* window.c: Fix last fix.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-23 Chong Yidong <cyd@gnu.org>
2
3 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4 call when setting menu-bar-lines and tool-bar-lines parameters.
5 (unwind_create_frame_1): New helper function.
6
7 * window.c (inhibit_window_configuration_change_hook): New var.
8 (run_window_configuration_change_hook): Obey it.
9 (syms_of_window): Initialize it.
10
11 2012-02-22 Chong Yidong <cyd@gnu.org>
12
13 * xterm.c (x_draw_image_relief): Add missing type check for
14 Vtool_bar_button_margin (Bug#10743).
15
16 2012-02-21 Chong Yidong <cyd@gnu.org>
17
18 * fileio.c (Vfile_name_handler_alist): Doc fix.
19
20 * buffer.c (Fget_file_buffer): Protect against invalid file
21 handler return value.
22
23 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
24
25 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
26 when computing $valmask.
27
28 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
29 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
30 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
31 It's useless in that case, and it can cause problems on hosts
32 that allocate halves of EMACS_INT values separately.
33 Reported by Dan Horák. Diagnosed by Andreas Schwab in
34 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
35 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
36 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
37 it avoids undefined behavior on hosts where shifting right by more
38 than the word width has undefined behavior.
39
40 2012-02-19 Chong Yidong <cyd@gnu.org>
41
42 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
43 (Funhandled_file_name_directory, Ffile_name_as_directory)
44 (Fdirectory_file_name, Fexpand_file_name)
45 (Fsubstitute_in_file_name): Protect against invalid file handler
46 return values (Bug#10845).
47
48 2012-02-18 Eli Zaretskii <eliz@gnu.org>
49
50 * .gdbinit (pitx): Fix incorrect references to fields of the
51 iterator stack.
52
53 2012-02-17 Chong Yidong <cyd@gnu.org>
54
55 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
56
57 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
58
59 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
60 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
61
62 2012-02-15 Chong Yidong <cyd@gnu.org>
63
64 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
65 marked as special. Also, starting docstrings with * is obsolete.
66
67 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
68
69 * gnutls.c (emacs_gnutls_write): Fix last change.
70
71 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
72
73 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
74 send_process.
75
76 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
77
78 * keymap.c (Fsingle_key_description): Handle char ranges.
79
80 2012-02-12 Chong Yidong <cyd@gnu.org>
81
82 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
83 as that creates a dangerous corner case.
84
85 * window.c (Fdelete_window_internal): Invalidate the mouse
86 highlight (Bug#9904).
87
88 2012-02-12 Glenn Morris <rgm@gnu.org>
89
90 * xselect.c (Fx_own_selection_internal)
91 (Fx_get_selection_internal, Fx_disown_selection_internal)
92 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
93 * nsselect.m (Fx_own_selection_internal)
94 (Fx_disown_selection_internal, Fx_selection_exists_p)
95 (Fx_selection_owner_p, Fx_get_selection_internal):
96 Sync docs and argument specs with the xselect.c versions.
97
98 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
99
100 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
101
102 2012-02-11 Eli Zaretskii <eliz@gnu.org>
103
104 * w32select.c (Fx_selection_exists_p): Sync doc string and
105 argument list with xselect.c. (Bug#10783)
106
107 * w16select.c (Fx_selection_exists_p): Sync doc string and
108 argument list with xselect.c. (Bug#10783)
109
110 2012-02-10 Glenn Morris <rgm@gnu.org>
111
112 * fns.c (Fsecure_hash): Doc fix.
113
114 2012-02-09 Kenichi Handa <handa@m17n.org>
115
116 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
117
118 2012-02-07 Chong Yidong <cyd@gnu.org>
119
120 * buffer.c (Fbuffer_local_variables)
121 (buffer_lisp_local_variables): Handle unbound vars correctly;
122 don't let Qunbound leak into Lisp.
123
124 2012-02-07 Glenn Morris <rgm@gnu.org>
125
126 * image.c (Fimagemagick_types): Doc fix.
127
128 * image.c (imagemagick-render-type): Change it from a lisp object
129 to an integer. Move the doc here from the lisp manual.
130 Treat all values not equal to 0 the same.
131
132 2012-02-06 Chong Yidong <cyd@gnu.org>
133
134 * doc.c (store_function_docstring): Avoid applying docstring of
135 alias to base function (Bug#2603).
136
137 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
138
139 * .gdbinit (pp1, pv1): Remove redundant defines.
140 (pr): Use pp.
141
142 2012-02-04 Chong Yidong <cyd@gnu.org>
143
144 * nsterm.m: Declare a global (Bug#10694).
145
146 2012-02-04 Eli Zaretskii <eliz@gnu.org>
147
148 * w32.c (get_emacs_configuration_options): Include
149 --enable-checking, if specified, in the return value.
150
151 2012-02-04 Martin Rudalics <rudalics@gmx.at>
152
153 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
154 after rounding frame sizes. (Bug#9723)
155
156 2012-02-04 Eli Zaretskii <eliz@gnu.org>
157
158 * keyboard.c (adjust_point_for_property): Don't position point
159 before BEGV. (Bug#10696)
160
161 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
162
163 Handle overflow when computing char display width (Bug#9496).
164 * character.c (char_width): Return EMACS_INT, not int.
165 (char_width, c_string_width): Check for overflow when
166 computing the width; this is possible now that individual
167 characters can have unbounded width. Problem introduced
168 by merge from Emacs 23 on 2012-01-19.
169
170 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
171
172 * dbusbind.c (Fdbus_register_method): Mention the return value
173 :ignore in the docstring.
174
175 2012-02-02 Glenn Morris <rgm@gnu.org>
176
177 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
178
179 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
180 Unconditionally set to t. (Bug#10673)
181 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
182 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
183 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
184
185 2012-02-02 Kenichi Handa <handa@m17n.org>
186
187 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
188 0, do not call append_composite_glyph.
189
190 2012-02-02 Kenichi Handa <handa@m17n.org>
191
192 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
193 NULL (Bug#6988).
194 (x_produce_glyphs): If the component of a composition is a null
195 string, set it->pixel_width to 1 to avoid zero-width glyph.
196
197 2012-02-01 Eli Zaretskii <eliz@gnu.org>
198
199 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
200 first 2 arguments are identical. This makes inserting large
201 output from a subprocess an order of magnitude faster on
202 MS-Windows, where all sbrk'ed memory is always contiguous.
203
204 2012-01-31 Glenn Morris <rgm@gnu.org>
205
206 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
207 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
208 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
209
210 2012-01-29 Glenn Morris <rgm@gnu.org>
211
212 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
213
214 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
215
216 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
217
218 2012-01-28 Chong Yidong <cyd@gnu.org>
219
220 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
221
222 2012-01-26 Chong Yidong <cyd@gnu.org>
223
224 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
225
226 * search.c (Fsearch_forward, Fsearch_backward): Document negative
227 repeat counts (Bug#10507).
228
229 2012-01-26 Glenn Morris <rgm@gnu.org>
230
231 * lread.c (syms_of_lread): Doc fix.
232
233 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
234
235 * coding.c (encode_designation_at_bol): Change return value to
236 EMACS_INT.
237
238 2012-01-25 Chong Yidong <cyd@gnu.org>
239
240 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
241
242 2012-01-21 Chong Yidong <cyd@gnu.org>
243
244 * floatfns.c (Fcopysign): Make the second argument non-optional,
245 since nil is not allowed anyway.
246
247 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
248
249 * process.c (read_process_output): Use p instead of XPROCESS (proc).
250 (send_process): Likewise.
251
252 2012-01-19 Martin Rudalics <rudalics@gmx.at>
253
254 * window.c (save_window_save, Fcurrent_window_configuration)
255 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
256 doc-strings.
257
258 2012-01-19 Kenichi Handa <handa@m17n.org>
259
260 * character.c (char_width): New function.
261 (Fchar_width, c_string_width, lisp_string_width):
262 Use char_width (Bug#9496).
263
264 2012-01-16 Martin Rudalics <rudalics@gmx.at>
265
266 * window.c (Vwindow_persistent_parameters): New variable.
267 (Fset_window_configuration, save_window_save): Handle persistent
268 window parameters.
269
270 2012-01-14 Eli Zaretskii <eliz@gnu.org>
271
272 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
273 thrashing the stack of the thread. (Bug#9087)
274
275 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
276
277 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
278
279 2012-01-11 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (rows_from_pos_range): Handle the case where the
282 highlight ends on a newline. (Bug#10464)
283 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
284 he end column for display of highlight that ends on a newline
285 before a R2L line.
286
287 2012-01-11 Glenn Morris <rgm@gnu.org>
288
289 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
290 from load-path also when installation-directory is nil. (Bug#10208)
291
292 2012-01-10 Glenn Morris <rgm@gnu.org>
293
294 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
295
296 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
297 Update template values to be closer to their typical values these days.
298
299 2012-01-09 Eli Zaretskii <eliz@gnu.org>
300
301 * xdisp.c (rows_from_pos_range): Accept additional argument
302 DISP_STRING, and accept any glyph in a row whose object is that
303 string as eligible for mouse highlight. Fixes mouse highlight of
304 display strings from overlays. (Bug#10464)
305
306 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
307
308 emacs: fix an auto-save permissions race condition (Bug#10400)
309 * fileio.c (auto_saving_dir_umask): New static var.
310 (Fmake_directory_internal): Use it.
311 (do_auto_save_make_dir): Set it, instead of invoking chmod after
312 creating the directory. The old code temporarily assigns
313 too-generous permissions to the directory.
314 (do_auto_save_eh): Clear it.
315 (Fdo_auto_save): Catch all errors, not just file errors, so
316 that the var is always cleared.
317
318 2012-01-07 Eli Zaretskii <eliz@gnu.org>
319
320 * search.c (scan_buffer): Pass character positions to
321 know_region_cache, not byte positions. (Bug#6540)
322
323 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
324
325 * w32.c (sys_rename): Report EXDEV when rename of a directory
326 fails because the target is on another logical disk. (Bug#10284)
327
328 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
329
330 * xterm.c (x_embed_request_focus): New function.
331
332 * xterm.h: Add prototype.
333
334 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
335
336 2012-01-05 Glenn Morris <rgm@gnu.org>
337
338 * emacs.c (emacs_copyright): Update short copyright year to 2012.
339
340 2012-01-01 Eli Zaretskii <eliz@gnu.org>
341
342 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
343 Load gnutls_transport_set_lowat only if GnuTLS version is below
344 2.11.1.
345 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
346 GnuTLS versions below 2.11.1.
347
348 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
349
350 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
351 to the doc string advising against its use for altering the way
352 windows are scrolled.
353
354 2011-12-28 Kenichi Handa <handa@m17n.org>
355
356 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
357 coding-system ASCII compatible only when it does not produce BOM
358 on encoding (Bug#10383).
359
360 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
361
362 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
363 can scroll.
364 (create_and_show_popup_menu): Always use menu_position_func for
365 Gtk3 (Bug#10361).
366
367 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
368
369 * callint.c (Fcall_interactively): Don't truncate prompt string.
370
371 2011-12-23 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
374 property that ends at ZV, so that the bidi iteration could be
375 resumed from there (after widening). (Bug#10360)
376
377 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
378
379 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
380
381 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
382
383 * nsterm.m (x_free_frame_resources):
384 Release f->output_data.ns->miniimage.
385 (ns_index_color): Fix indentation. Do not retain
386 color_table->colors[i].
387
388 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
389 before returning.
390
391 * nsfns.m (x_set_background_color): Assign return value from
392 ns_index_color to face-background instead of NSColor*.
393 (ns_implicitly_set_icon_type): Fix indentation.
394 Change assignment in for loop to comparison.
395
396 * emacs.c (ns_pool): New variable.
397 (main): Assign ns_pool.
398 (Fkill_emacs): Call ns_release_autorelease_pool.
399
400 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
401 autorelease fdesc, release fdAttrs and tdict.
402 (ns_get_covering_families): Release charset.
403 (ns_findfonts): Release NSFontDescriptor created with new.
404 (ns_uni_to_glyphs): Fix indentation.
405 (setString): Release attrStr before assigning new value.
406
407 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
408
409 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
410 and NS_IMPL_COCOA.
411 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
412 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
413
414 2011-12-18 David Reitter <reitter@cmu.edu>
415
416 * nsterm.m (ns_term_init): Subscribe for notifications
417 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
418 to method trackingNotification in EmacsMenu.
419
420 * nsmenu.m (trackingMenu): New variable.
421 (trackingNotification): New method (from Aquamacs).
422 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
423 from Aquamacs (Bug#7030).
424
425 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
426
427 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
428 (symbol_to_nsstring): Fix indentation.
429 (ns_symbol_to_pb): New function.
430 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
431 (Fns_rotate_cut_buffers_internal): Removed.
432 (Fns_store_selection_internal): Renamed from
433 Fns_store_cut_buffer_internal.
434 (ns_get_foreign_selection, Fx_own_selection_internal)
435 (Fx_disown_selection_internal, Fx_selection_exists_p)
436 (Fns_get_selection_internal, Fns_store_selection_internal):
437 Use ns_symbol_to_pb and check if return value is nil.
438 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
439 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
440 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
441 renamed to Sns_store_selection_internal.
442 (ns_handle_selection_request): Move code to Fx_own_selection_internal
443 and remove this function.
444 (ns_handle_selection_clear): Remove, never used.
445 (Fx_own_selection_internal): Move code from ns_handle_selection_request
446 here.
447
448 2011-12-17 Ken Brown <kbrown@cornell.edu>
449
450 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
451 GID is unknown (Bug#10257).
452
453 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
454
455 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
456 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
457 which caused a build failure on GNU/Linux IA-64. This problem was
458 introduced by my 2011-10-07 patch.
459
460 2011-12-15 Juri Linkov <juri@jurta.org>
461
462 * image.c (imagemagick_error): New function. (Bug#10112)
463 (imagemagick_load_image): Comment out `MagickSetResolution' call.
464 Use `imagemagick_error' where ImageMagick functions return
465 `MagickFalse'.
466 (Fimagemagick_types): Add `Fnreverse' to return the list in the
467 proper order.
468
469 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
470
471 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
472 fill background (Bug#8992).
473
474 2011-12-13 Martin Rudalics <rudalics@gmx.at>
475
476 * window.c (Vwindow_combination_resize)
477 (Vwindow_combination_limit): Use t instead of non-nil in
478 doc-strings.
479 (Vrecenter_redisplay): Add first sentence of doc-string on
480 separate line.
481 (Frecenter): Fix doc-string typo.
482
483 2011-12-11 Kenichi Handa <handa@m17n.org>
484
485 * coding.c (Funencodable_char_position): Pay attention to the
486 buffer text relocation (Bug#9389).
487
488 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
489
490 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
491 gtk_init (Bug#10100).
492
493 2011-12-10 Eli Zaretskii <eliz@gnu.org>
494
495 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
496 IT->string is nil. (Bug#10263)
497
498 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
499
500 * nsterm.h (x_free_frame_resources): Declare.
501
502 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
503 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
504
505 * nsterm.h (ns_get_defaults_value): Declare.
506
507 * nsterm.m (ns_default): Call ns_get_defaults_value.
508
509 2011-12-09 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
512 (Bug#10170)
513
514 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
515
516 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
517 that where the value of an _OBJC_* symbol points to is in the .bss
518 section (Bug#10240).
519
520 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
521
522 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
523 after the loop to call ccl_driver at least once (Bug#8619).
524
525 2011-12-08 Kenichi Handa <handa@m17n.org>
526
527 * ftfont.c (get_adstyle_property): Fix previous change
528 (Bug#10233).
529
530 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
531
532 * w32.c (init_environment): If no_site_lisp, remove site-lisp
533 dirs from the default value of EMACSLOADPATH (bug#10208).
534
535 2011-12-07 Glenn Morris <rgm@gnu.org>
536
537 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
538 installation and source directories as well. (Bug#10208)
539
540 2011-12-06 Chong Yidong <cyd@gnu.org>
541
542 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
543
544 2011-12-06 Glenn Morris <rgm@gnu.org>
545
546 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
547 as an error, not just -1. (Bug#10217)
548
549 2011-12-05 Chong Yidong <cyd@gnu.org>
550
551 * keyboard.c (process_special_events): New function.
552 (swallow_events, Finput_pending_p): Use it (Bug#10195).
553
554 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
555
556 * coding.c (encode_designation_at_bol): Don't use uninitialized
557 local variable (Bug#9318).
558
559 2011-12-05 Kenichi Handa <handa@m17n.org>
560
561 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
562 return Qnil (Bug#8046, Bug#10193).
563
564 2011-12-05 Kenichi Handa <handa@m17n.org>
565
566 * coding.c (encode_designation_at_bol): New args charbuf_end and
567 dst. Return the number of produced bytes. Callers changed.
568 (coding_set_source): Return how many bytes coding->source was
569 relocated.
570 (coding_set_destination): Return how many bytes
571 coding->destination was relocated.
572 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
573 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
574
575 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
576
577 * coding.c (CODING_CHAR_CHARSET_P): New macro.
578 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
579 macro (Bug#9318).
580
581 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
582
583 The following changes are to fix Bug#9318.
584
585 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
586 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
587 (encode_coding_iso_2022, encode_coding_sjis)
588 (encode_coding_big5, encode_coding_charset): Use the above macros.
589
590 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
591
592 * lisp.h (process_quit_flag): Fix external declaration.
593
594 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 Don't macro-inline non-performance-critical code.
597 * eval.c (process_quit_flag): New function.
598 * lisp.h (QUIT): Use it.
599
600 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
601
602 * nsfns.m (get_geometry_from_preferences): New function.
603 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
604
605 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
606
607 * emacs.c (Qkill_emacs): Define.
608 (syms_of_emacs): Initialize it.
609 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
610 Qquit_flag to `kill-emacs' instead.
611 (quit_throw_to_read_char): Add parameter `from_signal'.
612 All callers changed. Call Fkill_emacs if requested and safe.
613 * lisp.h (QUIT): Call Fkill_emacs if requested.
614
615 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
616
617 * widget.c (update_wm_hints): Return if wmshell is null.
618 (widget_update_wm_size_hints): New function.
619
620 * widget.h (widget_update_wm_size_hints): Declare.
621
622 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
623 widget_update_wm_size_hints (Bug#10104).
624
625 2011-12-03 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (handle_invisible_prop): If the invisible text ends just
628 before a newline, prepare the bidi iterator for consuming the
629 newline, and keep the current paragraph direction. (Bug#10183)
630 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
631
632 2011-12-02 Juri Linkov <juri@jurta.org>
633
634 * search.c (Fword_search_regexp): New Lisp function created from
635 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
636 (Fword_search_backward, Fword_search_forward)
637 (Fword_search_backward_lax, Fword_search_forward_lax):
638 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
639 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
640
641 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
642
643 * fileio.c (Finsert_file_contents): Move after-change-function call
644 to before the "handled:" label, since all "goto handled" appear in
645 cases where the *-change-functions have already been properly called
646 (bug#10117).
647
648 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
649
650 * keyboard.c (interrupt_signal): Don't call kill-emacs when
651 waiting for input. (Bug#10169)
652
653 2011-11-30 Eli Zaretskii <eliz@gnu.org>
654
655 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
656 verifies glyph row's hash code--we have just reallocated the
657 glyphs, so their contents can be complete garbage. (Bug#10164)
658
659 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
660
661 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
662
663 2011-11-30 Eli Zaretskii <eliz@gnu.org>
664
665 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
666 attributes are tested _before_ calling verify_row_hash, to protect
667 against GCC re-ordering of the tests. (Bug#10164)
668
669 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
670
671 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
672
673 * xterm.c (handle_one_xevent): Only set async_visible and friends
674 if net_wm_state_hidden_seen is non-zero (Bug#10002)
675 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
676 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
677
678 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
679
680 Remove GCPRO-related macros that exist only to avoid shadowing locals.
681 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
682 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
683 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
684 All uses changed to use GCPRO1 etc.
685 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
686 Revert to old implementation (i.e., before 2011-03-11).
687
688 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
689
690 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
691 of scroll runs so as to avoid assigning disabled bogus rows and
692 unnecessary graphics copy operations.
693
694 2011-11-27 Eli Zaretskii <eliz@gnu.org>
695
696 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
697 (snprintf) [_MSC_VER]: Redirect to _snprintf.
698 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
699 (malloc, free, realloc, calloc): Redirect to e_* only when
700 compiling Emacs.
701
702 * lisp.h (GCTYPEBITS): Move before first use.
703 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
704 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
705 this macro definition.
706
707 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
708 _MSC_VER.
709
710 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
711
712 * gtkutil.c (xg_create_frame_widgets):
713 Call gtk_window_set_has_resize_grip (FALSE) if that function is
714 present with Gtk+ 2.0.
715
716 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
717
718 * fileio.c (Finsert_file_contents): Undo previous change; see
719 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
720
721 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
722
723 Rename locals to avoid shadowing.
724 * fileio.c (Finsert_file_contents):
725 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
726 * process.c (wait_reading_process_output):
727 Rename inner 'proc' to 'p' to avoid shadowing.
728 Indent for consistency with usual Emacs style.
729
730 2011-11-25 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (redisplay_window): If cursor row is not fully visible
733 after recentering, and scroll-conservatively is set to a large
734 number, scroll window by a few more lines to make the cursor fully
735 visible and out of scroll-margin. (Bug#10105)
736 (start_display): Don't move to the next line if the display should
737 start at a newline that is part of a display vector or an overlay
738 string. (Bug#10119)
739
740 2011-11-24 Juri Linkov <juri@jurta.org>
741
742 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
743 after the `MagickPingImage' call. (Bug#10112)
744
745 2011-11-23 Chong Yidong <cyd@gnu.org>
746
747 * window.c (Fcoordinates_in_window_p): Accept only live windows.
748
749 2011-11-23 Martin Rudalics <rudalics@gmx.at>
750
751 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
752 making another buffer current. (Bug#10114)
753
754 2011-11-23 Glenn Morris <rgm@gnu.org>
755
756 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
757
758 2011-11-23 Chong Yidong <cyd@gnu.org>
759
760 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
761 using it (Bug#5984).
762
763 2011-11-22 Eli Zaretskii <eliz@gnu.org>
764
765 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
766 and header-lines, as they don't have one computed for them.
767 (Bug#10098)
768
769 * .gdbinit (prow): Make displayed values more self-explaining.
770 Add row's hash code.
771
772 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
773
774 * process.c (wait_reading_process_output): Fix asynchrounous
775 GnuTLS socket handling on some versions of the GnuTLS library.
776 (wait_reading_process_output): Add comment and URL.
777
778 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
779
780 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
781
782 2011-11-21 Chong Yidong <cyd@gnu.org>
783
784 * window.c (Fnext_window, Fprevious_window): Doc fix.
785
786 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
787
788 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
789
790 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
791
792 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
793
794 2011-11-20 Martin Rudalics <rudalics@gmx.at>
795
796 * window.c (Fset_window_combination_limit): Rename argument
797 STATUS to LIMIT.
798 (Vwindow_combination_limit): Remove "status" from doc-string.
799
800 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
801
802 * m/ibms390.h: Remove.
803 * m/ibms390x.h: Don't include "ibms390.h".
804
805 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
806
807 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
808 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
809
810 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
811
812 * casetab.c (Fset_case_table):
813 * charset.c (Fcharset_after): Fix typos.
814
815 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
816
817 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
818 Otherwise, valgrind does not work on some platforms.
819 Problem reported by Andreas Schwab in
820 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
821 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
822 is set, removing the need for VIRT_ADDRESS_VARIES.
823 (PURE_P): Use a more-efficient implementation that needs just one
824 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
825 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
826 to 4 (xorl, subq, cmpq, setbe).
827 * alloc.c (pure): Always extern now, since that's the
828 VIRT_ADDR_VARIES behavior.
829 (PURE_POINTER_P): Use a single comparison, not two, for
830 consistency with the new puresize.h.
831 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
832 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
833 Remove VIRT_ADDR_VARIES no longer needed.
834
835 2011-11-19 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
838 (erase_phys_cursor, update_window_cursor, show_mouse_face)
839 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
840 behave as if the cursor position were at the window margin.
841
842 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
843 and the cursor position is out of bounds, behave as if the cursor
844 position were at the window margin. (Bug#10075)
845
846 2011-11-18 Chong Yidong <cyd@gnu.org>
847
848 * window.c (Fwindow_combination_limit): Make first argument
849 non-optional, since it is meaningless for live windows like the
850 selected window.
851
852 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
855
856 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 * intervals.c: Fix grafting over the whole buffer (bug#10071).
859 (graft_intervals_into_buffer): Simplify.
860
861 2011-11-18 Eli Zaretskii <eliz@gnu.org>
862
863 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
864 hash values of the two rows.
865 (copy_row_except_pointers): Preserve the used[] arrays and the
866 hash values of the two rows. (Bug#10035)
867 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
868
869 * xdisp.c (row_hash): New function, body extracted from
870 compute_line_metrics.
871 (compute_line_metrics): Call row_hash, instead of computing the
872 hash code inline.
873
874 * dispnew.c (verify_row_hash): Call row_hash for computing the
875 hash code of a row, instead of duplicating code from xdisp.c.
876
877 * dispextern.h (row_hash): Add prototype.
878
879 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
880
881 * frame.c (delete_frame): Don't delete the terminal when the last
882 X frame is closed if emacs is built with GTK toolkit.
883
884 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
885
886 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
887
888 2011-11-17 Martin Rudalics <rudalics@gmx.at>
889
890 * window.c (Vwindow_splits): Rename to
891 Vwindow_combination_resize. Suggested by Juri Linkov.
892 (Fsplit_window_internal): Use Vwindow_combination_resize instead
893 of Vwindow_splits.
894
895 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
896
897 * nsfns.m (Fns_font_name):
898 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
899
900 2011-11-16 Martin Rudalics <rudalics@gmx.at>
901
902 * window.h (window): Rename slot "nest" to "combination_limit".
903 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
904 (Fset_window_nest): Rename to Fset_window_combination_limit.
905 (Vwindow_nest): Rename to Vwindow_combination_limit.
906 (recombine_windows, make_parent_window, make_window)
907 (Fsplit_window_internal, saved_window)
908 (Fset_window_configuration, save_window_save): Rename all
909 occurrences of window_nest to window_combination_limit.
910
911 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
912
913 * image.c (imagemagick_load_image): Fix typo.
914
915 2011-11-14 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (display_line): Move the call to
918 highlight_trailing_whitespace before the call to
919 compute_line_metrics, since the latter needs to see the final
920 faces of all the glyphs to compute ROW's hash value.
921 Fixes assertion violations in row_equal_p. (Bug#10035)
922
923 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
924
925 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
926 just return (bug#10044).
927
928 2011-11-12 Eli Zaretskii <eliz@gnu.org>
929
930 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
931 with user-defined heap size. Bump the default size of the temacs
932 heap to 27MB, to avoid memory warning when running temacs.
933 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
934
935 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
936 current_matrix and desired_matrix. (Bug#9990)
937 (verify_row_hash) [XASSERTS]: New function.
938 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
939 that the hash value of glyph rows is correct.
940
941 2011-11-12 Martin Rudalics <rudalics@gmx.at>
942
943 * window.h (window): Remove splits slot.
944 * window.c (Fwindow_splits, Fset_window_splits): Remove.
945 (Fdelete_other_windows_internal, make_parent_window)
946 (make_window, Fsplit_window_internal, Fdelete_window_internal)
947 (Fset_window_configuration, save_window_save): Don't deal with
948 split status of windows.
949 (saved_window): Remove splits slot.
950 (Vwindow_splits): Rewrite doc-string.
951
952 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
953
954 * xfns.c (unwind_create_frame):
955 * nsfns.m (unwind_create_frame):
956 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
957 Vframe_list (Bug#9999).
958
959 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
960
961 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
962
963 2011-11-11 Kenichi Handa <handa@m17n.org>
964
965 * callproc.c (Fcall_process): Set the member dst_multibyte of
966 process_coding.
967
968 2011-11-11 Johan Bockgård <bojohan@gnu.org>
969
970 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
971 avoid a crash (bug#9496).
972
973 2011-11-09 Chong Yidong <cyd@gnu.org>
974
975 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
976 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
977
978 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
979
980 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
981
982 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
983
984 Avoid some portability problems by eschewing 'extern inline' functions.
985 The trivial performance wins aren't worth the portability hassles; see
986 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
987 et seq.
988 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
989 (window_box_width, window_box_left, window_box_left_offset)
990 (window_box_right, window_box_right_offset): Undo previous change,
991 by removing the "extern"s.
992 * intervals.c (adjust_intervals_for_insertion)
993 (adjust_intervals_for_deletion): Undo previous change,
994 making these static again.
995 (offset_intervals, temp_set_point_both, temp_set_point)
996 (copy_intervals_to_string): No longer inline.
997 * xdisp.c (window_text_bottom_y, window_box_width)
998 (window_box_height, window_box_left_offset)
999 (window_box_right_offset, window_box_left, window_box_right)
1000 (window_box): No longer inline.
1001
1002 2011-11-08 Chong Yidong <cyd@gnu.org>
1003
1004 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1005 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1006 Signal an error if not a live window.
1007 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1008 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1009
1010 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * lisp.h (syms_of_abbrev): Remove declaration.
1013 Reported by CHENG Gao <chenggao@royau.me>.
1014
1015 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1016
1017 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1018 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1019 of temacs in GUI mode.
1020
1021 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1022
1023 * window.h: Declare delete_all_child_windows instead of
1024 delete_all_subwindows.
1025 * window.c (Fwindow_nest, Fset_window_nest)
1026 (Fset_window_new_total, Fset_window_new_normal)
1027 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1028 (delete_all_subwindows): Rename to delete_all_child_windows.
1029 (Fdelete_other_windows_internal, Fset_window_configuration):
1030 Call delete_all_child_windows instead of delete_all_subwindows.
1031 * frame.c (delete_frame): Call delete_all_child_windows instead
1032 of delete_all_subwindows.
1033
1034 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1037 This is also needed for porting to any host where GC_MARK_STACK is
1038 not GC_MAKE_GCPROS_NOOPS.
1039 (which_symbols): Use it.
1040
1041 2011-11-07 Kenichi Handa <handa@m17n.org>
1042
1043 * coding.c (coding_set_destination): Check coding->src_pos only
1044 when coding->src_object is a buffer (bug#9910).
1045
1046 * process.c (send_process): Set the member src_multibyte of coding
1047 to 0 (bug#9911) when sending a unibyte text.
1048
1049 * callproc.c (Fcall_process): Set the member src_multibyte of
1050 process_coding to 0 (bug#9912).
1051
1052 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1053
1054 * xmenu.c (cleanup_widget_value_tree): New function.
1055 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1056 calling free_menubar_widget_value_tree directly (Bug#9830).
1057
1058 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 Fix some portability problems with 'inline'.
1061 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1062 (window_box_width, window_box_left, window_box_left_offset)
1063 (window_box_right, window_box_right_offset): Declare extern.
1064 Otherwise, these inline functions do not conform to C99 and
1065 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1067 * intervals.c (adjust_intervals_for_insertion)
1068 (adjust_intervals_for_deletion): Now extern, because otherwise the
1069 extern inline functions 'offset_intervals' couldn't refer to it.
1070 (static_offset_intervals): Remove.
1071 (offset_intervals): Rewrite using the old contents of
1072 static_offset_intervals. The old version didn't conform to C99
1073 because an extern inline function contained a reference to an
1074 identifier with static linkage.
1075
1076 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1079 GC.
1080
1081 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1084 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1085 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1086 return Qleft_to_right.
1087
1088 2011-11-06 Chong Yidong <cyd@gnu.org>
1089
1090 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1091 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1092 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1093 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1094 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1095 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1096 (Fwindow_vscroll): Doc fix.
1097 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1098 argument, since it makes no sense to pass a live window and for
1099 consistency with window-child.
1100
1101 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1102
1103 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1104 support MSVC.
1105
1106 2011-11-05 Jason Rumney <jasonr@gnu.org>
1107
1108 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1109 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1110 fonts (Bug#6029).
1111 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1112 bitwise arithmetic preventing use of unicode-sip and non-truetype
1113 opentype fonts.
1114
1115 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1116
1117 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1118 "emacs"-only part.
1119
1120 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1121 initialization code to keep similarity to xfns.c after changes
1122 from 2011-11-05.
1123
1124 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1127 (unwind_create_frame): New function (Bug#9943).
1128 (Fx_create_frame): Restructure code to be more similar to the one in
1129 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1130 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1131 Move terminal->reference_count++ just before making the frame official
1132 (Bug#9943).
1133
1134 * nsterm.m (x_free_frame_resources): New function.
1135 (x_destroy_window): Move code to x_free_frame_resources.
1136
1137 * xfns.c (unwind_create_frame): Fix comment.
1138 (Fx_create_frame, x_create_tip_frame):
1139 Move terminal->reference_count++ just before making the frame
1140 official. Move initialization of image_cache_refcount and
1141 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1142
1143 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1144
1145 Support MSVC build with newer versions of Visual Studio.
1146 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1147 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1148 nt/gmake.defs.
1149
1150 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1151 which are not supported by MSVC.
1152 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1153 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1154 bitfields.
1155 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1156 types in bitfields.
1157 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1158
1159 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1160
1161 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1162
1163 Support MSVC build with newer versions of Visual Studio.
1164 * w32.c: Don't include w32api.h for MSVC.
1165 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1166
1167 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1168 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1169 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1170 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1171 e_* cousins.
1172 (alloca) [_MSC_VER]: Define to _alloca.
1173
1174 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1175
1176 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1177
1178 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (note_mouse_highlight): If either of
1181 previous/next-single-property-change returns nil, treat that as
1182 the beginning or the end of the buffer. (Bug#9955)
1183
1184 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1187 label is not null (Bug#9951).
1188 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1189 may be NULL.
1190
1191 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1192
1193 * window.c (Fwindow_body_size): Mention in the doc string that the
1194 return value is in frame's canonical units. (Bug#9949)
1195
1196 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1199
1200 * w32fns.c (unwind_create_frame): If needed, free the glyph
1201 matrices of the partially constructed frame. (Bug#9943)
1202 * xfns.c (unwind_create_frame): Likewise.
1203
1204 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1205
1206 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1207 Don't stop backward scan on the continuation glyph, even though
1208 its CHARPOS is positive.
1209 (mouse_face_from_buffer_pos, note_mouse_highlight):
1210 Rename cover_string to disp_string.
1211
1212 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1213
1214 * window.c (temp_output_buffer_show): Don't use
1215 Vtemp_buffer_show_specifiers.
1216 (Vtemp_buffer_show_specifiers): Remove unused variable.
1217
1218 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1221 past the beginning of the current glyph matrix.
1222
1223 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1224
1225 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1226 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1227 HAVE_GTK3 (Bug#9869).
1228
1229 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1230 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1231
1232 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1233
1234 * xterm.c: Declare x_handle_net_wm_state to return int.
1235 (handle_one_xevent): Check if we are iconified but don't have
1236 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1237 (get_current_wm_state): Return non-zero if not hidden,
1238 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1239 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1240 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1241 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1242
1243 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1246 so that this new function doesn't get optimized away by a
1247 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1248
1249 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1252
1253 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1254
1255 Fix the `xbytecode' command.
1256 * .gdbinit (xprintbytestr): New command.
1257 (xwhichsymbols): Rename from `which'; all callers changed.
1258 (xbytecode): Print the byte-code string as well.
1259
1260 2011-10-29 Kim Storm <storm@cua.dk>
1261
1262 * alloc.c (which_symbols): New function.
1263
1264 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1265
1266 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1267 line. (Bug#9903)
1268
1269 2011-10-29 Glenn Morris <rgm@gnu.org>
1270
1271 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1272 Not clear what it was for, and it causes various bugs. (Bug#9839)
1273
1274 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1277 possible random value that matches one of those tested as
1278 condition to clear the mouse face.
1279
1280 2011-10-28 Chong Yidong <cyd@gnu.org>
1281
1282 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1283
1284 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1285
1286 * window.c (make_window): Initialize phys_cursor_on_p.
1287
1288 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1289
1290 * lisp.h (struct Lisp_Symbol): Update comments.
1291
1292 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1295
1296 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1297
1298 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1299 <oslsachem@gmail.com> for helping to debug this.
1300
1301 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1302 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1303 (g_b_init_get_glyph_outline_w): New static variables.
1304 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1305 (GetGlyphOutlineW_Proc): New typedefs.
1306 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1307 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1308 New functions.
1309 (w32font_open_internal, compute_metrics):
1310 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1311 instead of calling the "wide" APIs directly.
1312
1313 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1314
1315 * w32.h (syms_of_w32font): Add prototype.
1316
1317 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1320 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1321 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1322 (Fmove_to_window_line): Doc fix.
1323
1324 2011-10-27 Chong Yidong <cyd@gnu.org>
1325
1326 * process.c (make_process): Set gnutls_state to NULL.
1327
1328 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1329 non-NULL, regardless of GNUTLS_INITSTAGE.
1330 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1331 an error. Set process slots as soon as we allocate them.
1332
1333 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1334
1335 2011-10-27 Chong Yidong <cyd@gnu.org>
1336
1337 * gnutls.c (emacs_gnutls_deinit): New function.
1338 Deallocate credentials structures as well as calling gnutls_deinit.
1339 (Fgnutls_deinit, Fgnutls_boot): Use it.
1340
1341 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1342 (deactivate_process): Call emacs_gnutls_deinit.
1343
1344 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * image.c (x_create_x_image_and_pixmap):
1347 * w32.c (sys_rename, w32_delayed_load):
1348 * w32font.c (fill_in_logfont):
1349 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1350
1351 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * w32fns.c (w32_default_color_map): New function,
1354 extracted from Fw32_default_color_map.
1355 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1356
1357 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1360
1361 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * keyboard.c (test_undefined): New function (bug#9751).
1364 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1365
1366 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1367
1368 * sysdep.c (init_sys_modes): Fix the check for the controlling
1369 terminal (Bug#6649).
1370
1371 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1372
1373 * dispextern.h (struct bidi_it): New member next_en_type.
1374
1375 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1376 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1377 current character, check also for next_en_type being WEAK_EN.
1378 (bidi_resolve_weak): Don't enter the expensive loop if the current
1379 position is before next_en_pos. Record the bidi type of the first
1380 non-ET, non-BN character we find, in addition to its position.
1381 (bidi_level_of_next_char): Invalidate next_en_type when
1382 next_en_pos is over-stepped.
1383
1384 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1387 * editfns.c: Rewrite current-time-zone so that it invokes
1388 the equivalent of (format-time-string "%Z") to get the time zone name.
1389 This fixes a bug when the time zone name contains characters that
1390 need converting from the system time locale to Emacs internal format.
1391 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1392 that patch fixed format-time-string to do the conversion, but
1393 I forgot to fix current-time-zone.
1394 (format_time_string): New function, containing most of
1395 what Fformat_time_string used to contain.
1396 (Fformat_time_string): Rewrite in terms of format_time_string.
1397 This doesn't change this function's behavior.
1398 (current-time-zone): Rewrite to use format_time_string.
1399 This fixes the bug reported by Michael Schierl in
1400 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1401 Jason Rumney's 2007-06-07 change worked around this bug, but
1402 didn't fix it.
1403 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1404
1405 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1406
1407 * xdisp.c (start_display): If the character at POS is displayed
1408 via a display vector, reset IT->current.dpvec_index to zero.
1409 (try_window_reusing_current_matrix): If a line ends in a display
1410 vector or the next line starts in a display vector, continue
1411 redrawing the window even though the character position of
1412 start_row was reached.
1413 (Bug#9771, part 2)
1414
1415 2011-10-18 Chong Yidong <cyd@gnu.org>
1416
1417 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1418 with nobreak-char-display too.
1419
1420 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1421
1422 Fix part 3 of bug#9771.
1423 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1424 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1425 non-neutral characters if the current character is a paragraph
1426 separator (a.k.a. Newline). This avoids running the same
1427 expensive loop twice, once when we consume the preceding newline
1428 and the other time when the line actually needs to be displayed.
1429 Avoid the loop when we see neutrals on the base embedding level
1430 following a character whose directionality is the same as the
1431 paragraph's. This avoids running the expensive loop when a line
1432 ends in a long sequence of neutrals, like control characters.
1433 Add assertion against STRONG_AL type. Slightly rearrange code
1434 that determines the type of a neutral given the first non-neutral
1435 that follows it.
1436 (bidi_level_of_next_char): Set next_en_pos to zero when
1437 invalidating its info.
1438
1439 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1440
1441 * xdisp.c (push_display_prop): Determine whether to record string
1442 or buffer position by IT->string, not by IT->method. Allow
1443 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1444 (move_it_vertically_backward): Don't look for character position
1445 immediately after the newline when in a continuation line.
1446 (Bug#9771, part 1)
1447
1448 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1449
1450 * window.c (coordinates_in_window): Rewrite and delabelize
1451 vertical border check. (Bug#5357) (Bug#9618)
1452
1453 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1454
1455 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1456 errors in XSetWindowBorder (bug#9310).
1457
1458 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1461 avoid crash when xmalloc overrun checking is enabled.
1462
1463 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1464
1465 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1466 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1467 cursor motion with <left> and <right> arrow keys.
1468
1469 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1470 some callers set that themselves.
1471
1472 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1475 display string and the previous row comes from the same string and
1476 is empty. (Bug#9739) (Bug#9738)
1477
1478 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1479
1480 * doc.c (get_doc_string): Encode file name (bug#9735).
1481
1482 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1483
1484 * bidi.c (bidi_level_of_next_char):
1485 * xdisp.c (get_visually_first_element): Remove old incorrect
1486 comments regarding the Unicode Line Separator character.
1487
1488 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1489
1490 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1491
1492 * alloc.c (Fgc_status): Do not access beyond zombies array
1493 boundary if nzombies > MAX_ZOMBIES.
1494 * alloc.c (dump_zombies): Add missing format specifier.
1495
1496 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1499 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1500
1501 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1502 Some packages use them to denote characters with modifiers.
1503
1504 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1505
1506 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1507 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1508 matching a pp-number. Rename parameter var to var1.
1509
1510 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1511
1512 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1513
1514 2011-10-08 Glenn Morris <rgm@gnu.org>
1515
1516 * callint.c (Fcall_interactively): Give a more explicit error for the
1517 'c' case with a non-character input. (Bug#8479)
1518
1519 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1522 lines.
1523 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1524 lines that are hscrolled on the left.
1525
1526 * dispnew.c (buffer_posn_from_coords): Account for a possible
1527 presence of header-line. (Bug#4426)
1528
1529 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1532 Don't advertise functionality which we discourage or doesn't work.
1533
1534 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1537 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1538 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1539 this makes Emacs dump core during garbage collection on rare
1540 occasions. sizeof is obviously inferior to offsetof here, so
1541 stick with offsetof.
1542 (GC_POINTER_ALIGNMENT): New macro.
1543 (mark_memory): Omit 3rd (offset) arg; caller changed.
1544 Don't assume EMACS_INT alignment is the same as pointer alignment.
1545
1546 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1547
1548 * keyboard.c (read_key_sequence_remapped): New var.
1549 (read_key_sequence): Compute remapping in the right buffer.
1550 (command_loop_1): Use read_key_sequence's remapping directly.
1551
1552 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1553
1554 * dired.c (file_name_completion): Don't expand file name.
1555 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1556 before checking file name handler.
1557
1558 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1559 they've been requested explicitly (bug#9591).
1560
1561 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1562
1563 * keymap.c (Fsingle_key_description): Use make_specified_string
1564 instead of build_string to build string from push_key_description.
1565 (Bug#5193)
1566
1567 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1570 This fixes a Y2038 bug on 64-bit hosts.
1571 * buffer.c (reset_buffer):
1572 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1573 (Fclear_buffer_auto_save_failure):
1574 Use 0, not -1, to represent an unset failure time, since time_t
1575 might not be signed.
1576
1577 Remove dependency on glibc malloc internals.
1578 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1579 Move back here from lisp.h, but with their new implementations.
1580 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1581 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1582 * charset.c (charset_table_init): New static var.
1583 (syms_of_charset): Use it instead of xmalloc. This removes a
1584 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1585 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1586 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1587 Move back to alloc.c.
1588 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1589 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1590
1591 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1592
1593 * nsterm.m (windowDidResize): Call x_set_window_size only when
1594 ns_in_resize is true. Otherwise set pixelwidth/height and
1595 call change_frame_size (Bug#9628).
1596
1597 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 Port --enable-checking=all to Fedora 14 x86-64.
1600 * charset.c (syms_of_charset): Also account for glibc malloc's
1601 internal overhead when calculating the initial malloc maximum.
1602
1603 Port --enable-checking=all to Fedora 14 x86.
1604 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1605 Move to lisp.h.
1606 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1607 (overrun_check_realloc, overrun_check_free):
1608 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1609 That way, xmalloc returns a properly-aligned pointer even if
1610 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1611 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1612 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1613 into account when calculating the initial malloc maximum.
1614 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1615 Move here from alloc.c, so that charset.c can use it too.
1616 Properly align; the old code wasn't right for common 32-bit hosts
1617 when configured with --enable-checking=all.
1618 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1619 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1620
1621 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1622
1623 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1624 use EDOM.
1625
1626 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1627
1628 * xdisp.c (compute_display_string_end): If there's no display
1629 string at CHARPOS, return -1.
1630
1631 * bidi.c (bidi_fetch_char): When compute_display_string_end
1632 returns a negative value, treat the character as a normal
1633 character not covered by a display string. (Bug#9624)
1634
1635 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * lread.c (Fread_from_string): Fix typo in docstring.
1638
1639 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1642 newline, reseat the iterator instead of bidi-iterating there one
1643 character at a time. (Bug#9610)
1644 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1645 TO_CHARPOS if the bidi iterator is at base embedding level.
1646
1647 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * lread.c (readevalloop): Use correct code for NBSP.
1650 (read1): Likewise. (Bug#9608)
1651
1652 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1653
1654 * dbusbind.c (Fdbus_register_signal): When service is not
1655 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1656
1657 2011-09-25 Glenn Morris <rgm@gnu.org>
1658
1659 * buffer.c (truncate-lines): Doc fix.
1660
1661 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1664 (Fset_window_next_buffers): Doc fix.
1665
1666 2011-09-24 Glenn Morris <rgm@gnu.org>
1667
1668 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1669
1670 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 Fix minor problems found by static checking.
1673 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1674 * indent.c (Fvertical_motion): Fix == vs = typo.
1675
1676 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1677
1678 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1679 Default value is now t. Doc fix.
1680
1681 * indent.c (Fvertical_motion): Compute and apply the overshoot
1682 logic when moving up, not only when moving down. Fix the
1683 confusing name and values of the it_overshoot_expected variable;
1684 logic changes accordingly. (Bug#9254) (Bug#9549)
1685
1686 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1687 CHARPOS is covered by a display string which includes newlines.
1688 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1689 is covered by a display string with embedded newlines.
1690
1691 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1692
1693 * dbusbind.c (Fdbus_register_signal): Add match rule to
1694 Vdbus_registered_objects_table. (Bug#9581)
1695 (Fdbus_register_method, Vdbus_registered_objects_table):
1696 Fix docstring.
1697
1698 2011-09-24 Jim Meyering <meyering@redhat.com>
1699
1700 do not ignore write error for any output size
1701 The previous change was incomplete.
1702 While it makes emacs --batch detect the vast majority of stdout
1703 write failures, errors were still ignored whenever the output size is
1704 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1705 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1706 && echo FAIL: ignored write error
1707 FAIL: ignored write error
1708 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1709 && echo FAIL: ignored write error
1710 FAIL: ignored write error
1711 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1712
1713 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * emacs.c (Fkill_emacs): In noninteractive mode exit
1716 non-successfully if a write error occurred on stdout. (Bug#9574)
1717
1718 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1719
1720 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1721 the xassert test.
1722
1723 * dispextern.h (struct it): Update the comment documenting what
1724 can it->OBJECT be.
1725
1726 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1729 a display string, extend search for cursor position to end of row.
1730 (find_row_edges): If the row ends in a newline from a display
1731 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1732 Handle the case of a display string with multiple newlines.
1733 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1734 non-empty line. Fixes confusing cursor motion with arrow keys at
1735 the beginning of a line that starts with whitespace.
1736
1737 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1738
1739 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1740 (bug#9493).
1741
1742 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1745 boolean (Bug#9154).
1746
1747 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1748
1749 * xdisp.c (display_line): Record maximum and minimum buffer
1750 positions even if no glyphs were produced (e.g., by a zero-width
1751 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1752 buffer positions that will be removed from the glyph row because
1753 they don't fit.
1754 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1755 column is beyond frame width: don't subtract 1 "pixel" when
1756 computing width of the stretch.
1757 (reseat_at_next_visible_line_start): Undo the change made on
1758 2011-09-17 that saved paragraph information and restored it after
1759 the call to `reseat'. (Bug#9545)
1760
1761 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1762
1763 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1764 and turn window cursor on if cleared (Bug#9415).
1765
1766 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1767
1768 * search.c (boyer_moore): Take unibyte characters from pattern
1769 literally. (Bug#9458)
1770
1771 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1772
1773 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1774
1775 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 Fix minor problem found by static checking.
1778 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1779 initialized, to pacify gcc -Wuninitialized.
1780
1781 * fileio.c: Report proper errno when syscall falls.
1782 (Finsert_file_contents): Save and restore errno,
1783 so that report_file_error outputs the correct diagnostic.
1784 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1785
1786 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1787
1788 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1789
1790 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1793 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1794
1795 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1796
1797 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1798 about the current paragraph and restore it after the call to reseat.
1799
1800 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1801 (bidi_find_paragraph_start): Search back for paragraph beginning
1802 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1803 (bidi_move_to_visually_next): Only trigger paragraph-related
1804 computations when the last character is a newline or at EOB, not
1805 just any NEUTRAL_B. (Bug#9470)
1806
1807 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1808 truncated lines if point is covered by a display string. (Bug#9524)
1809
1810 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1813 (cons_to_x_long): New function.
1814 (lisp_data_to_selection_data): Use it. Correct the test for
1815 short-versus-long data; it was negated. Break out of vector
1816 loop, for efficiency, when a long datum is discovered.
1817
1818 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1821
1822 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1823
1824 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1825 GCC PR/17406) by declaring this function with external scope.
1826
1827 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1830 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1831
1832 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1833
1834 * editfns.c (Fformat): Correctly handle text properties on "%%".
1835
1836 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1837
1838 * xterm.c (x_draw_composite_glyph_string_foreground):
1839 * w32term.c (x_draw_composite_glyph_string_foreground):
1840 * term.c (encode_terminal_code):
1841 * composite.c (composition_update_it, get_composition_id):
1842 * xdisp.c (get_next_display_element)
1843 (fill_composite_glyph_string): Add comments about special meaning
1844 of TAB characters in a composition.
1845
1846 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1849 This occurs when processing a multibyte format.
1850 Problem reported by Wolfgang Jenker.
1851
1852 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1853
1854 * xdisp.c (try_cursor_movement): Only check for exact match if
1855 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1856
1857 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Remove unused external symbols.
1860 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1861 * xdisp.c (calc_pixel_width_or_height): Now static.
1862 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1863 * indent.c (check_display_width):
1864 * w32term.c: Fix comment to match code.
1865 * xterm.c, xterm.h (x_catching_errors): Remove.
1866
1867 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * xselect.c: Use signed conversions more consistently (Bug#9498).
1870 (selection_data_to_lisp_data): Assume incoming selection data are
1871 signed integers, not unsigned. This is to be consistent with
1872 outgoing selection data, which was modified to use signed integers
1873 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1874 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1875 expects long, not unsigned long.
1876
1877 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1880 computation of loop end. Reported by Johan Bockgård
1881 <bojohan@gnu.org>.
1882
1883 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1884
1885 * frame.c (Fother_visible_frames_p): Function deleted.
1886
1887 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1888
1889 * indent.c (compute_motion): Process display vector front to back
1890 rather than the other way around. (Bug#2496)
1891
1892 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1895
1896 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1897
1898 * minibuf.c (Fread_from_minibuffer): Doc fix.
1899
1900 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1903 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1904
1905 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906
1907 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1908 value for non-existent files.
1909
1910 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1911
1912 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1913 set its "size" to -1. This will set the modtime_size field of
1914 the corresponding buffer to -1, which is what
1915 verify-visited-file-modtime expects for files that do not exist.
1916 (Bug#9139)
1917
1918 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1921 here ...
1922 * lisp.h: ... from here. push_key_description is no longer
1923 defined in keyboard.c, so its declaration should not be in
1924 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1925 logically belongs with push_key_description.
1926
1927 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * buffer.h: Include <sys/types.h> instead of <time.h>.
1930 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1931 Problem reported by Herbert J. Skuhra.
1932
1933 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1934
1935 * xml.c (parse_region): Make the parsing work for
1936 non-comment-starting XML files again (bug#9144).
1937
1938 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * image.c (gif_load): Fix calculation of bottom and right corner.
1941 (Bug#9468)
1942
1943 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1946 redisplay in small windows.
1947
1948 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1949
1950 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1951
1952 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1953
1954 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1955 Operate on live windows only.
1956
1957 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1960
1961 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1962
1963 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1964 only under bidi iteration.
1965
1966 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1969
1970 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1973 Without this fix, the command to link temacs failed due to an
1974 undefined symbol __builtin_isnan. This is because
1975 /usr/include/iso/math_c99.h #defines isnan(x) to
1976 __builtin_isnan(x), but the bundled gcc, which identifies itself
1977 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1978 a __builtin_isnan.
1979 * floatfns.c (isnan): #undef, and then #define to a clone of
1980 what's in data.c.
1981 (Fisnan): Always define, since it's always available now.
1982 (syms_of_floatfns): Always define isnan at the Lisp level.
1983
1984 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1987
1988 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1991 The previous code assumed that file offsets (off_t values) fit in
1992 EMACS_INT variables, which is not true on typical 32-bit hosts.
1993 The code messed up by falsely reporting buffer overflow in cases
1994 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1995 when "big" contains more than 2**29 bytes, even though this
1996 inserts just one byte and does not overflow the buffer.
1997 (Finsert_file_contents): Store file offsets as off_t
1998 values, not as EMACS_INT values. Check for overflow when
1999 converting between EMACS_INT and off_t. When checking for
2000 buffer overflow or for overlap, take the offsets into account.
2001 Don't use EMACS_INT for small values where int suffices.
2002 When checking for overlap, fix a typo: ZV was used where
2003 ZV_BYTE was intended.
2004 (Fwrite_region): Don't assume off_t fits into 'long'.
2005 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2006
2007 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2008
2009 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2010
2011 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 sprintf-related integer and memory overflow issues (Bug#9412).
2014
2015 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2016 (esprintf, exprintf, evxprintf): New functions.
2017 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2018 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2019 (modify_event_symbol): Do not assume that the length of
2020 name_alist_or_stem is safe to alloca and fits in int.
2021 (Fexecute_extended_command): Likewise for function name and binding.
2022 (Frecursion_depth): Wrap around reliably on integer overflow.
2023 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2024 since some callers pass EMACS_INT values.
2025 (Fsingle_key_description): Don't crash if symbol name contains more
2026 than MAX_ALLOCA bytes.
2027 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2028 (get_minibuffer): Arg is now EMACS_INT, not int.
2029 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2030 (esprintf, exprintf, evxprintf): New decls.
2031 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2032
2033 * dbusbind.c (signature_cat): New function.
2034 (xd_signature, Fdbus_register_signal):
2035 Do not overrun buffer; instead, report string overflow.
2036
2037 * dispnew.c (add_window_display_history): Don't overrun buffer.
2038 Truncate instead; this is OK since it's just a log.
2039
2040 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2041 even if the time zone offset is outlandishly large.
2042 Don't mishandle offset == INT_MIN.
2043
2044 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2045 when creating daemon; the previous buffer-overflow check was incorrect.
2046
2047 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2048 which has the guts of the old verror function.
2049
2050 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2051 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2052
2053 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2054 (font_unparse_xlfd): Don't blindly alloca long strings.
2055 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2056 fits in int, when using sprintf. Use single snprintf to count
2057 length of string rather than counting it via multiple sprintfs;
2058 that's simpler and more reliable.
2059 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2060 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2061 sprintf, in case result does not fit in int.
2062
2063 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2064 (fontset_from_font): Print it.
2065
2066 * frame.c (tty_frame_count): Now printmax_t, not int.
2067 (make_terminal_frame, set_term_frame_name): Print it.
2068 (x_report_frame_params): In X, window IDs are unsigned long,
2069 not signed long, so print them as unsigned.
2070 (validate_x_resource_name): Check for implausibly long names,
2071 and don't assume name length fits in 'int'.
2072 (x_get_resource_string): Don't blindly alloca invocation name;
2073 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2074 not fit in int.
2075
2076 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2077 (xg_check_special_colors, xg_set_geometry):
2078 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2079
2080 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2081 Use esprintf, not sprintf, in case result does not fit in int.
2082
2083 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2084 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2085 it as a large positive number.
2086 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2087 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2088
2089 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2090 in case result does not fit in int.
2091
2092 * print.c (float_to_string): Detect width overflow more reliably.
2093 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2094 buffer overrun. Don't assume list length fits in 'int'. Treat
2095 print length of 0 as 0, not as infinity; to be consistent with other
2096 uses of print length in this function. Don't overflow print length
2097 index. Don't assume hash table size fits in 'long', or that
2098 vectorlike size fits in 'unsigned long'.
2099
2100 * process.c (make_process): Use printmax_t, not int, to format
2101 process-name gensyms.
2102
2103 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2104
2105 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2106 to avoid potential buffer overrun.
2107
2108 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2109 if X resource line is longer than 512 bytes.
2110
2111 * xfns.c (x_window): Make sprintf buffer a bit bigger
2112 to avoid potential buffer overrun.
2113
2114 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2115
2116 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2117
2118 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 Integer overflow fixes for scrolling, etc.
2121 Without these, Emacs silently mishandles large integers sometimes.
2122 For example, "C-u 4294967297 M-x recenter" was treated as if
2123 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2124
2125 * xdisp.c (try_window_id): Check Emacs fixnum range before
2126 converting to 'int'.
2127
2128 * window.c (window_scroll_line_based, Frecenter):
2129 Check that an Emacs fixnum is in range before assigning it to 'int'.
2130 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2131 values converted from Emacs fixnums.
2132 (Frecenter): Don't wrap around a line count if it is out of 'int'
2133 range; instead, treat it as an extreme value.
2134 (Fset_window_configuration, compare_window_configurations):
2135 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2136
2137 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2138 that can exceed INT_MAX. Check that EMACS_INT value is in range
2139 before assigning it to the (possibly-narrower) index.
2140 (match_limit): Don't assume that a fixnum can fit in 'int'.
2141
2142 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2143 exceed INT_MAX.
2144
2145 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2146 (Fvertical_motion): Don't wrap around LINES values that don't fit
2147 in 'int'. Instead, treat them as extreme values. This is good
2148 enough for windows, which can't have more than INT_MAX lines anyway.
2149
2150 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2151
2152 * Require libxml/parser.h to avoid compilation warning.
2153
2154 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2155
2156 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2157 since this reportedly can destroy thread storage.
2158
2159 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2160
2161 * syntax.c (find_defun_start): Update all cache variables if
2162 exiting early (Bug#9401).
2163
2164 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2165
2166 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2167
2168 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2169 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2170 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2171
2172 * term.c (tty_append_glyph): New function.
2173 (produce_stretch_glyph): Static function and its prototype deleted.
2174
2175 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2176 Add prototypes.
2177
2178 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2181 when checking :margin (Bug#9390).
2182 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2183 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2184 so that the name doesn't mislead. All uses changed.
2185
2186 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2187
2188 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2189 set_tty_hooks.
2190
2191 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (move_it_to): Don't bail out early when reaching
2194 position beyond to_charpos, if we are scanning backwards.
2195 (move_it_vertically_backward): When DY == 0, make sure we get to
2196 the first character in the line after the newline.
2197
2198 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2201 (ccl_driver): Do not generate an out-of-range pointer.
2202 (Fccl_execute_on_string): Remove unnecessary check for
2203 integer overflow, noted by Stefan Monnier in
2204 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2205 Remove a FIXME that didn't need fixing.
2206 Simplify the newly-introduced buffer reallocation code.
2207
2208 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2209
2210 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2211
2212 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 Integer and memory overflow issues (Bug#9196).
2215
2216 * doc.c (get_doc_string): Rework so that
2217 get_doc_string_buffer_size is the actual buffer size, rather than
2218 being 1 less than the actual buffer size; this makes xpalloc more
2219 convenient.
2220
2221 * image.c (x_allocate_bitmap_record, cache_image):
2222 * xselect.c (Fx_register_dnd_atom):
2223 Simplify previous changes by using xpalloc.
2224
2225 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2226 since either will do and ptrdiff_t is convenient with xpalloc.
2227
2228 * charset.c (charset_table_size)
2229 (struct charset_sort_data.priority): Now ptrdiff_t.
2230 (charset_compare): Don't overflow if priorities differ greatly.
2231 (Fsort_charsets): Don't assume list length fits in int.
2232 Check for size-calculation overflow when allocating sort data.
2233 (syms_of_charset): Allocate an initial charset table that is
2234 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2235
2236 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2237
2238 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2239 The actual value is always <= INT_MAX, and leaving it unsigned made
2240 overflow checking harder.
2241
2242 * dispextern.h (struct glyph_matrix.rows_allocated)
2243 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2244 with xpalloc. The values are still always <= INT_MAX.
2245
2246 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2247
2248 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2249 (SAFE_NALLOCA): New macro.
2250
2251 * region-cache.c (struct boundary.pos, find_cache_boundary)
2252 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2253 (set_cache_region, invalidate_region_cache)
2254 (revalidate_region_cache, know_region_cache, region_cache_forward)
2255 (region_cache_backward, pp_cache):
2256 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2257 so that ptrdiff_t * can be passed to xpalloc.
2258 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2259 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2260 (pp_cache): Don't assume cache_len fits in int.
2261 * region-cache.h: Adjust extern decls to match.
2262
2263 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2264 EMACS_INT, since either will do, for xpalloc.
2265
2266 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2267 (xnmalloc, xnrealloc, xpalloc): New functions.
2268
2269 * bidi.c (bidi_shelve_header_size): New constant.
2270 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2271 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2272
2273 * bidi.c (bidi_cache_shrink):
2274 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2275 (overlay_strings):
2276 Don't update size of array until after memory allocation succeeds,
2277 because xmalloc/xrealloc may not return.
2278 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2279 now that we have proper integer overflow checking.
2280 (record_overlay_string, overlay_strings): Catch overflows when
2281 calculating size of overlay_str_buf.
2282
2283 * callproc.c (Fcall_process): Check for size overflow when
2284 calculating size of args2.
2285 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2286 Normally we prefer signed values, but sticking with ptrdiff_t would
2287 require adding more-complicated checks.
2288
2289 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2290 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2291 Redo buffer-overflow calculations to avoid integer overflow.
2292 Add a FIXME comment where memory seems to be over-allocated.
2293
2294 * character.c (Fstring): Check for size-calculation overflow.
2295
2296 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2297 unnecessary integer overflow. Check for size overflow.
2298 (encode_coding_object): Don't update size until xmalloc succeeds.
2299
2300 * composite.c (get_composition_id): Check for overflow in glyph
2301 length calculations.
2302
2303 Integer and memory overflow fixes for display code.
2304 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2305 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2306 (scrolling_window): Check for overflow in size calculations.
2307 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2308 Don't assume glyph table len fits in int.
2309 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2310 (row_table_size): Now ptrdiff_t, not int.
2311 (scrolling_window): Avoid overflow in size calculations.
2312 Don't update size until allocation succeeds.
2313 * fns.c (concat): Check for overflow in size calculations.
2314 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2315 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2316 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2317
2318 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2319 (get_doc_string): Check for size calculation overflow.
2320 Don't update size until allocation succeeds.
2321 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2322 EMACS_INT, where ptrdiff_t will do.
2323 (Fsubstitute_command_keys): Check for string overflow.
2324
2325 * editfns.c (set_time_zone_rule): Don't assume environment length
2326 fits in int.
2327 (message_length): Now ptrdiff_t, not int.
2328 (Fmessage_box): Don't update size until allocation succeeds.
2329 Don't assume message length fits in int.
2330 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2331
2332 * emacs.c (main): Do not reallocate argv, since there is a null at
2333 the end that can be overwritten, and this way there's no need to
2334 worry about size-calculation overflow.
2335 (sort_args): Check for size-calculation overflow.
2336
2337 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2338 alloc succeeds.
2339 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2340
2341 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2342 (x_set_scroll_bar_width, x_figure_window_size):
2343 Check for integer overflow.
2344 (x_set_alpha): Do not assume XINT fits in int.
2345
2346 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2347 This is for the members text_lines, text_cols, total_lines, total_cols,
2348 where the system imposes an 'int' limit.
2349
2350 * fringe.c (Fdefine_fringe_bitmap):
2351 Don't update size until alloc works.
2352
2353 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2354 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2355
2356 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2357 Check for size-calculation overflow.
2358 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2359 do, as we prefer signed integers.
2360 (id_to_widget.max_size, id_to_widget.used)
2361 (xg_store_widget_in_map, xg_remove_widget_from_map)
2362 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2363 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2364 Use and return ptrdiff_t, not int.
2365 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2366 * gtkutil.h: Change prototypes to match the above.
2367
2368 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2369 are duplicate now that they've been promoted to lisp.h.
2370 (x_allocate_bitmap_record, x_alloc_image_color)
2371 (make_image_cache, cache_image, xpm_load):
2372 Don't update size until alloc is done.
2373 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2374 (x_detect_edges):
2375 Check for size calculation overflow.
2376 (ct_colors_allocated_max): New constant.
2377 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2378 overflow.
2379
2380 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2381 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2382 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2383 Use ptrdiff_t, not int, to count maps.
2384 (read_char_minibuf_menu_prompt): Check for overflow in size
2385 calculations. Don't update size until allocation succeeds.
2386 Redo calculations to avoid overflow.
2387 * keyboard.h: Change prototypes to match the above.
2388
2389 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2390 to count maps.
2391 (current_minor_maps): Check for size calculation overflow.
2392 * keymap.h: Change prototypes to match the above.
2393
2394 * lread.c (read1, init_obarray): Don't update size until alloc done.
2395
2396 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2397 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2398
2399 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2400 Now ptrdiff_t, not int.
2401 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2402 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2403
2404 * process.c (Fnetwork_interface_list): Check for overflow
2405 in size calculation.
2406
2407 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2408
2409 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2410 overflow. Don't bother calling xmalloc when xrealloc will do.
2411
2412 * search.c (Freplace_match): Check for size calculation overflow.
2413 (Fset_match_data): Don't assume list lengths fit in 'int'.
2414
2415 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2416 for command line length. Do not attempt to address one before the
2417 beginning of an array, as that's not portable.
2418
2419 * term.c (max_frame_lines): Remove; unused.
2420 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2421 not int.
2422 (encode_terminal_code, calculate_costs): Check for size
2423 calculation overflow.
2424 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2425 table lengths and related sizes. Don't update size until alloc
2426 done. Redo calculations to avoid overflow.
2427 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2428
2429 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2430 subtracting pointers.
2431 (gobble_line): Check for overflow more carefully. Don't update size
2432 until alloc done.
2433
2434 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2435 Don't update size until alloc done.
2436 Redo size calculations to avoid overflow.
2437 Check for size calculation overflow.
2438 (main) [DEBUG]: Fix typo in invoking tparam1.
2439
2440 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2441 Use ptrdiff_t, not int, for sizes.
2442 (store_mode_line_noprop_char): Don't update size until alloc done.
2443
2444 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2445 Use ptrdiff_t, not int, for sizes.
2446 (Finternal_make_lisp_face, cache_face):
2447 Check for size calculation overflow.
2448 (cache_face): Treat size calculation overflows as if they were
2449 memory exhaustion (the usual treatment), rather than aborting.
2450
2451 * xfns.c (x_encode_text, x_set_name_internal)
2452 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2453 sizes, since they can exceed INT_MAX in size. Check for size
2454 calculation overflow.
2455
2456 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2457 (xg_select): Check for size calculation overflow.
2458 Don't update size until alloc done.
2459
2460 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2461 as sprintf is limited to int lengths.
2462
2463 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2464 (X_LONG_MIN): New macros.
2465 Use them to make the following changes clearer.
2466 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2467 This change doesn't affect the value now, but it may help remind
2468 future maintainers not to raise the value too much later.
2469 (SELECTION_QUANTUM): Remove, replacing with ...
2470 (selection_quantum): ... new function, which avoids overflow.
2471 All uses changed.
2472 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2473 assumption that selection length fits in 'int'.
2474 (x_reply_selection_request, x_handle_selection_request)
2475 (x_get_window_property, receive_incremental_selection)
2476 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2477 (lisp_data_to_selection_data, clean_local_selection_data):
2478 Use ptrdiff_t, not int, to record length of selection.
2479 (x_reply_selection_request, x_get_window_property)
2480 (receive_incremental_selection, x_property_data_to_lisp):
2481 Redo calculations to avoid overflow.
2482 (x_reply_selection_request): When sending hint, ceiling it at
2483 X_LONG_MAX rather than relying on wraparound overflow to send
2484 something.
2485 (x_get_window_property, receive_incremental_selection)
2486 (lisp_data_to_selection_data, x_property_data_to_lisp):
2487 Check for size-calculation overflow.
2488 (x_get_window_property, receive_incremental_selection)
2489 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2490 Don't store size until memory allocation succeeds.
2491 (x_get_window_property): Plug memory leak on memory exhaustion.
2492 Don't double-block input; malloc is safe here. Don't assume 2**34
2493 - 4 fits in unsigned long. Add an xassert to check
2494 XGetWindowProperty overflow. Be more careful about overflow
2495 calculations, and distinguish size from memory overflow better.
2496 (receive_incremental_selection): When tracing, don't assume
2497 unsigned int is less than INT_MAX.
2498 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2499 harmful) conversions of unsigned short to int.
2500 (lisp_data_to_selection_data): Don't assume that integers
2501 in the range -65535 through -1 fit in an X unsigned short.
2502 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2503 result parameters unless successful. Rely on cons_to_unsigned
2504 to report problems with elements; the old code wasn't right anyway.
2505 (x_check_property_data): Check for int overflow; we cannot use
2506 a wider type due to X limits.
2507 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2508
2509 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2510
2511 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2512 (x_term_init): Check for size calculation overflow.
2513 (x_color_cells): Don't store size until memory allocation succeeds.
2514 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2515 Don't assume alloca size is less than MAX_ALLOCA.
2516 (x_term_init): Don't assume length fits in int (sprintf is limited
2517 to int size).
2518
2519 Use ptrdiff_t for composition IDs.
2520 * character.c (lisp_string_width):
2521 * composite.c (composition_table_size, n_compositions)
2522 (get_composition_id, composition_gstring_from_id):
2523 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2524 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2525 * window.c (Frecenter):
2526 Use ptrdiff_t, not int, for composition IDs.
2527 * composite.c (get_composition_id): Check for integer overflow.
2528 * composite.h: Adjust prototypes to match the above changes.
2529
2530 Use ptrdiff_t for hash table indexes.
2531 * category.c (hash_get_category_set):
2532 * ccl.c (ccl_driver):
2533 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2534 * coding.c (coding_system_charset_list, detect_coding_system):
2535 * coding.h (struct coding_system.id):
2536 * composite.c (get_composition_id, gstring_lookup_cache):
2537 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2538 * image.c (xpm_get_color_table_h):
2539 * lisp.h (hash_lookup, hash_put):
2540 * minibuf.c (Ftest_completion):
2541 Use ptrdiff_t for hash table indexes, not int (which is too
2542 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2543 32-bit --with-wide-int hosts).
2544
2545 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2546 Add a FIXME comment about memory leaks.
2547 (syms_of_charset): Don't assume xmalloc returns.
2548
2549 Don't assume that stated character widths fit in int.
2550 * character.c (Fchar_width, c_string_width, lisp_string_width):
2551 * character.h (CHAR_WIDTH):
2552 * indent.c (MULTIBYTE_BYTES_WIDTH):
2553 Use sanitize_char_width to avoid undefined and/or bad behavior
2554 with outlandish widths.
2555 * character.h (sanitize_tab_width): Rename from sanitize_width,
2556 now that we have two such functions. All uses changed.
2557 (sanitize_char_width): New inline function.
2558
2559 Don't assume that tab-width fits in int.
2560 * character.h (sanitize_width): New inline function.
2561 (SANE_TAB_WIDTH): New macro.
2562 (ASCII_CHAR_WIDTH): Use it.
2563 * indent.c (sane_tab_width): Remove. All uses replaced by
2564 SANE_TAB_WIDTH (current_buffer).
2565 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2566
2567 * fileio.c: Integer overflow issues with file modes.
2568 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2569
2570 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2571 Remove unreachable code.
2572 (read_hex, load_charset_map_from_file): Check for integer overflow.
2573
2574 * xterm.c: Don't go over XClientMessageEvent limit.
2575 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2576 (x_send_scroll_bar_event): Likewise. Check that the size does not
2577 exceed limits imposed by XClientMessageEvent, as well as the usual
2578 ptrdiff_t and size_t limits.
2579
2580 * keyboard.c: Overflow, signedness and related fixes.
2581 (make_lispy_movement): Use same integer type in forward decl
2582 that is used in the definition.
2583 (read_key_sequence, keyremap_step):
2584 Change bufsize argument back to int, undoing my 2011-03-30 change.
2585 We prefer signed types, and int is wide enough here.
2586 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2587 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2588 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2589 length, not size_t. Use ptrdiff_t for index, not int.
2590 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2591 possibility of integer overflow.
2592
2593 Overflow, signedness and related fixes for images.
2594
2595 * dispextern.h (struct it.stack[0].u.image.image_id)
2596 (struct_it.image_id, struct image.id, struct image_cache.size)
2597 (struct image_cache.used, struct image_cache.ref_count):
2598 * gtkutil.c (update_frame_tool_bar):
2599 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2600 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2601 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2602 * nsmenu.m (update_frame_tool_bar):
2603 * xdisp.c (calc_pixel_width_or_height):
2604 * xfns.c (image_cache_refcount):
2605 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2606 on typical 64-bit hosts.
2607
2608 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2609 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2610 Omit unnecessary casts to int.
2611 (parse_image_spec): Check that integers fall into 'int' range
2612 when the callers expect that.
2613 (image_ascent): Redo ascent calculation to avoid int overflow.
2614 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2615 (lookup_image): Remove unnecessary tests.
2616 (xbm_image_p): Locals are now of int, not EMACS_INT,
2617 since parse_image_check makes sure they fit into int.
2618 (png_load, gif_load, svg_load_image):
2619 Prefer int to unsigned where either will do.
2620 (tiff_handler): New function, combining the cores of the
2621 old tiff_error_handler and tiff_warning_handler.
2622 This function is rewritten to use vsnprintf and thereby avoid
2623 stack buffer overflows. It uses only the features of vsnprintf
2624 that are common to both POSIX and native Microsoft.
2625 (tiff_error_handler, tiff_warning_handler): Use it.
2626 (tiff_load, gif_load, imagemagick_load_image):
2627 Don't assume :index value fits in 'int'.
2628 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2629 (imagemagick_load_image): Check that crop parameters fit into
2630 the integer types that MagickCropImage accepts. Don't assume
2631 Vimagemagick_render_type has a nonnegative value. Don't assume
2632 size_t fits in 'long'.
2633 (gs_load): Use printmax_t to print the widest integers possible.
2634 Check for integer overflow when computing image height and width.
2635
2636 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2637
2638 * xdisp.c (redisplay_window): Don't force window start if point
2639 will be invisible in the resulting window. (Bug#9324)
2640
2641 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2644 the display spec is of the form `(space ...)'.
2645 (handle_display_spec): Return the value returned by
2646 handle_single_display_spec, not just 1 or zero.
2647 (handle_single_display_spec): If the display spec is of the form
2648 `(space ...)', and specifies display in the text area, return 2
2649 rather than 1.
2650 (try_cursor_movement): Check for the need to scroll more
2651 accurately, and prefer exact match for point under bidi.
2652 Don't advance `row' beyond the last row of the window.
2653
2654 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2655 into disp_prop; all users changed.
2656
2657 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2658 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2659 for the text covered by the display property.
2660
2661 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2664 Change return value to nil.
2665 (Frecord_buffer): Delete unused function.
2666
2667 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2668
2669 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2670 buffers, return left-to-right.
2671 (set_cursor_from_row): Consider candidate row a win if its glyph
2672 represents a newline and point is on that newline. Fixes cursor
2673 positioning on the newline at EOL of R2L text within L2R
2674 paragraph, and vice versa.
2675 (try_cursor_movement): Check continued rows, in addition to
2676 continuation rows. Fixes unwarranted scroll when point enters a
2677 continued line of R2L text within an L2R paragraph, or vice versa.
2678 (cursor_row_p): Consider the case of point being equal to
2679 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2680 from the end of a short line to the beginning of a continued line
2681 of R2L text within L2R paragraph.
2682 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2683 composed characters.
2684
2685 * bidi.c (bidi_check_type): Use xassert.
2686 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2687 members.
2688
2689 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2690
2691 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2692 a character.
2693
2694 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * nsfont.m (ns_otf_to_script): Fix typo.
2697
2698 2011-08-22 Kenichi Handa <handa@m17n.org>
2699
2700 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2701 extra slot even if the purpose is char-code-property-table.
2702
2703 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2704
2705 * xdisp.c (redisplay_window): When computing centering_position,
2706 account for the height of the header line. (Bug#8874)
2707
2708 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2709 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2710 candidate is selected by the mouse, and that candidate has a
2711 composed character under the mouse.
2712
2713 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2714 coordinates reported by pos-visible-in-window-p for a composed
2715 character in column zero.
2716
2717 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2718
2719 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2720
2721 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2724 consider it a hit if to_charpos is anywhere in the range of the
2725 composed buffer positions.
2726
2727 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2728
2729 * image.c (gif_load): Don't assume that each subimage has the same
2730 dimensions as the base image. Handle disposal method that is
2731 "undefined" by the gif spec (Bug#9335).
2732
2733 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2736 (Fcondition_case): Document `debug' symbol in error handler.
2737
2738 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2741 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2742 from an Org mode buffer to a Speedbar frame.
2743
2744 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2745 a composition, take its buffer position from IT->cmp_it.charpos.
2746 Fixes cursor positioning at the beginning of a line that begins
2747 with a composed character.
2748
2749 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2750
2751 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2752 character bidirectional type, use STRONG_L instead. Fixes crashes
2753 in a buffer produced by `describe-categories'.
2754
2755 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2756 members before the level stack, so they would be saved and
2757 restored when copying iterator state. Fixes incorrect reordering
2758 around TABs covered by display properties.
2759
2760 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2761
2762 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2763
2764 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2765
2766 * eval.c (internal_condition_case, internal_condition_case_1)
2767 (internal_condition_case_2, internal_condition_case_n):
2768 Remove unnecessary aborts (Bug#9081).
2769
2770 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2771
2772 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2773 has no `load' handler, try opening the file locally. (Bug#9311)
2774
2775 2011-08-16 Ken Brown <kbrown@cornell.edu>
2776
2777 * gmalloc.c: Expand comment.
2778
2779 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2780
2781 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2782 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2783
2784 2011-08-16 Ken Brown <kbrown@cornell.edu>
2785
2786 Fix memory allocation problems in Cygwin build (Bug#9273).
2787
2788 * unexcw.c ( __malloc_initialized): Declare external variable.
2789 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2790
2791 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2792 New variables.
2793 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2794 dumped emacs.
2795 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2796 in the static heap.
2797 [CYGWIN] (special_realloc): New function.
2798 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2799 requests to realloc storage in the static heap.
2800
2801 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * bidi.c (bidi_initialize): Remove unused local.
2804
2805 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2806
2807 * bidimirror.h:
2808 * biditype.h: Remove file.
2809 * makefile.w32-in ($(BLD)/bidi.$(O)):
2810 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2811
2812 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2813
2814 * chartab.c: Improve commentary for the uniprop_table API.
2815
2816 * bidi.c (bidi_paragraph_init): Support zero value of
2817 bidi_ignore_explicit_marks_for_paragraph_level.
2818 (bidi_initialize): Use uniprop_table instead of including
2819 biditype.h and bidimirror.h.
2820
2821 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2822 coordinates of the iterator when restoring from ppos_it.
2823 (Bug#9296)
2824
2825 2011-08-14 Kenichi Handa <handa@m17n.org>
2826
2827 * process.c (create_process): Call setup_process_coding_systems
2828 after the pid of the process is set to -1 (Bug#8162).
2829
2830 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2831
2832 * xdisp.c (move_it_in_display_line_to): Don't invoke
2833 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2834 ppos_it. Fixes vertical cursor motion when line beginning is
2835 covered by an image. (Bug#9296)
2836
2837 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2838
2839 * nsterm.h (ns_run_ascript): Declare.
2840 (NSAPP_DATA2_RUNASSCRIPT): Define.
2841
2842 * nsfns.m (as_script, as_result, as_status): New static variables.
2843 (ns_run_ascript): New function.
2844 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2845 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2846 the event loop. Get status from as_status (Bug#7276).
2847
2848 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2849 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2850 the event loop (Bug#7276).
2851
2852 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2853
2854 * gnutls.c (QCgnutls_bootprop_priority)
2855 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2856 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2857 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2858 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2859 (QCgnutls_bootprop_verify_hostname_error)
2860 (QCgnutls_bootprop_callbacks_verify): Rename from
2861 Qgnutls_bootprop_..., all uses changed.
2862
2863 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2864 uses changed.
2865
2866 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * xfaces.c (Qframe_set_background_mode): Now static.
2869 * dispextern.h (Qframe_set_background_mode): Remove decl.
2870
2871 * process.c (Fnetwork_interface_info): Declare local only if needed.
2872
2873 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2874
2875 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2876 (Fnetwork_interface_list): Allocate in increments of bytes instead
2877 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2878 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2879 sockaddr.
2880 (struct ifflag_def): notrailers is smart on OSX.
2881 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2882 Get hardware address with getifaddrs if available.
2883
2884 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2885
2886 * xdisp.c (iterate_out_of_display_property): xassert that
2887 IT->position is set to within IT->object's boundaries. Break from
2888 the loop as soon as EOB is reached; avoids infloops in redisplay
2889 when IT->position is set up wrongly due to some bug.
2890 Set IT->current to match the bidi iterator unconditionally.
2891 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2892 entry. Force push_it to save on the stack the current
2893 buffer/string position, to be restored by pop_it. Fix flags in
2894 the iterator structure wrt the object coming from a display
2895 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2896 properties. (Bug#9284)
2897
2898 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2899
2900 * fontset.c (fontset_get_font_group): Add proper type checks.
2901 (Bug#9172)
2902
2903 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2904
2905 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2906 and LC_VERSION_MIN_MACOSX.
2907 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2908 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2909
2910 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (forward_to_next_line_start): Allow to use the
2913 no-display-properties-and-no-overlays under bidi display.
2914 Set disp_pos in the bidi iterator to avoid searches for display
2915 properties and overlays.
2916
2917 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2918
2919 * editfns.c (Fset_time_zone_rule): Document relationship with the
2920 setenv function.
2921
2922 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2923 the font entity extracted from the cache (Bug#8109).
2924
2925 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2926
2927 * composite.c (autocmp_chars): Don't reset point. That is done by
2928 restore_point_unwind (Bug#5984).
2929
2930 2011-08-07 Juri Linkov <juri@jurta.org>
2931
2932 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2933 to show the arg `TIME' instead of `TIMEVAL'.
2934
2935 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2936
2937 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2938 display property strides EOL and includes a newline, as in
2939 longlines-mode. (Bug#9254)
2940 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2941 word-wrap under bidirectional display. (Bug#9224)
2942
2943 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2944 is non-zero, even if the data buffer is NULL. Fixes a crash in
2945 vertical-motion with longlines-mode. (Bug#9254)
2946
2947 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2948
2949 * bidi.c <bidi_cache_total_alloc>: Now static.
2950 (bidi_initialize): Initialize bidi_cache_total_alloc.
2951
2952 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2953 cache. (Bug#9221)
2954
2955 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2956 amount allocated this far in `bidi_cache_total_alloc'.
2957 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2958 non-zero, only free the data buffer without restoring the cache
2959 contents. All callers changed.
2960
2961 * dispextern.h (bidi_unshelve_cache): Update prototype.
2962
2963 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2964 (move_it_in_display_line, move_it_to)
2965 (move_it_vertically_backward, move_it_by_lines): Replace the call
2966 to xfree to an equivalent call to bidi_unshelve_cache.
2967 (move_it_in_display_line_to): Fix logic of returning
2968 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2969
2970 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2973 came from a string character with a `cursor' property. (Bug#9229)
2974
2975 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2976
2977 * Makefile.in (LIB_PTHREAD): New variable.
2978 (LIBES): Add LIB_PTHREAD (Bug#9216).
2979
2980 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2981 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2982
2983 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2984
2985 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2986
2987 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * xterm.c (x_find_topmost_parent): New function.
2990 (x_set_frame_alpha): Find topmost parent window with
2991 x_find_topmost_parent and set the property there also (bug#9181).
2992 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2993
2994 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 * callproc.c (Fcall_process): Avoid vfork clobbering
2997 the local vars buffer, coding_systems, current_dir.
2998
2999 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3002
3003 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3004
3005 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3006 so that it is not optimized away.
3007
3008 * xdisp.c (compute_display_string_pos): Remove unused local.
3009
3010 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3011
3012 Fix slow cursor motion and scrolling in large buffers with
3013 selective display, like Org Mode buffers. (Bug#9218)
3014
3015 * dispextern.h (struct bidi_it): New member disp_prop_p.
3016
3017 * xdisp.c: Remove one-slot cache of display string positions.
3018 (compute_display_string_pos): Accept an additional argument
3019 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3020 for a display string or property. If found, set DISP_PROP_P
3021 non-zero.
3022
3023 * bidi.c (bidi_fetch_char): Accept an additional argument
3024 DISP_PROP_P, and pass it to compute_display_string_pos.
3025 Only handle text covered by a display string if DISP_PROP_P is returned
3026 non-zero. All callers of bidi_fetch_char changed.
3027
3028 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3031
3032 2010-12-03 Don March <don@ohspite.net>
3033
3034 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3035 last character M-[char] is translated to ESC [char] (bug#7541).
3036
3037 2011-08-02 Kenichi Handa <handa@m17n.org>
3038
3039 * lisp.h (uniprop_table): Extern it.
3040
3041 * chartab.c (uniprop_table): Make it non-static.
3042
3043 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3044
3045 * xdisp.c (forward_to_next_line_start): Accept additional argument
3046 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3047 on the newline.
3048 (reseat_at_next_visible_line_start): Use the bidi iterator state
3049 returned by forward_to_next_line_start to restore the state of
3050 it->bidi_it after backing up to previous newline. (Bug#9212)
3051
3052 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3053
3054 * regex.c (re_comp): Protoize.
3055 (re_exec): Fix return type.
3056 (regexec): Fix type of `ret'. (Bug#9203)
3057
3058 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3061 This is needed if max-image-size is a floating-point number.
3062
3063 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3064
3065 * print.c (print_object): Print empty symbol as ##.
3066
3067 * lread.c (read1): Read ## as empty symbol.
3068
3069 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3070
3071 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3072 setting frame foreground color (Bug#9175).
3073 (x_set_background_color): Likewise.
3074
3075 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3076 contents (Bug#9176).
3077 (EmacsTooltip -init): Remove bezels and add shadows to
3078 tooltip windows.
3079
3080 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3081 or scroll bar (Bug#8470).
3082
3083 * nsfont.m (nsfont_open): Remove assignment to voffset and
3084 unnecessary vars hshink, expand, hd, full_height, min_height.
3085 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3086
3087 * nsterm.h (nsfont_info): Remove voffset field.
3088
3089 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3090
3091 Implement strike-through and overline on NextStep (Bug#8863).
3092
3093 * nsfont.m (nsfont_open): Use underline position provided by font,
3094 instead of hard-coded value of 2.
3095 (nsfont_draw): Call ns_draw_text_decoration instead.
3096
3097 * nsterm.h: Add declaration for ns_draw_text_decoration.
3098
3099 * nsterm.m (ns_draw_text_decoration): New function for drawing
3100 underline, overline, and strike-through.
3101 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3102 ns_draw_text_decoration. Change treatment of cursor drawing to
3103 accommodate underlining, etc.
3104
3105 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3106
3107 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3108 default.
3109
3110 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3113 Without this fix, if a signal arrives just after memory fills up,
3114 'malloc' might be invoked reentrantly.
3115
3116 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3117 In other words, assume that every image size is allowed, on non-X
3118 hosts. This assumption is probably wrong, but it lets Emacs compile.
3119
3120 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3121
3122 * regex.c (re_iswctype): Convert return values to boolean.
3123
3124 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3125
3126 * xdisp.c (compute_display_string_pos): Don't use cached display
3127 string position if the buffer had its restriction changed.
3128 (Bug#9184)
3129
3130 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3133
3134 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 Integer signedness and overflow and related fixes. (Bug#9079)
3137
3138 * bidi.c: Integer size and overflow fixes.
3139 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3140 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3141 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3142 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3143 (bidi_find_other_level_edge):
3144 Use ptrdiff_t instead of EMACS_INT where either will do.
3145 This works better on 32-bit hosts configured --with-wide-int.
3146 (bidi_cache_ensure_space): Check for size-calculation overflow.
3147 Use % rather than repeated addition, for better worst-case speed.
3148 Don't set bidi_cache_size until after xrealloc returns, because it
3149 might not return.
3150 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3151 (bidi_cache_ensure_space): Also check that the bidi cache size
3152 does not exceed that of the largest Lisp string or buffer. See Eli
3153 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3154
3155 * alloc.c (__malloc_size_t): Remove.
3156 All uses replaced by size_t. See Andreas Schwab's note
3157 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3158
3159 * image.c: Improve checking for integer overflow.
3160 (check_image_size): Assume that f is nonnull, since
3161 it is always nonnull in practice. This is one less thing to
3162 worry about when checking for integer overflow later.
3163 (x_check_image_size): New function, which checks for integer
3164 overflow issues inside X.
3165 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3166 This removes the need for a memory_full check.
3167 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3168 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3169 (xbm_read_bitmap_data): Change locals back to 'int', since
3170 their values must fit in 'int'.
3171 (xpm_load_image, png_load, tiff_load):
3172 Invoke x_create_x_image_and_pixmap earlier,
3173 to avoid much needless work if the image is too large.
3174 (tiff_load): Treat overly large images as if
3175 x_create_x_image_and_pixmap failed, not as malloc failures.
3176 (gs_load): Use x_check_image_size.
3177
3178 * gtkutil.c: Omit integer casts.
3179 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3180 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3181
3182 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3183
3184 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3185 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3186 would wrongly return t on a 64-bit host.
3187
3188 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3189 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3190 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3191 and therefore cause GCC to emit a bogus diagnostic in some cases.
3192
3193 * image.c: Integer signedness and overflow and related fixes.
3194 This is not an exhaustive set of fixes, but it's time to
3195 record what I've got.
3196 (lookup_pixel_color, check_image_size): Remove redundant decls.
3197 (check_image_size): Don't assume that arbitrary EMACS_INT values
3198 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3199 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3200 (tiff_load, imagemagick_load_image):
3201 Check for overflow in size calculations.
3202 (x_create_x_image_and_pixmap): Remove unnecessary test for
3203 xmalloc returning NULL; that can't happen.
3204 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3205 (xpm_color_bucket): Use better integer hashing function.
3206 (xpm_cache_color): Don't possibly over-allocate memory.
3207 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3208 (gif_memory_source):
3209 Use ptrdiff_t, not int or size_t, to record sizes.
3210 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3211 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3212 either works, as we prefer signed integers.
3213 (tiff_read_from_memory, tiff_write_from_memory):
3214 Return tsize_t, not size_t, since that's what the TIFF API wants.
3215 (tiff_read_from_memory): Don't fail simply because the read would
3216 go past EOF; instead, return a short read.
3217 (tiff_load): Omit no-longer-needed casts.
3218 (Fimagemagick_types): Don't assume size fits into 'int'.
3219
3220 Improve hashing quality when configured --with-wide-int.
3221 * fns.c (hash_string): New function, taken from sxhash_string.
3222 Do not discard information about ASCII character case; this
3223 discarding is no longer needed.
3224 (sxhash-string): Use it. Change sig to match it. Caller changed.
3225 * lisp.h: Declare it.
3226 * lread.c (hash_string): Remove, since we now use fns.c's version.
3227 The fns.c version returns a wider integer if --with-wide-int is
3228 specified, so this should help the quality of the hashing a bit.
3229
3230 * emacs.c: Integer overflow minor fix.
3231 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3232 Define only if GNU_LINUX.
3233 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3234
3235 * dispnew.c: Integer signedness and overflow fixes.
3236 Remove unnecessary forward decls, that were a maintenance hassle.
3237 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3238 All uses changed.
3239 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3240 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3241 (prepare_desired_row, line_draw_cost):
3242 Use int, not unsigned, where either works.
3243 (save_current_matrix, restore_current_matrix):
3244 Use ptrdiff_t, not size_t, where either works.
3245 (init_display): Check for overflow more accurately, and without
3246 relying on undefined behavior.
3247
3248 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3249 Remove, replacing with the new symbols in lisp.h. All uses changed.
3250 * fileio.c (make_temp_name):
3251 * filelock.c (lock_file_1, lock_file):
3252 * xdisp.c (message_dolog):
3253 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3254 Use pMd etc. instead.
3255 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3256 replacing the pWIDE etc. symbols removed from editfns.c.
3257
3258 * keyboard.h (num_input_events): Now uintmax_t.
3259 This is (very slightly) less likely to mess up due to wraparound.
3260 All uses changed.
3261
3262 * buffer.c: Integer signedness fixes.
3263 (alloc_buffer_text, enlarge_buffer_text):
3264 Use ptrdiff_t rather than size_t when either will do, as we prefer
3265 signed integers.
3266
3267 * alloc.c: Integer signedness and overflow fixes.
3268 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3269 (__malloc_size_t): Default to size_t, not to int.
3270 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3271 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3272 Prefer ptrdiff_t to size_t when either would do, as we prefer
3273 signed integers.
3274 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3275 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3276 Now const. Initialize with values that are in range even if char
3277 is signed.
3278 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3279 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3280 These functions do the right thing with sizes > 2**32.
3281 (check_depth): Now ptrdiff_t, not int.
3282 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3283 Adjust to new way of storing sizes. Check for size overflow bugs
3284 in rest of code.
3285 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3286 slightly wrong anyway, as it missed one instance of
3287 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3288 (refill_memory_reserve): Omit needless cast to size_t.
3289 (mark_object_loop_halt): Mark as externally visible.
3290
3291 * xselect.c: Integer signedness and overflow fixes.
3292 (Fx_register_dnd_atom, x_handle_dnd_message):
3293 Use ptrdiff_t, not size_t, since we prefer signed.
3294 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3295 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3296 x_dnd_atoms_size and x_dnd_atoms_length.
3297
3298 * doprnt.c: Prefer signed to unsigned when either works.
3299 * eval.c (verror):
3300 * doprnt.c (doprnt):
3301 * lisp.h (doprnt):
3302 * xdisp.c (vmessage):
3303 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3304 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3305 prefer signed arithmetic to avoid comparison confusion.
3306 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3307 but is a bit tricky.
3308
3309 Assume freestanding C89 headers, string.h, stdlib.h.
3310 * data.c, doprnt.c, floatfns.c, print.c:
3311 Include float.h unconditionally.
3312 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3313 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3314 * regex.c: Likewise for stddef.h, string.h.
3315 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3316 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3317 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3318 (STDC_HEADERS): Remove obsolete defines.
3319 * sysdep.c: Include limits.h unconditionally.
3320
3321 Assume support for memcmp, memcpy, memmove, memset.
3322 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3323 * regex.c (memcmp, memcpy):
3324 Remove; we assume C89 now.
3325
3326 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3327 (__malloc_safe_bcopy): Remove; no longer needed.
3328
3329 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3330 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3331 well either way, and we prefer signed to unsigned.
3332
3333 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3334
3335 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3336 closes the connection while we're reading (bug#9182).
3337
3338 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3339
3340 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3341 are specified (Bug#9168).
3342
3343 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3346 Found by GCC static checking and --with-wide-int on a 32-bit host.
3347
3348 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3349
3350 * xdisp.c (compute_display_string_pos): Fix logic of caching
3351 previous display string position. Initialize cached_prev_pos to
3352 -1. Fixes slow-down at the beginning of a buffer.
3353
3354 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3357 for attrs[LFACE_FONTSET_INDEX].
3358
3359 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * xml.c (parse_region): Remove unused local
3362 that was recently introduced.
3363
3364 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3365
3366 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3367 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3368
3369 * xdisp.c (move_it_in_display_line_to): Record the best matching
3370 position for TO_CHARPOS while scanning the line, and restore it on
3371 exit if none of the characters scanned was an exact match.
3372 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3373 when exact match is impossible due to invisible text, and the
3374 lines are truncated.
3375
3376 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3379 for OSX >= 10.7.
3380
3381 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3382
3383 Fix a significant slow-down of cursor motion with C-n, C-p,
3384 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3385 auto-repeat under bidi redisplay in fontified buffers.
3386 * xdisp.c (compute_stop_pos_backwards): New function.
3387 (next_element_from_buffer): Call compute_stop_pos_backwards to
3388 find a suitable prev_stop when we find ourselves before
3389 base_level_stop.
3390 (reseat): Don't look for prev_stop, as that could mean a very long
3391 run.
3392 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3393 <cached_disp_overlay_modiff>: Cache for last found display string
3394 position.
3395 (compute_display_string_pos): Return the cached position if asked
3396 about the same buffer in the same area of character positions, and
3397 the buffer wasn't changed since the time the display string
3398 position was cached.
3399
3400 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3401
3402 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3403 is an integer, which is important for empty lines. (Bug#9149)
3404
3405 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3406
3407 * frame.c (Fmodify_frame_parameters): In tty case, update the
3408 default face if necessary (Bug#4238).
3409
3410 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3411
3412 * editfns.c (Fstring_to_char): No need to explain what a character
3413 is in the docstring (Bug#6576).
3414
3415 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3416
3417 * xml.c (parse_region): Make sure we always return a tree.
3418
3419 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3420
3421 * xml.c (parse_region): If a document contains only comments,
3422 return that, too.
3423
3424 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3425
3426 * xml.c (make_dom): Return comments, too.
3427
3428 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 Port to OpenBSD.
3431 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3432 and the surrounding thread.
3433 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3434 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3435 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3436 timer goes off.
3437 * s/openbsd.h (BROKEN_SIGIO): Define.
3438 * unexelf.c (unexec) [__OpenBSD__]:
3439 Don't update the .mdebug section of the Alpha COFF symbol table.
3440
3441 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3442
3443 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3444 (bug#8460).
3445
3446 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3447
3448 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3449 This fixes some race conditions on the permissions of any newly
3450 created file.
3451
3452 * alloc.c (valid_pointer_p): Use pipe, not open.
3453 This fixes some permissions issues when debugging.
3454
3455 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3456 If fchown fails to set both uid and gid, try to set just gid,
3457 as that is sometimes allowed. Adjust the file's mode to eliminate
3458 setuid or setgid bits that are inappropriate if fchown fails.
3459
3460 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3461
3462 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3463 to compare Lisp_Objects.
3464 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3465 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3466 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3467
3468 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3469
3470 * lread.c (read_integer): Unread even EOF character.
3471 (read1): Likewise. Properly record start position of symbol.
3472
3473 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3474 symbol character follows.
3475
3476 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3479 This works around a problem with the previous change to Fcopy_file.
3480 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3481 and without this change, GCC might complain about discarding
3482 fchown's return value.
3483
3484 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3487
3488 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3491
3492 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3493
3494 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3495 it's used from the C level.
3496
3497 * process.c: Use the same condition for POLL_FOR_INPUT in both
3498 keyboard.c and process.c (bug#1858).
3499
3500 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3501
3502 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3503 (Fgnutls_boot): Use it.
3504
3505 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3506
3507 * doc.c (Fsubstitute_command_keys): Revert last change.
3508
3509 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3510
3511 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3512 quotes the next character, and doesn't affect other longer
3513 sequences (bug#8935).
3514
3515 * lread.c (syms_of_lread): Clarify that is isn't only
3516 `eval-buffer' and `eval-defun' that's affected by
3517 `lexical-binding' (bug#8460).
3518
3519 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3520
3521 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3522 bidi redisplay when a line includes both an image and is truncated.
3523
3524 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 Fix minor problems found by static checking.
3527 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3528 (elsz): Now a signed constant, not a size_t var. We prefer signed
3529 types to unsigned, to avoid integer comparison confusion. Without
3530 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3531 "cannot optimize loop, the loop counter may overflow", a symptom
3532 of the confusion.
3533 * indent.c (Fvertical_motion): Mark locals as initialized.
3534 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3535
3536 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3537
3538 * search.c (Fre_search_backward): Mention `case-fold-search' in
3539 all the re_search_* functions (bug#8138).
3540
3541 * keyboard.c (Fopen_dribble_file): Document when the file is
3542 closed (bug#8056).
3543
3544 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3545
3546 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3547 bidi_cache_idx.
3548
3549 Support bidi reordering of display and overlay strings.
3550 * xdisp.c (compute_display_string_pos)
3551 (compute_display_string_end): Accept additional argument STRING.
3552 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3553 (reseat_to_string): Initialize bidi_it->string.s and
3554 bidi_it->string.schars.
3555 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3556 NULL (avoids a crash in bidi_paragraph_init).
3557 Initialize itb.string.lstring.
3558 (init_iterator): Call bidi_init_it only of a valid
3559 buffer position was specified. Initialize paragraph_embedding to
3560 L2R.
3561 (reseat_to_string): Initialize the bidi iterator.
3562 (display_string): If we need to ignore text properties of
3563 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3564 original value of -1 will not work with bidi.)
3565 (compute_display_string_pos): First arg is now struct
3566 `text_pos *'; all callers changed. Support display properties on
3567 Lisp strings.
3568 (compute_display_string_end): Support display properties on Lisp
3569 strings.
3570 (init_iterator, reseat_1, reseat_to_string): Initialize the
3571 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3572 when iterating on a string not from display properties).
3573 (compute_display_string_pos, compute_display_string_end):
3574 Fix calculation of the object to scan. Fixes an error when using
3575 arrow keys.
3576 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3577 base_level_stop; instead, set base_level_stop to BEGV.
3578 Fixes crashes in vertical-motion.
3579 (next_element_from_buffer): Improve commentary for when
3580 the iterator is before prev_stop.
3581 (init_iterator): Initialize bidi_p from the default value of
3582 bidi-display-reordering, not from buffer-local value. Use the
3583 buffer-local value only if initializing for buffer iteration.
3584 (handle_invisible_prop): Support invisible properties on strings
3585 that are being bidi-reordered.
3586 (set_iterator_to_next): Support bidi reordering of C strings and
3587 Lisp strings.
3588 (next_element_from_string): Support bidi reordering of Lisp
3589 strings.
3590 (handle_stop_backwards): Support Lisp strings as well.
3591 (display_string): Support display of R2L glyph rows.
3592 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3593 (init_iterator): Don't initialize it->bidi_p for strings
3594 here.
3595 (reseat_to_string): Initialize it->bidi_p for strings here.
3596 (next_element_from_string, next_element_from_c_string)
3597 (next_element_from_buffer): Add xassert's for correspondence
3598 between IT's object being iterated and it->bidi_it.string
3599 structure.
3600 (face_before_or_after_it_pos): Support bidi iteration.
3601 (next_element_from_c_string): Handle the case of the first string
3602 character that is not the first one in the visual order.
3603 (get_visually_first_element): New function, refactored from common
3604 parts of next_element_from_buffer, next_element_from_string, and
3605 next_element_from_c_string.
3606 (tool_bar_lines_needed, redisplay_tool_bar)
3607 (display_menu_bar): Force left-to-right direction. Add a FIXME
3608 comment for making that be controlled by a user option.
3609 (push_it, pop_it): Save and restore the state of the
3610 bidi iterator. Save and restore the bidi_p flag.
3611 (pop_it): Iterate out of display property for string iteration as
3612 well.
3613 (iterate_out_of_display_property): Support iteration over strings.
3614 (handle_single_display_spec): Set up it->bidi_it for iteration
3615 over a display string, and call bidi_init_it.
3616 (handle_single_display_spec, next_overlay_string)
3617 (get_overlay_strings_1, push_display_prop): Set up the bidi
3618 iterator for displaying display or overlay strings.
3619 (forward_to_next_line_start): Don't use the shortcut if
3620 bidi-iterating.
3621 (back_to_previous_visible_line_start): If handle_display_prop
3622 pushed the iterator stack, restore the internal state of the bidi
3623 iterator by calling bidi_pop_it same number of times.
3624 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3625 and we are bidi-iterating, don't decrement the iterator position;
3626 instead, set the first_elt flag in the bidi iterator, to produce
3627 the same effect.
3628 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3629 (push_display_prop): xassert that we are iterating a buffer.
3630 (push_it, pop_it): Save and restore paragraph_embedding member.
3631 (handle_single_display_spec, next_overlay_string)
3632 (get_overlay_strings_1, reseat_1, reseat_to_string)
3633 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3634 correctly. Don't assume unibyte strings are not bidi-reordered.
3635 (compute_display_string_pos)
3636 (compute_display_string_end): Fix handling the case of C string.
3637 (push_it, pop_it): Save and restore from_disp_prop_p.
3638 (handle_single_display_spec, push_display_prop): Set the
3639 from_disp_prop_p flag.
3640 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3641 (pop_it): Call iterate_out_of_display_property only if we are
3642 popping after iteration over a string that came from a display
3643 property. Fix a typo in popping stretch info. Add an assertion
3644 for verifying that the iterator position is in sync with the bidi
3645 iterator.
3646 (handle_single_display_spec, get_overlay_strings_1)
3647 (push_display_prop): Fix initialization of paragraph direction for
3648 string when that of the parent object is not yet determined.
3649 (reseat_1): Call bidi_init_it to resync the bidi
3650 iterator with IT's position. (Bug#7616)
3651 (find_row_edges): If ROW->start.pos gives position
3652 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3653 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3654 Reset the from_disp_prop_p flag.
3655 (SAVE_IT, RESTORE_IT): New macros.
3656 (pos_visible_p, face_before_or_after_it_pos)
3657 (back_to_previous_visible_line_start)
3658 (move_it_in_display_line_to, move_it_in_display_line)
3659 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3660 (try_scrolling, redisplay_window, display_line): Use them when
3661 saving a temporary copy of the iterator and restoring it back.
3662 (back_to_previous_visible_line_start, reseat_1)
3663 (init_iterator): Empty the bidi cache "stack".
3664 (move_it_in_display_line_to): If iterator ended up at
3665 EOL, but we never saw any buffer positions smaller than
3666 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3667 motion in bidi-reordered lines.
3668 (move_it_in_display_line_to): Record prev_method and prev_pos
3669 immediately before the call to set_iterator_to_next. Fixes cursor
3670 motion in bidi-reordered lines with stretch glyphs and strings
3671 displayed in margins. (Bug#8133) (Bug#8867)
3672 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3673 TO_CHARPOS.
3674 (pos_visible_p): Support positions in bidi-reordered lines.
3675 Save and restore bidi cache.
3676
3677 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3678 (bidi_paragraph_info): Delete unused struct.
3679 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3680 (bidi_cache_start): New variable.
3681 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3682 to zero.
3683 (bidi_cache_fetch_state, bidi_cache_search)
3684 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3685 (bidi_cache_find, bidi_peek_at_next_level)
3686 (bidi_level_of_next_char, bidi_find_other_level_edge)
3687 (bidi_move_to_visually_next): Compare cache index with
3688 bidi_cache_start rather than with zero.
3689 (bidi_fetch_char): Accept new argument STRING; all callers
3690 changed. Support iteration over a string. Support strings with
3691 display properties. Support unibyte strings. Fix the type of
3692 `len' according to what STRING_CHAR_AND_LENGTH expects.
3693 (bidi_paragraph_init, bidi_resolve_explicit_1)
3694 (bidi_resolve_explicit, bidi_resolve_weak)
3695 (bidi_level_of_next_char, bidi_move_to_visually_next):
3696 Support iteration over a string.
3697 (bidi_set_sor_type, bidi_resolve_explicit_1)
3698 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3699 can now be zero (for strings); special values 0 and -1 were
3700 changed to -1 and -2, respectively.
3701 (bidi_char_at_pos): New function.
3702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3703 Call it instead of FETCH_MULTIBYTE_CHAR.
3704 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3705 initialized to valid values.
3706 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3707 values.
3708 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3709 the test for valid cached positions. Fix the logic for looking up
3710 the sentinel state in the cache. GCPRO the Lisp string we are
3711 iterating.
3712 (bidi_push_it, bidi_pop_it): New functions.
3713 (bidi_initialize): Initialize the bidi cache start stack pointer.
3714 (bidi_cache_ensure_space): New function, refactored from part of
3715 bidi_cache_iterator_state. Don't assume the required size is just
3716 one BIDI_CACHE_CHUNK away.
3717 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3718 (bidi_count_bytes, bidi_char_at_pos): New functions.
3719 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3720 always valid if bidi_cache_idx is valid.
3721 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3722 is valid if it's going to be used.
3723 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3724 (bidi_cache_fetch_state, bidi_cache_search)
3725 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3726 (bidi_cache_iterator_state, bidi_cache_find)
3727 (bidi_find_other_level_edge, bidi_cache_start_stack):
3728 All variables related to cache indices are now EMACS_INT.
3729
3730 * dispextern.h (struct bidi_string_data): New structure.
3731 (struct bidi_it): New member `string'. Make flag members be 1-bit
3732 fields, and put them last in the struct.
3733 (compute_display_string_pos, compute_display_string_end):
3734 Update prototypes.
3735 (bidi_push_it, bidi_pop_it): Add prototypes.
3736 (struct iterator_stack_entry): New members bidi_p,
3737 paragraph_embedding, and from_disp_prop_p.
3738 (struct it): Member bidi_p is now a bit field 1 bit wide.
3739 (bidi_shelve_cache, bidi_unshelve_cache):
3740 Declare prototypes.
3741
3742 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3743 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3744 and vector-like objects.
3745
3746 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3747 cache around display iteration.
3748
3749 * window.c (Fwindow_end, window_scroll_pixel_based)
3750 (displayed_window_lines, Frecenter): Save and restore the bidi
3751 cache around display iteration.
3752
3753 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754
3755 * editfns.c (Fdelete_region): Clarify the use of the named
3756 parameters (bug#6788).
3757
3758 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3759
3760 * indent.c (Fvertical_motion): Set and restore w->pointm when
3761 saving and restoring the window's buffer (Bug#9006).
3762
3763 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3764
3765 * editfns.c (Fstring_to_char): Clarify just what is returned
3766 (bug#6576). Text by Eli Zaretskii.
3767
3768 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3771
3772 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3773
3774 * buffer.c (mmap_find): Fix a typo.
3775
3776 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3777
3778 Fix execution of x selection hooks.
3779 * xselect.c (Qx_lost_selection_functions)
3780 (Qx_sent_selection_functions): New vars.
3781 (syms_of_xselect): DEFSYM them.
3782 (x_handle_selection_request): Pass Qx_sent_selection_functions
3783 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3784 (x_handle_selection_clear,x_clear_frame_selections):
3785 Pass Qx_lost_selection_functions rather than
3786 Vx_lost_selection_functions to Frun_hook_with_args.
3787
3788 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3791 The old code sometimes used this field without initializing it.
3792
3793 * alloc.c (gc_sweep): Don't read past end of array.
3794 In theory, the old code could also have corrupted Emacs internals,
3795 though it'd be very unlikely.
3796
3797 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3798
3799 * character.c (Fcharacterp): Don't advertise optional ignored
3800 argument. (Bug#4026)
3801
3802 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
3804 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3805 key" (bug#4257).
3806
3807 * window.c (Fset_window_start): Doc fix (bug#4199).
3808 (Fset_window_hscroll): Ditto.
3809
3810 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Fix minor new problems caught by GCC 4.6.1.
3813 * term.c (init_tty): Remove unused local.
3814 * xsettings.c (store_monospaced_changed): Define this function only
3815 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3816 not used otherwise.
3817
3818 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3821
3822 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3823
3824 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3825 are the mini-buffer and the echo area (bug#3320).
3826
3827 * term.c (init_tty): Remove support for supdup, c10 and perq
3828 terminals, which are no longer supported (bug#1482).
3829
3830 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3831
3832 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3833
3834 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3835
3836 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3837 for non-popups (Bug#3642).
3838
3839 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * alloc.c (reset_malloc_hooks): Protoize.
3842 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3843 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3844 * cm.c (losecursor): Likewise.
3845 * data.c (fmod): Likewise.
3846 * dispnew.c (swap_glyphs_in_rows): Likewise.
3847 * emacs.c (memory_warning_signal): Likewise.
3848 * floatfns.c (float_error): Likewise.
3849 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3850 (otf_open, font_otf_capability, generate_otf_features)
3851 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3852 Likewise.
3853 * image.c (pbm_read_file): Likewise.
3854 * indent.c (string_display_width): Likewise.
3855 * intervals.c (check_for_interval, search_for_interval)
3856 (inc_interval_count, count_intervals, root_interval)
3857 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3858 * lread.c (defalias): Likewise.
3859 * ralloc.c (r_alloc_check): Likewise.
3860 * regex.c (set_image_of_range_1, set_image_of_range)
3861 (regex_grow_registers): Likewise.
3862 * sysdep.c (strerror): Likewise.
3863 * termcap.c (valid_filename_p, tprint, main): Likewise.
3864 * tparam.c (main): Likewise.
3865 * unexhp9k800.c (run_time_remap, save_data_space)
3866 (update_file_ptrs, read_header, write_header, calculate_checksum)
3867 (copy_file, copy_rest, display_header): Likewise.
3868 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3869 Likewise.
3870 * xdisp.c (check_it): Likewise.
3871 * xfaces.c (register_color, unregister_color, unregister_colors):
3872 Likewise.
3873 * xfns.c (print_fontset_result): Likewise.
3874 * xrdb.c (member, fatal, main): Likewise.
3875
3876 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 Fix minor problems found by static checking (Bug#9031).
3879 * chartab.c (char_table_set_range, map_sub_char_table):
3880 Remove unused locals.
3881 (uniprop_table): Now static.
3882 * composite.c (_work_char): Remove unused static var.
3883
3884 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3885
3886 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3887
3888 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * gtkutil.c (qttip_cb): Remove code without function.
3891
3892 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3893
3894 * w32.c (pthread_sigmask): New stub.
3895
3896 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3897
3898 Use pthread_sigmask, not sigprocmask (Bug#9010).
3899 sigprocmask is portable only for single-threaded applications, and
3900 Emacs can be multi-threaded when it uses GTK.
3901 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3902 (LIBES): Use it.
3903 * callproc.c (Fcall_process):
3904 * process.c (create_process):
3905 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3906 Use pthread_sigmask, not sigprocmask.
3907
3908 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3909
3910 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3911 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3912 wrong (Bug#8591).
3913
3914 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3915
3916 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3917 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3918 (xg_hide_tooltip): Fix comment.
3919
3920 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3921 in registerServicesMenuSendTypes.
3922 (validRequestorForSendType): Don't check ns_return_types.
3923
3924 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3925 ns_return_type.
3926
3927 2011-07-08 Jason Rumney <jasonr@gnu.org>
3928
3929 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3930 SH_SHOW for hidden windows (Bug#5482).
3931
3932 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3933 frame struct members of non-existent frames (Bug#6284).
3934
3935 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3936
3937 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3938 variable firstTime not needed on OSX >= 10.6.
3939 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3940 >= 10.5. Use setKnobProportion, setDoubleValue.
3941
3942 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3943 (MAC_OS_X_VERSION_10_5): Define if not defined.
3944 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3945 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3946 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3947
3948 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3949 cString and lossyCString on OSX >= 10.4
3950
3951 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3952 sizeToFit on OSX >= 10.2.
3953
3954 * nsimage.m (allocInitFromFile): Don't use deprecated method
3955 bestRepresentationForDevice on OSX >= 10.6.
3956
3957 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3958 to avoid warning.
3959
3960 * emacs.c: Declare unexec_init_emacs_zone.
3961
3962 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3963
3964 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3965
3966 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3967 on svcsMenu (Bug#8842).
3968
3969 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3970 ns_return_types.
3971 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3972
3973 * nsterm.m (QUTF8_STRING): Declare.
3974 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3975 (validRequestorForSendType): Return type is (id).
3976 Change indexOfObjectIdenticalTo to indexOfObject.
3977 Check if we have local selection before returning self (Bug#8842).
3978 (writeSelectionToPasteboard): Put local selection into paste board
3979 if we have a local selection (Bug#8842).
3980 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3981
3982 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3983 (ns_get_local_selection): Declare.
3984
3985 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3986
3987 * keymap.c (describe_map_tree): Don't insert a double newline at
3988 the end of the buffer (bug#1169) and return whether we inserted
3989 something.
3990
3991 * callint.c (Fcall_interactively): Change "reading args" to
3992 "providing args" to try to clarify what it does (bug#1010).
3993
3994 2011-07-07 Kenichi Handa <handa@m17n.org>
3995
3996 * composite.c (composition_compute_stop_pos): Ignore a static
3997 composition starting before CHARPOS (Bug#8915).
3998
3999 * xdisp.c (handle_composition_prop): Likewise.
4000
4001 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4002
4003 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4004 (Bug#9015)
4005
4006 2011-07-07 Kenichi Handa <handa@m17n.org>
4007
4008 * character.h (unicode_category_t): New enum type.
4009
4010 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4011 (Qchar_code_property_table): New variable.
4012 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4013 (UNIPROP_COMPRESSED_FORM_P): New macros.
4014 (char_table_ascii): Uncompress the compressed values.
4015 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4016 Uncompress the compressed values.
4017 (sub_char_table_ref_and_range): Likewise.
4018 (char_table_ref_and_range): Uncompress the compressed values.
4019 (sub_char_table_set): New arg is_uniprop. Callers changed.
4020 Uncompress the compressed values.
4021 (sub_char_table_set_range): Args changed. Callers changed.
4022 (char_table_set_range): Adjuted for the above change.
4023 (map_sub_char_table): Delete args default_val and parent. Add arg
4024 top. Give decoded values to a Lisp function.
4025 (map_char_table): Adjust for the above change. Give decoded
4026 values to a Lisp function. Gcpro more variables.
4027 (uniprop_table_uncompress)
4028 (uniprop_decode_value_run_length): New functions.
4029 (uniprop_decoder, uniprop_decoder_count): New variables.
4030 (uniprop_get_decoder, uniprop_encode_value_character)
4031 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4032 New functions.
4033 (uniprop_encoder, uniprop_encoder_count): New variables.
4034 (uniprop_get_encoder, uniprop_table)
4035 (Funicode_property_table_internal, Fget_unicode_property_internal)
4036 (Fput_unicode_property_internal): New functions.
4037 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4038 Sunicode_property_table_internal, Sget_unicode_property_internal,
4039 and Sput_unicode_property_internal. Defvar_lisp
4040 char-code-property-alist.
4041
4042 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4043 Vunicode_category_table.
4044
4045 * font.c (font_range): Adjust for the change of
4046 Vunicode_category_table.
4047
4048 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4049
4050 * m/iris4d.h: Remove file, move contents ...
4051 * s/irix6-5.h: ... here.
4052
4053 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 Remove unportable assumption about struct layout (Bug#8884).
4056 * alloc.c (mark_buffer):
4057 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4058 (clone_per_buffer_values): Don't assume that
4059 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4060 This isn't true in general, and it's particularly not true
4061 if Emacs is configured with --with-wide-int.
4062 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4063 New macros, used in the buffer.c change.
4064
4065 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4066
4067 * xsettings.c: Use both GConf and GSettings if both are available.
4068 (store_config_changed_event): Add comment.
4069 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4070 (store_tool_bar_style_changed): New functions.
4071 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4072 (struct xsettings): Move font inside HAVE_XFT.
4073 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4074 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4075 Move inside HAVE_XFT.
4076 (something_changed_gsettingsCB): Rename from something_changedCB.
4077 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4078 also.
4079 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4080 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4081 (something_changed_gconfCB): Rename from something_changedCB.
4082 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4083 (parse_settings): Move check for font inside HAVE_XFT.
4084 (read_settings, apply_xft_settings): Add comment.
4085 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4086 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4087 call store_font_name_changed.
4088 (xft_settings_event): Add comment.
4089 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4090 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4091 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4092 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4093 (xsettings_initialize): Call init_gsettings last.
4094 (xsettings_get_system_font, xsettings_get_system_normal_font):
4095 Add comment.
4096
4097 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 Random fixes. E.g., (random) never returned negative values.
4100 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4101 subseconds part to the entropy, as that's a bit more random.
4102 Prefer signed to unsigned, since the signedness doesn't matter and
4103 in general we prefer signed. When given a limit, use a
4104 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4105 latter isn't right if USE_2_TAGS_FOR_INTS.
4106 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4107 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4108
4109 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * textprop.c (text_property_stickiness):
4112 Obey Vtext_property_default_nonsticky.
4113 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4114 * w32fns.c (syms_of_w32fns):
4115 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4116
4117 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4118
4119 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4120 This is more efficient than Ffile_directory_p and avoids a minor race.
4121
4122 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4123
4124 * buffer.c (Foverlay_put): Say what the return value is
4125 (bug#7835).
4126
4127 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4128 is a directory before asking whether to use the file name
4129 (bug#7564).
4130 (barf_or_query_if_file_exists): Make the "File is a directory"
4131 error be more correct.
4132
4133 * fns.c (Frequire): Remove the mention of the .gz files, since
4134 that's installation-specific, but keep the mention of
4135 `get-load-suffixes'.
4136
4137 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4140 Report string overflow if the output is too long.
4141
4142 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4145 (syms_of_gnutls): Remove duplicate DEFSYM for
4146 Qgnutls_bootprop_verify_hostname_error, an error for
4147 Qgnutls_bootprop_verify_error (which is no longer used).
4148
4149 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4150 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4151 Also (re)move comments that are misplaced or no longer relevant.
4152
4153 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154
4155 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4156
4157 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4158
4159 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4160 and background color parameters if they have been changed.
4161
4162 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163
4164 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4165
4166 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * xsettings.c (SYSTEM_FONT): Define only when used.
4169 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4170
4171 * keymap.c (access_keymap_1): Now static.
4172
4173 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4174
4175 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4176 leave any prefix arg for the up event (Bug#1586).
4177
4178 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4179
4180 * lread.c (syms_of_lread): Mention single symbols defined by
4181 `defvar' or `defconst' (bug#7154).
4182
4183 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4184 (Frequire): Mention get-load-suffixes.
4185
4186 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4187
4188 * window.h (window): Remove clone_number slot.
4189 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4190 Remove.
4191 (make_parent_window, make_window, saved_window)
4192 (Fset_window_configuration, save_window_save): Don't deal with
4193 clone numbers.
4194 * buffer.c (Qclone_number): Remove declaration.
4195 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4196
4197 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 Add multiple inheritance to keymaps.
4200 * keymap.c (Fmake_composed_keymap): New function.
4201 (Fset_keymap_parent): Simplify.
4202 (fix_submap_inheritance): Remove.
4203 (access_keymap_1): New function extracted from access_keymap to handle
4204 embedded parents and handle lists of maps.
4205 (access_keymap): Use it.
4206 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4207 (Fcopy_keymap): Handle embedded parents.
4208 (Fcommand_remapping, define_as_prefix): Simplify.
4209 (Fkey_binding): Simplify.
4210 (syms_of_keymap): Move minibuffer-local-completion-map,
4211 minibuffer-local-filename-completion-map,
4212 minibuffer-local-must-match-map, and
4213 minibuffer-local-filename-must-match-map to Elisp.
4214 (syms_of_keymap): Defsubr make-composed-keymap.
4215 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4216 (parse_menu_item): Trivial simplification.
4217
4218 2011-07-01 Glenn Morris <rgm@gnu.org>
4219
4220 * Makefile.in (SETTINGS_LIBS): Fix typo.
4221
4222 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4223
4224 * coding.c (Fencode_coding_string): Record the last coding system
4225 used, as the function doc string says (bug#8738).
4226
4227 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4228
4229 * xsettings.c (store_monospaced_changed): Take new font as arg and
4230 check for change against current_mono_font.
4231 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4232 (emacs_settings_constructor, emacs_settings_get_property)
4233 (emacs_settings_set_property, emacs_settings_class_init)
4234 (emacs_settings_init, gsettings_obj): Remove.
4235 (something_changedCB): New function for HAVE_GSETTINGS.
4236 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4237 with value as argument.
4238 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4239 g_settings_new (Bug#8967). Do not create gsettings_obj.
4240 Remove calls to g_settings_bind. Connect something_changedCB to
4241 "changed".
4242
4243 * xgselect.c: Add defined (HAVE_GSETTINGS).
4244 (xgselect_initialize): Ditto.
4245
4246 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4247 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4248 xg_select.
4249
4250 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 * eval.c (struct backtrace): Simplify and port the data structure.
4253 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4254 signed bit field, as this assumption is not portable and it makes
4255 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4256 "char debug_on_exit : 1" as this is not portable either; instead,
4257 use the portable "unsigned int debug_on_exit : 1". Remove unused
4258 member evalargs. Remove obsolete comments about cc bombing out.
4259
4260 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4261
4262 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4263 Let HAVE_GSETTINGS override HAVE_GCONF.
4264 (store_monospaced_changed): New function.
4265 (EMACS_SETTINGS): A new type derived from GObject to handle
4266 GSettings notifications.
4267 (emacs_settings_constructor, emacs_settings_get_property)
4268 (emacs_settings_set_property, emacs_settings_class_init):
4269 New functions.
4270 (gsettings_client, gsettings_obj): New variables.
4271 (GSETTINGS_SCHEMA): New define.
4272 (something_changedCB): Call store_monospaced_changed.
4273 (init_gsettings): New function.
4274 (xsettings_initialize): Call init_gsettings.
4275 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4276 to NULL.
4277
4278 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4279 GCONF_CFLAGS/LIBS.
4280
4281 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4282
4283 * window.c (resize_root_window, grow_mini_window)
4284 (shrink_mini_window): Rename Qresize_root_window to
4285 Qwindow_resize_root_window and Qresize_root_window_vertically to
4286 Qwindow_resize_root_window_vertically.
4287
4288 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4289
4290 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4291
4292 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * makefile.w32-in: Redesign dependencies so they reflect more
4295 clearly which files are directly included by each source file,
4296 and not through other includes.
4297
4298 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4299
4300 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4301 (sort_overlays, overlay_strings): When an overlay's clone number
4302 matches the window's clone number process the overlay even if
4303 the overlay's window property doesn't match the current window.
4304
4305 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4306 (Fwindow_hchild): Rename to Fwindow_left_child.
4307 (Fwindow_next): Rename to Fwindow_next_sibling.
4308 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4309 (resize_window_check): Rename to window_resize_check.
4310 (resize_window_apply): Rename to window_resize_apply.
4311 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4312 (Fdelete_other_windows_internal, resize_frame_windows)
4313 (Fsplit_window_internal, Fdelete_window_internal)
4314 (grow_mini_window, shrink_mini_window)
4315 (Fresize_mini_window_internal): Fix callers accordingly.
4316
4317 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4320 (emacs_fixed_set_min_size): Remove.
4321 (emacs_fixed_new): Take frame as argument.
4322
4323 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4324 (_EmacsFixedPrivate): Remove minwidth/height.
4325 Add struct frame *f.
4326 (emacs_fixed_init): Initialize priv->f.
4327 (get_parent_class, emacs_fixed_set_min_size): Remove.
4328 (emacs_fixed_new): Set priv->f to argument.
4329 (emacs_fixed_get_preferred_width)
4330 (emacs_fixed_get_preferred_height): Use min_width/height from
4331 frames size_hint to set minimum and natural (Bug#8919).
4332 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4333 and use min_width/height from frames size_hint to set
4334 min_width/height (Bug#8919).
4335
4336 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4337 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4338 Fix indentation.
4339
4340 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4341
4342 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4343 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4344 called at ZV.
4345
4346 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4347
4348 * process.c (wait_reading_process_output): Bypass select if
4349 waiting for a cell while ignoring keyboard input, and input is
4350 pending. Suggested by Jan Djärv (Bug#8869).
4351
4352 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 Use gnulib's dup2 module instead of rolling our own.
4355 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4356
4357 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4358
4359 * dispnew.c (scrolling_window): Before scrolling, turn off a
4360 mouse-highlight in the window being scrolled.
4361
4362 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4363
4364 Move DEFSYM to lisp.h and use everywhere.
4365
4366 * character.h (DEFSYM): Move declaration...
4367 * lisp.h (DEFSYM): ...here.
4368
4369 * gnutls.c:
4370 * minibuf.c:
4371 * w32menu.c:
4372 * w32proc.c:
4373 * w32select.c: Don't include character.h.
4374
4375 * alloc.c (syms_of_alloc):
4376 * buffer.c (syms_of_buffer):
4377 * bytecode.c (syms_of_bytecode):
4378 * callint.c (syms_of_callint):
4379 * casefiddle.c (syms_of_casefiddle):
4380 * casetab.c (init_casetab_once):
4381 * category.c (init_category_once, syms_of_category):
4382 * ccl.c (syms_of_ccl):
4383 * cmds.c (syms_of_cmds):
4384 * composite.c (syms_of_composite):
4385 * dbusbind.c (syms_of_dbusbind):
4386 * dired.c (syms_of_dired):
4387 * dispnew.c (syms_of_display):
4388 * doc.c (syms_of_doc):
4389 * editfns.c (syms_of_editfns):
4390 * emacs.c (syms_of_emacs):
4391 * eval.c (syms_of_eval):
4392 * fileio.c (syms_of_fileio):
4393 * fns.c (syms_of_fns):
4394 * frame.c (syms_of_frame):
4395 * fringe.c (syms_of_fringe):
4396 * insdel.c (syms_of_insdel):
4397 * keymap.c (syms_of_keymap):
4398 * lread.c (init_obarray, syms_of_lread):
4399 * macros.c (syms_of_macros):
4400 * msdos.c (syms_of_msdos):
4401 * print.c (syms_of_print):
4402 * process.c (syms_of_process):
4403 * search.c (syms_of_search):
4404 * sound.c (syms_of_sound):
4405 * syntax.c (init_syntax_once, syms_of_syntax):
4406 * terminal.c (syms_of_terminal):
4407 * textprop.c (syms_of_textprop):
4408 * undo.c (syms_of_undo):
4409 * w32.c (globals_of_w32):
4410 * window.c (syms_of_window):
4411 * xdisp.c (syms_of_xdisp):
4412 * xfaces.c (syms_of_xfaces):
4413 * xfns.c (syms_of_xfns):
4414 * xmenu.c (syms_of_xmenu):
4415 * xsettings.c (syms_of_xsettings):
4416 * xterm.c (syms_of_xterm): Use DEFSYM.
4417
4418 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4419
4420 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4421
4422 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 Integer and buffer overflow fixes (Bug#8873).
4425
4426 * print.c (printchar, strout): Check for string overflow.
4427 (PRINTPREPARE, printchar, strout):
4428 Don't set size unless allocation succeeds.
4429
4430 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4431 for sizes. Check for string overflow more accurately.
4432 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4433
4434 * macros.c: Integer and buffer overflow fixes.
4435 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4436 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4437 Use ptrdiff_t, not int, for sizes.
4438 Don't increment bufsize until after realloc succeeds.
4439 Check for size-calculation overflow.
4440 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4441
4442 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4443
4444 * lread.c: Integer overflow fixes.
4445 (read_integer): Radix is now EMACS_INT, not int,
4446 to improve quality of diagnostics for out-of-range radices.
4447 Calculate buffer size correctly for out-of-range radices.
4448 (read1): Check for integer overflow in radices, and in
4449 read-circle numbers.
4450 (read_escape): Avoid int overflow.
4451 (Fload, openp, read_buffer_size, read1)
4452 (substitute_object_recurse, read_vector, read_list, map_obarray):
4453 Use ptrdiff_t, not int, for sizes.
4454 (read1): Use EMACS_INT, not int, for sizes.
4455 Check for size overflow.
4456
4457 * image.c (cache_image): Check for size arithmetic overflow.
4458
4459 * lread.c: Integer overflow issues.
4460 (saved_doc_string_size, saved_doc_string_length)
4461 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4462 Now ptrdiff_t, not int.
4463 (read1): Don't assume doc string length fits in int. Check for
4464 out-of-range doc string lengths.
4465 (read_list): Don't assume file position fits in int.
4466 (read_escape): Check for hex character overflow.
4467
4468 2011-06-22 Leo Liu <sdl.web@gmail.com>
4469
4470 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4471 Move to minibuffer.el.
4472
4473 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4474
4475 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4476 The following patches are for when GLYPH_DEBUG && !XASSERT.
4477 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4478 * dispnew.c (flush_stdout):
4479 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4480 Mark as externally visible.
4481 * dispnew.c (check_window_matrix_pointers): Now static.
4482 * dispnew.c (window_to_frame_vpos):
4483 * xfns.c (unwind_create_frame):
4484 * xterm.c (x_check_font): Remove unused local.
4485 * scroll.c (CHECK_BOUNDS):
4486 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4487 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4488 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4489 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4490 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4491 Now static.
4492 (debug_method_add): Use va_list and vsprintf rather than relying
4493 on undefined behavior with wrong number of arguments.
4494 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4495 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4496 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4497 since we're not interested in debugging glyphs with old libraries.
4498 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4499 GCC 4.6.0's static checking.
4500
4501 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4502
4503 Integer overflow and signedness fixes (Bug#8873).
4504 A few related buffer overrun fixes, too.
4505
4506 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4507
4508 * dispextern.h (struct face.stipple):
4509 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4510 (x_bitmap_mask, x_allocate_bitmap_record)
4511 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4512 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4513 (x_create_bitmap_from_xpm_data):
4514 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4515 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4516 (.bitmaps_last):
4517 * xfaces.c (load_pixmap):
4518 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4519 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4520 (.bitmaps_last, struct x_output.icon_bitmap):
4521 Use ptrdiff_t, not int, for bitmap indexes.
4522 (x_allocate_bitmap_record): Check for size overflow.
4523 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4524
4525 Use ptrdiff_t, not int, for overlay counts.
4526 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4527 * editfns.c (overlays_around, get_pos_property):
4528 * textprop.c (get_char_property_and_overlay):
4529 * xdisp.c (next_overlay_change, note_mouse_highlight):
4530 * xfaces.c (face_at_buffer_position):
4531 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4532 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4533 (Fnext_overlay_change, Fprevious_overlay_change)
4534 (mouse_face_overlay_overlaps, Foverlays_in):
4535 Use ptrdiff_t, not int, for sizes.
4536 (overlays_at, overlays_in): Check for size-calculation overflow.
4537
4538 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4539
4540 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4541 (x_session_initialize): Do not assume string length fits in int.
4542
4543 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4544 This is unlikely, but can occur if DPI is outlandish.
4545
4546 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4547 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4548
4549 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4550 * xrdb.c (magic_file_p, search_magic_path):
4551 Omit last arg SUFFIX; it was always 0. All callers changed.
4552 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4553
4554 * xfont.c (xfont_match): Avoid need for strlen.
4555
4556 * xfns.c: Don't assume strlen fits in int.
4557 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4558
4559 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4560 not unsigned long, as we prefer signed integers. All callers changed.
4561 Detect integer overflow in repeat count.
4562 (message_dolog): Don't assume print length fits in 39 bytes.
4563 (display_mode_element): Don't assume strlen fits in int.
4564
4565 * termcap.c: Don't assume sizes fit in int and never overflow.
4566 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4567 (gobble_line): Check for size-calculation overflow.
4568
4569 * minibuf.c (Fread_buffer):
4570 * lread.c (intern, intern_c_string):
4571 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4572 Don't assume string length fits in int.
4573
4574 * keyboard.c (parse_tool_bar_item):
4575 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4576
4577 * font.c: Don't assume string length fits in int.
4578 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4579 Use ptrdiff_t, not int.
4580 (font_intern_prop): Don't assume string length fits in int.
4581 Don't assume integer property fits in fixnum.
4582 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4583
4584 * filelock.c: Fix some buffer overrun and integer overflow issues.
4585 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4586 Reformulate so as not to need the command string.
4587 Invoke gzip -cd rather than gunzip, as it's more portable.
4588 (lock_info_type, lock_file_1, lock_file):
4589 Don't assume pid_t and time_t fit in unsigned long.
4590 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4591 (current_lock_owner): Prefer signed type for sizes.
4592 Use memcpy, not strncpy, where memcpy is what is really wanted.
4593 Don't assume (via atoi) that time_t and pid_t fit in int.
4594 Check for time_t and/or pid_t out of range, e.g., via a network share.
4595 Don't alloca where an auto var works fine.
4596
4597 * fileio.c: Fix some integer overflow issues.
4598 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4599 Don't assume string length fits in int.
4600 (directory_file_name): Don't assume string length fits in long.
4601 (make_temp_name): Don't assume pid fits in int, or that its print
4602 length is less than 20.
4603
4604 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4605
4606 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4607
4608 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4609
4610 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4611 We prefer signed integers, even for size calculations.
4612
4613 * emacs.c: Don't assume string length fits in 'int'.
4614 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4615 (main): Don't invoke strlen when not needed.
4616
4617 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4618 (XD_DEBUG_MESSAGE): Don't waste a byte.
4619
4620 * callproc.c (getenv_internal_1, getenv_internal)
4621 (Fgetenv_internal):
4622 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4623
4624 * lread.c (invalid_syntax): Omit length argument.
4625 All uses changed. This doesn't fix a bug, but it simplifies the
4626 code away from its former Hollerith-constant appearance, and it's
4627 one less 'int' to worry about when looking at integer-overflow issues.
4628 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4629
4630 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4631 This didn't break anything, but it didn't help either.
4632 It's confusing to put a bogus integer in a place where the actual
4633 value does not matter.
4634 (LIST_END_P): Remove unused macro and its bogus comment.
4635 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4636
4637 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4638 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4639 implementation.
4640 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4641 We prefer signed types, and the value cannot exceed the EMACS_INT
4642 range anyway (because otherwise the length would not be representable).
4643 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4644 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4645 This avoids a GCC warning when WIDE_EMACS_INT.
4646
4647 * indent.c (sane_tab_width): New function.
4648 (current_column, scan_for_column, Findent_to, position_indentation)
4649 (compute_motion): Use it. This is just for clarity.
4650 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4651
4652 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4653
4654 * lisp.h (lint_assume): New macro.
4655 * composite.c (composition_gstring_put_cache):
4656 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4657
4658 * editfns.c, insdel.c:
4659 Omit unnecessary forward decls, to simplify future changes.
4660
4661 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4662
4663 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4664
4665 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4666 Use much-faster test for byte-length change.
4667 Don't assume string byte-length fits in 'int'.
4668 Check that character arg fits in 'int'.
4669 (mapcar1): Declare byte as byte, for clarity.
4670
4671 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4672
4673 * fns.c (concat): Catch string overflow earlier.
4674 Do not rely on integer wraparound.
4675
4676 * dispextern.h (struct it.overlay_strings_charpos)
4677 (struct it.selective): Now EMACS_INT, not int.
4678 * xdisp.c (forward_to_next_line_start)
4679 (back_to_previous_visible_line_start)
4680 (reseat_at_next_visible_line_start, next_element_from_buffer):
4681 Don't arbitrarily truncate the value of 'selective' to int.
4682
4683 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4684
4685 * composite.c: Don't truncate sizes to 'int'.
4686 (composition_gstring_p, composition_reseat_it)
4687 (composition_adjust_point): Use EMACS_INT, not int.
4688 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4689 not EMACS_UINT, for indexes.
4690
4691 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4692
4693 * buffer.c: Include <verify.h>.
4694 (struct sortvec.priority, struct sortstr.priority):
4695 Now EMACS_INT, not int.
4696 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4697 (struct sortstr.size, record_overlay_string)
4698 (struct sortstrlist.size, struct sortlist.used):
4699 Don't truncate size to int.
4700 (record_overlay_string): Check for size-calculation overflow.
4701 (init_buffer_once): Check at compile-time, not run-time.
4702
4703 2011-06-22 Jim Meyering <meyering@redhat.com>
4704
4705 Don't leak an XBM-image-sized buffer
4706 * image.c (xbm_load): Free the image buffer after using it.
4707
4708 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4709
4710 Port to Sun C.
4711 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4712 that Sun C diagnosed.
4713 * fns.c (secure_hash): Fix pointer signedness issue.
4714 * intervals.c (static_offset_intervals): New function.
4715 (offset_intervals): Use it.
4716
4717 2011-06-21 Leo Liu <sdl.web@gmail.com>
4718
4719 * deps.mk (fns.o):
4720 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4721 sha512.h.
4722
4723 * fns.c (secure_hash): Rename from crypto_hash_function and change
4724 the first arg to accept symbols.
4725 (Fsecure_hash): New primitive.
4726 (syms_of_fns): New symbols.
4727
4728 2011-06-20 Deniz Dogan <deniz@dogan.se>
4729
4730 * process.c (Fset_process_buffer): Clarify return value in
4731 docstring.
4732
4733 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4734
4735 * dispnew.c (add_window_display_history): Use BVAR.
4736
4737 * xdisp.c (debug_method_add): Use BVAR.
4738 (check_window_end, dump_glyph_matrix, dump_glyph)
4739 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4740
4741 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4742 Likewise.
4743
4744 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4745 check till after the cache is created in init_frame_faces.
4746
4747 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4750
4751 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4754 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4755 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4756
4757 Improve buffer-overflow checking (Bug#8873).
4758 * fileio.c (Finsert_file_contents):
4759 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4760 Remove the old (too-loose) buffer overflow checks.
4761 They weren't needed, since make_gap checks for buffer overflow.
4762 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4763 The old code merely checked for Emacs fixnum overflow, and relied
4764 on undefined (wraparound) behavior. The new code avoids undefined
4765 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4766
4767 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4768 Tune. Don't use wider integers than needed. Don't use alloca.
4769 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4770
4771 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4772
4773 * insdel.c, lisp.h (buffer_overflow): New function.
4774 (insert_from_buffer_1, replace_range, replace_range_2):
4775 * insdel.c (make_gap_larger):
4776 * editfns.c (Finsert_char):
4777 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4778
4779 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4780
4781 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4784
4785 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4786 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4787
4788 * fileio.c: Don't assume EMACS_INT fits in off_t.
4789 (emacs_lseek): New static function.
4790 (Finsert_file_contents, Fwrite_region): Use it.
4791 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4792
4793 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4794
4795 * fns.c: Don't overflow int when computing a list length.
4796 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4797 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4798 truncation on 64-bit hosts. Check for QUIT every
4799 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4800 faster and is responsive enough.
4801 (Flength): Report an error instead of overflowing an integer.
4802 (Fsafe_length): Return a float if the value is not representable
4803 as a fixnum. This shouldn't happen except in contrived situations.
4804 (Fnthcdr, Fsort): Don't assume list length fits in int.
4805 (Fcopy_sequence): Don't assume vector length fits in int.
4806
4807 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4808 (header_size, word_size): New constants.
4809 (allocate_vectorlike): Don't check size overflow here.
4810 (allocate_vector): Check it here instead, since this is the only
4811 caller of allocate_vectorlike that could cause overflow.
4812 Check that the new vector's length is representable as a fixnum.
4813
4814 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4815 The previous code was bogus. For example, next_almost_prime (32)
4816 returned 39, which is undesirable as it is a multiple of 3; and
4817 next_almost_prime (24) returned 25, which is a multiple of 5 so
4818 why was the code bothering to check for multiples of 7?
4819
4820 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4821
4822 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4823
4824 Variadic C functions now count arguments with ptrdiff_t.
4825 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4826 Back then I didn't know that the Emacs coding style prefers signed int.
4827 Also, in the meantime I found a few more instances where arguments
4828 were being counted with int, which may truncate counts on 64-bit
4829 machines, or EMACS_INT, which may be unnecessarily wide.
4830 * lisp.h (struct Lisp_Subr.function.aMANY)
4831 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4832 Arg counts are now ptrdiff_t, not size_t.
4833 All variadic functions and their callers changed accordingly.
4834 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4835 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4836 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4837 * callint.c (Fcall_interactively): Check arg count for overflow,
4838 to avoid potential buffer overrun. Use signed char, not 'int',
4839 for 'varies' array, so that we needn't bother to check its size
4840 calculation for overflow.
4841 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4842 * eval.c (apply_lambda):
4843 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4844 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4845 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4846
4847 * callint.c (Fcall_interactively): Don't use index var as event count.
4848
4849 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4850 * mem-limits.h (SIZE): Remove; no longer used.
4851
4852 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4853
4854 Remove unnecessary casts.
4855 * xterm.c (x_term_init):
4856 * xfns.c (x_set_border_pixel):
4857 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4858 These aren't needed now that we assume ANSI C.
4859
4860 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4861 It's more likely to cause problems (due to unsigned overflow)
4862 than to cure them.
4863
4864 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4865
4866 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4867
4868 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4869
4870 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4871
4872 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4873
4874 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4875
4876 GLYPH_CODE_FACE returns EMACS_INT, not int.
4877 * dispextern.h (merge_faces):
4878 * xfaces.c (merge_faces):
4879 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4880 Don't assume EMACS_INT fits in int.
4881
4882 * character.h (CHAR_VALID_P): Remove unused parameter.
4883 * fontset.c, lisp.h, xdisp.c: All uses changed.
4884
4885 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4886
4887 * fns.c (concat): Minor tuning based on overflow analysis.
4888 This doesn't fix any bugs. Use int to hold character, instead
4889 of constantly refetching from Emacs object. Use XFASTINT, not
4890 XINT, for value known to be a character. Don't bother comparing
4891 a single byte to 0400, as it's always less.
4892
4893 * floatfns.c (Fexpt):
4894 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4895
4896 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4897 for characters.
4898
4899 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4900
4901 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4902 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4903 incorrectly succeed when S was a string, because 4294967386 was
4904 truncated before it was used.
4905
4906 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4907 Otherwise, an out-of-range integer could cause undefined behavior
4908 on a 64-bit host.
4909
4910 * composite.c: Use int, not EMACS_INT, for characters.
4911 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4912 EMACS_INT, for values that are known to be in character range.
4913 This doesn't fix any bugs but is the usual style inside Emacs and
4914 may generate better code on 32-bit machines.
4915
4916 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4917 This is for reasons similar to the recent CHAR_STRING fix.
4918 * charset.c (Fencode_char): Check that character arg is actually
4919 a character. Pass an int to ENCODE_CHAR.
4920 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4921 wider than 'int', as a compile-time check to prevent future regressions
4922 in this area.
4923
4924 * character.c (char_string): Remove unnecessary casts.
4925
4926 Make sure a 64-bit char is never passed to CHAR_STRING.
4927 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4928 by silently ignoring the top 32 bits, allowing some values
4929 that were far too large to be valid characters.
4930 * character.h: Include <verify.h>.
4931 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4932 arguments are no wider than unsigned, as a compile-time check
4933 to prevent future regressions in this area.
4934 * data.c (Faset):
4935 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4936 (Fsubst_char_in_region):
4937 * fns.c (concat):
4938 * xdisp.c (decode_mode_spec_coding):
4939 Adjust to CHAR_STRING's new requirement.
4940 * editfns.c (Finsert_char, Fsubst_char_in_region):
4941 * fns.c (concat): Check that character args are actually
4942 characters. Without this test, these functions did the wrong
4943 thing with wildly out-of-range values on 64-bit hosts.
4944
4945 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4946 These casts should not be needed on 32-bit hosts, either.
4947 * keyboard.c (read_char):
4948 * lread.c (Fload): Remove casts to unsigned.
4949
4950 * lisp.h (UNSIGNED_CMP): New macro.
4951 This fixes comparison bugs on 64-bit hosts.
4952 (ASCII_CHAR_P): Use it.
4953 * casefiddle.c (casify_object):
4954 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4955 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4956 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4957 * dispextern.h (FACE_FROM_ID):
4958 * keyboard.c (read_char): Use UNSIGNED_CMP.
4959
4960 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4961 not to EMACS_INT, to avoid GCC warning.
4962
4963 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4964
4965 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4966 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4967 isn't needed on 32-bit machines.
4968
4969 * buffer.c (Fgenerate_new_buffer_name):
4970 Use EMACS_INT for count, not int.
4971 (advance_to_char_boundary): Return EMACS_INT, not int.
4972
4973 * data.c (Qcompiled_function): Now static.
4974
4975 * window.c (window_body_lines): Now static.
4976
4977 * image.c (gif_load): Rename local to avoid shadowing.
4978
4979 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4980 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4981 * alloc.c (make_save_value): Integer argument is now of type
4982 ptrdiff_t, not int.
4983 (mark_object): Use ptrdiff_t, not int.
4984 * lisp.h (pD): New macro.
4985 * print.c (print_object): Use it.
4986
4987 * alloc.c: Use EMACS_INT, not int, to count objects.
4988 (total_conses, total_markers, total_symbols, total_vector_size)
4989 (total_free_conses, total_free_markers, total_free_symbols)
4990 (total_free_floats, total_floats, total_free_intervals)
4991 (total_intervals, total_strings, total_free_strings):
4992 Now EMACS_INT, not int. All uses changed.
4993 (Fgarbage_collect): Compute overall total using a double, so that
4994 integer overflow is less likely to be a problem. Check for overflow
4995 when converting back to an integer.
4996 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4997 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4998 These were 'int' variables that could overflow on 64-bit hosts;
4999 they were never used, so remove them instead of repairing them.
5000 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5001 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5002 Previously, this ceilinged at INT_MAX, but that doesn't work on
5003 64-bit machines.
5004 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5005
5006 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5007 (allocate_vectorlike): Check for ptrdiff_t overflow.
5008 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5009 when a (possibly-narrower) signed value would do just as well.
5010 We prefer using signed arithmetic, to avoid comparison confusion.
5011
5012 * alloc.c: Catch some string size overflows that we were missing.
5013 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5014 for convenience in STRING_BYTES_MAX.
5015 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5016 The definition here is exact; the one in lisp.h was approximate.
5017 (allocate_string_data): Check for string overflow. This catches
5018 some instances we weren't catching before. Also, it catches
5019 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5020 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5021 and ptrdiff_t and EMACS_INT are both 64 bits.
5022
5023 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5024 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5025 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5026
5027 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5028
5029 * alloc.c (Fmake_string): Check for out-of-range init.
5030
5031 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5032
5033 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5034
5035 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5036
5037 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5038 xg_get_default_scrollbar_width.
5039
5040 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5041 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5042 (style_changed_cb): Call update_theme_scrollbar_width and call
5043 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5044 all frames (Bug#8505).
5045 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5046 Call gtk_window_set_resizable if HAVE_GTK3.
5047 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5048 and height if HAVE_GTK3 (Bug#8505).
5049 (scroll_bar_width_for_theme): New variable.
5050 (update_theme_scrollbar_width): New function.
5051 (xg_get_default_scrollbar_width): Move code to
5052 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5053 (xg_initialize): Call update_theme_scrollbar_width.
5054
5055 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5056
5057 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5058
5059 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5060
5061 * frame.c (make_frame): Call other_buffer_safely instead of
5062 other_buffer.
5063
5064 * window.c (temp_output_buffer_show): Call display_buffer with
5065 second argument Vtemp_buffer_show_specifiers and reset latter
5066 immediately after the call.
5067 (Vtemp_buffer_show_specifiers): New variable.
5068 (auto_window_vscroll_p, next_screen_context_lines)
5069 (Vscroll_preserve_screen_position): Remove leading asterisks from
5070 doc-strings.
5071
5072 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 Fix minor problems found by GCC 4.6.0 static checking.
5075 * buffer.c (Qclone_number): Remove for now, as it's unused.
5076 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5077 (record_buffer): Remove unused local.
5078 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5079 (set_frame_buffer_list): Remove; unused.
5080 * frame.h (other_visible_frames): Remove decl.
5081 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5082 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5083 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5084 if HAVE_GPM.
5085 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5086 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5087 Define only if HAVE_GPM.
5088 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5089 (update_hints_inhibit): Remove; never set. All uses removed.
5090 * widgetprv.h (emacsFrameClassRec): Remove decl.
5091 * window.c (delete_deletable_window): Now returns void, since it
5092 wasn't returning anything.
5093 (compare_window_configurations): Remove unused locals.
5094 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5095 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5096 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5097 the same widths as pointers. This follows up on the 2011-05-06 patch.
5098 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5099 * xterm.h: Likewise.
5100 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5101
5102 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * makefile.w32-in: Update dependencies.
5105 (LISP_H): Add lib/intprops.h.
5106
5107 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5108
5109 * image.c (gif_load): Add animation frame delay to the metadata.
5110 (syms_of_image): Use DEFSYM. New symbol `delay'.
5111
5112 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5113
5114 * window.c (delete_deletable_window): Re-add.
5115 (Fset_window_configuration): Rewrite to handle dead buffers and
5116 consequently deletable windows.
5117 (window_tree, Fwindow_tree): Remove. Supply functionality in
5118 window.el.
5119 (compare_window_configurations): Simplify code.
5120
5121 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5122
5123 * image.c (imagemagick_load_image): Fix type mismatch.
5124 (Fimagemagick_types): Likewise.
5125
5126 * window.h (replace_buffer_in_windows): Declare.
5127
5128 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5129
5130 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5131 Qclone_number. Remove external declaration of Qdelete_window.
5132 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5133 code.
5134 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5135 Run Qbuffer_list_update_hook if allowed.
5136 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5137 buffer list implementation.
5138 (other_buffer_safely): New function.
5139 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5140 calls to replace_buffer_in_windows and
5141 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5142 if allowed.
5143 (record_buffer): Inhibit quitting and rewrite using quittable
5144 functions. Run Qbuffer_list_update_hook if allowed.
5145 (Frecord_buffer, Funrecord_buffer): New functions.
5146 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5147 Move switch-to-buffer to window.el.
5148 (bury-buffer): Move to window.el.
5149 (Vbuffer_list_update_hook): New variable.
5150
5151 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5152 section.
5153
5154 * window.h (resize_frame_windows): Move up in code.
5155 (Fwindow_frame): Remove EXFUN.
5156 (replace_buffer_in_all_windows): Remove prototype.
5157 (replace_buffer_in_windows_safely): Add prototype.
5158
5159 * window.c: Declare Qdelete_window static again. Move down
5160 declaration of select_count.
5161 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5162 (Fother_window): Move to window.el.
5163 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5164 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5165 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5166 window.el.
5167 (replace_buffer_in_windows): Implement by calling
5168 Qreplace_buffer_in_windows.
5169 (replace_buffer_in_all_windows): Remove with some functionality
5170 moved into replace_buffer_in_windows_safely.
5171 (replace_buffer_in_windows_safely): New function.
5172 (select_window_norecord, select_frame_norecord): Move in front
5173 of run_window_configuration_change_hook. Remove now obsolete
5174 declarations.
5175 (Fset_window_buffer): Rewrite doc-string.
5176 Call Qrecord_window_buffer.
5177 (keys_of_window): Move binding for other-window to window.el.
5178
5179 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5180
5181 * dispextern.h (struct image): Replace data member, whose int_val
5182 and ptr_val fields were not used by anything, with a single
5183 lisp_val object.
5184
5185 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5186 (gif_clear_image, gif_load, imagemagick_load_image)
5187 (gs_clear_image, gs_load): Callers changed.
5188
5189 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5190
5191 * buffer.h: Include <time.h>, for time_t.
5192 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5193
5194 Fix minor problems found by static checking.
5195
5196 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5197
5198 Make identifiers static if they are not used in other modules.
5199 * data.c (Qcompiled_function, Qframe, Qvector):
5200 * image.c (QimageMagick, Qsvg):
5201 * minibuf.c (Qmetadata):
5202 * window.c (resize_window_check, resize_root_window): Now static.
5203 * window.h (resize_window_check, resize_root_window): Remove decls.
5204
5205 * window.c (window_deletion_count, delete_deletable_window):
5206 Remove; unused.
5207 (window_body_lines): Now static.
5208 (Fdelete_other_windows_internal): Mark vars as initialized.
5209 Make sure 'resize_failed' is initialized.
5210 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5211 (resize_window_apply): Remove unused local.
5212 * window.h (delete_deletable_window): Remove decl.
5213
5214 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5215 (imagemagick_load_image): Fix pointer signedness problem by changing
5216 last arg from unsigned char * to char *. All uses changed.
5217 Also, fix a local for similar reasons.
5218 Remove unused locals. Remove locals to avoid shadowing.
5219 (fn_rsvg_handle_free): Remove; unused.
5220 (svg_load, svg_load_image): Fix pointer signedness problem.
5221 (imagemagick_load_image): Don't use garbage pointer image_wand.
5222
5223 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5224
5225 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5226
5227 * image.c (gif_load): Fix omitted cast error introduced by
5228 2011-06-06 change.
5229
5230 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5231
5232 * window.h (resize_proportionally, orig_total_lines)
5233 (orig_top_line): Remove from window structure.
5234 (set_window_height, set_window_width, change_window_heights)
5235 (Fdelete_window): Remove prototypes.
5236 (resize_frame_windows): Remove duplicate declaration.
5237
5238 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5239
5240 * window.h (resize_frame_windows, resize_window_check)
5241 (delete_deletable_window, resize_root_window)
5242 (resize_frame_windows): Declare prototypes.
5243
5244 * window.c (resize_window_apply): Make definition be "static" to
5245 match the prototype.
5246
5247 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5248
5249 * window.c: Remove declarations of Qwindow_size_fixed,
5250 window_min_size_1, window_min_size_2, window_min_size,
5251 size_window, window_fixed_size_p, enlarge_window, delete_window.
5252 Remove static from declaration of Qdelete_window, it's
5253 temporarily needed by Fbury_buffer.
5254 (replace_window): Don't assign orig_top_line and
5255 orig_total_lines.
5256 (Fdelete_window, delete_window): Remove. Window deletion is
5257 handled by window.el.
5258 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5259 Replace Fdelete_window calls with calls to Qdelete_window.
5260 (Fdelete_other_windows): Remove. Deleting other windows is
5261 handled by window.el.
5262 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5263 handled in window.el.
5264 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5265 Window minimum sizes are handled in window.el.
5266 (shrink_windows, size_window, set_window_height)
5267 (set_window_width, change_window_heights, window_height)
5268 (window_width, CURBEG, CURSIZE, enlarge_window)
5269 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5270 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5271 handled in window.el.
5272 (make_dummy_parent): Rename to make_parent_window and give it a
5273 second argument horflag.
5274 (make_window): Don't set resize_proportionally any more.
5275 (Fsplit_window): Remove. Windows are split in window.el.
5276 (save_restore_action, save_restore_orig_size)
5277 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5278 Resize mini windows in window.el.
5279 (grow_mini_window, shrink_mini_window): Implement by calling
5280 Qresize_root_window_vertically, resize_window_check and
5281 resize_window_apply.
5282 (saved_window, Fset_window_configuration, save_window_save):
5283 Do not handle orig_top_line, orig_total_lines, and
5284 resize_proportionally.
5285 (window_min_height, window_min_width): Move to window.el.
5286 (keys_of_window): Move bindings for delete-other-windows,
5287 split-window, delete-window and enlarge-window to window.el.
5288
5289 * buffer.c: Temporarily extern Qdelete_window.
5290 (Fbury_buffer): Temporarily call Qdelete_window instead of
5291 Fdelete_window (Fbury_buffer will move to window.el soon).
5292
5293 * frame.c (set_menu_bar_lines_1): Remove code handling
5294 orig_top_line and orig_total_lines.
5295
5296 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5297 set_window_height but set heights directly.
5298 (change_frame_size_1): Use resize_frame_windows.
5299
5300 * xdisp.c (init_xdisp): Don't use set_window_height but set
5301 heights directly.
5302
5303 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5304 Use resize_frame_windows instead of change_window_heights and run
5305 run_window_configuration_change_hook.
5306
5307 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5308 instead of change_window_heights and run
5309 run_window_configuration_change_hook.
5310
5311 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5312
5313 * window.c (replace_window): Rename second argument REPLACEMENT to
5314 NEW. New third argument SETFLAG. Rewrite.
5315 (delete_window, make_dummy_parent): Call replace_window with
5316 third argument 1.
5317 (window_list_1): Move down in code.
5318 (run_window_configuration_change_hook): Move set_buffer part
5319 before select_frame_norecord part in order to unwind correctly.
5320 Rename count1 to count.
5321 (recombine_windows, delete_deletable_window, resize_root_window)
5322 (Fdelete_other_windows_internal)
5323 (Frun_window_configuration_change_hook, make_parent_window)
5324 (resize_window_check, resize_window_apply, Fresize_window_apply)
5325 (resize_frame_windows, Fsplit_window_internal)
5326 (Fdelete_window_internal, Fresize_mini_window_internal):
5327 New functions.
5328 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5329
5330 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5331
5332 * window.h (window): Add some new members to window structure -
5333 normal_lines, normal_cols, new_total, new_normal, clone_number,
5334 splits, nest, prev_buffers, next_buffers.
5335 (WINDOW_TOTAL_SIZE): Move here from window.c.
5336 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5337
5338 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5339 Remove.
5340 (make_dummy_parent): Set new members of windows structure.
5341 (make_window): Move down in code. Handle new members of window
5342 structure.
5343 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5344 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5345 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5346 (Fset_window_prev_buffers, Fwindow_next_buffers)
5347 (Fset_window_next_buffers, Fset_window_clone_number):
5348 New functions.
5349 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5350 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5351 Doc-string fixes.
5352 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5353 Argument WINDOW can be now internal window too.
5354 (Fwindow_use_time): Move up in code.
5355 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5356 Rewrite doc-string.
5357 (Fset_window_configuration, saved_window)
5358 (Fcurrent_window_configuration, save_window_save): Handle new
5359 members of window structure.
5360 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5361 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5362 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5363 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5364 Qget_mru_window, Qresize_root_window,
5365 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5366 Qauto_buffer_name; staticpro them.
5367
5368 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5369
5370 * window.c (Fwindow_total_size, Fwindow_left_column)
5371 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5372 (Fwindow_list_1): New functions.
5373 (window_box_text_cols): Replace with window_body_cols.
5374 (Fwindow_width, Fscroll_left, Fscroll_right):
5375 Use window_body_cols instead of window_box_text_cols.
5376 (delete_window, Fset_window_configuration):
5377 Call delete_all_subwindows with window as argument.
5378 (delete_all_subwindows): Take a window as argument and not a
5379 structure. Rewrite.
5380 (window_loop): Remove handling of GET_LRU_WINDOW and
5381 GET_LARGEST_WINDOW.
5382 (Fget_lru_window, Fget_largest_window): Move to window.el.
5383
5384 * window.h: Extern window_body_cols instead of
5385 window_box_text_cols. delete_all_subwindows now takes a
5386 Lisp_Object as argument.
5387
5388 * indent.c (compute_motion, Fcompute_motion):
5389 Use window_body_cols instead of window_box_text_cols.
5390
5391 * frame.c (delete_frame): Call delete_all_subwindows with root
5392 window as argument.
5393
5394 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5395
5396 * fns.c (Fputhash): Document return value.
5397
5398 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5399
5400 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5401
5402 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 Cons<->int and similar integer overflow fixes (Bug#8794).
5405
5406 Check for overflow when converting integer to cons and back.
5407 * charset.c (Fdefine_charset_internal, Fdecode_char):
5408 Use cons_to_unsigned to catch overflow.
5409 (Fencode_char): Use INTEGER_TO_CONS.
5410 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5411 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5412 * data.c (long_to_cons, cons_to_long): Remove.
5413 (cons_to_unsigned, cons_to_signed): New functions.
5414 These signal an error for invalid or out-of-range values.
5415 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5416 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5417 * font.c (Ffont_variation_glyphs):
5418 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5419 * lisp.h: Include <intprops.h>.
5420 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5421 (cons_to_signed, cons_to_unsigned): New decls.
5422 (long_to_cons, cons_to_long): Remove decls.
5423 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5424 (Fprimitive_undo): Use CONS_TO_INTEGER.
5425 * xfns.c (Fx_window_property): Likewise.
5426 * xselect.c: Include <limits.h>.
5427 (x_own_selection, selection_data_to_lisp_data):
5428 Use INTEGER_TO_CONS.
5429 (x_handle_selection_request, x_handle_selection_clear)
5430 (x_get_foreign_selection, Fx_disown_selection_internal)
5431 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5432 (lisp_data_to_selection_data): Use cons_to_unsigned.
5433 (x_fill_property_data): Use cons_to_signed.
5434 Report values out of range.
5435
5436 Check for buffer and string overflow more precisely.
5437 * buffer.h (BUF_BYTES_MAX): New macro.
5438 * lisp.h (STRING_BYTES_MAX): New macro.
5439 * alloc.c (Fmake_string):
5440 * character.c (string_escape_byte8):
5441 * coding.c (coding_alloc_by_realloc):
5442 * doprnt.c (doprnt):
5443 * editfns.c (Fformat):
5444 * eval.c (verror):
5445 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5446 since they may not be the same number.
5447 * editfns.c (Finsert_char):
5448 * fileio.c (Finsert_file_contents):
5449 Likewise for BUF_BYTES_MAX.
5450
5451 * image.c: Use ptrdiff_t, not int, for sizes.
5452 (slurp_file): Switch from int to ptrdiff_t.
5453 All uses changed.
5454 (slurp_file): Check that file size fits in both size_t (for
5455 malloc) and ptrdiff_t (for sanity and safety).
5456
5457 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5458 if b->modtime has its maximal value.
5459
5460 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5461
5462 Don't assume time_t can fit into int.
5463 * buffer.h (struct buffer.modtime): Now time_t, not int.
5464 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5465 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5466
5467 Minor fixes for signed vs unsigned integers.
5468 * character.h (MAYBE_UNIFY_CHAR):
5469 * charset.c (maybe_unify_char):
5470 * keyboard.c (read_char, reorder_modifiers):
5471 XINT -> XFASTINT, since the integer must be nonnegative.
5472 * ftfont.c (ftfont_spec_pattern):
5473 * keymap.c (access_keymap, silly_event_symbol_error):
5474 XUINT -> XFASTINT, since the integer must be nonnegative.
5475 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5476 since it makes no difference and we prefer signed.
5477 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5478 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5479 nonnegative.
5480
5481 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5482
5483 * window.h (Fwindow_frame): Declare.
5484
5485 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5488 (SPARE_MEMORY): Always define.
5489 (LARGE_REQUEST): Remove.
5490 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5491
5492 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5493
5494 * lisp.h: Move EXFUNS for Fframe_root_window,
5495 Fframe_first_window and Fset_frame_selected_window to window.h.
5496
5497 * window.h: Move EXFUNS for Fframe_root_window,
5498 Fframe_first_window and Fset_frame_selected_window here from
5499 lisp.h.
5500
5501 * frame.c (Fwindow_frame, Fframe_first_window)
5502 (Fframe_root_window, Fframe_selected_window)
5503 (Fset_frame_selected_window): Move to window.c.
5504 (Factive_minibuffer_window): Move to minibuf.c.
5505 (Fother_visible_frames_p): New function.
5506
5507 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5508
5509 * window.c (decode_window, decode_any_window): Move up in code.
5510 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5511 (inhibit_frame_unsplittable): Remove unused variable.
5512 (Fwindow_buffer): Move up and rewrite doc-string.
5513 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5514 (Fwindow_prev): New functions.
5515 (Fwindow_frame): Move here from frame.c. Accept any window as
5516 argument.
5517 (Fframe_root_window, Fframe_first_window)
5518 (Fframe_selected_window): Move here from frame.c. Accept frame
5519 or arbitrary window as argument. Update doc-strings.
5520 (Fminibuffer_window): Move up in code.
5521 (Fwindow_minibuffer_p): Move up in code and simplify.
5522 (Fset_frame_selected_window): Move here from frame.c.
5523 Marginal rewrite.
5524 (Fselected_window, select_window, Fselect_window): Move up in
5525 code. Minor doc-string fixes.
5526
5527 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5530 Do not assume that spare memory exists; that assumption is valid
5531 only if SYSTEM_MALLOC.
5532 (LARGE_REQUEST): New macro, so that the issue of large requests
5533 is separated from the issue of spare memory.
5534
5535 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5536
5537 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5538 format. (Bug#8806)
5539
5540 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5541
5542 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5543 before statements.
5544
5545 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5546
5547 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5548
5549 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5550
5551 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5552 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5553
5554 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5555
5556 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5557
5558 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5559
5560 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5561 (x_clipboard_manager_save): Add return value.
5562 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5563 New error handlers.
5564 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5565 Obey Vx_select_enable_clipboard_manager. Catch errors in
5566 x_clipboard_manager_save (Bug#8779).
5567 (Vx_select_enable_clipboard_manager): New variable.
5568 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5569
5570 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5571
5572 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5573
5574 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5575
5576 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5577 in the current matrix if keep_current_p is non-zero.
5578
5579 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5580
5581 * bidi.c (bidi_level_of_next_char): Fix last change.
5582
5583 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5584
5585 Support bidi reordering of text covered by display properties.
5586
5587 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5588 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5589 (bidi_cache_search, bidi_cache_iterator_state)
5590 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5591 (bidi_level_of_next_char, bidi_move_to_visually_next):
5592 Support character positions inside a run of characters covered by a
5593 display string.
5594 (bidi_paragraph_init, bidi_resolve_explicit_1)
5595 (bidi_level_of_next_char): Call bidi_fetch_char and
5596 bidi_fetch_char_advance instead of FETCH_CHAR and
5597 FETCH_CHAR_ADVANCE.
5598 (bidi_init_it): Initialize new members.
5599 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5600 definitions.
5601 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5602 instead of using explicit *_CHAR codes.
5603 (bidi_resolve_explicit, bidi_resolve_weak):
5604 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5605 bidirectional text is supported only in multibyte buffers.
5606 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5607 it to initialize the frame_window_p member of struct bidi_it.
5608 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5609 (bidi_resolve_explicit, bidi_resolve_weak)
5610 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5611 bidi_it->nchars is non-positive.
5612 (bidi_level_of_next_char): Don't try to lookup the cache for the
5613 next/previous character if nothing is cached there yet, or if we
5614 were just reseat()'ed to a new position.
5615
5616 * xdisp.c (set_cursor_from_row): Set start and stop points
5617 according to the row's direction when priming the loop that looks
5618 for the glyph on which to display cursor.
5619 (single_display_spec_intangible_p): Function deleted.
5620 (display_prop_intangible_p): Reimplement to call
5621 handle_display_spec instead of single_display_spec_intangible_p.
5622 Accept 3 additional arguments needed by handle_display_spec.
5623 This fixes incorrect cursor motion across display property with complex
5624 values: lists, `(when COND...)' forms, etc.
5625 (single_display_spec_string_p): Support property values that are
5626 lists with the argument STRING its top-level element.
5627 (display_prop_string_p): Fix the condition for processing a
5628 property that is a list to be consistent with handle_display_spec.
5629 (handle_display_spec): New function, refactored from the
5630 last portion of handle_display_prop.
5631 (compute_display_string_pos): Accept additional argument
5632 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5633 value of a `display' property is a "replacing spec".
5634 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5635 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5636 the display property, but just return a value indicating whether
5637 the display property will replace the characters it covers.
5638 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5639 frame_window_p members of struct bidi_it.
5640 (compute_display_string_pos, compute_display_string_end):
5641 New functions.
5642 (push_it): Accept second argument POSITION, where pop_it should
5643 jump to continue iteration.
5644 (reseat_1): Initialize bidi_it.disp_pos.
5645
5646 * keyboard.c (adjust_point_for_property): Adjust the call to
5647 display_prop_intangible_p to its new signature.
5648
5649 * dispextern.h (struct bidi_it): New member frame_window_p.
5650 (bidi_init_it): Update prototypes.
5651 (display_prop_intangible_p): Update prototype.
5652 (compute_display_string_pos, compute_display_string_end):
5653 Declare prototypes.
5654 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5655 EMACS_INT.
5656
5657 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5658
5659 Malloc failure behavior now depends on size of allocation.
5660 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5661 * lisp.h: Change signatures accordingly.
5662 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5663 All callers changed. (Bug#8762)
5664
5665 * gnutls.c: Use Emacs's memory allocators.
5666 Without this change, the gnutls library would invoke malloc etc.
5667 directly, which causes problems on non-SYNC_INPUT hosts, and which
5668 runs afoul of improving memory_full behavior. (Bug#8761)
5669 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5670 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5671 xfree instead of the default malloc, realloc, free.
5672 (Fgnutls_boot): No need to check for memory allocation failure,
5673 since xmalloc does that for us.
5674
5675 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5676 * category.c (hash_get_category_set):
5677 * ccl.c (ccl_driver):
5678 * charset.c (Fdefine_charset_internal):
5679 * charset.h (struct charset.hash_index):
5680 * composite.c (get_composition_id, gstring_lookup_cache)
5681 (composition_gstring_put_cache):
5682 * composite.h (struct composition.hash_index):
5683 * dispextern.h (struct image.hash):
5684 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5685 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5686 (hashfn_equal, hashfn_user_defined, make_hash_table)
5687 (maybe_resize_hash_table, hash_lookup, hash_put)
5688 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5689 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5690 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5691 * image.c (make_image, search_image_cache, lookup_image)
5692 (xpm_put_color_table_h):
5693 * lisp.h (struct Lisp_Hash_Table):
5694 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5695 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5696 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5697 * alloc.c (allocate_vectorlike):
5698 Check for overflow in vector size calculations.
5699 * ccl.c (ccl_driver):
5700 Check for overflow when converting EMACS_INT to int.
5701 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5702 need to be updated by these changes.
5703 * fns.c (make_hash_table, maybe_resize_hash_table):
5704 Check for integer overflow with large hash tables.
5705 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5706 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5707 (SXHASH_REDUCE): New macro.
5708 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5709 Use it instead of discarding useful hash info with large hash values.
5710 (sxhash_float): New function.
5711 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5712 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5713 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5714 Rewrite to use FIXNUM_BITS, as this simplifies things.
5715 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5716 Adjust signatures to match updated version of code.
5717 (consing_since_gc): Now EMACS_INT, since a single hash table can
5718 use more than INT_MAX bytes.
5719
5720 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5721
5722 Make it possible to build with GCC-4.6+ -O2 -flto.
5723
5724 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5725
5726 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5727
5728 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5729 Call minibuffer-inactive-mode.
5730
5731 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5734 Update dependencies.
5735
5736 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5737
5738 * data.c (init_data): Remove code for UTS, this system is not
5739 supported anymore.
5740
5741 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5742
5743 Don't force ./temacs to start in terminal mode.
5744
5745 * frame.c (make_initial_frame): Initialize faces in all cases, not
5746 only when CANNOT_DUMP is defined.
5747 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5748
5749 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5750
5751 * dispnew.c (add_window_display_history): Use const for the string
5752 pointer. Remove declaration, not needed.
5753
5754 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5755
5756 Use 'inline', not 'INLINE'.
5757 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5758 * alloc.c, fontset.c (INLINE): Remove.
5759 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5760 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5761 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5762 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5763 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5764
5765 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5766
5767 Make it possible to run ./temacs.
5768
5769 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5770 syms_of_callproc does the same thing. Remove test for
5771 "initialized", do it in the caller.
5772 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5773
5774 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5775
5776 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5777 (read_minibuf): Use get_minibuffer.
5778 (syms_of_minibuf): Use DEFSYM.
5779 (Qmetadata): New var.
5780 * data.c (Qbuffer): Don't make it static.
5781 (syms_of_data): Use DEFSYM.
5782
5783 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5786 (CCL_CODE_MIN): New macro.
5787
5788 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5789
5790 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5791
5792 * eval.c (Qdebug): Now static.
5793 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5794 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5795 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5796
5797 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5798
5799 * image.c: Various fixes to ImageMagick code comments.
5800 (Fimagemagick_types): Doc fix.
5801
5802 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5803
5804 Minor fixes prompted by GCC 4.6.0 warnings.
5805
5806 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5807
5808 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5809 (x_clipboard_manager_save_all): Move extern decl to ...
5810 * xterm.h: ... here, so that it can be checked for consistency.
5811
5812 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5813
5814 * xselect.c (x_clipboard_manager_save_frame)
5815 (x_clipboard_manager_save_all): New functions.
5816 (Fx_clipboard_manager_save): Lisp function deleted.
5817
5818 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5819 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5820
5821 * xterm.h: Update prototype.
5822
5823 2011-05-28 William Xu <william.xwl@gmail.com>
5824
5825 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5826 exiting (Bug#8239).
5827
5828 2011-05-28 Jim Meyering <meyering@redhat.com>
5829
5830 Avoid a sign-extension bug in crypto_hash_function.
5831 * fns.c (to_uchar): Define.
5832 (crypto_hash_function): Use it to convert some newly-signed
5833 variables to unsigned, to avoid sign-extension bugs. For example,
5834 without this change, (md5 "truc") would evaluate to
5835 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5836 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5837 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5838
5839 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 Integer overflow fixes.
5842
5843 * dbusbind.c: Serial number integer overflow fixes.
5844 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5845 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5846 to hold a serial number that is too large for a fixnum.
5847 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5848 Check for serial numbers out of range. Decode any serial number
5849 that was so large that it became a float. (Bug#8722)
5850
5851 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5853 Use XFASTINT rather than XUINT when numbers are nonnegative.
5854 (xd_append_arg, Fdbus_method_return_internal):
5855 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5856 arguments, check that Lisp number is nonnegative, rather than
5857 silently wrapping negative numbers around. (Bug#8722)
5858 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5859 (Bug#8722)
5860
5861 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5862
5863 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5864
5865 ccl: Add integer overflow checks.
5866 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5867 (IN_INT_RANGE): New macros.
5868 (ccl_driver): Use them to check for integer overflow when
5869 decoding a CCL program. Many of the new checks are whether XINT (x)
5870 fits in int; it doesn't always, on 64-bit hosts. The new version
5871 doesn't catch all possible integer overflows, but it's an
5872 improvement. (Bug#8719)
5873
5874 * alloc.c (make_event_array): Use XINT, not XUINT.
5875 There's no need for unsigned here.
5876
5877 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5878 This follows up to the 2011-05-06 change that substituted uintptr_t
5879 for EMACS_INT. This case wasn't caught back then.
5880
5881 Rework Fformat to avoid integer overflow issues.
5882 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5883 now (part of C89). Include <verify.h>.
5884 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5885 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5886 (Fformat): Avoid the prepass trying to compute sizes; it was only
5887 approximate and thus did not catch overflow reliably. Instead, walk
5888 through the format just once, formatting and computing sizes as we go,
5889 checking for integer overflow at every step, and allocating a larger
5890 buffer as needed. Keep track separately whether the format is
5891 multibyte. Keep only the most-recently calculated precision, rather
5892 than them all. Record whether each argument has been converted to
5893 string. Use EMACS_INT, not int, for byte and char and arg counts.
5894 Support field widths and precisions larger than INT_MAX. Avoid
5895 sprintf's undefined behavior with conversion specifications such as %#d
5896 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5897 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5898 formatting out-of-range floating point numbers with int
5899 formats. (Bug#8668)
5900
5901 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5902
5903 * data.c: Avoid integer truncation in expressions involving floats.
5904 * data.c: Include <intprops.h>.
5905 (arith_driver): When there's an integer overflow in an expression
5906 involving floating point, convert the integers to floating point
5907 so that the resulting value does not suffer from catastrophic
5908 integer truncation. For example, on a 64-bit host (* 4
5909 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5910 Do not rely on undefined behavior after integer overflow.
5911
5912 merge count_size_as_multibyte, parse_str_to_multibyte
5913 * character.c, character.h (count_size_as_multibyte):
5914 Rename from parse_str_to_multibyte; all uses changed.
5915 Check for integer overflow.
5916 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5917 since it's now a duplicate of the other. This is more of
5918 a character than a buffer op, so better that it's in character.c.
5919 * fns.c, print.c: Adjust to above changes.
5920
5921 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5924
5925 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5926
5927 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5928 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5929 (x_clipboard_manager_save): Now static.
5930 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5931
5932 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5933 (crypto_hash_function): Now static.
5934 Fix pointer signedness problems. Avoid unnecessary initializations.
5935
5936 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5937
5938 * termhooks.h (Vselection_alist): Make it terminal-local.
5939
5940 * terminal.c (create_terminal): Initialize it.
5941
5942 * xselect.c: Support for clipboard managers.
5943 (Vselection_alist): Move to termhooks.h as terminal-local var.
5944 (LOCAL_SELECTION): New macro.
5945 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5946 (symbol_to_x_atom): Remove gratuitous arg.
5947 (x_handle_selection_request, lisp_data_to_selection_data)
5948 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5949 (x_own_selection, x_get_local_selection, x_convert_selection):
5950 New arg, specifying work frame. Use terminal-local Vselection_alist.
5951 (some_frame_on_display): Delete unused function.
5952 (Fx_own_selection_internal, Fx_get_selection_internal)
5953 (Fx_disown_selection_internal, Fx_selection_owner_p)
5954 (Fx_selection_exists_p): New optional frame arg.
5955 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5956 (x_handle_selection_clear): Don't treat other terminals with the
5957 same keyboard specially. Use the terminal-local Vselection_alist.
5958 (x_clear_frame_selections): Use Frun_hook_with_args.
5959
5960 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5961
5962 * xterm.h: Add support for those atoms.
5963
5964 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5965
5966 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5967 (converted_selections, conversion_fail_tag): New global variables.
5968 (x_selection_request_lisp_error): Free the above.
5969 (x_get_local_selection): Remove unnecessary code.
5970 (x_reply_selection_request): Args changed; handle arbitrary array
5971 of converted selections stored in converted_selections.
5972 Separate the XChangeProperty and SelectionNotify steps.
5973 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5974 (x_convert_selection): New function.
5975 (x_handle_selection_event): Simplify.
5976 (x_get_foreign_selection): Don't ignore incoming requests while
5977 waiting for an answer; this will fail when we implement
5978 SAVE_TARGETS, and seems unnecessary anyway.
5979 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5980 (Vx_sent_selection_functions): Doc fix.
5981
5982 2011-05-26 Leo Liu <sdl.web@gmail.com>
5983
5984 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5985
5986 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5987
5988 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5989
5990 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5991 for fringe update if it has periodic bitmap.
5992 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5993 and fringe_bitmap_periodic_p.
5994
5995 * fringe.c (get_fringe_bitmap_data): New function.
5996 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5997 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5998 row. Mark glyph row for fringe update if periodicity changed.
5999
6000 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6001 for fringe update unless it has periodic bitmap.
6002
6003 2011-05-25 Kenichi Handa <handa@m17n.org>
6004
6005 * xdisp.c (get_next_display_element): Set correct it->face_id for
6006 a static composition.
6007
6008 2011-05-24 Leo Liu <sdl.web@gmail.com>
6009
6010 * deps.mk (fns.o):
6011 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6012
6013 * fns.c (crypto_hash_function, Fsha1): New function.
6014 (Fmd5): Use crypto_hash_function.
6015 (syms_of_fns): Add Ssha1.
6016
6017 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6018
6019 * gnutls.c: Remove unused macros.
6020 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6021 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6022 Remove macros that are defined and never used.
6023 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6024
6025 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6026
6027 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6028 (Fx_get_selection_internal): Minor cleanup.
6029 (Fx_own_selection_internal): Rename arguments for consistency with
6030 select.el.
6031
6032 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6035
6036 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6037
6038 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6039
6040 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6041
6042 * dispnew.c (scrolling_window): Don't exclude the case that the
6043 last enabled row in the desired matrix touches the bottom boundary.
6044
6045 2011-05-21 Glenn Morris <rgm@gnu.org>
6046
6047 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6048 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6049 and add some more files.
6050
6051 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6052
6053 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6054 report_file_error introduced by the change from 2011-05-07.
6055
6056 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6057
6058 * systime.h (Time): Define only if emacs is defined.
6059 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6060 where the include path doesn't have X11/X.h by default. See
6061 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6062
6063 2011-05-20 Kenichi Handa <handa@m17n.org>
6064
6065 * composite.c (find_automatic_composition): Fix previous change.
6066
6067 2011-05-20 Glenn Morris <rgm@gnu.org>
6068
6069 * lisp.mk: New file, split from Makefile.in.
6070 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6071 (shortlisp): Remove.
6072 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6073
6074 2011-05-19 Glenn Morris <rgm@gnu.org>
6075
6076 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6077 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6078 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6079 (lisp): Set the order to that of loadup.el.
6080 (shortlisp): Make it a copy of $lisp.
6081 (SOME_MACHINE_LISP): Remove.
6082 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6083 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6084
6085 2011-05-18 Kenichi Handa <handa@m17n.org>
6086
6087 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6088 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6089 (find_automatic_composition): Mostly rewrite for efficiency.
6090
6091 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6092
6093 * makefile.w32-in: Update dependencies.
6094
6095 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6096
6097 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6098 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6099
6100 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 Fix some integer overflow issues, such as string length overflow.
6103
6104 * insdel.c (count_size_as_multibyte): Check for string overflow.
6105
6106 * character.c (lisp_string_width): Check for string overflow.
6107 Use EMACS_INT, not int, for string indexes and lengths; in
6108 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6109 the resulting string length overflows an EMACS_INT; instead,
6110 report a string overflow if no precision given. When checking for
6111 precision exhaustion, use a check that cannot possibly have
6112 integer overflow. (Bug#8675)
6113 * character.h (lisp_string_width): Adjust to new signature.
6114
6115 * alloc.c (string_overflow): New function.
6116 (Fmake_string): Use it. This doesn't change behavior, but saves
6117 a few bytes and will simplify future changes.
6118 * character.c (string_escape_byte8): Likewise.
6119 * lisp.h (string_overflow): New decl.
6120
6121 Fixups, following up to the user-interface timestamp change.
6122 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6123 for UI timestamps, instead of unsigned long.
6124 * msdos.c (mouse_get_pos): Likewise.
6125 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6126 * w32gui.h (Time): Define by including "systime.h" rather than by
6127 declaring it ourselves. (Bug#8664)
6128
6129 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6130 * image.c (clear_image_cache): Likewise.
6131
6132 * term.c (term_mouse_position): Don't assume time_t wraparound.
6133
6134 Be more systematic about user-interface timestamps.
6135 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6136 and sometimes 'EMACS_UINT', to represent these timestamps.
6137 This change causes it to use 'Time' uniformly, as that's what X uses.
6138 This makes the code easier to follow, and makes it easier to catch
6139 integer overflow bugs such as Bug#8664.
6140 * frame.c (Fmouse_position, Fmouse_pixel_position):
6141 Use Time, not unsigned long, for user-interface timestamps.
6142 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6143 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6144 * keyboard.h (last_event_timestamp): Likewise.
6145 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6146 * menu.h (xmenu_show): Likewise.
6147 * term.c (term_mouse_position): Likewise.
6148 * termhooks.h (struct input_event.timestamp): Likewise.
6149 (struct terminal.mouse_position_hook): Likewise.
6150 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6151 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6152 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6153 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6154 what it was before.
6155 * menu.h, termhooks.h: Include "systime.h", for Time.
6156
6157 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6158 Don't assume that the difference between two unsigned long values
6159 can fit into an integer. At this point, we know button_down_time
6160 <= event->timestamp, so the difference must be nonnegative, so
6161 there's no need to cast the result if double-click-time is
6162 nonnegative, as it should be; check that it's nonnegative, just in
6163 case. This bug is triggered when events are more than 2**31 ms
6164 apart (about 25 days). (Bug#8664)
6165
6166 * xselect.c (last_event_timestamp): Remove duplicate decl.
6167 (x_own_selection): Remove needless cast to unsigned long.
6168
6169 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6170 that always fit in int. Use a sentinel instead of a counter, to
6171 avoid a temp and to allay GCC's concerns about possible int overflow.
6172 * frame.h (struct frame): Use int for menu_bar_items_used
6173 instead of EMACS_INT, since it always fits in int.
6174
6175 * menu.c (grow_menu_items): Check for int overflow.
6176
6177 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6178
6179 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6180 Before, the code was not consistent. These values cannot exceed
6181 2**31 - 1 so there's no need to make them unsigned.
6182 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6183 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6184 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6185 as modifiers.
6186 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6187
6188 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6189 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6190 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6191 presumably because the widths might not match.
6192
6193 * window.c (size_window): Avoid needless test at loop start.
6194
6195 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6196
6197 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6198
6199 2011-05-12 Drew Adams <drew.adams@oracle.com>
6200
6201 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6202
6203 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6204
6205 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6206 `width' to `bar_area_x' and `bar_area_width', respectively.
6207 (x_scroll_run): Take account of fringe background extension.
6208
6209 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6210 Rename local vars `left' and `width' to `bar_area_x' and
6211 `bar_area_width', respectively.
6212 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6213 background extension.
6214
6215 2011-05-10 Jim Meyering <meyering@redhat.com>
6216
6217 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6218
6219 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * image.c (Finit_image_library): Return t for built-in image types,
6222 like pbm and xbm. (Bug#8640)
6223
6224 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6225
6226 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6227
6228 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6229
6230 * w32console.c (Fset_screen_color): Doc fix.
6231 (Fget_screen_color): New function.
6232 (syms_of_ntterm): Defsubr it.
6233
6234 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6235 unlink the temporary file if Fcall_process didn't create it in the
6236 first place.
6237 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6238 child process will be redirected to a file specified with `:file'.
6239 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6240 cue to call_process_cleanup not to close that handle.
6241
6242 2011-05-07 Ben Key <bkey76@gmail.com>
6243
6244 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6245 one of two shell specific rules, either bootstrap-temacs-CMD or
6246 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6247 to the previous implementation of the bootstrap-temacs rule.
6248 The bootstrap-temacs-CMD rule is similar to the previous
6249 implementation of the bootstrap-temacs rule except that it
6250 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6251 variable.
6252
6253 These changes, along with some changes to nt/configure.bat,
6254 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6255 earlier fix to add support for --cflags and --ldflags options
6256 that include quotes so that it works whether make uses cmd or
6257 sh as the shell.
6258
6259 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6260
6261 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6262 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6263 is a constant.
6264 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6265 a string. Handle both cases.
6266 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6267 (Fdbus_register_method): Use Qinvalid_function.
6268
6269 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * makefile.w32-in: Update dependencies.
6272 (LISP_H): Add inttypes.h and stdin.h.
6273 (PROCESS_H): Add unistd.h.
6274
6275 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6276
6277 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6278 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6279
6280 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6281
6282 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6283
6284 * term.c (vfatal): Remove stray call to va_end.
6285 It's not needed and the C Standard doesn't allow it here anyway.
6286
6287 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6288 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6289
6290 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6291 bytes.
6292
6293 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6294
6295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6296
6297 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6298
6299 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6300
6301 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6302
6303 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6304 * charset.c (Fdefine_charset_internal): Don't initialize
6305 charset.code_space[15]. The value was garbage, on hosts with
6306 32-bit int (Bug#8600).
6307
6308 * lread.c (read_integer): Be more consistent with string-to-number.
6309 Use string_to_number to do the actual conversion; this avoids
6310 rounding errors and fixes some other screwups. Without this fix,
6311 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6312 (digit_to_number): Move earlier, for benefit of read_integer.
6313 Return -1 if the digit is out of range for the base, -2 if it is
6314 not a digit in any supported base. (Bug#8602)
6315
6316 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6317
6318 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6319 to match comment at start of function. This also removes a
6320 GCC warning about overflow in a 32+64-bit port.
6321
6322 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6323
6324 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6325 Reported by Stefan Monnier in
6326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6327 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6328 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6329
6330 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6331 (EMACS_UINTPTR): Likewise, with uintptr_t.
6332
6333 * lisp.h: Prefer 64-bit EMACS_INT if available.
6334 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6335 on 32-bit hosts that have 64-bit int, so that they can access
6336 large files.
6337 However, temporarily disable this change unless the temporary
6338 symbol WIDE_EMACS_INT is defined.
6339
6340 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6341
6342 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6343 This removes an assumption that EMACS_INT and long are the same
6344 width as pointers. The assumption is true for Emacs porting targets
6345 now, but we want to make other targets possible.
6346 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6347 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6348 In the rest of the code, change types of integers that hold casted
6349 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6350 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6351 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6352 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6353 No need to cast type when ORing.
6354 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6355 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6356 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6357 assume EMACS_INT is the same width as char *.
6358 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6359 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6360 Remove no-longer-needed casts.
6361 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6362 (xg_tool_bar_help_callback, xg_make_tool_item):
6363 Use EMACS_INTPTR to hold an integer
6364 that will be cast to void *; this can avoid a GCC warning
6365 if EMACS_INT is not the same width as void *.
6366 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6367 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6368 (current_message_1, set_message_1):
6369 Use a local to convert to proper width without a cast.
6370 * xmenu.c (dialog_selection_callback): Likewise.
6371
6372 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6373 Also, don't assume VALBITS / RAND_BITS is less than 5,
6374 and don't rely on undefined behavior when shifting a 1 left into
6375 the sign bit.
6376 * lisp.h (get_random): Change signature to match.
6377
6378 * lread.c (hash_string): Use size_t, not int, for hash computation.
6379 Normally we prefer signed values; but hashing is special, because
6380 it's better to use unsigned division on hash table sizes so that
6381 the remainder is nonnegative. Also, size_t is the natural width
6382 for hashing into memory. The previous code used 'int', which doesn't
6383 retain enough info to hash well into very large tables.
6384 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6385
6386 * dbusbind.c: Don't possibly lose pointer info when converting.
6387 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6388 Use XPNTR rather than XHASH, so that the high-order bits of
6389 the pointer aren't lost when converting through void *.
6390
6391 * eval.c (Fautoload): Don't double-shift a pointer.
6392
6393 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6394
6395 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6396
6397 * gnutls.c (DEF_GNUTLS_FN):
6398 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6399
6400 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6401
6402 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6403 marker. (Bug#8610)
6404
6405 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6406
6407 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6408 New version that can reserve upto 2GB of heap space.
6409
6410 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6411
6412 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6413
6414 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6415
6416 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6417 `gnutls_certificate_set_x509_key_file'.
6418
6419 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6422 Update dependencies.
6423
6424 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6425
6426 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6427 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6428 Remove unused parameter `fildes'.
6429 * process.c (read_process_output, send_process): Don't pass it.
6430
6431 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6432
6433 Fix previous change: the library cache is defined in w32.c.
6434 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6435 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6436
6437 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6438
6439 Implement dynamic loading of GnuTLS on Windows.
6440
6441 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6442 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6443 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6444 Declare.
6445
6446 * gnutls.c (Qgnutls_dll): Define.
6447 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6448 (gnutls_*): Declare function pointers.
6449 (init_gnutls_functions): New function to initialize function pointers.
6450 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6451 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6452 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6453 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6454 (emacs_gnutls_write, emacs_gnutls_read)
6455 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6456 (Fgnutls_available_p): New function.
6457 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6458 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6459 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6460
6461 * image.c: Include w32.h.
6462 (Vimage_type_cache): Delete.
6463 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6464 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6465 (w32_delayed_load): Move to w32.c.
6466
6467 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6468
6469 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6470 (w32_delayed_load): Move from image.c. When loading a library, record
6471 its filename in the :loaded-from property of the library id.
6472 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6473 Initialize and staticpro them.
6474 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6475
6476 * process.c: Include lisp.h before w32.h, not after.
6477 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6478 instead of gnutls_record_check_pending.
6479
6480 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6481
6482 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6483
6484 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6485 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6486 as passed in.
6487
6488 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6489
6490 * xterm.c (x_set_frame_alpha): Do not set property on anything
6491 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6492
6493 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6496
6497 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6500 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6501 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6502 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6503 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6504 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6505 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6506 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6507 (Qgnutls_bootprop_callbacks_verify): Make static.
6508
6509 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6510
6511 * callproc.c: Indentation fixup.
6512
6513 * sysdep.c (wait_for_termination_1): Make static.
6514 (wait_for_termination, interruptible_wait_for_termination):
6515 Move after wait_for_termination_1.
6516
6517 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6518
6519 * sysdep.c (interruptible_wait_for_termination): New function
6520 which is like wait_for_termination, but allows keyboard
6521 interruptions.
6522
6523 * callproc.c (Fcall_process): Add (:file "file") as an option for
6524 the STDOUT buffer.
6525 (Fcall_process_region): Ditto.
6526
6527 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6528
6529 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6530 rather than `XVECTOR (FOO)->size'.
6531
6532 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6533 inttypes.h, as a gnulib replacement is used if it not available in
6534 system headers.
6535
6536 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6537
6538 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6539 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6540 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6541
6542 * coding.c (coding_alloc_by_realloc): Error out if destination
6543 will grow beyond MOST_POSITIVE_FIXNUM.
6544 (decode_coding_emacs_mule): Abort if there isn't enough place in
6545 charbuf for the composition carryover bytes. Reserve an extra
6546 space for up to 2 characters produced in a loop.
6547 (decode_coding_iso_2022): Abort if there isn't enough place in
6548 charbuf for the composition carryover bytes.
6549
6550 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6551
6552 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6553 aborting when %lld or %lll format is passed.
6554 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6555 %llo or %llx format is passed. (Bug#8545)
6556
6557 * window.c (window_scroll_line_based): Use a marker instead of
6558 simple variables to record original value of point. (Bug#7952)
6559
6560 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6561 produced by %s or %c overflows available buffer space. (Bug#8545)
6562
6563 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6566 (SIZE_MAX): Move defn after all includes, as they might #define it.
6567
6568 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6571
6572 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * keyboard.c (Qdelayed_warnings_hook): Define.
6575 (command_loop_1): Run `delayed-warnings-hook'
6576 if Vdelayed_warnings_list is non-nil.
6577 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6578 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6579
6580 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6581
6582 * doprnt.c (doprnt): Don't return value smaller than the buffer
6583 size if the message was truncated. (Bug#8545).
6584
6585 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6586
6587 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6588 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6589
6590 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6593
6594 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * makefile.w32-in: Update dependencies.
6597
6598 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6599
6600 Improve `doprnt' and its usage. (Bug#8545)
6601 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6602 `format_end'. Remove support for %l as a conversion specifier.
6603 Don't use xrealloc. Improve diagnostics when the %l size modifier
6604 is used. Update the commentary.
6605
6606 * eval.c (verror): Simplify calculation of size_t.
6607
6608 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6609 messages.
6610
6611 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6612
6613 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6614 change.
6615
6616 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6617
6618 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6619 This makes this file independent of the recent pseudovector change.
6620
6621 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6622
6623 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6624
6625 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6626 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6627 Remove unused local.
6628 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6629
6630 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6631 GCC 4.6.0 optimizes based on type-based alias analysis.
6632 For example, if b is of type struct buffer * and v of type struct
6633 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6634 != &v->size, and therefore "v->size = 1; b->size = 2; return
6635 v->size;" must therefore return 1. This assumption is incorrect
6636 for Emacs, since it type-puns struct Lisp_Vector * with many other
6637 types. To fix this problem, this patch adds a new type struct
6638 vectorlike_header that documents the constraints on layout of vectors
6639 and pseudovectors, and helps optimizing compilers not get fooled
6640 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6641 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6642 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6643 the size member.
6644 (XSETPVECTYPE): Rewrite in terms of new macro.
6645 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6646 This is a bit clearer, and further avoids the possibility of
6647 undesirable aliasing.
6648 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6649 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6650 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6651 since Lisp_Subr is a special case (no "next" field).
6652 (ASIZE): Now uses header.size rather than size.
6653 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6654 to avoid the hassle of writing XVECTOR (foo)->header.size.
6655 (struct vectorlike_header): New type.
6656 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6657 object, to help avoid aliasing.
6658 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6659 (SUBRP): Likewise, since Lisp_Subr is a special case.
6660 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6661 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6662 (struct Lisp_Hash_Table): Combine first two members into a single
6663 struct vectorlike_header member. All uses of "size" and "next" members
6664 changed to be "header.size" and "header.next".
6665 * buffer.h (struct buffer): Likewise.
6666 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6667 * frame.h (struct frame): Likewise.
6668 * process.h (struct Lisp_Process): Likewise.
6669 * termhooks.h (struct terminal): Likewise.
6670 * window.c (struct save_window_data, struct saved_window): Likewise.
6671 * window.h (struct window): Likewise.
6672 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6673 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6674 * buffer.c (init_buffer_once): Likewise.
6675 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6676 special case.
6677 * process.c (Fformat_network_address): Use local var for size,
6678 for brevity.
6679
6680 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6681
6682 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6683 * data.c (atof): Remove decl; no longer used or needed.
6684 (digit_to_number): Move to lread.c.
6685 (Fstring_to_number): Use new string_to_number function, to be
6686 consistent with how the Lisp reader treats infinities and NaNs.
6687 Do not assume that floating-point numbers represent EMACS_INT
6688 without losing information; this is not true on most 64-bit hosts.
6689 Avoid double-rounding errors, by insisting on integers when
6690 parsing non-base-10 numbers, as the documentation specifies.
6691 * lisp.h (string_to_number): New decl, replacing ...
6692 (isfloat_string): Remove.
6693 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6694 (read1): Do not accept +. and -. as integers; this
6695 appears to have been a coding error. Similarly, do not accept
6696 strings like +-1e0 as floating point numbers. Do not report
6697 overflow for integer overflows unless the base is not 10 which
6698 means we have no simple and reliable way to continue.
6699 Break out the floating-point parsing into a new
6700 function string_to_number, so that Fstring_to_number parses
6701 floating point numbers consistently with the Lisp reader.
6702 (digit_to_number): Move here from data.c. Make it static inline.
6703 (E_CHAR, EXP_INT): Remove, replacing with ...
6704 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6705 (string_to_number): New function, replacing isfloat_string.
6706 This function checks for valid syntax and produces the resulting
6707 Lisp float number too. Rework it so that string-to-number
6708 no longer mishandles examples like "1.0e+". Use strtoumax,
6709 so that overflow for non-base-10 numbers is reported only when
6710 there's no portable and simple way to convert to floating point.
6711
6712 * textprop.c (set_text_properties_1): Rewrite for clarity,
6713 and to avoid GCC warning about integer overflow.
6714
6715 * intervals.h (struct interval): Use EMACS_INT for members
6716 where EMACS_UINT might cause problems. See
6717 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6718 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6719 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6720 All uses changed.
6721 (offset_intervals): Tell GCC not to worry about length overflow
6722 when negating a negative length.
6723
6724 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6725 (overrun_check_free): Likewise.
6726
6727 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6728 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6729 word size.
6730
6731 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6732 (gnutls_make_error): Rename local to avoid shadowing.
6733 (gnutls_emacs_global_deinit): ifdef out; not used.
6734 (Fgnutls_boot): Use const for pointer to readonly storage.
6735 Comment out unused local. Fix pointer signedness problems.
6736
6737 * lread.c (openp): Don't stuff size_t into an 'int'.
6738 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6739 about possible signed overflow.
6740
6741 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6742 (GDK_KEY_g): Don't define if already defined.
6743 (xg_prepare_tooltip): Avoid pointer signedness problem.
6744 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6745
6746 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6747 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6748
6749 * xfns.c (Fx_window_property): Simplify a bit,
6750 to make a bit faster and to avoid GCC 4.6.0 warning.
6751 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6752
6753 * fns.c (internal_equal): Don't assume size_t fits in int.
6754
6755 * alloc.c (compact_small_strings): Tighten assertion a little.
6756
6757 Replace pEd with more-general pI, and fix some printf arg casts.
6758 * lisp.h (pI): New macro, generalizing old pEd macro to other
6759 conversion specifiers. For example, use "...%"pI"d..." rather
6760 than "...%"pEd"...".
6761 (pEd): Remove. All uses replaced with similar uses of pI.
6762 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6763 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6764 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6765 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6766 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6767 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6768 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6769 64-bit hosts.
6770 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6771 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6772 * print.c (safe_debug_print, print_object): Likewise.
6773 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6774 to int.
6775 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6776 avoiding the 0 flag, which is not portable.
6777 * process.c (Fmake_network_process): Use pI to avoid cast.
6778 * region-cache.c (pp_cache): Likewise.
6779 * xdisp.c (decode_mode_spec): Likewise.
6780 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6781 behavior on 64-bit hosts with printf arg.
6782 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6783 (x_stop_queuing_selection_requests): Likewise.
6784 (x_get_window_property): Don't truncate byte count to an 'int'
6785 when tracing.
6786
6787 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6788 here, since it parses constructs like leading '-' and spaces,
6789 which are not wanted; and it overflows with large numbers.
6790 Instead, simply match F[0-9]+, which is what is wanted anyway.
6791
6792 * alloc.c: Remove unportable assumptions about struct layout.
6793 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6794 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6795 (allocate_vectorlike, make_pure_vector): Use the new macros,
6796 plus offsetof, to remove unportable assumptions about struct layout.
6797 These assumptions hold on all porting targets that I know of, but
6798 they are not guaranteed, they're easy to remove, and removing them
6799 makes further changes easier.
6800
6801 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6802 This doesn't fix a bug but makes the code clearer.
6803 (string_overrun_cookie): Now const. Use initializers that
6804 don't formally overflow signed char, to avoid warnings.
6805 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6806 can cause Emacs to crash when string overrun checking is enabled.
6807 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6808 multiple of sizeof (EMACS_INT); it need not be, if
6809 alignof(EMACS_INT) < sizeof (EMACS_INT).
6810 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6811
6812 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6813
6814 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6815
6816 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6817
6818 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6819 supposed to be handshaking. (Bug#8556)
6820 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6821
6822 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6823
6824 * lisp.h (Qdebug): List symbol.
6825 * eval.c (Qdebug): Restore global linkage.
6826 * keyboard.c (debug-on-event): New variable.
6827 (handle_user_signal): Break into debugger when debug-on-event
6828 matches the current signal symbol.
6829
6830 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6831
6832 * alloc.c (check_sblock, check_string_bytes)
6833 (check_string_free_list): Convert to standard C.
6834
6835 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6836
6837 * w32.c (emacs_gnutls_push): Fix typo.
6838
6839 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6840
6841 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6842 "cast to pointer from integer of different size".
6843
6844 Improve doprnt and its use in verror. (Bug#8545)
6845 * doprnt.c (doprnt): Document the set of format control sequences
6846 supported by the function. Use SAFE_ALLOCA instead of always
6847 using `alloca'.
6848
6849 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6850 is one byte too soon. Don't use xrealloc; instead xfree and
6851 xmalloc anew.
6852
6853 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6854
6855 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6856 callbacks stage.
6857
6858 * gnutls.c: Renamed global_initialized to
6859 gnutls_global_initialized. Added internals for the
6860 :verify-hostname-error, :verify-error, and :verify-flags
6861 parameters of `gnutls-boot' and documented those parameters in the
6862 docstring. Start callback support.
6863 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6864 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6865 on error. Return error code.
6866 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6867 (emacs_gnutls_read): Likewise.
6868 (Fgnutls_boot): Return handshake error code.
6869 (emacs_gnutls_handle_error): New function.
6870 (wsaerror_to_errno): Likewise.
6871
6872 * w32.h (emacs_gnutls_pull): Add prototype.
6873 (emacs_gnutls_push): Likewise.
6874
6875 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6876 (emacs_gnutls_push): Likewise.
6877
6878 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6879
6880 * process.c (wait_reading_process_output): Check if GnuTLS
6881 buffered some data internally if no FDs are set for TLS
6882 connections.
6883
6884 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6885 (LIBS): Link to USER_LIBS.
6886 ($(BLD)/gnutls.$(0)): New target.
6887
6888 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6889
6890 * xdisp.c (handle_single_display_spec): Rename the
6891 display_replaced_before_p argument into display_replaced_p, to
6892 make it consistent with the commentary. Fix typos in the
6893 commentary.
6894
6895 * textprop.c (syms_of_textprop): Remove dead code.
6896 (copy_text_properties): Delete obsolete commentary about an
6897 interface that was deleted long ago. Fix typos in the description
6898 of arguments.
6899
6900 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6901 to changes in oldXMenu/XMenu.h from 2011-04-16.
6902 <menu_help_message, prev_menu_help_message>: Constify.
6903 (IT_menu_make_room): menu->help_text is now `const char **';
6904 adjust.
6905
6906 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6907 to changes in oldXMenu/XMenu.h from 2011-04-16.
6908 (struct XMenu): Declare `help_text' `const char **'.
6909
6910 * xfaces.c <Qunspecified>: Make extern again.
6911
6912 * syntax.c: Include sys/types.h before including regex.h, as
6913 required by Posix.
6914
6915 * doc.c (get_doc_string): Improve the format passed to `error'.
6916
6917 * doprnt.c (doprnt): Improve commentary.
6918
6919 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6920
6921 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6922 them with etags.
6923
6924 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6925 changes in globals.h immediately force recompilation.
6926 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6927 $(CURDIR)/s/ms-w32.h.
6928 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6929
6930 * character.c (Fchar_direction): Function deleted.
6931 (syms_of_character): Don't defsubr it.
6932 <char-direction-table>: Deleted.
6933
6934 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6935
6936 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6937 * doprnt.c: Include limits.h.
6938 (SIZE_MAX): New macro.
6939 (doprnt): Return a size_t value. 2nd arg is now size_t.
6940 Many local variables are now size_t instead of int or unsigned.
6941 Improve overflow protection. Support `l' modifier for integer
6942 conversions. Support %l conversion. Don't assume an EMACS_INT
6943 argument for integer conversions and for %c.
6944
6945 * lisp.h (doprnt): Restore prototype.
6946
6947 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6948 $(SRC)/character.h.
6949
6950 * Makefile.in (base_obj): Add back doprnt.o.
6951
6952 * deps.mk (doprnt.o): Add back prerequisites.
6953 (callint.o): Depend on character.h.
6954
6955 * eval.c (internal_lisp_condition_case): Include the handler
6956 representation in the error message.
6957 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6958 when breaking from the loop.
6959
6960 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6961
6962 * callint.c (Fcall_interactively): When displaying error message
6963 about invalid control letter, pass the character's codepoint, not
6964 a pointer to its multibyte form. Improve display of the character
6965 in octal and display also its hex code.
6966
6967 * character.c (char_string): Use %x to display the (unsigned)
6968 codepoint of an invalid character, to avoid displaying a bogus
6969 negative value.
6970
6971 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6972 `error', not SYMBOL_NAME itself.
6973
6974 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6975 character arguments to `error'.
6976
6977 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6978 to `error' in error message about FINAL_CHAR argument. Make sure
6979 FINAL_CHAR is a character, and use %c when it is passed as
6980 argument to `error'.
6981
6982 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6983
6984 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6985
6986 * w32.c: Include <time.h>.
6987 (sys_localtime): New function.
6988
6989 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6990
6991 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6992
6993 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6994
6995 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6996
6997 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6998 zombies (Bug#8467).
6999
7000 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7001
7002 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7003 gl_state.e_property when gl_state.object is Qt.
7004
7005 * insdel.c (make_gap_larger): Remove limitation of buffer size
7006 to <= INT_MAX.
7007
7008 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7009
7010 * xdisp.c (lookup_glyphless_char_display)
7011 (produce_glyphless_glyph): Handle cons cell entry in
7012 glyphless-char-display.
7013 (Vglyphless_char_display): Document it.
7014
7015 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7016 glyphless-char-display.
7017
7018 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7019
7020 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7021
7022 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7023
7024 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7025 definition for no-X builds.
7026
7027 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7028
7029 Static checks with GCC 4.6.0 and non-default toolkits.
7030
7031 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7032
7033 * process.c (keyboard_bit_set): Define only if SIGIO.
7034 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7035 (send_process): Repair possible setjmp clobbering.
7036
7037 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7038
7039 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7040
7041 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7042
7043 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7044 Define only if needed.
7045
7046 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7047 by pacifying GCC about it. Maybe it's time to retire it?
7048 * xfaces.c (USG, __TIMEVAL__): Likewise.
7049
7050 * dispextern.h (struct redisplay_interface): Rename param
7051 to avoid shadowing.
7052 * termhooks.h (struct terminal): Likewise.
7053 * xterm.c (xembed_send_message): Likewise.
7054
7055 * insdel.c (make_gap_smaller): Define only if
7056 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7057
7058 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7059 it.
7060
7061 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7062 so that we aren't warned about unused symbols.
7063
7064 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7065
7066 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7067
7068 * xfns.c (x_real_positions): Mark locals as initialized.
7069
7070 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7071
7072 * xterm.c: Fix problems found by static analysis with other toolkits.
7073 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7074 (x_dispatch_event): Declare static if USE_GTK, and
7075 define if USE_GTK || USE_X_TOOLKIT.
7076 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7077 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7078 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7079 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7080
7081 * xmenu.c (menu_help_callback): Pointer type fixes.
7082 Use const pointers when pointing at readonly data. Avoid pointer
7083 signedness clashes.
7084 (FALSE): Remove unused macro.
7085 (update_frame_menubar): Remove unused decl.
7086
7087 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7088
7089 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7090 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7091 (single_menu_item): Rename local to avoid shadowing.
7092
7093 * keyboard.c (make_lispy_event): Remove unused local var.
7094
7095 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7096 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7097
7098 * bitmaps: Change bitmaps from unsigned char back to the X11
7099 compatible char. Avoid the old compiler warnings about
7100 out-of-range initializers by using, for example, '\xab' rather
7101 than 0xab.
7102
7103 * xgselect.c (xgselect_initialize): Check vs interface
7104 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7105
7106 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7107
7108 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7109 to read-only memory.
7110
7111 * fns.c (vector): Remove; this old hack is no longer needed.
7112
7113 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7114 Remove unused var.
7115 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7116
7117 * xrdb.c (x_load_resources): Omit unused local.
7118
7119 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7120 (x_window): Rename locals to avoid shadowing.
7121 (USG): Use the kludged USG macro, to pacify gcc.
7122
7123 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7124 (x_term_init): Remove local to avoid shadowing.
7125
7126 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7127
7128 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7129 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7130
7131 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7132
7133 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7134
7135 Fix regex.c, syntax.c and friends for buffers > 2GB.
7136 * syntax.h (struct gl_state_s): Declare character position members
7137 EMACS_INT.
7138
7139 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7140
7141 * textprop.c (verify_interval_modification, interval_of):
7142 Declare arguments EMACS_INT.
7143
7144 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7145 EMACS_INT.
7146
7147 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7148
7149 * indent.c (Fvertical_motion): Local variable it_start is now
7150 EMACS_INT.
7151
7152 * regex.c (re_match, re_match_2, re_match_2_internal)
7153 (bcmp_translate, regcomp, regexec, print_double_string)
7154 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7155 (re_compile_pattern, re_exec): Declare arguments and local
7156 variables `size_t' and `ssize_t' and return values `regoff_t', as
7157 appropriate.
7158 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7159 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7160 <compile_stack_type>: `size' and `avail' are now `size_t'.
7161
7162 * regex.h <regoff_t>: Use ssize_t, not int.
7163 (re_search, re_search_2, re_match, re_match_2): Arguments that
7164 specify buffer/string position and length are now ssize_t and
7165 size_t. Return type is regoff_t.
7166
7167 2011-04-16 Ben Key <bkey76@gmail.com>
7168
7169 * nsfont.m: Fixed bugs in ns_get_family and
7170 ns_descriptor_to_entity that were caused by using free to
7171 deallocate memory blocks that were allocated by xmalloc (via
7172 xstrdup). This caused Emacs to crash when compiled with
7173 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7174 --enable-checking=xmallocoverrun). xfree is now used to
7175 deallocate these memory blocks.
7176
7177 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7178
7179 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7180
7181 emacs_write: Accept and return EMACS_INT for sizes.
7182 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7183 et seq.
7184 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7185 Accept and return EMACS_INT.
7186 (emacs_gnutls_write): Return the number of bytes written on
7187 partial writes.
7188 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7189 (emacs_read, emacs_write): Remove check for negative size, as the
7190 Emacs source code has been audited now.
7191 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7192 (emacs_read, emacs_write): Use it.
7193 * process.c (send_process): Adjust to the new signatures of
7194 emacs_write and emacs_gnutls_write. Do not attempt to store
7195 a byte offset into an 'int'; it might overflow.
7196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7197
7198 * sound.c: Don't assume sizes fit in 'int'.
7199 (struct sound_device.period_size, alsa_period_size):
7200 Return EMACS_INT, not int.
7201 (struct sound_device.write, vox_write, alsa_write):
7202 Accept EMACS_INT, not int.
7203 (wav_play, au_play): Use EMACS_INT to store sizes and to
7204 record read return values.
7205
7206 2011-04-15 Ben Key <bkey76@gmail.com>
7207
7208 * keyboard.c (Qundefined): Don't declare static since it is used
7209 in nsfns.m.
7210 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7211 static since they are used in nsfont.m.
7212
7213 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7214
7215 * process.c (Qprocessp): Don't declare static.
7216 * lisp.h (Qprocessp): Declare again.
7217
7218 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7219
7220 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7221
7222 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7223
7224 Improve C-level modularity by making more things 'static'.
7225
7226 Don't publish debugger-only interfaces to other modules.
7227 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7228 (verify_bytepos, count_markers): Move decls to the only modules
7229 that need them.
7230 * region-cache.h (pp_cache): Likewise.
7231 * window.h (check_all_windows): Likewise.
7232 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7233
7234 * sysdep.c (croak): Now static, if
7235 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7236 * syssignal.h (croak): Declare only if not static.
7237
7238 * alloc.c (refill_memory_reserve): Now static if
7239 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7240 * lisp.h (refill_memory_reserve): Declare only if not static.
7241
7242 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7243 Define only if USE_LUCID.
7244
7245 * xrdb.c (x_customization_string, x_rm_string): Now static.
7246
7247 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7248 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7249
7250 * xdisp.c (draw_row_with_mouse_face): Now static.
7251 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7252
7253 * window.h (check_all_windows): Mark externally visible.
7254
7255 * window.c (window_deletion_count): Now static.
7256
7257 * undo.c: Make symbols static if they're not exported.
7258 (last_undo_buffer, last_boundary_position, pending_boundary):
7259 Now static.
7260
7261 * textprop.c (interval_insert_behind_hooks): Now static.
7262 (interval_insert_in_front_hooks): Likewise.
7263
7264 * term.c: Make symbols static if they're not exported.
7265 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7266 (max_frame_lines, tty_set_terminal_modes):
7267 (tty_reset_terminal_modes, tty_turn_off_highlight):
7268 (get_tty_terminal): Now static.
7269 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7270 * termhooks.h (term_mouse_moveto): Do not declare if
7271 HAVE_WINDOW_SYSTEM.
7272 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7273 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7274
7275 * sysdep.c: Make symbols static if they're not exported.
7276 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7277 Now static.
7278 (sigprocmask_set, full_mask): Remove; unused.
7279 (wait_debugging): Mark as visible.
7280 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7281 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7282
7283 * syntax.c (syntax_temp): Define only if !__GNUC__.
7284
7285 * sound.c (current_sound_device, current_sound): Now static.
7286
7287 * search.c (searchbufs, searchbuf_head): Now static.
7288
7289 * scroll.c (scroll_cost): Remove; unused.
7290 * dispextern.h (scroll_cost): Remove decl.
7291
7292 * region-cache.h (pp_cache): Mark as externally visible.
7293
7294 * process.c: Make symbols static if they're not exported.
7295 (process_tick, update_tick, create_process, chan_process):
7296 (Vprocess_alist, proc_buffered_char, datagram_access):
7297 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7298 (deactivate_process): Mark defn as static, as well as decl.
7299 * lisp.h (create_process): Remove decl.
7300 * process.h (chan_process, Vprocess_alist): Remove decls.
7301
7302 * print.c: Make symbols static if they're not exported.
7303 (print_depth, new_backquote_output, being_printed, print_buffer):
7304 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7305 (print_interval, print_number_index, initial_stderr_stream):
7306 Now static.
7307 * lisp.h (Fprinc): Remove decl.
7308 (debug_output_compilation_hack): Mark as externally visible.
7309
7310 * sysdep.c (croak): Move decl from here to syssignal.h.
7311 * syssignal.h (croak): Put it here, so the API can be checked when
7312 'croak' is called from dissociate_if_controlling_tty.
7313
7314 * minibuf.c: Make symbols static if they're not exported.
7315 (minibuf_save_list, choose_minibuf_frame): Now static.
7316 * lisp.h (choose_minibuf_frame): Remove decl.
7317
7318 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7319
7320 * lread.c: Make symbols static if they're not exported.
7321 (read_objects, initial_obarray, oblookup_last_bucket_number):
7322 Now static.
7323 (make_symbol): Remove; unused.
7324 * lisp.h (initial_obarray, make_symbol): Remove decls.
7325
7326 * keyboard.c: Make symbols static if they're not exported.
7327 (single_kboard, recent_keys_index, total_keys, recent_keys):
7328 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7329 (this_single_command_key_start, echoing, last_auto_save):
7330 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7331 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7332 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7333 (Vlispy_mouse_stem, double_click_count):
7334 Now static.
7335 (force_auto_save_soon): Define only if SIGDANGER.
7336 (ignore_mouse_drag_p): Now static if
7337 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7338 (print_help): Remove; unused.
7339 (stop_character, last_timer_event): Mark as externally visible.
7340 * keyboard.h (ignore_mouse_drag_p): Declare only if
7341 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7342 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7343 * lisp.h (echoing): Remove decl.
7344 (force_auto_save_soon): Declare only if SIGDANGER.
7345 * xdisp.c (redisplay_window): Simplify code, to make it more
7346 obvious that ignore_mouse_drag_p is not accessed if !defined
7347 USE_GTK && !defined HAVE_NS.
7348
7349 * intervals.c: Make symbols static if they're not exported.
7350 (merge_properties_sticky, merge_interval_right, delete_interval):
7351 Now static.
7352 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7353
7354 * insdel.c: Make symbols static if they're not exported.
7355 However, leave prepare_to_modify_buffer alone. It's never
7356 called from outside this function, but that appears to be a bug.
7357 (combine_after_change_list, combine_after_change_buffer):
7358 (adjust_after_replace, signal_before_change): Now static.
7359 (adjust_after_replace_noundo): Remove; unused.
7360 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7361 (signal_before_change): Remove decls.
7362
7363 * indent.c (val_compute_motion, val_vmotion): Now static.
7364
7365 * image.c: Make symbols static if they're not exported.
7366 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7367 if USE_GTK.
7368 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7369 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7370
7371 * fringe.c (standard_bitmaps): Now static.
7372 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7373
7374 * frame.c: Make symbols static if they're not exported.
7375 (x_report_frame_params, make_terminal_frame): Now static.
7376 (get_frame_param): Now static, unless HAVE_NS.
7377 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7378 (x_get_resource_string): Remove; not used.
7379 * frame.h (make_terminal_frame, x_report_frame_params):
7380 (x_get_resource_string); Remove decls.
7381 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7382 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7383
7384 * font.c, fontset.c: Make symbols static if they're not exported.
7385 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7386 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7387 * font.c (font_close_object): Now static.
7388 * font.h (font_close_object): Remove.
7389 * fontset.c (FONTSET_OBJLIST): Remove.
7390 (free_realized_fontset) #if-0 the body, which does nothing.
7391 (face_suitable_for_char_p): #if-0, as it's never called.
7392 * fontset.h (face_suitable_for_char_p): Remove decl.
7393 * xfaces.c (face_at_string_position):
7394 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7395 since 0 is always ASCII.
7396
7397 * fns.c (weak_hash_tables): Now static.
7398
7399 * fileio.c: Make symbols static if they're not exported.
7400 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7401 (Vwrite_region_annotation_buffers): Now static.
7402
7403 * eval.c: Make symbols static if they're not exported.
7404 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7405 * lisp.h (backtrace_list): Remove decl.
7406
7407 * emacs.c: Make symbols static if they're not exported.
7408 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7409 (fatal_error_code, fatal_error_signal_hook, standard_args):
7410 Now static.
7411 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7412 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7413 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7414 * lisp.h (fatal_error_signal_hook): Remove decl.
7415 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7416
7417 * editfns.c: Move a (normally-unused) function to its only use.
7418 * editfns.c, lisp.h (get_operating_system_release): Remove.
7419 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7420 worth the hassle of breaking this out.
7421
7422 * xterm.c: Make symbols static if they're not exported.
7423 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7424 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7425 (x_destroy_window, x_delete_display):
7426 Now static.
7427 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7428 (x_mouse_leave): Remove; unused.
7429 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7430 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7431 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7432 Remove decls.
7433 (x_mouse_leave): Declare only if WINDOWSNT.
7434 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7435 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7436 USE_X_TOOLKIT.
7437
7438 * ftxfont.c: Make symbols static if they're not exported.
7439 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7440 HAVE_FREETYPE.
7441 * font.h (ftxfont_driver): Likewise.
7442
7443 * xfns.c: Make symbols static if they're not exported.
7444 (x_last_font_name, x_display_info_for_name):
7445 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7446 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7447 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7448 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7449 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7450 (last_show_tip_args): Now static.
7451 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7452 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7453 (x_screen_planes): Remove; unused.
7454 * dispextern.h (x_screen_planes): Remove decl.
7455
7456 * dispnew.c: Make symbols static if they're not exported.
7457 * dispextern.h (redraw_garbaged_frames, scrolling):
7458 (increment_row_positions): Remove.
7459 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7460 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7461 Now static.
7462 (redraw_garbaged_frames): Remove; unused.
7463
7464 * xfaces.c: Make symbols static if they're not exported.
7465 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7466 Remove decls.
7467 * xterm.h (defined_color): Remove decls.
7468 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7469 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7470 (menu_face_changed_default, defined_color, free_realized_face):
7471 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7472 (ascii_face_of_lisp_face): Remove; unused.
7473
7474 * xdisp.c: Make symbols static if they're not exported.
7475 * dispextern.h (scratch_glyph_row, window_box_edges):
7476 (glyph_to_pixel_coords, set_cursor_from_row):
7477 (get_next_display_element, set_iterator_to_next):
7478 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7479 (show_mouse_face): Remove decls
7480 * frame.h (message_buf_print): Likewise.
7481 * lisp.h (pop_message, set_message, check_point_in_composition):
7482 Likewise.
7483 * xterm.h (set_vertical_scroll_bar): Likewise.
7484 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7485 (message_buf_print, scratch_glyph_row, displayed_buffer):
7486 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7487 (get_next_display_element, show_mouse_face, window_box_edges):
7488 (frame_to_window_pixel_xy, check_point_in_composition):
7489 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7490 (glyph_to_pixel_coords): Remove; unused.
7491
7492 * dired.c (file_name_completion): Now static.
7493
7494 * dbusbind.c (xd_in_read_queued_messages): Now static.
7495
7496 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7497 * data.c (circular_list_error): Remove.
7498
7499 * commands.h (last_point_position, last_point_position_buffer):
7500 (last_point_position_window): Remove decls.
7501 * keyboard.c: Make these variables static.
7502
7503 * coding.h (coding, code_convert_region, encode_coding_gap):
7504 Remove decls.
7505 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7506 (iso_code_class, detect_coding, code_convert_region): Now static.
7507 (encode_coding_gap): Remove; unused.
7508
7509 * chartab.c (chartab_chars, chartab_bits): Now static.
7510
7511 * charset.h (charset_iso_8859_1): Remove decl.
7512 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7513 Now static.
7514
7515 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7516 * ccl.c (Vccl_program_table): Now static.
7517 (check_ccl_update): Remove; unused.
7518
7519 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7520 * category.h: ... from here.
7521 * category.c (check_category_table, set_category_set): Now static.
7522
7523 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7524 * lisp.h: Remove these decls.
7525
7526 * buffer.c (buffer_count): Remove unused var.
7527
7528 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7529 so that it's not optimized away.
7530 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7531 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7532 exported only to the debugger.
7533
7534 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7535 * atimer.h (run_all_atimers): Remove; not exported.
7536
7537 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7538 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7539 was inaccessible from Lisp.
7540 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7541 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7542
7543 alloc.c: Import and export fewer symbols, and remove unused items.
7544 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7545 is defined.
7546 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7547 it's not optimized away by whole-program optimization.
7548 (message_enable_multibyte, free_misc): Remove.
7549 (catchlist, handlerlist, mark_backtrace):
7550 Declare only if BYTE_MARK_STACK.
7551 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7552 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7553 (message_enable_multibyte): Remove decl.
7554 (free_misc, interval_free_list, float_block, float_block_index):
7555 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7556 (cons_free_list, last_marked_index):
7557 Now static.
7558 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7559 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7560 (mark_backtrace): Define only if BYTE_MARK_STACK.
7561 * xdisp.c (message_enable_multibyte): Now static.
7562
7563 Declare Lisp_Object Q* variables to be 'static' if not exported.
7564 This makes it easier for human readers (and static analyzers)
7565 to see whether these variables are used from other modules.
7566 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7567 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7568 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7569 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7570 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7571 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7572 * xmenu.c, xselect.c:
7573 Declare Q* vars static if they are not used in other modules.
7574 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7575 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7576 Remove decls of unexported vars.
7577 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7578
7579 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7580
7581 Make Emacs functions such as Fatom 'static' by default.
7582 This makes it easier for human readers (and static analyzers)
7583 to see whether these functions can be called from other modules.
7584 DEFUN now defines a static function. To make the function external
7585 so that it can be used in other C modules, use the new macro DEFUE.
7586 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7587 (Finit_image_library):
7588 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7589 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7590 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7591 Remove decls, since these functions are now static.
7592 (Funintern, Fget_internal_run_time): New decls, since these functions
7593 were already external.
7594
7595 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7596 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7597 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7598 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7599 * keyboard.c, keymap.c, lread.c:
7600 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7601 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7602 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7603 Mark functions with DEFUE instead of DEFUN,
7604 if they are used in other modules.
7605 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7606 decls for now-static functions.
7607 * buffer.h (Fdelete_overlay): Remove decl.
7608 * callproc.c (Fgetenv_internal): Mark as internal.
7609 * composite.c (Fremove_list_of_text_properties): Remove decl.
7610 (Fcomposition_get_gstring): New forward static decl.
7611 * composite.h (Fcomposite_get_gstring): Remove decl.
7612 * dired.c (Ffile_attributes): New forward static decl.
7613 * doc.c (Fdocumntation_property): New forward static decl.
7614 * eval.c (Ffetch_bytecode): New forward static decl.
7615 (Funintern): Remove extern decl; now in .h file where it belongs.
7616 * fileio.c (Fmake_symbolic_link): New forward static decl.
7617 * image.c (Finit_image_library): New forward static decl.
7618 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7619 * intervals.h (Fprevious_property_change):
7620 (Fremove_list_of_text_properties): Remove decls.
7621 * keyboard.c (Fthis_command_keys): Remove decl.
7622 (Fcommand_execute): New forward static decl.
7623 * keymap.c (Flookup_key): New forward static decl.
7624 (Fcopy_keymap): Now static.
7625 * keymap.h (Flookup_key): Remove decl.
7626 * process.c (Fget_process): New forward static decl.
7627 (Fprocess_datagram_address): Mark as internal.
7628 * syntax.c (Fsyntax_table_p): New forward static decl.
7629 (skip_chars): Remove duplicate decl.
7630 * textprop.c (Fprevious_property_change): New forward static decl.
7631 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7632 Now internal.
7633 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7634 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7635
7636 * editfns.c (Fformat): Remove unreachable code.
7637
7638 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7639
7640 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7641 change. (Bug#8496)
7642
7643 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7644
7645 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7646 when at ZV. (Bug#8487)
7647
7648 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7649
7650 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7651 (Bug#8437)
7652 * keyboard.c (parse_tool_bar_item): Likewise.
7653 * sound.c (sound_cleanup, alsa_close): Likewise.
7654 * termcap.c (tgetent): Likewise.
7655 * xfns.c (x_default_font_parameter): Likewise.
7656 * xsettings.c (read_and_apply_settings): Likewise.
7657
7658 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7659 (overrun_check_free): Protoize.
7660
7661 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7662
7663 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7664 since callers should never pass a negative size.
7665 Change the signature to match that of plain 'read' and 'write'; see
7666 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7667 * lisp.h: Update prototypes of emacs_write and emacs_read.
7668
7669 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7670
7671 * xdisp.c (redisplay_window): Don't try to determine the character
7672 position of the scroll margin if the window start point w->startp
7673 is outside the buffer's accessible region. (Bug#8468)
7674
7675 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7676
7677 Fix write-region and its subroutines for buffers > 2GB.
7678 * fileio.c (a_write, e_write): Modify declaration of arguments and
7679 local variables to support buffers larger than 2GB.
7680 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7681
7682 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7683 argument, local variables, and return value.
7684
7685 * lisp.h: Update prototypes of emacs_write and emacs_read.
7686
7687 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7688
7689 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7692
7693 Fix more problems found by GCC 4.6.0's static checks.
7694
7695 * xdisp.c (vmessage): Use a better test for character truncation.
7696
7697 * charset.c (load_charset_map): <, not <=, for optimization,
7698 and to avoid potential problems with integer overflow.
7699 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7700 * casetab.c (set_identity, shuffle): Likewise.
7701 * editfns.c (Fformat): Likewise.
7702 * syntax.c (skip_chars): Likewise.
7703
7704 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7705 This also lets GCC 4.6.0 generate slightly better loop code.
7706
7707 * callint.c (Fcall_interactively): <, not <=, for optimization.
7708 (Fcall_interactively): Count the number of arguments produced,
7709 not the number of arguments given. This is simpler and lets GCC
7710 4.6.0 generate slightly better code.
7711
7712 * ftfont.c: Distingish more carefully between FcChar8 and char.
7713 The previous code passed unsigned char * to a functions like
7714 strlen and xstrcasecmp that expect char *, which does not
7715 conform to the C standard.
7716 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7717 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7718 char * when the C standard requires it.
7719
7720 * keyboard.c (read_char): Remove unused var.
7721
7722 * eval.c: Port to Windows vsnprintf (Bug#8435).
7723 Include <limits.h>.
7724 (SIZE_MAX): Define if the headers do not.
7725 (verror): Do not give up if vsnprintf returns a negative count.
7726 Instead, grow the buffer. This ports to Windows vsnprintf, which
7727 does not conform to C99. Problem reported by Eli Zaretskii.
7728 Also, simplify the allocation scheme, by avoiding the need for
7729 calling realloc, and removing the ALLOCATED variable.
7730
7731 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7732
7733 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7734 But keep the doprint source code for now, as we might revamp it
7735 and use it again (Bug#8435).
7736 * lisp.h (doprnt): Remove.
7737 * Makefile.in (base_obj): Remove doprnt.o.
7738 * deps.mk (doprnt.o): Remove.
7739
7740 error: Print 32- and 64-bit integers portably (Bug#8435).
7741 Without this change, on typical 64-bit hosts error ("...%d...", N)
7742 was used to print both 32- and 64-bit integers N, which relied on
7743 undefined behavior.
7744 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7745 New macro.
7746 * lisp.h (error, verror): Mark as printf-like functions.
7747 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7748 Report overflow in size calculations when allocating printf buffer.
7749 Do not truncate output string at its first null byte.
7750 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7751 Truncate the output at a character boundary, since vsnprintf does not
7752 do that.
7753 * charset.c (check_iso_charset_parameter): Convert internal
7754 character to string before calling 'error', since %c now has the
7755 printf meaning.
7756 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7757 overflow when computing char to be passed to 'error'. Do not
7758 pass Lisp_Object to 'error'; pass the integer instead.
7759 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7760 formatted with plain %d.
7761
7762 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7763
7764 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7765
7766 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7767
7768 * xterm.c (x_catch_errors): Remove duplicate declaration.
7769
7770 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7771
7772 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7773
7774 2011-04-10 Jim Meyering <meyering@redhat.com>
7775
7776 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7777 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7778 return ssize_t not "int", and use size_t as the buffer length.
7779 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7780 * gnutls.h: Update declarations.
7781 * process.c (read_process_output): Use ssize_t, to match.
7782 (send_process): Likewise.
7783
7784 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7785
7786 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7787
7788 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7789
7790 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7791 Use unsigned char, to match FcChar8 type definition.
7792
7793 * xterm.c (handle_one_xevent):
7794 * xmenu.c (create_and_show_popup_menu):
7795 * xselect.c (x_decline_selection_request)
7796 (x_reply_selection_request): Avoid type-punned deref of X events.
7797
7798 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7799
7800 Fix some uses of `int' instead of EMACS_INT.
7801 * search.c (string_match_1, fast_string_match)
7802 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7803 (scan_buffer, find_next_newline_no_quit)
7804 (find_before_next_newline, search_command, Freplace_match)
7805 (Fmatch_data): Make some `int' variables be EMACS_INT.
7806
7807 * xdisp.c (display_count_lines): 3rd argument and return value now
7808 EMACS_INT. All callers changed.
7809 (pint2hrstr): Last argument is now EMACS_INT.
7810
7811 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7812 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7813 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7814 (decode_coding_utf_16, decode_coding_emacs_mule)
7815 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7816 (decode_coding_ccl, decode_coding_charset)
7817 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7818 (decode_coding_iso_2022, decode_coding_emacs_mule)
7819 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7820 <char_offset, last_offset>: Declare EMACS_INT.
7821 (encode_coding_utf_8, encode_coding_utf_16)
7822 (encode_coding_emacs_mule, encode_invocation_designation)
7823 (encode_designation_at_bol, encode_coding_iso_2022)
7824 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7825 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7826 Declare EMACS_INT.
7827 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7828 (encode_invocation_designation): Last argument P_NCHARS is now
7829 EMACS_INT.
7830 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7831 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7832
7833 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7834 All users changed.
7835
7836 * ccl.c (Fccl_execute_on_string): Declare some variables
7837 EMACS_INT.
7838
7839 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7840
7841 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7842
7843 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7844
7845 * process.c (Fformat_network_address): Doc fix.
7846
7847 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7848
7849 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7850
7851 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7852
7853 * keyboard.c (read_char): Call Lisp function help-form-show,
7854 instead of using internal_with_output_to_temp_buffer.
7855 (Qhelp_form_show): New var.
7856 (syms_of_keyboard): Use DEFSYM macro.
7857
7858 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7859
7860 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7861
7862 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7863
7864 * process.c (Flist_processes): Remove to Lisp.
7865 (list_processes_1): Delete.
7866
7867 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7868
7869 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7870
7871 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7872
7873 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7874
7875 Fix more problems found by GCC 4.6.0's static checks.
7876
7877 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7878
7879 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7880
7881 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7882
7883 * xdisp.c (vmessage): Mark as a printf-like function.
7884
7885 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7886
7887 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7888
7889 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7890 printf-like functions.
7891 (tiff_load): Add casts to remove these marks before passing them
7892 to system-supplied API.
7893
7894 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7895
7896 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7897 This avoids several warnings with gcc -Wstrict-overflow.
7898 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7899 directly, rather than having caller test rule sign. This avoids
7900 some unnecessary tests.
7901 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7902 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7903 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7904
7905 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7906 (xfont_open): Avoid unnecessary tests.
7907
7908 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7909
7910 * composite.h, composite.c (composition_gstring_put_cache):
7911 Use EMACS_INT, not int, for length.
7912
7913 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7914 breaking out part of COMPOSITION_DECODE_RULE.
7915 (COMPOSITION_DECODE_RULE): Use it.
7916 * composite.c (get_composition_id): Remove unused local vars,
7917 by using the new macro.
7918
7919 * textprop.c (set_text_properties_1): Change while to do-while,
7920 since the condition is always true at first.
7921
7922 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7923 (interval_deletion_adjustment): Return unsigned value.
7924 All uses changed.
7925
7926 * process.c (list_processes_1, create_pty, read_process_output):
7927 (exec_sentinel): Remove vars that were set but not used.
7928 (create_pty): Remove unnecessary "volatile"s.
7929 (Fnetwork_interface_info): Avoid possibility of int overflow.
7930 (read_process_output): Do adaptive read buffering even if carryover.
7931 (read_process_output): Simplify nbytes computation if buffered.
7932
7933 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7934
7935 * syntax.c (scan_words): Remove var that was set but not used.
7936 (update_syntax_table): Use unsigned instead of int.
7937
7938 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7939 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7940 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7941
7942 * print.c (print_error_message): Avoid int overflow.
7943
7944 * font.c (font_list_entities): Redo for clarity,
7945 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7946
7947 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7948 (font_score): Avoid potential overflow in diff calculation.
7949
7950 * fns.c (substring_both): Remove var that is set but not used.
7951 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7952
7953 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7954
7955 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7956 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7957 can always succeed if overflow has undefined behavior.
7958
7959 * search.c (boyer_moore, wordify): Remove vars set but not used.
7960 (wordify): Omit three unnecessary tests.
7961
7962 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7963 All callers changed. This avoids the need for an unused var.
7964
7965 * casefiddle.c (casify_region): Remove var that is set but not used.
7966
7967 * dired.c (file_name_completion): Remove var that is set but not used.
7968
7969 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7970
7971 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7972 (Finsert_file_contents): Remove unnecessary code checking fd.
7973
7974 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7975 Check for integer overflow on size calculations.
7976
7977 * buffer.c (Fprevious_overlay_change): Remove var that is set
7978 but not used.
7979
7980 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7981 Remove vars that are set but not used.
7982 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7983 (timer_check_2): Mark vars as initialized.
7984
7985 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7986
7987 * image.c (lookup_image): Remove var that is set but not used.
7988 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7989
7990 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7991 that are set but not used.
7992
7993 * xfns.c (make_invisible_cursor): Don't return garbage
7994 if XCreateBitmapFromData fails (Bug#8410).
7995
7996 * xselect.c (x_get_local_selection, x_handle_property_notify):
7997 Remove vars that are set but not used.
7998
7999 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8000 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8001
8002 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8003 Remove var that is set but not used.
8004 (scroll_bar_windows_size): Now size_t, not int.
8005 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8006 Check for overflow.
8007
8008 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8009 (map_tty_color) [!defined MSDOS]: Likewise.
8010
8011 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8012
8013 * coding.c: Remove vars that are set but not used.
8014 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8015 All callers changed.
8016 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8017 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8018 (decode_coding_charset): Remove vars that are set but not used.
8019
8020 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8021 that is set but not used.
8022
8023 * print.c (print_object): Remove var that is set but not used.
8024
8025 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8026 The gnulib version avoids calling malloc in the usual case,
8027 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8028 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8029 * filelock.c (current_lock_owner): Likewise.
8030 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8031 * sysdep.c: Include allocator.h, careadlinkat.h.
8032 (emacs_no_realloc_allocator): New static constant.
8033 (emacs_readlink): New function.
8034 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8035 ../lib/careadlinkat.h.
8036
8037 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8038
8039 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8040 first non-nil return value).
8041
8042 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8043
8044 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8045 if not defined (Bug#8403).
8046
8047 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8048
8049 * xdisp.c (display_count_lines): Remove parameter `start',
8050 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8051 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8052 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8053 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8054 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8055 and thereabouts. All callers changed.
8056 (get_per_char_metric): Remove parameter `f', unused since
8057 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8058
8059 2011-04-02 Jim Meyering <meyering@redhat.com>
8060
8061 do not dereference NULL upon failed strdup
8062 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8063 (ns_get_family): Likewise.
8064
8065 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8066
8067 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8068
8069 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8070
8071 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8072 later (Bug#8403).
8073
8074 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8075
8076 Add lexical binding.
8077
8078 * window.c (Ftemp_output_buffer_show): New fun.
8079 (Fsave_window_excursion):
8080 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8081
8082 * lread.c (lisp_file_lexically_bound_p): New function.
8083 (Fload): Bind Qlexical_binding.
8084 (readevalloop): Remove `evalfun' arg.
8085 Bind Qinternal_interpreter_environment.
8086 (Feval_buffer): Bind Qlexical_binding.
8087 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8088 Mark as dynamic.
8089 (syms_of_lread): Declare `lexical-binding'.
8090
8091 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8092
8093 * keyboard.c (eval_dyn): New fun.
8094 (menu_item_eval_property): Use it.
8095
8096 * image.c (parse_image_spec): Use Ffunctionp.
8097
8098 * fns.c (concat, mapcar1): Accept byte-code-functions.
8099
8100 * eval.c (Fsetq): Handle lexical vars.
8101 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8102 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8103 (FletX, Flet): Obey lexical binding.
8104 (Fcommandp): Handle closures.
8105 (Feval): New `lexical' arg.
8106 (eval_sub): New function extracted from Feval. Use it almost
8107 everywhere where Feval was used. Look up vars in lexical env.
8108 Handle closures.
8109 (Ffunctionp): Move from subr.el.
8110 (Ffuncall): Handle closures.
8111 (apply_lambda): Remove `eval_flags'.
8112 (funcall_lambda): Handle closures and new byte-code-functions.
8113 (Fspecial_variable_p): New function.
8114 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8115 but without exporting it to Lisp.
8116
8117 * doc.c (Fdocumentation, store_function_docstring):
8118 * data.c (Finteractive_form): Handle closures.
8119
8120 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8121 interactive spec.
8122
8123 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8124 New byte-codes.
8125 (exec_byte_code): New function extracted from Fbyte_code to handle new
8126 calling convention for byte-code-functions. Add new byte-codes.
8127
8128 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8129
8130 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8131
8132 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8133
8134 * xdisp.c (redisplay_internal): Fix prototype.
8135
8136 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8137
8138 * xdisp.c (SCROLL_LIMIT): New macro.
8139 (try_scrolling): Use it when setting scroll_limit.
8140 Limit scrolling to 100 screen lines.
8141 (redisplay_window): Even when falling back on "recentering",
8142 position point in the window according to scroll-conservatively,
8143 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8144
8145 (try_scrolling): When point is above the window, allow searching
8146 as far as scroll_max, or one screenful, to compute vertical
8147 distance from PT to the scroll margin position. This prevents
8148 try_scrolling from unnecessarily failing when
8149 scroll-conservatively is set to a value slightly larger than the
8150 window height. Clean up the case of PT below the margin at bottom
8151 of window: scroll_max can no longer be INT_MAX. When aggressive
8152 scrolling is in use, don't let point enter the opposite scroll
8153 margin as result of the scroll.
8154 (syms_of_xdisp) <scroll-conservatively>: Document the
8155 threshold of 100 lines for never-recentering scrolling.
8156
8157 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * dispextern.h (move_it_by_lines):
8160 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8161 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8162 (message_log_check_duplicate): Remove parameters `prev_bol' and
8163 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8164 (redisplay_internal): Remove parameter `preserve_echo_area',
8165 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8166
8167 * indent.c (Fvertical_motion):
8168 * window.c (window_scroll_pixel_based, Frecenter):
8169 Don't pass `need_y_p' to `move_it_by_lines'.
8170
8171 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8172
8173 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8174 steal a few bits to be more compact.
8175 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8176 Remove unneeded casts.
8177
8178 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8179
8180 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8181
8182 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8183 binding" message (bug#7967).
8184
8185 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 Fix more problems found by GCC 4.6.0's static checks.
8188
8189 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8190 Remove unused local var.
8191
8192 * editfns.c (Fmessage_box): Remove unused local var.
8193
8194 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8195 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8196 Omit unused local vars.
8197 * window.c (shrink_windows): Omit unused local var.
8198 * menu.c (digest_single_submenu): Omit unused local var.
8199 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8200 Omit unused local var.
8201
8202 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8203 Don't assume string length fits in int.
8204 (keyremap_step, read_key_sequence): Use size_t for sizes.
8205 (read_key_sequence): Don't check last_real_key_start redundantly.
8206
8207 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8208 instead of alloca (Bug#8344).
8209
8210 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8211 (Fbacktrace_frame): Don't assume nframes fits in int.
8212
8213 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8214
8215 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8216 concerns.
8217
8218 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8219
8220 * cm.c (calccost): Turn while-do into do-while, for clarity.
8221
8222 * keyboard.c (syms_of_keyboard): Use the same style as later
8223 in this function when indexing through an array. This also
8224 works around GCC bug 48267.
8225
8226 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8227
8228 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8229
8230 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8231 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8232
8233 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8234 This avoids undefined behavior on integer overflow, and is a bit
8235 more convenient anyway since it is compared to a size_t variable.
8236
8237 Variadic C functions now count arguments with size_t, not int.
8238 This avoids an unnecessary limitation on 64-bit machines, which
8239 caused (substring ...) to crash on large vectors (Bug#8344).
8240 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8241 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8242 All variadic functions and their callers changed accordingly.
8243 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8244 * data.c (arith_driver, float_arith_driver): Likewise.
8245 * editfns.c (general_insert_function): Likewise.
8246 * eval.c (struct backtrace.nargs, interactive_p)
8247 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8248 (funcall_lambda, mark_backtrace): Likewise.
8249 * fns.c (concat): Likewise.
8250 * frame.c (x_set_frame_parameters): Likewise.
8251 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8252 0 if not found, not -1. All callers changed.
8253
8254 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8255 (stack_copy_size): Now size_t, not int.
8256 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8257
8258 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8259
8260 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8261 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8262 All callers changed.
8263
8264 * lisp.h (multibyte_char_to_unibyte):
8265 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8266 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8267 * character.h (CHAR_TO_BYTE8):
8268 * cmds.c (internal_self_insert):
8269 * editfns.c (general_insert_function):
8270 * keymap.c (push_key_description):
8271 * search.c (Freplace_match):
8272 * xdisp.c (message_dolog, set_message_1): All callers changed.
8273
8274 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8275
8276 * keyboard.c (safe_run_hook_funcall): New function.
8277 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8278 don't set the hook to nil, but remove the offending function instead.
8279 (Qcommand_hook_internal): Remove, unused.
8280 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8281 Vcommand_hook_internal.
8282
8283 * eval.c (enum run_hooks_condition): Remove.
8284 (funcall_nil, funcall_not): New functions.
8285 (run_hook_with_args): Call each function through a `funcall' argument.
8286 Remove `cond' argument, now redundant.
8287 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8288 (Frun_hook_with_args_until_failure): Adjust accordingly.
8289 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8290
8291 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8292
8293 * dispextern.h (string_buffer_position): Remove declaration.
8294
8295 * print.c (strout): Remove parameter `multibyte', unused since
8296 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8297
8298 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8299 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8300 All callers changed.
8301
8302 * w32.c (_wsa_errlist): Use braces for struct initializers.
8303
8304 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8305 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8306 All callers changed.
8307 (string_buffer_position): Likewise. Also, make static (it's never
8308 used outside xdisp.c).
8309 (cursor_row_p): Remove parameter `w', unused since
8310 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8311 (decode_mode_spec): Remove parameter `precision', introduced during
8312 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8313 All callers changed.
8314
8315 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8316
8317 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8318
8319 2011-03-27 Anders Lindgren <andlind@gmail.com>
8320
8321 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8322 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8323 (ns_update_auto_hide_menu_bar): New functions.
8324 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8325 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8326 ns_constrain_all_frames.
8327 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8328 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8329
8330 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8331
8332 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8333
8334 2011-03-27 Glenn Morris <rgm@gnu.org>
8335
8336 * syssignal.h: Replace RETSIGTYPE with void.
8337 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8338 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8339 Replace SIGTYPE with void everywhere.
8340 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8341 * s/template.h (SIGTYPE): Remove commented out definition.
8342
8343 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8344
8345 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8346 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8347
8348 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8349
8350 * w32.c (read_unc_volume): Use parameter `henum', instead of
8351 global variable `wget_enum_handle'.
8352
8353 * keymap.c (describe_vector): Remove parameters `indices' and
8354 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8355 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8356
8357 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8358
8359 * keyboard.c (timer_check): Remove parameter `do_it_now',
8360 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8361 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8362 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8363
8364 * keyboard.c (read_char):
8365 * w32menu.c (w32_menu_display_help):
8366 * xmenu.c (show_help_event, menu_help_callback):
8367 Adjust calls to `show_help_echo'.
8368
8369 * gtkutil.c (xg_maybe_add_timer):
8370 * keyboard.c (readable_events):
8371 * process.c (wait_reading_process_output):
8372 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8373
8374 * insdel.c (adjust_markers_gap_motion):
8375 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8376 (gap_left, gap_right): Don't call it.
8377
8378 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8379
8380 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8381 incurred during fontification.
8382
8383 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8384
8385 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8386 (DEFVAR_PER_BUFFER): Don't pass it.
8387
8388 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8389 (scrolling_window): Don't pass it.
8390
8391 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8392
8393 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8394
8395 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8396 and `suffix'.
8397 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8398 of variables specific to SELinux and computation of `encoded_absname'.
8399
8400 * image.c (XPutPixel): Remove unused variable `height'.
8401
8402 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8403
8404 * unexw32.c (get_section_info): Remove unused variable `section'.
8405
8406 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8407 (system_process_attributes): Remove unused variable `sess'.
8408 (sys_read): Remove unused variable `err'.
8409
8410 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8411 (w32_wnd_proc): Remove unused variable `isdead'.
8412 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8413 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8414 (x_create_tip_frame): Remove unused variable `tem'.
8415
8416 * w32inevt.c (w32_console_read_socket):
8417 Remove unused variable `no_events'.
8418
8419 * w32term.c (x_draw_composite_glyph_string_foreground):
8420 Remove unused variable `width'.
8421
8422 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8423
8424 * w32term.c (x_set_glyph_string_clipping):
8425 Don't pass uninitialized region to CombineRgn.
8426
8427 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8430 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8431 (Fx_close_connection): Remove unused variable `i'.
8432
8433 * w32font.c (w32font_draw): Return number of glyphs.
8434 (w32font_open_internal): Remove unused variable `i'.
8435 (w32font_driver): Add missing initializer.
8436
8437 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8438 (fill_in_menu): Remove unused variable `items_added'.
8439
8440 * w32term.c (last_mouse_press_frame): Remove static global variable.
8441 (w32_clip_to_row): Remove unused variable `f'.
8442 (x_delete_terminal): Remove unused variable `i'.
8443
8444 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8445 (NOTHING): Remove unused static global variable.
8446 (uniscribe_check_otf): Remove unused variable `table'.
8447 (uniscribe_font_driver): Add missing initializers.
8448
8449 2011-03-23 Julien Danjou <julien@danjou.info>
8450
8451 * term.c (Fsuspend_tty, Fresume_tty):
8452 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8453 * window.c (temp_output_buffer_show):
8454 * insdel.c (signal_before_change):
8455 * frame.c (Fhandle_switch_frame):
8456 * fileio.c (Fdo_auto_save):
8457 * emacs.c (Fkill_emacs):
8458 * editfns.c (save_excursion_restore):
8459 * cmds.c (internal_self_insert):
8460 * callint.c (Fcall_interactively):
8461 * buffer.c (Fkill_all_local_variables):
8462 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8463 Use Frun_hooks.
8464 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8465 unconditionally since it does the check itself.
8466
8467 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8468
8469 Fix more problems found by GCC 4.5.2's static checks.
8470
8471 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8472 the first time through the loop, since we know p0 < p1 then.
8473 This also avoids a gcc -Wstrict-overflow warning.
8474
8475 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8476 leading to a memory leak, possible in functions like
8477 load_charset_map_from_file that can allocate an unbounded number
8478 of objects (Bug#8318).
8479
8480 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8481 that could (at least in theory) be that large.
8482
8483 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8484 This is less likely to overflow, and avoids undefined behavior if
8485 overflow does occur. All callers changed. Use strtoul to scan
8486 for the unsigned long integer.
8487 (pint2hrstr): Simplify and tune code slightly.
8488 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8489
8490 * scroll.c (do_scrolling): Work around GCC bug 48228.
8491 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8492
8493 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8494 This also avoids a warning with gcc -Wstrict-overflow.
8495 (validate_x_resource_name): Simplify count usage.
8496 This also avoids a warning with gcc -Wstrict-overflow.
8497
8498 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8499 fail (Bug#8306).
8500
8501 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8502
8503 * process.c (Fmake_network_process): Use socklen_t, not int,
8504 where POSIX says socklen_t is required in portable programs.
8505 This fixes a porting bug on hosts like 64-bit HP-UX, where
8506 socklen_t is wider than int (Bug#8277).
8507 (Fmake_network_process, server_accept_connection):
8508 (wait_reading_process_output, read_process_output):
8509 Likewise.
8510
8511 * process.c: Rename or move locals to avoid shadowing.
8512 (list_processes_1, Fmake_network_process):
8513 (read_process_output_error_handler, exec_sentinel_error_handler):
8514 Rename or move locals.
8515 (Fmake_network_process): Define label "retry_connect" only if needed.
8516 (Fnetwork_interface_info): Fix pointer signedness.
8517 (process_send_signal): Add cast to avoid pointer signedness problem.
8518 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8519 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8520
8521 Make tparam.h and terminfo.c consistent.
8522 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8523 Include tparam.h instead, since it declares them.
8524 * cm.h (PC): Remove extern decl; tparam.h now does this.
8525 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8526 * terminfo.c: Include tparam.h, to check interfaces.
8527 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8528 (tparam): Adjust signature to match interface in tparam.h;
8529 this removes some undefined behavior. Check that outstring and len
8530 are zero, which they always are with Emacs.
8531 * tparam.h (PC, BC, UP): New extern decls.
8532
8533 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8534 (xftfont_open): Rename locals to avoid shadowing.
8535
8536 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8537 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8538 (OTF_TAG_SYM): Omit macro if not needed.
8539 (ftfont_list): Remove unused local.
8540 (get_adstyle_property, ftfont_pattern_entity):
8541 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8542 Rename locals to avoid shadowing.
8543
8544 * xfont.c (xfont_list_family): Mark var as initialized.
8545
8546 * xml.c (make_dom): Now static.
8547
8548 * composite.c (composition_compute_stop_pos): Rename local to
8549 avoid shadowing.
8550 (composition_reseat_it): Remove unused locals.
8551 (find_automatic_composition, composition_adjust_point): Likewise.
8552 (composition_update_it): Mark var as initialized.
8553 (find_automatic_composition): Mark vars as initialized,
8554 with a FIXME (Bug#8290).
8555
8556 character.h: Rename locals to avoid shadowing.
8557 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8558 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8559 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8560 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8561 to avoid shadowing.
8562
8563 * textprop.c (property_change_between_p): Remove; unused.
8564
8565 * intervals.c (interval_start_pos): Now static.
8566
8567 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8568
8569 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8570 Rename locals to avoid shadowing.
8571
8572 * sound.c (wav_play, au_play, Fplay_sound_internal):
8573 Fix pointer signedness.
8574 (alsa_choose_format): Remove unused local var.
8575 (wav_play): Initialize a variable to 0, to prevent undefined
8576 behavior (Bug#8278).
8577
8578 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8579
8580 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8581
8582 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8583 clobbering (Bug#8298).
8584 * sysdep.c (sys_subshell): Likewise.
8585 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8586
8587 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8588 This should get cleaned up, so that child_setup has the
8589 same signature on all platforms.
8590
8591 * callproc.c (call_process_cleanup): Now static.
8592 (relocate_fd): Rename locals to avoid shadowing.
8593
8594 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8595
8596 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8597 not to be necessary, and produces flickering.
8598
8599 2011-03-20 Glenn Morris <rgm@gnu.org>
8600
8601 * config.in: Remove file.
8602
8603 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8604
8605 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8606 are now in src/globals.h.
8607 (syms_of_minibuf): Remove spurious & from previous change.
8608
8609 2011-03-20 Leo Liu <sdl.web@gmail.com>
8610
8611 * minibuf.c (completing-read-function): New variable.
8612 (completing-read-default): Rename from completing-read.
8613 (completing-read): Call completing-read-function.
8614
8615 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8616
8617 * xfaces.c (Fx_load_color_file):
8618 Read color file from absolute filename (bug#8250).
8619
8620 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * makefile.w32-in: Update dependencies.
8623
8624 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8625
8626 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8627
8628 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8629
8630 Fix more problems found by GCC 4.5.2's static checks.
8631
8632 * process.c (make_serial_process_unwind, send_process_trap):
8633 (sigchld_handler): Now static.
8634
8635 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8636 That way, the code declares only the vars that it needs.
8637 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8638 * s/cygwin.h (PTY_ITERATION): Likewise.
8639 * s/darwin.h (PTY_ITERATION): Likewise.
8640 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8641
8642 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8643 * process.c (allocate_pty): Don't declare stb unless it's needed.
8644
8645 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8646 (CONSTANTLIM): Remove; unused.
8647 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8648 Define only if needed.
8649
8650 * unexelf.c (unexec): Name an expression,
8651 to avoid gcc -Wbad-function-cast warning.
8652 Use a different way to cause a compilation error if anyone uses
8653 n rather than nn, a way that does not involve shadowing.
8654 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8655
8656 * deps.mk (unexalpha.o): Remove; unused.
8657
8658 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8659 * unexec.h: New file.
8660 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8661 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8662 Depend on unexec.h.
8663 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8664 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8665 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8666 Change as necessary to match prototype in unexec.h.
8667
8668 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8669 shadowing.
8670 (back_comment, skip_chars): Mark vars as initialized.
8671
8672 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8673 Rename locals to avoid shadowing.
8674
8675 * lread.c (read1): Rewrite so as not to use empty "else".
8676 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8677
8678 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8679
8680 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8681 warning when compiling print.c.
8682
8683 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8684 instead of using an uninitialized var.
8685 (font_sort_entities): Mark var as initialized.
8686
8687 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8688
8689 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8690 pointers to constants.
8691 (font_parse_fcname): Remove unused vars.
8692 (font_delete_unmatched): Now static.
8693 (font_get_spec): Remove; unused.
8694 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8695 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8696 Rename or move locals to avoid shadowing.
8697
8698 * fns.c (require_nesting_list, require_unwind): Now static.
8699 (Ffillarray): Rename locals to avoid shadowing.
8700
8701 * floatfns.c (domain_error2): Define only if needed.
8702 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8703
8704 * alloc.c (mark_backtrace): Move decl from here ...
8705 * lisp.h: ... to here, so that it can be checked.
8706
8707 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8708 (Fdefvar): Rewrite so as not to use empty "else".
8709 (lisp_indirect_variable): Name an expression,
8710 to avoid gcc -Wbad-function-cast warning.
8711 (Fdefvar): Rename locals to avoid shadowing.
8712
8713 * callint.c (quotify_arg, quotify_args): Now static.
8714 (Fcall_interactively): Rename locals to avoid shadowing.
8715 Use const pointer when appropriate.
8716
8717 * lisp.h (get_system_name, get_operating_system_release):
8718 Move decls here, to check interfaces.
8719 * process.c (get_operating_system_release): Move decl to lisp.h.
8720 * xrdb.c (get_system_name): Likewise.
8721 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8722 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8723 some of which prompt warnings from gcc -Wbad-function-cast.
8724 (Fformat_time_string, Fencode_time, Finsert_char):
8725 (Ftranslate_region_internal, Fformat):
8726 Rename or remove local vars to avoid shadowing.
8727 (Ftranslate_region_internal): Mark var as initialized.
8728
8729 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8730 avoid shadowing.
8731
8732 * lisp.h (eassert): Check that the argument compiles, even if
8733 ENABLE_CHECKING is not defined.
8734
8735 * data.c (Findirect_variable): Name an expression, to avoid
8736 gcc -Wbad-function-cast warning.
8737 (default_value, arithcompare, arith_driver, arith_error): Now static.
8738 (store_symval_forwarding): Rename local to avoid shadowing.
8739 (Fmake_variable_buffer_local, Fmake_local_variable):
8740 Mark variables as initialized.
8741 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8742
8743 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8744 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8745 Rename locals to avoid shadowing.
8746 (mark_stack): Move local variables into the #ifdef region where
8747 they're used.
8748 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8749 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8750 needed otherwise.
8751 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8752 (GC_STRING_CHARS): Remove; not used.
8753 (Fmemory_limit): Cast sbrk's returned value to char *.
8754
8755 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8756 avoids undefined behavior in theory.
8757
8758 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8759
8760 Use functions, not macros, for up- and down-casing (Bug#8254).
8761 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8762 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8763 to use the following functions instead of these macros.
8764 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8765 EMACS_INT, since callers assume the returned value fits in int.
8766 (upcase1): Likewise, for UPCASE_TABLE.
8767 (uppercasep, lowercasep, upcase): New static inline functions.
8768 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8769 the race-condition problem in the old DOWNCASE.
8770
8771 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8772 Rename locals to avoid shadowing.
8773 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8774 (regex_compile, re_search_2, re_match_2_internal):
8775 Remove unused local vars.
8776 (FREE_VAR): Rewrite so as not to use empty "else",
8777 which gcc can warn about.
8778 (regex_compile, re_match_2_internal): Mark locals as initialized.
8779 (RETALLOC_IF): Define only if needed.
8780 (WORDCHAR_P): Likewise. This one is never needed, but is used
8781 only in a comment talking about a compiler bug, so put inside
8782 the #if 0 of that comment.
8783 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8784 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8785 Remove; unused.
8786
8787 * search.c (boyer_moore): Rename locals to avoid shadowing.
8788 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8789 (PREV_CHAR_BOUNDARY): Likewise.
8790
8791 * search.c (simple_search): Remove unused var.
8792
8793 * dired.c (compile_pattern): Move decl from here ...
8794 * lisp.h: ... to here, so that it can be checked.
8795 (struct re_registers): New forward decl.
8796
8797 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8798
8799 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8800 All uses changed.
8801 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8802 Rename locals to avoid shadowing.
8803 (Fvertical_motion): Mark locals as initialized.
8804
8805 * casefiddle.c (casify_object, casify_region): Now static.
8806 (casify_region): Mark local as initialized.
8807
8808 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8809
8810 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8811 New macros, so that the caller can use some names other than
8812 gcpro1, gcpro2, etc.
8813 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8814 of the new macros.
8815 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8816 argument, for consistency with GCPRO2_VAR, etc: it is now the
8817 prefix of the variable, not the variable itself. All uses
8818 changed.
8819 * dired.c (directory_files_internal, file_name_completion):
8820 Rename locals to avoid shadowing.
8821
8822 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8823 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8824 dired.c's scmp function, had undefined behavior.
8825 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8826 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8827 * buffer.h: ... to here, because these macros use current_buffer,
8828 and the new implementation with inline functions needs to have
8829 current_buffer in scope now, rather than later when the macros
8830 are used.
8831 (downcase, upcase1): New static inline functions.
8832 (DOWNCASE, UPCASE1): Reimplement using these functions.
8833 This avoids undefined behavior in expressions like
8834 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8835 from race conditions in accessing the global variables
8836 case_temp1 and case_temp2.
8837 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8838 * lisp.h (case_temp1, case_temp2): Remove their decls.
8839 * character.h (ASCII_CHAR_P): Move from here ...
8840 * lisp.h: ... to here, so that the inline functions mentioned
8841 above can use them.
8842
8843 * dired.c (directory_files_internal_unwind): Now static.
8844
8845 * fileio.c (file_name_as_directory, directory_file_name):
8846 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8847 Now static.
8848 (file_name_as_directory): Use const pointers when appropriate.
8849 (Fexpand_file_name): Likewise. In particular, newdir might
8850 point at constant storage, so make it a const pointer.
8851 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8852 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8853 signedness issues.
8854 (Fset_file_times, Finsert_file_contents, auto_save_error):
8855 Rename locals to avoid shadowing.
8856
8857 * minibuf.c (choose_minibuf_frame_1): Now static.
8858 (Ftry_completion, Fall_completions): Rename or remove locals
8859 to avoid shadowing.
8860
8861 * marker.c (bytepos_to_charpos): Remove; unused.
8862
8863 * lisp.h (verify_bytepos, count_markers): New decls,
8864 so that gcc does not warn that these functions aren't declared.
8865
8866 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8867 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8868 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8869 (copy_text): Remove unused local var.
8870
8871 * filelock.c (within_one_second): Now static.
8872 (lock_file_1): Rename local to avoid shadowing.
8873
8874 * buffer.c (fix_overlays_before): Mark locals as initialized.
8875 (fix_start_end_in_overlays): Likewise. This function should be
8876 simplified by using pointers-to-pointers, but that's a different
8877 matter.
8878 (switch_to_buffer_1): Now static.
8879 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8880 (report_overlay_modification): Rename locals to avoid shadowing.
8881
8882 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8883 Fix pointer signedness issue.
8884 (sys_subshell): Mark local as volatile if checking for lint,
8885 to suppress a gcc -Wclobbered warning that does not seem to be right.
8886 (MAXPATHLEN): Define only if needed.
8887
8888 * process.c (serial_open, serial_configure): Move decls from here ...
8889 * systty.h: ... to here, so that they can be checked.
8890
8891 * fns.c (get_random, seed_random): Move extern decls from here ...
8892 * lisp.h: ... to here, so that they can be checked.
8893
8894 * sysdep.c (reset_io): Now static.
8895 (wait_for_termination_signal): Remove; unused.
8896
8897 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8898 (copy_keymap_item, append_key, push_text_char_description):
8899 Now static.
8900 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8901 (DENSE_TABLE_SIZE): Remove; unused.
8902 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8903 (describe_map_tree):
8904 Rename locals to avoid shadowing.
8905
8906 * keyboard.c: Declare functions static if they are not used elsewhere.
8907 (echo_char, echo_dash, cmd_error, top_level_2):
8908 (poll_for_input, handle_async_input): Now static.
8909 (read_char, kbd_buffer_get_event, make_lispy_position):
8910 (make_lispy_event, make_lispy_movement, apply_modifiers):
8911 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8912 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8913 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8914 (read_key_sequence, read_char): Mark locals as initialized.
8915 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8916
8917 * keyboard.h (make_ctrl_char): New decl.
8918 (mark_kboards): Move decl here ...
8919 * alloc.c (mark_kboards): ... from here.
8920
8921 * lisp.h (force_auto_save_soon): New decl.
8922
8923 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8924 (DEFINE_DUMMY_FUNCTION): New macro.
8925 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8926 Use it.
8927 (main): Add casts to avoid warnings
8928 if GCC considers string literals to be constants.
8929
8930 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8931
8932 * dbusbind.c: Pointer signedness fixes.
8933 (xd_signature, xd_append_arg, xd_initialize):
8934 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8935 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8936 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8937 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8938
8939 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8940 if GCC considers string literals to be constants.
8941 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8942
8943 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8944
8945 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8946 (print_preprocess, print_object): New macro to fix last change.
8947
8948 * print.c (print_preprocess): Don't forget font objects.
8949
8950 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * emacs.c (USAGE3): Doc fixes.
8953
8954 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8955
8956 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8957 structure.
8958
8959 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8960
8961 * lisp.h (VWindow_system, Qfile_name_history):
8962 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8963 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8964 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8965
8966 * w32select.c: Don't #include "keyboard.h".
8967 (run_protected): Add extern declaration for waiting_for_input.
8968
8969 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8970 * w32console.c (detect_input_pending, read_input_pending)
8971 (encode_terminal_code):
8972 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8973 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8974 (w32_system_caret_y, Qfile_name_history):
8975 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8976 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8977 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8978 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8979 * w32proc.c (Qlocal, report_file_error):
8980 * w32term.c (Vwindow_system, updating_frame):
8981 * w32uniscribe.c (initialized, uniscribe_font_driver):
8982 Remove unneeded extern declarations.
8983
8984 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8985
8986 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8987
8988 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8989
8990 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8991 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8992 These macros can no longer be used for assignment.
8993
8994 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8995 Assign struct members directly, instead of using BUF_BEGV etc.
8996 (record_buffer_markers, fetch_buffer_markers): New functions for
8997 recording and fetching special buffer markers.
8998 (set_buffer_internal_1, set_buffer_temp): Use them.
8999
9000 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9001
9002 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9003
9004 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9005 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9006
9007 * xdisp.c (hscroll_window_tree):
9008 (reconsider_clip_changes): Use PT instead of BUF_PT.
9009
9010 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9011
9012 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9013 $(EMACS_ROOT)/lib/intprops.h.
9014
9015 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9016
9017 Fix more problems found by GCC 4.5.2's static checks.
9018
9019 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9020 to unsigned char * to avoid compiler diagnostic.
9021 (xg_free_frame_widgets): Make it clear that a local variable is
9022 needed only if USE_GTK_TOOLTIP.
9023 (gdk_window_get_screen): Make it clear that this macro is needed
9024 only if USE_GTK_TOOLTIP.
9025 (int_gtk_range_get_value): New function, which avoids a diagnostic
9026 from gcc -Wbad-function-cast.
9027 (xg_set_toolkit_scroll_bar_thumb): Use it.
9028 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9029 diagnostic from gcc -Wbad-function-cast.
9030 (get_utf8_string, xg_get_file_with_chooser):
9031 Rename locals to avoid shadowing.
9032 (create_dialog): Move locals to avoid shadowing.
9033
9034 * xgselect.c (xg_select): Remove unused var.
9035
9036 * image.c (four_corners_best): Mark locals as initialized.
9037 (gif_load): Initialize transparent_p to zero (Bug#8238).
9038 Mark another local as initialized.
9039 (my_png_error, my_error_exit): Mark with NO_RETURN.
9040
9041 * image.c (clear_image_cache): Now static.
9042 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9043 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9044 (x_edge_detection): Remove unnecessary cast that
9045 gcc -Wbad-function-cast diagnoses.
9046 (gif_load): Fix pointer signedness.
9047 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9048 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9049
9050 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9051
9052 Improve quality of tests for time stamp overflow.
9053 For example, without this patch (encode-time 0 0 0 1 1
9054 1152921504606846976) returns the obviously-bogus value (-948597
9055 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9056 reports time overflow. See
9057 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9058 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9059 * editfns.c: Include limits.h and intprops.h.
9060 (TIME_T_MIN, TIME_T_MAX): New macros.
9061 (time_overflow): Move earlier, to before first use.
9062 (hi_time, lo_time): New functions, for an accurate test for
9063 out-of-range times.
9064 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9065 (Fget_internal_run_time): Don't assume time_t fits in int.
9066 (make_time): Use list2 instead of Fcons twice.
9067 (Fdecode_time): More accurate test for out-of-range times.
9068 (check_tm_member): New function.
9069 (Fencode_time): Use it, to test for out-of-range times.
9070 (lisp_time_argument): Don't rely on undefined left-shift and
9071 right-shift behavior when checking for time stamp overflow.
9072
9073 * editfns.c (time_overflow): New function, refactoring common code.
9074 (Fformat_time_string, Fdecode_time, Fencode_time):
9075 (Fcurrent_time_string): Use it.
9076
9077 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9078 * dired.c (make_time): Move to ...
9079 * editfns.c (make_time): ... here.
9080 * systime.h: Note the move.
9081
9082 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9083
9084 * fringe.c (update_window_fringes): Remove unused variables.
9085
9086 * unexmacosx.c (copy_data_segment): Also copy __got section.
9087 (Bug#8223)
9088
9089 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9090
9091 * termcap.c [MSDOS]: Include "msdos.h".
9092 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9093 Constify `char *' arguments and their references according to
9094 prototypes in tparam.h.
9095
9096 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9097
9098 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9099 Adapt all references accordingly.
9100
9101 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9102
9103 2011-03-11 Tom Tromey <tromey@redhat.com>
9104
9105 * buffer.c (syms_of_buffer): Remove obsolete comment.
9106
9107 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9108
9109 * termhooks.h (encode_terminal_code): Declare prototype.
9110
9111 * msdos.c (encode_terminal_code): Don't declare prototype.
9112
9113 * term.c (encode_terminal_code): Now external again, used by
9114 w32console.c and msdos.c.
9115
9116 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9117 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9118
9119 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9120
9121 Fix some minor problems found by GCC 4.5.2's static checks.
9122
9123 * fringe.c (update_window_fringes): Mark locals as initialized
9124 (Bug#8227).
9125 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9126
9127 * alloc.c (mark_fringe_data): Move decl from here ...
9128 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9129 to check its interface.
9130 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9131
9132 * fontset.c (free_realized_fontset): Now static.
9133 (Fset_fontset_font): Rename local to avoid shadowing.
9134 (fontset_font): Mark local as initialized.
9135 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9136
9137 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9138
9139 * xselect.c (x_disown_buffer_selections): Remove; not used.
9140 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9141 (x_own_selection, Fx_disown_selection_internal): Rename locals
9142 to avoid shadowing.
9143 (x_handle_dnd_message): Remove local to avoid shadowing.
9144
9145 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9146 so that the caller can use some name other than gcpro1.
9147 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9148 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9149 (Fx_backspace_delete_keys_p):
9150 Use them to avoid shadowing, and rename vars to avoid shadowing.
9151 (x_decode_color, x_set_name, x_window): Now static.
9152 (Fx_create_frame): Add braces to silence GCC warning.
9153 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9154 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9155 Remove unused locals.
9156 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9157 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9158 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9159 macros.
9160
9161 * xterm.h (x_mouse_leave): New decl.
9162
9163 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9164 Remove unused functions.
9165 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9166 (x_calc_absolute_position): Now static.
9167 (XTread_socket): Don't define label "out" unless it's used.
9168 Don't declare local "event" unless it's used.
9169 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9170 unless they are used.
9171 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9172 (x_fatal_error_signal): Remove; not used.
9173 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9174 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9175 (x_error_catcher, x_connection_closed, x_error_handler):
9176 (x_error_quitter, xembed_send_message, x_iconify_frame):
9177 (my_log_handler): Rename locals to avoid shadowing.
9178 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9179 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9180
9181 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9182 Rename or move locals to avoid shadowing.
9183 (tty_defined_color, merge_face_heights): Now static.
9184 (free_realized_faces_for_fontset): Remove; not used.
9185 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9186 does not deduce is never used uninitialized.
9187 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9188 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9189
9190 * terminal.c (store_terminal_param): Now static.
9191
9192 * xmenu.c (menu_highlight_callback): Now static.
9193 (set_frame_menubar): Remove unused local.
9194 (xmenu_show): Rename parameter to avoid shadowing.
9195 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9196 since they might point to immutable storage.
9197 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9198 since it's unused otherwise.
9199
9200 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9201 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9202 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9203 avoids a gcc -Wuninitialized diagnostic.
9204 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9205 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9206 does not deduce are never used uninitialized.
9207
9208 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9209
9210 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9211 * window.c (window_loop, size_window):
9212 (run_window_configuration_change_hook, enlarge_window): Likewise.
9213
9214 * window.c (display_buffer): Now static.
9215 (size_window): Mark variables that gcc -Wuninitialized
9216 does not deduce are never used uninitialized.
9217 * window.h (check_all_windows): New decl, to forestall
9218 gcc -Wmissing-prototypes diagnostic.
9219 * dispextern.h (bidi_dump_cached_states): Likewise.
9220
9221 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9222 shadowing.
9223 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9224 Include <limits.h>.
9225 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9226 and to avoid gcc -Wuninitialized warning.
9227 (load_charset_map): Mark variables that gcc -Wuninitialized
9228 does not deduce are never used uninitialized.
9229 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9230
9231 * coding.c (coding_set_source, coding_set_destination):
9232 Use "else { /* comment */ }" rather than "else /* comment */;"
9233 for clarity, and to avoid gcc -Wempty-body warning.
9234 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9235 a block, when the outer 'i' will do.
9236 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9237 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9238 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9239 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9240 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9241 Rename locals to avoid shadowing.
9242 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9243 * coding.c (emacs_mule_char, encode_invocation_designation):
9244 Now static, since they're not used elsewhere.
9245 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9246 (decode_coding_object, encode_coding_object, detect_coding_system):
9247 (decode_coding_emacs_mule): Mark variables that gcc
9248 -Wuninitialized does not deduce are never used uninitialized.
9249 (detect_coding_iso_2022): Initialize a local variable that might
9250 be used uninitialized. Leave a FIXME because it's not clear that
9251 this initialization is needed. (Bug#8211)
9252 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9253 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9254 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9255 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9256 Remove unused macros.
9257
9258 * category.c (hash_get_category_set): Remove unused local var.
9259 (copy_category_table): Now static, since it's not used elsewhere.
9260 * character.c (string_count_byte8): Likewise.
9261
9262 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9263 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9264
9265 * chartab.c (copy_sub_char_table): Now static, since it's not used
9266 elsewhere.
9267 (sub_char_table_ref_and_range, char_table_ref_and_range):
9268 Rename locals to avoid shadowing.
9269 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9270
9271 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9272 (BIDI_BOB): Remove unused macro.
9273
9274 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9275 deduce are never used uninitialized.
9276 * term.c (encode_terminal_code): Likewise.
9277
9278 * term.c (encode_terminal_code): Now static. Remove unused local.
9279
9280 * tparam.h: New file.
9281 * term.c, tparam.h: Include it.
9282 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9283 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9284 Move these decls to tparam.h, and make them agree with what
9285 is actually in tparam.c. The previous trick of using incompatible
9286 decls in different modules does not conform to the C standard.
9287 All callers of tparam changed to use tparam's actual API.
9288 * tparam.c (tparam1, tparam, tgoto):
9289 Use const pointers where appropriate.
9290
9291 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9292 * cm.h (struct cm): Likewise.
9293 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9294 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9295 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9296 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9297 (turn_on_face, init_tty): Likewise.
9298 * termchar.h (struct tty_display_info): Likewise.
9299
9300 * term.c (term_mouse_position): Rename local to avoid shadowing.
9301
9302 * alloc.c (mark_ttys): Move decl from here ...
9303 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9304
9305 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9306
9307 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9308
9309 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9310
9311 * search.c (compile_pattern_1): Remove argument regp, unused since
9312 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9313 (compile_pattern): Don't pass it.
9314
9315 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9316
9317 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9318 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9319 for ! HAVE_GTK3.
9320 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9321
9322 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9323
9324 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9325 gdk_window_get_screen, gdk_window_get_geometry,
9326 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9327 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9328 (xg_get_pixbuf_from_pixmap): New function.
9329 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9330 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9331 Call xg_get_pixbuf_from_pixmap instead of
9332 gdk_pixbuf_get_from_drawable.
9333 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9334 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9335 (xg_check_special_colors): Use GtkStyleContext and its functions
9336 for HAVE_GTK3.
9337 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9338 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9339 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9340 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9341 Call gtk_widget_get_preferred_size.
9342 (xg_frame_resized): gdk_window_get_geometry only takes 5
9343 parameters.
9344 (xg_win_to_widget, xg_event_is_for_menubar):
9345 Call gdk_x11_window_lookup_for_display.
9346 (xg_set_widget_bg): New function.
9347 (delete_cb): New function.
9348 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9349 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9350 (xg_set_background_color): Call xg_set_widget_bg.
9351 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9352 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9353 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9354 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9355 if ! HAVE_GTK3.
9356 (update_frame_tool_bar): Call gtk_widget_hide.
9357 (xg_initialize): Use GDK_KEY_g.
9358
9359 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9360 if ! HAVE_GTK3
9361 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9362
9363 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9364 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9365 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9366
9367 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9368
9369 * w32xfns.c (select_palette): Check success of RealizePalette against
9370 GDI_ERROR, not zero.
9371
9372 See ChangeLog.11 for earlier changes.
9373
9374 ;; Local Variables:
9375 ;; coding: utf-8
9376 ;; End:
9377
9378 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9379
9380 This file is part of GNU Emacs.
9381
9382 GNU Emacs is free software: you can redistribute it and/or modify
9383 it under the terms of the GNU General Public License as published by
9384 the Free Software Foundation, either version 3 of the License, or
9385 (at your option) any later version.
9386
9387 GNU Emacs is distributed in the hope that it will be useful,
9388 but WITHOUT ANY WARRANTY; without even the implied warranty of
9389 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9390 GNU General Public License for more details.
9391
9392 You should have received a copy of the GNU General Public License
9393 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.