1 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3 Untag more efficiently if USE_LSB_TAG.
4 This is based on a proposal by YAMAMOTO Mitsuharu in
5 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6 For an admittedly artificial (nth 8000 longlist) benchmark on
7 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8 Emacs's overall text size by 1%.
9 * lisp.h (XUNTAG): New macro.
10 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
11 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
12 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
14 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
15 * frame.h (XFRAME): Use XUNTAG.
17 Port recent dbusbind.c changes to 32-bit --with-wide-int.
18 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
19 Remove unportable assumptions about print widths of types like
21 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
22 intptr_t when converting between pointer and integer, to avoid GCC
23 warnings about wrong width.
25 2012-05-09 Eli Zaretskii <eliz@gnu.org>
27 * w32proc.c (new_child): Force Windows to reserve only 64KB of
28 stack for each reader_thread, instead of defaulting to 8MB
29 determined by the linker. This avoids failures in creating
30 subprocesses on Windows 7, see the discussion in this thread:
31 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
33 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
35 Fix up display of the *Minibuf-0* buffer in the mini window.
36 * keyboard.c (read_char): Don't clear the echo area if there's no
38 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
39 contents of *Minibuf-0*) if there's no message displayed in its stead.
41 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
43 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
46 2012-05-06 Chong Yidong <cyd@gnu.org>
48 * lisp.mk (lisp): Update.
50 2012-05-05 Jim Meyering <meyering@redhat.com>
52 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
54 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
56 * data.c (PUT_ERROR): New macro.
57 (syms_of_data): Use it. Add new error type `user-error'.
58 * undo.c (user_error): New function.
59 (Fprimitive_undo): Use it.
60 * print.c (print_error_message): Adjust print style for `user-error'.
61 * keyboard.c (user_error): New function.
62 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
64 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
66 Do not limit current-time-string to years 1000..9999.
67 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
68 (Fcurrent_time_string): Support any year that is supported by the
69 underlying localtime representation. Don't use asctime, as it
70 has undefined behavior for years outside the range -999..9999.
72 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
74 Fix race conditions involving setenv, gmtime, localtime, asctime.
75 Without this fix, interrupts could mess up code that uses these
76 nonreentrant functions, since setting TZ invalidates existing
77 tm_zone or tzname values, and since most of these functions return
78 pointers to static storage.
79 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
80 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
81 Grow the critical sections to include not just invoking
82 localtime/gmtime, but also accessing these functions' results
83 including their tm_zone values if any, and any related TZ setting.
84 (format_time_string): Last arg is now struct tm *, not struct tm **,
85 so that the struct tm is saved in the critical section.
86 All callers changed. Simplify allocation of initial buffer, partly
87 motivated by the fact that memory allocation needs to be outside
90 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
92 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
95 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
96 Remove duplicated buffer name initialization.
98 2012-05-02 Jim Meyering <jim@meyering.net>
100 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
102 * xfns.c (x_window): Use xstrdup (Bug#11375).
104 2012-05-02 Eli Zaretskii <eliz@gnu.org>
106 * xdisp.c (pos_visible_p): If already at a newline from the
107 display string before the 'while' loop, don't walk back the glyphs
108 from it3.glyph_row. Solves assertion violation when the display
109 string begins with a newline (egg.el). (Bug#11367)
111 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
113 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
116 2012-05-01 Glenn Morris <rgm@gnu.org>
118 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
119 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
120 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
121 All were removed before 23.1.
123 * dispnew.c: Remove HAVE_LIBNCURSES test;
124 it is always true on relevant platforms.
126 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
127 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
129 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
131 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
133 * .gdbinit (xpr): Remove checks for no longer existing misc types.
134 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
137 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
139 Do not avoid creating empty evaporating overlays (Bug#9642).
140 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
141 That is, do not delete an evaporating overlay if it becomes
142 empty after its bounds are adjusted to fit within its buffer.
143 This fix caused other problems, and I'm reverting it until we get
144 to the bottom of them.
146 2012-04-27 Chong Yidong <cyd@gnu.org>
148 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
150 2012-04-27 Eli Zaretskii <eliz@gnu.org>
152 * xdisp.c (pos_visible_p): If the window start position is beyond
153 ZV, start the display from buffer beginning. Prevents assertion
154 violation in init_iterator when the minibuffer window is scrolled
157 * window.c (window_scroll_pixel_based): Likewise.
159 2012-04-27 Chong Yidong <cyd@gnu.org>
161 * keymap.c (where_is_internal): Doc fix (Bug#10872).
163 2012-04-27 Glenn Morris <rgm@gnu.org>
165 * fileio.c (Fcopy_file, Fset_file_selinux_context):
166 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
168 2012-04-27 Eli Zaretskii <eliz@gnu.org>
170 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
171 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
173 2012-04-26 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
176 display element, check also the underlying string or buffer
177 character. (Bug#11341)
179 * w32menu.c: Include w32heap.h.
180 (add_menu_item): If the call to AppendMenuW (via
181 unicode_append_menu) fails, disable Unicode menus only if we are
182 running on Windows 9X/Me.
184 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
186 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
187 (xgetint): Add missing shift for LSB tags.
189 2012-04-24 Martin Rudalics <rudalics@gmx.at>
191 * keyboard.c (read_char): Don't wipe echo area for select window
192 events: These might get delayed via `mouse-autoselect-window'
195 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
197 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
198 manipulation of :loaded-from data.
200 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
202 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
203 now a cons (bug#11311).
205 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
207 Do not create empty overlays with the evaporate property (Bug#9642).
208 * buffer.c (Fmove_overlay): Delete an evaporating overlay
209 if it becomes empty after its bounds are adjusted to fit within
210 its buffer. Without this fix, in a nonempty buffer (let ((o
211 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
212 yields an empty overlay that has the evaporate property, which is
213 not supposed to happen.
215 Fix minor GTK3 problems found by static checking.
216 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
217 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
218 (struct _EmacsFixedClass, emacs_fixed_get_type):
219 Move decls here from emacsgtkfixed.h, since they needn't be public.
220 (emacs_fixed_get_type): Now static.
221 (emacs_fixed_class_init): Omit unused local.
222 (emacs_fixed_child_type): Remove; unused.
223 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
224 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
225 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
226 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
227 (EMACS_FIXED_GET_CLASS): Remove; unused.
228 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
230 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
231 Problem reported by Juanma Barranquero for Windows -Wunused-function.
233 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
235 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
236 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
237 (__malloc_size_t, __malloc_ptrdiff_t):
238 Remove. All uses removed, replaced by the definiens if needed,
239 since we can assume C89 or better now.
240 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
241 (protect_malloc_state, align, get_contiguous_space)
242 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
243 (malloc_atfork_handler_child, malloc_enable_thread)
244 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
245 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
246 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
247 (special_realloc, _realloc_internal_nolock, _realloc_internal)
248 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
249 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
250 Define using prototypes, not old style.
251 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
252 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
253 (align): Don't assume that signed integer overflow wraps around.
254 Omit unused local var.
255 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
256 (_free_internal_nolock, memalign, mallochook, reallochook):
257 Omit no-longer-needed casts.
258 (valloc): Use getpagesize, not __getpagesize.
259 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
260 (struct hdr): The 'magic' member is now size_t, not unsigned long.
262 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
264 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
266 Move functions from C to Lisp. Make non-blocking method calls
267 the default. Implement further D-Bus standard interfaces.
269 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
270 (QCdbus_request_name_allow_replacement)
271 (QCdbus_request_name_replace_existing)
272 (QCdbus_request_name_do_not_queue)
273 (QCdbus_request_name_reply_primary_owner)
274 (QCdbus_request_name_reply_in_queue)
275 (QCdbus_request_name_reply_exists)
276 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
277 (QCdbus_registered_serial, QCdbus_registered_method)
278 (QCdbus_registered_signal): New Lisp objects.
279 (XD_DEBUG_MESSAGE): Use sizeof.
280 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
281 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
282 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
283 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
284 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
285 (xd_signature, xd_append_arg): Allow float for integer types.
286 (xd_get_connection_references): New function.
287 (xd_get_connection_address): Rename from xd_initialize.
288 Return cached address.
289 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
290 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
292 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
293 Return number of refcounts.
294 (Fdbus_get_unique_name): Make stronger parameter check.
295 (Fdbus_message_internal): New defun.
296 (Fdbus_call_method, Fdbus_call_method_asynchronously)
297 (Fdbus_method_return_internal, Fdbus_method_error_internal)
298 (Fdbus_send_signal, Fdbus_register_service)
299 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
300 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
301 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
302 (Vdbus_compiled_version, Vdbus_runtime_version)
303 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
304 (Vdbus_message_type_method_return, Vdbus_message_type_error)
305 (Vdbus_message_type_signal): New defvars.
306 (Vdbus_registered_buses, Vdbus_registered_objects_table):
309 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
311 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
312 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
313 Do not assume ptrdiff_t is the same width as 'int'.
315 * alloc.c: Handle unusual debugging option combinations.
316 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
317 since the two debugging options are incompatible.
318 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
320 (mem_init, mem_insert, mem_insert_fixup):
321 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
322 (NEED_MEM_INSERT): Remove; no longer needed.
324 2012-04-22 Leo Liu <sdl.web@gmail.com>
326 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
328 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
330 * sysdep.c [__FreeBSD__]: Minor cleanups.
331 (list_system_processes, system_process_attributes) [__FreeBSD__]:
332 Use Emacs indenting style more consistently. Avoid some casts.
333 Use 'double' consistently rather than mixing 'float' and 'double'.
335 2012-04-21 Eduard Wiebe <usenet@pusto.de>
337 * sysdep.c (list_system_processes, system_process_attributes):
338 Add implementation for FreeBSD (Bug#5243).
340 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
342 * lisp.mk (lisp): Update.
344 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
346 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
347 It is never used otherwise.
349 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
351 * print.c (print_preprocess): Only check print_depth if print-circle
353 (print_object): Check for cycles even when print-circle is nil and
354 print-gensym is t, but only check print_depth if print-circle is nil.
356 2012-04-20 Chong Yidong <cyd@gnu.org>
358 * process.c (wait_reading_process_output): If EIO occurs on a pty,
359 set the status to "failed" and ensure that sentinel is run.
361 2012-04-20 Glenn Morris <rgm@gnu.org>
363 * process.c (Fset_process_inherit_coding_system_flag)
364 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
365 (Fmake_network_process, Fmake_serial_process): Doc fix.
367 2012-04-20 Eli Zaretskii <eliz@gnu.org>
369 * xdisp.c (string_buffer_position_lim): Limit starting position to
371 (set_cursor_from_row): If called for a mode-line or header-line
372 row, return zero immediately.
373 (try_cursor_movement): If inside continuation line, don't back up
374 farther than the first row after the header line, if any.
375 Don't consider the header-line row as "partially visible", even if
376 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
378 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
380 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
383 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
384 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
386 configure: new option --enable-gcc-warnings (Bug#11207)
387 * Makefile.in (C_WARNINGS_SWITCH): Remove.
388 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
389 (ALL_CFLAGS): Use new macros rather than old.
390 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
391 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
392 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
393 -Wunused-result, -Wunused-variable. This should go away once
394 the Emacs and Gnulib regex code is merged.
395 (xmalloc, xrealloc): Now static.
397 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
399 * dired.c (Fsystem_groups): Remove unused local.
401 2012-04-17 Glenn Morris <rgm@gnu.org>
403 * dired.c (Fsystem_users): Doc fix.
405 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
407 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
408 (syms_of_dired): Add them.
410 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
412 Fix minor alloc.c problems found by static checking.
413 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
414 New extern decls, to avoid calling undeclared functions.
415 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
416 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
417 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
418 (NEED_MEM_INSERT): New macro.
419 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
420 Remove one incorrect comment and fix another.
422 Fix minor ralloc.c problems found by static checking.
423 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
424 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
425 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
426 (r_alloc_sbrk): Now static.
428 Improve ralloc.c interface checking.
429 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
430 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
431 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
432 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
433 [REL_ALLOC]: ... to here, to check interface.
434 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
435 Remove decls. This fixes an "It stinks!".
437 * alloc.c (which_symbols): Fix alignment issue / type clash.
439 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
441 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
442 (struct Lisp_Misc_Any): Likewise.
443 (struct Lisp_Free): Likewise.
444 * alloc.c (union aligned_Lisp_Symbol): Define.
445 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
446 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
447 (union aligned_Lisp_Misc): Define.
448 (MARKER_BLOCK_SIZE, struct marker_block): Use union
449 aligned_Lisp_Misc instead of union Lisp_Misc.
450 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
452 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
454 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
455 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
456 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
457 * s/netbsd.h, s/sol2-6.h:
458 Remove definition of GC_MARK_STACK, since the default now works.
459 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
460 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
461 no longer the default.
462 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
464 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
466 * lread.c (lisp_file_lexically_bound_p):
467 Fix hang at ";-*-\n" (bug#11238).
469 2012-04-14 Eli Zaretskii <eliz@gnu.org>
471 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
472 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
474 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
476 * nsterm.m (constrainFrameRect): Always constrain when there is only
477 one screen (Bug#10962).
479 2012-04-13 Ken Brown <kbrown@cornell.edu>
481 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
483 2012-04-13 Reuben Thomas <rrt@sc3d.org>
485 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
487 2012-04-11 Daniel Colascione <dancol@dancol.org>
489 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
490 against is gone. It's better to use vfork now so that when Cygwin
491 gains a new, working vfork, we use it automatically (bug#10398).
493 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
495 * window.c (save_window_save): Obey window-point-insertion-type.
497 2012-04-11 Glenn Morris <rgm@gnu.org>
499 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
501 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
503 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
505 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
507 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
508 (force_quit_count): New var.
509 (handle_interrupt): Use it.
511 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
513 * w32.c (w32_delayed_load): Record the full path of the library
514 being loaded (bug#10424).
516 2012-04-09 Glenn Morris <rgm@gnu.org>
518 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
519 not just in the obarray, before snarfing them. (Bug#11036)
521 * Makefile.in ($(leimdir)/leim-list.el):
522 Pass EMACS rather than BUILT_EMACS.
524 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
526 * process.c (make_process):
527 * process.h: Add integer `gnutls_handshakes_tried' member to
530 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
531 Add convenience `GNUTLS_LOG2i' macro.
533 * gnutls.c (gnutls_log_function2i): Convenience log function.
534 (emacs_gnutls_read): Use new log functions,
535 `gnutls_handshakes_tried' process member, and
536 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
537 attempts per process (connection).
539 2012-04-09 Chong Yidong <cyd@gnu.org>
541 * eval.c (Fuser_variable_p, user_variable_p_eh)
542 (lisp_indirect_variable): Functions deleted.
543 (Fdefvar): Caller changed.
545 * callint.c (Finteractive, Fcall_interactively):
546 * minibuf.c (Fread_variable): Callers changed.
548 2012-04-09 Eli Zaretskii <eliz@gnu.org>
550 * xdisp.c (set_cursor_from_row): If the display string appears in
551 the buffer at position that is closer to point than the position
552 after the display string, display the cursor on the first glyph of
553 the display string. Fixes cursor display when a 'display' text
554 property immediately follows invisible text. (Bug#11094)
556 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
558 composite.c: use 'double' consistently
559 * composite.c (get_composition_id): Use 'double' consistently
560 instead of converting 'float' to 'double' and vice versa; this is
561 easier to understand and avoids a GCC warning.
563 2012-04-09 Glenn Morris <rgm@gnu.org>
565 * Makefile.in: Generate leim-list with bootstrap-emacs, in
566 preparation for dumping it with emacs. (Bug#4789)
567 (leimdir): New variable.
568 ($(leimdir)/leim-list.el): New rule.
569 (emacs$(EXEEXT)): Depend on leim-list.el.
571 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
572 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
573 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
575 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
577 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
580 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
582 * xml.c (init_libxml2_functions) [WINDOWSNT]:
583 Remove unused local variable.
585 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
587 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
588 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
589 (mark_memory): Mark Lisp_Objects only if pointers might hide in
590 objects, as mark_maybe_pointer will catch them otherwise.
591 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
592 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
594 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
596 Fix typo that broke non-Windows builds.
597 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
599 2012-04-07 Eli Zaretskii <eliz@gnu.org>
601 Support building on MS-Windows with libxml2.
603 * makefile.w32-in (OBJ2): Add xml.$(O).
604 (GLOBAL_SOURCES): Add xml.c.
605 ($(BLD)/xml.$(O)): New dependency list.
607 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
608 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
609 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
610 [!WINDOWSNT]: New macros.
611 (init_libxml2_functions, libxml2_loaded_p): New functions.
612 (parse_region): Call fn_xmlCheckVersion instead of using the macro
613 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
614 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
615 Calls xmlCleanupParser only if libxml2 was loaded (or statically
617 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
618 Call init_libxml2_functions before calling libxml2 functions.
619 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
621 * emacs.c: Don't include libxml/parser.h.
622 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
623 xmlCleanupParser directly.
625 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
627 2012-04-07 Eli Zaretskii <eliz@gnu.org>
629 * indent.c (Fvertical_motion): If there is a display string at
630 point, use it.vpos to compute how many lines to backtrack after
631 move_it_to point. (Bug#11133)
633 2012-04-06 Eli Zaretskii <eliz@gnu.org>
635 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
636 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
637 about subtle differences between FETCH_CHAR* and STRING_CHAR*
638 macros related to unification of CJK characters. For the details,
639 see the discussion following the message here:
640 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
642 2012-04-04 Chong Yidong <cyd@gnu.org>
644 * keyboard.c (Vdelayed_warnings_list): Doc fix.
646 2012-04-01 Eli Zaretskii <eliz@gnu.org>
648 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
649 instead of alloca. (Bug#11138)
651 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
653 * w32menu.c (is_simple_dialog): Properly check lisp types.
656 2012-03-31 Eli Zaretskii <eliz@gnu.org>
658 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
659 position we get to after a call to move_it_to fails the
660 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
661 only if we wind up in a string from display property. (Bug#11063)
663 * window.c (Fdelete_other_windows_internal): Invalidate the row
664 and column information about mouse highlight, so that redisplay
665 restores it after reallocating the glyph matrices. (Bug#7464)
667 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
668 string comes from a `display' text property, use the buffer
669 position of that property as if we actually saw that position in
671 (move_it_by_lines): Remove the assertion that
672 "it->current_x == 0 && it->hpos == 0" which can be legitimately
673 violated when there's a before-string at the beginning of a line.
676 2012-03-30 Eli Zaretskii <eliz@gnu.org>
678 * xdisp.c (append_space_for_newline): If the default face was
679 remapped, use the remapped face for the appended newline.
680 (extend_face_to_end_of_line): Use the remapped default face for
681 extending the face to the end of the line.
682 (display_line): Call extend_face_to_end_of_line when the default
683 face was remapped. (Bug#11068)
685 2012-03-29 Eli Zaretskii <eliz@gnu.org>
687 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
689 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
691 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
693 2012-03-27 Glenn Morris <rgm@gnu.org>
695 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
698 2012-03-26 Kenichi Handa <handa@m17n.org>
700 * dispextern.h (struct glyph): Fix previous change. Change the
701 bit length of glyphless.ch to 25 (Bug#11082).
703 2012-03-26 Chong Yidong <cyd@gnu.org>
705 * keyboard.c (Vselection_inhibit_update_commands): New variable.
706 (command_loop_1): Use it; inhibit selection update for
707 handle-select-window too (Bug#8996).
709 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
711 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
713 2012-03-25 Kenichi Handa <handa@m17n.org>
715 * dispextern.h (struct glyph): Change the bit length of
716 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
718 2012-03-24 Eli Zaretskii <eliz@gnu.org>
720 * s/ms-w32.h (tzname): Include time.h before redirecting to
721 _tzname. Fixes the MSVC build. (Bug#9960)
723 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
725 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
728 * xterm.c (XTread_socket): Only modify handling_signal if
729 !SYNC_INPUT. (Bug#11080)
731 2012-03-23 Eli Zaretskii <eliz@gnu.org>
733 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
734 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
735 when fetching a multibyte character consumes more bytes than
736 CHAR_BYTES returns, due to unification of CJK characters in
737 string_char. (Bug#11073)
739 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
741 * process.c (wait_reading_process_output): Handle pty disconnect
742 by refraining from sending oneself a SIGCHLD (bug#10933).
744 2012-03-22 Chong Yidong <cyd@gnu.org>
746 * dispextern.h (struct it): New member string_from_prefix_prop_p.
748 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
749 Mark string as coming from a prefix property.
750 (handle_face_prop): Use default face for prefix strings (Bug#4281).
751 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
753 2012-03-21 Chong Yidong <cyd@gnu.org>
755 * xfaces.c (Vface_remapping_alist): Doc fix.
757 2012-03-20 Eli Zaretskii <eliz@gnu.org>
759 * w32proc.c (Fw32_set_console_codepage)
760 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
763 2012-03-20 Chong Yidong <cyd@gnu.org>
765 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
766 to reflect default non-nil value of redisplay-dont-pause.
768 2012-03-19 Kenichi Handa <handa@m17n.org>
770 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
771 it fit in a valid range (Bug#11003).
773 2012-03-18 Eli Zaretskii <eliz@gnu.org>
775 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
776 that is not from display property, accept the row as a "cursor
777 row" if one of the string's character has a non-nil `cursor'
778 property. Fixes cursor positioning when there are newlines in
779 overlay strings, e.g. in icomplete.el. (Bug#11035)
781 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
783 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
785 2012-03-12 Chong Yidong <cyd@gnu.org>
787 * eval.c (inhibit_lisp_code): Rename from
788 inhibit_window_configuration_change_hook; move from window.c.
790 * xfns.c (unwind_create_frame_1, Fx_create_frame):
791 * window.c (run_window_configuration_change_hook)
792 (syms_of_window): Callers changed.
794 2012-03-11 Chong Yidong <cyd@gnu.org>
796 * keymap.c (Fkey_description): Doc fix (Bug#9700).
798 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
800 2012-03-10 Chong Yidong <cyd@gnu.org>
802 * frame.c (other_visible_frames): Don't assume the selected frame
803 is visible (Bug#10955).
805 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
807 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
809 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
811 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
812 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
815 2012-03-03 Glenn Morris <rgm@gnu.org>
817 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
819 2012-03-02 Eli Zaretskii <eliz@gnu.org>
821 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
822 position past the first glyph_row that ends at ZV. (Bug#10902)
823 (redisplay_window, next_element_from_string): Fix typos in
825 (redisplay_window): Pass to move_it_vertically the margin in
826 pixels, not in screen lines.
828 2012-03-02 Glenn Morris <rgm@gnu.org>
830 * buffer.c (buffer-list-update-hook): Doc fix.
832 2012-02-29 Eli Zaretskii <eliz@gnu.org>
834 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
835 push_it before setting up the iterator for the first overlay
836 string, even if we have an empty string loaded.
837 (next_overlay_string): If there's an empty string on the iterator
838 stack, pop the stack. (Bug#10903)
840 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
842 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
843 Suggested by Stefan Monnier in
844 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
845 * alloc.c (widen_to_Lisp_Object): New static function.
846 (mark_memory): Also mark Lisp_Objects by fetching pointer words
847 and widening them to Lisp_Objects. This would work even if
848 USE_LSB_TAG is defined and wide integers are used, which might
849 happen in a future version of Emacs.
851 2012-02-25 Chong Yidong <cyd@gnu.org>
853 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
856 * xselect.c (Fx_selection_exists_p): Doc fix.
857 (x_clipboard_manager_save_all): Print an informative message
858 before saving to clipboard manager.
860 2012-02-24 Chong Yidong <cyd@gnu.org>
862 * keyboard.c (process_special_events): Handle all X selection
863 requests in kbd_buffer, not just the next one (Bug#8869).
865 2012-02-23 Chong Yidong <cyd@gnu.org>
867 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
868 call when setting menu-bar-lines and tool-bar-lines parameters.
869 (unwind_create_frame_1): New helper function.
871 * window.c (inhibit_window_configuration_change_hook): New var.
872 (run_window_configuration_change_hook): Obey it.
873 (syms_of_window): Initialize it.
875 2012-02-22 Chong Yidong <cyd@gnu.org>
877 * xterm.c (x_draw_image_relief): Add missing type check for
878 Vtool_bar_button_margin (Bug#10743).
880 2012-02-21 Chong Yidong <cyd@gnu.org>
882 * fileio.c (Vfile_name_handler_alist): Doc fix.
884 * buffer.c (Fget_file_buffer): Protect against invalid file
885 handler return value.
887 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
889 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
890 when computing $valmask.
892 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
893 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
894 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
895 It's useless in that case, and it can cause problems on hosts
896 that allocate halves of EMACS_INT values separately.
897 Reported by Dan Horák. Diagnosed by Andreas Schwab in
898 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
899 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
900 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
901 it avoids undefined behavior on hosts where shifting right by more
902 than the word width has undefined behavior.
904 2012-02-19 Chong Yidong <cyd@gnu.org>
906 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
907 (Funhandled_file_name_directory, Ffile_name_as_directory)
908 (Fdirectory_file_name, Fexpand_file_name)
909 (Fsubstitute_in_file_name): Protect against invalid file handler
910 return values (Bug#10845).
912 2012-02-18 Eli Zaretskii <eliz@gnu.org>
914 * .gdbinit (pitx): Fix incorrect references to fields of the
917 2012-02-17 Chong Yidong <cyd@gnu.org>
919 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
921 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
923 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
924 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
926 2012-02-15 Chong Yidong <cyd@gnu.org>
928 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
929 marked as special. Also, starting docstrings with * is obsolete.
931 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
933 * gnutls.c (emacs_gnutls_write): Fix last change.
935 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
937 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
940 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
942 * keymap.c (Fsingle_key_description): Handle char ranges.
944 2012-02-12 Chong Yidong <cyd@gnu.org>
946 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
947 as that creates a dangerous corner case.
949 * window.c (Fdelete_window_internal): Invalidate the mouse
950 highlight (Bug#9904).
952 2012-02-12 Glenn Morris <rgm@gnu.org>
954 * xselect.c (Fx_own_selection_internal)
955 (Fx_get_selection_internal, Fx_disown_selection_internal)
956 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
957 * nsselect.m (Fx_own_selection_internal)
958 (Fx_disown_selection_internal, Fx_selection_exists_p)
959 (Fx_selection_owner_p, Fx_get_selection_internal):
960 Sync docs and argument specs with the xselect.c versions.
962 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
964 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
966 2012-02-11 Eli Zaretskii <eliz@gnu.org>
968 * w32select.c (Fx_selection_exists_p): Sync doc string and
969 argument list with xselect.c. (Bug#10783)
971 * w16select.c (Fx_selection_exists_p): Sync doc string and
972 argument list with xselect.c. (Bug#10783)
974 2012-02-10 Glenn Morris <rgm@gnu.org>
976 * fns.c (Fsecure_hash): Doc fix.
978 2012-02-09 Kenichi Handa <handa@m17n.org>
980 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
982 2012-02-07 Chong Yidong <cyd@gnu.org>
984 * buffer.c (Fbuffer_local_variables)
985 (buffer_lisp_local_variables): Handle unbound vars correctly;
986 don't let Qunbound leak into Lisp.
988 2012-02-07 Glenn Morris <rgm@gnu.org>
990 * image.c (Fimagemagick_types): Doc fix.
992 * image.c (imagemagick-render-type): Change it from a lisp object
993 to an integer. Move the doc here from the lisp manual.
994 Treat all values not equal to 0 the same.
996 2012-02-06 Chong Yidong <cyd@gnu.org>
998 * doc.c (store_function_docstring): Avoid applying docstring of
999 alias to base function (Bug#2603).
1001 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1003 * .gdbinit (pp1, pv1): Remove redundant defines.
1006 2012-02-04 Chong Yidong <cyd@gnu.org>
1008 * nsterm.m: Declare a global (Bug#10694).
1010 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1012 * w32.c (get_emacs_configuration_options):
1013 Include --enable-checking, if specified, in the return value.
1015 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1017 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1018 after rounding frame sizes. (Bug#9723)
1020 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1022 * keyboard.c (adjust_point_for_property): Don't position point
1023 before BEGV. (Bug#10696)
1025 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1027 Handle overflow when computing char display width (Bug#9496).
1028 * character.c (char_width): Return EMACS_INT, not int.
1029 (char_width, c_string_width): Check for overflow when
1030 computing the width; this is possible now that individual
1031 characters can have unbounded width. Problem introduced
1032 by merge from Emacs 23 on 2012-01-19.
1034 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1036 * dbusbind.c (Fdbus_register_method): Mention the return value
1037 :ignore in the docstring.
1039 2012-02-02 Glenn Morris <rgm@gnu.org>
1041 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1043 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1044 Unconditionally set to t. (Bug#10673)
1045 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1046 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1047 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1049 2012-02-02 Kenichi Handa <handa@m17n.org>
1051 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1052 0, do not call append_composite_glyph.
1054 2012-02-02 Kenichi Handa <handa@m17n.org>
1056 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1058 (x_produce_glyphs): If the component of a composition is a null
1059 string, set it->pixel_width to 1 to avoid zero-width glyph.
1061 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1063 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1064 first 2 arguments are identical. This makes inserting large
1065 output from a subprocess an order of magnitude faster on
1066 MS-Windows, where all sbrk'ed memory is always contiguous.
1068 2012-01-31 Glenn Morris <rgm@gnu.org>
1070 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1071 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1072 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1074 2012-01-29 Glenn Morris <rgm@gnu.org>
1076 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1078 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1080 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1082 2012-01-28 Chong Yidong <cyd@gnu.org>
1084 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1086 2012-01-26 Chong Yidong <cyd@gnu.org>
1088 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1090 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1091 repeat counts (Bug#10507).
1093 2012-01-26 Glenn Morris <rgm@gnu.org>
1095 * lread.c (syms_of_lread): Doc fix.
1097 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1099 * coding.c (encode_designation_at_bol): Change return value to
1102 2012-01-25 Chong Yidong <cyd@gnu.org>
1104 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1106 2012-01-21 Chong Yidong <cyd@gnu.org>
1108 * floatfns.c (Fcopysign): Make the second argument non-optional,
1109 since nil is not allowed anyway.
1111 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1113 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1114 (send_process): Likewise.
1116 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1118 * window.c (save_window_save, Fcurrent_window_configuration)
1119 (Vwindow_persistent_parameters): Do not use Qstate.
1120 Rewrite doc-strings.
1122 2012-01-19 Kenichi Handa <handa@m17n.org>
1124 * character.c (char_width): New function.
1125 (Fchar_width, c_string_width, lisp_string_width):
1126 Use char_width (Bug#9496).
1128 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1130 * window.c (Vwindow_persistent_parameters): New variable.
1131 (Fset_window_configuration, save_window_save): Handle persistent
1134 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1136 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1137 thrashing the stack of the thread. (Bug#9087)
1139 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1141 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1143 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1145 * xdisp.c (rows_from_pos_range): Handle the case where the
1146 highlight ends on a newline. (Bug#10464)
1147 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1148 he end column for display of highlight that ends on a newline
1151 2012-01-11 Glenn Morris <rgm@gnu.org>
1153 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1154 from load-path also when installation-directory is nil. (Bug#10208)
1156 2012-01-10 Glenn Morris <rgm@gnu.org>
1158 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1160 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1161 Update template values to be closer to their typical values these days.
1163 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1165 * xdisp.c (rows_from_pos_range): Accept additional argument
1166 DISP_STRING, and accept any glyph in a row whose object is that
1167 string as eligible for mouse highlight. Fixes mouse highlight of
1168 display strings from overlays. (Bug#10464)
1170 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1172 emacs: fix an auto-save permissions race condition (Bug#10400)
1173 * fileio.c (auto_saving_dir_umask): New static var.
1174 (Fmake_directory_internal): Use it.
1175 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1176 creating the directory. The old code temporarily assigns
1177 too-generous permissions to the directory.
1178 (do_auto_save_eh): Clear it.
1179 (Fdo_auto_save): Catch all errors, not just file errors, so
1180 that the var is always cleared.
1182 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1184 * search.c (scan_buffer): Pass character positions to
1185 know_region_cache, not byte positions. (Bug#6540)
1187 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1189 * w32.c (sys_rename): Report EXDEV when rename of a directory
1190 fails because the target is on another logical disk. (Bug#10284)
1192 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1194 * xterm.c (x_embed_request_focus): New function.
1196 * xterm.h: Add prototype.
1198 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1200 2012-01-05 Glenn Morris <rgm@gnu.org>
1202 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1204 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1206 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1207 Load gnutls_transport_set_lowat only if GnuTLS version is below
1209 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1210 GnuTLS versions below 2.11.1.
1212 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1214 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1215 to the doc string advising against its use for altering the way
1216 windows are scrolled.
1218 2011-12-28 Kenichi Handa <handa@m17n.org>
1220 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1221 coding-system ASCII compatible only when it does not produce BOM
1222 on encoding (Bug#10383).
1224 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1226 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1228 (create_and_show_popup_menu): Always use menu_position_func for
1231 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1233 * callint.c (Fcall_interactively): Don't truncate prompt string.
1235 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1237 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1238 property that ends at ZV, so that the bidi iteration could be
1239 resumed from there (after widening). (Bug#10360)
1241 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1243 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1245 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1247 * nsterm.m (x_free_frame_resources):
1248 Release f->output_data.ns->miniimage.
1249 (ns_index_color): Fix indentation. Do not retain
1250 color_table->colors[i].
1252 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1255 * nsfns.m (x_set_background_color): Assign return value from
1256 ns_index_color to face-background instead of NSColor*.
1257 (ns_implicitly_set_icon_type): Fix indentation.
1258 Change assignment in for loop to comparison.
1260 * emacs.c (ns_pool): New variable.
1261 (main): Assign ns_pool.
1262 (Fkill_emacs): Call ns_release_autorelease_pool.
1264 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1265 autorelease fdesc, release fdAttrs and tdict.
1266 (ns_get_covering_families): Release charset.
1267 (ns_findfonts): Release NSFontDescriptor created with new.
1268 (ns_uni_to_glyphs): Fix indentation.
1269 (setString): Release attrStr before assigning new value.
1271 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1273 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1275 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1276 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1278 2011-12-18 David Reitter <reitter@cmu.edu>
1280 * nsterm.m (ns_term_init): Subscribe for notifications
1281 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1282 to method trackingNotification in EmacsMenu.
1284 * nsmenu.m (trackingMenu): New variable.
1285 (trackingNotification): New method (from Aquamacs).
1286 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1287 from Aquamacs (Bug#7030).
1289 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1291 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1292 (symbol_to_nsstring): Fix indentation.
1293 (ns_symbol_to_pb): New function.
1294 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1295 (Fns_rotate_cut_buffers_internal): Remove.
1296 (Fns_store_selection_internal): Rename from
1297 Fns_store_cut_buffer_internal.
1298 (ns_get_foreign_selection, Fx_own_selection_internal)
1299 (Fx_disown_selection_internal, Fx_selection_exists_p)
1300 (Fns_get_selection_internal, Fns_store_selection_internal):
1301 Use ns_symbol_to_pb and check if return value is nil.
1302 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1303 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1304 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1305 renamed to Sns_store_selection_internal.
1306 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1307 and remove this function.
1308 (ns_handle_selection_clear): Remove, never used.
1309 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1312 2011-12-17 Ken Brown <kbrown@cornell.edu>
1314 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1315 GID is unknown (Bug#10257).
1317 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1319 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1320 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1321 which caused a build failure on GNU/Linux IA-64. This problem was
1322 introduced by my 2011-10-07 patch.
1324 2011-12-15 Juri Linkov <juri@jurta.org>
1326 * image.c (imagemagick_error): New function. (Bug#10112)
1327 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1328 Use `imagemagick_error' where ImageMagick functions return
1330 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1333 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1335 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1336 fill background (Bug#8992).
1338 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1340 * window.c (Vwindow_combination_resize)
1341 (Vwindow_combination_limit): Use t instead of non-nil in
1343 (Vrecenter_redisplay): Add first sentence of doc-string on
1345 (Frecenter): Fix doc-string typo.
1347 2011-12-11 Kenichi Handa <handa@m17n.org>
1349 * coding.c (Funencodable_char_position): Pay attention to the
1350 buffer text relocation (Bug#9389).
1352 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1354 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1355 gtk_init (Bug#10100).
1357 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1359 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1360 IT->string is nil. (Bug#10263)
1362 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1364 * nsterm.h (x_free_frame_resources): Declare.
1366 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1367 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1369 * nsterm.h (ns_get_defaults_value): Declare.
1371 * nsterm.m (ns_default): Call ns_get_defaults_value.
1373 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1375 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1378 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1380 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1381 that where the value of an _OBJC_* symbol points to is in the .bss
1382 section (Bug#10240).
1384 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1386 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1387 after the loop to call ccl_driver at least once (Bug#8619).
1389 2011-12-08 Kenichi Handa <handa@m17n.org>
1391 * ftfont.c (get_adstyle_property): Fix previous change
1394 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1396 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1397 dirs from the default value of EMACSLOADPATH (bug#10208).
1399 2011-12-07 Glenn Morris <rgm@gnu.org>
1401 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1402 installation and source directories as well. (Bug#10208)
1404 2011-12-06 Chong Yidong <cyd@gnu.org>
1406 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1408 2011-12-06 Glenn Morris <rgm@gnu.org>
1410 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1411 as an error, not just -1. (Bug#10217)
1413 2011-12-05 Chong Yidong <cyd@gnu.org>
1415 * keyboard.c (process_special_events): New function.
1416 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1418 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1420 * coding.c (encode_designation_at_bol): Don't use uninitialized
1421 local variable (Bug#9318).
1423 2011-12-05 Kenichi Handa <handa@m17n.org>
1425 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1426 return Qnil (Bug#8046, Bug#10193).
1428 2011-12-05 Kenichi Handa <handa@m17n.org>
1430 * coding.c (encode_designation_at_bol): New args charbuf_end and
1431 dst. Return the number of produced bytes. Callers changed.
1432 (coding_set_source): Return how many bytes coding->source was
1434 (coding_set_destination): Return how many bytes
1435 coding->destination was relocated.
1436 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1437 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1439 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1441 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1442 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1445 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1447 The following changes are to fix Bug#9318.
1449 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1450 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1451 (encode_coding_iso_2022, encode_coding_sjis)
1452 (encode_coding_big5, encode_coding_charset): Use the above macros.
1454 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1456 * lisp.h (process_quit_flag): Fix external declaration.
1458 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1460 Don't macro-inline non-performance-critical code.
1461 * eval.c (process_quit_flag): New function.
1462 * lisp.h (QUIT): Use it.
1464 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1466 * nsfns.m (get_geometry_from_preferences): New function.
1467 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1469 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1471 * emacs.c (Qkill_emacs): Define.
1472 (syms_of_emacs): Initialize it.
1473 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1474 Qquit_flag to `kill-emacs' instead.
1475 (quit_throw_to_read_char): Add parameter `from_signal'.
1476 All callers changed. Call Fkill_emacs if requested and safe.
1477 * lisp.h (QUIT): Call Fkill_emacs if requested.
1479 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1481 * widget.c (update_wm_hints): Return if wmshell is null.
1482 (widget_update_wm_size_hints): New function.
1484 * widget.h (widget_update_wm_size_hints): Declare.
1486 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1487 widget_update_wm_size_hints (Bug#10104).
1489 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1491 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1492 before a newline, prepare the bidi iterator for consuming the
1493 newline, and keep the current paragraph direction. (Bug#10183)
1494 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1496 2011-12-02 Juri Linkov <juri@jurta.org>
1498 * search.c (Fword_search_regexp): New Lisp function created from
1499 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1500 (Fword_search_backward, Fword_search_forward)
1501 (Fword_search_backward_lax, Fword_search_forward_lax):
1502 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1503 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1505 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1507 * fileio.c (Finsert_file_contents): Move after-change-function call
1508 to before the "handled:" label, since all "goto handled" appear in
1509 cases where the *-change-functions have already been properly called
1512 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1514 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1515 waiting for input. (Bug#10169)
1517 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1519 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1520 verifies glyph row's hash code--we have just reallocated the
1521 glyphs, so their contents can be complete garbage. (Bug#10164)
1523 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1525 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1527 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1529 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1530 attributes are tested _before_ calling verify_row_hash, to protect
1531 against GCC re-ordering of the tests. (Bug#10164)
1533 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1535 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1537 * xterm.c (handle_one_xevent): Only set async_visible and friends
1538 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1539 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1540 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1542 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1544 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1545 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1546 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1547 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1548 All uses changed to use GCPRO1 etc.
1549 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1550 Revert to old implementation (i.e., before 2011-03-11).
1552 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1554 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1555 of scroll runs so as to avoid assigning disabled bogus rows and
1556 unnecessary graphics copy operations.
1558 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1560 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1561 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1562 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1563 (malloc, free, realloc, calloc): Redirect to e_* only when
1566 * lisp.h (GCTYPEBITS): Move before first use.
1567 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1568 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1569 this macro definition.
1571 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1574 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1576 * gtkutil.c (xg_create_frame_widgets):
1577 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1578 present with Gtk+ 2.0.
1580 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1582 * fileio.c (Finsert_file_contents): Undo previous change; see
1583 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1585 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1587 Rename locals to avoid shadowing.
1588 * fileio.c (Finsert_file_contents):
1589 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1590 * process.c (wait_reading_process_output):
1591 Rename inner 'proc' to 'p' to avoid shadowing.
1592 Indent for consistency with usual Emacs style.
1594 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1596 * xdisp.c (redisplay_window): If cursor row is not fully visible
1597 after recentering, and scroll-conservatively is set to a large
1598 number, scroll window by a few more lines to make the cursor fully
1599 visible and out of scroll-margin. (Bug#10105)
1600 (start_display): Don't move to the next line if the display should
1601 start at a newline that is part of a display vector or an overlay
1604 2011-11-24 Juri Linkov <juri@jurta.org>
1606 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1607 after the `MagickPingImage' call. (Bug#10112)
1609 2011-11-23 Chong Yidong <cyd@gnu.org>
1611 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1613 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1615 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1616 making another buffer current. (Bug#10114)
1618 2011-11-23 Glenn Morris <rgm@gnu.org>
1620 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1622 2011-11-23 Chong Yidong <cyd@gnu.org>
1624 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1625 using it (Bug#5984).
1627 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1629 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1630 and header-lines, as they don't have one computed for them.
1633 * .gdbinit (prow): Make displayed values more self-explaining.
1634 Add row's hash code.
1636 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1638 * process.c (wait_reading_process_output): Fix asynchrounous
1639 GnuTLS socket handling on some versions of the GnuTLS library.
1640 (wait_reading_process_output): Add comment and URL.
1642 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1644 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1646 2011-11-21 Chong Yidong <cyd@gnu.org>
1648 * window.c (Fnext_window, Fprevious_window): Doc fix.
1650 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1652 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1654 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1656 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1658 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1660 * window.c (Fset_window_combination_limit): Rename argument
1662 (Vwindow_combination_limit): Remove "status" from doc-string.
1664 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1666 * m/ibms390.h: Remove.
1667 * m/ibms390x.h: Don't include "ibms390.h".
1669 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1671 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1672 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1674 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1676 * casetab.c (Fset_case_table):
1677 * charset.c (Fcharset_after): Fix typos.
1679 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1681 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1682 Otherwise, valgrind does not work on some platforms.
1683 Problem reported by Andreas Schwab in
1684 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1685 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1686 is set, removing the need for VIRT_ADDRESS_VARIES.
1687 (PURE_P): Use a more-efficient implementation that needs just one
1688 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1689 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1690 to 4 (xorl, subq, cmpq, setbe).
1691 * alloc.c (pure): Always extern now, since that's the
1692 VIRT_ADDR_VARIES behavior.
1693 (PURE_POINTER_P): Use a single comparison, not two, for
1694 consistency with the new puresize.h.
1695 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1696 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1697 Remove VIRT_ADDR_VARIES no longer needed.
1699 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1701 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1702 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1703 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1704 behave as if the cursor position were at the window margin.
1706 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1707 and the cursor position is out of bounds, behave as if the cursor
1708 position were at the window margin. (Bug#10075)
1710 2011-11-18 Chong Yidong <cyd@gnu.org>
1712 * window.c (Fwindow_combination_limit): Make first argument
1713 non-optional, since it is meaningless for live windows like the
1716 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1718 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1720 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1722 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1723 (graft_intervals_into_buffer): Simplify.
1725 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1727 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1728 hash values of the two rows.
1729 (copy_row_except_pointers): Preserve the used[] arrays and the
1730 hash values of the two rows. (Bug#10035)
1731 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1733 * xdisp.c (row_hash): New function, body extracted from
1734 compute_line_metrics.
1735 (compute_line_metrics): Call row_hash, instead of computing the
1738 * dispnew.c (verify_row_hash): Call row_hash for computing the
1739 hash code of a row, instead of duplicating code from xdisp.c.
1741 * dispextern.h (row_hash): Add prototype.
1743 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1745 * frame.c (delete_frame): Don't delete the terminal when the last
1746 X frame is closed if emacs is built with GTK toolkit.
1748 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1750 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1752 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1754 * window.c (Vwindow_splits): Rename to
1755 Vwindow_combination_resize. Suggested by Juri Linkov.
1756 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1759 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1761 * nsfns.m (Fns_font_name):
1762 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1764 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1766 * window.h (window): Rename slot "nest" to "combination_limit".
1767 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1768 (Fset_window_nest): Rename to Fset_window_combination_limit.
1769 (Vwindow_nest): Rename to Vwindow_combination_limit.
1770 (recombine_windows, make_parent_window, make_window)
1771 (Fsplit_window_internal, saved_window)
1772 (Fset_window_configuration, save_window_save): Rename all
1773 occurrences of window_nest to window_combination_limit.
1775 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1777 * image.c (imagemagick_load_image): Fix typo.
1779 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1781 * xdisp.c (display_line): Move the call to
1782 highlight_trailing_whitespace before the call to
1783 compute_line_metrics, since the latter needs to see the final
1784 faces of all the glyphs to compute ROW's hash value.
1785 Fixes assertion violations in row_equal_p. (Bug#10035)
1787 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1789 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1790 just return (bug#10044).
1792 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1794 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1795 with user-defined heap size. Bump the default size of the temacs
1796 heap to 27MB, to avoid memory warning when running temacs.
1797 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1799 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1800 current_matrix and desired_matrix. (Bug#9990)
1801 (verify_row_hash) [XASSERTS]: New function.
1802 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1803 that the hash value of glyph rows is correct.
1805 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1807 * window.h (window): Remove splits slot.
1808 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1809 (Fdelete_other_windows_internal, make_parent_window)
1810 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1811 (Fset_window_configuration, save_window_save): Don't deal with
1812 split status of windows.
1813 (saved_window): Remove splits slot.
1814 (Vwindow_splits): Rewrite doc-string.
1816 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1818 * xfns.c (unwind_create_frame):
1819 * nsfns.m (unwind_create_frame):
1820 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1821 Vframe_list (Bug#9999).
1823 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1825 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1827 2011-11-11 Kenichi Handa <handa@m17n.org>
1829 * callproc.c (Fcall_process): Set the member dst_multibyte of
1832 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1834 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1835 avoid a crash (bug#9496).
1837 2011-11-09 Chong Yidong <cyd@gnu.org>
1839 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1840 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1842 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1844 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1846 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1848 Avoid some portability problems by eschewing 'extern inline' functions.
1849 The trivial performance wins aren't worth the portability hassles; see
1850 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1852 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1853 (window_box_width, window_box_left, window_box_left_offset)
1854 (window_box_right, window_box_right_offset): Undo previous change,
1855 by removing the "extern"s.
1856 * intervals.c (adjust_intervals_for_insertion)
1857 (adjust_intervals_for_deletion): Undo previous change,
1858 making these static again.
1859 (offset_intervals, temp_set_point_both, temp_set_point)
1860 (copy_intervals_to_string): No longer inline.
1861 * xdisp.c (window_text_bottom_y, window_box_width)
1862 (window_box_height, window_box_left_offset)
1863 (window_box_right_offset, window_box_left, window_box_right)
1864 (window_box): No longer inline.
1866 2011-11-08 Chong Yidong <cyd@gnu.org>
1868 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1869 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1870 Signal an error if not a live window.
1871 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1872 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1874 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1876 * lisp.h (syms_of_abbrev): Remove declaration.
1877 Reported by CHENG Gao <chenggao@royau.me>.
1879 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1881 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1882 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1883 of temacs in GUI mode.
1885 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1887 * window.h: Declare delete_all_child_windows instead of
1888 delete_all_subwindows.
1889 * window.c (Fwindow_nest, Fset_window_nest)
1890 (Fset_window_new_total, Fset_window_new_normal)
1891 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1892 (delete_all_subwindows): Rename to delete_all_child_windows.
1893 (Fdelete_other_windows_internal, Fset_window_configuration):
1894 Call delete_all_child_windows instead of delete_all_subwindows.
1895 * frame.c (delete_frame): Call delete_all_child_windows instead
1896 of delete_all_subwindows.
1898 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1900 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1901 This is also needed for porting to any host where GC_MARK_STACK is
1902 not GC_MAKE_GCPROS_NOOPS.
1903 (which_symbols): Use it.
1905 2011-11-07 Kenichi Handa <handa@m17n.org>
1907 * coding.c (coding_set_destination): Check coding->src_pos only
1908 when coding->src_object is a buffer (bug#9910).
1910 * process.c (send_process): Set the member src_multibyte of coding
1911 to 0 (bug#9911) when sending a unibyte text.
1913 * callproc.c (Fcall_process): Set the member src_multibyte of
1914 process_coding to 0 (bug#9912).
1916 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1918 * xmenu.c (cleanup_widget_value_tree): New function.
1919 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1920 calling free_menubar_widget_value_tree directly (Bug#9830).
1922 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1924 Fix some portability problems with 'inline'.
1925 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1926 (window_box_width, window_box_left, window_box_left_offset)
1927 (window_box_right, window_box_right_offset): Declare extern.
1928 Otherwise, these inline functions do not conform to C99 and
1929 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1930 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1931 * intervals.c (adjust_intervals_for_insertion)
1932 (adjust_intervals_for_deletion): Now extern, because otherwise the
1933 extern inline functions 'offset_intervals' couldn't refer to it.
1934 (static_offset_intervals): Remove.
1935 (offset_intervals): Rewrite using the old contents of
1936 static_offset_intervals. The old version didn't conform to C99
1937 because an extern inline function contained a reference to an
1938 identifier with static linkage.
1940 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1942 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1945 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1948 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1949 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1950 return Qleft_to_right.
1952 2011-11-06 Chong Yidong <cyd@gnu.org>
1954 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1955 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1956 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1957 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1958 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1959 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1960 (Fwindow_vscroll): Doc fix.
1961 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1962 argument, since it makes no sense to pass a live window and for
1963 consistency with window-child.
1965 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1967 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1970 2011-11-05 Jason Rumney <jasonr@gnu.org>
1972 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1973 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1975 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1976 bitwise arithmetic preventing use of unicode-sip and non-truetype
1979 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1981 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1984 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1985 initialization code to keep similarity to xfns.c after changes
1988 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1990 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1991 (unwind_create_frame): New function (Bug#9943).
1992 (Fx_create_frame): Restructure code to be more similar to the one in
1993 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1994 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1995 Move terminal->reference_count++ just before making the frame official
1998 * nsterm.m (x_free_frame_resources): New function.
1999 (x_destroy_window): Move code to x_free_frame_resources.
2001 * xfns.c (unwind_create_frame): Fix comment.
2002 (Fx_create_frame, x_create_tip_frame):
2003 Move terminal->reference_count++ just before making the frame
2004 official. Move initialization of image_cache_refcount and
2005 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2007 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2009 Support MSVC build with newer versions of Visual Studio.
2010 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2011 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2014 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2015 which are not supported by MSVC.
2016 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2017 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2019 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2021 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2023 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2025 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2027 Support MSVC build with newer versions of Visual Studio.
2028 * w32.c: Don't include w32api.h for MSVC.
2029 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2031 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2032 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2033 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2034 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2036 (alloca) [_MSC_VER]: Define to _alloca.
2038 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2040 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2042 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2044 * xdisp.c (note_mouse_highlight): If either of
2045 previous/next-single-property-change returns nil, treat that as
2046 the beginning or the end of the buffer. (Bug#9955)
2048 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2050 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2051 label is not null (Bug#9951).
2052 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2055 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2057 * window.c (Fwindow_body_size): Mention in the doc string that the
2058 return value is in frame's canonical units. (Bug#9949)
2060 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2062 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2064 * w32fns.c (unwind_create_frame): If needed, free the glyph
2065 matrices of the partially constructed frame. (Bug#9943)
2066 * xfns.c (unwind_create_frame): Likewise.
2068 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2070 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2071 Don't stop backward scan on the continuation glyph, even though
2072 its CHARPOS is positive.
2073 (mouse_face_from_buffer_pos, note_mouse_highlight):
2074 Rename cover_string to disp_string.
2076 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2078 * window.c (temp_output_buffer_show): Don't use
2079 Vtemp_buffer_show_specifiers.
2080 (Vtemp_buffer_show_specifiers): Remove unused variable.
2082 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2084 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2085 past the beginning of the current glyph matrix.
2087 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2089 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2090 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2091 HAVE_GTK3 (Bug#9869).
2093 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2094 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2096 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2098 * xterm.c: Declare x_handle_net_wm_state to return int.
2099 (handle_one_xevent): Check if we are iconified but don't have
2100 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2101 (get_current_wm_state): Return non-zero if not hidden,
2102 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2103 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2104 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2105 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2107 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2109 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2110 so that this new function doesn't get optimized away by a
2111 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2113 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2115 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2117 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2119 Fix the `xbytecode' command.
2120 * .gdbinit (xprintbytestr): New command.
2121 (xwhichsymbols): Rename from `which'; all callers changed.
2122 (xbytecode): Print the byte-code string as well.
2124 2011-10-29 Kim Storm <storm@cua.dk>
2126 * alloc.c (which_symbols): New function.
2128 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2130 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2133 2011-10-29 Glenn Morris <rgm@gnu.org>
2135 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2136 Not clear what it was for, and it causes various bugs. (Bug#9839)
2138 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2140 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2141 possible random value that matches one of those tested as
2142 condition to clear the mouse face.
2144 2011-10-28 Chong Yidong <cyd@gnu.org>
2146 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2148 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2150 * window.c (make_window): Initialize phys_cursor_on_p.
2152 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2154 * lisp.h (struct Lisp_Symbol): Update comments.
2156 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2158 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2160 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2162 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2163 <oslsachem@gmail.com> for helping to debug this.
2165 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2166 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2167 (g_b_init_get_glyph_outline_w): New static variables.
2168 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2169 (GetGlyphOutlineW_Proc): New typedefs.
2170 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2171 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2173 (w32font_open_internal, compute_metrics):
2174 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2175 instead of calling the "wide" APIs directly.
2177 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2179 * w32.h (syms_of_w32font): Add prototype.
2181 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2183 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2184 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2185 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2186 (Fmove_to_window_line): Doc fix.
2188 2011-10-27 Chong Yidong <cyd@gnu.org>
2190 * process.c (make_process): Set gnutls_state to NULL.
2192 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2193 non-NULL, regardless of GNUTLS_INITSTAGE.
2194 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2195 an error. Set process slots as soon as we allocate them.
2197 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2199 2011-10-27 Chong Yidong <cyd@gnu.org>
2201 * gnutls.c (emacs_gnutls_deinit): New function.
2202 Deallocate credentials structures as well as calling gnutls_deinit.
2203 (Fgnutls_deinit, Fgnutls_boot): Use it.
2205 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2206 (deactivate_process): Call emacs_gnutls_deinit.
2208 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2210 * image.c (x_create_x_image_and_pixmap):
2211 * w32.c (sys_rename, w32_delayed_load):
2212 * w32font.c (fill_in_logfont):
2213 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2215 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2217 * w32fns.c (w32_default_color_map): New function,
2218 extracted from Fw32_default_color_map.
2219 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2221 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2223 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2225 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2227 * keyboard.c (test_undefined): New function (bug#9751).
2228 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2230 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2232 * sysdep.c (init_sys_modes): Fix the check for the controlling
2233 terminal (Bug#6649).
2235 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2237 * dispextern.h (struct bidi_it): New member next_en_type.
2239 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2240 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2241 current character, check also for next_en_type being WEAK_EN.
2242 (bidi_resolve_weak): Don't enter the expensive loop if the current
2243 position is before next_en_pos. Record the bidi type of the first
2244 non-ET, non-BN character we find, in addition to its position.
2245 (bidi_level_of_next_char): Invalidate next_en_type when
2246 next_en_pos is over-stepped.
2248 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2250 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2251 * editfns.c: Rewrite current-time-zone so that it invokes
2252 the equivalent of (format-time-string "%Z") to get the time zone name.
2253 This fixes a bug when the time zone name contains characters that
2254 need converting from the system time locale to Emacs internal format.
2255 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2256 that patch fixed format-time-string to do the conversion, but
2257 I forgot to fix current-time-zone.
2258 (format_time_string): New function, containing most of
2259 what Fformat_time_string used to contain.
2260 (Fformat_time_string): Rewrite in terms of format_time_string.
2261 This doesn't change this function's behavior.
2262 (current-time-zone): Rewrite to use format_time_string.
2263 This fixes the bug reported by Michael Schierl in
2264 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2265 Jason Rumney's 2007-06-07 change worked around this bug, but
2267 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2269 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2271 * xdisp.c (start_display): If the character at POS is displayed
2272 via a display vector, reset IT->current.dpvec_index to zero.
2273 (try_window_reusing_current_matrix): If a line ends in a display
2274 vector or the next line starts in a display vector, continue
2275 redrawing the window even though the character position of
2276 start_row was reached.
2279 2011-10-18 Chong Yidong <cyd@gnu.org>
2281 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2282 with nobreak-char-display too.
2284 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2286 Fix part 3 of bug#9771.
2287 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2288 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2289 non-neutral characters if the current character is a paragraph
2290 separator (a.k.a. Newline). This avoids running the same
2291 expensive loop twice, once when we consume the preceding newline
2292 and the other time when the line actually needs to be displayed.
2293 Avoid the loop when we see neutrals on the base embedding level
2294 following a character whose directionality is the same as the
2295 paragraph's. This avoids running the expensive loop when a line
2296 ends in a long sequence of neutrals, like control characters.
2297 Add assertion against STRONG_AL type. Slightly rearrange code
2298 that determines the type of a neutral given the first non-neutral
2300 (bidi_level_of_next_char): Set next_en_pos to zero when
2301 invalidating its info.
2303 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (push_display_prop): Determine whether to record string
2306 or buffer position by IT->string, not by IT->method. Allow
2307 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2308 (move_it_vertically_backward): Don't look for character position
2309 immediately after the newline when in a continuation line.
2312 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2314 * window.c (coordinates_in_window): Rewrite and delabelize
2315 vertical border check. (Bug#5357) (Bug#9618)
2317 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2319 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2320 errors in XSetWindowBorder (bug#9310).
2322 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2324 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2325 avoid crash when xmalloc overrun checking is enabled.
2327 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2329 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2330 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2331 cursor motion with <left> and <right> arrow keys.
2333 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2334 some callers set that themselves.
2336 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2338 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2339 display string and the previous row comes from the same string and
2340 is empty. (Bug#9739) (Bug#9738)
2342 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2344 * doc.c (get_doc_string): Encode file name (bug#9735).
2346 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2348 * bidi.c (bidi_level_of_next_char):
2349 * xdisp.c (get_visually_first_element): Remove old incorrect
2350 comments regarding the Unicode Line Separator character.
2352 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2354 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2356 * alloc.c (Fgc_status): Do not access beyond zombies array
2357 boundary if nzombies > MAX_ZOMBIES.
2358 * alloc.c (dump_zombies): Add missing format specifier.
2360 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2362 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2363 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2365 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2366 Some packages use them to denote characters with modifiers.
2368 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2370 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2371 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2372 matching a pp-number. Rename parameter var to var1.
2374 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2376 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2378 2011-10-08 Glenn Morris <rgm@gnu.org>
2380 * callint.c (Fcall_interactively): Give a more explicit error for the
2381 'c' case with a non-character input. (Bug#8479)
2383 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2385 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2387 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2388 lines that are hscrolled on the left.
2390 * dispnew.c (buffer_posn_from_coords): Account for a possible
2391 presence of header-line. (Bug#4426)
2393 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2395 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2396 Don't advertise functionality which we discourage or doesn't work.
2398 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2400 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2401 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2402 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2403 this makes Emacs dump core during garbage collection on rare
2404 occasions. sizeof is obviously inferior to offsetof here, so
2405 stick with offsetof.
2406 (GC_POINTER_ALIGNMENT): New macro.
2407 (mark_memory): Omit 3rd (offset) arg; caller changed.
2408 Don't assume EMACS_INT alignment is the same as pointer alignment.
2410 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2412 * keyboard.c (read_key_sequence_remapped): New var.
2413 (read_key_sequence): Compute remapping in the right buffer.
2414 (command_loop_1): Use read_key_sequence's remapping directly.
2416 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2418 * dired.c (file_name_completion): Don't expand file name.
2419 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2420 before checking file name handler.
2422 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2423 they've been requested explicitly (bug#9591).
2425 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2427 * keymap.c (Fsingle_key_description): Use make_specified_string
2428 instead of build_string to build string from push_key_description.
2431 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2433 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2434 This fixes a Y2038 bug on 64-bit hosts.
2435 * buffer.c (reset_buffer):
2436 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2437 (Fclear_buffer_auto_save_failure):
2438 Use 0, not -1, to represent an unset failure time, since time_t
2439 might not be signed.
2441 Remove dependency on glibc malloc internals.
2442 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2443 Move back here from lisp.h, but with their new implementations.
2444 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2445 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2446 * charset.c (charset_table_init): New static var.
2447 (syms_of_charset): Use it instead of xmalloc. This removes a
2448 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2449 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2450 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2451 Move back to alloc.c.
2452 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2453 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2455 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2457 * nsterm.m (windowDidResize): Call x_set_window_size only when
2458 ns_in_resize is true. Otherwise set pixelwidth/height and
2459 call change_frame_size (Bug#9628).
2461 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2463 Port --enable-checking=all to Fedora 14 x86-64.
2464 * charset.c (syms_of_charset): Also account for glibc malloc's
2465 internal overhead when calculating the initial malloc maximum.
2467 Port --enable-checking=all to Fedora 14 x86.
2468 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2470 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2471 (overrun_check_realloc, overrun_check_free):
2472 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2473 That way, xmalloc returns a properly-aligned pointer even if
2474 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2475 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2476 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2477 into account when calculating the initial malloc maximum.
2478 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2479 Move here from alloc.c, so that charset.c can use it too.
2480 Properly align; the old code wasn't right for common 32-bit hosts
2481 when configured with --enable-checking=all.
2482 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2483 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2485 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2487 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2490 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2492 * xdisp.c (compute_display_string_end): If there's no display
2493 string at CHARPOS, return -1.
2495 * bidi.c (bidi_fetch_char): When compute_display_string_end
2496 returns a negative value, treat the character as a normal
2497 character not covered by a display string. (Bug#9624)
2499 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2501 * lread.c (Fread_from_string): Fix typo in docstring.
2503 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2505 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2506 newline, reseat the iterator instead of bidi-iterating there one
2507 character at a time. (Bug#9610)
2508 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2509 TO_CHARPOS if the bidi iterator is at base embedding level.
2511 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2513 * lread.c (readevalloop): Use correct code for NBSP.
2514 (read1): Likewise. (Bug#9608)
2516 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2518 * dbusbind.c (Fdbus_register_signal): When service is not
2519 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2521 2011-09-25 Glenn Morris <rgm@gnu.org>
2523 * buffer.c (truncate-lines): Doc fix.
2525 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2527 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2528 (Fset_window_next_buffers): Doc fix.
2530 2011-09-24 Glenn Morris <rgm@gnu.org>
2532 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2534 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2536 Fix minor problems found by static checking.
2537 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2538 * indent.c (Fvertical_motion): Fix == vs = typo.
2540 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2542 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2543 Default value is now t. Doc fix.
2545 * indent.c (Fvertical_motion): Compute and apply the overshoot
2546 logic when moving up, not only when moving down. Fix the
2547 confusing name and values of the it_overshoot_expected variable;
2548 logic changes accordingly. (Bug#9254) (Bug#9549)
2550 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2551 CHARPOS is covered by a display string which includes newlines.
2552 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2553 is covered by a display string with embedded newlines.
2555 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2557 * dbusbind.c (Fdbus_register_signal): Add match rule to
2558 Vdbus_registered_objects_table. (Bug#9581)
2559 (Fdbus_register_method, Vdbus_registered_objects_table):
2562 2011-09-24 Jim Meyering <meyering@redhat.com>
2564 do not ignore write error for any output size
2565 The previous change was incomplete.
2566 While it makes emacs --batch detect the vast majority of stdout
2567 write failures, errors were still ignored whenever the output size is
2568 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2569 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2570 && echo FAIL: ignored write error
2571 FAIL: ignored write error
2572 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2573 && echo FAIL: ignored write error
2574 FAIL: ignored write error
2575 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2577 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2579 * emacs.c (Fkill_emacs): In noninteractive mode exit
2580 non-successfully if a write error occurred on stdout. (Bug#9574)
2582 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2584 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2587 * dispextern.h (struct it): Update the comment documenting what
2590 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2592 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2593 a display string, extend search for cursor position to end of row.
2594 (find_row_edges): If the row ends in a newline from a display
2595 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2596 Handle the case of a display string with multiple newlines.
2597 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2598 non-empty line. Fixes confusing cursor motion with arrow keys at
2599 the beginning of a line that starts with whitespace.
2601 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2603 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2606 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2608 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2611 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2613 * xdisp.c (display_line): Record maximum and minimum buffer
2614 positions even if no glyphs were produced (e.g., by a zero-width
2615 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2616 buffer positions that will be removed from the glyph row because
2618 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2619 column is beyond frame width: don't subtract 1 "pixel" when
2620 computing width of the stretch.
2621 (reseat_at_next_visible_line_start): Undo the change made on
2622 2011-09-17 that saved paragraph information and restored it after
2623 the call to `reseat'. (Bug#9545)
2625 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2627 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2628 and turn window cursor on if cleared (Bug#9415).
2630 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2632 * search.c (boyer_moore): Take unibyte characters from pattern
2633 literally. (Bug#9458)
2635 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2637 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2639 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2641 Fix minor problem found by static checking.
2642 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2643 initialized, to pacify gcc -Wuninitialized.
2645 * fileio.c: Report proper errno when syscall falls.
2646 (Finsert_file_contents): Save and restore errno,
2647 so that report_file_error outputs the correct diagnostic.
2648 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2650 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2652 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2654 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2656 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2657 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2659 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2661 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2662 about the current paragraph and restore it after the call to reseat.
2664 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2665 (bidi_find_paragraph_start): Search back for paragraph beginning
2666 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2667 (bidi_move_to_visually_next): Only trigger paragraph-related
2668 computations when the last character is a newline or at EOB, not
2669 just any NEUTRAL_B. (Bug#9470)
2671 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2672 truncated lines if point is covered by a display string. (Bug#9524)
2674 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2676 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2677 (cons_to_x_long): New function.
2678 (lisp_data_to_selection_data): Use it. Correct the test for
2679 short-versus-long data; it was negated. Break out of vector
2680 loop, for efficiency, when a long datum is discovered.
2682 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2684 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2686 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2688 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2689 GCC PR/17406) by declaring this function with external scope.
2691 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2693 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2694 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2696 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2698 * editfns.c (Fformat): Correctly handle text properties on "%%".
2700 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2702 * xterm.c (x_draw_composite_glyph_string_foreground):
2703 * w32term.c (x_draw_composite_glyph_string_foreground):
2704 * term.c (encode_terminal_code):
2705 * composite.c (composition_update_it, get_composition_id):
2706 * xdisp.c (get_next_display_element)
2707 (fill_composite_glyph_string): Add comments about special meaning
2708 of TAB characters in a composition.
2710 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2712 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2713 This occurs when processing a multibyte format.
2714 Problem reported by Wolfgang Jenker.
2716 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2718 * xdisp.c (try_cursor_movement): Only check for exact match if
2719 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2721 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2723 Remove unused external symbols.
2724 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2725 * xdisp.c (calc_pixel_width_or_height): Now static.
2726 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2727 * indent.c (check_display_width):
2728 * w32term.c: Fix comment to match code.
2729 * xterm.c, xterm.h (x_catching_errors): Remove.
2731 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2733 * xselect.c: Use signed conversions more consistently (Bug#9498).
2734 (selection_data_to_lisp_data): Assume incoming selection data are
2735 signed integers, not unsigned. This is to be consistent with
2736 outgoing selection data, which was modified to use signed integers
2737 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2738 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2739 expects long, not unsigned long.
2741 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2743 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2744 computation of loop end. Reported by Johan Bockgård
2747 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2749 * frame.c (Fother_visible_frames_p): Function deleted.
2751 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2753 * indent.c (compute_motion): Process display vector front to back
2754 rather than the other way around. (Bug#2496)
2756 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2758 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2760 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2762 * minibuf.c (Fread_from_minibuffer): Doc fix.
2764 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2766 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2767 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2769 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2771 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2772 value for non-existent files.
2774 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2776 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2777 set its "size" to -1. This will set the modtime_size field of
2778 the corresponding buffer to -1, which is what
2779 verify-visited-file-modtime expects for files that do not exist.
2782 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2784 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2786 * lisp.h: ... from here. push_key_description is no longer
2787 defined in keyboard.c, so its declaration should not be in
2788 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2789 logically belongs with push_key_description.
2791 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2793 * buffer.h: Include <sys/types.h> instead of <time.h>.
2794 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2795 Problem reported by Herbert J. Skuhra.
2797 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2799 * xml.c (parse_region): Make the parsing work for
2800 non-comment-starting XML files again (bug#9144).
2802 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2804 * image.c (gif_load): Fix calculation of bottom and right corner.
2807 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2809 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2810 redisplay in small windows.
2812 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2814 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2816 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2818 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2819 Operate on live windows only.
2821 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2823 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2825 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2827 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2828 only under bidi iteration.
2830 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2832 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2834 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2836 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2837 Without this fix, the command to link temacs failed due to an
2838 undefined symbol __builtin_isnan. This is because
2839 /usr/include/iso/math_c99.h #defines isnan(x) to
2840 __builtin_isnan(x), but the bundled gcc, which identifies itself
2841 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2843 * floatfns.c (isnan): #undef, and then #define to a clone of
2845 (Fisnan): Always define, since it's always available now.
2846 (syms_of_floatfns): Always define isnan at the Lisp level.
2848 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2850 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2852 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2854 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2855 The previous code assumed that file offsets (off_t values) fit in
2856 EMACS_INT variables, which is not true on typical 32-bit hosts.
2857 The code messed up by falsely reporting buffer overflow in cases
2858 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2859 when "big" contains more than 2**29 bytes, even though this
2860 inserts just one byte and does not overflow the buffer.
2861 (Finsert_file_contents): Store file offsets as off_t
2862 values, not as EMACS_INT values. Check for overflow when
2863 converting between EMACS_INT and off_t. When checking for
2864 buffer overflow or for overlap, take the offsets into account.
2865 Don't use EMACS_INT for small values where int suffices.
2866 When checking for overlap, fix a typo: ZV was used where
2867 ZV_BYTE was intended.
2868 (Fwrite_region): Don't assume off_t fits into 'long'.
2869 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2871 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2873 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2875 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2877 sprintf-related integer and memory overflow issues (Bug#9412).
2879 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2880 (esprintf, exprintf, evxprintf): New functions.
2881 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2882 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2883 (modify_event_symbol): Do not assume that the length of
2884 name_alist_or_stem is safe to alloca and fits in int.
2885 (Fexecute_extended_command): Likewise for function name and binding.
2886 (Frecursion_depth): Wrap around reliably on integer overflow.
2887 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2888 since some callers pass EMACS_INT values.
2889 (Fsingle_key_description): Don't crash if symbol name contains more
2890 than MAX_ALLOCA bytes.
2891 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2892 (get_minibuffer): Arg is now EMACS_INT, not int.
2893 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2894 (esprintf, exprintf, evxprintf): New decls.
2895 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2897 * dbusbind.c (signature_cat): New function.
2898 (xd_signature, Fdbus_register_signal):
2899 Do not overrun buffer; instead, report string overflow.
2901 * dispnew.c (add_window_display_history): Don't overrun buffer.
2902 Truncate instead; this is OK since it's just a log.
2904 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2905 even if the time zone offset is outlandishly large.
2906 Don't mishandle offset == INT_MIN.
2908 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2909 when creating daemon; the previous buffer-overflow check was incorrect.
2911 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2912 which has the guts of the old verror function.
2914 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2915 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2917 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2918 (font_unparse_xlfd): Don't blindly alloca long strings.
2919 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2920 fits in int, when using sprintf. Use single snprintf to count
2921 length of string rather than counting it via multiple sprintfs;
2922 that's simpler and more reliable.
2923 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2924 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2925 sprintf, in case result does not fit in int.
2927 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2928 (fontset_from_font): Print it.
2930 * frame.c (tty_frame_count): Now printmax_t, not int.
2931 (make_terminal_frame, set_term_frame_name): Print it.
2932 (x_report_frame_params): In X, window IDs are unsigned long,
2933 not signed long, so print them as unsigned.
2934 (validate_x_resource_name): Check for implausibly long names,
2935 and don't assume name length fits in 'int'.
2936 (x_get_resource_string): Don't blindly alloca invocation name;
2937 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2940 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2941 (xg_check_special_colors, xg_set_geometry):
2942 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2944 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2945 Use esprintf, not sprintf, in case result does not fit in int.
2947 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2948 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2949 it as a large positive number.
2950 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2951 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2953 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2954 in case result does not fit in int.
2956 * print.c (float_to_string): Detect width overflow more reliably.
2957 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2958 buffer overrun. Don't assume list length fits in 'int'. Treat
2959 print length of 0 as 0, not as infinity; to be consistent with other
2960 uses of print length in this function. Don't overflow print length
2961 index. Don't assume hash table size fits in 'long', or that
2962 vectorlike size fits in 'unsigned long'.
2964 * process.c (make_process): Use printmax_t, not int, to format
2965 process-name gensyms.
2967 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2969 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2970 to avoid potential buffer overrun.
2972 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2973 if X resource line is longer than 512 bytes.
2975 * xfns.c (x_window): Make sprintf buffer a bit bigger
2976 to avoid potential buffer overrun.
2978 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2980 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2982 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2984 Integer overflow fixes for scrolling, etc.
2985 Without these, Emacs silently mishandles large integers sometimes.
2986 For example, "C-u 4294967297 M-x recenter" was treated as if
2987 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2989 * xdisp.c (try_window_id): Check Emacs fixnum range before
2990 converting to 'int'.
2992 * window.c (window_scroll_line_based, Frecenter):
2993 Check that an Emacs fixnum is in range before assigning it to 'int'.
2994 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2995 values converted from Emacs fixnums.
2996 (Frecenter): Don't wrap around a line count if it is out of 'int'
2997 range; instead, treat it as an extreme value.
2998 (Fset_window_configuration, compare_window_configurations):
2999 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3001 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3002 that can exceed INT_MAX. Check that EMACS_INT value is in range
3003 before assigning it to the (possibly-narrower) index.
3004 (match_limit): Don't assume that a fixnum can fit in 'int'.
3006 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3009 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3010 (Fvertical_motion): Don't wrap around LINES values that don't fit
3011 in 'int'. Instead, treat them as extreme values. This is good
3012 enough for windows, which can't have more than INT_MAX lines anyway.
3014 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3016 * Require libxml/parser.h to avoid compilation warning.
3018 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3020 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3021 since this reportedly can destroy thread storage.
3023 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3025 * syntax.c (find_defun_start): Update all cache variables if
3026 exiting early (Bug#9401).
3028 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3030 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3032 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3033 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3034 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3036 * term.c (tty_append_glyph): New function.
3037 (produce_stretch_glyph): Static function and its prototype deleted.
3039 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3042 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3044 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3045 when checking :margin (Bug#9390).
3046 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3047 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3048 so that the name doesn't mislead. All uses changed.
3050 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3052 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3055 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3057 * xdisp.c (move_it_to): Don't bail out early when reaching
3058 position beyond to_charpos, if we are scanning backwards.
3059 (move_it_vertically_backward): When DY == 0, make sure we get to
3060 the first character in the line after the newline.
3062 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3064 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3065 (ccl_driver): Do not generate an out-of-range pointer.
3066 (Fccl_execute_on_string): Remove unnecessary check for
3067 integer overflow, noted by Stefan Monnier in
3068 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3069 Remove a FIXME that didn't need fixing.
3070 Simplify the newly-introduced buffer reallocation code.
3072 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3074 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3076 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3078 Integer and memory overflow issues (Bug#9196).
3080 * doc.c (get_doc_string): Rework so that
3081 get_doc_string_buffer_size is the actual buffer size, rather than
3082 being 1 less than the actual buffer size; this makes xpalloc more
3085 * image.c (x_allocate_bitmap_record, cache_image):
3086 * xselect.c (Fx_register_dnd_atom):
3087 Simplify previous changes by using xpalloc.
3089 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3090 since either will do and ptrdiff_t is convenient with xpalloc.
3092 * charset.c (charset_table_size)
3093 (struct charset_sort_data.priority): Now ptrdiff_t.
3094 (charset_compare): Don't overflow if priorities differ greatly.
3095 (Fsort_charsets): Don't assume list length fits in int.
3096 Check for size-calculation overflow when allocating sort data.
3097 (syms_of_charset): Allocate an initial charset table that is
3098 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3100 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3102 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3103 The actual value is always <= INT_MAX, and leaving it unsigned made
3104 overflow checking harder.
3106 * dispextern.h (struct glyph_matrix.rows_allocated)
3107 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3108 with xpalloc. The values are still always <= INT_MAX.
3110 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3112 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3113 (SAFE_NALLOCA): New macro.
3115 * region-cache.c (struct boundary.pos, find_cache_boundary)
3116 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3117 (set_cache_region, invalidate_region_cache)
3118 (revalidate_region_cache, know_region_cache, region_cache_forward)
3119 (region_cache_backward, pp_cache):
3120 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3121 so that ptrdiff_t * can be passed to xpalloc.
3122 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3123 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3124 (pp_cache): Don't assume cache_len fits in int.
3125 * region-cache.h: Adjust extern decls to match.
3127 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3128 EMACS_INT, since either will do, for xpalloc.
3130 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3131 (xnmalloc, xnrealloc, xpalloc): New functions.
3133 * bidi.c (bidi_shelve_header_size): New constant.
3134 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3135 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3137 * bidi.c (bidi_cache_shrink):
3138 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3140 Don't update size of array until after memory allocation succeeds,
3141 because xmalloc/xrealloc may not return.
3142 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3143 now that we have proper integer overflow checking.
3144 (record_overlay_string, overlay_strings): Catch overflows when
3145 calculating size of overlay_str_buf.
3147 * callproc.c (Fcall_process): Check for size overflow when
3148 calculating size of args2.
3149 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3150 Normally we prefer signed values, but sticking with ptrdiff_t would
3151 require adding more-complicated checks.
3153 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3154 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3155 Redo buffer-overflow calculations to avoid integer overflow.
3156 Add a FIXME comment where memory seems to be over-allocated.
3158 * character.c (Fstring): Check for size-calculation overflow.
3160 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3161 unnecessary integer overflow. Check for size overflow.
3162 (encode_coding_object): Don't update size until xmalloc succeeds.
3164 * composite.c (get_composition_id): Check for overflow in glyph
3165 length calculations.
3167 Integer and memory overflow fixes for display code.
3168 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3169 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3170 (scrolling_window): Check for overflow in size calculations.
3171 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3172 Don't assume glyph table len fits in int.
3173 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3174 (row_table_size): Now ptrdiff_t, not int.
3175 (scrolling_window): Avoid overflow in size calculations.
3176 Don't update size until allocation succeeds.
3177 * fns.c (concat): Check for overflow in size calculations.
3178 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3179 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3180 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3182 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3183 (get_doc_string): Check for size calculation overflow.
3184 Don't update size until allocation succeeds.
3185 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3186 EMACS_INT, where ptrdiff_t will do.
3187 (Fsubstitute_command_keys): Check for string overflow.
3189 * editfns.c (set_time_zone_rule): Don't assume environment length
3191 (message_length): Now ptrdiff_t, not int.
3192 (Fmessage_box): Don't update size until allocation succeeds.
3193 Don't assume message length fits in int.
3194 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3196 * emacs.c (main): Do not reallocate argv, since there is a null at
3197 the end that can be overwritten, and this way there's no need to
3198 worry about size-calculation overflow.
3199 (sort_args): Check for size-calculation overflow.
3201 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3203 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3205 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3206 (x_set_scroll_bar_width, x_figure_window_size):
3207 Check for integer overflow.
3208 (x_set_alpha): Do not assume XINT fits in int.
3210 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3211 This is for the members text_lines, text_cols, total_lines, total_cols,
3212 where the system imposes an 'int' limit.
3214 * fringe.c (Fdefine_fringe_bitmap):
3215 Don't update size until alloc works.
3217 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3218 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3220 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3221 Check for size-calculation overflow.
3222 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3223 do, as we prefer signed integers.
3224 (id_to_widget.max_size, id_to_widget.used)
3225 (xg_store_widget_in_map, xg_remove_widget_from_map)
3226 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3227 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3228 Use and return ptrdiff_t, not int.
3229 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3230 * gtkutil.h: Change prototypes to match the above.
3232 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3233 are duplicate now that they've been promoted to lisp.h.
3234 (x_allocate_bitmap_record, x_alloc_image_color)
3235 (make_image_cache, cache_image, xpm_load):
3236 Don't update size until alloc is done.
3237 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3239 Check for size calculation overflow.
3240 (ct_colors_allocated_max): New constant.
3241 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3244 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3245 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3246 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3247 Use ptrdiff_t, not int, to count maps.
3248 (read_char_minibuf_menu_prompt): Check for overflow in size
3249 calculations. Don't update size until allocation succeeds.
3250 Redo calculations to avoid overflow.
3251 * keyboard.h: Change prototypes to match the above.
3253 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3255 (current_minor_maps): Check for size calculation overflow.
3256 * keymap.h: Change prototypes to match the above.
3258 * lread.c (read1, init_obarray): Don't update size until alloc done.
3260 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3261 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3263 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3264 Now ptrdiff_t, not int.
3265 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3266 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3268 * process.c (Fnetwork_interface_list): Check for overflow
3269 in size calculation.
3271 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3273 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3274 overflow. Don't bother calling xmalloc when xrealloc will do.
3276 * search.c (Freplace_match): Check for size calculation overflow.
3277 (Fset_match_data): Don't assume list lengths fit in 'int'.
3279 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3280 for command line length. Do not attempt to address one before the
3281 beginning of an array, as that's not portable.
3283 * term.c (max_frame_lines): Remove; unused.
3284 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3286 (encode_terminal_code, calculate_costs): Check for size
3287 calculation overflow.
3288 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3289 table lengths and related sizes. Don't update size until alloc
3290 done. Redo calculations to avoid overflow.
3291 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3293 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3294 subtracting pointers.
3295 (gobble_line): Check for overflow more carefully. Don't update size
3298 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3299 Don't update size until alloc done.
3300 Redo size calculations to avoid overflow.
3301 Check for size calculation overflow.
3302 (main) [DEBUG]: Fix typo in invoking tparam1.
3304 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3305 Use ptrdiff_t, not int, for sizes.
3306 (store_mode_line_noprop_char): Don't update size until alloc done.
3308 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3309 Use ptrdiff_t, not int, for sizes.
3310 (Finternal_make_lisp_face, cache_face):
3311 Check for size calculation overflow.
3312 (cache_face): Treat size calculation overflows as if they were
3313 memory exhaustion (the usual treatment), rather than aborting.
3315 * xfns.c (x_encode_text, x_set_name_internal)
3316 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3317 sizes, since they can exceed INT_MAX in size. Check for size
3318 calculation overflow.
3320 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3321 (xg_select): Check for size calculation overflow.
3322 Don't update size until alloc done.
3324 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3325 as sprintf is limited to int lengths.
3327 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3328 (X_LONG_MIN): New macros.
3329 Use them to make the following changes clearer.
3330 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3331 This change doesn't affect the value now, but it may help remind
3332 future maintainers not to raise the value too much later.
3333 (SELECTION_QUANTUM): Remove, replacing with ...
3334 (selection_quantum): ... new function, which avoids overflow.
3336 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3337 assumption that selection length fits in 'int'.
3338 (x_reply_selection_request, x_handle_selection_request)
3339 (x_get_window_property, receive_incremental_selection)
3340 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3341 (lisp_data_to_selection_data, clean_local_selection_data):
3342 Use ptrdiff_t, not int, to record length of selection.
3343 (x_reply_selection_request, x_get_window_property)
3344 (receive_incremental_selection, x_property_data_to_lisp):
3345 Redo calculations to avoid overflow.
3346 (x_reply_selection_request): When sending hint, ceiling it at
3347 X_LONG_MAX rather than relying on wraparound overflow to send
3349 (x_get_window_property, receive_incremental_selection)
3350 (lisp_data_to_selection_data, x_property_data_to_lisp):
3351 Check for size-calculation overflow.
3352 (x_get_window_property, receive_incremental_selection)
3353 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3354 Don't store size until memory allocation succeeds.
3355 (x_get_window_property): Plug memory leak on memory exhaustion.
3356 Don't double-block input; malloc is safe here. Don't assume 2**34
3357 - 4 fits in unsigned long. Add an xassert to check
3358 XGetWindowProperty overflow. Be more careful about overflow
3359 calculations, and distinguish size from memory overflow better.
3360 (receive_incremental_selection): When tracing, don't assume
3361 unsigned int is less than INT_MAX.
3362 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3363 harmful) conversions of unsigned short to int.
3364 (lisp_data_to_selection_data): Don't assume that integers
3365 in the range -65535 through -1 fit in an X unsigned short.
3366 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3367 result parameters unless successful. Rely on cons_to_unsigned
3368 to report problems with elements; the old code wasn't right anyway.
3369 (x_check_property_data): Check for int overflow; we cannot use
3370 a wider type due to X limits.
3371 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3373 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3375 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3376 (x_term_init): Check for size calculation overflow.
3377 (x_color_cells): Don't store size until memory allocation succeeds.
3378 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3379 Don't assume alloca size is less than MAX_ALLOCA.
3380 (x_term_init): Don't assume length fits in int (sprintf is limited
3383 Use ptrdiff_t for composition IDs.
3384 * character.c (lisp_string_width):
3385 * composite.c (composition_table_size, n_compositions)
3386 (get_composition_id, composition_gstring_from_id):
3387 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3388 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3389 * window.c (Frecenter):
3390 Use ptrdiff_t, not int, for composition IDs.
3391 * composite.c (get_composition_id): Check for integer overflow.
3392 * composite.h: Adjust prototypes to match the above changes.
3394 Use ptrdiff_t for hash table indexes.
3395 * category.c (hash_get_category_set):
3396 * ccl.c (ccl_driver):
3397 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3398 * coding.c (coding_system_charset_list, detect_coding_system):
3399 * coding.h (struct coding_system.id):
3400 * composite.c (get_composition_id, gstring_lookup_cache):
3401 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3402 * image.c (xpm_get_color_table_h):
3403 * lisp.h (hash_lookup, hash_put):
3404 * minibuf.c (Ftest_completion):
3405 Use ptrdiff_t for hash table indexes, not int (which is too
3406 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3407 32-bit --with-wide-int hosts).
3409 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3410 Add a FIXME comment about memory leaks.
3411 (syms_of_charset): Don't assume xmalloc returns.
3413 Don't assume that stated character widths fit in int.
3414 * character.c (Fchar_width, c_string_width, lisp_string_width):
3415 * character.h (CHAR_WIDTH):
3416 * indent.c (MULTIBYTE_BYTES_WIDTH):
3417 Use sanitize_char_width to avoid undefined and/or bad behavior
3418 with outlandish widths.
3419 * character.h (sanitize_tab_width): Rename from sanitize_width,
3420 now that we have two such functions. All uses changed.
3421 (sanitize_char_width): New inline function.
3423 Don't assume that tab-width fits in int.
3424 * character.h (sanitize_width): New inline function.
3425 (SANE_TAB_WIDTH): New macro.
3426 (ASCII_CHAR_WIDTH): Use it.
3427 * indent.c (sane_tab_width): Remove. All uses replaced by
3428 SANE_TAB_WIDTH (current_buffer).
3429 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3431 * fileio.c: Integer overflow issues with file modes.
3432 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3434 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3435 Remove unreachable code.
3436 (read_hex, load_charset_map_from_file): Check for integer overflow.
3438 * xterm.c: Don't go over XClientMessageEvent limit.
3439 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3440 (x_send_scroll_bar_event): Likewise. Check that the size does not
3441 exceed limits imposed by XClientMessageEvent, as well as the usual
3442 ptrdiff_t and size_t limits.
3444 * keyboard.c: Overflow, signedness and related fixes.
3445 (make_lispy_movement): Use same integer type in forward decl
3446 that is used in the definition.
3447 (read_key_sequence, keyremap_step):
3448 Change bufsize argument back to int, undoing my 2011-03-30 change.
3449 We prefer signed types, and int is wide enough here.
3450 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3451 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3452 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3453 length, not size_t. Use ptrdiff_t for index, not int.
3454 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3455 possibility of integer overflow.
3457 Overflow, signedness and related fixes for images.
3459 * dispextern.h (struct it.stack[0].u.image.image_id)
3460 (struct_it.image_id, struct image.id, struct image_cache.size)
3461 (struct image_cache.used, struct image_cache.ref_count):
3462 * gtkutil.c (update_frame_tool_bar):
3463 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3464 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3465 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3466 * nsmenu.m (update_frame_tool_bar):
3467 * xdisp.c (calc_pixel_width_or_height):
3468 * xfns.c (image_cache_refcount):
3469 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3470 on typical 64-bit hosts.
3472 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3473 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3474 Omit unnecessary casts to int.
3475 (parse_image_spec): Check that integers fall into 'int' range
3476 when the callers expect that.
3477 (image_ascent): Redo ascent calculation to avoid int overflow.
3478 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3479 (lookup_image): Remove unnecessary tests.
3480 (xbm_image_p): Locals are now of int, not EMACS_INT,
3481 since parse_image_check makes sure they fit into int.
3482 (png_load, gif_load, svg_load_image):
3483 Prefer int to unsigned where either will do.
3484 (tiff_handler): New function, combining the cores of the
3485 old tiff_error_handler and tiff_warning_handler.
3486 This function is rewritten to use vsnprintf and thereby avoid
3487 stack buffer overflows. It uses only the features of vsnprintf
3488 that are common to both POSIX and native Microsoft.
3489 (tiff_error_handler, tiff_warning_handler): Use it.
3490 (tiff_load, gif_load, imagemagick_load_image):
3491 Don't assume :index value fits in 'int'.
3492 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3493 (imagemagick_load_image): Check that crop parameters fit into
3494 the integer types that MagickCropImage accepts. Don't assume
3495 Vimagemagick_render_type has a nonnegative value. Don't assume
3496 size_t fits in 'long'.
3497 (gs_load): Use printmax_t to print the widest integers possible.
3498 Check for integer overflow when computing image height and width.
3500 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3502 * xdisp.c (redisplay_window): Don't force window start if point
3503 will be invisible in the resulting window. (Bug#9324)
3505 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3507 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3508 the display spec is of the form `(space ...)'.
3509 (handle_display_spec): Return the value returned by
3510 handle_single_display_spec, not just 1 or zero.
3511 (handle_single_display_spec): If the display spec is of the form
3512 `(space ...)', and specifies display in the text area, return 2
3514 (try_cursor_movement): Check for the need to scroll more
3515 accurately, and prefer exact match for point under bidi.
3516 Don't advance `row' beyond the last row of the window.
3518 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3519 into disp_prop; all users changed.
3521 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3522 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3523 for the text covered by the display property.
3525 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3527 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3528 Change return value to nil.
3529 (Frecord_buffer): Delete unused function.
3531 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3533 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3534 buffers, return left-to-right.
3535 (set_cursor_from_row): Consider candidate row a win if its glyph
3536 represents a newline and point is on that newline. Fixes cursor
3537 positioning on the newline at EOL of R2L text within L2R
3538 paragraph, and vice versa.
3539 (try_cursor_movement): Check continued rows, in addition to
3540 continuation rows. Fixes unwarranted scroll when point enters a
3541 continued line of R2L text within an L2R paragraph, or vice versa.
3542 (cursor_row_p): Consider the case of point being equal to
3543 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3544 from the end of a short line to the beginning of a continued line
3545 of R2L text within L2R paragraph.
3546 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3547 composed characters.
3549 * bidi.c (bidi_check_type): Use xassert.
3550 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3553 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3555 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3558 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3560 * nsfont.m (ns_otf_to_script): Fix typo.
3562 2011-08-22 Kenichi Handa <handa@m17n.org>
3564 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3565 extra slot even if the purpose is char-code-property-table.
3567 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3569 * xdisp.c (redisplay_window): When computing centering_position,
3570 account for the height of the header line. (Bug#8874)
3572 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3573 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3574 candidate is selected by the mouse, and that candidate has a
3575 composed character under the mouse.
3577 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3578 coordinates reported by pos-visible-in-window-p for a composed
3579 character in column zero.
3581 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3583 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3585 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3587 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3588 consider it a hit if to_charpos is anywhere in the range of the
3589 composed buffer positions.
3591 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3593 * image.c (gif_load): Don't assume that each subimage has the same
3594 dimensions as the base image. Handle disposal method that is
3595 "undefined" by the gif spec (Bug#9335).
3597 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3599 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3600 (Fcondition_case): Document `debug' symbol in error handler.
3602 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3604 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3605 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3606 from an Org mode buffer to a Speedbar frame.
3608 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3609 a composition, take its buffer position from IT->cmp_it.charpos.
3610 Fixes cursor positioning at the beginning of a line that begins
3611 with a composed character.
3613 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3615 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3616 character bidirectional type, use STRONG_L instead. Fixes crashes
3617 in a buffer produced by `describe-categories'.
3619 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3620 members before the level stack, so they would be saved and
3621 restored when copying iterator state. Fixes incorrect reordering
3622 around TABs covered by display properties.
3624 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3626 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3628 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3630 * eval.c (internal_condition_case, internal_condition_case_1)
3631 (internal_condition_case_2, internal_condition_case_n):
3632 Remove unnecessary aborts (Bug#9081).
3634 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3636 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3637 has no `load' handler, try opening the file locally. (Bug#9311)
3639 2011-08-16 Ken Brown <kbrown@cornell.edu>
3641 * gmalloc.c: Expand comment.
3643 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3645 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3646 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3648 2011-08-16 Ken Brown <kbrown@cornell.edu>
3650 Fix memory allocation problems in Cygwin build (Bug#9273).
3652 * unexcw.c ( __malloc_initialized): Declare external variable.
3653 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3655 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3657 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3659 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3661 [CYGWIN] (special_realloc): New function.
3662 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3663 requests to realloc storage in the static heap.
3665 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3667 * bidi.c (bidi_initialize): Remove unused local.
3669 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3672 * biditype.h: Remove file.
3673 * makefile.w32-in ($(BLD)/bidi.$(O)):
3674 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3676 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3678 * chartab.c: Improve commentary for the uniprop_table API.
3680 * bidi.c (bidi_paragraph_init): Support zero value of
3681 bidi_ignore_explicit_marks_for_paragraph_level.
3682 (bidi_initialize): Use uniprop_table instead of including
3683 biditype.h and bidimirror.h.
3685 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3686 coordinates of the iterator when restoring from ppos_it.
3689 2011-08-14 Kenichi Handa <handa@m17n.org>
3691 * process.c (create_process): Call setup_process_coding_systems
3692 after the pid of the process is set to -1 (Bug#8162).
3694 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3696 * xdisp.c (move_it_in_display_line_to): Don't invoke
3697 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3698 ppos_it. Fixes vertical cursor motion when line beginning is
3699 covered by an image. (Bug#9296)
3701 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3703 * nsterm.h (ns_run_ascript): Declare.
3704 (NSAPP_DATA2_RUNASSCRIPT): Define.
3706 * nsfns.m (as_script, as_result, as_status): New static variables.
3707 (ns_run_ascript): New function.
3708 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3709 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3710 the event loop. Get status from as_status (Bug#7276).
3712 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3713 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3714 the event loop (Bug#7276).
3716 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3718 * gnutls.c (QCgnutls_bootprop_priority)
3719 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3720 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3721 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3722 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3723 (QCgnutls_bootprop_verify_hostname_error)
3724 (QCgnutls_bootprop_callbacks_verify): Rename from
3725 Qgnutls_bootprop_..., all uses changed.
3727 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3730 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3732 * xfaces.c (Qframe_set_background_mode): Now static.
3733 * dispextern.h (Qframe_set_background_mode): Remove decl.
3735 * process.c (Fnetwork_interface_info): Declare local only if needed.
3737 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3739 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3740 (Fnetwork_interface_list): Allocate in increments of bytes instead
3741 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3742 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3744 (struct ifflag_def): notrailers is smart on OSX.
3745 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3746 Get hardware address with getifaddrs if available.
3748 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3750 * xdisp.c (iterate_out_of_display_property): xassert that
3751 IT->position is set to within IT->object's boundaries. Break from
3752 the loop as soon as EOB is reached; avoids infloops in redisplay
3753 when IT->position is set up wrongly due to some bug.
3754 Set IT->current to match the bidi iterator unconditionally.
3755 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3756 entry. Force push_it to save on the stack the current
3757 buffer/string position, to be restored by pop_it. Fix flags in
3758 the iterator structure wrt the object coming from a display
3759 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3760 properties. (Bug#9284)
3762 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3764 * fontset.c (fontset_get_font_group): Add proper type checks.
3767 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3769 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3770 and LC_VERSION_MIN_MACOSX.
3771 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3772 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3774 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3776 * xdisp.c (forward_to_next_line_start): Allow to use the
3777 no-display-properties-and-no-overlays under bidi display.
3778 Set disp_pos in the bidi iterator to avoid searches for display
3779 properties and overlays.
3781 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3783 * editfns.c (Fset_time_zone_rule): Document relationship with the
3786 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3787 the font entity extracted from the cache (Bug#8109).
3789 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3791 * composite.c (autocmp_chars): Don't reset point. That is done by
3792 restore_point_unwind (Bug#5984).
3794 2011-08-07 Juri Linkov <juri@jurta.org>
3796 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3797 to show the arg `TIME' instead of `TIMEVAL'.
3799 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3801 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3802 display property strides EOL and includes a newline, as in
3803 longlines-mode. (Bug#9254)
3804 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3805 word-wrap under bidirectional display. (Bug#9224)
3807 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3808 is non-zero, even if the data buffer is NULL. Fixes a crash in
3809 vertical-motion with longlines-mode. (Bug#9254)
3811 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3813 * bidi.c <bidi_cache_total_alloc>: Now static.
3814 (bidi_initialize): Initialize bidi_cache_total_alloc.
3816 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3819 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3820 amount allocated this far in `bidi_cache_total_alloc'.
3821 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3822 non-zero, only free the data buffer without restoring the cache
3823 contents. All callers changed.
3825 * dispextern.h (bidi_unshelve_cache): Update prototype.
3827 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3828 (move_it_in_display_line, move_it_to)
3829 (move_it_vertically_backward, move_it_by_lines): Replace the call
3830 to xfree to an equivalent call to bidi_unshelve_cache.
3831 (move_it_in_display_line_to): Fix logic of returning
3832 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3834 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3836 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3837 came from a string character with a `cursor' property. (Bug#9229)
3839 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3841 * Makefile.in (LIB_PTHREAD): New variable.
3842 (LIBES): Add LIB_PTHREAD (Bug#9216).
3844 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3845 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3847 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3849 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3851 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3853 * xterm.c (x_find_topmost_parent): New function.
3854 (x_set_frame_alpha): Find topmost parent window with
3855 x_find_topmost_parent and set the property there also (bug#9181).
3856 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3858 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3860 * callproc.c (Fcall_process): Avoid vfork clobbering
3861 the local vars buffer, coding_systems, current_dir.
3863 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3865 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3867 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3869 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3870 so that it is not optimized away.
3872 * xdisp.c (compute_display_string_pos): Remove unused local.
3874 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3876 Fix slow cursor motion and scrolling in large buffers with
3877 selective display, like Org Mode buffers. (Bug#9218)
3879 * dispextern.h (struct bidi_it): New member disp_prop_p.
3881 * xdisp.c: Remove one-slot cache of display string positions.
3882 (compute_display_string_pos): Accept an additional argument
3883 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3884 for a display string or property. If found, set DISP_PROP_P
3887 * bidi.c (bidi_fetch_char): Accept an additional argument
3888 DISP_PROP_P, and pass it to compute_display_string_pos.
3889 Only handle text covered by a display string if DISP_PROP_P is returned
3890 non-zero. All callers of bidi_fetch_char changed.
3892 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3894 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3896 2010-12-03 Don March <don@ohspite.net>
3898 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3899 last character M-[char] is translated to ESC [char] (bug#7541).
3901 2011-08-02 Kenichi Handa <handa@m17n.org>
3903 * lisp.h (uniprop_table): Extern it.
3905 * chartab.c (uniprop_table): Make it non-static.
3907 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3909 * xdisp.c (forward_to_next_line_start): Accept additional argument
3910 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3912 (reseat_at_next_visible_line_start): Use the bidi iterator state
3913 returned by forward_to_next_line_start to restore the state of
3914 it->bidi_it after backing up to previous newline. (Bug#9212)
3916 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3918 * regex.c (re_comp): Protoize.
3919 (re_exec): Fix return type.
3920 (regexec): Fix type of `ret'. (Bug#9203)
3922 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3924 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3925 This is needed if max-image-size is a floating-point number.
3927 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3929 * print.c (print_object): Print empty symbol as ##.
3931 * lread.c (read1): Read ## as empty symbol.
3933 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3935 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3936 setting frame foreground color (Bug#9175).
3937 (x_set_background_color): Likewise.
3939 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3940 contents (Bug#9176).
3941 (EmacsTooltip -init): Remove bezels and add shadows to
3944 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3945 or scroll bar (Bug#8470).
3947 * nsfont.m (nsfont_open): Remove assignment to voffset and
3948 unnecessary vars hshink, expand, hd, full_height, min_height.
3949 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3951 * nsterm.h (nsfont_info): Remove voffset field.
3953 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3955 Implement strike-through and overline on NextStep (Bug#8863).
3957 * nsfont.m (nsfont_open): Use underline position provided by font,
3958 instead of hard-coded value of 2.
3959 (nsfont_draw): Call ns_draw_text_decoration instead.
3961 * nsterm.h: Add declaration for ns_draw_text_decoration.
3963 * nsterm.m (ns_draw_text_decoration): New function for drawing
3964 underline, overline, and strike-through.
3965 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3966 ns_draw_text_decoration. Change treatment of cursor drawing to
3967 accommodate underlining, etc.
3969 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3971 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3974 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3976 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3977 Without this fix, if a signal arrives just after memory fills up,
3978 'malloc' might be invoked reentrantly.
3980 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3981 In other words, assume that every image size is allowed, on non-X
3982 hosts. This assumption is probably wrong, but it lets Emacs compile.
3984 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3986 * regex.c (re_iswctype): Convert return values to boolean.
3988 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3990 * xdisp.c (compute_display_string_pos): Don't use cached display
3991 string position if the buffer had its restriction changed.
3994 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3996 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3998 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4000 Integer signedness and overflow and related fixes. (Bug#9079)
4002 * bidi.c: Integer size and overflow fixes.
4003 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4004 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4005 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4006 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4007 (bidi_find_other_level_edge):
4008 Use ptrdiff_t instead of EMACS_INT where either will do.
4009 This works better on 32-bit hosts configured --with-wide-int.
4010 (bidi_cache_ensure_space): Check for size-calculation overflow.
4011 Use % rather than repeated addition, for better worst-case speed.
4012 Don't set bidi_cache_size until after xrealloc returns, because it
4014 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4015 (bidi_cache_ensure_space): Also check that the bidi cache size
4016 does not exceed that of the largest Lisp string or buffer. See Eli
4017 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4019 * alloc.c (__malloc_size_t): Remove.
4020 All uses replaced by size_t. See Andreas Schwab's note
4021 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4023 * image.c: Improve checking for integer overflow.
4024 (check_image_size): Assume that f is nonnull, since
4025 it is always nonnull in practice. This is one less thing to
4026 worry about when checking for integer overflow later.
4027 (x_check_image_size): New function, which checks for integer
4028 overflow issues inside X.
4029 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4030 This removes the need for a memory_full check.
4031 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4032 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4033 (xbm_read_bitmap_data): Change locals back to 'int', since
4034 their values must fit in 'int'.
4035 (xpm_load_image, png_load, tiff_load):
4036 Invoke x_create_x_image_and_pixmap earlier,
4037 to avoid much needless work if the image is too large.
4038 (tiff_load): Treat overly large images as if
4039 x_create_x_image_and_pixmap failed, not as malloc failures.
4040 (gs_load): Use x_check_image_size.
4042 * gtkutil.c: Omit integer casts.
4043 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4044 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4046 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4048 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4049 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4050 would wrongly return t on a 64-bit host.
4052 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4053 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4054 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4055 and therefore cause GCC to emit a bogus diagnostic in some cases.
4057 * image.c: Integer signedness and overflow and related fixes.
4058 This is not an exhaustive set of fixes, but it's time to
4059 record what I've got.
4060 (lookup_pixel_color, check_image_size): Remove redundant decls.
4061 (check_image_size): Don't assume that arbitrary EMACS_INT values
4062 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4063 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4064 (tiff_load, imagemagick_load_image):
4065 Check for overflow in size calculations.
4066 (x_create_x_image_and_pixmap): Remove unnecessary test for
4067 xmalloc returning NULL; that can't happen.
4068 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4069 (xpm_color_bucket): Use better integer hashing function.
4070 (xpm_cache_color): Don't possibly over-allocate memory.
4071 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4072 (gif_memory_source):
4073 Use ptrdiff_t, not int or size_t, to record sizes.
4074 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4075 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4076 either works, as we prefer signed integers.
4077 (tiff_read_from_memory, tiff_write_from_memory):
4078 Return tsize_t, not size_t, since that's what the TIFF API wants.
4079 (tiff_read_from_memory): Don't fail simply because the read would
4080 go past EOF; instead, return a short read.
4081 (tiff_load): Omit no-longer-needed casts.
4082 (Fimagemagick_types): Don't assume size fits into 'int'.
4084 Improve hashing quality when configured --with-wide-int.
4085 * fns.c (hash_string): New function, taken from sxhash_string.
4086 Do not discard information about ASCII character case; this
4087 discarding is no longer needed.
4088 (sxhash-string): Use it. Change sig to match it. Caller changed.
4089 * lisp.h: Declare it.
4090 * lread.c (hash_string): Remove, since we now use fns.c's version.
4091 The fns.c version returns a wider integer if --with-wide-int is
4092 specified, so this should help the quality of the hashing a bit.
4094 * emacs.c: Integer overflow minor fix.
4095 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4096 Define only if GNU_LINUX.
4097 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4099 * dispnew.c: Integer signedness and overflow fixes.
4100 Remove unnecessary forward decls, that were a maintenance hassle.
4101 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4103 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4104 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4105 (prepare_desired_row, line_draw_cost):
4106 Use int, not unsigned, where either works.
4107 (save_current_matrix, restore_current_matrix):
4108 Use ptrdiff_t, not size_t, where either works.
4109 (init_display): Check for overflow more accurately, and without
4110 relying on undefined behavior.
4112 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4113 Remove, replacing with the new symbols in lisp.h. All uses changed.
4114 * fileio.c (make_temp_name):
4115 * filelock.c (lock_file_1, lock_file):
4116 * xdisp.c (message_dolog):
4117 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4118 Use pMd etc. instead.
4119 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4120 replacing the pWIDE etc. symbols removed from editfns.c.
4122 * keyboard.h (num_input_events): Now uintmax_t.
4123 This is (very slightly) less likely to mess up due to wraparound.
4126 * buffer.c: Integer signedness fixes.
4127 (alloc_buffer_text, enlarge_buffer_text):
4128 Use ptrdiff_t rather than size_t when either will do, as we prefer
4131 * alloc.c: Integer signedness and overflow fixes.
4132 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4133 (__malloc_size_t): Default to size_t, not to int.
4134 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4135 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4136 Prefer ptrdiff_t to size_t when either would do, as we prefer
4138 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4139 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4140 Now const. Initialize with values that are in range even if char
4142 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4143 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4144 These functions do the right thing with sizes > 2**32.
4145 (check_depth): Now ptrdiff_t, not int.
4146 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4147 Adjust to new way of storing sizes. Check for size overflow bugs
4149 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4150 slightly wrong anyway, as it missed one instance of
4151 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4152 (refill_memory_reserve): Omit needless cast to size_t.
4153 (mark_object_loop_halt): Mark as externally visible.
4155 * xselect.c: Integer signedness and overflow fixes.
4156 (Fx_register_dnd_atom, x_handle_dnd_message):
4157 Use ptrdiff_t, not size_t, since we prefer signed.
4158 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4159 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4160 x_dnd_atoms_size and x_dnd_atoms_length.
4162 * doprnt.c: Prefer signed to unsigned when either works.
4164 * doprnt.c (doprnt):
4166 * xdisp.c (vmessage):
4167 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4168 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4169 prefer signed arithmetic to avoid comparison confusion.
4170 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4171 but is a bit tricky.
4173 Assume freestanding C89 headers, string.h, stdlib.h.
4174 * data.c, doprnt.c, floatfns.c, print.c:
4175 Include float.h unconditionally.
4176 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4177 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4178 * regex.c: Likewise for stddef.h, string.h.
4179 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4180 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4181 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4182 (STDC_HEADERS): Remove obsolete defines.
4183 * sysdep.c: Include limits.h unconditionally.
4185 Assume support for memcmp, memcpy, memmove, memset.
4186 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4187 * regex.c (memcmp, memcpy):
4188 Remove; we assume C89 now.
4190 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4191 (__malloc_safe_bcopy): Remove; no longer needed.
4193 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4194 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4195 well either way, and we prefer signed to unsigned.
4197 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4199 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4200 closes the connection while we're reading (bug#9182).
4202 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4204 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4205 are specified (Bug#9168).
4207 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4209 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4210 Found by GCC static checking and --with-wide-int on a 32-bit host.
4212 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4214 * xdisp.c (compute_display_string_pos): Fix logic of caching
4215 previous display string position. Initialize cached_prev_pos to
4216 -1. Fixes slow-down at the beginning of a buffer.
4218 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4220 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4221 for attrs[LFACE_FONTSET_INDEX].
4223 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4225 * xml.c (parse_region): Remove unused local
4226 that was recently introduced.
4228 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4230 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4231 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4233 * xdisp.c (move_it_in_display_line_to): Record the best matching
4234 position for TO_CHARPOS while scanning the line, and restore it on
4235 exit if none of the characters scanned was an exact match.
4236 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4237 when exact match is impossible due to invisible text, and the
4238 lines are truncated.
4240 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4242 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4245 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4247 Fix a significant slow-down of cursor motion with C-n, C-p,
4248 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4249 auto-repeat under bidi redisplay in fontified buffers.
4250 * xdisp.c (compute_stop_pos_backwards): New function.
4251 (next_element_from_buffer): Call compute_stop_pos_backwards to
4252 find a suitable prev_stop when we find ourselves before
4254 (reseat): Don't look for prev_stop, as that could mean a very long
4256 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4257 <cached_disp_overlay_modiff>: Cache for last found display string
4259 (compute_display_string_pos): Return the cached position if asked
4260 about the same buffer in the same area of character positions, and
4261 the buffer wasn't changed since the time the display string
4262 position was cached.
4264 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4266 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4267 is an integer, which is important for empty lines. (Bug#9149)
4269 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4271 * frame.c (Fmodify_frame_parameters): In tty case, update the
4272 default face if necessary (Bug#4238).
4274 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4276 * editfns.c (Fstring_to_char): No need to explain what a character
4277 is in the docstring (Bug#6576).
4279 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4281 * xml.c (parse_region): Make sure we always return a tree.
4283 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4285 * xml.c (parse_region): If a document contains only comments,
4288 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4290 * xml.c (make_dom): Return comments, too.
4292 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4295 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4296 and the surrounding thread.
4297 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4298 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4299 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4301 * s/openbsd.h (BROKEN_SIGIO): Define.
4302 * unexelf.c (unexec) [__OpenBSD__]:
4303 Don't update the .mdebug section of the Alpha COFF symbol table.
4305 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4307 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4310 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4312 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4313 This fixes some race conditions on the permissions of any newly
4316 * alloc.c (valid_pointer_p): Use pipe, not open.
4317 This fixes some permissions issues when debugging.
4319 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4320 If fchown fails to set both uid and gid, try to set just gid,
4321 as that is sometimes allowed. Adjust the file's mode to eliminate
4322 setuid or setgid bits that are inappropriate if fchown fails.
4324 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4326 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4327 to compare Lisp_Objects.
4328 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4329 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4330 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4332 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4334 * lread.c (read_integer): Unread even EOF character.
4335 (read1): Likewise. Properly record start position of symbol.
4337 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4338 symbol character follows.
4340 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4342 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4343 This works around a problem with the previous change to Fcopy_file.
4344 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4345 and without this change, GCC might complain about discarding
4346 fchown's return value.
4348 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4350 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4352 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4354 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4356 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4358 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4359 it's used from the C level.
4361 * process.c: Use the same condition for POLL_FOR_INPUT in both
4362 keyboard.c and process.c (bug#1858).
4364 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4366 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4367 (Fgnutls_boot): Use it.
4369 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4371 * doc.c (Fsubstitute_command_keys): Revert last change.
4373 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4375 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4376 quotes the next character, and doesn't affect other longer
4377 sequences (bug#8935).
4379 * lread.c (syms_of_lread): Clarify that is isn't only
4380 `eval-buffer' and `eval-defun' that's affected by
4381 `lexical-binding' (bug#8460).
4383 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4385 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4386 bidi redisplay when a line includes both an image and is truncated.
4388 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4390 Fix minor problems found by static checking.
4391 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4392 (elsz): Now a signed constant, not a size_t var. We prefer signed
4393 types to unsigned, to avoid integer comparison confusion. Without
4394 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4395 "cannot optimize loop, the loop counter may overflow", a symptom
4397 * indent.c (Fvertical_motion): Mark locals as initialized.
4398 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4400 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4402 * search.c (Fre_search_backward): Mention `case-fold-search' in
4403 all the re_search_* functions (bug#8138).
4405 * keyboard.c (Fopen_dribble_file): Document when the file is
4408 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4410 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4413 Support bidi reordering of display and overlay strings.
4414 * xdisp.c (compute_display_string_pos)
4415 (compute_display_string_end): Accept additional argument STRING.
4416 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4417 (reseat_to_string): Initialize bidi_it->string.s and
4418 bidi_it->string.schars.
4419 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4420 NULL (avoids a crash in bidi_paragraph_init).
4421 Initialize itb.string.lstring.
4422 (init_iterator): Call bidi_init_it only of a valid
4423 buffer position was specified. Initialize paragraph_embedding to
4425 (reseat_to_string): Initialize the bidi iterator.
4426 (display_string): If we need to ignore text properties of
4427 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4428 original value of -1 will not work with bidi.)
4429 (compute_display_string_pos): First arg is now struct
4430 `text_pos *'; all callers changed. Support display properties on
4432 (compute_display_string_end): Support display properties on Lisp
4434 (init_iterator, reseat_1, reseat_to_string): Initialize the
4435 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4436 when iterating on a string not from display properties).
4437 (compute_display_string_pos, compute_display_string_end):
4438 Fix calculation of the object to scan. Fixes an error when using
4440 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4441 base_level_stop; instead, set base_level_stop to BEGV.
4442 Fixes crashes in vertical-motion.
4443 (next_element_from_buffer): Improve commentary for when
4444 the iterator is before prev_stop.
4445 (init_iterator): Initialize bidi_p from the default value of
4446 bidi-display-reordering, not from buffer-local value. Use the
4447 buffer-local value only if initializing for buffer iteration.
4448 (handle_invisible_prop): Support invisible properties on strings
4449 that are being bidi-reordered.
4450 (set_iterator_to_next): Support bidi reordering of C strings and
4452 (next_element_from_string): Support bidi reordering of Lisp
4454 (handle_stop_backwards): Support Lisp strings as well.
4455 (display_string): Support display of R2L glyph rows.
4456 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4457 (init_iterator): Don't initialize it->bidi_p for strings
4459 (reseat_to_string): Initialize it->bidi_p for strings here.
4460 (next_element_from_string, next_element_from_c_string)
4461 (next_element_from_buffer): Add xassert's for correspondence
4462 between IT's object being iterated and it->bidi_it.string
4464 (face_before_or_after_it_pos): Support bidi iteration.
4465 (next_element_from_c_string): Handle the case of the first string
4466 character that is not the first one in the visual order.
4467 (get_visually_first_element): New function, refactored from common
4468 parts of next_element_from_buffer, next_element_from_string, and
4469 next_element_from_c_string.
4470 (tool_bar_lines_needed, redisplay_tool_bar)
4471 (display_menu_bar): Force left-to-right direction. Add a FIXME
4472 comment for making that be controlled by a user option.
4473 (push_it, pop_it): Save and restore the state of the
4474 bidi iterator. Save and restore the bidi_p flag.
4475 (pop_it): Iterate out of display property for string iteration as
4477 (iterate_out_of_display_property): Support iteration over strings.
4478 (handle_single_display_spec): Set up it->bidi_it for iteration
4479 over a display string, and call bidi_init_it.
4480 (handle_single_display_spec, next_overlay_string)
4481 (get_overlay_strings_1, push_display_prop): Set up the bidi
4482 iterator for displaying display or overlay strings.
4483 (forward_to_next_line_start): Don't use the shortcut if
4485 (back_to_previous_visible_line_start): If handle_display_prop
4486 pushed the iterator stack, restore the internal state of the bidi
4487 iterator by calling bidi_pop_it same number of times.
4488 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4489 and we are bidi-iterating, don't decrement the iterator position;
4490 instead, set the first_elt flag in the bidi iterator, to produce
4492 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4493 (push_display_prop): xassert that we are iterating a buffer.
4494 (push_it, pop_it): Save and restore paragraph_embedding member.
4495 (handle_single_display_spec, next_overlay_string)
4496 (get_overlay_strings_1, reseat_1, reseat_to_string)
4497 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4498 correctly. Don't assume unibyte strings are not bidi-reordered.
4499 (compute_display_string_pos)
4500 (compute_display_string_end): Fix handling the case of C string.
4501 (push_it, pop_it): Save and restore from_disp_prop_p.
4502 (handle_single_display_spec, push_display_prop): Set the
4503 from_disp_prop_p flag.
4504 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4505 (pop_it): Call iterate_out_of_display_property only if we are
4506 popping after iteration over a string that came from a display
4507 property. Fix a typo in popping stretch info. Add an assertion
4508 for verifying that the iterator position is in sync with the bidi
4510 (handle_single_display_spec, get_overlay_strings_1)
4511 (push_display_prop): Fix initialization of paragraph direction for
4512 string when that of the parent object is not yet determined.
4513 (reseat_1): Call bidi_init_it to resync the bidi
4514 iterator with IT's position. (Bug#7616)
4515 (find_row_edges): If ROW->start.pos gives position
4516 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4517 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4518 Reset the from_disp_prop_p flag.
4519 (SAVE_IT, RESTORE_IT): New macros.
4520 (pos_visible_p, face_before_or_after_it_pos)
4521 (back_to_previous_visible_line_start)
4522 (move_it_in_display_line_to, move_it_in_display_line)
4523 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4524 (try_scrolling, redisplay_window, display_line): Use them when
4525 saving a temporary copy of the iterator and restoring it back.
4526 (back_to_previous_visible_line_start, reseat_1)
4527 (init_iterator): Empty the bidi cache "stack".
4528 (move_it_in_display_line_to): If iterator ended up at
4529 EOL, but we never saw any buffer positions smaller than
4530 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4531 motion in bidi-reordered lines.
4532 (move_it_in_display_line_to): Record prev_method and prev_pos
4533 immediately before the call to set_iterator_to_next. Fixes cursor
4534 motion in bidi-reordered lines with stretch glyphs and strings
4535 displayed in margins. (Bug#8133) (Bug#8867)
4536 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4538 (pos_visible_p): Support positions in bidi-reordered lines.
4539 Save and restore bidi cache.
4541 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4542 (bidi_paragraph_info): Delete unused struct.
4543 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4544 (bidi_cache_start): New variable.
4545 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4547 (bidi_cache_fetch_state, bidi_cache_search)
4548 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4549 (bidi_cache_find, bidi_peek_at_next_level)
4550 (bidi_level_of_next_char, bidi_find_other_level_edge)
4551 (bidi_move_to_visually_next): Compare cache index with
4552 bidi_cache_start rather than with zero.
4553 (bidi_fetch_char): Accept new argument STRING; all callers
4554 changed. Support iteration over a string. Support strings with
4555 display properties. Support unibyte strings. Fix the type of
4556 `len' according to what STRING_CHAR_AND_LENGTH expects.
4557 (bidi_paragraph_init, bidi_resolve_explicit_1)
4558 (bidi_resolve_explicit, bidi_resolve_weak)
4559 (bidi_level_of_next_char, bidi_move_to_visually_next):
4560 Support iteration over a string.
4561 (bidi_set_sor_type, bidi_resolve_explicit_1)
4562 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4563 can now be zero (for strings); special values 0 and -1 were
4564 changed to -1 and -2, respectively.
4565 (bidi_char_at_pos): New function.
4566 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4567 Call it instead of FETCH_MULTIBYTE_CHAR.
4568 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4569 initialized to valid values.
4570 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4572 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4573 the test for valid cached positions. Fix the logic for looking up
4574 the sentinel state in the cache. GCPRO the Lisp string we are
4576 (bidi_push_it, bidi_pop_it): New functions.
4577 (bidi_initialize): Initialize the bidi cache start stack pointer.
4578 (bidi_cache_ensure_space): New function, refactored from part of
4579 bidi_cache_iterator_state. Don't assume the required size is just
4580 one BIDI_CACHE_CHUNK away.
4581 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4582 (bidi_count_bytes, bidi_char_at_pos): New functions.
4583 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4584 always valid if bidi_cache_idx is valid.
4585 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4586 is valid if it's going to be used.
4587 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4588 (bidi_cache_fetch_state, bidi_cache_search)
4589 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4590 (bidi_cache_iterator_state, bidi_cache_find)
4591 (bidi_find_other_level_edge, bidi_cache_start_stack):
4592 All variables related to cache indices are now EMACS_INT.
4594 * dispextern.h (struct bidi_string_data): New structure.
4595 (struct bidi_it): New member `string'. Make flag members be 1-bit
4596 fields, and put them last in the struct.
4597 (compute_display_string_pos, compute_display_string_end):
4599 (bidi_push_it, bidi_pop_it): Add prototypes.
4600 (struct iterator_stack_entry): New members bidi_p,
4601 paragraph_embedding, and from_disp_prop_p.
4602 (struct it): Member bidi_p is now a bit field 1 bit wide.
4603 (bidi_shelve_cache, bidi_unshelve_cache):
4606 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4607 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4608 and vector-like objects.
4610 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4611 cache around display iteration.
4613 * window.c (Fwindow_end, window_scroll_pixel_based)
4614 (displayed_window_lines, Frecenter): Save and restore the bidi
4615 cache around display iteration.
4617 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4619 * editfns.c (Fdelete_region): Clarify the use of the named
4620 parameters (bug#6788).
4622 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4624 * indent.c (Fvertical_motion): Set and restore w->pointm when
4625 saving and restoring the window's buffer (Bug#9006).
4627 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4629 * editfns.c (Fstring_to_char): Clarify just what is returned
4630 (bug#6576). Text by Eli Zaretskii.
4632 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4634 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4636 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4638 * buffer.c (mmap_find): Fix a typo.
4640 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4642 Fix execution of x selection hooks.
4643 * xselect.c (Qx_lost_selection_functions)
4644 (Qx_sent_selection_functions): New vars.
4645 (syms_of_xselect): DEFSYM them.
4646 (x_handle_selection_request): Pass Qx_sent_selection_functions
4647 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4648 (x_handle_selection_clear,x_clear_frame_selections):
4649 Pass Qx_lost_selection_functions rather than
4650 Vx_lost_selection_functions to Frun_hook_with_args.
4652 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4654 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4655 The old code sometimes used this field without initializing it.
4657 * alloc.c (gc_sweep): Don't read past end of array.
4658 In theory, the old code could also have corrupted Emacs internals,
4659 though it'd be very unlikely.
4661 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4663 * character.c (Fcharacterp): Don't advertise optional ignored
4664 argument. (Bug#4026)
4666 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4668 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4671 * window.c (Fset_window_start): Doc fix (bug#4199).
4672 (Fset_window_hscroll): Ditto.
4674 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4676 Fix minor new problems caught by GCC 4.6.1.
4677 * term.c (init_tty): Remove unused local.
4678 * xsettings.c (store_monospaced_changed): Define this function only
4679 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4682 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4684 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4686 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4688 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4689 are the mini-buffer and the echo area (bug#3320).
4691 * term.c (init_tty): Remove support for supdup, c10 and perq
4692 terminals, which are no longer supported (bug#1482).
4694 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4696 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4698 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4700 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4701 for non-popups (Bug#3642).
4703 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4705 * alloc.c (reset_malloc_hooks): Protoize.
4706 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4707 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4708 * cm.c (losecursor): Likewise.
4709 * data.c (fmod): Likewise.
4710 * dispnew.c (swap_glyphs_in_rows): Likewise.
4711 * emacs.c (memory_warning_signal): Likewise.
4712 * floatfns.c (float_error): Likewise.
4713 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4714 (otf_open, font_otf_capability, generate_otf_features)
4715 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4717 * image.c (pbm_read_file): Likewise.
4718 * indent.c (string_display_width): Likewise.
4719 * intervals.c (check_for_interval, search_for_interval)
4720 (inc_interval_count, count_intervals, root_interval)
4721 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4722 * lread.c (defalias): Likewise.
4723 * ralloc.c (r_alloc_check): Likewise.
4724 * regex.c (set_image_of_range_1, set_image_of_range)
4725 (regex_grow_registers): Likewise.
4726 * sysdep.c (strerror): Likewise.
4727 * termcap.c (valid_filename_p, tprint, main): Likewise.
4728 * tparam.c (main): Likewise.
4729 * unexhp9k800.c (run_time_remap, save_data_space)
4730 (update_file_ptrs, read_header, write_header, calculate_checksum)
4731 (copy_file, copy_rest, display_header): Likewise.
4732 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4734 * xdisp.c (check_it): Likewise.
4735 * xfaces.c (register_color, unregister_color, unregister_colors):
4737 * xfns.c (print_fontset_result): Likewise.
4738 * xrdb.c (member, fatal, main): Likewise.
4740 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4742 Fix minor problems found by static checking (Bug#9031).
4743 * chartab.c (char_table_set_range, map_sub_char_table):
4744 Remove unused locals.
4745 (uniprop_table): Now static.
4746 * composite.c (_work_char): Remove unused static var.
4748 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4750 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4752 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4754 * gtkutil.c (qttip_cb): Remove code without function.
4756 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4758 * w32.c (pthread_sigmask): New stub.
4760 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4762 Use pthread_sigmask, not sigprocmask (Bug#9010).
4763 sigprocmask is portable only for single-threaded applications, and
4764 Emacs can be multi-threaded when it uses GTK.
4765 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4767 * callproc.c (Fcall_process):
4768 * process.c (create_process):
4769 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4770 Use pthread_sigmask, not sigprocmask.
4772 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4774 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4775 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4778 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4780 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4781 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4782 (xg_hide_tooltip): Fix comment.
4784 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4785 in registerServicesMenuSendTypes.
4786 (validRequestorForSendType): Don't check ns_return_types.
4788 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4791 2011-07-08 Jason Rumney <jasonr@gnu.org>
4793 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4794 SH_SHOW for hidden windows (Bug#5482).
4796 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4797 frame struct members of non-existent frames (Bug#6284).
4799 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4801 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4802 variable firstTime not needed on OSX >= 10.6.
4803 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4804 >= 10.5. Use setKnobProportion, setDoubleValue.
4806 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4807 (MAC_OS_X_VERSION_10_5): Define if not defined.
4808 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4809 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4810 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4812 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4813 cString and lossyCString on OSX >= 10.4
4815 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4816 sizeToFit on OSX >= 10.2.
4818 * nsimage.m (allocInitFromFile): Don't use deprecated method
4819 bestRepresentationForDevice on OSX >= 10.6.
4821 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4824 * emacs.c: Declare unexec_init_emacs_zone.
4826 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4828 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4830 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4831 on svcsMenu (Bug#8842).
4833 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4835 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4837 * nsterm.m (QUTF8_STRING): Declare.
4838 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4839 (validRequestorForSendType): Return type is (id).
4840 Change indexOfObjectIdenticalTo to indexOfObject.
4841 Check if we have local selection before returning self (Bug#8842).
4842 (writeSelectionToPasteboard): Put local selection into paste board
4843 if we have a local selection (Bug#8842).
4844 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4846 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4847 (ns_get_local_selection): Declare.
4849 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4851 * keymap.c (describe_map_tree): Don't insert a double newline at
4852 the end of the buffer (bug#1169) and return whether we inserted
4855 * callint.c (Fcall_interactively): Change "reading args" to
4856 "providing args" to try to clarify what it does (bug#1010).
4858 2011-07-07 Kenichi Handa <handa@m17n.org>
4860 * composite.c (composition_compute_stop_pos): Ignore a static
4861 composition starting before CHARPOS (Bug#8915).
4863 * xdisp.c (handle_composition_prop): Likewise.
4865 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4867 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4870 2011-07-07 Kenichi Handa <handa@m17n.org>
4872 * character.h (unicode_category_t): New enum type.
4874 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4875 (Qchar_code_property_table): New variable.
4876 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4877 (UNIPROP_COMPRESSED_FORM_P): New macros.
4878 (char_table_ascii): Uncompress the compressed values.
4879 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4880 Uncompress the compressed values.
4881 (sub_char_table_ref_and_range): Likewise.
4882 (char_table_ref_and_range): Uncompress the compressed values.
4883 (sub_char_table_set): New arg is_uniprop. Callers changed.
4884 Uncompress the compressed values.
4885 (sub_char_table_set_range): Args changed. Callers changed.
4886 (char_table_set_range): Adjuted for the above change.
4887 (map_sub_char_table): Delete args default_val and parent. Add arg
4888 top. Give decoded values to a Lisp function.
4889 (map_char_table): Adjust for the above change. Give decoded
4890 values to a Lisp function. Gcpro more variables.
4891 (uniprop_table_uncompress)
4892 (uniprop_decode_value_run_length): New functions.
4893 (uniprop_decoder, uniprop_decoder_count): New variables.
4894 (uniprop_get_decoder, uniprop_encode_value_character)
4895 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4897 (uniprop_encoder, uniprop_encoder_count): New variables.
4898 (uniprop_get_encoder, uniprop_table)
4899 (Funicode_property_table_internal, Fget_unicode_property_internal)
4900 (Fput_unicode_property_internal): New functions.
4901 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4902 Sunicode_property_table_internal, Sget_unicode_property_internal,
4903 and Sput_unicode_property_internal. Defvar_lisp
4904 char-code-property-alist.
4906 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4907 Vunicode_category_table.
4909 * font.c (font_range): Adjust for the change of
4910 Vunicode_category_table.
4912 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4914 * m/iris4d.h: Remove file, move contents ...
4915 * s/irix6-5.h: ... here.
4917 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4919 Remove unportable assumption about struct layout (Bug#8884).
4920 * alloc.c (mark_buffer):
4921 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4922 (clone_per_buffer_values): Don't assume that
4923 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4924 This isn't true in general, and it's particularly not true
4925 if Emacs is configured with --with-wide-int.
4926 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4927 New macros, used in the buffer.c change.
4929 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4931 * xsettings.c: Use both GConf and GSettings if both are available.
4932 (store_config_changed_event): Add comment.
4933 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4934 (store_tool_bar_style_changed): New functions.
4935 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4936 (struct xsettings): Move font inside HAVE_XFT.
4937 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4938 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4939 Move inside HAVE_XFT.
4940 (something_changed_gsettingsCB): Rename from something_changedCB.
4941 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4943 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4944 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4945 (something_changed_gconfCB): Rename from something_changedCB.
4946 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4947 (parse_settings): Move check for font inside HAVE_XFT.
4948 (read_settings, apply_xft_settings): Add comment.
4949 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4950 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4951 call store_font_name_changed.
4952 (xft_settings_event): Add comment.
4953 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4954 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4955 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4956 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4957 (xsettings_initialize): Call init_gsettings last.
4958 (xsettings_get_system_font, xsettings_get_system_normal_font):
4961 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4963 Random fixes. E.g., (random) never returned negative values.
4964 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4965 subseconds part to the entropy, as that's a bit more random.
4966 Prefer signed to unsigned, since the signedness doesn't matter and
4967 in general we prefer signed. When given a limit, use a
4968 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4969 latter isn't right if USE_2_TAGS_FOR_INTS.
4970 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4971 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4973 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4975 * textprop.c (text_property_stickiness):
4976 Obey Vtext_property_default_nonsticky.
4977 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4978 * w32fns.c (syms_of_w32fns):
4979 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4981 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4983 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4984 This is more efficient than Ffile_directory_p and avoids a minor race.
4986 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4988 * buffer.c (Foverlay_put): Say what the return value is
4991 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4992 is a directory before asking whether to use the file name
4994 (barf_or_query_if_file_exists): Make the "File is a directory"
4995 error be more correct.
4997 * fns.c (Frequire): Remove the mention of the .gz files, since
4998 that's installation-specific, but keep the mention of
4999 `get-load-suffixes'.
5001 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5003 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5004 Report string overflow if the output is too long.
5006 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5008 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5009 (syms_of_gnutls): Remove duplicate DEFSYM for
5010 Qgnutls_bootprop_verify_hostname_error, an error for
5011 Qgnutls_bootprop_verify_error (which is no longer used).
5013 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5014 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5015 Also (re)move comments that are misplaced or no longer relevant.
5017 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5019 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5021 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5023 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5024 and background color parameters if they have been changed.
5026 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5028 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5030 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5032 * xsettings.c (SYSTEM_FONT): Define only when used.
5033 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5035 * keymap.c (access_keymap_1): Now static.
5037 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5039 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5040 leave any prefix arg for the up event (Bug#1586).
5042 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5044 * lread.c (syms_of_lread): Mention single symbols defined by
5045 `defvar' or `defconst' (bug#7154).
5047 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5048 (Frequire): Mention get-load-suffixes.
5050 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5052 * window.h (window): Remove clone_number slot.
5053 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5055 (make_parent_window, make_window, saved_window)
5056 (Fset_window_configuration, save_window_save): Don't deal with
5058 * buffer.c (Qclone_number): Remove declaration.
5059 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5061 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5063 Add multiple inheritance to keymaps.
5064 * keymap.c (Fmake_composed_keymap): New function.
5065 (Fset_keymap_parent): Simplify.
5066 (fix_submap_inheritance): Remove.
5067 (access_keymap_1): New function extracted from access_keymap to handle
5068 embedded parents and handle lists of maps.
5069 (access_keymap): Use it.
5070 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5071 (Fcopy_keymap): Handle embedded parents.
5072 (Fcommand_remapping, define_as_prefix): Simplify.
5073 (Fkey_binding): Simplify.
5074 (syms_of_keymap): Move minibuffer-local-completion-map,
5075 minibuffer-local-filename-completion-map,
5076 minibuffer-local-must-match-map, and
5077 minibuffer-local-filename-must-match-map to Elisp.
5078 (syms_of_keymap): Defsubr make-composed-keymap.
5079 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5080 (parse_menu_item): Trivial simplification.
5082 2011-07-01 Glenn Morris <rgm@gnu.org>
5084 * Makefile.in (SETTINGS_LIBS): Fix typo.
5086 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5088 * coding.c (Fencode_coding_string): Record the last coding system
5089 used, as the function doc string says (bug#8738).
5091 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5093 * xsettings.c (store_monospaced_changed): Take new font as arg and
5094 check for change against current_mono_font.
5095 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5096 (emacs_settings_constructor, emacs_settings_get_property)
5097 (emacs_settings_set_property, emacs_settings_class_init)
5098 (emacs_settings_init, gsettings_obj): Remove.
5099 (something_changedCB): New function for HAVE_GSETTINGS.
5100 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5101 with value as argument.
5102 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5103 g_settings_new (Bug#8967). Do not create gsettings_obj.
5104 Remove calls to g_settings_bind. Connect something_changedCB to
5107 * xgselect.c: Add defined (HAVE_GSETTINGS).
5108 (xgselect_initialize): Ditto.
5110 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5111 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5114 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5116 * eval.c (struct backtrace): Simplify and port the data structure.
5117 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5118 signed bit field, as this assumption is not portable and it makes
5119 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5120 "char debug_on_exit : 1" as this is not portable either; instead,
5121 use the portable "unsigned int debug_on_exit : 1". Remove unused
5122 member evalargs. Remove obsolete comments about cc bombing out.
5124 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5126 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5127 Let HAVE_GSETTINGS override HAVE_GCONF.
5128 (store_monospaced_changed): New function.
5129 (EMACS_SETTINGS): A new type derived from GObject to handle
5130 GSettings notifications.
5131 (emacs_settings_constructor, emacs_settings_get_property)
5132 (emacs_settings_set_property, emacs_settings_class_init):
5134 (gsettings_client, gsettings_obj): New variables.
5135 (GSETTINGS_SCHEMA): New define.
5136 (something_changedCB): Call store_monospaced_changed.
5137 (init_gsettings): New function.
5138 (xsettings_initialize): Call init_gsettings.
5139 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5142 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5145 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5147 * window.c (resize_root_window, grow_mini_window)
5148 (shrink_mini_window): Rename Qresize_root_window to
5149 Qwindow_resize_root_window and Qresize_root_window_vertically to
5150 Qwindow_resize_root_window_vertically.
5152 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5154 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5156 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5158 * makefile.w32-in: Redesign dependencies so they reflect more
5159 clearly which files are directly included by each source file,
5160 and not through other includes.
5162 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5164 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5165 (sort_overlays, overlay_strings): When an overlay's clone number
5166 matches the window's clone number process the overlay even if
5167 the overlay's window property doesn't match the current window.
5169 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5170 (Fwindow_hchild): Rename to Fwindow_left_child.
5171 (Fwindow_next): Rename to Fwindow_next_sibling.
5172 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5173 (resize_window_check): Rename to window_resize_check.
5174 (resize_window_apply): Rename to window_resize_apply.
5175 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5176 (Fdelete_other_windows_internal, resize_frame_windows)
5177 (Fsplit_window_internal, Fdelete_window_internal)
5178 (grow_mini_window, shrink_mini_window)
5179 (Fresize_mini_window_internal): Fix callers accordingly.
5181 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5183 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5184 (emacs_fixed_set_min_size): Remove.
5185 (emacs_fixed_new): Take frame as argument.
5187 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5188 (_EmacsFixedPrivate): Remove minwidth/height.
5189 Add struct frame *f.
5190 (emacs_fixed_init): Initialize priv->f.
5191 (get_parent_class, emacs_fixed_set_min_size): Remove.
5192 (emacs_fixed_new): Set priv->f to argument.
5193 (emacs_fixed_get_preferred_width)
5194 (emacs_fixed_get_preferred_height): Use min_width/height from
5195 frames size_hint to set minimum and natural (Bug#8919).
5196 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5197 and use min_width/height from frames size_hint to set
5198 min_width/height (Bug#8919).
5200 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5201 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5204 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5206 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5207 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5210 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5212 * process.c (wait_reading_process_output): Bypass select if
5213 waiting for a cell while ignoring keyboard input, and input is
5214 pending. Suggested by Jan Djärv (Bug#8869).
5216 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5218 Use gnulib's dup2 module instead of rolling our own.
5219 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5221 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5223 * dispnew.c (scrolling_window): Before scrolling, turn off a
5224 mouse-highlight in the window being scrolled.
5226 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5228 Move DEFSYM to lisp.h and use everywhere.
5230 * character.h (DEFSYM): Move declaration...
5231 * lisp.h (DEFSYM): ...here.
5237 * w32select.c: Don't include character.h.
5239 * alloc.c (syms_of_alloc):
5240 * buffer.c (syms_of_buffer):
5241 * bytecode.c (syms_of_bytecode):
5242 * callint.c (syms_of_callint):
5243 * casefiddle.c (syms_of_casefiddle):
5244 * casetab.c (init_casetab_once):
5245 * category.c (init_category_once, syms_of_category):
5246 * ccl.c (syms_of_ccl):
5247 * cmds.c (syms_of_cmds):
5248 * composite.c (syms_of_composite):
5249 * dbusbind.c (syms_of_dbusbind):
5250 * dired.c (syms_of_dired):
5251 * dispnew.c (syms_of_display):
5252 * doc.c (syms_of_doc):
5253 * editfns.c (syms_of_editfns):
5254 * emacs.c (syms_of_emacs):
5255 * eval.c (syms_of_eval):
5256 * fileio.c (syms_of_fileio):
5257 * fns.c (syms_of_fns):
5258 * frame.c (syms_of_frame):
5259 * fringe.c (syms_of_fringe):
5260 * insdel.c (syms_of_insdel):
5261 * keymap.c (syms_of_keymap):
5262 * lread.c (init_obarray, syms_of_lread):
5263 * macros.c (syms_of_macros):
5264 * msdos.c (syms_of_msdos):
5265 * print.c (syms_of_print):
5266 * process.c (syms_of_process):
5267 * search.c (syms_of_search):
5268 * sound.c (syms_of_sound):
5269 * syntax.c (init_syntax_once, syms_of_syntax):
5270 * terminal.c (syms_of_terminal):
5271 * textprop.c (syms_of_textprop):
5272 * undo.c (syms_of_undo):
5273 * w32.c (globals_of_w32):
5274 * window.c (syms_of_window):
5275 * xdisp.c (syms_of_xdisp):
5276 * xfaces.c (syms_of_xfaces):
5277 * xfns.c (syms_of_xfns):
5278 * xmenu.c (syms_of_xmenu):
5279 * xsettings.c (syms_of_xsettings):
5280 * xterm.c (syms_of_xterm): Use DEFSYM.
5282 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5284 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5286 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5288 Integer and buffer overflow fixes (Bug#8873).
5290 * print.c (printchar, strout): Check for string overflow.
5291 (PRINTPREPARE, printchar, strout):
5292 Don't set size unless allocation succeeds.
5294 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5295 for sizes. Check for string overflow more accurately.
5296 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5298 * macros.c: Integer and buffer overflow fixes.
5299 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5300 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5301 Use ptrdiff_t, not int, for sizes.
5302 Don't increment bufsize until after realloc succeeds.
5303 Check for size-calculation overflow.
5304 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5306 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5308 * lread.c: Integer overflow fixes.
5309 (read_integer): Radix is now EMACS_INT, not int,
5310 to improve quality of diagnostics for out-of-range radices.
5311 Calculate buffer size correctly for out-of-range radices.
5312 (read1): Check for integer overflow in radices, and in
5313 read-circle numbers.
5314 (read_escape): Avoid int overflow.
5315 (Fload, openp, read_buffer_size, read1)
5316 (substitute_object_recurse, read_vector, read_list, map_obarray):
5317 Use ptrdiff_t, not int, for sizes.
5318 (read1): Use EMACS_INT, not int, for sizes.
5319 Check for size overflow.
5321 * image.c (cache_image): Check for size arithmetic overflow.
5323 * lread.c: Integer overflow issues.
5324 (saved_doc_string_size, saved_doc_string_length)
5325 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5326 Now ptrdiff_t, not int.
5327 (read1): Don't assume doc string length fits in int. Check for
5328 out-of-range doc string lengths.
5329 (read_list): Don't assume file position fits in int.
5330 (read_escape): Check for hex character overflow.
5332 2011-06-22 Leo Liu <sdl.web@gmail.com>
5334 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5335 Move to minibuffer.el.
5337 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5339 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5340 The following patches are for when GLYPH_DEBUG && !XASSERT.
5341 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5342 * dispnew.c (flush_stdout):
5343 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5344 Mark as externally visible.
5345 * dispnew.c (check_window_matrix_pointers): Now static.
5346 * dispnew.c (window_to_frame_vpos):
5347 * xfns.c (unwind_create_frame):
5348 * xterm.c (x_check_font): Remove unused local.
5349 * scroll.c (CHECK_BOUNDS):
5350 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5351 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5352 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5353 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5354 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5356 (debug_method_add): Use va_list and vsprintf rather than relying
5357 on undefined behavior with wrong number of arguments.
5358 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5359 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5360 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5361 since we're not interested in debugging glyphs with old libraries.
5362 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5363 GCC 4.6.0's static checking.
5365 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5367 Integer overflow and signedness fixes (Bug#8873).
5368 A few related buffer overrun fixes, too.
5370 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5372 * dispextern.h (struct face.stipple):
5373 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5374 (x_bitmap_mask, x_allocate_bitmap_record)
5375 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5376 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5377 (x_create_bitmap_from_xpm_data):
5378 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5379 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5381 * xfaces.c (load_pixmap):
5382 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5383 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5384 (.bitmaps_last, struct x_output.icon_bitmap):
5385 Use ptrdiff_t, not int, for bitmap indexes.
5386 (x_allocate_bitmap_record): Check for size overflow.
5387 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5389 Use ptrdiff_t, not int, for overlay counts.
5390 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5391 * editfns.c (overlays_around, get_pos_property):
5392 * textprop.c (get_char_property_and_overlay):
5393 * xdisp.c (next_overlay_change, note_mouse_highlight):
5394 * xfaces.c (face_at_buffer_position):
5395 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5396 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5397 (Fnext_overlay_change, Fprevious_overlay_change)
5398 (mouse_face_overlay_overlaps, Foverlays_in):
5399 Use ptrdiff_t, not int, for sizes.
5400 (overlays_at, overlays_in): Check for size-calculation overflow.
5402 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5404 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5405 (x_session_initialize): Do not assume string length fits in int.
5407 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5408 This is unlikely, but can occur if DPI is outlandish.
5410 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5411 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5413 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5414 * xrdb.c (magic_file_p, search_magic_path):
5415 Omit last arg SUFFIX; it was always 0. All callers changed.
5416 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5418 * xfont.c (xfont_match): Avoid need for strlen.
5420 * xfns.c: Don't assume strlen fits in int.
5421 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5423 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5424 not unsigned long, as we prefer signed integers. All callers changed.
5425 Detect integer overflow in repeat count.
5426 (message_dolog): Don't assume print length fits in 39 bytes.
5427 (display_mode_element): Don't assume strlen fits in int.
5429 * termcap.c: Don't assume sizes fit in int and never overflow.
5430 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5431 (gobble_line): Check for size-calculation overflow.
5433 * minibuf.c (Fread_buffer):
5434 * lread.c (intern, intern_c_string):
5435 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5436 Don't assume string length fits in int.
5438 * keyboard.c (parse_tool_bar_item):
5439 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5441 * font.c: Don't assume string length fits in int.
5442 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5443 Use ptrdiff_t, not int.
5444 (font_intern_prop): Don't assume string length fits in int.
5445 Don't assume integer property fits in fixnum.
5446 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5448 * filelock.c: Fix some buffer overrun and integer overflow issues.
5449 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5450 Reformulate so as not to need the command string.
5451 Invoke gzip -cd rather than gunzip, as it's more portable.
5452 (lock_info_type, lock_file_1, lock_file):
5453 Don't assume pid_t and time_t fit in unsigned long.
5454 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5455 (current_lock_owner): Prefer signed type for sizes.
5456 Use memcpy, not strncpy, where memcpy is what is really wanted.
5457 Don't assume (via atoi) that time_t and pid_t fit in int.
5458 Check for time_t and/or pid_t out of range, e.g., via a network share.
5459 Don't alloca where an auto var works fine.
5461 * fileio.c: Fix some integer overflow issues.
5462 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5463 Don't assume string length fits in int.
5464 (directory_file_name): Don't assume string length fits in long.
5465 (make_temp_name): Don't assume pid fits in int, or that its print
5466 length is less than 20.
5468 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5470 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5472 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5474 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5475 We prefer signed integers, even for size calculations.
5477 * emacs.c: Don't assume string length fits in 'int'.
5478 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5479 (main): Don't invoke strlen when not needed.
5481 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5482 (XD_DEBUG_MESSAGE): Don't waste a byte.
5484 * callproc.c (getenv_internal_1, getenv_internal)
5486 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5488 * lread.c (invalid_syntax): Omit length argument.
5489 All uses changed. This doesn't fix a bug, but it simplifies the
5490 code away from its former Hollerith-constant appearance, and it's
5491 one less 'int' to worry about when looking at integer-overflow issues.
5492 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5494 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5495 This didn't break anything, but it didn't help either.
5496 It's confusing to put a bogus integer in a place where the actual
5497 value does not matter.
5498 (LIST_END_P): Remove unused macro and its bogus comment.
5499 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5501 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5502 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5504 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5505 We prefer signed types, and the value cannot exceed the EMACS_INT
5506 range anyway (because otherwise the length would not be representable).
5507 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5508 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5509 This avoids a GCC warning when WIDE_EMACS_INT.
5511 * indent.c (sane_tab_width): New function.
5512 (current_column, scan_for_column, Findent_to, position_indentation)
5513 (compute_motion): Use it. This is just for clarity.
5514 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5516 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5518 * lisp.h (lint_assume): New macro.
5519 * composite.c (composition_gstring_put_cache):
5520 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5522 * editfns.c, insdel.c:
5523 Omit unnecessary forward decls, to simplify future changes.
5525 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5527 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5529 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5530 Use much-faster test for byte-length change.
5531 Don't assume string byte-length fits in 'int'.
5532 Check that character arg fits in 'int'.
5533 (mapcar1): Declare byte as byte, for clarity.
5535 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5537 * fns.c (concat): Catch string overflow earlier.
5538 Do not rely on integer wraparound.
5540 * dispextern.h (struct it.overlay_strings_charpos)
5541 (struct it.selective): Now EMACS_INT, not int.
5542 * xdisp.c (forward_to_next_line_start)
5543 (back_to_previous_visible_line_start)
5544 (reseat_at_next_visible_line_start, next_element_from_buffer):
5545 Don't arbitrarily truncate the value of 'selective' to int.
5547 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5549 * composite.c: Don't truncate sizes to 'int'.
5550 (composition_gstring_p, composition_reseat_it)
5551 (composition_adjust_point): Use EMACS_INT, not int.
5552 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5553 not EMACS_UINT, for indexes.
5555 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5557 * buffer.c: Include <verify.h>.
5558 (struct sortvec.priority, struct sortstr.priority):
5559 Now EMACS_INT, not int.
5560 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5561 (struct sortstr.size, record_overlay_string)
5562 (struct sortstrlist.size, struct sortlist.used):
5563 Don't truncate size to int.
5564 (record_overlay_string): Check for size-calculation overflow.
5565 (init_buffer_once): Check at compile-time, not run-time.
5567 2011-06-22 Jim Meyering <meyering@redhat.com>
5569 Don't leak an XBM-image-sized buffer
5570 * image.c (xbm_load): Free the image buffer after using it.
5572 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5575 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5576 that Sun C diagnosed.
5577 * fns.c (secure_hash): Fix pointer signedness issue.
5578 * intervals.c (static_offset_intervals): New function.
5579 (offset_intervals): Use it.
5581 2011-06-21 Leo Liu <sdl.web@gmail.com>
5584 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5587 * fns.c (secure_hash): Rename from crypto_hash_function and change
5588 the first arg to accept symbols.
5589 (Fsecure_hash): New primitive.
5590 (syms_of_fns): New symbols.
5592 2011-06-20 Deniz Dogan <deniz@dogan.se>
5594 * process.c (Fset_process_buffer): Clarify return value in
5597 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5599 * dispnew.c (add_window_display_history): Use BVAR.
5601 * xdisp.c (debug_method_add): Use BVAR.
5602 (check_window_end, dump_glyph_matrix, dump_glyph)
5603 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5605 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5608 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5609 check till after the cache is created in init_frame_faces.
5611 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5613 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5615 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5617 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5618 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5619 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5621 Improve buffer-overflow checking (Bug#8873).
5622 * fileio.c (Finsert_file_contents):
5623 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5624 Remove the old (too-loose) buffer overflow checks.
5625 They weren't needed, since make_gap checks for buffer overflow.
5626 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5627 The old code merely checked for Emacs fixnum overflow, and relied
5628 on undefined (wraparound) behavior. The new code avoids undefined
5629 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5631 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5632 Tune. Don't use wider integers than needed. Don't use alloca.
5633 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5635 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5637 * insdel.c, lisp.h (buffer_overflow): New function.
5638 (insert_from_buffer_1, replace_range, replace_range_2):
5639 * insdel.c (make_gap_larger):
5640 * editfns.c (Finsert_char):
5641 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5643 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5645 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5647 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5649 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5650 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5652 * fileio.c: Don't assume EMACS_INT fits in off_t.
5653 (emacs_lseek): New static function.
5654 (Finsert_file_contents, Fwrite_region): Use it.
5655 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5657 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5659 * fns.c: Don't overflow int when computing a list length.
5660 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5661 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5662 truncation on 64-bit hosts. Check for QUIT every
5663 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5664 faster and is responsive enough.
5665 (Flength): Report an error instead of overflowing an integer.
5666 (Fsafe_length): Return a float if the value is not representable
5667 as a fixnum. This shouldn't happen except in contrived situations.
5668 (Fnthcdr, Fsort): Don't assume list length fits in int.
5669 (Fcopy_sequence): Don't assume vector length fits in int.
5671 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5672 (header_size, word_size): New constants.
5673 (allocate_vectorlike): Don't check size overflow here.
5674 (allocate_vector): Check it here instead, since this is the only
5675 caller of allocate_vectorlike that could cause overflow.
5676 Check that the new vector's length is representable as a fixnum.
5678 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5679 The previous code was bogus. For example, next_almost_prime (32)
5680 returned 39, which is undesirable as it is a multiple of 3; and
5681 next_almost_prime (24) returned 25, which is a multiple of 5 so
5682 why was the code bothering to check for multiples of 7?
5684 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5686 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5688 Variadic C functions now count arguments with ptrdiff_t.
5689 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5690 Back then I didn't know that the Emacs coding style prefers signed int.
5691 Also, in the meantime I found a few more instances where arguments
5692 were being counted with int, which may truncate counts on 64-bit
5693 machines, or EMACS_INT, which may be unnecessarily wide.
5694 * lisp.h (struct Lisp_Subr.function.aMANY)
5695 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5696 Arg counts are now ptrdiff_t, not size_t.
5697 All variadic functions and their callers changed accordingly.
5698 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5699 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5700 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5701 * callint.c (Fcall_interactively): Check arg count for overflow,
5702 to avoid potential buffer overrun. Use signed char, not 'int',
5703 for 'varies' array, so that we needn't bother to check its size
5704 calculation for overflow.
5705 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5706 * eval.c (apply_lambda):
5707 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5708 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5709 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5711 * callint.c (Fcall_interactively): Don't use index var as event count.
5713 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5714 * mem-limits.h (SIZE): Remove; no longer used.
5716 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5718 Remove unnecessary casts.
5719 * xterm.c (x_term_init):
5720 * xfns.c (x_set_border_pixel):
5721 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5722 These aren't needed now that we assume ANSI C.
5724 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5725 It's more likely to cause problems (due to unsigned overflow)
5728 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5730 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5732 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5734 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5736 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5738 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5740 GLYPH_CODE_FACE returns EMACS_INT, not int.
5741 * dispextern.h (merge_faces):
5742 * xfaces.c (merge_faces):
5743 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5744 Don't assume EMACS_INT fits in int.
5746 * character.h (CHAR_VALID_P): Remove unused parameter.
5747 * fontset.c, lisp.h, xdisp.c: All uses changed.
5749 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5751 * fns.c (concat): Minor tuning based on overflow analysis.
5752 This doesn't fix any bugs. Use int to hold character, instead
5753 of constantly refetching from Emacs object. Use XFASTINT, not
5754 XINT, for value known to be a character. Don't bother comparing
5755 a single byte to 0400, as it's always less.
5757 * floatfns.c (Fexpt):
5758 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5760 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5763 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5765 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5766 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5767 incorrectly succeed when S was a string, because 4294967386 was
5768 truncated before it was used.
5770 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5771 Otherwise, an out-of-range integer could cause undefined behavior
5774 * composite.c: Use int, not EMACS_INT, for characters.
5775 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5776 EMACS_INT, for values that are known to be in character range.
5777 This doesn't fix any bugs but is the usual style inside Emacs and
5778 may generate better code on 32-bit machines.
5780 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5781 This is for reasons similar to the recent CHAR_STRING fix.
5782 * charset.c (Fencode_char): Check that character arg is actually
5783 a character. Pass an int to ENCODE_CHAR.
5784 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5785 wider than 'int', as a compile-time check to prevent future regressions
5788 * character.c (char_string): Remove unnecessary casts.
5790 Make sure a 64-bit char is never passed to CHAR_STRING.
5791 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5792 by silently ignoring the top 32 bits, allowing some values
5793 that were far too large to be valid characters.
5794 * character.h: Include <verify.h>.
5795 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5796 arguments are no wider than unsigned, as a compile-time check
5797 to prevent future regressions in this area.
5799 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5800 (Fsubst_char_in_region):
5802 * xdisp.c (decode_mode_spec_coding):
5803 Adjust to CHAR_STRING's new requirement.
5804 * editfns.c (Finsert_char, Fsubst_char_in_region):
5805 * fns.c (concat): Check that character args are actually
5806 characters. Without this test, these functions did the wrong
5807 thing with wildly out-of-range values on 64-bit hosts.
5809 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5810 These casts should not be needed on 32-bit hosts, either.
5811 * keyboard.c (read_char):
5812 * lread.c (Fload): Remove casts to unsigned.
5814 * lisp.h (UNSIGNED_CMP): New macro.
5815 This fixes comparison bugs on 64-bit hosts.
5816 (ASCII_CHAR_P): Use it.
5817 * casefiddle.c (casify_object):
5818 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5819 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5820 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5821 * dispextern.h (FACE_FROM_ID):
5822 * keyboard.c (read_char): Use UNSIGNED_CMP.
5824 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5825 not to EMACS_INT, to avoid GCC warning.
5827 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5829 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5830 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5831 isn't needed on 32-bit machines.
5833 * buffer.c (Fgenerate_new_buffer_name):
5834 Use EMACS_INT for count, not int.
5835 (advance_to_char_boundary): Return EMACS_INT, not int.
5837 * data.c (Qcompiled_function): Now static.
5839 * window.c (window_body_lines): Now static.
5841 * image.c (gif_load): Rename local to avoid shadowing.
5843 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5844 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5845 * alloc.c (make_save_value): Integer argument is now of type
5847 (mark_object): Use ptrdiff_t, not int.
5848 * lisp.h (pD): New macro.
5849 * print.c (print_object): Use it.
5851 * alloc.c: Use EMACS_INT, not int, to count objects.
5852 (total_conses, total_markers, total_symbols, total_vector_size)
5853 (total_free_conses, total_free_markers, total_free_symbols)
5854 (total_free_floats, total_floats, total_free_intervals)
5855 (total_intervals, total_strings, total_free_strings):
5856 Now EMACS_INT, not int. All uses changed.
5857 (Fgarbage_collect): Compute overall total using a double, so that
5858 integer overflow is less likely to be a problem. Check for overflow
5859 when converting back to an integer.
5860 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5861 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5862 These were 'int' variables that could overflow on 64-bit hosts;
5863 they were never used, so remove them instead of repairing them.
5864 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5865 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5866 Previously, this ceilinged at INT_MAX, but that doesn't work on
5868 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5870 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5871 (allocate_vectorlike): Check for ptrdiff_t overflow.
5872 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5873 when a (possibly-narrower) signed value would do just as well.
5874 We prefer using signed arithmetic, to avoid comparison confusion.
5876 * alloc.c: Catch some string size overflows that we were missing.
5877 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5878 for convenience in STRING_BYTES_MAX.
5879 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5880 The definition here is exact; the one in lisp.h was approximate.
5881 (allocate_string_data): Check for string overflow. This catches
5882 some instances we weren't catching before. Also, it catches
5883 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5884 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5885 and ptrdiff_t and EMACS_INT are both 64 bits.
5887 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5888 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5889 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5891 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5893 * alloc.c (Fmake_string): Check for out-of-range init.
5895 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5897 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5899 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5901 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5902 xg_get_default_scrollbar_width.
5904 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5905 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5906 (style_changed_cb): Call update_theme_scrollbar_width and call
5907 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5908 all frames (Bug#8505).
5909 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5910 Call gtk_window_set_resizable if HAVE_GTK3.
5911 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5912 and height if HAVE_GTK3 (Bug#8505).
5913 (scroll_bar_width_for_theme): New variable.
5914 (update_theme_scrollbar_width): New function.
5915 (xg_get_default_scrollbar_width): Move code to
5916 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5917 (xg_initialize): Call update_theme_scrollbar_width.
5919 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5921 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5923 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5925 * frame.c (make_frame): Call other_buffer_safely instead of
5928 * window.c (temp_output_buffer_show): Call display_buffer with
5929 second argument Vtemp_buffer_show_specifiers and reset latter
5930 immediately after the call.
5931 (Vtemp_buffer_show_specifiers): New variable.
5932 (auto_window_vscroll_p, next_screen_context_lines)
5933 (Vscroll_preserve_screen_position): Remove leading asterisks from
5936 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5938 Fix minor problems found by GCC 4.6.0 static checking.
5939 * buffer.c (Qclone_number): Remove for now, as it's unused.
5940 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5941 (record_buffer): Remove unused local.
5942 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5943 (set_frame_buffer_list): Remove; unused.
5944 * frame.h (other_visible_frames): Remove decl.
5945 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5946 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5947 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5949 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5950 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5951 Define only if HAVE_GPM.
5952 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5953 (update_hints_inhibit): Remove; never set. All uses removed.
5954 * widgetprv.h (emacsFrameClassRec): Remove decl.
5955 * window.c (delete_deletable_window): Now returns void, since it
5956 wasn't returning anything.
5957 (compare_window_configurations): Remove unused locals.
5958 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5959 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5960 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5961 the same widths as pointers. This follows up on the 2011-05-06 patch.
5962 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5963 * xterm.h: Likewise.
5964 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5966 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5968 * makefile.w32-in: Update dependencies.
5969 (LISP_H): Add lib/intprops.h.
5971 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5973 * image.c (gif_load): Add animation frame delay to the metadata.
5974 (syms_of_image): Use DEFSYM. New symbol `delay'.
5976 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5978 * window.c (delete_deletable_window): Re-add.
5979 (Fset_window_configuration): Rewrite to handle dead buffers and
5980 consequently deletable windows.
5981 (window_tree, Fwindow_tree): Remove. Supply functionality in
5983 (compare_window_configurations): Simplify code.
5985 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5987 * image.c (imagemagick_load_image): Fix type mismatch.
5988 (Fimagemagick_types): Likewise.
5990 * window.h (replace_buffer_in_windows): Declare.
5992 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5994 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5995 Qclone_number. Remove external declaration of Qdelete_window.
5996 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5998 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5999 Run Qbuffer_list_update_hook if allowed.
6000 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6001 buffer list implementation.
6002 (other_buffer_safely): New function.
6003 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6004 calls to replace_buffer_in_windows and
6005 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6007 (record_buffer): Inhibit quitting and rewrite using quittable
6008 functions. Run Qbuffer_list_update_hook if allowed.
6009 (Frecord_buffer, Funrecord_buffer): New functions.
6010 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6011 Move switch-to-buffer to window.el.
6012 (bury-buffer): Move to window.el.
6013 (Vbuffer_list_update_hook): New variable.
6015 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6018 * window.h (resize_frame_windows): Move up in code.
6019 (Fwindow_frame): Remove EXFUN.
6020 (replace_buffer_in_all_windows): Remove prototype.
6021 (replace_buffer_in_windows_safely): Add prototype.
6023 * window.c: Declare Qdelete_window static again. Move down
6024 declaration of select_count.
6025 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6026 (Fother_window): Move to window.el.
6027 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6028 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6029 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6031 (replace_buffer_in_windows): Implement by calling
6032 Qreplace_buffer_in_windows.
6033 (replace_buffer_in_all_windows): Remove with some functionality
6034 moved into replace_buffer_in_windows_safely.
6035 (replace_buffer_in_windows_safely): New function.
6036 (select_window_norecord, select_frame_norecord): Move in front
6037 of run_window_configuration_change_hook. Remove now obsolete
6039 (Fset_window_buffer): Rewrite doc-string.
6040 Call Qrecord_window_buffer.
6041 (keys_of_window): Move binding for other-window to window.el.
6043 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6045 * dispextern.h (struct image): Replace data member, whose int_val
6046 and ptr_val fields were not used by anything, with a single
6049 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6050 (gif_clear_image, gif_load, imagemagick_load_image)
6051 (gs_clear_image, gs_load): Callers changed.
6053 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6055 * buffer.h: Include <time.h>, for time_t.
6056 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6058 Fix minor problems found by static checking.
6060 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6062 Make identifiers static if they are not used in other modules.
6063 * data.c (Qcompiled_function, Qframe, Qvector):
6064 * image.c (QimageMagick, Qsvg):
6065 * minibuf.c (Qmetadata):
6066 * window.c (resize_window_check, resize_root_window): Now static.
6067 * window.h (resize_window_check, resize_root_window): Remove decls.
6069 * window.c (window_deletion_count, delete_deletable_window):
6071 (window_body_lines): Now static.
6072 (Fdelete_other_windows_internal): Mark vars as initialized.
6073 Make sure 'resize_failed' is initialized.
6074 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6075 (resize_window_apply): Remove unused local.
6076 * window.h (delete_deletable_window): Remove decl.
6078 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6079 (imagemagick_load_image): Fix pointer signedness problem by changing
6080 last arg from unsigned char * to char *. All uses changed.
6081 Also, fix a local for similar reasons.
6082 Remove unused locals. Remove locals to avoid shadowing.
6083 (fn_rsvg_handle_free): Remove; unused.
6084 (svg_load, svg_load_image): Fix pointer signedness problem.
6085 (imagemagick_load_image): Don't use garbage pointer image_wand.
6087 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6089 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6091 * image.c (gif_load): Fix omitted cast error introduced by
6094 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6096 * window.h (resize_proportionally, orig_total_lines)
6097 (orig_top_line): Remove from window structure.
6098 (set_window_height, set_window_width, change_window_heights)
6099 (Fdelete_window): Remove prototypes.
6100 (resize_frame_windows): Remove duplicate declaration.
6102 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6104 * window.h (resize_frame_windows, resize_window_check)
6105 (delete_deletable_window, resize_root_window)
6106 (resize_frame_windows): Declare prototypes.
6108 * window.c (resize_window_apply): Make definition be "static" to
6109 match the prototype.
6111 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6113 * window.c: Remove declarations of Qwindow_size_fixed,
6114 window_min_size_1, window_min_size_2, window_min_size,
6115 size_window, window_fixed_size_p, enlarge_window, delete_window.
6116 Remove static from declaration of Qdelete_window, it's
6117 temporarily needed by Fbury_buffer.
6118 (replace_window): Don't assign orig_top_line and
6120 (Fdelete_window, delete_window): Remove. Window deletion is
6121 handled by window.el.
6122 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6123 Replace Fdelete_window calls with calls to Qdelete_window.
6124 (Fdelete_other_windows): Remove. Deleting other windows is
6125 handled by window.el.
6126 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6127 handled in window.el.
6128 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6129 Window minimum sizes are handled in window.el.
6130 (shrink_windows, size_window, set_window_height)
6131 (set_window_width, change_window_heights, window_height)
6132 (window_width, CURBEG, CURSIZE, enlarge_window)
6133 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6134 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6135 handled in window.el.
6136 (make_dummy_parent): Rename to make_parent_window and give it a
6137 second argument horflag.
6138 (make_window): Don't set resize_proportionally any more.
6139 (Fsplit_window): Remove. Windows are split in window.el.
6140 (save_restore_action, save_restore_orig_size)
6141 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6142 Resize mini windows in window.el.
6143 (grow_mini_window, shrink_mini_window): Implement by calling
6144 Qresize_root_window_vertically, resize_window_check and
6145 resize_window_apply.
6146 (saved_window, Fset_window_configuration, save_window_save):
6147 Do not handle orig_top_line, orig_total_lines, and
6148 resize_proportionally.
6149 (window_min_height, window_min_width): Move to window.el.
6150 (keys_of_window): Move bindings for delete-other-windows,
6151 split-window, delete-window and enlarge-window to window.el.
6153 * buffer.c: Temporarily extern Qdelete_window.
6154 (Fbury_buffer): Temporarily call Qdelete_window instead of
6155 Fdelete_window (Fbury_buffer will move to window.el soon).
6157 * frame.c (set_menu_bar_lines_1): Remove code handling
6158 orig_top_line and orig_total_lines.
6160 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6161 set_window_height but set heights directly.
6162 (change_frame_size_1): Use resize_frame_windows.
6164 * xdisp.c (init_xdisp): Don't use set_window_height but set
6167 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6168 Use resize_frame_windows instead of change_window_heights and run
6169 run_window_configuration_change_hook.
6171 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6172 instead of change_window_heights and run
6173 run_window_configuration_change_hook.
6175 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6177 * window.c (replace_window): Rename second argument REPLACEMENT to
6178 NEW. New third argument SETFLAG. Rewrite.
6179 (delete_window, make_dummy_parent): Call replace_window with
6181 (window_list_1): Move down in code.
6182 (run_window_configuration_change_hook): Move set_buffer part
6183 before select_frame_norecord part in order to unwind correctly.
6184 Rename count1 to count.
6185 (recombine_windows, delete_deletable_window, resize_root_window)
6186 (Fdelete_other_windows_internal)
6187 (Frun_window_configuration_change_hook, make_parent_window)
6188 (resize_window_check, resize_window_apply, Fresize_window_apply)
6189 (resize_frame_windows, Fsplit_window_internal)
6190 (Fdelete_window_internal, Fresize_mini_window_internal):
6192 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6194 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6196 * window.h (window): Add some new members to window structure -
6197 normal_lines, normal_cols, new_total, new_normal, clone_number,
6198 splits, nest, prev_buffers, next_buffers.
6199 (WINDOW_TOTAL_SIZE): Move here from window.c.
6200 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6202 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6204 (make_dummy_parent): Set new members of windows structure.
6205 (make_window): Move down in code. Handle new members of window
6207 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6208 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6209 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6210 (Fset_window_prev_buffers, Fwindow_next_buffers)
6211 (Fset_window_next_buffers, Fset_window_clone_number):
6213 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6214 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6216 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6217 Argument WINDOW can be now internal window too.
6218 (Fwindow_use_time): Move up in code.
6219 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6221 (Fset_window_configuration, saved_window)
6222 (Fcurrent_window_configuration, save_window_save): Handle new
6223 members of window structure.
6224 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6225 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6226 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6227 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6228 Qget_mru_window, Qresize_root_window,
6229 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6230 Qauto_buffer_name; staticpro them.
6232 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6234 * window.c (Fwindow_total_size, Fwindow_left_column)
6235 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6236 (Fwindow_list_1): New functions.
6237 (window_box_text_cols): Replace with window_body_cols.
6238 (Fwindow_width, Fscroll_left, Fscroll_right):
6239 Use window_body_cols instead of window_box_text_cols.
6240 (delete_window, Fset_window_configuration):
6241 Call delete_all_subwindows with window as argument.
6242 (delete_all_subwindows): Take a window as argument and not a
6244 (window_loop): Remove handling of GET_LRU_WINDOW and
6246 (Fget_lru_window, Fget_largest_window): Move to window.el.
6248 * window.h: Extern window_body_cols instead of
6249 window_box_text_cols. delete_all_subwindows now takes a
6250 Lisp_Object as argument.
6252 * indent.c (compute_motion, Fcompute_motion):
6253 Use window_body_cols instead of window_box_text_cols.
6255 * frame.c (delete_frame): Call delete_all_subwindows with root
6258 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6260 * fns.c (Fputhash): Document return value.
6262 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6264 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6266 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6268 Cons<->int and similar integer overflow fixes (Bug#8794).
6270 Check for overflow when converting integer to cons and back.
6271 * charset.c (Fdefine_charset_internal, Fdecode_char):
6272 Use cons_to_unsigned to catch overflow.
6273 (Fencode_char): Use INTEGER_TO_CONS.
6274 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6275 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6276 * data.c (long_to_cons, cons_to_long): Remove.
6277 (cons_to_unsigned, cons_to_signed): New functions.
6278 These signal an error for invalid or out-of-range values.
6279 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6280 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6281 * font.c (Ffont_variation_glyphs):
6282 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6283 * lisp.h: Include <intprops.h>.
6284 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6285 (cons_to_signed, cons_to_unsigned): New decls.
6286 (long_to_cons, cons_to_long): Remove decls.
6287 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6288 (Fprimitive_undo): Use CONS_TO_INTEGER.
6289 * xfns.c (Fx_window_property): Likewise.
6290 * xselect.c: Include <limits.h>.
6291 (x_own_selection, selection_data_to_lisp_data):
6292 Use INTEGER_TO_CONS.
6293 (x_handle_selection_request, x_handle_selection_clear)
6294 (x_get_foreign_selection, Fx_disown_selection_internal)
6295 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6296 (lisp_data_to_selection_data): Use cons_to_unsigned.
6297 (x_fill_property_data): Use cons_to_signed.
6298 Report values out of range.
6300 Check for buffer and string overflow more precisely.
6301 * buffer.h (BUF_BYTES_MAX): New macro.
6302 * lisp.h (STRING_BYTES_MAX): New macro.
6303 * alloc.c (Fmake_string):
6304 * character.c (string_escape_byte8):
6305 * coding.c (coding_alloc_by_realloc):
6306 * doprnt.c (doprnt):
6307 * editfns.c (Fformat):
6309 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6310 since they may not be the same number.
6311 * editfns.c (Finsert_char):
6312 * fileio.c (Finsert_file_contents):
6313 Likewise for BUF_BYTES_MAX.
6315 * image.c: Use ptrdiff_t, not int, for sizes.
6316 (slurp_file): Switch from int to ptrdiff_t.
6318 (slurp_file): Check that file size fits in both size_t (for
6319 malloc) and ptrdiff_t (for sanity and safety).
6321 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6322 if b->modtime has its maximal value.
6324 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6326 Don't assume time_t can fit into int.
6327 * buffer.h (struct buffer.modtime): Now time_t, not int.
6328 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6329 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6331 Minor fixes for signed vs unsigned integers.
6332 * character.h (MAYBE_UNIFY_CHAR):
6333 * charset.c (maybe_unify_char):
6334 * keyboard.c (read_char, reorder_modifiers):
6335 XINT -> XFASTINT, since the integer must be nonnegative.
6336 * ftfont.c (ftfont_spec_pattern):
6337 * keymap.c (access_keymap, silly_event_symbol_error):
6338 XUINT -> XFASTINT, since the integer must be nonnegative.
6339 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6340 since it makes no difference and we prefer signed.
6341 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6342 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6345 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6347 * window.h (Fwindow_frame): Declare.
6349 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6351 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6352 (SPARE_MEMORY): Always define.
6353 (LARGE_REQUEST): Remove.
6354 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6356 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6358 * lisp.h: Move EXFUNS for Fframe_root_window,
6359 Fframe_first_window and Fset_frame_selected_window to window.h.
6361 * window.h: Move EXFUNS for Fframe_root_window,
6362 Fframe_first_window and Fset_frame_selected_window here from
6365 * frame.c (Fwindow_frame, Fframe_first_window)
6366 (Fframe_root_window, Fframe_selected_window)
6367 (Fset_frame_selected_window): Move to window.c.
6368 (Factive_minibuffer_window): Move to minibuf.c.
6369 (Fother_visible_frames_p): New function.
6371 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6373 * window.c (decode_window, decode_any_window): Move up in code.
6374 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6375 (inhibit_frame_unsplittable): Remove unused variable.
6376 (Fwindow_buffer): Move up and rewrite doc-string.
6377 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6378 (Fwindow_prev): New functions.
6379 (Fwindow_frame): Move here from frame.c. Accept any window as
6381 (Fframe_root_window, Fframe_first_window)
6382 (Fframe_selected_window): Move here from frame.c. Accept frame
6383 or arbitrary window as argument. Update doc-strings.
6384 (Fminibuffer_window): Move up in code.
6385 (Fwindow_minibuffer_p): Move up in code and simplify.
6386 (Fset_frame_selected_window): Move here from frame.c.
6388 (Fselected_window, select_window, Fselect_window): Move up in
6389 code. Minor doc-string fixes.
6391 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6393 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6394 Do not assume that spare memory exists; that assumption is valid
6395 only if SYSTEM_MALLOC.
6396 (LARGE_REQUEST): New macro, so that the issue of large requests
6397 is separated from the issue of spare memory.
6399 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6401 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6404 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6406 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6409 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6411 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6413 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6415 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6416 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6418 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6420 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6422 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6424 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6425 (x_clipboard_manager_save): Add return value.
6426 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6428 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6429 Obey Vx_select_enable_clipboard_manager. Catch errors in
6430 x_clipboard_manager_save (Bug#8779).
6431 (Vx_select_enable_clipboard_manager): New variable.
6432 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6434 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6436 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6438 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6440 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6441 in the current matrix if keep_current_p is non-zero.
6443 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6445 * bidi.c (bidi_level_of_next_char): Fix last change.
6447 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6449 Support bidi reordering of text covered by display properties.
6451 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6452 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6453 (bidi_cache_search, bidi_cache_iterator_state)
6454 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6455 (bidi_level_of_next_char, bidi_move_to_visually_next):
6456 Support character positions inside a run of characters covered by a
6458 (bidi_paragraph_init, bidi_resolve_explicit_1)
6459 (bidi_level_of_next_char): Call bidi_fetch_char and
6460 bidi_fetch_char_advance instead of FETCH_CHAR and
6462 (bidi_init_it): Initialize new members.
6463 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6465 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6466 instead of using explicit *_CHAR codes.
6467 (bidi_resolve_explicit, bidi_resolve_weak):
6468 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6469 bidirectional text is supported only in multibyte buffers.
6470 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6471 it to initialize the frame_window_p member of struct bidi_it.
6472 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6473 (bidi_resolve_explicit, bidi_resolve_weak)
6474 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6475 bidi_it->nchars is non-positive.
6476 (bidi_level_of_next_char): Don't try to lookup the cache for the
6477 next/previous character if nothing is cached there yet, or if we
6478 were just reseat()'ed to a new position.
6480 * xdisp.c (set_cursor_from_row): Set start and stop points
6481 according to the row's direction when priming the loop that looks
6482 for the glyph on which to display cursor.
6483 (single_display_spec_intangible_p): Function deleted.
6484 (display_prop_intangible_p): Reimplement to call
6485 handle_display_spec instead of single_display_spec_intangible_p.
6486 Accept 3 additional arguments needed by handle_display_spec.
6487 This fixes incorrect cursor motion across display property with complex
6488 values: lists, `(when COND...)' forms, etc.
6489 (single_display_spec_string_p): Support property values that are
6490 lists with the argument STRING its top-level element.
6491 (display_prop_string_p): Fix the condition for processing a
6492 property that is a list to be consistent with handle_display_spec.
6493 (handle_display_spec): New function, refactored from the
6494 last portion of handle_display_prop.
6495 (compute_display_string_pos): Accept additional argument
6496 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6497 value of a `display' property is a "replacing spec".
6498 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6499 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6500 the display property, but just return a value indicating whether
6501 the display property will replace the characters it covers.
6502 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6503 frame_window_p members of struct bidi_it.
6504 (compute_display_string_pos, compute_display_string_end):
6506 (push_it): Accept second argument POSITION, where pop_it should
6507 jump to continue iteration.
6508 (reseat_1): Initialize bidi_it.disp_pos.
6510 * keyboard.c (adjust_point_for_property): Adjust the call to
6511 display_prop_intangible_p to its new signature.
6513 * dispextern.h (struct bidi_it): New member frame_window_p.
6514 (bidi_init_it): Update prototypes.
6515 (display_prop_intangible_p): Update prototype.
6516 (compute_display_string_pos, compute_display_string_end):
6518 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6521 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6523 Malloc failure behavior now depends on size of allocation.
6524 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6525 * lisp.h: Change signatures accordingly.
6526 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6527 All callers changed. (Bug#8762)
6529 * gnutls.c: Use Emacs's memory allocators.
6530 Without this change, the gnutls library would invoke malloc etc.
6531 directly, which causes problems on non-SYNC_INPUT hosts, and which
6532 runs afoul of improving memory_full behavior. (Bug#8761)
6533 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6534 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6535 xfree instead of the default malloc, realloc, free.
6536 (Fgnutls_boot): No need to check for memory allocation failure,
6537 since xmalloc does that for us.
6539 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6540 * category.c (hash_get_category_set):
6541 * ccl.c (ccl_driver):
6542 * charset.c (Fdefine_charset_internal):
6543 * charset.h (struct charset.hash_index):
6544 * composite.c (get_composition_id, gstring_lookup_cache)
6545 (composition_gstring_put_cache):
6546 * composite.h (struct composition.hash_index):
6547 * dispextern.h (struct image.hash):
6548 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6549 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6550 (hashfn_equal, hashfn_user_defined, make_hash_table)
6551 (maybe_resize_hash_table, hash_lookup, hash_put)
6552 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6553 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6554 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6555 * image.c (make_image, search_image_cache, lookup_image)
6556 (xpm_put_color_table_h):
6557 * lisp.h (struct Lisp_Hash_Table):
6558 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6559 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6560 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6561 * alloc.c (allocate_vectorlike):
6562 Check for overflow in vector size calculations.
6563 * ccl.c (ccl_driver):
6564 Check for overflow when converting EMACS_INT to int.
6565 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6566 need to be updated by these changes.
6567 * fns.c (make_hash_table, maybe_resize_hash_table):
6568 Check for integer overflow with large hash tables.
6569 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6570 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6571 (SXHASH_REDUCE): New macro.
6572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6573 Use it instead of discarding useful hash info with large hash values.
6574 (sxhash_float): New function.
6575 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6576 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6577 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6578 Rewrite to use FIXNUM_BITS, as this simplifies things.
6579 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6580 Adjust signatures to match updated version of code.
6581 (consing_since_gc): Now EMACS_INT, since a single hash table can
6582 use more than INT_MAX bytes.
6584 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6586 Make it possible to build with GCC-4.6+ -O2 -flto.
6588 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6590 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6592 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6593 Call minibuffer-inactive-mode.
6595 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6597 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6598 Update dependencies.
6600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6602 * data.c (init_data): Remove code for UTS, this system is not
6605 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6607 Don't force ./temacs to start in terminal mode.
6609 * frame.c (make_initial_frame): Initialize faces in all cases, not
6610 only when CANNOT_DUMP is defined.
6611 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6615 * dispnew.c (add_window_display_history): Use const for the string
6616 pointer. Remove declaration, not needed.
6618 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6620 Use 'inline', not 'INLINE'.
6621 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6622 * alloc.c, fontset.c (INLINE): Remove.
6623 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6624 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6625 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6626 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6627 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6629 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6631 Make it possible to run ./temacs.
6633 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6634 syms_of_callproc does the same thing. Remove test for
6635 "initialized", do it in the caller.
6636 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6638 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6640 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6641 (read_minibuf): Use get_minibuffer.
6642 (syms_of_minibuf): Use DEFSYM.
6643 (Qmetadata): New var.
6644 * data.c (Qbuffer): Don't make it static.
6645 (syms_of_data): Use DEFSYM.
6647 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6649 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6650 (CCL_CODE_MIN): New macro.
6652 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6654 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6656 * eval.c (Qdebug): Now static.
6657 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6658 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6659 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6661 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6663 * image.c: Various fixes to ImageMagick code comments.
6664 (Fimagemagick_types): Doc fix.
6666 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6668 Minor fixes prompted by GCC 4.6.0 warnings.
6670 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6672 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6673 (x_clipboard_manager_save_all): Move extern decl to ...
6674 * xterm.h: ... here, so that it can be checked for consistency.
6676 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6678 * xselect.c (x_clipboard_manager_save_frame)
6679 (x_clipboard_manager_save_all): New functions.
6680 (Fx_clipboard_manager_save): Lisp function deleted.
6682 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6683 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6685 * xterm.h: Update prototype.
6687 2011-05-28 William Xu <william.xwl@gmail.com>
6689 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6692 2011-05-28 Jim Meyering <meyering@redhat.com>
6694 Avoid a sign-extension bug in crypto_hash_function.
6695 * fns.c (to_uchar): Define.
6696 (crypto_hash_function): Use it to convert some newly-signed
6697 variables to unsigned, to avoid sign-extension bugs. For example,
6698 without this change, (md5 "truc") would evaluate to
6699 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6700 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6701 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6703 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6705 Integer overflow fixes.
6707 * dbusbind.c: Serial number integer overflow fixes.
6708 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6709 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6710 to hold a serial number that is too large for a fixnum.
6711 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6712 Check for serial numbers out of range. Decode any serial number
6713 that was so large that it became a float. (Bug#8722)
6715 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6716 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6717 Use XFASTINT rather than XUINT when numbers are nonnegative.
6718 (xd_append_arg, Fdbus_method_return_internal):
6719 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6720 arguments, check that Lisp number is nonnegative, rather than
6721 silently wrapping negative numbers around. (Bug#8722)
6722 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6725 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6727 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6729 ccl: Add integer overflow checks.
6730 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6731 (IN_INT_RANGE): New macros.
6732 (ccl_driver): Use them to check for integer overflow when
6733 decoding a CCL program. Many of the new checks are whether XINT (x)
6734 fits in int; it doesn't always, on 64-bit hosts. The new version
6735 doesn't catch all possible integer overflows, but it's an
6736 improvement. (Bug#8719)
6738 * alloc.c (make_event_array): Use XINT, not XUINT.
6739 There's no need for unsigned here.
6741 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6742 This follows up to the 2011-05-06 change that substituted uintptr_t
6743 for EMACS_INT. This case wasn't caught back then.
6745 Rework Fformat to avoid integer overflow issues.
6746 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6747 now (part of C89). Include <verify.h>.
6748 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6749 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6750 (Fformat): Avoid the prepass trying to compute sizes; it was only
6751 approximate and thus did not catch overflow reliably. Instead, walk
6752 through the format just once, formatting and computing sizes as we go,
6753 checking for integer overflow at every step, and allocating a larger
6754 buffer as needed. Keep track separately whether the format is
6755 multibyte. Keep only the most-recently calculated precision, rather
6756 than them all. Record whether each argument has been converted to
6757 string. Use EMACS_INT, not int, for byte and char and arg counts.
6758 Support field widths and precisions larger than INT_MAX. Avoid
6759 sprintf's undefined behavior with conversion specifications such as %#d
6760 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6761 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6762 formatting out-of-range floating point numbers with int
6765 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6767 * data.c: Avoid integer truncation in expressions involving floats.
6768 * data.c: Include <intprops.h>.
6769 (arith_driver): When there's an integer overflow in an expression
6770 involving floating point, convert the integers to floating point
6771 so that the resulting value does not suffer from catastrophic
6772 integer truncation. For example, on a 64-bit host (* 4
6773 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6774 Do not rely on undefined behavior after integer overflow.
6776 merge count_size_as_multibyte, parse_str_to_multibyte
6777 * character.c, character.h (count_size_as_multibyte):
6778 Rename from parse_str_to_multibyte; all uses changed.
6779 Check for integer overflow.
6780 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6781 since it's now a duplicate of the other. This is more of
6782 a character than a buffer op, so better that it's in character.c.
6783 * fns.c, print.c: Adjust to above changes.
6785 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6787 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6789 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6791 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6792 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6793 (x_clipboard_manager_save): Now static.
6794 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6796 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6797 (crypto_hash_function): Now static.
6798 Fix pointer signedness problems. Avoid unnecessary initializations.
6800 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6802 * termhooks.h (Vselection_alist): Make it terminal-local.
6804 * terminal.c (create_terminal): Initialize it.
6806 * xselect.c: Support for clipboard managers.
6807 (Vselection_alist): Move to termhooks.h as terminal-local var.
6808 (LOCAL_SELECTION): New macro.
6809 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6810 (symbol_to_x_atom): Remove gratuitous arg.
6811 (x_handle_selection_request, lisp_data_to_selection_data)
6812 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6813 (x_own_selection, x_get_local_selection, x_convert_selection):
6814 New arg, specifying work frame. Use terminal-local Vselection_alist.
6815 (some_frame_on_display): Delete unused function.
6816 (Fx_own_selection_internal, Fx_get_selection_internal)
6817 (Fx_disown_selection_internal, Fx_selection_owner_p)
6818 (Fx_selection_exists_p): New optional frame arg.
6819 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6820 (x_handle_selection_clear): Don't treat other terminals with the
6821 same keyboard specially. Use the terminal-local Vselection_alist.
6822 (x_clear_frame_selections): Use Frun_hook_with_args.
6824 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6826 * xterm.h: Add support for those atoms.
6828 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6830 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6831 (converted_selections, conversion_fail_tag): New global variables.
6832 (x_selection_request_lisp_error): Free the above.
6833 (x_get_local_selection): Remove unnecessary code.
6834 (x_reply_selection_request): Args changed; handle arbitrary array
6835 of converted selections stored in converted_selections.
6836 Separate the XChangeProperty and SelectionNotify steps.
6837 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6838 (x_convert_selection): New function.
6839 (x_handle_selection_event): Simplify.
6840 (x_get_foreign_selection): Don't ignore incoming requests while
6841 waiting for an answer; this will fail when we implement
6842 SAVE_TARGETS, and seems unnecessary anyway.
6843 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6844 (Vx_sent_selection_functions): Doc fix.
6846 2011-05-26 Leo Liu <sdl.web@gmail.com>
6848 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6850 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6852 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6854 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6855 for fringe update if it has periodic bitmap.
6856 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6857 and fringe_bitmap_periodic_p.
6859 * fringe.c (get_fringe_bitmap_data): New function.
6860 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6861 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6862 row. Mark glyph row for fringe update if periodicity changed.
6864 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6865 for fringe update unless it has periodic bitmap.
6867 2011-05-25 Kenichi Handa <handa@m17n.org>
6869 * xdisp.c (get_next_display_element): Set correct it->face_id for
6870 a static composition.
6872 2011-05-24 Leo Liu <sdl.web@gmail.com>
6875 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6877 * fns.c (crypto_hash_function, Fsha1): New function.
6878 (Fmd5): Use crypto_hash_function.
6879 (syms_of_fns): Add Ssha1.
6881 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6883 * gnutls.c: Remove unused macros.
6884 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6885 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6886 Remove macros that are defined and never used.
6887 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6889 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6891 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6892 (Fx_get_selection_internal): Minor cleanup.
6893 (Fx_own_selection_internal): Rename arguments for consistency with
6896 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6898 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6900 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6902 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6904 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6906 * dispnew.c (scrolling_window): Don't exclude the case that the
6907 last enabled row in the desired matrix touches the bottom boundary.
6909 2011-05-21 Glenn Morris <rgm@gnu.org>
6911 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6912 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6913 and add some more files.
6915 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6917 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6918 report_file_error introduced by the change from 2011-05-07.
6920 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6922 * systime.h (Time): Define only if emacs is defined.
6923 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6924 where the include path doesn't have X11/X.h by default. See
6925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6927 2011-05-20 Kenichi Handa <handa@m17n.org>
6929 * composite.c (find_automatic_composition): Fix previous change.
6931 2011-05-20 Glenn Morris <rgm@gnu.org>
6933 * lisp.mk: New file, split from Makefile.in.
6934 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6935 (shortlisp): Remove.
6936 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6938 2011-05-19 Glenn Morris <rgm@gnu.org>
6940 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6941 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6942 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6943 (lisp): Set the order to that of loadup.el.
6944 (shortlisp): Make it a copy of $lisp.
6945 (SOME_MACHINE_LISP): Remove.
6946 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6947 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6949 2011-05-18 Kenichi Handa <handa@m17n.org>
6951 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6952 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6953 (find_automatic_composition): Mostly rewrite for efficiency.
6955 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6957 * makefile.w32-in: Update dependencies.
6959 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6961 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6962 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6964 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6966 Fix some integer overflow issues, such as string length overflow.
6968 * insdel.c (count_size_as_multibyte): Check for string overflow.
6970 * character.c (lisp_string_width): Check for string overflow.
6971 Use EMACS_INT, not int, for string indexes and lengths; in
6972 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6973 the resulting string length overflows an EMACS_INT; instead,
6974 report a string overflow if no precision given. When checking for
6975 precision exhaustion, use a check that cannot possibly have
6976 integer overflow. (Bug#8675)
6977 * character.h (lisp_string_width): Adjust to new signature.
6979 * alloc.c (string_overflow): New function.
6980 (Fmake_string): Use it. This doesn't change behavior, but saves
6981 a few bytes and will simplify future changes.
6982 * character.c (string_escape_byte8): Likewise.
6983 * lisp.h (string_overflow): New decl.
6985 Fixups, following up to the user-interface timestamp change.
6986 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6987 for UI timestamps, instead of unsigned long.
6988 * msdos.c (mouse_get_pos): Likewise.
6989 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6990 * w32gui.h (Time): Define by including "systime.h" rather than by
6991 declaring it ourselves. (Bug#8664)
6993 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6994 * image.c (clear_image_cache): Likewise.
6996 * term.c (term_mouse_position): Don't assume time_t wraparound.
6998 Be more systematic about user-interface timestamps.
6999 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7000 and sometimes 'EMACS_UINT', to represent these timestamps.
7001 This change causes it to use 'Time' uniformly, as that's what X uses.
7002 This makes the code easier to follow, and makes it easier to catch
7003 integer overflow bugs such as Bug#8664.
7004 * frame.c (Fmouse_position, Fmouse_pixel_position):
7005 Use Time, not unsigned long, for user-interface timestamps.
7006 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7007 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7008 * keyboard.h (last_event_timestamp): Likewise.
7009 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7010 * menu.h (xmenu_show): Likewise.
7011 * term.c (term_mouse_position): Likewise.
7012 * termhooks.h (struct input_event.timestamp): Likewise.
7013 (struct terminal.mouse_position_hook): Likewise.
7014 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7015 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7016 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7017 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7019 * menu.h, termhooks.h: Include "systime.h", for Time.
7021 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7022 Don't assume that the difference between two unsigned long values
7023 can fit into an integer. At this point, we know button_down_time
7024 <= event->timestamp, so the difference must be nonnegative, so
7025 there's no need to cast the result if double-click-time is
7026 nonnegative, as it should be; check that it's nonnegative, just in
7027 case. This bug is triggered when events are more than 2**31 ms
7028 apart (about 25 days). (Bug#8664)
7030 * xselect.c (last_event_timestamp): Remove duplicate decl.
7031 (x_own_selection): Remove needless cast to unsigned long.
7033 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7034 that always fit in int. Use a sentinel instead of a counter, to
7035 avoid a temp and to allay GCC's concerns about possible int overflow.
7036 * frame.h (struct frame): Use int for menu_bar_items_used
7037 instead of EMACS_INT, since it always fits in int.
7039 * menu.c (grow_menu_items): Check for int overflow.
7041 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7043 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7044 Before, the code was not consistent. These values cannot exceed
7045 2**31 - 1 so there's no need to make them unsigned.
7046 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7047 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7048 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7050 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7052 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7053 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7054 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7055 presumably because the widths might not match.
7057 * window.c (size_window): Avoid needless test at loop start.
7059 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7061 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7063 2011-05-12 Drew Adams <drew.adams@oracle.com>
7065 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7067 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7069 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7070 `width' to `bar_area_x' and `bar_area_width', respectively.
7071 (x_scroll_run): Take account of fringe background extension.
7073 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7074 Rename local vars `left' and `width' to `bar_area_x' and
7075 `bar_area_width', respectively.
7076 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7077 background extension.
7079 2011-05-10 Jim Meyering <meyering@redhat.com>
7081 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7083 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7085 * image.c (Finit_image_library): Return t for built-in image types,
7086 like pbm and xbm. (Bug#8640)
7088 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7090 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7092 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7094 * w32console.c (Fset_screen_color): Doc fix.
7095 (Fget_screen_color): New function.
7096 (syms_of_ntterm): Defsubr it.
7098 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7099 unlink the temporary file if Fcall_process didn't create it in the
7101 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7102 child process will be redirected to a file specified with `:file'.
7103 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7104 cue to call_process_cleanup not to close that handle.
7106 2011-05-07 Ben Key <bkey76@gmail.com>
7108 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7109 one of two shell specific rules, either bootstrap-temacs-CMD or
7110 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7111 to the previous implementation of the bootstrap-temacs rule.
7112 The bootstrap-temacs-CMD rule is similar to the previous
7113 implementation of the bootstrap-temacs rule except that it
7114 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7117 These changes, along with some changes to nt/configure.bat,
7118 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7119 earlier fix to add support for --cflags and --ldflags options
7120 that include quotes so that it works whether make uses cmd or
7123 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7125 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7126 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7128 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7129 a string. Handle both cases.
7130 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7131 (Fdbus_register_method): Use Qinvalid_function.
7133 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7135 * makefile.w32-in: Update dependencies.
7136 (LISP_H): Add inttypes.h and stdin.h.
7137 (PROCESS_H): Add unistd.h.
7139 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7141 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7142 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7144 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7146 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7148 * term.c (vfatal): Remove stray call to va_end.
7149 It's not needed and the C Standard doesn't allow it here anyway.
7151 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7152 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7154 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7157 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7159 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7161 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7163 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7165 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7167 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7168 * charset.c (Fdefine_charset_internal): Don't initialize
7169 charset.code_space[15]. The value was garbage, on hosts with
7170 32-bit int (Bug#8600).
7172 * lread.c (read_integer): Be more consistent with string-to-number.
7173 Use string_to_number to do the actual conversion; this avoids
7174 rounding errors and fixes some other screwups. Without this fix,
7175 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7176 (digit_to_number): Move earlier, for benefit of read_integer.
7177 Return -1 if the digit is out of range for the base, -2 if it is
7178 not a digit in any supported base. (Bug#8602)
7180 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7182 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7183 to match comment at start of function. This also removes a
7184 GCC warning about overflow in a 32+64-bit port.
7186 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7188 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7189 Reported by Stefan Monnier in
7190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7192 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7194 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7195 (EMACS_UINTPTR): Likewise, with uintptr_t.
7197 * lisp.h: Prefer 64-bit EMACS_INT if available.
7198 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7199 on 32-bit hosts that have 64-bit int, so that they can access
7201 However, temporarily disable this change unless the temporary
7202 symbol WIDE_EMACS_INT is defined.
7204 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7206 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7207 This removes an assumption that EMACS_INT and long are the same
7208 width as pointers. The assumption is true for Emacs porting targets
7209 now, but we want to make other targets possible.
7210 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7211 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7212 In the rest of the code, change types of integers that hold casted
7213 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7214 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7215 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7216 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7217 No need to cast type when ORing.
7218 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7219 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7220 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7221 assume EMACS_INT is the same width as char *.
7222 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7223 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7224 Remove no-longer-needed casts.
7225 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7226 (xg_tool_bar_help_callback, xg_make_tool_item):
7227 Use EMACS_INTPTR to hold an integer
7228 that will be cast to void *; this can avoid a GCC warning
7229 if EMACS_INT is not the same width as void *.
7230 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7231 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7232 (current_message_1, set_message_1):
7233 Use a local to convert to proper width without a cast.
7234 * xmenu.c (dialog_selection_callback): Likewise.
7236 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7237 Also, don't assume VALBITS / RAND_BITS is less than 5,
7238 and don't rely on undefined behavior when shifting a 1 left into
7240 * lisp.h (get_random): Change signature to match.
7242 * lread.c (hash_string): Use size_t, not int, for hash computation.
7243 Normally we prefer signed values; but hashing is special, because
7244 it's better to use unsigned division on hash table sizes so that
7245 the remainder is nonnegative. Also, size_t is the natural width
7246 for hashing into memory. The previous code used 'int', which doesn't
7247 retain enough info to hash well into very large tables.
7248 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7250 * dbusbind.c: Don't possibly lose pointer info when converting.
7251 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7252 Use XPNTR rather than XHASH, so that the high-order bits of
7253 the pointer aren't lost when converting through void *.
7255 * eval.c (Fautoload): Don't double-shift a pointer.
7257 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7259 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7261 * gnutls.c (DEF_GNUTLS_FN):
7262 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7264 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7266 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7269 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7271 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7272 New version that can reserve upto 2GB of heap space.
7274 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7276 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7278 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7280 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7281 `gnutls_certificate_set_x509_key_file'.
7283 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7285 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7286 Update dependencies.
7288 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7290 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7291 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7292 Remove unused parameter `fildes'.
7293 * process.c (read_process_output, send_process): Don't pass it.
7295 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7297 Fix previous change: the library cache is defined in w32.c.
7298 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7299 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7301 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7303 Implement dynamic loading of GnuTLS on Windows.
7305 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7306 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7307 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7310 * gnutls.c (Qgnutls_dll): Define.
7311 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7312 (gnutls_*): Declare function pointers.
7313 (init_gnutls_functions): New function to initialize function pointers.
7314 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7315 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7317 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7318 (emacs_gnutls_write, emacs_gnutls_read)
7319 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7320 (Fgnutls_available_p): New function.
7321 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7322 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7323 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7325 * image.c: Include w32.h.
7326 (Vimage_type_cache): Delete.
7327 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7328 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7329 (w32_delayed_load): Move to w32.c.
7331 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7333 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7334 (w32_delayed_load): Move from image.c. When loading a library, record
7335 its filename in the :loaded-from property of the library id.
7336 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7337 Initialize and staticpro them.
7338 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7340 * process.c: Include lisp.h before w32.h, not after.
7341 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7342 instead of gnutls_record_check_pending.
7344 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7346 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7348 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7349 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7352 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7354 * xterm.c (x_set_frame_alpha): Do not set property on anything
7355 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7357 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7359 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7361 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7363 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7364 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7365 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7366 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7367 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7368 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7369 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7370 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7371 (Qgnutls_bootprop_callbacks_verify): Make static.
7373 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7375 * callproc.c: Indentation fixup.
7377 * sysdep.c (wait_for_termination_1): Make static.
7378 (wait_for_termination, interruptible_wait_for_termination):
7379 Move after wait_for_termination_1.
7381 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7383 * sysdep.c (interruptible_wait_for_termination): New function
7384 which is like wait_for_termination, but allows keyboard
7387 * callproc.c (Fcall_process): Add (:file "file") as an option for
7389 (Fcall_process_region): Ditto.
7391 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7393 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7394 rather than `XVECTOR (FOO)->size'.
7396 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7397 inttypes.h, as a gnulib replacement is used if it not available in
7400 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7402 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7403 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7404 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7406 * coding.c (coding_alloc_by_realloc): Error out if destination
7407 will grow beyond MOST_POSITIVE_FIXNUM.
7408 (decode_coding_emacs_mule): Abort if there isn't enough place in
7409 charbuf for the composition carryover bytes. Reserve an extra
7410 space for up to 2 characters produced in a loop.
7411 (decode_coding_iso_2022): Abort if there isn't enough place in
7412 charbuf for the composition carryover bytes.
7414 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7416 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7417 aborting when %lld or %lll format is passed.
7418 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7419 %llo or %llx format is passed. (Bug#8545)
7421 * window.c (window_scroll_line_based): Use a marker instead of
7422 simple variables to record original value of point. (Bug#7952)
7424 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7425 produced by %s or %c overflows available buffer space. (Bug#8545)
7427 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7429 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7430 (SIZE_MAX): Move defn after all includes, as they might #define it.
7432 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7434 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7436 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7438 * keyboard.c (Qdelayed_warnings_hook): Define.
7439 (command_loop_1): Run `delayed-warnings-hook'
7440 if Vdelayed_warnings_list is non-nil.
7441 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7442 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7444 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7446 * doprnt.c (doprnt): Don't return value smaller than the buffer
7447 size if the message was truncated. (Bug#8545).
7449 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7451 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7452 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7454 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7456 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7458 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7460 * makefile.w32-in: Update dependencies.
7462 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7464 Improve `doprnt' and its usage. (Bug#8545)
7465 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7466 `format_end'. Remove support for %l as a conversion specifier.
7467 Don't use xrealloc. Improve diagnostics when the %l size modifier
7468 is used. Update the commentary.
7470 * eval.c (verror): Simplify calculation of size_t.
7472 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7475 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7477 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7480 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7482 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7483 This makes this file independent of the recent pseudovector change.
7485 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7487 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7489 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7490 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7491 Remove unused local.
7492 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7494 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7495 GCC 4.6.0 optimizes based on type-based alias analysis.
7496 For example, if b is of type struct buffer * and v of type struct
7497 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7498 != &v->size, and therefore "v->size = 1; b->size = 2; return
7499 v->size;" must therefore return 1. This assumption is incorrect
7500 for Emacs, since it type-puns struct Lisp_Vector * with many other
7501 types. To fix this problem, this patch adds a new type struct
7502 vectorlike_header that documents the constraints on layout of vectors
7503 and pseudovectors, and helps optimizing compilers not get fooled
7504 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7505 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7506 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7508 (XSETPVECTYPE): Rewrite in terms of new macro.
7509 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7510 This is a bit clearer, and further avoids the possibility of
7511 undesirable aliasing.
7512 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7513 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7514 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7515 since Lisp_Subr is a special case (no "next" field).
7516 (ASIZE): Now uses header.size rather than size.
7517 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7518 to avoid the hassle of writing XVECTOR (foo)->header.size.
7519 (struct vectorlike_header): New type.
7520 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7521 object, to help avoid aliasing.
7522 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7523 (SUBRP): Likewise, since Lisp_Subr is a special case.
7524 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7525 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7526 (struct Lisp_Hash_Table): Combine first two members into a single
7527 struct vectorlike_header member. All uses of "size" and "next" members
7528 changed to be "header.size" and "header.next".
7529 * buffer.h (struct buffer): Likewise.
7530 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7531 * frame.h (struct frame): Likewise.
7532 * process.h (struct Lisp_Process): Likewise.
7533 * termhooks.h (struct terminal): Likewise.
7534 * window.c (struct save_window_data, struct saved_window): Likewise.
7535 * window.h (struct window): Likewise.
7536 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7537 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7538 * buffer.c (init_buffer_once): Likewise.
7539 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7541 * process.c (Fformat_network_address): Use local var for size,
7544 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7546 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7547 * data.c (atof): Remove decl; no longer used or needed.
7548 (digit_to_number): Move to lread.c.
7549 (Fstring_to_number): Use new string_to_number function, to be
7550 consistent with how the Lisp reader treats infinities and NaNs.
7551 Do not assume that floating-point numbers represent EMACS_INT
7552 without losing information; this is not true on most 64-bit hosts.
7553 Avoid double-rounding errors, by insisting on integers when
7554 parsing non-base-10 numbers, as the documentation specifies.
7555 * lisp.h (string_to_number): New decl, replacing ...
7556 (isfloat_string): Remove.
7557 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7558 (read1): Do not accept +. and -. as integers; this
7559 appears to have been a coding error. Similarly, do not accept
7560 strings like +-1e0 as floating point numbers. Do not report
7561 overflow for integer overflows unless the base is not 10 which
7562 means we have no simple and reliable way to continue.
7563 Break out the floating-point parsing into a new
7564 function string_to_number, so that Fstring_to_number parses
7565 floating point numbers consistently with the Lisp reader.
7566 (digit_to_number): Move here from data.c. Make it static inline.
7567 (E_CHAR, EXP_INT): Remove, replacing with ...
7568 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7569 (string_to_number): New function, replacing isfloat_string.
7570 This function checks for valid syntax and produces the resulting
7571 Lisp float number too. Rework it so that string-to-number
7572 no longer mishandles examples like "1.0e+". Use strtoumax,
7573 so that overflow for non-base-10 numbers is reported only when
7574 there's no portable and simple way to convert to floating point.
7576 * textprop.c (set_text_properties_1): Rewrite for clarity,
7577 and to avoid GCC warning about integer overflow.
7579 * intervals.h (struct interval): Use EMACS_INT for members
7580 where EMACS_UINT might cause problems. See
7581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7582 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7583 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7585 (offset_intervals): Tell GCC not to worry about length overflow
7586 when negating a negative length.
7588 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7589 (overrun_check_free): Likewise.
7591 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7592 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7595 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7596 (gnutls_make_error): Rename local to avoid shadowing.
7597 (gnutls_emacs_global_deinit): ifdef out; not used.
7598 (Fgnutls_boot): Use const for pointer to readonly storage.
7599 Comment out unused local. Fix pointer signedness problems.
7601 * lread.c (openp): Don't stuff size_t into an 'int'.
7602 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7603 about possible signed overflow.
7605 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7606 (GDK_KEY_g): Don't define if already defined.
7607 (xg_prepare_tooltip): Avoid pointer signedness problem.
7608 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7610 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7611 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7613 * xfns.c (Fx_window_property): Simplify a bit,
7614 to make a bit faster and to avoid GCC 4.6.0 warning.
7615 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7617 * fns.c (internal_equal): Don't assume size_t fits in int.
7619 * alloc.c (compact_small_strings): Tighten assertion a little.
7621 Replace pEd with more-general pI, and fix some printf arg casts.
7622 * lisp.h (pI): New macro, generalizing old pEd macro to other
7623 conversion specifiers. For example, use "...%"pI"d..." rather
7624 than "...%"pEd"...".
7625 (pEd): Remove. All uses replaced with similar uses of pI.
7626 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7627 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7628 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7629 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7630 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7631 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7632 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7634 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7635 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7636 * print.c (safe_debug_print, print_object): Likewise.
7637 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7639 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7640 avoiding the 0 flag, which is not portable.
7641 * process.c (Fmake_network_process): Use pI to avoid cast.
7642 * region-cache.c (pp_cache): Likewise.
7643 * xdisp.c (decode_mode_spec): Likewise.
7644 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7645 behavior on 64-bit hosts with printf arg.
7646 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7647 (x_stop_queuing_selection_requests): Likewise.
7648 (x_get_window_property): Don't truncate byte count to an 'int'
7651 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7652 here, since it parses constructs like leading '-' and spaces,
7653 which are not wanted; and it overflows with large numbers.
7654 Instead, simply match F[0-9]+, which is what is wanted anyway.
7656 * alloc.c: Remove unportable assumptions about struct layout.
7657 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7658 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7659 (allocate_vectorlike, make_pure_vector): Use the new macros,
7660 plus offsetof, to remove unportable assumptions about struct layout.
7661 These assumptions hold on all porting targets that I know of, but
7662 they are not guaranteed, they're easy to remove, and removing them
7663 makes further changes easier.
7665 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7666 This doesn't fix a bug but makes the code clearer.
7667 (string_overrun_cookie): Now const. Use initializers that
7668 don't formally overflow signed char, to avoid warnings.
7669 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7670 can cause Emacs to crash when string overrun checking is enabled.
7671 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7672 multiple of sizeof (EMACS_INT); it need not be, if
7673 alignof(EMACS_INT) < sizeof (EMACS_INT).
7674 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7676 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7678 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7680 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7682 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7683 supposed to be handshaking. (Bug#8556)
7684 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7686 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7688 * lisp.h (Qdebug): List symbol.
7689 * eval.c (Qdebug): Restore global linkage.
7690 * keyboard.c (debug-on-event): New variable.
7691 (handle_user_signal): Break into debugger when debug-on-event
7692 matches the current signal symbol.
7694 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7696 * alloc.c (check_sblock, check_string_bytes)
7697 (check_string_free_list): Convert to standard C.
7699 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7701 * w32.c (emacs_gnutls_push): Fix typo.
7703 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7705 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7706 "cast to pointer from integer of different size".
7708 Improve doprnt and its use in verror. (Bug#8545)
7709 * doprnt.c (doprnt): Document the set of format control sequences
7710 supported by the function. Use SAFE_ALLOCA instead of always
7713 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7714 is one byte too soon. Don't use xrealloc; instead xfree and
7717 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7719 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7722 * gnutls.c: Renamed global_initialized to
7723 gnutls_global_initialized. Added internals for the
7724 :verify-hostname-error, :verify-error, and :verify-flags
7725 parameters of `gnutls-boot' and documented those parameters in the
7726 docstring. Start callback support.
7727 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7728 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7729 on error. Return error code.
7730 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7731 (emacs_gnutls_read): Likewise.
7732 (Fgnutls_boot): Return handshake error code.
7733 (emacs_gnutls_handle_error): New function.
7734 (wsaerror_to_errno): Likewise.
7736 * w32.h (emacs_gnutls_pull): Add prototype.
7737 (emacs_gnutls_push): Likewise.
7739 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7740 (emacs_gnutls_push): Likewise.
7742 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7744 * process.c (wait_reading_process_output): Check if GnuTLS
7745 buffered some data internally if no FDs are set for TLS
7748 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7749 (LIBS): Link to USER_LIBS.
7750 ($(BLD)/gnutls.$(0)): New target.
7752 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7754 * xdisp.c (handle_single_display_spec): Rename the
7755 display_replaced_before_p argument into display_replaced_p, to
7756 make it consistent with the commentary. Fix typos in the
7759 * textprop.c (syms_of_textprop): Remove dead code.
7760 (copy_text_properties): Delete obsolete commentary about an
7761 interface that was deleted long ago. Fix typos in the description
7764 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7765 to changes in oldXMenu/XMenu.h from 2011-04-16.
7766 <menu_help_message, prev_menu_help_message>: Constify.
7767 (IT_menu_make_room): menu->help_text is now `const char **';
7770 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7771 to changes in oldXMenu/XMenu.h from 2011-04-16.
7772 (struct XMenu): Declare `help_text' `const char **'.
7774 * xfaces.c <Qunspecified>: Make extern again.
7776 * syntax.c: Include sys/types.h before including regex.h, as
7779 * doc.c (get_doc_string): Improve the format passed to `error'.
7781 * doprnt.c (doprnt): Improve commentary.
7783 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7785 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7788 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7789 changes in globals.h immediately force recompilation.
7790 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7791 $(CURDIR)/s/ms-w32.h.
7792 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7794 * character.c (Fchar_direction): Function deleted.
7795 (syms_of_character): Don't defsubr it.
7796 <char-direction-table>: Deleted.
7798 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7800 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7801 * doprnt.c: Include limits.h.
7802 (SIZE_MAX): New macro.
7803 (doprnt): Return a size_t value. 2nd arg is now size_t.
7804 Many local variables are now size_t instead of int or unsigned.
7805 Improve overflow protection. Support `l' modifier for integer
7806 conversions. Support %l conversion. Don't assume an EMACS_INT
7807 argument for integer conversions and for %c.
7809 * lisp.h (doprnt): Restore prototype.
7811 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7814 * Makefile.in (base_obj): Add back doprnt.o.
7816 * deps.mk (doprnt.o): Add back prerequisites.
7817 (callint.o): Depend on character.h.
7819 * eval.c (internal_lisp_condition_case): Include the handler
7820 representation in the error message.
7821 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7822 when breaking from the loop.
7824 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7826 * callint.c (Fcall_interactively): When displaying error message
7827 about invalid control letter, pass the character's codepoint, not
7828 a pointer to its multibyte form. Improve display of the character
7829 in octal and display also its hex code.
7831 * character.c (char_string): Use %x to display the (unsigned)
7832 codepoint of an invalid character, to avoid displaying a bogus
7835 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7836 `error', not SYMBOL_NAME itself.
7838 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7839 character arguments to `error'.
7841 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7842 to `error' in error message about FINAL_CHAR argument. Make sure
7843 FINAL_CHAR is a character, and use %c when it is passed as
7844 argument to `error'.
7846 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7848 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7850 * w32.c: Include <time.h>.
7851 (sys_localtime): New function.
7853 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7855 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7857 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7859 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7861 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7864 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7866 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7867 gl_state.e_property when gl_state.object is Qt.
7869 * insdel.c (make_gap_larger): Remove limitation of buffer size
7872 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7874 * xdisp.c (lookup_glyphless_char_display)
7875 (produce_glyphless_glyph): Handle cons cell entry in
7876 glyphless-char-display.
7877 (Vglyphless_char_display): Document it.
7879 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7880 glyphless-char-display.
7882 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7884 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7886 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7888 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7889 definition for no-X builds.
7891 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7893 Static checks with GCC 4.6.0 and non-default toolkits.
7895 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7897 * process.c (keyboard_bit_set): Define only if SIGIO.
7898 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7899 (send_process): Repair possible setjmp clobbering.
7901 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7903 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7905 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7907 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7908 Define only if needed.
7910 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7911 by pacifying GCC about it. Maybe it's time to retire it?
7912 * xfaces.c (USG, __TIMEVAL__): Likewise.
7914 * dispextern.h (struct redisplay_interface): Rename param
7916 * termhooks.h (struct terminal): Likewise.
7917 * xterm.c (xembed_send_message): Likewise.
7919 * insdel.c (make_gap_smaller): Define only if
7920 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7922 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7925 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7926 so that we aren't warned about unused symbols.
7928 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7930 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7932 * xfns.c (x_real_positions): Mark locals as initialized.
7934 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7936 * xterm.c: Fix problems found by static analysis with other toolkits.
7937 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7938 (x_dispatch_event): Declare static if USE_GTK, and
7939 define if USE_GTK || USE_X_TOOLKIT.
7940 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7941 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7942 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7943 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7945 * xmenu.c (menu_help_callback): Pointer type fixes.
7946 Use const pointers when pointing at readonly data. Avoid pointer
7948 (FALSE): Remove unused macro.
7949 (update_frame_menubar): Remove unused decl.
7951 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7953 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7954 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7955 (single_menu_item): Rename local to avoid shadowing.
7957 * keyboard.c (make_lispy_event): Remove unused local var.
7959 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7960 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7962 * bitmaps: Change bitmaps from unsigned char back to the X11
7963 compatible char. Avoid the old compiler warnings about
7964 out-of-range initializers by using, for example, '\xab' rather
7967 * xgselect.c (xgselect_initialize): Check vs interface
7968 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7970 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7972 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7973 to read-only memory.
7975 * fns.c (vector): Remove; this old hack is no longer needed.
7977 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7979 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7981 * xrdb.c (x_load_resources): Omit unused local.
7983 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7984 (x_window): Rename locals to avoid shadowing.
7985 (USG): Use the kludged USG macro, to pacify gcc.
7987 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7988 (x_term_init): Remove local to avoid shadowing.
7990 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7992 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7993 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7995 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7997 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7999 Fix regex.c, syntax.c and friends for buffers > 2GB.
8000 * syntax.h (struct gl_state_s): Declare character position members
8003 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8005 * textprop.c (verify_interval_modification, interval_of):
8006 Declare arguments EMACS_INT.
8008 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8011 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8013 * indent.c (Fvertical_motion): Local variable it_start is now
8016 * regex.c (re_match, re_match_2, re_match_2_internal)
8017 (bcmp_translate, regcomp, regexec, print_double_string)
8018 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8019 (re_compile_pattern, re_exec): Declare arguments and local
8020 variables `size_t' and `ssize_t' and return values `regoff_t', as
8022 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8023 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8024 <compile_stack_type>: `size' and `avail' are now `size_t'.
8026 * regex.h <regoff_t>: Use ssize_t, not int.
8027 (re_search, re_search_2, re_match, re_match_2): Arguments that
8028 specify buffer/string position and length are now ssize_t and
8029 size_t. Return type is regoff_t.
8031 2011-04-16 Ben Key <bkey76@gmail.com>
8033 * nsfont.m: Fixed bugs in ns_get_family and
8034 ns_descriptor_to_entity that were caused by using free to
8035 deallocate memory blocks that were allocated by xmalloc (via
8036 xstrdup). This caused Emacs to crash when compiled with
8037 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8038 --enable-checking=xmallocoverrun). xfree is now used to
8039 deallocate these memory blocks.
8041 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8043 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8045 emacs_write: Accept and return EMACS_INT for sizes.
8046 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8048 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8049 Accept and return EMACS_INT.
8050 (emacs_gnutls_write): Return the number of bytes written on
8052 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8053 (emacs_read, emacs_write): Remove check for negative size, as the
8054 Emacs source code has been audited now.
8055 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8056 (emacs_read, emacs_write): Use it.
8057 * process.c (send_process): Adjust to the new signatures of
8058 emacs_write and emacs_gnutls_write. Do not attempt to store
8059 a byte offset into an 'int'; it might overflow.
8060 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8062 * sound.c: Don't assume sizes fit in 'int'.
8063 (struct sound_device.period_size, alsa_period_size):
8064 Return EMACS_INT, not int.
8065 (struct sound_device.write, vox_write, alsa_write):
8066 Accept EMACS_INT, not int.
8067 (wav_play, au_play): Use EMACS_INT to store sizes and to
8068 record read return values.
8070 2011-04-15 Ben Key <bkey76@gmail.com>
8072 * keyboard.c (Qundefined): Don't declare static since it is used
8074 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8075 static since they are used in nsfont.m.
8077 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8079 * process.c (Qprocessp): Don't declare static.
8080 * lisp.h (Qprocessp): Declare again.
8082 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8084 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8086 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8088 Improve C-level modularity by making more things 'static'.
8090 Don't publish debugger-only interfaces to other modules.
8091 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8092 (verify_bytepos, count_markers): Move decls to the only modules
8094 * region-cache.h (pp_cache): Likewise.
8095 * window.h (check_all_windows): Likewise.
8096 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8098 * sysdep.c (croak): Now static, if
8099 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8100 * syssignal.h (croak): Declare only if not static.
8102 * alloc.c (refill_memory_reserve): Now static if
8103 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8104 * lisp.h (refill_memory_reserve): Declare only if not static.
8106 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8107 Define only if USE_LUCID.
8109 * xrdb.c (x_customization_string, x_rm_string): Now static.
8111 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8112 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8114 * xdisp.c (draw_row_with_mouse_face): Now static.
8115 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8117 * window.h (check_all_windows): Mark externally visible.
8119 * window.c (window_deletion_count): Now static.
8121 * undo.c: Make symbols static if they're not exported.
8122 (last_undo_buffer, last_boundary_position, pending_boundary):
8125 * textprop.c (interval_insert_behind_hooks): Now static.
8126 (interval_insert_in_front_hooks): Likewise.
8128 * term.c: Make symbols static if they're not exported.
8129 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8130 (max_frame_lines, tty_set_terminal_modes):
8131 (tty_reset_terminal_modes, tty_turn_off_highlight):
8132 (get_tty_terminal): Now static.
8133 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8134 * termhooks.h (term_mouse_moveto): Do not declare if
8136 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8137 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8139 * sysdep.c: Make symbols static if they're not exported.
8140 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8142 (sigprocmask_set, full_mask): Remove; unused.
8143 (wait_debugging): Mark as visible.
8144 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8145 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8147 * syntax.c (syntax_temp): Define only if !__GNUC__.
8149 * sound.c (current_sound_device, current_sound): Now static.
8151 * search.c (searchbufs, searchbuf_head): Now static.
8153 * scroll.c (scroll_cost): Remove; unused.
8154 * dispextern.h (scroll_cost): Remove decl.
8156 * region-cache.h (pp_cache): Mark as externally visible.
8158 * process.c: Make symbols static if they're not exported.
8159 (process_tick, update_tick, create_process, chan_process):
8160 (Vprocess_alist, proc_buffered_char, datagram_access):
8161 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8162 (deactivate_process): Mark defn as static, as well as decl.
8163 * lisp.h (create_process): Remove decl.
8164 * process.h (chan_process, Vprocess_alist): Remove decls.
8166 * print.c: Make symbols static if they're not exported.
8167 (print_depth, new_backquote_output, being_printed, print_buffer):
8168 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8169 (print_interval, print_number_index, initial_stderr_stream):
8171 * lisp.h (Fprinc): Remove decl.
8172 (debug_output_compilation_hack): Mark as externally visible.
8174 * sysdep.c (croak): Move decl from here to syssignal.h.
8175 * syssignal.h (croak): Put it here, so the API can be checked when
8176 'croak' is called from dissociate_if_controlling_tty.
8178 * minibuf.c: Make symbols static if they're not exported.
8179 (minibuf_save_list, choose_minibuf_frame): Now static.
8180 * lisp.h (choose_minibuf_frame): Remove decl.
8182 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8184 * lread.c: Make symbols static if they're not exported.
8185 (read_objects, initial_obarray, oblookup_last_bucket_number):
8187 (make_symbol): Remove; unused.
8188 * lisp.h (initial_obarray, make_symbol): Remove decls.
8190 * keyboard.c: Make symbols static if they're not exported.
8191 (single_kboard, recent_keys_index, total_keys, recent_keys):
8192 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8193 (this_single_command_key_start, echoing, last_auto_save):
8194 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8195 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8196 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8197 (Vlispy_mouse_stem, double_click_count):
8199 (force_auto_save_soon): Define only if SIGDANGER.
8200 (ignore_mouse_drag_p): Now static if
8201 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8202 (print_help): Remove; unused.
8203 (stop_character, last_timer_event): Mark as externally visible.
8204 * keyboard.h (ignore_mouse_drag_p): Declare only if
8205 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8206 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8207 * lisp.h (echoing): Remove decl.
8208 (force_auto_save_soon): Declare only if SIGDANGER.
8209 * xdisp.c (redisplay_window): Simplify code, to make it more
8210 obvious that ignore_mouse_drag_p is not accessed if !defined
8211 USE_GTK && !defined HAVE_NS.
8213 * intervals.c: Make symbols static if they're not exported.
8214 (merge_properties_sticky, merge_interval_right, delete_interval):
8216 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8218 * insdel.c: Make symbols static if they're not exported.
8219 However, leave prepare_to_modify_buffer alone. It's never
8220 called from outside this function, but that appears to be a bug.
8221 (combine_after_change_list, combine_after_change_buffer):
8222 (adjust_after_replace, signal_before_change): Now static.
8223 (adjust_after_replace_noundo): Remove; unused.
8224 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8225 (signal_before_change): Remove decls.
8227 * indent.c (val_compute_motion, val_vmotion): Now static.
8229 * image.c: Make symbols static if they're not exported.
8230 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8232 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8233 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8235 * fringe.c (standard_bitmaps): Now static.
8236 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8238 * frame.c: Make symbols static if they're not exported.
8239 (x_report_frame_params, make_terminal_frame): Now static.
8240 (get_frame_param): Now static, unless HAVE_NS.
8241 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8242 (x_get_resource_string): Remove; not used.
8243 * frame.h (make_terminal_frame, x_report_frame_params):
8244 (x_get_resource_string); Remove decls.
8245 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8246 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8248 * font.c, fontset.c: Make symbols static if they're not exported.
8249 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8250 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8251 * font.c (font_close_object): Now static.
8252 * font.h (font_close_object): Remove.
8253 * fontset.c (FONTSET_OBJLIST): Remove.
8254 (free_realized_fontset) #if-0 the body, which does nothing.
8255 (face_suitable_for_char_p): #if-0, as it's never called.
8256 * fontset.h (face_suitable_for_char_p): Remove decl.
8257 * xfaces.c (face_at_string_position):
8258 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8259 since 0 is always ASCII.
8261 * fns.c (weak_hash_tables): Now static.
8263 * fileio.c: Make symbols static if they're not exported.
8264 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8265 (Vwrite_region_annotation_buffers): Now static.
8267 * eval.c: Make symbols static if they're not exported.
8268 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8269 * lisp.h (backtrace_list): Remove decl.
8271 * emacs.c: Make symbols static if they're not exported.
8272 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8273 (fatal_error_code, fatal_error_signal_hook, standard_args):
8275 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8276 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8277 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8278 * lisp.h (fatal_error_signal_hook): Remove decl.
8279 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8281 * editfns.c: Move a (normally-unused) function to its only use.
8282 * editfns.c, lisp.h (get_operating_system_release): Remove.
8283 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8284 worth the hassle of breaking this out.
8286 * xterm.c: Make symbols static if they're not exported.
8287 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8288 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8289 (x_destroy_window, x_delete_display):
8291 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8292 (x_mouse_leave): Remove; unused.
8293 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8294 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8295 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8297 (x_mouse_leave): Declare only if WINDOWSNT.
8298 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8299 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8302 * ftxfont.c: Make symbols static if they're not exported.
8303 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8305 * font.h (ftxfont_driver): Likewise.
8307 * xfns.c: Make symbols static if they're not exported.
8308 (x_last_font_name, x_display_info_for_name):
8309 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8310 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8311 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8312 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8313 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8314 (last_show_tip_args): Now static.
8315 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8316 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8317 (x_screen_planes): Remove; unused.
8318 * dispextern.h (x_screen_planes): Remove decl.
8320 * dispnew.c: Make symbols static if they're not exported.
8321 * dispextern.h (redraw_garbaged_frames, scrolling):
8322 (increment_row_positions): Remove.
8323 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8324 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8326 (redraw_garbaged_frames): Remove; unused.
8328 * xfaces.c: Make symbols static if they're not exported.
8329 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8331 * xterm.h (defined_color): Remove decls.
8332 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8333 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8334 (menu_face_changed_default, defined_color, free_realized_face):
8335 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8336 (ascii_face_of_lisp_face): Remove; unused.
8338 * xdisp.c: Make symbols static if they're not exported.
8339 * dispextern.h (scratch_glyph_row, window_box_edges):
8340 (glyph_to_pixel_coords, set_cursor_from_row):
8341 (get_next_display_element, set_iterator_to_next):
8342 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8343 (show_mouse_face): Remove decls
8344 * frame.h (message_buf_print): Likewise.
8345 * lisp.h (pop_message, set_message, check_point_in_composition):
8347 * xterm.h (set_vertical_scroll_bar): Likewise.
8348 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8349 (message_buf_print, scratch_glyph_row, displayed_buffer):
8350 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8351 (get_next_display_element, show_mouse_face, window_box_edges):
8352 (frame_to_window_pixel_xy, check_point_in_composition):
8353 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8354 (glyph_to_pixel_coords): Remove; unused.
8356 * dired.c (file_name_completion): Now static.
8358 * dbusbind.c (xd_in_read_queued_messages): Now static.
8360 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8361 * data.c (circular_list_error): Remove.
8363 * commands.h (last_point_position, last_point_position_buffer):
8364 (last_point_position_window): Remove decls.
8365 * keyboard.c: Make these variables static.
8367 * coding.h (coding, code_convert_region, encode_coding_gap):
8369 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8370 (iso_code_class, detect_coding, code_convert_region): Now static.
8371 (encode_coding_gap): Remove; unused.
8373 * chartab.c (chartab_chars, chartab_bits): Now static.
8375 * charset.h (charset_iso_8859_1): Remove decl.
8376 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8379 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8380 * ccl.c (Vccl_program_table): Now static.
8381 (check_ccl_update): Remove; unused.
8383 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8384 * category.h: ... from here.
8385 * category.c (check_category_table, set_category_set): Now static.
8387 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8388 * lisp.h: Remove these decls.
8390 * buffer.c (buffer_count): Remove unused var.
8392 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8393 so that it's not optimized away.
8394 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8395 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8396 exported only to the debugger.
8398 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8399 * atimer.h (run_all_atimers): Remove; not exported.
8401 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8402 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8403 was inaccessible from Lisp.
8404 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8405 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8407 alloc.c: Import and export fewer symbols, and remove unused items.
8408 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8410 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8411 it's not optimized away by whole-program optimization.
8412 (message_enable_multibyte, free_misc): Remove.
8413 (catchlist, handlerlist, mark_backtrace):
8414 Declare only if BYTE_MARK_STACK.
8415 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8416 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8417 (message_enable_multibyte): Remove decl.
8418 (free_misc, interval_free_list, float_block, float_block_index):
8419 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8420 (cons_free_list, last_marked_index):
8422 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8423 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8424 (mark_backtrace): Define only if BYTE_MARK_STACK.
8425 * xdisp.c (message_enable_multibyte): Now static.
8427 Declare Lisp_Object Q* variables to be 'static' if not exported.
8428 This makes it easier for human readers (and static analyzers)
8429 to see whether these variables are used from other modules.
8430 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8431 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8432 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8433 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8434 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8435 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8436 * xmenu.c, xselect.c:
8437 Declare Q* vars static if they are not used in other modules.
8438 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8439 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8440 Remove decls of unexported vars.
8441 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8443 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8445 Make Emacs functions such as Fatom 'static' by default.
8446 This makes it easier for human readers (and static analyzers)
8447 to see whether these functions can be called from other modules.
8448 DEFUN now defines a static function. To make the function external
8449 so that it can be used in other C modules, use the new macro DEFUE.
8450 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8451 (Finit_image_library):
8452 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8453 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8454 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8455 Remove decls, since these functions are now static.
8456 (Funintern, Fget_internal_run_time): New decls, since these functions
8457 were already external.
8459 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8460 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8461 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8462 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8463 * keyboard.c, keymap.c, lread.c:
8464 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8465 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8466 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8467 Mark functions with DEFUE instead of DEFUN,
8468 if they are used in other modules.
8469 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8470 decls for now-static functions.
8471 * buffer.h (Fdelete_overlay): Remove decl.
8472 * callproc.c (Fgetenv_internal): Mark as internal.
8473 * composite.c (Fremove_list_of_text_properties): Remove decl.
8474 (Fcomposition_get_gstring): New forward static decl.
8475 * composite.h (Fcomposite_get_gstring): Remove decl.
8476 * dired.c (Ffile_attributes): New forward static decl.
8477 * doc.c (Fdocumntation_property): New forward static decl.
8478 * eval.c (Ffetch_bytecode): New forward static decl.
8479 (Funintern): Remove extern decl; now in .h file where it belongs.
8480 * fileio.c (Fmake_symbolic_link): New forward static decl.
8481 * image.c (Finit_image_library): New forward static decl.
8482 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8483 * intervals.h (Fprevious_property_change):
8484 (Fremove_list_of_text_properties): Remove decls.
8485 * keyboard.c (Fthis_command_keys): Remove decl.
8486 (Fcommand_execute): New forward static decl.
8487 * keymap.c (Flookup_key): New forward static decl.
8488 (Fcopy_keymap): Now static.
8489 * keymap.h (Flookup_key): Remove decl.
8490 * process.c (Fget_process): New forward static decl.
8491 (Fprocess_datagram_address): Mark as internal.
8492 * syntax.c (Fsyntax_table_p): New forward static decl.
8493 (skip_chars): Remove duplicate decl.
8494 * textprop.c (Fprevious_property_change): New forward static decl.
8495 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8497 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8498 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8500 * editfns.c (Fformat): Remove unreachable code.
8502 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8504 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8507 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8509 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8510 when at ZV. (Bug#8487)
8512 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8514 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8516 * keyboard.c (parse_tool_bar_item): Likewise.
8517 * sound.c (sound_cleanup, alsa_close): Likewise.
8518 * termcap.c (tgetent): Likewise.
8519 * xfns.c (x_default_font_parameter): Likewise.
8520 * xsettings.c (read_and_apply_settings): Likewise.
8522 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8523 (overrun_check_free): Protoize.
8525 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8527 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8528 since callers should never pass a negative size.
8529 Change the signature to match that of plain 'read' and 'write'; see
8530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8531 * lisp.h: Update prototypes of emacs_write and emacs_read.
8533 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8535 * xdisp.c (redisplay_window): Don't try to determine the character
8536 position of the scroll margin if the window start point w->startp
8537 is outside the buffer's accessible region. (Bug#8468)
8539 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8541 Fix write-region and its subroutines for buffers > 2GB.
8542 * fileio.c (a_write, e_write): Modify declaration of arguments and
8543 local variables to support buffers larger than 2GB.
8544 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8546 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8547 argument, local variables, and return value.
8549 * lisp.h: Update prototypes of emacs_write and emacs_read.
8551 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8553 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8555 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8557 Fix more problems found by GCC 4.6.0's static checks.
8559 * xdisp.c (vmessage): Use a better test for character truncation.
8561 * charset.c (load_charset_map): <, not <=, for optimization,
8562 and to avoid potential problems with integer overflow.
8563 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8564 * casetab.c (set_identity, shuffle): Likewise.
8565 * editfns.c (Fformat): Likewise.
8566 * syntax.c (skip_chars): Likewise.
8568 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8569 This also lets GCC 4.6.0 generate slightly better loop code.
8571 * callint.c (Fcall_interactively): <, not <=, for optimization.
8572 (Fcall_interactively): Count the number of arguments produced,
8573 not the number of arguments given. This is simpler and lets GCC
8574 4.6.0 generate slightly better code.
8576 * ftfont.c: Distingish more carefully between FcChar8 and char.
8577 The previous code passed unsigned char * to a functions like
8578 strlen and xstrcasecmp that expect char *, which does not
8579 conform to the C standard.
8580 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8581 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8582 char * when the C standard requires it.
8584 * keyboard.c (read_char): Remove unused var.
8586 * eval.c: Port to Windows vsnprintf (Bug#8435).
8588 (SIZE_MAX): Define if the headers do not.
8589 (verror): Do not give up if vsnprintf returns a negative count.
8590 Instead, grow the buffer. This ports to Windows vsnprintf, which
8591 does not conform to C99. Problem reported by Eli Zaretskii.
8592 Also, simplify the allocation scheme, by avoiding the need for
8593 calling realloc, and removing the ALLOCATED variable.
8595 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8597 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8598 But keep the doprint source code for now, as we might revamp it
8599 and use it again (Bug#8435).
8600 * lisp.h (doprnt): Remove.
8601 * Makefile.in (base_obj): Remove doprnt.o.
8602 * deps.mk (doprnt.o): Remove.
8604 error: Print 32- and 64-bit integers portably (Bug#8435).
8605 Without this change, on typical 64-bit hosts error ("...%d...", N)
8606 was used to print both 32- and 64-bit integers N, which relied on
8608 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8609 * lisp.h (error, verror): Mark as printf-like functions.
8610 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8611 Report overflow in size calculations when allocating printf buffer.
8612 Do not truncate output string at its first null byte.
8613 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8614 Truncate the output at a character boundary, since vsnprintf does not
8616 * charset.c (check_iso_charset_parameter): Convert internal
8617 character to string before calling 'error', since %c now has the
8619 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8620 overflow when computing char to be passed to 'error'. Do not
8621 pass Lisp_Object to 'error'; pass the integer instead.
8622 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8623 formatted with plain %d.
8625 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8627 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8629 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8631 * xterm.c (x_catch_errors): Remove duplicate declaration.
8633 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8635 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8637 2011-04-10 Jim Meyering <meyering@redhat.com>
8639 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8640 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8641 return ssize_t not "int", and use size_t as the buffer length.
8642 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8643 * gnutls.h: Update declarations.
8644 * process.c (read_process_output): Use ssize_t, to match.
8645 (send_process): Likewise.
8647 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8649 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8651 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8653 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8654 Use unsigned char, to match FcChar8 type definition.
8656 * xterm.c (handle_one_xevent):
8657 * xmenu.c (create_and_show_popup_menu):
8658 * xselect.c (x_decline_selection_request)
8659 (x_reply_selection_request): Avoid type-punned deref of X events.
8661 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8663 Fix some uses of `int' instead of EMACS_INT.
8664 * search.c (string_match_1, fast_string_match)
8665 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8666 (scan_buffer, find_next_newline_no_quit)
8667 (find_before_next_newline, search_command, Freplace_match)
8668 (Fmatch_data): Make some `int' variables be EMACS_INT.
8670 * xdisp.c (display_count_lines): 3rd argument and return value now
8671 EMACS_INT. All callers changed.
8672 (pint2hrstr): Last argument is now EMACS_INT.
8674 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8675 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8676 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8677 (decode_coding_utf_16, decode_coding_emacs_mule)
8678 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8679 (decode_coding_ccl, decode_coding_charset)
8680 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8681 (decode_coding_iso_2022, decode_coding_emacs_mule)
8682 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8683 <char_offset, last_offset>: Declare EMACS_INT.
8684 (encode_coding_utf_8, encode_coding_utf_16)
8685 (encode_coding_emacs_mule, encode_invocation_designation)
8686 (encode_designation_at_bol, encode_coding_iso_2022)
8687 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8688 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8690 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8691 (encode_invocation_designation): Last argument P_NCHARS is now
8693 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8694 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8696 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8699 * ccl.c (Fccl_execute_on_string): Declare some variables
8702 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8704 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8706 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8708 * process.c (Fformat_network_address): Doc fix.
8710 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8712 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8714 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8716 * keyboard.c (read_char): Call Lisp function help-form-show,
8717 instead of using internal_with_output_to_temp_buffer.
8718 (Qhelp_form_show): New var.
8719 (syms_of_keyboard): Use DEFSYM macro.
8721 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8723 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8725 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8727 * process.c (Flist_processes): Remove to Lisp.
8728 (list_processes_1): Delete.
8730 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8732 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8734 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8736 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8738 Fix more problems found by GCC 4.6.0's static checks.
8740 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8742 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8744 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8746 * xdisp.c (vmessage): Mark as a printf-like function.
8748 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8750 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8752 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8753 printf-like functions.
8754 (tiff_load): Add casts to remove these marks before passing them
8755 to system-supplied API.
8757 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8759 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8760 This avoids several warnings with gcc -Wstrict-overflow.
8761 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8762 directly, rather than having caller test rule sign. This avoids
8763 some unnecessary tests.
8764 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8765 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8766 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8768 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8769 (xfont_open): Avoid unnecessary tests.
8771 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8773 * composite.h, composite.c (composition_gstring_put_cache):
8774 Use EMACS_INT, not int, for length.
8776 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8777 breaking out part of COMPOSITION_DECODE_RULE.
8778 (COMPOSITION_DECODE_RULE): Use it.
8779 * composite.c (get_composition_id): Remove unused local vars,
8780 by using the new macro.
8782 * textprop.c (set_text_properties_1): Change while to do-while,
8783 since the condition is always true at first.
8785 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8786 (interval_deletion_adjustment): Return unsigned value.
8789 * process.c (list_processes_1, create_pty, read_process_output):
8790 (exec_sentinel): Remove vars that were set but not used.
8791 (create_pty): Remove unnecessary "volatile"s.
8792 (Fnetwork_interface_info): Avoid possibility of int overflow.
8793 (read_process_output): Do adaptive read buffering even if carryover.
8794 (read_process_output): Simplify nbytes computation if buffered.
8796 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8798 * syntax.c (scan_words): Remove var that was set but not used.
8799 (update_syntax_table): Use unsigned instead of int.
8801 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8802 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8803 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8805 * print.c (print_error_message): Avoid int overflow.
8807 * font.c (font_list_entities): Redo for clarity,
8808 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8810 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8811 (font_score): Avoid potential overflow in diff calculation.
8813 * fns.c (substring_both): Remove var that is set but not used.
8814 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8816 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8818 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8819 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8820 can always succeed if overflow has undefined behavior.
8822 * search.c (boyer_moore, wordify): Remove vars set but not used.
8823 (wordify): Omit three unnecessary tests.
8825 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8826 All callers changed. This avoids the need for an unused var.
8828 * casefiddle.c (casify_region): Remove var that is set but not used.
8830 * dired.c (file_name_completion): Remove var that is set but not used.
8832 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8834 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8835 (Finsert_file_contents): Remove unnecessary code checking fd.
8837 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8838 Check for integer overflow on size calculations.
8840 * buffer.c (Fprevious_overlay_change): Remove var that is set
8843 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8844 Remove vars that are set but not used.
8845 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8846 (timer_check_2): Mark vars as initialized.
8848 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8850 * image.c (lookup_image): Remove var that is set but not used.
8851 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8853 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8854 that are set but not used.
8856 * xfns.c (make_invisible_cursor): Don't return garbage
8857 if XCreateBitmapFromData fails (Bug#8410).
8859 * xselect.c (x_get_local_selection, x_handle_property_notify):
8860 Remove vars that are set but not used.
8862 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8863 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8865 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8866 Remove var that is set but not used.
8867 (scroll_bar_windows_size): Now size_t, not int.
8868 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8871 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8872 (map_tty_color) [!defined MSDOS]: Likewise.
8874 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8876 * coding.c: Remove vars that are set but not used.
8877 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8878 All callers changed.
8879 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8880 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8881 (decode_coding_charset): Remove vars that are set but not used.
8883 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8884 that is set but not used.
8886 * print.c (print_object): Remove var that is set but not used.
8888 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8889 The gnulib version avoids calling malloc in the usual case,
8890 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8891 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8892 * filelock.c (current_lock_owner): Likewise.
8893 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8894 * sysdep.c: Include allocator.h, careadlinkat.h.
8895 (emacs_no_realloc_allocator): New static constant.
8896 (emacs_readlink): New function.
8897 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8898 ../lib/careadlinkat.h.
8900 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8902 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8903 first non-nil return value).
8905 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8907 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8908 if not defined (Bug#8403).
8910 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8912 * xdisp.c (display_count_lines): Remove parameter `start',
8913 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8914 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8915 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8916 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8917 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8918 and thereabouts. All callers changed.
8919 (get_per_char_metric): Remove parameter `f', unused since
8920 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8922 2011-04-02 Jim Meyering <meyering@redhat.com>
8924 do not dereference NULL upon failed strdup
8925 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8926 (ns_get_family): Likewise.
8928 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8930 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8932 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8934 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8937 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8939 Add lexical binding.
8941 * window.c (Ftemp_output_buffer_show): New fun.
8942 (Fsave_window_excursion):
8943 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8945 * lread.c (lisp_file_lexically_bound_p): New function.
8946 (Fload): Bind Qlexical_binding.
8947 (readevalloop): Remove `evalfun' arg.
8948 Bind Qinternal_interpreter_environment.
8949 (Feval_buffer): Bind Qlexical_binding.
8950 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8952 (syms_of_lread): Declare `lexical-binding'.
8954 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8956 * keyboard.c (eval_dyn): New fun.
8957 (menu_item_eval_property): Use it.
8959 * image.c (parse_image_spec): Use Ffunctionp.
8961 * fns.c (concat, mapcar1): Accept byte-code-functions.
8963 * eval.c (Fsetq): Handle lexical vars.
8964 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8965 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8966 (FletX, Flet): Obey lexical binding.
8967 (Fcommandp): Handle closures.
8968 (Feval): New `lexical' arg.
8969 (eval_sub): New function extracted from Feval. Use it almost
8970 everywhere where Feval was used. Look up vars in lexical env.
8972 (Ffunctionp): Move from subr.el.
8973 (Ffuncall): Handle closures.
8974 (apply_lambda): Remove `eval_flags'.
8975 (funcall_lambda): Handle closures and new byte-code-functions.
8976 (Fspecial_variable_p): New function.
8977 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8978 but without exporting it to Lisp.
8980 * doc.c (Fdocumentation, store_function_docstring):
8981 * data.c (Finteractive_form): Handle closures.
8983 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8986 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8988 (exec_byte_code): New function extracted from Fbyte_code to handle new
8989 calling convention for byte-code-functions. Add new byte-codes.
8991 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8993 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8995 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8997 * xdisp.c (redisplay_internal): Fix prototype.
8999 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9001 * xdisp.c (SCROLL_LIMIT): New macro.
9002 (try_scrolling): Use it when setting scroll_limit.
9003 Limit scrolling to 100 screen lines.
9004 (redisplay_window): Even when falling back on "recentering",
9005 position point in the window according to scroll-conservatively,
9006 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9008 (try_scrolling): When point is above the window, allow searching
9009 as far as scroll_max, or one screenful, to compute vertical
9010 distance from PT to the scroll margin position. This prevents
9011 try_scrolling from unnecessarily failing when
9012 scroll-conservatively is set to a value slightly larger than the
9013 window height. Clean up the case of PT below the margin at bottom
9014 of window: scroll_max can no longer be INT_MAX. When aggressive
9015 scrolling is in use, don't let point enter the opposite scroll
9016 margin as result of the scroll.
9017 (syms_of_xdisp) <scroll-conservatively>: Document the
9018 threshold of 100 lines for never-recentering scrolling.
9020 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9022 * dispextern.h (move_it_by_lines):
9023 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9024 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9025 (message_log_check_duplicate): Remove parameters `prev_bol' and
9026 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9027 (redisplay_internal): Remove parameter `preserve_echo_area',
9028 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9030 * indent.c (Fvertical_motion):
9031 * window.c (window_scroll_pixel_based, Frecenter):
9032 Don't pass `need_y_p' to `move_it_by_lines'.
9034 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9036 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9037 steal a few bits to be more compact.
9038 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9039 Remove unneeded casts.
9041 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9043 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9045 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9046 binding" message (bug#7967).
9048 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9050 Fix more problems found by GCC 4.6.0's static checks.
9052 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9053 Remove unused local var.
9055 * editfns.c (Fmessage_box): Remove unused local var.
9057 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9058 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9059 Omit unused local vars.
9060 * window.c (shrink_windows): Omit unused local var.
9061 * menu.c (digest_single_submenu): Omit unused local var.
9062 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9063 Omit unused local var.
9065 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9066 Don't assume string length fits in int.
9067 (keyremap_step, read_key_sequence): Use size_t for sizes.
9068 (read_key_sequence): Don't check last_real_key_start redundantly.
9070 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9071 instead of alloca (Bug#8344).
9073 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9074 (Fbacktrace_frame): Don't assume nframes fits in int.
9076 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9078 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9081 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9083 * cm.c (calccost): Turn while-do into do-while, for clarity.
9085 * keyboard.c (syms_of_keyboard): Use the same style as later
9086 in this function when indexing through an array. This also
9087 works around GCC bug 48267.
9089 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9091 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9093 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9094 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9096 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9097 This avoids undefined behavior on integer overflow, and is a bit
9098 more convenient anyway since it is compared to a size_t variable.
9100 Variadic C functions now count arguments with size_t, not int.
9101 This avoids an unnecessary limitation on 64-bit machines, which
9102 caused (substring ...) to crash on large vectors (Bug#8344).
9103 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9104 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9105 All variadic functions and their callers changed accordingly.
9106 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9107 * data.c (arith_driver, float_arith_driver): Likewise.
9108 * editfns.c (general_insert_function): Likewise.
9109 * eval.c (struct backtrace.nargs, interactive_p)
9110 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9111 (funcall_lambda, mark_backtrace): Likewise.
9112 * fns.c (concat): Likewise.
9113 * frame.c (x_set_frame_parameters): Likewise.
9114 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9115 0 if not found, not -1. All callers changed.
9117 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9118 (stack_copy_size): Now size_t, not int.
9119 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9121 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9123 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9124 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9125 All callers changed.
9127 * lisp.h (multibyte_char_to_unibyte):
9128 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9129 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9130 * character.h (CHAR_TO_BYTE8):
9131 * cmds.c (internal_self_insert):
9132 * editfns.c (general_insert_function):
9133 * keymap.c (push_key_description):
9134 * search.c (Freplace_match):
9135 * xdisp.c (message_dolog, set_message_1): All callers changed.
9137 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9139 * keyboard.c (safe_run_hook_funcall): New function.
9140 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9141 don't set the hook to nil, but remove the offending function instead.
9142 (Qcommand_hook_internal): Remove, unused.
9143 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9144 Vcommand_hook_internal.
9146 * eval.c (enum run_hooks_condition): Remove.
9147 (funcall_nil, funcall_not): New functions.
9148 (run_hook_with_args): Call each function through a `funcall' argument.
9149 Remove `cond' argument, now redundant.
9150 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9151 (Frun_hook_with_args_until_failure): Adjust accordingly.
9152 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9154 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9156 * dispextern.h (string_buffer_position): Remove declaration.
9158 * print.c (strout): Remove parameter `multibyte', unused since
9159 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9161 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9162 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9163 All callers changed.
9165 * w32.c (_wsa_errlist): Use braces for struct initializers.
9167 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9168 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9169 All callers changed.
9170 (string_buffer_position): Likewise. Also, make static (it's never
9171 used outside xdisp.c).
9172 (cursor_row_p): Remove parameter `w', unused since
9173 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9174 (decode_mode_spec): Remove parameter `precision', introduced during
9175 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9176 All callers changed.
9178 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9180 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9182 2011-03-27 Anders Lindgren <andlind@gmail.com>
9184 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9185 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9186 (ns_update_auto_hide_menu_bar): New functions.
9187 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9188 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9189 ns_constrain_all_frames.
9190 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9191 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9193 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9195 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9197 2011-03-27 Glenn Morris <rgm@gnu.org>
9199 * syssignal.h: Replace RETSIGTYPE with void.
9200 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9201 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9202 Replace SIGTYPE with void everywhere.
9203 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9204 * s/template.h (SIGTYPE): Remove commented out definition.
9206 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9208 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9209 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9211 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9213 * w32.c (read_unc_volume): Use parameter `henum', instead of
9214 global variable `wget_enum_handle'.
9216 * keymap.c (describe_vector): Remove parameters `indices' and
9217 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9218 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9220 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9222 * keyboard.c (timer_check): Remove parameter `do_it_now',
9223 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9224 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9225 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9227 * keyboard.c (read_char):
9228 * w32menu.c (w32_menu_display_help):
9229 * xmenu.c (show_help_event, menu_help_callback):
9230 Adjust calls to `show_help_echo'.
9232 * gtkutil.c (xg_maybe_add_timer):
9233 * keyboard.c (readable_events):
9234 * process.c (wait_reading_process_output):
9235 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9237 * insdel.c (adjust_markers_gap_motion):
9238 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9239 (gap_left, gap_right): Don't call it.
9241 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9243 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9244 incurred during fontification.
9246 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9248 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9249 (DEFVAR_PER_BUFFER): Don't pass it.
9251 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9252 (scrolling_window): Don't pass it.
9254 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9256 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9258 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9260 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9261 of variables specific to SELinux and computation of `encoded_absname'.
9263 * image.c (XPutPixel): Remove unused variable `height'.
9265 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9267 * unexw32.c (get_section_info): Remove unused variable `section'.
9269 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9270 (system_process_attributes): Remove unused variable `sess'.
9271 (sys_read): Remove unused variable `err'.
9273 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9274 (w32_wnd_proc): Remove unused variable `isdead'.
9275 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9276 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9277 (x_create_tip_frame): Remove unused variable `tem'.
9279 * w32inevt.c (w32_console_read_socket):
9280 Remove unused variable `no_events'.
9282 * w32term.c (x_draw_composite_glyph_string_foreground):
9283 Remove unused variable `width'.
9285 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9287 * w32term.c (x_set_glyph_string_clipping):
9288 Don't pass uninitialized region to CombineRgn.
9290 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9292 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9293 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9294 (Fx_close_connection): Remove unused variable `i'.
9296 * w32font.c (w32font_draw): Return number of glyphs.
9297 (w32font_open_internal): Remove unused variable `i'.
9298 (w32font_driver): Add missing initializer.
9300 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9301 (fill_in_menu): Remove unused variable `items_added'.
9303 * w32term.c (last_mouse_press_frame): Remove static global variable.
9304 (w32_clip_to_row): Remove unused variable `f'.
9305 (x_delete_terminal): Remove unused variable `i'.
9307 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9308 (NOTHING): Remove unused static global variable.
9309 (uniscribe_check_otf): Remove unused variable `table'.
9310 (uniscribe_font_driver): Add missing initializers.
9312 2011-03-23 Julien Danjou <julien@danjou.info>
9314 * term.c (Fsuspend_tty, Fresume_tty):
9315 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9316 * window.c (temp_output_buffer_show):
9317 * insdel.c (signal_before_change):
9318 * frame.c (Fhandle_switch_frame):
9319 * fileio.c (Fdo_auto_save):
9320 * emacs.c (Fkill_emacs):
9321 * editfns.c (save_excursion_restore):
9322 * cmds.c (internal_self_insert):
9323 * callint.c (Fcall_interactively):
9324 * buffer.c (Fkill_all_local_variables):
9325 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9327 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9328 unconditionally since it does the check itself.
9330 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9332 Fix more problems found by GCC 4.5.2's static checks.
9334 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9335 the first time through the loop, since we know p0 < p1 then.
9336 This also avoids a gcc -Wstrict-overflow warning.
9338 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9339 leading to a memory leak, possible in functions like
9340 load_charset_map_from_file that can allocate an unbounded number
9341 of objects (Bug#8318).
9343 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9344 that could (at least in theory) be that large.
9346 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9347 This is less likely to overflow, and avoids undefined behavior if
9348 overflow does occur. All callers changed. Use strtoul to scan
9349 for the unsigned long integer.
9350 (pint2hrstr): Simplify and tune code slightly.
9351 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9353 * scroll.c (do_scrolling): Work around GCC bug 48228.
9354 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9356 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9357 This also avoids a warning with gcc -Wstrict-overflow.
9358 (validate_x_resource_name): Simplify count usage.
9359 This also avoids a warning with gcc -Wstrict-overflow.
9361 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9364 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9366 * process.c (Fmake_network_process): Use socklen_t, not int,
9367 where POSIX says socklen_t is required in portable programs.
9368 This fixes a porting bug on hosts like 64-bit HP-UX, where
9369 socklen_t is wider than int (Bug#8277).
9370 (Fmake_network_process, server_accept_connection):
9371 (wait_reading_process_output, read_process_output):
9374 * process.c: Rename or move locals to avoid shadowing.
9375 (list_processes_1, Fmake_network_process):
9376 (read_process_output_error_handler, exec_sentinel_error_handler):
9377 Rename or move locals.
9378 (Fmake_network_process): Define label "retry_connect" only if needed.
9379 (Fnetwork_interface_info): Fix pointer signedness.
9380 (process_send_signal): Add cast to avoid pointer signedness problem.
9381 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9382 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9384 Make tparam.h and terminfo.c consistent.
9385 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9386 Include tparam.h instead, since it declares them.
9387 * cm.h (PC): Remove extern decl; tparam.h now does this.
9388 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9389 * terminfo.c: Include tparam.h, to check interfaces.
9390 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9391 (tparam): Adjust signature to match interface in tparam.h;
9392 this removes some undefined behavior. Check that outstring and len
9393 are zero, which they always are with Emacs.
9394 * tparam.h (PC, BC, UP): New extern decls.
9396 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9397 (xftfont_open): Rename locals to avoid shadowing.
9399 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9400 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9401 (OTF_TAG_SYM): Omit macro if not needed.
9402 (ftfont_list): Remove unused local.
9403 (get_adstyle_property, ftfont_pattern_entity):
9404 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9405 Rename locals to avoid shadowing.
9407 * xfont.c (xfont_list_family): Mark var as initialized.
9409 * xml.c (make_dom): Now static.
9411 * composite.c (composition_compute_stop_pos): Rename local to
9413 (composition_reseat_it): Remove unused locals.
9414 (find_automatic_composition, composition_adjust_point): Likewise.
9415 (composition_update_it): Mark var as initialized.
9416 (find_automatic_composition): Mark vars as initialized,
9417 with a FIXME (Bug#8290).
9419 character.h: Rename locals to avoid shadowing.
9420 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9421 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9422 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9423 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9426 * textprop.c (property_change_between_p): Remove; unused.
9428 * intervals.c (interval_start_pos): Now static.
9430 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9432 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9433 Rename locals to avoid shadowing.
9435 * sound.c (wav_play, au_play, Fplay_sound_internal):
9436 Fix pointer signedness.
9437 (alsa_choose_format): Remove unused local var.
9438 (wav_play): Initialize a variable to 0, to prevent undefined
9439 behavior (Bug#8278).
9441 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9443 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9445 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9446 clobbering (Bug#8298).
9447 * sysdep.c (sys_subshell): Likewise.
9448 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9450 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9451 This should get cleaned up, so that child_setup has the
9452 same signature on all platforms.
9454 * callproc.c (call_process_cleanup): Now static.
9455 (relocate_fd): Rename locals to avoid shadowing.
9457 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9459 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9460 not to be necessary, and produces flickering.
9462 2011-03-20 Glenn Morris <rgm@gnu.org>
9464 * config.in: Remove file.
9466 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9468 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9469 are now in src/globals.h.
9470 (syms_of_minibuf): Remove spurious & from previous change.
9472 2011-03-20 Leo Liu <sdl.web@gmail.com>
9474 * minibuf.c (completing-read-function): New variable.
9475 (completing-read-default): Rename from completing-read.
9476 (completing-read): Call completing-read-function.
9478 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9480 * xfaces.c (Fx_load_color_file):
9481 Read color file from absolute filename (bug#8250).
9483 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9485 * makefile.w32-in: Update dependencies.
9487 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9489 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9491 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9493 Fix more problems found by GCC 4.5.2's static checks.
9495 * process.c (make_serial_process_unwind, send_process_trap):
9496 (sigchld_handler): Now static.
9498 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9499 That way, the code declares only the vars that it needs.
9500 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9501 * s/cygwin.h (PTY_ITERATION): Likewise.
9502 * s/darwin.h (PTY_ITERATION): Likewise.
9503 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9505 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9506 * process.c (allocate_pty): Don't declare stb unless it's needed.
9508 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9509 (CONSTANTLIM): Remove; unused.
9510 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9511 Define only if needed.
9513 * unexelf.c (unexec): Name an expression,
9514 to avoid gcc -Wbad-function-cast warning.
9515 Use a different way to cause a compilation error if anyone uses
9516 n rather than nn, a way that does not involve shadowing.
9517 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9519 * deps.mk (unexalpha.o): Remove; unused.
9521 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9522 * unexec.h: New file.
9523 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9524 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9526 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9527 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9528 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9529 Change as necessary to match prototype in unexec.h.
9531 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9533 (back_comment, skip_chars): Mark vars as initialized.
9535 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9536 Rename locals to avoid shadowing.
9538 * lread.c (read1): Rewrite so as not to use empty "else".
9539 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9541 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9543 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9544 warning when compiling print.c.
9546 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9547 instead of using an uninitialized var.
9548 (font_sort_entities): Mark var as initialized.
9550 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9552 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9553 pointers to constants.
9554 (font_parse_fcname): Remove unused vars.
9555 (font_delete_unmatched): Now static.
9556 (font_get_spec): Remove; unused.
9557 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9558 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9559 Rename or move locals to avoid shadowing.
9561 * fns.c (require_nesting_list, require_unwind): Now static.
9562 (Ffillarray): Rename locals to avoid shadowing.
9564 * floatfns.c (domain_error2): Define only if needed.
9565 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9567 * alloc.c (mark_backtrace): Move decl from here ...
9568 * lisp.h: ... to here, so that it can be checked.
9570 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9571 (Fdefvar): Rewrite so as not to use empty "else".
9572 (lisp_indirect_variable): Name an expression,
9573 to avoid gcc -Wbad-function-cast warning.
9574 (Fdefvar): Rename locals to avoid shadowing.
9576 * callint.c (quotify_arg, quotify_args): Now static.
9577 (Fcall_interactively): Rename locals to avoid shadowing.
9578 Use const pointer when appropriate.
9580 * lisp.h (get_system_name, get_operating_system_release):
9581 Move decls here, to check interfaces.
9582 * process.c (get_operating_system_release): Move decl to lisp.h.
9583 * xrdb.c (get_system_name): Likewise.
9584 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9585 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9586 some of which prompt warnings from gcc -Wbad-function-cast.
9587 (Fformat_time_string, Fencode_time, Finsert_char):
9588 (Ftranslate_region_internal, Fformat):
9589 Rename or remove local vars to avoid shadowing.
9590 (Ftranslate_region_internal): Mark var as initialized.
9592 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9595 * lisp.h (eassert): Check that the argument compiles, even if
9596 ENABLE_CHECKING is not defined.
9598 * data.c (Findirect_variable): Name an expression, to avoid
9599 gcc -Wbad-function-cast warning.
9600 (default_value, arithcompare, arith_driver, arith_error): Now static.
9601 (store_symval_forwarding): Rename local to avoid shadowing.
9602 (Fmake_variable_buffer_local, Fmake_local_variable):
9603 Mark variables as initialized.
9604 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9606 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9607 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9608 Rename locals to avoid shadowing.
9609 (mark_stack): Move local variables into the #ifdef region where
9611 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9612 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9614 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9615 (GC_STRING_CHARS): Remove; not used.
9616 (Fmemory_limit): Cast sbrk's returned value to char *.
9618 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9619 avoids undefined behavior in theory.
9621 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9623 Use functions, not macros, for up- and down-casing (Bug#8254).
9624 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9625 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9626 to use the following functions instead of these macros.
9627 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9628 EMACS_INT, since callers assume the returned value fits in int.
9629 (upcase1): Likewise, for UPCASE_TABLE.
9630 (uppercasep, lowercasep, upcase): New static inline functions.
9631 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9632 the race-condition problem in the old DOWNCASE.
9634 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9635 Rename locals to avoid shadowing.
9636 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9637 (regex_compile, re_search_2, re_match_2_internal):
9638 Remove unused local vars.
9639 (FREE_VAR): Rewrite so as not to use empty "else",
9640 which gcc can warn about.
9641 (regex_compile, re_match_2_internal): Mark locals as initialized.
9642 (RETALLOC_IF): Define only if needed.
9643 (WORDCHAR_P): Likewise. This one is never needed, but is used
9644 only in a comment talking about a compiler bug, so put inside
9645 the #if 0 of that comment.
9646 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9647 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9650 * search.c (boyer_moore): Rename locals to avoid shadowing.
9651 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9652 (PREV_CHAR_BOUNDARY): Likewise.
9654 * search.c (simple_search): Remove unused var.
9656 * dired.c (compile_pattern): Move decl from here ...
9657 * lisp.h: ... to here, so that it can be checked.
9658 (struct re_registers): New forward decl.
9660 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9662 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9664 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9665 Rename locals to avoid shadowing.
9666 (Fvertical_motion): Mark locals as initialized.
9668 * casefiddle.c (casify_object, casify_region): Now static.
9669 (casify_region): Mark local as initialized.
9671 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9673 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9674 New macros, so that the caller can use some names other than
9675 gcpro1, gcpro2, etc.
9676 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9678 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9679 argument, for consistency with GCPRO2_VAR, etc: it is now the
9680 prefix of the variable, not the variable itself. All uses
9682 * dired.c (directory_files_internal, file_name_completion):
9683 Rename locals to avoid shadowing.
9685 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9686 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9687 dired.c's scmp function, had undefined behavior.
9688 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9689 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9690 * buffer.h: ... to here, because these macros use current_buffer,
9691 and the new implementation with inline functions needs to have
9692 current_buffer in scope now, rather than later when the macros
9694 (downcase, upcase1): New static inline functions.
9695 (DOWNCASE, UPCASE1): Reimplement using these functions.
9696 This avoids undefined behavior in expressions like
9697 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9698 from race conditions in accessing the global variables
9699 case_temp1 and case_temp2.
9700 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9701 * lisp.h (case_temp1, case_temp2): Remove their decls.
9702 * character.h (ASCII_CHAR_P): Move from here ...
9703 * lisp.h: ... to here, so that the inline functions mentioned
9706 * dired.c (directory_files_internal_unwind): Now static.
9708 * fileio.c (file_name_as_directory, directory_file_name):
9709 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9711 (file_name_as_directory): Use const pointers when appropriate.
9712 (Fexpand_file_name): Likewise. In particular, newdir might
9713 point at constant storage, so make it a const pointer.
9714 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9715 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9717 (Fset_file_times, Finsert_file_contents, auto_save_error):
9718 Rename locals to avoid shadowing.
9720 * minibuf.c (choose_minibuf_frame_1): Now static.
9721 (Ftry_completion, Fall_completions): Rename or remove locals
9724 * marker.c (bytepos_to_charpos): Remove; unused.
9726 * lisp.h (verify_bytepos, count_markers): New decls,
9727 so that gcc does not warn that these functions aren't declared.
9729 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9730 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9731 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9732 (copy_text): Remove unused local var.
9734 * filelock.c (within_one_second): Now static.
9735 (lock_file_1): Rename local to avoid shadowing.
9737 * buffer.c (fix_overlays_before): Mark locals as initialized.
9738 (fix_start_end_in_overlays): Likewise. This function should be
9739 simplified by using pointers-to-pointers, but that's a different
9741 (switch_to_buffer_1): Now static.
9742 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9743 (report_overlay_modification): Rename locals to avoid shadowing.
9745 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9746 Fix pointer signedness issue.
9747 (sys_subshell): Mark local as volatile if checking for lint,
9748 to suppress a gcc -Wclobbered warning that does not seem to be right.
9749 (MAXPATHLEN): Define only if needed.
9751 * process.c (serial_open, serial_configure): Move decls from here ...
9752 * systty.h: ... to here, so that they can be checked.
9754 * fns.c (get_random, seed_random): Move extern decls from here ...
9755 * lisp.h: ... to here, so that they can be checked.
9757 * sysdep.c (reset_io): Now static.
9758 (wait_for_termination_signal): Remove; unused.
9760 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9761 (copy_keymap_item, append_key, push_text_char_description):
9763 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9764 (DENSE_TABLE_SIZE): Remove; unused.
9765 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9766 (describe_map_tree):
9767 Rename locals to avoid shadowing.
9769 * keyboard.c: Declare functions static if they are not used elsewhere.
9770 (echo_char, echo_dash, cmd_error, top_level_2):
9771 (poll_for_input, handle_async_input): Now static.
9772 (read_char, kbd_buffer_get_event, make_lispy_position):
9773 (make_lispy_event, make_lispy_movement, apply_modifiers):
9774 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9775 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9776 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9777 (read_key_sequence, read_char): Mark locals as initialized.
9778 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9780 * keyboard.h (make_ctrl_char): New decl.
9781 (mark_kboards): Move decl here ...
9782 * alloc.c (mark_kboards): ... from here.
9784 * lisp.h (force_auto_save_soon): New decl.
9786 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9787 (DEFINE_DUMMY_FUNCTION): New macro.
9788 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9790 (main): Add casts to avoid warnings
9791 if GCC considers string literals to be constants.
9793 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9795 * dbusbind.c: Pointer signedness fixes.
9796 (xd_signature, xd_append_arg, xd_initialize):
9797 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9798 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9799 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9800 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9802 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9803 if GCC considers string literals to be constants.
9804 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9806 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9808 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9809 (print_preprocess, print_object): New macro to fix last change.
9811 * print.c (print_preprocess): Don't forget font objects.
9813 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9815 * emacs.c (USAGE3): Doc fixes.
9817 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9819 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9822 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9824 * lisp.h (VWindow_system, Qfile_name_history):
9825 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9826 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9827 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9829 * w32select.c: Don't #include "keyboard.h".
9830 (run_protected): Add extern declaration for waiting_for_input.
9832 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9833 * w32console.c (detect_input_pending, read_input_pending)
9834 (encode_terminal_code):
9835 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9836 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9837 (w32_system_caret_y, Qfile_name_history):
9838 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9839 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9840 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9841 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9842 * w32proc.c (Qlocal, report_file_error):
9843 * w32term.c (Vwindow_system, updating_frame):
9844 * w32uniscribe.c (initialized, uniscribe_font_driver):
9845 Remove unneeded extern declarations.
9847 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9849 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9851 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9853 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9854 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9855 These macros can no longer be used for assignment.
9857 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9858 Assign struct members directly, instead of using BUF_BEGV etc.
9859 (record_buffer_markers, fetch_buffer_markers): New functions for
9860 recording and fetching special buffer markers.
9861 (set_buffer_internal_1, set_buffer_temp): Use them.
9863 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9865 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9867 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9868 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9870 * xdisp.c (hscroll_window_tree):
9871 (reconsider_clip_changes): Use PT instead of BUF_PT.
9873 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9875 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9876 $(EMACS_ROOT)/lib/intprops.h.
9878 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9880 Fix more problems found by GCC 4.5.2's static checks.
9882 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9883 to unsigned char * to avoid compiler diagnostic.
9884 (xg_free_frame_widgets): Make it clear that a local variable is
9885 needed only if USE_GTK_TOOLTIP.
9886 (gdk_window_get_screen): Make it clear that this macro is needed
9887 only if USE_GTK_TOOLTIP.
9888 (int_gtk_range_get_value): New function, which avoids a diagnostic
9889 from gcc -Wbad-function-cast.
9890 (xg_set_toolkit_scroll_bar_thumb): Use it.
9891 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9892 diagnostic from gcc -Wbad-function-cast.
9893 (get_utf8_string, xg_get_file_with_chooser):
9894 Rename locals to avoid shadowing.
9895 (create_dialog): Move locals to avoid shadowing.
9897 * xgselect.c (xg_select): Remove unused var.
9899 * image.c (four_corners_best): Mark locals as initialized.
9900 (gif_load): Initialize transparent_p to zero (Bug#8238).
9901 Mark another local as initialized.
9902 (my_png_error, my_error_exit): Mark with NO_RETURN.
9904 * image.c (clear_image_cache): Now static.
9905 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9906 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9907 (x_edge_detection): Remove unnecessary cast that
9908 gcc -Wbad-function-cast diagnoses.
9909 (gif_load): Fix pointer signedness.
9910 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9911 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9913 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9915 Improve quality of tests for time stamp overflow.
9916 For example, without this patch (encode-time 0 0 0 1 1
9917 1152921504606846976) returns the obviously-bogus value (-948597
9918 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9919 reports time overflow. See
9920 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9921 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9922 * editfns.c: Include limits.h and intprops.h.
9923 (TIME_T_MIN, TIME_T_MAX): New macros.
9924 (time_overflow): Move earlier, to before first use.
9925 (hi_time, lo_time): New functions, for an accurate test for
9927 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9928 (Fget_internal_run_time): Don't assume time_t fits in int.
9929 (make_time): Use list2 instead of Fcons twice.
9930 (Fdecode_time): More accurate test for out-of-range times.
9931 (check_tm_member): New function.
9932 (Fencode_time): Use it, to test for out-of-range times.
9933 (lisp_time_argument): Don't rely on undefined left-shift and
9934 right-shift behavior when checking for time stamp overflow.
9936 * editfns.c (time_overflow): New function, refactoring common code.
9937 (Fformat_time_string, Fdecode_time, Fencode_time):
9938 (Fcurrent_time_string): Use it.
9940 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9941 * dired.c (make_time): Move to ...
9942 * editfns.c (make_time): ... here.
9943 * systime.h: Note the move.
9945 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9947 * fringe.c (update_window_fringes): Remove unused variables.
9949 * unexmacosx.c (copy_data_segment): Also copy __got section.
9952 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9954 * termcap.c [MSDOS]: Include "msdos.h".
9955 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9956 Constify `char *' arguments and their references according to
9957 prototypes in tparam.h.
9959 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9961 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9962 Adapt all references accordingly.
9964 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9966 2011-03-11 Tom Tromey <tromey@redhat.com>
9968 * buffer.c (syms_of_buffer): Remove obsolete comment.
9970 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9972 * termhooks.h (encode_terminal_code): Declare prototype.
9974 * msdos.c (encode_terminal_code): Don't declare prototype.
9976 * term.c (encode_terminal_code): Now external again, used by
9977 w32console.c and msdos.c.
9979 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9980 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9982 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9984 Fix some minor problems found by GCC 4.5.2's static checks.
9986 * fringe.c (update_window_fringes): Mark locals as initialized
9988 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9990 * alloc.c (mark_fringe_data): Move decl from here ...
9991 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9992 to check its interface.
9993 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9995 * fontset.c (free_realized_fontset): Now static.
9996 (Fset_fontset_font): Rename local to avoid shadowing.
9997 (fontset_font): Mark local as initialized.
9998 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10000 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10002 * xselect.c (x_disown_buffer_selections): Remove; not used.
10003 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10004 (x_own_selection, Fx_disown_selection_internal): Rename locals
10005 to avoid shadowing.
10006 (x_handle_dnd_message): Remove local to avoid shadowing.
10008 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10009 so that the caller can use some name other than gcpro1.
10010 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10011 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10012 (Fx_backspace_delete_keys_p):
10013 Use them to avoid shadowing, and rename vars to avoid shadowing.
10014 (x_decode_color, x_set_name, x_window): Now static.
10015 (Fx_create_frame): Add braces to silence GCC warning.
10016 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10017 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10018 Remove unused locals.
10019 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10020 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10021 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10024 * xterm.h (x_mouse_leave): New decl.
10026 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10027 Remove unused functions.
10028 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10029 (x_calc_absolute_position): Now static.
10030 (XTread_socket): Don't define label "out" unless it's used.
10031 Don't declare local "event" unless it's used.
10032 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10033 unless they are used.
10034 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10035 (x_fatal_error_signal): Remove; not used.
10036 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10037 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10038 (x_error_catcher, x_connection_closed, x_error_handler):
10039 (x_error_quitter, xembed_send_message, x_iconify_frame):
10040 (my_log_handler): Rename locals to avoid shadowing.
10041 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10042 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10044 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10045 Rename or move locals to avoid shadowing.
10046 (tty_defined_color, merge_face_heights): Now static.
10047 (free_realized_faces_for_fontset): Remove; not used.
10048 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10049 does not deduce is never used uninitialized.
10050 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10051 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10053 * terminal.c (store_terminal_param): Now static.
10055 * xmenu.c (menu_highlight_callback): Now static.
10056 (set_frame_menubar): Remove unused local.
10057 (xmenu_show): Rename parameter to avoid shadowing.
10058 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10059 since they might point to immutable storage.
10060 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10061 since it's unused otherwise.
10063 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10064 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10065 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10066 avoids a gcc -Wuninitialized diagnostic.
10067 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10068 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10069 does not deduce are never used uninitialized.
10071 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10073 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10074 * window.c (window_loop, size_window):
10075 (run_window_configuration_change_hook, enlarge_window): Likewise.
10077 * window.c (display_buffer): Now static.
10078 (size_window): Mark variables that gcc -Wuninitialized
10079 does not deduce are never used uninitialized.
10080 * window.h (check_all_windows): New decl, to forestall
10081 gcc -Wmissing-prototypes diagnostic.
10082 * dispextern.h (bidi_dump_cached_states): Likewise.
10084 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10086 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10087 Include <limits.h>.
10088 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10089 and to avoid gcc -Wuninitialized warning.
10090 (load_charset_map): Mark variables that gcc -Wuninitialized
10091 does not deduce are never used uninitialized.
10092 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10094 * coding.c (coding_set_source, coding_set_destination):
10095 Use "else { /* comment */ }" rather than "else /* comment */;"
10096 for clarity, and to avoid gcc -Wempty-body warning.
10097 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10098 a block, when the outer 'i' will do.
10099 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10100 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10101 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10102 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10103 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10104 Rename locals to avoid shadowing.
10105 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10106 * coding.c (emacs_mule_char, encode_invocation_designation):
10107 Now static, since they're not used elsewhere.
10108 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10109 (decode_coding_object, encode_coding_object, detect_coding_system):
10110 (decode_coding_emacs_mule): Mark variables that gcc
10111 -Wuninitialized does not deduce are never used uninitialized.
10112 (detect_coding_iso_2022): Initialize a local variable that might
10113 be used uninitialized. Leave a FIXME because it's not clear that
10114 this initialization is needed. (Bug#8211)
10115 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10116 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10117 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10118 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10119 Remove unused macros.
10121 * category.c (hash_get_category_set): Remove unused local var.
10122 (copy_category_table): Now static, since it's not used elsewhere.
10123 * character.c (string_count_byte8): Likewise.
10125 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10126 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10128 * chartab.c (copy_sub_char_table): Now static, since it's not used
10130 (sub_char_table_ref_and_range, char_table_ref_and_range):
10131 Rename locals to avoid shadowing.
10132 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10134 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10135 (BIDI_BOB): Remove unused macro.
10137 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10138 deduce are never used uninitialized.
10139 * term.c (encode_terminal_code): Likewise.
10141 * term.c (encode_terminal_code): Now static. Remove unused local.
10143 * tparam.h: New file.
10144 * term.c, tparam.h: Include it.
10145 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10146 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10147 Move these decls to tparam.h, and make them agree with what
10148 is actually in tparam.c. The previous trick of using incompatible
10149 decls in different modules does not conform to the C standard.
10150 All callers of tparam changed to use tparam's actual API.
10151 * tparam.c (tparam1, tparam, tgoto):
10152 Use const pointers where appropriate.
10154 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10155 * cm.h (struct cm): Likewise.
10156 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10157 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10158 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10159 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10160 (turn_on_face, init_tty): Likewise.
10161 * termchar.h (struct tty_display_info): Likewise.
10163 * term.c (term_mouse_position): Rename local to avoid shadowing.
10165 * alloc.c (mark_ttys): Move decl from here ...
10166 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10168 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10170 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10172 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10174 * search.c (compile_pattern_1): Remove argument regp, unused since
10175 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10176 (compile_pattern): Don't pass it.
10178 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10180 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10181 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10183 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10185 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10187 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10188 gdk_window_get_screen, gdk_window_get_geometry,
10189 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10190 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10191 (xg_get_pixbuf_from_pixmap): New function.
10192 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10193 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10194 Call xg_get_pixbuf_from_pixmap instead of
10195 gdk_pixbuf_get_from_drawable.
10196 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10197 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10198 (xg_check_special_colors): Use GtkStyleContext and its functions
10200 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10201 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10202 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10203 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10204 Call gtk_widget_get_preferred_size.
10205 (xg_frame_resized): gdk_window_get_geometry only takes 5
10207 (xg_win_to_widget, xg_event_is_for_menubar):
10208 Call gdk_x11_window_lookup_for_display.
10209 (xg_set_widget_bg): New function.
10210 (delete_cb): New function.
10211 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10212 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10213 (xg_set_background_color): Call xg_set_widget_bg.
10214 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10215 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10216 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10217 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10219 (update_frame_tool_bar): Call gtk_widget_hide.
10220 (xg_initialize): Use GDK_KEY_g.
10222 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10224 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10226 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10227 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10228 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10230 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10232 * w32xfns.c (select_palette): Check success of RealizePalette against
10233 GDI_ERROR, not zero.
10235 See ChangeLog.11 for earlier changes.
10237 ;; Local Variables:
10241 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10243 This file is part of GNU Emacs.
10245 GNU Emacs is free software: you can redistribute it and/or modify
10246 it under the terms of the GNU General Public License as published by
10247 the Free Software Foundation, either version 3 of the License, or
10248 (at your option) any later version.
10250 GNU Emacs is distributed in the hope that it will be useful,
10251 but WITHOUT ANY WARRANTY; without even the implied warranty of
10252 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10253 GNU General Public License for more details.
10255 You should have received a copy of the GNU General Public License
10256 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.