Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 Integer and memory overflow issues (Bug#9196).
4
5 * charset.c (charset_table_size)
6 (struct charset_sort_data.priority): Now ptrdiff_t.
7 (charset_compare): Don't overflow if priorities differ greatly.
8 (Fsort_charsets): Don't assume list length fits in int.
9 Check for size-calculation overflow when allocating sort data.
10 (syms_of_charset): Allocate an initial charset table that is
11 just under 64 KiB, to avoid problems with glibc malloc and mmap.
12
13 * cmds.c (internal_self_insert): Check for size-calculation overflow.
14
15 * composite.h (struct composition.glyph_len): Now int, not unsigned.
16 The actual value is always <= INT_MAX, and leaving it unsigned made
17 overflow checking harder.
18
19 * dispextern.h (struct glyph_matrix.rows_allocated)
20 (struct face_cache.size): Now ptrdiff_t, for convenience in use
21 with xpalloc. The values are still always <= INT_MAX.
22
23 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
24
25 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
26 (SAFE_NALLOCA): New macro.
27
28 * region-cache.c (struct boundary.pos, find_cache_boundary)
29 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
30 (set_cache_region, invalidate_region_cache)
31 (revalidate_region_cache, know_region_cache, region_cache_forward)
32 (region_cache_backward, pp_cache):
33 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
34 so that ptrdiff_t * can be passed to xpalloc.
35 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
36 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
37 (pp_cache): Don't assume cache_len fits in int.
38 * region-cache.h: Adjust extern decls to match.
39
40 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
41 EMACS_INT, since either will do, for xpalloc.
42
43 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
44 (xnmalloc, xnrealloc, xpalloc): New functions.
45
46 * bidi.c (bidi_shelve_header_size): New constant.
47 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
48 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
49
50 * buffer.c (overlays_at, overlays_in, record_overlay_string)
51 (overlay_strings):
52 Don't update size of array until after memory allocation succeeds,
53 because xmalloc/xrealloc may not return.
54 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
55 now that we have proper integer overflow checking.
56 (record_overlay_string, overlay_strings): Catch overflows when
57 calculating size of overlay_str_buf.
58
59 * callproc.c (Fcall_process): Check for size overflow when
60 calculating size of args2.
61 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
62 Normally we prefer signed values, but sticking with ptrdiff_t would
63 require adding more-complicated checks.
64
65 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
66 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
67 Redo buffer-overflow calculations to avoid integer overflow.
68 Add a FIXME comment where memory seems to be over-allocated.
69
70 * character.c (Fstring): Check for size-calculation overflow.
71
72 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
73 unnecessary integer overflow. Check for size overflow.
74 (encode_coding_object): Don't update size until xmalloc succeeds.
75
76 * composite.c (get_composition_id): Check for overflow in glyph
77 length calculations.
78
79 Integer and memory overflow fixes for display code.
80 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
81 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
82 (scrolling_window): Check for overflow in size calculations.
83 (line_draw_cost, realloc_glyph_pool, add_row_entry):
84 Don't assume glyph table len fits in int.
85 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
86 (row_table_size): Now ptrdiff_t, not int.
87 (scrolling_window): Avoid overflow in size calculations.
88 Don't update size until allocation succeeds.
89 * fns.c (concat): Check for overflow in size calculations.
90 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
91 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
92 (NEXT_ALMOST_PRIME_LIMIT): New constant.
93
94 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
95 (get_doc_string): Check for size calculation overflow.
96 Don't update size until allocation succeeds.
97 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
98 EMACS_INT, where ptrdiff_t will do.
99 (Fsubstitute_command_keys): Check for string overflow.
100
101 * editfns.c (set_time_zone_rule): Don't assume environment length
102 fits in int.
103 (message_length): Now ptrdiff_t, not int.
104 (Fmessage_box): Don't update size until allocation succeeds.
105 Don't assume message length fits in int.
106 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
107
108 * emacs.c (main): Do not reallocate argv, since there is a null at
109 the end that can be overwritten, and this way there's no need to
110 worry about size-calculation overflow.
111 (sort_args): Check for size-calculation overflow.
112
113 * eval.c (init_eval_once, grow_specpdl): Don't update size until
114 alloc succeeds.
115 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
116
117 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
118 (x_set_scroll_bar_width, x_figure_window_size):
119 Check for integer overflow.
120 (x_set_alpha): Do not assume XINT fits in int.
121
122 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
123 This is for the members text_lines, text_cols, total_lines, total_cols,
124 where the system imposes an 'int' limit.
125
126 * fringe.c (Fdefine_fringe_bitmap):
127 Don't update size until alloc works.
128
129 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
130 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
131
132 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
133 Check for size-calculation overflow.
134 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
135 do, as we prefer signed integers.
136 (id_to_widget.max_size, id_to_widget.used)
137 (xg_store_widget_in_map, xg_remove_widget_from_map)
138 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
139 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
140 Use and return ptrdiff_t, not int.
141 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
142 * gtkutil.h: Change prototypes to match the above.
143
144 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
145 are duplicate now that they've been promoted to lisp.h.
146 (x_allocate_bitmap_record, x_alloc_image_color)
147 (make_image_cache, cache_image, xpm_load):
148 Don't update size until alloc is done.
149 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
150 (x_detect_edges):
151 Check for size calculation overflow.
152 (ct_colors_allocated_max): New constant.
153 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
154 overflow.
155
156 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
157 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
158 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
159 Use ptrdiff_t, not int, to count maps.
160 (read_char_minibuf_menu_prompt): Check for overflow in size
161 calculations. Don't update size until allocation succeeds. Redo
162 calculations to avoid overflow.
163 * keyboard.h: Change prototypes to match the above.
164
165 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
166 to count maps.
167 (current_minor_maps): Check for size calculation overflow.
168 * keymap.h: Change prototypes to match the above.
169
170 * lread.c (read1, init_obarray): Don't update size until alloc done.
171
172 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
173 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
174
175 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
176 Now ptrdiff_t, not int.
177 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
178 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
179
180 * process.c (Fnetwork_interface_list): Check for overflow
181 in size calculation.
182
183 * region-cache.c (move_cache_gap): Check for size calculation overflow.
184
185 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
186 overflow. Don't bother calling xmalloc when xrealloc will do.
187
188 * search.c (Freplace_match): Check for size calculation overflow.
189 (Fset_match_data): Don't assume list lengths fit in 'int'.
190
191 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
192 for command line length. Do not attempt to address one before the
193 beginning of an array, as that's not portable.
194
195 * term.c (max_frame_lines): Remove; unused.
196 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
197 not int.
198 (encode_terminal_code, calculate_costs): Check for size
199 calculation overflow.
200 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
201 table lengths and related sizes. Don't update size until alloc
202 done. Redo calculations to avoid overflow.
203 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
204
205 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
206 subtracting pointers.
207 (gobble_line): Check for overflow more carefully. Don't update size
208 until alloc done.
209
210 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
211 Don't update size until alloc done.
212 Redo size calculations to avoid overflow.
213 Check for size calculation overflow.
214 (main) [DEBUG]: Fix typo in invoking tparam1.
215
216 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
217 Use ptrdiff_t, not int, for sizes.
218 (store_mode_line_noprop_char): Don't update size until alloc done.
219
220 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
221 Use ptrdiff_t, not int, for sizes.
222 (Finternal_make_lisp_face, cache_face):
223 Check for size calculation overflow.
224 (cache_face): Treat size calculation overflows as if they were
225 memory exhaustion (the usual treatment), rather than aborting.
226
227 * xfns.c (x_encode_text, x_set_name_internal)
228 (Fx_change_window_property): Use ptrdiff_t, not int, to count
229 sizes, since they can exceed INT_MAX in size. Check for size
230 calculation overflow.
231
232 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
233 (xg_select): Check for size calculation overflow.
234 Don't update size until alloc done.
235
236 * xrdb.c (get_environ_db): Don't assume path length fits in int,
237 as sprintf is limited to int lengths.
238
239 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
240 (X_LONG_MIN): New macros.
241 Use them to make the following changes clearer.
242 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
243 This change doesn't affect the value now, but it may help remind
244 future maintainers not to raise the value too much later.
245 (SELECTION_QUANTUM): Remove, replacing with ...
246 (selection_quantum): ... new function, which avoids overflow.
247 All uses changed.
248 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
249 assumption that selection length fits in 'int'.
250 (x_reply_selection_request, x_handle_selection_request)
251 (x_get_window_property, receive_incremental_selection)
252 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
253 (lisp_data_to_selection_data, clean_local_selection_data):
254 Use ptrdiff_t, not int, to record length of selection.
255 (x_reply_selection_request, x_get_window_property)
256 (receive_incremental_selection, x_property_data_to_lisp):
257 Redo calculations to avoid overflow.
258 (x_reply_selection_request): When sending hint, ceiling it at
259 X_LONG_MAX rather than relying on wraparound overflow to send
260 something.
261 (x_get_window_property, receive_incremental_selection)
262 (lisp_data_to_selection_data, x_property_data_to_lisp):
263 Check for size-calculation overflow.
264 (x_get_window_property, receive_incremental_selection)
265 (lisp_data_to_selection_data, Fx_register_dnd_atom):
266 Don't store size until memory allocation succeeds.
267 (x_get_window_property): Plug memory leak on memory exhaustion.
268 Don't double-block input; malloc is safe here. Don't assume 2**34
269 - 4 fits in unsigned long. Add an xassert to check
270 XGetWindowProperty overflow. Be more careful about overflow
271 calculations, and distinguish size from memory overflow better.
272 (receive_incremental_selection): When tracing, don't assume
273 unsigned int is less than INT_MAX.
274 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
275 harmful) conversions of unsigned short to int.
276 (lisp_data_to_selection_data): Don't assume that integers
277 in the range -65535 through -1 fit in an X unsigned short.
278 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
279 result parameters unless successful. Rely on cons_to_unsigned
280 to report problems with elements; the old code wasn't right anyway.
281 (x_check_property_data): Check for int overflow; we cannot use
282 a wider type due to X limits.
283 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
284
285 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
286
287 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
288 (x_term_init): Check for size calculation overflow.
289 (x_color_cells): Don't store size until memory allocation succeeds.
290 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
291 Don't assume alloca size is less than MAX_ALLOCA.
292 (x_term_init): Don't assume length fits in int (sprintf is limited
293 to int size).
294
295 Use ptrdiff_t for composition IDs.
296 * character.c (lisp_string_width):
297 * composite.c (composition_table_size, n_compositions)
298 (get_composition_id, composition_gstring_from_id):
299 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
300 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
301 * window.c (Frecenter):
302 Use ptrdiff_t, not int, for composition IDs.
303 * composite.c (get_composition_id): Check for integer overflow.
304 * composite.h: Adjust prototypes to match the above changes.
305
306 Use ptrdiff_t for hash table indexes.
307 * category.c (hash_get_category_set):
308 * ccl.c (ccl_driver):
309 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
310 * coding.c (coding_system_charset_list, detect_coding_system):
311 * coding.h (struct coding_system.id):
312 * composite.c (get_composition_id, gstring_lookup_cache):
313 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
314 * image.c (xpm_get_color_table_h):
315 * lisp.h (hash_lookup, hash_put):
316 * minibuf.c (Ftest_completion):
317 Use ptrdiff_t for hash table indexes, not int (which is too
318 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
319 32-bit --with-wide-int hosts).
320
321 * charset.c (Fdefine_charset_internal): Check for integer overflow.
322 Add a FIXME comment about memory leaks.
323 (syms_of_charset): Don't assume xmalloc returns.
324
325 Don't assume that stated character widths fit in int.
326 * character.c (Fchar_width, c_string_width, lisp_string_width):
327 * character.h (CHAR_WIDTH):
328 * indent.c (MULTIBYTE_BYTES_WIDTH):
329 Use sanitize_char_width to avoid undefined and/or bad behavior
330 with outlandish widths.
331 * character.h (sanitize_tab_width): Renamed from sanitize_width,
332 now that we have two such functions. All uses changed.
333 (sanitize_char_width): New inline function.
334
335 Don't assume that tab-width fits in int.
336 * character.h (sanitize_width): New inline function.
337 (SANE_TAB_WIDTH): New macro.
338 (ASCII_CHAR_WIDTH): Use it.
339 * indent.c (sane_tab_width): Remove. All uses replaced by
340 SANE_TAB_WIDTH (current_buffer).
341 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
342
343 * fileio.c: Integer overflow issues with file modes.
344 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
345
346 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
347 Remove unreachable code.
348 (read_hex, load_charset_map_from_file): Check for integer overflow.
349
350 * xterm.c: don't go over XClientMessageEvent limit
351 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
352 (x_send_scroll_bar_event): Likewise. Check that the size does not
353 exceed limits imposed by XClientMessageEvent, as well as the usual
354 ptrdiff_t and size_t limits.
355
356 * keyboard.c: Overflow, signedness and related fixes.
357 (make_lispy_movement): Use same integer type in forward decl
358 that is used in the definition.
359 (read_key_sequence, keyremap_step):
360 Change bufsize argument back to int, undoing my 2011-03-30 change.
361 We prefer signed types, and int is wide enough here.
362 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
363 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
364 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
365 length, not size_t. Use ptrdiff_t for index, not int.
366 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
367 possibility of integer overflow.
368
369 Overflow, signedness and related fixes for images.
370
371 * dispextern.h (struct it.stack[0].u.image.image_id)
372 (struct_it.image_id, struct image.id, struct image_cache.size)
373 (struct image_cache.used, struct image_cache.ref_count):
374 * gtkutil.c (update_frame_tool_bar):
375 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
376 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
377 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
378 * nsmenu.m (update_frame_tool_bar):
379 * xdisp.c (calc_pixel_width_or_height):
380 * xfns.c (image_cache_refcount):
381 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
382 on typical 64-bit hosts.
383
384 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
385 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
386 Omit unnecessary casts to int.
387 (parse_image_spec): Check that integers fall into 'int' range
388 when the callers expect that.
389 (image_ascent): Redo ascent calculation to avoid int overflow.
390 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
391 (lookup_image): Remove unnecessary tests.
392 (xbm_image_p): Locals are now of int, not EMACS_INT,
393 since parse_image_check makes sure they fit into int.
394 (png_load, gif_load, svg_load_image):
395 Prefer int to unsigned where either will do.
396 (tiff_handler): New function, combining the cores of the
397 old tiff_error_handler and tiff_warning_handler. This
398 function is rewritten to use vsnprintf and thereby avoid
399 stack buffer overflows. It uses only the features of vsnprintf
400 that are common to both POSIX and native Microsoft.
401 (tiff_error_handler, tiff_warning_handler): Use it.
402 (tiff_load, gif_load, imagemagick_load_image):
403 Don't assume :index value fits in 'int'.
404 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
405 (imagemagick_load_image): Check that crop parameters fit into
406 the integer types that MagickCropImage accepts. Don't assume
407 Vimagemagick_render_type has a nonnegative value. Don't assume
408 size_t fits in 'long'.
409 (gs_load): Use printmax_t to print the widest integers possible.
410 Check for integer overflow when computing image height and width.
411
412 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
413
414 * bidi.c (bidi_initialize): Remove unused local.
415
416 2011-08-15 Eli Zaretskii <eliz@gnu.org>
417
418 * biditype.h: File removed.
419
420 * bidimirror.h: File removed.
421
422 * deps.mk (bidi.o): Remove biditype.h and
423 bidimirror.h.
424
425 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
426 bidimirror.h.
427
428 * dispextern.h: Fix a typo in the comment to bidi_type_t.
429
430 * chartab.c: Improve commentary for the uniprop_table API.
431
432 * bidi.c (bidi_paragraph_init): Support zero value of
433 bidi_ignore_explicit_marks_for_paragraph_level.
434 (bidi_initialize): Use uniprop_table instead of including
435 biditype.h and bidimirror.h.
436
437 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
438 coordinates of the iterator when restoring from ppos_it.
439 (Bug#9296)
440
441 2011-08-14 Kenichi Handa <handa@m17n.org>
442
443 * process.c (create_process): Call setup_process_coding_systems
444 after the pid of the process is set to -1.
445
446 2011-08-14 Eli Zaretskii <eliz@gnu.org>
447
448 * xdisp.c (move_it_in_display_line_to): Don't invoke
449 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
450 ppos_it. Fixes vertical cursor motion when line beginning is
451 covered by an image. (Bug#9296)
452
453 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
454
455 * nsterm.h (ns_run_ascript): Declare.
456 (NSAPP_DATA2_RUNASSCRIPT): Define.
457
458 * nsfns.m (as_script, as_result, as_status): New static variables.
459 (ns_run_ascript): New function.
460 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
461 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
462 the event loop. Get status from as_status (Bug#7276).
463
464 * nsterm.m (sendEvent): If event is NSApplicationDefined and
465 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
466 the event loop (Bug#7276).
467
468 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
469
470 * gnutls.c (QCgnutls_bootprop_priority)
471 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
472 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
473 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
474 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
475 (QCgnutls_bootprop_verify_hostname_error)
476 (QCgnutls_bootprop_callbacks_verify): Rename from
477 Qgnutls_bootprop_..., all uses changed.
478
479 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
480 uses changed.
481
482 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
483
484 * xfaces.c (Qframe_set_background_mode): Now static.
485 * dispextern.h (Qframe_set_background_mode): Remove decl.
486
487 * process.c (Fnetwork_interface_info): Declare local only if needed.
488
489 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
490
491 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
492 (Fnetwork_interface_list): Allocate in increments of bytes instead
493 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
494 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
495 sockaddr.
496 (struct ifflag_def): notrailers is smart on OSX.
497 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
498 Get hardware address with getifaddrs if available.
499
500 2011-08-12 Eli Zaretskii <eliz@gnu.org>
501
502 * xdisp.c (iterate_out_of_display_property): xassert that
503 IT->position is set to within IT->object's boundaries. Break from
504 the loop as soon as EOB is reached; avoids infloops in redisplay
505 when IT->position is set up wrongly due to some bug. Set
506 IT->current to match the bidi iterator unconditionally.
507 (push_display_prop): Allow GET_FROM_STRING as IT->method on
508 entry. Force push_it to save on the stack the current
509 buffer/string position, to be restored by pop_it. Fix flags in
510 the iterator structure wrt the object coming from a display
511 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
512 properties. (Bug#9284)
513
514 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
515
516 * fontset.c (fontset_get_font_group): Add proper type checks.
517 (Bug#9172)
518
519 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
520
521 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
522 and LC_VERSION_MIN_MACOSX.
523 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
524 (dump_it) [LC_FUNCTION_STARTS]: Use it.
525
526 2011-08-08 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (forward_to_next_line_start): Allow to use the
529 no-display-properties-and-no-overlays under bidi display. Set
530 disp_pos in the bidi iterator to avoid searches for display
531 properties and overlays.
532
533 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
534
535 * editfns.c (Fset_time_zone_rule): Document relationship with the
536 setenv function.
537
538 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
539 the font entity extracted from the cache (Bug#8109).
540
541 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
542
543 * composite.c (autocmp_chars): Don't reset point. That is done by
544 restore_point_unwind (Bug#5984).
545
546 2011-08-07 Juri Linkov <juri@jurta.org>
547
548 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
549 to show the arg `TIME' instead of `TIMEVAL'.
550
551 2011-08-06 Eli Zaretskii <eliz@gnu.org>
552
553 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
554 display property strides EOL and includes a newline, as in
555 longlines-mode. (Bug#9254)
556 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
557 word-wrap under bidirectional display. (Bug#9224)
558
559 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
560 is non-zero, even if the data buffer is NULL. Fixes a crash in
561 vertical-motion with longlines-mode. (Bug#9254)
562
563 2011-08-05 Eli Zaretskii <eliz@gnu.org>
564
565 * bidi.c <bidi_cache_total_alloc>: Now static.
566 (bidi_initialize): Initialize bidi_cache_total_alloc.
567
568 *xdisp.c (display_line): Release buffer allocated for shelved bidi
569 cache. (Bug#9221)
570
571 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
572 amount allocated this far in `bidi_cache_total_alloc'.
573 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
574 non-zero, only free the data buffer without restoring the cache
575 contents. All callers changed.
576
577 * dispextern.h (bidi_unshelve_cache): Update prototype.
578
579 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
580 (move_it_in_display_line, move_it_to)
581 (move_it_vertically_backward, move_it_by_lines): Replace the call
582 to xfree to an equivalent call to bidi_unshelve_cache.
583 (move_it_in_display_line_to): Fix logic of returning
584 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
585
586 2011-08-05 Eli Zaretskii <eliz@gnu.org>
587
588 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
589 came from a string character with a `cursor' property. (Bug#9229)
590
591 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
592
593 * Makefile.in (LIB_PTHREAD): New variable.
594 (LIBES): Add LIB_PTHREAD (Bug#9216).
595
596 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
597 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
598
599 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
600
601 * regex.c (re_iswctype): Remove some redundant boolean
602 conversions.
603
604 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
605
606 * xterm.c (x_find_topmost_parent): New function.
607 (x_set_frame_alpha): Find topmost parent window with
608 x_find_topmost_parent and set the property there also (bug#9181).
609 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
610
611 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
612
613 * callproc.c (Fcall_process): Avoid vfork clobbering
614 the local vars buffer, coding_systems, current_dir.
615
616 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
617
618 * keymap.c (Fmake_composed_keymap): Move to subr.el.
619
620 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
621
622 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
623 so that it is not optimized away.
624
625 * xdisp.c (compute_display_string_pos): Remove unused local.
626
627 2011-08-02 Eli Zaretskii <eliz@gnu.org>
628
629 Fix slow cursor motion and scrolling in large buffers with
630 selective display, like Org Mode buffers. (Bug#9218)
631
632 * dispextern.h (struct bidi_it): New member disp_prop_p.
633
634 * xdisp.c: Remove one-slot cache of display string positions.
635 (compute_display_string_pos): Accept an additional argument
636 DISP_PROP_P; callers changed. Scan at most 5K characters forward
637 for a display string or property. If found, set DISP_PROP_P
638 non-zero.
639
640 * bidi.c (bidi_fetch_char): Accept an additional argument
641 DISP_PROP_P, and pass it to compute_display_string_pos.
642 Only handle text covered by a display string if DISP_PROP_P is returned
643 non-zero. All callers of bidi_fetch_char changed.
644
645 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
646
647 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
648
649 2010-12-03 Don March <don@ohspite.net>
650
651 * keymap.c (Fdefine_key): Fix non-prefix key error message when
652 last character M-[char] is translated to ESC [char] (bug#7541).
653
654 2011-08-02 Kenichi Handa <handa@m17n.org>
655
656 * lisp.h (uniprop_table): Extern it.
657
658 * chartab.c (uniprop_table): Make it non-static.
659
660 2011-08-01 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (forward_to_next_line_start): Accept additional argument
663 BIDI_IT_PREV, and store into it the state of the bidi iterator had
664 on the newline.
665 (reseat_at_next_visible_line_start): Use the bidi iterator state
666 returned by forward_to_next_line_start to restore the state of
667 it->bidi_it after backing up to previous newline. (Bug#9212)
668
669 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
670
671 * regex.c (re_comp): Protoize.
672 (re_exec): Fix return type.
673 (regexec): Fix type of `ret'. (Bug#9203)
674
675 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
676
677 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
678 This is needed if max-image-size is a floating-point number.
679
680 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
681
682 * print.c (print_object): Print empty symbol as ##.
683
684 * lread.c (read1): Read ## as empty symbol.
685
686 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
687
688 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
689 setting frame foreground color (Bug#9175).
690 (x_set_background_color): Likewise.
691
692 * nsmenu.m (-setText): Size tooltip dimensions precisely to
693 contents (Bug#9176).
694 (EmacsTooltip -init): Remove bezels and add shadows to
695 tooltip windows.
696
697 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
698 or scroll bar (Bug#8470).
699
700 * nsfont.m (nsfont_open): Remove assignment to voffset and
701 unnecessary vars hshink, expand, hd, full_height, min_height.
702 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
703
704 * nsterm.h (nsfont_info): Remove voffset field.
705
706 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
707
708 Implement strike-through and overline on NextStep (Bug#8863).
709
710 * nsfont.m (nsfont_open): Use underline position provided by font,
711 instead of hard-coded value of 2.
712 (nsfont_draw): Call ns_draw_text_decoration instead.
713
714 * nsterm.h: Add declaration for ns_draw_text_decoration.
715
716 * nsterm.m (ns_draw_text_decoration): New function for drawing
717 underline, overline, and strike-through.
718 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
719 ns_draw_text_decoration. Change treatment of cursor drawing to
720 accomodate underlining, etc.
721
722 2011-07-28 Eli Zaretskii <eliz@gnu.org>
723
724 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
725 default.
726
727 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
728
729 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
730 Without this fix, if a signal arrives just after memory fills up,
731 'malloc' might be invoked reentrantly.
732
733 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
734 In other words, assume that every image size is allowed, on non-X
735 hosts. This assumption is probably wrong, but it lets Emacs compile.
736
737 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
738
739 * regex.c (re_iswctype): Convert return values to boolean.
740
741 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
742
743 * xdisp.c (compute_display_string_pos): Don't use cached display
744 string position if the buffer had its restriction changed.
745 (Bug#9184)
746
747 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
748
749 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
750
751 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
752
753 Integer signedness and overflow and related fixes. (Bug#9079)
754
755 * bidi.c: Integer size and overflow fixes.
756 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
757 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
759 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
760 (bidi_find_other_level_edge):
761 Use ptrdiff_t instead of EMACS_INT where either will do.
762 This works better on 32-bit hosts configured --with-wide-int.
763 (bidi_cache_ensure_space): Check for size-calculation overflow.
764 Use % rather than repeated addition, for better worst-case speed.
765 Don't set bidi_cache_size until after xrealloc returns, because it
766 might not return.
767 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
768 (bidi_cache_ensure_space): Also check that the bidi cache size
769 does not exceed that of the largest Lisp string or buffer. See Eli
770 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
771
772 * alloc.c (__malloc_size_t): Remove.
773 All uses replaced by size_t. See Andreas Schwab's note
774 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
775
776 * image.c: Improve checking for integer overflow.
777 (check_image_size): Assume that f is nonnull, since
778 it is always nonnull in practice. This is one less thing to
779 worry about when checking for integer overflow later.
780 (x_check_image_size): New function, which checks for integer
781 overflow issues inside X.
782 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
783 This removes the need for a memory_full check.
784 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
785 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
786 (xbm_read_bitmap_data): Change locals back to 'int', since
787 their values must fit in 'int'.
788 (xpm_load_image, png_load, tiff_load):
789 Invoke x_create_x_image_and_pixmap earlier,
790 to avoid much needless work if the image is too large.
791 (tiff_load): Treat overly large images as if
792 x_create_x_image_and_pixmap failed, not as malloc failures.
793 (gs_load): Use x_check_image_size.
794
795 * gtkutil.c: Omit integer casts.
796 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
797 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
798
799 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
800
801 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
802 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
803 would wrongly return t on a 64-bit host.
804
805 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
806 The plain *_OVERFLOW macros run afoul of GCC bug 49705
807 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
808 and therefore cause GCC to emit a bogus diagnostic in some cases.
809
810 * image.c: Integer signedness and overflow and related fixes.
811 This is not an exhaustive set of fixes, but it's time to
812 record what I've got.
813 (lookup_pixel_color, check_image_size): Remove redundant decls.
814 (check_image_size): Don't assume that arbitrary EMACS_INT values
815 fit in 'int', or that arbitrary 'double' values fit in 'int'.
816 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
817 (tiff_load, imagemagick_load_image):
818 Check for overflow in size calculations.
819 (x_create_x_image_and_pixmap): Remove unnecessary test for
820 xmalloc returning NULL; that can't happen.
821 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
822 (xpm_color_bucket): Use better integer hashing function.
823 (xpm_cache_color): Don't possibly over-allocate memory.
824 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
825 (gif_memory_source):
826 Use ptrdiff_t, not int or size_t, to record sizes.
827 (png_load): Don't assume values greater than 2**31 fit in 'int'.
828 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
829 either works, as we prefer signed integers.
830 (tiff_read_from_memory, tiff_write_from_memory):
831 Return tsize_t, not size_t, since that's what the TIFF API wants.
832 (tiff_read_from_memory): Don't fail simply because the read would
833 go past EOF; instead, return a short read.
834 (tiff_load): Omit no-longer-needed casts.
835 (Fimagemagick_types): Don't assume size fits into 'int'.
836
837 Improve hashing quality when configured --with-wide-int.
838 * fns.c (hash_string): New function, taken from sxhash_string.
839 Do not discard information about ASCII character case; this
840 discarding is no longer needed.
841 (sxhash-string): Use it. Change sig to match it. Caller changed.
842 * lisp.h: Declare it.
843 * lread.c (hash_string): Remove, since we now use fns.c's version.
844 The fns.c version returns a wider integer if --with-wide-int is
845 specified, so this should help the quality of the hashing a bit.
846
847 * emacs.c: Integer overflow minor fix.
848 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
849 Define only if GNU_LINUX.
850 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
851
852 * dispnew.c: Integer signedness and overflow fixes.
853 Remove unnecessary forward decls, that were a maintenance hassle.
854 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
855 All uses changed.
856 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
857 (scrolling_window): Use ptrdiff_t, not int, for byte count.
858 (prepare_desired_row, line_draw_cost):
859 Use int, not unsigned, where either works.
860 (save_current_matrix, restore_current_matrix):
861 Use ptrdiff_t, not size_t, where either works.
862 (init_display): Check for overflow more accurately, and without
863 relying on undefined behavior.
864
865 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
866 Remove, replacing with the new symbols in lisp.h. All uses changed.
867 * fileio.c (make_temp_name):
868 * filelock.c (lock_file_1, lock_file):
869 * xdisp.c (message_dolog):
870 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
871 Use pMd etc. instead.
872 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
873 replacing the pWIDE etc. symbols removed from editfns.c.
874
875 * keyboard.h (num_input_events): Now uintmax_t.
876 This is (very slightly) less likely to mess up due to wraparound.
877 All uses changed.
878
879 * buffer.c: Integer signedness fixes.
880 (alloc_buffer_text, enlarge_buffer_text):
881 Use ptrdiff_t rather than size_t when either will do, as we prefer
882 signed integers.
883
884 * alloc.c: Integer signedness and overflow fixes.
885 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
886 (__malloc_size_t): Default to size_t, not to int.
887 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
888 (Fgarbage_collect, mark_object_loop_halt, mark_object):
889 Prefer ptrdiff_t to size_t when either would do, as we prefer
890 signed integers.
891 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
892 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
893 Now const. Initialize with values that are in range even if char
894 is signed.
895 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
896 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
897 These functions do the right thing with sizes > 2**32.
898 (check_depth): Now ptrdiff_t, not int.
899 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
900 Adjust to new way of storing sizes. Check for size overflow bugs
901 in rest of code.
902 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
903 slightly wrong anyway, as it missed one instance of
904 XMALLOC_OVERRUN_CHECK_OVERHEAD.
905 (refill_memory_reserve): Omit needless cast to size_t.
906 (mark_object_loop_halt): Mark as externally visible.
907
908 * xselect.c: Integer signedness and overflow fixes.
909 (Fx_register_dnd_atom, x_handle_dnd_message):
910 Use ptrdiff_t, not size_t, since we prefer signed.
911 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
912 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
913 x_dnd_atoms_size and x_dnd_atoms_length.
914
915 * doprnt.c: Prefer signed to unsigned when either works.
916 * eval.c (verror):
917 * doprnt.c (doprnt):
918 * lisp.h (doprnt):
919 * xdisp.c (vmessage):
920 Use ptrdiff_t, not size_t, when using or implementing doprnt,
921 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
922 prefer signed arithmetic to avoid comparison confusion.
923 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
924 but is a bit tricky.
925
926 Assume freestanding C89 headers, string.h, stdlib.h.
927 * data.c, doprnt.c, floatfns.c, print.c:
928 Include float.h unconditionally.
929 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
930 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
931 * regex.c: Likewise for stddef.h, string.h.
932 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
933 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
934 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
935 (STDC_HEADERS): Remove obsolete defines.
936 * sysdep.c: Include limits.h unconditionally.
937
938 Assume support for memcmp, memcpy, memmove, memset.
939 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
940 * regex.c (memcmp, memcpy):
941 Remove; we assume C89 now.
942
943 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
944 (__malloc_safe_bcopy): Remove; no longer needed.
945
946 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
947 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
948 well either way, and we prefer signed to unsigned.
949
950 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
951
952 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
953 closes the connection while we're reading (bug#9182).
954
955 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
956
957 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
958 are specified (Bug#9168).
959
960 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
961
962 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
963 Found by GCC static checking and --with-wide-int on a 32-bit host.
964
965 2011-07-25 Eli Zaretskii <eliz@gnu.org>
966
967 * xdisp.c (compute_display_string_pos): Fix logic of caching
968 previous display string position. Initialize cached_prev_pos to
969 -1. Fixes slow-down at the beginning of a buffer.
970
971 2011-07-24 Eli Zaretskii <eliz@gnu.org>
972
973 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
974 for attrs[LFACE_FONTSET_INDEX].
975
976 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
977
978 * xml.c (parse_region): Remove unused local
979 that was recently introduced.
980
981 2011-07-23 Eli Zaretskii <eliz@gnu.org>
982
983 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
984 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
985
986 * xdisp.c (move_it_in_display_line_to): Record the best matching
987 position for TO_CHARPOS while scanning the line, and restore it on
988 exit if none of the characters scanned was an exact match.
989 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
990 when exact match is impossible due to invisible text, and the
991 lines are truncated.
992
993 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
994
995 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
996 for OSX >= 10.7.
997
998 2011-07-22 Eli Zaretskii <eliz@gnu.org>
999
1000 Fix a significant slow-down of cursor motion with C-n, C-p,
1001 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1002 auto-repeat under bidi redisplay in fontified buffers.
1003 * xdisp.c (compute_stop_pos_backwards): New function.
1004 (next_element_from_buffer): Call compute_stop_pos_backwards to
1005 find a suitable prev_stop when we find ourselves before
1006 base_level_stop.
1007 (reseat): Don't look for prev_stop, as that could mean a very long
1008 run.
1009 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1010 <cached_disp_overlay_modiff>: Cache for last found display string
1011 position.
1012 (compute_display_string_pos): Return the cached position if asked
1013 about the same buffer in the same area of character positions, and
1014 the buffer wasn't changed since the time the display string
1015 position was cached.
1016
1017 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1020 is an integer, which is important for empty lines. (Bug#9149)
1021
1022 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1023
1024 * frame.c (Fmodify_frame_parameters): In tty case, update the
1025 default face if necessary (Bug#4238).
1026
1027 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1028
1029 * editfns.c (Fstring_to_char): No need to explain what a character
1030 is in the docstring (Bug#6576).
1031
1032 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1033
1034 * xml.c (parse_region): Make sure we always return a tree.
1035
1036 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1037
1038 * xml.c (parse_region): If a document contains only comments,
1039 return that, too.
1040
1041 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1042
1043 * xml.c (make_dom): Return comments, too.
1044
1045 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 Port to OpenBSD.
1048 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1049 and the surrounding thread.
1050 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1051 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1052 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1053 timer goes off.
1054 * s/openbsd.h (BROKEN_SIGIO): Define.
1055 * unexelf.c (unexec) [__OpenBSD__]:
1056 Don't update the .mdebug section of the Alpha COFF symbol table.
1057
1058 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1059
1060 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1061 (bug#8460).
1062
1063 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1066 This fixes some race conditions on the permissions of any newly
1067 created file.
1068
1069 * alloc.c (valid_pointer_p): Use pipe, not open.
1070 This fixes some permissions issues when debugging.
1071
1072 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1073 If fchown fails to set both uid and gid, try to set just gid,
1074 as that is sometimes allowed. Adjust the file's mode to eliminate
1075 setuid or setgid bits that are inappropriate if fchown fails.
1076
1077 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1080 to compare Lisp_Objects.
1081 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1082 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1083 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1084
1085 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1086
1087 * lread.c (read_integer): Unread even EOF character.
1088 (read1): Likewise. Properly record start position of symbol.
1089
1090 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1091 symbol character follows.
1092
1093 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1096 This works around a problem with the previous change to Fcopy_file.
1097 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1098 and without this change, GCC might complain about discarding
1099 fchown's return value.
1100
1101 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1102
1103 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1104
1105 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1108
1109 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1110
1111 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1112 it's used from the C level.
1113
1114 * process.c: Use the same condition for POLL_FOR_INPUT in both
1115 keyboard.c and process.c (bug#1858).
1116
1117 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1118
1119 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1120 (Fgnutls_boot): Use it.
1121
1122 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * doc.c (Fsubstitute_command_keys): Revert last change.
1125
1126 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1127
1128 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1129 quotes the next character, and doesn't affect other longer
1130 sequences (bug#8935).
1131
1132 * lread.c (syms_of_lread): Clarify that is isn't only
1133 `eval-buffer' and `eval-defun' that's affected by
1134 `lexical-binding' (bug#8460).
1135
1136 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1137
1138 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1139 bidi redisplay when a line includes both an image and is
1140 truncated.
1141
1142 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 Fix minor problems found by static checking.
1145 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1146 (elsz): Now a signed constant, not a size_t var. We prefer signed
1147 types to unsigned, to avoid integer comparison confusion. Without
1148 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1149 "cannot optimize loop, the loop counter may overflow", a symptom
1150 of the confusion.
1151 * indent.c (Fvertical_motion): Mark locals as initialized.
1152 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1153
1154 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1155
1156 * search.c (Fre_search_backward): Mention `case-fold-search' in
1157 all the re_search_* functions (bug#8138).
1158
1159 * keyboard.c (Fopen_dribble_file): Document when the file is
1160 closed (bug#8056).
1161
1162 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1163
1164 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1165 bidi_cache_idx.
1166
1167 Support bidi reordering of display and overlay strings.
1168 * xdisp.c (compute_display_string_pos)
1169 (compute_display_string_end): Accept additional argument STRING.
1170 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1171 (reseat_to_string): Initialize bidi_it->string.s and
1172 bidi_it->string.schars.
1173 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1174 NULL (avoids a crash in bidi_paragraph_init).
1175 Initialize itb.string.lstring.
1176 (init_iterator): Call bidi_init_it only of a valid
1177 buffer position was specified. Initialize paragraph_embedding to
1178 L2R.
1179 (reseat_to_string): Initialize the bidi iterator.
1180 (display_string): If we need to ignore text properties of
1181 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1182 original value of -1 will not work with bidi.)
1183 (compute_display_string_pos): First arg is now struct
1184 `text_pos *'; all callers changed. Support display properties on
1185 Lisp strings.
1186 (compute_display_string_end): Support display properties on Lisp
1187 strings.
1188 (init_iterator, reseat_1, reseat_to_string): Initialize the
1189 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1190 when iterating on a string not from display properties).
1191 (compute_display_string_pos, compute_display_string_end):
1192 Fix calculation of the object to scan. Fixes an error when using
1193 arrow keys.
1194 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1195 base_level_stop; instead, set base_level_stop to BEGV.
1196 Fixes crashes in vertical-motion.
1197 (next_element_from_buffer): Improve commentary for when
1198 the iterator is before prev_stop.
1199 (init_iterator): Initialize bidi_p from the default value of
1200 bidi-display-reordering, not from buffer-local value. Use the
1201 buffer-local value only if initializing for buffer iteration.
1202 (handle_invisible_prop): Support invisible properties on strings
1203 that are being bidi-reordered.
1204 (set_iterator_to_next): Support bidi reordering of C strings and
1205 Lisp strings.
1206 (next_element_from_string): Support bidi reordering of Lisp
1207 strings.
1208 (handle_stop_backwards): Support Lisp strings as well.
1209 (display_string): Support display of R2L glyph rows.
1210 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1211 (init_iterator): Don't initialize it->bidi_p for strings
1212 here.
1213 (reseat_to_string): Initialize it->bidi_p for strings here.
1214 (next_element_from_string, next_element_from_c_string)
1215 (next_element_from_buffer): Add xassert's for correspondence
1216 between IT's object being iterated and it->bidi_it.string
1217 structure.
1218 (face_before_or_after_it_pos): Support bidi iteration.
1219 (next_element_from_c_string): Handle the case of the first string
1220 character that is not the first one in the visual order.
1221 (get_visually_first_element): New function, refactored from common
1222 parts of next_element_from_buffer, next_element_from_string, and
1223 next_element_from_c_string.
1224 (tool_bar_lines_needed, redisplay_tool_bar)
1225 (display_menu_bar): Force left-to-right direction. Add a FIXME
1226 comment for making that be controlled by a user option.
1227 (push_it, pop_it): Save and restore the state of the
1228 bidi iterator. Save and restore the bidi_p flag.
1229 (pop_it): Iterate out of display property for string iteration as
1230 well.
1231 (iterate_out_of_display_property): Support iteration over strings.
1232 (handle_single_display_spec): Set up it->bidi_it for iteration
1233 over a display string, and call bidi_init_it.
1234 (handle_single_display_spec, next_overlay_string)
1235 (get_overlay_strings_1, push_display_prop): Set up the bidi
1236 iterator for displaying display or overlay strings.
1237 (forward_to_next_line_start): Don't use the shortcut if
1238 bidi-iterating.
1239 (back_to_previous_visible_line_start): If handle_display_prop
1240 pushed the iterator stack, restore the internal state of the bidi
1241 iterator by calling bidi_pop_it same number of times.
1242 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1243 and we are bidi-iterating, don't decrement the iterator position;
1244 instead, set the first_elt flag in the bidi iterator, to produce
1245 the same effect.
1246 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1247 (push_display_prop): xassert that we are iterating a buffer.
1248 (push_it, pop_it): Save and restore paragraph_embedding member.
1249 (handle_single_display_spec, next_overlay_string)
1250 (get_overlay_strings_1, reseat_1, reseat_to_string)
1251 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1252 correctly. Don't assume unibyte strings are not bidi-reordered.
1253 (compute_display_string_pos)
1254 (compute_display_string_end): Fix handling the case of C string.
1255 (push_it, pop_it): Save and restore from_disp_prop_p.
1256 (handle_single_display_spec, push_display_prop): Set the
1257 from_disp_prop_p flag.
1258 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1259 (pop_it): Call iterate_out_of_display_property only if we are
1260 popping after iteration over a string that came from a display
1261 property. Fix a typo in popping stretch info. Add an assertion
1262 for verifying that the iterator position is in sync with the bidi
1263 iterator.
1264 (handle_single_display_spec, get_overlay_strings_1)
1265 (push_display_prop): Fix initialization of paragraph direction for
1266 string when that of the parent object is not yet determined.
1267 (reseat_1): Call bidi_init_it to resync the bidi
1268 iterator with IT's position. (Bug#7616)
1269 (find_row_edges): If ROW->start.pos gives position
1270 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1271 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1272 Reset the from_disp_prop_p flag.
1273 (SAVE_IT, RESTORE_IT): New macros.
1274 (pos_visible_p, face_before_or_after_it_pos)
1275 (back_to_previous_visible_line_start)
1276 (move_it_in_display_line_to, move_it_in_display_line)
1277 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1278 (try_scrolling, redisplay_window, display_line): Use them when
1279 saving a temporary copy of the iterator and restoring it back.
1280 (back_to_previous_visible_line_start, reseat_1)
1281 (init_iterator): Empty the bidi cache "stack".
1282 (move_it_in_display_line_to): If iterator ended up at
1283 EOL, but we never saw any buffer positions smaller than
1284 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1285 motion in bidi-reordered lines.
1286 (move_it_in_display_line_to): Record prev_method and prev_pos
1287 immediately before the call to set_iterator_to_next. Fixes cursor
1288 motion in bidi-reordered lines with stretch glyphs and strings
1289 displayed in margins. (Bug#8133) (Bug#8867)
1290 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1291 TO_CHARPOS.
1292 (pos_visible_p): Support positions in bidi-reordered lines.
1293 Save and restore bidi cache.
1294
1295 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1296 (bidi_paragraph_info): Delete unused struct.
1297 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1298 (bidi_cache_start): New variable.
1299 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1300 to zero.
1301 (bidi_cache_fetch_state, bidi_cache_search)
1302 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1303 (bidi_cache_find, bidi_peek_at_next_level)
1304 (bidi_level_of_next_char, bidi_find_other_level_edge)
1305 (bidi_move_to_visually_next): Compare cache index with
1306 bidi_cache_start rather than with zero.
1307 (bidi_fetch_char): Accept new argument STRING; all callers
1308 changed. Support iteration over a string. Support strings with
1309 display properties. Support unibyte strings. Fix the type of
1310 `len' according to what STRING_CHAR_AND_LENGTH expects.
1311 (bidi_paragraph_init, bidi_resolve_explicit_1)
1312 (bidi_resolve_explicit, bidi_resolve_weak)
1313 (bidi_level_of_next_char, bidi_move_to_visually_next):
1314 Support iteration over a string.
1315 (bidi_set_sor_type, bidi_resolve_explicit_1)
1316 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1317 can now be zero (for strings); special values 0 and -1 were
1318 changed to -1 and -2, respectively.
1319 (bidi_char_at_pos): New function.
1320 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1321 Call it instead of FETCH_MULTIBYTE_CHAR.
1322 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1323 initialized to valid values.
1324 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1325 values.
1326 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1327 the test for valid cached positions. Fix the logic for looking up
1328 the sentinel state in the cache. GCPRO the Lisp string we are
1329 iterating.
1330 (bidi_push_it, bidi_pop_it): New functions.
1331 (bidi_initialize): Initialize the bidi cache start stack pointer.
1332 (bidi_cache_ensure_space): New function, refactored from part of
1333 bidi_cache_iterator_state. Don't assume the required size is just
1334 one BIDI_CACHE_CHUNK away.
1335 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1336 (bidi_count_bytes, bidi_char_at_pos): New functions.
1337 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1338 always valid if bidi_cache_idx is valid.
1339 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1340 is valid if it's going to be used.
1341 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1342 (bidi_cache_fetch_state, bidi_cache_search)
1343 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1344 (bidi_cache_iterator_state, bidi_cache_find)
1345 (bidi_find_other_level_edge, bidi_cache_start_stack):
1346 All variables related to cache indices are now EMACS_INT.
1347
1348 * dispextern.h (struct bidi_string_data): New structure.
1349 (struct bidi_it): New member `string'. Make flag members be 1-bit
1350 fields, and put them last in the struct.
1351 (compute_display_string_pos, compute_display_string_end):
1352 Update prototypes.
1353 (bidi_push_it, bidi_pop_it): Add prototypes.
1354 (struct iterator_stack_entry): New members bidi_p,
1355 paragraph_embedding, and from_disp_prop_p.
1356 (struct it): Member bidi_p is now a bit field 1 bit wide.
1357 (bidi_shelve_cache, bidi_unshelve_cache):
1358 Declare prototypes.
1359
1360 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1361 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1362 and vector-like objects.
1363
1364 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1365 cache around display iteration.
1366
1367 * window.c (Fwindow_end, window_scroll_pixel_based)
1368 (displayed_window_lines, Frecenter): Save and restore the bidi
1369 cache around display iteration.
1370
1371 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
1373 * editfns.c (Fdelete_region): Clarify the use of the named
1374 parameters (bug#6788).
1375
1376 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1377
1378 * indent.c (Fvertical_motion): Set and restore w->pointm when
1379 saving and restoring the window's buffer (Bug#9006).
1380
1381 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1382
1383 * editfns.c (Fstring_to_char): Clarify just what is returned
1384 (bug#6576). Text by Eli Zaretskii.
1385
1386 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1387
1388 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1389
1390 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1391
1392 * buffer.c (mmap_find): Fix a typo.
1393
1394 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1395
1396 Fix execution of x selection hooks.
1397 * xselect.c (Qx_lost_selection_functions)
1398 (Qx_sent_selection_functions): New vars.
1399 (syms_of_xselect): DEFSYM them.
1400 (x_handle_selection_request): Pass Qx_sent_selection_functions
1401 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1402 (x_handle_selection_clear,x_clear_frame_selections):
1403 Pass Qx_lost_selection_functions rather than
1404 Vx_lost_selection_functions to Frun_hook_with_args.
1405
1406 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1409 The old code sometimes used this field without initializing it.
1410
1411 * alloc.c (gc_sweep): Don't read past end of array.
1412 In theory, the old code could also have corrupted Emacs internals,
1413 though it'd be very unlikely.
1414
1415 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1416
1417 * character.c (Fcharacterp): Don't advertise optional ignored
1418 argument. (Bug#4026)
1419
1420 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1421
1422 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1423 key" (bug#4257).
1424
1425 * window.c (Fset_window_start): Doc fix (bug#4199).
1426 (Fset_window_hscroll): Ditto.
1427
1428 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Fix minor new problems caught by GCC 4.6.1.
1431 * term.c (init_tty): Remove unused local.
1432 * xsettings.c (store_monospaced_changed): Define this function only
1433 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1434 not used otherwise.
1435
1436 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1439
1440 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1441
1442 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1443 are the mini-buffer and the echo area (bug#3320).
1444
1445 * term.c (init_tty): Remove support for supdup, c10 and perq
1446 terminals, which are no longer supported (bug#1482).
1447
1448 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1449
1450 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1451
1452 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1453
1454 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1455 for non-popups (Bug#3642).
1456
1457 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1458
1459 * alloc.c (reset_malloc_hooks): Protoize.
1460 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1461 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1462 * cm.c (losecursor): Likewise.
1463 * data.c (fmod): Likewise.
1464 * dispnew.c (swap_glyphs_in_rows): Likewise.
1465 * emacs.c (memory_warning_signal): Likewise.
1466 * floatfns.c (float_error): Likewise.
1467 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1468 (otf_open, font_otf_capability, generate_otf_features)
1469 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1470 Likewise.
1471 * image.c (pbm_read_file): Likewise.
1472 * indent.c (string_display_width): Likewise.
1473 * intervals.c (check_for_interval, search_for_interval)
1474 (inc_interval_count, count_intervals, root_interval)
1475 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1476 * lread.c (defalias): Likewise.
1477 * ralloc.c (r_alloc_check): Likewise.
1478 * regex.c (set_image_of_range_1, set_image_of_range)
1479 (regex_grow_registers): Likewise.
1480 * sysdep.c (strerror): Likewise.
1481 * termcap.c (valid_filename_p, tprint, main): Likewise.
1482 * tparam.c (main): Likewise.
1483 * unexhp9k800.c (run_time_remap, save_data_space)
1484 (update_file_ptrs, read_header, write_header, calculate_checksum)
1485 (copy_file, copy_rest, display_header): Likewise.
1486 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1487 Likewise.
1488 * xdisp.c (check_it): Likewise.
1489 * xfaces.c (register_color, unregister_color, unregister_colors):
1490 Likewise.
1491 * xfns.c (print_fontset_result): Likewise.
1492 * xrdb.c (member, fatal, main): Likewise.
1493
1494 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Fix minor problems found by static checking (Bug#9031).
1497 * chartab.c (char_table_set_range, map_sub_char_table):
1498 Remove unused locals.
1499 (uniprop_table): Now static.
1500 * composite.c (_work_char): Remove unused static var.
1501
1502 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1503
1504 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1505
1506 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1507
1508 * gtkutil.c (qttip_cb): Remove code without function.
1509
1510 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1511
1512 * w32.c (pthread_sigmask): New stub.
1513
1514 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Use pthread_sigmask, not sigprocmask (Bug#9010).
1517 sigprocmask is portable only for single-threaded applications, and
1518 Emacs can be multi-threaded when it uses GTK.
1519 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1520 (LIBES): Use it.
1521 * callproc.c (Fcall_process):
1522 * process.c (create_process):
1523 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1524 Use pthread_sigmask, not sigprocmask.
1525
1526 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1527
1528 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1529 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1530 wrong (Bug#8591).
1531
1532 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1533
1534 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1535 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1536 (xg_hide_tooltip): Fix comment.
1537
1538 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1539 in registerServicesMenuSendTypes.
1540 (validRequestorForSendType): Don't check ns_return_types.
1541
1542 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1543 ns_return_type.
1544
1545 2011-07-08 Jason Rumney <jasonr@gnu.org>
1546
1547 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1548 frame struct members of non-existent frames (Bug#6284).
1549
1550 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1551
1552 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1553 variable firstTime not needed on OSX >= 10.6.
1554 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1555 >= 10.5. Use setKnobProportion, setDoubleValue.
1556
1557 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1558 (MAC_OS_X_VERSION_10_5): Define if not defined.
1559 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1560 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1561 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1562
1563 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1564 cString and lossyCString on OSX >= 10.4
1565
1566 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1567 sizeToFit on OSX >= 10.2.
1568
1569 * nsimage.m (allocInitFromFile): Don't use deprecated method
1570 bestRepresentationForDevice on OSX >= 10.6.
1571
1572 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1573 to avoid warning.
1574
1575 * emacs.c: Declare unexec_init_emacs_zone.
1576
1577 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1578
1579 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1580
1581 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1582 on svcsMenu (Bug#8842).
1583
1584 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1585 ns_return_types.
1586 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1587
1588 * nsterm.m (QUTF8_STRING): Declare.
1589 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1590 (validRequestorForSendType): Return type is (id).
1591 Change indexOfObjectIdenticalTo to indexOfObject.
1592 Check if we have local selection before returning self (Bug#8842).
1593 (writeSelectionToPasteboard): Put local selection into paste board
1594 if we have a local selection (Bug#8842).
1595 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1596
1597 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1598 (ns_get_local_selection): Declare.
1599
1600 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1601
1602 * keymap.c (describe_map_tree): Don't insert a double newline at
1603 the end of the buffer (bug#1169) and return whether we inserted
1604 something.
1605
1606 * callint.c (Fcall_interactively): Change "reading args" to
1607 "providing args" to try to clarify what it does (bug#1010).
1608
1609 2011-07-07 Kenichi Handa <handa@m17n.org>
1610
1611 * composite.c (composition_compute_stop_pos): Ignore a static
1612 composition starting before CHARPOS (Bug#8915).
1613
1614 * xdisp.c (handle_composition_prop): Likewise.
1615
1616 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1617
1618 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1619 (Bug#9015)
1620
1621 2011-07-07 Kenichi Handa <handa@m17n.org>
1622
1623 * character.h (unicode_category_t): New enum type.
1624
1625 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1626 (Qchar_code_property_table): New variable.
1627 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1628 (UNIPROP_COMPRESSED_FORM_P): New macros.
1629 (char_table_ascii): Uncompress the compressed values.
1630 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1631 Uncompress the compressed values.
1632 (sub_char_table_ref_and_range): Likewise.
1633 (char_table_ref_and_range): Uncompress the compressed values.
1634 (sub_char_table_set): New arg is_uniprop. Callers changed.
1635 Uncompress the compressed values.
1636 (sub_char_table_set_range): Args changed. Callers changed.
1637 (char_table_set_range): Adjuted for the above change.
1638 (map_sub_char_table): Delete args default_val and parent. Add arg
1639 top. Give decoded values to a Lisp function.
1640 (map_char_table): Adjust for the above change. Give decoded
1641 values to a Lisp function. Gcpro more variables.
1642 (uniprop_table_uncompress)
1643 (uniprop_decode_value_run_length): New functions.
1644 (uniprop_decoder, uniprop_decoder_count): New variables.
1645 (uniprop_get_decoder, uniprop_encode_value_character)
1646 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1647 New functions.
1648 (uniprop_encoder, uniprop_encoder_count): New variables.
1649 (uniprop_get_encoder, uniprop_table)
1650 (Funicode_property_table_internal, Fget_unicode_property_internal)
1651 (Fput_unicode_property_internal): New functions.
1652 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1653 Sunicode_property_table_internal, Sget_unicode_property_internal,
1654 and Sput_unicode_property_internal. Defvar_lisp
1655 char-code-property-alist.
1656
1657 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1658 Vunicode_category_table.
1659
1660 * font.c (font_range): Adjust for the change of
1661 Vunicode_category_table.
1662
1663 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1664
1665 * m/iris4d.h: Remove file, move contents ...
1666 * s/irix6-5.h: ... here.
1667
1668 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 Remove unportable assumption about struct layout (Bug#8884).
1671 * alloc.c (mark_buffer):
1672 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1673 (clone_per_buffer_values): Don't assume that
1674 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1675 This isn't true in general, and it's particularly not true
1676 if Emacs is configured with --with-wide-int.
1677 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1678 New macros, used in the buffer.c change.
1679
1680 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1681
1682 * xsettings.c: Use both GConf and GSettings if both are available.
1683 (store_config_changed_event): Add comment.
1684 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1685 (store_tool_bar_style_changed): New functions.
1686 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1687 (struct xsettings): Move font inside HAVE_XFT.
1688 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1689 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1690 Move inside HAVE_XFT.
1691 (something_changed_gsettingsCB): Rename from something_changedCB.
1692 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1693 also.
1694 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1695 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1696 (something_changed_gconfCB): Rename from something_changedCB.
1697 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1698 (parse_settings): Move check for font inside HAVE_XFT.
1699 (read_settings, apply_xft_settings): Add comment.
1700 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1701 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1702 call store_font_name_changed.
1703 (xft_settings_event): Add comment.
1704 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1705 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1706 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1707 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1708 (xsettings_initialize): Call init_gsettings last.
1709 (xsettings_get_system_font, xsettings_get_system_normal_font):
1710 Add comment.
1711
1712 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 Random fixes. E.g., (random) never returned negative values.
1715 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1716 subseconds part to the entropy, as that's a bit more random.
1717 Prefer signed to unsigned, since the signedness doesn't matter and
1718 in general we prefer signed. When given a limit, use a
1719 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1720 latter isn't right if USE_2_TAGS_FOR_INTS.
1721 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1722 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1723
1724 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1725
1726 * textprop.c (text_property_stickiness):
1727 Obey Vtext_property_default_nonsticky.
1728 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1729 * w32fns.c (syms_of_w32fns):
1730 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1731
1732 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1735 This is more efficient than Ffile_directory_p and avoids a minor race.
1736
1737 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1738
1739 * buffer.c (Foverlay_put): Say what the return value is
1740 (bug#7835).
1741
1742 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1743 is a directory before asking whether to use the file name
1744 (bug#7564).
1745 (barf_or_query_if_file_exists): Make the "File is a directory"
1746 error be more correct.
1747
1748 * fns.c (Frequire): Remove the mention of the .gz files, since
1749 that's installation-specific, but keep the mention of
1750 `get-load-suffixes'.
1751
1752 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1755 Report string overflow if the output is too long.
1756
1757 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1758
1759 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1760 (syms_of_gnutls): Remove duplicate DEFSYM for
1761 Qgnutls_bootprop_verify_hostname_error, an error for
1762 Qgnutls_bootprop_verify_error (which is no longer used).
1763
1764 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1765 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1766 Also (re)move comments that are misplaced or no longer relevant.
1767
1768 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1769
1770 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1771
1772 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1773
1774 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1775 and background color parameters if they have been changed.
1776
1777 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1778
1779 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1780
1781 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 * xsettings.c (SYSTEM_FONT): Define only when used.
1784 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1785
1786 * keymap.c (access_keymap_1): Now static.
1787
1788 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1789
1790 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1791 leave any prefix arg for the up event (Bug#1586).
1792
1793 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1794
1795 * lread.c (syms_of_lread): Mention single symbols defined by
1796 `defvar' or `defconst' (bug#7154).
1797
1798 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1799 (Frequire): Mention get-load-suffixes.
1800
1801 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1802
1803 * window.h (window): Remove clone_number slot.
1804 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1805 Remove.
1806 (make_parent_window, make_window, saved_window)
1807 (Fset_window_configuration, save_window_save): Don't deal with
1808 clone numbers.
1809 * buffer.c (Qclone_number): Remove declaration.
1810 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1811
1812 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 Add multiple inheritance to keymaps.
1815 * keymap.c (Fmake_composed_keymap): New function.
1816 (Fset_keymap_parent): Simplify.
1817 (fix_submap_inheritance): Remove.
1818 (access_keymap_1): New function extracted from access_keymap to handle
1819 embedded parents and handle lists of maps.
1820 (access_keymap): Use it.
1821 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1822 (Fcopy_keymap): Handle embedded parents.
1823 (Fcommand_remapping, define_as_prefix): Simplify.
1824 (Fkey_binding): Simplify.
1825 (syms_of_keymap): Move minibuffer-local-completion-map,
1826 minibuffer-local-filename-completion-map,
1827 minibuffer-local-must-match-map, and
1828 minibuffer-local-filename-must-match-map to Elisp.
1829 (syms_of_keymap): Defsubr make-composed-keymap.
1830 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1831 (parse_menu_item): Trivial simplification.
1832
1833 2011-07-01 Glenn Morris <rgm@gnu.org>
1834
1835 * Makefile.in (SETTINGS_LIBS): Fix typo.
1836
1837 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1838
1839 * coding.c (Fencode_coding_string): Record the last coding system
1840 used, as the function doc string says (bug#8738).
1841
1842 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1843
1844 * xsettings.c (store_monospaced_changed): Take new font as arg and
1845 check for change against current_mono_font.
1846 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1847 (emacs_settings_constructor, emacs_settings_get_property)
1848 (emacs_settings_set_property, emacs_settings_class_init)
1849 (emacs_settings_init, gsettings_obj): Remove.
1850 (something_changedCB): New function for HAVE_GSETTINGS.
1851 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1852 with value as argument.
1853 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1854 g_settings_new (Bug#8967). Do not create gsettings_obj.
1855 Remove calls to g_settings_bind. Connect something_changedCB to
1856 "changed".
1857
1858 * xgselect.c: Add defined (HAVE_GSETTINGS).
1859 (xgselect_initialize): Ditto.
1860
1861 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1862 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1863 xg_select.
1864
1865 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * eval.c (struct backtrace): Simplify and port the data structure.
1868 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1869 signed bit field, as this assumption is not portable and it makes
1870 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1871 "char debug_on_exit : 1" as this is not portable either; instead,
1872 use the portable "unsigned int debug_on_exit : 1". Remove unused
1873 member evalargs. Remove obsolete comments about cc bombing out.
1874
1875 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1878 Let HAVE_GSETTINGS override HAVE_GCONF.
1879 (store_monospaced_changed): New function.
1880 (EMACS_SETTINGS): A new type derived from GObject to handle
1881 GSettings notifications.
1882 (emacs_settings_constructor, emacs_settings_get_property)
1883 (emacs_settings_set_property, emacs_settings_class_init):
1884 New functions.
1885 (gsettings_client, gsettings_obj): New variables.
1886 (GSETTINGS_SCHEMA): New define.
1887 (something_changedCB): Call store_monospaced_changed.
1888 (init_gsettings): New function.
1889 (xsettings_initialize): Call init_gsettings.
1890 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1891 to NULL.
1892
1893 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1894 GCONF_CFLAGS/LIBS.
1895
1896 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1897
1898 * window.c (resize_root_window, grow_mini_window)
1899 (shrink_mini_window): Rename Qresize_root_window to
1900 Qwindow_resize_root_window and Qresize_root_window_vertically to
1901 Qwindow_resize_root_window_vertically.
1902
1903 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1906
1907 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1908
1909 * makefile.w32-in: Redesign dependencies so they reflect more
1910 clearly which files are directly included by each source file,
1911 and not through other includes.
1912
1913 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1914
1915 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1916 (sort_overlays, overlay_strings): When an overlay's clone number
1917 matches the window's clone number process the overlay even if
1918 the overlay's window property doesn't match the current window.
1919
1920 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1921 (Fwindow_hchild): Rename to Fwindow_left_child.
1922 (Fwindow_next): Rename to Fwindow_next_sibling.
1923 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1924 (resize_window_check): Rename to window_resize_check.
1925 (resize_window_apply): Rename to window_resize_apply.
1926 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1927 (Fdelete_other_windows_internal, resize_frame_windows)
1928 (Fsplit_window_internal, Fdelete_window_internal)
1929 (grow_mini_window, shrink_mini_window)
1930 (Fresize_mini_window_internal): Fix callers accordingly.
1931
1932 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1933
1934 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1935 (emacs_fixed_set_min_size): Remove.
1936 (emacs_fixed_new): Take frame as argument.
1937
1938 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1939 (_EmacsFixedPrivate): Remove minwidth/height.
1940 Add struct frame *f.
1941 (emacs_fixed_init): Initialize priv->f.
1942 (get_parent_class, emacs_fixed_set_min_size): Remove.
1943 (emacs_fixed_new): Set priv->f to argument.
1944 (emacs_fixed_get_preferred_width)
1945 (emacs_fixed_get_preferred_height): Use min_width/height from
1946 frames size_hint to set minimum and natural (Bug#8919).
1947 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1948 and use min_width/height from frames size_hint to set
1949 min_width/height (Bug#8919).
1950
1951 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1952 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1953 Fix indentation.
1954
1955 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1956
1957 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1958 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1959 called at ZV.
1960
1961 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1962
1963 * process.c (wait_reading_process_output): Bypass select if
1964 waiting for a cell while ignoring keyboard input, and input is
1965 pending. Suggested by Jan Djärv (Bug#8869).
1966
1967 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 Use gnulib's dup2 module instead of rolling our own.
1970 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1971
1972 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1973
1974 * dispnew.c (scrolling_window): Before scrolling, turn off a
1975 mouse-highlight in the window being scrolled.
1976
1977 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1978
1979 Move DEFSYM to lisp.h and use everywhere.
1980
1981 * character.h (DEFSYM): Move declaration...
1982 * lisp.h (DEFSYM): ...here.
1983
1984 * gnutls.c:
1985 * minibuf.c:
1986 * w32menu.c:
1987 * w32proc.c:
1988 * w32select.c: Don't include character.h.
1989
1990 * alloc.c (syms_of_alloc):
1991 * buffer.c (syms_of_buffer):
1992 * bytecode.c (syms_of_bytecode):
1993 * callint.c (syms_of_callint):
1994 * casefiddle.c (syms_of_casefiddle):
1995 * casetab.c (init_casetab_once):
1996 * category.c (init_category_once, syms_of_category):
1997 * ccl.c (syms_of_ccl):
1998 * cmds.c (syms_of_cmds):
1999 * composite.c (syms_of_composite):
2000 * dbusbind.c (syms_of_dbusbind):
2001 * dired.c (syms_of_dired):
2002 * dispnew.c (syms_of_display):
2003 * doc.c (syms_of_doc):
2004 * editfns.c (syms_of_editfns):
2005 * emacs.c (syms_of_emacs):
2006 * eval.c (syms_of_eval):
2007 * fileio.c (syms_of_fileio):
2008 * fns.c (syms_of_fns):
2009 * frame.c (syms_of_frame):
2010 * fringe.c (syms_of_fringe):
2011 * insdel.c (syms_of_insdel):
2012 * keymap.c (syms_of_keymap):
2013 * lread.c (init_obarray, syms_of_lread):
2014 * macros.c (syms_of_macros):
2015 * msdos.c (syms_of_msdos):
2016 * print.c (syms_of_print):
2017 * process.c (syms_of_process):
2018 * search.c (syms_of_search):
2019 * sound.c (syms_of_sound):
2020 * syntax.c (init_syntax_once, syms_of_syntax):
2021 * terminal.c (syms_of_terminal):
2022 * textprop.c (syms_of_textprop):
2023 * undo.c (syms_of_undo):
2024 * w32.c (globals_of_w32):
2025 * window.c (syms_of_window):
2026 * xdisp.c (syms_of_xdisp):
2027 * xfaces.c (syms_of_xfaces):
2028 * xfns.c (syms_of_xfns):
2029 * xmenu.c (syms_of_xmenu):
2030 * xsettings.c (syms_of_xsettings):
2031 * xterm.c (syms_of_xterm): Use DEFSYM.
2032
2033 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2034
2035 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2036
2037 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 Integer and buffer overflow fixes (Bug#8873).
2040
2041 * print.c (printchar, strout): Check for string overflow.
2042 (PRINTPREPARE, printchar, strout):
2043 Don't set size unless allocation succeeds.
2044
2045 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2046 for sizes. Check for string overflow more accurately.
2047 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2048
2049 * macros.c: Integer and buffer overflow fixes.
2050 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2051 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2052 Use ptrdiff_t, not int, for sizes.
2053 Don't increment bufsize until after realloc succeeds.
2054 Check for size-calculation overflow.
2055 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2056
2057 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2058
2059 * lread.c: Integer overflow fixes.
2060 (read_integer): Radix is now EMACS_INT, not int,
2061 to improve quality of diagnostics for out-of-range radices.
2062 Calculate buffer size correctly for out-of-range radices.
2063 (read1): Check for integer overflow in radices, and in
2064 read-circle numbers.
2065 (read_escape): Avoid int overflow.
2066 (Fload, openp, read_buffer_size, read1)
2067 (substitute_object_recurse, read_vector, read_list, map_obarray):
2068 Use ptrdiff_t, not int, for sizes.
2069 (read1): Use EMACS_INT, not int, for sizes.
2070 Check for size overflow.
2071
2072 * image.c (cache_image): Check for size arithmetic overflow.
2073
2074 * lread.c: Integer overflow issues.
2075 (saved_doc_string_size, saved_doc_string_length)
2076 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2077 Now ptrdiff_t, not int.
2078 (read1): Don't assume doc string length fits in int. Check for
2079 out-of-range doc string lengths.
2080 (read_list): Don't assume file position fits in int.
2081 (read_escape): Check for hex character overflow.
2082
2083 2011-06-22 Leo Liu <sdl.web@gmail.com>
2084
2085 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2086 Move to minibuffer.el.
2087
2088 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2091 The following patches are for when GLYPH_DEBUG && !XASSERT.
2092 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2093 * dispnew.c (flush_stdout):
2094 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2095 Mark as externally visible.
2096 * dispnew.c (check_window_matrix_pointers): Now static.
2097 * dispnew.c (window_to_frame_vpos):
2098 * xfns.c (unwind_create_frame):
2099 * xterm.c (x_check_font): Remove unused local.
2100 * scroll.c (CHECK_BOUNDS):
2101 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2102 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2103 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2104 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2105 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2106 Now static.
2107 (debug_method_add): Use va_list and vsprintf rather than relying
2108 on undefined behavior with wrong number of arguments.
2109 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2110 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2111 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2112 since we're not interested in debugging glyphs with old libraries.
2113 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2114 GCC 4.6.0's static checking.
2115
2116 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 Integer overflow and signedness fixes (Bug#8873).
2119 A few related buffer overrun fixes, too.
2120
2121 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2122
2123 * dispextern.h (struct face.stipple):
2124 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2125 (x_bitmap_mask, x_allocate_bitmap_record)
2126 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2127 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2128 (x_create_bitmap_from_xpm_data):
2129 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2130 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2131 (.bitmaps_last):
2132 * xfaces.c (load_pixmap):
2133 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2134 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2135 (.bitmaps_last, struct x_output.icon_bitmap):
2136 Use ptrdiff_t, not int, for bitmap indexes.
2137 (x_allocate_bitmap_record): Check for size overflow.
2138 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2139
2140 Use ptrdiff_t, not int, for overlay counts.
2141 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2142 * editfns.c (overlays_around, get_pos_property):
2143 * textprop.c (get_char_property_and_overlay):
2144 * xdisp.c (next_overlay_change, note_mouse_highlight):
2145 * xfaces.c (face_at_buffer_position):
2146 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2147 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2148 (Fnext_overlay_change, Fprevious_overlay_change)
2149 (mouse_face_overlay_overlaps, Foverlays_in):
2150 Use ptrdiff_t, not int, for sizes.
2151 (overlays_at, overlays_in): Check for size-calculation overflow.
2152
2153 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2154
2155 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2156 (x_session_initialize): Do not assume string length fits in int.
2157
2158 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2159 This is unlikely, but can occur if DPI is outlandish.
2160
2161 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2162 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2163
2164 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2165 * xrdb.c (magic_file_p, search_magic_path):
2166 Omit last arg SUFFIX; it was always 0. All callers changed.
2167 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2168
2169 * xfont.c (xfont_match): Avoid need for strlen.
2170
2171 * xfns.c: Don't assume strlen fits in int.
2172 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2173
2174 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2175 not unsigned long, as we prefer signed integers. All callers changed.
2176 Detect integer overflow in repeat count.
2177 (message_dolog): Don't assume print length fits in 39 bytes.
2178 (display_mode_element): Don't assume strlen fits in int.
2179
2180 * termcap.c: Don't assume sizes fit in int and never overflow.
2181 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2182 (gobble_line): Check for size-calculation overflow.
2183
2184 * minibuf.c (Fread_buffer):
2185 * lread.c (intern, intern_c_string):
2186 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2187 Don't assume string length fits in int.
2188
2189 * keyboard.c (parse_tool_bar_item):
2190 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2191
2192 * font.c: Don't assume string length fits in int.
2193 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2194 Use ptrdiff_t, not int.
2195 (font_intern_prop): Don't assume string length fits in int.
2196 Don't assume integer property fits in fixnum.
2197 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2198
2199 * filelock.c: Fix some buffer overrun and integer overflow issues.
2200 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2201 Reformulate so as not to need the command string.
2202 Invoke gzip -cd rather than gunzip, as it's more portable.
2203 (lock_info_type, lock_file_1, lock_file):
2204 Don't assume pid_t and time_t fit in unsigned long.
2205 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2206 (current_lock_owner): Prefer signed type for sizes.
2207 Use memcpy, not strncpy, where memcpy is what is really wanted.
2208 Don't assume (via atoi) that time_t and pid_t fit in int.
2209 Check for time_t and/or pid_t out of range, e.g., via a network share.
2210 Don't alloca where an auto var works fine.
2211
2212 * fileio.c: Fix some integer overflow issues.
2213 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2214 Don't assume string length fits in int.
2215 (directory_file_name): Don't assume string length fits in long.
2216 (make_temp_name): Don't assume pid fits in int, or that its print
2217 length is less than 20.
2218
2219 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2220
2221 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2222
2223 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2224
2225 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2226 We prefer signed integers, even for size calculations.
2227
2228 * emacs.c: Don't assume string length fits in 'int'.
2229 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2230 (main): Don't invoke strlen when not needed.
2231
2232 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2233 (XD_DEBUG_MESSAGE): Don't waste a byte.
2234
2235 * callproc.c (getenv_internal_1, getenv_internal)
2236 (Fgetenv_internal):
2237 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2238
2239 * lread.c (invalid_syntax): Omit length argument.
2240 All uses changed. This doesn't fix a bug, but it simplifies the
2241 code away from its former Hollerith-constant appearance, and it's
2242 one less 'int' to worry about when looking at integer-overflow issues.
2243 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2244
2245 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2246 This didn't break anything, but it didn't help either.
2247 It's confusing to put a bogus integer in a place where the actual
2248 value does not matter.
2249 (LIST_END_P): Remove unused macro and its bogus comment.
2250 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2251
2252 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2253 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2254 implementation.
2255 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2256 We prefer signed types, and the value cannot exceed the EMACS_INT
2257 range anyway (because otherwise the length would not be representable).
2258 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2259 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2260 This avoids a GCC warning when WIDE_EMACS_INT.
2261
2262 * indent.c (sane_tab_width): New function.
2263 (current_column, scan_for_column, Findent_to, position_indentation)
2264 (compute_motion): Use it. This is just for clarity.
2265 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2266
2267 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2268
2269 * lisp.h (lint_assume): New macro.
2270 * composite.c (composition_gstring_put_cache):
2271 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2272
2273 * editfns.c, insdel.c:
2274 Omit unnecessary forward decls, to simplify future changes.
2275
2276 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2277
2278 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2279
2280 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2281 Use much-faster test for byte-length change.
2282 Don't assume string byte-length fits in 'int'.
2283 Check that character arg fits in 'int'.
2284 (mapcar1): Declare byte as byte, for clarity.
2285
2286 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2287
2288 * fns.c (concat): Catch string overflow earlier.
2289 Do not rely on integer wraparound.
2290
2291 * dispextern.h (struct it.overlay_strings_charpos)
2292 (struct it.selective): Now EMACS_INT, not int.
2293 * xdisp.c (forward_to_next_line_start)
2294 (back_to_previous_visible_line_start)
2295 (reseat_at_next_visible_line_start, next_element_from_buffer):
2296 Don't arbitrarily truncate the value of 'selective' to int.
2297
2298 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2299
2300 * composite.c: Don't truncate sizes to 'int'.
2301 (composition_gstring_p, composition_reseat_it)
2302 (composition_adjust_point): Use EMACS_INT, not int.
2303 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2304 not EMACS_UINT, for indexes.
2305
2306 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2307
2308 * buffer.c: Include <verify.h>.
2309 (struct sortvec.priority, struct sortstr.priority):
2310 Now EMACS_INT, not int.
2311 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2312 (struct sortstr.size, record_overlay_string)
2313 (struct sortstrlist.size, struct sortlist.used):
2314 Don't truncate size to int.
2315 (record_overlay_string): Check for size-calculation overflow.
2316 (init_buffer_once): Check at compile-time, not run-time.
2317
2318 2011-06-22 Jim Meyering <meyering@redhat.com>
2319
2320 Don't leak an XBM-image-sized buffer
2321 * image.c (xbm_load): Free the image buffer after using it.
2322
2323 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2324
2325 Port to Sun C.
2326 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2327 that Sun C diagnosed.
2328 * fns.c (secure_hash): Fix pointer signedness issue.
2329 * intervals.c (static_offset_intervals): New function.
2330 (offset_intervals): Use it.
2331
2332 2011-06-21 Leo Liu <sdl.web@gmail.com>
2333
2334 * deps.mk (fns.o):
2335 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2336 sha512.h.
2337
2338 * fns.c (secure_hash): Rename from crypto_hash_function and change
2339 the first arg to accept symbols.
2340 (Fsecure_hash): New primitive.
2341 (syms_of_fns): New symbols.
2342
2343 2011-06-20 Deniz Dogan <deniz@dogan.se>
2344
2345 * process.c (Fset_process_buffer): Clarify return value in
2346 docstring.
2347
2348 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * dispnew.c (add_window_display_history): Use BVAR.
2351
2352 * xdisp.c (debug_method_add): Use BVAR.
2353 (check_window_end, dump_glyph_matrix, dump_glyph)
2354 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2355
2356 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2357 Likewise.
2358
2359 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2360 check till after the cache is created in init_frame_faces.
2361
2362 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2363
2364 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2365
2366 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2369 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2370 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2371
2372 Improve buffer-overflow checking (Bug#8873).
2373 * fileio.c (Finsert_file_contents):
2374 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2375 Remove the old (too-loose) buffer overflow checks.
2376 They weren't needed, since make_gap checks for buffer overflow.
2377 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2378 The old code merely checked for Emacs fixnum overflow, and relied
2379 on undefined (wraparound) behavior. The new code avoids undefined
2380 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2381
2382 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2383 Tune. Don't use wider integers than needed. Don't use alloca.
2384 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2385
2386 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2387
2388 * insdel.c, lisp.h (buffer_overflow): New function.
2389 (insert_from_buffer_1, replace_range, replace_range_2):
2390 * insdel.c (make_gap_larger):
2391 * editfns.c (Finsert_char):
2392 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2393
2394 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2395
2396 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 Integer overflow and signedness fixes (Bug#8873).
2399
2400 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2401 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2402
2403 * fileio.c: Don't assume EMACS_INT fits in off_t.
2404 (emacs_lseek): New static function.
2405 (Finsert_file_contents, Fwrite_region): Use it.
2406 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2407
2408 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2409
2410 * fns.c: Don't overflow int when computing a list length.
2411 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2412 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2413 truncation on 64-bit hosts. Check for QUIT every
2414 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2415 faster and is responsive enough.
2416 (Flength): Report an error instead of overflowing an integer.
2417 (Fsafe_length): Return a float if the value is not representable
2418 as a fixnum. This shouldn't happen except in contrived situations.
2419 (Fnthcdr, Fsort): Don't assume list length fits in int.
2420 (Fcopy_sequence): Don't assume vector length fits in int.
2421
2422 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2423 (header_size, word_size): New constants.
2424 (allocate_vectorlike): Don't check size overflow here.
2425 (allocate_vector): Check it here instead, since this is the only
2426 caller of allocate_vectorlike that could cause overflow.
2427 Check that the new vector's length is representable as a fixnum.
2428
2429 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2430 The previous code was bogus. For example, next_almost_prime (32)
2431 returned 39, which is undesirable as it is a multiple of 3; and
2432 next_almost_prime (24) returned 25, which is a multiple of 5 so
2433 why was the code bothering to check for multiples of 7?
2434
2435 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2436
2437 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2438
2439 Variadic C functions now count arguments with ptrdiff_t.
2440 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2441 Back then I didn't know that the Emacs coding style prefers signed int.
2442 Also, in the meantime I found a few more instances where arguments
2443 were being counted with int, which may truncate counts on 64-bit
2444 machines, or EMACS_INT, which may be unnecessarily wide.
2445 * lisp.h (struct Lisp_Subr.function.aMANY)
2446 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2447 Arg counts are now ptrdiff_t, not size_t.
2448 All variadic functions and their callers changed accordingly.
2449 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2450 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2451 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2452 * callint.c (Fcall_interactively): Check arg count for overflow,
2453 to avoid potential buffer overrun. Use signed char, not 'int',
2454 for 'varies' array, so that we needn't bother to check its size
2455 calculation for overflow.
2456 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2457 * eval.c (apply_lambda):
2458 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2459 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2460 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2461
2462 * callint.c (Fcall_interactively): Don't use index var as event count.
2463
2464 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2465 * mem-limits.h (SIZE): Remove; no longer used.
2466
2467 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2468
2469 Remove unnecessary casts.
2470 * xterm.c (x_term_init):
2471 * xfns.c (x_set_border_pixel):
2472 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2473 These aren't needed now that we assume ANSI C.
2474
2475 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2476 It's more likely to cause problems (due to unsigned overflow)
2477 than to cure them.
2478
2479 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2480
2481 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2482
2483 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2484
2485 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2486
2487 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2488
2489 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2490
2491 GLYPH_CODE_FACE returns EMACS_INT, not int.
2492 * dispextern.h (merge_faces):
2493 * xfaces.c (merge_faces):
2494 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2495 Don't assume EMACS_INT fits in int.
2496
2497 * character.h (CHAR_VALID_P): Remove unused parameter.
2498 * fontset.c, lisp.h, xdisp.c: All uses changed.
2499
2500 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2501
2502 * fns.c (concat): Minor tuning based on overflow analysis.
2503 This doesn't fix any bugs. Use int to hold character, instead
2504 of constantly refetching from Emacs object. Use XFASTINT, not
2505 XINT, for value known to be a character. Don't bother comparing
2506 a single byte to 0400, as it's always less.
2507
2508 * floatfns.c (Fexpt):
2509 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2510
2511 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2512 for characters.
2513
2514 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2515
2516 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2517 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2518 incorrectly succeed when S was a string, because 4294967386 was
2519 truncated before it was used.
2520
2521 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2522 Otherwise, an out-of-range integer could cause undefined behavior
2523 on a 64-bit host.
2524
2525 * composite.c: Use int, not EMACS_INT, for characters.
2526 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2527 EMACS_INT, for values that are known to be in character range.
2528 This doesn't fix any bugs but is the usual style inside Emacs and
2529 may generate better code on 32-bit machines.
2530
2531 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2532 This is for reasons similar to the recent CHAR_STRING fix.
2533 * charset.c (Fencode_char): Check that character arg is actually
2534 a character. Pass an int to ENCODE_CHAR.
2535 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2536 wider than 'int', as a compile-time check to prevent future regressions
2537 in this area.
2538
2539 * character.c (char_string): Remove unnecessary casts.
2540
2541 Make sure a 64-bit char is never passed to CHAR_STRING.
2542 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2543 by silently ignoring the top 32 bits, allowing some values
2544 that were far too large to be valid characters.
2545 * character.h: Include <verify.h>.
2546 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2547 arguments are no wider than unsigned, as a compile-time check
2548 to prevent future regressions in this area.
2549 * data.c (Faset):
2550 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2551 (Fsubst_char_in_region):
2552 * fns.c (concat):
2553 * xdisp.c (decode_mode_spec_coding):
2554 Adjust to CHAR_STRING's new requirement.
2555 * editfns.c (Finsert_char, Fsubst_char_in_region):
2556 * fns.c (concat): Check that character args are actually
2557 characters. Without this test, these functions did the wrong
2558 thing with wildly out-of-range values on 64-bit hosts.
2559
2560 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2561 These casts should not be needed on 32-bit hosts, either.
2562 * keyboard.c (read_char):
2563 * lread.c (Fload): Remove casts to unsigned.
2564
2565 * lisp.h (UNSIGNED_CMP): New macro.
2566 This fixes comparison bugs on 64-bit hosts.
2567 (ASCII_CHAR_P): Use it.
2568 * casefiddle.c (casify_object):
2569 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2570 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2571 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2572 * dispextern.h (FACE_FROM_ID):
2573 * keyboard.c (read_char): Use UNSIGNED_CMP.
2574
2575 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2576 not to EMACS_INT, to avoid GCC warning.
2577
2578 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2579
2580 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2581 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2582 isn't needed on 32-bit machines.
2583
2584 * buffer.c (Fgenerate_new_buffer_name):
2585 Use EMACS_INT for count, not int.
2586 (advance_to_char_boundary): Return EMACS_INT, not int.
2587
2588 * data.c (Qcompiled_function): Now static.
2589
2590 * window.c (window_body_lines): Now static.
2591
2592 * image.c (gif_load): Rename local to avoid shadowing.
2593
2594 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2595 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2596 * alloc.c (make_save_value): Integer argument is now of type
2597 ptrdiff_t, not int.
2598 (mark_object): Use ptrdiff_t, not int.
2599 * lisp.h (pD): New macro.
2600 * print.c (print_object): Use it.
2601
2602 * alloc.c: Use EMACS_INT, not int, to count objects.
2603 (total_conses, total_markers, total_symbols, total_vector_size)
2604 (total_free_conses, total_free_markers, total_free_symbols)
2605 (total_free_floats, total_floats, total_free_intervals)
2606 (total_intervals, total_strings, total_free_strings):
2607 Now EMACS_INT, not int. All uses changed.
2608 (Fgarbage_collect): Compute overall total using a double, so that
2609 integer overflow is less likely to be a problem. Check for overflow
2610 when converting back to an integer.
2611 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2612 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2613 These were 'int' variables that could overflow on 64-bit hosts;
2614 they were never used, so remove them instead of repairing them.
2615 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2616 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2617 Previously, this ceilinged at INT_MAX, but that doesn't work on
2618 64-bit machines.
2619 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2620
2621 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2622 (allocate_vectorlike): Check for ptrdiff_t overflow.
2623 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2624 when a (possibly-narrower) signed value would do just as well.
2625 We prefer using signed arithmetic, to avoid comparison confusion.
2626
2627 * alloc.c: Catch some string size overflows that we were missing.
2628 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2629 for convenience in STRING_BYTES_MAX.
2630 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2631 The definition here is exact; the one in lisp.h was approximate.
2632 (allocate_string_data): Check for string overflow. This catches
2633 some instances we weren't catching before. Also, it catches
2634 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2635 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2636 and ptrdiff_t and EMACS_INT are both 64 bits.
2637
2638 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2639 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2640 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2641
2642 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2643
2644 * alloc.c (Fmake_string): Check for out-of-range init.
2645
2646 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2647
2648 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2649
2650 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2651
2652 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2653 xg_get_default_scrollbar_width.
2654
2655 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2656 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2657 (style_changed_cb): Call update_theme_scrollbar_width and call
2658 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2659 all frames (Bug#8505).
2660 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2661 Call gtk_window_set_resizable if HAVE_GTK3.
2662 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2663 and height if HAVE_GTK3 (Bug#8505).
2664 (scroll_bar_width_for_theme): New variable.
2665 (update_theme_scrollbar_width): New function.
2666 (xg_get_default_scrollbar_width): Move code to
2667 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2668 (xg_initialize): Call update_theme_scrollbar_width.
2669
2670 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2671
2672 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2673
2674 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2675
2676 * frame.c (make_frame): Call other_buffer_safely instead of
2677 other_buffer.
2678
2679 * window.c (temp_output_buffer_show): Call display_buffer with
2680 second argument Vtemp_buffer_show_specifiers and reset latter
2681 immediately after the call.
2682 (Vtemp_buffer_show_specifiers): New variable.
2683 (auto_window_vscroll_p, next_screen_context_lines)
2684 (Vscroll_preserve_screen_position): Remove leading asterisks from
2685 doc-strings.
2686
2687 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Fix minor problems found by GCC 4.6.0 static checking.
2690 * buffer.c (Qclone_number): Remove for now, as it's unused.
2691 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2692 (record_buffer): Remove unused local.
2693 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2694 (set_frame_buffer_list): Remove; unused.
2695 * frame.h (other_visible_frames): Remove decl.
2696 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2697 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2698 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2699 if HAVE_GPM.
2700 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2701 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2702 Define only if HAVE_GPM.
2703 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2704 (update_hints_inhibit): Remove; never set. All uses removed.
2705 * widgetprv.h (emacsFrameClassRec): Remove decl.
2706 * window.c (delete_deletable_window): Now returns void, since it
2707 wasn't returning anything.
2708 (compare_window_configurations): Remove unused locals.
2709 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2710 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2711 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2712 the same widths as pointers. This follows up on the 2011-05-06 patch.
2713 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2714 * xterm.h: Likewise.
2715 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2716
2717 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2718
2719 * makefile.w32-in: Update dependencies.
2720 (LISP_H): Add lib/intprops.h.
2721
2722 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2723
2724 * image.c (gif_load): Add animation frame delay to the metadata.
2725 (syms_of_image): Use DEFSYM. New symbol `delay'.
2726
2727 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2728
2729 * window.c (delete_deletable_window): Re-add.
2730 (Fset_window_configuration): Rewrite to handle dead buffers and
2731 consequently deletable windows.
2732 (window_tree, Fwindow_tree): Remove. Supply functionality in
2733 window.el.
2734 (compare_window_configurations): Simplify code.
2735
2736 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2737
2738 * image.c (imagemagick_load_image): Fix type mismatch.
2739 (Fimagemagick_types): Likewise.
2740
2741 * window.h (replace_buffer_in_windows): Declare.
2742
2743 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2744
2745 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2746 Qclone_number. Remove external declaration of Qdelete_window.
2747 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2748 code.
2749 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2750 Run Qbuffer_list_update_hook if allowed.
2751 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2752 buffer list implementation.
2753 (other_buffer_safely): New function.
2754 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2755 calls to replace_buffer_in_windows and
2756 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2757 if allowed.
2758 (record_buffer): Inhibit quitting and rewrite using quittable
2759 functions. Run Qbuffer_list_update_hook if allowed.
2760 (Frecord_buffer, Funrecord_buffer): New functions.
2761 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2762 Move switch-to-buffer to window.el.
2763 (bury-buffer): Move to window.el.
2764 (Vbuffer_list_update_hook): New variable.
2765
2766 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2767 section.
2768
2769 * window.h (resize_frame_windows): Move up in code.
2770 (Fwindow_frame): Remove EXFUN.
2771 (replace_buffer_in_all_windows): Remove prototype.
2772 (replace_buffer_in_windows_safely): Add prototype.
2773
2774 * window.c: Declare Qdelete_window static again. Move down
2775 declaration of select_count.
2776 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2777 (Fother_window): Move to window.el.
2778 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2779 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2780 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2781 window.el.
2782 (replace_buffer_in_windows): Implement by calling
2783 Qreplace_buffer_in_windows.
2784 (replace_buffer_in_all_windows): Remove with some functionality
2785 moved into replace_buffer_in_windows_safely.
2786 (replace_buffer_in_windows_safely): New function.
2787 (select_window_norecord, select_frame_norecord): Move in front
2788 of run_window_configuration_change_hook. Remove now obsolete
2789 declarations.
2790 (Fset_window_buffer): Rewrite doc-string.
2791 Call Qrecord_window_buffer.
2792 (keys_of_window): Move binding for other-window to window.el.
2793
2794 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2795
2796 * dispextern.h (struct image): Replace data member, whose int_val
2797 and ptr_val fields were not used by anything, with a single
2798 lisp_val object.
2799
2800 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2801 (gif_clear_image, gif_load, imagemagick_load_image)
2802 (gs_clear_image, gs_load): Callers changed.
2803
2804 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 * buffer.h: Include <time.h>, for time_t.
2807 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2808
2809 Fix minor problems found by static checking.
2810
2811 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2812
2813 Make identifiers static if they are not used in other modules.
2814 * data.c (Qcompiled_function, Qframe, Qvector):
2815 * image.c (QimageMagick, Qsvg):
2816 * minibuf.c (Qmetadata):
2817 * window.c (resize_window_check, resize_root_window): Now static.
2818 * window.h (resize_window_check, resize_root_window): Remove decls.
2819
2820 * window.c (window_deletion_count, delete_deletable_window):
2821 Remove; unused.
2822 (window_body_lines): Now static.
2823 (Fdelete_other_windows_internal): Mark vars as initialized.
2824 Make sure 'resize_failed' is initialized.
2825 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2826 (resize_window_apply): Remove unused local.
2827 * window.h (delete_deletable_window): Remove decl.
2828
2829 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2830 (imagemagick_load_image): Fix pointer signedness problem by changing
2831 last arg from unsigned char * to char *. All uses changed.
2832 Also, fix a local for similar reasons.
2833 Remove unused locals. Remove locals to avoid shadowing.
2834 (fn_rsvg_handle_free): Remove; unused.
2835 (svg_load, svg_load_image): Fix pointer signedness problem.
2836 (imagemagick_load_image): Don't use garbage pointer image_wand.
2837
2838 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2839
2840 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2841
2842 * image.c (gif_load): Fix omitted cast error introduced by
2843 2011-06-06 change.
2844
2845 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2846
2847 * window.h (resize_proportionally, orig_total_lines)
2848 (orig_top_line): Remove from window structure.
2849 (set_window_height, set_window_width, change_window_heights)
2850 (Fdelete_window): Remove prototypes.
2851 (resize_frame_windows): Remove duplicate declaration.
2852
2853 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2854
2855 * window.h (resize_frame_windows, resize_window_check)
2856 (delete_deletable_window, resize_root_window)
2857 (resize_frame_windows): Declare prototypes.
2858
2859 * window.c (resize_window_apply): Make definition be "static" to
2860 match the prototype.
2861
2862 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2863
2864 * window.c: Remove declarations of Qwindow_size_fixed,
2865 window_min_size_1, window_min_size_2, window_min_size,
2866 size_window, window_fixed_size_p, enlarge_window, delete_window.
2867 Remove static from declaration of Qdelete_window, it's
2868 temporarily needed by Fbury_buffer.
2869 (replace_window): Don't assign orig_top_line and
2870 orig_total_lines.
2871 (Fdelete_window, delete_window): Remove. Window deletion is
2872 handled by window.el.
2873 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2874 Replace Fdelete_window calls with calls to Qdelete_window.
2875 (Fdelete_other_windows): Remove. Deleting other windows is
2876 handled by window.el.
2877 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2878 handled in window.el.
2879 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2880 Window minimum sizes are handled in window.el.
2881 (shrink_windows, size_window, set_window_height)
2882 (set_window_width, change_window_heights, window_height)
2883 (window_width, CURBEG, CURSIZE, enlarge_window)
2884 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2885 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2886 handled in window.el.
2887 (make_dummy_parent): Rename to make_parent_window and give it a
2888 second argument horflag.
2889 (make_window): Don't set resize_proportionally any more.
2890 (Fsplit_window): Remove. Windows are split in window.el.
2891 (save_restore_action, save_restore_orig_size)
2892 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2893 Resize mini windows in window.el.
2894 (grow_mini_window, shrink_mini_window): Implement by calling
2895 Qresize_root_window_vertically, resize_window_check and
2896 resize_window_apply.
2897 (saved_window, Fset_window_configuration, save_window_save):
2898 Do not handle orig_top_line, orig_total_lines, and
2899 resize_proportionally.
2900 (window_min_height, window_min_width): Move to window.el.
2901 (keys_of_window): Move bindings for delete-other-windows,
2902 split-window, delete-window and enlarge-window to window.el.
2903
2904 * buffer.c: Temporarily extern Qdelete_window.
2905 (Fbury_buffer): Temporarily call Qdelete_window instead of
2906 Fdelete_window (Fbury_buffer will move to window.el soon).
2907
2908 * frame.c (set_menu_bar_lines_1): Remove code handling
2909 orig_top_line and orig_total_lines.
2910
2911 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2912 set_window_height but set heights directly.
2913 (change_frame_size_1): Use resize_frame_windows.
2914
2915 * xdisp.c (init_xdisp): Don't use set_window_height but set
2916 heights directly.
2917
2918 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2919 Use resize_frame_windows instead of change_window_heights and run
2920 run_window_configuration_change_hook.
2921
2922 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2923 instead of change_window_heights and run
2924 run_window_configuration_change_hook.
2925
2926 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2927
2928 * window.c (replace_window): Rename second argument REPLACEMENT to
2929 NEW. New third argument SETFLAG. Rewrite.
2930 (delete_window, make_dummy_parent): Call replace_window with
2931 third argument 1.
2932 (window_list_1): Move down in code.
2933 (run_window_configuration_change_hook): Move set_buffer part
2934 before select_frame_norecord part in order to unwind correctly.
2935 Rename count1 to count.
2936 (recombine_windows, delete_deletable_window, resize_root_window)
2937 (Fdelete_other_windows_internal)
2938 (Frun_window_configuration_change_hook, make_parent_window)
2939 (resize_window_check, resize_window_apply, Fresize_window_apply)
2940 (resize_frame_windows, Fsplit_window_internal)
2941 (Fdelete_window_internal, Fresize_mini_window_internal):
2942 New functions.
2943 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2944
2945 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2946
2947 * window.h (window): Add some new members to window structure -
2948 normal_lines, normal_cols, new_total, new_normal, clone_number,
2949 splits, nest, prev_buffers, next_buffers.
2950 (WINDOW_TOTAL_SIZE): Move here from window.c.
2951 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2952
2953 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2954 Remove.
2955 (make_dummy_parent): Set new members of windows structure.
2956 (make_window): Move down in code. Handle new members of window
2957 structure.
2958 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2959 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2960 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2961 (Fset_window_prev_buffers, Fwindow_next_buffers)
2962 (Fset_window_next_buffers, Fset_window_clone_number):
2963 New functions.
2964 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2965 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2966 Doc-string fixes.
2967 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2968 Argument WINDOW can be now internal window too.
2969 (Fwindow_use_time): Move up in code.
2970 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2971 Rewrite doc-string.
2972 (Fset_window_configuration, saved_window)
2973 (Fcurrent_window_configuration, save_window_save): Handle new
2974 members of window structure.
2975 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2976 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2977 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2978 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2979 Qget_mru_window, Qresize_root_window,
2980 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2981 Qauto_buffer_name; staticpro them.
2982
2983 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2984
2985 * window.c (Fwindow_total_size, Fwindow_left_column)
2986 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2987 (Fwindow_list_1): New functions.
2988 (window_box_text_cols): Replace with window_body_cols.
2989 (Fwindow_width, Fscroll_left, Fscroll_right):
2990 Use window_body_cols instead of window_box_text_cols.
2991 (delete_window, Fset_window_configuration):
2992 Call delete_all_subwindows with window as argument.
2993 (delete_all_subwindows): Take a window as argument and not a
2994 structure. Rewrite.
2995 (window_loop): Remove handling of GET_LRU_WINDOW and
2996 GET_LARGEST_WINDOW.
2997 (Fget_lru_window, Fget_largest_window): Move to window.el.
2998
2999 * window.h: Extern window_body_cols instead of
3000 window_box_text_cols. delete_all_subwindows now takes a
3001 Lisp_Object as argument.
3002
3003 * indent.c (compute_motion, Fcompute_motion):
3004 Use window_body_cols instead of window_box_text_cols.
3005
3006 * frame.c (delete_frame): Call delete_all_subwindows with root
3007 window as argument.
3008
3009 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3010
3011 * fns.c (Fputhash): Document return value.
3012
3013 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3014
3015 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3016
3017 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Cons<->int and similar integer overflow fixes (Bug#8794).
3020
3021 Check for overflow when converting integer to cons and back.
3022 * charset.c (Fdefine_charset_internal, Fdecode_char):
3023 Use cons_to_unsigned to catch overflow.
3024 (Fencode_char): Use INTEGER_TO_CONS.
3025 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3026 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3027 * data.c (long_to_cons, cons_to_long): Remove.
3028 (cons_to_unsigned, cons_to_signed): New functions.
3029 These signal an error for invalid or out-of-range values.
3030 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3031 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3032 * font.c (Ffont_variation_glyphs):
3033 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3034 * lisp.h: Include <intprops.h>.
3035 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3036 (cons_to_signed, cons_to_unsigned): New decls.
3037 (long_to_cons, cons_to_long): Remove decls.
3038 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3039 (Fprimitive_undo): Use CONS_TO_INTEGER.
3040 * xfns.c (Fx_window_property): Likewise.
3041 * xselect.c: Include <limits.h>.
3042 (x_own_selection, selection_data_to_lisp_data):
3043 Use INTEGER_TO_CONS.
3044 (x_handle_selection_request, x_handle_selection_clear)
3045 (x_get_foreign_selection, Fx_disown_selection_internal)
3046 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3047 (lisp_data_to_selection_data): Use cons_to_unsigned.
3048 (x_fill_property_data): Use cons_to_signed.
3049 Report values out of range.
3050
3051 Check for buffer and string overflow more precisely.
3052 * buffer.h (BUF_BYTES_MAX): New macro.
3053 * lisp.h (STRING_BYTES_MAX): New macro.
3054 * alloc.c (Fmake_string):
3055 * character.c (string_escape_byte8):
3056 * coding.c (coding_alloc_by_realloc):
3057 * doprnt.c (doprnt):
3058 * editfns.c (Fformat):
3059 * eval.c (verror):
3060 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3061 since they may not be the same number.
3062 * editfns.c (Finsert_char):
3063 * fileio.c (Finsert_file_contents):
3064 Likewise for BUF_BYTES_MAX.
3065
3066 * image.c: Use ptrdiff_t, not int, for sizes.
3067 (slurp_file): Switch from int to ptrdiff_t.
3068 All uses changed.
3069 (slurp_file): Check that file size fits in both size_t (for
3070 malloc) and ptrdiff_t (for sanity and safety).
3071
3072 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3073 if b->modtime has its maximal value.
3074
3075 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3076
3077 Don't assume time_t can fit into int.
3078 * buffer.h (struct buffer.modtime): Now time_t, not int.
3079 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3080 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3081
3082 Minor fixes for signed vs unsigned integers.
3083 * character.h (MAYBE_UNIFY_CHAR):
3084 * charset.c (maybe_unify_char):
3085 * keyboard.c (read_char, reorder_modifiers):
3086 XINT -> XFASTINT, since the integer must be nonnegative.
3087 * ftfont.c (ftfont_spec_pattern):
3088 * keymap.c (access_keymap, silly_event_symbol_error):
3089 XUINT -> XFASTINT, since the integer must be nonnegative.
3090 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3091 since it makes no difference and we prefer signed.
3092 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3093 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3094 nonnegative.
3095
3096 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3097
3098 * window.h (Fwindow_frame): Declare.
3099
3100 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3103 (SPARE_MEMORY): Always define.
3104 (LARGE_REQUEST): Remove.
3105 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3106
3107 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3108
3109 * lisp.h: Move EXFUNS for Fframe_root_window,
3110 Fframe_first_window and Fset_frame_selected_window to window.h.
3111
3112 * window.h: Move EXFUNS for Fframe_root_window,
3113 Fframe_first_window and Fset_frame_selected_window here from
3114 lisp.h.
3115
3116 * frame.c (Fwindow_frame, Fframe_first_window)
3117 (Fframe_root_window, Fframe_selected_window)
3118 (Fset_frame_selected_window): Move to window.c.
3119 (Factive_minibuffer_window): Move to minibuf.c.
3120 (Fother_visible_frames_p): New function.
3121
3122 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3123
3124 * window.c (decode_window, decode_any_window): Move up in code.
3125 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3126 (inhibit_frame_unsplittable): Remove unused variable.
3127 (Fwindow_buffer): Move up and rewrite doc-string.
3128 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3129 (Fwindow_prev): New functions.
3130 (Fwindow_frame): Move here from frame.c. Accept any window as
3131 argument.
3132 (Fframe_root_window, Fframe_first_window)
3133 (Fframe_selected_window): Move here from frame.c. Accept frame
3134 or arbitrary window as argument. Update doc-strings.
3135 (Fminibuffer_window): Move up in code.
3136 (Fwindow_minibuffer_p): Move up in code and simplify.
3137 (Fset_frame_selected_window): Move here from frame.c.
3138 Marginal rewrite.
3139 (Fselected_window, select_window, Fselect_window): Move up in
3140 code. Minor doc-string fixes.
3141
3142 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3143
3144 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3145 Do not assume that spare memory exists; that assumption is valid
3146 only if SYSTEM_MALLOC.
3147 (LARGE_REQUEST): New macro, so that the issue of large requests
3148 is separated from the issue of spare memory.
3149
3150 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3151
3152 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3153 format. (Bug#8806)
3154
3155 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3156
3157 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3158 before statements.
3159
3160 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3161
3162 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3163
3164 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3165
3166 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3167 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3168
3169 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3172
3173 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3174
3175 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3176 (x_clipboard_manager_save): Add return value.
3177 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3178 New error handlers.
3179 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3180 Obey Vx_select_enable_clipboard_manager. Catch errors in
3181 x_clipboard_manager_save (Bug#8779).
3182 (Vx_select_enable_clipboard_manager): New variable.
3183 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3184
3185 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3186
3187 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3188
3189 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3190
3191 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3192 in the current matrix if keep_current_p is non-zero.
3193
3194 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3195
3196 * bidi.c (bidi_level_of_next_char): Fix last change.
3197
3198 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3199
3200 Support bidi reordering of text covered by display properties.
3201
3202 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3203 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3204 (bidi_cache_search, bidi_cache_iterator_state)
3205 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3206 (bidi_level_of_next_char, bidi_move_to_visually_next):
3207 Support character positions inside a run of characters covered by a
3208 display string.
3209 (bidi_paragraph_init, bidi_resolve_explicit_1)
3210 (bidi_level_of_next_char): Call bidi_fetch_char and
3211 bidi_fetch_char_advance instead of FETCH_CHAR and
3212 FETCH_CHAR_ADVANCE.
3213 (bidi_init_it): Initialize new members.
3214 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3215 definitions.
3216 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3217 instead of using explicit *_CHAR codes.
3218 (bidi_resolve_explicit, bidi_resolve_weak):
3219 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3220 bidirectional text is supported only in multibyte buffers.
3221 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3222 it to initialize the frame_window_p member of struct bidi_it.
3223 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3224 (bidi_resolve_explicit, bidi_resolve_weak)
3225 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3226 bidi_it->nchars is non-positive.
3227 (bidi_level_of_next_char): Don't try to lookup the cache for the
3228 next/previous character if nothing is cached there yet, or if we
3229 were just reseat()'ed to a new position.
3230
3231 * xdisp.c (set_cursor_from_row): Set start and stop points
3232 according to the row's direction when priming the loop that looks
3233 for the glyph on which to display cursor.
3234 (single_display_spec_intangible_p): Function deleted.
3235 (display_prop_intangible_p): Reimplement to call
3236 handle_display_spec instead of single_display_spec_intangible_p.
3237 Accept 3 additional arguments needed by handle_display_spec.
3238 This fixes incorrect cursor motion across display property with complex
3239 values: lists, `(when COND...)' forms, etc.
3240 (single_display_spec_string_p): Support property values that are
3241 lists with the argument STRING its top-level element.
3242 (display_prop_string_p): Fix the condition for processing a
3243 property that is a list to be consistent with handle_display_spec.
3244 (handle_display_spec): New function, refactored from the
3245 last portion of handle_display_prop.
3246 (compute_display_string_pos): Accept additional argument
3247 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3248 value of a `display' property is a "replacing spec".
3249 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3250 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3251 the display property, but just return a value indicating whether
3252 the display property will replace the characters it covers.
3253 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3254 frame_window_p members of struct bidi_it.
3255 (compute_display_string_pos, compute_display_string_end):
3256 New functions.
3257 (push_it): Accept second argument POSITION, where pop_it should
3258 jump to continue iteration.
3259 (reseat_1): Initialize bidi_it.disp_pos.
3260
3261 * keyboard.c (adjust_point_for_property): Adjust the call to
3262 display_prop_intangible_p to its new signature.
3263
3264 * dispextern.h (struct bidi_it): New member frame_window_p.
3265 (bidi_init_it): Update prototypes.
3266 (display_prop_intangible_p): Update prototype.
3267 (compute_display_string_pos, compute_display_string_end):
3268 Declare prototypes.
3269 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3270 EMACS_INT.
3271
3272 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 Malloc failure behavior now depends on size of allocation.
3275 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3276 * lisp.h: Change signatures accordingly.
3277 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3278 All callers changed. (Bug#8762)
3279
3280 * gnutls.c: Use Emacs's memory allocators.
3281 Without this change, the gnutls library would invoke malloc etc.
3282 directly, which causes problems on non-SYNC_INPUT hosts, and which
3283 runs afoul of improving memory_full behavior. (Bug#8761)
3284 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3285 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3286 xfree instead of the default malloc, realloc, free.
3287 (Fgnutls_boot): No need to check for memory allocation failure,
3288 since xmalloc does that for us.
3289
3290 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3291 * category.c (hash_get_category_set):
3292 * ccl.c (ccl_driver):
3293 * charset.c (Fdefine_charset_internal):
3294 * charset.h (struct charset.hash_index):
3295 * composite.c (get_composition_id, gstring_lookup_cache)
3296 (composition_gstring_put_cache):
3297 * composite.h (struct composition.hash_index):
3298 * dispextern.h (struct image.hash):
3299 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3300 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3301 (hashfn_equal, hashfn_user_defined, make_hash_table)
3302 (maybe_resize_hash_table, hash_lookup, hash_put)
3303 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3304 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3305 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3306 * image.c (make_image, search_image_cache, lookup_image)
3307 (xpm_put_color_table_h):
3308 * lisp.h (struct Lisp_Hash_Table):
3309 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3310 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3311 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3312 * alloc.c (allocate_vectorlike):
3313 Check for overflow in vector size calculations.
3314 * ccl.c (ccl_driver):
3315 Check for overflow when converting EMACS_INT to int.
3316 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3317 need to be updated by these changes.
3318 * fns.c (make_hash_table, maybe_resize_hash_table):
3319 Check for integer overflow with large hash tables.
3320 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3321 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3322 (SXHASH_REDUCE): New macro.
3323 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3324 Use it instead of discarding useful hash info with large hash values.
3325 (sxhash_float): New function.
3326 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3327 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3328 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3329 Rewrite to use FIXNUM_BITS, as this simplifies things.
3330 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3331 Adjust signatures to match updated version of code.
3332 (consing_since_gc): Now EMACS_INT, since a single hash table can
3333 use more than INT_MAX bytes.
3334
3335 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3336
3337 Make it possible to build with GCC-4.6+ -O2 -flto.
3338
3339 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3340
3341 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3342
3343 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3344 Call minibuffer-inactive-mode.
3345
3346 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3349 Update dependencies.
3350
3351 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3352
3353 * data.c (init_data): Remove code for UTS, this system is not
3354 supported anymore.
3355
3356 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3357
3358 Don't force ./temacs to start in terminal mode.
3359
3360 * frame.c (make_initial_frame): Initialize faces in all cases, not
3361 only when CANNOT_DUMP is defined.
3362 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3363
3364 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3365
3366 * dispnew.c (add_window_display_history): Use const for the string
3367 pointer. Remove declaration, not needed.
3368
3369 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3370
3371 Use 'inline', not 'INLINE'.
3372 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3373 * alloc.c, fontset.c (INLINE): Remove.
3374 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3375 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3376 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3377 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3378 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3379
3380 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3381
3382 Make it possible to run ./temacs.
3383
3384 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3385 syms_of_callproc does the same thing. Remove test for
3386 "initialized", do it in the caller.
3387 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3388
3389 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3392 (read_minibuf): Use get_minibuffer.
3393 (syms_of_minibuf): Use DEFSYM.
3394 (Qmetadata): New var.
3395 * data.c (Qbuffer): Don't make it static.
3396 (syms_of_data): Use DEFSYM.
3397
3398 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3401 (CCL_CODE_MIN): New macro.
3402
3403 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3406
3407 * eval.c (Qdebug): Now static.
3408 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3409 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3410 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3411
3412 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3413
3414 * image.c: Various fixes to ImageMagick code comments.
3415 (Fimagemagick_types): Doc fix.
3416
3417 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 Minor fixes prompted by GCC 4.6.0 warnings.
3420
3421 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3422
3423 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3424 (x_clipboard_manager_save_all): Move extern decl to ...
3425 * xterm.h: ... here, so that it can be checked for consistency.
3426
3427 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3428
3429 * xselect.c (x_clipboard_manager_save_frame)
3430 (x_clipboard_manager_save_all): New functions.
3431 (Fx_clipboard_manager_save): Lisp function deleted.
3432
3433 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3434 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3435
3436 * xterm.h: Update prototype.
3437
3438 2011-05-28 William Xu <william.xwl@gmail.com>
3439
3440 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3441 exiting (Bug#8239).
3442
3443 2011-05-28 Jim Meyering <meyering@redhat.com>
3444
3445 Avoid a sign-extension bug in crypto_hash_function.
3446 * fns.c (to_uchar): Define.
3447 (crypto_hash_function): Use it to convert some newly-signed
3448 variables to unsigned, to avoid sign-extension bugs. For example,
3449 without this change, (md5 "truc") would evaluate to
3450 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3451 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3452 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3453
3454 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 Integer overflow fixes.
3457
3458 * dbusbind.c: Serial number integer overflow fixes.
3459 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3460 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3461 to hold a serial number that is too large for a fixnum.
3462 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3463 Check for serial numbers out of range. Decode any serial number
3464 that was so large that it became a float. (Bug#8722)
3465
3466 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3467 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3468 Use XFASTINT rather than XUINT when numbers are nonnegative.
3469 (xd_append_arg, Fdbus_method_return_internal):
3470 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3471 arguments, check that Lisp number is nonnegative, rather than
3472 silently wrapping negative numbers around. (Bug#8722)
3473 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3474 (Bug#8722)
3475
3476 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3477
3478 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3479
3480 ccl: add integer overflow checks
3481 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3482 (IN_INT_RANGE): New macros.
3483 (ccl_driver): Use them to check for integer overflow when
3484 decoding a CCL program. Many of the new checks are whether XINT (x)
3485 fits in int; it doesn't always, on 64-bit hosts. The new version
3486 doesn't catch all possible integer overflows, but it's an
3487 improvement. (Bug#8719)
3488
3489 * alloc.c (make_event_array): Use XINT, not XUINT.
3490 There's no need for unsigned here.
3491
3492 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3493 This follows up to the 2011-05-06 change that substituted uintptr_t
3494 for EMACS_INT. This case wasn't caught back then.
3495
3496 Rework Fformat to avoid integer overflow issues.
3497 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3498 now (part of C89). Include <verify.h>.
3499 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3500 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3501 (Fformat): Avoid the prepass trying to compute sizes; it was only
3502 approximate and thus did not catch overflow reliably. Instead, walk
3503 through the format just once, formatting and computing sizes as we go,
3504 checking for integer overflow at every step, and allocating a larger
3505 buffer as needed. Keep track separately whether the format is
3506 multibyte. Keep only the most-recently calculated precision, rather
3507 than them all. Record whether each argument has been converted to
3508 string. Use EMACS_INT, not int, for byte and char and arg counts.
3509 Support field widths and precisions larger than INT_MAX. Avoid
3510 sprintf's undefined behavior with conversion specifications such as %#d
3511 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3512 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3513 formatting out-of-range floating point numbers with int
3514 formats. (Bug#8668)
3515
3516 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3517
3518 * data.c: Avoid integer truncation in expressions involving floats.
3519 * data.c: Include <intprops.h>.
3520 (arith_driver): When there's an integer overflow in an expression
3521 involving floating point, convert the integers to floating point
3522 so that the resulting value does not suffer from catastrophic
3523 integer truncation. For example, on a 64-bit host (* 4
3524 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3525 Do not rely on undefined behavior after integer overflow.
3526
3527 merge count_size_as_multibyte, parse_str_to_multibyte
3528 * character.c, character.h (count_size_as_multibyte):
3529 Rename from parse_str_to_multibyte; all uses changed.
3530 Check for integer overflow.
3531 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3532 since it's now a duplicate of the other. This is more of
3533 a character than a buffer op, so better that it's in character.c.
3534 * fns.c, print.c: Adjust to above changes.
3535
3536 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3539
3540 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3543 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3544 (x_clipboard_manager_save): Now static.
3545 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3546
3547 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3548 (crypto_hash_function): Now static.
3549 Fix pointer signedness problems. Avoid unnecessary initializations.
3550
3551 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3552
3553 * termhooks.h (Vselection_alist): Make it terminal-local.
3554
3555 * terminal.c (create_terminal): Initialize it.
3556
3557 * xselect.c: Support for clipboard managers.
3558 (Vselection_alist): Move to termhooks.h as terminal-local var.
3559 (LOCAL_SELECTION): New macro.
3560 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3561 (symbol_to_x_atom): Remove gratuitous arg.
3562 (x_handle_selection_request, lisp_data_to_selection_data)
3563 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3564 (x_own_selection, x_get_local_selection, x_convert_selection):
3565 New arg, specifying work frame. Use terminal-local Vselection_alist.
3566 (some_frame_on_display): Delete unused function.
3567 (Fx_own_selection_internal, Fx_get_selection_internal)
3568 (Fx_disown_selection_internal, Fx_selection_owner_p)
3569 (Fx_selection_exists_p): New optional frame arg.
3570 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3571 (x_handle_selection_clear): Don't treat other terminals with the
3572 same keyboard specially. Use the terminal-local Vselection_alist.
3573 (x_clear_frame_selections): Use Frun_hook_with_args.
3574
3575 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3576
3577 * xterm.h: Add support for those atoms.
3578
3579 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3580
3581 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3582 (converted_selections, conversion_fail_tag): New global variables.
3583 (x_selection_request_lisp_error): Free the above.
3584 (x_get_local_selection): Remove unnecessary code.
3585 (x_reply_selection_request): Args changed; handle arbitrary array
3586 of converted selections stored in converted_selections.
3587 Separate the XChangeProperty and SelectionNotify steps.
3588 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3589 (x_convert_selection): New function.
3590 (x_handle_selection_event): Simplify.
3591 (x_get_foreign_selection): Don't ignore incoming requests while
3592 waiting for an answer; this will fail when we implement
3593 SAVE_TARGETS, and seems unnecessary anyway.
3594 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3595 (Vx_sent_selection_functions): Doc fix.
3596
3597 2011-05-26 Leo Liu <sdl.web@gmail.com>
3598
3599 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3600
3601 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3602
3603 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3604
3605 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3606 for fringe update if it has periodic bitmap.
3607 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3608 and fringe_bitmap_periodic_p.
3609
3610 * fringe.c (get_fringe_bitmap_data): New function.
3611 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3612 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3613 row. Mark glyph row for fringe update if periodicity changed.
3614
3615 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3616 for fringe update unless it has periodic bitmap.
3617
3618 2011-05-25 Kenichi Handa <handa@m17n.org>
3619
3620 * xdisp.c (get_next_display_element): Set correct it->face_id for
3621 a static composition.
3622
3623 2011-05-24 Leo Liu <sdl.web@gmail.com>
3624
3625 * deps.mk (fns.o):
3626 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3627
3628 * fns.c (crypto_hash_function, Fsha1): New function.
3629 (Fmd5): Use crypto_hash_function.
3630 (syms_of_fns): Add Ssha1.
3631
3632 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3633
3634 * gnutls.c: Remove unused macros.
3635 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3636 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3637 Remove macros that are defined and never used.
3638 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3639
3640 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3641
3642 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3643 (Fx_get_selection_internal): Minor cleanup.
3644 (Fx_own_selection_internal): Rename arguments for consistency with
3645 select.el.
3646
3647 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3650
3651 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3652
3653 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3654
3655 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3656
3657 * dispnew.c (scrolling_window): Don't exclude the case that the
3658 last enabled row in the desired matrix touches the bottom boundary.
3659
3660 2011-05-21 Glenn Morris <rgm@gnu.org>
3661
3662 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3663 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3664 and add some more files.
3665
3666 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3667
3668 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3669 report_file_error introduced by the change from 2011-05-07.
3670
3671 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * systime.h (Time): Define only if emacs is defined.
3674 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3675 where the include path doesn't have X11/X.h by default. See
3676 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3677
3678 2011-05-20 Kenichi Handa <handa@m17n.org>
3679
3680 * composite.c (find_automatic_composition): Fix previous change.
3681
3682 2011-05-20 Glenn Morris <rgm@gnu.org>
3683
3684 * lisp.mk: New file, split from Makefile.in.
3685 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3686 (shortlisp): Remove.
3687 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3688
3689 2011-05-19 Glenn Morris <rgm@gnu.org>
3690
3691 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3692 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3693 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3694 (lisp): Set the order to that of loadup.el.
3695 (shortlisp): Make it a copy of $lisp.
3696 (SOME_MACHINE_LISP): Remove.
3697 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3698 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3699
3700 2011-05-18 Kenichi Handa <handa@m17n.org>
3701
3702 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3703 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3704 (find_automatic_composition): Mostly rewrite for efficiency.
3705
3706 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * makefile.w32-in: Update dependencies.
3709
3710 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3711
3712 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3713 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3714
3715 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3716
3717 Fix some integer overflow issues, such as string length overflow.
3718
3719 * insdel.c (count_size_as_multibyte): Check for string overflow.
3720
3721 * character.c (lisp_string_width): Check for string overflow.
3722 Use EMACS_INT, not int, for string indexes and lengths; in
3723 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3724 the resulting string length overflows an EMACS_INT; instead,
3725 report a string overflow if no precision given. When checking for
3726 precision exhaustion, use a check that cannot possibly have
3727 integer overflow. (Bug#8675)
3728 * character.h (lisp_string_width): Adjust to new signature.
3729
3730 * alloc.c (string_overflow): New function.
3731 (Fmake_string): Use it. This doesn't change behavior, but saves
3732 a few bytes and will simplify future changes.
3733 * character.c (string_escape_byte8): Likewise.
3734 * lisp.h (string_overflow): New decl.
3735
3736 Fixups, following up to the user-interface timestamp change.
3737 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3738 for UI timestamps, instead of unsigned long.
3739 * msdos.c (mouse_get_pos): Likewise.
3740 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3741 * w32gui.h (Time): Define by including "systime.h" rather than by
3742 declaring it ourselves. (Bug#8664)
3743
3744 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3745 * image.c (clear_image_cache): Likewise.
3746
3747 * term.c (term_mouse_position): Don't assume time_t wraparound.
3748
3749 Be more systematic about user-interface timestamps.
3750 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3751 and sometimes 'EMACS_UINT', to represent these timestamps.
3752 This change causes it to use 'Time' uniformly, as that's what X uses.
3753 This makes the code easier to follow, and makes it easier to catch
3754 integer overflow bugs such as Bug#8664.
3755 * frame.c (Fmouse_position, Fmouse_pixel_position):
3756 Use Time, not unsigned long, for user-interface timestamps.
3757 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3758 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3759 * keyboard.h (last_event_timestamp): Likewise.
3760 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3761 * menu.h (xmenu_show): Likewise.
3762 * term.c (term_mouse_position): Likewise.
3763 * termhooks.h (struct input_event.timestamp): Likewise.
3764 (struct terminal.mouse_position_hook): Likewise.
3765 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3766 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3767 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3768 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3769 what it was before.
3770 * menu.h, termhooks.h: Include "systime.h", for Time.
3771
3772 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3773 Don't assume that the difference between two unsigned long values
3774 can fit into an integer. At this point, we know button_down_time
3775 <= event->timestamp, so the difference must be nonnegative, so
3776 there's no need to cast the result if double-click-time is
3777 nonnegative, as it should be; check that it's nonnegative, just in
3778 case. This bug is triggered when events are more than 2**31 ms
3779 apart (about 25 days). (Bug#8664)
3780
3781 * xselect.c (last_event_timestamp): Remove duplicate decl.
3782 (x_own_selection): Remove needless cast to unsigned long.
3783
3784 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3785 that always fit in int. Use a sentinel instead of a counter, to
3786 avoid a temp and to allay GCC's concerns about possible int overflow.
3787 * frame.h (struct frame): Use int for menu_bar_items_used
3788 instead of EMACS_INT, since it always fits in int.
3789
3790 * menu.c (grow_menu_items): Check for int overflow.
3791
3792 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3793
3794 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3795 Before, the code was not consistent. These values cannot exceed
3796 2**31 - 1 so there's no need to make them unsigned.
3797 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3798 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3799 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3800 as modifiers.
3801 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3802
3803 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3804 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3805 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3806 presumably because the widths might not match.
3807
3808 * window.c (size_window): Avoid needless test at loop start.
3809
3810 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3811
3812 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3813
3814 2011-05-12 Drew Adams <drew.adams@oracle.com>
3815
3816 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3817
3818 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3819
3820 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3821 `width' to `bar_area_x' and `bar_area_width', respectively.
3822 (x_scroll_run): Take account of fringe background extension.
3823
3824 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3825 Rename local vars `left' and `width' to `bar_area_x' and
3826 `bar_area_width', respectively.
3827 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3828 background extension.
3829
3830 2011-05-10 Jim Meyering <meyering@redhat.com>
3831
3832 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3833
3834 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3835
3836 * image.c (Finit_image_library): Return t for built-in image types,
3837 like pbm and xbm. (Bug#8640)
3838
3839 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3840
3841 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3842
3843 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3844
3845 * w32console.c (Fset_screen_color): Doc fix.
3846 (Fget_screen_color): New function.
3847 (syms_of_ntterm): Defsubr it.
3848
3849 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3850 unlink the temporary file if Fcall_process didn't create it in the
3851 first place.
3852 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3853 child process will be redirected to a file specified with `:file'.
3854 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3855 cue to call_process_cleanup not to close that handle.
3856
3857 2011-05-07 Ben Key <bkey76@gmail.com>
3858
3859 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3860 one of two shell specific rules, either bootstrap-temacs-CMD or
3861 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3862 to the previous implementation of the bootstrap-temacs rule.
3863 The bootstrap-temacs-CMD rule is similar to the previous
3864 implementation of the bootstrap-temacs rule except that it
3865 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3866 variable.
3867
3868 These changes, along with some changes to nt/configure.bat,
3869 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3870 earlier fix to add support for --cflags and --ldflags options
3871 that include quotes so that it works whether make uses cmd or
3872 sh as the shell.
3873
3874 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3875
3876 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3877 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3878 is a constant.
3879 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3880 a string. Handle both cases.
3881 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3882 (Fdbus_register_method): Use Qinvalid_function.
3883
3884 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3885
3886 * makefile.w32-in: Update dependencies.
3887 (LISP_H): Add inttypes.h and stdin.h.
3888 (PROCESS_H): Add unistd.h.
3889
3890 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3891
3892 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3893 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3894
3895 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3898
3899 * term.c (vfatal): Remove stray call to va_end.
3900 It's not needed and the C Standard doesn't allow it here anyway.
3901
3902 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3903 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3904
3905 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3906 bytes.
3907
3908 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3909
3910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3911
3912 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3913
3914 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3915
3916 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3917
3918 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3919 * charset.c (Fdefine_charset_internal): Don't initialize
3920 charset.code_space[15]. The value was garbage, on hosts with
3921 32-bit int (Bug#8600).
3922
3923 * lread.c (read_integer): Be more consistent with string-to-number.
3924 Use string_to_number to do the actual conversion; this avoids
3925 rounding errors and fixes some other screwups. Without this fix,
3926 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3927 (digit_to_number): Move earlier, for benefit of read_integer.
3928 Return -1 if the digit is out of range for the base, -2 if it is
3929 not a digit in any supported base. (Bug#8602)
3930
3931 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3932
3933 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3934 to match comment at start of function. This also removes a
3935 GCC warning about overflow in a 32+64-bit port.
3936
3937 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3938
3939 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3940 Reported by Stefan Monnier in
3941 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3942 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3943 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3944
3945 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3946 (EMACS_UINTPTR): Likewise, with uintptr_t.
3947
3948 * lisp.h: Prefer 64-bit EMACS_INT if available.
3949 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3950 on 32-bit hosts that have 64-bit int, so that they can access
3951 large files.
3952 However, temporarily disable this change unless the temporary
3953 symbol WIDE_EMACS_INT is defined.
3954
3955 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3956
3957 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3958 This removes an assumption that EMACS_INT and long are the same
3959 width as pointers. The assumption is true for Emacs porting targets
3960 now, but we want to make other targets possible.
3961 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3962 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3963 In the rest of the code, change types of integers that hold casted
3964 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3965 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3966 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3967 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3968 No need to cast type when ORing.
3969 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3970 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3971 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3972 assume EMACS_INT is the same width as char *.
3973 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3974 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3975 Remove no-longer-needed casts.
3976 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3977 (xg_tool_bar_help_callback, xg_make_tool_item):
3978 Use EMACS_INTPTR to hold an integer
3979 that will be cast to void *; this can avoid a GCC warning
3980 if EMACS_INT is not the same width as void *.
3981 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3982 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3983 (current_message_1, set_message_1):
3984 Use a local to convert to proper width without a cast.
3985 * xmenu.c (dialog_selection_callback): Likewise.
3986
3987 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3988 Also, don't assume VALBITS / RAND_BITS is less than 5,
3989 and don't rely on undefined behavior when shifting a 1 left into
3990 the sign bit.
3991 * lisp.h (get_random): Change signature to match.
3992
3993 * lread.c (hash_string): Use size_t, not int, for hash computation.
3994 Normally we prefer signed values; but hashing is special, because
3995 it's better to use unsigned division on hash table sizes so that
3996 the remainder is nonnegative. Also, size_t is the natural width
3997 for hashing into memory. The previous code used 'int', which doesn't
3998 retain enough info to hash well into very large tables.
3999 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4000
4001 * dbusbind.c: Don't possibly lose pointer info when converting.
4002 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4003 Use XPNTR rather than XHASH, so that the high-order bits of
4004 the pointer aren't lost when converting through void *.
4005
4006 * eval.c (Fautoload): Don't double-shift a pointer.
4007
4008 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4009
4010 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4011
4012 * gnutls.c (DEF_GNUTLS_FN):
4013 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4014
4015 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4016
4017 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4018 marker. (Bug#8610)
4019
4020 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4021
4022 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4023 New version that can reserve upto 2GB of heap space.
4024
4025 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4026
4027 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4028
4029 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4030
4031 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4032 `gnutls_certificate_set_x509_key_file'.
4033
4034 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4037 Update dependencies.
4038
4039 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4040
4041 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4042 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4043 Remove unused parameter `fildes'.
4044 * process.c (read_process_output, send_process): Don't pass it.
4045
4046 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4047
4048 Fix previous change: the library cache is defined in w32.c.
4049 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4050 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4051
4052 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4053
4054 Implement dynamic loading of GnuTLS on Windows.
4055
4056 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4057 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4058 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4059 Declare.
4060
4061 * gnutls.c (Qgnutls_dll): Define.
4062 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4063 (gnutls_*): Declare function pointers.
4064 (init_gnutls_functions): New function to initialize function pointers.
4065 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4066 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4067 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4068 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4069 (emacs_gnutls_write, emacs_gnutls_read)
4070 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4071 (Fgnutls_available_p): New function.
4072 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4073 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4074 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4075
4076 * image.c: Include w32.h.
4077 (Vimage_type_cache): Delete.
4078 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4079 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4080 (w32_delayed_load): Move to w32.c.
4081
4082 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4083
4084 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4085 (w32_delayed_load): Move from image.c. When loading a library, record
4086 its filename in the :loaded-from property of the library id.
4087 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4088 Initialize and staticpro them.
4089 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4090
4091 * process.c: Include lisp.h before w32.h, not after.
4092 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4093 instead of gnutls_record_check_pending.
4094
4095 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4096
4097 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4098
4099 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4100 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4101 as passed in.
4102
4103 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4104
4105 * xterm.c (x_set_frame_alpha): Do not set property on anything
4106 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4107
4108 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4109
4110 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4111
4112 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4113
4114 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4115 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4116 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4117 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4118 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4119 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4120 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4121 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4122 (Qgnutls_bootprop_callbacks_verify): Make static.
4123
4124 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4125
4126 * callproc.c: Indentation fixup.
4127
4128 * sysdep.c (wait_for_termination_1): Make static.
4129 (wait_for_termination, interruptible_wait_for_termination):
4130 Move after wait_for_termination_1.
4131
4132 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133
4134 * sysdep.c (interruptible_wait_for_termination): New function
4135 which is like wait_for_termination, but allows keyboard
4136 interruptions.
4137
4138 * callproc.c (Fcall_process): Add (:file "file") as an option for
4139 the STDOUT buffer.
4140 (Fcall_process_region): Ditto.
4141
4142 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4143
4144 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4145 rather than `XVECTOR (FOO)->size'.
4146
4147 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4148 inttypes.h, as a gnulib replacement is used if it not available in
4149 system headers.
4150
4151 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4152
4153 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4154 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4155 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4156
4157 * coding.c (coding_alloc_by_realloc): Error out if destination
4158 will grow beyond MOST_POSITIVE_FIXNUM.
4159 (decode_coding_emacs_mule): Abort if there isn't enough place in
4160 charbuf for the composition carryover bytes. Reserve an extra
4161 space for up to 2 characters produced in a loop.
4162 (decode_coding_iso_2022): Abort if there isn't enough place in
4163 charbuf for the composition carryover bytes.
4164
4165 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4166
4167 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4168 aborting when %lld or %lll format is passed.
4169 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4170 %llo or %llx format is passed. (Bug#8545)
4171
4172 * window.c (window_scroll_line_based): Use a marker instead of
4173 simple variables to record original value of point. (Bug#7952)
4174
4175 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4176 produced by %s or %c overflows available buffer space. (Bug#8545)
4177
4178 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4181 (SIZE_MAX): Move defn after all includes, as they might #define it.
4182
4183 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4184
4185 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4186
4187 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4188
4189 * keyboard.c (Qdelayed_warnings_hook): Define.
4190 (command_loop_1): Run `delayed-warnings-hook'
4191 if Vdelayed_warnings_list is non-nil.
4192 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4193 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4194
4195 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4196
4197 * doprnt.c (doprnt): Don't return value smaller than the buffer
4198 size if the message was truncated. (Bug#8545).
4199
4200 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4201
4202 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4203 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4204
4205 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4208
4209 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4210
4211 * makefile.w32-in: Update dependencies.
4212
4213 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4214
4215 Improve `doprnt' and its usage. (Bug#8545)
4216 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4217 `format_end'. Remove support for %l as a conversion specifier.
4218 Don't use xrealloc. Improve diagnostics when the %l size modifier
4219 is used. Update the commentary.
4220
4221 * eval.c (verror): Simplify calculation of size_t.
4222
4223 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4224 messages.
4225
4226 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4227
4228 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4229 change.
4230
4231 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4232
4233 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4234 This makes this file independent of the recent pseudovector change.
4235
4236 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4237
4238 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4239
4240 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4241 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4242 Remove unused local.
4243 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4244
4245 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4246 GCC 4.6.0 optimizes based on type-based alias analysis.
4247 For example, if b is of type struct buffer * and v of type struct
4248 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4249 != &v->size, and therefore "v->size = 1; b->size = 2; return
4250 v->size;" must therefore return 1. This assumption is incorrect
4251 for Emacs, since it type-puns struct Lisp_Vector * with many other
4252 types. To fix this problem, this patch adds a new type struct
4253 vectorlike_header that documents the constraints on layout of vectors
4254 and pseudovectors, and helps optimizing compilers not get fooled
4255 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4256 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4257 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4258 the size member.
4259 (XSETPVECTYPE): Rewrite in terms of new macro.
4260 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4261 This is a bit clearer, and further avoids the possibility of
4262 undesirable aliasing.
4263 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4264 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4265 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4266 since Lisp_Subr is a special case (no "next" field).
4267 (ASIZE): Now uses header.size rather than size.
4268 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4269 to avoid the hassle of writing XVECTOR (foo)->header.size.
4270 (struct vectorlike_header): New type.
4271 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4272 object, to help avoid aliasing.
4273 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4274 (SUBRP): Likewise, since Lisp_Subr is a special case.
4275 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4276 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4277 (struct Lisp_Hash_Table): Combine first two members into a single
4278 struct vectorlike_header member. All uses of "size" and "next" members
4279 changed to be "header.size" and "header.next".
4280 * buffer.h (struct buffer): Likewise.
4281 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4282 * frame.h (struct frame): Likewise.
4283 * process.h (struct Lisp_Process): Likewise.
4284 * termhooks.h (struct terminal): Likewise.
4285 * window.c (struct save_window_data, struct saved_window): Likewise.
4286 * window.h (struct window): Likewise.
4287 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4288 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4289 * buffer.c (init_buffer_once): Likewise.
4290 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4291 special case.
4292 * process.c (Fformat_network_address): Use local var for size,
4293 for brevity.
4294
4295 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4296
4297 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4298 * data.c (atof): Remove decl; no longer used or needed.
4299 (digit_to_number): Move to lread.c.
4300 (Fstring_to_number): Use new string_to_number function, to be
4301 consistent with how the Lisp reader treats infinities and NaNs.
4302 Do not assume that floating-point numbers represent EMACS_INT
4303 without losing information; this is not true on most 64-bit hosts.
4304 Avoid double-rounding errors, by insisting on integers when
4305 parsing non-base-10 numbers, as the documentation specifies.
4306 * lisp.h (string_to_number): New decl, replacing ...
4307 (isfloat_string): Remove.
4308 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4309 (read1): Do not accept +. and -. as integers; this
4310 appears to have been a coding error. Similarly, do not accept
4311 strings like +-1e0 as floating point numbers. Do not report
4312 overflow for integer overflows unless the base is not 10 which
4313 means we have no simple and reliable way to continue.
4314 Break out the floating-point parsing into a new
4315 function string_to_number, so that Fstring_to_number parses
4316 floating point numbers consistently with the Lisp reader.
4317 (digit_to_number): Move here from data.c. Make it static inline.
4318 (E_CHAR, EXP_INT): Remove, replacing with ...
4319 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4320 (string_to_number): New function, replacing isfloat_string.
4321 This function checks for valid syntax and produces the resulting
4322 Lisp float number too. Rework it so that string-to-number
4323 no longer mishandles examples like "1.0e+". Use strtoumax,
4324 so that overflow for non-base-10 numbers is reported only when
4325 there's no portable and simple way to convert to floating point.
4326
4327 * textprop.c (set_text_properties_1): Rewrite for clarity,
4328 and to avoid GCC warning about integer overflow.
4329
4330 * intervals.h (struct interval): Use EMACS_INT for members
4331 where EMACS_UINT might cause problems. See
4332 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4333 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4334 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4335 All uses changed.
4336 (offset_intervals): Tell GCC not to worry about length overflow
4337 when negating a negative length.
4338
4339 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4340 (overrun_check_free): Likewise.
4341
4342 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4343 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4344 word size.
4345
4346 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4347 (gnutls_make_error): Rename local to avoid shadowing.
4348 (gnutls_emacs_global_deinit): ifdef out; not used.
4349 (Fgnutls_boot): Use const for pointer to readonly storage.
4350 Comment out unused local. Fix pointer signedness problems.
4351
4352 * lread.c (openp): Don't stuff size_t into an 'int'.
4353 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4354 about possible signed overflow.
4355
4356 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4357 (GDK_KEY_g): Don't define if already defined.
4358 (xg_prepare_tooltip): Avoid pointer signedness problem.
4359 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4360
4361 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4362 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4363
4364 * xfns.c (Fx_window_property): Simplify a bit,
4365 to make a bit faster and to avoid GCC 4.6.0 warning.
4366 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4367
4368 * fns.c (internal_equal): Don't assume size_t fits in int.
4369
4370 * alloc.c (compact_small_strings): Tighten assertion a little.
4371
4372 Replace pEd with more-general pI, and fix some printf arg casts.
4373 * lisp.h (pI): New macro, generalizing old pEd macro to other
4374 conversion specifiers. For example, use "...%"pI"d..." rather
4375 than "...%"pEd"...".
4376 (pEd): Remove. All uses replaced with similar uses of pI.
4377 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4378 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4379 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4380 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4381 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4382 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4383 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4384 64-bit hosts.
4385 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4386 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4387 * print.c (safe_debug_print, print_object): Likewise.
4388 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4389 to int.
4390 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4391 avoiding the 0 flag, which is not portable.
4392 * process.c (Fmake_network_process): Use pI to avoid cast.
4393 * region-cache.c (pp_cache): Likewise.
4394 * xdisp.c (decode_mode_spec): Likewise.
4395 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4396 behavior on 64-bit hosts with printf arg.
4397 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4398 (x_stop_queuing_selection_requests): Likewise.
4399 (x_get_window_property): Don't truncate byte count to an 'int'
4400 when tracing.
4401
4402 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4403 here, since it parses constructs like leading '-' and spaces,
4404 which are not wanted; and it overflows with large numbers.
4405 Instead, simply match F[0-9]+, which is what is wanted anyway.
4406
4407 * alloc.c: Remove unportable assumptions about struct layout.
4408 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4409 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4410 (allocate_vectorlike, make_pure_vector): Use the new macros,
4411 plus offsetof, to remove unportable assumptions about struct layout.
4412 These assumptions hold on all porting targets that I know of, but
4413 they are not guaranteed, they're easy to remove, and removing them
4414 makes further changes easier.
4415
4416 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4417 This doesn't fix a bug but makes the code clearer.
4418 (string_overrun_cookie): Now const. Use initializers that
4419 don't formally overflow signed char, to avoid warnings.
4420 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4421 can cause Emacs to crash when string overrun checking is enabled.
4422 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4423 multiple of sizeof (EMACS_INT); it need not be, if
4424 alignof(EMACS_INT) < sizeof (EMACS_INT).
4425 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4426
4427 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4430
4431 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4432
4433 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4434 supposed to be handshaking. (Bug#8556)
4435 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4436
4437 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4438
4439 * lisp.h (Qdebug): List symbol.
4440 * eval.c (Qdebug): Restore global linkage.
4441 * keyboard.c (debug-on-event): New variable.
4442 (handle_user_signal): Break into debugger when debug-on-event
4443 matches the current signal symbol.
4444
4445 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4446
4447 * alloc.c (check_sblock, check_string_bytes)
4448 (check_string_free_list): Convert to standard C.
4449
4450 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4451
4452 * w32.c (emacs_gnutls_push): Fix typo.
4453
4454 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4455
4456 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4457 "cast to pointer from integer of different size".
4458
4459 Improve doprnt and its use in verror. (Bug#8545)
4460 * doprnt.c (doprnt): Document the set of format control sequences
4461 supported by the function. Use SAFE_ALLOCA instead of always
4462 using `alloca'.
4463
4464 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4465 is one byte too soon. Don't use xrealloc; instead xfree and
4466 xmalloc anew.
4467
4468 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4469
4470 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4471 callbacks stage.
4472
4473 * gnutls.c: Renamed global_initialized to
4474 gnutls_global_initialized. Added internals for the
4475 :verify-hostname-error, :verify-error, and :verify-flags
4476 parameters of `gnutls-boot' and documented those parameters in the
4477 docstring. Start callback support.
4478 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4479 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4480 on error. Return error code.
4481 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4482 (emacs_gnutls_read): Likewise.
4483 (Fgnutls_boot): Return handshake error code.
4484 (emacs_gnutls_handle_error): New function.
4485 (wsaerror_to_errno): Likewise.
4486
4487 * w32.h (emacs_gnutls_pull): Add prototype.
4488 (emacs_gnutls_push): Likewise.
4489
4490 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4491 (emacs_gnutls_push): Likewise.
4492
4493 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4494
4495 * process.c (wait_reading_process_output): Check if GnuTLS
4496 buffered some data internally if no FDs are set for TLS
4497 connections.
4498
4499 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4500 (LIBS): Link to USER_LIBS.
4501 ($(BLD)/gnutls.$(0)): New target.
4502
4503 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4504
4505 * xdisp.c (handle_single_display_spec): Rename the
4506 display_replaced_before_p argument into display_replaced_p, to
4507 make it consistent with the commentary. Fix typos in the
4508 commentary.
4509
4510 * textprop.c (syms_of_textprop): Remove dead code.
4511 (copy_text_properties): Delete obsolete commentary about an
4512 interface that was deleted long ago. Fix typos in the description
4513 of arguments.
4514
4515 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4516 to changes in oldXMenu/XMenu.h from 2011-04-16.
4517 <menu_help_message, prev_menu_help_message>: Constify.
4518 (IT_menu_make_room): menu->help_text is now `const char **';
4519 adjust.
4520
4521 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4522 to changes in oldXMenu/XMenu.h from 2011-04-16.
4523 (struct XMenu): Declare `help_text' `const char **'.
4524
4525 * xfaces.c <Qunspecified>: Make extern again.
4526
4527 * syntax.c: Include sys/types.h before including regex.h, as
4528 required by Posix.
4529
4530 * doc.c (get_doc_string): Improve the format passed to `error'.
4531
4532 * doprnt.c (doprnt): Improve commentary.
4533
4534 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4535
4536 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4537 them with etags.
4538
4539 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4540 changes in globals.h immediately force recompilation.
4541 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4542 $(CURDIR)/s/ms-w32.h.
4543 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4544
4545 * character.c (Fchar_direction): Function deleted.
4546 (syms_of_character): Don't defsubr it.
4547 <char-direction-table>: Deleted.
4548
4549 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4550
4551 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4552 * doprnt.c: Include limits.h.
4553 (SIZE_MAX): New macro.
4554 (doprnt): Return a size_t value. 2nd arg is now size_t.
4555 Many local variables are now size_t instead of int or unsigned.
4556 Improve overflow protection. Support `l' modifier for integer
4557 conversions. Support %l conversion. Don't assume an EMACS_INT
4558 argument for integer conversions and for %c.
4559
4560 * lisp.h (doprnt): Restore prototype.
4561
4562 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4563 $(SRC)/character.h.
4564
4565 * Makefile.in (base_obj): Add back doprnt.o.
4566
4567 * deps.mk (doprnt.o): Add back prerequisites.
4568 (callint.o): Depend on character.h.
4569
4570 * eval.c (internal_lisp_condition_case): Include the handler
4571 representation in the error message.
4572 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4573 when breaking from the loop.
4574
4575 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4576
4577 * callint.c (Fcall_interactively): When displaying error message
4578 about invalid control letter, pass the character's codepoint, not
4579 a pointer to its multibyte form. Improve display of the character
4580 in octal and display also its hex code.
4581
4582 * character.c (char_string): Use %x to display the (unsigned)
4583 codepoint of an invalid character, to avoid displaying a bogus
4584 negative value.
4585
4586 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4587 `error', not SYMBOL_NAME itself.
4588
4589 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4590 character arguments to `error'.
4591
4592 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4593 to `error' in error message about FINAL_CHAR argument. Make sure
4594 FINAL_CHAR is a character, and use %c when it is passed as
4595 argument to `error'.
4596
4597 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4598
4599 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4600
4601 * w32.c: Include <time.h>.
4602 (sys_localtime): New function.
4603
4604 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4605
4606 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4607
4608 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4609
4610 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4611
4612 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4613 zombies (Bug#8467).
4614
4615 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4616
4617 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4618 gl_state.e_property when gl_state.object is Qt.
4619
4620 * insdel.c (make_gap_larger): Remove limitation of buffer size
4621 to <= INT_MAX.
4622
4623 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4624
4625 * xdisp.c (lookup_glyphless_char_display)
4626 (produce_glyphless_glyph): Handle cons cell entry in
4627 glyphless-char-display.
4628 (Vglyphless_char_display): Document it.
4629
4630 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4631 glyphless-char-display.
4632
4633 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4634
4635 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4636
4637 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4638
4639 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4640 definition for no-X builds.
4641
4642 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 Static checks with GCC 4.6.0 and non-default toolkits.
4645
4646 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4647
4648 * process.c (keyboard_bit_set): Define only if SIGIO.
4649 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4650 (send_process): Repair possible setjmp clobbering.
4651
4652 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4653
4654 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4655
4656 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4657
4658 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4659 Define only if needed.
4660
4661 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4662 by pacifying GCC about it. Maybe it's time to retire it?
4663 * xfaces.c (USG, __TIMEVAL__): Likewise.
4664
4665 * dispextern.h (struct redisplay_interface): Rename param
4666 to avoid shadowing.
4667 * termhooks.h (struct terminal): Likewise.
4668 * xterm.c (xembed_send_message): Likewise.
4669
4670 * insdel.c (make_gap_smaller): Define only if
4671 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4672
4673 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4674 it.
4675
4676 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4677 so that we aren't warned about unused symbols.
4678
4679 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4680
4681 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4682
4683 * xfns.c (x_real_positions): Mark locals as initialized.
4684
4685 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4686
4687 * xterm.c: Fix problems found by static analysis with other toolkits.
4688 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4689 (x_dispatch_event): Declare static if USE_GTK, and
4690 define if USE_GTK || USE_X_TOOLKIT.
4691 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4692 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4693 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4694 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4695
4696 * xmenu.c (menu_help_callback): Pointer type fixes.
4697 Use const pointers when pointing at readonly data. Avoid pointer
4698 signedness clashes.
4699 (FALSE): Remove unused macro.
4700 (update_frame_menubar): Remove unused decl.
4701
4702 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4703
4704 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4705 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4706 (single_menu_item): Rename local to avoid shadowing.
4707
4708 * keyboard.c (make_lispy_event): Remove unused local var.
4709
4710 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4711 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4712
4713 * bitmaps: Change bitmaps from unsigned char back to the X11
4714 compatible char. Avoid the old compiler warnings about
4715 out-of-range initializers by using, for example, '\xab' rather
4716 than 0xab.
4717
4718 * xgselect.c (xgselect_initialize): Check vs interface
4719 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4720
4721 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4722
4723 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4724 to read-only memory.
4725
4726 * fns.c (vector): Remove; this old hack is no longer needed.
4727
4728 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4729 Remove unused var.
4730 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4731
4732 * xrdb.c (x_load_resources): Omit unused local.
4733
4734 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4735 (x_window): Rename locals to avoid shadowing.
4736 (USG): Use the kludged USG macro, to pacify gcc.
4737
4738 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4739 (x_term_init): Remove local to avoid shadowing.
4740
4741 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4742
4743 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4744 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4745
4746 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4747
4748 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4749
4750 Fix regex.c, syntax.c and friends for buffers > 2GB.
4751 * syntax.h (struct gl_state_s): Declare character position members
4752 EMACS_INT.
4753
4754 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4755
4756 * textprop.c (verify_interval_modification, interval_of):
4757 Declare arguments EMACS_INT.
4758
4759 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4760 EMACS_INT.
4761
4762 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4763
4764 * indent.c (Fvertical_motion): Local variable it_start is now
4765 EMACS_INT.
4766
4767 * regex.c (re_match, re_match_2, re_match_2_internal)
4768 (bcmp_translate, regcomp, regexec, print_double_string)
4769 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4770 (re_compile_pattern, re_exec): Declare arguments and local
4771 variables `size_t' and `ssize_t' and return values `regoff_t', as
4772 appropriate.
4773 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4774 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4775 <compile_stack_type>: `size' and `avail' are now `size_t'.
4776
4777 * regex.h <regoff_t>: Use ssize_t, not int.
4778 (re_search, re_search_2, re_match, re_match_2): Arguments that
4779 specify buffer/string position and length are now ssize_t and
4780 size_t. Return type is regoff_t.
4781
4782 2011-04-16 Ben Key <bkey76@gmail.com>
4783
4784 * nsfont.m: Fixed bugs in ns_get_family and
4785 ns_descriptor_to_entity that were caused by using free to
4786 deallocate memory blocks that were allocated by xmalloc (via
4787 xstrdup). This caused Emacs to crash when compiled with
4788 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4789 --enable-checking=xmallocoverrun). xfree is now used to
4790 deallocate these memory blocks.
4791
4792 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4795
4796 emacs_write: Accept and return EMACS_INT for sizes.
4797 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4798 et seq.
4799 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4800 Accept and return EMACS_INT.
4801 (emacs_gnutls_write): Return the number of bytes written on
4802 partial writes.
4803 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4804 (emacs_read, emacs_write): Remove check for negative size, as the
4805 Emacs source code has been audited now.
4806 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4807 (emacs_read, emacs_write): Use it.
4808 * process.c (send_process): Adjust to the new signatures of
4809 emacs_write and emacs_gnutls_write. Do not attempt to store
4810 a byte offset into an 'int'; it might overflow.
4811 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4812
4813 * sound.c: Don't assume sizes fit in 'int'.
4814 (struct sound_device.period_size, alsa_period_size):
4815 Return EMACS_INT, not int.
4816 (struct sound_device.write, vox_write, alsa_write):
4817 Accept EMACS_INT, not int.
4818 (wav_play, au_play): Use EMACS_INT to store sizes and to
4819 record read return values.
4820
4821 2011-04-15 Ben Key <bkey76@gmail.com>
4822
4823 * keyboard.c (Qundefined): Don't declare static since it is used
4824 in nsfns.m.
4825 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4826 static since they are used in nsfont.m.
4827
4828 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4829
4830 * process.c (Qprocessp): Don't declare static.
4831 * lisp.h (Qprocessp): Declare again.
4832
4833 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4836
4837 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4838
4839 Improve C-level modularity by making more things 'static'.
4840
4841 Don't publish debugger-only interfaces to other modules.
4842 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4843 (verify_bytepos, count_markers): Move decls to the only modules
4844 that need them.
4845 * region-cache.h (pp_cache): Likewise.
4846 * window.h (check_all_windows): Likewise.
4847 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4848
4849 * sysdep.c (croak): Now static, if
4850 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4851 * syssignal.h (croak): Declare only if not static.
4852
4853 * alloc.c (refill_memory_reserve): Now static if
4854 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4855 * lisp.h (refill_memory_reserve): Declare only if not static.
4856
4857 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4858 Define only if USE_LUCID.
4859
4860 * xrdb.c (x_customization_string, x_rm_string): Now static.
4861
4862 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4863 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4864
4865 * xdisp.c (draw_row_with_mouse_face): Now static.
4866 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4867
4868 * window.h (check_all_windows): Mark externally visible.
4869
4870 * window.c (window_deletion_count): Now static.
4871
4872 * undo.c: Make symbols static if they're not exported.
4873 (last_undo_buffer, last_boundary_position, pending_boundary):
4874 Now static.
4875
4876 * textprop.c (interval_insert_behind_hooks): Now static.
4877 (interval_insert_in_front_hooks): Likewise.
4878
4879 * term.c: Make symbols static if they're not exported.
4880 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4881 (max_frame_lines, tty_set_terminal_modes):
4882 (tty_reset_terminal_modes, tty_turn_off_highlight):
4883 (get_tty_terminal): Now static.
4884 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4885 * termhooks.h (term_mouse_moveto): Do not declare if
4886 HAVE_WINDOW_SYSTEM.
4887 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4888 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4889
4890 * sysdep.c: Make symbols static if they're not exported.
4891 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4892 Now static.
4893 (sigprocmask_set, full_mask): Remove; unused.
4894 (wait_debugging): Mark as visible.
4895 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4896 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4897
4898 * syntax.c (syntax_temp): Define only if !__GNUC__.
4899
4900 * sound.c (current_sound_device, current_sound): Now static.
4901
4902 * search.c (searchbufs, searchbuf_head): Now static.
4903
4904 * scroll.c (scroll_cost): Remove; unused.
4905 * dispextern.h (scroll_cost): Remove decl.
4906
4907 * region-cache.h (pp_cache): Mark as externally visible.
4908
4909 * process.c: Make symbols static if they're not exported.
4910 (process_tick, update_tick, create_process, chan_process):
4911 (Vprocess_alist, proc_buffered_char, datagram_access):
4912 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4913 (deactivate_process): Mark defn as static, as well as decl.
4914 * lisp.h (create_process): Remove decl.
4915 * process.h (chan_process, Vprocess_alist): Remove decls.
4916
4917 * print.c: Make symbols static if they're not exported.
4918 (print_depth, new_backquote_output, being_printed, print_buffer):
4919 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4920 (print_interval, print_number_index, initial_stderr_stream):
4921 Now static.
4922 * lisp.h (Fprinc): Remove decl.
4923 (debug_output_compilation_hack): Mark as externally visible.
4924
4925 * sysdep.c (croak): Move decl from here to syssignal.h.
4926 * syssignal.h (croak): Put it here, so the API can be checked when
4927 'croak' is called from dissociate_if_controlling_tty.
4928
4929 * minibuf.c: Make symbols static if they're not exported.
4930 (minibuf_save_list, choose_minibuf_frame): Now static.
4931 * lisp.h (choose_minibuf_frame): Remove decl.
4932
4933 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4934
4935 * lread.c: Make symbols static if they're not exported.
4936 (read_objects, initial_obarray, oblookup_last_bucket_number):
4937 Now static.
4938 (make_symbol): Remove; unused.
4939 * lisp.h (initial_obarray, make_symbol): Remove decls.
4940
4941 * keyboard.c: Make symbols static if they're not exported.
4942 (single_kboard, recent_keys_index, total_keys, recent_keys):
4943 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4944 (this_single_command_key_start, echoing, last_auto_save):
4945 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4946 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4947 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4948 (Vlispy_mouse_stem, double_click_count):
4949 Now static.
4950 (force_auto_save_soon): Define only if SIGDANGER.
4951 (ignore_mouse_drag_p): Now static if
4952 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4953 (print_help): Remove; unused.
4954 (stop_character, last_timer_event): Mark as externally visible.
4955 * keyboard.h (ignore_mouse_drag_p): Declare only if
4956 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4957 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4958 * lisp.h (echoing): Remove decl.
4959 (force_auto_save_soon): Declare only if SIGDANGER.
4960 * xdisp.c (redisplay_window): Simplify code, to make it more
4961 obvious that ignore_mouse_drag_p is not accessed if !defined
4962 USE_GTK && !defined HAVE_NS.
4963
4964 * intervals.c: Make symbols static if they're not exported.
4965 (merge_properties_sticky, merge_interval_right, delete_interval):
4966 Now static.
4967 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4968
4969 * insdel.c: Make symbols static if they're not exported.
4970 However, leave prepare_to_modify_buffer alone. It's never
4971 called from outside this function, but that appears to be a bug.
4972 (combine_after_change_list, combine_after_change_buffer):
4973 (adjust_after_replace, signal_before_change): Now static.
4974 (adjust_after_replace_noundo): Remove; unused.
4975 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4976 (signal_before_change): Remove decls.
4977
4978 * indent.c (val_compute_motion, val_vmotion): Now static.
4979
4980 * image.c: Make symbols static if they're not exported.
4981 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4982 if USE_GTK.
4983 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4984 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4985
4986 * fringe.c (standard_bitmaps): Now static.
4987 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4988
4989 * frame.c: Make symbols static if they're not exported.
4990 (x_report_frame_params, make_terminal_frame): Now static.
4991 (get_frame_param): Now static, unless HAVE_NS.
4992 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4993 (x_get_resource_string): Remove; not used.
4994 * frame.h (make_terminal_frame, x_report_frame_params):
4995 (x_get_resource_string); Remove decls.
4996 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4997 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4998
4999 * font.c, fontset.c: Make symbols static if they're not exported.
5000 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5001 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5002 * font.c (font_close_object): Now static.
5003 * font.h (font_close_object): Remove.
5004 * fontset.c (FONTSET_OBJLIST): Remove.
5005 (free_realized_fontset) #if-0 the body, which does nothing.
5006 (face_suitable_for_char_p): #if-0, as it's never called.
5007 * fontset.h (face_suitable_for_char_p): Remove decl.
5008 * xfaces.c (face_at_string_position):
5009 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5010 since 0 is always ASCII.
5011
5012 * fns.c (weak_hash_tables): Now static.
5013
5014 * fileio.c: Make symbols static if they're not exported.
5015 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5016 (Vwrite_region_annotation_buffers): Now static.
5017
5018 * eval.c: Make symbols static if they're not exported.
5019 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5020 * lisp.h (backtrace_list): Remove decl.
5021
5022 * emacs.c: Make symbols static if they're not exported.
5023 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5024 (fatal_error_code, fatal_error_signal_hook, standard_args):
5025 Now static.
5026 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5027 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5028 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5029 * lisp.h (fatal_error_signal_hook): Remove decl.
5030 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5031
5032 * editfns.c: Move a (normally-unused) function to its only use.
5033 * editfns.c, lisp.h (get_operating_system_release): Remove.
5034 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5035 worth the hassle of breaking this out.
5036
5037 * xterm.c: Make symbols static if they're not exported.
5038 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5039 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5040 (x_destroy_window, x_delete_display):
5041 Now static.
5042 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5043 (x_mouse_leave): Remove; unused.
5044 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5045 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5046 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5047 Remove decls.
5048 (x_mouse_leave): Declare only if WINDOWSNT.
5049 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5050 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5051 USE_X_TOOLKIT.
5052
5053 * ftxfont.c: Make symbols static if they're not exported.
5054 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5055 HAVE_FREETYPE.
5056 * font.h (ftxfont_driver): Likewise.
5057
5058 * xfns.c: Make symbols static if they're not exported.
5059 (x_last_font_name, x_display_info_for_name):
5060 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5061 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5062 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5063 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5064 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5065 (last_show_tip_args): Now static.
5066 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5067 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5068 (x_screen_planes): Remove; unused.
5069 * dispextern.h (x_screen_planes): Remove decl.
5070
5071 * dispnew.c: Make symbols static if they're not exported.
5072 * dispextern.h (redraw_garbaged_frames, scrolling):
5073 (increment_row_positions): Remove.
5074 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5075 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5076 Now static.
5077 (redraw_garbaged_frames): Remove; unused.
5078
5079 * xfaces.c: Make symbols static if they're not exported.
5080 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5081 Remove decls.
5082 * xterm.h (defined_color): Remove decls.
5083 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5084 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5085 (menu_face_changed_default, defined_color, free_realized_face):
5086 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5087 (ascii_face_of_lisp_face): Remove; unused.
5088
5089 * xdisp.c: Make symbols static if they're not exported.
5090 * dispextern.h (scratch_glyph_row, window_box_edges):
5091 (glyph_to_pixel_coords, set_cursor_from_row):
5092 (get_next_display_element, set_iterator_to_next):
5093 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5094 (show_mouse_face): Remove decls
5095 * frame.h (message_buf_print): Likewise.
5096 * lisp.h (pop_message, set_message, check_point_in_composition):
5097 Likewise.
5098 * xterm.h (set_vertical_scroll_bar): Likewise.
5099 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5100 (message_buf_print, scratch_glyph_row, displayed_buffer):
5101 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5102 (get_next_display_element, show_mouse_face, window_box_edges):
5103 (frame_to_window_pixel_xy, check_point_in_composition):
5104 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5105 (glyph_to_pixel_coords): Remove; unused.
5106
5107 * dired.c (file_name_completion): Now static.
5108
5109 * dbusbind.c (xd_in_read_queued_messages): Now static.
5110
5111 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5112 * data.c (circular_list_error): Remove.
5113
5114 * commands.h (last_point_position, last_point_position_buffer):
5115 (last_point_position_window): Remove decls.
5116 * keyboard.c: Make these variables static.
5117
5118 * coding.h (coding, code_convert_region, encode_coding_gap):
5119 Remove decls.
5120 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5121 (iso_code_class, detect_coding, code_convert_region): Now static.
5122 (encode_coding_gap): Remove; unused.
5123
5124 * chartab.c (chartab_chars, chartab_bits): Now static.
5125
5126 * charset.h (charset_iso_8859_1): Remove decl.
5127 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5128 Now static.
5129
5130 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5131 * ccl.c (Vccl_program_table): Now static.
5132 (check_ccl_update): Remove; unused.
5133
5134 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5135 * category.h: ... from here.
5136 * category.c (check_category_table, set_category_set): Now static.
5137
5138 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5139 * lisp.h: Remove these decls.
5140
5141 * buffer.c (buffer_count): Remove unused var.
5142
5143 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5144 so that it's not optimized away.
5145 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5146 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5147 exported only to the debugger.
5148
5149 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5150 * atimer.h (run_all_atimers): Remove; not exported.
5151
5152 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5153 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5154 was inaccessible from Lisp.
5155 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5156 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5157
5158 alloc.c: Import and export fewer symbols, and remove unused items.
5159 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5160 is defined.
5161 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5162 it's not optimized away by whole-program optimization.
5163 (message_enable_multibyte, free_misc): Remove.
5164 (catchlist, handlerlist, mark_backtrace):
5165 Declare only if BYTE_MARK_STACK.
5166 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5167 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5168 (message_enable_multibyte): Remove decl.
5169 (free_misc, interval_free_list, float_block, float_block_index):
5170 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5171 (cons_free_list, last_marked_index):
5172 Now static.
5173 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5174 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5175 (mark_backtrace): Define only if BYTE_MARK_STACK.
5176 * xdisp.c (message_enable_multibyte): Now static.
5177
5178 Declare Lisp_Object Q* variables to be 'static' if not exported.
5179 This makes it easier for human readers (and static analyzers)
5180 to see whether these variables are used from other modules.
5181 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5182 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5183 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5184 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5185 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5186 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5187 * xmenu.c, xselect.c:
5188 Declare Q* vars static if they are not used in other modules.
5189 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5190 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5191 Remove decls of unexported vars.
5192 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5193
5194 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5195
5196 Make Emacs functions such as Fatom 'static' by default.
5197 This makes it easier for human readers (and static analyzers)
5198 to see whether these functions can be called from other modules.
5199 DEFUN now defines a static function. To make the function external
5200 so that it can be used in other C modules, use the new macro DEFUE.
5201 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5202 (Finit_image_library):
5203 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5204 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5205 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5206 Remove decls, since these functions are now static.
5207 (Funintern, Fget_internal_run_time): New decls, since these functions
5208 were already external.
5209
5210 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5211 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5212 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5213 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5214 * keyboard.c, keymap.c, lread.c:
5215 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5216 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5217 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5218 Mark functions with DEFUE instead of DEFUN,
5219 if they are used in other modules.
5220 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5221 decls for now-static functions.
5222 * buffer.h (Fdelete_overlay): Remove decl.
5223 * callproc.c (Fgetenv_internal): Mark as internal.
5224 * composite.c (Fremove_list_of_text_properties): Remove decl.
5225 (Fcomposition_get_gstring): New forward static decl.
5226 * composite.h (Fcomposite_get_gstring): Remove decl.
5227 * dired.c (Ffile_attributes): New forward static decl.
5228 * doc.c (Fdocumntation_property): New forward static decl.
5229 * eval.c (Ffetch_bytecode): New forward static decl.
5230 (Funintern): Remove extern decl; now in .h file where it belongs.
5231 * fileio.c (Fmake_symbolic_link): New forward static decl.
5232 * image.c (Finit_image_library): New forward static decl.
5233 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5234 * intervals.h (Fprevious_property_change):
5235 (Fremove_list_of_text_properties): Remove decls.
5236 * keyboard.c (Fthis_command_keys): Remove decl.
5237 (Fcommand_execute): New forward static decl.
5238 * keymap.c (Flookup_key): New forward static decl.
5239 (Fcopy_keymap): Now static.
5240 * keymap.h (Flookup_key): Remove decl.
5241 * process.c (Fget_process): New forward static decl.
5242 (Fprocess_datagram_address): Mark as internal.
5243 * syntax.c (Fsyntax_table_p): New forward static decl.
5244 (skip_chars): Remove duplicate decl.
5245 * textprop.c (Fprevious_property_change): New forward static decl.
5246 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5247 Now internal.
5248 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5249 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5250
5251 * editfns.c (Fformat): Remove unreachable code.
5252
5253 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5254
5255 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5256 change. (Bug#8496)
5257
5258 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5261 when at ZV. (Bug#8487)
5262
5263 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5264
5265 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5266 (Bug#8437)
5267 * keyboard.c (parse_tool_bar_item): Likewise.
5268 * sound.c (sound_cleanup, alsa_close): Likewise.
5269 * termcap.c (tgetent): Likewise.
5270 * xfns.c (x_default_font_parameter): Likewise.
5271 * xsettings.c (read_and_apply_settings): Likewise.
5272
5273 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5274 (overrun_check_free): Protoize.
5275
5276 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5279 since callers should never pass a negative size.
5280 Change the signature to match that of plain 'read' and 'write'; see
5281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5282 * lisp.h: Update prototypes of emacs_write and emacs_read.
5283
5284 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5285
5286 * xdisp.c (redisplay_window): Don't try to determine the character
5287 position of the scroll margin if the window start point w->startp
5288 is outside the buffer's accessible region. (Bug#8468)
5289
5290 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5291
5292 Fix write-region and its subroutines for buffers > 2GB.
5293 * fileio.c (a_write, e_write): Modify declaration of arguments and
5294 local variables to support buffers larger than 2GB.
5295 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5296
5297 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5298 argument, local variables, and return value.
5299
5300 * lisp.h: Update prototypes of emacs_write and emacs_read.
5301
5302 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5303
5304 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5305
5306 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5307
5308 Fix more problems found by GCC 4.6.0's static checks.
5309
5310 * xdisp.c (vmessage): Use a better test for character truncation.
5311
5312 * charset.c (load_charset_map): <, not <=, for optimization,
5313 and to avoid potential problems with integer overflow.
5314 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5315 * casetab.c (set_identity, shuffle): Likewise.
5316 * editfns.c (Fformat): Likewise.
5317 * syntax.c (skip_chars): Likewise.
5318
5319 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5320 This also lets GCC 4.6.0 generate slightly better loop code.
5321
5322 * callint.c (Fcall_interactively): <, not <=, for optimization.
5323 (Fcall_interactively): Count the number of arguments produced,
5324 not the number of arguments given. This is simpler and lets GCC
5325 4.6.0 generate slightly better code.
5326
5327 * ftfont.c: Distingish more carefully between FcChar8 and char.
5328 The previous code passed unsigned char * to a functions like
5329 strlen and xstrcasecmp that expect char *, which does not
5330 conform to the C standard.
5331 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5332 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5333 char * when the C standard requires it.
5334
5335 * keyboard.c (read_char): Remove unused var.
5336
5337 * eval.c: Port to Windows vsnprintf (Bug#8435).
5338 Include <limits.h>.
5339 (SIZE_MAX): Define if the headers do not.
5340 (verror): Do not give up if vsnprintf returns a negative count.
5341 Instead, grow the buffer. This ports to Windows vsnprintf, which
5342 does not conform to C99. Problem reported by Eli Zaretskii.
5343 Also, simplify the allocation scheme, by avoiding the need for
5344 calling realloc, and removing the ALLOCATED variable.
5345
5346 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5347
5348 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5349 But keep the doprint source code for now, as we might revamp it
5350 and use it again (Bug#8435).
5351 * lisp.h (doprnt): Remove.
5352 * Makefile.in (base_obj): Remove doprnt.o.
5353 * deps.mk (doprnt.o): Remove.
5354
5355 error: Print 32- and 64-bit integers portably (Bug#8435).
5356 Without this change, on typical 64-bit hosts error ("...%d...", N)
5357 was used to print both 32- and 64-bit integers N, which relied on
5358 undefined behavior.
5359 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5360 New macro.
5361 * lisp.h (error, verror): Mark as printf-like functions.
5362 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5363 Report overflow in size calculations when allocating printf buffer.
5364 Do not truncate output string at its first null byte.
5365 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5366 Truncate the output at a character boundary, since vsnprintf does not
5367 do that.
5368 * charset.c (check_iso_charset_parameter): Convert internal
5369 character to string before calling 'error', since %c now has the
5370 printf meaning.
5371 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5372 overflow when computing char to be passed to 'error'. Do not
5373 pass Lisp_Object to 'error'; pass the integer instead.
5374 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5375 formatted with plain %d.
5376
5377 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5378
5379 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5380
5381 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5382
5383 * xterm.c (x_catch_errors): Remove duplicate declaration.
5384
5385 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5386
5387 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5388
5389 2011-04-10 Jim Meyering <meyering@redhat.com>
5390
5391 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5392 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5393 return ssize_t not "int", and use size_t as the buffer length.
5394 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5395 * gnutls.h: Update declarations.
5396 * process.c (read_process_output): Use ssize_t, to match.
5397 (send_process): Likewise.
5398
5399 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5400
5401 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5402
5403 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5404
5405 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5406 Use unsigned char, to match FcChar8 type definition.
5407
5408 * xterm.c (handle_one_xevent):
5409 * xmenu.c (create_and_show_popup_menu):
5410 * xselect.c (x_decline_selection_request)
5411 (x_reply_selection_request): Avoid type-punned deref of X events.
5412
5413 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5414
5415 Fix some uses of `int' instead of EMACS_INT.
5416 * search.c (string_match_1, fast_string_match)
5417 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5418 (scan_buffer, find_next_newline_no_quit)
5419 (find_before_next_newline, search_command, Freplace_match)
5420 (Fmatch_data): Make some `int' variables be EMACS_INT.
5421
5422 * xdisp.c (display_count_lines): 3rd argument and return value now
5423 EMACS_INT. All callers changed.
5424 (pint2hrstr): Last argument is now EMACS_INT.
5425
5426 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5427 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5428 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5429 (decode_coding_utf_16, decode_coding_emacs_mule)
5430 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5431 (decode_coding_ccl, decode_coding_charset)
5432 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5433 (decode_coding_iso_2022, decode_coding_emacs_mule)
5434 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5435 <char_offset, last_offset>: Declare EMACS_INT.
5436 (encode_coding_utf_8, encode_coding_utf_16)
5437 (encode_coding_emacs_mule, encode_invocation_designation)
5438 (encode_designation_at_bol, encode_coding_iso_2022)
5439 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5440 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5441 Declare EMACS_INT.
5442 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5443 (encode_invocation_designation): Last argument P_NCHARS is now
5444 EMACS_INT.
5445 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5446 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5447
5448 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5449 All users changed.
5450
5451 * ccl.c (Fccl_execute_on_string): Declare some variables
5452 EMACS_INT.
5453
5454 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5455
5456 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5457
5458 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5459
5460 * process.c (Fformat_network_address): Doc fix.
5461
5462 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5463
5464 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5465
5466 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5467
5468 * keyboard.c (read_char): Call Lisp function help-form-show,
5469 instead of using internal_with_output_to_temp_buffer.
5470 (Qhelp_form_show): New var.
5471 (syms_of_keyboard): Use DEFSYM macro.
5472
5473 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5474
5475 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5476
5477 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5478
5479 * process.c (Flist_processes): Remove to Lisp.
5480 (list_processes_1): Delete.
5481
5482 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5483
5484 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5485
5486 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5487
5488 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 Fix more problems found by GCC 4.6.0's static checks.
5491
5492 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5493
5494 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5495
5496 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5497
5498 * xdisp.c (vmessage): Mark as a printf-like function.
5499
5500 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5501
5502 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5503
5504 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5505 printf-like functions.
5506 (tiff_load): Add casts to remove these marks before passing them
5507 to system-supplied API.
5508
5509 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5510
5511 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5512 This avoids several warnings with gcc -Wstrict-overflow.
5513 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5514 directly, rather than having caller test rule sign. This avoids
5515 some unnecessary tests.
5516 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5517 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5518 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5519
5520 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5521 (xfont_open): Avoid unnecessary tests.
5522
5523 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5524
5525 * composite.h, composite.c (composition_gstring_put_cache):
5526 Use EMACS_INT, not int, for length.
5527
5528 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5529 breaking out part of COMPOSITION_DECODE_RULE.
5530 (COMPOSITION_DECODE_RULE): Use it.
5531 * composite.c (get_composition_id): Remove unused local vars,
5532 by using the new macro.
5533
5534 * textprop.c (set_text_properties_1): Change while to do-while,
5535 since the condition is always true at first.
5536
5537 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5538 (interval_deletion_adjustment): Return unsigned value.
5539 All uses changed.
5540
5541 * process.c (list_processes_1, create_pty, read_process_output):
5542 (exec_sentinel): Remove vars that were set but not used.
5543 (create_pty): Remove unnecessary "volatile"s.
5544 (Fnetwork_interface_info): Avoid possibility of int overflow.
5545 (read_process_output): Do adaptive read buffering even if carryover.
5546 (read_process_output): Simplify nbytes computation if buffered.
5547
5548 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5549
5550 * syntax.c (scan_words): Remove var that was set but not used.
5551 (update_syntax_table): Use unsigned instead of int.
5552
5553 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5554 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5555 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5556
5557 * print.c (print_error_message): Avoid int overflow.
5558
5559 * font.c (font_list_entities): Redo for clarity,
5560 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5561
5562 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5563 (font_score): Avoid potential overflow in diff calculation.
5564
5565 * fns.c (substring_both): Remove var that is set but not used.
5566 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5567
5568 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5569
5570 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5571 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5572 can always succeed if overflow has undefined behavior.
5573
5574 * search.c (boyer_moore, wordify): Remove vars set but not used.
5575 (wordify): Omit three unnecessary tests.
5576
5577 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5578 All callers changed. This avoids the need for an unused var.
5579
5580 * casefiddle.c (casify_region): Remove var that is set but not used.
5581
5582 * dired.c (file_name_completion): Remove var that is set but not used.
5583
5584 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5585
5586 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5587 (Finsert_file_contents): Remove unnecessary code checking fd.
5588
5589 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5590 Check for integer overflow on size calculations.
5591
5592 * buffer.c (Fprevious_overlay_change): Remove var that is set
5593 but not used.
5594
5595 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5596 Remove vars that are set but not used.
5597 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5598 (timer_check_2): Mark vars as initialized.
5599
5600 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5601
5602 * image.c (lookup_image): Remove var that is set but not used.
5603 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5604
5605 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5606 that are set but not used.
5607
5608 * xfns.c (make_invisible_cursor): Don't return garbage
5609 if XCreateBitmapFromData fails (Bug#8410).
5610
5611 * xselect.c (x_get_local_selection, x_handle_property_notify):
5612 Remove vars that are set but not used.
5613
5614 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5615 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5616
5617 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5618 Remove var that is set but not used.
5619 (scroll_bar_windows_size): Now size_t, not int.
5620 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5621 Check for overflow.
5622
5623 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5624 (map_tty_color) [!defined MSDOS]: Likewise.
5625
5626 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5627
5628 * coding.c: Remove vars that are set but not used.
5629 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5630 All callers changed.
5631 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5632 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5633 (decode_coding_charset): Remove vars that are set but not used.
5634
5635 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5636 that is set but not used.
5637
5638 * print.c (print_object): Remove var that is set but not used.
5639
5640 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5641 The gnulib version avoids calling malloc in the usual case,
5642 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5643 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5644 * filelock.c (current_lock_owner): Likewise.
5645 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5646 * sysdep.c: Include allocator.h, careadlinkat.h.
5647 (emacs_no_realloc_allocator): New static constant.
5648 (emacs_readlink): New function.
5649 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5650 ../lib/careadlinkat.h.
5651
5652 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5653
5654 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5655 first non-nil return value).
5656
5657 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5658
5659 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5660 if not defined (Bug#8403).
5661
5662 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * xdisp.c (display_count_lines): Remove parameter `start',
5665 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5666 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5667 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5668 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5669 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5670 and thereabouts. All callers changed.
5671 (get_per_char_metric): Remove parameter `f', unused since
5672 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5673
5674 2011-04-02 Jim Meyering <meyering@redhat.com>
5675
5676 do not dereference NULL upon failed strdup
5677 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5678 (ns_get_family): Likewise.
5679
5680 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5683
5684 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5685
5686 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5687 later (Bug#8403).
5688
5689 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5690
5691 Add lexical binding.
5692
5693 * window.c (Ftemp_output_buffer_show): New fun.
5694 (Fsave_window_excursion):
5695 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5696
5697 * lread.c (lisp_file_lexically_bound_p): New function.
5698 (Fload): Bind Qlexical_binding.
5699 (readevalloop): Remove `evalfun' arg.
5700 Bind Qinternal_interpreter_environment.
5701 (Feval_buffer): Bind Qlexical_binding.
5702 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5703 Mark as dynamic.
5704 (syms_of_lread): Declare `lexical-binding'.
5705
5706 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5707
5708 * keyboard.c (eval_dyn): New fun.
5709 (menu_item_eval_property): Use it.
5710
5711 * image.c (parse_image_spec): Use Ffunctionp.
5712
5713 * fns.c (concat, mapcar1): Accept byte-code-functions.
5714
5715 * eval.c (Fsetq): Handle lexical vars.
5716 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5717 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5718 (FletX, Flet): Obey lexical binding.
5719 (Fcommandp): Handle closures.
5720 (Feval): New `lexical' arg.
5721 (eval_sub): New function extracted from Feval. Use it almost
5722 everywhere where Feval was used. Look up vars in lexical env.
5723 Handle closures.
5724 (Ffunctionp): Move from subr.el.
5725 (Ffuncall): Handle closures.
5726 (apply_lambda): Remove `eval_flags'.
5727 (funcall_lambda): Handle closures and new byte-code-functions.
5728 (Fspecial_variable_p): New function.
5729 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5730 but without exporting it to Lisp.
5731
5732 * doc.c (Fdocumentation, store_function_docstring):
5733 * data.c (Finteractive_form): Handle closures.
5734
5735 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5736 interactive spec.
5737
5738 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5739 New byte-codes.
5740 (exec_byte_code): New function extracted from Fbyte_code to handle new
5741 calling convention for byte-code-functions. Add new byte-codes.
5742
5743 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5744
5745 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5746
5747 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5748
5749 * xdisp.c (redisplay_internal): Fix prototype.
5750
5751 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5752
5753 * xdisp.c (SCROLL_LIMIT): New macro.
5754 (try_scrolling): Use it when setting scroll_limit.
5755 Limit scrolling to 100 screen lines.
5756 (redisplay_window): Even when falling back on "recentering",
5757 position point in the window according to scroll-conservatively,
5758 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5759
5760 (try_scrolling): When point is above the window, allow searching
5761 as far as scroll_max, or one screenful, to compute vertical
5762 distance from PT to the scroll margin position. This prevents
5763 try_scrolling from unnecessarily failing when
5764 scroll-conservatively is set to a value slightly larger than the
5765 window height. Clean up the case of PT below the margin at bottom
5766 of window: scroll_max can no longer be INT_MAX. When aggressive
5767 scrolling is in use, don't let point enter the opposite scroll
5768 margin as result of the scroll.
5769 (syms_of_xdisp) <scroll-conservatively>: Document the
5770 threshold of 100 lines for never-recentering scrolling.
5771
5772 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5773
5774 * dispextern.h (move_it_by_lines):
5775 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5776 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5777 (message_log_check_duplicate): Remove parameters `prev_bol' and
5778 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5779 (redisplay_internal): Remove parameter `preserve_echo_area',
5780 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5781
5782 * indent.c (Fvertical_motion):
5783 * window.c (window_scroll_pixel_based, Frecenter):
5784 Don't pass `need_y_p' to `move_it_by_lines'.
5785
5786 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5787
5788 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5789 steal a few bits to be more compact.
5790 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5791 Remove unneeded casts.
5792
5793 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5794
5795 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5796
5797 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5798 binding" message (bug#7967).
5799
5800 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5801
5802 Fix more problems found by GCC 4.6.0's static checks.
5803
5804 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5805 Remove unused local var.
5806
5807 * editfns.c (Fmessage_box): Remove unused local var.
5808
5809 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5810 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5811 Omit unused local vars.
5812 * window.c (shrink_windows): Omit unused local var.
5813 * menu.c (digest_single_submenu): Omit unused local var.
5814 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5815 Omit unused local var.
5816
5817 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5818 Don't assume string length fits in int.
5819 (keyremap_step, read_key_sequence): Use size_t for sizes.
5820 (read_key_sequence): Don't check last_real_key_start redundantly.
5821
5822 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5823 instead of alloca (Bug#8344).
5824
5825 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5826 (Fbacktrace_frame): Don't assume nframes fits in int.
5827
5828 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5829
5830 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5831 concerns.
5832
5833 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5834
5835 * cm.c (calccost): Turn while-do into do-while, for clarity.
5836
5837 * keyboard.c (syms_of_keyboard): Use the same style as later
5838 in this function when indexing through an array. This also
5839 works around GCC bug 48267.
5840
5841 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5842
5843 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5844
5845 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5846 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5847
5848 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5849 This avoids undefined behavior on integer overflow, and is a bit
5850 more convenient anyway since it is compared to a size_t variable.
5851
5852 Variadic C functions now count arguments with size_t, not int.
5853 This avoids an unnecessary limitation on 64-bit machines, which
5854 caused (substring ...) to crash on large vectors (Bug#8344).
5855 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5856 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5857 All variadic functions and their callers changed accordingly.
5858 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5859 * data.c (arith_driver, float_arith_driver): Likewise.
5860 * editfns.c (general_insert_function): Likewise.
5861 * eval.c (struct backtrace.nargs, interactive_p)
5862 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5863 (funcall_lambda, mark_backtrace): Likewise.
5864 * fns.c (concat): Likewise.
5865 * frame.c (x_set_frame_parameters): Likewise.
5866 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5867 0 if not found, not -1. All callers changed.
5868
5869 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5870 (stack_copy_size): Now size_t, not int.
5871 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5872
5873 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5876 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5877 All callers changed.
5878
5879 * lisp.h (multibyte_char_to_unibyte):
5880 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5881 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5882 * character.h (CHAR_TO_BYTE8):
5883 * cmds.c (internal_self_insert):
5884 * editfns.c (general_insert_function):
5885 * keymap.c (push_key_description):
5886 * search.c (Freplace_match):
5887 * xdisp.c (message_dolog, set_message_1): All callers changed.
5888
5889 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5890
5891 * keyboard.c (safe_run_hook_funcall): New function.
5892 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5893 don't set the hook to nil, but remove the offending function instead.
5894 (Qcommand_hook_internal): Remove, unused.
5895 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5896 Vcommand_hook_internal.
5897
5898 * eval.c (enum run_hooks_condition): Remove.
5899 (funcall_nil, funcall_not): New functions.
5900 (run_hook_with_args): Call each function through a `funcall' argument.
5901 Remove `cond' argument, now redundant.
5902 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5903 (Frun_hook_with_args_until_failure): Adjust accordingly.
5904 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5905
5906 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5907
5908 * dispextern.h (string_buffer_position): Remove declaration.
5909
5910 * print.c (strout): Remove parameter `multibyte', unused since
5911 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5912
5913 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5914 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5915 All callers changed.
5916
5917 * w32.c (_wsa_errlist): Use braces for struct initializers.
5918
5919 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5920 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5921 All callers changed.
5922 (string_buffer_position): Likewise. Also, make static (it's never
5923 used outside xdisp.c).
5924 (cursor_row_p): Remove parameter `w', unused since
5925 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5926 (decode_mode_spec): Remove parameter `precision', introduced during
5927 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5928 All callers changed.
5929
5930 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5931
5932 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5933
5934 2011-03-27 Anders Lindgren <andlind@gmail.com>
5935
5936 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5937 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5938 (ns_update_auto_hide_menu_bar): New functions.
5939 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5940 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5941 ns_constrain_all_frames.
5942 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5943 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5944
5945 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5946
5947 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5948
5949 2011-03-27 Glenn Morris <rgm@gnu.org>
5950
5951 * syssignal.h: Replace RETSIGTYPE with void.
5952 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5953 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5954 Replace SIGTYPE with void everywhere.
5955 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5956 * s/template.h (SIGTYPE): Remove commented out definition.
5957
5958 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5961 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5962
5963 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5964
5965 * w32.c (read_unc_volume): Use parameter `henum', instead of
5966 global variable `wget_enum_handle'.
5967
5968 * keymap.c (describe_vector): Remove parameters `indices' and
5969 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5970 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5971
5972 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5973
5974 * keyboard.c (timer_check): Remove parameter `do_it_now',
5975 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5976 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5977 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5978
5979 * keyboard.c (read_char):
5980 * w32menu.c (w32_menu_display_help):
5981 * xmenu.c (show_help_event, menu_help_callback):
5982 Adjust calls to `show_help_echo'.
5983
5984 * gtkutil.c (xg_maybe_add_timer):
5985 * keyboard.c (readable_events):
5986 * process.c (wait_reading_process_output):
5987 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5988
5989 * insdel.c (adjust_markers_gap_motion):
5990 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5991 (gap_left, gap_right): Don't call it.
5992
5993 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5994
5995 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5996 incurred during fontification.
5997
5998 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5999
6000 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6001 (DEFVAR_PER_BUFFER): Don't pass it.
6002
6003 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6004 (scrolling_window): Don't pass it.
6005
6006 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6007
6008 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6009
6010 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6011 and `suffix'.
6012 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6013 of variables specific to SELinux and computation of `encoded_absname'.
6014
6015 * image.c (XPutPixel): Remove unused variable `height'.
6016
6017 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6018
6019 * unexw32.c (get_section_info): Remove unused variable `section'.
6020
6021 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6022 (system_process_attributes): Remove unused variable `sess'.
6023 (sys_read): Remove unused variable `err'.
6024
6025 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6026 (w32_wnd_proc): Remove unused variable `isdead'.
6027 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6028 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6029 (x_create_tip_frame): Remove unused variable `tem'.
6030
6031 * w32inevt.c (w32_console_read_socket):
6032 Remove unused variable `no_events'.
6033
6034 * w32term.c (x_draw_composite_glyph_string_foreground):
6035 Remove unused variable `width'.
6036
6037 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6038
6039 * w32term.c (x_set_glyph_string_clipping):
6040 Don't pass uninitialized region to CombineRgn.
6041
6042 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6043
6044 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6045 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6046 (Fx_close_connection): Remove unused variable `i'.
6047
6048 * w32font.c (w32font_draw): Return number of glyphs.
6049 (w32font_open_internal): Remove unused variable `i'.
6050 (w32font_driver): Add missing initializer.
6051
6052 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6053 (fill_in_menu): Remove unused variable `items_added'.
6054
6055 * w32term.c (last_mouse_press_frame): Remove static global variable.
6056 (w32_clip_to_row): Remove unused variable `f'.
6057 (x_delete_terminal): Remove unused variable `i'.
6058
6059 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6060 (NOTHING): Remove unused static global variable.
6061 (uniscribe_check_otf): Remove unused variable `table'.
6062 (uniscribe_font_driver): Add missing initializers.
6063
6064 2011-03-23 Julien Danjou <julien@danjou.info>
6065
6066 * term.c (Fsuspend_tty, Fresume_tty):
6067 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6068 * window.c (temp_output_buffer_show):
6069 * insdel.c (signal_before_change):
6070 * frame.c (Fhandle_switch_frame):
6071 * fileio.c (Fdo_auto_save):
6072 * emacs.c (Fkill_emacs):
6073 * editfns.c (save_excursion_restore):
6074 * cmds.c (internal_self_insert):
6075 * callint.c (Fcall_interactively):
6076 * buffer.c (Fkill_all_local_variables):
6077 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6078 Use Frun_hooks.
6079 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6080 unconditionnaly since it does the check itself.
6081
6082 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 Fix more problems found by GCC 4.5.2's static checks.
6085
6086 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6087 the first time through the loop, since we know p0 < p1 then.
6088 This also avoids a gcc -Wstrict-overflow warning.
6089
6090 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6091 leading to a memory leak, possible in functions like
6092 load_charset_map_from_file that can allocate an unbounded number
6093 of objects (Bug#8318).
6094
6095 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6096 that could (at least in theory) be that large.
6097
6098 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6099 This is less likely to overflow, and avoids undefined behavior if
6100 overflow does occur. All callers changed. Use strtoul to scan
6101 for the unsigned long integer.
6102 (pint2hrstr): Simplify and tune code slightly.
6103 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6104
6105 * scroll.c (do_scrolling): Work around GCC bug 48228.
6106 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6107
6108 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6109 This also avoids a warning with gcc -Wstrict-overflow.
6110 (validate_x_resource_name): Simplify count usage.
6111 This also avoids a warning with gcc -Wstrict-overflow.
6112
6113 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6114 fail (Bug#8306).
6115
6116 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6117
6118 * process.c (Fmake_network_process): Use socklen_t, not int,
6119 where POSIX says socklen_t is required in portable programs.
6120 This fixes a porting bug on hosts like 64-bit HP-UX, where
6121 socklen_t is wider than int (Bug#8277).
6122 (Fmake_network_process, server_accept_connection):
6123 (wait_reading_process_output, read_process_output):
6124 Likewise.
6125
6126 * process.c: Rename or move locals to avoid shadowing.
6127 (list_processes_1, Fmake_network_process):
6128 (read_process_output_error_handler, exec_sentinel_error_handler):
6129 Rename or move locals.
6130 (Fmake_network_process): Define label "retry_connect" only if needed.
6131 (Fnetwork_interface_info): Fix pointer signedness.
6132 (process_send_signal): Add cast to avoid pointer signedness problem.
6133 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6134 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6135
6136 Make tparam.h and terminfo.c consistent.
6137 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6138 Include tparam.h instead, since it declares them.
6139 * cm.h (PC): Remove extern decl; tparam.h now does this.
6140 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6141 * terminfo.c: Include tparam.h, to check interfaces.
6142 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6143 (tparam): Adjust signature to match interface in tparam.h;
6144 this removes some undefined behavior. Check that outstring and len
6145 are zero, which they always are with Emacs.
6146 * tparam.h (PC, BC, UP): New extern decls.
6147
6148 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6149 (xftfont_open): Rename locals to avoid shadowing.
6150
6151 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6152 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6153 (OTF_TAG_SYM): Omit macro if not needed.
6154 (ftfont_list): Remove unused local.
6155 (get_adstyle_property, ftfont_pattern_entity):
6156 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6157 Rename locals to avoid shadowing.
6158
6159 * xfont.c (xfont_list_family): Mark var as initialized.
6160
6161 * xml.c (make_dom): Now static.
6162
6163 * composite.c (composition_compute_stop_pos): Rename local to
6164 avoid shadowing.
6165 (composition_reseat_it): Remove unused locals.
6166 (find_automatic_composition, composition_adjust_point): Likewise.
6167 (composition_update_it): Mark var as initialized.
6168 (find_automatic_composition): Mark vars as initialized,
6169 with a FIXME (Bug#8290).
6170
6171 character.h: Rename locals to avoid shadowing.
6172 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6173 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6174 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6175 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6176 to avoid shadowing.
6177
6178 * textprop.c (property_change_between_p): Remove; unused.
6179
6180 * intervals.c (interval_start_pos): Now static.
6181
6182 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6183
6184 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6185 Rename locals to avoid shadowing.
6186
6187 * sound.c (wav_play, au_play, Fplay_sound_internal):
6188 Fix pointer signedness.
6189 (alsa_choose_format): Remove unused local var.
6190 (wav_play): Initialize a variable to 0, to prevent undefined
6191 behavior (Bug#8278).
6192
6193 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6194
6195 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6196
6197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6198 clobbering (Bug#8298).
6199 * sysdep.c (sys_subshell): Likewise.
6200 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6201
6202 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6203 This should get cleaned up, so that child_setup has the
6204 same signature on all platforms.
6205
6206 * callproc.c (call_process_cleanup): Now static.
6207 (relocate_fd): Rename locals to avoid shadowing.
6208
6209 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6210
6211 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6212 not to be necessary, and produces flickering.
6213
6214 2011-03-20 Glenn Morris <rgm@gnu.org>
6215
6216 * config.in: Remove file.
6217
6218 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6221 are now in src/globals.h.
6222 (syms_of_minibuf): Remove spurious & from previous change.
6223
6224 2011-03-20 Leo <sdl.web@gmail.com>
6225
6226 * minibuf.c (completing-read-function): New variable.
6227 (completing-read-default): Rename from completing-read.
6228 (completing-read): Call completing-read-function.
6229
6230 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * xfaces.c (Fx_load_color_file):
6233 Read color file from absolute filename (bug#8250).
6234
6235 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * makefile.w32-in: Update dependencies.
6238
6239 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6240
6241 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6242
6243 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6244
6245 Fix more problems found by GCC 4.5.2's static checks.
6246
6247 * process.c (make_serial_process_unwind, send_process_trap):
6248 (sigchld_handler): Now static.
6249
6250 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6251 That way, the code declares only the vars that it needs.
6252 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6253 * s/cygwin.h (PTY_ITERATION): Likewise.
6254 * s/darwin.h (PTY_ITERATION): Likewise.
6255 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6256
6257 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6258 * process.c (allocate_pty): Don't declare stb unless it's needed.
6259
6260 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6261 (CONSTANTLIM): Remove; unused.
6262 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6263 Define only if needed.
6264
6265 * unexelf.c (unexec): Name an expression,
6266 to avoid gcc -Wbad-function-cast warning.
6267 Use a different way to cause a compilation error if anyone uses
6268 n rather than nn, a way that does not involve shadowing.
6269 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6270
6271 * deps.mk (unexalpha.o): Remove; unused.
6272
6273 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6274 * unexec.h: New file.
6275 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6276 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6277 Depend on unexec.h.
6278 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6279 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6280 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6281 Change as necessary to match prototype in unexec.h.
6282
6283 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6284 shadowing.
6285 (back_comment, skip_chars): Mark vars as initialized.
6286
6287 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6288 Rename locals to avoid shadowing.
6289
6290 * lread.c (read1): Rewrite so as not to use empty "else".
6291 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6292
6293 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6294
6295 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6296 warning when compiling print.c.
6297
6298 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6299 instead of using an uninitialized var.
6300 (font_sort_entities): Mark var as initialized.
6301
6302 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6303
6304 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6305 pointers to constants.
6306 (font_parse_fcname): Remove unused vars.
6307 (font_delete_unmatched): Now static.
6308 (font_get_spec): Remove; unused.
6309 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6310 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6311 Rename or move locals to avoid shadowing.
6312
6313 * fns.c (require_nesting_list, require_unwind): Now static.
6314 (Ffillarray): Rename locals to avoid shadowing.
6315
6316 * floatfns.c (domain_error2): Define only if needed.
6317 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6318
6319 * alloc.c (mark_backtrace): Move decl from here ...
6320 * lisp.h: ... to here, so that it can be checked.
6321
6322 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6323 (Fdefvar): Rewrite so as not to use empty "else".
6324 (lisp_indirect_variable): Name an expression,
6325 to avoid gcc -Wbad-function-cast warning.
6326 (Fdefvar): Rename locals to avoid shadowing.
6327
6328 * callint.c (quotify_arg, quotify_args): Now static.
6329 (Fcall_interactively): Rename locals to avoid shadowing.
6330 Use const pointer when appropriate.
6331
6332 * lisp.h (get_system_name, get_operating_system_release):
6333 Move decls here, to check interfaces.
6334 * process.c (get_operating_system_release): Move decl to lisp.h.
6335 * xrdb.c (get_system_name): Likewise.
6336 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6337 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6338 some of which prompt warnings from gcc -Wbad-function-cast.
6339 (Fformat_time_string, Fencode_time, Finsert_char):
6340 (Ftranslate_region_internal, Fformat):
6341 Rename or remove local vars to avoid shadowing.
6342 (Ftranslate_region_internal): Mark var as initialized.
6343
6344 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6345 avoid shadowing.
6346
6347 * lisp.h (eassert): Check that the argument compiles, even if
6348 ENABLE_CHECKING is not defined.
6349
6350 * data.c (Findirect_variable): Name an expression, to avoid
6351 gcc -Wbad-function-cast warning.
6352 (default_value, arithcompare, arith_driver, arith_error): Now static.
6353 (store_symval_forwarding): Rename local to avoid shadowing.
6354 (Fmake_variable_buffer_local, Fmake_local_variable):
6355 Mark variables as initialized.
6356 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6357
6358 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6359 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6360 Rename locals to avoid shadowing.
6361 (mark_stack): Move local variables into the #ifdef region where
6362 they're used.
6363 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6364 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6365 needed otherwise.
6366 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6367 (GC_STRING_CHARS): Remove; not used.
6368 (Fmemory_limit): Cast sbrk's returned value to char *.
6369
6370 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6371 avoids undefined behavior in theory.
6372
6373 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6374
6375 Use functions, not macros, for up- and down-casing (Bug#8254).
6376 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6377 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6378 to use the following functions instead of these macros.
6379 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6380 EMACS_INT, since callers assume the returned value fits in int.
6381 (upcase1): Likewise, for UPCASE_TABLE.
6382 (uppercasep, lowercasep, upcase): New static inline functions.
6383 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6384 the race-condition problem in the old DOWNCASE.
6385
6386 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6387 Rename locals to avoid shadowing.
6388 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6389 (regex_compile, re_search_2, re_match_2_internal):
6390 Remove unused local vars.
6391 (FREE_VAR): Rewrite so as not to use empty "else",
6392 which gcc can warn about.
6393 (regex_compile, re_match_2_internal): Mark locals as initialized.
6394 (RETALLOC_IF): Define only if needed.
6395 (WORDCHAR_P): Likewise. This one is never needed, but is used
6396 only in a comment talking about a compiler bug, so put inside
6397 the #if 0 of that comment.
6398 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6399 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6400 Remove; unused.
6401
6402 * search.c (boyer_moore): Rename locals to avoid shadowing.
6403 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6404 (PREV_CHAR_BOUNDARY): Likewise.
6405
6406 * search.c (simple_search): Remove unused var.
6407
6408 * dired.c (compile_pattern): Move decl from here ...
6409 * lisp.h: ... to here, so that it can be checked.
6410 (struct re_registers): New forward decl.
6411
6412 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6413
6414 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6415 All uses changed.
6416 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6417 Rename locals to avoid shadowing.
6418 (Fvertical_motion): Mark locals as initialized.
6419
6420 * casefiddle.c (casify_object, casify_region): Now static.
6421 (casify_region): Mark local as initialized.
6422
6423 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6424
6425 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6426 New macros, so that the caller can use some names other than
6427 gcpro1, gcpro2, etc.
6428 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6429 of the new macros.
6430 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6431 argument, for consistency with GCPRO2_VAR, etc: it is now the
6432 prefix of the variable, not the variable itself. All uses
6433 changed.
6434 * dired.c (directory_files_internal, file_name_completion):
6435 Rename locals to avoid shadowing.
6436
6437 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6438 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6439 dired.c's scmp function, had undefined behavior.
6440 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6441 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6442 * buffer.h: ... to here, because these macros use current_buffer,
6443 and the new implementation with inline functions needs to have
6444 current_buffer in scope now, rather than later when the macros
6445 are used.
6446 (downcase, upcase1): New static inline functions.
6447 (DOWNCASE, UPCASE1): Reimplement using these functions.
6448 This avoids undefined behavior in expressions like
6449 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6450 from race conditions in accessing the global variables
6451 case_temp1 and case_temp2.
6452 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6453 * lisp.h (case_temp1, case_temp2): Remove their decls.
6454 * character.h (ASCII_CHAR_P): Move from here ...
6455 * lisp.h: ... to here, so that the inline functions mentioned
6456 above can use them.
6457
6458 * dired.c (directory_files_internal_unwind): Now static.
6459
6460 * fileio.c (file_name_as_directory, directory_file_name):
6461 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6462 Now static.
6463 (file_name_as_directory): Use const pointers when appropriate.
6464 (Fexpand_file_name): Likewise. In particular, newdir might
6465 point at constant storage, so make it a const pointer.
6466 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6467 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6468 signedness issues.
6469 (Fset_file_times, Finsert_file_contents, auto_save_error):
6470 Rename locals to avoid shadowing.
6471
6472 * minibuf.c (choose_minibuf_frame_1): Now static.
6473 (Ftry_completion, Fall_completions): Rename or remove locals
6474 to avoid shadowing.
6475
6476 * marker.c (bytepos_to_charpos): Remove; unused.
6477
6478 * lisp.h (verify_bytepos, count_markers): New decls,
6479 so that gcc does not warn that these functions aren't declared.
6480
6481 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6482 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6483 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6484 (copy_text): Remove unused local var.
6485
6486 * filelock.c (within_one_second): Now static.
6487 (lock_file_1): Rename local to avoid shadowing.
6488
6489 * buffer.c (fix_overlays_before): Mark locals as initialized.
6490 (fix_start_end_in_overlays): Likewise. This function should be
6491 simplified by using pointers-to-pointers, but that's a different
6492 matter.
6493 (switch_to_buffer_1): Now static.
6494 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6495 (report_overlay_modification): Rename locals to avoid shadowing.
6496
6497 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6498 Fix pointer signedness issue.
6499 (sys_subshell): Mark local as volatile if checking for lint,
6500 to suppress a gcc -Wclobbered warning that does not seem to be right.
6501 (MAXPATHLEN): Define only if needed.
6502
6503 * process.c (serial_open, serial_configure): Move decls from here ...
6504 * systty.h: ... to here, so that they can be checked.
6505
6506 * fns.c (get_random, seed_random): Move extern decls from here ...
6507 * lisp.h: ... to here, so that they can be checked.
6508
6509 * sysdep.c (reset_io): Now static.
6510 (wait_for_termination_signal): Remove; unused.
6511
6512 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6513 (copy_keymap_item, append_key, push_text_char_description):
6514 Now static.
6515 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6516 (DENSE_TABLE_SIZE): Remove; unused.
6517 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6518 (describe_map_tree):
6519 Rename locals to avoid shadowing.
6520
6521 * keyboard.c: Declare functions static if they are not used elsewhere.
6522 (echo_char, echo_dash, cmd_error, top_level_2):
6523 (poll_for_input, handle_async_input): Now static.
6524 (read_char, kbd_buffer_get_event, make_lispy_position):
6525 (make_lispy_event, make_lispy_movement, apply_modifiers):
6526 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6527 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6528 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6529 (read_key_sequence, read_char): Mark locals as initialized.
6530 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6531
6532 * keyboard.h (make_ctrl_char): New decl.
6533 (mark_kboards): Move decl here ...
6534 * alloc.c (mark_kboards): ... from here.
6535
6536 * lisp.h (force_auto_save_soon): New decl.
6537
6538 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6539 (DEFINE_DUMMY_FUNCTION): New macro.
6540 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6541 Use it.
6542 (main): Add casts to avoid warnings
6543 if GCC considers string literals to be constants.
6544
6545 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6546
6547 * dbusbind.c: Pointer signedness fixes.
6548 (xd_signature, xd_append_arg, xd_initialize):
6549 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6550 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6551 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6552 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6553
6554 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6555 if GCC considers string literals to be constants.
6556 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6557
6558 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6559
6560 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6561 (print_preprocess, print_object): New macro to fix last change.
6562
6563 * print.c (print_preprocess): Don't forget font objects.
6564
6565 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6566
6567 * emacs.c (USAGE3): Doc fixes.
6568
6569 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6570
6571 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6572 structure.
6573
6574 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6575
6576 * lisp.h (VWindow_system, Qfile_name_history):
6577 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6578 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6579 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6580
6581 * w32select.c: Don't #include "keyboard.h".
6582 (run_protected): Add extern declaration for waiting_for_input.
6583
6584 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6585 * w32console.c (detect_input_pending, read_input_pending)
6586 (encode_terminal_code):
6587 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6588 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6589 (w32_system_caret_y, Qfile_name_history):
6590 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6591 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6592 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6593 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6594 * w32proc.c (Qlocal, report_file_error):
6595 * w32term.c (Vwindow_system, updating_frame):
6596 * w32uniscribe.c (initialized, uniscribe_font_driver):
6597 Remove unneeded extern declarations.
6598
6599 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6600
6601 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6602
6603 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6604
6605 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6606 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6607 These macros can no longer be used for assignment.
6608
6609 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6610 Assign struct members directly, instead of using BUF_BEGV etc.
6611 (record_buffer_markers, fetch_buffer_markers): New functions for
6612 recording and fetching special buffer markers.
6613 (set_buffer_internal_1, set_buffer_temp): Use them.
6614
6615 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6616
6617 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6618
6619 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6620 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6621
6622 * xdisp.c (hscroll_window_tree):
6623 (reconsider_clip_changes): Use PT instead of BUF_PT.
6624
6625 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6626
6627 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6628 $(EMACS_ROOT)/lib/intprops.h.
6629
6630 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 Fix more problems found by GCC 4.5.2's static checks.
6633
6634 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6635 to unsigned char * to avoid compiler diagnostic.
6636 (xg_free_frame_widgets): Make it clear that a local variable is
6637 needed only if USE_GTK_TOOLTIP.
6638 (gdk_window_get_screen): Make it clear that this macro is needed
6639 only if USE_GTK_TOOLTIP.
6640 (int_gtk_range_get_value): New function, which avoids a diagnostic
6641 from gcc -Wbad-function-cast.
6642 (xg_set_toolkit_scroll_bar_thumb): Use it.
6643 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6644 diagnostic from gcc -Wbad-function-cast.
6645 (get_utf8_string, xg_get_file_with_chooser):
6646 Rename locals to avoid shadowing.
6647 (create_dialog): Move locals to avoid shadowing.
6648
6649 * xgselect.c (xg_select): Remove unused var.
6650
6651 * image.c (four_corners_best): Mark locals as initialized.
6652 (gif_load): Initialize transparent_p to zero (Bug#8238).
6653 Mark another local as initialized.
6654 (my_png_error, my_error_exit): Mark with NO_RETURN.
6655
6656 * image.c (clear_image_cache): Now static.
6657 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6658 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6659 (x_edge_detection): Remove unnecessary cast that
6660 gcc -Wbad-function-cast diagnoses.
6661 (gif_load): Fix pointer signedness.
6662 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6663 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6664
6665 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 Improve quality of tests for time stamp overflow.
6668 For example, without this patch (encode-time 0 0 0 1 1
6669 1152921504606846976) returns the obviously-bogus value (-948597
6670 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6671 reports time overflow. See
6672 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6673 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6674 * editfns.c: Include limits.h and intprops.h.
6675 (TIME_T_MIN, TIME_T_MAX): New macros.
6676 (time_overflow): Move earlier, to before first use.
6677 (hi_time, lo_time): New functions, for an accurate test for
6678 out-of-range times.
6679 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6680 (Fget_internal_run_time): Don't assume time_t fits in int.
6681 (make_time): Use list2 instead of Fcons twice.
6682 (Fdecode_time): More accurate test for out-of-range times.
6683 (check_tm_member): New function.
6684 (Fencode_time): Use it, to test for out-of-range times.
6685 (lisp_time_argument): Don't rely on undefined left-shift and
6686 right-shift behavior when checking for time stamp overflow.
6687
6688 * editfns.c (time_overflow): New function, refactoring common code.
6689 (Fformat_time_string, Fdecode_time, Fencode_time):
6690 (Fcurrent_time_string): Use it.
6691
6692 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6693 * dired.c (make_time): Move to ...
6694 * editfns.c (make_time): ... here.
6695 * systime.h: Note the move.
6696
6697 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6698
6699 * fringe.c (update_window_fringes): Remove unused variables.
6700
6701 * unexmacosx.c (copy_data_segment): Also copy __got section.
6702 (Bug#8223)
6703
6704 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6705
6706 * termcap.c [MSDOS]: Include "msdos.h".
6707 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6708 Constify `char *' arguments and their references according to
6709 prototypes in tparam.h.
6710
6711 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6712
6713 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6714 Adapt all references accordingly.
6715
6716 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6717
6718 2011-03-11 Tom Tromey <tromey@redhat.com>
6719
6720 * buffer.c (syms_of_buffer): Remove obsolete comment.
6721
6722 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6723
6724 * termhooks.h (encode_terminal_code): Declare prototype.
6725
6726 * msdos.c (encode_terminal_code): Don't declare prototype.
6727
6728 * term.c (encode_terminal_code): Now external again, used by
6729 w32console.c and msdos.c.
6730
6731 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6732 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6733
6734 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6735
6736 Fix some minor problems found by GCC 4.5.2's static checks.
6737
6738 * fringe.c (update_window_fringes): Mark locals as initialized
6739 (Bug#8227).
6740 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6741
6742 * alloc.c (mark_fringe_data): Move decl from here ...
6743 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6744 to check its interface.
6745 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6746
6747 * fontset.c (free_realized_fontset): Now static.
6748 (Fset_fontset_font): Rename local to avoid shadowing.
6749 (fontset_font): Mark local as initialized.
6750 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6751
6752 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6753
6754 * xselect.c (x_disown_buffer_selections): Remove; not used.
6755 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6756 (x_own_selection, Fx_disown_selection_internal): Rename locals
6757 to avoid shadowing.
6758 (x_handle_dnd_message): Remove local to avoid shadowing.
6759
6760 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6761 so that the caller can use some name other than gcpro1.
6762 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6763 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6764 (Fx_backspace_delete_keys_p):
6765 Use them to avoid shadowing, and rename vars to avoid shadowing.
6766 (x_decode_color, x_set_name, x_window): Now static.
6767 (Fx_create_frame): Add braces to silence GCC warning.
6768 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6769 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6770 Remove unused locals.
6771 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6772 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6773 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6774 macros.
6775
6776 * xterm.h (x_mouse_leave): New decl.
6777
6778 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6779 Remove unused functions.
6780 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6781 (x_calc_absolute_position): Now static.
6782 (XTread_socket): Don't define label "out" unless it's used.
6783 Don't declare local "event" unless it's used.
6784 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6785 unless they are used.
6786 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6787 (x_fatal_error_signal): Remove; not used.
6788 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6789 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6790 (x_error_catcher, x_connection_closed, x_error_handler):
6791 (x_error_quitter, xembed_send_message, x_iconify_frame):
6792 (my_log_handler): Rename locals to avoid shadowing.
6793 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6794 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6795
6796 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6797 Rename or move locals to avoid shadowing.
6798 (tty_defined_color, merge_face_heights): Now static.
6799 (free_realized_faces_for_fontset): Remove; not used.
6800 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6801 does not deduce is never used uninitialized.
6802 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6803 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6804
6805 * terminal.c (store_terminal_param): Now static.
6806
6807 * xmenu.c (menu_highlight_callback): Now static.
6808 (set_frame_menubar): Remove unused local.
6809 (xmenu_show): Rename parameter to avoid shadowing.
6810 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6811 since they might point to immutable storage.
6812 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6813 since it's unused otherwise.
6814
6815 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6816 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6817 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6818 avoids a gcc -Wuninitialized diagnostic.
6819 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6820 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6821 does not deduce are never used uninitialized.
6822
6823 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6824
6825 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6826 * window.c (window_loop, size_window):
6827 (run_window_configuration_change_hook, enlarge_window): Likewise.
6828
6829 * window.c (display_buffer): Now static.
6830 (size_window): Mark variables that gcc -Wuninitialized
6831 does not deduce are never used uninitialized.
6832 * window.h (check_all_windows): New decl, to forestall
6833 gcc -Wmissing-prototypes diagnostic.
6834 * dispextern.h (bidi_dump_cached_states): Likewise.
6835
6836 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6837 shadowing.
6838 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6839 Include <limits.h>.
6840 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6841 and to avoid gcc -Wuninitialized warning.
6842 (load_charset_map): Mark variables that gcc -Wuninitialized
6843 does not deduce are never used uninitialized.
6844 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6845
6846 * coding.c (coding_set_source, coding_set_destination):
6847 Use "else { /* comment */ }" rather than "else /* comment */;"
6848 for clarity, and to avoid gcc -Wempty-body warning.
6849 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6850 a block, when the outer 'i' will do.
6851 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6852 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6853 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6854 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6855 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6856 Rename locals to avoid shadowing.
6857 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6858 * coding.c (emacs_mule_char, encode_invocation_designation):
6859 Now static, since they're not used elsewhere.
6860 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6861 (decode_coding_object, encode_coding_object, detect_coding_system):
6862 (decode_coding_emacs_mule): Mark variables that gcc
6863 -Wuninitialized does not deduce are never used uninitialized.
6864 (detect_coding_iso_2022): Initialize a local variable that might
6865 be used uninitialized. Leave a FIXME because it's not clear that
6866 this initialization is needed. (Bug#8211)
6867 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6868 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6869 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6870 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6871 Remove unused macros.
6872
6873 * category.c (hash_get_category_set): Remove unused local var.
6874 (copy_category_table): Now static, since it's not used elsewhere.
6875 * character.c (string_count_byte8): Likewise.
6876
6877 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6878 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6879
6880 * chartab.c (copy_sub_char_table): Now static, since it's not used
6881 elsewhere.
6882 (sub_char_table_ref_and_range, char_table_ref_and_range):
6883 Rename locals to avoid shadowing.
6884 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6885
6886 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6887 (BIDI_BOB): Remove unused macro.
6888
6889 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6890 deduce are never used uninitialized.
6891 * term.c (encode_terminal_code): Likewise.
6892
6893 * term.c (encode_terminal_code): Now static. Remove unused local.
6894
6895 * tparam.h: New file.
6896 * term.c, tparam.h: Include it.
6897 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6898 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6899 Move these decls to tparam.h, and make them agree with what
6900 is actually in tparam.c. The previous trick of using incompatible
6901 decls in different modules does not conform to the C standard.
6902 All callers of tparam changed to use tparam's actual API.
6903 * tparam.c (tparam1, tparam, tgoto):
6904 Use const pointers where appropriate.
6905
6906 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6907 * cm.h (struct cm): Likewise.
6908 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6909 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6910 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6911 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6912 (turn_on_face, init_tty): Likewise.
6913 * termchar.h (struct tty_display_info): Likewise.
6914
6915 * term.c (term_mouse_position): Rename local to avoid shadowing.
6916
6917 * alloc.c (mark_ttys): Move decl from here ...
6918 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6919
6920 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6921
6922 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6923
6924 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6925
6926 * search.c (compile_pattern_1): Remove argument regp, unused since
6927 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6928 (compile_pattern): Don't pass it.
6929
6930 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6931
6932 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6933 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6934 for ! HAVE_GTK3.
6935 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6936
6937 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6938
6939 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6940 gdk_window_get_screen, gdk_window_get_geometry,
6941 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6942 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6943 (xg_get_pixbuf_from_pixmap): New function.
6944 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6945 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6946 Call xg_get_pixbuf_from_pixmap instead of
6947 gdk_pixbuf_get_from_drawable.
6948 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6949 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6950 (xg_check_special_colors): Use GtkStyleContext and its functions
6951 for HAVE_GTK3.
6952 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6953 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6954 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6955 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6956 Call gtk_widget_get_preferred_size.
6957 (xg_frame_resized): gdk_window_get_geometry only takes 5
6958 parameters.
6959 (xg_win_to_widget, xg_event_is_for_menubar):
6960 Call gdk_x11_window_lookup_for_display.
6961 (xg_set_widget_bg): New function.
6962 (delete_cb): New function.
6963 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6964 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6965 (xg_set_background_color): Call xg_set_widget_bg.
6966 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6967 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6968 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6969 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6970 if ! HAVE_GTK3.
6971 (update_frame_tool_bar): Call gtk_widget_hide.
6972 (xg_initialize): Use GDK_KEY_g.
6973
6974 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6975 if ! HAVE_GTK3
6976 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6977
6978 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6979 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6980 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6981
6982 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6983
6984 * w32xfns.c (select_palette): Check success of RealizePalette against
6985 GDI_ERROR, not zero.
6986
6987 See ChangeLog.11 for earlier changes.
6988
6989 ;; Local Variables:
6990 ;; coding: utf-8
6991 ;; End:
6992
6993 Copyright (C) 2011 Free Software Foundation, Inc.
6994
6995 This file is part of GNU Emacs.
6996
6997 GNU Emacs is free software: you can redistribute it and/or modify
6998 it under the terms of the GNU General Public License as published by
6999 the Free Software Foundation, either version 3 of the License, or
7000 (at your option) any later version.
7001
7002 GNU Emacs is distributed in the hope that it will be useful,
7003 but WITHOUT ANY WARRANTY; without even the implied warranty of
7004 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7005 GNU General Public License for more details.
7006
7007 You should have received a copy of the GNU General Public License
7008 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.