1 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3 Make it possible to build with GCC-4.6+ -O2 -flto.
5 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10 Call minibuffer-inactive-mode.
12 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
14 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
17 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
19 * data.c (init_data): Remove code for UTS, this system is not
22 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
24 Don't force ./temacs to start in terminal mode.
26 * frame.c (make_initial_frame): Initialize faces in all cases, not
27 only when CANNOT_DUMP is defined.
28 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
30 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
32 * dispnew.c (add_window_display_history): Use const for the string
33 pointer. Remove declaration, not needed.
35 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
37 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
38 * category.c (hash_get_category_set):
40 * charset.c (Fdefine_charset_internal):
41 * charset.h (struct charset.hash_index):
42 * composite.c (get_composition_id, gstring_lookup_cache)
43 (composition_gstring_put_cache):
44 * composite.h (struct composition.hash_index):
45 * dispextern.h (struct image.hash):
46 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
47 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
48 (hashfn_equal, hashfn_user_defined, make_hash_table)
49 (maybe_resize_hash_table, hash_lookup, hash_put)
50 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
51 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
52 (Fsxhash, Fgethash, Fputhash, Fmaphash):
53 * image.c (make_image, search_image_cache, lookup_image)
54 (xpm_put_color_table_h):
55 * lisp.h (struct Lisp_Hash_Table):
56 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
57 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
58 for hashes and hash indexes, instead of 'unsigned' and 'int'.
59 * alloc.c (allocate_vectorlike): Check for overflow in vector size
61 * ccl.c (ccl_driver): Check for overflow when converting EMACS_INT
63 * fns.c, image.c: Remove unnecessary static decls that would otherwise
64 need to be updated by these changes.
65 * fns.c (make_hash_table, maybe_resize_hash_table): Check for integer
66 overflow with large hash tables.
67 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
68 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
69 (SXHASH_REDUCE): New macro.
70 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
71 Use it instead of discarding useful hash info with large hash values.
72 (sxhash_float): New function.
73 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
74 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
75 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK): Rewrite
76 to use FIXNUM_BITS, as this simplifies things.
77 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
78 Adjust signatures to match updated version of code.
79 (consing_since_gc): Now EMACS_INT, since a single hash table can
80 use more than INT_MAX bytes.
82 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
84 Use 'inline', not 'INLINE'.
85 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
86 * alloc.c, fontset.c (INLINE): Remove.
87 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
88 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
89 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
90 * gmalloc.c (register_heapinfo): Use inline unconditionally.
91 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
93 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
95 Make it possible to run ./temacs.
97 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
98 syms_of_callproc does the same thing. Remove test for
99 "initialized", do it in the caller.
100 * emacs.c (main): Avoid calling set_initial_environment when dumping.
102 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
104 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
105 (read_minibuf): Use get_minibuffer.
106 (syms_of_minibuf): Use DEFSYM.
107 (Qmetadata): New var.
108 * data.c (Qbuffer): Don't make it static.
109 (syms_of_data): Use DEFSYM.
111 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
113 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
114 (CCL_CODE_MIN): New macro.
116 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
118 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
120 * eval.c (Qdebug): Now static.
121 * lisp.h (Qdebug): Remove decl. This reverts a part of the
122 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
123 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
125 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
127 * image.c: Various fixes to ImageMagick code comments.
128 (Fimagemagick_types): Doc fix.
130 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
132 Minor fixes prompted by GCC 4.6.0 warnings.
134 * xselect.c (converted_selections, conversion_fail_tag): Now static.
136 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
137 (x_clipboard_manager_save_all): Move extern decl to ...
138 * xterm.h: ... here, so that it can be checked for consistency.
140 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
142 * xselect.c (x_clipboard_manager_save_frame)
143 (x_clipboard_manager_save_all): New functions.
144 (Fx_clipboard_manager_save): Lisp function deleted.
146 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
147 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
149 * xterm.h: Update prototype.
151 2011-05-28 William Xu <william.xwl@gmail.com>
153 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
156 2011-05-28 Jim Meyering <meyering@redhat.com>
158 Avoid a sign-extension bug in crypto_hash_function.
159 * fns.c (to_uchar): Define.
160 (crypto_hash_function): Use it to convert some newly-signed
161 variables to unsigned, to avoid sign-extension bugs. For example,
162 without this change, (md5 "truc") would evaluate to
163 45723a2aff78ff4fff7fff1114760e62 rather than the expected
164 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
165 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
167 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
169 Integer overflow fixes.
171 * dbusbind.c: Serial number integer overflow fixes.
172 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
173 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
174 to hold a serial number that is too large for a fixnum.
175 (Fdbus_method_return_internal, Fdbus_method_error_internal):
176 Check for serial numbers out of range. Decode any serial number
177 that was so large that it became a float. (Bug#8722)
179 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
181 Use XFASTINT rather than XUINT when numbers are nonnegative.
182 (xd_append_arg, Fdbus_method_return_internal):
183 (Fdbus_method_error_internal): Likewise. Also, for unsigned
184 arguments, check that Lisp number is nonnegative, rather than
185 silently wrapping negative numbers around. (Bug#8722)
186 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
189 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
191 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
193 ccl: add integer overflow checks
194 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
195 (IN_INT_RANGE): New macros.
196 (ccl_driver): Use them to check for integer overflow when
197 decoding a CCL program. Many of the new checks are whether XINT (x)
198 fits in int; it doesn't always, on 64-bit hosts. The new version
199 doesn't catch all possible integer overflows, but it's an
200 improvement. (Bug#8719)
202 * alloc.c (make_event_array): Use XINT, not XUINT.
203 There's no need for unsigned here.
205 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
206 This follows up to the 2011-05-06 change that substituted uintptr_t
207 for EMACS_INT. This case wasn't caught back then.
209 Rework Fformat to avoid integer overflow issues.
210 * editfns.c: Include <float.h> unconditionally, as it's everywhere
211 now (part of C89). Include <verify.h>.
212 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
213 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
214 (Fformat): Avoid the prepass trying to compute sizes; it was only
215 approximate and thus did not catch overflow reliably. Instead, walk
216 through the format just once, formatting and computing sizes as we go,
217 checking for integer overflow at every step, and allocating a larger
218 buffer as needed. Keep track separately whether the format is
219 multibyte. Keep only the most-recently calculated precision, rather
220 than them all. Record whether each argument has been converted to
221 string. Use EMACS_INT, not int, for byte and char and arg counts.
222 Support field widths and precisions larger than INT_MAX. Avoid
223 sprintf's undefined behavior with conversion specifications such as %#d
224 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
225 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
226 formatting out-of-range floating point numbers with int
229 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
231 * data.c: Avoid integer truncation in expressions involving floats.
232 * data.c: Include <intprops.h>.
233 (arith_driver): When there's an integer overflow in an expression
234 involving floating point, convert the integers to floating point
235 so that the resulting value does not suffer from catastrophic
236 integer truncation. For example, on a 64-bit host (* 4
237 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
238 Do not rely on undefined behavior after integer overflow.
240 merge count_size_as_multibyte, parse_str_to_multibyte
241 * character.c, character.h (count_size_as_multibyte):
242 Rename from parse_str_to_multibyte; all uses changed.
243 Check for integer overflow.
244 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
245 since it's now a duplicate of the other. This is more of
246 a character than a buffer op, so better that it's in character.c.
247 * fns.c, print.c: Adjust to above changes.
249 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
251 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
253 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
255 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
256 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
257 (x_clipboard_manager_save): Now static.
258 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
260 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
261 (crypto_hash_function): Now static.
262 Fix pointer signedness problems. Avoid unnecessary initializations.
264 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
266 * termhooks.h (Vselection_alist): Make it terminal-local.
268 * terminal.c (create_terminal): Initialize it.
270 * xselect.c: Support for clipboard managers.
271 (Vselection_alist): Move to termhooks.h as terminal-local var.
272 (LOCAL_SELECTION): New macro.
273 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
274 (symbol_to_x_atom): Remove gratuitous arg.
275 (x_handle_selection_request, lisp_data_to_selection_data)
276 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
277 (x_own_selection, x_get_local_selection, x_convert_selection):
278 New arg, specifying work frame. Use terminal-local Vselection_alist.
279 (some_frame_on_display): Delete unused function.
280 (Fx_own_selection_internal, Fx_get_selection_internal)
281 (Fx_disown_selection_internal, Fx_selection_owner_p)
282 (Fx_selection_exists_p): New optional frame arg.
283 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
284 (x_handle_selection_clear): Don't treat other terminals with the
285 same keyboard specially. Use the terminal-local Vselection_alist.
286 (x_clear_frame_selections): Use Frun_hook_with_args.
288 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
290 * xterm.h: Add support for those atoms.
292 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
294 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
295 (converted_selections, conversion_fail_tag): New global variables.
296 (x_selection_request_lisp_error): Free the above.
297 (x_get_local_selection): Remove unnecessary code.
298 (x_reply_selection_request): Args changed; handle arbitrary array
299 of converted selections stored in converted_selections.
300 Separate the XChangeProperty and SelectionNotify steps.
301 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
302 (x_convert_selection): New function.
303 (x_handle_selection_event): Simplify.
304 (x_get_foreign_selection): Don't ignore incoming requests while
305 waiting for an answer; this will fail when we implement
306 SAVE_TARGETS, and seems unnecessary anyway.
307 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
308 (Vx_sent_selection_functions): Doc fix.
310 2011-05-26 Leo Liu <sdl.web@gmail.com>
312 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
314 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
316 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
318 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
319 for fringe update if it has periodic bitmap.
320 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
321 and fringe_bitmap_periodic_p.
323 * fringe.c (get_fringe_bitmap_data): New function.
324 (draw_fringe_bitmap_1, update_window_fringes): Use it.
325 (update_window_fringes): Record periodicity of fringe bitmap in glyph
326 row. Mark glyph row for fringe update if periodicity changed.
328 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
329 for fringe update unless it has periodic bitmap.
331 2011-05-25 Kenichi Handa <handa@m17n.org>
333 * xdisp.c (get_next_display_element): Set correct it->face_id for
334 a static composition.
336 2011-05-24 Leo Liu <sdl.web@gmail.com>
339 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
341 * fns.c (crypto_hash_function, Fsha1): New function.
342 (Fmd5): Use crypto_hash_function.
343 (syms_of_fns): Add Ssha1.
345 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
347 * gnutls.c: Remove unused macros.
348 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
349 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
350 Remove macros that are defined and never used.
351 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
353 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
355 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
356 (Fx_get_selection_internal): Minor cleanup.
357 (Fx_own_selection_internal): Rename arguments for consistency with
360 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
362 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
364 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
366 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
368 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
370 * dispnew.c (scrolling_window): Don't exclude the case that the
371 last enabled row in the desired matrix touches the bottom boundary.
373 2011-05-21 Glenn Morris <rgm@gnu.org>
375 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
376 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
377 and add some more files.
379 2011-05-20 Eli Zaretskii <eliz@gnu.org>
381 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
382 report_file_error introduced by the change from 2011-05-07.
384 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
386 * systime.h (Time): Define only if emacs is defined.
387 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
388 where the include path doesn't have X11/X.h by default. See
389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
391 2011-05-20 Kenichi Handa <handa@m17n.org>
393 * composite.c (find_automatic_composition): Fix previous change.
395 2011-05-20 Glenn Morris <rgm@gnu.org>
397 * lisp.mk: New file, split from Makefile.in.
398 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
400 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
402 2011-05-19 Glenn Morris <rgm@gnu.org>
404 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
405 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
406 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
407 (lisp): Set the order to that of loadup.el.
408 (shortlisp): Make it a copy of $lisp.
409 (SOME_MACHINE_LISP): Remove.
410 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
411 Use just $shortlisp, not $SOME_MACHINE_LISP too.
413 2011-05-18 Kenichi Handa <handa@m17n.org>
415 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
416 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
417 (find_automatic_composition): Mostly rewrite for efficiency.
419 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
421 * makefile.w32-in: Update dependencies.
423 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
425 * menu.c: Include limits.h (fixes the MS-Windows build broken by
428 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
430 Fix some integer overflow issues, such as string length overflow.
432 * insdel.c (count_size_as_multibyte): Check for string overflow.
434 * character.c (lisp_string_width): Check for string overflow.
435 Use EMACS_INT, not int, for string indexes and lengths; in
436 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
437 the resulting string length overflows an EMACS_INT; instead,
438 report a string overflow if no precision given. When checking for
439 precision exhaustion, use a check that cannot possibly have
440 integer overflow. (Bug#8675)
441 * character.h (lisp_string_width): Adjust to new signature.
443 * alloc.c (string_overflow): New function.
444 (Fmake_string): Use it. This doesn't change behavior, but saves
445 a few bytes and will simplify future changes.
446 * character.c (string_escape_byte8): Likewise.
447 * lisp.h (string_overflow): New decl.
449 Fixups, following up to the user-interface timestamp change.
450 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
451 for UI timestamps, instead of unsigned long.
452 * msdos.c (mouse_get_pos): Likewise.
453 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
454 * w32gui.h (Time): Define by including "systime.h" rather than by
455 declaring it ourselves. (Bug#8664)
457 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
458 * image.c (clear_image_cache): Likewise.
460 * term.c (term_mouse_position): Don't assume time_t wraparound.
462 Be more systematic about user-interface timestamps.
463 Before, the code sometimes used 'Time', sometimes 'unsigned long',
464 and sometimes 'EMACS_UINT', to represent these timestamps.
465 This change causes it to use 'Time' uniformly, as that's what X uses.
466 This makes the code easier to follow, and makes it easier to catch
467 integer overflow bugs such as Bug#8664.
468 * frame.c (Fmouse_position, Fmouse_pixel_position):
469 Use Time, not unsigned long, for user-interface timestamps.
470 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
471 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
472 * keyboard.h (last_event_timestamp): Likewise.
473 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
474 * menu.h (xmenu_show): Likewise.
475 * term.c (term_mouse_position): Likewise.
476 * termhooks.h (struct input_event.timestamp): Likewise.
477 (struct terminal.mouse_position_hook): Likewise.
478 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
479 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
480 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
481 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
483 * menu.h, termhooks.h: Include "systime.h", for Time.
485 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
486 Don't assume that the difference between two unsigned long values
487 can fit into an integer. At this point, we know button_down_time
488 <= event->timestamp, so the difference must be nonnegative, so
489 there's no need to cast the result if double-click-time is
490 nonnegative, as it should be; check that it's nonnegative, just in
491 case. This bug is triggered when events are more than 2**31 ms
492 apart (about 25 days). (Bug#8664)
494 * xselect.c (last_event_timestamp): Remove duplicate decl.
495 (x_own_selection): Remove needless cast to unsigned long.
497 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
498 that always fit in int. Use a sentinel instead of a counter, to
499 avoid a temp and to allay GCC's concerns about possible int overflow.
500 * frame.h (struct frame): Use int for menu_bar_items_used
501 instead of EMACS_INT, since it always fits in int.
503 * menu.c (grow_menu_items): Check for int overflow.
505 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
507 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
508 Before, the code was not consistent. These values cannot exceed
509 2**31 - 1 so there's no need to make them unsigned.
510 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
511 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
512 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
514 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
516 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
517 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
518 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
519 presumably because the widths might not match.
521 * window.c (size_window): Avoid needless test at loop start.
523 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
525 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
527 2011-05-12 Drew Adams <drew.adams@oracle.com>
529 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
531 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
533 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
534 `width' to `bar_area_x' and `bar_area_width', respectively.
535 (x_scroll_run): Take account of fringe background extension.
537 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
538 Rename local vars `left' and `width' to `bar_area_x' and
539 `bar_area_width', respectively.
540 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
541 background extension.
543 2011-05-10 Jim Meyering <meyering@redhat.com>
545 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
547 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
549 * image.c (Finit_image_library): Return t for built-in image types,
550 like pbm and xbm. (Bug#8640)
552 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
554 * w32menu.c (set_frame_menubar): Fix submenu allocation.
556 2011-05-07 Eli Zaretskii <eliz@gnu.org>
558 * w32console.c (Fset_screen_color): Doc fix.
559 (Fget_screen_color): New function.
560 (syms_of_ntterm): Defsubr it.
562 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
563 unlink the temporary file if Fcall_process didn't create it in the
565 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
566 child process will be redirected to a file specified with `:file'.
567 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
568 cue to call_process_cleanup not to close that handle.
570 2011-05-07 Ben Key <bkey76@gmail.com>
572 * makefile.w32-in: The bootstrap-temacs rule now makes use of
573 one of two shell specific rules, either bootstrap-temacs-CMD or
574 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
575 to the previous implementation of the bootstrap-temacs rule.
576 The bootstrap-temacs-CMD rule is similar to the previous
577 implementation of the bootstrap-temacs rule except that it
578 makes use of the ESC_CFLAGS variable instead of the CFLAGS
581 These changes, along with some changes to nt/configure.bat,
582 nt/gmake.defs, and nt/nmake.defs, are required to extend my
583 earlier fix to add support for --cflags and --ldflags options
584 that include quotes so that it works whether make uses cmd or
587 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
589 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
590 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
592 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
593 a string. Handle both cases.
594 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
595 (Fdbus_register_method): Use Qinvalid_function.
597 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
599 * makefile.w32-in: Update dependencies.
600 (LISP_H): Add inttypes.h and stdin.h.
601 (PROCESS_H): Add unistd.h.
603 2011-05-06 Eli Zaretskii <eliz@gnu.org>
605 * lread.c: Include limits.h (fixes the MS-Windows build broken by
606 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
608 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
610 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
612 * term.c (vfatal): Remove stray call to va_end.
613 It's not needed and the C Standard doesn't allow it here anyway.
615 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
616 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
618 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
621 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
623 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
625 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
627 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
629 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
631 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
632 * charset.c (Fdefine_charset_internal): Don't initialize
633 charset.code_space[15]. The value was garbage, on hosts with
634 32-bit int (Bug#8600).
636 * lread.c (read_integer): Be more consistent with string-to-number.
637 Use string_to_number to do the actual conversion; this avoids
638 rounding errors and fixes some other screwups. Without this fix,
639 for example, #x1fffffffffffffff was misread as -2305843009213693952.
640 (digit_to_number): Move earlier, for benefit of read_integer.
641 Return -1 if the digit is out of range for the base, -2 if it is
642 not a digit in any supported base. (Bug#8602)
644 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
646 * dispnew.c (scrolling_window): Return 1 if we scrolled,
647 to match comment at start of function. This also removes a
648 GCC warning about overflow in a 32+64-bit port.
650 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
652 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
653 Reported by Stefan Monnier in
654 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
656 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
658 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
659 (EMACS_UINTPTR): Likewise, with uintptr_t.
661 * lisp.h: Prefer 64-bit EMACS_INT if available.
662 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
663 on 32-bit hosts that have 64-bit int, so that they can access
665 However, temporarily disable this change unless the temporary
666 symbol WIDE_EMACS_INT is defined.
668 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
670 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
671 This removes an assumption that EMACS_INT and long are the same
672 width as pointers. The assumption is true for Emacs porting targets
673 now, but we want to make other targets possible.
674 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
675 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
676 In the rest of the code, change types of integers that hold casted
677 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
678 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
679 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
680 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
681 No need to cast type when ORing.
682 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
683 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
684 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
685 assume EMACS_INT is the same width as char *.
686 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
687 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
688 Remove no-longer-needed casts.
689 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
690 (xg_tool_bar_help_callback, xg_make_tool_item):
691 Use EMACS_INTPTR to hold an integer
692 that will be cast to void *; this can avoid a GCC warning
693 if EMACS_INT is not the same width as void *.
694 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
695 * xdisp.c (display_echo_area_1, resize_mini_window_1):
696 (current_message_1, set_message_1):
697 Use a local to convert to proper width without a cast.
698 * xmenu.c (dialog_selection_callback): Likewise.
700 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
701 Also, don't assume VALBITS / RAND_BITS is less than 5,
702 and don't rely on undefined behavior when shifting a 1 left into
704 * lisp.h (get_random): Change signature to match.
706 * lread.c (hash_string): Use size_t, not int, for hash computation.
707 Normally we prefer signed values; but hashing is special, because
708 it's better to use unsigned division on hash table sizes so that
709 the remainder is nonnegative. Also, size_t is the natural width
710 for hashing into memory. The previous code used 'int', which doesn't
711 retain enough info to hash well into very large tables.
712 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
714 * dbusbind.c: Don't possibly lose pointer info when converting.
715 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
716 Use XPNTR rather than XHASH, so that the high-order bits of
717 the pointer aren't lost when converting through void *.
719 * eval.c (Fautoload): Don't double-shift a pointer.
721 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
723 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
725 * gnutls.c (DEF_GNUTLS_FN):
726 * image.c (DEF_IMGLIB_FN): Make function pointers static.
728 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
730 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
733 2011-05-05 Eli Zaretskii <eliz@gnu.org>
735 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
736 New version that can reserve upto 2GB of heap space.
738 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
740 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
742 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
744 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
745 `gnutls_certificate_set_x509_key_file'.
747 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
749 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
752 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
754 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
755 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
756 Remove unused parameter `fildes'.
757 * process.c (read_process_output, send_process): Don't pass it.
759 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
761 Fix previous change: the library cache is defined in w32.c.
762 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
763 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
765 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
767 Implement dynamic loading of GnuTLS on Windows.
769 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
770 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
771 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
774 * gnutls.c (Qgnutls_dll): Define.
775 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
776 (gnutls_*): Declare function pointers.
777 (init_gnutls_functions): New function to initialize function pointers.
778 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
779 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
780 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
781 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
782 (emacs_gnutls_write, emacs_gnutls_read)
783 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
784 (Fgnutls_available_p): New function.
785 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
786 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
787 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
789 * image.c: Include w32.h.
790 (Vimage_type_cache): Delete.
791 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
792 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
793 (w32_delayed_load): Move to w32.c.
795 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
797 * w32.c (QCloaded_from, Vlibrary_cache): Define.
798 (w32_delayed_load): Move from image.c. When loading a library, record
799 its filename in the :loaded-from property of the library id.
800 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
801 Initialize and staticpro them.
802 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
804 * process.c: Include lisp.h before w32.h, not after.
805 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
806 instead of gnutls_record_check_pending.
808 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
810 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
812 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
813 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
816 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
818 * xterm.c (x_set_frame_alpha): Do not set property on anything
819 else than FRAME_X_OUTER_WINDOW (Bug#8608).
821 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
823 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
825 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
827 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
828 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
829 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
830 (gnutls_global_initialized, Qgnutls_bootprop_priority)
831 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
832 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
833 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
834 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
835 (Qgnutls_bootprop_callbacks_verify): Make static.
837 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
839 * callproc.c: Indentation fixup.
841 * sysdep.c (wait_for_termination_1): Make static.
842 (wait_for_termination, interruptible_wait_for_termination):
843 Move after wait_for_termination_1.
845 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
847 * sysdep.c (interruptible_wait_for_termination): New function
848 which is like wait_for_termination, but allows keyboard
851 * callproc.c (Fcall_process): Add (:file "file") as an option for
853 (Fcall_process_region): Ditto.
855 2011-04-30 Eli Zaretskii <eliz@gnu.org>
857 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
858 rather than `XVECTOR (FOO)->size'.
860 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
861 inttypes.h, as a gnulib replacement is used if it not available in
864 2011-04-21 Eli Zaretskii <eliz@gnu.org>
866 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
867 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
868 of MOST_POSITIVE_FIXNUM. (Bug#8528)
870 * coding.c (coding_alloc_by_realloc): Error out if destination
871 will grow beyond MOST_POSITIVE_FIXNUM.
872 (decode_coding_emacs_mule): Abort if there isn't enough place in
873 charbuf for the composition carryover bytes. Reserve an extra
874 space for up to 2 characters produced in a loop.
875 (decode_coding_iso_2022): Abort if there isn't enough place in
876 charbuf for the composition carryover bytes.
878 2011-04-21 Eli Zaretskii <eliz@gnu.org>
880 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
881 aborting when %lld or %lll format is passed.
882 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
883 %llo or %llx format is passed. (Bug#8545)
885 * window.c (window_scroll_line_based): Use a marker instead of
886 simple variables to record original value of point. (Bug#7952)
888 * doprnt.c (doprnt): Fix the case where a multibyte sequence
889 produced by %s or %c overflows available buffer space. (Bug#8545)
891 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
893 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
894 (SIZE_MAX): Move defn after all includes, as they might #define it.
896 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
898 * w32.c (init_environment): Warn about defaulting HOME to C:\.
900 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
902 * keyboard.c (Qdelayed_warnings_hook): Define.
903 (command_loop_1): Run `delayed-warnings-hook'
904 if Vdelayed_warnings_list is non-nil.
905 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
906 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
908 2011-04-28 Eli Zaretskii <eliz@gnu.org>
910 * doprnt.c (doprnt): Don't return value smaller than the buffer
911 size if the message was truncated. (Bug#8545).
913 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
915 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
916 (Fx_window_property): #if-0 the whole functions, not just the bodies.
918 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
920 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
922 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
924 * makefile.w32-in: Update dependencies.
926 2011-04-27 Eli Zaretskii <eliz@gnu.org>
928 Improve `doprnt' and its usage. (Bug#8545)
929 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
930 `format_end'. Remove support for %l as a conversion specifier.
931 Don't use xrealloc. Improve diagnostics when the %l size modifier
932 is used. Update the commentary.
934 * eval.c (verror): Simplify calculation of size_t.
936 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
939 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
941 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
944 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
946 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
947 This makes this file independent of the recent pseudovector change.
949 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
951 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
953 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
954 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
956 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
958 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
959 GCC 4.6.0 optimizes based on type-based alias analysis.
960 For example, if b is of type struct buffer * and v of type struct
961 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
962 != &v->size, and therefore "v->size = 1; b->size = 2; return
963 v->size;" must therefore return 1. This assumption is incorrect
964 for Emacs, since it type-puns struct Lisp_Vector * with many other
965 types. To fix this problem, this patch adds a new type struct
966 vectorlike_header that documents the constraints on layout of vectors
967 and pseudovectors, and helps optimizing compilers not get fooled
968 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
969 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
970 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
972 (XSETPVECTYPE): Rewrite in terms of new macro.
973 (XSETPVECTYPESIZE): New macro, specifying both type and size.
974 This is a bit clearer, and further avoids the possibility of
975 undesirable aliasing.
976 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
977 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
978 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
979 since Lisp_Subr is a special case (no "next" field).
980 (ASIZE): Now uses header.size rather than size.
981 All previous uses of XVECTOR (foo)->size replaced to use this macro,
982 to avoid the hassle of writing XVECTOR (foo)->header.size.
983 (struct vectorlike_header): New type.
984 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
985 object, to help avoid aliasing.
986 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
987 (SUBRP): Likewise, since Lisp_Subr is a special case.
988 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
989 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
990 (struct Lisp_Hash_Table): Combine first two members into a single
991 struct vectorlike_header member. All uses of "size" and "next" members
992 changed to be "header.size" and "header.next".
993 * buffer.h (struct buffer): Likewise.
994 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
995 * frame.h (struct frame): Likewise.
996 * process.h (struct Lisp_Process): Likewise.
997 * termhooks.h (struct terminal): Likewise.
998 * window.c (struct save_window_data, struct saved_window): Likewise.
999 * window.h (struct window): Likewise.
1000 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1001 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1002 * buffer.c (init_buffer_once): Likewise.
1003 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1005 * process.c (Fformat_network_address): Use local var for size,
1008 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1010 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1011 * data.c (atof): Remove decl; no longer used or needed.
1012 (digit_to_number): Move to lread.c.
1013 (Fstring_to_number): Use new string_to_number function, to be
1014 consistent with how the Lisp reader treats infinities and NaNs.
1015 Do not assume that floating-point numbers represent EMACS_INT
1016 without losing information; this is not true on most 64-bit hosts.
1017 Avoid double-rounding errors, by insisting on integers when
1018 parsing non-base-10 numbers, as the documentation specifies.
1019 * lisp.h (string_to_number): New decl, replacing ...
1020 (isfloat_string): Remove.
1021 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1022 (read1): Do not accept +. and -. as integers; this
1023 appears to have been a coding error. Similarly, do not accept
1024 strings like +-1e0 as floating point numbers. Do not report
1025 overflow for integer overflows unless the base is not 10 which
1026 means we have no simple and reliable way to continue.
1027 Break out the floating-point parsing into a new
1028 function string_to_number, so that Fstring_to_number parses
1029 floating point numbers consistently with the Lisp reader.
1030 (digit_to_number): Move here from data.c. Make it static inline.
1031 (E_CHAR, EXP_INT): Remove, replacing with ...
1032 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1033 (string_to_number): New function, replacing isfloat_string.
1034 This function checks for valid syntax and produces the resulting
1035 Lisp float number too. Rework it so that string-to-number
1036 no longer mishandles examples like "1.0e+". Use strtoumax,
1037 so that overflow for non-base-10 numbers is reported only when
1038 there's no portable and simple way to convert to floating point.
1040 * textprop.c (set_text_properties_1): Rewrite for clarity,
1041 and to avoid GCC warning about integer overflow.
1043 * intervals.h (struct interval): Use EMACS_INT for members
1044 where EMACS_UINT might cause problems. See
1045 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1046 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1047 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1049 (offset_intervals): Tell GCC not to worry about length overflow
1050 when negating a negative length.
1052 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1053 (overrun_check_free): Likewise.
1055 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1056 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1059 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1060 (gnutls_make_error): Rename local to avoid shadowing.
1061 (gnutls_emacs_global_deinit): ifdef out; not used.
1062 (Fgnutls_boot): Use const for pointer to readonly storage.
1063 Comment out unused local. Fix pointer signedness problems.
1065 * lread.c (openp): Don't stuff size_t into an 'int'.
1066 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1067 about possible signed overflow.
1069 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1070 (GDK_KEY_g): Don't define if already defined.
1071 (xg_prepare_tooltip): Avoid pointer signedness problem.
1072 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1074 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1075 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1077 * xfns.c (Fx_window_property): Simplify a bit,
1078 to make a bit faster and to avoid GCC 4.6.0 warning.
1079 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1081 * fns.c (internal_equal): Don't assume size_t fits in int.
1083 * alloc.c (compact_small_strings): Tighten assertion a little.
1085 Replace pEd with more-general pI, and fix some printf arg casts.
1086 * lisp.h (pI): New macro, generalizing old pEd macro to other
1087 conversion specifiers. For example, use "...%"pI"d..." rather
1088 than "...%"pEd"...".
1089 (pEd): Remove. All uses replaced with similar uses of pI.
1090 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1091 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1092 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1093 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1094 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1095 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1096 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1098 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1099 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1100 * print.c (safe_debug_print, print_object): Likewise.
1101 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1103 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1104 avoiding the 0 flag, which is not portable.
1105 * process.c (Fmake_network_process): Use pI to avoid cast.
1106 * region-cache.c (pp_cache): Likewise.
1107 * xdisp.c (decode_mode_spec): Likewise.
1108 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1109 behavior on 64-bit hosts with printf arg.
1110 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1111 (x_stop_queuing_selection_requests): Likewise.
1112 (x_get_window_property): Don't truncate byte count to an 'int'
1115 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1116 here, since it parses constructs like leading '-' and spaces,
1117 which are not wanted; and it overflows with large numbers.
1118 Instead, simply match F[0-9]+, which is what is wanted anyway.
1120 * alloc.c: Remove unportable assumptions about struct layout.
1121 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1122 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1123 (allocate_vectorlike, make_pure_vector): Use the new macros,
1124 plus offsetof, to remove unportable assumptions about struct layout.
1125 These assumptions hold on all porting targets that I know of, but
1126 they are not guaranteed, they're easy to remove, and removing them
1127 makes further changes easier.
1129 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1130 This doesn't fix a bug but makes the code clearer.
1131 (string_overrun_cookie): Now const. Use initializers that
1132 don't formally overflow signed char, to avoid warnings.
1133 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1134 can cause Emacs to crash when string overrun checking is enabled.
1135 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1136 multiple of sizeof (EMACS_INT); it need not be, if
1137 alignof(EMACS_INT) < sizeof (EMACS_INT).
1138 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1140 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1142 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1144 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1146 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1147 supposed to be handshaking. (Bug#8556)
1148 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1150 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1152 * lisp.h (Qdebug): List symbol.
1153 * eval.c (Qdebug): Restore global linkage.
1154 * keyboard.c (debug-on-event): New variable.
1155 (handle_user_signal): Break into debugger when debug-on-event
1156 matches the current signal symbol.
1158 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1160 * alloc.c (check_sblock, check_string_bytes)
1161 (check_string_free_list): Convert to standard C.
1163 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1165 * w32.c (emacs_gnutls_push): Fix typo.
1167 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1169 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1170 "cast to pointer from integer of different size".
1172 Improve doprnt and its use in verror. (Bug#8545)
1173 * doprnt.c (doprnt): Document the set of format control sequences
1174 supported by the function. Use SAFE_ALLOCA instead of always
1177 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1178 is one byte too soon. Don't use xrealloc; instead xfree and
1181 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1183 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1186 * gnutls.c: Renamed global_initialized to
1187 gnutls_global_initialized. Added internals for the
1188 :verify-hostname-error, :verify-error, and :verify-flags
1189 parameters of `gnutls-boot' and documented those parameters in the
1190 docstring. Start callback support.
1191 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1192 unless a fatal error occured. Call gnutls_alert_send_appropriate
1193 on error. Return error code.
1194 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1195 (emacs_gnutls_read): Likewise.
1196 (Fgnutls_boot): Return handshake error code.
1197 (emacs_gnutls_handle_error): New function.
1198 (wsaerror_to_errno): Likewise.
1200 * w32.h (emacs_gnutls_pull): Add prototype.
1201 (emacs_gnutls_push): Likewise.
1203 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1204 (emacs_gnutls_push): Likewise.
1206 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1208 * process.c (wait_reading_process_output): Check if GnuTLS
1209 buffered some data internally if no FDs are set for TLS
1212 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1213 (LIBS): Link to USER_LIBS.
1214 ($(BLD)/gnutls.$(0)): New target.
1216 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1218 * xdisp.c (handle_single_display_spec): Rename the
1219 display_replaced_before_p argument into display_replaced_p, to
1220 make it consistent with the commentary. Fix typos in the
1223 * textprop.c (syms_of_textprop): Remove dead code.
1224 (copy_text_properties): Delete obsolete commentary about an
1225 interface that was deleted long ago. Fix typos in the description
1228 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1229 to changes in oldXMenu/XMenu.h from 2011-04-16.
1230 <menu_help_message, prev_menu_help_message>: Constify.
1231 (IT_menu_make_room): menu->help_text is now `const char **';
1234 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1235 to changes in oldXMenu/XMenu.h from 2011-04-16.
1236 (struct XMenu): Declare `help_text' `const char **'.
1238 * xfaces.c <Qunspecified>: Make extern again.
1240 * syntax.c: Include sys/types.h before including regex.h, as
1243 * doc.c (get_doc_string): Improve the format passed to `error'.
1245 * doprnt.c (doprnt): Improve commentary.
1247 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1249 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1252 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1253 changes in globals.h immediately force recompilation.
1254 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1255 $(CURDIR)/s/ms-w32.h.
1256 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1258 * character.c (Fchar_direction): Function deleted.
1259 (syms_of_character): Don't defsubr it.
1260 <char-direction-table>: Deleted.
1262 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1264 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1265 * doprnt.c: Include limits.h.
1266 (SIZE_MAX): New macro.
1267 (doprnt): Return a size_t value. 2nd arg is now size_t.
1268 Many local variables are now size_t instead of int or unsigned.
1269 Improve overflow protection. Support `l' modifier for integer
1270 conversions. Support %l conversion. Don't assume an EMACS_INT
1271 argument for integer conversions and for %c.
1273 * lisp.h (doprnt): Restore prototype.
1275 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1278 * Makefile.in (base_obj): Add back doprnt.o.
1280 * deps.mk (doprnt.o): Add back prerequisites.
1281 (callint.o): Depend on character.h.
1283 * eval.c (internal_lisp_condition_case): Include the handler
1284 representation in the error message.
1285 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1286 when breaking from the loop.
1288 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1290 * callint.c (Fcall_interactively): When displaying error message
1291 about invalid control letter, pass the character's codepoint, not
1292 a pointer to its multibyte form. Improve display of the character
1293 in octal and display also its hex code.
1295 * character.c (char_string): Use %x to display the (unsigned)
1296 codepoint of an invalid character, to avoid displaying a bogus
1299 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1300 `error', not SYMBOL_NAME itself.
1302 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1303 character arguments to `error'.
1305 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1306 to `error' in error message about FINAL_CHAR argument. Make sure
1307 FINAL_CHAR is a character, and use %c when it is passed as
1308 argument to `error'.
1310 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1312 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1314 * w32.c: Include <time.h>.
1315 (sys_localtime): New function.
1317 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1319 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1321 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1323 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1325 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1328 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1330 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1331 gl_state.e_property when gl_state.object is Qt.
1333 * insdel.c (make_gap_larger): Remove limitation of buffer size
1336 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1338 * xdisp.c (lookup_glyphless_char_display)
1339 (produce_glyphless_glyph): Handle cons cell entry in
1340 glyphless-char-display.
1341 (Vglyphless_char_display): Document it.
1343 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1344 glyphless-char-display.
1346 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1348 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1350 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1352 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1353 definition for no-X builds.
1355 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1357 Static checks with GCC 4.6.0 and non-default toolkits.
1359 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1361 * process.c (keyboard_bit_set): Define only if SIGIO.
1362 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1363 (send_process): Repair possible setjmp clobbering.
1365 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1367 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1369 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1371 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1372 Define only if needed.
1374 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1375 by pacifying GCC about it. Maybe it's time to retire it?
1376 * xfaces.c (USG, __TIMEVAL__): Likewise.
1378 * dispextern.h (struct redisplay_interface): Rename param
1380 * termhooks.h (struct terminal): Likewise.
1381 * xterm.c (xembed_send_message): Likewise.
1383 * insdel.c (make_gap_smaller): Define only if
1384 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1386 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1389 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1390 so that we aren't warned about unused symbols.
1392 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1394 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1396 * xfns.c (x_real_positions): Mark locals as initialized.
1398 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1400 * xterm.c: Fix problems found by static analysis with other toolkits.
1401 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1402 (x_dispatch_event): Declare static if USE_GTK, and
1403 define if USE_GTK || USE_X_TOOLKIT.
1404 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1405 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1406 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1407 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1409 * xmenu.c (menu_help_callback): Pointer type fixes.
1410 Use const pointers when pointing at readonly data. Avoid pointer
1412 (FALSE): Remove unused macro.
1413 (update_frame_menubar): Remove unused decl.
1415 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1417 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1418 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1419 (single_menu_item): Rename local to avoid shadowing.
1421 * keyboard.c (make_lispy_event): Remove unused local var.
1423 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1424 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1426 * bitmaps: Change bitmaps from unsigned char back to the X11
1427 compatible char. Avoid the old compiler warnings about
1428 out-of-range initializers by using, for example, '\xab' rather
1431 * xgselect.c (xgselect_initialize): Check vs interface
1432 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1434 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1436 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1437 to read-only memory.
1439 * fns.c (vector): Remove; this old hack is no longer needed.
1441 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1443 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1445 * xrdb.c (x_load_resources): Omit unused local.
1447 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1448 (x_window): Rename locals to avoid shadowing.
1449 (USG): Use the kludged USG macro, to pacify gcc.
1451 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1452 (x_term_init): Remove local to avoid shadowing.
1454 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1456 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1457 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1459 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1461 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1463 Fix regex.c, syntax.c and friends for buffers > 2GB.
1464 * syntax.h (struct gl_state_s): Declare character position members
1467 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1469 * textprop.c (verify_interval_modification, interval_of):
1470 Declare arguments EMACS_INT.
1472 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1475 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1477 * indent.c (Fvertical_motion): Local variable it_start is now
1480 * regex.c (re_match, re_match_2, re_match_2_internal)
1481 (bcmp_translate, regcomp, regexec, print_double_string)
1482 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1483 (re_compile_pattern, re_exec): Declare arguments and local
1484 variables `size_t' and `ssize_t' and return values `regoff_t', as
1486 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1487 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1488 <compile_stack_type>: `size' and `avail' are now `size_t'.
1490 * regex.h <regoff_t>: Use ssize_t, not int.
1491 (re_search, re_search_2, re_match, re_match_2): Arguments that
1492 specify buffer/string position and length are now ssize_t and
1493 size_t. Return type is regoff_t.
1495 2011-04-16 Ben Key <bkey76@gmail.com>
1497 * nsfont.m: Fixed bugs in ns_get_family and
1498 ns_descriptor_to_entity that were caused by using free to
1499 deallocate memory blocks that were allocated by xmalloc (via
1500 xstrdup). This caused Emacs to crash when compiled with
1501 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1502 --enable-checking=xmallocoverrun). xfree is now used to
1503 deallocate these memory blocks.
1505 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1507 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1509 emacs_write: Accept and return EMACS_INT for sizes.
1510 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1512 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1513 Accept and return EMACS_INT.
1514 (emacs_gnutls_write): Return the number of bytes written on
1516 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1517 (emacs_read, emacs_write): Remove check for negative size, as the
1518 Emacs source code has been audited now.
1519 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1520 (emacs_read, emacs_write): Use it.
1521 * process.c (send_process): Adjust to the new signatures of
1522 emacs_write and emacs_gnutls_write. Do not attempt to store
1523 a byte offset into an 'int'; it might overflow.
1524 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1526 * sound.c: Don't assume sizes fit in 'int'.
1527 (struct sound_device.period_size, alsa_period_size):
1528 Return EMACS_INT, not int.
1529 (struct sound_device.write, vox_write, alsa_write):
1530 Accept EMACS_INT, not int.
1531 (wav_play, au_play): Use EMACS_INT to store sizes and to
1532 record read return values.
1534 2011-04-15 Ben Key <bkey76@gmail.com>
1536 * keyboard.c (Qundefined): Don't declare static since it is used
1538 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1539 static since they are used in nsfont.m.
1541 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1543 * process.c (Qprocessp): Don't declare static.
1544 * lisp.h (Qprocessp): Declare again.
1546 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1548 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1550 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1552 Improve C-level modularity by making more things 'static'.
1554 Don't publish debugger-only interfaces to other modules.
1555 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1556 (verify_bytepos, count_markers): Move decls to the only modules
1558 * region-cache.h (pp_cache): Likewise.
1559 * window.h (check_all_windows): Likewise.
1560 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1562 * sysdep.c (croak): Now static, if
1563 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1564 * syssignal.h (croak): Declare only if not static.
1566 * alloc.c (refill_memory_reserve): Now static if
1567 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1568 * lisp.h (refill_memory_reserve): Declare only if not static.
1570 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1571 Define only if USE_LUCID.
1573 * xrdb.c (x_customization_string, x_rm_string): Now static.
1575 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1576 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1578 * xdisp.c (draw_row_with_mouse_face): Now static.
1579 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1581 * window.h (check_all_windows): Mark externally visible.
1583 * window.c (window_deletion_count): Now static.
1585 * undo.c: Make symbols static if they're not exported.
1586 (last_undo_buffer, last_boundary_position, pending_boundary):
1589 * textprop.c (interval_insert_behind_hooks): Now static.
1590 (interval_insert_in_front_hooks): Likewise.
1592 * term.c: Make symbols static if they're not exported.
1593 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1594 (max_frame_lines, tty_set_terminal_modes):
1595 (tty_reset_terminal_modes, tty_turn_off_highlight):
1596 (get_tty_terminal): Now static.
1597 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1598 * termhooks.h (term_mouse_moveto): Do not declare if
1600 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1601 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1603 * sysdep.c: Make symbols static if they're not exported.
1604 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1606 (sigprocmask_set, full_mask): Remove; unused.
1607 (wait_debugging): Mark as visible.
1608 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1609 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1611 * syntax.c (syntax_temp): Define only if !__GNUC__.
1613 * sound.c (current_sound_device, current_sound): Now static.
1615 * search.c (searchbufs, searchbuf_head): Now static.
1617 * scroll.c (scroll_cost): Remove; unused.
1618 * dispextern.h (scroll_cost): Remove decl.
1620 * region-cache.h (pp_cache): Mark as externally visible.
1622 * process.c: Make symbols static if they're not exported.
1623 (process_tick, update_tick, create_process, chan_process):
1624 (Vprocess_alist, proc_buffered_char, datagram_access):
1625 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1626 (deactivate_process): Mark defn as static, as well as decl.
1627 * lisp.h (create_process): Remove decl.
1628 * process.h (chan_process, Vprocess_alist): Remove decls.
1630 * print.c: Make symbols static if they're not exported.
1631 (print_depth, new_backquote_output, being_printed, print_buffer):
1632 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1633 (print_interval, print_number_index, initial_stderr_stream):
1635 * lisp.h (Fprinc): Remove decl.
1636 (debug_output_compilation_hack): Mark as externally visible.
1638 * sysdep.c (croak): Move decl from here to syssignal.h.
1639 * syssignal.h (croak): Put it here, so the API can be checked when
1640 'croak' is called from dissociate_if_controlling_tty.
1642 * minibuf.c: Make symbols static if they're not exported.
1643 (minibuf_save_list, choose_minibuf_frame): Now static.
1644 * lisp.h (choose_minibuf_frame): Remove decl.
1646 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1648 * lread.c: Make symbols static if they're not exported.
1649 (read_objects, initial_obarray, oblookup_last_bucket_number):
1651 (make_symbol): Remove; unused.
1652 * lisp.h (initial_obarray, make_symbol): Remove decls.
1654 * keyboard.c: Make symbols static if they're not exported.
1655 (single_kboard, recent_keys_index, total_keys, recent_keys):
1656 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1657 (this_single_command_key_start, echoing, last_auto_save):
1658 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1659 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1660 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1661 (Vlispy_mouse_stem, double_click_count):
1663 (force_auto_save_soon): Define only if SIGDANGER.
1664 (ignore_mouse_drag_p): Now static if
1665 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1666 (print_help): Remove; unused.
1667 (stop_character, last_timer_event): Mark as externally visible.
1668 * keyboard.h (ignore_mouse_drag_p): Declare only if
1669 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1670 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1671 * lisp.h (echoing): Remove decl.
1672 (force_auto_save_soon): Declare only if SIGDANGER.
1673 * xdisp.c (redisplay_window): Simplify code, to make it more
1674 obvious that ignore_mouse_drag_p is not accessed if !defined
1675 USE_GTK && !defined HAVE_NS.
1677 * intervals.c: Make symbols static if they're not exported.
1678 (merge_properties_sticky, merge_interval_right, delete_interval):
1680 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1682 * insdel.c: Make symbols static if they're not exported.
1683 However, leave prepare_to_modify_buffer alone. It's never
1684 called from outside this function, but that appears to be a bug.
1685 (combine_after_change_list, combine_after_change_buffer):
1686 (adjust_after_replace, signal_before_change): Now static.
1687 (adjust_after_replace_noundo): Remove; unused.
1688 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1689 (signal_before_change): Remove decls.
1691 * indent.c (val_compute_motion, val_vmotion): Now static.
1693 * image.c: Make symbols static if they're not exported.
1694 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1696 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1697 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1699 * fringe.c (standard_bitmaps): Now static.
1700 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1702 * frame.c: Make symbols static if they're not exported.
1703 (x_report_frame_params, make_terminal_frame): Now static.
1704 (get_frame_param): Now static, unless HAVE_NS.
1705 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1706 (x_get_resource_string): Remove; not used.
1707 * frame.h (make_terminal_frame, x_report_frame_params):
1708 (x_get_resource_string); Remove decls.
1709 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1710 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1712 * font.c, fontset.c: Make symbols static if they're not exported.
1713 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1714 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1715 * font.c (font_close_object): Now static.
1716 * font.h (font_close_object): Remove.
1717 * fontset.c (FONTSET_OBJLIST): Remove.
1718 (free_realized_fontset) #if-0 the body, which does nothing.
1719 (face_suitable_for_char_p): #if-0, as it's never called.
1720 * fontset.h (face_suitable_for_char_p): Remove decl.
1721 * xfaces.c (face_at_string_position):
1722 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1723 since 0 is always ASCII.
1725 * fns.c (weak_hash_tables): Now static.
1727 * fileio.c: Make symbols static if they're not exported.
1728 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1729 (Vwrite_region_annotation_buffers): Now static.
1731 * eval.c: Make symbols static if they're not exported.
1732 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1733 * lisp.h (backtrace_list): Remove decl.
1735 * emacs.c: Make symbols static if they're not exported.
1736 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1737 (fatal_error_code, fatal_error_signal_hook, standard_args):
1739 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1740 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1741 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1742 * lisp.h (fatal_error_signal_hook): Remove decl.
1743 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1745 * editfns.c: Move a (normally-unused) function to its only use.
1746 * editfns.c, lisp.h (get_operating_system_release): Remove.
1747 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1748 worth the hassle of breaking this out.
1750 * xterm.c: Make symbols static if they're not exported.
1751 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1752 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1753 (x_destroy_window, x_delete_display):
1755 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1756 (x_mouse_leave): Remove; unused.
1757 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1758 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1759 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1761 (x_mouse_leave): Declare only if WINDOWSNT.
1762 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1763 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1766 * ftxfont.c: Make symbols static if they're not exported.
1767 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1769 * font.h (ftxfont_driver): Likewise.
1771 * xfns.c: Make symbols static if they're not exported.
1772 (x_last_font_name, x_display_info_for_name):
1773 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1774 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1775 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1776 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1777 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1778 (last_show_tip_args): Now static.
1779 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1780 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1781 (x_screen_planes): Remove; unused.
1782 * dispextern.h (x_screen_planes): Remove decl.
1784 * dispnew.c: Make symbols static if they're not exported.
1785 * dispextern.h (redraw_garbaged_frames, scrolling):
1786 (increment_row_positions): Remove.
1787 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1788 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1790 (redraw_garbaged_frames): Remove; unused.
1792 * xfaces.c: Make symbols static if they're not exported.
1793 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1795 * xterm.h (defined_color): Remove decls.
1796 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1797 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1798 (menu_face_changed_default, defined_color, free_realized_face):
1799 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1800 (ascii_face_of_lisp_face): Remove; unused.
1802 * xdisp.c: Make symbols static if they're not exported.
1803 * dispextern.h (scratch_glyph_row, window_box_edges):
1804 (glyph_to_pixel_coords, set_cursor_from_row):
1805 (get_next_display_element, set_iterator_to_next):
1806 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1807 (show_mouse_face): Remove decls
1808 * frame.h (message_buf_print): Likewise.
1809 * lisp.h (pop_message, set_message, check_point_in_composition):
1811 * xterm.h (set_vertical_scroll_bar): Likewise.
1812 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1813 (message_buf_print, scratch_glyph_row, displayed_buffer):
1814 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1815 (get_next_display_element, show_mouse_face, window_box_edges):
1816 (frame_to_window_pixel_xy, check_point_in_composition):
1817 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1818 (glyph_to_pixel_coords): Remove; unused.
1820 * dired.c (file_name_completion): Now static.
1822 * dbusbind.c (xd_in_read_queued_messages): Now static.
1824 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1825 * data.c (circular_list_error): Remove.
1827 * commands.h (last_point_position, last_point_position_buffer):
1828 (last_point_position_window): Remove decls.
1829 * keyboard.c: Make these variables static.
1831 * coding.h (coding, code_convert_region, encode_coding_gap):
1833 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1834 (iso_code_class, detect_coding, code_convert_region): Now static.
1835 (encode_coding_gap): Remove; unused.
1837 * chartab.c (chartab_chars, chartab_bits): Now static.
1839 * charset.h (charset_iso_8859_1): Remove decl.
1840 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1843 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1844 * ccl.c (Vccl_program_table): Now static.
1845 (check_ccl_update): Remove; unused.
1847 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1848 * category.h: ... from here.
1849 * category.c (check_category_table, set_category_set): Now static.
1851 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1852 * lisp.h: Remove these decls.
1854 * buffer.c (buffer_count): Remove unused var.
1856 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1857 so that it's not optimized away.
1858 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1859 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1860 exported only to the debugger.
1862 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1863 * atimer.h (run_all_atimers): Remove; not exported.
1865 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1866 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1867 was inaccessible from Lisp.
1868 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1869 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1871 alloc.c: Import and export fewer symbols, and remove unused items.
1872 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1874 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1875 it's not optimized away by whole-program optimization.
1876 (message_enable_multibyte, free_misc): Remove.
1877 (catchlist, handlerlist, mark_backtrace):
1878 Declare only if BYTE_MARK_STACK.
1879 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1880 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1881 (message_enable_multibyte): Remove decl.
1882 (free_misc, interval_free_list, float_block, float_block_index):
1883 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1884 (cons_free_list, last_marked_index):
1886 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1887 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1888 (mark_backtrace): Define only if BYTE_MARK_STACK.
1889 * xdisp.c (message_enable_multibyte): Now static.
1891 Declare Lisp_Object Q* variables to be 'static' if not exported.
1892 This makes it easier for human readers (and static analyzers)
1893 to see whether these variables are used from other modules.
1894 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1895 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1896 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1897 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1898 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1899 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1900 * xmenu.c, xselect.c:
1901 Declare Q* vars static if they are not used in other modules.
1902 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1903 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1904 Remove decls of unexported vars.
1905 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1907 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1909 Make Emacs functions such as Fatom 'static' by default.
1910 This makes it easier for human readers (and static analyzers)
1911 to see whether these functions can be called from other modules.
1912 DEFUN now defines a static function. To make the function external
1913 so that it can be used in other C modules, use the new macro DEFUE.
1914 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1915 (Finit_image_library):
1916 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1917 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1918 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1919 Remove decls, since these functions are now static.
1920 (Funintern, Fget_internal_run_time): New decls, since these functions
1921 were already external.
1923 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1924 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1925 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1926 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1927 * keyboard.c, keymap.c, lread.c:
1928 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1929 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1930 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1931 Mark functions with DEFUE instead of DEFUN,
1932 if they are used in other modules.
1933 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1934 decls for now-static functions.
1935 * buffer.h (Fdelete_overlay): Remove decl.
1936 * callproc.c (Fgetenv_internal): Mark as internal.
1937 * composite.c (Fremove_list_of_text_properties): Remove decl.
1938 (Fcomposition_get_gstring): New forward static decl.
1939 * composite.h (Fcomposite_get_gstring): Remove decl.
1940 * dired.c (Ffile_attributes): New forward static decl.
1941 * doc.c (Fdocumntation_property): New forward static decl.
1942 * eval.c (Ffetch_bytecode): New forward static decl.
1943 (Funintern): Remove extern decl; now in .h file where it belongs.
1944 * fileio.c (Fmake_symbolic_link): New forward static decl.
1945 * image.c (Finit_image_library): New forward static decl.
1946 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1947 * intervals.h (Fprevious_property_change):
1948 (Fremove_list_of_text_properties): Remove decls.
1949 * keyboard.c (Fthis_command_keys): Remove decl.
1950 (Fcommand_execute): New forward static decl.
1951 * keymap.c (Flookup_key): New forward static decl.
1952 (Fcopy_keymap): Now static.
1953 * keymap.h (Flookup_key): Remove decl.
1954 * process.c (Fget_process): New forward static decl.
1955 (Fprocess_datagram_address): Mark as internal.
1956 * syntax.c (Fsyntax_table_p): New forward static decl.
1957 (skip_chars): Remove duplicate decl.
1958 * textprop.c (Fprevious_property_change): New forward static decl.
1959 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1961 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1962 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1964 * editfns.c (Fformat): Remove unreachable code.
1966 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1968 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1971 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1973 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1974 when at ZV. (Bug#8487)
1976 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1978 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1980 * keyboard.c (parse_tool_bar_item): Likewise.
1981 * sound.c (sound_cleanup, alsa_close): Likewise.
1982 * termcap.c (tgetent): Likewise.
1983 * xfns.c (x_default_font_parameter): Likewise.
1984 * xsettings.c (read_and_apply_settings): Likewise.
1986 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1987 (overrun_check_free): Protoize.
1989 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1991 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1992 since callers should never pass a negative size.
1993 Change the signature to match that of plain 'read' and 'write'; see
1994 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1995 * lisp.h: Update prototypes of emacs_write and emacs_read.
1997 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1999 * xdisp.c (redisplay_window): Don't try to determine the character
2000 position of the scroll margin if the window start point w->startp
2001 is outside the buffer's accessible region. (Bug#8468)
2003 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2005 Fix write-region and its subroutines for buffers > 2GB.
2006 * fileio.c (a_write, e_write): Modify declaration of arguments and
2007 local variables to support buffers larger than 2GB.
2008 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2010 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2011 argument, local variables, and return value.
2013 * lisp.h: Update prototypes of emacs_write and emacs_read.
2015 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2017 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2019 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2021 Fix more problems found by GCC 4.6.0's static checks.
2023 * xdisp.c (vmessage): Use a better test for character truncation.
2025 * charset.c (load_charset_map): <, not <=, for optimization,
2026 and to avoid potential problems with integer overflow.
2027 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2028 * casetab.c (set_identity, shuffle): Likewise.
2029 * editfns.c (Fformat): Likewise.
2030 * syntax.c (skip_chars): Likewise.
2032 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2033 This also lets GCC 4.6.0 generate slightly better loop code.
2035 * callint.c (Fcall_interactively): <, not <=, for optimization.
2036 (Fcall_interactively): Count the number of arguments produced,
2037 not the number of arguments given. This is simpler and lets GCC
2038 4.6.0 generate slightly better code.
2040 * ftfont.c: Distingish more carefully between FcChar8 and char.
2041 The previous code passed unsigned char * to a functions like
2042 strlen and xstrcasecmp that expect char *, which does not
2043 conform to the C standard.
2044 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2045 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2046 char * when the C standard requires it.
2048 * keyboard.c (read_char): Remove unused var.
2050 * eval.c: Port to Windows vsnprintf (Bug#8435).
2052 (SIZE_MAX): Define if the headers do not.
2053 (verror): Do not give up if vsnprintf returns a negative count.
2054 Instead, grow the buffer. This ports to Windows vsnprintf, which
2055 does not conform to C99. Problem reported by Eli Zaretskii.
2056 Also, simplify the allocation scheme, by avoiding the need for
2057 calling realloc, and removing the ALLOCATED variable.
2059 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2061 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2062 But keep the doprint source code for now, as we might revamp it
2063 and use it again (Bug#8435).
2064 * lisp.h (doprnt): Remove.
2065 * Makefile.in (base_obj): Remove doprnt.o.
2066 * deps.mk (doprnt.o): Remove.
2068 error: Print 32- and 64-bit integers portably (Bug#8435).
2069 Without this change, on typical 64-bit hosts error ("...%d...", N)
2070 was used to print both 32- and 64-bit integers N, which relied on
2072 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2074 * lisp.h (error, verror): Mark as printf-like functions.
2075 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2076 Report overflow in size calculations when allocating printf buffer.
2077 Do not truncate output string at its first null byte.
2078 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2079 Truncate the output at a character boundary, since vsnprintf does not
2081 * charset.c (check_iso_charset_parameter): Convert internal
2082 character to string before calling 'error', since %c now has the
2084 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2085 overflow when computing char to be passed to 'error'. Do not
2086 pass Lisp_Object to 'error'; pass the integer instead.
2087 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2088 formatted with plain %d.
2090 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2092 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2094 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2096 * xterm.c (x_catch_errors): Remove duplicate declaration.
2098 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2100 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2102 2011-04-10 Jim Meyering <meyering@redhat.com>
2104 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2105 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2106 return ssize_t not "int", and use size_t as the buffer length.
2107 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2108 * gnutls.h: Update declarations.
2109 * process.c (read_process_output): Use ssize_t, to match.
2110 (send_process): Likewise.
2112 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2114 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2116 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2118 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2119 Use unsigned char, to match FcChar8 type definition.
2121 * xterm.c (handle_one_xevent):
2122 * xmenu.c (create_and_show_popup_menu):
2123 * xselect.c (x_decline_selection_request)
2124 (x_reply_selection_request): Avoid type-punned deref of X events.
2126 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2128 Fix some uses of `int' instead of EMACS_INT.
2129 * search.c (string_match_1, fast_string_match)
2130 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2131 (scan_buffer, find_next_newline_no_quit)
2132 (find_before_next_newline, search_command, Freplace_match)
2133 (Fmatch_data): Make some `int' variables be EMACS_INT.
2135 * xdisp.c (display_count_lines): 3rd argument and return value now
2136 EMACS_INT. All callers changed.
2137 (pint2hrstr): Last argument is now EMACS_INT.
2139 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2140 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2141 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2142 (decode_coding_utf_16, decode_coding_emacs_mule)
2143 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2144 (decode_coding_ccl, decode_coding_charset)
2145 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2146 (decode_coding_iso_2022, decode_coding_emacs_mule)
2147 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2148 <char_offset, last_offset>: Declare EMACS_INT.
2149 (encode_coding_utf_8, encode_coding_utf_16)
2150 (encode_coding_emacs_mule, encode_invocation_designation)
2151 (encode_designation_at_bol, encode_coding_iso_2022)
2152 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2153 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2155 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2156 (encode_invocation_designation): Last argument P_NCHARS is now
2158 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2159 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2161 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2164 * ccl.c (Fccl_execute_on_string): Declare some variables
2167 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2169 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2171 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2173 * process.c (Fformat_network_address): Doc fix.
2175 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2177 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2179 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2181 * keyboard.c (read_char): Call Lisp function help-form-show,
2182 instead of using internal_with_output_to_temp_buffer.
2183 (Qhelp_form_show): New var.
2184 (syms_of_keyboard): Use DEFSYM macro.
2186 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2188 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2190 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2192 * process.c (Flist_processes): Remove to Lisp.
2193 (list_processes_1): Delete.
2195 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2197 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2199 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2201 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2203 Fix more problems found by GCC 4.6.0's static checks.
2205 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2207 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2209 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2211 * xdisp.c (vmessage): Mark as a printf-like function.
2213 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2215 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2217 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2218 printf-like functions.
2219 (tiff_load): Add casts to remove these marks before passing them
2220 to system-supplied API.
2222 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2224 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2225 This avoids several warnings with gcc -Wstrict-overflow.
2226 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2227 directly, rather than having caller test rule sign. This avoids
2228 some unnecessary tests.
2229 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2230 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2231 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2233 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2234 (xfont_open): Avoid unnecessary tests.
2236 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2238 * composite.h, composite.c (composition_gstring_put_cache):
2239 Use EMACS_INT, not int, for length.
2241 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2242 breaking out part of COMPOSITION_DECODE_RULE.
2243 (COMPOSITION_DECODE_RULE): Use it.
2244 * composite.c (get_composition_id): Remove unused local vars,
2245 by using the new macro.
2247 * textprop.c (set_text_properties_1): Change while to do-while,
2248 since the condition is always true at first.
2250 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2251 (interval_deletion_adjustment): Return unsigned value.
2254 * process.c (list_processes_1, create_pty, read_process_output):
2255 (exec_sentinel): Remove vars that were set but not used.
2256 (create_pty): Remove unnecessary "volatile"s.
2257 (Fnetwork_interface_info): Avoid possibility of int overflow.
2258 (read_process_output): Do adaptive read buffering even if carryover.
2259 (read_process_output): Simplify nbytes computation if buffered.
2261 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2263 * syntax.c (scan_words): Remove var that was set but not used.
2264 (update_syntax_table): Use unsigned instead of int.
2266 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2267 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2268 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2270 * print.c (print_error_message): Avoid int overflow.
2272 * font.c (font_list_entities): Redo for clarity,
2273 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2275 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2276 (font_score): Avoid potential overflow in diff calculation.
2278 * fns.c (substring_both): Remove var that is set but not used.
2279 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2281 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2283 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2284 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2285 can always succeed if overflow has undefined behavior.
2287 * search.c (boyer_moore, wordify): Remove vars set but not used.
2288 (wordify): Omit three unnecessary tests.
2290 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2291 All callers changed. This avoids the need for an unused var.
2293 * casefiddle.c (casify_region): Remove var that is set but not used.
2295 * dired.c (file_name_completion): Remove var that is set but not used.
2297 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2299 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2300 (Finsert_file_contents): Remove unnecessary code checking fd.
2302 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2303 Check for integer overflow on size calculations.
2305 * buffer.c (Fprevious_overlay_change): Remove var that is set
2308 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2309 Remove vars that are set but not used.
2310 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2311 (timer_check_2): Mark vars as initialized.
2313 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2315 * image.c (lookup_image): Remove var that is set but not used.
2316 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2318 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2319 that are set but not used.
2321 * xfns.c (make_invisible_cursor): Don't return garbage
2322 if XCreateBitmapFromData fails (Bug#8410).
2324 * xselect.c (x_get_local_selection, x_handle_property_notify):
2325 Remove vars that are set but not used.
2327 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2328 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2330 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2331 Remove var that is set but not used.
2332 (scroll_bar_windows_size): Now size_t, not int.
2333 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2336 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2337 (map_tty_color) [!defined MSDOS]: Likewise.
2339 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2341 * coding.c: Remove vars that are set but not used.
2342 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2343 All callers changed.
2344 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2345 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2346 (decode_coding_charset): Remove vars that are set but not used.
2348 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2349 that is set but not used.
2351 * print.c (print_object): Remove var that is set but not used.
2353 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2354 The gnulib version avoids calling malloc in the usual case,
2355 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2356 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2357 * filelock.c (current_lock_owner): Likewise.
2358 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2359 * sysdep.c: Include allocator.h, careadlinkat.h.
2360 (emacs_no_realloc_allocator): New static constant.
2361 (emacs_readlink): New function.
2362 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2363 ../lib/careadlinkat.h.
2365 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2367 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2368 first non-nil return value).
2370 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2372 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2373 if not defined (Bug#8403).
2375 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2377 * xdisp.c (display_count_lines): Remove parameter `start',
2378 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2379 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2380 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2381 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2382 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2383 and thereabouts. All callers changed.
2384 (get_per_char_metric): Remove parameter `f', unused since
2385 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2387 2011-04-02 Jim Meyering <meyering@redhat.com>
2389 do not dereference NULL upon failed strdup
2390 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2391 (ns_get_family): Likewise.
2393 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2395 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2397 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2399 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2402 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2404 Add lexical binding.
2406 * window.c (Ftemp_output_buffer_show): New fun.
2407 (Fsave_window_excursion):
2408 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2410 * lread.c (lisp_file_lexically_bound_p): New function.
2411 (Fload): Bind Qlexical_binding.
2412 (readevalloop): Remove `evalfun' arg.
2413 Bind Qinternal_interpreter_environment.
2414 (Feval_buffer): Bind Qlexical_binding.
2415 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2417 (syms_of_lread): Declare `lexical-binding'.
2419 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2421 * keyboard.c (eval_dyn): New fun.
2422 (menu_item_eval_property): Use it.
2424 * image.c (parse_image_spec): Use Ffunctionp.
2426 * fns.c (concat, mapcar1): Accept byte-code-functions.
2428 * eval.c (Fsetq): Handle lexical vars.
2429 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2430 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2431 (FletX, Flet): Obey lexical binding.
2432 (Fcommandp): Handle closures.
2433 (Feval): New `lexical' arg.
2434 (eval_sub): New function extracted from Feval. Use it almost
2435 everywhere where Feval was used. Look up vars in lexical env.
2437 (Ffunctionp): Move from subr.el.
2438 (Ffuncall): Handle closures.
2439 (apply_lambda): Remove `eval_flags'.
2440 (funcall_lambda): Handle closures and new byte-code-functions.
2441 (Fspecial_variable_p): New function.
2442 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2443 but without exporting it to Lisp.
2445 * doc.c (Fdocumentation, store_function_docstring):
2446 * data.c (Finteractive_form): Handle closures.
2448 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2451 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2453 (exec_byte_code): New function extracted from Fbyte_code to handle new
2454 calling convention for byte-code-functions. Add new byte-codes.
2456 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2458 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2460 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2462 * xdisp.c (redisplay_internal): Fix prototype.
2464 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2466 * xdisp.c (SCROLL_LIMIT): New macro.
2467 (try_scrolling): Use it when setting scroll_limit.
2468 Limit scrolling to 100 screen lines.
2469 (redisplay_window): Even when falling back on "recentering",
2470 position point in the window according to scroll-conservatively,
2471 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2473 (try_scrolling): When point is above the window, allow searching
2474 as far as scroll_max, or one screenful, to compute vertical
2475 distance from PT to the scroll margin position. This prevents
2476 try_scrolling from unnecessarily failing when
2477 scroll-conservatively is set to a value slightly larger than the
2478 window height. Clean up the case of PT below the margin at bottom
2479 of window: scroll_max can no longer be INT_MAX. When aggressive
2480 scrolling is in use, don't let point enter the opposite scroll
2481 margin as result of the scroll.
2482 (syms_of_xdisp) <scroll-conservatively>: Document the
2483 threshold of 100 lines for never-recentering scrolling.
2485 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2487 * dispextern.h (move_it_by_lines):
2488 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2489 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2490 (message_log_check_duplicate): Remove parameters `prev_bol' and
2491 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2492 (redisplay_internal): Remove parameter `preserve_echo_area',
2493 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2495 * indent.c (Fvertical_motion):
2496 * window.c (window_scroll_pixel_based, Frecenter):
2497 Don't pass `need_y_p' to `move_it_by_lines'.
2499 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2501 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2502 steal a few bits to be more compact.
2503 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2504 Remove unneeded casts.
2506 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2508 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2510 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2511 binding" message (bug#7967).
2513 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2515 Fix more problems found by GCC 4.6.0's static checks.
2517 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2518 Remove unused local var.
2520 * editfns.c (Fmessage_box): Remove unused local var.
2522 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2523 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2524 Omit unused local vars.
2525 * window.c (shrink_windows): Omit unused local var.
2526 * menu.c (digest_single_submenu): Omit unused local var.
2527 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2528 Omit unused local var.
2530 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2531 Don't assume string length fits in int.
2532 (keyremap_step, read_key_sequence): Use size_t for sizes.
2533 (read_key_sequence): Don't check last_real_key_start redundantly.
2535 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2536 instead of alloca (Bug#8344).
2538 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2539 (Fbacktrace_frame): Don't assume nframes fits in int.
2541 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2543 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2546 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2548 * cm.c (calccost): Turn while-do into do-while, for clarity.
2550 * keyboard.c (syms_of_keyboard): Use the same style as later
2551 in this function when indexing through an array. This also
2552 works around GCC bug 48267.
2554 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2556 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2558 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2559 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2561 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2562 This avoids undefined behavior on integer overflow, and is a bit
2563 more convenient anyway since it is compared to a size_t variable.
2565 Variadic C functions now count arguments with size_t, not int.
2566 This avoids an unnecessary limitation on 64-bit machines, which
2567 caused (substring ...) to crash on large vectors (Bug#8344).
2568 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2570 All variadic functions and their callers changed accordingly.
2571 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2572 * data.c (arith_driver, float_arith_driver): Likewise.
2573 * editfns.c (general_insert_function): Likewise.
2574 * eval.c (struct backtrace.nargs, interactive_p)
2575 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2576 (funcall_lambda, mark_backtrace): Likewise.
2577 * fns.c (concat): Likewise.
2578 * frame.c (x_set_frame_parameters): Likewise.
2579 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2580 0 if not found, not -1. All callers changed.
2582 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2583 (stack_copy_size): Now size_t, not int.
2584 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2586 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2588 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2589 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2590 All callers changed.
2592 * lisp.h (multibyte_char_to_unibyte):
2593 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2594 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2595 * character.h (CHAR_TO_BYTE8):
2596 * cmds.c (internal_self_insert):
2597 * editfns.c (general_insert_function):
2598 * keymap.c (push_key_description):
2599 * search.c (Freplace_match):
2600 * xdisp.c (message_dolog, set_message_1): All callers changed.
2602 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2604 * keyboard.c (safe_run_hook_funcall): New function.
2605 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2606 don't set the hook to nil, but remove the offending function instead.
2607 (Qcommand_hook_internal): Remove, unused.
2608 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2609 Vcommand_hook_internal.
2611 * eval.c (enum run_hooks_condition): Remove.
2612 (funcall_nil, funcall_not): New functions.
2613 (run_hook_with_args): Call each function through a `funcall' argument.
2614 Remove `cond' argument, now redundant.
2615 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2616 (Frun_hook_with_args_until_failure): Adjust accordingly.
2617 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2619 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2621 * dispextern.h (string_buffer_position): Remove declaration.
2623 * print.c (strout): Remove parameter `multibyte', unused since
2624 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2626 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2627 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2628 All callers changed.
2630 * w32.c (_wsa_errlist): Use braces for struct initializers.
2632 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2633 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2634 All callers changed.
2635 (string_buffer_position): Likewise. Also, make static (it's never
2636 used outside xdisp.c).
2637 (cursor_row_p): Remove parameter `w', unused since
2638 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2639 (decode_mode_spec): Remove parameter `precision', introduced during
2640 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2641 All callers changed.
2643 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2645 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2647 2011-03-27 Anders Lindgren <andlind@gmail.com>
2649 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2650 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2651 (ns_update_auto_hide_menu_bar): New functions.
2652 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2653 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2654 ns_constrain_all_frames.
2655 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2656 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2658 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2660 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2662 2011-03-27 Glenn Morris <rgm@gnu.org>
2664 * syssignal.h: Replace RETSIGTYPE with void.
2665 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2666 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2667 Replace SIGTYPE with void everywhere.
2668 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2669 * s/template.h (SIGTYPE): Remove commented out definition.
2671 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2673 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2674 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2676 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2678 * w32.c (read_unc_volume): Use parameter `henum', instead of
2679 global variable `wget_enum_handle'.
2681 * keymap.c (describe_vector): Remove parameters `indices' and
2682 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2683 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2685 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2687 * keyboard.c (timer_check): Remove parameter `do_it_now',
2688 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2689 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2690 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2692 * keyboard.c (read_char):
2693 * w32menu.c (w32_menu_display_help):
2694 * xmenu.c (show_help_event, menu_help_callback):
2695 Adjust calls to `show_help_echo'.
2697 * gtkutil.c (xg_maybe_add_timer):
2698 * keyboard.c (readable_events):
2699 * process.c (wait_reading_process_output):
2700 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2702 * insdel.c (adjust_markers_gap_motion):
2703 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2704 (gap_left, gap_right): Don't call it.
2706 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2708 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2709 incurred during fontification.
2711 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2713 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2714 (DEFVAR_PER_BUFFER): Don't pass it.
2716 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2717 (scrolling_window): Don't pass it.
2719 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2721 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2723 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2725 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2726 of variables specific to SELinux and computation of `encoded_absname'.
2728 * image.c (XPutPixel): Remove unused variable `height'.
2730 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2732 * unexw32.c (get_section_info): Remove unused variable `section'.
2734 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2735 (system_process_attributes): Remove unused variable `sess'.
2736 (sys_read): Remove unused variable `err'.
2738 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2739 (w32_wnd_proc): Remove unused variable `isdead'.
2740 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2741 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2742 (x_create_tip_frame): Remove unused variable `tem'.
2744 * w32inevt.c (w32_console_read_socket):
2745 Remove unused variable `no_events'.
2747 * w32term.c (x_draw_composite_glyph_string_foreground):
2748 Remove unused variable `width'.
2750 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2752 * w32term.c (x_set_glyph_string_clipping):
2753 Don't pass uninitialized region to CombineRgn.
2755 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2757 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2758 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2759 (Fx_close_connection): Remove unused variable `i'.
2761 * w32font.c (w32font_draw): Return number of glyphs.
2762 (w32font_open_internal): Remove unused variable `i'.
2763 (w32font_driver): Add missing initializer.
2765 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2766 (fill_in_menu): Remove unused variable `items_added'.
2768 * w32term.c (last_mouse_press_frame): Remove static global variable.
2769 (w32_clip_to_row): Remove unused variable `f'.
2770 (x_delete_terminal): Remove unused variable `i'.
2772 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2773 (NOTHING): Remove unused static global variable.
2774 (uniscribe_check_otf): Remove unused variable `table'.
2775 (uniscribe_font_driver): Add missing initializers.
2777 2011-03-23 Julien Danjou <julien@danjou.info>
2779 * term.c (Fsuspend_tty, Fresume_tty):
2780 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2781 * window.c (temp_output_buffer_show):
2782 * insdel.c (signal_before_change):
2783 * frame.c (Fhandle_switch_frame):
2784 * fileio.c (Fdo_auto_save):
2785 * emacs.c (Fkill_emacs):
2786 * editfns.c (save_excursion_restore):
2787 * cmds.c (internal_self_insert):
2788 * callint.c (Fcall_interactively):
2789 * buffer.c (Fkill_all_local_variables):
2790 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2792 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2793 unconditionnaly since it does the check itself.
2795 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2797 Fix more problems found by GCC 4.5.2's static checks.
2799 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2800 the first time through the loop, since we know p0 < p1 then.
2801 This also avoids a gcc -Wstrict-overflow warning.
2803 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2804 leading to a memory leak, possible in functions like
2805 load_charset_map_from_file that can allocate an unbounded number
2806 of objects (Bug#8318).
2808 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2809 that could (at least in theory) be that large.
2811 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2812 This is less likely to overflow, and avoids undefined behavior if
2813 overflow does occur. All callers changed. Use strtoul to scan
2814 for the unsigned long integer.
2815 (pint2hrstr): Simplify and tune code slightly.
2816 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2818 * scroll.c (do_scrolling): Work around GCC bug 48228.
2819 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2821 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2822 This also avoids a warning with gcc -Wstrict-overflow.
2823 (validate_x_resource_name): Simplify count usage.
2824 This also avoids a warning with gcc -Wstrict-overflow.
2826 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2829 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2831 * process.c (Fmake_network_process): Use socklen_t, not int,
2832 where POSIX says socklen_t is required in portable programs.
2833 This fixes a porting bug on hosts like 64-bit HP-UX, where
2834 socklen_t is wider than int (Bug#8277).
2835 (Fmake_network_process, server_accept_connection):
2836 (wait_reading_process_output, read_process_output):
2839 * process.c: Rename or move locals to avoid shadowing.
2840 (list_processes_1, Fmake_network_process):
2841 (read_process_output_error_handler, exec_sentinel_error_handler):
2842 Rename or move locals.
2843 (Fmake_network_process): Define label "retry_connect" only if needed.
2844 (Fnetwork_interface_info): Fix pointer signedness.
2845 (process_send_signal): Add cast to avoid pointer signedness problem.
2846 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2847 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2849 Make tparam.h and terminfo.c consistent.
2850 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2851 Include tparam.h instead, since it declares them.
2852 * cm.h (PC): Remove extern decl; tparam.h now does this.
2853 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2854 * terminfo.c: Include tparam.h, to check interfaces.
2855 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2856 (tparam): Adjust signature to match interface in tparam.h;
2857 this removes some undefined behavior. Check that outstring and len
2858 are zero, which they always are with Emacs.
2859 * tparam.h (PC, BC, UP): New extern decls.
2861 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2862 (xftfont_open): Rename locals to avoid shadowing.
2864 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2865 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2866 (OTF_TAG_SYM): Omit macro if not needed.
2867 (ftfont_list): Remove unused local.
2868 (get_adstyle_property, ftfont_pattern_entity):
2869 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2870 Rename locals to avoid shadowing.
2872 * xfont.c (xfont_list_family): Mark var as initialized.
2874 * xml.c (make_dom): Now static.
2876 * composite.c (composition_compute_stop_pos): Rename local to
2878 (composition_reseat_it): Remove unused locals.
2879 (find_automatic_composition, composition_adjust_point): Likewise.
2880 (composition_update_it): Mark var as initialized.
2881 (find_automatic_composition): Mark vars as initialized,
2882 with a FIXME (Bug#8290).
2884 character.h: Rename locals to avoid shadowing.
2885 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2886 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2887 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2888 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2891 * textprop.c (property_change_between_p): Remove; unused.
2893 * intervals.c (interval_start_pos): Now static.
2895 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2897 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2898 Rename locals to avoid shadowing.
2900 * sound.c (wav_play, au_play, Fplay_sound_internal):
2901 Fix pointer signedness.
2902 (alsa_choose_format): Remove unused local var.
2903 (wav_play): Initialize a variable to 0, to prevent undefined
2904 behavior (Bug#8278).
2906 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2908 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2911 clobbering (Bug#8298).
2912 * sysdep.c (sys_subshell): Likewise.
2913 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2915 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2916 This should get cleaned up, so that child_setup has the
2917 same signature on all platforms.
2919 * callproc.c (call_process_cleanup): Now static.
2920 (relocate_fd): Rename locals to avoid shadowing.
2922 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2924 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2925 not to be necessary, and produces flickering.
2927 2011-03-20 Glenn Morris <rgm@gnu.org>
2929 * config.in: Remove file.
2931 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2933 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2934 are now in src/globals.h.
2935 (syms_of_minibuf): Remove spurious & from previous change.
2937 2011-03-20 Leo <sdl.web@gmail.com>
2939 * minibuf.c (completing-read-function): New variable.
2940 (completing-read-default): Rename from completing-read.
2941 (completing-read): Call completing-read-function.
2943 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2945 * xfaces.c (Fx_load_color_file):
2946 Read color file from absolute filename (bug#8250).
2948 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2950 * makefile.w32-in: Update dependencies.
2952 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2954 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2956 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2958 Fix more problems found by GCC 4.5.2's static checks.
2960 * process.c (make_serial_process_unwind, send_process_trap):
2961 (sigchld_handler): Now static.
2963 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2964 That way, the code declares only the vars that it needs.
2965 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2966 * s/cygwin.h (PTY_ITERATION): Likewise.
2967 * s/darwin.h (PTY_ITERATION): Likewise.
2968 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2970 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2971 * process.c (allocate_pty): Don't declare stb unless it's needed.
2973 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2974 (CONSTANTLIM): Remove; unused.
2975 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2976 Define only if needed.
2978 * unexelf.c (unexec): Name an expression,
2979 to avoid gcc -Wbad-function-cast warning.
2980 Use a different way to cause a compilation error if anyone uses
2981 n rather than nn, a way that does not involve shadowing.
2982 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2984 * deps.mk (unexalpha.o): Remove; unused.
2986 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2987 * unexec.h: New file.
2988 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2989 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2991 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2992 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2993 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2994 Change as necessary to match prototype in unexec.h.
2996 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2998 (back_comment, skip_chars): Mark vars as initialized.
3000 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3001 Rename locals to avoid shadowing.
3003 * lread.c (read1): Rewrite so as not to use empty "else".
3004 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3006 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3008 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3009 warning when compiling print.c.
3011 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3012 instead of using an uninitialized var.
3013 (font_sort_entities): Mark var as initialized.
3015 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3017 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3018 pointers to constants.
3019 (font_parse_fcname): Remove unused vars.
3020 (font_delete_unmatched): Now static.
3021 (font_get_spec): Remove; unused.
3022 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3023 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3024 Rename or move locals to avoid shadowing.
3026 * fns.c (require_nesting_list, require_unwind): Now static.
3027 (Ffillarray): Rename locals to avoid shadowing.
3029 * floatfns.c (domain_error2): Define only if needed.
3030 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3032 * alloc.c (mark_backtrace): Move decl from here ...
3033 * lisp.h: ... to here, so that it can be checked.
3035 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3036 (Fdefvar): Rewrite so as not to use empty "else".
3037 (lisp_indirect_variable): Name an expression,
3038 to avoid gcc -Wbad-function-cast warning.
3039 (Fdefvar): Rename locals to avoid shadowing.
3041 * callint.c (quotify_arg, quotify_args): Now static.
3042 (Fcall_interactively): Rename locals to avoid shadowing.
3043 Use const pointer when appropriate.
3045 * lisp.h (get_system_name, get_operating_system_release):
3046 Move decls here, to check interfaces.
3047 * process.c (get_operating_system_release): Move decl to lisp.h.
3048 * xrdb.c (get_system_name): Likewise.
3049 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3050 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3051 some of which prompt warnings from gcc -Wbad-function-cast.
3052 (Fformat_time_string, Fencode_time, Finsert_char):
3053 (Ftranslate_region_internal, Fformat):
3054 Rename or remove local vars to avoid shadowing.
3055 (Ftranslate_region_internal): Mark var as initialized.
3057 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3060 * lisp.h (eassert): Check that the argument compiles, even if
3061 ENABLE_CHECKING is not defined.
3063 * data.c (Findirect_variable): Name an expression, to avoid
3064 gcc -Wbad-function-cast warning.
3065 (default_value, arithcompare, arith_driver, arith_error): Now static.
3066 (store_symval_forwarding): Rename local to avoid shadowing.
3067 (Fmake_variable_buffer_local, Fmake_local_variable):
3068 Mark variables as initialized.
3069 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3071 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3072 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3073 Rename locals to avoid shadowing.
3074 (mark_stack): Move local variables into the #ifdef region where
3076 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3077 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3079 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3080 (GC_STRING_CHARS): Remove; not used.
3081 (Fmemory_limit): Cast sbrk's returned value to char *.
3083 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3084 avoids undefined behavior in theory.
3086 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3088 Use functions, not macros, for up- and down-casing (Bug#8254).
3089 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3091 to use the following functions instead of these macros.
3092 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3093 EMACS_INT, since callers assume the returned value fits in int.
3094 (upcase1): Likewise, for UPCASE_TABLE.
3095 (uppercasep, lowercasep, upcase): New static inline functions.
3096 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3097 the race-condition problem in the old DOWNCASE.
3099 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3100 Rename locals to avoid shadowing.
3101 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3102 (regex_compile, re_search_2, re_match_2_internal):
3103 Remove unused local vars.
3104 (FREE_VAR): Rewrite so as not to use empty "else",
3105 which gcc can warn about.
3106 (regex_compile, re_match_2_internal): Mark locals as initialized.
3107 (RETALLOC_IF): Define only if needed.
3108 (WORDCHAR_P): Likewise. This one is never needed, but is used
3109 only in a comment talking about a compiler bug, so put inside
3110 the #if 0 of that comment.
3111 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3112 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3115 * search.c (boyer_moore): Rename locals to avoid shadowing.
3116 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3117 (PREV_CHAR_BOUNDARY): Likewise.
3119 * search.c (simple_search): Remove unused var.
3121 * dired.c (compile_pattern): Move decl from here ...
3122 * lisp.h: ... to here, so that it can be checked.
3123 (struct re_registers): New forward decl.
3125 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3127 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3129 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3130 Rename locals to avoid shadowing.
3131 (Fvertical_motion): Mark locals as initialized.
3133 * casefiddle.c (casify_object, casify_region): Now static.
3134 (casify_region): Mark local as initialized.
3136 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3138 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3139 New macros, so that the caller can use some names other than
3140 gcpro1, gcpro2, etc.
3141 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3143 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3144 argument, for consistency with GCPRO2_VAR, etc: it is now the
3145 prefix of the variable, not the variable itself. All uses
3147 * dired.c (directory_files_internal, file_name_completion):
3148 Rename locals to avoid shadowing.
3150 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3151 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3152 dired.c's scmp function, had undefined behavior.
3153 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3155 * buffer.h: ... to here, because these macros use current_buffer,
3156 and the new implementation with inline functions needs to have
3157 current_buffer in scope now, rather than later when the macros
3159 (downcase, upcase1): New static inline functions.
3160 (DOWNCASE, UPCASE1): Reimplement using these functions.
3161 This avoids undefined behavior in expressions like
3162 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3163 from race conditions in accessing the global variables
3164 case_temp1 and case_temp2.
3165 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3166 * lisp.h (case_temp1, case_temp2): Remove their decls.
3167 * character.h (ASCII_CHAR_P): Move from here ...
3168 * lisp.h: ... to here, so that the inline functions mentioned
3171 * dired.c (directory_files_internal_unwind): Now static.
3173 * fileio.c (file_name_as_directory, directory_file_name):
3174 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3176 (file_name_as_directory): Use const pointers when appropriate.
3177 (Fexpand_file_name): Likewise. In particular, newdir might
3178 point at constant storage, so make it a const pointer.
3179 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3180 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3182 (Fset_file_times, Finsert_file_contents, auto_save_error):
3183 Rename locals to avoid shadowing.
3185 * minibuf.c (choose_minibuf_frame_1): Now static.
3186 (Ftry_completion, Fall_completions): Rename or remove locals
3189 * marker.c (bytepos_to_charpos): Remove; unused.
3191 * lisp.h (verify_bytepos, count_markers): New decls,
3192 so that gcc does not warn that these functions aren't declared.
3194 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3195 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3196 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3197 (copy_text): Remove unused local var.
3199 * filelock.c (within_one_second): Now static.
3200 (lock_file_1): Rename local to avoid shadowing.
3202 * buffer.c (fix_overlays_before): Mark locals as initialized.
3203 (fix_start_end_in_overlays): Likewise. This function should be
3204 simplified by using pointers-to-pointers, but that's a different
3206 (switch_to_buffer_1): Now static.
3207 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3208 (report_overlay_modification): Rename locals to avoid shadowing.
3210 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3211 Fix pointer signedness issue.
3212 (sys_subshell): Mark local as volatile if checking for lint,
3213 to suppress a gcc -Wclobbered warning that does not seem to be right.
3214 (MAXPATHLEN): Define only if needed.
3216 * process.c (serial_open, serial_configure): Move decls from here ...
3217 * systty.h: ... to here, so that they can be checked.
3219 * fns.c (get_random, seed_random): Move extern decls from here ...
3220 * lisp.h: ... to here, so that they can be checked.
3222 * sysdep.c (reset_io): Now static.
3223 (wait_for_termination_signal): Remove; unused.
3225 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3226 (copy_keymap_item, append_key, push_text_char_description):
3228 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3229 (DENSE_TABLE_SIZE): Remove; unused.
3230 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3231 (describe_map_tree):
3232 Rename locals to avoid shadowing.
3234 * keyboard.c: Declare functions static if they are not used elsewhere.
3235 (echo_char, echo_dash, cmd_error, top_level_2):
3236 (poll_for_input, handle_async_input): Now static.
3237 (read_char, kbd_buffer_get_event, make_lispy_position):
3238 (make_lispy_event, make_lispy_movement, apply_modifiers):
3239 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3240 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3241 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3242 (read_key_sequence, read_char): Mark locals as initialized.
3243 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3245 * keyboard.h (make_ctrl_char): New decl.
3246 (mark_kboards): Move decl here ...
3247 * alloc.c (mark_kboards): ... from here.
3249 * lisp.h (force_auto_save_soon): New decl.
3251 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3252 (DEFINE_DUMMY_FUNCTION): New macro.
3253 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3255 (main): Add casts to avoid warnings
3256 if GCC considers string literals to be constants.
3258 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3260 * dbusbind.c: Pointer signedness fixes.
3261 (xd_signature, xd_append_arg, xd_initialize):
3262 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3263 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3264 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3265 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3267 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3268 if GCC considers string literals to be constants.
3269 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3271 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3273 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3274 (print_preprocess, print_object): New macro to fix last change.
3276 * print.c (print_preprocess): Don't forget font objects.
3278 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3280 * emacs.c (USAGE3): Doc fixes.
3282 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3284 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3287 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3289 * lisp.h (VWindow_system, Qfile_name_history):
3290 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3291 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3292 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3294 * w32select.c: Don't #include "keyboard.h".
3295 (run_protected): Add extern declaration for waiting_for_input.
3297 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3298 * w32console.c (detect_input_pending, read_input_pending)
3299 (encode_terminal_code):
3300 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3301 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3302 (w32_system_caret_y, Qfile_name_history):
3303 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3304 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3305 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3306 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3307 * w32proc.c (Qlocal, report_file_error):
3308 * w32term.c (Vwindow_system, updating_frame):
3309 * w32uniscribe.c (initialized, uniscribe_font_driver):
3310 Remove unneeded extern declarations.
3312 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3314 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3316 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3318 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3319 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3320 These macros can no longer be used for assignment.
3322 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3323 Assign struct members directly, instead of using BUF_BEGV etc.
3324 (record_buffer_markers, fetch_buffer_markers): New functions for
3325 recording and fetching special buffer markers.
3326 (set_buffer_internal_1, set_buffer_temp): Use them.
3328 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3330 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3332 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3333 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3335 * xdisp.c (hscroll_window_tree):
3336 (reconsider_clip_changes): Use PT instead of BUF_PT.
3338 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3340 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3341 $(EMACS_ROOT)/lib/intprops.h.
3343 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3345 Fix more problems found by GCC 4.5.2's static checks.
3347 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3348 to unsigned char * to avoid compiler diagnostic.
3349 (xg_free_frame_widgets): Make it clear that a local variable is
3350 needed only if USE_GTK_TOOLTIP.
3351 (gdk_window_get_screen): Make it clear that this macro is needed
3352 only if USE_GTK_TOOLTIP.
3353 (int_gtk_range_get_value): New function, which avoids a diagnostic
3354 from gcc -Wbad-function-cast.
3355 (xg_set_toolkit_scroll_bar_thumb): Use it.
3356 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3357 diagnostic from gcc -Wbad-function-cast.
3358 (get_utf8_string, xg_get_file_with_chooser):
3359 Rename locals to avoid shadowing.
3360 (create_dialog): Move locals to avoid shadowing.
3362 * xgselect.c (xg_select): Remove unused var.
3364 * image.c (four_corners_best): Mark locals as initialized.
3365 (gif_load): Initialize transparent_p to zero (Bug#8238).
3366 Mark another local as initialized.
3367 (my_png_error, my_error_exit): Mark with NO_RETURN.
3369 * image.c (clear_image_cache): Now static.
3370 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3371 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3372 (x_edge_detection): Remove unnecessary cast that
3373 gcc -Wbad-function-cast diagnoses.
3374 (gif_load): Fix pointer signedness.
3375 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3376 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3378 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3380 Improve quality of tests for time stamp overflow.
3381 For example, without this patch (encode-time 0 0 0 1 1
3382 1152921504606846976) returns the obviously-bogus value (-948597
3383 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3384 reports time overflow. See
3385 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3386 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3387 * editfns.c: Include limits.h and intprops.h.
3388 (TIME_T_MIN, TIME_T_MAX): New macros.
3389 (time_overflow): Move earlier, to before first use.
3390 (hi_time, lo_time): New functions, for an accurate test for
3392 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3393 (Fget_internal_run_time): Don't assume time_t fits in int.
3394 (make_time): Use list2 instead of Fcons twice.
3395 (Fdecode_time): More accurate test for out-of-range times.
3396 (check_tm_member): New function.
3397 (Fencode_time): Use it, to test for out-of-range times.
3398 (lisp_time_argument): Don't rely on undefined left-shift and
3399 right-shift behavior when checking for time stamp overflow.
3401 * editfns.c (time_overflow): New function, refactoring common code.
3402 (Fformat_time_string, Fdecode_time, Fencode_time):
3403 (Fcurrent_time_string): Use it.
3405 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3406 * dired.c (make_time): Move to ...
3407 * editfns.c (make_time): ... here.
3408 * systime.h: Note the move.
3410 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3412 * fringe.c (update_window_fringes): Remove unused variables.
3414 * unexmacosx.c (copy_data_segment): Also copy __got section.
3417 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3419 * termcap.c [MSDOS]: Include "msdos.h".
3420 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3421 Constify `char *' arguments and their references according to
3422 prototypes in tparam.h.
3424 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3426 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3427 Adapt all references accordingly.
3429 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3431 2011-03-11 Tom Tromey <tromey@redhat.com>
3433 * buffer.c (syms_of_buffer): Remove obsolete comment.
3435 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3437 * termhooks.h (encode_terminal_code): Declare prototype.
3439 * msdos.c (encode_terminal_code): Don't declare prototype.
3441 * term.c (encode_terminal_code): Now external again, used by
3442 w32console.c and msdos.c.
3444 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3445 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3447 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3449 Fix some minor problems found by GCC 4.5.2's static checks.
3451 * fringe.c (update_window_fringes): Mark locals as initialized
3453 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3455 * alloc.c (mark_fringe_data): Move decl from here ...
3456 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3457 to check its interface.
3458 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3460 * fontset.c (free_realized_fontset): Now static.
3461 (Fset_fontset_font): Rename local to avoid shadowing.
3462 (fontset_font): Mark local as initialized.
3463 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3465 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3467 * xselect.c (x_disown_buffer_selections): Remove; not used.
3468 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3469 (x_own_selection, Fx_disown_selection_internal): Rename locals
3471 (x_handle_dnd_message): Remove local to avoid shadowing.
3473 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3474 so that the caller can use some name other than gcpro1.
3475 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3476 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3477 (Fx_backspace_delete_keys_p):
3478 Use them to avoid shadowing, and rename vars to avoid shadowing.
3479 (x_decode_color, x_set_name, x_window): Now static.
3480 (Fx_create_frame): Add braces to silence GCC warning.
3481 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3482 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3483 Remove unused locals.
3484 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3485 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3486 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3489 * xterm.h (x_mouse_leave): New decl.
3491 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3492 Remove unused functions.
3493 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3494 (x_calc_absolute_position): Now static.
3495 (XTread_socket): Don't define label "out" unless it's used.
3496 Don't declare local "event" unless it's used.
3497 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3498 unless they are used.
3499 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3500 (x_fatal_error_signal): Remove; not used.
3501 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3502 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3503 (x_error_catcher, x_connection_closed, x_error_handler):
3504 (x_error_quitter, xembed_send_message, x_iconify_frame):
3505 (my_log_handler): Rename locals to avoid shadowing.
3506 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3507 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3509 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3510 Rename or move locals to avoid shadowing.
3511 (tty_defined_color, merge_face_heights): Now static.
3512 (free_realized_faces_for_fontset): Remove; not used.
3513 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3514 does not deduce is never used uninitialized.
3515 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3516 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3518 * terminal.c (store_terminal_param): Now static.
3520 * xmenu.c (menu_highlight_callback): Now static.
3521 (set_frame_menubar): Remove unused local.
3522 (xmenu_show): Rename parameter to avoid shadowing.
3523 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3524 since they might point to immutable storage.
3525 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3526 since it's unused otherwise.
3528 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3529 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3530 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3531 avoids a gcc -Wuninitialized diagnostic.
3532 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3533 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3534 does not deduce are never used uninitialized.
3536 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3538 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3539 * window.c (window_loop, size_window):
3540 (run_window_configuration_change_hook, enlarge_window): Likewise.
3542 * window.c (display_buffer): Now static.
3543 (size_window): Mark variables that gcc -Wuninitialized
3544 does not deduce are never used uninitialized.
3545 * window.h (check_all_windows): New decl, to forestall
3546 gcc -Wmissing-prototypes diagnostic.
3547 * dispextern.h (bidi_dump_cached_states): Likewise.
3549 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3551 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3553 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3554 and to avoid gcc -Wuninitialized warning.
3555 (load_charset_map): Mark variables that gcc -Wuninitialized
3556 does not deduce are never used uninitialized.
3557 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3559 * coding.c (coding_set_source, coding_set_destination):
3560 Use "else { /* comment */ }" rather than "else /* comment */;"
3561 for clarity, and to avoid gcc -Wempty-body warning.
3562 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3563 a block, when the outer 'i' will do.
3564 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3565 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3566 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3567 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3568 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3569 Rename locals to avoid shadowing.
3570 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3571 * coding.c (emacs_mule_char, encode_invocation_designation):
3572 Now static, since they're not used elsewhere.
3573 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3574 (decode_coding_object, encode_coding_object, detect_coding_system):
3575 (decode_coding_emacs_mule): Mark variables that gcc
3576 -Wuninitialized does not deduce are never used uninitialized.
3577 (detect_coding_iso_2022): Initialize a local variable that might
3578 be used uninitialized. Leave a FIXME because it's not clear that
3579 this initialization is needed. (Bug#8211)
3580 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3581 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3582 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3583 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3584 Remove unused macros.
3586 * category.c (hash_get_category_set): Remove unused local var.
3587 (copy_category_table): Now static, since it's not used elsewhere.
3588 * character.c (string_count_byte8): Likewise.
3590 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3591 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3593 * chartab.c (copy_sub_char_table): Now static, since it's not used
3595 (sub_char_table_ref_and_range, char_table_ref_and_range):
3596 Rename locals to avoid shadowing.
3597 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3599 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3600 (BIDI_BOB): Remove unused macro.
3602 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3603 deduce are never used uninitialized.
3604 * term.c (encode_terminal_code): Likewise.
3606 * term.c (encode_terminal_code): Now static. Remove unused local.
3608 * tparam.h: New file.
3609 * term.c, tparam.h: Include it.
3610 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3611 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3612 Move these decls to tparam.h, and make them agree with what
3613 is actually in tparam.c. The previous trick of using incompatible
3614 decls in different modules does not conform to the C standard.
3615 All callers of tparam changed to use tparam's actual API.
3616 * tparam.c (tparam1, tparam, tgoto):
3617 Use const pointers where appropriate.
3619 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3620 * cm.h (struct cm): Likewise.
3621 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3622 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3623 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3624 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3625 (turn_on_face, init_tty): Likewise.
3626 * termchar.h (struct tty_display_info): Likewise.
3628 * term.c (term_mouse_position): Rename local to avoid shadowing.
3630 * alloc.c (mark_ttys): Move decl from here ...
3631 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3633 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3635 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3637 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3639 * search.c (compile_pattern_1): Remove argument regp, unused since
3640 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3641 (compile_pattern): Don't pass it.
3643 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3645 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3646 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3648 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3650 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3652 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3653 gdk_window_get_screen, gdk_window_get_geometry,
3654 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3655 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3656 (xg_get_pixbuf_from_pixmap): New function.
3657 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3658 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3659 Call xg_get_pixbuf_from_pixmap instead of
3660 gdk_pixbuf_get_from_drawable.
3661 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3662 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3663 (xg_check_special_colors): Use GtkStyleContext and its functions
3665 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3666 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3667 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3668 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3669 Call gtk_widget_get_preferred_size.
3670 (xg_frame_resized): gdk_window_get_geometry only takes 5
3672 (xg_win_to_widget, xg_event_is_for_menubar):
3673 Call gdk_x11_window_lookup_for_display.
3674 (xg_set_widget_bg): New function.
3675 (delete_cb): New function.
3676 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3677 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3678 (xg_set_background_color): Call xg_set_widget_bg.
3679 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3680 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3681 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3682 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3684 (update_frame_tool_bar): Call gtk_widget_hide.
3685 (xg_initialize): Use GDK_KEY_g.
3687 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3689 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3691 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3692 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3693 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3695 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3697 * w32xfns.c (select_palette): Check success of RealizePalette against
3698 GDI_ERROR, not zero.
3700 See ChangeLog.11 for earlier changes.
3706 Copyright (C) 2011 Free Software Foundation, Inc.
3708 This file is part of GNU Emacs.
3710 GNU Emacs is free software: you can redistribute it and/or modify
3711 it under the terms of the GNU General Public License as published by
3712 the Free Software Foundation, either version 3 of the License, or
3713 (at your option) any later version.
3715 GNU Emacs is distributed in the hope that it will be useful,
3716 but WITHOUT ANY WARRANTY; without even the implied warranty of
3717 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3718 GNU General Public License for more details.
3720 You should have received a copy of the GNU General Public License
3721 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.