* doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
[bpt/emacs.git] / src / ChangeLog
1 2011-04-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4
5 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6 to match comment at start of function. This also removes a
7 GCC warning about overflow in a 32+64-bit port.
8
9 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10
11 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12 Reported by Stefan Monnier in
13 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
14 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
15 SYMBOLP-guarded XSYMBOL, not XPNTR.
16
17 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
18 (EMACS_UINTPTR): Likewise, with uintptr_t.
19
20 * lisp.h: Prefer 64-bit EMACS_INT if available.
21 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
22 on 32-bit hosts that have 64-bit int, so that they can access
23 large files.
24
25 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
26
27 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
28 This removes an assumption that EMACS_INT and long are the same
29 width as pointers. The assumption is true for Emacs porting targets
30 now, but we want to make other targets possible.
31 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
32 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
33 In the rest of the code, change types of integers that hold casted
34 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
35 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
36 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
37 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
38 No need to cast type when ORing.
39 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
40 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
41 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
42 assume EMACS_INT is the same width as char *.
43 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
44 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
45 Remove no-longer-needed casts.
46 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
47 (xg_tool_bar_help_callback, xg_make_tool_item):
48 Use EMACS_INTPTR to hold an integer
49 that will be cast to void *; this can avoid a GCC warning
50 if EMACS_INT is not the same width as void *.
51 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
52 * xdisp.c (display_echo_area_1, resize_mini_window_1):
53 (current_message_1, set_message_1):
54 Use a local to convert to proper width without a cast.
55 * xmenu.c (dialog_selection_callback): Likewise.
56
57 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
58 Also, don't assume VALBITS / RAND_BITS is less than 5,
59 and don't rely on undefined behavior when shifting a 1 left into
60 the sign bit.
61 * lisp.h (get_random): Change signature to match.
62
63 * lread.c (hash_string): Use size_t, not int, for hash computation.
64 Normally we prefer signed values; but hashing is special, because
65 it's better to use unsigned division on hash table sizes so that
66 the remainder is nonnegative. Also, size_t is the natural width
67 for hashing into memory. The previous code used 'int', which doesn't
68 retain enough info to hash well into very large tables.
69 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
70
71 * dbusbind.c: Don't possibly lose pointer info when converting.
72 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
73 Use XPNTR rather than XHASH, so that the high-order bits of
74 the pointer aren't lost when converting through void *.
75
76 * eval.c (Fautoload): Don't double-shift a pointer.
77
78 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
79
80 2011-04-30 Eli Zaretskii <eliz@gnu.org>
81
82 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
83 rather than `XVECTOR (FOO)->size'.
84
85 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
86 inttypes.h, as a gnulib replacement is used if it not available in
87 system headers.
88
89 2011-04-21 Eli Zaretskii <eliz@gnu.org>
90
91 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
92 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
93 of MOST_POSITIVE_FIXNUM. (Bug#8528)
94
95 * coding.c (coding_alloc_by_realloc): Error out if destination
96 will grow beyond MOST_POSITIVE_FIXNUM.
97 (decode_coding_emacs_mule): Abort if there isn't enough place in
98 charbuf for the composition carryover bytes. Reserve an extra
99 space for up to 2 characters produced in a loop.
100 (decode_coding_iso_2022): Abort if there isn't enough place in
101 charbuf for the composition carryover bytes.
102
103 2011-04-21 Eli Zaretskii <eliz@gnu.org>
104
105 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
106 aborting when %lld or %lll format is passed.
107 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
108 %llo or %llx format is passed. (Bug#8545)
109
110 * window.c (window_scroll_line_based): Use a marker instead of
111 simple variables to record original value of point. (Bug#7952)
112
113 * doprnt.c (doprnt): Fix the case where a multibyte sequence
114 produced by %s or %c overflows available buffer space. (Bug#8545)
115
116 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
117
118 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
119 (SIZE_MAX): Move defn after all includes, as they might #define it.
120
121 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
122
123 * w32.c (init_environment): Warn about defaulting HOME to C:\.
124
125 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
126
127 * keyboard.c (Qdelayed_warnings_hook): Define.
128 (command_loop_1): Run `delayed-warnings-hook'
129 if Vdelayed_warnings_list is non-nil.
130 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
131 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
132
133 2011-04-28 Eli Zaretskii <eliz@gnu.org>
134
135 * doprnt.c (doprnt): Don't return value smaller than the buffer
136 size if the message was truncated. (Bug#8545).
137
138 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
139
140 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
141 (Fx_window_property): #if-0 the whole functions, not just the bodies.
142
143 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
144
145 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
146
147 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
148
149 * makefile.w32-in: Update dependencies.
150
151 2011-04-27 Eli Zaretskii <eliz@gnu.org>
152
153 Improve `doprnt' and its usage. (Bug#8545)
154 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
155 `format_end'. Remove support for %l as a conversion specifier.
156 Don't use xrealloc. Improve diagnostics when the %l size modifier
157 is used. Update the commentary.
158
159 * eval.c (verror): Simplify calculation of size_t.
160
161 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
162 messages.
163
164 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
165
166 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
167 change.
168
169 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
170
171 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
172 This makes this file independent of the recent pseudovector change.
173
174 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
175
176 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
177
178 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
179 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
180 Remove unused local.
181 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
182
183 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
184 GCC 4.6.0 optimizes based on type-based alias analysis. For
185 example, if b is of type struct buffer * and v of type struct
186 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
187 != &v->size, and therefore "v->size = 1; b->size = 2; return
188 v->size;" must therefore return 1. This assumption is incorrect
189 for Emacs, since it type-puns struct Lisp_Vector * with many other
190 types. To fix this problem, this patch adds a new type struct
191 vectorlike_header that documents the constraints on layout of vectors
192 and pseudovectors, and helps optimizing compilers not get fooled
193 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
194 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
195 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
196 the size member.
197 (XSETPVECTYPE): Rewrite in terms of new macro.
198 (XSETPVECTYPESIZE): New macro, specifying both type and size.
199 This is a bit clearer, and further avoids the possibility of
200 undesirable aliasing.
201 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
202 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
203 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
204 since Lisp_Subr is a special case (no "next" field).
205 (ASIZE): Now uses header.size rather than size. All
206 previous uses of XVECTOR (foo)->size replaced to use this macro,
207 to avoid the hassle of writing XVECTOR (foo)->header.size.
208 (struct vectorlike_header): New type.
209 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
210 object, to help avoid aliasing.
211 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
212 (SUBRP): Likewise, since Lisp_Subr is a special case.
213 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
214 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
215 (struct Lisp_Hash_Table): Combine first two members into a single
216 struct vectorlike_header member. All uses of "size" and "next" members
217 changed to be "header.size" and "header.next".
218 * buffer.h (struct buffer): Likewise.
219 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
220 * frame.h (struct frame): Likewise.
221 * process.h (struct Lisp_Process): Likewise.
222 * termhooks.h (struct terminal): Likewise.
223 * window.c (struct save_window_data, struct saved_window): Likewise.
224 * window.h (struct window): Likewise.
225 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
226 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
227 * buffer.c (init_buffer_once): Likewise.
228 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
229 special case.
230 * process.c (Fformat_network_address): Use local var for size,
231 for brevity.
232
233 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
234
235 Make the Lisp reader and string-to-float more consistent (Bug#8525)
236 * data.c (atof): Remove decl; no longer used or needed.
237 (digit_to_number): Move to lread.c.
238 (Fstring_to_number): Use new string_to_number function, to be
239 consistent with how the Lisp reader treats infinities and NaNs.
240 Do not assume that floating-point numbers represent EMACS_INT
241 without losing information; this is not true on most 64-bit hosts.
242 Avoid double-rounding errors, by insisting on integers when
243 parsing non-base-10 numbers, as the documentation specifies.
244 * lisp.h (string_to_number): New decl, replacing ...
245 (isfloat_string): Remove.
246 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
247 (read1): Do not accept +. and -. as integers; this
248 appears to have been a coding error. Similarly, do not accept
249 strings like +-1e0 as floating point numbers. Do not report
250 overflow for integer overflows unless the base is not 10 which
251 means we have no simple and reliable way to continue.
252 Break out the floating-point parsing into a new
253 function string_to_number, so that Fstring_to_number parses
254 floating point numbers consistently with the Lisp reader.
255 (digit_to_number): Moved here from data.c. Make it static inline.
256 (E_CHAR, EXP_INT): Remove, replacing with ...
257 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
258 (string_to_number): New function, replacing isfloat_string.
259 This function checks for valid syntax and produces the resulting
260 Lisp float number too. Rework it so that string-to-number
261 no longer mishandles examples like "1.0e+". Use strtoumax,
262 so that overflow for non-base-10 numbers is reported only when
263 there's no portable and simple way to convert to floating point.
264
265 * textprop.c (set_text_properties_1): Rewrite for clarity,
266 and to avoid GCC warning about integer overflow.
267
268 * intervals.h (struct interval): Use EMACS_INT for members
269 where EMACS_UINT might cause problems. See
270 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
271 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
272 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
273 All uses changed.
274 (offset_intervals): Tell GCC not to worry about length overflow
275 when negating a negative length.
276
277 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
278 (overrun_check_free): Likewise.
279
280 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
281 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
282 word size.
283
284 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
285 (gnutls_make_error): Rename local to avoid shadowing.
286 (gnutls_emacs_global_deinit): ifdef out; not used.
287 (Fgnutls_boot): Use const for pointer to readonly storage.
288 Comment out unused local. Fix pointer signedness problems.
289
290 * lread.c (openp): Don't stuff size_t into an 'int'.
291 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
292 about possible signed overflow.
293
294 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
295 (GDK_KEY_g): Don't define if already defined.
296 (xg_prepare_tooltip): Avoid pointer signedness problem.
297 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
298
299 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
300 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
301
302 * xfns.c (Fx_window_property): Simplify a bit,
303 to make a bit faster and to avoid GCC 4.6.0 warning.
304 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
305
306 * fns.c (internal_equal): Don't assume size_t fits in int.
307
308 * alloc.c (compact_small_strings): Tighten assertion a little.
309
310 Replace pEd with more-general pI, and fix some printf arg casts.
311 * lisp.h (pI): New macro, generalizing old pEd macro to other
312 conversion specifiers. For example, use "...%"pI"d..." rather
313 than "...%"pEd"...".
314 (pEd): Remove. All uses replaced with similar uses of pI.
315 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
316 * alloc.c (check_pure_size): Don't overflow by converting size to int.
317 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
318 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
319 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
320 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
321 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
322 64-bit hosts.
323 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
324 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
325 * print.c (safe_debug_print, print_object): Likewise.
326 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
327 to int.
328 Use pI instead of if-then-else-abort. Use %p to avoid casts,
329 avoiding the 0 flag, which is not portable.
330 * process.c (Fmake_network_process): Use pI to avoid cast.
331 * region-cache.c (pp_cache): Likewise.
332 * xdisp.c (decode_mode_spec): Likewise.
333 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
334 behavior on 64-bit hosts with printf arg.
335 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
336 (x_stop_queuing_selection_requests): Likewise.
337 (x_get_window_property): Don't truncate byte count to an 'int'
338 when tracing.
339
340 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
341 here, since it parses constructs like leading '-' and spaces,
342 which are not wanted; and it overflows with large numbers.
343 Instead, simply match F[0-9]+, which is what is wanted anyway.
344
345 * alloc.c: Remove unportable assumptions about struct layout.
346 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
347 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
348 (allocate_vectorlike, make_pure_vector): Use the new macros,
349 plus offsetof, to remove unportable assumptions about struct layout.
350 These assumptions hold on all porting targets that I know of, but
351 they are not guaranteed, they're easy to remove, and removing them
352 makes further changes easier.
353
354 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
355 This doesn't fix a bug but makes the code clearer.
356 (string_overrun_cookie): Now const. Use initializers that
357 don't formally overflow signed char, to avoid warnings.
358 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
359 can cause Emacs to crash when string overrun checking is enabled.
360 (allocate_buffer): Don't assume sizeof (struct buffer) is a
361 multiple of sizeof (EMACS_INT); it need not be, if
362 alignof(EMACS_INT) < sizeof (EMACS_INT).
363 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
364
365 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
366
367 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
368
369 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
370
371 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
372 supposed to be handshaking. (Bug#8556)
373 Reported by Paul Eggert <eggert@cs.ucla.edu>.
374
375 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
376
377 * lisp.h (Qdebug): List symbol.
378 * eval.c (Qdebug): Restore global linkage.
379 * keyboard.c (debug-on-event): New variable.
380 (handle_user_signal): Break into debugger when debug-on-event
381 matches the current signal symbol.
382
383 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
384
385 * alloc.c (check_sblock, check_string_bytes)
386 (check_string_free_list): Convert to standard C.
387
388 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
389
390 * w32.c (emacs_gnutls_push): Fix typo.
391
392 2011-04-25 Eli Zaretskii <eliz@gnu.org>
393
394 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
395 "cast to pointer from integer of different size".
396
397 Improve doprnt and its use in verror. (Bug#8545)
398 * doprnt.c (doprnt): Document the set of format control sequences
399 supported by the function. Use SAFE_ALLOCA instead of always
400 using `alloca'.
401
402 * eval.c (verror): Don't limit the buffer size at size_max-1, that
403 is one byte too soon. Don't use xrealloc; instead xfree and
404 xmalloc anew.
405
406 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
407
408 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
409 callbacks stage.
410
411 * gnutls.c: Renamed global_initialized to
412 gnutls_global_initialized. Added internals for the
413 :verify-hostname-error, :verify-error, and :verify-flags
414 parameters of `gnutls-boot' and documented those parameters in the
415 docstring. Start callback support.
416 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
417 unless a fatal error occured. Call gnutls_alert_send_appropriate
418 on error. Return error code.
419 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
420 (emacs_gnutls_read): Likewise.
421 (Fgnutls_boot): Return handshake error code.
422 (emacs_gnutls_handle_error): New function.
423 (wsaerror_to_errno): Likewise.
424
425 * w32.h (emacs_gnutls_pull): Add prototype.
426 (emacs_gnutls_push): Likewise.
427
428 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
429 (emacs_gnutls_push): Likewise.
430
431 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
432
433 * process.c (wait_reading_process_output): Check if GnuTLS
434 buffered some data internally if no FDs are set for TLS
435 connections.
436
437 * makefile.w32-in (OBJ2): Add gnutls.$(O).
438 (LIBS): Link to USER_LIBS.
439 ($(BLD)/gnutls.$(0)): New target.
440
441 2011-04-24 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (handle_single_display_spec): Rename the
444 display_replaced_before_p argument into display_replaced_p, to
445 make it consistent with the commentary. Fix typos in the
446 commentary.
447
448 * textprop.c (syms_of_textprop): Remove dead code.
449 (copy_text_properties): Delete obsolete commentary about an
450 interface that was deleted long ago. Fix typos in the description
451 of arguments.
452
453 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
454 to changes in oldXMenu/XMenu.h from 2011-04-16.
455 <menu_help_message, prev_menu_help_message>: Constify.
456 (IT_menu_make_room): menu->help_text is now `const char **';
457 adjust.
458
459 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
460 to changes in oldXMenu/XMenu.h from 2011-04-16.
461 (struct XMenu): Declare `help_text' `const char **'.
462
463 * xfaces.c <Qunspecified>: Make extern again.
464
465 * syntax.c: Include sys/types.h before including regex.h, as
466 required by Posix.
467
468 * doc.c (get_doc_string): Improve the format passed to `error'.
469
470 * doprnt.c (doprnt): Improve commentary.
471
472 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
473
474 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
475 them with etags.
476
477 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
478 changes in globals.h immediately force recompilation.
479 (TAGS): Depend on $(CURDIR)/m/intel386.h and
480 $(CURDIR)/s/ms-w32.h.
481 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
482
483 * character.c (Fchar_direction): Function deleted.
484 (syms_of_character): Don't defsubr it.
485 <char-direction-table>: Deleted.
486
487 2011-04-23 Eli Zaretskii <eliz@gnu.org>
488
489 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
490 * doprnt.c: Include limits.h.
491 (SIZE_MAX): New macro.
492 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
493 local variables are now size_t instead of int or unsigned.
494 Improve overflow protection. Support `l' modifier for integer
495 conversions. Support %l conversion. Don't assume an EMACS_INT
496 argument for integer conversions and for %c.
497
498 * lisp.h (doprnt): Restore prototype.
499
500 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
501 $(SRC)/character.h.
502
503 * Makefile.in (base_obj): Add back doprnt.o.
504
505 * deps.mk (doprnt.o): Add back prerequisites.
506 (callint.o): Depend on character.h.
507
508 * eval.c (internal_lisp_condition_case): Include the handler
509 representation in the error message.
510 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
511 when breaking from the loop.
512
513 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
514
515 * callint.c (Fcall_interactively): When displaying error message
516 about invalid control letter, pass the character's codepoint, not
517 a pointer to its multibyte form. Improve display of the character
518 in octal and display also its hex code.
519
520 * character.c (char_string): Use %x to display the (unsigned)
521 codepoint of an invalid character, to avoid displaying a bogus
522 negative value.
523
524 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
525 `error', not SYMBOL_NAME itself.
526
527 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
528 character arguments to `error'.
529
530 * charset.c (check_iso_charset_parameter): Fix incorrect argument
531 to `error' in error message about FINAL_CHAR argument. Make sure
532 FINAL_CHAR is a character, and use %c when it is passed as
533 argument to `error'.
534
535 2011-04-23 Eli Zaretskii <eliz@gnu.org>
536
537 * s/ms-w32.h (localtime): Redirect to sys_localtime.
538
539 * w32.c: Include <time.h>.
540 (sys_localtime): New function.
541
542 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
543
544 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
545
546 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
547
548 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
549
550 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
551 zombies (Bug#8467).
552
553 2011-04-19 Eli Zaretskii <eliz@gnu.org>
554
555 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
556 gl_state.e_property when gl_state.object is Qt.
557
558 * insdel.c (make_gap_larger): Remove limitation of buffer size
559 to <= INT_MAX.
560
561 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
562
563 * xdisp.c (lookup_glyphless_char_display)
564 (produce_glyphless_glyph): Handle cons cell entry in
565 glyphless-char-display.
566 (Vglyphless_char_display): Document it.
567
568 * term.c (produce_glyphless_glyph): Handle cons cell entry in
569 glyphless-char-display.
570
571 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
572
573 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
574
575 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
576
577 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
578 definition for no-X builds.
579
580 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
581
582 Static checks with GCC 4.6.0 and non-default toolkits.
583
584 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
585
586 * process.c (keyboard_bit_set): Define only if SIGIO.
587 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
588 (send_process): Repair possible setjmp clobbering.
589
590 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
591
592 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
593
594 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
595
596 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
597 Define only if needed.
598
599 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
600 by pacifying GCC about it. Maybe it's time to retire it?
601 * xfaces.c (USG, __TIMEVAL__): Likewise.
602
603 * dispextern.h (struct redisplay_interface): Rename param
604 to avoid shadowing.
605 * termhooks.h (struct terminal): Likewise.
606 * xterm.c (xembed_send_message): Likewise.
607
608 * insdel.c (make_gap_smaller): Define only if
609 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
610
611 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
612 it.
613
614 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
615 so that we aren't warned about unused symbols.
616
617 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
618
619 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
620
621 * xfns.c (x_real_positions): Mark locals as initialized.
622
623 * xmenu.c (xmenu_show): Don't use uninitialized vars.
624
625 * xterm.c: Fix problems found by static analysis with other toolkits.
626 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
627 (x_dispatch_event): Declare static if USE_GTK, and
628 define if USE_GTK || USE_X_TOOLKIT.
629 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
630 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
631 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
632 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
633
634 * xmenu.c (menu_help_callback): Pointer type fixes.
635 Use const pointers when pointing at readonly data. Avoid pointer
636 signedness clashes.
637 (FALSE): Remove unused macro.
638 (update_frame_menubar): Remove unused decl.
639
640 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
641
642 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
643 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
644 (single_menu_item): Rename local to avoid shadowing.
645
646 * keyboard.c (make_lispy_event): Remove unused local var.
647
648 * frame.c, frame.h (x_get_resource_string): Bring this back, but
649 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
650
651 * bitmaps: Change bitmaps from unsigned char back to the X11
652 compatible char. Avoid the old compiler warnings about
653 out-of-range initializers by using, for example, '\xab' rather
654 than 0xab.
655
656 * xgselect.c (xgselect_initialize): Check vs interface
657 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
658
659 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
660
661 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
662 to read-only memory.
663
664 * fns.c (vector): Remove; this old hack is no longer needed.
665
666 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
667 Remove unused var.
668 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
669
670 * xrdb.c (x_load_resources): Omit unused local.
671
672 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
673 (x_window): Rename locals to avoid shadowing.
674 (USG): Use the kludged USG macro, to pacify gcc.
675
676 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
677 (x_term_init): Remove local to avoid shadowing.
678
679 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
680
681 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
682 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
683
684 2011-04-16 Eli Zaretskii <eliz@gnu.org>
685
686 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
687
688 Fix regex.c, syntax.c and friends for buffers > 2GB.
689 * syntax.h (struct gl_state_s): Declare character position members
690 EMACS_INT.
691
692 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
693
694 * textprop.c (verify_interval_modification, interval_of): Declare
695 arguments EMACS_INT.
696
697 * intervals.c (adjust_intervals_for_insertion): Declare arguments
698 EMACS_INT.
699
700 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
701
702 * indent.c (Fvertical_motion): Local variable it_start is now
703 EMACS_INT.
704
705 * regex.c (re_match, re_match_2, re_match_2_internal)
706 (bcmp_translate, regcomp, regexec, print_double_string)
707 (group_in_compile_stack, re_search, re_search_2, regex_compile)
708 (re_compile_pattern, re_exec): Declare arguments and local
709 variables `size_t' and `ssize_t' and return values `regoff_t', as
710 appropriate.
711 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
712 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
713 <compile_stack_type>: `size' and `avail' are now `size_t'.
714
715 * regex.h <regoff_t>: Use ssize_t, not int.
716 (re_search, re_search_2, re_match, re_match_2): Arguments that
717 specify buffer/string position and length are now ssize_t and
718 size_t. Return type is regoff_t.
719
720 2011-04-16 Ben Key <bkey76@gmail.com>
721
722 * nsfont.m: Fixed bugs in ns_get_family and
723 ns_descriptor_to_entity that were caused by using free to
724 deallocate memory blocks that were allocated by xmalloc (via
725 xstrdup). This caused Emacs to crash when compiled with
726 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
727 --enable-checking=xmallocoverrun). xfree is now used to
728 deallocate these memory blocks.
729
730 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
731
732 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
733
734 emacs_write: Accept and return EMACS_INT for sizes.
735 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
736 et seq.
737 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
738 Accept and return EMACS_INT.
739 (emacs_gnutls_write): Return the number of bytes written on
740 partial writes.
741 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
742 (emacs_read, emacs_write): Remove check for negative size, as the
743 Emacs source code has been audited now.
744 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
745 (emacs_read, emacs_write): Use it.
746 * process.c (send_process): Adjust to the new signatures of
747 emacs_write and emacs_gnutls_write. Do not attempt to store
748 a byte offset into an 'int'; it might overflow.
749 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
750
751 * sound.c: Don't assume sizes fit in 'int'.
752 (struct sound_device.period_size, alsa_period_size):
753 Return EMACS_INT, not int.
754 (struct sound_device.write, vox_write, alsa_write):
755 Accept EMACS_INT, not int.
756 (wav_play, au_play): Use EMACS_INT to store sizes and to
757 record read return values.
758
759 2011-04-15 Ben Key <bkey76@gmail.com>
760
761 * keyboard.c (Qundefined): Don't declare static since it is used
762 in nsfns.m.
763 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
764 static since they are used in nsfont.m.
765
766 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * process.c (Qprocessp): Don't declare static.
769 * lisp.h (Qprocessp): Declare again.
770
771 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
772
773 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
774
775 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
776
777 Improve C-level modularity by making more things 'static'.
778
779 Don't publish debugger-only interfaces to other modules.
780 * lisp.h (safe_debug_print, debug_output_compilation_hack):
781 (verify_bytepos, count_markers): Move decls to the only modules
782 that need them.
783 * region-cache.h (pp_cache): Likewise.
784 * window.h (check_all_windows): Likewise.
785 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
786
787 * sysdep.c (croak): Now static, if
788 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
789 * syssignal.h (croak): Declare only if not static.
790
791 * alloc.c (refill_memory_reserve): Now static if
792 !defined REL_ALLOC || defined SYSTEM_MALLOC.
793 * lisp.h (refill_memory_reserve): Declare only if not static.
794
795 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
796 Define only if USE_LUCID.
797
798 * xrdb.c (x_customization_string, x_rm_string): Now static.
799
800 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
801 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
802
803 * xdisp.c (draw_row_with_mouse_face): Now static.
804 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
805
806 * window.h (check_all_windows): Mark externally visible.
807
808 * window.c (window_deletion_count): Now static.
809
810 * undo.c: Make symbols static if they're not exported.
811 (last_undo_buffer, last_boundary_position, pending_boundary):
812 Now static.
813
814 * textprop.c (interval_insert_behind_hooks): Now static.
815 (interval_insert_in_front_hooks): Likewise.
816
817 * term.c: Make symbols static if they're not exported.
818 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
819 (max_frame_lines, tty_set_terminal_modes):
820 (tty_reset_terminal_modes, tty_turn_off_highlight):
821 (get_tty_terminal): Now static.
822 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
823 * termhooks.h (term_mouse_moveto): Do not declare if
824 HAVE_WINDOW_SYSTEM.
825 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
826 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
827
828 * sysdep.c: Make symbols static if they're not exported.
829 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
830 Now static.
831 (sigprocmask_set, full_mask): Remove; unused.
832 (wait_debugging): Mark as visible.
833 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
834 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
835
836 * syntax.c (syntax_temp): Define only if !__GNUC__.
837
838 * sound.c (current_sound_device, current_sound): Now static.
839
840 * search.c (searchbufs, searchbuf_head): Now static.
841
842 * scroll.c (scroll_cost): Remove; unused.
843 * dispextern.h (scroll_cost): Remove decl.
844
845 * region-cache.h (pp_cache): Mark as externally visible.
846
847 * process.c: Make symbols static if they're not exported.
848 (process_tick, update_tick, create_process, chan_process):
849 (Vprocess_alist, proc_buffered_char, datagram_access):
850 (fd_callback_data, send_process_frame, process_sent_to): Now static.
851 (deactivate_process): Mark defn as static, as well as decl.
852 * lisp.h (create_process): Remove decl.
853 * process.h (chan_process, Vprocess_alist): Remove decls.
854
855 * print.c: Make symbols static if they're not exported.
856 (print_depth, new_backquote_output, being_printed, print_buffer):
857 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
858 (print_interval, print_number_index, initial_stderr_stream):
859 Now static.
860 * lisp.h (Fprinc): Remove decl.
861 (debug_output_compilation_hack): Mark as externally visible.
862
863 * sysdep.c (croak): Move decl from here to syssignal.h.
864 * syssignal.h (croak): Put it here, so the API can be checked when
865 'croak' is called from dissociate_if_controlling_tty.
866
867 * minibuf.c: Make symbols static if they're not exported.
868 (minibuf_save_list, choose_minibuf_frame): Now static.
869 * lisp.h (choose_minibuf_frame): Remove decl.
870
871 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
872
873 * lread.c: Make symbols static if they're not exported.
874 (read_objects, initial_obarray, oblookup_last_bucket_number):
875 Now static.
876 (make_symbol): Remove; unused.
877 * lisp.h (initial_obarray, make_symbol): Remove decls.
878
879 * keyboard.c: Make symbols static if they're not exported.
880 (single_kboard, recent_keys_index, total_keys, recent_keys):
881 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
882 (this_single_command_key_start, echoing, last_auto_save):
883 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
884 (command_loop, echo_now, keyboard_init_hook, help_char_p):
885 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
886 (Vlispy_mouse_stem, double_click_count):
887 Now static.
888 (force_auto_save_soon): Define only if SIGDANGER.
889 (ignore_mouse_drag_p): Now static if
890 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
891 (print_help): Remove; unused.
892 (stop_character, last_timer_event): Mark as externally visible.
893 * keyboard.h (ignore_mouse_drag_p): Declare only if
894 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
895 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
896 * lisp.h (echoing): Remove decl.
897 (force_auto_save_soon): Declare only if SIGDANGER.
898 * xdisp.c (redisplay_window): Simplify code, to make it more
899 obvious that ignore_mouse_drag_p is not accessed if !defined
900 USE_GTK && !defined HAVE_NS.
901
902 * intervals.c: Make symbols static if they're not exported.
903 (merge_properties_sticky, merge_interval_right, delete_interval):
904 Now static.
905 * intervals.h (merge_interval_right, delete_interval): Remove decls.
906
907 * insdel.c: Make symbols static if they're not exported.
908 However, leave prepare_to_modify_buffer alone. It's never
909 called from outside this function, but that appears to be a bug.
910 (combine_after_change_list, combine_after_change_buffer):
911 (adjust_after_replace, signal_before_change): Now static.
912 (adjust_after_replace_noundo): Remove; unused.
913 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
914 (signal_before_change): Remove decls.
915
916 * indent.c (val_compute_motion, val_vmotion): Now static.
917
918 * image.c: Make symbols static if they're not exported.
919 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
920 if USE_GTK.
921 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
922 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
923
924 * fringe.c (standard_bitmaps): Now static.
925 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
926
927 * frame.c: Make symbols static if they're not exported.
928 (x_report_frame_params, make_terminal_frame): Now static.
929 (get_frame_param): Now static, unless HAVE_NS.
930 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
931 (x_get_resource_string): Remove; not used.
932 * frame.h (make_terminal_frame, x_report_frame_params):
933 (x_get_resource_string); Remove decls.
934 (x_fullscreen_adjust): Declare only if WINDOWSNT.
935 * lisp.h (get_frame_param): Declare only if HAVE_NS.
936
937 * font.c, fontset.c: Make symbols static if they're not exported.
938 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
939 (FACE_SUITABLE_FOR_CHAR_P): Use it.
940 * font.c (font_close_object): Now static.
941 * font.h (font_close_object): Remove.
942 * fontset.c (FONTSET_OBJLIST): Remove.
943 (free_realized_fontset) #if-0 the body, which does nothing.
944 (face_suitable_for_char_p): #if-0, as it's never called.
945 * fontset.h (face_suitable_for_char_p): Remove decl.
946 * xfaces.c (face_at_string_position): Use
947 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
948 since 0 is always ASCII.
949
950 * fns.c (weak_hash_tables): Now static.
951
952 * fileio.c: Make symbols static if they're not exported.
953 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
954 (Vwrite_region_annotation_buffers): Now static.
955
956 * eval.c: Make symbols static if they're not exported.
957 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
958 * lisp.h (backtrace_list): Remove decl.
959
960 * emacs.c: Make symbols static if they're not exported.
961 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
962 (fatal_error_code, fatal_error_signal_hook, standard_args):
963 Now static.
964 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
965 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
966 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
967 * lisp.h (fatal_error_signal_hook): Remove decl.
968 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
969
970 * editfns.c: Move a (normally-unused) function to its only use.
971 * editfns.c, lisp.h (get_operating_system_release): Remove.
972 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
973 worth the hassle of breaking this out.
974
975 * xterm.c: Make symbols static if they're not exported.
976 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
977 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
978 (x_destroy_window, x_delete_display):
979 Now static.
980 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
981 (x_mouse_leave): Remove; unused.
982 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
983 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
984 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
985 Remove decls.
986 (x_mouse_leave): Declare only if WINDOWSNT.
987 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
988 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
989 USE_X_TOOLKIT.
990
991 * ftxfont.c: Make symbols static if they're not exported.
992 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
993 HAVE_FREETYPE.
994 * font.h (ftxfont_driver): Likewise.
995
996 * xfns.c: Make symbols static if they're not exported.
997 (x_last_font_name, x_display_info_for_name):
998 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
999 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1000 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1001 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1002 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1003 (last_show_tip_args): Now static.
1004 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1005 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1006 (x_screen_planes): Remove; unused.
1007 * dispextern.h (x_screen_planes): Remove decl.
1008
1009 * dispnew.c: Make symbols static if they're not exported.
1010 * dispextern.h (redraw_garbaged_frames, scrolling):
1011 (increment_row_positions): Remove.
1012 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1013 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1014 Now static.
1015 (redraw_garbaged_frames): Remove; unused.
1016
1017 * xfaces.c: Make symbols static if they're not exported.
1018 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1019 Remove decls.
1020 * xterm.h (defined_color): Remove decls.
1021 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1022 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1023 (menu_face_changed_default, defined_color, free_realized_face):
1024 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1025 (ascii_face_of_lisp_face): Remove; unused.
1026
1027 * xdisp.c: Make symbols static if they're not exported.
1028 * dispextern.h (scratch_glyph_row, window_box_edges):
1029 (glyph_to_pixel_coords, set_cursor_from_row):
1030 (get_next_display_element, set_iterator_to_next):
1031 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1032 (show_mouse_face): Remove decls
1033 * frame.h (message_buf_print): Likewise.
1034 * lisp.h (pop_message, set_message, check_point_in_composition):
1035 Likewise.
1036 * xterm.h (set_vertical_scroll_bar): Likewise.
1037 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1038 (message_buf_print, scratch_glyph_row, displayed_buffer):
1039 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1040 (get_next_display_element, show_mouse_face, window_box_edges):
1041 (frame_to_window_pixel_xy, check_point_in_composition):
1042 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1043 (glyph_to_pixel_coords): Remove; unused.
1044
1045 * dired.c (file_name_completion): Now static.
1046
1047 * dbusbind.c (xd_in_read_queued_messages): Now static.
1048
1049 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1050 * data.c (circular_list_error): Remove.
1051
1052 * commands.h (last_point_position, last_point_position_buffer):
1053 (last_point_position_window): Remove decls.
1054 * keyboard.c: Make these variables static.
1055
1056 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1057 decls.
1058 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1059 (iso_code_class, detect_coding, code_convert_region): Now static.
1060 (encode_coding_gap): Remove; unused.
1061
1062 * chartab.c (chartab_chars, chartab_bits): Now static.
1063
1064 * charset.h (charset_iso_8859_1): Remove decl.
1065 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1066 Now static.
1067
1068 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1069 * ccl.c (Vccl_program_table): Now static.
1070 (check_ccl_update): Remove; unused.
1071
1072 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1073 * category.h: ... from here.
1074 * category.c (check_category_table, set_category_set): Now static.
1075
1076 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1077 * lisp.h: Remove these decls.
1078
1079 * buffer.c (buffer_count): Remove unused var.
1080
1081 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1082 so that it's not optimized away.
1083 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1084 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1085 exported only to the debugger.
1086
1087 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1088 * atimer.h (run_all_atimers): Removed; not exported.
1089
1090 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1091 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1092 was inaccessible from Lisp.
1093 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1094 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1095
1096 alloc.c: Import and export fewer symbols, and remove unused items.
1097 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1098 is defined.
1099 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1100 it's not optimized away by whole-program optimization.
1101 (message_enable_multibyte, free_misc): Remove.
1102 (catchlist, handlerlist, mark_backtrace):
1103 Declare only if BYTE_MARK_STACK.
1104 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1105 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1106 (message_enable_multibyte): Remove decl.
1107 (free_misc, interval_free_list, float_block, float_block_index):
1108 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1109 (cons_free_list, last_marked_index):
1110 Now static.
1111 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1112 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1113 (mark_backtrace): Define only if BYTE_MARK_STACK.
1114 * xdisp.c (message_enable_multibyte): Now static.
1115
1116 Declare Lisp_Object Q* variables to be 'static' if not exported.
1117 This makes it easier for human readers (and static analyzers)
1118 to see whether these variables are used from other modules.
1119 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1120 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1121 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1122 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1123 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1124 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1125 * xmenu.c, xselect.c:
1126 Declare Q* vars static if they are not used in other modules.
1127 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1128 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1129 Remove decls of unexported vars.
1130 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1131
1132 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1133
1134 Make Emacs functions such as Fatom 'static' by default.
1135 This makes it easier for human readers (and static analyzers)
1136 to see whether these functions can be called from other modules.
1137 DEFUN now defines a static function. To make the function external
1138 so that it can be used in other C modules, use the new macro DEFUE.
1139 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1140 (Finit_image_library):
1141 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1142 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1143 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1144 Remove decls, since these functions are now static.
1145 (Funintern, Fget_internal_run_time): New decls, since these functions
1146 were already external.
1147
1148 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1149 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1150 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1151 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1152 * keyboard.c, keymap.c, lread.c:
1153 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1154 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1155 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1156 Mark functions with DEFUE instead of DEFUN,
1157 if they are used in other modules.
1158 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1159 decls for now-static functions.
1160 * buffer.h (Fdelete_overlay): Remove decl.
1161 * callproc.c (Fgetenv_internal): Mark as internal.
1162 * composite.c (Fremove_list_of_text_properties): Remove decl.
1163 (Fcomposition_get_gstring): New forward static decl.
1164 * composite.h (Fcomposite_get_gstring): Remove decl.
1165 * dired.c (Ffile_attributes): New forward static decl.
1166 * doc.c (Fdocumntation_property): New forward static decl.
1167 * eval.c (Ffetch_bytecode): New forward static decl.
1168 (Funintern): Remove extern decl; now in .h file where it belongs.
1169 * fileio.c (Fmake_symbolic_link): New forward static decl.
1170 * image.c (Finit_image_library): New forward static decl.
1171 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1172 * intervals.h (Fprevious_property_change):
1173 (Fremove_list_of_text_properties): Remove decls.
1174 * keyboard.c (Fthis_command_keys): Remove decl.
1175 (Fcommand_execute): New forward static decl.
1176 * keymap.c (Flookup_key): New forward static decl.
1177 (Fcopy_keymap): Now static.
1178 * keymap.h (Flookup_key): Remove decl.
1179 * process.c (Fget_process): New forward static decl.
1180 (Fprocess_datagram_address): Mark as internal.
1181 * syntax.c (Fsyntax_table_p): New forward static decl.
1182 (skip_chars): Remove duplicate decl.
1183 * textprop.c (Fprevious_property_change): New forward static decl.
1184 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1185 Now internal.
1186 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1187 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1188
1189 * editfns.c (Fformat): Remove unreachable code.
1190
1191 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1192
1193 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1194 change. (Bug#8496)
1195
1196 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1199 when at ZV. (Bug#8487)
1200
1201 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1202
1203 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1204 (Bug#8437)
1205 * keyboard.c (parse_tool_bar_item): Likewise.
1206 * sound.c (sound_cleanup, alsa_close): Likewise.
1207 * termcap.c (tgetent): Likewise.
1208 * xfns.c (x_default_font_parameter): Likewise.
1209 * xsettings.c (read_and_apply_settings): Likewise.
1210
1211 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1212 (overrun_check_free): Protoize.
1213
1214 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1217 since callers should never pass a negative size.
1218 Change the signature to match that of plain 'read' and 'write'; see
1219 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1220 * lisp.h: Update prototypes of emacs_write and emacs_read.
1221
1222 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xdisp.c (redisplay_window): Don't try to determine the character
1225 position of the scroll margin if the window start point w->startp
1226 is outside the buffer's accessible region. (Bug#8468)
1227
1228 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1229
1230 Fix write-region and its subroutines for buffers > 2GB.
1231 * fileio.c (a_write, e_write): Modify declaration of arguments and
1232 local variables to support buffers larger than 2GB.
1233 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1234
1235 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1236 argument, local variables, and return value.
1237
1238 * lisp.h: Update prototypes of emacs_write and emacs_read.
1239
1240 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1241
1242 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1245
1246 Fix more problems found by GCC 4.6.0's static checks.
1247
1248 * xdisp.c (vmessage): Use a better test for character truncation.
1249
1250 * charset.c (load_charset_map): <, not <=, for optimization,
1251 and to avoid potential problems with integer overflow.
1252 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1253 * casetab.c (set_identity, shuffle): Likewise.
1254 * editfns.c (Fformat): Likewise.
1255 * syntax.c (skip_chars): Likewise.
1256
1257 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1258 This also lets GCC 4.6.0 generate slightly better loop code.
1259
1260 * callint.c (Fcall_interactively): <, not <=, for optimization.
1261 (Fcall_interactively): Count the number of arguments produced,
1262 not the number of arguments given. This is simpler and lets GCC
1263 4.6.0 generate slightly better code.
1264
1265 * ftfont.c: Distingish more carefully between FcChar8 and char.
1266 The previous code passed unsigned char * to a functions like
1267 strlen and xstrcasecmp that expect char *, which does not
1268 conform to the C standard.
1269 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1270 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1271 char * when the C standard requires it.
1272
1273 * keyboard.c (read_char): Remove unused var.
1274
1275 * eval.c: Port to Windows vsnprintf (Bug#8435).
1276 Include <limits.h>.
1277 (SIZE_MAX): Define if the headers do not.
1278 (verror): Do not give up if vsnprintf returns a negative count.
1279 Instead, grow the buffer. This ports to Windows vsnprintf, which
1280 does not conform to C99. Problem reported by Eli Zaretskii.
1281 Also, simplify the allocation scheme, by avoiding the need for
1282 calling realloc, and removing the ALLOCATED variable.
1283
1284 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1285
1286 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1287 But keep the doprint source code for now, as we might revamp it
1288 and use it again (Bug#8435).
1289 * lisp.h (doprnt): Remove.
1290 * Makefile.in (base_obj): Remove doprnt.o.
1291 * deps.mk (doprnt.o): Remove.
1292
1293 error: Print 32- and 64-bit integers portably (Bug#8435).
1294 Without this change, on typical 64-bit hosts error ("...%d...", N)
1295 was used to print both 32- and 64-bit integers N, which relied on
1296 undefined behavior.
1297 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1298 New macro.
1299 * lisp.h (error, verror): Mark as printf-like functions.
1300 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1301 Report overflow in size calculations when allocating printf buffer.
1302 Do not truncate output string at its first null byte.
1303 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1304 Truncate the output at a character boundary, since vsnprintf does not
1305 do that.
1306 * charset.c (check_iso_charset_parameter): Convert internal
1307 character to string before calling 'error', since %c now has the
1308 printf meaning.
1309 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1310 overflow when computing char to be passed to 'error'. Do not
1311 pass Lisp_Object to 'error'; pass the integer instead.
1312 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1313 formatted with plain %d.
1314
1315 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1316
1317 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1318
1319 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1320
1321 * xterm.c (x_catch_errors): Remove duplicate declaration.
1322
1323 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1324
1325 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1326
1327 2011-04-10 Jim Meyering <meyering@redhat.com>
1328
1329 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1330 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1331 return ssize_t not "int", and use size_t as the buffer length.
1332 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1333 * gnutls.h: Update declarations.
1334 * process.c (read_process_output): Use ssize_t, to match.
1335 (send_process): Likewise.
1336
1337 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1338
1339 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1340
1341 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1342
1343 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1344 unsigned char, to match FcChar8 type definition.
1345
1346 * xterm.c (handle_one_xevent):
1347 * xmenu.c (create_and_show_popup_menu):
1348 * xselect.c (x_decline_selection_request)
1349 (x_reply_selection_request): Avoid type-punned deref of X events.
1350
1351 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1352
1353 Fix some uses of `int' instead of EMACS_INT.
1354 * search.c (string_match_1, fast_string_match)
1355 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1356 (scan_buffer, find_next_newline_no_quit)
1357 (find_before_next_newline, search_command, Freplace_match)
1358 (Fmatch_data): Make some `int' variables be EMACS_INT.
1359
1360 * xdisp.c (display_count_lines): 3rd argument and return value now
1361 EMACS_INT. All callers changed.
1362 (pint2hrstr): Last argument is now EMACS_INT.
1363
1364 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1365 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1366 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1367 (decode_coding_utf_16, decode_coding_emacs_mule)
1368 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1369 (decode_coding_ccl, decode_coding_charset)
1370 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1371 (decode_coding_iso_2022, decode_coding_emacs_mule)
1372 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1373 <char_offset, last_offset>: Declare EMACS_INT.
1374 (encode_coding_utf_8, encode_coding_utf_16)
1375 (encode_coding_emacs_mule, encode_invocation_designation)
1376 (encode_designation_at_bol, encode_coding_iso_2022)
1377 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1378 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1379 Declare EMACS_INT.
1380 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1381 (encode_invocation_designation): Last argument P_NCHARS is now
1382 EMACS_INT.
1383 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1384 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1385
1386 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1387 All users changed.
1388
1389 * ccl.c (Fccl_execute_on_string): Declare some variables
1390 EMACS_INT.
1391
1392 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1393
1394 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1395
1396 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1397
1398 * process.c (Fformat_network_address): Doc fix.
1399
1400 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1401
1402 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1403
1404 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1405
1406 * keyboard.c (read_char): Call Lisp function help-form-show,
1407 instead of using internal_with_output_to_temp_buffer.
1408 (Qhelp_form_show): New var.
1409 (syms_of_keyboard): Use DEFSYM macro.
1410
1411 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1412
1413 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1414
1415 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * process.c (Flist_processes): Removed to Lisp.
1418 (list_processes_1): Deleted.
1419
1420 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1421
1422 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1423
1424 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1425
1426 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 Fix more problems found by GCC 4.6.0's static checks.
1429
1430 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1431
1432 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1433
1434 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1435
1436 * xdisp.c (vmessage): Mark as a printf-like function.
1437
1438 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1439
1440 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1441
1442 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1443 printf-like functions.
1444 (tiff_load): Add casts to remove these marks before passing them
1445 to system-supplied API.
1446
1447 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1448
1449 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1450 This avoids several warnings with gcc -Wstrict-overflow.
1451 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1452 directly, rather than having caller test rule sign. This avoids
1453 some unnecessary tests.
1454 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1455 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1456 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1457
1458 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1459 (xfont_open): Avoid unnecessary tests.
1460
1461 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1462
1463 * composite.h, composite.c (composition_gstring_put_cache):
1464 Use EMACS_INT, not int, for length.
1465
1466 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1467 breaking out part of COMPOSITION_DECODE_RULE.
1468 (COMPOSITION_DECODE_RULE): Use it.
1469 * composite.c (get_composition_id): Remove unused local vars,
1470 by using the new macro.
1471
1472 * textprop.c (set_text_properties_1): Change while to do-while,
1473 since the condition is always true at first.
1474
1475 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1476 (interval_deletion_adjustment): Return unsigned value.
1477 All uses changed.
1478
1479 * process.c (list_processes_1, create_pty, read_process_output):
1480 (exec_sentinel): Remove vars that were set but not used.
1481 (create_pty): Remove unnecessary "volatile"s.
1482 (Fnetwork_interface_info): Avoid possibility of int overflow.
1483 (read_process_output): Do adaptive read buffering even if carryover.
1484 (read_process_output): Simplify nbytes computation if buffered.
1485
1486 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1487
1488 * syntax.c (scan_words): Remove var that was set but not used.
1489 (update_syntax_table): Use unsigned instead of int.
1490
1491 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1492 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1493 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1494
1495 * print.c (print_error_message): Avoid int overflow.
1496
1497 * font.c (font_list_entities): Redo for clarity,
1498 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1499
1500 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1501 (font_score): Avoid potential overflow in diff calculation.
1502
1503 * fns.c (substring_both): Remove var that is set but not used.
1504 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1505
1506 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1507
1508 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1509 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1510 can always succeed if overflow has undefined behavior.
1511
1512 * search.c (boyer_moore, wordify): Remove vars set but not used.
1513 (wordify): Omit three unnecessary tests.
1514
1515 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1516 All callers changed. This avoids the need for an unused var.
1517
1518 * casefiddle.c (casify_region): Remove var that is set but not used.
1519
1520 * dired.c (file_name_completion): Remove var that is set but not used.
1521
1522 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1523
1524 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1525 (Finsert_file_contents): Remove unnecessary code checking fd.
1526
1527 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1528 Check for integer overflow on size calculations.
1529
1530 * buffer.c (Fprevious_overlay_change): Remove var that is set
1531 but not used.
1532
1533 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1534 Remove vars that are set but not used.
1535 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1536 (timer_check_2): Mark vars as initialized.
1537
1538 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1539
1540 * image.c (lookup_image): Remove var that is set but not used.
1541 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1542
1543 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1544 that are set but not used.
1545
1546 * xfns.c (make_invisible_cursor): Don't return garbage
1547 if XCreateBitmapFromData fails (Bug#8410).
1548
1549 * xselect.c (x_get_local_selection, x_handle_property_notify):
1550 Remove vars that are set but not used.
1551
1552 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1553 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1554
1555 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1556 Remove var that is set but not used.
1557 (scroll_bar_windows_size): Now size_t, not int.
1558 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1559 Check for overflow.
1560
1561 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1562 (map_tty_color) [!defined MSDOS]: Likewise.
1563
1564 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1565
1566 * coding.c: Remove vars that are set but not used.
1567 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1568 All callers changed.
1569 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1570 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1571 (decode_coding_charset): Remove vars that are set but not used.
1572
1573 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1574 that is set but not used.
1575
1576 * print.c (print_object): Remove var that is set but not used.
1577
1578 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1579 The gnulib version avoids calling malloc in the usual case,
1580 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1581 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1582 * filelock.c (current_lock_owner): Likewise.
1583 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1584 * sysdep.c: Include allocator.h, careadlinkat.h.
1585 (emacs_no_realloc_allocator): New static constant.
1586 (emacs_readlink): New function.
1587 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1588 ../lib/careadlinkat.h.
1589
1590 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1593 first non-nil return value).
1594
1595 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1596
1597 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1598 if not defined (Bug#8403).
1599
1600 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * xdisp.c (display_count_lines): Remove parameter `start',
1603 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1604 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1605 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1606 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1607 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1608 and thereabouts. All callers changed.
1609 (get_per_char_metric): Remove parameter `f', unused since
1610 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1611
1612 2011-04-02 Jim Meyering <meyering@redhat.com>
1613
1614 do not dereference NULL upon failed strdup
1615 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1616 (ns_get_family): Likewise.
1617
1618 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1621
1622 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1623
1624 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1625 later (Bug#8403).
1626
1627 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1628
1629 Add lexical binding.
1630
1631 * window.c (Ftemp_output_buffer_show): New fun.
1632 (Fsave_window_excursion):
1633 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1634
1635 * lread.c (lisp_file_lexically_bound_p): New function.
1636 (Fload): Bind Qlexical_binding.
1637 (readevalloop): Remove `evalfun' arg.
1638 Bind Qinternal_interpreter_environment.
1639 (Feval_buffer): Bind Qlexical_binding.
1640 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1641 Mark as dynamic.
1642 (syms_of_lread): Declare `lexical-binding'.
1643
1644 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1645
1646 * keyboard.c (eval_dyn): New fun.
1647 (menu_item_eval_property): Use it.
1648
1649 * image.c (parse_image_spec): Use Ffunctionp.
1650
1651 * fns.c (concat, mapcar1): Accept byte-code-functions.
1652
1653 * eval.c (Fsetq): Handle lexical vars.
1654 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1655 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1656 (FletX, Flet): Obey lexical binding.
1657 (Fcommandp): Handle closures.
1658 (Feval): New `lexical' arg.
1659 (eval_sub): New function extracted from Feval. Use it almost
1660 everywhere where Feval was used. Look up vars in lexical env.
1661 Handle closures.
1662 (Ffunctionp): Move from subr.el.
1663 (Ffuncall): Handle closures.
1664 (apply_lambda): Remove `eval_flags'.
1665 (funcall_lambda): Handle closures and new byte-code-functions.
1666 (Fspecial_variable_p): New function.
1667 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1668 but without exporting it to Lisp.
1669
1670 * doc.c (Fdocumentation, store_function_docstring):
1671 * data.c (Finteractive_form): Handle closures.
1672
1673 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1674 interactive spec.
1675
1676 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1677 byte-codes.
1678 (exec_byte_code): New function extracted from Fbyte_code to handle new
1679 calling convention for byte-code-functions. Add new byte-codes.
1680
1681 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1682
1683 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1684
1685 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * xdisp.c (redisplay_internal): Fix prototype.
1688
1689 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1690
1691 * xdisp.c (SCROLL_LIMIT): New macro.
1692 (try_scrolling): Use it when setting scroll_limit. Limit
1693 scrolling to 100 screen lines.
1694 (redisplay_window): Even when falling back on "recentering",
1695 position point in the window according to scroll-conservatively,
1696 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1697
1698 (try_scrolling): When point is above the window, allow searching
1699 as far as scroll_max, or one screenful, to compute vertical
1700 distance from PT to the scroll margin position. This prevents
1701 try_scrolling from unnecessarily failing when
1702 scroll-conservatively is set to a value slightly larger than the
1703 window height. Clean up the case of PT below the margin at bottom
1704 of window: scroll_max can no longer be INT_MAX. When aggressive
1705 scrolling is in use, don't let point enter the opposite scroll
1706 margin as result of the scroll.
1707 (syms_of_xdisp) <scroll-conservatively>: Document the
1708 threshold of 100 lines for never-recentering scrolling.
1709
1710 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * dispextern.h (move_it_by_lines):
1713 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1714 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1715 (message_log_check_duplicate): Remove parameters `prev_bol' and
1716 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1717 (redisplay_internal): Remove parameter `preserve_echo_area',
1718 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1719
1720 * indent.c (Fvertical_motion):
1721 * window.c (window_scroll_pixel_based, Frecenter):
1722 Don't pass `need_y_p' to `move_it_by_lines'.
1723
1724 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1725
1726 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1727 steal a few bits to be more compact.
1728 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1729 Remove unneeded casts.
1730
1731 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1732
1733 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1734
1735 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1736 binding" message (bug#7967).
1737
1738 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 Fix more problems found by GCC 4.6.0's static checks.
1741
1742 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1743 Remove unused local var.
1744
1745 * editfns.c (Fmessage_box): Remove unused local var.
1746
1747 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1748 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1749 Omit unused local vars.
1750 * window.c (shrink_windows): Omit unused local var.
1751 * menu.c (digest_single_submenu): Omit unused local var.
1752 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1753 Omit unused local var.
1754
1755 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1756 Don't assume string length fits in int.
1757 (keyremap_step, read_key_sequence): Use size_t for sizes.
1758 (read_key_sequence): Don't check last_real_key_start redundantly.
1759
1760 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1761 instead of alloca (Bug#8344).
1762
1763 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1764 (Fbacktrace_frame): Don't assume nframes fits in int.
1765
1766 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1767
1768 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1769 concerns.
1770
1771 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1772
1773 * cm.c (calccost): Turn while-do into do-while, for clarity.
1774
1775 * keyboard.c (syms_of_keyboard): Use the same style as later
1776 in this function when indexing through an array. This also
1777 works around GCC bug 48267.
1778
1779 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1780
1781 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1782
1783 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1784 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1785
1786 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1787 This avoids undefined behavior on integer overflow, and is a bit
1788 more convenient anyway since it is compared to a size_t variable.
1789
1790 Variadic C functions now count arguments with size_t, not int.
1791 This avoids an unnecessary limitation on 64-bit machines, which
1792 caused (substring ...) to crash on large vectors (Bug#8344).
1793 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1795 All variadic functions and their callers changed accordingly.
1796 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1797 * data.c (arith_driver, float_arith_driver): Likewise.
1798 * editfns.c (general_insert_function): Likewise.
1799 * eval.c (struct backtrace.nargs, interactive_p)
1800 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1801 (funcall_lambda, mark_backtrace): Likewise.
1802 * fns.c (concat): Likewise.
1803 * frame.c (x_set_frame_parameters): Likewise.
1804 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1805 0 if not found, not -1. All callers changed.
1806
1807 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1808 (stack_copy_size): Now size_t, not int.
1809 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1810
1811 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1814 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1815 All callers changed.
1816
1817 * lisp.h (multibyte_char_to_unibyte):
1818 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1819 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1820 * character.h (CHAR_TO_BYTE8):
1821 * cmds.c (internal_self_insert):
1822 * editfns.c (general_insert_function):
1823 * keymap.c (push_key_description):
1824 * search.c (Freplace_match):
1825 * xdisp.c (message_dolog, set_message_1): All callers changed.
1826
1827 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1828
1829 * keyboard.c (safe_run_hook_funcall): New function.
1830 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1831 don't set the hook to nil, but remove the offending function instead.
1832 (Qcommand_hook_internal): Remove, unused.
1833 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1834 Vcommand_hook_internal.
1835
1836 * eval.c (enum run_hooks_condition): Remove.
1837 (funcall_nil, funcall_not): New functions.
1838 (run_hook_with_args): Call each function through a `funcall' argument.
1839 Remove `cond' argument, now redundant.
1840 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1841 (Frun_hook_with_args_until_failure): Adjust accordingly.
1842 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1843
1844 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * dispextern.h (string_buffer_position): Remove declaration.
1847
1848 * print.c (strout): Remove parameter `multibyte', unused since
1849 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1850
1851 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1852 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1853 All callers changed.
1854
1855 * w32.c (_wsa_errlist): Use braces for struct initializers.
1856
1857 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1858 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1859 All callers changed.
1860 (string_buffer_position): Likewise. Also, make static (it's never
1861 used outside xdisp.c).
1862 (cursor_row_p): Remove parameter `w', unused since
1863 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1864 (decode_mode_spec): Remove parameter `precision', introduced during
1865 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1866 All callers changed.
1867
1868 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1869
1870 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1871
1872 2011-03-27 Anders Lindgren <andlind@gmail.com>
1873
1874 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1875 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1876 (ns_update_auto_hide_menu_bar): New functions.
1877 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1878 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1879 ns_constrain_all_frames.
1880 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1881 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1882
1883 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1884
1885 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1886
1887 2011-03-27 Glenn Morris <rgm@gnu.org>
1888
1889 * syssignal.h: Replace RETSIGTYPE with void.
1890 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1891 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1892 Replace SIGTYPE with void everywhere.
1893 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1894 * s/template.h (SIGTYPE): Remove commented out definition.
1895
1896 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1899 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1900
1901 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1902
1903 * w32.c (read_unc_volume): Use parameter `henum', instead of
1904 global variable `wget_enum_handle'.
1905
1906 * keymap.c (describe_vector): Remove parameters `indices' and
1907 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1908 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1909
1910 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1911
1912 * keyboard.c (timer_check): Remove parameter `do_it_now',
1913 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1914 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1915 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1916
1917 * keyboard.c (read_char):
1918 * w32menu.c (w32_menu_display_help):
1919 * xmenu.c (show_help_event, menu_help_callback):
1920 Adjust calls to `show_help_echo'.
1921
1922 * gtkutil.c (xg_maybe_add_timer):
1923 * keyboard.c (readable_events):
1924 * process.c (wait_reading_process_output):
1925 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1926
1927 * insdel.c (adjust_markers_gap_motion):
1928 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1929 (gap_left, gap_right): Don't call it.
1930
1931 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1932
1933 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1934 incurred during fontification.
1935
1936 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1937
1938 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1939 (DEFVAR_PER_BUFFER): Don't pass it.
1940
1941 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1942 (scrolling_window): Don't pass it.
1943
1944 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1945
1946 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1947
1948 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1949 and `suffix'.
1950 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1951 of variables specific to SELinux and computation of `encoded_absname'.
1952
1953 * image.c (XPutPixel): Remove unused variable `height'.
1954
1955 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1956
1957 * unexw32.c (get_section_info): Remove unused variable `section'.
1958
1959 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1960 (system_process_attributes): Remove unused variable `sess'.
1961 (sys_read): Remove unused variable `err'.
1962
1963 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1964 (w32_wnd_proc): Remove unused variable `isdead'.
1965 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1966 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1967 (x_create_tip_frame): Remove unused variable `tem'.
1968
1969 * w32inevt.c (w32_console_read_socket):
1970 Remove unused variable `no_events'.
1971
1972 * w32term.c (x_draw_composite_glyph_string_foreground):
1973 Remove unused variable `width'.
1974
1975 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1976
1977 * w32term.c (x_set_glyph_string_clipping):
1978 Don't pass uninitialized region to CombineRgn.
1979
1980 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1981
1982 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1983 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1984 (Fx_close_connection): Remove unused variable `i'.
1985
1986 * w32font.c (w32font_draw): Return number of glyphs.
1987 (w32font_open_internal): Remove unused variable `i'.
1988 (w32font_driver): Add missing initializer.
1989
1990 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1991 (fill_in_menu): Remove unused variable `items_added'.
1992
1993 * w32term.c (last_mouse_press_frame): Remove static global variable.
1994 (w32_clip_to_row): Remove unused variable `f'.
1995 (x_delete_terminal): Remove unused variable `i'.
1996
1997 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1998 (NOTHING): Remove unused static global variable.
1999 (uniscribe_check_otf): Remove unused variable `table'.
2000 (uniscribe_font_driver): Add missing initializers.
2001
2002 2011-03-23 Julien Danjou <julien@danjou.info>
2003
2004 * term.c (Fsuspend_tty, Fresume_tty):
2005 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2006 * window.c (temp_output_buffer_show):
2007 * insdel.c (signal_before_change):
2008 * frame.c (Fhandle_switch_frame):
2009 * fileio.c (Fdo_auto_save):
2010 * emacs.c (Fkill_emacs):
2011 * editfns.c (save_excursion_restore):
2012 * cmds.c (internal_self_insert):
2013 * callint.c (Fcall_interactively):
2014 * buffer.c (Fkill_all_local_variables):
2015 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2016 Use Frun_hooks.
2017 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2018 unconditionnaly since it does the check itself.
2019
2020 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 Fix more problems found by GCC 4.5.2's static checks.
2023
2024 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2025 the first time through the loop, since we know p0 < p1 then.
2026 This also avoids a gcc -Wstrict-overflow warning.
2027
2028 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2029 leading to a memory leak, possible in functions like
2030 load_charset_map_from_file that can allocate an unbounded number
2031 of objects (Bug#8318).
2032
2033 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2034 that could (at least in theory) be that large.
2035
2036 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2037 This is less likely to overflow, and avoids undefined behavior if
2038 overflow does occur. All callers changed. Use strtoul to scan
2039 for the unsigned long integer.
2040 (pint2hrstr): Simplify and tune code slightly.
2041 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2042
2043 * scroll.c (do_scrolling): Work around GCC bug 48228.
2044 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2045
2046 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2047 This also avoids a warning with gcc -Wstrict-overflow.
2048 (validate_x_resource_name): Simplify count usage.
2049 This also avoids a warning with gcc -Wstrict-overflow.
2050
2051 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2052 fail (Bug#8306).
2053
2054 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2055
2056 * process.c (Fmake_network_process): Use socklen_t, not int,
2057 where POSIX says socklen_t is required in portable programs.
2058 This fixes a porting bug on hosts like 64-bit HP-UX, where
2059 socklen_t is wider than int (Bug#8277).
2060 (Fmake_network_process, server_accept_connection):
2061 (wait_reading_process_output, read_process_output):
2062 Likewise.
2063
2064 * process.c: Rename or move locals to avoid shadowing.
2065 (list_processes_1, Fmake_network_process):
2066 (read_process_output_error_handler, exec_sentinel_error_handler):
2067 Rename or move locals.
2068 (Fmake_network_process): Define label "retry_connect" only if needed.
2069 (Fnetwork_interface_info): Fix pointer signedness.
2070 (process_send_signal): Add cast to avoid pointer signedness problem.
2071 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2072 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2073
2074 Make tparam.h and terminfo.c consistent.
2075 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2076 Include tparam.h instead, since it declares them.
2077 * cm.h (PC): Remove extern decl; tparam.h now does this.
2078 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2079 * terminfo.c: Include tparam.h, to check interfaces.
2080 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2081 (tparam): Adjust signature to match interface in tparam.h;
2082 this removes some undefined behavior. Check that outstring and len
2083 are zero, which they always are with Emacs.
2084 * tparam.h (PC, BC, UP): New extern decls.
2085
2086 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2087 (xftfont_open): Rename locals to avoid shadowing.
2088
2089 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2090 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2091 (OTF_TAG_SYM): Omit macro if not needed.
2092 (ftfont_list): Remove unused local.
2093 (get_adstyle_property, ftfont_pattern_entity):
2094 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2095 Rename locals to avoid shadowing.
2096
2097 * xfont.c (xfont_list_family): Mark var as initialized.
2098
2099 * xml.c (make_dom): Now static.
2100
2101 * composite.c (composition_compute_stop_pos): Rename local to
2102 avoid shadowing.
2103 (composition_reseat_it): Remove unused locals.
2104 (find_automatic_composition, composition_adjust_point): Likewise.
2105 (composition_update_it): Mark var as initialized.
2106 (find_automatic_composition): Mark vars as initialized,
2107 with a FIXME (Bug#8290).
2108
2109 character.h: Rename locals to avoid shadowing.
2110 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2111 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2112 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2113 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2114 to avoid shadowing.
2115
2116 * textprop.c (property_change_between_p): Remove; unused.
2117
2118 * intervals.c (interval_start_pos): Now static.
2119
2120 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2121
2122 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2123 Rename locals to avoid shadowing.
2124
2125 * sound.c (wav_play, au_play, Fplay_sound_internal):
2126 Fix pointer signedness.
2127 (alsa_choose_format): Remove unused local var.
2128 (wav_play): Initialize a variable to 0, to prevent undefined
2129 behavior (Bug#8278).
2130
2131 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2132
2133 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2134
2135 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2136 clobbering (Bug#8298).
2137 * sysdep.c (sys_subshell): Likewise.
2138 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2139
2140 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2141 This should get cleaned up, so that child_setup has the
2142 same signature on all platforms.
2143
2144 * callproc.c (call_process_cleanup): Now static.
2145 (relocate_fd): Rename locals to avoid shadowing.
2146
2147 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2148
2149 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2150 not to be necessary, and produces flickering.
2151
2152 2011-03-20 Glenn Morris <rgm@gnu.org>
2153
2154 * config.in: Remove file.
2155
2156 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2159 are now in src/globals.h.
2160 (syms_of_minibuf): Remove spurious & from previous change.
2161
2162 2011-03-20 Leo <sdl.web@gmail.com>
2163
2164 * minibuf.c (completing-read-function): New variable.
2165 (completing-read-default): Rename from completing-read.
2166 (completing-read): Call completing-read-function.
2167
2168 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2169
2170 * xfaces.c (Fx_load_color_file):
2171 Read color file from absolute filename (bug#8250).
2172
2173 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2174
2175 * makefile.w32-in: Update dependencies.
2176
2177 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2178
2179 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2180
2181 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 Fix more problems found by GCC 4.5.2's static checks.
2184
2185 * process.c (make_serial_process_unwind, send_process_trap):
2186 (sigchld_handler): Now static.
2187
2188 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2189 That way, the code declares only the vars that it needs.
2190 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2191 * s/cygwin.h (PTY_ITERATION): Likewise.
2192 * s/darwin.h (PTY_ITERATION): Likewise.
2193 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2194
2195 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2196 * process.c (allocate_pty): Don't declare stb unless it's needed.
2197
2198 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2199 (CONSTANTLIM): Remove; unused.
2200 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2201 Define only if needed.
2202
2203 * unexelf.c (unexec): Name an expression,
2204 to avoid gcc -Wbad-function-cast warning.
2205 Use a different way to cause a compilation error if anyone uses
2206 n rather than nn, a way that does not involve shadowing.
2207 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2208
2209 * deps.mk (unexalpha.o): Remove; unused.
2210
2211 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2212 * unexec.h: New file.
2213 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2214 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2215 Depend on unexec.h.
2216 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2217 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2218 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2219 Change as necessary to match prototype in unexec.h.
2220
2221 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2222 shadowing.
2223 (back_comment, skip_chars): Mark vars as initialized.
2224
2225 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2226 Rename locals to avoid shadowing.
2227
2228 * lread.c (read1): Rewrite so as not to use empty "else".
2229 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2230
2231 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2232
2233 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2234 warning when compiling print.c.
2235
2236 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2237 instead of using an uninitialized var.
2238 (font_sort_entities): Mark var as initialized.
2239
2240 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2241
2242 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2243 pointers to constants.
2244 (font_parse_fcname): Remove unused vars.
2245 (font_delete_unmatched): Now static.
2246 (font_get_spec): Remove; unused.
2247 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2248 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2249 Rename or move locals to avoid shadowing.
2250
2251 * fns.c (require_nesting_list, require_unwind): Now static.
2252 (Ffillarray): Rename locals to avoid shadowing.
2253
2254 * floatfns.c (domain_error2): Define only if needed.
2255 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2256
2257 * alloc.c (mark_backtrace): Move decl from here ...
2258 * lisp.h: ... to here, so that it can be checked.
2259
2260 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2261 (Fdefvar): Rewrite so as not to use empty "else".
2262 (lisp_indirect_variable): Name an expression,
2263 to avoid gcc -Wbad-function-cast warning.
2264 (Fdefvar): Rename locals to avoid shadowing.
2265
2266 * callint.c (quotify_arg, quotify_args): Now static.
2267 (Fcall_interactively): Rename locals to avoid shadowing.
2268 Use const pointer when appropriate.
2269
2270 * lisp.h (get_system_name, get_operating_system_release):
2271 Move decls here, to check interfaces.
2272 * process.c (get_operating_system_release): Move decl to lisp.h.
2273 * xrdb.c (get_system_name): Likewise.
2274 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2275 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2276 some of which prompt warnings from gcc -Wbad-function-cast.
2277 (Fformat_time_string, Fencode_time, Finsert_char):
2278 (Ftranslate_region_internal, Fformat):
2279 Rename or remove local vars to avoid shadowing.
2280 (Ftranslate_region_internal): Mark var as initialized.
2281
2282 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2283 avoid shadowing.
2284
2285 * lisp.h (eassert): Check that the argument compiles, even if
2286 ENABLE_CHECKING is not defined.
2287
2288 * data.c (Findirect_variable): Name an expression, to avoid
2289 gcc -Wbad-function-cast warning.
2290 (default_value, arithcompare, arith_driver, arith_error): Now static.
2291 (store_symval_forwarding): Rename local to avoid shadowing.
2292 (Fmake_variable_buffer_local, Fmake_local_variable):
2293 Mark variables as initialized.
2294 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2295
2296 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2297 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2298 Rename locals to avoid shadowing.
2299 (mark_stack): Move local variables into the #ifdef region where
2300 they're used.
2301 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2302 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2303 needed otherwise.
2304 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2305 (GC_STRING_CHARS): Remove; not used.
2306 (Fmemory_limit): Cast sbrk's returned value to char *.
2307
2308 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2309 avoids undefined behavior in theory.
2310
2311 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2312
2313 Use functions, not macros, for up- and down-casing (Bug#8254).
2314 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2315 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2316 to use the following functions instead of these macros.
2317 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2318 EMACS_INT, since callers assume the returned value fits in int.
2319 (upcase1): Likewise, for UPCASE_TABLE.
2320 (uppercasep, lowercasep, upcase): New static inline functions.
2321 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2322 the race-condition problem in the old DOWNCASE.
2323
2324 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2325 Rename locals to avoid shadowing.
2326 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2327 (regex_compile, re_search_2, re_match_2_internal):
2328 Remove unused local vars.
2329 (FREE_VAR): Rewrite so as not to use empty "else",
2330 which gcc can warn about.
2331 (regex_compile, re_match_2_internal): Mark locals as initialized.
2332 (RETALLOC_IF): Define only if needed.
2333 (WORDCHAR_P): Likewise. This one is never needed, but is used
2334 only in a comment talking about a compiler bug, so put inside
2335 the #if 0 of that comment.
2336 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2337 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2338 Remove; unused.
2339
2340 * search.c (boyer_moore): Rename locals to avoid shadowing.
2341 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2342 (PREV_CHAR_BOUNDARY): Likewise.
2343
2344 * search.c (simple_search): Remove unused var.
2345
2346 * dired.c (compile_pattern): Move decl from here ...
2347 * lisp.h: ... to here, so that it can be checked.
2348 (struct re_registers): New forward decl.
2349
2350 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2351
2352 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2353 All uses changed.
2354 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2355 Rename locals to avoid shadowing.
2356 (Fvertical_motion): Mark locals as initialized.
2357
2358 * casefiddle.c (casify_object, casify_region): Now static.
2359 (casify_region): Mark local as initialized.
2360
2361 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2362
2363 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2364 New macros, so that the caller can use some names other than
2365 gcpro1, gcpro2, etc.
2366 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2367 of the new macros.
2368 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2369 argument, for consistency with GCPRO2_VAR, etc: it is now the
2370 prefix of the variable, not the variable itself. All uses
2371 changed.
2372 * dired.c (directory_files_internal, file_name_completion):
2373 Rename locals to avoid shadowing.
2374
2375 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2376 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2377 dired.c's scmp function, had undefined behavior.
2378 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2379 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2380 * buffer.h: ... to here, because these macros use current_buffer,
2381 and the new implementation with inline functions needs to have
2382 current_buffer in scope now, rather than later when the macros
2383 are used.
2384 (downcase, upcase1): New static inline functions.
2385 (DOWNCASE, UPCASE1): Reimplement using these functions.
2386 This avoids undefined behavior in expressions like
2387 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2388 from race conditions in accessing the global variables
2389 case_temp1 and case_temp2.
2390 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2391 * lisp.h (case_temp1, case_temp2): Remove their decls.
2392 * character.h (ASCII_CHAR_P): Move from here ...
2393 * lisp.h: ... to here, so that the inline functions mentioned
2394 above can use them.
2395
2396 * dired.c (directory_files_internal_unwind): Now static.
2397
2398 * fileio.c (file_name_as_directory, directory_file_name):
2399 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2400 Now static.
2401 (file_name_as_directory): Use const pointers when appropriate.
2402 (Fexpand_file_name): Likewise. In particular, newdir might
2403 point at constant storage, so make it a const pointer.
2404 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2405 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2406 signedness issues.
2407 (Fset_file_times, Finsert_file_contents, auto_save_error):
2408 Rename locals to avoid shadowing.
2409
2410 * minibuf.c (choose_minibuf_frame_1): Now static.
2411 (Ftry_completion, Fall_completions): Rename or remove locals
2412 to avoid shadowing.
2413
2414 * marker.c (bytepos_to_charpos): Remove; unused.
2415
2416 * lisp.h (verify_bytepos, count_markers): New decls,
2417 so that gcc does not warn that these functions aren't declared.
2418
2419 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2420 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2421 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2422 (copy_text): Remove unused local var.
2423
2424 * filelock.c (within_one_second): Now static.
2425 (lock_file_1): Rename local to avoid shadowing.
2426
2427 * buffer.c (fix_overlays_before): Mark locals as initialized.
2428 (fix_start_end_in_overlays): Likewise. This function should be
2429 simplified by using pointers-to-pointers, but that's a different
2430 matter.
2431 (switch_to_buffer_1): Now static.
2432 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2433 (report_overlay_modification): Rename locals to avoid shadowing.
2434
2435 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2436 Fix pointer signedness issue.
2437 (sys_subshell): Mark local as volatile if checking for lint,
2438 to suppress a gcc -Wclobbered warning that does not seem to be right.
2439 (MAXPATHLEN): Define only if needed.
2440
2441 * process.c (serial_open, serial_configure): Move decls from here ...
2442 * systty.h: ... to here, so that they can be checked.
2443
2444 * fns.c (get_random, seed_random): Move extern decls from here ...
2445 * lisp.h: ... to here, so that they can be checked.
2446
2447 * sysdep.c (reset_io): Now static.
2448 (wait_for_termination_signal): Remove; unused.
2449
2450 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2451 (copy_keymap_item, append_key, push_text_char_description):
2452 Now static.
2453 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2454 (DENSE_TABLE_SIZE): Remove; unused.
2455 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2456 (describe_map_tree):
2457 Rename locals to avoid shadowing.
2458
2459 * keyboard.c: Declare functions static if they are not used elsewhere.
2460 (echo_char, echo_dash, cmd_error, top_level_2):
2461 (poll_for_input, handle_async_input): Now static.
2462 (read_char, kbd_buffer_get_event, make_lispy_position):
2463 (make_lispy_event, make_lispy_movement, apply_modifiers):
2464 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2465 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2466 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2467 (read_key_sequence, read_char): Mark locals as initialized.
2468 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2469
2470 * keyboard.h (make_ctrl_char): New decl.
2471 (mark_kboards): Move decl here ...
2472 * alloc.c (mark_kboards): ... from here.
2473
2474 * lisp.h (force_auto_save_soon): New decl.
2475
2476 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2477 (DEFINE_DUMMY_FUNCTION): New macro.
2478 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2479 Use it.
2480 (main): Add casts to avoid warnings
2481 if GCC considers string literals to be constants.
2482
2483 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2484
2485 * dbusbind.c: Pointer signedness fixes.
2486 (xd_signature, xd_append_arg, xd_initialize):
2487 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2488 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2489 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2490 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2491
2492 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2493 if GCC considers string literals to be constants.
2494 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2495
2496 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2497
2498 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2499 (print_preprocess, print_object): New macro to fix last change.
2500
2501 * print.c (print_preprocess): Don't forget font objects.
2502
2503 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * emacs.c (USAGE3): Doc fixes.
2506
2507 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2508
2509 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2510 structure.
2511
2512 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2513
2514 * lisp.h (VWindow_system, Qfile_name_history):
2515 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2516 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2517 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2518
2519 * w32select.c: Don't #include "keyboard.h".
2520 (run_protected): Add extern declaration for waiting_for_input.
2521
2522 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2523 * w32console.c (detect_input_pending, read_input_pending)
2524 (encode_terminal_code):
2525 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2526 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2527 (w32_system_caret_y, Qfile_name_history):
2528 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2529 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2530 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2531 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2532 * w32proc.c (Qlocal, report_file_error):
2533 * w32term.c (Vwindow_system, updating_frame):
2534 * w32uniscribe.c (initialized, uniscribe_font_driver):
2535 Remove unneeded extern declarations.
2536
2537 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2538
2539 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2540
2541 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2544 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2545 These macros can no longer be used for assignment.
2546
2547 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2548 Assign struct members directly, instead of using BUF_BEGV etc.
2549 (record_buffer_markers, fetch_buffer_markers): New functions for
2550 recording and fetching special buffer markers.
2551 (set_buffer_internal_1, set_buffer_temp): Use them.
2552
2553 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2554
2555 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2556
2557 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2558 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2559
2560 * xdisp.c (hscroll_window_tree):
2561 (reconsider_clip_changes): Use PT instead of BUF_PT.
2562
2563 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2564
2565 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2566 $(EMACS_ROOT)/lib/intprops.h.
2567
2568 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 Fix more problems found by GCC 4.5.2's static checks.
2571
2572 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2573 to unsigned char * to avoid compiler diagnostic.
2574 (xg_free_frame_widgets): Make it clear that a local variable is
2575 needed only if USE_GTK_TOOLTIP.
2576 (gdk_window_get_screen): Make it clear that this macro is needed
2577 only if USE_GTK_TOOLTIP.
2578 (int_gtk_range_get_value): New function, which avoids a diagnostic
2579 from gcc -Wbad-function-cast.
2580 (xg_set_toolkit_scroll_bar_thumb): Use it.
2581 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2582 diagnostic from gcc -Wbad-function-cast.
2583 (get_utf8_string, xg_get_file_with_chooser):
2584 Rename locals to avoid shadowing.
2585 (create_dialog): Move locals to avoid shadowing.
2586
2587 * xgselect.c (xg_select): Remove unused var.
2588
2589 * image.c (four_corners_best): Mark locals as initialized.
2590 (gif_load): Initialize transparent_p to zero (Bug#8238).
2591 Mark another local as initialized.
2592 (my_png_error, my_error_exit): Mark with NO_RETURN.
2593
2594 * image.c (clear_image_cache): Now static.
2595 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2596 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2597 (x_edge_detection): Remove unnecessary cast that
2598 gcc -Wbad-function-cast diagnoses.
2599 (gif_load): Fix pointer signedness.
2600 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2601 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2602
2603 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 Improve quality of tests for time stamp overflow.
2606 For example, without this patch (encode-time 0 0 0 1 1
2607 1152921504606846976) returns the obviously-bogus value (-948597
2608 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2609 reports time overflow. See
2610 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2611 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2612 * editfns.c: Include limits.h and intprops.h.
2613 (TIME_T_MIN, TIME_T_MAX): New macros.
2614 (time_overflow): Move earlier, to before first use.
2615 (hi_time, lo_time): New functions, for an accurate test for
2616 out-of-range times.
2617 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2618 (Fget_internal_run_time): Don't assume time_t fits in int.
2619 (make_time): Use list2 instead of Fcons twice.
2620 (Fdecode_time): More accurate test for out-of-range times.
2621 (check_tm_member): New function.
2622 (Fencode_time): Use it, to test for out-of-range times.
2623 (lisp_time_argument): Don't rely on undefined left-shift and
2624 right-shift behavior when checking for time stamp overflow.
2625
2626 * editfns.c (time_overflow): New function, refactoring common code.
2627 (Fformat_time_string, Fdecode_time, Fencode_time):
2628 (Fcurrent_time_string): Use it.
2629
2630 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2631 * dired.c (make_time): Move to ...
2632 * editfns.c (make_time): ... here.
2633 * systime.h: Note the move.
2634
2635 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2636
2637 * fringe.c (update_window_fringes): Remove unused variables.
2638
2639 * unexmacosx.c (copy_data_segment): Also copy __got section.
2640 (Bug#8223)
2641
2642 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2643
2644 * termcap.c [MSDOS]: Include "msdos.h".
2645 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2646 Constify `char *' arguments and their references according to
2647 prototypes in tparam.h.
2648
2649 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2650
2651 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2652 Adapt all references accordingly.
2653
2654 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2655
2656 2011-03-11 Tom Tromey <tromey@redhat.com>
2657
2658 * buffer.c (syms_of_buffer): Remove obsolete comment.
2659
2660 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2661
2662 * termhooks.h (encode_terminal_code): Declare prototype.
2663
2664 * msdos.c (encode_terminal_code): Don't declare prototype.
2665
2666 * term.c (encode_terminal_code): Now external again, used by
2667 w32console.c and msdos.c.
2668
2669 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2670 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2671
2672 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 Fix some minor problems found by GCC 4.5.2's static checks.
2675
2676 * fringe.c (update_window_fringes): Mark locals as initialized
2677 (Bug#8227).
2678 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2679
2680 * alloc.c (mark_fringe_data): Move decl from here ...
2681 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2682 to check its interface.
2683 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2684
2685 * fontset.c (free_realized_fontset): Now static.
2686 (Fset_fontset_font): Rename local to avoid shadowing.
2687 (fontset_font): Mark local as initialized.
2688 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2689
2690 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2691
2692 * xselect.c (x_disown_buffer_selections): Remove; not used.
2693 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2694 (x_own_selection, Fx_disown_selection_internal): Rename locals
2695 to avoid shadowing.
2696 (x_handle_dnd_message): Remove local to avoid shadowing.
2697
2698 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2699 so that the caller can use some name other than gcpro1.
2700 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2701 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2702 (Fx_backspace_delete_keys_p):
2703 Use them to avoid shadowing, and rename vars to avoid shadowing.
2704 (x_decode_color, x_set_name, x_window): Now static.
2705 (Fx_create_frame): Add braces to silence GCC warning.
2706 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2707 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2708 Remove unused locals.
2709 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2710 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2711 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2712 macros.
2713
2714 * xterm.h (x_mouse_leave): New decl.
2715
2716 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2717 Remove unused functions.
2718 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2719 (x_calc_absolute_position): Now static.
2720 (XTread_socket): Don't define label "out" unless it's used.
2721 Don't declare local "event" unless it's used.
2722 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2723 unless they are used.
2724 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2725 (x_fatal_error_signal): Remove; not used.
2726 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2727 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2728 (x_error_catcher, x_connection_closed, x_error_handler):
2729 (x_error_quitter, xembed_send_message, x_iconify_frame):
2730 (my_log_handler): Rename locals to avoid shadowing.
2731 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2732 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2733
2734 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2735 Rename or move locals to avoid shadowing.
2736 (tty_defined_color, merge_face_heights): Now static.
2737 (free_realized_faces_for_fontset): Remove; not used.
2738 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2739 does not deduce is never used uninitialized.
2740 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2741 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2742
2743 * terminal.c (store_terminal_param): Now static.
2744
2745 * xmenu.c (menu_highlight_callback): Now static.
2746 (set_frame_menubar): Remove unused local.
2747 (xmenu_show): Rename parameter to avoid shadowing.
2748 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2749 since they might point to immutable storage.
2750 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2751 since it's unused otherwise.
2752
2753 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2754 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2755 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2756 avoids a gcc -Wuninitialized diagnostic.
2757 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2758 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2759 does not deduce are never used uninitialized.
2760
2761 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2762
2763 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2764 * window.c (window_loop, size_window):
2765 (run_window_configuration_change_hook, enlarge_window): Likewise.
2766
2767 * window.c (display_buffer): Now static.
2768 (size_window): Mark variables that gcc -Wuninitialized
2769 does not deduce are never used uninitialized.
2770 * window.h (check_all_windows): New decl, to forestall
2771 gcc -Wmissing-prototypes diagnostic.
2772 * dispextern.h (bidi_dump_cached_states): Likewise.
2773
2774 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2775 shadowing.
2776 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2777 Include <limits.h>.
2778 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2779 and to avoid gcc -Wuninitialized warning.
2780 (load_charset_map): Mark variables that gcc -Wuninitialized
2781 does not deduce are never used uninitialized.
2782 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2783
2784 * coding.c (coding_set_source, coding_set_destination):
2785 Use "else { /* comment */ }" rather than "else /* comment */;"
2786 for clarity, and to avoid gcc -Wempty-body warning.
2787 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2788 a block, when the outer 'i' will do.
2789 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2790 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2792 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2793 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2794 Rename locals to avoid shadowing.
2795 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2796 * coding.c (emacs_mule_char, encode_invocation_designation):
2797 Now static, since they're not used elsewhere.
2798 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2799 (decode_coding_object, encode_coding_object, detect_coding_system):
2800 (decode_coding_emacs_mule): Mark variables that gcc
2801 -Wuninitialized does not deduce are never used uninitialized.
2802 (detect_coding_iso_2022): Initialize a local variable that might
2803 be used uninitialized. Leave a FIXME because it's not clear that
2804 this initialization is needed. (Bug#8211)
2805 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2806 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2807 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2808 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2809 Remove unused macros.
2810
2811 * category.c (hash_get_category_set): Remove unused local var.
2812 (copy_category_table): Now static, since it's not used elsewhere.
2813 * character.c (string_count_byte8): Likewise.
2814
2815 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2816 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2817
2818 * chartab.c (copy_sub_char_table): Now static, since it's not used
2819 elsewhere.
2820 (sub_char_table_ref_and_range, char_table_ref_and_range):
2821 Rename locals to avoid shadowing.
2822 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2823
2824 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2825 (BIDI_BOB): Remove unused macro.
2826
2827 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2828 deduce are never used uninitialized.
2829 * term.c (encode_terminal_code): Likewise.
2830
2831 * term.c (encode_terminal_code): Now static. Remove unused local.
2832
2833 * tparam.h: New file.
2834 * term.c, tparam.h: Include it.
2835 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2836 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2837 Move these decls to tparam.h, and make them agree with what
2838 is actually in tparam.c. The previous trick of using incompatible
2839 decls in different modules does not conform to the C standard.
2840 All callers of tparam changed to use tparam's actual API.
2841 * tparam.c (tparam1, tparam, tgoto):
2842 Use const pointers where appropriate.
2843
2844 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2845 * cm.h (struct cm): Likewise.
2846 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2847 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2848 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2849 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2850 (turn_on_face, init_tty): Likewise.
2851 * termchar.h (struct tty_display_info): Likewise.
2852
2853 * term.c (term_mouse_position): Rename local to avoid shadowing.
2854
2855 * alloc.c (mark_ttys): Move decl from here ...
2856 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2857
2858 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2859
2860 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2861
2862 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * search.c (compile_pattern_1): Remove argument regp, unused since
2865 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2866 (compile_pattern): Don't pass it.
2867
2868 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2869
2870 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2871 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2872 for ! HAVE_GTK3.
2873 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2874
2875 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2876
2877 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2878 gdk_window_get_screen, gdk_window_get_geometry,
2879 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2880 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2881 (xg_get_pixbuf_from_pixmap): New function.
2882 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2883 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2884 Call xg_get_pixbuf_from_pixmap instead of
2885 gdk_pixbuf_get_from_drawable.
2886 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2887 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2888 (xg_check_special_colors): Use GtkStyleContext and its functions
2889 for HAVE_GTK3.
2890 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2891 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2892 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2893 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2894 Call gtk_widget_get_preferred_size.
2895 (xg_frame_resized): gdk_window_get_geometry only takes 5
2896 parameters.
2897 (xg_win_to_widget, xg_event_is_for_menubar):
2898 Call gdk_x11_window_lookup_for_display.
2899 (xg_set_widget_bg): New function.
2900 (delete_cb): New function.
2901 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2902 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2903 (xg_set_background_color): Call xg_set_widget_bg.
2904 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2905 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2906 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2907 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2908 if ! HAVE_GTK3.
2909 (update_frame_tool_bar): Call gtk_widget_hide.
2910 (xg_initialize): Use GDK_KEY_g.
2911
2912 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2913 if ! HAVE_GTK3
2914 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2915
2916 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2917 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2918 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2919
2920 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * w32xfns.c (select_palette): Check success of RealizePalette against
2923 GDI_ERROR, not zero.
2924
2925 See ChangeLog.11 for earlier changes.
2926
2927 ;; Local Variables:
2928 ;; coding: utf-8
2929 ;; End:
2930
2931 Copyright (C) 2011 Free Software Foundation, Inc.
2932
2933 This file is part of GNU Emacs.
2934
2935 GNU Emacs is free software: you can redistribute it and/or modify
2936 it under the terms of the GNU General Public License as published by
2937 the Free Software Foundation, either version 3 of the License, or
2938 (at your option) any later version.
2939
2940 GNU Emacs is distributed in the hope that it will be useful,
2941 but WITHOUT ANY WARRANTY; without even the implied warranty of
2942 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2943 GNU General Public License for more details.
2944
2945 You should have received a copy of the GNU General Public License
2946 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.