1 2011-05-03 Paul Eggert <eggert@cs.ucla.edu>
3 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6 * charset.c (Fdefine_charset_internal): Don't initialize
7 charset.code_space[15]. The value was garbage, on hosts with
10 * lread.c (read_integer): Be more consistent with string-to-number.
11 Use string_to_number to do the actual conversion; this avoids
12 rounding errors and fixes some other screwups. Without this fix,
13 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14 (digit_to_number): Move earlier, for benefit of read_integer.
15 Return -1 if the digit is out of range for the base, -2 if it is
16 not a digit in any supported base. (Bug#8602)
18 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
20 * dispnew.c (scrolling_window): Return 1 if we scrolled,
21 to match comment at start of function. This also removes a
22 GCC warning about overflow in a 32+64-bit port.
24 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
26 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
27 Reported by Stefan Monnier in
28 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
29 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
30 SYMBOLP-guarded XSYMBOL, not XPNTR.
32 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
33 (EMACS_UINTPTR): Likewise, with uintptr_t.
35 * lisp.h: Prefer 64-bit EMACS_INT if available.
36 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
37 on 32-bit hosts that have 64-bit int, so that they can access
40 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
42 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
43 This removes an assumption that EMACS_INT and long are the same
44 width as pointers. The assumption is true for Emacs porting targets
45 now, but we want to make other targets possible.
46 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
47 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
48 In the rest of the code, change types of integers that hold casted
49 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
50 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
51 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
52 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
53 No need to cast type when ORing.
54 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
55 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
56 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
57 assume EMACS_INT is the same width as char *.
58 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
59 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
60 Remove no-longer-needed casts.
61 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
62 (xg_tool_bar_help_callback, xg_make_tool_item):
63 Use EMACS_INTPTR to hold an integer
64 that will be cast to void *; this can avoid a GCC warning
65 if EMACS_INT is not the same width as void *.
66 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
67 * xdisp.c (display_echo_area_1, resize_mini_window_1):
68 (current_message_1, set_message_1):
69 Use a local to convert to proper width without a cast.
70 * xmenu.c (dialog_selection_callback): Likewise.
72 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
73 Also, don't assume VALBITS / RAND_BITS is less than 5,
74 and don't rely on undefined behavior when shifting a 1 left into
76 * lisp.h (get_random): Change signature to match.
78 * lread.c (hash_string): Use size_t, not int, for hash computation.
79 Normally we prefer signed values; but hashing is special, because
80 it's better to use unsigned division on hash table sizes so that
81 the remainder is nonnegative. Also, size_t is the natural width
82 for hashing into memory. The previous code used 'int', which doesn't
83 retain enough info to hash well into very large tables.
84 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
86 * dbusbind.c: Don't possibly lose pointer info when converting.
87 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
88 Use XPNTR rather than XHASH, so that the high-order bits of
89 the pointer aren't lost when converting through void *.
91 * eval.c (Fautoload): Don't double-shift a pointer.
93 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
95 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
97 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
99 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
101 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
102 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
103 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
104 (gnutls_global_initialized, Qgnutls_bootprop_priority)
105 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
106 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
107 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
108 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
109 (Qgnutls_bootprop_callbacks_verify): Make static.
111 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
113 * callproc.c: Indentation fixup.
115 * sysdep.c (wait_for_termination_1): Make static.
116 (wait_for_termination, interruptible_wait_for_termination): Move
117 after wait_for_termination_1.
119 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
121 * sysdep.c (interruptible_wait_for_termination): New function
122 which is like wait_for_termination, but allows keyboard
125 * callproc.c (Fcall_process): Add (:file "file") as an option for
127 (Fcall_process_region): Ditto.
129 2011-04-30 Eli Zaretskii <eliz@gnu.org>
131 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
132 rather than `XVECTOR (FOO)->size'.
134 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
135 inttypes.h, as a gnulib replacement is used if it not available in
138 2011-04-21 Eli Zaretskii <eliz@gnu.org>
140 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
141 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
142 of MOST_POSITIVE_FIXNUM. (Bug#8528)
144 * coding.c (coding_alloc_by_realloc): Error out if destination
145 will grow beyond MOST_POSITIVE_FIXNUM.
146 (decode_coding_emacs_mule): Abort if there isn't enough place in
147 charbuf for the composition carryover bytes. Reserve an extra
148 space for up to 2 characters produced in a loop.
149 (decode_coding_iso_2022): Abort if there isn't enough place in
150 charbuf for the composition carryover bytes.
152 2011-04-21 Eli Zaretskii <eliz@gnu.org>
154 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
155 aborting when %lld or %lll format is passed.
156 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
157 %llo or %llx format is passed. (Bug#8545)
159 * window.c (window_scroll_line_based): Use a marker instead of
160 simple variables to record original value of point. (Bug#7952)
162 * doprnt.c (doprnt): Fix the case where a multibyte sequence
163 produced by %s or %c overflows available buffer space. (Bug#8545)
165 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
167 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
168 (SIZE_MAX): Move defn after all includes, as they might #define it.
170 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
172 * w32.c (init_environment): Warn about defaulting HOME to C:\.
174 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
176 * keyboard.c (Qdelayed_warnings_hook): Define.
177 (command_loop_1): Run `delayed-warnings-hook'
178 if Vdelayed_warnings_list is non-nil.
179 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
180 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
182 2011-04-28 Eli Zaretskii <eliz@gnu.org>
184 * doprnt.c (doprnt): Don't return value smaller than the buffer
185 size if the message was truncated. (Bug#8545).
187 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
189 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
190 (Fx_window_property): #if-0 the whole functions, not just the bodies.
192 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
194 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
196 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
198 * makefile.w32-in: Update dependencies.
200 2011-04-27 Eli Zaretskii <eliz@gnu.org>
202 Improve `doprnt' and its usage. (Bug#8545)
203 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
204 `format_end'. Remove support for %l as a conversion specifier.
205 Don't use xrealloc. Improve diagnostics when the %l size modifier
206 is used. Update the commentary.
208 * eval.c (verror): Simplify calculation of size_t.
210 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
213 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
215 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
218 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
220 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
221 This makes this file independent of the recent pseudovector change.
223 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
225 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
227 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
228 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
230 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
232 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
233 GCC 4.6.0 optimizes based on type-based alias analysis. For
234 example, if b is of type struct buffer * and v of type struct
235 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
236 != &v->size, and therefore "v->size = 1; b->size = 2; return
237 v->size;" must therefore return 1. This assumption is incorrect
238 for Emacs, since it type-puns struct Lisp_Vector * with many other
239 types. To fix this problem, this patch adds a new type struct
240 vectorlike_header that documents the constraints on layout of vectors
241 and pseudovectors, and helps optimizing compilers not get fooled
242 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
243 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
244 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
246 (XSETPVECTYPE): Rewrite in terms of new macro.
247 (XSETPVECTYPESIZE): New macro, specifying both type and size.
248 This is a bit clearer, and further avoids the possibility of
249 undesirable aliasing.
250 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
251 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
252 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
253 since Lisp_Subr is a special case (no "next" field).
254 (ASIZE): Now uses header.size rather than size. All
255 previous uses of XVECTOR (foo)->size replaced to use this macro,
256 to avoid the hassle of writing XVECTOR (foo)->header.size.
257 (struct vectorlike_header): New type.
258 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
259 object, to help avoid aliasing.
260 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
261 (SUBRP): Likewise, since Lisp_Subr is a special case.
262 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
263 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
264 (struct Lisp_Hash_Table): Combine first two members into a single
265 struct vectorlike_header member. All uses of "size" and "next" members
266 changed to be "header.size" and "header.next".
267 * buffer.h (struct buffer): Likewise.
268 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
269 * frame.h (struct frame): Likewise.
270 * process.h (struct Lisp_Process): Likewise.
271 * termhooks.h (struct terminal): Likewise.
272 * window.c (struct save_window_data, struct saved_window): Likewise.
273 * window.h (struct window): Likewise.
274 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
275 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
276 * buffer.c (init_buffer_once): Likewise.
277 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
279 * process.c (Fformat_network_address): Use local var for size,
282 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
284 Make the Lisp reader and string-to-float more consistent (Bug#8525)
285 * data.c (atof): Remove decl; no longer used or needed.
286 (digit_to_number): Move to lread.c.
287 (Fstring_to_number): Use new string_to_number function, to be
288 consistent with how the Lisp reader treats infinities and NaNs.
289 Do not assume that floating-point numbers represent EMACS_INT
290 without losing information; this is not true on most 64-bit hosts.
291 Avoid double-rounding errors, by insisting on integers when
292 parsing non-base-10 numbers, as the documentation specifies.
293 * lisp.h (string_to_number): New decl, replacing ...
294 (isfloat_string): Remove.
295 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
296 (read1): Do not accept +. and -. as integers; this
297 appears to have been a coding error. Similarly, do not accept
298 strings like +-1e0 as floating point numbers. Do not report
299 overflow for integer overflows unless the base is not 10 which
300 means we have no simple and reliable way to continue.
301 Break out the floating-point parsing into a new
302 function string_to_number, so that Fstring_to_number parses
303 floating point numbers consistently with the Lisp reader.
304 (digit_to_number): Moved here from data.c. Make it static inline.
305 (E_CHAR, EXP_INT): Remove, replacing with ...
306 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
307 (string_to_number): New function, replacing isfloat_string.
308 This function checks for valid syntax and produces the resulting
309 Lisp float number too. Rework it so that string-to-number
310 no longer mishandles examples like "1.0e+". Use strtoumax,
311 so that overflow for non-base-10 numbers is reported only when
312 there's no portable and simple way to convert to floating point.
314 * textprop.c (set_text_properties_1): Rewrite for clarity,
315 and to avoid GCC warning about integer overflow.
317 * intervals.h (struct interval): Use EMACS_INT for members
318 where EMACS_UINT might cause problems. See
319 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
320 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
321 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
323 (offset_intervals): Tell GCC not to worry about length overflow
324 when negating a negative length.
326 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
327 (overrun_check_free): Likewise.
329 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
330 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
333 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
334 (gnutls_make_error): Rename local to avoid shadowing.
335 (gnutls_emacs_global_deinit): ifdef out; not used.
336 (Fgnutls_boot): Use const for pointer to readonly storage.
337 Comment out unused local. Fix pointer signedness problems.
339 * lread.c (openp): Don't stuff size_t into an 'int'.
340 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
341 about possible signed overflow.
343 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
344 (GDK_KEY_g): Don't define if already defined.
345 (xg_prepare_tooltip): Avoid pointer signedness problem.
346 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
348 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
349 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
351 * xfns.c (Fx_window_property): Simplify a bit,
352 to make a bit faster and to avoid GCC 4.6.0 warning.
353 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
355 * fns.c (internal_equal): Don't assume size_t fits in int.
357 * alloc.c (compact_small_strings): Tighten assertion a little.
359 Replace pEd with more-general pI, and fix some printf arg casts.
360 * lisp.h (pI): New macro, generalizing old pEd macro to other
361 conversion specifiers. For example, use "...%"pI"d..." rather
363 (pEd): Remove. All uses replaced with similar uses of pI.
364 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
365 * alloc.c (check_pure_size): Don't overflow by converting size to int.
366 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
367 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
368 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
369 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
370 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
372 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
373 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
374 * print.c (safe_debug_print, print_object): Likewise.
375 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
377 Use pI instead of if-then-else-abort. Use %p to avoid casts,
378 avoiding the 0 flag, which is not portable.
379 * process.c (Fmake_network_process): Use pI to avoid cast.
380 * region-cache.c (pp_cache): Likewise.
381 * xdisp.c (decode_mode_spec): Likewise.
382 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
383 behavior on 64-bit hosts with printf arg.
384 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
385 (x_stop_queuing_selection_requests): Likewise.
386 (x_get_window_property): Don't truncate byte count to an 'int'
389 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
390 here, since it parses constructs like leading '-' and spaces,
391 which are not wanted; and it overflows with large numbers.
392 Instead, simply match F[0-9]+, which is what is wanted anyway.
394 * alloc.c: Remove unportable assumptions about struct layout.
395 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
396 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
397 (allocate_vectorlike, make_pure_vector): Use the new macros,
398 plus offsetof, to remove unportable assumptions about struct layout.
399 These assumptions hold on all porting targets that I know of, but
400 they are not guaranteed, they're easy to remove, and removing them
401 makes further changes easier.
403 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
404 This doesn't fix a bug but makes the code clearer.
405 (string_overrun_cookie): Now const. Use initializers that
406 don't formally overflow signed char, to avoid warnings.
407 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
408 can cause Emacs to crash when string overrun checking is enabled.
409 (allocate_buffer): Don't assume sizeof (struct buffer) is a
410 multiple of sizeof (EMACS_INT); it need not be, if
411 alignof(EMACS_INT) < sizeof (EMACS_INT).
412 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
414 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
416 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
418 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
420 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
421 supposed to be handshaking. (Bug#8556)
422 Reported by Paul Eggert <eggert@cs.ucla.edu>.
424 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
426 * lisp.h (Qdebug): List symbol.
427 * eval.c (Qdebug): Restore global linkage.
428 * keyboard.c (debug-on-event): New variable.
429 (handle_user_signal): Break into debugger when debug-on-event
430 matches the current signal symbol.
432 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
434 * alloc.c (check_sblock, check_string_bytes)
435 (check_string_free_list): Convert to standard C.
437 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
439 * w32.c (emacs_gnutls_push): Fix typo.
441 2011-04-25 Eli Zaretskii <eliz@gnu.org>
443 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
444 "cast to pointer from integer of different size".
446 Improve doprnt and its use in verror. (Bug#8545)
447 * doprnt.c (doprnt): Document the set of format control sequences
448 supported by the function. Use SAFE_ALLOCA instead of always
451 * eval.c (verror): Don't limit the buffer size at size_max-1, that
452 is one byte too soon. Don't use xrealloc; instead xfree and
455 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
457 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
460 * gnutls.c: Renamed global_initialized to
461 gnutls_global_initialized. Added internals for the
462 :verify-hostname-error, :verify-error, and :verify-flags
463 parameters of `gnutls-boot' and documented those parameters in the
464 docstring. Start callback support.
465 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
466 unless a fatal error occured. Call gnutls_alert_send_appropriate
467 on error. Return error code.
468 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
469 (emacs_gnutls_read): Likewise.
470 (Fgnutls_boot): Return handshake error code.
471 (emacs_gnutls_handle_error): New function.
472 (wsaerror_to_errno): Likewise.
474 * w32.h (emacs_gnutls_pull): Add prototype.
475 (emacs_gnutls_push): Likewise.
477 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
478 (emacs_gnutls_push): Likewise.
480 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
482 * process.c (wait_reading_process_output): Check if GnuTLS
483 buffered some data internally if no FDs are set for TLS
486 * makefile.w32-in (OBJ2): Add gnutls.$(O).
487 (LIBS): Link to USER_LIBS.
488 ($(BLD)/gnutls.$(0)): New target.
490 2011-04-24 Eli Zaretskii <eliz@gnu.org>
492 * xdisp.c (handle_single_display_spec): Rename the
493 display_replaced_before_p argument into display_replaced_p, to
494 make it consistent with the commentary. Fix typos in the
497 * textprop.c (syms_of_textprop): Remove dead code.
498 (copy_text_properties): Delete obsolete commentary about an
499 interface that was deleted long ago. Fix typos in the description
502 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
503 to changes in oldXMenu/XMenu.h from 2011-04-16.
504 <menu_help_message, prev_menu_help_message>: Constify.
505 (IT_menu_make_room): menu->help_text is now `const char **';
508 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
509 to changes in oldXMenu/XMenu.h from 2011-04-16.
510 (struct XMenu): Declare `help_text' `const char **'.
512 * xfaces.c <Qunspecified>: Make extern again.
514 * syntax.c: Include sys/types.h before including regex.h, as
517 * doc.c (get_doc_string): Improve the format passed to `error'.
519 * doprnt.c (doprnt): Improve commentary.
521 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
523 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
526 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
527 changes in globals.h immediately force recompilation.
528 (TAGS): Depend on $(CURDIR)/m/intel386.h and
529 $(CURDIR)/s/ms-w32.h.
530 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
532 * character.c (Fchar_direction): Function deleted.
533 (syms_of_character): Don't defsubr it.
534 <char-direction-table>: Deleted.
536 2011-04-23 Eli Zaretskii <eliz@gnu.org>
538 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
539 * doprnt.c: Include limits.h.
540 (SIZE_MAX): New macro.
541 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
542 local variables are now size_t instead of int or unsigned.
543 Improve overflow protection. Support `l' modifier for integer
544 conversions. Support %l conversion. Don't assume an EMACS_INT
545 argument for integer conversions and for %c.
547 * lisp.h (doprnt): Restore prototype.
549 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
552 * Makefile.in (base_obj): Add back doprnt.o.
554 * deps.mk (doprnt.o): Add back prerequisites.
555 (callint.o): Depend on character.h.
557 * eval.c (internal_lisp_condition_case): Include the handler
558 representation in the error message.
559 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
560 when breaking from the loop.
562 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
564 * callint.c (Fcall_interactively): When displaying error message
565 about invalid control letter, pass the character's codepoint, not
566 a pointer to its multibyte form. Improve display of the character
567 in octal and display also its hex code.
569 * character.c (char_string): Use %x to display the (unsigned)
570 codepoint of an invalid character, to avoid displaying a bogus
573 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
574 `error', not SYMBOL_NAME itself.
576 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
577 character arguments to `error'.
579 * charset.c (check_iso_charset_parameter): Fix incorrect argument
580 to `error' in error message about FINAL_CHAR argument. Make sure
581 FINAL_CHAR is a character, and use %c when it is passed as
584 2011-04-23 Eli Zaretskii <eliz@gnu.org>
586 * s/ms-w32.h (localtime): Redirect to sys_localtime.
588 * w32.c: Include <time.h>.
589 (sys_localtime): New function.
591 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
593 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
595 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
597 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
599 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
602 2011-04-19 Eli Zaretskii <eliz@gnu.org>
604 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
605 gl_state.e_property when gl_state.object is Qt.
607 * insdel.c (make_gap_larger): Remove limitation of buffer size
610 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
612 * xdisp.c (lookup_glyphless_char_display)
613 (produce_glyphless_glyph): Handle cons cell entry in
614 glyphless-char-display.
615 (Vglyphless_char_display): Document it.
617 * term.c (produce_glyphless_glyph): Handle cons cell entry in
618 glyphless-char-display.
620 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
622 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
624 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
626 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
627 definition for no-X builds.
629 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
631 Static checks with GCC 4.6.0 and non-default toolkits.
633 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
635 * process.c (keyboard_bit_set): Define only if SIGIO.
636 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
637 (send_process): Repair possible setjmp clobbering.
639 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
641 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
643 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
645 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
646 Define only if needed.
648 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
649 by pacifying GCC about it. Maybe it's time to retire it?
650 * xfaces.c (USG, __TIMEVAL__): Likewise.
652 * dispextern.h (struct redisplay_interface): Rename param
654 * termhooks.h (struct terminal): Likewise.
655 * xterm.c (xembed_send_message): Likewise.
657 * insdel.c (make_gap_smaller): Define only if
658 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
660 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
663 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
664 so that we aren't warned about unused symbols.
666 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
668 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
670 * xfns.c (x_real_positions): Mark locals as initialized.
672 * xmenu.c (xmenu_show): Don't use uninitialized vars.
674 * xterm.c: Fix problems found by static analysis with other toolkits.
675 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
676 (x_dispatch_event): Declare static if USE_GTK, and
677 define if USE_GTK || USE_X_TOOLKIT.
678 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
679 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
680 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
681 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
683 * xmenu.c (menu_help_callback): Pointer type fixes.
684 Use const pointers when pointing at readonly data. Avoid pointer
686 (FALSE): Remove unused macro.
687 (update_frame_menubar): Remove unused decl.
689 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
691 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
692 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
693 (single_menu_item): Rename local to avoid shadowing.
695 * keyboard.c (make_lispy_event): Remove unused local var.
697 * frame.c, frame.h (x_get_resource_string): Bring this back, but
698 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
700 * bitmaps: Change bitmaps from unsigned char back to the X11
701 compatible char. Avoid the old compiler warnings about
702 out-of-range initializers by using, for example, '\xab' rather
705 * xgselect.c (xgselect_initialize): Check vs interface
706 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
708 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
710 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
713 * fns.c (vector): Remove; this old hack is no longer needed.
715 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
717 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
719 * xrdb.c (x_load_resources): Omit unused local.
721 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
722 (x_window): Rename locals to avoid shadowing.
723 (USG): Use the kludged USG macro, to pacify gcc.
725 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
726 (x_term_init): Remove local to avoid shadowing.
728 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
730 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
731 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
733 2011-04-16 Eli Zaretskii <eliz@gnu.org>
735 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
737 Fix regex.c, syntax.c and friends for buffers > 2GB.
738 * syntax.h (struct gl_state_s): Declare character position members
741 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
743 * textprop.c (verify_interval_modification, interval_of): Declare
746 * intervals.c (adjust_intervals_for_insertion): Declare arguments
749 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
751 * indent.c (Fvertical_motion): Local variable it_start is now
754 * regex.c (re_match, re_match_2, re_match_2_internal)
755 (bcmp_translate, regcomp, regexec, print_double_string)
756 (group_in_compile_stack, re_search, re_search_2, regex_compile)
757 (re_compile_pattern, re_exec): Declare arguments and local
758 variables `size_t' and `ssize_t' and return values `regoff_t', as
760 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
761 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
762 <compile_stack_type>: `size' and `avail' are now `size_t'.
764 * regex.h <regoff_t>: Use ssize_t, not int.
765 (re_search, re_search_2, re_match, re_match_2): Arguments that
766 specify buffer/string position and length are now ssize_t and
767 size_t. Return type is regoff_t.
769 2011-04-16 Ben Key <bkey76@gmail.com>
771 * nsfont.m: Fixed bugs in ns_get_family and
772 ns_descriptor_to_entity that were caused by using free to
773 deallocate memory blocks that were allocated by xmalloc (via
774 xstrdup). This caused Emacs to crash when compiled with
775 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
776 --enable-checking=xmallocoverrun). xfree is now used to
777 deallocate these memory blocks.
779 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
781 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
783 emacs_write: Accept and return EMACS_INT for sizes.
784 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
786 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
787 Accept and return EMACS_INT.
788 (emacs_gnutls_write): Return the number of bytes written on
790 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
791 (emacs_read, emacs_write): Remove check for negative size, as the
792 Emacs source code has been audited now.
793 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
794 (emacs_read, emacs_write): Use it.
795 * process.c (send_process): Adjust to the new signatures of
796 emacs_write and emacs_gnutls_write. Do not attempt to store
797 a byte offset into an 'int'; it might overflow.
798 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
800 * sound.c: Don't assume sizes fit in 'int'.
801 (struct sound_device.period_size, alsa_period_size):
802 Return EMACS_INT, not int.
803 (struct sound_device.write, vox_write, alsa_write):
804 Accept EMACS_INT, not int.
805 (wav_play, au_play): Use EMACS_INT to store sizes and to
806 record read return values.
808 2011-04-15 Ben Key <bkey76@gmail.com>
810 * keyboard.c (Qundefined): Don't declare static since it is used
812 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
813 static since they are used in nsfont.m.
815 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
817 * process.c (Qprocessp): Don't declare static.
818 * lisp.h (Qprocessp): Declare again.
820 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
822 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
824 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
826 Improve C-level modularity by making more things 'static'.
828 Don't publish debugger-only interfaces to other modules.
829 * lisp.h (safe_debug_print, debug_output_compilation_hack):
830 (verify_bytepos, count_markers): Move decls to the only modules
832 * region-cache.h (pp_cache): Likewise.
833 * window.h (check_all_windows): Likewise.
834 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
836 * sysdep.c (croak): Now static, if
837 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
838 * syssignal.h (croak): Declare only if not static.
840 * alloc.c (refill_memory_reserve): Now static if
841 !defined REL_ALLOC || defined SYSTEM_MALLOC.
842 * lisp.h (refill_memory_reserve): Declare only if not static.
844 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
845 Define only if USE_LUCID.
847 * xrdb.c (x_customization_string, x_rm_string): Now static.
849 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
850 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
852 * xdisp.c (draw_row_with_mouse_face): Now static.
853 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
855 * window.h (check_all_windows): Mark externally visible.
857 * window.c (window_deletion_count): Now static.
859 * undo.c: Make symbols static if they're not exported.
860 (last_undo_buffer, last_boundary_position, pending_boundary):
863 * textprop.c (interval_insert_behind_hooks): Now static.
864 (interval_insert_in_front_hooks): Likewise.
866 * term.c: Make symbols static if they're not exported.
867 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
868 (max_frame_lines, tty_set_terminal_modes):
869 (tty_reset_terminal_modes, tty_turn_off_highlight):
870 (get_tty_terminal): Now static.
871 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
872 * termhooks.h (term_mouse_moveto): Do not declare if
874 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
875 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
877 * sysdep.c: Make symbols static if they're not exported.
878 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
880 (sigprocmask_set, full_mask): Remove; unused.
881 (wait_debugging): Mark as visible.
882 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
883 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
885 * syntax.c (syntax_temp): Define only if !__GNUC__.
887 * sound.c (current_sound_device, current_sound): Now static.
889 * search.c (searchbufs, searchbuf_head): Now static.
891 * scroll.c (scroll_cost): Remove; unused.
892 * dispextern.h (scroll_cost): Remove decl.
894 * region-cache.h (pp_cache): Mark as externally visible.
896 * process.c: Make symbols static if they're not exported.
897 (process_tick, update_tick, create_process, chan_process):
898 (Vprocess_alist, proc_buffered_char, datagram_access):
899 (fd_callback_data, send_process_frame, process_sent_to): Now static.
900 (deactivate_process): Mark defn as static, as well as decl.
901 * lisp.h (create_process): Remove decl.
902 * process.h (chan_process, Vprocess_alist): Remove decls.
904 * print.c: Make symbols static if they're not exported.
905 (print_depth, new_backquote_output, being_printed, print_buffer):
906 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
907 (print_interval, print_number_index, initial_stderr_stream):
909 * lisp.h (Fprinc): Remove decl.
910 (debug_output_compilation_hack): Mark as externally visible.
912 * sysdep.c (croak): Move decl from here to syssignal.h.
913 * syssignal.h (croak): Put it here, so the API can be checked when
914 'croak' is called from dissociate_if_controlling_tty.
916 * minibuf.c: Make symbols static if they're not exported.
917 (minibuf_save_list, choose_minibuf_frame): Now static.
918 * lisp.h (choose_minibuf_frame): Remove decl.
920 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
922 * lread.c: Make symbols static if they're not exported.
923 (read_objects, initial_obarray, oblookup_last_bucket_number):
925 (make_symbol): Remove; unused.
926 * lisp.h (initial_obarray, make_symbol): Remove decls.
928 * keyboard.c: Make symbols static if they're not exported.
929 (single_kboard, recent_keys_index, total_keys, recent_keys):
930 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
931 (this_single_command_key_start, echoing, last_auto_save):
932 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
933 (command_loop, echo_now, keyboard_init_hook, help_char_p):
934 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
935 (Vlispy_mouse_stem, double_click_count):
937 (force_auto_save_soon): Define only if SIGDANGER.
938 (ignore_mouse_drag_p): Now static if
939 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
940 (print_help): Remove; unused.
941 (stop_character, last_timer_event): Mark as externally visible.
942 * keyboard.h (ignore_mouse_drag_p): Declare only if
943 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
944 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
945 * lisp.h (echoing): Remove decl.
946 (force_auto_save_soon): Declare only if SIGDANGER.
947 * xdisp.c (redisplay_window): Simplify code, to make it more
948 obvious that ignore_mouse_drag_p is not accessed if !defined
949 USE_GTK && !defined HAVE_NS.
951 * intervals.c: Make symbols static if they're not exported.
952 (merge_properties_sticky, merge_interval_right, delete_interval):
954 * intervals.h (merge_interval_right, delete_interval): Remove decls.
956 * insdel.c: Make symbols static if they're not exported.
957 However, leave prepare_to_modify_buffer alone. It's never
958 called from outside this function, but that appears to be a bug.
959 (combine_after_change_list, combine_after_change_buffer):
960 (adjust_after_replace, signal_before_change): Now static.
961 (adjust_after_replace_noundo): Remove; unused.
962 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
963 (signal_before_change): Remove decls.
965 * indent.c (val_compute_motion, val_vmotion): Now static.
967 * image.c: Make symbols static if they're not exported.
968 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
970 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
971 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
973 * fringe.c (standard_bitmaps): Now static.
974 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
976 * frame.c: Make symbols static if they're not exported.
977 (x_report_frame_params, make_terminal_frame): Now static.
978 (get_frame_param): Now static, unless HAVE_NS.
979 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
980 (x_get_resource_string): Remove; not used.
981 * frame.h (make_terminal_frame, x_report_frame_params):
982 (x_get_resource_string); Remove decls.
983 (x_fullscreen_adjust): Declare only if WINDOWSNT.
984 * lisp.h (get_frame_param): Declare only if HAVE_NS.
986 * font.c, fontset.c: Make symbols static if they're not exported.
987 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
988 (FACE_SUITABLE_FOR_CHAR_P): Use it.
989 * font.c (font_close_object): Now static.
990 * font.h (font_close_object): Remove.
991 * fontset.c (FONTSET_OBJLIST): Remove.
992 (free_realized_fontset) #if-0 the body, which does nothing.
993 (face_suitable_for_char_p): #if-0, as it's never called.
994 * fontset.h (face_suitable_for_char_p): Remove decl.
995 * xfaces.c (face_at_string_position): Use
996 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
997 since 0 is always ASCII.
999 * fns.c (weak_hash_tables): Now static.
1001 * fileio.c: Make symbols static if they're not exported.
1002 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1003 (Vwrite_region_annotation_buffers): Now static.
1005 * eval.c: Make symbols static if they're not exported.
1006 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1007 * lisp.h (backtrace_list): Remove decl.
1009 * emacs.c: Make symbols static if they're not exported.
1010 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1011 (fatal_error_code, fatal_error_signal_hook, standard_args):
1013 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1014 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1015 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1016 * lisp.h (fatal_error_signal_hook): Remove decl.
1017 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1019 * editfns.c: Move a (normally-unused) function to its only use.
1020 * editfns.c, lisp.h (get_operating_system_release): Remove.
1021 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1022 worth the hassle of breaking this out.
1024 * xterm.c: Make symbols static if they're not exported.
1025 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1026 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1027 (x_destroy_window, x_delete_display):
1029 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1030 (x_mouse_leave): Remove; unused.
1031 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1032 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1033 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1035 (x_mouse_leave): Declare only if WINDOWSNT.
1036 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1037 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1040 * ftxfont.c: Make symbols static if they're not exported.
1041 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1043 * font.h (ftxfont_driver): Likewise.
1045 * xfns.c: Make symbols static if they're not exported.
1046 (x_last_font_name, x_display_info_for_name):
1047 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1048 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1049 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1050 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1051 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1052 (last_show_tip_args): Now static.
1053 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1054 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1055 (x_screen_planes): Remove; unused.
1056 * dispextern.h (x_screen_planes): Remove decl.
1058 * dispnew.c: Make symbols static if they're not exported.
1059 * dispextern.h (redraw_garbaged_frames, scrolling):
1060 (increment_row_positions): Remove.
1061 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1062 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1064 (redraw_garbaged_frames): Remove; unused.
1066 * xfaces.c: Make symbols static if they're not exported.
1067 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1069 * xterm.h (defined_color): Remove decls.
1070 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1071 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1072 (menu_face_changed_default, defined_color, free_realized_face):
1073 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1074 (ascii_face_of_lisp_face): Remove; unused.
1076 * xdisp.c: Make symbols static if they're not exported.
1077 * dispextern.h (scratch_glyph_row, window_box_edges):
1078 (glyph_to_pixel_coords, set_cursor_from_row):
1079 (get_next_display_element, set_iterator_to_next):
1080 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1081 (show_mouse_face): Remove decls
1082 * frame.h (message_buf_print): Likewise.
1083 * lisp.h (pop_message, set_message, check_point_in_composition):
1085 * xterm.h (set_vertical_scroll_bar): Likewise.
1086 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1087 (message_buf_print, scratch_glyph_row, displayed_buffer):
1088 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1089 (get_next_display_element, show_mouse_face, window_box_edges):
1090 (frame_to_window_pixel_xy, check_point_in_composition):
1091 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1092 (glyph_to_pixel_coords): Remove; unused.
1094 * dired.c (file_name_completion): Now static.
1096 * dbusbind.c (xd_in_read_queued_messages): Now static.
1098 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1099 * data.c (circular_list_error): Remove.
1101 * commands.h (last_point_position, last_point_position_buffer):
1102 (last_point_position_window): Remove decls.
1103 * keyboard.c: Make these variables static.
1105 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1107 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1108 (iso_code_class, detect_coding, code_convert_region): Now static.
1109 (encode_coding_gap): Remove; unused.
1111 * chartab.c (chartab_chars, chartab_bits): Now static.
1113 * charset.h (charset_iso_8859_1): Remove decl.
1114 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1117 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1118 * ccl.c (Vccl_program_table): Now static.
1119 (check_ccl_update): Remove; unused.
1121 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1122 * category.h: ... from here.
1123 * category.c (check_category_table, set_category_set): Now static.
1125 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1126 * lisp.h: Remove these decls.
1128 * buffer.c (buffer_count): Remove unused var.
1130 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1131 so that it's not optimized away.
1132 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1133 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1134 exported only to the debugger.
1136 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1137 * atimer.h (run_all_atimers): Removed; not exported.
1139 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1140 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1141 was inaccessible from Lisp.
1142 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1143 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1145 alloc.c: Import and export fewer symbols, and remove unused items.
1146 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1148 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1149 it's not optimized away by whole-program optimization.
1150 (message_enable_multibyte, free_misc): Remove.
1151 (catchlist, handlerlist, mark_backtrace):
1152 Declare only if BYTE_MARK_STACK.
1153 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1154 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1155 (message_enable_multibyte): Remove decl.
1156 (free_misc, interval_free_list, float_block, float_block_index):
1157 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1158 (cons_free_list, last_marked_index):
1160 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1161 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1162 (mark_backtrace): Define only if BYTE_MARK_STACK.
1163 * xdisp.c (message_enable_multibyte): Now static.
1165 Declare Lisp_Object Q* variables to be 'static' if not exported.
1166 This makes it easier for human readers (and static analyzers)
1167 to see whether these variables are used from other modules.
1168 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1169 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1170 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1171 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1172 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1173 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1174 * xmenu.c, xselect.c:
1175 Declare Q* vars static if they are not used in other modules.
1176 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1177 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1178 Remove decls of unexported vars.
1179 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1181 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1183 Make Emacs functions such as Fatom 'static' by default.
1184 This makes it easier for human readers (and static analyzers)
1185 to see whether these functions can be called from other modules.
1186 DEFUN now defines a static function. To make the function external
1187 so that it can be used in other C modules, use the new macro DEFUE.
1188 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1189 (Finit_image_library):
1190 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1191 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1192 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1193 Remove decls, since these functions are now static.
1194 (Funintern, Fget_internal_run_time): New decls, since these functions
1195 were already external.
1197 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1198 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1199 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1200 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1201 * keyboard.c, keymap.c, lread.c:
1202 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1203 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1204 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1205 Mark functions with DEFUE instead of DEFUN,
1206 if they are used in other modules.
1207 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1208 decls for now-static functions.
1209 * buffer.h (Fdelete_overlay): Remove decl.
1210 * callproc.c (Fgetenv_internal): Mark as internal.
1211 * composite.c (Fremove_list_of_text_properties): Remove decl.
1212 (Fcomposition_get_gstring): New forward static decl.
1213 * composite.h (Fcomposite_get_gstring): Remove decl.
1214 * dired.c (Ffile_attributes): New forward static decl.
1215 * doc.c (Fdocumntation_property): New forward static decl.
1216 * eval.c (Ffetch_bytecode): New forward static decl.
1217 (Funintern): Remove extern decl; now in .h file where it belongs.
1218 * fileio.c (Fmake_symbolic_link): New forward static decl.
1219 * image.c (Finit_image_library): New forward static decl.
1220 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1221 * intervals.h (Fprevious_property_change):
1222 (Fremove_list_of_text_properties): Remove decls.
1223 * keyboard.c (Fthis_command_keys): Remove decl.
1224 (Fcommand_execute): New forward static decl.
1225 * keymap.c (Flookup_key): New forward static decl.
1226 (Fcopy_keymap): Now static.
1227 * keymap.h (Flookup_key): Remove decl.
1228 * process.c (Fget_process): New forward static decl.
1229 (Fprocess_datagram_address): Mark as internal.
1230 * syntax.c (Fsyntax_table_p): New forward static decl.
1231 (skip_chars): Remove duplicate decl.
1232 * textprop.c (Fprevious_property_change): New forward static decl.
1233 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1235 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1236 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1238 * editfns.c (Fformat): Remove unreachable code.
1240 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1242 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1245 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1247 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1248 when at ZV. (Bug#8487)
1250 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1252 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1254 * keyboard.c (parse_tool_bar_item): Likewise.
1255 * sound.c (sound_cleanup, alsa_close): Likewise.
1256 * termcap.c (tgetent): Likewise.
1257 * xfns.c (x_default_font_parameter): Likewise.
1258 * xsettings.c (read_and_apply_settings): Likewise.
1260 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1261 (overrun_check_free): Protoize.
1263 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1265 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1266 since callers should never pass a negative size.
1267 Change the signature to match that of plain 'read' and 'write'; see
1268 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1269 * lisp.h: Update prototypes of emacs_write and emacs_read.
1271 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1273 * xdisp.c (redisplay_window): Don't try to determine the character
1274 position of the scroll margin if the window start point w->startp
1275 is outside the buffer's accessible region. (Bug#8468)
1277 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1279 Fix write-region and its subroutines for buffers > 2GB.
1280 * fileio.c (a_write, e_write): Modify declaration of arguments and
1281 local variables to support buffers larger than 2GB.
1282 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1284 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1285 argument, local variables, and return value.
1287 * lisp.h: Update prototypes of emacs_write and emacs_read.
1289 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1291 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1293 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1295 Fix more problems found by GCC 4.6.0's static checks.
1297 * xdisp.c (vmessage): Use a better test for character truncation.
1299 * charset.c (load_charset_map): <, not <=, for optimization,
1300 and to avoid potential problems with integer overflow.
1301 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1302 * casetab.c (set_identity, shuffle): Likewise.
1303 * editfns.c (Fformat): Likewise.
1304 * syntax.c (skip_chars): Likewise.
1306 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1307 This also lets GCC 4.6.0 generate slightly better loop code.
1309 * callint.c (Fcall_interactively): <, not <=, for optimization.
1310 (Fcall_interactively): Count the number of arguments produced,
1311 not the number of arguments given. This is simpler and lets GCC
1312 4.6.0 generate slightly better code.
1314 * ftfont.c: Distingish more carefully between FcChar8 and char.
1315 The previous code passed unsigned char * to a functions like
1316 strlen and xstrcasecmp that expect char *, which does not
1317 conform to the C standard.
1318 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1319 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1320 char * when the C standard requires it.
1322 * keyboard.c (read_char): Remove unused var.
1324 * eval.c: Port to Windows vsnprintf (Bug#8435).
1326 (SIZE_MAX): Define if the headers do not.
1327 (verror): Do not give up if vsnprintf returns a negative count.
1328 Instead, grow the buffer. This ports to Windows vsnprintf, which
1329 does not conform to C99. Problem reported by Eli Zaretskii.
1330 Also, simplify the allocation scheme, by avoiding the need for
1331 calling realloc, and removing the ALLOCATED variable.
1333 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1335 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1336 But keep the doprint source code for now, as we might revamp it
1337 and use it again (Bug#8435).
1338 * lisp.h (doprnt): Remove.
1339 * Makefile.in (base_obj): Remove doprnt.o.
1340 * deps.mk (doprnt.o): Remove.
1342 error: Print 32- and 64-bit integers portably (Bug#8435).
1343 Without this change, on typical 64-bit hosts error ("...%d...", N)
1344 was used to print both 32- and 64-bit integers N, which relied on
1346 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1348 * lisp.h (error, verror): Mark as printf-like functions.
1349 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1350 Report overflow in size calculations when allocating printf buffer.
1351 Do not truncate output string at its first null byte.
1352 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1353 Truncate the output at a character boundary, since vsnprintf does not
1355 * charset.c (check_iso_charset_parameter): Convert internal
1356 character to string before calling 'error', since %c now has the
1358 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1359 overflow when computing char to be passed to 'error'. Do not
1360 pass Lisp_Object to 'error'; pass the integer instead.
1361 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1362 formatted with plain %d.
1364 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1366 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1368 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1370 * xterm.c (x_catch_errors): Remove duplicate declaration.
1372 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1374 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1376 2011-04-10 Jim Meyering <meyering@redhat.com>
1378 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1379 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1380 return ssize_t not "int", and use size_t as the buffer length.
1381 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1382 * gnutls.h: Update declarations.
1383 * process.c (read_process_output): Use ssize_t, to match.
1384 (send_process): Likewise.
1386 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1388 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1390 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1392 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1393 unsigned char, to match FcChar8 type definition.
1395 * xterm.c (handle_one_xevent):
1396 * xmenu.c (create_and_show_popup_menu):
1397 * xselect.c (x_decline_selection_request)
1398 (x_reply_selection_request): Avoid type-punned deref of X events.
1400 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1402 Fix some uses of `int' instead of EMACS_INT.
1403 * search.c (string_match_1, fast_string_match)
1404 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1405 (scan_buffer, find_next_newline_no_quit)
1406 (find_before_next_newline, search_command, Freplace_match)
1407 (Fmatch_data): Make some `int' variables be EMACS_INT.
1409 * xdisp.c (display_count_lines): 3rd argument and return value now
1410 EMACS_INT. All callers changed.
1411 (pint2hrstr): Last argument is now EMACS_INT.
1413 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1414 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1415 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1416 (decode_coding_utf_16, decode_coding_emacs_mule)
1417 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1418 (decode_coding_ccl, decode_coding_charset)
1419 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1420 (decode_coding_iso_2022, decode_coding_emacs_mule)
1421 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1422 <char_offset, last_offset>: Declare EMACS_INT.
1423 (encode_coding_utf_8, encode_coding_utf_16)
1424 (encode_coding_emacs_mule, encode_invocation_designation)
1425 (encode_designation_at_bol, encode_coding_iso_2022)
1426 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1427 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1429 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1430 (encode_invocation_designation): Last argument P_NCHARS is now
1432 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1433 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1435 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1438 * ccl.c (Fccl_execute_on_string): Declare some variables
1441 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1443 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1445 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1447 * process.c (Fformat_network_address): Doc fix.
1449 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1451 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1453 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1455 * keyboard.c (read_char): Call Lisp function help-form-show,
1456 instead of using internal_with_output_to_temp_buffer.
1457 (Qhelp_form_show): New var.
1458 (syms_of_keyboard): Use DEFSYM macro.
1460 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1462 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1464 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1466 * process.c (Flist_processes): Removed to Lisp.
1467 (list_processes_1): Deleted.
1469 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1471 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1473 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1475 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1477 Fix more problems found by GCC 4.6.0's static checks.
1479 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1481 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1483 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1485 * xdisp.c (vmessage): Mark as a printf-like function.
1487 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1489 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1491 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1492 printf-like functions.
1493 (tiff_load): Add casts to remove these marks before passing them
1494 to system-supplied API.
1496 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1498 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1499 This avoids several warnings with gcc -Wstrict-overflow.
1500 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1501 directly, rather than having caller test rule sign. This avoids
1502 some unnecessary tests.
1503 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1504 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1505 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1507 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1508 (xfont_open): Avoid unnecessary tests.
1510 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1512 * composite.h, composite.c (composition_gstring_put_cache):
1513 Use EMACS_INT, not int, for length.
1515 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1516 breaking out part of COMPOSITION_DECODE_RULE.
1517 (COMPOSITION_DECODE_RULE): Use it.
1518 * composite.c (get_composition_id): Remove unused local vars,
1519 by using the new macro.
1521 * textprop.c (set_text_properties_1): Change while to do-while,
1522 since the condition is always true at first.
1524 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1525 (interval_deletion_adjustment): Return unsigned value.
1528 * process.c (list_processes_1, create_pty, read_process_output):
1529 (exec_sentinel): Remove vars that were set but not used.
1530 (create_pty): Remove unnecessary "volatile"s.
1531 (Fnetwork_interface_info): Avoid possibility of int overflow.
1532 (read_process_output): Do adaptive read buffering even if carryover.
1533 (read_process_output): Simplify nbytes computation if buffered.
1535 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1537 * syntax.c (scan_words): Remove var that was set but not used.
1538 (update_syntax_table): Use unsigned instead of int.
1540 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1541 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1542 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1544 * print.c (print_error_message): Avoid int overflow.
1546 * font.c (font_list_entities): Redo for clarity,
1547 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1549 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1550 (font_score): Avoid potential overflow in diff calculation.
1552 * fns.c (substring_both): Remove var that is set but not used.
1553 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1555 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1557 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1558 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1559 can always succeed if overflow has undefined behavior.
1561 * search.c (boyer_moore, wordify): Remove vars set but not used.
1562 (wordify): Omit three unnecessary tests.
1564 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1565 All callers changed. This avoids the need for an unused var.
1567 * casefiddle.c (casify_region): Remove var that is set but not used.
1569 * dired.c (file_name_completion): Remove var that is set but not used.
1571 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1573 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1574 (Finsert_file_contents): Remove unnecessary code checking fd.
1576 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1577 Check for integer overflow on size calculations.
1579 * buffer.c (Fprevious_overlay_change): Remove var that is set
1582 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1583 Remove vars that are set but not used.
1584 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1585 (timer_check_2): Mark vars as initialized.
1587 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1589 * image.c (lookup_image): Remove var that is set but not used.
1590 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1592 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1593 that are set but not used.
1595 * xfns.c (make_invisible_cursor): Don't return garbage
1596 if XCreateBitmapFromData fails (Bug#8410).
1598 * xselect.c (x_get_local_selection, x_handle_property_notify):
1599 Remove vars that are set but not used.
1601 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1602 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1604 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1605 Remove var that is set but not used.
1606 (scroll_bar_windows_size): Now size_t, not int.
1607 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1610 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1611 (map_tty_color) [!defined MSDOS]: Likewise.
1613 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1615 * coding.c: Remove vars that are set but not used.
1616 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1617 All callers changed.
1618 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1619 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1620 (decode_coding_charset): Remove vars that are set but not used.
1622 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1623 that is set but not used.
1625 * print.c (print_object): Remove var that is set but not used.
1627 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1628 The gnulib version avoids calling malloc in the usual case,
1629 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1630 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1631 * filelock.c (current_lock_owner): Likewise.
1632 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1633 * sysdep.c: Include allocator.h, careadlinkat.h.
1634 (emacs_no_realloc_allocator): New static constant.
1635 (emacs_readlink): New function.
1636 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1637 ../lib/careadlinkat.h.
1639 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1641 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1642 first non-nil return value).
1644 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1646 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1647 if not defined (Bug#8403).
1649 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1651 * xdisp.c (display_count_lines): Remove parameter `start',
1652 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1653 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1654 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1655 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1656 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1657 and thereabouts. All callers changed.
1658 (get_per_char_metric): Remove parameter `f', unused since
1659 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1661 2011-04-02 Jim Meyering <meyering@redhat.com>
1663 do not dereference NULL upon failed strdup
1664 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1665 (ns_get_family): Likewise.
1667 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1669 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1671 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1673 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1676 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1678 Add lexical binding.
1680 * window.c (Ftemp_output_buffer_show): New fun.
1681 (Fsave_window_excursion):
1682 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1684 * lread.c (lisp_file_lexically_bound_p): New function.
1685 (Fload): Bind Qlexical_binding.
1686 (readevalloop): Remove `evalfun' arg.
1687 Bind Qinternal_interpreter_environment.
1688 (Feval_buffer): Bind Qlexical_binding.
1689 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1691 (syms_of_lread): Declare `lexical-binding'.
1693 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1695 * keyboard.c (eval_dyn): New fun.
1696 (menu_item_eval_property): Use it.
1698 * image.c (parse_image_spec): Use Ffunctionp.
1700 * fns.c (concat, mapcar1): Accept byte-code-functions.
1702 * eval.c (Fsetq): Handle lexical vars.
1703 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1704 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1705 (FletX, Flet): Obey lexical binding.
1706 (Fcommandp): Handle closures.
1707 (Feval): New `lexical' arg.
1708 (eval_sub): New function extracted from Feval. Use it almost
1709 everywhere where Feval was used. Look up vars in lexical env.
1711 (Ffunctionp): Move from subr.el.
1712 (Ffuncall): Handle closures.
1713 (apply_lambda): Remove `eval_flags'.
1714 (funcall_lambda): Handle closures and new byte-code-functions.
1715 (Fspecial_variable_p): New function.
1716 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1717 but without exporting it to Lisp.
1719 * doc.c (Fdocumentation, store_function_docstring):
1720 * data.c (Finteractive_form): Handle closures.
1722 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1725 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1727 (exec_byte_code): New function extracted from Fbyte_code to handle new
1728 calling convention for byte-code-functions. Add new byte-codes.
1730 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1732 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1734 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1736 * xdisp.c (redisplay_internal): Fix prototype.
1738 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1740 * xdisp.c (SCROLL_LIMIT): New macro.
1741 (try_scrolling): Use it when setting scroll_limit. Limit
1742 scrolling to 100 screen lines.
1743 (redisplay_window): Even when falling back on "recentering",
1744 position point in the window according to scroll-conservatively,
1745 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1747 (try_scrolling): When point is above the window, allow searching
1748 as far as scroll_max, or one screenful, to compute vertical
1749 distance from PT to the scroll margin position. This prevents
1750 try_scrolling from unnecessarily failing when
1751 scroll-conservatively is set to a value slightly larger than the
1752 window height. Clean up the case of PT below the margin at bottom
1753 of window: scroll_max can no longer be INT_MAX. When aggressive
1754 scrolling is in use, don't let point enter the opposite scroll
1755 margin as result of the scroll.
1756 (syms_of_xdisp) <scroll-conservatively>: Document the
1757 threshold of 100 lines for never-recentering scrolling.
1759 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1761 * dispextern.h (move_it_by_lines):
1762 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1763 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1764 (message_log_check_duplicate): Remove parameters `prev_bol' and
1765 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1766 (redisplay_internal): Remove parameter `preserve_echo_area',
1767 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1769 * indent.c (Fvertical_motion):
1770 * window.c (window_scroll_pixel_based, Frecenter):
1771 Don't pass `need_y_p' to `move_it_by_lines'.
1773 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1775 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1776 steal a few bits to be more compact.
1777 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1778 Remove unneeded casts.
1780 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1782 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1784 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1785 binding" message (bug#7967).
1787 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1789 Fix more problems found by GCC 4.6.0's static checks.
1791 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1792 Remove unused local var.
1794 * editfns.c (Fmessage_box): Remove unused local var.
1796 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1797 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1798 Omit unused local vars.
1799 * window.c (shrink_windows): Omit unused local var.
1800 * menu.c (digest_single_submenu): Omit unused local var.
1801 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1802 Omit unused local var.
1804 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1805 Don't assume string length fits in int.
1806 (keyremap_step, read_key_sequence): Use size_t for sizes.
1807 (read_key_sequence): Don't check last_real_key_start redundantly.
1809 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1810 instead of alloca (Bug#8344).
1812 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1813 (Fbacktrace_frame): Don't assume nframes fits in int.
1815 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1817 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1820 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1822 * cm.c (calccost): Turn while-do into do-while, for clarity.
1824 * keyboard.c (syms_of_keyboard): Use the same style as later
1825 in this function when indexing through an array. This also
1826 works around GCC bug 48267.
1828 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1830 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1832 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1833 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1835 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1836 This avoids undefined behavior on integer overflow, and is a bit
1837 more convenient anyway since it is compared to a size_t variable.
1839 Variadic C functions now count arguments with size_t, not int.
1840 This avoids an unnecessary limitation on 64-bit machines, which
1841 caused (substring ...) to crash on large vectors (Bug#8344).
1842 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1843 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1844 All variadic functions and their callers changed accordingly.
1845 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1846 * data.c (arith_driver, float_arith_driver): Likewise.
1847 * editfns.c (general_insert_function): Likewise.
1848 * eval.c (struct backtrace.nargs, interactive_p)
1849 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1850 (funcall_lambda, mark_backtrace): Likewise.
1851 * fns.c (concat): Likewise.
1852 * frame.c (x_set_frame_parameters): Likewise.
1853 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1854 0 if not found, not -1. All callers changed.
1856 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1857 (stack_copy_size): Now size_t, not int.
1858 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1860 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1862 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1863 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1864 All callers changed.
1866 * lisp.h (multibyte_char_to_unibyte):
1867 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1868 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1869 * character.h (CHAR_TO_BYTE8):
1870 * cmds.c (internal_self_insert):
1871 * editfns.c (general_insert_function):
1872 * keymap.c (push_key_description):
1873 * search.c (Freplace_match):
1874 * xdisp.c (message_dolog, set_message_1): All callers changed.
1876 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1878 * keyboard.c (safe_run_hook_funcall): New function.
1879 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1880 don't set the hook to nil, but remove the offending function instead.
1881 (Qcommand_hook_internal): Remove, unused.
1882 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1883 Vcommand_hook_internal.
1885 * eval.c (enum run_hooks_condition): Remove.
1886 (funcall_nil, funcall_not): New functions.
1887 (run_hook_with_args): Call each function through a `funcall' argument.
1888 Remove `cond' argument, now redundant.
1889 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1890 (Frun_hook_with_args_until_failure): Adjust accordingly.
1891 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1893 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1895 * dispextern.h (string_buffer_position): Remove declaration.
1897 * print.c (strout): Remove parameter `multibyte', unused since
1898 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1900 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1901 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1902 All callers changed.
1904 * w32.c (_wsa_errlist): Use braces for struct initializers.
1906 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1907 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1908 All callers changed.
1909 (string_buffer_position): Likewise. Also, make static (it's never
1910 used outside xdisp.c).
1911 (cursor_row_p): Remove parameter `w', unused since
1912 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1913 (decode_mode_spec): Remove parameter `precision', introduced during
1914 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1915 All callers changed.
1917 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1919 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1921 2011-03-27 Anders Lindgren <andlind@gmail.com>
1923 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1924 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1925 (ns_update_auto_hide_menu_bar): New functions.
1926 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1927 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1928 ns_constrain_all_frames.
1929 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1930 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1932 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1934 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1936 2011-03-27 Glenn Morris <rgm@gnu.org>
1938 * syssignal.h: Replace RETSIGTYPE with void.
1939 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1940 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1941 Replace SIGTYPE with void everywhere.
1942 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1943 * s/template.h (SIGTYPE): Remove commented out definition.
1945 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1948 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1950 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1952 * w32.c (read_unc_volume): Use parameter `henum', instead of
1953 global variable `wget_enum_handle'.
1955 * keymap.c (describe_vector): Remove parameters `indices' and
1956 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1957 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1959 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1961 * keyboard.c (timer_check): Remove parameter `do_it_now',
1962 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1963 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1964 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1966 * keyboard.c (read_char):
1967 * w32menu.c (w32_menu_display_help):
1968 * xmenu.c (show_help_event, menu_help_callback):
1969 Adjust calls to `show_help_echo'.
1971 * gtkutil.c (xg_maybe_add_timer):
1972 * keyboard.c (readable_events):
1973 * process.c (wait_reading_process_output):
1974 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1976 * insdel.c (adjust_markers_gap_motion):
1977 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1978 (gap_left, gap_right): Don't call it.
1980 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1982 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1983 incurred during fontification.
1985 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1987 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1988 (DEFVAR_PER_BUFFER): Don't pass it.
1990 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1991 (scrolling_window): Don't pass it.
1993 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1995 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1997 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1999 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2000 of variables specific to SELinux and computation of `encoded_absname'.
2002 * image.c (XPutPixel): Remove unused variable `height'.
2004 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2006 * unexw32.c (get_section_info): Remove unused variable `section'.
2008 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2009 (system_process_attributes): Remove unused variable `sess'.
2010 (sys_read): Remove unused variable `err'.
2012 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2013 (w32_wnd_proc): Remove unused variable `isdead'.
2014 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2015 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2016 (x_create_tip_frame): Remove unused variable `tem'.
2018 * w32inevt.c (w32_console_read_socket):
2019 Remove unused variable `no_events'.
2021 * w32term.c (x_draw_composite_glyph_string_foreground):
2022 Remove unused variable `width'.
2024 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2026 * w32term.c (x_set_glyph_string_clipping):
2027 Don't pass uninitialized region to CombineRgn.
2029 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2031 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2032 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2033 (Fx_close_connection): Remove unused variable `i'.
2035 * w32font.c (w32font_draw): Return number of glyphs.
2036 (w32font_open_internal): Remove unused variable `i'.
2037 (w32font_driver): Add missing initializer.
2039 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2040 (fill_in_menu): Remove unused variable `items_added'.
2042 * w32term.c (last_mouse_press_frame): Remove static global variable.
2043 (w32_clip_to_row): Remove unused variable `f'.
2044 (x_delete_terminal): Remove unused variable `i'.
2046 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2047 (NOTHING): Remove unused static global variable.
2048 (uniscribe_check_otf): Remove unused variable `table'.
2049 (uniscribe_font_driver): Add missing initializers.
2051 2011-03-23 Julien Danjou <julien@danjou.info>
2053 * term.c (Fsuspend_tty, Fresume_tty):
2054 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2055 * window.c (temp_output_buffer_show):
2056 * insdel.c (signal_before_change):
2057 * frame.c (Fhandle_switch_frame):
2058 * fileio.c (Fdo_auto_save):
2059 * emacs.c (Fkill_emacs):
2060 * editfns.c (save_excursion_restore):
2061 * cmds.c (internal_self_insert):
2062 * callint.c (Fcall_interactively):
2063 * buffer.c (Fkill_all_local_variables):
2064 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2066 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2067 unconditionnaly since it does the check itself.
2069 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2071 Fix more problems found by GCC 4.5.2's static checks.
2073 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2074 the first time through the loop, since we know p0 < p1 then.
2075 This also avoids a gcc -Wstrict-overflow warning.
2077 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2078 leading to a memory leak, possible in functions like
2079 load_charset_map_from_file that can allocate an unbounded number
2080 of objects (Bug#8318).
2082 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2083 that could (at least in theory) be that large.
2085 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2086 This is less likely to overflow, and avoids undefined behavior if
2087 overflow does occur. All callers changed. Use strtoul to scan
2088 for the unsigned long integer.
2089 (pint2hrstr): Simplify and tune code slightly.
2090 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2092 * scroll.c (do_scrolling): Work around GCC bug 48228.
2093 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2095 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2096 This also avoids a warning with gcc -Wstrict-overflow.
2097 (validate_x_resource_name): Simplify count usage.
2098 This also avoids a warning with gcc -Wstrict-overflow.
2100 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2103 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2105 * process.c (Fmake_network_process): Use socklen_t, not int,
2106 where POSIX says socklen_t is required in portable programs.
2107 This fixes a porting bug on hosts like 64-bit HP-UX, where
2108 socklen_t is wider than int (Bug#8277).
2109 (Fmake_network_process, server_accept_connection):
2110 (wait_reading_process_output, read_process_output):
2113 * process.c: Rename or move locals to avoid shadowing.
2114 (list_processes_1, Fmake_network_process):
2115 (read_process_output_error_handler, exec_sentinel_error_handler):
2116 Rename or move locals.
2117 (Fmake_network_process): Define label "retry_connect" only if needed.
2118 (Fnetwork_interface_info): Fix pointer signedness.
2119 (process_send_signal): Add cast to avoid pointer signedness problem.
2120 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2121 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2123 Make tparam.h and terminfo.c consistent.
2124 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2125 Include tparam.h instead, since it declares them.
2126 * cm.h (PC): Remove extern decl; tparam.h now does this.
2127 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2128 * terminfo.c: Include tparam.h, to check interfaces.
2129 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2130 (tparam): Adjust signature to match interface in tparam.h;
2131 this removes some undefined behavior. Check that outstring and len
2132 are zero, which they always are with Emacs.
2133 * tparam.h (PC, BC, UP): New extern decls.
2135 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2136 (xftfont_open): Rename locals to avoid shadowing.
2138 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2139 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2140 (OTF_TAG_SYM): Omit macro if not needed.
2141 (ftfont_list): Remove unused local.
2142 (get_adstyle_property, ftfont_pattern_entity):
2143 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2144 Rename locals to avoid shadowing.
2146 * xfont.c (xfont_list_family): Mark var as initialized.
2148 * xml.c (make_dom): Now static.
2150 * composite.c (composition_compute_stop_pos): Rename local to
2152 (composition_reseat_it): Remove unused locals.
2153 (find_automatic_composition, composition_adjust_point): Likewise.
2154 (composition_update_it): Mark var as initialized.
2155 (find_automatic_composition): Mark vars as initialized,
2156 with a FIXME (Bug#8290).
2158 character.h: Rename locals to avoid shadowing.
2159 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2160 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2161 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2162 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2165 * textprop.c (property_change_between_p): Remove; unused.
2167 * intervals.c (interval_start_pos): Now static.
2169 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2171 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2172 Rename locals to avoid shadowing.
2174 * sound.c (wav_play, au_play, Fplay_sound_internal):
2175 Fix pointer signedness.
2176 (alsa_choose_format): Remove unused local var.
2177 (wav_play): Initialize a variable to 0, to prevent undefined
2178 behavior (Bug#8278).
2180 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2182 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2184 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2185 clobbering (Bug#8298).
2186 * sysdep.c (sys_subshell): Likewise.
2187 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2189 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2190 This should get cleaned up, so that child_setup has the
2191 same signature on all platforms.
2193 * callproc.c (call_process_cleanup): Now static.
2194 (relocate_fd): Rename locals to avoid shadowing.
2196 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2198 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2199 not to be necessary, and produces flickering.
2201 2011-03-20 Glenn Morris <rgm@gnu.org>
2203 * config.in: Remove file.
2205 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2207 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2208 are now in src/globals.h.
2209 (syms_of_minibuf): Remove spurious & from previous change.
2211 2011-03-20 Leo <sdl.web@gmail.com>
2213 * minibuf.c (completing-read-function): New variable.
2214 (completing-read-default): Rename from completing-read.
2215 (completing-read): Call completing-read-function.
2217 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2219 * xfaces.c (Fx_load_color_file):
2220 Read color file from absolute filename (bug#8250).
2222 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2224 * makefile.w32-in: Update dependencies.
2226 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2228 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2230 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2232 Fix more problems found by GCC 4.5.2's static checks.
2234 * process.c (make_serial_process_unwind, send_process_trap):
2235 (sigchld_handler): Now static.
2237 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2238 That way, the code declares only the vars that it needs.
2239 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2240 * s/cygwin.h (PTY_ITERATION): Likewise.
2241 * s/darwin.h (PTY_ITERATION): Likewise.
2242 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2244 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2245 * process.c (allocate_pty): Don't declare stb unless it's needed.
2247 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2248 (CONSTANTLIM): Remove; unused.
2249 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2250 Define only if needed.
2252 * unexelf.c (unexec): Name an expression,
2253 to avoid gcc -Wbad-function-cast warning.
2254 Use a different way to cause a compilation error if anyone uses
2255 n rather than nn, a way that does not involve shadowing.
2256 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2258 * deps.mk (unexalpha.o): Remove; unused.
2260 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2261 * unexec.h: New file.
2262 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2263 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2265 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2266 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2267 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2268 Change as necessary to match prototype in unexec.h.
2270 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2272 (back_comment, skip_chars): Mark vars as initialized.
2274 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2275 Rename locals to avoid shadowing.
2277 * lread.c (read1): Rewrite so as not to use empty "else".
2278 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2280 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2282 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2283 warning when compiling print.c.
2285 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2286 instead of using an uninitialized var.
2287 (font_sort_entities): Mark var as initialized.
2289 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2291 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2292 pointers to constants.
2293 (font_parse_fcname): Remove unused vars.
2294 (font_delete_unmatched): Now static.
2295 (font_get_spec): Remove; unused.
2296 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2297 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2298 Rename or move locals to avoid shadowing.
2300 * fns.c (require_nesting_list, require_unwind): Now static.
2301 (Ffillarray): Rename locals to avoid shadowing.
2303 * floatfns.c (domain_error2): Define only if needed.
2304 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2306 * alloc.c (mark_backtrace): Move decl from here ...
2307 * lisp.h: ... to here, so that it can be checked.
2309 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2310 (Fdefvar): Rewrite so as not to use empty "else".
2311 (lisp_indirect_variable): Name an expression,
2312 to avoid gcc -Wbad-function-cast warning.
2313 (Fdefvar): Rename locals to avoid shadowing.
2315 * callint.c (quotify_arg, quotify_args): Now static.
2316 (Fcall_interactively): Rename locals to avoid shadowing.
2317 Use const pointer when appropriate.
2319 * lisp.h (get_system_name, get_operating_system_release):
2320 Move decls here, to check interfaces.
2321 * process.c (get_operating_system_release): Move decl to lisp.h.
2322 * xrdb.c (get_system_name): Likewise.
2323 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2324 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2325 some of which prompt warnings from gcc -Wbad-function-cast.
2326 (Fformat_time_string, Fencode_time, Finsert_char):
2327 (Ftranslate_region_internal, Fformat):
2328 Rename or remove local vars to avoid shadowing.
2329 (Ftranslate_region_internal): Mark var as initialized.
2331 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2334 * lisp.h (eassert): Check that the argument compiles, even if
2335 ENABLE_CHECKING is not defined.
2337 * data.c (Findirect_variable): Name an expression, to avoid
2338 gcc -Wbad-function-cast warning.
2339 (default_value, arithcompare, arith_driver, arith_error): Now static.
2340 (store_symval_forwarding): Rename local to avoid shadowing.
2341 (Fmake_variable_buffer_local, Fmake_local_variable):
2342 Mark variables as initialized.
2343 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2345 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2346 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2347 Rename locals to avoid shadowing.
2348 (mark_stack): Move local variables into the #ifdef region where
2350 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2351 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2353 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2354 (GC_STRING_CHARS): Remove; not used.
2355 (Fmemory_limit): Cast sbrk's returned value to char *.
2357 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2358 avoids undefined behavior in theory.
2360 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2362 Use functions, not macros, for up- and down-casing (Bug#8254).
2363 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2364 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2365 to use the following functions instead of these macros.
2366 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2367 EMACS_INT, since callers assume the returned value fits in int.
2368 (upcase1): Likewise, for UPCASE_TABLE.
2369 (uppercasep, lowercasep, upcase): New static inline functions.
2370 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2371 the race-condition problem in the old DOWNCASE.
2373 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2374 Rename locals to avoid shadowing.
2375 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2376 (regex_compile, re_search_2, re_match_2_internal):
2377 Remove unused local vars.
2378 (FREE_VAR): Rewrite so as not to use empty "else",
2379 which gcc can warn about.
2380 (regex_compile, re_match_2_internal): Mark locals as initialized.
2381 (RETALLOC_IF): Define only if needed.
2382 (WORDCHAR_P): Likewise. This one is never needed, but is used
2383 only in a comment talking about a compiler bug, so put inside
2384 the #if 0 of that comment.
2385 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2386 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2389 * search.c (boyer_moore): Rename locals to avoid shadowing.
2390 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2391 (PREV_CHAR_BOUNDARY): Likewise.
2393 * search.c (simple_search): Remove unused var.
2395 * dired.c (compile_pattern): Move decl from here ...
2396 * lisp.h: ... to here, so that it can be checked.
2397 (struct re_registers): New forward decl.
2399 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2401 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2403 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2404 Rename locals to avoid shadowing.
2405 (Fvertical_motion): Mark locals as initialized.
2407 * casefiddle.c (casify_object, casify_region): Now static.
2408 (casify_region): Mark local as initialized.
2410 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2412 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2413 New macros, so that the caller can use some names other than
2414 gcpro1, gcpro2, etc.
2415 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2417 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2418 argument, for consistency with GCPRO2_VAR, etc: it is now the
2419 prefix of the variable, not the variable itself. All uses
2421 * dired.c (directory_files_internal, file_name_completion):
2422 Rename locals to avoid shadowing.
2424 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2425 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2426 dired.c's scmp function, had undefined behavior.
2427 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2428 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2429 * buffer.h: ... to here, because these macros use current_buffer,
2430 and the new implementation with inline functions needs to have
2431 current_buffer in scope now, rather than later when the macros
2433 (downcase, upcase1): New static inline functions.
2434 (DOWNCASE, UPCASE1): Reimplement using these functions.
2435 This avoids undefined behavior in expressions like
2436 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2437 from race conditions in accessing the global variables
2438 case_temp1 and case_temp2.
2439 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2440 * lisp.h (case_temp1, case_temp2): Remove their decls.
2441 * character.h (ASCII_CHAR_P): Move from here ...
2442 * lisp.h: ... to here, so that the inline functions mentioned
2445 * dired.c (directory_files_internal_unwind): Now static.
2447 * fileio.c (file_name_as_directory, directory_file_name):
2448 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2450 (file_name_as_directory): Use const pointers when appropriate.
2451 (Fexpand_file_name): Likewise. In particular, newdir might
2452 point at constant storage, so make it a const pointer.
2453 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2454 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2456 (Fset_file_times, Finsert_file_contents, auto_save_error):
2457 Rename locals to avoid shadowing.
2459 * minibuf.c (choose_minibuf_frame_1): Now static.
2460 (Ftry_completion, Fall_completions): Rename or remove locals
2463 * marker.c (bytepos_to_charpos): Remove; unused.
2465 * lisp.h (verify_bytepos, count_markers): New decls,
2466 so that gcc does not warn that these functions aren't declared.
2468 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2469 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2470 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2471 (copy_text): Remove unused local var.
2473 * filelock.c (within_one_second): Now static.
2474 (lock_file_1): Rename local to avoid shadowing.
2476 * buffer.c (fix_overlays_before): Mark locals as initialized.
2477 (fix_start_end_in_overlays): Likewise. This function should be
2478 simplified by using pointers-to-pointers, but that's a different
2480 (switch_to_buffer_1): Now static.
2481 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2482 (report_overlay_modification): Rename locals to avoid shadowing.
2484 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2485 Fix pointer signedness issue.
2486 (sys_subshell): Mark local as volatile if checking for lint,
2487 to suppress a gcc -Wclobbered warning that does not seem to be right.
2488 (MAXPATHLEN): Define only if needed.
2490 * process.c (serial_open, serial_configure): Move decls from here ...
2491 * systty.h: ... to here, so that they can be checked.
2493 * fns.c (get_random, seed_random): Move extern decls from here ...
2494 * lisp.h: ... to here, so that they can be checked.
2496 * sysdep.c (reset_io): Now static.
2497 (wait_for_termination_signal): Remove; unused.
2499 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2500 (copy_keymap_item, append_key, push_text_char_description):
2502 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2503 (DENSE_TABLE_SIZE): Remove; unused.
2504 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2505 (describe_map_tree):
2506 Rename locals to avoid shadowing.
2508 * keyboard.c: Declare functions static if they are not used elsewhere.
2509 (echo_char, echo_dash, cmd_error, top_level_2):
2510 (poll_for_input, handle_async_input): Now static.
2511 (read_char, kbd_buffer_get_event, make_lispy_position):
2512 (make_lispy_event, make_lispy_movement, apply_modifiers):
2513 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2514 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2515 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2516 (read_key_sequence, read_char): Mark locals as initialized.
2517 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2519 * keyboard.h (make_ctrl_char): New decl.
2520 (mark_kboards): Move decl here ...
2521 * alloc.c (mark_kboards): ... from here.
2523 * lisp.h (force_auto_save_soon): New decl.
2525 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2526 (DEFINE_DUMMY_FUNCTION): New macro.
2527 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2529 (main): Add casts to avoid warnings
2530 if GCC considers string literals to be constants.
2532 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2534 * dbusbind.c: Pointer signedness fixes.
2535 (xd_signature, xd_append_arg, xd_initialize):
2536 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2537 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2538 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2539 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2541 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2542 if GCC considers string literals to be constants.
2543 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2545 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2547 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2548 (print_preprocess, print_object): New macro to fix last change.
2550 * print.c (print_preprocess): Don't forget font objects.
2552 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2554 * emacs.c (USAGE3): Doc fixes.
2556 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2558 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2561 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2563 * lisp.h (VWindow_system, Qfile_name_history):
2564 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2565 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2566 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2568 * w32select.c: Don't #include "keyboard.h".
2569 (run_protected): Add extern declaration for waiting_for_input.
2571 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2572 * w32console.c (detect_input_pending, read_input_pending)
2573 (encode_terminal_code):
2574 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2575 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2576 (w32_system_caret_y, Qfile_name_history):
2577 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2578 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2579 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2580 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2581 * w32proc.c (Qlocal, report_file_error):
2582 * w32term.c (Vwindow_system, updating_frame):
2583 * w32uniscribe.c (initialized, uniscribe_font_driver):
2584 Remove unneeded extern declarations.
2586 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2588 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2590 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2592 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2593 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2594 These macros can no longer be used for assignment.
2596 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2597 Assign struct members directly, instead of using BUF_BEGV etc.
2598 (record_buffer_markers, fetch_buffer_markers): New functions for
2599 recording and fetching special buffer markers.
2600 (set_buffer_internal_1, set_buffer_temp): Use them.
2602 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2604 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2606 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2607 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2609 * xdisp.c (hscroll_window_tree):
2610 (reconsider_clip_changes): Use PT instead of BUF_PT.
2612 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2614 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2615 $(EMACS_ROOT)/lib/intprops.h.
2617 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2619 Fix more problems found by GCC 4.5.2's static checks.
2621 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2622 to unsigned char * to avoid compiler diagnostic.
2623 (xg_free_frame_widgets): Make it clear that a local variable is
2624 needed only if USE_GTK_TOOLTIP.
2625 (gdk_window_get_screen): Make it clear that this macro is needed
2626 only if USE_GTK_TOOLTIP.
2627 (int_gtk_range_get_value): New function, which avoids a diagnostic
2628 from gcc -Wbad-function-cast.
2629 (xg_set_toolkit_scroll_bar_thumb): Use it.
2630 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2631 diagnostic from gcc -Wbad-function-cast.
2632 (get_utf8_string, xg_get_file_with_chooser):
2633 Rename locals to avoid shadowing.
2634 (create_dialog): Move locals to avoid shadowing.
2636 * xgselect.c (xg_select): Remove unused var.
2638 * image.c (four_corners_best): Mark locals as initialized.
2639 (gif_load): Initialize transparent_p to zero (Bug#8238).
2640 Mark another local as initialized.
2641 (my_png_error, my_error_exit): Mark with NO_RETURN.
2643 * image.c (clear_image_cache): Now static.
2644 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2645 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2646 (x_edge_detection): Remove unnecessary cast that
2647 gcc -Wbad-function-cast diagnoses.
2648 (gif_load): Fix pointer signedness.
2649 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2650 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2652 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2654 Improve quality of tests for time stamp overflow.
2655 For example, without this patch (encode-time 0 0 0 1 1
2656 1152921504606846976) returns the obviously-bogus value (-948597
2657 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2658 reports time overflow. See
2659 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2660 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2661 * editfns.c: Include limits.h and intprops.h.
2662 (TIME_T_MIN, TIME_T_MAX): New macros.
2663 (time_overflow): Move earlier, to before first use.
2664 (hi_time, lo_time): New functions, for an accurate test for
2666 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2667 (Fget_internal_run_time): Don't assume time_t fits in int.
2668 (make_time): Use list2 instead of Fcons twice.
2669 (Fdecode_time): More accurate test for out-of-range times.
2670 (check_tm_member): New function.
2671 (Fencode_time): Use it, to test for out-of-range times.
2672 (lisp_time_argument): Don't rely on undefined left-shift and
2673 right-shift behavior when checking for time stamp overflow.
2675 * editfns.c (time_overflow): New function, refactoring common code.
2676 (Fformat_time_string, Fdecode_time, Fencode_time):
2677 (Fcurrent_time_string): Use it.
2679 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2680 * dired.c (make_time): Move to ...
2681 * editfns.c (make_time): ... here.
2682 * systime.h: Note the move.
2684 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2686 * fringe.c (update_window_fringes): Remove unused variables.
2688 * unexmacosx.c (copy_data_segment): Also copy __got section.
2691 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2693 * termcap.c [MSDOS]: Include "msdos.h".
2694 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2695 Constify `char *' arguments and their references according to
2696 prototypes in tparam.h.
2698 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2700 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2701 Adapt all references accordingly.
2703 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2705 2011-03-11 Tom Tromey <tromey@redhat.com>
2707 * buffer.c (syms_of_buffer): Remove obsolete comment.
2709 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2711 * termhooks.h (encode_terminal_code): Declare prototype.
2713 * msdos.c (encode_terminal_code): Don't declare prototype.
2715 * term.c (encode_terminal_code): Now external again, used by
2716 w32console.c and msdos.c.
2718 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2719 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2721 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2723 Fix some minor problems found by GCC 4.5.2's static checks.
2725 * fringe.c (update_window_fringes): Mark locals as initialized
2727 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2729 * alloc.c (mark_fringe_data): Move decl from here ...
2730 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2731 to check its interface.
2732 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2734 * fontset.c (free_realized_fontset): Now static.
2735 (Fset_fontset_font): Rename local to avoid shadowing.
2736 (fontset_font): Mark local as initialized.
2737 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2739 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2741 * xselect.c (x_disown_buffer_selections): Remove; not used.
2742 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2743 (x_own_selection, Fx_disown_selection_internal): Rename locals
2745 (x_handle_dnd_message): Remove local to avoid shadowing.
2747 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2748 so that the caller can use some name other than gcpro1.
2749 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2750 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2751 (Fx_backspace_delete_keys_p):
2752 Use them to avoid shadowing, and rename vars to avoid shadowing.
2753 (x_decode_color, x_set_name, x_window): Now static.
2754 (Fx_create_frame): Add braces to silence GCC warning.
2755 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2756 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2757 Remove unused locals.
2758 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2759 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2760 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2763 * xterm.h (x_mouse_leave): New decl.
2765 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2766 Remove unused functions.
2767 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2768 (x_calc_absolute_position): Now static.
2769 (XTread_socket): Don't define label "out" unless it's used.
2770 Don't declare local "event" unless it's used.
2771 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2772 unless they are used.
2773 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2774 (x_fatal_error_signal): Remove; not used.
2775 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2776 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2777 (x_error_catcher, x_connection_closed, x_error_handler):
2778 (x_error_quitter, xembed_send_message, x_iconify_frame):
2779 (my_log_handler): Rename locals to avoid shadowing.
2780 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2781 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2783 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2784 Rename or move locals to avoid shadowing.
2785 (tty_defined_color, merge_face_heights): Now static.
2786 (free_realized_faces_for_fontset): Remove; not used.
2787 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2788 does not deduce is never used uninitialized.
2789 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2790 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2792 * terminal.c (store_terminal_param): Now static.
2794 * xmenu.c (menu_highlight_callback): Now static.
2795 (set_frame_menubar): Remove unused local.
2796 (xmenu_show): Rename parameter to avoid shadowing.
2797 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2798 since they might point to immutable storage.
2799 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2800 since it's unused otherwise.
2802 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2803 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2804 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2805 avoids a gcc -Wuninitialized diagnostic.
2806 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2807 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2808 does not deduce are never used uninitialized.
2810 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2812 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2813 * window.c (window_loop, size_window):
2814 (run_window_configuration_change_hook, enlarge_window): Likewise.
2816 * window.c (display_buffer): Now static.
2817 (size_window): Mark variables that gcc -Wuninitialized
2818 does not deduce are never used uninitialized.
2819 * window.h (check_all_windows): New decl, to forestall
2820 gcc -Wmissing-prototypes diagnostic.
2821 * dispextern.h (bidi_dump_cached_states): Likewise.
2823 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2825 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2827 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2828 and to avoid gcc -Wuninitialized warning.
2829 (load_charset_map): Mark variables that gcc -Wuninitialized
2830 does not deduce are never used uninitialized.
2831 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2833 * coding.c (coding_set_source, coding_set_destination):
2834 Use "else { /* comment */ }" rather than "else /* comment */;"
2835 for clarity, and to avoid gcc -Wempty-body warning.
2836 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2837 a block, when the outer 'i' will do.
2838 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2839 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2840 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2841 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2842 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2843 Rename locals to avoid shadowing.
2844 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2845 * coding.c (emacs_mule_char, encode_invocation_designation):
2846 Now static, since they're not used elsewhere.
2847 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2848 (decode_coding_object, encode_coding_object, detect_coding_system):
2849 (decode_coding_emacs_mule): Mark variables that gcc
2850 -Wuninitialized does not deduce are never used uninitialized.
2851 (detect_coding_iso_2022): Initialize a local variable that might
2852 be used uninitialized. Leave a FIXME because it's not clear that
2853 this initialization is needed. (Bug#8211)
2854 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2855 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2856 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2857 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2858 Remove unused macros.
2860 * category.c (hash_get_category_set): Remove unused local var.
2861 (copy_category_table): Now static, since it's not used elsewhere.
2862 * character.c (string_count_byte8): Likewise.
2864 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2865 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2867 * chartab.c (copy_sub_char_table): Now static, since it's not used
2869 (sub_char_table_ref_and_range, char_table_ref_and_range):
2870 Rename locals to avoid shadowing.
2871 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2873 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2874 (BIDI_BOB): Remove unused macro.
2876 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2877 deduce are never used uninitialized.
2878 * term.c (encode_terminal_code): Likewise.
2880 * term.c (encode_terminal_code): Now static. Remove unused local.
2882 * tparam.h: New file.
2883 * term.c, tparam.h: Include it.
2884 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2885 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2886 Move these decls to tparam.h, and make them agree with what
2887 is actually in tparam.c. The previous trick of using incompatible
2888 decls in different modules does not conform to the C standard.
2889 All callers of tparam changed to use tparam's actual API.
2890 * tparam.c (tparam1, tparam, tgoto):
2891 Use const pointers where appropriate.
2893 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2894 * cm.h (struct cm): Likewise.
2895 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2896 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2897 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2898 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2899 (turn_on_face, init_tty): Likewise.
2900 * termchar.h (struct tty_display_info): Likewise.
2902 * term.c (term_mouse_position): Rename local to avoid shadowing.
2904 * alloc.c (mark_ttys): Move decl from here ...
2905 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2907 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2909 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2911 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2913 * search.c (compile_pattern_1): Remove argument regp, unused since
2914 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2915 (compile_pattern): Don't pass it.
2917 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2919 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2920 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2922 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2924 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2926 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2927 gdk_window_get_screen, gdk_window_get_geometry,
2928 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2929 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2930 (xg_get_pixbuf_from_pixmap): New function.
2931 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2932 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2933 Call xg_get_pixbuf_from_pixmap instead of
2934 gdk_pixbuf_get_from_drawable.
2935 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2936 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2937 (xg_check_special_colors): Use GtkStyleContext and its functions
2939 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2940 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2941 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2942 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2943 Call gtk_widget_get_preferred_size.
2944 (xg_frame_resized): gdk_window_get_geometry only takes 5
2946 (xg_win_to_widget, xg_event_is_for_menubar):
2947 Call gdk_x11_window_lookup_for_display.
2948 (xg_set_widget_bg): New function.
2949 (delete_cb): New function.
2950 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2951 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2952 (xg_set_background_color): Call xg_set_widget_bg.
2953 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2954 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2955 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2956 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2958 (update_frame_tool_bar): Call gtk_widget_hide.
2959 (xg_initialize): Use GDK_KEY_g.
2961 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2963 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2965 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2966 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2967 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2969 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2971 * w32xfns.c (select_palette): Check success of RealizePalette against
2972 GDI_ERROR, not zero.
2974 See ChangeLog.11 for earlier changes.
2980 Copyright (C) 2011 Free Software Foundation, Inc.
2982 This file is part of GNU Emacs.
2984 GNU Emacs is free software: you can redistribute it and/or modify
2985 it under the terms of the GNU General Public License as published by
2986 the Free Software Foundation, either version 3 of the License, or
2987 (at your option) any later version.
2989 GNU Emacs is distributed in the hope that it will be useful,
2990 but WITHOUT ANY WARRANTY; without even the implied warranty of
2991 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2992 GNU General Public License for more details.
2994 You should have received a copy of the GNU General Public License
2995 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.