Document negative repeat counts for search-forward and search-backward.
[bpt/emacs.git] / src / ChangeLog
1 2012-01-26 Chong Yidong <cyd@gnu.org>
2
3 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4 repeat counts (Bug#10507).
5
6 2012-01-26 Glenn Morris <rgm@gnu.org>
7
8 * lread.c (syms_of_lread): Doc fix.
9
10 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
11
12 * coding.c (encode_designation_at_bol): Change return value to
13 EMACS_INT.
14
15 2012-01-25 Chong Yidong <cyd@gnu.org>
16
17 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
18
19 2012-01-21 Chong Yidong <cyd@gnu.org>
20
21 * floatfns.c (Fcopysign): Make the second argument non-optional,
22 since nil is not allowed anyway.
23
24 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
25
26 * process.c (read_process_output): Use p instead of XPROCESS (proc).
27 (send_process): Likewise.
28
29 2012-01-19 Martin Rudalics <rudalics@gmx.at>
30
31 * window.c (save_window_save, Fcurrent_window_configuration)
32 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
33 doc-strings.
34
35 2012-01-19 Kenichi Handa <handa@m17n.org>
36
37 * character.c (char_width): New function.
38 (Fchar_width, c_string_width, lisp_string_width):
39 Use char_width (Bug#9496).
40
41 2012-01-16 Martin Rudalics <rudalics@gmx.at>
42
43 * window.c (Vwindow_persistent_parameters): New variable.
44 (Fset_window_configuration, save_window_save): Handle persistent
45 window parameters.
46
47 2012-01-14 Eli Zaretskii <eliz@gnu.org>
48
49 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
50 thrashing the stack of the thread. (Bug#9087)
51
52 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
53
54 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
55
56 2012-01-11 Eli Zaretskii <eliz@gnu.org>
57
58 * xdisp.c (rows_from_pos_range): Handle the case where the
59 highlight ends on a newline. (Bug#10464)
60 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
61 he end column for display of highlight that ends on a newline
62 before a R2L line.
63
64 2012-01-11 Glenn Morris <rgm@gnu.org>
65
66 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
67 from load-path also when installation-directory is nil. (Bug#10208)
68
69 2012-01-10 Glenn Morris <rgm@gnu.org>
70
71 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
72
73 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
74 Update template values to be closer to their typical values these days.
75
76 2012-01-09 Eli Zaretskii <eliz@gnu.org>
77
78 * xdisp.c (rows_from_pos_range): Accept additional argument
79 DISP_STRING, and accept any glyph in a row whose object is that
80 string as eligible for mouse highlight. Fixes mouse highlight of
81 display strings from overlays. (Bug#10464)
82
83 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
84
85 emacs: fix an auto-save permissions race condition (Bug#10400)
86 * fileio.c (auto_saving_dir_umask): New static var.
87 (Fmake_directory_internal): Use it.
88 (do_auto_save_make_dir): Set it, instead of invoking chmod after
89 creating the directory. The old code temporarily assigns
90 too-generous permissions to the directory.
91 (do_auto_save_eh): Clear it.
92 (Fdo_auto_save): Catch all errors, not just file errors, so
93 that the var is always cleared.
94
95 2012-01-07 Eli Zaretskii <eliz@gnu.org>
96
97 * search.c (scan_buffer): Pass character positions to
98 know_region_cache, not byte positions. (Bug#6540)
99
100 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
101
102 * w32.c (sys_rename): Report EXDEV when rename of a directory
103 fails because the target is on another logical disk. (Bug#10284)
104
105 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
106
107 * xterm.c (x_embed_request_focus): New function.
108
109 * xterm.h: Add prototype.
110
111 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
112
113 2012-01-05 Glenn Morris <rgm@gnu.org>
114
115 * emacs.c (emacs_copyright): Update short copyright year to 2012.
116
117 2012-01-01 Eli Zaretskii <eliz@gnu.org>
118
119 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
120 Load gnutls_transport_set_lowat only if GnuTLS version is below
121 2.11.1.
122 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
123 GnuTLS versions below 2.11.1.
124
125 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
126
127 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
128 to the doc string advising against its use for altering the way
129 windows are scrolled.
130
131 2011-12-28 Kenichi Handa <handa@m17n.org>
132
133 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
134 coding-system ASCII compatible only when it does not produce BOM
135 on encoding (Bug#10383).
136
137 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
138
139 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
140 can scroll.
141 (create_and_show_popup_menu): Always use menu_position_func for
142 Gtk3 (Bug#10361).
143
144 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
145
146 * callint.c (Fcall_interactively): Don't truncate prompt string.
147
148 2011-12-23 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
151 property that ends at ZV, so that the bidi iteration could be
152 resumed from there (after widening). (Bug#10360)
153
154 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
155
156 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
157
158 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
159
160 * nsterm.m (x_free_frame_resources):
161 Release f->output_data.ns->miniimage.
162 (ns_index_color): Fix indentation. Do not retain
163 color_table->colors[i].
164
165 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
166 before returning.
167
168 * nsfns.m (x_set_background_color): Assign return value from
169 ns_index_color to face-background instead of NSColor*.
170 (ns_implicitly_set_icon_type): Fix indentation.
171 Change assignment in for loop to comparison.
172
173 * emacs.c (ns_pool): New variable.
174 (main): Assign ns_pool.
175 (Fkill_emacs): Call ns_release_autorelease_pool.
176
177 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
178 autorelease fdesc, release fdAttrs and tdict.
179 (ns_get_covering_families): Release charset.
180 (ns_findfonts): Release NSFontDescriptor created with new.
181 (ns_uni_to_glyphs): Fix indentation.
182 (setString): Release attrStr before assigning new value.
183
184 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
185
186 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
187 and NS_IMPL_COCOA.
188 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
189 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
190
191 2011-12-18 David Reitter <reitter@cmu.edu>
192
193 * nsterm.m (ns_term_init): Subscribe for notifications
194 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
195 to method trackingNotification in EmacsMenu.
196
197 * nsmenu.m (trackingMenu): New variable.
198 (trackingNotification): New method (from Aquamacs).
199 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
200 from Aquamacs (Bug#7030).
201
202 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
203
204 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
205 (symbol_to_nsstring): Fix indentation.
206 (ns_symbol_to_pb): New function.
207 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
208 (Fns_rotate_cut_buffers_internal): Removed.
209 (Fns_store_selection_internal): Renamed from
210 Fns_store_cut_buffer_internal.
211 (ns_get_foreign_selection, Fx_own_selection_internal)
212 (Fx_disown_selection_internal, Fx_selection_exists_p)
213 (Fns_get_selection_internal, Fns_store_selection_internal):
214 Use ns_symbol_to_pb and check if return value is nil.
215 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
216 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
217 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
218 renamed to Sns_store_selection_internal.
219 (ns_handle_selection_request): Move code to Fx_own_selection_internal
220 and remove this function.
221 (ns_handle_selection_clear): Remove, never used.
222 (Fx_own_selection_internal): Move code from ns_handle_selection_request
223 here.
224
225 2011-12-17 Ken Brown <kbrown@cornell.edu>
226
227 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
228 GID is unknown (Bug#10257).
229
230 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
231
232 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
233 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
234 which caused a build failure on GNU/Linux IA-64. This problem was
235 introduced by my 2011-10-07 patch.
236
237 2011-12-15 Juri Linkov <juri@jurta.org>
238
239 * image.c (imagemagick_error): New function. (Bug#10112)
240 (imagemagick_load_image): Comment out `MagickSetResolution' call.
241 Use `imagemagick_error' where ImageMagick functions return
242 `MagickFalse'.
243 (Fimagemagick_types): Add `Fnreverse' to return the list in the
244 proper order.
245
246 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
247
248 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
249 fill background (Bug#8992).
250
251 2011-12-13 Martin Rudalics <rudalics@gmx.at>
252
253 * window.c (Vwindow_combination_resize)
254 (Vwindow_combination_limit): Use t instead of non-nil in
255 doc-strings.
256 (Vrecenter_redisplay): Add first sentence of doc-string on
257 separate line.
258 (Frecenter): Fix doc-string typo.
259
260 2011-12-11 Kenichi Handa <handa@m17n.org>
261
262 * coding.c (Funencodable_char_position): Pay attention to the
263 buffer text relocation (Bug#9389).
264
265 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
266
267 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
268 gtk_init (Bug#10100).
269
270 2011-12-10 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
273 IT->string is nil. (Bug#10263)
274
275 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
276
277 * nsterm.h (x_free_frame_resources): Declare.
278
279 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
280 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
281
282 * nsterm.h (ns_get_defaults_value): Declare.
283
284 * nsterm.m (ns_default): Call ns_get_defaults_value.
285
286 2011-12-09 Eli Zaretskii <eliz@gnu.org>
287
288 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
289 (Bug#10170)
290
291 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
292
293 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
294 that where the value of an _OBJC_* symbol points to is in the .bss
295 section (Bug#10240).
296
297 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
298
299 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
300 after the loop to call ccl_driver at least once (Bug#8619).
301
302 2011-12-08 Kenichi Handa <handa@m17n.org>
303
304 * ftfont.c (get_adstyle_property): Fix previous change
305 (Bug#10233).
306
307 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
308
309 * w32.c (init_environment): If no_site_lisp, remove site-lisp
310 dirs from the default value of EMACSLOADPATH (bug#10208).
311
312 2011-12-07 Glenn Morris <rgm@gnu.org>
313
314 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
315 installation and source directories as well. (Bug#10208)
316
317 2011-12-06 Chong Yidong <cyd@gnu.org>
318
319 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
320
321 2011-12-06 Glenn Morris <rgm@gnu.org>
322
323 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
324 as an error, not just -1. (Bug#10217)
325
326 2011-12-05 Chong Yidong <cyd@gnu.org>
327
328 * keyboard.c (process_special_events): New function.
329 (swallow_events, Finput_pending_p): Use it (Bug#10195).
330
331 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
332
333 * coding.c (encode_designation_at_bol): Don't use uninitialized
334 local variable (Bug#9318).
335
336 2011-12-05 Kenichi Handa <handa@m17n.org>
337
338 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
339 return Qnil (Bug#8046, Bug#10193).
340
341 2011-12-05 Kenichi Handa <handa@m17n.org>
342
343 * coding.c (encode_designation_at_bol): New args charbuf_end and
344 dst. Return the number of produced bytes. Callers changed.
345 (coding_set_source): Return how many bytes coding->source was
346 relocated.
347 (coding_set_destination): Return how many bytes
348 coding->destination was relocated.
349 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
350 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
351
352 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
353
354 * coding.c (CODING_CHAR_CHARSET_P): New macro.
355 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
356 macro (Bug#9318).
357
358 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
359
360 The following changes are to fix Bug#9318.
361
362 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
363 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
364 (encode_coding_iso_2022, encode_coding_sjis)
365 (encode_coding_big5, encode_coding_charset): Use the above macros.
366
367 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
368
369 * lisp.h (process_quit_flag): Fix external declaration.
370
371 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
372
373 Don't macro-inline non-performance-critical code.
374 * eval.c (process_quit_flag): New function.
375 * lisp.h (QUIT): Use it.
376
377 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
378
379 * nsfns.m (get_geometry_from_preferences): New function.
380 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
381
382 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
383
384 * emacs.c (Qkill_emacs): Define.
385 (syms_of_emacs): Initialize it.
386 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
387 Qquit_flag to `kill-emacs' instead.
388 (quit_throw_to_read_char): Add parameter `from_signal'.
389 All callers changed. Call Fkill_emacs if requested and safe.
390 * lisp.h (QUIT): Call Fkill_emacs if requested.
391
392 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
393
394 * widget.c (update_wm_hints): Return if wmshell is null.
395 (widget_update_wm_size_hints): New function.
396
397 * widget.h (widget_update_wm_size_hints): Declare.
398
399 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
400 widget_update_wm_size_hints (Bug#10104).
401
402 2011-12-03 Eli Zaretskii <eliz@gnu.org>
403
404 * xdisp.c (handle_invisible_prop): If the invisible text ends just
405 before a newline, prepare the bidi iterator for consuming the
406 newline, and keep the current paragraph direction. (Bug#10183)
407 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
408
409 2011-12-02 Juri Linkov <juri@jurta.org>
410
411 * search.c (Fword_search_regexp): New Lisp function created from
412 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
413 (Fword_search_backward, Fword_search_forward)
414 (Fword_search_backward_lax, Fword_search_forward_lax):
415 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
416 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
417
418 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
419
420 * fileio.c (Finsert_file_contents): Move after-change-function call
421 to before the "handled:" label, since all "goto handled" appear in
422 cases where the *-change-functions have already been properly called
423 (bug#10117).
424
425 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
426
427 * keyboard.c (interrupt_signal): Don't call kill-emacs when
428 waiting for input. (Bug#10169)
429
430 2011-11-30 Eli Zaretskii <eliz@gnu.org>
431
432 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
433 verifies glyph row's hash code--we have just reallocated the
434 glyphs, so their contents can be complete garbage. (Bug#10164)
435
436 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
437
438 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
439
440 2011-11-30 Eli Zaretskii <eliz@gnu.org>
441
442 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
443 attributes are tested _before_ calling verify_row_hash, to protect
444 against GCC re-ordering of the tests. (Bug#10164)
445
446 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
447
448 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
449
450 * xterm.c (handle_one_xevent): Only set async_visible and friends
451 if net_wm_state_hidden_seen is non-zero (Bug#10002)
452 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
453 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
454
455 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
456
457 Remove GCPRO-related macros that exist only to avoid shadowing locals.
458 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
459 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
460 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
461 All uses changed to use GCPRO1 etc.
462 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
463 Revert to old implementation (i.e., before 2011-03-11).
464
465 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
466
467 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
468 of scroll runs so as to avoid assigning disabled bogus rows and
469 unnecessary graphics copy operations.
470
471 2011-11-27 Eli Zaretskii <eliz@gnu.org>
472
473 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
474 (snprintf) [_MSC_VER]: Redirect to _snprintf.
475 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
476 (malloc, free, realloc, calloc): Redirect to e_* only when
477 compiling Emacs.
478
479 * lisp.h (GCTYPEBITS): Move before first use.
480 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
481 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
482 this macro definition.
483
484 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
485 _MSC_VER.
486
487 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
488
489 * gtkutil.c (xg_create_frame_widgets):
490 Call gtk_window_set_has_resize_grip (FALSE) if that function is
491 present with Gtk+ 2.0.
492
493 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
494
495 * fileio.c (Finsert_file_contents): Undo previous change; see
496 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
497
498 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
499
500 Rename locals to avoid shadowing.
501 * fileio.c (Finsert_file_contents):
502 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
503 * process.c (wait_reading_process_output):
504 Rename inner 'proc' to 'p' to avoid shadowing.
505 Indent for consistency with usual Emacs style.
506
507 2011-11-25 Eli Zaretskii <eliz@gnu.org>
508
509 * xdisp.c (redisplay_window): If cursor row is not fully visible
510 after recentering, and scroll-conservatively is set to a large
511 number, scroll window by a few more lines to make the cursor fully
512 visible and out of scroll-margin. (Bug#10105)
513 (start_display): Don't move to the next line if the display should
514 start at a newline that is part of a display vector or an overlay
515 string. (Bug#10119)
516
517 2011-11-24 Juri Linkov <juri@jurta.org>
518
519 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
520 after the `MagickPingImage' call. (Bug#10112)
521
522 2011-11-23 Chong Yidong <cyd@gnu.org>
523
524 * window.c (Fcoordinates_in_window_p): Accept only live windows.
525
526 2011-11-23 Martin Rudalics <rudalics@gmx.at>
527
528 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
529 making another buffer current. (Bug#10114)
530
531 2011-11-23 Glenn Morris <rgm@gnu.org>
532
533 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
534
535 2011-11-23 Chong Yidong <cyd@gnu.org>
536
537 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
538 using it (Bug#5984).
539
540 2011-11-22 Eli Zaretskii <eliz@gnu.org>
541
542 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
543 and header-lines, as they don't have one computed for them.
544 (Bug#10098)
545
546 * .gdbinit (prow): Make displayed values more self-explaining.
547 Add row's hash code.
548
549 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
550
551 * process.c (wait_reading_process_output): Fix asynchrounous
552 GnuTLS socket handling on some versions of the GnuTLS library.
553 (wait_reading_process_output): Add comment and URL.
554
555 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
556
557 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
558
559 2011-11-21 Chong Yidong <cyd@gnu.org>
560
561 * window.c (Fnext_window, Fprevious_window): Doc fix.
562
563 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
564
565 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
566
567 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
568
569 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
570
571 2011-11-20 Martin Rudalics <rudalics@gmx.at>
572
573 * window.c (Fset_window_combination_limit): Rename argument
574 STATUS to LIMIT.
575 (Vwindow_combination_limit): Remove "status" from doc-string.
576
577 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
578
579 * m/ibms390.h: Remove.
580 * m/ibms390x.h: Don't include "ibms390.h".
581
582 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
583
584 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
585 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
586
587 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
588
589 * casetab.c (Fset_case_table):
590 * charset.c (Fcharset_after): Fix typos.
591
592 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
593
594 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
595 Otherwise, valgrind does not work on some platforms.
596 Problem reported by Andreas Schwab in
597 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
598 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
599 is set, removing the need for VIRT_ADDRESS_VARIES.
600 (PURE_P): Use a more-efficient implementation that needs just one
601 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
602 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
603 to 4 (xorl, subq, cmpq, setbe).
604 * alloc.c (pure): Always extern now, since that's the
605 VIRT_ADDR_VARIES behavior.
606 (PURE_POINTER_P): Use a single comparison, not two, for
607 consistency with the new puresize.h.
608 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
609 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
610 Remove VIRT_ADDR_VARIES no longer needed.
611
612 2011-11-19 Eli Zaretskii <eliz@gnu.org>
613
614 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
615 (erase_phys_cursor, update_window_cursor, show_mouse_face)
616 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
617 behave as if the cursor position were at the window margin.
618
619 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
620 and the cursor position is out of bounds, behave as if the cursor
621 position were at the window margin. (Bug#10075)
622
623 2011-11-18 Chong Yidong <cyd@gnu.org>
624
625 * window.c (Fwindow_combination_limit): Make first argument
626 non-optional, since it is meaningless for live windows like the
627 selected window.
628
629 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
630
631 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
632
633 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
634
635 * intervals.c: Fix grafting over the whole buffer (bug#10071).
636 (graft_intervals_into_buffer): Simplify.
637
638 2011-11-18 Eli Zaretskii <eliz@gnu.org>
639
640 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
641 hash values of the two rows.
642 (copy_row_except_pointers): Preserve the used[] arrays and the
643 hash values of the two rows. (Bug#10035)
644 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
645
646 * xdisp.c (row_hash): New function, body extracted from
647 compute_line_metrics.
648 (compute_line_metrics): Call row_hash, instead of computing the
649 hash code inline.
650
651 * dispnew.c (verify_row_hash): Call row_hash for computing the
652 hash code of a row, instead of duplicating code from xdisp.c.
653
654 * dispextern.h (row_hash): Add prototype.
655
656 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
657
658 * frame.c (delete_frame): Don't delete the terminal when the last
659 X frame is closed if emacs is built with GTK toolkit.
660
661 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
662
663 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
664
665 2011-11-17 Martin Rudalics <rudalics@gmx.at>
666
667 * window.c (Vwindow_splits): Rename to
668 Vwindow_combination_resize. Suggested by Juri Linkov.
669 (Fsplit_window_internal): Use Vwindow_combination_resize instead
670 of Vwindow_splits.
671
672 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
673
674 * nsfns.m (Fns_font_name):
675 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
676
677 2011-11-16 Martin Rudalics <rudalics@gmx.at>
678
679 * window.h (window): Rename slot "nest" to "combination_limit".
680 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
681 (Fset_window_nest): Rename to Fset_window_combination_limit.
682 (Vwindow_nest): Rename to Vwindow_combination_limit.
683 (recombine_windows, make_parent_window, make_window)
684 (Fsplit_window_internal, saved_window)
685 (Fset_window_configuration, save_window_save): Rename all
686 occurrences of window_nest to window_combination_limit.
687
688 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
689
690 * image.c (imagemagick_load_image): Fix typo.
691
692 2011-11-14 Eli Zaretskii <eliz@gnu.org>
693
694 * xdisp.c (display_line): Move the call to
695 highlight_trailing_whitespace before the call to
696 compute_line_metrics, since the latter needs to see the final
697 faces of all the glyphs to compute ROW's hash value.
698 Fixes assertion violations in row_equal_p. (Bug#10035)
699
700 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
701
702 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
703 just return (bug#10044).
704
705 2011-11-12 Eli Zaretskii <eliz@gnu.org>
706
707 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
708 with user-defined heap size. Bump the default size of the temacs
709 heap to 27MB, to avoid memory warning when running temacs.
710 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
711
712 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
713 current_matrix and desired_matrix. (Bug#9990)
714 (verify_row_hash) [XASSERTS]: New function.
715 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
716 that the hash value of glyph rows is correct.
717
718 2011-11-12 Martin Rudalics <rudalics@gmx.at>
719
720 * window.h (window): Remove splits slot.
721 * window.c (Fwindow_splits, Fset_window_splits): Remove.
722 (Fdelete_other_windows_internal, make_parent_window)
723 (make_window, Fsplit_window_internal, Fdelete_window_internal)
724 (Fset_window_configuration, save_window_save): Don't deal with
725 split status of windows.
726 (saved_window): Remove splits slot.
727 (Vwindow_splits): Rewrite doc-string.
728
729 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
730
731 * xfns.c (unwind_create_frame):
732 * nsfns.m (unwind_create_frame):
733 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
734 Vframe_list (Bug#9999).
735
736 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
737
738 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
739
740 2011-11-11 Kenichi Handa <handa@m17n.org>
741
742 * callproc.c (Fcall_process): Set the member dst_multibyte of
743 process_coding.
744
745 2011-11-11 Johan Bockgård <bojohan@gnu.org>
746
747 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
748 avoid a crash (bug#9496).
749
750 2011-11-09 Chong Yidong <cyd@gnu.org>
751
752 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
753 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
754
755 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
756
757 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
758
759 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
760
761 Avoid some portability problems by eschewing 'extern inline' functions.
762 The trivial performance wins aren't worth the portability hassles; see
763 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
764 et seq.
765 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
766 (window_box_width, window_box_left, window_box_left_offset)
767 (window_box_right, window_box_right_offset): Undo previous change,
768 by removing the "extern"s.
769 * intervals.c (adjust_intervals_for_insertion)
770 (adjust_intervals_for_deletion): Undo previous change,
771 making these static again.
772 (offset_intervals, temp_set_point_both, temp_set_point)
773 (copy_intervals_to_string): No longer inline.
774 * xdisp.c (window_text_bottom_y, window_box_width)
775 (window_box_height, window_box_left_offset)
776 (window_box_right_offset, window_box_left, window_box_right)
777 (window_box): No longer inline.
778
779 2011-11-08 Chong Yidong <cyd@gnu.org>
780
781 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
782 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
783 Signal an error if not a live window.
784 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
785 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
786
787 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
788
789 * lisp.h (syms_of_abbrev): Remove declaration.
790 Reported by CHENG Gao <chenggao@royau.me>.
791
792 2011-11-07 Eli Zaretskii <eliz@gnu.org>
793
794 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
795 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
796 of temacs in GUI mode.
797
798 2011-11-07 Martin Rudalics <rudalics@gmx.at>
799
800 * window.h: Declare delete_all_child_windows instead of
801 delete_all_subwindows.
802 * window.c (Fwindow_nest, Fset_window_nest)
803 (Fset_window_new_total, Fset_window_new_normal)
804 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
805 (delete_all_subwindows): Rename to delete_all_child_windows.
806 (Fdelete_other_windows_internal, Fset_window_configuration):
807 Call delete_all_child_windows instead of delete_all_subwindows.
808 * frame.c (delete_frame): Call delete_all_child_windows instead
809 of delete_all_subwindows.
810
811 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
812
813 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
814 This is also needed for porting to any host where GC_MARK_STACK is
815 not GC_MAKE_GCPROS_NOOPS.
816 (which_symbols): Use it.
817
818 2011-11-07 Kenichi Handa <handa@m17n.org>
819
820 * coding.c (coding_set_destination): Check coding->src_pos only
821 when coding->src_object is a buffer (bug#9910).
822
823 * process.c (send_process): Set the member src_multibyte of coding
824 to 0 (bug#9911) when sending a unibyte text.
825
826 * callproc.c (Fcall_process): Set the member src_multibyte of
827 process_coding to 0 (bug#9912).
828
829 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
830
831 * xmenu.c (cleanup_widget_value_tree): New function.
832 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
833 calling free_menubar_widget_value_tree directly (Bug#9830).
834
835 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
836
837 Fix some portability problems with 'inline'.
838 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
839 (window_box_width, window_box_left, window_box_left_offset)
840 (window_box_right, window_box_right_offset): Declare extern.
841 Otherwise, these inline functions do not conform to C99 and
842 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
843 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
844 * intervals.c (adjust_intervals_for_insertion)
845 (adjust_intervals_for_deletion): Now extern, because otherwise the
846 extern inline functions 'offset_intervals' couldn't refer to it.
847 (static_offset_intervals): Remove.
848 (offset_intervals): Rewrite using the old contents of
849 static_offset_intervals. The old version didn't conform to C99
850 because an extern inline function contained a reference to an
851 identifier with static linkage.
852
853 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
854
855 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
856 GC.
857
858 2011-11-06 Eli Zaretskii <eliz@gnu.org>
859
860 * xdisp.c (init_iterator, reseat_to_string): Don't set the
861 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
862 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
863 return Qleft_to_right.
864
865 2011-11-06 Chong Yidong <cyd@gnu.org>
866
867 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
868 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
869 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
870 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
871 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
872 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
873 (Fwindow_vscroll): Doc fix.
874 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
875 argument, since it makes no sense to pass a live window and for
876 consistency with window-child.
877
878 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
879
880 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
881 support MSVC.
882
883 2011-11-05 Jason Rumney <jasonr@gnu.org>
884
885 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
886 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
887 fonts (Bug#6029).
888 (add_font_entity_to_list): Fix logic errors in mixed boolean and
889 bitwise arithmetic preventing use of unicode-sip and non-truetype
890 opentype fonts.
891
892 2011-11-05 Eli Zaretskii <eliz@gnu.org>
893
894 * s/ms-w32.h (fstat, stat, utime): Move redirections to
895 "emacs"-only part.
896
897 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
898 initialization code to keep similarity to xfns.c after changes
899 from 2011-11-05.
900
901 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
902
903 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
904 (unwind_create_frame): New function (Bug#9943).
905 (Fx_create_frame): Restructure code to be more similar to the one in
906 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
907 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
908 Move terminal->reference_count++ just before making the frame official
909 (Bug#9943).
910
911 * nsterm.m (x_free_frame_resources): New function.
912 (x_destroy_window): Move code to x_free_frame_resources.
913
914 * xfns.c (unwind_create_frame): Fix comment.
915 (Fx_create_frame, x_create_tip_frame):
916 Move terminal->reference_count++ just before making the frame
917 official. Move initialization of image_cache_refcount and
918 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
919
920 2011-11-05 Eli Zaretskii <eliz@gnu.org>
921
922 Support MSVC build with newer versions of Visual Studio.
923 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
924 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
925 nt/gmake.defs.
926
927 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
928 which are not supported by MSVC.
929 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
930 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
931 bitfields.
932 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
933 types in bitfields.
934 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
935
936 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
937
938 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
939
940 Support MSVC build with newer versions of Visual Studio.
941 * w32.c: Don't include w32api.h for MSVC.
942 (init_environment) [_MSC_VER]: Call sys_access, not _access.
943
944 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
945 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
946 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
947 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
948 e_* cousins.
949 (alloca) [_MSC_VER]: Define to _alloca.
950
951 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
952
953 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
954
955 2011-11-04 Eli Zaretskii <eliz@gnu.org>
956
957 * xdisp.c (note_mouse_highlight): If either of
958 previous/next-single-property-change returns nil, treat that as
959 the beginning or the end of the buffer. (Bug#9955)
960
961 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
962
963 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
964 label is not null (Bug#9951).
965 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
966 may be NULL.
967
968 2011-11-04 Eli Zaretskii <eliz@gnu.org>
969
970 * window.c (Fwindow_body_size): Mention in the doc string that the
971 return value is in frame's canonical units. (Bug#9949)
972
973 2011-11-03 Eli Zaretskii <eliz@gnu.org>
974
975 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
976
977 * w32fns.c (unwind_create_frame): If needed, free the glyph
978 matrices of the partially constructed frame. (Bug#9943)
979 * xfns.c (unwind_create_frame): Likewise.
980
981 2011-11-01 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
984 Don't stop backward scan on the continuation glyph, even though
985 its CHARPOS is positive.
986 (mouse_face_from_buffer_pos, note_mouse_highlight):
987 Rename cover_string to disp_string.
988
989 2011-11-01 Martin Rudalics <rudalics@gmx.at>
990
991 * window.c (temp_output_buffer_show): Don't use
992 Vtemp_buffer_show_specifiers.
993 (Vtemp_buffer_show_specifiers): Remove unused variable.
994
995 2011-10-30 Eli Zaretskii <eliz@gnu.org>
996
997 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
998 past the beginning of the current glyph matrix.
999
1000 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1001
1002 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1003 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1004 HAVE_GTK3 (Bug#9869).
1005
1006 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1007 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1008
1009 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1010
1011 * xterm.c: Declare x_handle_net_wm_state to return int.
1012 (handle_one_xevent): Check if we are iconified but don't have
1013 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1014 (get_current_wm_state): Return non-zero if not hidden,
1015 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1016 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1017 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1018 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1019
1020 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1021
1022 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1023 so that this new function doesn't get optimized away by a
1024 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1025
1026 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1029
1030 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1031
1032 Fix the `xbytecode' command.
1033 * .gdbinit (xprintbytestr): New command.
1034 (xwhichsymbols): Rename from `which'; all callers changed.
1035 (xbytecode): Print the byte-code string as well.
1036
1037 2011-10-29 Kim Storm <storm@cua.dk>
1038
1039 * alloc.c (which_symbols): New function.
1040
1041 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1044 line. (Bug#9903)
1045
1046 2011-10-29 Glenn Morris <rgm@gnu.org>
1047
1048 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1049 Not clear what it was for, and it causes various bugs. (Bug#9839)
1050
1051 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1054 possible random value that matches one of those tested as
1055 condition to clear the mouse face.
1056
1057 2011-10-28 Chong Yidong <cyd@gnu.org>
1058
1059 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1060
1061 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1062
1063 * window.c (make_window): Initialize phys_cursor_on_p.
1064
1065 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * lisp.h (struct Lisp_Symbol): Update comments.
1068
1069 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1070
1071 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1072
1073 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1074
1075 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1076 <oslsachem@gmail.com> for helping to debug this.
1077
1078 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1079 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1080 (g_b_init_get_glyph_outline_w): New static variables.
1081 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1082 (GetGlyphOutlineW_Proc): New typedefs.
1083 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1084 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1085 New functions.
1086 (w32font_open_internal, compute_metrics):
1087 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1088 instead of calling the "wide" APIs directly.
1089
1090 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1091
1092 * w32.h (syms_of_w32font): Add prototype.
1093
1094 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1097 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1098 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1099 (Fmove_to_window_line): Doc fix.
1100
1101 2011-10-27 Chong Yidong <cyd@gnu.org>
1102
1103 * process.c (make_process): Set gnutls_state to NULL.
1104
1105 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1106 non-NULL, regardless of GNUTLS_INITSTAGE.
1107 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1108 an error. Set process slots as soon as we allocate them.
1109
1110 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1111
1112 2011-10-27 Chong Yidong <cyd@gnu.org>
1113
1114 * gnutls.c (emacs_gnutls_deinit): New function.
1115 Deallocate credentials structures as well as calling gnutls_deinit.
1116 (Fgnutls_deinit, Fgnutls_boot): Use it.
1117
1118 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1119 (deactivate_process): Call emacs_gnutls_deinit.
1120
1121 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1122
1123 * image.c (x_create_x_image_and_pixmap):
1124 * w32.c (sys_rename, w32_delayed_load):
1125 * w32font.c (fill_in_logfont):
1126 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1127
1128 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * w32fns.c (w32_default_color_map): New function,
1131 extracted from Fw32_default_color_map.
1132 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1133
1134 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1137
1138 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1139
1140 * keyboard.c (test_undefined): New function (bug#9751).
1141 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1142
1143 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1144
1145 * sysdep.c (init_sys_modes): Fix the check for the controlling
1146 terminal (Bug#6649).
1147
1148 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1149
1150 * dispextern.h (struct bidi_it): New member next_en_type.
1151
1152 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1153 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1154 current character, check also for next_en_type being WEAK_EN.
1155 (bidi_resolve_weak): Don't enter the expensive loop if the current
1156 position is before next_en_pos. Record the bidi type of the first
1157 non-ET, non-BN character we find, in addition to its position.
1158 (bidi_level_of_next_char): Invalidate next_en_type when
1159 next_en_pos is over-stepped.
1160
1161 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1164 * editfns.c: Rewrite current-time-zone so that it invokes
1165 the equivalent of (format-time-string "%Z") to get the time zone name.
1166 This fixes a bug when the time zone name contains characters that
1167 need converting from the system time locale to Emacs internal format.
1168 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1169 that patch fixed format-time-string to do the conversion, but
1170 I forgot to fix current-time-zone.
1171 (format_time_string): New function, containing most of
1172 what Fformat_time_string used to contain.
1173 (Fformat_time_string): Rewrite in terms of format_time_string.
1174 This doesn't change this function's behavior.
1175 (current-time-zone): Rewrite to use format_time_string.
1176 This fixes the bug reported by Michael Schierl in
1177 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1178 Jason Rumney's 2007-06-07 change worked around this bug, but
1179 didn't fix it.
1180 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1181
1182 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (start_display): If the character at POS is displayed
1185 via a display vector, reset IT->current.dpvec_index to zero.
1186 (try_window_reusing_current_matrix): If a line ends in a display
1187 vector or the next line starts in a display vector, continue
1188 redrawing the window even though the character position of
1189 start_row was reached.
1190 (Bug#9771, part 2)
1191
1192 2011-10-18 Chong Yidong <cyd@gnu.org>
1193
1194 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1195 with nobreak-char-display too.
1196
1197 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1198
1199 Fix part 3 of bug#9771.
1200 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1201 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1202 non-neutral characters if the current character is a paragraph
1203 separator (a.k.a. Newline). This avoids running the same
1204 expensive loop twice, once when we consume the preceding newline
1205 and the other time when the line actually needs to be displayed.
1206 Avoid the loop when we see neutrals on the base embedding level
1207 following a character whose directionality is the same as the
1208 paragraph's. This avoids running the expensive loop when a line
1209 ends in a long sequence of neutrals, like control characters.
1210 Add assertion against STRONG_AL type. Slightly rearrange code
1211 that determines the type of a neutral given the first non-neutral
1212 that follows it.
1213 (bidi_level_of_next_char): Set next_en_pos to zero when
1214 invalidating its info.
1215
1216 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1217
1218 * xdisp.c (push_display_prop): Determine whether to record string
1219 or buffer position by IT->string, not by IT->method. Allow
1220 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1221 (move_it_vertically_backward): Don't look for character position
1222 immediately after the newline when in a continuation line.
1223 (Bug#9771, part 1)
1224
1225 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1226
1227 * window.c (coordinates_in_window): Rewrite and delabelize
1228 vertical border check. (Bug#5357) (Bug#9618)
1229
1230 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1231
1232 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1233 errors in XSetWindowBorder (bug#9310).
1234
1235 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1238 avoid crash when xmalloc overrun checking is enabled.
1239
1240 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1241
1242 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1243 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1244 cursor motion with <left> and <right> arrow keys.
1245
1246 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1247 some callers set that themselves.
1248
1249 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1252 display string and the previous row comes from the same string and
1253 is empty. (Bug#9739) (Bug#9738)
1254
1255 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * doc.c (get_doc_string): Encode file name (bug#9735).
1258
1259 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1260
1261 * bidi.c (bidi_level_of_next_char):
1262 * xdisp.c (get_visually_first_element): Remove old incorrect
1263 comments regarding the Unicode Line Separator character.
1264
1265 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1266
1267 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 * alloc.c (Fgc_status): Do not access beyond zombies array
1270 boundary if nzombies > MAX_ZOMBIES.
1271 * alloc.c (dump_zombies): Add missing format specifier.
1272
1273 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1276 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1277
1278 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1279 Some packages use them to denote characters with modifiers.
1280
1281 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1282
1283 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1284 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1285 matching a pp-number. Rename parameter var to var1.
1286
1287 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1288
1289 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1290
1291 2011-10-08 Glenn Morris <rgm@gnu.org>
1292
1293 * callint.c (Fcall_interactively): Give a more explicit error for the
1294 'c' case with a non-character input. (Bug#8479)
1295
1296 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1299 lines.
1300 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1301 lines that are hscrolled on the left.
1302
1303 * dispnew.c (buffer_posn_from_coords): Account for a possible
1304 presence of header-line. (Bug#4426)
1305
1306 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1307
1308 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1309 Don't advertise functionality which we discourage or doesn't work.
1310
1311 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1314 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1315 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1316 this makes Emacs dump core during garbage collection on rare
1317 occasions. sizeof is obviously inferior to offsetof here, so
1318 stick with offsetof.
1319 (GC_POINTER_ALIGNMENT): New macro.
1320 (mark_memory): Omit 3rd (offset) arg; caller changed.
1321 Don't assume EMACS_INT alignment is the same as pointer alignment.
1322
1323 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1324
1325 * keyboard.c (read_key_sequence_remapped): New var.
1326 (read_key_sequence): Compute remapping in the right buffer.
1327 (command_loop_1): Use read_key_sequence's remapping directly.
1328
1329 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * dired.c (file_name_completion): Don't expand file name.
1332 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1333 before checking file name handler.
1334
1335 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1336 they've been requested explicitly (bug#9591).
1337
1338 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1339
1340 * keymap.c (Fsingle_key_description): Use make_specified_string
1341 instead of build_string to build string from push_key_description.
1342 (Bug#5193)
1343
1344 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1347 This fixes a Y2038 bug on 64-bit hosts.
1348 * buffer.c (reset_buffer):
1349 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1350 (Fclear_buffer_auto_save_failure):
1351 Use 0, not -1, to represent an unset failure time, since time_t
1352 might not be signed.
1353
1354 Remove dependency on glibc malloc internals.
1355 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1356 Move back here from lisp.h, but with their new implementations.
1357 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1358 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1359 * charset.c (charset_table_init): New static var.
1360 (syms_of_charset): Use it instead of xmalloc. This removes a
1361 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1362 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1363 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1364 Move back to alloc.c.
1365 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1366 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1367
1368 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1369
1370 * nsterm.m (windowDidResize): Call x_set_window_size only when
1371 ns_in_resize is true. Otherwise set pixelwidth/height and
1372 call change_frame_size (Bug#9628).
1373
1374 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Port --enable-checking=all to Fedora 14 x86-64.
1377 * charset.c (syms_of_charset): Also account for glibc malloc's
1378 internal overhead when calculating the initial malloc maximum.
1379
1380 Port --enable-checking=all to Fedora 14 x86.
1381 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1382 Move to lisp.h.
1383 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1384 (overrun_check_realloc, overrun_check_free):
1385 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1386 That way, xmalloc returns a properly-aligned pointer even if
1387 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1388 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1389 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1390 into account when calculating the initial malloc maximum.
1391 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1392 Move here from alloc.c, so that charset.c can use it too.
1393 Properly align; the old code wasn't right for common 32-bit hosts
1394 when configured with --enable-checking=all.
1395 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1396 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1397
1398 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1399
1400 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1401 use EDOM.
1402
1403 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1404
1405 * xdisp.c (compute_display_string_end): If there's no display
1406 string at CHARPOS, return -1.
1407
1408 * bidi.c (bidi_fetch_char): When compute_display_string_end
1409 returns a negative value, treat the character as a normal
1410 character not covered by a display string. (Bug#9624)
1411
1412 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1413
1414 * lread.c (Fread_from_string): Fix typo in docstring.
1415
1416 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1419 newline, reseat the iterator instead of bidi-iterating there one
1420 character at a time. (Bug#9610)
1421 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1422 TO_CHARPOS if the bidi iterator is at base embedding level.
1423
1424 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1425
1426 * lread.c (readevalloop): Use correct code for NBSP.
1427 (read1): Likewise. (Bug#9608)
1428
1429 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1430
1431 * dbusbind.c (Fdbus_register_signal): When service is not
1432 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1433
1434 2011-09-25 Glenn Morris <rgm@gnu.org>
1435
1436 * buffer.c (truncate-lines): Doc fix.
1437
1438 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1439
1440 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1441 (Fset_window_next_buffers): Doc fix.
1442
1443 2011-09-24 Glenn Morris <rgm@gnu.org>
1444
1445 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1446
1447 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 Fix minor problems found by static checking.
1450 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1451 * indent.c (Fvertical_motion): Fix == vs = typo.
1452
1453 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1454
1455 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1456 Default value is now t. Doc fix.
1457
1458 * indent.c (Fvertical_motion): Compute and apply the overshoot
1459 logic when moving up, not only when moving down. Fix the
1460 confusing name and values of the it_overshoot_expected variable;
1461 logic changes accordingly. (Bug#9254) (Bug#9549)
1462
1463 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1464 CHARPOS is covered by a display string which includes newlines.
1465 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1466 is covered by a display string with embedded newlines.
1467
1468 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1469
1470 * dbusbind.c (Fdbus_register_signal): Add match rule to
1471 Vdbus_registered_objects_table. (Bug#9581)
1472 (Fdbus_register_method, Vdbus_registered_objects_table):
1473 Fix docstring.
1474
1475 2011-09-24 Jim Meyering <meyering@redhat.com>
1476
1477 do not ignore write error for any output size
1478 The previous change was incomplete.
1479 While it makes emacs --batch detect the vast majority of stdout
1480 write failures, errors were still ignored whenever the output size is
1481 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1482 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1483 && echo FAIL: ignored write error
1484 FAIL: ignored write error
1485 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1486 && echo FAIL: ignored write error
1487 FAIL: ignored write error
1488 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1489
1490 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1491
1492 * emacs.c (Fkill_emacs): In noninteractive mode exit
1493 non-successfully if a write error occurred on stdout. (Bug#9574)
1494
1495 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1498 the xassert test.
1499
1500 * dispextern.h (struct it): Update the comment documenting what
1501 can it->OBJECT be.
1502
1503 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1504
1505 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1506 a display string, extend search for cursor position to end of row.
1507 (find_row_edges): If the row ends in a newline from a display
1508 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1509 Handle the case of a display string with multiple newlines.
1510 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1511 non-empty line. Fixes confusing cursor motion with arrow keys at
1512 the beginning of a line that starts with whitespace.
1513
1514 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1515
1516 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1517 (bug#9493).
1518
1519 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1520
1521 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1522 boolean (Bug#9154).
1523
1524 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1525
1526 * xdisp.c (display_line): Record maximum and minimum buffer
1527 positions even if no glyphs were produced (e.g., by a zero-width
1528 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1529 buffer positions that will be removed from the glyph row because
1530 they don't fit.
1531 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1532 column is beyond frame width: don't subtract 1 "pixel" when
1533 computing width of the stretch.
1534 (reseat_at_next_visible_line_start): Undo the change made on
1535 2011-09-17 that saved paragraph information and restored it after
1536 the call to `reseat'. (Bug#9545)
1537
1538 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1539
1540 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1541 and turn window cursor on if cleared (Bug#9415).
1542
1543 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1544
1545 * search.c (boyer_moore): Take unibyte characters from pattern
1546 literally. (Bug#9458)
1547
1548 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1549
1550 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1551
1552 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Fix minor problem found by static checking.
1555 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1556 initialized, to pacify gcc -Wuninitialized.
1557
1558 * fileio.c: Report proper errno when syscall falls.
1559 (Finsert_file_contents): Save and restore errno,
1560 so that report_file_error outputs the correct diagnostic.
1561 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1562
1563 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1564
1565 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1566
1567 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1570 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1571
1572 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1573
1574 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1575 about the current paragraph and restore it after the call to reseat.
1576
1577 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1578 (bidi_find_paragraph_start): Search back for paragraph beginning
1579 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1580 (bidi_move_to_visually_next): Only trigger paragraph-related
1581 computations when the last character is a newline or at EOB, not
1582 just any NEUTRAL_B. (Bug#9470)
1583
1584 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1585 truncated lines if point is covered by a display string. (Bug#9524)
1586
1587 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1590 (cons_to_x_long): New function.
1591 (lisp_data_to_selection_data): Use it. Correct the test for
1592 short-versus-long data; it was negated. Break out of vector
1593 loop, for efficiency, when a long datum is discovered.
1594
1595 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1596
1597 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1598
1599 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1600
1601 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1602 GCC PR/17406) by declaring this function with external scope.
1603
1604 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1607 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1608
1609 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1610
1611 * editfns.c (Fformat): Correctly handle text properties on "%%".
1612
1613 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xterm.c (x_draw_composite_glyph_string_foreground):
1616 * w32term.c (x_draw_composite_glyph_string_foreground):
1617 * term.c (encode_terminal_code):
1618 * composite.c (composition_update_it, get_composition_id):
1619 * xdisp.c (get_next_display_element)
1620 (fill_composite_glyph_string): Add comments about special meaning
1621 of TAB characters in a composition.
1622
1623 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1626 This occurs when processing a multibyte format.
1627 Problem reported by Wolfgang Jenker.
1628
1629 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1630
1631 * xdisp.c (try_cursor_movement): Only check for exact match if
1632 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1633
1634 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 Remove unused external symbols.
1637 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1638 * xdisp.c (calc_pixel_width_or_height): Now static.
1639 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1640 * indent.c (check_display_width):
1641 * w32term.c: Fix comment to match code.
1642 * xterm.c, xterm.h (x_catching_errors): Remove.
1643
1644 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1645
1646 * xselect.c: Use signed conversions more consistently (Bug#9498).
1647 (selection_data_to_lisp_data): Assume incoming selection data are
1648 signed integers, not unsigned. This is to be consistent with
1649 outgoing selection data, which was modified to use signed integers
1650 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1651 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1652 expects long, not unsigned long.
1653
1654 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1655
1656 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1657 computation of loop end. Reported by Johan Bockgård
1658 <bojohan@gnu.org>.
1659
1660 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1661
1662 * frame.c (Fother_visible_frames_p): Function deleted.
1663
1664 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1665
1666 * indent.c (compute_motion): Process display vector front to back
1667 rather than the other way around. (Bug#2496)
1668
1669 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1670
1671 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1672
1673 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1674
1675 * minibuf.c (Fread_from_minibuffer): Doc fix.
1676
1677 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1680 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1681
1682 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1683
1684 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1685 value for non-existent files.
1686
1687 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1688
1689 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1690 set its "size" to -1. This will set the modtime_size field of
1691 the corresponding buffer to -1, which is what
1692 verify-visited-file-modtime expects for files that do not exist.
1693 (Bug#9139)
1694
1695 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1698 here ...
1699 * lisp.h: ... from here. push_key_description is no longer
1700 defined in keyboard.c, so its declaration should not be in
1701 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1702 logically belongs with push_key_description.
1703
1704 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 * buffer.h: Include <sys/types.h> instead of <time.h>.
1707 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1708 Problem reported by Herbert J. Skuhra.
1709
1710 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1711
1712 * xml.c (parse_region): Make the parsing work for
1713 non-comment-starting XML files again (bug#9144).
1714
1715 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1716
1717 * image.c (gif_load): Fix calculation of bottom and right corner.
1718 (Bug#9468)
1719
1720 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1723 redisplay in small windows.
1724
1725 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1726
1727 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1728
1729 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1730
1731 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1732 Operate on live windows only.
1733
1734 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1737
1738 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1739
1740 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1741 only under bidi iteration.
1742
1743 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1746
1747 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1750 Without this fix, the command to link temacs failed due to an
1751 undefined symbol __builtin_isnan. This is because
1752 /usr/include/iso/math_c99.h #defines isnan(x) to
1753 __builtin_isnan(x), but the bundled gcc, which identifies itself
1754 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1755 a __builtin_isnan.
1756 * floatfns.c (isnan): #undef, and then #define to a clone of
1757 what's in data.c.
1758 (Fisnan): Always define, since it's always available now.
1759 (syms_of_floatfns): Always define isnan at the Lisp level.
1760
1761 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1764
1765 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1768 The previous code assumed that file offsets (off_t values) fit in
1769 EMACS_INT variables, which is not true on typical 32-bit hosts.
1770 The code messed up by falsely reporting buffer overflow in cases
1771 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1772 when "big" contains more than 2**29 bytes, even though this
1773 inserts just one byte and does not overflow the buffer.
1774 (Finsert_file_contents): Store file offsets as off_t
1775 values, not as EMACS_INT values. Check for overflow when
1776 converting between EMACS_INT and off_t. When checking for
1777 buffer overflow or for overlap, take the offsets into account.
1778 Don't use EMACS_INT for small values where int suffices.
1779 When checking for overlap, fix a typo: ZV was used where
1780 ZV_BYTE was intended.
1781 (Fwrite_region): Don't assume off_t fits into 'long'.
1782 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1783
1784 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1785
1786 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1787
1788 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 sprintf-related integer and memory overflow issues (Bug#9412).
1791
1792 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1793 (esprintf, exprintf, evxprintf): New functions.
1794 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1795 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1796 (modify_event_symbol): Do not assume that the length of
1797 name_alist_or_stem is safe to alloca and fits in int.
1798 (Fexecute_extended_command): Likewise for function name and binding.
1799 (Frecursion_depth): Wrap around reliably on integer overflow.
1800 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1801 since some callers pass EMACS_INT values.
1802 (Fsingle_key_description): Don't crash if symbol name contains more
1803 than MAX_ALLOCA bytes.
1804 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1805 (get_minibuffer): Arg is now EMACS_INT, not int.
1806 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1807 (esprintf, exprintf, evxprintf): New decls.
1808 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1809
1810 * dbusbind.c (signature_cat): New function.
1811 (xd_signature, Fdbus_register_signal):
1812 Do not overrun buffer; instead, report string overflow.
1813
1814 * dispnew.c (add_window_display_history): Don't overrun buffer.
1815 Truncate instead; this is OK since it's just a log.
1816
1817 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1818 even if the time zone offset is outlandishly large.
1819 Don't mishandle offset == INT_MIN.
1820
1821 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1822 when creating daemon; the previous buffer-overflow check was incorrect.
1823
1824 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1825 which has the guts of the old verror function.
1826
1827 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1828 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1829
1830 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1831 (font_unparse_xlfd): Don't blindly alloca long strings.
1832 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1833 fits in int, when using sprintf. Use single snprintf to count
1834 length of string rather than counting it via multiple sprintfs;
1835 that's simpler and more reliable.
1836 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1837 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1838 sprintf, in case result does not fit in int.
1839
1840 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1841 (fontset_from_font): Print it.
1842
1843 * frame.c (tty_frame_count): Now printmax_t, not int.
1844 (make_terminal_frame, set_term_frame_name): Print it.
1845 (x_report_frame_params): In X, window IDs are unsigned long,
1846 not signed long, so print them as unsigned.
1847 (validate_x_resource_name): Check for implausibly long names,
1848 and don't assume name length fits in 'int'.
1849 (x_get_resource_string): Don't blindly alloca invocation name;
1850 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1851 not fit in int.
1852
1853 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1854 (xg_check_special_colors, xg_set_geometry):
1855 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1856
1857 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1858 Use esprintf, not sprintf, in case result does not fit in int.
1859
1860 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1861 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1862 it as a large positive number.
1863 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1864 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1865
1866 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1867 in case result does not fit in int.
1868
1869 * print.c (float_to_string): Detect width overflow more reliably.
1870 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1871 buffer overrun. Don't assume list length fits in 'int'. Treat
1872 print length of 0 as 0, not as infinity; to be consistent with other
1873 uses of print length in this function. Don't overflow print length
1874 index. Don't assume hash table size fits in 'long', or that
1875 vectorlike size fits in 'unsigned long'.
1876
1877 * process.c (make_process): Use printmax_t, not int, to format
1878 process-name gensyms.
1879
1880 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1881
1882 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1883 to avoid potential buffer overrun.
1884
1885 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1886 if X resource line is longer than 512 bytes.
1887
1888 * xfns.c (x_window): Make sprintf buffer a bit bigger
1889 to avoid potential buffer overrun.
1890
1891 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1892
1893 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1894
1895 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 Integer overflow fixes for scrolling, etc.
1898 Without these, Emacs silently mishandles large integers sometimes.
1899 For example, "C-u 4294967297 M-x recenter" was treated as if
1900 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1901
1902 * xdisp.c (try_window_id): Check Emacs fixnum range before
1903 converting to 'int'.
1904
1905 * window.c (window_scroll_line_based, Frecenter):
1906 Check that an Emacs fixnum is in range before assigning it to 'int'.
1907 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1908 values converted from Emacs fixnums.
1909 (Frecenter): Don't wrap around a line count if it is out of 'int'
1910 range; instead, treat it as an extreme value.
1911 (Fset_window_configuration, compare_window_configurations):
1912 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1913
1914 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1915 that can exceed INT_MAX. Check that EMACS_INT value is in range
1916 before assigning it to the (possibly-narrower) index.
1917 (match_limit): Don't assume that a fixnum can fit in 'int'.
1918
1919 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1920 exceed INT_MAX.
1921
1922 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1923 (Fvertical_motion): Don't wrap around LINES values that don't fit
1924 in 'int'. Instead, treat them as extreme values. This is good
1925 enough for windows, which can't have more than INT_MAX lines anyway.
1926
1927 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1928
1929 * Require libxml/parser.h to avoid compilation warning.
1930
1931 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1932
1933 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1934 since this reportedly can destroy thread storage.
1935
1936 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1937
1938 * syntax.c (find_defun_start): Update all cache variables if
1939 exiting early (Bug#9401).
1940
1941 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1942
1943 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1944
1945 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1946 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1947 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1948
1949 * term.c (tty_append_glyph): New function.
1950 (produce_stretch_glyph): Static function and its prototype deleted.
1951
1952 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1953 Add prototypes.
1954
1955 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1958 when checking :margin (Bug#9390).
1959 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1960 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1961 so that the name doesn't mislead. All uses changed.
1962
1963 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1964
1965 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1966 set_tty_hooks.
1967
1968 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (move_it_to): Don't bail out early when reaching
1971 position beyond to_charpos, if we are scanning backwards.
1972 (move_it_vertically_backward): When DY == 0, make sure we get to
1973 the first character in the line after the newline.
1974
1975 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1978 (ccl_driver): Do not generate an out-of-range pointer.
1979 (Fccl_execute_on_string): Remove unnecessary check for
1980 integer overflow, noted by Stefan Monnier in
1981 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1982 Remove a FIXME that didn't need fixing.
1983 Simplify the newly-introduced buffer reallocation code.
1984
1985 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1986
1987 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1988
1989 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 Integer and memory overflow issues (Bug#9196).
1992
1993 * doc.c (get_doc_string): Rework so that
1994 get_doc_string_buffer_size is the actual buffer size, rather than
1995 being 1 less than the actual buffer size; this makes xpalloc more
1996 convenient.
1997
1998 * image.c (x_allocate_bitmap_record, cache_image):
1999 * xselect.c (Fx_register_dnd_atom):
2000 Simplify previous changes by using xpalloc.
2001
2002 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2003 since either will do and ptrdiff_t is convenient with xpalloc.
2004
2005 * charset.c (charset_table_size)
2006 (struct charset_sort_data.priority): Now ptrdiff_t.
2007 (charset_compare): Don't overflow if priorities differ greatly.
2008 (Fsort_charsets): Don't assume list length fits in int.
2009 Check for size-calculation overflow when allocating sort data.
2010 (syms_of_charset): Allocate an initial charset table that is
2011 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2012
2013 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2014
2015 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2016 The actual value is always <= INT_MAX, and leaving it unsigned made
2017 overflow checking harder.
2018
2019 * dispextern.h (struct glyph_matrix.rows_allocated)
2020 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2021 with xpalloc. The values are still always <= INT_MAX.
2022
2023 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2024
2025 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2026 (SAFE_NALLOCA): New macro.
2027
2028 * region-cache.c (struct boundary.pos, find_cache_boundary)
2029 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2030 (set_cache_region, invalidate_region_cache)
2031 (revalidate_region_cache, know_region_cache, region_cache_forward)
2032 (region_cache_backward, pp_cache):
2033 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2034 so that ptrdiff_t * can be passed to xpalloc.
2035 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2036 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2037 (pp_cache): Don't assume cache_len fits in int.
2038 * region-cache.h: Adjust extern decls to match.
2039
2040 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2041 EMACS_INT, since either will do, for xpalloc.
2042
2043 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2044 (xnmalloc, xnrealloc, xpalloc): New functions.
2045
2046 * bidi.c (bidi_shelve_header_size): New constant.
2047 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2048 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2049
2050 * bidi.c (bidi_cache_shrink):
2051 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2052 (overlay_strings):
2053 Don't update size of array until after memory allocation succeeds,
2054 because xmalloc/xrealloc may not return.
2055 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2056 now that we have proper integer overflow checking.
2057 (record_overlay_string, overlay_strings): Catch overflows when
2058 calculating size of overlay_str_buf.
2059
2060 * callproc.c (Fcall_process): Check for size overflow when
2061 calculating size of args2.
2062 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2063 Normally we prefer signed values, but sticking with ptrdiff_t would
2064 require adding more-complicated checks.
2065
2066 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2067 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2068 Redo buffer-overflow calculations to avoid integer overflow.
2069 Add a FIXME comment where memory seems to be over-allocated.
2070
2071 * character.c (Fstring): Check for size-calculation overflow.
2072
2073 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2074 unnecessary integer overflow. Check for size overflow.
2075 (encode_coding_object): Don't update size until xmalloc succeeds.
2076
2077 * composite.c (get_composition_id): Check for overflow in glyph
2078 length calculations.
2079
2080 Integer and memory overflow fixes for display code.
2081 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2082 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2083 (scrolling_window): Check for overflow in size calculations.
2084 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2085 Don't assume glyph table len fits in int.
2086 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2087 (row_table_size): Now ptrdiff_t, not int.
2088 (scrolling_window): Avoid overflow in size calculations.
2089 Don't update size until allocation succeeds.
2090 * fns.c (concat): Check for overflow in size calculations.
2091 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2092 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2093 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2094
2095 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2096 (get_doc_string): Check for size calculation overflow.
2097 Don't update size until allocation succeeds.
2098 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2099 EMACS_INT, where ptrdiff_t will do.
2100 (Fsubstitute_command_keys): Check for string overflow.
2101
2102 * editfns.c (set_time_zone_rule): Don't assume environment length
2103 fits in int.
2104 (message_length): Now ptrdiff_t, not int.
2105 (Fmessage_box): Don't update size until allocation succeeds.
2106 Don't assume message length fits in int.
2107 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2108
2109 * emacs.c (main): Do not reallocate argv, since there is a null at
2110 the end that can be overwritten, and this way there's no need to
2111 worry about size-calculation overflow.
2112 (sort_args): Check for size-calculation overflow.
2113
2114 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2115 alloc succeeds.
2116 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2117
2118 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2119 (x_set_scroll_bar_width, x_figure_window_size):
2120 Check for integer overflow.
2121 (x_set_alpha): Do not assume XINT fits in int.
2122
2123 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2124 This is for the members text_lines, text_cols, total_lines, total_cols,
2125 where the system imposes an 'int' limit.
2126
2127 * fringe.c (Fdefine_fringe_bitmap):
2128 Don't update size until alloc works.
2129
2130 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2131 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2132
2133 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2134 Check for size-calculation overflow.
2135 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2136 do, as we prefer signed integers.
2137 (id_to_widget.max_size, id_to_widget.used)
2138 (xg_store_widget_in_map, xg_remove_widget_from_map)
2139 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2140 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2141 Use and return ptrdiff_t, not int.
2142 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2143 * gtkutil.h: Change prototypes to match the above.
2144
2145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2146 are duplicate now that they've been promoted to lisp.h.
2147 (x_allocate_bitmap_record, x_alloc_image_color)
2148 (make_image_cache, cache_image, xpm_load):
2149 Don't update size until alloc is done.
2150 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2151 (x_detect_edges):
2152 Check for size calculation overflow.
2153 (ct_colors_allocated_max): New constant.
2154 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2155 overflow.
2156
2157 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2158 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2159 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2160 Use ptrdiff_t, not int, to count maps.
2161 (read_char_minibuf_menu_prompt): Check for overflow in size
2162 calculations. Don't update size until allocation succeeds.
2163 Redo calculations to avoid overflow.
2164 * keyboard.h: Change prototypes to match the above.
2165
2166 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2167 to count maps.
2168 (current_minor_maps): Check for size calculation overflow.
2169 * keymap.h: Change prototypes to match the above.
2170
2171 * lread.c (read1, init_obarray): Don't update size until alloc done.
2172
2173 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2174 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2175
2176 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2177 Now ptrdiff_t, not int.
2178 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2179 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2180
2181 * process.c (Fnetwork_interface_list): Check for overflow
2182 in size calculation.
2183
2184 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2185
2186 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2187 overflow. Don't bother calling xmalloc when xrealloc will do.
2188
2189 * search.c (Freplace_match): Check for size calculation overflow.
2190 (Fset_match_data): Don't assume list lengths fit in 'int'.
2191
2192 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2193 for command line length. Do not attempt to address one before the
2194 beginning of an array, as that's not portable.
2195
2196 * term.c (max_frame_lines): Remove; unused.
2197 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2198 not int.
2199 (encode_terminal_code, calculate_costs): Check for size
2200 calculation overflow.
2201 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2202 table lengths and related sizes. Don't update size until alloc
2203 done. Redo calculations to avoid overflow.
2204 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2205
2206 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2207 subtracting pointers.
2208 (gobble_line): Check for overflow more carefully. Don't update size
2209 until alloc done.
2210
2211 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2212 Don't update size until alloc done.
2213 Redo size calculations to avoid overflow.
2214 Check for size calculation overflow.
2215 (main) [DEBUG]: Fix typo in invoking tparam1.
2216
2217 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2218 Use ptrdiff_t, not int, for sizes.
2219 (store_mode_line_noprop_char): Don't update size until alloc done.
2220
2221 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2222 Use ptrdiff_t, not int, for sizes.
2223 (Finternal_make_lisp_face, cache_face):
2224 Check for size calculation overflow.
2225 (cache_face): Treat size calculation overflows as if they were
2226 memory exhaustion (the usual treatment), rather than aborting.
2227
2228 * xfns.c (x_encode_text, x_set_name_internal)
2229 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2230 sizes, since they can exceed INT_MAX in size. Check for size
2231 calculation overflow.
2232
2233 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2234 (xg_select): Check for size calculation overflow.
2235 Don't update size until alloc done.
2236
2237 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2238 as sprintf is limited to int lengths.
2239
2240 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2241 (X_LONG_MIN): New macros.
2242 Use them to make the following changes clearer.
2243 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2244 This change doesn't affect the value now, but it may help remind
2245 future maintainers not to raise the value too much later.
2246 (SELECTION_QUANTUM): Remove, replacing with ...
2247 (selection_quantum): ... new function, which avoids overflow.
2248 All uses changed.
2249 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2250 assumption that selection length fits in 'int'.
2251 (x_reply_selection_request, x_handle_selection_request)
2252 (x_get_window_property, receive_incremental_selection)
2253 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2254 (lisp_data_to_selection_data, clean_local_selection_data):
2255 Use ptrdiff_t, not int, to record length of selection.
2256 (x_reply_selection_request, x_get_window_property)
2257 (receive_incremental_selection, x_property_data_to_lisp):
2258 Redo calculations to avoid overflow.
2259 (x_reply_selection_request): When sending hint, ceiling it at
2260 X_LONG_MAX rather than relying on wraparound overflow to send
2261 something.
2262 (x_get_window_property, receive_incremental_selection)
2263 (lisp_data_to_selection_data, x_property_data_to_lisp):
2264 Check for size-calculation overflow.
2265 (x_get_window_property, receive_incremental_selection)
2266 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2267 Don't store size until memory allocation succeeds.
2268 (x_get_window_property): Plug memory leak on memory exhaustion.
2269 Don't double-block input; malloc is safe here. Don't assume 2**34
2270 - 4 fits in unsigned long. Add an xassert to check
2271 XGetWindowProperty overflow. Be more careful about overflow
2272 calculations, and distinguish size from memory overflow better.
2273 (receive_incremental_selection): When tracing, don't assume
2274 unsigned int is less than INT_MAX.
2275 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2276 harmful) conversions of unsigned short to int.
2277 (lisp_data_to_selection_data): Don't assume that integers
2278 in the range -65535 through -1 fit in an X unsigned short.
2279 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2280 result parameters unless successful. Rely on cons_to_unsigned
2281 to report problems with elements; the old code wasn't right anyway.
2282 (x_check_property_data): Check for int overflow; we cannot use
2283 a wider type due to X limits.
2284 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2285
2286 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2287
2288 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2289 (x_term_init): Check for size calculation overflow.
2290 (x_color_cells): Don't store size until memory allocation succeeds.
2291 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2292 Don't assume alloca size is less than MAX_ALLOCA.
2293 (x_term_init): Don't assume length fits in int (sprintf is limited
2294 to int size).
2295
2296 Use ptrdiff_t for composition IDs.
2297 * character.c (lisp_string_width):
2298 * composite.c (composition_table_size, n_compositions)
2299 (get_composition_id, composition_gstring_from_id):
2300 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2301 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2302 * window.c (Frecenter):
2303 Use ptrdiff_t, not int, for composition IDs.
2304 * composite.c (get_composition_id): Check for integer overflow.
2305 * composite.h: Adjust prototypes to match the above changes.
2306
2307 Use ptrdiff_t for hash table indexes.
2308 * category.c (hash_get_category_set):
2309 * ccl.c (ccl_driver):
2310 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2311 * coding.c (coding_system_charset_list, detect_coding_system):
2312 * coding.h (struct coding_system.id):
2313 * composite.c (get_composition_id, gstring_lookup_cache):
2314 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2315 * image.c (xpm_get_color_table_h):
2316 * lisp.h (hash_lookup, hash_put):
2317 * minibuf.c (Ftest_completion):
2318 Use ptrdiff_t for hash table indexes, not int (which is too
2319 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2320 32-bit --with-wide-int hosts).
2321
2322 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2323 Add a FIXME comment about memory leaks.
2324 (syms_of_charset): Don't assume xmalloc returns.
2325
2326 Don't assume that stated character widths fit in int.
2327 * character.c (Fchar_width, c_string_width, lisp_string_width):
2328 * character.h (CHAR_WIDTH):
2329 * indent.c (MULTIBYTE_BYTES_WIDTH):
2330 Use sanitize_char_width to avoid undefined and/or bad behavior
2331 with outlandish widths.
2332 * character.h (sanitize_tab_width): Rename from sanitize_width,
2333 now that we have two such functions. All uses changed.
2334 (sanitize_char_width): New inline function.
2335
2336 Don't assume that tab-width fits in int.
2337 * character.h (sanitize_width): New inline function.
2338 (SANE_TAB_WIDTH): New macro.
2339 (ASCII_CHAR_WIDTH): Use it.
2340 * indent.c (sane_tab_width): Remove. All uses replaced by
2341 SANE_TAB_WIDTH (current_buffer).
2342 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2343
2344 * fileio.c: Integer overflow issues with file modes.
2345 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2346
2347 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2348 Remove unreachable code.
2349 (read_hex, load_charset_map_from_file): Check for integer overflow.
2350
2351 * xterm.c: don't go over XClientMessageEvent limit
2352 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2353 (x_send_scroll_bar_event): Likewise. Check that the size does not
2354 exceed limits imposed by XClientMessageEvent, as well as the usual
2355 ptrdiff_t and size_t limits.
2356
2357 * keyboard.c: Overflow, signedness and related fixes.
2358 (make_lispy_movement): Use same integer type in forward decl
2359 that is used in the definition.
2360 (read_key_sequence, keyremap_step):
2361 Change bufsize argument back to int, undoing my 2011-03-30 change.
2362 We prefer signed types, and int is wide enough here.
2363 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2364 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2365 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2366 length, not size_t. Use ptrdiff_t for index, not int.
2367 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2368 possibility of integer overflow.
2369
2370 Overflow, signedness and related fixes for images.
2371
2372 * dispextern.h (struct it.stack[0].u.image.image_id)
2373 (struct_it.image_id, struct image.id, struct image_cache.size)
2374 (struct image_cache.used, struct image_cache.ref_count):
2375 * gtkutil.c (update_frame_tool_bar):
2376 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2377 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2378 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2379 * nsmenu.m (update_frame_tool_bar):
2380 * xdisp.c (calc_pixel_width_or_height):
2381 * xfns.c (image_cache_refcount):
2382 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2383 on typical 64-bit hosts.
2384
2385 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2386 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2387 Omit unnecessary casts to int.
2388 (parse_image_spec): Check that integers fall into 'int' range
2389 when the callers expect that.
2390 (image_ascent): Redo ascent calculation to avoid int overflow.
2391 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2392 (lookup_image): Remove unnecessary tests.
2393 (xbm_image_p): Locals are now of int, not EMACS_INT,
2394 since parse_image_check makes sure they fit into int.
2395 (png_load, gif_load, svg_load_image):
2396 Prefer int to unsigned where either will do.
2397 (tiff_handler): New function, combining the cores of the
2398 old tiff_error_handler and tiff_warning_handler.
2399 This function is rewritten to use vsnprintf and thereby avoid
2400 stack buffer overflows. It uses only the features of vsnprintf
2401 that are common to both POSIX and native Microsoft.
2402 (tiff_error_handler, tiff_warning_handler): Use it.
2403 (tiff_load, gif_load, imagemagick_load_image):
2404 Don't assume :index value fits in 'int'.
2405 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2406 (imagemagick_load_image): Check that crop parameters fit into
2407 the integer types that MagickCropImage accepts. Don't assume
2408 Vimagemagick_render_type has a nonnegative value. Don't assume
2409 size_t fits in 'long'.
2410 (gs_load): Use printmax_t to print the widest integers possible.
2411 Check for integer overflow when computing image height and width.
2412
2413 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (redisplay_window): Don't force window start if point
2416 will be invisible in the resulting window. (Bug#9324)
2417
2418 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2421 the display spec is of the form `(space ...)'.
2422 (handle_display_spec): Return the value returned by
2423 handle_single_display_spec, not just 1 or zero.
2424 (handle_single_display_spec): If the display spec is of the form
2425 `(space ...)', and specifies display in the text area, return 2
2426 rather than 1.
2427 (try_cursor_movement): Check for the need to scroll more
2428 accurately, and prefer exact match for point under bidi.
2429 Don't advance `row' beyond the last row of the window.
2430
2431 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2432 into disp_prop; all users changed.
2433
2434 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2435 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2436 for the text covered by the display property.
2437
2438 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2439
2440 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2441 Change return value to nil.
2442 (Frecord_buffer): Delete unused function.
2443
2444 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2447 buffers, return left-to-right.
2448 (set_cursor_from_row): Consider candidate row a win if its glyph
2449 represents a newline and point is on that newline. Fixes cursor
2450 positioning on the newline at EOL of R2L text within L2R
2451 paragraph, and vice versa.
2452 (try_cursor_movement): Check continued rows, in addition to
2453 continuation rows. Fixes unwarranted scroll when point enters a
2454 continued line of R2L text within an L2R paragraph, or vice versa.
2455 (cursor_row_p): Consider the case of point being equal to
2456 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2457 from the end of a short line to the beginning of a continued line
2458 of R2L text within L2R paragraph.
2459 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2460 composed characters.
2461
2462 * bidi.c (bidi_check_type): Use xassert.
2463 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2464 members.
2465
2466 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2467
2468 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2469 a character.
2470
2471 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * nsfont.m (ns_otf_to_script): Fix typo.
2474
2475 2011-08-22 Kenichi Handa <handa@m17n.org>
2476
2477 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2478 extra slot even if the purpose is char-code-property-table.
2479
2480 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2481
2482 * xdisp.c (redisplay_window): When computing centering_position,
2483 account for the height of the header line. (Bug#8874)
2484
2485 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2486 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2487 candidate is selected by the mouse, and that candidate has a
2488 composed character under the mouse.
2489
2490 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2491 coordinates reported by pos-visible-in-window-p for a composed
2492 character in column zero.
2493
2494 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2495
2496 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2497
2498 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2499
2500 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2501 consider it a hit if to_charpos is anywhere in the range of the
2502 composed buffer positions.
2503
2504 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2505
2506 * image.c (gif_load): Don't assume that each subimage has the same
2507 dimensions as the base image. Handle disposal method that is
2508 "undefined" by the gif spec (Bug#9335).
2509
2510 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2511
2512 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2513 (Fcondition_case): Document `debug' symbol in error handler.
2514
2515 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2516
2517 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2518 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2519 from an Org mode buffer to a Speedbar frame.
2520
2521 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2522 a composition, take its buffer position from IT->cmp_it.charpos.
2523 Fixes cursor positioning at the beginning of a line that begins
2524 with a composed character.
2525
2526 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2527
2528 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2529 character bidirectional type, use STRONG_L instead. Fixes crashes
2530 in a buffer produced by `describe-categories'.
2531
2532 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2533 members before the level stack, so they would be saved and
2534 restored when copying iterator state. Fixes incorrect reordering
2535 around TABs covered by display properties.
2536
2537 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2538
2539 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2540
2541 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * eval.c (internal_condition_case, internal_condition_case_1)
2544 (internal_condition_case_2, internal_condition_case_n):
2545 Remove unnecessary aborts (Bug#9081).
2546
2547 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2548
2549 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2550 has no `load' handler, try opening the file locally. (Bug#9311)
2551
2552 2011-08-16 Ken Brown <kbrown@cornell.edu>
2553
2554 * gmalloc.c: Expand comment.
2555
2556 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2557
2558 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2559 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2560
2561 2011-08-16 Ken Brown <kbrown@cornell.edu>
2562
2563 Fix memory allocation problems in Cygwin build (Bug#9273).
2564
2565 * unexcw.c ( __malloc_initialized): Declare external variable.
2566 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2567
2568 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2569 New variables.
2570 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2571 dumped emacs.
2572 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2573 in the static heap.
2574 [CYGWIN] (special_realloc): New function.
2575 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2576 requests to realloc storage in the static heap.
2577
2578 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2579
2580 * bidi.c (bidi_initialize): Remove unused local.
2581
2582 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2583
2584 * bidimirror.h:
2585 * biditype.h: Remove file.
2586 * makefile.w32-in ($(BLD)/bidi.$(O)):
2587 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2588
2589 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2590
2591 * chartab.c: Improve commentary for the uniprop_table API.
2592
2593 * bidi.c (bidi_paragraph_init): Support zero value of
2594 bidi_ignore_explicit_marks_for_paragraph_level.
2595 (bidi_initialize): Use uniprop_table instead of including
2596 biditype.h and bidimirror.h.
2597
2598 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2599 coordinates of the iterator when restoring from ppos_it.
2600 (Bug#9296)
2601
2602 2011-08-14 Kenichi Handa <handa@m17n.org>
2603
2604 * process.c (create_process): Call setup_process_coding_systems
2605 after the pid of the process is set to -1 (Bug#8162).
2606
2607 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2608
2609 * xdisp.c (move_it_in_display_line_to): Don't invoke
2610 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2611 ppos_it. Fixes vertical cursor motion when line beginning is
2612 covered by an image. (Bug#9296)
2613
2614 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2615
2616 * nsterm.h (ns_run_ascript): Declare.
2617 (NSAPP_DATA2_RUNASSCRIPT): Define.
2618
2619 * nsfns.m (as_script, as_result, as_status): New static variables.
2620 (ns_run_ascript): New function.
2621 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2622 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2623 the event loop. Get status from as_status (Bug#7276).
2624
2625 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2626 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2627 the event loop (Bug#7276).
2628
2629 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2630
2631 * gnutls.c (QCgnutls_bootprop_priority)
2632 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2633 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2634 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2635 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2636 (QCgnutls_bootprop_verify_hostname_error)
2637 (QCgnutls_bootprop_callbacks_verify): Rename from
2638 Qgnutls_bootprop_..., all uses changed.
2639
2640 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2641 uses changed.
2642
2643 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * xfaces.c (Qframe_set_background_mode): Now static.
2646 * dispextern.h (Qframe_set_background_mode): Remove decl.
2647
2648 * process.c (Fnetwork_interface_info): Declare local only if needed.
2649
2650 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2651
2652 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2653 (Fnetwork_interface_list): Allocate in increments of bytes instead
2654 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2655 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2656 sockaddr.
2657 (struct ifflag_def): notrailers is smart on OSX.
2658 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2659 Get hardware address with getifaddrs if available.
2660
2661 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xdisp.c (iterate_out_of_display_property): xassert that
2664 IT->position is set to within IT->object's boundaries. Break from
2665 the loop as soon as EOB is reached; avoids infloops in redisplay
2666 when IT->position is set up wrongly due to some bug.
2667 Set IT->current to match the bidi iterator unconditionally.
2668 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2669 entry. Force push_it to save on the stack the current
2670 buffer/string position, to be restored by pop_it. Fix flags in
2671 the iterator structure wrt the object coming from a display
2672 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2673 properties. (Bug#9284)
2674
2675 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * fontset.c (fontset_get_font_group): Add proper type checks.
2678 (Bug#9172)
2679
2680 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2681
2682 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2683 and LC_VERSION_MIN_MACOSX.
2684 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2685 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2686
2687 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (forward_to_next_line_start): Allow to use the
2690 no-display-properties-and-no-overlays under bidi display.
2691 Set disp_pos in the bidi iterator to avoid searches for display
2692 properties and overlays.
2693
2694 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2695
2696 * editfns.c (Fset_time_zone_rule): Document relationship with the
2697 setenv function.
2698
2699 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2700 the font entity extracted from the cache (Bug#8109).
2701
2702 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2703
2704 * composite.c (autocmp_chars): Don't reset point. That is done by
2705 restore_point_unwind (Bug#5984).
2706
2707 2011-08-07 Juri Linkov <juri@jurta.org>
2708
2709 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2710 to show the arg `TIME' instead of `TIMEVAL'.
2711
2712 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2713
2714 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2715 display property strides EOL and includes a newline, as in
2716 longlines-mode. (Bug#9254)
2717 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2718 word-wrap under bidirectional display. (Bug#9224)
2719
2720 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2721 is non-zero, even if the data buffer is NULL. Fixes a crash in
2722 vertical-motion with longlines-mode. (Bug#9254)
2723
2724 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2725
2726 * bidi.c <bidi_cache_total_alloc>: Now static.
2727 (bidi_initialize): Initialize bidi_cache_total_alloc.
2728
2729 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2730 cache. (Bug#9221)
2731
2732 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2733 amount allocated this far in `bidi_cache_total_alloc'.
2734 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2735 non-zero, only free the data buffer without restoring the cache
2736 contents. All callers changed.
2737
2738 * dispextern.h (bidi_unshelve_cache): Update prototype.
2739
2740 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2741 (move_it_in_display_line, move_it_to)
2742 (move_it_vertically_backward, move_it_by_lines): Replace the call
2743 to xfree to an equivalent call to bidi_unshelve_cache.
2744 (move_it_in_display_line_to): Fix logic of returning
2745 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2746
2747 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2748
2749 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2750 came from a string character with a `cursor' property. (Bug#9229)
2751
2752 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2753
2754 * Makefile.in (LIB_PTHREAD): New variable.
2755 (LIBES): Add LIB_PTHREAD (Bug#9216).
2756
2757 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2758 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2759
2760 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2761
2762 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2763
2764 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2765
2766 * xterm.c (x_find_topmost_parent): New function.
2767 (x_set_frame_alpha): Find topmost parent window with
2768 x_find_topmost_parent and set the property there also (bug#9181).
2769 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2770
2771 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 * callproc.c (Fcall_process): Avoid vfork clobbering
2774 the local vars buffer, coding_systems, current_dir.
2775
2776 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2777
2778 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2779
2780 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2783 so that it is not optimized away.
2784
2785 * xdisp.c (compute_display_string_pos): Remove unused local.
2786
2787 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2788
2789 Fix slow cursor motion and scrolling in large buffers with
2790 selective display, like Org Mode buffers. (Bug#9218)
2791
2792 * dispextern.h (struct bidi_it): New member disp_prop_p.
2793
2794 * xdisp.c: Remove one-slot cache of display string positions.
2795 (compute_display_string_pos): Accept an additional argument
2796 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2797 for a display string or property. If found, set DISP_PROP_P
2798 non-zero.
2799
2800 * bidi.c (bidi_fetch_char): Accept an additional argument
2801 DISP_PROP_P, and pass it to compute_display_string_pos.
2802 Only handle text covered by a display string if DISP_PROP_P is returned
2803 non-zero. All callers of bidi_fetch_char changed.
2804
2805 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2806
2807 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2808
2809 2010-12-03 Don March <don@ohspite.net>
2810
2811 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2812 last character M-[char] is translated to ESC [char] (bug#7541).
2813
2814 2011-08-02 Kenichi Handa <handa@m17n.org>
2815
2816 * lisp.h (uniprop_table): Extern it.
2817
2818 * chartab.c (uniprop_table): Make it non-static.
2819
2820 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2821
2822 * xdisp.c (forward_to_next_line_start): Accept additional argument
2823 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2824 on the newline.
2825 (reseat_at_next_visible_line_start): Use the bidi iterator state
2826 returned by forward_to_next_line_start to restore the state of
2827 it->bidi_it after backing up to previous newline. (Bug#9212)
2828
2829 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2830
2831 * regex.c (re_comp): Protoize.
2832 (re_exec): Fix return type.
2833 (regexec): Fix type of `ret'. (Bug#9203)
2834
2835 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2838 This is needed if max-image-size is a floating-point number.
2839
2840 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2841
2842 * print.c (print_object): Print empty symbol as ##.
2843
2844 * lread.c (read1): Read ## as empty symbol.
2845
2846 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2847
2848 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2849 setting frame foreground color (Bug#9175).
2850 (x_set_background_color): Likewise.
2851
2852 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2853 contents (Bug#9176).
2854 (EmacsTooltip -init): Remove bezels and add shadows to
2855 tooltip windows.
2856
2857 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2858 or scroll bar (Bug#8470).
2859
2860 * nsfont.m (nsfont_open): Remove assignment to voffset and
2861 unnecessary vars hshink, expand, hd, full_height, min_height.
2862 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2863
2864 * nsterm.h (nsfont_info): Remove voffset field.
2865
2866 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2867
2868 Implement strike-through and overline on NextStep (Bug#8863).
2869
2870 * nsfont.m (nsfont_open): Use underline position provided by font,
2871 instead of hard-coded value of 2.
2872 (nsfont_draw): Call ns_draw_text_decoration instead.
2873
2874 * nsterm.h: Add declaration for ns_draw_text_decoration.
2875
2876 * nsterm.m (ns_draw_text_decoration): New function for drawing
2877 underline, overline, and strike-through.
2878 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2879 ns_draw_text_decoration. Change treatment of cursor drawing to
2880 accommodate underlining, etc.
2881
2882 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2883
2884 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2885 default.
2886
2887 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2888
2889 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2890 Without this fix, if a signal arrives just after memory fills up,
2891 'malloc' might be invoked reentrantly.
2892
2893 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2894 In other words, assume that every image size is allowed, on non-X
2895 hosts. This assumption is probably wrong, but it lets Emacs compile.
2896
2897 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2898
2899 * regex.c (re_iswctype): Convert return values to boolean.
2900
2901 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2902
2903 * xdisp.c (compute_display_string_pos): Don't use cached display
2904 string position if the buffer had its restriction changed.
2905 (Bug#9184)
2906
2907 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2908
2909 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2910
2911 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 Integer signedness and overflow and related fixes. (Bug#9079)
2914
2915 * bidi.c: Integer size and overflow fixes.
2916 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2917 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2918 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2919 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2920 (bidi_find_other_level_edge):
2921 Use ptrdiff_t instead of EMACS_INT where either will do.
2922 This works better on 32-bit hosts configured --with-wide-int.
2923 (bidi_cache_ensure_space): Check for size-calculation overflow.
2924 Use % rather than repeated addition, for better worst-case speed.
2925 Don't set bidi_cache_size until after xrealloc returns, because it
2926 might not return.
2927 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2928 (bidi_cache_ensure_space): Also check that the bidi cache size
2929 does not exceed that of the largest Lisp string or buffer. See Eli
2930 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2931
2932 * alloc.c (__malloc_size_t): Remove.
2933 All uses replaced by size_t. See Andreas Schwab's note
2934 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2935
2936 * image.c: Improve checking for integer overflow.
2937 (check_image_size): Assume that f is nonnull, since
2938 it is always nonnull in practice. This is one less thing to
2939 worry about when checking for integer overflow later.
2940 (x_check_image_size): New function, which checks for integer
2941 overflow issues inside X.
2942 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2943 This removes the need for a memory_full check.
2944 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2945 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2946 (xbm_read_bitmap_data): Change locals back to 'int', since
2947 their values must fit in 'int'.
2948 (xpm_load_image, png_load, tiff_load):
2949 Invoke x_create_x_image_and_pixmap earlier,
2950 to avoid much needless work if the image is too large.
2951 (tiff_load): Treat overly large images as if
2952 x_create_x_image_and_pixmap failed, not as malloc failures.
2953 (gs_load): Use x_check_image_size.
2954
2955 * gtkutil.c: Omit integer casts.
2956 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2957 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2958
2959 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2960
2961 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2962 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2963 would wrongly return t on a 64-bit host.
2964
2965 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2966 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2967 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2968 and therefore cause GCC to emit a bogus diagnostic in some cases.
2969
2970 * image.c: Integer signedness and overflow and related fixes.
2971 This is not an exhaustive set of fixes, but it's time to
2972 record what I've got.
2973 (lookup_pixel_color, check_image_size): Remove redundant decls.
2974 (check_image_size): Don't assume that arbitrary EMACS_INT values
2975 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2976 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2977 (tiff_load, imagemagick_load_image):
2978 Check for overflow in size calculations.
2979 (x_create_x_image_and_pixmap): Remove unnecessary test for
2980 xmalloc returning NULL; that can't happen.
2981 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2982 (xpm_color_bucket): Use better integer hashing function.
2983 (xpm_cache_color): Don't possibly over-allocate memory.
2984 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2985 (gif_memory_source):
2986 Use ptrdiff_t, not int or size_t, to record sizes.
2987 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2988 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2989 either works, as we prefer signed integers.
2990 (tiff_read_from_memory, tiff_write_from_memory):
2991 Return tsize_t, not size_t, since that's what the TIFF API wants.
2992 (tiff_read_from_memory): Don't fail simply because the read would
2993 go past EOF; instead, return a short read.
2994 (tiff_load): Omit no-longer-needed casts.
2995 (Fimagemagick_types): Don't assume size fits into 'int'.
2996
2997 Improve hashing quality when configured --with-wide-int.
2998 * fns.c (hash_string): New function, taken from sxhash_string.
2999 Do not discard information about ASCII character case; this
3000 discarding is no longer needed.
3001 (sxhash-string): Use it. Change sig to match it. Caller changed.
3002 * lisp.h: Declare it.
3003 * lread.c (hash_string): Remove, since we now use fns.c's version.
3004 The fns.c version returns a wider integer if --with-wide-int is
3005 specified, so this should help the quality of the hashing a bit.
3006
3007 * emacs.c: Integer overflow minor fix.
3008 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3009 Define only if GNU_LINUX.
3010 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3011
3012 * dispnew.c: Integer signedness and overflow fixes.
3013 Remove unnecessary forward decls, that were a maintenance hassle.
3014 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3015 All uses changed.
3016 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3017 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3018 (prepare_desired_row, line_draw_cost):
3019 Use int, not unsigned, where either works.
3020 (save_current_matrix, restore_current_matrix):
3021 Use ptrdiff_t, not size_t, where either works.
3022 (init_display): Check for overflow more accurately, and without
3023 relying on undefined behavior.
3024
3025 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3026 Remove, replacing with the new symbols in lisp.h. All uses changed.
3027 * fileio.c (make_temp_name):
3028 * filelock.c (lock_file_1, lock_file):
3029 * xdisp.c (message_dolog):
3030 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3031 Use pMd etc. instead.
3032 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3033 replacing the pWIDE etc. symbols removed from editfns.c.
3034
3035 * keyboard.h (num_input_events): Now uintmax_t.
3036 This is (very slightly) less likely to mess up due to wraparound.
3037 All uses changed.
3038
3039 * buffer.c: Integer signedness fixes.
3040 (alloc_buffer_text, enlarge_buffer_text):
3041 Use ptrdiff_t rather than size_t when either will do, as we prefer
3042 signed integers.
3043
3044 * alloc.c: Integer signedness and overflow fixes.
3045 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3046 (__malloc_size_t): Default to size_t, not to int.
3047 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3048 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3049 Prefer ptrdiff_t to size_t when either would do, as we prefer
3050 signed integers.
3051 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3052 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3053 Now const. Initialize with values that are in range even if char
3054 is signed.
3055 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3056 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3057 These functions do the right thing with sizes > 2**32.
3058 (check_depth): Now ptrdiff_t, not int.
3059 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3060 Adjust to new way of storing sizes. Check for size overflow bugs
3061 in rest of code.
3062 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3063 slightly wrong anyway, as it missed one instance of
3064 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3065 (refill_memory_reserve): Omit needless cast to size_t.
3066 (mark_object_loop_halt): Mark as externally visible.
3067
3068 * xselect.c: Integer signedness and overflow fixes.
3069 (Fx_register_dnd_atom, x_handle_dnd_message):
3070 Use ptrdiff_t, not size_t, since we prefer signed.
3071 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3072 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3073 x_dnd_atoms_size and x_dnd_atoms_length.
3074
3075 * doprnt.c: Prefer signed to unsigned when either works.
3076 * eval.c (verror):
3077 * doprnt.c (doprnt):
3078 * lisp.h (doprnt):
3079 * xdisp.c (vmessage):
3080 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3081 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3082 prefer signed arithmetic to avoid comparison confusion.
3083 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3084 but is a bit tricky.
3085
3086 Assume freestanding C89 headers, string.h, stdlib.h.
3087 * data.c, doprnt.c, floatfns.c, print.c:
3088 Include float.h unconditionally.
3089 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3090 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3091 * regex.c: Likewise for stddef.h, string.h.
3092 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3093 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3094 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3095 (STDC_HEADERS): Remove obsolete defines.
3096 * sysdep.c: Include limits.h unconditionally.
3097
3098 Assume support for memcmp, memcpy, memmove, memset.
3099 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3100 * regex.c (memcmp, memcpy):
3101 Remove; we assume C89 now.
3102
3103 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3104 (__malloc_safe_bcopy): Remove; no longer needed.
3105
3106 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3107 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3108 well either way, and we prefer signed to unsigned.
3109
3110 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3111
3112 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3113 closes the connection while we're reading (bug#9182).
3114
3115 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3116
3117 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3118 are specified (Bug#9168).
3119
3120 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3123 Found by GCC static checking and --with-wide-int on a 32-bit host.
3124
3125 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3126
3127 * xdisp.c (compute_display_string_pos): Fix logic of caching
3128 previous display string position. Initialize cached_prev_pos to
3129 -1. Fixes slow-down at the beginning of a buffer.
3130
3131 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3132
3133 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3134 for attrs[LFACE_FONTSET_INDEX].
3135
3136 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * xml.c (parse_region): Remove unused local
3139 that was recently introduced.
3140
3141 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3142
3143 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3144 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3145
3146 * xdisp.c (move_it_in_display_line_to): Record the best matching
3147 position for TO_CHARPOS while scanning the line, and restore it on
3148 exit if none of the characters scanned was an exact match.
3149 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3150 when exact match is impossible due to invisible text, and the
3151 lines are truncated.
3152
3153 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3154
3155 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3156 for OSX >= 10.7.
3157
3158 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3159
3160 Fix a significant slow-down of cursor motion with C-n, C-p,
3161 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3162 auto-repeat under bidi redisplay in fontified buffers.
3163 * xdisp.c (compute_stop_pos_backwards): New function.
3164 (next_element_from_buffer): Call compute_stop_pos_backwards to
3165 find a suitable prev_stop when we find ourselves before
3166 base_level_stop.
3167 (reseat): Don't look for prev_stop, as that could mean a very long
3168 run.
3169 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3170 <cached_disp_overlay_modiff>: Cache for last found display string
3171 position.
3172 (compute_display_string_pos): Return the cached position if asked
3173 about the same buffer in the same area of character positions, and
3174 the buffer wasn't changed since the time the display string
3175 position was cached.
3176
3177 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3178
3179 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3180 is an integer, which is important for empty lines. (Bug#9149)
3181
3182 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3183
3184 * frame.c (Fmodify_frame_parameters): In tty case, update the
3185 default face if necessary (Bug#4238).
3186
3187 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3188
3189 * editfns.c (Fstring_to_char): No need to explain what a character
3190 is in the docstring (Bug#6576).
3191
3192 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3193
3194 * xml.c (parse_region): Make sure we always return a tree.
3195
3196 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3197
3198 * xml.c (parse_region): If a document contains only comments,
3199 return that, too.
3200
3201 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3202
3203 * xml.c (make_dom): Return comments, too.
3204
3205 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3206
3207 Port to OpenBSD.
3208 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3209 and the surrounding thread.
3210 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3211 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3212 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3213 timer goes off.
3214 * s/openbsd.h (BROKEN_SIGIO): Define.
3215 * unexelf.c (unexec) [__OpenBSD__]:
3216 Don't update the .mdebug section of the Alpha COFF symbol table.
3217
3218 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3219
3220 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3221 (bug#8460).
3222
3223 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3226 This fixes some race conditions on the permissions of any newly
3227 created file.
3228
3229 * alloc.c (valid_pointer_p): Use pipe, not open.
3230 This fixes some permissions issues when debugging.
3231
3232 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3233 If fchown fails to set both uid and gid, try to set just gid,
3234 as that is sometimes allowed. Adjust the file's mode to eliminate
3235 setuid or setgid bits that are inappropriate if fchown fails.
3236
3237 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3240 to compare Lisp_Objects.
3241 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3242 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3243 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3244
3245 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3246
3247 * lread.c (read_integer): Unread even EOF character.
3248 (read1): Likewise. Properly record start position of symbol.
3249
3250 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3251 symbol character follows.
3252
3253 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3256 This works around a problem with the previous change to Fcopy_file.
3257 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3258 and without this change, GCC might complain about discarding
3259 fchown's return value.
3260
3261 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3262
3263 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3264
3265 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3268
3269 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3270
3271 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3272 it's used from the C level.
3273
3274 * process.c: Use the same condition for POLL_FOR_INPUT in both
3275 keyboard.c and process.c (bug#1858).
3276
3277 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3278
3279 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3280 (Fgnutls_boot): Use it.
3281
3282 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3283
3284 * doc.c (Fsubstitute_command_keys): Revert last change.
3285
3286 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3287
3288 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3289 quotes the next character, and doesn't affect other longer
3290 sequences (bug#8935).
3291
3292 * lread.c (syms_of_lread): Clarify that is isn't only
3293 `eval-buffer' and `eval-defun' that's affected by
3294 `lexical-binding' (bug#8460).
3295
3296 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3297
3298 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3299 bidi redisplay when a line includes both an image and is truncated.
3300
3301 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3302
3303 Fix minor problems found by static checking.
3304 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3305 (elsz): Now a signed constant, not a size_t var. We prefer signed
3306 types to unsigned, to avoid integer comparison confusion. Without
3307 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3308 "cannot optimize loop, the loop counter may overflow", a symptom
3309 of the confusion.
3310 * indent.c (Fvertical_motion): Mark locals as initialized.
3311 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3312
3313 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3314
3315 * search.c (Fre_search_backward): Mention `case-fold-search' in
3316 all the re_search_* functions (bug#8138).
3317
3318 * keyboard.c (Fopen_dribble_file): Document when the file is
3319 closed (bug#8056).
3320
3321 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3322
3323 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3324 bidi_cache_idx.
3325
3326 Support bidi reordering of display and overlay strings.
3327 * xdisp.c (compute_display_string_pos)
3328 (compute_display_string_end): Accept additional argument STRING.
3329 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3330 (reseat_to_string): Initialize bidi_it->string.s and
3331 bidi_it->string.schars.
3332 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3333 NULL (avoids a crash in bidi_paragraph_init).
3334 Initialize itb.string.lstring.
3335 (init_iterator): Call bidi_init_it only of a valid
3336 buffer position was specified. Initialize paragraph_embedding to
3337 L2R.
3338 (reseat_to_string): Initialize the bidi iterator.
3339 (display_string): If we need to ignore text properties of
3340 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3341 original value of -1 will not work with bidi.)
3342 (compute_display_string_pos): First arg is now struct
3343 `text_pos *'; all callers changed. Support display properties on
3344 Lisp strings.
3345 (compute_display_string_end): Support display properties on Lisp
3346 strings.
3347 (init_iterator, reseat_1, reseat_to_string): Initialize the
3348 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3349 when iterating on a string not from display properties).
3350 (compute_display_string_pos, compute_display_string_end):
3351 Fix calculation of the object to scan. Fixes an error when using
3352 arrow keys.
3353 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3354 base_level_stop; instead, set base_level_stop to BEGV.
3355 Fixes crashes in vertical-motion.
3356 (next_element_from_buffer): Improve commentary for when
3357 the iterator is before prev_stop.
3358 (init_iterator): Initialize bidi_p from the default value of
3359 bidi-display-reordering, not from buffer-local value. Use the
3360 buffer-local value only if initializing for buffer iteration.
3361 (handle_invisible_prop): Support invisible properties on strings
3362 that are being bidi-reordered.
3363 (set_iterator_to_next): Support bidi reordering of C strings and
3364 Lisp strings.
3365 (next_element_from_string): Support bidi reordering of Lisp
3366 strings.
3367 (handle_stop_backwards): Support Lisp strings as well.
3368 (display_string): Support display of R2L glyph rows.
3369 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3370 (init_iterator): Don't initialize it->bidi_p for strings
3371 here.
3372 (reseat_to_string): Initialize it->bidi_p for strings here.
3373 (next_element_from_string, next_element_from_c_string)
3374 (next_element_from_buffer): Add xassert's for correspondence
3375 between IT's object being iterated and it->bidi_it.string
3376 structure.
3377 (face_before_or_after_it_pos): Support bidi iteration.
3378 (next_element_from_c_string): Handle the case of the first string
3379 character that is not the first one in the visual order.
3380 (get_visually_first_element): New function, refactored from common
3381 parts of next_element_from_buffer, next_element_from_string, and
3382 next_element_from_c_string.
3383 (tool_bar_lines_needed, redisplay_tool_bar)
3384 (display_menu_bar): Force left-to-right direction. Add a FIXME
3385 comment for making that be controlled by a user option.
3386 (push_it, pop_it): Save and restore the state of the
3387 bidi iterator. Save and restore the bidi_p flag.
3388 (pop_it): Iterate out of display property for string iteration as
3389 well.
3390 (iterate_out_of_display_property): Support iteration over strings.
3391 (handle_single_display_spec): Set up it->bidi_it for iteration
3392 over a display string, and call bidi_init_it.
3393 (handle_single_display_spec, next_overlay_string)
3394 (get_overlay_strings_1, push_display_prop): Set up the bidi
3395 iterator for displaying display or overlay strings.
3396 (forward_to_next_line_start): Don't use the shortcut if
3397 bidi-iterating.
3398 (back_to_previous_visible_line_start): If handle_display_prop
3399 pushed the iterator stack, restore the internal state of the bidi
3400 iterator by calling bidi_pop_it same number of times.
3401 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3402 and we are bidi-iterating, don't decrement the iterator position;
3403 instead, set the first_elt flag in the bidi iterator, to produce
3404 the same effect.
3405 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3406 (push_display_prop): xassert that we are iterating a buffer.
3407 (push_it, pop_it): Save and restore paragraph_embedding member.
3408 (handle_single_display_spec, next_overlay_string)
3409 (get_overlay_strings_1, reseat_1, reseat_to_string)
3410 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3411 correctly. Don't assume unibyte strings are not bidi-reordered.
3412 (compute_display_string_pos)
3413 (compute_display_string_end): Fix handling the case of C string.
3414 (push_it, pop_it): Save and restore from_disp_prop_p.
3415 (handle_single_display_spec, push_display_prop): Set the
3416 from_disp_prop_p flag.
3417 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3418 (pop_it): Call iterate_out_of_display_property only if we are
3419 popping after iteration over a string that came from a display
3420 property. Fix a typo in popping stretch info. Add an assertion
3421 for verifying that the iterator position is in sync with the bidi
3422 iterator.
3423 (handle_single_display_spec, get_overlay_strings_1)
3424 (push_display_prop): Fix initialization of paragraph direction for
3425 string when that of the parent object is not yet determined.
3426 (reseat_1): Call bidi_init_it to resync the bidi
3427 iterator with IT's position. (Bug#7616)
3428 (find_row_edges): If ROW->start.pos gives position
3429 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3430 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3431 Reset the from_disp_prop_p flag.
3432 (SAVE_IT, RESTORE_IT): New macros.
3433 (pos_visible_p, face_before_or_after_it_pos)
3434 (back_to_previous_visible_line_start)
3435 (move_it_in_display_line_to, move_it_in_display_line)
3436 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3437 (try_scrolling, redisplay_window, display_line): Use them when
3438 saving a temporary copy of the iterator and restoring it back.
3439 (back_to_previous_visible_line_start, reseat_1)
3440 (init_iterator): Empty the bidi cache "stack".
3441 (move_it_in_display_line_to): If iterator ended up at
3442 EOL, but we never saw any buffer positions smaller than
3443 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3444 motion in bidi-reordered lines.
3445 (move_it_in_display_line_to): Record prev_method and prev_pos
3446 immediately before the call to set_iterator_to_next. Fixes cursor
3447 motion in bidi-reordered lines with stretch glyphs and strings
3448 displayed in margins. (Bug#8133) (Bug#8867)
3449 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3450 TO_CHARPOS.
3451 (pos_visible_p): Support positions in bidi-reordered lines.
3452 Save and restore bidi cache.
3453
3454 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3455 (bidi_paragraph_info): Delete unused struct.
3456 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3457 (bidi_cache_start): New variable.
3458 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3459 to zero.
3460 (bidi_cache_fetch_state, bidi_cache_search)
3461 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3462 (bidi_cache_find, bidi_peek_at_next_level)
3463 (bidi_level_of_next_char, bidi_find_other_level_edge)
3464 (bidi_move_to_visually_next): Compare cache index with
3465 bidi_cache_start rather than with zero.
3466 (bidi_fetch_char): Accept new argument STRING; all callers
3467 changed. Support iteration over a string. Support strings with
3468 display properties. Support unibyte strings. Fix the type of
3469 `len' according to what STRING_CHAR_AND_LENGTH expects.
3470 (bidi_paragraph_init, bidi_resolve_explicit_1)
3471 (bidi_resolve_explicit, bidi_resolve_weak)
3472 (bidi_level_of_next_char, bidi_move_to_visually_next):
3473 Support iteration over a string.
3474 (bidi_set_sor_type, bidi_resolve_explicit_1)
3475 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3476 can now be zero (for strings); special values 0 and -1 were
3477 changed to -1 and -2, respectively.
3478 (bidi_char_at_pos): New function.
3479 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3480 Call it instead of FETCH_MULTIBYTE_CHAR.
3481 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3482 initialized to valid values.
3483 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3484 values.
3485 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3486 the test for valid cached positions. Fix the logic for looking up
3487 the sentinel state in the cache. GCPRO the Lisp string we are
3488 iterating.
3489 (bidi_push_it, bidi_pop_it): New functions.
3490 (bidi_initialize): Initialize the bidi cache start stack pointer.
3491 (bidi_cache_ensure_space): New function, refactored from part of
3492 bidi_cache_iterator_state. Don't assume the required size is just
3493 one BIDI_CACHE_CHUNK away.
3494 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3495 (bidi_count_bytes, bidi_char_at_pos): New functions.
3496 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3497 always valid if bidi_cache_idx is valid.
3498 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3499 is valid if it's going to be used.
3500 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3501 (bidi_cache_fetch_state, bidi_cache_search)
3502 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3503 (bidi_cache_iterator_state, bidi_cache_find)
3504 (bidi_find_other_level_edge, bidi_cache_start_stack):
3505 All variables related to cache indices are now EMACS_INT.
3506
3507 * dispextern.h (struct bidi_string_data): New structure.
3508 (struct bidi_it): New member `string'. Make flag members be 1-bit
3509 fields, and put them last in the struct.
3510 (compute_display_string_pos, compute_display_string_end):
3511 Update prototypes.
3512 (bidi_push_it, bidi_pop_it): Add prototypes.
3513 (struct iterator_stack_entry): New members bidi_p,
3514 paragraph_embedding, and from_disp_prop_p.
3515 (struct it): Member bidi_p is now a bit field 1 bit wide.
3516 (bidi_shelve_cache, bidi_unshelve_cache):
3517 Declare prototypes.
3518
3519 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3520 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3521 and vector-like objects.
3522
3523 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3524 cache around display iteration.
3525
3526 * window.c (Fwindow_end, window_scroll_pixel_based)
3527 (displayed_window_lines, Frecenter): Save and restore the bidi
3528 cache around display iteration.
3529
3530 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3531
3532 * editfns.c (Fdelete_region): Clarify the use of the named
3533 parameters (bug#6788).
3534
3535 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3536
3537 * indent.c (Fvertical_motion): Set and restore w->pointm when
3538 saving and restoring the window's buffer (Bug#9006).
3539
3540 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3541
3542 * editfns.c (Fstring_to_char): Clarify just what is returned
3543 (bug#6576). Text by Eli Zaretskii.
3544
3545 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3548
3549 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3550
3551 * buffer.c (mmap_find): Fix a typo.
3552
3553 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3554
3555 Fix execution of x selection hooks.
3556 * xselect.c (Qx_lost_selection_functions)
3557 (Qx_sent_selection_functions): New vars.
3558 (syms_of_xselect): DEFSYM them.
3559 (x_handle_selection_request): Pass Qx_sent_selection_functions
3560 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3561 (x_handle_selection_clear,x_clear_frame_selections):
3562 Pass Qx_lost_selection_functions rather than
3563 Vx_lost_selection_functions to Frun_hook_with_args.
3564
3565 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3568 The old code sometimes used this field without initializing it.
3569
3570 * alloc.c (gc_sweep): Don't read past end of array.
3571 In theory, the old code could also have corrupted Emacs internals,
3572 though it'd be very unlikely.
3573
3574 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3575
3576 * character.c (Fcharacterp): Don't advertise optional ignored
3577 argument. (Bug#4026)
3578
3579 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
3581 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3582 key" (bug#4257).
3583
3584 * window.c (Fset_window_start): Doc fix (bug#4199).
3585 (Fset_window_hscroll): Ditto.
3586
3587 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 Fix minor new problems caught by GCC 4.6.1.
3590 * term.c (init_tty): Remove unused local.
3591 * xsettings.c (store_monospaced_changed): Define this function only
3592 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3593 not used otherwise.
3594
3595 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3596
3597 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3598
3599 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3600
3601 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3602 are the mini-buffer and the echo area (bug#3320).
3603
3604 * term.c (init_tty): Remove support for supdup, c10 and perq
3605 terminals, which are no longer supported (bug#1482).
3606
3607 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3608
3609 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3610
3611 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3612
3613 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3614 for non-popups (Bug#3642).
3615
3616 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * alloc.c (reset_malloc_hooks): Protoize.
3619 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3620 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3621 * cm.c (losecursor): Likewise.
3622 * data.c (fmod): Likewise.
3623 * dispnew.c (swap_glyphs_in_rows): Likewise.
3624 * emacs.c (memory_warning_signal): Likewise.
3625 * floatfns.c (float_error): Likewise.
3626 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3627 (otf_open, font_otf_capability, generate_otf_features)
3628 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3629 Likewise.
3630 * image.c (pbm_read_file): Likewise.
3631 * indent.c (string_display_width): Likewise.
3632 * intervals.c (check_for_interval, search_for_interval)
3633 (inc_interval_count, count_intervals, root_interval)
3634 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3635 * lread.c (defalias): Likewise.
3636 * ralloc.c (r_alloc_check): Likewise.
3637 * regex.c (set_image_of_range_1, set_image_of_range)
3638 (regex_grow_registers): Likewise.
3639 * sysdep.c (strerror): Likewise.
3640 * termcap.c (valid_filename_p, tprint, main): Likewise.
3641 * tparam.c (main): Likewise.
3642 * unexhp9k800.c (run_time_remap, save_data_space)
3643 (update_file_ptrs, read_header, write_header, calculate_checksum)
3644 (copy_file, copy_rest, display_header): Likewise.
3645 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3646 Likewise.
3647 * xdisp.c (check_it): Likewise.
3648 * xfaces.c (register_color, unregister_color, unregister_colors):
3649 Likewise.
3650 * xfns.c (print_fontset_result): Likewise.
3651 * xrdb.c (member, fatal, main): Likewise.
3652
3653 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 Fix minor problems found by static checking (Bug#9031).
3656 * chartab.c (char_table_set_range, map_sub_char_table):
3657 Remove unused locals.
3658 (uniprop_table): Now static.
3659 * composite.c (_work_char): Remove unused static var.
3660
3661 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3662
3663 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3664
3665 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3666
3667 * gtkutil.c (qttip_cb): Remove code without function.
3668
3669 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3670
3671 * w32.c (pthread_sigmask): New stub.
3672
3673 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 Use pthread_sigmask, not sigprocmask (Bug#9010).
3676 sigprocmask is portable only for single-threaded applications, and
3677 Emacs can be multi-threaded when it uses GTK.
3678 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3679 (LIBES): Use it.
3680 * callproc.c (Fcall_process):
3681 * process.c (create_process):
3682 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3683 Use pthread_sigmask, not sigprocmask.
3684
3685 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3686
3687 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3688 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3689 wrong (Bug#8591).
3690
3691 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3692
3693 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3694 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3695 (xg_hide_tooltip): Fix comment.
3696
3697 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3698 in registerServicesMenuSendTypes.
3699 (validRequestorForSendType): Don't check ns_return_types.
3700
3701 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3702 ns_return_type.
3703
3704 2011-07-08 Jason Rumney <jasonr@gnu.org>
3705
3706 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3707 SH_SHOW for hidden windows (Bug#5482).
3708
3709 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3710 frame struct members of non-existent frames (Bug#6284).
3711
3712 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3713
3714 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3715 variable firstTime not needed on OSX >= 10.6.
3716 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3717 >= 10.5. Use setKnobProportion, setDoubleValue.
3718
3719 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3720 (MAC_OS_X_VERSION_10_5): Define if not defined.
3721 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3722 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3723 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3724
3725 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3726 cString and lossyCString on OSX >= 10.4
3727
3728 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3729 sizeToFit on OSX >= 10.2.
3730
3731 * nsimage.m (allocInitFromFile): Don't use deprecated method
3732 bestRepresentationForDevice on OSX >= 10.6.
3733
3734 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3735 to avoid warning.
3736
3737 * emacs.c: Declare unexec_init_emacs_zone.
3738
3739 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3740
3741 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3742
3743 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3744 on svcsMenu (Bug#8842).
3745
3746 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3747 ns_return_types.
3748 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3749
3750 * nsterm.m (QUTF8_STRING): Declare.
3751 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3752 (validRequestorForSendType): Return type is (id).
3753 Change indexOfObjectIdenticalTo to indexOfObject.
3754 Check if we have local selection before returning self (Bug#8842).
3755 (writeSelectionToPasteboard): Put local selection into paste board
3756 if we have a local selection (Bug#8842).
3757 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3758
3759 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3760 (ns_get_local_selection): Declare.
3761
3762 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3763
3764 * keymap.c (describe_map_tree): Don't insert a double newline at
3765 the end of the buffer (bug#1169) and return whether we inserted
3766 something.
3767
3768 * callint.c (Fcall_interactively): Change "reading args" to
3769 "providing args" to try to clarify what it does (bug#1010).
3770
3771 2011-07-07 Kenichi Handa <handa@m17n.org>
3772
3773 * composite.c (composition_compute_stop_pos): Ignore a static
3774 composition starting before CHARPOS (Bug#8915).
3775
3776 * xdisp.c (handle_composition_prop): Likewise.
3777
3778 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3779
3780 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3781 (Bug#9015)
3782
3783 2011-07-07 Kenichi Handa <handa@m17n.org>
3784
3785 * character.h (unicode_category_t): New enum type.
3786
3787 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3788 (Qchar_code_property_table): New variable.
3789 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3790 (UNIPROP_COMPRESSED_FORM_P): New macros.
3791 (char_table_ascii): Uncompress the compressed values.
3792 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3793 Uncompress the compressed values.
3794 (sub_char_table_ref_and_range): Likewise.
3795 (char_table_ref_and_range): Uncompress the compressed values.
3796 (sub_char_table_set): New arg is_uniprop. Callers changed.
3797 Uncompress the compressed values.
3798 (sub_char_table_set_range): Args changed. Callers changed.
3799 (char_table_set_range): Adjuted for the above change.
3800 (map_sub_char_table): Delete args default_val and parent. Add arg
3801 top. Give decoded values to a Lisp function.
3802 (map_char_table): Adjust for the above change. Give decoded
3803 values to a Lisp function. Gcpro more variables.
3804 (uniprop_table_uncompress)
3805 (uniprop_decode_value_run_length): New functions.
3806 (uniprop_decoder, uniprop_decoder_count): New variables.
3807 (uniprop_get_decoder, uniprop_encode_value_character)
3808 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3809 New functions.
3810 (uniprop_encoder, uniprop_encoder_count): New variables.
3811 (uniprop_get_encoder, uniprop_table)
3812 (Funicode_property_table_internal, Fget_unicode_property_internal)
3813 (Fput_unicode_property_internal): New functions.
3814 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3815 Sunicode_property_table_internal, Sget_unicode_property_internal,
3816 and Sput_unicode_property_internal. Defvar_lisp
3817 char-code-property-alist.
3818
3819 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3820 Vunicode_category_table.
3821
3822 * font.c (font_range): Adjust for the change of
3823 Vunicode_category_table.
3824
3825 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3826
3827 * m/iris4d.h: Remove file, move contents ...
3828 * s/irix6-5.h: ... here.
3829
3830 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Remove unportable assumption about struct layout (Bug#8884).
3833 * alloc.c (mark_buffer):
3834 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3835 (clone_per_buffer_values): Don't assume that
3836 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3837 This isn't true in general, and it's particularly not true
3838 if Emacs is configured with --with-wide-int.
3839 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3840 New macros, used in the buffer.c change.
3841
3842 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3843
3844 * xsettings.c: Use both GConf and GSettings if both are available.
3845 (store_config_changed_event): Add comment.
3846 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3847 (store_tool_bar_style_changed): New functions.
3848 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3849 (struct xsettings): Move font inside HAVE_XFT.
3850 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3851 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3852 Move inside HAVE_XFT.
3853 (something_changed_gsettingsCB): Rename from something_changedCB.
3854 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3855 also.
3856 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3857 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3858 (something_changed_gconfCB): Rename from something_changedCB.
3859 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3860 (parse_settings): Move check for font inside HAVE_XFT.
3861 (read_settings, apply_xft_settings): Add comment.
3862 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3863 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3864 call store_font_name_changed.
3865 (xft_settings_event): Add comment.
3866 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3867 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3868 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3869 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3870 (xsettings_initialize): Call init_gsettings last.
3871 (xsettings_get_system_font, xsettings_get_system_normal_font):
3872 Add comment.
3873
3874 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Random fixes. E.g., (random) never returned negative values.
3877 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3878 subseconds part to the entropy, as that's a bit more random.
3879 Prefer signed to unsigned, since the signedness doesn't matter and
3880 in general we prefer signed. When given a limit, use a
3881 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3882 latter isn't right if USE_2_TAGS_FOR_INTS.
3883 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3884 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3885
3886 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * textprop.c (text_property_stickiness):
3889 Obey Vtext_property_default_nonsticky.
3890 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3891 * w32fns.c (syms_of_w32fns):
3892 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3893
3894 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3897 This is more efficient than Ffile_directory_p and avoids a minor race.
3898
3899 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3900
3901 * buffer.c (Foverlay_put): Say what the return value is
3902 (bug#7835).
3903
3904 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3905 is a directory before asking whether to use the file name
3906 (bug#7564).
3907 (barf_or_query_if_file_exists): Make the "File is a directory"
3908 error be more correct.
3909
3910 * fns.c (Frequire): Remove the mention of the .gz files, since
3911 that's installation-specific, but keep the mention of
3912 `get-load-suffixes'.
3913
3914 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3915
3916 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3917 Report string overflow if the output is too long.
3918
3919 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3922 (syms_of_gnutls): Remove duplicate DEFSYM for
3923 Qgnutls_bootprop_verify_hostname_error, an error for
3924 Qgnutls_bootprop_verify_error (which is no longer used).
3925
3926 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3927 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3928 Also (re)move comments that are misplaced or no longer relevant.
3929
3930 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3931
3932 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3933
3934 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3937 and background color parameters if they have been changed.
3938
3939 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3940
3941 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3942
3943 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * xsettings.c (SYSTEM_FONT): Define only when used.
3946 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3947
3948 * keymap.c (access_keymap_1): Now static.
3949
3950 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3951
3952 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3953 leave any prefix arg for the up event (Bug#1586).
3954
3955 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3956
3957 * lread.c (syms_of_lread): Mention single symbols defined by
3958 `defvar' or `defconst' (bug#7154).
3959
3960 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3961 (Frequire): Mention get-load-suffixes.
3962
3963 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3964
3965 * window.h (window): Remove clone_number slot.
3966 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3967 Remove.
3968 (make_parent_window, make_window, saved_window)
3969 (Fset_window_configuration, save_window_save): Don't deal with
3970 clone numbers.
3971 * buffer.c (Qclone_number): Remove declaration.
3972 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3973
3974 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3975
3976 Add multiple inheritance to keymaps.
3977 * keymap.c (Fmake_composed_keymap): New function.
3978 (Fset_keymap_parent): Simplify.
3979 (fix_submap_inheritance): Remove.
3980 (access_keymap_1): New function extracted from access_keymap to handle
3981 embedded parents and handle lists of maps.
3982 (access_keymap): Use it.
3983 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3984 (Fcopy_keymap): Handle embedded parents.
3985 (Fcommand_remapping, define_as_prefix): Simplify.
3986 (Fkey_binding): Simplify.
3987 (syms_of_keymap): Move minibuffer-local-completion-map,
3988 minibuffer-local-filename-completion-map,
3989 minibuffer-local-must-match-map, and
3990 minibuffer-local-filename-must-match-map to Elisp.
3991 (syms_of_keymap): Defsubr make-composed-keymap.
3992 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3993 (parse_menu_item): Trivial simplification.
3994
3995 2011-07-01 Glenn Morris <rgm@gnu.org>
3996
3997 * Makefile.in (SETTINGS_LIBS): Fix typo.
3998
3999 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4000
4001 * coding.c (Fencode_coding_string): Record the last coding system
4002 used, as the function doc string says (bug#8738).
4003
4004 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4005
4006 * xsettings.c (store_monospaced_changed): Take new font as arg and
4007 check for change against current_mono_font.
4008 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4009 (emacs_settings_constructor, emacs_settings_get_property)
4010 (emacs_settings_set_property, emacs_settings_class_init)
4011 (emacs_settings_init, gsettings_obj): Remove.
4012 (something_changedCB): New function for HAVE_GSETTINGS.
4013 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4014 with value as argument.
4015 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4016 g_settings_new (Bug#8967). Do not create gsettings_obj.
4017 Remove calls to g_settings_bind. Connect something_changedCB to
4018 "changed".
4019
4020 * xgselect.c: Add defined (HAVE_GSETTINGS).
4021 (xgselect_initialize): Ditto.
4022
4023 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4024 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4025 xg_select.
4026
4027 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4028
4029 * eval.c (struct backtrace): Simplify and port the data structure.
4030 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4031 signed bit field, as this assumption is not portable and it makes
4032 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4033 "char debug_on_exit : 1" as this is not portable either; instead,
4034 use the portable "unsigned int debug_on_exit : 1". Remove unused
4035 member evalargs. Remove obsolete comments about cc bombing out.
4036
4037 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4038
4039 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4040 Let HAVE_GSETTINGS override HAVE_GCONF.
4041 (store_monospaced_changed): New function.
4042 (EMACS_SETTINGS): A new type derived from GObject to handle
4043 GSettings notifications.
4044 (emacs_settings_constructor, emacs_settings_get_property)
4045 (emacs_settings_set_property, emacs_settings_class_init):
4046 New functions.
4047 (gsettings_client, gsettings_obj): New variables.
4048 (GSETTINGS_SCHEMA): New define.
4049 (something_changedCB): Call store_monospaced_changed.
4050 (init_gsettings): New function.
4051 (xsettings_initialize): Call init_gsettings.
4052 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4053 to NULL.
4054
4055 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4056 GCONF_CFLAGS/LIBS.
4057
4058 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4059
4060 * window.c (resize_root_window, grow_mini_window)
4061 (shrink_mini_window): Rename Qresize_root_window to
4062 Qwindow_resize_root_window and Qresize_root_window_vertically to
4063 Qwindow_resize_root_window_vertically.
4064
4065 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4068
4069 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * makefile.w32-in: Redesign dependencies so they reflect more
4072 clearly which files are directly included by each source file,
4073 and not through other includes.
4074
4075 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4076
4077 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4078 (sort_overlays, overlay_strings): When an overlay's clone number
4079 matches the window's clone number process the overlay even if
4080 the overlay's window property doesn't match the current window.
4081
4082 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4083 (Fwindow_hchild): Rename to Fwindow_left_child.
4084 (Fwindow_next): Rename to Fwindow_next_sibling.
4085 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4086 (resize_window_check): Rename to window_resize_check.
4087 (resize_window_apply): Rename to window_resize_apply.
4088 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4089 (Fdelete_other_windows_internal, resize_frame_windows)
4090 (Fsplit_window_internal, Fdelete_window_internal)
4091 (grow_mini_window, shrink_mini_window)
4092 (Fresize_mini_window_internal): Fix callers accordingly.
4093
4094 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4095
4096 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4097 (emacs_fixed_set_min_size): Remove.
4098 (emacs_fixed_new): Take frame as argument.
4099
4100 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4101 (_EmacsFixedPrivate): Remove minwidth/height.
4102 Add struct frame *f.
4103 (emacs_fixed_init): Initialize priv->f.
4104 (get_parent_class, emacs_fixed_set_min_size): Remove.
4105 (emacs_fixed_new): Set priv->f to argument.
4106 (emacs_fixed_get_preferred_width)
4107 (emacs_fixed_get_preferred_height): Use min_width/height from
4108 frames size_hint to set minimum and natural (Bug#8919).
4109 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4110 and use min_width/height from frames size_hint to set
4111 min_width/height (Bug#8919).
4112
4113 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4114 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4115 Fix indentation.
4116
4117 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4118
4119 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4120 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4121 called at ZV.
4122
4123 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4124
4125 * process.c (wait_reading_process_output): Bypass select if
4126 waiting for a cell while ignoring keyboard input, and input is
4127 pending. Suggested by Jan Djärv (Bug#8869).
4128
4129 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 Use gnulib's dup2 module instead of rolling our own.
4132 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4133
4134 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4135
4136 * dispnew.c (scrolling_window): Before scrolling, turn off a
4137 mouse-highlight in the window being scrolled.
4138
4139 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4140
4141 Move DEFSYM to lisp.h and use everywhere.
4142
4143 * character.h (DEFSYM): Move declaration...
4144 * lisp.h (DEFSYM): ...here.
4145
4146 * gnutls.c:
4147 * minibuf.c:
4148 * w32menu.c:
4149 * w32proc.c:
4150 * w32select.c: Don't include character.h.
4151
4152 * alloc.c (syms_of_alloc):
4153 * buffer.c (syms_of_buffer):
4154 * bytecode.c (syms_of_bytecode):
4155 * callint.c (syms_of_callint):
4156 * casefiddle.c (syms_of_casefiddle):
4157 * casetab.c (init_casetab_once):
4158 * category.c (init_category_once, syms_of_category):
4159 * ccl.c (syms_of_ccl):
4160 * cmds.c (syms_of_cmds):
4161 * composite.c (syms_of_composite):
4162 * dbusbind.c (syms_of_dbusbind):
4163 * dired.c (syms_of_dired):
4164 * dispnew.c (syms_of_display):
4165 * doc.c (syms_of_doc):
4166 * editfns.c (syms_of_editfns):
4167 * emacs.c (syms_of_emacs):
4168 * eval.c (syms_of_eval):
4169 * fileio.c (syms_of_fileio):
4170 * fns.c (syms_of_fns):
4171 * frame.c (syms_of_frame):
4172 * fringe.c (syms_of_fringe):
4173 * insdel.c (syms_of_insdel):
4174 * keymap.c (syms_of_keymap):
4175 * lread.c (init_obarray, syms_of_lread):
4176 * macros.c (syms_of_macros):
4177 * msdos.c (syms_of_msdos):
4178 * print.c (syms_of_print):
4179 * process.c (syms_of_process):
4180 * search.c (syms_of_search):
4181 * sound.c (syms_of_sound):
4182 * syntax.c (init_syntax_once, syms_of_syntax):
4183 * terminal.c (syms_of_terminal):
4184 * textprop.c (syms_of_textprop):
4185 * undo.c (syms_of_undo):
4186 * w32.c (globals_of_w32):
4187 * window.c (syms_of_window):
4188 * xdisp.c (syms_of_xdisp):
4189 * xfaces.c (syms_of_xfaces):
4190 * xfns.c (syms_of_xfns):
4191 * xmenu.c (syms_of_xmenu):
4192 * xsettings.c (syms_of_xsettings):
4193 * xterm.c (syms_of_xterm): Use DEFSYM.
4194
4195 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4196
4197 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4198
4199 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4200
4201 Integer and buffer overflow fixes (Bug#8873).
4202
4203 * print.c (printchar, strout): Check for string overflow.
4204 (PRINTPREPARE, printchar, strout):
4205 Don't set size unless allocation succeeds.
4206
4207 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4208 for sizes. Check for string overflow more accurately.
4209 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4210
4211 * macros.c: Integer and buffer overflow fixes.
4212 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4213 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4214 Use ptrdiff_t, not int, for sizes.
4215 Don't increment bufsize until after realloc succeeds.
4216 Check for size-calculation overflow.
4217 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4218
4219 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4220
4221 * lread.c: Integer overflow fixes.
4222 (read_integer): Radix is now EMACS_INT, not int,
4223 to improve quality of diagnostics for out-of-range radices.
4224 Calculate buffer size correctly for out-of-range radices.
4225 (read1): Check for integer overflow in radices, and in
4226 read-circle numbers.
4227 (read_escape): Avoid int overflow.
4228 (Fload, openp, read_buffer_size, read1)
4229 (substitute_object_recurse, read_vector, read_list, map_obarray):
4230 Use ptrdiff_t, not int, for sizes.
4231 (read1): Use EMACS_INT, not int, for sizes.
4232 Check for size overflow.
4233
4234 * image.c (cache_image): Check for size arithmetic overflow.
4235
4236 * lread.c: Integer overflow issues.
4237 (saved_doc_string_size, saved_doc_string_length)
4238 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4239 Now ptrdiff_t, not int.
4240 (read1): Don't assume doc string length fits in int. Check for
4241 out-of-range doc string lengths.
4242 (read_list): Don't assume file position fits in int.
4243 (read_escape): Check for hex character overflow.
4244
4245 2011-06-22 Leo Liu <sdl.web@gmail.com>
4246
4247 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4248 Move to minibuffer.el.
4249
4250 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4253 The following patches are for when GLYPH_DEBUG && !XASSERT.
4254 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4255 * dispnew.c (flush_stdout):
4256 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4257 Mark as externally visible.
4258 * dispnew.c (check_window_matrix_pointers): Now static.
4259 * dispnew.c (window_to_frame_vpos):
4260 * xfns.c (unwind_create_frame):
4261 * xterm.c (x_check_font): Remove unused local.
4262 * scroll.c (CHECK_BOUNDS):
4263 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4264 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4265 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4266 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4267 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4268 Now static.
4269 (debug_method_add): Use va_list and vsprintf rather than relying
4270 on undefined behavior with wrong number of arguments.
4271 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4272 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4273 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4274 since we're not interested in debugging glyphs with old libraries.
4275 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4276 GCC 4.6.0's static checking.
4277
4278 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4279
4280 Integer overflow and signedness fixes (Bug#8873).
4281 A few related buffer overrun fixes, too.
4282
4283 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4284
4285 * dispextern.h (struct face.stipple):
4286 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4287 (x_bitmap_mask, x_allocate_bitmap_record)
4288 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4289 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4290 (x_create_bitmap_from_xpm_data):
4291 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4292 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4293 (.bitmaps_last):
4294 * xfaces.c (load_pixmap):
4295 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4296 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4297 (.bitmaps_last, struct x_output.icon_bitmap):
4298 Use ptrdiff_t, not int, for bitmap indexes.
4299 (x_allocate_bitmap_record): Check for size overflow.
4300 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4301
4302 Use ptrdiff_t, not int, for overlay counts.
4303 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4304 * editfns.c (overlays_around, get_pos_property):
4305 * textprop.c (get_char_property_and_overlay):
4306 * xdisp.c (next_overlay_change, note_mouse_highlight):
4307 * xfaces.c (face_at_buffer_position):
4308 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4309 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4310 (Fnext_overlay_change, Fprevious_overlay_change)
4311 (mouse_face_overlay_overlaps, Foverlays_in):
4312 Use ptrdiff_t, not int, for sizes.
4313 (overlays_at, overlays_in): Check for size-calculation overflow.
4314
4315 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4316
4317 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4318 (x_session_initialize): Do not assume string length fits in int.
4319
4320 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4321 This is unlikely, but can occur if DPI is outlandish.
4322
4323 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4324 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4325
4326 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4327 * xrdb.c (magic_file_p, search_magic_path):
4328 Omit last arg SUFFIX; it was always 0. All callers changed.
4329 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4330
4331 * xfont.c (xfont_match): Avoid need for strlen.
4332
4333 * xfns.c: Don't assume strlen fits in int.
4334 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4335
4336 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4337 not unsigned long, as we prefer signed integers. All callers changed.
4338 Detect integer overflow in repeat count.
4339 (message_dolog): Don't assume print length fits in 39 bytes.
4340 (display_mode_element): Don't assume strlen fits in int.
4341
4342 * termcap.c: Don't assume sizes fit in int and never overflow.
4343 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4344 (gobble_line): Check for size-calculation overflow.
4345
4346 * minibuf.c (Fread_buffer):
4347 * lread.c (intern, intern_c_string):
4348 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4349 Don't assume string length fits in int.
4350
4351 * keyboard.c (parse_tool_bar_item):
4352 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4353
4354 * font.c: Don't assume string length fits in int.
4355 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4356 Use ptrdiff_t, not int.
4357 (font_intern_prop): Don't assume string length fits in int.
4358 Don't assume integer property fits in fixnum.
4359 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4360
4361 * filelock.c: Fix some buffer overrun and integer overflow issues.
4362 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4363 Reformulate so as not to need the command string.
4364 Invoke gzip -cd rather than gunzip, as it's more portable.
4365 (lock_info_type, lock_file_1, lock_file):
4366 Don't assume pid_t and time_t fit in unsigned long.
4367 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4368 (current_lock_owner): Prefer signed type for sizes.
4369 Use memcpy, not strncpy, where memcpy is what is really wanted.
4370 Don't assume (via atoi) that time_t and pid_t fit in int.
4371 Check for time_t and/or pid_t out of range, e.g., via a network share.
4372 Don't alloca where an auto var works fine.
4373
4374 * fileio.c: Fix some integer overflow issues.
4375 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4376 Don't assume string length fits in int.
4377 (directory_file_name): Don't assume string length fits in long.
4378 (make_temp_name): Don't assume pid fits in int, or that its print
4379 length is less than 20.
4380
4381 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4382
4383 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4384
4385 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4386
4387 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4388 We prefer signed integers, even for size calculations.
4389
4390 * emacs.c: Don't assume string length fits in 'int'.
4391 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4392 (main): Don't invoke strlen when not needed.
4393
4394 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4395 (XD_DEBUG_MESSAGE): Don't waste a byte.
4396
4397 * callproc.c (getenv_internal_1, getenv_internal)
4398 (Fgetenv_internal):
4399 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4400
4401 * lread.c (invalid_syntax): Omit length argument.
4402 All uses changed. This doesn't fix a bug, but it simplifies the
4403 code away from its former Hollerith-constant appearance, and it's
4404 one less 'int' to worry about when looking at integer-overflow issues.
4405 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4406
4407 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4408 This didn't break anything, but it didn't help either.
4409 It's confusing to put a bogus integer in a place where the actual
4410 value does not matter.
4411 (LIST_END_P): Remove unused macro and its bogus comment.
4412 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4413
4414 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4415 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4416 implementation.
4417 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4418 We prefer signed types, and the value cannot exceed the EMACS_INT
4419 range anyway (because otherwise the length would not be representable).
4420 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4421 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4422 This avoids a GCC warning when WIDE_EMACS_INT.
4423
4424 * indent.c (sane_tab_width): New function.
4425 (current_column, scan_for_column, Findent_to, position_indentation)
4426 (compute_motion): Use it. This is just for clarity.
4427 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4428
4429 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4430
4431 * lisp.h (lint_assume): New macro.
4432 * composite.c (composition_gstring_put_cache):
4433 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4434
4435 * editfns.c, insdel.c:
4436 Omit unnecessary forward decls, to simplify future changes.
4437
4438 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4439
4440 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4441
4442 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4443 Use much-faster test for byte-length change.
4444 Don't assume string byte-length fits in 'int'.
4445 Check that character arg fits in 'int'.
4446 (mapcar1): Declare byte as byte, for clarity.
4447
4448 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4449
4450 * fns.c (concat): Catch string overflow earlier.
4451 Do not rely on integer wraparound.
4452
4453 * dispextern.h (struct it.overlay_strings_charpos)
4454 (struct it.selective): Now EMACS_INT, not int.
4455 * xdisp.c (forward_to_next_line_start)
4456 (back_to_previous_visible_line_start)
4457 (reseat_at_next_visible_line_start, next_element_from_buffer):
4458 Don't arbitrarily truncate the value of 'selective' to int.
4459
4460 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4461
4462 * composite.c: Don't truncate sizes to 'int'.
4463 (composition_gstring_p, composition_reseat_it)
4464 (composition_adjust_point): Use EMACS_INT, not int.
4465 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4466 not EMACS_UINT, for indexes.
4467
4468 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4469
4470 * buffer.c: Include <verify.h>.
4471 (struct sortvec.priority, struct sortstr.priority):
4472 Now EMACS_INT, not int.
4473 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4474 (struct sortstr.size, record_overlay_string)
4475 (struct sortstrlist.size, struct sortlist.used):
4476 Don't truncate size to int.
4477 (record_overlay_string): Check for size-calculation overflow.
4478 (init_buffer_once): Check at compile-time, not run-time.
4479
4480 2011-06-22 Jim Meyering <meyering@redhat.com>
4481
4482 Don't leak an XBM-image-sized buffer
4483 * image.c (xbm_load): Free the image buffer after using it.
4484
4485 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4486
4487 Port to Sun C.
4488 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4489 that Sun C diagnosed.
4490 * fns.c (secure_hash): Fix pointer signedness issue.
4491 * intervals.c (static_offset_intervals): New function.
4492 (offset_intervals): Use it.
4493
4494 2011-06-21 Leo Liu <sdl.web@gmail.com>
4495
4496 * deps.mk (fns.o):
4497 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4498 sha512.h.
4499
4500 * fns.c (secure_hash): Rename from crypto_hash_function and change
4501 the first arg to accept symbols.
4502 (Fsecure_hash): New primitive.
4503 (syms_of_fns): New symbols.
4504
4505 2011-06-20 Deniz Dogan <deniz@dogan.se>
4506
4507 * process.c (Fset_process_buffer): Clarify return value in
4508 docstring.
4509
4510 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4511
4512 * dispnew.c (add_window_display_history): Use BVAR.
4513
4514 * xdisp.c (debug_method_add): Use BVAR.
4515 (check_window_end, dump_glyph_matrix, dump_glyph)
4516 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4517
4518 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4519 Likewise.
4520
4521 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4522 check till after the cache is created in init_frame_faces.
4523
4524 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4525
4526 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4527
4528 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4531 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4532 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4533
4534 Improve buffer-overflow checking (Bug#8873).
4535 * fileio.c (Finsert_file_contents):
4536 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4537 Remove the old (too-loose) buffer overflow checks.
4538 They weren't needed, since make_gap checks for buffer overflow.
4539 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4540 The old code merely checked for Emacs fixnum overflow, and relied
4541 on undefined (wraparound) behavior. The new code avoids undefined
4542 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4543
4544 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4545 Tune. Don't use wider integers than needed. Don't use alloca.
4546 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4547
4548 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4549
4550 * insdel.c, lisp.h (buffer_overflow): New function.
4551 (insert_from_buffer_1, replace_range, replace_range_2):
4552 * insdel.c (make_gap_larger):
4553 * editfns.c (Finsert_char):
4554 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4555
4556 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4557
4558 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4561
4562 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4563 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4564
4565 * fileio.c: Don't assume EMACS_INT fits in off_t.
4566 (emacs_lseek): New static function.
4567 (Finsert_file_contents, Fwrite_region): Use it.
4568 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4569
4570 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4571
4572 * fns.c: Don't overflow int when computing a list length.
4573 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4574 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4575 truncation on 64-bit hosts. Check for QUIT every
4576 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4577 faster and is responsive enough.
4578 (Flength): Report an error instead of overflowing an integer.
4579 (Fsafe_length): Return a float if the value is not representable
4580 as a fixnum. This shouldn't happen except in contrived situations.
4581 (Fnthcdr, Fsort): Don't assume list length fits in int.
4582 (Fcopy_sequence): Don't assume vector length fits in int.
4583
4584 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4585 (header_size, word_size): New constants.
4586 (allocate_vectorlike): Don't check size overflow here.
4587 (allocate_vector): Check it here instead, since this is the only
4588 caller of allocate_vectorlike that could cause overflow.
4589 Check that the new vector's length is representable as a fixnum.
4590
4591 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4592 The previous code was bogus. For example, next_almost_prime (32)
4593 returned 39, which is undesirable as it is a multiple of 3; and
4594 next_almost_prime (24) returned 25, which is a multiple of 5 so
4595 why was the code bothering to check for multiples of 7?
4596
4597 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4598
4599 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4600
4601 Variadic C functions now count arguments with ptrdiff_t.
4602 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4603 Back then I didn't know that the Emacs coding style prefers signed int.
4604 Also, in the meantime I found a few more instances where arguments
4605 were being counted with int, which may truncate counts on 64-bit
4606 machines, or EMACS_INT, which may be unnecessarily wide.
4607 * lisp.h (struct Lisp_Subr.function.aMANY)
4608 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4609 Arg counts are now ptrdiff_t, not size_t.
4610 All variadic functions and their callers changed accordingly.
4611 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4612 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4613 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4614 * callint.c (Fcall_interactively): Check arg count for overflow,
4615 to avoid potential buffer overrun. Use signed char, not 'int',
4616 for 'varies' array, so that we needn't bother to check its size
4617 calculation for overflow.
4618 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4619 * eval.c (apply_lambda):
4620 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4621 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4622 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4623
4624 * callint.c (Fcall_interactively): Don't use index var as event count.
4625
4626 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4627 * mem-limits.h (SIZE): Remove; no longer used.
4628
4629 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4630
4631 Remove unnecessary casts.
4632 * xterm.c (x_term_init):
4633 * xfns.c (x_set_border_pixel):
4634 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4635 These aren't needed now that we assume ANSI C.
4636
4637 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4638 It's more likely to cause problems (due to unsigned overflow)
4639 than to cure them.
4640
4641 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4642
4643 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4644
4645 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4646
4647 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4648
4649 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4650
4651 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4652
4653 GLYPH_CODE_FACE returns EMACS_INT, not int.
4654 * dispextern.h (merge_faces):
4655 * xfaces.c (merge_faces):
4656 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4657 Don't assume EMACS_INT fits in int.
4658
4659 * character.h (CHAR_VALID_P): Remove unused parameter.
4660 * fontset.c, lisp.h, xdisp.c: All uses changed.
4661
4662 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4663
4664 * fns.c (concat): Minor tuning based on overflow analysis.
4665 This doesn't fix any bugs. Use int to hold character, instead
4666 of constantly refetching from Emacs object. Use XFASTINT, not
4667 XINT, for value known to be a character. Don't bother comparing
4668 a single byte to 0400, as it's always less.
4669
4670 * floatfns.c (Fexpt):
4671 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4672
4673 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4674 for characters.
4675
4676 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4677
4678 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4679 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4680 incorrectly succeed when S was a string, because 4294967386 was
4681 truncated before it was used.
4682
4683 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4684 Otherwise, an out-of-range integer could cause undefined behavior
4685 on a 64-bit host.
4686
4687 * composite.c: Use int, not EMACS_INT, for characters.
4688 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4689 EMACS_INT, for values that are known to be in character range.
4690 This doesn't fix any bugs but is the usual style inside Emacs and
4691 may generate better code on 32-bit machines.
4692
4693 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4694 This is for reasons similar to the recent CHAR_STRING fix.
4695 * charset.c (Fencode_char): Check that character arg is actually
4696 a character. Pass an int to ENCODE_CHAR.
4697 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4698 wider than 'int', as a compile-time check to prevent future regressions
4699 in this area.
4700
4701 * character.c (char_string): Remove unnecessary casts.
4702
4703 Make sure a 64-bit char is never passed to CHAR_STRING.
4704 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4705 by silently ignoring the top 32 bits, allowing some values
4706 that were far too large to be valid characters.
4707 * character.h: Include <verify.h>.
4708 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4709 arguments are no wider than unsigned, as a compile-time check
4710 to prevent future regressions in this area.
4711 * data.c (Faset):
4712 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4713 (Fsubst_char_in_region):
4714 * fns.c (concat):
4715 * xdisp.c (decode_mode_spec_coding):
4716 Adjust to CHAR_STRING's new requirement.
4717 * editfns.c (Finsert_char, Fsubst_char_in_region):
4718 * fns.c (concat): Check that character args are actually
4719 characters. Without this test, these functions did the wrong
4720 thing with wildly out-of-range values on 64-bit hosts.
4721
4722 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4723 These casts should not be needed on 32-bit hosts, either.
4724 * keyboard.c (read_char):
4725 * lread.c (Fload): Remove casts to unsigned.
4726
4727 * lisp.h (UNSIGNED_CMP): New macro.
4728 This fixes comparison bugs on 64-bit hosts.
4729 (ASCII_CHAR_P): Use it.
4730 * casefiddle.c (casify_object):
4731 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4732 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4733 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4734 * dispextern.h (FACE_FROM_ID):
4735 * keyboard.c (read_char): Use UNSIGNED_CMP.
4736
4737 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4738 not to EMACS_INT, to avoid GCC warning.
4739
4740 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4741
4742 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4743 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4744 isn't needed on 32-bit machines.
4745
4746 * buffer.c (Fgenerate_new_buffer_name):
4747 Use EMACS_INT for count, not int.
4748 (advance_to_char_boundary): Return EMACS_INT, not int.
4749
4750 * data.c (Qcompiled_function): Now static.
4751
4752 * window.c (window_body_lines): Now static.
4753
4754 * image.c (gif_load): Rename local to avoid shadowing.
4755
4756 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4757 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4758 * alloc.c (make_save_value): Integer argument is now of type
4759 ptrdiff_t, not int.
4760 (mark_object): Use ptrdiff_t, not int.
4761 * lisp.h (pD): New macro.
4762 * print.c (print_object): Use it.
4763
4764 * alloc.c: Use EMACS_INT, not int, to count objects.
4765 (total_conses, total_markers, total_symbols, total_vector_size)
4766 (total_free_conses, total_free_markers, total_free_symbols)
4767 (total_free_floats, total_floats, total_free_intervals)
4768 (total_intervals, total_strings, total_free_strings):
4769 Now EMACS_INT, not int. All uses changed.
4770 (Fgarbage_collect): Compute overall total using a double, so that
4771 integer overflow is less likely to be a problem. Check for overflow
4772 when converting back to an integer.
4773 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4774 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4775 These were 'int' variables that could overflow on 64-bit hosts;
4776 they were never used, so remove them instead of repairing them.
4777 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4778 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4779 Previously, this ceilinged at INT_MAX, but that doesn't work on
4780 64-bit machines.
4781 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4782
4783 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4784 (allocate_vectorlike): Check for ptrdiff_t overflow.
4785 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4786 when a (possibly-narrower) signed value would do just as well.
4787 We prefer using signed arithmetic, to avoid comparison confusion.
4788
4789 * alloc.c: Catch some string size overflows that we were missing.
4790 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4791 for convenience in STRING_BYTES_MAX.
4792 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4793 The definition here is exact; the one in lisp.h was approximate.
4794 (allocate_string_data): Check for string overflow. This catches
4795 some instances we weren't catching before. Also, it catches
4796 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4797 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4798 and ptrdiff_t and EMACS_INT are both 64 bits.
4799
4800 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4801 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4802 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4803
4804 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4805
4806 * alloc.c (Fmake_string): Check for out-of-range init.
4807
4808 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4809
4810 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4811
4812 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4813
4814 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4815 xg_get_default_scrollbar_width.
4816
4817 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4818 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4819 (style_changed_cb): Call update_theme_scrollbar_width and call
4820 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4821 all frames (Bug#8505).
4822 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4823 Call gtk_window_set_resizable if HAVE_GTK3.
4824 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4825 and height if HAVE_GTK3 (Bug#8505).
4826 (scroll_bar_width_for_theme): New variable.
4827 (update_theme_scrollbar_width): New function.
4828 (xg_get_default_scrollbar_width): Move code to
4829 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4830 (xg_initialize): Call update_theme_scrollbar_width.
4831
4832 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4833
4834 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4835
4836 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4837
4838 * frame.c (make_frame): Call other_buffer_safely instead of
4839 other_buffer.
4840
4841 * window.c (temp_output_buffer_show): Call display_buffer with
4842 second argument Vtemp_buffer_show_specifiers and reset latter
4843 immediately after the call.
4844 (Vtemp_buffer_show_specifiers): New variable.
4845 (auto_window_vscroll_p, next_screen_context_lines)
4846 (Vscroll_preserve_screen_position): Remove leading asterisks from
4847 doc-strings.
4848
4849 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4850
4851 Fix minor problems found by GCC 4.6.0 static checking.
4852 * buffer.c (Qclone_number): Remove for now, as it's unused.
4853 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4854 (record_buffer): Remove unused local.
4855 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4856 (set_frame_buffer_list): Remove; unused.
4857 * frame.h (other_visible_frames): Remove decl.
4858 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4859 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4860 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4861 if HAVE_GPM.
4862 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4863 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4864 Define only if HAVE_GPM.
4865 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4866 (update_hints_inhibit): Remove; never set. All uses removed.
4867 * widgetprv.h (emacsFrameClassRec): Remove decl.
4868 * window.c (delete_deletable_window): Now returns void, since it
4869 wasn't returning anything.
4870 (compare_window_configurations): Remove unused locals.
4871 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4872 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4873 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4874 the same widths as pointers. This follows up on the 2011-05-06 patch.
4875 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4876 * xterm.h: Likewise.
4877 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4878
4879 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4880
4881 * makefile.w32-in: Update dependencies.
4882 (LISP_H): Add lib/intprops.h.
4883
4884 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4885
4886 * image.c (gif_load): Add animation frame delay to the metadata.
4887 (syms_of_image): Use DEFSYM. New symbol `delay'.
4888
4889 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4890
4891 * window.c (delete_deletable_window): Re-add.
4892 (Fset_window_configuration): Rewrite to handle dead buffers and
4893 consequently deletable windows.
4894 (window_tree, Fwindow_tree): Remove. Supply functionality in
4895 window.el.
4896 (compare_window_configurations): Simplify code.
4897
4898 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4899
4900 * image.c (imagemagick_load_image): Fix type mismatch.
4901 (Fimagemagick_types): Likewise.
4902
4903 * window.h (replace_buffer_in_windows): Declare.
4904
4905 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4906
4907 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4908 Qclone_number. Remove external declaration of Qdelete_window.
4909 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4910 code.
4911 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4912 Run Qbuffer_list_update_hook if allowed.
4913 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4914 buffer list implementation.
4915 (other_buffer_safely): New function.
4916 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4917 calls to replace_buffer_in_windows and
4918 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4919 if allowed.
4920 (record_buffer): Inhibit quitting and rewrite using quittable
4921 functions. Run Qbuffer_list_update_hook if allowed.
4922 (Frecord_buffer, Funrecord_buffer): New functions.
4923 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4924 Move switch-to-buffer to window.el.
4925 (bury-buffer): Move to window.el.
4926 (Vbuffer_list_update_hook): New variable.
4927
4928 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4929 section.
4930
4931 * window.h (resize_frame_windows): Move up in code.
4932 (Fwindow_frame): Remove EXFUN.
4933 (replace_buffer_in_all_windows): Remove prototype.
4934 (replace_buffer_in_windows_safely): Add prototype.
4935
4936 * window.c: Declare Qdelete_window static again. Move down
4937 declaration of select_count.
4938 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4939 (Fother_window): Move to window.el.
4940 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4941 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4942 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4943 window.el.
4944 (replace_buffer_in_windows): Implement by calling
4945 Qreplace_buffer_in_windows.
4946 (replace_buffer_in_all_windows): Remove with some functionality
4947 moved into replace_buffer_in_windows_safely.
4948 (replace_buffer_in_windows_safely): New function.
4949 (select_window_norecord, select_frame_norecord): Move in front
4950 of run_window_configuration_change_hook. Remove now obsolete
4951 declarations.
4952 (Fset_window_buffer): Rewrite doc-string.
4953 Call Qrecord_window_buffer.
4954 (keys_of_window): Move binding for other-window to window.el.
4955
4956 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4957
4958 * dispextern.h (struct image): Replace data member, whose int_val
4959 and ptr_val fields were not used by anything, with a single
4960 lisp_val object.
4961
4962 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4963 (gif_clear_image, gif_load, imagemagick_load_image)
4964 (gs_clear_image, gs_load): Callers changed.
4965
4966 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * buffer.h: Include <time.h>, for time_t.
4969 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4970
4971 Fix minor problems found by static checking.
4972
4973 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4974
4975 Make identifiers static if they are not used in other modules.
4976 * data.c (Qcompiled_function, Qframe, Qvector):
4977 * image.c (QimageMagick, Qsvg):
4978 * minibuf.c (Qmetadata):
4979 * window.c (resize_window_check, resize_root_window): Now static.
4980 * window.h (resize_window_check, resize_root_window): Remove decls.
4981
4982 * window.c (window_deletion_count, delete_deletable_window):
4983 Remove; unused.
4984 (window_body_lines): Now static.
4985 (Fdelete_other_windows_internal): Mark vars as initialized.
4986 Make sure 'resize_failed' is initialized.
4987 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4988 (resize_window_apply): Remove unused local.
4989 * window.h (delete_deletable_window): Remove decl.
4990
4991 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4992 (imagemagick_load_image): Fix pointer signedness problem by changing
4993 last arg from unsigned char * to char *. All uses changed.
4994 Also, fix a local for similar reasons.
4995 Remove unused locals. Remove locals to avoid shadowing.
4996 (fn_rsvg_handle_free): Remove; unused.
4997 (svg_load, svg_load_image): Fix pointer signedness problem.
4998 (imagemagick_load_image): Don't use garbage pointer image_wand.
4999
5000 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5001
5002 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5003
5004 * image.c (gif_load): Fix omitted cast error introduced by
5005 2011-06-06 change.
5006
5007 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5008
5009 * window.h (resize_proportionally, orig_total_lines)
5010 (orig_top_line): Remove from window structure.
5011 (set_window_height, set_window_width, change_window_heights)
5012 (Fdelete_window): Remove prototypes.
5013 (resize_frame_windows): Remove duplicate declaration.
5014
5015 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5016
5017 * window.h (resize_frame_windows, resize_window_check)
5018 (delete_deletable_window, resize_root_window)
5019 (resize_frame_windows): Declare prototypes.
5020
5021 * window.c (resize_window_apply): Make definition be "static" to
5022 match the prototype.
5023
5024 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5025
5026 * window.c: Remove declarations of Qwindow_size_fixed,
5027 window_min_size_1, window_min_size_2, window_min_size,
5028 size_window, window_fixed_size_p, enlarge_window, delete_window.
5029 Remove static from declaration of Qdelete_window, it's
5030 temporarily needed by Fbury_buffer.
5031 (replace_window): Don't assign orig_top_line and
5032 orig_total_lines.
5033 (Fdelete_window, delete_window): Remove. Window deletion is
5034 handled by window.el.
5035 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5036 Replace Fdelete_window calls with calls to Qdelete_window.
5037 (Fdelete_other_windows): Remove. Deleting other windows is
5038 handled by window.el.
5039 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5040 handled in window.el.
5041 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5042 Window minimum sizes are handled in window.el.
5043 (shrink_windows, size_window, set_window_height)
5044 (set_window_width, change_window_heights, window_height)
5045 (window_width, CURBEG, CURSIZE, enlarge_window)
5046 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5047 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5048 handled in window.el.
5049 (make_dummy_parent): Rename to make_parent_window and give it a
5050 second argument horflag.
5051 (make_window): Don't set resize_proportionally any more.
5052 (Fsplit_window): Remove. Windows are split in window.el.
5053 (save_restore_action, save_restore_orig_size)
5054 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5055 Resize mini windows in window.el.
5056 (grow_mini_window, shrink_mini_window): Implement by calling
5057 Qresize_root_window_vertically, resize_window_check and
5058 resize_window_apply.
5059 (saved_window, Fset_window_configuration, save_window_save):
5060 Do not handle orig_top_line, orig_total_lines, and
5061 resize_proportionally.
5062 (window_min_height, window_min_width): Move to window.el.
5063 (keys_of_window): Move bindings for delete-other-windows,
5064 split-window, delete-window and enlarge-window to window.el.
5065
5066 * buffer.c: Temporarily extern Qdelete_window.
5067 (Fbury_buffer): Temporarily call Qdelete_window instead of
5068 Fdelete_window (Fbury_buffer will move to window.el soon).
5069
5070 * frame.c (set_menu_bar_lines_1): Remove code handling
5071 orig_top_line and orig_total_lines.
5072
5073 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5074 set_window_height but set heights directly.
5075 (change_frame_size_1): Use resize_frame_windows.
5076
5077 * xdisp.c (init_xdisp): Don't use set_window_height but set
5078 heights directly.
5079
5080 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5081 Use resize_frame_windows instead of change_window_heights and run
5082 run_window_configuration_change_hook.
5083
5084 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5085 instead of change_window_heights and run
5086 run_window_configuration_change_hook.
5087
5088 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5089
5090 * window.c (replace_window): Rename second argument REPLACEMENT to
5091 NEW. New third argument SETFLAG. Rewrite.
5092 (delete_window, make_dummy_parent): Call replace_window with
5093 third argument 1.
5094 (window_list_1): Move down in code.
5095 (run_window_configuration_change_hook): Move set_buffer part
5096 before select_frame_norecord part in order to unwind correctly.
5097 Rename count1 to count.
5098 (recombine_windows, delete_deletable_window, resize_root_window)
5099 (Fdelete_other_windows_internal)
5100 (Frun_window_configuration_change_hook, make_parent_window)
5101 (resize_window_check, resize_window_apply, Fresize_window_apply)
5102 (resize_frame_windows, Fsplit_window_internal)
5103 (Fdelete_window_internal, Fresize_mini_window_internal):
5104 New functions.
5105 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5106
5107 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5108
5109 * window.h (window): Add some new members to window structure -
5110 normal_lines, normal_cols, new_total, new_normal, clone_number,
5111 splits, nest, prev_buffers, next_buffers.
5112 (WINDOW_TOTAL_SIZE): Move here from window.c.
5113 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5114
5115 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5116 Remove.
5117 (make_dummy_parent): Set new members of windows structure.
5118 (make_window): Move down in code. Handle new members of window
5119 structure.
5120 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5121 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5122 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5123 (Fset_window_prev_buffers, Fwindow_next_buffers)
5124 (Fset_window_next_buffers, Fset_window_clone_number):
5125 New functions.
5126 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5127 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5128 Doc-string fixes.
5129 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5130 Argument WINDOW can be now internal window too.
5131 (Fwindow_use_time): Move up in code.
5132 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5133 Rewrite doc-string.
5134 (Fset_window_configuration, saved_window)
5135 (Fcurrent_window_configuration, save_window_save): Handle new
5136 members of window structure.
5137 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5138 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5139 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5140 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5141 Qget_mru_window, Qresize_root_window,
5142 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5143 Qauto_buffer_name; staticpro them.
5144
5145 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5146
5147 * window.c (Fwindow_total_size, Fwindow_left_column)
5148 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5149 (Fwindow_list_1): New functions.
5150 (window_box_text_cols): Replace with window_body_cols.
5151 (Fwindow_width, Fscroll_left, Fscroll_right):
5152 Use window_body_cols instead of window_box_text_cols.
5153 (delete_window, Fset_window_configuration):
5154 Call delete_all_subwindows with window as argument.
5155 (delete_all_subwindows): Take a window as argument and not a
5156 structure. Rewrite.
5157 (window_loop): Remove handling of GET_LRU_WINDOW and
5158 GET_LARGEST_WINDOW.
5159 (Fget_lru_window, Fget_largest_window): Move to window.el.
5160
5161 * window.h: Extern window_body_cols instead of
5162 window_box_text_cols. delete_all_subwindows now takes a
5163 Lisp_Object as argument.
5164
5165 * indent.c (compute_motion, Fcompute_motion):
5166 Use window_body_cols instead of window_box_text_cols.
5167
5168 * frame.c (delete_frame): Call delete_all_subwindows with root
5169 window as argument.
5170
5171 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5172
5173 * fns.c (Fputhash): Document return value.
5174
5175 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5176
5177 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5178
5179 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5180
5181 Cons<->int and similar integer overflow fixes (Bug#8794).
5182
5183 Check for overflow when converting integer to cons and back.
5184 * charset.c (Fdefine_charset_internal, Fdecode_char):
5185 Use cons_to_unsigned to catch overflow.
5186 (Fencode_char): Use INTEGER_TO_CONS.
5187 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5188 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5189 * data.c (long_to_cons, cons_to_long): Remove.
5190 (cons_to_unsigned, cons_to_signed): New functions.
5191 These signal an error for invalid or out-of-range values.
5192 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5193 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5194 * font.c (Ffont_variation_glyphs):
5195 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5196 * lisp.h: Include <intprops.h>.
5197 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5198 (cons_to_signed, cons_to_unsigned): New decls.
5199 (long_to_cons, cons_to_long): Remove decls.
5200 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5201 (Fprimitive_undo): Use CONS_TO_INTEGER.
5202 * xfns.c (Fx_window_property): Likewise.
5203 * xselect.c: Include <limits.h>.
5204 (x_own_selection, selection_data_to_lisp_data):
5205 Use INTEGER_TO_CONS.
5206 (x_handle_selection_request, x_handle_selection_clear)
5207 (x_get_foreign_selection, Fx_disown_selection_internal)
5208 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5209 (lisp_data_to_selection_data): Use cons_to_unsigned.
5210 (x_fill_property_data): Use cons_to_signed.
5211 Report values out of range.
5212
5213 Check for buffer and string overflow more precisely.
5214 * buffer.h (BUF_BYTES_MAX): New macro.
5215 * lisp.h (STRING_BYTES_MAX): New macro.
5216 * alloc.c (Fmake_string):
5217 * character.c (string_escape_byte8):
5218 * coding.c (coding_alloc_by_realloc):
5219 * doprnt.c (doprnt):
5220 * editfns.c (Fformat):
5221 * eval.c (verror):
5222 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5223 since they may not be the same number.
5224 * editfns.c (Finsert_char):
5225 * fileio.c (Finsert_file_contents):
5226 Likewise for BUF_BYTES_MAX.
5227
5228 * image.c: Use ptrdiff_t, not int, for sizes.
5229 (slurp_file): Switch from int to ptrdiff_t.
5230 All uses changed.
5231 (slurp_file): Check that file size fits in both size_t (for
5232 malloc) and ptrdiff_t (for sanity and safety).
5233
5234 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5235 if b->modtime has its maximal value.
5236
5237 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5238
5239 Don't assume time_t can fit into int.
5240 * buffer.h (struct buffer.modtime): Now time_t, not int.
5241 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5242 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5243
5244 Minor fixes for signed vs unsigned integers.
5245 * character.h (MAYBE_UNIFY_CHAR):
5246 * charset.c (maybe_unify_char):
5247 * keyboard.c (read_char, reorder_modifiers):
5248 XINT -> XFASTINT, since the integer must be nonnegative.
5249 * ftfont.c (ftfont_spec_pattern):
5250 * keymap.c (access_keymap, silly_event_symbol_error):
5251 XUINT -> XFASTINT, since the integer must be nonnegative.
5252 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5253 since it makes no difference and we prefer signed.
5254 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5255 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5256 nonnegative.
5257
5258 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5259
5260 * window.h (Fwindow_frame): Declare.
5261
5262 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5263
5264 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5265 (SPARE_MEMORY): Always define.
5266 (LARGE_REQUEST): Remove.
5267 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5268
5269 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5270
5271 * lisp.h: Move EXFUNS for Fframe_root_window,
5272 Fframe_first_window and Fset_frame_selected_window to window.h.
5273
5274 * window.h: Move EXFUNS for Fframe_root_window,
5275 Fframe_first_window and Fset_frame_selected_window here from
5276 lisp.h.
5277
5278 * frame.c (Fwindow_frame, Fframe_first_window)
5279 (Fframe_root_window, Fframe_selected_window)
5280 (Fset_frame_selected_window): Move to window.c.
5281 (Factive_minibuffer_window): Move to minibuf.c.
5282 (Fother_visible_frames_p): New function.
5283
5284 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5285
5286 * window.c (decode_window, decode_any_window): Move up in code.
5287 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5288 (inhibit_frame_unsplittable): Remove unused variable.
5289 (Fwindow_buffer): Move up and rewrite doc-string.
5290 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5291 (Fwindow_prev): New functions.
5292 (Fwindow_frame): Move here from frame.c. Accept any window as
5293 argument.
5294 (Fframe_root_window, Fframe_first_window)
5295 (Fframe_selected_window): Move here from frame.c. Accept frame
5296 or arbitrary window as argument. Update doc-strings.
5297 (Fminibuffer_window): Move up in code.
5298 (Fwindow_minibuffer_p): Move up in code and simplify.
5299 (Fset_frame_selected_window): Move here from frame.c.
5300 Marginal rewrite.
5301 (Fselected_window, select_window, Fselect_window): Move up in
5302 code. Minor doc-string fixes.
5303
5304 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5305
5306 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5307 Do not assume that spare memory exists; that assumption is valid
5308 only if SYSTEM_MALLOC.
5309 (LARGE_REQUEST): New macro, so that the issue of large requests
5310 is separated from the issue of spare memory.
5311
5312 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5313
5314 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5315 format. (Bug#8806)
5316
5317 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5318
5319 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5320 before statements.
5321
5322 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5323
5324 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5325
5326 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5327
5328 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5329 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5330
5331 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5332
5333 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5334
5335 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5336
5337 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5338 (x_clipboard_manager_save): Add return value.
5339 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5340 New error handlers.
5341 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5342 Obey Vx_select_enable_clipboard_manager. Catch errors in
5343 x_clipboard_manager_save (Bug#8779).
5344 (Vx_select_enable_clipboard_manager): New variable.
5345 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5346
5347 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5348
5349 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5350
5351 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5352
5353 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5354 in the current matrix if keep_current_p is non-zero.
5355
5356 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5357
5358 * bidi.c (bidi_level_of_next_char): Fix last change.
5359
5360 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5361
5362 Support bidi reordering of text covered by display properties.
5363
5364 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5365 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5366 (bidi_cache_search, bidi_cache_iterator_state)
5367 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5368 (bidi_level_of_next_char, bidi_move_to_visually_next):
5369 Support character positions inside a run of characters covered by a
5370 display string.
5371 (bidi_paragraph_init, bidi_resolve_explicit_1)
5372 (bidi_level_of_next_char): Call bidi_fetch_char and
5373 bidi_fetch_char_advance instead of FETCH_CHAR and
5374 FETCH_CHAR_ADVANCE.
5375 (bidi_init_it): Initialize new members.
5376 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5377 definitions.
5378 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5379 instead of using explicit *_CHAR codes.
5380 (bidi_resolve_explicit, bidi_resolve_weak):
5381 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5382 bidirectional text is supported only in multibyte buffers.
5383 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5384 it to initialize the frame_window_p member of struct bidi_it.
5385 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5386 (bidi_resolve_explicit, bidi_resolve_weak)
5387 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5388 bidi_it->nchars is non-positive.
5389 (bidi_level_of_next_char): Don't try to lookup the cache for the
5390 next/previous character if nothing is cached there yet, or if we
5391 were just reseat()'ed to a new position.
5392
5393 * xdisp.c (set_cursor_from_row): Set start and stop points
5394 according to the row's direction when priming the loop that looks
5395 for the glyph on which to display cursor.
5396 (single_display_spec_intangible_p): Function deleted.
5397 (display_prop_intangible_p): Reimplement to call
5398 handle_display_spec instead of single_display_spec_intangible_p.
5399 Accept 3 additional arguments needed by handle_display_spec.
5400 This fixes incorrect cursor motion across display property with complex
5401 values: lists, `(when COND...)' forms, etc.
5402 (single_display_spec_string_p): Support property values that are
5403 lists with the argument STRING its top-level element.
5404 (display_prop_string_p): Fix the condition for processing a
5405 property that is a list to be consistent with handle_display_spec.
5406 (handle_display_spec): New function, refactored from the
5407 last portion of handle_display_prop.
5408 (compute_display_string_pos): Accept additional argument
5409 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5410 value of a `display' property is a "replacing spec".
5411 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5412 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5413 the display property, but just return a value indicating whether
5414 the display property will replace the characters it covers.
5415 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5416 frame_window_p members of struct bidi_it.
5417 (compute_display_string_pos, compute_display_string_end):
5418 New functions.
5419 (push_it): Accept second argument POSITION, where pop_it should
5420 jump to continue iteration.
5421 (reseat_1): Initialize bidi_it.disp_pos.
5422
5423 * keyboard.c (adjust_point_for_property): Adjust the call to
5424 display_prop_intangible_p to its new signature.
5425
5426 * dispextern.h (struct bidi_it): New member frame_window_p.
5427 (bidi_init_it): Update prototypes.
5428 (display_prop_intangible_p): Update prototype.
5429 (compute_display_string_pos, compute_display_string_end):
5430 Declare prototypes.
5431 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5432 EMACS_INT.
5433
5434 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5435
5436 Malloc failure behavior now depends on size of allocation.
5437 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5438 * lisp.h: Change signatures accordingly.
5439 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5440 All callers changed. (Bug#8762)
5441
5442 * gnutls.c: Use Emacs's memory allocators.
5443 Without this change, the gnutls library would invoke malloc etc.
5444 directly, which causes problems on non-SYNC_INPUT hosts, and which
5445 runs afoul of improving memory_full behavior. (Bug#8761)
5446 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5447 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5448 xfree instead of the default malloc, realloc, free.
5449 (Fgnutls_boot): No need to check for memory allocation failure,
5450 since xmalloc does that for us.
5451
5452 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5453 * category.c (hash_get_category_set):
5454 * ccl.c (ccl_driver):
5455 * charset.c (Fdefine_charset_internal):
5456 * charset.h (struct charset.hash_index):
5457 * composite.c (get_composition_id, gstring_lookup_cache)
5458 (composition_gstring_put_cache):
5459 * composite.h (struct composition.hash_index):
5460 * dispextern.h (struct image.hash):
5461 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5462 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5463 (hashfn_equal, hashfn_user_defined, make_hash_table)
5464 (maybe_resize_hash_table, hash_lookup, hash_put)
5465 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5466 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5467 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5468 * image.c (make_image, search_image_cache, lookup_image)
5469 (xpm_put_color_table_h):
5470 * lisp.h (struct Lisp_Hash_Table):
5471 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5472 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5473 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5474 * alloc.c (allocate_vectorlike):
5475 Check for overflow in vector size calculations.
5476 * ccl.c (ccl_driver):
5477 Check for overflow when converting EMACS_INT to int.
5478 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5479 need to be updated by these changes.
5480 * fns.c (make_hash_table, maybe_resize_hash_table):
5481 Check for integer overflow with large hash tables.
5482 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5483 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5484 (SXHASH_REDUCE): New macro.
5485 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5486 Use it instead of discarding useful hash info with large hash values.
5487 (sxhash_float): New function.
5488 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5489 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5490 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5491 Rewrite to use FIXNUM_BITS, as this simplifies things.
5492 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5493 Adjust signatures to match updated version of code.
5494 (consing_since_gc): Now EMACS_INT, since a single hash table can
5495 use more than INT_MAX bytes.
5496
5497 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5498
5499 Make it possible to build with GCC-4.6+ -O2 -flto.
5500
5501 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5502
5503 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5504
5505 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5506 Call minibuffer-inactive-mode.
5507
5508 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5509
5510 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5511 Update dependencies.
5512
5513 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5514
5515 * data.c (init_data): Remove code for UTS, this system is not
5516 supported anymore.
5517
5518 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5519
5520 Don't force ./temacs to start in terminal mode.
5521
5522 * frame.c (make_initial_frame): Initialize faces in all cases, not
5523 only when CANNOT_DUMP is defined.
5524 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5525
5526 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5527
5528 * dispnew.c (add_window_display_history): Use const for the string
5529 pointer. Remove declaration, not needed.
5530
5531 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 Use 'inline', not 'INLINE'.
5534 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5535 * alloc.c, fontset.c (INLINE): Remove.
5536 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5537 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5538 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5539 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5540 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5541
5542 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5543
5544 Make it possible to run ./temacs.
5545
5546 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5547 syms_of_callproc does the same thing. Remove test for
5548 "initialized", do it in the caller.
5549 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5550
5551 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5552
5553 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5554 (read_minibuf): Use get_minibuffer.
5555 (syms_of_minibuf): Use DEFSYM.
5556 (Qmetadata): New var.
5557 * data.c (Qbuffer): Don't make it static.
5558 (syms_of_data): Use DEFSYM.
5559
5560 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5561
5562 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5563 (CCL_CODE_MIN): New macro.
5564
5565 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5568
5569 * eval.c (Qdebug): Now static.
5570 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5571 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5572 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5573
5574 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5575
5576 * image.c: Various fixes to ImageMagick code comments.
5577 (Fimagemagick_types): Doc fix.
5578
5579 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5580
5581 Minor fixes prompted by GCC 4.6.0 warnings.
5582
5583 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5584
5585 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5586 (x_clipboard_manager_save_all): Move extern decl to ...
5587 * xterm.h: ... here, so that it can be checked for consistency.
5588
5589 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5590
5591 * xselect.c (x_clipboard_manager_save_frame)
5592 (x_clipboard_manager_save_all): New functions.
5593 (Fx_clipboard_manager_save): Lisp function deleted.
5594
5595 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5596 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5597
5598 * xterm.h: Update prototype.
5599
5600 2011-05-28 William Xu <william.xwl@gmail.com>
5601
5602 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5603 exiting (Bug#8239).
5604
5605 2011-05-28 Jim Meyering <meyering@redhat.com>
5606
5607 Avoid a sign-extension bug in crypto_hash_function.
5608 * fns.c (to_uchar): Define.
5609 (crypto_hash_function): Use it to convert some newly-signed
5610 variables to unsigned, to avoid sign-extension bugs. For example,
5611 without this change, (md5 "truc") would evaluate to
5612 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5613 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5614 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5615
5616 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5617
5618 Integer overflow fixes.
5619
5620 * dbusbind.c: Serial number integer overflow fixes.
5621 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5622 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5623 to hold a serial number that is too large for a fixnum.
5624 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5625 Check for serial numbers out of range. Decode any serial number
5626 that was so large that it became a float. (Bug#8722)
5627
5628 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5629 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5630 Use XFASTINT rather than XUINT when numbers are nonnegative.
5631 (xd_append_arg, Fdbus_method_return_internal):
5632 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5633 arguments, check that Lisp number is nonnegative, rather than
5634 silently wrapping negative numbers around. (Bug#8722)
5635 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5636 (Bug#8722)
5637
5638 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5639
5640 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5641
5642 ccl: add integer overflow checks
5643 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5644 (IN_INT_RANGE): New macros.
5645 (ccl_driver): Use them to check for integer overflow when
5646 decoding a CCL program. Many of the new checks are whether XINT (x)
5647 fits in int; it doesn't always, on 64-bit hosts. The new version
5648 doesn't catch all possible integer overflows, but it's an
5649 improvement. (Bug#8719)
5650
5651 * alloc.c (make_event_array): Use XINT, not XUINT.
5652 There's no need for unsigned here.
5653
5654 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5655 This follows up to the 2011-05-06 change that substituted uintptr_t
5656 for EMACS_INT. This case wasn't caught back then.
5657
5658 Rework Fformat to avoid integer overflow issues.
5659 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5660 now (part of C89). Include <verify.h>.
5661 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5662 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5663 (Fformat): Avoid the prepass trying to compute sizes; it was only
5664 approximate and thus did not catch overflow reliably. Instead, walk
5665 through the format just once, formatting and computing sizes as we go,
5666 checking for integer overflow at every step, and allocating a larger
5667 buffer as needed. Keep track separately whether the format is
5668 multibyte. Keep only the most-recently calculated precision, rather
5669 than them all. Record whether each argument has been converted to
5670 string. Use EMACS_INT, not int, for byte and char and arg counts.
5671 Support field widths and precisions larger than INT_MAX. Avoid
5672 sprintf's undefined behavior with conversion specifications such as %#d
5673 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5674 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5675 formatting out-of-range floating point numbers with int
5676 formats. (Bug#8668)
5677
5678 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5679
5680 * data.c: Avoid integer truncation in expressions involving floats.
5681 * data.c: Include <intprops.h>.
5682 (arith_driver): When there's an integer overflow in an expression
5683 involving floating point, convert the integers to floating point
5684 so that the resulting value does not suffer from catastrophic
5685 integer truncation. For example, on a 64-bit host (* 4
5686 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5687 Do not rely on undefined behavior after integer overflow.
5688
5689 merge count_size_as_multibyte, parse_str_to_multibyte
5690 * character.c, character.h (count_size_as_multibyte):
5691 Rename from parse_str_to_multibyte; all uses changed.
5692 Check for integer overflow.
5693 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5694 since it's now a duplicate of the other. This is more of
5695 a character than a buffer op, so better that it's in character.c.
5696 * fns.c, print.c: Adjust to above changes.
5697
5698 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5699
5700 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5701
5702 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5705 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5706 (x_clipboard_manager_save): Now static.
5707 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5708
5709 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5710 (crypto_hash_function): Now static.
5711 Fix pointer signedness problems. Avoid unnecessary initializations.
5712
5713 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5714
5715 * termhooks.h (Vselection_alist): Make it terminal-local.
5716
5717 * terminal.c (create_terminal): Initialize it.
5718
5719 * xselect.c: Support for clipboard managers.
5720 (Vselection_alist): Move to termhooks.h as terminal-local var.
5721 (LOCAL_SELECTION): New macro.
5722 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5723 (symbol_to_x_atom): Remove gratuitous arg.
5724 (x_handle_selection_request, lisp_data_to_selection_data)
5725 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5726 (x_own_selection, x_get_local_selection, x_convert_selection):
5727 New arg, specifying work frame. Use terminal-local Vselection_alist.
5728 (some_frame_on_display): Delete unused function.
5729 (Fx_own_selection_internal, Fx_get_selection_internal)
5730 (Fx_disown_selection_internal, Fx_selection_owner_p)
5731 (Fx_selection_exists_p): New optional frame arg.
5732 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5733 (x_handle_selection_clear): Don't treat other terminals with the
5734 same keyboard specially. Use the terminal-local Vselection_alist.
5735 (x_clear_frame_selections): Use Frun_hook_with_args.
5736
5737 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5738
5739 * xterm.h: Add support for those atoms.
5740
5741 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5742
5743 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5744 (converted_selections, conversion_fail_tag): New global variables.
5745 (x_selection_request_lisp_error): Free the above.
5746 (x_get_local_selection): Remove unnecessary code.
5747 (x_reply_selection_request): Args changed; handle arbitrary array
5748 of converted selections stored in converted_selections.
5749 Separate the XChangeProperty and SelectionNotify steps.
5750 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5751 (x_convert_selection): New function.
5752 (x_handle_selection_event): Simplify.
5753 (x_get_foreign_selection): Don't ignore incoming requests while
5754 waiting for an answer; this will fail when we implement
5755 SAVE_TARGETS, and seems unnecessary anyway.
5756 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5757 (Vx_sent_selection_functions): Doc fix.
5758
5759 2011-05-26 Leo Liu <sdl.web@gmail.com>
5760
5761 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5762
5763 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5764
5765 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5766
5767 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5768 for fringe update if it has periodic bitmap.
5769 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5770 and fringe_bitmap_periodic_p.
5771
5772 * fringe.c (get_fringe_bitmap_data): New function.
5773 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5774 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5775 row. Mark glyph row for fringe update if periodicity changed.
5776
5777 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5778 for fringe update unless it has periodic bitmap.
5779
5780 2011-05-25 Kenichi Handa <handa@m17n.org>
5781
5782 * xdisp.c (get_next_display_element): Set correct it->face_id for
5783 a static composition.
5784
5785 2011-05-24 Leo Liu <sdl.web@gmail.com>
5786
5787 * deps.mk (fns.o):
5788 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5789
5790 * fns.c (crypto_hash_function, Fsha1): New function.
5791 (Fmd5): Use crypto_hash_function.
5792 (syms_of_fns): Add Ssha1.
5793
5794 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5795
5796 * gnutls.c: Remove unused macros.
5797 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5798 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5799 Remove macros that are defined and never used.
5800 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5801
5802 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5803
5804 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5805 (Fx_get_selection_internal): Minor cleanup.
5806 (Fx_own_selection_internal): Rename arguments for consistency with
5807 select.el.
5808
5809 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5810
5811 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5812
5813 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5814
5815 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5816
5817 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5818
5819 * dispnew.c (scrolling_window): Don't exclude the case that the
5820 last enabled row in the desired matrix touches the bottom boundary.
5821
5822 2011-05-21 Glenn Morris <rgm@gnu.org>
5823
5824 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5825 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5826 and add some more files.
5827
5828 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5829
5830 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5831 report_file_error introduced by the change from 2011-05-07.
5832
5833 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 * systime.h (Time): Define only if emacs is defined.
5836 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5837 where the include path doesn't have X11/X.h by default. See
5838 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5839
5840 2011-05-20 Kenichi Handa <handa@m17n.org>
5841
5842 * composite.c (find_automatic_composition): Fix previous change.
5843
5844 2011-05-20 Glenn Morris <rgm@gnu.org>
5845
5846 * lisp.mk: New file, split from Makefile.in.
5847 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5848 (shortlisp): Remove.
5849 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5850
5851 2011-05-19 Glenn Morris <rgm@gnu.org>
5852
5853 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5854 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5855 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5856 (lisp): Set the order to that of loadup.el.
5857 (shortlisp): Make it a copy of $lisp.
5858 (SOME_MACHINE_LISP): Remove.
5859 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5860 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5861
5862 2011-05-18 Kenichi Handa <handa@m17n.org>
5863
5864 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5865 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5866 (find_automatic_composition): Mostly rewrite for efficiency.
5867
5868 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5869
5870 * makefile.w32-in: Update dependencies.
5871
5872 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5873
5874 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5875 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5876
5877 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 Fix some integer overflow issues, such as string length overflow.
5880
5881 * insdel.c (count_size_as_multibyte): Check for string overflow.
5882
5883 * character.c (lisp_string_width): Check for string overflow.
5884 Use EMACS_INT, not int, for string indexes and lengths; in
5885 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5886 the resulting string length overflows an EMACS_INT; instead,
5887 report a string overflow if no precision given. When checking for
5888 precision exhaustion, use a check that cannot possibly have
5889 integer overflow. (Bug#8675)
5890 * character.h (lisp_string_width): Adjust to new signature.
5891
5892 * alloc.c (string_overflow): New function.
5893 (Fmake_string): Use it. This doesn't change behavior, but saves
5894 a few bytes and will simplify future changes.
5895 * character.c (string_escape_byte8): Likewise.
5896 * lisp.h (string_overflow): New decl.
5897
5898 Fixups, following up to the user-interface timestamp change.
5899 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5900 for UI timestamps, instead of unsigned long.
5901 * msdos.c (mouse_get_pos): Likewise.
5902 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5903 * w32gui.h (Time): Define by including "systime.h" rather than by
5904 declaring it ourselves. (Bug#8664)
5905
5906 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5907 * image.c (clear_image_cache): Likewise.
5908
5909 * term.c (term_mouse_position): Don't assume time_t wraparound.
5910
5911 Be more systematic about user-interface timestamps.
5912 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5913 and sometimes 'EMACS_UINT', to represent these timestamps.
5914 This change causes it to use 'Time' uniformly, as that's what X uses.
5915 This makes the code easier to follow, and makes it easier to catch
5916 integer overflow bugs such as Bug#8664.
5917 * frame.c (Fmouse_position, Fmouse_pixel_position):
5918 Use Time, not unsigned long, for user-interface timestamps.
5919 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5920 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5921 * keyboard.h (last_event_timestamp): Likewise.
5922 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5923 * menu.h (xmenu_show): Likewise.
5924 * term.c (term_mouse_position): Likewise.
5925 * termhooks.h (struct input_event.timestamp): Likewise.
5926 (struct terminal.mouse_position_hook): Likewise.
5927 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5928 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5929 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5930 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5931 what it was before.
5932 * menu.h, termhooks.h: Include "systime.h", for Time.
5933
5934 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5935 Don't assume that the difference between two unsigned long values
5936 can fit into an integer. At this point, we know button_down_time
5937 <= event->timestamp, so the difference must be nonnegative, so
5938 there's no need to cast the result if double-click-time is
5939 nonnegative, as it should be; check that it's nonnegative, just in
5940 case. This bug is triggered when events are more than 2**31 ms
5941 apart (about 25 days). (Bug#8664)
5942
5943 * xselect.c (last_event_timestamp): Remove duplicate decl.
5944 (x_own_selection): Remove needless cast to unsigned long.
5945
5946 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5947 that always fit in int. Use a sentinel instead of a counter, to
5948 avoid a temp and to allay GCC's concerns about possible int overflow.
5949 * frame.h (struct frame): Use int for menu_bar_items_used
5950 instead of EMACS_INT, since it always fits in int.
5951
5952 * menu.c (grow_menu_items): Check for int overflow.
5953
5954 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5955
5956 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5957 Before, the code was not consistent. These values cannot exceed
5958 2**31 - 1 so there's no need to make them unsigned.
5959 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5960 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5961 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5962 as modifiers.
5963 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5964
5965 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5966 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5967 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5968 presumably because the widths might not match.
5969
5970 * window.c (size_window): Avoid needless test at loop start.
5971
5972 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5973
5974 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5975
5976 2011-05-12 Drew Adams <drew.adams@oracle.com>
5977
5978 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5979
5980 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5981
5982 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5983 `width' to `bar_area_x' and `bar_area_width', respectively.
5984 (x_scroll_run): Take account of fringe background extension.
5985
5986 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5987 Rename local vars `left' and `width' to `bar_area_x' and
5988 `bar_area_width', respectively.
5989 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5990 background extension.
5991
5992 2011-05-10 Jim Meyering <meyering@redhat.com>
5993
5994 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5995
5996 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5997
5998 * image.c (Finit_image_library): Return t for built-in image types,
5999 like pbm and xbm. (Bug#8640)
6000
6001 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6002
6003 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6004
6005 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6006
6007 * w32console.c (Fset_screen_color): Doc fix.
6008 (Fget_screen_color): New function.
6009 (syms_of_ntterm): Defsubr it.
6010
6011 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6012 unlink the temporary file if Fcall_process didn't create it in the
6013 first place.
6014 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6015 child process will be redirected to a file specified with `:file'.
6016 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6017 cue to call_process_cleanup not to close that handle.
6018
6019 2011-05-07 Ben Key <bkey76@gmail.com>
6020
6021 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6022 one of two shell specific rules, either bootstrap-temacs-CMD or
6023 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6024 to the previous implementation of the bootstrap-temacs rule.
6025 The bootstrap-temacs-CMD rule is similar to the previous
6026 implementation of the bootstrap-temacs rule except that it
6027 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6028 variable.
6029
6030 These changes, along with some changes to nt/configure.bat,
6031 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6032 earlier fix to add support for --cflags and --ldflags options
6033 that include quotes so that it works whether make uses cmd or
6034 sh as the shell.
6035
6036 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6037
6038 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6039 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6040 is a constant.
6041 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6042 a string. Handle both cases.
6043 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6044 (Fdbus_register_method): Use Qinvalid_function.
6045
6046 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6047
6048 * makefile.w32-in: Update dependencies.
6049 (LISP_H): Add inttypes.h and stdin.h.
6050 (PROCESS_H): Add unistd.h.
6051
6052 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6053
6054 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6055 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6056
6057 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6058
6059 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6060
6061 * term.c (vfatal): Remove stray call to va_end.
6062 It's not needed and the C Standard doesn't allow it here anyway.
6063
6064 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6065 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6066
6067 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6068 bytes.
6069
6070 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6071
6072 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6073
6074 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6075
6076 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6077
6078 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6079
6080 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6081 * charset.c (Fdefine_charset_internal): Don't initialize
6082 charset.code_space[15]. The value was garbage, on hosts with
6083 32-bit int (Bug#8600).
6084
6085 * lread.c (read_integer): Be more consistent with string-to-number.
6086 Use string_to_number to do the actual conversion; this avoids
6087 rounding errors and fixes some other screwups. Without this fix,
6088 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6089 (digit_to_number): Move earlier, for benefit of read_integer.
6090 Return -1 if the digit is out of range for the base, -2 if it is
6091 not a digit in any supported base. (Bug#8602)
6092
6093 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6094
6095 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6096 to match comment at start of function. This also removes a
6097 GCC warning about overflow in a 32+64-bit port.
6098
6099 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6100
6101 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6102 Reported by Stefan Monnier in
6103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6104 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6105 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6106
6107 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6108 (EMACS_UINTPTR): Likewise, with uintptr_t.
6109
6110 * lisp.h: Prefer 64-bit EMACS_INT if available.
6111 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6112 on 32-bit hosts that have 64-bit int, so that they can access
6113 large files.
6114 However, temporarily disable this change unless the temporary
6115 symbol WIDE_EMACS_INT is defined.
6116
6117 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6118
6119 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6120 This removes an assumption that EMACS_INT and long are the same
6121 width as pointers. The assumption is true for Emacs porting targets
6122 now, but we want to make other targets possible.
6123 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6124 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6125 In the rest of the code, change types of integers that hold casted
6126 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6127 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6128 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6129 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6130 No need to cast type when ORing.
6131 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6132 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6133 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6134 assume EMACS_INT is the same width as char *.
6135 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6136 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6137 Remove no-longer-needed casts.
6138 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6139 (xg_tool_bar_help_callback, xg_make_tool_item):
6140 Use EMACS_INTPTR to hold an integer
6141 that will be cast to void *; this can avoid a GCC warning
6142 if EMACS_INT is not the same width as void *.
6143 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6144 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6145 (current_message_1, set_message_1):
6146 Use a local to convert to proper width without a cast.
6147 * xmenu.c (dialog_selection_callback): Likewise.
6148
6149 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6150 Also, don't assume VALBITS / RAND_BITS is less than 5,
6151 and don't rely on undefined behavior when shifting a 1 left into
6152 the sign bit.
6153 * lisp.h (get_random): Change signature to match.
6154
6155 * lread.c (hash_string): Use size_t, not int, for hash computation.
6156 Normally we prefer signed values; but hashing is special, because
6157 it's better to use unsigned division on hash table sizes so that
6158 the remainder is nonnegative. Also, size_t is the natural width
6159 for hashing into memory. The previous code used 'int', which doesn't
6160 retain enough info to hash well into very large tables.
6161 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6162
6163 * dbusbind.c: Don't possibly lose pointer info when converting.
6164 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6165 Use XPNTR rather than XHASH, so that the high-order bits of
6166 the pointer aren't lost when converting through void *.
6167
6168 * eval.c (Fautoload): Don't double-shift a pointer.
6169
6170 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6171
6172 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * gnutls.c (DEF_GNUTLS_FN):
6175 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6176
6177 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6178
6179 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6180 marker. (Bug#8610)
6181
6182 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6183
6184 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6185 New version that can reserve upto 2GB of heap space.
6186
6187 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6188
6189 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6190
6191 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6192
6193 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6194 `gnutls_certificate_set_x509_key_file'.
6195
6196 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6199 Update dependencies.
6200
6201 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6202
6203 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6204 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6205 Remove unused parameter `fildes'.
6206 * process.c (read_process_output, send_process): Don't pass it.
6207
6208 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6209
6210 Fix previous change: the library cache is defined in w32.c.
6211 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6212 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6213
6214 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6215
6216 Implement dynamic loading of GnuTLS on Windows.
6217
6218 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6219 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6220 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6221 Declare.
6222
6223 * gnutls.c (Qgnutls_dll): Define.
6224 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6225 (gnutls_*): Declare function pointers.
6226 (init_gnutls_functions): New function to initialize function pointers.
6227 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6228 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6230 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6231 (emacs_gnutls_write, emacs_gnutls_read)
6232 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6233 (Fgnutls_available_p): New function.
6234 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6235 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6236 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6237
6238 * image.c: Include w32.h.
6239 (Vimage_type_cache): Delete.
6240 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6241 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6242 (w32_delayed_load): Move to w32.c.
6243
6244 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6245
6246 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6247 (w32_delayed_load): Move from image.c. When loading a library, record
6248 its filename in the :loaded-from property of the library id.
6249 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6250 Initialize and staticpro them.
6251 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6252
6253 * process.c: Include lisp.h before w32.h, not after.
6254 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6255 instead of gnutls_record_check_pending.
6256
6257 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6258
6259 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6260
6261 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6262 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6263 as passed in.
6264
6265 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6266
6267 * xterm.c (x_set_frame_alpha): Do not set property on anything
6268 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6269
6270 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6271
6272 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6273
6274 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6275
6276 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6277 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6278 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6279 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6280 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6281 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6282 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6283 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6284 (Qgnutls_bootprop_callbacks_verify): Make static.
6285
6286 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6287
6288 * callproc.c: Indentation fixup.
6289
6290 * sysdep.c (wait_for_termination_1): Make static.
6291 (wait_for_termination, interruptible_wait_for_termination):
6292 Move after wait_for_termination_1.
6293
6294 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6295
6296 * sysdep.c (interruptible_wait_for_termination): New function
6297 which is like wait_for_termination, but allows keyboard
6298 interruptions.
6299
6300 * callproc.c (Fcall_process): Add (:file "file") as an option for
6301 the STDOUT buffer.
6302 (Fcall_process_region): Ditto.
6303
6304 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6305
6306 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6307 rather than `XVECTOR (FOO)->size'.
6308
6309 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6310 inttypes.h, as a gnulib replacement is used if it not available in
6311 system headers.
6312
6313 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6314
6315 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6316 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6317 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6318
6319 * coding.c (coding_alloc_by_realloc): Error out if destination
6320 will grow beyond MOST_POSITIVE_FIXNUM.
6321 (decode_coding_emacs_mule): Abort if there isn't enough place in
6322 charbuf for the composition carryover bytes. Reserve an extra
6323 space for up to 2 characters produced in a loop.
6324 (decode_coding_iso_2022): Abort if there isn't enough place in
6325 charbuf for the composition carryover bytes.
6326
6327 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6328
6329 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6330 aborting when %lld or %lll format is passed.
6331 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6332 %llo or %llx format is passed. (Bug#8545)
6333
6334 * window.c (window_scroll_line_based): Use a marker instead of
6335 simple variables to record original value of point. (Bug#7952)
6336
6337 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6338 produced by %s or %c overflows available buffer space. (Bug#8545)
6339
6340 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6341
6342 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6343 (SIZE_MAX): Move defn after all includes, as they might #define it.
6344
6345 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6346
6347 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6348
6349 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6350
6351 * keyboard.c (Qdelayed_warnings_hook): Define.
6352 (command_loop_1): Run `delayed-warnings-hook'
6353 if Vdelayed_warnings_list is non-nil.
6354 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6355 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6356
6357 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6358
6359 * doprnt.c (doprnt): Don't return value smaller than the buffer
6360 size if the message was truncated. (Bug#8545).
6361
6362 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6363
6364 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6365 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6366
6367 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6370
6371 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6372
6373 * makefile.w32-in: Update dependencies.
6374
6375 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6376
6377 Improve `doprnt' and its usage. (Bug#8545)
6378 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6379 `format_end'. Remove support for %l as a conversion specifier.
6380 Don't use xrealloc. Improve diagnostics when the %l size modifier
6381 is used. Update the commentary.
6382
6383 * eval.c (verror): Simplify calculation of size_t.
6384
6385 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6386 messages.
6387
6388 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6389
6390 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6391 change.
6392
6393 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6396 This makes this file independent of the recent pseudovector change.
6397
6398 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6399
6400 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6401
6402 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6403 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6404 Remove unused local.
6405 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6406
6407 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6408 GCC 4.6.0 optimizes based on type-based alias analysis.
6409 For example, if b is of type struct buffer * and v of type struct
6410 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6411 != &v->size, and therefore "v->size = 1; b->size = 2; return
6412 v->size;" must therefore return 1. This assumption is incorrect
6413 for Emacs, since it type-puns struct Lisp_Vector * with many other
6414 types. To fix this problem, this patch adds a new type struct
6415 vectorlike_header that documents the constraints on layout of vectors
6416 and pseudovectors, and helps optimizing compilers not get fooled
6417 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6418 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6419 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6420 the size member.
6421 (XSETPVECTYPE): Rewrite in terms of new macro.
6422 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6423 This is a bit clearer, and further avoids the possibility of
6424 undesirable aliasing.
6425 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6426 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6427 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6428 since Lisp_Subr is a special case (no "next" field).
6429 (ASIZE): Now uses header.size rather than size.
6430 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6431 to avoid the hassle of writing XVECTOR (foo)->header.size.
6432 (struct vectorlike_header): New type.
6433 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6434 object, to help avoid aliasing.
6435 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6436 (SUBRP): Likewise, since Lisp_Subr is a special case.
6437 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6438 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6439 (struct Lisp_Hash_Table): Combine first two members into a single
6440 struct vectorlike_header member. All uses of "size" and "next" members
6441 changed to be "header.size" and "header.next".
6442 * buffer.h (struct buffer): Likewise.
6443 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6444 * frame.h (struct frame): Likewise.
6445 * process.h (struct Lisp_Process): Likewise.
6446 * termhooks.h (struct terminal): Likewise.
6447 * window.c (struct save_window_data, struct saved_window): Likewise.
6448 * window.h (struct window): Likewise.
6449 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6450 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6451 * buffer.c (init_buffer_once): Likewise.
6452 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6453 special case.
6454 * process.c (Fformat_network_address): Use local var for size,
6455 for brevity.
6456
6457 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6458
6459 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6460 * data.c (atof): Remove decl; no longer used or needed.
6461 (digit_to_number): Move to lread.c.
6462 (Fstring_to_number): Use new string_to_number function, to be
6463 consistent with how the Lisp reader treats infinities and NaNs.
6464 Do not assume that floating-point numbers represent EMACS_INT
6465 without losing information; this is not true on most 64-bit hosts.
6466 Avoid double-rounding errors, by insisting on integers when
6467 parsing non-base-10 numbers, as the documentation specifies.
6468 * lisp.h (string_to_number): New decl, replacing ...
6469 (isfloat_string): Remove.
6470 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6471 (read1): Do not accept +. and -. as integers; this
6472 appears to have been a coding error. Similarly, do not accept
6473 strings like +-1e0 as floating point numbers. Do not report
6474 overflow for integer overflows unless the base is not 10 which
6475 means we have no simple and reliable way to continue.
6476 Break out the floating-point parsing into a new
6477 function string_to_number, so that Fstring_to_number parses
6478 floating point numbers consistently with the Lisp reader.
6479 (digit_to_number): Move here from data.c. Make it static inline.
6480 (E_CHAR, EXP_INT): Remove, replacing with ...
6481 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6482 (string_to_number): New function, replacing isfloat_string.
6483 This function checks for valid syntax and produces the resulting
6484 Lisp float number too. Rework it so that string-to-number
6485 no longer mishandles examples like "1.0e+". Use strtoumax,
6486 so that overflow for non-base-10 numbers is reported only when
6487 there's no portable and simple way to convert to floating point.
6488
6489 * textprop.c (set_text_properties_1): Rewrite for clarity,
6490 and to avoid GCC warning about integer overflow.
6491
6492 * intervals.h (struct interval): Use EMACS_INT for members
6493 where EMACS_UINT might cause problems. See
6494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6495 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6496 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6497 All uses changed.
6498 (offset_intervals): Tell GCC not to worry about length overflow
6499 when negating a negative length.
6500
6501 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6502 (overrun_check_free): Likewise.
6503
6504 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6505 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6506 word size.
6507
6508 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6509 (gnutls_make_error): Rename local to avoid shadowing.
6510 (gnutls_emacs_global_deinit): ifdef out; not used.
6511 (Fgnutls_boot): Use const for pointer to readonly storage.
6512 Comment out unused local. Fix pointer signedness problems.
6513
6514 * lread.c (openp): Don't stuff size_t into an 'int'.
6515 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6516 about possible signed overflow.
6517
6518 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6519 (GDK_KEY_g): Don't define if already defined.
6520 (xg_prepare_tooltip): Avoid pointer signedness problem.
6521 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6522
6523 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6524 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6525
6526 * xfns.c (Fx_window_property): Simplify a bit,
6527 to make a bit faster and to avoid GCC 4.6.0 warning.
6528 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6529
6530 * fns.c (internal_equal): Don't assume size_t fits in int.
6531
6532 * alloc.c (compact_small_strings): Tighten assertion a little.
6533
6534 Replace pEd with more-general pI, and fix some printf arg casts.
6535 * lisp.h (pI): New macro, generalizing old pEd macro to other
6536 conversion specifiers. For example, use "...%"pI"d..." rather
6537 than "...%"pEd"...".
6538 (pEd): Remove. All uses replaced with similar uses of pI.
6539 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6540 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6541 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6542 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6543 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6544 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6545 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6546 64-bit hosts.
6547 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6548 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6549 * print.c (safe_debug_print, print_object): Likewise.
6550 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6551 to int.
6552 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6553 avoiding the 0 flag, which is not portable.
6554 * process.c (Fmake_network_process): Use pI to avoid cast.
6555 * region-cache.c (pp_cache): Likewise.
6556 * xdisp.c (decode_mode_spec): Likewise.
6557 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6558 behavior on 64-bit hosts with printf arg.
6559 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6560 (x_stop_queuing_selection_requests): Likewise.
6561 (x_get_window_property): Don't truncate byte count to an 'int'
6562 when tracing.
6563
6564 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6565 here, since it parses constructs like leading '-' and spaces,
6566 which are not wanted; and it overflows with large numbers.
6567 Instead, simply match F[0-9]+, which is what is wanted anyway.
6568
6569 * alloc.c: Remove unportable assumptions about struct layout.
6570 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6571 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6572 (allocate_vectorlike, make_pure_vector): Use the new macros,
6573 plus offsetof, to remove unportable assumptions about struct layout.
6574 These assumptions hold on all porting targets that I know of, but
6575 they are not guaranteed, they're easy to remove, and removing them
6576 makes further changes easier.
6577
6578 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6579 This doesn't fix a bug but makes the code clearer.
6580 (string_overrun_cookie): Now const. Use initializers that
6581 don't formally overflow signed char, to avoid warnings.
6582 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6583 can cause Emacs to crash when string overrun checking is enabled.
6584 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6585 multiple of sizeof (EMACS_INT); it need not be, if
6586 alignof(EMACS_INT) < sizeof (EMACS_INT).
6587 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6588
6589 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6590
6591 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6592
6593 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6594
6595 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6596 supposed to be handshaking. (Bug#8556)
6597 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6598
6599 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6600
6601 * lisp.h (Qdebug): List symbol.
6602 * eval.c (Qdebug): Restore global linkage.
6603 * keyboard.c (debug-on-event): New variable.
6604 (handle_user_signal): Break into debugger when debug-on-event
6605 matches the current signal symbol.
6606
6607 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6608
6609 * alloc.c (check_sblock, check_string_bytes)
6610 (check_string_free_list): Convert to standard C.
6611
6612 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6613
6614 * w32.c (emacs_gnutls_push): Fix typo.
6615
6616 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6617
6618 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6619 "cast to pointer from integer of different size".
6620
6621 Improve doprnt and its use in verror. (Bug#8545)
6622 * doprnt.c (doprnt): Document the set of format control sequences
6623 supported by the function. Use SAFE_ALLOCA instead of always
6624 using `alloca'.
6625
6626 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6627 is one byte too soon. Don't use xrealloc; instead xfree and
6628 xmalloc anew.
6629
6630 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6631
6632 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6633 callbacks stage.
6634
6635 * gnutls.c: Renamed global_initialized to
6636 gnutls_global_initialized. Added internals for the
6637 :verify-hostname-error, :verify-error, and :verify-flags
6638 parameters of `gnutls-boot' and documented those parameters in the
6639 docstring. Start callback support.
6640 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6641 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6642 on error. Return error code.
6643 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6644 (emacs_gnutls_read): Likewise.
6645 (Fgnutls_boot): Return handshake error code.
6646 (emacs_gnutls_handle_error): New function.
6647 (wsaerror_to_errno): Likewise.
6648
6649 * w32.h (emacs_gnutls_pull): Add prototype.
6650 (emacs_gnutls_push): Likewise.
6651
6652 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6653 (emacs_gnutls_push): Likewise.
6654
6655 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6656
6657 * process.c (wait_reading_process_output): Check if GnuTLS
6658 buffered some data internally if no FDs are set for TLS
6659 connections.
6660
6661 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6662 (LIBS): Link to USER_LIBS.
6663 ($(BLD)/gnutls.$(0)): New target.
6664
6665 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6666
6667 * xdisp.c (handle_single_display_spec): Rename the
6668 display_replaced_before_p argument into display_replaced_p, to
6669 make it consistent with the commentary. Fix typos in the
6670 commentary.
6671
6672 * textprop.c (syms_of_textprop): Remove dead code.
6673 (copy_text_properties): Delete obsolete commentary about an
6674 interface that was deleted long ago. Fix typos in the description
6675 of arguments.
6676
6677 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6678 to changes in oldXMenu/XMenu.h from 2011-04-16.
6679 <menu_help_message, prev_menu_help_message>: Constify.
6680 (IT_menu_make_room): menu->help_text is now `const char **';
6681 adjust.
6682
6683 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6684 to changes in oldXMenu/XMenu.h from 2011-04-16.
6685 (struct XMenu): Declare `help_text' `const char **'.
6686
6687 * xfaces.c <Qunspecified>: Make extern again.
6688
6689 * syntax.c: Include sys/types.h before including regex.h, as
6690 required by Posix.
6691
6692 * doc.c (get_doc_string): Improve the format passed to `error'.
6693
6694 * doprnt.c (doprnt): Improve commentary.
6695
6696 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6697
6698 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6699 them with etags.
6700
6701 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6702 changes in globals.h immediately force recompilation.
6703 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6704 $(CURDIR)/s/ms-w32.h.
6705 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6706
6707 * character.c (Fchar_direction): Function deleted.
6708 (syms_of_character): Don't defsubr it.
6709 <char-direction-table>: Deleted.
6710
6711 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6712
6713 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6714 * doprnt.c: Include limits.h.
6715 (SIZE_MAX): New macro.
6716 (doprnt): Return a size_t value. 2nd arg is now size_t.
6717 Many local variables are now size_t instead of int or unsigned.
6718 Improve overflow protection. Support `l' modifier for integer
6719 conversions. Support %l conversion. Don't assume an EMACS_INT
6720 argument for integer conversions and for %c.
6721
6722 * lisp.h (doprnt): Restore prototype.
6723
6724 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6725 $(SRC)/character.h.
6726
6727 * Makefile.in (base_obj): Add back doprnt.o.
6728
6729 * deps.mk (doprnt.o): Add back prerequisites.
6730 (callint.o): Depend on character.h.
6731
6732 * eval.c (internal_lisp_condition_case): Include the handler
6733 representation in the error message.
6734 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6735 when breaking from the loop.
6736
6737 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6738
6739 * callint.c (Fcall_interactively): When displaying error message
6740 about invalid control letter, pass the character's codepoint, not
6741 a pointer to its multibyte form. Improve display of the character
6742 in octal and display also its hex code.
6743
6744 * character.c (char_string): Use %x to display the (unsigned)
6745 codepoint of an invalid character, to avoid displaying a bogus
6746 negative value.
6747
6748 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6749 `error', not SYMBOL_NAME itself.
6750
6751 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6752 character arguments to `error'.
6753
6754 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6755 to `error' in error message about FINAL_CHAR argument. Make sure
6756 FINAL_CHAR is a character, and use %c when it is passed as
6757 argument to `error'.
6758
6759 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6760
6761 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6762
6763 * w32.c: Include <time.h>.
6764 (sys_localtime): New function.
6765
6766 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6767
6768 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6769
6770 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6771
6772 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6773
6774 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6775 zombies (Bug#8467).
6776
6777 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6778
6779 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6780 gl_state.e_property when gl_state.object is Qt.
6781
6782 * insdel.c (make_gap_larger): Remove limitation of buffer size
6783 to <= INT_MAX.
6784
6785 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6786
6787 * xdisp.c (lookup_glyphless_char_display)
6788 (produce_glyphless_glyph): Handle cons cell entry in
6789 glyphless-char-display.
6790 (Vglyphless_char_display): Document it.
6791
6792 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6793 glyphless-char-display.
6794
6795 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6796
6797 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6798
6799 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6800
6801 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6802 definition for no-X builds.
6803
6804 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6805
6806 Static checks with GCC 4.6.0 and non-default toolkits.
6807
6808 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6809
6810 * process.c (keyboard_bit_set): Define only if SIGIO.
6811 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6812 (send_process): Repair possible setjmp clobbering.
6813
6814 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6815
6816 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6817
6818 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6819
6820 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6821 Define only if needed.
6822
6823 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6824 by pacifying GCC about it. Maybe it's time to retire it?
6825 * xfaces.c (USG, __TIMEVAL__): Likewise.
6826
6827 * dispextern.h (struct redisplay_interface): Rename param
6828 to avoid shadowing.
6829 * termhooks.h (struct terminal): Likewise.
6830 * xterm.c (xembed_send_message): Likewise.
6831
6832 * insdel.c (make_gap_smaller): Define only if
6833 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6834
6835 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6836 it.
6837
6838 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6839 so that we aren't warned about unused symbols.
6840
6841 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6842
6843 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6844
6845 * xfns.c (x_real_positions): Mark locals as initialized.
6846
6847 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6848
6849 * xterm.c: Fix problems found by static analysis with other toolkits.
6850 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6851 (x_dispatch_event): Declare static if USE_GTK, and
6852 define if USE_GTK || USE_X_TOOLKIT.
6853 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6854 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6855 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6856 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6857
6858 * xmenu.c (menu_help_callback): Pointer type fixes.
6859 Use const pointers when pointing at readonly data. Avoid pointer
6860 signedness clashes.
6861 (FALSE): Remove unused macro.
6862 (update_frame_menubar): Remove unused decl.
6863
6864 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6865
6866 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6867 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6868 (single_menu_item): Rename local to avoid shadowing.
6869
6870 * keyboard.c (make_lispy_event): Remove unused local var.
6871
6872 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6873 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6874
6875 * bitmaps: Change bitmaps from unsigned char back to the X11
6876 compatible char. Avoid the old compiler warnings about
6877 out-of-range initializers by using, for example, '\xab' rather
6878 than 0xab.
6879
6880 * xgselect.c (xgselect_initialize): Check vs interface
6881 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6882
6883 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6884
6885 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6886 to read-only memory.
6887
6888 * fns.c (vector): Remove; this old hack is no longer needed.
6889
6890 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6891 Remove unused var.
6892 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6893
6894 * xrdb.c (x_load_resources): Omit unused local.
6895
6896 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6897 (x_window): Rename locals to avoid shadowing.
6898 (USG): Use the kludged USG macro, to pacify gcc.
6899
6900 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6901 (x_term_init): Remove local to avoid shadowing.
6902
6903 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6904
6905 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6906 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6907
6908 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6909
6910 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6911
6912 Fix regex.c, syntax.c and friends for buffers > 2GB.
6913 * syntax.h (struct gl_state_s): Declare character position members
6914 EMACS_INT.
6915
6916 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6917
6918 * textprop.c (verify_interval_modification, interval_of):
6919 Declare arguments EMACS_INT.
6920
6921 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6922 EMACS_INT.
6923
6924 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6925
6926 * indent.c (Fvertical_motion): Local variable it_start is now
6927 EMACS_INT.
6928
6929 * regex.c (re_match, re_match_2, re_match_2_internal)
6930 (bcmp_translate, regcomp, regexec, print_double_string)
6931 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6932 (re_compile_pattern, re_exec): Declare arguments and local
6933 variables `size_t' and `ssize_t' and return values `regoff_t', as
6934 appropriate.
6935 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6936 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6937 <compile_stack_type>: `size' and `avail' are now `size_t'.
6938
6939 * regex.h <regoff_t>: Use ssize_t, not int.
6940 (re_search, re_search_2, re_match, re_match_2): Arguments that
6941 specify buffer/string position and length are now ssize_t and
6942 size_t. Return type is regoff_t.
6943
6944 2011-04-16 Ben Key <bkey76@gmail.com>
6945
6946 * nsfont.m: Fixed bugs in ns_get_family and
6947 ns_descriptor_to_entity that were caused by using free to
6948 deallocate memory blocks that were allocated by xmalloc (via
6949 xstrdup). This caused Emacs to crash when compiled with
6950 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6951 --enable-checking=xmallocoverrun). xfree is now used to
6952 deallocate these memory blocks.
6953
6954 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6955
6956 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6957
6958 emacs_write: Accept and return EMACS_INT for sizes.
6959 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6960 et seq.
6961 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6962 Accept and return EMACS_INT.
6963 (emacs_gnutls_write): Return the number of bytes written on
6964 partial writes.
6965 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6966 (emacs_read, emacs_write): Remove check for negative size, as the
6967 Emacs source code has been audited now.
6968 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6969 (emacs_read, emacs_write): Use it.
6970 * process.c (send_process): Adjust to the new signatures of
6971 emacs_write and emacs_gnutls_write. Do not attempt to store
6972 a byte offset into an 'int'; it might overflow.
6973 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6974
6975 * sound.c: Don't assume sizes fit in 'int'.
6976 (struct sound_device.period_size, alsa_period_size):
6977 Return EMACS_INT, not int.
6978 (struct sound_device.write, vox_write, alsa_write):
6979 Accept EMACS_INT, not int.
6980 (wav_play, au_play): Use EMACS_INT to store sizes and to
6981 record read return values.
6982
6983 2011-04-15 Ben Key <bkey76@gmail.com>
6984
6985 * keyboard.c (Qundefined): Don't declare static since it is used
6986 in nsfns.m.
6987 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6988 static since they are used in nsfont.m.
6989
6990 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6991
6992 * process.c (Qprocessp): Don't declare static.
6993 * lisp.h (Qprocessp): Declare again.
6994
6995 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6996
6997 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6998
6999 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7000
7001 Improve C-level modularity by making more things 'static'.
7002
7003 Don't publish debugger-only interfaces to other modules.
7004 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7005 (verify_bytepos, count_markers): Move decls to the only modules
7006 that need them.
7007 * region-cache.h (pp_cache): Likewise.
7008 * window.h (check_all_windows): Likewise.
7009 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7010
7011 * sysdep.c (croak): Now static, if
7012 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7013 * syssignal.h (croak): Declare only if not static.
7014
7015 * alloc.c (refill_memory_reserve): Now static if
7016 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7017 * lisp.h (refill_memory_reserve): Declare only if not static.
7018
7019 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7020 Define only if USE_LUCID.
7021
7022 * xrdb.c (x_customization_string, x_rm_string): Now static.
7023
7024 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7025 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7026
7027 * xdisp.c (draw_row_with_mouse_face): Now static.
7028 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7029
7030 * window.h (check_all_windows): Mark externally visible.
7031
7032 * window.c (window_deletion_count): Now static.
7033
7034 * undo.c: Make symbols static if they're not exported.
7035 (last_undo_buffer, last_boundary_position, pending_boundary):
7036 Now static.
7037
7038 * textprop.c (interval_insert_behind_hooks): Now static.
7039 (interval_insert_in_front_hooks): Likewise.
7040
7041 * term.c: Make symbols static if they're not exported.
7042 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7043 (max_frame_lines, tty_set_terminal_modes):
7044 (tty_reset_terminal_modes, tty_turn_off_highlight):
7045 (get_tty_terminal): Now static.
7046 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7047 * termhooks.h (term_mouse_moveto): Do not declare if
7048 HAVE_WINDOW_SYSTEM.
7049 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7050 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7051
7052 * sysdep.c: Make symbols static if they're not exported.
7053 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7054 Now static.
7055 (sigprocmask_set, full_mask): Remove; unused.
7056 (wait_debugging): Mark as visible.
7057 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7058 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7059
7060 * syntax.c (syntax_temp): Define only if !__GNUC__.
7061
7062 * sound.c (current_sound_device, current_sound): Now static.
7063
7064 * search.c (searchbufs, searchbuf_head): Now static.
7065
7066 * scroll.c (scroll_cost): Remove; unused.
7067 * dispextern.h (scroll_cost): Remove decl.
7068
7069 * region-cache.h (pp_cache): Mark as externally visible.
7070
7071 * process.c: Make symbols static if they're not exported.
7072 (process_tick, update_tick, create_process, chan_process):
7073 (Vprocess_alist, proc_buffered_char, datagram_access):
7074 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7075 (deactivate_process): Mark defn as static, as well as decl.
7076 * lisp.h (create_process): Remove decl.
7077 * process.h (chan_process, Vprocess_alist): Remove decls.
7078
7079 * print.c: Make symbols static if they're not exported.
7080 (print_depth, new_backquote_output, being_printed, print_buffer):
7081 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7082 (print_interval, print_number_index, initial_stderr_stream):
7083 Now static.
7084 * lisp.h (Fprinc): Remove decl.
7085 (debug_output_compilation_hack): Mark as externally visible.
7086
7087 * sysdep.c (croak): Move decl from here to syssignal.h.
7088 * syssignal.h (croak): Put it here, so the API can be checked when
7089 'croak' is called from dissociate_if_controlling_tty.
7090
7091 * minibuf.c: Make symbols static if they're not exported.
7092 (minibuf_save_list, choose_minibuf_frame): Now static.
7093 * lisp.h (choose_minibuf_frame): Remove decl.
7094
7095 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7096
7097 * lread.c: Make symbols static if they're not exported.
7098 (read_objects, initial_obarray, oblookup_last_bucket_number):
7099 Now static.
7100 (make_symbol): Remove; unused.
7101 * lisp.h (initial_obarray, make_symbol): Remove decls.
7102
7103 * keyboard.c: Make symbols static if they're not exported.
7104 (single_kboard, recent_keys_index, total_keys, recent_keys):
7105 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7106 (this_single_command_key_start, echoing, last_auto_save):
7107 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7108 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7109 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7110 (Vlispy_mouse_stem, double_click_count):
7111 Now static.
7112 (force_auto_save_soon): Define only if SIGDANGER.
7113 (ignore_mouse_drag_p): Now static if
7114 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7115 (print_help): Remove; unused.
7116 (stop_character, last_timer_event): Mark as externally visible.
7117 * keyboard.h (ignore_mouse_drag_p): Declare only if
7118 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7119 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7120 * lisp.h (echoing): Remove decl.
7121 (force_auto_save_soon): Declare only if SIGDANGER.
7122 * xdisp.c (redisplay_window): Simplify code, to make it more
7123 obvious that ignore_mouse_drag_p is not accessed if !defined
7124 USE_GTK && !defined HAVE_NS.
7125
7126 * intervals.c: Make symbols static if they're not exported.
7127 (merge_properties_sticky, merge_interval_right, delete_interval):
7128 Now static.
7129 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7130
7131 * insdel.c: Make symbols static if they're not exported.
7132 However, leave prepare_to_modify_buffer alone. It's never
7133 called from outside this function, but that appears to be a bug.
7134 (combine_after_change_list, combine_after_change_buffer):
7135 (adjust_after_replace, signal_before_change): Now static.
7136 (adjust_after_replace_noundo): Remove; unused.
7137 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7138 (signal_before_change): Remove decls.
7139
7140 * indent.c (val_compute_motion, val_vmotion): Now static.
7141
7142 * image.c: Make symbols static if they're not exported.
7143 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7144 if USE_GTK.
7145 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7146 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7147
7148 * fringe.c (standard_bitmaps): Now static.
7149 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7150
7151 * frame.c: Make symbols static if they're not exported.
7152 (x_report_frame_params, make_terminal_frame): Now static.
7153 (get_frame_param): Now static, unless HAVE_NS.
7154 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7155 (x_get_resource_string): Remove; not used.
7156 * frame.h (make_terminal_frame, x_report_frame_params):
7157 (x_get_resource_string); Remove decls.
7158 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7159 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7160
7161 * font.c, fontset.c: Make symbols static if they're not exported.
7162 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7163 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7164 * font.c (font_close_object): Now static.
7165 * font.h (font_close_object): Remove.
7166 * fontset.c (FONTSET_OBJLIST): Remove.
7167 (free_realized_fontset) #if-0 the body, which does nothing.
7168 (face_suitable_for_char_p): #if-0, as it's never called.
7169 * fontset.h (face_suitable_for_char_p): Remove decl.
7170 * xfaces.c (face_at_string_position):
7171 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7172 since 0 is always ASCII.
7173
7174 * fns.c (weak_hash_tables): Now static.
7175
7176 * fileio.c: Make symbols static if they're not exported.
7177 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7178 (Vwrite_region_annotation_buffers): Now static.
7179
7180 * eval.c: Make symbols static if they're not exported.
7181 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7182 * lisp.h (backtrace_list): Remove decl.
7183
7184 * emacs.c: Make symbols static if they're not exported.
7185 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7186 (fatal_error_code, fatal_error_signal_hook, standard_args):
7187 Now static.
7188 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7189 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7190 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7191 * lisp.h (fatal_error_signal_hook): Remove decl.
7192 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7193
7194 * editfns.c: Move a (normally-unused) function to its only use.
7195 * editfns.c, lisp.h (get_operating_system_release): Remove.
7196 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7197 worth the hassle of breaking this out.
7198
7199 * xterm.c: Make symbols static if they're not exported.
7200 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7201 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7202 (x_destroy_window, x_delete_display):
7203 Now static.
7204 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7205 (x_mouse_leave): Remove; unused.
7206 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7207 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7208 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7209 Remove decls.
7210 (x_mouse_leave): Declare only if WINDOWSNT.
7211 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7212 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7213 USE_X_TOOLKIT.
7214
7215 * ftxfont.c: Make symbols static if they're not exported.
7216 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7217 HAVE_FREETYPE.
7218 * font.h (ftxfont_driver): Likewise.
7219
7220 * xfns.c: Make symbols static if they're not exported.
7221 (x_last_font_name, x_display_info_for_name):
7222 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7223 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7224 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7225 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7226 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7227 (last_show_tip_args): Now static.
7228 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7229 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7230 (x_screen_planes): Remove; unused.
7231 * dispextern.h (x_screen_planes): Remove decl.
7232
7233 * dispnew.c: Make symbols static if they're not exported.
7234 * dispextern.h (redraw_garbaged_frames, scrolling):
7235 (increment_row_positions): Remove.
7236 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7237 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7238 Now static.
7239 (redraw_garbaged_frames): Remove; unused.
7240
7241 * xfaces.c: Make symbols static if they're not exported.
7242 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7243 Remove decls.
7244 * xterm.h (defined_color): Remove decls.
7245 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7246 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7247 (menu_face_changed_default, defined_color, free_realized_face):
7248 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7249 (ascii_face_of_lisp_face): Remove; unused.
7250
7251 * xdisp.c: Make symbols static if they're not exported.
7252 * dispextern.h (scratch_glyph_row, window_box_edges):
7253 (glyph_to_pixel_coords, set_cursor_from_row):
7254 (get_next_display_element, set_iterator_to_next):
7255 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7256 (show_mouse_face): Remove decls
7257 * frame.h (message_buf_print): Likewise.
7258 * lisp.h (pop_message, set_message, check_point_in_composition):
7259 Likewise.
7260 * xterm.h (set_vertical_scroll_bar): Likewise.
7261 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7262 (message_buf_print, scratch_glyph_row, displayed_buffer):
7263 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7264 (get_next_display_element, show_mouse_face, window_box_edges):
7265 (frame_to_window_pixel_xy, check_point_in_composition):
7266 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7267 (glyph_to_pixel_coords): Remove; unused.
7268
7269 * dired.c (file_name_completion): Now static.
7270
7271 * dbusbind.c (xd_in_read_queued_messages): Now static.
7272
7273 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7274 * data.c (circular_list_error): Remove.
7275
7276 * commands.h (last_point_position, last_point_position_buffer):
7277 (last_point_position_window): Remove decls.
7278 * keyboard.c: Make these variables static.
7279
7280 * coding.h (coding, code_convert_region, encode_coding_gap):
7281 Remove decls.
7282 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7283 (iso_code_class, detect_coding, code_convert_region): Now static.
7284 (encode_coding_gap): Remove; unused.
7285
7286 * chartab.c (chartab_chars, chartab_bits): Now static.
7287
7288 * charset.h (charset_iso_8859_1): Remove decl.
7289 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7290 Now static.
7291
7292 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7293 * ccl.c (Vccl_program_table): Now static.
7294 (check_ccl_update): Remove; unused.
7295
7296 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7297 * category.h: ... from here.
7298 * category.c (check_category_table, set_category_set): Now static.
7299
7300 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7301 * lisp.h: Remove these decls.
7302
7303 * buffer.c (buffer_count): Remove unused var.
7304
7305 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7306 so that it's not optimized away.
7307 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7308 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7309 exported only to the debugger.
7310
7311 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7312 * atimer.h (run_all_atimers): Remove; not exported.
7313
7314 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7315 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7316 was inaccessible from Lisp.
7317 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7318 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7319
7320 alloc.c: Import and export fewer symbols, and remove unused items.
7321 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7322 is defined.
7323 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7324 it's not optimized away by whole-program optimization.
7325 (message_enable_multibyte, free_misc): Remove.
7326 (catchlist, handlerlist, mark_backtrace):
7327 Declare only if BYTE_MARK_STACK.
7328 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7329 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7330 (message_enable_multibyte): Remove decl.
7331 (free_misc, interval_free_list, float_block, float_block_index):
7332 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7333 (cons_free_list, last_marked_index):
7334 Now static.
7335 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7336 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7337 (mark_backtrace): Define only if BYTE_MARK_STACK.
7338 * xdisp.c (message_enable_multibyte): Now static.
7339
7340 Declare Lisp_Object Q* variables to be 'static' if not exported.
7341 This makes it easier for human readers (and static analyzers)
7342 to see whether these variables are used from other modules.
7343 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7344 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7345 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7346 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7347 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7348 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7349 * xmenu.c, xselect.c:
7350 Declare Q* vars static if they are not used in other modules.
7351 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7352 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7353 Remove decls of unexported vars.
7354 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7355
7356 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7357
7358 Make Emacs functions such as Fatom 'static' by default.
7359 This makes it easier for human readers (and static analyzers)
7360 to see whether these functions can be called from other modules.
7361 DEFUN now defines a static function. To make the function external
7362 so that it can be used in other C modules, use the new macro DEFUE.
7363 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7364 (Finit_image_library):
7365 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7366 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7367 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7368 Remove decls, since these functions are now static.
7369 (Funintern, Fget_internal_run_time): New decls, since these functions
7370 were already external.
7371
7372 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7373 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7374 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7375 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7376 * keyboard.c, keymap.c, lread.c:
7377 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7378 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7379 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7380 Mark functions with DEFUE instead of DEFUN,
7381 if they are used in other modules.
7382 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7383 decls for now-static functions.
7384 * buffer.h (Fdelete_overlay): Remove decl.
7385 * callproc.c (Fgetenv_internal): Mark as internal.
7386 * composite.c (Fremove_list_of_text_properties): Remove decl.
7387 (Fcomposition_get_gstring): New forward static decl.
7388 * composite.h (Fcomposite_get_gstring): Remove decl.
7389 * dired.c (Ffile_attributes): New forward static decl.
7390 * doc.c (Fdocumntation_property): New forward static decl.
7391 * eval.c (Ffetch_bytecode): New forward static decl.
7392 (Funintern): Remove extern decl; now in .h file where it belongs.
7393 * fileio.c (Fmake_symbolic_link): New forward static decl.
7394 * image.c (Finit_image_library): New forward static decl.
7395 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7396 * intervals.h (Fprevious_property_change):
7397 (Fremove_list_of_text_properties): Remove decls.
7398 * keyboard.c (Fthis_command_keys): Remove decl.
7399 (Fcommand_execute): New forward static decl.
7400 * keymap.c (Flookup_key): New forward static decl.
7401 (Fcopy_keymap): Now static.
7402 * keymap.h (Flookup_key): Remove decl.
7403 * process.c (Fget_process): New forward static decl.
7404 (Fprocess_datagram_address): Mark as internal.
7405 * syntax.c (Fsyntax_table_p): New forward static decl.
7406 (skip_chars): Remove duplicate decl.
7407 * textprop.c (Fprevious_property_change): New forward static decl.
7408 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7409 Now internal.
7410 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7411 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7412
7413 * editfns.c (Fformat): Remove unreachable code.
7414
7415 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7416
7417 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7418 change. (Bug#8496)
7419
7420 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7421
7422 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7423 when at ZV. (Bug#8487)
7424
7425 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7426
7427 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7428 (Bug#8437)
7429 * keyboard.c (parse_tool_bar_item): Likewise.
7430 * sound.c (sound_cleanup, alsa_close): Likewise.
7431 * termcap.c (tgetent): Likewise.
7432 * xfns.c (x_default_font_parameter): Likewise.
7433 * xsettings.c (read_and_apply_settings): Likewise.
7434
7435 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7436 (overrun_check_free): Protoize.
7437
7438 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7439
7440 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7441 since callers should never pass a negative size.
7442 Change the signature to match that of plain 'read' and 'write'; see
7443 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7444 * lisp.h: Update prototypes of emacs_write and emacs_read.
7445
7446 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7447
7448 * xdisp.c (redisplay_window): Don't try to determine the character
7449 position of the scroll margin if the window start point w->startp
7450 is outside the buffer's accessible region. (Bug#8468)
7451
7452 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7453
7454 Fix write-region and its subroutines for buffers > 2GB.
7455 * fileio.c (a_write, e_write): Modify declaration of arguments and
7456 local variables to support buffers larger than 2GB.
7457 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7458
7459 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7460 argument, local variables, and return value.
7461
7462 * lisp.h: Update prototypes of emacs_write and emacs_read.
7463
7464 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7465
7466 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7469
7470 Fix more problems found by GCC 4.6.0's static checks.
7471
7472 * xdisp.c (vmessage): Use a better test for character truncation.
7473
7474 * charset.c (load_charset_map): <, not <=, for optimization,
7475 and to avoid potential problems with integer overflow.
7476 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7477 * casetab.c (set_identity, shuffle): Likewise.
7478 * editfns.c (Fformat): Likewise.
7479 * syntax.c (skip_chars): Likewise.
7480
7481 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7482 This also lets GCC 4.6.0 generate slightly better loop code.
7483
7484 * callint.c (Fcall_interactively): <, not <=, for optimization.
7485 (Fcall_interactively): Count the number of arguments produced,
7486 not the number of arguments given. This is simpler and lets GCC
7487 4.6.0 generate slightly better code.
7488
7489 * ftfont.c: Distingish more carefully between FcChar8 and char.
7490 The previous code passed unsigned char * to a functions like
7491 strlen and xstrcasecmp that expect char *, which does not
7492 conform to the C standard.
7493 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7494 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7495 char * when the C standard requires it.
7496
7497 * keyboard.c (read_char): Remove unused var.
7498
7499 * eval.c: Port to Windows vsnprintf (Bug#8435).
7500 Include <limits.h>.
7501 (SIZE_MAX): Define if the headers do not.
7502 (verror): Do not give up if vsnprintf returns a negative count.
7503 Instead, grow the buffer. This ports to Windows vsnprintf, which
7504 does not conform to C99. Problem reported by Eli Zaretskii.
7505 Also, simplify the allocation scheme, by avoiding the need for
7506 calling realloc, and removing the ALLOCATED variable.
7507
7508 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7509
7510 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7511 But keep the doprint source code for now, as we might revamp it
7512 and use it again (Bug#8435).
7513 * lisp.h (doprnt): Remove.
7514 * Makefile.in (base_obj): Remove doprnt.o.
7515 * deps.mk (doprnt.o): Remove.
7516
7517 error: Print 32- and 64-bit integers portably (Bug#8435).
7518 Without this change, on typical 64-bit hosts error ("...%d...", N)
7519 was used to print both 32- and 64-bit integers N, which relied on
7520 undefined behavior.
7521 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7522 New macro.
7523 * lisp.h (error, verror): Mark as printf-like functions.
7524 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7525 Report overflow in size calculations when allocating printf buffer.
7526 Do not truncate output string at its first null byte.
7527 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7528 Truncate the output at a character boundary, since vsnprintf does not
7529 do that.
7530 * charset.c (check_iso_charset_parameter): Convert internal
7531 character to string before calling 'error', since %c now has the
7532 printf meaning.
7533 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7534 overflow when computing char to be passed to 'error'. Do not
7535 pass Lisp_Object to 'error'; pass the integer instead.
7536 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7537 formatted with plain %d.
7538
7539 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7540
7541 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7542
7543 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7544
7545 * xterm.c (x_catch_errors): Remove duplicate declaration.
7546
7547 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7548
7549 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7550
7551 2011-04-10 Jim Meyering <meyering@redhat.com>
7552
7553 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7554 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7555 return ssize_t not "int", and use size_t as the buffer length.
7556 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7557 * gnutls.h: Update declarations.
7558 * process.c (read_process_output): Use ssize_t, to match.
7559 (send_process): Likewise.
7560
7561 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7562
7563 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7564
7565 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7566
7567 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7568 Use unsigned char, to match FcChar8 type definition.
7569
7570 * xterm.c (handle_one_xevent):
7571 * xmenu.c (create_and_show_popup_menu):
7572 * xselect.c (x_decline_selection_request)
7573 (x_reply_selection_request): Avoid type-punned deref of X events.
7574
7575 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7576
7577 Fix some uses of `int' instead of EMACS_INT.
7578 * search.c (string_match_1, fast_string_match)
7579 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7580 (scan_buffer, find_next_newline_no_quit)
7581 (find_before_next_newline, search_command, Freplace_match)
7582 (Fmatch_data): Make some `int' variables be EMACS_INT.
7583
7584 * xdisp.c (display_count_lines): 3rd argument and return value now
7585 EMACS_INT. All callers changed.
7586 (pint2hrstr): Last argument is now EMACS_INT.
7587
7588 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7589 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7590 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7591 (decode_coding_utf_16, decode_coding_emacs_mule)
7592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7593 (decode_coding_ccl, decode_coding_charset)
7594 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7595 (decode_coding_iso_2022, decode_coding_emacs_mule)
7596 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7597 <char_offset, last_offset>: Declare EMACS_INT.
7598 (encode_coding_utf_8, encode_coding_utf_16)
7599 (encode_coding_emacs_mule, encode_invocation_designation)
7600 (encode_designation_at_bol, encode_coding_iso_2022)
7601 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7602 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7603 Declare EMACS_INT.
7604 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7605 (encode_invocation_designation): Last argument P_NCHARS is now
7606 EMACS_INT.
7607 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7608 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7609
7610 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7611 All users changed.
7612
7613 * ccl.c (Fccl_execute_on_string): Declare some variables
7614 EMACS_INT.
7615
7616 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7617
7618 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7619
7620 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7621
7622 * process.c (Fformat_network_address): Doc fix.
7623
7624 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7625
7626 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7627
7628 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7629
7630 * keyboard.c (read_char): Call Lisp function help-form-show,
7631 instead of using internal_with_output_to_temp_buffer.
7632 (Qhelp_form_show): New var.
7633 (syms_of_keyboard): Use DEFSYM macro.
7634
7635 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7636
7637 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7638
7639 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7640
7641 * process.c (Flist_processes): Remove to Lisp.
7642 (list_processes_1): Delete.
7643
7644 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7645
7646 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7647
7648 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7649
7650 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7651
7652 Fix more problems found by GCC 4.6.0's static checks.
7653
7654 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7655
7656 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7657
7658 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7659
7660 * xdisp.c (vmessage): Mark as a printf-like function.
7661
7662 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7663
7664 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7665
7666 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7667 printf-like functions.
7668 (tiff_load): Add casts to remove these marks before passing them
7669 to system-supplied API.
7670
7671 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7672
7673 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7674 This avoids several warnings with gcc -Wstrict-overflow.
7675 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7676 directly, rather than having caller test rule sign. This avoids
7677 some unnecessary tests.
7678 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7679 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7680 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7681
7682 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7683 (xfont_open): Avoid unnecessary tests.
7684
7685 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7686
7687 * composite.h, composite.c (composition_gstring_put_cache):
7688 Use EMACS_INT, not int, for length.
7689
7690 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7691 breaking out part of COMPOSITION_DECODE_RULE.
7692 (COMPOSITION_DECODE_RULE): Use it.
7693 * composite.c (get_composition_id): Remove unused local vars,
7694 by using the new macro.
7695
7696 * textprop.c (set_text_properties_1): Change while to do-while,
7697 since the condition is always true at first.
7698
7699 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7700 (interval_deletion_adjustment): Return unsigned value.
7701 All uses changed.
7702
7703 * process.c (list_processes_1, create_pty, read_process_output):
7704 (exec_sentinel): Remove vars that were set but not used.
7705 (create_pty): Remove unnecessary "volatile"s.
7706 (Fnetwork_interface_info): Avoid possibility of int overflow.
7707 (read_process_output): Do adaptive read buffering even if carryover.
7708 (read_process_output): Simplify nbytes computation if buffered.
7709
7710 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7711
7712 * syntax.c (scan_words): Remove var that was set but not used.
7713 (update_syntax_table): Use unsigned instead of int.
7714
7715 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7716 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7717 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7718
7719 * print.c (print_error_message): Avoid int overflow.
7720
7721 * font.c (font_list_entities): Redo for clarity,
7722 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7723
7724 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7725 (font_score): Avoid potential overflow in diff calculation.
7726
7727 * fns.c (substring_both): Remove var that is set but not used.
7728 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7729
7730 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7731
7732 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7733 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7734 can always succeed if overflow has undefined behavior.
7735
7736 * search.c (boyer_moore, wordify): Remove vars set but not used.
7737 (wordify): Omit three unnecessary tests.
7738
7739 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7740 All callers changed. This avoids the need for an unused var.
7741
7742 * casefiddle.c (casify_region): Remove var that is set but not used.
7743
7744 * dired.c (file_name_completion): Remove var that is set but not used.
7745
7746 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7747
7748 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7749 (Finsert_file_contents): Remove unnecessary code checking fd.
7750
7751 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7752 Check for integer overflow on size calculations.
7753
7754 * buffer.c (Fprevious_overlay_change): Remove var that is set
7755 but not used.
7756
7757 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7758 Remove vars that are set but not used.
7759 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7760 (timer_check_2): Mark vars as initialized.
7761
7762 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7763
7764 * image.c (lookup_image): Remove var that is set but not used.
7765 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7766
7767 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7768 that are set but not used.
7769
7770 * xfns.c (make_invisible_cursor): Don't return garbage
7771 if XCreateBitmapFromData fails (Bug#8410).
7772
7773 * xselect.c (x_get_local_selection, x_handle_property_notify):
7774 Remove vars that are set but not used.
7775
7776 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7777 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7778
7779 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7780 Remove var that is set but not used.
7781 (scroll_bar_windows_size): Now size_t, not int.
7782 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7783 Check for overflow.
7784
7785 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7786 (map_tty_color) [!defined MSDOS]: Likewise.
7787
7788 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7789
7790 * coding.c: Remove vars that are set but not used.
7791 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7792 All callers changed.
7793 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7794 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7795 (decode_coding_charset): Remove vars that are set but not used.
7796
7797 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7798 that is set but not used.
7799
7800 * print.c (print_object): Remove var that is set but not used.
7801
7802 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7803 The gnulib version avoids calling malloc in the usual case,
7804 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7805 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7806 * filelock.c (current_lock_owner): Likewise.
7807 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7808 * sysdep.c: Include allocator.h, careadlinkat.h.
7809 (emacs_no_realloc_allocator): New static constant.
7810 (emacs_readlink): New function.
7811 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7812 ../lib/careadlinkat.h.
7813
7814 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7815
7816 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7817 first non-nil return value).
7818
7819 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7820
7821 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7822 if not defined (Bug#8403).
7823
7824 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7825
7826 * xdisp.c (display_count_lines): Remove parameter `start',
7827 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7828 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7829 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7830 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7831 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7832 and thereabouts. All callers changed.
7833 (get_per_char_metric): Remove parameter `f', unused since
7834 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7835
7836 2011-04-02 Jim Meyering <meyering@redhat.com>
7837
7838 do not dereference NULL upon failed strdup
7839 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7840 (ns_get_family): Likewise.
7841
7842 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7843
7844 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7845
7846 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7847
7848 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7849 later (Bug#8403).
7850
7851 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7852
7853 Add lexical binding.
7854
7855 * window.c (Ftemp_output_buffer_show): New fun.
7856 (Fsave_window_excursion):
7857 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7858
7859 * lread.c (lisp_file_lexically_bound_p): New function.
7860 (Fload): Bind Qlexical_binding.
7861 (readevalloop): Remove `evalfun' arg.
7862 Bind Qinternal_interpreter_environment.
7863 (Feval_buffer): Bind Qlexical_binding.
7864 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7865 Mark as dynamic.
7866 (syms_of_lread): Declare `lexical-binding'.
7867
7868 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7869
7870 * keyboard.c (eval_dyn): New fun.
7871 (menu_item_eval_property): Use it.
7872
7873 * image.c (parse_image_spec): Use Ffunctionp.
7874
7875 * fns.c (concat, mapcar1): Accept byte-code-functions.
7876
7877 * eval.c (Fsetq): Handle lexical vars.
7878 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7879 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7880 (FletX, Flet): Obey lexical binding.
7881 (Fcommandp): Handle closures.
7882 (Feval): New `lexical' arg.
7883 (eval_sub): New function extracted from Feval. Use it almost
7884 everywhere where Feval was used. Look up vars in lexical env.
7885 Handle closures.
7886 (Ffunctionp): Move from subr.el.
7887 (Ffuncall): Handle closures.
7888 (apply_lambda): Remove `eval_flags'.
7889 (funcall_lambda): Handle closures and new byte-code-functions.
7890 (Fspecial_variable_p): New function.
7891 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7892 but without exporting it to Lisp.
7893
7894 * doc.c (Fdocumentation, store_function_docstring):
7895 * data.c (Finteractive_form): Handle closures.
7896
7897 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7898 interactive spec.
7899
7900 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7901 New byte-codes.
7902 (exec_byte_code): New function extracted from Fbyte_code to handle new
7903 calling convention for byte-code-functions. Add new byte-codes.
7904
7905 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7906
7907 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7908
7909 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7910
7911 * xdisp.c (redisplay_internal): Fix prototype.
7912
7913 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7914
7915 * xdisp.c (SCROLL_LIMIT): New macro.
7916 (try_scrolling): Use it when setting scroll_limit.
7917 Limit scrolling to 100 screen lines.
7918 (redisplay_window): Even when falling back on "recentering",
7919 position point in the window according to scroll-conservatively,
7920 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7921
7922 (try_scrolling): When point is above the window, allow searching
7923 as far as scroll_max, or one screenful, to compute vertical
7924 distance from PT to the scroll margin position. This prevents
7925 try_scrolling from unnecessarily failing when
7926 scroll-conservatively is set to a value slightly larger than the
7927 window height. Clean up the case of PT below the margin at bottom
7928 of window: scroll_max can no longer be INT_MAX. When aggressive
7929 scrolling is in use, don't let point enter the opposite scroll
7930 margin as result of the scroll.
7931 (syms_of_xdisp) <scroll-conservatively>: Document the
7932 threshold of 100 lines for never-recentering scrolling.
7933
7934 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7935
7936 * dispextern.h (move_it_by_lines):
7937 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7938 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7939 (message_log_check_duplicate): Remove parameters `prev_bol' and
7940 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7941 (redisplay_internal): Remove parameter `preserve_echo_area',
7942 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7943
7944 * indent.c (Fvertical_motion):
7945 * window.c (window_scroll_pixel_based, Frecenter):
7946 Don't pass `need_y_p' to `move_it_by_lines'.
7947
7948 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7949
7950 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7951 steal a few bits to be more compact.
7952 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7953 Remove unneeded casts.
7954
7955 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7956
7957 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7958
7959 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7960 binding" message (bug#7967).
7961
7962 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7963
7964 Fix more problems found by GCC 4.6.0's static checks.
7965
7966 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7967 Remove unused local var.
7968
7969 * editfns.c (Fmessage_box): Remove unused local var.
7970
7971 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7972 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7973 Omit unused local vars.
7974 * window.c (shrink_windows): Omit unused local var.
7975 * menu.c (digest_single_submenu): Omit unused local var.
7976 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7977 Omit unused local var.
7978
7979 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7980 Don't assume string length fits in int.
7981 (keyremap_step, read_key_sequence): Use size_t for sizes.
7982 (read_key_sequence): Don't check last_real_key_start redundantly.
7983
7984 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7985 instead of alloca (Bug#8344).
7986
7987 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7988 (Fbacktrace_frame): Don't assume nframes fits in int.
7989
7990 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7991
7992 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7993 concerns.
7994
7995 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7996
7997 * cm.c (calccost): Turn while-do into do-while, for clarity.
7998
7999 * keyboard.c (syms_of_keyboard): Use the same style as later
8000 in this function when indexing through an array. This also
8001 works around GCC bug 48267.
8002
8003 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8004
8005 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8006
8007 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8008 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8009
8010 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8011 This avoids undefined behavior on integer overflow, and is a bit
8012 more convenient anyway since it is compared to a size_t variable.
8013
8014 Variadic C functions now count arguments with size_t, not int.
8015 This avoids an unnecessary limitation on 64-bit machines, which
8016 caused (substring ...) to crash on large vectors (Bug#8344).
8017 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8018 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8019 All variadic functions and their callers changed accordingly.
8020 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8021 * data.c (arith_driver, float_arith_driver): Likewise.
8022 * editfns.c (general_insert_function): Likewise.
8023 * eval.c (struct backtrace.nargs, interactive_p)
8024 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8025 (funcall_lambda, mark_backtrace): Likewise.
8026 * fns.c (concat): Likewise.
8027 * frame.c (x_set_frame_parameters): Likewise.
8028 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8029 0 if not found, not -1. All callers changed.
8030
8031 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8032 (stack_copy_size): Now size_t, not int.
8033 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8034
8035 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8036
8037 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8038 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8039 All callers changed.
8040
8041 * lisp.h (multibyte_char_to_unibyte):
8042 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8043 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8044 * character.h (CHAR_TO_BYTE8):
8045 * cmds.c (internal_self_insert):
8046 * editfns.c (general_insert_function):
8047 * keymap.c (push_key_description):
8048 * search.c (Freplace_match):
8049 * xdisp.c (message_dolog, set_message_1): All callers changed.
8050
8051 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8052
8053 * keyboard.c (safe_run_hook_funcall): New function.
8054 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8055 don't set the hook to nil, but remove the offending function instead.
8056 (Qcommand_hook_internal): Remove, unused.
8057 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8058 Vcommand_hook_internal.
8059
8060 * eval.c (enum run_hooks_condition): Remove.
8061 (funcall_nil, funcall_not): New functions.
8062 (run_hook_with_args): Call each function through a `funcall' argument.
8063 Remove `cond' argument, now redundant.
8064 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8065 (Frun_hook_with_args_until_failure): Adjust accordingly.
8066 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8067
8068 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8069
8070 * dispextern.h (string_buffer_position): Remove declaration.
8071
8072 * print.c (strout): Remove parameter `multibyte', unused since
8073 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8074
8075 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8076 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8077 All callers changed.
8078
8079 * w32.c (_wsa_errlist): Use braces for struct initializers.
8080
8081 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8082 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8083 All callers changed.
8084 (string_buffer_position): Likewise. Also, make static (it's never
8085 used outside xdisp.c).
8086 (cursor_row_p): Remove parameter `w', unused since
8087 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8088 (decode_mode_spec): Remove parameter `precision', introduced during
8089 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8090 All callers changed.
8091
8092 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8093
8094 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8095
8096 2011-03-27 Anders Lindgren <andlind@gmail.com>
8097
8098 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8099 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8100 (ns_update_auto_hide_menu_bar): New functions.
8101 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8102 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8103 ns_constrain_all_frames.
8104 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8105 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8106
8107 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8108
8109 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8110
8111 2011-03-27 Glenn Morris <rgm@gnu.org>
8112
8113 * syssignal.h: Replace RETSIGTYPE with void.
8114 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8115 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8116 Replace SIGTYPE with void everywhere.
8117 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8118 * s/template.h (SIGTYPE): Remove commented out definition.
8119
8120 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8121
8122 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8123 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8124
8125 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8126
8127 * w32.c (read_unc_volume): Use parameter `henum', instead of
8128 global variable `wget_enum_handle'.
8129
8130 * keymap.c (describe_vector): Remove parameters `indices' and
8131 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8132 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8133
8134 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8135
8136 * keyboard.c (timer_check): Remove parameter `do_it_now',
8137 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8138 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8139 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8140
8141 * keyboard.c (read_char):
8142 * w32menu.c (w32_menu_display_help):
8143 * xmenu.c (show_help_event, menu_help_callback):
8144 Adjust calls to `show_help_echo'.
8145
8146 * gtkutil.c (xg_maybe_add_timer):
8147 * keyboard.c (readable_events):
8148 * process.c (wait_reading_process_output):
8149 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8150
8151 * insdel.c (adjust_markers_gap_motion):
8152 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8153 (gap_left, gap_right): Don't call it.
8154
8155 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8156
8157 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8158 incurred during fontification.
8159
8160 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8161
8162 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8163 (DEFVAR_PER_BUFFER): Don't pass it.
8164
8165 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8166 (scrolling_window): Don't pass it.
8167
8168 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8169
8170 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8171
8172 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8173 and `suffix'.
8174 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8175 of variables specific to SELinux and computation of `encoded_absname'.
8176
8177 * image.c (XPutPixel): Remove unused variable `height'.
8178
8179 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8180
8181 * unexw32.c (get_section_info): Remove unused variable `section'.
8182
8183 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8184 (system_process_attributes): Remove unused variable `sess'.
8185 (sys_read): Remove unused variable `err'.
8186
8187 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8188 (w32_wnd_proc): Remove unused variable `isdead'.
8189 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8190 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8191 (x_create_tip_frame): Remove unused variable `tem'.
8192
8193 * w32inevt.c (w32_console_read_socket):
8194 Remove unused variable `no_events'.
8195
8196 * w32term.c (x_draw_composite_glyph_string_foreground):
8197 Remove unused variable `width'.
8198
8199 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8200
8201 * w32term.c (x_set_glyph_string_clipping):
8202 Don't pass uninitialized region to CombineRgn.
8203
8204 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8205
8206 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8207 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8208 (Fx_close_connection): Remove unused variable `i'.
8209
8210 * w32font.c (w32font_draw): Return number of glyphs.
8211 (w32font_open_internal): Remove unused variable `i'.
8212 (w32font_driver): Add missing initializer.
8213
8214 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8215 (fill_in_menu): Remove unused variable `items_added'.
8216
8217 * w32term.c (last_mouse_press_frame): Remove static global variable.
8218 (w32_clip_to_row): Remove unused variable `f'.
8219 (x_delete_terminal): Remove unused variable `i'.
8220
8221 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8222 (NOTHING): Remove unused static global variable.
8223 (uniscribe_check_otf): Remove unused variable `table'.
8224 (uniscribe_font_driver): Add missing initializers.
8225
8226 2011-03-23 Julien Danjou <julien@danjou.info>
8227
8228 * term.c (Fsuspend_tty, Fresume_tty):
8229 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8230 * window.c (temp_output_buffer_show):
8231 * insdel.c (signal_before_change):
8232 * frame.c (Fhandle_switch_frame):
8233 * fileio.c (Fdo_auto_save):
8234 * emacs.c (Fkill_emacs):
8235 * editfns.c (save_excursion_restore):
8236 * cmds.c (internal_self_insert):
8237 * callint.c (Fcall_interactively):
8238 * buffer.c (Fkill_all_local_variables):
8239 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8240 Use Frun_hooks.
8241 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8242 unconditionally since it does the check itself.
8243
8244 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8245
8246 Fix more problems found by GCC 4.5.2's static checks.
8247
8248 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8249 the first time through the loop, since we know p0 < p1 then.
8250 This also avoids a gcc -Wstrict-overflow warning.
8251
8252 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8253 leading to a memory leak, possible in functions like
8254 load_charset_map_from_file that can allocate an unbounded number
8255 of objects (Bug#8318).
8256
8257 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8258 that could (at least in theory) be that large.
8259
8260 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8261 This is less likely to overflow, and avoids undefined behavior if
8262 overflow does occur. All callers changed. Use strtoul to scan
8263 for the unsigned long integer.
8264 (pint2hrstr): Simplify and tune code slightly.
8265 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8266
8267 * scroll.c (do_scrolling): Work around GCC bug 48228.
8268 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8269
8270 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8271 This also avoids a warning with gcc -Wstrict-overflow.
8272 (validate_x_resource_name): Simplify count usage.
8273 This also avoids a warning with gcc -Wstrict-overflow.
8274
8275 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8276 fail (Bug#8306).
8277
8278 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8279
8280 * process.c (Fmake_network_process): Use socklen_t, not int,
8281 where POSIX says socklen_t is required in portable programs.
8282 This fixes a porting bug on hosts like 64-bit HP-UX, where
8283 socklen_t is wider than int (Bug#8277).
8284 (Fmake_network_process, server_accept_connection):
8285 (wait_reading_process_output, read_process_output):
8286 Likewise.
8287
8288 * process.c: Rename or move locals to avoid shadowing.
8289 (list_processes_1, Fmake_network_process):
8290 (read_process_output_error_handler, exec_sentinel_error_handler):
8291 Rename or move locals.
8292 (Fmake_network_process): Define label "retry_connect" only if needed.
8293 (Fnetwork_interface_info): Fix pointer signedness.
8294 (process_send_signal): Add cast to avoid pointer signedness problem.
8295 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8296 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8297
8298 Make tparam.h and terminfo.c consistent.
8299 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8300 Include tparam.h instead, since it declares them.
8301 * cm.h (PC): Remove extern decl; tparam.h now does this.
8302 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8303 * terminfo.c: Include tparam.h, to check interfaces.
8304 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8305 (tparam): Adjust signature to match interface in tparam.h;
8306 this removes some undefined behavior. Check that outstring and len
8307 are zero, which they always are with Emacs.
8308 * tparam.h (PC, BC, UP): New extern decls.
8309
8310 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8311 (xftfont_open): Rename locals to avoid shadowing.
8312
8313 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8314 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8315 (OTF_TAG_SYM): Omit macro if not needed.
8316 (ftfont_list): Remove unused local.
8317 (get_adstyle_property, ftfont_pattern_entity):
8318 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8319 Rename locals to avoid shadowing.
8320
8321 * xfont.c (xfont_list_family): Mark var as initialized.
8322
8323 * xml.c (make_dom): Now static.
8324
8325 * composite.c (composition_compute_stop_pos): Rename local to
8326 avoid shadowing.
8327 (composition_reseat_it): Remove unused locals.
8328 (find_automatic_composition, composition_adjust_point): Likewise.
8329 (composition_update_it): Mark var as initialized.
8330 (find_automatic_composition): Mark vars as initialized,
8331 with a FIXME (Bug#8290).
8332
8333 character.h: Rename locals to avoid shadowing.
8334 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8335 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8336 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8337 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8338 to avoid shadowing.
8339
8340 * textprop.c (property_change_between_p): Remove; unused.
8341
8342 * intervals.c (interval_start_pos): Now static.
8343
8344 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8345
8346 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8347 Rename locals to avoid shadowing.
8348
8349 * sound.c (wav_play, au_play, Fplay_sound_internal):
8350 Fix pointer signedness.
8351 (alsa_choose_format): Remove unused local var.
8352 (wav_play): Initialize a variable to 0, to prevent undefined
8353 behavior (Bug#8278).
8354
8355 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8356
8357 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8358
8359 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8360 clobbering (Bug#8298).
8361 * sysdep.c (sys_subshell): Likewise.
8362 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8363
8364 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8365 This should get cleaned up, so that child_setup has the
8366 same signature on all platforms.
8367
8368 * callproc.c (call_process_cleanup): Now static.
8369 (relocate_fd): Rename locals to avoid shadowing.
8370
8371 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8372
8373 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8374 not to be necessary, and produces flickering.
8375
8376 2011-03-20 Glenn Morris <rgm@gnu.org>
8377
8378 * config.in: Remove file.
8379
8380 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8381
8382 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8383 are now in src/globals.h.
8384 (syms_of_minibuf): Remove spurious & from previous change.
8385
8386 2011-03-20 Leo Liu <sdl.web@gmail.com>
8387
8388 * minibuf.c (completing-read-function): New variable.
8389 (completing-read-default): Rename from completing-read.
8390 (completing-read): Call completing-read-function.
8391
8392 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8393
8394 * xfaces.c (Fx_load_color_file):
8395 Read color file from absolute filename (bug#8250).
8396
8397 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8398
8399 * makefile.w32-in: Update dependencies.
8400
8401 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8402
8403 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8404
8405 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8406
8407 Fix more problems found by GCC 4.5.2's static checks.
8408
8409 * process.c (make_serial_process_unwind, send_process_trap):
8410 (sigchld_handler): Now static.
8411
8412 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8413 That way, the code declares only the vars that it needs.
8414 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8415 * s/cygwin.h (PTY_ITERATION): Likewise.
8416 * s/darwin.h (PTY_ITERATION): Likewise.
8417 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8418
8419 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8420 * process.c (allocate_pty): Don't declare stb unless it's needed.
8421
8422 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8423 (CONSTANTLIM): Remove; unused.
8424 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8425 Define only if needed.
8426
8427 * unexelf.c (unexec): Name an expression,
8428 to avoid gcc -Wbad-function-cast warning.
8429 Use a different way to cause a compilation error if anyone uses
8430 n rather than nn, a way that does not involve shadowing.
8431 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8432
8433 * deps.mk (unexalpha.o): Remove; unused.
8434
8435 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8436 * unexec.h: New file.
8437 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8438 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8439 Depend on unexec.h.
8440 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8441 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8442 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8443 Change as necessary to match prototype in unexec.h.
8444
8445 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8446 shadowing.
8447 (back_comment, skip_chars): Mark vars as initialized.
8448
8449 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8450 Rename locals to avoid shadowing.
8451
8452 * lread.c (read1): Rewrite so as not to use empty "else".
8453 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8454
8455 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8456
8457 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8458 warning when compiling print.c.
8459
8460 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8461 instead of using an uninitialized var.
8462 (font_sort_entities): Mark var as initialized.
8463
8464 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8465
8466 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8467 pointers to constants.
8468 (font_parse_fcname): Remove unused vars.
8469 (font_delete_unmatched): Now static.
8470 (font_get_spec): Remove; unused.
8471 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8472 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8473 Rename or move locals to avoid shadowing.
8474
8475 * fns.c (require_nesting_list, require_unwind): Now static.
8476 (Ffillarray): Rename locals to avoid shadowing.
8477
8478 * floatfns.c (domain_error2): Define only if needed.
8479 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8480
8481 * alloc.c (mark_backtrace): Move decl from here ...
8482 * lisp.h: ... to here, so that it can be checked.
8483
8484 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8485 (Fdefvar): Rewrite so as not to use empty "else".
8486 (lisp_indirect_variable): Name an expression,
8487 to avoid gcc -Wbad-function-cast warning.
8488 (Fdefvar): Rename locals to avoid shadowing.
8489
8490 * callint.c (quotify_arg, quotify_args): Now static.
8491 (Fcall_interactively): Rename locals to avoid shadowing.
8492 Use const pointer when appropriate.
8493
8494 * lisp.h (get_system_name, get_operating_system_release):
8495 Move decls here, to check interfaces.
8496 * process.c (get_operating_system_release): Move decl to lisp.h.
8497 * xrdb.c (get_system_name): Likewise.
8498 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8499 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8500 some of which prompt warnings from gcc -Wbad-function-cast.
8501 (Fformat_time_string, Fencode_time, Finsert_char):
8502 (Ftranslate_region_internal, Fformat):
8503 Rename or remove local vars to avoid shadowing.
8504 (Ftranslate_region_internal): Mark var as initialized.
8505
8506 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8507 avoid shadowing.
8508
8509 * lisp.h (eassert): Check that the argument compiles, even if
8510 ENABLE_CHECKING is not defined.
8511
8512 * data.c (Findirect_variable): Name an expression, to avoid
8513 gcc -Wbad-function-cast warning.
8514 (default_value, arithcompare, arith_driver, arith_error): Now static.
8515 (store_symval_forwarding): Rename local to avoid shadowing.
8516 (Fmake_variable_buffer_local, Fmake_local_variable):
8517 Mark variables as initialized.
8518 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8519
8520 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8521 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8522 Rename locals to avoid shadowing.
8523 (mark_stack): Move local variables into the #ifdef region where
8524 they're used.
8525 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8526 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8527 needed otherwise.
8528 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8529 (GC_STRING_CHARS): Remove; not used.
8530 (Fmemory_limit): Cast sbrk's returned value to char *.
8531
8532 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8533 avoids undefined behavior in theory.
8534
8535 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8536
8537 Use functions, not macros, for up- and down-casing (Bug#8254).
8538 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8539 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8540 to use the following functions instead of these macros.
8541 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8542 EMACS_INT, since callers assume the returned value fits in int.
8543 (upcase1): Likewise, for UPCASE_TABLE.
8544 (uppercasep, lowercasep, upcase): New static inline functions.
8545 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8546 the race-condition problem in the old DOWNCASE.
8547
8548 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8549 Rename locals to avoid shadowing.
8550 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8551 (regex_compile, re_search_2, re_match_2_internal):
8552 Remove unused local vars.
8553 (FREE_VAR): Rewrite so as not to use empty "else",
8554 which gcc can warn about.
8555 (regex_compile, re_match_2_internal): Mark locals as initialized.
8556 (RETALLOC_IF): Define only if needed.
8557 (WORDCHAR_P): Likewise. This one is never needed, but is used
8558 only in a comment talking about a compiler bug, so put inside
8559 the #if 0 of that comment.
8560 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8561 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8562 Remove; unused.
8563
8564 * search.c (boyer_moore): Rename locals to avoid shadowing.
8565 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8566 (PREV_CHAR_BOUNDARY): Likewise.
8567
8568 * search.c (simple_search): Remove unused var.
8569
8570 * dired.c (compile_pattern): Move decl from here ...
8571 * lisp.h: ... to here, so that it can be checked.
8572 (struct re_registers): New forward decl.
8573
8574 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8575
8576 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8577 All uses changed.
8578 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8579 Rename locals to avoid shadowing.
8580 (Fvertical_motion): Mark locals as initialized.
8581
8582 * casefiddle.c (casify_object, casify_region): Now static.
8583 (casify_region): Mark local as initialized.
8584
8585 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8586
8587 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8588 New macros, so that the caller can use some names other than
8589 gcpro1, gcpro2, etc.
8590 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8591 of the new macros.
8592 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8593 argument, for consistency with GCPRO2_VAR, etc: it is now the
8594 prefix of the variable, not the variable itself. All uses
8595 changed.
8596 * dired.c (directory_files_internal, file_name_completion):
8597 Rename locals to avoid shadowing.
8598
8599 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8600 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8601 dired.c's scmp function, had undefined behavior.
8602 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8603 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8604 * buffer.h: ... to here, because these macros use current_buffer,
8605 and the new implementation with inline functions needs to have
8606 current_buffer in scope now, rather than later when the macros
8607 are used.
8608 (downcase, upcase1): New static inline functions.
8609 (DOWNCASE, UPCASE1): Reimplement using these functions.
8610 This avoids undefined behavior in expressions like
8611 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8612 from race conditions in accessing the global variables
8613 case_temp1 and case_temp2.
8614 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8615 * lisp.h (case_temp1, case_temp2): Remove their decls.
8616 * character.h (ASCII_CHAR_P): Move from here ...
8617 * lisp.h: ... to here, so that the inline functions mentioned
8618 above can use them.
8619
8620 * dired.c (directory_files_internal_unwind): Now static.
8621
8622 * fileio.c (file_name_as_directory, directory_file_name):
8623 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8624 Now static.
8625 (file_name_as_directory): Use const pointers when appropriate.
8626 (Fexpand_file_name): Likewise. In particular, newdir might
8627 point at constant storage, so make it a const pointer.
8628 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8629 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8630 signedness issues.
8631 (Fset_file_times, Finsert_file_contents, auto_save_error):
8632 Rename locals to avoid shadowing.
8633
8634 * minibuf.c (choose_minibuf_frame_1): Now static.
8635 (Ftry_completion, Fall_completions): Rename or remove locals
8636 to avoid shadowing.
8637
8638 * marker.c (bytepos_to_charpos): Remove; unused.
8639
8640 * lisp.h (verify_bytepos, count_markers): New decls,
8641 so that gcc does not warn that these functions aren't declared.
8642
8643 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8644 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8645 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8646 (copy_text): Remove unused local var.
8647
8648 * filelock.c (within_one_second): Now static.
8649 (lock_file_1): Rename local to avoid shadowing.
8650
8651 * buffer.c (fix_overlays_before): Mark locals as initialized.
8652 (fix_start_end_in_overlays): Likewise. This function should be
8653 simplified by using pointers-to-pointers, but that's a different
8654 matter.
8655 (switch_to_buffer_1): Now static.
8656 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8657 (report_overlay_modification): Rename locals to avoid shadowing.
8658
8659 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8660 Fix pointer signedness issue.
8661 (sys_subshell): Mark local as volatile if checking for lint,
8662 to suppress a gcc -Wclobbered warning that does not seem to be right.
8663 (MAXPATHLEN): Define only if needed.
8664
8665 * process.c (serial_open, serial_configure): Move decls from here ...
8666 * systty.h: ... to here, so that they can be checked.
8667
8668 * fns.c (get_random, seed_random): Move extern decls from here ...
8669 * lisp.h: ... to here, so that they can be checked.
8670
8671 * sysdep.c (reset_io): Now static.
8672 (wait_for_termination_signal): Remove; unused.
8673
8674 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8675 (copy_keymap_item, append_key, push_text_char_description):
8676 Now static.
8677 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8678 (DENSE_TABLE_SIZE): Remove; unused.
8679 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8680 (describe_map_tree):
8681 Rename locals to avoid shadowing.
8682
8683 * keyboard.c: Declare functions static if they are not used elsewhere.
8684 (echo_char, echo_dash, cmd_error, top_level_2):
8685 (poll_for_input, handle_async_input): Now static.
8686 (read_char, kbd_buffer_get_event, make_lispy_position):
8687 (make_lispy_event, make_lispy_movement, apply_modifiers):
8688 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8689 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8690 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8691 (read_key_sequence, read_char): Mark locals as initialized.
8692 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8693
8694 * keyboard.h (make_ctrl_char): New decl.
8695 (mark_kboards): Move decl here ...
8696 * alloc.c (mark_kboards): ... from here.
8697
8698 * lisp.h (force_auto_save_soon): New decl.
8699
8700 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8701 (DEFINE_DUMMY_FUNCTION): New macro.
8702 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8703 Use it.
8704 (main): Add casts to avoid warnings
8705 if GCC considers string literals to be constants.
8706
8707 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8708
8709 * dbusbind.c: Pointer signedness fixes.
8710 (xd_signature, xd_append_arg, xd_initialize):
8711 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8713 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8714 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8715
8716 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8717 if GCC considers string literals to be constants.
8718 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8719
8720 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8721
8722 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8723 (print_preprocess, print_object): New macro to fix last change.
8724
8725 * print.c (print_preprocess): Don't forget font objects.
8726
8727 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8728
8729 * emacs.c (USAGE3): Doc fixes.
8730
8731 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8732
8733 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8734 structure.
8735
8736 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * lisp.h (VWindow_system, Qfile_name_history):
8739 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8740 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8741 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8742
8743 * w32select.c: Don't #include "keyboard.h".
8744 (run_protected): Add extern declaration for waiting_for_input.
8745
8746 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8747 * w32console.c (detect_input_pending, read_input_pending)
8748 (encode_terminal_code):
8749 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8750 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8751 (w32_system_caret_y, Qfile_name_history):
8752 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8753 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8754 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8755 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8756 * w32proc.c (Qlocal, report_file_error):
8757 * w32term.c (Vwindow_system, updating_frame):
8758 * w32uniscribe.c (initialized, uniscribe_font_driver):
8759 Remove unneeded extern declarations.
8760
8761 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8762
8763 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8764
8765 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8766
8767 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8768 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8769 These macros can no longer be used for assignment.
8770
8771 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8772 Assign struct members directly, instead of using BUF_BEGV etc.
8773 (record_buffer_markers, fetch_buffer_markers): New functions for
8774 recording and fetching special buffer markers.
8775 (set_buffer_internal_1, set_buffer_temp): Use them.
8776
8777 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8778
8779 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8780
8781 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8782 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8783
8784 * xdisp.c (hscroll_window_tree):
8785 (reconsider_clip_changes): Use PT instead of BUF_PT.
8786
8787 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8788
8789 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8790 $(EMACS_ROOT)/lib/intprops.h.
8791
8792 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8793
8794 Fix more problems found by GCC 4.5.2's static checks.
8795
8796 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8797 to unsigned char * to avoid compiler diagnostic.
8798 (xg_free_frame_widgets): Make it clear that a local variable is
8799 needed only if USE_GTK_TOOLTIP.
8800 (gdk_window_get_screen): Make it clear that this macro is needed
8801 only if USE_GTK_TOOLTIP.
8802 (int_gtk_range_get_value): New function, which avoids a diagnostic
8803 from gcc -Wbad-function-cast.
8804 (xg_set_toolkit_scroll_bar_thumb): Use it.
8805 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8806 diagnostic from gcc -Wbad-function-cast.
8807 (get_utf8_string, xg_get_file_with_chooser):
8808 Rename locals to avoid shadowing.
8809 (create_dialog): Move locals to avoid shadowing.
8810
8811 * xgselect.c (xg_select): Remove unused var.
8812
8813 * image.c (four_corners_best): Mark locals as initialized.
8814 (gif_load): Initialize transparent_p to zero (Bug#8238).
8815 Mark another local as initialized.
8816 (my_png_error, my_error_exit): Mark with NO_RETURN.
8817
8818 * image.c (clear_image_cache): Now static.
8819 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8820 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8821 (x_edge_detection): Remove unnecessary cast that
8822 gcc -Wbad-function-cast diagnoses.
8823 (gif_load): Fix pointer signedness.
8824 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8825 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8826
8827 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8828
8829 Improve quality of tests for time stamp overflow.
8830 For example, without this patch (encode-time 0 0 0 1 1
8831 1152921504606846976) returns the obviously-bogus value (-948597
8832 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8833 reports time overflow. See
8834 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8835 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8836 * editfns.c: Include limits.h and intprops.h.
8837 (TIME_T_MIN, TIME_T_MAX): New macros.
8838 (time_overflow): Move earlier, to before first use.
8839 (hi_time, lo_time): New functions, for an accurate test for
8840 out-of-range times.
8841 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8842 (Fget_internal_run_time): Don't assume time_t fits in int.
8843 (make_time): Use list2 instead of Fcons twice.
8844 (Fdecode_time): More accurate test for out-of-range times.
8845 (check_tm_member): New function.
8846 (Fencode_time): Use it, to test for out-of-range times.
8847 (lisp_time_argument): Don't rely on undefined left-shift and
8848 right-shift behavior when checking for time stamp overflow.
8849
8850 * editfns.c (time_overflow): New function, refactoring common code.
8851 (Fformat_time_string, Fdecode_time, Fencode_time):
8852 (Fcurrent_time_string): Use it.
8853
8854 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8855 * dired.c (make_time): Move to ...
8856 * editfns.c (make_time): ... here.
8857 * systime.h: Note the move.
8858
8859 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8860
8861 * fringe.c (update_window_fringes): Remove unused variables.
8862
8863 * unexmacosx.c (copy_data_segment): Also copy __got section.
8864 (Bug#8223)
8865
8866 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8867
8868 * termcap.c [MSDOS]: Include "msdos.h".
8869 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8870 Constify `char *' arguments and their references according to
8871 prototypes in tparam.h.
8872
8873 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8874
8875 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8876 Adapt all references accordingly.
8877
8878 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8879
8880 2011-03-11 Tom Tromey <tromey@redhat.com>
8881
8882 * buffer.c (syms_of_buffer): Remove obsolete comment.
8883
8884 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8885
8886 * termhooks.h (encode_terminal_code): Declare prototype.
8887
8888 * msdos.c (encode_terminal_code): Don't declare prototype.
8889
8890 * term.c (encode_terminal_code): Now external again, used by
8891 w32console.c and msdos.c.
8892
8893 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8894 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8895
8896 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8897
8898 Fix some minor problems found by GCC 4.5.2's static checks.
8899
8900 * fringe.c (update_window_fringes): Mark locals as initialized
8901 (Bug#8227).
8902 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8903
8904 * alloc.c (mark_fringe_data): Move decl from here ...
8905 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8906 to check its interface.
8907 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8908
8909 * fontset.c (free_realized_fontset): Now static.
8910 (Fset_fontset_font): Rename local to avoid shadowing.
8911 (fontset_font): Mark local as initialized.
8912 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8913
8914 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8915
8916 * xselect.c (x_disown_buffer_selections): Remove; not used.
8917 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8918 (x_own_selection, Fx_disown_selection_internal): Rename locals
8919 to avoid shadowing.
8920 (x_handle_dnd_message): Remove local to avoid shadowing.
8921
8922 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8923 so that the caller can use some name other than gcpro1.
8924 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8925 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8926 (Fx_backspace_delete_keys_p):
8927 Use them to avoid shadowing, and rename vars to avoid shadowing.
8928 (x_decode_color, x_set_name, x_window): Now static.
8929 (Fx_create_frame): Add braces to silence GCC warning.
8930 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8931 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8932 Remove unused locals.
8933 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8934 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8935 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8936 macros.
8937
8938 * xterm.h (x_mouse_leave): New decl.
8939
8940 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8941 Remove unused functions.
8942 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8943 (x_calc_absolute_position): Now static.
8944 (XTread_socket): Don't define label "out" unless it's used.
8945 Don't declare local "event" unless it's used.
8946 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8947 unless they are used.
8948 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8949 (x_fatal_error_signal): Remove; not used.
8950 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8951 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8952 (x_error_catcher, x_connection_closed, x_error_handler):
8953 (x_error_quitter, xembed_send_message, x_iconify_frame):
8954 (my_log_handler): Rename locals to avoid shadowing.
8955 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8956 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8957
8958 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8959 Rename or move locals to avoid shadowing.
8960 (tty_defined_color, merge_face_heights): Now static.
8961 (free_realized_faces_for_fontset): Remove; not used.
8962 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8963 does not deduce is never used uninitialized.
8964 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8965 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8966
8967 * terminal.c (store_terminal_param): Now static.
8968
8969 * xmenu.c (menu_highlight_callback): Now static.
8970 (set_frame_menubar): Remove unused local.
8971 (xmenu_show): Rename parameter to avoid shadowing.
8972 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8973 since they might point to immutable storage.
8974 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8975 since it's unused otherwise.
8976
8977 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8978 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8979 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8980 avoids a gcc -Wuninitialized diagnostic.
8981 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8982 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8983 does not deduce are never used uninitialized.
8984
8985 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8986
8987 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8988 * window.c (window_loop, size_window):
8989 (run_window_configuration_change_hook, enlarge_window): Likewise.
8990
8991 * window.c (display_buffer): Now static.
8992 (size_window): Mark variables that gcc -Wuninitialized
8993 does not deduce are never used uninitialized.
8994 * window.h (check_all_windows): New decl, to forestall
8995 gcc -Wmissing-prototypes diagnostic.
8996 * dispextern.h (bidi_dump_cached_states): Likewise.
8997
8998 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8999 shadowing.
9000 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9001 Include <limits.h>.
9002 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9003 and to avoid gcc -Wuninitialized warning.
9004 (load_charset_map): Mark variables that gcc -Wuninitialized
9005 does not deduce are never used uninitialized.
9006 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9007
9008 * coding.c (coding_set_source, coding_set_destination):
9009 Use "else { /* comment */ }" rather than "else /* comment */;"
9010 for clarity, and to avoid gcc -Wempty-body warning.
9011 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9012 a block, when the outer 'i' will do.
9013 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9014 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9015 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9016 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9017 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9018 Rename locals to avoid shadowing.
9019 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9020 * coding.c (emacs_mule_char, encode_invocation_designation):
9021 Now static, since they're not used elsewhere.
9022 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9023 (decode_coding_object, encode_coding_object, detect_coding_system):
9024 (decode_coding_emacs_mule): Mark variables that gcc
9025 -Wuninitialized does not deduce are never used uninitialized.
9026 (detect_coding_iso_2022): Initialize a local variable that might
9027 be used uninitialized. Leave a FIXME because it's not clear that
9028 this initialization is needed. (Bug#8211)
9029 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9030 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9031 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9032 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9033 Remove unused macros.
9034
9035 * category.c (hash_get_category_set): Remove unused local var.
9036 (copy_category_table): Now static, since it's not used elsewhere.
9037 * character.c (string_count_byte8): Likewise.
9038
9039 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9040 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9041
9042 * chartab.c (copy_sub_char_table): Now static, since it's not used
9043 elsewhere.
9044 (sub_char_table_ref_and_range, char_table_ref_and_range):
9045 Rename locals to avoid shadowing.
9046 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9047
9048 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9049 (BIDI_BOB): Remove unused macro.
9050
9051 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9052 deduce are never used uninitialized.
9053 * term.c (encode_terminal_code): Likewise.
9054
9055 * term.c (encode_terminal_code): Now static. Remove unused local.
9056
9057 * tparam.h: New file.
9058 * term.c, tparam.h: Include it.
9059 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9060 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9061 Move these decls to tparam.h, and make them agree with what
9062 is actually in tparam.c. The previous trick of using incompatible
9063 decls in different modules does not conform to the C standard.
9064 All callers of tparam changed to use tparam's actual API.
9065 * tparam.c (tparam1, tparam, tgoto):
9066 Use const pointers where appropriate.
9067
9068 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9069 * cm.h (struct cm): Likewise.
9070 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9071 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9072 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9073 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9074 (turn_on_face, init_tty): Likewise.
9075 * termchar.h (struct tty_display_info): Likewise.
9076
9077 * term.c (term_mouse_position): Rename local to avoid shadowing.
9078
9079 * alloc.c (mark_ttys): Move decl from here ...
9080 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9081
9082 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9083
9084 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9085
9086 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9087
9088 * search.c (compile_pattern_1): Remove argument regp, unused since
9089 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9090 (compile_pattern): Don't pass it.
9091
9092 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9093
9094 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9095 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9096 for ! HAVE_GTK3.
9097 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9098
9099 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9100
9101 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9102 gdk_window_get_screen, gdk_window_get_geometry,
9103 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9104 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9105 (xg_get_pixbuf_from_pixmap): New function.
9106 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9107 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9108 Call xg_get_pixbuf_from_pixmap instead of
9109 gdk_pixbuf_get_from_drawable.
9110 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9111 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9112 (xg_check_special_colors): Use GtkStyleContext and its functions
9113 for HAVE_GTK3.
9114 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9115 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9116 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9117 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9118 Call gtk_widget_get_preferred_size.
9119 (xg_frame_resized): gdk_window_get_geometry only takes 5
9120 parameters.
9121 (xg_win_to_widget, xg_event_is_for_menubar):
9122 Call gdk_x11_window_lookup_for_display.
9123 (xg_set_widget_bg): New function.
9124 (delete_cb): New function.
9125 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9126 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9127 (xg_set_background_color): Call xg_set_widget_bg.
9128 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9129 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9130 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9131 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9132 if ! HAVE_GTK3.
9133 (update_frame_tool_bar): Call gtk_widget_hide.
9134 (xg_initialize): Use GDK_KEY_g.
9135
9136 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9137 if ! HAVE_GTK3
9138 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9139
9140 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9141 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9142 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9143
9144 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9145
9146 * w32xfns.c (select_palette): Check success of RealizePalette against
9147 GDI_ERROR, not zero.
9148
9149 See ChangeLog.11 for earlier changes.
9150
9151 ;; Local Variables:
9152 ;; coding: utf-8
9153 ;; End:
9154
9155 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9156
9157 This file is part of GNU Emacs.
9158
9159 GNU Emacs is free software: you can redistribute it and/or modify
9160 it under the terms of the GNU General Public License as published by
9161 the Free Software Foundation, either version 3 of the License, or
9162 (at your option) any later version.
9163
9164 GNU Emacs is distributed in the hope that it will be useful,
9165 but WITHOUT ANY WARRANTY; without even the implied warranty of
9166 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9167 GNU General Public License for more details.
9168
9169 You should have received a copy of the GNU General Public License
9170 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.