1 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4 (Fx_get_selection_internal): Minor cleanup.
5 (Fx_own_selection_internal): Rename arguments for consistency with
8 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
14 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
16 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
18 * dispnew.c (scrolling_window): Don't exclude the case that the
19 last enabled row in the desired matrix touches the bottom boundary.
21 2011-05-21 Glenn Morris <rgm@gnu.org>
23 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
24 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
25 and add some more files.
27 2011-05-20 Eli Zaretskii <eliz@gnu.org>
29 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
30 report_file_error introduced by the change from 2011-05-07.
32 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
34 * systime.h (Time): Define only if emacs is defined.
35 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
36 where the include path doesn't have X11/X.h by default. See
37 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
39 2011-05-20 Kenichi Handa <handa@m17n.org>
41 * composite.c (find_automatic_composition): Fix previous change.
43 2011-05-20 Glenn Morris <rgm@gnu.org>
45 * lisp.mk: New file, split from Makefile.in.
46 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
48 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
50 2011-05-19 Glenn Morris <rgm@gnu.org>
52 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
53 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
54 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
55 (lisp): Set the order to that of loadup.el.
56 (shortlisp): Make it a copy of $lisp.
57 (SOME_MACHINE_LISP): Remove.
58 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
59 Use just $shortlisp, not $SOME_MACHINE_LISP too.
61 2011-05-18 Kenichi Handa <handa@m17n.org>
63 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
64 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
65 (find_automatic_composition): Mostly rewrite for efficiency.
67 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
69 * makefile.w32-in: Update dependencies.
71 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
73 * menu.c: Include limits.h (fixes the MS-Windows build broken by
76 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
78 Fix some integer overflow issues, such as string length overflow.
80 * insdel.c (count_size_as_multibyte): Check for string overflow.
82 * character.c (lisp_string_width): Check for string overflow.
83 Use EMACS_INT, not int, for string indexes and lengths; in
84 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
85 the resulting string length overflows an EMACS_INT; instead,
86 report a string overflow if no precision given. When checking for
87 precision exhaustion, use a check that cannot possibly have
88 integer overflow. (Bug#8675)
89 * character.h (lisp_string_width): Adjust to new signature.
91 * alloc.c (string_overflow): New function.
92 (Fmake_string): Use it. This doesn't change behavior, but saves
93 a few bytes and will simplify future changes.
94 * character.c (string_escape_byte8): Likewise.
95 * lisp.h (string_overflow): New decl.
97 Fixups, following up to the user-interface timestamp change.
98 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
99 for UI timestamps, instead of unsigned long.
100 * msdos.c (mouse_get_pos): Likewise.
101 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
102 * w32gui.h (Time): Define by including "systime.h" rather than by
103 declaring it ourselves. (Bug#8664)
105 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
106 * image.c (clear_image_cache): Likewise.
108 * term.c (term_mouse_position): Don't assume time_t wraparound.
110 Be more systematic about user-interface timestamps.
111 Before, the code sometimes used 'Time', sometimes 'unsigned long',
112 and sometimes 'EMACS_UINT', to represent these timestamps. This
113 change causes it to use 'Time' uniformly, as that's what X uses.
114 This makes the code easier to follow, and makes it easier to catch
115 integer overflow bugs such as Bug#8664.
116 * frame.c (Fmouse_position, Fmouse_pixel_position):
117 Use Time, not unsigned long, for user-interface timestamps.
118 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
119 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
120 * keyboard.h (last_event_timestamp): Likewise.
121 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
122 * menu.h (xmenu_show): Likewise.
123 * term.c (term_mouse_position): Likewise.
124 * termhooks.h (struct input_event.timestamp): Likewise.
125 (struct terminal.mouse_position_hook): Likewise.
126 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
127 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
128 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
129 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
131 * menu.h, termhooks.h: Include "systime.h", for Time.
133 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
134 Don't assume that the difference between two unsigned long values
135 can fit into an integer. At this point, we know button_down_time
136 <= event->timestamp, so the difference must be nonnegative, so
137 there's no need to cast the result if double-click-time is
138 nonnegative, as it should be; check that it's nonnegative, just in
139 case. This bug is triggered when events are more than 2**31 ms
140 apart (about 25 days). (Bug#8664)
142 * xselect.c (last_event_timestamp): Remove duplicate decl.
143 (x_own_selection): Remove needless cast to unsigned long.
145 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
146 that always fit in int. Use a sentinel instead of a counter, to
147 avoid a temp and to allay GCC's concerns about possible int overflow.
148 * frame.h (struct frame): Use int for menu_bar_items_used
149 instead of EMACS_INT, since it always fits in int.
151 * menu.c (grow_menu_items): Check for int overflow.
153 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
155 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
156 Before, the code was not consistent. These values cannot exceed
157 2**31 - 1 so there's no need to make them unsigned.
158 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
159 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
160 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
162 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
164 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
165 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
166 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
167 presumably because the widths might not match.
169 * window.c (size_window): Avoid needless test at loop start.
171 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
173 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
175 2011-05-12 Drew Adams <drew.adams@oracle.com>
177 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
179 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
181 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
182 `width' to `bar_area_x' and `bar_area_width', respectively.
183 (x_scroll_run): Take account of fringe background extension.
185 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
186 Rename local vars `left' and `width' to `bar_area_x' and
187 `bar_area_width', respectively.
188 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
189 background extension.
191 2011-05-10 Jim Meyering <meyering@redhat.com>
193 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
195 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
197 * image.c (Finit_image_library): Return t for built-in image types,
198 like pbm and xbm. (Bug#8640)
200 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
202 * w32menu.c (set_frame_menubar): Fix submenu allocation.
204 2011-05-07 Eli Zaretskii <eliz@gnu.org>
206 * w32console.c (Fset_screen_color): Doc fix.
207 (Fget_screen_color): New function.
208 (syms_of_ntterm): Defsubr it.
210 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
211 unlink the temporary file if Fcall_process didn't create it in the
213 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
214 child process will be redirected to a file specified with `:file'.
215 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
216 cue to call_process_cleanup not to close that handle.
218 2011-05-07 Ben Key <bkey76@gmail.com>
220 * makefile.w32-in: The bootstrap-temacs rule now makes use of
221 one of two shell specific rules, either bootstrap-temacs-CMD or
222 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
223 to the previous implementation of the bootstrap-temacs rule.
224 The bootstrap-temacs-CMD rule is similar to the previous
225 implementation of the bootstrap-temacs rule except that it
226 makes use of the ESC_CFLAGS variable instead of the CFLAGS
229 These changes, along with some changes to nt/configure.bat,
230 nt/gmake.defs, and nt/nmake.defs, are required to extend my
231 earlier fix to add support for --cflags and --ldflags options
232 that include quotes so that it works whether make uses cmd or
235 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
237 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
238 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
240 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
241 a string. Handle both cases.
242 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
243 (Fdbus_register_method): Use Qinvalid_function.
245 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
247 * makefile.w32-in: Update dependencies.
248 (LISP_H): Add inttypes.h and stdin.h.
249 (PROCESS_H): Add unistd.h.
251 2011-05-06 Eli Zaretskii <eliz@gnu.org>
253 * lread.c: Include limits.h (fixes the MS-Windows build broken by
254 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
256 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
258 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
260 * term.c (vfatal): Remove stray call to va_end.
261 It's not needed and the C Standard doesn't allow it here anyway.
263 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
264 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
266 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
269 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
273 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
275 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
277 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
279 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
280 * charset.c (Fdefine_charset_internal): Don't initialize
281 charset.code_space[15]. The value was garbage, on hosts with
282 32-bit int (Bug#8600).
284 * lread.c (read_integer): Be more consistent with string-to-number.
285 Use string_to_number to do the actual conversion; this avoids
286 rounding errors and fixes some other screwups. Without this fix,
287 for example, #x1fffffffffffffff was misread as -2305843009213693952.
288 (digit_to_number): Move earlier, for benefit of read_integer.
289 Return -1 if the digit is out of range for the base, -2 if it is
290 not a digit in any supported base. (Bug#8602)
292 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
294 * dispnew.c (scrolling_window): Return 1 if we scrolled,
295 to match comment at start of function. This also removes a
296 GCC warning about overflow in a 32+64-bit port.
298 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
300 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
301 Reported by Stefan Monnier in
302 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
304 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
306 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
307 (EMACS_UINTPTR): Likewise, with uintptr_t.
309 * lisp.h: Prefer 64-bit EMACS_INT if available.
310 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
311 on 32-bit hosts that have 64-bit int, so that they can access
313 However, temporarily disable this change unless the temporary
314 symbol WIDE_EMACS_INT is defined.
316 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
318 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
319 This removes an assumption that EMACS_INT and long are the same
320 width as pointers. The assumption is true for Emacs porting targets
321 now, but we want to make other targets possible.
322 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
323 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
324 In the rest of the code, change types of integers that hold casted
325 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
326 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
327 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
328 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
329 No need to cast type when ORing.
330 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
331 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
332 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
333 assume EMACS_INT is the same width as char *.
334 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
335 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
336 Remove no-longer-needed casts.
337 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
338 (xg_tool_bar_help_callback, xg_make_tool_item):
339 Use EMACS_INTPTR to hold an integer
340 that will be cast to void *; this can avoid a GCC warning
341 if EMACS_INT is not the same width as void *.
342 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
343 * xdisp.c (display_echo_area_1, resize_mini_window_1):
344 (current_message_1, set_message_1):
345 Use a local to convert to proper width without a cast.
346 * xmenu.c (dialog_selection_callback): Likewise.
348 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
349 Also, don't assume VALBITS / RAND_BITS is less than 5,
350 and don't rely on undefined behavior when shifting a 1 left into
352 * lisp.h (get_random): Change signature to match.
354 * lread.c (hash_string): Use size_t, not int, for hash computation.
355 Normally we prefer signed values; but hashing is special, because
356 it's better to use unsigned division on hash table sizes so that
357 the remainder is nonnegative. Also, size_t is the natural width
358 for hashing into memory. The previous code used 'int', which doesn't
359 retain enough info to hash well into very large tables.
360 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
362 * dbusbind.c: Don't possibly lose pointer info when converting.
363 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
364 Use XPNTR rather than XHASH, so that the high-order bits of
365 the pointer aren't lost when converting through void *.
367 * eval.c (Fautoload): Don't double-shift a pointer.
369 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
371 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
373 * gnutls.c (DEF_GNUTLS_FN):
374 * image.c (DEF_IMGLIB_FN): Make function pointers static.
376 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
378 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
381 2011-05-05 Eli Zaretskii <eliz@gnu.org>
383 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
384 New version that can reserve upto 2GB of heap space.
386 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
388 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
390 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
392 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
393 `gnutls_certificate_set_x509_key_file'.
395 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
397 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
400 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
402 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
403 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
404 Remove unused parameter `fildes'.
405 * process.c (read_process_output, send_process): Don't pass it.
407 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
409 Fix previous change: the library cache is defined in w32.c.
410 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
411 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
413 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
415 Implement dynamic loading of GnuTLS on Windows.
417 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
418 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
419 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
422 * gnutls.c (Qgnutls_dll): Define.
423 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
424 (gnutls_*): Declare function pointers.
425 (init_gnutls_functions): New function to initialize function pointers.
426 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
427 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
428 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
429 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
430 (emacs_gnutls_write, emacs_gnutls_read)
431 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
432 (Fgnutls_available_p): New function.
433 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
434 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
435 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
437 * image.c: Include w32.h.
438 (Vimage_type_cache): Delete.
439 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
440 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
441 (w32_delayed_load): Move to w32.c.
443 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
445 * w32.c (QCloaded_from, Vlibrary_cache): Define.
446 (w32_delayed_load): Move from image.c. When loading a library, record
447 its filename in the :loaded-from property of the library id.
448 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
449 Initialize and staticpro them.
450 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
452 * process.c: Include lisp.h before w32.h, not after.
453 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
454 instead of gnutls_record_check_pending.
456 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
458 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
460 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
461 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
464 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
466 * xterm.c (x_set_frame_alpha): Do not set property on anything
467 else than FRAME_X_OUTER_WINDOW (Bug#8608).
469 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
471 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
473 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
475 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
476 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
477 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
478 (gnutls_global_initialized, Qgnutls_bootprop_priority)
479 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
480 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
481 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
482 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
483 (Qgnutls_bootprop_callbacks_verify): Make static.
485 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
487 * callproc.c: Indentation fixup.
489 * sysdep.c (wait_for_termination_1): Make static.
490 (wait_for_termination, interruptible_wait_for_termination):
491 Move after wait_for_termination_1.
493 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
495 * sysdep.c (interruptible_wait_for_termination): New function
496 which is like wait_for_termination, but allows keyboard
499 * callproc.c (Fcall_process): Add (:file "file") as an option for
501 (Fcall_process_region): Ditto.
503 2011-04-30 Eli Zaretskii <eliz@gnu.org>
505 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
506 rather than `XVECTOR (FOO)->size'.
508 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
509 inttypes.h, as a gnulib replacement is used if it not available in
512 2011-04-21 Eli Zaretskii <eliz@gnu.org>
514 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
515 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
516 of MOST_POSITIVE_FIXNUM. (Bug#8528)
518 * coding.c (coding_alloc_by_realloc): Error out if destination
519 will grow beyond MOST_POSITIVE_FIXNUM.
520 (decode_coding_emacs_mule): Abort if there isn't enough place in
521 charbuf for the composition carryover bytes. Reserve an extra
522 space for up to 2 characters produced in a loop.
523 (decode_coding_iso_2022): Abort if there isn't enough place in
524 charbuf for the composition carryover bytes.
526 2011-04-21 Eli Zaretskii <eliz@gnu.org>
528 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
529 aborting when %lld or %lll format is passed.
530 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
531 %llo or %llx format is passed. (Bug#8545)
533 * window.c (window_scroll_line_based): Use a marker instead of
534 simple variables to record original value of point. (Bug#7952)
536 * doprnt.c (doprnt): Fix the case where a multibyte sequence
537 produced by %s or %c overflows available buffer space. (Bug#8545)
539 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
541 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
542 (SIZE_MAX): Move defn after all includes, as they might #define it.
544 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
546 * w32.c (init_environment): Warn about defaulting HOME to C:\.
548 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
550 * keyboard.c (Qdelayed_warnings_hook): Define.
551 (command_loop_1): Run `delayed-warnings-hook'
552 if Vdelayed_warnings_list is non-nil.
553 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
554 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
556 2011-04-28 Eli Zaretskii <eliz@gnu.org>
558 * doprnt.c (doprnt): Don't return value smaller than the buffer
559 size if the message was truncated. (Bug#8545).
561 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
563 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
564 (Fx_window_property): #if-0 the whole functions, not just the bodies.
566 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
568 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
570 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
572 * makefile.w32-in: Update dependencies.
574 2011-04-27 Eli Zaretskii <eliz@gnu.org>
576 Improve `doprnt' and its usage. (Bug#8545)
577 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
578 `format_end'. Remove support for %l as a conversion specifier.
579 Don't use xrealloc. Improve diagnostics when the %l size modifier
580 is used. Update the commentary.
582 * eval.c (verror): Simplify calculation of size_t.
584 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
587 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
589 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
592 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
594 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
595 This makes this file independent of the recent pseudovector change.
597 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
599 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
601 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
602 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
604 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
606 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
607 GCC 4.6.0 optimizes based on type-based alias analysis.
608 For example, if b is of type struct buffer * and v of type struct
609 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
610 != &v->size, and therefore "v->size = 1; b->size = 2; return
611 v->size;" must therefore return 1. This assumption is incorrect
612 for Emacs, since it type-puns struct Lisp_Vector * with many other
613 types. To fix this problem, this patch adds a new type struct
614 vectorlike_header that documents the constraints on layout of vectors
615 and pseudovectors, and helps optimizing compilers not get fooled
616 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
617 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
618 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
620 (XSETPVECTYPE): Rewrite in terms of new macro.
621 (XSETPVECTYPESIZE): New macro, specifying both type and size.
622 This is a bit clearer, and further avoids the possibility of
623 undesirable aliasing.
624 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
625 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
626 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
627 since Lisp_Subr is a special case (no "next" field).
628 (ASIZE): Now uses header.size rather than size.
629 All previous uses of XVECTOR (foo)->size replaced to use this macro,
630 to avoid the hassle of writing XVECTOR (foo)->header.size.
631 (struct vectorlike_header): New type.
632 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
633 object, to help avoid aliasing.
634 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
635 (SUBRP): Likewise, since Lisp_Subr is a special case.
636 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
637 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
638 (struct Lisp_Hash_Table): Combine first two members into a single
639 struct vectorlike_header member. All uses of "size" and "next" members
640 changed to be "header.size" and "header.next".
641 * buffer.h (struct buffer): Likewise.
642 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
643 * frame.h (struct frame): Likewise.
644 * process.h (struct Lisp_Process): Likewise.
645 * termhooks.h (struct terminal): Likewise.
646 * window.c (struct save_window_data, struct saved_window): Likewise.
647 * window.h (struct window): Likewise.
648 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
649 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
650 * buffer.c (init_buffer_once): Likewise.
651 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
653 * process.c (Fformat_network_address): Use local var for size,
656 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
658 Make the Lisp reader and string-to-float more consistent (Bug#8525)
659 * data.c (atof): Remove decl; no longer used or needed.
660 (digit_to_number): Move to lread.c.
661 (Fstring_to_number): Use new string_to_number function, to be
662 consistent with how the Lisp reader treats infinities and NaNs.
663 Do not assume that floating-point numbers represent EMACS_INT
664 without losing information; this is not true on most 64-bit hosts.
665 Avoid double-rounding errors, by insisting on integers when
666 parsing non-base-10 numbers, as the documentation specifies.
667 * lisp.h (string_to_number): New decl, replacing ...
668 (isfloat_string): Remove.
669 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
670 (read1): Do not accept +. and -. as integers; this
671 appears to have been a coding error. Similarly, do not accept
672 strings like +-1e0 as floating point numbers. Do not report
673 overflow for integer overflows unless the base is not 10 which
674 means we have no simple and reliable way to continue.
675 Break out the floating-point parsing into a new
676 function string_to_number, so that Fstring_to_number parses
677 floating point numbers consistently with the Lisp reader.
678 (digit_to_number): Move here from data.c. Make it static inline.
679 (E_CHAR, EXP_INT): Remove, replacing with ...
680 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
681 (string_to_number): New function, replacing isfloat_string.
682 This function checks for valid syntax and produces the resulting
683 Lisp float number too. Rework it so that string-to-number
684 no longer mishandles examples like "1.0e+". Use strtoumax,
685 so that overflow for non-base-10 numbers is reported only when
686 there's no portable and simple way to convert to floating point.
688 * textprop.c (set_text_properties_1): Rewrite for clarity,
689 and to avoid GCC warning about integer overflow.
691 * intervals.h (struct interval): Use EMACS_INT for members
692 where EMACS_UINT might cause problems. See
693 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
694 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
695 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
697 (offset_intervals): Tell GCC not to worry about length overflow
698 when negating a negative length.
700 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
701 (overrun_check_free): Likewise.
703 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
704 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
707 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
708 (gnutls_make_error): Rename local to avoid shadowing.
709 (gnutls_emacs_global_deinit): ifdef out; not used.
710 (Fgnutls_boot): Use const for pointer to readonly storage.
711 Comment out unused local. Fix pointer signedness problems.
713 * lread.c (openp): Don't stuff size_t into an 'int'.
714 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
715 about possible signed overflow.
717 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
718 (GDK_KEY_g): Don't define if already defined.
719 (xg_prepare_tooltip): Avoid pointer signedness problem.
720 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
722 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
723 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
725 * xfns.c (Fx_window_property): Simplify a bit,
726 to make a bit faster and to avoid GCC 4.6.0 warning.
727 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
729 * fns.c (internal_equal): Don't assume size_t fits in int.
731 * alloc.c (compact_small_strings): Tighten assertion a little.
733 Replace pEd with more-general pI, and fix some printf arg casts.
734 * lisp.h (pI): New macro, generalizing old pEd macro to other
735 conversion specifiers. For example, use "...%"pI"d..." rather
737 (pEd): Remove. All uses replaced with similar uses of pI.
738 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
739 * alloc.c (check_pure_size): Don't overflow by converting size to int.
740 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
741 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
742 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
743 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
744 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
746 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
747 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
748 * print.c (safe_debug_print, print_object): Likewise.
749 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
751 Use pI instead of if-then-else-abort. Use %p to avoid casts,
752 avoiding the 0 flag, which is not portable.
753 * process.c (Fmake_network_process): Use pI to avoid cast.
754 * region-cache.c (pp_cache): Likewise.
755 * xdisp.c (decode_mode_spec): Likewise.
756 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
757 behavior on 64-bit hosts with printf arg.
758 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
759 (x_stop_queuing_selection_requests): Likewise.
760 (x_get_window_property): Don't truncate byte count to an 'int'
763 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
764 here, since it parses constructs like leading '-' and spaces,
765 which are not wanted; and it overflows with large numbers.
766 Instead, simply match F[0-9]+, which is what is wanted anyway.
768 * alloc.c: Remove unportable assumptions about struct layout.
769 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
770 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
771 (allocate_vectorlike, make_pure_vector): Use the new macros,
772 plus offsetof, to remove unportable assumptions about struct layout.
773 These assumptions hold on all porting targets that I know of, but
774 they are not guaranteed, they're easy to remove, and removing them
775 makes further changes easier.
777 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
778 This doesn't fix a bug but makes the code clearer.
779 (string_overrun_cookie): Now const. Use initializers that
780 don't formally overflow signed char, to avoid warnings.
781 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
782 can cause Emacs to crash when string overrun checking is enabled.
783 (allocate_buffer): Don't assume sizeof (struct buffer) is a
784 multiple of sizeof (EMACS_INT); it need not be, if
785 alignof(EMACS_INT) < sizeof (EMACS_INT).
786 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
788 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
790 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
792 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
794 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
795 supposed to be handshaking. (Bug#8556)
796 Reported by Paul Eggert <eggert@cs.ucla.edu>.
798 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
800 * lisp.h (Qdebug): List symbol.
801 * eval.c (Qdebug): Restore global linkage.
802 * keyboard.c (debug-on-event): New variable.
803 (handle_user_signal): Break into debugger when debug-on-event
804 matches the current signal symbol.
806 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
808 * alloc.c (check_sblock, check_string_bytes)
809 (check_string_free_list): Convert to standard C.
811 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
813 * w32.c (emacs_gnutls_push): Fix typo.
815 2011-04-25 Eli Zaretskii <eliz@gnu.org>
817 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
818 "cast to pointer from integer of different size".
820 Improve doprnt and its use in verror. (Bug#8545)
821 * doprnt.c (doprnt): Document the set of format control sequences
822 supported by the function. Use SAFE_ALLOCA instead of always
825 * eval.c (verror): Don't limit the buffer size at size_max-1, that
826 is one byte too soon. Don't use xrealloc; instead xfree and
829 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
831 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
834 * gnutls.c: Renamed global_initialized to
835 gnutls_global_initialized. Added internals for the
836 :verify-hostname-error, :verify-error, and :verify-flags
837 parameters of `gnutls-boot' and documented those parameters in the
838 docstring. Start callback support.
839 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
840 unless a fatal error occured. Call gnutls_alert_send_appropriate
841 on error. Return error code.
842 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
843 (emacs_gnutls_read): Likewise.
844 (Fgnutls_boot): Return handshake error code.
845 (emacs_gnutls_handle_error): New function.
846 (wsaerror_to_errno): Likewise.
848 * w32.h (emacs_gnutls_pull): Add prototype.
849 (emacs_gnutls_push): Likewise.
851 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
852 (emacs_gnutls_push): Likewise.
854 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
856 * process.c (wait_reading_process_output): Check if GnuTLS
857 buffered some data internally if no FDs are set for TLS
860 * makefile.w32-in (OBJ2): Add gnutls.$(O).
861 (LIBS): Link to USER_LIBS.
862 ($(BLD)/gnutls.$(0)): New target.
864 2011-04-24 Eli Zaretskii <eliz@gnu.org>
866 * xdisp.c (handle_single_display_spec): Rename the
867 display_replaced_before_p argument into display_replaced_p, to
868 make it consistent with the commentary. Fix typos in the
871 * textprop.c (syms_of_textprop): Remove dead code.
872 (copy_text_properties): Delete obsolete commentary about an
873 interface that was deleted long ago. Fix typos in the description
876 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
877 to changes in oldXMenu/XMenu.h from 2011-04-16.
878 <menu_help_message, prev_menu_help_message>: Constify.
879 (IT_menu_make_room): menu->help_text is now `const char **';
882 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
883 to changes in oldXMenu/XMenu.h from 2011-04-16.
884 (struct XMenu): Declare `help_text' `const char **'.
886 * xfaces.c <Qunspecified>: Make extern again.
888 * syntax.c: Include sys/types.h before including regex.h, as
891 * doc.c (get_doc_string): Improve the format passed to `error'.
893 * doprnt.c (doprnt): Improve commentary.
895 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
897 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
900 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
901 changes in globals.h immediately force recompilation.
902 (TAGS): Depend on $(CURDIR)/m/intel386.h and
903 $(CURDIR)/s/ms-w32.h.
904 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
906 * character.c (Fchar_direction): Function deleted.
907 (syms_of_character): Don't defsubr it.
908 <char-direction-table>: Deleted.
910 2011-04-23 Eli Zaretskii <eliz@gnu.org>
912 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
913 * doprnt.c: Include limits.h.
914 (SIZE_MAX): New macro.
915 (doprnt): Return a size_t value. 2nd arg is now size_t.
916 Many local variables are now size_t instead of int or unsigned.
917 Improve overflow protection. Support `l' modifier for integer
918 conversions. Support %l conversion. Don't assume an EMACS_INT
919 argument for integer conversions and for %c.
921 * lisp.h (doprnt): Restore prototype.
923 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
926 * Makefile.in (base_obj): Add back doprnt.o.
928 * deps.mk (doprnt.o): Add back prerequisites.
929 (callint.o): Depend on character.h.
931 * eval.c (internal_lisp_condition_case): Include the handler
932 representation in the error message.
933 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
934 when breaking from the loop.
936 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
938 * callint.c (Fcall_interactively): When displaying error message
939 about invalid control letter, pass the character's codepoint, not
940 a pointer to its multibyte form. Improve display of the character
941 in octal and display also its hex code.
943 * character.c (char_string): Use %x to display the (unsigned)
944 codepoint of an invalid character, to avoid displaying a bogus
947 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
948 `error', not SYMBOL_NAME itself.
950 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
951 character arguments to `error'.
953 * charset.c (check_iso_charset_parameter): Fix incorrect argument
954 to `error' in error message about FINAL_CHAR argument. Make sure
955 FINAL_CHAR is a character, and use %c when it is passed as
958 2011-04-23 Eli Zaretskii <eliz@gnu.org>
960 * s/ms-w32.h (localtime): Redirect to sys_localtime.
962 * w32.c: Include <time.h>.
963 (sys_localtime): New function.
965 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
967 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
969 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
971 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
973 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
976 2011-04-19 Eli Zaretskii <eliz@gnu.org>
978 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
979 gl_state.e_property when gl_state.object is Qt.
981 * insdel.c (make_gap_larger): Remove limitation of buffer size
984 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
986 * xdisp.c (lookup_glyphless_char_display)
987 (produce_glyphless_glyph): Handle cons cell entry in
988 glyphless-char-display.
989 (Vglyphless_char_display): Document it.
991 * term.c (produce_glyphless_glyph): Handle cons cell entry in
992 glyphless-char-display.
994 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
996 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
998 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1000 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1001 definition for no-X builds.
1003 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1005 Static checks with GCC 4.6.0 and non-default toolkits.
1007 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1009 * process.c (keyboard_bit_set): Define only if SIGIO.
1010 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1011 (send_process): Repair possible setjmp clobbering.
1013 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1015 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1017 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1019 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1020 Define only if needed.
1022 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1023 by pacifying GCC about it. Maybe it's time to retire it?
1024 * xfaces.c (USG, __TIMEVAL__): Likewise.
1026 * dispextern.h (struct redisplay_interface): Rename param
1028 * termhooks.h (struct terminal): Likewise.
1029 * xterm.c (xembed_send_message): Likewise.
1031 * insdel.c (make_gap_smaller): Define only if
1032 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1034 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1037 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1038 so that we aren't warned about unused symbols.
1040 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1042 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1044 * xfns.c (x_real_positions): Mark locals as initialized.
1046 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1048 * xterm.c: Fix problems found by static analysis with other toolkits.
1049 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1050 (x_dispatch_event): Declare static if USE_GTK, and
1051 define if USE_GTK || USE_X_TOOLKIT.
1052 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1053 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1054 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1055 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1057 * xmenu.c (menu_help_callback): Pointer type fixes.
1058 Use const pointers when pointing at readonly data. Avoid pointer
1060 (FALSE): Remove unused macro.
1061 (update_frame_menubar): Remove unused decl.
1063 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1065 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1066 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1067 (single_menu_item): Rename local to avoid shadowing.
1069 * keyboard.c (make_lispy_event): Remove unused local var.
1071 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1072 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1074 * bitmaps: Change bitmaps from unsigned char back to the X11
1075 compatible char. Avoid the old compiler warnings about
1076 out-of-range initializers by using, for example, '\xab' rather
1079 * xgselect.c (xgselect_initialize): Check vs interface
1080 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1082 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1084 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1085 to read-only memory.
1087 * fns.c (vector): Remove; this old hack is no longer needed.
1089 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1091 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1093 * xrdb.c (x_load_resources): Omit unused local.
1095 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1096 (x_window): Rename locals to avoid shadowing.
1097 (USG): Use the kludged USG macro, to pacify gcc.
1099 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1100 (x_term_init): Remove local to avoid shadowing.
1102 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1104 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1105 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1107 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1109 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1111 Fix regex.c, syntax.c and friends for buffers > 2GB.
1112 * syntax.h (struct gl_state_s): Declare character position members
1115 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1117 * textprop.c (verify_interval_modification, interval_of):
1118 Declare arguments EMACS_INT.
1120 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1123 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1125 * indent.c (Fvertical_motion): Local variable it_start is now
1128 * regex.c (re_match, re_match_2, re_match_2_internal)
1129 (bcmp_translate, regcomp, regexec, print_double_string)
1130 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1131 (re_compile_pattern, re_exec): Declare arguments and local
1132 variables `size_t' and `ssize_t' and return values `regoff_t', as
1134 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1135 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1136 <compile_stack_type>: `size' and `avail' are now `size_t'.
1138 * regex.h <regoff_t>: Use ssize_t, not int.
1139 (re_search, re_search_2, re_match, re_match_2): Arguments that
1140 specify buffer/string position and length are now ssize_t and
1141 size_t. Return type is regoff_t.
1143 2011-04-16 Ben Key <bkey76@gmail.com>
1145 * nsfont.m: Fixed bugs in ns_get_family and
1146 ns_descriptor_to_entity that were caused by using free to
1147 deallocate memory blocks that were allocated by xmalloc (via
1148 xstrdup). This caused Emacs to crash when compiled with
1149 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1150 --enable-checking=xmallocoverrun). xfree is now used to
1151 deallocate these memory blocks.
1153 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1155 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1157 emacs_write: Accept and return EMACS_INT for sizes.
1158 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1160 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1161 Accept and return EMACS_INT.
1162 (emacs_gnutls_write): Return the number of bytes written on
1164 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1165 (emacs_read, emacs_write): Remove check for negative size, as the
1166 Emacs source code has been audited now.
1167 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1168 (emacs_read, emacs_write): Use it.
1169 * process.c (send_process): Adjust to the new signatures of
1170 emacs_write and emacs_gnutls_write. Do not attempt to store
1171 a byte offset into an 'int'; it might overflow.
1172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1174 * sound.c: Don't assume sizes fit in 'int'.
1175 (struct sound_device.period_size, alsa_period_size):
1176 Return EMACS_INT, not int.
1177 (struct sound_device.write, vox_write, alsa_write):
1178 Accept EMACS_INT, not int.
1179 (wav_play, au_play): Use EMACS_INT to store sizes and to
1180 record read return values.
1182 2011-04-15 Ben Key <bkey76@gmail.com>
1184 * keyboard.c (Qundefined): Don't declare static since it is used
1186 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1187 static since they are used in nsfont.m.
1189 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1191 * process.c (Qprocessp): Don't declare static.
1192 * lisp.h (Qprocessp): Declare again.
1194 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1196 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1198 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1200 Improve C-level modularity by making more things 'static'.
1202 Don't publish debugger-only interfaces to other modules.
1203 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1204 (verify_bytepos, count_markers): Move decls to the only modules
1206 * region-cache.h (pp_cache): Likewise.
1207 * window.h (check_all_windows): Likewise.
1208 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1210 * sysdep.c (croak): Now static, if
1211 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1212 * syssignal.h (croak): Declare only if not static.
1214 * alloc.c (refill_memory_reserve): Now static if
1215 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1216 * lisp.h (refill_memory_reserve): Declare only if not static.
1218 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1219 Define only if USE_LUCID.
1221 * xrdb.c (x_customization_string, x_rm_string): Now static.
1223 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1224 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1226 * xdisp.c (draw_row_with_mouse_face): Now static.
1227 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1229 * window.h (check_all_windows): Mark externally visible.
1231 * window.c (window_deletion_count): Now static.
1233 * undo.c: Make symbols static if they're not exported.
1234 (last_undo_buffer, last_boundary_position, pending_boundary):
1237 * textprop.c (interval_insert_behind_hooks): Now static.
1238 (interval_insert_in_front_hooks): Likewise.
1240 * term.c: Make symbols static if they're not exported.
1241 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1242 (max_frame_lines, tty_set_terminal_modes):
1243 (tty_reset_terminal_modes, tty_turn_off_highlight):
1244 (get_tty_terminal): Now static.
1245 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1246 * termhooks.h (term_mouse_moveto): Do not declare if
1248 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1249 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1251 * sysdep.c: Make symbols static if they're not exported.
1252 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1254 (sigprocmask_set, full_mask): Remove; unused.
1255 (wait_debugging): Mark as visible.
1256 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1257 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1259 * syntax.c (syntax_temp): Define only if !__GNUC__.
1261 * sound.c (current_sound_device, current_sound): Now static.
1263 * search.c (searchbufs, searchbuf_head): Now static.
1265 * scroll.c (scroll_cost): Remove; unused.
1266 * dispextern.h (scroll_cost): Remove decl.
1268 * region-cache.h (pp_cache): Mark as externally visible.
1270 * process.c: Make symbols static if they're not exported.
1271 (process_tick, update_tick, create_process, chan_process):
1272 (Vprocess_alist, proc_buffered_char, datagram_access):
1273 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1274 (deactivate_process): Mark defn as static, as well as decl.
1275 * lisp.h (create_process): Remove decl.
1276 * process.h (chan_process, Vprocess_alist): Remove decls.
1278 * print.c: Make symbols static if they're not exported.
1279 (print_depth, new_backquote_output, being_printed, print_buffer):
1280 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1281 (print_interval, print_number_index, initial_stderr_stream):
1283 * lisp.h (Fprinc): Remove decl.
1284 (debug_output_compilation_hack): Mark as externally visible.
1286 * sysdep.c (croak): Move decl from here to syssignal.h.
1287 * syssignal.h (croak): Put it here, so the API can be checked when
1288 'croak' is called from dissociate_if_controlling_tty.
1290 * minibuf.c: Make symbols static if they're not exported.
1291 (minibuf_save_list, choose_minibuf_frame): Now static.
1292 * lisp.h (choose_minibuf_frame): Remove decl.
1294 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1296 * lread.c: Make symbols static if they're not exported.
1297 (read_objects, initial_obarray, oblookup_last_bucket_number):
1299 (make_symbol): Remove; unused.
1300 * lisp.h (initial_obarray, make_symbol): Remove decls.
1302 * keyboard.c: Make symbols static if they're not exported.
1303 (single_kboard, recent_keys_index, total_keys, recent_keys):
1304 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1305 (this_single_command_key_start, echoing, last_auto_save):
1306 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1307 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1308 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1309 (Vlispy_mouse_stem, double_click_count):
1311 (force_auto_save_soon): Define only if SIGDANGER.
1312 (ignore_mouse_drag_p): Now static if
1313 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1314 (print_help): Remove; unused.
1315 (stop_character, last_timer_event): Mark as externally visible.
1316 * keyboard.h (ignore_mouse_drag_p): Declare only if
1317 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1318 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1319 * lisp.h (echoing): Remove decl.
1320 (force_auto_save_soon): Declare only if SIGDANGER.
1321 * xdisp.c (redisplay_window): Simplify code, to make it more
1322 obvious that ignore_mouse_drag_p is not accessed if !defined
1323 USE_GTK && !defined HAVE_NS.
1325 * intervals.c: Make symbols static if they're not exported.
1326 (merge_properties_sticky, merge_interval_right, delete_interval):
1328 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1330 * insdel.c: Make symbols static if they're not exported.
1331 However, leave prepare_to_modify_buffer alone. It's never
1332 called from outside this function, but that appears to be a bug.
1333 (combine_after_change_list, combine_after_change_buffer):
1334 (adjust_after_replace, signal_before_change): Now static.
1335 (adjust_after_replace_noundo): Remove; unused.
1336 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1337 (signal_before_change): Remove decls.
1339 * indent.c (val_compute_motion, val_vmotion): Now static.
1341 * image.c: Make symbols static if they're not exported.
1342 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1344 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1345 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1347 * fringe.c (standard_bitmaps): Now static.
1348 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1350 * frame.c: Make symbols static if they're not exported.
1351 (x_report_frame_params, make_terminal_frame): Now static.
1352 (get_frame_param): Now static, unless HAVE_NS.
1353 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1354 (x_get_resource_string): Remove; not used.
1355 * frame.h (make_terminal_frame, x_report_frame_params):
1356 (x_get_resource_string); Remove decls.
1357 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1358 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1360 * font.c, fontset.c: Make symbols static if they're not exported.
1361 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1362 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1363 * font.c (font_close_object): Now static.
1364 * font.h (font_close_object): Remove.
1365 * fontset.c (FONTSET_OBJLIST): Remove.
1366 (free_realized_fontset) #if-0 the body, which does nothing.
1367 (face_suitable_for_char_p): #if-0, as it's never called.
1368 * fontset.h (face_suitable_for_char_p): Remove decl.
1369 * xfaces.c (face_at_string_position):
1370 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1371 since 0 is always ASCII.
1373 * fns.c (weak_hash_tables): Now static.
1375 * fileio.c: Make symbols static if they're not exported.
1376 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1377 (Vwrite_region_annotation_buffers): Now static.
1379 * eval.c: Make symbols static if they're not exported.
1380 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1381 * lisp.h (backtrace_list): Remove decl.
1383 * emacs.c: Make symbols static if they're not exported.
1384 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1385 (fatal_error_code, fatal_error_signal_hook, standard_args):
1387 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1388 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1389 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1390 * lisp.h (fatal_error_signal_hook): Remove decl.
1391 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1393 * editfns.c: Move a (normally-unused) function to its only use.
1394 * editfns.c, lisp.h (get_operating_system_release): Remove.
1395 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1396 worth the hassle of breaking this out.
1398 * xterm.c: Make symbols static if they're not exported.
1399 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1400 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1401 (x_destroy_window, x_delete_display):
1403 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1404 (x_mouse_leave): Remove; unused.
1405 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1406 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1407 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1409 (x_mouse_leave): Declare only if WINDOWSNT.
1410 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1411 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1414 * ftxfont.c: Make symbols static if they're not exported.
1415 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1417 * font.h (ftxfont_driver): Likewise.
1419 * xfns.c: Make symbols static if they're not exported.
1420 (x_last_font_name, x_display_info_for_name):
1421 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1422 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1423 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1424 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1425 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1426 (last_show_tip_args): Now static.
1427 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1428 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1429 (x_screen_planes): Remove; unused.
1430 * dispextern.h (x_screen_planes): Remove decl.
1432 * dispnew.c: Make symbols static if they're not exported.
1433 * dispextern.h (redraw_garbaged_frames, scrolling):
1434 (increment_row_positions): Remove.
1435 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1436 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1438 (redraw_garbaged_frames): Remove; unused.
1440 * xfaces.c: Make symbols static if they're not exported.
1441 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1443 * xterm.h (defined_color): Remove decls.
1444 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1445 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1446 (menu_face_changed_default, defined_color, free_realized_face):
1447 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1448 (ascii_face_of_lisp_face): Remove; unused.
1450 * xdisp.c: Make symbols static if they're not exported.
1451 * dispextern.h (scratch_glyph_row, window_box_edges):
1452 (glyph_to_pixel_coords, set_cursor_from_row):
1453 (get_next_display_element, set_iterator_to_next):
1454 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1455 (show_mouse_face): Remove decls
1456 * frame.h (message_buf_print): Likewise.
1457 * lisp.h (pop_message, set_message, check_point_in_composition):
1459 * xterm.h (set_vertical_scroll_bar): Likewise.
1460 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1461 (message_buf_print, scratch_glyph_row, displayed_buffer):
1462 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1463 (get_next_display_element, show_mouse_face, window_box_edges):
1464 (frame_to_window_pixel_xy, check_point_in_composition):
1465 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1466 (glyph_to_pixel_coords): Remove; unused.
1468 * dired.c (file_name_completion): Now static.
1470 * dbusbind.c (xd_in_read_queued_messages): Now static.
1472 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1473 * data.c (circular_list_error): Remove.
1475 * commands.h (last_point_position, last_point_position_buffer):
1476 (last_point_position_window): Remove decls.
1477 * keyboard.c: Make these variables static.
1479 * coding.h (coding, code_convert_region, encode_coding_gap):
1481 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1482 (iso_code_class, detect_coding, code_convert_region): Now static.
1483 (encode_coding_gap): Remove; unused.
1485 * chartab.c (chartab_chars, chartab_bits): Now static.
1487 * charset.h (charset_iso_8859_1): Remove decl.
1488 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1491 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1492 * ccl.c (Vccl_program_table): Now static.
1493 (check_ccl_update): Remove; unused.
1495 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1496 * category.h: ... from here.
1497 * category.c (check_category_table, set_category_set): Now static.
1499 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1500 * lisp.h: Remove these decls.
1502 * buffer.c (buffer_count): Remove unused var.
1504 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1505 so that it's not optimized away.
1506 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1507 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1508 exported only to the debugger.
1510 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1511 * atimer.h (run_all_atimers): Remove; not exported.
1513 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1514 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1515 was inaccessible from Lisp.
1516 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1517 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1519 alloc.c: Import and export fewer symbols, and remove unused items.
1520 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1522 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1523 it's not optimized away by whole-program optimization.
1524 (message_enable_multibyte, free_misc): Remove.
1525 (catchlist, handlerlist, mark_backtrace):
1526 Declare only if BYTE_MARK_STACK.
1527 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1528 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1529 (message_enable_multibyte): Remove decl.
1530 (free_misc, interval_free_list, float_block, float_block_index):
1531 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1532 (cons_free_list, last_marked_index):
1534 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1535 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1536 (mark_backtrace): Define only if BYTE_MARK_STACK.
1537 * xdisp.c (message_enable_multibyte): Now static.
1539 Declare Lisp_Object Q* variables to be 'static' if not exported.
1540 This makes it easier for human readers (and static analyzers)
1541 to see whether these variables are used from other modules.
1542 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1543 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1544 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1545 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1546 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1547 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1548 * xmenu.c, xselect.c:
1549 Declare Q* vars static if they are not used in other modules.
1550 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1551 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1552 Remove decls of unexported vars.
1553 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1555 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1557 Make Emacs functions such as Fatom 'static' by default.
1558 This makes it easier for human readers (and static analyzers)
1559 to see whether these functions can be called from other modules.
1560 DEFUN now defines a static function. To make the function external
1561 so that it can be used in other C modules, use the new macro DEFUE.
1562 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1563 (Finit_image_library):
1564 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1565 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1566 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1567 Remove decls, since these functions are now static.
1568 (Funintern, Fget_internal_run_time): New decls, since these functions
1569 were already external.
1571 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1572 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1573 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1574 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1575 * keyboard.c, keymap.c, lread.c:
1576 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1577 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1578 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1579 Mark functions with DEFUE instead of DEFUN,
1580 if they are used in other modules.
1581 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1582 decls for now-static functions.
1583 * buffer.h (Fdelete_overlay): Remove decl.
1584 * callproc.c (Fgetenv_internal): Mark as internal.
1585 * composite.c (Fremove_list_of_text_properties): Remove decl.
1586 (Fcomposition_get_gstring): New forward static decl.
1587 * composite.h (Fcomposite_get_gstring): Remove decl.
1588 * dired.c (Ffile_attributes): New forward static decl.
1589 * doc.c (Fdocumntation_property): New forward static decl.
1590 * eval.c (Ffetch_bytecode): New forward static decl.
1591 (Funintern): Remove extern decl; now in .h file where it belongs.
1592 * fileio.c (Fmake_symbolic_link): New forward static decl.
1593 * image.c (Finit_image_library): New forward static decl.
1594 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1595 * intervals.h (Fprevious_property_change):
1596 (Fremove_list_of_text_properties): Remove decls.
1597 * keyboard.c (Fthis_command_keys): Remove decl.
1598 (Fcommand_execute): New forward static decl.
1599 * keymap.c (Flookup_key): New forward static decl.
1600 (Fcopy_keymap): Now static.
1601 * keymap.h (Flookup_key): Remove decl.
1602 * process.c (Fget_process): New forward static decl.
1603 (Fprocess_datagram_address): Mark as internal.
1604 * syntax.c (Fsyntax_table_p): New forward static decl.
1605 (skip_chars): Remove duplicate decl.
1606 * textprop.c (Fprevious_property_change): New forward static decl.
1607 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1609 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1610 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1612 * editfns.c (Fformat): Remove unreachable code.
1614 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1616 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1619 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1621 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1622 when at ZV. (Bug#8487)
1624 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1626 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1628 * keyboard.c (parse_tool_bar_item): Likewise.
1629 * sound.c (sound_cleanup, alsa_close): Likewise.
1630 * termcap.c (tgetent): Likewise.
1631 * xfns.c (x_default_font_parameter): Likewise.
1632 * xsettings.c (read_and_apply_settings): Likewise.
1634 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1635 (overrun_check_free): Protoize.
1637 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1639 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1640 since callers should never pass a negative size.
1641 Change the signature to match that of plain 'read' and 'write'; see
1642 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1643 * lisp.h: Update prototypes of emacs_write and emacs_read.
1645 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1647 * xdisp.c (redisplay_window): Don't try to determine the character
1648 position of the scroll margin if the window start point w->startp
1649 is outside the buffer's accessible region. (Bug#8468)
1651 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1653 Fix write-region and its subroutines for buffers > 2GB.
1654 * fileio.c (a_write, e_write): Modify declaration of arguments and
1655 local variables to support buffers larger than 2GB.
1656 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1658 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1659 argument, local variables, and return value.
1661 * lisp.h: Update prototypes of emacs_write and emacs_read.
1663 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1665 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1667 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1669 Fix more problems found by GCC 4.6.0's static checks.
1671 * xdisp.c (vmessage): Use a better test for character truncation.
1673 * charset.c (load_charset_map): <, not <=, for optimization,
1674 and to avoid potential problems with integer overflow.
1675 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1676 * casetab.c (set_identity, shuffle): Likewise.
1677 * editfns.c (Fformat): Likewise.
1678 * syntax.c (skip_chars): Likewise.
1680 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1681 This also lets GCC 4.6.0 generate slightly better loop code.
1683 * callint.c (Fcall_interactively): <, not <=, for optimization.
1684 (Fcall_interactively): Count the number of arguments produced,
1685 not the number of arguments given. This is simpler and lets GCC
1686 4.6.0 generate slightly better code.
1688 * ftfont.c: Distingish more carefully between FcChar8 and char.
1689 The previous code passed unsigned char * to a functions like
1690 strlen and xstrcasecmp that expect char *, which does not
1691 conform to the C standard.
1692 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1693 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1694 char * when the C standard requires it.
1696 * keyboard.c (read_char): Remove unused var.
1698 * eval.c: Port to Windows vsnprintf (Bug#8435).
1700 (SIZE_MAX): Define if the headers do not.
1701 (verror): Do not give up if vsnprintf returns a negative count.
1702 Instead, grow the buffer. This ports to Windows vsnprintf, which
1703 does not conform to C99. Problem reported by Eli Zaretskii.
1704 Also, simplify the allocation scheme, by avoiding the need for
1705 calling realloc, and removing the ALLOCATED variable.
1707 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1709 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1710 But keep the doprint source code for now, as we might revamp it
1711 and use it again (Bug#8435).
1712 * lisp.h (doprnt): Remove.
1713 * Makefile.in (base_obj): Remove doprnt.o.
1714 * deps.mk (doprnt.o): Remove.
1716 error: Print 32- and 64-bit integers portably (Bug#8435).
1717 Without this change, on typical 64-bit hosts error ("...%d...", N)
1718 was used to print both 32- and 64-bit integers N, which relied on
1720 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1722 * lisp.h (error, verror): Mark as printf-like functions.
1723 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1724 Report overflow in size calculations when allocating printf buffer.
1725 Do not truncate output string at its first null byte.
1726 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1727 Truncate the output at a character boundary, since vsnprintf does not
1729 * charset.c (check_iso_charset_parameter): Convert internal
1730 character to string before calling 'error', since %c now has the
1732 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1733 overflow when computing char to be passed to 'error'. Do not
1734 pass Lisp_Object to 'error'; pass the integer instead.
1735 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1736 formatted with plain %d.
1738 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1740 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1742 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1744 * xterm.c (x_catch_errors): Remove duplicate declaration.
1746 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1748 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1750 2011-04-10 Jim Meyering <meyering@redhat.com>
1752 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1753 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1754 return ssize_t not "int", and use size_t as the buffer length.
1755 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1756 * gnutls.h: Update declarations.
1757 * process.c (read_process_output): Use ssize_t, to match.
1758 (send_process): Likewise.
1760 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1762 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1764 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1766 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1767 Use unsigned char, to match FcChar8 type definition.
1769 * xterm.c (handle_one_xevent):
1770 * xmenu.c (create_and_show_popup_menu):
1771 * xselect.c (x_decline_selection_request)
1772 (x_reply_selection_request): Avoid type-punned deref of X events.
1774 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1776 Fix some uses of `int' instead of EMACS_INT.
1777 * search.c (string_match_1, fast_string_match)
1778 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1779 (scan_buffer, find_next_newline_no_quit)
1780 (find_before_next_newline, search_command, Freplace_match)
1781 (Fmatch_data): Make some `int' variables be EMACS_INT.
1783 * xdisp.c (display_count_lines): 3rd argument and return value now
1784 EMACS_INT. All callers changed.
1785 (pint2hrstr): Last argument is now EMACS_INT.
1787 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1788 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1789 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1790 (decode_coding_utf_16, decode_coding_emacs_mule)
1791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1792 (decode_coding_ccl, decode_coding_charset)
1793 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1794 (decode_coding_iso_2022, decode_coding_emacs_mule)
1795 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1796 <char_offset, last_offset>: Declare EMACS_INT.
1797 (encode_coding_utf_8, encode_coding_utf_16)
1798 (encode_coding_emacs_mule, encode_invocation_designation)
1799 (encode_designation_at_bol, encode_coding_iso_2022)
1800 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1801 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1803 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1804 (encode_invocation_designation): Last argument P_NCHARS is now
1806 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1807 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1809 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1812 * ccl.c (Fccl_execute_on_string): Declare some variables
1815 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1817 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1819 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1821 * process.c (Fformat_network_address): Doc fix.
1823 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1825 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1827 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1829 * keyboard.c (read_char): Call Lisp function help-form-show,
1830 instead of using internal_with_output_to_temp_buffer.
1831 (Qhelp_form_show): New var.
1832 (syms_of_keyboard): Use DEFSYM macro.
1834 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1836 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1838 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1840 * process.c (Flist_processes): Remove to Lisp.
1841 (list_processes_1): Delete.
1843 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1845 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1847 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1849 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1851 Fix more problems found by GCC 4.6.0's static checks.
1853 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1855 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1857 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1859 * xdisp.c (vmessage): Mark as a printf-like function.
1861 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1863 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1865 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1866 printf-like functions.
1867 (tiff_load): Add casts to remove these marks before passing them
1868 to system-supplied API.
1870 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1872 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1873 This avoids several warnings with gcc -Wstrict-overflow.
1874 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1875 directly, rather than having caller test rule sign. This avoids
1876 some unnecessary tests.
1877 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1878 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1879 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1881 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1882 (xfont_open): Avoid unnecessary tests.
1884 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1886 * composite.h, composite.c (composition_gstring_put_cache):
1887 Use EMACS_INT, not int, for length.
1889 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1890 breaking out part of COMPOSITION_DECODE_RULE.
1891 (COMPOSITION_DECODE_RULE): Use it.
1892 * composite.c (get_composition_id): Remove unused local vars,
1893 by using the new macro.
1895 * textprop.c (set_text_properties_1): Change while to do-while,
1896 since the condition is always true at first.
1898 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1899 (interval_deletion_adjustment): Return unsigned value.
1902 * process.c (list_processes_1, create_pty, read_process_output):
1903 (exec_sentinel): Remove vars that were set but not used.
1904 (create_pty): Remove unnecessary "volatile"s.
1905 (Fnetwork_interface_info): Avoid possibility of int overflow.
1906 (read_process_output): Do adaptive read buffering even if carryover.
1907 (read_process_output): Simplify nbytes computation if buffered.
1909 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1911 * syntax.c (scan_words): Remove var that was set but not used.
1912 (update_syntax_table): Use unsigned instead of int.
1914 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1915 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1916 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1918 * print.c (print_error_message): Avoid int overflow.
1920 * font.c (font_list_entities): Redo for clarity,
1921 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1923 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1924 (font_score): Avoid potential overflow in diff calculation.
1926 * fns.c (substring_both): Remove var that is set but not used.
1927 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1929 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1931 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1932 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1933 can always succeed if overflow has undefined behavior.
1935 * search.c (boyer_moore, wordify): Remove vars set but not used.
1936 (wordify): Omit three unnecessary tests.
1938 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1939 All callers changed. This avoids the need for an unused var.
1941 * casefiddle.c (casify_region): Remove var that is set but not used.
1943 * dired.c (file_name_completion): Remove var that is set but not used.
1945 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1947 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1948 (Finsert_file_contents): Remove unnecessary code checking fd.
1950 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1951 Check for integer overflow on size calculations.
1953 * buffer.c (Fprevious_overlay_change): Remove var that is set
1956 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1957 Remove vars that are set but not used.
1958 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1959 (timer_check_2): Mark vars as initialized.
1961 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1963 * image.c (lookup_image): Remove var that is set but not used.
1964 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1966 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1967 that are set but not used.
1969 * xfns.c (make_invisible_cursor): Don't return garbage
1970 if XCreateBitmapFromData fails (Bug#8410).
1972 * xselect.c (x_get_local_selection, x_handle_property_notify):
1973 Remove vars that are set but not used.
1975 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1976 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1978 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1979 Remove var that is set but not used.
1980 (scroll_bar_windows_size): Now size_t, not int.
1981 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1984 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1985 (map_tty_color) [!defined MSDOS]: Likewise.
1987 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1989 * coding.c: Remove vars that are set but not used.
1990 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1991 All callers changed.
1992 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1993 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1994 (decode_coding_charset): Remove vars that are set but not used.
1996 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1997 that is set but not used.
1999 * print.c (print_object): Remove var that is set but not used.
2001 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2002 The gnulib version avoids calling malloc in the usual case,
2003 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2004 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2005 * filelock.c (current_lock_owner): Likewise.
2006 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2007 * sysdep.c: Include allocator.h, careadlinkat.h.
2008 (emacs_no_realloc_allocator): New static constant.
2009 (emacs_readlink): New function.
2010 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2011 ../lib/careadlinkat.h.
2013 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2015 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2016 first non-nil return value).
2018 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2020 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2021 if not defined (Bug#8403).
2023 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2025 * xdisp.c (display_count_lines): Remove parameter `start',
2026 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2027 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2028 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2029 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2030 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2031 and thereabouts. All callers changed.
2032 (get_per_char_metric): Remove parameter `f', unused since
2033 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2035 2011-04-02 Jim Meyering <meyering@redhat.com>
2037 do not dereference NULL upon failed strdup
2038 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2039 (ns_get_family): Likewise.
2041 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2043 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2045 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2047 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2050 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2052 Add lexical binding.
2054 * window.c (Ftemp_output_buffer_show): New fun.
2055 (Fsave_window_excursion):
2056 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2058 * lread.c (lisp_file_lexically_bound_p): New function.
2059 (Fload): Bind Qlexical_binding.
2060 (readevalloop): Remove `evalfun' arg.
2061 Bind Qinternal_interpreter_environment.
2062 (Feval_buffer): Bind Qlexical_binding.
2063 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2065 (syms_of_lread): Declare `lexical-binding'.
2067 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2069 * keyboard.c (eval_dyn): New fun.
2070 (menu_item_eval_property): Use it.
2072 * image.c (parse_image_spec): Use Ffunctionp.
2074 * fns.c (concat, mapcar1): Accept byte-code-functions.
2076 * eval.c (Fsetq): Handle lexical vars.
2077 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2078 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2079 (FletX, Flet): Obey lexical binding.
2080 (Fcommandp): Handle closures.
2081 (Feval): New `lexical' arg.
2082 (eval_sub): New function extracted from Feval. Use it almost
2083 everywhere where Feval was used. Look up vars in lexical env.
2085 (Ffunctionp): Move from subr.el.
2086 (Ffuncall): Handle closures.
2087 (apply_lambda): Remove `eval_flags'.
2088 (funcall_lambda): Handle closures and new byte-code-functions.
2089 (Fspecial_variable_p): New function.
2090 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2091 but without exporting it to Lisp.
2093 * doc.c (Fdocumentation, store_function_docstring):
2094 * data.c (Finteractive_form): Handle closures.
2096 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2099 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2101 (exec_byte_code): New function extracted from Fbyte_code to handle new
2102 calling convention for byte-code-functions. Add new byte-codes.
2104 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2106 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2108 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2110 * xdisp.c (redisplay_internal): Fix prototype.
2112 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (SCROLL_LIMIT): New macro.
2115 (try_scrolling): Use it when setting scroll_limit.
2116 Limit scrolling to 100 screen lines.
2117 (redisplay_window): Even when falling back on "recentering",
2118 position point in the window according to scroll-conservatively,
2119 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2121 (try_scrolling): When point is above the window, allow searching
2122 as far as scroll_max, or one screenful, to compute vertical
2123 distance from PT to the scroll margin position. This prevents
2124 try_scrolling from unnecessarily failing when
2125 scroll-conservatively is set to a value slightly larger than the
2126 window height. Clean up the case of PT below the margin at bottom
2127 of window: scroll_max can no longer be INT_MAX. When aggressive
2128 scrolling is in use, don't let point enter the opposite scroll
2129 margin as result of the scroll.
2130 (syms_of_xdisp) <scroll-conservatively>: Document the
2131 threshold of 100 lines for never-recentering scrolling.
2133 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2135 * dispextern.h (move_it_by_lines):
2136 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2137 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2138 (message_log_check_duplicate): Remove parameters `prev_bol' and
2139 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2140 (redisplay_internal): Remove parameter `preserve_echo_area',
2141 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2143 * indent.c (Fvertical_motion):
2144 * window.c (window_scroll_pixel_based, Frecenter):
2145 Don't pass `need_y_p' to `move_it_by_lines'.
2147 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2149 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2150 steal a few bits to be more compact.
2151 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2152 Remove unneeded casts.
2154 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2156 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2158 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2159 binding" message (bug#7967).
2161 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2163 Fix more problems found by GCC 4.6.0's static checks.
2165 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2166 Remove unused local var.
2168 * editfns.c (Fmessage_box): Remove unused local var.
2170 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2171 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2172 Omit unused local vars.
2173 * window.c (shrink_windows): Omit unused local var.
2174 * menu.c (digest_single_submenu): Omit unused local var.
2175 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2176 Omit unused local var.
2178 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2179 Don't assume string length fits in int.
2180 (keyremap_step, read_key_sequence): Use size_t for sizes.
2181 (read_key_sequence): Don't check last_real_key_start redundantly.
2183 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2184 instead of alloca (Bug#8344).
2186 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2187 (Fbacktrace_frame): Don't assume nframes fits in int.
2189 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2191 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2194 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2196 * cm.c (calccost): Turn while-do into do-while, for clarity.
2198 * keyboard.c (syms_of_keyboard): Use the same style as later
2199 in this function when indexing through an array. This also
2200 works around GCC bug 48267.
2202 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2204 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2206 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2207 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2209 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2210 This avoids undefined behavior on integer overflow, and is a bit
2211 more convenient anyway since it is compared to a size_t variable.
2213 Variadic C functions now count arguments with size_t, not int.
2214 This avoids an unnecessary limitation on 64-bit machines, which
2215 caused (substring ...) to crash on large vectors (Bug#8344).
2216 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2218 All variadic functions and their callers changed accordingly.
2219 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2220 * data.c (arith_driver, float_arith_driver): Likewise.
2221 * editfns.c (general_insert_function): Likewise.
2222 * eval.c (struct backtrace.nargs, interactive_p)
2223 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2224 (funcall_lambda, mark_backtrace): Likewise.
2225 * fns.c (concat): Likewise.
2226 * frame.c (x_set_frame_parameters): Likewise.
2227 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2228 0 if not found, not -1. All callers changed.
2230 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2231 (stack_copy_size): Now size_t, not int.
2232 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2234 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2236 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2237 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2238 All callers changed.
2240 * lisp.h (multibyte_char_to_unibyte):
2241 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2242 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2243 * character.h (CHAR_TO_BYTE8):
2244 * cmds.c (internal_self_insert):
2245 * editfns.c (general_insert_function):
2246 * keymap.c (push_key_description):
2247 * search.c (Freplace_match):
2248 * xdisp.c (message_dolog, set_message_1): All callers changed.
2250 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2252 * keyboard.c (safe_run_hook_funcall): New function.
2253 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2254 don't set the hook to nil, but remove the offending function instead.
2255 (Qcommand_hook_internal): Remove, unused.
2256 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2257 Vcommand_hook_internal.
2259 * eval.c (enum run_hooks_condition): Remove.
2260 (funcall_nil, funcall_not): New functions.
2261 (run_hook_with_args): Call each function through a `funcall' argument.
2262 Remove `cond' argument, now redundant.
2263 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2264 (Frun_hook_with_args_until_failure): Adjust accordingly.
2265 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2267 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2269 * dispextern.h (string_buffer_position): Remove declaration.
2271 * print.c (strout): Remove parameter `multibyte', unused since
2272 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2274 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2275 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2276 All callers changed.
2278 * w32.c (_wsa_errlist): Use braces for struct initializers.
2280 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2281 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2282 All callers changed.
2283 (string_buffer_position): Likewise. Also, make static (it's never
2284 used outside xdisp.c).
2285 (cursor_row_p): Remove parameter `w', unused since
2286 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2287 (decode_mode_spec): Remove parameter `precision', introduced during
2288 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2289 All callers changed.
2291 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2293 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2295 2011-03-27 Anders Lindgren <andlind@gmail.com>
2297 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2298 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2299 (ns_update_auto_hide_menu_bar): New functions.
2300 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2301 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2302 ns_constrain_all_frames.
2303 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2304 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2306 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2308 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2310 2011-03-27 Glenn Morris <rgm@gnu.org>
2312 * syssignal.h: Replace RETSIGTYPE with void.
2313 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2314 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2315 Replace SIGTYPE with void everywhere.
2316 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2317 * s/template.h (SIGTYPE): Remove commented out definition.
2319 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2321 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2322 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2324 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2326 * w32.c (read_unc_volume): Use parameter `henum', instead of
2327 global variable `wget_enum_handle'.
2329 * keymap.c (describe_vector): Remove parameters `indices' and
2330 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2331 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2333 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2335 * keyboard.c (timer_check): Remove parameter `do_it_now',
2336 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2337 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2338 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2340 * keyboard.c (read_char):
2341 * w32menu.c (w32_menu_display_help):
2342 * xmenu.c (show_help_event, menu_help_callback):
2343 Adjust calls to `show_help_echo'.
2345 * gtkutil.c (xg_maybe_add_timer):
2346 * keyboard.c (readable_events):
2347 * process.c (wait_reading_process_output):
2348 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2350 * insdel.c (adjust_markers_gap_motion):
2351 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2352 (gap_left, gap_right): Don't call it.
2354 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2356 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2357 incurred during fontification.
2359 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2361 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2362 (DEFVAR_PER_BUFFER): Don't pass it.
2364 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2365 (scrolling_window): Don't pass it.
2367 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2369 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2371 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2373 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2374 of variables specific to SELinux and computation of `encoded_absname'.
2376 * image.c (XPutPixel): Remove unused variable `height'.
2378 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2380 * unexw32.c (get_section_info): Remove unused variable `section'.
2382 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2383 (system_process_attributes): Remove unused variable `sess'.
2384 (sys_read): Remove unused variable `err'.
2386 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2387 (w32_wnd_proc): Remove unused variable `isdead'.
2388 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2389 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2390 (x_create_tip_frame): Remove unused variable `tem'.
2392 * w32inevt.c (w32_console_read_socket):
2393 Remove unused variable `no_events'.
2395 * w32term.c (x_draw_composite_glyph_string_foreground):
2396 Remove unused variable `width'.
2398 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2400 * w32term.c (x_set_glyph_string_clipping):
2401 Don't pass uninitialized region to CombineRgn.
2403 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2405 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2406 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2407 (Fx_close_connection): Remove unused variable `i'.
2409 * w32font.c (w32font_draw): Return number of glyphs.
2410 (w32font_open_internal): Remove unused variable `i'.
2411 (w32font_driver): Add missing initializer.
2413 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2414 (fill_in_menu): Remove unused variable `items_added'.
2416 * w32term.c (last_mouse_press_frame): Remove static global variable.
2417 (w32_clip_to_row): Remove unused variable `f'.
2418 (x_delete_terminal): Remove unused variable `i'.
2420 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2421 (NOTHING): Remove unused static global variable.
2422 (uniscribe_check_otf): Remove unused variable `table'.
2423 (uniscribe_font_driver): Add missing initializers.
2425 2011-03-23 Julien Danjou <julien@danjou.info>
2427 * term.c (Fsuspend_tty, Fresume_tty):
2428 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2429 * window.c (temp_output_buffer_show):
2430 * insdel.c (signal_before_change):
2431 * frame.c (Fhandle_switch_frame):
2432 * fileio.c (Fdo_auto_save):
2433 * emacs.c (Fkill_emacs):
2434 * editfns.c (save_excursion_restore):
2435 * cmds.c (internal_self_insert):
2436 * callint.c (Fcall_interactively):
2437 * buffer.c (Fkill_all_local_variables):
2438 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2440 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2441 unconditionnaly since it does the check itself.
2443 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2445 Fix more problems found by GCC 4.5.2's static checks.
2447 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2448 the first time through the loop, since we know p0 < p1 then.
2449 This also avoids a gcc -Wstrict-overflow warning.
2451 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2452 leading to a memory leak, possible in functions like
2453 load_charset_map_from_file that can allocate an unbounded number
2454 of objects (Bug#8318).
2456 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2457 that could (at least in theory) be that large.
2459 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2460 This is less likely to overflow, and avoids undefined behavior if
2461 overflow does occur. All callers changed. Use strtoul to scan
2462 for the unsigned long integer.
2463 (pint2hrstr): Simplify and tune code slightly.
2464 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2466 * scroll.c (do_scrolling): Work around GCC bug 48228.
2467 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2469 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2470 This also avoids a warning with gcc -Wstrict-overflow.
2471 (validate_x_resource_name): Simplify count usage.
2472 This also avoids a warning with gcc -Wstrict-overflow.
2474 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2477 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2479 * process.c (Fmake_network_process): Use socklen_t, not int,
2480 where POSIX says socklen_t is required in portable programs.
2481 This fixes a porting bug on hosts like 64-bit HP-UX, where
2482 socklen_t is wider than int (Bug#8277).
2483 (Fmake_network_process, server_accept_connection):
2484 (wait_reading_process_output, read_process_output):
2487 * process.c: Rename or move locals to avoid shadowing.
2488 (list_processes_1, Fmake_network_process):
2489 (read_process_output_error_handler, exec_sentinel_error_handler):
2490 Rename or move locals.
2491 (Fmake_network_process): Define label "retry_connect" only if needed.
2492 (Fnetwork_interface_info): Fix pointer signedness.
2493 (process_send_signal): Add cast to avoid pointer signedness problem.
2494 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2495 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2497 Make tparam.h and terminfo.c consistent.
2498 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2499 Include tparam.h instead, since it declares them.
2500 * cm.h (PC): Remove extern decl; tparam.h now does this.
2501 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2502 * terminfo.c: Include tparam.h, to check interfaces.
2503 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2504 (tparam): Adjust signature to match interface in tparam.h;
2505 this removes some undefined behavior. Check that outstring and len
2506 are zero, which they always are with Emacs.
2507 * tparam.h (PC, BC, UP): New extern decls.
2509 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2510 (xftfont_open): Rename locals to avoid shadowing.
2512 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2513 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2514 (OTF_TAG_SYM): Omit macro if not needed.
2515 (ftfont_list): Remove unused local.
2516 (get_adstyle_property, ftfont_pattern_entity):
2517 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2518 Rename locals to avoid shadowing.
2520 * xfont.c (xfont_list_family): Mark var as initialized.
2522 * xml.c (make_dom): Now static.
2524 * composite.c (composition_compute_stop_pos): Rename local to
2526 (composition_reseat_it): Remove unused locals.
2527 (find_automatic_composition, composition_adjust_point): Likewise.
2528 (composition_update_it): Mark var as initialized.
2529 (find_automatic_composition): Mark vars as initialized,
2530 with a FIXME (Bug#8290).
2532 character.h: Rename locals to avoid shadowing.
2533 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2534 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2535 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2536 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2539 * textprop.c (property_change_between_p): Remove; unused.
2541 * intervals.c (interval_start_pos): Now static.
2543 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2545 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2546 Rename locals to avoid shadowing.
2548 * sound.c (wav_play, au_play, Fplay_sound_internal):
2549 Fix pointer signedness.
2550 (alsa_choose_format): Remove unused local var.
2551 (wav_play): Initialize a variable to 0, to prevent undefined
2552 behavior (Bug#8278).
2554 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2556 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2559 clobbering (Bug#8298).
2560 * sysdep.c (sys_subshell): Likewise.
2561 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2563 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2564 This should get cleaned up, so that child_setup has the
2565 same signature on all platforms.
2567 * callproc.c (call_process_cleanup): Now static.
2568 (relocate_fd): Rename locals to avoid shadowing.
2570 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2572 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2573 not to be necessary, and produces flickering.
2575 2011-03-20 Glenn Morris <rgm@gnu.org>
2577 * config.in: Remove file.
2579 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2581 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2582 are now in src/globals.h.
2583 (syms_of_minibuf): Remove spurious & from previous change.
2585 2011-03-20 Leo <sdl.web@gmail.com>
2587 * minibuf.c (completing-read-function): New variable.
2588 (completing-read-default): Rename from completing-read.
2589 (completing-read): Call completing-read-function.
2591 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2593 * xfaces.c (Fx_load_color_file):
2594 Read color file from absolute filename (bug#8250).
2596 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2598 * makefile.w32-in: Update dependencies.
2600 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2602 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2604 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2606 Fix more problems found by GCC 4.5.2's static checks.
2608 * process.c (make_serial_process_unwind, send_process_trap):
2609 (sigchld_handler): Now static.
2611 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2612 That way, the code declares only the vars that it needs.
2613 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2614 * s/cygwin.h (PTY_ITERATION): Likewise.
2615 * s/darwin.h (PTY_ITERATION): Likewise.
2616 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2618 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2619 * process.c (allocate_pty): Don't declare stb unless it's needed.
2621 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2622 (CONSTANTLIM): Remove; unused.
2623 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2624 Define only if needed.
2626 * unexelf.c (unexec): Name an expression,
2627 to avoid gcc -Wbad-function-cast warning.
2628 Use a different way to cause a compilation error if anyone uses
2629 n rather than nn, a way that does not involve shadowing.
2630 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2632 * deps.mk (unexalpha.o): Remove; unused.
2634 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2635 * unexec.h: New file.
2636 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2637 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2639 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2640 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2641 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2642 Change as necessary to match prototype in unexec.h.
2644 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2646 (back_comment, skip_chars): Mark vars as initialized.
2648 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2649 Rename locals to avoid shadowing.
2651 * lread.c (read1): Rewrite so as not to use empty "else".
2652 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2654 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2656 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2657 warning when compiling print.c.
2659 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2660 instead of using an uninitialized var.
2661 (font_sort_entities): Mark var as initialized.
2663 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2665 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2666 pointers to constants.
2667 (font_parse_fcname): Remove unused vars.
2668 (font_delete_unmatched): Now static.
2669 (font_get_spec): Remove; unused.
2670 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2671 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2672 Rename or move locals to avoid shadowing.
2674 * fns.c (require_nesting_list, require_unwind): Now static.
2675 (Ffillarray): Rename locals to avoid shadowing.
2677 * floatfns.c (domain_error2): Define only if needed.
2678 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2680 * alloc.c (mark_backtrace): Move decl from here ...
2681 * lisp.h: ... to here, so that it can be checked.
2683 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2684 (Fdefvar): Rewrite so as not to use empty "else".
2685 (lisp_indirect_variable): Name an expression,
2686 to avoid gcc -Wbad-function-cast warning.
2687 (Fdefvar): Rename locals to avoid shadowing.
2689 * callint.c (quotify_arg, quotify_args): Now static.
2690 (Fcall_interactively): Rename locals to avoid shadowing.
2691 Use const pointer when appropriate.
2693 * lisp.h (get_system_name, get_operating_system_release):
2694 Move decls here, to check interfaces.
2695 * process.c (get_operating_system_release): Move decl to lisp.h.
2696 * xrdb.c (get_system_name): Likewise.
2697 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2698 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2699 some of which prompt warnings from gcc -Wbad-function-cast.
2700 (Fformat_time_string, Fencode_time, Finsert_char):
2701 (Ftranslate_region_internal, Fformat):
2702 Rename or remove local vars to avoid shadowing.
2703 (Ftranslate_region_internal): Mark var as initialized.
2705 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2708 * lisp.h (eassert): Check that the argument compiles, even if
2709 ENABLE_CHECKING is not defined.
2711 * data.c (Findirect_variable): Name an expression, to avoid
2712 gcc -Wbad-function-cast warning.
2713 (default_value, arithcompare, arith_driver, arith_error): Now static.
2714 (store_symval_forwarding): Rename local to avoid shadowing.
2715 (Fmake_variable_buffer_local, Fmake_local_variable):
2716 Mark variables as initialized.
2717 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2719 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2720 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2721 Rename locals to avoid shadowing.
2722 (mark_stack): Move local variables into the #ifdef region where
2724 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2725 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2727 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2728 (GC_STRING_CHARS): Remove; not used.
2729 (Fmemory_limit): Cast sbrk's returned value to char *.
2731 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2732 avoids undefined behavior in theory.
2734 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2736 Use functions, not macros, for up- and down-casing (Bug#8254).
2737 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2738 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2739 to use the following functions instead of these macros.
2740 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2741 EMACS_INT, since callers assume the returned value fits in int.
2742 (upcase1): Likewise, for UPCASE_TABLE.
2743 (uppercasep, lowercasep, upcase): New static inline functions.
2744 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2745 the race-condition problem in the old DOWNCASE.
2747 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2748 Rename locals to avoid shadowing.
2749 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2750 (regex_compile, re_search_2, re_match_2_internal):
2751 Remove unused local vars.
2752 (FREE_VAR): Rewrite so as not to use empty "else",
2753 which gcc can warn about.
2754 (regex_compile, re_match_2_internal): Mark locals as initialized.
2755 (RETALLOC_IF): Define only if needed.
2756 (WORDCHAR_P): Likewise. This one is never needed, but is used
2757 only in a comment talking about a compiler bug, so put inside
2758 the #if 0 of that comment.
2759 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2760 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2763 * search.c (boyer_moore): Rename locals to avoid shadowing.
2764 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2765 (PREV_CHAR_BOUNDARY): Likewise.
2767 * search.c (simple_search): Remove unused var.
2769 * dired.c (compile_pattern): Move decl from here ...
2770 * lisp.h: ... to here, so that it can be checked.
2771 (struct re_registers): New forward decl.
2773 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2775 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2777 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2778 Rename locals to avoid shadowing.
2779 (Fvertical_motion): Mark locals as initialized.
2781 * casefiddle.c (casify_object, casify_region): Now static.
2782 (casify_region): Mark local as initialized.
2784 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2786 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2787 New macros, so that the caller can use some names other than
2788 gcpro1, gcpro2, etc.
2789 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2791 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2792 argument, for consistency with GCPRO2_VAR, etc: it is now the
2793 prefix of the variable, not the variable itself. All uses
2795 * dired.c (directory_files_internal, file_name_completion):
2796 Rename locals to avoid shadowing.
2798 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2799 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2800 dired.c's scmp function, had undefined behavior.
2801 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2802 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2803 * buffer.h: ... to here, because these macros use current_buffer,
2804 and the new implementation with inline functions needs to have
2805 current_buffer in scope now, rather than later when the macros
2807 (downcase, upcase1): New static inline functions.
2808 (DOWNCASE, UPCASE1): Reimplement using these functions.
2809 This avoids undefined behavior in expressions like
2810 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2811 from race conditions in accessing the global variables
2812 case_temp1 and case_temp2.
2813 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2814 * lisp.h (case_temp1, case_temp2): Remove their decls.
2815 * character.h (ASCII_CHAR_P): Move from here ...
2816 * lisp.h: ... to here, so that the inline functions mentioned
2819 * dired.c (directory_files_internal_unwind): Now static.
2821 * fileio.c (file_name_as_directory, directory_file_name):
2822 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2824 (file_name_as_directory): Use const pointers when appropriate.
2825 (Fexpand_file_name): Likewise. In particular, newdir might
2826 point at constant storage, so make it a const pointer.
2827 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2828 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2830 (Fset_file_times, Finsert_file_contents, auto_save_error):
2831 Rename locals to avoid shadowing.
2833 * minibuf.c (choose_minibuf_frame_1): Now static.
2834 (Ftry_completion, Fall_completions): Rename or remove locals
2837 * marker.c (bytepos_to_charpos): Remove; unused.
2839 * lisp.h (verify_bytepos, count_markers): New decls,
2840 so that gcc does not warn that these functions aren't declared.
2842 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2843 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2844 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2845 (copy_text): Remove unused local var.
2847 * filelock.c (within_one_second): Now static.
2848 (lock_file_1): Rename local to avoid shadowing.
2850 * buffer.c (fix_overlays_before): Mark locals as initialized.
2851 (fix_start_end_in_overlays): Likewise. This function should be
2852 simplified by using pointers-to-pointers, but that's a different
2854 (switch_to_buffer_1): Now static.
2855 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2856 (report_overlay_modification): Rename locals to avoid shadowing.
2858 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2859 Fix pointer signedness issue.
2860 (sys_subshell): Mark local as volatile if checking for lint,
2861 to suppress a gcc -Wclobbered warning that does not seem to be right.
2862 (MAXPATHLEN): Define only if needed.
2864 * process.c (serial_open, serial_configure): Move decls from here ...
2865 * systty.h: ... to here, so that they can be checked.
2867 * fns.c (get_random, seed_random): Move extern decls from here ...
2868 * lisp.h: ... to here, so that they can be checked.
2870 * sysdep.c (reset_io): Now static.
2871 (wait_for_termination_signal): Remove; unused.
2873 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2874 (copy_keymap_item, append_key, push_text_char_description):
2876 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2877 (DENSE_TABLE_SIZE): Remove; unused.
2878 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2879 (describe_map_tree):
2880 Rename locals to avoid shadowing.
2882 * keyboard.c: Declare functions static if they are not used elsewhere.
2883 (echo_char, echo_dash, cmd_error, top_level_2):
2884 (poll_for_input, handle_async_input): Now static.
2885 (read_char, kbd_buffer_get_event, make_lispy_position):
2886 (make_lispy_event, make_lispy_movement, apply_modifiers):
2887 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2888 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2889 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2890 (read_key_sequence, read_char): Mark locals as initialized.
2891 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2893 * keyboard.h (make_ctrl_char): New decl.
2894 (mark_kboards): Move decl here ...
2895 * alloc.c (mark_kboards): ... from here.
2897 * lisp.h (force_auto_save_soon): New decl.
2899 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2900 (DEFINE_DUMMY_FUNCTION): New macro.
2901 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2903 (main): Add casts to avoid warnings
2904 if GCC considers string literals to be constants.
2906 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2908 * dbusbind.c: Pointer signedness fixes.
2909 (xd_signature, xd_append_arg, xd_initialize):
2910 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2911 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2912 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2913 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2915 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2916 if GCC considers string literals to be constants.
2917 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2919 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2921 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2922 (print_preprocess, print_object): New macro to fix last change.
2924 * print.c (print_preprocess): Don't forget font objects.
2926 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2928 * emacs.c (USAGE3): Doc fixes.
2930 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2932 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2935 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2937 * lisp.h (VWindow_system, Qfile_name_history):
2938 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2939 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2940 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2942 * w32select.c: Don't #include "keyboard.h".
2943 (run_protected): Add extern declaration for waiting_for_input.
2945 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2946 * w32console.c (detect_input_pending, read_input_pending)
2947 (encode_terminal_code):
2948 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2949 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2950 (w32_system_caret_y, Qfile_name_history):
2951 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2952 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2953 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2954 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2955 * w32proc.c (Qlocal, report_file_error):
2956 * w32term.c (Vwindow_system, updating_frame):
2957 * w32uniscribe.c (initialized, uniscribe_font_driver):
2958 Remove unneeded extern declarations.
2960 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2962 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2964 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2966 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2967 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2968 These macros can no longer be used for assignment.
2970 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2971 Assign struct members directly, instead of using BUF_BEGV etc.
2972 (record_buffer_markers, fetch_buffer_markers): New functions for
2973 recording and fetching special buffer markers.
2974 (set_buffer_internal_1, set_buffer_temp): Use them.
2976 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2978 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2980 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2981 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2983 * xdisp.c (hscroll_window_tree):
2984 (reconsider_clip_changes): Use PT instead of BUF_PT.
2986 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2988 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2989 $(EMACS_ROOT)/lib/intprops.h.
2991 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2993 Fix more problems found by GCC 4.5.2's static checks.
2995 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2996 to unsigned char * to avoid compiler diagnostic.
2997 (xg_free_frame_widgets): Make it clear that a local variable is
2998 needed only if USE_GTK_TOOLTIP.
2999 (gdk_window_get_screen): Make it clear that this macro is needed
3000 only if USE_GTK_TOOLTIP.
3001 (int_gtk_range_get_value): New function, which avoids a diagnostic
3002 from gcc -Wbad-function-cast.
3003 (xg_set_toolkit_scroll_bar_thumb): Use it.
3004 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3005 diagnostic from gcc -Wbad-function-cast.
3006 (get_utf8_string, xg_get_file_with_chooser):
3007 Rename locals to avoid shadowing.
3008 (create_dialog): Move locals to avoid shadowing.
3010 * xgselect.c (xg_select): Remove unused var.
3012 * image.c (four_corners_best): Mark locals as initialized.
3013 (gif_load): Initialize transparent_p to zero (Bug#8238).
3014 Mark another local as initialized.
3015 (my_png_error, my_error_exit): Mark with NO_RETURN.
3017 * image.c (clear_image_cache): Now static.
3018 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3019 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3020 (x_edge_detection): Remove unnecessary cast that
3021 gcc -Wbad-function-cast diagnoses.
3022 (gif_load): Fix pointer signedness.
3023 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3024 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3026 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3028 Improve quality of tests for time stamp overflow.
3029 For example, without this patch (encode-time 0 0 0 1 1
3030 1152921504606846976) returns the obviously-bogus value (-948597
3031 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3032 reports time overflow. See
3033 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3034 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3035 * editfns.c: Include limits.h and intprops.h.
3036 (TIME_T_MIN, TIME_T_MAX): New macros.
3037 (time_overflow): Move earlier, to before first use.
3038 (hi_time, lo_time): New functions, for an accurate test for
3040 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3041 (Fget_internal_run_time): Don't assume time_t fits in int.
3042 (make_time): Use list2 instead of Fcons twice.
3043 (Fdecode_time): More accurate test for out-of-range times.
3044 (check_tm_member): New function.
3045 (Fencode_time): Use it, to test for out-of-range times.
3046 (lisp_time_argument): Don't rely on undefined left-shift and
3047 right-shift behavior when checking for time stamp overflow.
3049 * editfns.c (time_overflow): New function, refactoring common code.
3050 (Fformat_time_string, Fdecode_time, Fencode_time):
3051 (Fcurrent_time_string): Use it.
3053 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3054 * dired.c (make_time): Move to ...
3055 * editfns.c (make_time): ... here.
3056 * systime.h: Note the move.
3058 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3060 * fringe.c (update_window_fringes): Remove unused variables.
3062 * unexmacosx.c (copy_data_segment): Also copy __got section.
3065 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3067 * termcap.c [MSDOS]: Include "msdos.h".
3068 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3069 Constify `char *' arguments and their references according to
3070 prototypes in tparam.h.
3072 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3074 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3075 Adapt all references accordingly.
3077 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3079 2011-03-11 Tom Tromey <tromey@redhat.com>
3081 * buffer.c (syms_of_buffer): Remove obsolete comment.
3083 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3085 * termhooks.h (encode_terminal_code): Declare prototype.
3087 * msdos.c (encode_terminal_code): Don't declare prototype.
3089 * term.c (encode_terminal_code): Now external again, used by
3090 w32console.c and msdos.c.
3092 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3093 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3095 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3097 Fix some minor problems found by GCC 4.5.2's static checks.
3099 * fringe.c (update_window_fringes): Mark locals as initialized
3101 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3103 * alloc.c (mark_fringe_data): Move decl from here ...
3104 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3105 to check its interface.
3106 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3108 * fontset.c (free_realized_fontset): Now static.
3109 (Fset_fontset_font): Rename local to avoid shadowing.
3110 (fontset_font): Mark local as initialized.
3111 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3113 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3115 * xselect.c (x_disown_buffer_selections): Remove; not used.
3116 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3117 (x_own_selection, Fx_disown_selection_internal): Rename locals
3119 (x_handle_dnd_message): Remove local to avoid shadowing.
3121 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3122 so that the caller can use some name other than gcpro1.
3123 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3124 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3125 (Fx_backspace_delete_keys_p):
3126 Use them to avoid shadowing, and rename vars to avoid shadowing.
3127 (x_decode_color, x_set_name, x_window): Now static.
3128 (Fx_create_frame): Add braces to silence GCC warning.
3129 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3130 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3131 Remove unused locals.
3132 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3133 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3134 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3137 * xterm.h (x_mouse_leave): New decl.
3139 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3140 Remove unused functions.
3141 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3142 (x_calc_absolute_position): Now static.
3143 (XTread_socket): Don't define label "out" unless it's used.
3144 Don't declare local "event" unless it's used.
3145 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3146 unless they are used.
3147 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3148 (x_fatal_error_signal): Remove; not used.
3149 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3150 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3151 (x_error_catcher, x_connection_closed, x_error_handler):
3152 (x_error_quitter, xembed_send_message, x_iconify_frame):
3153 (my_log_handler): Rename locals to avoid shadowing.
3154 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3155 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3157 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3158 Rename or move locals to avoid shadowing.
3159 (tty_defined_color, merge_face_heights): Now static.
3160 (free_realized_faces_for_fontset): Remove; not used.
3161 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3162 does not deduce is never used uninitialized.
3163 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3164 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3166 * terminal.c (store_terminal_param): Now static.
3168 * xmenu.c (menu_highlight_callback): Now static.
3169 (set_frame_menubar): Remove unused local.
3170 (xmenu_show): Rename parameter to avoid shadowing.
3171 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3172 since they might point to immutable storage.
3173 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3174 since it's unused otherwise.
3176 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3177 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3178 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3179 avoids a gcc -Wuninitialized diagnostic.
3180 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3181 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3182 does not deduce are never used uninitialized.
3184 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3186 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3187 * window.c (window_loop, size_window):
3188 (run_window_configuration_change_hook, enlarge_window): Likewise.
3190 * window.c (display_buffer): Now static.
3191 (size_window): Mark variables that gcc -Wuninitialized
3192 does not deduce are never used uninitialized.
3193 * window.h (check_all_windows): New decl, to forestall
3194 gcc -Wmissing-prototypes diagnostic.
3195 * dispextern.h (bidi_dump_cached_states): Likewise.
3197 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3199 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3201 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3202 and to avoid gcc -Wuninitialized warning.
3203 (load_charset_map): Mark variables that gcc -Wuninitialized
3204 does not deduce are never used uninitialized.
3205 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3207 * coding.c (coding_set_source, coding_set_destination):
3208 Use "else { /* comment */ }" rather than "else /* comment */;"
3209 for clarity, and to avoid gcc -Wempty-body warning.
3210 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3211 a block, when the outer 'i' will do.
3212 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3213 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3214 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3215 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3216 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3217 Rename locals to avoid shadowing.
3218 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3219 * coding.c (emacs_mule_char, encode_invocation_designation):
3220 Now static, since they're not used elsewhere.
3221 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3222 (decode_coding_object, encode_coding_object, detect_coding_system):
3223 (decode_coding_emacs_mule): Mark variables that gcc
3224 -Wuninitialized does not deduce are never used uninitialized.
3225 (detect_coding_iso_2022): Initialize a local variable that might
3226 be used uninitialized. Leave a FIXME because it's not clear that
3227 this initialization is needed. (Bug#8211)
3228 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3229 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3230 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3231 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3232 Remove unused macros.
3234 * category.c (hash_get_category_set): Remove unused local var.
3235 (copy_category_table): Now static, since it's not used elsewhere.
3236 * character.c (string_count_byte8): Likewise.
3238 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3239 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3241 * chartab.c (copy_sub_char_table): Now static, since it's not used
3243 (sub_char_table_ref_and_range, char_table_ref_and_range):
3244 Rename locals to avoid shadowing.
3245 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3247 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3248 (BIDI_BOB): Remove unused macro.
3250 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3251 deduce are never used uninitialized.
3252 * term.c (encode_terminal_code): Likewise.
3254 * term.c (encode_terminal_code): Now static. Remove unused local.
3256 * tparam.h: New file.
3257 * term.c, tparam.h: Include it.
3258 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3259 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3260 Move these decls to tparam.h, and make them agree with what
3261 is actually in tparam.c. The previous trick of using incompatible
3262 decls in different modules does not conform to the C standard.
3263 All callers of tparam changed to use tparam's actual API.
3264 * tparam.c (tparam1, tparam, tgoto):
3265 Use const pointers where appropriate.
3267 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3268 * cm.h (struct cm): Likewise.
3269 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3270 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3271 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3272 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3273 (turn_on_face, init_tty): Likewise.
3274 * termchar.h (struct tty_display_info): Likewise.
3276 * term.c (term_mouse_position): Rename local to avoid shadowing.
3278 * alloc.c (mark_ttys): Move decl from here ...
3279 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3281 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3283 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3285 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3287 * search.c (compile_pattern_1): Remove argument regp, unused since
3288 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3289 (compile_pattern): Don't pass it.
3291 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3293 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3294 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3296 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3298 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3300 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3301 gdk_window_get_screen, gdk_window_get_geometry,
3302 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3303 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3304 (xg_get_pixbuf_from_pixmap): New function.
3305 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3306 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3307 Call xg_get_pixbuf_from_pixmap instead of
3308 gdk_pixbuf_get_from_drawable.
3309 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3310 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3311 (xg_check_special_colors): Use GtkStyleContext and its functions
3313 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3314 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3315 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3316 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3317 Call gtk_widget_get_preferred_size.
3318 (xg_frame_resized): gdk_window_get_geometry only takes 5
3320 (xg_win_to_widget, xg_event_is_for_menubar):
3321 Call gdk_x11_window_lookup_for_display.
3322 (xg_set_widget_bg): New function.
3323 (delete_cb): New function.
3324 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3325 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3326 (xg_set_background_color): Call xg_set_widget_bg.
3327 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3328 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3329 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3330 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3332 (update_frame_tool_bar): Call gtk_widget_hide.
3333 (xg_initialize): Use GDK_KEY_g.
3335 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3337 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3339 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3340 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3341 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3343 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3345 * w32xfns.c (select_palette): Check success of RealizePalette against
3346 GDI_ERROR, not zero.
3348 See ChangeLog.11 for earlier changes.
3354 Copyright (C) 2011 Free Software Foundation, Inc.
3356 This file is part of GNU Emacs.
3358 GNU Emacs is free software: you can redistribute it and/or modify
3359 it under the terms of the GNU General Public License as published by
3360 the Free Software Foundation, either version 3 of the License, or
3361 (at your option) any later version.
3363 GNU Emacs is distributed in the hope that it will be useful,
3364 but WITHOUT ANY WARRANTY; without even the implied warranty of
3365 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3366 GNU General Public License for more details.
3368 You should have received a copy of the GNU General Public License
3369 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.