Fix pos-visible-in-window-p under bidi redisplay.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (move_it_in_display_line_to): Record the best matching
4 position for TO_CHARPOS while scanning the line, and restore it on
5 exit if none of the characters scanned was an exact match. Fixes
6 vertical-motion and pos-visible-in-window-p under bidi redisplay
7 when exact match is impossible due to invisible text, and the
8 lines are truncated.
9
10 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11
12 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
13 for OSX >= 10.7.
14
15 2011-07-22 Eli Zaretskii <eliz@gnu.org>
16
17 Fix a significant slow-down of cursor motion with C-n, C-p,
18 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
19 auto-repeat under bidi redisplay in fontified buffers.
20 * xdisp.c (compute_stop_pos_backwards): New function.
21 (next_element_from_buffer): Call compute_stop_pos_backwards to
22 find a suitable prev_stop when we find ourselves before
23 base_level_stop.
24 (reseat): Don't look for prev_stop, as that could mean a very long
25 run.
26 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
27 <cached_disp_overlay_modiff>: Cache for last found display string
28 position.
29 (compute_display_string_pos): Return the cached position if asked
30 about the same buffer in the same area of character positions, and
31 the buffer wasn't changed since the time the display string
32 position was cached.
33
34 2011-07-22 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
37 is an integer, which is important for empty lines. (Bug#9149)
38
39 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
40
41 * frame.c (Fmodify_frame_parameters): In tty case, update the
42 default face if necessary (Bug#4238).
43
44 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
45
46 * editfns.c (Fstring_to_char): No need to explain what a character
47 is in the docstring (Bug#6576).
48
49 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
50
51 * xml.c (parse_region): Make sure we always return a tree.
52
53 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
54
55 * xml.c (parse_region): If a document contains only comments,
56 return that, too.
57
58 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
59
60 * xml.c (make_dom): Return comments, too.
61
62 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
63
64 Port to OpenBSD.
65 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
66 and the surrounding thread.
67 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
68 rather than fgets, and retry after EINTR. Otherwise, 'emacs
69 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
70 timer goes off.
71 * s/openbsd.h (BROKEN_SIGIO): Define.
72 * unexelf.c (unexec) [__OpenBSD__]:
73 Don't update the .mdebug section of the Alpha COFF symbol table.
74
75 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
76
77 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
78 (bug#8460).
79
80 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
81
82 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
83 This fixes some race conditions on the permissions of any newly
84 created file.
85
86 * alloc.c (valid_pointer_p): Use pipe, not open.
87 This fixes some permissions issues when debugging.
88
89 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
90 If fchown fails to set both uid and gid, try to set just gid,
91 as that is sometimes allowed. Adjust the file's mode to eliminate
92 setuid or setgid bits that are inappropriate if fchown fails.
93
94 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
97 to compare Lisp_Objects.
98 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
99 global_gnutls_log_level, don't mistake it for a Lisp_Object.
100 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
101
102 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
103
104 * lread.c (read_integer): Unread even EOF character.
105 (read1): Likewise. Properly record start position of symbol.
106
107 * lread.c (read1): Read `#:' as empty uninterned symbol if no
108 symbol character follows.
109
110 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
111
112 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
113 This works around a problem with the previous change to Fcopy_file.
114 Recent glibc declares fchown with __attribute__((warn_unused_result)),
115 and without this change, GCC might complain about discarding
116 fchown's return value.
117
118 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
119
120 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
121
122 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
123
124 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
125
126 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
127
128 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
129 it's used from the C level.
130
131 * process.c: Use the same condition for POLL_FOR_INPUT in both
132 keyboard.c and process.c (bug#1858).
133
134 2011-07-09 Lawrence Mitchell <wence@gmx.li>
135
136 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
137 (Fgnutls_boot): Use it.
138
139 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
140
141 * doc.c (Fsubstitute_command_keys): Revert last change.
142
143 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
144
145 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
146 quotes the next character, and doesn't affect other longer
147 sequences (bug#8935).
148
149 * lread.c (syms_of_lread): Clarify that is isn't only
150 `eval-buffer' and `eval-defun' that's affected by
151 `lexical-binding' (bug#8460).
152
153 2011-07-15 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
156 bidi redisplay when a line includes both an image and is
157 truncated.
158
159 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
160
161 Fix minor problems found by static checking.
162 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
163 (elsz): Now a signed constant, not a size_t var. We prefer signed
164 types to unsigned, to avoid integer comparison confusion. Without
165 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
166 "cannot optimize loop, the loop counter may overflow", a symptom
167 of the confusion.
168 * indent.c (Fvertical_motion): Mark locals as initialized.
169 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
170
171 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
172
173 * search.c (Fre_search_backward): Mention `case-fold-search' in
174 all the re_search_* functions (bug#8138).
175
176 * keyboard.c (Fopen_dribble_file): Document when the file is
177 closed (bug#8056).
178
179 2011-07-14 Eli Zaretskii <eliz@gnu.org>
180
181 * bidi.c (bidi_dump_cached_states): Fix format of displaying
182 bidi_cache_idx.
183
184 Support bidi reordering of display and overlay strings.
185 * xdisp.c (compute_display_string_pos)
186 (compute_display_string_end): Accept additional argument STRING.
187 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
188 (reseat_to_string): Initialize bidi_it->string.s and
189 bidi_it->string.schars.
190 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
191 NULL (avoids a crash in bidi_paragraph_init). Initialize
192 itb.string.lstring.
193 (init_iterator): Call bidi_init_it only of a valid
194 buffer position was specified. Initialize paragraph_embedding to
195 L2R.
196 (reseat_to_string): Initialize the bidi iterator.
197 (display_string): If we need to ignore text properties of
198 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
199 original value of -1 will not work with bidi.)
200 (compute_display_string_pos): First arg is now struct
201 `text_pos *'; all callers changed. Support display properties on
202 Lisp strings.
203 (compute_display_string_end): Support display properties on Lisp
204 strings.
205 (init_iterator, reseat_1, reseat_to_string): Initialize the
206 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
207 when iterating on a string not from display properties).
208 (compute_display_string_pos, compute_display_string_end): Fix
209 calculation of the object to scan. Fixes an error when using
210 arrow keys.
211 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
212 base_level_stop; instead, set base_level_stop to BEGV. Fixes
213 crashes in vertical-motion.
214 (next_element_from_buffer): Improve commentary for when
215 the iterator is before prev_stop.
216 (init_iterator): Initialize bidi_p from the default value of
217 bidi-display-reordering, not from buffer-local value. Use the
218 buffer-local value only if initializing for buffer iteration.
219 (handle_invisible_prop): Support invisible properties on strings
220 that are being bidi-reordered.
221 (set_iterator_to_next): Support bidi reordering of C strings and
222 Lisp strings.
223 (next_element_from_string): Support bidi reordering of Lisp
224 strings.
225 (handle_stop_backwards): Support Lisp strings as well.
226 (display_string): Support display of R2L glyph rows. Use
227 IT_STRING_CHARPOS when displaying from a Lisp string.
228 (init_iterator): Don't initialize it->bidi_p for strings
229 here.
230 (reseat_to_string): Initialize it->bidi_p for strings here.
231 (next_element_from_string, next_element_from_c_string)
232 (next_element_from_buffer): Add xassert's for correspondence
233 between IT's object being iterated and it->bidi_it.string
234 structure.
235 (face_before_or_after_it_pos): Support bidi iteration.
236 (next_element_from_c_string): Handle the case of the first string
237 character that is not the first one in the visual order.
238 (get_visually_first_element): New function, refactored from common
239 parts of next_element_from_buffer, next_element_from_string, and
240 next_element_from_c_string.
241 (tool_bar_lines_needed, redisplay_tool_bar)
242 (display_menu_bar): Force left-to-right direction. Add a FIXME
243 comment for making that be controlled by a user option.
244 (push_it, pop_it): Save and restore the state of the
245 bidi iterator. Save and restore the bidi_p flag.
246 (pop_it): Iterate out of display property for string iteration as
247 well.
248 (iterate_out_of_display_property): Support iteration over strings.
249 (handle_single_display_spec): Set up it->bidi_it for iteration
250 over a display string, and call bidi_init_it.
251 (handle_single_display_spec, next_overlay_string)
252 (get_overlay_strings_1, push_display_prop): Set up the bidi
253 iterator for displaying display or overlay strings.
254 (forward_to_next_line_start): Don't use the shortcut if
255 bidi-iterating.
256 (back_to_previous_visible_line_start): If handle_display_prop
257 pushed the iterator stack, restore the internal state of the bidi
258 iterator by calling bidi_pop_it same number of times.
259 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
260 and we are bidi-iterating, don't decrement the iterator position;
261 instead, set the first_elt flag in the bidi iterator, to produce
262 the same effect.
263 (reseat_1): Remove redundant setting of string_from_display_prop_p.
264 (push_display_prop): xassert that we are iterating a buffer.
265 (push_it, pop_it): Save and restore paragraph_embedding member.
266 (handle_single_display_spec, next_overlay_string)
267 (get_overlay_strings_1, reseat_1, reseat_to_string)
268 (push_display_prop): Set up the `unibyte' member of bidi_it.string
269 correctly. Don't assume unibyte strings are not bidi-reordered.
270 (compute_display_string_pos)
271 (compute_display_string_end): Fix handling the case of C string.
272 (push_it, pop_it): Save and restore from_disp_prop_p.
273 (handle_single_display_spec, push_display_prop): Set the
274 from_disp_prop_p flag.
275 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
276 (pop_it): Call iterate_out_of_display_property only if we are
277 popping after iteration over a string that came from a display
278 property. Fix a typo in popping stretch info. Add an assertion
279 for verifying that the iterator position is in sync with the bidi
280 iterator.
281 (handle_single_display_spec, get_overlay_strings_1)
282 (push_display_prop): Fix initialization of paragraph direction for
283 string when that of the parent object is not yet determined.
284 (reseat_1): Call bidi_init_it to resync the bidi
285 iterator with IT's position. (Bug#7616)
286 (find_row_edges): If ROW->start.pos gives position
287 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
288 (handle_stop, back_to_previous_visible_line_start, reseat_1):
289 Reset the from_disp_prop_p flag.
290 (SAVE_IT, RESTORE_IT): New macros.
291 (pos_visible_p, face_before_or_after_it_pos)
292 (back_to_previous_visible_line_start)
293 (move_it_in_display_line_to, move_it_in_display_line)
294 (move_it_to, move_it_vertically_backward, move_it_by_lines)
295 (try_scrolling, redisplay_window, display_line): Use them when
296 saving a temporary copy of the iterator and restoring it back.
297 (back_to_previous_visible_line_start, reseat_1)
298 (init_iterator): Empty the bidi cache "stack".
299 (move_it_in_display_line_to): If iterator ended up at
300 EOL, but we never saw any buffer positions smaller than
301 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
302 motion in bidi-reordered lines.
303 (move_it_in_display_line_to): Record prev_method and prev_pos
304 immediately before the call to set_iterator_to_next. Fixes cursor
305 motion in bidi-reordered lines with stretch glyphs and strings
306 displayed in margins. (Bug#8133) (Bug#8867)
307 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
308 TO_CHARPOS.
309 (pos_visible_p): Support positions in bidi-reordered lines. Save
310 and restore bidi cache.
311
312 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
313 (bidi_paragraph_info): Delete unused struct.
314 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
315 (bidi_cache_start): New variable.
316 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
317 to zero.
318 (bidi_cache_fetch_state, bidi_cache_search)
319 (bidi_cache_find_level_change, bidi_cache_iterator_state)
320 (bidi_cache_find, bidi_peek_at_next_level)
321 (bidi_level_of_next_char, bidi_find_other_level_edge)
322 (bidi_move_to_visually_next): Compare cache index with
323 bidi_cache_start rather than with zero.
324 (bidi_fetch_char): Accept new argument STRING; all callers
325 changed. Support iteration over a string. Support strings with
326 display properties. Support unibyte strings. Fix the type of
327 `len' according to what STRING_CHAR_AND_LENGTH expects.
328 (bidi_paragraph_init, bidi_resolve_explicit_1)
329 (bidi_resolve_explicit, bidi_resolve_weak)
330 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
331 iteration over a string.
332 (bidi_set_sor_type, bidi_resolve_explicit_1)
333 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
334 can now be zero (for strings); special values 0 and -1 were
335 changed to -1 and -2, respectively.
336 (bidi_char_at_pos): New function.
337 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
338 Call it instead of FETCH_MULTIBYTE_CHAR.
339 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
340 initialized to valid values.
341 (bidi_init_it): Don't initialize charpos and bytepos with invalid
342 values.
343 (bidi_level_of_next_char): Allow the sentinel "position" to pass
344 the test for valid cached positions. Fix the logic for looking up
345 the sentinel state in the cache. GCPRO the Lisp string we are
346 iterating.
347 (bidi_push_it, bidi_pop_it): New functions.
348 (bidi_initialize): Initialize the bidi cache start stack pointer.
349 (bidi_cache_ensure_space): New function, refactored from part of
350 bidi_cache_iterator_state. Don't assume the required size is just
351 one BIDI_CACHE_CHUNK away.
352 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
353 (bidi_count_bytes, bidi_char_at_pos): New functions.
354 (bidi_cache_search): Don't assume bidi_cache_last_idx is
355 always valid if bidi_cache_idx is valid.
356 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
357 is valid if it's going to be used.
358 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
359 (bidi_cache_fetch_state, bidi_cache_search)
360 (bidi_cache_find_level_change, bidi_cache_ensure_space)
361 (bidi_cache_iterator_state, bidi_cache_find)
362 (bidi_find_other_level_edge, bidi_cache_start_stack): All
363 variables related to cache indices are now EMACS_INT.
364
365 * dispextern.h (struct bidi_string_data): New structure.
366 (struct bidi_it): New member `string'. Make flag members be 1-bit
367 fields, and put them last in the struct.
368 (compute_display_string_pos, compute_display_string_end): Update
369 prototypes.
370 (bidi_push_it, bidi_pop_it): Add prototypes.
371 (struct iterator_stack_entry): New members bidi_p,
372 paragraph_embedding, and from_disp_prop_p.
373 (struct it): Member bidi_p is now a bit field 1 bit wide.
374 (bidi_shelve_cache, bidi_unshelve_cache): Declare
375 prototypes.
376
377 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
378 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
379 and vector-like objects.
380
381 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
382 cache around display iteration.
383
384 * window.c (Fwindow_end, window_scroll_pixel_based)
385 (displayed_window_lines, Frecenter): Save and restore the bidi
386 cache around display iteration.
387
388 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
389
390 * editfns.c (Fdelete_region): Clarify the use of the named
391 parameters (bug#6788).
392
393 2011-07-14 Martin Rudalics <rudalics@gmx.at>
394
395 * indent.c (Fvertical_motion): Set and restore w->pointm when
396 saving and restoring the window's buffer (Bug#9006).
397
398 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
399
400 * editfns.c (Fstring_to_char): Clarify just what is returned
401 (bug#6576). Text by Eli Zaretskii.
402
403 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
404
405 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
406
407 2011-07-13 Eli Zaretskii <eliz@gnu.org>
408
409 * buffer.c (mmap_find): Fix a typo.
410
411 2011-07-13 Johan Bockgård <bojohan@gnu.org>
412
413 Fix execution of x selection hooks.
414 * xselect.c (Qx_lost_selection_functions)
415 (Qx_sent_selection_functions): New vars.
416 (syms_of_xselect): DEFSYM them.
417 (x_handle_selection_request): Pass Qx_sent_selection_functions
418 rather than Vx_sent_selection_functions to Frun_hook_with_args.
419 (x_handle_selection_clear,x_clear_frame_selections):
420 Pass Qx_lost_selection_functions rather than
421 Vx_lost_selection_functions to Frun_hook_with_args.
422
423 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
424
425 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
426 The old code sometimes used this field without initializing it.
427
428 * alloc.c (gc_sweep): Don't read past end of array.
429 In theory, the old code could also have corrupted Emacs internals,
430 though it'd be very unlikely.
431
432 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
433
434 * character.c (Fcharacterp): Don't advertise optional ignored
435 argument. (Bug#4026)
436
437 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
438
439 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
440 key" (bug#4257).
441
442 * window.c (Fset_window_start): Doc fix (bug#4199).
443 (Fset_window_hscroll): Ditto.
444
445 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
446
447 Fix minor new problems caught by GCC 4.6.1.
448 * term.c (init_tty): Remove unused local.
449 * xsettings.c (store_monospaced_changed): Define this function only
450 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
451 not used otherwise.
452
453 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
454
455 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
456
457 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
458
459 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
460 are the mini-buffer and the echo area (bug#3320).
461
462 * term.c (init_tty): Remove support for supdup, c10 and perq
463 terminals, which are no longer supported (bug#1482).
464
465 2011-07-10 Johan Bockgård <bojohan@gnu.org>
466
467 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
468
469 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
470
471 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
472 for non-popups (Bug#3642).
473
474 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
475
476 * alloc.c (reset_malloc_hooks): Protoize.
477 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
478 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
479 * cm.c (losecursor): Likewise.
480 * data.c (fmod): Likewise.
481 * dispnew.c (swap_glyphs_in_rows): Likewise.
482 * emacs.c (memory_warning_signal): Likewise.
483 * floatfns.c (float_error): Likewise.
484 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
485 (otf_open, font_otf_capability, generate_otf_features)
486 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
487 Likewise.
488 * image.c (pbm_read_file): Likewise.
489 * indent.c (string_display_width): Likewise.
490 * intervals.c (check_for_interval, search_for_interval)
491 (inc_interval_count, count_intervals, root_interval)
492 (adjust_intervals_for_insertion, make_new_interval): Likewise.
493 * lread.c (defalias): Likewise.
494 * ralloc.c (r_alloc_check): Likewise.
495 * regex.c (set_image_of_range_1, set_image_of_range)
496 (regex_grow_registers): Likewise.
497 * sysdep.c (strerror): Likewise.
498 * termcap.c (valid_filename_p, tprint, main): Likewise.
499 * tparam.c (main): Likewise.
500 * unexhp9k800.c (run_time_remap, save_data_space)
501 (update_file_ptrs, read_header, write_header, calculate_checksum)
502 (copy_file, copy_rest, display_header): Likewise.
503 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
504 Likewise.
505 * xdisp.c (check_it): Likewise.
506 * xfaces.c (register_color, unregister_color, unregister_colors):
507 Likewise.
508 * xfns.c (print_fontset_result): Likewise.
509 * xrdb.c (member, fatal, main): Likewise.
510
511 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
512
513 Fix minor problems found by static checking (Bug#9031).
514 * chartab.c (char_table_set_range, map_sub_char_table):
515 Remove unused locals.
516 (uniprop_table): Now static.
517 * composite.c (_work_char): Remove unused static var.
518
519 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
520
521 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
522
523 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
524
525 * gtkutil.c (qttip_cb): Remove code without function.
526
527 2011-07-09 Eli Zaretskii <eliz@gnu.org>
528
529 * w32.c (pthread_sigmask): New stub.
530
531 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
532
533 Use pthread_sigmask, not sigprocmask (Bug#9010).
534 sigprocmask is portable only for single-threaded applications, and
535 Emacs can be multi-threaded when it uses GTK.
536 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
537 (LIBES): Use it.
538 * callproc.c (Fcall_process):
539 * process.c (create_process):
540 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
541 Use pthread_sigmask, not sigprocmask.
542
543 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
544
545 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
546 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
547 wrong (Bug#8591).
548
549 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
550
551 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
552 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
553 (xg_hide_tooltip): Fix comment.
554
555 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
556 in registerServicesMenuSendTypes.
557 (validRequestorForSendType): Don't check ns_return_types.
558
559 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
560 ns_return_type.
561
562 2011-07-08 Jason Rumney <jasonr@gnu.org>
563
564 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
565 frame struct members of non-existent frames (Bug#6284).
566
567 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
568
569 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
570 variable firstTime not needed on OSX >= 10.6.
571 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
572 >= 10.5. Use setKnobProportion, setDoubleValue.
573
574 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
575 (MAC_OS_X_VERSION_10_5): Define if not defined.
576 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
577 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
578 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
579
580 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
581 cString and lossyCString on OSX >= 10.4
582
583 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
584 sizeToFit on OSX >= 10.2.
585
586 * nsimage.m (allocInitFromFile): Don't use deprecated method
587 bestRepresentationForDevice on OSX >= 10.6.
588
589 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
590 to avoid warning.
591
592 * emacs.c: Declare unexec_init_emacs_zone.
593
594 * nsgui.h: Fix compiler warning about gnulib redefining verify.
595
596 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
597
598 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
599 on svcsMenu (Bug#8842).
600
601 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
602 ns_return_types.
603 (Fns_list_services): Just return Qnil on 10.6, code not working there.
604
605 * nsterm.m (QUTF8_STRING): Declare.
606 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
607 (validRequestorForSendType): Return type is (id).
608 Change indexOfObjectIdenticalTo to indexOfObject.
609 Check if we have local selection before returning self (Bug#8842).
610 (writeSelectionToPasteboard): Put local selection into paste board
611 if we have a local selection (Bug#8842).
612 (syms_of_nsterm): DEFSYM QUTF8_STRING.
613
614 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
615 (ns_get_local_selection): Declare.
616
617 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
618
619 * keymap.c (describe_map_tree): Don't insert a double newline at
620 the end of the buffer (bug#1169) and return whether we inserted
621 something.
622
623 * callint.c (Fcall_interactively): Change "reading args" to
624 "providing args" to try to clarify what it does (bug#1010).
625
626 2011-07-07 Kenichi Handa <handa@m17n.org>
627
628 * composite.c (composition_compute_stop_pos): Ignore a static
629 composition starting before CHARPOS (Bug#8915).
630
631 * xdisp.c (handle_composition_prop): Likewise.
632
633 2011-07-07 Eli Zaretskii <eliz@gnu.org>
634
635 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
636 (Bug#9015)
637
638 2011-07-07 Kenichi Handa <handa@m17n.org>
639
640 * character.h (unicode_category_t): New enum type.
641
642 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
643 (Qchar_code_property_table): New variable.
644 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
645 (UNIPROP_COMPRESSED_FORM_P): New macros.
646 (char_table_ascii): Uncompress the compressed values.
647 (sub_char_table_ref): New arg is_uniprop. Callers changed.
648 Uncompress the compressed values.
649 (sub_char_table_ref_and_range): Likewise.
650 (char_table_ref_and_range): Uncompress the compressed values.
651 (sub_char_table_set): New arg is_uniprop. Callers changed.
652 Uncompress the compressed values.
653 (sub_char_table_set_range): Args changed. Callers changed.
654 (char_table_set_range): Adjuted for the above change.
655 (map_sub_char_table): Delete args default_val and parent. Add arg
656 top. Give decoded values to a Lisp function.
657 (map_char_table): Adjusted for the above change. Give decoded
658 values to a Lisp function. Gcpro more variables.
659 (uniprop_table_uncompress)
660 (uniprop_decode_value_run_length): New functions.
661 (uniprop_decoder, uniprop_decoder_count): New variables.
662 (uniprop_get_decoder, uniprop_encode_value_character)
663 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
664 New functions.
665 (uniprop_encoder, uniprop_encoder_count): New variables.
666 (uniprop_get_encoder, uniprop_table)
667 (Funicode_property_table_internal, Fget_unicode_property_internal)
668 (Fput_unicode_property_internal): New functions.
669 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
670 Sunicode_property_table_internal, Sget_unicode_property_internal,
671 and Sput_unicode_property_internal. Defvar_lisp
672 char-code-property-alist.
673
674 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
675 Vunicode_category_table.
676
677 * font.c (font_range): Adjusted for the change of
678 Vunicode_category_table.
679
680 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
681
682 * m/iris4d.h: Remove file, move contents ...
683 * s/irix6-5.h: ... here.
684
685 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
686
687 Remove unportable assumption about struct layout (Bug#8884).
688 * alloc.c (mark_buffer):
689 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
690 (clone_per_buffer_values): Don't assume that
691 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
692 This isn't true in general, and it's particularly not true
693 if Emacs is configured with --with-wide-int.
694 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
695 New macros, used in the buffer.c change.
696
697 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
698
699 * xsettings.c: Use both GConf and GSettings if both are available.
700 (store_config_changed_event): Add comment.
701 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
702 (store_tool_bar_style_changed): New functions.
703 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
704 (struct xsettings): Move font inside HAVE_XFT.
705 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
706 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
707 Move inside HAVE_XFT.
708 (something_changed_gsettingsCB): Renamed from something_changedCB.
709 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
710 also.
711 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
712 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
713 (something_changed_gconfCB): Renamed from something_changedCB.
714 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
715 (parse_settings): Move check for font inside HAVE_XFT.
716 (read_settings, apply_xft_settings): Add comment.
717 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
718 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
719 call store_font_name_changed.
720 (xft_settings_event): Add comment.
721 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
722 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
723 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
724 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
725 (xsettings_initialize): Call init_gsettings last.
726 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
727 comment.
728
729 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
730
731 Random fixes. E.g., (random) never returned negative values.
732 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
733 subseconds part to the entropy, as that's a bit more random.
734 Prefer signed to unsigned, since the signedness doesn't matter and
735 in general we prefer signed. When given a limit, use a
736 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
737 latter isn't right if USE_2_TAGS_FOR_INTS.
738 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
739 not 0..VALMASK. Don't discard "excess" bits that random () returns.
740
741 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
742
743 * textprop.c (text_property_stickiness):
744 Obey Vtext_property_default_nonsticky.
745 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
746 * w32fns.c (syms_of_w32fns):
747 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
748
749 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
750
751 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
752 This is more efficient than Ffile_directory_p and avoids a minor race.
753
754 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
755
756 * buffer.c (Foverlay_put): Say what the return value is
757 (bug#7835).
758
759 * fileio.c (barf_or_query_if_file_exists): Check first if the file
760 is a directory before asking whether to use the file name
761 (bug#7564).
762 (barf_or_query_if_file_exists): Make the "File is a directory"
763 error be more correct.
764
765 * fns.c (Frequire): Remove the mention of the .gz files, since
766 that's installation-specific, but keep the mention of
767 `get-load-suffixes'.
768
769 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
770
771 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
772 Report string overflow if the output is too long.
773
774 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
775
776 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
777 (syms_of_gnutls): Remove duplicate DEFSYM for
778 Qgnutls_bootprop_verify_hostname_error, an error for
779 Qgnutls_bootprop_verify_error (which is no longer used).
780
781 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
782 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
783 Also (re)move comments that are misplaced or no longer relevant.
784
785 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
786
787 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
788
789 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
790
791 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
792 and background color parameters if they have been changed.
793
794 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
795
796 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
797
798 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
799
800 * xsettings.c (SYSTEM_FONT): Define only when used.
801 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
802
803 * keymap.c (access_keymap_1): Now static.
804
805 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
806
807 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
808 leave any prefix arg for the up event (Bug#1586).
809
810 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
811
812 * lread.c (syms_of_lread): Mention single symbols defined by
813 `defvar' or `defconst' (bug#7154).
814
815 * fns.c (Frequire): Mention .el.gz files (bug#7314).
816 (Frequire): Mention get-load-suffixes.
817
818 2011-07-02 Martin Rudalics <rudalics@gmx.at>
819
820 * window.h (window): Remove clone_number slot.
821 * window.c (Fwindow_clone_number, Fset_window_clone_number):
822 Remove.
823 (make_parent_window, make_window, saved_window)
824 (Fset_window_configuration, save_window_save): Don't deal with
825 clone numbers.
826 * buffer.c (Qclone_number): Remove declaration.
827 (sort_overlays, overlay_strings): Don't deal with clone numbers.
828
829 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
830
831 Add multiple inheritance to keymaps.
832 * keymap.c (Fmake_composed_keymap): New function.
833 (Fset_keymap_parent): Simplify.
834 (fix_submap_inheritance): Remove.
835 (access_keymap_1): New function extracted from access_keymap to handle
836 embedded parents and handle lists of maps.
837 (access_keymap): Use it.
838 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
839 (Fcopy_keymap): Handle embedded parents.
840 (Fcommand_remapping, define_as_prefix): Simplify.
841 (Fkey_binding): Simplify.
842 (syms_of_keymap): Move minibuffer-local-completion-map,
843 minibuffer-local-filename-completion-map,
844 minibuffer-local-must-match-map, and
845 minibuffer-local-filename-must-match-map to Elisp.
846 (syms_of_keymap): Defsubr make-composed-keymap.
847 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
848 (parse_menu_item): Trivial simplification.
849
850 2011-07-01 Glenn Morris <rgm@gnu.org>
851
852 * Makefile.in (SETTINGS_LIBS): Fix typo.
853
854 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
855
856 * coding.c (Fencode_coding_string): Record the last coding system
857 used, as the function doc string says (bug#8738).
858
859 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
860
861 * xsettings.c (store_monospaced_changed): Take new font as arg and
862 check for change against current_mono_font.
863 (EMACS_TYPE_SETTINGS): Remove this and related defines.
864 (emacs_settings_constructor, emacs_settings_get_property)
865 (emacs_settings_set_property, emacs_settings_class_init)
866 (emacs_settings_init, gsettings_obj): Remove.
867 (something_changedCB): New function for HAVE_GSETTINGS.
868 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
869 with value as argument.
870 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
871 g_settings_new (Bug#8967). Do not create gsettings_obj.
872 Remove calls to g_settings_bind. Connect something_changedCB to
873 "changed".
874
875 * xgselect.c: Add defined (HAVE_GSETTINGS).
876 (xgselect_initialize): Ditto.
877
878 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
879 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
880 xg_select.
881
882 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
883
884 * eval.c (struct backtrace): Simplify and port the data structure.
885 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
886 signed bit field, as this assumption is not portable and it makes
887 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
888 "char debug_on_exit : 1" as this is not portable either; instead,
889 use the portable "unsigned int debug_on_exit : 1". Remove unused
890 member evalargs. Remove obsolete comments about cc bombing out.
891
892 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
893
894 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
895 Let HAVE_GSETTINGS override HAVE_GCONF.
896 (store_monospaced_changed): New function.
897 (EMACS_SETTINGS): A new type derived from GObject to handle
898 GSettings notifications.
899 (emacs_settings_constructor, emacs_settings_get_property)
900 (emacs_settings_set_property, emacs_settings_class_init):
901 New functions.
902 (gsettings_client, gsettings_obj): New variables.
903 (GSETTINGS_SCHEMA): New define.
904 (something_changedCB): Call store_monospaced_changed.
905 (init_gsettings): New function.
906 (xsettings_initialize): Call init_gsettings.
907 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
908 to NULL.
909
910 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
911 GCONF_CFLAGS/LIBS.
912
913 2011-06-29 Martin Rudalics <rudalics@gmx.at>
914
915 * window.c (resize_root_window, grow_mini_window)
916 (shrink_mini_window): Rename Qresize_root_window to
917 Qwindow_resize_root_window and Qresize_root_window_vertically to
918 Qwindow_resize_root_window_vertically.
919
920 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
921
922 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
923
924 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
925
926 * makefile.w32-in: Redesign dependencies so they reflect more
927 clearly which files are directly included by each source file,
928 and not through other includes.
929
930 2011-06-27 Martin Rudalics <rudalics@gmx.at>
931
932 * buffer.c (Qclone_number): Declare static and DEFSYM it.
933 (sort_overlays, overlay_strings): When an overlay's clone number
934 matches the window's clone number process the overlay even if
935 the overlay's window property doesn't match the current window.
936
937 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
938 (Fwindow_hchild): Rename to Fwindow_left_child.
939 (Fwindow_next): Rename to Fwindow_next_sibling.
940 (Fwindow_prev): Rename to Fwindow_prev_sibling.
941 (resize_window_check): Rename to window_resize_check.
942 (resize_window_apply): Rename to window_resize_apply.
943 (Fresize_window_apply): Rename to Fwindow_resize_apply.
944 (Fdelete_other_windows_internal, resize_frame_windows)
945 (Fsplit_window_internal, Fdelete_window_internal)
946 (grow_mini_window, shrink_mini_window)
947 (Fresize_mini_window_internal): Fix callers accordingly.
948
949 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
950
951 * emacsgtkfixed.h: State that this is only used with Gtk+3.
952 (emacs_fixed_set_min_size): Remove.
953 (emacs_fixed_new): Take frame as argument.
954
955 * emacsgtkfixed.c: State that this is only used with Gtk+3.
956 (_EmacsFixedPrivate): Remove minwidth/height.
957 Add struct frame *f.
958 (emacs_fixed_init): Initialize priv->f.
959 (get_parent_class, emacs_fixed_set_min_size): Remove.
960 (emacs_fixed_new): Set priv->f to argument.
961 (emacs_fixed_get_preferred_width)
962 (emacs_fixed_get_preferred_height): Use min_width/height from
963 frames size_hint to set minimum and natural (Bug#8919).
964 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
965 and use min_width/height from frames size_hint to set
966 min_width/height (Bug#8919).
967
968 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
969 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
970 Fix indentation.
971
972 2011-06-26 Eli Zaretskii <eliz@gnu.org>
973
974 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
975 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
976 called at ZV.
977
978 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
979
980 * process.c (wait_reading_process_output): Bypass select if
981 waiting for a cell while ignoring keyboard input, and input is
982 pending. Suggested by Jan Djärv (Bug#8869).
983
984 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
985
986 Use gnulib's dup2 module instead of rolling our own.
987 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
988
989 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
990
991 * dispnew.c (scrolling_window): Before scrolling, turn off a
992 mouse-highlight in the window being scrolled.
993
994 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
995
996 Move DEFSYM to lisp.h and use everywhere.
997
998 * character.h (DEFSYM): Move declaration...
999 * lisp.h (DEFSYM): ...here.
1000
1001 * gnutls.c:
1002 * minibuf.c:
1003 * w32menu.c:
1004 * w32proc.c:
1005 * w32select.c: Don't include character.h.
1006
1007 * alloc.c (syms_of_alloc):
1008 * buffer.c (syms_of_buffer):
1009 * bytecode.c (syms_of_bytecode):
1010 * callint.c (syms_of_callint):
1011 * casefiddle.c (syms_of_casefiddle):
1012 * casetab.c (init_casetab_once):
1013 * category.c (init_category_once, syms_of_category):
1014 * ccl.c (syms_of_ccl):
1015 * cmds.c (syms_of_cmds):
1016 * composite.c (syms_of_composite):
1017 * dbusbind.c (syms_of_dbusbind):
1018 * dired.c (syms_of_dired):
1019 * dispnew.c (syms_of_display):
1020 * doc.c (syms_of_doc):
1021 * editfns.c (syms_of_editfns):
1022 * emacs.c (syms_of_emacs):
1023 * eval.c (syms_of_eval):
1024 * fileio.c (syms_of_fileio):
1025 * fns.c (syms_of_fns):
1026 * frame.c (syms_of_frame):
1027 * fringe.c (syms_of_fringe):
1028 * insdel.c (syms_of_insdel):
1029 * keymap.c (syms_of_keymap):
1030 * lread.c (init_obarray, syms_of_lread):
1031 * macros.c (syms_of_macros):
1032 * msdos.c (syms_of_msdos):
1033 * print.c (syms_of_print):
1034 * process.c (syms_of_process):
1035 * search.c (syms_of_search):
1036 * sound.c (syms_of_sound):
1037 * syntax.c (init_syntax_once, syms_of_syntax):
1038 * terminal.c (syms_of_terminal):
1039 * textprop.c (syms_of_textprop):
1040 * undo.c (syms_of_undo):
1041 * w32.c (globals_of_w32):
1042 * window.c (syms_of_window):
1043 * xdisp.c (syms_of_xdisp):
1044 * xfaces.c (syms_of_xfaces):
1045 * xfns.c (syms_of_xfns):
1046 * xmenu.c (syms_of_xmenu):
1047 * xsettings.c (syms_of_xsettings):
1048 * xterm.c (syms_of_xterm): Use DEFSYM.
1049
1050 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1051
1052 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1053
1054 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 Integer and buffer overflow fixes (Bug#8873).
1057
1058 * print.c (printchar, strout): Check for string overflow.
1059 (PRINTPREPARE, printchar, strout):
1060 Don't set size unless allocation succeeds.
1061
1062 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1063 for sizes. Check for string overflow more accurately.
1064 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1065
1066 * macros.c: Integer and buffer overflow fixes.
1067 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1068 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1069 Use ptrdiff_t, not int, for sizes.
1070 Don't increment bufsize until after realloc succeeds.
1071 Check for size-calculation overflow.
1072 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1073
1074 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1075
1076 * lread.c: Integer overflow fixes.
1077 (read_integer): Radix is now EMACS_INT, not int,
1078 to improve quality of diagnostics for out-of-range radices.
1079 Calculate buffer size correctly for out-of-range radices.
1080 (read1): Check for integer overflow in radices, and in
1081 read-circle numbers.
1082 (read_escape): Avoid int overflow.
1083 (Fload, openp, read_buffer_size, read1)
1084 (substitute_object_recurse, read_vector, read_list, map_obarray):
1085 Use ptrdiff_t, not int, for sizes.
1086 (read1): Use EMACS_INT, not int, for sizes.
1087 Check for size overflow.
1088
1089 * image.c (cache_image): Check for size arithmetic overflow.
1090
1091 * lread.c: Integer overflow issues.
1092 (saved_doc_string_size, saved_doc_string_length)
1093 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1094 Now ptrdiff_t, not int.
1095 (read1): Don't assume doc string length fits in int. Check for
1096 out-of-range doc string lengths.
1097 (read_list): Don't assume file position fits in int.
1098 (read_escape): Check for hex character overflow.
1099
1100 2011-06-22 Leo Liu <sdl.web@gmail.com>
1101
1102 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1103 Move to minibuffer.el.
1104
1105 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1108 The following patches are for when GLYPH_DEBUG && !XASSERT.
1109 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1110 * dispnew.c (flush_stdout):
1111 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1112 Mark as externally visible.
1113 * dispnew.c (check_window_matrix_pointers): Now static.
1114 * dispnew.c (window_to_frame_vpos):
1115 * xfns.c (unwind_create_frame):
1116 * xterm.c (x_check_font): Remove unused local.
1117 * scroll.c (CHECK_BOUNDS):
1118 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1119 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1120 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1121 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1122 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1123 Now static.
1124 (debug_method_add): Use va_list and vsprintf rather than relying
1125 on undefined behavior with wrong number of arguments.
1126 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1127 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1128 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1129 since we're not interested in debugging glyphs with old libraries.
1130 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1131 GCC 4.6.0's static checking.
1132
1133 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 Integer overflow and signedness fixes (Bug#8873).
1136 A few related buffer overrun fixes, too.
1137
1138 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1139
1140 * dispextern.h (struct face.stipple):
1141 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1142 (x_bitmap_mask, x_allocate_bitmap_record)
1143 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1144 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1145 (x_create_bitmap_from_xpm_data):
1146 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1147 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1148 (.bitmaps_last):
1149 * xfaces.c (load_pixmap):
1150 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1151 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1152 (.bitmaps_last, struct x_output.icon_bitmap):
1153 Use ptrdiff_t, not int, for bitmap indexes.
1154 (x_allocate_bitmap_record): Check for size overflow.
1155 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1156
1157 Use ptrdiff_t, not int, for overlay counts.
1158 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1159 * editfns.c (overlays_around, get_pos_property):
1160 * textprop.c (get_char_property_and_overlay):
1161 * xdisp.c (next_overlay_change, note_mouse_highlight):
1162 * xfaces.c (face_at_buffer_position):
1163 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1164 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1165 (Fnext_overlay_change, Fprevious_overlay_change)
1166 (mouse_face_overlay_overlaps, Foverlays_in):
1167 Use ptrdiff_t, not int, for sizes.
1168 (overlays_at, overlays_in): Check for size-calculation overflow.
1169
1170 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1171
1172 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1173 (x_session_initialize): Do not assume string length fits in int.
1174
1175 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1176 This is unlikely, but can occur if DPI is outlandish.
1177
1178 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1179 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1180
1181 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1182 * xrdb.c (magic_file_p, search_magic_path):
1183 Omit last arg SUFFIX; it was always 0. All callers changed.
1184 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1185
1186 * xfont.c (xfont_match): Avoid need for strlen.
1187
1188 * xfns.c: Don't assume strlen fits in int.
1189 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1190
1191 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1192 not unsigned long, as we prefer signed integers. All callers changed.
1193 Detect integer overflow in repeat count.
1194 (message_dolog): Don't assume print length fits in 39 bytes.
1195 (display_mode_element): Don't assume strlen fits in int.
1196
1197 * termcap.c: Don't assume sizes fit in int and never overflow.
1198 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1199 (gobble_line): Check for size-calculation overflow.
1200
1201 * minibuf.c (Fread_buffer):
1202 * lread.c (intern, intern_c_string):
1203 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1204 Don't assume string length fits in int.
1205
1206 * keyboard.c (parse_tool_bar_item):
1207 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1208
1209 * font.c: Don't assume string length fits in int.
1210 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1211 Use ptrdiff_t, not int.
1212 (font_intern_prop): Don't assume string length fits in int.
1213 Don't assume integer property fits in fixnum.
1214 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1215
1216 * filelock.c: Fix some buffer overrun and integer overflow issues.
1217 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1218 Reformulate so as not to need the command string.
1219 Invoke gzip -cd rather than gunzip, as it's more portable.
1220 (lock_info_type, lock_file_1, lock_file):
1221 Don't assume pid_t and time_t fit in unsigned long.
1222 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1223 (current_lock_owner): Prefer signed type for sizes.
1224 Use memcpy, not strncpy, where memcpy is what is really wanted.
1225 Don't assume (via atoi) that time_t and pid_t fit in int.
1226 Check for time_t and/or pid_t out of range, e.g., via a network share.
1227 Don't alloca where an auto var works fine.
1228
1229 * fileio.c: Fix some integer overflow issues.
1230 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1231 Don't assume string length fits in int.
1232 (directory_file_name): Don't assume string length fits in long.
1233 (make_temp_name): Don't assume pid fits in int, or that its print
1234 length is less than 20.
1235
1236 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1237
1238 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1239
1240 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1241
1242 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1243 We prefer signed integers, even for size calculations.
1244
1245 * emacs.c: Don't assume string length fits in 'int'.
1246 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1247 (main): Don't invoke strlen when not needed.
1248
1249 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1250 (XD_DEBUG_MESSAGE): Don't waste a byte.
1251
1252 * callproc.c (getenv_internal_1, getenv_internal)
1253 (Fgetenv_internal):
1254 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1255
1256 * lread.c (invalid_syntax): Omit length argument.
1257 All uses changed. This doesn't fix a bug, but it simplifies the
1258 code away from its former Hollerith-constant appearance, and it's
1259 one less 'int' to worry about when looking at integer-overflow issues.
1260 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1261
1262 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1263 This didn't break anything, but it didn't help either.
1264 It's confusing to put a bogus integer in a place where the actual
1265 value does not matter.
1266 (LIST_END_P): Remove unused macro and its bogus comment.
1267 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1268
1269 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1270 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1271 implementation.
1272 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1273 We prefer signed types, and the value cannot exceed the EMACS_INT
1274 range anyway (because otherwise the length would not be representable).
1275 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1276 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1277 This avoids a GCC warning when WIDE_EMACS_INT.
1278
1279 * indent.c (sane_tab_width): New function.
1280 (current_column, scan_for_column, Findent_to, position_indentation)
1281 (compute_motion): Use it. This is just for clarity.
1282 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1283
1284 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1285
1286 * lisp.h (lint_assume): New macro.
1287 * composite.c (composition_gstring_put_cache):
1288 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1289
1290 * editfns.c, insdel.c:
1291 Omit unnecessary forward decls, to simplify future changes.
1292
1293 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1294
1295 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1296
1297 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1298 Use much-faster test for byte-length change.
1299 Don't assume string byte-length fits in 'int'.
1300 Check that character arg fits in 'int'.
1301 (mapcar1): Declare byte as byte, for clarity.
1302
1303 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1304
1305 * fns.c (concat): Catch string overflow earlier.
1306 Do not rely on integer wraparound.
1307
1308 * dispextern.h (struct it.overlay_strings_charpos)
1309 (struct it.selective): Now EMACS_INT, not int.
1310 * xdisp.c (forward_to_next_line_start)
1311 (back_to_previous_visible_line_start)
1312 (reseat_at_next_visible_line_start, next_element_from_buffer):
1313 Don't arbitrarily truncate the value of 'selective' to int.
1314
1315 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1316
1317 * composite.c: Don't truncate sizes to 'int'.
1318 (composition_gstring_p, composition_reseat_it)
1319 (composition_adjust_point): Use EMACS_INT, not int.
1320 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1321 not EMACS_UINT, for indexes.
1322
1323 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1324
1325 * buffer.c: Include <verify.h>.
1326 (struct sortvec.priority, struct sortstr.priority):
1327 Now EMACS_INT, not int.
1328 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1329 (struct sortstr.size, record_overlay_string)
1330 (struct sortstrlist.size, struct sortlist.used):
1331 Don't truncate size to int.
1332 (record_overlay_string): Check for size-calculation overflow.
1333 (init_buffer_once): Check at compile-time, not run-time.
1334
1335 2011-06-22 Jim Meyering <meyering@redhat.com>
1336
1337 Don't leak an XBM-image-sized buffer
1338 * image.c (xbm_load): Free the image buffer after using it.
1339
1340 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 Port to Sun C.
1343 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1344 that Sun C diagnosed.
1345 * fns.c (secure_hash): Fix pointer signedness issue.
1346 * intervals.c (static_offset_intervals): New function.
1347 (offset_intervals): Use it.
1348
1349 2011-06-21 Leo Liu <sdl.web@gmail.com>
1350
1351 * deps.mk (fns.o):
1352 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1353 sha512.h.
1354
1355 * fns.c (secure_hash): Rename from crypto_hash_function and change
1356 the first arg to accept symbols.
1357 (Fsecure_hash): New primitive.
1358 (syms_of_fns): New symbols.
1359
1360 2011-06-20 Deniz Dogan <deniz@dogan.se>
1361
1362 * process.c (Fset_process_buffer): Clarify return value in
1363 docstring.
1364
1365 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1366
1367 * dispnew.c (add_window_display_history): Use BVAR.
1368
1369 * xdisp.c (debug_method_add): Use BVAR.
1370 (check_window_end, dump_glyph_matrix, dump_glyph)
1371 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1372
1373 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1374 Likewise.
1375
1376 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1377 check till after the cache is created in init_frame_faces.
1378
1379 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1380
1381 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1382
1383 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1386 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1387 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1388
1389 Improve buffer-overflow checking (Bug#8873).
1390 * fileio.c (Finsert_file_contents):
1391 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1392 Remove the old (too-loose) buffer overflow checks.
1393 They weren't needed, since make_gap checks for buffer overflow.
1394 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1395 The old code merely checked for Emacs fixnum overflow, and relied
1396 on undefined (wraparound) behavior. The new code avoids undefined
1397 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1398
1399 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1400 Tune. Don't use wider integers than needed. Don't use alloca.
1401 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1402
1403 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1404
1405 * insdel.c, lisp.h (buffer_overflow): New function.
1406 (insert_from_buffer_1, replace_range, replace_range_2):
1407 * insdel.c (make_gap_larger):
1408 * editfns.c (Finsert_char):
1409 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1410
1411 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1412
1413 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 Integer overflow and signedness fixes (Bug#8873).
1416
1417 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1418 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1419
1420 * fileio.c: Don't assume EMACS_INT fits in off_t.
1421 (emacs_lseek): New static function.
1422 (Finsert_file_contents, Fwrite_region): Use it.
1423 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1424
1425 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1426
1427 * fns.c: Don't overflow int when computing a list length.
1428 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1429 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1430 truncation on 64-bit hosts. Check for QUIT every
1431 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1432 faster and is responsive enough.
1433 (Flength): Report an error instead of overflowing an integer.
1434 (Fsafe_length): Return a float if the value is not representable
1435 as a fixnum. This shouldn't happen except in contrived situations.
1436 (Fnthcdr, Fsort): Don't assume list length fits in int.
1437 (Fcopy_sequence): Don't assume vector length fits in int.
1438
1439 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1440 (header_size, word_size): New constants.
1441 (allocate_vectorlike): Don't check size overflow here.
1442 (allocate_vector): Check it here instead, since this is the only
1443 caller of allocate_vectorlike that could cause overflow.
1444 Check that the new vector's length is representable as a fixnum.
1445
1446 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1447 The previous code was bogus. For example, next_almost_prime (32)
1448 returned 39, which is undesirable as it is a multiple of 3; and
1449 next_almost_prime (24) returned 25, which is a multiple of 5 so
1450 why was the code bothering to check for multiples of 7?
1451
1452 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1453
1454 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1455
1456 Variadic C functions now count arguments with ptrdiff_t.
1457 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1458 Back then I didn't know that the Emacs coding style prefers signed int.
1459 Also, in the meantime I found a few more instances where arguments
1460 were being counted with int, which may truncate counts on 64-bit
1461 machines, or EMACS_INT, which may be unnecessarily wide.
1462 * lisp.h (struct Lisp_Subr.function.aMANY)
1463 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1464 Arg counts are now ptrdiff_t, not size_t.
1465 All variadic functions and their callers changed accordingly.
1466 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1467 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1468 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1469 * callint.c (Fcall_interactively): Check arg count for overflow,
1470 to avoid potential buffer overrun. Use signed char, not 'int',
1471 for 'varies' array, so that we needn't bother to check its size
1472 calculation for overflow.
1473 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1474 * eval.c (apply_lambda):
1475 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1476 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1477 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1478
1479 * callint.c (Fcall_interactively): Don't use index var as event count.
1480
1481 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1482 * mem-limits.h (SIZE): Remove; no longer used.
1483
1484 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1485
1486 Remove unnecessary casts.
1487 * xterm.c (x_term_init):
1488 * xfns.c (x_set_border_pixel):
1489 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1490 These aren't needed now that we assume ANSI C.
1491
1492 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1493 It's more likely to cause problems (due to unsigned overflow)
1494 than to cure them.
1495
1496 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1497
1498 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1499
1500 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1501
1502 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1503
1504 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1505
1506 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1507
1508 GLYPH_CODE_FACE returns EMACS_INT, not int.
1509 * dispextern.h (merge_faces):
1510 * xfaces.c (merge_faces):
1511 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1512 Don't assume EMACS_INT fits in int.
1513
1514 * character.h (CHAR_VALID_P): Remove unused parameter.
1515 * fontset.c, lisp.h, xdisp.c: All uses changed.
1516
1517 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1518
1519 * fns.c (concat): Minor tuning based on overflow analysis.
1520 This doesn't fix any bugs. Use int to hold character, instead
1521 of constantly refetching from Emacs object. Use XFASTINT, not
1522 XINT, for value known to be a character. Don't bother comparing
1523 a single byte to 0400, as it's always less.
1524
1525 * floatfns.c (Fexpt):
1526 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1527
1528 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1529 for characters.
1530
1531 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1532
1533 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1534 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1535 incorrectly succeed when S was a string, because 4294967386 was
1536 truncated before it was used.
1537
1538 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1539 Otherwise, an out-of-range integer could cause undefined behavior
1540 on a 64-bit host.
1541
1542 * composite.c: Use int, not EMACS_INT, for characters.
1543 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1544 EMACS_INT, for values that are known to be in character range.
1545 This doesn't fix any bugs but is the usual style inside Emacs and
1546 may generate better code on 32-bit machines.
1547
1548 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1549 This is for reasons similar to the recent CHAR_STRING fix.
1550 * charset.c (Fencode_char): Check that character arg is actually
1551 a character. Pass an int to ENCODE_CHAR.
1552 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1553 wider than 'int', as a compile-time check to prevent future regressions
1554 in this area.
1555
1556 * character.c (char_string): Remove unnecessary casts.
1557
1558 Make sure a 64-bit char is never passed to CHAR_STRING.
1559 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1560 by silently ignoring the top 32 bits, allowing some values
1561 that were far too large to be valid characters.
1562 * character.h: Include <verify.h>.
1563 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1564 arguments are no wider than unsigned, as a compile-time check
1565 to prevent future regressions in this area.
1566 * data.c (Faset):
1567 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1568 (Fsubst_char_in_region):
1569 * fns.c (concat):
1570 * xdisp.c (decode_mode_spec_coding):
1571 Adjust to CHAR_STRING's new requirement.
1572 * editfns.c (Finsert_char, Fsubst_char_in_region):
1573 * fns.c (concat): Check that character args are actually
1574 characters. Without this test, these functions did the wrong
1575 thing with wildly out-of-range values on 64-bit hosts.
1576
1577 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1578 These casts should not be needed on 32-bit hosts, either.
1579 * keyboard.c (read_char):
1580 * lread.c (Fload): Remove casts to unsigned.
1581
1582 * lisp.h (UNSIGNED_CMP): New macro.
1583 This fixes comparison bugs on 64-bit hosts.
1584 (ASCII_CHAR_P): Use it.
1585 * casefiddle.c (casify_object):
1586 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1587 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1588 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1589 * dispextern.h (FACE_FROM_ID):
1590 * keyboard.c (read_char): Use UNSIGNED_CMP.
1591
1592 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1593 not to EMACS_INT, to avoid GCC warning.
1594
1595 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1596
1597 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1598 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1599 isn't needed on 32-bit machines.
1600
1601 * buffer.c (Fgenerate_new_buffer_name):
1602 Use EMACS_INT for count, not int.
1603 (advance_to_char_boundary): Return EMACS_INT, not int.
1604
1605 * data.c (Qcompiled_function): Now static.
1606
1607 * window.c (window_body_lines): Now static.
1608
1609 * image.c (gif_load): Rename local to avoid shadowing.
1610
1611 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1612 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1613 * alloc.c (make_save_value): Integer argument is now of type
1614 ptrdiff_t, not int.
1615 (mark_object): Use ptrdiff_t, not int.
1616 * lisp.h (pD): New macro.
1617 * print.c (print_object): Use it.
1618
1619 * alloc.c: Use EMACS_INT, not int, to count objects.
1620 (total_conses, total_markers, total_symbols, total_vector_size)
1621 (total_free_conses, total_free_markers, total_free_symbols)
1622 (total_free_floats, total_floats, total_free_intervals)
1623 (total_intervals, total_strings, total_free_strings):
1624 Now EMACS_INT, not int. All uses changed.
1625 (Fgarbage_collect): Compute overall total using a double, so that
1626 integer overflow is less likely to be a problem. Check for overflow
1627 when converting back to an integer.
1628 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1629 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1630 These were 'int' variables that could overflow on 64-bit hosts;
1631 they were never used, so remove them instead of repairing them.
1632 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1633 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1634 Previously, this ceilinged at INT_MAX, but that doesn't work on
1635 64-bit machines.
1636 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1637
1638 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1639 (allocate_vectorlike): Check for ptrdiff_t overflow.
1640 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1641 when a (possibly-narrower) signed value would do just as well.
1642 We prefer using signed arithmetic, to avoid comparison confusion.
1643
1644 * alloc.c: Catch some string size overflows that we were missing.
1645 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1646 for convenience in STRING_BYTES_MAX.
1647 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1648 The definition here is exact; the one in lisp.h was approximate.
1649 (allocate_string_data): Check for string overflow. This catches
1650 some instances we weren't catching before. Also, it catches
1651 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1652 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1653 and ptrdiff_t and EMACS_INT are both 64 bits.
1654
1655 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1656 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1657 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1658
1659 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1660
1661 * alloc.c (Fmake_string): Check for out-of-range init.
1662
1663 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1664
1665 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1666
1667 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1668
1669 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1670 xg_get_default_scrollbar_width.
1671
1672 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1673 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1674 (style_changed_cb): Call update_theme_scrollbar_width and call
1675 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1676 all frames (Bug#8505).
1677 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1678 Call gtk_window_set_resizable if HAVE_GTK3.
1679 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1680 and height if HAVE_GTK3 (Bug#8505).
1681 (scroll_bar_width_for_theme): New variable.
1682 (update_theme_scrollbar_width): New function.
1683 (xg_get_default_scrollbar_width): Move code to
1684 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1685 (xg_initialize): Call update_theme_scrollbar_width.
1686
1687 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1688
1689 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1690
1691 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1692
1693 * frame.c (make_frame): Call other_buffer_safely instead of
1694 other_buffer.
1695
1696 * window.c (temp_output_buffer_show): Call display_buffer with
1697 second argument Vtemp_buffer_show_specifiers and reset latter
1698 immediately after the call.
1699 (Vtemp_buffer_show_specifiers): New variable.
1700 (auto_window_vscroll_p, next_screen_context_lines)
1701 (Vscroll_preserve_screen_position): Remove leading asterisks from
1702 doc-strings.
1703
1704 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 Fix minor problems found by GCC 4.6.0 static checking.
1707 * buffer.c (Qclone_number): Remove for now, as it's unused.
1708 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1709 (record_buffer): Remove unused local.
1710 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1711 (set_frame_buffer_list): Remove; unused.
1712 * frame.h (other_visible_frames): Remove decl.
1713 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1714 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1715 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1716 if HAVE_GPM.
1717 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1718 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1719 Define only if HAVE_GPM.
1720 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1721 (update_hints_inhibit): Remove; never set. All uses removed.
1722 * widgetprv.h (emacsFrameClassRec): Remove decl.
1723 * window.c (delete_deletable_window): Now returns void, since it
1724 wasn't returning anything.
1725 (compare_window_configurations): Remove unused locals.
1726 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1727 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1728 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1729 the same widths as pointers. This follows up on the 2011-05-06 patch.
1730 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1731 * xterm.h: Likewise.
1732 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1733
1734 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * makefile.w32-in: Update dependencies.
1737 (LISP_H): Add lib/intprops.h.
1738
1739 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1740
1741 * image.c (gif_load): Add animation frame delay to the metadata.
1742 (syms_of_image): Use DEFSYM. New symbol `delay'.
1743
1744 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1745
1746 * window.c (delete_deletable_window): Re-add.
1747 (Fset_window_configuration): Rewrite to handle dead buffers and
1748 consequently deletable windows.
1749 (window_tree, Fwindow_tree): Remove. Supply functionality in
1750 window.el.
1751 (compare_window_configurations): Simplify code.
1752
1753 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1754
1755 * image.c (imagemagick_load_image): Fix type mismatch.
1756 (Fimagemagick_types): Likewise.
1757
1758 * window.h (replace_buffer_in_windows): Declare.
1759
1760 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1761
1762 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1763 Qclone_number. Remove external declaration of Qdelete_window.
1764 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1765 code.
1766 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1767 Qbuffer_list_update_hook if allowed.
1768 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1769 buffer list implementation.
1770 (other_buffer_safely): New function.
1771 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1772 calls to replace_buffer_in_windows and
1773 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1774 if allowed.
1775 (record_buffer): Inhibit quitting and rewrite using quittable
1776 functions. Run Qbuffer_list_update_hook if allowed.
1777 (Frecord_buffer, Funrecord_buffer): New functions.
1778 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1779 switch-to-buffer to window.el.
1780 (bury-buffer): Move to window.el.
1781 (Vbuffer_list_update_hook): New variable.
1782
1783 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1784 section.
1785
1786 * window.h (resize_frame_windows): Move up in code.
1787 (Fwindow_frame): Remove EXFUN.
1788 (replace_buffer_in_all_windows): Remove prototype.
1789 (replace_buffer_in_windows_safely): Add prototype.
1790
1791 * window.c: Declare Qdelete_window static again. Move down
1792 declaration of select_count.
1793 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1794 (Fother_window): Move to window.el.
1795 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1796 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1797 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1798 window.el.
1799 (replace_buffer_in_windows): Implement by calling
1800 Qreplace_buffer_in_windows.
1801 (replace_buffer_in_all_windows): Remove with some functionality
1802 moved into replace_buffer_in_windows_safely.
1803 (replace_buffer_in_windows_safely): New function.
1804 (select_window_norecord, select_frame_norecord): Move in front
1805 of run_window_configuration_change_hook. Remove now obsolete
1806 declarations.
1807 (Fset_window_buffer): Rewrite doc-string. Call
1808 Qrecord_window_buffer.
1809 (keys_of_window): Move binding for other-window to window.el.
1810
1811 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1812
1813 * dispextern.h (struct image): Replace data member, whose int_val
1814 and ptr_val fields were not used by anything, with a single
1815 lisp_val object.
1816
1817 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1818 (gif_clear_image, gif_load, imagemagick_load_image)
1819 (gs_clear_image, gs_load): Callers changed.
1820
1821 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * buffer.h: Include <time.h>, for time_t.
1824 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1825
1826 Fix minor problems found by static checking.
1827
1828 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1829
1830 Make identifiers static if they are not used in other modules.
1831 * data.c (Qcompiled_function, Qframe, Qvector):
1832 * image.c (QimageMagick, Qsvg):
1833 * minibuf.c (Qmetadata):
1834 * window.c (resize_window_check, resize_root_window): Now static.
1835 * window.h (resize_window_check, resize_root_window): Remove decls.
1836
1837 * window.c (window_deletion_count, delete_deletable_window):
1838 Remove; unused.
1839 (window_body_lines): Now static.
1840 (Fdelete_other_windows_internal): Mark vars as initialized.
1841 Make sure 'resize_failed' is initialized.
1842 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1843 (resize_window_apply): Remove unused local.
1844 * window.h (delete_deletable_window): Remove decl.
1845
1846 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1847 (imagemagick_load_image): Fix pointer signedness problem by changing
1848 last arg from unsigned char * to char *. All uses changed.
1849 Also, fix a local for similar reasons.
1850 Remove unused locals. Remove locals to avoid shadowing.
1851 (fn_rsvg_handle_free): Remove; unused.
1852 (svg_load, svg_load_image): Fix pointer signedness problem.
1853 (imagemagick_load_image): Don't use garbage pointer image_wand.
1854
1855 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1856
1857 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1858
1859 * image.c (gif_load): Fix omitted cast error introduced by
1860 2011-06-06 change.
1861
1862 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1863
1864 * window.h (resize_proportionally, orig_total_lines)
1865 (orig_top_line): Remove from window structure.
1866 (set_window_height, set_window_width, change_window_heights)
1867 (Fdelete_window): Remove prototypes.
1868 (resize_frame_windows): Remove duplicate declaration.
1869
1870 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1871
1872 * window.h (resize_frame_windows, resize_window_check)
1873 (delete_deletable_window, resize_root_window)
1874 (resize_frame_windows): Declare prototypes.
1875
1876 * window.c (resize_window_apply): Make definition be "static" to
1877 match the prototype.
1878
1879 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1880
1881 * window.c: Remove declarations of Qwindow_size_fixed,
1882 window_min_size_1, window_min_size_2, window_min_size,
1883 size_window, window_fixed_size_p, enlarge_window, delete_window.
1884 Remove static from declaration of Qdelete_window, it's
1885 temporarily needed by Fbury_buffer.
1886 (replace_window): Don't assign orig_top_line and
1887 orig_total_lines.
1888 (Fdelete_window, delete_window): Remove. Window deletion is
1889 handled by window.el.
1890 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1891 Fdelete_window calls with calls to Qdelete_window.
1892 (Fdelete_other_windows): Remove. Deleting other windows is
1893 handled by window.el.
1894 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1895 handled in window.el.
1896 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1897 Window minimum sizes are handled in window.el.
1898 (shrink_windows, size_window, set_window_height)
1899 (set_window_width, change_window_heights, window_height)
1900 (window_width, CURBEG, CURSIZE, enlarge_window)
1901 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1902 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1903 handled in window.el.
1904 (make_dummy_parent): Rename to make_parent_window and give it a
1905 second argument horflag.
1906 (make_window): Don't set resize_proportionally any more.
1907 (Fsplit_window): Remove. Windows are split in window.el.
1908 (save_restore_action, save_restore_orig_size)
1909 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1910 Resize mini windows in window.el.
1911 (grow_mini_window, shrink_mini_window): Implement by calling
1912 Qresize_root_window_vertically, resize_window_check and
1913 resize_window_apply.
1914 (saved_window, Fset_window_configuration, save_window_save): Do
1915 not handle orig_top_line, orig_total_lines, and
1916 resize_proportionally.
1917 (window_min_height, window_min_width): Move to window.el.
1918 (keys_of_window): Move bindings for delete-other-windows,
1919 split-window, delete-window and enlarge-window to window.el.
1920
1921 * buffer.c: Temporarily extern Qdelete_window.
1922 (Fbury_buffer): Temporarily call Qdelete_window instead of
1923 Fdelete_window (Fbury_buffer will move to window.el soon).
1924
1925 * frame.c (set_menu_bar_lines_1): Remove code handling
1926 orig_top_line and orig_total_lines.
1927
1928 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1929 set_window_height but set heights directly.
1930 (change_frame_size_1): Use resize_frame_windows.
1931
1932 * xdisp.c (init_xdisp): Don't use set_window_height but set
1933 heights directly.
1934
1935 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1936 resize_frame_windows instead of change_window_heights and run
1937 run_window_configuration_change_hook.
1938
1939 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1940 instead of change_window_heights and run
1941 run_window_configuration_change_hook.
1942
1943 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1944
1945 * window.c (replace_window): Rename second argument REPLACEMENT to
1946 NEW. New third argument SETFLAG. Rewrite.
1947 (delete_window, make_dummy_parent): Call replace_window with
1948 third argument 1.
1949 (window_list_1): Move down in code.
1950 (run_window_configuration_change_hook): Move set_buffer part
1951 before select_frame_norecord part in order to unwind correctly.
1952 Rename count1 to count.
1953 (recombine_windows, delete_deletable_window, resize_root_window)
1954 (Fdelete_other_windows_internal)
1955 (Frun_window_configuration_change_hook, make_parent_window)
1956 (resize_window_check, resize_window_apply, Fresize_window_apply)
1957 (resize_frame_windows, Fsplit_window_internal)
1958 (Fdelete_window_internal, Fresize_mini_window_internal): New
1959 functions.
1960 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1961
1962 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1963
1964 * window.h (window): Add some new members to window structure -
1965 normal_lines, normal_cols, new_total, new_normal, clone_number,
1966 splits, nest, prev_buffers, next_buffers.
1967 (WINDOW_TOTAL_SIZE): Move here from window.c.
1968 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1969
1970 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1971 Remove.
1972 (make_dummy_parent): Set new members of windows structure.
1973 (make_window): Move down in code. Handle new members of window
1974 structure.
1975 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1976 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1977 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1978 (Fset_window_prev_buffers, Fwindow_next_buffers)
1979 (Fset_window_next_buffers, Fset_window_clone_number): New
1980 functions.
1981 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1982 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1983 Doc-string fixes.
1984 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1985 Argument WINDOW can be now internal window too.
1986 (Fwindow_use_time): Move up in code.
1987 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1988 Rewrite doc-string.
1989 (Fset_window_configuration, saved_window)
1990 (Fcurrent_window_configuration, save_window_save): Handle new
1991 members of window structure.
1992 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1993 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1994 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1995 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1996 Qget_mru_window, Qresize_root_window,
1997 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1998 Qauto_buffer_name; staticpro them.
1999
2000 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2001
2002 * window.c (Fwindow_total_size, Fwindow_left_column)
2003 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2004 (Fwindow_list_1): New functions.
2005 (window_box_text_cols): Replace with window_body_cols.
2006 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2007 window_body_cols instead of window_box_text_cols.
2008 (delete_window, Fset_window_configuration): Call
2009 delete_all_subwindows with window as argument.
2010 (delete_all_subwindows): Take a window as argument and not a
2011 structure. Rewrite.
2012 (window_loop): Remove handling of GET_LRU_WINDOW and
2013 GET_LARGEST_WINDOW.
2014 (Fget_lru_window, Fget_largest_window): Move to window.el.
2015
2016 * window.h: Extern window_body_cols instead of
2017 window_box_text_cols. delete_all_subwindows now takes a
2018 Lisp_Object as argument.
2019
2020 * indent.c (compute_motion, Fcompute_motion): Use
2021 window_body_cols instead of window_box_text_cols.
2022
2023 * frame.c (delete_frame): Call delete_all_subwindows with root
2024 window as argument.
2025
2026 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2027
2028 * fns.c (Fputhash): Document return value.
2029
2030 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2031
2032 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2033
2034 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 Cons<->int and similar integer overflow fixes (Bug#8794).
2037
2038 Check for overflow when converting integer to cons and back.
2039 * charset.c (Fdefine_charset_internal, Fdecode_char):
2040 Use cons_to_unsigned to catch overflow.
2041 (Fencode_char): Use INTEGER_TO_CONS.
2042 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2043 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2044 * data.c (long_to_cons, cons_to_long): Remove.
2045 (cons_to_unsigned, cons_to_signed): New functions.
2046 These signal an error for invalid or out-of-range values.
2047 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2048 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2049 * font.c (Ffont_variation_glyphs):
2050 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2051 * lisp.h: Include <intprops.h>.
2052 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2053 (cons_to_signed, cons_to_unsigned): New decls.
2054 (long_to_cons, cons_to_long): Remove decls.
2055 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2056 (Fprimitive_undo): Use CONS_TO_INTEGER.
2057 * xfns.c (Fx_window_property): Likewise.
2058 * xselect.c: Include <limits.h>.
2059 (x_own_selection, selection_data_to_lisp_data):
2060 Use INTEGER_TO_CONS.
2061 (x_handle_selection_request, x_handle_selection_clear)
2062 (x_get_foreign_selection, Fx_disown_selection_internal)
2063 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2064 (lisp_data_to_selection_data): Use cons_to_unsigned.
2065 (x_fill_property_data): Use cons_to_signed.
2066 Report values out of range.
2067
2068 Check for buffer and string overflow more precisely.
2069 * buffer.h (BUF_BYTES_MAX): New macro.
2070 * lisp.h (STRING_BYTES_MAX): New macro.
2071 * alloc.c (Fmake_string):
2072 * character.c (string_escape_byte8):
2073 * coding.c (coding_alloc_by_realloc):
2074 * doprnt.c (doprnt):
2075 * editfns.c (Fformat):
2076 * eval.c (verror):
2077 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2078 since they may not be the same number.
2079 * editfns.c (Finsert_char):
2080 * fileio.c (Finsert_file_contents):
2081 Likewise for BUF_BYTES_MAX.
2082
2083 * image.c: Use ptrdiff_t, not int, for sizes.
2084 (slurp_file): Switch from int to ptrdiff_t.
2085 All uses changed.
2086 (slurp_file): Check that file size fits in both size_t (for
2087 malloc) and ptrdiff_t (for sanity and safety).
2088
2089 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2090 if b->modtime has its maximal value.
2091
2092 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2093
2094 Don't assume time_t can fit into int.
2095 * buffer.h (struct buffer.modtime): Now time_t, not int.
2096 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2097 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2098
2099 Minor fixes for signed vs unsigned integers.
2100 * character.h (MAYBE_UNIFY_CHAR):
2101 * charset.c (maybe_unify_char):
2102 * keyboard.c (read_char, reorder_modifiers):
2103 XINT -> XFASTINT, since the integer must be nonnegative.
2104 * ftfont.c (ftfont_spec_pattern):
2105 * keymap.c (access_keymap, silly_event_symbol_error):
2106 XUINT -> XFASTINT, since the integer must be nonnegative.
2107 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2108 since it makes no difference and we prefer signed.
2109 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2110 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2111 nonnegative.
2112
2113 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2114
2115 * window.h (Fwindow_frame): Declare.
2116
2117 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2120 (SPARE_MEMORY): Always define.
2121 (LARGE_REQUEST): Remove.
2122 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2123
2124 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2125
2126 * lisp.h: Move EXFUNS for Fframe_root_window,
2127 Fframe_first_window and Fset_frame_selected_window to window.h.
2128
2129 * window.h: Move EXFUNS for Fframe_root_window,
2130 Fframe_first_window and Fset_frame_selected_window here from
2131 lisp.h.
2132
2133 * frame.c (Fwindow_frame, Fframe_first_window)
2134 (Fframe_root_window, Fframe_selected_window)
2135 (Fset_frame_selected_window): Move to window.c.
2136 (Factive_minibuffer_window): Move to minibuf.c.
2137 (Fother_visible_frames_p): New function.
2138
2139 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2140
2141 * window.c (decode_window, decode_any_window): Move up in code.
2142 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2143 (inhibit_frame_unsplittable): Remove unused variable.
2144 (Fwindow_buffer): Move up and rewrite doc-string.
2145 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2146 (Fwindow_prev): New functions.
2147 (Fwindow_frame): Move here from frame.c. Accept any window as
2148 argument.
2149 (Fframe_root_window, Fframe_first_window)
2150 (Fframe_selected_window): Move here from frame.c. Accept frame
2151 or arbitrary window as argument. Update doc-strings.
2152 (Fminibuffer_window): Move up in code.
2153 (Fwindow_minibuffer_p): Move up in code and simplify.
2154 (Fset_frame_selected_window): Move here from frame.c.
2155 Marginal rewrite.
2156 (Fselected_window, select_window, Fselect_window): Move up in
2157 code. Minor doc-string fixes.
2158
2159 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2162 Do not assume that spare memory exists; that assumption is valid
2163 only if SYSTEM_MALLOC.
2164 (LARGE_REQUEST): New macro, so that the issue of large requests
2165 is separated from the issue of spare memory.
2166
2167 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2168
2169 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2170 format. (Bug#8806)
2171
2172 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2173
2174 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2175 before statements.
2176
2177 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2178
2179 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2180
2181 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2182
2183 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2184 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2185
2186 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2187
2188 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2189
2190 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2193 (x_clipboard_manager_save): Add return value.
2194 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2195 New error handlers.
2196 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2197 Obey Vx_select_enable_clipboard_manager. Catch errors in
2198 x_clipboard_manager_save (Bug#8779).
2199 (Vx_select_enable_clipboard_manager): New variable.
2200 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2201
2202 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2203
2204 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2205
2206 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2207
2208 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2209 in the current matrix if keep_current_p is non-zero.
2210
2211 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2212
2213 * bidi.c (bidi_level_of_next_char): Fix last change.
2214
2215 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2216
2217 Support bidi reordering of text covered by display properties.
2218
2219 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2220 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2221 (bidi_cache_search, bidi_cache_iterator_state)
2222 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2223 (bidi_level_of_next_char, bidi_move_to_visually_next):
2224 Support character positions inside a run of characters covered by a
2225 display string.
2226 (bidi_paragraph_init, bidi_resolve_explicit_1)
2227 (bidi_level_of_next_char): Call bidi_fetch_char and
2228 bidi_fetch_char_advance instead of FETCH_CHAR and
2229 FETCH_CHAR_ADVANCE.
2230 (bidi_init_it): Initialize new members.
2231 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2232 definitions.
2233 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2234 instead of using explicit *_CHAR codes.
2235 (bidi_resolve_explicit, bidi_resolve_weak):
2236 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2237 bidirectional text is supported only in multibyte buffers.
2238 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2239 it to initialize the frame_window_p member of struct bidi_it.
2240 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2241 (bidi_resolve_explicit, bidi_resolve_weak)
2242 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2243 bidi_it->nchars is non-positive.
2244 (bidi_level_of_next_char): Don't try to lookup the cache for the
2245 next/previous character if nothing is cached there yet, or if we
2246 were just reseat()'ed to a new position.
2247
2248 * xdisp.c (set_cursor_from_row): Set start and stop points
2249 according to the row's direction when priming the loop that looks
2250 for the glyph on which to display cursor.
2251 (single_display_spec_intangible_p): Function deleted.
2252 (display_prop_intangible_p): Reimplement to call
2253 handle_display_spec instead of single_display_spec_intangible_p.
2254 Accept 3 additional arguments needed by handle_display_spec.
2255 This fixes incorrect cursor motion across display property with complex
2256 values: lists, `(when COND...)' forms, etc.
2257 (single_display_spec_string_p): Support property values that are
2258 lists with the argument STRING its top-level element.
2259 (display_prop_string_p): Fix the condition for processing a
2260 property that is a list to be consistent with handle_display_spec.
2261 (handle_display_spec): New function, refactored from the
2262 last portion of handle_display_prop.
2263 (compute_display_string_pos): Accept additional argument
2264 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2265 value of a `display' property is a "replacing spec".
2266 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2267 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2268 the display property, but just return a value indicating whether
2269 the display property will replace the characters it covers.
2270 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2271 frame_window_p members of struct bidi_it.
2272 (compute_display_string_pos, compute_display_string_end):
2273 New functions.
2274 (push_it): Accept second argument POSITION, where pop_it should
2275 jump to continue iteration.
2276 (reseat_1): Initialize bidi_it.disp_pos.
2277
2278 * keyboard.c (adjust_point_for_property): Adjust the call to
2279 display_prop_intangible_p to its new signature.
2280
2281 * dispextern.h (struct bidi_it): New member frame_window_p.
2282 (bidi_init_it): Update prototypes.
2283 (display_prop_intangible_p): Update prototype.
2284 (compute_display_string_pos, compute_display_string_end):
2285 Declare prototypes.
2286 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2287 EMACS_INT.
2288
2289 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Malloc failure behavior now depends on size of allocation.
2292 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2293 * lisp.h: Change signatures accordingly.
2294 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2295 All callers changed. (Bug#8762)
2296
2297 * gnutls.c: Use Emacs's memory allocators.
2298 Without this change, the gnutls library would invoke malloc etc.
2299 directly, which causes problems on non-SYNC_INPUT hosts, and which
2300 runs afoul of improving memory_full behavior. (Bug#8761)
2301 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2302 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2303 xfree instead of the default malloc, realloc, free.
2304 (Fgnutls_boot): No need to check for memory allocation failure,
2305 since xmalloc does that for us.
2306
2307 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2308 * category.c (hash_get_category_set):
2309 * ccl.c (ccl_driver):
2310 * charset.c (Fdefine_charset_internal):
2311 * charset.h (struct charset.hash_index):
2312 * composite.c (get_composition_id, gstring_lookup_cache)
2313 (composition_gstring_put_cache):
2314 * composite.h (struct composition.hash_index):
2315 * dispextern.h (struct image.hash):
2316 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2317 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2318 (hashfn_equal, hashfn_user_defined, make_hash_table)
2319 (maybe_resize_hash_table, hash_lookup, hash_put)
2320 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2321 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2322 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2323 * image.c (make_image, search_image_cache, lookup_image)
2324 (xpm_put_color_table_h):
2325 * lisp.h (struct Lisp_Hash_Table):
2326 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2327 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2328 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2329 * alloc.c (allocate_vectorlike):
2330 Check for overflow in vector size calculations.
2331 * ccl.c (ccl_driver):
2332 Check for overflow when converting EMACS_INT to int.
2333 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2334 need to be updated by these changes.
2335 * fns.c (make_hash_table, maybe_resize_hash_table):
2336 Check for integer overflow with large hash tables.
2337 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2338 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2339 (SXHASH_REDUCE): New macro.
2340 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2341 Use it instead of discarding useful hash info with large hash values.
2342 (sxhash_float): New function.
2343 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2344 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2345 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2346 Rewrite to use FIXNUM_BITS, as this simplifies things.
2347 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2348 Adjust signatures to match updated version of code.
2349 (consing_since_gc): Now EMACS_INT, since a single hash table can
2350 use more than INT_MAX bytes.
2351
2352 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2353
2354 Make it possible to build with GCC-4.6+ -O2 -flto.
2355
2356 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2357
2358 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2359
2360 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2361 Call minibuffer-inactive-mode.
2362
2363 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2366 Update dependencies.
2367
2368 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2369
2370 * data.c (init_data): Remove code for UTS, this system is not
2371 supported anymore.
2372
2373 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2374
2375 Don't force ./temacs to start in terminal mode.
2376
2377 * frame.c (make_initial_frame): Initialize faces in all cases, not
2378 only when CANNOT_DUMP is defined.
2379 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2380
2381 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2382
2383 * dispnew.c (add_window_display_history): Use const for the string
2384 pointer. Remove declaration, not needed.
2385
2386 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 Use 'inline', not 'INLINE'.
2389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2390 * alloc.c, fontset.c (INLINE): Remove.
2391 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2392 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2393 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2394 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2395 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2396
2397 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2398
2399 Make it possible to run ./temacs.
2400
2401 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2402 syms_of_callproc does the same thing. Remove test for
2403 "initialized", do it in the caller.
2404 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2405
2406 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2407
2408 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2409 (read_minibuf): Use get_minibuffer.
2410 (syms_of_minibuf): Use DEFSYM.
2411 (Qmetadata): New var.
2412 * data.c (Qbuffer): Don't make it static.
2413 (syms_of_data): Use DEFSYM.
2414
2415 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2418 (CCL_CODE_MIN): New macro.
2419
2420 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2423
2424 * eval.c (Qdebug): Now static.
2425 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2426 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2427 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2428
2429 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2430
2431 * image.c: Various fixes to ImageMagick code comments.
2432 (Fimagemagick_types): Doc fix.
2433
2434 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 Minor fixes prompted by GCC 4.6.0 warnings.
2437
2438 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2439
2440 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2441 (x_clipboard_manager_save_all): Move extern decl to ...
2442 * xterm.h: ... here, so that it can be checked for consistency.
2443
2444 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2445
2446 * xselect.c (x_clipboard_manager_save_frame)
2447 (x_clipboard_manager_save_all): New functions.
2448 (Fx_clipboard_manager_save): Lisp function deleted.
2449
2450 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2451 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2452
2453 * xterm.h: Update prototype.
2454
2455 2011-05-28 William Xu <william.xwl@gmail.com>
2456
2457 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2458 exiting (Bug#8239).
2459
2460 2011-05-28 Jim Meyering <meyering@redhat.com>
2461
2462 Avoid a sign-extension bug in crypto_hash_function.
2463 * fns.c (to_uchar): Define.
2464 (crypto_hash_function): Use it to convert some newly-signed
2465 variables to unsigned, to avoid sign-extension bugs. For example,
2466 without this change, (md5 "truc") would evaluate to
2467 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2468 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2469 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2470
2471 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 Integer overflow fixes.
2474
2475 * dbusbind.c: Serial number integer overflow fixes.
2476 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2477 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2478 to hold a serial number that is too large for a fixnum.
2479 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2480 Check for serial numbers out of range. Decode any serial number
2481 that was so large that it became a float. (Bug#8722)
2482
2483 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2484 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2485 Use XFASTINT rather than XUINT when numbers are nonnegative.
2486 (xd_append_arg, Fdbus_method_return_internal):
2487 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2488 arguments, check that Lisp number is nonnegative, rather than
2489 silently wrapping negative numbers around. (Bug#8722)
2490 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2491 (Bug#8722)
2492
2493 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2494
2495 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2496
2497 ccl: add integer overflow checks
2498 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2499 (IN_INT_RANGE): New macros.
2500 (ccl_driver): Use them to check for integer overflow when
2501 decoding a CCL program. Many of the new checks are whether XINT (x)
2502 fits in int; it doesn't always, on 64-bit hosts. The new version
2503 doesn't catch all possible integer overflows, but it's an
2504 improvement. (Bug#8719)
2505
2506 * alloc.c (make_event_array): Use XINT, not XUINT.
2507 There's no need for unsigned here.
2508
2509 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2510 This follows up to the 2011-05-06 change that substituted uintptr_t
2511 for EMACS_INT. This case wasn't caught back then.
2512
2513 Rework Fformat to avoid integer overflow issues.
2514 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2515 now (part of C89). Include <verify.h>.
2516 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2517 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2518 (Fformat): Avoid the prepass trying to compute sizes; it was only
2519 approximate and thus did not catch overflow reliably. Instead, walk
2520 through the format just once, formatting and computing sizes as we go,
2521 checking for integer overflow at every step, and allocating a larger
2522 buffer as needed. Keep track separately whether the format is
2523 multibyte. Keep only the most-recently calculated precision, rather
2524 than them all. Record whether each argument has been converted to
2525 string. Use EMACS_INT, not int, for byte and char and arg counts.
2526 Support field widths and precisions larger than INT_MAX. Avoid
2527 sprintf's undefined behavior with conversion specifications such as %#d
2528 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2529 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2530 formatting out-of-range floating point numbers with int
2531 formats. (Bug#8668)
2532
2533 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2534
2535 * data.c: Avoid integer truncation in expressions involving floats.
2536 * data.c: Include <intprops.h>.
2537 (arith_driver): When there's an integer overflow in an expression
2538 involving floating point, convert the integers to floating point
2539 so that the resulting value does not suffer from catastrophic
2540 integer truncation. For example, on a 64-bit host (* 4
2541 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2542 Do not rely on undefined behavior after integer overflow.
2543
2544 merge count_size_as_multibyte, parse_str_to_multibyte
2545 * character.c, character.h (count_size_as_multibyte):
2546 Rename from parse_str_to_multibyte; all uses changed.
2547 Check for integer overflow.
2548 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2549 since it's now a duplicate of the other. This is more of
2550 a character than a buffer op, so better that it's in character.c.
2551 * fns.c, print.c: Adjust to above changes.
2552
2553 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2554
2555 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2556
2557 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2560 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2561 (x_clipboard_manager_save): Now static.
2562 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2563
2564 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2565 (crypto_hash_function): Now static.
2566 Fix pointer signedness problems. Avoid unnecessary initializations.
2567
2568 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2569
2570 * termhooks.h (Vselection_alist): Make it terminal-local.
2571
2572 * terminal.c (create_terminal): Initialize it.
2573
2574 * xselect.c: Support for clipboard managers.
2575 (Vselection_alist): Move to termhooks.h as terminal-local var.
2576 (LOCAL_SELECTION): New macro.
2577 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2578 (symbol_to_x_atom): Remove gratuitous arg.
2579 (x_handle_selection_request, lisp_data_to_selection_data)
2580 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2581 (x_own_selection, x_get_local_selection, x_convert_selection):
2582 New arg, specifying work frame. Use terminal-local Vselection_alist.
2583 (some_frame_on_display): Delete unused function.
2584 (Fx_own_selection_internal, Fx_get_selection_internal)
2585 (Fx_disown_selection_internal, Fx_selection_owner_p)
2586 (Fx_selection_exists_p): New optional frame arg.
2587 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2588 (x_handle_selection_clear): Don't treat other terminals with the
2589 same keyboard specially. Use the terminal-local Vselection_alist.
2590 (x_clear_frame_selections): Use Frun_hook_with_args.
2591
2592 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2593
2594 * xterm.h: Add support for those atoms.
2595
2596 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2597
2598 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2599 (converted_selections, conversion_fail_tag): New global variables.
2600 (x_selection_request_lisp_error): Free the above.
2601 (x_get_local_selection): Remove unnecessary code.
2602 (x_reply_selection_request): Args changed; handle arbitrary array
2603 of converted selections stored in converted_selections.
2604 Separate the XChangeProperty and SelectionNotify steps.
2605 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2606 (x_convert_selection): New function.
2607 (x_handle_selection_event): Simplify.
2608 (x_get_foreign_selection): Don't ignore incoming requests while
2609 waiting for an answer; this will fail when we implement
2610 SAVE_TARGETS, and seems unnecessary anyway.
2611 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2612 (Vx_sent_selection_functions): Doc fix.
2613
2614 2011-05-26 Leo Liu <sdl.web@gmail.com>
2615
2616 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2617
2618 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2619
2620 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2621
2622 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2623 for fringe update if it has periodic bitmap.
2624 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2625 and fringe_bitmap_periodic_p.
2626
2627 * fringe.c (get_fringe_bitmap_data): New function.
2628 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2629 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2630 row. Mark glyph row for fringe update if periodicity changed.
2631
2632 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2633 for fringe update unless it has periodic bitmap.
2634
2635 2011-05-25 Kenichi Handa <handa@m17n.org>
2636
2637 * xdisp.c (get_next_display_element): Set correct it->face_id for
2638 a static composition.
2639
2640 2011-05-24 Leo Liu <sdl.web@gmail.com>
2641
2642 * deps.mk (fns.o):
2643 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2644
2645 * fns.c (crypto_hash_function, Fsha1): New function.
2646 (Fmd5): Use crypto_hash_function.
2647 (syms_of_fns): Add Ssha1.
2648
2649 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2650
2651 * gnutls.c: Remove unused macros.
2652 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2653 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2654 Remove macros that are defined and never used.
2655 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2656
2657 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2658
2659 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2660 (Fx_get_selection_internal): Minor cleanup.
2661 (Fx_own_selection_internal): Rename arguments for consistency with
2662 select.el.
2663
2664 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2667
2668 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2669
2670 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2671
2672 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2673
2674 * dispnew.c (scrolling_window): Don't exclude the case that the
2675 last enabled row in the desired matrix touches the bottom boundary.
2676
2677 2011-05-21 Glenn Morris <rgm@gnu.org>
2678
2679 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2680 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2681 and add some more files.
2682
2683 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2684
2685 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2686 report_file_error introduced by the change from 2011-05-07.
2687
2688 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 * systime.h (Time): Define only if emacs is defined.
2691 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2692 where the include path doesn't have X11/X.h by default. See
2693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2694
2695 2011-05-20 Kenichi Handa <handa@m17n.org>
2696
2697 * composite.c (find_automatic_composition): Fix previous change.
2698
2699 2011-05-20 Glenn Morris <rgm@gnu.org>
2700
2701 * lisp.mk: New file, split from Makefile.in.
2702 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2703 (shortlisp): Remove.
2704 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2705
2706 2011-05-19 Glenn Morris <rgm@gnu.org>
2707
2708 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2709 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2710 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2711 (lisp): Set the order to that of loadup.el.
2712 (shortlisp): Make it a copy of $lisp.
2713 (SOME_MACHINE_LISP): Remove.
2714 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2715 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2716
2717 2011-05-18 Kenichi Handa <handa@m17n.org>
2718
2719 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2720 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2721 (find_automatic_composition): Mostly rewrite for efficiency.
2722
2723 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2724
2725 * makefile.w32-in: Update dependencies.
2726
2727 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2728
2729 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2730 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2731
2732 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 Fix some integer overflow issues, such as string length overflow.
2735
2736 * insdel.c (count_size_as_multibyte): Check for string overflow.
2737
2738 * character.c (lisp_string_width): Check for string overflow.
2739 Use EMACS_INT, not int, for string indexes and lengths; in
2740 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2741 the resulting string length overflows an EMACS_INT; instead,
2742 report a string overflow if no precision given. When checking for
2743 precision exhaustion, use a check that cannot possibly have
2744 integer overflow. (Bug#8675)
2745 * character.h (lisp_string_width): Adjust to new signature.
2746
2747 * alloc.c (string_overflow): New function.
2748 (Fmake_string): Use it. This doesn't change behavior, but saves
2749 a few bytes and will simplify future changes.
2750 * character.c (string_escape_byte8): Likewise.
2751 * lisp.h (string_overflow): New decl.
2752
2753 Fixups, following up to the user-interface timestamp change.
2754 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2755 for UI timestamps, instead of unsigned long.
2756 * msdos.c (mouse_get_pos): Likewise.
2757 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2758 * w32gui.h (Time): Define by including "systime.h" rather than by
2759 declaring it ourselves. (Bug#8664)
2760
2761 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2762 * image.c (clear_image_cache): Likewise.
2763
2764 * term.c (term_mouse_position): Don't assume time_t wraparound.
2765
2766 Be more systematic about user-interface timestamps.
2767 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2768 and sometimes 'EMACS_UINT', to represent these timestamps.
2769 This change causes it to use 'Time' uniformly, as that's what X uses.
2770 This makes the code easier to follow, and makes it easier to catch
2771 integer overflow bugs such as Bug#8664.
2772 * frame.c (Fmouse_position, Fmouse_pixel_position):
2773 Use Time, not unsigned long, for user-interface timestamps.
2774 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2775 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2776 * keyboard.h (last_event_timestamp): Likewise.
2777 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2778 * menu.h (xmenu_show): Likewise.
2779 * term.c (term_mouse_position): Likewise.
2780 * termhooks.h (struct input_event.timestamp): Likewise.
2781 (struct terminal.mouse_position_hook): Likewise.
2782 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2783 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2784 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2785 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2786 what it was before.
2787 * menu.h, termhooks.h: Include "systime.h", for Time.
2788
2789 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2790 Don't assume that the difference between two unsigned long values
2791 can fit into an integer. At this point, we know button_down_time
2792 <= event->timestamp, so the difference must be nonnegative, so
2793 there's no need to cast the result if double-click-time is
2794 nonnegative, as it should be; check that it's nonnegative, just in
2795 case. This bug is triggered when events are more than 2**31 ms
2796 apart (about 25 days). (Bug#8664)
2797
2798 * xselect.c (last_event_timestamp): Remove duplicate decl.
2799 (x_own_selection): Remove needless cast to unsigned long.
2800
2801 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2802 that always fit in int. Use a sentinel instead of a counter, to
2803 avoid a temp and to allay GCC's concerns about possible int overflow.
2804 * frame.h (struct frame): Use int for menu_bar_items_used
2805 instead of EMACS_INT, since it always fits in int.
2806
2807 * menu.c (grow_menu_items): Check for int overflow.
2808
2809 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2810
2811 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2812 Before, the code was not consistent. These values cannot exceed
2813 2**31 - 1 so there's no need to make them unsigned.
2814 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2815 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2816 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2817 as modifiers.
2818 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2819
2820 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2821 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2822 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2823 presumably because the widths might not match.
2824
2825 * window.c (size_window): Avoid needless test at loop start.
2826
2827 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2828
2829 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2830
2831 2011-05-12 Drew Adams <drew.adams@oracle.com>
2832
2833 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2834
2835 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2836
2837 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2838 `width' to `bar_area_x' and `bar_area_width', respectively.
2839 (x_scroll_run): Take account of fringe background extension.
2840
2841 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2842 Rename local vars `left' and `width' to `bar_area_x' and
2843 `bar_area_width', respectively.
2844 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2845 background extension.
2846
2847 2011-05-10 Jim Meyering <meyering@redhat.com>
2848
2849 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2850
2851 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2852
2853 * image.c (Finit_image_library): Return t for built-in image types,
2854 like pbm and xbm. (Bug#8640)
2855
2856 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2857
2858 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2859
2860 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2861
2862 * w32console.c (Fset_screen_color): Doc fix.
2863 (Fget_screen_color): New function.
2864 (syms_of_ntterm): Defsubr it.
2865
2866 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2867 unlink the temporary file if Fcall_process didn't create it in the
2868 first place.
2869 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2870 child process will be redirected to a file specified with `:file'.
2871 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2872 cue to call_process_cleanup not to close that handle.
2873
2874 2011-05-07 Ben Key <bkey76@gmail.com>
2875
2876 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2877 one of two shell specific rules, either bootstrap-temacs-CMD or
2878 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2879 to the previous implementation of the bootstrap-temacs rule.
2880 The bootstrap-temacs-CMD rule is similar to the previous
2881 implementation of the bootstrap-temacs rule except that it
2882 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2883 variable.
2884
2885 These changes, along with some changes to nt/configure.bat,
2886 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2887 earlier fix to add support for --cflags and --ldflags options
2888 that include quotes so that it works whether make uses cmd or
2889 sh as the shell.
2890
2891 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2892
2893 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2894 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2895 is a constant.
2896 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2897 a string. Handle both cases.
2898 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2899 (Fdbus_register_method): Use Qinvalid_function.
2900
2901 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2902
2903 * makefile.w32-in: Update dependencies.
2904 (LISP_H): Add inttypes.h and stdin.h.
2905 (PROCESS_H): Add unistd.h.
2906
2907 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2908
2909 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2910 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2911
2912 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2915
2916 * term.c (vfatal): Remove stray call to va_end.
2917 It's not needed and the C Standard doesn't allow it here anyway.
2918
2919 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2920 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2921
2922 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2923 bytes.
2924
2925 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2926
2927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2928
2929 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2930
2931 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2932
2933 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2934
2935 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2936 * charset.c (Fdefine_charset_internal): Don't initialize
2937 charset.code_space[15]. The value was garbage, on hosts with
2938 32-bit int (Bug#8600).
2939
2940 * lread.c (read_integer): Be more consistent with string-to-number.
2941 Use string_to_number to do the actual conversion; this avoids
2942 rounding errors and fixes some other screwups. Without this fix,
2943 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2944 (digit_to_number): Move earlier, for benefit of read_integer.
2945 Return -1 if the digit is out of range for the base, -2 if it is
2946 not a digit in any supported base. (Bug#8602)
2947
2948 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2949
2950 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2951 to match comment at start of function. This also removes a
2952 GCC warning about overflow in a 32+64-bit port.
2953
2954 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2955
2956 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2957 Reported by Stefan Monnier in
2958 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2959 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2960 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2961
2962 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2963 (EMACS_UINTPTR): Likewise, with uintptr_t.
2964
2965 * lisp.h: Prefer 64-bit EMACS_INT if available.
2966 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2967 on 32-bit hosts that have 64-bit int, so that they can access
2968 large files.
2969 However, temporarily disable this change unless the temporary
2970 symbol WIDE_EMACS_INT is defined.
2971
2972 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2973
2974 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2975 This removes an assumption that EMACS_INT and long are the same
2976 width as pointers. The assumption is true for Emacs porting targets
2977 now, but we want to make other targets possible.
2978 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2979 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2980 In the rest of the code, change types of integers that hold casted
2981 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2982 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2983 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2984 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2985 No need to cast type when ORing.
2986 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2987 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2988 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2989 assume EMACS_INT is the same width as char *.
2990 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2991 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2992 Remove no-longer-needed casts.
2993 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2994 (xg_tool_bar_help_callback, xg_make_tool_item):
2995 Use EMACS_INTPTR to hold an integer
2996 that will be cast to void *; this can avoid a GCC warning
2997 if EMACS_INT is not the same width as void *.
2998 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2999 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3000 (current_message_1, set_message_1):
3001 Use a local to convert to proper width without a cast.
3002 * xmenu.c (dialog_selection_callback): Likewise.
3003
3004 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3005 Also, don't assume VALBITS / RAND_BITS is less than 5,
3006 and don't rely on undefined behavior when shifting a 1 left into
3007 the sign bit.
3008 * lisp.h (get_random): Change signature to match.
3009
3010 * lread.c (hash_string): Use size_t, not int, for hash computation.
3011 Normally we prefer signed values; but hashing is special, because
3012 it's better to use unsigned division on hash table sizes so that
3013 the remainder is nonnegative. Also, size_t is the natural width
3014 for hashing into memory. The previous code used 'int', which doesn't
3015 retain enough info to hash well into very large tables.
3016 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3017
3018 * dbusbind.c: Don't possibly lose pointer info when converting.
3019 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3020 Use XPNTR rather than XHASH, so that the high-order bits of
3021 the pointer aren't lost when converting through void *.
3022
3023 * eval.c (Fautoload): Don't double-shift a pointer.
3024
3025 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3026
3027 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * gnutls.c (DEF_GNUTLS_FN):
3030 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3031
3032 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3033
3034 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3035 marker. (Bug#8610)
3036
3037 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3038
3039 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3040 New version that can reserve upto 2GB of heap space.
3041
3042 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3045
3046 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3047
3048 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3049 `gnutls_certificate_set_x509_key_file'.
3050
3051 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3054 Update dependencies.
3055
3056 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3059 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3060 Remove unused parameter `fildes'.
3061 * process.c (read_process_output, send_process): Don't pass it.
3062
3063 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3064
3065 Fix previous change: the library cache is defined in w32.c.
3066 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3067 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3068
3069 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3070
3071 Implement dynamic loading of GnuTLS on Windows.
3072
3073 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3074 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3075 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3076 Declare.
3077
3078 * gnutls.c (Qgnutls_dll): Define.
3079 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3080 (gnutls_*): Declare function pointers.
3081 (init_gnutls_functions): New function to initialize function pointers.
3082 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3083 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3084 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3085 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3086 (emacs_gnutls_write, emacs_gnutls_read)
3087 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3088 (Fgnutls_available_p): New function.
3089 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3090 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3091 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3092
3093 * image.c: Include w32.h.
3094 (Vimage_type_cache): Delete.
3095 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3096 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3097 (w32_delayed_load): Move to w32.c.
3098
3099 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3100
3101 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3102 (w32_delayed_load): Move from image.c. When loading a library, record
3103 its filename in the :loaded-from property of the library id.
3104 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3105 Initialize and staticpro them.
3106 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3107
3108 * process.c: Include lisp.h before w32.h, not after.
3109 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3110 instead of gnutls_record_check_pending.
3111
3112 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3113
3114 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3115
3116 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3117 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3118 as passed in.
3119
3120 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3121
3122 * xterm.c (x_set_frame_alpha): Do not set property on anything
3123 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3124
3125 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3126
3127 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3128
3129 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3130
3131 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3132 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3133 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3134 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3135 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3136 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3137 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3138 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3139 (Qgnutls_bootprop_callbacks_verify): Make static.
3140
3141 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3142
3143 * callproc.c: Indentation fixup.
3144
3145 * sysdep.c (wait_for_termination_1): Make static.
3146 (wait_for_termination, interruptible_wait_for_termination):
3147 Move after wait_for_termination_1.
3148
3149 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150
3151 * sysdep.c (interruptible_wait_for_termination): New function
3152 which is like wait_for_termination, but allows keyboard
3153 interruptions.
3154
3155 * callproc.c (Fcall_process): Add (:file "file") as an option for
3156 the STDOUT buffer.
3157 (Fcall_process_region): Ditto.
3158
3159 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3160
3161 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3162 rather than `XVECTOR (FOO)->size'.
3163
3164 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3165 inttypes.h, as a gnulib replacement is used if it not available in
3166 system headers.
3167
3168 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3169
3170 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3171 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3172 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3173
3174 * coding.c (coding_alloc_by_realloc): Error out if destination
3175 will grow beyond MOST_POSITIVE_FIXNUM.
3176 (decode_coding_emacs_mule): Abort if there isn't enough place in
3177 charbuf for the composition carryover bytes. Reserve an extra
3178 space for up to 2 characters produced in a loop.
3179 (decode_coding_iso_2022): Abort if there isn't enough place in
3180 charbuf for the composition carryover bytes.
3181
3182 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3183
3184 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3185 aborting when %lld or %lll format is passed.
3186 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3187 %llo or %llx format is passed. (Bug#8545)
3188
3189 * window.c (window_scroll_line_based): Use a marker instead of
3190 simple variables to record original value of point. (Bug#7952)
3191
3192 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3193 produced by %s or %c overflows available buffer space. (Bug#8545)
3194
3195 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3196
3197 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3198 (SIZE_MAX): Move defn after all includes, as they might #define it.
3199
3200 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3201
3202 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3203
3204 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3205
3206 * keyboard.c (Qdelayed_warnings_hook): Define.
3207 (command_loop_1): Run `delayed-warnings-hook'
3208 if Vdelayed_warnings_list is non-nil.
3209 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3210 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3211
3212 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3213
3214 * doprnt.c (doprnt): Don't return value smaller than the buffer
3215 size if the message was truncated. (Bug#8545).
3216
3217 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3220 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3221
3222 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3225
3226 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3227
3228 * makefile.w32-in: Update dependencies.
3229
3230 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3231
3232 Improve `doprnt' and its usage. (Bug#8545)
3233 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3234 `format_end'. Remove support for %l as a conversion specifier.
3235 Don't use xrealloc. Improve diagnostics when the %l size modifier
3236 is used. Update the commentary.
3237
3238 * eval.c (verror): Simplify calculation of size_t.
3239
3240 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3241 messages.
3242
3243 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3244
3245 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3246 change.
3247
3248 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3251 This makes this file independent of the recent pseudovector change.
3252
3253 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3256
3257 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3258 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3259 Remove unused local.
3260 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3261
3262 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3263 GCC 4.6.0 optimizes based on type-based alias analysis.
3264 For example, if b is of type struct buffer * and v of type struct
3265 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3266 != &v->size, and therefore "v->size = 1; b->size = 2; return
3267 v->size;" must therefore return 1. This assumption is incorrect
3268 for Emacs, since it type-puns struct Lisp_Vector * with many other
3269 types. To fix this problem, this patch adds a new type struct
3270 vectorlike_header that documents the constraints on layout of vectors
3271 and pseudovectors, and helps optimizing compilers not get fooled
3272 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3273 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3274 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3275 the size member.
3276 (XSETPVECTYPE): Rewrite in terms of new macro.
3277 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3278 This is a bit clearer, and further avoids the possibility of
3279 undesirable aliasing.
3280 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3281 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3282 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3283 since Lisp_Subr is a special case (no "next" field).
3284 (ASIZE): Now uses header.size rather than size.
3285 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3286 to avoid the hassle of writing XVECTOR (foo)->header.size.
3287 (struct vectorlike_header): New type.
3288 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3289 object, to help avoid aliasing.
3290 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3291 (SUBRP): Likewise, since Lisp_Subr is a special case.
3292 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3293 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3294 (struct Lisp_Hash_Table): Combine first two members into a single
3295 struct vectorlike_header member. All uses of "size" and "next" members
3296 changed to be "header.size" and "header.next".
3297 * buffer.h (struct buffer): Likewise.
3298 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3299 * frame.h (struct frame): Likewise.
3300 * process.h (struct Lisp_Process): Likewise.
3301 * termhooks.h (struct terminal): Likewise.
3302 * window.c (struct save_window_data, struct saved_window): Likewise.
3303 * window.h (struct window): Likewise.
3304 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3305 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3306 * buffer.c (init_buffer_once): Likewise.
3307 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3308 special case.
3309 * process.c (Fformat_network_address): Use local var for size,
3310 for brevity.
3311
3312 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3313
3314 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3315 * data.c (atof): Remove decl; no longer used or needed.
3316 (digit_to_number): Move to lread.c.
3317 (Fstring_to_number): Use new string_to_number function, to be
3318 consistent with how the Lisp reader treats infinities and NaNs.
3319 Do not assume that floating-point numbers represent EMACS_INT
3320 without losing information; this is not true on most 64-bit hosts.
3321 Avoid double-rounding errors, by insisting on integers when
3322 parsing non-base-10 numbers, as the documentation specifies.
3323 * lisp.h (string_to_number): New decl, replacing ...
3324 (isfloat_string): Remove.
3325 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3326 (read1): Do not accept +. and -. as integers; this
3327 appears to have been a coding error. Similarly, do not accept
3328 strings like +-1e0 as floating point numbers. Do not report
3329 overflow for integer overflows unless the base is not 10 which
3330 means we have no simple and reliable way to continue.
3331 Break out the floating-point parsing into a new
3332 function string_to_number, so that Fstring_to_number parses
3333 floating point numbers consistently with the Lisp reader.
3334 (digit_to_number): Move here from data.c. Make it static inline.
3335 (E_CHAR, EXP_INT): Remove, replacing with ...
3336 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3337 (string_to_number): New function, replacing isfloat_string.
3338 This function checks for valid syntax and produces the resulting
3339 Lisp float number too. Rework it so that string-to-number
3340 no longer mishandles examples like "1.0e+". Use strtoumax,
3341 so that overflow for non-base-10 numbers is reported only when
3342 there's no portable and simple way to convert to floating point.
3343
3344 * textprop.c (set_text_properties_1): Rewrite for clarity,
3345 and to avoid GCC warning about integer overflow.
3346
3347 * intervals.h (struct interval): Use EMACS_INT for members
3348 where EMACS_UINT might cause problems. See
3349 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3350 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3351 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3352 All uses changed.
3353 (offset_intervals): Tell GCC not to worry about length overflow
3354 when negating a negative length.
3355
3356 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3357 (overrun_check_free): Likewise.
3358
3359 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3360 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3361 word size.
3362
3363 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3364 (gnutls_make_error): Rename local to avoid shadowing.
3365 (gnutls_emacs_global_deinit): ifdef out; not used.
3366 (Fgnutls_boot): Use const for pointer to readonly storage.
3367 Comment out unused local. Fix pointer signedness problems.
3368
3369 * lread.c (openp): Don't stuff size_t into an 'int'.
3370 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3371 about possible signed overflow.
3372
3373 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3374 (GDK_KEY_g): Don't define if already defined.
3375 (xg_prepare_tooltip): Avoid pointer signedness problem.
3376 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3377
3378 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3379 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3380
3381 * xfns.c (Fx_window_property): Simplify a bit,
3382 to make a bit faster and to avoid GCC 4.6.0 warning.
3383 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3384
3385 * fns.c (internal_equal): Don't assume size_t fits in int.
3386
3387 * alloc.c (compact_small_strings): Tighten assertion a little.
3388
3389 Replace pEd with more-general pI, and fix some printf arg casts.
3390 * lisp.h (pI): New macro, generalizing old pEd macro to other
3391 conversion specifiers. For example, use "...%"pI"d..." rather
3392 than "...%"pEd"...".
3393 (pEd): Remove. All uses replaced with similar uses of pI.
3394 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3395 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3396 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3397 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3398 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3399 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3400 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3401 64-bit hosts.
3402 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3403 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3404 * print.c (safe_debug_print, print_object): Likewise.
3405 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3406 to int.
3407 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3408 avoiding the 0 flag, which is not portable.
3409 * process.c (Fmake_network_process): Use pI to avoid cast.
3410 * region-cache.c (pp_cache): Likewise.
3411 * xdisp.c (decode_mode_spec): Likewise.
3412 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3413 behavior on 64-bit hosts with printf arg.
3414 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3415 (x_stop_queuing_selection_requests): Likewise.
3416 (x_get_window_property): Don't truncate byte count to an 'int'
3417 when tracing.
3418
3419 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3420 here, since it parses constructs like leading '-' and spaces,
3421 which are not wanted; and it overflows with large numbers.
3422 Instead, simply match F[0-9]+, which is what is wanted anyway.
3423
3424 * alloc.c: Remove unportable assumptions about struct layout.
3425 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3426 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3427 (allocate_vectorlike, make_pure_vector): Use the new macros,
3428 plus offsetof, to remove unportable assumptions about struct layout.
3429 These assumptions hold on all porting targets that I know of, but
3430 they are not guaranteed, they're easy to remove, and removing them
3431 makes further changes easier.
3432
3433 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3434 This doesn't fix a bug but makes the code clearer.
3435 (string_overrun_cookie): Now const. Use initializers that
3436 don't formally overflow signed char, to avoid warnings.
3437 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3438 can cause Emacs to crash when string overrun checking is enabled.
3439 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3440 multiple of sizeof (EMACS_INT); it need not be, if
3441 alignof(EMACS_INT) < sizeof (EMACS_INT).
3442 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3443
3444 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3447
3448 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3449
3450 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3451 supposed to be handshaking. (Bug#8556)
3452 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3453
3454 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3455
3456 * lisp.h (Qdebug): List symbol.
3457 * eval.c (Qdebug): Restore global linkage.
3458 * keyboard.c (debug-on-event): New variable.
3459 (handle_user_signal): Break into debugger when debug-on-event
3460 matches the current signal symbol.
3461
3462 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3463
3464 * alloc.c (check_sblock, check_string_bytes)
3465 (check_string_free_list): Convert to standard C.
3466
3467 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3468
3469 * w32.c (emacs_gnutls_push): Fix typo.
3470
3471 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3472
3473 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3474 "cast to pointer from integer of different size".
3475
3476 Improve doprnt and its use in verror. (Bug#8545)
3477 * doprnt.c (doprnt): Document the set of format control sequences
3478 supported by the function. Use SAFE_ALLOCA instead of always
3479 using `alloca'.
3480
3481 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3482 is one byte too soon. Don't use xrealloc; instead xfree and
3483 xmalloc anew.
3484
3485 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3486
3487 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3488 callbacks stage.
3489
3490 * gnutls.c: Renamed global_initialized to
3491 gnutls_global_initialized. Added internals for the
3492 :verify-hostname-error, :verify-error, and :verify-flags
3493 parameters of `gnutls-boot' and documented those parameters in the
3494 docstring. Start callback support.
3495 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3496 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3497 on error. Return error code.
3498 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3499 (emacs_gnutls_read): Likewise.
3500 (Fgnutls_boot): Return handshake error code.
3501 (emacs_gnutls_handle_error): New function.
3502 (wsaerror_to_errno): Likewise.
3503
3504 * w32.h (emacs_gnutls_pull): Add prototype.
3505 (emacs_gnutls_push): Likewise.
3506
3507 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3508 (emacs_gnutls_push): Likewise.
3509
3510 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3511
3512 * process.c (wait_reading_process_output): Check if GnuTLS
3513 buffered some data internally if no FDs are set for TLS
3514 connections.
3515
3516 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3517 (LIBS): Link to USER_LIBS.
3518 ($(BLD)/gnutls.$(0)): New target.
3519
3520 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3521
3522 * xdisp.c (handle_single_display_spec): Rename the
3523 display_replaced_before_p argument into display_replaced_p, to
3524 make it consistent with the commentary. Fix typos in the
3525 commentary.
3526
3527 * textprop.c (syms_of_textprop): Remove dead code.
3528 (copy_text_properties): Delete obsolete commentary about an
3529 interface that was deleted long ago. Fix typos in the description
3530 of arguments.
3531
3532 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3533 to changes in oldXMenu/XMenu.h from 2011-04-16.
3534 <menu_help_message, prev_menu_help_message>: Constify.
3535 (IT_menu_make_room): menu->help_text is now `const char **';
3536 adjust.
3537
3538 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3539 to changes in oldXMenu/XMenu.h from 2011-04-16.
3540 (struct XMenu): Declare `help_text' `const char **'.
3541
3542 * xfaces.c <Qunspecified>: Make extern again.
3543
3544 * syntax.c: Include sys/types.h before including regex.h, as
3545 required by Posix.
3546
3547 * doc.c (get_doc_string): Improve the format passed to `error'.
3548
3549 * doprnt.c (doprnt): Improve commentary.
3550
3551 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3552
3553 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3554 them with etags.
3555
3556 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3557 changes in globals.h immediately force recompilation.
3558 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3559 $(CURDIR)/s/ms-w32.h.
3560 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3561
3562 * character.c (Fchar_direction): Function deleted.
3563 (syms_of_character): Don't defsubr it.
3564 <char-direction-table>: Deleted.
3565
3566 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3567
3568 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3569 * doprnt.c: Include limits.h.
3570 (SIZE_MAX): New macro.
3571 (doprnt): Return a size_t value. 2nd arg is now size_t.
3572 Many local variables are now size_t instead of int or unsigned.
3573 Improve overflow protection. Support `l' modifier for integer
3574 conversions. Support %l conversion. Don't assume an EMACS_INT
3575 argument for integer conversions and for %c.
3576
3577 * lisp.h (doprnt): Restore prototype.
3578
3579 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3580 $(SRC)/character.h.
3581
3582 * Makefile.in (base_obj): Add back doprnt.o.
3583
3584 * deps.mk (doprnt.o): Add back prerequisites.
3585 (callint.o): Depend on character.h.
3586
3587 * eval.c (internal_lisp_condition_case): Include the handler
3588 representation in the error message.
3589 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3590 when breaking from the loop.
3591
3592 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3593
3594 * callint.c (Fcall_interactively): When displaying error message
3595 about invalid control letter, pass the character's codepoint, not
3596 a pointer to its multibyte form. Improve display of the character
3597 in octal and display also its hex code.
3598
3599 * character.c (char_string): Use %x to display the (unsigned)
3600 codepoint of an invalid character, to avoid displaying a bogus
3601 negative value.
3602
3603 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3604 `error', not SYMBOL_NAME itself.
3605
3606 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3607 character arguments to `error'.
3608
3609 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3610 to `error' in error message about FINAL_CHAR argument. Make sure
3611 FINAL_CHAR is a character, and use %c when it is passed as
3612 argument to `error'.
3613
3614 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3615
3616 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3617
3618 * w32.c: Include <time.h>.
3619 (sys_localtime): New function.
3620
3621 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3622
3623 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3624
3625 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3626
3627 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3628
3629 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3630 zombies (Bug#8467).
3631
3632 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3633
3634 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3635 gl_state.e_property when gl_state.object is Qt.
3636
3637 * insdel.c (make_gap_larger): Remove limitation of buffer size
3638 to <= INT_MAX.
3639
3640 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3641
3642 * xdisp.c (lookup_glyphless_char_display)
3643 (produce_glyphless_glyph): Handle cons cell entry in
3644 glyphless-char-display.
3645 (Vglyphless_char_display): Document it.
3646
3647 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3648 glyphless-char-display.
3649
3650 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3651
3652 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3653
3654 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3655
3656 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3657 definition for no-X builds.
3658
3659 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3660
3661 Static checks with GCC 4.6.0 and non-default toolkits.
3662
3663 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3664
3665 * process.c (keyboard_bit_set): Define only if SIGIO.
3666 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3667 (send_process): Repair possible setjmp clobbering.
3668
3669 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3670
3671 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3672
3673 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3674
3675 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3676 Define only if needed.
3677
3678 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3679 by pacifying GCC about it. Maybe it's time to retire it?
3680 * xfaces.c (USG, __TIMEVAL__): Likewise.
3681
3682 * dispextern.h (struct redisplay_interface): Rename param
3683 to avoid shadowing.
3684 * termhooks.h (struct terminal): Likewise.
3685 * xterm.c (xembed_send_message): Likewise.
3686
3687 * insdel.c (make_gap_smaller): Define only if
3688 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3689
3690 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3691 it.
3692
3693 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3694 so that we aren't warned about unused symbols.
3695
3696 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3697
3698 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3699
3700 * xfns.c (x_real_positions): Mark locals as initialized.
3701
3702 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3703
3704 * xterm.c: Fix problems found by static analysis with other toolkits.
3705 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3706 (x_dispatch_event): Declare static if USE_GTK, and
3707 define if USE_GTK || USE_X_TOOLKIT.
3708 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3709 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3710 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3711 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3712
3713 * xmenu.c (menu_help_callback): Pointer type fixes.
3714 Use const pointers when pointing at readonly data. Avoid pointer
3715 signedness clashes.
3716 (FALSE): Remove unused macro.
3717 (update_frame_menubar): Remove unused decl.
3718
3719 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3720
3721 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3722 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3723 (single_menu_item): Rename local to avoid shadowing.
3724
3725 * keyboard.c (make_lispy_event): Remove unused local var.
3726
3727 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3728 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3729
3730 * bitmaps: Change bitmaps from unsigned char back to the X11
3731 compatible char. Avoid the old compiler warnings about
3732 out-of-range initializers by using, for example, '\xab' rather
3733 than 0xab.
3734
3735 * xgselect.c (xgselect_initialize): Check vs interface
3736 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3737
3738 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3739
3740 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3741 to read-only memory.
3742
3743 * fns.c (vector): Remove; this old hack is no longer needed.
3744
3745 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3746 Remove unused var.
3747 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3748
3749 * xrdb.c (x_load_resources): Omit unused local.
3750
3751 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3752 (x_window): Rename locals to avoid shadowing.
3753 (USG): Use the kludged USG macro, to pacify gcc.
3754
3755 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3756 (x_term_init): Remove local to avoid shadowing.
3757
3758 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3759
3760 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3761 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3762
3763 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3764
3765 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3766
3767 Fix regex.c, syntax.c and friends for buffers > 2GB.
3768 * syntax.h (struct gl_state_s): Declare character position members
3769 EMACS_INT.
3770
3771 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3772
3773 * textprop.c (verify_interval_modification, interval_of):
3774 Declare arguments EMACS_INT.
3775
3776 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3777 EMACS_INT.
3778
3779 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3780
3781 * indent.c (Fvertical_motion): Local variable it_start is now
3782 EMACS_INT.
3783
3784 * regex.c (re_match, re_match_2, re_match_2_internal)
3785 (bcmp_translate, regcomp, regexec, print_double_string)
3786 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3787 (re_compile_pattern, re_exec): Declare arguments and local
3788 variables `size_t' and `ssize_t' and return values `regoff_t', as
3789 appropriate.
3790 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3791 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3792 <compile_stack_type>: `size' and `avail' are now `size_t'.
3793
3794 * regex.h <regoff_t>: Use ssize_t, not int.
3795 (re_search, re_search_2, re_match, re_match_2): Arguments that
3796 specify buffer/string position and length are now ssize_t and
3797 size_t. Return type is regoff_t.
3798
3799 2011-04-16 Ben Key <bkey76@gmail.com>
3800
3801 * nsfont.m: Fixed bugs in ns_get_family and
3802 ns_descriptor_to_entity that were caused by using free to
3803 deallocate memory blocks that were allocated by xmalloc (via
3804 xstrdup). This caused Emacs to crash when compiled with
3805 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3806 --enable-checking=xmallocoverrun). xfree is now used to
3807 deallocate these memory blocks.
3808
3809 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3812
3813 emacs_write: Accept and return EMACS_INT for sizes.
3814 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3815 et seq.
3816 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3817 Accept and return EMACS_INT.
3818 (emacs_gnutls_write): Return the number of bytes written on
3819 partial writes.
3820 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3821 (emacs_read, emacs_write): Remove check for negative size, as the
3822 Emacs source code has been audited now.
3823 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3824 (emacs_read, emacs_write): Use it.
3825 * process.c (send_process): Adjust to the new signatures of
3826 emacs_write and emacs_gnutls_write. Do not attempt to store
3827 a byte offset into an 'int'; it might overflow.
3828 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3829
3830 * sound.c: Don't assume sizes fit in 'int'.
3831 (struct sound_device.period_size, alsa_period_size):
3832 Return EMACS_INT, not int.
3833 (struct sound_device.write, vox_write, alsa_write):
3834 Accept EMACS_INT, not int.
3835 (wav_play, au_play): Use EMACS_INT to store sizes and to
3836 record read return values.
3837
3838 2011-04-15 Ben Key <bkey76@gmail.com>
3839
3840 * keyboard.c (Qundefined): Don't declare static since it is used
3841 in nsfns.m.
3842 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3843 static since they are used in nsfont.m.
3844
3845 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3846
3847 * process.c (Qprocessp): Don't declare static.
3848 * lisp.h (Qprocessp): Declare again.
3849
3850 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3851
3852 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3853
3854 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 Improve C-level modularity by making more things 'static'.
3857
3858 Don't publish debugger-only interfaces to other modules.
3859 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3860 (verify_bytepos, count_markers): Move decls to the only modules
3861 that need them.
3862 * region-cache.h (pp_cache): Likewise.
3863 * window.h (check_all_windows): Likewise.
3864 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3865
3866 * sysdep.c (croak): Now static, if
3867 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3868 * syssignal.h (croak): Declare only if not static.
3869
3870 * alloc.c (refill_memory_reserve): Now static if
3871 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3872 * lisp.h (refill_memory_reserve): Declare only if not static.
3873
3874 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3875 Define only if USE_LUCID.
3876
3877 * xrdb.c (x_customization_string, x_rm_string): Now static.
3878
3879 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3880 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3881
3882 * xdisp.c (draw_row_with_mouse_face): Now static.
3883 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3884
3885 * window.h (check_all_windows): Mark externally visible.
3886
3887 * window.c (window_deletion_count): Now static.
3888
3889 * undo.c: Make symbols static if they're not exported.
3890 (last_undo_buffer, last_boundary_position, pending_boundary):
3891 Now static.
3892
3893 * textprop.c (interval_insert_behind_hooks): Now static.
3894 (interval_insert_in_front_hooks): Likewise.
3895
3896 * term.c: Make symbols static if they're not exported.
3897 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3898 (max_frame_lines, tty_set_terminal_modes):
3899 (tty_reset_terminal_modes, tty_turn_off_highlight):
3900 (get_tty_terminal): Now static.
3901 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3902 * termhooks.h (term_mouse_moveto): Do not declare if
3903 HAVE_WINDOW_SYSTEM.
3904 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3905 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3906
3907 * sysdep.c: Make symbols static if they're not exported.
3908 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3909 Now static.
3910 (sigprocmask_set, full_mask): Remove; unused.
3911 (wait_debugging): Mark as visible.
3912 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3913 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3914
3915 * syntax.c (syntax_temp): Define only if !__GNUC__.
3916
3917 * sound.c (current_sound_device, current_sound): Now static.
3918
3919 * search.c (searchbufs, searchbuf_head): Now static.
3920
3921 * scroll.c (scroll_cost): Remove; unused.
3922 * dispextern.h (scroll_cost): Remove decl.
3923
3924 * region-cache.h (pp_cache): Mark as externally visible.
3925
3926 * process.c: Make symbols static if they're not exported.
3927 (process_tick, update_tick, create_process, chan_process):
3928 (Vprocess_alist, proc_buffered_char, datagram_access):
3929 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3930 (deactivate_process): Mark defn as static, as well as decl.
3931 * lisp.h (create_process): Remove decl.
3932 * process.h (chan_process, Vprocess_alist): Remove decls.
3933
3934 * print.c: Make symbols static if they're not exported.
3935 (print_depth, new_backquote_output, being_printed, print_buffer):
3936 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3937 (print_interval, print_number_index, initial_stderr_stream):
3938 Now static.
3939 * lisp.h (Fprinc): Remove decl.
3940 (debug_output_compilation_hack): Mark as externally visible.
3941
3942 * sysdep.c (croak): Move decl from here to syssignal.h.
3943 * syssignal.h (croak): Put it here, so the API can be checked when
3944 'croak' is called from dissociate_if_controlling_tty.
3945
3946 * minibuf.c: Make symbols static if they're not exported.
3947 (minibuf_save_list, choose_minibuf_frame): Now static.
3948 * lisp.h (choose_minibuf_frame): Remove decl.
3949
3950 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3951
3952 * lread.c: Make symbols static if they're not exported.
3953 (read_objects, initial_obarray, oblookup_last_bucket_number):
3954 Now static.
3955 (make_symbol): Remove; unused.
3956 * lisp.h (initial_obarray, make_symbol): Remove decls.
3957
3958 * keyboard.c: Make symbols static if they're not exported.
3959 (single_kboard, recent_keys_index, total_keys, recent_keys):
3960 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3961 (this_single_command_key_start, echoing, last_auto_save):
3962 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3963 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3964 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3965 (Vlispy_mouse_stem, double_click_count):
3966 Now static.
3967 (force_auto_save_soon): Define only if SIGDANGER.
3968 (ignore_mouse_drag_p): Now static if
3969 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3970 (print_help): Remove; unused.
3971 (stop_character, last_timer_event): Mark as externally visible.
3972 * keyboard.h (ignore_mouse_drag_p): Declare only if
3973 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3974 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3975 * lisp.h (echoing): Remove decl.
3976 (force_auto_save_soon): Declare only if SIGDANGER.
3977 * xdisp.c (redisplay_window): Simplify code, to make it more
3978 obvious that ignore_mouse_drag_p is not accessed if !defined
3979 USE_GTK && !defined HAVE_NS.
3980
3981 * intervals.c: Make symbols static if they're not exported.
3982 (merge_properties_sticky, merge_interval_right, delete_interval):
3983 Now static.
3984 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3985
3986 * insdel.c: Make symbols static if they're not exported.
3987 However, leave prepare_to_modify_buffer alone. It's never
3988 called from outside this function, but that appears to be a bug.
3989 (combine_after_change_list, combine_after_change_buffer):
3990 (adjust_after_replace, signal_before_change): Now static.
3991 (adjust_after_replace_noundo): Remove; unused.
3992 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3993 (signal_before_change): Remove decls.
3994
3995 * indent.c (val_compute_motion, val_vmotion): Now static.
3996
3997 * image.c: Make symbols static if they're not exported.
3998 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3999 if USE_GTK.
4000 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4001 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4002
4003 * fringe.c (standard_bitmaps): Now static.
4004 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4005
4006 * frame.c: Make symbols static if they're not exported.
4007 (x_report_frame_params, make_terminal_frame): Now static.
4008 (get_frame_param): Now static, unless HAVE_NS.
4009 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4010 (x_get_resource_string): Remove; not used.
4011 * frame.h (make_terminal_frame, x_report_frame_params):
4012 (x_get_resource_string); Remove decls.
4013 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4014 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4015
4016 * font.c, fontset.c: Make symbols static if they're not exported.
4017 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4018 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4019 * font.c (font_close_object): Now static.
4020 * font.h (font_close_object): Remove.
4021 * fontset.c (FONTSET_OBJLIST): Remove.
4022 (free_realized_fontset) #if-0 the body, which does nothing.
4023 (face_suitable_for_char_p): #if-0, as it's never called.
4024 * fontset.h (face_suitable_for_char_p): Remove decl.
4025 * xfaces.c (face_at_string_position):
4026 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4027 since 0 is always ASCII.
4028
4029 * fns.c (weak_hash_tables): Now static.
4030
4031 * fileio.c: Make symbols static if they're not exported.
4032 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4033 (Vwrite_region_annotation_buffers): Now static.
4034
4035 * eval.c: Make symbols static if they're not exported.
4036 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4037 * lisp.h (backtrace_list): Remove decl.
4038
4039 * emacs.c: Make symbols static if they're not exported.
4040 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4041 (fatal_error_code, fatal_error_signal_hook, standard_args):
4042 Now static.
4043 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4044 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4045 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4046 * lisp.h (fatal_error_signal_hook): Remove decl.
4047 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4048
4049 * editfns.c: Move a (normally-unused) function to its only use.
4050 * editfns.c, lisp.h (get_operating_system_release): Remove.
4051 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4052 worth the hassle of breaking this out.
4053
4054 * xterm.c: Make symbols static if they're not exported.
4055 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4056 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4057 (x_destroy_window, x_delete_display):
4058 Now static.
4059 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4060 (x_mouse_leave): Remove; unused.
4061 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4062 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4063 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4064 Remove decls.
4065 (x_mouse_leave): Declare only if WINDOWSNT.
4066 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4067 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4068 USE_X_TOOLKIT.
4069
4070 * ftxfont.c: Make symbols static if they're not exported.
4071 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4072 HAVE_FREETYPE.
4073 * font.h (ftxfont_driver): Likewise.
4074
4075 * xfns.c: Make symbols static if they're not exported.
4076 (x_last_font_name, x_display_info_for_name):
4077 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4078 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4079 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4080 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4081 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4082 (last_show_tip_args): Now static.
4083 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4084 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4085 (x_screen_planes): Remove; unused.
4086 * dispextern.h (x_screen_planes): Remove decl.
4087
4088 * dispnew.c: Make symbols static if they're not exported.
4089 * dispextern.h (redraw_garbaged_frames, scrolling):
4090 (increment_row_positions): Remove.
4091 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4092 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4093 Now static.
4094 (redraw_garbaged_frames): Remove; unused.
4095
4096 * xfaces.c: Make symbols static if they're not exported.
4097 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4098 Remove decls.
4099 * xterm.h (defined_color): Remove decls.
4100 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4101 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4102 (menu_face_changed_default, defined_color, free_realized_face):
4103 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4104 (ascii_face_of_lisp_face): Remove; unused.
4105
4106 * xdisp.c: Make symbols static if they're not exported.
4107 * dispextern.h (scratch_glyph_row, window_box_edges):
4108 (glyph_to_pixel_coords, set_cursor_from_row):
4109 (get_next_display_element, set_iterator_to_next):
4110 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4111 (show_mouse_face): Remove decls
4112 * frame.h (message_buf_print): Likewise.
4113 * lisp.h (pop_message, set_message, check_point_in_composition):
4114 Likewise.
4115 * xterm.h (set_vertical_scroll_bar): Likewise.
4116 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4117 (message_buf_print, scratch_glyph_row, displayed_buffer):
4118 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4119 (get_next_display_element, show_mouse_face, window_box_edges):
4120 (frame_to_window_pixel_xy, check_point_in_composition):
4121 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4122 (glyph_to_pixel_coords): Remove; unused.
4123
4124 * dired.c (file_name_completion): Now static.
4125
4126 * dbusbind.c (xd_in_read_queued_messages): Now static.
4127
4128 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4129 * data.c (circular_list_error): Remove.
4130
4131 * commands.h (last_point_position, last_point_position_buffer):
4132 (last_point_position_window): Remove decls.
4133 * keyboard.c: Make these variables static.
4134
4135 * coding.h (coding, code_convert_region, encode_coding_gap):
4136 Remove decls.
4137 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4138 (iso_code_class, detect_coding, code_convert_region): Now static.
4139 (encode_coding_gap): Remove; unused.
4140
4141 * chartab.c (chartab_chars, chartab_bits): Now static.
4142
4143 * charset.h (charset_iso_8859_1): Remove decl.
4144 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4145 Now static.
4146
4147 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4148 * ccl.c (Vccl_program_table): Now static.
4149 (check_ccl_update): Remove; unused.
4150
4151 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4152 * category.h: ... from here.
4153 * category.c (check_category_table, set_category_set): Now static.
4154
4155 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4156 * lisp.h: Remove these decls.
4157
4158 * buffer.c (buffer_count): Remove unused var.
4159
4160 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4161 so that it's not optimized away.
4162 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4163 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4164 exported only to the debugger.
4165
4166 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4167 * atimer.h (run_all_atimers): Remove; not exported.
4168
4169 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4170 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4171 was inaccessible from Lisp.
4172 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4173 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4174
4175 alloc.c: Import and export fewer symbols, and remove unused items.
4176 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4177 is defined.
4178 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4179 it's not optimized away by whole-program optimization.
4180 (message_enable_multibyte, free_misc): Remove.
4181 (catchlist, handlerlist, mark_backtrace):
4182 Declare only if BYTE_MARK_STACK.
4183 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4184 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4185 (message_enable_multibyte): Remove decl.
4186 (free_misc, interval_free_list, float_block, float_block_index):
4187 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4188 (cons_free_list, last_marked_index):
4189 Now static.
4190 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4191 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4192 (mark_backtrace): Define only if BYTE_MARK_STACK.
4193 * xdisp.c (message_enable_multibyte): Now static.
4194
4195 Declare Lisp_Object Q* variables to be 'static' if not exported.
4196 This makes it easier for human readers (and static analyzers)
4197 to see whether these variables are used from other modules.
4198 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4199 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4200 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4201 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4202 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4203 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4204 * xmenu.c, xselect.c:
4205 Declare Q* vars static if they are not used in other modules.
4206 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4207 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4208 Remove decls of unexported vars.
4209 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4210
4211 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4212
4213 Make Emacs functions such as Fatom 'static' by default.
4214 This makes it easier for human readers (and static analyzers)
4215 to see whether these functions can be called from other modules.
4216 DEFUN now defines a static function. To make the function external
4217 so that it can be used in other C modules, use the new macro DEFUE.
4218 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4219 (Finit_image_library):
4220 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4221 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4222 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4223 Remove decls, since these functions are now static.
4224 (Funintern, Fget_internal_run_time): New decls, since these functions
4225 were already external.
4226
4227 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4228 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4229 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4230 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4231 * keyboard.c, keymap.c, lread.c:
4232 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4233 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4234 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4235 Mark functions with DEFUE instead of DEFUN,
4236 if they are used in other modules.
4237 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4238 decls for now-static functions.
4239 * buffer.h (Fdelete_overlay): Remove decl.
4240 * callproc.c (Fgetenv_internal): Mark as internal.
4241 * composite.c (Fremove_list_of_text_properties): Remove decl.
4242 (Fcomposition_get_gstring): New forward static decl.
4243 * composite.h (Fcomposite_get_gstring): Remove decl.
4244 * dired.c (Ffile_attributes): New forward static decl.
4245 * doc.c (Fdocumntation_property): New forward static decl.
4246 * eval.c (Ffetch_bytecode): New forward static decl.
4247 (Funintern): Remove extern decl; now in .h file where it belongs.
4248 * fileio.c (Fmake_symbolic_link): New forward static decl.
4249 * image.c (Finit_image_library): New forward static decl.
4250 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4251 * intervals.h (Fprevious_property_change):
4252 (Fremove_list_of_text_properties): Remove decls.
4253 * keyboard.c (Fthis_command_keys): Remove decl.
4254 (Fcommand_execute): New forward static decl.
4255 * keymap.c (Flookup_key): New forward static decl.
4256 (Fcopy_keymap): Now static.
4257 * keymap.h (Flookup_key): Remove decl.
4258 * process.c (Fget_process): New forward static decl.
4259 (Fprocess_datagram_address): Mark as internal.
4260 * syntax.c (Fsyntax_table_p): New forward static decl.
4261 (skip_chars): Remove duplicate decl.
4262 * textprop.c (Fprevious_property_change): New forward static decl.
4263 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4264 Now internal.
4265 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4266 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4267
4268 * editfns.c (Fformat): Remove unreachable code.
4269
4270 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4271
4272 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4273 change. (Bug#8496)
4274
4275 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4276
4277 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4278 when at ZV. (Bug#8487)
4279
4280 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4281
4282 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4283 (Bug#8437)
4284 * keyboard.c (parse_tool_bar_item): Likewise.
4285 * sound.c (sound_cleanup, alsa_close): Likewise.
4286 * termcap.c (tgetent): Likewise.
4287 * xfns.c (x_default_font_parameter): Likewise.
4288 * xsettings.c (read_and_apply_settings): Likewise.
4289
4290 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4291 (overrun_check_free): Protoize.
4292
4293 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4296 since callers should never pass a negative size.
4297 Change the signature to match that of plain 'read' and 'write'; see
4298 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4299 * lisp.h: Update prototypes of emacs_write and emacs_read.
4300
4301 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (redisplay_window): Don't try to determine the character
4304 position of the scroll margin if the window start point w->startp
4305 is outside the buffer's accessible region. (Bug#8468)
4306
4307 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4308
4309 Fix write-region and its subroutines for buffers > 2GB.
4310 * fileio.c (a_write, e_write): Modify declaration of arguments and
4311 local variables to support buffers larger than 2GB.
4312 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4313
4314 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4315 argument, local variables, and return value.
4316
4317 * lisp.h: Update prototypes of emacs_write and emacs_read.
4318
4319 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4320
4321 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4324
4325 Fix more problems found by GCC 4.6.0's static checks.
4326
4327 * xdisp.c (vmessage): Use a better test for character truncation.
4328
4329 * charset.c (load_charset_map): <, not <=, for optimization,
4330 and to avoid potential problems with integer overflow.
4331 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4332 * casetab.c (set_identity, shuffle): Likewise.
4333 * editfns.c (Fformat): Likewise.
4334 * syntax.c (skip_chars): Likewise.
4335
4336 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4337 This also lets GCC 4.6.0 generate slightly better loop code.
4338
4339 * callint.c (Fcall_interactively): <, not <=, for optimization.
4340 (Fcall_interactively): Count the number of arguments produced,
4341 not the number of arguments given. This is simpler and lets GCC
4342 4.6.0 generate slightly better code.
4343
4344 * ftfont.c: Distingish more carefully between FcChar8 and char.
4345 The previous code passed unsigned char * to a functions like
4346 strlen and xstrcasecmp that expect char *, which does not
4347 conform to the C standard.
4348 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4349 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4350 char * when the C standard requires it.
4351
4352 * keyboard.c (read_char): Remove unused var.
4353
4354 * eval.c: Port to Windows vsnprintf (Bug#8435).
4355 Include <limits.h>.
4356 (SIZE_MAX): Define if the headers do not.
4357 (verror): Do not give up if vsnprintf returns a negative count.
4358 Instead, grow the buffer. This ports to Windows vsnprintf, which
4359 does not conform to C99. Problem reported by Eli Zaretskii.
4360 Also, simplify the allocation scheme, by avoiding the need for
4361 calling realloc, and removing the ALLOCATED variable.
4362
4363 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4364
4365 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4366 But keep the doprint source code for now, as we might revamp it
4367 and use it again (Bug#8435).
4368 * lisp.h (doprnt): Remove.
4369 * Makefile.in (base_obj): Remove doprnt.o.
4370 * deps.mk (doprnt.o): Remove.
4371
4372 error: Print 32- and 64-bit integers portably (Bug#8435).
4373 Without this change, on typical 64-bit hosts error ("...%d...", N)
4374 was used to print both 32- and 64-bit integers N, which relied on
4375 undefined behavior.
4376 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4377 New macro.
4378 * lisp.h (error, verror): Mark as printf-like functions.
4379 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4380 Report overflow in size calculations when allocating printf buffer.
4381 Do not truncate output string at its first null byte.
4382 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4383 Truncate the output at a character boundary, since vsnprintf does not
4384 do that.
4385 * charset.c (check_iso_charset_parameter): Convert internal
4386 character to string before calling 'error', since %c now has the
4387 printf meaning.
4388 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4389 overflow when computing char to be passed to 'error'. Do not
4390 pass Lisp_Object to 'error'; pass the integer instead.
4391 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4392 formatted with plain %d.
4393
4394 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4395
4396 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4397
4398 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4399
4400 * xterm.c (x_catch_errors): Remove duplicate declaration.
4401
4402 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4403
4404 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4405
4406 2011-04-10 Jim Meyering <meyering@redhat.com>
4407
4408 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4409 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4410 return ssize_t not "int", and use size_t as the buffer length.
4411 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4412 * gnutls.h: Update declarations.
4413 * process.c (read_process_output): Use ssize_t, to match.
4414 (send_process): Likewise.
4415
4416 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4417
4418 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4419
4420 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4421
4422 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4423 Use unsigned char, to match FcChar8 type definition.
4424
4425 * xterm.c (handle_one_xevent):
4426 * xmenu.c (create_and_show_popup_menu):
4427 * xselect.c (x_decline_selection_request)
4428 (x_reply_selection_request): Avoid type-punned deref of X events.
4429
4430 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4431
4432 Fix some uses of `int' instead of EMACS_INT.
4433 * search.c (string_match_1, fast_string_match)
4434 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4435 (scan_buffer, find_next_newline_no_quit)
4436 (find_before_next_newline, search_command, Freplace_match)
4437 (Fmatch_data): Make some `int' variables be EMACS_INT.
4438
4439 * xdisp.c (display_count_lines): 3rd argument and return value now
4440 EMACS_INT. All callers changed.
4441 (pint2hrstr): Last argument is now EMACS_INT.
4442
4443 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4444 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4445 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4446 (decode_coding_utf_16, decode_coding_emacs_mule)
4447 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4448 (decode_coding_ccl, decode_coding_charset)
4449 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4450 (decode_coding_iso_2022, decode_coding_emacs_mule)
4451 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4452 <char_offset, last_offset>: Declare EMACS_INT.
4453 (encode_coding_utf_8, encode_coding_utf_16)
4454 (encode_coding_emacs_mule, encode_invocation_designation)
4455 (encode_designation_at_bol, encode_coding_iso_2022)
4456 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4457 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4458 Declare EMACS_INT.
4459 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4460 (encode_invocation_designation): Last argument P_NCHARS is now
4461 EMACS_INT.
4462 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4463 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4464
4465 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4466 All users changed.
4467
4468 * ccl.c (Fccl_execute_on_string): Declare some variables
4469 EMACS_INT.
4470
4471 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4472
4473 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4474
4475 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4476
4477 * process.c (Fformat_network_address): Doc fix.
4478
4479 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4480
4481 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4482
4483 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4484
4485 * keyboard.c (read_char): Call Lisp function help-form-show,
4486 instead of using internal_with_output_to_temp_buffer.
4487 (Qhelp_form_show): New var.
4488 (syms_of_keyboard): Use DEFSYM macro.
4489
4490 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4491
4492 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4493
4494 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4495
4496 * process.c (Flist_processes): Remove to Lisp.
4497 (list_processes_1): Delete.
4498
4499 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4500
4501 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4502
4503 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4504
4505 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 Fix more problems found by GCC 4.6.0's static checks.
4508
4509 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4510
4511 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4512
4513 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4514
4515 * xdisp.c (vmessage): Mark as a printf-like function.
4516
4517 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4518
4519 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4520
4521 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4522 printf-like functions.
4523 (tiff_load): Add casts to remove these marks before passing them
4524 to system-supplied API.
4525
4526 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4527
4528 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4529 This avoids several warnings with gcc -Wstrict-overflow.
4530 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4531 directly, rather than having caller test rule sign. This avoids
4532 some unnecessary tests.
4533 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4534 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4535 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4536
4537 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4538 (xfont_open): Avoid unnecessary tests.
4539
4540 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4541
4542 * composite.h, composite.c (composition_gstring_put_cache):
4543 Use EMACS_INT, not int, for length.
4544
4545 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4546 breaking out part of COMPOSITION_DECODE_RULE.
4547 (COMPOSITION_DECODE_RULE): Use it.
4548 * composite.c (get_composition_id): Remove unused local vars,
4549 by using the new macro.
4550
4551 * textprop.c (set_text_properties_1): Change while to do-while,
4552 since the condition is always true at first.
4553
4554 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4555 (interval_deletion_adjustment): Return unsigned value.
4556 All uses changed.
4557
4558 * process.c (list_processes_1, create_pty, read_process_output):
4559 (exec_sentinel): Remove vars that were set but not used.
4560 (create_pty): Remove unnecessary "volatile"s.
4561 (Fnetwork_interface_info): Avoid possibility of int overflow.
4562 (read_process_output): Do adaptive read buffering even if carryover.
4563 (read_process_output): Simplify nbytes computation if buffered.
4564
4565 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4566
4567 * syntax.c (scan_words): Remove var that was set but not used.
4568 (update_syntax_table): Use unsigned instead of int.
4569
4570 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4571 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4572 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4573
4574 * print.c (print_error_message): Avoid int overflow.
4575
4576 * font.c (font_list_entities): Redo for clarity,
4577 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4578
4579 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4580 (font_score): Avoid potential overflow in diff calculation.
4581
4582 * fns.c (substring_both): Remove var that is set but not used.
4583 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4584
4585 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4586
4587 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4588 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4589 can always succeed if overflow has undefined behavior.
4590
4591 * search.c (boyer_moore, wordify): Remove vars set but not used.
4592 (wordify): Omit three unnecessary tests.
4593
4594 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4595 All callers changed. This avoids the need for an unused var.
4596
4597 * casefiddle.c (casify_region): Remove var that is set but not used.
4598
4599 * dired.c (file_name_completion): Remove var that is set but not used.
4600
4601 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4602
4603 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4604 (Finsert_file_contents): Remove unnecessary code checking fd.
4605
4606 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4607 Check for integer overflow on size calculations.
4608
4609 * buffer.c (Fprevious_overlay_change): Remove var that is set
4610 but not used.
4611
4612 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4613 Remove vars that are set but not used.
4614 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4615 (timer_check_2): Mark vars as initialized.
4616
4617 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4618
4619 * image.c (lookup_image): Remove var that is set but not used.
4620 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4621
4622 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4623 that are set but not used.
4624
4625 * xfns.c (make_invisible_cursor): Don't return garbage
4626 if XCreateBitmapFromData fails (Bug#8410).
4627
4628 * xselect.c (x_get_local_selection, x_handle_property_notify):
4629 Remove vars that are set but not used.
4630
4631 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4632 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4633
4634 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4635 Remove var that is set but not used.
4636 (scroll_bar_windows_size): Now size_t, not int.
4637 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4638 Check for overflow.
4639
4640 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4641 (map_tty_color) [!defined MSDOS]: Likewise.
4642
4643 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4644
4645 * coding.c: Remove vars that are set but not used.
4646 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4647 All callers changed.
4648 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4649 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4650 (decode_coding_charset): Remove vars that are set but not used.
4651
4652 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4653 that is set but not used.
4654
4655 * print.c (print_object): Remove var that is set but not used.
4656
4657 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4658 The gnulib version avoids calling malloc in the usual case,
4659 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4660 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4661 * filelock.c (current_lock_owner): Likewise.
4662 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4663 * sysdep.c: Include allocator.h, careadlinkat.h.
4664 (emacs_no_realloc_allocator): New static constant.
4665 (emacs_readlink): New function.
4666 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4667 ../lib/careadlinkat.h.
4668
4669 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4670
4671 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4672 first non-nil return value).
4673
4674 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4675
4676 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4677 if not defined (Bug#8403).
4678
4679 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * xdisp.c (display_count_lines): Remove parameter `start',
4682 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4683 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4684 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4685 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4686 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4687 and thereabouts. All callers changed.
4688 (get_per_char_metric): Remove parameter `f', unused since
4689 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4690
4691 2011-04-02 Jim Meyering <meyering@redhat.com>
4692
4693 do not dereference NULL upon failed strdup
4694 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4695 (ns_get_family): Likewise.
4696
4697 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4698
4699 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4700
4701 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4702
4703 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4704 later (Bug#8403).
4705
4706 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4707
4708 Add lexical binding.
4709
4710 * window.c (Ftemp_output_buffer_show): New fun.
4711 (Fsave_window_excursion):
4712 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4713
4714 * lread.c (lisp_file_lexically_bound_p): New function.
4715 (Fload): Bind Qlexical_binding.
4716 (readevalloop): Remove `evalfun' arg.
4717 Bind Qinternal_interpreter_environment.
4718 (Feval_buffer): Bind Qlexical_binding.
4719 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4720 Mark as dynamic.
4721 (syms_of_lread): Declare `lexical-binding'.
4722
4723 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4724
4725 * keyboard.c (eval_dyn): New fun.
4726 (menu_item_eval_property): Use it.
4727
4728 * image.c (parse_image_spec): Use Ffunctionp.
4729
4730 * fns.c (concat, mapcar1): Accept byte-code-functions.
4731
4732 * eval.c (Fsetq): Handle lexical vars.
4733 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4734 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4735 (FletX, Flet): Obey lexical binding.
4736 (Fcommandp): Handle closures.
4737 (Feval): New `lexical' arg.
4738 (eval_sub): New function extracted from Feval. Use it almost
4739 everywhere where Feval was used. Look up vars in lexical env.
4740 Handle closures.
4741 (Ffunctionp): Move from subr.el.
4742 (Ffuncall): Handle closures.
4743 (apply_lambda): Remove `eval_flags'.
4744 (funcall_lambda): Handle closures and new byte-code-functions.
4745 (Fspecial_variable_p): New function.
4746 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4747 but without exporting it to Lisp.
4748
4749 * doc.c (Fdocumentation, store_function_docstring):
4750 * data.c (Finteractive_form): Handle closures.
4751
4752 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4753 interactive spec.
4754
4755 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4756 New byte-codes.
4757 (exec_byte_code): New function extracted from Fbyte_code to handle new
4758 calling convention for byte-code-functions. Add new byte-codes.
4759
4760 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4761
4762 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4763
4764 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4765
4766 * xdisp.c (redisplay_internal): Fix prototype.
4767
4768 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4769
4770 * xdisp.c (SCROLL_LIMIT): New macro.
4771 (try_scrolling): Use it when setting scroll_limit.
4772 Limit scrolling to 100 screen lines.
4773 (redisplay_window): Even when falling back on "recentering",
4774 position point in the window according to scroll-conservatively,
4775 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4776
4777 (try_scrolling): When point is above the window, allow searching
4778 as far as scroll_max, or one screenful, to compute vertical
4779 distance from PT to the scroll margin position. This prevents
4780 try_scrolling from unnecessarily failing when
4781 scroll-conservatively is set to a value slightly larger than the
4782 window height. Clean up the case of PT below the margin at bottom
4783 of window: scroll_max can no longer be INT_MAX. When aggressive
4784 scrolling is in use, don't let point enter the opposite scroll
4785 margin as result of the scroll.
4786 (syms_of_xdisp) <scroll-conservatively>: Document the
4787 threshold of 100 lines for never-recentering scrolling.
4788
4789 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4790
4791 * dispextern.h (move_it_by_lines):
4792 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4793 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4794 (message_log_check_duplicate): Remove parameters `prev_bol' and
4795 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4796 (redisplay_internal): Remove parameter `preserve_echo_area',
4797 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4798
4799 * indent.c (Fvertical_motion):
4800 * window.c (window_scroll_pixel_based, Frecenter):
4801 Don't pass `need_y_p' to `move_it_by_lines'.
4802
4803 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4804
4805 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4806 steal a few bits to be more compact.
4807 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4808 Remove unneeded casts.
4809
4810 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4811
4812 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4813
4814 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4815 binding" message (bug#7967).
4816
4817 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 Fix more problems found by GCC 4.6.0's static checks.
4820
4821 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4822 Remove unused local var.
4823
4824 * editfns.c (Fmessage_box): Remove unused local var.
4825
4826 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4827 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4828 Omit unused local vars.
4829 * window.c (shrink_windows): Omit unused local var.
4830 * menu.c (digest_single_submenu): Omit unused local var.
4831 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4832 Omit unused local var.
4833
4834 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4835 Don't assume string length fits in int.
4836 (keyremap_step, read_key_sequence): Use size_t for sizes.
4837 (read_key_sequence): Don't check last_real_key_start redundantly.
4838
4839 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4840 instead of alloca (Bug#8344).
4841
4842 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4843 (Fbacktrace_frame): Don't assume nframes fits in int.
4844
4845 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4846
4847 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4848 concerns.
4849
4850 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4851
4852 * cm.c (calccost): Turn while-do into do-while, for clarity.
4853
4854 * keyboard.c (syms_of_keyboard): Use the same style as later
4855 in this function when indexing through an array. This also
4856 works around GCC bug 48267.
4857
4858 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4859
4860 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4861
4862 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4863 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4864
4865 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4866 This avoids undefined behavior on integer overflow, and is a bit
4867 more convenient anyway since it is compared to a size_t variable.
4868
4869 Variadic C functions now count arguments with size_t, not int.
4870 This avoids an unnecessary limitation on 64-bit machines, which
4871 caused (substring ...) to crash on large vectors (Bug#8344).
4872 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4873 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4874 All variadic functions and their callers changed accordingly.
4875 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4876 * data.c (arith_driver, float_arith_driver): Likewise.
4877 * editfns.c (general_insert_function): Likewise.
4878 * eval.c (struct backtrace.nargs, interactive_p)
4879 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4880 (funcall_lambda, mark_backtrace): Likewise.
4881 * fns.c (concat): Likewise.
4882 * frame.c (x_set_frame_parameters): Likewise.
4883 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4884 0 if not found, not -1. All callers changed.
4885
4886 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4887 (stack_copy_size): Now size_t, not int.
4888 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4889
4890 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4893 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4894 All callers changed.
4895
4896 * lisp.h (multibyte_char_to_unibyte):
4897 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4898 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4899 * character.h (CHAR_TO_BYTE8):
4900 * cmds.c (internal_self_insert):
4901 * editfns.c (general_insert_function):
4902 * keymap.c (push_key_description):
4903 * search.c (Freplace_match):
4904 * xdisp.c (message_dolog, set_message_1): All callers changed.
4905
4906 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4907
4908 * keyboard.c (safe_run_hook_funcall): New function.
4909 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4910 don't set the hook to nil, but remove the offending function instead.
4911 (Qcommand_hook_internal): Remove, unused.
4912 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4913 Vcommand_hook_internal.
4914
4915 * eval.c (enum run_hooks_condition): Remove.
4916 (funcall_nil, funcall_not): New functions.
4917 (run_hook_with_args): Call each function through a `funcall' argument.
4918 Remove `cond' argument, now redundant.
4919 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4920 (Frun_hook_with_args_until_failure): Adjust accordingly.
4921 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4922
4923 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4924
4925 * dispextern.h (string_buffer_position): Remove declaration.
4926
4927 * print.c (strout): Remove parameter `multibyte', unused since
4928 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4929
4930 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4931 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4932 All callers changed.
4933
4934 * w32.c (_wsa_errlist): Use braces for struct initializers.
4935
4936 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4937 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4938 All callers changed.
4939 (string_buffer_position): Likewise. Also, make static (it's never
4940 used outside xdisp.c).
4941 (cursor_row_p): Remove parameter `w', unused since
4942 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4943 (decode_mode_spec): Remove parameter `precision', introduced during
4944 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4945 All callers changed.
4946
4947 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4948
4949 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4950
4951 2011-03-27 Anders Lindgren <andlind@gmail.com>
4952
4953 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4954 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4955 (ns_update_auto_hide_menu_bar): New functions.
4956 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4957 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4958 ns_constrain_all_frames.
4959 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4960 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4961
4962 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4963
4964 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4965
4966 2011-03-27 Glenn Morris <rgm@gnu.org>
4967
4968 * syssignal.h: Replace RETSIGTYPE with void.
4969 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4970 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4971 Replace SIGTYPE with void everywhere.
4972 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4973 * s/template.h (SIGTYPE): Remove commented out definition.
4974
4975 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4976
4977 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4978 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4979
4980 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * w32.c (read_unc_volume): Use parameter `henum', instead of
4983 global variable `wget_enum_handle'.
4984
4985 * keymap.c (describe_vector): Remove parameters `indices' and
4986 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4987 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4988
4989 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4990
4991 * keyboard.c (timer_check): Remove parameter `do_it_now',
4992 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4993 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4994 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4995
4996 * keyboard.c (read_char):
4997 * w32menu.c (w32_menu_display_help):
4998 * xmenu.c (show_help_event, menu_help_callback):
4999 Adjust calls to `show_help_echo'.
5000
5001 * gtkutil.c (xg_maybe_add_timer):
5002 * keyboard.c (readable_events):
5003 * process.c (wait_reading_process_output):
5004 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5005
5006 * insdel.c (adjust_markers_gap_motion):
5007 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5008 (gap_left, gap_right): Don't call it.
5009
5010 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5011
5012 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5013 incurred during fontification.
5014
5015 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5016
5017 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5018 (DEFVAR_PER_BUFFER): Don't pass it.
5019
5020 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5021 (scrolling_window): Don't pass it.
5022
5023 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5026
5027 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5028 and `suffix'.
5029 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5030 of variables specific to SELinux and computation of `encoded_absname'.
5031
5032 * image.c (XPutPixel): Remove unused variable `height'.
5033
5034 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5035
5036 * unexw32.c (get_section_info): Remove unused variable `section'.
5037
5038 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5039 (system_process_attributes): Remove unused variable `sess'.
5040 (sys_read): Remove unused variable `err'.
5041
5042 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5043 (w32_wnd_proc): Remove unused variable `isdead'.
5044 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5045 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5046 (x_create_tip_frame): Remove unused variable `tem'.
5047
5048 * w32inevt.c (w32_console_read_socket):
5049 Remove unused variable `no_events'.
5050
5051 * w32term.c (x_draw_composite_glyph_string_foreground):
5052 Remove unused variable `width'.
5053
5054 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5055
5056 * w32term.c (x_set_glyph_string_clipping):
5057 Don't pass uninitialized region to CombineRgn.
5058
5059 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5060
5061 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5062 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5063 (Fx_close_connection): Remove unused variable `i'.
5064
5065 * w32font.c (w32font_draw): Return number of glyphs.
5066 (w32font_open_internal): Remove unused variable `i'.
5067 (w32font_driver): Add missing initializer.
5068
5069 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5070 (fill_in_menu): Remove unused variable `items_added'.
5071
5072 * w32term.c (last_mouse_press_frame): Remove static global variable.
5073 (w32_clip_to_row): Remove unused variable `f'.
5074 (x_delete_terminal): Remove unused variable `i'.
5075
5076 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5077 (NOTHING): Remove unused static global variable.
5078 (uniscribe_check_otf): Remove unused variable `table'.
5079 (uniscribe_font_driver): Add missing initializers.
5080
5081 2011-03-23 Julien Danjou <julien@danjou.info>
5082
5083 * term.c (Fsuspend_tty, Fresume_tty):
5084 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5085 * window.c (temp_output_buffer_show):
5086 * insdel.c (signal_before_change):
5087 * frame.c (Fhandle_switch_frame):
5088 * fileio.c (Fdo_auto_save):
5089 * emacs.c (Fkill_emacs):
5090 * editfns.c (save_excursion_restore):
5091 * cmds.c (internal_self_insert):
5092 * callint.c (Fcall_interactively):
5093 * buffer.c (Fkill_all_local_variables):
5094 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5095 Use Frun_hooks.
5096 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5097 unconditionnaly since it does the check itself.
5098
5099 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 Fix more problems found by GCC 4.5.2's static checks.
5102
5103 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5104 the first time through the loop, since we know p0 < p1 then.
5105 This also avoids a gcc -Wstrict-overflow warning.
5106
5107 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5108 leading to a memory leak, possible in functions like
5109 load_charset_map_from_file that can allocate an unbounded number
5110 of objects (Bug#8318).
5111
5112 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5113 that could (at least in theory) be that large.
5114
5115 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5116 This is less likely to overflow, and avoids undefined behavior if
5117 overflow does occur. All callers changed. Use strtoul to scan
5118 for the unsigned long integer.
5119 (pint2hrstr): Simplify and tune code slightly.
5120 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5121
5122 * scroll.c (do_scrolling): Work around GCC bug 48228.
5123 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5124
5125 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5126 This also avoids a warning with gcc -Wstrict-overflow.
5127 (validate_x_resource_name): Simplify count usage.
5128 This also avoids a warning with gcc -Wstrict-overflow.
5129
5130 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5131 fail (Bug#8306).
5132
5133 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5134
5135 * process.c (Fmake_network_process): Use socklen_t, not int,
5136 where POSIX says socklen_t is required in portable programs.
5137 This fixes a porting bug on hosts like 64-bit HP-UX, where
5138 socklen_t is wider than int (Bug#8277).
5139 (Fmake_network_process, server_accept_connection):
5140 (wait_reading_process_output, read_process_output):
5141 Likewise.
5142
5143 * process.c: Rename or move locals to avoid shadowing.
5144 (list_processes_1, Fmake_network_process):
5145 (read_process_output_error_handler, exec_sentinel_error_handler):
5146 Rename or move locals.
5147 (Fmake_network_process): Define label "retry_connect" only if needed.
5148 (Fnetwork_interface_info): Fix pointer signedness.
5149 (process_send_signal): Add cast to avoid pointer signedness problem.
5150 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5151 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5152
5153 Make tparam.h and terminfo.c consistent.
5154 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5155 Include tparam.h instead, since it declares them.
5156 * cm.h (PC): Remove extern decl; tparam.h now does this.
5157 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5158 * terminfo.c: Include tparam.h, to check interfaces.
5159 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5160 (tparam): Adjust signature to match interface in tparam.h;
5161 this removes some undefined behavior. Check that outstring and len
5162 are zero, which they always are with Emacs.
5163 * tparam.h (PC, BC, UP): New extern decls.
5164
5165 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5166 (xftfont_open): Rename locals to avoid shadowing.
5167
5168 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5169 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5170 (OTF_TAG_SYM): Omit macro if not needed.
5171 (ftfont_list): Remove unused local.
5172 (get_adstyle_property, ftfont_pattern_entity):
5173 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5174 Rename locals to avoid shadowing.
5175
5176 * xfont.c (xfont_list_family): Mark var as initialized.
5177
5178 * xml.c (make_dom): Now static.
5179
5180 * composite.c (composition_compute_stop_pos): Rename local to
5181 avoid shadowing.
5182 (composition_reseat_it): Remove unused locals.
5183 (find_automatic_composition, composition_adjust_point): Likewise.
5184 (composition_update_it): Mark var as initialized.
5185 (find_automatic_composition): Mark vars as initialized,
5186 with a FIXME (Bug#8290).
5187
5188 character.h: Rename locals to avoid shadowing.
5189 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5190 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5191 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5192 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5193 to avoid shadowing.
5194
5195 * textprop.c (property_change_between_p): Remove; unused.
5196
5197 * intervals.c (interval_start_pos): Now static.
5198
5199 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5200
5201 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5202 Rename locals to avoid shadowing.
5203
5204 * sound.c (wav_play, au_play, Fplay_sound_internal):
5205 Fix pointer signedness.
5206 (alsa_choose_format): Remove unused local var.
5207 (wav_play): Initialize a variable to 0, to prevent undefined
5208 behavior (Bug#8278).
5209
5210 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5211
5212 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5213
5214 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5215 clobbering (Bug#8298).
5216 * sysdep.c (sys_subshell): Likewise.
5217 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5218
5219 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5220 This should get cleaned up, so that child_setup has the
5221 same signature on all platforms.
5222
5223 * callproc.c (call_process_cleanup): Now static.
5224 (relocate_fd): Rename locals to avoid shadowing.
5225
5226 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5227
5228 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5229 not to be necessary, and produces flickering.
5230
5231 2011-03-20 Glenn Morris <rgm@gnu.org>
5232
5233 * config.in: Remove file.
5234
5235 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5236
5237 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5238 are now in src/globals.h.
5239 (syms_of_minibuf): Remove spurious & from previous change.
5240
5241 2011-03-20 Leo <sdl.web@gmail.com>
5242
5243 * minibuf.c (completing-read-function): New variable.
5244 (completing-read-default): Rename from completing-read.
5245 (completing-read): Call completing-read-function.
5246
5247 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5248
5249 * xfaces.c (Fx_load_color_file):
5250 Read color file from absolute filename (bug#8250).
5251
5252 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5253
5254 * makefile.w32-in: Update dependencies.
5255
5256 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5257
5258 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5259
5260 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 Fix more problems found by GCC 4.5.2's static checks.
5263
5264 * process.c (make_serial_process_unwind, send_process_trap):
5265 (sigchld_handler): Now static.
5266
5267 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5268 That way, the code declares only the vars that it needs.
5269 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5270 * s/cygwin.h (PTY_ITERATION): Likewise.
5271 * s/darwin.h (PTY_ITERATION): Likewise.
5272 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5273
5274 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5275 * process.c (allocate_pty): Don't declare stb unless it's needed.
5276
5277 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5278 (CONSTANTLIM): Remove; unused.
5279 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5280 Define only if needed.
5281
5282 * unexelf.c (unexec): Name an expression,
5283 to avoid gcc -Wbad-function-cast warning.
5284 Use a different way to cause a compilation error if anyone uses
5285 n rather than nn, a way that does not involve shadowing.
5286 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5287
5288 * deps.mk (unexalpha.o): Remove; unused.
5289
5290 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5291 * unexec.h: New file.
5292 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5293 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5294 Depend on unexec.h.
5295 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5296 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5297 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5298 Change as necessary to match prototype in unexec.h.
5299
5300 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5301 shadowing.
5302 (back_comment, skip_chars): Mark vars as initialized.
5303
5304 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5305 Rename locals to avoid shadowing.
5306
5307 * lread.c (read1): Rewrite so as not to use empty "else".
5308 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5309
5310 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5311
5312 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5313 warning when compiling print.c.
5314
5315 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5316 instead of using an uninitialized var.
5317 (font_sort_entities): Mark var as initialized.
5318
5319 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5320
5321 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5322 pointers to constants.
5323 (font_parse_fcname): Remove unused vars.
5324 (font_delete_unmatched): Now static.
5325 (font_get_spec): Remove; unused.
5326 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5327 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5328 Rename or move locals to avoid shadowing.
5329
5330 * fns.c (require_nesting_list, require_unwind): Now static.
5331 (Ffillarray): Rename locals to avoid shadowing.
5332
5333 * floatfns.c (domain_error2): Define only if needed.
5334 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5335
5336 * alloc.c (mark_backtrace): Move decl from here ...
5337 * lisp.h: ... to here, so that it can be checked.
5338
5339 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5340 (Fdefvar): Rewrite so as not to use empty "else".
5341 (lisp_indirect_variable): Name an expression,
5342 to avoid gcc -Wbad-function-cast warning.
5343 (Fdefvar): Rename locals to avoid shadowing.
5344
5345 * callint.c (quotify_arg, quotify_args): Now static.
5346 (Fcall_interactively): Rename locals to avoid shadowing.
5347 Use const pointer when appropriate.
5348
5349 * lisp.h (get_system_name, get_operating_system_release):
5350 Move decls here, to check interfaces.
5351 * process.c (get_operating_system_release): Move decl to lisp.h.
5352 * xrdb.c (get_system_name): Likewise.
5353 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5354 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5355 some of which prompt warnings from gcc -Wbad-function-cast.
5356 (Fformat_time_string, Fencode_time, Finsert_char):
5357 (Ftranslate_region_internal, Fformat):
5358 Rename or remove local vars to avoid shadowing.
5359 (Ftranslate_region_internal): Mark var as initialized.
5360
5361 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5362 avoid shadowing.
5363
5364 * lisp.h (eassert): Check that the argument compiles, even if
5365 ENABLE_CHECKING is not defined.
5366
5367 * data.c (Findirect_variable): Name an expression, to avoid
5368 gcc -Wbad-function-cast warning.
5369 (default_value, arithcompare, arith_driver, arith_error): Now static.
5370 (store_symval_forwarding): Rename local to avoid shadowing.
5371 (Fmake_variable_buffer_local, Fmake_local_variable):
5372 Mark variables as initialized.
5373 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5374
5375 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5376 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5377 Rename locals to avoid shadowing.
5378 (mark_stack): Move local variables into the #ifdef region where
5379 they're used.
5380 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5381 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5382 needed otherwise.
5383 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5384 (GC_STRING_CHARS): Remove; not used.
5385 (Fmemory_limit): Cast sbrk's returned value to char *.
5386
5387 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5388 avoids undefined behavior in theory.
5389
5390 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5391
5392 Use functions, not macros, for up- and down-casing (Bug#8254).
5393 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5394 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5395 to use the following functions instead of these macros.
5396 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5397 EMACS_INT, since callers assume the returned value fits in int.
5398 (upcase1): Likewise, for UPCASE_TABLE.
5399 (uppercasep, lowercasep, upcase): New static inline functions.
5400 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5401 the race-condition problem in the old DOWNCASE.
5402
5403 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5404 Rename locals to avoid shadowing.
5405 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5406 (regex_compile, re_search_2, re_match_2_internal):
5407 Remove unused local vars.
5408 (FREE_VAR): Rewrite so as not to use empty "else",
5409 which gcc can warn about.
5410 (regex_compile, re_match_2_internal): Mark locals as initialized.
5411 (RETALLOC_IF): Define only if needed.
5412 (WORDCHAR_P): Likewise. This one is never needed, but is used
5413 only in a comment talking about a compiler bug, so put inside
5414 the #if 0 of that comment.
5415 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5416 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5417 Remove; unused.
5418
5419 * search.c (boyer_moore): Rename locals to avoid shadowing.
5420 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5421 (PREV_CHAR_BOUNDARY): Likewise.
5422
5423 * search.c (simple_search): Remove unused var.
5424
5425 * dired.c (compile_pattern): Move decl from here ...
5426 * lisp.h: ... to here, so that it can be checked.
5427 (struct re_registers): New forward decl.
5428
5429 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5430
5431 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5432 All uses changed.
5433 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5434 Rename locals to avoid shadowing.
5435 (Fvertical_motion): Mark locals as initialized.
5436
5437 * casefiddle.c (casify_object, casify_region): Now static.
5438 (casify_region): Mark local as initialized.
5439
5440 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5441
5442 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5443 New macros, so that the caller can use some names other than
5444 gcpro1, gcpro2, etc.
5445 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5446 of the new macros.
5447 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5448 argument, for consistency with GCPRO2_VAR, etc: it is now the
5449 prefix of the variable, not the variable itself. All uses
5450 changed.
5451 * dired.c (directory_files_internal, file_name_completion):
5452 Rename locals to avoid shadowing.
5453
5454 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5455 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5456 dired.c's scmp function, had undefined behavior.
5457 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5458 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5459 * buffer.h: ... to here, because these macros use current_buffer,
5460 and the new implementation with inline functions needs to have
5461 current_buffer in scope now, rather than later when the macros
5462 are used.
5463 (downcase, upcase1): New static inline functions.
5464 (DOWNCASE, UPCASE1): Reimplement using these functions.
5465 This avoids undefined behavior in expressions like
5466 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5467 from race conditions in accessing the global variables
5468 case_temp1 and case_temp2.
5469 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5470 * lisp.h (case_temp1, case_temp2): Remove their decls.
5471 * character.h (ASCII_CHAR_P): Move from here ...
5472 * lisp.h: ... to here, so that the inline functions mentioned
5473 above can use them.
5474
5475 * dired.c (directory_files_internal_unwind): Now static.
5476
5477 * fileio.c (file_name_as_directory, directory_file_name):
5478 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5479 Now static.
5480 (file_name_as_directory): Use const pointers when appropriate.
5481 (Fexpand_file_name): Likewise. In particular, newdir might
5482 point at constant storage, so make it a const pointer.
5483 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5484 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5485 signedness issues.
5486 (Fset_file_times, Finsert_file_contents, auto_save_error):
5487 Rename locals to avoid shadowing.
5488
5489 * minibuf.c (choose_minibuf_frame_1): Now static.
5490 (Ftry_completion, Fall_completions): Rename or remove locals
5491 to avoid shadowing.
5492
5493 * marker.c (bytepos_to_charpos): Remove; unused.
5494
5495 * lisp.h (verify_bytepos, count_markers): New decls,
5496 so that gcc does not warn that these functions aren't declared.
5497
5498 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5499 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5500 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5501 (copy_text): Remove unused local var.
5502
5503 * filelock.c (within_one_second): Now static.
5504 (lock_file_1): Rename local to avoid shadowing.
5505
5506 * buffer.c (fix_overlays_before): Mark locals as initialized.
5507 (fix_start_end_in_overlays): Likewise. This function should be
5508 simplified by using pointers-to-pointers, but that's a different
5509 matter.
5510 (switch_to_buffer_1): Now static.
5511 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5512 (report_overlay_modification): Rename locals to avoid shadowing.
5513
5514 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5515 Fix pointer signedness issue.
5516 (sys_subshell): Mark local as volatile if checking for lint,
5517 to suppress a gcc -Wclobbered warning that does not seem to be right.
5518 (MAXPATHLEN): Define only if needed.
5519
5520 * process.c (serial_open, serial_configure): Move decls from here ...
5521 * systty.h: ... to here, so that they can be checked.
5522
5523 * fns.c (get_random, seed_random): Move extern decls from here ...
5524 * lisp.h: ... to here, so that they can be checked.
5525
5526 * sysdep.c (reset_io): Now static.
5527 (wait_for_termination_signal): Remove; unused.
5528
5529 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5530 (copy_keymap_item, append_key, push_text_char_description):
5531 Now static.
5532 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5533 (DENSE_TABLE_SIZE): Remove; unused.
5534 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5535 (describe_map_tree):
5536 Rename locals to avoid shadowing.
5537
5538 * keyboard.c: Declare functions static if they are not used elsewhere.
5539 (echo_char, echo_dash, cmd_error, top_level_2):
5540 (poll_for_input, handle_async_input): Now static.
5541 (read_char, kbd_buffer_get_event, make_lispy_position):
5542 (make_lispy_event, make_lispy_movement, apply_modifiers):
5543 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5544 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5545 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5546 (read_key_sequence, read_char): Mark locals as initialized.
5547 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5548
5549 * keyboard.h (make_ctrl_char): New decl.
5550 (mark_kboards): Move decl here ...
5551 * alloc.c (mark_kboards): ... from here.
5552
5553 * lisp.h (force_auto_save_soon): New decl.
5554
5555 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5556 (DEFINE_DUMMY_FUNCTION): New macro.
5557 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5558 Use it.
5559 (main): Add casts to avoid warnings
5560 if GCC considers string literals to be constants.
5561
5562 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5563
5564 * dbusbind.c: Pointer signedness fixes.
5565 (xd_signature, xd_append_arg, xd_initialize):
5566 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5567 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5568 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5569 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5570
5571 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5572 if GCC considers string literals to be constants.
5573 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5574
5575 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5576
5577 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5578 (print_preprocess, print_object): New macro to fix last change.
5579
5580 * print.c (print_preprocess): Don't forget font objects.
5581
5582 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5583
5584 * emacs.c (USAGE3): Doc fixes.
5585
5586 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5587
5588 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5589 structure.
5590
5591 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5592
5593 * lisp.h (VWindow_system, Qfile_name_history):
5594 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5595 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5596 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5597
5598 * w32select.c: Don't #include "keyboard.h".
5599 (run_protected): Add extern declaration for waiting_for_input.
5600
5601 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5602 * w32console.c (detect_input_pending, read_input_pending)
5603 (encode_terminal_code):
5604 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5605 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5606 (w32_system_caret_y, Qfile_name_history):
5607 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5608 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5609 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5610 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5611 * w32proc.c (Qlocal, report_file_error):
5612 * w32term.c (Vwindow_system, updating_frame):
5613 * w32uniscribe.c (initialized, uniscribe_font_driver):
5614 Remove unneeded extern declarations.
5615
5616 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5619
5620 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5621
5622 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5623 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5624 These macros can no longer be used for assignment.
5625
5626 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5627 Assign struct members directly, instead of using BUF_BEGV etc.
5628 (record_buffer_markers, fetch_buffer_markers): New functions for
5629 recording and fetching special buffer markers.
5630 (set_buffer_internal_1, set_buffer_temp): Use them.
5631
5632 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5633
5634 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5635
5636 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5637 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5638
5639 * xdisp.c (hscroll_window_tree):
5640 (reconsider_clip_changes): Use PT instead of BUF_PT.
5641
5642 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5643
5644 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5645 $(EMACS_ROOT)/lib/intprops.h.
5646
5647 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5648
5649 Fix more problems found by GCC 4.5.2's static checks.
5650
5651 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5652 to unsigned char * to avoid compiler diagnostic.
5653 (xg_free_frame_widgets): Make it clear that a local variable is
5654 needed only if USE_GTK_TOOLTIP.
5655 (gdk_window_get_screen): Make it clear that this macro is needed
5656 only if USE_GTK_TOOLTIP.
5657 (int_gtk_range_get_value): New function, which avoids a diagnostic
5658 from gcc -Wbad-function-cast.
5659 (xg_set_toolkit_scroll_bar_thumb): Use it.
5660 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5661 diagnostic from gcc -Wbad-function-cast.
5662 (get_utf8_string, xg_get_file_with_chooser):
5663 Rename locals to avoid shadowing.
5664 (create_dialog): Move locals to avoid shadowing.
5665
5666 * xgselect.c (xg_select): Remove unused var.
5667
5668 * image.c (four_corners_best): Mark locals as initialized.
5669 (gif_load): Initialize transparent_p to zero (Bug#8238).
5670 Mark another local as initialized.
5671 (my_png_error, my_error_exit): Mark with NO_RETURN.
5672
5673 * image.c (clear_image_cache): Now static.
5674 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5675 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5676 (x_edge_detection): Remove unnecessary cast that
5677 gcc -Wbad-function-cast diagnoses.
5678 (gif_load): Fix pointer signedness.
5679 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5680 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5681
5682 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 Improve quality of tests for time stamp overflow.
5685 For example, without this patch (encode-time 0 0 0 1 1
5686 1152921504606846976) returns the obviously-bogus value (-948597
5687 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5688 reports time overflow. See
5689 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5690 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5691 * editfns.c: Include limits.h and intprops.h.
5692 (TIME_T_MIN, TIME_T_MAX): New macros.
5693 (time_overflow): Move earlier, to before first use.
5694 (hi_time, lo_time): New functions, for an accurate test for
5695 out-of-range times.
5696 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5697 (Fget_internal_run_time): Don't assume time_t fits in int.
5698 (make_time): Use list2 instead of Fcons twice.
5699 (Fdecode_time): More accurate test for out-of-range times.
5700 (check_tm_member): New function.
5701 (Fencode_time): Use it, to test for out-of-range times.
5702 (lisp_time_argument): Don't rely on undefined left-shift and
5703 right-shift behavior when checking for time stamp overflow.
5704
5705 * editfns.c (time_overflow): New function, refactoring common code.
5706 (Fformat_time_string, Fdecode_time, Fencode_time):
5707 (Fcurrent_time_string): Use it.
5708
5709 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5710 * dired.c (make_time): Move to ...
5711 * editfns.c (make_time): ... here.
5712 * systime.h: Note the move.
5713
5714 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5715
5716 * fringe.c (update_window_fringes): Remove unused variables.
5717
5718 * unexmacosx.c (copy_data_segment): Also copy __got section.
5719 (Bug#8223)
5720
5721 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5722
5723 * termcap.c [MSDOS]: Include "msdos.h".
5724 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5725 Constify `char *' arguments and their references according to
5726 prototypes in tparam.h.
5727
5728 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5729
5730 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5731 Adapt all references accordingly.
5732
5733 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5734
5735 2011-03-11 Tom Tromey <tromey@redhat.com>
5736
5737 * buffer.c (syms_of_buffer): Remove obsolete comment.
5738
5739 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5740
5741 * termhooks.h (encode_terminal_code): Declare prototype.
5742
5743 * msdos.c (encode_terminal_code): Don't declare prototype.
5744
5745 * term.c (encode_terminal_code): Now external again, used by
5746 w32console.c and msdos.c.
5747
5748 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5749 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5750
5751 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 Fix some minor problems found by GCC 4.5.2's static checks.
5754
5755 * fringe.c (update_window_fringes): Mark locals as initialized
5756 (Bug#8227).
5757 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5758
5759 * alloc.c (mark_fringe_data): Move decl from here ...
5760 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5761 to check its interface.
5762 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5763
5764 * fontset.c (free_realized_fontset): Now static.
5765 (Fset_fontset_font): Rename local to avoid shadowing.
5766 (fontset_font): Mark local as initialized.
5767 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5768
5769 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5770
5771 * xselect.c (x_disown_buffer_selections): Remove; not used.
5772 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5773 (x_own_selection, Fx_disown_selection_internal): Rename locals
5774 to avoid shadowing.
5775 (x_handle_dnd_message): Remove local to avoid shadowing.
5776
5777 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5778 so that the caller can use some name other than gcpro1.
5779 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5780 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5781 (Fx_backspace_delete_keys_p):
5782 Use them to avoid shadowing, and rename vars to avoid shadowing.
5783 (x_decode_color, x_set_name, x_window): Now static.
5784 (Fx_create_frame): Add braces to silence GCC warning.
5785 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5786 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5787 Remove unused locals.
5788 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5789 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5790 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5791 macros.
5792
5793 * xterm.h (x_mouse_leave): New decl.
5794
5795 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5796 Remove unused functions.
5797 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5798 (x_calc_absolute_position): Now static.
5799 (XTread_socket): Don't define label "out" unless it's used.
5800 Don't declare local "event" unless it's used.
5801 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5802 unless they are used.
5803 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5804 (x_fatal_error_signal): Remove; not used.
5805 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5806 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5807 (x_error_catcher, x_connection_closed, x_error_handler):
5808 (x_error_quitter, xembed_send_message, x_iconify_frame):
5809 (my_log_handler): Rename locals to avoid shadowing.
5810 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5811 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5812
5813 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5814 Rename or move locals to avoid shadowing.
5815 (tty_defined_color, merge_face_heights): Now static.
5816 (free_realized_faces_for_fontset): Remove; not used.
5817 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5818 does not deduce is never used uninitialized.
5819 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5820 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5821
5822 * terminal.c (store_terminal_param): Now static.
5823
5824 * xmenu.c (menu_highlight_callback): Now static.
5825 (set_frame_menubar): Remove unused local.
5826 (xmenu_show): Rename parameter to avoid shadowing.
5827 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5828 since they might point to immutable storage.
5829 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5830 since it's unused otherwise.
5831
5832 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5833 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5834 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5835 avoids a gcc -Wuninitialized diagnostic.
5836 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5837 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5838 does not deduce are never used uninitialized.
5839
5840 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5841
5842 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5843 * window.c (window_loop, size_window):
5844 (run_window_configuration_change_hook, enlarge_window): Likewise.
5845
5846 * window.c (display_buffer): Now static.
5847 (size_window): Mark variables that gcc -Wuninitialized
5848 does not deduce are never used uninitialized.
5849 * window.h (check_all_windows): New decl, to forestall
5850 gcc -Wmissing-prototypes diagnostic.
5851 * dispextern.h (bidi_dump_cached_states): Likewise.
5852
5853 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5854 shadowing.
5855 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5856 Include <limits.h>.
5857 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5858 and to avoid gcc -Wuninitialized warning.
5859 (load_charset_map): Mark variables that gcc -Wuninitialized
5860 does not deduce are never used uninitialized.
5861 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5862
5863 * coding.c (coding_set_source, coding_set_destination):
5864 Use "else { /* comment */ }" rather than "else /* comment */;"
5865 for clarity, and to avoid gcc -Wempty-body warning.
5866 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5867 a block, when the outer 'i' will do.
5868 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5869 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5870 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5871 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5872 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5873 Rename locals to avoid shadowing.
5874 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5875 * coding.c (emacs_mule_char, encode_invocation_designation):
5876 Now static, since they're not used elsewhere.
5877 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5878 (decode_coding_object, encode_coding_object, detect_coding_system):
5879 (decode_coding_emacs_mule): Mark variables that gcc
5880 -Wuninitialized does not deduce are never used uninitialized.
5881 (detect_coding_iso_2022): Initialize a local variable that might
5882 be used uninitialized. Leave a FIXME because it's not clear that
5883 this initialization is needed. (Bug#8211)
5884 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5885 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5886 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5887 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5888 Remove unused macros.
5889
5890 * category.c (hash_get_category_set): Remove unused local var.
5891 (copy_category_table): Now static, since it's not used elsewhere.
5892 * character.c (string_count_byte8): Likewise.
5893
5894 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5895 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5896
5897 * chartab.c (copy_sub_char_table): Now static, since it's not used
5898 elsewhere.
5899 (sub_char_table_ref_and_range, char_table_ref_and_range):
5900 Rename locals to avoid shadowing.
5901 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5902
5903 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5904 (BIDI_BOB): Remove unused macro.
5905
5906 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5907 deduce are never used uninitialized.
5908 * term.c (encode_terminal_code): Likewise.
5909
5910 * term.c (encode_terminal_code): Now static. Remove unused local.
5911
5912 * tparam.h: New file.
5913 * term.c, tparam.h: Include it.
5914 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5915 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5916 Move these decls to tparam.h, and make them agree with what
5917 is actually in tparam.c. The previous trick of using incompatible
5918 decls in different modules does not conform to the C standard.
5919 All callers of tparam changed to use tparam's actual API.
5920 * tparam.c (tparam1, tparam, tgoto):
5921 Use const pointers where appropriate.
5922
5923 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5924 * cm.h (struct cm): Likewise.
5925 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5926 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5927 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5928 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5929 (turn_on_face, init_tty): Likewise.
5930 * termchar.h (struct tty_display_info): Likewise.
5931
5932 * term.c (term_mouse_position): Rename local to avoid shadowing.
5933
5934 * alloc.c (mark_ttys): Move decl from here ...
5935 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5936
5937 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5938
5939 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5940
5941 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5942
5943 * search.c (compile_pattern_1): Remove argument regp, unused since
5944 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5945 (compile_pattern): Don't pass it.
5946
5947 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5948
5949 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5950 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5951 for ! HAVE_GTK3.
5952 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5953
5954 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5955
5956 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5957 gdk_window_get_screen, gdk_window_get_geometry,
5958 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5959 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5960 (xg_get_pixbuf_from_pixmap): New function.
5961 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5962 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5963 Call xg_get_pixbuf_from_pixmap instead of
5964 gdk_pixbuf_get_from_drawable.
5965 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5966 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5967 (xg_check_special_colors): Use GtkStyleContext and its functions
5968 for HAVE_GTK3.
5969 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5970 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5971 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5972 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5973 Call gtk_widget_get_preferred_size.
5974 (xg_frame_resized): gdk_window_get_geometry only takes 5
5975 parameters.
5976 (xg_win_to_widget, xg_event_is_for_menubar):
5977 Call gdk_x11_window_lookup_for_display.
5978 (xg_set_widget_bg): New function.
5979 (delete_cb): New function.
5980 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5981 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5982 (xg_set_background_color): Call xg_set_widget_bg.
5983 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5984 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5985 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5986 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5987 if ! HAVE_GTK3.
5988 (update_frame_tool_bar): Call gtk_widget_hide.
5989 (xg_initialize): Use GDK_KEY_g.
5990
5991 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5992 if ! HAVE_GTK3
5993 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5994
5995 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5996 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5997 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5998
5999 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6000
6001 * w32xfns.c (select_palette): Check success of RealizePalette against
6002 GDI_ERROR, not zero.
6003
6004 See ChangeLog.11 for earlier changes.
6005
6006 ;; Local Variables:
6007 ;; coding: utf-8
6008 ;; End:
6009
6010 Copyright (C) 2011 Free Software Foundation, Inc.
6011
6012 This file is part of GNU Emacs.
6013
6014 GNU Emacs is free software: you can redistribute it and/or modify
6015 it under the terms of the GNU General Public License as published by
6016 the Free Software Foundation, either version 3 of the License, or
6017 (at your option) any later version.
6018
6019 GNU Emacs is distributed in the hope that it will be useful,
6020 but WITHOUT ANY WARRANTY; without even the implied warranty of
6021 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6022 GNU General Public License for more details.
6023
6024 You should have received a copy of the GNU General Public License
6025 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.