1 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7 * process.c: Use the same condition for POLL_FOR_INPUT in both
8 keyboard.c and process.c (bug#1858).
10 2011-07-09 Lawrence Mitchell <wence@gmx.li>
12 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
13 (Fgnutls_boot): Use it.
15 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
17 * doc.c (Fsubstitute_command_keys): Revert last change.
19 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
21 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
22 quotes the next character, and doesn't affect other longer
25 * lread.c (syms_of_lread): Clarify that is isn't only
26 `eval-buffer' and `eval-defun' that's affected by
27 `lexical-binding' (bug#8460).
29 2011-07-15 Eli Zaretskii <eliz@gnu.org>
31 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
32 bidi redisplay when a line includes both an image and is
35 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
37 Fix minor problems found by static checking.
38 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
39 (elsz): Now a signed constant, not a size_t var. We prefer signed
40 types to unsigned, to avoid integer comparison confusion. Without
41 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
42 "cannot optimize loop, the loop counter may overflow", a symptom
44 * indent.c (Fvertical_motion): Mark locals as initialized.
45 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
47 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
49 * search.c (Fre_search_backward): Mention `case-fold-search' in
50 all the re_search_* functions (bug#8138).
52 * keyboard.c (Fopen_dribble_file): Document when the file is
55 2011-07-14 Eli Zaretskii <eliz@gnu.org>
57 * bidi.c (bidi_dump_cached_states): Fix format of displaying
60 Support bidi reordering of display and overlay strings.
61 * xdisp.c (compute_display_string_pos)
62 (compute_display_string_end): Accept additional argument STRING.
63 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
64 (reseat_to_string): Initialize bidi_it->string.s and
65 bidi_it->string.schars.
66 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
67 NULL (avoids a crash in bidi_paragraph_init). Initialize
69 (init_iterator): Call bidi_init_it only of a valid
70 buffer position was specified. Initialize paragraph_embedding to
72 (reseat_to_string): Initialize the bidi iterator.
73 (display_string): If we need to ignore text properties of
74 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
75 original value of -1 will not work with bidi.)
76 (compute_display_string_pos): First arg is now struct
77 `text_pos *'; all callers changed. Support display properties on
79 (compute_display_string_end): Support display properties on Lisp
81 (init_iterator, reseat_1, reseat_to_string): Initialize the
82 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
83 when iterating on a string not from display properties).
84 (compute_display_string_pos, compute_display_string_end): Fix
85 calculation of the object to scan. Fixes an error when using
87 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
88 base_level_stop; instead, set base_level_stop to BEGV. Fixes
89 crashes in vertical-motion.
90 (next_element_from_buffer): Improve commentary for when
91 the iterator is before prev_stop.
92 (init_iterator): Initialize bidi_p from the default value of
93 bidi-display-reordering, not from buffer-local value. Use the
94 buffer-local value only if initializing for buffer iteration.
95 (handle_invisible_prop): Support invisible properties on strings
96 that are being bidi-reordered.
97 (set_iterator_to_next): Support bidi reordering of C strings and
99 (next_element_from_string): Support bidi reordering of Lisp
101 (handle_stop_backwards): Support Lisp strings as well.
102 (display_string): Support display of R2L glyph rows. Use
103 IT_STRING_CHARPOS when displaying from a Lisp string.
104 (init_iterator): Don't initialize it->bidi_p for strings
106 (reseat_to_string): Initialize it->bidi_p for strings here.
107 (next_element_from_string, next_element_from_c_string)
108 (next_element_from_buffer): Add xassert's for correspondence
109 between IT's object being iterated and it->bidi_it.string
111 (face_before_or_after_it_pos): Support bidi iteration.
112 (next_element_from_c_string): Handle the case of the first string
113 character that is not the first one in the visual order.
114 (get_visually_first_element): New function, refactored from common
115 parts of next_element_from_buffer, next_element_from_string, and
116 next_element_from_c_string.
117 (tool_bar_lines_needed, redisplay_tool_bar)
118 (display_menu_bar): Force left-to-right direction. Add a FIXME
119 comment for making that be controlled by a user option.
120 (push_it, pop_it): Save and restore the state of the
121 bidi iterator. Save and restore the bidi_p flag.
122 (pop_it): Iterate out of display property for string iteration as
124 (iterate_out_of_display_property): Support iteration over strings.
125 (handle_single_display_spec): Set up it->bidi_it for iteration
126 over a display string, and call bidi_init_it.
127 (handle_single_display_spec, next_overlay_string)
128 (get_overlay_strings_1, push_display_prop): Set up the bidi
129 iterator for displaying display or overlay strings.
130 (forward_to_next_line_start): Don't use the shortcut if
132 (back_to_previous_visible_line_start): If handle_display_prop
133 pushed the iterator stack, restore the internal state of the bidi
134 iterator by calling bidi_pop_it same number of times.
135 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
136 and we are bidi-iterating, don't decrement the iterator position;
137 instead, set the first_elt flag in the bidi iterator, to produce
139 (reseat_1): Remove redundant setting of string_from_display_prop_p.
140 (push_display_prop): xassert that we are iterating a buffer.
141 (push_it, pop_it): Save and restore paragraph_embedding member.
142 (handle_single_display_spec, next_overlay_string)
143 (get_overlay_strings_1, reseat_1, reseat_to_string)
144 (push_display_prop): Set up the `unibyte' member of bidi_it.string
145 correctly. Don't assume unibyte strings are not bidi-reordered.
146 (compute_display_string_pos)
147 (compute_display_string_end): Fix handling the case of C string.
148 (push_it, pop_it): Save and restore from_disp_prop_p.
149 (handle_single_display_spec, push_display_prop): Set the
150 from_disp_prop_p flag.
151 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
152 (pop_it): Call iterate_out_of_display_property only if we are
153 popping after iteration over a string that came from a display
154 property. Fix a typo in popping stretch info. Add an assertion
155 for verifying that the iterator position is in sync with the bidi
157 (handle_single_display_spec, get_overlay_strings_1)
158 (push_display_prop): Fix initialization of paragraph direction for
159 string when that of the parent object is not yet determined.
160 (reseat_1): Call bidi_init_it to resync the bidi
161 iterator with IT's position. (Bug#7616)
162 (find_row_edges): If ROW->start.pos gives position
163 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
164 (handle_stop, back_to_previous_visible_line_start, reseat_1):
165 Reset the from_disp_prop_p flag.
166 (SAVE_IT, RESTORE_IT): New macros.
167 (pos_visible_p, face_before_or_after_it_pos)
168 (back_to_previous_visible_line_start)
169 (move_it_in_display_line_to, move_it_in_display_line)
170 (move_it_to, move_it_vertically_backward, move_it_by_lines)
171 (try_scrolling, redisplay_window, display_line): Use them when
172 saving a temporary copy of the iterator and restoring it back.
173 (back_to_previous_visible_line_start, reseat_1)
174 (init_iterator): Empty the bidi cache "stack".
175 (move_it_in_display_line_to): If iterator ended up at
176 EOL, but we never saw any buffer positions smaller than
177 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
178 motion in bidi-reordered lines.
179 (move_it_in_display_line_to): Record prev_method and prev_pos
180 immediately before the call to set_iterator_to_next. Fixes cursor
181 motion in bidi-reordered lines with stretch glyphs and strings
182 displayed in margins. (Bug#8133) (Bug#8867)
183 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
185 (pos_visible_p): Support positions in bidi-reordered lines. Save
186 and restore bidi cache.
188 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
189 (bidi_paragraph_info): Delete unused struct.
190 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
191 (bidi_cache_start): New variable.
192 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
194 (bidi_cache_fetch_state, bidi_cache_search)
195 (bidi_cache_find_level_change, bidi_cache_iterator_state)
196 (bidi_cache_find, bidi_peek_at_next_level)
197 (bidi_level_of_next_char, bidi_find_other_level_edge)
198 (bidi_move_to_visually_next): Compare cache index with
199 bidi_cache_start rather than with zero.
200 (bidi_fetch_char): Accept new argument STRING; all callers
201 changed. Support iteration over a string. Support strings with
202 display properties. Support unibyte strings. Fix the type of
203 `len' according to what STRING_CHAR_AND_LENGTH expects.
204 (bidi_paragraph_init, bidi_resolve_explicit_1)
205 (bidi_resolve_explicit, bidi_resolve_weak)
206 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
207 iteration over a string.
208 (bidi_set_sor_type, bidi_resolve_explicit_1)
209 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
210 can now be zero (for strings); special values 0 and -1 were
211 changed to -1 and -2, respectively.
212 (bidi_char_at_pos): New function.
213 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
214 Call it instead of FETCH_MULTIBYTE_CHAR.
215 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
216 initialized to valid values.
217 (bidi_init_it): Don't initialize charpos and bytepos with invalid
219 (bidi_level_of_next_char): Allow the sentinel "position" to pass
220 the test for valid cached positions. Fix the logic for looking up
221 the sentinel state in the cache. GCPRO the Lisp string we are
223 (bidi_push_it, bidi_pop_it): New functions.
224 (bidi_initialize): Initialize the bidi cache start stack pointer.
225 (bidi_cache_ensure_space): New function, refactored from part of
226 bidi_cache_iterator_state. Don't assume the required size is just
227 one BIDI_CACHE_CHUNK away.
228 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
229 (bidi_count_bytes, bidi_char_at_pos): New functions.
230 (bidi_cache_search): Don't assume bidi_cache_last_idx is
231 always valid if bidi_cache_idx is valid.
232 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
233 is valid if it's going to be used.
234 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
235 (bidi_cache_fetch_state, bidi_cache_search)
236 (bidi_cache_find_level_change, bidi_cache_ensure_space)
237 (bidi_cache_iterator_state, bidi_cache_find)
238 (bidi_find_other_level_edge, bidi_cache_start_stack): All
239 variables related to cache indices are now EMACS_INT.
241 * dispextern.h (struct bidi_string_data): New structure.
242 (struct bidi_it): New member `string'. Make flag members be 1-bit
243 fields, and put them last in the struct.
244 (compute_display_string_pos, compute_display_string_end): Update
246 (bidi_push_it, bidi_pop_it): Add prototypes.
247 (struct iterator_stack_entry): New members bidi_p,
248 paragraph_embedding, and from_disp_prop_p.
249 (struct it): Member bidi_p is now a bit field 1 bit wide.
250 (bidi_shelve_cache, bidi_unshelve_cache): Declare
253 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
254 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
255 and vector-like objects.
257 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
258 cache around display iteration.
260 * window.c (Fwindow_end, window_scroll_pixel_based)
261 (displayed_window_lines, Frecenter): Save and restore the bidi
262 cache around display iteration.
264 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
266 * editfns.c (Fdelete_region): Clarify the use of the named
267 parameters (bug#6788).
269 2011-07-14 Martin Rudalics <rudalics@gmx.at>
271 * indent.c (Fvertical_motion): Set and restore w->pointm when
272 saving and restoring the window's buffer (Bug#9006).
274 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
276 * editfns.c (Fstring_to_char): Clarify just what is returned
277 (bug#6576). Text by Eli Zaretskii.
279 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
281 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
283 2011-07-13 Eli Zaretskii <eliz@gnu.org>
285 * buffer.c (mmap_find): Fix a typo.
287 2011-07-13 Johan Bockgård <bojohan@gnu.org>
289 Fix execution of x selection hooks.
290 * xselect.c (Qx_lost_selection_functions)
291 (Qx_sent_selection_functions): New vars.
292 (syms_of_xselect): DEFSYM them.
293 (x_handle_selection_request): Pass Qx_sent_selection_functions
294 rather than Vx_sent_selection_functions to Frun_hook_with_args.
295 (x_handle_selection_clear,x_clear_frame_selections):
296 Pass Qx_lost_selection_functions rather than
297 Vx_lost_selection_functions to Frun_hook_with_args.
299 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
301 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
302 The old code sometimes used this field without initializing it.
304 * alloc.c (gc_sweep): Don't read past end of array.
305 In theory, the old code could also have corrupted Emacs internals,
306 though it'd be very unlikely.
308 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
310 * character.c (Fcharacterp): Don't advertise optional ignored
313 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
315 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
318 * window.c (Fset_window_start): Doc fix (bug#4199).
319 (Fset_window_hscroll): Ditto.
321 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
323 Fix minor new problems caught by GCC 4.6.1.
324 * term.c (init_tty): Remove unused local.
325 * xsettings.c (store_monospaced_changed): Define this function only
326 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
329 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
331 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
333 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
335 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
336 are the mini-buffer and the echo area (bug#3320).
338 * term.c (init_tty): Remove support for supdup, c10 and perq
339 terminals, which are no longer supported (bug#1482).
341 2011-07-10 Johan Bockgård <bojohan@gnu.org>
343 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
345 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
347 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
348 for non-popups (Bug#3642).
350 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
352 * alloc.c (reset_malloc_hooks): Protoize.
353 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
354 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
355 * cm.c (losecursor): Likewise.
356 * data.c (fmod): Likewise.
357 * dispnew.c (swap_glyphs_in_rows): Likewise.
358 * emacs.c (memory_warning_signal): Likewise.
359 * floatfns.c (float_error): Likewise.
360 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
361 (otf_open, font_otf_capability, generate_otf_features)
362 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
364 * image.c (pbm_read_file): Likewise.
365 * indent.c (string_display_width): Likewise.
366 * intervals.c (check_for_interval, search_for_interval)
367 (inc_interval_count, count_intervals, root_interval)
368 (adjust_intervals_for_insertion, make_new_interval): Likewise.
369 * lread.c (defalias): Likewise.
370 * ralloc.c (r_alloc_check): Likewise.
371 * regex.c (set_image_of_range_1, set_image_of_range)
372 (regex_grow_registers): Likewise.
373 * sysdep.c (strerror): Likewise.
374 * termcap.c (valid_filename_p, tprint, main): Likewise.
375 * tparam.c (main): Likewise.
376 * unexhp9k800.c (run_time_remap, save_data_space)
377 (update_file_ptrs, read_header, write_header, calculate_checksum)
378 (copy_file, copy_rest, display_header): Likewise.
379 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
381 * xdisp.c (check_it): Likewise.
382 * xfaces.c (register_color, unregister_color, unregister_colors):
384 * xfns.c (print_fontset_result): Likewise.
385 * xrdb.c (member, fatal, main): Likewise.
387 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
389 Fix minor problems found by static checking (Bug#9031).
390 * chartab.c (char_table_set_range, map_sub_char_table):
391 Remove unused locals.
392 (uniprop_table): Now static.
393 * composite.c (_work_char): Remove unused static var.
395 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
397 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
399 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
401 * gtkutil.c (qttip_cb): Remove code without function.
403 2011-07-09 Eli Zaretskii <eliz@gnu.org>
405 * w32.c (pthread_sigmask): New stub.
407 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
409 Use pthread_sigmask, not sigprocmask (Bug#9010).
410 sigprocmask is portable only for single-threaded applications, and
411 Emacs can be multi-threaded when it uses GTK.
412 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
414 * callproc.c (Fcall_process):
415 * process.c (create_process):
416 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
417 Use pthread_sigmask, not sigprocmask.
419 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
421 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
422 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
425 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
427 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
428 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
429 (xg_hide_tooltip): Fix comment.
431 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
432 in registerServicesMenuSendTypes.
433 (validRequestorForSendType): Don't check ns_return_types.
435 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
438 2011-07-08 Jason Rumney <jasonr@gnu.org>
440 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
441 frame struct members of non-existent frames (Bug#6284).
443 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
445 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
446 variable firstTime not needed on OSX >= 10.6.
447 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
448 >= 10.5. Use setKnobProportion, setDoubleValue.
450 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
451 (MAC_OS_X_VERSION_10_5): Define if not defined.
452 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
453 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
454 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
456 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
457 cString and lossyCString on OSX >= 10.4
459 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
460 sizeToFit on OSX >= 10.2.
462 * nsimage.m (allocInitFromFile): Don't use deprecated method
463 bestRepresentationForDevice on OSX >= 10.6.
465 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
468 * emacs.c: Declare unexec_init_emacs_zone.
470 * nsgui.h: Fix compiler warning about gnulib redefining verify.
472 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
474 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
475 on svcsMenu (Bug#8842).
477 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
479 (Fns_list_services): Just return Qnil on 10.6, code not working there.
481 * nsterm.m (QUTF8_STRING): Declare.
482 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
483 (validRequestorForSendType): Return type is (id).
484 Change indexOfObjectIdenticalTo to indexOfObject.
485 Check if we have local selection before returning self (Bug#8842).
486 (writeSelectionToPasteboard): Put local selection into paste board
487 if we have a local selection (Bug#8842).
488 (syms_of_nsterm): DEFSYM QUTF8_STRING.
490 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
491 (ns_get_local_selection): Declare.
493 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
495 * keymap.c (describe_map_tree): Don't insert a double newline at
496 the end of the buffer (bug#1169) and return whether we inserted
499 * callint.c (Fcall_interactively): Change "reading args" to
500 "providing args" to try to clarify what it does (bug#1010).
502 2011-07-07 Kenichi Handa <handa@m17n.org>
504 * composite.c (composition_compute_stop_pos): Ignore a static
505 composition starting before CHARPOS (Bug#8915).
507 * xdisp.c (handle_composition_prop): Likewise.
509 2011-07-07 Eli Zaretskii <eliz@gnu.org>
511 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
514 2011-07-07 Kenichi Handa <handa@m17n.org>
516 * character.h (unicode_category_t): New enum type.
518 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
519 (Qchar_code_property_table): New variable.
520 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
521 (UNIPROP_COMPRESSED_FORM_P): New macros.
522 (char_table_ascii): Uncompress the compressed values.
523 (sub_char_table_ref): New arg is_uniprop. Callers changed.
524 Uncompress the compressed values.
525 (sub_char_table_ref_and_range): Likewise.
526 (char_table_ref_and_range): Uncompress the compressed values.
527 (sub_char_table_set): New arg is_uniprop. Callers changed.
528 Uncompress the compressed values.
529 (sub_char_table_set_range): Args changed. Callers changed.
530 (char_table_set_range): Adjuted for the above change.
531 (map_sub_char_table): Delete args default_val and parent. Add arg
532 top. Give decoded values to a Lisp function.
533 (map_char_table): Adjusted for the above change. Give decoded
534 values to a Lisp function. Gcpro more variables.
535 (uniprop_table_uncompress)
536 (uniprop_decode_value_run_length): New functions.
537 (uniprop_decoder, uniprop_decoder_count): New variables.
538 (uniprop_get_decoder, uniprop_encode_value_character)
539 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
541 (uniprop_encoder, uniprop_encoder_count): New variables.
542 (uniprop_get_encoder, uniprop_table)
543 (Funicode_property_table_internal, Fget_unicode_property_internal)
544 (Fput_unicode_property_internal): New functions.
545 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
546 Sunicode_property_table_internal, Sget_unicode_property_internal,
547 and Sput_unicode_property_internal. Defvar_lisp
548 char-code-property-alist.
550 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
551 Vunicode_category_table.
553 * font.c (font_range): Adjusted for the change of
554 Vunicode_category_table.
556 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
558 * m/iris4d.h: Remove file, move contents ...
559 * s/irix6-5.h: ... here.
561 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
563 Remove unportable assumption about struct layout (Bug#8884).
564 * alloc.c (mark_buffer):
565 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
566 (clone_per_buffer_values): Don't assume that
567 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
568 This isn't true in general, and it's particularly not true
569 if Emacs is configured with --with-wide-int.
570 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
571 New macros, used in the buffer.c change.
573 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
575 * xsettings.c: Use both GConf and GSettings if both are available.
576 (store_config_changed_event): Add comment.
577 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
578 (store_tool_bar_style_changed): New functions.
579 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
580 (struct xsettings): Move font inside HAVE_XFT.
581 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
582 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
583 Move inside HAVE_XFT.
584 (something_changed_gsettingsCB): Renamed from something_changedCB.
585 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
587 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
588 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
589 (something_changed_gconfCB): Renamed from something_changedCB.
590 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
591 (parse_settings): Move check for font inside HAVE_XFT.
592 (read_settings, apply_xft_settings): Add comment.
593 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
594 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
595 call store_font_name_changed.
596 (xft_settings_event): Add comment.
597 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
598 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
599 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
600 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
601 (xsettings_initialize): Call init_gsettings last.
602 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
605 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
607 Random fixes. E.g., (random) never returned negative values.
608 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
609 subseconds part to the entropy, as that's a bit more random.
610 Prefer signed to unsigned, since the signedness doesn't matter and
611 in general we prefer signed. When given a limit, use a
612 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
613 latter isn't right if USE_2_TAGS_FOR_INTS.
614 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
615 not 0..VALMASK. Don't discard "excess" bits that random () returns.
617 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
619 * textprop.c (text_property_stickiness):
620 Obey Vtext_property_default_nonsticky.
621 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
622 * w32fns.c (syms_of_w32fns):
623 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
625 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
627 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
628 This is more efficient than Ffile_directory_p and avoids a minor race.
630 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
632 * buffer.c (Foverlay_put): Say what the return value is
635 * fileio.c (barf_or_query_if_file_exists): Check first if the file
636 is a directory before asking whether to use the file name
638 (barf_or_query_if_file_exists): Make the "File is a directory"
639 error be more correct.
641 * fns.c (Frequire): Remove the mention of the .gz files, since
642 that's installation-specific, but keep the mention of
645 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
647 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
648 Report string overflow if the output is too long.
650 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
652 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
653 (syms_of_gnutls): Remove duplicate DEFSYM for
654 Qgnutls_bootprop_verify_hostname_error, an error for
655 Qgnutls_bootprop_verify_error (which is no longer used).
657 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
658 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
659 Also (re)move comments that are misplaced or no longer relevant.
661 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
663 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
665 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
667 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
668 and background color parameters if they have been changed.
670 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
672 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
674 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
676 * xsettings.c (SYSTEM_FONT): Define only when used.
677 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
679 * keymap.c (access_keymap_1): Now static.
681 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
683 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
684 leave any prefix arg for the up event (Bug#1586).
686 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
688 * lread.c (syms_of_lread): Mention single symbols defined by
689 `defvar' or `defconst' (bug#7154).
691 * fns.c (Frequire): Mention .el.gz files (bug#7314).
692 (Frequire): Mention get-load-suffixes.
694 2011-07-02 Martin Rudalics <rudalics@gmx.at>
696 * window.h (window): Remove clone_number slot.
697 * window.c (Fwindow_clone_number, Fset_window_clone_number):
699 (make_parent_window, make_window, saved_window)
700 (Fset_window_configuration, save_window_save): Don't deal with
702 * buffer.c (Qclone_number): Remove declaration.
703 (sort_overlays, overlay_strings): Don't deal with clone numbers.
705 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
707 Add multiple inheritance to keymaps.
708 * keymap.c (Fmake_composed_keymap): New function.
709 (Fset_keymap_parent): Simplify.
710 (fix_submap_inheritance): Remove.
711 (access_keymap_1): New function extracted from access_keymap to handle
712 embedded parents and handle lists of maps.
713 (access_keymap): Use it.
714 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
715 (Fcopy_keymap): Handle embedded parents.
716 (Fcommand_remapping, define_as_prefix): Simplify.
717 (Fkey_binding): Simplify.
718 (syms_of_keymap): Move minibuffer-local-completion-map,
719 minibuffer-local-filename-completion-map,
720 minibuffer-local-must-match-map, and
721 minibuffer-local-filename-must-match-map to Elisp.
722 (syms_of_keymap): Defsubr make-composed-keymap.
723 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
724 (parse_menu_item): Trivial simplification.
726 2011-07-01 Glenn Morris <rgm@gnu.org>
728 * Makefile.in (SETTINGS_LIBS): Fix typo.
730 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
732 * coding.c (Fencode_coding_string): Record the last coding system
733 used, as the function doc string says (bug#8738).
735 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
737 * xsettings.c (store_monospaced_changed): Take new font as arg and
738 check for change against current_mono_font.
739 (EMACS_TYPE_SETTINGS): Remove this and related defines.
740 (emacs_settings_constructor, emacs_settings_get_property)
741 (emacs_settings_set_property, emacs_settings_class_init)
742 (emacs_settings_init, gsettings_obj): Remove.
743 (something_changedCB): New function for HAVE_GSETTINGS.
744 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
745 with value as argument.
746 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
747 g_settings_new (Bug#8967). Do not create gsettings_obj.
748 Remove calls to g_settings_bind. Connect something_changedCB to
751 * xgselect.c: Add defined (HAVE_GSETTINGS).
752 (xgselect_initialize): Ditto.
754 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
755 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
758 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
760 * eval.c (struct backtrace): Simplify and port the data structure.
761 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
762 signed bit field, as this assumption is not portable and it makes
763 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
764 "char debug_on_exit : 1" as this is not portable either; instead,
765 use the portable "unsigned int debug_on_exit : 1". Remove unused
766 member evalargs. Remove obsolete comments about cc bombing out.
768 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
770 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
771 Let HAVE_GSETTINGS override HAVE_GCONF.
772 (store_monospaced_changed): New function.
773 (EMACS_SETTINGS): A new type derived from GObject to handle
774 GSettings notifications.
775 (emacs_settings_constructor, emacs_settings_get_property)
776 (emacs_settings_set_property, emacs_settings_class_init):
778 (gsettings_client, gsettings_obj): New variables.
779 (GSETTINGS_SCHEMA): New define.
780 (something_changedCB): Call store_monospaced_changed.
781 (init_gsettings): New function.
782 (xsettings_initialize): Call init_gsettings.
783 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
786 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
789 2011-06-29 Martin Rudalics <rudalics@gmx.at>
791 * window.c (resize_root_window, grow_mini_window)
792 (shrink_mini_window): Rename Qresize_root_window to
793 Qwindow_resize_root_window and Qresize_root_window_vertically to
794 Qwindow_resize_root_window_vertically.
796 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
798 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
800 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
802 * makefile.w32-in: Redesign dependencies so they reflect more
803 clearly which files are directly included by each source file,
804 and not through other includes.
806 2011-06-27 Martin Rudalics <rudalics@gmx.at>
808 * buffer.c (Qclone_number): Declare static and DEFSYM it.
809 (sort_overlays, overlay_strings): When an overlay's clone number
810 matches the window's clone number process the overlay even if
811 the overlay's window property doesn't match the current window.
813 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
814 (Fwindow_hchild): Rename to Fwindow_left_child.
815 (Fwindow_next): Rename to Fwindow_next_sibling.
816 (Fwindow_prev): Rename to Fwindow_prev_sibling.
817 (resize_window_check): Rename to window_resize_check.
818 (resize_window_apply): Rename to window_resize_apply.
819 (Fresize_window_apply): Rename to Fwindow_resize_apply.
820 (Fdelete_other_windows_internal, resize_frame_windows)
821 (Fsplit_window_internal, Fdelete_window_internal)
822 (grow_mini_window, shrink_mini_window)
823 (Fresize_mini_window_internal): Fix callers accordingly.
825 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
827 * emacsgtkfixed.h: State that this is only used with Gtk+3.
828 (emacs_fixed_set_min_size): Remove.
829 (emacs_fixed_new): Take frame as argument.
831 * emacsgtkfixed.c: State that this is only used with Gtk+3.
832 (_EmacsFixedPrivate): Remove minwidth/height.
834 (emacs_fixed_init): Initialize priv->f.
835 (get_parent_class, emacs_fixed_set_min_size): Remove.
836 (emacs_fixed_new): Set priv->f to argument.
837 (emacs_fixed_get_preferred_width)
838 (emacs_fixed_get_preferred_height): Use min_width/height from
839 frames size_hint to set minimum and natural (Bug#8919).
840 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
841 and use min_width/height from frames size_hint to set
842 min_width/height (Bug#8919).
844 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
845 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
848 2011-06-26 Eli Zaretskii <eliz@gnu.org>
850 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
851 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
854 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
856 * process.c (wait_reading_process_output): Bypass select if
857 waiting for a cell while ignoring keyboard input, and input is
858 pending. Suggested by Jan Djärv (Bug#8869).
860 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
862 Use gnulib's dup2 module instead of rolling our own.
863 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
865 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
867 * dispnew.c (scrolling_window): Before scrolling, turn off a
868 mouse-highlight in the window being scrolled.
870 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
872 Move DEFSYM to lisp.h and use everywhere.
874 * character.h (DEFSYM): Move declaration...
875 * lisp.h (DEFSYM): ...here.
881 * w32select.c: Don't include character.h.
883 * alloc.c (syms_of_alloc):
884 * buffer.c (syms_of_buffer):
885 * bytecode.c (syms_of_bytecode):
886 * callint.c (syms_of_callint):
887 * casefiddle.c (syms_of_casefiddle):
888 * casetab.c (init_casetab_once):
889 * category.c (init_category_once, syms_of_category):
890 * ccl.c (syms_of_ccl):
891 * cmds.c (syms_of_cmds):
892 * composite.c (syms_of_composite):
893 * dbusbind.c (syms_of_dbusbind):
894 * dired.c (syms_of_dired):
895 * dispnew.c (syms_of_display):
896 * doc.c (syms_of_doc):
897 * editfns.c (syms_of_editfns):
898 * emacs.c (syms_of_emacs):
899 * eval.c (syms_of_eval):
900 * fileio.c (syms_of_fileio):
901 * fns.c (syms_of_fns):
902 * frame.c (syms_of_frame):
903 * fringe.c (syms_of_fringe):
904 * insdel.c (syms_of_insdel):
905 * keymap.c (syms_of_keymap):
906 * lread.c (init_obarray, syms_of_lread):
907 * macros.c (syms_of_macros):
908 * msdos.c (syms_of_msdos):
909 * print.c (syms_of_print):
910 * process.c (syms_of_process):
911 * search.c (syms_of_search):
912 * sound.c (syms_of_sound):
913 * syntax.c (init_syntax_once, syms_of_syntax):
914 * terminal.c (syms_of_terminal):
915 * textprop.c (syms_of_textprop):
916 * undo.c (syms_of_undo):
917 * w32.c (globals_of_w32):
918 * window.c (syms_of_window):
919 * xdisp.c (syms_of_xdisp):
920 * xfaces.c (syms_of_xfaces):
921 * xfns.c (syms_of_xfns):
922 * xmenu.c (syms_of_xmenu):
923 * xsettings.c (syms_of_xsettings):
924 * xterm.c (syms_of_xterm): Use DEFSYM.
926 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
928 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
930 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
932 Integer and buffer overflow fixes (Bug#8873).
934 * print.c (printchar, strout): Check for string overflow.
935 (PRINTPREPARE, printchar, strout):
936 Don't set size unless allocation succeeds.
938 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
939 for sizes. Check for string overflow more accurately.
940 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
942 * macros.c: Integer and buffer overflow fixes.
943 * keyboard.h (struct keyboard.kbd_macro_bufsize):
944 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
945 Use ptrdiff_t, not int, for sizes.
946 Don't increment bufsize until after realloc succeeds.
947 Check for size-calculation overflow.
948 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
950 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
952 * lread.c: Integer overflow fixes.
953 (read_integer): Radix is now EMACS_INT, not int,
954 to improve quality of diagnostics for out-of-range radices.
955 Calculate buffer size correctly for out-of-range radices.
956 (read1): Check for integer overflow in radices, and in
958 (read_escape): Avoid int overflow.
959 (Fload, openp, read_buffer_size, read1)
960 (substitute_object_recurse, read_vector, read_list, map_obarray):
961 Use ptrdiff_t, not int, for sizes.
962 (read1): Use EMACS_INT, not int, for sizes.
963 Check for size overflow.
965 * image.c (cache_image): Check for size arithmetic overflow.
967 * lread.c: Integer overflow issues.
968 (saved_doc_string_size, saved_doc_string_length)
969 (prev_saved_doc_string_size, prev_saved_doc_string_length):
970 Now ptrdiff_t, not int.
971 (read1): Don't assume doc string length fits in int. Check for
972 out-of-range doc string lengths.
973 (read_list): Don't assume file position fits in int.
974 (read_escape): Check for hex character overflow.
976 2011-06-22 Leo Liu <sdl.web@gmail.com>
978 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
979 Move to minibuffer.el.
981 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
983 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
984 The following patches are for when GLYPH_DEBUG && !XASSERT.
985 * dispextern.h (trace_redisplay_p, dump_glyph_string):
986 * dispnew.c (flush_stdout):
987 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
988 Mark as externally visible.
989 * dispnew.c (check_window_matrix_pointers): Now static.
990 * dispnew.c (window_to_frame_vpos):
991 * xfns.c (unwind_create_frame):
992 * xterm.c (x_check_font): Remove unused local.
993 * scroll.c (CHECK_BOUNDS):
994 * xfaces.c (cache_fache): Rename local to avoid shadowing.
995 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
996 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
997 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
998 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1000 (debug_method_add): Use va_list and vsprintf rather than relying
1001 on undefined behavior with wrong number of arguments.
1002 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1003 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1004 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1005 since we're not interested in debugging glyphs with old libraries.
1006 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1007 GCC 4.6.0's static checking.
1009 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1011 Integer overflow and signedness fixes (Bug#8873).
1012 A few related buffer overrun fixes, too.
1014 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1016 * dispextern.h (struct face.stipple):
1017 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1018 (x_bitmap_mask, x_allocate_bitmap_record)
1019 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1020 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1021 (x_create_bitmap_from_xpm_data):
1022 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1023 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1025 * xfaces.c (load_pixmap):
1026 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1027 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1028 (.bitmaps_last, struct x_output.icon_bitmap):
1029 Use ptrdiff_t, not int, for bitmap indexes.
1030 (x_allocate_bitmap_record): Check for size overflow.
1031 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1033 Use ptrdiff_t, not int, for overlay counts.
1034 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1035 * editfns.c (overlays_around, get_pos_property):
1036 * textprop.c (get_char_property_and_overlay):
1037 * xdisp.c (next_overlay_change, note_mouse_highlight):
1038 * xfaces.c (face_at_buffer_position):
1039 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1040 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1041 (Fnext_overlay_change, Fprevious_overlay_change)
1042 (mouse_face_overlay_overlaps, Foverlays_in):
1043 Use ptrdiff_t, not int, for sizes.
1044 (overlays_at, overlays_in): Check for size-calculation overflow.
1046 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1048 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1049 (x_session_initialize): Do not assume string length fits in int.
1051 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1052 This is unlikely, but can occur if DPI is outlandish.
1054 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1055 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1057 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1058 * xrdb.c (magic_file_p, search_magic_path):
1059 Omit last arg SUFFIX; it was always 0. All callers changed.
1060 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1062 * xfont.c (xfont_match): Avoid need for strlen.
1064 * xfns.c: Don't assume strlen fits in int.
1065 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1067 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1068 not unsigned long, as we prefer signed integers. All callers changed.
1069 Detect integer overflow in repeat count.
1070 (message_dolog): Don't assume print length fits in 39 bytes.
1071 (display_mode_element): Don't assume strlen fits in int.
1073 * termcap.c: Don't assume sizes fit in int and never overflow.
1074 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1075 (gobble_line): Check for size-calculation overflow.
1077 * minibuf.c (Fread_buffer):
1078 * lread.c (intern, intern_c_string):
1079 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1080 Don't assume string length fits in int.
1082 * keyboard.c (parse_tool_bar_item):
1083 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1085 * font.c: Don't assume string length fits in int.
1086 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1087 Use ptrdiff_t, not int.
1088 (font_intern_prop): Don't assume string length fits in int.
1089 Don't assume integer property fits in fixnum.
1090 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1092 * filelock.c: Fix some buffer overrun and integer overflow issues.
1093 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1094 Reformulate so as not to need the command string.
1095 Invoke gzip -cd rather than gunzip, as it's more portable.
1096 (lock_info_type, lock_file_1, lock_file):
1097 Don't assume pid_t and time_t fit in unsigned long.
1098 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1099 (current_lock_owner): Prefer signed type for sizes.
1100 Use memcpy, not strncpy, where memcpy is what is really wanted.
1101 Don't assume (via atoi) that time_t and pid_t fit in int.
1102 Check for time_t and/or pid_t out of range, e.g., via a network share.
1103 Don't alloca where an auto var works fine.
1105 * fileio.c: Fix some integer overflow issues.
1106 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1107 Don't assume string length fits in int.
1108 (directory_file_name): Don't assume string length fits in long.
1109 (make_temp_name): Don't assume pid fits in int, or that its print
1110 length is less than 20.
1112 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1114 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1116 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1118 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1119 We prefer signed integers, even for size calculations.
1121 * emacs.c: Don't assume string length fits in 'int'.
1122 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1123 (main): Don't invoke strlen when not needed.
1125 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1126 (XD_DEBUG_MESSAGE): Don't waste a byte.
1128 * callproc.c (getenv_internal_1, getenv_internal)
1130 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1132 * lread.c (invalid_syntax): Omit length argument.
1133 All uses changed. This doesn't fix a bug, but it simplifies the
1134 code away from its former Hollerith-constant appearance, and it's
1135 one less 'int' to worry about when looking at integer-overflow issues.
1136 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1138 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1139 This didn't break anything, but it didn't help either.
1140 It's confusing to put a bogus integer in a place where the actual
1141 value does not matter.
1142 (LIST_END_P): Remove unused macro and its bogus comment.
1143 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1145 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1146 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1148 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1149 We prefer signed types, and the value cannot exceed the EMACS_INT
1150 range anyway (because otherwise the length would not be representable).
1151 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1152 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1153 This avoids a GCC warning when WIDE_EMACS_INT.
1155 * indent.c (sane_tab_width): New function.
1156 (current_column, scan_for_column, Findent_to, position_indentation)
1157 (compute_motion): Use it. This is just for clarity.
1158 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1160 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1162 * lisp.h (lint_assume): New macro.
1163 * composite.c (composition_gstring_put_cache):
1164 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1166 * editfns.c, insdel.c:
1167 Omit unnecessary forward decls, to simplify future changes.
1169 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1171 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1173 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1174 Use much-faster test for byte-length change.
1175 Don't assume string byte-length fits in 'int'.
1176 Check that character arg fits in 'int'.
1177 (mapcar1): Declare byte as byte, for clarity.
1179 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1181 * fns.c (concat): Catch string overflow earlier.
1182 Do not rely on integer wraparound.
1184 * dispextern.h (struct it.overlay_strings_charpos)
1185 (struct it.selective): Now EMACS_INT, not int.
1186 * xdisp.c (forward_to_next_line_start)
1187 (back_to_previous_visible_line_start)
1188 (reseat_at_next_visible_line_start, next_element_from_buffer):
1189 Don't arbitrarily truncate the value of 'selective' to int.
1191 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1193 * composite.c: Don't truncate sizes to 'int'.
1194 (composition_gstring_p, composition_reseat_it)
1195 (composition_adjust_point): Use EMACS_INT, not int.
1196 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1197 not EMACS_UINT, for indexes.
1199 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1201 * buffer.c: Include <verify.h>.
1202 (struct sortvec.priority, struct sortstr.priority):
1203 Now EMACS_INT, not int.
1204 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1205 (struct sortstr.size, record_overlay_string)
1206 (struct sortstrlist.size, struct sortlist.used):
1207 Don't truncate size to int.
1208 (record_overlay_string): Check for size-calculation overflow.
1209 (init_buffer_once): Check at compile-time, not run-time.
1211 2011-06-22 Jim Meyering <meyering@redhat.com>
1213 Don't leak an XBM-image-sized buffer
1214 * image.c (xbm_load): Free the image buffer after using it.
1216 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1219 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1220 that Sun C diagnosed.
1221 * fns.c (secure_hash): Fix pointer signedness issue.
1222 * intervals.c (static_offset_intervals): New function.
1223 (offset_intervals): Use it.
1225 2011-06-21 Leo Liu <sdl.web@gmail.com>
1228 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1231 * fns.c (secure_hash): Rename from crypto_hash_function and change
1232 the first arg to accept symbols.
1233 (Fsecure_hash): New primitive.
1234 (syms_of_fns): New symbols.
1236 2011-06-20 Deniz Dogan <deniz@dogan.se>
1238 * process.c (Fset_process_buffer): Clarify return value in
1241 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1243 * dispnew.c (add_window_display_history): Use BVAR.
1245 * xdisp.c (debug_method_add): Use BVAR.
1246 (check_window_end, dump_glyph_matrix, dump_glyph)
1247 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1249 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1252 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1253 check till after the cache is created in init_frame_faces.
1255 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1257 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1259 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1261 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1262 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1263 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1265 Improve buffer-overflow checking (Bug#8873).
1266 * fileio.c (Finsert_file_contents):
1267 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1268 Remove the old (too-loose) buffer overflow checks.
1269 They weren't needed, since make_gap checks for buffer overflow.
1270 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1271 The old code merely checked for Emacs fixnum overflow, and relied
1272 on undefined (wraparound) behavior. The new code avoids undefined
1273 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1275 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1276 Tune. Don't use wider integers than needed. Don't use alloca.
1277 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1279 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1281 * insdel.c, lisp.h (buffer_overflow): New function.
1282 (insert_from_buffer_1, replace_range, replace_range_2):
1283 * insdel.c (make_gap_larger):
1284 * editfns.c (Finsert_char):
1285 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1287 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1289 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1291 Integer overflow and signedness fixes (Bug#8873).
1293 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1294 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1296 * fileio.c: Don't assume EMACS_INT fits in off_t.
1297 (emacs_lseek): New static function.
1298 (Finsert_file_contents, Fwrite_region): Use it.
1299 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1301 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1303 * fns.c: Don't overflow int when computing a list length.
1304 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1305 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1306 truncation on 64-bit hosts. Check for QUIT every
1307 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1308 faster and is responsive enough.
1309 (Flength): Report an error instead of overflowing an integer.
1310 (Fsafe_length): Return a float if the value is not representable
1311 as a fixnum. This shouldn't happen except in contrived situations.
1312 (Fnthcdr, Fsort): Don't assume list length fits in int.
1313 (Fcopy_sequence): Don't assume vector length fits in int.
1315 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1316 (header_size, word_size): New constants.
1317 (allocate_vectorlike): Don't check size overflow here.
1318 (allocate_vector): Check it here instead, since this is the only
1319 caller of allocate_vectorlike that could cause overflow.
1320 Check that the new vector's length is representable as a fixnum.
1322 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1323 The previous code was bogus. For example, next_almost_prime (32)
1324 returned 39, which is undesirable as it is a multiple of 3; and
1325 next_almost_prime (24) returned 25, which is a multiple of 5 so
1326 why was the code bothering to check for multiples of 7?
1328 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1330 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1332 Variadic C functions now count arguments with ptrdiff_t.
1333 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1334 Back then I didn't know that the Emacs coding style prefers signed int.
1335 Also, in the meantime I found a few more instances where arguments
1336 were being counted with int, which may truncate counts on 64-bit
1337 machines, or EMACS_INT, which may be unnecessarily wide.
1338 * lisp.h (struct Lisp_Subr.function.aMANY)
1339 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1340 Arg counts are now ptrdiff_t, not size_t.
1341 All variadic functions and their callers changed accordingly.
1342 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1343 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1344 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1345 * callint.c (Fcall_interactively): Check arg count for overflow,
1346 to avoid potential buffer overrun. Use signed char, not 'int',
1347 for 'varies' array, so that we needn't bother to check its size
1348 calculation for overflow.
1349 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1350 * eval.c (apply_lambda):
1351 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1352 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1353 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1355 * callint.c (Fcall_interactively): Don't use index var as event count.
1357 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1358 * mem-limits.h (SIZE): Remove; no longer used.
1360 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1362 Remove unnecessary casts.
1363 * xterm.c (x_term_init):
1364 * xfns.c (x_set_border_pixel):
1365 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1366 These aren't needed now that we assume ANSI C.
1368 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1369 It's more likely to cause problems (due to unsigned overflow)
1372 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1374 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1376 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1378 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1380 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1382 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1384 GLYPH_CODE_FACE returns EMACS_INT, not int.
1385 * dispextern.h (merge_faces):
1386 * xfaces.c (merge_faces):
1387 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1388 Don't assume EMACS_INT fits in int.
1390 * character.h (CHAR_VALID_P): Remove unused parameter.
1391 * fontset.c, lisp.h, xdisp.c: All uses changed.
1393 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1395 * fns.c (concat): Minor tuning based on overflow analysis.
1396 This doesn't fix any bugs. Use int to hold character, instead
1397 of constantly refetching from Emacs object. Use XFASTINT, not
1398 XINT, for value known to be a character. Don't bother comparing
1399 a single byte to 0400, as it's always less.
1401 * floatfns.c (Fexpt):
1402 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1404 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1407 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1409 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1410 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1411 incorrectly succeed when S was a string, because 4294967386 was
1412 truncated before it was used.
1414 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1415 Otherwise, an out-of-range integer could cause undefined behavior
1418 * composite.c: Use int, not EMACS_INT, for characters.
1419 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1420 EMACS_INT, for values that are known to be in character range.
1421 This doesn't fix any bugs but is the usual style inside Emacs and
1422 may generate better code on 32-bit machines.
1424 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1425 This is for reasons similar to the recent CHAR_STRING fix.
1426 * charset.c (Fencode_char): Check that character arg is actually
1427 a character. Pass an int to ENCODE_CHAR.
1428 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1429 wider than 'int', as a compile-time check to prevent future regressions
1432 * character.c (char_string): Remove unnecessary casts.
1434 Make sure a 64-bit char is never passed to CHAR_STRING.
1435 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1436 by silently ignoring the top 32 bits, allowing some values
1437 that were far too large to be valid characters.
1438 * character.h: Include <verify.h>.
1439 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1440 arguments are no wider than unsigned, as a compile-time check
1441 to prevent future regressions in this area.
1443 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1444 (Fsubst_char_in_region):
1446 * xdisp.c (decode_mode_spec_coding):
1447 Adjust to CHAR_STRING's new requirement.
1448 * editfns.c (Finsert_char, Fsubst_char_in_region):
1449 * fns.c (concat): Check that character args are actually
1450 characters. Without this test, these functions did the wrong
1451 thing with wildly out-of-range values on 64-bit hosts.
1453 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1454 These casts should not be needed on 32-bit hosts, either.
1455 * keyboard.c (read_char):
1456 * lread.c (Fload): Remove casts to unsigned.
1458 * lisp.h (UNSIGNED_CMP): New macro.
1459 This fixes comparison bugs on 64-bit hosts.
1460 (ASCII_CHAR_P): Use it.
1461 * casefiddle.c (casify_object):
1462 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1463 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1464 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1465 * dispextern.h (FACE_FROM_ID):
1466 * keyboard.c (read_char): Use UNSIGNED_CMP.
1468 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1469 not to EMACS_INT, to avoid GCC warning.
1471 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1473 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1474 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1475 isn't needed on 32-bit machines.
1477 * buffer.c (Fgenerate_new_buffer_name):
1478 Use EMACS_INT for count, not int.
1479 (advance_to_char_boundary): Return EMACS_INT, not int.
1481 * data.c (Qcompiled_function): Now static.
1483 * window.c (window_body_lines): Now static.
1485 * image.c (gif_load): Rename local to avoid shadowing.
1487 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1488 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1489 * alloc.c (make_save_value): Integer argument is now of type
1491 (mark_object): Use ptrdiff_t, not int.
1492 * lisp.h (pD): New macro.
1493 * print.c (print_object): Use it.
1495 * alloc.c: Use EMACS_INT, not int, to count objects.
1496 (total_conses, total_markers, total_symbols, total_vector_size)
1497 (total_free_conses, total_free_markers, total_free_symbols)
1498 (total_free_floats, total_floats, total_free_intervals)
1499 (total_intervals, total_strings, total_free_strings):
1500 Now EMACS_INT, not int. All uses changed.
1501 (Fgarbage_collect): Compute overall total using a double, so that
1502 integer overflow is less likely to be a problem. Check for overflow
1503 when converting back to an integer.
1504 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1505 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1506 These were 'int' variables that could overflow on 64-bit hosts;
1507 they were never used, so remove them instead of repairing them.
1508 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1509 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1510 Previously, this ceilinged at INT_MAX, but that doesn't work on
1512 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1514 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1515 (allocate_vectorlike): Check for ptrdiff_t overflow.
1516 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1517 when a (possibly-narrower) signed value would do just as well.
1518 We prefer using signed arithmetic, to avoid comparison confusion.
1520 * alloc.c: Catch some string size overflows that we were missing.
1521 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1522 for convenience in STRING_BYTES_MAX.
1523 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1524 The definition here is exact; the one in lisp.h was approximate.
1525 (allocate_string_data): Check for string overflow. This catches
1526 some instances we weren't catching before. Also, it catches
1527 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1528 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1529 and ptrdiff_t and EMACS_INT are both 64 bits.
1531 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1532 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1533 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1535 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1537 * alloc.c (Fmake_string): Check for out-of-range init.
1539 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1541 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1543 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1545 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1546 xg_get_default_scrollbar_width.
1548 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1549 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1550 (style_changed_cb): Call update_theme_scrollbar_width and call
1551 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1552 all frames (Bug#8505).
1553 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1554 Call gtk_window_set_resizable if HAVE_GTK3.
1555 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1556 and height if HAVE_GTK3 (Bug#8505).
1557 (scroll_bar_width_for_theme): New variable.
1558 (update_theme_scrollbar_width): New function.
1559 (xg_get_default_scrollbar_width): Move code to
1560 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1561 (xg_initialize): Call update_theme_scrollbar_width.
1563 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1565 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1567 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1569 * frame.c (make_frame): Call other_buffer_safely instead of
1572 * window.c (temp_output_buffer_show): Call display_buffer with
1573 second argument Vtemp_buffer_show_specifiers and reset latter
1574 immediately after the call.
1575 (Vtemp_buffer_show_specifiers): New variable.
1576 (auto_window_vscroll_p, next_screen_context_lines)
1577 (Vscroll_preserve_screen_position): Remove leading asterisks from
1580 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1582 Fix minor problems found by GCC 4.6.0 static checking.
1583 * buffer.c (Qclone_number): Remove for now, as it's unused.
1584 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1585 (record_buffer): Remove unused local.
1586 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1587 (set_frame_buffer_list): Remove; unused.
1588 * frame.h (other_visible_frames): Remove decl.
1589 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1590 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1591 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1593 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1594 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1595 Define only if HAVE_GPM.
1596 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1597 (update_hints_inhibit): Remove; never set. All uses removed.
1598 * widgetprv.h (emacsFrameClassRec): Remove decl.
1599 * window.c (delete_deletable_window): Now returns void, since it
1600 wasn't returning anything.
1601 (compare_window_configurations): Remove unused locals.
1602 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1603 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1604 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1605 the same widths as pointers. This follows up on the 2011-05-06 patch.
1606 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1607 * xterm.h: Likewise.
1608 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1610 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1612 * makefile.w32-in: Update dependencies.
1613 (LISP_H): Add lib/intprops.h.
1615 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1617 * image.c (gif_load): Add animation frame delay to the metadata.
1618 (syms_of_image): Use DEFSYM. New symbol `delay'.
1620 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1622 * window.c (delete_deletable_window): Re-add.
1623 (Fset_window_configuration): Rewrite to handle dead buffers and
1624 consequently deletable windows.
1625 (window_tree, Fwindow_tree): Remove. Supply functionality in
1627 (compare_window_configurations): Simplify code.
1629 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1631 * image.c (imagemagick_load_image): Fix type mismatch.
1632 (Fimagemagick_types): Likewise.
1634 * window.h (replace_buffer_in_windows): Declare.
1636 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1638 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1639 Qclone_number. Remove external declaration of Qdelete_window.
1640 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1642 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1643 Qbuffer_list_update_hook if allowed.
1644 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1645 buffer list implementation.
1646 (other_buffer_safely): New function.
1647 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1648 calls to replace_buffer_in_windows and
1649 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1651 (record_buffer): Inhibit quitting and rewrite using quittable
1652 functions. Run Qbuffer_list_update_hook if allowed.
1653 (Frecord_buffer, Funrecord_buffer): New functions.
1654 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1655 switch-to-buffer to window.el.
1656 (bury-buffer): Move to window.el.
1657 (Vbuffer_list_update_hook): New variable.
1659 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1662 * window.h (resize_frame_windows): Move up in code.
1663 (Fwindow_frame): Remove EXFUN.
1664 (replace_buffer_in_all_windows): Remove prototype.
1665 (replace_buffer_in_windows_safely): Add prototype.
1667 * window.c: Declare Qdelete_window static again. Move down
1668 declaration of select_count.
1669 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1670 (Fother_window): Move to window.el.
1671 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1672 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1673 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1675 (replace_buffer_in_windows): Implement by calling
1676 Qreplace_buffer_in_windows.
1677 (replace_buffer_in_all_windows): Remove with some functionality
1678 moved into replace_buffer_in_windows_safely.
1679 (replace_buffer_in_windows_safely): New function.
1680 (select_window_norecord, select_frame_norecord): Move in front
1681 of run_window_configuration_change_hook. Remove now obsolete
1683 (Fset_window_buffer): Rewrite doc-string. Call
1684 Qrecord_window_buffer.
1685 (keys_of_window): Move binding for other-window to window.el.
1687 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1689 * dispextern.h (struct image): Replace data member, whose int_val
1690 and ptr_val fields were not used by anything, with a single
1693 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1694 (gif_clear_image, gif_load, imagemagick_load_image)
1695 (gs_clear_image, gs_load): Callers changed.
1697 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1699 * buffer.h: Include <time.h>, for time_t.
1700 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1702 Fix minor problems found by static checking.
1704 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1706 Make identifiers static if they are not used in other modules.
1707 * data.c (Qcompiled_function, Qframe, Qvector):
1708 * image.c (QimageMagick, Qsvg):
1709 * minibuf.c (Qmetadata):
1710 * window.c (resize_window_check, resize_root_window): Now static.
1711 * window.h (resize_window_check, resize_root_window): Remove decls.
1713 * window.c (window_deletion_count, delete_deletable_window):
1715 (window_body_lines): Now static.
1716 (Fdelete_other_windows_internal): Mark vars as initialized.
1717 Make sure 'resize_failed' is initialized.
1718 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1719 (resize_window_apply): Remove unused local.
1720 * window.h (delete_deletable_window): Remove decl.
1722 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1723 (imagemagick_load_image): Fix pointer signedness problem by changing
1724 last arg from unsigned char * to char *. All uses changed.
1725 Also, fix a local for similar reasons.
1726 Remove unused locals. Remove locals to avoid shadowing.
1727 (fn_rsvg_handle_free): Remove; unused.
1728 (svg_load, svg_load_image): Fix pointer signedness problem.
1729 (imagemagick_load_image): Don't use garbage pointer image_wand.
1731 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1733 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1735 * image.c (gif_load): Fix omitted cast error introduced by
1738 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1740 * window.h (resize_proportionally, orig_total_lines)
1741 (orig_top_line): Remove from window structure.
1742 (set_window_height, set_window_width, change_window_heights)
1743 (Fdelete_window): Remove prototypes.
1744 (resize_frame_windows): Remove duplicate declaration.
1746 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1748 * window.h (resize_frame_windows, resize_window_check)
1749 (delete_deletable_window, resize_root_window)
1750 (resize_frame_windows): Declare prototypes.
1752 * window.c (resize_window_apply): Make definition be "static" to
1753 match the prototype.
1755 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1757 * window.c: Remove declarations of Qwindow_size_fixed,
1758 window_min_size_1, window_min_size_2, window_min_size,
1759 size_window, window_fixed_size_p, enlarge_window, delete_window.
1760 Remove static from declaration of Qdelete_window, it's
1761 temporarily needed by Fbury_buffer.
1762 (replace_window): Don't assign orig_top_line and
1764 (Fdelete_window, delete_window): Remove. Window deletion is
1765 handled by window.el.
1766 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1767 Fdelete_window calls with calls to Qdelete_window.
1768 (Fdelete_other_windows): Remove. Deleting other windows is
1769 handled by window.el.
1770 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1771 handled in window.el.
1772 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1773 Window minimum sizes are handled in window.el.
1774 (shrink_windows, size_window, set_window_height)
1775 (set_window_width, change_window_heights, window_height)
1776 (window_width, CURBEG, CURSIZE, enlarge_window)
1777 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1778 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1779 handled in window.el.
1780 (make_dummy_parent): Rename to make_parent_window and give it a
1781 second argument horflag.
1782 (make_window): Don't set resize_proportionally any more.
1783 (Fsplit_window): Remove. Windows are split in window.el.
1784 (save_restore_action, save_restore_orig_size)
1785 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1786 Resize mini windows in window.el.
1787 (grow_mini_window, shrink_mini_window): Implement by calling
1788 Qresize_root_window_vertically, resize_window_check and
1789 resize_window_apply.
1790 (saved_window, Fset_window_configuration, save_window_save): Do
1791 not handle orig_top_line, orig_total_lines, and
1792 resize_proportionally.
1793 (window_min_height, window_min_width): Move to window.el.
1794 (keys_of_window): Move bindings for delete-other-windows,
1795 split-window, delete-window and enlarge-window to window.el.
1797 * buffer.c: Temporarily extern Qdelete_window.
1798 (Fbury_buffer): Temporarily call Qdelete_window instead of
1799 Fdelete_window (Fbury_buffer will move to window.el soon).
1801 * frame.c (set_menu_bar_lines_1): Remove code handling
1802 orig_top_line and orig_total_lines.
1804 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1805 set_window_height but set heights directly.
1806 (change_frame_size_1): Use resize_frame_windows.
1808 * xdisp.c (init_xdisp): Don't use set_window_height but set
1811 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1812 resize_frame_windows instead of change_window_heights and run
1813 run_window_configuration_change_hook.
1815 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1816 instead of change_window_heights and run
1817 run_window_configuration_change_hook.
1819 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1821 * window.c (replace_window): Rename second argument REPLACEMENT to
1822 NEW. New third argument SETFLAG. Rewrite.
1823 (delete_window, make_dummy_parent): Call replace_window with
1825 (window_list_1): Move down in code.
1826 (run_window_configuration_change_hook): Move set_buffer part
1827 before select_frame_norecord part in order to unwind correctly.
1828 Rename count1 to count.
1829 (recombine_windows, delete_deletable_window, resize_root_window)
1830 (Fdelete_other_windows_internal)
1831 (Frun_window_configuration_change_hook, make_parent_window)
1832 (resize_window_check, resize_window_apply, Fresize_window_apply)
1833 (resize_frame_windows, Fsplit_window_internal)
1834 (Fdelete_window_internal, Fresize_mini_window_internal): New
1836 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1838 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1840 * window.h (window): Add some new members to window structure -
1841 normal_lines, normal_cols, new_total, new_normal, clone_number,
1842 splits, nest, prev_buffers, next_buffers.
1843 (WINDOW_TOTAL_SIZE): Move here from window.c.
1844 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1846 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1848 (make_dummy_parent): Set new members of windows structure.
1849 (make_window): Move down in code. Handle new members of window
1851 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1852 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1853 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1854 (Fset_window_prev_buffers, Fwindow_next_buffers)
1855 (Fset_window_next_buffers, Fset_window_clone_number): New
1857 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1858 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1860 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1861 Argument WINDOW can be now internal window too.
1862 (Fwindow_use_time): Move up in code.
1863 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1865 (Fset_window_configuration, saved_window)
1866 (Fcurrent_window_configuration, save_window_save): Handle new
1867 members of window structure.
1868 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1869 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1870 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1871 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1872 Qget_mru_window, Qresize_root_window,
1873 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1874 Qauto_buffer_name; staticpro them.
1876 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1878 * window.c (Fwindow_total_size, Fwindow_left_column)
1879 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1880 (Fwindow_list_1): New functions.
1881 (window_box_text_cols): Replace with window_body_cols.
1882 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1883 window_body_cols instead of window_box_text_cols.
1884 (delete_window, Fset_window_configuration): Call
1885 delete_all_subwindows with window as argument.
1886 (delete_all_subwindows): Take a window as argument and not a
1888 (window_loop): Remove handling of GET_LRU_WINDOW and
1890 (Fget_lru_window, Fget_largest_window): Move to window.el.
1892 * window.h: Extern window_body_cols instead of
1893 window_box_text_cols. delete_all_subwindows now takes a
1894 Lisp_Object as argument.
1896 * indent.c (compute_motion, Fcompute_motion): Use
1897 window_body_cols instead of window_box_text_cols.
1899 * frame.c (delete_frame): Call delete_all_subwindows with root
1902 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1904 * fns.c (Fputhash): Document return value.
1906 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1908 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1910 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1912 Cons<->int and similar integer overflow fixes (Bug#8794).
1914 Check for overflow when converting integer to cons and back.
1915 * charset.c (Fdefine_charset_internal, Fdecode_char):
1916 Use cons_to_unsigned to catch overflow.
1917 (Fencode_char): Use INTEGER_TO_CONS.
1918 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1919 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1920 * data.c (long_to_cons, cons_to_long): Remove.
1921 (cons_to_unsigned, cons_to_signed): New functions.
1922 These signal an error for invalid or out-of-range values.
1923 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1924 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1925 * font.c (Ffont_variation_glyphs):
1926 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1927 * lisp.h: Include <intprops.h>.
1928 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1929 (cons_to_signed, cons_to_unsigned): New decls.
1930 (long_to_cons, cons_to_long): Remove decls.
1931 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1932 (Fprimitive_undo): Use CONS_TO_INTEGER.
1933 * xfns.c (Fx_window_property): Likewise.
1934 * xselect.c: Include <limits.h>.
1935 (x_own_selection, selection_data_to_lisp_data):
1936 Use INTEGER_TO_CONS.
1937 (x_handle_selection_request, x_handle_selection_clear)
1938 (x_get_foreign_selection, Fx_disown_selection_internal)
1939 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1940 (lisp_data_to_selection_data): Use cons_to_unsigned.
1941 (x_fill_property_data): Use cons_to_signed.
1942 Report values out of range.
1944 Check for buffer and string overflow more precisely.
1945 * buffer.h (BUF_BYTES_MAX): New macro.
1946 * lisp.h (STRING_BYTES_MAX): New macro.
1947 * alloc.c (Fmake_string):
1948 * character.c (string_escape_byte8):
1949 * coding.c (coding_alloc_by_realloc):
1950 * doprnt.c (doprnt):
1951 * editfns.c (Fformat):
1953 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1954 since they may not be the same number.
1955 * editfns.c (Finsert_char):
1956 * fileio.c (Finsert_file_contents):
1957 Likewise for BUF_BYTES_MAX.
1959 * image.c: Use ptrdiff_t, not int, for sizes.
1960 (slurp_file): Switch from int to ptrdiff_t.
1962 (slurp_file): Check that file size fits in both size_t (for
1963 malloc) and ptrdiff_t (for sanity and safety).
1965 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1966 if b->modtime has its maximal value.
1968 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1970 Don't assume time_t can fit into int.
1971 * buffer.h (struct buffer.modtime): Now time_t, not int.
1972 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1973 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1975 Minor fixes for signed vs unsigned integers.
1976 * character.h (MAYBE_UNIFY_CHAR):
1977 * charset.c (maybe_unify_char):
1978 * keyboard.c (read_char, reorder_modifiers):
1979 XINT -> XFASTINT, since the integer must be nonnegative.
1980 * ftfont.c (ftfont_spec_pattern):
1981 * keymap.c (access_keymap, silly_event_symbol_error):
1982 XUINT -> XFASTINT, since the integer must be nonnegative.
1983 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1984 since it makes no difference and we prefer signed.
1985 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1986 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1989 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1991 * window.h (Fwindow_frame): Declare.
1993 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1995 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1996 (SPARE_MEMORY): Always define.
1997 (LARGE_REQUEST): Remove.
1998 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2000 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2002 * lisp.h: Move EXFUNS for Fframe_root_window,
2003 Fframe_first_window and Fset_frame_selected_window to window.h.
2005 * window.h: Move EXFUNS for Fframe_root_window,
2006 Fframe_first_window and Fset_frame_selected_window here from
2009 * frame.c (Fwindow_frame, Fframe_first_window)
2010 (Fframe_root_window, Fframe_selected_window)
2011 (Fset_frame_selected_window): Move to window.c.
2012 (Factive_minibuffer_window): Move to minibuf.c.
2013 (Fother_visible_frames_p): New function.
2015 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2017 * window.c (decode_window, decode_any_window): Move up in code.
2018 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2019 (inhibit_frame_unsplittable): Remove unused variable.
2020 (Fwindow_buffer): Move up and rewrite doc-string.
2021 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2022 (Fwindow_prev): New functions.
2023 (Fwindow_frame): Move here from frame.c. Accept any window as
2025 (Fframe_root_window, Fframe_first_window)
2026 (Fframe_selected_window): Move here from frame.c. Accept frame
2027 or arbitrary window as argument. Update doc-strings.
2028 (Fminibuffer_window): Move up in code.
2029 (Fwindow_minibuffer_p): Move up in code and simplify.
2030 (Fset_frame_selected_window): Move here from frame.c.
2032 (Fselected_window, select_window, Fselect_window): Move up in
2033 code. Minor doc-string fixes.
2035 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2037 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2038 Do not assume that spare memory exists; that assumption is valid
2039 only if SYSTEM_MALLOC.
2040 (LARGE_REQUEST): New macro, so that the issue of large requests
2041 is separated from the issue of spare memory.
2043 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2045 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2048 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2050 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2053 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2055 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2057 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2059 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2060 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2062 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2064 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2066 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2068 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2069 (x_clipboard_manager_save): Add return value.
2070 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2072 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2073 Obey Vx_select_enable_clipboard_manager. Catch errors in
2074 x_clipboard_manager_save (Bug#8779).
2075 (Vx_select_enable_clipboard_manager): New variable.
2076 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2078 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2080 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2082 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2084 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2085 in the current matrix if keep_current_p is non-zero.
2087 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2089 * bidi.c (bidi_level_of_next_char): Fix last change.
2091 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2093 Support bidi reordering of text covered by display properties.
2095 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2096 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2097 (bidi_cache_search, bidi_cache_iterator_state)
2098 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2099 (bidi_level_of_next_char, bidi_move_to_visually_next):
2100 Support character positions inside a run of characters covered by a
2102 (bidi_paragraph_init, bidi_resolve_explicit_1)
2103 (bidi_level_of_next_char): Call bidi_fetch_char and
2104 bidi_fetch_char_advance instead of FETCH_CHAR and
2106 (bidi_init_it): Initialize new members.
2107 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2109 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2110 instead of using explicit *_CHAR codes.
2111 (bidi_resolve_explicit, bidi_resolve_weak):
2112 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2113 bidirectional text is supported only in multibyte buffers.
2114 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2115 it to initialize the frame_window_p member of struct bidi_it.
2116 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2117 (bidi_resolve_explicit, bidi_resolve_weak)
2118 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2119 bidi_it->nchars is non-positive.
2120 (bidi_level_of_next_char): Don't try to lookup the cache for the
2121 next/previous character if nothing is cached there yet, or if we
2122 were just reseat()'ed to a new position.
2124 * xdisp.c (set_cursor_from_row): Set start and stop points
2125 according to the row's direction when priming the loop that looks
2126 for the glyph on which to display cursor.
2127 (single_display_spec_intangible_p): Function deleted.
2128 (display_prop_intangible_p): Reimplement to call
2129 handle_display_spec instead of single_display_spec_intangible_p.
2130 Accept 3 additional arguments needed by handle_display_spec.
2131 This fixes incorrect cursor motion across display property with complex
2132 values: lists, `(when COND...)' forms, etc.
2133 (single_display_spec_string_p): Support property values that are
2134 lists with the argument STRING its top-level element.
2135 (display_prop_string_p): Fix the condition for processing a
2136 property that is a list to be consistent with handle_display_spec.
2137 (handle_display_spec): New function, refactored from the
2138 last portion of handle_display_prop.
2139 (compute_display_string_pos): Accept additional argument
2140 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2141 value of a `display' property is a "replacing spec".
2142 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2143 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2144 the display property, but just return a value indicating whether
2145 the display property will replace the characters it covers.
2146 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2147 frame_window_p members of struct bidi_it.
2148 (compute_display_string_pos, compute_display_string_end):
2150 (push_it): Accept second argument POSITION, where pop_it should
2151 jump to continue iteration.
2152 (reseat_1): Initialize bidi_it.disp_pos.
2154 * keyboard.c (adjust_point_for_property): Adjust the call to
2155 display_prop_intangible_p to its new signature.
2157 * dispextern.h (struct bidi_it): New member frame_window_p.
2158 (bidi_init_it): Update prototypes.
2159 (display_prop_intangible_p): Update prototype.
2160 (compute_display_string_pos, compute_display_string_end):
2162 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2165 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2167 Malloc failure behavior now depends on size of allocation.
2168 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2169 * lisp.h: Change signatures accordingly.
2170 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2171 All callers changed. (Bug#8762)
2173 * gnutls.c: Use Emacs's memory allocators.
2174 Without this change, the gnutls library would invoke malloc etc.
2175 directly, which causes problems on non-SYNC_INPUT hosts, and which
2176 runs afoul of improving memory_full behavior. (Bug#8761)
2177 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2178 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2179 xfree instead of the default malloc, realloc, free.
2180 (Fgnutls_boot): No need to check for memory allocation failure,
2181 since xmalloc does that for us.
2183 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2184 * category.c (hash_get_category_set):
2185 * ccl.c (ccl_driver):
2186 * charset.c (Fdefine_charset_internal):
2187 * charset.h (struct charset.hash_index):
2188 * composite.c (get_composition_id, gstring_lookup_cache)
2189 (composition_gstring_put_cache):
2190 * composite.h (struct composition.hash_index):
2191 * dispextern.h (struct image.hash):
2192 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2193 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2194 (hashfn_equal, hashfn_user_defined, make_hash_table)
2195 (maybe_resize_hash_table, hash_lookup, hash_put)
2196 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2197 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2198 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2199 * image.c (make_image, search_image_cache, lookup_image)
2200 (xpm_put_color_table_h):
2201 * lisp.h (struct Lisp_Hash_Table):
2202 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2203 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2204 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2205 * alloc.c (allocate_vectorlike):
2206 Check for overflow in vector size calculations.
2207 * ccl.c (ccl_driver):
2208 Check for overflow when converting EMACS_INT to int.
2209 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2210 need to be updated by these changes.
2211 * fns.c (make_hash_table, maybe_resize_hash_table):
2212 Check for integer overflow with large hash tables.
2213 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2214 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2215 (SXHASH_REDUCE): New macro.
2216 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2217 Use it instead of discarding useful hash info with large hash values.
2218 (sxhash_float): New function.
2219 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2220 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2221 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2222 Rewrite to use FIXNUM_BITS, as this simplifies things.
2223 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2224 Adjust signatures to match updated version of code.
2225 (consing_since_gc): Now EMACS_INT, since a single hash table can
2226 use more than INT_MAX bytes.
2228 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2230 Make it possible to build with GCC-4.6+ -O2 -flto.
2232 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2234 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2236 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2237 Call minibuffer-inactive-mode.
2239 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2241 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2242 Update dependencies.
2244 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2246 * data.c (init_data): Remove code for UTS, this system is not
2249 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2251 Don't force ./temacs to start in terminal mode.
2253 * frame.c (make_initial_frame): Initialize faces in all cases, not
2254 only when CANNOT_DUMP is defined.
2255 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2257 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2259 * dispnew.c (add_window_display_history): Use const for the string
2260 pointer. Remove declaration, not needed.
2262 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2264 Use 'inline', not 'INLINE'.
2265 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2266 * alloc.c, fontset.c (INLINE): Remove.
2267 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2268 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2269 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2270 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2271 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2273 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2275 Make it possible to run ./temacs.
2277 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2278 syms_of_callproc does the same thing. Remove test for
2279 "initialized", do it in the caller.
2280 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2282 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2284 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2285 (read_minibuf): Use get_minibuffer.
2286 (syms_of_minibuf): Use DEFSYM.
2287 (Qmetadata): New var.
2288 * data.c (Qbuffer): Don't make it static.
2289 (syms_of_data): Use DEFSYM.
2291 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2293 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2294 (CCL_CODE_MIN): New macro.
2296 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2298 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2300 * eval.c (Qdebug): Now static.
2301 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2302 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2303 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2305 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2307 * image.c: Various fixes to ImageMagick code comments.
2308 (Fimagemagick_types): Doc fix.
2310 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2312 Minor fixes prompted by GCC 4.6.0 warnings.
2314 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2316 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2317 (x_clipboard_manager_save_all): Move extern decl to ...
2318 * xterm.h: ... here, so that it can be checked for consistency.
2320 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2322 * xselect.c (x_clipboard_manager_save_frame)
2323 (x_clipboard_manager_save_all): New functions.
2324 (Fx_clipboard_manager_save): Lisp function deleted.
2326 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2327 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2329 * xterm.h: Update prototype.
2331 2011-05-28 William Xu <william.xwl@gmail.com>
2333 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2336 2011-05-28 Jim Meyering <meyering@redhat.com>
2338 Avoid a sign-extension bug in crypto_hash_function.
2339 * fns.c (to_uchar): Define.
2340 (crypto_hash_function): Use it to convert some newly-signed
2341 variables to unsigned, to avoid sign-extension bugs. For example,
2342 without this change, (md5 "truc") would evaluate to
2343 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2344 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2345 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2347 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2349 Integer overflow fixes.
2351 * dbusbind.c: Serial number integer overflow fixes.
2352 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2353 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2354 to hold a serial number that is too large for a fixnum.
2355 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2356 Check for serial numbers out of range. Decode any serial number
2357 that was so large that it became a float. (Bug#8722)
2359 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2360 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2361 Use XFASTINT rather than XUINT when numbers are nonnegative.
2362 (xd_append_arg, Fdbus_method_return_internal):
2363 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2364 arguments, check that Lisp number is nonnegative, rather than
2365 silently wrapping negative numbers around. (Bug#8722)
2366 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2369 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2371 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2373 ccl: add integer overflow checks
2374 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2375 (IN_INT_RANGE): New macros.
2376 (ccl_driver): Use them to check for integer overflow when
2377 decoding a CCL program. Many of the new checks are whether XINT (x)
2378 fits in int; it doesn't always, on 64-bit hosts. The new version
2379 doesn't catch all possible integer overflows, but it's an
2380 improvement. (Bug#8719)
2382 * alloc.c (make_event_array): Use XINT, not XUINT.
2383 There's no need for unsigned here.
2385 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2386 This follows up to the 2011-05-06 change that substituted uintptr_t
2387 for EMACS_INT. This case wasn't caught back then.
2389 Rework Fformat to avoid integer overflow issues.
2390 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2391 now (part of C89). Include <verify.h>.
2392 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2393 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2394 (Fformat): Avoid the prepass trying to compute sizes; it was only
2395 approximate and thus did not catch overflow reliably. Instead, walk
2396 through the format just once, formatting and computing sizes as we go,
2397 checking for integer overflow at every step, and allocating a larger
2398 buffer as needed. Keep track separately whether the format is
2399 multibyte. Keep only the most-recently calculated precision, rather
2400 than them all. Record whether each argument has been converted to
2401 string. Use EMACS_INT, not int, for byte and char and arg counts.
2402 Support field widths and precisions larger than INT_MAX. Avoid
2403 sprintf's undefined behavior with conversion specifications such as %#d
2404 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2405 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2406 formatting out-of-range floating point numbers with int
2409 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2411 * data.c: Avoid integer truncation in expressions involving floats.
2412 * data.c: Include <intprops.h>.
2413 (arith_driver): When there's an integer overflow in an expression
2414 involving floating point, convert the integers to floating point
2415 so that the resulting value does not suffer from catastrophic
2416 integer truncation. For example, on a 64-bit host (* 4
2417 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2418 Do not rely on undefined behavior after integer overflow.
2420 merge count_size_as_multibyte, parse_str_to_multibyte
2421 * character.c, character.h (count_size_as_multibyte):
2422 Rename from parse_str_to_multibyte; all uses changed.
2423 Check for integer overflow.
2424 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2425 since it's now a duplicate of the other. This is more of
2426 a character than a buffer op, so better that it's in character.c.
2427 * fns.c, print.c: Adjust to above changes.
2429 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2431 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2433 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2435 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2436 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2437 (x_clipboard_manager_save): Now static.
2438 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2440 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2441 (crypto_hash_function): Now static.
2442 Fix pointer signedness problems. Avoid unnecessary initializations.
2444 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2446 * termhooks.h (Vselection_alist): Make it terminal-local.
2448 * terminal.c (create_terminal): Initialize it.
2450 * xselect.c: Support for clipboard managers.
2451 (Vselection_alist): Move to termhooks.h as terminal-local var.
2452 (LOCAL_SELECTION): New macro.
2453 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2454 (symbol_to_x_atom): Remove gratuitous arg.
2455 (x_handle_selection_request, lisp_data_to_selection_data)
2456 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2457 (x_own_selection, x_get_local_selection, x_convert_selection):
2458 New arg, specifying work frame. Use terminal-local Vselection_alist.
2459 (some_frame_on_display): Delete unused function.
2460 (Fx_own_selection_internal, Fx_get_selection_internal)
2461 (Fx_disown_selection_internal, Fx_selection_owner_p)
2462 (Fx_selection_exists_p): New optional frame arg.
2463 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2464 (x_handle_selection_clear): Don't treat other terminals with the
2465 same keyboard specially. Use the terminal-local Vselection_alist.
2466 (x_clear_frame_selections): Use Frun_hook_with_args.
2468 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2470 * xterm.h: Add support for those atoms.
2472 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2474 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2475 (converted_selections, conversion_fail_tag): New global variables.
2476 (x_selection_request_lisp_error): Free the above.
2477 (x_get_local_selection): Remove unnecessary code.
2478 (x_reply_selection_request): Args changed; handle arbitrary array
2479 of converted selections stored in converted_selections.
2480 Separate the XChangeProperty and SelectionNotify steps.
2481 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2482 (x_convert_selection): New function.
2483 (x_handle_selection_event): Simplify.
2484 (x_get_foreign_selection): Don't ignore incoming requests while
2485 waiting for an answer; this will fail when we implement
2486 SAVE_TARGETS, and seems unnecessary anyway.
2487 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2488 (Vx_sent_selection_functions): Doc fix.
2490 2011-05-26 Leo Liu <sdl.web@gmail.com>
2492 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2494 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2496 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2498 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2499 for fringe update if it has periodic bitmap.
2500 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2501 and fringe_bitmap_periodic_p.
2503 * fringe.c (get_fringe_bitmap_data): New function.
2504 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2505 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2506 row. Mark glyph row for fringe update if periodicity changed.
2508 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2509 for fringe update unless it has periodic bitmap.
2511 2011-05-25 Kenichi Handa <handa@m17n.org>
2513 * xdisp.c (get_next_display_element): Set correct it->face_id for
2514 a static composition.
2516 2011-05-24 Leo Liu <sdl.web@gmail.com>
2519 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2521 * fns.c (crypto_hash_function, Fsha1): New function.
2522 (Fmd5): Use crypto_hash_function.
2523 (syms_of_fns): Add Ssha1.
2525 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2527 * gnutls.c: Remove unused macros.
2528 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2529 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2530 Remove macros that are defined and never used.
2531 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2533 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2535 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2536 (Fx_get_selection_internal): Minor cleanup.
2537 (Fx_own_selection_internal): Rename arguments for consistency with
2540 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2542 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2544 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2546 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2548 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2550 * dispnew.c (scrolling_window): Don't exclude the case that the
2551 last enabled row in the desired matrix touches the bottom boundary.
2553 2011-05-21 Glenn Morris <rgm@gnu.org>
2555 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2556 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2557 and add some more files.
2559 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2561 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2562 report_file_error introduced by the change from 2011-05-07.
2564 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2566 * systime.h (Time): Define only if emacs is defined.
2567 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2568 where the include path doesn't have X11/X.h by default. See
2569 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2571 2011-05-20 Kenichi Handa <handa@m17n.org>
2573 * composite.c (find_automatic_composition): Fix previous change.
2575 2011-05-20 Glenn Morris <rgm@gnu.org>
2577 * lisp.mk: New file, split from Makefile.in.
2578 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2579 (shortlisp): Remove.
2580 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2582 2011-05-19 Glenn Morris <rgm@gnu.org>
2584 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2585 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2586 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2587 (lisp): Set the order to that of loadup.el.
2588 (shortlisp): Make it a copy of $lisp.
2589 (SOME_MACHINE_LISP): Remove.
2590 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2591 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2593 2011-05-18 Kenichi Handa <handa@m17n.org>
2595 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2596 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2597 (find_automatic_composition): Mostly rewrite for efficiency.
2599 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2601 * makefile.w32-in: Update dependencies.
2603 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2605 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2606 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2608 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2610 Fix some integer overflow issues, such as string length overflow.
2612 * insdel.c (count_size_as_multibyte): Check for string overflow.
2614 * character.c (lisp_string_width): Check for string overflow.
2615 Use EMACS_INT, not int, for string indexes and lengths; in
2616 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2617 the resulting string length overflows an EMACS_INT; instead,
2618 report a string overflow if no precision given. When checking for
2619 precision exhaustion, use a check that cannot possibly have
2620 integer overflow. (Bug#8675)
2621 * character.h (lisp_string_width): Adjust to new signature.
2623 * alloc.c (string_overflow): New function.
2624 (Fmake_string): Use it. This doesn't change behavior, but saves
2625 a few bytes and will simplify future changes.
2626 * character.c (string_escape_byte8): Likewise.
2627 * lisp.h (string_overflow): New decl.
2629 Fixups, following up to the user-interface timestamp change.
2630 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2631 for UI timestamps, instead of unsigned long.
2632 * msdos.c (mouse_get_pos): Likewise.
2633 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2634 * w32gui.h (Time): Define by including "systime.h" rather than by
2635 declaring it ourselves. (Bug#8664)
2637 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2638 * image.c (clear_image_cache): Likewise.
2640 * term.c (term_mouse_position): Don't assume time_t wraparound.
2642 Be more systematic about user-interface timestamps.
2643 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2644 and sometimes 'EMACS_UINT', to represent these timestamps.
2645 This change causes it to use 'Time' uniformly, as that's what X uses.
2646 This makes the code easier to follow, and makes it easier to catch
2647 integer overflow bugs such as Bug#8664.
2648 * frame.c (Fmouse_position, Fmouse_pixel_position):
2649 Use Time, not unsigned long, for user-interface timestamps.
2650 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2651 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2652 * keyboard.h (last_event_timestamp): Likewise.
2653 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2654 * menu.h (xmenu_show): Likewise.
2655 * term.c (term_mouse_position): Likewise.
2656 * termhooks.h (struct input_event.timestamp): Likewise.
2657 (struct terminal.mouse_position_hook): Likewise.
2658 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2659 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2660 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2661 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2663 * menu.h, termhooks.h: Include "systime.h", for Time.
2665 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2666 Don't assume that the difference between two unsigned long values
2667 can fit into an integer. At this point, we know button_down_time
2668 <= event->timestamp, so the difference must be nonnegative, so
2669 there's no need to cast the result if double-click-time is
2670 nonnegative, as it should be; check that it's nonnegative, just in
2671 case. This bug is triggered when events are more than 2**31 ms
2672 apart (about 25 days). (Bug#8664)
2674 * xselect.c (last_event_timestamp): Remove duplicate decl.
2675 (x_own_selection): Remove needless cast to unsigned long.
2677 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2678 that always fit in int. Use a sentinel instead of a counter, to
2679 avoid a temp and to allay GCC's concerns about possible int overflow.
2680 * frame.h (struct frame): Use int for menu_bar_items_used
2681 instead of EMACS_INT, since it always fits in int.
2683 * menu.c (grow_menu_items): Check for int overflow.
2685 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2687 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2688 Before, the code was not consistent. These values cannot exceed
2689 2**31 - 1 so there's no need to make them unsigned.
2690 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2691 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2692 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2694 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2696 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2697 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2698 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2699 presumably because the widths might not match.
2701 * window.c (size_window): Avoid needless test at loop start.
2703 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2705 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2707 2011-05-12 Drew Adams <drew.adams@oracle.com>
2709 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2711 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2713 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2714 `width' to `bar_area_x' and `bar_area_width', respectively.
2715 (x_scroll_run): Take account of fringe background extension.
2717 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2718 Rename local vars `left' and `width' to `bar_area_x' and
2719 `bar_area_width', respectively.
2720 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2721 background extension.
2723 2011-05-10 Jim Meyering <meyering@redhat.com>
2725 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2727 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2729 * image.c (Finit_image_library): Return t for built-in image types,
2730 like pbm and xbm. (Bug#8640)
2732 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2734 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2736 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2738 * w32console.c (Fset_screen_color): Doc fix.
2739 (Fget_screen_color): New function.
2740 (syms_of_ntterm): Defsubr it.
2742 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2743 unlink the temporary file if Fcall_process didn't create it in the
2745 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2746 child process will be redirected to a file specified with `:file'.
2747 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2748 cue to call_process_cleanup not to close that handle.
2750 2011-05-07 Ben Key <bkey76@gmail.com>
2752 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2753 one of two shell specific rules, either bootstrap-temacs-CMD or
2754 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2755 to the previous implementation of the bootstrap-temacs rule.
2756 The bootstrap-temacs-CMD rule is similar to the previous
2757 implementation of the bootstrap-temacs rule except that it
2758 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2761 These changes, along with some changes to nt/configure.bat,
2762 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2763 earlier fix to add support for --cflags and --ldflags options
2764 that include quotes so that it works whether make uses cmd or
2767 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2769 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2770 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2772 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2773 a string. Handle both cases.
2774 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2775 (Fdbus_register_method): Use Qinvalid_function.
2777 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2779 * makefile.w32-in: Update dependencies.
2780 (LISP_H): Add inttypes.h and stdin.h.
2781 (PROCESS_H): Add unistd.h.
2783 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2785 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2786 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2788 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2790 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2792 * term.c (vfatal): Remove stray call to va_end.
2793 It's not needed and the C Standard doesn't allow it here anyway.
2795 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2796 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2798 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2801 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2803 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2805 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2807 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2809 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2811 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2812 * charset.c (Fdefine_charset_internal): Don't initialize
2813 charset.code_space[15]. The value was garbage, on hosts with
2814 32-bit int (Bug#8600).
2816 * lread.c (read_integer): Be more consistent with string-to-number.
2817 Use string_to_number to do the actual conversion; this avoids
2818 rounding errors and fixes some other screwups. Without this fix,
2819 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2820 (digit_to_number): Move earlier, for benefit of read_integer.
2821 Return -1 if the digit is out of range for the base, -2 if it is
2822 not a digit in any supported base. (Bug#8602)
2824 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2826 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2827 to match comment at start of function. This also removes a
2828 GCC warning about overflow in a 32+64-bit port.
2830 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2832 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2833 Reported by Stefan Monnier in
2834 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2835 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2836 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2838 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2839 (EMACS_UINTPTR): Likewise, with uintptr_t.
2841 * lisp.h: Prefer 64-bit EMACS_INT if available.
2842 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2843 on 32-bit hosts that have 64-bit int, so that they can access
2845 However, temporarily disable this change unless the temporary
2846 symbol WIDE_EMACS_INT is defined.
2848 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2850 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2851 This removes an assumption that EMACS_INT and long are the same
2852 width as pointers. The assumption is true for Emacs porting targets
2853 now, but we want to make other targets possible.
2854 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2855 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2856 In the rest of the code, change types of integers that hold casted
2857 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2858 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2859 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2860 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2861 No need to cast type when ORing.
2862 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2863 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2864 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2865 assume EMACS_INT is the same width as char *.
2866 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2867 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2868 Remove no-longer-needed casts.
2869 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2870 (xg_tool_bar_help_callback, xg_make_tool_item):
2871 Use EMACS_INTPTR to hold an integer
2872 that will be cast to void *; this can avoid a GCC warning
2873 if EMACS_INT is not the same width as void *.
2874 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2875 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2876 (current_message_1, set_message_1):
2877 Use a local to convert to proper width without a cast.
2878 * xmenu.c (dialog_selection_callback): Likewise.
2880 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2881 Also, don't assume VALBITS / RAND_BITS is less than 5,
2882 and don't rely on undefined behavior when shifting a 1 left into
2884 * lisp.h (get_random): Change signature to match.
2886 * lread.c (hash_string): Use size_t, not int, for hash computation.
2887 Normally we prefer signed values; but hashing is special, because
2888 it's better to use unsigned division on hash table sizes so that
2889 the remainder is nonnegative. Also, size_t is the natural width
2890 for hashing into memory. The previous code used 'int', which doesn't
2891 retain enough info to hash well into very large tables.
2892 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2894 * dbusbind.c: Don't possibly lose pointer info when converting.
2895 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2896 Use XPNTR rather than XHASH, so that the high-order bits of
2897 the pointer aren't lost when converting through void *.
2899 * eval.c (Fautoload): Don't double-shift a pointer.
2901 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2903 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2905 * gnutls.c (DEF_GNUTLS_FN):
2906 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2908 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2910 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2913 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2915 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2916 New version that can reserve upto 2GB of heap space.
2918 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2920 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2922 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2924 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2925 `gnutls_certificate_set_x509_key_file'.
2927 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2929 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2930 Update dependencies.
2932 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2934 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2935 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2936 Remove unused parameter `fildes'.
2937 * process.c (read_process_output, send_process): Don't pass it.
2939 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2941 Fix previous change: the library cache is defined in w32.c.
2942 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2943 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2945 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2947 Implement dynamic loading of GnuTLS on Windows.
2949 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2950 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2951 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2954 * gnutls.c (Qgnutls_dll): Define.
2955 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2956 (gnutls_*): Declare function pointers.
2957 (init_gnutls_functions): New function to initialize function pointers.
2958 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2959 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2960 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2961 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2962 (emacs_gnutls_write, emacs_gnutls_read)
2963 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2964 (Fgnutls_available_p): New function.
2965 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2966 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2967 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2969 * image.c: Include w32.h.
2970 (Vimage_type_cache): Delete.
2971 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2972 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2973 (w32_delayed_load): Move to w32.c.
2975 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2977 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2978 (w32_delayed_load): Move from image.c. When loading a library, record
2979 its filename in the :loaded-from property of the library id.
2980 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2981 Initialize and staticpro them.
2982 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2984 * process.c: Include lisp.h before w32.h, not after.
2985 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2986 instead of gnutls_record_check_pending.
2988 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2990 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2992 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2993 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2996 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2998 * xterm.c (x_set_frame_alpha): Do not set property on anything
2999 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3001 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3003 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3005 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3007 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3008 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3009 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3010 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3011 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3012 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3013 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3014 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3015 (Qgnutls_bootprop_callbacks_verify): Make static.
3017 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3019 * callproc.c: Indentation fixup.
3021 * sysdep.c (wait_for_termination_1): Make static.
3022 (wait_for_termination, interruptible_wait_for_termination):
3023 Move after wait_for_termination_1.
3025 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3027 * sysdep.c (interruptible_wait_for_termination): New function
3028 which is like wait_for_termination, but allows keyboard
3031 * callproc.c (Fcall_process): Add (:file "file") as an option for
3033 (Fcall_process_region): Ditto.
3035 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3037 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3038 rather than `XVECTOR (FOO)->size'.
3040 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3041 inttypes.h, as a gnulib replacement is used if it not available in
3044 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3046 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3047 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3048 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3050 * coding.c (coding_alloc_by_realloc): Error out if destination
3051 will grow beyond MOST_POSITIVE_FIXNUM.
3052 (decode_coding_emacs_mule): Abort if there isn't enough place in
3053 charbuf for the composition carryover bytes. Reserve an extra
3054 space for up to 2 characters produced in a loop.
3055 (decode_coding_iso_2022): Abort if there isn't enough place in
3056 charbuf for the composition carryover bytes.
3058 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3060 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3061 aborting when %lld or %lll format is passed.
3062 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3063 %llo or %llx format is passed. (Bug#8545)
3065 * window.c (window_scroll_line_based): Use a marker instead of
3066 simple variables to record original value of point. (Bug#7952)
3068 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3069 produced by %s or %c overflows available buffer space. (Bug#8545)
3071 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3073 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3074 (SIZE_MAX): Move defn after all includes, as they might #define it.
3076 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3078 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3080 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3082 * keyboard.c (Qdelayed_warnings_hook): Define.
3083 (command_loop_1): Run `delayed-warnings-hook'
3084 if Vdelayed_warnings_list is non-nil.
3085 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3086 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3088 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3090 * doprnt.c (doprnt): Don't return value smaller than the buffer
3091 size if the message was truncated. (Bug#8545).
3093 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3095 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3096 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3098 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3100 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3102 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3104 * makefile.w32-in: Update dependencies.
3106 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3108 Improve `doprnt' and its usage. (Bug#8545)
3109 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3110 `format_end'. Remove support for %l as a conversion specifier.
3111 Don't use xrealloc. Improve diagnostics when the %l size modifier
3112 is used. Update the commentary.
3114 * eval.c (verror): Simplify calculation of size_t.
3116 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3119 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3121 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3124 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3126 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3127 This makes this file independent of the recent pseudovector change.
3129 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3131 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3133 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3134 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3135 Remove unused local.
3136 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3138 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3139 GCC 4.6.0 optimizes based on type-based alias analysis.
3140 For example, if b is of type struct buffer * and v of type struct
3141 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3142 != &v->size, and therefore "v->size = 1; b->size = 2; return
3143 v->size;" must therefore return 1. This assumption is incorrect
3144 for Emacs, since it type-puns struct Lisp_Vector * with many other
3145 types. To fix this problem, this patch adds a new type struct
3146 vectorlike_header that documents the constraints on layout of vectors
3147 and pseudovectors, and helps optimizing compilers not get fooled
3148 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3149 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3150 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3152 (XSETPVECTYPE): Rewrite in terms of new macro.
3153 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3154 This is a bit clearer, and further avoids the possibility of
3155 undesirable aliasing.
3156 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3157 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3158 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3159 since Lisp_Subr is a special case (no "next" field).
3160 (ASIZE): Now uses header.size rather than size.
3161 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3162 to avoid the hassle of writing XVECTOR (foo)->header.size.
3163 (struct vectorlike_header): New type.
3164 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3165 object, to help avoid aliasing.
3166 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3167 (SUBRP): Likewise, since Lisp_Subr is a special case.
3168 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3169 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3170 (struct Lisp_Hash_Table): Combine first two members into a single
3171 struct vectorlike_header member. All uses of "size" and "next" members
3172 changed to be "header.size" and "header.next".
3173 * buffer.h (struct buffer): Likewise.
3174 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3175 * frame.h (struct frame): Likewise.
3176 * process.h (struct Lisp_Process): Likewise.
3177 * termhooks.h (struct terminal): Likewise.
3178 * window.c (struct save_window_data, struct saved_window): Likewise.
3179 * window.h (struct window): Likewise.
3180 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3181 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3182 * buffer.c (init_buffer_once): Likewise.
3183 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3185 * process.c (Fformat_network_address): Use local var for size,
3188 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3190 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3191 * data.c (atof): Remove decl; no longer used or needed.
3192 (digit_to_number): Move to lread.c.
3193 (Fstring_to_number): Use new string_to_number function, to be
3194 consistent with how the Lisp reader treats infinities and NaNs.
3195 Do not assume that floating-point numbers represent EMACS_INT
3196 without losing information; this is not true on most 64-bit hosts.
3197 Avoid double-rounding errors, by insisting on integers when
3198 parsing non-base-10 numbers, as the documentation specifies.
3199 * lisp.h (string_to_number): New decl, replacing ...
3200 (isfloat_string): Remove.
3201 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3202 (read1): Do not accept +. and -. as integers; this
3203 appears to have been a coding error. Similarly, do not accept
3204 strings like +-1e0 as floating point numbers. Do not report
3205 overflow for integer overflows unless the base is not 10 which
3206 means we have no simple and reliable way to continue.
3207 Break out the floating-point parsing into a new
3208 function string_to_number, so that Fstring_to_number parses
3209 floating point numbers consistently with the Lisp reader.
3210 (digit_to_number): Move here from data.c. Make it static inline.
3211 (E_CHAR, EXP_INT): Remove, replacing with ...
3212 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3213 (string_to_number): New function, replacing isfloat_string.
3214 This function checks for valid syntax and produces the resulting
3215 Lisp float number too. Rework it so that string-to-number
3216 no longer mishandles examples like "1.0e+". Use strtoumax,
3217 so that overflow for non-base-10 numbers is reported only when
3218 there's no portable and simple way to convert to floating point.
3220 * textprop.c (set_text_properties_1): Rewrite for clarity,
3221 and to avoid GCC warning about integer overflow.
3223 * intervals.h (struct interval): Use EMACS_INT for members
3224 where EMACS_UINT might cause problems. See
3225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3226 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3227 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3229 (offset_intervals): Tell GCC not to worry about length overflow
3230 when negating a negative length.
3232 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3233 (overrun_check_free): Likewise.
3235 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3236 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3239 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3240 (gnutls_make_error): Rename local to avoid shadowing.
3241 (gnutls_emacs_global_deinit): ifdef out; not used.
3242 (Fgnutls_boot): Use const for pointer to readonly storage.
3243 Comment out unused local. Fix pointer signedness problems.
3245 * lread.c (openp): Don't stuff size_t into an 'int'.
3246 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3247 about possible signed overflow.
3249 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3250 (GDK_KEY_g): Don't define if already defined.
3251 (xg_prepare_tooltip): Avoid pointer signedness problem.
3252 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3254 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3255 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3257 * xfns.c (Fx_window_property): Simplify a bit,
3258 to make a bit faster and to avoid GCC 4.6.0 warning.
3259 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3261 * fns.c (internal_equal): Don't assume size_t fits in int.
3263 * alloc.c (compact_small_strings): Tighten assertion a little.
3265 Replace pEd with more-general pI, and fix some printf arg casts.
3266 * lisp.h (pI): New macro, generalizing old pEd macro to other
3267 conversion specifiers. For example, use "...%"pI"d..." rather
3268 than "...%"pEd"...".
3269 (pEd): Remove. All uses replaced with similar uses of pI.
3270 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3271 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3272 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3273 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3274 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3275 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3276 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3278 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3279 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3280 * print.c (safe_debug_print, print_object): Likewise.
3281 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3283 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3284 avoiding the 0 flag, which is not portable.
3285 * process.c (Fmake_network_process): Use pI to avoid cast.
3286 * region-cache.c (pp_cache): Likewise.
3287 * xdisp.c (decode_mode_spec): Likewise.
3288 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3289 behavior on 64-bit hosts with printf arg.
3290 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3291 (x_stop_queuing_selection_requests): Likewise.
3292 (x_get_window_property): Don't truncate byte count to an 'int'
3295 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3296 here, since it parses constructs like leading '-' and spaces,
3297 which are not wanted; and it overflows with large numbers.
3298 Instead, simply match F[0-9]+, which is what is wanted anyway.
3300 * alloc.c: Remove unportable assumptions about struct layout.
3301 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3302 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3303 (allocate_vectorlike, make_pure_vector): Use the new macros,
3304 plus offsetof, to remove unportable assumptions about struct layout.
3305 These assumptions hold on all porting targets that I know of, but
3306 they are not guaranteed, they're easy to remove, and removing them
3307 makes further changes easier.
3309 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3310 This doesn't fix a bug but makes the code clearer.
3311 (string_overrun_cookie): Now const. Use initializers that
3312 don't formally overflow signed char, to avoid warnings.
3313 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3314 can cause Emacs to crash when string overrun checking is enabled.
3315 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3316 multiple of sizeof (EMACS_INT); it need not be, if
3317 alignof(EMACS_INT) < sizeof (EMACS_INT).
3318 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3320 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3322 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3324 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3326 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3327 supposed to be handshaking. (Bug#8556)
3328 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3330 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3332 * lisp.h (Qdebug): List symbol.
3333 * eval.c (Qdebug): Restore global linkage.
3334 * keyboard.c (debug-on-event): New variable.
3335 (handle_user_signal): Break into debugger when debug-on-event
3336 matches the current signal symbol.
3338 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3340 * alloc.c (check_sblock, check_string_bytes)
3341 (check_string_free_list): Convert to standard C.
3343 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3345 * w32.c (emacs_gnutls_push): Fix typo.
3347 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3349 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3350 "cast to pointer from integer of different size".
3352 Improve doprnt and its use in verror. (Bug#8545)
3353 * doprnt.c (doprnt): Document the set of format control sequences
3354 supported by the function. Use SAFE_ALLOCA instead of always
3357 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3358 is one byte too soon. Don't use xrealloc; instead xfree and
3361 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3363 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3366 * gnutls.c: Renamed global_initialized to
3367 gnutls_global_initialized. Added internals for the
3368 :verify-hostname-error, :verify-error, and :verify-flags
3369 parameters of `gnutls-boot' and documented those parameters in the
3370 docstring. Start callback support.
3371 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3372 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3373 on error. Return error code.
3374 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3375 (emacs_gnutls_read): Likewise.
3376 (Fgnutls_boot): Return handshake error code.
3377 (emacs_gnutls_handle_error): New function.
3378 (wsaerror_to_errno): Likewise.
3380 * w32.h (emacs_gnutls_pull): Add prototype.
3381 (emacs_gnutls_push): Likewise.
3383 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3384 (emacs_gnutls_push): Likewise.
3386 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3388 * process.c (wait_reading_process_output): Check if GnuTLS
3389 buffered some data internally if no FDs are set for TLS
3392 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3393 (LIBS): Link to USER_LIBS.
3394 ($(BLD)/gnutls.$(0)): New target.
3396 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3398 * xdisp.c (handle_single_display_spec): Rename the
3399 display_replaced_before_p argument into display_replaced_p, to
3400 make it consistent with the commentary. Fix typos in the
3403 * textprop.c (syms_of_textprop): Remove dead code.
3404 (copy_text_properties): Delete obsolete commentary about an
3405 interface that was deleted long ago. Fix typos in the description
3408 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3409 to changes in oldXMenu/XMenu.h from 2011-04-16.
3410 <menu_help_message, prev_menu_help_message>: Constify.
3411 (IT_menu_make_room): menu->help_text is now `const char **';
3414 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3415 to changes in oldXMenu/XMenu.h from 2011-04-16.
3416 (struct XMenu): Declare `help_text' `const char **'.
3418 * xfaces.c <Qunspecified>: Make extern again.
3420 * syntax.c: Include sys/types.h before including regex.h, as
3423 * doc.c (get_doc_string): Improve the format passed to `error'.
3425 * doprnt.c (doprnt): Improve commentary.
3427 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3429 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3432 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3433 changes in globals.h immediately force recompilation.
3434 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3435 $(CURDIR)/s/ms-w32.h.
3436 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3438 * character.c (Fchar_direction): Function deleted.
3439 (syms_of_character): Don't defsubr it.
3440 <char-direction-table>: Deleted.
3442 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3444 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3445 * doprnt.c: Include limits.h.
3446 (SIZE_MAX): New macro.
3447 (doprnt): Return a size_t value. 2nd arg is now size_t.
3448 Many local variables are now size_t instead of int or unsigned.
3449 Improve overflow protection. Support `l' modifier for integer
3450 conversions. Support %l conversion. Don't assume an EMACS_INT
3451 argument for integer conversions and for %c.
3453 * lisp.h (doprnt): Restore prototype.
3455 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3458 * Makefile.in (base_obj): Add back doprnt.o.
3460 * deps.mk (doprnt.o): Add back prerequisites.
3461 (callint.o): Depend on character.h.
3463 * eval.c (internal_lisp_condition_case): Include the handler
3464 representation in the error message.
3465 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3466 when breaking from the loop.
3468 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3470 * callint.c (Fcall_interactively): When displaying error message
3471 about invalid control letter, pass the character's codepoint, not
3472 a pointer to its multibyte form. Improve display of the character
3473 in octal and display also its hex code.
3475 * character.c (char_string): Use %x to display the (unsigned)
3476 codepoint of an invalid character, to avoid displaying a bogus
3479 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3480 `error', not SYMBOL_NAME itself.
3482 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3483 character arguments to `error'.
3485 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3486 to `error' in error message about FINAL_CHAR argument. Make sure
3487 FINAL_CHAR is a character, and use %c when it is passed as
3488 argument to `error'.
3490 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3492 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3494 * w32.c: Include <time.h>.
3495 (sys_localtime): New function.
3497 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3499 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3501 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3503 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3505 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3508 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3510 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3511 gl_state.e_property when gl_state.object is Qt.
3513 * insdel.c (make_gap_larger): Remove limitation of buffer size
3516 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3518 * xdisp.c (lookup_glyphless_char_display)
3519 (produce_glyphless_glyph): Handle cons cell entry in
3520 glyphless-char-display.
3521 (Vglyphless_char_display): Document it.
3523 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3524 glyphless-char-display.
3526 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3528 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3530 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3532 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3533 definition for no-X builds.
3535 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3537 Static checks with GCC 4.6.0 and non-default toolkits.
3539 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3541 * process.c (keyboard_bit_set): Define only if SIGIO.
3542 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3543 (send_process): Repair possible setjmp clobbering.
3545 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3547 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3549 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3551 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3552 Define only if needed.
3554 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3555 by pacifying GCC about it. Maybe it's time to retire it?
3556 * xfaces.c (USG, __TIMEVAL__): Likewise.
3558 * dispextern.h (struct redisplay_interface): Rename param
3560 * termhooks.h (struct terminal): Likewise.
3561 * xterm.c (xembed_send_message): Likewise.
3563 * insdel.c (make_gap_smaller): Define only if
3564 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3566 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3569 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3570 so that we aren't warned about unused symbols.
3572 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3574 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3576 * xfns.c (x_real_positions): Mark locals as initialized.
3578 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3580 * xterm.c: Fix problems found by static analysis with other toolkits.
3581 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3582 (x_dispatch_event): Declare static if USE_GTK, and
3583 define if USE_GTK || USE_X_TOOLKIT.
3584 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3585 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3586 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3587 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3589 * xmenu.c (menu_help_callback): Pointer type fixes.
3590 Use const pointers when pointing at readonly data. Avoid pointer
3592 (FALSE): Remove unused macro.
3593 (update_frame_menubar): Remove unused decl.
3595 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3597 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3598 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3599 (single_menu_item): Rename local to avoid shadowing.
3601 * keyboard.c (make_lispy_event): Remove unused local var.
3603 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3604 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3606 * bitmaps: Change bitmaps from unsigned char back to the X11
3607 compatible char. Avoid the old compiler warnings about
3608 out-of-range initializers by using, for example, '\xab' rather
3611 * xgselect.c (xgselect_initialize): Check vs interface
3612 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3614 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3616 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3617 to read-only memory.
3619 * fns.c (vector): Remove; this old hack is no longer needed.
3621 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3623 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3625 * xrdb.c (x_load_resources): Omit unused local.
3627 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3628 (x_window): Rename locals to avoid shadowing.
3629 (USG): Use the kludged USG macro, to pacify gcc.
3631 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3632 (x_term_init): Remove local to avoid shadowing.
3634 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3636 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3637 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3639 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3641 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3643 Fix regex.c, syntax.c and friends for buffers > 2GB.
3644 * syntax.h (struct gl_state_s): Declare character position members
3647 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3649 * textprop.c (verify_interval_modification, interval_of):
3650 Declare arguments EMACS_INT.
3652 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3655 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3657 * indent.c (Fvertical_motion): Local variable it_start is now
3660 * regex.c (re_match, re_match_2, re_match_2_internal)
3661 (bcmp_translate, regcomp, regexec, print_double_string)
3662 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3663 (re_compile_pattern, re_exec): Declare arguments and local
3664 variables `size_t' and `ssize_t' and return values `regoff_t', as
3666 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3667 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3668 <compile_stack_type>: `size' and `avail' are now `size_t'.
3670 * regex.h <regoff_t>: Use ssize_t, not int.
3671 (re_search, re_search_2, re_match, re_match_2): Arguments that
3672 specify buffer/string position and length are now ssize_t and
3673 size_t. Return type is regoff_t.
3675 2011-04-16 Ben Key <bkey76@gmail.com>
3677 * nsfont.m: Fixed bugs in ns_get_family and
3678 ns_descriptor_to_entity that were caused by using free to
3679 deallocate memory blocks that were allocated by xmalloc (via
3680 xstrdup). This caused Emacs to crash when compiled with
3681 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3682 --enable-checking=xmallocoverrun). xfree is now used to
3683 deallocate these memory blocks.
3685 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3687 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3689 emacs_write: Accept and return EMACS_INT for sizes.
3690 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3692 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3693 Accept and return EMACS_INT.
3694 (emacs_gnutls_write): Return the number of bytes written on
3696 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3697 (emacs_read, emacs_write): Remove check for negative size, as the
3698 Emacs source code has been audited now.
3699 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3700 (emacs_read, emacs_write): Use it.
3701 * process.c (send_process): Adjust to the new signatures of
3702 emacs_write and emacs_gnutls_write. Do not attempt to store
3703 a byte offset into an 'int'; it might overflow.
3704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3706 * sound.c: Don't assume sizes fit in 'int'.
3707 (struct sound_device.period_size, alsa_period_size):
3708 Return EMACS_INT, not int.
3709 (struct sound_device.write, vox_write, alsa_write):
3710 Accept EMACS_INT, not int.
3711 (wav_play, au_play): Use EMACS_INT to store sizes and to
3712 record read return values.
3714 2011-04-15 Ben Key <bkey76@gmail.com>
3716 * keyboard.c (Qundefined): Don't declare static since it is used
3718 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3719 static since they are used in nsfont.m.
3721 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3723 * process.c (Qprocessp): Don't declare static.
3724 * lisp.h (Qprocessp): Declare again.
3726 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3728 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3730 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3732 Improve C-level modularity by making more things 'static'.
3734 Don't publish debugger-only interfaces to other modules.
3735 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3736 (verify_bytepos, count_markers): Move decls to the only modules
3738 * region-cache.h (pp_cache): Likewise.
3739 * window.h (check_all_windows): Likewise.
3740 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3742 * sysdep.c (croak): Now static, if
3743 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3744 * syssignal.h (croak): Declare only if not static.
3746 * alloc.c (refill_memory_reserve): Now static if
3747 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3748 * lisp.h (refill_memory_reserve): Declare only if not static.
3750 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3751 Define only if USE_LUCID.
3753 * xrdb.c (x_customization_string, x_rm_string): Now static.
3755 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3756 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3758 * xdisp.c (draw_row_with_mouse_face): Now static.
3759 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3761 * window.h (check_all_windows): Mark externally visible.
3763 * window.c (window_deletion_count): Now static.
3765 * undo.c: Make symbols static if they're not exported.
3766 (last_undo_buffer, last_boundary_position, pending_boundary):
3769 * textprop.c (interval_insert_behind_hooks): Now static.
3770 (interval_insert_in_front_hooks): Likewise.
3772 * term.c: Make symbols static if they're not exported.
3773 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3774 (max_frame_lines, tty_set_terminal_modes):
3775 (tty_reset_terminal_modes, tty_turn_off_highlight):
3776 (get_tty_terminal): Now static.
3777 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3778 * termhooks.h (term_mouse_moveto): Do not declare if
3780 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3781 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3783 * sysdep.c: Make symbols static if they're not exported.
3784 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3786 (sigprocmask_set, full_mask): Remove; unused.
3787 (wait_debugging): Mark as visible.
3788 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3789 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3791 * syntax.c (syntax_temp): Define only if !__GNUC__.
3793 * sound.c (current_sound_device, current_sound): Now static.
3795 * search.c (searchbufs, searchbuf_head): Now static.
3797 * scroll.c (scroll_cost): Remove; unused.
3798 * dispextern.h (scroll_cost): Remove decl.
3800 * region-cache.h (pp_cache): Mark as externally visible.
3802 * process.c: Make symbols static if they're not exported.
3803 (process_tick, update_tick, create_process, chan_process):
3804 (Vprocess_alist, proc_buffered_char, datagram_access):
3805 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3806 (deactivate_process): Mark defn as static, as well as decl.
3807 * lisp.h (create_process): Remove decl.
3808 * process.h (chan_process, Vprocess_alist): Remove decls.
3810 * print.c: Make symbols static if they're not exported.
3811 (print_depth, new_backquote_output, being_printed, print_buffer):
3812 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3813 (print_interval, print_number_index, initial_stderr_stream):
3815 * lisp.h (Fprinc): Remove decl.
3816 (debug_output_compilation_hack): Mark as externally visible.
3818 * sysdep.c (croak): Move decl from here to syssignal.h.
3819 * syssignal.h (croak): Put it here, so the API can be checked when
3820 'croak' is called from dissociate_if_controlling_tty.
3822 * minibuf.c: Make symbols static if they're not exported.
3823 (minibuf_save_list, choose_minibuf_frame): Now static.
3824 * lisp.h (choose_minibuf_frame): Remove decl.
3826 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3828 * lread.c: Make symbols static if they're not exported.
3829 (read_objects, initial_obarray, oblookup_last_bucket_number):
3831 (make_symbol): Remove; unused.
3832 * lisp.h (initial_obarray, make_symbol): Remove decls.
3834 * keyboard.c: Make symbols static if they're not exported.
3835 (single_kboard, recent_keys_index, total_keys, recent_keys):
3836 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3837 (this_single_command_key_start, echoing, last_auto_save):
3838 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3839 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3840 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3841 (Vlispy_mouse_stem, double_click_count):
3843 (force_auto_save_soon): Define only if SIGDANGER.
3844 (ignore_mouse_drag_p): Now static if
3845 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3846 (print_help): Remove; unused.
3847 (stop_character, last_timer_event): Mark as externally visible.
3848 * keyboard.h (ignore_mouse_drag_p): Declare only if
3849 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3850 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3851 * lisp.h (echoing): Remove decl.
3852 (force_auto_save_soon): Declare only if SIGDANGER.
3853 * xdisp.c (redisplay_window): Simplify code, to make it more
3854 obvious that ignore_mouse_drag_p is not accessed if !defined
3855 USE_GTK && !defined HAVE_NS.
3857 * intervals.c: Make symbols static if they're not exported.
3858 (merge_properties_sticky, merge_interval_right, delete_interval):
3860 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3862 * insdel.c: Make symbols static if they're not exported.
3863 However, leave prepare_to_modify_buffer alone. It's never
3864 called from outside this function, but that appears to be a bug.
3865 (combine_after_change_list, combine_after_change_buffer):
3866 (adjust_after_replace, signal_before_change): Now static.
3867 (adjust_after_replace_noundo): Remove; unused.
3868 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3869 (signal_before_change): Remove decls.
3871 * indent.c (val_compute_motion, val_vmotion): Now static.
3873 * image.c: Make symbols static if they're not exported.
3874 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3876 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3877 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3879 * fringe.c (standard_bitmaps): Now static.
3880 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3882 * frame.c: Make symbols static if they're not exported.
3883 (x_report_frame_params, make_terminal_frame): Now static.
3884 (get_frame_param): Now static, unless HAVE_NS.
3885 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3886 (x_get_resource_string): Remove; not used.
3887 * frame.h (make_terminal_frame, x_report_frame_params):
3888 (x_get_resource_string); Remove decls.
3889 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3890 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3892 * font.c, fontset.c: Make symbols static if they're not exported.
3893 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3894 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3895 * font.c (font_close_object): Now static.
3896 * font.h (font_close_object): Remove.
3897 * fontset.c (FONTSET_OBJLIST): Remove.
3898 (free_realized_fontset) #if-0 the body, which does nothing.
3899 (face_suitable_for_char_p): #if-0, as it's never called.
3900 * fontset.h (face_suitable_for_char_p): Remove decl.
3901 * xfaces.c (face_at_string_position):
3902 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3903 since 0 is always ASCII.
3905 * fns.c (weak_hash_tables): Now static.
3907 * fileio.c: Make symbols static if they're not exported.
3908 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3909 (Vwrite_region_annotation_buffers): Now static.
3911 * eval.c: Make symbols static if they're not exported.
3912 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3913 * lisp.h (backtrace_list): Remove decl.
3915 * emacs.c: Make symbols static if they're not exported.
3916 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3917 (fatal_error_code, fatal_error_signal_hook, standard_args):
3919 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3920 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3921 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3922 * lisp.h (fatal_error_signal_hook): Remove decl.
3923 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3925 * editfns.c: Move a (normally-unused) function to its only use.
3926 * editfns.c, lisp.h (get_operating_system_release): Remove.
3927 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3928 worth the hassle of breaking this out.
3930 * xterm.c: Make symbols static if they're not exported.
3931 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3932 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3933 (x_destroy_window, x_delete_display):
3935 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3936 (x_mouse_leave): Remove; unused.
3937 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3938 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3939 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3941 (x_mouse_leave): Declare only if WINDOWSNT.
3942 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3943 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3946 * ftxfont.c: Make symbols static if they're not exported.
3947 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3949 * font.h (ftxfont_driver): Likewise.
3951 * xfns.c: Make symbols static if they're not exported.
3952 (x_last_font_name, x_display_info_for_name):
3953 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3954 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3955 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3956 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3957 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3958 (last_show_tip_args): Now static.
3959 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3960 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3961 (x_screen_planes): Remove; unused.
3962 * dispextern.h (x_screen_planes): Remove decl.
3964 * dispnew.c: Make symbols static if they're not exported.
3965 * dispextern.h (redraw_garbaged_frames, scrolling):
3966 (increment_row_positions): Remove.
3967 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3968 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3970 (redraw_garbaged_frames): Remove; unused.
3972 * xfaces.c: Make symbols static if they're not exported.
3973 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3975 * xterm.h (defined_color): Remove decls.
3976 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3977 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3978 (menu_face_changed_default, defined_color, free_realized_face):
3979 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3980 (ascii_face_of_lisp_face): Remove; unused.
3982 * xdisp.c: Make symbols static if they're not exported.
3983 * dispextern.h (scratch_glyph_row, window_box_edges):
3984 (glyph_to_pixel_coords, set_cursor_from_row):
3985 (get_next_display_element, set_iterator_to_next):
3986 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3987 (show_mouse_face): Remove decls
3988 * frame.h (message_buf_print): Likewise.
3989 * lisp.h (pop_message, set_message, check_point_in_composition):
3991 * xterm.h (set_vertical_scroll_bar): Likewise.
3992 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3993 (message_buf_print, scratch_glyph_row, displayed_buffer):
3994 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3995 (get_next_display_element, show_mouse_face, window_box_edges):
3996 (frame_to_window_pixel_xy, check_point_in_composition):
3997 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3998 (glyph_to_pixel_coords): Remove; unused.
4000 * dired.c (file_name_completion): Now static.
4002 * dbusbind.c (xd_in_read_queued_messages): Now static.
4004 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4005 * data.c (circular_list_error): Remove.
4007 * commands.h (last_point_position, last_point_position_buffer):
4008 (last_point_position_window): Remove decls.
4009 * keyboard.c: Make these variables static.
4011 * coding.h (coding, code_convert_region, encode_coding_gap):
4013 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4014 (iso_code_class, detect_coding, code_convert_region): Now static.
4015 (encode_coding_gap): Remove; unused.
4017 * chartab.c (chartab_chars, chartab_bits): Now static.
4019 * charset.h (charset_iso_8859_1): Remove decl.
4020 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4023 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4024 * ccl.c (Vccl_program_table): Now static.
4025 (check_ccl_update): Remove; unused.
4027 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4028 * category.h: ... from here.
4029 * category.c (check_category_table, set_category_set): Now static.
4031 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4032 * lisp.h: Remove these decls.
4034 * buffer.c (buffer_count): Remove unused var.
4036 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4037 so that it's not optimized away.
4038 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4039 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4040 exported only to the debugger.
4042 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4043 * atimer.h (run_all_atimers): Remove; not exported.
4045 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4046 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4047 was inaccessible from Lisp.
4048 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4049 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4051 alloc.c: Import and export fewer symbols, and remove unused items.
4052 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4054 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4055 it's not optimized away by whole-program optimization.
4056 (message_enable_multibyte, free_misc): Remove.
4057 (catchlist, handlerlist, mark_backtrace):
4058 Declare only if BYTE_MARK_STACK.
4059 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4060 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4061 (message_enable_multibyte): Remove decl.
4062 (free_misc, interval_free_list, float_block, float_block_index):
4063 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4064 (cons_free_list, last_marked_index):
4066 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4067 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4068 (mark_backtrace): Define only if BYTE_MARK_STACK.
4069 * xdisp.c (message_enable_multibyte): Now static.
4071 Declare Lisp_Object Q* variables to be 'static' if not exported.
4072 This makes it easier for human readers (and static analyzers)
4073 to see whether these variables are used from other modules.
4074 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4075 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4076 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4077 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4078 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4079 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4080 * xmenu.c, xselect.c:
4081 Declare Q* vars static if they are not used in other modules.
4082 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4083 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4084 Remove decls of unexported vars.
4085 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4087 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4089 Make Emacs functions such as Fatom 'static' by default.
4090 This makes it easier for human readers (and static analyzers)
4091 to see whether these functions can be called from other modules.
4092 DEFUN now defines a static function. To make the function external
4093 so that it can be used in other C modules, use the new macro DEFUE.
4094 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4095 (Finit_image_library):
4096 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4097 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4098 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4099 Remove decls, since these functions are now static.
4100 (Funintern, Fget_internal_run_time): New decls, since these functions
4101 were already external.
4103 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4104 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4105 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4106 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4107 * keyboard.c, keymap.c, lread.c:
4108 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4109 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4110 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4111 Mark functions with DEFUE instead of DEFUN,
4112 if they are used in other modules.
4113 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4114 decls for now-static functions.
4115 * buffer.h (Fdelete_overlay): Remove decl.
4116 * callproc.c (Fgetenv_internal): Mark as internal.
4117 * composite.c (Fremove_list_of_text_properties): Remove decl.
4118 (Fcomposition_get_gstring): New forward static decl.
4119 * composite.h (Fcomposite_get_gstring): Remove decl.
4120 * dired.c (Ffile_attributes): New forward static decl.
4121 * doc.c (Fdocumntation_property): New forward static decl.
4122 * eval.c (Ffetch_bytecode): New forward static decl.
4123 (Funintern): Remove extern decl; now in .h file where it belongs.
4124 * fileio.c (Fmake_symbolic_link): New forward static decl.
4125 * image.c (Finit_image_library): New forward static decl.
4126 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4127 * intervals.h (Fprevious_property_change):
4128 (Fremove_list_of_text_properties): Remove decls.
4129 * keyboard.c (Fthis_command_keys): Remove decl.
4130 (Fcommand_execute): New forward static decl.
4131 * keymap.c (Flookup_key): New forward static decl.
4132 (Fcopy_keymap): Now static.
4133 * keymap.h (Flookup_key): Remove decl.
4134 * process.c (Fget_process): New forward static decl.
4135 (Fprocess_datagram_address): Mark as internal.
4136 * syntax.c (Fsyntax_table_p): New forward static decl.
4137 (skip_chars): Remove duplicate decl.
4138 * textprop.c (Fprevious_property_change): New forward static decl.
4139 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4141 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4142 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4144 * editfns.c (Fformat): Remove unreachable code.
4146 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4148 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4151 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4153 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4154 when at ZV. (Bug#8487)
4156 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4158 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4160 * keyboard.c (parse_tool_bar_item): Likewise.
4161 * sound.c (sound_cleanup, alsa_close): Likewise.
4162 * termcap.c (tgetent): Likewise.
4163 * xfns.c (x_default_font_parameter): Likewise.
4164 * xsettings.c (read_and_apply_settings): Likewise.
4166 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4167 (overrun_check_free): Protoize.
4169 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4171 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4172 since callers should never pass a negative size.
4173 Change the signature to match that of plain 'read' and 'write'; see
4174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4175 * lisp.h: Update prototypes of emacs_write and emacs_read.
4177 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4179 * xdisp.c (redisplay_window): Don't try to determine the character
4180 position of the scroll margin if the window start point w->startp
4181 is outside the buffer's accessible region. (Bug#8468)
4183 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4185 Fix write-region and its subroutines for buffers > 2GB.
4186 * fileio.c (a_write, e_write): Modify declaration of arguments and
4187 local variables to support buffers larger than 2GB.
4188 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4190 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4191 argument, local variables, and return value.
4193 * lisp.h: Update prototypes of emacs_write and emacs_read.
4195 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4197 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4199 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4201 Fix more problems found by GCC 4.6.0's static checks.
4203 * xdisp.c (vmessage): Use a better test for character truncation.
4205 * charset.c (load_charset_map): <, not <=, for optimization,
4206 and to avoid potential problems with integer overflow.
4207 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4208 * casetab.c (set_identity, shuffle): Likewise.
4209 * editfns.c (Fformat): Likewise.
4210 * syntax.c (skip_chars): Likewise.
4212 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4213 This also lets GCC 4.6.0 generate slightly better loop code.
4215 * callint.c (Fcall_interactively): <, not <=, for optimization.
4216 (Fcall_interactively): Count the number of arguments produced,
4217 not the number of arguments given. This is simpler and lets GCC
4218 4.6.0 generate slightly better code.
4220 * ftfont.c: Distingish more carefully between FcChar8 and char.
4221 The previous code passed unsigned char * to a functions like
4222 strlen and xstrcasecmp that expect char *, which does not
4223 conform to the C standard.
4224 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4225 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4226 char * when the C standard requires it.
4228 * keyboard.c (read_char): Remove unused var.
4230 * eval.c: Port to Windows vsnprintf (Bug#8435).
4232 (SIZE_MAX): Define if the headers do not.
4233 (verror): Do not give up if vsnprintf returns a negative count.
4234 Instead, grow the buffer. This ports to Windows vsnprintf, which
4235 does not conform to C99. Problem reported by Eli Zaretskii.
4236 Also, simplify the allocation scheme, by avoiding the need for
4237 calling realloc, and removing the ALLOCATED variable.
4239 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4241 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4242 But keep the doprint source code for now, as we might revamp it
4243 and use it again (Bug#8435).
4244 * lisp.h (doprnt): Remove.
4245 * Makefile.in (base_obj): Remove doprnt.o.
4246 * deps.mk (doprnt.o): Remove.
4248 error: Print 32- and 64-bit integers portably (Bug#8435).
4249 Without this change, on typical 64-bit hosts error ("...%d...", N)
4250 was used to print both 32- and 64-bit integers N, which relied on
4252 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4254 * lisp.h (error, verror): Mark as printf-like functions.
4255 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4256 Report overflow in size calculations when allocating printf buffer.
4257 Do not truncate output string at its first null byte.
4258 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4259 Truncate the output at a character boundary, since vsnprintf does not
4261 * charset.c (check_iso_charset_parameter): Convert internal
4262 character to string before calling 'error', since %c now has the
4264 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4265 overflow when computing char to be passed to 'error'. Do not
4266 pass Lisp_Object to 'error'; pass the integer instead.
4267 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4268 formatted with plain %d.
4270 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4272 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4274 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4276 * xterm.c (x_catch_errors): Remove duplicate declaration.
4278 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4280 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4282 2011-04-10 Jim Meyering <meyering@redhat.com>
4284 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4285 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4286 return ssize_t not "int", and use size_t as the buffer length.
4287 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4288 * gnutls.h: Update declarations.
4289 * process.c (read_process_output): Use ssize_t, to match.
4290 (send_process): Likewise.
4292 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4294 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4296 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4298 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4299 Use unsigned char, to match FcChar8 type definition.
4301 * xterm.c (handle_one_xevent):
4302 * xmenu.c (create_and_show_popup_menu):
4303 * xselect.c (x_decline_selection_request)
4304 (x_reply_selection_request): Avoid type-punned deref of X events.
4306 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4308 Fix some uses of `int' instead of EMACS_INT.
4309 * search.c (string_match_1, fast_string_match)
4310 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4311 (scan_buffer, find_next_newline_no_quit)
4312 (find_before_next_newline, search_command, Freplace_match)
4313 (Fmatch_data): Make some `int' variables be EMACS_INT.
4315 * xdisp.c (display_count_lines): 3rd argument and return value now
4316 EMACS_INT. All callers changed.
4317 (pint2hrstr): Last argument is now EMACS_INT.
4319 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4320 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4321 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4322 (decode_coding_utf_16, decode_coding_emacs_mule)
4323 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4324 (decode_coding_ccl, decode_coding_charset)
4325 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4326 (decode_coding_iso_2022, decode_coding_emacs_mule)
4327 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4328 <char_offset, last_offset>: Declare EMACS_INT.
4329 (encode_coding_utf_8, encode_coding_utf_16)
4330 (encode_coding_emacs_mule, encode_invocation_designation)
4331 (encode_designation_at_bol, encode_coding_iso_2022)
4332 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4333 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4335 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4336 (encode_invocation_designation): Last argument P_NCHARS is now
4338 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4339 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4341 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4344 * ccl.c (Fccl_execute_on_string): Declare some variables
4347 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4349 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4351 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4353 * process.c (Fformat_network_address): Doc fix.
4355 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4357 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4359 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4361 * keyboard.c (read_char): Call Lisp function help-form-show,
4362 instead of using internal_with_output_to_temp_buffer.
4363 (Qhelp_form_show): New var.
4364 (syms_of_keyboard): Use DEFSYM macro.
4366 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4368 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4370 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4372 * process.c (Flist_processes): Remove to Lisp.
4373 (list_processes_1): Delete.
4375 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4377 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4379 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4381 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4383 Fix more problems found by GCC 4.6.0's static checks.
4385 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4387 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4389 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4391 * xdisp.c (vmessage): Mark as a printf-like function.
4393 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4395 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4397 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4398 printf-like functions.
4399 (tiff_load): Add casts to remove these marks before passing them
4400 to system-supplied API.
4402 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4404 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4405 This avoids several warnings with gcc -Wstrict-overflow.
4406 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4407 directly, rather than having caller test rule sign. This avoids
4408 some unnecessary tests.
4409 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4410 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4411 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4413 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4414 (xfont_open): Avoid unnecessary tests.
4416 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4418 * composite.h, composite.c (composition_gstring_put_cache):
4419 Use EMACS_INT, not int, for length.
4421 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4422 breaking out part of COMPOSITION_DECODE_RULE.
4423 (COMPOSITION_DECODE_RULE): Use it.
4424 * composite.c (get_composition_id): Remove unused local vars,
4425 by using the new macro.
4427 * textprop.c (set_text_properties_1): Change while to do-while,
4428 since the condition is always true at first.
4430 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4431 (interval_deletion_adjustment): Return unsigned value.
4434 * process.c (list_processes_1, create_pty, read_process_output):
4435 (exec_sentinel): Remove vars that were set but not used.
4436 (create_pty): Remove unnecessary "volatile"s.
4437 (Fnetwork_interface_info): Avoid possibility of int overflow.
4438 (read_process_output): Do adaptive read buffering even if carryover.
4439 (read_process_output): Simplify nbytes computation if buffered.
4441 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4443 * syntax.c (scan_words): Remove var that was set but not used.
4444 (update_syntax_table): Use unsigned instead of int.
4446 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4447 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4448 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4450 * print.c (print_error_message): Avoid int overflow.
4452 * font.c (font_list_entities): Redo for clarity,
4453 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4455 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4456 (font_score): Avoid potential overflow in diff calculation.
4458 * fns.c (substring_both): Remove var that is set but not used.
4459 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4461 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4463 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4464 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4465 can always succeed if overflow has undefined behavior.
4467 * search.c (boyer_moore, wordify): Remove vars set but not used.
4468 (wordify): Omit three unnecessary tests.
4470 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4471 All callers changed. This avoids the need for an unused var.
4473 * casefiddle.c (casify_region): Remove var that is set but not used.
4475 * dired.c (file_name_completion): Remove var that is set but not used.
4477 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4479 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4480 (Finsert_file_contents): Remove unnecessary code checking fd.
4482 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4483 Check for integer overflow on size calculations.
4485 * buffer.c (Fprevious_overlay_change): Remove var that is set
4488 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4489 Remove vars that are set but not used.
4490 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4491 (timer_check_2): Mark vars as initialized.
4493 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4495 * image.c (lookup_image): Remove var that is set but not used.
4496 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4498 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4499 that are set but not used.
4501 * xfns.c (make_invisible_cursor): Don't return garbage
4502 if XCreateBitmapFromData fails (Bug#8410).
4504 * xselect.c (x_get_local_selection, x_handle_property_notify):
4505 Remove vars that are set but not used.
4507 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4508 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4510 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4511 Remove var that is set but not used.
4512 (scroll_bar_windows_size): Now size_t, not int.
4513 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4516 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4517 (map_tty_color) [!defined MSDOS]: Likewise.
4519 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4521 * coding.c: Remove vars that are set but not used.
4522 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4523 All callers changed.
4524 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4525 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4526 (decode_coding_charset): Remove vars that are set but not used.
4528 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4529 that is set but not used.
4531 * print.c (print_object): Remove var that is set but not used.
4533 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4534 The gnulib version avoids calling malloc in the usual case,
4535 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4536 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4537 * filelock.c (current_lock_owner): Likewise.
4538 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4539 * sysdep.c: Include allocator.h, careadlinkat.h.
4540 (emacs_no_realloc_allocator): New static constant.
4541 (emacs_readlink): New function.
4542 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4543 ../lib/careadlinkat.h.
4545 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4547 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4548 first non-nil return value).
4550 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4552 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4553 if not defined (Bug#8403).
4555 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4557 * xdisp.c (display_count_lines): Remove parameter `start',
4558 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4559 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4560 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4561 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4562 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4563 and thereabouts. All callers changed.
4564 (get_per_char_metric): Remove parameter `f', unused since
4565 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4567 2011-04-02 Jim Meyering <meyering@redhat.com>
4569 do not dereference NULL upon failed strdup
4570 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4571 (ns_get_family): Likewise.
4573 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4575 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4577 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4579 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4582 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4584 Add lexical binding.
4586 * window.c (Ftemp_output_buffer_show): New fun.
4587 (Fsave_window_excursion):
4588 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4590 * lread.c (lisp_file_lexically_bound_p): New function.
4591 (Fload): Bind Qlexical_binding.
4592 (readevalloop): Remove `evalfun' arg.
4593 Bind Qinternal_interpreter_environment.
4594 (Feval_buffer): Bind Qlexical_binding.
4595 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4597 (syms_of_lread): Declare `lexical-binding'.
4599 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4601 * keyboard.c (eval_dyn): New fun.
4602 (menu_item_eval_property): Use it.
4604 * image.c (parse_image_spec): Use Ffunctionp.
4606 * fns.c (concat, mapcar1): Accept byte-code-functions.
4608 * eval.c (Fsetq): Handle lexical vars.
4609 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4610 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4611 (FletX, Flet): Obey lexical binding.
4612 (Fcommandp): Handle closures.
4613 (Feval): New `lexical' arg.
4614 (eval_sub): New function extracted from Feval. Use it almost
4615 everywhere where Feval was used. Look up vars in lexical env.
4617 (Ffunctionp): Move from subr.el.
4618 (Ffuncall): Handle closures.
4619 (apply_lambda): Remove `eval_flags'.
4620 (funcall_lambda): Handle closures and new byte-code-functions.
4621 (Fspecial_variable_p): New function.
4622 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4623 but without exporting it to Lisp.
4625 * doc.c (Fdocumentation, store_function_docstring):
4626 * data.c (Finteractive_form): Handle closures.
4628 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4631 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4633 (exec_byte_code): New function extracted from Fbyte_code to handle new
4634 calling convention for byte-code-functions. Add new byte-codes.
4636 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4638 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4640 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4642 * xdisp.c (redisplay_internal): Fix prototype.
4644 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4646 * xdisp.c (SCROLL_LIMIT): New macro.
4647 (try_scrolling): Use it when setting scroll_limit.
4648 Limit scrolling to 100 screen lines.
4649 (redisplay_window): Even when falling back on "recentering",
4650 position point in the window according to scroll-conservatively,
4651 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4653 (try_scrolling): When point is above the window, allow searching
4654 as far as scroll_max, or one screenful, to compute vertical
4655 distance from PT to the scroll margin position. This prevents
4656 try_scrolling from unnecessarily failing when
4657 scroll-conservatively is set to a value slightly larger than the
4658 window height. Clean up the case of PT below the margin at bottom
4659 of window: scroll_max can no longer be INT_MAX. When aggressive
4660 scrolling is in use, don't let point enter the opposite scroll
4661 margin as result of the scroll.
4662 (syms_of_xdisp) <scroll-conservatively>: Document the
4663 threshold of 100 lines for never-recentering scrolling.
4665 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4667 * dispextern.h (move_it_by_lines):
4668 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4669 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4670 (message_log_check_duplicate): Remove parameters `prev_bol' and
4671 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4672 (redisplay_internal): Remove parameter `preserve_echo_area',
4673 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4675 * indent.c (Fvertical_motion):
4676 * window.c (window_scroll_pixel_based, Frecenter):
4677 Don't pass `need_y_p' to `move_it_by_lines'.
4679 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4681 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4682 steal a few bits to be more compact.
4683 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4684 Remove unneeded casts.
4686 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4688 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4690 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4691 binding" message (bug#7967).
4693 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4695 Fix more problems found by GCC 4.6.0's static checks.
4697 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4698 Remove unused local var.
4700 * editfns.c (Fmessage_box): Remove unused local var.
4702 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4703 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4704 Omit unused local vars.
4705 * window.c (shrink_windows): Omit unused local var.
4706 * menu.c (digest_single_submenu): Omit unused local var.
4707 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4708 Omit unused local var.
4710 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4711 Don't assume string length fits in int.
4712 (keyremap_step, read_key_sequence): Use size_t for sizes.
4713 (read_key_sequence): Don't check last_real_key_start redundantly.
4715 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4716 instead of alloca (Bug#8344).
4718 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4719 (Fbacktrace_frame): Don't assume nframes fits in int.
4721 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4723 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4726 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4728 * cm.c (calccost): Turn while-do into do-while, for clarity.
4730 * keyboard.c (syms_of_keyboard): Use the same style as later
4731 in this function when indexing through an array. This also
4732 works around GCC bug 48267.
4734 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4736 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4738 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4739 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4741 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4742 This avoids undefined behavior on integer overflow, and is a bit
4743 more convenient anyway since it is compared to a size_t variable.
4745 Variadic C functions now count arguments with size_t, not int.
4746 This avoids an unnecessary limitation on 64-bit machines, which
4747 caused (substring ...) to crash on large vectors (Bug#8344).
4748 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4749 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4750 All variadic functions and their callers changed accordingly.
4751 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4752 * data.c (arith_driver, float_arith_driver): Likewise.
4753 * editfns.c (general_insert_function): Likewise.
4754 * eval.c (struct backtrace.nargs, interactive_p)
4755 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4756 (funcall_lambda, mark_backtrace): Likewise.
4757 * fns.c (concat): Likewise.
4758 * frame.c (x_set_frame_parameters): Likewise.
4759 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4760 0 if not found, not -1. All callers changed.
4762 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4763 (stack_copy_size): Now size_t, not int.
4764 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4766 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4768 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4769 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4770 All callers changed.
4772 * lisp.h (multibyte_char_to_unibyte):
4773 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4774 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4775 * character.h (CHAR_TO_BYTE8):
4776 * cmds.c (internal_self_insert):
4777 * editfns.c (general_insert_function):
4778 * keymap.c (push_key_description):
4779 * search.c (Freplace_match):
4780 * xdisp.c (message_dolog, set_message_1): All callers changed.
4782 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4784 * keyboard.c (safe_run_hook_funcall): New function.
4785 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4786 don't set the hook to nil, but remove the offending function instead.
4787 (Qcommand_hook_internal): Remove, unused.
4788 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4789 Vcommand_hook_internal.
4791 * eval.c (enum run_hooks_condition): Remove.
4792 (funcall_nil, funcall_not): New functions.
4793 (run_hook_with_args): Call each function through a `funcall' argument.
4794 Remove `cond' argument, now redundant.
4795 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4796 (Frun_hook_with_args_until_failure): Adjust accordingly.
4797 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4799 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4801 * dispextern.h (string_buffer_position): Remove declaration.
4803 * print.c (strout): Remove parameter `multibyte', unused since
4804 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4806 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4807 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4808 All callers changed.
4810 * w32.c (_wsa_errlist): Use braces for struct initializers.
4812 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4813 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4814 All callers changed.
4815 (string_buffer_position): Likewise. Also, make static (it's never
4816 used outside xdisp.c).
4817 (cursor_row_p): Remove parameter `w', unused since
4818 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4819 (decode_mode_spec): Remove parameter `precision', introduced during
4820 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4821 All callers changed.
4823 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4825 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4827 2011-03-27 Anders Lindgren <andlind@gmail.com>
4829 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4830 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4831 (ns_update_auto_hide_menu_bar): New functions.
4832 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4833 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4834 ns_constrain_all_frames.
4835 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4836 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4838 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4840 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4842 2011-03-27 Glenn Morris <rgm@gnu.org>
4844 * syssignal.h: Replace RETSIGTYPE with void.
4845 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4846 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4847 Replace SIGTYPE with void everywhere.
4848 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4849 * s/template.h (SIGTYPE): Remove commented out definition.
4851 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4853 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4854 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4856 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4858 * w32.c (read_unc_volume): Use parameter `henum', instead of
4859 global variable `wget_enum_handle'.
4861 * keymap.c (describe_vector): Remove parameters `indices' and
4862 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4863 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4865 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4867 * keyboard.c (timer_check): Remove parameter `do_it_now',
4868 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4869 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4870 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4872 * keyboard.c (read_char):
4873 * w32menu.c (w32_menu_display_help):
4874 * xmenu.c (show_help_event, menu_help_callback):
4875 Adjust calls to `show_help_echo'.
4877 * gtkutil.c (xg_maybe_add_timer):
4878 * keyboard.c (readable_events):
4879 * process.c (wait_reading_process_output):
4880 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4882 * insdel.c (adjust_markers_gap_motion):
4883 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4884 (gap_left, gap_right): Don't call it.
4886 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4888 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4889 incurred during fontification.
4891 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4893 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4894 (DEFVAR_PER_BUFFER): Don't pass it.
4896 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4897 (scrolling_window): Don't pass it.
4899 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4901 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4903 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4905 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4906 of variables specific to SELinux and computation of `encoded_absname'.
4908 * image.c (XPutPixel): Remove unused variable `height'.
4910 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4912 * unexw32.c (get_section_info): Remove unused variable `section'.
4914 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4915 (system_process_attributes): Remove unused variable `sess'.
4916 (sys_read): Remove unused variable `err'.
4918 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4919 (w32_wnd_proc): Remove unused variable `isdead'.
4920 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4921 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4922 (x_create_tip_frame): Remove unused variable `tem'.
4924 * w32inevt.c (w32_console_read_socket):
4925 Remove unused variable `no_events'.
4927 * w32term.c (x_draw_composite_glyph_string_foreground):
4928 Remove unused variable `width'.
4930 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4932 * w32term.c (x_set_glyph_string_clipping):
4933 Don't pass uninitialized region to CombineRgn.
4935 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4937 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4938 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4939 (Fx_close_connection): Remove unused variable `i'.
4941 * w32font.c (w32font_draw): Return number of glyphs.
4942 (w32font_open_internal): Remove unused variable `i'.
4943 (w32font_driver): Add missing initializer.
4945 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4946 (fill_in_menu): Remove unused variable `items_added'.
4948 * w32term.c (last_mouse_press_frame): Remove static global variable.
4949 (w32_clip_to_row): Remove unused variable `f'.
4950 (x_delete_terminal): Remove unused variable `i'.
4952 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4953 (NOTHING): Remove unused static global variable.
4954 (uniscribe_check_otf): Remove unused variable `table'.
4955 (uniscribe_font_driver): Add missing initializers.
4957 2011-03-23 Julien Danjou <julien@danjou.info>
4959 * term.c (Fsuspend_tty, Fresume_tty):
4960 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4961 * window.c (temp_output_buffer_show):
4962 * insdel.c (signal_before_change):
4963 * frame.c (Fhandle_switch_frame):
4964 * fileio.c (Fdo_auto_save):
4965 * emacs.c (Fkill_emacs):
4966 * editfns.c (save_excursion_restore):
4967 * cmds.c (internal_self_insert):
4968 * callint.c (Fcall_interactively):
4969 * buffer.c (Fkill_all_local_variables):
4970 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4972 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4973 unconditionnaly since it does the check itself.
4975 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4977 Fix more problems found by GCC 4.5.2's static checks.
4979 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4980 the first time through the loop, since we know p0 < p1 then.
4981 This also avoids a gcc -Wstrict-overflow warning.
4983 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4984 leading to a memory leak, possible in functions like
4985 load_charset_map_from_file that can allocate an unbounded number
4986 of objects (Bug#8318).
4988 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4989 that could (at least in theory) be that large.
4991 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4992 This is less likely to overflow, and avoids undefined behavior if
4993 overflow does occur. All callers changed. Use strtoul to scan
4994 for the unsigned long integer.
4995 (pint2hrstr): Simplify and tune code slightly.
4996 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4998 * scroll.c (do_scrolling): Work around GCC bug 48228.
4999 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5001 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5002 This also avoids a warning with gcc -Wstrict-overflow.
5003 (validate_x_resource_name): Simplify count usage.
5004 This also avoids a warning with gcc -Wstrict-overflow.
5006 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5009 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5011 * process.c (Fmake_network_process): Use socklen_t, not int,
5012 where POSIX says socklen_t is required in portable programs.
5013 This fixes a porting bug on hosts like 64-bit HP-UX, where
5014 socklen_t is wider than int (Bug#8277).
5015 (Fmake_network_process, server_accept_connection):
5016 (wait_reading_process_output, read_process_output):
5019 * process.c: Rename or move locals to avoid shadowing.
5020 (list_processes_1, Fmake_network_process):
5021 (read_process_output_error_handler, exec_sentinel_error_handler):
5022 Rename or move locals.
5023 (Fmake_network_process): Define label "retry_connect" only if needed.
5024 (Fnetwork_interface_info): Fix pointer signedness.
5025 (process_send_signal): Add cast to avoid pointer signedness problem.
5026 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5027 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5029 Make tparam.h and terminfo.c consistent.
5030 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5031 Include tparam.h instead, since it declares them.
5032 * cm.h (PC): Remove extern decl; tparam.h now does this.
5033 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5034 * terminfo.c: Include tparam.h, to check interfaces.
5035 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5036 (tparam): Adjust signature to match interface in tparam.h;
5037 this removes some undefined behavior. Check that outstring and len
5038 are zero, which they always are with Emacs.
5039 * tparam.h (PC, BC, UP): New extern decls.
5041 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5042 (xftfont_open): Rename locals to avoid shadowing.
5044 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5045 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5046 (OTF_TAG_SYM): Omit macro if not needed.
5047 (ftfont_list): Remove unused local.
5048 (get_adstyle_property, ftfont_pattern_entity):
5049 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5050 Rename locals to avoid shadowing.
5052 * xfont.c (xfont_list_family): Mark var as initialized.
5054 * xml.c (make_dom): Now static.
5056 * composite.c (composition_compute_stop_pos): Rename local to
5058 (composition_reseat_it): Remove unused locals.
5059 (find_automatic_composition, composition_adjust_point): Likewise.
5060 (composition_update_it): Mark var as initialized.
5061 (find_automatic_composition): Mark vars as initialized,
5062 with a FIXME (Bug#8290).
5064 character.h: Rename locals to avoid shadowing.
5065 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5066 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5067 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5068 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5071 * textprop.c (property_change_between_p): Remove; unused.
5073 * intervals.c (interval_start_pos): Now static.
5075 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5077 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5078 Rename locals to avoid shadowing.
5080 * sound.c (wav_play, au_play, Fplay_sound_internal):
5081 Fix pointer signedness.
5082 (alsa_choose_format): Remove unused local var.
5083 (wav_play): Initialize a variable to 0, to prevent undefined
5084 behavior (Bug#8278).
5086 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5088 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5090 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5091 clobbering (Bug#8298).
5092 * sysdep.c (sys_subshell): Likewise.
5093 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5095 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5096 This should get cleaned up, so that child_setup has the
5097 same signature on all platforms.
5099 * callproc.c (call_process_cleanup): Now static.
5100 (relocate_fd): Rename locals to avoid shadowing.
5102 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5104 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5105 not to be necessary, and produces flickering.
5107 2011-03-20 Glenn Morris <rgm@gnu.org>
5109 * config.in: Remove file.
5111 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5113 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5114 are now in src/globals.h.
5115 (syms_of_minibuf): Remove spurious & from previous change.
5117 2011-03-20 Leo <sdl.web@gmail.com>
5119 * minibuf.c (completing-read-function): New variable.
5120 (completing-read-default): Rename from completing-read.
5121 (completing-read): Call completing-read-function.
5123 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5125 * xfaces.c (Fx_load_color_file):
5126 Read color file from absolute filename (bug#8250).
5128 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5130 * makefile.w32-in: Update dependencies.
5132 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5134 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5136 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5138 Fix more problems found by GCC 4.5.2's static checks.
5140 * process.c (make_serial_process_unwind, send_process_trap):
5141 (sigchld_handler): Now static.
5143 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5144 That way, the code declares only the vars that it needs.
5145 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5146 * s/cygwin.h (PTY_ITERATION): Likewise.
5147 * s/darwin.h (PTY_ITERATION): Likewise.
5148 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5150 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5151 * process.c (allocate_pty): Don't declare stb unless it's needed.
5153 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5154 (CONSTANTLIM): Remove; unused.
5155 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5156 Define only if needed.
5158 * unexelf.c (unexec): Name an expression,
5159 to avoid gcc -Wbad-function-cast warning.
5160 Use a different way to cause a compilation error if anyone uses
5161 n rather than nn, a way that does not involve shadowing.
5162 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5164 * deps.mk (unexalpha.o): Remove; unused.
5166 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5167 * unexec.h: New file.
5168 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5169 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5171 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5172 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5173 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5174 Change as necessary to match prototype in unexec.h.
5176 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5178 (back_comment, skip_chars): Mark vars as initialized.
5180 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5181 Rename locals to avoid shadowing.
5183 * lread.c (read1): Rewrite so as not to use empty "else".
5184 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5186 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5188 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5189 warning when compiling print.c.
5191 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5192 instead of using an uninitialized var.
5193 (font_sort_entities): Mark var as initialized.
5195 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5197 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5198 pointers to constants.
5199 (font_parse_fcname): Remove unused vars.
5200 (font_delete_unmatched): Now static.
5201 (font_get_spec): Remove; unused.
5202 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5203 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5204 Rename or move locals to avoid shadowing.
5206 * fns.c (require_nesting_list, require_unwind): Now static.
5207 (Ffillarray): Rename locals to avoid shadowing.
5209 * floatfns.c (domain_error2): Define only if needed.
5210 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5212 * alloc.c (mark_backtrace): Move decl from here ...
5213 * lisp.h: ... to here, so that it can be checked.
5215 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5216 (Fdefvar): Rewrite so as not to use empty "else".
5217 (lisp_indirect_variable): Name an expression,
5218 to avoid gcc -Wbad-function-cast warning.
5219 (Fdefvar): Rename locals to avoid shadowing.
5221 * callint.c (quotify_arg, quotify_args): Now static.
5222 (Fcall_interactively): Rename locals to avoid shadowing.
5223 Use const pointer when appropriate.
5225 * lisp.h (get_system_name, get_operating_system_release):
5226 Move decls here, to check interfaces.
5227 * process.c (get_operating_system_release): Move decl to lisp.h.
5228 * xrdb.c (get_system_name): Likewise.
5229 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5230 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5231 some of which prompt warnings from gcc -Wbad-function-cast.
5232 (Fformat_time_string, Fencode_time, Finsert_char):
5233 (Ftranslate_region_internal, Fformat):
5234 Rename or remove local vars to avoid shadowing.
5235 (Ftranslate_region_internal): Mark var as initialized.
5237 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5240 * lisp.h (eassert): Check that the argument compiles, even if
5241 ENABLE_CHECKING is not defined.
5243 * data.c (Findirect_variable): Name an expression, to avoid
5244 gcc -Wbad-function-cast warning.
5245 (default_value, arithcompare, arith_driver, arith_error): Now static.
5246 (store_symval_forwarding): Rename local to avoid shadowing.
5247 (Fmake_variable_buffer_local, Fmake_local_variable):
5248 Mark variables as initialized.
5249 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5251 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5252 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5253 Rename locals to avoid shadowing.
5254 (mark_stack): Move local variables into the #ifdef region where
5256 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5257 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5259 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5260 (GC_STRING_CHARS): Remove; not used.
5261 (Fmemory_limit): Cast sbrk's returned value to char *.
5263 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5264 avoids undefined behavior in theory.
5266 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5268 Use functions, not macros, for up- and down-casing (Bug#8254).
5269 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5270 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5271 to use the following functions instead of these macros.
5272 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5273 EMACS_INT, since callers assume the returned value fits in int.
5274 (upcase1): Likewise, for UPCASE_TABLE.
5275 (uppercasep, lowercasep, upcase): New static inline functions.
5276 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5277 the race-condition problem in the old DOWNCASE.
5279 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5280 Rename locals to avoid shadowing.
5281 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5282 (regex_compile, re_search_2, re_match_2_internal):
5283 Remove unused local vars.
5284 (FREE_VAR): Rewrite so as not to use empty "else",
5285 which gcc can warn about.
5286 (regex_compile, re_match_2_internal): Mark locals as initialized.
5287 (RETALLOC_IF): Define only if needed.
5288 (WORDCHAR_P): Likewise. This one is never needed, but is used
5289 only in a comment talking about a compiler bug, so put inside
5290 the #if 0 of that comment.
5291 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5292 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5295 * search.c (boyer_moore): Rename locals to avoid shadowing.
5296 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5297 (PREV_CHAR_BOUNDARY): Likewise.
5299 * search.c (simple_search): Remove unused var.
5301 * dired.c (compile_pattern): Move decl from here ...
5302 * lisp.h: ... to here, so that it can be checked.
5303 (struct re_registers): New forward decl.
5305 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5307 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5309 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5310 Rename locals to avoid shadowing.
5311 (Fvertical_motion): Mark locals as initialized.
5313 * casefiddle.c (casify_object, casify_region): Now static.
5314 (casify_region): Mark local as initialized.
5316 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5318 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5319 New macros, so that the caller can use some names other than
5320 gcpro1, gcpro2, etc.
5321 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5323 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5324 argument, for consistency with GCPRO2_VAR, etc: it is now the
5325 prefix of the variable, not the variable itself. All uses
5327 * dired.c (directory_files_internal, file_name_completion):
5328 Rename locals to avoid shadowing.
5330 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5331 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5332 dired.c's scmp function, had undefined behavior.
5333 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5334 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5335 * buffer.h: ... to here, because these macros use current_buffer,
5336 and the new implementation with inline functions needs to have
5337 current_buffer in scope now, rather than later when the macros
5339 (downcase, upcase1): New static inline functions.
5340 (DOWNCASE, UPCASE1): Reimplement using these functions.
5341 This avoids undefined behavior in expressions like
5342 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5343 from race conditions in accessing the global variables
5344 case_temp1 and case_temp2.
5345 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5346 * lisp.h (case_temp1, case_temp2): Remove their decls.
5347 * character.h (ASCII_CHAR_P): Move from here ...
5348 * lisp.h: ... to here, so that the inline functions mentioned
5351 * dired.c (directory_files_internal_unwind): Now static.
5353 * fileio.c (file_name_as_directory, directory_file_name):
5354 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5356 (file_name_as_directory): Use const pointers when appropriate.
5357 (Fexpand_file_name): Likewise. In particular, newdir might
5358 point at constant storage, so make it a const pointer.
5359 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5360 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5362 (Fset_file_times, Finsert_file_contents, auto_save_error):
5363 Rename locals to avoid shadowing.
5365 * minibuf.c (choose_minibuf_frame_1): Now static.
5366 (Ftry_completion, Fall_completions): Rename or remove locals
5369 * marker.c (bytepos_to_charpos): Remove; unused.
5371 * lisp.h (verify_bytepos, count_markers): New decls,
5372 so that gcc does not warn that these functions aren't declared.
5374 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5375 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5376 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5377 (copy_text): Remove unused local var.
5379 * filelock.c (within_one_second): Now static.
5380 (lock_file_1): Rename local to avoid shadowing.
5382 * buffer.c (fix_overlays_before): Mark locals as initialized.
5383 (fix_start_end_in_overlays): Likewise. This function should be
5384 simplified by using pointers-to-pointers, but that's a different
5386 (switch_to_buffer_1): Now static.
5387 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5388 (report_overlay_modification): Rename locals to avoid shadowing.
5390 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5391 Fix pointer signedness issue.
5392 (sys_subshell): Mark local as volatile if checking for lint,
5393 to suppress a gcc -Wclobbered warning that does not seem to be right.
5394 (MAXPATHLEN): Define only if needed.
5396 * process.c (serial_open, serial_configure): Move decls from here ...
5397 * systty.h: ... to here, so that they can be checked.
5399 * fns.c (get_random, seed_random): Move extern decls from here ...
5400 * lisp.h: ... to here, so that they can be checked.
5402 * sysdep.c (reset_io): Now static.
5403 (wait_for_termination_signal): Remove; unused.
5405 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5406 (copy_keymap_item, append_key, push_text_char_description):
5408 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5409 (DENSE_TABLE_SIZE): Remove; unused.
5410 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5411 (describe_map_tree):
5412 Rename locals to avoid shadowing.
5414 * keyboard.c: Declare functions static if they are not used elsewhere.
5415 (echo_char, echo_dash, cmd_error, top_level_2):
5416 (poll_for_input, handle_async_input): Now static.
5417 (read_char, kbd_buffer_get_event, make_lispy_position):
5418 (make_lispy_event, make_lispy_movement, apply_modifiers):
5419 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5420 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5421 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5422 (read_key_sequence, read_char): Mark locals as initialized.
5423 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5425 * keyboard.h (make_ctrl_char): New decl.
5426 (mark_kboards): Move decl here ...
5427 * alloc.c (mark_kboards): ... from here.
5429 * lisp.h (force_auto_save_soon): New decl.
5431 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5432 (DEFINE_DUMMY_FUNCTION): New macro.
5433 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5435 (main): Add casts to avoid warnings
5436 if GCC considers string literals to be constants.
5438 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5440 * dbusbind.c: Pointer signedness fixes.
5441 (xd_signature, xd_append_arg, xd_initialize):
5442 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5443 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5444 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5445 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5447 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5448 if GCC considers string literals to be constants.
5449 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5451 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5453 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5454 (print_preprocess, print_object): New macro to fix last change.
5456 * print.c (print_preprocess): Don't forget font objects.
5458 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5460 * emacs.c (USAGE3): Doc fixes.
5462 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5464 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5467 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5469 * lisp.h (VWindow_system, Qfile_name_history):
5470 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5471 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5472 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5474 * w32select.c: Don't #include "keyboard.h".
5475 (run_protected): Add extern declaration for waiting_for_input.
5477 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5478 * w32console.c (detect_input_pending, read_input_pending)
5479 (encode_terminal_code):
5480 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5481 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5482 (w32_system_caret_y, Qfile_name_history):
5483 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5484 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5485 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5486 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5487 * w32proc.c (Qlocal, report_file_error):
5488 * w32term.c (Vwindow_system, updating_frame):
5489 * w32uniscribe.c (initialized, uniscribe_font_driver):
5490 Remove unneeded extern declarations.
5492 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5494 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5496 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5498 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5499 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5500 These macros can no longer be used for assignment.
5502 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5503 Assign struct members directly, instead of using BUF_BEGV etc.
5504 (record_buffer_markers, fetch_buffer_markers): New functions for
5505 recording and fetching special buffer markers.
5506 (set_buffer_internal_1, set_buffer_temp): Use them.
5508 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5510 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5512 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5513 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5515 * xdisp.c (hscroll_window_tree):
5516 (reconsider_clip_changes): Use PT instead of BUF_PT.
5518 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5520 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5521 $(EMACS_ROOT)/lib/intprops.h.
5523 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5525 Fix more problems found by GCC 4.5.2's static checks.
5527 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5528 to unsigned char * to avoid compiler diagnostic.
5529 (xg_free_frame_widgets): Make it clear that a local variable is
5530 needed only if USE_GTK_TOOLTIP.
5531 (gdk_window_get_screen): Make it clear that this macro is needed
5532 only if USE_GTK_TOOLTIP.
5533 (int_gtk_range_get_value): New function, which avoids a diagnostic
5534 from gcc -Wbad-function-cast.
5535 (xg_set_toolkit_scroll_bar_thumb): Use it.
5536 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5537 diagnostic from gcc -Wbad-function-cast.
5538 (get_utf8_string, xg_get_file_with_chooser):
5539 Rename locals to avoid shadowing.
5540 (create_dialog): Move locals to avoid shadowing.
5542 * xgselect.c (xg_select): Remove unused var.
5544 * image.c (four_corners_best): Mark locals as initialized.
5545 (gif_load): Initialize transparent_p to zero (Bug#8238).
5546 Mark another local as initialized.
5547 (my_png_error, my_error_exit): Mark with NO_RETURN.
5549 * image.c (clear_image_cache): Now static.
5550 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5551 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5552 (x_edge_detection): Remove unnecessary cast that
5553 gcc -Wbad-function-cast diagnoses.
5554 (gif_load): Fix pointer signedness.
5555 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5556 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5558 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5560 Improve quality of tests for time stamp overflow.
5561 For example, without this patch (encode-time 0 0 0 1 1
5562 1152921504606846976) returns the obviously-bogus value (-948597
5563 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5564 reports time overflow. See
5565 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5566 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5567 * editfns.c: Include limits.h and intprops.h.
5568 (TIME_T_MIN, TIME_T_MAX): New macros.
5569 (time_overflow): Move earlier, to before first use.
5570 (hi_time, lo_time): New functions, for an accurate test for
5572 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5573 (Fget_internal_run_time): Don't assume time_t fits in int.
5574 (make_time): Use list2 instead of Fcons twice.
5575 (Fdecode_time): More accurate test for out-of-range times.
5576 (check_tm_member): New function.
5577 (Fencode_time): Use it, to test for out-of-range times.
5578 (lisp_time_argument): Don't rely on undefined left-shift and
5579 right-shift behavior when checking for time stamp overflow.
5581 * editfns.c (time_overflow): New function, refactoring common code.
5582 (Fformat_time_string, Fdecode_time, Fencode_time):
5583 (Fcurrent_time_string): Use it.
5585 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5586 * dired.c (make_time): Move to ...
5587 * editfns.c (make_time): ... here.
5588 * systime.h: Note the move.
5590 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5592 * fringe.c (update_window_fringes): Remove unused variables.
5594 * unexmacosx.c (copy_data_segment): Also copy __got section.
5597 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5599 * termcap.c [MSDOS]: Include "msdos.h".
5600 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5601 Constify `char *' arguments and their references according to
5602 prototypes in tparam.h.
5604 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5606 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5607 Adapt all references accordingly.
5609 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5611 2011-03-11 Tom Tromey <tromey@redhat.com>
5613 * buffer.c (syms_of_buffer): Remove obsolete comment.
5615 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5617 * termhooks.h (encode_terminal_code): Declare prototype.
5619 * msdos.c (encode_terminal_code): Don't declare prototype.
5621 * term.c (encode_terminal_code): Now external again, used by
5622 w32console.c and msdos.c.
5624 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5625 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5627 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5629 Fix some minor problems found by GCC 4.5.2's static checks.
5631 * fringe.c (update_window_fringes): Mark locals as initialized
5633 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5635 * alloc.c (mark_fringe_data): Move decl from here ...
5636 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5637 to check its interface.
5638 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5640 * fontset.c (free_realized_fontset): Now static.
5641 (Fset_fontset_font): Rename local to avoid shadowing.
5642 (fontset_font): Mark local as initialized.
5643 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5645 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5647 * xselect.c (x_disown_buffer_selections): Remove; not used.
5648 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5649 (x_own_selection, Fx_disown_selection_internal): Rename locals
5651 (x_handle_dnd_message): Remove local to avoid shadowing.
5653 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5654 so that the caller can use some name other than gcpro1.
5655 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5656 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5657 (Fx_backspace_delete_keys_p):
5658 Use them to avoid shadowing, and rename vars to avoid shadowing.
5659 (x_decode_color, x_set_name, x_window): Now static.
5660 (Fx_create_frame): Add braces to silence GCC warning.
5661 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5662 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5663 Remove unused locals.
5664 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5665 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5666 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5669 * xterm.h (x_mouse_leave): New decl.
5671 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5672 Remove unused functions.
5673 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5674 (x_calc_absolute_position): Now static.
5675 (XTread_socket): Don't define label "out" unless it's used.
5676 Don't declare local "event" unless it's used.
5677 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5678 unless they are used.
5679 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5680 (x_fatal_error_signal): Remove; not used.
5681 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5682 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5683 (x_error_catcher, x_connection_closed, x_error_handler):
5684 (x_error_quitter, xembed_send_message, x_iconify_frame):
5685 (my_log_handler): Rename locals to avoid shadowing.
5686 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5687 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5689 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5690 Rename or move locals to avoid shadowing.
5691 (tty_defined_color, merge_face_heights): Now static.
5692 (free_realized_faces_for_fontset): Remove; not used.
5693 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5694 does not deduce is never used uninitialized.
5695 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5696 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5698 * terminal.c (store_terminal_param): Now static.
5700 * xmenu.c (menu_highlight_callback): Now static.
5701 (set_frame_menubar): Remove unused local.
5702 (xmenu_show): Rename parameter to avoid shadowing.
5703 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5704 since they might point to immutable storage.
5705 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5706 since it's unused otherwise.
5708 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5709 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5710 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5711 avoids a gcc -Wuninitialized diagnostic.
5712 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5713 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5714 does not deduce are never used uninitialized.
5716 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5718 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5719 * window.c (window_loop, size_window):
5720 (run_window_configuration_change_hook, enlarge_window): Likewise.
5722 * window.c (display_buffer): Now static.
5723 (size_window): Mark variables that gcc -Wuninitialized
5724 does not deduce are never used uninitialized.
5725 * window.h (check_all_windows): New decl, to forestall
5726 gcc -Wmissing-prototypes diagnostic.
5727 * dispextern.h (bidi_dump_cached_states): Likewise.
5729 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5731 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5733 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5734 and to avoid gcc -Wuninitialized warning.
5735 (load_charset_map): Mark variables that gcc -Wuninitialized
5736 does not deduce are never used uninitialized.
5737 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5739 * coding.c (coding_set_source, coding_set_destination):
5740 Use "else { /* comment */ }" rather than "else /* comment */;"
5741 for clarity, and to avoid gcc -Wempty-body warning.
5742 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5743 a block, when the outer 'i' will do.
5744 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5745 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5746 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5747 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5748 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5749 Rename locals to avoid shadowing.
5750 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5751 * coding.c (emacs_mule_char, encode_invocation_designation):
5752 Now static, since they're not used elsewhere.
5753 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5754 (decode_coding_object, encode_coding_object, detect_coding_system):
5755 (decode_coding_emacs_mule): Mark variables that gcc
5756 -Wuninitialized does not deduce are never used uninitialized.
5757 (detect_coding_iso_2022): Initialize a local variable that might
5758 be used uninitialized. Leave a FIXME because it's not clear that
5759 this initialization is needed. (Bug#8211)
5760 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5761 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5762 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5763 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5764 Remove unused macros.
5766 * category.c (hash_get_category_set): Remove unused local var.
5767 (copy_category_table): Now static, since it's not used elsewhere.
5768 * character.c (string_count_byte8): Likewise.
5770 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5771 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5773 * chartab.c (copy_sub_char_table): Now static, since it's not used
5775 (sub_char_table_ref_and_range, char_table_ref_and_range):
5776 Rename locals to avoid shadowing.
5777 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5779 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5780 (BIDI_BOB): Remove unused macro.
5782 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5783 deduce are never used uninitialized.
5784 * term.c (encode_terminal_code): Likewise.
5786 * term.c (encode_terminal_code): Now static. Remove unused local.
5788 * tparam.h: New file.
5789 * term.c, tparam.h: Include it.
5790 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5791 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5792 Move these decls to tparam.h, and make them agree with what
5793 is actually in tparam.c. The previous trick of using incompatible
5794 decls in different modules does not conform to the C standard.
5795 All callers of tparam changed to use tparam's actual API.
5796 * tparam.c (tparam1, tparam, tgoto):
5797 Use const pointers where appropriate.
5799 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5800 * cm.h (struct cm): Likewise.
5801 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5802 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5803 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5804 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5805 (turn_on_face, init_tty): Likewise.
5806 * termchar.h (struct tty_display_info): Likewise.
5808 * term.c (term_mouse_position): Rename local to avoid shadowing.
5810 * alloc.c (mark_ttys): Move decl from here ...
5811 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5813 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5815 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5817 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5819 * search.c (compile_pattern_1): Remove argument regp, unused since
5820 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5821 (compile_pattern): Don't pass it.
5823 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5825 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5826 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5828 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5830 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5832 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5833 gdk_window_get_screen, gdk_window_get_geometry,
5834 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5835 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5836 (xg_get_pixbuf_from_pixmap): New function.
5837 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5838 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5839 Call xg_get_pixbuf_from_pixmap instead of
5840 gdk_pixbuf_get_from_drawable.
5841 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5842 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5843 (xg_check_special_colors): Use GtkStyleContext and its functions
5845 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5846 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5847 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5848 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5849 Call gtk_widget_get_preferred_size.
5850 (xg_frame_resized): gdk_window_get_geometry only takes 5
5852 (xg_win_to_widget, xg_event_is_for_menubar):
5853 Call gdk_x11_window_lookup_for_display.
5854 (xg_set_widget_bg): New function.
5855 (delete_cb): New function.
5856 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5857 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5858 (xg_set_background_color): Call xg_set_widget_bg.
5859 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5860 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5861 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5862 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5864 (update_frame_tool_bar): Call gtk_widget_hide.
5865 (xg_initialize): Use GDK_KEY_g.
5867 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5869 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5871 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5872 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5873 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5875 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5877 * w32xfns.c (select_palette): Check success of RealizePalette against
5878 GDI_ERROR, not zero.
5880 See ChangeLog.11 for earlier changes.
5886 Copyright (C) 2011 Free Software Foundation, Inc.
5888 This file is part of GNU Emacs.
5890 GNU Emacs is free software: you can redistribute it and/or modify
5891 it under the terms of the GNU General Public License as published by
5892 the Free Software Foundation, either version 3 of the License, or
5893 (at your option) any later version.
5895 GNU Emacs is distributed in the hope that it will be useful,
5896 but WITHOUT ANY WARRANTY; without even the implied warranty of
5897 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5898 GNU General Public License for more details.
5900 You should have received a copy of the GNU General Public License
5901 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.