1 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
3 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
4 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
6 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8 * image.c (imagemagick_filename_hint): Check for errors in the
11 2013-08-13 Eli Zaretskii <eliz@gnu.org>
13 * window.c (Fwindow_margins): Return nil when there's no marginal
14 area, as per the documented API.
16 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
17 Fmake_vector, as scroll bar's struct members are not all Lisp
18 objects now. This avoids crashes in GC.
20 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
21 bool, so its address could be taken.
23 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
25 * image.c (imagemagick_filename_hint): New function to possibly
26 apply `image-content-type-suffixes'.
27 (imagemagick_load_image): Use it.
29 2013-08-13 Eli Zaretskii <eliz@gnu.org>
31 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
32 if loading zlib failed.
34 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
36 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
37 2013-08-13 checkin below. Change bool to BOOL, rule is:
38 All Obj-C code uses BOOL, except for interfaces callable from C.
40 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
42 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
44 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
45 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
47 * w32term.h (struct scroll_bar): Convert fringe_extended_p
48 from Lisp_Object to bitfield. Adjust comment.
49 * w32term.c (x_scroll_bar_create): Adjust user.
50 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
51 * xterm.c (XTset_vertical_scroll_bar): Likewise.
53 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
54 to `unsigned int' when defining a bitfield.
56 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
58 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
60 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
62 * window.h (struct window): Convert left_margin_cols and
63 right_margin_cols from Lisp_Objects to integers. Adjust comment.
64 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
65 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
67 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
69 (showing_window_margins_p, update_window_line, update_frame_1):
70 * fringe.c (draw_fringe_bitmap_1):
71 * xdisp.c (window_box_width): Adjust users.
72 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
73 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
74 Use direct assignment.
75 (Fset_window_configuration, save_window_save, Fwindow_margins):
76 Convert Lisp_Object to integer and back where appropriate.
77 (Fset_window_margins): Adjust user. Return t if any margin
78 was actually changed, and mention this in docstring.
80 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
82 * syntax.c (forward_word):
83 * cmds.c (forward_char, backward_char): Mention the optional argument.
85 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
87 * window.h (struct window): Convert left_fringe_width
88 and right_fringe_width from Lisp_Objects to integers.
90 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
91 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
92 * window.c (wset_left_fringe_width, wset_right_fringe_width):
94 (make_window): Initialize new integer fields to -1.
95 (Fsplit_window_internal): Use direct assignment.
96 (Fset_window_configuration, save_window_save): Convert
97 Lisp_Object to integer and back where appropriate.
98 (Fset_window_fringes): Adjust user. Return t if any fringe
99 was actually changed, and mention this in docstring.
101 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
103 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
104 * nsfns.m (x_set_cursor_type):
105 * w32fns.c (x_set_cursor_type):
106 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
107 * xdisp.c (set_frame_cursor_types): ...but in common code.
109 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
111 * font.c (clear_font_cache): New function, stripped from...
112 (Fclear_font_cache): ...here, which now uses the function
113 above. Adjust comment.
114 * font.h (clear_font_cache): Add prototype.
115 * xfaces.c (clear_face_cache): Use clear_font_cache.
117 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
119 * window.c (Fset_window_start): Compare `w', not `window' because
120 `w' might not be equal to `window' after call to decode_live_window.
122 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
124 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
125 This fixes a problem introduced by the Bug#15035 patch
126 when using GPG. Reported by Herbert J. Skuhra.
128 2013-08-12 Eli Zaretskii <eliz@gnu.org>
130 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
131 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
134 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
136 * decompress.c (Fzlib_decompress_region): Support zlib
137 decompression, too, and rename.
139 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
141 Minor zlib configuration tweaks.
142 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
143 Don't assume presence of fn_inflateInit2_ zlib internal function.
145 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
147 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
148 include the zlib prefix.
150 2013-08-12 Eli Zaretskii <eliz@gnu.org>
152 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
153 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
154 define static variables that are pointers to zlib functions to be
156 (init_zlib_functions) [WINDOWSNT]: New function.
157 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
159 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
160 macros instead of invoking the zlib functions directly.
161 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
164 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
166 Avoid looping over all frame windows to freeze and unfreeze.
167 * window.h (struct window): Drop frozen_window_start_p.
168 (freeze_window_starts): Drop prototype.
169 * frame.h (struct frame): New frozen_window_starts flag.
170 (FRAME_WINDOWS_FROZEN): New macro.
171 * window.c (freeze_window_start, freeze_window_starts):
173 (select_window, replace_window): Adjust users.
174 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
175 (window_frozen_p): New function.
176 (redisplay_window): Use it.
178 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
180 Fix some fd issues when running subprocesses (Bug#15035).
181 Fix bugs that can leak files or file descriptors on errors.
182 Don't unlink open temp files, as that's hard for users to diagnose
183 when things go awry (e.g., temp disk exhausted).
184 Don't bother to lock temp files. Check for invalid recursion.
185 * callproc.c (synch_process_fd): Remove. All uses removed.
186 (synch_process_tempfile): New var or macro.
187 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
189 (record_kill_process): New arg, the temp name. All callers changed.
190 (delete_temp_file): Now just a simple wrapper around unlink.
191 (call_process_kill): New arg, the call_process_fd array.
192 Close them all. Clear synch_process_pid. Remove the temp file,
193 or arrange for it to be removed.
194 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
195 that's been moved to synch_process_tempfile. Caller changed.
196 Do not remove the tempfile; that's now call_process_kill's
198 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
199 call_process_kill; the caller now does that.
200 (call_process_cleanup): Do not close the process fd; that's now
201 call_process_kill's responsibility.
202 (Fcall_process): Implement via new function call_process, which
203 has most of the old body of Fcall_process, but with a different API.
204 (call_process): New function that does not open or close filefd if
205 it is nonnegative. Record which fds need to be closed, and let
206 call_process_kill close (and remove the tempfile, on MSDOS) on error.
207 Signal an error if invoked recursively (could be done via a hook).
208 Simplify creation of the tempfile in the MSDOS case.
209 Don't create the output file until after checking for the executable.
210 Report any failure to open /dev/null.
211 Don't open /dev/null for writing twice; once is enough.
212 Don't create pipe if all output is being discarded or sent to file.
213 Don't worry about setting up the coding system or reading from the
214 pipe if all output is being discarded.
215 Hoist fd_error local into top level, to lessen block nesting.
216 Don't record deleted pid here; now done by Fcall_process_region.
217 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
218 and note its success in synch_process_tempfile.
219 Do not leak resources when child_setup fails.
220 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
221 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
222 (create_temp_file): Now returns open fd, with an additional
223 Lisp_Object * argument to return the name. All callers changed.
224 Do not close the file; rewind it instead, and leave it open for
225 the caller. Do not lock the temp file. Unwind-protect the file
226 and the file-descriptor.
227 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
228 If an asynchrounous process, record it here, not in call_process.
229 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
230 * eval.c (set_unwind_protect): New function.
231 * fileio.c (write_region): New function, generalized from the
232 old Fwrite_region. Do not lock temp files.
233 (Fwrite_region): Use it.
234 * lisp.h (set_unwind_protect, write_region): New decls.
235 * process.c: Include <verify.h>.
236 (make_process): Mark fds as initially closed.
237 (deleted_pid_list): Now a list of pid-filename pairs.
239 (close_process_fd): New function.
240 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
241 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
242 New constants. Verify that their number matches PROCESS_OPEN_FDS.
243 (create_process, create_pty, Fmake_serial_process)
244 (server_accept_connection): Record which fds need to be closed,
245 and let deactivate_process close them.
246 (Fmake_network_process): Do not discard the unwind-protect
247 until it's safe to do so.
248 (deactivate_process): Close the fds opened by create_process etc.
249 (Fprocess_send_eof): Adjust to new way of recording open fds.
250 Report an error if /dev/null can't be opened, instead of aborting.
251 * process.h (PROCESS_OPEN_FDS): New constant.
252 (struct Lisp_Process): New member open_fds.
253 (record_kill_process, record_deleted_pid): Adjust signatures.
254 (record_deleted_pid): Move decl here ...
255 * syswait.h (record_deleted_pid): ... from here.
257 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
259 * decompress.c: Fix bugs with large buffers and weird inputs.
260 Tune a bit. Reindent as per usual Emacs style.
261 (BUFFER_SIZE): Remove.
262 (Fdecompress_gzipped_region): Do not mishandle input buffers with
263 more than UINT_MAX bytes. Decompress into the gap instead of into
264 an auto buffer, as this should avoid copying. Return nil if
265 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
266 set immediate_quit; we shouldn't trust zlib code that much.
268 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
270 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
271 errors, and really move the gap to where we want it.
273 * lisp.h: Include decompress.c support.
275 * emacs.c (main): Include decompress.c support.
277 * Makefile.in: Include -lz if present.
279 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
281 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
282 (initWithTitle:): Initialize frame to 0.
283 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
284 (fillWithWidgetValue:frame:): Renamed from
285 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
287 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
288 fillWithWidgetValue:frame:
290 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
291 remove memory leak warnings.
293 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
294 (ns_check_menu_open): Handle menu == nil. Remove assignment to
297 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
298 (x_activate_menubar): Update the whole menu.
299 (trackingNotification:): Call ns_check_menu_open if tracking ends.
300 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
301 current event is not NSSystemDefined (Bug#15001).
302 Call ns_check_menu_open only if trackingMenu is 2.
303 (menuDidClose:): New method, decrease trackingMenu.
304 (fillWithWidgetValue:setDelegate:): New method.
305 (fillWithWidgetValue:): Call the above.
307 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
309 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
311 Omit some unnecessary casts.
312 Many of these go back to the old pre-C89 days, when they may have
313 been needed, but we've been assuming C89 or later for a while now.
314 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
315 (live_float_p, live_misc_p, live_vector_p):
316 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
317 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
319 * callint.c (Fcall_interactively):
320 * doc.c (Fsubstitute_command_keys):
321 * filelock.c (get_boot_time):
322 * frame.c (xrdb_get_resource):
323 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
324 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
325 (xg_get_file_name_from_selector, menuitem_destroy_callback)
326 (menuitem_highlight_callback, menu_destroy_callback)
327 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
328 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
329 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
330 (xg_tool_bar_help_callback, tb_size_cb):
331 * image.c (xpm_alloc_color, png_read_from_memory)
332 (png_read_from_file, png_load_body, our_memory_skip_input_data)
333 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
335 * keymap.c (describe_map):
336 * nsfns.m (Fns_display_monitor_attributes_list):
337 * nsmenu.m (process_dialog:):
338 * nsterm.m (hold_event):
339 * process.c (wait_reading_process_output):
340 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
341 * scroll.c (do_direct_scrolling, scrolling_1):
342 * termcap.c (tgetent):
343 * window.c (check_window_containing, add_window_to_list)
344 (freeze_window_starts):
345 * xdisp.c (compare_overlay_entries, vmessage):
346 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
347 (x_get_monitor_attributes_xrandr)
348 (Fx_display_monitor_attributes_list, x_display_info_for_name)
349 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
350 * xfont.c (xfont_match, xfont_open):
351 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
352 (menubar_selection_callback, menu_position_func)
353 (popup_selection_callback, create_and_show_popup_menu)
354 (dialog_selection_callback, create_and_show_dialog):
355 * xrdb.c (x_get_string_resource):
357 * xsmfns.c (x_session_check_input):
358 * xterm.c (x_draw_glyphless_glyph_string_foreground)
359 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
360 (xaw_jump_callback, xaw_scroll_callback):
361 Omit unnecessary casts.
363 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
365 Minor string-length refactoring.
366 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
367 * frame.c (make_monitor_attribute_list):
368 Prefer build_string to strlen + make_string.
370 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
372 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
373 don't check minor_code (Bug#14417).
375 2013-08-09 Eli Zaretskii <eliz@gnu.org>
377 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
378 vertical positions instead. This avoids calling MATRIX_ROW with
379 row numbers that are possibly beyond valid limits. (Bug#15064)
381 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
383 Use xstrdup and build_unibyte_string where applicable.
384 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
386 * xrdb.c (x_get_customization_string):
387 * xterm.c (xim_initialize):
388 * w32fns.c (w32_window): Use xstrdup.
389 (w32_display_monitor_attributes_list):
390 * emacs.c (init_cmdargs):
391 * keyboard.c (PUSH_C_STR):
392 * nsfont.m (nsfont_open):
393 * sysdep.c (system_process_attributes):
394 * w32.c (system_process_attributes):
395 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
397 2013-08-09 Eli Zaretskii <eliz@gnu.org>
399 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
400 variables of these types so that GDB would know about them, as aid
401 for debugging fatal exceptions. (Bug#15024) See also
402 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
405 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
407 * nsterm.m (ns_update_begin): Don't change clip path if it would be
408 larger than the NSWindow (Bug#14934).
410 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
412 Redesign redisplay interface to drop global variable updated_window.
413 Always pass currently updated window as a parameter to update routines.
414 * dispextern.h (updated_window): Remove declaration.
415 (struct redisplay_interface): Pass window parameter to
416 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
417 and after_update_window_hook.
418 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
420 * dispnew.c (updated_window): Remove.
421 (redraw_overlapped_rows, update_marginal_area, update_text_area)
422 (update_window_line): Adjust to match redisplay interface changes.
423 * nsterm.m (ns_update_window_begin, ns_update_window_end)
424 (ns_scroll_run, ns_after_update_window_line):
425 * w32term.c (x_update_window_begin, x_update_window_end)
426 (x_after_update_window_line, x_scroll_run):
427 * xterm.c (x_update_window_begin, x_update_window_end)
428 (x_after_update_window_line, x_scroll_run):
429 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
430 Likewise. Adjust comments where appropriate.
431 (x_cursor_to): Simplify because this is always called during window
432 update (but install debugging check anyway).
433 (expose_window): Check must_be_updated_p flag to see whether this
434 function is called during window update.
436 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
438 Do not reset window modification event counters excessively.
439 These leftovers and poor man's tricky methods to catch extra
440 redisplay's attention are no longer needed.
441 * frame.c (set_menu_bar_lines_1):
442 * minibuf.c (read_minibuf_unwind):
443 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
444 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
445 (window_scroll_line_based, Fset_window_configuration):
446 * xdisp.c (redisplay_window): Do not reset last_modified and
447 last_overlay_modified counters.
449 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
451 * xselect.c (x_send_client_event): Set send_event and serial, memset
452 data.l as it might be bigger than data.b. Use 24 bit mask to
453 XSendEvent (Bug#15034).
455 2013-08-07 Eli Zaretskii <eliz@gnu.org>
457 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
458 for TTY frames that are not the top frame on their console.
461 2013-08-07 Martin Rudalics <rudalics@gmx.at>
463 * w32term.c (w32fullscreen_hook): Really maximize frame when
464 asked for (Bug#14841).
466 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
468 Prefer selected_window to Fselected_window, likewise for frames.
469 * buffer.c (Fbuffer_swap_text):
470 * data.c (Fvariable_binding_locus):
471 * window.c (run_window_configuration_change_hook): Adjust users.
472 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
473 Use decode_live_frame.
475 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
477 Be more careful if selected window shows the buffer other than current,
478 use window_outdated only if this is not so. This change should also
479 address some weird issues discussed in Bug#13012.
480 * window.h (window_outdated): New prototype.
481 * window.c (window_outdated): Now here. Convert from static and
482 always assume window's buffer.
483 (Fwindow_end, Fwindow_line_height): Use it.
484 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
485 and always assume window's buffer.
486 (redisplay_window): Adjust user.
487 (redisplay_internal): Call to reconsider_clip_changes once and
488 check whether mode line should be updated only if selected window
489 shows current buffer.
490 (run_window_scroll_functions): Use eassert for debugging check.
491 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
493 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
495 * window.c (window_scroll, window_scroll_pixel_based)
496 (window_scroll_line_based): Use bool for booleans.
498 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
500 * process.c: Fix minor off-by-one issues in descriptor counts.
501 This shouldn't fix any real bugs, but it cleans up the code a bit.
502 (max_process_desc, max_input_desc): -1, not 0, means none.
504 (delete_input_desc): New function.
505 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
506 (deactivate_process): Scan backwards when recomuting max_process_desc;
507 that should be faster.
508 (init_process_emacs): Initialize max_input_desc.
510 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
512 Use region cache to speedup bidi_find_paragraph_start.
513 * buffer.h (struct buffer): New member bidi_paragraph_cache.
514 Rename cache_long_line_scans to cache_long_scans.
515 * buffer.c (bset_cache_long_line_scans): Rename to
516 bset_cache_long_scans.
517 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
518 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
520 (syms_of_buffer): Rename cache-long-line-scans to
521 cache-long-scans. Adjust docstring.
522 * search.c (newline_cache_on_off):
523 * indent.c (width_run_cache_on_off): Adjust users.
524 * bidi.c (bidi_paragraph_cache_on_off): New function.
525 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
526 * insdel.c (prepare_to_modify_buffer): Invalidate
527 bidi_paragraph_cache if enabled.
529 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
531 Invalidate region caches only if buffer text is going to be changed.
532 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
533 (modify_text): ...new prototype.
534 (prepare_to_modify_buffer_1): New prototype.
535 * textprop.c (modify_region): Rename to...
536 (modify_text_properties): ...new function.
537 (add_text_properties_1, set_text_properties, Fremove_text_properties)
538 (Fremove_list_of_text_properties): Adjust users.
539 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
540 (modify_text): ...new function.
541 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
542 (prepare_to_modify_buffer_1): ...new function.
543 * casefiddle.c (casify_region):
544 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
545 (Ftranspose_regions): Use modify_text.
547 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
549 * lisp.mk (lisp): Add nadvice.elc.
551 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
553 New macro to iterate over live buffers similar to frames.
554 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
555 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
556 Declare buffer-related variables here to offload lisp.h.
557 * buffer.c (Vbuffer_alist): Adjust comment.
558 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
559 (other_buffer_safely):
560 * data.c (store_symval_forwarding):
561 * dispnew.c (Fframe_or_buffer_changed_p):
562 * fileio.c (Fdo_auto_save):
563 * filelock.c (unlock_all_files):
564 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
566 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
568 Fix some minor races in hosts lacking mkostemp (Bug#15015).
569 * callproc.c (create_temp_file):
570 * filelock.c (create_lock_file):
571 Assume mkostemp, since it's now provided by Gnulib.
573 2013-08-04 Eli Zaretskii <eliz@gnu.org>
575 * w32.c (mkostemp): New function.
576 (mktemp): Remove, no longer used. Most of the code reused in
577 mkostemp. (Bug#15015)
578 (mktemp): Don't undef.
580 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
582 * dispnew.c (glyph_matrix_count, glyph_pool_count):
583 Move under GLYPH_DEBUG and ENABLE_CHECKING.
584 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
585 (free_glyph_pool, check_glyph_memory): Likewise for
586 all users. Adjust comments where appropriate.
588 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
590 * composite.h: Minor fixups.
591 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
592 to fix a misspelling, and change it to an inline function while
593 we're at it (it need not be a macro). All uses changed.
594 (composition_method, composition_valid_p):
595 Rewrite to avoid assignments in if-conditions.
597 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
599 Do not use global Lisp_Object in composition macros.
600 * composite.h (composition_temp): Remove declaration.
601 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
602 (composition_method, composition_valid_p): ...inline functions.
603 (compose_region): Remove the leftover.
604 * composite.c (composition_temp): Remove.
605 (run_composition_function, update_compositions)
606 (composition_compute_stop_pos, composition_adjust_point)
607 (Ffind_composition_internal):
608 * coding.c (handle_composition_annotation):
609 * xdisp.c (handle_composition_prop, check_point_in_composition):
610 Related users changed.
612 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
614 Drop FRAME_PTR typedef.
615 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
616 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
617 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
618 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
619 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
620 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
621 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
622 All related users changed.
624 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
626 * eval.c (default_toplevel_binding): New function.
628 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
629 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
630 (syms_of_eval): Export them.
631 * data.c (Fdefault_value): Micro cleanup.
632 * term.c (init_tty): Use "false".
634 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
636 Fix X GC leak in GTK and raw (no toolkit) X ports.
637 * xterm.c (x_free_frame_resources): If white and black relief
638 GCs are allocated, always free them here.
639 * xfns.c (x_make_gc): Omit redundant initialization.
640 * widget.c (create_frame_gcs): Remove the leftover.
641 (EmacsFrameDestroy): Do nothing because all GCs are now freed
642 in x_free_frame_resources.
644 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
646 * nsterm.m (windowWillResize:toSize:): Only change title if
647 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
649 (viewDidEndLiveResize): New method.
651 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
652 inside NS_IMPL_COCOA.
654 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
656 * insdel.c (adjust_after_replace, replace_range, del_range_2):
657 Do not check whether undo is enabled because record_insert and
658 record_delete does that themselves.
660 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
662 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
663 member which is not really used any more.
664 (FRAME_XIC_BASE_FONTNAME): Remove.
665 * xfns.c (xic_free_fontset): Adjust user.
666 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
667 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
668 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
669 (xdialog_show): Use eassert for debugging check.
670 * w32term.c (x_unfocus_frame): Remove unused dummy function.
672 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
674 * fileio.c, fns.c (merge): Move extern decl from here ...
675 * lisp.h (merge): ... to here.
677 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
679 Fix last font-related change.
680 * w32font.h (w32font_list_internal, w32font_match_internal):
682 * w32uniscribe.c (uniscribe_list, uniscribe_match):
683 (uniscribe_list_family): Adjust to match font API change.
684 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
685 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
687 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
689 * frame.h (FRAME_MOUSE_UPDATE):
690 * nsterm.m (ns_frame_up_to_date): Omit redundant check
691 whether hlinfo->mouse_face_mouse_frame is non-NULL.
693 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
695 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
696 * font.h (struct font_driver): Change list, match, and list_family
697 functions to accept struct frame * as first arg.
698 * font.c (font_score, font_compare, font_sort_entities): Remove
700 (font_sort_entities, font_list_entities, font_select_entity):
701 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
702 match font API change.
703 * xfont.c (xfont_list, xfont_match, xfont_list_family):
704 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
705 * ftxfont.c (ftxfont_list, ftxfont_match):
706 * xftfont.c (xftfont_list, xftfont_match):
707 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
708 * w32font.c (w32font_list, w32font_match, w32font_list):
709 (w32font_list_internal, w32_font_match_internal): Likewise.
710 * xfaces.c (Fx_family_fonts): Adjust user.
712 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
714 Do not use pure Xism x_wm_set_icon_position in non-X ports.
715 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
716 only if HAVE_X_WINDOWS is in use.
717 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
718 * nsterm.m (x_wm_set_icon_position): Remove no-op.
719 * w32term.c (x_wm_set_icon_position): Likewise.
720 * w32fns.c (x_icon): Adjust user.
722 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
724 * xterm.c (last_mouse_press_frame): Remove the
725 leftover which is not really used any more.
726 (handle_one_xevent, syms_of_xterm): Adjust users.
727 (x_flush): Call XFlush once per each X display, not frame.
728 This is better because this code always unconditionally skips
729 non-X frames in Vframe_list and issues the only XFlush if we
730 have more than one X frame on the same X display.
731 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
732 Use bool for booleans.
733 (x_draw_glyph_string_background, cvt_string_to_pixel):
734 (cvt_pixel_dtor): Drop unnecessary prototypes.
735 * xterm.h (x_display_ok): Adjust prototype.
737 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
739 Drop unnecessary functions that deals with frame pixel size.
740 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
741 (x_pixel_height): Drop prototypes.
742 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
743 (x_pixel_height): Drop implementations.
744 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
745 which should be always valid for window frame.
746 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
747 * w32menu.c (Fx_popup_dialog):
748 * xmenu.c (Fx_popup_dialog): Likewise for both.
750 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
752 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
753 frame parameters and call to Fmodify_frame_parameters just once.
754 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
755 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
756 and mention nil frame in docstring.
758 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
760 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
761 (x_figure_window_size): Likewise. Adjust to return long.
762 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
763 (toplevel): Move Qterminal_live_p to...
764 * terminal.c (toplevel): ...here, make it static, and...
765 (syms_of_terminal): ...DEFSYM here.
766 * frame.h (Qterminal_live_p): Remove declaration.
767 (make_frame, x_figure_window_size): Adjust prototype.
768 * nsfns.m (Fx_create_frame): Use long for window flags.
770 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
772 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
773 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
774 Do not assume that emacs_close (INT_MAX) is a no-op.
776 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
778 * xfaces.c (make_face_cache): For struct face_cache, prefer
779 xmalloc to xzalloc and so avoid redundant call to memset.
780 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
782 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
784 * fringe.c (draw_window_fringes, update_window_fringes)
785 (compute_fringe_widths):
786 * w32term.c (x_draw_glyph_string):
787 * window.c (candidate_window_p, Frecenter):
788 * xfaces.c (realize_basic_faces, realize_default_face)
789 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
790 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
791 * xfns.c (x_set_cursor_color, xic_free_xfontset):
792 * xmenu.c (Fx_menu_bar_open_internal):
793 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
794 * xsettings.c (xft_settings_event):
795 * xterm.c (x_draw_glyph_string, x_had_errors_p):
796 Use bool for booleans. Adjust style and comments where
798 * dispextern.h (draw_window_fringes, update_window_fringes)
799 (compute_fringe_widths):
800 * xterm.h (x_had_errors_p): Adjust prototype.
802 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
804 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
805 CHECK_LIST. Rewrite the loop to avoid useless local variable.
807 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
809 * fns.c (toplevel): Remove comment before Fsafe_length because
812 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
814 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
816 2013-07-28 Eli Zaretskii <eliz@gnu.org>
818 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
819 frame which got the message is still alive, before dereferencing
820 its pointer. (Bug#14970)
822 * frame.c (delete_frame): Test "this" frame's minibuffer window to
823 be a live window, before using it as such. (Bug#14970)
825 2013-07-27 Eli Zaretskii <eliz@gnu.org>
827 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
828 w32_detect_focus_change instead of doing part of its job by hand.
829 This fixes the problem whereby FOCUS_OUT events were not sent to
832 2013-07-26 Eli Zaretskii <eliz@gnu.org>
834 * process.c (Fprocess_list): Doc fix.
836 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
837 being re-exposed only if it didn't ask to become visible.
838 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
839 was previously iconified. (Bug#14841)
840 (x_iconify_frame): Mark the frame iconified.
842 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
844 Fix minor problems found by static checking.
845 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
846 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
848 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
850 * eval.c (set_specpdl_old_value): New function.
851 (unbind_to): Minor simplification.
852 (get_backtrace_frame): New function.
853 (Fbacktrace_frame): Use it. Add `base' argument.
854 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
855 (syms_of_eval): Export backtrace-eval.
856 * xterm.c (x_focus_changed): Simplify.
858 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
860 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
862 2013-07-24 Eli Zaretskii <eliz@gnu.org>
864 * xdisp.c (redisplay_window): Instead of moving point out of
865 scroll margin, reject the force_start method, and try scrolling
868 2013-07-24 Ken Brown <kbrown@cornell.edu>
870 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
873 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
875 * eval.c (Fprogn): Do not check that BODY is a proper list.
876 This undoes the previous change. The check slows down the
877 interpreter, and is not needed to prevent a crash. See
878 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
880 2013-07-23 Glenn Morris <rgm@gnu.org>
882 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
884 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
886 Port to GNU/Linux systems with tinfo but not ncurses.
887 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
888 to decide whether ncurses is being used. Without this change,
889 GCC complains about tgetent not being declared, on a system
890 that has tinfo installed but ncurses not installed.
892 * eval.c (Fprogn): Check that BODY is a proper list.
894 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
895 * data.c (Fsetq_default):
896 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
897 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
899 Tune by taking advantage of the fact that ARGS is always a list
900 when a function is declared to have UNEVALLED args.
902 * emacsgtkfixed.c: Port to GCC 4.6.
903 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
905 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
907 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
908 here to silence compiler warnings.
910 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
912 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
913 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
914 from messing up Emacs's 'struct frame' (Bug#14923).
916 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
918 * alloc.c (make_save_ptr_ptr): Define this function.
919 It was inadvertently omitted. It's needed only if
920 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
922 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
924 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
925 frame have focus (Bug#14895).
927 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
929 Avoid vfork-related deadlock more cleanly.
930 * callproc.c (child_setup): When the child's exec fails, output
931 the program name, as that's more useful. Use O_NONBLOCK to avoid
933 * process.c (create_process_1): Remove; no longer needed.
934 (create_process): Remove timer hack; no longer needed, now that
935 the child avoids deadlock.
937 2013-07-20 Glenn Morris <rgm@gnu.org>
939 * image.c (Fimage_flush): Fix doc typo.
941 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
943 Fix array bounds violation when pty allocation fails.
944 * process.c (PTY_NAME_SIZE): New constant.
945 (pty_name): Remove static variable; it's now auto.
946 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
947 Take pty_name as an arg rather than using a static variable.
949 (create_process): Recover pty_flag from process, not from volatile local.
950 (create_pty): Stay inside array even when pty allocation fails.
951 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
953 * lread.c (Fload): Avoid initialization only when lint checking.
954 Mention that it's needed only for older GCCs.
956 2013-07-20 Kenichi Handa <handa@gnu.org>
958 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
959 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
961 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
963 * lread.c (Fload): Avoid uninitialized warning.
965 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
967 Fix some minor file descriptor leaks and related glitches.
968 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
969 (create_lock_file): Use write, not emacs_write.
970 * image.c (slurp_file, png_load_body):
971 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
972 (server_accept_connection):
973 Don't leak an fd on memory allocation failure.
974 * image.c (slurp_file): Add a cheap heuristic for growing files.
975 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
976 as that's what the other routines do. Maybe input need not be
977 blocked at all, but it's better to be consistent.
978 Avoid undefined behavior when strlen is zero.
980 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
981 (NSTATICS): Now a constant; doesn't need to be a macro.
983 2013-07-19 Richard Stallman <rms@gnu.org>
985 * coding.c (decode_coding_utf_8): Add simple loop for fast
986 processing of ASCII characters.
988 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
990 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
992 2013-07-19 Eli Zaretskii <eliz@gnu.org>
994 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
995 unportable 'struct x_display_info'.
996 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
999 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1001 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1002 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1004 (system_process_attributes): Prefer plain char to unsigned char
1005 when either will do. Clean up properly if interrupted or if
1006 memory allocations fail. Don't assume sscanf succeeds. Remove
1007 no-longer-needed workaround to stop GCC from whining. Read
1008 command-line once, instead of multiple times. Check read status a
1011 Fix obscure porting bug with varargs functions.
1012 The code assumed that int is treated like ptrdiff_t in a vararg
1013 function, which is not a portable assumption. There was a similar
1014 -- though these days less likely -- porting problem with various
1015 assumptions that pointers of different types all smell the same as
1016 far as vararg functions is conserved. To make this problem less
1017 likely in the future, redo the API to use varargs functions.
1018 * alloc.c (make_save_value): Remove this vararg function.
1019 All uses changed to ...
1020 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1021 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1023 (make_save_ptr): Rename from make_save_pointer, for consistency with
1024 the above. Define only on platforms that need it. All uses changed.
1026 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1028 * keyboard.c: Try to fix typos in previous change.
1029 (DISPLAY_LIST_INFO): New macro.
1030 (kbd_buffer_get_event): Do not access members that are not present
1031 in X11. Revert inadvertent change of "!=" to "=".
1033 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1035 * keyboard.c (kbd_buffer_get_event):
1036 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1037 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1039 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1041 * filelock.c: Fix unlikely file descriptor leaks.
1042 (get_boot_time_1): Rework to avoid using emacs_open.
1043 This doesn't actually fix a leak, but is better anyway.
1044 (read_lock_data): Use read, not emacs_read.
1046 * doc.c: Fix minor memory and file descriptor leaks.
1047 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1048 (get_doc_string, Fsnarf_documentation):
1049 Fix file descriptor leak on error.
1051 * term.c: Fix minor fdopen-related file descriptor leaks.
1052 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1053 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1055 * charset.c: Fix file descriptor leaks and errno issues.
1057 (load_charset_map_from_file): Don't leak file descriptor on error.
1058 Use plain record_xmalloc since the allocation is larger than
1059 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1061 * eval.c (record_unwind_protect_nothing):
1062 * fileio.c (fclose_unwind):
1064 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1065 The replacement doesn't block input, but that no longer seems
1068 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1070 * lread.c: Fix file descriptor leaks and errno issues.
1071 (Fload): Close some races that leaked fds or streams when 'load'
1073 (Fload, openp): Report error number of last nontrivial failure to open.
1074 ENOENT counts as trivial.
1075 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1077 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1078 now that the function is always called with a nonnegative arg.
1079 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1080 All uses replaced with ...
1081 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1083 A few more minor file errno-reporting bugs.
1084 * callproc.c (Fcall_process):
1085 * doc.c (Fsnarf_documentation):
1086 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1087 * process.c (set_socket_option):
1088 Don't let a constructor trash errno.
1089 * doc.c: Include <errno.h>.
1091 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1093 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1095 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1097 Fix w32 bug with call-process-region (Bug#14885).
1098 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1099 to Fcall_process when the input is empty. This simplifies the
1100 code a bit. It makes no difference on POSIXish platforms but
1101 apparently it fixes a bug on w32.
1103 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1104 * fileio.c (close_file_unwind): Don't close if FD is negative;
1105 this can happen when unwinding a zapped file descriptor.
1106 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1107 in case Emacs runs out of memory between the two unwind-protects.
1108 Don't trash errno when closing FD.
1109 Zap the FD in the specpdl when closing it, instead of deferring
1110 the removal of the unwind-protect; this fixes a bug where a child
1111 function unwinds the stack past us.
1113 New unwind-protect flavors to better type-check C callbacks.
1114 This also lessens the need to write wrappers for callbacks,
1115 and the need for make_save_pointer.
1116 * alloca.c (free_save_value):
1117 * atimer.c (run_all_atimers):
1119 * alloc.c (safe_alloca_unwind):
1120 * atimer.c (unwind_stop_other_atimers):
1121 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1122 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1123 * minibuf.c (choose_minibuf_frame_1):
1124 * process.c (make_serial_process_unwind):
1125 * xdisp.h (pop_message_unwind):
1126 * xselect.c (queue_selection_requests_unwind):
1127 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1128 * alloca.c (record_xmalloc):
1129 Prefer record_unwind_protect_ptr to record_unwind_protect with
1131 * alloca.c (Fgarbage_collect):
1132 Prefer record_unwind_protect_void to passing a dummy.
1133 * buffer.c (restore_buffer):
1134 * window.c (restore_window_configuration):
1135 * xfns.c, w32fns.c (do_unwind_create_frame)
1136 New wrapper. All record-unwind uses of wrappee changed.
1137 * buffer.c (set_buffer_if_live):
1138 * callproc.c (call_process_cleanup, delete_temp_file):
1139 * coding.c (code_conversion_restore):
1140 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1141 * editfns.c (save_excursion_restore)
1142 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1143 (save_restriction_restore):
1144 * eval.c (restore_stack_limits, un_autoload):
1145 * fns.c (require_unwind):
1146 * keyboard.c (recursive_edit_unwind, tracking_off):
1147 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1148 * macros.c (pop_kbd_macro, restore_menu_items):
1149 * nsfns.m (unwind_create_frame):
1150 * print.c (print_unwind):
1151 * process.c (start_process_unwind):
1152 * search.c (unwind_set_match_data):
1153 * window.c (select_window_norecord, select_frame_norecord):
1154 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1155 (fast_set_selected_frame):
1156 * xfns.c, w32fns.c (unwind_create_tip_frame):
1157 Return void, not a dummy Lisp_Object. All uses changed.
1158 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1159 * callproc.c (call_process_kill):
1160 * fileio.c (restore_point_unwind, decide_coding_unwind)
1161 (build_annotations_unwind):
1162 * insdel.c (Fcombine_after_change_execute_1):
1163 * keyboard.c (read_char_help_form_unwind):
1164 * menu.c (unuse_menu_items):
1165 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1166 * sound.c (sound_cleanup):
1167 * xdisp.c (unwind_redisplay):
1168 * xfns.c (clean_up_dialog):
1169 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1170 Accept no args and return void, instead of accepting and returning
1171 a dummy Lisp_Object. All uses changed.
1172 * cygw32.c (fchdir_unwind):
1173 * fileio.c (close_file_unwind):
1174 * keyboard.c (restore_kboard_configuration):
1175 * lread.c (readevalllop_1):
1176 * process.c (wait_reading_process_output_unwind):
1177 Accept int and return void, rather than accepting an Emacs integer
1178 and returning a dummy object. In some cases this fixes an
1179 unlikely bug when the corresponding int is outside Emacs integer
1180 range. All uses changed.
1181 * dired.c (directory_files_internal_unwind):
1182 * fileio.c (do_auto_save_unwind):
1183 * gtkutil.c (pop_down_dialog):
1184 * insdel.c (reset_var_on_error):
1185 * lread.c (load_unwind):
1186 * xfns.c (clean_up_file_dialog):
1187 * xmenu.c, nsmenu.m (pop_down_menu):
1188 * xmenu.c (cleanup_widget_value_tree):
1189 * xselect.c (wait_for_property_change_unwind):
1190 Accept pointer and return void, rather than accepting an Emacs
1191 save value encapsulating the pointer and returning a dummy object.
1193 * editfns.c (Fformat): Update the saved pointer directly via
1194 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1195 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1196 (unwind_body): New function.
1197 (record_unwind_protect): First arg is now a function returning void,
1198 not a dummy Lisp_Object.
1199 (record_unwind_protect_ptr, record_unwind_protect_int)
1200 (record_unwind_protect_void): New functions.
1201 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1202 * fileio.c (struct auto_save_unwind): New type.
1203 (do_auto_save_unwind): Use it.
1204 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1205 * insdel.c (struct rvoe_arg): New type.
1206 (reset_var_on_error): Use it.
1207 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1209 (specbinding_func): Remove; there are now several such functions.
1210 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1211 (set_unwind_protect_ptr): New function.
1212 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1214 Be simpler and more consistent about reporting I/O errors.
1215 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1216 Say "Read error" and "Write error", rather than "I/O error", or
1217 "IO error reading", or "IO error writing", when a read or write
1219 * process.c (Fmake_network_process, wait_reading_process_output)
1220 (send_process, Fprocess_send_eof, wait_reading_process_output):
1221 Capitalize diagnostics consistently. Put "failed foo" at the
1222 start of the diagnostic, so that we don't capitalize the
1223 function name "foo". Consistently say "failed" for such
1225 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1226 All callers changed. This is so it can use report_file_error.
1227 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1228 diagnostics consistently as above.
1230 * fileio.c (report_file_errno): Fix errno reporting bug.
1231 If the file name is neither null nor a pair, package it up as a
1232 singleton list. All callers changed, both to this function and to
1233 report_file_error. This fixes a bug where the memory allocator
1234 invoked by list1 set errno so that the immediately following
1235 report_file_error reported the wrong errno value.
1237 Fix minor problems found by --enable-gcc-warnings.
1238 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1239 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1241 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1243 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1244 Set event->arg to Qt if switch-event shall be generated.
1245 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1247 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1249 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1252 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1253 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1254 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1255 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1256 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1257 and there is a focused frame.
1258 (head_table): Add focus-in and focus-out.
1259 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1260 bind to handle-focus-in/out.
1262 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1263 (Fhandle_switch_frame): Call Fhandle_focus_in.
1264 (syms_of_frame): defsubr handle-focus-in/out.
1266 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1268 Fix porting bug to older POSIXish platforms (Bug#14862).
1269 * sysdep.c (emacs_pipe): New function, that implements
1270 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1271 This should port better to CentOS 5 and to Mac OS X 10.6.
1272 All calls to pipe2 changed.
1274 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1275 This makes the code easier to read and the executable a bit smaller.
1276 Do not replace all calls to Fcons that happen to create lists,
1277 just calls that are intended to create lists. For example, when
1278 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1279 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1280 Similarly for list2 through list5.
1281 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1282 * bytecode.c (exec_byte_code):
1283 * callint.c (quotify_arg, Fcall_interactively):
1284 * callproc.c (Fcall_process, create_temp_file):
1285 * charset.c (load_charset_map_from_file)
1286 (Fdefine_charset_internal, init_charset):
1287 * coding.c (get_translation_table, detect_coding_system)
1288 (Fcheck_coding_systems_region)
1289 (Fset_terminal_coding_system_internal)
1290 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1291 * composite.c (update_compositions, Ffind_composition_internal):
1292 * dired.c (directory_files_internal, file_name_completion)
1294 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1295 * doc.c (Fsnarf_documentation):
1296 * editfns.c (Fmessage_box):
1298 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1299 (Feval, eval_sub, Ffuncall, apply_lambda):
1300 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1301 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1302 (Fset_file_times, Finsert_file_contents)
1303 (Fchoose_write_coding_system, Fwrite_region):
1304 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1305 * font.c (font_registry_charsets, font_parse_fcname)
1306 (font_prepare_cache, font_update_drivers, Flist_fonts):
1307 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1308 * frame.c (make_frame, Fmake_terminal_frame)
1309 (x_set_frame_parameters, x_report_frame_params)
1310 (x_default_parameter, Fx_parse_geometry):
1311 * ftfont.c (syms_of_ftfont):
1312 * image.c (gif_load):
1313 * keyboard.c (command_loop_1):
1314 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1315 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1316 (Fminor_mode_key_binding, accessible_keymaps_1)
1317 (Faccessible_keymaps, Fwhere_is_internal):
1318 * lread.c (read_emacs_mule_char):
1319 * menu.c (find_and_return_menu_selection):
1320 * minibuf.c (get_minibuffer):
1321 * nsfns.m (Fns_perform_service):
1322 * nsfont.m (ns_script_to_charset):
1323 * nsmenu.m (ns_popup_dialog):
1324 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1325 (Fx_own_selection_internal):
1326 * nsterm.m (append2):
1327 * print.c (Fredirect_debugging_output)
1328 (print_prune_string_charset):
1329 * process.c (Fdelete_process, Fprocess_contact)
1330 (Fformat_network_address, set_socket_option)
1331 (read_and_dispose_of_process_output, write_queue_push)
1332 (send_process, exec_sentinel):
1333 * sound.c (Fplay_sound_internal):
1334 * textprop.c (validate_plist, add_properties)
1335 (Fput_text_property, Fadd_face_text_property)
1336 (copy_text_properties, text_property_list, syms_of_textprop):
1337 * unexaix.c (report_error):
1338 * unexcoff.c (report_error):
1339 * unexsol.c (unexec):
1340 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1341 (Fformat_mode_line, syms_of_xdisp):
1342 * xfaces.c (set_font_frame_param)
1343 (Finternal_lisp_face_attribute_values)
1344 (Finternal_merge_in_global_face, syms_of_xfaces):
1345 * xfns.c (x_default_scroll_bar_color_parameter)
1346 (x_default_font_parameter, x_create_tip_frame):
1347 * xfont.c (xfont_supported_scripts):
1348 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1349 (menu_help_callback, xmenu_show):
1351 * xterm.c (set_wm_state):
1352 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1353 and similarly for list2 through list5.
1355 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1357 * callproc.c (Fcall_process_region): Fix minor race and tune.
1358 (create_temp_file): New function, with the temp-file-creation part
1359 of the old Fcall_process_region. Use Fcopy_sequence to create the
1360 temp file name, rather than alloca + build_string, for simplicity.
1361 Don't bother to block input around the temp file creation;
1362 shouldn't be needed. Simplify use of mktemp. Use
1363 record_unwind_protect immediately after creating the temp file;
1364 this closes an unlikely race where the temp file was not removed.
1365 Use memcpy rather than an open-coded loop.
1366 (Fcall_process_region): Use the new function. If the input is
1367 empty, redirect from /dev/null rather than from a newly created
1368 empty temp file; this avoids unnecessary file system traffic.
1370 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1372 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1373 Simplify by making this case like the other two. This is a bit
1374 slower on obsolete hosts, but the extra complexity isn't worth it.
1376 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1377 * process.c (create_process) [!DOS_NT]:
1378 Remove now-unnecessary calls to emacs_close.
1380 2013-07-13 Eli Zaretskii <eliz@gnu.org>
1382 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1383 returning early. (Bug#14850)
1385 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1386 and inhibit-iso-escape-detection attributes of 'undecided'.
1389 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1391 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1392 Reported by Herbert J. Skuhra in
1393 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1395 Don't lose top specpdl entry when memory is exhausted.
1396 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1397 specpdl overflow here, to simplify callers; all callers changed.
1398 Always reserve an unused entry at the stack top; this avoids
1399 losing the top entry's information when memory is exhausted.
1401 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1403 Clean up errno reporting and fix some errno-reporting bugs.
1404 * callproc.c (Fcall_process):
1405 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1406 * process.c (create_process, Fmake_network_process):
1407 * unexaix.c (report_error):
1408 * unexcoff.c (report_error):
1409 Be more careful about reporting the errno of failed operations.
1410 The code previously reported the wrong errno sometimes.
1411 Also, prefer report_file_errno to setting errno + report_file_error.
1412 (Fcall_process): Look at openp return value rather than at path,
1413 as that's a bit faster and clearer when there's a numeric predicate.
1414 * fileio.c (report_file_errno): New function, with most of the
1415 old contents of report_file_error.
1416 (report_file_error): Use it.
1417 (Ffile_exists_p, Ffile_accessible_directory_p):
1418 Set errno to 0 when it is junk.
1419 * fileio.c (Faccess_file):
1420 * image.c (x_create_bitmap_from_file):
1421 Use faccessat rather than opening the file, to avoid the hassle of
1422 having a file descriptor open.
1423 * lisp.h (report_file_errno): New decl.
1424 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1427 * process.c (create_process, wait_reading_process_output) [AIX]:
1428 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1429 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1430 a multithreaded environment anyway).
1431 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1433 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1435 * image.c (x_find_image_file): Don't close a remote file handle.
1437 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1439 Fix races with threads and file descriptors.
1440 * callproc.c (Fcall_process_region):
1441 * dired.c (open_directory):
1442 * emacs.c (main, Fdaemon_initialized):
1443 * image.c (x_find_image_file):
1444 * inotify.c (Finotify_rm_watch):
1445 * lread.c (Flocate_file_internal):
1446 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1447 * term.c (term_mouse_moveto, init_tty):
1448 * termcap.c (tgetent):
1449 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1450 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1451 * unexhp9k800.c, unexmacosx.c (unexec):
1452 * callproc.c (Fcall_process_region):
1453 Use emacs_close, not close.
1454 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1455 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1456 and posix_close function on current platforms (which all lack them).
1457 (emacs_close): Use it. This should fix the races on GNU/Linux and
1458 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1459 and it should avoid closing random victim file descriptors on
1462 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1464 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1465 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1468 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1469 This is for .gdbinit xbacktrace.
1471 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1472 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1473 (emacs_set_tty): Now static.
1474 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1475 * term.c (tty_capable_p, tty_default_color_capabilities)
1476 (get_tty_terminal, term_mouse_movement)
1477 (handle_one_term_event, init_tty, maybe_fatal):
1478 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1479 (tgetent, scan_file, name_match, compare_contin):
1480 * terminal.c (get_terminal):
1481 Use bool for boolean.
1482 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1483 Prefer char to unsigned char if either will do.
1484 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1485 (tty_write_glyphs): Prefer int to unsigned.
1486 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1487 All callers changed.
1488 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1490 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1493 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1494 (B__dummy__): New dummy symbol, to pacify C89.
1495 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1496 they can't grok varargs macros.
1497 * dispnew.c (add_window_display_history)
1498 (add_frame_display_history):
1499 * print.c (print_object):
1500 * xdisp.c (debug_method_add):
1501 Use %p printf format only for void pointers.
1502 * emacs.c (usage_message): New constant, replacing ...
1503 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1504 (main): Adjust to usage reorg.
1505 * fns.c (syms_of_fns):
1506 * profiler.c (syms_of_profiler):
1507 Don't use non-constant struct initializers.
1508 * gnutls.h (gnutls_initstage_t):
1509 * lisp.h (enum Lisp_Fwd_Type):
1510 * lread.c (lisp_file_lexically_bound_p):
1511 * xsettings.c (anonymous enum):
1512 Remove trailing comma.
1513 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1514 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1515 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1517 * regex.c (const_re_char): New type, to pacify strict C89.
1518 All uses of 'const re_char' replaced to use it.
1519 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1520 with glibc when strict C89. This change is imported from gnulib.
1522 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1523 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1524 Omit GNU_LINUX implementation, since it requires long long.
1525 * xterm.c (x_draw_underwave):
1526 Do not assume the traditional order of struct's members.
1527 (x_term_init): Rewrite to avoid the need for non-constant structure
1530 Syntax cleanup, mostly replacing macros with functions.
1531 This removes the need for the syntax_temp hack.
1532 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1533 * syntax.c (SYNTAX_INLINE): New macro.
1534 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1535 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1536 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1537 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1538 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1539 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1540 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1541 Now constants, not macros.
1542 (syntax_temp) [!__GNUC__]: Remove.
1543 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1544 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1545 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1546 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1547 Move here from syntax.h; now functions, not macros. Except for the
1548 last function, these are static since only syntax.c uses them.
1549 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1550 All uses changed. Now a function, not a macro; use this fact
1551 to simplify the code.
1552 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1553 compiler bugs; no longer relevant.
1554 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1555 (SYNTAX_INLINE): New macro.
1556 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1557 for the new functions. Use bool for boolean member.
1558 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1559 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1560 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1561 (SETUP_BUFFER_SYNTAX_TABLE):
1562 Now extern inline functions, not macros.
1563 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
1564 Remove; all uses replaced by implementation.
1565 (syntax_temp) [!__GNUC__]: Remove decl.
1566 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
1568 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
1570 * emacs.c (main): Fix syntax error.
1572 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1574 Timestamp fixes for undo (Bug#14824).
1575 * atimer.c (schedule_atimer):
1576 * fileio.c (Ffile_newer_than_file_p):
1577 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
1578 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
1579 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
1580 (syms_of_fileio): Remove Sclear_visited_file_name.
1581 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
1582 file doesn't exist; this avoids an ambiguity with negative timestamps.
1583 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
1584 * systime.h (make_emacs_time, invalid_emacs_time):
1585 Don't assume struct timespec layout; POSIX doesn't guarantee it.
1586 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
1587 * undo.c (record_first_change): Push (visited-file-modtime) onto
1588 undo list rather than reimplementing it by hand, incorrectly.
1590 2013-07-09 Ken Brown <kbrown@cornell.edu>
1592 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
1594 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
1596 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
1598 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
1600 Handle errno and exit status a bit more carefully.
1601 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
1602 number into an exit status. Instead, use EXIT_CANCELED.
1603 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
1604 * callproc.c (relocate_fd):
1605 * emacs.c (close_output_streams, main):
1606 * process.c (create_process):
1607 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
1608 Use emacs_perror for simplicity.
1609 * callproc.c (relocate_fd, main):
1610 * sysdep.c (sys_subshell):
1611 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
1612 (shut_down_emacs): Use emacs_write, not write.
1613 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
1614 * fileio.c (Fcopy_file, e_write):
1615 * nsterm.m (ns_select):
1616 * process.c (send_process):
1617 * sound.c (vox_write):
1618 Use emacs_write_sig, not emacs_write.
1619 * lisp.h (emacs_write_sig, emacs_perror): New decls.
1620 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
1622 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
1624 (emacs_full_write): New function.
1625 (emacs_write): Rewrite to use it.
1626 (emacswrite_sig, emacs_perror): New functions.
1627 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
1629 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
1631 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
1632 on NS even if it is present. Pixmap on NS is a void*.
1634 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1636 Port to Ubuntu 10 (Bug#14803).
1637 Problem reported by T.V. Raman.
1638 * process.c (close_on_exec, accept4, process_socket):
1639 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
1641 2013-07-07 Eli Zaretskii <eliz@gnu.org>
1643 * w32.c (sys_dup): Declare prototype.
1647 * callproc.c [WINDOWSNT]: Include sys/socket.h.
1649 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1651 Make file descriptors close-on-exec when possible (Bug#14803).
1652 This simplifies Emacs a bit, since it no longer needs to worry
1653 about closing file descriptors by hand in some cases.
1654 It also fixes some unlikely races. Not all such races, as
1655 libraries often open files internally without setting
1656 close-on-exec, but it's an improvement.
1657 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
1658 * callproc.c (Fcall_process) [!MSDOS]:
1659 * emacs.c (main) [!DOS_NT]:
1660 * nsterm.m (ns_term_init):
1661 * process.c (create_process):
1662 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
1663 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
1664 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
1665 Prefer mkostemp with O_CLOEXEC to mkstemp.
1666 * callproc.c (relocate_fd) [!WINDOWSNT]:
1667 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
1668 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
1670 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
1671 Make the resulting file descriptor close-on-exec.
1672 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
1673 * lread.c (load_descriptor_list, load_descriptor_unwind):
1674 Remove; no longer needed. All uses removed.
1675 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
1676 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
1678 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
1679 (Fmake_network_process, Fnetwork_interface_list):
1680 (Fnetwork_interface_info, server_accept_connection):
1681 Make newly-created socket close-on-exec.
1682 * sysdep.c (emacs_open, emacs_fopen):
1683 Make new-created descriptor close-on-exec.
1684 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
1685 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
1687 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
1689 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
1690 for NS_IMPL_GNUSTEP.
1692 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
1694 Fix openp errno handling.
1695 * callproc.c (Fcall_process): Preserve openp errno around close.
1696 * lread.c (openp): Set errno when returning -1, as some callers
1699 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
1701 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
1703 * nsterm.h (NSSavePanel): Update comment.
1704 (NSAPP_DATA2_RUNFILEDIALOG): Define.
1705 (ns_run_file_dialog): Declare.
1707 * nsfns.m: Remove panelOK.
1709 (ns_run_file_dialog): New function.
1710 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
1711 event loop, so file dialog is popped up by ns_run_file_dialog, called
1712 by sendEvent (Bug#14578).
1713 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
1715 2013-07-06 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (default_line_pixel_height): New function.
1718 (pos_visible_p, move_it_vertically_backward, try_scrolling)
1719 (try_cursor_movement, redisplay_window, try_window)
1720 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
1722 * window.c (window_scroll_pixel_based): use
1723 default_line_pixel_height.
1725 * dispextern.h (default_line_pixel_height): Add prototype.
1727 * frame.c (x_set_line_spacing): Accept a float value for
1728 line-spacing parameter, per the documentation.
1730 * data.c (Fmultibyte_string_p): Doc fix.
1732 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
1734 Use emacs_open more consistently when opening files.
1735 This handles EINTR more consistently now, and makes it easier
1736 to introduce other uniform changes to file descriptor handling.
1737 * src/systdio.h: New file.
1738 * src/buffer.c (mmap_init):
1739 * cygw32.c (chdir_to_default_directory):
1740 * dispnew.c (Fopen_termscript):
1741 * emacs.c (Fdaemon_initialized):
1742 * fileio.c (Fdo_auto_save):
1743 * image.c (slurp_file, png_load_body, jpeg_load_body):
1744 * keyboard.c (Fopen_dribble_file):
1746 * print.c (Fredirect_debugging_output):
1747 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
1748 * termcap.c (tgetent):
1749 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
1750 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
1751 * w32term.c (w32_initialize) [CYGWIN]:
1752 * xfaces.c (Fx_load_color_file):
1753 Use emacs_open instead of plain open, and emacs_fopen instead of
1755 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
1756 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
1757 * callproc.c (default_output_mode): New constant.
1758 (Fcall_process): Use it to call emacs_open instead of plain creat.
1759 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
1760 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
1761 (emacs_fopen): New function.
1762 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
1763 Include <lisp.h>, for emacs_open.
1764 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
1766 Remove duplicate #include directives.
1767 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
1769 Don't include stdio.h twice.
1770 * buffer.c [USE_MMAP_FOR_BUFFERS]:
1771 Don't include sys/types.h or stdio.h twice.
1772 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
1773 * lread.c: Don't include coding.h twice.
1774 * nsfont.m: Don't include frame.h twice.
1775 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
1776 * ralloc.c: Don't include <unistd.h> twice.
1777 * xdisp.c: Don't include font.h twice.
1778 * xterm.c: Don't include fontset.h twice.
1779 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
1781 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1783 Scale ImageMagick images more carefully.
1784 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
1785 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
1786 Be more careful about avoiding undefined behavior after
1787 integer overflow and division by zero.
1789 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1791 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
1792 (syms_of_w32fns): DEFSYM them.
1793 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
1794 (CCHDEVICENAME): Define macros if not defined.
1795 (struct MONITOR_INFO_EX): New struct.
1796 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
1797 (enum_display_monitors_fn): New variable.
1798 (globals_of_w32fns): Initialize it.
1799 (Fx_display_pixel_width, Fx_display_pixel_height)
1800 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
1801 multi-monitor setups in docstrings.
1802 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
1803 screen size by primary monitor's millimeter per pixel.
1804 (w32_monitor_enum, w32_display_monitor_attributes_list)
1805 (w32_display_monitor_attributes_list_fallback)
1806 (Fw32_display_monitor_attributes_list): New functions.
1807 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
1809 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
1811 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
1813 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
1815 * fileio.c (Qfile_notify_error): New error symbol.
1817 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
1818 * inotify.c (inotify_callback, symbol_to_inotifymask)
1819 (Finotify_add_watch, Finotify_rm_watch): Use it.
1820 (inotifyevent_to_event): Exchange order of cookie and file name.
1821 (Finotify_add_watch): Adapt docstring.
1823 * lisp.h (Qfile_notify_error): Declare.
1825 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1827 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
1828 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1829 Do not clear _malloc_thread_enabled_p, undoing the previous change,
1830 which did not work (see <http://bugs.gnu.org/14569#307>).
1831 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
1832 && (!noninteractive || initialized)). This attempts to thread
1833 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
1835 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
1837 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
1838 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
1840 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
1842 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
1843 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1844 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
1845 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
1847 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1849 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
1850 Define to __sys_siglist.
1852 2013-07-02 Eli Zaretskii <eliz@gnu.org>
1854 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
1855 word-wrap, so that overflow-newline-into-fringe would work in
1856 visual-line-mode. (Bug#2749)
1857 (move_it_in_display_line_to): When the last scanned display
1858 element fits exactly on the display line, and
1859 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
1860 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
1861 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
1862 finding buffer position that corresponds to pixel coordinates,
1863 e.g. in buffer_posn_from_coords.
1865 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
1867 * process.c (handle_child_signal): Call catch_child_signal if
1870 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
1872 Don't convert function pointers to void * and back.
1873 It isn't portable C, and it's easy enough to avoid.
1874 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
1875 (make_save_value): Add support for SAVE_FUNCPOINTER.
1876 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
1877 * print.c (print_object):
1878 Distinguish function from object pointers.
1879 * lisp.h (SAVE_FUNCPOINTER): New constant.
1880 (SAVE_SLOT_BITS): Adjust to it.
1881 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
1882 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
1883 (voidfuncptr): New typedef.
1884 (struct Lisp_Save_Value): New member data[0].funcpointer.
1885 (XSAVE_FUNCPOINTER): New function.
1887 Simplify buildobj processing.
1888 * Makefile.in (buildobj.h): Make it a sequence of strings each
1889 followed by comma, rather than a single string. Put it into a
1890 .tmp file in case there's an error while generating it.
1891 (gl-stamp): Use .tmp for temp files.
1892 (mostlyclean): Clean .tmp files.
1893 * doc.c (buildobj): Move to just the routine that needs it.
1894 It's now an array of strings, so processing is simpler.
1896 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
1898 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
1899 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
1900 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
1901 Invoke malloc_enable_thread even when not interactive.
1902 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
1903 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
1904 in this case, since the underlying bug has now been fixed.
1906 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
1908 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
1909 unlinking it (bug#14691).
1911 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
1913 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
1914 before checking whether buffer is modified. This lets
1915 `kill-buffer-query-functions' cancel killing of the buffer or save
1916 its content before `kill-buffer' asks user the "Buffer %s
1917 modified; kill anyway?" question.
1919 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
1921 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
1922 Let the super performKeyEquivalent deal with them (Bug#14747).
1924 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
1926 * widget.c (resize_cb): Remove unused local.
1928 Do not use GTK 3 if it exists but cannot be compiled.
1929 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
1930 * xterm.c (x_error_handler) [!USE_GTK]:
1933 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
1935 2013-06-30 Eli Zaretskii <eliz@gnu.org>
1937 * intervals.c (get_local_map): Instead of aborting, clip POSITION
1938 to the valid range of values. (Bug#14753)
1940 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
1941 when moving point by using the current glyph matrix. This avoids
1942 the need to force redisplay when this function is called in a
1945 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
1947 Fix minor problems found by static checking.
1948 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
1949 Redo the latter's body to sidestep GCC parenthesization warnings.
1950 (setup_coding_system, detect_coding, detect_coding_system): Use them.
1951 * coding.c (detect_coding, detect_coding_system):
1952 * coding.h (struct undecided_spec):
1953 Use bool for boolean.
1954 * image.c (QCmax_width, QCmax_height): Now static.
1955 * xdisp.c (Fmove_point_visually): Remove unused local.
1957 2013-06-29 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (Fmove_point_visually): New function.
1961 2013-06-28 Kenichi Handa <handa@gnu.org>
1963 * coding.h (define_coding_undecided_arg_index): New enum.
1964 (coding_attr_index): New members
1965 coding_attr_undecided_inhibit_null_byte_detection,
1966 coding_attr_undecided_inhibit_iso_escape_detection,
1967 coding_attr_undecided_prefer_utf_8.
1968 (undecided_spec): New struct.
1969 (struct coding_system): New member `undecided' of the member
1972 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
1973 (detect_coding): Likewise.
1974 (detect_coding_system): Likewise.
1975 (Fdefine_coding_system_internal): New coding system properties
1976 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
1978 (syms_of_coding): Adjust for coding_arg_undecided_max.
1980 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
1982 * image.c (x_from_xcolors): Remove unused local.
1984 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1986 Defer image data transfer between X client and server until actual
1989 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
1992 * image.c (Destroy_Image): Remove.
1993 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
1994 `mask_p', and `colors_p'. All uses changed.
1995 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
1996 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
1997 New macros for `flags' arg to x_clear_image_1.
1998 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
1999 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2000 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2001 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2002 (image_get_x_image, image_unget_x_image): New functions or macros.
2003 (image_background, image_background_transparent, x_to_xcolors)
2004 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2005 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2006 instead of Destroy_Image.
2007 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2008 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2009 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2010 (imagemagick_load_image, svg_load_image): Use them instead of
2011 x_create_x_image_and_pixmap, and x_put_x_image followed by
2012 x_destroy_x_image, respectively.
2013 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2014 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2015 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2016 background_transparent fields.
2017 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2018 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2020 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2022 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2023 This mostly consists of undoing recent changes.
2024 * callproc.c (Fcall_process):
2025 * process.c (create_process):
2026 Do not worry about catching SIGCHLD here, undoing previous change.
2027 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2028 * process.c, process.h (catch_child_signal):
2029 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2030 * process.c (catch_child_handler): Don't worry about being called
2031 lazily and do not assume caller has blocked SIGCHLD, undoing
2032 previous change. Move first-time stuff back to
2033 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2034 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2035 set lib_child_handler if it's already initialized, which may
2036 help avoid problems on GNUStep.
2038 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2040 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2041 * callproc.c (Fcall_process):
2042 * process.c (create_process):
2043 Make sure SIGCHLD is caught before we fork,
2044 since Emacs startup no arranges to catch SIGCHLD.
2045 * process.c (lib_child_handler): Initialize to null, not to
2047 (catch_child_signal): Allow self to be called lazily.
2048 Do nothing if it's already been called.
2049 Assume caller has blocked SIGCHLD (all callers do now).
2050 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2051 just before it's really needed.
2052 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2053 since it hasn't been caught yet.
2055 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2057 * image.c (compute_image_size): New function to implement
2058 :max-width and :max-height.
2059 (imagemagick_load_image): Use it.
2061 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2063 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2064 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2066 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2067 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2068 the SIGCHLD handler, since the code is not atomic and (due to glib)
2069 signals may be arriving now.
2070 * sysdep.c (init_signals): Do not catch child signals here;
2071 'main' now does that later, at a safer time.
2073 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2075 Clean up SIGCHLD handling a bit (Bug#14569).
2076 * process.c, process.h (catch_child_signal):
2077 Now always extern, even if !NS_IMPL_GNUSTEP.
2078 * process.c (catch_child_signal): Move glib tickler here from
2079 init_process_emacs, so that it's done earlier in Emacs
2080 initialization. Also move the noninteractive && !initialized
2081 check here from init_process_emacs. This is all a bit cleaner for
2082 GNUish platforms, and I hope it works around the Cygwin bug.
2083 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2084 that glib signal handling is tickled before glib creates threads.
2086 * process.c (wait_reading_process_output): Avoid int overflow
2087 when reading more than 2 GiB total from a process.
2089 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2091 * process.c (create_process): Handle a couple more cases,
2092 i.e., work even if new_argv and wait_child_setup[i] are cached.
2093 Use Fcall_process's style for volatile vars.
2095 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2097 * process.c (create_process): Mark PROCESS volatile.
2099 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2101 Use C99-style flexible array members if available.
2102 This avoids some subtle aliasing issues, which typically
2103 aren't a problem with GCC but may be a problem elsewhere.
2104 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2105 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2106 In either case, it uses a flexible array member rather than
2107 the old struct hack. All uses changed.
2108 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2109 Adjust to sdata reorganization.
2110 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2111 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2112 that ports better to pre-C99 non-GCC.
2113 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2114 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2115 as the latter has changed.
2116 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2117 and port better to pre-C99 GCC.
2118 * image.c (struct xpm_cached_color):
2119 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2120 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2121 Use FLEXIBLE_ARRAY_MEMBER.
2122 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2123 Move decl to top level so it gets checked against implementation.
2124 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2125 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2127 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2129 * syntax.c: Integer cleanups.
2130 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2131 All uses that need 0-or-2 changed to:
2132 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2133 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2134 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2135 (char_quoted, prev_char_comend_first, back_comment)
2136 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2137 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2138 Use bool for boolean.
2139 (update_syntax_table, skip_chars, skip_syntaxes):
2140 Prefer int to unsigned when either will do.
2141 (back_comment): Return boolean success flag, like forw_comment,
2142 instead of positive-or-minus-1 (which might have overflowed int anyway).
2143 Don't stuff ptrdiff_t into int.
2144 (syntax_spec_code, syntax_code_spec): Now const.
2145 (Fmatching_paren, scan_lists, scan_sexps_forward):
2146 Use enum syntaxcode for syntax code.
2147 (Fmatching_paren): Check that arg is a character, not just an integer.
2148 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2149 (Finternal_describe_syntax_value): Omit no-longer-needed
2151 (skip_chars): Use char, not unsigned char, when the distinction
2153 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2154 * bytecode.c (exec_byte_code):
2155 * syntax.c (syntax_spec_code, Fchar_syntax)
2156 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2158 * syntax.h (SYNTAX_WITH_FLAGS):
2159 Omit unnecessary casts.
2161 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2163 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2164 line dimensions here, to avoid race conditions with the main
2165 thread. (Bug#14062, bug#14630, bug#14669)
2167 * w32term.c (w32_draw_window_cursor): Compute the header line and
2168 mode line dimensions here.
2169 <w32_system_caret_window, w32_system_caret_hdr_height>:
2170 <w32_system_caret_mode_height>: New variables.
2172 * w32term.h: Declare them.
2174 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2176 * alloc.c (die): Move "assertion failed" string here ...
2177 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2178 COND when SUPPRESS_CHECKING. This shrinks the executable text
2179 size by 0.8% to 2.2% when configured with --enable-checking,
2180 depending on optimization flags (GCC 4.8.1 x86-64).
2182 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2184 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2186 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2187 base is 2; this is more accurate.
2189 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2191 * sound.c (string_default): Move to !WINDOWSNT section.
2192 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2194 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2196 * sound.c: Integer cleanups.
2197 Remove unnecessary forward decls.
2198 (struct sound_device): The 'file' member is now a Lisp_Object, not
2199 a char *, so that we needn't invoke alloca on a huge size.
2200 (Fplay_sound_internal): Adjust to this.
2201 (string_default): New function.
2202 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2203 Use it to adjust to the struct sound_device change.
2204 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2205 (be2hs) [0]: Remove.
2207 * syntax.c (skip_chars): Don't use uninitialized storage
2208 when searching a multibyte buffer for characters that are not in a
2209 unibyte string that contains non-ASCII characters.
2211 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2213 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2214 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2216 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2218 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2220 2013-06-18 Kenichi Handa <handa@gnu.org>
2222 * font.c (Ffont_spec): Signal an error for an invalid font name
2225 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2227 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2228 In particular this ports to 32-bit sparc Sun cc.
2229 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2230 array with a dummy element at specpdl[-1], so that its address can
2232 (unbind_to): Do not copy the binding; not needed, now that we
2233 copy old_value in the one place where the copy is needed.
2234 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2235 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2236 (union specbinding): Rename from struct specbinding. Redo layout
2237 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2238 which is not portable. With Sun C 5.12 32-bit sparc, the
2239 declaration causes nargs to be an unsigned bitfield, a behavior
2240 that the C standard allows; but Emacs wants nargs to be signed.
2241 The overall type is now a union of structures rather than a
2242 structure of union of structures, and the 'kind' member is now a
2243 bitfield, so that the overall type doesn't grow. All uses changed.
2244 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2246 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2248 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2249 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2251 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2253 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2255 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2256 unless we know that the window w's frame is a frame object.
2257 Another attempt at solving bug#14062 and bug#14630.
2259 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2261 * textprop.c (property_set_type): New enum.
2262 (add_properties): Allow appending/prepending text properties.
2263 (add_text_properties_1): Factored out of Fadd_text_properties.
2264 (Fadd_text_properties): Move all the code into
2265 add_text_properties_1.
2266 (Fadd_face_text_property): New function that calls
2267 add_text_properties_1.
2269 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2271 Move functions from lisp.h to individual modules when possible.
2272 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2273 * alloc.c (XFLOAT_INIT, set_symbol_name):
2274 * buffer.c (CHECK_OVERLAY):
2275 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2276 (set_char_table_parent):
2277 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2278 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2279 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2280 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2282 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2283 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2284 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2285 (backtrace_args, backtrace_debug_on_exit):
2286 * floatfns.c (CHECK_FLOAT):
2287 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2288 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2289 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2290 (set_hash_index_slot):
2291 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2292 * marker.c (CHECK_MARKER):
2293 * textprop.c (CHECK_STRING_OR_BUFFER):
2294 * window.c (CHECK_WINDOW_CONFIGURATION):
2295 Move here from lisp.h, and make these functions static rather than
2297 * buffer.c (Qoverlayp):
2299 * fns.c (Qhash_table_p):
2300 * window.c (Qwindow_configuration_p):
2302 * lisp.h: Remove the abovementioned defns and decls.
2304 Use functions, not macros, for XINT etc (Bug#11935).
2305 In lisp.h, prefer functions to function-like macros, and
2306 constants to object-like macros, when either will do. This:
2307 . simplifies use, as there's no more need to worry about
2308 arguments' side effects being evaluated multiple times.
2309 . makes the code easier to debug on some platforms.
2310 However, when using gcc -O0, keep using function-like macros
2311 for a few critical operations, for performance reasons.
2312 This sort of thing isn't needed with gcc -Og, but -Og
2313 is a GCC 4.8 feature and isn't widely-enough available yet.
2314 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2315 Remove enum lsb_bits; no longer needed.
2316 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2317 * buffer.c (Qoverlap):
2319 * fns.c (Qhash_table_p):
2320 Now extern, so lisp.h can use these symbols.
2321 * dispextern.h: Include character.h, for MAX_CHAR etc.
2322 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2323 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2324 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2325 (GLYPH_CODE_P): Move here from lisp.h.
2326 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2327 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2328 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2329 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2330 XUNTAG now returns void *.
2331 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2332 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2333 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2334 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2335 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2336 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2337 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2338 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2339 New macros, renamed from their sans-lisp_h_ counterparts.
2340 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2341 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2342 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2343 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2344 If compiling via GCC without optimization, define these as macros
2345 in addition to inline functions.
2346 To disable this, compile with -DINLINING=0.
2347 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2348 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2349 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2350 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2351 (INTMASK, VALMASK): Now macros, since static values cannot be
2352 accessed from extern inline functions.
2353 (VALMASK): Also a constant, for benefit of old GDB.
2354 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2355 is INTEGERP, which can fold it in.
2356 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
2357 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2358 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2359 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2360 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2361 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2362 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2363 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2364 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2365 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2366 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2367 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2368 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2369 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2370 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2371 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2372 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2373 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2374 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2375 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2376 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2377 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2378 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2379 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2380 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2381 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2382 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2383 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2384 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2385 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2386 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2387 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2388 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2390 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2391 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2392 (VALMASK): Define in one place rather than in two, merging the
2393 USE_LSB_TAG parts; this is simpler.
2394 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2395 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2396 Move up, to avoid use before definition.
2397 Also include "globals.h" earlier, for the same reason.
2398 (make_natnum): New function.
2399 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2400 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2401 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2402 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2403 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2404 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2405 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2406 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2407 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2408 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2409 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2410 (Qwindow_configuration_p, Qimage): New forward declarations.
2411 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2412 (STRING_COPYIN): Remove; unused.
2413 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2414 (xcar_addr, xcdr_addr): New functions. All uses changed.
2415 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2416 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2417 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2418 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2419 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2420 (TYPE_RANGED_INTEGERP): Simplify.
2421 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2422 (setlocale, fixup_locale, synchronize_system_messages_locale)
2423 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2424 Now empty functions, not macros.
2425 (functionp): Return bool, not int.
2426 * window.c (Qwindow_configuration_p): Now extern,
2427 so window.h can use it.
2428 * window.h (Qwindowp): Move decl back to lisp.h.
2430 2013-06-15 Eli Zaretskii <eliz@gnu.org>
2432 * xdisp.c (Fline_pixel_height): New function, required for solving
2435 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2437 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2439 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2441 * lread.c (syms_of_lread):
2442 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2444 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2446 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2448 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2450 * fileio.c (expand_file_name): Doc fix.
2452 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2454 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2455 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2456 Wait for self, not for 0. This can't hurt on GNU or similar
2457 system, and may help with Cygwin.
2459 * keyboard.c: Don't use PROP (...) as an lvalue.
2460 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2461 Use set_prop (A, B), not PROP (A) = B.
2463 2013-06-10 Eli Zaretskii <eliz@gnu.org>
2465 * xdisp.c (get_it_property): Use it->window instead of generating
2466 a Lisp object from it->w.
2468 2013-06-09 Eli Zaretskii <eliz@gnu.org>
2470 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2471 get-char-property the window that is being rendered, instead of
2472 the buffer, to support window-specific overlays. (Bug#14575)
2473 (compute_display_string_pos): When W is NULL, use the current
2474 buffer as the object to pass to get-char-property.
2475 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2476 pointer member of the bidi iterator, since no window is pertinent
2479 2013-06-08 Eli Zaretskii <eliz@gnu.org>
2481 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2482 being displayed, and pass it to compute_display_string_pos.
2483 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2484 (bidi_paragraph_init): All callers changed.
2486 * xdisp.c (init_from_display_pos, init_iterator)
2487 (handle_single_display_spec, next_overlay_string)
2488 (get_overlay_strings_1, reseat_1, reseat_to_string)
2489 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2490 Set bidi_it.w member from it->w.
2491 (compute_display_string_pos): Accept additional argument, the
2492 window being displayed, and pass it to Fget_char_property.
2495 * dispextern.h (struct bidi_it): New member w, the window being
2497 (compute_display_string_pos): Adjust prototype.
2499 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2501 * xgselect.c: Remove unneeded include xterm.h.
2503 * process.c (wait_reading_process_output): Check for NS before GLIB.
2504 GLIB may be linked in due to rsvg, but ns_select must be called.
2506 * xgselect.c (xg_select): Remove call to window_system_available
2507 and g_main_context_pending at the top, so Gdk events (i.e. file
2508 notify) are processed when Emacs is started with -nw.
2510 2013-06-07 Eli Zaretskii <eliz@gnu.org>
2512 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2513 (ctagsfiles3): New variable, includes only *.m files.
2514 (TAGS): Use an explicit language name in the regular expressions,
2515 to avoid transformation of '/SOMETHING' by MSYS to
2516 'c:\MSYS\SOMETHING'.
2518 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2520 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2522 2013-06-06 Eli Zaretskii <eliz@gnu.org>
2524 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2525 still need to set the mouse pointer shape and activate help-echo.
2528 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2530 A few porting etc. fixes for the new file monitor code.
2531 See the thread containing
2532 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2533 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2534 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2535 (dir_monitor_callback, Fgfile_rm_watch):
2536 Use assq_no_quit instead of Fassoc, for speed.
2537 (dir_monitor_callback, Fgfile_rm_watch):
2538 eassert that the monitor is a fixnum.
2539 (dir_monitor_callback): No need for CDR_SAFE.
2540 Simplify building of lisp with alternative tails.
2541 (Fgfile_add_watch, Fgfile_rm_watch):
2542 Do not assume glib functions set errno reliably on failure.
2543 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2544 and signal an error otherwise.
2545 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2546 Use Fdelq instead of Fdelete, for speed.
2548 2013-06-05 Eli Zaretskii <eliz@gnu.org>
2550 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2551 don't insist on being invoked on a highlighted tool-bar button.
2552 Avoids losing tool-bar functionality when mouse-highlight is nil.
2553 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2554 Don't highlight when mouse-highlight is nil.
2555 (note_mouse_highlight): When mouse-highlight is nil, don't return
2556 right away; instead, run tool-bar and mode-line highlight
2557 subroutine, clear any existing highlight, and revert the mouse
2558 pointer to its default shape. (Bug#14558)
2560 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2562 * lisp.mk (lisp): Add prog-mode.el.
2564 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
2566 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
2567 * process.c (dummy_handler): New function.
2568 (lib_child_handler): New static var.
2569 (handle_child_signal): Invoke it.
2570 (catch_child_signal): If a library has set up a signal handler,
2571 save it into lib_child_handler.
2572 (init_process_emacs): If using glib and not on Windows, tickle glib's
2573 child-handling code so that it initializes its private SIGCHLD handler.
2574 * syssignal.h (SA_SIGINFO): Default to 0.
2575 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
2576 31; it should no longer be needed now.
2578 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
2580 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
2582 * gfilenotify.c (globals_of_gfilenotify): New function.
2583 (syms_of_gfilenotify): Move global initialization there.
2585 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
2587 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
2589 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
2590 * keyboard.c (menu_bar_items, tool_bar_items):
2591 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
2592 not override local keymaps any more.
2594 2013-06-04 Eli Zaretskii <eliz@gnu.org>
2596 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
2598 2013-06-03 Eli Zaretskii <eliz@gnu.org>
2600 * w32console.c (initialize_w32_display): Return the dimensions of
2601 the console window via 2 additional arguments, not via the current
2602 frame. This avoids crashes due to overrunning the bounds of
2603 frame's decode_mode_spec_buffer, which is not resized following
2604 the change of the frame dimensions from the initial 10x10.
2606 * w32term.h (w32_initialize_display_info): Adjust prototype.
2608 * term.c (init_tty): Take dimensions of the frame from the values
2609 returned by initialize_w32_display.
2611 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
2612 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
2613 (LIBES): Add $(GFILENOTIFY_LIBS).
2615 * w32inevt.c (handle_file_notifications): Add dummy implementation
2616 for !HAVE_W32NOTIFY.
2618 * w32term.c: Wrap code with HAVE_W32NOTIFY.
2620 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
2622 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
2624 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
2626 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
2628 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
2630 Fix minor problems found by static checking.
2631 * data.c (pure_write_error):
2632 Use xsignal2, not Fsignal, as Fsignal might return.
2633 * eval.c (set_backtrace_debug_on_exit): Now static.
2634 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
2635 No longer inline. EXTERN_INLINE is needed only for functions
2636 defined in .h files. Reindent function header as per GNU style.
2637 (backtrace_p, backtrace_top, backtrace_next):
2638 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
2639 compiler or linker. Add extern decls to pacify gcc -Wall.
2640 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2642 * frame.c (free_monitors): Define only on platforms that need it.
2643 * nsterm.m (ns_term_init):
2644 * process.c (catch_child_signal):
2645 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
2646 defined on all porting targets these days.
2647 * process.c, process.h (catch_child_signal):
2648 Make it extern only if NS_IMPL_GNUSTEP is defined.
2650 2013-06-03 Eli Zaretskii <eliz@gnu.org>
2652 * w32.c (gettimeofday): Make the signature identical to prototype
2653 in nt/inc/sys/time.h.
2655 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2657 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
2660 * keyboard.c (safe_run_hooks_error): Improve error message.
2662 * data.c (pure_write_error): Add `object' argument.
2663 * puresize.h (CHECK_IMPURE): Use it.
2665 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
2667 * Makefile.in (NOTIFY_OBJ): New variable.
2668 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
2670 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
2671 Call syms_of_gfilenotify.
2673 * gfilenotify.c: New file.
2675 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
2676 and Qfile_w32notify.
2677 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
2678 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
2680 * lisp.h: Declare syms_of_gfilenotify.
2682 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
2684 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
2686 Merge the specpdl and backtrace stacks. Make the structure of the
2687 specpdl entries more obvious via a tagged union of structs.
2688 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
2689 (enum specbind_tag): New enum.
2690 (struct specbinding): Make it a tagged union of structs.
2691 Add a case for backtrace records.
2692 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
2693 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
2694 (backtrace_debug_on_exit): New accessors.
2695 (struct backtrace): Remove.
2696 (struct catchtag): Remove backlist field.
2697 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2699 (Flocal_variable_p): Speed up the common case where the binding is
2701 * eval.c (backtrace_list): Remove.
2702 (set_specpdl_symbol, set_specpdl_old_value): Remove.
2703 (set_backtrace_args, set_backtrace_nargs)
2704 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
2705 (backtrace_next): New functions.
2706 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
2707 (unwind_to_catch, internal_lisp_condition_case)
2708 (internal_condition_case, internal_condition_case_1)
2709 (internal_condition_case_2, internal_condition_case_n): Don't bother
2710 with backtrace_list any more.
2711 (Fsignal): Adjust to new backtrace format.
2712 (grow_specpdl): Move up.
2713 (record_in_backtrace): New function.
2714 (eval_sub, Ffuncall): Use it.
2715 (apply_lambda): Adjust to new backtrace format.
2716 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
2718 (specbind): Adjust to new specpdl format. Simplify.
2719 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
2720 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
2722 (mark_backtrace): Remove.
2723 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
2724 * xdisp.c (redisplay_internal): Use record_in_backtrace.
2725 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
2727 * profiler.c (record_backtrace): Use get_backtrace.
2728 (handle_profiler_signal): Use backtrace_top_function.
2729 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
2732 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
2734 * process.h (catch_child_signal): Declare.
2736 * process.c (catch_child_signal): New function.
2737 (init_process_emacs): Call it.
2739 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
2740 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
2742 (x_set_cursor_type): Remove declaration.
2743 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
2744 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
2745 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
2746 (ns_get_color): Use F suffix on float.
2747 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
2748 (ns_get_rgb_color): Remove.
2749 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
2750 (note_mouse_movement): x and y are CGFloat.
2751 (ns_draw_fringe_bitmap): Remove unused rowY.
2752 Change #if to COCOA && >= 10_6.
2753 (ns_draw_window_cursor): Remove unused overspill.
2754 (ns_draw_underwave): width and x are EamcsCGFloat.
2755 (ns_draw_box): thickness is CGFloat.
2756 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
2757 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
2758 if not in main thread.
2759 (ns_get_pending_menu_title, ns_check_menu_open)
2760 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
2761 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
2762 (sendFromMainThread:): New method.
2763 (changeFont:): size is CGFloat.
2764 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
2765 Disable warning about permanent text.
2766 (characterIndexForPoint:): Adjust return type depending on GNUStep
2768 (mouseDown:): delta is CGFloat.
2769 (updateFrameSize): Remove unised variable f.
2770 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
2771 Cast float to EmacsCGFloat.
2772 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
2773 also to -1 when restoring.
2774 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
2775 inside NS_IMPL_COCOA.
2776 (toggleFullScreen:): Put call to toggleFullScreen inside
2777 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
2778 (setPosition:portion:whole:): por is CGFloat.
2779 (getMouseMotionPart:window:x:y:): Add F suffix to float.
2780 (mouseDown:): Use CGFloat.
2781 (mouseDragged:): Remove unised variable edge.
2782 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
2784 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
2786 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
2787 when NS_IMPL_GNUSTEP.
2788 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
2789 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
2790 (EmacsToolbar): Add clearAll. Add tag argument to
2791 addDisplayItemWithImage.
2792 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
2794 * nsselect.m (ns_get_local_selection): Remove unused variable type.
2796 * nsmenu.m (ns_update_menubar): Make static.
2797 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
2798 (fillWithWidgetValue:): Add cast to SEL for setAction.
2799 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
2800 (update_frame_tool_bar): Update code for GNUStep.
2801 (clearAll): New method.
2802 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
2803 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
2804 Move identifierToItem setObject and activeIdentifiers addObject before
2805 call to insertItemWithItemIdentifier.
2806 (validateVisibleItems): Fix indentation.
2807 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
2808 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
2809 UtilityWindow to aStyle, remove call to setStyleMask.
2811 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
2813 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
2814 (ns_charset_covers, ns_get_covering_families, nsfont_open):
2815 Use F suffix on floats.
2816 (ns_char_width): Returns CGFloat.
2817 (ns_ascii_average_width): w is CGFloat instead of float.
2818 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
2820 (ns_glyph_metrics): CGFloat instead of float.
2822 * nsfns.m (x_set_foreground_color, x_set_background_color):
2824 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
2825 remove unused variables.
2826 (Fns_read_file_name): Keep track if panel is for save.
2827 Use ns_filename_from_panel/ns_directory_from_panel.
2828 (Fns_list_services): delegate only used for COCOA.
2829 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
2830 Just return the input if GNUStep.
2831 (x_screen_planes): Remove.
2832 (Fxw_color_values): Use EmacsCGFloat
2833 (Fns_display_monitor_attributes_list): Only get screen number for
2835 (getDirectory, getFilename): Remove from EmacsOpenPanel and
2837 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
2838 ns_directory_from_panel.
2840 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
2842 * process.c (handle_child_signal): Also use WCONTINUED.
2843 This is so that list-processes doesn't mistakenly list the process
2844 as stopped, when the process has actually been continued and is
2847 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
2849 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
2850 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
2851 not already configured.
2853 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
2855 2013-05-29 Eli Zaretskii <eliz@gnu.org>
2857 * Makefile.in (mostlyclean): Remove *.res files.
2859 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
2861 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
2862 a buffer (bug#8447).
2864 2013-05-27 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
2867 display vector, and we backtrack, handle the case that the
2868 previous character position is also displayed from a display
2869 vector or covered by a display string or image. (Bug#14476)
2871 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
2873 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2874 (struct MonitorInfo, free_monitors): Remove.
2875 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
2876 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
2877 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2880 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
2881 (struct MonitorInfo, free_monitors): Remove.
2882 (ns_screen_name): Make static.
2883 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
2884 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
2887 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
2888 (struct MonitorInfo): New struct.
2889 (free_monitors, make_monitor_attribute_list): Declare.
2891 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
2893 (free_monitors, make_monitor_attribute_list): New functions.
2894 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
2897 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
2899 * callproc.c (call_process): Refine the doc string. (Bug#14045)
2901 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
2903 * keyboard.c: Apply keyboard decoding only to events that come directly
2904 from the tty, not from unread-command-events (bug#14368).
2905 (read_event_from_main_queue): New function, extracted from read_char).
2906 (read_decoded_char): Remove.
2907 (read_decoded_event_from_main_queue): New function to replace it.
2908 (read_char): Use it.
2909 (read_key_sequence): Use read_char rather than read_decoded_char.
2911 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
2913 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2915 * casetab.c (init_casetab_once): Fix last change (bug#14424).
2917 2013-05-22 Kenichi Handa <handa@gnu.org>
2919 The following changes are to fix the setting of
2920 buffer-file-coding-system on, for instance, C-x RET c unix RET
2921 _FILE_OF_DOS_EOL_TYPE_ RET.
2923 * coding.h (struct coding_system): New member detected_utf8_chars.
2925 * coding.c (detect_coding_utf_8): Count characters and check EOL
2926 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
2928 (setup_coding_system): Do not initialize coding->head_ascii.
2929 (check_ascii): Do not set coding->eol_seen but update it. Do not
2930 call adjust_coding_eol_type here.
2931 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
2932 If the eol-type of CODING is already specified, adjust the eol type
2933 of the found coding-system.
2934 (decode_coding_gap): Cancel previous change. Utilize the
2935 character numbers counted by detect_coding_utf_8. Fix detection
2938 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2940 * search.c (looking_at_1): Only set last_thing_searched if the match
2941 changed the match-data (bug#14281).
2943 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
2945 * xdisp.c (reseat_at_previous_visible_line_start):
2946 Already declared in dispextern.h, so remove it here.
2947 (move_it_vertically_backward): Likewise.
2949 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2951 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
2952 (Fx_display_pixel_width, Fx_display_pixel_height)
2953 (Fx_display_mm_width, Fx_display_mm_height):
2954 Mention `display-monitor-attributes-list' in docstrings.
2956 * nsfns.m (ns_get_screen): Remove function. All uses removed.
2957 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
2958 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
2959 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
2960 (Fx_display_backing_store, Fx_display_visual_class)
2961 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
2962 (Fx_display_grayscale_p, Fx_display_pixel_width)
2963 (Fx_display_pixel_height, Fx_display_planes)
2964 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
2965 (Fx_display_screens): Don't confuse X11 screens with NS screens.
2966 (Fx_display_mm_width, Fx_display_mm_height)
2967 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
2968 height for all physical monitors as in X11.
2970 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
2971 Return pixel width or height for all physical monitors as in X11.
2973 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
2975 Port --enable-gcc-warnings to clang.
2976 * bytecode.c (exec_byte_code):
2978 Redo diagnostic pragmas to pacify clang, too.
2979 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
2980 * editfns.c (Fencode_time):
2981 * fileio.c (file_accessible_directory_p):
2982 * font.c (font_unparse_xlfd):
2983 Use '&"string"[index]' instead of '"string" + (index)'.
2984 * undo.c (user_error): Remove; unused.
2986 2013-05-16 Eli Zaretskii <eliz@gnu.org>
2988 * insdel.c (insert_1_both): Document the arguments, instead of
2989 referring to insert_1, which no longer exists.
2991 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
2992 some window, increment windows_or_buffers_changed, so that
2993 *Messages* display in that window is updated. (Bug#14408)
2995 * w32.c: Include epaths.h.
2996 (init_environment): Use cmdproxy.exe without leading directories.
2997 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
2999 (gettimeofday): Adjust signature and return value to Posix
3002 * unexw32.c (open_output_file): Delete the existing emacs.exe
3003 before creating it, to break the hard link to the versioned
3006 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3007 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3008 (FIRSTFILE_OBJ): New variables.
3009 (W32_RES): Rename to EMACSRES. All users changed.
3010 (base_obj): Use $(CM_OBJ).
3011 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3012 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3013 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3014 $(W32_RES_LINK) before $(LIBES).
3015 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3017 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3019 * makefile.w32-in (DOC): Use just "DOC".
3021 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3023 * process.c: Export default filters and sentinels to Elisp.
3024 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3026 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3027 (Fset_process_sentinel, Fformat_network_address):
3028 Default to them instead of nil.
3029 (server_accept_connection): Sentinels can't be nil any more.
3030 (read_and_dispose_of_process_output): New function, extracted from
3031 read_process_output.
3032 (read_process_output): Use it; filters can't be nil.
3033 (Finternal_default_process_filter): New function, extracted from
3034 read_process_output.
3035 (exec_sentinel_unwind): Remove function.
3036 (exec_sentinel): Don't zilch sentinel while running.
3037 (status_notify): Sentinels can't be nil.
3038 (Finternal_default_process_sentinel): New function extracted from
3040 (setup_process_coding_systems): Default filter is not nil any more.
3041 (syms_of_process): Export new Elisp functions and initialize
3043 * lisp.h (make_lisp_proc): New function.
3045 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3047 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3049 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3051 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3052 unless we know that the window w is a leaf window.
3053 Another attempt at solving bug#14062.
3055 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3057 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3060 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3062 * image.c (gif_load): Check that subimages fit (Bug#14345).
3064 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3066 * lread.c (skip_dyn_eof): New function.
3067 (read1): Use it to skip the end of a file in response to #@00.
3069 * doc.c (get_doc_string): Slightly relax the sanity checking.
3071 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3073 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3074 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3075 (MonitorInfo): New struct.
3076 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3077 (Fns_display_monitor_attributes_list): New functions.
3078 (display-usable-bounds): Remove.
3079 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3082 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3084 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3085 (GTK_CHECK_VERSION): New macro, if not already defined.
3086 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3087 replaced by GTK_CHECK_VERSION.
3089 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3091 * xterm.h (GTK_PREREQ): New macro.
3092 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3093 to use this macro instead, for consistency and clarity.
3095 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3097 * xdisp.c (row_for_charpos_p): New function, with code of
3098 cursor_row_p, but accepts an additional argument CHARPOS instead
3099 of using a hardcoded PT.
3100 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3101 (row_containing_pos): Call row_for_charpos_p instead of partially
3102 doing the same. Fixes cursor positioning under longlines-mode
3103 when longlines-show-effect includes more than one newline, when
3104 moving the cursor vertically up.
3106 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3108 * makefile.w32-in (ACL_H): New macro.
3109 ($(BLD)/fileio.$(O)): Update dependencies.
3111 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3113 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3114 * Makefile.in (LIB_ACL): New macro.
3115 (LIBACL_LIBS): Remove.
3116 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3117 * fileio.c: Include <acl.h>.
3118 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3119 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3121 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3124 * unexelf.c: Don't assume ElfW (Half) fits in int.
3125 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3126 when dealing with ElfW (Half) values, since they can exceed 2**31
3127 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3128 (entry_address): Omit unused NUM arg. All uses changed.
3130 2013-05-07 Juri Linkov <juri@jurta.org>
3132 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3133 to the string converted from number with `Fnumber_to_string'.
3136 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3138 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3139 This fixes a problem introduced by my previous change.
3141 2013-05-07 Glenn Morris <rgm@gnu.org>
3143 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3145 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3147 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3149 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3151 Static checking by GCC 4.8.0.
3152 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3153 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3154 (x_get_monitor_attributes_fallback)
3155 (x_get_monitor_attributes_xinerama)
3156 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3157 Define only if USE_GTK.
3158 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3159 (x_get_monitor_attributes_fallback): Omit unused locals.
3160 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3161 Use double, not float, to avoid mixed-mode floating point arithmetic.
3163 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3164 Jan Djärv <jan.h.d@swipnet.se>
3166 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3167 (XINERAMA_CFLAGS): New macros.
3168 (ALL_CFLAGS, LIBES): Use them.
3170 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3171 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3172 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3173 (syms_of_xfns): DEFSYM them.
3174 (struct MonitorInfo): New struct.
3175 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3176 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3177 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3178 (x_get_monitor_attributes_xinerama): New functions.
3179 (Fx_display_monitor_attributes_list): New primitive.
3180 (syms_of_xfns): Defsubr it.
3182 * xterm.h (x_display_info): Add Xatom_net_workarea and
3183 Xatom_net_current_desktop.
3185 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3186 and dpyinfo->Xatom_net_current_desktop.
3188 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3190 * xdisp.c (pos_visible_p): Use the special code for finding the
3191 beginning of a display property or overlay for any "replacing"
3192 display property, not just for display strings. This solves
3193 incorrect reporting of position by posn-at-point. (Bug#14241)
3195 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3197 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3198 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3199 Verify that ElfW (Half) fits in int.
3200 (fatal): Use same signature as lisp.h.
3201 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3202 configure and build with -DUNEXELF_DEBUG without worrying about
3203 other modules that use DEBUG.
3204 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3205 possibly-wide integers now uses it instead of plain fprintf.
3206 (entry_address): New function, which avoids problems with 32-bit
3207 overflow on 64-bit hosts.
3208 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3209 (round_up): Don't assume the remainder fits in int.
3210 (find_section): Use bool for boolean. Simplify debug code.
3211 (unexec): Don't assume file sizes fit in int or size_t.
3212 Omit unnecessary trailing newline in 'fatal' format.
3213 Use strerror rather than outputting decimal error number.
3214 Remove unused code when emacs is not defined;
3215 this file relies on Emacs now.
3216 Don't assume e_phnum and e_shnum are positive.
3218 * regex.c: Fix problems when DEBUG is defined.
3219 (extract_number, extract_number_and_incr): Define regardless of
3220 whether DEBUG is defined; that's simpler and makes the code less
3221 likely to go stale in the normal case when DEBUG is not defined.
3222 Return int rather than taking an int * arg. All callers changed.
3223 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3224 Remove, replacing with ...
3225 (DEBUG_PRINT): New macro. All callers changed.
3226 (DEBUG_COMPILES_ARGUMENTS): New macro.
3227 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3228 (print_compiled_pattern, print_double_string) [DEBUG]:
3229 Use prototype rather than old-style definition.
3230 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3231 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3232 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3233 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3234 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3235 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3236 This matters only when DEBUG is defined.
3238 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3240 * xdisp.c (set_iterator_to_next): Set the
3241 ignore_overlay_strings_at_pos_p flag only if we are _really_
3242 iterating over an overlay string, as indicated by the
3243 current.overlay_string_index member. (Bug#14306)
3245 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3247 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3248 to where it is used, to avoid autorelease issues (Bug#14050).
3250 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3252 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3253 * fileio.c (syms_of_fileio): Implement this.
3254 * filelock.c (create_lock_file): If symbolic links don't work, so
3255 we use a regular file as a lock file, do not fsync the lock file;
3258 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3260 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3261 (syms_of_minibuf): Adjust accodingly.
3263 * callint.c (Fcall_interactively): Adjust calls accordingly.
3265 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3267 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3268 w->contents is a buffer before computing everything else.
3269 Use parentheses to disambiguate last part of the condition.
3271 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3272 assertion violations. (Bug#14062)
3274 2013-05-01 David Reitter <david.reitter@gmail.com>
3276 * nsfns.m (ns_tooltip): Initialize.
3278 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3280 * coding.c (decode_coding_gap): Don't remove the character before
3281 a newline unless it's a CR character. (Bug#14287)
3283 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3285 * dispextern.h (struct face): Move enum face_underline_type
3286 earlier so that bitfields can be in the same word.
3288 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3290 * nsfns.m (handlePanelKeys): New function.
3291 (EmacsOpenPanel:performKeyEquivalent:)
3292 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3293 arrows/function/control and copy/paste keys (Bug#14296).
3295 2013-04-27 Juri Linkov <juri@jurta.org>
3297 * callint.c (Fcall_interactively): Call `Qread_number' for
3298 interactive code letter `n' instead of using duplicate code.
3301 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3303 * systime.h (make_timeval): Declare as 'const'.
3305 2013-04-27 Kenichi Handa <handa@gnu.org>
3307 * font.c (font_open_entity): Always open a font of manageable
3310 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3312 Port better to AIX (Bug#14258).
3313 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3316 2013-04-24 Kenichi Handa <handa@gnu.org>
3318 * coding.c (decode_coding_iso_2022): When an invalid escape
3319 sequence is encountered, reset the invocation and designation
3320 status to the safest one.
3322 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3324 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3325 Without this fix, "make distclean" leaves stamp-h1 behind.
3327 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3329 * w32fns.c (w32_fullscreen_rect): New function to compute the
3330 window rectangle for the given fullscreen mode.
3331 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3332 longer tunes the window size. This keeps the window's edges flush
3333 with the screen and allows the taskbar to hide itself in fullboth.
3335 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3336 window decorations and uses the entire screen.
3338 * w32term.h (w32_fullscreen_rect) Add prototype.
3339 (struct w32_output): Replace normal_width, normal_height,
3340 normal_top, and normal_left members with a single normal_placement
3342 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3344 (FRAME_NORMAL_PLACEMENT): New macro.
3346 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
3348 * minibuf.c (Ftest_completion): Silence compiler warning.
3350 2013-04-15 Eli Zaretskii <eliz@gnu.org>
3352 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
3355 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3358 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3359 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3360 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3361 parentheses where appropriate.
3363 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3365 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3367 2013-04-14 Eli Zaretskii <eliz@gnu.org>
3369 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3370 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3371 Mention in the doc string that setting these variables takes
3372 effect only after a call to set-window-buffer. (Bug#14200)
3374 2013-04-13 Eli Zaretskii <eliz@gnu.org>
3376 * indent.c (Fvertical_motion): Don't consider display strings on
3377 overlay strings as display strings on the buffer position we
3378 started from. This prevents vertical cursor motion from jumping
3379 more than one line when there's an overlay string with a display
3380 property at end of line.
3381 Reported by Karl Chen <Karl.Chen@quarl.org> in
3382 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3384 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3386 * window.c (select_window): `record_buffer' even if window is
3387 already selected (bug#14191).
3389 2013-04-11 Eli Zaretskii <eliz@gnu.org>
3391 * window.c (Fwindow_end): Test more flags, including the buffer's
3392 last_overlay_modified flag, to determine whether the window's
3393 display is really up-to-date. Prevents the function from
3394 returning a stale value. (Bug#14170)
3395 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3398 2013-04-10 Eli Zaretskii <eliz@gnu.org>
3400 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
3401 garbaged only if it is not already the top frame on its TTY.
3402 This prevents flickering due to constant redrawing of TTY frames when
3403 there are GUI frames open in the same session. (Bug#13864)
3405 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3407 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3408 of marking the idle timers directly.
3410 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3412 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3415 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3417 * window.c (select_window): Don't record_buffer while the invariant is
3418 temporarily broken (bug#14161).
3420 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3422 2013-04-07 Eli Zaretskii <eliz@gnu.org>
3424 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3426 2013-04-07 Romain Francoise <romain@orebokech.com>
3428 Ignore additional platform-specific ACL errors (Bug#13702).
3429 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3430 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3432 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3434 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3437 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3439 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3440 This bug was introduced by my 2013-02-25 change that simplified
3441 data_start configuration. Without this change, on GNU/Linux
3442 an Emacs configured with --enable-profiling fails immediately
3443 due to a profiler signal.
3444 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3445 with these flags. On platforms where special flags are needed
3446 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3447 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3448 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3450 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3452 Get rid of some platform-specific functions examining window
3453 system and its capabilities. This is a partial rework of the
3455 * lisp.h (have_menus_p): Remove prototype. This function is
3456 replaced with platform-independent window_system_available.
3457 (check_window_system): Move to...
3458 * frame.h (decode_window_system_frame, window_system_available):
3459 ...here, add new prototypes.
3460 * frame.c (window_system_available, decode_window_system_frame):
3462 (check_window_system): Platform-independent now.
3463 * xterm.h (x_in_use): Remove declaration.
3465 * w32term.h (check_x_frame):
3466 * nsterm.h (check_x_frame): Remove prototypes. This function
3467 is replaced with platform-independent decode_window_system_frame.
3468 * msdos.c (have_menus_p): Remove.
3469 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3470 Remove platform-specific functions. Use check_window_system,
3471 decode_window_system_frame and check_ns_display_info where
3472 appropriate. Minor style and comment tweaks.
3473 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3474 (check_x_frame): Likewise.
3475 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3477 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3478 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3479 * xmenu.c, xselect.c: All related users changed.
3481 2013-04-03 Kenichi Handa <handa@gnu.org>
3483 The following changes is to optimize the code for reading UTF-8
3486 * coding.c (check_ascii): Rename from detect_ascii. Return value
3487 changed. Check EOL format. Do not call adjust_coding_eol_type
3489 (check_utf_8): New function.
3490 (adjust_coding_eol_type): Do nothing if already adjusted.
3491 (detect_coding): Compare the return value of check_ascii with
3492 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3493 (decode_coding_gap): Optimize for valid UTF-8.
3495 2013-03-21 Kenichi Handa <handa@gnu.org>
3497 * coding.c (syms_of_coding): Cancel previous change.
3499 * insdel.c (insert_from_gap): Fix previous change.
3501 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3503 Consistently use platform-specific function to detect window system.
3504 * lisp.h (check_window_system): New prototype. This function is
3505 going to replace check_x, check_w32 and check_ns.
3506 (have_menus_p): Mention msdos.c in comment.
3507 * fontset.c (check_window_system_func): Remove. Adjust all users.
3508 * fontset.h (check_window_system_func): Remove prototype.
3509 * nsterm.h (check_ns):
3510 * xterm.h (check_x):
3511 * w32term.h (check_w32): Likewise.
3512 * menu.c (Fx_popup_menu): Use check_window_system.
3513 * msdos.c (check_window_system): Define for MS-DOS.
3514 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3515 * w32fns.c (check_window_system): Likewise for MS-Windows.
3516 * xfns.c (check_window_system): Likewise for X.
3517 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3518 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3520 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3522 Prefer < to > in range checks such as 0 <= i && i < N.
3523 This makes it easier to visualize quantities on a number line.
3524 This patch doesn't apply to all such range checks,
3525 only to the range checks affected by the 2013-03-24 change.
3526 This patch reverts most of the 2013-03-24 change.
3527 * alloc.c (xpalloc, Fgarbage_collect):
3528 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3529 * character.c (string_escape_byte8):
3530 * charset.c (read_hex):
3531 * data.c (cons_to_unsigned):
3532 * dispnew.c (update_frame_1):
3533 * doc.c (Fsubstitute_command_keys):
3534 * doprnt.c (doprnt):
3535 * editfns.c (hi_time, decode_time_components):
3536 * fileio.c (file_offset):
3537 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3538 * font.c (font_intern_prop):
3539 * frame.c (x_set_alpha):
3540 * gtkutil.c (get_utf8_string):
3541 * indent.c (check_display_width):
3542 * keymap.c (Fkey_description):
3543 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3545 * minibuf.c (read_minibuf_noninteractive):
3546 * process.c (wait_reading_process_output):
3547 * search.c (Freplace_match):
3548 * window.c (get_phys_cursor_glyph):
3549 * xdisp.c (redisplay_internal):
3550 * xsmfns.c (smc_save_yourself_CB):
3551 Prefer < to > for range checks.
3552 * dispnew.c (sit_for): Don't mishandle NaNs.
3553 This fixes a bug introduced in the 2013-03-24 change.
3554 * editfns.c (decode_time_components): Don't hoist comparison.
3555 This fixes another bug introduced in the 2013-03-24 change.
3557 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3559 * frame.h (struct frame): Drop scroll_bottom_vpos
3560 member becaue all real users are dead long ago.
3561 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
3562 * xdisp.c (redisplay_internal): Adjust user.
3564 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
3566 * nsmenu.m (showAtX:Y:for:): setLevel to
3567 NSPopUpMenuWindowLevel (Bug#13998).
3569 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
3571 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
3572 (ns_check_pending_open_menu): Declare.
3574 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
3575 (x_activate_menubar): Update the menu with title that matches
3576 ns_get_pending_menu_title, and call
3577 ns_check_pending_openmenu (Bug#12698).
3578 (menuWillOpen:): New method.
3579 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
3581 * nsterm.m (menu_will_open_state, menu_mouse_point)
3582 (menu_pending_title): New varaibles.
3583 (ns_get_pending_menu_title, ns_check_menu_open)
3584 (ns_check_pending_open_menu): New functions.
3586 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
3588 * indent.c (current_column_bol_cache): Remove leftover which is not
3589 used in Fmove_to_column any more.
3590 (current_column, scan_for_column): Adjust users.
3591 * keyboard.c (last_point_position_buffer, last_point_position_window):
3592 Remove leftovers which are not used for recording undo any more.
3593 (command_loop_1, syms_of_keyboard): Adjust users.
3594 * xdisp.c (last_max_ascent): Remove leftover which is not used in
3595 redisplay_window any more.
3596 (move_it_to): Adjust user.
3598 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
3600 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
3601 Update dependencies.
3603 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3605 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
3606 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
3609 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3611 * window.h (struct window): Replace hchild, vchild and buffer slots
3612 with the only contents slot. This is possible because each valid
3613 window may have either the child window (in vertical or horizontal
3614 combination) or buffer to display (for the leaf window). Using that,
3615 a lof of operations to traverse and/or change window hierarchies may
3616 be simplified. New member horizontal is used to distinguish between
3617 horizontal and vertical combinations of internal windows.
3618 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
3619 (WINDOW_VERTICAL_COMBINATION_P): New macros.
3620 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
3621 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
3622 Use contents slot, not buffer, where appropriate.
3623 (wset_combination): New function.
3624 (wset_buffer): Add eassert.
3625 (Fframe_first_window): Simplify the loop reaching first window.
3626 (Fwindow_buffer): Use WINDOW_LEAF_P.
3627 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
3628 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
3629 (unshow_buffer): Convert initial debugging check to eassert.
3630 (replace_window, recombine_windows, Fdelete_other_windows_internal)
3631 (make_parent_window, window_resize_check, window_resize_apply)
3632 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
3633 (Fset_window_configuration, delete_all_child_windows, save_window_save):
3634 Adjust to match struct window changes.
3635 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
3636 (mark_window_cursors_off, count_windows, get_leaf_windows)
3637 (foreach_window_1): Simplify the loop.
3638 * alloc.c (mark_object): Do not check for the leaf window because
3639 internal windows has no glyph matrices anyway.
3640 * dispnew.c (clear_window_matrices, showing_window_margins_p)
3641 (allocate_matrices_for_window_redisplay, fake_current_matrices)
3642 (allocate_matrices_for_frame_redisplay, free_window_matrices)
3643 (build_frame_matrix_from_window_tree, mirror_make_current)
3644 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
3645 (update_window_tree, set_window_update_flags): Simplify the loop.
3646 (sync_window_with_frame_matrix_rows): Enforce live window.
3647 Use contents slot, not buffer, where appropriate.
3648 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
3649 and WINDOW_HORIZONTAL_COMBINATION_P.
3650 (make_frame_visible_1): Simplify the loop.
3651 Use contents slot, not buffer, where appropriate.
3652 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
3653 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
3654 (expose_window_tree): Likewise.
3655 Use contents slot, not buffer, where appropriate.
3656 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
3657 to avoid deleted windows. Use contents slot instead of buffer.
3658 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
3659 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
3660 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
3661 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
3663 2013-03-28 Eli Zaretskii <eliz@gnu.org>
3665 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
3666 identify the reasons for assertion violations in bug#14062 and
3668 (Fx_show_tip): Fix compilation error under
3669 "--enable-check-lisp-object-type". (Bug#14073)
3671 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
3672 Reported by <rzl24ozi@gmail.com>.
3674 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
3676 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
3678 (unwind_with_echo_area_buffer): ...to restore it here.
3679 This is needed to ensure that...
3680 (redisplay_window): ...both window markers are valid here,
3681 which is verified by eassert.
3682 * editfns.c (save_excursion_save): Do not assume that
3683 selected_window always displays the buffer.
3684 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
3687 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
3689 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
3692 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
3694 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
3696 2013-03-27 Eli Zaretskii <eliz@gnu.org>
3698 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
3699 since MinGW's w32api headers do. This avoids compiler warnings.
3701 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
3704 2013-03-26 Eli Zaretskii <eliz@gnu.org>
3706 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
3708 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
3710 * gtkutil.c (style_changed_cb): Check if frame is live and an
3711 X frame (Bug#14038).
3713 2013-03-26 Eli Zaretskii <eliz@gnu.org>
3715 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
3716 Define only for _WIN32_WINNT less than 0x0500.
3717 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
3719 Move inclusion of time.h before sys/time.h, so that MinGW64 could
3720 see its own definitions of 'struct timeval' and 'struct timezone'.
3722 Fix incompatibilities between MinGW.org and MinGW64 headers.
3723 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
3725 * w32.c (REPARSE_DATA_BUFFER): Guard with
3726 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
3728 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
3730 * xterm.c: Include X11/XKBlib.h
3731 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
3733 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
3735 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
3737 * blockinput.h (input_blocked_p): Likewise.
3738 * bytecode.c (exec_byte_code): Likewise.
3739 * callproc.c (call_process_kill, call_process_cleanup)
3740 (Fcall_process): Likewise.
3741 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
3742 (Fccl_execute_on_string): Likewise.
3743 * character.c (string_escape_byte8): Likewise.
3744 * charset.c (read_hex): Likewise.
3745 * cm.c (calccost): Likewise.
3746 * data.c (cons_to_unsigned): Likewise.
3747 * dired.c (directory_files_internal, file_name_completion):
3749 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
3750 (sit_for): Likewise.
3751 * doc.c (Fsubstitute_command_keys): Likewise.
3752 * doprnt.c (doprnt): Likewise.
3753 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
3754 * emacsgtkfixed.c: Likewise.
3755 * fileio.c (file_offset, Fwrite_region): Likewise.
3756 * floatfns.c (Fexpt, fmod_float): Likewise.
3757 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3759 * font.c (font_intern_prop): Likewise.
3760 * frame.c (x_set_alpha): Likewise.
3761 * gtkutil.c (get_utf8_string): Likewise.
3762 * indent.c (check_display_width): Likewise.
3763 * intervals.c (create_root_interval, rotate_right, rotate_left)
3764 (split_interval_right, split_interval_left)
3765 (adjust_intervals_for_insertion, delete_node)
3766 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3767 (merge_interval_right, merge_interval_left, copy_intervals)
3768 (set_intervals_multibyte_1): Likewise.
3769 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
3770 * keymap.c (Fkey_description): Likewise.
3771 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
3772 * lread.c (openp, read_integer, read1, string_to_number):
3774 * menu.c (ensure_menu_items): Likewise.
3775 * minibuf.c (read_minibuf_noninteractive): Likewise.
3776 * print.c (printchar, strout): Likewise.
3777 * process.c (create_process, Faccept_process_output)
3778 (wait_reading_process_output, read_process_output, send_process)
3779 (wait_reading_process_output): Likewise.
3780 * profiler.c (make_log, handle_profiler_signal): Likewise.
3781 * regex.c (re_exec): Likewise.
3782 * regex.h: Likewise.
3783 * search.c (looking_at_1, Freplace_match): Likewise.
3784 * sysdep.c (get_child_status, procfs_ttyname)
3785 (procfs_get_total_memory): Likewise.
3786 * systime.h (EMACS_TIME_VALID_P): Likewise.
3787 * term.c (dissociate_if_controlling_tty): Likewise.
3788 * window.c (get_phys_cursor_glyph): Likewise.
3789 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
3790 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
3792 * xfns.c (Fx_window_property): Likewise.
3793 * xmenu.c (set_frame_menubar): Likewise.
3794 * xselect.c (x_get_window_property, x_handle_dnd_message):
3796 * xsmfns.c (smc_save_yourself_CB): Likewise.
3797 * xterm.c (x_scroll_bar_set_handle): Likewise.
3799 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
3801 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
3802 to be optional or nil. Adjust comment and convert it to docstring.
3803 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
3804 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
3806 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
3808 Static checking by GCC 4.8-20130319.
3809 * image.c (gif_load): Assume pass < 3 to pacify GCC.
3810 * process.c (Fset_process_datagram_address)
3811 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
3812 * xdisp.c (get_char_face_and_encoding):
3813 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
3814 (get_glyph_face_and_encoding): Prepare face before possibly using it.
3815 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
3817 2013-03-24 Ken Brown <kbrown@cornell.edu>
3819 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
3820 fix compilation on 64-bit Cygwin, where underscores are not
3821 automatically prepended.
3823 * w32term.c (w32_initialize): Silence compiler warning.
3825 2013-03-23 Eli Zaretskii <eliz@gnu.org>
3827 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
3828 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
3829 variables, to save and restore frame dimensions.
3830 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
3831 after returning from a 'fullscreen' configuration.
3832 use SendMessage instead of PostMessage to send the SC_RESTORE message,
3833 to avoid races between the main thread and the input thread.
3835 * w32term.h (struct w32_output): New members normal_width,
3836 normal_height, normal_top, normal_left, and prev_fsmode.
3837 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
3838 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
3841 * w32term.c (w32fullscreen_hook): Record last value of the frame's
3842 'fullscreen' parameter. Always record previous width and height
3843 of the frame, except when switching out of maximized modes, so
3844 that they could be restored correctly, instead of resetting to the
3845 default frame dimensions. Send SC_RESTORE command to the frame,
3846 unless we are going to send SC_MAXIMIZE, to restore the frame
3847 resize hints in the mouse pointer shown by the window manager.
3850 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
3852 * lisp.h (get_frame_param): Adjust conditions for prototype
3855 2013-03-22 Ken Brown <kbrown@cornell.edu>
3857 * unexcw.c: Drop unneeded inclusion of w32common.h.
3858 (report_sheap_usage): Declare.
3859 (read_exe_header): Add magic numbers for x86_64.
3860 (fixup_executable): Fix printf format specifier for unsigned long
3863 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
3865 * frame.h (struct frame): Put menu_bar_window under #ifdef
3866 because this member is not needed when X toolkit is in use.
3867 (fset_menu_bar_window):
3868 * dispnew.c (clear_current_matrices, clear_desired_matrices)
3869 (free_glyphs, update_frame):
3870 * xdisp.c (expose_frame): Likewise.
3871 (display_menu_bar): Likewise. Remove redundant eassert.
3872 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
3875 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
3877 Use functions and constants to manipulate Lisp_Save_Value objects.
3878 This replaces code that used macros and strings and token-pasting.
3879 The change makes the C source a bit easier to follow,
3880 and shrinks the Emacs executable a bit.
3881 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
3882 (make_save_value): Change 1st arg from string to enum. All callers
3885 (mark_object): Use if, not #if, for GC_MARK_STACK.
3886 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
3887 (XSAVE_OBJECT): Now functions, not macros.
3888 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
3889 the constant was never used.
3890 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
3891 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
3892 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
3893 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
3895 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
3896 type3 with a single member save_type. All uses changed.
3897 (save_type, set_save_pointer, set_save_integer): New functions.
3898 * print.c (PRINTX): Remove.
3900 * alloc.c: Remove redundant static declarations.
3902 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3904 * window.h (struct window): Convert left_col, top_line, total_lines
3905 and total_cols from Lisp_Objects to integers. Adjust comments.
3906 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
3908 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
3909 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
3910 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
3911 Adjust users where appropriate.
3913 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
3915 * frame.h (struct frame): Drop resx and resy because the same data is
3916 available from window system-specific output context. Adjust users.
3917 (default_pixels_per_inch_x, default_pixels_per_inch_y):
3918 New functions to provide defaults when no window system available.
3919 (FRAME_RES_X, FRAME_RES_Y): New macros.
3920 (NUMVAL): Move from xdisp.c.
3921 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
3922 (Ffont_face_attributes, Fopen_font):
3923 * image.c (gs_load):
3924 * w32font.c (fill_in_logfont):
3925 * xdisp.c (calc_pixel_width_or_height):
3926 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
3927 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
3929 2013-03-20 Kenichi Handa <handa@gnu.org>
3931 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
3932 to 1 (temporary workaround until a bug related to ASCII
3933 optimization is fixed).
3935 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
3937 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
3938 Signal error if window is not internal. Adjust docstring.
3939 (delete_all_child_windows): Use combination_limit to save the buffer.
3940 (Fset_window_configuration): Adjust accordingly.
3941 * print.c (syms_of_print): Initialize debugging output not here...
3942 (init_print_once): ...but in a new function here.
3943 * lisp.h (init_print_once): Add prototype.
3944 * emacs.c (main): Add call to init_print_once. Adjust comments.
3946 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
3948 * window.c (window_resize_check, window_resize_apply)
3949 (window_from_coordinates, recombine_windows, set_window_buffer)
3950 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
3951 (Fsplit_window_internal, Fdelete_window_internal)
3952 (freeze_window_starts): Use bool for booleans.
3953 * window.h (window_frame_coordinates, resize_frame_windows)
3954 (freeze_window_starts, set_window_buffer): Adjust prototypes.
3956 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
3958 * dispnew.c (bitch_at_user): Use `user-error'.
3960 2013-03-17 Ken Brown <kbrown@cornell.edu>
3962 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
3963 as return type of image_background. (Bug#13981)
3964 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
3966 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
3968 * nsterm.m (updateFrameSize:): Change resize increments if needed.
3969 (ns_select): Don't return with result uninitialized.
3971 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
3974 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
3976 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
3977 directories. If filename is nil, get directory name (Bug#13932).
3978 Use getFilename and getDirectory.
3979 (getFilename, getDirectory): New methods for EmacsSavePanel and
3981 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
3983 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
3985 * coding.c (decode_coding_gap): Fix typo caught by static checking.
3987 2013-03-15 Kenichi Handa <handa@gnu.org>
3989 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
3990 (adjust_after_replace): Make it back to static. Delete the third
3991 arg text_at_gap_tail. Cancel the code for handling it.
3993 * coding.h (struct coding_system): New member eol_seen.
3995 * coding.c (detect_ascii): New function.
3996 (detect_coding): Set coding->head_ascii and coding->eol_seen only
3997 when the source bytes are actually scanned. On detecting for
3998 coding_category_utf_8_auto, call detect_ascii instead of scanning
3999 source bytes directly.
4000 (produce_chars): Call insert_from_gap with the new arg 0.
4001 (encode_coding): Likewise.
4002 (decode_coding_gap): Control ASCII optimization by the variable
4003 disable_ascii_optimization instead of #ifndef .. #endif.
4004 Deccode EOL format according to coding->eol_seen.
4005 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4008 * lisp.h (adjust_after_replace): Cancel externing it.
4009 (insert_from_gap): Adjust prototype.
4011 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4013 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4014 FULLSCREEN_MAXIMIZED. (Bug#13935)
4016 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4018 * region-cache.c (find_cache_boundary, move_cache_gap)
4019 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4020 Simplify debugging check and convert to eassert. Adjust comment.
4021 (pp_cache): Put under ENABLE_CHECKING.
4023 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4025 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4026 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4028 (w32fullscreen_hook): If the frame is visible, reset
4029 f->want_fullscreen flag after changing the frame size. If the
4030 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4033 2013-03-13 Daniel Colascione <dancol@dancol.org>
4035 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4036 too so that these builds can use Cygwin's file conversion
4037 functions. (We've been building and linking cygw32.o all along
4038 and just not using it.)
4040 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4042 File synchronization fixes (Bug#13944).
4043 * Makefile.in (LIB_FDATASYNC): New macro.
4045 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4046 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4047 Don't worry about HAVE_FSYNC, since a substitute fsync is
4048 available if the system lacks one.
4049 (Fwrite_regin): Retry fsync if interrupted.
4051 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4053 * w32term.c (w32_read_socket): If the Emacs frame is being
4054 activated, call w32fullscreen_hook, to make sure the new frame
4055 dimensions are in effect. (Bug#13937)
4057 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4059 * xdisp.c (init_iterator): Simplify because both character and byte
4060 positions are either specified or -1. Add eassert. Adjust comment.
4061 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4062 character and byte positions can be obtained from marker.
4064 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4066 Static checking by Sun C 5.12.
4067 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4068 * bytecode.c (exec_byte_code):
4069 * dispnew.c (init_display):
4071 * fileio.c (Fsubstitute_in_file_name):
4072 * keyboard.c (Fevent_convert_list):
4073 * keymap.c (Fsingle_key_description):
4074 * term.c (maybe_fatal, fatal):
4075 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4076 * xsmfns.c (Fhandle_save_session):
4077 Omit unreachable code.
4078 * keymap.c (map_keymap_char_table_item): Cast void * to
4079 a function pointer type; the C Standard requires this.
4081 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4082 Include <sys/param.h> unconditionally, as that works elsewhere and
4083 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4084 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4087 See ChangeLog.12 for earlier changes.
4093 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4095 This file is part of GNU Emacs.
4097 GNU Emacs is free software: you can redistribute it and/or modify
4098 it under the terms of the GNU General Public License as published by
4099 the Free Software Foundation, either version 3 of the License, or
4100 (at your option) any later version.
4102 GNU Emacs is distributed in the hope that it will be useful,
4103 but WITHOUT ANY WARRANTY; without even the implied warranty of
4104 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4105 GNU General Public License for more details.
4107 You should have received a copy of the GNU General Public License
4108 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.