1 2012-02-21 Chong Yidong <cyd@gnu.org>
3 * fileio.c (Vfile_name_handler_alist): Doc fix.
5 * buffer.c (Fget_file_buffer): Protect against invalid file
8 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
10 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
11 when computing $valmask.
13 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
14 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
15 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
16 It's useless in that case, and it can cause problems on hosts
17 that allocate halves of EMACS_INT values separately.
18 Reported by Dan Horák. Diagnosed by Andreas Schwab in
19 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
20 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
21 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
22 it avoids undefined behavior on hosts where shifting right by more
23 than the word width has undefined behavior.
25 2012-02-19 Chong Yidong <cyd@gnu.org>
27 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
28 (Funhandled_file_name_directory, Ffile_name_as_directory)
29 (Fdirectory_file_name, Fexpand_file_name)
30 (Fsubstitute_in_file_name): Protect against invalid file handler
31 return values (Bug#10845).
33 2012-02-18 Eli Zaretskii <eliz@gnu.org>
35 * .gdbinit (pitx): Fix incorrect references to fields of the
38 2012-02-17 Chong Yidong <cyd@gnu.org>
40 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
42 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
44 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
45 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
47 2012-02-15 Chong Yidong <cyd@gnu.org>
49 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
50 marked as special. Also, starting docstrings with * is obsolete.
52 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
54 * gnutls.c (emacs_gnutls_write): Fix last change.
56 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
58 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
61 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
63 * keymap.c (Fsingle_key_description): Handle char ranges.
65 2012-02-12 Chong Yidong <cyd@gnu.org>
67 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
68 as that creates a dangerous corner case.
70 * window.c (Fdelete_window_internal): Invalidate the mouse
73 2012-02-12 Glenn Morris <rgm@gnu.org>
75 * xselect.c (Fx_own_selection_internal)
76 (Fx_get_selection_internal, Fx_disown_selection_internal)
77 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
78 * nsselect.m (Fx_own_selection_internal)
79 (Fx_disown_selection_internal, Fx_selection_exists_p)
80 (Fx_selection_owner_p, Fx_get_selection_internal):
81 Sync docs and argument specs with the xselect.c versions.
83 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
85 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
87 2012-02-11 Eli Zaretskii <eliz@gnu.org>
89 * w32select.c (Fx_selection_exists_p): Sync doc string and
90 argument list with xselect.c. (Bug#10783)
92 * w16select.c (Fx_selection_exists_p): Sync doc string and
93 argument list with xselect.c. (Bug#10783)
95 2012-02-10 Glenn Morris <rgm@gnu.org>
97 * fns.c (Fsecure_hash): Doc fix.
99 2012-02-09 Kenichi Handa <handa@m17n.org>
101 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
103 2012-02-07 Chong Yidong <cyd@gnu.org>
105 * buffer.c (Fbuffer_local_variables)
106 (buffer_lisp_local_variables): Handle unbound vars correctly;
107 don't let Qunbound leak into Lisp.
109 2012-02-07 Glenn Morris <rgm@gnu.org>
111 * image.c (Fimagemagick_types): Doc fix.
113 * image.c (imagemagick-render-type): Change it from a lisp object
114 to an integer. Move the doc here from the lisp manual.
115 Treat all values not equal to 0 the same.
117 2012-02-06 Chong Yidong <cyd@gnu.org>
119 * doc.c (store_function_docstring): Avoid applying docstring of
120 alias to base function (Bug#2603).
122 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
124 * .gdbinit (pp1, pv1): Remove redundant defines.
127 2012-02-04 Chong Yidong <cyd@gnu.org>
129 * nsterm.m: Declare a global (Bug#10694).
131 2012-02-04 Eli Zaretskii <eliz@gnu.org>
133 * w32.c (get_emacs_configuration_options): Include
134 --enable-checking, if specified, in the return value.
136 2012-02-04 Martin Rudalics <rudalics@gmx.at>
138 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
139 after rounding frame sizes. (Bug#9723)
141 2012-02-04 Eli Zaretskii <eliz@gnu.org>
143 * keyboard.c (adjust_point_for_property): Don't position point
144 before BEGV. (Bug#10696)
146 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
148 Handle overflow when computing char display width (Bug#9496).
149 * character.c (char_width): Return EMACS_INT, not int.
150 (char_width, c_string_width): Check for overflow when
151 computing the width; this is possible now that individual
152 characters can have unbounded width. Problem introduced
153 by merge from Emacs 23 on 2012-01-19.
155 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
157 * dbusbind.c (Fdbus_register_method): Mention the return value
158 :ignore in the docstring.
160 2012-02-02 Glenn Morris <rgm@gnu.org>
162 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
164 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
165 Unconditionally set to t. (Bug#10673)
166 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
167 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
168 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
170 2012-02-02 Kenichi Handa <handa@m17n.org>
172 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
173 0, do not call append_composite_glyph.
175 2012-02-02 Kenichi Handa <handa@m17n.org>
177 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
179 (x_produce_glyphs): If the component of a composition is a null
180 string, set it->pixel_width to 1 to avoid zero-width glyph.
182 2012-02-01 Eli Zaretskii <eliz@gnu.org>
184 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
185 first 2 arguments are identical. This makes inserting large
186 output from a subprocess an order of magnitude faster on
187 MS-Windows, where all sbrk'ed memory is always contiguous.
189 2012-01-31 Glenn Morris <rgm@gnu.org>
191 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
192 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
193 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
195 2012-01-29 Glenn Morris <rgm@gnu.org>
197 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
199 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
201 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
203 2012-01-28 Chong Yidong <cyd@gnu.org>
205 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
207 2012-01-26 Chong Yidong <cyd@gnu.org>
209 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
211 * search.c (Fsearch_forward, Fsearch_backward): Document negative
212 repeat counts (Bug#10507).
214 2012-01-26 Glenn Morris <rgm@gnu.org>
216 * lread.c (syms_of_lread): Doc fix.
218 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
220 * coding.c (encode_designation_at_bol): Change return value to
223 2012-01-25 Chong Yidong <cyd@gnu.org>
225 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
227 2012-01-21 Chong Yidong <cyd@gnu.org>
229 * floatfns.c (Fcopysign): Make the second argument non-optional,
230 since nil is not allowed anyway.
232 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
234 * process.c (read_process_output): Use p instead of XPROCESS (proc).
235 (send_process): Likewise.
237 2012-01-19 Martin Rudalics <rudalics@gmx.at>
239 * window.c (save_window_save, Fcurrent_window_configuration)
240 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
243 2012-01-19 Kenichi Handa <handa@m17n.org>
245 * character.c (char_width): New function.
246 (Fchar_width, c_string_width, lisp_string_width):
247 Use char_width (Bug#9496).
249 2012-01-16 Martin Rudalics <rudalics@gmx.at>
251 * window.c (Vwindow_persistent_parameters): New variable.
252 (Fset_window_configuration, save_window_save): Handle persistent
255 2012-01-14 Eli Zaretskii <eliz@gnu.org>
257 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
258 thrashing the stack of the thread. (Bug#9087)
260 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
262 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
264 2012-01-11 Eli Zaretskii <eliz@gnu.org>
266 * xdisp.c (rows_from_pos_range): Handle the case where the
267 highlight ends on a newline. (Bug#10464)
268 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
269 he end column for display of highlight that ends on a newline
272 2012-01-11 Glenn Morris <rgm@gnu.org>
274 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
275 from load-path also when installation-directory is nil. (Bug#10208)
277 2012-01-10 Glenn Morris <rgm@gnu.org>
279 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
281 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
282 Update template values to be closer to their typical values these days.
284 2012-01-09 Eli Zaretskii <eliz@gnu.org>
286 * xdisp.c (rows_from_pos_range): Accept additional argument
287 DISP_STRING, and accept any glyph in a row whose object is that
288 string as eligible for mouse highlight. Fixes mouse highlight of
289 display strings from overlays. (Bug#10464)
291 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
293 emacs: fix an auto-save permissions race condition (Bug#10400)
294 * fileio.c (auto_saving_dir_umask): New static var.
295 (Fmake_directory_internal): Use it.
296 (do_auto_save_make_dir): Set it, instead of invoking chmod after
297 creating the directory. The old code temporarily assigns
298 too-generous permissions to the directory.
299 (do_auto_save_eh): Clear it.
300 (Fdo_auto_save): Catch all errors, not just file errors, so
301 that the var is always cleared.
303 2012-01-07 Eli Zaretskii <eliz@gnu.org>
305 * search.c (scan_buffer): Pass character positions to
306 know_region_cache, not byte positions. (Bug#6540)
308 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
310 * w32.c (sys_rename): Report EXDEV when rename of a directory
311 fails because the target is on another logical disk. (Bug#10284)
313 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
315 * xterm.c (x_embed_request_focus): New function.
317 * xterm.h: Add prototype.
319 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
321 2012-01-05 Glenn Morris <rgm@gnu.org>
323 * emacs.c (emacs_copyright): Update short copyright year to 2012.
325 2012-01-01 Eli Zaretskii <eliz@gnu.org>
327 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
328 Load gnutls_transport_set_lowat only if GnuTLS version is below
330 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
331 GnuTLS versions below 2.11.1.
333 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
335 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
336 to the doc string advising against its use for altering the way
337 windows are scrolled.
339 2011-12-28 Kenichi Handa <handa@m17n.org>
341 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
342 coding-system ASCII compatible only when it does not produce BOM
343 on encoding (Bug#10383).
345 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
347 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
349 (create_and_show_popup_menu): Always use menu_position_func for
352 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
354 * callint.c (Fcall_interactively): Don't truncate prompt string.
356 2011-12-23 Eli Zaretskii <eliz@gnu.org>
358 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
359 property that ends at ZV, so that the bidi iteration could be
360 resumed from there (after widening). (Bug#10360)
362 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
364 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
366 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
368 * nsterm.m (x_free_frame_resources):
369 Release f->output_data.ns->miniimage.
370 (ns_index_color): Fix indentation. Do not retain
371 color_table->colors[i].
373 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
376 * nsfns.m (x_set_background_color): Assign return value from
377 ns_index_color to face-background instead of NSColor*.
378 (ns_implicitly_set_icon_type): Fix indentation.
379 Change assignment in for loop to comparison.
381 * emacs.c (ns_pool): New variable.
382 (main): Assign ns_pool.
383 (Fkill_emacs): Call ns_release_autorelease_pool.
385 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
386 autorelease fdesc, release fdAttrs and tdict.
387 (ns_get_covering_families): Release charset.
388 (ns_findfonts): Release NSFontDescriptor created with new.
389 (ns_uni_to_glyphs): Fix indentation.
390 (setString): Release attrStr before assigning new value.
392 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
394 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
396 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
397 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
399 2011-12-18 David Reitter <reitter@cmu.edu>
401 * nsterm.m (ns_term_init): Subscribe for notifications
402 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
403 to method trackingNotification in EmacsMenu.
405 * nsmenu.m (trackingMenu): New variable.
406 (trackingNotification): New method (from Aquamacs).
407 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
408 from Aquamacs (Bug#7030).
410 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
412 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
413 (symbol_to_nsstring): Fix indentation.
414 (ns_symbol_to_pb): New function.
415 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
416 (Fns_rotate_cut_buffers_internal): Removed.
417 (Fns_store_selection_internal): Renamed from
418 Fns_store_cut_buffer_internal.
419 (ns_get_foreign_selection, Fx_own_selection_internal)
420 (Fx_disown_selection_internal, Fx_selection_exists_p)
421 (Fns_get_selection_internal, Fns_store_selection_internal):
422 Use ns_symbol_to_pb and check if return value is nil.
423 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
424 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
425 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
426 renamed to Sns_store_selection_internal.
427 (ns_handle_selection_request): Move code to Fx_own_selection_internal
428 and remove this function.
429 (ns_handle_selection_clear): Remove, never used.
430 (Fx_own_selection_internal): Move code from ns_handle_selection_request
433 2011-12-17 Ken Brown <kbrown@cornell.edu>
435 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
436 GID is unknown (Bug#10257).
438 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
440 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
441 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
442 which caused a build failure on GNU/Linux IA-64. This problem was
443 introduced by my 2011-10-07 patch.
445 2011-12-15 Juri Linkov <juri@jurta.org>
447 * image.c (imagemagick_error): New function. (Bug#10112)
448 (imagemagick_load_image): Comment out `MagickSetResolution' call.
449 Use `imagemagick_error' where ImageMagick functions return
451 (Fimagemagick_types): Add `Fnreverse' to return the list in the
454 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
456 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
457 fill background (Bug#8992).
459 2011-12-13 Martin Rudalics <rudalics@gmx.at>
461 * window.c (Vwindow_combination_resize)
462 (Vwindow_combination_limit): Use t instead of non-nil in
464 (Vrecenter_redisplay): Add first sentence of doc-string on
466 (Frecenter): Fix doc-string typo.
468 2011-12-11 Kenichi Handa <handa@m17n.org>
470 * coding.c (Funencodable_char_position): Pay attention to the
471 buffer text relocation (Bug#9389).
473 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
475 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
476 gtk_init (Bug#10100).
478 2011-12-10 Eli Zaretskii <eliz@gnu.org>
480 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
481 IT->string is nil. (Bug#10263)
483 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
485 * nsterm.h (x_free_frame_resources): Declare.
487 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
488 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
490 * nsterm.h (ns_get_defaults_value): Declare.
492 * nsterm.m (ns_default): Call ns_get_defaults_value.
494 2011-12-09 Eli Zaretskii <eliz@gnu.org>
496 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
499 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
501 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
502 that where the value of an _OBJC_* symbol points to is in the .bss
505 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
507 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
508 after the loop to call ccl_driver at least once (Bug#8619).
510 2011-12-08 Kenichi Handa <handa@m17n.org>
512 * ftfont.c (get_adstyle_property): Fix previous change
515 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
517 * w32.c (init_environment): If no_site_lisp, remove site-lisp
518 dirs from the default value of EMACSLOADPATH (bug#10208).
520 2011-12-07 Glenn Morris <rgm@gnu.org>
522 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
523 installation and source directories as well. (Bug#10208)
525 2011-12-06 Chong Yidong <cyd@gnu.org>
527 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
529 2011-12-06 Glenn Morris <rgm@gnu.org>
531 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
532 as an error, not just -1. (Bug#10217)
534 2011-12-05 Chong Yidong <cyd@gnu.org>
536 * keyboard.c (process_special_events): New function.
537 (swallow_events, Finput_pending_p): Use it (Bug#10195).
539 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
541 * coding.c (encode_designation_at_bol): Don't use uninitialized
542 local variable (Bug#9318).
544 2011-12-05 Kenichi Handa <handa@m17n.org>
546 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
547 return Qnil (Bug#8046, Bug#10193).
549 2011-12-05 Kenichi Handa <handa@m17n.org>
551 * coding.c (encode_designation_at_bol): New args charbuf_end and
552 dst. Return the number of produced bytes. Callers changed.
553 (coding_set_source): Return how many bytes coding->source was
555 (coding_set_destination): Return how many bytes
556 coding->destination was relocated.
557 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
558 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
560 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
562 * coding.c (CODING_CHAR_CHARSET_P): New macro.
563 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
566 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
568 The following changes are to fix Bug#9318.
570 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
571 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
572 (encode_coding_iso_2022, encode_coding_sjis)
573 (encode_coding_big5, encode_coding_charset): Use the above macros.
575 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
577 * lisp.h (process_quit_flag): Fix external declaration.
579 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
581 Don't macro-inline non-performance-critical code.
582 * eval.c (process_quit_flag): New function.
583 * lisp.h (QUIT): Use it.
585 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
587 * nsfns.m (get_geometry_from_preferences): New function.
588 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
590 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
592 * emacs.c (Qkill_emacs): Define.
593 (syms_of_emacs): Initialize it.
594 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
595 Qquit_flag to `kill-emacs' instead.
596 (quit_throw_to_read_char): Add parameter `from_signal'.
597 All callers changed. Call Fkill_emacs if requested and safe.
598 * lisp.h (QUIT): Call Fkill_emacs if requested.
600 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
602 * widget.c (update_wm_hints): Return if wmshell is null.
603 (widget_update_wm_size_hints): New function.
605 * widget.h (widget_update_wm_size_hints): Declare.
607 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
608 widget_update_wm_size_hints (Bug#10104).
610 2011-12-03 Eli Zaretskii <eliz@gnu.org>
612 * xdisp.c (handle_invisible_prop): If the invisible text ends just
613 before a newline, prepare the bidi iterator for consuming the
614 newline, and keep the current paragraph direction. (Bug#10183)
615 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
617 2011-12-02 Juri Linkov <juri@jurta.org>
619 * search.c (Fword_search_regexp): New Lisp function created from
620 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
621 (Fword_search_backward, Fword_search_forward)
622 (Fword_search_backward_lax, Fword_search_forward_lax):
623 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
624 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
626 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
628 * fileio.c (Finsert_file_contents): Move after-change-function call
629 to before the "handled:" label, since all "goto handled" appear in
630 cases where the *-change-functions have already been properly called
633 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
635 * keyboard.c (interrupt_signal): Don't call kill-emacs when
636 waiting for input. (Bug#10169)
638 2011-11-30 Eli Zaretskii <eliz@gnu.org>
640 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
641 verifies glyph row's hash code--we have just reallocated the
642 glyphs, so their contents can be complete garbage. (Bug#10164)
644 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
646 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
648 2011-11-30 Eli Zaretskii <eliz@gnu.org>
650 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
651 attributes are tested _before_ calling verify_row_hash, to protect
652 against GCC re-ordering of the tests. (Bug#10164)
654 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
656 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
658 * xterm.c (handle_one_xevent): Only set async_visible and friends
659 if net_wm_state_hidden_seen is non-zero (Bug#10002)
660 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
661 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
663 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
665 Remove GCPRO-related macros that exist only to avoid shadowing locals.
666 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
667 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
668 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
669 All uses changed to use GCPRO1 etc.
670 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
671 Revert to old implementation (i.e., before 2011-03-11).
673 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
675 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
676 of scroll runs so as to avoid assigning disabled bogus rows and
677 unnecessary graphics copy operations.
679 2011-11-27 Eli Zaretskii <eliz@gnu.org>
681 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
682 (snprintf) [_MSC_VER]: Redirect to _snprintf.
683 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
684 (malloc, free, realloc, calloc): Redirect to e_* only when
687 * lisp.h (GCTYPEBITS): Move before first use.
688 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
689 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
690 this macro definition.
692 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
695 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
697 * gtkutil.c (xg_create_frame_widgets):
698 Call gtk_window_set_has_resize_grip (FALSE) if that function is
699 present with Gtk+ 2.0.
701 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
703 * fileio.c (Finsert_file_contents): Undo previous change; see
704 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
706 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
708 Rename locals to avoid shadowing.
709 * fileio.c (Finsert_file_contents):
710 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
711 * process.c (wait_reading_process_output):
712 Rename inner 'proc' to 'p' to avoid shadowing.
713 Indent for consistency with usual Emacs style.
715 2011-11-25 Eli Zaretskii <eliz@gnu.org>
717 * xdisp.c (redisplay_window): If cursor row is not fully visible
718 after recentering, and scroll-conservatively is set to a large
719 number, scroll window by a few more lines to make the cursor fully
720 visible and out of scroll-margin. (Bug#10105)
721 (start_display): Don't move to the next line if the display should
722 start at a newline that is part of a display vector or an overlay
725 2011-11-24 Juri Linkov <juri@jurta.org>
727 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
728 after the `MagickPingImage' call. (Bug#10112)
730 2011-11-23 Chong Yidong <cyd@gnu.org>
732 * window.c (Fcoordinates_in_window_p): Accept only live windows.
734 2011-11-23 Martin Rudalics <rudalics@gmx.at>
736 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
737 making another buffer current. (Bug#10114)
739 2011-11-23 Glenn Morris <rgm@gnu.org>
741 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
743 2011-11-23 Chong Yidong <cyd@gnu.org>
745 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
748 2011-11-22 Eli Zaretskii <eliz@gnu.org>
750 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
751 and header-lines, as they don't have one computed for them.
754 * .gdbinit (prow): Make displayed values more self-explaining.
757 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
759 * process.c (wait_reading_process_output): Fix asynchrounous
760 GnuTLS socket handling on some versions of the GnuTLS library.
761 (wait_reading_process_output): Add comment and URL.
763 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
765 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
767 2011-11-21 Chong Yidong <cyd@gnu.org>
769 * window.c (Fnext_window, Fprevious_window): Doc fix.
771 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
773 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
775 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
777 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
779 2011-11-20 Martin Rudalics <rudalics@gmx.at>
781 * window.c (Fset_window_combination_limit): Rename argument
783 (Vwindow_combination_limit): Remove "status" from doc-string.
785 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
787 * m/ibms390.h: Remove.
788 * m/ibms390x.h: Don't include "ibms390.h".
790 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
792 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
793 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
795 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
797 * casetab.c (Fset_case_table):
798 * charset.c (Fcharset_after): Fix typos.
800 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
802 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
803 Otherwise, valgrind does not work on some platforms.
804 Problem reported by Andreas Schwab in
805 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
806 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
807 is set, removing the need for VIRT_ADDRESS_VARIES.
808 (PURE_P): Use a more-efficient implementation that needs just one
809 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
810 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
811 to 4 (xorl, subq, cmpq, setbe).
812 * alloc.c (pure): Always extern now, since that's the
813 VIRT_ADDR_VARIES behavior.
814 (PURE_POINTER_P): Use a single comparison, not two, for
815 consistency with the new puresize.h.
816 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
817 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
818 Remove VIRT_ADDR_VARIES no longer needed.
820 2011-11-19 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
823 (erase_phys_cursor, update_window_cursor, show_mouse_face)
824 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
825 behave as if the cursor position were at the window margin.
827 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
828 and the cursor position is out of bounds, behave as if the cursor
829 position were at the window margin. (Bug#10075)
831 2011-11-18 Chong Yidong <cyd@gnu.org>
833 * window.c (Fwindow_combination_limit): Make first argument
834 non-optional, since it is meaningless for live windows like the
837 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
839 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
841 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
843 * intervals.c: Fix grafting over the whole buffer (bug#10071).
844 (graft_intervals_into_buffer): Simplify.
846 2011-11-18 Eli Zaretskii <eliz@gnu.org>
848 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
849 hash values of the two rows.
850 (copy_row_except_pointers): Preserve the used[] arrays and the
851 hash values of the two rows. (Bug#10035)
852 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
854 * xdisp.c (row_hash): New function, body extracted from
855 compute_line_metrics.
856 (compute_line_metrics): Call row_hash, instead of computing the
859 * dispnew.c (verify_row_hash): Call row_hash for computing the
860 hash code of a row, instead of duplicating code from xdisp.c.
862 * dispextern.h (row_hash): Add prototype.
864 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
866 * frame.c (delete_frame): Don't delete the terminal when the last
867 X frame is closed if emacs is built with GTK toolkit.
869 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
871 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
873 2011-11-17 Martin Rudalics <rudalics@gmx.at>
875 * window.c (Vwindow_splits): Rename to
876 Vwindow_combination_resize. Suggested by Juri Linkov.
877 (Fsplit_window_internal): Use Vwindow_combination_resize instead
880 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
882 * nsfns.m (Fns_font_name):
883 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
885 2011-11-16 Martin Rudalics <rudalics@gmx.at>
887 * window.h (window): Rename slot "nest" to "combination_limit".
888 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
889 (Fset_window_nest): Rename to Fset_window_combination_limit.
890 (Vwindow_nest): Rename to Vwindow_combination_limit.
891 (recombine_windows, make_parent_window, make_window)
892 (Fsplit_window_internal, saved_window)
893 (Fset_window_configuration, save_window_save): Rename all
894 occurrences of window_nest to window_combination_limit.
896 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
898 * image.c (imagemagick_load_image): Fix typo.
900 2011-11-14 Eli Zaretskii <eliz@gnu.org>
902 * xdisp.c (display_line): Move the call to
903 highlight_trailing_whitespace before the call to
904 compute_line_metrics, since the latter needs to see the final
905 faces of all the glyphs to compute ROW's hash value.
906 Fixes assertion violations in row_equal_p. (Bug#10035)
908 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
910 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
911 just return (bug#10044).
913 2011-11-12 Eli Zaretskii <eliz@gnu.org>
915 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
916 with user-defined heap size. Bump the default size of the temacs
917 heap to 27MB, to avoid memory warning when running temacs.
918 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
920 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
921 current_matrix and desired_matrix. (Bug#9990)
922 (verify_row_hash) [XASSERTS]: New function.
923 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
924 that the hash value of glyph rows is correct.
926 2011-11-12 Martin Rudalics <rudalics@gmx.at>
928 * window.h (window): Remove splits slot.
929 * window.c (Fwindow_splits, Fset_window_splits): Remove.
930 (Fdelete_other_windows_internal, make_parent_window)
931 (make_window, Fsplit_window_internal, Fdelete_window_internal)
932 (Fset_window_configuration, save_window_save): Don't deal with
933 split status of windows.
934 (saved_window): Remove splits slot.
935 (Vwindow_splits): Rewrite doc-string.
937 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
939 * xfns.c (unwind_create_frame):
940 * nsfns.m (unwind_create_frame):
941 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
942 Vframe_list (Bug#9999).
944 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
946 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
948 2011-11-11 Kenichi Handa <handa@m17n.org>
950 * callproc.c (Fcall_process): Set the member dst_multibyte of
953 2011-11-11 Johan Bockgård <bojohan@gnu.org>
955 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
956 avoid a crash (bug#9496).
958 2011-11-09 Chong Yidong <cyd@gnu.org>
960 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
961 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
963 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
965 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
967 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
969 Avoid some portability problems by eschewing 'extern inline' functions.
970 The trivial performance wins aren't worth the portability hassles; see
971 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
973 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
974 (window_box_width, window_box_left, window_box_left_offset)
975 (window_box_right, window_box_right_offset): Undo previous change,
976 by removing the "extern"s.
977 * intervals.c (adjust_intervals_for_insertion)
978 (adjust_intervals_for_deletion): Undo previous change,
979 making these static again.
980 (offset_intervals, temp_set_point_both, temp_set_point)
981 (copy_intervals_to_string): No longer inline.
982 * xdisp.c (window_text_bottom_y, window_box_width)
983 (window_box_height, window_box_left_offset)
984 (window_box_right_offset, window_box_left, window_box_right)
985 (window_box): No longer inline.
987 2011-11-08 Chong Yidong <cyd@gnu.org>
989 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
990 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
991 Signal an error if not a live window.
992 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
993 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
995 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
997 * lisp.h (syms_of_abbrev): Remove declaration.
998 Reported by CHENG Gao <chenggao@royau.me>.
1000 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1002 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1003 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1004 of temacs in GUI mode.
1006 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1008 * window.h: Declare delete_all_child_windows instead of
1009 delete_all_subwindows.
1010 * window.c (Fwindow_nest, Fset_window_nest)
1011 (Fset_window_new_total, Fset_window_new_normal)
1012 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1013 (delete_all_subwindows): Rename to delete_all_child_windows.
1014 (Fdelete_other_windows_internal, Fset_window_configuration):
1015 Call delete_all_child_windows instead of delete_all_subwindows.
1016 * frame.c (delete_frame): Call delete_all_child_windows instead
1017 of delete_all_subwindows.
1019 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1021 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1022 This is also needed for porting to any host where GC_MARK_STACK is
1023 not GC_MAKE_GCPROS_NOOPS.
1024 (which_symbols): Use it.
1026 2011-11-07 Kenichi Handa <handa@m17n.org>
1028 * coding.c (coding_set_destination): Check coding->src_pos only
1029 when coding->src_object is a buffer (bug#9910).
1031 * process.c (send_process): Set the member src_multibyte of coding
1032 to 0 (bug#9911) when sending a unibyte text.
1034 * callproc.c (Fcall_process): Set the member src_multibyte of
1035 process_coding to 0 (bug#9912).
1037 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1039 * xmenu.c (cleanup_widget_value_tree): New function.
1040 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1041 calling free_menubar_widget_value_tree directly (Bug#9830).
1043 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1045 Fix some portability problems with 'inline'.
1046 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1047 (window_box_width, window_box_left, window_box_left_offset)
1048 (window_box_right, window_box_right_offset): Declare extern.
1049 Otherwise, these inline functions do not conform to C99 and
1050 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1051 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1052 * intervals.c (adjust_intervals_for_insertion)
1053 (adjust_intervals_for_deletion): Now extern, because otherwise the
1054 extern inline functions 'offset_intervals' couldn't refer to it.
1055 (static_offset_intervals): Remove.
1056 (offset_intervals): Rewrite using the old contents of
1057 static_offset_intervals. The old version didn't conform to C99
1058 because an extern inline function contained a reference to an
1059 identifier with static linkage.
1061 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1063 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1066 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1069 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1070 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1071 return Qleft_to_right.
1073 2011-11-06 Chong Yidong <cyd@gnu.org>
1075 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1076 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1077 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1078 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1079 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1080 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1081 (Fwindow_vscroll): Doc fix.
1082 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1083 argument, since it makes no sense to pass a live window and for
1084 consistency with window-child.
1086 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1088 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1091 2011-11-05 Jason Rumney <jasonr@gnu.org>
1093 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1094 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1096 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1097 bitwise arithmetic preventing use of unicode-sip and non-truetype
1100 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1102 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1105 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1106 initialization code to keep similarity to xfns.c after changes
1109 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1111 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1112 (unwind_create_frame): New function (Bug#9943).
1113 (Fx_create_frame): Restructure code to be more similar to the one in
1114 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1115 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1116 Move terminal->reference_count++ just before making the frame official
1119 * nsterm.m (x_free_frame_resources): New function.
1120 (x_destroy_window): Move code to x_free_frame_resources.
1122 * xfns.c (unwind_create_frame): Fix comment.
1123 (Fx_create_frame, x_create_tip_frame):
1124 Move terminal->reference_count++ just before making the frame
1125 official. Move initialization of image_cache_refcount and
1126 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1128 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1130 Support MSVC build with newer versions of Visual Studio.
1131 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1132 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1135 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1136 which are not supported by MSVC.
1137 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1138 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1140 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1142 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1144 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1146 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1148 Support MSVC build with newer versions of Visual Studio.
1149 * w32.c: Don't include w32api.h for MSVC.
1150 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1152 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1153 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1154 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1155 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1157 (alloca) [_MSC_VER]: Define to _alloca.
1159 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1161 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1163 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1165 * xdisp.c (note_mouse_highlight): If either of
1166 previous/next-single-property-change returns nil, treat that as
1167 the beginning or the end of the buffer. (Bug#9955)
1169 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1171 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1172 label is not null (Bug#9951).
1173 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1176 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1178 * window.c (Fwindow_body_size): Mention in the doc string that the
1179 return value is in frame's canonical units. (Bug#9949)
1181 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1183 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1185 * w32fns.c (unwind_create_frame): If needed, free the glyph
1186 matrices of the partially constructed frame. (Bug#9943)
1187 * xfns.c (unwind_create_frame): Likewise.
1189 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1191 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1192 Don't stop backward scan on the continuation glyph, even though
1193 its CHARPOS is positive.
1194 (mouse_face_from_buffer_pos, note_mouse_highlight):
1195 Rename cover_string to disp_string.
1197 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1199 * window.c (temp_output_buffer_show): Don't use
1200 Vtemp_buffer_show_specifiers.
1201 (Vtemp_buffer_show_specifiers): Remove unused variable.
1203 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1205 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1206 past the beginning of the current glyph matrix.
1208 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1210 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1211 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1212 HAVE_GTK3 (Bug#9869).
1214 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1215 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1217 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1219 * xterm.c: Declare x_handle_net_wm_state to return int.
1220 (handle_one_xevent): Check if we are iconified but don't have
1221 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1222 (get_current_wm_state): Return non-zero if not hidden,
1223 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1224 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1225 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1226 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1228 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1230 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1231 so that this new function doesn't get optimized away by a
1232 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1234 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1236 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1238 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1240 Fix the `xbytecode' command.
1241 * .gdbinit (xprintbytestr): New command.
1242 (xwhichsymbols): Rename from `which'; all callers changed.
1243 (xbytecode): Print the byte-code string as well.
1245 2011-10-29 Kim Storm <storm@cua.dk>
1247 * alloc.c (which_symbols): New function.
1249 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1251 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1254 2011-10-29 Glenn Morris <rgm@gnu.org>
1256 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1257 Not clear what it was for, and it causes various bugs. (Bug#9839)
1259 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1261 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1262 possible random value that matches one of those tested as
1263 condition to clear the mouse face.
1265 2011-10-28 Chong Yidong <cyd@gnu.org>
1267 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1269 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1271 * window.c (make_window): Initialize phys_cursor_on_p.
1273 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1275 * lisp.h (struct Lisp_Symbol): Update comments.
1277 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1279 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1281 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1283 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1284 <oslsachem@gmail.com> for helping to debug this.
1286 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1287 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1288 (g_b_init_get_glyph_outline_w): New static variables.
1289 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1290 (GetGlyphOutlineW_Proc): New typedefs.
1291 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1292 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1294 (w32font_open_internal, compute_metrics):
1295 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1296 instead of calling the "wide" APIs directly.
1298 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1300 * w32.h (syms_of_w32font): Add prototype.
1302 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1304 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1305 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1306 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1307 (Fmove_to_window_line): Doc fix.
1309 2011-10-27 Chong Yidong <cyd@gnu.org>
1311 * process.c (make_process): Set gnutls_state to NULL.
1313 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1314 non-NULL, regardless of GNUTLS_INITSTAGE.
1315 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1316 an error. Set process slots as soon as we allocate them.
1318 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1320 2011-10-27 Chong Yidong <cyd@gnu.org>
1322 * gnutls.c (emacs_gnutls_deinit): New function.
1323 Deallocate credentials structures as well as calling gnutls_deinit.
1324 (Fgnutls_deinit, Fgnutls_boot): Use it.
1326 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1327 (deactivate_process): Call emacs_gnutls_deinit.
1329 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1331 * image.c (x_create_x_image_and_pixmap):
1332 * w32.c (sys_rename, w32_delayed_load):
1333 * w32font.c (fill_in_logfont):
1334 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1336 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1338 * w32fns.c (w32_default_color_map): New function,
1339 extracted from Fw32_default_color_map.
1340 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1342 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1344 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1346 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1348 * keyboard.c (test_undefined): New function (bug#9751).
1349 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1351 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1353 * sysdep.c (init_sys_modes): Fix the check for the controlling
1354 terminal (Bug#6649).
1356 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1358 * dispextern.h (struct bidi_it): New member next_en_type.
1360 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1361 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1362 current character, check also for next_en_type being WEAK_EN.
1363 (bidi_resolve_weak): Don't enter the expensive loop if the current
1364 position is before next_en_pos. Record the bidi type of the first
1365 non-ET, non-BN character we find, in addition to its position.
1366 (bidi_level_of_next_char): Invalidate next_en_type when
1367 next_en_pos is over-stepped.
1369 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1371 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1372 * editfns.c: Rewrite current-time-zone so that it invokes
1373 the equivalent of (format-time-string "%Z") to get the time zone name.
1374 This fixes a bug when the time zone name contains characters that
1375 need converting from the system time locale to Emacs internal format.
1376 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1377 that patch fixed format-time-string to do the conversion, but
1378 I forgot to fix current-time-zone.
1379 (format_time_string): New function, containing most of
1380 what Fformat_time_string used to contain.
1381 (Fformat_time_string): Rewrite in terms of format_time_string.
1382 This doesn't change this function's behavior.
1383 (current-time-zone): Rewrite to use format_time_string.
1384 This fixes the bug reported by Michael Schierl in
1385 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1386 Jason Rumney's 2007-06-07 change worked around this bug, but
1388 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1390 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1392 * xdisp.c (start_display): If the character at POS is displayed
1393 via a display vector, reset IT->current.dpvec_index to zero.
1394 (try_window_reusing_current_matrix): If a line ends in a display
1395 vector or the next line starts in a display vector, continue
1396 redrawing the window even though the character position of
1397 start_row was reached.
1400 2011-10-18 Chong Yidong <cyd@gnu.org>
1402 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1403 with nobreak-char-display too.
1405 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1407 Fix part 3 of bug#9771.
1408 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1409 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1410 non-neutral characters if the current character is a paragraph
1411 separator (a.k.a. Newline). This avoids running the same
1412 expensive loop twice, once when we consume the preceding newline
1413 and the other time when the line actually needs to be displayed.
1414 Avoid the loop when we see neutrals on the base embedding level
1415 following a character whose directionality is the same as the
1416 paragraph's. This avoids running the expensive loop when a line
1417 ends in a long sequence of neutrals, like control characters.
1418 Add assertion against STRONG_AL type. Slightly rearrange code
1419 that determines the type of a neutral given the first non-neutral
1421 (bidi_level_of_next_char): Set next_en_pos to zero when
1422 invalidating its info.
1424 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1426 * xdisp.c (push_display_prop): Determine whether to record string
1427 or buffer position by IT->string, not by IT->method. Allow
1428 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1429 (move_it_vertically_backward): Don't look for character position
1430 immediately after the newline when in a continuation line.
1433 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1435 * window.c (coordinates_in_window): Rewrite and delabelize
1436 vertical border check. (Bug#5357) (Bug#9618)
1438 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1440 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1441 errors in XSetWindowBorder (bug#9310).
1443 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1445 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1446 avoid crash when xmalloc overrun checking is enabled.
1448 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1450 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1451 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1452 cursor motion with <left> and <right> arrow keys.
1454 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1455 some callers set that themselves.
1457 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1459 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1460 display string and the previous row comes from the same string and
1461 is empty. (Bug#9739) (Bug#9738)
1463 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1465 * doc.c (get_doc_string): Encode file name (bug#9735).
1467 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1469 * bidi.c (bidi_level_of_next_char):
1470 * xdisp.c (get_visually_first_element): Remove old incorrect
1471 comments regarding the Unicode Line Separator character.
1473 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1475 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1477 * alloc.c (Fgc_status): Do not access beyond zombies array
1478 boundary if nzombies > MAX_ZOMBIES.
1479 * alloc.c (dump_zombies): Add missing format specifier.
1481 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1483 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1484 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1486 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1487 Some packages use them to denote characters with modifiers.
1489 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1491 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1492 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1493 matching a pp-number. Rename parameter var to var1.
1495 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1497 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1499 2011-10-08 Glenn Morris <rgm@gnu.org>
1501 * callint.c (Fcall_interactively): Give a more explicit error for the
1502 'c' case with a non-character input. (Bug#8479)
1504 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1508 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1509 lines that are hscrolled on the left.
1511 * dispnew.c (buffer_posn_from_coords): Account for a possible
1512 presence of header-line. (Bug#4426)
1514 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1516 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1517 Don't advertise functionality which we discourage or doesn't work.
1519 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1521 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1522 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1523 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1524 this makes Emacs dump core during garbage collection on rare
1525 occasions. sizeof is obviously inferior to offsetof here, so
1526 stick with offsetof.
1527 (GC_POINTER_ALIGNMENT): New macro.
1528 (mark_memory): Omit 3rd (offset) arg; caller changed.
1529 Don't assume EMACS_INT alignment is the same as pointer alignment.
1531 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1533 * keyboard.c (read_key_sequence_remapped): New var.
1534 (read_key_sequence): Compute remapping in the right buffer.
1535 (command_loop_1): Use read_key_sequence's remapping directly.
1537 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1539 * dired.c (file_name_completion): Don't expand file name.
1540 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1541 before checking file name handler.
1543 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1544 they've been requested explicitly (bug#9591).
1546 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1548 * keymap.c (Fsingle_key_description): Use make_specified_string
1549 instead of build_string to build string from push_key_description.
1552 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1554 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1555 This fixes a Y2038 bug on 64-bit hosts.
1556 * buffer.c (reset_buffer):
1557 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1558 (Fclear_buffer_auto_save_failure):
1559 Use 0, not -1, to represent an unset failure time, since time_t
1560 might not be signed.
1562 Remove dependency on glibc malloc internals.
1563 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1564 Move back here from lisp.h, but with their new implementations.
1565 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1566 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1567 * charset.c (charset_table_init): New static var.
1568 (syms_of_charset): Use it instead of xmalloc. This removes a
1569 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1570 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1571 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1572 Move back to alloc.c.
1573 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1574 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1576 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1578 * nsterm.m (windowDidResize): Call x_set_window_size only when
1579 ns_in_resize is true. Otherwise set pixelwidth/height and
1580 call change_frame_size (Bug#9628).
1582 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1584 Port --enable-checking=all to Fedora 14 x86-64.
1585 * charset.c (syms_of_charset): Also account for glibc malloc's
1586 internal overhead when calculating the initial malloc maximum.
1588 Port --enable-checking=all to Fedora 14 x86.
1589 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1591 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1592 (overrun_check_realloc, overrun_check_free):
1593 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1594 That way, xmalloc returns a properly-aligned pointer even if
1595 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1596 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1597 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1598 into account when calculating the initial malloc maximum.
1599 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1600 Move here from alloc.c, so that charset.c can use it too.
1601 Properly align; the old code wasn't right for common 32-bit hosts
1602 when configured with --enable-checking=all.
1603 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1604 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1606 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1608 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1611 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1613 * xdisp.c (compute_display_string_end): If there's no display
1614 string at CHARPOS, return -1.
1616 * bidi.c (bidi_fetch_char): When compute_display_string_end
1617 returns a negative value, treat the character as a normal
1618 character not covered by a display string. (Bug#9624)
1620 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1622 * lread.c (Fread_from_string): Fix typo in docstring.
1624 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1626 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1627 newline, reseat the iterator instead of bidi-iterating there one
1628 character at a time. (Bug#9610)
1629 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1630 TO_CHARPOS if the bidi iterator is at base embedding level.
1632 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1634 * lread.c (readevalloop): Use correct code for NBSP.
1635 (read1): Likewise. (Bug#9608)
1637 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1639 * dbusbind.c (Fdbus_register_signal): When service is not
1640 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1642 2011-09-25 Glenn Morris <rgm@gnu.org>
1644 * buffer.c (truncate-lines): Doc fix.
1646 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1648 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1649 (Fset_window_next_buffers): Doc fix.
1651 2011-09-24 Glenn Morris <rgm@gnu.org>
1653 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1655 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1657 Fix minor problems found by static checking.
1658 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1659 * indent.c (Fvertical_motion): Fix == vs = typo.
1661 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1663 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1664 Default value is now t. Doc fix.
1666 * indent.c (Fvertical_motion): Compute and apply the overshoot
1667 logic when moving up, not only when moving down. Fix the
1668 confusing name and values of the it_overshoot_expected variable;
1669 logic changes accordingly. (Bug#9254) (Bug#9549)
1671 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1672 CHARPOS is covered by a display string which includes newlines.
1673 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1674 is covered by a display string with embedded newlines.
1676 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1678 * dbusbind.c (Fdbus_register_signal): Add match rule to
1679 Vdbus_registered_objects_table. (Bug#9581)
1680 (Fdbus_register_method, Vdbus_registered_objects_table):
1683 2011-09-24 Jim Meyering <meyering@redhat.com>
1685 do not ignore write error for any output size
1686 The previous change was incomplete.
1687 While it makes emacs --batch detect the vast majority of stdout
1688 write failures, errors were still ignored whenever the output size is
1689 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1690 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1691 && echo FAIL: ignored write error
1692 FAIL: ignored write error
1693 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1694 && echo FAIL: ignored write error
1695 FAIL: ignored write error
1696 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1698 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1700 * emacs.c (Fkill_emacs): In noninteractive mode exit
1701 non-successfully if a write error occurred on stdout. (Bug#9574)
1703 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1705 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1708 * dispextern.h (struct it): Update the comment documenting what
1711 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1714 a display string, extend search for cursor position to end of row.
1715 (find_row_edges): If the row ends in a newline from a display
1716 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1717 Handle the case of a display string with multiple newlines.
1718 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1719 non-empty line. Fixes confusing cursor motion with arrow keys at
1720 the beginning of a line that starts with whitespace.
1722 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1724 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1727 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1729 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1732 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1734 * xdisp.c (display_line): Record maximum and minimum buffer
1735 positions even if no glyphs were produced (e.g., by a zero-width
1736 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1737 buffer positions that will be removed from the glyph row because
1739 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1740 column is beyond frame width: don't subtract 1 "pixel" when
1741 computing width of the stretch.
1742 (reseat_at_next_visible_line_start): Undo the change made on
1743 2011-09-17 that saved paragraph information and restored it after
1744 the call to `reseat'. (Bug#9545)
1746 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1748 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1749 and turn window cursor on if cleared (Bug#9415).
1751 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1753 * search.c (boyer_moore): Take unibyte characters from pattern
1754 literally. (Bug#9458)
1756 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1758 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1760 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1762 Fix minor problem found by static checking.
1763 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1764 initialized, to pacify gcc -Wuninitialized.
1766 * fileio.c: Report proper errno when syscall falls.
1767 (Finsert_file_contents): Save and restore errno,
1768 so that report_file_error outputs the correct diagnostic.
1769 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1771 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1773 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1775 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1777 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1778 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1780 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1783 about the current paragraph and restore it after the call to reseat.
1785 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1786 (bidi_find_paragraph_start): Search back for paragraph beginning
1787 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1788 (bidi_move_to_visually_next): Only trigger paragraph-related
1789 computations when the last character is a newline or at EOB, not
1790 just any NEUTRAL_B. (Bug#9470)
1792 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1793 truncated lines if point is covered by a display string. (Bug#9524)
1795 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1797 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1798 (cons_to_x_long): New function.
1799 (lisp_data_to_selection_data): Use it. Correct the test for
1800 short-versus-long data; it was negated. Break out of vector
1801 loop, for efficiency, when a long datum is discovered.
1803 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1805 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1807 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1809 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1810 GCC PR/17406) by declaring this function with external scope.
1812 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1814 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1815 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1817 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1819 * editfns.c (Fformat): Correctly handle text properties on "%%".
1821 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1823 * xterm.c (x_draw_composite_glyph_string_foreground):
1824 * w32term.c (x_draw_composite_glyph_string_foreground):
1825 * term.c (encode_terminal_code):
1826 * composite.c (composition_update_it, get_composition_id):
1827 * xdisp.c (get_next_display_element)
1828 (fill_composite_glyph_string): Add comments about special meaning
1829 of TAB characters in a composition.
1831 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1833 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1834 This occurs when processing a multibyte format.
1835 Problem reported by Wolfgang Jenker.
1837 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1839 * xdisp.c (try_cursor_movement): Only check for exact match if
1840 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1842 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1844 Remove unused external symbols.
1845 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1846 * xdisp.c (calc_pixel_width_or_height): Now static.
1847 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1848 * indent.c (check_display_width):
1849 * w32term.c: Fix comment to match code.
1850 * xterm.c, xterm.h (x_catching_errors): Remove.
1852 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1854 * xselect.c: Use signed conversions more consistently (Bug#9498).
1855 (selection_data_to_lisp_data): Assume incoming selection data are
1856 signed integers, not unsigned. This is to be consistent with
1857 outgoing selection data, which was modified to use signed integers
1858 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1859 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1860 expects long, not unsigned long.
1862 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1864 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1865 computation of loop end. Reported by Johan Bockgård
1868 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1870 * frame.c (Fother_visible_frames_p): Function deleted.
1872 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1874 * indent.c (compute_motion): Process display vector front to back
1875 rather than the other way around. (Bug#2496)
1877 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1879 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1881 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1883 * minibuf.c (Fread_from_minibuffer): Doc fix.
1885 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1887 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1888 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1890 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1892 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1893 value for non-existent files.
1895 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1897 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1898 set its "size" to -1. This will set the modtime_size field of
1899 the corresponding buffer to -1, which is what
1900 verify-visited-file-modtime expects for files that do not exist.
1903 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1905 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1907 * lisp.h: ... from here. push_key_description is no longer
1908 defined in keyboard.c, so its declaration should not be in
1909 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1910 logically belongs with push_key_description.
1912 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1914 * buffer.h: Include <sys/types.h> instead of <time.h>.
1915 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1916 Problem reported by Herbert J. Skuhra.
1918 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920 * xml.c (parse_region): Make the parsing work for
1921 non-comment-starting XML files again (bug#9144).
1923 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1925 * image.c (gif_load): Fix calculation of bottom and right corner.
1928 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1930 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1931 redisplay in small windows.
1933 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1935 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1937 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1939 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1940 Operate on live windows only.
1942 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1944 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1946 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1948 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1949 only under bidi iteration.
1951 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1953 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1955 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1957 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1958 Without this fix, the command to link temacs failed due to an
1959 undefined symbol __builtin_isnan. This is because
1960 /usr/include/iso/math_c99.h #defines isnan(x) to
1961 __builtin_isnan(x), but the bundled gcc, which identifies itself
1962 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1964 * floatfns.c (isnan): #undef, and then #define to a clone of
1966 (Fisnan): Always define, since it's always available now.
1967 (syms_of_floatfns): Always define isnan at the Lisp level.
1969 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1971 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1973 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1975 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1976 The previous code assumed that file offsets (off_t values) fit in
1977 EMACS_INT variables, which is not true on typical 32-bit hosts.
1978 The code messed up by falsely reporting buffer overflow in cases
1979 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1980 when "big" contains more than 2**29 bytes, even though this
1981 inserts just one byte and does not overflow the buffer.
1982 (Finsert_file_contents): Store file offsets as off_t
1983 values, not as EMACS_INT values. Check for overflow when
1984 converting between EMACS_INT and off_t. When checking for
1985 buffer overflow or for overlap, take the offsets into account.
1986 Don't use EMACS_INT for small values where int suffices.
1987 When checking for overlap, fix a typo: ZV was used where
1988 ZV_BYTE was intended.
1989 (Fwrite_region): Don't assume off_t fits into 'long'.
1990 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1992 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1994 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1996 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1998 sprintf-related integer and memory overflow issues (Bug#9412).
2000 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2001 (esprintf, exprintf, evxprintf): New functions.
2002 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2003 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2004 (modify_event_symbol): Do not assume that the length of
2005 name_alist_or_stem is safe to alloca and fits in int.
2006 (Fexecute_extended_command): Likewise for function name and binding.
2007 (Frecursion_depth): Wrap around reliably on integer overflow.
2008 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2009 since some callers pass EMACS_INT values.
2010 (Fsingle_key_description): Don't crash if symbol name contains more
2011 than MAX_ALLOCA bytes.
2012 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2013 (get_minibuffer): Arg is now EMACS_INT, not int.
2014 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2015 (esprintf, exprintf, evxprintf): New decls.
2016 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2018 * dbusbind.c (signature_cat): New function.
2019 (xd_signature, Fdbus_register_signal):
2020 Do not overrun buffer; instead, report string overflow.
2022 * dispnew.c (add_window_display_history): Don't overrun buffer.
2023 Truncate instead; this is OK since it's just a log.
2025 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2026 even if the time zone offset is outlandishly large.
2027 Don't mishandle offset == INT_MIN.
2029 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2030 when creating daemon; the previous buffer-overflow check was incorrect.
2032 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2033 which has the guts of the old verror function.
2035 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2036 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2038 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2039 (font_unparse_xlfd): Don't blindly alloca long strings.
2040 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2041 fits in int, when using sprintf. Use single snprintf to count
2042 length of string rather than counting it via multiple sprintfs;
2043 that's simpler and more reliable.
2044 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2045 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2046 sprintf, in case result does not fit in int.
2048 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2049 (fontset_from_font): Print it.
2051 * frame.c (tty_frame_count): Now printmax_t, not int.
2052 (make_terminal_frame, set_term_frame_name): Print it.
2053 (x_report_frame_params): In X, window IDs are unsigned long,
2054 not signed long, so print them as unsigned.
2055 (validate_x_resource_name): Check for implausibly long names,
2056 and don't assume name length fits in 'int'.
2057 (x_get_resource_string): Don't blindly alloca invocation name;
2058 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2061 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2062 (xg_check_special_colors, xg_set_geometry):
2063 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2065 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2066 Use esprintf, not sprintf, in case result does not fit in int.
2068 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2069 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2070 it as a large positive number.
2071 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2072 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2074 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2075 in case result does not fit in int.
2077 * print.c (float_to_string): Detect width overflow more reliably.
2078 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2079 buffer overrun. Don't assume list length fits in 'int'. Treat
2080 print length of 0 as 0, not as infinity; to be consistent with other
2081 uses of print length in this function. Don't overflow print length
2082 index. Don't assume hash table size fits in 'long', or that
2083 vectorlike size fits in 'unsigned long'.
2085 * process.c (make_process): Use printmax_t, not int, to format
2086 process-name gensyms.
2088 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2090 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2091 to avoid potential buffer overrun.
2093 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2094 if X resource line is longer than 512 bytes.
2096 * xfns.c (x_window): Make sprintf buffer a bit bigger
2097 to avoid potential buffer overrun.
2099 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2101 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2103 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2105 Integer overflow fixes for scrolling, etc.
2106 Without these, Emacs silently mishandles large integers sometimes.
2107 For example, "C-u 4294967297 M-x recenter" was treated as if
2108 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2110 * xdisp.c (try_window_id): Check Emacs fixnum range before
2111 converting to 'int'.
2113 * window.c (window_scroll_line_based, Frecenter):
2114 Check that an Emacs fixnum is in range before assigning it to 'int'.
2115 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2116 values converted from Emacs fixnums.
2117 (Frecenter): Don't wrap around a line count if it is out of 'int'
2118 range; instead, treat it as an extreme value.
2119 (Fset_window_configuration, compare_window_configurations):
2120 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2122 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2123 that can exceed INT_MAX. Check that EMACS_INT value is in range
2124 before assigning it to the (possibly-narrower) index.
2125 (match_limit): Don't assume that a fixnum can fit in 'int'.
2127 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2130 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2131 (Fvertical_motion): Don't wrap around LINES values that don't fit
2132 in 'int'. Instead, treat them as extreme values. This is good
2133 enough for windows, which can't have more than INT_MAX lines anyway.
2135 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2137 * Require libxml/parser.h to avoid compilation warning.
2139 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2141 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2142 since this reportedly can destroy thread storage.
2144 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2146 * syntax.c (find_defun_start): Update all cache variables if
2147 exiting early (Bug#9401).
2149 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2151 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2153 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2154 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2155 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2157 * term.c (tty_append_glyph): New function.
2158 (produce_stretch_glyph): Static function and its prototype deleted.
2160 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2163 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2165 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2166 when checking :margin (Bug#9390).
2167 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2168 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2169 so that the name doesn't mislead. All uses changed.
2171 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2173 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2176 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2178 * xdisp.c (move_it_to): Don't bail out early when reaching
2179 position beyond to_charpos, if we are scanning backwards.
2180 (move_it_vertically_backward): When DY == 0, make sure we get to
2181 the first character in the line after the newline.
2183 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2185 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2186 (ccl_driver): Do not generate an out-of-range pointer.
2187 (Fccl_execute_on_string): Remove unnecessary check for
2188 integer overflow, noted by Stefan Monnier in
2189 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2190 Remove a FIXME that didn't need fixing.
2191 Simplify the newly-introduced buffer reallocation code.
2193 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2195 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2197 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2199 Integer and memory overflow issues (Bug#9196).
2201 * doc.c (get_doc_string): Rework so that
2202 get_doc_string_buffer_size is the actual buffer size, rather than
2203 being 1 less than the actual buffer size; this makes xpalloc more
2206 * image.c (x_allocate_bitmap_record, cache_image):
2207 * xselect.c (Fx_register_dnd_atom):
2208 Simplify previous changes by using xpalloc.
2210 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2211 since either will do and ptrdiff_t is convenient with xpalloc.
2213 * charset.c (charset_table_size)
2214 (struct charset_sort_data.priority): Now ptrdiff_t.
2215 (charset_compare): Don't overflow if priorities differ greatly.
2216 (Fsort_charsets): Don't assume list length fits in int.
2217 Check for size-calculation overflow when allocating sort data.
2218 (syms_of_charset): Allocate an initial charset table that is
2219 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2221 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2223 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2224 The actual value is always <= INT_MAX, and leaving it unsigned made
2225 overflow checking harder.
2227 * dispextern.h (struct glyph_matrix.rows_allocated)
2228 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2229 with xpalloc. The values are still always <= INT_MAX.
2231 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2233 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2234 (SAFE_NALLOCA): New macro.
2236 * region-cache.c (struct boundary.pos, find_cache_boundary)
2237 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2238 (set_cache_region, invalidate_region_cache)
2239 (revalidate_region_cache, know_region_cache, region_cache_forward)
2240 (region_cache_backward, pp_cache):
2241 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2242 so that ptrdiff_t * can be passed to xpalloc.
2243 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2244 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2245 (pp_cache): Don't assume cache_len fits in int.
2246 * region-cache.h: Adjust extern decls to match.
2248 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2249 EMACS_INT, since either will do, for xpalloc.
2251 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2252 (xnmalloc, xnrealloc, xpalloc): New functions.
2254 * bidi.c (bidi_shelve_header_size): New constant.
2255 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2256 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2258 * bidi.c (bidi_cache_shrink):
2259 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2261 Don't update size of array until after memory allocation succeeds,
2262 because xmalloc/xrealloc may not return.
2263 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2264 now that we have proper integer overflow checking.
2265 (record_overlay_string, overlay_strings): Catch overflows when
2266 calculating size of overlay_str_buf.
2268 * callproc.c (Fcall_process): Check for size overflow when
2269 calculating size of args2.
2270 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2271 Normally we prefer signed values, but sticking with ptrdiff_t would
2272 require adding more-complicated checks.
2274 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2275 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2276 Redo buffer-overflow calculations to avoid integer overflow.
2277 Add a FIXME comment where memory seems to be over-allocated.
2279 * character.c (Fstring): Check for size-calculation overflow.
2281 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2282 unnecessary integer overflow. Check for size overflow.
2283 (encode_coding_object): Don't update size until xmalloc succeeds.
2285 * composite.c (get_composition_id): Check for overflow in glyph
2286 length calculations.
2288 Integer and memory overflow fixes for display code.
2289 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2290 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2291 (scrolling_window): Check for overflow in size calculations.
2292 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2293 Don't assume glyph table len fits in int.
2294 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2295 (row_table_size): Now ptrdiff_t, not int.
2296 (scrolling_window): Avoid overflow in size calculations.
2297 Don't update size until allocation succeeds.
2298 * fns.c (concat): Check for overflow in size calculations.
2299 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2300 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2301 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2303 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2304 (get_doc_string): Check for size calculation overflow.
2305 Don't update size until allocation succeeds.
2306 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2307 EMACS_INT, where ptrdiff_t will do.
2308 (Fsubstitute_command_keys): Check for string overflow.
2310 * editfns.c (set_time_zone_rule): Don't assume environment length
2312 (message_length): Now ptrdiff_t, not int.
2313 (Fmessage_box): Don't update size until allocation succeeds.
2314 Don't assume message length fits in int.
2315 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2317 * emacs.c (main): Do not reallocate argv, since there is a null at
2318 the end that can be overwritten, and this way there's no need to
2319 worry about size-calculation overflow.
2320 (sort_args): Check for size-calculation overflow.
2322 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2324 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2326 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2327 (x_set_scroll_bar_width, x_figure_window_size):
2328 Check for integer overflow.
2329 (x_set_alpha): Do not assume XINT fits in int.
2331 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2332 This is for the members text_lines, text_cols, total_lines, total_cols,
2333 where the system imposes an 'int' limit.
2335 * fringe.c (Fdefine_fringe_bitmap):
2336 Don't update size until alloc works.
2338 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2339 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2341 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2342 Check for size-calculation overflow.
2343 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2344 do, as we prefer signed integers.
2345 (id_to_widget.max_size, id_to_widget.used)
2346 (xg_store_widget_in_map, xg_remove_widget_from_map)
2347 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2348 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2349 Use and return ptrdiff_t, not int.
2350 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2351 * gtkutil.h: Change prototypes to match the above.
2353 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2354 are duplicate now that they've been promoted to lisp.h.
2355 (x_allocate_bitmap_record, x_alloc_image_color)
2356 (make_image_cache, cache_image, xpm_load):
2357 Don't update size until alloc is done.
2358 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2360 Check for size calculation overflow.
2361 (ct_colors_allocated_max): New constant.
2362 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2365 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2366 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2367 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2368 Use ptrdiff_t, not int, to count maps.
2369 (read_char_minibuf_menu_prompt): Check for overflow in size
2370 calculations. Don't update size until allocation succeeds.
2371 Redo calculations to avoid overflow.
2372 * keyboard.h: Change prototypes to match the above.
2374 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2376 (current_minor_maps): Check for size calculation overflow.
2377 * keymap.h: Change prototypes to match the above.
2379 * lread.c (read1, init_obarray): Don't update size until alloc done.
2381 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2382 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2384 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2385 Now ptrdiff_t, not int.
2386 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2387 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2389 * process.c (Fnetwork_interface_list): Check for overflow
2390 in size calculation.
2392 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2394 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2395 overflow. Don't bother calling xmalloc when xrealloc will do.
2397 * search.c (Freplace_match): Check for size calculation overflow.
2398 (Fset_match_data): Don't assume list lengths fit in 'int'.
2400 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2401 for command line length. Do not attempt to address one before the
2402 beginning of an array, as that's not portable.
2404 * term.c (max_frame_lines): Remove; unused.
2405 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2407 (encode_terminal_code, calculate_costs): Check for size
2408 calculation overflow.
2409 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2410 table lengths and related sizes. Don't update size until alloc
2411 done. Redo calculations to avoid overflow.
2412 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2414 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2415 subtracting pointers.
2416 (gobble_line): Check for overflow more carefully. Don't update size
2419 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2420 Don't update size until alloc done.
2421 Redo size calculations to avoid overflow.
2422 Check for size calculation overflow.
2423 (main) [DEBUG]: Fix typo in invoking tparam1.
2425 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2426 Use ptrdiff_t, not int, for sizes.
2427 (store_mode_line_noprop_char): Don't update size until alloc done.
2429 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2430 Use ptrdiff_t, not int, for sizes.
2431 (Finternal_make_lisp_face, cache_face):
2432 Check for size calculation overflow.
2433 (cache_face): Treat size calculation overflows as if they were
2434 memory exhaustion (the usual treatment), rather than aborting.
2436 * xfns.c (x_encode_text, x_set_name_internal)
2437 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2438 sizes, since they can exceed INT_MAX in size. Check for size
2439 calculation overflow.
2441 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2442 (xg_select): Check for size calculation overflow.
2443 Don't update size until alloc done.
2445 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2446 as sprintf is limited to int lengths.
2448 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2449 (X_LONG_MIN): New macros.
2450 Use them to make the following changes clearer.
2451 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2452 This change doesn't affect the value now, but it may help remind
2453 future maintainers not to raise the value too much later.
2454 (SELECTION_QUANTUM): Remove, replacing with ...
2455 (selection_quantum): ... new function, which avoids overflow.
2457 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2458 assumption that selection length fits in 'int'.
2459 (x_reply_selection_request, x_handle_selection_request)
2460 (x_get_window_property, receive_incremental_selection)
2461 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2462 (lisp_data_to_selection_data, clean_local_selection_data):
2463 Use ptrdiff_t, not int, to record length of selection.
2464 (x_reply_selection_request, x_get_window_property)
2465 (receive_incremental_selection, x_property_data_to_lisp):
2466 Redo calculations to avoid overflow.
2467 (x_reply_selection_request): When sending hint, ceiling it at
2468 X_LONG_MAX rather than relying on wraparound overflow to send
2470 (x_get_window_property, receive_incremental_selection)
2471 (lisp_data_to_selection_data, x_property_data_to_lisp):
2472 Check for size-calculation overflow.
2473 (x_get_window_property, receive_incremental_selection)
2474 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2475 Don't store size until memory allocation succeeds.
2476 (x_get_window_property): Plug memory leak on memory exhaustion.
2477 Don't double-block input; malloc is safe here. Don't assume 2**34
2478 - 4 fits in unsigned long. Add an xassert to check
2479 XGetWindowProperty overflow. Be more careful about overflow
2480 calculations, and distinguish size from memory overflow better.
2481 (receive_incremental_selection): When tracing, don't assume
2482 unsigned int is less than INT_MAX.
2483 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2484 harmful) conversions of unsigned short to int.
2485 (lisp_data_to_selection_data): Don't assume that integers
2486 in the range -65535 through -1 fit in an X unsigned short.
2487 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2488 result parameters unless successful. Rely on cons_to_unsigned
2489 to report problems with elements; the old code wasn't right anyway.
2490 (x_check_property_data): Check for int overflow; we cannot use
2491 a wider type due to X limits.
2492 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2494 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2496 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2497 (x_term_init): Check for size calculation overflow.
2498 (x_color_cells): Don't store size until memory allocation succeeds.
2499 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2500 Don't assume alloca size is less than MAX_ALLOCA.
2501 (x_term_init): Don't assume length fits in int (sprintf is limited
2504 Use ptrdiff_t for composition IDs.
2505 * character.c (lisp_string_width):
2506 * composite.c (composition_table_size, n_compositions)
2507 (get_composition_id, composition_gstring_from_id):
2508 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2509 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2510 * window.c (Frecenter):
2511 Use ptrdiff_t, not int, for composition IDs.
2512 * composite.c (get_composition_id): Check for integer overflow.
2513 * composite.h: Adjust prototypes to match the above changes.
2515 Use ptrdiff_t for hash table indexes.
2516 * category.c (hash_get_category_set):
2517 * ccl.c (ccl_driver):
2518 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2519 * coding.c (coding_system_charset_list, detect_coding_system):
2520 * coding.h (struct coding_system.id):
2521 * composite.c (get_composition_id, gstring_lookup_cache):
2522 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2523 * image.c (xpm_get_color_table_h):
2524 * lisp.h (hash_lookup, hash_put):
2525 * minibuf.c (Ftest_completion):
2526 Use ptrdiff_t for hash table indexes, not int (which is too
2527 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2528 32-bit --with-wide-int hosts).
2530 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2531 Add a FIXME comment about memory leaks.
2532 (syms_of_charset): Don't assume xmalloc returns.
2534 Don't assume that stated character widths fit in int.
2535 * character.c (Fchar_width, c_string_width, lisp_string_width):
2536 * character.h (CHAR_WIDTH):
2537 * indent.c (MULTIBYTE_BYTES_WIDTH):
2538 Use sanitize_char_width to avoid undefined and/or bad behavior
2539 with outlandish widths.
2540 * character.h (sanitize_tab_width): Rename from sanitize_width,
2541 now that we have two such functions. All uses changed.
2542 (sanitize_char_width): New inline function.
2544 Don't assume that tab-width fits in int.
2545 * character.h (sanitize_width): New inline function.
2546 (SANE_TAB_WIDTH): New macro.
2547 (ASCII_CHAR_WIDTH): Use it.
2548 * indent.c (sane_tab_width): Remove. All uses replaced by
2549 SANE_TAB_WIDTH (current_buffer).
2550 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2552 * fileio.c: Integer overflow issues with file modes.
2553 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2555 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2556 Remove unreachable code.
2557 (read_hex, load_charset_map_from_file): Check for integer overflow.
2559 * xterm.c: Don't go over XClientMessageEvent limit.
2560 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2561 (x_send_scroll_bar_event): Likewise. Check that the size does not
2562 exceed limits imposed by XClientMessageEvent, as well as the usual
2563 ptrdiff_t and size_t limits.
2565 * keyboard.c: Overflow, signedness and related fixes.
2566 (make_lispy_movement): Use same integer type in forward decl
2567 that is used in the definition.
2568 (read_key_sequence, keyremap_step):
2569 Change bufsize argument back to int, undoing my 2011-03-30 change.
2570 We prefer signed types, and int is wide enough here.
2571 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2572 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2573 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2574 length, not size_t. Use ptrdiff_t for index, not int.
2575 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2576 possibility of integer overflow.
2578 Overflow, signedness and related fixes for images.
2580 * dispextern.h (struct it.stack[0].u.image.image_id)
2581 (struct_it.image_id, struct image.id, struct image_cache.size)
2582 (struct image_cache.used, struct image_cache.ref_count):
2583 * gtkutil.c (update_frame_tool_bar):
2584 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2585 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2586 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2587 * nsmenu.m (update_frame_tool_bar):
2588 * xdisp.c (calc_pixel_width_or_height):
2589 * xfns.c (image_cache_refcount):
2590 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2591 on typical 64-bit hosts.
2593 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2594 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2595 Omit unnecessary casts to int.
2596 (parse_image_spec): Check that integers fall into 'int' range
2597 when the callers expect that.
2598 (image_ascent): Redo ascent calculation to avoid int overflow.
2599 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2600 (lookup_image): Remove unnecessary tests.
2601 (xbm_image_p): Locals are now of int, not EMACS_INT,
2602 since parse_image_check makes sure they fit into int.
2603 (png_load, gif_load, svg_load_image):
2604 Prefer int to unsigned where either will do.
2605 (tiff_handler): New function, combining the cores of the
2606 old tiff_error_handler and tiff_warning_handler.
2607 This function is rewritten to use vsnprintf and thereby avoid
2608 stack buffer overflows. It uses only the features of vsnprintf
2609 that are common to both POSIX and native Microsoft.
2610 (tiff_error_handler, tiff_warning_handler): Use it.
2611 (tiff_load, gif_load, imagemagick_load_image):
2612 Don't assume :index value fits in 'int'.
2613 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2614 (imagemagick_load_image): Check that crop parameters fit into
2615 the integer types that MagickCropImage accepts. Don't assume
2616 Vimagemagick_render_type has a nonnegative value. Don't assume
2617 size_t fits in 'long'.
2618 (gs_load): Use printmax_t to print the widest integers possible.
2619 Check for integer overflow when computing image height and width.
2621 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2623 * xdisp.c (redisplay_window): Don't force window start if point
2624 will be invisible in the resulting window. (Bug#9324)
2626 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2628 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2629 the display spec is of the form `(space ...)'.
2630 (handle_display_spec): Return the value returned by
2631 handle_single_display_spec, not just 1 or zero.
2632 (handle_single_display_spec): If the display spec is of the form
2633 `(space ...)', and specifies display in the text area, return 2
2635 (try_cursor_movement): Check for the need to scroll more
2636 accurately, and prefer exact match for point under bidi.
2637 Don't advance `row' beyond the last row of the window.
2639 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2640 into disp_prop; all users changed.
2642 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2643 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2644 for the text covered by the display property.
2646 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2648 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2649 Change return value to nil.
2650 (Frecord_buffer): Delete unused function.
2652 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2654 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2655 buffers, return left-to-right.
2656 (set_cursor_from_row): Consider candidate row a win if its glyph
2657 represents a newline and point is on that newline. Fixes cursor
2658 positioning on the newline at EOL of R2L text within L2R
2659 paragraph, and vice versa.
2660 (try_cursor_movement): Check continued rows, in addition to
2661 continuation rows. Fixes unwarranted scroll when point enters a
2662 continued line of R2L text within an L2R paragraph, or vice versa.
2663 (cursor_row_p): Consider the case of point being equal to
2664 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2665 from the end of a short line to the beginning of a continued line
2666 of R2L text within L2R paragraph.
2667 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2668 composed characters.
2670 * bidi.c (bidi_check_type): Use xassert.
2671 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2674 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2676 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2679 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2681 * nsfont.m (ns_otf_to_script): Fix typo.
2683 2011-08-22 Kenichi Handa <handa@m17n.org>
2685 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2686 extra slot even if the purpose is char-code-property-table.
2688 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2690 * xdisp.c (redisplay_window): When computing centering_position,
2691 account for the height of the header line. (Bug#8874)
2693 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2694 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2695 candidate is selected by the mouse, and that candidate has a
2696 composed character under the mouse.
2698 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2699 coordinates reported by pos-visible-in-window-p for a composed
2700 character in column zero.
2702 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2704 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2706 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2708 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2709 consider it a hit if to_charpos is anywhere in the range of the
2710 composed buffer positions.
2712 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2714 * image.c (gif_load): Don't assume that each subimage has the same
2715 dimensions as the base image. Handle disposal method that is
2716 "undefined" by the gif spec (Bug#9335).
2718 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2720 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2721 (Fcondition_case): Document `debug' symbol in error handler.
2723 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2725 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2726 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2727 from an Org mode buffer to a Speedbar frame.
2729 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2730 a composition, take its buffer position from IT->cmp_it.charpos.
2731 Fixes cursor positioning at the beginning of a line that begins
2732 with a composed character.
2734 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2736 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2737 character bidirectional type, use STRONG_L instead. Fixes crashes
2738 in a buffer produced by `describe-categories'.
2740 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2741 members before the level stack, so they would be saved and
2742 restored when copying iterator state. Fixes incorrect reordering
2743 around TABs covered by display properties.
2745 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2747 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2749 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2751 * eval.c (internal_condition_case, internal_condition_case_1)
2752 (internal_condition_case_2, internal_condition_case_n):
2753 Remove unnecessary aborts (Bug#9081).
2755 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2757 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2758 has no `load' handler, try opening the file locally. (Bug#9311)
2760 2011-08-16 Ken Brown <kbrown@cornell.edu>
2762 * gmalloc.c: Expand comment.
2764 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2766 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2767 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2769 2011-08-16 Ken Brown <kbrown@cornell.edu>
2771 Fix memory allocation problems in Cygwin build (Bug#9273).
2773 * unexcw.c ( __malloc_initialized): Declare external variable.
2774 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2776 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2778 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2780 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2782 [CYGWIN] (special_realloc): New function.
2783 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2784 requests to realloc storage in the static heap.
2786 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2788 * bidi.c (bidi_initialize): Remove unused local.
2790 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2793 * biditype.h: Remove file.
2794 * makefile.w32-in ($(BLD)/bidi.$(O)):
2795 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2797 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2799 * chartab.c: Improve commentary for the uniprop_table API.
2801 * bidi.c (bidi_paragraph_init): Support zero value of
2802 bidi_ignore_explicit_marks_for_paragraph_level.
2803 (bidi_initialize): Use uniprop_table instead of including
2804 biditype.h and bidimirror.h.
2806 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2807 coordinates of the iterator when restoring from ppos_it.
2810 2011-08-14 Kenichi Handa <handa@m17n.org>
2812 * process.c (create_process): Call setup_process_coding_systems
2813 after the pid of the process is set to -1 (Bug#8162).
2815 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2817 * xdisp.c (move_it_in_display_line_to): Don't invoke
2818 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2819 ppos_it. Fixes vertical cursor motion when line beginning is
2820 covered by an image. (Bug#9296)
2822 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2824 * nsterm.h (ns_run_ascript): Declare.
2825 (NSAPP_DATA2_RUNASSCRIPT): Define.
2827 * nsfns.m (as_script, as_result, as_status): New static variables.
2828 (ns_run_ascript): New function.
2829 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2830 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2831 the event loop. Get status from as_status (Bug#7276).
2833 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2834 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2835 the event loop (Bug#7276).
2837 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2839 * gnutls.c (QCgnutls_bootprop_priority)
2840 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2841 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2842 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2843 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2844 (QCgnutls_bootprop_verify_hostname_error)
2845 (QCgnutls_bootprop_callbacks_verify): Rename from
2846 Qgnutls_bootprop_..., all uses changed.
2848 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2851 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2853 * xfaces.c (Qframe_set_background_mode): Now static.
2854 * dispextern.h (Qframe_set_background_mode): Remove decl.
2856 * process.c (Fnetwork_interface_info): Declare local only if needed.
2858 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2860 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2861 (Fnetwork_interface_list): Allocate in increments of bytes instead
2862 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2863 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2865 (struct ifflag_def): notrailers is smart on OSX.
2866 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2867 Get hardware address with getifaddrs if available.
2869 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2871 * xdisp.c (iterate_out_of_display_property): xassert that
2872 IT->position is set to within IT->object's boundaries. Break from
2873 the loop as soon as EOB is reached; avoids infloops in redisplay
2874 when IT->position is set up wrongly due to some bug.
2875 Set IT->current to match the bidi iterator unconditionally.
2876 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2877 entry. Force push_it to save on the stack the current
2878 buffer/string position, to be restored by pop_it. Fix flags in
2879 the iterator structure wrt the object coming from a display
2880 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2881 properties. (Bug#9284)
2883 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2885 * fontset.c (fontset_get_font_group): Add proper type checks.
2888 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2890 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2891 and LC_VERSION_MIN_MACOSX.
2892 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2893 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2895 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2897 * xdisp.c (forward_to_next_line_start): Allow to use the
2898 no-display-properties-and-no-overlays under bidi display.
2899 Set disp_pos in the bidi iterator to avoid searches for display
2900 properties and overlays.
2902 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2904 * editfns.c (Fset_time_zone_rule): Document relationship with the
2907 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2908 the font entity extracted from the cache (Bug#8109).
2910 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2912 * composite.c (autocmp_chars): Don't reset point. That is done by
2913 restore_point_unwind (Bug#5984).
2915 2011-08-07 Juri Linkov <juri@jurta.org>
2917 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2918 to show the arg `TIME' instead of `TIMEVAL'.
2920 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2922 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2923 display property strides EOL and includes a newline, as in
2924 longlines-mode. (Bug#9254)
2925 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2926 word-wrap under bidirectional display. (Bug#9224)
2928 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2929 is non-zero, even if the data buffer is NULL. Fixes a crash in
2930 vertical-motion with longlines-mode. (Bug#9254)
2932 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2934 * bidi.c <bidi_cache_total_alloc>: Now static.
2935 (bidi_initialize): Initialize bidi_cache_total_alloc.
2937 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2940 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2941 amount allocated this far in `bidi_cache_total_alloc'.
2942 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2943 non-zero, only free the data buffer without restoring the cache
2944 contents. All callers changed.
2946 * dispextern.h (bidi_unshelve_cache): Update prototype.
2948 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2949 (move_it_in_display_line, move_it_to)
2950 (move_it_vertically_backward, move_it_by_lines): Replace the call
2951 to xfree to an equivalent call to bidi_unshelve_cache.
2952 (move_it_in_display_line_to): Fix logic of returning
2953 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2955 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2957 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2958 came from a string character with a `cursor' property. (Bug#9229)
2960 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2962 * Makefile.in (LIB_PTHREAD): New variable.
2963 (LIBES): Add LIB_PTHREAD (Bug#9216).
2965 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2966 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2968 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2970 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2972 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2974 * xterm.c (x_find_topmost_parent): New function.
2975 (x_set_frame_alpha): Find topmost parent window with
2976 x_find_topmost_parent and set the property there also (bug#9181).
2977 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2979 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2981 * callproc.c (Fcall_process): Avoid vfork clobbering
2982 the local vars buffer, coding_systems, current_dir.
2984 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2986 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2988 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2990 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2991 so that it is not optimized away.
2993 * xdisp.c (compute_display_string_pos): Remove unused local.
2995 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2997 Fix slow cursor motion and scrolling in large buffers with
2998 selective display, like Org Mode buffers. (Bug#9218)
3000 * dispextern.h (struct bidi_it): New member disp_prop_p.
3002 * xdisp.c: Remove one-slot cache of display string positions.
3003 (compute_display_string_pos): Accept an additional argument
3004 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3005 for a display string or property. If found, set DISP_PROP_P
3008 * bidi.c (bidi_fetch_char): Accept an additional argument
3009 DISP_PROP_P, and pass it to compute_display_string_pos.
3010 Only handle text covered by a display string if DISP_PROP_P is returned
3011 non-zero. All callers of bidi_fetch_char changed.
3013 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3015 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3017 2010-12-03 Don March <don@ohspite.net>
3019 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3020 last character M-[char] is translated to ESC [char] (bug#7541).
3022 2011-08-02 Kenichi Handa <handa@m17n.org>
3024 * lisp.h (uniprop_table): Extern it.
3026 * chartab.c (uniprop_table): Make it non-static.
3028 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3030 * xdisp.c (forward_to_next_line_start): Accept additional argument
3031 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3033 (reseat_at_next_visible_line_start): Use the bidi iterator state
3034 returned by forward_to_next_line_start to restore the state of
3035 it->bidi_it after backing up to previous newline. (Bug#9212)
3037 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3039 * regex.c (re_comp): Protoize.
3040 (re_exec): Fix return type.
3041 (regexec): Fix type of `ret'. (Bug#9203)
3043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3045 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3046 This is needed if max-image-size is a floating-point number.
3048 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3050 * print.c (print_object): Print empty symbol as ##.
3052 * lread.c (read1): Read ## as empty symbol.
3054 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3056 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3057 setting frame foreground color (Bug#9175).
3058 (x_set_background_color): Likewise.
3060 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3061 contents (Bug#9176).
3062 (EmacsTooltip -init): Remove bezels and add shadows to
3065 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3066 or scroll bar (Bug#8470).
3068 * nsfont.m (nsfont_open): Remove assignment to voffset and
3069 unnecessary vars hshink, expand, hd, full_height, min_height.
3070 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3072 * nsterm.h (nsfont_info): Remove voffset field.
3074 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3076 Implement strike-through and overline on NextStep (Bug#8863).
3078 * nsfont.m (nsfont_open): Use underline position provided by font,
3079 instead of hard-coded value of 2.
3080 (nsfont_draw): Call ns_draw_text_decoration instead.
3082 * nsterm.h: Add declaration for ns_draw_text_decoration.
3084 * nsterm.m (ns_draw_text_decoration): New function for drawing
3085 underline, overline, and strike-through.
3086 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3087 ns_draw_text_decoration. Change treatment of cursor drawing to
3088 accommodate underlining, etc.
3090 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3092 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3095 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3097 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3098 Without this fix, if a signal arrives just after memory fills up,
3099 'malloc' might be invoked reentrantly.
3101 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3102 In other words, assume that every image size is allowed, on non-X
3103 hosts. This assumption is probably wrong, but it lets Emacs compile.
3105 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3107 * regex.c (re_iswctype): Convert return values to boolean.
3109 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3111 * xdisp.c (compute_display_string_pos): Don't use cached display
3112 string position if the buffer had its restriction changed.
3115 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3117 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3119 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3121 Integer signedness and overflow and related fixes. (Bug#9079)
3123 * bidi.c: Integer size and overflow fixes.
3124 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3125 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3127 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3128 (bidi_find_other_level_edge):
3129 Use ptrdiff_t instead of EMACS_INT where either will do.
3130 This works better on 32-bit hosts configured --with-wide-int.
3131 (bidi_cache_ensure_space): Check for size-calculation overflow.
3132 Use % rather than repeated addition, for better worst-case speed.
3133 Don't set bidi_cache_size until after xrealloc returns, because it
3135 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3136 (bidi_cache_ensure_space): Also check that the bidi cache size
3137 does not exceed that of the largest Lisp string or buffer. See Eli
3138 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3140 * alloc.c (__malloc_size_t): Remove.
3141 All uses replaced by size_t. See Andreas Schwab's note
3142 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3144 * image.c: Improve checking for integer overflow.
3145 (check_image_size): Assume that f is nonnull, since
3146 it is always nonnull in practice. This is one less thing to
3147 worry about when checking for integer overflow later.
3148 (x_check_image_size): New function, which checks for integer
3149 overflow issues inside X.
3150 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3151 This removes the need for a memory_full check.
3152 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3153 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3154 (xbm_read_bitmap_data): Change locals back to 'int', since
3155 their values must fit in 'int'.
3156 (xpm_load_image, png_load, tiff_load):
3157 Invoke x_create_x_image_and_pixmap earlier,
3158 to avoid much needless work if the image is too large.
3159 (tiff_load): Treat overly large images as if
3160 x_create_x_image_and_pixmap failed, not as malloc failures.
3161 (gs_load): Use x_check_image_size.
3163 * gtkutil.c: Omit integer casts.
3164 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3165 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3167 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3169 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3170 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3171 would wrongly return t on a 64-bit host.
3173 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3174 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3175 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3176 and therefore cause GCC to emit a bogus diagnostic in some cases.
3178 * image.c: Integer signedness and overflow and related fixes.
3179 This is not an exhaustive set of fixes, but it's time to
3180 record what I've got.
3181 (lookup_pixel_color, check_image_size): Remove redundant decls.
3182 (check_image_size): Don't assume that arbitrary EMACS_INT values
3183 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3184 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3185 (tiff_load, imagemagick_load_image):
3186 Check for overflow in size calculations.
3187 (x_create_x_image_and_pixmap): Remove unnecessary test for
3188 xmalloc returning NULL; that can't happen.
3189 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3190 (xpm_color_bucket): Use better integer hashing function.
3191 (xpm_cache_color): Don't possibly over-allocate memory.
3192 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3193 (gif_memory_source):
3194 Use ptrdiff_t, not int or size_t, to record sizes.
3195 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3196 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3197 either works, as we prefer signed integers.
3198 (tiff_read_from_memory, tiff_write_from_memory):
3199 Return tsize_t, not size_t, since that's what the TIFF API wants.
3200 (tiff_read_from_memory): Don't fail simply because the read would
3201 go past EOF; instead, return a short read.
3202 (tiff_load): Omit no-longer-needed casts.
3203 (Fimagemagick_types): Don't assume size fits into 'int'.
3205 Improve hashing quality when configured --with-wide-int.
3206 * fns.c (hash_string): New function, taken from sxhash_string.
3207 Do not discard information about ASCII character case; this
3208 discarding is no longer needed.
3209 (sxhash-string): Use it. Change sig to match it. Caller changed.
3210 * lisp.h: Declare it.
3211 * lread.c (hash_string): Remove, since we now use fns.c's version.
3212 The fns.c version returns a wider integer if --with-wide-int is
3213 specified, so this should help the quality of the hashing a bit.
3215 * emacs.c: Integer overflow minor fix.
3216 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3217 Define only if GNU_LINUX.
3218 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3220 * dispnew.c: Integer signedness and overflow fixes.
3221 Remove unnecessary forward decls, that were a maintenance hassle.
3222 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3224 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3225 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3226 (prepare_desired_row, line_draw_cost):
3227 Use int, not unsigned, where either works.
3228 (save_current_matrix, restore_current_matrix):
3229 Use ptrdiff_t, not size_t, where either works.
3230 (init_display): Check for overflow more accurately, and without
3231 relying on undefined behavior.
3233 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3234 Remove, replacing with the new symbols in lisp.h. All uses changed.
3235 * fileio.c (make_temp_name):
3236 * filelock.c (lock_file_1, lock_file):
3237 * xdisp.c (message_dolog):
3238 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3239 Use pMd etc. instead.
3240 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3241 replacing the pWIDE etc. symbols removed from editfns.c.
3243 * keyboard.h (num_input_events): Now uintmax_t.
3244 This is (very slightly) less likely to mess up due to wraparound.
3247 * buffer.c: Integer signedness fixes.
3248 (alloc_buffer_text, enlarge_buffer_text):
3249 Use ptrdiff_t rather than size_t when either will do, as we prefer
3252 * alloc.c: Integer signedness and overflow fixes.
3253 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3254 (__malloc_size_t): Default to size_t, not to int.
3255 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3256 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3257 Prefer ptrdiff_t to size_t when either would do, as we prefer
3259 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3260 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3261 Now const. Initialize with values that are in range even if char
3263 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3264 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3265 These functions do the right thing with sizes > 2**32.
3266 (check_depth): Now ptrdiff_t, not int.
3267 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3268 Adjust to new way of storing sizes. Check for size overflow bugs
3270 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3271 slightly wrong anyway, as it missed one instance of
3272 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3273 (refill_memory_reserve): Omit needless cast to size_t.
3274 (mark_object_loop_halt): Mark as externally visible.
3276 * xselect.c: Integer signedness and overflow fixes.
3277 (Fx_register_dnd_atom, x_handle_dnd_message):
3278 Use ptrdiff_t, not size_t, since we prefer signed.
3279 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3280 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3281 x_dnd_atoms_size and x_dnd_atoms_length.
3283 * doprnt.c: Prefer signed to unsigned when either works.
3285 * doprnt.c (doprnt):
3287 * xdisp.c (vmessage):
3288 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3289 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3290 prefer signed arithmetic to avoid comparison confusion.
3291 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3292 but is a bit tricky.
3294 Assume freestanding C89 headers, string.h, stdlib.h.
3295 * data.c, doprnt.c, floatfns.c, print.c:
3296 Include float.h unconditionally.
3297 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3298 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3299 * regex.c: Likewise for stddef.h, string.h.
3300 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3301 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3302 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3303 (STDC_HEADERS): Remove obsolete defines.
3304 * sysdep.c: Include limits.h unconditionally.
3306 Assume support for memcmp, memcpy, memmove, memset.
3307 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3308 * regex.c (memcmp, memcpy):
3309 Remove; we assume C89 now.
3311 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3312 (__malloc_safe_bcopy): Remove; no longer needed.
3314 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3315 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3316 well either way, and we prefer signed to unsigned.
3318 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3320 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3321 closes the connection while we're reading (bug#9182).
3323 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3325 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3326 are specified (Bug#9168).
3328 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3330 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3331 Found by GCC static checking and --with-wide-int on a 32-bit host.
3333 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3335 * xdisp.c (compute_display_string_pos): Fix logic of caching
3336 previous display string position. Initialize cached_prev_pos to
3337 -1. Fixes slow-down at the beginning of a buffer.
3339 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3341 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3342 for attrs[LFACE_FONTSET_INDEX].
3344 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3346 * xml.c (parse_region): Remove unused local
3347 that was recently introduced.
3349 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3351 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3352 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3354 * xdisp.c (move_it_in_display_line_to): Record the best matching
3355 position for TO_CHARPOS while scanning the line, and restore it on
3356 exit if none of the characters scanned was an exact match.
3357 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3358 when exact match is impossible due to invisible text, and the
3359 lines are truncated.
3361 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3363 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3366 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3368 Fix a significant slow-down of cursor motion with C-n, C-p,
3369 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3370 auto-repeat under bidi redisplay in fontified buffers.
3371 * xdisp.c (compute_stop_pos_backwards): New function.
3372 (next_element_from_buffer): Call compute_stop_pos_backwards to
3373 find a suitable prev_stop when we find ourselves before
3375 (reseat): Don't look for prev_stop, as that could mean a very long
3377 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3378 <cached_disp_overlay_modiff>: Cache for last found display string
3380 (compute_display_string_pos): Return the cached position if asked
3381 about the same buffer in the same area of character positions, and
3382 the buffer wasn't changed since the time the display string
3383 position was cached.
3385 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3387 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3388 is an integer, which is important for empty lines. (Bug#9149)
3390 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3392 * frame.c (Fmodify_frame_parameters): In tty case, update the
3393 default face if necessary (Bug#4238).
3395 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3397 * editfns.c (Fstring_to_char): No need to explain what a character
3398 is in the docstring (Bug#6576).
3400 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3402 * xml.c (parse_region): Make sure we always return a tree.
3404 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3406 * xml.c (parse_region): If a document contains only comments,
3409 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3411 * xml.c (make_dom): Return comments, too.
3413 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3416 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3417 and the surrounding thread.
3418 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3419 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3420 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3422 * s/openbsd.h (BROKEN_SIGIO): Define.
3423 * unexelf.c (unexec) [__OpenBSD__]:
3424 Don't update the .mdebug section of the Alpha COFF symbol table.
3426 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3428 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3431 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3433 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3434 This fixes some race conditions on the permissions of any newly
3437 * alloc.c (valid_pointer_p): Use pipe, not open.
3438 This fixes some permissions issues when debugging.
3440 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3441 If fchown fails to set both uid and gid, try to set just gid,
3442 as that is sometimes allowed. Adjust the file's mode to eliminate
3443 setuid or setgid bits that are inappropriate if fchown fails.
3445 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3447 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3448 to compare Lisp_Objects.
3449 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3450 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3451 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3453 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3455 * lread.c (read_integer): Unread even EOF character.
3456 (read1): Likewise. Properly record start position of symbol.
3458 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3459 symbol character follows.
3461 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3463 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3464 This works around a problem with the previous change to Fcopy_file.
3465 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3466 and without this change, GCC might complain about discarding
3467 fchown's return value.
3469 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3471 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3473 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3475 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3477 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3479 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3480 it's used from the C level.
3482 * process.c: Use the same condition for POLL_FOR_INPUT in both
3483 keyboard.c and process.c (bug#1858).
3485 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3487 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3488 (Fgnutls_boot): Use it.
3490 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3492 * doc.c (Fsubstitute_command_keys): Revert last change.
3494 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3496 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3497 quotes the next character, and doesn't affect other longer
3498 sequences (bug#8935).
3500 * lread.c (syms_of_lread): Clarify that is isn't only
3501 `eval-buffer' and `eval-defun' that's affected by
3502 `lexical-binding' (bug#8460).
3504 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3506 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3507 bidi redisplay when a line includes both an image and is truncated.
3509 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3511 Fix minor problems found by static checking.
3512 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3513 (elsz): Now a signed constant, not a size_t var. We prefer signed
3514 types to unsigned, to avoid integer comparison confusion. Without
3515 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3516 "cannot optimize loop, the loop counter may overflow", a symptom
3518 * indent.c (Fvertical_motion): Mark locals as initialized.
3519 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3521 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3523 * search.c (Fre_search_backward): Mention `case-fold-search' in
3524 all the re_search_* functions (bug#8138).
3526 * keyboard.c (Fopen_dribble_file): Document when the file is
3529 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3531 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3534 Support bidi reordering of display and overlay strings.
3535 * xdisp.c (compute_display_string_pos)
3536 (compute_display_string_end): Accept additional argument STRING.
3537 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3538 (reseat_to_string): Initialize bidi_it->string.s and
3539 bidi_it->string.schars.
3540 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3541 NULL (avoids a crash in bidi_paragraph_init).
3542 Initialize itb.string.lstring.
3543 (init_iterator): Call bidi_init_it only of a valid
3544 buffer position was specified. Initialize paragraph_embedding to
3546 (reseat_to_string): Initialize the bidi iterator.
3547 (display_string): If we need to ignore text properties of
3548 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3549 original value of -1 will not work with bidi.)
3550 (compute_display_string_pos): First arg is now struct
3551 `text_pos *'; all callers changed. Support display properties on
3553 (compute_display_string_end): Support display properties on Lisp
3555 (init_iterator, reseat_1, reseat_to_string): Initialize the
3556 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3557 when iterating on a string not from display properties).
3558 (compute_display_string_pos, compute_display_string_end):
3559 Fix calculation of the object to scan. Fixes an error when using
3561 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3562 base_level_stop; instead, set base_level_stop to BEGV.
3563 Fixes crashes in vertical-motion.
3564 (next_element_from_buffer): Improve commentary for when
3565 the iterator is before prev_stop.
3566 (init_iterator): Initialize bidi_p from the default value of
3567 bidi-display-reordering, not from buffer-local value. Use the
3568 buffer-local value only if initializing for buffer iteration.
3569 (handle_invisible_prop): Support invisible properties on strings
3570 that are being bidi-reordered.
3571 (set_iterator_to_next): Support bidi reordering of C strings and
3573 (next_element_from_string): Support bidi reordering of Lisp
3575 (handle_stop_backwards): Support Lisp strings as well.
3576 (display_string): Support display of R2L glyph rows.
3577 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3578 (init_iterator): Don't initialize it->bidi_p for strings
3580 (reseat_to_string): Initialize it->bidi_p for strings here.
3581 (next_element_from_string, next_element_from_c_string)
3582 (next_element_from_buffer): Add xassert's for correspondence
3583 between IT's object being iterated and it->bidi_it.string
3585 (face_before_or_after_it_pos): Support bidi iteration.
3586 (next_element_from_c_string): Handle the case of the first string
3587 character that is not the first one in the visual order.
3588 (get_visually_first_element): New function, refactored from common
3589 parts of next_element_from_buffer, next_element_from_string, and
3590 next_element_from_c_string.
3591 (tool_bar_lines_needed, redisplay_tool_bar)
3592 (display_menu_bar): Force left-to-right direction. Add a FIXME
3593 comment for making that be controlled by a user option.
3594 (push_it, pop_it): Save and restore the state of the
3595 bidi iterator. Save and restore the bidi_p flag.
3596 (pop_it): Iterate out of display property for string iteration as
3598 (iterate_out_of_display_property): Support iteration over strings.
3599 (handle_single_display_spec): Set up it->bidi_it for iteration
3600 over a display string, and call bidi_init_it.
3601 (handle_single_display_spec, next_overlay_string)
3602 (get_overlay_strings_1, push_display_prop): Set up the bidi
3603 iterator for displaying display or overlay strings.
3604 (forward_to_next_line_start): Don't use the shortcut if
3606 (back_to_previous_visible_line_start): If handle_display_prop
3607 pushed the iterator stack, restore the internal state of the bidi
3608 iterator by calling bidi_pop_it same number of times.
3609 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3610 and we are bidi-iterating, don't decrement the iterator position;
3611 instead, set the first_elt flag in the bidi iterator, to produce
3613 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3614 (push_display_prop): xassert that we are iterating a buffer.
3615 (push_it, pop_it): Save and restore paragraph_embedding member.
3616 (handle_single_display_spec, next_overlay_string)
3617 (get_overlay_strings_1, reseat_1, reseat_to_string)
3618 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3619 correctly. Don't assume unibyte strings are not bidi-reordered.
3620 (compute_display_string_pos)
3621 (compute_display_string_end): Fix handling the case of C string.
3622 (push_it, pop_it): Save and restore from_disp_prop_p.
3623 (handle_single_display_spec, push_display_prop): Set the
3624 from_disp_prop_p flag.
3625 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3626 (pop_it): Call iterate_out_of_display_property only if we are
3627 popping after iteration over a string that came from a display
3628 property. Fix a typo in popping stretch info. Add an assertion
3629 for verifying that the iterator position is in sync with the bidi
3631 (handle_single_display_spec, get_overlay_strings_1)
3632 (push_display_prop): Fix initialization of paragraph direction for
3633 string when that of the parent object is not yet determined.
3634 (reseat_1): Call bidi_init_it to resync the bidi
3635 iterator with IT's position. (Bug#7616)
3636 (find_row_edges): If ROW->start.pos gives position
3637 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3638 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3639 Reset the from_disp_prop_p flag.
3640 (SAVE_IT, RESTORE_IT): New macros.
3641 (pos_visible_p, face_before_or_after_it_pos)
3642 (back_to_previous_visible_line_start)
3643 (move_it_in_display_line_to, move_it_in_display_line)
3644 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3645 (try_scrolling, redisplay_window, display_line): Use them when
3646 saving a temporary copy of the iterator and restoring it back.
3647 (back_to_previous_visible_line_start, reseat_1)
3648 (init_iterator): Empty the bidi cache "stack".
3649 (move_it_in_display_line_to): If iterator ended up at
3650 EOL, but we never saw any buffer positions smaller than
3651 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3652 motion in bidi-reordered lines.
3653 (move_it_in_display_line_to): Record prev_method and prev_pos
3654 immediately before the call to set_iterator_to_next. Fixes cursor
3655 motion in bidi-reordered lines with stretch glyphs and strings
3656 displayed in margins. (Bug#8133) (Bug#8867)
3657 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3659 (pos_visible_p): Support positions in bidi-reordered lines.
3660 Save and restore bidi cache.
3662 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3663 (bidi_paragraph_info): Delete unused struct.
3664 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3665 (bidi_cache_start): New variable.
3666 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3668 (bidi_cache_fetch_state, bidi_cache_search)
3669 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3670 (bidi_cache_find, bidi_peek_at_next_level)
3671 (bidi_level_of_next_char, bidi_find_other_level_edge)
3672 (bidi_move_to_visually_next): Compare cache index with
3673 bidi_cache_start rather than with zero.
3674 (bidi_fetch_char): Accept new argument STRING; all callers
3675 changed. Support iteration over a string. Support strings with
3676 display properties. Support unibyte strings. Fix the type of
3677 `len' according to what STRING_CHAR_AND_LENGTH expects.
3678 (bidi_paragraph_init, bidi_resolve_explicit_1)
3679 (bidi_resolve_explicit, bidi_resolve_weak)
3680 (bidi_level_of_next_char, bidi_move_to_visually_next):
3681 Support iteration over a string.
3682 (bidi_set_sor_type, bidi_resolve_explicit_1)
3683 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3684 can now be zero (for strings); special values 0 and -1 were
3685 changed to -1 and -2, respectively.
3686 (bidi_char_at_pos): New function.
3687 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3688 Call it instead of FETCH_MULTIBYTE_CHAR.
3689 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3690 initialized to valid values.
3691 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3693 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3694 the test for valid cached positions. Fix the logic for looking up
3695 the sentinel state in the cache. GCPRO the Lisp string we are
3697 (bidi_push_it, bidi_pop_it): New functions.
3698 (bidi_initialize): Initialize the bidi cache start stack pointer.
3699 (bidi_cache_ensure_space): New function, refactored from part of
3700 bidi_cache_iterator_state. Don't assume the required size is just
3701 one BIDI_CACHE_CHUNK away.
3702 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3703 (bidi_count_bytes, bidi_char_at_pos): New functions.
3704 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3705 always valid if bidi_cache_idx is valid.
3706 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3707 is valid if it's going to be used.
3708 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3709 (bidi_cache_fetch_state, bidi_cache_search)
3710 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3711 (bidi_cache_iterator_state, bidi_cache_find)
3712 (bidi_find_other_level_edge, bidi_cache_start_stack):
3713 All variables related to cache indices are now EMACS_INT.
3715 * dispextern.h (struct bidi_string_data): New structure.
3716 (struct bidi_it): New member `string'. Make flag members be 1-bit
3717 fields, and put them last in the struct.
3718 (compute_display_string_pos, compute_display_string_end):
3720 (bidi_push_it, bidi_pop_it): Add prototypes.
3721 (struct iterator_stack_entry): New members bidi_p,
3722 paragraph_embedding, and from_disp_prop_p.
3723 (struct it): Member bidi_p is now a bit field 1 bit wide.
3724 (bidi_shelve_cache, bidi_unshelve_cache):
3727 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3728 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3729 and vector-like objects.
3731 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3732 cache around display iteration.
3734 * window.c (Fwindow_end, window_scroll_pixel_based)
3735 (displayed_window_lines, Frecenter): Save and restore the bidi
3736 cache around display iteration.
3738 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3740 * editfns.c (Fdelete_region): Clarify the use of the named
3741 parameters (bug#6788).
3743 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3745 * indent.c (Fvertical_motion): Set and restore w->pointm when
3746 saving and restoring the window's buffer (Bug#9006).
3748 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3750 * editfns.c (Fstring_to_char): Clarify just what is returned
3751 (bug#6576). Text by Eli Zaretskii.
3753 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3755 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3757 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3759 * buffer.c (mmap_find): Fix a typo.
3761 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3763 Fix execution of x selection hooks.
3764 * xselect.c (Qx_lost_selection_functions)
3765 (Qx_sent_selection_functions): New vars.
3766 (syms_of_xselect): DEFSYM them.
3767 (x_handle_selection_request): Pass Qx_sent_selection_functions
3768 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3769 (x_handle_selection_clear,x_clear_frame_selections):
3770 Pass Qx_lost_selection_functions rather than
3771 Vx_lost_selection_functions to Frun_hook_with_args.
3773 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3775 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3776 The old code sometimes used this field without initializing it.
3778 * alloc.c (gc_sweep): Don't read past end of array.
3779 In theory, the old code could also have corrupted Emacs internals,
3780 though it'd be very unlikely.
3782 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3784 * character.c (Fcharacterp): Don't advertise optional ignored
3785 argument. (Bug#4026)
3787 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3789 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3792 * window.c (Fset_window_start): Doc fix (bug#4199).
3793 (Fset_window_hscroll): Ditto.
3795 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3797 Fix minor new problems caught by GCC 4.6.1.
3798 * term.c (init_tty): Remove unused local.
3799 * xsettings.c (store_monospaced_changed): Define this function only
3800 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3803 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3805 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3807 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3809 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3810 are the mini-buffer and the echo area (bug#3320).
3812 * term.c (init_tty): Remove support for supdup, c10 and perq
3813 terminals, which are no longer supported (bug#1482).
3815 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3817 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3819 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3821 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3822 for non-popups (Bug#3642).
3824 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3826 * alloc.c (reset_malloc_hooks): Protoize.
3827 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3828 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3829 * cm.c (losecursor): Likewise.
3830 * data.c (fmod): Likewise.
3831 * dispnew.c (swap_glyphs_in_rows): Likewise.
3832 * emacs.c (memory_warning_signal): Likewise.
3833 * floatfns.c (float_error): Likewise.
3834 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3835 (otf_open, font_otf_capability, generate_otf_features)
3836 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3838 * image.c (pbm_read_file): Likewise.
3839 * indent.c (string_display_width): Likewise.
3840 * intervals.c (check_for_interval, search_for_interval)
3841 (inc_interval_count, count_intervals, root_interval)
3842 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3843 * lread.c (defalias): Likewise.
3844 * ralloc.c (r_alloc_check): Likewise.
3845 * regex.c (set_image_of_range_1, set_image_of_range)
3846 (regex_grow_registers): Likewise.
3847 * sysdep.c (strerror): Likewise.
3848 * termcap.c (valid_filename_p, tprint, main): Likewise.
3849 * tparam.c (main): Likewise.
3850 * unexhp9k800.c (run_time_remap, save_data_space)
3851 (update_file_ptrs, read_header, write_header, calculate_checksum)
3852 (copy_file, copy_rest, display_header): Likewise.
3853 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3855 * xdisp.c (check_it): Likewise.
3856 * xfaces.c (register_color, unregister_color, unregister_colors):
3858 * xfns.c (print_fontset_result): Likewise.
3859 * xrdb.c (member, fatal, main): Likewise.
3861 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3863 Fix minor problems found by static checking (Bug#9031).
3864 * chartab.c (char_table_set_range, map_sub_char_table):
3865 Remove unused locals.
3866 (uniprop_table): Now static.
3867 * composite.c (_work_char): Remove unused static var.
3869 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3871 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3873 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3875 * gtkutil.c (qttip_cb): Remove code without function.
3877 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3879 * w32.c (pthread_sigmask): New stub.
3881 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3883 Use pthread_sigmask, not sigprocmask (Bug#9010).
3884 sigprocmask is portable only for single-threaded applications, and
3885 Emacs can be multi-threaded when it uses GTK.
3886 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3888 * callproc.c (Fcall_process):
3889 * process.c (create_process):
3890 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3891 Use pthread_sigmask, not sigprocmask.
3893 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3895 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3896 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3899 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3901 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3902 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3903 (xg_hide_tooltip): Fix comment.
3905 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3906 in registerServicesMenuSendTypes.
3907 (validRequestorForSendType): Don't check ns_return_types.
3909 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3912 2011-07-08 Jason Rumney <jasonr@gnu.org>
3914 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3915 SH_SHOW for hidden windows (Bug#5482).
3917 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3918 frame struct members of non-existent frames (Bug#6284).
3920 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3922 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3923 variable firstTime not needed on OSX >= 10.6.
3924 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3925 >= 10.5. Use setKnobProportion, setDoubleValue.
3927 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3928 (MAC_OS_X_VERSION_10_5): Define if not defined.
3929 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3930 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3931 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3933 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3934 cString and lossyCString on OSX >= 10.4
3936 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3937 sizeToFit on OSX >= 10.2.
3939 * nsimage.m (allocInitFromFile): Don't use deprecated method
3940 bestRepresentationForDevice on OSX >= 10.6.
3942 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3945 * emacs.c: Declare unexec_init_emacs_zone.
3947 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3949 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3951 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3952 on svcsMenu (Bug#8842).
3954 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3956 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3958 * nsterm.m (QUTF8_STRING): Declare.
3959 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3960 (validRequestorForSendType): Return type is (id).
3961 Change indexOfObjectIdenticalTo to indexOfObject.
3962 Check if we have local selection before returning self (Bug#8842).
3963 (writeSelectionToPasteboard): Put local selection into paste board
3964 if we have a local selection (Bug#8842).
3965 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3967 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3968 (ns_get_local_selection): Declare.
3970 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3972 * keymap.c (describe_map_tree): Don't insert a double newline at
3973 the end of the buffer (bug#1169) and return whether we inserted
3976 * callint.c (Fcall_interactively): Change "reading args" to
3977 "providing args" to try to clarify what it does (bug#1010).
3979 2011-07-07 Kenichi Handa <handa@m17n.org>
3981 * composite.c (composition_compute_stop_pos): Ignore a static
3982 composition starting before CHARPOS (Bug#8915).
3984 * xdisp.c (handle_composition_prop): Likewise.
3986 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3988 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3991 2011-07-07 Kenichi Handa <handa@m17n.org>
3993 * character.h (unicode_category_t): New enum type.
3995 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3996 (Qchar_code_property_table): New variable.
3997 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3998 (UNIPROP_COMPRESSED_FORM_P): New macros.
3999 (char_table_ascii): Uncompress the compressed values.
4000 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4001 Uncompress the compressed values.
4002 (sub_char_table_ref_and_range): Likewise.
4003 (char_table_ref_and_range): Uncompress the compressed values.
4004 (sub_char_table_set): New arg is_uniprop. Callers changed.
4005 Uncompress the compressed values.
4006 (sub_char_table_set_range): Args changed. Callers changed.
4007 (char_table_set_range): Adjuted for the above change.
4008 (map_sub_char_table): Delete args default_val and parent. Add arg
4009 top. Give decoded values to a Lisp function.
4010 (map_char_table): Adjust for the above change. Give decoded
4011 values to a Lisp function. Gcpro more variables.
4012 (uniprop_table_uncompress)
4013 (uniprop_decode_value_run_length): New functions.
4014 (uniprop_decoder, uniprop_decoder_count): New variables.
4015 (uniprop_get_decoder, uniprop_encode_value_character)
4016 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4018 (uniprop_encoder, uniprop_encoder_count): New variables.
4019 (uniprop_get_encoder, uniprop_table)
4020 (Funicode_property_table_internal, Fget_unicode_property_internal)
4021 (Fput_unicode_property_internal): New functions.
4022 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4023 Sunicode_property_table_internal, Sget_unicode_property_internal,
4024 and Sput_unicode_property_internal. Defvar_lisp
4025 char-code-property-alist.
4027 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4028 Vunicode_category_table.
4030 * font.c (font_range): Adjust for the change of
4031 Vunicode_category_table.
4033 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4035 * m/iris4d.h: Remove file, move contents ...
4036 * s/irix6-5.h: ... here.
4038 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4040 Remove unportable assumption about struct layout (Bug#8884).
4041 * alloc.c (mark_buffer):
4042 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4043 (clone_per_buffer_values): Don't assume that
4044 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4045 This isn't true in general, and it's particularly not true
4046 if Emacs is configured with --with-wide-int.
4047 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4048 New macros, used in the buffer.c change.
4050 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4052 * xsettings.c: Use both GConf and GSettings if both are available.
4053 (store_config_changed_event): Add comment.
4054 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4055 (store_tool_bar_style_changed): New functions.
4056 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4057 (struct xsettings): Move font inside HAVE_XFT.
4058 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4059 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4060 Move inside HAVE_XFT.
4061 (something_changed_gsettingsCB): Rename from something_changedCB.
4062 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4064 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4065 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4066 (something_changed_gconfCB): Rename from something_changedCB.
4067 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4068 (parse_settings): Move check for font inside HAVE_XFT.
4069 (read_settings, apply_xft_settings): Add comment.
4070 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4071 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4072 call store_font_name_changed.
4073 (xft_settings_event): Add comment.
4074 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4075 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4076 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4077 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4078 (xsettings_initialize): Call init_gsettings last.
4079 (xsettings_get_system_font, xsettings_get_system_normal_font):
4082 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4084 Random fixes. E.g., (random) never returned negative values.
4085 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4086 subseconds part to the entropy, as that's a bit more random.
4087 Prefer signed to unsigned, since the signedness doesn't matter and
4088 in general we prefer signed. When given a limit, use a
4089 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4090 latter isn't right if USE_2_TAGS_FOR_INTS.
4091 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4092 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4094 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4096 * textprop.c (text_property_stickiness):
4097 Obey Vtext_property_default_nonsticky.
4098 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4099 * w32fns.c (syms_of_w32fns):
4100 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4102 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4104 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4105 This is more efficient than Ffile_directory_p and avoids a minor race.
4107 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4109 * buffer.c (Foverlay_put): Say what the return value is
4112 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4113 is a directory before asking whether to use the file name
4115 (barf_or_query_if_file_exists): Make the "File is a directory"
4116 error be more correct.
4118 * fns.c (Frequire): Remove the mention of the .gz files, since
4119 that's installation-specific, but keep the mention of
4120 `get-load-suffixes'.
4122 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4124 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4125 Report string overflow if the output is too long.
4127 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4129 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4130 (syms_of_gnutls): Remove duplicate DEFSYM for
4131 Qgnutls_bootprop_verify_hostname_error, an error for
4132 Qgnutls_bootprop_verify_error (which is no longer used).
4134 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4135 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4136 Also (re)move comments that are misplaced or no longer relevant.
4138 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4140 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4142 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4144 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4145 and background color parameters if they have been changed.
4147 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4149 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4151 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4153 * xsettings.c (SYSTEM_FONT): Define only when used.
4154 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4156 * keymap.c (access_keymap_1): Now static.
4158 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4160 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4161 leave any prefix arg for the up event (Bug#1586).
4163 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4165 * lread.c (syms_of_lread): Mention single symbols defined by
4166 `defvar' or `defconst' (bug#7154).
4168 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4169 (Frequire): Mention get-load-suffixes.
4171 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4173 * window.h (window): Remove clone_number slot.
4174 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4176 (make_parent_window, make_window, saved_window)
4177 (Fset_window_configuration, save_window_save): Don't deal with
4179 * buffer.c (Qclone_number): Remove declaration.
4180 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4182 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4184 Add multiple inheritance to keymaps.
4185 * keymap.c (Fmake_composed_keymap): New function.
4186 (Fset_keymap_parent): Simplify.
4187 (fix_submap_inheritance): Remove.
4188 (access_keymap_1): New function extracted from access_keymap to handle
4189 embedded parents and handle lists of maps.
4190 (access_keymap): Use it.
4191 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4192 (Fcopy_keymap): Handle embedded parents.
4193 (Fcommand_remapping, define_as_prefix): Simplify.
4194 (Fkey_binding): Simplify.
4195 (syms_of_keymap): Move minibuffer-local-completion-map,
4196 minibuffer-local-filename-completion-map,
4197 minibuffer-local-must-match-map, and
4198 minibuffer-local-filename-must-match-map to Elisp.
4199 (syms_of_keymap): Defsubr make-composed-keymap.
4200 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4201 (parse_menu_item): Trivial simplification.
4203 2011-07-01 Glenn Morris <rgm@gnu.org>
4205 * Makefile.in (SETTINGS_LIBS): Fix typo.
4207 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4209 * coding.c (Fencode_coding_string): Record the last coding system
4210 used, as the function doc string says (bug#8738).
4212 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4214 * xsettings.c (store_monospaced_changed): Take new font as arg and
4215 check for change against current_mono_font.
4216 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4217 (emacs_settings_constructor, emacs_settings_get_property)
4218 (emacs_settings_set_property, emacs_settings_class_init)
4219 (emacs_settings_init, gsettings_obj): Remove.
4220 (something_changedCB): New function for HAVE_GSETTINGS.
4221 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4222 with value as argument.
4223 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4224 g_settings_new (Bug#8967). Do not create gsettings_obj.
4225 Remove calls to g_settings_bind. Connect something_changedCB to
4228 * xgselect.c: Add defined (HAVE_GSETTINGS).
4229 (xgselect_initialize): Ditto.
4231 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4232 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4235 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4237 * eval.c (struct backtrace): Simplify and port the data structure.
4238 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4239 signed bit field, as this assumption is not portable and it makes
4240 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4241 "char debug_on_exit : 1" as this is not portable either; instead,
4242 use the portable "unsigned int debug_on_exit : 1". Remove unused
4243 member evalargs. Remove obsolete comments about cc bombing out.
4245 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4247 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4248 Let HAVE_GSETTINGS override HAVE_GCONF.
4249 (store_monospaced_changed): New function.
4250 (EMACS_SETTINGS): A new type derived from GObject to handle
4251 GSettings notifications.
4252 (emacs_settings_constructor, emacs_settings_get_property)
4253 (emacs_settings_set_property, emacs_settings_class_init):
4255 (gsettings_client, gsettings_obj): New variables.
4256 (GSETTINGS_SCHEMA): New define.
4257 (something_changedCB): Call store_monospaced_changed.
4258 (init_gsettings): New function.
4259 (xsettings_initialize): Call init_gsettings.
4260 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4263 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4266 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4268 * window.c (resize_root_window, grow_mini_window)
4269 (shrink_mini_window): Rename Qresize_root_window to
4270 Qwindow_resize_root_window and Qresize_root_window_vertically to
4271 Qwindow_resize_root_window_vertically.
4273 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4275 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4277 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4279 * makefile.w32-in: Redesign dependencies so they reflect more
4280 clearly which files are directly included by each source file,
4281 and not through other includes.
4283 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4285 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4286 (sort_overlays, overlay_strings): When an overlay's clone number
4287 matches the window's clone number process the overlay even if
4288 the overlay's window property doesn't match the current window.
4290 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4291 (Fwindow_hchild): Rename to Fwindow_left_child.
4292 (Fwindow_next): Rename to Fwindow_next_sibling.
4293 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4294 (resize_window_check): Rename to window_resize_check.
4295 (resize_window_apply): Rename to window_resize_apply.
4296 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4297 (Fdelete_other_windows_internal, resize_frame_windows)
4298 (Fsplit_window_internal, Fdelete_window_internal)
4299 (grow_mini_window, shrink_mini_window)
4300 (Fresize_mini_window_internal): Fix callers accordingly.
4302 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4304 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4305 (emacs_fixed_set_min_size): Remove.
4306 (emacs_fixed_new): Take frame as argument.
4308 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4309 (_EmacsFixedPrivate): Remove minwidth/height.
4310 Add struct frame *f.
4311 (emacs_fixed_init): Initialize priv->f.
4312 (get_parent_class, emacs_fixed_set_min_size): Remove.
4313 (emacs_fixed_new): Set priv->f to argument.
4314 (emacs_fixed_get_preferred_width)
4315 (emacs_fixed_get_preferred_height): Use min_width/height from
4316 frames size_hint to set minimum and natural (Bug#8919).
4317 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4318 and use min_width/height from frames size_hint to set
4319 min_width/height (Bug#8919).
4321 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4322 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4325 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4327 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4328 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4331 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4333 * process.c (wait_reading_process_output): Bypass select if
4334 waiting for a cell while ignoring keyboard input, and input is
4335 pending. Suggested by Jan Djärv (Bug#8869).
4337 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4339 Use gnulib's dup2 module instead of rolling our own.
4340 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4342 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4344 * dispnew.c (scrolling_window): Before scrolling, turn off a
4345 mouse-highlight in the window being scrolled.
4347 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4349 Move DEFSYM to lisp.h and use everywhere.
4351 * character.h (DEFSYM): Move declaration...
4352 * lisp.h (DEFSYM): ...here.
4358 * w32select.c: Don't include character.h.
4360 * alloc.c (syms_of_alloc):
4361 * buffer.c (syms_of_buffer):
4362 * bytecode.c (syms_of_bytecode):
4363 * callint.c (syms_of_callint):
4364 * casefiddle.c (syms_of_casefiddle):
4365 * casetab.c (init_casetab_once):
4366 * category.c (init_category_once, syms_of_category):
4367 * ccl.c (syms_of_ccl):
4368 * cmds.c (syms_of_cmds):
4369 * composite.c (syms_of_composite):
4370 * dbusbind.c (syms_of_dbusbind):
4371 * dired.c (syms_of_dired):
4372 * dispnew.c (syms_of_display):
4373 * doc.c (syms_of_doc):
4374 * editfns.c (syms_of_editfns):
4375 * emacs.c (syms_of_emacs):
4376 * eval.c (syms_of_eval):
4377 * fileio.c (syms_of_fileio):
4378 * fns.c (syms_of_fns):
4379 * frame.c (syms_of_frame):
4380 * fringe.c (syms_of_fringe):
4381 * insdel.c (syms_of_insdel):
4382 * keymap.c (syms_of_keymap):
4383 * lread.c (init_obarray, syms_of_lread):
4384 * macros.c (syms_of_macros):
4385 * msdos.c (syms_of_msdos):
4386 * print.c (syms_of_print):
4387 * process.c (syms_of_process):
4388 * search.c (syms_of_search):
4389 * sound.c (syms_of_sound):
4390 * syntax.c (init_syntax_once, syms_of_syntax):
4391 * terminal.c (syms_of_terminal):
4392 * textprop.c (syms_of_textprop):
4393 * undo.c (syms_of_undo):
4394 * w32.c (globals_of_w32):
4395 * window.c (syms_of_window):
4396 * xdisp.c (syms_of_xdisp):
4397 * xfaces.c (syms_of_xfaces):
4398 * xfns.c (syms_of_xfns):
4399 * xmenu.c (syms_of_xmenu):
4400 * xsettings.c (syms_of_xsettings):
4401 * xterm.c (syms_of_xterm): Use DEFSYM.
4403 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4405 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4407 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4409 Integer and buffer overflow fixes (Bug#8873).
4411 * print.c (printchar, strout): Check for string overflow.
4412 (PRINTPREPARE, printchar, strout):
4413 Don't set size unless allocation succeeds.
4415 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4416 for sizes. Check for string overflow more accurately.
4417 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4419 * macros.c: Integer and buffer overflow fixes.
4420 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4421 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4422 Use ptrdiff_t, not int, for sizes.
4423 Don't increment bufsize until after realloc succeeds.
4424 Check for size-calculation overflow.
4425 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4427 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4429 * lread.c: Integer overflow fixes.
4430 (read_integer): Radix is now EMACS_INT, not int,
4431 to improve quality of diagnostics for out-of-range radices.
4432 Calculate buffer size correctly for out-of-range radices.
4433 (read1): Check for integer overflow in radices, and in
4434 read-circle numbers.
4435 (read_escape): Avoid int overflow.
4436 (Fload, openp, read_buffer_size, read1)
4437 (substitute_object_recurse, read_vector, read_list, map_obarray):
4438 Use ptrdiff_t, not int, for sizes.
4439 (read1): Use EMACS_INT, not int, for sizes.
4440 Check for size overflow.
4442 * image.c (cache_image): Check for size arithmetic overflow.
4444 * lread.c: Integer overflow issues.
4445 (saved_doc_string_size, saved_doc_string_length)
4446 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4447 Now ptrdiff_t, not int.
4448 (read1): Don't assume doc string length fits in int. Check for
4449 out-of-range doc string lengths.
4450 (read_list): Don't assume file position fits in int.
4451 (read_escape): Check for hex character overflow.
4453 2011-06-22 Leo Liu <sdl.web@gmail.com>
4455 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4456 Move to minibuffer.el.
4458 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4460 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4461 The following patches are for when GLYPH_DEBUG && !XASSERT.
4462 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4463 * dispnew.c (flush_stdout):
4464 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4465 Mark as externally visible.
4466 * dispnew.c (check_window_matrix_pointers): Now static.
4467 * dispnew.c (window_to_frame_vpos):
4468 * xfns.c (unwind_create_frame):
4469 * xterm.c (x_check_font): Remove unused local.
4470 * scroll.c (CHECK_BOUNDS):
4471 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4472 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4473 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4474 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4475 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4477 (debug_method_add): Use va_list and vsprintf rather than relying
4478 on undefined behavior with wrong number of arguments.
4479 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4480 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4481 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4482 since we're not interested in debugging glyphs with old libraries.
4483 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4484 GCC 4.6.0's static checking.
4486 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4488 Integer overflow and signedness fixes (Bug#8873).
4489 A few related buffer overrun fixes, too.
4491 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4493 * dispextern.h (struct face.stipple):
4494 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4495 (x_bitmap_mask, x_allocate_bitmap_record)
4496 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4497 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4498 (x_create_bitmap_from_xpm_data):
4499 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4500 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4502 * xfaces.c (load_pixmap):
4503 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4504 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4505 (.bitmaps_last, struct x_output.icon_bitmap):
4506 Use ptrdiff_t, not int, for bitmap indexes.
4507 (x_allocate_bitmap_record): Check for size overflow.
4508 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4510 Use ptrdiff_t, not int, for overlay counts.
4511 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4512 * editfns.c (overlays_around, get_pos_property):
4513 * textprop.c (get_char_property_and_overlay):
4514 * xdisp.c (next_overlay_change, note_mouse_highlight):
4515 * xfaces.c (face_at_buffer_position):
4516 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4517 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4518 (Fnext_overlay_change, Fprevious_overlay_change)
4519 (mouse_face_overlay_overlaps, Foverlays_in):
4520 Use ptrdiff_t, not int, for sizes.
4521 (overlays_at, overlays_in): Check for size-calculation overflow.
4523 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4525 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4526 (x_session_initialize): Do not assume string length fits in int.
4528 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4529 This is unlikely, but can occur if DPI is outlandish.
4531 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4532 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4534 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4535 * xrdb.c (magic_file_p, search_magic_path):
4536 Omit last arg SUFFIX; it was always 0. All callers changed.
4537 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4539 * xfont.c (xfont_match): Avoid need for strlen.
4541 * xfns.c: Don't assume strlen fits in int.
4542 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4544 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4545 not unsigned long, as we prefer signed integers. All callers changed.
4546 Detect integer overflow in repeat count.
4547 (message_dolog): Don't assume print length fits in 39 bytes.
4548 (display_mode_element): Don't assume strlen fits in int.
4550 * termcap.c: Don't assume sizes fit in int and never overflow.
4551 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4552 (gobble_line): Check for size-calculation overflow.
4554 * minibuf.c (Fread_buffer):
4555 * lread.c (intern, intern_c_string):
4556 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4557 Don't assume string length fits in int.
4559 * keyboard.c (parse_tool_bar_item):
4560 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4562 * font.c: Don't assume string length fits in int.
4563 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4564 Use ptrdiff_t, not int.
4565 (font_intern_prop): Don't assume string length fits in int.
4566 Don't assume integer property fits in fixnum.
4567 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4569 * filelock.c: Fix some buffer overrun and integer overflow issues.
4570 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4571 Reformulate so as not to need the command string.
4572 Invoke gzip -cd rather than gunzip, as it's more portable.
4573 (lock_info_type, lock_file_1, lock_file):
4574 Don't assume pid_t and time_t fit in unsigned long.
4575 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4576 (current_lock_owner): Prefer signed type for sizes.
4577 Use memcpy, not strncpy, where memcpy is what is really wanted.
4578 Don't assume (via atoi) that time_t and pid_t fit in int.
4579 Check for time_t and/or pid_t out of range, e.g., via a network share.
4580 Don't alloca where an auto var works fine.
4582 * fileio.c: Fix some integer overflow issues.
4583 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4584 Don't assume string length fits in int.
4585 (directory_file_name): Don't assume string length fits in long.
4586 (make_temp_name): Don't assume pid fits in int, or that its print
4587 length is less than 20.
4589 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4591 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4593 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4595 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4596 We prefer signed integers, even for size calculations.
4598 * emacs.c: Don't assume string length fits in 'int'.
4599 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4600 (main): Don't invoke strlen when not needed.
4602 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4603 (XD_DEBUG_MESSAGE): Don't waste a byte.
4605 * callproc.c (getenv_internal_1, getenv_internal)
4607 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4609 * lread.c (invalid_syntax): Omit length argument.
4610 All uses changed. This doesn't fix a bug, but it simplifies the
4611 code away from its former Hollerith-constant appearance, and it's
4612 one less 'int' to worry about when looking at integer-overflow issues.
4613 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4615 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4616 This didn't break anything, but it didn't help either.
4617 It's confusing to put a bogus integer in a place where the actual
4618 value does not matter.
4619 (LIST_END_P): Remove unused macro and its bogus comment.
4620 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4622 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4623 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4625 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4626 We prefer signed types, and the value cannot exceed the EMACS_INT
4627 range anyway (because otherwise the length would not be representable).
4628 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4629 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4630 This avoids a GCC warning when WIDE_EMACS_INT.
4632 * indent.c (sane_tab_width): New function.
4633 (current_column, scan_for_column, Findent_to, position_indentation)
4634 (compute_motion): Use it. This is just for clarity.
4635 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4637 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4639 * lisp.h (lint_assume): New macro.
4640 * composite.c (composition_gstring_put_cache):
4641 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4643 * editfns.c, insdel.c:
4644 Omit unnecessary forward decls, to simplify future changes.
4646 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4648 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4650 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4651 Use much-faster test for byte-length change.
4652 Don't assume string byte-length fits in 'int'.
4653 Check that character arg fits in 'int'.
4654 (mapcar1): Declare byte as byte, for clarity.
4656 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4658 * fns.c (concat): Catch string overflow earlier.
4659 Do not rely on integer wraparound.
4661 * dispextern.h (struct it.overlay_strings_charpos)
4662 (struct it.selective): Now EMACS_INT, not int.
4663 * xdisp.c (forward_to_next_line_start)
4664 (back_to_previous_visible_line_start)
4665 (reseat_at_next_visible_line_start, next_element_from_buffer):
4666 Don't arbitrarily truncate the value of 'selective' to int.
4668 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4670 * composite.c: Don't truncate sizes to 'int'.
4671 (composition_gstring_p, composition_reseat_it)
4672 (composition_adjust_point): Use EMACS_INT, not int.
4673 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4674 not EMACS_UINT, for indexes.
4676 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4678 * buffer.c: Include <verify.h>.
4679 (struct sortvec.priority, struct sortstr.priority):
4680 Now EMACS_INT, not int.
4681 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4682 (struct sortstr.size, record_overlay_string)
4683 (struct sortstrlist.size, struct sortlist.used):
4684 Don't truncate size to int.
4685 (record_overlay_string): Check for size-calculation overflow.
4686 (init_buffer_once): Check at compile-time, not run-time.
4688 2011-06-22 Jim Meyering <meyering@redhat.com>
4690 Don't leak an XBM-image-sized buffer
4691 * image.c (xbm_load): Free the image buffer after using it.
4693 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4696 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4697 that Sun C diagnosed.
4698 * fns.c (secure_hash): Fix pointer signedness issue.
4699 * intervals.c (static_offset_intervals): New function.
4700 (offset_intervals): Use it.
4702 2011-06-21 Leo Liu <sdl.web@gmail.com>
4705 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4708 * fns.c (secure_hash): Rename from crypto_hash_function and change
4709 the first arg to accept symbols.
4710 (Fsecure_hash): New primitive.
4711 (syms_of_fns): New symbols.
4713 2011-06-20 Deniz Dogan <deniz@dogan.se>
4715 * process.c (Fset_process_buffer): Clarify return value in
4718 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4720 * dispnew.c (add_window_display_history): Use BVAR.
4722 * xdisp.c (debug_method_add): Use BVAR.
4723 (check_window_end, dump_glyph_matrix, dump_glyph)
4724 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4726 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4729 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4730 check till after the cache is created in init_frame_faces.
4732 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4734 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4736 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4738 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4739 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4740 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4742 Improve buffer-overflow checking (Bug#8873).
4743 * fileio.c (Finsert_file_contents):
4744 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4745 Remove the old (too-loose) buffer overflow checks.
4746 They weren't needed, since make_gap checks for buffer overflow.
4747 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4748 The old code merely checked for Emacs fixnum overflow, and relied
4749 on undefined (wraparound) behavior. The new code avoids undefined
4750 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4752 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4753 Tune. Don't use wider integers than needed. Don't use alloca.
4754 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4756 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4758 * insdel.c, lisp.h (buffer_overflow): New function.
4759 (insert_from_buffer_1, replace_range, replace_range_2):
4760 * insdel.c (make_gap_larger):
4761 * editfns.c (Finsert_char):
4762 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4764 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4766 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4768 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4770 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4771 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4773 * fileio.c: Don't assume EMACS_INT fits in off_t.
4774 (emacs_lseek): New static function.
4775 (Finsert_file_contents, Fwrite_region): Use it.
4776 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4778 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4780 * fns.c: Don't overflow int when computing a list length.
4781 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4782 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4783 truncation on 64-bit hosts. Check for QUIT every
4784 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4785 faster and is responsive enough.
4786 (Flength): Report an error instead of overflowing an integer.
4787 (Fsafe_length): Return a float if the value is not representable
4788 as a fixnum. This shouldn't happen except in contrived situations.
4789 (Fnthcdr, Fsort): Don't assume list length fits in int.
4790 (Fcopy_sequence): Don't assume vector length fits in int.
4792 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4793 (header_size, word_size): New constants.
4794 (allocate_vectorlike): Don't check size overflow here.
4795 (allocate_vector): Check it here instead, since this is the only
4796 caller of allocate_vectorlike that could cause overflow.
4797 Check that the new vector's length is representable as a fixnum.
4799 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4800 The previous code was bogus. For example, next_almost_prime (32)
4801 returned 39, which is undesirable as it is a multiple of 3; and
4802 next_almost_prime (24) returned 25, which is a multiple of 5 so
4803 why was the code bothering to check for multiples of 7?
4805 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4807 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4809 Variadic C functions now count arguments with ptrdiff_t.
4810 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4811 Back then I didn't know that the Emacs coding style prefers signed int.
4812 Also, in the meantime I found a few more instances where arguments
4813 were being counted with int, which may truncate counts on 64-bit
4814 machines, or EMACS_INT, which may be unnecessarily wide.
4815 * lisp.h (struct Lisp_Subr.function.aMANY)
4816 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4817 Arg counts are now ptrdiff_t, not size_t.
4818 All variadic functions and their callers changed accordingly.
4819 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4820 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4821 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4822 * callint.c (Fcall_interactively): Check arg count for overflow,
4823 to avoid potential buffer overrun. Use signed char, not 'int',
4824 for 'varies' array, so that we needn't bother to check its size
4825 calculation for overflow.
4826 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4827 * eval.c (apply_lambda):
4828 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4829 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4830 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4832 * callint.c (Fcall_interactively): Don't use index var as event count.
4834 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4835 * mem-limits.h (SIZE): Remove; no longer used.
4837 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4839 Remove unnecessary casts.
4840 * xterm.c (x_term_init):
4841 * xfns.c (x_set_border_pixel):
4842 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4843 These aren't needed now that we assume ANSI C.
4845 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4846 It's more likely to cause problems (due to unsigned overflow)
4849 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4851 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4853 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4855 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4857 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4859 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4861 GLYPH_CODE_FACE returns EMACS_INT, not int.
4862 * dispextern.h (merge_faces):
4863 * xfaces.c (merge_faces):
4864 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4865 Don't assume EMACS_INT fits in int.
4867 * character.h (CHAR_VALID_P): Remove unused parameter.
4868 * fontset.c, lisp.h, xdisp.c: All uses changed.
4870 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4872 * fns.c (concat): Minor tuning based on overflow analysis.
4873 This doesn't fix any bugs. Use int to hold character, instead
4874 of constantly refetching from Emacs object. Use XFASTINT, not
4875 XINT, for value known to be a character. Don't bother comparing
4876 a single byte to 0400, as it's always less.
4878 * floatfns.c (Fexpt):
4879 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4881 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4884 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4886 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4887 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4888 incorrectly succeed when S was a string, because 4294967386 was
4889 truncated before it was used.
4891 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4892 Otherwise, an out-of-range integer could cause undefined behavior
4895 * composite.c: Use int, not EMACS_INT, for characters.
4896 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4897 EMACS_INT, for values that are known to be in character range.
4898 This doesn't fix any bugs but is the usual style inside Emacs and
4899 may generate better code on 32-bit machines.
4901 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4902 This is for reasons similar to the recent CHAR_STRING fix.
4903 * charset.c (Fencode_char): Check that character arg is actually
4904 a character. Pass an int to ENCODE_CHAR.
4905 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4906 wider than 'int', as a compile-time check to prevent future regressions
4909 * character.c (char_string): Remove unnecessary casts.
4911 Make sure a 64-bit char is never passed to CHAR_STRING.
4912 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4913 by silently ignoring the top 32 bits, allowing some values
4914 that were far too large to be valid characters.
4915 * character.h: Include <verify.h>.
4916 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4917 arguments are no wider than unsigned, as a compile-time check
4918 to prevent future regressions in this area.
4920 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4921 (Fsubst_char_in_region):
4923 * xdisp.c (decode_mode_spec_coding):
4924 Adjust to CHAR_STRING's new requirement.
4925 * editfns.c (Finsert_char, Fsubst_char_in_region):
4926 * fns.c (concat): Check that character args are actually
4927 characters. Without this test, these functions did the wrong
4928 thing with wildly out-of-range values on 64-bit hosts.
4930 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4931 These casts should not be needed on 32-bit hosts, either.
4932 * keyboard.c (read_char):
4933 * lread.c (Fload): Remove casts to unsigned.
4935 * lisp.h (UNSIGNED_CMP): New macro.
4936 This fixes comparison bugs on 64-bit hosts.
4937 (ASCII_CHAR_P): Use it.
4938 * casefiddle.c (casify_object):
4939 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4940 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4941 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4942 * dispextern.h (FACE_FROM_ID):
4943 * keyboard.c (read_char): Use UNSIGNED_CMP.
4945 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4946 not to EMACS_INT, to avoid GCC warning.
4948 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4950 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4951 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4952 isn't needed on 32-bit machines.
4954 * buffer.c (Fgenerate_new_buffer_name):
4955 Use EMACS_INT for count, not int.
4956 (advance_to_char_boundary): Return EMACS_INT, not int.
4958 * data.c (Qcompiled_function): Now static.
4960 * window.c (window_body_lines): Now static.
4962 * image.c (gif_load): Rename local to avoid shadowing.
4964 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4965 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4966 * alloc.c (make_save_value): Integer argument is now of type
4968 (mark_object): Use ptrdiff_t, not int.
4969 * lisp.h (pD): New macro.
4970 * print.c (print_object): Use it.
4972 * alloc.c: Use EMACS_INT, not int, to count objects.
4973 (total_conses, total_markers, total_symbols, total_vector_size)
4974 (total_free_conses, total_free_markers, total_free_symbols)
4975 (total_free_floats, total_floats, total_free_intervals)
4976 (total_intervals, total_strings, total_free_strings):
4977 Now EMACS_INT, not int. All uses changed.
4978 (Fgarbage_collect): Compute overall total using a double, so that
4979 integer overflow is less likely to be a problem. Check for overflow
4980 when converting back to an integer.
4981 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4982 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4983 These were 'int' variables that could overflow on 64-bit hosts;
4984 they were never used, so remove them instead of repairing them.
4985 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4986 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4987 Previously, this ceilinged at INT_MAX, but that doesn't work on
4989 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4991 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4992 (allocate_vectorlike): Check for ptrdiff_t overflow.
4993 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4994 when a (possibly-narrower) signed value would do just as well.
4995 We prefer using signed arithmetic, to avoid comparison confusion.
4997 * alloc.c: Catch some string size overflows that we were missing.
4998 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4999 for convenience in STRING_BYTES_MAX.
5000 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5001 The definition here is exact; the one in lisp.h was approximate.
5002 (allocate_string_data): Check for string overflow. This catches
5003 some instances we weren't catching before. Also, it catches
5004 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5005 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5006 and ptrdiff_t and EMACS_INT are both 64 bits.
5008 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5009 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5010 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5012 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5014 * alloc.c (Fmake_string): Check for out-of-range init.
5016 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5018 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5020 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5022 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5023 xg_get_default_scrollbar_width.
5025 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5026 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5027 (style_changed_cb): Call update_theme_scrollbar_width and call
5028 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5029 all frames (Bug#8505).
5030 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5031 Call gtk_window_set_resizable if HAVE_GTK3.
5032 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5033 and height if HAVE_GTK3 (Bug#8505).
5034 (scroll_bar_width_for_theme): New variable.
5035 (update_theme_scrollbar_width): New function.
5036 (xg_get_default_scrollbar_width): Move code to
5037 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5038 (xg_initialize): Call update_theme_scrollbar_width.
5040 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5042 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5044 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5046 * frame.c (make_frame): Call other_buffer_safely instead of
5049 * window.c (temp_output_buffer_show): Call display_buffer with
5050 second argument Vtemp_buffer_show_specifiers and reset latter
5051 immediately after the call.
5052 (Vtemp_buffer_show_specifiers): New variable.
5053 (auto_window_vscroll_p, next_screen_context_lines)
5054 (Vscroll_preserve_screen_position): Remove leading asterisks from
5057 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5059 Fix minor problems found by GCC 4.6.0 static checking.
5060 * buffer.c (Qclone_number): Remove for now, as it's unused.
5061 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5062 (record_buffer): Remove unused local.
5063 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5064 (set_frame_buffer_list): Remove; unused.
5065 * frame.h (other_visible_frames): Remove decl.
5066 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5067 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5068 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5070 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5071 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5072 Define only if HAVE_GPM.
5073 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5074 (update_hints_inhibit): Remove; never set. All uses removed.
5075 * widgetprv.h (emacsFrameClassRec): Remove decl.
5076 * window.c (delete_deletable_window): Now returns void, since it
5077 wasn't returning anything.
5078 (compare_window_configurations): Remove unused locals.
5079 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5080 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5081 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5082 the same widths as pointers. This follows up on the 2011-05-06 patch.
5083 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5084 * xterm.h: Likewise.
5085 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5087 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5089 * makefile.w32-in: Update dependencies.
5090 (LISP_H): Add lib/intprops.h.
5092 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5094 * image.c (gif_load): Add animation frame delay to the metadata.
5095 (syms_of_image): Use DEFSYM. New symbol `delay'.
5097 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5099 * window.c (delete_deletable_window): Re-add.
5100 (Fset_window_configuration): Rewrite to handle dead buffers and
5101 consequently deletable windows.
5102 (window_tree, Fwindow_tree): Remove. Supply functionality in
5104 (compare_window_configurations): Simplify code.
5106 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5108 * image.c (imagemagick_load_image): Fix type mismatch.
5109 (Fimagemagick_types): Likewise.
5111 * window.h (replace_buffer_in_windows): Declare.
5113 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5115 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5116 Qclone_number. Remove external declaration of Qdelete_window.
5117 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5119 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5120 Run Qbuffer_list_update_hook if allowed.
5121 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5122 buffer list implementation.
5123 (other_buffer_safely): New function.
5124 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5125 calls to replace_buffer_in_windows and
5126 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5128 (record_buffer): Inhibit quitting and rewrite using quittable
5129 functions. Run Qbuffer_list_update_hook if allowed.
5130 (Frecord_buffer, Funrecord_buffer): New functions.
5131 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5132 Move switch-to-buffer to window.el.
5133 (bury-buffer): Move to window.el.
5134 (Vbuffer_list_update_hook): New variable.
5136 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5139 * window.h (resize_frame_windows): Move up in code.
5140 (Fwindow_frame): Remove EXFUN.
5141 (replace_buffer_in_all_windows): Remove prototype.
5142 (replace_buffer_in_windows_safely): Add prototype.
5144 * window.c: Declare Qdelete_window static again. Move down
5145 declaration of select_count.
5146 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5147 (Fother_window): Move to window.el.
5148 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5149 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5150 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5152 (replace_buffer_in_windows): Implement by calling
5153 Qreplace_buffer_in_windows.
5154 (replace_buffer_in_all_windows): Remove with some functionality
5155 moved into replace_buffer_in_windows_safely.
5156 (replace_buffer_in_windows_safely): New function.
5157 (select_window_norecord, select_frame_norecord): Move in front
5158 of run_window_configuration_change_hook. Remove now obsolete
5160 (Fset_window_buffer): Rewrite doc-string.
5161 Call Qrecord_window_buffer.
5162 (keys_of_window): Move binding for other-window to window.el.
5164 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5166 * dispextern.h (struct image): Replace data member, whose int_val
5167 and ptr_val fields were not used by anything, with a single
5170 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5171 (gif_clear_image, gif_load, imagemagick_load_image)
5172 (gs_clear_image, gs_load): Callers changed.
5174 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5176 * buffer.h: Include <time.h>, for time_t.
5177 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5179 Fix minor problems found by static checking.
5181 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5183 Make identifiers static if they are not used in other modules.
5184 * data.c (Qcompiled_function, Qframe, Qvector):
5185 * image.c (QimageMagick, Qsvg):
5186 * minibuf.c (Qmetadata):
5187 * window.c (resize_window_check, resize_root_window): Now static.
5188 * window.h (resize_window_check, resize_root_window): Remove decls.
5190 * window.c (window_deletion_count, delete_deletable_window):
5192 (window_body_lines): Now static.
5193 (Fdelete_other_windows_internal): Mark vars as initialized.
5194 Make sure 'resize_failed' is initialized.
5195 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5196 (resize_window_apply): Remove unused local.
5197 * window.h (delete_deletable_window): Remove decl.
5199 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5200 (imagemagick_load_image): Fix pointer signedness problem by changing
5201 last arg from unsigned char * to char *. All uses changed.
5202 Also, fix a local for similar reasons.
5203 Remove unused locals. Remove locals to avoid shadowing.
5204 (fn_rsvg_handle_free): Remove; unused.
5205 (svg_load, svg_load_image): Fix pointer signedness problem.
5206 (imagemagick_load_image): Don't use garbage pointer image_wand.
5208 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5210 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5212 * image.c (gif_load): Fix omitted cast error introduced by
5215 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5217 * window.h (resize_proportionally, orig_total_lines)
5218 (orig_top_line): Remove from window structure.
5219 (set_window_height, set_window_width, change_window_heights)
5220 (Fdelete_window): Remove prototypes.
5221 (resize_frame_windows): Remove duplicate declaration.
5223 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5225 * window.h (resize_frame_windows, resize_window_check)
5226 (delete_deletable_window, resize_root_window)
5227 (resize_frame_windows): Declare prototypes.
5229 * window.c (resize_window_apply): Make definition be "static" to
5230 match the prototype.
5232 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5234 * window.c: Remove declarations of Qwindow_size_fixed,
5235 window_min_size_1, window_min_size_2, window_min_size,
5236 size_window, window_fixed_size_p, enlarge_window, delete_window.
5237 Remove static from declaration of Qdelete_window, it's
5238 temporarily needed by Fbury_buffer.
5239 (replace_window): Don't assign orig_top_line and
5241 (Fdelete_window, delete_window): Remove. Window deletion is
5242 handled by window.el.
5243 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5244 Replace Fdelete_window calls with calls to Qdelete_window.
5245 (Fdelete_other_windows): Remove. Deleting other windows is
5246 handled by window.el.
5247 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5248 handled in window.el.
5249 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5250 Window minimum sizes are handled in window.el.
5251 (shrink_windows, size_window, set_window_height)
5252 (set_window_width, change_window_heights, window_height)
5253 (window_width, CURBEG, CURSIZE, enlarge_window)
5254 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5255 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5256 handled in window.el.
5257 (make_dummy_parent): Rename to make_parent_window and give it a
5258 second argument horflag.
5259 (make_window): Don't set resize_proportionally any more.
5260 (Fsplit_window): Remove. Windows are split in window.el.
5261 (save_restore_action, save_restore_orig_size)
5262 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5263 Resize mini windows in window.el.
5264 (grow_mini_window, shrink_mini_window): Implement by calling
5265 Qresize_root_window_vertically, resize_window_check and
5266 resize_window_apply.
5267 (saved_window, Fset_window_configuration, save_window_save):
5268 Do not handle orig_top_line, orig_total_lines, and
5269 resize_proportionally.
5270 (window_min_height, window_min_width): Move to window.el.
5271 (keys_of_window): Move bindings for delete-other-windows,
5272 split-window, delete-window and enlarge-window to window.el.
5274 * buffer.c: Temporarily extern Qdelete_window.
5275 (Fbury_buffer): Temporarily call Qdelete_window instead of
5276 Fdelete_window (Fbury_buffer will move to window.el soon).
5278 * frame.c (set_menu_bar_lines_1): Remove code handling
5279 orig_top_line and orig_total_lines.
5281 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5282 set_window_height but set heights directly.
5283 (change_frame_size_1): Use resize_frame_windows.
5285 * xdisp.c (init_xdisp): Don't use set_window_height but set
5288 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5289 Use resize_frame_windows instead of change_window_heights and run
5290 run_window_configuration_change_hook.
5292 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5293 instead of change_window_heights and run
5294 run_window_configuration_change_hook.
5296 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5298 * window.c (replace_window): Rename second argument REPLACEMENT to
5299 NEW. New third argument SETFLAG. Rewrite.
5300 (delete_window, make_dummy_parent): Call replace_window with
5302 (window_list_1): Move down in code.
5303 (run_window_configuration_change_hook): Move set_buffer part
5304 before select_frame_norecord part in order to unwind correctly.
5305 Rename count1 to count.
5306 (recombine_windows, delete_deletable_window, resize_root_window)
5307 (Fdelete_other_windows_internal)
5308 (Frun_window_configuration_change_hook, make_parent_window)
5309 (resize_window_check, resize_window_apply, Fresize_window_apply)
5310 (resize_frame_windows, Fsplit_window_internal)
5311 (Fdelete_window_internal, Fresize_mini_window_internal):
5313 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5315 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5317 * window.h (window): Add some new members to window structure -
5318 normal_lines, normal_cols, new_total, new_normal, clone_number,
5319 splits, nest, prev_buffers, next_buffers.
5320 (WINDOW_TOTAL_SIZE): Move here from window.c.
5321 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5323 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5325 (make_dummy_parent): Set new members of windows structure.
5326 (make_window): Move down in code. Handle new members of window
5328 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5329 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5330 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5331 (Fset_window_prev_buffers, Fwindow_next_buffers)
5332 (Fset_window_next_buffers, Fset_window_clone_number):
5334 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5335 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5337 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5338 Argument WINDOW can be now internal window too.
5339 (Fwindow_use_time): Move up in code.
5340 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5342 (Fset_window_configuration, saved_window)
5343 (Fcurrent_window_configuration, save_window_save): Handle new
5344 members of window structure.
5345 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5346 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5347 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5348 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5349 Qget_mru_window, Qresize_root_window,
5350 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5351 Qauto_buffer_name; staticpro them.
5353 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5355 * window.c (Fwindow_total_size, Fwindow_left_column)
5356 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5357 (Fwindow_list_1): New functions.
5358 (window_box_text_cols): Replace with window_body_cols.
5359 (Fwindow_width, Fscroll_left, Fscroll_right):
5360 Use window_body_cols instead of window_box_text_cols.
5361 (delete_window, Fset_window_configuration):
5362 Call delete_all_subwindows with window as argument.
5363 (delete_all_subwindows): Take a window as argument and not a
5365 (window_loop): Remove handling of GET_LRU_WINDOW and
5367 (Fget_lru_window, Fget_largest_window): Move to window.el.
5369 * window.h: Extern window_body_cols instead of
5370 window_box_text_cols. delete_all_subwindows now takes a
5371 Lisp_Object as argument.
5373 * indent.c (compute_motion, Fcompute_motion):
5374 Use window_body_cols instead of window_box_text_cols.
5376 * frame.c (delete_frame): Call delete_all_subwindows with root
5379 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5381 * fns.c (Fputhash): Document return value.
5383 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5385 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5387 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5389 Cons<->int and similar integer overflow fixes (Bug#8794).
5391 Check for overflow when converting integer to cons and back.
5392 * charset.c (Fdefine_charset_internal, Fdecode_char):
5393 Use cons_to_unsigned to catch overflow.
5394 (Fencode_char): Use INTEGER_TO_CONS.
5395 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5396 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5397 * data.c (long_to_cons, cons_to_long): Remove.
5398 (cons_to_unsigned, cons_to_signed): New functions.
5399 These signal an error for invalid or out-of-range values.
5400 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5401 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5402 * font.c (Ffont_variation_glyphs):
5403 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5404 * lisp.h: Include <intprops.h>.
5405 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5406 (cons_to_signed, cons_to_unsigned): New decls.
5407 (long_to_cons, cons_to_long): Remove decls.
5408 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5409 (Fprimitive_undo): Use CONS_TO_INTEGER.
5410 * xfns.c (Fx_window_property): Likewise.
5411 * xselect.c: Include <limits.h>.
5412 (x_own_selection, selection_data_to_lisp_data):
5413 Use INTEGER_TO_CONS.
5414 (x_handle_selection_request, x_handle_selection_clear)
5415 (x_get_foreign_selection, Fx_disown_selection_internal)
5416 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5417 (lisp_data_to_selection_data): Use cons_to_unsigned.
5418 (x_fill_property_data): Use cons_to_signed.
5419 Report values out of range.
5421 Check for buffer and string overflow more precisely.
5422 * buffer.h (BUF_BYTES_MAX): New macro.
5423 * lisp.h (STRING_BYTES_MAX): New macro.
5424 * alloc.c (Fmake_string):
5425 * character.c (string_escape_byte8):
5426 * coding.c (coding_alloc_by_realloc):
5427 * doprnt.c (doprnt):
5428 * editfns.c (Fformat):
5430 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5431 since they may not be the same number.
5432 * editfns.c (Finsert_char):
5433 * fileio.c (Finsert_file_contents):
5434 Likewise for BUF_BYTES_MAX.
5436 * image.c: Use ptrdiff_t, not int, for sizes.
5437 (slurp_file): Switch from int to ptrdiff_t.
5439 (slurp_file): Check that file size fits in both size_t (for
5440 malloc) and ptrdiff_t (for sanity and safety).
5442 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5443 if b->modtime has its maximal value.
5445 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5447 Don't assume time_t can fit into int.
5448 * buffer.h (struct buffer.modtime): Now time_t, not int.
5449 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5450 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5452 Minor fixes for signed vs unsigned integers.
5453 * character.h (MAYBE_UNIFY_CHAR):
5454 * charset.c (maybe_unify_char):
5455 * keyboard.c (read_char, reorder_modifiers):
5456 XINT -> XFASTINT, since the integer must be nonnegative.
5457 * ftfont.c (ftfont_spec_pattern):
5458 * keymap.c (access_keymap, silly_event_symbol_error):
5459 XUINT -> XFASTINT, since the integer must be nonnegative.
5460 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5461 since it makes no difference and we prefer signed.
5462 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5463 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5466 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5468 * window.h (Fwindow_frame): Declare.
5470 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5472 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5473 (SPARE_MEMORY): Always define.
5474 (LARGE_REQUEST): Remove.
5475 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5477 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5479 * lisp.h: Move EXFUNS for Fframe_root_window,
5480 Fframe_first_window and Fset_frame_selected_window to window.h.
5482 * window.h: Move EXFUNS for Fframe_root_window,
5483 Fframe_first_window and Fset_frame_selected_window here from
5486 * frame.c (Fwindow_frame, Fframe_first_window)
5487 (Fframe_root_window, Fframe_selected_window)
5488 (Fset_frame_selected_window): Move to window.c.
5489 (Factive_minibuffer_window): Move to minibuf.c.
5490 (Fother_visible_frames_p): New function.
5492 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5494 * window.c (decode_window, decode_any_window): Move up in code.
5495 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5496 (inhibit_frame_unsplittable): Remove unused variable.
5497 (Fwindow_buffer): Move up and rewrite doc-string.
5498 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5499 (Fwindow_prev): New functions.
5500 (Fwindow_frame): Move here from frame.c. Accept any window as
5502 (Fframe_root_window, Fframe_first_window)
5503 (Fframe_selected_window): Move here from frame.c. Accept frame
5504 or arbitrary window as argument. Update doc-strings.
5505 (Fminibuffer_window): Move up in code.
5506 (Fwindow_minibuffer_p): Move up in code and simplify.
5507 (Fset_frame_selected_window): Move here from frame.c.
5509 (Fselected_window, select_window, Fselect_window): Move up in
5510 code. Minor doc-string fixes.
5512 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5514 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5515 Do not assume that spare memory exists; that assumption is valid
5516 only if SYSTEM_MALLOC.
5517 (LARGE_REQUEST): New macro, so that the issue of large requests
5518 is separated from the issue of spare memory.
5520 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5522 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5525 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5527 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5530 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5532 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5534 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5536 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5537 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5539 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5541 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5543 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5545 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5546 (x_clipboard_manager_save): Add return value.
5547 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5549 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5550 Obey Vx_select_enable_clipboard_manager. Catch errors in
5551 x_clipboard_manager_save (Bug#8779).
5552 (Vx_select_enable_clipboard_manager): New variable.
5553 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5555 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5557 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5559 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5561 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5562 in the current matrix if keep_current_p is non-zero.
5564 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5566 * bidi.c (bidi_level_of_next_char): Fix last change.
5568 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5570 Support bidi reordering of text covered by display properties.
5572 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5573 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5574 (bidi_cache_search, bidi_cache_iterator_state)
5575 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5576 (bidi_level_of_next_char, bidi_move_to_visually_next):
5577 Support character positions inside a run of characters covered by a
5579 (bidi_paragraph_init, bidi_resolve_explicit_1)
5580 (bidi_level_of_next_char): Call bidi_fetch_char and
5581 bidi_fetch_char_advance instead of FETCH_CHAR and
5583 (bidi_init_it): Initialize new members.
5584 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5586 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5587 instead of using explicit *_CHAR codes.
5588 (bidi_resolve_explicit, bidi_resolve_weak):
5589 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5590 bidirectional text is supported only in multibyte buffers.
5591 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5592 it to initialize the frame_window_p member of struct bidi_it.
5593 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5594 (bidi_resolve_explicit, bidi_resolve_weak)
5595 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5596 bidi_it->nchars is non-positive.
5597 (bidi_level_of_next_char): Don't try to lookup the cache for the
5598 next/previous character if nothing is cached there yet, or if we
5599 were just reseat()'ed to a new position.
5601 * xdisp.c (set_cursor_from_row): Set start and stop points
5602 according to the row's direction when priming the loop that looks
5603 for the glyph on which to display cursor.
5604 (single_display_spec_intangible_p): Function deleted.
5605 (display_prop_intangible_p): Reimplement to call
5606 handle_display_spec instead of single_display_spec_intangible_p.
5607 Accept 3 additional arguments needed by handle_display_spec.
5608 This fixes incorrect cursor motion across display property with complex
5609 values: lists, `(when COND...)' forms, etc.
5610 (single_display_spec_string_p): Support property values that are
5611 lists with the argument STRING its top-level element.
5612 (display_prop_string_p): Fix the condition for processing a
5613 property that is a list to be consistent with handle_display_spec.
5614 (handle_display_spec): New function, refactored from the
5615 last portion of handle_display_prop.
5616 (compute_display_string_pos): Accept additional argument
5617 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5618 value of a `display' property is a "replacing spec".
5619 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5620 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5621 the display property, but just return a value indicating whether
5622 the display property will replace the characters it covers.
5623 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5624 frame_window_p members of struct bidi_it.
5625 (compute_display_string_pos, compute_display_string_end):
5627 (push_it): Accept second argument POSITION, where pop_it should
5628 jump to continue iteration.
5629 (reseat_1): Initialize bidi_it.disp_pos.
5631 * keyboard.c (adjust_point_for_property): Adjust the call to
5632 display_prop_intangible_p to its new signature.
5634 * dispextern.h (struct bidi_it): New member frame_window_p.
5635 (bidi_init_it): Update prototypes.
5636 (display_prop_intangible_p): Update prototype.
5637 (compute_display_string_pos, compute_display_string_end):
5639 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5642 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5644 Malloc failure behavior now depends on size of allocation.
5645 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5646 * lisp.h: Change signatures accordingly.
5647 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5648 All callers changed. (Bug#8762)
5650 * gnutls.c: Use Emacs's memory allocators.
5651 Without this change, the gnutls library would invoke malloc etc.
5652 directly, which causes problems on non-SYNC_INPUT hosts, and which
5653 runs afoul of improving memory_full behavior. (Bug#8761)
5654 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5655 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5656 xfree instead of the default malloc, realloc, free.
5657 (Fgnutls_boot): No need to check for memory allocation failure,
5658 since xmalloc does that for us.
5660 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5661 * category.c (hash_get_category_set):
5662 * ccl.c (ccl_driver):
5663 * charset.c (Fdefine_charset_internal):
5664 * charset.h (struct charset.hash_index):
5665 * composite.c (get_composition_id, gstring_lookup_cache)
5666 (composition_gstring_put_cache):
5667 * composite.h (struct composition.hash_index):
5668 * dispextern.h (struct image.hash):
5669 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5670 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5671 (hashfn_equal, hashfn_user_defined, make_hash_table)
5672 (maybe_resize_hash_table, hash_lookup, hash_put)
5673 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5674 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5675 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5676 * image.c (make_image, search_image_cache, lookup_image)
5677 (xpm_put_color_table_h):
5678 * lisp.h (struct Lisp_Hash_Table):
5679 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5680 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5681 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5682 * alloc.c (allocate_vectorlike):
5683 Check for overflow in vector size calculations.
5684 * ccl.c (ccl_driver):
5685 Check for overflow when converting EMACS_INT to int.
5686 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5687 need to be updated by these changes.
5688 * fns.c (make_hash_table, maybe_resize_hash_table):
5689 Check for integer overflow with large hash tables.
5690 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5691 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5692 (SXHASH_REDUCE): New macro.
5693 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5694 Use it instead of discarding useful hash info with large hash values.
5695 (sxhash_float): New function.
5696 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5697 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5698 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5699 Rewrite to use FIXNUM_BITS, as this simplifies things.
5700 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5701 Adjust signatures to match updated version of code.
5702 (consing_since_gc): Now EMACS_INT, since a single hash table can
5703 use more than INT_MAX bytes.
5705 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5707 Make it possible to build with GCC-4.6+ -O2 -flto.
5709 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5711 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5713 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5714 Call minibuffer-inactive-mode.
5716 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5718 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5719 Update dependencies.
5721 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5723 * data.c (init_data): Remove code for UTS, this system is not
5726 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5728 Don't force ./temacs to start in terminal mode.
5730 * frame.c (make_initial_frame): Initialize faces in all cases, not
5731 only when CANNOT_DUMP is defined.
5732 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5734 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5736 * dispnew.c (add_window_display_history): Use const for the string
5737 pointer. Remove declaration, not needed.
5739 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5741 Use 'inline', not 'INLINE'.
5742 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5743 * alloc.c, fontset.c (INLINE): Remove.
5744 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5745 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5746 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5747 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5748 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5750 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5752 Make it possible to run ./temacs.
5754 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5755 syms_of_callproc does the same thing. Remove test for
5756 "initialized", do it in the caller.
5757 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5759 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5761 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5762 (read_minibuf): Use get_minibuffer.
5763 (syms_of_minibuf): Use DEFSYM.
5764 (Qmetadata): New var.
5765 * data.c (Qbuffer): Don't make it static.
5766 (syms_of_data): Use DEFSYM.
5768 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5770 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5771 (CCL_CODE_MIN): New macro.
5773 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5775 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5777 * eval.c (Qdebug): Now static.
5778 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5779 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5780 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5782 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5784 * image.c: Various fixes to ImageMagick code comments.
5785 (Fimagemagick_types): Doc fix.
5787 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5789 Minor fixes prompted by GCC 4.6.0 warnings.
5791 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5793 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5794 (x_clipboard_manager_save_all): Move extern decl to ...
5795 * xterm.h: ... here, so that it can be checked for consistency.
5797 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5799 * xselect.c (x_clipboard_manager_save_frame)
5800 (x_clipboard_manager_save_all): New functions.
5801 (Fx_clipboard_manager_save): Lisp function deleted.
5803 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5804 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5806 * xterm.h: Update prototype.
5808 2011-05-28 William Xu <william.xwl@gmail.com>
5810 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5813 2011-05-28 Jim Meyering <meyering@redhat.com>
5815 Avoid a sign-extension bug in crypto_hash_function.
5816 * fns.c (to_uchar): Define.
5817 (crypto_hash_function): Use it to convert some newly-signed
5818 variables to unsigned, to avoid sign-extension bugs. For example,
5819 without this change, (md5 "truc") would evaluate to
5820 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5821 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5822 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5824 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5826 Integer overflow fixes.
5828 * dbusbind.c: Serial number integer overflow fixes.
5829 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5830 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5831 to hold a serial number that is too large for a fixnum.
5832 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5833 Check for serial numbers out of range. Decode any serial number
5834 that was so large that it became a float. (Bug#8722)
5836 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5838 Use XFASTINT rather than XUINT when numbers are nonnegative.
5839 (xd_append_arg, Fdbus_method_return_internal):
5840 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5841 arguments, check that Lisp number is nonnegative, rather than
5842 silently wrapping negative numbers around. (Bug#8722)
5843 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5846 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5848 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5850 ccl: Add integer overflow checks.
5851 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5852 (IN_INT_RANGE): New macros.
5853 (ccl_driver): Use them to check for integer overflow when
5854 decoding a CCL program. Many of the new checks are whether XINT (x)
5855 fits in int; it doesn't always, on 64-bit hosts. The new version
5856 doesn't catch all possible integer overflows, but it's an
5857 improvement. (Bug#8719)
5859 * alloc.c (make_event_array): Use XINT, not XUINT.
5860 There's no need for unsigned here.
5862 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5863 This follows up to the 2011-05-06 change that substituted uintptr_t
5864 for EMACS_INT. This case wasn't caught back then.
5866 Rework Fformat to avoid integer overflow issues.
5867 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5868 now (part of C89). Include <verify.h>.
5869 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5870 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5871 (Fformat): Avoid the prepass trying to compute sizes; it was only
5872 approximate and thus did not catch overflow reliably. Instead, walk
5873 through the format just once, formatting and computing sizes as we go,
5874 checking for integer overflow at every step, and allocating a larger
5875 buffer as needed. Keep track separately whether the format is
5876 multibyte. Keep only the most-recently calculated precision, rather
5877 than them all. Record whether each argument has been converted to
5878 string. Use EMACS_INT, not int, for byte and char and arg counts.
5879 Support field widths and precisions larger than INT_MAX. Avoid
5880 sprintf's undefined behavior with conversion specifications such as %#d
5881 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5882 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5883 formatting out-of-range floating point numbers with int
5886 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5888 * data.c: Avoid integer truncation in expressions involving floats.
5889 * data.c: Include <intprops.h>.
5890 (arith_driver): When there's an integer overflow in an expression
5891 involving floating point, convert the integers to floating point
5892 so that the resulting value does not suffer from catastrophic
5893 integer truncation. For example, on a 64-bit host (* 4
5894 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5895 Do not rely on undefined behavior after integer overflow.
5897 merge count_size_as_multibyte, parse_str_to_multibyte
5898 * character.c, character.h (count_size_as_multibyte):
5899 Rename from parse_str_to_multibyte; all uses changed.
5900 Check for integer overflow.
5901 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5902 since it's now a duplicate of the other. This is more of
5903 a character than a buffer op, so better that it's in character.c.
5904 * fns.c, print.c: Adjust to above changes.
5906 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5908 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5910 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5912 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5913 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5914 (x_clipboard_manager_save): Now static.
5915 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5917 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5918 (crypto_hash_function): Now static.
5919 Fix pointer signedness problems. Avoid unnecessary initializations.
5921 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5923 * termhooks.h (Vselection_alist): Make it terminal-local.
5925 * terminal.c (create_terminal): Initialize it.
5927 * xselect.c: Support for clipboard managers.
5928 (Vselection_alist): Move to termhooks.h as terminal-local var.
5929 (LOCAL_SELECTION): New macro.
5930 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5931 (symbol_to_x_atom): Remove gratuitous arg.
5932 (x_handle_selection_request, lisp_data_to_selection_data)
5933 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5934 (x_own_selection, x_get_local_selection, x_convert_selection):
5935 New arg, specifying work frame. Use terminal-local Vselection_alist.
5936 (some_frame_on_display): Delete unused function.
5937 (Fx_own_selection_internal, Fx_get_selection_internal)
5938 (Fx_disown_selection_internal, Fx_selection_owner_p)
5939 (Fx_selection_exists_p): New optional frame arg.
5940 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5941 (x_handle_selection_clear): Don't treat other terminals with the
5942 same keyboard specially. Use the terminal-local Vselection_alist.
5943 (x_clear_frame_selections): Use Frun_hook_with_args.
5945 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5947 * xterm.h: Add support for those atoms.
5949 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5951 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5952 (converted_selections, conversion_fail_tag): New global variables.
5953 (x_selection_request_lisp_error): Free the above.
5954 (x_get_local_selection): Remove unnecessary code.
5955 (x_reply_selection_request): Args changed; handle arbitrary array
5956 of converted selections stored in converted_selections.
5957 Separate the XChangeProperty and SelectionNotify steps.
5958 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5959 (x_convert_selection): New function.
5960 (x_handle_selection_event): Simplify.
5961 (x_get_foreign_selection): Don't ignore incoming requests while
5962 waiting for an answer; this will fail when we implement
5963 SAVE_TARGETS, and seems unnecessary anyway.
5964 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5965 (Vx_sent_selection_functions): Doc fix.
5967 2011-05-26 Leo Liu <sdl.web@gmail.com>
5969 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5971 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5973 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5975 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5976 for fringe update if it has periodic bitmap.
5977 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5978 and fringe_bitmap_periodic_p.
5980 * fringe.c (get_fringe_bitmap_data): New function.
5981 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5982 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5983 row. Mark glyph row for fringe update if periodicity changed.
5985 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5986 for fringe update unless it has periodic bitmap.
5988 2011-05-25 Kenichi Handa <handa@m17n.org>
5990 * xdisp.c (get_next_display_element): Set correct it->face_id for
5991 a static composition.
5993 2011-05-24 Leo Liu <sdl.web@gmail.com>
5996 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5998 * fns.c (crypto_hash_function, Fsha1): New function.
5999 (Fmd5): Use crypto_hash_function.
6000 (syms_of_fns): Add Ssha1.
6002 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6004 * gnutls.c: Remove unused macros.
6005 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6006 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6007 Remove macros that are defined and never used.
6008 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6010 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6012 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6013 (Fx_get_selection_internal): Minor cleanup.
6014 (Fx_own_selection_internal): Rename arguments for consistency with
6017 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6019 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6021 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6023 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6025 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6027 * dispnew.c (scrolling_window): Don't exclude the case that the
6028 last enabled row in the desired matrix touches the bottom boundary.
6030 2011-05-21 Glenn Morris <rgm@gnu.org>
6032 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6033 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6034 and add some more files.
6036 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6038 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6039 report_file_error introduced by the change from 2011-05-07.
6041 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6043 * systime.h (Time): Define only if emacs is defined.
6044 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6045 where the include path doesn't have X11/X.h by default. See
6046 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6048 2011-05-20 Kenichi Handa <handa@m17n.org>
6050 * composite.c (find_automatic_composition): Fix previous change.
6052 2011-05-20 Glenn Morris <rgm@gnu.org>
6054 * lisp.mk: New file, split from Makefile.in.
6055 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6056 (shortlisp): Remove.
6057 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6059 2011-05-19 Glenn Morris <rgm@gnu.org>
6061 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6062 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6063 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6064 (lisp): Set the order to that of loadup.el.
6065 (shortlisp): Make it a copy of $lisp.
6066 (SOME_MACHINE_LISP): Remove.
6067 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6068 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6070 2011-05-18 Kenichi Handa <handa@m17n.org>
6072 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6073 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6074 (find_automatic_composition): Mostly rewrite for efficiency.
6076 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6078 * makefile.w32-in: Update dependencies.
6080 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6082 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6083 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6085 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6087 Fix some integer overflow issues, such as string length overflow.
6089 * insdel.c (count_size_as_multibyte): Check for string overflow.
6091 * character.c (lisp_string_width): Check for string overflow.
6092 Use EMACS_INT, not int, for string indexes and lengths; in
6093 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6094 the resulting string length overflows an EMACS_INT; instead,
6095 report a string overflow if no precision given. When checking for
6096 precision exhaustion, use a check that cannot possibly have
6097 integer overflow. (Bug#8675)
6098 * character.h (lisp_string_width): Adjust to new signature.
6100 * alloc.c (string_overflow): New function.
6101 (Fmake_string): Use it. This doesn't change behavior, but saves
6102 a few bytes and will simplify future changes.
6103 * character.c (string_escape_byte8): Likewise.
6104 * lisp.h (string_overflow): New decl.
6106 Fixups, following up to the user-interface timestamp change.
6107 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6108 for UI timestamps, instead of unsigned long.
6109 * msdos.c (mouse_get_pos): Likewise.
6110 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6111 * w32gui.h (Time): Define by including "systime.h" rather than by
6112 declaring it ourselves. (Bug#8664)
6114 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6115 * image.c (clear_image_cache): Likewise.
6117 * term.c (term_mouse_position): Don't assume time_t wraparound.
6119 Be more systematic about user-interface timestamps.
6120 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6121 and sometimes 'EMACS_UINT', to represent these timestamps.
6122 This change causes it to use 'Time' uniformly, as that's what X uses.
6123 This makes the code easier to follow, and makes it easier to catch
6124 integer overflow bugs such as Bug#8664.
6125 * frame.c (Fmouse_position, Fmouse_pixel_position):
6126 Use Time, not unsigned long, for user-interface timestamps.
6127 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6128 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6129 * keyboard.h (last_event_timestamp): Likewise.
6130 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6131 * menu.h (xmenu_show): Likewise.
6132 * term.c (term_mouse_position): Likewise.
6133 * termhooks.h (struct input_event.timestamp): Likewise.
6134 (struct terminal.mouse_position_hook): Likewise.
6135 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6136 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6137 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6138 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6140 * menu.h, termhooks.h: Include "systime.h", for Time.
6142 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6143 Don't assume that the difference between two unsigned long values
6144 can fit into an integer. At this point, we know button_down_time
6145 <= event->timestamp, so the difference must be nonnegative, so
6146 there's no need to cast the result if double-click-time is
6147 nonnegative, as it should be; check that it's nonnegative, just in
6148 case. This bug is triggered when events are more than 2**31 ms
6149 apart (about 25 days). (Bug#8664)
6151 * xselect.c (last_event_timestamp): Remove duplicate decl.
6152 (x_own_selection): Remove needless cast to unsigned long.
6154 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6155 that always fit in int. Use a sentinel instead of a counter, to
6156 avoid a temp and to allay GCC's concerns about possible int overflow.
6157 * frame.h (struct frame): Use int for menu_bar_items_used
6158 instead of EMACS_INT, since it always fits in int.
6160 * menu.c (grow_menu_items): Check for int overflow.
6162 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6164 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6165 Before, the code was not consistent. These values cannot exceed
6166 2**31 - 1 so there's no need to make them unsigned.
6167 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6168 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6169 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6171 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6173 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6174 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6175 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6176 presumably because the widths might not match.
6178 * window.c (size_window): Avoid needless test at loop start.
6180 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6182 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6184 2011-05-12 Drew Adams <drew.adams@oracle.com>
6186 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6188 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6190 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6191 `width' to `bar_area_x' and `bar_area_width', respectively.
6192 (x_scroll_run): Take account of fringe background extension.
6194 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6195 Rename local vars `left' and `width' to `bar_area_x' and
6196 `bar_area_width', respectively.
6197 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6198 background extension.
6200 2011-05-10 Jim Meyering <meyering@redhat.com>
6202 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6204 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6206 * image.c (Finit_image_library): Return t for built-in image types,
6207 like pbm and xbm. (Bug#8640)
6209 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6211 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6213 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6215 * w32console.c (Fset_screen_color): Doc fix.
6216 (Fget_screen_color): New function.
6217 (syms_of_ntterm): Defsubr it.
6219 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6220 unlink the temporary file if Fcall_process didn't create it in the
6222 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6223 child process will be redirected to a file specified with `:file'.
6224 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6225 cue to call_process_cleanup not to close that handle.
6227 2011-05-07 Ben Key <bkey76@gmail.com>
6229 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6230 one of two shell specific rules, either bootstrap-temacs-CMD or
6231 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6232 to the previous implementation of the bootstrap-temacs rule.
6233 The bootstrap-temacs-CMD rule is similar to the previous
6234 implementation of the bootstrap-temacs rule except that it
6235 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6238 These changes, along with some changes to nt/configure.bat,
6239 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6240 earlier fix to add support for --cflags and --ldflags options
6241 that include quotes so that it works whether make uses cmd or
6244 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6246 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6247 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6249 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6250 a string. Handle both cases.
6251 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6252 (Fdbus_register_method): Use Qinvalid_function.
6254 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6256 * makefile.w32-in: Update dependencies.
6257 (LISP_H): Add inttypes.h and stdin.h.
6258 (PROCESS_H): Add unistd.h.
6260 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6262 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6263 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6265 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6267 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6269 * term.c (vfatal): Remove stray call to va_end.
6270 It's not needed and the C Standard doesn't allow it here anyway.
6272 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6273 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6275 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6278 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6280 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6282 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6284 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6286 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6288 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6289 * charset.c (Fdefine_charset_internal): Don't initialize
6290 charset.code_space[15]. The value was garbage, on hosts with
6291 32-bit int (Bug#8600).
6293 * lread.c (read_integer): Be more consistent with string-to-number.
6294 Use string_to_number to do the actual conversion; this avoids
6295 rounding errors and fixes some other screwups. Without this fix,
6296 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6297 (digit_to_number): Move earlier, for benefit of read_integer.
6298 Return -1 if the digit is out of range for the base, -2 if it is
6299 not a digit in any supported base. (Bug#8602)
6301 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6303 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6304 to match comment at start of function. This also removes a
6305 GCC warning about overflow in a 32+64-bit port.
6307 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6309 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6310 Reported by Stefan Monnier in
6311 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6312 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6313 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6315 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6316 (EMACS_UINTPTR): Likewise, with uintptr_t.
6318 * lisp.h: Prefer 64-bit EMACS_INT if available.
6319 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6320 on 32-bit hosts that have 64-bit int, so that they can access
6322 However, temporarily disable this change unless the temporary
6323 symbol WIDE_EMACS_INT is defined.
6325 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6327 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6328 This removes an assumption that EMACS_INT and long are the same
6329 width as pointers. The assumption is true for Emacs porting targets
6330 now, but we want to make other targets possible.
6331 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6332 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6333 In the rest of the code, change types of integers that hold casted
6334 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6335 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6336 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6337 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6338 No need to cast type when ORing.
6339 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6340 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6341 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6342 assume EMACS_INT is the same width as char *.
6343 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6344 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6345 Remove no-longer-needed casts.
6346 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6347 (xg_tool_bar_help_callback, xg_make_tool_item):
6348 Use EMACS_INTPTR to hold an integer
6349 that will be cast to void *; this can avoid a GCC warning
6350 if EMACS_INT is not the same width as void *.
6351 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6352 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6353 (current_message_1, set_message_1):
6354 Use a local to convert to proper width without a cast.
6355 * xmenu.c (dialog_selection_callback): Likewise.
6357 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6358 Also, don't assume VALBITS / RAND_BITS is less than 5,
6359 and don't rely on undefined behavior when shifting a 1 left into
6361 * lisp.h (get_random): Change signature to match.
6363 * lread.c (hash_string): Use size_t, not int, for hash computation.
6364 Normally we prefer signed values; but hashing is special, because
6365 it's better to use unsigned division on hash table sizes so that
6366 the remainder is nonnegative. Also, size_t is the natural width
6367 for hashing into memory. The previous code used 'int', which doesn't
6368 retain enough info to hash well into very large tables.
6369 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6371 * dbusbind.c: Don't possibly lose pointer info when converting.
6372 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6373 Use XPNTR rather than XHASH, so that the high-order bits of
6374 the pointer aren't lost when converting through void *.
6376 * eval.c (Fautoload): Don't double-shift a pointer.
6378 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6380 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6382 * gnutls.c (DEF_GNUTLS_FN):
6383 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6385 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6387 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6390 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6392 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6393 New version that can reserve upto 2GB of heap space.
6395 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6397 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6399 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6401 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6402 `gnutls_certificate_set_x509_key_file'.
6404 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6406 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6407 Update dependencies.
6409 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6411 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6412 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6413 Remove unused parameter `fildes'.
6414 * process.c (read_process_output, send_process): Don't pass it.
6416 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6418 Fix previous change: the library cache is defined in w32.c.
6419 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6420 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6422 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6424 Implement dynamic loading of GnuTLS on Windows.
6426 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6427 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6428 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6431 * gnutls.c (Qgnutls_dll): Define.
6432 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6433 (gnutls_*): Declare function pointers.
6434 (init_gnutls_functions): New function to initialize function pointers.
6435 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6436 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6438 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6439 (emacs_gnutls_write, emacs_gnutls_read)
6440 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6441 (Fgnutls_available_p): New function.
6442 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6443 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6444 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6446 * image.c: Include w32.h.
6447 (Vimage_type_cache): Delete.
6448 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6449 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6450 (w32_delayed_load): Move to w32.c.
6452 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6454 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6455 (w32_delayed_load): Move from image.c. When loading a library, record
6456 its filename in the :loaded-from property of the library id.
6457 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6458 Initialize and staticpro them.
6459 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6461 * process.c: Include lisp.h before w32.h, not after.
6462 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6463 instead of gnutls_record_check_pending.
6465 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6467 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6469 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6470 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6473 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6475 * xterm.c (x_set_frame_alpha): Do not set property on anything
6476 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6478 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6480 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6482 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6484 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6485 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6486 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6487 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6488 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6489 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6490 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6491 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6492 (Qgnutls_bootprop_callbacks_verify): Make static.
6494 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6496 * callproc.c: Indentation fixup.
6498 * sysdep.c (wait_for_termination_1): Make static.
6499 (wait_for_termination, interruptible_wait_for_termination):
6500 Move after wait_for_termination_1.
6502 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6504 * sysdep.c (interruptible_wait_for_termination): New function
6505 which is like wait_for_termination, but allows keyboard
6508 * callproc.c (Fcall_process): Add (:file "file") as an option for
6510 (Fcall_process_region): Ditto.
6512 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6514 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6515 rather than `XVECTOR (FOO)->size'.
6517 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6518 inttypes.h, as a gnulib replacement is used if it not available in
6521 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6523 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6524 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6525 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6527 * coding.c (coding_alloc_by_realloc): Error out if destination
6528 will grow beyond MOST_POSITIVE_FIXNUM.
6529 (decode_coding_emacs_mule): Abort if there isn't enough place in
6530 charbuf for the composition carryover bytes. Reserve an extra
6531 space for up to 2 characters produced in a loop.
6532 (decode_coding_iso_2022): Abort if there isn't enough place in
6533 charbuf for the composition carryover bytes.
6535 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6537 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6538 aborting when %lld or %lll format is passed.
6539 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6540 %llo or %llx format is passed. (Bug#8545)
6542 * window.c (window_scroll_line_based): Use a marker instead of
6543 simple variables to record original value of point. (Bug#7952)
6545 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6546 produced by %s or %c overflows available buffer space. (Bug#8545)
6548 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6550 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6551 (SIZE_MAX): Move defn after all includes, as they might #define it.
6553 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6555 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6557 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6559 * keyboard.c (Qdelayed_warnings_hook): Define.
6560 (command_loop_1): Run `delayed-warnings-hook'
6561 if Vdelayed_warnings_list is non-nil.
6562 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6563 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6565 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6567 * doprnt.c (doprnt): Don't return value smaller than the buffer
6568 size if the message was truncated. (Bug#8545).
6570 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6572 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6573 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6575 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6577 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6579 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6581 * makefile.w32-in: Update dependencies.
6583 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6585 Improve `doprnt' and its usage. (Bug#8545)
6586 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6587 `format_end'. Remove support for %l as a conversion specifier.
6588 Don't use xrealloc. Improve diagnostics when the %l size modifier
6589 is used. Update the commentary.
6591 * eval.c (verror): Simplify calculation of size_t.
6593 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6596 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6598 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6601 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6603 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6604 This makes this file independent of the recent pseudovector change.
6606 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6608 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6610 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6611 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6612 Remove unused local.
6613 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6615 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6616 GCC 4.6.0 optimizes based on type-based alias analysis.
6617 For example, if b is of type struct buffer * and v of type struct
6618 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6619 != &v->size, and therefore "v->size = 1; b->size = 2; return
6620 v->size;" must therefore return 1. This assumption is incorrect
6621 for Emacs, since it type-puns struct Lisp_Vector * with many other
6622 types. To fix this problem, this patch adds a new type struct
6623 vectorlike_header that documents the constraints on layout of vectors
6624 and pseudovectors, and helps optimizing compilers not get fooled
6625 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6626 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6627 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6629 (XSETPVECTYPE): Rewrite in terms of new macro.
6630 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6631 This is a bit clearer, and further avoids the possibility of
6632 undesirable aliasing.
6633 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6634 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6635 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6636 since Lisp_Subr is a special case (no "next" field).
6637 (ASIZE): Now uses header.size rather than size.
6638 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6639 to avoid the hassle of writing XVECTOR (foo)->header.size.
6640 (struct vectorlike_header): New type.
6641 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6642 object, to help avoid aliasing.
6643 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6644 (SUBRP): Likewise, since Lisp_Subr is a special case.
6645 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6646 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6647 (struct Lisp_Hash_Table): Combine first two members into a single
6648 struct vectorlike_header member. All uses of "size" and "next" members
6649 changed to be "header.size" and "header.next".
6650 * buffer.h (struct buffer): Likewise.
6651 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6652 * frame.h (struct frame): Likewise.
6653 * process.h (struct Lisp_Process): Likewise.
6654 * termhooks.h (struct terminal): Likewise.
6655 * window.c (struct save_window_data, struct saved_window): Likewise.
6656 * window.h (struct window): Likewise.
6657 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6658 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6659 * buffer.c (init_buffer_once): Likewise.
6660 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6662 * process.c (Fformat_network_address): Use local var for size,
6665 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6667 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6668 * data.c (atof): Remove decl; no longer used or needed.
6669 (digit_to_number): Move to lread.c.
6670 (Fstring_to_number): Use new string_to_number function, to be
6671 consistent with how the Lisp reader treats infinities and NaNs.
6672 Do not assume that floating-point numbers represent EMACS_INT
6673 without losing information; this is not true on most 64-bit hosts.
6674 Avoid double-rounding errors, by insisting on integers when
6675 parsing non-base-10 numbers, as the documentation specifies.
6676 * lisp.h (string_to_number): New decl, replacing ...
6677 (isfloat_string): Remove.
6678 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6679 (read1): Do not accept +. and -. as integers; this
6680 appears to have been a coding error. Similarly, do not accept
6681 strings like +-1e0 as floating point numbers. Do not report
6682 overflow for integer overflows unless the base is not 10 which
6683 means we have no simple and reliable way to continue.
6684 Break out the floating-point parsing into a new
6685 function string_to_number, so that Fstring_to_number parses
6686 floating point numbers consistently with the Lisp reader.
6687 (digit_to_number): Move here from data.c. Make it static inline.
6688 (E_CHAR, EXP_INT): Remove, replacing with ...
6689 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6690 (string_to_number): New function, replacing isfloat_string.
6691 This function checks for valid syntax and produces the resulting
6692 Lisp float number too. Rework it so that string-to-number
6693 no longer mishandles examples like "1.0e+". Use strtoumax,
6694 so that overflow for non-base-10 numbers is reported only when
6695 there's no portable and simple way to convert to floating point.
6697 * textprop.c (set_text_properties_1): Rewrite for clarity,
6698 and to avoid GCC warning about integer overflow.
6700 * intervals.h (struct interval): Use EMACS_INT for members
6701 where EMACS_UINT might cause problems. See
6702 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6703 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6704 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6706 (offset_intervals): Tell GCC not to worry about length overflow
6707 when negating a negative length.
6709 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6710 (overrun_check_free): Likewise.
6712 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6713 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6716 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6717 (gnutls_make_error): Rename local to avoid shadowing.
6718 (gnutls_emacs_global_deinit): ifdef out; not used.
6719 (Fgnutls_boot): Use const for pointer to readonly storage.
6720 Comment out unused local. Fix pointer signedness problems.
6722 * lread.c (openp): Don't stuff size_t into an 'int'.
6723 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6724 about possible signed overflow.
6726 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6727 (GDK_KEY_g): Don't define if already defined.
6728 (xg_prepare_tooltip): Avoid pointer signedness problem.
6729 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6731 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6732 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6734 * xfns.c (Fx_window_property): Simplify a bit,
6735 to make a bit faster and to avoid GCC 4.6.0 warning.
6736 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6738 * fns.c (internal_equal): Don't assume size_t fits in int.
6740 * alloc.c (compact_small_strings): Tighten assertion a little.
6742 Replace pEd with more-general pI, and fix some printf arg casts.
6743 * lisp.h (pI): New macro, generalizing old pEd macro to other
6744 conversion specifiers. For example, use "...%"pI"d..." rather
6745 than "...%"pEd"...".
6746 (pEd): Remove. All uses replaced with similar uses of pI.
6747 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6748 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6749 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6750 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6751 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6752 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6753 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6755 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6756 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6757 * print.c (safe_debug_print, print_object): Likewise.
6758 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6760 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6761 avoiding the 0 flag, which is not portable.
6762 * process.c (Fmake_network_process): Use pI to avoid cast.
6763 * region-cache.c (pp_cache): Likewise.
6764 * xdisp.c (decode_mode_spec): Likewise.
6765 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6766 behavior on 64-bit hosts with printf arg.
6767 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6768 (x_stop_queuing_selection_requests): Likewise.
6769 (x_get_window_property): Don't truncate byte count to an 'int'
6772 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6773 here, since it parses constructs like leading '-' and spaces,
6774 which are not wanted; and it overflows with large numbers.
6775 Instead, simply match F[0-9]+, which is what is wanted anyway.
6777 * alloc.c: Remove unportable assumptions about struct layout.
6778 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6779 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6780 (allocate_vectorlike, make_pure_vector): Use the new macros,
6781 plus offsetof, to remove unportable assumptions about struct layout.
6782 These assumptions hold on all porting targets that I know of, but
6783 they are not guaranteed, they're easy to remove, and removing them
6784 makes further changes easier.
6786 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6787 This doesn't fix a bug but makes the code clearer.
6788 (string_overrun_cookie): Now const. Use initializers that
6789 don't formally overflow signed char, to avoid warnings.
6790 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6791 can cause Emacs to crash when string overrun checking is enabled.
6792 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6793 multiple of sizeof (EMACS_INT); it need not be, if
6794 alignof(EMACS_INT) < sizeof (EMACS_INT).
6795 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6797 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6799 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6801 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6803 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6804 supposed to be handshaking. (Bug#8556)
6805 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6807 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6809 * lisp.h (Qdebug): List symbol.
6810 * eval.c (Qdebug): Restore global linkage.
6811 * keyboard.c (debug-on-event): New variable.
6812 (handle_user_signal): Break into debugger when debug-on-event
6813 matches the current signal symbol.
6815 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6817 * alloc.c (check_sblock, check_string_bytes)
6818 (check_string_free_list): Convert to standard C.
6820 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6822 * w32.c (emacs_gnutls_push): Fix typo.
6824 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6826 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6827 "cast to pointer from integer of different size".
6829 Improve doprnt and its use in verror. (Bug#8545)
6830 * doprnt.c (doprnt): Document the set of format control sequences
6831 supported by the function. Use SAFE_ALLOCA instead of always
6834 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6835 is one byte too soon. Don't use xrealloc; instead xfree and
6838 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6840 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6843 * gnutls.c: Renamed global_initialized to
6844 gnutls_global_initialized. Added internals for the
6845 :verify-hostname-error, :verify-error, and :verify-flags
6846 parameters of `gnutls-boot' and documented those parameters in the
6847 docstring. Start callback support.
6848 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6849 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6850 on error. Return error code.
6851 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6852 (emacs_gnutls_read): Likewise.
6853 (Fgnutls_boot): Return handshake error code.
6854 (emacs_gnutls_handle_error): New function.
6855 (wsaerror_to_errno): Likewise.
6857 * w32.h (emacs_gnutls_pull): Add prototype.
6858 (emacs_gnutls_push): Likewise.
6860 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6861 (emacs_gnutls_push): Likewise.
6863 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6865 * process.c (wait_reading_process_output): Check if GnuTLS
6866 buffered some data internally if no FDs are set for TLS
6869 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6870 (LIBS): Link to USER_LIBS.
6871 ($(BLD)/gnutls.$(0)): New target.
6873 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6875 * xdisp.c (handle_single_display_spec): Rename the
6876 display_replaced_before_p argument into display_replaced_p, to
6877 make it consistent with the commentary. Fix typos in the
6880 * textprop.c (syms_of_textprop): Remove dead code.
6881 (copy_text_properties): Delete obsolete commentary about an
6882 interface that was deleted long ago. Fix typos in the description
6885 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6886 to changes in oldXMenu/XMenu.h from 2011-04-16.
6887 <menu_help_message, prev_menu_help_message>: Constify.
6888 (IT_menu_make_room): menu->help_text is now `const char **';
6891 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6892 to changes in oldXMenu/XMenu.h from 2011-04-16.
6893 (struct XMenu): Declare `help_text' `const char **'.
6895 * xfaces.c <Qunspecified>: Make extern again.
6897 * syntax.c: Include sys/types.h before including regex.h, as
6900 * doc.c (get_doc_string): Improve the format passed to `error'.
6902 * doprnt.c (doprnt): Improve commentary.
6904 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6906 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6909 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6910 changes in globals.h immediately force recompilation.
6911 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6912 $(CURDIR)/s/ms-w32.h.
6913 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6915 * character.c (Fchar_direction): Function deleted.
6916 (syms_of_character): Don't defsubr it.
6917 <char-direction-table>: Deleted.
6919 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6921 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6922 * doprnt.c: Include limits.h.
6923 (SIZE_MAX): New macro.
6924 (doprnt): Return a size_t value. 2nd arg is now size_t.
6925 Many local variables are now size_t instead of int or unsigned.
6926 Improve overflow protection. Support `l' modifier for integer
6927 conversions. Support %l conversion. Don't assume an EMACS_INT
6928 argument for integer conversions and for %c.
6930 * lisp.h (doprnt): Restore prototype.
6932 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6935 * Makefile.in (base_obj): Add back doprnt.o.
6937 * deps.mk (doprnt.o): Add back prerequisites.
6938 (callint.o): Depend on character.h.
6940 * eval.c (internal_lisp_condition_case): Include the handler
6941 representation in the error message.
6942 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6943 when breaking from the loop.
6945 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6947 * callint.c (Fcall_interactively): When displaying error message
6948 about invalid control letter, pass the character's codepoint, not
6949 a pointer to its multibyte form. Improve display of the character
6950 in octal and display also its hex code.
6952 * character.c (char_string): Use %x to display the (unsigned)
6953 codepoint of an invalid character, to avoid displaying a bogus
6956 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6957 `error', not SYMBOL_NAME itself.
6959 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6960 character arguments to `error'.
6962 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6963 to `error' in error message about FINAL_CHAR argument. Make sure
6964 FINAL_CHAR is a character, and use %c when it is passed as
6965 argument to `error'.
6967 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6969 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6971 * w32.c: Include <time.h>.
6972 (sys_localtime): New function.
6974 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6976 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6978 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6980 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6982 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6985 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6987 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6988 gl_state.e_property when gl_state.object is Qt.
6990 * insdel.c (make_gap_larger): Remove limitation of buffer size
6993 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6995 * xdisp.c (lookup_glyphless_char_display)
6996 (produce_glyphless_glyph): Handle cons cell entry in
6997 glyphless-char-display.
6998 (Vglyphless_char_display): Document it.
7000 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7001 glyphless-char-display.
7003 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7005 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7007 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7009 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7010 definition for no-X builds.
7012 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7014 Static checks with GCC 4.6.0 and non-default toolkits.
7016 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7018 * process.c (keyboard_bit_set): Define only if SIGIO.
7019 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7020 (send_process): Repair possible setjmp clobbering.
7022 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7024 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7026 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7028 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7029 Define only if needed.
7031 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7032 by pacifying GCC about it. Maybe it's time to retire it?
7033 * xfaces.c (USG, __TIMEVAL__): Likewise.
7035 * dispextern.h (struct redisplay_interface): Rename param
7037 * termhooks.h (struct terminal): Likewise.
7038 * xterm.c (xembed_send_message): Likewise.
7040 * insdel.c (make_gap_smaller): Define only if
7041 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7043 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7046 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7047 so that we aren't warned about unused symbols.
7049 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7051 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7053 * xfns.c (x_real_positions): Mark locals as initialized.
7055 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7057 * xterm.c: Fix problems found by static analysis with other toolkits.
7058 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7059 (x_dispatch_event): Declare static if USE_GTK, and
7060 define if USE_GTK || USE_X_TOOLKIT.
7061 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7062 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7063 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7064 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7066 * xmenu.c (menu_help_callback): Pointer type fixes.
7067 Use const pointers when pointing at readonly data. Avoid pointer
7069 (FALSE): Remove unused macro.
7070 (update_frame_menubar): Remove unused decl.
7072 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7074 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7075 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7076 (single_menu_item): Rename local to avoid shadowing.
7078 * keyboard.c (make_lispy_event): Remove unused local var.
7080 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7081 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7083 * bitmaps: Change bitmaps from unsigned char back to the X11
7084 compatible char. Avoid the old compiler warnings about
7085 out-of-range initializers by using, for example, '\xab' rather
7088 * xgselect.c (xgselect_initialize): Check vs interface
7089 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7091 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7093 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7094 to read-only memory.
7096 * fns.c (vector): Remove; this old hack is no longer needed.
7098 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7100 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7102 * xrdb.c (x_load_resources): Omit unused local.
7104 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7105 (x_window): Rename locals to avoid shadowing.
7106 (USG): Use the kludged USG macro, to pacify gcc.
7108 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7109 (x_term_init): Remove local to avoid shadowing.
7111 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7113 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7114 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7116 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7118 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7120 Fix regex.c, syntax.c and friends for buffers > 2GB.
7121 * syntax.h (struct gl_state_s): Declare character position members
7124 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7126 * textprop.c (verify_interval_modification, interval_of):
7127 Declare arguments EMACS_INT.
7129 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7132 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7134 * indent.c (Fvertical_motion): Local variable it_start is now
7137 * regex.c (re_match, re_match_2, re_match_2_internal)
7138 (bcmp_translate, regcomp, regexec, print_double_string)
7139 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7140 (re_compile_pattern, re_exec): Declare arguments and local
7141 variables `size_t' and `ssize_t' and return values `regoff_t', as
7143 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7144 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7145 <compile_stack_type>: `size' and `avail' are now `size_t'.
7147 * regex.h <regoff_t>: Use ssize_t, not int.
7148 (re_search, re_search_2, re_match, re_match_2): Arguments that
7149 specify buffer/string position and length are now ssize_t and
7150 size_t. Return type is regoff_t.
7152 2011-04-16 Ben Key <bkey76@gmail.com>
7154 * nsfont.m: Fixed bugs in ns_get_family and
7155 ns_descriptor_to_entity that were caused by using free to
7156 deallocate memory blocks that were allocated by xmalloc (via
7157 xstrdup). This caused Emacs to crash when compiled with
7158 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7159 --enable-checking=xmallocoverrun). xfree is now used to
7160 deallocate these memory blocks.
7162 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7164 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7166 emacs_write: Accept and return EMACS_INT for sizes.
7167 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7169 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7170 Accept and return EMACS_INT.
7171 (emacs_gnutls_write): Return the number of bytes written on
7173 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7174 (emacs_read, emacs_write): Remove check for negative size, as the
7175 Emacs source code has been audited now.
7176 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7177 (emacs_read, emacs_write): Use it.
7178 * process.c (send_process): Adjust to the new signatures of
7179 emacs_write and emacs_gnutls_write. Do not attempt to store
7180 a byte offset into an 'int'; it might overflow.
7181 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7183 * sound.c: Don't assume sizes fit in 'int'.
7184 (struct sound_device.period_size, alsa_period_size):
7185 Return EMACS_INT, not int.
7186 (struct sound_device.write, vox_write, alsa_write):
7187 Accept EMACS_INT, not int.
7188 (wav_play, au_play): Use EMACS_INT to store sizes and to
7189 record read return values.
7191 2011-04-15 Ben Key <bkey76@gmail.com>
7193 * keyboard.c (Qundefined): Don't declare static since it is used
7195 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7196 static since they are used in nsfont.m.
7198 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7200 * process.c (Qprocessp): Don't declare static.
7201 * lisp.h (Qprocessp): Declare again.
7203 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7205 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7207 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7209 Improve C-level modularity by making more things 'static'.
7211 Don't publish debugger-only interfaces to other modules.
7212 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7213 (verify_bytepos, count_markers): Move decls to the only modules
7215 * region-cache.h (pp_cache): Likewise.
7216 * window.h (check_all_windows): Likewise.
7217 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7219 * sysdep.c (croak): Now static, if
7220 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7221 * syssignal.h (croak): Declare only if not static.
7223 * alloc.c (refill_memory_reserve): Now static if
7224 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7225 * lisp.h (refill_memory_reserve): Declare only if not static.
7227 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7228 Define only if USE_LUCID.
7230 * xrdb.c (x_customization_string, x_rm_string): Now static.
7232 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7233 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7235 * xdisp.c (draw_row_with_mouse_face): Now static.
7236 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7238 * window.h (check_all_windows): Mark externally visible.
7240 * window.c (window_deletion_count): Now static.
7242 * undo.c: Make symbols static if they're not exported.
7243 (last_undo_buffer, last_boundary_position, pending_boundary):
7246 * textprop.c (interval_insert_behind_hooks): Now static.
7247 (interval_insert_in_front_hooks): Likewise.
7249 * term.c: Make symbols static if they're not exported.
7250 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7251 (max_frame_lines, tty_set_terminal_modes):
7252 (tty_reset_terminal_modes, tty_turn_off_highlight):
7253 (get_tty_terminal): Now static.
7254 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7255 * termhooks.h (term_mouse_moveto): Do not declare if
7257 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7258 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7260 * sysdep.c: Make symbols static if they're not exported.
7261 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7263 (sigprocmask_set, full_mask): Remove; unused.
7264 (wait_debugging): Mark as visible.
7265 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7266 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7268 * syntax.c (syntax_temp): Define only if !__GNUC__.
7270 * sound.c (current_sound_device, current_sound): Now static.
7272 * search.c (searchbufs, searchbuf_head): Now static.
7274 * scroll.c (scroll_cost): Remove; unused.
7275 * dispextern.h (scroll_cost): Remove decl.
7277 * region-cache.h (pp_cache): Mark as externally visible.
7279 * process.c: Make symbols static if they're not exported.
7280 (process_tick, update_tick, create_process, chan_process):
7281 (Vprocess_alist, proc_buffered_char, datagram_access):
7282 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7283 (deactivate_process): Mark defn as static, as well as decl.
7284 * lisp.h (create_process): Remove decl.
7285 * process.h (chan_process, Vprocess_alist): Remove decls.
7287 * print.c: Make symbols static if they're not exported.
7288 (print_depth, new_backquote_output, being_printed, print_buffer):
7289 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7290 (print_interval, print_number_index, initial_stderr_stream):
7292 * lisp.h (Fprinc): Remove decl.
7293 (debug_output_compilation_hack): Mark as externally visible.
7295 * sysdep.c (croak): Move decl from here to syssignal.h.
7296 * syssignal.h (croak): Put it here, so the API can be checked when
7297 'croak' is called from dissociate_if_controlling_tty.
7299 * minibuf.c: Make symbols static if they're not exported.
7300 (minibuf_save_list, choose_minibuf_frame): Now static.
7301 * lisp.h (choose_minibuf_frame): Remove decl.
7303 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7305 * lread.c: Make symbols static if they're not exported.
7306 (read_objects, initial_obarray, oblookup_last_bucket_number):
7308 (make_symbol): Remove; unused.
7309 * lisp.h (initial_obarray, make_symbol): Remove decls.
7311 * keyboard.c: Make symbols static if they're not exported.
7312 (single_kboard, recent_keys_index, total_keys, recent_keys):
7313 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7314 (this_single_command_key_start, echoing, last_auto_save):
7315 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7316 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7317 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7318 (Vlispy_mouse_stem, double_click_count):
7320 (force_auto_save_soon): Define only if SIGDANGER.
7321 (ignore_mouse_drag_p): Now static if
7322 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7323 (print_help): Remove; unused.
7324 (stop_character, last_timer_event): Mark as externally visible.
7325 * keyboard.h (ignore_mouse_drag_p): Declare only if
7326 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7327 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7328 * lisp.h (echoing): Remove decl.
7329 (force_auto_save_soon): Declare only if SIGDANGER.
7330 * xdisp.c (redisplay_window): Simplify code, to make it more
7331 obvious that ignore_mouse_drag_p is not accessed if !defined
7332 USE_GTK && !defined HAVE_NS.
7334 * intervals.c: Make symbols static if they're not exported.
7335 (merge_properties_sticky, merge_interval_right, delete_interval):
7337 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7339 * insdel.c: Make symbols static if they're not exported.
7340 However, leave prepare_to_modify_buffer alone. It's never
7341 called from outside this function, but that appears to be a bug.
7342 (combine_after_change_list, combine_after_change_buffer):
7343 (adjust_after_replace, signal_before_change): Now static.
7344 (adjust_after_replace_noundo): Remove; unused.
7345 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7346 (signal_before_change): Remove decls.
7348 * indent.c (val_compute_motion, val_vmotion): Now static.
7350 * image.c: Make symbols static if they're not exported.
7351 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7353 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7354 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7356 * fringe.c (standard_bitmaps): Now static.
7357 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7359 * frame.c: Make symbols static if they're not exported.
7360 (x_report_frame_params, make_terminal_frame): Now static.
7361 (get_frame_param): Now static, unless HAVE_NS.
7362 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7363 (x_get_resource_string): Remove; not used.
7364 * frame.h (make_terminal_frame, x_report_frame_params):
7365 (x_get_resource_string); Remove decls.
7366 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7367 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7369 * font.c, fontset.c: Make symbols static if they're not exported.
7370 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7371 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7372 * font.c (font_close_object): Now static.
7373 * font.h (font_close_object): Remove.
7374 * fontset.c (FONTSET_OBJLIST): Remove.
7375 (free_realized_fontset) #if-0 the body, which does nothing.
7376 (face_suitable_for_char_p): #if-0, as it's never called.
7377 * fontset.h (face_suitable_for_char_p): Remove decl.
7378 * xfaces.c (face_at_string_position):
7379 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7380 since 0 is always ASCII.
7382 * fns.c (weak_hash_tables): Now static.
7384 * fileio.c: Make symbols static if they're not exported.
7385 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7386 (Vwrite_region_annotation_buffers): Now static.
7388 * eval.c: Make symbols static if they're not exported.
7389 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7390 * lisp.h (backtrace_list): Remove decl.
7392 * emacs.c: Make symbols static if they're not exported.
7393 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7394 (fatal_error_code, fatal_error_signal_hook, standard_args):
7396 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7397 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7398 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7399 * lisp.h (fatal_error_signal_hook): Remove decl.
7400 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7402 * editfns.c: Move a (normally-unused) function to its only use.
7403 * editfns.c, lisp.h (get_operating_system_release): Remove.
7404 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7405 worth the hassle of breaking this out.
7407 * xterm.c: Make symbols static if they're not exported.
7408 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7409 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7410 (x_destroy_window, x_delete_display):
7412 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7413 (x_mouse_leave): Remove; unused.
7414 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7415 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7416 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7418 (x_mouse_leave): Declare only if WINDOWSNT.
7419 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7420 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7423 * ftxfont.c: Make symbols static if they're not exported.
7424 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7426 * font.h (ftxfont_driver): Likewise.
7428 * xfns.c: Make symbols static if they're not exported.
7429 (x_last_font_name, x_display_info_for_name):
7430 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7431 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7432 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7433 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7434 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7435 (last_show_tip_args): Now static.
7436 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7437 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7438 (x_screen_planes): Remove; unused.
7439 * dispextern.h (x_screen_planes): Remove decl.
7441 * dispnew.c: Make symbols static if they're not exported.
7442 * dispextern.h (redraw_garbaged_frames, scrolling):
7443 (increment_row_positions): Remove.
7444 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7445 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7447 (redraw_garbaged_frames): Remove; unused.
7449 * xfaces.c: Make symbols static if they're not exported.
7450 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7452 * xterm.h (defined_color): Remove decls.
7453 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7454 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7455 (menu_face_changed_default, defined_color, free_realized_face):
7456 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7457 (ascii_face_of_lisp_face): Remove; unused.
7459 * xdisp.c: Make symbols static if they're not exported.
7460 * dispextern.h (scratch_glyph_row, window_box_edges):
7461 (glyph_to_pixel_coords, set_cursor_from_row):
7462 (get_next_display_element, set_iterator_to_next):
7463 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7464 (show_mouse_face): Remove decls
7465 * frame.h (message_buf_print): Likewise.
7466 * lisp.h (pop_message, set_message, check_point_in_composition):
7468 * xterm.h (set_vertical_scroll_bar): Likewise.
7469 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7470 (message_buf_print, scratch_glyph_row, displayed_buffer):
7471 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7472 (get_next_display_element, show_mouse_face, window_box_edges):
7473 (frame_to_window_pixel_xy, check_point_in_composition):
7474 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7475 (glyph_to_pixel_coords): Remove; unused.
7477 * dired.c (file_name_completion): Now static.
7479 * dbusbind.c (xd_in_read_queued_messages): Now static.
7481 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7482 * data.c (circular_list_error): Remove.
7484 * commands.h (last_point_position, last_point_position_buffer):
7485 (last_point_position_window): Remove decls.
7486 * keyboard.c: Make these variables static.
7488 * coding.h (coding, code_convert_region, encode_coding_gap):
7490 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7491 (iso_code_class, detect_coding, code_convert_region): Now static.
7492 (encode_coding_gap): Remove; unused.
7494 * chartab.c (chartab_chars, chartab_bits): Now static.
7496 * charset.h (charset_iso_8859_1): Remove decl.
7497 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7500 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7501 * ccl.c (Vccl_program_table): Now static.
7502 (check_ccl_update): Remove; unused.
7504 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7505 * category.h: ... from here.
7506 * category.c (check_category_table, set_category_set): Now static.
7508 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7509 * lisp.h: Remove these decls.
7511 * buffer.c (buffer_count): Remove unused var.
7513 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7514 so that it's not optimized away.
7515 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7516 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7517 exported only to the debugger.
7519 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7520 * atimer.h (run_all_atimers): Remove; not exported.
7522 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7523 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7524 was inaccessible from Lisp.
7525 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7526 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7528 alloc.c: Import and export fewer symbols, and remove unused items.
7529 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7531 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7532 it's not optimized away by whole-program optimization.
7533 (message_enable_multibyte, free_misc): Remove.
7534 (catchlist, handlerlist, mark_backtrace):
7535 Declare only if BYTE_MARK_STACK.
7536 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7537 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7538 (message_enable_multibyte): Remove decl.
7539 (free_misc, interval_free_list, float_block, float_block_index):
7540 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7541 (cons_free_list, last_marked_index):
7543 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7544 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7545 (mark_backtrace): Define only if BYTE_MARK_STACK.
7546 * xdisp.c (message_enable_multibyte): Now static.
7548 Declare Lisp_Object Q* variables to be 'static' if not exported.
7549 This makes it easier for human readers (and static analyzers)
7550 to see whether these variables are used from other modules.
7551 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7552 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7553 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7554 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7555 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7556 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7557 * xmenu.c, xselect.c:
7558 Declare Q* vars static if they are not used in other modules.
7559 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7560 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7561 Remove decls of unexported vars.
7562 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7564 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7566 Make Emacs functions such as Fatom 'static' by default.
7567 This makes it easier for human readers (and static analyzers)
7568 to see whether these functions can be called from other modules.
7569 DEFUN now defines a static function. To make the function external
7570 so that it can be used in other C modules, use the new macro DEFUE.
7571 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7572 (Finit_image_library):
7573 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7574 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7575 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7576 Remove decls, since these functions are now static.
7577 (Funintern, Fget_internal_run_time): New decls, since these functions
7578 were already external.
7580 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7581 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7582 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7583 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7584 * keyboard.c, keymap.c, lread.c:
7585 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7586 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7587 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7588 Mark functions with DEFUE instead of DEFUN,
7589 if they are used in other modules.
7590 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7591 decls for now-static functions.
7592 * buffer.h (Fdelete_overlay): Remove decl.
7593 * callproc.c (Fgetenv_internal): Mark as internal.
7594 * composite.c (Fremove_list_of_text_properties): Remove decl.
7595 (Fcomposition_get_gstring): New forward static decl.
7596 * composite.h (Fcomposite_get_gstring): Remove decl.
7597 * dired.c (Ffile_attributes): New forward static decl.
7598 * doc.c (Fdocumntation_property): New forward static decl.
7599 * eval.c (Ffetch_bytecode): New forward static decl.
7600 (Funintern): Remove extern decl; now in .h file where it belongs.
7601 * fileio.c (Fmake_symbolic_link): New forward static decl.
7602 * image.c (Finit_image_library): New forward static decl.
7603 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7604 * intervals.h (Fprevious_property_change):
7605 (Fremove_list_of_text_properties): Remove decls.
7606 * keyboard.c (Fthis_command_keys): Remove decl.
7607 (Fcommand_execute): New forward static decl.
7608 * keymap.c (Flookup_key): New forward static decl.
7609 (Fcopy_keymap): Now static.
7610 * keymap.h (Flookup_key): Remove decl.
7611 * process.c (Fget_process): New forward static decl.
7612 (Fprocess_datagram_address): Mark as internal.
7613 * syntax.c (Fsyntax_table_p): New forward static decl.
7614 (skip_chars): Remove duplicate decl.
7615 * textprop.c (Fprevious_property_change): New forward static decl.
7616 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7618 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7619 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7621 * editfns.c (Fformat): Remove unreachable code.
7623 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7625 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7628 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7630 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7631 when at ZV. (Bug#8487)
7633 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7635 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7637 * keyboard.c (parse_tool_bar_item): Likewise.
7638 * sound.c (sound_cleanup, alsa_close): Likewise.
7639 * termcap.c (tgetent): Likewise.
7640 * xfns.c (x_default_font_parameter): Likewise.
7641 * xsettings.c (read_and_apply_settings): Likewise.
7643 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7644 (overrun_check_free): Protoize.
7646 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7648 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7649 since callers should never pass a negative size.
7650 Change the signature to match that of plain 'read' and 'write'; see
7651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7652 * lisp.h: Update prototypes of emacs_write and emacs_read.
7654 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7656 * xdisp.c (redisplay_window): Don't try to determine the character
7657 position of the scroll margin if the window start point w->startp
7658 is outside the buffer's accessible region. (Bug#8468)
7660 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7662 Fix write-region and its subroutines for buffers > 2GB.
7663 * fileio.c (a_write, e_write): Modify declaration of arguments and
7664 local variables to support buffers larger than 2GB.
7665 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7667 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7668 argument, local variables, and return value.
7670 * lisp.h: Update prototypes of emacs_write and emacs_read.
7672 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7674 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7676 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7678 Fix more problems found by GCC 4.6.0's static checks.
7680 * xdisp.c (vmessage): Use a better test for character truncation.
7682 * charset.c (load_charset_map): <, not <=, for optimization,
7683 and to avoid potential problems with integer overflow.
7684 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7685 * casetab.c (set_identity, shuffle): Likewise.
7686 * editfns.c (Fformat): Likewise.
7687 * syntax.c (skip_chars): Likewise.
7689 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7690 This also lets GCC 4.6.0 generate slightly better loop code.
7692 * callint.c (Fcall_interactively): <, not <=, for optimization.
7693 (Fcall_interactively): Count the number of arguments produced,
7694 not the number of arguments given. This is simpler and lets GCC
7695 4.6.0 generate slightly better code.
7697 * ftfont.c: Distingish more carefully between FcChar8 and char.
7698 The previous code passed unsigned char * to a functions like
7699 strlen and xstrcasecmp that expect char *, which does not
7700 conform to the C standard.
7701 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7702 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7703 char * when the C standard requires it.
7705 * keyboard.c (read_char): Remove unused var.
7707 * eval.c: Port to Windows vsnprintf (Bug#8435).
7709 (SIZE_MAX): Define if the headers do not.
7710 (verror): Do not give up if vsnprintf returns a negative count.
7711 Instead, grow the buffer. This ports to Windows vsnprintf, which
7712 does not conform to C99. Problem reported by Eli Zaretskii.
7713 Also, simplify the allocation scheme, by avoiding the need for
7714 calling realloc, and removing the ALLOCATED variable.
7716 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7718 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7719 But keep the doprint source code for now, as we might revamp it
7720 and use it again (Bug#8435).
7721 * lisp.h (doprnt): Remove.
7722 * Makefile.in (base_obj): Remove doprnt.o.
7723 * deps.mk (doprnt.o): Remove.
7725 error: Print 32- and 64-bit integers portably (Bug#8435).
7726 Without this change, on typical 64-bit hosts error ("...%d...", N)
7727 was used to print both 32- and 64-bit integers N, which relied on
7729 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7731 * lisp.h (error, verror): Mark as printf-like functions.
7732 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7733 Report overflow in size calculations when allocating printf buffer.
7734 Do not truncate output string at its first null byte.
7735 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7736 Truncate the output at a character boundary, since vsnprintf does not
7738 * charset.c (check_iso_charset_parameter): Convert internal
7739 character to string before calling 'error', since %c now has the
7741 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7742 overflow when computing char to be passed to 'error'. Do not
7743 pass Lisp_Object to 'error'; pass the integer instead.
7744 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7745 formatted with plain %d.
7747 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7749 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7751 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7753 * xterm.c (x_catch_errors): Remove duplicate declaration.
7755 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7757 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7759 2011-04-10 Jim Meyering <meyering@redhat.com>
7761 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7762 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7763 return ssize_t not "int", and use size_t as the buffer length.
7764 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7765 * gnutls.h: Update declarations.
7766 * process.c (read_process_output): Use ssize_t, to match.
7767 (send_process): Likewise.
7769 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7771 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7773 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7775 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7776 Use unsigned char, to match FcChar8 type definition.
7778 * xterm.c (handle_one_xevent):
7779 * xmenu.c (create_and_show_popup_menu):
7780 * xselect.c (x_decline_selection_request)
7781 (x_reply_selection_request): Avoid type-punned deref of X events.
7783 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7785 Fix some uses of `int' instead of EMACS_INT.
7786 * search.c (string_match_1, fast_string_match)
7787 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7788 (scan_buffer, find_next_newline_no_quit)
7789 (find_before_next_newline, search_command, Freplace_match)
7790 (Fmatch_data): Make some `int' variables be EMACS_INT.
7792 * xdisp.c (display_count_lines): 3rd argument and return value now
7793 EMACS_INT. All callers changed.
7794 (pint2hrstr): Last argument is now EMACS_INT.
7796 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7797 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7798 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7799 (decode_coding_utf_16, decode_coding_emacs_mule)
7800 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7801 (decode_coding_ccl, decode_coding_charset)
7802 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7803 (decode_coding_iso_2022, decode_coding_emacs_mule)
7804 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7805 <char_offset, last_offset>: Declare EMACS_INT.
7806 (encode_coding_utf_8, encode_coding_utf_16)
7807 (encode_coding_emacs_mule, encode_invocation_designation)
7808 (encode_designation_at_bol, encode_coding_iso_2022)
7809 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7810 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7812 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7813 (encode_invocation_designation): Last argument P_NCHARS is now
7815 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7816 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7818 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7821 * ccl.c (Fccl_execute_on_string): Declare some variables
7824 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7826 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7828 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7830 * process.c (Fformat_network_address): Doc fix.
7832 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7834 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7836 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7838 * keyboard.c (read_char): Call Lisp function help-form-show,
7839 instead of using internal_with_output_to_temp_buffer.
7840 (Qhelp_form_show): New var.
7841 (syms_of_keyboard): Use DEFSYM macro.
7843 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7845 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7847 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7849 * process.c (Flist_processes): Remove to Lisp.
7850 (list_processes_1): Delete.
7852 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7854 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7856 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7858 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7860 Fix more problems found by GCC 4.6.0's static checks.
7862 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7864 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7866 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7868 * xdisp.c (vmessage): Mark as a printf-like function.
7870 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7872 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7874 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7875 printf-like functions.
7876 (tiff_load): Add casts to remove these marks before passing them
7877 to system-supplied API.
7879 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7881 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7882 This avoids several warnings with gcc -Wstrict-overflow.
7883 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7884 directly, rather than having caller test rule sign. This avoids
7885 some unnecessary tests.
7886 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7887 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7888 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7890 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7891 (xfont_open): Avoid unnecessary tests.
7893 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7895 * composite.h, composite.c (composition_gstring_put_cache):
7896 Use EMACS_INT, not int, for length.
7898 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7899 breaking out part of COMPOSITION_DECODE_RULE.
7900 (COMPOSITION_DECODE_RULE): Use it.
7901 * composite.c (get_composition_id): Remove unused local vars,
7902 by using the new macro.
7904 * textprop.c (set_text_properties_1): Change while to do-while,
7905 since the condition is always true at first.
7907 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7908 (interval_deletion_adjustment): Return unsigned value.
7911 * process.c (list_processes_1, create_pty, read_process_output):
7912 (exec_sentinel): Remove vars that were set but not used.
7913 (create_pty): Remove unnecessary "volatile"s.
7914 (Fnetwork_interface_info): Avoid possibility of int overflow.
7915 (read_process_output): Do adaptive read buffering even if carryover.
7916 (read_process_output): Simplify nbytes computation if buffered.
7918 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7920 * syntax.c (scan_words): Remove var that was set but not used.
7921 (update_syntax_table): Use unsigned instead of int.
7923 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7924 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7925 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7927 * print.c (print_error_message): Avoid int overflow.
7929 * font.c (font_list_entities): Redo for clarity,
7930 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7932 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7933 (font_score): Avoid potential overflow in diff calculation.
7935 * fns.c (substring_both): Remove var that is set but not used.
7936 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7938 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7940 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7941 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7942 can always succeed if overflow has undefined behavior.
7944 * search.c (boyer_moore, wordify): Remove vars set but not used.
7945 (wordify): Omit three unnecessary tests.
7947 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7948 All callers changed. This avoids the need for an unused var.
7950 * casefiddle.c (casify_region): Remove var that is set but not used.
7952 * dired.c (file_name_completion): Remove var that is set but not used.
7954 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7956 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7957 (Finsert_file_contents): Remove unnecessary code checking fd.
7959 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7960 Check for integer overflow on size calculations.
7962 * buffer.c (Fprevious_overlay_change): Remove var that is set
7965 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7966 Remove vars that are set but not used.
7967 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7968 (timer_check_2): Mark vars as initialized.
7970 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7972 * image.c (lookup_image): Remove var that is set but not used.
7973 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7975 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7976 that are set but not used.
7978 * xfns.c (make_invisible_cursor): Don't return garbage
7979 if XCreateBitmapFromData fails (Bug#8410).
7981 * xselect.c (x_get_local_selection, x_handle_property_notify):
7982 Remove vars that are set but not used.
7984 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7985 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7987 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7988 Remove var that is set but not used.
7989 (scroll_bar_windows_size): Now size_t, not int.
7990 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7993 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7994 (map_tty_color) [!defined MSDOS]: Likewise.
7996 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7998 * coding.c: Remove vars that are set but not used.
7999 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8000 All callers changed.
8001 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8002 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8003 (decode_coding_charset): Remove vars that are set but not used.
8005 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8006 that is set but not used.
8008 * print.c (print_object): Remove var that is set but not used.
8010 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8011 The gnulib version avoids calling malloc in the usual case,
8012 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8013 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8014 * filelock.c (current_lock_owner): Likewise.
8015 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8016 * sysdep.c: Include allocator.h, careadlinkat.h.
8017 (emacs_no_realloc_allocator): New static constant.
8018 (emacs_readlink): New function.
8019 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8020 ../lib/careadlinkat.h.
8022 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8024 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8025 first non-nil return value).
8027 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8029 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8030 if not defined (Bug#8403).
8032 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8034 * xdisp.c (display_count_lines): Remove parameter `start',
8035 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8036 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8037 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8038 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8039 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8040 and thereabouts. All callers changed.
8041 (get_per_char_metric): Remove parameter `f', unused since
8042 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8044 2011-04-02 Jim Meyering <meyering@redhat.com>
8046 do not dereference NULL upon failed strdup
8047 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8048 (ns_get_family): Likewise.
8050 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8052 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8054 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8056 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8059 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8061 Add lexical binding.
8063 * window.c (Ftemp_output_buffer_show): New fun.
8064 (Fsave_window_excursion):
8065 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8067 * lread.c (lisp_file_lexically_bound_p): New function.
8068 (Fload): Bind Qlexical_binding.
8069 (readevalloop): Remove `evalfun' arg.
8070 Bind Qinternal_interpreter_environment.
8071 (Feval_buffer): Bind Qlexical_binding.
8072 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8074 (syms_of_lread): Declare `lexical-binding'.
8076 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8078 * keyboard.c (eval_dyn): New fun.
8079 (menu_item_eval_property): Use it.
8081 * image.c (parse_image_spec): Use Ffunctionp.
8083 * fns.c (concat, mapcar1): Accept byte-code-functions.
8085 * eval.c (Fsetq): Handle lexical vars.
8086 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8087 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8088 (FletX, Flet): Obey lexical binding.
8089 (Fcommandp): Handle closures.
8090 (Feval): New `lexical' arg.
8091 (eval_sub): New function extracted from Feval. Use it almost
8092 everywhere where Feval was used. Look up vars in lexical env.
8094 (Ffunctionp): Move from subr.el.
8095 (Ffuncall): Handle closures.
8096 (apply_lambda): Remove `eval_flags'.
8097 (funcall_lambda): Handle closures and new byte-code-functions.
8098 (Fspecial_variable_p): New function.
8099 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8100 but without exporting it to Lisp.
8102 * doc.c (Fdocumentation, store_function_docstring):
8103 * data.c (Finteractive_form): Handle closures.
8105 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8108 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8110 (exec_byte_code): New function extracted from Fbyte_code to handle new
8111 calling convention for byte-code-functions. Add new byte-codes.
8113 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8115 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8117 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8119 * xdisp.c (redisplay_internal): Fix prototype.
8121 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8123 * xdisp.c (SCROLL_LIMIT): New macro.
8124 (try_scrolling): Use it when setting scroll_limit.
8125 Limit scrolling to 100 screen lines.
8126 (redisplay_window): Even when falling back on "recentering",
8127 position point in the window according to scroll-conservatively,
8128 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8130 (try_scrolling): When point is above the window, allow searching
8131 as far as scroll_max, or one screenful, to compute vertical
8132 distance from PT to the scroll margin position. This prevents
8133 try_scrolling from unnecessarily failing when
8134 scroll-conservatively is set to a value slightly larger than the
8135 window height. Clean up the case of PT below the margin at bottom
8136 of window: scroll_max can no longer be INT_MAX. When aggressive
8137 scrolling is in use, don't let point enter the opposite scroll
8138 margin as result of the scroll.
8139 (syms_of_xdisp) <scroll-conservatively>: Document the
8140 threshold of 100 lines for never-recentering scrolling.
8142 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8144 * dispextern.h (move_it_by_lines):
8145 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8146 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8147 (message_log_check_duplicate): Remove parameters `prev_bol' and
8148 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8149 (redisplay_internal): Remove parameter `preserve_echo_area',
8150 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8152 * indent.c (Fvertical_motion):
8153 * window.c (window_scroll_pixel_based, Frecenter):
8154 Don't pass `need_y_p' to `move_it_by_lines'.
8156 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8158 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8159 steal a few bits to be more compact.
8160 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8161 Remove unneeded casts.
8163 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8165 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8167 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8168 binding" message (bug#7967).
8170 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8172 Fix more problems found by GCC 4.6.0's static checks.
8174 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8175 Remove unused local var.
8177 * editfns.c (Fmessage_box): Remove unused local var.
8179 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8180 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8181 Omit unused local vars.
8182 * window.c (shrink_windows): Omit unused local var.
8183 * menu.c (digest_single_submenu): Omit unused local var.
8184 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8185 Omit unused local var.
8187 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8188 Don't assume string length fits in int.
8189 (keyremap_step, read_key_sequence): Use size_t for sizes.
8190 (read_key_sequence): Don't check last_real_key_start redundantly.
8192 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8193 instead of alloca (Bug#8344).
8195 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8196 (Fbacktrace_frame): Don't assume nframes fits in int.
8198 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8200 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8203 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8205 * cm.c (calccost): Turn while-do into do-while, for clarity.
8207 * keyboard.c (syms_of_keyboard): Use the same style as later
8208 in this function when indexing through an array. This also
8209 works around GCC bug 48267.
8211 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8213 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8215 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8216 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8218 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8219 This avoids undefined behavior on integer overflow, and is a bit
8220 more convenient anyway since it is compared to a size_t variable.
8222 Variadic C functions now count arguments with size_t, not int.
8223 This avoids an unnecessary limitation on 64-bit machines, which
8224 caused (substring ...) to crash on large vectors (Bug#8344).
8225 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8226 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8227 All variadic functions and their callers changed accordingly.
8228 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8229 * data.c (arith_driver, float_arith_driver): Likewise.
8230 * editfns.c (general_insert_function): Likewise.
8231 * eval.c (struct backtrace.nargs, interactive_p)
8232 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8233 (funcall_lambda, mark_backtrace): Likewise.
8234 * fns.c (concat): Likewise.
8235 * frame.c (x_set_frame_parameters): Likewise.
8236 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8237 0 if not found, not -1. All callers changed.
8239 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8240 (stack_copy_size): Now size_t, not int.
8241 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8243 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8245 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8246 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8247 All callers changed.
8249 * lisp.h (multibyte_char_to_unibyte):
8250 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8251 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8252 * character.h (CHAR_TO_BYTE8):
8253 * cmds.c (internal_self_insert):
8254 * editfns.c (general_insert_function):
8255 * keymap.c (push_key_description):
8256 * search.c (Freplace_match):
8257 * xdisp.c (message_dolog, set_message_1): All callers changed.
8259 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8261 * keyboard.c (safe_run_hook_funcall): New function.
8262 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8263 don't set the hook to nil, but remove the offending function instead.
8264 (Qcommand_hook_internal): Remove, unused.
8265 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8266 Vcommand_hook_internal.
8268 * eval.c (enum run_hooks_condition): Remove.
8269 (funcall_nil, funcall_not): New functions.
8270 (run_hook_with_args): Call each function through a `funcall' argument.
8271 Remove `cond' argument, now redundant.
8272 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8273 (Frun_hook_with_args_until_failure): Adjust accordingly.
8274 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8276 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8278 * dispextern.h (string_buffer_position): Remove declaration.
8280 * print.c (strout): Remove parameter `multibyte', unused since
8281 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8283 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8284 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8285 All callers changed.
8287 * w32.c (_wsa_errlist): Use braces for struct initializers.
8289 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8290 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8291 All callers changed.
8292 (string_buffer_position): Likewise. Also, make static (it's never
8293 used outside xdisp.c).
8294 (cursor_row_p): Remove parameter `w', unused since
8295 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8296 (decode_mode_spec): Remove parameter `precision', introduced during
8297 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8298 All callers changed.
8300 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8302 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8304 2011-03-27 Anders Lindgren <andlind@gmail.com>
8306 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8307 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8308 (ns_update_auto_hide_menu_bar): New functions.
8309 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8310 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8311 ns_constrain_all_frames.
8312 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8313 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8315 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8317 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8319 2011-03-27 Glenn Morris <rgm@gnu.org>
8321 * syssignal.h: Replace RETSIGTYPE with void.
8322 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8323 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8324 Replace SIGTYPE with void everywhere.
8325 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8326 * s/template.h (SIGTYPE): Remove commented out definition.
8328 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8330 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8331 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8333 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8335 * w32.c (read_unc_volume): Use parameter `henum', instead of
8336 global variable `wget_enum_handle'.
8338 * keymap.c (describe_vector): Remove parameters `indices' and
8339 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8340 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8342 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8344 * keyboard.c (timer_check): Remove parameter `do_it_now',
8345 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8346 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8347 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8349 * keyboard.c (read_char):
8350 * w32menu.c (w32_menu_display_help):
8351 * xmenu.c (show_help_event, menu_help_callback):
8352 Adjust calls to `show_help_echo'.
8354 * gtkutil.c (xg_maybe_add_timer):
8355 * keyboard.c (readable_events):
8356 * process.c (wait_reading_process_output):
8357 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8359 * insdel.c (adjust_markers_gap_motion):
8360 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8361 (gap_left, gap_right): Don't call it.
8363 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8365 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8366 incurred during fontification.
8368 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8370 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8371 (DEFVAR_PER_BUFFER): Don't pass it.
8373 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8374 (scrolling_window): Don't pass it.
8376 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8378 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8380 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8382 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8383 of variables specific to SELinux and computation of `encoded_absname'.
8385 * image.c (XPutPixel): Remove unused variable `height'.
8387 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8389 * unexw32.c (get_section_info): Remove unused variable `section'.
8391 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8392 (system_process_attributes): Remove unused variable `sess'.
8393 (sys_read): Remove unused variable `err'.
8395 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8396 (w32_wnd_proc): Remove unused variable `isdead'.
8397 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8398 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8399 (x_create_tip_frame): Remove unused variable `tem'.
8401 * w32inevt.c (w32_console_read_socket):
8402 Remove unused variable `no_events'.
8404 * w32term.c (x_draw_composite_glyph_string_foreground):
8405 Remove unused variable `width'.
8407 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8409 * w32term.c (x_set_glyph_string_clipping):
8410 Don't pass uninitialized region to CombineRgn.
8412 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8414 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8415 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8416 (Fx_close_connection): Remove unused variable `i'.
8418 * w32font.c (w32font_draw): Return number of glyphs.
8419 (w32font_open_internal): Remove unused variable `i'.
8420 (w32font_driver): Add missing initializer.
8422 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8423 (fill_in_menu): Remove unused variable `items_added'.
8425 * w32term.c (last_mouse_press_frame): Remove static global variable.
8426 (w32_clip_to_row): Remove unused variable `f'.
8427 (x_delete_terminal): Remove unused variable `i'.
8429 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8430 (NOTHING): Remove unused static global variable.
8431 (uniscribe_check_otf): Remove unused variable `table'.
8432 (uniscribe_font_driver): Add missing initializers.
8434 2011-03-23 Julien Danjou <julien@danjou.info>
8436 * term.c (Fsuspend_tty, Fresume_tty):
8437 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8438 * window.c (temp_output_buffer_show):
8439 * insdel.c (signal_before_change):
8440 * frame.c (Fhandle_switch_frame):
8441 * fileio.c (Fdo_auto_save):
8442 * emacs.c (Fkill_emacs):
8443 * editfns.c (save_excursion_restore):
8444 * cmds.c (internal_self_insert):
8445 * callint.c (Fcall_interactively):
8446 * buffer.c (Fkill_all_local_variables):
8447 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8449 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8450 unconditionally since it does the check itself.
8452 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8454 Fix more problems found by GCC 4.5.2's static checks.
8456 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8457 the first time through the loop, since we know p0 < p1 then.
8458 This also avoids a gcc -Wstrict-overflow warning.
8460 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8461 leading to a memory leak, possible in functions like
8462 load_charset_map_from_file that can allocate an unbounded number
8463 of objects (Bug#8318).
8465 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8466 that could (at least in theory) be that large.
8468 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8469 This is less likely to overflow, and avoids undefined behavior if
8470 overflow does occur. All callers changed. Use strtoul to scan
8471 for the unsigned long integer.
8472 (pint2hrstr): Simplify and tune code slightly.
8473 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8475 * scroll.c (do_scrolling): Work around GCC bug 48228.
8476 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8478 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8479 This also avoids a warning with gcc -Wstrict-overflow.
8480 (validate_x_resource_name): Simplify count usage.
8481 This also avoids a warning with gcc -Wstrict-overflow.
8483 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8486 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8488 * process.c (Fmake_network_process): Use socklen_t, not int,
8489 where POSIX says socklen_t is required in portable programs.
8490 This fixes a porting bug on hosts like 64-bit HP-UX, where
8491 socklen_t is wider than int (Bug#8277).
8492 (Fmake_network_process, server_accept_connection):
8493 (wait_reading_process_output, read_process_output):
8496 * process.c: Rename or move locals to avoid shadowing.
8497 (list_processes_1, Fmake_network_process):
8498 (read_process_output_error_handler, exec_sentinel_error_handler):
8499 Rename or move locals.
8500 (Fmake_network_process): Define label "retry_connect" only if needed.
8501 (Fnetwork_interface_info): Fix pointer signedness.
8502 (process_send_signal): Add cast to avoid pointer signedness problem.
8503 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8504 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8506 Make tparam.h and terminfo.c consistent.
8507 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8508 Include tparam.h instead, since it declares them.
8509 * cm.h (PC): Remove extern decl; tparam.h now does this.
8510 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8511 * terminfo.c: Include tparam.h, to check interfaces.
8512 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8513 (tparam): Adjust signature to match interface in tparam.h;
8514 this removes some undefined behavior. Check that outstring and len
8515 are zero, which they always are with Emacs.
8516 * tparam.h (PC, BC, UP): New extern decls.
8518 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8519 (xftfont_open): Rename locals to avoid shadowing.
8521 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8522 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8523 (OTF_TAG_SYM): Omit macro if not needed.
8524 (ftfont_list): Remove unused local.
8525 (get_adstyle_property, ftfont_pattern_entity):
8526 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8527 Rename locals to avoid shadowing.
8529 * xfont.c (xfont_list_family): Mark var as initialized.
8531 * xml.c (make_dom): Now static.
8533 * composite.c (composition_compute_stop_pos): Rename local to
8535 (composition_reseat_it): Remove unused locals.
8536 (find_automatic_composition, composition_adjust_point): Likewise.
8537 (composition_update_it): Mark var as initialized.
8538 (find_automatic_composition): Mark vars as initialized,
8539 with a FIXME (Bug#8290).
8541 character.h: Rename locals to avoid shadowing.
8542 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8543 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8544 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8545 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8548 * textprop.c (property_change_between_p): Remove; unused.
8550 * intervals.c (interval_start_pos): Now static.
8552 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8554 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8555 Rename locals to avoid shadowing.
8557 * sound.c (wav_play, au_play, Fplay_sound_internal):
8558 Fix pointer signedness.
8559 (alsa_choose_format): Remove unused local var.
8560 (wav_play): Initialize a variable to 0, to prevent undefined
8561 behavior (Bug#8278).
8563 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8565 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8567 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8568 clobbering (Bug#8298).
8569 * sysdep.c (sys_subshell): Likewise.
8570 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8572 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8573 This should get cleaned up, so that child_setup has the
8574 same signature on all platforms.
8576 * callproc.c (call_process_cleanup): Now static.
8577 (relocate_fd): Rename locals to avoid shadowing.
8579 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8581 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8582 not to be necessary, and produces flickering.
8584 2011-03-20 Glenn Morris <rgm@gnu.org>
8586 * config.in: Remove file.
8588 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8590 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8591 are now in src/globals.h.
8592 (syms_of_minibuf): Remove spurious & from previous change.
8594 2011-03-20 Leo Liu <sdl.web@gmail.com>
8596 * minibuf.c (completing-read-function): New variable.
8597 (completing-read-default): Rename from completing-read.
8598 (completing-read): Call completing-read-function.
8600 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8602 * xfaces.c (Fx_load_color_file):
8603 Read color file from absolute filename (bug#8250).
8605 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8607 * makefile.w32-in: Update dependencies.
8609 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8611 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8613 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8615 Fix more problems found by GCC 4.5.2's static checks.
8617 * process.c (make_serial_process_unwind, send_process_trap):
8618 (sigchld_handler): Now static.
8620 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8621 That way, the code declares only the vars that it needs.
8622 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8623 * s/cygwin.h (PTY_ITERATION): Likewise.
8624 * s/darwin.h (PTY_ITERATION): Likewise.
8625 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8627 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8628 * process.c (allocate_pty): Don't declare stb unless it's needed.
8630 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8631 (CONSTANTLIM): Remove; unused.
8632 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8633 Define only if needed.
8635 * unexelf.c (unexec): Name an expression,
8636 to avoid gcc -Wbad-function-cast warning.
8637 Use a different way to cause a compilation error if anyone uses
8638 n rather than nn, a way that does not involve shadowing.
8639 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8641 * deps.mk (unexalpha.o): Remove; unused.
8643 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8644 * unexec.h: New file.
8645 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8646 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8648 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8649 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8650 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8651 Change as necessary to match prototype in unexec.h.
8653 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8655 (back_comment, skip_chars): Mark vars as initialized.
8657 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8658 Rename locals to avoid shadowing.
8660 * lread.c (read1): Rewrite so as not to use empty "else".
8661 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8663 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8665 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8666 warning when compiling print.c.
8668 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8669 instead of using an uninitialized var.
8670 (font_sort_entities): Mark var as initialized.
8672 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8674 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8675 pointers to constants.
8676 (font_parse_fcname): Remove unused vars.
8677 (font_delete_unmatched): Now static.
8678 (font_get_spec): Remove; unused.
8679 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8680 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8681 Rename or move locals to avoid shadowing.
8683 * fns.c (require_nesting_list, require_unwind): Now static.
8684 (Ffillarray): Rename locals to avoid shadowing.
8686 * floatfns.c (domain_error2): Define only if needed.
8687 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8689 * alloc.c (mark_backtrace): Move decl from here ...
8690 * lisp.h: ... to here, so that it can be checked.
8692 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8693 (Fdefvar): Rewrite so as not to use empty "else".
8694 (lisp_indirect_variable): Name an expression,
8695 to avoid gcc -Wbad-function-cast warning.
8696 (Fdefvar): Rename locals to avoid shadowing.
8698 * callint.c (quotify_arg, quotify_args): Now static.
8699 (Fcall_interactively): Rename locals to avoid shadowing.
8700 Use const pointer when appropriate.
8702 * lisp.h (get_system_name, get_operating_system_release):
8703 Move decls here, to check interfaces.
8704 * process.c (get_operating_system_release): Move decl to lisp.h.
8705 * xrdb.c (get_system_name): Likewise.
8706 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8707 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8708 some of which prompt warnings from gcc -Wbad-function-cast.
8709 (Fformat_time_string, Fencode_time, Finsert_char):
8710 (Ftranslate_region_internal, Fformat):
8711 Rename or remove local vars to avoid shadowing.
8712 (Ftranslate_region_internal): Mark var as initialized.
8714 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8717 * lisp.h (eassert): Check that the argument compiles, even if
8718 ENABLE_CHECKING is not defined.
8720 * data.c (Findirect_variable): Name an expression, to avoid
8721 gcc -Wbad-function-cast warning.
8722 (default_value, arithcompare, arith_driver, arith_error): Now static.
8723 (store_symval_forwarding): Rename local to avoid shadowing.
8724 (Fmake_variable_buffer_local, Fmake_local_variable):
8725 Mark variables as initialized.
8726 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8728 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8729 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8730 Rename locals to avoid shadowing.
8731 (mark_stack): Move local variables into the #ifdef region where
8733 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8734 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8736 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8737 (GC_STRING_CHARS): Remove; not used.
8738 (Fmemory_limit): Cast sbrk's returned value to char *.
8740 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8741 avoids undefined behavior in theory.
8743 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8745 Use functions, not macros, for up- and down-casing (Bug#8254).
8746 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8747 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8748 to use the following functions instead of these macros.
8749 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8750 EMACS_INT, since callers assume the returned value fits in int.
8751 (upcase1): Likewise, for UPCASE_TABLE.
8752 (uppercasep, lowercasep, upcase): New static inline functions.
8753 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8754 the race-condition problem in the old DOWNCASE.
8756 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8757 Rename locals to avoid shadowing.
8758 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8759 (regex_compile, re_search_2, re_match_2_internal):
8760 Remove unused local vars.
8761 (FREE_VAR): Rewrite so as not to use empty "else",
8762 which gcc can warn about.
8763 (regex_compile, re_match_2_internal): Mark locals as initialized.
8764 (RETALLOC_IF): Define only if needed.
8765 (WORDCHAR_P): Likewise. This one is never needed, but is used
8766 only in a comment talking about a compiler bug, so put inside
8767 the #if 0 of that comment.
8768 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8769 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8772 * search.c (boyer_moore): Rename locals to avoid shadowing.
8773 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8774 (PREV_CHAR_BOUNDARY): Likewise.
8776 * search.c (simple_search): Remove unused var.
8778 * dired.c (compile_pattern): Move decl from here ...
8779 * lisp.h: ... to here, so that it can be checked.
8780 (struct re_registers): New forward decl.
8782 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8784 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8786 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8787 Rename locals to avoid shadowing.
8788 (Fvertical_motion): Mark locals as initialized.
8790 * casefiddle.c (casify_object, casify_region): Now static.
8791 (casify_region): Mark local as initialized.
8793 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8795 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8796 New macros, so that the caller can use some names other than
8797 gcpro1, gcpro2, etc.
8798 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8800 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8801 argument, for consistency with GCPRO2_VAR, etc: it is now the
8802 prefix of the variable, not the variable itself. All uses
8804 * dired.c (directory_files_internal, file_name_completion):
8805 Rename locals to avoid shadowing.
8807 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8808 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8809 dired.c's scmp function, had undefined behavior.
8810 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8811 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8812 * buffer.h: ... to here, because these macros use current_buffer,
8813 and the new implementation with inline functions needs to have
8814 current_buffer in scope now, rather than later when the macros
8816 (downcase, upcase1): New static inline functions.
8817 (DOWNCASE, UPCASE1): Reimplement using these functions.
8818 This avoids undefined behavior in expressions like
8819 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8820 from race conditions in accessing the global variables
8821 case_temp1 and case_temp2.
8822 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8823 * lisp.h (case_temp1, case_temp2): Remove their decls.
8824 * character.h (ASCII_CHAR_P): Move from here ...
8825 * lisp.h: ... to here, so that the inline functions mentioned
8828 * dired.c (directory_files_internal_unwind): Now static.
8830 * fileio.c (file_name_as_directory, directory_file_name):
8831 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8833 (file_name_as_directory): Use const pointers when appropriate.
8834 (Fexpand_file_name): Likewise. In particular, newdir might
8835 point at constant storage, so make it a const pointer.
8836 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8837 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8839 (Fset_file_times, Finsert_file_contents, auto_save_error):
8840 Rename locals to avoid shadowing.
8842 * minibuf.c (choose_minibuf_frame_1): Now static.
8843 (Ftry_completion, Fall_completions): Rename or remove locals
8846 * marker.c (bytepos_to_charpos): Remove; unused.
8848 * lisp.h (verify_bytepos, count_markers): New decls,
8849 so that gcc does not warn that these functions aren't declared.
8851 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8852 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8853 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8854 (copy_text): Remove unused local var.
8856 * filelock.c (within_one_second): Now static.
8857 (lock_file_1): Rename local to avoid shadowing.
8859 * buffer.c (fix_overlays_before): Mark locals as initialized.
8860 (fix_start_end_in_overlays): Likewise. This function should be
8861 simplified by using pointers-to-pointers, but that's a different
8863 (switch_to_buffer_1): Now static.
8864 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8865 (report_overlay_modification): Rename locals to avoid shadowing.
8867 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8868 Fix pointer signedness issue.
8869 (sys_subshell): Mark local as volatile if checking for lint,
8870 to suppress a gcc -Wclobbered warning that does not seem to be right.
8871 (MAXPATHLEN): Define only if needed.
8873 * process.c (serial_open, serial_configure): Move decls from here ...
8874 * systty.h: ... to here, so that they can be checked.
8876 * fns.c (get_random, seed_random): Move extern decls from here ...
8877 * lisp.h: ... to here, so that they can be checked.
8879 * sysdep.c (reset_io): Now static.
8880 (wait_for_termination_signal): Remove; unused.
8882 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8883 (copy_keymap_item, append_key, push_text_char_description):
8885 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8886 (DENSE_TABLE_SIZE): Remove; unused.
8887 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8888 (describe_map_tree):
8889 Rename locals to avoid shadowing.
8891 * keyboard.c: Declare functions static if they are not used elsewhere.
8892 (echo_char, echo_dash, cmd_error, top_level_2):
8893 (poll_for_input, handle_async_input): Now static.
8894 (read_char, kbd_buffer_get_event, make_lispy_position):
8895 (make_lispy_event, make_lispy_movement, apply_modifiers):
8896 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8897 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8898 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8899 (read_key_sequence, read_char): Mark locals as initialized.
8900 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8902 * keyboard.h (make_ctrl_char): New decl.
8903 (mark_kboards): Move decl here ...
8904 * alloc.c (mark_kboards): ... from here.
8906 * lisp.h (force_auto_save_soon): New decl.
8908 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8909 (DEFINE_DUMMY_FUNCTION): New macro.
8910 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8912 (main): Add casts to avoid warnings
8913 if GCC considers string literals to be constants.
8915 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8917 * dbusbind.c: Pointer signedness fixes.
8918 (xd_signature, xd_append_arg, xd_initialize):
8919 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8920 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8921 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8922 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8924 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8925 if GCC considers string literals to be constants.
8926 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8928 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8930 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8931 (print_preprocess, print_object): New macro to fix last change.
8933 * print.c (print_preprocess): Don't forget font objects.
8935 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8937 * emacs.c (USAGE3): Doc fixes.
8939 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8941 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8944 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8946 * lisp.h (VWindow_system, Qfile_name_history):
8947 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8948 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8949 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8951 * w32select.c: Don't #include "keyboard.h".
8952 (run_protected): Add extern declaration for waiting_for_input.
8954 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8955 * w32console.c (detect_input_pending, read_input_pending)
8956 (encode_terminal_code):
8957 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8958 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8959 (w32_system_caret_y, Qfile_name_history):
8960 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8961 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8962 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8963 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8964 * w32proc.c (Qlocal, report_file_error):
8965 * w32term.c (Vwindow_system, updating_frame):
8966 * w32uniscribe.c (initialized, uniscribe_font_driver):
8967 Remove unneeded extern declarations.
8969 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8971 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8973 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8975 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8976 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8977 These macros can no longer be used for assignment.
8979 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8980 Assign struct members directly, instead of using BUF_BEGV etc.
8981 (record_buffer_markers, fetch_buffer_markers): New functions for
8982 recording and fetching special buffer markers.
8983 (set_buffer_internal_1, set_buffer_temp): Use them.
8985 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8987 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8989 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8990 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8992 * xdisp.c (hscroll_window_tree):
8993 (reconsider_clip_changes): Use PT instead of BUF_PT.
8995 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8997 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8998 $(EMACS_ROOT)/lib/intprops.h.
9000 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9002 Fix more problems found by GCC 4.5.2's static checks.
9004 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9005 to unsigned char * to avoid compiler diagnostic.
9006 (xg_free_frame_widgets): Make it clear that a local variable is
9007 needed only if USE_GTK_TOOLTIP.
9008 (gdk_window_get_screen): Make it clear that this macro is needed
9009 only if USE_GTK_TOOLTIP.
9010 (int_gtk_range_get_value): New function, which avoids a diagnostic
9011 from gcc -Wbad-function-cast.
9012 (xg_set_toolkit_scroll_bar_thumb): Use it.
9013 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9014 diagnostic from gcc -Wbad-function-cast.
9015 (get_utf8_string, xg_get_file_with_chooser):
9016 Rename locals to avoid shadowing.
9017 (create_dialog): Move locals to avoid shadowing.
9019 * xgselect.c (xg_select): Remove unused var.
9021 * image.c (four_corners_best): Mark locals as initialized.
9022 (gif_load): Initialize transparent_p to zero (Bug#8238).
9023 Mark another local as initialized.
9024 (my_png_error, my_error_exit): Mark with NO_RETURN.
9026 * image.c (clear_image_cache): Now static.
9027 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9028 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9029 (x_edge_detection): Remove unnecessary cast that
9030 gcc -Wbad-function-cast diagnoses.
9031 (gif_load): Fix pointer signedness.
9032 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9033 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9035 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9037 Improve quality of tests for time stamp overflow.
9038 For example, without this patch (encode-time 0 0 0 1 1
9039 1152921504606846976) returns the obviously-bogus value (-948597
9040 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9041 reports time overflow. See
9042 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9043 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9044 * editfns.c: Include limits.h and intprops.h.
9045 (TIME_T_MIN, TIME_T_MAX): New macros.
9046 (time_overflow): Move earlier, to before first use.
9047 (hi_time, lo_time): New functions, for an accurate test for
9049 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9050 (Fget_internal_run_time): Don't assume time_t fits in int.
9051 (make_time): Use list2 instead of Fcons twice.
9052 (Fdecode_time): More accurate test for out-of-range times.
9053 (check_tm_member): New function.
9054 (Fencode_time): Use it, to test for out-of-range times.
9055 (lisp_time_argument): Don't rely on undefined left-shift and
9056 right-shift behavior when checking for time stamp overflow.
9058 * editfns.c (time_overflow): New function, refactoring common code.
9059 (Fformat_time_string, Fdecode_time, Fencode_time):
9060 (Fcurrent_time_string): Use it.
9062 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9063 * dired.c (make_time): Move to ...
9064 * editfns.c (make_time): ... here.
9065 * systime.h: Note the move.
9067 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9069 * fringe.c (update_window_fringes): Remove unused variables.
9071 * unexmacosx.c (copy_data_segment): Also copy __got section.
9074 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9076 * termcap.c [MSDOS]: Include "msdos.h".
9077 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9078 Constify `char *' arguments and their references according to
9079 prototypes in tparam.h.
9081 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9083 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9084 Adapt all references accordingly.
9086 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9088 2011-03-11 Tom Tromey <tromey@redhat.com>
9090 * buffer.c (syms_of_buffer): Remove obsolete comment.
9092 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9094 * termhooks.h (encode_terminal_code): Declare prototype.
9096 * msdos.c (encode_terminal_code): Don't declare prototype.
9098 * term.c (encode_terminal_code): Now external again, used by
9099 w32console.c and msdos.c.
9101 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9102 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9104 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9106 Fix some minor problems found by GCC 4.5.2's static checks.
9108 * fringe.c (update_window_fringes): Mark locals as initialized
9110 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9112 * alloc.c (mark_fringe_data): Move decl from here ...
9113 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9114 to check its interface.
9115 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9117 * fontset.c (free_realized_fontset): Now static.
9118 (Fset_fontset_font): Rename local to avoid shadowing.
9119 (fontset_font): Mark local as initialized.
9120 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9122 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9124 * xselect.c (x_disown_buffer_selections): Remove; not used.
9125 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9126 (x_own_selection, Fx_disown_selection_internal): Rename locals
9128 (x_handle_dnd_message): Remove local to avoid shadowing.
9130 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9131 so that the caller can use some name other than gcpro1.
9132 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9133 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9134 (Fx_backspace_delete_keys_p):
9135 Use them to avoid shadowing, and rename vars to avoid shadowing.
9136 (x_decode_color, x_set_name, x_window): Now static.
9137 (Fx_create_frame): Add braces to silence GCC warning.
9138 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9139 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9140 Remove unused locals.
9141 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9142 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9143 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9146 * xterm.h (x_mouse_leave): New decl.
9148 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9149 Remove unused functions.
9150 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9151 (x_calc_absolute_position): Now static.
9152 (XTread_socket): Don't define label "out" unless it's used.
9153 Don't declare local "event" unless it's used.
9154 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9155 unless they are used.
9156 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9157 (x_fatal_error_signal): Remove; not used.
9158 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9159 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9160 (x_error_catcher, x_connection_closed, x_error_handler):
9161 (x_error_quitter, xembed_send_message, x_iconify_frame):
9162 (my_log_handler): Rename locals to avoid shadowing.
9163 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9164 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9166 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9167 Rename or move locals to avoid shadowing.
9168 (tty_defined_color, merge_face_heights): Now static.
9169 (free_realized_faces_for_fontset): Remove; not used.
9170 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9171 does not deduce is never used uninitialized.
9172 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9173 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9175 * terminal.c (store_terminal_param): Now static.
9177 * xmenu.c (menu_highlight_callback): Now static.
9178 (set_frame_menubar): Remove unused local.
9179 (xmenu_show): Rename parameter to avoid shadowing.
9180 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9181 since they might point to immutable storage.
9182 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9183 since it's unused otherwise.
9185 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9186 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9187 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9188 avoids a gcc -Wuninitialized diagnostic.
9189 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9190 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9191 does not deduce are never used uninitialized.
9193 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9195 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9196 * window.c (window_loop, size_window):
9197 (run_window_configuration_change_hook, enlarge_window): Likewise.
9199 * window.c (display_buffer): Now static.
9200 (size_window): Mark variables that gcc -Wuninitialized
9201 does not deduce are never used uninitialized.
9202 * window.h (check_all_windows): New decl, to forestall
9203 gcc -Wmissing-prototypes diagnostic.
9204 * dispextern.h (bidi_dump_cached_states): Likewise.
9206 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9208 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9210 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9211 and to avoid gcc -Wuninitialized warning.
9212 (load_charset_map): Mark variables that gcc -Wuninitialized
9213 does not deduce are never used uninitialized.
9214 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9216 * coding.c (coding_set_source, coding_set_destination):
9217 Use "else { /* comment */ }" rather than "else /* comment */;"
9218 for clarity, and to avoid gcc -Wempty-body warning.
9219 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9220 a block, when the outer 'i' will do.
9221 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9222 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9223 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9224 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9225 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9226 Rename locals to avoid shadowing.
9227 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9228 * coding.c (emacs_mule_char, encode_invocation_designation):
9229 Now static, since they're not used elsewhere.
9230 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9231 (decode_coding_object, encode_coding_object, detect_coding_system):
9232 (decode_coding_emacs_mule): Mark variables that gcc
9233 -Wuninitialized does not deduce are never used uninitialized.
9234 (detect_coding_iso_2022): Initialize a local variable that might
9235 be used uninitialized. Leave a FIXME because it's not clear that
9236 this initialization is needed. (Bug#8211)
9237 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9238 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9239 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9240 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9241 Remove unused macros.
9243 * category.c (hash_get_category_set): Remove unused local var.
9244 (copy_category_table): Now static, since it's not used elsewhere.
9245 * character.c (string_count_byte8): Likewise.
9247 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9248 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9250 * chartab.c (copy_sub_char_table): Now static, since it's not used
9252 (sub_char_table_ref_and_range, char_table_ref_and_range):
9253 Rename locals to avoid shadowing.
9254 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9256 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9257 (BIDI_BOB): Remove unused macro.
9259 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9260 deduce are never used uninitialized.
9261 * term.c (encode_terminal_code): Likewise.
9263 * term.c (encode_terminal_code): Now static. Remove unused local.
9265 * tparam.h: New file.
9266 * term.c, tparam.h: Include it.
9267 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9268 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9269 Move these decls to tparam.h, and make them agree with what
9270 is actually in tparam.c. The previous trick of using incompatible
9271 decls in different modules does not conform to the C standard.
9272 All callers of tparam changed to use tparam's actual API.
9273 * tparam.c (tparam1, tparam, tgoto):
9274 Use const pointers where appropriate.
9276 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9277 * cm.h (struct cm): Likewise.
9278 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9279 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9280 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9281 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9282 (turn_on_face, init_tty): Likewise.
9283 * termchar.h (struct tty_display_info): Likewise.
9285 * term.c (term_mouse_position): Rename local to avoid shadowing.
9287 * alloc.c (mark_ttys): Move decl from here ...
9288 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9290 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9292 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9294 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9296 * search.c (compile_pattern_1): Remove argument regp, unused since
9297 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9298 (compile_pattern): Don't pass it.
9300 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9302 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9303 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9305 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9307 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9309 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9310 gdk_window_get_screen, gdk_window_get_geometry,
9311 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9312 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9313 (xg_get_pixbuf_from_pixmap): New function.
9314 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9315 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9316 Call xg_get_pixbuf_from_pixmap instead of
9317 gdk_pixbuf_get_from_drawable.
9318 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9319 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9320 (xg_check_special_colors): Use GtkStyleContext and its functions
9322 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9323 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9324 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9325 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9326 Call gtk_widget_get_preferred_size.
9327 (xg_frame_resized): gdk_window_get_geometry only takes 5
9329 (xg_win_to_widget, xg_event_is_for_menubar):
9330 Call gdk_x11_window_lookup_for_display.
9331 (xg_set_widget_bg): New function.
9332 (delete_cb): New function.
9333 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9334 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9335 (xg_set_background_color): Call xg_set_widget_bg.
9336 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9337 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9338 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9339 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9341 (update_frame_tool_bar): Call gtk_widget_hide.
9342 (xg_initialize): Use GDK_KEY_g.
9344 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9346 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9348 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9349 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9350 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9352 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9354 * w32xfns.c (select_palette): Check success of RealizePalette against
9355 GDI_ERROR, not zero.
9357 See ChangeLog.11 for earlier changes.
9363 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9365 This file is part of GNU Emacs.
9367 GNU Emacs is free software: you can redistribute it and/or modify
9368 it under the terms of the GNU General Public License as published by
9369 the Free Software Foundation, either version 3 of the License, or
9370 (at your option) any later version.
9372 GNU Emacs is distributed in the hope that it will be useful,
9373 but WITHOUT ANY WARRANTY; without even the implied warranty of
9374 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9375 GNU General Public License for more details.
9377 You should have received a copy of the GNU General Public License
9378 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.