1 2011-05-14 Paul Eggert <eggert@cs.ucla.edu>
3 Fixups, following up to the user-interface timestamp change.
4 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5 for UI timestamps, instead of unsigned long.
6 * msdos.c (mouse_get_pos): Likewise.
7 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8 * w32gui.h (Time): Define by including "systime.h" rather than by
9 declaring it ourselves. (Bug#8664)
11 2011-05-13 Paul Eggert <eggert@cs.ucla.edu>
13 * editfns.c (Fformat): Fix several integer overflow problems.
14 For example, without this change, (format "%2147483648d" 1) dumps
15 core on x86-64 GNU/Linux. Use EMACS_INT, not size_t, for sizes,
16 since we prefer using signed values, and EMACS_INT will be big
17 enough soon, even on 32-bit hosts. Also, prefer EMACS_INT to int
18 for sizes. Don't assume that pI is either "l" or ""; it might be
19 "ll" or "I64". Check for width and precision greater than
20 INT_MAX, as this can make sprintf go kaflooey. (Bug#8668)
22 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
23 * image.c (clear_image_cache): Likewise.
25 2011-05-12 Paul Eggert <eggert@cs.ucla.edu>
27 * term.c (term_mouse_position): Don't assume time_t wraparound.
29 Be more systematic about user-interface timestamps.
30 Before, the code sometimes used 'Time', sometimes 'unsigned long',
31 and sometimes 'EMACS_UINT', to represent these timestamps. This
32 change causes it to use 'Time' uniformly, as that's what X uses.
33 This makes the code easier to follow, and makes it easier to catch
34 integer overflow bugs such as Bug#8664.
35 * frame.c (Fmouse_position, Fmouse_pixel_position):
36 Use Time, not unsigned long, for user-interface timestamps.
37 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
38 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
39 * keyboard.h (last_event_timestamp): Likewise.
40 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
41 * menu.h (xmenu_show): Likewise.
42 * term.c (term_mouse_position): Likewise.
43 * termhooks.h (struct input_event.timestamp): Likewise.
44 (struct terminal.mouse_position_hook): Likewise.
45 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
46 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
47 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
48 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
50 * menu.h, termhooks.h: Include "systime.h", for Time.
52 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
53 Don't assume that the difference between two unsigned long values
54 can fit into an integer. At this point, we know button_down_time
55 <= event->timestamp, so the difference must be nonnegative, so
56 there's no need to cast the result if double-click-time is
57 nonnegative, as it should be; check that it's nonnegative, just in
58 case. This bug is triggered when events are more than 2**31 ms
59 apart (about 25 days). (Bug#8664)
61 * xselect.c (last_event_timestamp): Remove duplicate decl.
62 (x_own_selection): Remove needless cast to unsigned long.
64 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
65 that always fit in int. Use a sentinel instead of a counter, to
66 avoid a temp and to allay GCC's concerns about possible int overflow.
67 * frame.h (struct frame): Use int for menu_bar_items_used
68 instead of EMACS_INT, since it always fits in int.
70 * menu.c (grow_menu_items): Check for int overflow.
72 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
74 2011-05-11 Paul Eggert <eggert@cs.ucla.edu>
76 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
77 Before, the code was not consistent. These values cannot exceed
78 2**31 - 1 so there's no need to make them unsigned.
79 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
80 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
81 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
83 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
85 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
86 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
87 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
88 presumably because the widths might not match.
90 * window.c (size_window): Avoid needless test at loop start.
92 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
94 * image.c (Finit_image_library): Return t for built-in image types,
95 like pbm and xbm. (Bug#8640)
97 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
99 * w32menu.c (set_frame_menubar): Fix submenu allocation.
101 2011-05-07 Eli Zaretskii <eliz@gnu.org>
103 * w32console.c (Fset_screen_color): Doc fix.
104 (Fget_screen_color): New function.
105 (syms_of_ntterm): Defsubr it.
107 * callproc.c (call_process_cleanup): Don't close and unlink the
108 temporary file if Fcall_process didn't create it in the first
110 (Fcall_process): Don't create tempfile if stdout of the child
111 process will be redirected to a file specified with `:file'.
112 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
113 cue to call_process_cleanup not to close that handle.
115 2011-05-07 Ben Key <bkey76@gmail.com>
117 * makefile.w32-in: The bootstrap-temacs rule now makes use of
118 one of two shell specific rules, either bootstrap-temacs-CMD or
119 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
120 to the previous implementation of the bootstrap-temacs rule.
121 The bootstrap-temacs-CMD rule is similar to the previous
122 implementation of the bootstrap-temacs rule except that it
123 makes use of the ESC_CFLAGS variable instead of the CFLAGS
126 These changes, along with some changes to nt/configure.bat,
127 nt/gmake.defs, and nt/nmake.defs, are required to extend my
128 earlier fix to add support for --cflags and --ldflags options
129 that include quotes so that it works whether make uses cmd or
132 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
134 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
135 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
137 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
138 a string. Handle both cases.
139 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
140 (Fdbus_register_method): Use Qinvalid_function.
142 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
144 * makefile.w32-in: Update dependencies.
145 (LISP_H): Add inttypes.h and stdin.h.
146 (PROCESS_H): Add unistd.h.
148 2011-05-06 Eli Zaretskii <eliz@gnu.org>
150 * lread.c: Include limits.h (fixes the MS-Windows build broken by
151 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
153 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
155 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
157 * term.c (vfatal): Remove stray call to va_end.
158 It's not needed and the C Standard doesn't allow it here anyway.
160 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
161 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
163 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
166 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
168 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
170 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
172 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
174 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
176 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
177 * charset.c (Fdefine_charset_internal): Don't initialize
178 charset.code_space[15]. The value was garbage, on hosts with
179 32-bit int (Bug#8600).
181 * lread.c (read_integer): Be more consistent with string-to-number.
182 Use string_to_number to do the actual conversion; this avoids
183 rounding errors and fixes some other screwups. Without this fix,
184 for example, #x1fffffffffffffff was misread as -2305843009213693952.
185 (digit_to_number): Move earlier, for benefit of read_integer.
186 Return -1 if the digit is out of range for the base, -2 if it is
187 not a digit in any supported base. (Bug#8602)
189 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
191 * dispnew.c (scrolling_window): Return 1 if we scrolled,
192 to match comment at start of function. This also removes a
193 GCC warning about overflow in a 32+64-bit port.
195 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
197 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
198 Reported by Stefan Monnier in
199 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
200 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
201 SYMBOLP-guarded XSYMBOL, not XPNTR.
203 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
204 (EMACS_UINTPTR): Likewise, with uintptr_t.
206 * lisp.h: Prefer 64-bit EMACS_INT if available.
207 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
208 on 32-bit hosts that have 64-bit int, so that they can access
210 However, temporarily disable this change unless the temporary
211 symbol WIDE_EMACS_INT is defined.
213 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
215 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
216 This removes an assumption that EMACS_INT and long are the same
217 width as pointers. The assumption is true for Emacs porting targets
218 now, but we want to make other targets possible.
219 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
220 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
221 In the rest of the code, change types of integers that hold casted
222 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
223 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
224 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
225 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
226 No need to cast type when ORing.
227 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
228 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
229 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
230 assume EMACS_INT is the same width as char *.
231 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
232 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
233 Remove no-longer-needed casts.
234 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
235 (xg_tool_bar_help_callback, xg_make_tool_item):
236 Use EMACS_INTPTR to hold an integer
237 that will be cast to void *; this can avoid a GCC warning
238 if EMACS_INT is not the same width as void *.
239 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
240 * xdisp.c (display_echo_area_1, resize_mini_window_1):
241 (current_message_1, set_message_1):
242 Use a local to convert to proper width without a cast.
243 * xmenu.c (dialog_selection_callback): Likewise.
245 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
246 Also, don't assume VALBITS / RAND_BITS is less than 5,
247 and don't rely on undefined behavior when shifting a 1 left into
249 * lisp.h (get_random): Change signature to match.
251 * lread.c (hash_string): Use size_t, not int, for hash computation.
252 Normally we prefer signed values; but hashing is special, because
253 it's better to use unsigned division on hash table sizes so that
254 the remainder is nonnegative. Also, size_t is the natural width
255 for hashing into memory. The previous code used 'int', which doesn't
256 retain enough info to hash well into very large tables.
257 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
259 * dbusbind.c: Don't possibly lose pointer info when converting.
260 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
261 Use XPNTR rather than XHASH, so that the high-order bits of
262 the pointer aren't lost when converting through void *.
264 * eval.c (Fautoload): Don't double-shift a pointer.
266 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
268 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
270 * gnutls.c (DEF_GNUTLS_FN):
271 * image.c (DEF_IMGLIB_FN): Make function pointers static.
273 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
275 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
278 2011-05-05 Eli Zaretskii <eliz@gnu.org>
280 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
281 New version that can reserve upto 2GB of heap space.
283 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
285 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
287 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
289 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
290 `gnutls_certificate_set_x509_key_file'.
292 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
294 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
297 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
299 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
300 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
301 Remove unused parameter `fildes'.
302 * process.c (read_process_output, send_process): Don't pass it.
304 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
306 Fix previous change: the library cache is defined in w32.c.
307 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
308 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
310 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
312 Implement dynamic loading of GnuTLS on Windows.
314 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
315 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
319 * gnutls.c (Qgnutls_dll): Define.
320 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
321 (gnutls_*): Declare function pointers.
322 (init_gnutls_functions): New function to initialize function pointers.
323 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
324 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
325 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
326 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
327 (emacs_gnutls_write, emacs_gnutls_read)
328 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
329 (Fgnutls_available_p): New function.
330 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
331 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
332 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
334 * image.c: Include w32.h.
335 (Vimage_type_cache): Delete.
336 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
337 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
338 (w32_delayed_load): Move to w32.c.
340 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
342 * w32.c (QCloaded_from, Vlibrary_cache): Define.
343 (w32_delayed_load): Move from image.c. When loading a library, record
344 its filename in the :loaded-from property of the library id.
345 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
346 Initialize and staticpro them.
347 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
349 * process.c: Include lisp.h before w32.h, not after.
350 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
351 instead of gnutls_record_check_pending.
353 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
355 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
357 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
358 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
361 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
363 * xterm.c (x_set_frame_alpha): Do not set property on anything
364 else than FRAME_X_OUTER_WINDOW (Bug#8608).
366 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
368 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
370 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
372 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
373 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
374 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
375 (gnutls_global_initialized, Qgnutls_bootprop_priority)
376 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
377 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
378 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
379 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
380 (Qgnutls_bootprop_callbacks_verify): Make static.
382 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
384 * callproc.c: Indentation fixup.
386 * sysdep.c (wait_for_termination_1): Make static.
387 (wait_for_termination, interruptible_wait_for_termination): Move
388 after wait_for_termination_1.
390 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
392 * sysdep.c (interruptible_wait_for_termination): New function
393 which is like wait_for_termination, but allows keyboard
396 * callproc.c (Fcall_process): Add (:file "file") as an option for
398 (Fcall_process_region): Ditto.
400 2011-04-30 Eli Zaretskii <eliz@gnu.org>
402 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
403 rather than `XVECTOR (FOO)->size'.
405 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
406 inttypes.h, as a gnulib replacement is used if it not available in
409 2011-04-21 Eli Zaretskii <eliz@gnu.org>
411 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
412 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
413 of MOST_POSITIVE_FIXNUM. (Bug#8528)
415 * coding.c (coding_alloc_by_realloc): Error out if destination
416 will grow beyond MOST_POSITIVE_FIXNUM.
417 (decode_coding_emacs_mule): Abort if there isn't enough place in
418 charbuf for the composition carryover bytes. Reserve an extra
419 space for up to 2 characters produced in a loop.
420 (decode_coding_iso_2022): Abort if there isn't enough place in
421 charbuf for the composition carryover bytes.
423 2011-04-21 Eli Zaretskii <eliz@gnu.org>
425 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
426 aborting when %lld or %lll format is passed.
427 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
428 %llo or %llx format is passed. (Bug#8545)
430 * window.c (window_scroll_line_based): Use a marker instead of
431 simple variables to record original value of point. (Bug#7952)
433 * doprnt.c (doprnt): Fix the case where a multibyte sequence
434 produced by %s or %c overflows available buffer space. (Bug#8545)
436 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
438 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
439 (SIZE_MAX): Move defn after all includes, as they might #define it.
441 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
443 * w32.c (init_environment): Warn about defaulting HOME to C:\.
445 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
447 * keyboard.c (Qdelayed_warnings_hook): Define.
448 (command_loop_1): Run `delayed-warnings-hook'
449 if Vdelayed_warnings_list is non-nil.
450 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
451 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
453 2011-04-28 Eli Zaretskii <eliz@gnu.org>
455 * doprnt.c (doprnt): Don't return value smaller than the buffer
456 size if the message was truncated. (Bug#8545).
458 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
460 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
461 (Fx_window_property): #if-0 the whole functions, not just the bodies.
463 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
465 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
467 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
469 * makefile.w32-in: Update dependencies.
471 2011-04-27 Eli Zaretskii <eliz@gnu.org>
473 Improve `doprnt' and its usage. (Bug#8545)
474 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
475 `format_end'. Remove support for %l as a conversion specifier.
476 Don't use xrealloc. Improve diagnostics when the %l size modifier
477 is used. Update the commentary.
479 * eval.c (verror): Simplify calculation of size_t.
481 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
484 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
486 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
489 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
491 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
492 This makes this file independent of the recent pseudovector change.
494 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
496 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
498 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
499 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
501 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
503 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
504 GCC 4.6.0 optimizes based on type-based alias analysis. For
505 example, if b is of type struct buffer * and v of type struct
506 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
507 != &v->size, and therefore "v->size = 1; b->size = 2; return
508 v->size;" must therefore return 1. This assumption is incorrect
509 for Emacs, since it type-puns struct Lisp_Vector * with many other
510 types. To fix this problem, this patch adds a new type struct
511 vectorlike_header that documents the constraints on layout of vectors
512 and pseudovectors, and helps optimizing compilers not get fooled
513 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
514 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
515 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
517 (XSETPVECTYPE): Rewrite in terms of new macro.
518 (XSETPVECTYPESIZE): New macro, specifying both type and size.
519 This is a bit clearer, and further avoids the possibility of
520 undesirable aliasing.
521 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
522 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
523 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
524 since Lisp_Subr is a special case (no "next" field).
525 (ASIZE): Now uses header.size rather than size. All
526 previous uses of XVECTOR (foo)->size replaced to use this macro,
527 to avoid the hassle of writing XVECTOR (foo)->header.size.
528 (struct vectorlike_header): New type.
529 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
530 object, to help avoid aliasing.
531 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
532 (SUBRP): Likewise, since Lisp_Subr is a special case.
533 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
534 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
535 (struct Lisp_Hash_Table): Combine first two members into a single
536 struct vectorlike_header member. All uses of "size" and "next" members
537 changed to be "header.size" and "header.next".
538 * buffer.h (struct buffer): Likewise.
539 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
540 * frame.h (struct frame): Likewise.
541 * process.h (struct Lisp_Process): Likewise.
542 * termhooks.h (struct terminal): Likewise.
543 * window.c (struct save_window_data, struct saved_window): Likewise.
544 * window.h (struct window): Likewise.
545 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
546 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
547 * buffer.c (init_buffer_once): Likewise.
548 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
550 * process.c (Fformat_network_address): Use local var for size,
553 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
555 Make the Lisp reader and string-to-float more consistent (Bug#8525)
556 * data.c (atof): Remove decl; no longer used or needed.
557 (digit_to_number): Move to lread.c.
558 (Fstring_to_number): Use new string_to_number function, to be
559 consistent with how the Lisp reader treats infinities and NaNs.
560 Do not assume that floating-point numbers represent EMACS_INT
561 without losing information; this is not true on most 64-bit hosts.
562 Avoid double-rounding errors, by insisting on integers when
563 parsing non-base-10 numbers, as the documentation specifies.
564 * lisp.h (string_to_number): New decl, replacing ...
565 (isfloat_string): Remove.
566 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
567 (read1): Do not accept +. and -. as integers; this
568 appears to have been a coding error. Similarly, do not accept
569 strings like +-1e0 as floating point numbers. Do not report
570 overflow for integer overflows unless the base is not 10 which
571 means we have no simple and reliable way to continue.
572 Break out the floating-point parsing into a new
573 function string_to_number, so that Fstring_to_number parses
574 floating point numbers consistently with the Lisp reader.
575 (digit_to_number): Moved here from data.c. Make it static inline.
576 (E_CHAR, EXP_INT): Remove, replacing with ...
577 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
578 (string_to_number): New function, replacing isfloat_string.
579 This function checks for valid syntax and produces the resulting
580 Lisp float number too. Rework it so that string-to-number
581 no longer mishandles examples like "1.0e+". Use strtoumax,
582 so that overflow for non-base-10 numbers is reported only when
583 there's no portable and simple way to convert to floating point.
585 * textprop.c (set_text_properties_1): Rewrite for clarity,
586 and to avoid GCC warning about integer overflow.
588 * intervals.h (struct interval): Use EMACS_INT for members
589 where EMACS_UINT might cause problems. See
590 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
591 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
592 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
594 (offset_intervals): Tell GCC not to worry about length overflow
595 when negating a negative length.
597 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
598 (overrun_check_free): Likewise.
600 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
601 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
604 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
605 (gnutls_make_error): Rename local to avoid shadowing.
606 (gnutls_emacs_global_deinit): ifdef out; not used.
607 (Fgnutls_boot): Use const for pointer to readonly storage.
608 Comment out unused local. Fix pointer signedness problems.
610 * lread.c (openp): Don't stuff size_t into an 'int'.
611 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
612 about possible signed overflow.
614 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
615 (GDK_KEY_g): Don't define if already defined.
616 (xg_prepare_tooltip): Avoid pointer signedness problem.
617 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
619 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
620 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
622 * xfns.c (Fx_window_property): Simplify a bit,
623 to make a bit faster and to avoid GCC 4.6.0 warning.
624 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
626 * fns.c (internal_equal): Don't assume size_t fits in int.
628 * alloc.c (compact_small_strings): Tighten assertion a little.
630 Replace pEd with more-general pI, and fix some printf arg casts.
631 * lisp.h (pI): New macro, generalizing old pEd macro to other
632 conversion specifiers. For example, use "...%"pI"d..." rather
634 (pEd): Remove. All uses replaced with similar uses of pI.
635 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
636 * alloc.c (check_pure_size): Don't overflow by converting size to int.
637 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
638 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
639 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
640 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
641 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
643 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
644 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
645 * print.c (safe_debug_print, print_object): Likewise.
646 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
648 Use pI instead of if-then-else-abort. Use %p to avoid casts,
649 avoiding the 0 flag, which is not portable.
650 * process.c (Fmake_network_process): Use pI to avoid cast.
651 * region-cache.c (pp_cache): Likewise.
652 * xdisp.c (decode_mode_spec): Likewise.
653 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
654 behavior on 64-bit hosts with printf arg.
655 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
656 (x_stop_queuing_selection_requests): Likewise.
657 (x_get_window_property): Don't truncate byte count to an 'int'
660 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
661 here, since it parses constructs like leading '-' and spaces,
662 which are not wanted; and it overflows with large numbers.
663 Instead, simply match F[0-9]+, which is what is wanted anyway.
665 * alloc.c: Remove unportable assumptions about struct layout.
666 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
667 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
668 (allocate_vectorlike, make_pure_vector): Use the new macros,
669 plus offsetof, to remove unportable assumptions about struct layout.
670 These assumptions hold on all porting targets that I know of, but
671 they are not guaranteed, they're easy to remove, and removing them
672 makes further changes easier.
674 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
675 This doesn't fix a bug but makes the code clearer.
676 (string_overrun_cookie): Now const. Use initializers that
677 don't formally overflow signed char, to avoid warnings.
678 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
679 can cause Emacs to crash when string overrun checking is enabled.
680 (allocate_buffer): Don't assume sizeof (struct buffer) is a
681 multiple of sizeof (EMACS_INT); it need not be, if
682 alignof(EMACS_INT) < sizeof (EMACS_INT).
683 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
685 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
687 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
689 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
691 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
692 supposed to be handshaking. (Bug#8556)
693 Reported by Paul Eggert <eggert@cs.ucla.edu>.
695 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
697 * lisp.h (Qdebug): List symbol.
698 * eval.c (Qdebug): Restore global linkage.
699 * keyboard.c (debug-on-event): New variable.
700 (handle_user_signal): Break into debugger when debug-on-event
701 matches the current signal symbol.
703 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
705 * alloc.c (check_sblock, check_string_bytes)
706 (check_string_free_list): Convert to standard C.
708 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
710 * w32.c (emacs_gnutls_push): Fix typo.
712 2011-04-25 Eli Zaretskii <eliz@gnu.org>
714 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
715 "cast to pointer from integer of different size".
717 Improve doprnt and its use in verror. (Bug#8545)
718 * doprnt.c (doprnt): Document the set of format control sequences
719 supported by the function. Use SAFE_ALLOCA instead of always
722 * eval.c (verror): Don't limit the buffer size at size_max-1, that
723 is one byte too soon. Don't use xrealloc; instead xfree and
726 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
728 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
731 * gnutls.c: Renamed global_initialized to
732 gnutls_global_initialized. Added internals for the
733 :verify-hostname-error, :verify-error, and :verify-flags
734 parameters of `gnutls-boot' and documented those parameters in the
735 docstring. Start callback support.
736 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
737 unless a fatal error occured. Call gnutls_alert_send_appropriate
738 on error. Return error code.
739 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
740 (emacs_gnutls_read): Likewise.
741 (Fgnutls_boot): Return handshake error code.
742 (emacs_gnutls_handle_error): New function.
743 (wsaerror_to_errno): Likewise.
745 * w32.h (emacs_gnutls_pull): Add prototype.
746 (emacs_gnutls_push): Likewise.
748 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
749 (emacs_gnutls_push): Likewise.
751 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
753 * process.c (wait_reading_process_output): Check if GnuTLS
754 buffered some data internally if no FDs are set for TLS
757 * makefile.w32-in (OBJ2): Add gnutls.$(O).
758 (LIBS): Link to USER_LIBS.
759 ($(BLD)/gnutls.$(0)): New target.
761 2011-04-24 Eli Zaretskii <eliz@gnu.org>
763 * xdisp.c (handle_single_display_spec): Rename the
764 display_replaced_before_p argument into display_replaced_p, to
765 make it consistent with the commentary. Fix typos in the
768 * textprop.c (syms_of_textprop): Remove dead code.
769 (copy_text_properties): Delete obsolete commentary about an
770 interface that was deleted long ago. Fix typos in the description
773 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
774 to changes in oldXMenu/XMenu.h from 2011-04-16.
775 <menu_help_message, prev_menu_help_message>: Constify.
776 (IT_menu_make_room): menu->help_text is now `const char **';
779 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
780 to changes in oldXMenu/XMenu.h from 2011-04-16.
781 (struct XMenu): Declare `help_text' `const char **'.
783 * xfaces.c <Qunspecified>: Make extern again.
785 * syntax.c: Include sys/types.h before including regex.h, as
788 * doc.c (get_doc_string): Improve the format passed to `error'.
790 * doprnt.c (doprnt): Improve commentary.
792 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
794 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
797 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
798 changes in globals.h immediately force recompilation.
799 (TAGS): Depend on $(CURDIR)/m/intel386.h and
800 $(CURDIR)/s/ms-w32.h.
801 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
803 * character.c (Fchar_direction): Function deleted.
804 (syms_of_character): Don't defsubr it.
805 <char-direction-table>: Deleted.
807 2011-04-23 Eli Zaretskii <eliz@gnu.org>
809 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
810 * doprnt.c: Include limits.h.
811 (SIZE_MAX): New macro.
812 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
813 local variables are now size_t instead of int or unsigned.
814 Improve overflow protection. Support `l' modifier for integer
815 conversions. Support %l conversion. Don't assume an EMACS_INT
816 argument for integer conversions and for %c.
818 * lisp.h (doprnt): Restore prototype.
820 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
823 * Makefile.in (base_obj): Add back doprnt.o.
825 * deps.mk (doprnt.o): Add back prerequisites.
826 (callint.o): Depend on character.h.
828 * eval.c (internal_lisp_condition_case): Include the handler
829 representation in the error message.
830 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
831 when breaking from the loop.
833 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
835 * callint.c (Fcall_interactively): When displaying error message
836 about invalid control letter, pass the character's codepoint, not
837 a pointer to its multibyte form. Improve display of the character
838 in octal and display also its hex code.
840 * character.c (char_string): Use %x to display the (unsigned)
841 codepoint of an invalid character, to avoid displaying a bogus
844 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
845 `error', not SYMBOL_NAME itself.
847 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
848 character arguments to `error'.
850 * charset.c (check_iso_charset_parameter): Fix incorrect argument
851 to `error' in error message about FINAL_CHAR argument. Make sure
852 FINAL_CHAR is a character, and use %c when it is passed as
855 2011-04-23 Eli Zaretskii <eliz@gnu.org>
857 * s/ms-w32.h (localtime): Redirect to sys_localtime.
859 * w32.c: Include <time.h>.
860 (sys_localtime): New function.
862 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
864 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
866 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
868 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
870 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
873 2011-04-19 Eli Zaretskii <eliz@gnu.org>
875 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
876 gl_state.e_property when gl_state.object is Qt.
878 * insdel.c (make_gap_larger): Remove limitation of buffer size
881 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
883 * xdisp.c (lookup_glyphless_char_display)
884 (produce_glyphless_glyph): Handle cons cell entry in
885 glyphless-char-display.
886 (Vglyphless_char_display): Document it.
888 * term.c (produce_glyphless_glyph): Handle cons cell entry in
889 glyphless-char-display.
891 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
893 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
895 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
897 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
898 definition for no-X builds.
900 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
902 Static checks with GCC 4.6.0 and non-default toolkits.
904 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
906 * process.c (keyboard_bit_set): Define only if SIGIO.
907 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
908 (send_process): Repair possible setjmp clobbering.
910 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
912 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
914 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
916 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
917 Define only if needed.
919 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
920 by pacifying GCC about it. Maybe it's time to retire it?
921 * xfaces.c (USG, __TIMEVAL__): Likewise.
923 * dispextern.h (struct redisplay_interface): Rename param
925 * termhooks.h (struct terminal): Likewise.
926 * xterm.c (xembed_send_message): Likewise.
928 * insdel.c (make_gap_smaller): Define only if
929 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
931 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
934 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
935 so that we aren't warned about unused symbols.
937 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
939 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
941 * xfns.c (x_real_positions): Mark locals as initialized.
943 * xmenu.c (xmenu_show): Don't use uninitialized vars.
945 * xterm.c: Fix problems found by static analysis with other toolkits.
946 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
947 (x_dispatch_event): Declare static if USE_GTK, and
948 define if USE_GTK || USE_X_TOOLKIT.
949 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
950 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
951 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
952 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
954 * xmenu.c (menu_help_callback): Pointer type fixes.
955 Use const pointers when pointing at readonly data. Avoid pointer
957 (FALSE): Remove unused macro.
958 (update_frame_menubar): Remove unused decl.
960 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
962 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
963 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
964 (single_menu_item): Rename local to avoid shadowing.
966 * keyboard.c (make_lispy_event): Remove unused local var.
968 * frame.c, frame.h (x_get_resource_string): Bring this back, but
969 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
971 * bitmaps: Change bitmaps from unsigned char back to the X11
972 compatible char. Avoid the old compiler warnings about
973 out-of-range initializers by using, for example, '\xab' rather
976 * xgselect.c (xgselect_initialize): Check vs interface
977 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
979 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
981 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
984 * fns.c (vector): Remove; this old hack is no longer needed.
986 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
988 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
990 * xrdb.c (x_load_resources): Omit unused local.
992 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
993 (x_window): Rename locals to avoid shadowing.
994 (USG): Use the kludged USG macro, to pacify gcc.
996 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
997 (x_term_init): Remove local to avoid shadowing.
999 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1001 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1002 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1004 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1006 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1008 Fix regex.c, syntax.c and friends for buffers > 2GB.
1009 * syntax.h (struct gl_state_s): Declare character position members
1012 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1014 * textprop.c (verify_interval_modification, interval_of): Declare
1015 arguments EMACS_INT.
1017 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1020 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1022 * indent.c (Fvertical_motion): Local variable it_start is now
1025 * regex.c (re_match, re_match_2, re_match_2_internal)
1026 (bcmp_translate, regcomp, regexec, print_double_string)
1027 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1028 (re_compile_pattern, re_exec): Declare arguments and local
1029 variables `size_t' and `ssize_t' and return values `regoff_t', as
1031 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1032 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1033 <compile_stack_type>: `size' and `avail' are now `size_t'.
1035 * regex.h <regoff_t>: Use ssize_t, not int.
1036 (re_search, re_search_2, re_match, re_match_2): Arguments that
1037 specify buffer/string position and length are now ssize_t and
1038 size_t. Return type is regoff_t.
1040 2011-04-16 Ben Key <bkey76@gmail.com>
1042 * nsfont.m: Fixed bugs in ns_get_family and
1043 ns_descriptor_to_entity that were caused by using free to
1044 deallocate memory blocks that were allocated by xmalloc (via
1045 xstrdup). This caused Emacs to crash when compiled with
1046 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1047 --enable-checking=xmallocoverrun). xfree is now used to
1048 deallocate these memory blocks.
1050 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1052 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1054 emacs_write: Accept and return EMACS_INT for sizes.
1055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1057 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1058 Accept and return EMACS_INT.
1059 (emacs_gnutls_write): Return the number of bytes written on
1061 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1062 (emacs_read, emacs_write): Remove check for negative size, as the
1063 Emacs source code has been audited now.
1064 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1065 (emacs_read, emacs_write): Use it.
1066 * process.c (send_process): Adjust to the new signatures of
1067 emacs_write and emacs_gnutls_write. Do not attempt to store
1068 a byte offset into an 'int'; it might overflow.
1069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1071 * sound.c: Don't assume sizes fit in 'int'.
1072 (struct sound_device.period_size, alsa_period_size):
1073 Return EMACS_INT, not int.
1074 (struct sound_device.write, vox_write, alsa_write):
1075 Accept EMACS_INT, not int.
1076 (wav_play, au_play): Use EMACS_INT to store sizes and to
1077 record read return values.
1079 2011-04-15 Ben Key <bkey76@gmail.com>
1081 * keyboard.c (Qundefined): Don't declare static since it is used
1083 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1084 static since they are used in nsfont.m.
1086 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1088 * process.c (Qprocessp): Don't declare static.
1089 * lisp.h (Qprocessp): Declare again.
1091 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1093 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1095 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1097 Improve C-level modularity by making more things 'static'.
1099 Don't publish debugger-only interfaces to other modules.
1100 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1101 (verify_bytepos, count_markers): Move decls to the only modules
1103 * region-cache.h (pp_cache): Likewise.
1104 * window.h (check_all_windows): Likewise.
1105 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1107 * sysdep.c (croak): Now static, if
1108 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1109 * syssignal.h (croak): Declare only if not static.
1111 * alloc.c (refill_memory_reserve): Now static if
1112 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1113 * lisp.h (refill_memory_reserve): Declare only if not static.
1115 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1116 Define only if USE_LUCID.
1118 * xrdb.c (x_customization_string, x_rm_string): Now static.
1120 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1121 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1123 * xdisp.c (draw_row_with_mouse_face): Now static.
1124 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1126 * window.h (check_all_windows): Mark externally visible.
1128 * window.c (window_deletion_count): Now static.
1130 * undo.c: Make symbols static if they're not exported.
1131 (last_undo_buffer, last_boundary_position, pending_boundary):
1134 * textprop.c (interval_insert_behind_hooks): Now static.
1135 (interval_insert_in_front_hooks): Likewise.
1137 * term.c: Make symbols static if they're not exported.
1138 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1139 (max_frame_lines, tty_set_terminal_modes):
1140 (tty_reset_terminal_modes, tty_turn_off_highlight):
1141 (get_tty_terminal): Now static.
1142 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1143 * termhooks.h (term_mouse_moveto): Do not declare if
1145 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1146 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1148 * sysdep.c: Make symbols static if they're not exported.
1149 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1151 (sigprocmask_set, full_mask): Remove; unused.
1152 (wait_debugging): Mark as visible.
1153 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1154 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1156 * syntax.c (syntax_temp): Define only if !__GNUC__.
1158 * sound.c (current_sound_device, current_sound): Now static.
1160 * search.c (searchbufs, searchbuf_head): Now static.
1162 * scroll.c (scroll_cost): Remove; unused.
1163 * dispextern.h (scroll_cost): Remove decl.
1165 * region-cache.h (pp_cache): Mark as externally visible.
1167 * process.c: Make symbols static if they're not exported.
1168 (process_tick, update_tick, create_process, chan_process):
1169 (Vprocess_alist, proc_buffered_char, datagram_access):
1170 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1171 (deactivate_process): Mark defn as static, as well as decl.
1172 * lisp.h (create_process): Remove decl.
1173 * process.h (chan_process, Vprocess_alist): Remove decls.
1175 * print.c: Make symbols static if they're not exported.
1176 (print_depth, new_backquote_output, being_printed, print_buffer):
1177 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1178 (print_interval, print_number_index, initial_stderr_stream):
1180 * lisp.h (Fprinc): Remove decl.
1181 (debug_output_compilation_hack): Mark as externally visible.
1183 * sysdep.c (croak): Move decl from here to syssignal.h.
1184 * syssignal.h (croak): Put it here, so the API can be checked when
1185 'croak' is called from dissociate_if_controlling_tty.
1187 * minibuf.c: Make symbols static if they're not exported.
1188 (minibuf_save_list, choose_minibuf_frame): Now static.
1189 * lisp.h (choose_minibuf_frame): Remove decl.
1191 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1193 * lread.c: Make symbols static if they're not exported.
1194 (read_objects, initial_obarray, oblookup_last_bucket_number):
1196 (make_symbol): Remove; unused.
1197 * lisp.h (initial_obarray, make_symbol): Remove decls.
1199 * keyboard.c: Make symbols static if they're not exported.
1200 (single_kboard, recent_keys_index, total_keys, recent_keys):
1201 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1202 (this_single_command_key_start, echoing, last_auto_save):
1203 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1204 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1205 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1206 (Vlispy_mouse_stem, double_click_count):
1208 (force_auto_save_soon): Define only if SIGDANGER.
1209 (ignore_mouse_drag_p): Now static if
1210 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1211 (print_help): Remove; unused.
1212 (stop_character, last_timer_event): Mark as externally visible.
1213 * keyboard.h (ignore_mouse_drag_p): Declare only if
1214 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1215 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1216 * lisp.h (echoing): Remove decl.
1217 (force_auto_save_soon): Declare only if SIGDANGER.
1218 * xdisp.c (redisplay_window): Simplify code, to make it more
1219 obvious that ignore_mouse_drag_p is not accessed if !defined
1220 USE_GTK && !defined HAVE_NS.
1222 * intervals.c: Make symbols static if they're not exported.
1223 (merge_properties_sticky, merge_interval_right, delete_interval):
1225 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1227 * insdel.c: Make symbols static if they're not exported.
1228 However, leave prepare_to_modify_buffer alone. It's never
1229 called from outside this function, but that appears to be a bug.
1230 (combine_after_change_list, combine_after_change_buffer):
1231 (adjust_after_replace, signal_before_change): Now static.
1232 (adjust_after_replace_noundo): Remove; unused.
1233 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1234 (signal_before_change): Remove decls.
1236 * indent.c (val_compute_motion, val_vmotion): Now static.
1238 * image.c: Make symbols static if they're not exported.
1239 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1241 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1242 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1244 * fringe.c (standard_bitmaps): Now static.
1245 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1247 * frame.c: Make symbols static if they're not exported.
1248 (x_report_frame_params, make_terminal_frame): Now static.
1249 (get_frame_param): Now static, unless HAVE_NS.
1250 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1251 (x_get_resource_string): Remove; not used.
1252 * frame.h (make_terminal_frame, x_report_frame_params):
1253 (x_get_resource_string); Remove decls.
1254 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1255 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1257 * font.c, fontset.c: Make symbols static if they're not exported.
1258 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1259 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1260 * font.c (font_close_object): Now static.
1261 * font.h (font_close_object): Remove.
1262 * fontset.c (FONTSET_OBJLIST): Remove.
1263 (free_realized_fontset) #if-0 the body, which does nothing.
1264 (face_suitable_for_char_p): #if-0, as it's never called.
1265 * fontset.h (face_suitable_for_char_p): Remove decl.
1266 * xfaces.c (face_at_string_position): Use
1267 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1268 since 0 is always ASCII.
1270 * fns.c (weak_hash_tables): Now static.
1272 * fileio.c: Make symbols static if they're not exported.
1273 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1274 (Vwrite_region_annotation_buffers): Now static.
1276 * eval.c: Make symbols static if they're not exported.
1277 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1278 * lisp.h (backtrace_list): Remove decl.
1280 * emacs.c: Make symbols static if they're not exported.
1281 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1282 (fatal_error_code, fatal_error_signal_hook, standard_args):
1284 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1285 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1286 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1287 * lisp.h (fatal_error_signal_hook): Remove decl.
1288 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1290 * editfns.c: Move a (normally-unused) function to its only use.
1291 * editfns.c, lisp.h (get_operating_system_release): Remove.
1292 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1293 worth the hassle of breaking this out.
1295 * xterm.c: Make symbols static if they're not exported.
1296 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1297 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1298 (x_destroy_window, x_delete_display):
1300 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1301 (x_mouse_leave): Remove; unused.
1302 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1303 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1304 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1306 (x_mouse_leave): Declare only if WINDOWSNT.
1307 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1308 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1311 * ftxfont.c: Make symbols static if they're not exported.
1312 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1314 * font.h (ftxfont_driver): Likewise.
1316 * xfns.c: Make symbols static if they're not exported.
1317 (x_last_font_name, x_display_info_for_name):
1318 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1319 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1320 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1321 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1322 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1323 (last_show_tip_args): Now static.
1324 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1325 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1326 (x_screen_planes): Remove; unused.
1327 * dispextern.h (x_screen_planes): Remove decl.
1329 * dispnew.c: Make symbols static if they're not exported.
1330 * dispextern.h (redraw_garbaged_frames, scrolling):
1331 (increment_row_positions): Remove.
1332 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1333 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1335 (redraw_garbaged_frames): Remove; unused.
1337 * xfaces.c: Make symbols static if they're not exported.
1338 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1340 * xterm.h (defined_color): Remove decls.
1341 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1342 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1343 (menu_face_changed_default, defined_color, free_realized_face):
1344 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1345 (ascii_face_of_lisp_face): Remove; unused.
1347 * xdisp.c: Make symbols static if they're not exported.
1348 * dispextern.h (scratch_glyph_row, window_box_edges):
1349 (glyph_to_pixel_coords, set_cursor_from_row):
1350 (get_next_display_element, set_iterator_to_next):
1351 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1352 (show_mouse_face): Remove decls
1353 * frame.h (message_buf_print): Likewise.
1354 * lisp.h (pop_message, set_message, check_point_in_composition):
1356 * xterm.h (set_vertical_scroll_bar): Likewise.
1357 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1358 (message_buf_print, scratch_glyph_row, displayed_buffer):
1359 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1360 (get_next_display_element, show_mouse_face, window_box_edges):
1361 (frame_to_window_pixel_xy, check_point_in_composition):
1362 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1363 (glyph_to_pixel_coords): Remove; unused.
1365 * dired.c (file_name_completion): Now static.
1367 * dbusbind.c (xd_in_read_queued_messages): Now static.
1369 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1370 * data.c (circular_list_error): Remove.
1372 * commands.h (last_point_position, last_point_position_buffer):
1373 (last_point_position_window): Remove decls.
1374 * keyboard.c: Make these variables static.
1376 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1378 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1379 (iso_code_class, detect_coding, code_convert_region): Now static.
1380 (encode_coding_gap): Remove; unused.
1382 * chartab.c (chartab_chars, chartab_bits): Now static.
1384 * charset.h (charset_iso_8859_1): Remove decl.
1385 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1388 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1389 * ccl.c (Vccl_program_table): Now static.
1390 (check_ccl_update): Remove; unused.
1392 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1393 * category.h: ... from here.
1394 * category.c (check_category_table, set_category_set): Now static.
1396 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1397 * lisp.h: Remove these decls.
1399 * buffer.c (buffer_count): Remove unused var.
1401 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1402 so that it's not optimized away.
1403 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1404 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1405 exported only to the debugger.
1407 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1408 * atimer.h (run_all_atimers): Removed; not exported.
1410 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1411 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1412 was inaccessible from Lisp.
1413 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1414 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1416 alloc.c: Import and export fewer symbols, and remove unused items.
1417 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1419 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1420 it's not optimized away by whole-program optimization.
1421 (message_enable_multibyte, free_misc): Remove.
1422 (catchlist, handlerlist, mark_backtrace):
1423 Declare only if BYTE_MARK_STACK.
1424 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1425 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1426 (message_enable_multibyte): Remove decl.
1427 (free_misc, interval_free_list, float_block, float_block_index):
1428 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1429 (cons_free_list, last_marked_index):
1431 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1432 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1433 (mark_backtrace): Define only if BYTE_MARK_STACK.
1434 * xdisp.c (message_enable_multibyte): Now static.
1436 Declare Lisp_Object Q* variables to be 'static' if not exported.
1437 This makes it easier for human readers (and static analyzers)
1438 to see whether these variables are used from other modules.
1439 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1440 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1441 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1442 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1443 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1444 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1445 * xmenu.c, xselect.c:
1446 Declare Q* vars static if they are not used in other modules.
1447 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1448 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1449 Remove decls of unexported vars.
1450 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1452 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1454 Make Emacs functions such as Fatom 'static' by default.
1455 This makes it easier for human readers (and static analyzers)
1456 to see whether these functions can be called from other modules.
1457 DEFUN now defines a static function. To make the function external
1458 so that it can be used in other C modules, use the new macro DEFUE.
1459 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1460 (Finit_image_library):
1461 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1462 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1463 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1464 Remove decls, since these functions are now static.
1465 (Funintern, Fget_internal_run_time): New decls, since these functions
1466 were already external.
1468 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1469 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1470 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1471 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1472 * keyboard.c, keymap.c, lread.c:
1473 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1474 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1475 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1476 Mark functions with DEFUE instead of DEFUN,
1477 if they are used in other modules.
1478 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1479 decls for now-static functions.
1480 * buffer.h (Fdelete_overlay): Remove decl.
1481 * callproc.c (Fgetenv_internal): Mark as internal.
1482 * composite.c (Fremove_list_of_text_properties): Remove decl.
1483 (Fcomposition_get_gstring): New forward static decl.
1484 * composite.h (Fcomposite_get_gstring): Remove decl.
1485 * dired.c (Ffile_attributes): New forward static decl.
1486 * doc.c (Fdocumntation_property): New forward static decl.
1487 * eval.c (Ffetch_bytecode): New forward static decl.
1488 (Funintern): Remove extern decl; now in .h file where it belongs.
1489 * fileio.c (Fmake_symbolic_link): New forward static decl.
1490 * image.c (Finit_image_library): New forward static decl.
1491 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1492 * intervals.h (Fprevious_property_change):
1493 (Fremove_list_of_text_properties): Remove decls.
1494 * keyboard.c (Fthis_command_keys): Remove decl.
1495 (Fcommand_execute): New forward static decl.
1496 * keymap.c (Flookup_key): New forward static decl.
1497 (Fcopy_keymap): Now static.
1498 * keymap.h (Flookup_key): Remove decl.
1499 * process.c (Fget_process): New forward static decl.
1500 (Fprocess_datagram_address): Mark as internal.
1501 * syntax.c (Fsyntax_table_p): New forward static decl.
1502 (skip_chars): Remove duplicate decl.
1503 * textprop.c (Fprevious_property_change): New forward static decl.
1504 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1506 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1507 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1509 * editfns.c (Fformat): Remove unreachable code.
1511 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1513 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1516 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1518 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1519 when at ZV. (Bug#8487)
1521 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1523 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1525 * keyboard.c (parse_tool_bar_item): Likewise.
1526 * sound.c (sound_cleanup, alsa_close): Likewise.
1527 * termcap.c (tgetent): Likewise.
1528 * xfns.c (x_default_font_parameter): Likewise.
1529 * xsettings.c (read_and_apply_settings): Likewise.
1531 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1532 (overrun_check_free): Protoize.
1534 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1536 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1537 since callers should never pass a negative size.
1538 Change the signature to match that of plain 'read' and 'write'; see
1539 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1540 * lisp.h: Update prototypes of emacs_write and emacs_read.
1542 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1544 * xdisp.c (redisplay_window): Don't try to determine the character
1545 position of the scroll margin if the window start point w->startp
1546 is outside the buffer's accessible region. (Bug#8468)
1548 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1550 Fix write-region and its subroutines for buffers > 2GB.
1551 * fileio.c (a_write, e_write): Modify declaration of arguments and
1552 local variables to support buffers larger than 2GB.
1553 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1555 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1556 argument, local variables, and return value.
1558 * lisp.h: Update prototypes of emacs_write and emacs_read.
1560 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1562 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1564 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1566 Fix more problems found by GCC 4.6.0's static checks.
1568 * xdisp.c (vmessage): Use a better test for character truncation.
1570 * charset.c (load_charset_map): <, not <=, for optimization,
1571 and to avoid potential problems with integer overflow.
1572 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1573 * casetab.c (set_identity, shuffle): Likewise.
1574 * editfns.c (Fformat): Likewise.
1575 * syntax.c (skip_chars): Likewise.
1577 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1578 This also lets GCC 4.6.0 generate slightly better loop code.
1580 * callint.c (Fcall_interactively): <, not <=, for optimization.
1581 (Fcall_interactively): Count the number of arguments produced,
1582 not the number of arguments given. This is simpler and lets GCC
1583 4.6.0 generate slightly better code.
1585 * ftfont.c: Distingish more carefully between FcChar8 and char.
1586 The previous code passed unsigned char * to a functions like
1587 strlen and xstrcasecmp that expect char *, which does not
1588 conform to the C standard.
1589 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1590 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1591 char * when the C standard requires it.
1593 * keyboard.c (read_char): Remove unused var.
1595 * eval.c: Port to Windows vsnprintf (Bug#8435).
1597 (SIZE_MAX): Define if the headers do not.
1598 (verror): Do not give up if vsnprintf returns a negative count.
1599 Instead, grow the buffer. This ports to Windows vsnprintf, which
1600 does not conform to C99. Problem reported by Eli Zaretskii.
1601 Also, simplify the allocation scheme, by avoiding the need for
1602 calling realloc, and removing the ALLOCATED variable.
1604 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1606 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1607 But keep the doprint source code for now, as we might revamp it
1608 and use it again (Bug#8435).
1609 * lisp.h (doprnt): Remove.
1610 * Makefile.in (base_obj): Remove doprnt.o.
1611 * deps.mk (doprnt.o): Remove.
1613 error: Print 32- and 64-bit integers portably (Bug#8435).
1614 Without this change, on typical 64-bit hosts error ("...%d...", N)
1615 was used to print both 32- and 64-bit integers N, which relied on
1617 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1619 * lisp.h (error, verror): Mark as printf-like functions.
1620 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1621 Report overflow in size calculations when allocating printf buffer.
1622 Do not truncate output string at its first null byte.
1623 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1624 Truncate the output at a character boundary, since vsnprintf does not
1626 * charset.c (check_iso_charset_parameter): Convert internal
1627 character to string before calling 'error', since %c now has the
1629 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1630 overflow when computing char to be passed to 'error'. Do not
1631 pass Lisp_Object to 'error'; pass the integer instead.
1632 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1633 formatted with plain %d.
1635 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1637 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1639 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1641 * xterm.c (x_catch_errors): Remove duplicate declaration.
1643 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1645 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1647 2011-04-10 Jim Meyering <meyering@redhat.com>
1649 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1650 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1651 return ssize_t not "int", and use size_t as the buffer length.
1652 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1653 * gnutls.h: Update declarations.
1654 * process.c (read_process_output): Use ssize_t, to match.
1655 (send_process): Likewise.
1657 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1659 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1661 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1663 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1664 unsigned char, to match FcChar8 type definition.
1666 * xterm.c (handle_one_xevent):
1667 * xmenu.c (create_and_show_popup_menu):
1668 * xselect.c (x_decline_selection_request)
1669 (x_reply_selection_request): Avoid type-punned deref of X events.
1671 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1673 Fix some uses of `int' instead of EMACS_INT.
1674 * search.c (string_match_1, fast_string_match)
1675 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1676 (scan_buffer, find_next_newline_no_quit)
1677 (find_before_next_newline, search_command, Freplace_match)
1678 (Fmatch_data): Make some `int' variables be EMACS_INT.
1680 * xdisp.c (display_count_lines): 3rd argument and return value now
1681 EMACS_INT. All callers changed.
1682 (pint2hrstr): Last argument is now EMACS_INT.
1684 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1685 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1686 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1687 (decode_coding_utf_16, decode_coding_emacs_mule)
1688 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1689 (decode_coding_ccl, decode_coding_charset)
1690 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1691 (decode_coding_iso_2022, decode_coding_emacs_mule)
1692 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1693 <char_offset, last_offset>: Declare EMACS_INT.
1694 (encode_coding_utf_8, encode_coding_utf_16)
1695 (encode_coding_emacs_mule, encode_invocation_designation)
1696 (encode_designation_at_bol, encode_coding_iso_2022)
1697 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1698 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1700 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1701 (encode_invocation_designation): Last argument P_NCHARS is now
1703 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1704 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1706 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1709 * ccl.c (Fccl_execute_on_string): Declare some variables
1712 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1714 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1716 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1718 * process.c (Fformat_network_address): Doc fix.
1720 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1722 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1724 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1726 * keyboard.c (read_char): Call Lisp function help-form-show,
1727 instead of using internal_with_output_to_temp_buffer.
1728 (Qhelp_form_show): New var.
1729 (syms_of_keyboard): Use DEFSYM macro.
1731 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1733 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1735 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1737 * process.c (Flist_processes): Removed to Lisp.
1738 (list_processes_1): Deleted.
1740 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1742 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1744 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1746 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1748 Fix more problems found by GCC 4.6.0's static checks.
1750 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1752 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1754 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1756 * xdisp.c (vmessage): Mark as a printf-like function.
1758 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1760 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1762 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1763 printf-like functions.
1764 (tiff_load): Add casts to remove these marks before passing them
1765 to system-supplied API.
1767 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1769 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1770 This avoids several warnings with gcc -Wstrict-overflow.
1771 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1772 directly, rather than having caller test rule sign. This avoids
1773 some unnecessary tests.
1774 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1775 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1776 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1778 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1779 (xfont_open): Avoid unnecessary tests.
1781 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1783 * composite.h, composite.c (composition_gstring_put_cache):
1784 Use EMACS_INT, not int, for length.
1786 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1787 breaking out part of COMPOSITION_DECODE_RULE.
1788 (COMPOSITION_DECODE_RULE): Use it.
1789 * composite.c (get_composition_id): Remove unused local vars,
1790 by using the new macro.
1792 * textprop.c (set_text_properties_1): Change while to do-while,
1793 since the condition is always true at first.
1795 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1796 (interval_deletion_adjustment): Return unsigned value.
1799 * process.c (list_processes_1, create_pty, read_process_output):
1800 (exec_sentinel): Remove vars that were set but not used.
1801 (create_pty): Remove unnecessary "volatile"s.
1802 (Fnetwork_interface_info): Avoid possibility of int overflow.
1803 (read_process_output): Do adaptive read buffering even if carryover.
1804 (read_process_output): Simplify nbytes computation if buffered.
1806 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1808 * syntax.c (scan_words): Remove var that was set but not used.
1809 (update_syntax_table): Use unsigned instead of int.
1811 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1812 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1813 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1815 * print.c (print_error_message): Avoid int overflow.
1817 * font.c (font_list_entities): Redo for clarity,
1818 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1820 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1821 (font_score): Avoid potential overflow in diff calculation.
1823 * fns.c (substring_both): Remove var that is set but not used.
1824 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1826 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1828 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1829 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1830 can always succeed if overflow has undefined behavior.
1832 * search.c (boyer_moore, wordify): Remove vars set but not used.
1833 (wordify): Omit three unnecessary tests.
1835 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1836 All callers changed. This avoids the need for an unused var.
1838 * casefiddle.c (casify_region): Remove var that is set but not used.
1840 * dired.c (file_name_completion): Remove var that is set but not used.
1842 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1844 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1845 (Finsert_file_contents): Remove unnecessary code checking fd.
1847 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1848 Check for integer overflow on size calculations.
1850 * buffer.c (Fprevious_overlay_change): Remove var that is set
1853 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1854 Remove vars that are set but not used.
1855 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1856 (timer_check_2): Mark vars as initialized.
1858 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1860 * image.c (lookup_image): Remove var that is set but not used.
1861 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1863 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1864 that are set but not used.
1866 * xfns.c (make_invisible_cursor): Don't return garbage
1867 if XCreateBitmapFromData fails (Bug#8410).
1869 * xselect.c (x_get_local_selection, x_handle_property_notify):
1870 Remove vars that are set but not used.
1872 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1873 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1875 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1876 Remove var that is set but not used.
1877 (scroll_bar_windows_size): Now size_t, not int.
1878 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1881 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1882 (map_tty_color) [!defined MSDOS]: Likewise.
1884 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1886 * coding.c: Remove vars that are set but not used.
1887 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1888 All callers changed.
1889 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1890 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1891 (decode_coding_charset): Remove vars that are set but not used.
1893 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1894 that is set but not used.
1896 * print.c (print_object): Remove var that is set but not used.
1898 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1899 The gnulib version avoids calling malloc in the usual case,
1900 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1901 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1902 * filelock.c (current_lock_owner): Likewise.
1903 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1904 * sysdep.c: Include allocator.h, careadlinkat.h.
1905 (emacs_no_realloc_allocator): New static constant.
1906 (emacs_readlink): New function.
1907 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1908 ../lib/careadlinkat.h.
1910 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1912 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1913 first non-nil return value).
1915 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1917 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1918 if not defined (Bug#8403).
1920 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1922 * xdisp.c (display_count_lines): Remove parameter `start',
1923 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1924 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1925 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1926 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1927 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1928 and thereabouts. All callers changed.
1929 (get_per_char_metric): Remove parameter `f', unused since
1930 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1932 2011-04-02 Jim Meyering <meyering@redhat.com>
1934 do not dereference NULL upon failed strdup
1935 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1936 (ns_get_family): Likewise.
1938 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1940 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1942 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1944 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1947 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1949 Add lexical binding.
1951 * window.c (Ftemp_output_buffer_show): New fun.
1952 (Fsave_window_excursion):
1953 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1955 * lread.c (lisp_file_lexically_bound_p): New function.
1956 (Fload): Bind Qlexical_binding.
1957 (readevalloop): Remove `evalfun' arg.
1958 Bind Qinternal_interpreter_environment.
1959 (Feval_buffer): Bind Qlexical_binding.
1960 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1962 (syms_of_lread): Declare `lexical-binding'.
1964 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1966 * keyboard.c (eval_dyn): New fun.
1967 (menu_item_eval_property): Use it.
1969 * image.c (parse_image_spec): Use Ffunctionp.
1971 * fns.c (concat, mapcar1): Accept byte-code-functions.
1973 * eval.c (Fsetq): Handle lexical vars.
1974 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1975 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1976 (FletX, Flet): Obey lexical binding.
1977 (Fcommandp): Handle closures.
1978 (Feval): New `lexical' arg.
1979 (eval_sub): New function extracted from Feval. Use it almost
1980 everywhere where Feval was used. Look up vars in lexical env.
1982 (Ffunctionp): Move from subr.el.
1983 (Ffuncall): Handle closures.
1984 (apply_lambda): Remove `eval_flags'.
1985 (funcall_lambda): Handle closures and new byte-code-functions.
1986 (Fspecial_variable_p): New function.
1987 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1988 but without exporting it to Lisp.
1990 * doc.c (Fdocumentation, store_function_docstring):
1991 * data.c (Finteractive_form): Handle closures.
1993 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1996 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1998 (exec_byte_code): New function extracted from Fbyte_code to handle new
1999 calling convention for byte-code-functions. Add new byte-codes.
2001 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2003 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2005 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2007 * xdisp.c (redisplay_internal): Fix prototype.
2009 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (SCROLL_LIMIT): New macro.
2012 (try_scrolling): Use it when setting scroll_limit. Limit
2013 scrolling to 100 screen lines.
2014 (redisplay_window): Even when falling back on "recentering",
2015 position point in the window according to scroll-conservatively,
2016 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2018 (try_scrolling): When point is above the window, allow searching
2019 as far as scroll_max, or one screenful, to compute vertical
2020 distance from PT to the scroll margin position. This prevents
2021 try_scrolling from unnecessarily failing when
2022 scroll-conservatively is set to a value slightly larger than the
2023 window height. Clean up the case of PT below the margin at bottom
2024 of window: scroll_max can no longer be INT_MAX. When aggressive
2025 scrolling is in use, don't let point enter the opposite scroll
2026 margin as result of the scroll.
2027 (syms_of_xdisp) <scroll-conservatively>: Document the
2028 threshold of 100 lines for never-recentering scrolling.
2030 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2032 * dispextern.h (move_it_by_lines):
2033 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2034 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2035 (message_log_check_duplicate): Remove parameters `prev_bol' and
2036 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2037 (redisplay_internal): Remove parameter `preserve_echo_area',
2038 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2040 * indent.c (Fvertical_motion):
2041 * window.c (window_scroll_pixel_based, Frecenter):
2042 Don't pass `need_y_p' to `move_it_by_lines'.
2044 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2046 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2047 steal a few bits to be more compact.
2048 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2049 Remove unneeded casts.
2051 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2053 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2055 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2056 binding" message (bug#7967).
2058 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2060 Fix more problems found by GCC 4.6.0's static checks.
2062 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2063 Remove unused local var.
2065 * editfns.c (Fmessage_box): Remove unused local var.
2067 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2068 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2069 Omit unused local vars.
2070 * window.c (shrink_windows): Omit unused local var.
2071 * menu.c (digest_single_submenu): Omit unused local var.
2072 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2073 Omit unused local var.
2075 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2076 Don't assume string length fits in int.
2077 (keyremap_step, read_key_sequence): Use size_t for sizes.
2078 (read_key_sequence): Don't check last_real_key_start redundantly.
2080 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2081 instead of alloca (Bug#8344).
2083 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2084 (Fbacktrace_frame): Don't assume nframes fits in int.
2086 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2088 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2091 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2093 * cm.c (calccost): Turn while-do into do-while, for clarity.
2095 * keyboard.c (syms_of_keyboard): Use the same style as later
2096 in this function when indexing through an array. This also
2097 works around GCC bug 48267.
2099 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2101 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2103 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2104 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2106 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2107 This avoids undefined behavior on integer overflow, and is a bit
2108 more convenient anyway since it is compared to a size_t variable.
2110 Variadic C functions now count arguments with size_t, not int.
2111 This avoids an unnecessary limitation on 64-bit machines, which
2112 caused (substring ...) to crash on large vectors (Bug#8344).
2113 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2114 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2115 All variadic functions and their callers changed accordingly.
2116 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2117 * data.c (arith_driver, float_arith_driver): Likewise.
2118 * editfns.c (general_insert_function): Likewise.
2119 * eval.c (struct backtrace.nargs, interactive_p)
2120 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2121 (funcall_lambda, mark_backtrace): Likewise.
2122 * fns.c (concat): Likewise.
2123 * frame.c (x_set_frame_parameters): Likewise.
2124 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2125 0 if not found, not -1. All callers changed.
2127 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2128 (stack_copy_size): Now size_t, not int.
2129 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2131 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2133 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2134 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2135 All callers changed.
2137 * lisp.h (multibyte_char_to_unibyte):
2138 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2139 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2140 * character.h (CHAR_TO_BYTE8):
2141 * cmds.c (internal_self_insert):
2142 * editfns.c (general_insert_function):
2143 * keymap.c (push_key_description):
2144 * search.c (Freplace_match):
2145 * xdisp.c (message_dolog, set_message_1): All callers changed.
2147 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2149 * keyboard.c (safe_run_hook_funcall): New function.
2150 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2151 don't set the hook to nil, but remove the offending function instead.
2152 (Qcommand_hook_internal): Remove, unused.
2153 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2154 Vcommand_hook_internal.
2156 * eval.c (enum run_hooks_condition): Remove.
2157 (funcall_nil, funcall_not): New functions.
2158 (run_hook_with_args): Call each function through a `funcall' argument.
2159 Remove `cond' argument, now redundant.
2160 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2161 (Frun_hook_with_args_until_failure): Adjust accordingly.
2162 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2164 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2166 * dispextern.h (string_buffer_position): Remove declaration.
2168 * print.c (strout): Remove parameter `multibyte', unused since
2169 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2171 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2172 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2173 All callers changed.
2175 * w32.c (_wsa_errlist): Use braces for struct initializers.
2177 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2178 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2179 All callers changed.
2180 (string_buffer_position): Likewise. Also, make static (it's never
2181 used outside xdisp.c).
2182 (cursor_row_p): Remove parameter `w', unused since
2183 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2184 (decode_mode_spec): Remove parameter `precision', introduced during
2185 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2186 All callers changed.
2188 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2190 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2192 2011-03-27 Anders Lindgren <andlind@gmail.com>
2194 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2195 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2196 (ns_update_auto_hide_menu_bar): New functions.
2197 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2198 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2199 ns_constrain_all_frames.
2200 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2201 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2203 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2205 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2207 2011-03-27 Glenn Morris <rgm@gnu.org>
2209 * syssignal.h: Replace RETSIGTYPE with void.
2210 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2211 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2212 Replace SIGTYPE with void everywhere.
2213 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2214 * s/template.h (SIGTYPE): Remove commented out definition.
2216 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2218 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2219 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2221 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2223 * w32.c (read_unc_volume): Use parameter `henum', instead of
2224 global variable `wget_enum_handle'.
2226 * keymap.c (describe_vector): Remove parameters `indices' and
2227 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2228 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2230 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2232 * keyboard.c (timer_check): Remove parameter `do_it_now',
2233 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2234 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2235 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2237 * keyboard.c (read_char):
2238 * w32menu.c (w32_menu_display_help):
2239 * xmenu.c (show_help_event, menu_help_callback):
2240 Adjust calls to `show_help_echo'.
2242 * gtkutil.c (xg_maybe_add_timer):
2243 * keyboard.c (readable_events):
2244 * process.c (wait_reading_process_output):
2245 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2247 * insdel.c (adjust_markers_gap_motion):
2248 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2249 (gap_left, gap_right): Don't call it.
2251 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2253 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2254 incurred during fontification.
2256 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2258 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2259 (DEFVAR_PER_BUFFER): Don't pass it.
2261 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2262 (scrolling_window): Don't pass it.
2264 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2266 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2268 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2270 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2271 of variables specific to SELinux and computation of `encoded_absname'.
2273 * image.c (XPutPixel): Remove unused variable `height'.
2275 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2277 * unexw32.c (get_section_info): Remove unused variable `section'.
2279 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2280 (system_process_attributes): Remove unused variable `sess'.
2281 (sys_read): Remove unused variable `err'.
2283 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2284 (w32_wnd_proc): Remove unused variable `isdead'.
2285 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2286 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2287 (x_create_tip_frame): Remove unused variable `tem'.
2289 * w32inevt.c (w32_console_read_socket):
2290 Remove unused variable `no_events'.
2292 * w32term.c (x_draw_composite_glyph_string_foreground):
2293 Remove unused variable `width'.
2295 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2297 * w32term.c (x_set_glyph_string_clipping):
2298 Don't pass uninitialized region to CombineRgn.
2300 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2302 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2303 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2304 (Fx_close_connection): Remove unused variable `i'.
2306 * w32font.c (w32font_draw): Return number of glyphs.
2307 (w32font_open_internal): Remove unused variable `i'.
2308 (w32font_driver): Add missing initializer.
2310 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2311 (fill_in_menu): Remove unused variable `items_added'.
2313 * w32term.c (last_mouse_press_frame): Remove static global variable.
2314 (w32_clip_to_row): Remove unused variable `f'.
2315 (x_delete_terminal): Remove unused variable `i'.
2317 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2318 (NOTHING): Remove unused static global variable.
2319 (uniscribe_check_otf): Remove unused variable `table'.
2320 (uniscribe_font_driver): Add missing initializers.
2322 2011-03-23 Julien Danjou <julien@danjou.info>
2324 * term.c (Fsuspend_tty, Fresume_tty):
2325 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2326 * window.c (temp_output_buffer_show):
2327 * insdel.c (signal_before_change):
2328 * frame.c (Fhandle_switch_frame):
2329 * fileio.c (Fdo_auto_save):
2330 * emacs.c (Fkill_emacs):
2331 * editfns.c (save_excursion_restore):
2332 * cmds.c (internal_self_insert):
2333 * callint.c (Fcall_interactively):
2334 * buffer.c (Fkill_all_local_variables):
2335 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2337 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2338 unconditionnaly since it does the check itself.
2340 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2342 Fix more problems found by GCC 4.5.2's static checks.
2344 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2345 the first time through the loop, since we know p0 < p1 then.
2346 This also avoids a gcc -Wstrict-overflow warning.
2348 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2349 leading to a memory leak, possible in functions like
2350 load_charset_map_from_file that can allocate an unbounded number
2351 of objects (Bug#8318).
2353 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2354 that could (at least in theory) be that large.
2356 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2357 This is less likely to overflow, and avoids undefined behavior if
2358 overflow does occur. All callers changed. Use strtoul to scan
2359 for the unsigned long integer.
2360 (pint2hrstr): Simplify and tune code slightly.
2361 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2363 * scroll.c (do_scrolling): Work around GCC bug 48228.
2364 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2366 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2367 This also avoids a warning with gcc -Wstrict-overflow.
2368 (validate_x_resource_name): Simplify count usage.
2369 This also avoids a warning with gcc -Wstrict-overflow.
2371 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2374 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2376 * process.c (Fmake_network_process): Use socklen_t, not int,
2377 where POSIX says socklen_t is required in portable programs.
2378 This fixes a porting bug on hosts like 64-bit HP-UX, where
2379 socklen_t is wider than int (Bug#8277).
2380 (Fmake_network_process, server_accept_connection):
2381 (wait_reading_process_output, read_process_output):
2384 * process.c: Rename or move locals to avoid shadowing.
2385 (list_processes_1, Fmake_network_process):
2386 (read_process_output_error_handler, exec_sentinel_error_handler):
2387 Rename or move locals.
2388 (Fmake_network_process): Define label "retry_connect" only if needed.
2389 (Fnetwork_interface_info): Fix pointer signedness.
2390 (process_send_signal): Add cast to avoid pointer signedness problem.
2391 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2392 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2394 Make tparam.h and terminfo.c consistent.
2395 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2396 Include tparam.h instead, since it declares them.
2397 * cm.h (PC): Remove extern decl; tparam.h now does this.
2398 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2399 * terminfo.c: Include tparam.h, to check interfaces.
2400 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2401 (tparam): Adjust signature to match interface in tparam.h;
2402 this removes some undefined behavior. Check that outstring and len
2403 are zero, which they always are with Emacs.
2404 * tparam.h (PC, BC, UP): New extern decls.
2406 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2407 (xftfont_open): Rename locals to avoid shadowing.
2409 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2410 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2411 (OTF_TAG_SYM): Omit macro if not needed.
2412 (ftfont_list): Remove unused local.
2413 (get_adstyle_property, ftfont_pattern_entity):
2414 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2415 Rename locals to avoid shadowing.
2417 * xfont.c (xfont_list_family): Mark var as initialized.
2419 * xml.c (make_dom): Now static.
2421 * composite.c (composition_compute_stop_pos): Rename local to
2423 (composition_reseat_it): Remove unused locals.
2424 (find_automatic_composition, composition_adjust_point): Likewise.
2425 (composition_update_it): Mark var as initialized.
2426 (find_automatic_composition): Mark vars as initialized,
2427 with a FIXME (Bug#8290).
2429 character.h: Rename locals to avoid shadowing.
2430 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2431 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2432 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2433 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2436 * textprop.c (property_change_between_p): Remove; unused.
2438 * intervals.c (interval_start_pos): Now static.
2440 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2442 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2443 Rename locals to avoid shadowing.
2445 * sound.c (wav_play, au_play, Fplay_sound_internal):
2446 Fix pointer signedness.
2447 (alsa_choose_format): Remove unused local var.
2448 (wav_play): Initialize a variable to 0, to prevent undefined
2449 behavior (Bug#8278).
2451 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2453 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2456 clobbering (Bug#8298).
2457 * sysdep.c (sys_subshell): Likewise.
2458 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2460 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2461 This should get cleaned up, so that child_setup has the
2462 same signature on all platforms.
2464 * callproc.c (call_process_cleanup): Now static.
2465 (relocate_fd): Rename locals to avoid shadowing.
2467 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2469 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2470 not to be necessary, and produces flickering.
2472 2011-03-20 Glenn Morris <rgm@gnu.org>
2474 * config.in: Remove file.
2476 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2478 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2479 are now in src/globals.h.
2480 (syms_of_minibuf): Remove spurious & from previous change.
2482 2011-03-20 Leo <sdl.web@gmail.com>
2484 * minibuf.c (completing-read-function): New variable.
2485 (completing-read-default): Rename from completing-read.
2486 (completing-read): Call completing-read-function.
2488 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2490 * xfaces.c (Fx_load_color_file):
2491 Read color file from absolute filename (bug#8250).
2493 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2495 * makefile.w32-in: Update dependencies.
2497 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2499 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2501 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2503 Fix more problems found by GCC 4.5.2's static checks.
2505 * process.c (make_serial_process_unwind, send_process_trap):
2506 (sigchld_handler): Now static.
2508 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2509 That way, the code declares only the vars that it needs.
2510 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2511 * s/cygwin.h (PTY_ITERATION): Likewise.
2512 * s/darwin.h (PTY_ITERATION): Likewise.
2513 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2515 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2516 * process.c (allocate_pty): Don't declare stb unless it's needed.
2518 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2519 (CONSTANTLIM): Remove; unused.
2520 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2521 Define only if needed.
2523 * unexelf.c (unexec): Name an expression,
2524 to avoid gcc -Wbad-function-cast warning.
2525 Use a different way to cause a compilation error if anyone uses
2526 n rather than nn, a way that does not involve shadowing.
2527 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2529 * deps.mk (unexalpha.o): Remove; unused.
2531 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2532 * unexec.h: New file.
2533 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2534 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2536 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2537 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2538 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2539 Change as necessary to match prototype in unexec.h.
2541 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2543 (back_comment, skip_chars): Mark vars as initialized.
2545 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2546 Rename locals to avoid shadowing.
2548 * lread.c (read1): Rewrite so as not to use empty "else".
2549 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2551 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2553 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2554 warning when compiling print.c.
2556 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2557 instead of using an uninitialized var.
2558 (font_sort_entities): Mark var as initialized.
2560 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2562 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2563 pointers to constants.
2564 (font_parse_fcname): Remove unused vars.
2565 (font_delete_unmatched): Now static.
2566 (font_get_spec): Remove; unused.
2567 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2568 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2569 Rename or move locals to avoid shadowing.
2571 * fns.c (require_nesting_list, require_unwind): Now static.
2572 (Ffillarray): Rename locals to avoid shadowing.
2574 * floatfns.c (domain_error2): Define only if needed.
2575 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2577 * alloc.c (mark_backtrace): Move decl from here ...
2578 * lisp.h: ... to here, so that it can be checked.
2580 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2581 (Fdefvar): Rewrite so as not to use empty "else".
2582 (lisp_indirect_variable): Name an expression,
2583 to avoid gcc -Wbad-function-cast warning.
2584 (Fdefvar): Rename locals to avoid shadowing.
2586 * callint.c (quotify_arg, quotify_args): Now static.
2587 (Fcall_interactively): Rename locals to avoid shadowing.
2588 Use const pointer when appropriate.
2590 * lisp.h (get_system_name, get_operating_system_release):
2591 Move decls here, to check interfaces.
2592 * process.c (get_operating_system_release): Move decl to lisp.h.
2593 * xrdb.c (get_system_name): Likewise.
2594 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2595 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2596 some of which prompt warnings from gcc -Wbad-function-cast.
2597 (Fformat_time_string, Fencode_time, Finsert_char):
2598 (Ftranslate_region_internal, Fformat):
2599 Rename or remove local vars to avoid shadowing.
2600 (Ftranslate_region_internal): Mark var as initialized.
2602 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2605 * lisp.h (eassert): Check that the argument compiles, even if
2606 ENABLE_CHECKING is not defined.
2608 * data.c (Findirect_variable): Name an expression, to avoid
2609 gcc -Wbad-function-cast warning.
2610 (default_value, arithcompare, arith_driver, arith_error): Now static.
2611 (store_symval_forwarding): Rename local to avoid shadowing.
2612 (Fmake_variable_buffer_local, Fmake_local_variable):
2613 Mark variables as initialized.
2614 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2616 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2617 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2618 Rename locals to avoid shadowing.
2619 (mark_stack): Move local variables into the #ifdef region where
2621 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2622 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2624 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2625 (GC_STRING_CHARS): Remove; not used.
2626 (Fmemory_limit): Cast sbrk's returned value to char *.
2628 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2629 avoids undefined behavior in theory.
2631 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2633 Use functions, not macros, for up- and down-casing (Bug#8254).
2634 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2635 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2636 to use the following functions instead of these macros.
2637 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2638 EMACS_INT, since callers assume the returned value fits in int.
2639 (upcase1): Likewise, for UPCASE_TABLE.
2640 (uppercasep, lowercasep, upcase): New static inline functions.
2641 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2642 the race-condition problem in the old DOWNCASE.
2644 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2645 Rename locals to avoid shadowing.
2646 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2647 (regex_compile, re_search_2, re_match_2_internal):
2648 Remove unused local vars.
2649 (FREE_VAR): Rewrite so as not to use empty "else",
2650 which gcc can warn about.
2651 (regex_compile, re_match_2_internal): Mark locals as initialized.
2652 (RETALLOC_IF): Define only if needed.
2653 (WORDCHAR_P): Likewise. This one is never needed, but is used
2654 only in a comment talking about a compiler bug, so put inside
2655 the #if 0 of that comment.
2656 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2657 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2660 * search.c (boyer_moore): Rename locals to avoid shadowing.
2661 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2662 (PREV_CHAR_BOUNDARY): Likewise.
2664 * search.c (simple_search): Remove unused var.
2666 * dired.c (compile_pattern): Move decl from here ...
2667 * lisp.h: ... to here, so that it can be checked.
2668 (struct re_registers): New forward decl.
2670 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2672 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2674 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2675 Rename locals to avoid shadowing.
2676 (Fvertical_motion): Mark locals as initialized.
2678 * casefiddle.c (casify_object, casify_region): Now static.
2679 (casify_region): Mark local as initialized.
2681 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2683 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2684 New macros, so that the caller can use some names other than
2685 gcpro1, gcpro2, etc.
2686 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2688 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2689 argument, for consistency with GCPRO2_VAR, etc: it is now the
2690 prefix of the variable, not the variable itself. All uses
2692 * dired.c (directory_files_internal, file_name_completion):
2693 Rename locals to avoid shadowing.
2695 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2696 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2697 dired.c's scmp function, had undefined behavior.
2698 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2699 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2700 * buffer.h: ... to here, because these macros use current_buffer,
2701 and the new implementation with inline functions needs to have
2702 current_buffer in scope now, rather than later when the macros
2704 (downcase, upcase1): New static inline functions.
2705 (DOWNCASE, UPCASE1): Reimplement using these functions.
2706 This avoids undefined behavior in expressions like
2707 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2708 from race conditions in accessing the global variables
2709 case_temp1 and case_temp2.
2710 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2711 * lisp.h (case_temp1, case_temp2): Remove their decls.
2712 * character.h (ASCII_CHAR_P): Move from here ...
2713 * lisp.h: ... to here, so that the inline functions mentioned
2716 * dired.c (directory_files_internal_unwind): Now static.
2718 * fileio.c (file_name_as_directory, directory_file_name):
2719 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2721 (file_name_as_directory): Use const pointers when appropriate.
2722 (Fexpand_file_name): Likewise. In particular, newdir might
2723 point at constant storage, so make it a const pointer.
2724 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2725 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2727 (Fset_file_times, Finsert_file_contents, auto_save_error):
2728 Rename locals to avoid shadowing.
2730 * minibuf.c (choose_minibuf_frame_1): Now static.
2731 (Ftry_completion, Fall_completions): Rename or remove locals
2734 * marker.c (bytepos_to_charpos): Remove; unused.
2736 * lisp.h (verify_bytepos, count_markers): New decls,
2737 so that gcc does not warn that these functions aren't declared.
2739 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2740 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2741 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2742 (copy_text): Remove unused local var.
2744 * filelock.c (within_one_second): Now static.
2745 (lock_file_1): Rename local to avoid shadowing.
2747 * buffer.c (fix_overlays_before): Mark locals as initialized.
2748 (fix_start_end_in_overlays): Likewise. This function should be
2749 simplified by using pointers-to-pointers, but that's a different
2751 (switch_to_buffer_1): Now static.
2752 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2753 (report_overlay_modification): Rename locals to avoid shadowing.
2755 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2756 Fix pointer signedness issue.
2757 (sys_subshell): Mark local as volatile if checking for lint,
2758 to suppress a gcc -Wclobbered warning that does not seem to be right.
2759 (MAXPATHLEN): Define only if needed.
2761 * process.c (serial_open, serial_configure): Move decls from here ...
2762 * systty.h: ... to here, so that they can be checked.
2764 * fns.c (get_random, seed_random): Move extern decls from here ...
2765 * lisp.h: ... to here, so that they can be checked.
2767 * sysdep.c (reset_io): Now static.
2768 (wait_for_termination_signal): Remove; unused.
2770 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2771 (copy_keymap_item, append_key, push_text_char_description):
2773 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2774 (DENSE_TABLE_SIZE): Remove; unused.
2775 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2776 (describe_map_tree):
2777 Rename locals to avoid shadowing.
2779 * keyboard.c: Declare functions static if they are not used elsewhere.
2780 (echo_char, echo_dash, cmd_error, top_level_2):
2781 (poll_for_input, handle_async_input): Now static.
2782 (read_char, kbd_buffer_get_event, make_lispy_position):
2783 (make_lispy_event, make_lispy_movement, apply_modifiers):
2784 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2785 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2786 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2787 (read_key_sequence, read_char): Mark locals as initialized.
2788 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2790 * keyboard.h (make_ctrl_char): New decl.
2791 (mark_kboards): Move decl here ...
2792 * alloc.c (mark_kboards): ... from here.
2794 * lisp.h (force_auto_save_soon): New decl.
2796 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2797 (DEFINE_DUMMY_FUNCTION): New macro.
2798 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2800 (main): Add casts to avoid warnings
2801 if GCC considers string literals to be constants.
2803 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2805 * dbusbind.c: Pointer signedness fixes.
2806 (xd_signature, xd_append_arg, xd_initialize):
2807 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2808 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2809 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2810 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2812 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2813 if GCC considers string literals to be constants.
2814 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2816 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2818 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2819 (print_preprocess, print_object): New macro to fix last change.
2821 * print.c (print_preprocess): Don't forget font objects.
2823 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2825 * emacs.c (USAGE3): Doc fixes.
2827 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2829 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2832 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2834 * lisp.h (VWindow_system, Qfile_name_history):
2835 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2836 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2837 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2839 * w32select.c: Don't #include "keyboard.h".
2840 (run_protected): Add extern declaration for waiting_for_input.
2842 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2843 * w32console.c (detect_input_pending, read_input_pending)
2844 (encode_terminal_code):
2845 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2846 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2847 (w32_system_caret_y, Qfile_name_history):
2848 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2849 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2850 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2851 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2852 * w32proc.c (Qlocal, report_file_error):
2853 * w32term.c (Vwindow_system, updating_frame):
2854 * w32uniscribe.c (initialized, uniscribe_font_driver):
2855 Remove unneeded extern declarations.
2857 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2859 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2861 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2863 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2864 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2865 These macros can no longer be used for assignment.
2867 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2868 Assign struct members directly, instead of using BUF_BEGV etc.
2869 (record_buffer_markers, fetch_buffer_markers): New functions for
2870 recording and fetching special buffer markers.
2871 (set_buffer_internal_1, set_buffer_temp): Use them.
2873 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2875 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2877 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2878 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2880 * xdisp.c (hscroll_window_tree):
2881 (reconsider_clip_changes): Use PT instead of BUF_PT.
2883 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2885 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2886 $(EMACS_ROOT)/lib/intprops.h.
2888 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2890 Fix more problems found by GCC 4.5.2's static checks.
2892 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2893 to unsigned char * to avoid compiler diagnostic.
2894 (xg_free_frame_widgets): Make it clear that a local variable is
2895 needed only if USE_GTK_TOOLTIP.
2896 (gdk_window_get_screen): Make it clear that this macro is needed
2897 only if USE_GTK_TOOLTIP.
2898 (int_gtk_range_get_value): New function, which avoids a diagnostic
2899 from gcc -Wbad-function-cast.
2900 (xg_set_toolkit_scroll_bar_thumb): Use it.
2901 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2902 diagnostic from gcc -Wbad-function-cast.
2903 (get_utf8_string, xg_get_file_with_chooser):
2904 Rename locals to avoid shadowing.
2905 (create_dialog): Move locals to avoid shadowing.
2907 * xgselect.c (xg_select): Remove unused var.
2909 * image.c (four_corners_best): Mark locals as initialized.
2910 (gif_load): Initialize transparent_p to zero (Bug#8238).
2911 Mark another local as initialized.
2912 (my_png_error, my_error_exit): Mark with NO_RETURN.
2914 * image.c (clear_image_cache): Now static.
2915 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2916 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2917 (x_edge_detection): Remove unnecessary cast that
2918 gcc -Wbad-function-cast diagnoses.
2919 (gif_load): Fix pointer signedness.
2920 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2921 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2923 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2925 Improve quality of tests for time stamp overflow.
2926 For example, without this patch (encode-time 0 0 0 1 1
2927 1152921504606846976) returns the obviously-bogus value (-948597
2928 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2929 reports time overflow. See
2930 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2931 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2932 * editfns.c: Include limits.h and intprops.h.
2933 (TIME_T_MIN, TIME_T_MAX): New macros.
2934 (time_overflow): Move earlier, to before first use.
2935 (hi_time, lo_time): New functions, for an accurate test for
2937 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2938 (Fget_internal_run_time): Don't assume time_t fits in int.
2939 (make_time): Use list2 instead of Fcons twice.
2940 (Fdecode_time): More accurate test for out-of-range times.
2941 (check_tm_member): New function.
2942 (Fencode_time): Use it, to test for out-of-range times.
2943 (lisp_time_argument): Don't rely on undefined left-shift and
2944 right-shift behavior when checking for time stamp overflow.
2946 * editfns.c (time_overflow): New function, refactoring common code.
2947 (Fformat_time_string, Fdecode_time, Fencode_time):
2948 (Fcurrent_time_string): Use it.
2950 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2951 * dired.c (make_time): Move to ...
2952 * editfns.c (make_time): ... here.
2953 * systime.h: Note the move.
2955 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2957 * fringe.c (update_window_fringes): Remove unused variables.
2959 * unexmacosx.c (copy_data_segment): Also copy __got section.
2962 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2964 * termcap.c [MSDOS]: Include "msdos.h".
2965 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2966 Constify `char *' arguments and their references according to
2967 prototypes in tparam.h.
2969 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2971 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2972 Adapt all references accordingly.
2974 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2976 2011-03-11 Tom Tromey <tromey@redhat.com>
2978 * buffer.c (syms_of_buffer): Remove obsolete comment.
2980 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2982 * termhooks.h (encode_terminal_code): Declare prototype.
2984 * msdos.c (encode_terminal_code): Don't declare prototype.
2986 * term.c (encode_terminal_code): Now external again, used by
2987 w32console.c and msdos.c.
2989 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2990 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2992 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2994 Fix some minor problems found by GCC 4.5.2's static checks.
2996 * fringe.c (update_window_fringes): Mark locals as initialized
2998 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3000 * alloc.c (mark_fringe_data): Move decl from here ...
3001 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3002 to check its interface.
3003 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3005 * fontset.c (free_realized_fontset): Now static.
3006 (Fset_fontset_font): Rename local to avoid shadowing.
3007 (fontset_font): Mark local as initialized.
3008 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3010 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3012 * xselect.c (x_disown_buffer_selections): Remove; not used.
3013 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3014 (x_own_selection, Fx_disown_selection_internal): Rename locals
3016 (x_handle_dnd_message): Remove local to avoid shadowing.
3018 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3019 so that the caller can use some name other than gcpro1.
3020 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3021 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3022 (Fx_backspace_delete_keys_p):
3023 Use them to avoid shadowing, and rename vars to avoid shadowing.
3024 (x_decode_color, x_set_name, x_window): Now static.
3025 (Fx_create_frame): Add braces to silence GCC warning.
3026 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3027 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3028 Remove unused locals.
3029 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3030 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3031 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3034 * xterm.h (x_mouse_leave): New decl.
3036 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3037 Remove unused functions.
3038 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3039 (x_calc_absolute_position): Now static.
3040 (XTread_socket): Don't define label "out" unless it's used.
3041 Don't declare local "event" unless it's used.
3042 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3043 unless they are used.
3044 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3045 (x_fatal_error_signal): Remove; not used.
3046 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3047 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3048 (x_error_catcher, x_connection_closed, x_error_handler):
3049 (x_error_quitter, xembed_send_message, x_iconify_frame):
3050 (my_log_handler): Rename locals to avoid shadowing.
3051 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3052 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3054 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3055 Rename or move locals to avoid shadowing.
3056 (tty_defined_color, merge_face_heights): Now static.
3057 (free_realized_faces_for_fontset): Remove; not used.
3058 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3059 does not deduce is never used uninitialized.
3060 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3061 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3063 * terminal.c (store_terminal_param): Now static.
3065 * xmenu.c (menu_highlight_callback): Now static.
3066 (set_frame_menubar): Remove unused local.
3067 (xmenu_show): Rename parameter to avoid shadowing.
3068 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3069 since they might point to immutable storage.
3070 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3071 since it's unused otherwise.
3073 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3074 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3075 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3076 avoids a gcc -Wuninitialized diagnostic.
3077 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3078 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3079 does not deduce are never used uninitialized.
3081 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3083 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3084 * window.c (window_loop, size_window):
3085 (run_window_configuration_change_hook, enlarge_window): Likewise.
3087 * window.c (display_buffer): Now static.
3088 (size_window): Mark variables that gcc -Wuninitialized
3089 does not deduce are never used uninitialized.
3090 * window.h (check_all_windows): New decl, to forestall
3091 gcc -Wmissing-prototypes diagnostic.
3092 * dispextern.h (bidi_dump_cached_states): Likewise.
3094 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3096 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3098 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3099 and to avoid gcc -Wuninitialized warning.
3100 (load_charset_map): Mark variables that gcc -Wuninitialized
3101 does not deduce are never used uninitialized.
3102 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3104 * coding.c (coding_set_source, coding_set_destination):
3105 Use "else { /* comment */ }" rather than "else /* comment */;"
3106 for clarity, and to avoid gcc -Wempty-body warning.
3107 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3108 a block, when the outer 'i' will do.
3109 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3110 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3111 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3112 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3113 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3114 Rename locals to avoid shadowing.
3115 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3116 * coding.c (emacs_mule_char, encode_invocation_designation):
3117 Now static, since they're not used elsewhere.
3118 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3119 (decode_coding_object, encode_coding_object, detect_coding_system):
3120 (decode_coding_emacs_mule): Mark variables that gcc
3121 -Wuninitialized does not deduce are never used uninitialized.
3122 (detect_coding_iso_2022): Initialize a local variable that might
3123 be used uninitialized. Leave a FIXME because it's not clear that
3124 this initialization is needed. (Bug#8211)
3125 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3126 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3127 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3128 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3129 Remove unused macros.
3131 * category.c (hash_get_category_set): Remove unused local var.
3132 (copy_category_table): Now static, since it's not used elsewhere.
3133 * character.c (string_count_byte8): Likewise.
3135 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3136 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3138 * chartab.c (copy_sub_char_table): Now static, since it's not used
3140 (sub_char_table_ref_and_range, char_table_ref_and_range):
3141 Rename locals to avoid shadowing.
3142 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3144 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3145 (BIDI_BOB): Remove unused macro.
3147 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3148 deduce are never used uninitialized.
3149 * term.c (encode_terminal_code): Likewise.
3151 * term.c (encode_terminal_code): Now static. Remove unused local.
3153 * tparam.h: New file.
3154 * term.c, tparam.h: Include it.
3155 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3156 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3157 Move these decls to tparam.h, and make them agree with what
3158 is actually in tparam.c. The previous trick of using incompatible
3159 decls in different modules does not conform to the C standard.
3160 All callers of tparam changed to use tparam's actual API.
3161 * tparam.c (tparam1, tparam, tgoto):
3162 Use const pointers where appropriate.
3164 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3165 * cm.h (struct cm): Likewise.
3166 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3167 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3168 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3169 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3170 (turn_on_face, init_tty): Likewise.
3171 * termchar.h (struct tty_display_info): Likewise.
3173 * term.c (term_mouse_position): Rename local to avoid shadowing.
3175 * alloc.c (mark_ttys): Move decl from here ...
3176 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3178 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3180 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3182 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3184 * search.c (compile_pattern_1): Remove argument regp, unused since
3185 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3186 (compile_pattern): Don't pass it.
3188 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3190 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3191 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3193 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3195 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3197 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3198 gdk_window_get_screen, gdk_window_get_geometry,
3199 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3200 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3201 (xg_get_pixbuf_from_pixmap): New function.
3202 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3203 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3204 Call xg_get_pixbuf_from_pixmap instead of
3205 gdk_pixbuf_get_from_drawable.
3206 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3207 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3208 (xg_check_special_colors): Use GtkStyleContext and its functions
3210 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3211 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3212 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3213 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3214 Call gtk_widget_get_preferred_size.
3215 (xg_frame_resized): gdk_window_get_geometry only takes 5
3217 (xg_win_to_widget, xg_event_is_for_menubar):
3218 Call gdk_x11_window_lookup_for_display.
3219 (xg_set_widget_bg): New function.
3220 (delete_cb): New function.
3221 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3222 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3223 (xg_set_background_color): Call xg_set_widget_bg.
3224 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3225 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3226 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3227 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3229 (update_frame_tool_bar): Call gtk_widget_hide.
3230 (xg_initialize): Use GDK_KEY_g.
3232 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3234 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3236 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3237 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3238 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3240 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3242 * w32xfns.c (select_palette): Check success of RealizePalette against
3243 GDI_ERROR, not zero.
3245 See ChangeLog.11 for earlier changes.
3251 Copyright (C) 2011 Free Software Foundation, Inc.
3253 This file is part of GNU Emacs.
3255 GNU Emacs is free software: you can redistribute it and/or modify
3256 it under the terms of the GNU General Public License as published by
3257 the Free Software Foundation, either version 3 of the License, or
3258 (at your option) any later version.
3260 GNU Emacs is distributed in the hope that it will be useful,
3261 but WITHOUT ANY WARRANTY; without even the implied warranty of
3262 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3263 GNU General Public License for more details.
3265 You should have received a copy of the GNU General Public License
3266 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.