1 2012-03-22 Chong Yidong <cyd@gnu.org>
3 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5 * xdisp.c (push_prefix_prop): Renamed from push_display_prop.
6 Mark string as coming from a prefix property.
7 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
10 2012-03-21 Chong Yidong <cyd@gnu.org>
12 * xfaces.c (Vface_remapping_alist): Doc fix.
14 2012-03-20 Eli Zaretskii <eliz@gnu.org>
16 * w32proc.c (Fw32_set_console_codepage)
17 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset): Doc
20 2012-03-20 Chong Yidong <cyd@gnu.org>
22 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
23 to reflect default non-nil value of redisplay-dont-pause.
25 2012-03-19 Kenichi Handa <handa@m17n.org>
27 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
28 it fit in a valid range (Bug#11003).
30 2012-03-18 Eli Zaretskii <eliz@gnu.org>
32 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
33 that is not from display property, accept the row as a "cursor
34 row" if one of the string's character has a non-nil `cursor'
35 property. Fixes cursor positioning when there are newlines in
36 overlay strings, e.g. in icomplete.el. (Bug#11035)
38 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
40 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
42 2012-03-12 Chong Yidong <cyd@gnu.org>
44 * eval.c (inhibit_lisp_code): Rename from
45 inhibit_window_configuration_change_hook; move from window.c.
47 * xfns.c (unwind_create_frame_1, Fx_create_frame):
48 * window.c (run_window_configuration_change_hook)
49 (syms_of_window): Callers changed.
51 2012-03-11 Chong Yidong <cyd@gnu.org>
53 * keymap.c (Fkey_description): Doc fix (Bug#9700).
55 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
57 2012-03-10 Chong Yidong <cyd@gnu.org>
59 * frame.c (other_visible_frames): Don't assume the selected frame
60 is visible (Bug#10955).
62 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
64 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
66 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
68 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
69 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
72 2012-03-03 Glenn Morris <rgm@gnu.org>
74 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
76 2012-03-02 Eli Zaretskii <eliz@gnu.org>
78 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
79 position past the first glyph_row that ends at ZV. (Bug#10902)
80 (redisplay_window, next_element_from_string): Fix typos in
82 (redisplay_window): Pass to move_it_vertically the margin in
83 pixels, not in screen lines.
85 2012-03-02 Glenn Morris <rgm@gnu.org>
87 * buffer.c (buffer-list-update-hook): Doc fix.
89 2012-02-29 Eli Zaretskii <eliz@gnu.org>
91 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
92 push_it before setting up the iterator for the first overlay
93 string, even if we have an empty string loaded.
94 (next_overlay_string): If there's an empty string on the iterator
95 stack, pop the stack. (Bug#10903)
97 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
99 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
100 Suggested by Stefan Monnier in
101 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
102 * alloc.c (widen_to_Lisp_Object): New static function.
103 (mark_memory): Also mark Lisp_Objects by fetching pointer words
104 and widening them to Lisp_Objects. This would work even if
105 USE_LSB_TAG is defined and wide integers are used, which might
106 happen in a future version of Emacs.
108 2012-02-25 Chong Yidong <cyd@gnu.org>
110 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
113 * xselect.c (Fx_selection_exists_p): Doc fix.
114 (x_clipboard_manager_save_all): Print an informative message
115 before saving to clipboard manager.
117 2012-02-24 Chong Yidong <cyd@gnu.org>
119 * keyboard.c (process_special_events): Handle all X selection
120 requests in kbd_buffer, not just the next one (Bug#8869).
122 2012-02-23 Chong Yidong <cyd@gnu.org>
124 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
125 call when setting menu-bar-lines and tool-bar-lines parameters.
126 (unwind_create_frame_1): New helper function.
128 * window.c (inhibit_window_configuration_change_hook): New var.
129 (run_window_configuration_change_hook): Obey it.
130 (syms_of_window): Initialize it.
132 2012-02-22 Chong Yidong <cyd@gnu.org>
134 * xterm.c (x_draw_image_relief): Add missing type check for
135 Vtool_bar_button_margin (Bug#10743).
137 2012-02-21 Chong Yidong <cyd@gnu.org>
139 * fileio.c (Vfile_name_handler_alist): Doc fix.
141 * buffer.c (Fget_file_buffer): Protect against invalid file
142 handler return value.
144 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
146 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
147 when computing $valmask.
149 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
150 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
151 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
152 It's useless in that case, and it can cause problems on hosts
153 that allocate halves of EMACS_INT values separately.
154 Reported by Dan Horák. Diagnosed by Andreas Schwab in
155 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
156 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
157 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
158 it avoids undefined behavior on hosts where shifting right by more
159 than the word width has undefined behavior.
161 2012-02-19 Chong Yidong <cyd@gnu.org>
163 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
164 (Funhandled_file_name_directory, Ffile_name_as_directory)
165 (Fdirectory_file_name, Fexpand_file_name)
166 (Fsubstitute_in_file_name): Protect against invalid file handler
167 return values (Bug#10845).
169 2012-02-18 Eli Zaretskii <eliz@gnu.org>
171 * .gdbinit (pitx): Fix incorrect references to fields of the
174 2012-02-17 Chong Yidong <cyd@gnu.org>
176 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
178 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
180 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
181 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
183 2012-02-15 Chong Yidong <cyd@gnu.org>
185 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
186 marked as special. Also, starting docstrings with * is obsolete.
188 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
190 * gnutls.c (emacs_gnutls_write): Fix last change.
192 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
194 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
197 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
199 * keymap.c (Fsingle_key_description): Handle char ranges.
201 2012-02-12 Chong Yidong <cyd@gnu.org>
203 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
204 as that creates a dangerous corner case.
206 * window.c (Fdelete_window_internal): Invalidate the mouse
207 highlight (Bug#9904).
209 2012-02-12 Glenn Morris <rgm@gnu.org>
211 * xselect.c (Fx_own_selection_internal)
212 (Fx_get_selection_internal, Fx_disown_selection_internal)
213 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
214 * nsselect.m (Fx_own_selection_internal)
215 (Fx_disown_selection_internal, Fx_selection_exists_p)
216 (Fx_selection_owner_p, Fx_get_selection_internal):
217 Sync docs and argument specs with the xselect.c versions.
219 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
221 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
223 2012-02-11 Eli Zaretskii <eliz@gnu.org>
225 * w32select.c (Fx_selection_exists_p): Sync doc string and
226 argument list with xselect.c. (Bug#10783)
228 * w16select.c (Fx_selection_exists_p): Sync doc string and
229 argument list with xselect.c. (Bug#10783)
231 2012-02-10 Glenn Morris <rgm@gnu.org>
233 * fns.c (Fsecure_hash): Doc fix.
235 2012-02-09 Kenichi Handa <handa@m17n.org>
237 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
239 2012-02-07 Chong Yidong <cyd@gnu.org>
241 * buffer.c (Fbuffer_local_variables)
242 (buffer_lisp_local_variables): Handle unbound vars correctly;
243 don't let Qunbound leak into Lisp.
245 2012-02-07 Glenn Morris <rgm@gnu.org>
247 * image.c (Fimagemagick_types): Doc fix.
249 * image.c (imagemagick-render-type): Change it from a lisp object
250 to an integer. Move the doc here from the lisp manual.
251 Treat all values not equal to 0 the same.
253 2012-02-06 Chong Yidong <cyd@gnu.org>
255 * doc.c (store_function_docstring): Avoid applying docstring of
256 alias to base function (Bug#2603).
258 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
260 * .gdbinit (pp1, pv1): Remove redundant defines.
263 2012-02-04 Chong Yidong <cyd@gnu.org>
265 * nsterm.m: Declare a global (Bug#10694).
267 2012-02-04 Eli Zaretskii <eliz@gnu.org>
269 * w32.c (get_emacs_configuration_options):
270 Include --enable-checking, if specified, in the return value.
272 2012-02-04 Martin Rudalics <rudalics@gmx.at>
274 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
275 after rounding frame sizes. (Bug#9723)
277 2012-02-04 Eli Zaretskii <eliz@gnu.org>
279 * keyboard.c (adjust_point_for_property): Don't position point
280 before BEGV. (Bug#10696)
282 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
284 Handle overflow when computing char display width (Bug#9496).
285 * character.c (char_width): Return EMACS_INT, not int.
286 (char_width, c_string_width): Check for overflow when
287 computing the width; this is possible now that individual
288 characters can have unbounded width. Problem introduced
289 by merge from Emacs 23 on 2012-01-19.
291 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
293 * dbusbind.c (Fdbus_register_method): Mention the return value
294 :ignore in the docstring.
296 2012-02-02 Glenn Morris <rgm@gnu.org>
298 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
300 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
301 Unconditionally set to t. (Bug#10673)
302 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
303 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
304 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
306 2012-02-02 Kenichi Handa <handa@m17n.org>
308 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
309 0, do not call append_composite_glyph.
311 2012-02-02 Kenichi Handa <handa@m17n.org>
313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
315 (x_produce_glyphs): If the component of a composition is a null
316 string, set it->pixel_width to 1 to avoid zero-width glyph.
318 2012-02-01 Eli Zaretskii <eliz@gnu.org>
320 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
321 first 2 arguments are identical. This makes inserting large
322 output from a subprocess an order of magnitude faster on
323 MS-Windows, where all sbrk'ed memory is always contiguous.
325 2012-01-31 Glenn Morris <rgm@gnu.org>
327 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
328 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
329 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
331 2012-01-29 Glenn Morris <rgm@gnu.org>
333 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
335 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
337 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
339 2012-01-28 Chong Yidong <cyd@gnu.org>
341 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
343 2012-01-26 Chong Yidong <cyd@gnu.org>
345 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
347 * search.c (Fsearch_forward, Fsearch_backward): Document negative
348 repeat counts (Bug#10507).
350 2012-01-26 Glenn Morris <rgm@gnu.org>
352 * lread.c (syms_of_lread): Doc fix.
354 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
356 * coding.c (encode_designation_at_bol): Change return value to
359 2012-01-25 Chong Yidong <cyd@gnu.org>
361 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
363 2012-01-21 Chong Yidong <cyd@gnu.org>
365 * floatfns.c (Fcopysign): Make the second argument non-optional,
366 since nil is not allowed anyway.
368 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
370 * process.c (read_process_output): Use p instead of XPROCESS (proc).
371 (send_process): Likewise.
373 2012-01-19 Martin Rudalics <rudalics@gmx.at>
375 * window.c (save_window_save, Fcurrent_window_configuration)
376 (Vwindow_persistent_parameters): Do not use Qstate.
379 2012-01-19 Kenichi Handa <handa@m17n.org>
381 * character.c (char_width): New function.
382 (Fchar_width, c_string_width, lisp_string_width):
383 Use char_width (Bug#9496).
385 2012-01-16 Martin Rudalics <rudalics@gmx.at>
387 * window.c (Vwindow_persistent_parameters): New variable.
388 (Fset_window_configuration, save_window_save): Handle persistent
391 2012-01-14 Eli Zaretskii <eliz@gnu.org>
393 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
394 thrashing the stack of the thread. (Bug#9087)
396 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
398 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
400 2012-01-11 Eli Zaretskii <eliz@gnu.org>
402 * xdisp.c (rows_from_pos_range): Handle the case where the
403 highlight ends on a newline. (Bug#10464)
404 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
405 he end column for display of highlight that ends on a newline
408 2012-01-11 Glenn Morris <rgm@gnu.org>
410 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
411 from load-path also when installation-directory is nil. (Bug#10208)
413 2012-01-10 Glenn Morris <rgm@gnu.org>
415 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
417 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
418 Update template values to be closer to their typical values these days.
420 2012-01-09 Eli Zaretskii <eliz@gnu.org>
422 * xdisp.c (rows_from_pos_range): Accept additional argument
423 DISP_STRING, and accept any glyph in a row whose object is that
424 string as eligible for mouse highlight. Fixes mouse highlight of
425 display strings from overlays. (Bug#10464)
427 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
429 emacs: fix an auto-save permissions race condition (Bug#10400)
430 * fileio.c (auto_saving_dir_umask): New static var.
431 (Fmake_directory_internal): Use it.
432 (do_auto_save_make_dir): Set it, instead of invoking chmod after
433 creating the directory. The old code temporarily assigns
434 too-generous permissions to the directory.
435 (do_auto_save_eh): Clear it.
436 (Fdo_auto_save): Catch all errors, not just file errors, so
437 that the var is always cleared.
439 2012-01-07 Eli Zaretskii <eliz@gnu.org>
441 * search.c (scan_buffer): Pass character positions to
442 know_region_cache, not byte positions. (Bug#6540)
444 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
446 * w32.c (sys_rename): Report EXDEV when rename of a directory
447 fails because the target is on another logical disk. (Bug#10284)
449 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
451 * xterm.c (x_embed_request_focus): New function.
453 * xterm.h: Add prototype.
455 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
457 2012-01-05 Glenn Morris <rgm@gnu.org>
459 * emacs.c (emacs_copyright): Update short copyright year to 2012.
461 2012-01-01 Eli Zaretskii <eliz@gnu.org>
463 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
464 Load gnutls_transport_set_lowat only if GnuTLS version is below
466 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
467 GnuTLS versions below 2.11.1.
469 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
471 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
472 to the doc string advising against its use for altering the way
473 windows are scrolled.
475 2011-12-28 Kenichi Handa <handa@m17n.org>
477 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
478 coding-system ASCII compatible only when it does not produce BOM
479 on encoding (Bug#10383).
481 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
483 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
485 (create_and_show_popup_menu): Always use menu_position_func for
488 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
490 * callint.c (Fcall_interactively): Don't truncate prompt string.
492 2011-12-23 Eli Zaretskii <eliz@gnu.org>
494 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
495 property that ends at ZV, so that the bidi iteration could be
496 resumed from there (after widening). (Bug#10360)
498 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
500 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
502 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
504 * nsterm.m (x_free_frame_resources):
505 Release f->output_data.ns->miniimage.
506 (ns_index_color): Fix indentation. Do not retain
507 color_table->colors[i].
509 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
512 * nsfns.m (x_set_background_color): Assign return value from
513 ns_index_color to face-background instead of NSColor*.
514 (ns_implicitly_set_icon_type): Fix indentation.
515 Change assignment in for loop to comparison.
517 * emacs.c (ns_pool): New variable.
518 (main): Assign ns_pool.
519 (Fkill_emacs): Call ns_release_autorelease_pool.
521 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
522 autorelease fdesc, release fdAttrs and tdict.
523 (ns_get_covering_families): Release charset.
524 (ns_findfonts): Release NSFontDescriptor created with new.
525 (ns_uni_to_glyphs): Fix indentation.
526 (setString): Release attrStr before assigning new value.
528 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
530 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
532 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
533 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
535 2011-12-18 David Reitter <reitter@cmu.edu>
537 * nsterm.m (ns_term_init): Subscribe for notifications
538 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
539 to method trackingNotification in EmacsMenu.
541 * nsmenu.m (trackingMenu): New variable.
542 (trackingNotification): New method (from Aquamacs).
543 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
544 from Aquamacs (Bug#7030).
546 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
548 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
549 (symbol_to_nsstring): Fix indentation.
550 (ns_symbol_to_pb): New function.
551 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
552 (Fns_rotate_cut_buffers_internal): Remove.
553 (Fns_store_selection_internal): Rename from
554 Fns_store_cut_buffer_internal.
555 (ns_get_foreign_selection, Fx_own_selection_internal)
556 (Fx_disown_selection_internal, Fx_selection_exists_p)
557 (Fns_get_selection_internal, Fns_store_selection_internal):
558 Use ns_symbol_to_pb and check if return value is nil.
559 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
560 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
561 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
562 renamed to Sns_store_selection_internal.
563 (ns_handle_selection_request): Move code to Fx_own_selection_internal
564 and remove this function.
565 (ns_handle_selection_clear): Remove, never used.
566 (Fx_own_selection_internal): Move code from ns_handle_selection_request
569 2011-12-17 Ken Brown <kbrown@cornell.edu>
571 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
572 GID is unknown (Bug#10257).
574 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
576 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
577 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
578 which caused a build failure on GNU/Linux IA-64. This problem was
579 introduced by my 2011-10-07 patch.
581 2011-12-15 Juri Linkov <juri@jurta.org>
583 * image.c (imagemagick_error): New function. (Bug#10112)
584 (imagemagick_load_image): Comment out `MagickSetResolution' call.
585 Use `imagemagick_error' where ImageMagick functions return
587 (Fimagemagick_types): Add `Fnreverse' to return the list in the
590 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
592 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
593 fill background (Bug#8992).
595 2011-12-13 Martin Rudalics <rudalics@gmx.at>
597 * window.c (Vwindow_combination_resize)
598 (Vwindow_combination_limit): Use t instead of non-nil in
600 (Vrecenter_redisplay): Add first sentence of doc-string on
602 (Frecenter): Fix doc-string typo.
604 2011-12-11 Kenichi Handa <handa@m17n.org>
606 * coding.c (Funencodable_char_position): Pay attention to the
607 buffer text relocation (Bug#9389).
609 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
611 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
612 gtk_init (Bug#10100).
614 2011-12-10 Eli Zaretskii <eliz@gnu.org>
616 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
617 IT->string is nil. (Bug#10263)
619 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
621 * nsterm.h (x_free_frame_resources): Declare.
623 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
624 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
626 * nsterm.h (ns_get_defaults_value): Declare.
628 * nsterm.m (ns_default): Call ns_get_defaults_value.
630 2011-12-09 Eli Zaretskii <eliz@gnu.org>
632 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
635 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
637 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
638 that where the value of an _OBJC_* symbol points to is in the .bss
641 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
643 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
644 after the loop to call ccl_driver at least once (Bug#8619).
646 2011-12-08 Kenichi Handa <handa@m17n.org>
648 * ftfont.c (get_adstyle_property): Fix previous change
651 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
653 * w32.c (init_environment): If no_site_lisp, remove site-lisp
654 dirs from the default value of EMACSLOADPATH (bug#10208).
656 2011-12-07 Glenn Morris <rgm@gnu.org>
658 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
659 installation and source directories as well. (Bug#10208)
661 2011-12-06 Chong Yidong <cyd@gnu.org>
663 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
665 2011-12-06 Glenn Morris <rgm@gnu.org>
667 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
668 as an error, not just -1. (Bug#10217)
670 2011-12-05 Chong Yidong <cyd@gnu.org>
672 * keyboard.c (process_special_events): New function.
673 (swallow_events, Finput_pending_p): Use it (Bug#10195).
675 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
677 * coding.c (encode_designation_at_bol): Don't use uninitialized
678 local variable (Bug#9318).
680 2011-12-05 Kenichi Handa <handa@m17n.org>
682 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
683 return Qnil (Bug#8046, Bug#10193).
685 2011-12-05 Kenichi Handa <handa@m17n.org>
687 * coding.c (encode_designation_at_bol): New args charbuf_end and
688 dst. Return the number of produced bytes. Callers changed.
689 (coding_set_source): Return how many bytes coding->source was
691 (coding_set_destination): Return how many bytes
692 coding->destination was relocated.
693 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
694 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
696 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
698 * coding.c (CODING_CHAR_CHARSET_P): New macro.
699 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
702 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
704 The following changes are to fix Bug#9318.
706 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
707 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
708 (encode_coding_iso_2022, encode_coding_sjis)
709 (encode_coding_big5, encode_coding_charset): Use the above macros.
711 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
713 * lisp.h (process_quit_flag): Fix external declaration.
715 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
717 Don't macro-inline non-performance-critical code.
718 * eval.c (process_quit_flag): New function.
719 * lisp.h (QUIT): Use it.
721 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
723 * nsfns.m (get_geometry_from_preferences): New function.
724 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
726 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
728 * emacs.c (Qkill_emacs): Define.
729 (syms_of_emacs): Initialize it.
730 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
731 Qquit_flag to `kill-emacs' instead.
732 (quit_throw_to_read_char): Add parameter `from_signal'.
733 All callers changed. Call Fkill_emacs if requested and safe.
734 * lisp.h (QUIT): Call Fkill_emacs if requested.
736 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
738 * widget.c (update_wm_hints): Return if wmshell is null.
739 (widget_update_wm_size_hints): New function.
741 * widget.h (widget_update_wm_size_hints): Declare.
743 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
744 widget_update_wm_size_hints (Bug#10104).
746 2011-12-03 Eli Zaretskii <eliz@gnu.org>
748 * xdisp.c (handle_invisible_prop): If the invisible text ends just
749 before a newline, prepare the bidi iterator for consuming the
750 newline, and keep the current paragraph direction. (Bug#10183)
751 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
753 2011-12-02 Juri Linkov <juri@jurta.org>
755 * search.c (Fword_search_regexp): New Lisp function created from
756 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
757 (Fword_search_backward, Fword_search_forward)
758 (Fword_search_backward_lax, Fword_search_forward_lax):
759 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
760 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
762 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
764 * fileio.c (Finsert_file_contents): Move after-change-function call
765 to before the "handled:" label, since all "goto handled" appear in
766 cases where the *-change-functions have already been properly called
769 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
771 * keyboard.c (interrupt_signal): Don't call kill-emacs when
772 waiting for input. (Bug#10169)
774 2011-11-30 Eli Zaretskii <eliz@gnu.org>
776 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
777 verifies glyph row's hash code--we have just reallocated the
778 glyphs, so their contents can be complete garbage. (Bug#10164)
780 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
782 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
784 2011-11-30 Eli Zaretskii <eliz@gnu.org>
786 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
787 attributes are tested _before_ calling verify_row_hash, to protect
788 against GCC re-ordering of the tests. (Bug#10164)
790 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
792 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
794 * xterm.c (handle_one_xevent): Only set async_visible and friends
795 if net_wm_state_hidden_seen is non-zero (Bug#10002)
796 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
797 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
799 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
801 Remove GCPRO-related macros that exist only to avoid shadowing locals.
802 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
803 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
804 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
805 All uses changed to use GCPRO1 etc.
806 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
807 Revert to old implementation (i.e., before 2011-03-11).
809 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
811 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
812 of scroll runs so as to avoid assigning disabled bogus rows and
813 unnecessary graphics copy operations.
815 2011-11-27 Eli Zaretskii <eliz@gnu.org>
817 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
818 (snprintf) [_MSC_VER]: Redirect to _snprintf.
819 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
820 (malloc, free, realloc, calloc): Redirect to e_* only when
823 * lisp.h (GCTYPEBITS): Move before first use.
824 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
825 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
826 this macro definition.
828 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
831 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
833 * gtkutil.c (xg_create_frame_widgets):
834 Call gtk_window_set_has_resize_grip (FALSE) if that function is
835 present with Gtk+ 2.0.
837 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
839 * fileio.c (Finsert_file_contents): Undo previous change; see
840 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
842 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
844 Rename locals to avoid shadowing.
845 * fileio.c (Finsert_file_contents):
846 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
847 * process.c (wait_reading_process_output):
848 Rename inner 'proc' to 'p' to avoid shadowing.
849 Indent for consistency with usual Emacs style.
851 2011-11-25 Eli Zaretskii <eliz@gnu.org>
853 * xdisp.c (redisplay_window): If cursor row is not fully visible
854 after recentering, and scroll-conservatively is set to a large
855 number, scroll window by a few more lines to make the cursor fully
856 visible and out of scroll-margin. (Bug#10105)
857 (start_display): Don't move to the next line if the display should
858 start at a newline that is part of a display vector or an overlay
861 2011-11-24 Juri Linkov <juri@jurta.org>
863 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
864 after the `MagickPingImage' call. (Bug#10112)
866 2011-11-23 Chong Yidong <cyd@gnu.org>
868 * window.c (Fcoordinates_in_window_p): Accept only live windows.
870 2011-11-23 Martin Rudalics <rudalics@gmx.at>
872 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
873 making another buffer current. (Bug#10114)
875 2011-11-23 Glenn Morris <rgm@gnu.org>
877 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
879 2011-11-23 Chong Yidong <cyd@gnu.org>
881 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
884 2011-11-22 Eli Zaretskii <eliz@gnu.org>
886 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
887 and header-lines, as they don't have one computed for them.
890 * .gdbinit (prow): Make displayed values more self-explaining.
893 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
895 * process.c (wait_reading_process_output): Fix asynchrounous
896 GnuTLS socket handling on some versions of the GnuTLS library.
897 (wait_reading_process_output): Add comment and URL.
899 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
901 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
903 2011-11-21 Chong Yidong <cyd@gnu.org>
905 * window.c (Fnext_window, Fprevious_window): Doc fix.
907 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
909 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
911 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
913 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
915 2011-11-20 Martin Rudalics <rudalics@gmx.at>
917 * window.c (Fset_window_combination_limit): Rename argument
919 (Vwindow_combination_limit): Remove "status" from doc-string.
921 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
923 * m/ibms390.h: Remove.
924 * m/ibms390x.h: Don't include "ibms390.h".
926 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
928 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
929 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
931 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
933 * casetab.c (Fset_case_table):
934 * charset.c (Fcharset_after): Fix typos.
936 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
938 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
939 Otherwise, valgrind does not work on some platforms.
940 Problem reported by Andreas Schwab in
941 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
942 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
943 is set, removing the need for VIRT_ADDRESS_VARIES.
944 (PURE_P): Use a more-efficient implementation that needs just one
945 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
946 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
947 to 4 (xorl, subq, cmpq, setbe).
948 * alloc.c (pure): Always extern now, since that's the
949 VIRT_ADDR_VARIES behavior.
950 (PURE_POINTER_P): Use a single comparison, not two, for
951 consistency with the new puresize.h.
952 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
953 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
954 Remove VIRT_ADDR_VARIES no longer needed.
956 2011-11-19 Eli Zaretskii <eliz@gnu.org>
958 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
959 (erase_phys_cursor, update_window_cursor, show_mouse_face)
960 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
961 behave as if the cursor position were at the window margin.
963 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
964 and the cursor position is out of bounds, behave as if the cursor
965 position were at the window margin. (Bug#10075)
967 2011-11-18 Chong Yidong <cyd@gnu.org>
969 * window.c (Fwindow_combination_limit): Make first argument
970 non-optional, since it is meaningless for live windows like the
973 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
975 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
977 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
979 * intervals.c: Fix grafting over the whole buffer (bug#10071).
980 (graft_intervals_into_buffer): Simplify.
982 2011-11-18 Eli Zaretskii <eliz@gnu.org>
984 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
985 hash values of the two rows.
986 (copy_row_except_pointers): Preserve the used[] arrays and the
987 hash values of the two rows. (Bug#10035)
988 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
990 * xdisp.c (row_hash): New function, body extracted from
991 compute_line_metrics.
992 (compute_line_metrics): Call row_hash, instead of computing the
995 * dispnew.c (verify_row_hash): Call row_hash for computing the
996 hash code of a row, instead of duplicating code from xdisp.c.
998 * dispextern.h (row_hash): Add prototype.
1000 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1002 * frame.c (delete_frame): Don't delete the terminal when the last
1003 X frame is closed if emacs is built with GTK toolkit.
1005 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1007 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1009 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1011 * window.c (Vwindow_splits): Rename to
1012 Vwindow_combination_resize. Suggested by Juri Linkov.
1013 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1016 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1018 * nsfns.m (Fns_font_name):
1019 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1021 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1023 * window.h (window): Rename slot "nest" to "combination_limit".
1024 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1025 (Fset_window_nest): Rename to Fset_window_combination_limit.
1026 (Vwindow_nest): Rename to Vwindow_combination_limit.
1027 (recombine_windows, make_parent_window, make_window)
1028 (Fsplit_window_internal, saved_window)
1029 (Fset_window_configuration, save_window_save): Rename all
1030 occurrences of window_nest to window_combination_limit.
1032 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1034 * image.c (imagemagick_load_image): Fix typo.
1036 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1038 * xdisp.c (display_line): Move the call to
1039 highlight_trailing_whitespace before the call to
1040 compute_line_metrics, since the latter needs to see the final
1041 faces of all the glyphs to compute ROW's hash value.
1042 Fixes assertion violations in row_equal_p. (Bug#10035)
1044 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1046 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1047 just return (bug#10044).
1049 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1051 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1052 with user-defined heap size. Bump the default size of the temacs
1053 heap to 27MB, to avoid memory warning when running temacs.
1054 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1056 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1057 current_matrix and desired_matrix. (Bug#9990)
1058 (verify_row_hash) [XASSERTS]: New function.
1059 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1060 that the hash value of glyph rows is correct.
1062 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1064 * window.h (window): Remove splits slot.
1065 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1066 (Fdelete_other_windows_internal, make_parent_window)
1067 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1068 (Fset_window_configuration, save_window_save): Don't deal with
1069 split status of windows.
1070 (saved_window): Remove splits slot.
1071 (Vwindow_splits): Rewrite doc-string.
1073 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1075 * xfns.c (unwind_create_frame):
1076 * nsfns.m (unwind_create_frame):
1077 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1078 Vframe_list (Bug#9999).
1080 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1082 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1084 2011-11-11 Kenichi Handa <handa@m17n.org>
1086 * callproc.c (Fcall_process): Set the member dst_multibyte of
1089 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1091 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1092 avoid a crash (bug#9496).
1094 2011-11-09 Chong Yidong <cyd@gnu.org>
1096 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1097 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1099 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1101 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1103 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1105 Avoid some portability problems by eschewing 'extern inline' functions.
1106 The trivial performance wins aren't worth the portability hassles; see
1107 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1109 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1110 (window_box_width, window_box_left, window_box_left_offset)
1111 (window_box_right, window_box_right_offset): Undo previous change,
1112 by removing the "extern"s.
1113 * intervals.c (adjust_intervals_for_insertion)
1114 (adjust_intervals_for_deletion): Undo previous change,
1115 making these static again.
1116 (offset_intervals, temp_set_point_both, temp_set_point)
1117 (copy_intervals_to_string): No longer inline.
1118 * xdisp.c (window_text_bottom_y, window_box_width)
1119 (window_box_height, window_box_left_offset)
1120 (window_box_right_offset, window_box_left, window_box_right)
1121 (window_box): No longer inline.
1123 2011-11-08 Chong Yidong <cyd@gnu.org>
1125 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1126 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1127 Signal an error if not a live window.
1128 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1129 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1131 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1133 * lisp.h (syms_of_abbrev): Remove declaration.
1134 Reported by CHENG Gao <chenggao@royau.me>.
1136 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1138 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1139 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1140 of temacs in GUI mode.
1142 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1144 * window.h: Declare delete_all_child_windows instead of
1145 delete_all_subwindows.
1146 * window.c (Fwindow_nest, Fset_window_nest)
1147 (Fset_window_new_total, Fset_window_new_normal)
1148 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1149 (delete_all_subwindows): Rename to delete_all_child_windows.
1150 (Fdelete_other_windows_internal, Fset_window_configuration):
1151 Call delete_all_child_windows instead of delete_all_subwindows.
1152 * frame.c (delete_frame): Call delete_all_child_windows instead
1153 of delete_all_subwindows.
1155 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1157 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1158 This is also needed for porting to any host where GC_MARK_STACK is
1159 not GC_MAKE_GCPROS_NOOPS.
1160 (which_symbols): Use it.
1162 2011-11-07 Kenichi Handa <handa@m17n.org>
1164 * coding.c (coding_set_destination): Check coding->src_pos only
1165 when coding->src_object is a buffer (bug#9910).
1167 * process.c (send_process): Set the member src_multibyte of coding
1168 to 0 (bug#9911) when sending a unibyte text.
1170 * callproc.c (Fcall_process): Set the member src_multibyte of
1171 process_coding to 0 (bug#9912).
1173 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1175 * xmenu.c (cleanup_widget_value_tree): New function.
1176 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1177 calling free_menubar_widget_value_tree directly (Bug#9830).
1179 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1181 Fix some portability problems with 'inline'.
1182 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1183 (window_box_width, window_box_left, window_box_left_offset)
1184 (window_box_right, window_box_right_offset): Declare extern.
1185 Otherwise, these inline functions do not conform to C99 and
1186 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1187 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1188 * intervals.c (adjust_intervals_for_insertion)
1189 (adjust_intervals_for_deletion): Now extern, because otherwise the
1190 extern inline functions 'offset_intervals' couldn't refer to it.
1191 (static_offset_intervals): Remove.
1192 (offset_intervals): Rewrite using the old contents of
1193 static_offset_intervals. The old version didn't conform to C99
1194 because an extern inline function contained a reference to an
1195 identifier with static linkage.
1197 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1199 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1202 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1204 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1205 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1206 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1207 return Qleft_to_right.
1209 2011-11-06 Chong Yidong <cyd@gnu.org>
1211 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1212 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1213 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1214 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1215 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1216 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1217 (Fwindow_vscroll): Doc fix.
1218 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1219 argument, since it makes no sense to pass a live window and for
1220 consistency with window-child.
1222 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1224 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1227 2011-11-05 Jason Rumney <jasonr@gnu.org>
1229 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1230 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1232 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1233 bitwise arithmetic preventing use of unicode-sip and non-truetype
1236 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1238 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1241 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1242 initialization code to keep similarity to xfns.c after changes
1245 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1247 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1248 (unwind_create_frame): New function (Bug#9943).
1249 (Fx_create_frame): Restructure code to be more similar to the one in
1250 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1251 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1252 Move terminal->reference_count++ just before making the frame official
1255 * nsterm.m (x_free_frame_resources): New function.
1256 (x_destroy_window): Move code to x_free_frame_resources.
1258 * xfns.c (unwind_create_frame): Fix comment.
1259 (Fx_create_frame, x_create_tip_frame):
1260 Move terminal->reference_count++ just before making the frame
1261 official. Move initialization of image_cache_refcount and
1262 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1264 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1266 Support MSVC build with newer versions of Visual Studio.
1267 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1268 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1271 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1272 which are not supported by MSVC.
1273 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1274 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1276 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1278 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1280 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1282 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1284 Support MSVC build with newer versions of Visual Studio.
1285 * w32.c: Don't include w32api.h for MSVC.
1286 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1288 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1289 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1290 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1291 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1293 (alloca) [_MSC_VER]: Define to _alloca.
1295 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1297 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1299 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1301 * xdisp.c (note_mouse_highlight): If either of
1302 previous/next-single-property-change returns nil, treat that as
1303 the beginning or the end of the buffer. (Bug#9955)
1305 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1307 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1308 label is not null (Bug#9951).
1309 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1312 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1314 * window.c (Fwindow_body_size): Mention in the doc string that the
1315 return value is in frame's canonical units. (Bug#9949)
1317 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1321 * w32fns.c (unwind_create_frame): If needed, free the glyph
1322 matrices of the partially constructed frame. (Bug#9943)
1323 * xfns.c (unwind_create_frame): Likewise.
1325 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1327 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1328 Don't stop backward scan on the continuation glyph, even though
1329 its CHARPOS is positive.
1330 (mouse_face_from_buffer_pos, note_mouse_highlight):
1331 Rename cover_string to disp_string.
1333 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1335 * window.c (temp_output_buffer_show): Don't use
1336 Vtemp_buffer_show_specifiers.
1337 (Vtemp_buffer_show_specifiers): Remove unused variable.
1339 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1341 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1342 past the beginning of the current glyph matrix.
1344 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1346 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1347 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1348 HAVE_GTK3 (Bug#9869).
1350 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1351 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1353 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1355 * xterm.c: Declare x_handle_net_wm_state to return int.
1356 (handle_one_xevent): Check if we are iconified but don't have
1357 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1358 (get_current_wm_state): Return non-zero if not hidden,
1359 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1360 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1361 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1362 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1364 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1366 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1367 so that this new function doesn't get optimized away by a
1368 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1370 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1372 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1374 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1376 Fix the `xbytecode' command.
1377 * .gdbinit (xprintbytestr): New command.
1378 (xwhichsymbols): Rename from `which'; all callers changed.
1379 (xbytecode): Print the byte-code string as well.
1381 2011-10-29 Kim Storm <storm@cua.dk>
1383 * alloc.c (which_symbols): New function.
1385 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1387 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1390 2011-10-29 Glenn Morris <rgm@gnu.org>
1392 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1393 Not clear what it was for, and it causes various bugs. (Bug#9839)
1395 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1397 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1398 possible random value that matches one of those tested as
1399 condition to clear the mouse face.
1401 2011-10-28 Chong Yidong <cyd@gnu.org>
1403 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1405 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1407 * window.c (make_window): Initialize phys_cursor_on_p.
1409 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1411 * lisp.h (struct Lisp_Symbol): Update comments.
1413 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1415 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1417 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1419 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1420 <oslsachem@gmail.com> for helping to debug this.
1422 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1423 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1424 (g_b_init_get_glyph_outline_w): New static variables.
1425 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1426 (GetGlyphOutlineW_Proc): New typedefs.
1427 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1428 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1430 (w32font_open_internal, compute_metrics):
1431 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1432 instead of calling the "wide" APIs directly.
1434 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1436 * w32.h (syms_of_w32font): Add prototype.
1438 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1440 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1441 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1442 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1443 (Fmove_to_window_line): Doc fix.
1445 2011-10-27 Chong Yidong <cyd@gnu.org>
1447 * process.c (make_process): Set gnutls_state to NULL.
1449 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1450 non-NULL, regardless of GNUTLS_INITSTAGE.
1451 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1452 an error. Set process slots as soon as we allocate them.
1454 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1456 2011-10-27 Chong Yidong <cyd@gnu.org>
1458 * gnutls.c (emacs_gnutls_deinit): New function.
1459 Deallocate credentials structures as well as calling gnutls_deinit.
1460 (Fgnutls_deinit, Fgnutls_boot): Use it.
1462 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1463 (deactivate_process): Call emacs_gnutls_deinit.
1465 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1467 * image.c (x_create_x_image_and_pixmap):
1468 * w32.c (sys_rename, w32_delayed_load):
1469 * w32font.c (fill_in_logfont):
1470 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1472 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1474 * w32fns.c (w32_default_color_map): New function,
1475 extracted from Fw32_default_color_map.
1476 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1478 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1480 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1482 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1484 * keyboard.c (test_undefined): New function (bug#9751).
1485 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1487 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1489 * sysdep.c (init_sys_modes): Fix the check for the controlling
1490 terminal (Bug#6649).
1492 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1494 * dispextern.h (struct bidi_it): New member next_en_type.
1496 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1497 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1498 current character, check also for next_en_type being WEAK_EN.
1499 (bidi_resolve_weak): Don't enter the expensive loop if the current
1500 position is before next_en_pos. Record the bidi type of the first
1501 non-ET, non-BN character we find, in addition to its position.
1502 (bidi_level_of_next_char): Invalidate next_en_type when
1503 next_en_pos is over-stepped.
1505 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1507 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1508 * editfns.c: Rewrite current-time-zone so that it invokes
1509 the equivalent of (format-time-string "%Z") to get the time zone name.
1510 This fixes a bug when the time zone name contains characters that
1511 need converting from the system time locale to Emacs internal format.
1512 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1513 that patch fixed format-time-string to do the conversion, but
1514 I forgot to fix current-time-zone.
1515 (format_time_string): New function, containing most of
1516 what Fformat_time_string used to contain.
1517 (Fformat_time_string): Rewrite in terms of format_time_string.
1518 This doesn't change this function's behavior.
1519 (current-time-zone): Rewrite to use format_time_string.
1520 This fixes the bug reported by Michael Schierl in
1521 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1522 Jason Rumney's 2007-06-07 change worked around this bug, but
1524 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1526 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1528 * xdisp.c (start_display): If the character at POS is displayed
1529 via a display vector, reset IT->current.dpvec_index to zero.
1530 (try_window_reusing_current_matrix): If a line ends in a display
1531 vector or the next line starts in a display vector, continue
1532 redrawing the window even though the character position of
1533 start_row was reached.
1536 2011-10-18 Chong Yidong <cyd@gnu.org>
1538 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1539 with nobreak-char-display too.
1541 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1543 Fix part 3 of bug#9771.
1544 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1545 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1546 non-neutral characters if the current character is a paragraph
1547 separator (a.k.a. Newline). This avoids running the same
1548 expensive loop twice, once when we consume the preceding newline
1549 and the other time when the line actually needs to be displayed.
1550 Avoid the loop when we see neutrals on the base embedding level
1551 following a character whose directionality is the same as the
1552 paragraph's. This avoids running the expensive loop when a line
1553 ends in a long sequence of neutrals, like control characters.
1554 Add assertion against STRONG_AL type. Slightly rearrange code
1555 that determines the type of a neutral given the first non-neutral
1557 (bidi_level_of_next_char): Set next_en_pos to zero when
1558 invalidating its info.
1560 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1562 * xdisp.c (push_display_prop): Determine whether to record string
1563 or buffer position by IT->string, not by IT->method. Allow
1564 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1565 (move_it_vertically_backward): Don't look for character position
1566 immediately after the newline when in a continuation line.
1569 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1571 * window.c (coordinates_in_window): Rewrite and delabelize
1572 vertical border check. (Bug#5357) (Bug#9618)
1574 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1576 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1577 errors in XSetWindowBorder (bug#9310).
1579 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1581 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1582 avoid crash when xmalloc overrun checking is enabled.
1584 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1586 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1587 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1588 cursor motion with <left> and <right> arrow keys.
1590 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1591 some callers set that themselves.
1593 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1595 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1596 display string and the previous row comes from the same string and
1597 is empty. (Bug#9739) (Bug#9738)
1599 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1601 * doc.c (get_doc_string): Encode file name (bug#9735).
1603 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1605 * bidi.c (bidi_level_of_next_char):
1606 * xdisp.c (get_visually_first_element): Remove old incorrect
1607 comments regarding the Unicode Line Separator character.
1609 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1611 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1613 * alloc.c (Fgc_status): Do not access beyond zombies array
1614 boundary if nzombies > MAX_ZOMBIES.
1615 * alloc.c (dump_zombies): Add missing format specifier.
1617 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1619 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1620 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1622 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1623 Some packages use them to denote characters with modifiers.
1625 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1627 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1628 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1629 matching a pp-number. Rename parameter var to var1.
1631 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1633 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1635 2011-10-08 Glenn Morris <rgm@gnu.org>
1637 * callint.c (Fcall_interactively): Give a more explicit error for the
1638 'c' case with a non-character input. (Bug#8479)
1640 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1642 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1644 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1645 lines that are hscrolled on the left.
1647 * dispnew.c (buffer_posn_from_coords): Account for a possible
1648 presence of header-line. (Bug#4426)
1650 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1652 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1653 Don't advertise functionality which we discourage or doesn't work.
1655 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1657 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1658 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1659 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1660 this makes Emacs dump core during garbage collection on rare
1661 occasions. sizeof is obviously inferior to offsetof here, so
1662 stick with offsetof.
1663 (GC_POINTER_ALIGNMENT): New macro.
1664 (mark_memory): Omit 3rd (offset) arg; caller changed.
1665 Don't assume EMACS_INT alignment is the same as pointer alignment.
1667 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1669 * keyboard.c (read_key_sequence_remapped): New var.
1670 (read_key_sequence): Compute remapping in the right buffer.
1671 (command_loop_1): Use read_key_sequence's remapping directly.
1673 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1675 * dired.c (file_name_completion): Don't expand file name.
1676 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1677 before checking file name handler.
1679 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1680 they've been requested explicitly (bug#9591).
1682 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1684 * keymap.c (Fsingle_key_description): Use make_specified_string
1685 instead of build_string to build string from push_key_description.
1688 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1690 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1691 This fixes a Y2038 bug on 64-bit hosts.
1692 * buffer.c (reset_buffer):
1693 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1694 (Fclear_buffer_auto_save_failure):
1695 Use 0, not -1, to represent an unset failure time, since time_t
1696 might not be signed.
1698 Remove dependency on glibc malloc internals.
1699 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1700 Move back here from lisp.h, but with their new implementations.
1701 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1702 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1703 * charset.c (charset_table_init): New static var.
1704 (syms_of_charset): Use it instead of xmalloc. This removes a
1705 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1706 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1707 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1708 Move back to alloc.c.
1709 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1710 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1712 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1714 * nsterm.m (windowDidResize): Call x_set_window_size only when
1715 ns_in_resize is true. Otherwise set pixelwidth/height and
1716 call change_frame_size (Bug#9628).
1718 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1720 Port --enable-checking=all to Fedora 14 x86-64.
1721 * charset.c (syms_of_charset): Also account for glibc malloc's
1722 internal overhead when calculating the initial malloc maximum.
1724 Port --enable-checking=all to Fedora 14 x86.
1725 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1727 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1728 (overrun_check_realloc, overrun_check_free):
1729 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1730 That way, xmalloc returns a properly-aligned pointer even if
1731 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1732 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1733 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1734 into account when calculating the initial malloc maximum.
1735 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1736 Move here from alloc.c, so that charset.c can use it too.
1737 Properly align; the old code wasn't right for common 32-bit hosts
1738 when configured with --enable-checking=all.
1739 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1740 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1742 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1744 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1747 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1749 * xdisp.c (compute_display_string_end): If there's no display
1750 string at CHARPOS, return -1.
1752 * bidi.c (bidi_fetch_char): When compute_display_string_end
1753 returns a negative value, treat the character as a normal
1754 character not covered by a display string. (Bug#9624)
1756 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1758 * lread.c (Fread_from_string): Fix typo in docstring.
1760 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1762 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1763 newline, reseat the iterator instead of bidi-iterating there one
1764 character at a time. (Bug#9610)
1765 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1766 TO_CHARPOS if the bidi iterator is at base embedding level.
1768 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1770 * lread.c (readevalloop): Use correct code for NBSP.
1771 (read1): Likewise. (Bug#9608)
1773 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1775 * dbusbind.c (Fdbus_register_signal): When service is not
1776 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1778 2011-09-25 Glenn Morris <rgm@gnu.org>
1780 * buffer.c (truncate-lines): Doc fix.
1782 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1784 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1785 (Fset_window_next_buffers): Doc fix.
1787 2011-09-24 Glenn Morris <rgm@gnu.org>
1789 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1791 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1793 Fix minor problems found by static checking.
1794 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1795 * indent.c (Fvertical_motion): Fix == vs = typo.
1797 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1799 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1800 Default value is now t. Doc fix.
1802 * indent.c (Fvertical_motion): Compute and apply the overshoot
1803 logic when moving up, not only when moving down. Fix the
1804 confusing name and values of the it_overshoot_expected variable;
1805 logic changes accordingly. (Bug#9254) (Bug#9549)
1807 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1808 CHARPOS is covered by a display string which includes newlines.
1809 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1810 is covered by a display string with embedded newlines.
1812 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1814 * dbusbind.c (Fdbus_register_signal): Add match rule to
1815 Vdbus_registered_objects_table. (Bug#9581)
1816 (Fdbus_register_method, Vdbus_registered_objects_table):
1819 2011-09-24 Jim Meyering <meyering@redhat.com>
1821 do not ignore write error for any output size
1822 The previous change was incomplete.
1823 While it makes emacs --batch detect the vast majority of stdout
1824 write failures, errors were still ignored whenever the output size is
1825 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1826 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1827 && echo FAIL: ignored write error
1828 FAIL: ignored write error
1829 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1830 && echo FAIL: ignored write error
1831 FAIL: ignored write error
1832 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1834 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1836 * emacs.c (Fkill_emacs): In noninteractive mode exit
1837 non-successfully if a write error occurred on stdout. (Bug#9574)
1839 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1841 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1844 * dispextern.h (struct it): Update the comment documenting what
1847 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1849 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1850 a display string, extend search for cursor position to end of row.
1851 (find_row_edges): If the row ends in a newline from a display
1852 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1853 Handle the case of a display string with multiple newlines.
1854 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1855 non-empty line. Fixes confusing cursor motion with arrow keys at
1856 the beginning of a line that starts with whitespace.
1858 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1860 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1863 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1865 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1868 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1870 * xdisp.c (display_line): Record maximum and minimum buffer
1871 positions even if no glyphs were produced (e.g., by a zero-width
1872 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1873 buffer positions that will be removed from the glyph row because
1875 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1876 column is beyond frame width: don't subtract 1 "pixel" when
1877 computing width of the stretch.
1878 (reseat_at_next_visible_line_start): Undo the change made on
1879 2011-09-17 that saved paragraph information and restored it after
1880 the call to `reseat'. (Bug#9545)
1882 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1884 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1885 and turn window cursor on if cleared (Bug#9415).
1887 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1889 * search.c (boyer_moore): Take unibyte characters from pattern
1890 literally. (Bug#9458)
1892 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1894 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1896 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1898 Fix minor problem found by static checking.
1899 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1900 initialized, to pacify gcc -Wuninitialized.
1902 * fileio.c: Report proper errno when syscall falls.
1903 (Finsert_file_contents): Save and restore errno,
1904 so that report_file_error outputs the correct diagnostic.
1905 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1907 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1909 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1911 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1913 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1914 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1916 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1918 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1919 about the current paragraph and restore it after the call to reseat.
1921 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1922 (bidi_find_paragraph_start): Search back for paragraph beginning
1923 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1924 (bidi_move_to_visually_next): Only trigger paragraph-related
1925 computations when the last character is a newline or at EOB, not
1926 just any NEUTRAL_B. (Bug#9470)
1928 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1929 truncated lines if point is covered by a display string. (Bug#9524)
1931 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1933 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1934 (cons_to_x_long): New function.
1935 (lisp_data_to_selection_data): Use it. Correct the test for
1936 short-versus-long data; it was negated. Break out of vector
1937 loop, for efficiency, when a long datum is discovered.
1939 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1941 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1943 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1945 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1946 GCC PR/17406) by declaring this function with external scope.
1948 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1950 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1951 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1953 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1955 * editfns.c (Fformat): Correctly handle text properties on "%%".
1957 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1959 * xterm.c (x_draw_composite_glyph_string_foreground):
1960 * w32term.c (x_draw_composite_glyph_string_foreground):
1961 * term.c (encode_terminal_code):
1962 * composite.c (composition_update_it, get_composition_id):
1963 * xdisp.c (get_next_display_element)
1964 (fill_composite_glyph_string): Add comments about special meaning
1965 of TAB characters in a composition.
1967 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1969 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1970 This occurs when processing a multibyte format.
1971 Problem reported by Wolfgang Jenker.
1973 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1975 * xdisp.c (try_cursor_movement): Only check for exact match if
1976 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1978 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1980 Remove unused external symbols.
1981 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1982 * xdisp.c (calc_pixel_width_or_height): Now static.
1983 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1984 * indent.c (check_display_width):
1985 * w32term.c: Fix comment to match code.
1986 * xterm.c, xterm.h (x_catching_errors): Remove.
1988 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1990 * xselect.c: Use signed conversions more consistently (Bug#9498).
1991 (selection_data_to_lisp_data): Assume incoming selection data are
1992 signed integers, not unsigned. This is to be consistent with
1993 outgoing selection data, which was modified to use signed integers
1994 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1995 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1996 expects long, not unsigned long.
1998 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2000 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2001 computation of loop end. Reported by Johan Bockgård
2004 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2006 * frame.c (Fother_visible_frames_p): Function deleted.
2008 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2010 * indent.c (compute_motion): Process display vector front to back
2011 rather than the other way around. (Bug#2496)
2013 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2015 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2017 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2019 * minibuf.c (Fread_from_minibuffer): Doc fix.
2021 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2023 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2024 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2026 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2028 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2029 value for non-existent files.
2031 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2033 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2034 set its "size" to -1. This will set the modtime_size field of
2035 the corresponding buffer to -1, which is what
2036 verify-visited-file-modtime expects for files that do not exist.
2039 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2041 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2043 * lisp.h: ... from here. push_key_description is no longer
2044 defined in keyboard.c, so its declaration should not be in
2045 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2046 logically belongs with push_key_description.
2048 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2050 * buffer.h: Include <sys/types.h> instead of <time.h>.
2051 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2052 Problem reported by Herbert J. Skuhra.
2054 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2056 * xml.c (parse_region): Make the parsing work for
2057 non-comment-starting XML files again (bug#9144).
2059 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2061 * image.c (gif_load): Fix calculation of bottom and right corner.
2064 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2066 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2067 redisplay in small windows.
2069 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2071 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2073 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2075 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2076 Operate on live windows only.
2078 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2080 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2082 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2084 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2085 only under bidi iteration.
2087 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2089 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2091 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2093 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2094 Without this fix, the command to link temacs failed due to an
2095 undefined symbol __builtin_isnan. This is because
2096 /usr/include/iso/math_c99.h #defines isnan(x) to
2097 __builtin_isnan(x), but the bundled gcc, which identifies itself
2098 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2100 * floatfns.c (isnan): #undef, and then #define to a clone of
2102 (Fisnan): Always define, since it's always available now.
2103 (syms_of_floatfns): Always define isnan at the Lisp level.
2105 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2107 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2109 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2111 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2112 The previous code assumed that file offsets (off_t values) fit in
2113 EMACS_INT variables, which is not true on typical 32-bit hosts.
2114 The code messed up by falsely reporting buffer overflow in cases
2115 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2116 when "big" contains more than 2**29 bytes, even though this
2117 inserts just one byte and does not overflow the buffer.
2118 (Finsert_file_contents): Store file offsets as off_t
2119 values, not as EMACS_INT values. Check for overflow when
2120 converting between EMACS_INT and off_t. When checking for
2121 buffer overflow or for overlap, take the offsets into account.
2122 Don't use EMACS_INT for small values where int suffices.
2123 When checking for overlap, fix a typo: ZV was used where
2124 ZV_BYTE was intended.
2125 (Fwrite_region): Don't assume off_t fits into 'long'.
2126 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2128 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2130 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2132 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2134 sprintf-related integer and memory overflow issues (Bug#9412).
2136 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2137 (esprintf, exprintf, evxprintf): New functions.
2138 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2139 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2140 (modify_event_symbol): Do not assume that the length of
2141 name_alist_or_stem is safe to alloca and fits in int.
2142 (Fexecute_extended_command): Likewise for function name and binding.
2143 (Frecursion_depth): Wrap around reliably on integer overflow.
2144 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2145 since some callers pass EMACS_INT values.
2146 (Fsingle_key_description): Don't crash if symbol name contains more
2147 than MAX_ALLOCA bytes.
2148 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2149 (get_minibuffer): Arg is now EMACS_INT, not int.
2150 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2151 (esprintf, exprintf, evxprintf): New decls.
2152 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2154 * dbusbind.c (signature_cat): New function.
2155 (xd_signature, Fdbus_register_signal):
2156 Do not overrun buffer; instead, report string overflow.
2158 * dispnew.c (add_window_display_history): Don't overrun buffer.
2159 Truncate instead; this is OK since it's just a log.
2161 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2162 even if the time zone offset is outlandishly large.
2163 Don't mishandle offset == INT_MIN.
2165 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2166 when creating daemon; the previous buffer-overflow check was incorrect.
2168 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2169 which has the guts of the old verror function.
2171 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2172 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2174 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2175 (font_unparse_xlfd): Don't blindly alloca long strings.
2176 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2177 fits in int, when using sprintf. Use single snprintf to count
2178 length of string rather than counting it via multiple sprintfs;
2179 that's simpler and more reliable.
2180 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2181 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2182 sprintf, in case result does not fit in int.
2184 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2185 (fontset_from_font): Print it.
2187 * frame.c (tty_frame_count): Now printmax_t, not int.
2188 (make_terminal_frame, set_term_frame_name): Print it.
2189 (x_report_frame_params): In X, window IDs are unsigned long,
2190 not signed long, so print them as unsigned.
2191 (validate_x_resource_name): Check for implausibly long names,
2192 and don't assume name length fits in 'int'.
2193 (x_get_resource_string): Don't blindly alloca invocation name;
2194 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2197 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2198 (xg_check_special_colors, xg_set_geometry):
2199 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2201 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2202 Use esprintf, not sprintf, in case result does not fit in int.
2204 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2205 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2206 it as a large positive number.
2207 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2208 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2210 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2211 in case result does not fit in int.
2213 * print.c (float_to_string): Detect width overflow more reliably.
2214 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2215 buffer overrun. Don't assume list length fits in 'int'. Treat
2216 print length of 0 as 0, not as infinity; to be consistent with other
2217 uses of print length in this function. Don't overflow print length
2218 index. Don't assume hash table size fits in 'long', or that
2219 vectorlike size fits in 'unsigned long'.
2221 * process.c (make_process): Use printmax_t, not int, to format
2222 process-name gensyms.
2224 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2226 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2227 to avoid potential buffer overrun.
2229 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2230 if X resource line is longer than 512 bytes.
2232 * xfns.c (x_window): Make sprintf buffer a bit bigger
2233 to avoid potential buffer overrun.
2235 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2237 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2239 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2241 Integer overflow fixes for scrolling, etc.
2242 Without these, Emacs silently mishandles large integers sometimes.
2243 For example, "C-u 4294967297 M-x recenter" was treated as if
2244 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2246 * xdisp.c (try_window_id): Check Emacs fixnum range before
2247 converting to 'int'.
2249 * window.c (window_scroll_line_based, Frecenter):
2250 Check that an Emacs fixnum is in range before assigning it to 'int'.
2251 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2252 values converted from Emacs fixnums.
2253 (Frecenter): Don't wrap around a line count if it is out of 'int'
2254 range; instead, treat it as an extreme value.
2255 (Fset_window_configuration, compare_window_configurations):
2256 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2258 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2259 that can exceed INT_MAX. Check that EMACS_INT value is in range
2260 before assigning it to the (possibly-narrower) index.
2261 (match_limit): Don't assume that a fixnum can fit in 'int'.
2263 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2266 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2267 (Fvertical_motion): Don't wrap around LINES values that don't fit
2268 in 'int'. Instead, treat them as extreme values. This is good
2269 enough for windows, which can't have more than INT_MAX lines anyway.
2271 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2273 * Require libxml/parser.h to avoid compilation warning.
2275 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2277 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2278 since this reportedly can destroy thread storage.
2280 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2282 * syntax.c (find_defun_start): Update all cache variables if
2283 exiting early (Bug#9401).
2285 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2287 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2289 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2290 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2291 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2293 * term.c (tty_append_glyph): New function.
2294 (produce_stretch_glyph): Static function and its prototype deleted.
2296 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2299 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2301 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2302 when checking :margin (Bug#9390).
2303 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2304 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2305 so that the name doesn't mislead. All uses changed.
2307 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2309 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2312 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2314 * xdisp.c (move_it_to): Don't bail out early when reaching
2315 position beyond to_charpos, if we are scanning backwards.
2316 (move_it_vertically_backward): When DY == 0, make sure we get to
2317 the first character in the line after the newline.
2319 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2321 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2322 (ccl_driver): Do not generate an out-of-range pointer.
2323 (Fccl_execute_on_string): Remove unnecessary check for
2324 integer overflow, noted by Stefan Monnier in
2325 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2326 Remove a FIXME that didn't need fixing.
2327 Simplify the newly-introduced buffer reallocation code.
2329 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2331 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2333 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2335 Integer and memory overflow issues (Bug#9196).
2337 * doc.c (get_doc_string): Rework so that
2338 get_doc_string_buffer_size is the actual buffer size, rather than
2339 being 1 less than the actual buffer size; this makes xpalloc more
2342 * image.c (x_allocate_bitmap_record, cache_image):
2343 * xselect.c (Fx_register_dnd_atom):
2344 Simplify previous changes by using xpalloc.
2346 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2347 since either will do and ptrdiff_t is convenient with xpalloc.
2349 * charset.c (charset_table_size)
2350 (struct charset_sort_data.priority): Now ptrdiff_t.
2351 (charset_compare): Don't overflow if priorities differ greatly.
2352 (Fsort_charsets): Don't assume list length fits in int.
2353 Check for size-calculation overflow when allocating sort data.
2354 (syms_of_charset): Allocate an initial charset table that is
2355 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2357 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2359 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2360 The actual value is always <= INT_MAX, and leaving it unsigned made
2361 overflow checking harder.
2363 * dispextern.h (struct glyph_matrix.rows_allocated)
2364 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2365 with xpalloc. The values are still always <= INT_MAX.
2367 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2369 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2370 (SAFE_NALLOCA): New macro.
2372 * region-cache.c (struct boundary.pos, find_cache_boundary)
2373 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2374 (set_cache_region, invalidate_region_cache)
2375 (revalidate_region_cache, know_region_cache, region_cache_forward)
2376 (region_cache_backward, pp_cache):
2377 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2378 so that ptrdiff_t * can be passed to xpalloc.
2379 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2380 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2381 (pp_cache): Don't assume cache_len fits in int.
2382 * region-cache.h: Adjust extern decls to match.
2384 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2385 EMACS_INT, since either will do, for xpalloc.
2387 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2388 (xnmalloc, xnrealloc, xpalloc): New functions.
2390 * bidi.c (bidi_shelve_header_size): New constant.
2391 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2392 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2394 * bidi.c (bidi_cache_shrink):
2395 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2397 Don't update size of array until after memory allocation succeeds,
2398 because xmalloc/xrealloc may not return.
2399 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2400 now that we have proper integer overflow checking.
2401 (record_overlay_string, overlay_strings): Catch overflows when
2402 calculating size of overlay_str_buf.
2404 * callproc.c (Fcall_process): Check for size overflow when
2405 calculating size of args2.
2406 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2407 Normally we prefer signed values, but sticking with ptrdiff_t would
2408 require adding more-complicated checks.
2410 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2411 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2412 Redo buffer-overflow calculations to avoid integer overflow.
2413 Add a FIXME comment where memory seems to be over-allocated.
2415 * character.c (Fstring): Check for size-calculation overflow.
2417 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2418 unnecessary integer overflow. Check for size overflow.
2419 (encode_coding_object): Don't update size until xmalloc succeeds.
2421 * composite.c (get_composition_id): Check for overflow in glyph
2422 length calculations.
2424 Integer and memory overflow fixes for display code.
2425 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2426 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2427 (scrolling_window): Check for overflow in size calculations.
2428 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2429 Don't assume glyph table len fits in int.
2430 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2431 (row_table_size): Now ptrdiff_t, not int.
2432 (scrolling_window): Avoid overflow in size calculations.
2433 Don't update size until allocation succeeds.
2434 * fns.c (concat): Check for overflow in size calculations.
2435 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2436 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2437 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2439 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2440 (get_doc_string): Check for size calculation overflow.
2441 Don't update size until allocation succeeds.
2442 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2443 EMACS_INT, where ptrdiff_t will do.
2444 (Fsubstitute_command_keys): Check for string overflow.
2446 * editfns.c (set_time_zone_rule): Don't assume environment length
2448 (message_length): Now ptrdiff_t, not int.
2449 (Fmessage_box): Don't update size until allocation succeeds.
2450 Don't assume message length fits in int.
2451 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2453 * emacs.c (main): Do not reallocate argv, since there is a null at
2454 the end that can be overwritten, and this way there's no need to
2455 worry about size-calculation overflow.
2456 (sort_args): Check for size-calculation overflow.
2458 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2460 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2462 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2463 (x_set_scroll_bar_width, x_figure_window_size):
2464 Check for integer overflow.
2465 (x_set_alpha): Do not assume XINT fits in int.
2467 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2468 This is for the members text_lines, text_cols, total_lines, total_cols,
2469 where the system imposes an 'int' limit.
2471 * fringe.c (Fdefine_fringe_bitmap):
2472 Don't update size until alloc works.
2474 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2475 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2477 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2478 Check for size-calculation overflow.
2479 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2480 do, as we prefer signed integers.
2481 (id_to_widget.max_size, id_to_widget.used)
2482 (xg_store_widget_in_map, xg_remove_widget_from_map)
2483 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2484 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2485 Use and return ptrdiff_t, not int.
2486 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2487 * gtkutil.h: Change prototypes to match the above.
2489 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2490 are duplicate now that they've been promoted to lisp.h.
2491 (x_allocate_bitmap_record, x_alloc_image_color)
2492 (make_image_cache, cache_image, xpm_load):
2493 Don't update size until alloc is done.
2494 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2496 Check for size calculation overflow.
2497 (ct_colors_allocated_max): New constant.
2498 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2501 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2502 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2503 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2504 Use ptrdiff_t, not int, to count maps.
2505 (read_char_minibuf_menu_prompt): Check for overflow in size
2506 calculations. Don't update size until allocation succeeds.
2507 Redo calculations to avoid overflow.
2508 * keyboard.h: Change prototypes to match the above.
2510 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2512 (current_minor_maps): Check for size calculation overflow.
2513 * keymap.h: Change prototypes to match the above.
2515 * lread.c (read1, init_obarray): Don't update size until alloc done.
2517 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2518 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2520 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2521 Now ptrdiff_t, not int.
2522 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2523 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2525 * process.c (Fnetwork_interface_list): Check for overflow
2526 in size calculation.
2528 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2530 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2531 overflow. Don't bother calling xmalloc when xrealloc will do.
2533 * search.c (Freplace_match): Check for size calculation overflow.
2534 (Fset_match_data): Don't assume list lengths fit in 'int'.
2536 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2537 for command line length. Do not attempt to address one before the
2538 beginning of an array, as that's not portable.
2540 * term.c (max_frame_lines): Remove; unused.
2541 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2543 (encode_terminal_code, calculate_costs): Check for size
2544 calculation overflow.
2545 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2546 table lengths and related sizes. Don't update size until alloc
2547 done. Redo calculations to avoid overflow.
2548 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2550 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2551 subtracting pointers.
2552 (gobble_line): Check for overflow more carefully. Don't update size
2555 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2556 Don't update size until alloc done.
2557 Redo size calculations to avoid overflow.
2558 Check for size calculation overflow.
2559 (main) [DEBUG]: Fix typo in invoking tparam1.
2561 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2562 Use ptrdiff_t, not int, for sizes.
2563 (store_mode_line_noprop_char): Don't update size until alloc done.
2565 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2566 Use ptrdiff_t, not int, for sizes.
2567 (Finternal_make_lisp_face, cache_face):
2568 Check for size calculation overflow.
2569 (cache_face): Treat size calculation overflows as if they were
2570 memory exhaustion (the usual treatment), rather than aborting.
2572 * xfns.c (x_encode_text, x_set_name_internal)
2573 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2574 sizes, since they can exceed INT_MAX in size. Check for size
2575 calculation overflow.
2577 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2578 (xg_select): Check for size calculation overflow.
2579 Don't update size until alloc done.
2581 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2582 as sprintf is limited to int lengths.
2584 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2585 (X_LONG_MIN): New macros.
2586 Use them to make the following changes clearer.
2587 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2588 This change doesn't affect the value now, but it may help remind
2589 future maintainers not to raise the value too much later.
2590 (SELECTION_QUANTUM): Remove, replacing with ...
2591 (selection_quantum): ... new function, which avoids overflow.
2593 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2594 assumption that selection length fits in 'int'.
2595 (x_reply_selection_request, x_handle_selection_request)
2596 (x_get_window_property, receive_incremental_selection)
2597 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2598 (lisp_data_to_selection_data, clean_local_selection_data):
2599 Use ptrdiff_t, not int, to record length of selection.
2600 (x_reply_selection_request, x_get_window_property)
2601 (receive_incremental_selection, x_property_data_to_lisp):
2602 Redo calculations to avoid overflow.
2603 (x_reply_selection_request): When sending hint, ceiling it at
2604 X_LONG_MAX rather than relying on wraparound overflow to send
2606 (x_get_window_property, receive_incremental_selection)
2607 (lisp_data_to_selection_data, x_property_data_to_lisp):
2608 Check for size-calculation overflow.
2609 (x_get_window_property, receive_incremental_selection)
2610 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2611 Don't store size until memory allocation succeeds.
2612 (x_get_window_property): Plug memory leak on memory exhaustion.
2613 Don't double-block input; malloc is safe here. Don't assume 2**34
2614 - 4 fits in unsigned long. Add an xassert to check
2615 XGetWindowProperty overflow. Be more careful about overflow
2616 calculations, and distinguish size from memory overflow better.
2617 (receive_incremental_selection): When tracing, don't assume
2618 unsigned int is less than INT_MAX.
2619 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2620 harmful) conversions of unsigned short to int.
2621 (lisp_data_to_selection_data): Don't assume that integers
2622 in the range -65535 through -1 fit in an X unsigned short.
2623 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2624 result parameters unless successful. Rely on cons_to_unsigned
2625 to report problems with elements; the old code wasn't right anyway.
2626 (x_check_property_data): Check for int overflow; we cannot use
2627 a wider type due to X limits.
2628 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2630 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2632 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2633 (x_term_init): Check for size calculation overflow.
2634 (x_color_cells): Don't store size until memory allocation succeeds.
2635 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2636 Don't assume alloca size is less than MAX_ALLOCA.
2637 (x_term_init): Don't assume length fits in int (sprintf is limited
2640 Use ptrdiff_t for composition IDs.
2641 * character.c (lisp_string_width):
2642 * composite.c (composition_table_size, n_compositions)
2643 (get_composition_id, composition_gstring_from_id):
2644 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2645 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2646 * window.c (Frecenter):
2647 Use ptrdiff_t, not int, for composition IDs.
2648 * composite.c (get_composition_id): Check for integer overflow.
2649 * composite.h: Adjust prototypes to match the above changes.
2651 Use ptrdiff_t for hash table indexes.
2652 * category.c (hash_get_category_set):
2653 * ccl.c (ccl_driver):
2654 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2655 * coding.c (coding_system_charset_list, detect_coding_system):
2656 * coding.h (struct coding_system.id):
2657 * composite.c (get_composition_id, gstring_lookup_cache):
2658 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2659 * image.c (xpm_get_color_table_h):
2660 * lisp.h (hash_lookup, hash_put):
2661 * minibuf.c (Ftest_completion):
2662 Use ptrdiff_t for hash table indexes, not int (which is too
2663 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2664 32-bit --with-wide-int hosts).
2666 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2667 Add a FIXME comment about memory leaks.
2668 (syms_of_charset): Don't assume xmalloc returns.
2670 Don't assume that stated character widths fit in int.
2671 * character.c (Fchar_width, c_string_width, lisp_string_width):
2672 * character.h (CHAR_WIDTH):
2673 * indent.c (MULTIBYTE_BYTES_WIDTH):
2674 Use sanitize_char_width to avoid undefined and/or bad behavior
2675 with outlandish widths.
2676 * character.h (sanitize_tab_width): Rename from sanitize_width,
2677 now that we have two such functions. All uses changed.
2678 (sanitize_char_width): New inline function.
2680 Don't assume that tab-width fits in int.
2681 * character.h (sanitize_width): New inline function.
2682 (SANE_TAB_WIDTH): New macro.
2683 (ASCII_CHAR_WIDTH): Use it.
2684 * indent.c (sane_tab_width): Remove. All uses replaced by
2685 SANE_TAB_WIDTH (current_buffer).
2686 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2688 * fileio.c: Integer overflow issues with file modes.
2689 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2691 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2692 Remove unreachable code.
2693 (read_hex, load_charset_map_from_file): Check for integer overflow.
2695 * xterm.c: Don't go over XClientMessageEvent limit.
2696 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2697 (x_send_scroll_bar_event): Likewise. Check that the size does not
2698 exceed limits imposed by XClientMessageEvent, as well as the usual
2699 ptrdiff_t and size_t limits.
2701 * keyboard.c: Overflow, signedness and related fixes.
2702 (make_lispy_movement): Use same integer type in forward decl
2703 that is used in the definition.
2704 (read_key_sequence, keyremap_step):
2705 Change bufsize argument back to int, undoing my 2011-03-30 change.
2706 We prefer signed types, and int is wide enough here.
2707 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2708 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2709 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2710 length, not size_t. Use ptrdiff_t for index, not int.
2711 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2712 possibility of integer overflow.
2714 Overflow, signedness and related fixes for images.
2716 * dispextern.h (struct it.stack[0].u.image.image_id)
2717 (struct_it.image_id, struct image.id, struct image_cache.size)
2718 (struct image_cache.used, struct image_cache.ref_count):
2719 * gtkutil.c (update_frame_tool_bar):
2720 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2721 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2722 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2723 * nsmenu.m (update_frame_tool_bar):
2724 * xdisp.c (calc_pixel_width_or_height):
2725 * xfns.c (image_cache_refcount):
2726 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2727 on typical 64-bit hosts.
2729 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2730 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2731 Omit unnecessary casts to int.
2732 (parse_image_spec): Check that integers fall into 'int' range
2733 when the callers expect that.
2734 (image_ascent): Redo ascent calculation to avoid int overflow.
2735 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2736 (lookup_image): Remove unnecessary tests.
2737 (xbm_image_p): Locals are now of int, not EMACS_INT,
2738 since parse_image_check makes sure they fit into int.
2739 (png_load, gif_load, svg_load_image):
2740 Prefer int to unsigned where either will do.
2741 (tiff_handler): New function, combining the cores of the
2742 old tiff_error_handler and tiff_warning_handler.
2743 This function is rewritten to use vsnprintf and thereby avoid
2744 stack buffer overflows. It uses only the features of vsnprintf
2745 that are common to both POSIX and native Microsoft.
2746 (tiff_error_handler, tiff_warning_handler): Use it.
2747 (tiff_load, gif_load, imagemagick_load_image):
2748 Don't assume :index value fits in 'int'.
2749 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2750 (imagemagick_load_image): Check that crop parameters fit into
2751 the integer types that MagickCropImage accepts. Don't assume
2752 Vimagemagick_render_type has a nonnegative value. Don't assume
2753 size_t fits in 'long'.
2754 (gs_load): Use printmax_t to print the widest integers possible.
2755 Check for integer overflow when computing image height and width.
2757 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2759 * xdisp.c (redisplay_window): Don't force window start if point
2760 will be invisible in the resulting window. (Bug#9324)
2762 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2764 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2765 the display spec is of the form `(space ...)'.
2766 (handle_display_spec): Return the value returned by
2767 handle_single_display_spec, not just 1 or zero.
2768 (handle_single_display_spec): If the display spec is of the form
2769 `(space ...)', and specifies display in the text area, return 2
2771 (try_cursor_movement): Check for the need to scroll more
2772 accurately, and prefer exact match for point under bidi.
2773 Don't advance `row' beyond the last row of the window.
2775 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2776 into disp_prop; all users changed.
2778 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2779 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2780 for the text covered by the display property.
2782 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2784 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2785 Change return value to nil.
2786 (Frecord_buffer): Delete unused function.
2788 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2791 buffers, return left-to-right.
2792 (set_cursor_from_row): Consider candidate row a win if its glyph
2793 represents a newline and point is on that newline. Fixes cursor
2794 positioning on the newline at EOL of R2L text within L2R
2795 paragraph, and vice versa.
2796 (try_cursor_movement): Check continued rows, in addition to
2797 continuation rows. Fixes unwarranted scroll when point enters a
2798 continued line of R2L text within an L2R paragraph, or vice versa.
2799 (cursor_row_p): Consider the case of point being equal to
2800 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2801 from the end of a short line to the beginning of a continued line
2802 of R2L text within L2R paragraph.
2803 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2804 composed characters.
2806 * bidi.c (bidi_check_type): Use xassert.
2807 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2810 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2812 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2815 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2817 * nsfont.m (ns_otf_to_script): Fix typo.
2819 2011-08-22 Kenichi Handa <handa@m17n.org>
2821 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2822 extra slot even if the purpose is char-code-property-table.
2824 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (redisplay_window): When computing centering_position,
2827 account for the height of the header line. (Bug#8874)
2829 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2830 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2831 candidate is selected by the mouse, and that candidate has a
2832 composed character under the mouse.
2834 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2835 coordinates reported by pos-visible-in-window-p for a composed
2836 character in column zero.
2838 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2840 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2842 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2844 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2845 consider it a hit if to_charpos is anywhere in the range of the
2846 composed buffer positions.
2848 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2850 * image.c (gif_load): Don't assume that each subimage has the same
2851 dimensions as the base image. Handle disposal method that is
2852 "undefined" by the gif spec (Bug#9335).
2854 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2856 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2857 (Fcondition_case): Document `debug' symbol in error handler.
2859 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2861 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2862 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2863 from an Org mode buffer to a Speedbar frame.
2865 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2866 a composition, take its buffer position from IT->cmp_it.charpos.
2867 Fixes cursor positioning at the beginning of a line that begins
2868 with a composed character.
2870 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2872 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2873 character bidirectional type, use STRONG_L instead. Fixes crashes
2874 in a buffer produced by `describe-categories'.
2876 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2877 members before the level stack, so they would be saved and
2878 restored when copying iterator state. Fixes incorrect reordering
2879 around TABs covered by display properties.
2881 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2883 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2885 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2887 * eval.c (internal_condition_case, internal_condition_case_1)
2888 (internal_condition_case_2, internal_condition_case_n):
2889 Remove unnecessary aborts (Bug#9081).
2891 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2893 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2894 has no `load' handler, try opening the file locally. (Bug#9311)
2896 2011-08-16 Ken Brown <kbrown@cornell.edu>
2898 * gmalloc.c: Expand comment.
2900 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2902 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2903 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2905 2011-08-16 Ken Brown <kbrown@cornell.edu>
2907 Fix memory allocation problems in Cygwin build (Bug#9273).
2909 * unexcw.c ( __malloc_initialized): Declare external variable.
2910 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2912 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2914 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2916 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2918 [CYGWIN] (special_realloc): New function.
2919 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2920 requests to realloc storage in the static heap.
2922 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2924 * bidi.c (bidi_initialize): Remove unused local.
2926 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2929 * biditype.h: Remove file.
2930 * makefile.w32-in ($(BLD)/bidi.$(O)):
2931 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2933 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2935 * chartab.c: Improve commentary for the uniprop_table API.
2937 * bidi.c (bidi_paragraph_init): Support zero value of
2938 bidi_ignore_explicit_marks_for_paragraph_level.
2939 (bidi_initialize): Use uniprop_table instead of including
2940 biditype.h and bidimirror.h.
2942 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2943 coordinates of the iterator when restoring from ppos_it.
2946 2011-08-14 Kenichi Handa <handa@m17n.org>
2948 * process.c (create_process): Call setup_process_coding_systems
2949 after the pid of the process is set to -1 (Bug#8162).
2951 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2953 * xdisp.c (move_it_in_display_line_to): Don't invoke
2954 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2955 ppos_it. Fixes vertical cursor motion when line beginning is
2956 covered by an image. (Bug#9296)
2958 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2960 * nsterm.h (ns_run_ascript): Declare.
2961 (NSAPP_DATA2_RUNASSCRIPT): Define.
2963 * nsfns.m (as_script, as_result, as_status): New static variables.
2964 (ns_run_ascript): New function.
2965 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2966 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2967 the event loop. Get status from as_status (Bug#7276).
2969 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2970 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2971 the event loop (Bug#7276).
2973 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2975 * gnutls.c (QCgnutls_bootprop_priority)
2976 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2977 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2978 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2979 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2980 (QCgnutls_bootprop_verify_hostname_error)
2981 (QCgnutls_bootprop_callbacks_verify): Rename from
2982 Qgnutls_bootprop_..., all uses changed.
2984 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2987 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2989 * xfaces.c (Qframe_set_background_mode): Now static.
2990 * dispextern.h (Qframe_set_background_mode): Remove decl.
2992 * process.c (Fnetwork_interface_info): Declare local only if needed.
2994 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2996 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2997 (Fnetwork_interface_list): Allocate in increments of bytes instead
2998 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2999 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3001 (struct ifflag_def): notrailers is smart on OSX.
3002 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3003 Get hardware address with getifaddrs if available.
3005 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3007 * xdisp.c (iterate_out_of_display_property): xassert that
3008 IT->position is set to within IT->object's boundaries. Break from
3009 the loop as soon as EOB is reached; avoids infloops in redisplay
3010 when IT->position is set up wrongly due to some bug.
3011 Set IT->current to match the bidi iterator unconditionally.
3012 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3013 entry. Force push_it to save on the stack the current
3014 buffer/string position, to be restored by pop_it. Fix flags in
3015 the iterator structure wrt the object coming from a display
3016 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3017 properties. (Bug#9284)
3019 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3021 * fontset.c (fontset_get_font_group): Add proper type checks.
3024 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3026 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3027 and LC_VERSION_MIN_MACOSX.
3028 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3029 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3031 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3033 * xdisp.c (forward_to_next_line_start): Allow to use the
3034 no-display-properties-and-no-overlays under bidi display.
3035 Set disp_pos in the bidi iterator to avoid searches for display
3036 properties and overlays.
3038 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3040 * editfns.c (Fset_time_zone_rule): Document relationship with the
3043 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3044 the font entity extracted from the cache (Bug#8109).
3046 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3048 * composite.c (autocmp_chars): Don't reset point. That is done by
3049 restore_point_unwind (Bug#5984).
3051 2011-08-07 Juri Linkov <juri@jurta.org>
3053 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3054 to show the arg `TIME' instead of `TIMEVAL'.
3056 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3058 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3059 display property strides EOL and includes a newline, as in
3060 longlines-mode. (Bug#9254)
3061 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3062 word-wrap under bidirectional display. (Bug#9224)
3064 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3065 is non-zero, even if the data buffer is NULL. Fixes a crash in
3066 vertical-motion with longlines-mode. (Bug#9254)
3068 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3070 * bidi.c <bidi_cache_total_alloc>: Now static.
3071 (bidi_initialize): Initialize bidi_cache_total_alloc.
3073 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3076 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3077 amount allocated this far in `bidi_cache_total_alloc'.
3078 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3079 non-zero, only free the data buffer without restoring the cache
3080 contents. All callers changed.
3082 * dispextern.h (bidi_unshelve_cache): Update prototype.
3084 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3085 (move_it_in_display_line, move_it_to)
3086 (move_it_vertically_backward, move_it_by_lines): Replace the call
3087 to xfree to an equivalent call to bidi_unshelve_cache.
3088 (move_it_in_display_line_to): Fix logic of returning
3089 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3091 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3093 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3094 came from a string character with a `cursor' property. (Bug#9229)
3096 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3098 * Makefile.in (LIB_PTHREAD): New variable.
3099 (LIBES): Add LIB_PTHREAD (Bug#9216).
3101 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3102 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3104 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3106 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3108 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3110 * xterm.c (x_find_topmost_parent): New function.
3111 (x_set_frame_alpha): Find topmost parent window with
3112 x_find_topmost_parent and set the property there also (bug#9181).
3113 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3115 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3117 * callproc.c (Fcall_process): Avoid vfork clobbering
3118 the local vars buffer, coding_systems, current_dir.
3120 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3122 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3124 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3126 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3127 so that it is not optimized away.
3129 * xdisp.c (compute_display_string_pos): Remove unused local.
3131 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3133 Fix slow cursor motion and scrolling in large buffers with
3134 selective display, like Org Mode buffers. (Bug#9218)
3136 * dispextern.h (struct bidi_it): New member disp_prop_p.
3138 * xdisp.c: Remove one-slot cache of display string positions.
3139 (compute_display_string_pos): Accept an additional argument
3140 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3141 for a display string or property. If found, set DISP_PROP_P
3144 * bidi.c (bidi_fetch_char): Accept an additional argument
3145 DISP_PROP_P, and pass it to compute_display_string_pos.
3146 Only handle text covered by a display string if DISP_PROP_P is returned
3147 non-zero. All callers of bidi_fetch_char changed.
3149 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3151 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3153 2010-12-03 Don March <don@ohspite.net>
3155 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3156 last character M-[char] is translated to ESC [char] (bug#7541).
3158 2011-08-02 Kenichi Handa <handa@m17n.org>
3160 * lisp.h (uniprop_table): Extern it.
3162 * chartab.c (uniprop_table): Make it non-static.
3164 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3166 * xdisp.c (forward_to_next_line_start): Accept additional argument
3167 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3169 (reseat_at_next_visible_line_start): Use the bidi iterator state
3170 returned by forward_to_next_line_start to restore the state of
3171 it->bidi_it after backing up to previous newline. (Bug#9212)
3173 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3175 * regex.c (re_comp): Protoize.
3176 (re_exec): Fix return type.
3177 (regexec): Fix type of `ret'. (Bug#9203)
3179 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3181 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3182 This is needed if max-image-size is a floating-point number.
3184 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3186 * print.c (print_object): Print empty symbol as ##.
3188 * lread.c (read1): Read ## as empty symbol.
3190 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3192 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3193 setting frame foreground color (Bug#9175).
3194 (x_set_background_color): Likewise.
3196 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3197 contents (Bug#9176).
3198 (EmacsTooltip -init): Remove bezels and add shadows to
3201 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3202 or scroll bar (Bug#8470).
3204 * nsfont.m (nsfont_open): Remove assignment to voffset and
3205 unnecessary vars hshink, expand, hd, full_height, min_height.
3206 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3208 * nsterm.h (nsfont_info): Remove voffset field.
3210 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3212 Implement strike-through and overline on NextStep (Bug#8863).
3214 * nsfont.m (nsfont_open): Use underline position provided by font,
3215 instead of hard-coded value of 2.
3216 (nsfont_draw): Call ns_draw_text_decoration instead.
3218 * nsterm.h: Add declaration for ns_draw_text_decoration.
3220 * nsterm.m (ns_draw_text_decoration): New function for drawing
3221 underline, overline, and strike-through.
3222 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3223 ns_draw_text_decoration. Change treatment of cursor drawing to
3224 accommodate underlining, etc.
3226 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3228 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3231 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3233 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3234 Without this fix, if a signal arrives just after memory fills up,
3235 'malloc' might be invoked reentrantly.
3237 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3238 In other words, assume that every image size is allowed, on non-X
3239 hosts. This assumption is probably wrong, but it lets Emacs compile.
3241 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3243 * regex.c (re_iswctype): Convert return values to boolean.
3245 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3247 * xdisp.c (compute_display_string_pos): Don't use cached display
3248 string position if the buffer had its restriction changed.
3251 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3253 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3255 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3257 Integer signedness and overflow and related fixes. (Bug#9079)
3259 * bidi.c: Integer size and overflow fixes.
3260 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3261 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3263 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3264 (bidi_find_other_level_edge):
3265 Use ptrdiff_t instead of EMACS_INT where either will do.
3266 This works better on 32-bit hosts configured --with-wide-int.
3267 (bidi_cache_ensure_space): Check for size-calculation overflow.
3268 Use % rather than repeated addition, for better worst-case speed.
3269 Don't set bidi_cache_size until after xrealloc returns, because it
3271 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3272 (bidi_cache_ensure_space): Also check that the bidi cache size
3273 does not exceed that of the largest Lisp string or buffer. See Eli
3274 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3276 * alloc.c (__malloc_size_t): Remove.
3277 All uses replaced by size_t. See Andreas Schwab's note
3278 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3280 * image.c: Improve checking for integer overflow.
3281 (check_image_size): Assume that f is nonnull, since
3282 it is always nonnull in practice. This is one less thing to
3283 worry about when checking for integer overflow later.
3284 (x_check_image_size): New function, which checks for integer
3285 overflow issues inside X.
3286 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3287 This removes the need for a memory_full check.
3288 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3289 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3290 (xbm_read_bitmap_data): Change locals back to 'int', since
3291 their values must fit in 'int'.
3292 (xpm_load_image, png_load, tiff_load):
3293 Invoke x_create_x_image_and_pixmap earlier,
3294 to avoid much needless work if the image is too large.
3295 (tiff_load): Treat overly large images as if
3296 x_create_x_image_and_pixmap failed, not as malloc failures.
3297 (gs_load): Use x_check_image_size.
3299 * gtkutil.c: Omit integer casts.
3300 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3301 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3303 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3305 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3306 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3307 would wrongly return t on a 64-bit host.
3309 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3310 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3311 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3312 and therefore cause GCC to emit a bogus diagnostic in some cases.
3314 * image.c: Integer signedness and overflow and related fixes.
3315 This is not an exhaustive set of fixes, but it's time to
3316 record what I've got.
3317 (lookup_pixel_color, check_image_size): Remove redundant decls.
3318 (check_image_size): Don't assume that arbitrary EMACS_INT values
3319 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3320 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3321 (tiff_load, imagemagick_load_image):
3322 Check for overflow in size calculations.
3323 (x_create_x_image_and_pixmap): Remove unnecessary test for
3324 xmalloc returning NULL; that can't happen.
3325 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3326 (xpm_color_bucket): Use better integer hashing function.
3327 (xpm_cache_color): Don't possibly over-allocate memory.
3328 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3329 (gif_memory_source):
3330 Use ptrdiff_t, not int or size_t, to record sizes.
3331 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3332 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3333 either works, as we prefer signed integers.
3334 (tiff_read_from_memory, tiff_write_from_memory):
3335 Return tsize_t, not size_t, since that's what the TIFF API wants.
3336 (tiff_read_from_memory): Don't fail simply because the read would
3337 go past EOF; instead, return a short read.
3338 (tiff_load): Omit no-longer-needed casts.
3339 (Fimagemagick_types): Don't assume size fits into 'int'.
3341 Improve hashing quality when configured --with-wide-int.
3342 * fns.c (hash_string): New function, taken from sxhash_string.
3343 Do not discard information about ASCII character case; this
3344 discarding is no longer needed.
3345 (sxhash-string): Use it. Change sig to match it. Caller changed.
3346 * lisp.h: Declare it.
3347 * lread.c (hash_string): Remove, since we now use fns.c's version.
3348 The fns.c version returns a wider integer if --with-wide-int is
3349 specified, so this should help the quality of the hashing a bit.
3351 * emacs.c: Integer overflow minor fix.
3352 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3353 Define only if GNU_LINUX.
3354 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3356 * dispnew.c: Integer signedness and overflow fixes.
3357 Remove unnecessary forward decls, that were a maintenance hassle.
3358 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3360 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3361 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3362 (prepare_desired_row, line_draw_cost):
3363 Use int, not unsigned, where either works.
3364 (save_current_matrix, restore_current_matrix):
3365 Use ptrdiff_t, not size_t, where either works.
3366 (init_display): Check for overflow more accurately, and without
3367 relying on undefined behavior.
3369 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3370 Remove, replacing with the new symbols in lisp.h. All uses changed.
3371 * fileio.c (make_temp_name):
3372 * filelock.c (lock_file_1, lock_file):
3373 * xdisp.c (message_dolog):
3374 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3375 Use pMd etc. instead.
3376 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3377 replacing the pWIDE etc. symbols removed from editfns.c.
3379 * keyboard.h (num_input_events): Now uintmax_t.
3380 This is (very slightly) less likely to mess up due to wraparound.
3383 * buffer.c: Integer signedness fixes.
3384 (alloc_buffer_text, enlarge_buffer_text):
3385 Use ptrdiff_t rather than size_t when either will do, as we prefer
3388 * alloc.c: Integer signedness and overflow fixes.
3389 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3390 (__malloc_size_t): Default to size_t, not to int.
3391 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3392 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3393 Prefer ptrdiff_t to size_t when either would do, as we prefer
3395 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3396 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3397 Now const. Initialize with values that are in range even if char
3399 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3400 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3401 These functions do the right thing with sizes > 2**32.
3402 (check_depth): Now ptrdiff_t, not int.
3403 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3404 Adjust to new way of storing sizes. Check for size overflow bugs
3406 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3407 slightly wrong anyway, as it missed one instance of
3408 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3409 (refill_memory_reserve): Omit needless cast to size_t.
3410 (mark_object_loop_halt): Mark as externally visible.
3412 * xselect.c: Integer signedness and overflow fixes.
3413 (Fx_register_dnd_atom, x_handle_dnd_message):
3414 Use ptrdiff_t, not size_t, since we prefer signed.
3415 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3416 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3417 x_dnd_atoms_size and x_dnd_atoms_length.
3419 * doprnt.c: Prefer signed to unsigned when either works.
3421 * doprnt.c (doprnt):
3423 * xdisp.c (vmessage):
3424 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3425 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3426 prefer signed arithmetic to avoid comparison confusion.
3427 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3428 but is a bit tricky.
3430 Assume freestanding C89 headers, string.h, stdlib.h.
3431 * data.c, doprnt.c, floatfns.c, print.c:
3432 Include float.h unconditionally.
3433 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3434 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3435 * regex.c: Likewise for stddef.h, string.h.
3436 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3437 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3438 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3439 (STDC_HEADERS): Remove obsolete defines.
3440 * sysdep.c: Include limits.h unconditionally.
3442 Assume support for memcmp, memcpy, memmove, memset.
3443 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3444 * regex.c (memcmp, memcpy):
3445 Remove; we assume C89 now.
3447 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3448 (__malloc_safe_bcopy): Remove; no longer needed.
3450 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3451 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3452 well either way, and we prefer signed to unsigned.
3454 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3456 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3457 closes the connection while we're reading (bug#9182).
3459 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3461 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3462 are specified (Bug#9168).
3464 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3466 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3467 Found by GCC static checking and --with-wide-int on a 32-bit host.
3469 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3471 * xdisp.c (compute_display_string_pos): Fix logic of caching
3472 previous display string position. Initialize cached_prev_pos to
3473 -1. Fixes slow-down at the beginning of a buffer.
3475 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3477 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3478 for attrs[LFACE_FONTSET_INDEX].
3480 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3482 * xml.c (parse_region): Remove unused local
3483 that was recently introduced.
3485 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3487 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3488 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3490 * xdisp.c (move_it_in_display_line_to): Record the best matching
3491 position for TO_CHARPOS while scanning the line, and restore it on
3492 exit if none of the characters scanned was an exact match.
3493 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3494 when exact match is impossible due to invisible text, and the
3495 lines are truncated.
3497 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3499 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3502 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3504 Fix a significant slow-down of cursor motion with C-n, C-p,
3505 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3506 auto-repeat under bidi redisplay in fontified buffers.
3507 * xdisp.c (compute_stop_pos_backwards): New function.
3508 (next_element_from_buffer): Call compute_stop_pos_backwards to
3509 find a suitable prev_stop when we find ourselves before
3511 (reseat): Don't look for prev_stop, as that could mean a very long
3513 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3514 <cached_disp_overlay_modiff>: Cache for last found display string
3516 (compute_display_string_pos): Return the cached position if asked
3517 about the same buffer in the same area of character positions, and
3518 the buffer wasn't changed since the time the display string
3519 position was cached.
3521 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3523 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3524 is an integer, which is important for empty lines. (Bug#9149)
3526 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3528 * frame.c (Fmodify_frame_parameters): In tty case, update the
3529 default face if necessary (Bug#4238).
3531 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3533 * editfns.c (Fstring_to_char): No need to explain what a character
3534 is in the docstring (Bug#6576).
3536 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3538 * xml.c (parse_region): Make sure we always return a tree.
3540 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3542 * xml.c (parse_region): If a document contains only comments,
3545 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3547 * xml.c (make_dom): Return comments, too.
3549 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3552 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3553 and the surrounding thread.
3554 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3555 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3556 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3558 * s/openbsd.h (BROKEN_SIGIO): Define.
3559 * unexelf.c (unexec) [__OpenBSD__]:
3560 Don't update the .mdebug section of the Alpha COFF symbol table.
3562 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3564 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3567 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3569 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3570 This fixes some race conditions on the permissions of any newly
3573 * alloc.c (valid_pointer_p): Use pipe, not open.
3574 This fixes some permissions issues when debugging.
3576 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3577 If fchown fails to set both uid and gid, try to set just gid,
3578 as that is sometimes allowed. Adjust the file's mode to eliminate
3579 setuid or setgid bits that are inappropriate if fchown fails.
3581 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3583 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3584 to compare Lisp_Objects.
3585 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3586 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3587 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3589 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3591 * lread.c (read_integer): Unread even EOF character.
3592 (read1): Likewise. Properly record start position of symbol.
3594 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3595 symbol character follows.
3597 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3599 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3600 This works around a problem with the previous change to Fcopy_file.
3601 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3602 and without this change, GCC might complain about discarding
3603 fchown's return value.
3605 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3607 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3609 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3611 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3613 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3615 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3616 it's used from the C level.
3618 * process.c: Use the same condition for POLL_FOR_INPUT in both
3619 keyboard.c and process.c (bug#1858).
3621 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3623 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3624 (Fgnutls_boot): Use it.
3626 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3628 * doc.c (Fsubstitute_command_keys): Revert last change.
3630 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3632 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3633 quotes the next character, and doesn't affect other longer
3634 sequences (bug#8935).
3636 * lread.c (syms_of_lread): Clarify that is isn't only
3637 `eval-buffer' and `eval-defun' that's affected by
3638 `lexical-binding' (bug#8460).
3640 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3642 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3643 bidi redisplay when a line includes both an image and is truncated.
3645 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3647 Fix minor problems found by static checking.
3648 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3649 (elsz): Now a signed constant, not a size_t var. We prefer signed
3650 types to unsigned, to avoid integer comparison confusion. Without
3651 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3652 "cannot optimize loop, the loop counter may overflow", a symptom
3654 * indent.c (Fvertical_motion): Mark locals as initialized.
3655 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3657 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3659 * search.c (Fre_search_backward): Mention `case-fold-search' in
3660 all the re_search_* functions (bug#8138).
3662 * keyboard.c (Fopen_dribble_file): Document when the file is
3665 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3667 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3670 Support bidi reordering of display and overlay strings.
3671 * xdisp.c (compute_display_string_pos)
3672 (compute_display_string_end): Accept additional argument STRING.
3673 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3674 (reseat_to_string): Initialize bidi_it->string.s and
3675 bidi_it->string.schars.
3676 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3677 NULL (avoids a crash in bidi_paragraph_init).
3678 Initialize itb.string.lstring.
3679 (init_iterator): Call bidi_init_it only of a valid
3680 buffer position was specified. Initialize paragraph_embedding to
3682 (reseat_to_string): Initialize the bidi iterator.
3683 (display_string): If we need to ignore text properties of
3684 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3685 original value of -1 will not work with bidi.)
3686 (compute_display_string_pos): First arg is now struct
3687 `text_pos *'; all callers changed. Support display properties on
3689 (compute_display_string_end): Support display properties on Lisp
3691 (init_iterator, reseat_1, reseat_to_string): Initialize the
3692 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3693 when iterating on a string not from display properties).
3694 (compute_display_string_pos, compute_display_string_end):
3695 Fix calculation of the object to scan. Fixes an error when using
3697 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3698 base_level_stop; instead, set base_level_stop to BEGV.
3699 Fixes crashes in vertical-motion.
3700 (next_element_from_buffer): Improve commentary for when
3701 the iterator is before prev_stop.
3702 (init_iterator): Initialize bidi_p from the default value of
3703 bidi-display-reordering, not from buffer-local value. Use the
3704 buffer-local value only if initializing for buffer iteration.
3705 (handle_invisible_prop): Support invisible properties on strings
3706 that are being bidi-reordered.
3707 (set_iterator_to_next): Support bidi reordering of C strings and
3709 (next_element_from_string): Support bidi reordering of Lisp
3711 (handle_stop_backwards): Support Lisp strings as well.
3712 (display_string): Support display of R2L glyph rows.
3713 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3714 (init_iterator): Don't initialize it->bidi_p for strings
3716 (reseat_to_string): Initialize it->bidi_p for strings here.
3717 (next_element_from_string, next_element_from_c_string)
3718 (next_element_from_buffer): Add xassert's for correspondence
3719 between IT's object being iterated and it->bidi_it.string
3721 (face_before_or_after_it_pos): Support bidi iteration.
3722 (next_element_from_c_string): Handle the case of the first string
3723 character that is not the first one in the visual order.
3724 (get_visually_first_element): New function, refactored from common
3725 parts of next_element_from_buffer, next_element_from_string, and
3726 next_element_from_c_string.
3727 (tool_bar_lines_needed, redisplay_tool_bar)
3728 (display_menu_bar): Force left-to-right direction. Add a FIXME
3729 comment for making that be controlled by a user option.
3730 (push_it, pop_it): Save and restore the state of the
3731 bidi iterator. Save and restore the bidi_p flag.
3732 (pop_it): Iterate out of display property for string iteration as
3734 (iterate_out_of_display_property): Support iteration over strings.
3735 (handle_single_display_spec): Set up it->bidi_it for iteration
3736 over a display string, and call bidi_init_it.
3737 (handle_single_display_spec, next_overlay_string)
3738 (get_overlay_strings_1, push_display_prop): Set up the bidi
3739 iterator for displaying display or overlay strings.
3740 (forward_to_next_line_start): Don't use the shortcut if
3742 (back_to_previous_visible_line_start): If handle_display_prop
3743 pushed the iterator stack, restore the internal state of the bidi
3744 iterator by calling bidi_pop_it same number of times.
3745 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3746 and we are bidi-iterating, don't decrement the iterator position;
3747 instead, set the first_elt flag in the bidi iterator, to produce
3749 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3750 (push_display_prop): xassert that we are iterating a buffer.
3751 (push_it, pop_it): Save and restore paragraph_embedding member.
3752 (handle_single_display_spec, next_overlay_string)
3753 (get_overlay_strings_1, reseat_1, reseat_to_string)
3754 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3755 correctly. Don't assume unibyte strings are not bidi-reordered.
3756 (compute_display_string_pos)
3757 (compute_display_string_end): Fix handling the case of C string.
3758 (push_it, pop_it): Save and restore from_disp_prop_p.
3759 (handle_single_display_spec, push_display_prop): Set the
3760 from_disp_prop_p flag.
3761 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3762 (pop_it): Call iterate_out_of_display_property only if we are
3763 popping after iteration over a string that came from a display
3764 property. Fix a typo in popping stretch info. Add an assertion
3765 for verifying that the iterator position is in sync with the bidi
3767 (handle_single_display_spec, get_overlay_strings_1)
3768 (push_display_prop): Fix initialization of paragraph direction for
3769 string when that of the parent object is not yet determined.
3770 (reseat_1): Call bidi_init_it to resync the bidi
3771 iterator with IT's position. (Bug#7616)
3772 (find_row_edges): If ROW->start.pos gives position
3773 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3774 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3775 Reset the from_disp_prop_p flag.
3776 (SAVE_IT, RESTORE_IT): New macros.
3777 (pos_visible_p, face_before_or_after_it_pos)
3778 (back_to_previous_visible_line_start)
3779 (move_it_in_display_line_to, move_it_in_display_line)
3780 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3781 (try_scrolling, redisplay_window, display_line): Use them when
3782 saving a temporary copy of the iterator and restoring it back.
3783 (back_to_previous_visible_line_start, reseat_1)
3784 (init_iterator): Empty the bidi cache "stack".
3785 (move_it_in_display_line_to): If iterator ended up at
3786 EOL, but we never saw any buffer positions smaller than
3787 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3788 motion in bidi-reordered lines.
3789 (move_it_in_display_line_to): Record prev_method and prev_pos
3790 immediately before the call to set_iterator_to_next. Fixes cursor
3791 motion in bidi-reordered lines with stretch glyphs and strings
3792 displayed in margins. (Bug#8133) (Bug#8867)
3793 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3795 (pos_visible_p): Support positions in bidi-reordered lines.
3796 Save and restore bidi cache.
3798 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3799 (bidi_paragraph_info): Delete unused struct.
3800 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3801 (bidi_cache_start): New variable.
3802 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3804 (bidi_cache_fetch_state, bidi_cache_search)
3805 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3806 (bidi_cache_find, bidi_peek_at_next_level)
3807 (bidi_level_of_next_char, bidi_find_other_level_edge)
3808 (bidi_move_to_visually_next): Compare cache index with
3809 bidi_cache_start rather than with zero.
3810 (bidi_fetch_char): Accept new argument STRING; all callers
3811 changed. Support iteration over a string. Support strings with
3812 display properties. Support unibyte strings. Fix the type of
3813 `len' according to what STRING_CHAR_AND_LENGTH expects.
3814 (bidi_paragraph_init, bidi_resolve_explicit_1)
3815 (bidi_resolve_explicit, bidi_resolve_weak)
3816 (bidi_level_of_next_char, bidi_move_to_visually_next):
3817 Support iteration over a string.
3818 (bidi_set_sor_type, bidi_resolve_explicit_1)
3819 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3820 can now be zero (for strings); special values 0 and -1 were
3821 changed to -1 and -2, respectively.
3822 (bidi_char_at_pos): New function.
3823 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3824 Call it instead of FETCH_MULTIBYTE_CHAR.
3825 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3826 initialized to valid values.
3827 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3829 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3830 the test for valid cached positions. Fix the logic for looking up
3831 the sentinel state in the cache. GCPRO the Lisp string we are
3833 (bidi_push_it, bidi_pop_it): New functions.
3834 (bidi_initialize): Initialize the bidi cache start stack pointer.
3835 (bidi_cache_ensure_space): New function, refactored from part of
3836 bidi_cache_iterator_state. Don't assume the required size is just
3837 one BIDI_CACHE_CHUNK away.
3838 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3839 (bidi_count_bytes, bidi_char_at_pos): New functions.
3840 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3841 always valid if bidi_cache_idx is valid.
3842 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3843 is valid if it's going to be used.
3844 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3845 (bidi_cache_fetch_state, bidi_cache_search)
3846 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3847 (bidi_cache_iterator_state, bidi_cache_find)
3848 (bidi_find_other_level_edge, bidi_cache_start_stack):
3849 All variables related to cache indices are now EMACS_INT.
3851 * dispextern.h (struct bidi_string_data): New structure.
3852 (struct bidi_it): New member `string'. Make flag members be 1-bit
3853 fields, and put them last in the struct.
3854 (compute_display_string_pos, compute_display_string_end):
3856 (bidi_push_it, bidi_pop_it): Add prototypes.
3857 (struct iterator_stack_entry): New members bidi_p,
3858 paragraph_embedding, and from_disp_prop_p.
3859 (struct it): Member bidi_p is now a bit field 1 bit wide.
3860 (bidi_shelve_cache, bidi_unshelve_cache):
3863 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3864 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3865 and vector-like objects.
3867 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3868 cache around display iteration.
3870 * window.c (Fwindow_end, window_scroll_pixel_based)
3871 (displayed_window_lines, Frecenter): Save and restore the bidi
3872 cache around display iteration.
3874 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3876 * editfns.c (Fdelete_region): Clarify the use of the named
3877 parameters (bug#6788).
3879 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3881 * indent.c (Fvertical_motion): Set and restore w->pointm when
3882 saving and restoring the window's buffer (Bug#9006).
3884 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3886 * editfns.c (Fstring_to_char): Clarify just what is returned
3887 (bug#6576). Text by Eli Zaretskii.
3889 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3891 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3893 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3895 * buffer.c (mmap_find): Fix a typo.
3897 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3899 Fix execution of x selection hooks.
3900 * xselect.c (Qx_lost_selection_functions)
3901 (Qx_sent_selection_functions): New vars.
3902 (syms_of_xselect): DEFSYM them.
3903 (x_handle_selection_request): Pass Qx_sent_selection_functions
3904 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3905 (x_handle_selection_clear,x_clear_frame_selections):
3906 Pass Qx_lost_selection_functions rather than
3907 Vx_lost_selection_functions to Frun_hook_with_args.
3909 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3911 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3912 The old code sometimes used this field without initializing it.
3914 * alloc.c (gc_sweep): Don't read past end of array.
3915 In theory, the old code could also have corrupted Emacs internals,
3916 though it'd be very unlikely.
3918 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3920 * character.c (Fcharacterp): Don't advertise optional ignored
3921 argument. (Bug#4026)
3923 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3925 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3928 * window.c (Fset_window_start): Doc fix (bug#4199).
3929 (Fset_window_hscroll): Ditto.
3931 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3933 Fix minor new problems caught by GCC 4.6.1.
3934 * term.c (init_tty): Remove unused local.
3935 * xsettings.c (store_monospaced_changed): Define this function only
3936 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3939 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3941 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3943 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3945 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3946 are the mini-buffer and the echo area (bug#3320).
3948 * term.c (init_tty): Remove support for supdup, c10 and perq
3949 terminals, which are no longer supported (bug#1482).
3951 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3953 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3955 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3957 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3958 for non-popups (Bug#3642).
3960 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3962 * alloc.c (reset_malloc_hooks): Protoize.
3963 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3964 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3965 * cm.c (losecursor): Likewise.
3966 * data.c (fmod): Likewise.
3967 * dispnew.c (swap_glyphs_in_rows): Likewise.
3968 * emacs.c (memory_warning_signal): Likewise.
3969 * floatfns.c (float_error): Likewise.
3970 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3971 (otf_open, font_otf_capability, generate_otf_features)
3972 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3974 * image.c (pbm_read_file): Likewise.
3975 * indent.c (string_display_width): Likewise.
3976 * intervals.c (check_for_interval, search_for_interval)
3977 (inc_interval_count, count_intervals, root_interval)
3978 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3979 * lread.c (defalias): Likewise.
3980 * ralloc.c (r_alloc_check): Likewise.
3981 * regex.c (set_image_of_range_1, set_image_of_range)
3982 (regex_grow_registers): Likewise.
3983 * sysdep.c (strerror): Likewise.
3984 * termcap.c (valid_filename_p, tprint, main): Likewise.
3985 * tparam.c (main): Likewise.
3986 * unexhp9k800.c (run_time_remap, save_data_space)
3987 (update_file_ptrs, read_header, write_header, calculate_checksum)
3988 (copy_file, copy_rest, display_header): Likewise.
3989 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3991 * xdisp.c (check_it): Likewise.
3992 * xfaces.c (register_color, unregister_color, unregister_colors):
3994 * xfns.c (print_fontset_result): Likewise.
3995 * xrdb.c (member, fatal, main): Likewise.
3997 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3999 Fix minor problems found by static checking (Bug#9031).
4000 * chartab.c (char_table_set_range, map_sub_char_table):
4001 Remove unused locals.
4002 (uniprop_table): Now static.
4003 * composite.c (_work_char): Remove unused static var.
4005 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4007 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4009 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4011 * gtkutil.c (qttip_cb): Remove code without function.
4013 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4015 * w32.c (pthread_sigmask): New stub.
4017 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4019 Use pthread_sigmask, not sigprocmask (Bug#9010).
4020 sigprocmask is portable only for single-threaded applications, and
4021 Emacs can be multi-threaded when it uses GTK.
4022 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4024 * callproc.c (Fcall_process):
4025 * process.c (create_process):
4026 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4027 Use pthread_sigmask, not sigprocmask.
4029 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4031 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4032 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4035 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4037 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4038 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4039 (xg_hide_tooltip): Fix comment.
4041 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4042 in registerServicesMenuSendTypes.
4043 (validRequestorForSendType): Don't check ns_return_types.
4045 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4048 2011-07-08 Jason Rumney <jasonr@gnu.org>
4050 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4051 SH_SHOW for hidden windows (Bug#5482).
4053 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4054 frame struct members of non-existent frames (Bug#6284).
4056 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4058 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4059 variable firstTime not needed on OSX >= 10.6.
4060 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4061 >= 10.5. Use setKnobProportion, setDoubleValue.
4063 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4064 (MAC_OS_X_VERSION_10_5): Define if not defined.
4065 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4066 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4067 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4069 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4070 cString and lossyCString on OSX >= 10.4
4072 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4073 sizeToFit on OSX >= 10.2.
4075 * nsimage.m (allocInitFromFile): Don't use deprecated method
4076 bestRepresentationForDevice on OSX >= 10.6.
4078 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4081 * emacs.c: Declare unexec_init_emacs_zone.
4083 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4085 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4087 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4088 on svcsMenu (Bug#8842).
4090 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4092 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4094 * nsterm.m (QUTF8_STRING): Declare.
4095 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4096 (validRequestorForSendType): Return type is (id).
4097 Change indexOfObjectIdenticalTo to indexOfObject.
4098 Check if we have local selection before returning self (Bug#8842).
4099 (writeSelectionToPasteboard): Put local selection into paste board
4100 if we have a local selection (Bug#8842).
4101 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4103 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4104 (ns_get_local_selection): Declare.
4106 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4108 * keymap.c (describe_map_tree): Don't insert a double newline at
4109 the end of the buffer (bug#1169) and return whether we inserted
4112 * callint.c (Fcall_interactively): Change "reading args" to
4113 "providing args" to try to clarify what it does (bug#1010).
4115 2011-07-07 Kenichi Handa <handa@m17n.org>
4117 * composite.c (composition_compute_stop_pos): Ignore a static
4118 composition starting before CHARPOS (Bug#8915).
4120 * xdisp.c (handle_composition_prop): Likewise.
4122 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4124 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4127 2011-07-07 Kenichi Handa <handa@m17n.org>
4129 * character.h (unicode_category_t): New enum type.
4131 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4132 (Qchar_code_property_table): New variable.
4133 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4134 (UNIPROP_COMPRESSED_FORM_P): New macros.
4135 (char_table_ascii): Uncompress the compressed values.
4136 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4137 Uncompress the compressed values.
4138 (sub_char_table_ref_and_range): Likewise.
4139 (char_table_ref_and_range): Uncompress the compressed values.
4140 (sub_char_table_set): New arg is_uniprop. Callers changed.
4141 Uncompress the compressed values.
4142 (sub_char_table_set_range): Args changed. Callers changed.
4143 (char_table_set_range): Adjuted for the above change.
4144 (map_sub_char_table): Delete args default_val and parent. Add arg
4145 top. Give decoded values to a Lisp function.
4146 (map_char_table): Adjust for the above change. Give decoded
4147 values to a Lisp function. Gcpro more variables.
4148 (uniprop_table_uncompress)
4149 (uniprop_decode_value_run_length): New functions.
4150 (uniprop_decoder, uniprop_decoder_count): New variables.
4151 (uniprop_get_decoder, uniprop_encode_value_character)
4152 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4154 (uniprop_encoder, uniprop_encoder_count): New variables.
4155 (uniprop_get_encoder, uniprop_table)
4156 (Funicode_property_table_internal, Fget_unicode_property_internal)
4157 (Fput_unicode_property_internal): New functions.
4158 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4159 Sunicode_property_table_internal, Sget_unicode_property_internal,
4160 and Sput_unicode_property_internal. Defvar_lisp
4161 char-code-property-alist.
4163 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4164 Vunicode_category_table.
4166 * font.c (font_range): Adjust for the change of
4167 Vunicode_category_table.
4169 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4171 * m/iris4d.h: Remove file, move contents ...
4172 * s/irix6-5.h: ... here.
4174 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4176 Remove unportable assumption about struct layout (Bug#8884).
4177 * alloc.c (mark_buffer):
4178 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4179 (clone_per_buffer_values): Don't assume that
4180 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4181 This isn't true in general, and it's particularly not true
4182 if Emacs is configured with --with-wide-int.
4183 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4184 New macros, used in the buffer.c change.
4186 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4188 * xsettings.c: Use both GConf and GSettings if both are available.
4189 (store_config_changed_event): Add comment.
4190 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4191 (store_tool_bar_style_changed): New functions.
4192 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4193 (struct xsettings): Move font inside HAVE_XFT.
4194 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4195 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4196 Move inside HAVE_XFT.
4197 (something_changed_gsettingsCB): Rename from something_changedCB.
4198 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4200 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4201 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4202 (something_changed_gconfCB): Rename from something_changedCB.
4203 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4204 (parse_settings): Move check for font inside HAVE_XFT.
4205 (read_settings, apply_xft_settings): Add comment.
4206 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4207 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4208 call store_font_name_changed.
4209 (xft_settings_event): Add comment.
4210 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4211 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4212 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4213 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4214 (xsettings_initialize): Call init_gsettings last.
4215 (xsettings_get_system_font, xsettings_get_system_normal_font):
4218 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4220 Random fixes. E.g., (random) never returned negative values.
4221 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4222 subseconds part to the entropy, as that's a bit more random.
4223 Prefer signed to unsigned, since the signedness doesn't matter and
4224 in general we prefer signed. When given a limit, use a
4225 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4226 latter isn't right if USE_2_TAGS_FOR_INTS.
4227 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4228 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4230 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4232 * textprop.c (text_property_stickiness):
4233 Obey Vtext_property_default_nonsticky.
4234 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4235 * w32fns.c (syms_of_w32fns):
4236 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4238 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4240 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4241 This is more efficient than Ffile_directory_p and avoids a minor race.
4243 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4245 * buffer.c (Foverlay_put): Say what the return value is
4248 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4249 is a directory before asking whether to use the file name
4251 (barf_or_query_if_file_exists): Make the "File is a directory"
4252 error be more correct.
4254 * fns.c (Frequire): Remove the mention of the .gz files, since
4255 that's installation-specific, but keep the mention of
4256 `get-load-suffixes'.
4258 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4260 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4261 Report string overflow if the output is too long.
4263 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4265 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4266 (syms_of_gnutls): Remove duplicate DEFSYM for
4267 Qgnutls_bootprop_verify_hostname_error, an error for
4268 Qgnutls_bootprop_verify_error (which is no longer used).
4270 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4271 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4272 Also (re)move comments that are misplaced or no longer relevant.
4274 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4278 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4280 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4281 and background color parameters if they have been changed.
4283 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4285 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4287 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4289 * xsettings.c (SYSTEM_FONT): Define only when used.
4290 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4292 * keymap.c (access_keymap_1): Now static.
4294 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4296 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4297 leave any prefix arg for the up event (Bug#1586).
4299 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4301 * lread.c (syms_of_lread): Mention single symbols defined by
4302 `defvar' or `defconst' (bug#7154).
4304 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4305 (Frequire): Mention get-load-suffixes.
4307 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4309 * window.h (window): Remove clone_number slot.
4310 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4312 (make_parent_window, make_window, saved_window)
4313 (Fset_window_configuration, save_window_save): Don't deal with
4315 * buffer.c (Qclone_number): Remove declaration.
4316 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4318 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4320 Add multiple inheritance to keymaps.
4321 * keymap.c (Fmake_composed_keymap): New function.
4322 (Fset_keymap_parent): Simplify.
4323 (fix_submap_inheritance): Remove.
4324 (access_keymap_1): New function extracted from access_keymap to handle
4325 embedded parents and handle lists of maps.
4326 (access_keymap): Use it.
4327 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4328 (Fcopy_keymap): Handle embedded parents.
4329 (Fcommand_remapping, define_as_prefix): Simplify.
4330 (Fkey_binding): Simplify.
4331 (syms_of_keymap): Move minibuffer-local-completion-map,
4332 minibuffer-local-filename-completion-map,
4333 minibuffer-local-must-match-map, and
4334 minibuffer-local-filename-must-match-map to Elisp.
4335 (syms_of_keymap): Defsubr make-composed-keymap.
4336 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4337 (parse_menu_item): Trivial simplification.
4339 2011-07-01 Glenn Morris <rgm@gnu.org>
4341 * Makefile.in (SETTINGS_LIBS): Fix typo.
4343 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4345 * coding.c (Fencode_coding_string): Record the last coding system
4346 used, as the function doc string says (bug#8738).
4348 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4350 * xsettings.c (store_monospaced_changed): Take new font as arg and
4351 check for change against current_mono_font.
4352 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4353 (emacs_settings_constructor, emacs_settings_get_property)
4354 (emacs_settings_set_property, emacs_settings_class_init)
4355 (emacs_settings_init, gsettings_obj): Remove.
4356 (something_changedCB): New function for HAVE_GSETTINGS.
4357 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4358 with value as argument.
4359 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4360 g_settings_new (Bug#8967). Do not create gsettings_obj.
4361 Remove calls to g_settings_bind. Connect something_changedCB to
4364 * xgselect.c: Add defined (HAVE_GSETTINGS).
4365 (xgselect_initialize): Ditto.
4367 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4368 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4371 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4373 * eval.c (struct backtrace): Simplify and port the data structure.
4374 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4375 signed bit field, as this assumption is not portable and it makes
4376 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4377 "char debug_on_exit : 1" as this is not portable either; instead,
4378 use the portable "unsigned int debug_on_exit : 1". Remove unused
4379 member evalargs. Remove obsolete comments about cc bombing out.
4381 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4383 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4384 Let HAVE_GSETTINGS override HAVE_GCONF.
4385 (store_monospaced_changed): New function.
4386 (EMACS_SETTINGS): A new type derived from GObject to handle
4387 GSettings notifications.
4388 (emacs_settings_constructor, emacs_settings_get_property)
4389 (emacs_settings_set_property, emacs_settings_class_init):
4391 (gsettings_client, gsettings_obj): New variables.
4392 (GSETTINGS_SCHEMA): New define.
4393 (something_changedCB): Call store_monospaced_changed.
4394 (init_gsettings): New function.
4395 (xsettings_initialize): Call init_gsettings.
4396 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4399 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4402 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4404 * window.c (resize_root_window, grow_mini_window)
4405 (shrink_mini_window): Rename Qresize_root_window to
4406 Qwindow_resize_root_window and Qresize_root_window_vertically to
4407 Qwindow_resize_root_window_vertically.
4409 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4411 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4413 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4415 * makefile.w32-in: Redesign dependencies so they reflect more
4416 clearly which files are directly included by each source file,
4417 and not through other includes.
4419 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4421 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4422 (sort_overlays, overlay_strings): When an overlay's clone number
4423 matches the window's clone number process the overlay even if
4424 the overlay's window property doesn't match the current window.
4426 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4427 (Fwindow_hchild): Rename to Fwindow_left_child.
4428 (Fwindow_next): Rename to Fwindow_next_sibling.
4429 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4430 (resize_window_check): Rename to window_resize_check.
4431 (resize_window_apply): Rename to window_resize_apply.
4432 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4433 (Fdelete_other_windows_internal, resize_frame_windows)
4434 (Fsplit_window_internal, Fdelete_window_internal)
4435 (grow_mini_window, shrink_mini_window)
4436 (Fresize_mini_window_internal): Fix callers accordingly.
4438 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4440 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4441 (emacs_fixed_set_min_size): Remove.
4442 (emacs_fixed_new): Take frame as argument.
4444 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4445 (_EmacsFixedPrivate): Remove minwidth/height.
4446 Add struct frame *f.
4447 (emacs_fixed_init): Initialize priv->f.
4448 (get_parent_class, emacs_fixed_set_min_size): Remove.
4449 (emacs_fixed_new): Set priv->f to argument.
4450 (emacs_fixed_get_preferred_width)
4451 (emacs_fixed_get_preferred_height): Use min_width/height from
4452 frames size_hint to set minimum and natural (Bug#8919).
4453 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4454 and use min_width/height from frames size_hint to set
4455 min_width/height (Bug#8919).
4457 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4458 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4461 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4463 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4464 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4467 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4469 * process.c (wait_reading_process_output): Bypass select if
4470 waiting for a cell while ignoring keyboard input, and input is
4471 pending. Suggested by Jan Djärv (Bug#8869).
4473 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4475 Use gnulib's dup2 module instead of rolling our own.
4476 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4478 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4480 * dispnew.c (scrolling_window): Before scrolling, turn off a
4481 mouse-highlight in the window being scrolled.
4483 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4485 Move DEFSYM to lisp.h and use everywhere.
4487 * character.h (DEFSYM): Move declaration...
4488 * lisp.h (DEFSYM): ...here.
4494 * w32select.c: Don't include character.h.
4496 * alloc.c (syms_of_alloc):
4497 * buffer.c (syms_of_buffer):
4498 * bytecode.c (syms_of_bytecode):
4499 * callint.c (syms_of_callint):
4500 * casefiddle.c (syms_of_casefiddle):
4501 * casetab.c (init_casetab_once):
4502 * category.c (init_category_once, syms_of_category):
4503 * ccl.c (syms_of_ccl):
4504 * cmds.c (syms_of_cmds):
4505 * composite.c (syms_of_composite):
4506 * dbusbind.c (syms_of_dbusbind):
4507 * dired.c (syms_of_dired):
4508 * dispnew.c (syms_of_display):
4509 * doc.c (syms_of_doc):
4510 * editfns.c (syms_of_editfns):
4511 * emacs.c (syms_of_emacs):
4512 * eval.c (syms_of_eval):
4513 * fileio.c (syms_of_fileio):
4514 * fns.c (syms_of_fns):
4515 * frame.c (syms_of_frame):
4516 * fringe.c (syms_of_fringe):
4517 * insdel.c (syms_of_insdel):
4518 * keymap.c (syms_of_keymap):
4519 * lread.c (init_obarray, syms_of_lread):
4520 * macros.c (syms_of_macros):
4521 * msdos.c (syms_of_msdos):
4522 * print.c (syms_of_print):
4523 * process.c (syms_of_process):
4524 * search.c (syms_of_search):
4525 * sound.c (syms_of_sound):
4526 * syntax.c (init_syntax_once, syms_of_syntax):
4527 * terminal.c (syms_of_terminal):
4528 * textprop.c (syms_of_textprop):
4529 * undo.c (syms_of_undo):
4530 * w32.c (globals_of_w32):
4531 * window.c (syms_of_window):
4532 * xdisp.c (syms_of_xdisp):
4533 * xfaces.c (syms_of_xfaces):
4534 * xfns.c (syms_of_xfns):
4535 * xmenu.c (syms_of_xmenu):
4536 * xsettings.c (syms_of_xsettings):
4537 * xterm.c (syms_of_xterm): Use DEFSYM.
4539 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4541 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4543 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4545 Integer and buffer overflow fixes (Bug#8873).
4547 * print.c (printchar, strout): Check for string overflow.
4548 (PRINTPREPARE, printchar, strout):
4549 Don't set size unless allocation succeeds.
4551 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4552 for sizes. Check for string overflow more accurately.
4553 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4555 * macros.c: Integer and buffer overflow fixes.
4556 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4557 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4558 Use ptrdiff_t, not int, for sizes.
4559 Don't increment bufsize until after realloc succeeds.
4560 Check for size-calculation overflow.
4561 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4563 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4565 * lread.c: Integer overflow fixes.
4566 (read_integer): Radix is now EMACS_INT, not int,
4567 to improve quality of diagnostics for out-of-range radices.
4568 Calculate buffer size correctly for out-of-range radices.
4569 (read1): Check for integer overflow in radices, and in
4570 read-circle numbers.
4571 (read_escape): Avoid int overflow.
4572 (Fload, openp, read_buffer_size, read1)
4573 (substitute_object_recurse, read_vector, read_list, map_obarray):
4574 Use ptrdiff_t, not int, for sizes.
4575 (read1): Use EMACS_INT, not int, for sizes.
4576 Check for size overflow.
4578 * image.c (cache_image): Check for size arithmetic overflow.
4580 * lread.c: Integer overflow issues.
4581 (saved_doc_string_size, saved_doc_string_length)
4582 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4583 Now ptrdiff_t, not int.
4584 (read1): Don't assume doc string length fits in int. Check for
4585 out-of-range doc string lengths.
4586 (read_list): Don't assume file position fits in int.
4587 (read_escape): Check for hex character overflow.
4589 2011-06-22 Leo Liu <sdl.web@gmail.com>
4591 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4592 Move to minibuffer.el.
4594 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4596 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4597 The following patches are for when GLYPH_DEBUG && !XASSERT.
4598 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4599 * dispnew.c (flush_stdout):
4600 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4601 Mark as externally visible.
4602 * dispnew.c (check_window_matrix_pointers): Now static.
4603 * dispnew.c (window_to_frame_vpos):
4604 * xfns.c (unwind_create_frame):
4605 * xterm.c (x_check_font): Remove unused local.
4606 * scroll.c (CHECK_BOUNDS):
4607 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4608 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4609 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4610 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4611 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4613 (debug_method_add): Use va_list and vsprintf rather than relying
4614 on undefined behavior with wrong number of arguments.
4615 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4616 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4617 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4618 since we're not interested in debugging glyphs with old libraries.
4619 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4620 GCC 4.6.0's static checking.
4622 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4624 Integer overflow and signedness fixes (Bug#8873).
4625 A few related buffer overrun fixes, too.
4627 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4629 * dispextern.h (struct face.stipple):
4630 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4631 (x_bitmap_mask, x_allocate_bitmap_record)
4632 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4633 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4634 (x_create_bitmap_from_xpm_data):
4635 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4636 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4638 * xfaces.c (load_pixmap):
4639 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4640 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4641 (.bitmaps_last, struct x_output.icon_bitmap):
4642 Use ptrdiff_t, not int, for bitmap indexes.
4643 (x_allocate_bitmap_record): Check for size overflow.
4644 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4646 Use ptrdiff_t, not int, for overlay counts.
4647 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4648 * editfns.c (overlays_around, get_pos_property):
4649 * textprop.c (get_char_property_and_overlay):
4650 * xdisp.c (next_overlay_change, note_mouse_highlight):
4651 * xfaces.c (face_at_buffer_position):
4652 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4653 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4654 (Fnext_overlay_change, Fprevious_overlay_change)
4655 (mouse_face_overlay_overlaps, Foverlays_in):
4656 Use ptrdiff_t, not int, for sizes.
4657 (overlays_at, overlays_in): Check for size-calculation overflow.
4659 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4661 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4662 (x_session_initialize): Do not assume string length fits in int.
4664 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4665 This is unlikely, but can occur if DPI is outlandish.
4667 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4668 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4670 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4671 * xrdb.c (magic_file_p, search_magic_path):
4672 Omit last arg SUFFIX; it was always 0. All callers changed.
4673 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4675 * xfont.c (xfont_match): Avoid need for strlen.
4677 * xfns.c: Don't assume strlen fits in int.
4678 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4680 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4681 not unsigned long, as we prefer signed integers. All callers changed.
4682 Detect integer overflow in repeat count.
4683 (message_dolog): Don't assume print length fits in 39 bytes.
4684 (display_mode_element): Don't assume strlen fits in int.
4686 * termcap.c: Don't assume sizes fit in int and never overflow.
4687 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4688 (gobble_line): Check for size-calculation overflow.
4690 * minibuf.c (Fread_buffer):
4691 * lread.c (intern, intern_c_string):
4692 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4693 Don't assume string length fits in int.
4695 * keyboard.c (parse_tool_bar_item):
4696 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4698 * font.c: Don't assume string length fits in int.
4699 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4700 Use ptrdiff_t, not int.
4701 (font_intern_prop): Don't assume string length fits in int.
4702 Don't assume integer property fits in fixnum.
4703 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4705 * filelock.c: Fix some buffer overrun and integer overflow issues.
4706 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4707 Reformulate so as not to need the command string.
4708 Invoke gzip -cd rather than gunzip, as it's more portable.
4709 (lock_info_type, lock_file_1, lock_file):
4710 Don't assume pid_t and time_t fit in unsigned long.
4711 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4712 (current_lock_owner): Prefer signed type for sizes.
4713 Use memcpy, not strncpy, where memcpy is what is really wanted.
4714 Don't assume (via atoi) that time_t and pid_t fit in int.
4715 Check for time_t and/or pid_t out of range, e.g., via a network share.
4716 Don't alloca where an auto var works fine.
4718 * fileio.c: Fix some integer overflow issues.
4719 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4720 Don't assume string length fits in int.
4721 (directory_file_name): Don't assume string length fits in long.
4722 (make_temp_name): Don't assume pid fits in int, or that its print
4723 length is less than 20.
4725 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4727 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4729 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4731 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4732 We prefer signed integers, even for size calculations.
4734 * emacs.c: Don't assume string length fits in 'int'.
4735 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4736 (main): Don't invoke strlen when not needed.
4738 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4739 (XD_DEBUG_MESSAGE): Don't waste a byte.
4741 * callproc.c (getenv_internal_1, getenv_internal)
4743 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4745 * lread.c (invalid_syntax): Omit length argument.
4746 All uses changed. This doesn't fix a bug, but it simplifies the
4747 code away from its former Hollerith-constant appearance, and it's
4748 one less 'int' to worry about when looking at integer-overflow issues.
4749 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4751 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4752 This didn't break anything, but it didn't help either.
4753 It's confusing to put a bogus integer in a place where the actual
4754 value does not matter.
4755 (LIST_END_P): Remove unused macro and its bogus comment.
4756 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4758 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4759 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4761 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4762 We prefer signed types, and the value cannot exceed the EMACS_INT
4763 range anyway (because otherwise the length would not be representable).
4764 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4765 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4766 This avoids a GCC warning when WIDE_EMACS_INT.
4768 * indent.c (sane_tab_width): New function.
4769 (current_column, scan_for_column, Findent_to, position_indentation)
4770 (compute_motion): Use it. This is just for clarity.
4771 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4773 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4775 * lisp.h (lint_assume): New macro.
4776 * composite.c (composition_gstring_put_cache):
4777 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4779 * editfns.c, insdel.c:
4780 Omit unnecessary forward decls, to simplify future changes.
4782 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4784 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4786 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4787 Use much-faster test for byte-length change.
4788 Don't assume string byte-length fits in 'int'.
4789 Check that character arg fits in 'int'.
4790 (mapcar1): Declare byte as byte, for clarity.
4792 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4794 * fns.c (concat): Catch string overflow earlier.
4795 Do not rely on integer wraparound.
4797 * dispextern.h (struct it.overlay_strings_charpos)
4798 (struct it.selective): Now EMACS_INT, not int.
4799 * xdisp.c (forward_to_next_line_start)
4800 (back_to_previous_visible_line_start)
4801 (reseat_at_next_visible_line_start, next_element_from_buffer):
4802 Don't arbitrarily truncate the value of 'selective' to int.
4804 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4806 * composite.c: Don't truncate sizes to 'int'.
4807 (composition_gstring_p, composition_reseat_it)
4808 (composition_adjust_point): Use EMACS_INT, not int.
4809 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4810 not EMACS_UINT, for indexes.
4812 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4814 * buffer.c: Include <verify.h>.
4815 (struct sortvec.priority, struct sortstr.priority):
4816 Now EMACS_INT, not int.
4817 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4818 (struct sortstr.size, record_overlay_string)
4819 (struct sortstrlist.size, struct sortlist.used):
4820 Don't truncate size to int.
4821 (record_overlay_string): Check for size-calculation overflow.
4822 (init_buffer_once): Check at compile-time, not run-time.
4824 2011-06-22 Jim Meyering <meyering@redhat.com>
4826 Don't leak an XBM-image-sized buffer
4827 * image.c (xbm_load): Free the image buffer after using it.
4829 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4832 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4833 that Sun C diagnosed.
4834 * fns.c (secure_hash): Fix pointer signedness issue.
4835 * intervals.c (static_offset_intervals): New function.
4836 (offset_intervals): Use it.
4838 2011-06-21 Leo Liu <sdl.web@gmail.com>
4841 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4844 * fns.c (secure_hash): Rename from crypto_hash_function and change
4845 the first arg to accept symbols.
4846 (Fsecure_hash): New primitive.
4847 (syms_of_fns): New symbols.
4849 2011-06-20 Deniz Dogan <deniz@dogan.se>
4851 * process.c (Fset_process_buffer): Clarify return value in
4854 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4856 * dispnew.c (add_window_display_history): Use BVAR.
4858 * xdisp.c (debug_method_add): Use BVAR.
4859 (check_window_end, dump_glyph_matrix, dump_glyph)
4860 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4862 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4865 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4866 check till after the cache is created in init_frame_faces.
4868 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4870 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4872 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4874 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4875 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4876 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4878 Improve buffer-overflow checking (Bug#8873).
4879 * fileio.c (Finsert_file_contents):
4880 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4881 Remove the old (too-loose) buffer overflow checks.
4882 They weren't needed, since make_gap checks for buffer overflow.
4883 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4884 The old code merely checked for Emacs fixnum overflow, and relied
4885 on undefined (wraparound) behavior. The new code avoids undefined
4886 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4888 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4889 Tune. Don't use wider integers than needed. Don't use alloca.
4890 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4892 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4894 * insdel.c, lisp.h (buffer_overflow): New function.
4895 (insert_from_buffer_1, replace_range, replace_range_2):
4896 * insdel.c (make_gap_larger):
4897 * editfns.c (Finsert_char):
4898 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4900 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4902 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4904 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4906 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4907 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4909 * fileio.c: Don't assume EMACS_INT fits in off_t.
4910 (emacs_lseek): New static function.
4911 (Finsert_file_contents, Fwrite_region): Use it.
4912 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4914 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4916 * fns.c: Don't overflow int when computing a list length.
4917 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4918 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4919 truncation on 64-bit hosts. Check for QUIT every
4920 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4921 faster and is responsive enough.
4922 (Flength): Report an error instead of overflowing an integer.
4923 (Fsafe_length): Return a float if the value is not representable
4924 as a fixnum. This shouldn't happen except in contrived situations.
4925 (Fnthcdr, Fsort): Don't assume list length fits in int.
4926 (Fcopy_sequence): Don't assume vector length fits in int.
4928 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4929 (header_size, word_size): New constants.
4930 (allocate_vectorlike): Don't check size overflow here.
4931 (allocate_vector): Check it here instead, since this is the only
4932 caller of allocate_vectorlike that could cause overflow.
4933 Check that the new vector's length is representable as a fixnum.
4935 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4936 The previous code was bogus. For example, next_almost_prime (32)
4937 returned 39, which is undesirable as it is a multiple of 3; and
4938 next_almost_prime (24) returned 25, which is a multiple of 5 so
4939 why was the code bothering to check for multiples of 7?
4941 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4943 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4945 Variadic C functions now count arguments with ptrdiff_t.
4946 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4947 Back then I didn't know that the Emacs coding style prefers signed int.
4948 Also, in the meantime I found a few more instances where arguments
4949 were being counted with int, which may truncate counts on 64-bit
4950 machines, or EMACS_INT, which may be unnecessarily wide.
4951 * lisp.h (struct Lisp_Subr.function.aMANY)
4952 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4953 Arg counts are now ptrdiff_t, not size_t.
4954 All variadic functions and their callers changed accordingly.
4955 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4956 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4957 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4958 * callint.c (Fcall_interactively): Check arg count for overflow,
4959 to avoid potential buffer overrun. Use signed char, not 'int',
4960 for 'varies' array, so that we needn't bother to check its size
4961 calculation for overflow.
4962 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4963 * eval.c (apply_lambda):
4964 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4965 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4966 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4968 * callint.c (Fcall_interactively): Don't use index var as event count.
4970 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4971 * mem-limits.h (SIZE): Remove; no longer used.
4973 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4975 Remove unnecessary casts.
4976 * xterm.c (x_term_init):
4977 * xfns.c (x_set_border_pixel):
4978 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4979 These aren't needed now that we assume ANSI C.
4981 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4982 It's more likely to cause problems (due to unsigned overflow)
4985 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4987 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4989 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4991 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4993 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4995 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4997 GLYPH_CODE_FACE returns EMACS_INT, not int.
4998 * dispextern.h (merge_faces):
4999 * xfaces.c (merge_faces):
5000 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5001 Don't assume EMACS_INT fits in int.
5003 * character.h (CHAR_VALID_P): Remove unused parameter.
5004 * fontset.c, lisp.h, xdisp.c: All uses changed.
5006 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5008 * fns.c (concat): Minor tuning based on overflow analysis.
5009 This doesn't fix any bugs. Use int to hold character, instead
5010 of constantly refetching from Emacs object. Use XFASTINT, not
5011 XINT, for value known to be a character. Don't bother comparing
5012 a single byte to 0400, as it's always less.
5014 * floatfns.c (Fexpt):
5015 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5017 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5020 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5022 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5023 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5024 incorrectly succeed when S was a string, because 4294967386 was
5025 truncated before it was used.
5027 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5028 Otherwise, an out-of-range integer could cause undefined behavior
5031 * composite.c: Use int, not EMACS_INT, for characters.
5032 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5033 EMACS_INT, for values that are known to be in character range.
5034 This doesn't fix any bugs but is the usual style inside Emacs and
5035 may generate better code on 32-bit machines.
5037 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5038 This is for reasons similar to the recent CHAR_STRING fix.
5039 * charset.c (Fencode_char): Check that character arg is actually
5040 a character. Pass an int to ENCODE_CHAR.
5041 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5042 wider than 'int', as a compile-time check to prevent future regressions
5045 * character.c (char_string): Remove unnecessary casts.
5047 Make sure a 64-bit char is never passed to CHAR_STRING.
5048 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5049 by silently ignoring the top 32 bits, allowing some values
5050 that were far too large to be valid characters.
5051 * character.h: Include <verify.h>.
5052 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5053 arguments are no wider than unsigned, as a compile-time check
5054 to prevent future regressions in this area.
5056 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5057 (Fsubst_char_in_region):
5059 * xdisp.c (decode_mode_spec_coding):
5060 Adjust to CHAR_STRING's new requirement.
5061 * editfns.c (Finsert_char, Fsubst_char_in_region):
5062 * fns.c (concat): Check that character args are actually
5063 characters. Without this test, these functions did the wrong
5064 thing with wildly out-of-range values on 64-bit hosts.
5066 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5067 These casts should not be needed on 32-bit hosts, either.
5068 * keyboard.c (read_char):
5069 * lread.c (Fload): Remove casts to unsigned.
5071 * lisp.h (UNSIGNED_CMP): New macro.
5072 This fixes comparison bugs on 64-bit hosts.
5073 (ASCII_CHAR_P): Use it.
5074 * casefiddle.c (casify_object):
5075 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5076 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5077 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5078 * dispextern.h (FACE_FROM_ID):
5079 * keyboard.c (read_char): Use UNSIGNED_CMP.
5081 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5082 not to EMACS_INT, to avoid GCC warning.
5084 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5086 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5087 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5088 isn't needed on 32-bit machines.
5090 * buffer.c (Fgenerate_new_buffer_name):
5091 Use EMACS_INT for count, not int.
5092 (advance_to_char_boundary): Return EMACS_INT, not int.
5094 * data.c (Qcompiled_function): Now static.
5096 * window.c (window_body_lines): Now static.
5098 * image.c (gif_load): Rename local to avoid shadowing.
5100 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5101 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5102 * alloc.c (make_save_value): Integer argument is now of type
5104 (mark_object): Use ptrdiff_t, not int.
5105 * lisp.h (pD): New macro.
5106 * print.c (print_object): Use it.
5108 * alloc.c: Use EMACS_INT, not int, to count objects.
5109 (total_conses, total_markers, total_symbols, total_vector_size)
5110 (total_free_conses, total_free_markers, total_free_symbols)
5111 (total_free_floats, total_floats, total_free_intervals)
5112 (total_intervals, total_strings, total_free_strings):
5113 Now EMACS_INT, not int. All uses changed.
5114 (Fgarbage_collect): Compute overall total using a double, so that
5115 integer overflow is less likely to be a problem. Check for overflow
5116 when converting back to an integer.
5117 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5118 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5119 These were 'int' variables that could overflow on 64-bit hosts;
5120 they were never used, so remove them instead of repairing them.
5121 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5122 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5123 Previously, this ceilinged at INT_MAX, but that doesn't work on
5125 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5127 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5128 (allocate_vectorlike): Check for ptrdiff_t overflow.
5129 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5130 when a (possibly-narrower) signed value would do just as well.
5131 We prefer using signed arithmetic, to avoid comparison confusion.
5133 * alloc.c: Catch some string size overflows that we were missing.
5134 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5135 for convenience in STRING_BYTES_MAX.
5136 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5137 The definition here is exact; the one in lisp.h was approximate.
5138 (allocate_string_data): Check for string overflow. This catches
5139 some instances we weren't catching before. Also, it catches
5140 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5141 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5142 and ptrdiff_t and EMACS_INT are both 64 bits.
5144 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5145 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5146 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5148 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5150 * alloc.c (Fmake_string): Check for out-of-range init.
5152 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5154 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5156 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5158 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5159 xg_get_default_scrollbar_width.
5161 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5162 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5163 (style_changed_cb): Call update_theme_scrollbar_width and call
5164 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5165 all frames (Bug#8505).
5166 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5167 Call gtk_window_set_resizable if HAVE_GTK3.
5168 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5169 and height if HAVE_GTK3 (Bug#8505).
5170 (scroll_bar_width_for_theme): New variable.
5171 (update_theme_scrollbar_width): New function.
5172 (xg_get_default_scrollbar_width): Move code to
5173 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5174 (xg_initialize): Call update_theme_scrollbar_width.
5176 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5178 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5180 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5182 * frame.c (make_frame): Call other_buffer_safely instead of
5185 * window.c (temp_output_buffer_show): Call display_buffer with
5186 second argument Vtemp_buffer_show_specifiers and reset latter
5187 immediately after the call.
5188 (Vtemp_buffer_show_specifiers): New variable.
5189 (auto_window_vscroll_p, next_screen_context_lines)
5190 (Vscroll_preserve_screen_position): Remove leading asterisks from
5193 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5195 Fix minor problems found by GCC 4.6.0 static checking.
5196 * buffer.c (Qclone_number): Remove for now, as it's unused.
5197 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5198 (record_buffer): Remove unused local.
5199 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5200 (set_frame_buffer_list): Remove; unused.
5201 * frame.h (other_visible_frames): Remove decl.
5202 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5203 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5204 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5206 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5207 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5208 Define only if HAVE_GPM.
5209 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5210 (update_hints_inhibit): Remove; never set. All uses removed.
5211 * widgetprv.h (emacsFrameClassRec): Remove decl.
5212 * window.c (delete_deletable_window): Now returns void, since it
5213 wasn't returning anything.
5214 (compare_window_configurations): Remove unused locals.
5215 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5216 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5217 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5218 the same widths as pointers. This follows up on the 2011-05-06 patch.
5219 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5220 * xterm.h: Likewise.
5221 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5223 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5225 * makefile.w32-in: Update dependencies.
5226 (LISP_H): Add lib/intprops.h.
5228 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5230 * image.c (gif_load): Add animation frame delay to the metadata.
5231 (syms_of_image): Use DEFSYM. New symbol `delay'.
5233 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5235 * window.c (delete_deletable_window): Re-add.
5236 (Fset_window_configuration): Rewrite to handle dead buffers and
5237 consequently deletable windows.
5238 (window_tree, Fwindow_tree): Remove. Supply functionality in
5240 (compare_window_configurations): Simplify code.
5242 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5244 * image.c (imagemagick_load_image): Fix type mismatch.
5245 (Fimagemagick_types): Likewise.
5247 * window.h (replace_buffer_in_windows): Declare.
5249 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5251 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5252 Qclone_number. Remove external declaration of Qdelete_window.
5253 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5255 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5256 Run Qbuffer_list_update_hook if allowed.
5257 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5258 buffer list implementation.
5259 (other_buffer_safely): New function.
5260 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5261 calls to replace_buffer_in_windows and
5262 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5264 (record_buffer): Inhibit quitting and rewrite using quittable
5265 functions. Run Qbuffer_list_update_hook if allowed.
5266 (Frecord_buffer, Funrecord_buffer): New functions.
5267 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5268 Move switch-to-buffer to window.el.
5269 (bury-buffer): Move to window.el.
5270 (Vbuffer_list_update_hook): New variable.
5272 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5275 * window.h (resize_frame_windows): Move up in code.
5276 (Fwindow_frame): Remove EXFUN.
5277 (replace_buffer_in_all_windows): Remove prototype.
5278 (replace_buffer_in_windows_safely): Add prototype.
5280 * window.c: Declare Qdelete_window static again. Move down
5281 declaration of select_count.
5282 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5283 (Fother_window): Move to window.el.
5284 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5285 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5286 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5288 (replace_buffer_in_windows): Implement by calling
5289 Qreplace_buffer_in_windows.
5290 (replace_buffer_in_all_windows): Remove with some functionality
5291 moved into replace_buffer_in_windows_safely.
5292 (replace_buffer_in_windows_safely): New function.
5293 (select_window_norecord, select_frame_norecord): Move in front
5294 of run_window_configuration_change_hook. Remove now obsolete
5296 (Fset_window_buffer): Rewrite doc-string.
5297 Call Qrecord_window_buffer.
5298 (keys_of_window): Move binding for other-window to window.el.
5300 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5302 * dispextern.h (struct image): Replace data member, whose int_val
5303 and ptr_val fields were not used by anything, with a single
5306 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5307 (gif_clear_image, gif_load, imagemagick_load_image)
5308 (gs_clear_image, gs_load): Callers changed.
5310 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5312 * buffer.h: Include <time.h>, for time_t.
5313 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5315 Fix minor problems found by static checking.
5317 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5319 Make identifiers static if they are not used in other modules.
5320 * data.c (Qcompiled_function, Qframe, Qvector):
5321 * image.c (QimageMagick, Qsvg):
5322 * minibuf.c (Qmetadata):
5323 * window.c (resize_window_check, resize_root_window): Now static.
5324 * window.h (resize_window_check, resize_root_window): Remove decls.
5326 * window.c (window_deletion_count, delete_deletable_window):
5328 (window_body_lines): Now static.
5329 (Fdelete_other_windows_internal): Mark vars as initialized.
5330 Make sure 'resize_failed' is initialized.
5331 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5332 (resize_window_apply): Remove unused local.
5333 * window.h (delete_deletable_window): Remove decl.
5335 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5336 (imagemagick_load_image): Fix pointer signedness problem by changing
5337 last arg from unsigned char * to char *. All uses changed.
5338 Also, fix a local for similar reasons.
5339 Remove unused locals. Remove locals to avoid shadowing.
5340 (fn_rsvg_handle_free): Remove; unused.
5341 (svg_load, svg_load_image): Fix pointer signedness problem.
5342 (imagemagick_load_image): Don't use garbage pointer image_wand.
5344 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5346 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5348 * image.c (gif_load): Fix omitted cast error introduced by
5351 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5353 * window.h (resize_proportionally, orig_total_lines)
5354 (orig_top_line): Remove from window structure.
5355 (set_window_height, set_window_width, change_window_heights)
5356 (Fdelete_window): Remove prototypes.
5357 (resize_frame_windows): Remove duplicate declaration.
5359 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5361 * window.h (resize_frame_windows, resize_window_check)
5362 (delete_deletable_window, resize_root_window)
5363 (resize_frame_windows): Declare prototypes.
5365 * window.c (resize_window_apply): Make definition be "static" to
5366 match the prototype.
5368 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5370 * window.c: Remove declarations of Qwindow_size_fixed,
5371 window_min_size_1, window_min_size_2, window_min_size,
5372 size_window, window_fixed_size_p, enlarge_window, delete_window.
5373 Remove static from declaration of Qdelete_window, it's
5374 temporarily needed by Fbury_buffer.
5375 (replace_window): Don't assign orig_top_line and
5377 (Fdelete_window, delete_window): Remove. Window deletion is
5378 handled by window.el.
5379 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5380 Replace Fdelete_window calls with calls to Qdelete_window.
5381 (Fdelete_other_windows): Remove. Deleting other windows is
5382 handled by window.el.
5383 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5384 handled in window.el.
5385 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5386 Window minimum sizes are handled in window.el.
5387 (shrink_windows, size_window, set_window_height)
5388 (set_window_width, change_window_heights, window_height)
5389 (window_width, CURBEG, CURSIZE, enlarge_window)
5390 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5391 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5392 handled in window.el.
5393 (make_dummy_parent): Rename to make_parent_window and give it a
5394 second argument horflag.
5395 (make_window): Don't set resize_proportionally any more.
5396 (Fsplit_window): Remove. Windows are split in window.el.
5397 (save_restore_action, save_restore_orig_size)
5398 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5399 Resize mini windows in window.el.
5400 (grow_mini_window, shrink_mini_window): Implement by calling
5401 Qresize_root_window_vertically, resize_window_check and
5402 resize_window_apply.
5403 (saved_window, Fset_window_configuration, save_window_save):
5404 Do not handle orig_top_line, orig_total_lines, and
5405 resize_proportionally.
5406 (window_min_height, window_min_width): Move to window.el.
5407 (keys_of_window): Move bindings for delete-other-windows,
5408 split-window, delete-window and enlarge-window to window.el.
5410 * buffer.c: Temporarily extern Qdelete_window.
5411 (Fbury_buffer): Temporarily call Qdelete_window instead of
5412 Fdelete_window (Fbury_buffer will move to window.el soon).
5414 * frame.c (set_menu_bar_lines_1): Remove code handling
5415 orig_top_line and orig_total_lines.
5417 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5418 set_window_height but set heights directly.
5419 (change_frame_size_1): Use resize_frame_windows.
5421 * xdisp.c (init_xdisp): Don't use set_window_height but set
5424 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5425 Use resize_frame_windows instead of change_window_heights and run
5426 run_window_configuration_change_hook.
5428 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5429 instead of change_window_heights and run
5430 run_window_configuration_change_hook.
5432 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5434 * window.c (replace_window): Rename second argument REPLACEMENT to
5435 NEW. New third argument SETFLAG. Rewrite.
5436 (delete_window, make_dummy_parent): Call replace_window with
5438 (window_list_1): Move down in code.
5439 (run_window_configuration_change_hook): Move set_buffer part
5440 before select_frame_norecord part in order to unwind correctly.
5441 Rename count1 to count.
5442 (recombine_windows, delete_deletable_window, resize_root_window)
5443 (Fdelete_other_windows_internal)
5444 (Frun_window_configuration_change_hook, make_parent_window)
5445 (resize_window_check, resize_window_apply, Fresize_window_apply)
5446 (resize_frame_windows, Fsplit_window_internal)
5447 (Fdelete_window_internal, Fresize_mini_window_internal):
5449 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5451 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5453 * window.h (window): Add some new members to window structure -
5454 normal_lines, normal_cols, new_total, new_normal, clone_number,
5455 splits, nest, prev_buffers, next_buffers.
5456 (WINDOW_TOTAL_SIZE): Move here from window.c.
5457 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5459 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5461 (make_dummy_parent): Set new members of windows structure.
5462 (make_window): Move down in code. Handle new members of window
5464 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5465 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5466 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5467 (Fset_window_prev_buffers, Fwindow_next_buffers)
5468 (Fset_window_next_buffers, Fset_window_clone_number):
5470 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5471 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5473 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5474 Argument WINDOW can be now internal window too.
5475 (Fwindow_use_time): Move up in code.
5476 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5478 (Fset_window_configuration, saved_window)
5479 (Fcurrent_window_configuration, save_window_save): Handle new
5480 members of window structure.
5481 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5482 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5483 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5484 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5485 Qget_mru_window, Qresize_root_window,
5486 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5487 Qauto_buffer_name; staticpro them.
5489 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5491 * window.c (Fwindow_total_size, Fwindow_left_column)
5492 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5493 (Fwindow_list_1): New functions.
5494 (window_box_text_cols): Replace with window_body_cols.
5495 (Fwindow_width, Fscroll_left, Fscroll_right):
5496 Use window_body_cols instead of window_box_text_cols.
5497 (delete_window, Fset_window_configuration):
5498 Call delete_all_subwindows with window as argument.
5499 (delete_all_subwindows): Take a window as argument and not a
5501 (window_loop): Remove handling of GET_LRU_WINDOW and
5503 (Fget_lru_window, Fget_largest_window): Move to window.el.
5505 * window.h: Extern window_body_cols instead of
5506 window_box_text_cols. delete_all_subwindows now takes a
5507 Lisp_Object as argument.
5509 * indent.c (compute_motion, Fcompute_motion):
5510 Use window_body_cols instead of window_box_text_cols.
5512 * frame.c (delete_frame): Call delete_all_subwindows with root
5515 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5517 * fns.c (Fputhash): Document return value.
5519 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5521 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5523 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5525 Cons<->int and similar integer overflow fixes (Bug#8794).
5527 Check for overflow when converting integer to cons and back.
5528 * charset.c (Fdefine_charset_internal, Fdecode_char):
5529 Use cons_to_unsigned to catch overflow.
5530 (Fencode_char): Use INTEGER_TO_CONS.
5531 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5532 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5533 * data.c (long_to_cons, cons_to_long): Remove.
5534 (cons_to_unsigned, cons_to_signed): New functions.
5535 These signal an error for invalid or out-of-range values.
5536 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5537 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5538 * font.c (Ffont_variation_glyphs):
5539 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5540 * lisp.h: Include <intprops.h>.
5541 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5542 (cons_to_signed, cons_to_unsigned): New decls.
5543 (long_to_cons, cons_to_long): Remove decls.
5544 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5545 (Fprimitive_undo): Use CONS_TO_INTEGER.
5546 * xfns.c (Fx_window_property): Likewise.
5547 * xselect.c: Include <limits.h>.
5548 (x_own_selection, selection_data_to_lisp_data):
5549 Use INTEGER_TO_CONS.
5550 (x_handle_selection_request, x_handle_selection_clear)
5551 (x_get_foreign_selection, Fx_disown_selection_internal)
5552 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5553 (lisp_data_to_selection_data): Use cons_to_unsigned.
5554 (x_fill_property_data): Use cons_to_signed.
5555 Report values out of range.
5557 Check for buffer and string overflow more precisely.
5558 * buffer.h (BUF_BYTES_MAX): New macro.
5559 * lisp.h (STRING_BYTES_MAX): New macro.
5560 * alloc.c (Fmake_string):
5561 * character.c (string_escape_byte8):
5562 * coding.c (coding_alloc_by_realloc):
5563 * doprnt.c (doprnt):
5564 * editfns.c (Fformat):
5566 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5567 since they may not be the same number.
5568 * editfns.c (Finsert_char):
5569 * fileio.c (Finsert_file_contents):
5570 Likewise for BUF_BYTES_MAX.
5572 * image.c: Use ptrdiff_t, not int, for sizes.
5573 (slurp_file): Switch from int to ptrdiff_t.
5575 (slurp_file): Check that file size fits in both size_t (for
5576 malloc) and ptrdiff_t (for sanity and safety).
5578 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5579 if b->modtime has its maximal value.
5581 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5583 Don't assume time_t can fit into int.
5584 * buffer.h (struct buffer.modtime): Now time_t, not int.
5585 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5586 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5588 Minor fixes for signed vs unsigned integers.
5589 * character.h (MAYBE_UNIFY_CHAR):
5590 * charset.c (maybe_unify_char):
5591 * keyboard.c (read_char, reorder_modifiers):
5592 XINT -> XFASTINT, since the integer must be nonnegative.
5593 * ftfont.c (ftfont_spec_pattern):
5594 * keymap.c (access_keymap, silly_event_symbol_error):
5595 XUINT -> XFASTINT, since the integer must be nonnegative.
5596 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5597 since it makes no difference and we prefer signed.
5598 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5599 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5602 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5604 * window.h (Fwindow_frame): Declare.
5606 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5608 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5609 (SPARE_MEMORY): Always define.
5610 (LARGE_REQUEST): Remove.
5611 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5613 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5615 * lisp.h: Move EXFUNS for Fframe_root_window,
5616 Fframe_first_window and Fset_frame_selected_window to window.h.
5618 * window.h: Move EXFUNS for Fframe_root_window,
5619 Fframe_first_window and Fset_frame_selected_window here from
5622 * frame.c (Fwindow_frame, Fframe_first_window)
5623 (Fframe_root_window, Fframe_selected_window)
5624 (Fset_frame_selected_window): Move to window.c.
5625 (Factive_minibuffer_window): Move to minibuf.c.
5626 (Fother_visible_frames_p): New function.
5628 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5630 * window.c (decode_window, decode_any_window): Move up in code.
5631 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5632 (inhibit_frame_unsplittable): Remove unused variable.
5633 (Fwindow_buffer): Move up and rewrite doc-string.
5634 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5635 (Fwindow_prev): New functions.
5636 (Fwindow_frame): Move here from frame.c. Accept any window as
5638 (Fframe_root_window, Fframe_first_window)
5639 (Fframe_selected_window): Move here from frame.c. Accept frame
5640 or arbitrary window as argument. Update doc-strings.
5641 (Fminibuffer_window): Move up in code.
5642 (Fwindow_minibuffer_p): Move up in code and simplify.
5643 (Fset_frame_selected_window): Move here from frame.c.
5645 (Fselected_window, select_window, Fselect_window): Move up in
5646 code. Minor doc-string fixes.
5648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5650 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5651 Do not assume that spare memory exists; that assumption is valid
5652 only if SYSTEM_MALLOC.
5653 (LARGE_REQUEST): New macro, so that the issue of large requests
5654 is separated from the issue of spare memory.
5656 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5658 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5661 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5663 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5666 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5668 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5670 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5672 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5673 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5675 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5677 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5679 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5681 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5682 (x_clipboard_manager_save): Add return value.
5683 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5685 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5686 Obey Vx_select_enable_clipboard_manager. Catch errors in
5687 x_clipboard_manager_save (Bug#8779).
5688 (Vx_select_enable_clipboard_manager): New variable.
5689 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5691 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5693 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5695 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5697 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5698 in the current matrix if keep_current_p is non-zero.
5700 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5702 * bidi.c (bidi_level_of_next_char): Fix last change.
5704 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5706 Support bidi reordering of text covered by display properties.
5708 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5709 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5710 (bidi_cache_search, bidi_cache_iterator_state)
5711 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5712 (bidi_level_of_next_char, bidi_move_to_visually_next):
5713 Support character positions inside a run of characters covered by a
5715 (bidi_paragraph_init, bidi_resolve_explicit_1)
5716 (bidi_level_of_next_char): Call bidi_fetch_char and
5717 bidi_fetch_char_advance instead of FETCH_CHAR and
5719 (bidi_init_it): Initialize new members.
5720 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5722 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5723 instead of using explicit *_CHAR codes.
5724 (bidi_resolve_explicit, bidi_resolve_weak):
5725 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5726 bidirectional text is supported only in multibyte buffers.
5727 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5728 it to initialize the frame_window_p member of struct bidi_it.
5729 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5730 (bidi_resolve_explicit, bidi_resolve_weak)
5731 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5732 bidi_it->nchars is non-positive.
5733 (bidi_level_of_next_char): Don't try to lookup the cache for the
5734 next/previous character if nothing is cached there yet, or if we
5735 were just reseat()'ed to a new position.
5737 * xdisp.c (set_cursor_from_row): Set start and stop points
5738 according to the row's direction when priming the loop that looks
5739 for the glyph on which to display cursor.
5740 (single_display_spec_intangible_p): Function deleted.
5741 (display_prop_intangible_p): Reimplement to call
5742 handle_display_spec instead of single_display_spec_intangible_p.
5743 Accept 3 additional arguments needed by handle_display_spec.
5744 This fixes incorrect cursor motion across display property with complex
5745 values: lists, `(when COND...)' forms, etc.
5746 (single_display_spec_string_p): Support property values that are
5747 lists with the argument STRING its top-level element.
5748 (display_prop_string_p): Fix the condition for processing a
5749 property that is a list to be consistent with handle_display_spec.
5750 (handle_display_spec): New function, refactored from the
5751 last portion of handle_display_prop.
5752 (compute_display_string_pos): Accept additional argument
5753 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5754 value of a `display' property is a "replacing spec".
5755 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5756 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5757 the display property, but just return a value indicating whether
5758 the display property will replace the characters it covers.
5759 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5760 frame_window_p members of struct bidi_it.
5761 (compute_display_string_pos, compute_display_string_end):
5763 (push_it): Accept second argument POSITION, where pop_it should
5764 jump to continue iteration.
5765 (reseat_1): Initialize bidi_it.disp_pos.
5767 * keyboard.c (adjust_point_for_property): Adjust the call to
5768 display_prop_intangible_p to its new signature.
5770 * dispextern.h (struct bidi_it): New member frame_window_p.
5771 (bidi_init_it): Update prototypes.
5772 (display_prop_intangible_p): Update prototype.
5773 (compute_display_string_pos, compute_display_string_end):
5775 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5778 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5780 Malloc failure behavior now depends on size of allocation.
5781 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5782 * lisp.h: Change signatures accordingly.
5783 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5784 All callers changed. (Bug#8762)
5786 * gnutls.c: Use Emacs's memory allocators.
5787 Without this change, the gnutls library would invoke malloc etc.
5788 directly, which causes problems on non-SYNC_INPUT hosts, and which
5789 runs afoul of improving memory_full behavior. (Bug#8761)
5790 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5791 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5792 xfree instead of the default malloc, realloc, free.
5793 (Fgnutls_boot): No need to check for memory allocation failure,
5794 since xmalloc does that for us.
5796 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5797 * category.c (hash_get_category_set):
5798 * ccl.c (ccl_driver):
5799 * charset.c (Fdefine_charset_internal):
5800 * charset.h (struct charset.hash_index):
5801 * composite.c (get_composition_id, gstring_lookup_cache)
5802 (composition_gstring_put_cache):
5803 * composite.h (struct composition.hash_index):
5804 * dispextern.h (struct image.hash):
5805 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5806 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5807 (hashfn_equal, hashfn_user_defined, make_hash_table)
5808 (maybe_resize_hash_table, hash_lookup, hash_put)
5809 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5810 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5811 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5812 * image.c (make_image, search_image_cache, lookup_image)
5813 (xpm_put_color_table_h):
5814 * lisp.h (struct Lisp_Hash_Table):
5815 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5816 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5817 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5818 * alloc.c (allocate_vectorlike):
5819 Check for overflow in vector size calculations.
5820 * ccl.c (ccl_driver):
5821 Check for overflow when converting EMACS_INT to int.
5822 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5823 need to be updated by these changes.
5824 * fns.c (make_hash_table, maybe_resize_hash_table):
5825 Check for integer overflow with large hash tables.
5826 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5827 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5828 (SXHASH_REDUCE): New macro.
5829 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5830 Use it instead of discarding useful hash info with large hash values.
5831 (sxhash_float): New function.
5832 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5833 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5834 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5835 Rewrite to use FIXNUM_BITS, as this simplifies things.
5836 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5837 Adjust signatures to match updated version of code.
5838 (consing_since_gc): Now EMACS_INT, since a single hash table can
5839 use more than INT_MAX bytes.
5841 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5843 Make it possible to build with GCC-4.6+ -O2 -flto.
5845 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5847 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5849 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5850 Call minibuffer-inactive-mode.
5852 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5854 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5855 Update dependencies.
5857 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5859 * data.c (init_data): Remove code for UTS, this system is not
5862 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5864 Don't force ./temacs to start in terminal mode.
5866 * frame.c (make_initial_frame): Initialize faces in all cases, not
5867 only when CANNOT_DUMP is defined.
5868 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5870 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5872 * dispnew.c (add_window_display_history): Use const for the string
5873 pointer. Remove declaration, not needed.
5875 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5877 Use 'inline', not 'INLINE'.
5878 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5879 * alloc.c, fontset.c (INLINE): Remove.
5880 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5881 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5882 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5883 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5884 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5886 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5888 Make it possible to run ./temacs.
5890 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5891 syms_of_callproc does the same thing. Remove test for
5892 "initialized", do it in the caller.
5893 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5895 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5897 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5898 (read_minibuf): Use get_minibuffer.
5899 (syms_of_minibuf): Use DEFSYM.
5900 (Qmetadata): New var.
5901 * data.c (Qbuffer): Don't make it static.
5902 (syms_of_data): Use DEFSYM.
5904 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5906 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5907 (CCL_CODE_MIN): New macro.
5909 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5911 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5913 * eval.c (Qdebug): Now static.
5914 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5915 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5916 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5918 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5920 * image.c: Various fixes to ImageMagick code comments.
5921 (Fimagemagick_types): Doc fix.
5923 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5925 Minor fixes prompted by GCC 4.6.0 warnings.
5927 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5929 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5930 (x_clipboard_manager_save_all): Move extern decl to ...
5931 * xterm.h: ... here, so that it can be checked for consistency.
5933 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5935 * xselect.c (x_clipboard_manager_save_frame)
5936 (x_clipboard_manager_save_all): New functions.
5937 (Fx_clipboard_manager_save): Lisp function deleted.
5939 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5940 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5942 * xterm.h: Update prototype.
5944 2011-05-28 William Xu <william.xwl@gmail.com>
5946 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5949 2011-05-28 Jim Meyering <meyering@redhat.com>
5951 Avoid a sign-extension bug in crypto_hash_function.
5952 * fns.c (to_uchar): Define.
5953 (crypto_hash_function): Use it to convert some newly-signed
5954 variables to unsigned, to avoid sign-extension bugs. For example,
5955 without this change, (md5 "truc") would evaluate to
5956 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5957 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5958 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5960 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5962 Integer overflow fixes.
5964 * dbusbind.c: Serial number integer overflow fixes.
5965 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5966 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5967 to hold a serial number that is too large for a fixnum.
5968 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5969 Check for serial numbers out of range. Decode any serial number
5970 that was so large that it became a float. (Bug#8722)
5972 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5973 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5974 Use XFASTINT rather than XUINT when numbers are nonnegative.
5975 (xd_append_arg, Fdbus_method_return_internal):
5976 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5977 arguments, check that Lisp number is nonnegative, rather than
5978 silently wrapping negative numbers around. (Bug#8722)
5979 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5982 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5984 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5986 ccl: Add integer overflow checks.
5987 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5988 (IN_INT_RANGE): New macros.
5989 (ccl_driver): Use them to check for integer overflow when
5990 decoding a CCL program. Many of the new checks are whether XINT (x)
5991 fits in int; it doesn't always, on 64-bit hosts. The new version
5992 doesn't catch all possible integer overflows, but it's an
5993 improvement. (Bug#8719)
5995 * alloc.c (make_event_array): Use XINT, not XUINT.
5996 There's no need for unsigned here.
5998 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5999 This follows up to the 2011-05-06 change that substituted uintptr_t
6000 for EMACS_INT. This case wasn't caught back then.
6002 Rework Fformat to avoid integer overflow issues.
6003 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6004 now (part of C89). Include <verify.h>.
6005 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6006 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6007 (Fformat): Avoid the prepass trying to compute sizes; it was only
6008 approximate and thus did not catch overflow reliably. Instead, walk
6009 through the format just once, formatting and computing sizes as we go,
6010 checking for integer overflow at every step, and allocating a larger
6011 buffer as needed. Keep track separately whether the format is
6012 multibyte. Keep only the most-recently calculated precision, rather
6013 than them all. Record whether each argument has been converted to
6014 string. Use EMACS_INT, not int, for byte and char and arg counts.
6015 Support field widths and precisions larger than INT_MAX. Avoid
6016 sprintf's undefined behavior with conversion specifications such as %#d
6017 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6018 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6019 formatting out-of-range floating point numbers with int
6022 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6024 * data.c: Avoid integer truncation in expressions involving floats.
6025 * data.c: Include <intprops.h>.
6026 (arith_driver): When there's an integer overflow in an expression
6027 involving floating point, convert the integers to floating point
6028 so that the resulting value does not suffer from catastrophic
6029 integer truncation. For example, on a 64-bit host (* 4
6030 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6031 Do not rely on undefined behavior after integer overflow.
6033 merge count_size_as_multibyte, parse_str_to_multibyte
6034 * character.c, character.h (count_size_as_multibyte):
6035 Rename from parse_str_to_multibyte; all uses changed.
6036 Check for integer overflow.
6037 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6038 since it's now a duplicate of the other. This is more of
6039 a character than a buffer op, so better that it's in character.c.
6040 * fns.c, print.c: Adjust to above changes.
6042 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6044 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6046 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6048 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6049 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6050 (x_clipboard_manager_save): Now static.
6051 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6053 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6054 (crypto_hash_function): Now static.
6055 Fix pointer signedness problems. Avoid unnecessary initializations.
6057 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6059 * termhooks.h (Vselection_alist): Make it terminal-local.
6061 * terminal.c (create_terminal): Initialize it.
6063 * xselect.c: Support for clipboard managers.
6064 (Vselection_alist): Move to termhooks.h as terminal-local var.
6065 (LOCAL_SELECTION): New macro.
6066 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6067 (symbol_to_x_atom): Remove gratuitous arg.
6068 (x_handle_selection_request, lisp_data_to_selection_data)
6069 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6070 (x_own_selection, x_get_local_selection, x_convert_selection):
6071 New arg, specifying work frame. Use terminal-local Vselection_alist.
6072 (some_frame_on_display): Delete unused function.
6073 (Fx_own_selection_internal, Fx_get_selection_internal)
6074 (Fx_disown_selection_internal, Fx_selection_owner_p)
6075 (Fx_selection_exists_p): New optional frame arg.
6076 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6077 (x_handle_selection_clear): Don't treat other terminals with the
6078 same keyboard specially. Use the terminal-local Vselection_alist.
6079 (x_clear_frame_selections): Use Frun_hook_with_args.
6081 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6083 * xterm.h: Add support for those atoms.
6085 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6087 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6088 (converted_selections, conversion_fail_tag): New global variables.
6089 (x_selection_request_lisp_error): Free the above.
6090 (x_get_local_selection): Remove unnecessary code.
6091 (x_reply_selection_request): Args changed; handle arbitrary array
6092 of converted selections stored in converted_selections.
6093 Separate the XChangeProperty and SelectionNotify steps.
6094 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6095 (x_convert_selection): New function.
6096 (x_handle_selection_event): Simplify.
6097 (x_get_foreign_selection): Don't ignore incoming requests while
6098 waiting for an answer; this will fail when we implement
6099 SAVE_TARGETS, and seems unnecessary anyway.
6100 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6101 (Vx_sent_selection_functions): Doc fix.
6103 2011-05-26 Leo Liu <sdl.web@gmail.com>
6105 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6107 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6109 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6111 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6112 for fringe update if it has periodic bitmap.
6113 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6114 and fringe_bitmap_periodic_p.
6116 * fringe.c (get_fringe_bitmap_data): New function.
6117 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6118 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6119 row. Mark glyph row for fringe update if periodicity changed.
6121 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6122 for fringe update unless it has periodic bitmap.
6124 2011-05-25 Kenichi Handa <handa@m17n.org>
6126 * xdisp.c (get_next_display_element): Set correct it->face_id for
6127 a static composition.
6129 2011-05-24 Leo Liu <sdl.web@gmail.com>
6132 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6134 * fns.c (crypto_hash_function, Fsha1): New function.
6135 (Fmd5): Use crypto_hash_function.
6136 (syms_of_fns): Add Ssha1.
6138 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6140 * gnutls.c: Remove unused macros.
6141 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6142 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6143 Remove macros that are defined and never used.
6144 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6146 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6148 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6149 (Fx_get_selection_internal): Minor cleanup.
6150 (Fx_own_selection_internal): Rename arguments for consistency with
6153 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6155 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6157 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6159 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6161 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6163 * dispnew.c (scrolling_window): Don't exclude the case that the
6164 last enabled row in the desired matrix touches the bottom boundary.
6166 2011-05-21 Glenn Morris <rgm@gnu.org>
6168 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6169 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6170 and add some more files.
6172 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6174 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6175 report_file_error introduced by the change from 2011-05-07.
6177 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6179 * systime.h (Time): Define only if emacs is defined.
6180 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6181 where the include path doesn't have X11/X.h by default. See
6182 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6184 2011-05-20 Kenichi Handa <handa@m17n.org>
6186 * composite.c (find_automatic_composition): Fix previous change.
6188 2011-05-20 Glenn Morris <rgm@gnu.org>
6190 * lisp.mk: New file, split from Makefile.in.
6191 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6192 (shortlisp): Remove.
6193 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6195 2011-05-19 Glenn Morris <rgm@gnu.org>
6197 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6198 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6199 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6200 (lisp): Set the order to that of loadup.el.
6201 (shortlisp): Make it a copy of $lisp.
6202 (SOME_MACHINE_LISP): Remove.
6203 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6204 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6206 2011-05-18 Kenichi Handa <handa@m17n.org>
6208 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6209 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6210 (find_automatic_composition): Mostly rewrite for efficiency.
6212 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6214 * makefile.w32-in: Update dependencies.
6216 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6218 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6219 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6221 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6223 Fix some integer overflow issues, such as string length overflow.
6225 * insdel.c (count_size_as_multibyte): Check for string overflow.
6227 * character.c (lisp_string_width): Check for string overflow.
6228 Use EMACS_INT, not int, for string indexes and lengths; in
6229 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6230 the resulting string length overflows an EMACS_INT; instead,
6231 report a string overflow if no precision given. When checking for
6232 precision exhaustion, use a check that cannot possibly have
6233 integer overflow. (Bug#8675)
6234 * character.h (lisp_string_width): Adjust to new signature.
6236 * alloc.c (string_overflow): New function.
6237 (Fmake_string): Use it. This doesn't change behavior, but saves
6238 a few bytes and will simplify future changes.
6239 * character.c (string_escape_byte8): Likewise.
6240 * lisp.h (string_overflow): New decl.
6242 Fixups, following up to the user-interface timestamp change.
6243 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6244 for UI timestamps, instead of unsigned long.
6245 * msdos.c (mouse_get_pos): Likewise.
6246 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6247 * w32gui.h (Time): Define by including "systime.h" rather than by
6248 declaring it ourselves. (Bug#8664)
6250 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6251 * image.c (clear_image_cache): Likewise.
6253 * term.c (term_mouse_position): Don't assume time_t wraparound.
6255 Be more systematic about user-interface timestamps.
6256 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6257 and sometimes 'EMACS_UINT', to represent these timestamps.
6258 This change causes it to use 'Time' uniformly, as that's what X uses.
6259 This makes the code easier to follow, and makes it easier to catch
6260 integer overflow bugs such as Bug#8664.
6261 * frame.c (Fmouse_position, Fmouse_pixel_position):
6262 Use Time, not unsigned long, for user-interface timestamps.
6263 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6264 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6265 * keyboard.h (last_event_timestamp): Likewise.
6266 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6267 * menu.h (xmenu_show): Likewise.
6268 * term.c (term_mouse_position): Likewise.
6269 * termhooks.h (struct input_event.timestamp): Likewise.
6270 (struct terminal.mouse_position_hook): Likewise.
6271 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6272 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6273 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6274 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6276 * menu.h, termhooks.h: Include "systime.h", for Time.
6278 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6279 Don't assume that the difference between two unsigned long values
6280 can fit into an integer. At this point, we know button_down_time
6281 <= event->timestamp, so the difference must be nonnegative, so
6282 there's no need to cast the result if double-click-time is
6283 nonnegative, as it should be; check that it's nonnegative, just in
6284 case. This bug is triggered when events are more than 2**31 ms
6285 apart (about 25 days). (Bug#8664)
6287 * xselect.c (last_event_timestamp): Remove duplicate decl.
6288 (x_own_selection): Remove needless cast to unsigned long.
6290 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6291 that always fit in int. Use a sentinel instead of a counter, to
6292 avoid a temp and to allay GCC's concerns about possible int overflow.
6293 * frame.h (struct frame): Use int for menu_bar_items_used
6294 instead of EMACS_INT, since it always fits in int.
6296 * menu.c (grow_menu_items): Check for int overflow.
6298 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6300 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6301 Before, the code was not consistent. These values cannot exceed
6302 2**31 - 1 so there's no need to make them unsigned.
6303 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6304 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6305 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6307 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6309 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6310 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6311 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6312 presumably because the widths might not match.
6314 * window.c (size_window): Avoid needless test at loop start.
6316 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6318 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6320 2011-05-12 Drew Adams <drew.adams@oracle.com>
6322 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6324 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6326 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6327 `width' to `bar_area_x' and `bar_area_width', respectively.
6328 (x_scroll_run): Take account of fringe background extension.
6330 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6331 Rename local vars `left' and `width' to `bar_area_x' and
6332 `bar_area_width', respectively.
6333 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6334 background extension.
6336 2011-05-10 Jim Meyering <meyering@redhat.com>
6338 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6340 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6342 * image.c (Finit_image_library): Return t for built-in image types,
6343 like pbm and xbm. (Bug#8640)
6345 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6347 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6349 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6351 * w32console.c (Fset_screen_color): Doc fix.
6352 (Fget_screen_color): New function.
6353 (syms_of_ntterm): Defsubr it.
6355 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6356 unlink the temporary file if Fcall_process didn't create it in the
6358 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6359 child process will be redirected to a file specified with `:file'.
6360 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6361 cue to call_process_cleanup not to close that handle.
6363 2011-05-07 Ben Key <bkey76@gmail.com>
6365 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6366 one of two shell specific rules, either bootstrap-temacs-CMD or
6367 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6368 to the previous implementation of the bootstrap-temacs rule.
6369 The bootstrap-temacs-CMD rule is similar to the previous
6370 implementation of the bootstrap-temacs rule except that it
6371 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6374 These changes, along with some changes to nt/configure.bat,
6375 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6376 earlier fix to add support for --cflags and --ldflags options
6377 that include quotes so that it works whether make uses cmd or
6380 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6382 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6383 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6385 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6386 a string. Handle both cases.
6387 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6388 (Fdbus_register_method): Use Qinvalid_function.
6390 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6392 * makefile.w32-in: Update dependencies.
6393 (LISP_H): Add inttypes.h and stdin.h.
6394 (PROCESS_H): Add unistd.h.
6396 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6398 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6399 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6401 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6403 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6405 * term.c (vfatal): Remove stray call to va_end.
6406 It's not needed and the C Standard doesn't allow it here anyway.
6408 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6409 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6411 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6414 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6416 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6418 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6420 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6422 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6424 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6425 * charset.c (Fdefine_charset_internal): Don't initialize
6426 charset.code_space[15]. The value was garbage, on hosts with
6427 32-bit int (Bug#8600).
6429 * lread.c (read_integer): Be more consistent with string-to-number.
6430 Use string_to_number to do the actual conversion; this avoids
6431 rounding errors and fixes some other screwups. Without this fix,
6432 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6433 (digit_to_number): Move earlier, for benefit of read_integer.
6434 Return -1 if the digit is out of range for the base, -2 if it is
6435 not a digit in any supported base. (Bug#8602)
6437 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6439 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6440 to match comment at start of function. This also removes a
6441 GCC warning about overflow in a 32+64-bit port.
6443 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6445 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6446 Reported by Stefan Monnier in
6447 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6448 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6449 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6451 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6452 (EMACS_UINTPTR): Likewise, with uintptr_t.
6454 * lisp.h: Prefer 64-bit EMACS_INT if available.
6455 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6456 on 32-bit hosts that have 64-bit int, so that they can access
6458 However, temporarily disable this change unless the temporary
6459 symbol WIDE_EMACS_INT is defined.
6461 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6463 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6464 This removes an assumption that EMACS_INT and long are the same
6465 width as pointers. The assumption is true for Emacs porting targets
6466 now, but we want to make other targets possible.
6467 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6468 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6469 In the rest of the code, change types of integers that hold casted
6470 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6471 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6472 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6473 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6474 No need to cast type when ORing.
6475 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6476 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6477 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6478 assume EMACS_INT is the same width as char *.
6479 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6480 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6481 Remove no-longer-needed casts.
6482 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6483 (xg_tool_bar_help_callback, xg_make_tool_item):
6484 Use EMACS_INTPTR to hold an integer
6485 that will be cast to void *; this can avoid a GCC warning
6486 if EMACS_INT is not the same width as void *.
6487 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6488 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6489 (current_message_1, set_message_1):
6490 Use a local to convert to proper width without a cast.
6491 * xmenu.c (dialog_selection_callback): Likewise.
6493 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6494 Also, don't assume VALBITS / RAND_BITS is less than 5,
6495 and don't rely on undefined behavior when shifting a 1 left into
6497 * lisp.h (get_random): Change signature to match.
6499 * lread.c (hash_string): Use size_t, not int, for hash computation.
6500 Normally we prefer signed values; but hashing is special, because
6501 it's better to use unsigned division on hash table sizes so that
6502 the remainder is nonnegative. Also, size_t is the natural width
6503 for hashing into memory. The previous code used 'int', which doesn't
6504 retain enough info to hash well into very large tables.
6505 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6507 * dbusbind.c: Don't possibly lose pointer info when converting.
6508 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6509 Use XPNTR rather than XHASH, so that the high-order bits of
6510 the pointer aren't lost when converting through void *.
6512 * eval.c (Fautoload): Don't double-shift a pointer.
6514 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6516 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6518 * gnutls.c (DEF_GNUTLS_FN):
6519 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6521 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6523 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6526 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6528 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6529 New version that can reserve upto 2GB of heap space.
6531 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6533 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6535 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6537 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6538 `gnutls_certificate_set_x509_key_file'.
6540 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6542 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6543 Update dependencies.
6545 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6547 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6548 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6549 Remove unused parameter `fildes'.
6550 * process.c (read_process_output, send_process): Don't pass it.
6552 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6554 Fix previous change: the library cache is defined in w32.c.
6555 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6556 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6558 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6560 Implement dynamic loading of GnuTLS on Windows.
6562 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6563 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6564 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6567 * gnutls.c (Qgnutls_dll): Define.
6568 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6569 (gnutls_*): Declare function pointers.
6570 (init_gnutls_functions): New function to initialize function pointers.
6571 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6572 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6573 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6574 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6575 (emacs_gnutls_write, emacs_gnutls_read)
6576 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6577 (Fgnutls_available_p): New function.
6578 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6579 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6580 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6582 * image.c: Include w32.h.
6583 (Vimage_type_cache): Delete.
6584 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6585 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6586 (w32_delayed_load): Move to w32.c.
6588 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6590 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6591 (w32_delayed_load): Move from image.c. When loading a library, record
6592 its filename in the :loaded-from property of the library id.
6593 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6594 Initialize and staticpro them.
6595 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6597 * process.c: Include lisp.h before w32.h, not after.
6598 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6599 instead of gnutls_record_check_pending.
6601 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6603 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6605 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6606 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6609 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6611 * xterm.c (x_set_frame_alpha): Do not set property on anything
6612 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6614 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6616 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6618 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6620 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6621 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6622 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6623 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6624 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6625 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6626 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6627 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6628 (Qgnutls_bootprop_callbacks_verify): Make static.
6630 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6632 * callproc.c: Indentation fixup.
6634 * sysdep.c (wait_for_termination_1): Make static.
6635 (wait_for_termination, interruptible_wait_for_termination):
6636 Move after wait_for_termination_1.
6638 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6640 * sysdep.c (interruptible_wait_for_termination): New function
6641 which is like wait_for_termination, but allows keyboard
6644 * callproc.c (Fcall_process): Add (:file "file") as an option for
6646 (Fcall_process_region): Ditto.
6648 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6650 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6651 rather than `XVECTOR (FOO)->size'.
6653 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6654 inttypes.h, as a gnulib replacement is used if it not available in
6657 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6659 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6660 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6661 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6663 * coding.c (coding_alloc_by_realloc): Error out if destination
6664 will grow beyond MOST_POSITIVE_FIXNUM.
6665 (decode_coding_emacs_mule): Abort if there isn't enough place in
6666 charbuf for the composition carryover bytes. Reserve an extra
6667 space for up to 2 characters produced in a loop.
6668 (decode_coding_iso_2022): Abort if there isn't enough place in
6669 charbuf for the composition carryover bytes.
6671 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6673 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6674 aborting when %lld or %lll format is passed.
6675 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6676 %llo or %llx format is passed. (Bug#8545)
6678 * window.c (window_scroll_line_based): Use a marker instead of
6679 simple variables to record original value of point. (Bug#7952)
6681 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6682 produced by %s or %c overflows available buffer space. (Bug#8545)
6684 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6686 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6687 (SIZE_MAX): Move defn after all includes, as they might #define it.
6689 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6691 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6693 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6695 * keyboard.c (Qdelayed_warnings_hook): Define.
6696 (command_loop_1): Run `delayed-warnings-hook'
6697 if Vdelayed_warnings_list is non-nil.
6698 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6699 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6701 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6703 * doprnt.c (doprnt): Don't return value smaller than the buffer
6704 size if the message was truncated. (Bug#8545).
6706 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6708 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6709 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6711 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6713 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6715 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6717 * makefile.w32-in: Update dependencies.
6719 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6721 Improve `doprnt' and its usage. (Bug#8545)
6722 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6723 `format_end'. Remove support for %l as a conversion specifier.
6724 Don't use xrealloc. Improve diagnostics when the %l size modifier
6725 is used. Update the commentary.
6727 * eval.c (verror): Simplify calculation of size_t.
6729 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6732 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6734 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6737 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6739 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6740 This makes this file independent of the recent pseudovector change.
6742 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6744 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6746 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6747 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6748 Remove unused local.
6749 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6751 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6752 GCC 4.6.0 optimizes based on type-based alias analysis.
6753 For example, if b is of type struct buffer * and v of type struct
6754 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6755 != &v->size, and therefore "v->size = 1; b->size = 2; return
6756 v->size;" must therefore return 1. This assumption is incorrect
6757 for Emacs, since it type-puns struct Lisp_Vector * with many other
6758 types. To fix this problem, this patch adds a new type struct
6759 vectorlike_header that documents the constraints on layout of vectors
6760 and pseudovectors, and helps optimizing compilers not get fooled
6761 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6762 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6763 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6765 (XSETPVECTYPE): Rewrite in terms of new macro.
6766 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6767 This is a bit clearer, and further avoids the possibility of
6768 undesirable aliasing.
6769 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6770 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6771 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6772 since Lisp_Subr is a special case (no "next" field).
6773 (ASIZE): Now uses header.size rather than size.
6774 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6775 to avoid the hassle of writing XVECTOR (foo)->header.size.
6776 (struct vectorlike_header): New type.
6777 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6778 object, to help avoid aliasing.
6779 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6780 (SUBRP): Likewise, since Lisp_Subr is a special case.
6781 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6782 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6783 (struct Lisp_Hash_Table): Combine first two members into a single
6784 struct vectorlike_header member. All uses of "size" and "next" members
6785 changed to be "header.size" and "header.next".
6786 * buffer.h (struct buffer): Likewise.
6787 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6788 * frame.h (struct frame): Likewise.
6789 * process.h (struct Lisp_Process): Likewise.
6790 * termhooks.h (struct terminal): Likewise.
6791 * window.c (struct save_window_data, struct saved_window): Likewise.
6792 * window.h (struct window): Likewise.
6793 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6794 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6795 * buffer.c (init_buffer_once): Likewise.
6796 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6798 * process.c (Fformat_network_address): Use local var for size,
6801 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6803 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6804 * data.c (atof): Remove decl; no longer used or needed.
6805 (digit_to_number): Move to lread.c.
6806 (Fstring_to_number): Use new string_to_number function, to be
6807 consistent with how the Lisp reader treats infinities and NaNs.
6808 Do not assume that floating-point numbers represent EMACS_INT
6809 without losing information; this is not true on most 64-bit hosts.
6810 Avoid double-rounding errors, by insisting on integers when
6811 parsing non-base-10 numbers, as the documentation specifies.
6812 * lisp.h (string_to_number): New decl, replacing ...
6813 (isfloat_string): Remove.
6814 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6815 (read1): Do not accept +. and -. as integers; this
6816 appears to have been a coding error. Similarly, do not accept
6817 strings like +-1e0 as floating point numbers. Do not report
6818 overflow for integer overflows unless the base is not 10 which
6819 means we have no simple and reliable way to continue.
6820 Break out the floating-point parsing into a new
6821 function string_to_number, so that Fstring_to_number parses
6822 floating point numbers consistently with the Lisp reader.
6823 (digit_to_number): Move here from data.c. Make it static inline.
6824 (E_CHAR, EXP_INT): Remove, replacing with ...
6825 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6826 (string_to_number): New function, replacing isfloat_string.
6827 This function checks for valid syntax and produces the resulting
6828 Lisp float number too. Rework it so that string-to-number
6829 no longer mishandles examples like "1.0e+". Use strtoumax,
6830 so that overflow for non-base-10 numbers is reported only when
6831 there's no portable and simple way to convert to floating point.
6833 * textprop.c (set_text_properties_1): Rewrite for clarity,
6834 and to avoid GCC warning about integer overflow.
6836 * intervals.h (struct interval): Use EMACS_INT for members
6837 where EMACS_UINT might cause problems. See
6838 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6839 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6840 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6842 (offset_intervals): Tell GCC not to worry about length overflow
6843 when negating a negative length.
6845 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6846 (overrun_check_free): Likewise.
6848 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6849 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6852 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6853 (gnutls_make_error): Rename local to avoid shadowing.
6854 (gnutls_emacs_global_deinit): ifdef out; not used.
6855 (Fgnutls_boot): Use const for pointer to readonly storage.
6856 Comment out unused local. Fix pointer signedness problems.
6858 * lread.c (openp): Don't stuff size_t into an 'int'.
6859 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6860 about possible signed overflow.
6862 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6863 (GDK_KEY_g): Don't define if already defined.
6864 (xg_prepare_tooltip): Avoid pointer signedness problem.
6865 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6867 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6868 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6870 * xfns.c (Fx_window_property): Simplify a bit,
6871 to make a bit faster and to avoid GCC 4.6.0 warning.
6872 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6874 * fns.c (internal_equal): Don't assume size_t fits in int.
6876 * alloc.c (compact_small_strings): Tighten assertion a little.
6878 Replace pEd with more-general pI, and fix some printf arg casts.
6879 * lisp.h (pI): New macro, generalizing old pEd macro to other
6880 conversion specifiers. For example, use "...%"pI"d..." rather
6881 than "...%"pEd"...".
6882 (pEd): Remove. All uses replaced with similar uses of pI.
6883 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6884 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6885 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6886 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6887 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6888 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6889 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6891 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6892 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6893 * print.c (safe_debug_print, print_object): Likewise.
6894 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6896 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6897 avoiding the 0 flag, which is not portable.
6898 * process.c (Fmake_network_process): Use pI to avoid cast.
6899 * region-cache.c (pp_cache): Likewise.
6900 * xdisp.c (decode_mode_spec): Likewise.
6901 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6902 behavior on 64-bit hosts with printf arg.
6903 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6904 (x_stop_queuing_selection_requests): Likewise.
6905 (x_get_window_property): Don't truncate byte count to an 'int'
6908 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6909 here, since it parses constructs like leading '-' and spaces,
6910 which are not wanted; and it overflows with large numbers.
6911 Instead, simply match F[0-9]+, which is what is wanted anyway.
6913 * alloc.c: Remove unportable assumptions about struct layout.
6914 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6915 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6916 (allocate_vectorlike, make_pure_vector): Use the new macros,
6917 plus offsetof, to remove unportable assumptions about struct layout.
6918 These assumptions hold on all porting targets that I know of, but
6919 they are not guaranteed, they're easy to remove, and removing them
6920 makes further changes easier.
6922 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6923 This doesn't fix a bug but makes the code clearer.
6924 (string_overrun_cookie): Now const. Use initializers that
6925 don't formally overflow signed char, to avoid warnings.
6926 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6927 can cause Emacs to crash when string overrun checking is enabled.
6928 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6929 multiple of sizeof (EMACS_INT); it need not be, if
6930 alignof(EMACS_INT) < sizeof (EMACS_INT).
6931 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6933 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6935 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6937 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6939 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6940 supposed to be handshaking. (Bug#8556)
6941 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6943 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6945 * lisp.h (Qdebug): List symbol.
6946 * eval.c (Qdebug): Restore global linkage.
6947 * keyboard.c (debug-on-event): New variable.
6948 (handle_user_signal): Break into debugger when debug-on-event
6949 matches the current signal symbol.
6951 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6953 * alloc.c (check_sblock, check_string_bytes)
6954 (check_string_free_list): Convert to standard C.
6956 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6958 * w32.c (emacs_gnutls_push): Fix typo.
6960 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6962 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6963 "cast to pointer from integer of different size".
6965 Improve doprnt and its use in verror. (Bug#8545)
6966 * doprnt.c (doprnt): Document the set of format control sequences
6967 supported by the function. Use SAFE_ALLOCA instead of always
6970 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6971 is one byte too soon. Don't use xrealloc; instead xfree and
6974 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6976 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6979 * gnutls.c: Renamed global_initialized to
6980 gnutls_global_initialized. Added internals for the
6981 :verify-hostname-error, :verify-error, and :verify-flags
6982 parameters of `gnutls-boot' and documented those parameters in the
6983 docstring. Start callback support.
6984 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6985 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6986 on error. Return error code.
6987 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6988 (emacs_gnutls_read): Likewise.
6989 (Fgnutls_boot): Return handshake error code.
6990 (emacs_gnutls_handle_error): New function.
6991 (wsaerror_to_errno): Likewise.
6993 * w32.h (emacs_gnutls_pull): Add prototype.
6994 (emacs_gnutls_push): Likewise.
6996 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6997 (emacs_gnutls_push): Likewise.
6999 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7001 * process.c (wait_reading_process_output): Check if GnuTLS
7002 buffered some data internally if no FDs are set for TLS
7005 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7006 (LIBS): Link to USER_LIBS.
7007 ($(BLD)/gnutls.$(0)): New target.
7009 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7011 * xdisp.c (handle_single_display_spec): Rename the
7012 display_replaced_before_p argument into display_replaced_p, to
7013 make it consistent with the commentary. Fix typos in the
7016 * textprop.c (syms_of_textprop): Remove dead code.
7017 (copy_text_properties): Delete obsolete commentary about an
7018 interface that was deleted long ago. Fix typos in the description
7021 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7022 to changes in oldXMenu/XMenu.h from 2011-04-16.
7023 <menu_help_message, prev_menu_help_message>: Constify.
7024 (IT_menu_make_room): menu->help_text is now `const char **';
7027 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7028 to changes in oldXMenu/XMenu.h from 2011-04-16.
7029 (struct XMenu): Declare `help_text' `const char **'.
7031 * xfaces.c <Qunspecified>: Make extern again.
7033 * syntax.c: Include sys/types.h before including regex.h, as
7036 * doc.c (get_doc_string): Improve the format passed to `error'.
7038 * doprnt.c (doprnt): Improve commentary.
7040 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7042 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7045 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7046 changes in globals.h immediately force recompilation.
7047 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7048 $(CURDIR)/s/ms-w32.h.
7049 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7051 * character.c (Fchar_direction): Function deleted.
7052 (syms_of_character): Don't defsubr it.
7053 <char-direction-table>: Deleted.
7055 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7057 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7058 * doprnt.c: Include limits.h.
7059 (SIZE_MAX): New macro.
7060 (doprnt): Return a size_t value. 2nd arg is now size_t.
7061 Many local variables are now size_t instead of int or unsigned.
7062 Improve overflow protection. Support `l' modifier for integer
7063 conversions. Support %l conversion. Don't assume an EMACS_INT
7064 argument for integer conversions and for %c.
7066 * lisp.h (doprnt): Restore prototype.
7068 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7071 * Makefile.in (base_obj): Add back doprnt.o.
7073 * deps.mk (doprnt.o): Add back prerequisites.
7074 (callint.o): Depend on character.h.
7076 * eval.c (internal_lisp_condition_case): Include the handler
7077 representation in the error message.
7078 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7079 when breaking from the loop.
7081 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7083 * callint.c (Fcall_interactively): When displaying error message
7084 about invalid control letter, pass the character's codepoint, not
7085 a pointer to its multibyte form. Improve display of the character
7086 in octal and display also its hex code.
7088 * character.c (char_string): Use %x to display the (unsigned)
7089 codepoint of an invalid character, to avoid displaying a bogus
7092 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7093 `error', not SYMBOL_NAME itself.
7095 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7096 character arguments to `error'.
7098 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7099 to `error' in error message about FINAL_CHAR argument. Make sure
7100 FINAL_CHAR is a character, and use %c when it is passed as
7101 argument to `error'.
7103 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7105 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7107 * w32.c: Include <time.h>.
7108 (sys_localtime): New function.
7110 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7112 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7114 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7116 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7118 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7121 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7123 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7124 gl_state.e_property when gl_state.object is Qt.
7126 * insdel.c (make_gap_larger): Remove limitation of buffer size
7129 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7131 * xdisp.c (lookup_glyphless_char_display)
7132 (produce_glyphless_glyph): Handle cons cell entry in
7133 glyphless-char-display.
7134 (Vglyphless_char_display): Document it.
7136 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7137 glyphless-char-display.
7139 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7141 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7143 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7145 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7146 definition for no-X builds.
7148 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7150 Static checks with GCC 4.6.0 and non-default toolkits.
7152 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7154 * process.c (keyboard_bit_set): Define only if SIGIO.
7155 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7156 (send_process): Repair possible setjmp clobbering.
7158 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7160 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7162 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7164 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7165 Define only if needed.
7167 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7168 by pacifying GCC about it. Maybe it's time to retire it?
7169 * xfaces.c (USG, __TIMEVAL__): Likewise.
7171 * dispextern.h (struct redisplay_interface): Rename param
7173 * termhooks.h (struct terminal): Likewise.
7174 * xterm.c (xembed_send_message): Likewise.
7176 * insdel.c (make_gap_smaller): Define only if
7177 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7179 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7182 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7183 so that we aren't warned about unused symbols.
7185 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7187 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7189 * xfns.c (x_real_positions): Mark locals as initialized.
7191 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7193 * xterm.c: Fix problems found by static analysis with other toolkits.
7194 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7195 (x_dispatch_event): Declare static if USE_GTK, and
7196 define if USE_GTK || USE_X_TOOLKIT.
7197 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7198 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7199 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7200 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7202 * xmenu.c (menu_help_callback): Pointer type fixes.
7203 Use const pointers when pointing at readonly data. Avoid pointer
7205 (FALSE): Remove unused macro.
7206 (update_frame_menubar): Remove unused decl.
7208 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7210 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7211 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7212 (single_menu_item): Rename local to avoid shadowing.
7214 * keyboard.c (make_lispy_event): Remove unused local var.
7216 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7217 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7219 * bitmaps: Change bitmaps from unsigned char back to the X11
7220 compatible char. Avoid the old compiler warnings about
7221 out-of-range initializers by using, for example, '\xab' rather
7224 * xgselect.c (xgselect_initialize): Check vs interface
7225 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7227 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7229 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7230 to read-only memory.
7232 * fns.c (vector): Remove; this old hack is no longer needed.
7234 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7236 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7238 * xrdb.c (x_load_resources): Omit unused local.
7240 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7241 (x_window): Rename locals to avoid shadowing.
7242 (USG): Use the kludged USG macro, to pacify gcc.
7244 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7245 (x_term_init): Remove local to avoid shadowing.
7247 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7249 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7250 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7252 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7254 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7256 Fix regex.c, syntax.c and friends for buffers > 2GB.
7257 * syntax.h (struct gl_state_s): Declare character position members
7260 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7262 * textprop.c (verify_interval_modification, interval_of):
7263 Declare arguments EMACS_INT.
7265 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7268 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7270 * indent.c (Fvertical_motion): Local variable it_start is now
7273 * regex.c (re_match, re_match_2, re_match_2_internal)
7274 (bcmp_translate, regcomp, regexec, print_double_string)
7275 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7276 (re_compile_pattern, re_exec): Declare arguments and local
7277 variables `size_t' and `ssize_t' and return values `regoff_t', as
7279 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7280 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7281 <compile_stack_type>: `size' and `avail' are now `size_t'.
7283 * regex.h <regoff_t>: Use ssize_t, not int.
7284 (re_search, re_search_2, re_match, re_match_2): Arguments that
7285 specify buffer/string position and length are now ssize_t and
7286 size_t. Return type is regoff_t.
7288 2011-04-16 Ben Key <bkey76@gmail.com>
7290 * nsfont.m: Fixed bugs in ns_get_family and
7291 ns_descriptor_to_entity that were caused by using free to
7292 deallocate memory blocks that were allocated by xmalloc (via
7293 xstrdup). This caused Emacs to crash when compiled with
7294 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7295 --enable-checking=xmallocoverrun). xfree is now used to
7296 deallocate these memory blocks.
7298 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7300 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7302 emacs_write: Accept and return EMACS_INT for sizes.
7303 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7305 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7306 Accept and return EMACS_INT.
7307 (emacs_gnutls_write): Return the number of bytes written on
7309 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7310 (emacs_read, emacs_write): Remove check for negative size, as the
7311 Emacs source code has been audited now.
7312 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7313 (emacs_read, emacs_write): Use it.
7314 * process.c (send_process): Adjust to the new signatures of
7315 emacs_write and emacs_gnutls_write. Do not attempt to store
7316 a byte offset into an 'int'; it might overflow.
7317 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7319 * sound.c: Don't assume sizes fit in 'int'.
7320 (struct sound_device.period_size, alsa_period_size):
7321 Return EMACS_INT, not int.
7322 (struct sound_device.write, vox_write, alsa_write):
7323 Accept EMACS_INT, not int.
7324 (wav_play, au_play): Use EMACS_INT to store sizes and to
7325 record read return values.
7327 2011-04-15 Ben Key <bkey76@gmail.com>
7329 * keyboard.c (Qundefined): Don't declare static since it is used
7331 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7332 static since they are used in nsfont.m.
7334 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7336 * process.c (Qprocessp): Don't declare static.
7337 * lisp.h (Qprocessp): Declare again.
7339 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7341 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7343 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7345 Improve C-level modularity by making more things 'static'.
7347 Don't publish debugger-only interfaces to other modules.
7348 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7349 (verify_bytepos, count_markers): Move decls to the only modules
7351 * region-cache.h (pp_cache): Likewise.
7352 * window.h (check_all_windows): Likewise.
7353 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7355 * sysdep.c (croak): Now static, if
7356 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7357 * syssignal.h (croak): Declare only if not static.
7359 * alloc.c (refill_memory_reserve): Now static if
7360 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7361 * lisp.h (refill_memory_reserve): Declare only if not static.
7363 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7364 Define only if USE_LUCID.
7366 * xrdb.c (x_customization_string, x_rm_string): Now static.
7368 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7369 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7371 * xdisp.c (draw_row_with_mouse_face): Now static.
7372 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7374 * window.h (check_all_windows): Mark externally visible.
7376 * window.c (window_deletion_count): Now static.
7378 * undo.c: Make symbols static if they're not exported.
7379 (last_undo_buffer, last_boundary_position, pending_boundary):
7382 * textprop.c (interval_insert_behind_hooks): Now static.
7383 (interval_insert_in_front_hooks): Likewise.
7385 * term.c: Make symbols static if they're not exported.
7386 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7387 (max_frame_lines, tty_set_terminal_modes):
7388 (tty_reset_terminal_modes, tty_turn_off_highlight):
7389 (get_tty_terminal): Now static.
7390 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7391 * termhooks.h (term_mouse_moveto): Do not declare if
7393 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7394 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7396 * sysdep.c: Make symbols static if they're not exported.
7397 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7399 (sigprocmask_set, full_mask): Remove; unused.
7400 (wait_debugging): Mark as visible.
7401 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7402 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7404 * syntax.c (syntax_temp): Define only if !__GNUC__.
7406 * sound.c (current_sound_device, current_sound): Now static.
7408 * search.c (searchbufs, searchbuf_head): Now static.
7410 * scroll.c (scroll_cost): Remove; unused.
7411 * dispextern.h (scroll_cost): Remove decl.
7413 * region-cache.h (pp_cache): Mark as externally visible.
7415 * process.c: Make symbols static if they're not exported.
7416 (process_tick, update_tick, create_process, chan_process):
7417 (Vprocess_alist, proc_buffered_char, datagram_access):
7418 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7419 (deactivate_process): Mark defn as static, as well as decl.
7420 * lisp.h (create_process): Remove decl.
7421 * process.h (chan_process, Vprocess_alist): Remove decls.
7423 * print.c: Make symbols static if they're not exported.
7424 (print_depth, new_backquote_output, being_printed, print_buffer):
7425 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7426 (print_interval, print_number_index, initial_stderr_stream):
7428 * lisp.h (Fprinc): Remove decl.
7429 (debug_output_compilation_hack): Mark as externally visible.
7431 * sysdep.c (croak): Move decl from here to syssignal.h.
7432 * syssignal.h (croak): Put it here, so the API can be checked when
7433 'croak' is called from dissociate_if_controlling_tty.
7435 * minibuf.c: Make symbols static if they're not exported.
7436 (minibuf_save_list, choose_minibuf_frame): Now static.
7437 * lisp.h (choose_minibuf_frame): Remove decl.
7439 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7441 * lread.c: Make symbols static if they're not exported.
7442 (read_objects, initial_obarray, oblookup_last_bucket_number):
7444 (make_symbol): Remove; unused.
7445 * lisp.h (initial_obarray, make_symbol): Remove decls.
7447 * keyboard.c: Make symbols static if they're not exported.
7448 (single_kboard, recent_keys_index, total_keys, recent_keys):
7449 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7450 (this_single_command_key_start, echoing, last_auto_save):
7451 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7452 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7453 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7454 (Vlispy_mouse_stem, double_click_count):
7456 (force_auto_save_soon): Define only if SIGDANGER.
7457 (ignore_mouse_drag_p): Now static if
7458 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7459 (print_help): Remove; unused.
7460 (stop_character, last_timer_event): Mark as externally visible.
7461 * keyboard.h (ignore_mouse_drag_p): Declare only if
7462 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7463 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7464 * lisp.h (echoing): Remove decl.
7465 (force_auto_save_soon): Declare only if SIGDANGER.
7466 * xdisp.c (redisplay_window): Simplify code, to make it more
7467 obvious that ignore_mouse_drag_p is not accessed if !defined
7468 USE_GTK && !defined HAVE_NS.
7470 * intervals.c: Make symbols static if they're not exported.
7471 (merge_properties_sticky, merge_interval_right, delete_interval):
7473 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7475 * insdel.c: Make symbols static if they're not exported.
7476 However, leave prepare_to_modify_buffer alone. It's never
7477 called from outside this function, but that appears to be a bug.
7478 (combine_after_change_list, combine_after_change_buffer):
7479 (adjust_after_replace, signal_before_change): Now static.
7480 (adjust_after_replace_noundo): Remove; unused.
7481 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7482 (signal_before_change): Remove decls.
7484 * indent.c (val_compute_motion, val_vmotion): Now static.
7486 * image.c: Make symbols static if they're not exported.
7487 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7489 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7490 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7492 * fringe.c (standard_bitmaps): Now static.
7493 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7495 * frame.c: Make symbols static if they're not exported.
7496 (x_report_frame_params, make_terminal_frame): Now static.
7497 (get_frame_param): Now static, unless HAVE_NS.
7498 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7499 (x_get_resource_string): Remove; not used.
7500 * frame.h (make_terminal_frame, x_report_frame_params):
7501 (x_get_resource_string); Remove decls.
7502 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7503 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7505 * font.c, fontset.c: Make symbols static if they're not exported.
7506 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7507 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7508 * font.c (font_close_object): Now static.
7509 * font.h (font_close_object): Remove.
7510 * fontset.c (FONTSET_OBJLIST): Remove.
7511 (free_realized_fontset) #if-0 the body, which does nothing.
7512 (face_suitable_for_char_p): #if-0, as it's never called.
7513 * fontset.h (face_suitable_for_char_p): Remove decl.
7514 * xfaces.c (face_at_string_position):
7515 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7516 since 0 is always ASCII.
7518 * fns.c (weak_hash_tables): Now static.
7520 * fileio.c: Make symbols static if they're not exported.
7521 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7522 (Vwrite_region_annotation_buffers): Now static.
7524 * eval.c: Make symbols static if they're not exported.
7525 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7526 * lisp.h (backtrace_list): Remove decl.
7528 * emacs.c: Make symbols static if they're not exported.
7529 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7530 (fatal_error_code, fatal_error_signal_hook, standard_args):
7532 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7533 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7534 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7535 * lisp.h (fatal_error_signal_hook): Remove decl.
7536 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7538 * editfns.c: Move a (normally-unused) function to its only use.
7539 * editfns.c, lisp.h (get_operating_system_release): Remove.
7540 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7541 worth the hassle of breaking this out.
7543 * xterm.c: Make symbols static if they're not exported.
7544 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7545 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7546 (x_destroy_window, x_delete_display):
7548 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7549 (x_mouse_leave): Remove; unused.
7550 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7551 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7552 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7554 (x_mouse_leave): Declare only if WINDOWSNT.
7555 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7556 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7559 * ftxfont.c: Make symbols static if they're not exported.
7560 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7562 * font.h (ftxfont_driver): Likewise.
7564 * xfns.c: Make symbols static if they're not exported.
7565 (x_last_font_name, x_display_info_for_name):
7566 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7567 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7568 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7569 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7570 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7571 (last_show_tip_args): Now static.
7572 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7573 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7574 (x_screen_planes): Remove; unused.
7575 * dispextern.h (x_screen_planes): Remove decl.
7577 * dispnew.c: Make symbols static if they're not exported.
7578 * dispextern.h (redraw_garbaged_frames, scrolling):
7579 (increment_row_positions): Remove.
7580 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7581 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7583 (redraw_garbaged_frames): Remove; unused.
7585 * xfaces.c: Make symbols static if they're not exported.
7586 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7588 * xterm.h (defined_color): Remove decls.
7589 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7590 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7591 (menu_face_changed_default, defined_color, free_realized_face):
7592 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7593 (ascii_face_of_lisp_face): Remove; unused.
7595 * xdisp.c: Make symbols static if they're not exported.
7596 * dispextern.h (scratch_glyph_row, window_box_edges):
7597 (glyph_to_pixel_coords, set_cursor_from_row):
7598 (get_next_display_element, set_iterator_to_next):
7599 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7600 (show_mouse_face): Remove decls
7601 * frame.h (message_buf_print): Likewise.
7602 * lisp.h (pop_message, set_message, check_point_in_composition):
7604 * xterm.h (set_vertical_scroll_bar): Likewise.
7605 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7606 (message_buf_print, scratch_glyph_row, displayed_buffer):
7607 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7608 (get_next_display_element, show_mouse_face, window_box_edges):
7609 (frame_to_window_pixel_xy, check_point_in_composition):
7610 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7611 (glyph_to_pixel_coords): Remove; unused.
7613 * dired.c (file_name_completion): Now static.
7615 * dbusbind.c (xd_in_read_queued_messages): Now static.
7617 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7618 * data.c (circular_list_error): Remove.
7620 * commands.h (last_point_position, last_point_position_buffer):
7621 (last_point_position_window): Remove decls.
7622 * keyboard.c: Make these variables static.
7624 * coding.h (coding, code_convert_region, encode_coding_gap):
7626 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7627 (iso_code_class, detect_coding, code_convert_region): Now static.
7628 (encode_coding_gap): Remove; unused.
7630 * chartab.c (chartab_chars, chartab_bits): Now static.
7632 * charset.h (charset_iso_8859_1): Remove decl.
7633 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7636 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7637 * ccl.c (Vccl_program_table): Now static.
7638 (check_ccl_update): Remove; unused.
7640 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7641 * category.h: ... from here.
7642 * category.c (check_category_table, set_category_set): Now static.
7644 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7645 * lisp.h: Remove these decls.
7647 * buffer.c (buffer_count): Remove unused var.
7649 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7650 so that it's not optimized away.
7651 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7652 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7653 exported only to the debugger.
7655 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7656 * atimer.h (run_all_atimers): Remove; not exported.
7658 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7659 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7660 was inaccessible from Lisp.
7661 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7662 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7664 alloc.c: Import and export fewer symbols, and remove unused items.
7665 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7667 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7668 it's not optimized away by whole-program optimization.
7669 (message_enable_multibyte, free_misc): Remove.
7670 (catchlist, handlerlist, mark_backtrace):
7671 Declare only if BYTE_MARK_STACK.
7672 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7673 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7674 (message_enable_multibyte): Remove decl.
7675 (free_misc, interval_free_list, float_block, float_block_index):
7676 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7677 (cons_free_list, last_marked_index):
7679 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7680 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7681 (mark_backtrace): Define only if BYTE_MARK_STACK.
7682 * xdisp.c (message_enable_multibyte): Now static.
7684 Declare Lisp_Object Q* variables to be 'static' if not exported.
7685 This makes it easier for human readers (and static analyzers)
7686 to see whether these variables are used from other modules.
7687 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7688 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7689 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7690 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7691 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7692 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7693 * xmenu.c, xselect.c:
7694 Declare Q* vars static if they are not used in other modules.
7695 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7696 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7697 Remove decls of unexported vars.
7698 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7700 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7702 Make Emacs functions such as Fatom 'static' by default.
7703 This makes it easier for human readers (and static analyzers)
7704 to see whether these functions can be called from other modules.
7705 DEFUN now defines a static function. To make the function external
7706 so that it can be used in other C modules, use the new macro DEFUE.
7707 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7708 (Finit_image_library):
7709 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7710 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7711 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7712 Remove decls, since these functions are now static.
7713 (Funintern, Fget_internal_run_time): New decls, since these functions
7714 were already external.
7716 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7717 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7718 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7719 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7720 * keyboard.c, keymap.c, lread.c:
7721 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7722 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7723 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7724 Mark functions with DEFUE instead of DEFUN,
7725 if they are used in other modules.
7726 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7727 decls for now-static functions.
7728 * buffer.h (Fdelete_overlay): Remove decl.
7729 * callproc.c (Fgetenv_internal): Mark as internal.
7730 * composite.c (Fremove_list_of_text_properties): Remove decl.
7731 (Fcomposition_get_gstring): New forward static decl.
7732 * composite.h (Fcomposite_get_gstring): Remove decl.
7733 * dired.c (Ffile_attributes): New forward static decl.
7734 * doc.c (Fdocumntation_property): New forward static decl.
7735 * eval.c (Ffetch_bytecode): New forward static decl.
7736 (Funintern): Remove extern decl; now in .h file where it belongs.
7737 * fileio.c (Fmake_symbolic_link): New forward static decl.
7738 * image.c (Finit_image_library): New forward static decl.
7739 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7740 * intervals.h (Fprevious_property_change):
7741 (Fremove_list_of_text_properties): Remove decls.
7742 * keyboard.c (Fthis_command_keys): Remove decl.
7743 (Fcommand_execute): New forward static decl.
7744 * keymap.c (Flookup_key): New forward static decl.
7745 (Fcopy_keymap): Now static.
7746 * keymap.h (Flookup_key): Remove decl.
7747 * process.c (Fget_process): New forward static decl.
7748 (Fprocess_datagram_address): Mark as internal.
7749 * syntax.c (Fsyntax_table_p): New forward static decl.
7750 (skip_chars): Remove duplicate decl.
7751 * textprop.c (Fprevious_property_change): New forward static decl.
7752 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7754 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7755 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7757 * editfns.c (Fformat): Remove unreachable code.
7759 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7761 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7764 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7766 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7767 when at ZV. (Bug#8487)
7769 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7771 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7773 * keyboard.c (parse_tool_bar_item): Likewise.
7774 * sound.c (sound_cleanup, alsa_close): Likewise.
7775 * termcap.c (tgetent): Likewise.
7776 * xfns.c (x_default_font_parameter): Likewise.
7777 * xsettings.c (read_and_apply_settings): Likewise.
7779 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7780 (overrun_check_free): Protoize.
7782 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7784 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7785 since callers should never pass a negative size.
7786 Change the signature to match that of plain 'read' and 'write'; see
7787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7788 * lisp.h: Update prototypes of emacs_write and emacs_read.
7790 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7792 * xdisp.c (redisplay_window): Don't try to determine the character
7793 position of the scroll margin if the window start point w->startp
7794 is outside the buffer's accessible region. (Bug#8468)
7796 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7798 Fix write-region and its subroutines for buffers > 2GB.
7799 * fileio.c (a_write, e_write): Modify declaration of arguments and
7800 local variables to support buffers larger than 2GB.
7801 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7803 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7804 argument, local variables, and return value.
7806 * lisp.h: Update prototypes of emacs_write and emacs_read.
7808 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7810 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7812 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7814 Fix more problems found by GCC 4.6.0's static checks.
7816 * xdisp.c (vmessage): Use a better test for character truncation.
7818 * charset.c (load_charset_map): <, not <=, for optimization,
7819 and to avoid potential problems with integer overflow.
7820 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7821 * casetab.c (set_identity, shuffle): Likewise.
7822 * editfns.c (Fformat): Likewise.
7823 * syntax.c (skip_chars): Likewise.
7825 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7826 This also lets GCC 4.6.0 generate slightly better loop code.
7828 * callint.c (Fcall_interactively): <, not <=, for optimization.
7829 (Fcall_interactively): Count the number of arguments produced,
7830 not the number of arguments given. This is simpler and lets GCC
7831 4.6.0 generate slightly better code.
7833 * ftfont.c: Distingish more carefully between FcChar8 and char.
7834 The previous code passed unsigned char * to a functions like
7835 strlen and xstrcasecmp that expect char *, which does not
7836 conform to the C standard.
7837 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7838 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7839 char * when the C standard requires it.
7841 * keyboard.c (read_char): Remove unused var.
7843 * eval.c: Port to Windows vsnprintf (Bug#8435).
7845 (SIZE_MAX): Define if the headers do not.
7846 (verror): Do not give up if vsnprintf returns a negative count.
7847 Instead, grow the buffer. This ports to Windows vsnprintf, which
7848 does not conform to C99. Problem reported by Eli Zaretskii.
7849 Also, simplify the allocation scheme, by avoiding the need for
7850 calling realloc, and removing the ALLOCATED variable.
7852 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7854 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7855 But keep the doprint source code for now, as we might revamp it
7856 and use it again (Bug#8435).
7857 * lisp.h (doprnt): Remove.
7858 * Makefile.in (base_obj): Remove doprnt.o.
7859 * deps.mk (doprnt.o): Remove.
7861 error: Print 32- and 64-bit integers portably (Bug#8435).
7862 Without this change, on typical 64-bit hosts error ("...%d...", N)
7863 was used to print both 32- and 64-bit integers N, which relied on
7865 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7866 * lisp.h (error, verror): Mark as printf-like functions.
7867 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7868 Report overflow in size calculations when allocating printf buffer.
7869 Do not truncate output string at its first null byte.
7870 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7871 Truncate the output at a character boundary, since vsnprintf does not
7873 * charset.c (check_iso_charset_parameter): Convert internal
7874 character to string before calling 'error', since %c now has the
7876 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7877 overflow when computing char to be passed to 'error'. Do not
7878 pass Lisp_Object to 'error'; pass the integer instead.
7879 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7880 formatted with plain %d.
7882 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7884 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7886 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7888 * xterm.c (x_catch_errors): Remove duplicate declaration.
7890 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7892 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7894 2011-04-10 Jim Meyering <meyering@redhat.com>
7896 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7897 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7898 return ssize_t not "int", and use size_t as the buffer length.
7899 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7900 * gnutls.h: Update declarations.
7901 * process.c (read_process_output): Use ssize_t, to match.
7902 (send_process): Likewise.
7904 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7906 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7908 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7910 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7911 Use unsigned char, to match FcChar8 type definition.
7913 * xterm.c (handle_one_xevent):
7914 * xmenu.c (create_and_show_popup_menu):
7915 * xselect.c (x_decline_selection_request)
7916 (x_reply_selection_request): Avoid type-punned deref of X events.
7918 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7920 Fix some uses of `int' instead of EMACS_INT.
7921 * search.c (string_match_1, fast_string_match)
7922 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7923 (scan_buffer, find_next_newline_no_quit)
7924 (find_before_next_newline, search_command, Freplace_match)
7925 (Fmatch_data): Make some `int' variables be EMACS_INT.
7927 * xdisp.c (display_count_lines): 3rd argument and return value now
7928 EMACS_INT. All callers changed.
7929 (pint2hrstr): Last argument is now EMACS_INT.
7931 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7932 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7933 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7934 (decode_coding_utf_16, decode_coding_emacs_mule)
7935 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7936 (decode_coding_ccl, decode_coding_charset)
7937 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7938 (decode_coding_iso_2022, decode_coding_emacs_mule)
7939 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7940 <char_offset, last_offset>: Declare EMACS_INT.
7941 (encode_coding_utf_8, encode_coding_utf_16)
7942 (encode_coding_emacs_mule, encode_invocation_designation)
7943 (encode_designation_at_bol, encode_coding_iso_2022)
7944 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7945 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7947 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7948 (encode_invocation_designation): Last argument P_NCHARS is now
7950 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7951 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7953 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7956 * ccl.c (Fccl_execute_on_string): Declare some variables
7959 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7961 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7963 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7965 * process.c (Fformat_network_address): Doc fix.
7967 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7969 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7971 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7973 * keyboard.c (read_char): Call Lisp function help-form-show,
7974 instead of using internal_with_output_to_temp_buffer.
7975 (Qhelp_form_show): New var.
7976 (syms_of_keyboard): Use DEFSYM macro.
7978 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7980 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7982 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7984 * process.c (Flist_processes): Remove to Lisp.
7985 (list_processes_1): Delete.
7987 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7989 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7991 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7993 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7995 Fix more problems found by GCC 4.6.0's static checks.
7997 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7999 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8001 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8003 * xdisp.c (vmessage): Mark as a printf-like function.
8005 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8007 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8009 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8010 printf-like functions.
8011 (tiff_load): Add casts to remove these marks before passing them
8012 to system-supplied API.
8014 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8016 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8017 This avoids several warnings with gcc -Wstrict-overflow.
8018 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8019 directly, rather than having caller test rule sign. This avoids
8020 some unnecessary tests.
8021 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8022 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8023 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8025 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8026 (xfont_open): Avoid unnecessary tests.
8028 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8030 * composite.h, composite.c (composition_gstring_put_cache):
8031 Use EMACS_INT, not int, for length.
8033 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8034 breaking out part of COMPOSITION_DECODE_RULE.
8035 (COMPOSITION_DECODE_RULE): Use it.
8036 * composite.c (get_composition_id): Remove unused local vars,
8037 by using the new macro.
8039 * textprop.c (set_text_properties_1): Change while to do-while,
8040 since the condition is always true at first.
8042 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8043 (interval_deletion_adjustment): Return unsigned value.
8046 * process.c (list_processes_1, create_pty, read_process_output):
8047 (exec_sentinel): Remove vars that were set but not used.
8048 (create_pty): Remove unnecessary "volatile"s.
8049 (Fnetwork_interface_info): Avoid possibility of int overflow.
8050 (read_process_output): Do adaptive read buffering even if carryover.
8051 (read_process_output): Simplify nbytes computation if buffered.
8053 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8055 * syntax.c (scan_words): Remove var that was set but not used.
8056 (update_syntax_table): Use unsigned instead of int.
8058 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8059 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8060 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8062 * print.c (print_error_message): Avoid int overflow.
8064 * font.c (font_list_entities): Redo for clarity,
8065 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8067 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8068 (font_score): Avoid potential overflow in diff calculation.
8070 * fns.c (substring_both): Remove var that is set but not used.
8071 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8073 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8075 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8076 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8077 can always succeed if overflow has undefined behavior.
8079 * search.c (boyer_moore, wordify): Remove vars set but not used.
8080 (wordify): Omit three unnecessary tests.
8082 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8083 All callers changed. This avoids the need for an unused var.
8085 * casefiddle.c (casify_region): Remove var that is set but not used.
8087 * dired.c (file_name_completion): Remove var that is set but not used.
8089 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8091 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8092 (Finsert_file_contents): Remove unnecessary code checking fd.
8094 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8095 Check for integer overflow on size calculations.
8097 * buffer.c (Fprevious_overlay_change): Remove var that is set
8100 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8101 Remove vars that are set but not used.
8102 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8103 (timer_check_2): Mark vars as initialized.
8105 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8107 * image.c (lookup_image): Remove var that is set but not used.
8108 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8110 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8111 that are set but not used.
8113 * xfns.c (make_invisible_cursor): Don't return garbage
8114 if XCreateBitmapFromData fails (Bug#8410).
8116 * xselect.c (x_get_local_selection, x_handle_property_notify):
8117 Remove vars that are set but not used.
8119 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8120 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8122 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8123 Remove var that is set but not used.
8124 (scroll_bar_windows_size): Now size_t, not int.
8125 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8128 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8129 (map_tty_color) [!defined MSDOS]: Likewise.
8131 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8133 * coding.c: Remove vars that are set but not used.
8134 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8135 All callers changed.
8136 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8137 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8138 (decode_coding_charset): Remove vars that are set but not used.
8140 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8141 that is set but not used.
8143 * print.c (print_object): Remove var that is set but not used.
8145 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8146 The gnulib version avoids calling malloc in the usual case,
8147 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8148 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8149 * filelock.c (current_lock_owner): Likewise.
8150 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8151 * sysdep.c: Include allocator.h, careadlinkat.h.
8152 (emacs_no_realloc_allocator): New static constant.
8153 (emacs_readlink): New function.
8154 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8155 ../lib/careadlinkat.h.
8157 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8159 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8160 first non-nil return value).
8162 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8164 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8165 if not defined (Bug#8403).
8167 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8169 * xdisp.c (display_count_lines): Remove parameter `start',
8170 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8171 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8172 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8173 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8174 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8175 and thereabouts. All callers changed.
8176 (get_per_char_metric): Remove parameter `f', unused since
8177 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8179 2011-04-02 Jim Meyering <meyering@redhat.com>
8181 do not dereference NULL upon failed strdup
8182 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8183 (ns_get_family): Likewise.
8185 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8187 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8189 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8191 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8194 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8196 Add lexical binding.
8198 * window.c (Ftemp_output_buffer_show): New fun.
8199 (Fsave_window_excursion):
8200 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8202 * lread.c (lisp_file_lexically_bound_p): New function.
8203 (Fload): Bind Qlexical_binding.
8204 (readevalloop): Remove `evalfun' arg.
8205 Bind Qinternal_interpreter_environment.
8206 (Feval_buffer): Bind Qlexical_binding.
8207 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8209 (syms_of_lread): Declare `lexical-binding'.
8211 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8213 * keyboard.c (eval_dyn): New fun.
8214 (menu_item_eval_property): Use it.
8216 * image.c (parse_image_spec): Use Ffunctionp.
8218 * fns.c (concat, mapcar1): Accept byte-code-functions.
8220 * eval.c (Fsetq): Handle lexical vars.
8221 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8222 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8223 (FletX, Flet): Obey lexical binding.
8224 (Fcommandp): Handle closures.
8225 (Feval): New `lexical' arg.
8226 (eval_sub): New function extracted from Feval. Use it almost
8227 everywhere where Feval was used. Look up vars in lexical env.
8229 (Ffunctionp): Move from subr.el.
8230 (Ffuncall): Handle closures.
8231 (apply_lambda): Remove `eval_flags'.
8232 (funcall_lambda): Handle closures and new byte-code-functions.
8233 (Fspecial_variable_p): New function.
8234 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8235 but without exporting it to Lisp.
8237 * doc.c (Fdocumentation, store_function_docstring):
8238 * data.c (Finteractive_form): Handle closures.
8240 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8243 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8245 (exec_byte_code): New function extracted from Fbyte_code to handle new
8246 calling convention for byte-code-functions. Add new byte-codes.
8248 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8250 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8252 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8254 * xdisp.c (redisplay_internal): Fix prototype.
8256 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8258 * xdisp.c (SCROLL_LIMIT): New macro.
8259 (try_scrolling): Use it when setting scroll_limit.
8260 Limit scrolling to 100 screen lines.
8261 (redisplay_window): Even when falling back on "recentering",
8262 position point in the window according to scroll-conservatively,
8263 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8265 (try_scrolling): When point is above the window, allow searching
8266 as far as scroll_max, or one screenful, to compute vertical
8267 distance from PT to the scroll margin position. This prevents
8268 try_scrolling from unnecessarily failing when
8269 scroll-conservatively is set to a value slightly larger than the
8270 window height. Clean up the case of PT below the margin at bottom
8271 of window: scroll_max can no longer be INT_MAX. When aggressive
8272 scrolling is in use, don't let point enter the opposite scroll
8273 margin as result of the scroll.
8274 (syms_of_xdisp) <scroll-conservatively>: Document the
8275 threshold of 100 lines for never-recentering scrolling.
8277 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8279 * dispextern.h (move_it_by_lines):
8280 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8281 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8282 (message_log_check_duplicate): Remove parameters `prev_bol' and
8283 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8284 (redisplay_internal): Remove parameter `preserve_echo_area',
8285 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8287 * indent.c (Fvertical_motion):
8288 * window.c (window_scroll_pixel_based, Frecenter):
8289 Don't pass `need_y_p' to `move_it_by_lines'.
8291 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8293 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8294 steal a few bits to be more compact.
8295 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8296 Remove unneeded casts.
8298 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8300 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8302 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8303 binding" message (bug#7967).
8305 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8307 Fix more problems found by GCC 4.6.0's static checks.
8309 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8310 Remove unused local var.
8312 * editfns.c (Fmessage_box): Remove unused local var.
8314 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8315 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8316 Omit unused local vars.
8317 * window.c (shrink_windows): Omit unused local var.
8318 * menu.c (digest_single_submenu): Omit unused local var.
8319 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8320 Omit unused local var.
8322 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8323 Don't assume string length fits in int.
8324 (keyremap_step, read_key_sequence): Use size_t for sizes.
8325 (read_key_sequence): Don't check last_real_key_start redundantly.
8327 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8328 instead of alloca (Bug#8344).
8330 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8331 (Fbacktrace_frame): Don't assume nframes fits in int.
8333 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8335 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8338 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8340 * cm.c (calccost): Turn while-do into do-while, for clarity.
8342 * keyboard.c (syms_of_keyboard): Use the same style as later
8343 in this function when indexing through an array. This also
8344 works around GCC bug 48267.
8346 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8348 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8350 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8351 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8353 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8354 This avoids undefined behavior on integer overflow, and is a bit
8355 more convenient anyway since it is compared to a size_t variable.
8357 Variadic C functions now count arguments with size_t, not int.
8358 This avoids an unnecessary limitation on 64-bit machines, which
8359 caused (substring ...) to crash on large vectors (Bug#8344).
8360 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8361 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8362 All variadic functions and their callers changed accordingly.
8363 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8364 * data.c (arith_driver, float_arith_driver): Likewise.
8365 * editfns.c (general_insert_function): Likewise.
8366 * eval.c (struct backtrace.nargs, interactive_p)
8367 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8368 (funcall_lambda, mark_backtrace): Likewise.
8369 * fns.c (concat): Likewise.
8370 * frame.c (x_set_frame_parameters): Likewise.
8371 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8372 0 if not found, not -1. All callers changed.
8374 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8375 (stack_copy_size): Now size_t, not int.
8376 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8378 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8380 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8381 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8382 All callers changed.
8384 * lisp.h (multibyte_char_to_unibyte):
8385 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8386 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8387 * character.h (CHAR_TO_BYTE8):
8388 * cmds.c (internal_self_insert):
8389 * editfns.c (general_insert_function):
8390 * keymap.c (push_key_description):
8391 * search.c (Freplace_match):
8392 * xdisp.c (message_dolog, set_message_1): All callers changed.
8394 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8396 * keyboard.c (safe_run_hook_funcall): New function.
8397 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8398 don't set the hook to nil, but remove the offending function instead.
8399 (Qcommand_hook_internal): Remove, unused.
8400 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8401 Vcommand_hook_internal.
8403 * eval.c (enum run_hooks_condition): Remove.
8404 (funcall_nil, funcall_not): New functions.
8405 (run_hook_with_args): Call each function through a `funcall' argument.
8406 Remove `cond' argument, now redundant.
8407 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8408 (Frun_hook_with_args_until_failure): Adjust accordingly.
8409 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8411 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8413 * dispextern.h (string_buffer_position): Remove declaration.
8415 * print.c (strout): Remove parameter `multibyte', unused since
8416 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8418 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8419 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8420 All callers changed.
8422 * w32.c (_wsa_errlist): Use braces for struct initializers.
8424 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8425 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8426 All callers changed.
8427 (string_buffer_position): Likewise. Also, make static (it's never
8428 used outside xdisp.c).
8429 (cursor_row_p): Remove parameter `w', unused since
8430 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8431 (decode_mode_spec): Remove parameter `precision', introduced during
8432 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8433 All callers changed.
8435 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8437 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8439 2011-03-27 Anders Lindgren <andlind@gmail.com>
8441 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8442 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8443 (ns_update_auto_hide_menu_bar): New functions.
8444 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8445 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8446 ns_constrain_all_frames.
8447 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8448 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8450 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8452 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8454 2011-03-27 Glenn Morris <rgm@gnu.org>
8456 * syssignal.h: Replace RETSIGTYPE with void.
8457 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8458 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8459 Replace SIGTYPE with void everywhere.
8460 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8461 * s/template.h (SIGTYPE): Remove commented out definition.
8463 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8465 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8466 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8468 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8470 * w32.c (read_unc_volume): Use parameter `henum', instead of
8471 global variable `wget_enum_handle'.
8473 * keymap.c (describe_vector): Remove parameters `indices' and
8474 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8475 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8477 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8479 * keyboard.c (timer_check): Remove parameter `do_it_now',
8480 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8481 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8482 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8484 * keyboard.c (read_char):
8485 * w32menu.c (w32_menu_display_help):
8486 * xmenu.c (show_help_event, menu_help_callback):
8487 Adjust calls to `show_help_echo'.
8489 * gtkutil.c (xg_maybe_add_timer):
8490 * keyboard.c (readable_events):
8491 * process.c (wait_reading_process_output):
8492 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8494 * insdel.c (adjust_markers_gap_motion):
8495 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8496 (gap_left, gap_right): Don't call it.
8498 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8500 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8501 incurred during fontification.
8503 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8505 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8506 (DEFVAR_PER_BUFFER): Don't pass it.
8508 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8509 (scrolling_window): Don't pass it.
8511 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8513 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8515 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8517 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8518 of variables specific to SELinux and computation of `encoded_absname'.
8520 * image.c (XPutPixel): Remove unused variable `height'.
8522 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8524 * unexw32.c (get_section_info): Remove unused variable `section'.
8526 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8527 (system_process_attributes): Remove unused variable `sess'.
8528 (sys_read): Remove unused variable `err'.
8530 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8531 (w32_wnd_proc): Remove unused variable `isdead'.
8532 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8533 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8534 (x_create_tip_frame): Remove unused variable `tem'.
8536 * w32inevt.c (w32_console_read_socket):
8537 Remove unused variable `no_events'.
8539 * w32term.c (x_draw_composite_glyph_string_foreground):
8540 Remove unused variable `width'.
8542 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8544 * w32term.c (x_set_glyph_string_clipping):
8545 Don't pass uninitialized region to CombineRgn.
8547 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8549 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8550 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8551 (Fx_close_connection): Remove unused variable `i'.
8553 * w32font.c (w32font_draw): Return number of glyphs.
8554 (w32font_open_internal): Remove unused variable `i'.
8555 (w32font_driver): Add missing initializer.
8557 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8558 (fill_in_menu): Remove unused variable `items_added'.
8560 * w32term.c (last_mouse_press_frame): Remove static global variable.
8561 (w32_clip_to_row): Remove unused variable `f'.
8562 (x_delete_terminal): Remove unused variable `i'.
8564 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8565 (NOTHING): Remove unused static global variable.
8566 (uniscribe_check_otf): Remove unused variable `table'.
8567 (uniscribe_font_driver): Add missing initializers.
8569 2011-03-23 Julien Danjou <julien@danjou.info>
8571 * term.c (Fsuspend_tty, Fresume_tty):
8572 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8573 * window.c (temp_output_buffer_show):
8574 * insdel.c (signal_before_change):
8575 * frame.c (Fhandle_switch_frame):
8576 * fileio.c (Fdo_auto_save):
8577 * emacs.c (Fkill_emacs):
8578 * editfns.c (save_excursion_restore):
8579 * cmds.c (internal_self_insert):
8580 * callint.c (Fcall_interactively):
8581 * buffer.c (Fkill_all_local_variables):
8582 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8584 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8585 unconditionally since it does the check itself.
8587 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8589 Fix more problems found by GCC 4.5.2's static checks.
8591 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8592 the first time through the loop, since we know p0 < p1 then.
8593 This also avoids a gcc -Wstrict-overflow warning.
8595 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8596 leading to a memory leak, possible in functions like
8597 load_charset_map_from_file that can allocate an unbounded number
8598 of objects (Bug#8318).
8600 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8601 that could (at least in theory) be that large.
8603 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8604 This is less likely to overflow, and avoids undefined behavior if
8605 overflow does occur. All callers changed. Use strtoul to scan
8606 for the unsigned long integer.
8607 (pint2hrstr): Simplify and tune code slightly.
8608 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8610 * scroll.c (do_scrolling): Work around GCC bug 48228.
8611 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8613 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8614 This also avoids a warning with gcc -Wstrict-overflow.
8615 (validate_x_resource_name): Simplify count usage.
8616 This also avoids a warning with gcc -Wstrict-overflow.
8618 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8621 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8623 * process.c (Fmake_network_process): Use socklen_t, not int,
8624 where POSIX says socklen_t is required in portable programs.
8625 This fixes a porting bug on hosts like 64-bit HP-UX, where
8626 socklen_t is wider than int (Bug#8277).
8627 (Fmake_network_process, server_accept_connection):
8628 (wait_reading_process_output, read_process_output):
8631 * process.c: Rename or move locals to avoid shadowing.
8632 (list_processes_1, Fmake_network_process):
8633 (read_process_output_error_handler, exec_sentinel_error_handler):
8634 Rename or move locals.
8635 (Fmake_network_process): Define label "retry_connect" only if needed.
8636 (Fnetwork_interface_info): Fix pointer signedness.
8637 (process_send_signal): Add cast to avoid pointer signedness problem.
8638 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8639 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8641 Make tparam.h and terminfo.c consistent.
8642 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8643 Include tparam.h instead, since it declares them.
8644 * cm.h (PC): Remove extern decl; tparam.h now does this.
8645 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8646 * terminfo.c: Include tparam.h, to check interfaces.
8647 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8648 (tparam): Adjust signature to match interface in tparam.h;
8649 this removes some undefined behavior. Check that outstring and len
8650 are zero, which they always are with Emacs.
8651 * tparam.h (PC, BC, UP): New extern decls.
8653 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8654 (xftfont_open): Rename locals to avoid shadowing.
8656 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8657 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8658 (OTF_TAG_SYM): Omit macro if not needed.
8659 (ftfont_list): Remove unused local.
8660 (get_adstyle_property, ftfont_pattern_entity):
8661 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8662 Rename locals to avoid shadowing.
8664 * xfont.c (xfont_list_family): Mark var as initialized.
8666 * xml.c (make_dom): Now static.
8668 * composite.c (composition_compute_stop_pos): Rename local to
8670 (composition_reseat_it): Remove unused locals.
8671 (find_automatic_composition, composition_adjust_point): Likewise.
8672 (composition_update_it): Mark var as initialized.
8673 (find_automatic_composition): Mark vars as initialized,
8674 with a FIXME (Bug#8290).
8676 character.h: Rename locals to avoid shadowing.
8677 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8678 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8679 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8680 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8683 * textprop.c (property_change_between_p): Remove; unused.
8685 * intervals.c (interval_start_pos): Now static.
8687 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8689 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8690 Rename locals to avoid shadowing.
8692 * sound.c (wav_play, au_play, Fplay_sound_internal):
8693 Fix pointer signedness.
8694 (alsa_choose_format): Remove unused local var.
8695 (wav_play): Initialize a variable to 0, to prevent undefined
8696 behavior (Bug#8278).
8698 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8700 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8702 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8703 clobbering (Bug#8298).
8704 * sysdep.c (sys_subshell): Likewise.
8705 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8707 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8708 This should get cleaned up, so that child_setup has the
8709 same signature on all platforms.
8711 * callproc.c (call_process_cleanup): Now static.
8712 (relocate_fd): Rename locals to avoid shadowing.
8714 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8716 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8717 not to be necessary, and produces flickering.
8719 2011-03-20 Glenn Morris <rgm@gnu.org>
8721 * config.in: Remove file.
8723 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8725 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8726 are now in src/globals.h.
8727 (syms_of_minibuf): Remove spurious & from previous change.
8729 2011-03-20 Leo Liu <sdl.web@gmail.com>
8731 * minibuf.c (completing-read-function): New variable.
8732 (completing-read-default): Rename from completing-read.
8733 (completing-read): Call completing-read-function.
8735 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8737 * xfaces.c (Fx_load_color_file):
8738 Read color file from absolute filename (bug#8250).
8740 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8742 * makefile.w32-in: Update dependencies.
8744 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8746 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8748 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8750 Fix more problems found by GCC 4.5.2's static checks.
8752 * process.c (make_serial_process_unwind, send_process_trap):
8753 (sigchld_handler): Now static.
8755 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8756 That way, the code declares only the vars that it needs.
8757 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8758 * s/cygwin.h (PTY_ITERATION): Likewise.
8759 * s/darwin.h (PTY_ITERATION): Likewise.
8760 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8762 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8763 * process.c (allocate_pty): Don't declare stb unless it's needed.
8765 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8766 (CONSTANTLIM): Remove; unused.
8767 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8768 Define only if needed.
8770 * unexelf.c (unexec): Name an expression,
8771 to avoid gcc -Wbad-function-cast warning.
8772 Use a different way to cause a compilation error if anyone uses
8773 n rather than nn, a way that does not involve shadowing.
8774 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8776 * deps.mk (unexalpha.o): Remove; unused.
8778 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8779 * unexec.h: New file.
8780 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8781 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8783 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8784 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8785 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8786 Change as necessary to match prototype in unexec.h.
8788 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8790 (back_comment, skip_chars): Mark vars as initialized.
8792 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8793 Rename locals to avoid shadowing.
8795 * lread.c (read1): Rewrite so as not to use empty "else".
8796 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8798 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8800 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8801 warning when compiling print.c.
8803 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8804 instead of using an uninitialized var.
8805 (font_sort_entities): Mark var as initialized.
8807 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8809 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8810 pointers to constants.
8811 (font_parse_fcname): Remove unused vars.
8812 (font_delete_unmatched): Now static.
8813 (font_get_spec): Remove; unused.
8814 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8815 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8816 Rename or move locals to avoid shadowing.
8818 * fns.c (require_nesting_list, require_unwind): Now static.
8819 (Ffillarray): Rename locals to avoid shadowing.
8821 * floatfns.c (domain_error2): Define only if needed.
8822 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8824 * alloc.c (mark_backtrace): Move decl from here ...
8825 * lisp.h: ... to here, so that it can be checked.
8827 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8828 (Fdefvar): Rewrite so as not to use empty "else".
8829 (lisp_indirect_variable): Name an expression,
8830 to avoid gcc -Wbad-function-cast warning.
8831 (Fdefvar): Rename locals to avoid shadowing.
8833 * callint.c (quotify_arg, quotify_args): Now static.
8834 (Fcall_interactively): Rename locals to avoid shadowing.
8835 Use const pointer when appropriate.
8837 * lisp.h (get_system_name, get_operating_system_release):
8838 Move decls here, to check interfaces.
8839 * process.c (get_operating_system_release): Move decl to lisp.h.
8840 * xrdb.c (get_system_name): Likewise.
8841 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8842 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8843 some of which prompt warnings from gcc -Wbad-function-cast.
8844 (Fformat_time_string, Fencode_time, Finsert_char):
8845 (Ftranslate_region_internal, Fformat):
8846 Rename or remove local vars to avoid shadowing.
8847 (Ftranslate_region_internal): Mark var as initialized.
8849 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8852 * lisp.h (eassert): Check that the argument compiles, even if
8853 ENABLE_CHECKING is not defined.
8855 * data.c (Findirect_variable): Name an expression, to avoid
8856 gcc -Wbad-function-cast warning.
8857 (default_value, arithcompare, arith_driver, arith_error): Now static.
8858 (store_symval_forwarding): Rename local to avoid shadowing.
8859 (Fmake_variable_buffer_local, Fmake_local_variable):
8860 Mark variables as initialized.
8861 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8863 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8864 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8865 Rename locals to avoid shadowing.
8866 (mark_stack): Move local variables into the #ifdef region where
8868 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8869 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8871 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8872 (GC_STRING_CHARS): Remove; not used.
8873 (Fmemory_limit): Cast sbrk's returned value to char *.
8875 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8876 avoids undefined behavior in theory.
8878 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8880 Use functions, not macros, for up- and down-casing (Bug#8254).
8881 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8882 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8883 to use the following functions instead of these macros.
8884 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8885 EMACS_INT, since callers assume the returned value fits in int.
8886 (upcase1): Likewise, for UPCASE_TABLE.
8887 (uppercasep, lowercasep, upcase): New static inline functions.
8888 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8889 the race-condition problem in the old DOWNCASE.
8891 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8892 Rename locals to avoid shadowing.
8893 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8894 (regex_compile, re_search_2, re_match_2_internal):
8895 Remove unused local vars.
8896 (FREE_VAR): Rewrite so as not to use empty "else",
8897 which gcc can warn about.
8898 (regex_compile, re_match_2_internal): Mark locals as initialized.
8899 (RETALLOC_IF): Define only if needed.
8900 (WORDCHAR_P): Likewise. This one is never needed, but is used
8901 only in a comment talking about a compiler bug, so put inside
8902 the #if 0 of that comment.
8903 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8904 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8907 * search.c (boyer_moore): Rename locals to avoid shadowing.
8908 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8909 (PREV_CHAR_BOUNDARY): Likewise.
8911 * search.c (simple_search): Remove unused var.
8913 * dired.c (compile_pattern): Move decl from here ...
8914 * lisp.h: ... to here, so that it can be checked.
8915 (struct re_registers): New forward decl.
8917 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8919 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8921 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8922 Rename locals to avoid shadowing.
8923 (Fvertical_motion): Mark locals as initialized.
8925 * casefiddle.c (casify_object, casify_region): Now static.
8926 (casify_region): Mark local as initialized.
8928 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8930 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8931 New macros, so that the caller can use some names other than
8932 gcpro1, gcpro2, etc.
8933 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8935 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8936 argument, for consistency with GCPRO2_VAR, etc: it is now the
8937 prefix of the variable, not the variable itself. All uses
8939 * dired.c (directory_files_internal, file_name_completion):
8940 Rename locals to avoid shadowing.
8942 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8943 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8944 dired.c's scmp function, had undefined behavior.
8945 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8946 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8947 * buffer.h: ... to here, because these macros use current_buffer,
8948 and the new implementation with inline functions needs to have
8949 current_buffer in scope now, rather than later when the macros
8951 (downcase, upcase1): New static inline functions.
8952 (DOWNCASE, UPCASE1): Reimplement using these functions.
8953 This avoids undefined behavior in expressions like
8954 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8955 from race conditions in accessing the global variables
8956 case_temp1 and case_temp2.
8957 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8958 * lisp.h (case_temp1, case_temp2): Remove their decls.
8959 * character.h (ASCII_CHAR_P): Move from here ...
8960 * lisp.h: ... to here, so that the inline functions mentioned
8963 * dired.c (directory_files_internal_unwind): Now static.
8965 * fileio.c (file_name_as_directory, directory_file_name):
8966 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8968 (file_name_as_directory): Use const pointers when appropriate.
8969 (Fexpand_file_name): Likewise. In particular, newdir might
8970 point at constant storage, so make it a const pointer.
8971 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8972 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8974 (Fset_file_times, Finsert_file_contents, auto_save_error):
8975 Rename locals to avoid shadowing.
8977 * minibuf.c (choose_minibuf_frame_1): Now static.
8978 (Ftry_completion, Fall_completions): Rename or remove locals
8981 * marker.c (bytepos_to_charpos): Remove; unused.
8983 * lisp.h (verify_bytepos, count_markers): New decls,
8984 so that gcc does not warn that these functions aren't declared.
8986 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8987 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8988 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8989 (copy_text): Remove unused local var.
8991 * filelock.c (within_one_second): Now static.
8992 (lock_file_1): Rename local to avoid shadowing.
8994 * buffer.c (fix_overlays_before): Mark locals as initialized.
8995 (fix_start_end_in_overlays): Likewise. This function should be
8996 simplified by using pointers-to-pointers, but that's a different
8998 (switch_to_buffer_1): Now static.
8999 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9000 (report_overlay_modification): Rename locals to avoid shadowing.
9002 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9003 Fix pointer signedness issue.
9004 (sys_subshell): Mark local as volatile if checking for lint,
9005 to suppress a gcc -Wclobbered warning that does not seem to be right.
9006 (MAXPATHLEN): Define only if needed.
9008 * process.c (serial_open, serial_configure): Move decls from here ...
9009 * systty.h: ... to here, so that they can be checked.
9011 * fns.c (get_random, seed_random): Move extern decls from here ...
9012 * lisp.h: ... to here, so that they can be checked.
9014 * sysdep.c (reset_io): Now static.
9015 (wait_for_termination_signal): Remove; unused.
9017 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9018 (copy_keymap_item, append_key, push_text_char_description):
9020 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9021 (DENSE_TABLE_SIZE): Remove; unused.
9022 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9023 (describe_map_tree):
9024 Rename locals to avoid shadowing.
9026 * keyboard.c: Declare functions static if they are not used elsewhere.
9027 (echo_char, echo_dash, cmd_error, top_level_2):
9028 (poll_for_input, handle_async_input): Now static.
9029 (read_char, kbd_buffer_get_event, make_lispy_position):
9030 (make_lispy_event, make_lispy_movement, apply_modifiers):
9031 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9032 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9033 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9034 (read_key_sequence, read_char): Mark locals as initialized.
9035 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9037 * keyboard.h (make_ctrl_char): New decl.
9038 (mark_kboards): Move decl here ...
9039 * alloc.c (mark_kboards): ... from here.
9041 * lisp.h (force_auto_save_soon): New decl.
9043 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9044 (DEFINE_DUMMY_FUNCTION): New macro.
9045 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9047 (main): Add casts to avoid warnings
9048 if GCC considers string literals to be constants.
9050 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9052 * dbusbind.c: Pointer signedness fixes.
9053 (xd_signature, xd_append_arg, xd_initialize):
9054 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9055 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9056 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9057 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9059 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9060 if GCC considers string literals to be constants.
9061 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9063 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9065 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9066 (print_preprocess, print_object): New macro to fix last change.
9068 * print.c (print_preprocess): Don't forget font objects.
9070 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9072 * emacs.c (USAGE3): Doc fixes.
9074 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9076 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9079 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9081 * lisp.h (VWindow_system, Qfile_name_history):
9082 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9083 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9084 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9086 * w32select.c: Don't #include "keyboard.h".
9087 (run_protected): Add extern declaration for waiting_for_input.
9089 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9090 * w32console.c (detect_input_pending, read_input_pending)
9091 (encode_terminal_code):
9092 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9093 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9094 (w32_system_caret_y, Qfile_name_history):
9095 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9096 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9097 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9098 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9099 * w32proc.c (Qlocal, report_file_error):
9100 * w32term.c (Vwindow_system, updating_frame):
9101 * w32uniscribe.c (initialized, uniscribe_font_driver):
9102 Remove unneeded extern declarations.
9104 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9106 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9108 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9110 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9111 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9112 These macros can no longer be used for assignment.
9114 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9115 Assign struct members directly, instead of using BUF_BEGV etc.
9116 (record_buffer_markers, fetch_buffer_markers): New functions for
9117 recording and fetching special buffer markers.
9118 (set_buffer_internal_1, set_buffer_temp): Use them.
9120 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9122 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9124 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9125 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9127 * xdisp.c (hscroll_window_tree):
9128 (reconsider_clip_changes): Use PT instead of BUF_PT.
9130 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9132 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9133 $(EMACS_ROOT)/lib/intprops.h.
9135 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9137 Fix more problems found by GCC 4.5.2's static checks.
9139 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9140 to unsigned char * to avoid compiler diagnostic.
9141 (xg_free_frame_widgets): Make it clear that a local variable is
9142 needed only if USE_GTK_TOOLTIP.
9143 (gdk_window_get_screen): Make it clear that this macro is needed
9144 only if USE_GTK_TOOLTIP.
9145 (int_gtk_range_get_value): New function, which avoids a diagnostic
9146 from gcc -Wbad-function-cast.
9147 (xg_set_toolkit_scroll_bar_thumb): Use it.
9148 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9149 diagnostic from gcc -Wbad-function-cast.
9150 (get_utf8_string, xg_get_file_with_chooser):
9151 Rename locals to avoid shadowing.
9152 (create_dialog): Move locals to avoid shadowing.
9154 * xgselect.c (xg_select): Remove unused var.
9156 * image.c (four_corners_best): Mark locals as initialized.
9157 (gif_load): Initialize transparent_p to zero (Bug#8238).
9158 Mark another local as initialized.
9159 (my_png_error, my_error_exit): Mark with NO_RETURN.
9161 * image.c (clear_image_cache): Now static.
9162 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9163 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9164 (x_edge_detection): Remove unnecessary cast that
9165 gcc -Wbad-function-cast diagnoses.
9166 (gif_load): Fix pointer signedness.
9167 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9168 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9170 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9172 Improve quality of tests for time stamp overflow.
9173 For example, without this patch (encode-time 0 0 0 1 1
9174 1152921504606846976) returns the obviously-bogus value (-948597
9175 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9176 reports time overflow. See
9177 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9178 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9179 * editfns.c: Include limits.h and intprops.h.
9180 (TIME_T_MIN, TIME_T_MAX): New macros.
9181 (time_overflow): Move earlier, to before first use.
9182 (hi_time, lo_time): New functions, for an accurate test for
9184 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9185 (Fget_internal_run_time): Don't assume time_t fits in int.
9186 (make_time): Use list2 instead of Fcons twice.
9187 (Fdecode_time): More accurate test for out-of-range times.
9188 (check_tm_member): New function.
9189 (Fencode_time): Use it, to test for out-of-range times.
9190 (lisp_time_argument): Don't rely on undefined left-shift and
9191 right-shift behavior when checking for time stamp overflow.
9193 * editfns.c (time_overflow): New function, refactoring common code.
9194 (Fformat_time_string, Fdecode_time, Fencode_time):
9195 (Fcurrent_time_string): Use it.
9197 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9198 * dired.c (make_time): Move to ...
9199 * editfns.c (make_time): ... here.
9200 * systime.h: Note the move.
9202 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9204 * fringe.c (update_window_fringes): Remove unused variables.
9206 * unexmacosx.c (copy_data_segment): Also copy __got section.
9209 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9211 * termcap.c [MSDOS]: Include "msdos.h".
9212 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9213 Constify `char *' arguments and their references according to
9214 prototypes in tparam.h.
9216 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9218 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9219 Adapt all references accordingly.
9221 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9223 2011-03-11 Tom Tromey <tromey@redhat.com>
9225 * buffer.c (syms_of_buffer): Remove obsolete comment.
9227 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9229 * termhooks.h (encode_terminal_code): Declare prototype.
9231 * msdos.c (encode_terminal_code): Don't declare prototype.
9233 * term.c (encode_terminal_code): Now external again, used by
9234 w32console.c and msdos.c.
9236 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9237 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9239 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9241 Fix some minor problems found by GCC 4.5.2's static checks.
9243 * fringe.c (update_window_fringes): Mark locals as initialized
9245 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9247 * alloc.c (mark_fringe_data): Move decl from here ...
9248 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9249 to check its interface.
9250 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9252 * fontset.c (free_realized_fontset): Now static.
9253 (Fset_fontset_font): Rename local to avoid shadowing.
9254 (fontset_font): Mark local as initialized.
9255 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9257 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9259 * xselect.c (x_disown_buffer_selections): Remove; not used.
9260 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9261 (x_own_selection, Fx_disown_selection_internal): Rename locals
9263 (x_handle_dnd_message): Remove local to avoid shadowing.
9265 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9266 so that the caller can use some name other than gcpro1.
9267 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9268 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9269 (Fx_backspace_delete_keys_p):
9270 Use them to avoid shadowing, and rename vars to avoid shadowing.
9271 (x_decode_color, x_set_name, x_window): Now static.
9272 (Fx_create_frame): Add braces to silence GCC warning.
9273 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9274 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9275 Remove unused locals.
9276 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9277 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9278 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9281 * xterm.h (x_mouse_leave): New decl.
9283 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9284 Remove unused functions.
9285 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9286 (x_calc_absolute_position): Now static.
9287 (XTread_socket): Don't define label "out" unless it's used.
9288 Don't declare local "event" unless it's used.
9289 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9290 unless they are used.
9291 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9292 (x_fatal_error_signal): Remove; not used.
9293 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9294 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9295 (x_error_catcher, x_connection_closed, x_error_handler):
9296 (x_error_quitter, xembed_send_message, x_iconify_frame):
9297 (my_log_handler): Rename locals to avoid shadowing.
9298 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9299 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9301 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9302 Rename or move locals to avoid shadowing.
9303 (tty_defined_color, merge_face_heights): Now static.
9304 (free_realized_faces_for_fontset): Remove; not used.
9305 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9306 does not deduce is never used uninitialized.
9307 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9308 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9310 * terminal.c (store_terminal_param): Now static.
9312 * xmenu.c (menu_highlight_callback): Now static.
9313 (set_frame_menubar): Remove unused local.
9314 (xmenu_show): Rename parameter to avoid shadowing.
9315 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9316 since they might point to immutable storage.
9317 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9318 since it's unused otherwise.
9320 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9321 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9322 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9323 avoids a gcc -Wuninitialized diagnostic.
9324 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9325 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9326 does not deduce are never used uninitialized.
9328 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9330 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9331 * window.c (window_loop, size_window):
9332 (run_window_configuration_change_hook, enlarge_window): Likewise.
9334 * window.c (display_buffer): Now static.
9335 (size_window): Mark variables that gcc -Wuninitialized
9336 does not deduce are never used uninitialized.
9337 * window.h (check_all_windows): New decl, to forestall
9338 gcc -Wmissing-prototypes diagnostic.
9339 * dispextern.h (bidi_dump_cached_states): Likewise.
9341 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9343 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9345 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9346 and to avoid gcc -Wuninitialized warning.
9347 (load_charset_map): Mark variables that gcc -Wuninitialized
9348 does not deduce are never used uninitialized.
9349 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9351 * coding.c (coding_set_source, coding_set_destination):
9352 Use "else { /* comment */ }" rather than "else /* comment */;"
9353 for clarity, and to avoid gcc -Wempty-body warning.
9354 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9355 a block, when the outer 'i' will do.
9356 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9357 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9358 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9359 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9360 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9361 Rename locals to avoid shadowing.
9362 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9363 * coding.c (emacs_mule_char, encode_invocation_designation):
9364 Now static, since they're not used elsewhere.
9365 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9366 (decode_coding_object, encode_coding_object, detect_coding_system):
9367 (decode_coding_emacs_mule): Mark variables that gcc
9368 -Wuninitialized does not deduce are never used uninitialized.
9369 (detect_coding_iso_2022): Initialize a local variable that might
9370 be used uninitialized. Leave a FIXME because it's not clear that
9371 this initialization is needed. (Bug#8211)
9372 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9373 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9374 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9375 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9376 Remove unused macros.
9378 * category.c (hash_get_category_set): Remove unused local var.
9379 (copy_category_table): Now static, since it's not used elsewhere.
9380 * character.c (string_count_byte8): Likewise.
9382 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9383 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9385 * chartab.c (copy_sub_char_table): Now static, since it's not used
9387 (sub_char_table_ref_and_range, char_table_ref_and_range):
9388 Rename locals to avoid shadowing.
9389 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9391 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9392 (BIDI_BOB): Remove unused macro.
9394 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9395 deduce are never used uninitialized.
9396 * term.c (encode_terminal_code): Likewise.
9398 * term.c (encode_terminal_code): Now static. Remove unused local.
9400 * tparam.h: New file.
9401 * term.c, tparam.h: Include it.
9402 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9403 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9404 Move these decls to tparam.h, and make them agree with what
9405 is actually in tparam.c. The previous trick of using incompatible
9406 decls in different modules does not conform to the C standard.
9407 All callers of tparam changed to use tparam's actual API.
9408 * tparam.c (tparam1, tparam, tgoto):
9409 Use const pointers where appropriate.
9411 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9412 * cm.h (struct cm): Likewise.
9413 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9414 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9415 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9416 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9417 (turn_on_face, init_tty): Likewise.
9418 * termchar.h (struct tty_display_info): Likewise.
9420 * term.c (term_mouse_position): Rename local to avoid shadowing.
9422 * alloc.c (mark_ttys): Move decl from here ...
9423 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9425 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9427 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9429 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9431 * search.c (compile_pattern_1): Remove argument regp, unused since
9432 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9433 (compile_pattern): Don't pass it.
9435 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9437 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9438 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9440 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9442 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9444 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9445 gdk_window_get_screen, gdk_window_get_geometry,
9446 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9447 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9448 (xg_get_pixbuf_from_pixmap): New function.
9449 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9450 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9451 Call xg_get_pixbuf_from_pixmap instead of
9452 gdk_pixbuf_get_from_drawable.
9453 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9454 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9455 (xg_check_special_colors): Use GtkStyleContext and its functions
9457 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9458 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9459 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9460 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9461 Call gtk_widget_get_preferred_size.
9462 (xg_frame_resized): gdk_window_get_geometry only takes 5
9464 (xg_win_to_widget, xg_event_is_for_menubar):
9465 Call gdk_x11_window_lookup_for_display.
9466 (xg_set_widget_bg): New function.
9467 (delete_cb): New function.
9468 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9469 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9470 (xg_set_background_color): Call xg_set_widget_bg.
9471 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9472 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9473 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9474 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9476 (update_frame_tool_bar): Call gtk_widget_hide.
9477 (xg_initialize): Use GDK_KEY_g.
9479 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9481 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9483 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9484 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9485 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9487 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9489 * w32xfns.c (select_palette): Check success of RealizePalette against
9490 GDI_ERROR, not zero.
9492 See ChangeLog.11 for earlier changes.
9498 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9500 This file is part of GNU Emacs.
9502 GNU Emacs is free software: you can redistribute it and/or modify
9503 it under the terms of the GNU General Public License as published by
9504 the Free Software Foundation, either version 3 of the License, or
9505 (at your option) any later version.
9507 GNU Emacs is distributed in the hope that it will be useful,
9508 but WITHOUT ANY WARRANTY; without even the implied warranty of
9509 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9510 GNU General Public License for more details.
9512 You should have received a copy of the GNU General Public License
9513 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.