1 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3 * w32fns.c (Fx_window_property): Accept the same arguments as the
4 X Windows version. Doc fix.
5 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
7 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
8 Eli Zaretskii <eliz@gnu.org>
10 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
11 Windows-specific code from nt/config.nt moved here.
12 Obsolete settings removed.
14 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
16 * process.c: Avoid unnecessary calls to gettime.
17 (wait_reading_process_output): Don't get the time of day
18 when gobbling data immediately and not waiting, as there's no need
19 for it in that case. This removes a FIXME.
21 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
23 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
24 is defined (Bug#11768).
26 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
28 Fix marker debugging code.
29 * marker.c (byte_char_debug_check): Do not perform the check
30 if buffer is not multibyte.
31 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
32 byte_char_debug_check with correct arguments.
34 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
36 Compile marker debugging code only if ENABLE_CHECKING is defined.
37 * marker.c (byte_char_debug_check, count_markers): Use
38 only if ENABLE_CHECKING is defined.
39 (byte_debug_flag): Remove.
40 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
41 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
43 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
45 Avoid code repetition in marker-related functions.
46 * marker.c (attach_marker): New function.
47 (Fset_marker, set_marker_restricted, set_marker_both)
48 (set_marker_restricted_both): Use it.
49 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
50 Consistently rename charno to charpos.
51 (marker_position): Add eassert.
52 (marker_byte_position): Convert to eassert.
54 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
56 Simplify list operations in unchain_overlay and unchain_marker.
57 * buffer.c (unchain_overlay): Simplify. Add comment.
58 * marker.c (unchain_marker): Simplify. Fix comments.
60 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
62 Introduce fast path for the widely used marker operation.
63 * alloc.c (build_marker): New function.
64 * lisp.h (build_marker): New prototype.
65 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
66 * composite.c (autocmp_chars): Likewise.
67 * editfns.c (buildmark): Remove.
68 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
69 (save_restriction_save): Use build_marker.
70 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
71 * window.c (save_window_save): Likewise.
73 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
75 Do not use Fdelete_overlay in delete_all_overlays
76 to avoid redundant calls to unchain_overlay.
77 * buffer.c (drop_overlay): New function.
78 (delete_all_overlays, Fdelete_overlay): Use it.
79 * minibuf.c (get_minibuffer): Fix comment.
81 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
83 Port to OpenBSD 5.1 amd64.
84 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
85 This is needed for OpenBSD, and should be harmless on all BSD systems.
86 Also, include <sys/sysctl.h>, as it should be available on all
87 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
88 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
89 use p_pid member, not kp_proc.pid.
91 2012-07-06 Glenn Morris <rgm@gnu.org>
93 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
95 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
97 More xmalloc and related cleanup.
98 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
99 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
100 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
101 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
102 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
103 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
104 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
105 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
106 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
108 Omit needless casts involving void * pointers and allocation.
109 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
110 as the former is more robust if P's type is changed.
111 Prefer xzalloc to xmalloc + memset 0.
112 Simplify malloc-or-realloc to realloc.
113 Don't worry about xmalloc returning a null pointer.
114 Prefer xstrdup to xmalloc + strcpy.
115 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
117 * keyboard.c (apply_modifiers_uncached): Prefer local array to
118 alloca of a constant.
120 2012-07-05 Eli Zaretskii <eliz@gnu.org>
122 * xdisp.c (display_line): Fix horizontal pixel coordinates when
123 hscroll is larger than the line width. Fixes long and futile
124 looping inside extend_face_to_end_of_line (on a TTY) producing
125 glyphs that are not needed and thrown away.
127 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
129 * marker.c (set_marker_restricted_both): Simplify by using
132 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
134 * editfns.c (region_limit): Simplify by using clip_to_bounds.
136 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
138 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
139 not defined (Bug#11768).
140 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
141 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
142 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
143 followed by gtk_box_set_homogeneous (Bug#11768).
144 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
145 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
146 gtk_scrollbar_new (Bug#11768).
147 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
148 (is_box_type): New function (Bug#11768).
149 (xg_tool_item_stale_p): Call is_box_type.
150 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
151 with default display (Bug#11768).
153 2012-07-05 Eli Zaretskii <eliz@gnu.org>
155 * xdisp.c (window_hscroll_limited): New function.
156 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
157 coordinates when window's hscroll is set to insanely large
160 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
162 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
163 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
165 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
168 * lisp.h (xzalloc): New prototype. Omit needless casts.
169 * alloc.c (xzalloc): New function. Omit needless casts.
170 * charset.c: Omit needless casts. Convert all calls to
171 xmalloc with following memset to xzalloc.
172 * dispnew.c: Likewise.
173 * fringe.c: Likewise.
177 * w32fns.c: Likewise.
178 * w32font.c: Likewise.
179 * w32term.c: Likewise.
180 * xfaces.c: Likewise.
183 * atimer.c: Omit needless casts.
184 * buffer.c: Likewise.
185 * callproc.c: Likewise.
187 * coding.c: Likewise.
188 * composite.c: Likewise.
190 * doprnt.c: Likewise.
191 * editfns.c: Likewise.
194 * filelock.c: Likewise.
196 * gtkutil.c: Likewise.
197 * keyboard.c: Likewise.
200 * minibuf.c: Likewise.
203 * process.c: Likewise.
204 * region-cache.c: Likewise.
205 * search.c: Likewise.
206 * sysdep.c: Likewise.
207 * termcap.c: Likewise.
208 * terminal.c: Likewise.
209 * tparam.c: Likewise.
210 * w16select.c: Likewise.
212 * w32reg.c: Likewise.
213 * w32select.c: Likewise.
214 * w32uniscribe.c: Likewise.
215 * widget.c: Likewise.
219 * xselect.c: Likewise.
221 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
223 * fileio.c (time_error_value): Check the right error number.
224 Problem reported by Troels Nielsen in
225 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
227 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
229 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
230 This should be fixed in a better way; see Eli Zaretskii in
231 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
232 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
234 * fileio.c (time_error_value): Rename from special_mtime.
235 The old name's problems were noted by Eli Zaretskii in
236 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
238 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
239 This variable's comment says Emacs needs at least one GDB-visible
240 symbol of type enum pvec_type, to work around GDB problems.
241 The symbol's value doesn't matter.
243 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
244 that causes compilation to fail on pre-C99 compilers.
246 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
248 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
249 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
251 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
253 * buffer.c (init_buffer_once): Fix initialization of
254 headers for buffer_defaults and buffer_local_symbols.
255 Reported by Juanma Barranquero <lekktu@gmail.com>.
257 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
259 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
260 * lisp.h (enum pvec_type): Use fewer bits.
261 (PSEUDOVECTOR_SIZE_BITS): New constant.
262 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
263 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
265 (PSEUDOVECTOR_TYPEP): New macro.
266 (TYPED_PSEUDOVECTORP): Use it.
267 * fns.c (internal_equal): Adapt code to extract pvectype.
268 * emacs.c (gdb_pvec_type): Update type.
269 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
270 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
271 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
272 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
273 (sweep_vectors): Use it. Use local var `total_bytes' instead of
274 abusing vector->header.next.nbytes.
275 (live_vector_p): Use PVEC_TYPE.
276 (mark_object): Adapt code to extract pvectype. Use switch.
278 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
280 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
281 Tighten new eassert a bit.
283 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
285 Fix compilation with --enable-gcc-warnings and -O1
287 * doprnt.c (doprnt): Change type of tem to int, initialize
288 to avoid compiler warning. Add eassert.
289 * search.c (simple_search): Initialize match_byte to avoid
290 compiler warning. Add eassert.
292 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
294 Avoid weird behavior with large horizontal scrolls.
295 Without this change, for example, large hscroll values would
296 mess up Emacs's display on Fedora 15 x86, presumably due to
297 overflows in int calculations in the display code.
298 Also, if buffers had long lines, Emacs would freeze.
299 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
300 (set_window_hscroll): New function, containing the old guts of
301 Fset_window_hscroll. Return the clipped value.
302 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
303 This avoids the need to check against PTRDIFF_MAX.
305 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
307 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
309 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
311 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
313 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
314 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
315 since GCC 4.4.6 issues a bogus warning for them.
317 Fix bugs in file timestamp newness comparisons.
318 * fileio.c (Ffile_newer_than_file_p):
319 * lread.c (Fload): Use full timestamp resolution of files,
320 not just the 1-second resolution, so that files that are only
321 slightly newer still count as newer.
322 * fileio.c (Ffile_newer_than_file_p): Don't assume file
323 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
325 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
327 * fileio.c: Improve handling of file time marker. (Bug#11852)
328 (special_mtime): New function.
329 (Finsert_file_contents, Fverify_visited_file_modtime):
330 Use it to set special mtime values consistently.
332 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
334 * fileio.c (Finsert_file_contents): Properly handle st_mtime
335 marker for non-existing file. (Bug#11852)
337 2012-07-03 Glenn Morris <rgm@gnu.org>
339 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
340 and did not make it into globals.h).
342 2012-07-03 Tom Tromey <tromey@redhat.com>
344 * window.c (Fset_window_margins, Fset_window_fringes)
345 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
346 * textprop.c (Fprevious_property_change): No longer static.
347 * syntax.c (Fsyntax_table_p): No longer static.
348 * process.c (Fget_process, Fprocess_datagram_address): No longer
350 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
351 * keyboard.c (Fcommand_execute): No longer static.
353 * insdel.c (Fcombine_after_change_execute): No longer static.
354 * image.c (Finit_image_library): No longer static.
355 * fileio.c (Fmake_symbolic_link): No longer static.
356 * eval.c (Ffetch_bytecode): No longer static.
357 * editfns.c (Fuser_full_name): No longer static.
358 * doc.c (Fdocumentation_property, Fsnarf_documentation):
360 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
362 * dired.c (Ffile_attributes): No longer static.
363 * composite.c (Fcomposition_get_gstring): No longer static.
364 * callproc.c (Fgetenv_internal): No longer static.
366 * ccl.h: Remove EXFUNs.
367 * buffer.h: Remove EXFUNs.
368 * dispextern.h: Remove EXFUNs.
369 * intervals.h: Remove EXFUNs.
370 * fontset.h: Remove EXFUN.
371 * font.h: Remove EXFUNs.
372 * dosfns.c (system_process_attributes): Remove EXFUN.
373 * keymap.h: Remove EXFUNs.
374 * lisp.h: Remove EXFUNs.
375 * w32term.h: Remove EXFUNs.
376 * window.h: Remove EXFUNs.
377 * xsettings.h: Remove EXFUN.
378 * xterm.h: Remove EXFUN.
380 2012-07-03 Glenn Morris <rgm@gnu.org>
382 * lisp.h (Frandom): Make it visible to C.
383 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
384 buffer for invisible buffers. (Bug#1229)
386 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
388 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
389 values which aren't power of 2.
390 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
391 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
394 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
396 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
398 * alloc.c (mark_object): Revert part of last patch to use `switch'.
400 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
402 * alloc.c (allocate_vector_block): Remove redundant
403 calls to mallopt if DOUG_LEA_MALLOC is defined.
404 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
405 avoid calls to mallopt if zero_vector is returned.
407 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
409 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
410 is enabled, avoid dereferencing NULL current_sblock if
413 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
415 Cleanup basic buffer management.
416 * buffer.h (struct buffer): Change layout to use generic vector
417 marking code. Fix some comments. Change type of 'clip_changed'
418 to bitfield. Remove unused #ifndef old.
419 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
420 (GET_OVERLAYS_AT): Fix indentation.
421 (for_each_per_buffer_object_at): New macro.
422 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
423 (Fbuffer_local_variables): Use it.
424 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
425 * alloc.c (allocate_buffer): Adjust to match new layout of
426 struct buffer. Fix comment.
427 (mark_overlay): New function.
428 (mark_buffer): Use it. Use mark_vectorlike to mark normal
429 Lisp area of struct buffer.
430 (mark_object): Use it. Adjust marking of misc objects
431 and related comments.
433 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
435 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
436 wrapper that is not needed because the wrapped code is a no-op (zero
437 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
438 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
440 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
442 * alloc.c (mark_buffer): Simplify. Remove prototype.
443 (mark_object): Add comment. Reorganize marking of vector-like
444 objects. Use CHECK_LIVE for all vector-like objects except buffers
445 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
446 redundant calls to mark_vectorlike for bool vectors.
448 2012-06-30 Glenn Morris <rgm@gnu.org>
450 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
452 * epaths.in (PATH_SITELOADSEARCH): New.
453 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
454 This is rather than relying on --enable-locallisppath elements
455 having "site-lisp" in their names. (Bug#10208#25, 11658)
457 2012-06-30 Eli Zaretskii <eliz@gnu.org>
459 * w32proc.c (sys_select): Accept and ignore one more argument.
461 * w32.c (emacs_gnutls_pull): Call select with one more argument.
463 * sysselect.h [DOS_NT]: Don't include sys/select.h.
464 (pselect) [!MS_DOS]: Redirect to sys_select.
466 * sysdep.c: Don't include dos.h and dosfns.h.
468 * process.c (sys_select):
469 * msdos.c (sys_select): Accept one more argument and ignore it.
471 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
472 adapt data types and code to that.
475 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
476 which clashes with the gnulib function of the same name.
478 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
480 * font.c (font_style_to_value, font_style_symbolic)
481 (font_prop_validate_style): Add type checks for values in
484 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
486 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
489 2012-06-29 Eli Zaretskii <eliz@gnu.org>
491 * xdisp.c (try_window_id): Undo last change.
493 * w32.c (getwd): Adjust commentary about startup_dir.
494 (init_environment): Always call sys_access, even in non-MSVC
495 builds. Don't chdir to the directory of the Emacs executable.
496 This undoes code from 1997 which was justified by the need to
497 "avoid conflicts when removing and renaming directories". But its
498 downside was that every relative file name was being interpreted
499 relative to the directory of the Emacs executable, which can never
500 be TRT. In particular, it broke sys_access when called with
502 (sys_access): Map GetLastError to errno.
504 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
506 * window.h (struct window): Change type of 'fringes_outside_margins'
507 to bitfield. Fix comment. Adjust users accordingly.
508 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
510 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
513 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
515 * gnutls.c (emacs_gnutls_handshake):
516 Add QUIT to make the loop interruptible.
518 2012-06-29 Glenn Morris <rgm@gnu.org>
520 * charset.c (init_charset): Make lack of etc/charsets fatal.
522 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
524 * editfns.c (region_limit): Fix type mismatch.
526 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
528 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
529 undefined. Convert from xassert to eassert.
530 * nsmenu.m: Convert from xassert to eassert.
531 * nsterm.m: Likewise.
533 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
535 * editfns.c (region_limit): Clip to narrowing (bug#11770).
537 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
539 Avoid integer overflow on scroll-left and scroll-right.
540 * window.c (HSCROLL_MAX): New macro.
541 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
542 overflow when requested scroll falls outside ptrdiff_t range.
544 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
546 * window.h (struct window): Change type of 'hscroll',
547 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
548 'last_modified' and 'last_overlay_modified' to EMACS_INT.
549 Adjust users accordingly.
550 * xdisp.c (try_cursor_movement): Replace type check with eassert.
551 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
552 from EMACS_INT to ptrdiff_t.
553 (make_window): Omit redundant initialization.
555 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
557 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
559 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
561 * window.h (struct window): Change type of 'use_time' and
562 'sequence_number' from Lisp_Object to int.
563 * frame.c (make_frame): Adjust users accordingly.
564 * print.c (print_object): Likewise.
565 * window.c (select_window, Fwindow_use_time, make_parent_window)
566 (make_window): Likewise.
568 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
570 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
571 enabled with --enable-checking=[all,glyphs] configure option.
572 Fix GLYPH_DEBUG usage assuming that it may be undefined,
573 adjust comments accordingly.
574 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
575 undefined, adjust comments accordingly.
577 * scroll.c: Likewise.
578 * w32fns.c: Likewise.
579 * w32term.c: Likewise.
581 * xfaces.c: Likewise.
585 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
587 Generalize run-time debugging checks.
588 * dispextern.h (XASSERTS): Remove.
589 * fontset.c (xassert): Remove.
590 Convert from xassert to eassert.
591 * alloc.c: Convert from xassert to eassert.
593 * dispnew.c: Likewise.
595 * fringe.c: Likewise.
596 * ftfont.c: Likewise.
597 * gtkutil.c: Likewise.
599 * keyboard.c: Likewise.
601 * process.c: Likewise.
602 * scroll.c: Likewise.
605 * w32console.c: Likewise.
606 * w32fns.c: Likewise.
607 * w32term.c: Likewise.
608 * window.c: Likewise.
610 * xfaces.c: Likewise.
612 * xselect.c: Likewise.
615 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
617 * fns.c (maybe_resize_hash_table): Output message when growing the
620 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
622 * alloc.c (allocate_string_data): Remove dead code.
623 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
624 avoid GCC warning about unused macro.
626 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
628 * alloc.c (allocate_string): Omit intervals initialization.
629 * alloc.c (make_uninit_multibyte_string): Initialize intervals
630 as in make_pure_string and make_pure_c_string.
632 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
634 * alloc.c (allocate_string): Fix last change.
636 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
638 * alloc.c (allocate_string): Remove two redundant calls
639 to memset, add explicit initialization where appropriate.
641 2012-06-27 Glenn Morris <rgm@gnu.org>
643 * lisp.mk (lisp): Remove paths.elc.
645 2012-06-27 Chong Yidong <cyd@gnu.org>
647 * doc.c (Fsubstitute_command_keys): Fix punctuation.
649 2012-06-26 John Wiegley <johnw@newartisans.com>
651 * unexmacosx.c (copy_data_segment): Add two section names used
652 on Mac OS X Lion: __mod_init_func and __mod_term_func.
654 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
655 when building with Clang.
657 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
659 * eval.c (Fapply): Allow calling it with a single argument.
661 2012-06-26 Eli Zaretskii <eliz@gnu.org>
663 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
664 _stricmp and _strnicmp.
665 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
667 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
669 * alloc.c (allocate_window): Zero out non-Lisp part of newly
671 (allocate_process): Likewise for new process.
672 (allocate_terminal): Change to use offsetof.
673 (allocate_frame): Likewise.
674 * frame.c (make_frame): Omit redundant initialization.
675 * window.c (make_parent_window): Use memset.
676 (make_window): Omit redundant initialization.
677 * process.c (make_process): Omit redundant initialization.
678 * terminal.c (create_terminal): Likewise.
680 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
682 * term.c (delete_tty): Remove redundant call to memset.
684 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
686 * alloc.c: Remove build_string.
687 * lisp.h: Define build_string as static inline. This provides
688 a better opportunity to optimize away calls to strlen when the
689 function is called with compile-time constant argument.
690 * image.c (imagemagick_error): Convert to build_string.
691 * w32proc.c (sys_spawnve): Likewise.
692 * xterm.c (x_term_init): Likewise.
694 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
696 Use sprintf return value instead of invoking strlen on result.
697 In the old days this wasn't portable, since some sprintf
698 implementations returned char *. But they died out years ago and
699 Emacs already assumes sprintf returns int.
700 Similarly for float_to_string.
701 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
702 * ccl.c (ccl_driver):
703 * character.c (string_escape_byte8):
704 * data.c (Fnumber_to_string):
706 * print.c (print_object):
707 * xdisp.c (message_dolog):
708 * xfns.c (syms_of_xfns):
709 Use sprintf or float_to_string result to avoid need to call strlen.
710 * data.c (Fnumber_to_string):
711 Use make_unibyte_string, since the string must be ASCII.
712 * lisp.h, print.c (float_to_string): Now returns int length.
713 * term.c (produce_glyphless_glyph):
714 Use sprintf result rather than recomputing it.
716 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
717 * Makefile.in (ALL_CFLAGS):
718 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
719 * gmalloc.c, regex.c: Include <config.h> unconditionally.
721 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
723 * dispextern.h (xstrcasecmp): Define to library function
724 strcasecmp if available.
725 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
727 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
729 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
730 Avoid comma operator.
731 * menu.c (push_submenu_start, push_submenu_end)
732 (push_left_right_boundary, push_menu_pane): Likewise.
733 * msdos.c (dos_rawgetc): Likewise.
735 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
737 * xfns.c (xic_create_fontsetname): Remove redundant calls
740 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
742 * gtkutil.c (get_utf8_string): Remove redundant assignment.
743 sprintf already null-terminates its output.
745 * xfns.c (x_window): Remove redundant cast.
747 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
749 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
750 `const char *' to `char *' to avoid compiler warning.
752 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
754 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
755 instead of truncating it to 63 (admittedly a generous limit).
757 * process.c: Fix spelling and caps in comments.
759 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
761 * emacs.c (setpgrp): Remove definition, unused.
762 * sysdep.c (setpgrp): Remove definition, not used in this file.
764 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
766 * makefile.w32-in: Update dependencies.
768 2012-06-24 Eli Zaretskii <eliz@gnu.org>
770 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
771 (SYSTIME_H): Add nt/inc/sys/time.h.
773 * systime.h [WINDOWSNT]: Include sys/time.h.
775 * s/ms-w32.h (struct timespec): Definition moved from
776 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
778 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
780 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
781 * buffer.h (buffer_slot_type_mismatch):
782 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
783 * eval.c (unwind_to_catch):
784 * image.c (my_png_error, my_error_exit):
785 * keyboard.c (quit_throw_to_read_char, user_error)
786 (Fexit_recursive_edit, Fabort_recursive_edit):
787 * lisp.h (die, args_out_of_range, args_out_of_range_3)
788 (wrong_type_argument, buffer_overflow, __executable_start)
789 (memory_full, buffer_memory_full, string_overflow, Fthrow)
790 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
791 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
793 (child_setup) [!DOS_NT]:
794 * lread.c (end_of_file_error, invalid_syntax):
795 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
796 * puresize.h (pure_write_error):
797 * search.c (matcher_overflow):
798 * sound.c (sound_perror, alsa_sound_perror):
799 * sysdep.c, syssignal.h (croak):
800 * term.c (maybe_fatal, vfatal):
801 * textprop.c (text_read_only):
802 * undo.c (user_error):
803 * unexmacosx.c (unexec_error):
804 * xterm.c (x_ins_del_lines, x_delete_glyphs):
805 Use _Noreturn rather than NO_RETURN.
806 No need for separate decl merely because of _Noreturn.
807 * sound.c (sound_warning, parse_sound):
808 Remove unnecessary forward decls.
810 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
812 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
813 * lisp.h (WAIT_READING_MAX): New macro.
814 * dispnew.c (Fsleep_for, sit_for):
815 * keyboard.c (kbd_buffer_get_event):
816 * process.c (Faccept_process_output):
817 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
818 This improves on the previous patch, which introduced a bug
819 when time_t is unsigned and as wide as intmax_t.
820 See <http://bugs.gnu.org/9000#51>.
822 2012-06-23 Eli Zaretskii <eliz@gnu.org>
824 * dispnew.c (sit_for, Fsleep_for):
825 * keyboard.c (kbd_buffer_get_event):
826 * process.c (Faccept_process_output): Avoid compiler warnings when
827 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
829 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
831 * makefile.w32-in: Update dependencies.
833 * w32.c (ltime): Add return type and declare static.
834 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
836 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
838 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
839 Privately reported by Herbert J. Skuhra.
840 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
842 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
843 not make_lisp_timeval, when the argument is of type EMACS_TIME.
845 2012-06-23 Eli Zaretskii <eliz@gnu.org>
847 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
848 last argument of make_unibyte_string.
850 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
851 language ID in the event parameters.
853 * w32term.c (w32_read_socket): Put the new keyboard codepage into
854 event.code, not the obscure "character set ID".
856 2012-06-23 Chong Yidong <cyd@gnu.org>
858 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
860 2012-06-23 Eli Zaretskii <eliz@gnu.org>
862 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
863 * w32.c (fdutimens): New function.
865 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
867 * s/ms-w32.h (pselect): Redirect to sys_select.
869 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
871 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
872 in the logic of incrementing and decrementing the value of
873 use_relocatable_buffers.
875 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
877 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
878 Privately reported by Herbert J. Skuhra.
879 [__FreeBSD__]: Remove "*/" typo after "#include".
880 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
881 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
882 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
883 Don't assume EMACS_TIME and struct timeval are the same type.
885 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
887 Support higher-resolution time stamps (Bug#9000).
888 The time stamps are only nanosecond-resolution at the C level,
889 since that's the best that any real-world system supports now.
890 But they are picosecond-resolution at the Lisp level, as that's
891 easy, and leaves room for future OS improvements.
893 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
896 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
897 Don't get current time unless it's needed.
899 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
900 now provides it if it's absent.
901 (start_atimer): Port to higher-res time stamps.
902 Check for time stamp overflow. Don't get current time more
903 often than is needed.
905 * buffer.h (struct buffer): Buffer modtime now has high resolution.
906 Include systime.h, not time.h.
907 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
909 * dired.c: Include stat-time.h.
910 (Ffile-attributes): File times now have higher resolution.
912 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
913 (struct image): Timestamp now has higher resolution.
915 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
916 has at least microseconds now. All uses removed.
917 (update_frame, update_single_window, update_window, update_frame_1)
918 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
920 * editfns.c (time_overflow): Now extern.
921 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
922 (float-time, Fformat_time_string, Fcurrent_time_string)
923 (Fcurrent_time_zone): Accept and generate higher-resolution
925 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
926 (decode_time_components, lisp_seconds_argument): New functions.
927 (make_time): Now static.
928 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
929 Report an error if the time is invalid, rather than having the caller
932 * fileio.c: Include <stat-time.h>
933 (Fcopy_file): Copy higher-resolution time stamps.
934 Prefer to set the time stamp via a file descriptor if that works.
935 (Fset_file_times, Finsert_file_contents, Fwrite_region)
936 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
937 (Fvisited_file_modtime, Fset_visited_file_modtime):
938 Support higher-resolution time stamps.
940 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
942 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
944 * image.c (prepare_image_for_display, clear_image_cache)
945 (lookup_image): Port to higer-resolution time stamps.
947 * keyboard.c (start_polling, bind_polling_period):
948 Check for time stamp overflow.
949 (read_char, kbd_buffer_get_event, timer_start_idle)
950 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
951 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
952 Port to higher-resolution time stamps. Do not assume time_t is signed.
953 (decode_timer): New function. Timers are now vectors of length 9,
954 not 8, to accommodate the picosecond component.
955 (timer_check_2): Use it.
957 * nsterm.m (select_timeout, timeval_subtract): Remove.
958 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
959 as they're a bit more accurate and handle overflow better.
960 (ns_select): Change prototype to be compatible with pselect.
961 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
962 * nsterm.h (ns_select): Adjust prototype.
964 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
965 us-resolution time stamps.
966 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
968 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
970 * lisp.h (time_overflow): New decl.
971 (wait_reading_process_output): First arg is now intmax_t, not int,
972 to accommodate larger waits.
974 * process.h (struct Lisp_Process.read_output_delay):
975 Now counts nanoseconds, not microseconds.
976 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
978 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
979 (wait_reading_process_output):
980 Port to ns-resolution time stamps.
981 (Faccept_process_output, wait_reading_process_output):
982 Check for time stamp overflow. Do not assume time_t is signed.
983 (select_wrapper): Remove; we now use pselect.
984 (Fprocess_attributes): Now generates ns-resolution time stamps.
986 * sysdep.c: Include utimens.h. Don't include utime.h
987 or worry about struct utimbuf; gnulib does that for us now.
988 (gettimeofday): Remove; gnulib provides a substitute.
989 (make_timeval): New function.
990 (set_file_times): Now sets ns-resolution time stamps.
991 New arg FD; all uses changed.
992 (time_from_jiffies, ltime_from_jiffies, get_up_time)
993 (system_process_attributes):
994 Now returns ns-resolution time stamp. All uses changed.
995 Check for time stamp overflow.
997 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
998 provides a substitute now.
1000 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1001 since it guarantees struct timespec.
1002 (EMACS_TIME): Now struct timespec, so that we can support
1003 ns-resolution time stamps.
1004 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1005 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1006 (EMACS_USECS): Remove.
1007 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1008 so multiply the arg by 1000 before storing it.
1009 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1011 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1012 Port to ns-resolution time stamps.
1013 (EMACS_TIME_NEG_P): Remove; replaced by....
1014 (EMACS_TIME_SIGN): New macro.
1015 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1016 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1017 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1018 (make_timeval, make_lisp_time, decode_time_components): New decls.
1019 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1020 that it mishandled time_t overflow. You can't compare by subtracting!
1021 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1022 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1024 * term.c: Include <sys/time.h>.
1025 (timeval_to_Time): New function, for proper overflow wraparound.
1026 (term_mouse_position, term_mouse_click): Use it.
1028 * undo.c (record_first_change): Support higher-resolution time stamps
1030 (Fprimitive_undo): Use them when restoring time stamps.
1032 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1033 (w32_get_internal_run_time):
1034 Port to higher-resolution Emacs time stamps.
1035 (ltime): Now accepts single 64-bit integer, as that's more convenient
1038 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1040 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1041 for compatibility with pselect. Support ns-resolution time stamps.
1043 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1045 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1046 Check for time stamp overflow, and support ns-resolution time stamps.
1048 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1049 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1050 (timeval_subtract): Remove; no longer needed.
1051 (XTflash, XTring_bell, x_wait_for_event):
1052 Port to ns-resolution time stamps. Don't assume time_t is signed.
1054 2012-06-22 Chong Yidong <cyd@gnu.org>
1056 * xdisp.c (x_consider_frame_title): Revert last change.
1058 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1060 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1061 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1062 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1063 staticidx goes up to 1597 out of 1600 = 0x640.)
1065 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1067 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1068 Otherwise, the umask might be mistakenly 0 while handling input signals.
1070 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1072 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1074 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1076 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1077 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1078 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1079 access to `contents' member of Lisp_Vector objects with AREF and ASET
1082 2012-06-19 Chong Yidong <cyd@gnu.org>
1084 * frame.c (delete_frame): When selecting a frame on a different
1085 text terminal, do not alter the terminal's top-frame.
1087 * xdisp.c (format_mode_line_unwind_data): Record the target
1088 frame's selected window and its terminal's top-frame.
1089 (unwind_format_mode_line): Restore them.
1090 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1092 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1093 since tty frames can be explicitly named.
1094 (prepare_menu_bars): Likewise.
1096 * term.c (Ftty_top_frame): New function.
1098 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1100 Port byte-code-meter to modern targets.
1101 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1102 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1103 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1104 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1105 (METER_1, METER_2): Simplify.
1107 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1109 * data.c (Fdefalias): Return `symbol' (bug#11686).
1111 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1113 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1114 gets killed during executing of this function (Bug#11665).
1115 Try to always return Qt when the buffer has been actually killed.
1116 (Vkill_buffer_query_functions): In doc-string say that functions
1117 run by this hook should not change the current buffer.
1119 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1121 Fix recently-introduced process.c problems found by static checking.
1122 * process.c (write_queue_push, write_queue_pop, send_process):
1123 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1124 (write_queue_pop): Fix pointer signedness problem.
1125 (send_process): Remove unused local.
1127 2012-06-17 Chong Yidong <cyd@gnu.org>
1129 * xdisp.c (redisplay_internal): No need to redisplay terminal
1130 frames that are not on top.
1132 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1134 * process.c (make_process): Initialize write_queue.
1135 (write_queue_push, write_queue_pop): New functions.
1136 (send_process): Use them to maintain correct ordering of process
1139 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1141 * lisp.h (eassert): Assume C89 or later.
1142 This removes the need for CHECK.
1143 (CHECK): Remove. Its comments about always evaluating its
1144 argument were confusing, as 'eassert' typically does not evaluate
1147 * coding.c (produce_chars): Use ptrdiff_t, not int.
1149 * xterm.c (x_draw_underwave): Check for integer overflow.
1150 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1152 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1154 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1155 referenced (Bug#11583).
1157 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1159 Implement wave-style variant of underlining.
1160 * dispextern.h (face_underline_type): New enum.
1161 (face): Add field for underline type.
1162 * nsterm.m (ns_draw_underwave): New function.
1163 (ns_draw_text_decoration): Use it.
1164 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1166 (x_draw_glyph_string): Use them.
1167 * xfaces.c (Qline, Qwave): New Lisp objects.
1168 (check_lface_attrs, merge_face_ref)
1169 (Finternal_set_lisp_face_attribute, realize_x_face):
1170 Handle wave-style underline face attributes.
1171 * xterm.c (x_draw_underwave): New function.
1172 (x_draw_glyph_string): Use it.
1174 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1176 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1177 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1178 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1179 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1180 ($(BLD)/w32select.$(O)): Update dependencies.
1182 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1184 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1185 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1186 * character.c (_fetch_multibyte_char_p): Remove.
1187 * alloc.c: Include "character.h" before "buffer.h".
1189 * buffer.c: Likewise.
1190 * bytecode.c: Likewise.
1191 * callint.c: Likewise.
1192 * callproc.c: Likewise.
1193 * casefiddle.c: Likewise.
1194 * casetab.c: Likewise.
1195 * category.c: Likewise.
1197 * coding.c: Likewise.
1198 * composite.c: Likewise.
1199 * dired.c: Likewise.
1200 * dispnew.c: Likewise.
1202 * dosfns.c: Likewise.
1203 * editfns.c: Likewise.
1204 * emacs.c: Likewise.
1205 * fileio.c: Likewise.
1206 * filelock.c: Likewise.
1208 * fontset.c: Likewise.
1209 * fringe.c: Likewise.
1210 * indent.c: Likewise.
1211 * insdel.c: Likewise.
1212 * intervals.c: Likewise.
1213 * keyboard.c: Likewise.
1214 * keymap.c: Likewise.
1215 * lread.c: Likewise.
1216 * macros.c: Likewise.
1217 * marker.c: Likewise.
1218 * minibuf.c: Likewise.
1219 * nsfns.m: Likewise.
1220 * nsmenu.m: Likewise.
1221 * print.c: Likewise.
1222 * process.c: Likewise.
1223 * regex.c: Likewise.
1224 * region-cache.c: Likewise.
1225 * search.c: Likewise.
1226 * syntax.c: Likewise.
1228 * textprop.c: Likewise.
1230 * unexsol.c: Likewise.
1231 * w16select.c: Likewise.
1232 * w32fns.c: Likewise.
1233 * w32menu.c: Likewise.
1234 * window.c: Likewise.
1235 * xdisp.c: Likewise.
1237 * xmenu.c: Likewise.
1239 * xselect.c: Likewise.
1241 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1243 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1244 If all the glyphs of the glyph row came from strings, and we have no
1245 cursor positioning clues, put the cursor on the first glyph of the
1247 (handle_face_prop): Use chunk-relative overlay string index when
1248 indexing into it->string_overlays array. (Bug#11653)
1249 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1250 the rightmost. (Bug#11720)
1252 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1254 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1255 (CATEGORY_MEMBER): Enforce 1/0 value.
1256 * category.c (_temp_category_set): Remove.
1258 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1260 * window.c (Fdelete_other_windows_internal)
1261 (Fdelete_window_internal): Don't access frame's mouse highlight
1262 info of the initial frame. (Bug#11677)
1264 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1266 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1267 Assume USE_2_TAGS_FOR_INTS.
1268 (xreload): Adjust $tagmask width to match recent lisp.h change.
1270 Simplify lisp.h in minor ways that should not affect code.
1271 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1272 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1273 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1274 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1275 (INTTYPEBITS): New macro, for clarity.
1276 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1277 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1278 Simplify now that USE_LSB_TAG is always defined.
1279 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1280 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1282 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1284 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1286 2012-06-13 Glenn Morris <rgm@gnu.org>
1288 * s/bsd-common.h (BSD4_3):
1289 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1291 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1293 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1296 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1298 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1299 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1300 * alloc.c (widen_to_Lisp_Object): Remove.
1301 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1302 * frame.c (delete_frame): Remove outdated comment.
1303 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1304 USE_LISP_UNION_TYPE.
1305 (Fw32_unregister_hot_key): Likewise.
1306 (Fw32_toggle_lock_key): Likewise.
1307 * w32menu.c (add_menu_item): Likewise.
1308 (w32_menu_display_help): Use XIL instead of checking
1309 USE_LISP_UNION_TYPE.
1310 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1311 (init_heap): Likewise.
1312 * w32term.c (w32_read_socket): Update comment.
1314 2012-06-13 Glenn Morris <rgm@gnu.org>
1316 * s/usg5-4-common.h, src/s/unixware.h:
1317 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1319 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1321 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1323 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1324 * alloc.c (make_number) [!defined make_number]:
1325 Remove, as lisp.h always defines this now.
1326 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1327 (roundup_size): Verify that it is a power of 2.
1328 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1329 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1330 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1331 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1332 USE_LSB_TAG now is always defined to be either 0 or 1.
1334 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1335 code works fine either way, and efficiency is not a concern here,
1336 as the union type is for debugging, not for production.
1337 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1338 Use an inline function on all platforms when using the union type,
1339 since this is simpler and 'static inline' can be used portably
1341 (LISP_INITIALLY_ZERO): New macro.
1342 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1343 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1345 2012-06-12 Glenn Morris <rgm@gnu.org>
1347 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1349 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1351 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1352 Move BROKEN_SIGIO to configure.
1354 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1355 Move NO_TERMIO to configure.
1357 2012-06-12 Chong Yidong <cyd@gnu.org>
1359 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1360 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1361 MagickExportImagePixels is undefined.
1363 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1365 * image.c (imagemagick_load_image): Remove unused label.
1367 2012-06-11 Glenn Morris <rgm@gnu.org>
1369 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1370 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1371 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1372 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1374 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1376 * alloc.c (make_byte_code): New function.
1377 (Fmake_byte_code): Use it. Don't purify here.
1378 * lread.c (read1): Use it as well to avoid extra allocation.
1380 2012-06-11 Chong Yidong <cyd@gnu.org>
1382 * image.c (imagemagick_load_image): Implement transparency.
1384 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1386 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1387 account for preceding backslashes. (Bug#11663)
1389 2012-06-09 Chong Yidong <cyd@gnu.org>
1391 * term.c: Support italics in capable terminals (Bug#9652).
1392 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1393 (turn_on_face): Output using TS_enter_italic_mode if available.
1394 Don't handle unused blinking and alt-charset cases.
1395 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1396 and tty_alt_charset_p cases.
1397 (tty_capable_p, init_tty): Support italics.
1399 * termchar.h (struct tty_display_info): Add field for italics.
1400 Remove unused blink field.
1402 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1405 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1406 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1407 tty_alt_charset_p. Add tty_italic_p.
1409 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1411 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1412 dbus_type_is_basic if available.
1413 (xd_extract_signed, xd_extract_unsigned): Rename from
1414 extract_signed and extract_unsigned, respectively. Adapt callers.
1416 2012-06-09 Chong Yidong <cyd@gnu.org>
1418 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1420 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1423 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1425 * xdisp.c (vmessage): Treat frame message as multibyte.
1426 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1427 would generate the diagnostic "Making \302\247 buffer-local while
1430 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1432 * dispnew.c (showing_window_margins_p): Undo last change, which
1433 was done due to an inadvertent commit.
1434 (adjust_frame_glyphs_for_frame_redisplay): Do call
1435 showing_window_margins_p.
1437 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1439 * eval.c (Fmake_var_non_special): New primitive.
1440 (syms_of_eval): Defsubr it.
1441 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1443 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1445 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1446 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1448 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1450 * alloc.c (allocate_vectorlike): Fix last change.
1452 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1454 Block-based vector allocation of small vectors.
1455 * lisp.h (struct vectorlike_header): New field `nbytes',
1456 adjust comment accordingly.
1457 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1458 to denote vector blocks. Adjust users (live_vector_p,
1459 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1460 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1461 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1462 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1463 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1464 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1465 (roundup_size): New constant.
1466 (struct vector_block): New data type.
1467 (vector_blocks, vector_free_lists, zero_vector): New variables.
1468 (all_vectors): Rename to `large_vectors'.
1469 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1470 (sweep_vectors): New functions.
1471 (allocate_vectorlike): Return `zero_vector' as the only vector of
1472 0 items. Allocate new vector from block if vector size is less than
1473 or equal to VBLOCK_BYTES_MAX.
1474 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1475 (init_alloc_once): Add call to init_vectors.
1477 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1479 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1481 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1483 * doprnt.c (doprnt): Truncate multibyte char correctly.
1484 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1485 would mishandle a string argument "Xc" if X was a multibyte
1486 character of length 2: it would truncate after X's first byte
1487 rather than including all of X.
1489 2012-06-06 Chong Yidong <cyd@gnu.org>
1491 * buffer.c (word_wrap): Doc fix.
1493 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1495 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1497 2012-06-03 Glenn Morris <rgm@gnu.org>
1499 * xdisp.c (tool-bar-style): Doc fix.
1501 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1503 * Makefile.in (PAXCTL): Define.
1504 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1505 binary via PaX flags if the paxctl utility is available.
1506 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1507 Restore PaX flags to their default. (Bug#11398)
1509 2012-06-03 Chong Yidong <cyd@gnu.org>
1511 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1514 2012-06-03 Chong Yidong <cyd@gnu.org>
1516 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1517 (note_mode_line_or_margin_highlight): If there is no help echo,
1518 use mode-line-default-help-echo. Handle the case where the mouse
1519 position is past the end of the mode line string.
1521 * buffer.c (buffer_local_value_1): New function, split from
1522 Fbuffer_local_value; can return Qunbound.
1523 (Fbuffer_local_value): Use it.
1524 (Vmode_line_format): Docstring tweaks.
1526 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1528 * sysdep.c (system_process_attributes): Improve comment.
1530 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1532 * keyboard.c: Export real-this-command to Elisp.
1533 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1534 and DEFVAR it. Update all users.
1536 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1538 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1540 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1541 Convert pctcpu and pctmem to Lisp float properly.
1542 Let the compiler fold better, as 100.0/0x8000 is exact.
1544 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1546 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1549 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1551 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1553 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1555 For a 'struct window', replace some Lisp_Object fields to
1556 bitfields where appropriate, remove unused fields.
1557 * window.h (struct window): Remove unused 'last_mark_x' and
1558 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1559 change it's type from Lisp_Object to bitfield.
1560 Change type of 'force_start', 'optional_new_start',
1561 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1562 fields from Lisp_Object to bitfield. Adjust users accordingly.
1564 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1566 Pacify gcc -Wdouble-precision when using Xaw.
1567 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1568 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1569 Use 'float' consistently, rather than 'float' in most places
1570 and 'double' in a couple of places.
1572 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1574 * xdisp.c (handle_stop): Detect whether we have overlay strings
1575 loaded by testing it->current.overlay_string_index to be
1576 non-negative, instead of checking whether n_overlay_strings is
1577 positive. (Bug#11587)
1579 2012-05-31 Chong Yidong <cyd@gnu.org>
1581 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1583 * doc.c (Fsubstitute_command_keys): Doc fix.
1585 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1587 * search.c (search_buffer): Remove calls to
1588 r_alloc_inhibit_buffer_relocation, as it is now called by
1589 maybe_unify_char, which was the cause of relocation of buffer text
1592 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1594 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1595 for the duration of call to load_charset, to avoid problems with
1596 callers of maybe_unify_char that access buffer text through C
1599 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1600 decrement the inhibition flag, instead of just setting or
1603 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1605 Remove obsolete '#define static' cruft.
1606 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1607 This #undef was "temporary" in 2000; it is no longer needed
1608 now that '#define static' has gone away.
1609 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1610 (gray_bitmap_bits): Remove; no longer needed.
1611 All uses replaced with definiens.
1612 * xterm.c: Include "bitmaps/gray.xbm".
1614 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1616 Clean up __executable_start, monstartup when --enable-profiling.
1617 The following changes affect the code only when profiling.
1618 * dispnew.c (__executable_start): Rename from safe_bcopy.
1619 Define only on platforms that need it.
1620 * emacs.c: Include <sys/gmon.h> when profiling.
1621 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1622 (__executable_start): Remove decl, since lisp.h does it now.
1623 (safe_bcopy): Remove decl; no longer has that name.
1624 (main): Coalesce #if into single bit of code, for simplicity.
1625 Cast pointers to uintptr_t, since standard libraries want integers
1627 * lisp.h (__executable_start): New decl.
1629 2012-05-31 Glenn Morris <rgm@gnu.org>
1631 * image.c (Fimagemagick_types): Doc fix.
1633 2012-05-30 Jim Meyering <meyering@redhat.com>
1635 * callproc.c (Fcall_process_region): Include directory component
1636 in mkstemp error message (Bug#11586).
1638 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1640 * alloc.c, lisp.h (make_pure_vector): Now static.
1642 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1644 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1645 Move to byte-run.el.
1646 (Fautoload): Do the hash-doc more carefully.
1647 * data.c (Fdefalias): Purify definition, except for keymaps.
1648 (Qdefun): Move from eval.c.
1649 * lisp.h (Qdefun): Remove.
1650 * lread.c (read1): Tiny simplification.
1652 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1654 Do not create empty overlays with the evaporate property (Bug#9642).
1655 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1656 Bug#9642, but explicitly check that the buffer the overlay would
1657 be moved to is live and rearrange lines to make sure that errors
1658 will not put the overlay in an inconsistent state.
1659 (Fdelete_overlay): Cosmetics.
1661 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1663 * w32term.c (my_bring_window_to_top): New function.
1664 (x_raise_frame): Use handle returned by DeferWindowPos, which
1665 could be different from the original one.
1666 Call my_bring_window_to_top instead of my_set_foreground_window.
1669 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1670 by calling BringWindowToTop.
1672 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1673 (WM_EMACS_END): Increase by one.
1675 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1677 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1678 This avoids undefined behavior that might cause the eassert
1679 to not catch an out-of-range value.
1681 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1683 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1684 Update dependencies.
1686 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1688 * bidi.c (bidi_mirror_char): Fix last change.
1690 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1692 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1693 when referring to sectname field in printf format.
1695 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1697 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1698 Only r_alloc_inhibit_buffer_relocation needed to be added;
1699 the others were already declared.
1701 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1702 before checking whether it's out of range. Put the check inside
1704 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1706 2012-05-27 Ken Brown <kbrown@cornell.edu>
1708 * callproc.c (Fcall_process): Restore a line that was accidentally
1709 commented out in the 2011-02-13 change (bug#11547).
1711 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1713 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1714 defined on ralloc.c.
1716 * buffer.c [REL_ALLOC]: Remove prototypes of
1717 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1718 they are now on lisp.h.
1720 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1722 * search.c (search_buffer): Use it to inhibit relocation of buffer
1723 text while re_search_2 is doing its job, because re_search_2 is
1724 passed C pointers to buffer text. (Bug#11519)
1726 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1729 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1730 state after an additional call to move_it_in_display_line_to, keep
1731 the values of it->max_ascent and it->max_descent found for the
1733 (pos_visible_p): Revert the comparison against bottom_y to what it
1734 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1737 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1739 Fix coding-related core dumps with gcc -ftrapv.
1740 The code was computing A - B, where A and B are pointers, and B is
1741 random garbage. This can lead to core dumps on platforms that
1742 have special pointer registers, and it also leads to core dumps on
1743 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1744 A - B only when B is initialized properly.
1745 * coding.c (coding_set_source, coding_set_destination): Return void.
1746 (coding_change_source, coding_change_destinations): New functions,
1747 with the old behaviors of coding_set_source and coding_set_destination.
1748 All callers that need an offset changed to use these new functions.
1750 2012-05-26 Glenn Morris <rgm@gnu.org>
1752 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1754 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1756 Extend mouse support on W32 text-mode console.
1757 * xdisp.c (draw_row_with_mouse_face):
1758 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1760 * w32console.c: Include window.h.
1761 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1763 (initialize_w32_display): Initialize mouse-highlight data.
1765 * w32inevt.c: Include termchar.h and window.h.
1766 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1767 moves, call note_mouse_highlight. If help_echo changed, call
1768 gen_help_event to produce help-echo message in the echo area.
1769 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1772 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1774 * lread.c (read1): Simplify slightly to avoid an overflow warning
1775 with GCC 4.7.0 on x86-64.
1777 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1779 * bidi.c (bidi_mirror_char): Revert last change: an int is
1780 definitely wide enough here.
1782 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1784 Fix integer width and related bugs (Bug#9874).
1785 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1786 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1787 (string_bytes, check_sblock, allocate_string_data):
1788 (compact_small_strings, Fmake_bool_vector, make_string)
1789 (make_unibyte_string, make_multibyte_string)
1790 (make_string_from_bytes, make_specified_string)
1791 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1792 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 (allocate_pseudovector):
1796 Use int, not EMACS_INT, where int is wide enough.
1797 (inhibit_garbage_collection, Fgarbage_collect):
1798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1799 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1800 int might not be wide enough.
1801 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1802 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1803 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1804 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1805 (bidi_level_of_next_char, bidi_move_to_visually_next):
1806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1807 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1808 (Fkill_buffer, Fset_buffer_major_mode)
1809 (advance_to_char_boundary, Fbuffer_swap_text)
1810 (Fset_buffer_multibyte, overlays_at, overlays_in)
1811 (overlay_touches_p, struct sortvec, record_overlay_string)
1812 (overlay_strings, recenter_overlay_lists)
1813 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1814 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1815 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1816 (Foverlay_recenter, last_overlay_modification_hooks_used)
1817 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1819 (validate_region): Omit unnecessary test for b <= e,
1820 since that's guaranteed by the previous test.
1821 (adjust_overlays_for_delete): Avoid pos + length overflow.
1822 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1823 (report_overlay_modification):
1824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1825 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1826 Omit pointer cast, which isn't needed anyway, and doesn't work
1827 after the EMACS_INT -> ptrdiff_t change.
1828 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1829 * buffer.h: Adjust decls to match defn changes elsewhere.
1830 (struct buffer_text, struct buffer):
1831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1832 Use EMACS_INT, not int, where int might not be wide enough.
1833 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1834 not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (exec_byte_code): Use tighter memory-full test, one that checks
1836 for alloca overflow. Don't compute the address of the object just
1837 before an array, as that's not portable. Use EMACS_INT, not
1838 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1839 * callint.c (Fcall_interactively):
1840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1841 * callproc.c (call_process_kill, Fcall_process):
1842 Don't assume pid_t fits into an Emacs fixnum.
1843 (call_process_cleanup, Fcall_process, child_setup):
1844 Don't assume pid_t fits into int.
1845 (call_process_cleanup, Fcall_process, delete_temp_file)
1846 (Fcall_process_region):
1847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1848 (Fcall_process): Simplify handling of volatile integers.
1849 Use int, not EMACS_INT, where int will do.
1850 * casefiddle.c (casify_object, casify_region, operate_on_word)
1851 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 (casify_object): Avoid integer overflow when overallocating buffer.
1854 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1855 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1856 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1857 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1858 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1859 integers are now checked earlier. All uses replaced with XINT.
1861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1862 For CCL_MapSingle, check that content and value are in int range.
1863 (ccl_driver, Fregister_code_conversion_map):
1864 Check that Vcode_version_map_vector is a vector.
1865 (resolve_symbol_ccl_program): Check that vector header is in range.
1866 Always copy the vector, so that we can check its contents reliably
1867 now rather than having to recheck each instruction as it's being
1868 executed. Check that vector words fit in 'int'.
1869 (ccl_get_compiled_code, Fregister_ccl_program)
1870 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1871 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1872 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1873 contents are in range.
1874 (Fccl_execute_on_string): Check that status is in range.
1875 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1876 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1877 Accept and return EMACS_INT, not int, because callers can pass values
1879 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1880 (multibyte_chars_in_text, parse_str_as_multibyte)
1881 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1882 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1883 (string_escape_byte8, Fget_byte):
1884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1885 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1886 avoid mishandling large integers.
1887 * character.h: Adjust decls to match defn changes elsewhere.
1888 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1889 (Ffind_charset_region):
1890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1891 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1892 (load_charset_map_from_vector, Fdefine_charset_internal):
1893 Don't assume fixnum fits in int.
1894 (load_charset_map_from_vector, Fmap_charset_chars):
1895 Remove now-unnecessary CHECK_NATNUMs.
1896 (Fdefine_charset_internal): Check ranges here, more carefully.
1897 Don't rely on undefined behavior with signed left shift overflow.
1898 Don't assume unsigned int fits into fixnum, or that fixnum fits
1899 into unsigned int. Don't require max_code to be a valid fixnum;
1900 that's not true for gb10830 4-byte on a 32-bit host. Allow
1901 invalid_code to be a cons, for the same reason. Require code_offset
1902 to be a character. Avoid int overflow if max_char is close
1904 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1905 this is intended anyway and avoids some undefined behavior.
1906 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1907 INDEX_TO_CODE_POINT, as that's what it expects.
1908 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1909 * charset.h (DECODE_CHAR): Return int, not unsigned;
1910 this is what was intended anyway, and it avoids undefined behavior.
1911 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1912 integer-overflow issues.
1913 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1914 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1915 where the argument is EMACS_INT, and this behavior is not intended.
1916 * chartab.c (Fmake_char_table, Fset_char_table_range)
1917 (uniprop_get_decoder, uniprop_get_encoder):
1918 Don't assume fixnum fits in int.
1919 * cmds.c (move_point): New function, that does the gist of
1920 Fforward_char and Fbackward_char, but does so while checking
1921 for integer overflow more accurately.
1922 (Fforward_char, Fbackward_char): Use it.
1923 (Fforward_line, Fend_of_line, internal_self_insert)
1924 (internal_self_insert):
1925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1926 Fix a FIXME, by checking for integer overflow when calculating
1927 target_clm and actual_clm.
1928 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1929 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1930 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1931 (coding_alloc_by_making_gap, alloc_destination)
1932 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1933 (encode_coding_utf_16, detect_coding_emacs_mule)
1934 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1935 (detect_coding_iso_2022, decode_coding_iso_2022)
1936 (encode_invocation_designation, encode_designation_at_bol)
1937 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1938 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1939 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1940 (encode_coding_ccl, encode_coding_raw_text)
1941 (detect_coding_charset, decode_coding_charset)
1942 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1943 (produce_composition, produce_charset, produce_annotation)
1944 (decode_coding, handle_composition_annotation)
1945 (handle_charset_annotation, consume_chars, decode_coding_gap)
1946 (decode_coding_object, encode_coding_object, detect_coding_system)
1947 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1948 (code_convert_region, code_convert_string)
1949 (Fdefine_coding_system_internal)
1950 (coding_set_source, coding_set_destination):
1951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1952 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1953 (Fdefine_coding_system_internal):
1954 Don't assume fixnums fit in int.
1955 (decode_coding_gap, decode_coding_object, encode_coding_object)
1956 (Fread_coding_system, Fdetect_coding_region)
1957 (Funencodable_char_position, Fcheck_coding_systems_region)
1958 (get_translation, handle_composition_annotation, consume_chars):
1959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1960 (consume_chars): Rewrite to not calculate an address outside buffer.
1961 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1962 Don't access memory outside of the args array.
1963 (Fdefine_coding_system_internal): Check for charset-id overflow.
1964 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1965 result of ENCODE_CHAR.
1966 * coding.h: Adjust decls to match defn changes elsewhere.
1967 (struct coding_system):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 * composite.c (get_composition_id, find_composition)
1970 (run_composition_function, update_compositions)
1971 (compose_text, composition_gstring_put_cache)
1972 (composition_gstring_p, composition_gstring_width)
1973 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1974 (composition_compute_stop_pos, composition_reseat_it)
1975 (composition_update_it, struct position_record)
1976 (find_automatic_composition, composition_adjust_point)
1977 (Fcomposition_get_gstring, Ffind_composition_internal):
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 (update_compositions):
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 * composite.h: Adjust decls to match defn changes elsewhere.
1982 (struct composition):
1983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1984 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1985 Do not attempt to compute the address of the object just before a
1986 buffer; this is not portable.
1988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1989 (Faset): Use int, not EMACS_INT, where int is wide enough.
1990 (Fstring_to_number): Don't assume fixnums fit in int.
1991 (Frem): Don't assume arg is nonnegative.
1992 * dbusbind.c (xd_append_arg): Check for integers out of range.
1993 (Fdbus_call_method): Don't overflow the timeout int.
1994 (extract_signed, extract_unsigned): New functions.
1995 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1996 (xd_get_connection_references): Return ptrdiff_t, not int.
1998 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1999 (xd_read_message_1):
2000 Use int, not unsigned, where the dbus API uses int.
2001 (Fdbus_message_internal): Don't overflow mtype.
2002 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2003 * dired.c (directory_files_internal, file_name_completion, scmp)
2004 (file_name_completion_stat):
2005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2006 (file_name_completion): Don't overflow matchcount.
2007 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2008 * dispextern.h: Adjust decls to match defn changes elsewhere.
2009 (struct text_pos, struct glyph, struct bidi_saved_info)
2010 (struct bidi_string_data, struct bidi_it, struct composition_it)
2012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2013 (struct display_pos, struct composition_it, struct it):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 * dispnew.c (increment_matrix_positions)
2016 (increment_row_positions, mode_line_string)
2017 (marginal_area_string):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2019 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 (duration_to_sec_usec): New function, to check for overflow better.
2022 (Fsleep_for, sit_for): Use it.
2023 * doc.c (get_doc_string, store_function_docstring):
2024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2025 (get_doc_string, Fsnarf_documentation):
2026 Use int, not EMACS_INT, where int is wide enough.
2028 Use SAFE_ALLOCA, not alloca.
2029 Check for overflow when converting EMACS_INT to off_t.
2030 * doprnt.c (doprnt):
2031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2032 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2033 Don't assume uid_t fits into fixnum.
2034 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2035 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2036 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2037 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2038 (general_insert_function)
2039 (Finsert_char, make_buffer_string, make_buffer_string_both)
2040 (update_buffer_properties, Fbuffer_substring)
2041 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2042 (Fsubst_char_in_region, check_translation)
2043 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2044 (transpose_markers, Ftranspose_regions):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2046 (clip_to_bounds): Move to lisp.h as an inline function).
2047 (Fconstrain_to_field): Don't assume integers are nonnegative.
2048 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2049 (Fsubst_char_in_region, Fsave_restriction):
2050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2051 (Femacs_pid): Don't assume pid_t fits into fixnum.
2052 (lo_time): Use int, not EMACS_INT, when int suffices.
2053 (lisp_time_argument): Check for usec out of range.
2054 (Fencode_time): Don't assume fixnum fits in int.
2055 (Fuser_login_name, Fuser_full_name): Signal an error
2056 if a uid argument is out of range, rather than relying on
2058 (Fformat_time_string): Remove now-unnecessary check.
2059 lisp_time_argument checks for out-of-range usec now.
2060 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2061 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2062 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2063 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2064 (init_cmdargs, Fdump_emacs):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2067 the bottom (typically) 32 bits of the fixnum.
2068 * eval.c (specpdl_size, call_debugger):
2069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2070 (when_entered_debugger, Fbacktrace_debug):
2071 Don't assume fixnum can fit in int.
2072 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2073 the object just before a buffer; this is not portable.
2074 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2075 (grow_specpdl, unbind_to):
2076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2077 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2078 (grow_specpdl): Simplify allocation by using xpalloc.
2079 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2080 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2081 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2083 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2086 (Fcopy_file, non_regular_nbytes, read_non_regular)
2087 (Finsert_file_contents):
2088 Use int, not EMACS_INT, where int is wide enough.
2089 (READ_BUF_SIZE): Verify that it fits in int.
2090 (Finsert_file_contents): Check that counts are in proper range,
2091 rather than assuming fixnums fit into ptrdiff_t etc.
2092 Don't assume fixnums fit into int.
2093 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2094 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2095 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2096 (string_char_to_byte, string_byte_to_char)
2097 (string_make_multibyte, string_to_multibyte)
2098 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2099 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2100 (substring_both, Fdelete, internal_equal, Ffillarray)
2101 (Fclear_string, mapcar1)
2102 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2103 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2104 (larger_vector, make_hash_table, maybe_resize_hash_table)
2105 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2106 (Fmaphash, secure_hash):
2107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2108 (concat): Check for string index and length overflow.
2109 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2112 (larger_vector): New API (vec, incr_min, size_max) replaces old
2113 one (vec, new_size, init). This catches size overflow.
2114 INIT was removed because it was always Qnil.
2115 All callers changed.
2116 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2117 the upper bound on a hash table index size.
2118 (make_hash_table, maybe_resize_hash_table): Use it.
2119 (secure_hash): Computer start_byte and end_byte only after
2120 they're known to be in ptrdiff_t range.
2121 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2122 (Ffont_get_glyphs, Ffont_at):
2123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2124 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2125 (Flist_fonts, Fopen_font):
2126 Don't assume fixnum can fit in int.
2127 (check_gstring): Don't assume index can fit in int.
2128 (font_match_p): Check that fixnum is a character, not a nonnegative
2129 fixnum, since the later code needs to stuff it into an int.
2130 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2131 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2132 conversion overflow issues.
2133 (Fopen_font): Check for integer out of range.
2134 (Ffont_get_glyphs): Don't assume index can fit in int.
2135 * font.h: Adjust decls to match defn changes elsewhere.
2136 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2138 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2139 printmax_t, where ptrdiff_t is wide enough.
2140 (Finternal_char_font):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2143 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2144 (Fset_frame_position, x_set_frame_parameters)
2145 (x_set_line_spacing, x_set_border_width)
2146 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2147 Check that fixnums are in proper range for system types.
2148 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2151 Use SAFE_ALLOCA_LISP, not alloca.
2152 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2153 intptr_t is wide enough.
2154 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2155 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2156 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2157 Check for fixnum out of range.
2158 * ftfont.c (ftfont_list): Don't assume index fits in int.
2159 Check that fixnums are in proper range for system types.
2160 (ftfont_shape_by_flt):
2161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2162 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2164 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2165 Check that fixnums are in proper range for system types.
2166 * gnutls.h: Adjust decls to match defn changes elsewhere.
2167 * gtkutil.c (xg_dialog_run):
2168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2169 (update_frame_tool_bar):
2170 Check that fixnums are in proper range for system types.
2171 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2172 (lookup_image): Check that fixnums are in range for system types.
2173 * indent.c (last_known_column, last_known_column_point):
2174 (current_column_bol_cache):
2175 (skip_invisible, current_column, check_display_width):
2176 (check_display_width, scan_for_column, current_column_1)
2177 (Findent_to, Fcurrent_indentation, position_indentation)
2178 (indented_beyond_p, Fmove_to_column, compute_motion):
2179 (Fcompute_motion, Fvertical_motion):
2180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2181 (last_known_column_modified): Use EMACS_INT, not int.
2182 (check_display_width):
2184 Check that fixnums and floats are in proper range for system types.
2185 (compute_motion): Don't assume index or fixnum fits in int.
2186 (compute_motion, Fcompute_motion):
2187 Use int, not EMACS_INT, when it is wide enough.
2188 (vmotion): Omit local var start_hpos that is always 0; that way
2189 we don't need to worry about overflow in expressions involving it.
2190 * indent.h: Adjust decls to match defn changes elsewhere.
2192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2193 Use int, not EMACS_INT, where int is wide enough.
2194 Remove unused members ovstring_chars_done and tab_offset;
2196 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2197 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2198 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2199 (make_gap, copy_text, insert, insert_and_inherit)
2200 (insert_before_markers, insert_before_markers_and_inherit)
2201 (insert_1, count_combining_before, count_combining_after)
2202 (insert_1_both, insert_from_string)
2203 (insert_from_string_before_markers, insert_from_string_1)
2204 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2205 (adjust_after_replace, adjust_after_insert, replace_range)
2206 (replace_range_2, del_range, del_range_1, del_range_byte)
2207 (del_range_both, del_range_2, modify_region)
2208 (prepare_to_modify_buffer, signal_before_change)
2209 (signal_after_change, Fcombine_after_change_execute):
2210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2211 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2212 (balance_an_interval, split_interval_right, split_interval_left)
2213 (find_interval, next_interval, update_interval)
2214 (adjust_intervals_for_insertion, delete_node, delete_interval)
2215 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2216 (static_offset_intervals, offset_intervals)
2217 (merge_interval_right, merge_interval_left, make_new_interval)
2218 (graft_intervals_into_buffer, temp_set_point_both)
2219 (temp_set_point, set_point, adjust_for_invis_intang)
2220 (set_point_both, move_if_not_intangible, get_property_and_range)
2221 (get_local_map, copy_intervals, copy_intervals_to_string)
2222 (compare_string_intervals, set_intervals_multibyte_1):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 * intervals.h: Adjust decls to match defn changes elsewhere.
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 * keyboard.c (this_command_key_count, this_single_command_key_start)
2228 (before_command_key_count, before_command_echo_length, echo_now)
2229 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2230 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2231 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2232 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (last_non_minibuf_size, last_point_position, echo_truncate)
2235 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2236 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2237 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2238 (stuff_buffered_input):
2239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2240 (last_auto_save, command_loop_1, read_char):
2241 Use EMACS_INT, not int, to avoid integer overflow.
2242 (record_char): Avoid overflow in total_keys computation.
2243 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2244 * keyboard.h: Adjust decls to match defn changes elsewhere.
2245 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2246 (Fkey_description, Fdescribe_vector, Flookup_key):
2247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2248 (click_position): New function, to check that positions are in range.
2249 (Fcurrent_active_maps):
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2252 (Faccessible_keymaps, Fkey_description):
2253 (preferred_sequence_p):
2254 Don't assume fixnum can fit into int.
2255 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2256 Check for integer overflow in size calculations.
2257 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2258 avoid mishandling large integers.
2259 * lisp.h: Adjust decls to match defn changes elsewhere.
2260 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2261 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2262 (struct Lisp_Marker):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2264 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2265 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2266 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2267 All callers changed.
2268 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2269 Assume the arg has valid form, since it always does.
2270 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2271 unsigned integer system type.
2272 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2273 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2275 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2276 (duration_to_sec_usec): New decl.
2277 * lread.c (read_from_string_index, read_from_string_index_byte)
2278 (read_from_string_limit, readchar, unreadchar, openp)
2279 (read_internal_start, read1, oblookup):
2280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2281 (Fload, readevalloop, Feval_buffer, Feval_region):
2282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2283 (openp): Check for out-of-range argument to 'access'.
2284 (read1): Use int, not EMACS_INT, where int is wide enough.
2285 Don't assume fixnum fits into int.
2286 Fix off-by-one error that can read outside a buffer.
2287 (read_filtered_event): Use duration_to_sec_usec
2288 to do proper overflow checking on durations.
2289 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2290 in size calculation.
2291 (Fexecute_kbd_macro):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2294 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2295 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2296 (set_marker_both, set_marker_restricted_both, marker_position)
2297 (marker_byte_position, Fbuffer_has_markers_at):
2298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2299 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2300 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2301 It now merely ensures that the menu is large enough, without
2302 necessarily growing it, as this avoids some integer overflow issues.
2303 All callers changed.
2304 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2306 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2307 Use SAFE_ALLOCA_LISP, not alloca.
2308 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2309 to EMACS_INT. Check that fixnums are in proper range for system types.
2310 * minibuf.c (minibuf_prompt_width, string_to_object)
2311 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2312 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (get_minibuffer, read_minibuf_unwind):
2315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2317 this simplifies overflow checking. All callers changed.
2318 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2321 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2322 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2323 Check that fixnums are in proper range for system types.
2324 (Fx_create_frame, Fx_show_tip):
2325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2326 * nsfont.m (ns_findfonts, nsfont_list_family):
2327 Don't assume fixnum fits in long.
2328 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2330 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2332 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2334 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2335 (PRINTDECLARE, PRINTPREPARE):
2336 (strout, print_string):
2337 (print, print_preprocess, print_check_string_charset_prop)
2339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2341 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2344 (printchar, strout): Use xpalloc to catch size calculation overflow.
2345 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2346 (print_error_message): Use SAFE_ALLOCA, not alloca.
2347 (print_object): Use int, not EMACS_INT, where int is wide enough.
2348 (print_depth, new_backquote_output, print_number_index):
2349 Use ptrdiff_t, not int, where int might not be wide enough.
2350 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2351 (Fset_process_window_size, Fformat_network_address)
2352 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2354 Check that fixnums are in proper range for system types.
2355 (Fsignal_process): Simplify by avoiding a goto.
2356 Check for process-ids out of pid_t range rather than relying on
2358 (process_tick, update_tick): Use EMACS_INT, not int.
2359 (Fformat_network_address, read_process_output, send_process)
2360 (Fprocess_send_region, status_notify):
2361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2362 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2363 (wait_reading_process_output, read_process_output, exec_sentinel):
2364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2365 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2366 (Faccept_process_output): Use duration_to_sec_usec to do proper
2367 overflow checking on durations.
2368 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2369 Don't assume pid_t fits in int.
2370 * process.h (struct Lisp_Process): Members tick and update_tick
2371 are now of type EMACS_INT, not int.
2372 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2373 configured --with-wide-int.
2374 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2375 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2376 * search.c (looking_at_1, string_match_1):
2377 (fast_string_match, fast_c_string_match_ignore_case)
2378 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2379 (scan_newline, find_before_next_newline, search_command)
2380 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2381 (set_search_regs, wordify):
2384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2385 (string_match_1, search_buffer, set_search_regs):
2387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2388 (wordify): Check for overflow in size calculation.
2389 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2390 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2391 Check that fixnums are in proper range for system types.
2392 * sound.c (struct sound_device)
2393 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2395 (Fplay_sound_internal):
2396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2397 * syntax.c (struct lisp_parse_state, find_start_modiff)
2398 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2399 (Fparse_partial_sexp):
2400 Don't assume fixnums can fit in int.
2401 (struct lisp_parse_state, find_start_pos, find_start_value)
2402 (find_start_value_byte, find_start_begv)
2403 (update_syntax_table, char_quoted, dec_bytepos)
2404 (find_defun_start, prev_char_comend_first, back_comment):
2405 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2406 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 (Finternal_describe_syntax_value): Check that match_lisp is a
2409 character, not an integer, since the code stuffs it into int.
2410 (scan_words, scan_sexps_forward):
2411 Check that fixnums are in proper range for system types.
2413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2414 (scan_sexps_forward):
2415 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2416 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2417 * syntax.h: Adjust decls to match defn changes elsewhere.
2418 (struct gl_state_s):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2421 MOST_POSITIVE_FIXNUM.
2422 * sysdep.c (wait_for_termination_1, wait_for_termination)
2423 (interruptible_wait_for_termination, mkdir):
2424 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2425 (emacs_read, emacs_write):
2426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2427 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2428 and double all fit in int.
2429 * term.c (set_tty_color_mode):
2430 Check that fixnums are in proper range for system types.
2431 * termhooks.h (struct input_event):
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 * textprop.c (validate_interval_range, interval_of)
2434 (Fadd_text_properties, set_text_properties_1)
2435 (Fremove_text_properties, Fremove_list_of_text_properties)
2436 (Ftext_property_any, Ftext_property_not_all)
2437 (copy_text_properties, text_property_list, extend_property_ranges)
2438 (verify_interval_modification):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 (Fnext_single_char_property_change)
2441 (Fprevious_single_char_property_change):
2442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2443 (copy_text_properties):
2444 Check for integer overflow in index calculation.
2445 * undo.c (last_boundary_position, record_point, record_insert)
2446 (record_delete, record_marker_adjustment, record_change)
2447 (record_property_change):
2448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2449 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2451 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2452 (Fx_hide_tip, Fx_file_dialog):
2453 * w32menu.c (set_frame_menubar):
2454 Use ptrdiff_t, not int, for consistency with rest of code.
2455 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2456 (select_window, Fdelete_other_windows_internal)
2457 (window_scroll_pixel_based, window_scroll_line_based)
2458 (Frecenter, Fset_window_configuration):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (Fset_window_hscroll, run_window_configuration_change_hook)
2461 (set_window_buffer, temp_output_buffer_show, scroll_command)
2462 (Fscroll_other_window, Frecenter):
2463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2464 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2465 Don't assume fixnum fits in int.
2466 (Fset_window_scroll_bars):
2467 Check that fixnums are in proper range for system types.
2468 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2469 (string_pos, c_string_pos, number_of_chars, init_iterator)
2470 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2471 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2472 (compute_display_string_end, handle_face_prop)
2473 (face_before_or_after_it_pos, handle_invisible_prop)
2474 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2475 (display_prop_intangible_p, string_buffer_position_lim)
2476 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2477 (get_overlay_strings_1, get_overlay_strings)
2478 (iterate_out_of_display_property, forward_to_next_line_start)
2479 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2480 (get_next_display_element, set_iterator_to_next)
2481 (get_visually_first_element, compute_stop_pos_backwards)
2482 (handle_stop_backwards, next_element_from_buffer)
2483 (move_it_in_display_line_to, move_it_in_display_line)
2484 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2485 (add_to_log, message_dolog, message_log_check_duplicate)
2486 (message2, message2_nolog, message3, message3_nolog
2487 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2488 (current_message_1, truncate_echo_area, truncate_message_1)
2489 (set_message, set_message_1, store_mode_line_noprop)
2490 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2491 (text_outside_line_unchanged_p, check_point_in_composition)
2492 (reconsider_clip_changes)
2493 (redisplay_internal, set_cursor_from_row, try_scrolling)
2494 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2495 (redisplay_window, find_last_unchanged_at_beg_row)
2496 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2497 (trailing_whitespace_p, find_row_edges, display_line)
2498 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2499 (display_mode_element, store_mode_line_string)
2500 (pint2str, pint2hrstr, decode_mode_spec)
2501 (display_count_lines, display_string, draw_glyphs)
2502 (x_produce_glyphs, x_insert_glyphs)
2503 (rows_from_pos_range, mouse_face_from_buffer_pos)
2504 (fast_find_string_pos, mouse_face_from_string_pos)
2505 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2507 (safe_call, init_from_display_pos, handle_fontified_prop)
2508 (handle_single_display_spec, load_overlay_strings)
2509 (with_echo_area_buffer, setup_echo_area_for_printing)
2510 (display_echo_area, echo_area_display)
2511 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2512 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2513 (redisplay_window, dump_glyph_row, display_mode_line)
2514 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2515 (handle_display_spec, display_prop_string_p):
2516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 (handle_single_display_spec, build_desired_tool_bar_string)
2518 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2519 (get_specified_cursor_type):
2520 Check that fixnums are in proper range for system types.
2521 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2522 (Flookup_image_map):
2523 Don't assume fixnums fit in int.
2524 (compare_overlay_entries):
2525 Avoid mishandling comparisons due to subtraction overflow.
2526 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2527 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2528 (handle_tool_bar_click):
2529 Use int, not unsigned, since we prefer signed and the signedness
2530 doesn't matter here.
2531 (get_next_display_element, next_element_from_display_vector):
2532 Use int, not EMACS_INT, when int is wide enough.
2533 (start_hourglass): Use duration_to_sec_usec to do proper
2534 overflow checking on durations.
2535 * xfaces.c (Fbitmap_spec_p):
2536 Check that fixnums are in proper range for system types.
2537 (compare_fonts_by_sort_order):
2538 Avoid mishandling comparisons due to subtraction overflow.
2539 (Fx_family_fonts, realize_basic_faces):
2540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2542 Don't assume fixnum fits in int.
2543 Use SAFE_ALLOCA_LISP, not alloca.
2544 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2545 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2546 (face_at_buffer_position, face_for_overlay_string)
2547 (face_at_string_position):
2548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2549 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2550 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2552 Check that fixnums are in proper range for system types.
2553 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2554 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 (Fx_change_window_property): Don't assume fixnums fit in int.
2557 * xfont.c (xfont_chars_supported):
2558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2559 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2560 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 * xml.c (parse_region):
2563 * xrdb.c (magic_file_p):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2565 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2566 (x_get_local_selection, x_reply_selection_request)
2567 (x_handle_selection_request, wait_for_property_change):
2568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2569 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2570 short is wide enough.
2571 (x_send_client_event): Don't assume fixnum fits in int.
2572 * xterm.c (x_x_to_emacs_modifiers):
2573 Don't assume EMACS_INT overflows nicely into int.
2574 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2576 (handle_one_xevent): NATNUMP can eval its arg twice.
2577 (x_connection_closed):
2578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2579 * xterm.h: Adjust decls to match defn changes elsewhere.
2580 (struct scroll_bar): Use struct vectorlike_header
2581 rather than rolling our own approximation.
2582 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2584 2012-05-25 Glenn Morris <rgm@gnu.org>
2586 * lisp.mk (lisp): Update for more files being compiled now.
2588 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2590 * lread.c: Remove `read_pure' which makes no difference.
2591 (read_pure): Remove var.
2592 (unreadpure): Remove function.
2593 (readevalloop): Don't call read_list with -1 flag.
2594 (read1, read_vector): Don't test read_pure any more.
2595 (read_list): Simplify.
2597 * fileio.c, character.h: Minor style tweaks.
2599 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2601 * window.h (clip_changed): Remove useless declaration.
2603 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2605 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2606 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2608 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2611 This directory predates autoconf and is no longer needed nowadays.
2612 Move its few remaining bits of functionality to where they're needed.
2613 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2614 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2615 * m/template.h: Remove.
2616 * Makefile.in (M_FILE): Remove. All uses removed.
2617 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2618 * lisp.h (USE_LSB_TAG):
2619 * mem-limits.h (EXCEEDS_LISP_PTR):
2620 Use VAL_MAX, not VALBITS, in #if.
2621 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2622 (EMACS_UINT): Define unconditionally now.
2623 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2624 (BITS_PER_EMACS_INT): New constants, replacing
2625 what used to be in config.h, but not useful in #if.
2626 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2627 define them any more.
2628 (VAL_MAX): New macro.
2630 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2631 BITS_PER_EMACS_INT, in #if.
2632 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2633 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2634 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2635 * s/ms-w32.h (DATA_START):
2636 Move here from removed file m/intel386.h.
2637 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2638 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2640 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2642 Assume C89 or later.
2643 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2644 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2646 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2647 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2648 * textprop.c, tparam.c (NULL): Remove.
2649 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2650 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2651 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2652 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2653 * xterm.c (input_signal_count): Assume volatile works.
2655 2012-05-21 Ken Brown <kbrown@cornell.edu>
2657 * xgselect.c (xg_select): Fix first argument in call to 'select'
2660 2012-05-20 Ken Brown <kbrown@cornell.edu>
2662 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2663 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2665 2012-05-19 Ken Brown <kbrown@cornell.edu>
2667 * xfns.c (x_in_use): Remove `static' qualifier.
2668 * xterm.h (x_in_use): Declare.
2669 * xgselect.c: Include xterm.h.
2670 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2671 and `display_arg' (bug#9754).
2673 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2675 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2677 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2678 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2680 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2682 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2684 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2685 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2687 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2688 reference to image_cache->refcount.
2689 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2691 2012-05-17 Juri Linkov <juri@jurta.org>
2693 * search.c (Fword_search_regexp, Fword_search_backward)
2694 (Fword_search_forward, Fword_search_backward_lax)
2695 (Fword_search_forward_lax): Move functions to isearch.el
2696 (bug#10145, bug#11381).
2698 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2700 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2702 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2704 * lread.c (init_obarray): Declare Qt and Qnil as special.
2706 2012-05-14 Glenn Morris <rgm@gnu.org>
2708 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2709 Put "libexec" before "bin", for the sake of init_callproc_1.
2711 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2713 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2715 * unexaix.c: Port to more-recent AIX compilers.
2716 (report_error, report_error_1, make_hdr, copy_sym)
2717 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2718 Make arguments const char *, not char *, to avoid violations of C
2719 standard and to fix some AIX warnings reported by Gilles Pion.
2721 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2723 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2724 already have overlays loaded.
2725 (handle_single_display_spec): Before returning without displaying
2726 fringe bitmap, synchronize the bidi iterator with the main display
2727 iterator, by calling iterate_out_of_display_property.
2728 (iterate_out_of_display_property): Detect buffer iteration by
2729 testing that it->string is a Lisp string.
2730 (get_next_display_element): When the current object is exhausted,
2731 and there's something on it->stack, call set_iterator_to_next to
2732 proceed with what's on the stack, instead of returning zero.
2733 (set_iterator_to_next): If called at the end of a Lisp string,
2734 proceed to consider_string_end without incrementing string
2735 position. Don't increment display vector index past the end of
2736 the display vector. (Bug#11417)
2737 (pos_visible_p): Don't report a position visible when move_it_to
2738 stopped at the last line of window, which happens to be scanned
2739 backwards by the bidi iteration. (Bug#11464)
2741 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2743 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2744 and right-margin display specs even if the spec is invalid or we
2745 are on a TTY, and thus unable to display on the fringes.
2746 That's because the text with the property will not be displayed anyway,
2747 so we need to signal to the caller that this is a "replacing"
2748 display spec. This fixes display when the spec is invalid or we
2751 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2753 * unexaix.c (make_hdr): Fix typo in prototype.
2754 This bug broke the build on AIX. Problem reported by Gilles Pion.
2756 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2758 * keyboard.c (kbd_buffer_get_event): Read special events also in
2759 batch mode. (Bug#11415)
2761 2012-05-12 Glenn Morris <rgm@gnu.org>
2763 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2765 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2767 * lisp.mk (lisp): Add newcomment.elc.
2769 2012-05-12 Glenn Morris <rgm@gnu.org>
2771 * Makefile.in (MKDIR_P): New, set by configure.
2772 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2774 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2776 Remove unused function hourglass_started.
2777 * dispextern.h (hourglass_started):
2778 * w32fns.c (hourglass_started):
2779 * xdisp.c (hourglass_started): Remove.
2781 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2783 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2784 Update dependencies.
2786 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2788 * xgselect.c (xg_select): Put maxfds+1 into a var.
2789 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2791 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2793 2012-05-10 Dave Abrahams <dave@boostpro.com>
2795 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2796 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2798 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2800 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2801 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2802 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2803 Initialize xd_registered_buses.
2805 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2807 Untag more efficiently if USE_LSB_TAG.
2808 This is based on a proposal by YAMAMOTO Mitsuharu in
2809 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2810 For an admittedly artificial (nth 8000 longlist) benchmark on
2811 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2812 Emacs's overall text size by 1%.
2813 * lisp.h (XUNTAG): New macro.
2814 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2815 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2816 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2817 * eval.c (Fautoload):
2818 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2819 * frame.h (XFRAME): Use XUNTAG.
2821 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2822 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2823 Remove unportable assumptions about print widths of types like
2825 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2826 intptr_t when converting between pointer and integer, to avoid GCC
2827 warnings about wrong width.
2829 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2831 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2832 stack for each reader_thread, instead of defaulting to 8MB
2833 determined by the linker. This avoids failures in creating
2834 subprocesses on Windows 7, see the discussion in this thread:
2835 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2837 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2839 Fix up display of the *Minibuf-0* buffer in the mini window.
2840 * keyboard.c (read_char): Don't clear the echo area if there's no
2842 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2843 contents of *Minibuf-0*) if there's no message displayed in its stead.
2845 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2847 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2850 2012-05-06 Chong Yidong <cyd@gnu.org>
2852 * lisp.mk (lisp): Update.
2854 2012-05-05 Jim Meyering <meyering@redhat.com>
2856 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2858 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2860 * data.c (PUT_ERROR): New macro.
2861 (syms_of_data): Use it. Add new error type `user-error'.
2862 * undo.c (user_error): New function.
2863 (Fprimitive_undo): Use it.
2864 * print.c (print_error_message): Adjust print style for `user-error'.
2865 * keyboard.c (user_error): New function.
2866 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2868 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2870 Do not limit current-time-string to years 1000..9999.
2871 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2872 (Fcurrent_time_string): Support any year that is supported by the
2873 underlying localtime representation. Don't use asctime, as it
2874 has undefined behavior for years outside the range -999..9999.
2876 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2878 Fix race conditions involving setenv, gmtime, localtime, asctime.
2879 Without this fix, interrupts could mess up code that uses these
2880 nonreentrant functions, since setting TZ invalidates existing
2881 tm_zone or tzname values, and since most of these functions return
2882 pointers to static storage.
2883 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2884 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2885 Grow the critical sections to include not just invoking
2886 localtime/gmtime, but also accessing these functions' results
2887 including their tm_zone values if any, and any related TZ setting.
2888 (format_time_string): Last arg is now struct tm *, not struct tm **,
2889 so that the struct tm is saved in the critical section.
2890 All callers changed. Simplify allocation of initial buffer, partly
2891 motivated by the fact that memory allocation needs to be outside
2892 the critical section.
2894 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2896 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2897 with RESET_INTERVAL.
2899 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2900 Remove duplicated buffer name initialization.
2902 2012-05-02 Jim Meyering <jim@meyering.net>
2904 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2906 * xfns.c (x_window): Use xstrdup (Bug#11375).
2908 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2910 * xdisp.c (pos_visible_p): If already at a newline from the
2911 display string before the 'while' loop, don't walk back the glyphs
2912 from it3.glyph_row. Solves assertion violation when the display
2913 string begins with a newline (egg.el). (Bug#11367)
2915 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2917 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2920 2012-05-01 Glenn Morris <rgm@gnu.org>
2922 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2923 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2924 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2925 All were removed before 23.1.
2927 * dispnew.c: Remove HAVE_LIBNCURSES test;
2928 it is always true on relevant platforms.
2930 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2931 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2933 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2935 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2937 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2938 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2941 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2943 Do not avoid creating empty evaporating overlays (Bug#9642).
2944 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2945 That is, do not delete an evaporating overlay if it becomes
2946 empty after its bounds are adjusted to fit within its buffer.
2947 This fix caused other problems, and I'm reverting it until we get
2948 to the bottom of them.
2950 2012-04-27 Chong Yidong <cyd@gnu.org>
2952 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2954 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2956 * xdisp.c (pos_visible_p): If the window start position is beyond
2957 ZV, start the display from buffer beginning. Prevents assertion
2958 violation in init_iterator when the minibuffer window is scrolled
2961 * window.c (window_scroll_pixel_based): Likewise.
2963 2012-04-27 Chong Yidong <cyd@gnu.org>
2965 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2967 2012-04-27 Glenn Morris <rgm@gnu.org>
2969 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2970 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2972 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2974 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2975 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2977 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2979 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2980 display element, check also the underlying string or buffer
2981 character. (Bug#11341)
2983 * w32menu.c: Include w32heap.h.
2984 (add_menu_item): If the call to AppendMenuW (via
2985 unicode_append_menu) fails, disable Unicode menus only if we are
2986 running on Windows 9X/Me.
2988 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2990 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2991 (xgetint): Add missing shift for LSB tags.
2993 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2995 * keyboard.c (read_char): Don't wipe echo area for select window
2996 events: These might get delayed via `mouse-autoselect-window'
2999 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3001 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3002 manipulation of :loaded-from data.
3004 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3006 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3007 now a cons (bug#11311).
3009 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3011 Do not create empty overlays with the evaporate property (Bug#9642).
3012 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3013 if it becomes empty after its bounds are adjusted to fit within
3014 its buffer. Without this fix, in a nonempty buffer (let ((o
3015 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3016 yields an empty overlay that has the evaporate property, which is
3017 not supposed to happen.
3019 Fix minor GTK3 problems found by static checking.
3020 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3021 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3022 (struct _EmacsFixedClass, emacs_fixed_get_type):
3023 Move decls here from emacsgtkfixed.h, since they needn't be public.
3024 (emacs_fixed_get_type): Now static.
3025 (emacs_fixed_class_init): Omit unused local.
3026 (emacs_fixed_child_type): Remove; unused.
3027 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3028 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3029 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3030 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3031 (EMACS_FIXED_GET_CLASS): Remove; unused.
3032 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3034 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3035 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3037 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3039 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3040 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3041 (__malloc_size_t, __malloc_ptrdiff_t):
3042 Remove. All uses removed, replaced by the definiens if needed,
3043 since we can assume C89 or better now.
3044 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3045 (protect_malloc_state, align, get_contiguous_space)
3046 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3047 (malloc_atfork_handler_child, malloc_enable_thread)
3048 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3049 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3050 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3051 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3052 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3053 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3054 Define using prototypes, not old style.
3055 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3056 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3057 (align): Don't assume that signed integer overflow wraps around.
3058 Omit unused local var.
3059 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3060 (_free_internal_nolock, memalign, mallochook, reallochook):
3061 Omit no-longer-needed casts.
3062 (valloc): Use getpagesize, not __getpagesize.
3063 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3064 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3066 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3068 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3070 Move functions from C to Lisp. Make non-blocking method calls
3071 the default. Implement further D-Bus standard interfaces.
3073 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3074 (QCdbus_request_name_allow_replacement)
3075 (QCdbus_request_name_replace_existing)
3076 (QCdbus_request_name_do_not_queue)
3077 (QCdbus_request_name_reply_primary_owner)
3078 (QCdbus_request_name_reply_in_queue)
3079 (QCdbus_request_name_reply_exists)
3080 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3081 (QCdbus_registered_serial, QCdbus_registered_method)
3082 (QCdbus_registered_signal): New Lisp objects.
3083 (XD_DEBUG_MESSAGE): Use sizeof.
3084 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3085 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3086 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3087 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3088 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3089 (xd_signature, xd_append_arg): Allow float for integer types.
3090 (xd_get_connection_references): New function.
3091 (xd_get_connection_address): Rename from xd_initialize.
3092 Return cached address.
3093 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3094 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3096 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3097 Return number of refcounts.
3098 (Fdbus_get_unique_name): Make stronger parameter check.
3099 (Fdbus_message_internal): New defun.
3100 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3101 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3102 (Fdbus_send_signal, Fdbus_register_service)
3103 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3104 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3105 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3106 (Vdbus_compiled_version, Vdbus_runtime_version)
3107 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3108 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3109 (Vdbus_message_type_signal): New defvars.
3110 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3113 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3115 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3116 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3117 Do not assume ptrdiff_t is the same width as 'int'.
3119 * alloc.c: Handle unusual debugging option combinations.
3120 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3121 since the two debugging options are incompatible.
3122 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3124 (mem_init, mem_insert, mem_insert_fixup):
3125 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3126 (NEED_MEM_INSERT): Remove; no longer needed.
3128 2012-04-22 Leo Liu <sdl.web@gmail.com>
3130 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3132 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3134 * sysdep.c [__FreeBSD__]: Minor cleanups.
3135 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3136 Use Emacs indenting style more consistently. Avoid some casts.
3137 Use 'double' consistently rather than mixing 'float' and 'double'.
3139 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3141 * sysdep.c (list_system_processes, system_process_attributes):
3142 Add implementation for FreeBSD (Bug#5243).
3144 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3146 * lisp.mk (lisp): Update.
3148 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3150 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3151 It is never used otherwise.
3153 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3155 * print.c (print_preprocess): Only check print_depth if print-circle
3157 (print_object): Check for cycles even when print-circle is nil and
3158 print-gensym is t, but only check print_depth if print-circle is nil.
3160 2012-04-20 Chong Yidong <cyd@gnu.org>
3162 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3163 set the status to "failed" and ensure that sentinel is run.
3165 2012-04-20 Glenn Morris <rgm@gnu.org>
3167 * process.c (Fset_process_inherit_coding_system_flag)
3168 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3169 (Fmake_network_process, Fmake_serial_process): Doc fix.
3171 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3173 * xdisp.c (string_buffer_position_lim): Limit starting position to
3175 (set_cursor_from_row): If called for a mode-line or header-line
3176 row, return zero immediately.
3177 (try_cursor_movement): If inside continuation line, don't back up
3178 farther than the first row after the header line, if any.
3179 Don't consider the header-line row as "partially visible", even if
3180 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3182 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3184 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3187 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3188 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3190 configure: new option --enable-gcc-warnings (Bug#11207)
3191 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3192 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3193 (ALL_CFLAGS): Use new macros rather than old.
3194 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3195 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3196 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3197 -Wunused-result, -Wunused-variable. This should go away once
3198 the Emacs and Gnulib regex code is merged.
3199 (xmalloc, xrealloc): Now static.
3201 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3203 * dired.c (Fsystem_groups): Remove unused local.
3205 2012-04-17 Glenn Morris <rgm@gnu.org>
3207 * dired.c (Fsystem_users): Doc fix.
3209 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3211 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3212 (syms_of_dired): Add them.
3214 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3216 Fix minor alloc.c problems found by static checking.
3217 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3218 New extern decls, to avoid calling undeclared functions.
3219 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3220 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3221 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3222 (NEED_MEM_INSERT): New macro.
3223 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3224 Remove one incorrect comment and fix another.
3226 Fix minor ralloc.c problems found by static checking.
3227 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3228 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3229 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3230 (r_alloc_sbrk): Now static.
3232 Improve ralloc.c interface checking.
3233 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3234 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3235 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3236 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3237 [REL_ALLOC]: ... to here, to check interface.
3238 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3239 Remove decls. This fixes an "It stinks!".
3241 * alloc.c (which_symbols): Fix alignment issue / type clash.
3243 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3245 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3246 (struct Lisp_Misc_Any): Likewise.
3247 (struct Lisp_Free): Likewise.
3248 * alloc.c (union aligned_Lisp_Symbol): Define.
3249 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3250 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3251 (union aligned_Lisp_Misc): Define.
3252 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3253 aligned_Lisp_Misc instead of union Lisp_Misc.
3254 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3256 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3258 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3259 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3260 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3261 * s/netbsd.h, s/sol2-6.h:
3262 Remove definition of GC_MARK_STACK, since the default now works.
3263 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3264 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3265 no longer the default.
3266 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3268 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3270 * lread.c (lisp_file_lexically_bound_p):
3271 Fix hang at ";-*-\n" (bug#11238).
3273 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3275 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3276 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3278 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3280 * nsterm.m (constrainFrameRect): Always constrain when there is only
3281 one screen (Bug#10962).
3283 2012-04-13 Ken Brown <kbrown@cornell.edu>
3285 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3287 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3289 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3291 2012-04-11 Daniel Colascione <dancol@dancol.org>
3293 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3294 against is gone. It's better to use vfork now so that when Cygwin
3295 gains a new, working vfork, we use it automatically (bug#10398).
3297 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3299 * window.c (save_window_save): Obey window-point-insertion-type.
3301 2012-04-11 Glenn Morris <rgm@gnu.org>
3303 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3305 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3307 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3309 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3311 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3312 (force_quit_count): New var.
3313 (handle_interrupt): Use it.
3315 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3317 * w32.c (w32_delayed_load): Record the full path of the library
3318 being loaded (bug#10424).
3320 2012-04-09 Glenn Morris <rgm@gnu.org>
3322 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3323 not just in the obarray, before snarfing them. (Bug#11036)
3325 * Makefile.in ($(leimdir)/leim-list.el):
3326 Pass EMACS rather than BUILT_EMACS.
3328 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3330 * process.c (make_process):
3331 * process.h: Add integer `gnutls_handshakes_tried' member to
3334 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3335 Add convenience `GNUTLS_LOG2i' macro.
3337 * gnutls.c (gnutls_log_function2i): Convenience log function.
3338 (emacs_gnutls_read): Use new log functions,
3339 `gnutls_handshakes_tried' process member, and
3340 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3341 attempts per process (connection).
3343 2012-04-09 Chong Yidong <cyd@gnu.org>
3345 * eval.c (Fuser_variable_p, user_variable_p_eh)
3346 (lisp_indirect_variable): Functions deleted.
3347 (Fdefvar): Caller changed.
3349 * callint.c (Finteractive, Fcall_interactively):
3350 * minibuf.c (Fread_variable): Callers changed.
3352 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3354 * xdisp.c (set_cursor_from_row): If the display string appears in
3355 the buffer at position that is closer to point than the position
3356 after the display string, display the cursor on the first glyph of
3357 the display string. Fixes cursor display when a 'display' text
3358 property immediately follows invisible text. (Bug#11094)
3360 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3362 composite.c: use 'double' consistently
3363 * composite.c (get_composition_id): Use 'double' consistently
3364 instead of converting 'float' to 'double' and vice versa; this is
3365 easier to understand and avoids a GCC warning.
3367 2012-04-09 Glenn Morris <rgm@gnu.org>
3369 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3370 preparation for dumping it with emacs. (Bug#4789)
3371 (leimdir): New variable.
3372 ($(leimdir)/leim-list.el): New rule.
3373 (emacs$(EXEEXT)): Depend on leim-list.el.
3375 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3376 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3377 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3379 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3381 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3384 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3386 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3387 Remove unused local variable.
3389 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3391 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3392 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3393 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3394 objects, as mark_maybe_pointer will catch them otherwise.
3395 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3396 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3398 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3400 Fix typo that broke non-Windows builds.
3401 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3403 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3405 Support building on MS-Windows with libxml2.
3407 * makefile.w32-in (OBJ2): Add xml.$(O).
3408 (GLOBAL_SOURCES): Add xml.c.
3409 ($(BLD)/xml.$(O)): New dependency list.
3411 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3412 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3413 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3414 [!WINDOWSNT]: New macros.
3415 (init_libxml2_functions, libxml2_loaded_p): New functions.
3416 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3417 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3418 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3419 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3421 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3422 Call init_libxml2_functions before calling libxml2 functions.
3423 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3425 * emacs.c: Don't include libxml/parser.h.
3426 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3427 xmlCleanupParser directly.
3429 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3431 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3433 * indent.c (Fvertical_motion): If there is a display string at
3434 point, use it.vpos to compute how many lines to backtrack after
3435 move_it_to point. (Bug#11133)
3437 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3439 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3440 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3441 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3442 macros related to unification of CJK characters. For the details,
3443 see the discussion following the message here:
3444 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3446 2012-04-04 Chong Yidong <cyd@gnu.org>
3448 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3450 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3452 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3453 instead of alloca. (Bug#11138)
3455 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3457 * w32menu.c (is_simple_dialog): Properly check lisp types.
3460 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3463 position we get to after a call to move_it_to fails the
3464 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3465 only if we wind up in a string from display property. (Bug#11063)
3467 * window.c (Fdelete_other_windows_internal): Invalidate the row
3468 and column information about mouse highlight, so that redisplay
3469 restores it after reallocating the glyph matrices. (Bug#7464)
3471 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3472 string comes from a `display' text property, use the buffer
3473 position of that property as if we actually saw that position in
3475 (move_it_by_lines): Remove the assertion that
3476 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3477 violated when there's a before-string at the beginning of a line.
3480 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3482 * xdisp.c (append_space_for_newline): If the default face was
3483 remapped, use the remapped face for the appended newline.
3484 (extend_face_to_end_of_line): Use the remapped default face for
3485 extending the face to the end of the line.
3486 (display_line): Call extend_face_to_end_of_line when the default
3487 face was remapped. (Bug#11068)
3489 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3491 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3493 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3495 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3497 2012-03-27 Glenn Morris <rgm@gnu.org>
3499 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3502 2012-03-26 Kenichi Handa <handa@m17n.org>
3504 * dispextern.h (struct glyph): Fix previous change. Change the
3505 bit length of glyphless.ch to 25 (Bug#11082).
3507 2012-03-26 Chong Yidong <cyd@gnu.org>
3509 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3510 (command_loop_1): Use it; inhibit selection update for
3511 handle-select-window too (Bug#8996).
3513 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3515 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3517 2012-03-25 Kenichi Handa <handa@m17n.org>
3519 * dispextern.h (struct glyph): Change the bit length of
3520 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3522 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3524 * s/ms-w32.h (tzname): Include time.h before redirecting to
3525 _tzname. Fixes the MSVC build. (Bug#9960)
3527 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3529 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3532 * xterm.c (XTread_socket): Only modify handling_signal if
3533 !SYNC_INPUT. (Bug#11080)
3535 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3537 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3538 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3539 when fetching a multibyte character consumes more bytes than
3540 CHAR_BYTES returns, due to unification of CJK characters in
3541 string_char. (Bug#11073)
3543 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3545 * process.c (wait_reading_process_output): Handle pty disconnect
3546 by refraining from sending oneself a SIGCHLD (bug#10933).
3548 2012-03-22 Chong Yidong <cyd@gnu.org>
3550 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3552 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3553 Mark string as coming from a prefix property.
3554 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3555 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3557 2012-03-21 Chong Yidong <cyd@gnu.org>
3559 * xfaces.c (Vface_remapping_alist): Doc fix.
3561 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3563 * w32proc.c (Fw32_set_console_codepage)
3564 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3567 2012-03-20 Chong Yidong <cyd@gnu.org>
3569 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3570 to reflect default non-nil value of redisplay-dont-pause.
3572 2012-03-19 Kenichi Handa <handa@m17n.org>
3574 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3575 it fit in a valid range (Bug#11003).
3577 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3579 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3580 that is not from display property, accept the row as a "cursor
3581 row" if one of the string's character has a non-nil `cursor'
3582 property. Fixes cursor positioning when there are newlines in
3583 overlay strings, e.g. in icomplete.el. (Bug#11035)
3585 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3587 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3589 2012-03-12 Chong Yidong <cyd@gnu.org>
3591 * eval.c (inhibit_lisp_code): Rename from
3592 inhibit_window_configuration_change_hook; move from window.c.
3594 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3595 * window.c (run_window_configuration_change_hook)
3596 (syms_of_window): Callers changed.
3598 2012-03-11 Chong Yidong <cyd@gnu.org>
3600 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3602 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3604 2012-03-10 Chong Yidong <cyd@gnu.org>
3606 * frame.c (other_visible_frames): Don't assume the selected frame
3607 is visible (Bug#10955).
3609 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3611 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3613 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3615 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3616 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3619 2012-03-03 Glenn Morris <rgm@gnu.org>
3621 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3623 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3625 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3626 position past the first glyph_row that ends at ZV. (Bug#10902)
3627 (redisplay_window, next_element_from_string): Fix typos in
3629 (redisplay_window): Pass to move_it_vertically the margin in
3630 pixels, not in screen lines.
3632 2012-03-02 Glenn Morris <rgm@gnu.org>
3634 * buffer.c (buffer-list-update-hook): Doc fix.
3636 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3638 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3639 push_it before setting up the iterator for the first overlay
3640 string, even if we have an empty string loaded.
3641 (next_overlay_string): If there's an empty string on the iterator
3642 stack, pop the stack. (Bug#10903)
3644 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3646 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3647 Suggested by Stefan Monnier in
3648 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3649 * alloc.c (widen_to_Lisp_Object): New static function.
3650 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3651 and widening them to Lisp_Objects. This would work even if
3652 USE_LSB_TAG is defined and wide integers are used, which might
3653 happen in a future version of Emacs.
3655 2012-02-25 Chong Yidong <cyd@gnu.org>
3657 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3660 * xselect.c (Fx_selection_exists_p): Doc fix.
3661 (x_clipboard_manager_save_all): Print an informative message
3662 before saving to clipboard manager.
3664 2012-02-24 Chong Yidong <cyd@gnu.org>
3666 * keyboard.c (process_special_events): Handle all X selection
3667 requests in kbd_buffer, not just the next one (Bug#8869).
3669 2012-02-23 Chong Yidong <cyd@gnu.org>
3671 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3672 call when setting menu-bar-lines and tool-bar-lines parameters.
3673 (unwind_create_frame_1): New helper function.
3675 * window.c (inhibit_window_configuration_change_hook): New var.
3676 (run_window_configuration_change_hook): Obey it.
3677 (syms_of_window): Initialize it.
3679 2012-02-22 Chong Yidong <cyd@gnu.org>
3681 * xterm.c (x_draw_image_relief): Add missing type check for
3682 Vtool_bar_button_margin (Bug#10743).
3684 2012-02-21 Chong Yidong <cyd@gnu.org>
3686 * fileio.c (Vfile_name_handler_alist): Doc fix.
3688 * buffer.c (Fget_file_buffer): Protect against invalid file
3689 handler return value.
3691 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3693 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3694 when computing $valmask.
3696 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3697 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3698 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3699 It's useless in that case, and it can cause problems on hosts
3700 that allocate halves of EMACS_INT values separately.
3701 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3702 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3703 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3704 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3705 it avoids undefined behavior on hosts where shifting right by more
3706 than the word width has undefined behavior.
3708 2012-02-19 Chong Yidong <cyd@gnu.org>
3710 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3711 (Funhandled_file_name_directory, Ffile_name_as_directory)
3712 (Fdirectory_file_name, Fexpand_file_name)
3713 (Fsubstitute_in_file_name): Protect against invalid file handler
3714 return values (Bug#10845).
3716 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3718 * .gdbinit (pitx): Fix incorrect references to fields of the
3721 2012-02-17 Chong Yidong <cyd@gnu.org>
3723 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3725 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3727 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3728 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3730 2012-02-15 Chong Yidong <cyd@gnu.org>
3732 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3733 marked as special. Also, starting docstrings with * is obsolete.
3735 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3737 * gnutls.c (emacs_gnutls_write): Fix last change.
3739 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3741 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3744 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3746 * keymap.c (Fsingle_key_description): Handle char ranges.
3748 2012-02-12 Chong Yidong <cyd@gnu.org>
3750 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3751 as that creates a dangerous corner case.
3753 * window.c (Fdelete_window_internal): Invalidate the mouse
3754 highlight (Bug#9904).
3756 2012-02-12 Glenn Morris <rgm@gnu.org>
3758 * xselect.c (Fx_own_selection_internal)
3759 (Fx_get_selection_internal, Fx_disown_selection_internal)
3760 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3761 * nsselect.m (Fx_own_selection_internal)
3762 (Fx_disown_selection_internal, Fx_selection_exists_p)
3763 (Fx_selection_owner_p, Fx_get_selection_internal):
3764 Sync docs and argument specs with the xselect.c versions.
3766 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3768 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3770 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3772 * w32select.c (Fx_selection_exists_p): Sync doc string and
3773 argument list with xselect.c. (Bug#10783)
3775 * w16select.c (Fx_selection_exists_p): Sync doc string and
3776 argument list with xselect.c. (Bug#10783)
3778 2012-02-10 Glenn Morris <rgm@gnu.org>
3780 * fns.c (Fsecure_hash): Doc fix.
3782 2012-02-09 Kenichi Handa <handa@m17n.org>
3784 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3786 2012-02-07 Chong Yidong <cyd@gnu.org>
3788 * buffer.c (Fbuffer_local_variables)
3789 (buffer_lisp_local_variables): Handle unbound vars correctly;
3790 don't let Qunbound leak into Lisp.
3792 2012-02-07 Glenn Morris <rgm@gnu.org>
3794 * image.c (Fimagemagick_types): Doc fix.
3796 * image.c (imagemagick-render-type): Change it from a lisp object
3797 to an integer. Move the doc here from the lisp manual.
3798 Treat all values not equal to 0 the same.
3800 2012-02-06 Chong Yidong <cyd@gnu.org>
3802 * doc.c (store_function_docstring): Avoid applying docstring of
3803 alias to base function (Bug#2603).
3805 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3807 * .gdbinit (pp1, pv1): Remove redundant defines.
3810 2012-02-04 Chong Yidong <cyd@gnu.org>
3812 * nsterm.m: Declare a global (Bug#10694).
3814 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3816 * w32.c (get_emacs_configuration_options):
3817 Include --enable-checking, if specified, in the return value.
3819 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3821 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3822 after rounding frame sizes. (Bug#9723)
3824 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3826 * keyboard.c (adjust_point_for_property): Don't position point
3827 before BEGV. (Bug#10696)
3829 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3831 Handle overflow when computing char display width (Bug#9496).
3832 * character.c (char_width): Return EMACS_INT, not int.
3833 (char_width, c_string_width): Check for overflow when
3834 computing the width; this is possible now that individual
3835 characters can have unbounded width. Problem introduced
3836 by merge from Emacs 23 on 2012-01-19.
3838 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3840 * dbusbind.c (Fdbus_register_method): Mention the return value
3841 :ignore in the docstring.
3843 2012-02-02 Glenn Morris <rgm@gnu.org>
3845 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3847 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3848 Unconditionally set to t. (Bug#10673)
3849 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3850 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3851 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3853 2012-02-02 Kenichi Handa <handa@m17n.org>
3855 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3856 0, do not call append_composite_glyph.
3858 2012-02-02 Kenichi Handa <handa@m17n.org>
3860 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3862 (x_produce_glyphs): If the component of a composition is a null
3863 string, set it->pixel_width to 1 to avoid zero-width glyph.
3865 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3867 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3868 first 2 arguments are identical. This makes inserting large
3869 output from a subprocess an order of magnitude faster on
3870 MS-Windows, where all sbrk'ed memory is always contiguous.
3872 2012-01-31 Glenn Morris <rgm@gnu.org>
3874 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3875 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3876 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3878 2012-01-29 Glenn Morris <rgm@gnu.org>
3880 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3882 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3884 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3886 2012-01-28 Chong Yidong <cyd@gnu.org>
3888 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3890 2012-01-26 Chong Yidong <cyd@gnu.org>
3892 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3894 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3895 repeat counts (Bug#10507).
3897 2012-01-26 Glenn Morris <rgm@gnu.org>
3899 * lread.c (syms_of_lread): Doc fix.
3901 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3903 * coding.c (encode_designation_at_bol): Change return value to
3906 2012-01-25 Chong Yidong <cyd@gnu.org>
3908 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3910 2012-01-21 Chong Yidong <cyd@gnu.org>
3912 * floatfns.c (Fcopysign): Make the second argument non-optional,
3913 since nil is not allowed anyway.
3915 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3917 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3918 (send_process): Likewise.
3920 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3922 * window.c (save_window_save, Fcurrent_window_configuration)
3923 (Vwindow_persistent_parameters): Do not use Qstate.
3924 Rewrite doc-strings.
3926 2012-01-19 Kenichi Handa <handa@m17n.org>
3928 * character.c (char_width): New function.
3929 (Fchar_width, c_string_width, lisp_string_width):
3930 Use char_width (Bug#9496).
3932 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3934 * window.c (Vwindow_persistent_parameters): New variable.
3935 (Fset_window_configuration, save_window_save): Handle persistent
3938 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3940 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3941 thrashing the stack of the thread. (Bug#9087)
3943 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3945 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3947 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3949 * xdisp.c (rows_from_pos_range): Handle the case where the
3950 highlight ends on a newline. (Bug#10464)
3951 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3952 he end column for display of highlight that ends on a newline
3955 2012-01-11 Glenn Morris <rgm@gnu.org>
3957 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3958 from load-path also when installation-directory is nil. (Bug#10208)
3960 2012-01-10 Glenn Morris <rgm@gnu.org>
3962 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3964 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3965 Update template values to be closer to their typical values these days.
3967 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3969 * xdisp.c (rows_from_pos_range): Accept additional argument
3970 DISP_STRING, and accept any glyph in a row whose object is that
3971 string as eligible for mouse highlight. Fixes mouse highlight of
3972 display strings from overlays. (Bug#10464)
3974 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3976 emacs: fix an auto-save permissions race condition (Bug#10400)
3977 * fileio.c (auto_saving_dir_umask): New static var.
3978 (Fmake_directory_internal): Use it.
3979 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3980 creating the directory. The old code temporarily assigns
3981 too-generous permissions to the directory.
3982 (do_auto_save_eh): Clear it.
3983 (Fdo_auto_save): Catch all errors, not just file errors, so
3984 that the var is always cleared.
3986 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3988 * search.c (scan_buffer): Pass character positions to
3989 know_region_cache, not byte positions. (Bug#6540)
3991 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3993 * w32.c (sys_rename): Report EXDEV when rename of a directory
3994 fails because the target is on another logical disk. (Bug#10284)
3996 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3998 * xterm.c (x_embed_request_focus): New function.
4000 * xterm.h: Add prototype.
4002 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4004 2012-01-05 Glenn Morris <rgm@gnu.org>
4006 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4008 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4010 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4011 Load gnutls_transport_set_lowat only if GnuTLS version is below
4013 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4014 GnuTLS versions below 2.11.1.
4016 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4018 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4019 to the doc string advising against its use for altering the way
4020 windows are scrolled.
4022 2011-12-28 Kenichi Handa <handa@m17n.org>
4024 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4025 coding-system ASCII compatible only when it does not produce BOM
4026 on encoding (Bug#10383).
4028 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4030 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4032 (create_and_show_popup_menu): Always use menu_position_func for
4035 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4037 * callint.c (Fcall_interactively): Don't truncate prompt string.
4039 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4041 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4042 property that ends at ZV, so that the bidi iteration could be
4043 resumed from there (after widening). (Bug#10360)
4045 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4047 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4049 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4051 * nsterm.m (x_free_frame_resources):
4052 Release f->output_data.ns->miniimage.
4053 (ns_index_color): Fix indentation. Do not retain
4054 color_table->colors[i].
4056 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4059 * nsfns.m (x_set_background_color): Assign return value from
4060 ns_index_color to face-background instead of NSColor*.
4061 (ns_implicitly_set_icon_type): Fix indentation.
4062 Change assignment in for loop to comparison.
4064 * emacs.c (ns_pool): New variable.
4065 (main): Assign ns_pool.
4066 (Fkill_emacs): Call ns_release_autorelease_pool.
4068 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4069 autorelease fdesc, release fdAttrs and tdict.
4070 (ns_get_covering_families): Release charset.
4071 (ns_findfonts): Release NSFontDescriptor created with new.
4072 (ns_uni_to_glyphs): Fix indentation.
4073 (setString): Release attrStr before assigning new value.
4075 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4077 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4079 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4080 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4082 2011-12-18 David Reitter <reitter@cmu.edu>
4084 * nsterm.m (ns_term_init): Subscribe for notifications
4085 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4086 to method trackingNotification in EmacsMenu.
4088 * nsmenu.m (trackingMenu): New variable.
4089 (trackingNotification): New method (from Aquamacs).
4090 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4091 from Aquamacs (Bug#7030).
4093 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4095 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4096 (symbol_to_nsstring): Fix indentation.
4097 (ns_symbol_to_pb): New function.
4098 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4099 (Fns_rotate_cut_buffers_internal): Remove.
4100 (Fns_store_selection_internal): Rename from
4101 Fns_store_cut_buffer_internal.
4102 (ns_get_foreign_selection, Fx_own_selection_internal)
4103 (Fx_disown_selection_internal, Fx_selection_exists_p)
4104 (Fns_get_selection_internal, Fns_store_selection_internal):
4105 Use ns_symbol_to_pb and check if return value is nil.
4106 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4107 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4108 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4109 renamed to Sns_store_selection_internal.
4110 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4111 and remove this function.
4112 (ns_handle_selection_clear): Remove, never used.
4113 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4116 2011-12-17 Ken Brown <kbrown@cornell.edu>
4118 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4119 GID is unknown (Bug#10257).
4121 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4123 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4124 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4125 which caused a build failure on GNU/Linux IA-64. This problem was
4126 introduced by my 2011-10-07 patch.
4128 2011-12-15 Juri Linkov <juri@jurta.org>
4130 * image.c (imagemagick_error): New function. (Bug#10112)
4131 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4132 Use `imagemagick_error' where ImageMagick functions return
4134 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4137 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4139 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4140 fill background (Bug#8992).
4142 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4144 * window.c (Vwindow_combination_resize)
4145 (Vwindow_combination_limit): Use t instead of non-nil in
4147 (Vrecenter_redisplay): Add first sentence of doc-string on
4149 (Frecenter): Fix doc-string typo.
4151 2011-12-11 Kenichi Handa <handa@m17n.org>
4153 * coding.c (Funencodable_char_position): Pay attention to the
4154 buffer text relocation (Bug#9389).
4156 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4158 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4159 gtk_init (Bug#10100).
4161 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4163 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4164 IT->string is nil. (Bug#10263)
4166 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4168 * nsterm.h (x_free_frame_resources): Declare.
4170 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4171 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4173 * nsterm.h (ns_get_defaults_value): Declare.
4175 * nsterm.m (ns_default): Call ns_get_defaults_value.
4177 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4179 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4182 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4184 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4185 that where the value of an _OBJC_* symbol points to is in the .bss
4186 section (Bug#10240).
4188 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4190 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4191 after the loop to call ccl_driver at least once (Bug#8619).
4193 2011-12-08 Kenichi Handa <handa@m17n.org>
4195 * ftfont.c (get_adstyle_property): Fix previous change
4198 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4200 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4201 dirs from the default value of EMACSLOADPATH (bug#10208).
4203 2011-12-07 Glenn Morris <rgm@gnu.org>
4205 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4206 installation and source directories as well. (Bug#10208)
4208 2011-12-06 Chong Yidong <cyd@gnu.org>
4210 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4212 2011-12-06 Glenn Morris <rgm@gnu.org>
4214 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4215 as an error, not just -1. (Bug#10217)
4217 2011-12-05 Chong Yidong <cyd@gnu.org>
4219 * keyboard.c (process_special_events): New function.
4220 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4222 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4224 * coding.c (encode_designation_at_bol): Don't use uninitialized
4225 local variable (Bug#9318).
4227 2011-12-05 Kenichi Handa <handa@m17n.org>
4229 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4230 return Qnil (Bug#8046, Bug#10193).
4232 2011-12-05 Kenichi Handa <handa@m17n.org>
4234 * coding.c (encode_designation_at_bol): New args charbuf_end and
4235 dst. Return the number of produced bytes. Callers changed.
4236 (coding_set_source): Return how many bytes coding->source was
4238 (coding_set_destination): Return how many bytes
4239 coding->destination was relocated.
4240 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4241 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4243 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4245 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4246 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4249 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4251 The following changes are to fix Bug#9318.
4253 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4254 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4255 (encode_coding_iso_2022, encode_coding_sjis)
4256 (encode_coding_big5, encode_coding_charset): Use the above macros.
4258 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4260 * lisp.h (process_quit_flag): Fix external declaration.
4262 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4264 Don't macro-inline non-performance-critical code.
4265 * eval.c (process_quit_flag): New function.
4266 * lisp.h (QUIT): Use it.
4268 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4270 * nsfns.m (get_geometry_from_preferences): New function.
4271 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4273 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4275 * emacs.c (Qkill_emacs): Define.
4276 (syms_of_emacs): Initialize it.
4277 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4278 Qquit_flag to `kill-emacs' instead.
4279 (quit_throw_to_read_char): Add parameter `from_signal'.
4280 All callers changed. Call Fkill_emacs if requested and safe.
4281 * lisp.h (QUIT): Call Fkill_emacs if requested.
4283 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4285 * widget.c (update_wm_hints): Return if wmshell is null.
4286 (widget_update_wm_size_hints): New function.
4288 * widget.h (widget_update_wm_size_hints): Declare.
4290 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4291 widget_update_wm_size_hints (Bug#10104).
4293 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4295 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4296 before a newline, prepare the bidi iterator for consuming the
4297 newline, and keep the current paragraph direction. (Bug#10183)
4298 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4300 2011-12-02 Juri Linkov <juri@jurta.org>
4302 * search.c (Fword_search_regexp): New Lisp function created from
4303 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4304 (Fword_search_backward, Fword_search_forward)
4305 (Fword_search_backward_lax, Fword_search_forward_lax):
4306 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4307 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4309 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4311 * fileio.c (Finsert_file_contents): Move after-change-function call
4312 to before the "handled:" label, since all "goto handled" appear in
4313 cases where the *-change-functions have already been properly called
4316 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4318 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4319 waiting for input. (Bug#10169)
4321 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4323 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4324 verifies glyph row's hash code--we have just reallocated the
4325 glyphs, so their contents can be complete garbage. (Bug#10164)
4327 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4329 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4331 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4333 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4334 attributes are tested _before_ calling verify_row_hash, to protect
4335 against GCC re-ordering of the tests. (Bug#10164)
4337 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4339 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4341 * xterm.c (handle_one_xevent): Only set async_visible and friends
4342 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4343 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4344 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4346 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4348 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4349 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4350 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4351 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4352 All uses changed to use GCPRO1 etc.
4353 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4354 Revert to old implementation (i.e., before 2011-03-11).
4356 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4358 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4359 of scroll runs so as to avoid assigning disabled bogus rows and
4360 unnecessary graphics copy operations.
4362 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4364 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4365 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4366 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4367 (malloc, free, realloc, calloc): Redirect to e_* only when
4370 * lisp.h (GCTYPEBITS): Move before first use.
4371 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4372 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4373 this macro definition.
4375 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4378 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4380 * gtkutil.c (xg_create_frame_widgets):
4381 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4382 present with Gtk+ 2.0.
4384 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4386 * fileio.c (Finsert_file_contents): Undo previous change; see
4387 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4389 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4391 Rename locals to avoid shadowing.
4392 * fileio.c (Finsert_file_contents):
4393 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4394 * process.c (wait_reading_process_output):
4395 Rename inner 'proc' to 'p' to avoid shadowing.
4396 Indent for consistency with usual Emacs style.
4398 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4400 * xdisp.c (redisplay_window): If cursor row is not fully visible
4401 after recentering, and scroll-conservatively is set to a large
4402 number, scroll window by a few more lines to make the cursor fully
4403 visible and out of scroll-margin. (Bug#10105)
4404 (start_display): Don't move to the next line if the display should
4405 start at a newline that is part of a display vector or an overlay
4408 2011-11-24 Juri Linkov <juri@jurta.org>
4410 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4411 after the `MagickPingImage' call. (Bug#10112)
4413 2011-11-23 Chong Yidong <cyd@gnu.org>
4415 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4417 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4419 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4420 making another buffer current. (Bug#10114)
4422 2011-11-23 Glenn Morris <rgm@gnu.org>
4424 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4426 2011-11-23 Chong Yidong <cyd@gnu.org>
4428 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4429 using it (Bug#5984).
4431 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4433 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4434 and header-lines, as they don't have one computed for them.
4437 * .gdbinit (prow): Make displayed values more self-explaining.
4438 Add row's hash code.
4440 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4442 * process.c (wait_reading_process_output): Fix asynchrounous
4443 GnuTLS socket handling on some versions of the GnuTLS library.
4444 (wait_reading_process_output): Add comment and URL.
4446 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4448 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4450 2011-11-21 Chong Yidong <cyd@gnu.org>
4452 * window.c (Fnext_window, Fprevious_window): Doc fix.
4454 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4456 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4458 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4460 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4462 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4464 * window.c (Fset_window_combination_limit): Rename argument
4466 (Vwindow_combination_limit): Remove "status" from doc-string.
4468 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4470 * m/ibms390.h: Remove.
4471 * m/ibms390x.h: Don't include "ibms390.h".
4473 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4475 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4476 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4478 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4480 * casetab.c (Fset_case_table):
4481 * charset.c (Fcharset_after): Fix typos.
4483 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4485 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4486 Otherwise, valgrind does not work on some platforms.
4487 Problem reported by Andreas Schwab in
4488 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4489 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4490 is set, removing the need for VIRT_ADDRESS_VARIES.
4491 (PURE_P): Use a more-efficient implementation that needs just one
4492 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4493 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4494 to 4 (xorl, subq, cmpq, setbe).
4495 * alloc.c (pure): Always extern now, since that's the
4496 VIRT_ADDR_VARIES behavior.
4497 (PURE_POINTER_P): Use a single comparison, not two, for
4498 consistency with the new puresize.h.
4499 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4500 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4501 Remove VIRT_ADDR_VARIES no longer needed.
4503 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4505 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4506 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4507 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4508 behave as if the cursor position were at the window margin.
4510 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4511 and the cursor position is out of bounds, behave as if the cursor
4512 position were at the window margin. (Bug#10075)
4514 2011-11-18 Chong Yidong <cyd@gnu.org>
4516 * window.c (Fwindow_combination_limit): Make first argument
4517 non-optional, since it is meaningless for live windows like the
4520 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4522 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4524 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4526 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4527 (graft_intervals_into_buffer): Simplify.
4529 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4531 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4532 hash values of the two rows.
4533 (copy_row_except_pointers): Preserve the used[] arrays and the
4534 hash values of the two rows. (Bug#10035)
4535 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4537 * xdisp.c (row_hash): New function, body extracted from
4538 compute_line_metrics.
4539 (compute_line_metrics): Call row_hash, instead of computing the
4542 * dispnew.c (verify_row_hash): Call row_hash for computing the
4543 hash code of a row, instead of duplicating code from xdisp.c.
4545 * dispextern.h (row_hash): Add prototype.
4547 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4549 * frame.c (delete_frame): Don't delete the terminal when the last
4550 X frame is closed if emacs is built with GTK toolkit.
4552 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4554 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4556 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4558 * window.c (Vwindow_splits): Rename to
4559 Vwindow_combination_resize. Suggested by Juri Linkov.
4560 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4563 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4565 * nsfns.m (Fns_font_name):
4566 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4568 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4570 * window.h (window): Rename slot "nest" to "combination_limit".
4571 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4572 (Fset_window_nest): Rename to Fset_window_combination_limit.
4573 (Vwindow_nest): Rename to Vwindow_combination_limit.
4574 (recombine_windows, make_parent_window, make_window)
4575 (Fsplit_window_internal, saved_window)
4576 (Fset_window_configuration, save_window_save): Rename all
4577 occurrences of window_nest to window_combination_limit.
4579 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4581 * image.c (imagemagick_load_image): Fix typo.
4583 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4585 * xdisp.c (display_line): Move the call to
4586 highlight_trailing_whitespace before the call to
4587 compute_line_metrics, since the latter needs to see the final
4588 faces of all the glyphs to compute ROW's hash value.
4589 Fixes assertion violations in row_equal_p. (Bug#10035)
4591 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4593 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4594 just return (bug#10044).
4596 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4598 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4599 with user-defined heap size. Bump the default size of the temacs
4600 heap to 27MB, to avoid memory warning when running temacs.
4601 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4603 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4604 current_matrix and desired_matrix. (Bug#9990)
4605 (verify_row_hash) [XASSERTS]: New function.
4606 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4607 that the hash value of glyph rows is correct.
4609 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4611 * window.h (window): Remove splits slot.
4612 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4613 (Fdelete_other_windows_internal, make_parent_window)
4614 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4615 (Fset_window_configuration, save_window_save): Don't deal with
4616 split status of windows.
4617 (saved_window): Remove splits slot.
4618 (Vwindow_splits): Rewrite doc-string.
4620 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4622 * xfns.c (unwind_create_frame):
4623 * nsfns.m (unwind_create_frame):
4624 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4625 Vframe_list (Bug#9999).
4627 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4629 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4631 2011-11-11 Kenichi Handa <handa@m17n.org>
4633 * callproc.c (Fcall_process): Set the member dst_multibyte of
4636 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4638 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4639 avoid a crash (bug#9496).
4641 2011-11-09 Chong Yidong <cyd@gnu.org>
4643 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4644 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4646 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4648 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4650 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4652 Avoid some portability problems by eschewing 'extern inline' functions.
4653 The trivial performance wins aren't worth the portability hassles; see
4654 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4656 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4657 (window_box_width, window_box_left, window_box_left_offset)
4658 (window_box_right, window_box_right_offset): Undo previous change,
4659 by removing the "extern"s.
4660 * intervals.c (adjust_intervals_for_insertion)
4661 (adjust_intervals_for_deletion): Undo previous change,
4662 making these static again.
4663 (offset_intervals, temp_set_point_both, temp_set_point)
4664 (copy_intervals_to_string): No longer inline.
4665 * xdisp.c (window_text_bottom_y, window_box_width)
4666 (window_box_height, window_box_left_offset)
4667 (window_box_right_offset, window_box_left, window_box_right)
4668 (window_box): No longer inline.
4670 2011-11-08 Chong Yidong <cyd@gnu.org>
4672 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4673 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4674 Signal an error if not a live window.
4675 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4676 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4678 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4680 * lisp.h (syms_of_abbrev): Remove declaration.
4681 Reported by CHENG Gao <chenggao@royau.me>.
4683 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4685 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4686 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4687 of temacs in GUI mode.
4689 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4691 * window.h: Declare delete_all_child_windows instead of
4692 delete_all_subwindows.
4693 * window.c (Fwindow_nest, Fset_window_nest)
4694 (Fset_window_new_total, Fset_window_new_normal)
4695 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4696 (delete_all_subwindows): Rename to delete_all_child_windows.
4697 (Fdelete_other_windows_internal, Fset_window_configuration):
4698 Call delete_all_child_windows instead of delete_all_subwindows.
4699 * frame.c (delete_frame): Call delete_all_child_windows instead
4700 of delete_all_subwindows.
4702 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4704 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4705 This is also needed for porting to any host where GC_MARK_STACK is
4706 not GC_MAKE_GCPROS_NOOPS.
4707 (which_symbols): Use it.
4709 2011-11-07 Kenichi Handa <handa@m17n.org>
4711 * coding.c (coding_set_destination): Check coding->src_pos only
4712 when coding->src_object is a buffer (bug#9910).
4714 * process.c (send_process): Set the member src_multibyte of coding
4715 to 0 (bug#9911) when sending a unibyte text.
4717 * callproc.c (Fcall_process): Set the member src_multibyte of
4718 process_coding to 0 (bug#9912).
4720 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4722 * xmenu.c (cleanup_widget_value_tree): New function.
4723 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4724 calling free_menubar_widget_value_tree directly (Bug#9830).
4726 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4728 Fix some portability problems with 'inline'.
4729 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4730 (window_box_width, window_box_left, window_box_left_offset)
4731 (window_box_right, window_box_right_offset): Declare extern.
4732 Otherwise, these inline functions do not conform to C99 and
4733 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4734 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4735 * intervals.c (adjust_intervals_for_insertion)
4736 (adjust_intervals_for_deletion): Now extern, because otherwise the
4737 extern inline functions 'offset_intervals' couldn't refer to it.
4738 (static_offset_intervals): Remove.
4739 (offset_intervals): Rewrite using the old contents of
4740 static_offset_intervals. The old version didn't conform to C99
4741 because an extern inline function contained a reference to an
4742 identifier with static linkage.
4744 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4746 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4749 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4751 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4752 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4753 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4754 return Qleft_to_right.
4756 2011-11-06 Chong Yidong <cyd@gnu.org>
4758 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4759 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4760 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4761 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4762 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4763 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4764 (Fwindow_vscroll): Doc fix.
4765 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4766 argument, since it makes no sense to pass a live window and for
4767 consistency with window-child.
4769 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4771 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4774 2011-11-05 Jason Rumney <jasonr@gnu.org>
4776 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4777 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4779 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4780 bitwise arithmetic preventing use of unicode-sip and non-truetype
4783 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4785 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4788 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4789 initialization code to keep similarity to xfns.c after changes
4792 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4794 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4795 (unwind_create_frame): New function (Bug#9943).
4796 (Fx_create_frame): Restructure code to be more similar to the one in
4797 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4798 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4799 Move terminal->reference_count++ just before making the frame official
4802 * nsterm.m (x_free_frame_resources): New function.
4803 (x_destroy_window): Move code to x_free_frame_resources.
4805 * xfns.c (unwind_create_frame): Fix comment.
4806 (Fx_create_frame, x_create_tip_frame):
4807 Move terminal->reference_count++ just before making the frame
4808 official. Move initialization of image_cache_refcount and
4809 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4811 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4813 Support MSVC build with newer versions of Visual Studio.
4814 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4815 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4818 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4819 which are not supported by MSVC.
4820 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4821 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4823 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4825 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4827 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4829 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4831 Support MSVC build with newer versions of Visual Studio.
4832 * w32.c: Don't include w32api.h for MSVC.
4833 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4835 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4836 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4837 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4838 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4840 (alloca) [_MSC_VER]: Define to _alloca.
4842 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4844 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4846 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4848 * xdisp.c (note_mouse_highlight): If either of
4849 previous/next-single-property-change returns nil, treat that as
4850 the beginning or the end of the buffer. (Bug#9955)
4852 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4854 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4855 label is not null (Bug#9951).
4856 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4859 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4861 * window.c (Fwindow_body_size): Mention in the doc string that the
4862 return value is in frame's canonical units. (Bug#9949)
4864 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4866 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4868 * w32fns.c (unwind_create_frame): If needed, free the glyph
4869 matrices of the partially constructed frame. (Bug#9943)
4870 * xfns.c (unwind_create_frame): Likewise.
4872 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4874 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4875 Don't stop backward scan on the continuation glyph, even though
4876 its CHARPOS is positive.
4877 (mouse_face_from_buffer_pos, note_mouse_highlight):
4878 Rename cover_string to disp_string.
4880 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4882 * window.c (temp_output_buffer_show): Don't use
4883 Vtemp_buffer_show_specifiers.
4884 (Vtemp_buffer_show_specifiers): Remove unused variable.
4886 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4888 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4889 past the beginning of the current glyph matrix.
4891 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4893 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4894 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4895 HAVE_GTK3 (Bug#9869).
4897 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4898 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4900 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4902 * xterm.c: Declare x_handle_net_wm_state to return int.
4903 (handle_one_xevent): Check if we are iconified but don't have
4904 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4905 (get_current_wm_state): Return non-zero if not hidden,
4906 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4907 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4908 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4909 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4911 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4913 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4914 so that this new function doesn't get optimized away by a
4915 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4917 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4919 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4921 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4923 Fix the `xbytecode' command.
4924 * .gdbinit (xprintbytestr): New command.
4925 (xwhichsymbols): Rename from `which'; all callers changed.
4926 (xbytecode): Print the byte-code string as well.
4928 2011-10-29 Kim Storm <storm@cua.dk>
4930 * alloc.c (which_symbols): New function.
4932 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4934 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4937 2011-10-29 Glenn Morris <rgm@gnu.org>
4939 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4940 Not clear what it was for, and it causes various bugs. (Bug#9839)
4942 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4945 possible random value that matches one of those tested as
4946 condition to clear the mouse face.
4948 2011-10-28 Chong Yidong <cyd@gnu.org>
4950 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4952 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4954 * window.c (make_window): Initialize phys_cursor_on_p.
4956 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4958 * lisp.h (struct Lisp_Symbol): Update comments.
4960 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4962 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4964 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4966 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4967 <oslsachem@gmail.com> for helping to debug this.
4969 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4970 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4971 (g_b_init_get_glyph_outline_w): New static variables.
4972 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4973 (GetGlyphOutlineW_Proc): New typedefs.
4974 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4975 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4977 (w32font_open_internal, compute_metrics):
4978 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4979 instead of calling the "wide" APIs directly.
4981 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4983 * w32.h (syms_of_w32font): Add prototype.
4985 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4987 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4988 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4989 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4990 (Fmove_to_window_line): Doc fix.
4992 2011-10-27 Chong Yidong <cyd@gnu.org>
4994 * process.c (make_process): Set gnutls_state to NULL.
4996 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4997 non-NULL, regardless of GNUTLS_INITSTAGE.
4998 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4999 an error. Set process slots as soon as we allocate them.
5001 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5003 2011-10-27 Chong Yidong <cyd@gnu.org>
5005 * gnutls.c (emacs_gnutls_deinit): New function.
5006 Deallocate credentials structures as well as calling gnutls_deinit.
5007 (Fgnutls_deinit, Fgnutls_boot): Use it.
5009 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5010 (deactivate_process): Call emacs_gnutls_deinit.
5012 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5014 * image.c (x_create_x_image_and_pixmap):
5015 * w32.c (sys_rename, w32_delayed_load):
5016 * w32font.c (fill_in_logfont):
5017 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5019 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5021 * w32fns.c (w32_default_color_map): New function,
5022 extracted from Fw32_default_color_map.
5023 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5025 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5027 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5029 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5031 * keyboard.c (test_undefined): New function (bug#9751).
5032 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5034 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5036 * sysdep.c (init_sys_modes): Fix the check for the controlling
5037 terminal (Bug#6649).
5039 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5041 * dispextern.h (struct bidi_it): New member next_en_type.
5043 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5044 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5045 current character, check also for next_en_type being WEAK_EN.
5046 (bidi_resolve_weak): Don't enter the expensive loop if the current
5047 position is before next_en_pos. Record the bidi type of the first
5048 non-ET, non-BN character we find, in addition to its position.
5049 (bidi_level_of_next_char): Invalidate next_en_type when
5050 next_en_pos is over-stepped.
5052 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5054 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5055 * editfns.c: Rewrite current-time-zone so that it invokes
5056 the equivalent of (format-time-string "%Z") to get the time zone name.
5057 This fixes a bug when the time zone name contains characters that
5058 need converting from the system time locale to Emacs internal format.
5059 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5060 that patch fixed format-time-string to do the conversion, but
5061 I forgot to fix current-time-zone.
5062 (format_time_string): New function, containing most of
5063 what Fformat_time_string used to contain.
5064 (Fformat_time_string): Rewrite in terms of format_time_string.
5065 This doesn't change this function's behavior.
5066 (current-time-zone): Rewrite to use format_time_string.
5067 This fixes the bug reported by Michael Schierl in
5068 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5069 Jason Rumney's 2007-06-07 change worked around this bug, but
5071 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5073 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5075 * xdisp.c (start_display): If the character at POS is displayed
5076 via a display vector, reset IT->current.dpvec_index to zero.
5077 (try_window_reusing_current_matrix): If a line ends in a display
5078 vector or the next line starts in a display vector, continue
5079 redrawing the window even though the character position of
5080 start_row was reached.
5083 2011-10-18 Chong Yidong <cyd@gnu.org>
5085 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5086 with nobreak-char-display too.
5088 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5090 Fix part 3 of bug#9771.
5091 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5092 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5093 non-neutral characters if the current character is a paragraph
5094 separator (a.k.a. Newline). This avoids running the same
5095 expensive loop twice, once when we consume the preceding newline
5096 and the other time when the line actually needs to be displayed.
5097 Avoid the loop when we see neutrals on the base embedding level
5098 following a character whose directionality is the same as the
5099 paragraph's. This avoids running the expensive loop when a line
5100 ends in a long sequence of neutrals, like control characters.
5101 Add assertion against STRONG_AL type. Slightly rearrange code
5102 that determines the type of a neutral given the first non-neutral
5104 (bidi_level_of_next_char): Set next_en_pos to zero when
5105 invalidating its info.
5107 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5109 * xdisp.c (push_display_prop): Determine whether to record string
5110 or buffer position by IT->string, not by IT->method. Allow
5111 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5112 (move_it_vertically_backward): Don't look for character position
5113 immediately after the newline when in a continuation line.
5116 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5118 * window.c (coordinates_in_window): Rewrite and delabelize
5119 vertical border check. (Bug#5357) (Bug#9618)
5121 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5123 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5124 errors in XSetWindowBorder (bug#9310).
5126 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5128 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5129 avoid crash when xmalloc overrun checking is enabled.
5131 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5133 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5134 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5135 cursor motion with <left> and <right> arrow keys.
5137 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5138 some callers set that themselves.
5140 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5142 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5143 display string and the previous row comes from the same string and
5144 is empty. (Bug#9739) (Bug#9738)
5146 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5148 * doc.c (get_doc_string): Encode file name (bug#9735).
5150 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5152 * bidi.c (bidi_level_of_next_char):
5153 * xdisp.c (get_visually_first_element): Remove old incorrect
5154 comments regarding the Unicode Line Separator character.
5156 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5158 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5160 * alloc.c (Fgc_status): Do not access beyond zombies array
5161 boundary if nzombies > MAX_ZOMBIES.
5162 * alloc.c (dump_zombies): Add missing format specifier.
5164 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5166 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5167 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5169 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5170 Some packages use them to denote characters with modifiers.
5172 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5174 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5175 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5176 matching a pp-number. Rename parameter var to var1.
5178 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5180 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5182 2011-10-08 Glenn Morris <rgm@gnu.org>
5184 * callint.c (Fcall_interactively): Give a more explicit error for the
5185 'c' case with a non-character input. (Bug#8479)
5187 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5189 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5191 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5192 lines that are hscrolled on the left.
5194 * dispnew.c (buffer_posn_from_coords): Account for a possible
5195 presence of header-line. (Bug#4426)
5197 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5199 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5200 Don't advertise functionality which we discourage or doesn't work.
5202 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5204 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5205 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5206 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5207 this makes Emacs dump core during garbage collection on rare
5208 occasions. sizeof is obviously inferior to offsetof here, so
5209 stick with offsetof.
5210 (GC_POINTER_ALIGNMENT): New macro.
5211 (mark_memory): Omit 3rd (offset) arg; caller changed.
5212 Don't assume EMACS_INT alignment is the same as pointer alignment.
5214 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5216 * keyboard.c (read_key_sequence_remapped): New var.
5217 (read_key_sequence): Compute remapping in the right buffer.
5218 (command_loop_1): Use read_key_sequence's remapping directly.
5220 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5222 * dired.c (file_name_completion): Don't expand file name.
5223 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5224 before checking file name handler.
5226 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5227 they've been requested explicitly (bug#9591).
5229 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5231 * keymap.c (Fsingle_key_description): Use make_specified_string
5232 instead of build_string to build string from push_key_description.
5235 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5237 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5238 This fixes a Y2038 bug on 64-bit hosts.
5239 * buffer.c (reset_buffer):
5240 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5241 (Fclear_buffer_auto_save_failure):
5242 Use 0, not -1, to represent an unset failure time, since time_t
5243 might not be signed.
5245 Remove dependency on glibc malloc internals.
5246 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5247 Move back here from lisp.h, but with their new implementations.
5248 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5249 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5250 * charset.c (charset_table_init): New static var.
5251 (syms_of_charset): Use it instead of xmalloc. This removes a
5252 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5253 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5254 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5255 Move back to alloc.c.
5256 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5257 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5259 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5261 * nsterm.m (windowDidResize): Call x_set_window_size only when
5262 ns_in_resize is true. Otherwise set pixelwidth/height and
5263 call change_frame_size (Bug#9628).
5265 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5267 Port --enable-checking=all to Fedora 14 x86-64.
5268 * charset.c (syms_of_charset): Also account for glibc malloc's
5269 internal overhead when calculating the initial malloc maximum.
5271 Port --enable-checking=all to Fedora 14 x86.
5272 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5274 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5275 (overrun_check_realloc, overrun_check_free):
5276 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5277 That way, xmalloc returns a properly-aligned pointer even if
5278 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5279 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5280 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5281 into account when calculating the initial malloc maximum.
5282 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5283 Move here from alloc.c, so that charset.c can use it too.
5284 Properly align; the old code wasn't right for common 32-bit hosts
5285 when configured with --enable-checking=all.
5286 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5287 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5289 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5291 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5294 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5296 * xdisp.c (compute_display_string_end): If there's no display
5297 string at CHARPOS, return -1.
5299 * bidi.c (bidi_fetch_char): When compute_display_string_end
5300 returns a negative value, treat the character as a normal
5301 character not covered by a display string. (Bug#9624)
5303 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5305 * lread.c (Fread_from_string): Fix typo in docstring.
5307 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5309 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5310 newline, reseat the iterator instead of bidi-iterating there one
5311 character at a time. (Bug#9610)
5312 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5313 TO_CHARPOS if the bidi iterator is at base embedding level.
5315 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5317 * lread.c (readevalloop): Use correct code for NBSP.
5318 (read1): Likewise. (Bug#9608)
5320 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5322 * dbusbind.c (Fdbus_register_signal): When service is not
5323 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5325 2011-09-25 Glenn Morris <rgm@gnu.org>
5327 * buffer.c (truncate-lines): Doc fix.
5329 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5331 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5332 (Fset_window_next_buffers): Doc fix.
5334 2011-09-24 Glenn Morris <rgm@gnu.org>
5336 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5338 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5340 Fix minor problems found by static checking.
5341 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5342 * indent.c (Fvertical_motion): Fix == vs = typo.
5344 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5346 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5347 Default value is now t. Doc fix.
5349 * indent.c (Fvertical_motion): Compute and apply the overshoot
5350 logic when moving up, not only when moving down. Fix the
5351 confusing name and values of the it_overshoot_expected variable;
5352 logic changes accordingly. (Bug#9254) (Bug#9549)
5354 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5355 CHARPOS is covered by a display string which includes newlines.
5356 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5357 is covered by a display string with embedded newlines.
5359 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5361 * dbusbind.c (Fdbus_register_signal): Add match rule to
5362 Vdbus_registered_objects_table. (Bug#9581)
5363 (Fdbus_register_method, Vdbus_registered_objects_table):
5366 2011-09-24 Jim Meyering <meyering@redhat.com>
5368 do not ignore write error for any output size
5369 The previous change was incomplete.
5370 While it makes emacs --batch detect the vast majority of stdout
5371 write failures, errors were still ignored whenever the output size is
5372 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5373 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5374 && echo FAIL: ignored write error
5375 FAIL: ignored write error
5376 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5377 && echo FAIL: ignored write error
5378 FAIL: ignored write error
5379 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5381 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5383 * emacs.c (Fkill_emacs): In noninteractive mode exit
5384 non-successfully if a write error occurred on stdout. (Bug#9574)
5386 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5388 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5391 * dispextern.h (struct it): Update the comment documenting what
5394 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5396 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5397 a display string, extend search for cursor position to end of row.
5398 (find_row_edges): If the row ends in a newline from a display
5399 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5400 Handle the case of a display string with multiple newlines.
5401 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5402 non-empty line. Fixes confusing cursor motion with arrow keys at
5403 the beginning of a line that starts with whitespace.
5405 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5407 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5410 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5412 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5415 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5417 * xdisp.c (display_line): Record maximum and minimum buffer
5418 positions even if no glyphs were produced (e.g., by a zero-width
5419 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5420 buffer positions that will be removed from the glyph row because
5422 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5423 column is beyond frame width: don't subtract 1 "pixel" when
5424 computing width of the stretch.
5425 (reseat_at_next_visible_line_start): Undo the change made on
5426 2011-09-17 that saved paragraph information and restored it after
5427 the call to `reseat'. (Bug#9545)
5429 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5431 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5432 and turn window cursor on if cleared (Bug#9415).
5434 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5436 * search.c (boyer_moore): Take unibyte characters from pattern
5437 literally. (Bug#9458)
5439 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5441 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5443 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5445 Fix minor problem found by static checking.
5446 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5447 initialized, to pacify gcc -Wuninitialized.
5449 * fileio.c: Report proper errno when syscall falls.
5450 (Finsert_file_contents): Save and restore errno,
5451 so that report_file_error outputs the correct diagnostic.
5452 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5454 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5456 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5458 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5460 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5461 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5463 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5465 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5466 about the current paragraph and restore it after the call to reseat.
5468 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5469 (bidi_find_paragraph_start): Search back for paragraph beginning
5470 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5471 (bidi_move_to_visually_next): Only trigger paragraph-related
5472 computations when the last character is a newline or at EOB, not
5473 just any NEUTRAL_B. (Bug#9470)
5475 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5476 truncated lines if point is covered by a display string. (Bug#9524)
5478 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5480 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5481 (cons_to_x_long): New function.
5482 (lisp_data_to_selection_data): Use it. Correct the test for
5483 short-versus-long data; it was negated. Break out of vector
5484 loop, for efficiency, when a long datum is discovered.
5486 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5488 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5490 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5492 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5493 GCC PR/17406) by declaring this function with external scope.
5495 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5497 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5498 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5500 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5502 * editfns.c (Fformat): Correctly handle text properties on "%%".
5504 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5506 * xterm.c (x_draw_composite_glyph_string_foreground):
5507 * w32term.c (x_draw_composite_glyph_string_foreground):
5508 * term.c (encode_terminal_code):
5509 * composite.c (composition_update_it, get_composition_id):
5510 * xdisp.c (get_next_display_element)
5511 (fill_composite_glyph_string): Add comments about special meaning
5512 of TAB characters in a composition.
5514 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5516 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5517 This occurs when processing a multibyte format.
5518 Problem reported by Wolfgang Jenker.
5520 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5522 * xdisp.c (try_cursor_movement): Only check for exact match if
5523 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5525 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5527 Remove unused external symbols.
5528 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5529 * xdisp.c (calc_pixel_width_or_height): Now static.
5530 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5531 * indent.c (check_display_width):
5532 * w32term.c: Fix comment to match code.
5533 * xterm.c, xterm.h (x_catching_errors): Remove.
5535 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5537 * xselect.c: Use signed conversions more consistently (Bug#9498).
5538 (selection_data_to_lisp_data): Assume incoming selection data are
5539 signed integers, not unsigned. This is to be consistent with
5540 outgoing selection data, which was modified to use signed integers
5541 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5542 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5543 expects long, not unsigned long.
5545 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5547 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5548 computation of loop end. Reported by Johan Bockgård
5551 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5553 * frame.c (Fother_visible_frames_p): Function deleted.
5555 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5557 * indent.c (compute_motion): Process display vector front to back
5558 rather than the other way around. (Bug#2496)
5560 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5562 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5564 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5566 * minibuf.c (Fread_from_minibuffer): Doc fix.
5568 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5570 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5571 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5573 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5575 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5576 value for non-existent files.
5578 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5580 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5581 set its "size" to -1. This will set the modtime_size field of
5582 the corresponding buffer to -1, which is what
5583 verify-visited-file-modtime expects for files that do not exist.
5586 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5588 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5590 * lisp.h: ... from here. push_key_description is no longer
5591 defined in keyboard.c, so its declaration should not be in
5592 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5593 logically belongs with push_key_description.
5595 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5597 * buffer.h: Include <sys/types.h> instead of <time.h>.
5598 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5599 Problem reported by Herbert J. Skuhra.
5601 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5603 * xml.c (parse_region): Make the parsing work for
5604 non-comment-starting XML files again (bug#9144).
5606 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5608 * image.c (gif_load): Fix calculation of bottom and right corner.
5611 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5613 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5614 redisplay in small windows.
5616 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5618 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5620 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5622 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5623 Operate on live windows only.
5625 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5627 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5629 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5631 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5632 only under bidi iteration.
5634 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5636 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5638 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5640 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5641 Without this fix, the command to link temacs failed due to an
5642 undefined symbol __builtin_isnan. This is because
5643 /usr/include/iso/math_c99.h #defines isnan(x) to
5644 __builtin_isnan(x), but the bundled gcc, which identifies itself
5645 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5647 * floatfns.c (isnan): #undef, and then #define to a clone of
5649 (Fisnan): Always define, since it's always available now.
5650 (syms_of_floatfns): Always define isnan at the Lisp level.
5652 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5654 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5656 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5658 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5659 The previous code assumed that file offsets (off_t values) fit in
5660 EMACS_INT variables, which is not true on typical 32-bit hosts.
5661 The code messed up by falsely reporting buffer overflow in cases
5662 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5663 when "big" contains more than 2**29 bytes, even though this
5664 inserts just one byte and does not overflow the buffer.
5665 (Finsert_file_contents): Store file offsets as off_t
5666 values, not as EMACS_INT values. Check for overflow when
5667 converting between EMACS_INT and off_t. When checking for
5668 buffer overflow or for overlap, take the offsets into account.
5669 Don't use EMACS_INT for small values where int suffices.
5670 When checking for overlap, fix a typo: ZV was used where
5671 ZV_BYTE was intended.
5672 (Fwrite_region): Don't assume off_t fits into 'long'.
5673 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5675 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5677 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5679 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5681 sprintf-related integer and memory overflow issues (Bug#9412).
5683 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5684 (esprintf, exprintf, evxprintf): New functions.
5685 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5686 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5687 (modify_event_symbol): Do not assume that the length of
5688 name_alist_or_stem is safe to alloca and fits in int.
5689 (Fexecute_extended_command): Likewise for function name and binding.
5690 (Frecursion_depth): Wrap around reliably on integer overflow.
5691 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5692 since some callers pass EMACS_INT values.
5693 (Fsingle_key_description): Don't crash if symbol name contains more
5694 than MAX_ALLOCA bytes.
5695 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5696 (get_minibuffer): Arg is now EMACS_INT, not int.
5697 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5698 (esprintf, exprintf, evxprintf): New decls.
5699 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5701 * dbusbind.c (signature_cat): New function.
5702 (xd_signature, Fdbus_register_signal):
5703 Do not overrun buffer; instead, report string overflow.
5705 * dispnew.c (add_window_display_history): Don't overrun buffer.
5706 Truncate instead; this is OK since it's just a log.
5708 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5709 even if the time zone offset is outlandishly large.
5710 Don't mishandle offset == INT_MIN.
5712 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5713 when creating daemon; the previous buffer-overflow check was incorrect.
5715 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5716 which has the guts of the old verror function.
5718 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5719 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5721 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5722 (font_unparse_xlfd): Don't blindly alloca long strings.
5723 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5724 fits in int, when using sprintf. Use single snprintf to count
5725 length of string rather than counting it via multiple sprintfs;
5726 that's simpler and more reliable.
5727 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5728 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5729 sprintf, in case result does not fit in int.
5731 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5732 (fontset_from_font): Print it.
5734 * frame.c (tty_frame_count): Now printmax_t, not int.
5735 (make_terminal_frame, set_term_frame_name): Print it.
5736 (x_report_frame_params): In X, window IDs are unsigned long,
5737 not signed long, so print them as unsigned.
5738 (validate_x_resource_name): Check for implausibly long names,
5739 and don't assume name length fits in 'int'.
5740 (x_get_resource_string): Don't blindly alloca invocation name;
5741 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5744 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5745 (xg_check_special_colors, xg_set_geometry):
5746 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5748 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5749 Use esprintf, not sprintf, in case result does not fit in int.
5751 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5752 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5753 it as a large positive number.
5754 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5755 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5757 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5758 in case result does not fit in int.
5760 * print.c (float_to_string): Detect width overflow more reliably.
5761 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5762 buffer overrun. Don't assume list length fits in 'int'. Treat
5763 print length of 0 as 0, not as infinity; to be consistent with other
5764 uses of print length in this function. Don't overflow print length
5765 index. Don't assume hash table size fits in 'long', or that
5766 vectorlike size fits in 'unsigned long'.
5768 * process.c (make_process): Use printmax_t, not int, to format
5769 process-name gensyms.
5771 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5773 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5774 to avoid potential buffer overrun.
5776 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5777 if X resource line is longer than 512 bytes.
5779 * xfns.c (x_window): Make sprintf buffer a bit bigger
5780 to avoid potential buffer overrun.
5782 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5784 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5786 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5788 Integer overflow fixes for scrolling, etc.
5789 Without these, Emacs silently mishandles large integers sometimes.
5790 For example, "C-u 4294967297 M-x recenter" was treated as if
5791 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5793 * xdisp.c (try_window_id): Check Emacs fixnum range before
5794 converting to 'int'.
5796 * window.c (window_scroll_line_based, Frecenter):
5797 Check that an Emacs fixnum is in range before assigning it to 'int'.
5798 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5799 values converted from Emacs fixnums.
5800 (Frecenter): Don't wrap around a line count if it is out of 'int'
5801 range; instead, treat it as an extreme value.
5802 (Fset_window_configuration, compare_window_configurations):
5803 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5805 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5806 that can exceed INT_MAX. Check that EMACS_INT value is in range
5807 before assigning it to the (possibly-narrower) index.
5808 (match_limit): Don't assume that a fixnum can fit in 'int'.
5810 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5813 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5814 (Fvertical_motion): Don't wrap around LINES values that don't fit
5815 in 'int'. Instead, treat them as extreme values. This is good
5816 enough for windows, which can't have more than INT_MAX lines anyway.
5818 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5820 * Require libxml/parser.h to avoid compilation warning.
5822 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5824 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5825 since this reportedly can destroy thread storage.
5827 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5829 * syntax.c (find_defun_start): Update all cache variables if
5830 exiting early (Bug#9401).
5832 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5834 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5836 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5837 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5838 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5840 * term.c (tty_append_glyph): New function.
5841 (produce_stretch_glyph): Static function and its prototype deleted.
5843 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5846 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5848 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5849 when checking :margin (Bug#9390).
5850 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5851 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5852 so that the name doesn't mislead. All uses changed.
5854 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5856 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5859 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5861 * xdisp.c (move_it_to): Don't bail out early when reaching
5862 position beyond to_charpos, if we are scanning backwards.
5863 (move_it_vertically_backward): When DY == 0, make sure we get to
5864 the first character in the line after the newline.
5866 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5868 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5869 (ccl_driver): Do not generate an out-of-range pointer.
5870 (Fccl_execute_on_string): Remove unnecessary check for
5871 integer overflow, noted by Stefan Monnier in
5872 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5873 Remove a FIXME that didn't need fixing.
5874 Simplify the newly-introduced buffer reallocation code.
5876 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5878 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5880 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5882 Integer and memory overflow issues (Bug#9196).
5884 * doc.c (get_doc_string): Rework so that
5885 get_doc_string_buffer_size is the actual buffer size, rather than
5886 being 1 less than the actual buffer size; this makes xpalloc more
5889 * image.c (x_allocate_bitmap_record, cache_image):
5890 * xselect.c (Fx_register_dnd_atom):
5891 Simplify previous changes by using xpalloc.
5893 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5894 since either will do and ptrdiff_t is convenient with xpalloc.
5896 * charset.c (charset_table_size)
5897 (struct charset_sort_data.priority): Now ptrdiff_t.
5898 (charset_compare): Don't overflow if priorities differ greatly.
5899 (Fsort_charsets): Don't assume list length fits in int.
5900 Check for size-calculation overflow when allocating sort data.
5901 (syms_of_charset): Allocate an initial charset table that is
5902 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5904 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5906 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5907 The actual value is always <= INT_MAX, and leaving it unsigned made
5908 overflow checking harder.
5910 * dispextern.h (struct glyph_matrix.rows_allocated)
5911 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5912 with xpalloc. The values are still always <= INT_MAX.
5914 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5916 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5917 (SAFE_NALLOCA): New macro.
5919 * region-cache.c (struct boundary.pos, find_cache_boundary)
5920 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5921 (set_cache_region, invalidate_region_cache)
5922 (revalidate_region_cache, know_region_cache, region_cache_forward)
5923 (region_cache_backward, pp_cache):
5924 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5925 so that ptrdiff_t * can be passed to xpalloc.
5926 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5927 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5928 (pp_cache): Don't assume cache_len fits in int.
5929 * region-cache.h: Adjust extern decls to match.
5931 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5932 EMACS_INT, since either will do, for xpalloc.
5934 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5935 (xnmalloc, xnrealloc, xpalloc): New functions.
5937 * bidi.c (bidi_shelve_header_size): New constant.
5938 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5939 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5941 * bidi.c (bidi_cache_shrink):
5942 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5944 Don't update size of array until after memory allocation succeeds,
5945 because xmalloc/xrealloc may not return.
5946 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5947 now that we have proper integer overflow checking.
5948 (record_overlay_string, overlay_strings): Catch overflows when
5949 calculating size of overlay_str_buf.
5951 * callproc.c (Fcall_process): Check for size overflow when
5952 calculating size of args2.
5953 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5954 Normally we prefer signed values, but sticking with ptrdiff_t would
5955 require adding more-complicated checks.
5957 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5958 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5959 Redo buffer-overflow calculations to avoid integer overflow.
5960 Add a FIXME comment where memory seems to be over-allocated.
5962 * character.c (Fstring): Check for size-calculation overflow.
5964 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5965 unnecessary integer overflow. Check for size overflow.
5966 (encode_coding_object): Don't update size until xmalloc succeeds.
5968 * composite.c (get_composition_id): Check for overflow in glyph
5969 length calculations.
5971 Integer and memory overflow fixes for display code.
5972 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5973 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5974 (scrolling_window): Check for overflow in size calculations.
5975 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5976 Don't assume glyph table len fits in int.
5977 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5978 (row_table_size): Now ptrdiff_t, not int.
5979 (scrolling_window): Avoid overflow in size calculations.
5980 Don't update size until allocation succeeds.
5981 * fns.c (concat): Check for overflow in size calculations.
5982 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5983 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5984 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5986 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5987 (get_doc_string): Check for size calculation overflow.
5988 Don't update size until allocation succeeds.
5989 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5990 EMACS_INT, where ptrdiff_t will do.
5991 (Fsubstitute_command_keys): Check for string overflow.
5993 * editfns.c (set_time_zone_rule): Don't assume environment length
5995 (message_length): Now ptrdiff_t, not int.
5996 (Fmessage_box): Don't update size until allocation succeeds.
5997 Don't assume message length fits in int.
5998 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6000 * emacs.c (main): Do not reallocate argv, since there is a null at
6001 the end that can be overwritten, and this way there's no need to
6002 worry about size-calculation overflow.
6003 (sort_args): Check for size-calculation overflow.
6005 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6007 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6009 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6010 (x_set_scroll_bar_width, x_figure_window_size):
6011 Check for integer overflow.
6012 (x_set_alpha): Do not assume XINT fits in int.
6014 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6015 This is for the members text_lines, text_cols, total_lines, total_cols,
6016 where the system imposes an 'int' limit.
6018 * fringe.c (Fdefine_fringe_bitmap):
6019 Don't update size until alloc works.
6021 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6022 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6024 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6025 Check for size-calculation overflow.
6026 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6027 do, as we prefer signed integers.
6028 (id_to_widget.max_size, id_to_widget.used)
6029 (xg_store_widget_in_map, xg_remove_widget_from_map)
6030 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6031 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6032 Use and return ptrdiff_t, not int.
6033 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6034 * gtkutil.h: Change prototypes to match the above.
6036 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6037 are duplicate now that they've been promoted to lisp.h.
6038 (x_allocate_bitmap_record, x_alloc_image_color)
6039 (make_image_cache, cache_image, xpm_load):
6040 Don't update size until alloc is done.
6041 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6043 Check for size calculation overflow.
6044 (ct_colors_allocated_max): New constant.
6045 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6048 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6049 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6050 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6051 Use ptrdiff_t, not int, to count maps.
6052 (read_char_minibuf_menu_prompt): Check for overflow in size
6053 calculations. Don't update size until allocation succeeds.
6054 Redo calculations to avoid overflow.
6055 * keyboard.h: Change prototypes to match the above.
6057 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6059 (current_minor_maps): Check for size calculation overflow.
6060 * keymap.h: Change prototypes to match the above.
6062 * lread.c (read1, init_obarray): Don't update size until alloc done.
6064 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6065 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6067 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6068 Now ptrdiff_t, not int.
6069 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6070 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6072 * process.c (Fnetwork_interface_list): Check for overflow
6073 in size calculation.
6075 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6077 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6078 overflow. Don't bother calling xmalloc when xrealloc will do.
6080 * search.c (Freplace_match): Check for size calculation overflow.
6081 (Fset_match_data): Don't assume list lengths fit in 'int'.
6083 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6084 for command line length. Do not attempt to address one before the
6085 beginning of an array, as that's not portable.
6087 * term.c (max_frame_lines): Remove; unused.
6088 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6090 (encode_terminal_code, calculate_costs): Check for size
6091 calculation overflow.
6092 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6093 table lengths and related sizes. Don't update size until alloc
6094 done. Redo calculations to avoid overflow.
6095 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6097 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6098 subtracting pointers.
6099 (gobble_line): Check for overflow more carefully. Don't update size
6102 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6103 Don't update size until alloc done.
6104 Redo size calculations to avoid overflow.
6105 Check for size calculation overflow.
6106 (main) [DEBUG]: Fix typo in invoking tparam1.
6108 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6109 Use ptrdiff_t, not int, for sizes.
6110 (store_mode_line_noprop_char): Don't update size until alloc done.
6112 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6113 Use ptrdiff_t, not int, for sizes.
6114 (Finternal_make_lisp_face, cache_face):
6115 Check for size calculation overflow.
6116 (cache_face): Treat size calculation overflows as if they were
6117 memory exhaustion (the usual treatment), rather than aborting.
6119 * xfns.c (x_encode_text, x_set_name_internal)
6120 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6121 sizes, since they can exceed INT_MAX in size. Check for size
6122 calculation overflow.
6124 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6125 (xg_select): Check for size calculation overflow.
6126 Don't update size until alloc done.
6128 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6129 as sprintf is limited to int lengths.
6131 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6132 (X_LONG_MIN): New macros.
6133 Use them to make the following changes clearer.
6134 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6135 This change doesn't affect the value now, but it may help remind
6136 future maintainers not to raise the value too much later.
6137 (SELECTION_QUANTUM): Remove, replacing with ...
6138 (selection_quantum): ... new function, which avoids overflow.
6140 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6141 assumption that selection length fits in 'int'.
6142 (x_reply_selection_request, x_handle_selection_request)
6143 (x_get_window_property, receive_incremental_selection)
6144 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6145 (lisp_data_to_selection_data, clean_local_selection_data):
6146 Use ptrdiff_t, not int, to record length of selection.
6147 (x_reply_selection_request, x_get_window_property)
6148 (receive_incremental_selection, x_property_data_to_lisp):
6149 Redo calculations to avoid overflow.
6150 (x_reply_selection_request): When sending hint, ceiling it at
6151 X_LONG_MAX rather than relying on wraparound overflow to send
6153 (x_get_window_property, receive_incremental_selection)
6154 (lisp_data_to_selection_data, x_property_data_to_lisp):
6155 Check for size-calculation overflow.
6156 (x_get_window_property, receive_incremental_selection)
6157 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6158 Don't store size until memory allocation succeeds.
6159 (x_get_window_property): Plug memory leak on memory exhaustion.
6160 Don't double-block input; malloc is safe here. Don't assume 2**34
6161 - 4 fits in unsigned long. Add an xassert to check
6162 XGetWindowProperty overflow. Be more careful about overflow
6163 calculations, and distinguish size from memory overflow better.
6164 (receive_incremental_selection): When tracing, don't assume
6165 unsigned int is less than INT_MAX.
6166 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6167 harmful) conversions of unsigned short to int.
6168 (lisp_data_to_selection_data): Don't assume that integers
6169 in the range -65535 through -1 fit in an X unsigned short.
6170 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6171 result parameters unless successful. Rely on cons_to_unsigned
6172 to report problems with elements; the old code wasn't right anyway.
6173 (x_check_property_data): Check for int overflow; we cannot use
6174 a wider type due to X limits.
6175 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6177 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6179 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6180 (x_term_init): Check for size calculation overflow.
6181 (x_color_cells): Don't store size until memory allocation succeeds.
6182 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6183 Don't assume alloca size is less than MAX_ALLOCA.
6184 (x_term_init): Don't assume length fits in int (sprintf is limited
6187 Use ptrdiff_t for composition IDs.
6188 * character.c (lisp_string_width):
6189 * composite.c (composition_table_size, n_compositions)
6190 (get_composition_id, composition_gstring_from_id):
6191 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6192 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6193 * window.c (Frecenter):
6194 Use ptrdiff_t, not int, for composition IDs.
6195 * composite.c (get_composition_id): Check for integer overflow.
6196 * composite.h: Adjust prototypes to match the above changes.
6198 Use ptrdiff_t for hash table indexes.
6199 * category.c (hash_get_category_set):
6200 * ccl.c (ccl_driver):
6201 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6202 * coding.c (coding_system_charset_list, detect_coding_system):
6203 * coding.h (struct coding_system.id):
6204 * composite.c (get_composition_id, gstring_lookup_cache):
6205 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6206 * image.c (xpm_get_color_table_h):
6207 * lisp.h (hash_lookup, hash_put):
6208 * minibuf.c (Ftest_completion):
6209 Use ptrdiff_t for hash table indexes, not int (which is too
6210 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6211 32-bit --with-wide-int hosts).
6213 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6214 Add a FIXME comment about memory leaks.
6215 (syms_of_charset): Don't assume xmalloc returns.
6217 Don't assume that stated character widths fit in int.
6218 * character.c (Fchar_width, c_string_width, lisp_string_width):
6219 * character.h (CHAR_WIDTH):
6220 * indent.c (MULTIBYTE_BYTES_WIDTH):
6221 Use sanitize_char_width to avoid undefined and/or bad behavior
6222 with outlandish widths.
6223 * character.h (sanitize_tab_width): Rename from sanitize_width,
6224 now that we have two such functions. All uses changed.
6225 (sanitize_char_width): New inline function.
6227 Don't assume that tab-width fits in int.
6228 * character.h (sanitize_width): New inline function.
6229 (SANE_TAB_WIDTH): New macro.
6230 (ASCII_CHAR_WIDTH): Use it.
6231 * indent.c (sane_tab_width): Remove. All uses replaced by
6232 SANE_TAB_WIDTH (current_buffer).
6233 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6235 * fileio.c: Integer overflow issues with file modes.
6236 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6238 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6239 Remove unreachable code.
6240 (read_hex, load_charset_map_from_file): Check for integer overflow.
6242 * xterm.c: Don't go over XClientMessageEvent limit.
6243 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6244 (x_send_scroll_bar_event): Likewise. Check that the size does not
6245 exceed limits imposed by XClientMessageEvent, as well as the usual
6246 ptrdiff_t and size_t limits.
6248 * keyboard.c: Overflow, signedness and related fixes.
6249 (make_lispy_movement): Use same integer type in forward decl
6250 that is used in the definition.
6251 (read_key_sequence, keyremap_step):
6252 Change bufsize argument back to int, undoing my 2011-03-30 change.
6253 We prefer signed types, and int is wide enough here.
6254 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6255 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6256 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6257 length, not size_t. Use ptrdiff_t for index, not int.
6258 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6259 possibility of integer overflow.
6261 Overflow, signedness and related fixes for images.
6263 * dispextern.h (struct it.stack[0].u.image.image_id)
6264 (struct_it.image_id, struct image.id, struct image_cache.size)
6265 (struct image_cache.used, struct image_cache.ref_count):
6266 * gtkutil.c (update_frame_tool_bar):
6267 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6268 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6269 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6270 * nsmenu.m (update_frame_tool_bar):
6271 * xdisp.c (calc_pixel_width_or_height):
6272 * xfns.c (image_cache_refcount):
6273 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6274 on typical 64-bit hosts.
6276 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6277 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6278 Omit unnecessary casts to int.
6279 (parse_image_spec): Check that integers fall into 'int' range
6280 when the callers expect that.
6281 (image_ascent): Redo ascent calculation to avoid int overflow.
6282 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6283 (lookup_image): Remove unnecessary tests.
6284 (xbm_image_p): Locals are now of int, not EMACS_INT,
6285 since parse_image_check makes sure they fit into int.
6286 (png_load, gif_load, svg_load_image):
6287 Prefer int to unsigned where either will do.
6288 (tiff_handler): New function, combining the cores of the
6289 old tiff_error_handler and tiff_warning_handler.
6290 This function is rewritten to use vsnprintf and thereby avoid
6291 stack buffer overflows. It uses only the features of vsnprintf
6292 that are common to both POSIX and native Microsoft.
6293 (tiff_error_handler, tiff_warning_handler): Use it.
6294 (tiff_load, gif_load, imagemagick_load_image):
6295 Don't assume :index value fits in 'int'.
6296 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6297 (imagemagick_load_image): Check that crop parameters fit into
6298 the integer types that MagickCropImage accepts. Don't assume
6299 Vimagemagick_render_type has a nonnegative value. Don't assume
6300 size_t fits in 'long'.
6301 (gs_load): Use printmax_t to print the widest integers possible.
6302 Check for integer overflow when computing image height and width.
6304 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6306 * xdisp.c (redisplay_window): Don't force window start if point
6307 will be invisible in the resulting window. (Bug#9324)
6309 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6311 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6312 the display spec is of the form `(space ...)'.
6313 (handle_display_spec): Return the value returned by
6314 handle_single_display_spec, not just 1 or zero.
6315 (handle_single_display_spec): If the display spec is of the form
6316 `(space ...)', and specifies display in the text area, return 2
6318 (try_cursor_movement): Check for the need to scroll more
6319 accurately, and prefer exact match for point under bidi.
6320 Don't advance `row' beyond the last row of the window.
6322 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6323 into disp_prop; all users changed.
6325 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6326 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6327 for the text covered by the display property.
6329 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6331 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6332 Change return value to nil.
6333 (Frecord_buffer): Delete unused function.
6335 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6337 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6338 buffers, return left-to-right.
6339 (set_cursor_from_row): Consider candidate row a win if its glyph
6340 represents a newline and point is on that newline. Fixes cursor
6341 positioning on the newline at EOL of R2L text within L2R
6342 paragraph, and vice versa.
6343 (try_cursor_movement): Check continued rows, in addition to
6344 continuation rows. Fixes unwarranted scroll when point enters a
6345 continued line of R2L text within an L2R paragraph, or vice versa.
6346 (cursor_row_p): Consider the case of point being equal to
6347 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6348 from the end of a short line to the beginning of a continued line
6349 of R2L text within L2R paragraph.
6350 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6351 composed characters.
6353 * bidi.c (bidi_check_type): Use xassert.
6354 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6357 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6359 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6362 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6364 * nsfont.m (ns_otf_to_script): Fix typo.
6366 2011-08-22 Kenichi Handa <handa@m17n.org>
6368 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6369 extra slot even if the purpose is char-code-property-table.
6371 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6373 * xdisp.c (redisplay_window): When computing centering_position,
6374 account for the height of the header line. (Bug#8874)
6376 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6377 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6378 candidate is selected by the mouse, and that candidate has a
6379 composed character under the mouse.
6381 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6382 coordinates reported by pos-visible-in-window-p for a composed
6383 character in column zero.
6385 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6387 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6389 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6391 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6392 consider it a hit if to_charpos is anywhere in the range of the
6393 composed buffer positions.
6395 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6397 * image.c (gif_load): Don't assume that each subimage has the same
6398 dimensions as the base image. Handle disposal method that is
6399 "undefined" by the gif spec (Bug#9335).
6401 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6403 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6404 (Fcondition_case): Document `debug' symbol in error handler.
6406 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6408 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6409 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6410 from an Org mode buffer to a Speedbar frame.
6412 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6413 a composition, take its buffer position from IT->cmp_it.charpos.
6414 Fixes cursor positioning at the beginning of a line that begins
6415 with a composed character.
6417 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6419 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6420 character bidirectional type, use STRONG_L instead. Fixes crashes
6421 in a buffer produced by `describe-categories'.
6423 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6424 members before the level stack, so they would be saved and
6425 restored when copying iterator state. Fixes incorrect reordering
6426 around TABs covered by display properties.
6428 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6430 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6432 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6434 * eval.c (internal_condition_case, internal_condition_case_1)
6435 (internal_condition_case_2, internal_condition_case_n):
6436 Remove unnecessary aborts (Bug#9081).
6438 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6440 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6441 has no `load' handler, try opening the file locally. (Bug#9311)
6443 2011-08-16 Ken Brown <kbrown@cornell.edu>
6445 * gmalloc.c: Expand comment.
6447 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6449 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6450 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6452 2011-08-16 Ken Brown <kbrown@cornell.edu>
6454 Fix memory allocation problems in Cygwin build (Bug#9273).
6456 * unexcw.c ( __malloc_initialized): Declare external variable.
6457 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6459 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6461 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6463 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6465 [CYGWIN] (special_realloc): New function.
6466 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6467 requests to realloc storage in the static heap.
6469 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6471 * bidi.c (bidi_initialize): Remove unused local.
6473 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6476 * biditype.h: Remove file.
6477 * makefile.w32-in ($(BLD)/bidi.$(O)):
6478 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6480 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6482 * chartab.c: Improve commentary for the uniprop_table API.
6484 * bidi.c (bidi_paragraph_init): Support zero value of
6485 bidi_ignore_explicit_marks_for_paragraph_level.
6486 (bidi_initialize): Use uniprop_table instead of including
6487 biditype.h and bidimirror.h.
6489 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6490 coordinates of the iterator when restoring from ppos_it.
6493 2011-08-14 Kenichi Handa <handa@m17n.org>
6495 * process.c (create_process): Call setup_process_coding_systems
6496 after the pid of the process is set to -1 (Bug#8162).
6498 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6500 * xdisp.c (move_it_in_display_line_to): Don't invoke
6501 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6502 ppos_it. Fixes vertical cursor motion when line beginning is
6503 covered by an image. (Bug#9296)
6505 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6507 * nsterm.h (ns_run_ascript): Declare.
6508 (NSAPP_DATA2_RUNASSCRIPT): Define.
6510 * nsfns.m (as_script, as_result, as_status): New static variables.
6511 (ns_run_ascript): New function.
6512 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6513 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6514 the event loop. Get status from as_status (Bug#7276).
6516 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6517 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6518 the event loop (Bug#7276).
6520 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6522 * gnutls.c (QCgnutls_bootprop_priority)
6523 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6524 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6525 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6526 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6527 (QCgnutls_bootprop_verify_hostname_error)
6528 (QCgnutls_bootprop_callbacks_verify): Rename from
6529 Qgnutls_bootprop_..., all uses changed.
6531 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6534 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6536 * xfaces.c (Qframe_set_background_mode): Now static.
6537 * dispextern.h (Qframe_set_background_mode): Remove decl.
6539 * process.c (Fnetwork_interface_info): Declare local only if needed.
6541 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6543 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6544 (Fnetwork_interface_list): Allocate in increments of bytes instead
6545 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6546 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6548 (struct ifflag_def): notrailers is smart on OSX.
6549 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6550 Get hardware address with getifaddrs if available.
6552 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6554 * xdisp.c (iterate_out_of_display_property): xassert that
6555 IT->position is set to within IT->object's boundaries. Break from
6556 the loop as soon as EOB is reached; avoids infloops in redisplay
6557 when IT->position is set up wrongly due to some bug.
6558 Set IT->current to match the bidi iterator unconditionally.
6559 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6560 entry. Force push_it to save on the stack the current
6561 buffer/string position, to be restored by pop_it. Fix flags in
6562 the iterator structure wrt the object coming from a display
6563 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6564 properties. (Bug#9284)
6566 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6568 * fontset.c (fontset_get_font_group): Add proper type checks.
6571 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6573 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6574 and LC_VERSION_MIN_MACOSX.
6575 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6576 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6578 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6580 * xdisp.c (forward_to_next_line_start): Allow to use the
6581 no-display-properties-and-no-overlays under bidi display.
6582 Set disp_pos in the bidi iterator to avoid searches for display
6583 properties and overlays.
6585 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6587 * editfns.c (Fset_time_zone_rule): Document relationship with the
6590 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6591 the font entity extracted from the cache (Bug#8109).
6593 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6595 * composite.c (autocmp_chars): Don't reset point. That is done by
6596 restore_point_unwind (Bug#5984).
6598 2011-08-07 Juri Linkov <juri@jurta.org>
6600 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6601 to show the arg `TIME' instead of `TIMEVAL'.
6603 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6605 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6606 display property strides EOL and includes a newline, as in
6607 longlines-mode. (Bug#9254)
6608 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6609 word-wrap under bidirectional display. (Bug#9224)
6611 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6612 is non-zero, even if the data buffer is NULL. Fixes a crash in
6613 vertical-motion with longlines-mode. (Bug#9254)
6615 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6617 * bidi.c <bidi_cache_total_alloc>: Now static.
6618 (bidi_initialize): Initialize bidi_cache_total_alloc.
6620 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6623 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6624 amount allocated this far in `bidi_cache_total_alloc'.
6625 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6626 non-zero, only free the data buffer without restoring the cache
6627 contents. All callers changed.
6629 * dispextern.h (bidi_unshelve_cache): Update prototype.
6631 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6632 (move_it_in_display_line, move_it_to)
6633 (move_it_vertically_backward, move_it_by_lines): Replace the call
6634 to xfree to an equivalent call to bidi_unshelve_cache.
6635 (move_it_in_display_line_to): Fix logic of returning
6636 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6638 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6640 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6641 came from a string character with a `cursor' property. (Bug#9229)
6643 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6645 * Makefile.in (LIB_PTHREAD): New variable.
6646 (LIBES): Add LIB_PTHREAD (Bug#9216).
6648 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6649 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6651 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6653 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6655 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6657 * xterm.c (x_find_topmost_parent): New function.
6658 (x_set_frame_alpha): Find topmost parent window with
6659 x_find_topmost_parent and set the property there also (bug#9181).
6660 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6662 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6664 * callproc.c (Fcall_process): Avoid vfork clobbering
6665 the local vars buffer, coding_systems, current_dir.
6667 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6669 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6671 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6673 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6674 so that it is not optimized away.
6676 * xdisp.c (compute_display_string_pos): Remove unused local.
6678 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6680 Fix slow cursor motion and scrolling in large buffers with
6681 selective display, like Org Mode buffers. (Bug#9218)
6683 * dispextern.h (struct bidi_it): New member disp_prop_p.
6685 * xdisp.c: Remove one-slot cache of display string positions.
6686 (compute_display_string_pos): Accept an additional argument
6687 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6688 for a display string or property. If found, set DISP_PROP_P
6691 * bidi.c (bidi_fetch_char): Accept an additional argument
6692 DISP_PROP_P, and pass it to compute_display_string_pos.
6693 Only handle text covered by a display string if DISP_PROP_P is returned
6694 non-zero. All callers of bidi_fetch_char changed.
6696 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6698 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6700 2010-12-03 Don March <don@ohspite.net>
6702 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6703 last character M-[char] is translated to ESC [char] (bug#7541).
6705 2011-08-02 Kenichi Handa <handa@m17n.org>
6707 * lisp.h (uniprop_table): Extern it.
6709 * chartab.c (uniprop_table): Make it non-static.
6711 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6713 * xdisp.c (forward_to_next_line_start): Accept additional argument
6714 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6716 (reseat_at_next_visible_line_start): Use the bidi iterator state
6717 returned by forward_to_next_line_start to restore the state of
6718 it->bidi_it after backing up to previous newline. (Bug#9212)
6720 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6722 * regex.c (re_comp): Protoize.
6723 (re_exec): Fix return type.
6724 (regexec): Fix type of `ret'. (Bug#9203)
6726 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6728 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6729 This is needed if max-image-size is a floating-point number.
6731 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6733 * print.c (print_object): Print empty symbol as ##.
6735 * lread.c (read1): Read ## as empty symbol.
6737 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6739 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6740 setting frame foreground color (Bug#9175).
6741 (x_set_background_color): Likewise.
6743 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6744 contents (Bug#9176).
6745 (EmacsTooltip -init): Remove bezels and add shadows to
6748 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6749 or scroll bar (Bug#8470).
6751 * nsfont.m (nsfont_open): Remove assignment to voffset and
6752 unnecessary vars hshink, expand, hd, full_height, min_height.
6753 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6755 * nsterm.h (nsfont_info): Remove voffset field.
6757 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6759 Implement strike-through and overline on NextStep (Bug#8863).
6761 * nsfont.m (nsfont_open): Use underline position provided by font,
6762 instead of hard-coded value of 2.
6763 (nsfont_draw): Call ns_draw_text_decoration instead.
6765 * nsterm.h: Add declaration for ns_draw_text_decoration.
6767 * nsterm.m (ns_draw_text_decoration): New function for drawing
6768 underline, overline, and strike-through.
6769 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6770 ns_draw_text_decoration. Change treatment of cursor drawing to
6771 accommodate underlining, etc.
6773 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6775 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6778 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6780 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6781 Without this fix, if a signal arrives just after memory fills up,
6782 'malloc' might be invoked reentrantly.
6784 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6785 In other words, assume that every image size is allowed, on non-X
6786 hosts. This assumption is probably wrong, but it lets Emacs compile.
6788 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6790 * regex.c (re_iswctype): Convert return values to boolean.
6792 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6794 * xdisp.c (compute_display_string_pos): Don't use cached display
6795 string position if the buffer had its restriction changed.
6798 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6800 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6802 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6804 Integer signedness and overflow and related fixes. (Bug#9079)
6806 * bidi.c: Integer size and overflow fixes.
6807 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6808 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6809 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6810 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6811 (bidi_find_other_level_edge):
6812 Use ptrdiff_t instead of EMACS_INT where either will do.
6813 This works better on 32-bit hosts configured --with-wide-int.
6814 (bidi_cache_ensure_space): Check for size-calculation overflow.
6815 Use % rather than repeated addition, for better worst-case speed.
6816 Don't set bidi_cache_size until after xrealloc returns, because it
6818 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6819 (bidi_cache_ensure_space): Also check that the bidi cache size
6820 does not exceed that of the largest Lisp string or buffer. See Eli
6821 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6823 * alloc.c (__malloc_size_t): Remove.
6824 All uses replaced by size_t. See Andreas Schwab's note
6825 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6827 * image.c: Improve checking for integer overflow.
6828 (check_image_size): Assume that f is nonnull, since
6829 it is always nonnull in practice. This is one less thing to
6830 worry about when checking for integer overflow later.
6831 (x_check_image_size): New function, which checks for integer
6832 overflow issues inside X.
6833 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6834 This removes the need for a memory_full check.
6835 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6836 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6837 (xbm_read_bitmap_data): Change locals back to 'int', since
6838 their values must fit in 'int'.
6839 (xpm_load_image, png_load, tiff_load):
6840 Invoke x_create_x_image_and_pixmap earlier,
6841 to avoid much needless work if the image is too large.
6842 (tiff_load): Treat overly large images as if
6843 x_create_x_image_and_pixmap failed, not as malloc failures.
6844 (gs_load): Use x_check_image_size.
6846 * gtkutil.c: Omit integer casts.
6847 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6848 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6850 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6852 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6853 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6854 would wrongly return t on a 64-bit host.
6856 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6857 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6858 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6859 and therefore cause GCC to emit a bogus diagnostic in some cases.
6861 * image.c: Integer signedness and overflow and related fixes.
6862 This is not an exhaustive set of fixes, but it's time to
6863 record what I've got.
6864 (lookup_pixel_color, check_image_size): Remove redundant decls.
6865 (check_image_size): Don't assume that arbitrary EMACS_INT values
6866 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6867 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6868 (tiff_load, imagemagick_load_image):
6869 Check for overflow in size calculations.
6870 (x_create_x_image_and_pixmap): Remove unnecessary test for
6871 xmalloc returning NULL; that can't happen.
6872 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6873 (xpm_color_bucket): Use better integer hashing function.
6874 (xpm_cache_color): Don't possibly over-allocate memory.
6875 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6876 (gif_memory_source):
6877 Use ptrdiff_t, not int or size_t, to record sizes.
6878 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6879 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6880 either works, as we prefer signed integers.
6881 (tiff_read_from_memory, tiff_write_from_memory):
6882 Return tsize_t, not size_t, since that's what the TIFF API wants.
6883 (tiff_read_from_memory): Don't fail simply because the read would
6884 go past EOF; instead, return a short read.
6885 (tiff_load): Omit no-longer-needed casts.
6886 (Fimagemagick_types): Don't assume size fits into 'int'.
6888 Improve hashing quality when configured --with-wide-int.
6889 * fns.c (hash_string): New function, taken from sxhash_string.
6890 Do not discard information about ASCII character case; this
6891 discarding is no longer needed.
6892 (sxhash-string): Use it. Change sig to match it. Caller changed.
6893 * lisp.h: Declare it.
6894 * lread.c (hash_string): Remove, since we now use fns.c's version.
6895 The fns.c version returns a wider integer if --with-wide-int is
6896 specified, so this should help the quality of the hashing a bit.
6898 * emacs.c: Integer overflow minor fix.
6899 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6900 Define only if GNU_LINUX.
6901 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6903 * dispnew.c: Integer signedness and overflow fixes.
6904 Remove unnecessary forward decls, that were a maintenance hassle.
6905 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6907 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6908 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6909 (prepare_desired_row, line_draw_cost):
6910 Use int, not unsigned, where either works.
6911 (save_current_matrix, restore_current_matrix):
6912 Use ptrdiff_t, not size_t, where either works.
6913 (init_display): Check for overflow more accurately, and without
6914 relying on undefined behavior.
6916 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6917 Remove, replacing with the new symbols in lisp.h. All uses changed.
6918 * fileio.c (make_temp_name):
6919 * filelock.c (lock_file_1, lock_file):
6920 * xdisp.c (message_dolog):
6921 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6922 Use pMd etc. instead.
6923 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6924 replacing the pWIDE etc. symbols removed from editfns.c.
6926 * keyboard.h (num_input_events): Now uintmax_t.
6927 This is (very slightly) less likely to mess up due to wraparound.
6930 * buffer.c: Integer signedness fixes.
6931 (alloc_buffer_text, enlarge_buffer_text):
6932 Use ptrdiff_t rather than size_t when either will do, as we prefer
6935 * alloc.c: Integer signedness and overflow fixes.
6936 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6937 (__malloc_size_t): Default to size_t, not to int.
6938 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6939 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6940 Prefer ptrdiff_t to size_t when either would do, as we prefer
6942 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6943 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6944 Now const. Initialize with values that are in range even if char
6946 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6947 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6948 These functions do the right thing with sizes > 2**32.
6949 (check_depth): Now ptrdiff_t, not int.
6950 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6951 Adjust to new way of storing sizes. Check for size overflow bugs
6953 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6954 slightly wrong anyway, as it missed one instance of
6955 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6956 (refill_memory_reserve): Omit needless cast to size_t.
6957 (mark_object_loop_halt): Mark as externally visible.
6959 * xselect.c: Integer signedness and overflow fixes.
6960 (Fx_register_dnd_atom, x_handle_dnd_message):
6961 Use ptrdiff_t, not size_t, since we prefer signed.
6962 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6963 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6964 x_dnd_atoms_size and x_dnd_atoms_length.
6966 * doprnt.c: Prefer signed to unsigned when either works.
6968 * doprnt.c (doprnt):
6970 * xdisp.c (vmessage):
6971 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6972 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6973 prefer signed arithmetic to avoid comparison confusion.
6974 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6975 but is a bit tricky.
6977 Assume freestanding C89 headers, string.h, stdlib.h.
6978 * data.c, doprnt.c, floatfns.c, print.c:
6979 Include float.h unconditionally.
6980 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6981 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6982 * regex.c: Likewise for stddef.h, string.h.
6983 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6984 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6985 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6986 (STDC_HEADERS): Remove obsolete defines.
6987 * sysdep.c: Include limits.h unconditionally.
6989 Assume support for memcmp, memcpy, memmove, memset.
6990 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6991 * regex.c (memcmp, memcpy):
6992 Remove; we assume C89 now.
6994 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6995 (__malloc_safe_bcopy): Remove; no longer needed.
6997 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6998 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6999 well either way, and we prefer signed to unsigned.
7001 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7003 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7004 closes the connection while we're reading (bug#9182).
7006 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7008 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7009 are specified (Bug#9168).
7011 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7013 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7014 Found by GCC static checking and --with-wide-int on a 32-bit host.
7016 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7018 * xdisp.c (compute_display_string_pos): Fix logic of caching
7019 previous display string position. Initialize cached_prev_pos to
7020 -1. Fixes slow-down at the beginning of a buffer.
7022 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7024 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7025 for attrs[LFACE_FONTSET_INDEX].
7027 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7029 * xml.c (parse_region): Remove unused local
7030 that was recently introduced.
7032 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7034 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7035 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7037 * xdisp.c (move_it_in_display_line_to): Record the best matching
7038 position for TO_CHARPOS while scanning the line, and restore it on
7039 exit if none of the characters scanned was an exact match.
7040 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7041 when exact match is impossible due to invisible text, and the
7042 lines are truncated.
7044 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7046 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7049 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7051 Fix a significant slow-down of cursor motion with C-n, C-p,
7052 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7053 auto-repeat under bidi redisplay in fontified buffers.
7054 * xdisp.c (compute_stop_pos_backwards): New function.
7055 (next_element_from_buffer): Call compute_stop_pos_backwards to
7056 find a suitable prev_stop when we find ourselves before
7058 (reseat): Don't look for prev_stop, as that could mean a very long
7060 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7061 <cached_disp_overlay_modiff>: Cache for last found display string
7063 (compute_display_string_pos): Return the cached position if asked
7064 about the same buffer in the same area of character positions, and
7065 the buffer wasn't changed since the time the display string
7066 position was cached.
7068 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7070 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7071 is an integer, which is important for empty lines. (Bug#9149)
7073 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7075 * frame.c (Fmodify_frame_parameters): In tty case, update the
7076 default face if necessary (Bug#4238).
7078 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7080 * editfns.c (Fstring_to_char): No need to explain what a character
7081 is in the docstring (Bug#6576).
7083 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7085 * xml.c (parse_region): Make sure we always return a tree.
7087 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7089 * xml.c (parse_region): If a document contains only comments,
7092 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7094 * xml.c (make_dom): Return comments, too.
7096 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7099 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7100 and the surrounding thread.
7101 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7102 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7103 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7105 * s/openbsd.h (BROKEN_SIGIO): Define.
7106 * unexelf.c (unexec) [__OpenBSD__]:
7107 Don't update the .mdebug section of the Alpha COFF symbol table.
7109 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7111 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7114 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7116 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7117 This fixes some race conditions on the permissions of any newly
7120 * alloc.c (valid_pointer_p): Use pipe, not open.
7121 This fixes some permissions issues when debugging.
7123 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7124 If fchown fails to set both uid and gid, try to set just gid,
7125 as that is sometimes allowed. Adjust the file's mode to eliminate
7126 setuid or setgid bits that are inappropriate if fchown fails.
7128 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7130 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7131 to compare Lisp_Objects.
7132 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7133 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7134 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7136 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7138 * lread.c (read_integer): Unread even EOF character.
7139 (read1): Likewise. Properly record start position of symbol.
7141 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7142 symbol character follows.
7144 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7146 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7147 This works around a problem with the previous change to Fcopy_file.
7148 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7149 and without this change, GCC might complain about discarding
7150 fchown's return value.
7152 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7154 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7156 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7158 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7160 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7162 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7163 it's used from the C level.
7165 * process.c: Use the same condition for POLL_FOR_INPUT in both
7166 keyboard.c and process.c (bug#1858).
7168 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7170 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7171 (Fgnutls_boot): Use it.
7173 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7175 * doc.c (Fsubstitute_command_keys): Revert last change.
7177 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7179 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7180 quotes the next character, and doesn't affect other longer
7181 sequences (bug#8935).
7183 * lread.c (syms_of_lread): Clarify that is isn't only
7184 `eval-buffer' and `eval-defun' that's affected by
7185 `lexical-binding' (bug#8460).
7187 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7189 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7190 bidi redisplay when a line includes both an image and is truncated.
7192 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7194 Fix minor problems found by static checking.
7195 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7196 (elsz): Now a signed constant, not a size_t var. We prefer signed
7197 types to unsigned, to avoid integer comparison confusion. Without
7198 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7199 "cannot optimize loop, the loop counter may overflow", a symptom
7201 * indent.c (Fvertical_motion): Mark locals as initialized.
7202 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7204 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7206 * search.c (Fre_search_backward): Mention `case-fold-search' in
7207 all the re_search_* functions (bug#8138).
7209 * keyboard.c (Fopen_dribble_file): Document when the file is
7212 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7214 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7217 Support bidi reordering of display and overlay strings.
7218 * xdisp.c (compute_display_string_pos)
7219 (compute_display_string_end): Accept additional argument STRING.
7220 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7221 (reseat_to_string): Initialize bidi_it->string.s and
7222 bidi_it->string.schars.
7223 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7224 NULL (avoids a crash in bidi_paragraph_init).
7225 Initialize itb.string.lstring.
7226 (init_iterator): Call bidi_init_it only of a valid
7227 buffer position was specified. Initialize paragraph_embedding to
7229 (reseat_to_string): Initialize the bidi iterator.
7230 (display_string): If we need to ignore text properties of
7231 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7232 original value of -1 will not work with bidi.)
7233 (compute_display_string_pos): First arg is now struct
7234 `text_pos *'; all callers changed. Support display properties on
7236 (compute_display_string_end): Support display properties on Lisp
7238 (init_iterator, reseat_1, reseat_to_string): Initialize the
7239 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7240 when iterating on a string not from display properties).
7241 (compute_display_string_pos, compute_display_string_end):
7242 Fix calculation of the object to scan. Fixes an error when using
7244 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7245 base_level_stop; instead, set base_level_stop to BEGV.
7246 Fixes crashes in vertical-motion.
7247 (next_element_from_buffer): Improve commentary for when
7248 the iterator is before prev_stop.
7249 (init_iterator): Initialize bidi_p from the default value of
7250 bidi-display-reordering, not from buffer-local value. Use the
7251 buffer-local value only if initializing for buffer iteration.
7252 (handle_invisible_prop): Support invisible properties on strings
7253 that are being bidi-reordered.
7254 (set_iterator_to_next): Support bidi reordering of C strings and
7256 (next_element_from_string): Support bidi reordering of Lisp
7258 (handle_stop_backwards): Support Lisp strings as well.
7259 (display_string): Support display of R2L glyph rows.
7260 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7261 (init_iterator): Don't initialize it->bidi_p for strings
7263 (reseat_to_string): Initialize it->bidi_p for strings here.
7264 (next_element_from_string, next_element_from_c_string)
7265 (next_element_from_buffer): Add xassert's for correspondence
7266 between IT's object being iterated and it->bidi_it.string
7268 (face_before_or_after_it_pos): Support bidi iteration.
7269 (next_element_from_c_string): Handle the case of the first string
7270 character that is not the first one in the visual order.
7271 (get_visually_first_element): New function, refactored from common
7272 parts of next_element_from_buffer, next_element_from_string, and
7273 next_element_from_c_string.
7274 (tool_bar_lines_needed, redisplay_tool_bar)
7275 (display_menu_bar): Force left-to-right direction. Add a FIXME
7276 comment for making that be controlled by a user option.
7277 (push_it, pop_it): Save and restore the state of the
7278 bidi iterator. Save and restore the bidi_p flag.
7279 (pop_it): Iterate out of display property for string iteration as
7281 (iterate_out_of_display_property): Support iteration over strings.
7282 (handle_single_display_spec): Set up it->bidi_it for iteration
7283 over a display string, and call bidi_init_it.
7284 (handle_single_display_spec, next_overlay_string)
7285 (get_overlay_strings_1, push_display_prop): Set up the bidi
7286 iterator for displaying display or overlay strings.
7287 (forward_to_next_line_start): Don't use the shortcut if
7289 (back_to_previous_visible_line_start): If handle_display_prop
7290 pushed the iterator stack, restore the internal state of the bidi
7291 iterator by calling bidi_pop_it same number of times.
7292 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7293 and we are bidi-iterating, don't decrement the iterator position;
7294 instead, set the first_elt flag in the bidi iterator, to produce
7296 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7297 (push_display_prop): xassert that we are iterating a buffer.
7298 (push_it, pop_it): Save and restore paragraph_embedding member.
7299 (handle_single_display_spec, next_overlay_string)
7300 (get_overlay_strings_1, reseat_1, reseat_to_string)
7301 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7302 correctly. Don't assume unibyte strings are not bidi-reordered.
7303 (compute_display_string_pos)
7304 (compute_display_string_end): Fix handling the case of C string.
7305 (push_it, pop_it): Save and restore from_disp_prop_p.
7306 (handle_single_display_spec, push_display_prop): Set the
7307 from_disp_prop_p flag.
7308 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7309 (pop_it): Call iterate_out_of_display_property only if we are
7310 popping after iteration over a string that came from a display
7311 property. Fix a typo in popping stretch info. Add an assertion
7312 for verifying that the iterator position is in sync with the bidi
7314 (handle_single_display_spec, get_overlay_strings_1)
7315 (push_display_prop): Fix initialization of paragraph direction for
7316 string when that of the parent object is not yet determined.
7317 (reseat_1): Call bidi_init_it to resync the bidi
7318 iterator with IT's position. (Bug#7616)
7319 (find_row_edges): If ROW->start.pos gives position
7320 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7321 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7322 Reset the from_disp_prop_p flag.
7323 (SAVE_IT, RESTORE_IT): New macros.
7324 (pos_visible_p, face_before_or_after_it_pos)
7325 (back_to_previous_visible_line_start)
7326 (move_it_in_display_line_to, move_it_in_display_line)
7327 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7328 (try_scrolling, redisplay_window, display_line): Use them when
7329 saving a temporary copy of the iterator and restoring it back.
7330 (back_to_previous_visible_line_start, reseat_1)
7331 (init_iterator): Empty the bidi cache "stack".
7332 (move_it_in_display_line_to): If iterator ended up at
7333 EOL, but we never saw any buffer positions smaller than
7334 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7335 motion in bidi-reordered lines.
7336 (move_it_in_display_line_to): Record prev_method and prev_pos
7337 immediately before the call to set_iterator_to_next. Fixes cursor
7338 motion in bidi-reordered lines with stretch glyphs and strings
7339 displayed in margins. (Bug#8133) (Bug#8867)
7340 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7342 (pos_visible_p): Support positions in bidi-reordered lines.
7343 Save and restore bidi cache.
7345 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7346 (bidi_paragraph_info): Delete unused struct.
7347 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7348 (bidi_cache_start): New variable.
7349 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7351 (bidi_cache_fetch_state, bidi_cache_search)
7352 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7353 (bidi_cache_find, bidi_peek_at_next_level)
7354 (bidi_level_of_next_char, bidi_find_other_level_edge)
7355 (bidi_move_to_visually_next): Compare cache index with
7356 bidi_cache_start rather than with zero.
7357 (bidi_fetch_char): Accept new argument STRING; all callers
7358 changed. Support iteration over a string. Support strings with
7359 display properties. Support unibyte strings. Fix the type of
7360 `len' according to what STRING_CHAR_AND_LENGTH expects.
7361 (bidi_paragraph_init, bidi_resolve_explicit_1)
7362 (bidi_resolve_explicit, bidi_resolve_weak)
7363 (bidi_level_of_next_char, bidi_move_to_visually_next):
7364 Support iteration over a string.
7365 (bidi_set_sor_type, bidi_resolve_explicit_1)
7366 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7367 can now be zero (for strings); special values 0 and -1 were
7368 changed to -1 and -2, respectively.
7369 (bidi_char_at_pos): New function.
7370 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7371 Call it instead of FETCH_MULTIBYTE_CHAR.
7372 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7373 initialized to valid values.
7374 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7376 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7377 the test for valid cached positions. Fix the logic for looking up
7378 the sentinel state in the cache. GCPRO the Lisp string we are
7380 (bidi_push_it, bidi_pop_it): New functions.
7381 (bidi_initialize): Initialize the bidi cache start stack pointer.
7382 (bidi_cache_ensure_space): New function, refactored from part of
7383 bidi_cache_iterator_state. Don't assume the required size is just
7384 one BIDI_CACHE_CHUNK away.
7385 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7386 (bidi_count_bytes, bidi_char_at_pos): New functions.
7387 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7388 always valid if bidi_cache_idx is valid.
7389 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7390 is valid if it's going to be used.
7391 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7392 (bidi_cache_fetch_state, bidi_cache_search)
7393 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7394 (bidi_cache_iterator_state, bidi_cache_find)
7395 (bidi_find_other_level_edge, bidi_cache_start_stack):
7396 All variables related to cache indices are now EMACS_INT.
7398 * dispextern.h (struct bidi_string_data): New structure.
7399 (struct bidi_it): New member `string'. Make flag members be 1-bit
7400 fields, and put them last in the struct.
7401 (compute_display_string_pos, compute_display_string_end):
7403 (bidi_push_it, bidi_pop_it): Add prototypes.
7404 (struct iterator_stack_entry): New members bidi_p,
7405 paragraph_embedding, and from_disp_prop_p.
7406 (struct it): Member bidi_p is now a bit field 1 bit wide.
7407 (bidi_shelve_cache, bidi_unshelve_cache):
7410 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7411 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7412 and vector-like objects.
7414 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7415 cache around display iteration.
7417 * window.c (Fwindow_end, window_scroll_pixel_based)
7418 (displayed_window_lines, Frecenter): Save and restore the bidi
7419 cache around display iteration.
7421 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7423 * editfns.c (Fdelete_region): Clarify the use of the named
7424 parameters (bug#6788).
7426 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7428 * indent.c (Fvertical_motion): Set and restore w->pointm when
7429 saving and restoring the window's buffer (Bug#9006).
7431 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7433 * editfns.c (Fstring_to_char): Clarify just what is returned
7434 (bug#6576). Text by Eli Zaretskii.
7436 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7438 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7440 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7442 * buffer.c (mmap_find): Fix a typo.
7444 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7446 Fix execution of x selection hooks.
7447 * xselect.c (Qx_lost_selection_functions)
7448 (Qx_sent_selection_functions): New vars.
7449 (syms_of_xselect): DEFSYM them.
7450 (x_handle_selection_request): Pass Qx_sent_selection_functions
7451 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7452 (x_handle_selection_clear,x_clear_frame_selections):
7453 Pass Qx_lost_selection_functions rather than
7454 Vx_lost_selection_functions to Frun_hook_with_args.
7456 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7458 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7459 The old code sometimes used this field without initializing it.
7461 * alloc.c (gc_sweep): Don't read past end of array.
7462 In theory, the old code could also have corrupted Emacs internals,
7463 though it'd be very unlikely.
7465 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7467 * character.c (Fcharacterp): Don't advertise optional ignored
7468 argument. (Bug#4026)
7470 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7472 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7475 * window.c (Fset_window_start): Doc fix (bug#4199).
7476 (Fset_window_hscroll): Ditto.
7478 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7480 Fix minor new problems caught by GCC 4.6.1.
7481 * term.c (init_tty): Remove unused local.
7482 * xsettings.c (store_monospaced_changed): Define this function only
7483 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7486 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7488 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7490 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7492 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7493 are the mini-buffer and the echo area (bug#3320).
7495 * term.c (init_tty): Remove support for supdup, c10 and perq
7496 terminals, which are no longer supported (bug#1482).
7498 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7500 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7502 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7504 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7505 for non-popups (Bug#3642).
7507 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7509 * alloc.c (reset_malloc_hooks): Protoize.
7510 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7511 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7512 * cm.c (losecursor): Likewise.
7513 * data.c (fmod): Likewise.
7514 * dispnew.c (swap_glyphs_in_rows): Likewise.
7515 * emacs.c (memory_warning_signal): Likewise.
7516 * floatfns.c (float_error): Likewise.
7517 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7518 (otf_open, font_otf_capability, generate_otf_features)
7519 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7521 * image.c (pbm_read_file): Likewise.
7522 * indent.c (string_display_width): Likewise.
7523 * intervals.c (check_for_interval, search_for_interval)
7524 (inc_interval_count, count_intervals, root_interval)
7525 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7526 * lread.c (defalias): Likewise.
7527 * ralloc.c (r_alloc_check): Likewise.
7528 * regex.c (set_image_of_range_1, set_image_of_range)
7529 (regex_grow_registers): Likewise.
7530 * sysdep.c (strerror): Likewise.
7531 * termcap.c (valid_filename_p, tprint, main): Likewise.
7532 * tparam.c (main): Likewise.
7533 * unexhp9k800.c (run_time_remap, save_data_space)
7534 (update_file_ptrs, read_header, write_header, calculate_checksum)
7535 (copy_file, copy_rest, display_header): Likewise.
7536 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7538 * xdisp.c (check_it): Likewise.
7539 * xfaces.c (register_color, unregister_color, unregister_colors):
7541 * xfns.c (print_fontset_result): Likewise.
7542 * xrdb.c (member, fatal, main): Likewise.
7544 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7546 Fix minor problems found by static checking (Bug#9031).
7547 * chartab.c (char_table_set_range, map_sub_char_table):
7548 Remove unused locals.
7549 (uniprop_table): Now static.
7550 * composite.c (_work_char): Remove unused static var.
7552 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7554 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7556 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7558 * gtkutil.c (qttip_cb): Remove code without function.
7560 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7562 * w32.c (pthread_sigmask): New stub.
7564 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7566 Use pthread_sigmask, not sigprocmask (Bug#9010).
7567 sigprocmask is portable only for single-threaded applications, and
7568 Emacs can be multi-threaded when it uses GTK.
7569 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7571 * callproc.c (Fcall_process):
7572 * process.c (create_process):
7573 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7574 Use pthread_sigmask, not sigprocmask.
7576 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7578 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7579 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7582 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7584 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7585 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7586 (xg_hide_tooltip): Fix comment.
7588 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7589 in registerServicesMenuSendTypes.
7590 (validRequestorForSendType): Don't check ns_return_types.
7592 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7595 2011-07-08 Jason Rumney <jasonr@gnu.org>
7597 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7598 SH_SHOW for hidden windows (Bug#5482).
7600 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7601 frame struct members of non-existent frames (Bug#6284).
7603 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7605 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7606 variable firstTime not needed on OSX >= 10.6.
7607 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7608 >= 10.5. Use setKnobProportion, setDoubleValue.
7610 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7611 (MAC_OS_X_VERSION_10_5): Define if not defined.
7612 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7613 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7614 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7616 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7617 cString and lossyCString on OSX >= 10.4
7619 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7620 sizeToFit on OSX >= 10.2.
7622 * nsimage.m (allocInitFromFile): Don't use deprecated method
7623 bestRepresentationForDevice on OSX >= 10.6.
7625 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7628 * emacs.c: Declare unexec_init_emacs_zone.
7630 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7632 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7634 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7635 on svcsMenu (Bug#8842).
7637 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7639 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7641 * nsterm.m (QUTF8_STRING): Declare.
7642 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7643 (validRequestorForSendType): Return type is (id).
7644 Change indexOfObjectIdenticalTo to indexOfObject.
7645 Check if we have local selection before returning self (Bug#8842).
7646 (writeSelectionToPasteboard): Put local selection into paste board
7647 if we have a local selection (Bug#8842).
7648 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7650 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7651 (ns_get_local_selection): Declare.
7653 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7655 * keymap.c (describe_map_tree): Don't insert a double newline at
7656 the end of the buffer (bug#1169) and return whether we inserted
7659 * callint.c (Fcall_interactively): Change "reading args" to
7660 "providing args" to try to clarify what it does (bug#1010).
7662 2011-07-07 Kenichi Handa <handa@m17n.org>
7664 * composite.c (composition_compute_stop_pos): Ignore a static
7665 composition starting before CHARPOS (Bug#8915).
7667 * xdisp.c (handle_composition_prop): Likewise.
7669 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7671 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7674 2011-07-07 Kenichi Handa <handa@m17n.org>
7676 * character.h (unicode_category_t): New enum type.
7678 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7679 (Qchar_code_property_table): New variable.
7680 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7681 (UNIPROP_COMPRESSED_FORM_P): New macros.
7682 (char_table_ascii): Uncompress the compressed values.
7683 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7684 Uncompress the compressed values.
7685 (sub_char_table_ref_and_range): Likewise.
7686 (char_table_ref_and_range): Uncompress the compressed values.
7687 (sub_char_table_set): New arg is_uniprop. Callers changed.
7688 Uncompress the compressed values.
7689 (sub_char_table_set_range): Args changed. Callers changed.
7690 (char_table_set_range): Adjuted for the above change.
7691 (map_sub_char_table): Delete args default_val and parent. Add arg
7692 top. Give decoded values to a Lisp function.
7693 (map_char_table): Adjust for the above change. Give decoded
7694 values to a Lisp function. Gcpro more variables.
7695 (uniprop_table_uncompress)
7696 (uniprop_decode_value_run_length): New functions.
7697 (uniprop_decoder, uniprop_decoder_count): New variables.
7698 (uniprop_get_decoder, uniprop_encode_value_character)
7699 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7701 (uniprop_encoder, uniprop_encoder_count): New variables.
7702 (uniprop_get_encoder, uniprop_table)
7703 (Funicode_property_table_internal, Fget_unicode_property_internal)
7704 (Fput_unicode_property_internal): New functions.
7705 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7706 Sunicode_property_table_internal, Sget_unicode_property_internal,
7707 and Sput_unicode_property_internal. Defvar_lisp
7708 char-code-property-alist.
7710 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7711 Vunicode_category_table.
7713 * font.c (font_range): Adjust for the change of
7714 Vunicode_category_table.
7716 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7718 * m/iris4d.h: Remove file, move contents ...
7719 * s/irix6-5.h: ... here.
7721 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7723 Remove unportable assumption about struct layout (Bug#8884).
7724 * alloc.c (mark_buffer):
7725 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7726 (clone_per_buffer_values): Don't assume that
7727 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7728 This isn't true in general, and it's particularly not true
7729 if Emacs is configured with --with-wide-int.
7730 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7731 New macros, used in the buffer.c change.
7733 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7735 * xsettings.c: Use both GConf and GSettings if both are available.
7736 (store_config_changed_event): Add comment.
7737 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7738 (store_tool_bar_style_changed): New functions.
7739 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7740 (struct xsettings): Move font inside HAVE_XFT.
7741 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7742 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7743 Move inside HAVE_XFT.
7744 (something_changed_gsettingsCB): Rename from something_changedCB.
7745 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7747 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7748 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7749 (something_changed_gconfCB): Rename from something_changedCB.
7750 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7751 (parse_settings): Move check for font inside HAVE_XFT.
7752 (read_settings, apply_xft_settings): Add comment.
7753 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7754 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7755 call store_font_name_changed.
7756 (xft_settings_event): Add comment.
7757 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7758 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7759 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7760 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7761 (xsettings_initialize): Call init_gsettings last.
7762 (xsettings_get_system_font, xsettings_get_system_normal_font):
7765 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7767 Random fixes. E.g., (random) never returned negative values.
7768 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7769 subseconds part to the entropy, as that's a bit more random.
7770 Prefer signed to unsigned, since the signedness doesn't matter and
7771 in general we prefer signed. When given a limit, use a
7772 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7773 latter isn't right if USE_2_TAGS_FOR_INTS.
7774 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7775 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7777 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7779 * textprop.c (text_property_stickiness):
7780 Obey Vtext_property_default_nonsticky.
7781 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7782 * w32fns.c (syms_of_w32fns):
7783 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7785 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7787 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7788 This is more efficient than Ffile_directory_p and avoids a minor race.
7790 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7792 * buffer.c (Foverlay_put): Say what the return value is
7795 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7796 is a directory before asking whether to use the file name
7798 (barf_or_query_if_file_exists): Make the "File is a directory"
7799 error be more correct.
7801 * fns.c (Frequire): Remove the mention of the .gz files, since
7802 that's installation-specific, but keep the mention of
7803 `get-load-suffixes'.
7805 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7807 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7808 Report string overflow if the output is too long.
7810 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7812 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7813 (syms_of_gnutls): Remove duplicate DEFSYM for
7814 Qgnutls_bootprop_verify_hostname_error, an error for
7815 Qgnutls_bootprop_verify_error (which is no longer used).
7817 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7818 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7819 Also (re)move comments that are misplaced or no longer relevant.
7821 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7823 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7825 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7827 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7828 and background color parameters if they have been changed.
7830 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7832 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7834 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7836 * xsettings.c (SYSTEM_FONT): Define only when used.
7837 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7839 * keymap.c (access_keymap_1): Now static.
7841 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7843 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7844 leave any prefix arg for the up event (Bug#1586).
7846 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7848 * lread.c (syms_of_lread): Mention single symbols defined by
7849 `defvar' or `defconst' (bug#7154).
7851 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7852 (Frequire): Mention get-load-suffixes.
7854 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7856 * window.h (window): Remove clone_number slot.
7857 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7859 (make_parent_window, make_window, saved_window)
7860 (Fset_window_configuration, save_window_save): Don't deal with
7862 * buffer.c (Qclone_number): Remove declaration.
7863 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7865 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7867 Add multiple inheritance to keymaps.
7868 * keymap.c (Fmake_composed_keymap): New function.
7869 (Fset_keymap_parent): Simplify.
7870 (fix_submap_inheritance): Remove.
7871 (access_keymap_1): New function extracted from access_keymap to handle
7872 embedded parents and handle lists of maps.
7873 (access_keymap): Use it.
7874 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7875 (Fcopy_keymap): Handle embedded parents.
7876 (Fcommand_remapping, define_as_prefix): Simplify.
7877 (Fkey_binding): Simplify.
7878 (syms_of_keymap): Move minibuffer-local-completion-map,
7879 minibuffer-local-filename-completion-map,
7880 minibuffer-local-must-match-map, and
7881 minibuffer-local-filename-must-match-map to Elisp.
7882 (syms_of_keymap): Defsubr make-composed-keymap.
7883 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7884 (parse_menu_item): Trivial simplification.
7886 2011-07-01 Glenn Morris <rgm@gnu.org>
7888 * Makefile.in (SETTINGS_LIBS): Fix typo.
7890 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7892 * coding.c (Fencode_coding_string): Record the last coding system
7893 used, as the function doc string says (bug#8738).
7895 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7897 * xsettings.c (store_monospaced_changed): Take new font as arg and
7898 check for change against current_mono_font.
7899 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7900 (emacs_settings_constructor, emacs_settings_get_property)
7901 (emacs_settings_set_property, emacs_settings_class_init)
7902 (emacs_settings_init, gsettings_obj): Remove.
7903 (something_changedCB): New function for HAVE_GSETTINGS.
7904 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7905 with value as argument.
7906 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7907 g_settings_new (Bug#8967). Do not create gsettings_obj.
7908 Remove calls to g_settings_bind. Connect something_changedCB to
7911 * xgselect.c: Add defined (HAVE_GSETTINGS).
7912 (xgselect_initialize): Ditto.
7914 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7915 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7918 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7920 * eval.c (struct backtrace): Simplify and port the data structure.
7921 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7922 signed bit field, as this assumption is not portable and it makes
7923 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7924 "char debug_on_exit : 1" as this is not portable either; instead,
7925 use the portable "unsigned int debug_on_exit : 1". Remove unused
7926 member evalargs. Remove obsolete comments about cc bombing out.
7928 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7930 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7931 Let HAVE_GSETTINGS override HAVE_GCONF.
7932 (store_monospaced_changed): New function.
7933 (EMACS_SETTINGS): A new type derived from GObject to handle
7934 GSettings notifications.
7935 (emacs_settings_constructor, emacs_settings_get_property)
7936 (emacs_settings_set_property, emacs_settings_class_init):
7938 (gsettings_client, gsettings_obj): New variables.
7939 (GSETTINGS_SCHEMA): New define.
7940 (something_changedCB): Call store_monospaced_changed.
7941 (init_gsettings): New function.
7942 (xsettings_initialize): Call init_gsettings.
7943 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7946 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7949 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7951 * window.c (resize_root_window, grow_mini_window)
7952 (shrink_mini_window): Rename Qresize_root_window to
7953 Qwindow_resize_root_window and Qresize_root_window_vertically to
7954 Qwindow_resize_root_window_vertically.
7956 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7958 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7960 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7962 * makefile.w32-in: Redesign dependencies so they reflect more
7963 clearly which files are directly included by each source file,
7964 and not through other includes.
7966 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7968 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7969 (sort_overlays, overlay_strings): When an overlay's clone number
7970 matches the window's clone number process the overlay even if
7971 the overlay's window property doesn't match the current window.
7973 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7974 (Fwindow_hchild): Rename to Fwindow_left_child.
7975 (Fwindow_next): Rename to Fwindow_next_sibling.
7976 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7977 (resize_window_check): Rename to window_resize_check.
7978 (resize_window_apply): Rename to window_resize_apply.
7979 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7980 (Fdelete_other_windows_internal, resize_frame_windows)
7981 (Fsplit_window_internal, Fdelete_window_internal)
7982 (grow_mini_window, shrink_mini_window)
7983 (Fresize_mini_window_internal): Fix callers accordingly.
7985 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7987 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7988 (emacs_fixed_set_min_size): Remove.
7989 (emacs_fixed_new): Take frame as argument.
7991 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7992 (_EmacsFixedPrivate): Remove minwidth/height.
7993 Add struct frame *f.
7994 (emacs_fixed_init): Initialize priv->f.
7995 (get_parent_class, emacs_fixed_set_min_size): Remove.
7996 (emacs_fixed_new): Set priv->f to argument.
7997 (emacs_fixed_get_preferred_width)
7998 (emacs_fixed_get_preferred_height): Use min_width/height from
7999 frames size_hint to set minimum and natural (Bug#8919).
8000 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8001 and use min_width/height from frames size_hint to set
8002 min_width/height (Bug#8919).
8004 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8005 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8008 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8010 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8011 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8014 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8016 * process.c (wait_reading_process_output): Bypass select if
8017 waiting for a cell while ignoring keyboard input, and input is
8018 pending. Suggested by Jan Djärv (Bug#8869).
8020 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8022 Use gnulib's dup2 module instead of rolling our own.
8023 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8025 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8027 * dispnew.c (scrolling_window): Before scrolling, turn off a
8028 mouse-highlight in the window being scrolled.
8030 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8032 Move DEFSYM to lisp.h and use everywhere.
8034 * character.h (DEFSYM): Move declaration...
8035 * lisp.h (DEFSYM): ...here.
8041 * w32select.c: Don't include character.h.
8043 * alloc.c (syms_of_alloc):
8044 * buffer.c (syms_of_buffer):
8045 * bytecode.c (syms_of_bytecode):
8046 * callint.c (syms_of_callint):
8047 * casefiddle.c (syms_of_casefiddle):
8048 * casetab.c (init_casetab_once):
8049 * category.c (init_category_once, syms_of_category):
8050 * ccl.c (syms_of_ccl):
8051 * cmds.c (syms_of_cmds):
8052 * composite.c (syms_of_composite):
8053 * dbusbind.c (syms_of_dbusbind):
8054 * dired.c (syms_of_dired):
8055 * dispnew.c (syms_of_display):
8056 * doc.c (syms_of_doc):
8057 * editfns.c (syms_of_editfns):
8058 * emacs.c (syms_of_emacs):
8059 * eval.c (syms_of_eval):
8060 * fileio.c (syms_of_fileio):
8061 * fns.c (syms_of_fns):
8062 * frame.c (syms_of_frame):
8063 * fringe.c (syms_of_fringe):
8064 * insdel.c (syms_of_insdel):
8065 * keymap.c (syms_of_keymap):
8066 * lread.c (init_obarray, syms_of_lread):
8067 * macros.c (syms_of_macros):
8068 * msdos.c (syms_of_msdos):
8069 * print.c (syms_of_print):
8070 * process.c (syms_of_process):
8071 * search.c (syms_of_search):
8072 * sound.c (syms_of_sound):
8073 * syntax.c (init_syntax_once, syms_of_syntax):
8074 * terminal.c (syms_of_terminal):
8075 * textprop.c (syms_of_textprop):
8076 * undo.c (syms_of_undo):
8077 * w32.c (globals_of_w32):
8078 * window.c (syms_of_window):
8079 * xdisp.c (syms_of_xdisp):
8080 * xfaces.c (syms_of_xfaces):
8081 * xfns.c (syms_of_xfns):
8082 * xmenu.c (syms_of_xmenu):
8083 * xsettings.c (syms_of_xsettings):
8084 * xterm.c (syms_of_xterm): Use DEFSYM.
8086 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8088 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8090 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8092 Integer and buffer overflow fixes (Bug#8873).
8094 * print.c (printchar, strout): Check for string overflow.
8095 (PRINTPREPARE, printchar, strout):
8096 Don't set size unless allocation succeeds.
8098 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8099 for sizes. Check for string overflow more accurately.
8100 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8102 * macros.c: Integer and buffer overflow fixes.
8103 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8104 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8105 Use ptrdiff_t, not int, for sizes.
8106 Don't increment bufsize until after realloc succeeds.
8107 Check for size-calculation overflow.
8108 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8110 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8112 * lread.c: Integer overflow fixes.
8113 (read_integer): Radix is now EMACS_INT, not int,
8114 to improve quality of diagnostics for out-of-range radices.
8115 Calculate buffer size correctly for out-of-range radices.
8116 (read1): Check for integer overflow in radices, and in
8117 read-circle numbers.
8118 (read_escape): Avoid int overflow.
8119 (Fload, openp, read_buffer_size, read1)
8120 (substitute_object_recurse, read_vector, read_list, map_obarray):
8121 Use ptrdiff_t, not int, for sizes.
8122 (read1): Use EMACS_INT, not int, for sizes.
8123 Check for size overflow.
8125 * image.c (cache_image): Check for size arithmetic overflow.
8127 * lread.c: Integer overflow issues.
8128 (saved_doc_string_size, saved_doc_string_length)
8129 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8130 Now ptrdiff_t, not int.
8131 (read1): Don't assume doc string length fits in int. Check for
8132 out-of-range doc string lengths.
8133 (read_list): Don't assume file position fits in int.
8134 (read_escape): Check for hex character overflow.
8136 2011-06-22 Leo Liu <sdl.web@gmail.com>
8138 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8139 Move to minibuffer.el.
8141 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8143 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8144 The following patches are for when GLYPH_DEBUG && !XASSERT.
8145 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8146 * dispnew.c (flush_stdout):
8147 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8148 Mark as externally visible.
8149 * dispnew.c (check_window_matrix_pointers): Now static.
8150 * dispnew.c (window_to_frame_vpos):
8151 * xfns.c (unwind_create_frame):
8152 * xterm.c (x_check_font): Remove unused local.
8153 * scroll.c (CHECK_BOUNDS):
8154 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8155 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8156 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8157 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8158 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8160 (debug_method_add): Use va_list and vsprintf rather than relying
8161 on undefined behavior with wrong number of arguments.
8162 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8163 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8164 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8165 since we're not interested in debugging glyphs with old libraries.
8166 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8167 GCC 4.6.0's static checking.
8169 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8171 Integer overflow and signedness fixes (Bug#8873).
8172 A few related buffer overrun fixes, too.
8174 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8176 * dispextern.h (struct face.stipple):
8177 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8178 (x_bitmap_mask, x_allocate_bitmap_record)
8179 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8180 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8181 (x_create_bitmap_from_xpm_data):
8182 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8183 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8185 * xfaces.c (load_pixmap):
8186 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8187 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8188 (.bitmaps_last, struct x_output.icon_bitmap):
8189 Use ptrdiff_t, not int, for bitmap indexes.
8190 (x_allocate_bitmap_record): Check for size overflow.
8191 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8193 Use ptrdiff_t, not int, for overlay counts.
8194 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8195 * editfns.c (overlays_around, get_pos_property):
8196 * textprop.c (get_char_property_and_overlay):
8197 * xdisp.c (next_overlay_change, note_mouse_highlight):
8198 * xfaces.c (face_at_buffer_position):
8199 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8200 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8201 (Fnext_overlay_change, Fprevious_overlay_change)
8202 (mouse_face_overlay_overlaps, Foverlays_in):
8203 Use ptrdiff_t, not int, for sizes.
8204 (overlays_at, overlays_in): Check for size-calculation overflow.
8206 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8208 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8209 (x_session_initialize): Do not assume string length fits in int.
8211 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8212 This is unlikely, but can occur if DPI is outlandish.
8214 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8215 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8217 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8218 * xrdb.c (magic_file_p, search_magic_path):
8219 Omit last arg SUFFIX; it was always 0. All callers changed.
8220 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8222 * xfont.c (xfont_match): Avoid need for strlen.
8224 * xfns.c: Don't assume strlen fits in int.
8225 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8227 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8228 not unsigned long, as we prefer signed integers. All callers changed.
8229 Detect integer overflow in repeat count.
8230 (message_dolog): Don't assume print length fits in 39 bytes.
8231 (display_mode_element): Don't assume strlen fits in int.
8233 * termcap.c: Don't assume sizes fit in int and never overflow.
8234 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8235 (gobble_line): Check for size-calculation overflow.
8237 * minibuf.c (Fread_buffer):
8238 * lread.c (intern, intern_c_string):
8239 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8240 Don't assume string length fits in int.
8242 * keyboard.c (parse_tool_bar_item):
8243 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8245 * font.c: Don't assume string length fits in int.
8246 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8247 Use ptrdiff_t, not int.
8248 (font_intern_prop): Don't assume string length fits in int.
8249 Don't assume integer property fits in fixnum.
8250 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8252 * filelock.c: Fix some buffer overrun and integer overflow issues.
8253 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8254 Reformulate so as not to need the command string.
8255 Invoke gzip -cd rather than gunzip, as it's more portable.
8256 (lock_info_type, lock_file_1, lock_file):
8257 Don't assume pid_t and time_t fit in unsigned long.
8258 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8259 (current_lock_owner): Prefer signed type for sizes.
8260 Use memcpy, not strncpy, where memcpy is what is really wanted.
8261 Don't assume (via atoi) that time_t and pid_t fit in int.
8262 Check for time_t and/or pid_t out of range, e.g., via a network share.
8263 Don't alloca where an auto var works fine.
8265 * fileio.c: Fix some integer overflow issues.
8266 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8267 Don't assume string length fits in int.
8268 (directory_file_name): Don't assume string length fits in long.
8269 (make_temp_name): Don't assume pid fits in int, or that its print
8270 length is less than 20.
8272 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8274 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8276 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8278 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8279 We prefer signed integers, even for size calculations.
8281 * emacs.c: Don't assume string length fits in 'int'.
8282 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8283 (main): Don't invoke strlen when not needed.
8285 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8286 (XD_DEBUG_MESSAGE): Don't waste a byte.
8288 * callproc.c (getenv_internal_1, getenv_internal)
8290 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8292 * lread.c (invalid_syntax): Omit length argument.
8293 All uses changed. This doesn't fix a bug, but it simplifies the
8294 code away from its former Hollerith-constant appearance, and it's
8295 one less 'int' to worry about when looking at integer-overflow issues.
8296 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8298 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8299 This didn't break anything, but it didn't help either.
8300 It's confusing to put a bogus integer in a place where the actual
8301 value does not matter.
8302 (LIST_END_P): Remove unused macro and its bogus comment.
8303 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8305 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8306 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8308 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8309 We prefer signed types, and the value cannot exceed the EMACS_INT
8310 range anyway (because otherwise the length would not be representable).
8311 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8312 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8313 This avoids a GCC warning when WIDE_EMACS_INT.
8315 * indent.c (sane_tab_width): New function.
8316 (current_column, scan_for_column, Findent_to, position_indentation)
8317 (compute_motion): Use it. This is just for clarity.
8318 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8320 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8322 * lisp.h (lint_assume): New macro.
8323 * composite.c (composition_gstring_put_cache):
8324 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8326 * editfns.c, insdel.c:
8327 Omit unnecessary forward decls, to simplify future changes.
8329 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8331 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8333 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8334 Use much-faster test for byte-length change.
8335 Don't assume string byte-length fits in 'int'.
8336 Check that character arg fits in 'int'.
8337 (mapcar1): Declare byte as byte, for clarity.
8339 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8341 * fns.c (concat): Catch string overflow earlier.
8342 Do not rely on integer wraparound.
8344 * dispextern.h (struct it.overlay_strings_charpos)
8345 (struct it.selective): Now EMACS_INT, not int.
8346 * xdisp.c (forward_to_next_line_start)
8347 (back_to_previous_visible_line_start)
8348 (reseat_at_next_visible_line_start, next_element_from_buffer):
8349 Don't arbitrarily truncate the value of 'selective' to int.
8351 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8353 * composite.c: Don't truncate sizes to 'int'.
8354 (composition_gstring_p, composition_reseat_it)
8355 (composition_adjust_point): Use EMACS_INT, not int.
8356 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8357 not EMACS_UINT, for indexes.
8359 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8361 * buffer.c: Include <verify.h>.
8362 (struct sortvec.priority, struct sortstr.priority):
8363 Now EMACS_INT, not int.
8364 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8365 (struct sortstr.size, record_overlay_string)
8366 (struct sortstrlist.size, struct sortlist.used):
8367 Don't truncate size to int.
8368 (record_overlay_string): Check for size-calculation overflow.
8369 (init_buffer_once): Check at compile-time, not run-time.
8371 2011-06-22 Jim Meyering <meyering@redhat.com>
8373 Don't leak an XBM-image-sized buffer
8374 * image.c (xbm_load): Free the image buffer after using it.
8376 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8379 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8380 that Sun C diagnosed.
8381 * fns.c (secure_hash): Fix pointer signedness issue.
8382 * intervals.c (static_offset_intervals): New function.
8383 (offset_intervals): Use it.
8385 2011-06-21 Leo Liu <sdl.web@gmail.com>
8388 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8391 * fns.c (secure_hash): Rename from crypto_hash_function and change
8392 the first arg to accept symbols.
8393 (Fsecure_hash): New primitive.
8394 (syms_of_fns): New symbols.
8396 2011-06-20 Deniz Dogan <deniz@dogan.se>
8398 * process.c (Fset_process_buffer): Clarify return value in
8401 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8403 * dispnew.c (add_window_display_history): Use BVAR.
8405 * xdisp.c (debug_method_add): Use BVAR.
8406 (check_window_end, dump_glyph_matrix, dump_glyph)
8407 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8409 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8412 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8413 check till after the cache is created in init_frame_faces.
8415 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8417 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8419 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8421 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8422 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8423 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8425 Improve buffer-overflow checking (Bug#8873).
8426 * fileio.c (Finsert_file_contents):
8427 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8428 Remove the old (too-loose) buffer overflow checks.
8429 They weren't needed, since make_gap checks for buffer overflow.
8430 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8431 The old code merely checked for Emacs fixnum overflow, and relied
8432 on undefined (wraparound) behavior. The new code avoids undefined
8433 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8435 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8436 Tune. Don't use wider integers than needed. Don't use alloca.
8437 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8439 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8441 * insdel.c, lisp.h (buffer_overflow): New function.
8442 (insert_from_buffer_1, replace_range, replace_range_2):
8443 * insdel.c (make_gap_larger):
8444 * editfns.c (Finsert_char):
8445 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8447 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8449 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8451 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8453 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8454 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8456 * fileio.c: Don't assume EMACS_INT fits in off_t.
8457 (emacs_lseek): New static function.
8458 (Finsert_file_contents, Fwrite_region): Use it.
8459 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8461 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8463 * fns.c: Don't overflow int when computing a list length.
8464 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8465 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8466 truncation on 64-bit hosts. Check for QUIT every
8467 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8468 faster and is responsive enough.
8469 (Flength): Report an error instead of overflowing an integer.
8470 (Fsafe_length): Return a float if the value is not representable
8471 as a fixnum. This shouldn't happen except in contrived situations.
8472 (Fnthcdr, Fsort): Don't assume list length fits in int.
8473 (Fcopy_sequence): Don't assume vector length fits in int.
8475 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8476 (header_size, word_size): New constants.
8477 (allocate_vectorlike): Don't check size overflow here.
8478 (allocate_vector): Check it here instead, since this is the only
8479 caller of allocate_vectorlike that could cause overflow.
8480 Check that the new vector's length is representable as a fixnum.
8482 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8483 The previous code was bogus. For example, next_almost_prime (32)
8484 returned 39, which is undesirable as it is a multiple of 3; and
8485 next_almost_prime (24) returned 25, which is a multiple of 5 so
8486 why was the code bothering to check for multiples of 7?
8488 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8490 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8492 Variadic C functions now count arguments with ptrdiff_t.
8493 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8494 Back then I didn't know that the Emacs coding style prefers signed int.
8495 Also, in the meantime I found a few more instances where arguments
8496 were being counted with int, which may truncate counts on 64-bit
8497 machines, or EMACS_INT, which may be unnecessarily wide.
8498 * lisp.h (struct Lisp_Subr.function.aMANY)
8499 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8500 Arg counts are now ptrdiff_t, not size_t.
8501 All variadic functions and their callers changed accordingly.
8502 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8503 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8504 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8505 * callint.c (Fcall_interactively): Check arg count for overflow,
8506 to avoid potential buffer overrun. Use signed char, not 'int',
8507 for 'varies' array, so that we needn't bother to check its size
8508 calculation for overflow.
8509 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8510 * eval.c (apply_lambda):
8511 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8512 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8513 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8515 * callint.c (Fcall_interactively): Don't use index var as event count.
8517 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8518 * mem-limits.h (SIZE): Remove; no longer used.
8520 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8522 Remove unnecessary casts.
8523 * xterm.c (x_term_init):
8524 * xfns.c (x_set_border_pixel):
8525 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8526 These aren't needed now that we assume ANSI C.
8528 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8529 It's more likely to cause problems (due to unsigned overflow)
8532 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8534 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8536 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8538 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8540 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8542 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8544 GLYPH_CODE_FACE returns EMACS_INT, not int.
8545 * dispextern.h (merge_faces):
8546 * xfaces.c (merge_faces):
8547 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8548 Don't assume EMACS_INT fits in int.
8550 * character.h (CHAR_VALID_P): Remove unused parameter.
8551 * fontset.c, lisp.h, xdisp.c: All uses changed.
8553 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8555 * fns.c (concat): Minor tuning based on overflow analysis.
8556 This doesn't fix any bugs. Use int to hold character, instead
8557 of constantly refetching from Emacs object. Use XFASTINT, not
8558 XINT, for value known to be a character. Don't bother comparing
8559 a single byte to 0400, as it's always less.
8561 * floatfns.c (Fexpt):
8562 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8564 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8567 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8569 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8570 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8571 incorrectly succeed when S was a string, because 4294967386 was
8572 truncated before it was used.
8574 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8575 Otherwise, an out-of-range integer could cause undefined behavior
8578 * composite.c: Use int, not EMACS_INT, for characters.
8579 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8580 EMACS_INT, for values that are known to be in character range.
8581 This doesn't fix any bugs but is the usual style inside Emacs and
8582 may generate better code on 32-bit machines.
8584 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8585 This is for reasons similar to the recent CHAR_STRING fix.
8586 * charset.c (Fencode_char): Check that character arg is actually
8587 a character. Pass an int to ENCODE_CHAR.
8588 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8589 wider than 'int', as a compile-time check to prevent future regressions
8592 * character.c (char_string): Remove unnecessary casts.
8594 Make sure a 64-bit char is never passed to CHAR_STRING.
8595 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8596 by silently ignoring the top 32 bits, allowing some values
8597 that were far too large to be valid characters.
8598 * character.h: Include <verify.h>.
8599 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8600 arguments are no wider than unsigned, as a compile-time check
8601 to prevent future regressions in this area.
8603 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8604 (Fsubst_char_in_region):
8606 * xdisp.c (decode_mode_spec_coding):
8607 Adjust to CHAR_STRING's new requirement.
8608 * editfns.c (Finsert_char, Fsubst_char_in_region):
8609 * fns.c (concat): Check that character args are actually
8610 characters. Without this test, these functions did the wrong
8611 thing with wildly out-of-range values on 64-bit hosts.
8613 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8614 These casts should not be needed on 32-bit hosts, either.
8615 * keyboard.c (read_char):
8616 * lread.c (Fload): Remove casts to unsigned.
8618 * lisp.h (UNSIGNED_CMP): New macro.
8619 This fixes comparison bugs on 64-bit hosts.
8620 (ASCII_CHAR_P): Use it.
8621 * casefiddle.c (casify_object):
8622 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8623 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8624 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8625 * dispextern.h (FACE_FROM_ID):
8626 * keyboard.c (read_char): Use UNSIGNED_CMP.
8628 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8629 not to EMACS_INT, to avoid GCC warning.
8631 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8633 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8634 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8635 isn't needed on 32-bit machines.
8637 * buffer.c (Fgenerate_new_buffer_name):
8638 Use EMACS_INT for count, not int.
8639 (advance_to_char_boundary): Return EMACS_INT, not int.
8641 * data.c (Qcompiled_function): Now static.
8643 * window.c (window_body_lines): Now static.
8645 * image.c (gif_load): Rename local to avoid shadowing.
8647 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8648 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8649 * alloc.c (make_save_value): Integer argument is now of type
8651 (mark_object): Use ptrdiff_t, not int.
8652 * lisp.h (pD): New macro.
8653 * print.c (print_object): Use it.
8655 * alloc.c: Use EMACS_INT, not int, to count objects.
8656 (total_conses, total_markers, total_symbols, total_vector_size)
8657 (total_free_conses, total_free_markers, total_free_symbols)
8658 (total_free_floats, total_floats, total_free_intervals)
8659 (total_intervals, total_strings, total_free_strings):
8660 Now EMACS_INT, not int. All uses changed.
8661 (Fgarbage_collect): Compute overall total using a double, so that
8662 integer overflow is less likely to be a problem. Check for overflow
8663 when converting back to an integer.
8664 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8665 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8666 These were 'int' variables that could overflow on 64-bit hosts;
8667 they were never used, so remove them instead of repairing them.
8668 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8669 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8670 Previously, this ceilinged at INT_MAX, but that doesn't work on
8672 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8674 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8675 (allocate_vectorlike): Check for ptrdiff_t overflow.
8676 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8677 when a (possibly-narrower) signed value would do just as well.
8678 We prefer using signed arithmetic, to avoid comparison confusion.
8680 * alloc.c: Catch some string size overflows that we were missing.
8681 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8682 for convenience in STRING_BYTES_MAX.
8683 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8684 The definition here is exact; the one in lisp.h was approximate.
8685 (allocate_string_data): Check for string overflow. This catches
8686 some instances we weren't catching before. Also, it catches
8687 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8688 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8689 and ptrdiff_t and EMACS_INT are both 64 bits.
8691 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8692 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8693 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8695 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8697 * alloc.c (Fmake_string): Check for out-of-range init.
8699 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8701 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8703 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8705 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8706 xg_get_default_scrollbar_width.
8708 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8709 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8710 (style_changed_cb): Call update_theme_scrollbar_width and call
8711 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8712 all frames (Bug#8505).
8713 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8714 Call gtk_window_set_resizable if HAVE_GTK3.
8715 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8716 and height if HAVE_GTK3 (Bug#8505).
8717 (scroll_bar_width_for_theme): New variable.
8718 (update_theme_scrollbar_width): New function.
8719 (xg_get_default_scrollbar_width): Move code to
8720 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8721 (xg_initialize): Call update_theme_scrollbar_width.
8723 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8725 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8727 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8729 * frame.c (make_frame): Call other_buffer_safely instead of
8732 * window.c (temp_output_buffer_show): Call display_buffer with
8733 second argument Vtemp_buffer_show_specifiers and reset latter
8734 immediately after the call.
8735 (Vtemp_buffer_show_specifiers): New variable.
8736 (auto_window_vscroll_p, next_screen_context_lines)
8737 (Vscroll_preserve_screen_position): Remove leading asterisks from
8740 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8742 Fix minor problems found by GCC 4.6.0 static checking.
8743 * buffer.c (Qclone_number): Remove for now, as it's unused.
8744 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8745 (record_buffer): Remove unused local.
8746 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8747 (set_frame_buffer_list): Remove; unused.
8748 * frame.h (other_visible_frames): Remove decl.
8749 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8750 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8751 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8753 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8754 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8755 Define only if HAVE_GPM.
8756 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8757 (update_hints_inhibit): Remove; never set. All uses removed.
8758 * widgetprv.h (emacsFrameClassRec): Remove decl.
8759 * window.c (delete_deletable_window): Now returns void, since it
8760 wasn't returning anything.
8761 (compare_window_configurations): Remove unused locals.
8762 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8763 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8764 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8765 the same widths as pointers. This follows up on the 2011-05-06 patch.
8766 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8767 * xterm.h: Likewise.
8768 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8770 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8772 * makefile.w32-in: Update dependencies.
8773 (LISP_H): Add lib/intprops.h.
8775 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8777 * image.c (gif_load): Add animation frame delay to the metadata.
8778 (syms_of_image): Use DEFSYM. New symbol `delay'.
8780 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8782 * window.c (delete_deletable_window): Re-add.
8783 (Fset_window_configuration): Rewrite to handle dead buffers and
8784 consequently deletable windows.
8785 (window_tree, Fwindow_tree): Remove. Supply functionality in
8787 (compare_window_configurations): Simplify code.
8789 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8791 * image.c (imagemagick_load_image): Fix type mismatch.
8792 (Fimagemagick_types): Likewise.
8794 * window.h (replace_buffer_in_windows): Declare.
8796 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8798 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8799 Qclone_number. Remove external declaration of Qdelete_window.
8800 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8802 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8803 Run Qbuffer_list_update_hook if allowed.
8804 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8805 buffer list implementation.
8806 (other_buffer_safely): New function.
8807 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8808 calls to replace_buffer_in_windows and
8809 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8811 (record_buffer): Inhibit quitting and rewrite using quittable
8812 functions. Run Qbuffer_list_update_hook if allowed.
8813 (Frecord_buffer, Funrecord_buffer): New functions.
8814 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8815 Move switch-to-buffer to window.el.
8816 (bury-buffer): Move to window.el.
8817 (Vbuffer_list_update_hook): New variable.
8819 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8822 * window.h (resize_frame_windows): Move up in code.
8823 (Fwindow_frame): Remove EXFUN.
8824 (replace_buffer_in_all_windows): Remove prototype.
8825 (replace_buffer_in_windows_safely): Add prototype.
8827 * window.c: Declare Qdelete_window static again. Move down
8828 declaration of select_count.
8829 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8830 (Fother_window): Move to window.el.
8831 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8832 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8833 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8835 (replace_buffer_in_windows): Implement by calling
8836 Qreplace_buffer_in_windows.
8837 (replace_buffer_in_all_windows): Remove with some functionality
8838 moved into replace_buffer_in_windows_safely.
8839 (replace_buffer_in_windows_safely): New function.
8840 (select_window_norecord, select_frame_norecord): Move in front
8841 of run_window_configuration_change_hook. Remove now obsolete
8843 (Fset_window_buffer): Rewrite doc-string.
8844 Call Qrecord_window_buffer.
8845 (keys_of_window): Move binding for other-window to window.el.
8847 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8849 * dispextern.h (struct image): Replace data member, whose int_val
8850 and ptr_val fields were not used by anything, with a single
8853 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8854 (gif_clear_image, gif_load, imagemagick_load_image)
8855 (gs_clear_image, gs_load): Callers changed.
8857 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8859 * buffer.h: Include <time.h>, for time_t.
8860 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8862 Fix minor problems found by static checking.
8864 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8866 Make identifiers static if they are not used in other modules.
8867 * data.c (Qcompiled_function, Qframe, Qvector):
8868 * image.c (QimageMagick, Qsvg):
8869 * minibuf.c (Qmetadata):
8870 * window.c (resize_window_check, resize_root_window): Now static.
8871 * window.h (resize_window_check, resize_root_window): Remove decls.
8873 * window.c (window_deletion_count, delete_deletable_window):
8875 (window_body_lines): Now static.
8876 (Fdelete_other_windows_internal): Mark vars as initialized.
8877 Make sure 'resize_failed' is initialized.
8878 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8879 (resize_window_apply): Remove unused local.
8880 * window.h (delete_deletable_window): Remove decl.
8882 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8883 (imagemagick_load_image): Fix pointer signedness problem by changing
8884 last arg from unsigned char * to char *. All uses changed.
8885 Also, fix a local for similar reasons.
8886 Remove unused locals. Remove locals to avoid shadowing.
8887 (fn_rsvg_handle_free): Remove; unused.
8888 (svg_load, svg_load_image): Fix pointer signedness problem.
8889 (imagemagick_load_image): Don't use garbage pointer image_wand.
8891 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8893 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8895 * image.c (gif_load): Fix omitted cast error introduced by
8898 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8900 * window.h (resize_proportionally, orig_total_lines)
8901 (orig_top_line): Remove from window structure.
8902 (set_window_height, set_window_width, change_window_heights)
8903 (Fdelete_window): Remove prototypes.
8904 (resize_frame_windows): Remove duplicate declaration.
8906 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8908 * window.h (resize_frame_windows, resize_window_check)
8909 (delete_deletable_window, resize_root_window)
8910 (resize_frame_windows): Declare prototypes.
8912 * window.c (resize_window_apply): Make definition be "static" to
8913 match the prototype.
8915 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8917 * window.c: Remove declarations of Qwindow_size_fixed,
8918 window_min_size_1, window_min_size_2, window_min_size,
8919 size_window, window_fixed_size_p, enlarge_window, delete_window.
8920 Remove static from declaration of Qdelete_window, it's
8921 temporarily needed by Fbury_buffer.
8922 (replace_window): Don't assign orig_top_line and
8924 (Fdelete_window, delete_window): Remove. Window deletion is
8925 handled by window.el.
8926 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8927 Replace Fdelete_window calls with calls to Qdelete_window.
8928 (Fdelete_other_windows): Remove. Deleting other windows is
8929 handled by window.el.
8930 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8931 handled in window.el.
8932 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8933 Window minimum sizes are handled in window.el.
8934 (shrink_windows, size_window, set_window_height)
8935 (set_window_width, change_window_heights, window_height)
8936 (window_width, CURBEG, CURSIZE, enlarge_window)
8937 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8938 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8939 handled in window.el.
8940 (make_dummy_parent): Rename to make_parent_window and give it a
8941 second argument horflag.
8942 (make_window): Don't set resize_proportionally any more.
8943 (Fsplit_window): Remove. Windows are split in window.el.
8944 (save_restore_action, save_restore_orig_size)
8945 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8946 Resize mini windows in window.el.
8947 (grow_mini_window, shrink_mini_window): Implement by calling
8948 Qresize_root_window_vertically, resize_window_check and
8949 resize_window_apply.
8950 (saved_window, Fset_window_configuration, save_window_save):
8951 Do not handle orig_top_line, orig_total_lines, and
8952 resize_proportionally.
8953 (window_min_height, window_min_width): Move to window.el.
8954 (keys_of_window): Move bindings for delete-other-windows,
8955 split-window, delete-window and enlarge-window to window.el.
8957 * buffer.c: Temporarily extern Qdelete_window.
8958 (Fbury_buffer): Temporarily call Qdelete_window instead of
8959 Fdelete_window (Fbury_buffer will move to window.el soon).
8961 * frame.c (set_menu_bar_lines_1): Remove code handling
8962 orig_top_line and orig_total_lines.
8964 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8965 set_window_height but set heights directly.
8966 (change_frame_size_1): Use resize_frame_windows.
8968 * xdisp.c (init_xdisp): Don't use set_window_height but set
8971 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8972 Use resize_frame_windows instead of change_window_heights and run
8973 run_window_configuration_change_hook.
8975 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8976 instead of change_window_heights and run
8977 run_window_configuration_change_hook.
8979 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8981 * window.c (replace_window): Rename second argument REPLACEMENT to
8982 NEW. New third argument SETFLAG. Rewrite.
8983 (delete_window, make_dummy_parent): Call replace_window with
8985 (window_list_1): Move down in code.
8986 (run_window_configuration_change_hook): Move set_buffer part
8987 before select_frame_norecord part in order to unwind correctly.
8988 Rename count1 to count.
8989 (recombine_windows, delete_deletable_window, resize_root_window)
8990 (Fdelete_other_windows_internal)
8991 (Frun_window_configuration_change_hook, make_parent_window)
8992 (resize_window_check, resize_window_apply, Fresize_window_apply)
8993 (resize_frame_windows, Fsplit_window_internal)
8994 (Fdelete_window_internal, Fresize_mini_window_internal):
8996 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8998 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9000 * window.h (window): Add some new members to window structure -
9001 normal_lines, normal_cols, new_total, new_normal, clone_number,
9002 splits, nest, prev_buffers, next_buffers.
9003 (WINDOW_TOTAL_SIZE): Move here from window.c.
9004 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9006 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9008 (make_dummy_parent): Set new members of windows structure.
9009 (make_window): Move down in code. Handle new members of window
9011 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9012 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9013 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9014 (Fset_window_prev_buffers, Fwindow_next_buffers)
9015 (Fset_window_next_buffers, Fset_window_clone_number):
9017 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9018 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9020 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9021 Argument WINDOW can be now internal window too.
9022 (Fwindow_use_time): Move up in code.
9023 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9025 (Fset_window_configuration, saved_window)
9026 (Fcurrent_window_configuration, save_window_save): Handle new
9027 members of window structure.
9028 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9029 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9030 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9031 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9032 Qget_mru_window, Qresize_root_window,
9033 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9034 Qauto_buffer_name; staticpro them.
9036 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9038 * window.c (Fwindow_total_size, Fwindow_left_column)
9039 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9040 (Fwindow_list_1): New functions.
9041 (window_box_text_cols): Replace with window_body_cols.
9042 (Fwindow_width, Fscroll_left, Fscroll_right):
9043 Use window_body_cols instead of window_box_text_cols.
9044 (delete_window, Fset_window_configuration):
9045 Call delete_all_subwindows with window as argument.
9046 (delete_all_subwindows): Take a window as argument and not a
9048 (window_loop): Remove handling of GET_LRU_WINDOW and
9050 (Fget_lru_window, Fget_largest_window): Move to window.el.
9052 * window.h: Extern window_body_cols instead of
9053 window_box_text_cols. delete_all_subwindows now takes a
9054 Lisp_Object as argument.
9056 * indent.c (compute_motion, Fcompute_motion):
9057 Use window_body_cols instead of window_box_text_cols.
9059 * frame.c (delete_frame): Call delete_all_subwindows with root
9062 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9064 * fns.c (Fputhash): Document return value.
9066 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9068 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9070 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9072 Cons<->int and similar integer overflow fixes (Bug#8794).
9074 Check for overflow when converting integer to cons and back.
9075 * charset.c (Fdefine_charset_internal, Fdecode_char):
9076 Use cons_to_unsigned to catch overflow.
9077 (Fencode_char): Use INTEGER_TO_CONS.
9078 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9079 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9080 * data.c (long_to_cons, cons_to_long): Remove.
9081 (cons_to_unsigned, cons_to_signed): New functions.
9082 These signal an error for invalid or out-of-range values.
9083 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9084 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9085 * font.c (Ffont_variation_glyphs):
9086 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9087 * lisp.h: Include <intprops.h>.
9088 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9089 (cons_to_signed, cons_to_unsigned): New decls.
9090 (long_to_cons, cons_to_long): Remove decls.
9091 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9092 (Fprimitive_undo): Use CONS_TO_INTEGER.
9093 * xfns.c (Fx_window_property): Likewise.
9094 * xselect.c: Include <limits.h>.
9095 (x_own_selection, selection_data_to_lisp_data):
9096 Use INTEGER_TO_CONS.
9097 (x_handle_selection_request, x_handle_selection_clear)
9098 (x_get_foreign_selection, Fx_disown_selection_internal)
9099 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9100 (lisp_data_to_selection_data): Use cons_to_unsigned.
9101 (x_fill_property_data): Use cons_to_signed.
9102 Report values out of range.
9104 Check for buffer and string overflow more precisely.
9105 * buffer.h (BUF_BYTES_MAX): New macro.
9106 * lisp.h (STRING_BYTES_MAX): New macro.
9107 * alloc.c (Fmake_string):
9108 * character.c (string_escape_byte8):
9109 * coding.c (coding_alloc_by_realloc):
9110 * doprnt.c (doprnt):
9111 * editfns.c (Fformat):
9113 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9114 since they may not be the same number.
9115 * editfns.c (Finsert_char):
9116 * fileio.c (Finsert_file_contents):
9117 Likewise for BUF_BYTES_MAX.
9119 * image.c: Use ptrdiff_t, not int, for sizes.
9120 (slurp_file): Switch from int to ptrdiff_t.
9122 (slurp_file): Check that file size fits in both size_t (for
9123 malloc) and ptrdiff_t (for sanity and safety).
9125 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9126 if b->modtime has its maximal value.
9128 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9130 Don't assume time_t can fit into int.
9131 * buffer.h (struct buffer.modtime): Now time_t, not int.
9132 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9133 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9135 Minor fixes for signed vs unsigned integers.
9136 * character.h (MAYBE_UNIFY_CHAR):
9137 * charset.c (maybe_unify_char):
9138 * keyboard.c (read_char, reorder_modifiers):
9139 XINT -> XFASTINT, since the integer must be nonnegative.
9140 * ftfont.c (ftfont_spec_pattern):
9141 * keymap.c (access_keymap, silly_event_symbol_error):
9142 XUINT -> XFASTINT, since the integer must be nonnegative.
9143 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9144 since it makes no difference and we prefer signed.
9145 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9146 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9149 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9151 * window.h (Fwindow_frame): Declare.
9153 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9155 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9156 (SPARE_MEMORY): Always define.
9157 (LARGE_REQUEST): Remove.
9158 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9160 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9162 * lisp.h: Move EXFUNS for Fframe_root_window,
9163 Fframe_first_window and Fset_frame_selected_window to window.h.
9165 * window.h: Move EXFUNS for Fframe_root_window,
9166 Fframe_first_window and Fset_frame_selected_window here from
9169 * frame.c (Fwindow_frame, Fframe_first_window)
9170 (Fframe_root_window, Fframe_selected_window)
9171 (Fset_frame_selected_window): Move to window.c.
9172 (Factive_minibuffer_window): Move to minibuf.c.
9173 (Fother_visible_frames_p): New function.
9175 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9177 * window.c (decode_window, decode_any_window): Move up in code.
9178 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9179 (inhibit_frame_unsplittable): Remove unused variable.
9180 (Fwindow_buffer): Move up and rewrite doc-string.
9181 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9182 (Fwindow_prev): New functions.
9183 (Fwindow_frame): Move here from frame.c. Accept any window as
9185 (Fframe_root_window, Fframe_first_window)
9186 (Fframe_selected_window): Move here from frame.c. Accept frame
9187 or arbitrary window as argument. Update doc-strings.
9188 (Fminibuffer_window): Move up in code.
9189 (Fwindow_minibuffer_p): Move up in code and simplify.
9190 (Fset_frame_selected_window): Move here from frame.c.
9192 (Fselected_window, select_window, Fselect_window): Move up in
9193 code. Minor doc-string fixes.
9195 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9197 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9198 Do not assume that spare memory exists; that assumption is valid
9199 only if SYSTEM_MALLOC.
9200 (LARGE_REQUEST): New macro, so that the issue of large requests
9201 is separated from the issue of spare memory.
9203 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9205 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9208 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9210 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9213 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9215 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9217 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9219 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9220 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9222 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9224 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9226 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9228 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9229 (x_clipboard_manager_save): Add return value.
9230 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9232 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9233 Obey Vx_select_enable_clipboard_manager. Catch errors in
9234 x_clipboard_manager_save (Bug#8779).
9235 (Vx_select_enable_clipboard_manager): New variable.
9236 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9238 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9240 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9242 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9244 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9245 in the current matrix if keep_current_p is non-zero.
9247 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9249 * bidi.c (bidi_level_of_next_char): Fix last change.
9251 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9253 Support bidi reordering of text covered by display properties.
9255 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9256 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9257 (bidi_cache_search, bidi_cache_iterator_state)
9258 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9259 (bidi_level_of_next_char, bidi_move_to_visually_next):
9260 Support character positions inside a run of characters covered by a
9262 (bidi_paragraph_init, bidi_resolve_explicit_1)
9263 (bidi_level_of_next_char): Call bidi_fetch_char and
9264 bidi_fetch_char_advance instead of FETCH_CHAR and
9266 (bidi_init_it): Initialize new members.
9267 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9269 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9270 instead of using explicit *_CHAR codes.
9271 (bidi_resolve_explicit, bidi_resolve_weak):
9272 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9273 bidirectional text is supported only in multibyte buffers.
9274 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9275 it to initialize the frame_window_p member of struct bidi_it.
9276 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9277 (bidi_resolve_explicit, bidi_resolve_weak)
9278 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9279 bidi_it->nchars is non-positive.
9280 (bidi_level_of_next_char): Don't try to lookup the cache for the
9281 next/previous character if nothing is cached there yet, or if we
9282 were just reseat()'ed to a new position.
9284 * xdisp.c (set_cursor_from_row): Set start and stop points
9285 according to the row's direction when priming the loop that looks
9286 for the glyph on which to display cursor.
9287 (single_display_spec_intangible_p): Function deleted.
9288 (display_prop_intangible_p): Reimplement to call
9289 handle_display_spec instead of single_display_spec_intangible_p.
9290 Accept 3 additional arguments needed by handle_display_spec.
9291 This fixes incorrect cursor motion across display property with complex
9292 values: lists, `(when COND...)' forms, etc.
9293 (single_display_spec_string_p): Support property values that are
9294 lists with the argument STRING its top-level element.
9295 (display_prop_string_p): Fix the condition for processing a
9296 property that is a list to be consistent with handle_display_spec.
9297 (handle_display_spec): New function, refactored from the
9298 last portion of handle_display_prop.
9299 (compute_display_string_pos): Accept additional argument
9300 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9301 value of a `display' property is a "replacing spec".
9302 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9303 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9304 the display property, but just return a value indicating whether
9305 the display property will replace the characters it covers.
9306 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9307 frame_window_p members of struct bidi_it.
9308 (compute_display_string_pos, compute_display_string_end):
9310 (push_it): Accept second argument POSITION, where pop_it should
9311 jump to continue iteration.
9312 (reseat_1): Initialize bidi_it.disp_pos.
9314 * keyboard.c (adjust_point_for_property): Adjust the call to
9315 display_prop_intangible_p to its new signature.
9317 * dispextern.h (struct bidi_it): New member frame_window_p.
9318 (bidi_init_it): Update prototypes.
9319 (display_prop_intangible_p): Update prototype.
9320 (compute_display_string_pos, compute_display_string_end):
9322 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9325 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9327 Malloc failure behavior now depends on size of allocation.
9328 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9329 * lisp.h: Change signatures accordingly.
9330 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9331 All callers changed. (Bug#8762)
9333 * gnutls.c: Use Emacs's memory allocators.
9334 Without this change, the gnutls library would invoke malloc etc.
9335 directly, which causes problems on non-SYNC_INPUT hosts, and which
9336 runs afoul of improving memory_full behavior. (Bug#8761)
9337 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9338 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9339 xfree instead of the default malloc, realloc, free.
9340 (Fgnutls_boot): No need to check for memory allocation failure,
9341 since xmalloc does that for us.
9343 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9344 * category.c (hash_get_category_set):
9345 * ccl.c (ccl_driver):
9346 * charset.c (Fdefine_charset_internal):
9347 * charset.h (struct charset.hash_index):
9348 * composite.c (get_composition_id, gstring_lookup_cache)
9349 (composition_gstring_put_cache):
9350 * composite.h (struct composition.hash_index):
9351 * dispextern.h (struct image.hash):
9352 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9353 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9354 (hashfn_equal, hashfn_user_defined, make_hash_table)
9355 (maybe_resize_hash_table, hash_lookup, hash_put)
9356 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9357 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9358 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9359 * image.c (make_image, search_image_cache, lookup_image)
9360 (xpm_put_color_table_h):
9361 * lisp.h (struct Lisp_Hash_Table):
9362 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9363 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9364 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9365 * alloc.c (allocate_vectorlike):
9366 Check for overflow in vector size calculations.
9367 * ccl.c (ccl_driver):
9368 Check for overflow when converting EMACS_INT to int.
9369 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9370 need to be updated by these changes.
9371 * fns.c (make_hash_table, maybe_resize_hash_table):
9372 Check for integer overflow with large hash tables.
9373 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9374 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9375 (SXHASH_REDUCE): New macro.
9376 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9377 Use it instead of discarding useful hash info with large hash values.
9378 (sxhash_float): New function.
9379 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9380 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9381 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9382 Rewrite to use FIXNUM_BITS, as this simplifies things.
9383 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9384 Adjust signatures to match updated version of code.
9385 (consing_since_gc): Now EMACS_INT, since a single hash table can
9386 use more than INT_MAX bytes.
9388 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9390 Make it possible to build with GCC-4.6+ -O2 -flto.
9392 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9394 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9396 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9397 Call minibuffer-inactive-mode.
9399 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9401 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9402 Update dependencies.
9404 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9406 * data.c (init_data): Remove code for UTS, this system is not
9409 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9411 Don't force ./temacs to start in terminal mode.
9413 * frame.c (make_initial_frame): Initialize faces in all cases, not
9414 only when CANNOT_DUMP is defined.
9415 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9417 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9419 * dispnew.c (add_window_display_history): Use const for the string
9420 pointer. Remove declaration, not needed.
9422 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9424 Use 'inline', not 'INLINE'.
9425 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9426 * alloc.c, fontset.c (INLINE): Remove.
9427 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9428 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9429 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9430 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9431 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9433 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9435 Make it possible to run ./temacs.
9437 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9438 syms_of_callproc does the same thing. Remove test for
9439 "initialized", do it in the caller.
9440 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9442 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9444 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9445 (read_minibuf): Use get_minibuffer.
9446 (syms_of_minibuf): Use DEFSYM.
9447 (Qmetadata): New var.
9448 * data.c (Qbuffer): Don't make it static.
9449 (syms_of_data): Use DEFSYM.
9451 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9453 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9454 (CCL_CODE_MIN): New macro.
9456 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9458 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9460 * eval.c (Qdebug): Now static.
9461 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9462 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9463 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9465 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9467 * image.c: Various fixes to ImageMagick code comments.
9468 (Fimagemagick_types): Doc fix.
9470 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9472 Minor fixes prompted by GCC 4.6.0 warnings.
9474 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9476 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9477 (x_clipboard_manager_save_all): Move extern decl to ...
9478 * xterm.h: ... here, so that it can be checked for consistency.
9480 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9482 * xselect.c (x_clipboard_manager_save_frame)
9483 (x_clipboard_manager_save_all): New functions.
9484 (Fx_clipboard_manager_save): Lisp function deleted.
9486 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9487 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9489 * xterm.h: Update prototype.
9491 2011-05-28 William Xu <william.xwl@gmail.com>
9493 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9496 2011-05-28 Jim Meyering <meyering@redhat.com>
9498 Avoid a sign-extension bug in crypto_hash_function.
9499 * fns.c (to_uchar): Define.
9500 (crypto_hash_function): Use it to convert some newly-signed
9501 variables to unsigned, to avoid sign-extension bugs. For example,
9502 without this change, (md5 "truc") would evaluate to
9503 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9504 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9505 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9507 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9509 Integer overflow fixes.
9511 * dbusbind.c: Serial number integer overflow fixes.
9512 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9513 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9514 to hold a serial number that is too large for a fixnum.
9515 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9516 Check for serial numbers out of range. Decode any serial number
9517 that was so large that it became a float. (Bug#8722)
9519 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9520 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9521 Use XFASTINT rather than XUINT when numbers are nonnegative.
9522 (xd_append_arg, Fdbus_method_return_internal):
9523 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9524 arguments, check that Lisp number is nonnegative, rather than
9525 silently wrapping negative numbers around. (Bug#8722)
9526 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9529 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9531 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9533 ccl: Add integer overflow checks.
9534 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9535 (IN_INT_RANGE): New macros.
9536 (ccl_driver): Use them to check for integer overflow when
9537 decoding a CCL program. Many of the new checks are whether XINT (x)
9538 fits in int; it doesn't always, on 64-bit hosts. The new version
9539 doesn't catch all possible integer overflows, but it's an
9540 improvement. (Bug#8719)
9542 * alloc.c (make_event_array): Use XINT, not XUINT.
9543 There's no need for unsigned here.
9545 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9546 This follows up to the 2011-05-06 change that substituted uintptr_t
9547 for EMACS_INT. This case wasn't caught back then.
9549 Rework Fformat to avoid integer overflow issues.
9550 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9551 now (part of C89). Include <verify.h>.
9552 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9553 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9554 (Fformat): Avoid the prepass trying to compute sizes; it was only
9555 approximate and thus did not catch overflow reliably. Instead, walk
9556 through the format just once, formatting and computing sizes as we go,
9557 checking for integer overflow at every step, and allocating a larger
9558 buffer as needed. Keep track separately whether the format is
9559 multibyte. Keep only the most-recently calculated precision, rather
9560 than them all. Record whether each argument has been converted to
9561 string. Use EMACS_INT, not int, for byte and char and arg counts.
9562 Support field widths and precisions larger than INT_MAX. Avoid
9563 sprintf's undefined behavior with conversion specifications such as %#d
9564 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9565 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9566 formatting out-of-range floating point numbers with int
9569 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9571 * data.c: Avoid integer truncation in expressions involving floats.
9572 * data.c: Include <intprops.h>.
9573 (arith_driver): When there's an integer overflow in an expression
9574 involving floating point, convert the integers to floating point
9575 so that the resulting value does not suffer from catastrophic
9576 integer truncation. For example, on a 64-bit host (* 4
9577 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9578 Do not rely on undefined behavior after integer overflow.
9580 merge count_size_as_multibyte, parse_str_to_multibyte
9581 * character.c, character.h (count_size_as_multibyte):
9582 Rename from parse_str_to_multibyte; all uses changed.
9583 Check for integer overflow.
9584 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9585 since it's now a duplicate of the other. This is more of
9586 a character than a buffer op, so better that it's in character.c.
9587 * fns.c, print.c: Adjust to above changes.
9589 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9591 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9593 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9595 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9596 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9597 (x_clipboard_manager_save): Now static.
9598 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9600 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9601 (crypto_hash_function): Now static.
9602 Fix pointer signedness problems. Avoid unnecessary initializations.
9604 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9606 * termhooks.h (Vselection_alist): Make it terminal-local.
9608 * terminal.c (create_terminal): Initialize it.
9610 * xselect.c: Support for clipboard managers.
9611 (Vselection_alist): Move to termhooks.h as terminal-local var.
9612 (LOCAL_SELECTION): New macro.
9613 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9614 (symbol_to_x_atom): Remove gratuitous arg.
9615 (x_handle_selection_request, lisp_data_to_selection_data)
9616 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9617 (x_own_selection, x_get_local_selection, x_convert_selection):
9618 New arg, specifying work frame. Use terminal-local Vselection_alist.
9619 (some_frame_on_display): Delete unused function.
9620 (Fx_own_selection_internal, Fx_get_selection_internal)
9621 (Fx_disown_selection_internal, Fx_selection_owner_p)
9622 (Fx_selection_exists_p): New optional frame arg.
9623 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9624 (x_handle_selection_clear): Don't treat other terminals with the
9625 same keyboard specially. Use the terminal-local Vselection_alist.
9626 (x_clear_frame_selections): Use Frun_hook_with_args.
9628 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9630 * xterm.h: Add support for those atoms.
9632 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9634 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9635 (converted_selections, conversion_fail_tag): New global variables.
9636 (x_selection_request_lisp_error): Free the above.
9637 (x_get_local_selection): Remove unnecessary code.
9638 (x_reply_selection_request): Args changed; handle arbitrary array
9639 of converted selections stored in converted_selections.
9640 Separate the XChangeProperty and SelectionNotify steps.
9641 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9642 (x_convert_selection): New function.
9643 (x_handle_selection_event): Simplify.
9644 (x_get_foreign_selection): Don't ignore incoming requests while
9645 waiting for an answer; this will fail when we implement
9646 SAVE_TARGETS, and seems unnecessary anyway.
9647 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9648 (Vx_sent_selection_functions): Doc fix.
9650 2011-05-26 Leo Liu <sdl.web@gmail.com>
9652 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9654 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9656 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9658 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9659 for fringe update if it has periodic bitmap.
9660 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9661 and fringe_bitmap_periodic_p.
9663 * fringe.c (get_fringe_bitmap_data): New function.
9664 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9665 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9666 row. Mark glyph row for fringe update if periodicity changed.
9668 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9669 for fringe update unless it has periodic bitmap.
9671 2011-05-25 Kenichi Handa <handa@m17n.org>
9673 * xdisp.c (get_next_display_element): Set correct it->face_id for
9674 a static composition.
9676 2011-05-24 Leo Liu <sdl.web@gmail.com>
9679 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9681 * fns.c (crypto_hash_function, Fsha1): New function.
9682 (Fmd5): Use crypto_hash_function.
9683 (syms_of_fns): Add Ssha1.
9685 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9687 * gnutls.c: Remove unused macros.
9688 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9689 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9690 Remove macros that are defined and never used.
9691 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9693 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9695 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9696 (Fx_get_selection_internal): Minor cleanup.
9697 (Fx_own_selection_internal): Rename arguments for consistency with
9700 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9702 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9704 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9706 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9708 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9710 * dispnew.c (scrolling_window): Don't exclude the case that the
9711 last enabled row in the desired matrix touches the bottom boundary.
9713 2011-05-21 Glenn Morris <rgm@gnu.org>
9715 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9716 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9717 and add some more files.
9719 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9721 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9722 report_file_error introduced by the change from 2011-05-07.
9724 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9726 * systime.h (Time): Define only if emacs is defined.
9727 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9728 where the include path doesn't have X11/X.h by default. See
9729 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9731 2011-05-20 Kenichi Handa <handa@m17n.org>
9733 * composite.c (find_automatic_composition): Fix previous change.
9735 2011-05-20 Glenn Morris <rgm@gnu.org>
9737 * lisp.mk: New file, split from Makefile.in.
9738 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9739 (shortlisp): Remove.
9740 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9742 2011-05-19 Glenn Morris <rgm@gnu.org>
9744 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9745 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9746 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9747 (lisp): Set the order to that of loadup.el.
9748 (shortlisp): Make it a copy of $lisp.
9749 (SOME_MACHINE_LISP): Remove.
9750 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9751 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9753 2011-05-18 Kenichi Handa <handa@m17n.org>
9755 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9756 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9757 (find_automatic_composition): Mostly rewrite for efficiency.
9759 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9761 * makefile.w32-in: Update dependencies.
9763 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9765 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9766 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9768 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9770 Fix some integer overflow issues, such as string length overflow.
9772 * insdel.c (count_size_as_multibyte): Check for string overflow.
9774 * character.c (lisp_string_width): Check for string overflow.
9775 Use EMACS_INT, not int, for string indexes and lengths; in
9776 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9777 the resulting string length overflows an EMACS_INT; instead,
9778 report a string overflow if no precision given. When checking for
9779 precision exhaustion, use a check that cannot possibly have
9780 integer overflow. (Bug#8675)
9781 * character.h (lisp_string_width): Adjust to new signature.
9783 * alloc.c (string_overflow): New function.
9784 (Fmake_string): Use it. This doesn't change behavior, but saves
9785 a few bytes and will simplify future changes.
9786 * character.c (string_escape_byte8): Likewise.
9787 * lisp.h (string_overflow): New decl.
9789 Fixups, following up to the user-interface timestamp change.
9790 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9791 for UI timestamps, instead of unsigned long.
9792 * msdos.c (mouse_get_pos): Likewise.
9793 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9794 * w32gui.h (Time): Define by including "systime.h" rather than by
9795 declaring it ourselves. (Bug#8664)
9797 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9798 * image.c (clear_image_cache): Likewise.
9800 * term.c (term_mouse_position): Don't assume time_t wraparound.
9802 Be more systematic about user-interface timestamps.
9803 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9804 and sometimes 'EMACS_UINT', to represent these timestamps.
9805 This change causes it to use 'Time' uniformly, as that's what X uses.
9806 This makes the code easier to follow, and makes it easier to catch
9807 integer overflow bugs such as Bug#8664.
9808 * frame.c (Fmouse_position, Fmouse_pixel_position):
9809 Use Time, not unsigned long, for user-interface timestamps.
9810 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9811 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9812 * keyboard.h (last_event_timestamp): Likewise.
9813 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9814 * menu.h (xmenu_show): Likewise.
9815 * term.c (term_mouse_position): Likewise.
9816 * termhooks.h (struct input_event.timestamp): Likewise.
9817 (struct terminal.mouse_position_hook): Likewise.
9818 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9819 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9820 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9821 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9823 * menu.h, termhooks.h: Include "systime.h", for Time.
9825 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9826 Don't assume that the difference between two unsigned long values
9827 can fit into an integer. At this point, we know button_down_time
9828 <= event->timestamp, so the difference must be nonnegative, so
9829 there's no need to cast the result if double-click-time is
9830 nonnegative, as it should be; check that it's nonnegative, just in
9831 case. This bug is triggered when events are more than 2**31 ms
9832 apart (about 25 days). (Bug#8664)
9834 * xselect.c (last_event_timestamp): Remove duplicate decl.
9835 (x_own_selection): Remove needless cast to unsigned long.
9837 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9838 that always fit in int. Use a sentinel instead of a counter, to
9839 avoid a temp and to allay GCC's concerns about possible int overflow.
9840 * frame.h (struct frame): Use int for menu_bar_items_used
9841 instead of EMACS_INT, since it always fits in int.
9843 * menu.c (grow_menu_items): Check for int overflow.
9845 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9847 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9848 Before, the code was not consistent. These values cannot exceed
9849 2**31 - 1 so there's no need to make them unsigned.
9850 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9851 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9852 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9854 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9856 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9857 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9858 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9859 presumably because the widths might not match.
9861 * window.c (size_window): Avoid needless test at loop start.
9863 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9865 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9867 2011-05-12 Drew Adams <drew.adams@oracle.com>
9869 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9871 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9873 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9874 `width' to `bar_area_x' and `bar_area_width', respectively.
9875 (x_scroll_run): Take account of fringe background extension.
9877 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9878 Rename local vars `left' and `width' to `bar_area_x' and
9879 `bar_area_width', respectively.
9880 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9881 background extension.
9883 2011-05-10 Jim Meyering <meyering@redhat.com>
9885 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9887 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9889 * image.c (Finit_image_library): Return t for built-in image types,
9890 like pbm and xbm. (Bug#8640)
9892 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9894 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9896 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9898 * w32console.c (Fset_screen_color): Doc fix.
9899 (Fget_screen_color): New function.
9900 (syms_of_ntterm): Defsubr it.
9902 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9903 unlink the temporary file if Fcall_process didn't create it in the
9905 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9906 child process will be redirected to a file specified with `:file'.
9907 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9908 cue to call_process_cleanup not to close that handle.
9910 2011-05-07 Ben Key <bkey76@gmail.com>
9912 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9913 one of two shell specific rules, either bootstrap-temacs-CMD or
9914 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9915 to the previous implementation of the bootstrap-temacs rule.
9916 The bootstrap-temacs-CMD rule is similar to the previous
9917 implementation of the bootstrap-temacs rule except that it
9918 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9921 These changes, along with some changes to nt/configure.bat,
9922 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9923 earlier fix to add support for --cflags and --ldflags options
9924 that include quotes so that it works whether make uses cmd or
9927 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9929 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9930 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9932 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9933 a string. Handle both cases.
9934 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9935 (Fdbus_register_method): Use Qinvalid_function.
9937 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9939 * makefile.w32-in: Update dependencies.
9940 (LISP_H): Add inttypes.h and stdin.h.
9941 (PROCESS_H): Add unistd.h.
9943 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9945 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9946 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9948 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9950 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9952 * term.c (vfatal): Remove stray call to va_end.
9953 It's not needed and the C Standard doesn't allow it here anyway.
9955 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9956 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9958 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9961 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9963 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9965 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9967 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9969 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9971 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9972 * charset.c (Fdefine_charset_internal): Don't initialize
9973 charset.code_space[15]. The value was garbage, on hosts with
9974 32-bit int (Bug#8600).
9976 * lread.c (read_integer): Be more consistent with string-to-number.
9977 Use string_to_number to do the actual conversion; this avoids
9978 rounding errors and fixes some other screwups. Without this fix,
9979 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9980 (digit_to_number): Move earlier, for benefit of read_integer.
9981 Return -1 if the digit is out of range for the base, -2 if it is
9982 not a digit in any supported base. (Bug#8602)
9984 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9986 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9987 to match comment at start of function. This also removes a
9988 GCC warning about overflow in a 32+64-bit port.
9990 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9992 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9993 Reported by Stefan Monnier in
9994 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9995 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9996 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9998 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9999 (EMACS_UINTPTR): Likewise, with uintptr_t.
10001 * lisp.h: Prefer 64-bit EMACS_INT if available.
10002 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10003 on 32-bit hosts that have 64-bit int, so that they can access
10005 However, temporarily disable this change unless the temporary
10006 symbol WIDE_EMACS_INT is defined.
10008 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10010 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10011 This removes an assumption that EMACS_INT and long are the same
10012 width as pointers. The assumption is true for Emacs porting targets
10013 now, but we want to make other targets possible.
10014 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10015 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10016 In the rest of the code, change types of integers that hold casted
10017 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10018 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10019 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10020 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10021 No need to cast type when ORing.
10022 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10023 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10024 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10025 assume EMACS_INT is the same width as char *.
10026 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10027 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10028 Remove no-longer-needed casts.
10029 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10030 (xg_tool_bar_help_callback, xg_make_tool_item):
10031 Use EMACS_INTPTR to hold an integer
10032 that will be cast to void *; this can avoid a GCC warning
10033 if EMACS_INT is not the same width as void *.
10034 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10035 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10036 (current_message_1, set_message_1):
10037 Use a local to convert to proper width without a cast.
10038 * xmenu.c (dialog_selection_callback): Likewise.
10040 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10041 Also, don't assume VALBITS / RAND_BITS is less than 5,
10042 and don't rely on undefined behavior when shifting a 1 left into
10044 * lisp.h (get_random): Change signature to match.
10046 * lread.c (hash_string): Use size_t, not int, for hash computation.
10047 Normally we prefer signed values; but hashing is special, because
10048 it's better to use unsigned division on hash table sizes so that
10049 the remainder is nonnegative. Also, size_t is the natural width
10050 for hashing into memory. The previous code used 'int', which doesn't
10051 retain enough info to hash well into very large tables.
10052 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10054 * dbusbind.c: Don't possibly lose pointer info when converting.
10055 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10056 Use XPNTR rather than XHASH, so that the high-order bits of
10057 the pointer aren't lost when converting through void *.
10059 * eval.c (Fautoload): Don't double-shift a pointer.
10061 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10063 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10065 * gnutls.c (DEF_GNUTLS_FN):
10066 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10068 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10070 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10073 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10075 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10076 New version that can reserve upto 2GB of heap space.
10078 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10080 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10082 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10084 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10085 `gnutls_certificate_set_x509_key_file'.
10087 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10089 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10090 Update dependencies.
10092 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10094 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10095 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10096 Remove unused parameter `fildes'.
10097 * process.c (read_process_output, send_process): Don't pass it.
10099 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10101 Fix previous change: the library cache is defined in w32.c.
10102 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10103 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10105 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10107 Implement dynamic loading of GnuTLS on Windows.
10109 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10110 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10111 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10114 * gnutls.c (Qgnutls_dll): Define.
10115 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10116 (gnutls_*): Declare function pointers.
10117 (init_gnutls_functions): New function to initialize function pointers.
10118 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10119 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10120 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10121 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10122 (emacs_gnutls_write, emacs_gnutls_read)
10123 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10124 (Fgnutls_available_p): New function.
10125 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10126 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10127 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10129 * image.c: Include w32.h.
10130 (Vimage_type_cache): Delete.
10131 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10132 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10133 (w32_delayed_load): Move to w32.c.
10135 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10137 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10138 (w32_delayed_load): Move from image.c. When loading a library, record
10139 its filename in the :loaded-from property of the library id.
10140 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10141 Initialize and staticpro them.
10142 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10144 * process.c: Include lisp.h before w32.h, not after.
10145 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10146 instead of gnutls_record_check_pending.
10148 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10150 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10152 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10153 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10156 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10158 * xterm.c (x_set_frame_alpha): Do not set property on anything
10159 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10161 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10163 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10165 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10167 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10168 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10169 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10170 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10171 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10172 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10173 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10174 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10175 (Qgnutls_bootprop_callbacks_verify): Make static.
10177 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10179 * callproc.c: Indentation fixup.
10181 * sysdep.c (wait_for_termination_1): Make static.
10182 (wait_for_termination, interruptible_wait_for_termination):
10183 Move after wait_for_termination_1.
10185 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10187 * sysdep.c (interruptible_wait_for_termination): New function
10188 which is like wait_for_termination, but allows keyboard
10191 * callproc.c (Fcall_process): Add (:file "file") as an option for
10193 (Fcall_process_region): Ditto.
10195 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10197 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10198 rather than `XVECTOR (FOO)->size'.
10200 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10201 inttypes.h, as a gnulib replacement is used if it not available in
10204 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10206 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10207 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10208 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10210 * coding.c (coding_alloc_by_realloc): Error out if destination
10211 will grow beyond MOST_POSITIVE_FIXNUM.
10212 (decode_coding_emacs_mule): Abort if there isn't enough place in
10213 charbuf for the composition carryover bytes. Reserve an extra
10214 space for up to 2 characters produced in a loop.
10215 (decode_coding_iso_2022): Abort if there isn't enough place in
10216 charbuf for the composition carryover bytes.
10218 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10220 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10221 aborting when %lld or %lll format is passed.
10222 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10223 %llo or %llx format is passed. (Bug#8545)
10225 * window.c (window_scroll_line_based): Use a marker instead of
10226 simple variables to record original value of point. (Bug#7952)
10228 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10229 produced by %s or %c overflows available buffer space. (Bug#8545)
10231 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10233 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10234 (SIZE_MAX): Move defn after all includes, as they might #define it.
10236 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10238 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10240 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10242 * keyboard.c (Qdelayed_warnings_hook): Define.
10243 (command_loop_1): Run `delayed-warnings-hook'
10244 if Vdelayed_warnings_list is non-nil.
10245 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10246 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10248 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10250 * doprnt.c (doprnt): Don't return value smaller than the buffer
10251 size if the message was truncated. (Bug#8545).
10253 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10255 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10256 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10258 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10260 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10262 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10264 * makefile.w32-in: Update dependencies.
10266 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10268 Improve `doprnt' and its usage. (Bug#8545)
10269 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10270 `format_end'. Remove support for %l as a conversion specifier.
10271 Don't use xrealloc. Improve diagnostics when the %l size modifier
10272 is used. Update the commentary.
10274 * eval.c (verror): Simplify calculation of size_t.
10276 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10279 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10281 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10284 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10286 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10287 This makes this file independent of the recent pseudovector change.
10289 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10291 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10293 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10294 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10295 Remove unused local.
10296 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10298 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10299 GCC 4.6.0 optimizes based on type-based alias analysis.
10300 For example, if b is of type struct buffer * and v of type struct
10301 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10302 != &v->size, and therefore "v->size = 1; b->size = 2; return
10303 v->size;" must therefore return 1. This assumption is incorrect
10304 for Emacs, since it type-puns struct Lisp_Vector * with many other
10305 types. To fix this problem, this patch adds a new type struct
10306 vectorlike_header that documents the constraints on layout of vectors
10307 and pseudovectors, and helps optimizing compilers not get fooled
10308 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10309 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10310 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10312 (XSETPVECTYPE): Rewrite in terms of new macro.
10313 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10314 This is a bit clearer, and further avoids the possibility of
10315 undesirable aliasing.
10316 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10317 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10318 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10319 since Lisp_Subr is a special case (no "next" field).
10320 (ASIZE): Now uses header.size rather than size.
10321 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10322 to avoid the hassle of writing XVECTOR (foo)->header.size.
10323 (struct vectorlike_header): New type.
10324 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10325 object, to help avoid aliasing.
10326 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10327 (SUBRP): Likewise, since Lisp_Subr is a special case.
10328 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10329 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10330 (struct Lisp_Hash_Table): Combine first two members into a single
10331 struct vectorlike_header member. All uses of "size" and "next" members
10332 changed to be "header.size" and "header.next".
10333 * buffer.h (struct buffer): Likewise.
10334 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10335 * frame.h (struct frame): Likewise.
10336 * process.h (struct Lisp_Process): Likewise.
10337 * termhooks.h (struct terminal): Likewise.
10338 * window.c (struct save_window_data, struct saved_window): Likewise.
10339 * window.h (struct window): Likewise.
10340 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10341 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10342 * buffer.c (init_buffer_once): Likewise.
10343 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10345 * process.c (Fformat_network_address): Use local var for size,
10348 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10350 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10351 * data.c (atof): Remove decl; no longer used or needed.
10352 (digit_to_number): Move to lread.c.
10353 (Fstring_to_number): Use new string_to_number function, to be
10354 consistent with how the Lisp reader treats infinities and NaNs.
10355 Do not assume that floating-point numbers represent EMACS_INT
10356 without losing information; this is not true on most 64-bit hosts.
10357 Avoid double-rounding errors, by insisting on integers when
10358 parsing non-base-10 numbers, as the documentation specifies.
10359 * lisp.h (string_to_number): New decl, replacing ...
10360 (isfloat_string): Remove.
10361 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10362 (read1): Do not accept +. and -. as integers; this
10363 appears to have been a coding error. Similarly, do not accept
10364 strings like +-1e0 as floating point numbers. Do not report
10365 overflow for integer overflows unless the base is not 10 which
10366 means we have no simple and reliable way to continue.
10367 Break out the floating-point parsing into a new
10368 function string_to_number, so that Fstring_to_number parses
10369 floating point numbers consistently with the Lisp reader.
10370 (digit_to_number): Move here from data.c. Make it static inline.
10371 (E_CHAR, EXP_INT): Remove, replacing with ...
10372 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10373 (string_to_number): New function, replacing isfloat_string.
10374 This function checks for valid syntax and produces the resulting
10375 Lisp float number too. Rework it so that string-to-number
10376 no longer mishandles examples like "1.0e+". Use strtoumax,
10377 so that overflow for non-base-10 numbers is reported only when
10378 there's no portable and simple way to convert to floating point.
10380 * textprop.c (set_text_properties_1): Rewrite for clarity,
10381 and to avoid GCC warning about integer overflow.
10383 * intervals.h (struct interval): Use EMACS_INT for members
10384 where EMACS_UINT might cause problems. See
10385 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10386 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10387 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10389 (offset_intervals): Tell GCC not to worry about length overflow
10390 when negating a negative length.
10392 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10393 (overrun_check_free): Likewise.
10395 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10396 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10399 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10400 (gnutls_make_error): Rename local to avoid shadowing.
10401 (gnutls_emacs_global_deinit): ifdef out; not used.
10402 (Fgnutls_boot): Use const for pointer to readonly storage.
10403 Comment out unused local. Fix pointer signedness problems.
10405 * lread.c (openp): Don't stuff size_t into an 'int'.
10406 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10407 about possible signed overflow.
10409 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10410 (GDK_KEY_g): Don't define if already defined.
10411 (xg_prepare_tooltip): Avoid pointer signedness problem.
10412 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10414 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10415 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10417 * xfns.c (Fx_window_property): Simplify a bit,
10418 to make a bit faster and to avoid GCC 4.6.0 warning.
10419 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10421 * fns.c (internal_equal): Don't assume size_t fits in int.
10423 * alloc.c (compact_small_strings): Tighten assertion a little.
10425 Replace pEd with more-general pI, and fix some printf arg casts.
10426 * lisp.h (pI): New macro, generalizing old pEd macro to other
10427 conversion specifiers. For example, use "...%"pI"d..." rather
10428 than "...%"pEd"...".
10429 (pEd): Remove. All uses replaced with similar uses of pI.
10430 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10431 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10432 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10433 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10434 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10435 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10436 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10438 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10439 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10440 * print.c (safe_debug_print, print_object): Likewise.
10441 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10443 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10444 avoiding the 0 flag, which is not portable.
10445 * process.c (Fmake_network_process): Use pI to avoid cast.
10446 * region-cache.c (pp_cache): Likewise.
10447 * xdisp.c (decode_mode_spec): Likewise.
10448 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10449 behavior on 64-bit hosts with printf arg.
10450 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10451 (x_stop_queuing_selection_requests): Likewise.
10452 (x_get_window_property): Don't truncate byte count to an 'int'
10455 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10456 here, since it parses constructs like leading '-' and spaces,
10457 which are not wanted; and it overflows with large numbers.
10458 Instead, simply match F[0-9]+, which is what is wanted anyway.
10460 * alloc.c: Remove unportable assumptions about struct layout.
10461 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10462 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10463 (allocate_vectorlike, make_pure_vector): Use the new macros,
10464 plus offsetof, to remove unportable assumptions about struct layout.
10465 These assumptions hold on all porting targets that I know of, but
10466 they are not guaranteed, they're easy to remove, and removing them
10467 makes further changes easier.
10469 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10470 This doesn't fix a bug but makes the code clearer.
10471 (string_overrun_cookie): Now const. Use initializers that
10472 don't formally overflow signed char, to avoid warnings.
10473 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10474 can cause Emacs to crash when string overrun checking is enabled.
10475 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10476 multiple of sizeof (EMACS_INT); it need not be, if
10477 alignof(EMACS_INT) < sizeof (EMACS_INT).
10478 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10480 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10482 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10484 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10486 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10487 supposed to be handshaking. (Bug#8556)
10488 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10490 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10492 * lisp.h (Qdebug): List symbol.
10493 * eval.c (Qdebug): Restore global linkage.
10494 * keyboard.c (debug-on-event): New variable.
10495 (handle_user_signal): Break into debugger when debug-on-event
10496 matches the current signal symbol.
10498 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10500 * alloc.c (check_sblock, check_string_bytes)
10501 (check_string_free_list): Convert to standard C.
10503 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10505 * w32.c (emacs_gnutls_push): Fix typo.
10507 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10509 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10510 "cast to pointer from integer of different size".
10512 Improve doprnt and its use in verror. (Bug#8545)
10513 * doprnt.c (doprnt): Document the set of format control sequences
10514 supported by the function. Use SAFE_ALLOCA instead of always
10517 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10518 is one byte too soon. Don't use xrealloc; instead xfree and
10521 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10523 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10526 * gnutls.c: Renamed global_initialized to
10527 gnutls_global_initialized. Added internals for the
10528 :verify-hostname-error, :verify-error, and :verify-flags
10529 parameters of `gnutls-boot' and documented those parameters in the
10530 docstring. Start callback support.
10531 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10532 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10533 on error. Return error code.
10534 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10535 (emacs_gnutls_read): Likewise.
10536 (Fgnutls_boot): Return handshake error code.
10537 (emacs_gnutls_handle_error): New function.
10538 (wsaerror_to_errno): Likewise.
10540 * w32.h (emacs_gnutls_pull): Add prototype.
10541 (emacs_gnutls_push): Likewise.
10543 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10544 (emacs_gnutls_push): Likewise.
10546 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10548 * process.c (wait_reading_process_output): Check if GnuTLS
10549 buffered some data internally if no FDs are set for TLS
10552 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10553 (LIBS): Link to USER_LIBS.
10554 ($(BLD)/gnutls.$(0)): New target.
10556 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10558 * xdisp.c (handle_single_display_spec): Rename the
10559 display_replaced_before_p argument into display_replaced_p, to
10560 make it consistent with the commentary. Fix typos in the
10563 * textprop.c (syms_of_textprop): Remove dead code.
10564 (copy_text_properties): Delete obsolete commentary about an
10565 interface that was deleted long ago. Fix typos in the description
10568 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10569 to changes in oldXMenu/XMenu.h from 2011-04-16.
10570 <menu_help_message, prev_menu_help_message>: Constify.
10571 (IT_menu_make_room): menu->help_text is now `const char **';
10574 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10575 to changes in oldXMenu/XMenu.h from 2011-04-16.
10576 (struct XMenu): Declare `help_text' `const char **'.
10578 * xfaces.c <Qunspecified>: Make extern again.
10580 * syntax.c: Include sys/types.h before including regex.h, as
10583 * doc.c (get_doc_string): Improve the format passed to `error'.
10585 * doprnt.c (doprnt): Improve commentary.
10587 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10589 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10592 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10593 changes in globals.h immediately force recompilation.
10594 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10595 $(CURDIR)/s/ms-w32.h.
10596 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10598 * character.c (Fchar_direction): Function deleted.
10599 (syms_of_character): Don't defsubr it.
10600 <char-direction-table>: Deleted.
10602 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10604 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10605 * doprnt.c: Include limits.h.
10606 (SIZE_MAX): New macro.
10607 (doprnt): Return a size_t value. 2nd arg is now size_t.
10608 Many local variables are now size_t instead of int or unsigned.
10609 Improve overflow protection. Support `l' modifier for integer
10610 conversions. Support %l conversion. Don't assume an EMACS_INT
10611 argument for integer conversions and for %c.
10613 * lisp.h (doprnt): Restore prototype.
10615 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10616 $(SRC)/character.h.
10618 * Makefile.in (base_obj): Add back doprnt.o.
10620 * deps.mk (doprnt.o): Add back prerequisites.
10621 (callint.o): Depend on character.h.
10623 * eval.c (internal_lisp_condition_case): Include the handler
10624 representation in the error message.
10625 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10626 when breaking from the loop.
10628 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10630 * callint.c (Fcall_interactively): When displaying error message
10631 about invalid control letter, pass the character's codepoint, not
10632 a pointer to its multibyte form. Improve display of the character
10633 in octal and display also its hex code.
10635 * character.c (char_string): Use %x to display the (unsigned)
10636 codepoint of an invalid character, to avoid displaying a bogus
10639 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10640 `error', not SYMBOL_NAME itself.
10642 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10643 character arguments to `error'.
10645 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10646 to `error' in error message about FINAL_CHAR argument. Make sure
10647 FINAL_CHAR is a character, and use %c when it is passed as
10648 argument to `error'.
10650 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10652 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10654 * w32.c: Include <time.h>.
10655 (sys_localtime): New function.
10657 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10659 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10661 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10663 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10665 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10666 zombies (Bug#8467).
10668 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10670 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10671 gl_state.e_property when gl_state.object is Qt.
10673 * insdel.c (make_gap_larger): Remove limitation of buffer size
10676 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10678 * xdisp.c (lookup_glyphless_char_display)
10679 (produce_glyphless_glyph): Handle cons cell entry in
10680 glyphless-char-display.
10681 (Vglyphless_char_display): Document it.
10683 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10684 glyphless-char-display.
10686 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10688 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10690 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10692 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10693 definition for no-X builds.
10695 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10697 Static checks with GCC 4.6.0 and non-default toolkits.
10699 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10701 * process.c (keyboard_bit_set): Define only if SIGIO.
10702 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10703 (send_process): Repair possible setjmp clobbering.
10705 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10707 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10709 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10711 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10712 Define only if needed.
10714 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10715 by pacifying GCC about it. Maybe it's time to retire it?
10716 * xfaces.c (USG, __TIMEVAL__): Likewise.
10718 * dispextern.h (struct redisplay_interface): Rename param
10719 to avoid shadowing.
10720 * termhooks.h (struct terminal): Likewise.
10721 * xterm.c (xembed_send_message): Likewise.
10723 * insdel.c (make_gap_smaller): Define only if
10724 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10726 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10729 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10730 so that we aren't warned about unused symbols.
10732 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10734 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10736 * xfns.c (x_real_positions): Mark locals as initialized.
10738 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10740 * xterm.c: Fix problems found by static analysis with other toolkits.
10741 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10742 (x_dispatch_event): Declare static if USE_GTK, and
10743 define if USE_GTK || USE_X_TOOLKIT.
10744 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10745 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10746 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10747 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10749 * xmenu.c (menu_help_callback): Pointer type fixes.
10750 Use const pointers when pointing at readonly data. Avoid pointer
10751 signedness clashes.
10752 (FALSE): Remove unused macro.
10753 (update_frame_menubar): Remove unused decl.
10755 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10757 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10758 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10759 (single_menu_item): Rename local to avoid shadowing.
10761 * keyboard.c (make_lispy_event): Remove unused local var.
10763 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10764 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10766 * bitmaps: Change bitmaps from unsigned char back to the X11
10767 compatible char. Avoid the old compiler warnings about
10768 out-of-range initializers by using, for example, '\xab' rather
10771 * xgselect.c (xgselect_initialize): Check vs interface
10772 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10774 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10776 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10777 to read-only memory.
10779 * fns.c (vector): Remove; this old hack is no longer needed.
10781 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10783 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10785 * xrdb.c (x_load_resources): Omit unused local.
10787 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10788 (x_window): Rename locals to avoid shadowing.
10789 (USG): Use the kludged USG macro, to pacify gcc.
10791 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10792 (x_term_init): Remove local to avoid shadowing.
10794 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10796 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10797 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10799 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10801 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10803 Fix regex.c, syntax.c and friends for buffers > 2GB.
10804 * syntax.h (struct gl_state_s): Declare character position members
10807 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10809 * textprop.c (verify_interval_modification, interval_of):
10810 Declare arguments EMACS_INT.
10812 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10815 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10817 * indent.c (Fvertical_motion): Local variable it_start is now
10820 * regex.c (re_match, re_match_2, re_match_2_internal)
10821 (bcmp_translate, regcomp, regexec, print_double_string)
10822 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10823 (re_compile_pattern, re_exec): Declare arguments and local
10824 variables `size_t' and `ssize_t' and return values `regoff_t', as
10826 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10827 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10828 <compile_stack_type>: `size' and `avail' are now `size_t'.
10830 * regex.h <regoff_t>: Use ssize_t, not int.
10831 (re_search, re_search_2, re_match, re_match_2): Arguments that
10832 specify buffer/string position and length are now ssize_t and
10833 size_t. Return type is regoff_t.
10835 2011-04-16 Ben Key <bkey76@gmail.com>
10837 * nsfont.m: Fixed bugs in ns_get_family and
10838 ns_descriptor_to_entity that were caused by using free to
10839 deallocate memory blocks that were allocated by xmalloc (via
10840 xstrdup). This caused Emacs to crash when compiled with
10841 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10842 --enable-checking=xmallocoverrun). xfree is now used to
10843 deallocate these memory blocks.
10845 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10847 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10849 emacs_write: Accept and return EMACS_INT for sizes.
10850 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10852 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10853 Accept and return EMACS_INT.
10854 (emacs_gnutls_write): Return the number of bytes written on
10856 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10857 (emacs_read, emacs_write): Remove check for negative size, as the
10858 Emacs source code has been audited now.
10859 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10860 (emacs_read, emacs_write): Use it.
10861 * process.c (send_process): Adjust to the new signatures of
10862 emacs_write and emacs_gnutls_write. Do not attempt to store
10863 a byte offset into an 'int'; it might overflow.
10864 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10866 * sound.c: Don't assume sizes fit in 'int'.
10867 (struct sound_device.period_size, alsa_period_size):
10868 Return EMACS_INT, not int.
10869 (struct sound_device.write, vox_write, alsa_write):
10870 Accept EMACS_INT, not int.
10871 (wav_play, au_play): Use EMACS_INT to store sizes and to
10872 record read return values.
10874 2011-04-15 Ben Key <bkey76@gmail.com>
10876 * keyboard.c (Qundefined): Don't declare static since it is used
10878 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10879 static since they are used in nsfont.m.
10881 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10883 * process.c (Qprocessp): Don't declare static.
10884 * lisp.h (Qprocessp): Declare again.
10886 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10888 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10890 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10892 Improve C-level modularity by making more things 'static'.
10894 Don't publish debugger-only interfaces to other modules.
10895 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10896 (verify_bytepos, count_markers): Move decls to the only modules
10898 * region-cache.h (pp_cache): Likewise.
10899 * window.h (check_all_windows): Likewise.
10900 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10902 * sysdep.c (croak): Now static, if
10903 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10904 * syssignal.h (croak): Declare only if not static.
10906 * alloc.c (refill_memory_reserve): Now static if
10907 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10908 * lisp.h (refill_memory_reserve): Declare only if not static.
10910 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10911 Define only if USE_LUCID.
10913 * xrdb.c (x_customization_string, x_rm_string): Now static.
10915 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10916 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10918 * xdisp.c (draw_row_with_mouse_face): Now static.
10919 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10921 * window.h (check_all_windows): Mark externally visible.
10923 * window.c (window_deletion_count): Now static.
10925 * undo.c: Make symbols static if they're not exported.
10926 (last_undo_buffer, last_boundary_position, pending_boundary):
10929 * textprop.c (interval_insert_behind_hooks): Now static.
10930 (interval_insert_in_front_hooks): Likewise.
10932 * term.c: Make symbols static if they're not exported.
10933 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10934 (max_frame_lines, tty_set_terminal_modes):
10935 (tty_reset_terminal_modes, tty_turn_off_highlight):
10936 (get_tty_terminal): Now static.
10937 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10938 * termhooks.h (term_mouse_moveto): Do not declare if
10939 HAVE_WINDOW_SYSTEM.
10940 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10941 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10943 * sysdep.c: Make symbols static if they're not exported.
10944 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10946 (sigprocmask_set, full_mask): Remove; unused.
10947 (wait_debugging): Mark as visible.
10948 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10949 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10951 * syntax.c (syntax_temp): Define only if !__GNUC__.
10953 * sound.c (current_sound_device, current_sound): Now static.
10955 * search.c (searchbufs, searchbuf_head): Now static.
10957 * scroll.c (scroll_cost): Remove; unused.
10958 * dispextern.h (scroll_cost): Remove decl.
10960 * region-cache.h (pp_cache): Mark as externally visible.
10962 * process.c: Make symbols static if they're not exported.
10963 (process_tick, update_tick, create_process, chan_process):
10964 (Vprocess_alist, proc_buffered_char, datagram_access):
10965 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10966 (deactivate_process): Mark defn as static, as well as decl.
10967 * lisp.h (create_process): Remove decl.
10968 * process.h (chan_process, Vprocess_alist): Remove decls.
10970 * print.c: Make symbols static if they're not exported.
10971 (print_depth, new_backquote_output, being_printed, print_buffer):
10972 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10973 (print_interval, print_number_index, initial_stderr_stream):
10975 * lisp.h (Fprinc): Remove decl.
10976 (debug_output_compilation_hack): Mark as externally visible.
10978 * sysdep.c (croak): Move decl from here to syssignal.h.
10979 * syssignal.h (croak): Put it here, so the API can be checked when
10980 'croak' is called from dissociate_if_controlling_tty.
10982 * minibuf.c: Make symbols static if they're not exported.
10983 (minibuf_save_list, choose_minibuf_frame): Now static.
10984 * lisp.h (choose_minibuf_frame): Remove decl.
10986 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10988 * lread.c: Make symbols static if they're not exported.
10989 (read_objects, initial_obarray, oblookup_last_bucket_number):
10991 (make_symbol): Remove; unused.
10992 * lisp.h (initial_obarray, make_symbol): Remove decls.
10994 * keyboard.c: Make symbols static if they're not exported.
10995 (single_kboard, recent_keys_index, total_keys, recent_keys):
10996 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10997 (this_single_command_key_start, echoing, last_auto_save):
10998 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10999 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11000 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11001 (Vlispy_mouse_stem, double_click_count):
11003 (force_auto_save_soon): Define only if SIGDANGER.
11004 (ignore_mouse_drag_p): Now static if
11005 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11006 (print_help): Remove; unused.
11007 (stop_character, last_timer_event): Mark as externally visible.
11008 * keyboard.h (ignore_mouse_drag_p): Declare only if
11009 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11010 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11011 * lisp.h (echoing): Remove decl.
11012 (force_auto_save_soon): Declare only if SIGDANGER.
11013 * xdisp.c (redisplay_window): Simplify code, to make it more
11014 obvious that ignore_mouse_drag_p is not accessed if !defined
11015 USE_GTK && !defined HAVE_NS.
11017 * intervals.c: Make symbols static if they're not exported.
11018 (merge_properties_sticky, merge_interval_right, delete_interval):
11020 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11022 * insdel.c: Make symbols static if they're not exported.
11023 However, leave prepare_to_modify_buffer alone. It's never
11024 called from outside this function, but that appears to be a bug.
11025 (combine_after_change_list, combine_after_change_buffer):
11026 (adjust_after_replace, signal_before_change): Now static.
11027 (adjust_after_replace_noundo): Remove; unused.
11028 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11029 (signal_before_change): Remove decls.
11031 * indent.c (val_compute_motion, val_vmotion): Now static.
11033 * image.c: Make symbols static if they're not exported.
11034 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11036 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11037 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11039 * fringe.c (standard_bitmaps): Now static.
11040 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11042 * frame.c: Make symbols static if they're not exported.
11043 (x_report_frame_params, make_terminal_frame): Now static.
11044 (get_frame_param): Now static, unless HAVE_NS.
11045 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11046 (x_get_resource_string): Remove; not used.
11047 * frame.h (make_terminal_frame, x_report_frame_params):
11048 (x_get_resource_string); Remove decls.
11049 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11050 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11052 * font.c, fontset.c: Make symbols static if they're not exported.
11053 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11054 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11055 * font.c (font_close_object): Now static.
11056 * font.h (font_close_object): Remove.
11057 * fontset.c (FONTSET_OBJLIST): Remove.
11058 (free_realized_fontset) #if-0 the body, which does nothing.
11059 (face_suitable_for_char_p): #if-0, as it's never called.
11060 * fontset.h (face_suitable_for_char_p): Remove decl.
11061 * xfaces.c (face_at_string_position):
11062 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11063 since 0 is always ASCII.
11065 * fns.c (weak_hash_tables): Now static.
11067 * fileio.c: Make symbols static if they're not exported.
11068 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11069 (Vwrite_region_annotation_buffers): Now static.
11071 * eval.c: Make symbols static if they're not exported.
11072 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11073 * lisp.h (backtrace_list): Remove decl.
11075 * emacs.c: Make symbols static if they're not exported.
11076 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11077 (fatal_error_code, fatal_error_signal_hook, standard_args):
11079 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11080 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11081 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11082 * lisp.h (fatal_error_signal_hook): Remove decl.
11083 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11085 * editfns.c: Move a (normally-unused) function to its only use.
11086 * editfns.c, lisp.h (get_operating_system_release): Remove.
11087 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11088 worth the hassle of breaking this out.
11090 * xterm.c: Make symbols static if they're not exported.
11091 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11092 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11093 (x_destroy_window, x_delete_display):
11095 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11096 (x_mouse_leave): Remove; unused.
11097 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11098 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11099 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11101 (x_mouse_leave): Declare only if WINDOWSNT.
11102 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11103 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11106 * ftxfont.c: Make symbols static if they're not exported.
11107 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11109 * font.h (ftxfont_driver): Likewise.
11111 * xfns.c: Make symbols static if they're not exported.
11112 (x_last_font_name, x_display_info_for_name):
11113 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11114 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11115 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11116 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11117 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11118 (last_show_tip_args): Now static.
11119 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11120 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11121 (x_screen_planes): Remove; unused.
11122 * dispextern.h (x_screen_planes): Remove decl.
11124 * dispnew.c: Make symbols static if they're not exported.
11125 * dispextern.h (redraw_garbaged_frames, scrolling):
11126 (increment_row_positions): Remove.
11127 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11128 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11130 (redraw_garbaged_frames): Remove; unused.
11132 * xfaces.c: Make symbols static if they're not exported.
11133 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11135 * xterm.h (defined_color): Remove decls.
11136 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11137 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11138 (menu_face_changed_default, defined_color, free_realized_face):
11139 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11140 (ascii_face_of_lisp_face): Remove; unused.
11142 * xdisp.c: Make symbols static if they're not exported.
11143 * dispextern.h (scratch_glyph_row, window_box_edges):
11144 (glyph_to_pixel_coords, set_cursor_from_row):
11145 (get_next_display_element, set_iterator_to_next):
11146 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11147 (show_mouse_face): Remove decls
11148 * frame.h (message_buf_print): Likewise.
11149 * lisp.h (pop_message, set_message, check_point_in_composition):
11151 * xterm.h (set_vertical_scroll_bar): Likewise.
11152 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11153 (message_buf_print, scratch_glyph_row, displayed_buffer):
11154 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11155 (get_next_display_element, show_mouse_face, window_box_edges):
11156 (frame_to_window_pixel_xy, check_point_in_composition):
11157 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11158 (glyph_to_pixel_coords): Remove; unused.
11160 * dired.c (file_name_completion): Now static.
11162 * dbusbind.c (xd_in_read_queued_messages): Now static.
11164 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11165 * data.c (circular_list_error): Remove.
11167 * commands.h (last_point_position, last_point_position_buffer):
11168 (last_point_position_window): Remove decls.
11169 * keyboard.c: Make these variables static.
11171 * coding.h (coding, code_convert_region, encode_coding_gap):
11173 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11174 (iso_code_class, detect_coding, code_convert_region): Now static.
11175 (encode_coding_gap): Remove; unused.
11177 * chartab.c (chartab_chars, chartab_bits): Now static.
11179 * charset.h (charset_iso_8859_1): Remove decl.
11180 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11183 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11184 * ccl.c (Vccl_program_table): Now static.
11185 (check_ccl_update): Remove; unused.
11187 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11188 * category.h: ... from here.
11189 * category.c (check_category_table, set_category_set): Now static.
11191 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11192 * lisp.h: Remove these decls.
11194 * buffer.c (buffer_count): Remove unused var.
11196 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11197 so that it's not optimized away.
11198 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11199 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11200 exported only to the debugger.
11202 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11203 * atimer.h (run_all_atimers): Remove; not exported.
11205 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11206 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11207 was inaccessible from Lisp.
11208 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11209 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11211 alloc.c: Import and export fewer symbols, and remove unused items.
11212 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11214 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11215 it's not optimized away by whole-program optimization.
11216 (message_enable_multibyte, free_misc): Remove.
11217 (catchlist, handlerlist, mark_backtrace):
11218 Declare only if BYTE_MARK_STACK.
11219 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11220 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11221 (message_enable_multibyte): Remove decl.
11222 (free_misc, interval_free_list, float_block, float_block_index):
11223 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11224 (cons_free_list, last_marked_index):
11226 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11227 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11228 (mark_backtrace): Define only if BYTE_MARK_STACK.
11229 * xdisp.c (message_enable_multibyte): Now static.
11231 Declare Lisp_Object Q* variables to be 'static' if not exported.
11232 This makes it easier for human readers (and static analyzers)
11233 to see whether these variables are used from other modules.
11234 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11235 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11236 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11237 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11238 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11239 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11240 * xmenu.c, xselect.c:
11241 Declare Q* vars static if they are not used in other modules.
11242 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11243 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11244 Remove decls of unexported vars.
11245 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11247 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11249 Make Emacs functions such as Fatom 'static' by default.
11250 This makes it easier for human readers (and static analyzers)
11251 to see whether these functions can be called from other modules.
11252 DEFUN now defines a static function. To make the function external
11253 so that it can be used in other C modules, use the new macro DEFUE.
11254 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11255 (Finit_image_library):
11256 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11257 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11258 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11259 Remove decls, since these functions are now static.
11260 (Funintern, Fget_internal_run_time): New decls, since these functions
11261 were already external.
11263 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11264 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11265 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11266 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11267 * keyboard.c, keymap.c, lread.c:
11268 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11269 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11270 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11271 Mark functions with DEFUE instead of DEFUN,
11272 if they are used in other modules.
11273 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11274 decls for now-static functions.
11275 * buffer.h (Fdelete_overlay): Remove decl.
11276 * callproc.c (Fgetenv_internal): Mark as internal.
11277 * composite.c (Fremove_list_of_text_properties): Remove decl.
11278 (Fcomposition_get_gstring): New forward static decl.
11279 * composite.h (Fcomposite_get_gstring): Remove decl.
11280 * dired.c (Ffile_attributes): New forward static decl.
11281 * doc.c (Fdocumntation_property): New forward static decl.
11282 * eval.c (Ffetch_bytecode): New forward static decl.
11283 (Funintern): Remove extern decl; now in .h file where it belongs.
11284 * fileio.c (Fmake_symbolic_link): New forward static decl.
11285 * image.c (Finit_image_library): New forward static decl.
11286 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11287 * intervals.h (Fprevious_property_change):
11288 (Fremove_list_of_text_properties): Remove decls.
11289 * keyboard.c (Fthis_command_keys): Remove decl.
11290 (Fcommand_execute): New forward static decl.
11291 * keymap.c (Flookup_key): New forward static decl.
11292 (Fcopy_keymap): Now static.
11293 * keymap.h (Flookup_key): Remove decl.
11294 * process.c (Fget_process): New forward static decl.
11295 (Fprocess_datagram_address): Mark as internal.
11296 * syntax.c (Fsyntax_table_p): New forward static decl.
11297 (skip_chars): Remove duplicate decl.
11298 * textprop.c (Fprevious_property_change): New forward static decl.
11299 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11301 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11302 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11304 * editfns.c (Fformat): Remove unreachable code.
11306 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11308 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11311 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11313 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11314 when at ZV. (Bug#8487)
11316 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11318 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11320 * keyboard.c (parse_tool_bar_item): Likewise.
11321 * sound.c (sound_cleanup, alsa_close): Likewise.
11322 * termcap.c (tgetent): Likewise.
11323 * xfns.c (x_default_font_parameter): Likewise.
11324 * xsettings.c (read_and_apply_settings): Likewise.
11326 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11327 (overrun_check_free): Protoize.
11329 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11331 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11332 since callers should never pass a negative size.
11333 Change the signature to match that of plain 'read' and 'write'; see
11334 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11335 * lisp.h: Update prototypes of emacs_write and emacs_read.
11337 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11339 * xdisp.c (redisplay_window): Don't try to determine the character
11340 position of the scroll margin if the window start point w->startp
11341 is outside the buffer's accessible region. (Bug#8468)
11343 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11345 Fix write-region and its subroutines for buffers > 2GB.
11346 * fileio.c (a_write, e_write): Modify declaration of arguments and
11347 local variables to support buffers larger than 2GB.
11348 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11350 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11351 argument, local variables, and return value.
11353 * lisp.h: Update prototypes of emacs_write and emacs_read.
11355 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11357 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11359 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11361 Fix more problems found by GCC 4.6.0's static checks.
11363 * xdisp.c (vmessage): Use a better test for character truncation.
11365 * charset.c (load_charset_map): <, not <=, for optimization,
11366 and to avoid potential problems with integer overflow.
11367 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11368 * casetab.c (set_identity, shuffle): Likewise.
11369 * editfns.c (Fformat): Likewise.
11370 * syntax.c (skip_chars): Likewise.
11372 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11373 This also lets GCC 4.6.0 generate slightly better loop code.
11375 * callint.c (Fcall_interactively): <, not <=, for optimization.
11376 (Fcall_interactively): Count the number of arguments produced,
11377 not the number of arguments given. This is simpler and lets GCC
11378 4.6.0 generate slightly better code.
11380 * ftfont.c: Distingish more carefully between FcChar8 and char.
11381 The previous code passed unsigned char * to a functions like
11382 strlen and xstrcasecmp that expect char *, which does not
11383 conform to the C standard.
11384 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11385 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11386 char * when the C standard requires it.
11388 * keyboard.c (read_char): Remove unused var.
11390 * eval.c: Port to Windows vsnprintf (Bug#8435).
11391 Include <limits.h>.
11392 (SIZE_MAX): Define if the headers do not.
11393 (verror): Do not give up if vsnprintf returns a negative count.
11394 Instead, grow the buffer. This ports to Windows vsnprintf, which
11395 does not conform to C99. Problem reported by Eli Zaretskii.
11396 Also, simplify the allocation scheme, by avoiding the need for
11397 calling realloc, and removing the ALLOCATED variable.
11399 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11401 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11402 But keep the doprint source code for now, as we might revamp it
11403 and use it again (Bug#8435).
11404 * lisp.h (doprnt): Remove.
11405 * Makefile.in (base_obj): Remove doprnt.o.
11406 * deps.mk (doprnt.o): Remove.
11408 error: Print 32- and 64-bit integers portably (Bug#8435).
11409 Without this change, on typical 64-bit hosts error ("...%d...", N)
11410 was used to print both 32- and 64-bit integers N, which relied on
11411 undefined behavior.
11412 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11413 * lisp.h (error, verror): Mark as printf-like functions.
11414 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11415 Report overflow in size calculations when allocating printf buffer.
11416 Do not truncate output string at its first null byte.
11417 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11418 Truncate the output at a character boundary, since vsnprintf does not
11420 * charset.c (check_iso_charset_parameter): Convert internal
11421 character to string before calling 'error', since %c now has the
11423 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11424 overflow when computing char to be passed to 'error'. Do not
11425 pass Lisp_Object to 'error'; pass the integer instead.
11426 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11427 formatted with plain %d.
11429 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11431 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11433 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11435 * xterm.c (x_catch_errors): Remove duplicate declaration.
11437 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11439 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11441 2011-04-10 Jim Meyering <meyering@redhat.com>
11443 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11444 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11445 return ssize_t not "int", and use size_t as the buffer length.
11446 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11447 * gnutls.h: Update declarations.
11448 * process.c (read_process_output): Use ssize_t, to match.
11449 (send_process): Likewise.
11451 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11453 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11455 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11457 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11458 Use unsigned char, to match FcChar8 type definition.
11460 * xterm.c (handle_one_xevent):
11461 * xmenu.c (create_and_show_popup_menu):
11462 * xselect.c (x_decline_selection_request)
11463 (x_reply_selection_request): Avoid type-punned deref of X events.
11465 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11467 Fix some uses of `int' instead of EMACS_INT.
11468 * search.c (string_match_1, fast_string_match)
11469 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11470 (scan_buffer, find_next_newline_no_quit)
11471 (find_before_next_newline, search_command, Freplace_match)
11472 (Fmatch_data): Make some `int' variables be EMACS_INT.
11474 * xdisp.c (display_count_lines): 3rd argument and return value now
11475 EMACS_INT. All callers changed.
11476 (pint2hrstr): Last argument is now EMACS_INT.
11478 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11479 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11480 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11481 (decode_coding_utf_16, decode_coding_emacs_mule)
11482 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11483 (decode_coding_ccl, decode_coding_charset)
11484 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11485 (decode_coding_iso_2022, decode_coding_emacs_mule)
11486 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11487 <char_offset, last_offset>: Declare EMACS_INT.
11488 (encode_coding_utf_8, encode_coding_utf_16)
11489 (encode_coding_emacs_mule, encode_invocation_designation)
11490 (encode_designation_at_bol, encode_coding_iso_2022)
11491 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11492 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11494 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11495 (encode_invocation_designation): Last argument P_NCHARS is now
11497 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11498 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11500 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11503 * ccl.c (Fccl_execute_on_string): Declare some variables
11506 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11508 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11510 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11512 * process.c (Fformat_network_address): Doc fix.
11514 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11516 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11518 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11520 * keyboard.c (read_char): Call Lisp function help-form-show,
11521 instead of using internal_with_output_to_temp_buffer.
11522 (Qhelp_form_show): New var.
11523 (syms_of_keyboard): Use DEFSYM macro.
11525 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11527 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11529 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11531 * process.c (Flist_processes): Remove to Lisp.
11532 (list_processes_1): Delete.
11534 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11536 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11538 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11540 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11542 Fix more problems found by GCC 4.6.0's static checks.
11544 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11546 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11548 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11550 * xdisp.c (vmessage): Mark as a printf-like function.
11552 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11554 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11556 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11557 printf-like functions.
11558 (tiff_load): Add casts to remove these marks before passing them
11559 to system-supplied API.
11561 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11563 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11564 This avoids several warnings with gcc -Wstrict-overflow.
11565 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11566 directly, rather than having caller test rule sign. This avoids
11567 some unnecessary tests.
11568 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11569 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11570 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11572 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11573 (xfont_open): Avoid unnecessary tests.
11575 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11577 * composite.h, composite.c (composition_gstring_put_cache):
11578 Use EMACS_INT, not int, for length.
11580 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11581 breaking out part of COMPOSITION_DECODE_RULE.
11582 (COMPOSITION_DECODE_RULE): Use it.
11583 * composite.c (get_composition_id): Remove unused local vars,
11584 by using the new macro.
11586 * textprop.c (set_text_properties_1): Change while to do-while,
11587 since the condition is always true at first.
11589 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11590 (interval_deletion_adjustment): Return unsigned value.
11593 * process.c (list_processes_1, create_pty, read_process_output):
11594 (exec_sentinel): Remove vars that were set but not used.
11595 (create_pty): Remove unnecessary "volatile"s.
11596 (Fnetwork_interface_info): Avoid possibility of int overflow.
11597 (read_process_output): Do adaptive read buffering even if carryover.
11598 (read_process_output): Simplify nbytes computation if buffered.
11600 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11602 * syntax.c (scan_words): Remove var that was set but not used.
11603 (update_syntax_table): Use unsigned instead of int.
11605 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11606 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11607 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11609 * print.c (print_error_message): Avoid int overflow.
11611 * font.c (font_list_entities): Redo for clarity,
11612 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11614 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11615 (font_score): Avoid potential overflow in diff calculation.
11617 * fns.c (substring_both): Remove var that is set but not used.
11618 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11620 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11622 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11623 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11624 can always succeed if overflow has undefined behavior.
11626 * search.c (boyer_moore, wordify): Remove vars set but not used.
11627 (wordify): Omit three unnecessary tests.
11629 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11630 All callers changed. This avoids the need for an unused var.
11632 * casefiddle.c (casify_region): Remove var that is set but not used.
11634 * dired.c (file_name_completion): Remove var that is set but not used.
11636 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11638 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11639 (Finsert_file_contents): Remove unnecessary code checking fd.
11641 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11642 Check for integer overflow on size calculations.
11644 * buffer.c (Fprevious_overlay_change): Remove var that is set
11647 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11648 Remove vars that are set but not used.
11649 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11650 (timer_check_2): Mark vars as initialized.
11652 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11654 * image.c (lookup_image): Remove var that is set but not used.
11655 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11657 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11658 that are set but not used.
11660 * xfns.c (make_invisible_cursor): Don't return garbage
11661 if XCreateBitmapFromData fails (Bug#8410).
11663 * xselect.c (x_get_local_selection, x_handle_property_notify):
11664 Remove vars that are set but not used.
11666 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11667 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11669 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11670 Remove var that is set but not used.
11671 (scroll_bar_windows_size): Now size_t, not int.
11672 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11673 Check for overflow.
11675 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11676 (map_tty_color) [!defined MSDOS]: Likewise.
11678 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11680 * coding.c: Remove vars that are set but not used.
11681 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11682 All callers changed.
11683 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11684 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11685 (decode_coding_charset): Remove vars that are set but not used.
11687 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11688 that is set but not used.
11690 * print.c (print_object): Remove var that is set but not used.
11692 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11693 The gnulib version avoids calling malloc in the usual case,
11694 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11695 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11696 * filelock.c (current_lock_owner): Likewise.
11697 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11698 * sysdep.c: Include allocator.h, careadlinkat.h.
11699 (emacs_no_realloc_allocator): New static constant.
11700 (emacs_readlink): New function.
11701 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11702 ../lib/careadlinkat.h.
11704 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11706 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11707 first non-nil return value).
11709 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11711 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11712 if not defined (Bug#8403).
11714 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11716 * xdisp.c (display_count_lines): Remove parameter `start',
11717 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11718 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11719 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11720 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11721 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11722 and thereabouts. All callers changed.
11723 (get_per_char_metric): Remove parameter `f', unused since
11724 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11726 2011-04-02 Jim Meyering <meyering@redhat.com>
11728 do not dereference NULL upon failed strdup
11729 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11730 (ns_get_family): Likewise.
11732 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11734 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11736 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11738 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11741 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11743 Add lexical binding.
11745 * window.c (Ftemp_output_buffer_show): New fun.
11746 (Fsave_window_excursion):
11747 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11749 * lread.c (lisp_file_lexically_bound_p): New function.
11750 (Fload): Bind Qlexical_binding.
11751 (readevalloop): Remove `evalfun' arg.
11752 Bind Qinternal_interpreter_environment.
11753 (Feval_buffer): Bind Qlexical_binding.
11754 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11756 (syms_of_lread): Declare `lexical-binding'.
11758 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11760 * keyboard.c (eval_dyn): New fun.
11761 (menu_item_eval_property): Use it.
11763 * image.c (parse_image_spec): Use Ffunctionp.
11765 * fns.c (concat, mapcar1): Accept byte-code-functions.
11767 * eval.c (Fsetq): Handle lexical vars.
11768 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11769 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11770 (FletX, Flet): Obey lexical binding.
11771 (Fcommandp): Handle closures.
11772 (Feval): New `lexical' arg.
11773 (eval_sub): New function extracted from Feval. Use it almost
11774 everywhere where Feval was used. Look up vars in lexical env.
11776 (Ffunctionp): Move from subr.el.
11777 (Ffuncall): Handle closures.
11778 (apply_lambda): Remove `eval_flags'.
11779 (funcall_lambda): Handle closures and new byte-code-functions.
11780 (Fspecial_variable_p): New function.
11781 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11782 but without exporting it to Lisp.
11784 * doc.c (Fdocumentation, store_function_docstring):
11785 * data.c (Finteractive_form): Handle closures.
11787 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11790 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11792 (exec_byte_code): New function extracted from Fbyte_code to handle new
11793 calling convention for byte-code-functions. Add new byte-codes.
11795 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11797 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11799 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11801 * xdisp.c (redisplay_internal): Fix prototype.
11803 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11805 * xdisp.c (SCROLL_LIMIT): New macro.
11806 (try_scrolling): Use it when setting scroll_limit.
11807 Limit scrolling to 100 screen lines.
11808 (redisplay_window): Even when falling back on "recentering",
11809 position point in the window according to scroll-conservatively,
11810 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11812 (try_scrolling): When point is above the window, allow searching
11813 as far as scroll_max, or one screenful, to compute vertical
11814 distance from PT to the scroll margin position. This prevents
11815 try_scrolling from unnecessarily failing when
11816 scroll-conservatively is set to a value slightly larger than the
11817 window height. Clean up the case of PT below the margin at bottom
11818 of window: scroll_max can no longer be INT_MAX. When aggressive
11819 scrolling is in use, don't let point enter the opposite scroll
11820 margin as result of the scroll.
11821 (syms_of_xdisp) <scroll-conservatively>: Document the
11822 threshold of 100 lines for never-recentering scrolling.
11824 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11826 * dispextern.h (move_it_by_lines):
11827 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11828 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11829 (message_log_check_duplicate): Remove parameters `prev_bol' and
11830 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11831 (redisplay_internal): Remove parameter `preserve_echo_area',
11832 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11834 * indent.c (Fvertical_motion):
11835 * window.c (window_scroll_pixel_based, Frecenter):
11836 Don't pass `need_y_p' to `move_it_by_lines'.
11838 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11840 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11841 steal a few bits to be more compact.
11842 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11843 Remove unneeded casts.
11845 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11847 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11849 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11850 binding" message (bug#7967).
11852 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11854 Fix more problems found by GCC 4.6.0's static checks.
11856 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11857 Remove unused local var.
11859 * editfns.c (Fmessage_box): Remove unused local var.
11861 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11862 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11863 Omit unused local vars.
11864 * window.c (shrink_windows): Omit unused local var.
11865 * menu.c (digest_single_submenu): Omit unused local var.
11866 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11867 Omit unused local var.
11869 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11870 Don't assume string length fits in int.
11871 (keyremap_step, read_key_sequence): Use size_t for sizes.
11872 (read_key_sequence): Don't check last_real_key_start redundantly.
11874 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11875 instead of alloca (Bug#8344).
11877 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11878 (Fbacktrace_frame): Don't assume nframes fits in int.
11880 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11882 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11885 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11887 * cm.c (calccost): Turn while-do into do-while, for clarity.
11889 * keyboard.c (syms_of_keyboard): Use the same style as later
11890 in this function when indexing through an array. This also
11891 works around GCC bug 48267.
11893 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11895 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11897 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11898 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11900 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11901 This avoids undefined behavior on integer overflow, and is a bit
11902 more convenient anyway since it is compared to a size_t variable.
11904 Variadic C functions now count arguments with size_t, not int.
11905 This avoids an unnecessary limitation on 64-bit machines, which
11906 caused (substring ...) to crash on large vectors (Bug#8344).
11907 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11908 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11909 All variadic functions and their callers changed accordingly.
11910 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11911 * data.c (arith_driver, float_arith_driver): Likewise.
11912 * editfns.c (general_insert_function): Likewise.
11913 * eval.c (struct backtrace.nargs, interactive_p)
11914 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11915 (funcall_lambda, mark_backtrace): Likewise.
11916 * fns.c (concat): Likewise.
11917 * frame.c (x_set_frame_parameters): Likewise.
11918 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11919 0 if not found, not -1. All callers changed.
11921 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11922 (stack_copy_size): Now size_t, not int.
11923 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11925 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11927 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11928 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11929 All callers changed.
11931 * lisp.h (multibyte_char_to_unibyte):
11932 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11933 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11934 * character.h (CHAR_TO_BYTE8):
11935 * cmds.c (internal_self_insert):
11936 * editfns.c (general_insert_function):
11937 * keymap.c (push_key_description):
11938 * search.c (Freplace_match):
11939 * xdisp.c (message_dolog, set_message_1): All callers changed.
11941 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11943 * keyboard.c (safe_run_hook_funcall): New function.
11944 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11945 don't set the hook to nil, but remove the offending function instead.
11946 (Qcommand_hook_internal): Remove, unused.
11947 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11948 Vcommand_hook_internal.
11950 * eval.c (enum run_hooks_condition): Remove.
11951 (funcall_nil, funcall_not): New functions.
11952 (run_hook_with_args): Call each function through a `funcall' argument.
11953 Remove `cond' argument, now redundant.
11954 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11955 (Frun_hook_with_args_until_failure): Adjust accordingly.
11956 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11958 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11960 * dispextern.h (string_buffer_position): Remove declaration.
11962 * print.c (strout): Remove parameter `multibyte', unused since
11963 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11965 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11966 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11967 All callers changed.
11969 * w32.c (_wsa_errlist): Use braces for struct initializers.
11971 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11972 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11973 All callers changed.
11974 (string_buffer_position): Likewise. Also, make static (it's never
11975 used outside xdisp.c).
11976 (cursor_row_p): Remove parameter `w', unused since
11977 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11978 (decode_mode_spec): Remove parameter `precision', introduced during
11979 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11980 All callers changed.
11982 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11984 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11986 2011-03-27 Anders Lindgren <andlind@gmail.com>
11988 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11989 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11990 (ns_update_auto_hide_menu_bar): New functions.
11991 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11992 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11993 ns_constrain_all_frames.
11994 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11995 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11997 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11999 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12001 2011-03-27 Glenn Morris <rgm@gnu.org>
12003 * syssignal.h: Replace RETSIGTYPE with void.
12004 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12005 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12006 Replace SIGTYPE with void everywhere.
12007 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12008 * s/template.h (SIGTYPE): Remove commented out definition.
12010 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12012 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12013 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12015 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12017 * w32.c (read_unc_volume): Use parameter `henum', instead of
12018 global variable `wget_enum_handle'.
12020 * keymap.c (describe_vector): Remove parameters `indices' and
12021 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12022 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12024 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12026 * keyboard.c (timer_check): Remove parameter `do_it_now',
12027 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12028 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12029 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12031 * keyboard.c (read_char):
12032 * w32menu.c (w32_menu_display_help):
12033 * xmenu.c (show_help_event, menu_help_callback):
12034 Adjust calls to `show_help_echo'.
12036 * gtkutil.c (xg_maybe_add_timer):
12037 * keyboard.c (readable_events):
12038 * process.c (wait_reading_process_output):
12039 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12041 * insdel.c (adjust_markers_gap_motion):
12042 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12043 (gap_left, gap_right): Don't call it.
12045 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12047 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12048 incurred during fontification.
12050 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12052 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12053 (DEFVAR_PER_BUFFER): Don't pass it.
12055 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12056 (scrolling_window): Don't pass it.
12058 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12060 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12062 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12064 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12065 of variables specific to SELinux and computation of `encoded_absname'.
12067 * image.c (XPutPixel): Remove unused variable `height'.
12069 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12071 * unexw32.c (get_section_info): Remove unused variable `section'.
12073 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12074 (system_process_attributes): Remove unused variable `sess'.
12075 (sys_read): Remove unused variable `err'.
12077 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12078 (w32_wnd_proc): Remove unused variable `isdead'.
12079 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12080 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12081 (x_create_tip_frame): Remove unused variable `tem'.
12083 * w32inevt.c (w32_console_read_socket):
12084 Remove unused variable `no_events'.
12086 * w32term.c (x_draw_composite_glyph_string_foreground):
12087 Remove unused variable `width'.
12089 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12091 * w32term.c (x_set_glyph_string_clipping):
12092 Don't pass uninitialized region to CombineRgn.
12094 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12096 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12097 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12098 (Fx_close_connection): Remove unused variable `i'.
12100 * w32font.c (w32font_draw): Return number of glyphs.
12101 (w32font_open_internal): Remove unused variable `i'.
12102 (w32font_driver): Add missing initializer.
12104 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12105 (fill_in_menu): Remove unused variable `items_added'.
12107 * w32term.c (last_mouse_press_frame): Remove static global variable.
12108 (w32_clip_to_row): Remove unused variable `f'.
12109 (x_delete_terminal): Remove unused variable `i'.
12111 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12112 (NOTHING): Remove unused static global variable.
12113 (uniscribe_check_otf): Remove unused variable `table'.
12114 (uniscribe_font_driver): Add missing initializers.
12116 2011-03-23 Julien Danjou <julien@danjou.info>
12118 * term.c (Fsuspend_tty, Fresume_tty):
12119 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12120 * window.c (temp_output_buffer_show):
12121 * insdel.c (signal_before_change):
12122 * frame.c (Fhandle_switch_frame):
12123 * fileio.c (Fdo_auto_save):
12124 * emacs.c (Fkill_emacs):
12125 * editfns.c (save_excursion_restore):
12126 * cmds.c (internal_self_insert):
12127 * callint.c (Fcall_interactively):
12128 * buffer.c (Fkill_all_local_variables):
12129 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12131 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12132 unconditionally since it does the check itself.
12134 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12136 Fix more problems found by GCC 4.5.2's static checks.
12138 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12139 the first time through the loop, since we know p0 < p1 then.
12140 This also avoids a gcc -Wstrict-overflow warning.
12142 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12143 leading to a memory leak, possible in functions like
12144 load_charset_map_from_file that can allocate an unbounded number
12145 of objects (Bug#8318).
12147 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12148 that could (at least in theory) be that large.
12150 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12151 This is less likely to overflow, and avoids undefined behavior if
12152 overflow does occur. All callers changed. Use strtoul to scan
12153 for the unsigned long integer.
12154 (pint2hrstr): Simplify and tune code slightly.
12155 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12157 * scroll.c (do_scrolling): Work around GCC bug 48228.
12158 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12160 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12161 This also avoids a warning with gcc -Wstrict-overflow.
12162 (validate_x_resource_name): Simplify count usage.
12163 This also avoids a warning with gcc -Wstrict-overflow.
12165 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12168 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12170 * process.c (Fmake_network_process): Use socklen_t, not int,
12171 where POSIX says socklen_t is required in portable programs.
12172 This fixes a porting bug on hosts like 64-bit HP-UX, where
12173 socklen_t is wider than int (Bug#8277).
12174 (Fmake_network_process, server_accept_connection):
12175 (wait_reading_process_output, read_process_output):
12178 * process.c: Rename or move locals to avoid shadowing.
12179 (list_processes_1, Fmake_network_process):
12180 (read_process_output_error_handler, exec_sentinel_error_handler):
12181 Rename or move locals.
12182 (Fmake_network_process): Define label "retry_connect" only if needed.
12183 (Fnetwork_interface_info): Fix pointer signedness.
12184 (process_send_signal): Add cast to avoid pointer signedness problem.
12185 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12186 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12188 Make tparam.h and terminfo.c consistent.
12189 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12190 Include tparam.h instead, since it declares them.
12191 * cm.h (PC): Remove extern decl; tparam.h now does this.
12192 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12193 * terminfo.c: Include tparam.h, to check interfaces.
12194 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12195 (tparam): Adjust signature to match interface in tparam.h;
12196 this removes some undefined behavior. Check that outstring and len
12197 are zero, which they always are with Emacs.
12198 * tparam.h (PC, BC, UP): New extern decls.
12200 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12201 (xftfont_open): Rename locals to avoid shadowing.
12203 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12204 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12205 (OTF_TAG_SYM): Omit macro if not needed.
12206 (ftfont_list): Remove unused local.
12207 (get_adstyle_property, ftfont_pattern_entity):
12208 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12209 Rename locals to avoid shadowing.
12211 * xfont.c (xfont_list_family): Mark var as initialized.
12213 * xml.c (make_dom): Now static.
12215 * composite.c (composition_compute_stop_pos): Rename local to
12217 (composition_reseat_it): Remove unused locals.
12218 (find_automatic_composition, composition_adjust_point): Likewise.
12219 (composition_update_it): Mark var as initialized.
12220 (find_automatic_composition): Mark vars as initialized,
12221 with a FIXME (Bug#8290).
12223 character.h: Rename locals to avoid shadowing.
12224 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12225 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12226 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12227 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12228 to avoid shadowing.
12230 * textprop.c (property_change_between_p): Remove; unused.
12232 * intervals.c (interval_start_pos): Now static.
12234 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12236 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12237 Rename locals to avoid shadowing.
12239 * sound.c (wav_play, au_play, Fplay_sound_internal):
12240 Fix pointer signedness.
12241 (alsa_choose_format): Remove unused local var.
12242 (wav_play): Initialize a variable to 0, to prevent undefined
12243 behavior (Bug#8278).
12245 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12247 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12249 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12250 clobbering (Bug#8298).
12251 * sysdep.c (sys_subshell): Likewise.
12252 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12254 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12255 This should get cleaned up, so that child_setup has the
12256 same signature on all platforms.
12258 * callproc.c (call_process_cleanup): Now static.
12259 (relocate_fd): Rename locals to avoid shadowing.
12261 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12263 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12264 not to be necessary, and produces flickering.
12266 2011-03-20 Glenn Morris <rgm@gnu.org>
12268 * config.in: Remove file.
12270 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12272 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12273 are now in src/globals.h.
12274 (syms_of_minibuf): Remove spurious & from previous change.
12276 2011-03-20 Leo Liu <sdl.web@gmail.com>
12278 * minibuf.c (completing-read-function): New variable.
12279 (completing-read-default): Rename from completing-read.
12280 (completing-read): Call completing-read-function.
12282 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12284 * xfaces.c (Fx_load_color_file):
12285 Read color file from absolute filename (bug#8250).
12287 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12289 * makefile.w32-in: Update dependencies.
12291 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12293 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12295 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12297 Fix more problems found by GCC 4.5.2's static checks.
12299 * process.c (make_serial_process_unwind, send_process_trap):
12300 (sigchld_handler): Now static.
12302 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12303 That way, the code declares only the vars that it needs.
12304 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12305 * s/cygwin.h (PTY_ITERATION): Likewise.
12306 * s/darwin.h (PTY_ITERATION): Likewise.
12307 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12309 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12310 * process.c (allocate_pty): Don't declare stb unless it's needed.
12312 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12313 (CONSTANTLIM): Remove; unused.
12314 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12315 Define only if needed.
12317 * unexelf.c (unexec): Name an expression,
12318 to avoid gcc -Wbad-function-cast warning.
12319 Use a different way to cause a compilation error if anyone uses
12320 n rather than nn, a way that does not involve shadowing.
12321 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12323 * deps.mk (unexalpha.o): Remove; unused.
12325 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12326 * unexec.h: New file.
12327 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12328 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12329 Depend on unexec.h.
12330 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12331 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12332 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12333 Change as necessary to match prototype in unexec.h.
12335 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12337 (back_comment, skip_chars): Mark vars as initialized.
12339 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12340 Rename locals to avoid shadowing.
12342 * lread.c (read1): Rewrite so as not to use empty "else".
12343 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12345 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12347 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12348 warning when compiling print.c.
12350 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12351 instead of using an uninitialized var.
12352 (font_sort_entities): Mark var as initialized.
12354 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12356 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12357 pointers to constants.
12358 (font_parse_fcname): Remove unused vars.
12359 (font_delete_unmatched): Now static.
12360 (font_get_spec): Remove; unused.
12361 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12362 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12363 Rename or move locals to avoid shadowing.
12365 * fns.c (require_nesting_list, require_unwind): Now static.
12366 (Ffillarray): Rename locals to avoid shadowing.
12368 * floatfns.c (domain_error2): Define only if needed.
12369 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12371 * alloc.c (mark_backtrace): Move decl from here ...
12372 * lisp.h: ... to here, so that it can be checked.
12374 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12375 (Fdefvar): Rewrite so as not to use empty "else".
12376 (lisp_indirect_variable): Name an expression,
12377 to avoid gcc -Wbad-function-cast warning.
12378 (Fdefvar): Rename locals to avoid shadowing.
12380 * callint.c (quotify_arg, quotify_args): Now static.
12381 (Fcall_interactively): Rename locals to avoid shadowing.
12382 Use const pointer when appropriate.
12384 * lisp.h (get_system_name, get_operating_system_release):
12385 Move decls here, to check interfaces.
12386 * process.c (get_operating_system_release): Move decl to lisp.h.
12387 * xrdb.c (get_system_name): Likewise.
12388 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12389 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12390 some of which prompt warnings from gcc -Wbad-function-cast.
12391 (Fformat_time_string, Fencode_time, Finsert_char):
12392 (Ftranslate_region_internal, Fformat):
12393 Rename or remove local vars to avoid shadowing.
12394 (Ftranslate_region_internal): Mark var as initialized.
12396 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12399 * lisp.h (eassert): Check that the argument compiles, even if
12400 ENABLE_CHECKING is not defined.
12402 * data.c (Findirect_variable): Name an expression, to avoid
12403 gcc -Wbad-function-cast warning.
12404 (default_value, arithcompare, arith_driver, arith_error): Now static.
12405 (store_symval_forwarding): Rename local to avoid shadowing.
12406 (Fmake_variable_buffer_local, Fmake_local_variable):
12407 Mark variables as initialized.
12408 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12410 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12411 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12412 Rename locals to avoid shadowing.
12413 (mark_stack): Move local variables into the #ifdef region where
12415 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12416 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12418 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12419 (GC_STRING_CHARS): Remove; not used.
12420 (Fmemory_limit): Cast sbrk's returned value to char *.
12422 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12423 avoids undefined behavior in theory.
12425 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12427 Use functions, not macros, for up- and down-casing (Bug#8254).
12428 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12429 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12430 to use the following functions instead of these macros.
12431 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12432 EMACS_INT, since callers assume the returned value fits in int.
12433 (upcase1): Likewise, for UPCASE_TABLE.
12434 (uppercasep, lowercasep, upcase): New static inline functions.
12435 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12436 the race-condition problem in the old DOWNCASE.
12438 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12439 Rename locals to avoid shadowing.
12440 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12441 (regex_compile, re_search_2, re_match_2_internal):
12442 Remove unused local vars.
12443 (FREE_VAR): Rewrite so as not to use empty "else",
12444 which gcc can warn about.
12445 (regex_compile, re_match_2_internal): Mark locals as initialized.
12446 (RETALLOC_IF): Define only if needed.
12447 (WORDCHAR_P): Likewise. This one is never needed, but is used
12448 only in a comment talking about a compiler bug, so put inside
12449 the #if 0 of that comment.
12450 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12451 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12454 * search.c (boyer_moore): Rename locals to avoid shadowing.
12455 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12456 (PREV_CHAR_BOUNDARY): Likewise.
12458 * search.c (simple_search): Remove unused var.
12460 * dired.c (compile_pattern): Move decl from here ...
12461 * lisp.h: ... to here, so that it can be checked.
12462 (struct re_registers): New forward decl.
12464 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12466 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12468 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12469 Rename locals to avoid shadowing.
12470 (Fvertical_motion): Mark locals as initialized.
12472 * casefiddle.c (casify_object, casify_region): Now static.
12473 (casify_region): Mark local as initialized.
12475 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12477 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12478 New macros, so that the caller can use some names other than
12479 gcpro1, gcpro2, etc.
12480 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12482 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12483 argument, for consistency with GCPRO2_VAR, etc: it is now the
12484 prefix of the variable, not the variable itself. All uses
12486 * dired.c (directory_files_internal, file_name_completion):
12487 Rename locals to avoid shadowing.
12489 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12490 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12491 dired.c's scmp function, had undefined behavior.
12492 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12493 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12494 * buffer.h: ... to here, because these macros use current_buffer,
12495 and the new implementation with inline functions needs to have
12496 current_buffer in scope now, rather than later when the macros
12498 (downcase, upcase1): New static inline functions.
12499 (DOWNCASE, UPCASE1): Reimplement using these functions.
12500 This avoids undefined behavior in expressions like
12501 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12502 from race conditions in accessing the global variables
12503 case_temp1 and case_temp2.
12504 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12505 * lisp.h (case_temp1, case_temp2): Remove their decls.
12506 * character.h (ASCII_CHAR_P): Move from here ...
12507 * lisp.h: ... to here, so that the inline functions mentioned
12508 above can use them.
12510 * dired.c (directory_files_internal_unwind): Now static.
12512 * fileio.c (file_name_as_directory, directory_file_name):
12513 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12515 (file_name_as_directory): Use const pointers when appropriate.
12516 (Fexpand_file_name): Likewise. In particular, newdir might
12517 point at constant storage, so make it a const pointer.
12518 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12519 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12521 (Fset_file_times, Finsert_file_contents, auto_save_error):
12522 Rename locals to avoid shadowing.
12524 * minibuf.c (choose_minibuf_frame_1): Now static.
12525 (Ftry_completion, Fall_completions): Rename or remove locals
12526 to avoid shadowing.
12528 * marker.c (bytepos_to_charpos): Remove; unused.
12530 * lisp.h (verify_bytepos, count_markers): New decls,
12531 so that gcc does not warn that these functions aren't declared.
12533 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12534 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12535 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12536 (copy_text): Remove unused local var.
12538 * filelock.c (within_one_second): Now static.
12539 (lock_file_1): Rename local to avoid shadowing.
12541 * buffer.c (fix_overlays_before): Mark locals as initialized.
12542 (fix_start_end_in_overlays): Likewise. This function should be
12543 simplified by using pointers-to-pointers, but that's a different
12545 (switch_to_buffer_1): Now static.
12546 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12547 (report_overlay_modification): Rename locals to avoid shadowing.
12549 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12550 Fix pointer signedness issue.
12551 (sys_subshell): Mark local as volatile if checking for lint,
12552 to suppress a gcc -Wclobbered warning that does not seem to be right.
12553 (MAXPATHLEN): Define only if needed.
12555 * process.c (serial_open, serial_configure): Move decls from here ...
12556 * systty.h: ... to here, so that they can be checked.
12558 * fns.c (get_random, seed_random): Move extern decls from here ...
12559 * lisp.h: ... to here, so that they can be checked.
12561 * sysdep.c (reset_io): Now static.
12562 (wait_for_termination_signal): Remove; unused.
12564 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12565 (copy_keymap_item, append_key, push_text_char_description):
12567 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12568 (DENSE_TABLE_SIZE): Remove; unused.
12569 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12570 (describe_map_tree):
12571 Rename locals to avoid shadowing.
12573 * keyboard.c: Declare functions static if they are not used elsewhere.
12574 (echo_char, echo_dash, cmd_error, top_level_2):
12575 (poll_for_input, handle_async_input): Now static.
12576 (read_char, kbd_buffer_get_event, make_lispy_position):
12577 (make_lispy_event, make_lispy_movement, apply_modifiers):
12578 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12579 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12580 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12581 (read_key_sequence, read_char): Mark locals as initialized.
12582 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12584 * keyboard.h (make_ctrl_char): New decl.
12585 (mark_kboards): Move decl here ...
12586 * alloc.c (mark_kboards): ... from here.
12588 * lisp.h (force_auto_save_soon): New decl.
12590 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12591 (DEFINE_DUMMY_FUNCTION): New macro.
12592 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12594 (main): Add casts to avoid warnings
12595 if GCC considers string literals to be constants.
12597 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12599 * dbusbind.c: Pointer signedness fixes.
12600 (xd_signature, xd_append_arg, xd_initialize):
12601 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12602 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12603 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12604 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12606 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12607 if GCC considers string literals to be constants.
12608 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12610 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12612 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12613 (print_preprocess, print_object): New macro to fix last change.
12615 * print.c (print_preprocess): Don't forget font objects.
12617 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12619 * emacs.c (USAGE3): Doc fixes.
12621 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12623 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12626 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12628 * lisp.h (VWindow_system, Qfile_name_history):
12629 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12630 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12631 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12633 * w32select.c: Don't #include "keyboard.h".
12634 (run_protected): Add extern declaration for waiting_for_input.
12636 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12637 * w32console.c (detect_input_pending, read_input_pending)
12638 (encode_terminal_code):
12639 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12640 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12641 (w32_system_caret_y, Qfile_name_history):
12642 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12643 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12644 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12645 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12646 * w32proc.c (Qlocal, report_file_error):
12647 * w32term.c (Vwindow_system, updating_frame):
12648 * w32uniscribe.c (initialized, uniscribe_font_driver):
12649 Remove unneeded extern declarations.
12651 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12653 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12655 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12657 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12658 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12659 These macros can no longer be used for assignment.
12661 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12662 Assign struct members directly, instead of using BUF_BEGV etc.
12663 (record_buffer_markers, fetch_buffer_markers): New functions for
12664 recording and fetching special buffer markers.
12665 (set_buffer_internal_1, set_buffer_temp): Use them.
12667 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12669 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12671 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12672 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12674 * xdisp.c (hscroll_window_tree):
12675 (reconsider_clip_changes): Use PT instead of BUF_PT.
12677 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12679 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12680 $(EMACS_ROOT)/lib/intprops.h.
12682 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12684 Fix more problems found by GCC 4.5.2's static checks.
12686 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12687 to unsigned char * to avoid compiler diagnostic.
12688 (xg_free_frame_widgets): Make it clear that a local variable is
12689 needed only if USE_GTK_TOOLTIP.
12690 (gdk_window_get_screen): Make it clear that this macro is needed
12691 only if USE_GTK_TOOLTIP.
12692 (int_gtk_range_get_value): New function, which avoids a diagnostic
12693 from gcc -Wbad-function-cast.
12694 (xg_set_toolkit_scroll_bar_thumb): Use it.
12695 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12696 diagnostic from gcc -Wbad-function-cast.
12697 (get_utf8_string, xg_get_file_with_chooser):
12698 Rename locals to avoid shadowing.
12699 (create_dialog): Move locals to avoid shadowing.
12701 * xgselect.c (xg_select): Remove unused var.
12703 * image.c (four_corners_best): Mark locals as initialized.
12704 (gif_load): Initialize transparent_p to zero (Bug#8238).
12705 Mark another local as initialized.
12706 (my_png_error, my_error_exit): Mark with NO_RETURN.
12708 * image.c (clear_image_cache): Now static.
12709 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12710 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12711 (x_edge_detection): Remove unnecessary cast that
12712 gcc -Wbad-function-cast diagnoses.
12713 (gif_load): Fix pointer signedness.
12714 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12715 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12717 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12719 Improve quality of tests for time stamp overflow.
12720 For example, without this patch (encode-time 0 0 0 1 1
12721 1152921504606846976) returns the obviously-bogus value (-948597
12722 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12723 reports time overflow. See
12724 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12725 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12726 * editfns.c: Include limits.h and intprops.h.
12727 (TIME_T_MIN, TIME_T_MAX): New macros.
12728 (time_overflow): Move earlier, to before first use.
12729 (hi_time, lo_time): New functions, for an accurate test for
12730 out-of-range times.
12731 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12732 (Fget_internal_run_time): Don't assume time_t fits in int.
12733 (make_time): Use list2 instead of Fcons twice.
12734 (Fdecode_time): More accurate test for out-of-range times.
12735 (check_tm_member): New function.
12736 (Fencode_time): Use it, to test for out-of-range times.
12737 (lisp_time_argument): Don't rely on undefined left-shift and
12738 right-shift behavior when checking for time stamp overflow.
12740 * editfns.c (time_overflow): New function, refactoring common code.
12741 (Fformat_time_string, Fdecode_time, Fencode_time):
12742 (Fcurrent_time_string): Use it.
12744 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12745 * dired.c (make_time): Move to ...
12746 * editfns.c (make_time): ... here.
12747 * systime.h: Note the move.
12749 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12751 * fringe.c (update_window_fringes): Remove unused variables.
12753 * unexmacosx.c (copy_data_segment): Also copy __got section.
12756 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12758 * termcap.c [MSDOS]: Include "msdos.h".
12759 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12760 Constify `char *' arguments and their references according to
12761 prototypes in tparam.h.
12763 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12765 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12766 Adapt all references accordingly.
12768 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12770 2011-03-11 Tom Tromey <tromey@redhat.com>
12772 * buffer.c (syms_of_buffer): Remove obsolete comment.
12774 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12776 * termhooks.h (encode_terminal_code): Declare prototype.
12778 * msdos.c (encode_terminal_code): Don't declare prototype.
12780 * term.c (encode_terminal_code): Now external again, used by
12781 w32console.c and msdos.c.
12783 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12784 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12786 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12788 Fix some minor problems found by GCC 4.5.2's static checks.
12790 * fringe.c (update_window_fringes): Mark locals as initialized
12792 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12794 * alloc.c (mark_fringe_data): Move decl from here ...
12795 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12796 to check its interface.
12797 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12799 * fontset.c (free_realized_fontset): Now static.
12800 (Fset_fontset_font): Rename local to avoid shadowing.
12801 (fontset_font): Mark local as initialized.
12802 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12804 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12806 * xselect.c (x_disown_buffer_selections): Remove; not used.
12807 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12808 (x_own_selection, Fx_disown_selection_internal): Rename locals
12809 to avoid shadowing.
12810 (x_handle_dnd_message): Remove local to avoid shadowing.
12812 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12813 so that the caller can use some name other than gcpro1.
12814 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12815 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12816 (Fx_backspace_delete_keys_p):
12817 Use them to avoid shadowing, and rename vars to avoid shadowing.
12818 (x_decode_color, x_set_name, x_window): Now static.
12819 (Fx_create_frame): Add braces to silence GCC warning.
12820 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12821 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12822 Remove unused locals.
12823 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12824 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12825 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12828 * xterm.h (x_mouse_leave): New decl.
12830 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12831 Remove unused functions.
12832 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12833 (x_calc_absolute_position): Now static.
12834 (XTread_socket): Don't define label "out" unless it's used.
12835 Don't declare local "event" unless it's used.
12836 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12837 unless they are used.
12838 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12839 (x_fatal_error_signal): Remove; not used.
12840 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12841 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12842 (x_error_catcher, x_connection_closed, x_error_handler):
12843 (x_error_quitter, xembed_send_message, x_iconify_frame):
12844 (my_log_handler): Rename locals to avoid shadowing.
12845 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12846 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12848 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12849 Rename or move locals to avoid shadowing.
12850 (tty_defined_color, merge_face_heights): Now static.
12851 (free_realized_faces_for_fontset): Remove; not used.
12852 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12853 does not deduce is never used uninitialized.
12854 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12855 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12857 * terminal.c (store_terminal_param): Now static.
12859 * xmenu.c (menu_highlight_callback): Now static.
12860 (set_frame_menubar): Remove unused local.
12861 (xmenu_show): Rename parameter to avoid shadowing.
12862 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12863 since they might point to immutable storage.
12864 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12865 since it's unused otherwise.
12867 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12868 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12869 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12870 avoids a gcc -Wuninitialized diagnostic.
12871 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12872 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12873 does not deduce are never used uninitialized.
12875 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12877 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12878 * window.c (window_loop, size_window):
12879 (run_window_configuration_change_hook, enlarge_window): Likewise.
12881 * window.c (display_buffer): Now static.
12882 (size_window): Mark variables that gcc -Wuninitialized
12883 does not deduce are never used uninitialized.
12884 * window.h (check_all_windows): New decl, to forestall
12885 gcc -Wmissing-prototypes diagnostic.
12886 * dispextern.h (bidi_dump_cached_states): Likewise.
12888 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12890 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12891 Include <limits.h>.
12892 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12893 and to avoid gcc -Wuninitialized warning.
12894 (load_charset_map): Mark variables that gcc -Wuninitialized
12895 does not deduce are never used uninitialized.
12896 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12898 * coding.c (coding_set_source, coding_set_destination):
12899 Use "else { /* comment */ }" rather than "else /* comment */;"
12900 for clarity, and to avoid gcc -Wempty-body warning.
12901 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12902 a block, when the outer 'i' will do.
12903 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12904 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12905 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12906 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12907 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12908 Rename locals to avoid shadowing.
12909 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12910 * coding.c (emacs_mule_char, encode_invocation_designation):
12911 Now static, since they're not used elsewhere.
12912 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12913 (decode_coding_object, encode_coding_object, detect_coding_system):
12914 (decode_coding_emacs_mule): Mark variables that gcc
12915 -Wuninitialized does not deduce are never used uninitialized.
12916 (detect_coding_iso_2022): Initialize a local variable that might
12917 be used uninitialized. Leave a FIXME because it's not clear that
12918 this initialization is needed. (Bug#8211)
12919 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12920 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12921 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12922 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12923 Remove unused macros.
12925 * category.c (hash_get_category_set): Remove unused local var.
12926 (copy_category_table): Now static, since it's not used elsewhere.
12927 * character.c (string_count_byte8): Likewise.
12929 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12930 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12932 * chartab.c (copy_sub_char_table): Now static, since it's not used
12934 (sub_char_table_ref_and_range, char_table_ref_and_range):
12935 Rename locals to avoid shadowing.
12936 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12938 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12939 (BIDI_BOB): Remove unused macro.
12941 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12942 deduce are never used uninitialized.
12943 * term.c (encode_terminal_code): Likewise.
12945 * term.c (encode_terminal_code): Now static. Remove unused local.
12947 * tparam.h: New file.
12948 * term.c, tparam.h: Include it.
12949 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12950 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12951 Move these decls to tparam.h, and make them agree with what
12952 is actually in tparam.c. The previous trick of using incompatible
12953 decls in different modules does not conform to the C standard.
12954 All callers of tparam changed to use tparam's actual API.
12955 * tparam.c (tparam1, tparam, tgoto):
12956 Use const pointers where appropriate.
12958 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12959 * cm.h (struct cm): Likewise.
12960 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12961 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12962 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12963 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12964 (turn_on_face, init_tty): Likewise.
12965 * termchar.h (struct tty_display_info): Likewise.
12967 * term.c (term_mouse_position): Rename local to avoid shadowing.
12969 * alloc.c (mark_ttys): Move decl from here ...
12970 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12972 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12974 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12976 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12978 * search.c (compile_pattern_1): Remove argument regp, unused since
12979 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12980 (compile_pattern): Don't pass it.
12982 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12984 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12985 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12987 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12989 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12991 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12992 gdk_window_get_screen, gdk_window_get_geometry,
12993 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12994 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12995 (xg_get_pixbuf_from_pixmap): New function.
12996 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12997 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12998 Call xg_get_pixbuf_from_pixmap instead of
12999 gdk_pixbuf_get_from_drawable.
13000 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13001 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13002 (xg_check_special_colors): Use GtkStyleContext and its functions
13004 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13005 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13006 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13007 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13008 Call gtk_widget_get_preferred_size.
13009 (xg_frame_resized): gdk_window_get_geometry only takes 5
13011 (xg_win_to_widget, xg_event_is_for_menubar):
13012 Call gdk_x11_window_lookup_for_display.
13013 (xg_set_widget_bg): New function.
13014 (delete_cb): New function.
13015 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13016 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13017 (xg_set_background_color): Call xg_set_widget_bg.
13018 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13019 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13020 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13021 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13023 (update_frame_tool_bar): Call gtk_widget_hide.
13024 (xg_initialize): Use GDK_KEY_g.
13026 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13028 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13030 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13031 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13032 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13034 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13036 * w32xfns.c (select_palette): Check success of RealizePalette against
13037 GDI_ERROR, not zero.
13039 See ChangeLog.11 for earlier changes.
13041 ;; Local Variables:
13045 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13047 This file is part of GNU Emacs.
13049 GNU Emacs is free software: you can redistribute it and/or modify
13050 it under the terms of the GNU General Public License as published by
13051 the Free Software Foundation, either version 3 of the License, or
13052 (at your option) any later version.
13054 GNU Emacs is distributed in the hope that it will be useful,
13055 but WITHOUT ANY WARRANTY; without even the implied warranty of
13056 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13057 GNU General Public License for more details.
13059 You should have received a copy of the GNU General Public License
13060 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.