* xml.c (parse_region): Make sure we always return a tree.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * xml.c (parse_region): Make sure we always return a tree.
4
5 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6
7 * xml.c (parse_region): If a document contains only comments,
8 return that, too.
9
10 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
12 * xml.c (make_dom): Return comments, too.
13
14 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
15
16 Port to OpenBSD.
17 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
18 and the surrounding thread.
19 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
20 rather than fgets, and retry after EINTR. Otherwise, 'emacs
21 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
22 timer goes off.
23 * s/openbsd.h (BROKEN_SIGIO): Define.
24 * unexelf.c (unexec) [__OpenBSD__]:
25 Don't update the .mdebug section of the Alpha COFF symbol table.
26
27 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
28
29 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
30 (bug#8460).
31
32 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
33
34 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
35 This fixes some race conditions on the permissions of any newly
36 created file.
37
38 * alloc.c (valid_pointer_p): Use pipe, not open.
39 This fixes some permissions issues when debugging.
40
41 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
42 If fchown fails to set both uid and gid, try to set just gid,
43 as that is sometimes allowed. Adjust the file's mode to eliminate
44 setuid or setgid bits that are inappropriate if fchown fails.
45
46 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
47
48 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
49 to compare Lisp_Objects.
50 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
51 global_gnutls_log_level, don't mistake it for a Lisp_Object.
52 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
53
54 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
55
56 * lread.c (read_integer): Unread even EOF character.
57 (read1): Likewise. Properly record start position of symbol.
58
59 * lread.c (read1): Read `#:' as empty uninterned symbol if no
60 symbol character follows.
61
62 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
63
64 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
65 This works around a problem with the previous change to Fcopy_file.
66 Recent glibc declares fchown with __attribute__((warn_unused_result)),
67 and without this change, GCC might complain about discarding
68 fchown's return value.
69
70 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
71
72 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
73
74 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
75
76 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
77
78 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
79
80 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
81 it's used from the C level.
82
83 * process.c: Use the same condition for POLL_FOR_INPUT in both
84 keyboard.c and process.c (bug#1858).
85
86 2011-07-09 Lawrence Mitchell <wence@gmx.li>
87
88 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
89 (Fgnutls_boot): Use it.
90
91 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
92
93 * doc.c (Fsubstitute_command_keys): Revert last change.
94
95 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
96
97 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
98 quotes the next character, and doesn't affect other longer
99 sequences (bug#8935).
100
101 * lread.c (syms_of_lread): Clarify that is isn't only
102 `eval-buffer' and `eval-defun' that's affected by
103 `lexical-binding' (bug#8460).
104
105 2011-07-15 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
108 bidi redisplay when a line includes both an image and is
109 truncated.
110
111 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
112
113 Fix minor problems found by static checking.
114 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
115 (elsz): Now a signed constant, not a size_t var. We prefer signed
116 types to unsigned, to avoid integer comparison confusion. Without
117 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
118 "cannot optimize loop, the loop counter may overflow", a symptom
119 of the confusion.
120 * indent.c (Fvertical_motion): Mark locals as initialized.
121 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
122
123 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
124
125 * search.c (Fre_search_backward): Mention `case-fold-search' in
126 all the re_search_* functions (bug#8138).
127
128 * keyboard.c (Fopen_dribble_file): Document when the file is
129 closed (bug#8056).
130
131 2011-07-14 Eli Zaretskii <eliz@gnu.org>
132
133 * bidi.c (bidi_dump_cached_states): Fix format of displaying
134 bidi_cache_idx.
135
136 Support bidi reordering of display and overlay strings.
137 * xdisp.c (compute_display_string_pos)
138 (compute_display_string_end): Accept additional argument STRING.
139 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
140 (reseat_to_string): Initialize bidi_it->string.s and
141 bidi_it->string.schars.
142 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
143 NULL (avoids a crash in bidi_paragraph_init). Initialize
144 itb.string.lstring.
145 (init_iterator): Call bidi_init_it only of a valid
146 buffer position was specified. Initialize paragraph_embedding to
147 L2R.
148 (reseat_to_string): Initialize the bidi iterator.
149 (display_string): If we need to ignore text properties of
150 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
151 original value of -1 will not work with bidi.)
152 (compute_display_string_pos): First arg is now struct
153 `text_pos *'; all callers changed. Support display properties on
154 Lisp strings.
155 (compute_display_string_end): Support display properties on Lisp
156 strings.
157 (init_iterator, reseat_1, reseat_to_string): Initialize the
158 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
159 when iterating on a string not from display properties).
160 (compute_display_string_pos, compute_display_string_end): Fix
161 calculation of the object to scan. Fixes an error when using
162 arrow keys.
163 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
164 base_level_stop; instead, set base_level_stop to BEGV. Fixes
165 crashes in vertical-motion.
166 (next_element_from_buffer): Improve commentary for when
167 the iterator is before prev_stop.
168 (init_iterator): Initialize bidi_p from the default value of
169 bidi-display-reordering, not from buffer-local value. Use the
170 buffer-local value only if initializing for buffer iteration.
171 (handle_invisible_prop): Support invisible properties on strings
172 that are being bidi-reordered.
173 (set_iterator_to_next): Support bidi reordering of C strings and
174 Lisp strings.
175 (next_element_from_string): Support bidi reordering of Lisp
176 strings.
177 (handle_stop_backwards): Support Lisp strings as well.
178 (display_string): Support display of R2L glyph rows. Use
179 IT_STRING_CHARPOS when displaying from a Lisp string.
180 (init_iterator): Don't initialize it->bidi_p for strings
181 here.
182 (reseat_to_string): Initialize it->bidi_p for strings here.
183 (next_element_from_string, next_element_from_c_string)
184 (next_element_from_buffer): Add xassert's for correspondence
185 between IT's object being iterated and it->bidi_it.string
186 structure.
187 (face_before_or_after_it_pos): Support bidi iteration.
188 (next_element_from_c_string): Handle the case of the first string
189 character that is not the first one in the visual order.
190 (get_visually_first_element): New function, refactored from common
191 parts of next_element_from_buffer, next_element_from_string, and
192 next_element_from_c_string.
193 (tool_bar_lines_needed, redisplay_tool_bar)
194 (display_menu_bar): Force left-to-right direction. Add a FIXME
195 comment for making that be controlled by a user option.
196 (push_it, pop_it): Save and restore the state of the
197 bidi iterator. Save and restore the bidi_p flag.
198 (pop_it): Iterate out of display property for string iteration as
199 well.
200 (iterate_out_of_display_property): Support iteration over strings.
201 (handle_single_display_spec): Set up it->bidi_it for iteration
202 over a display string, and call bidi_init_it.
203 (handle_single_display_spec, next_overlay_string)
204 (get_overlay_strings_1, push_display_prop): Set up the bidi
205 iterator for displaying display or overlay strings.
206 (forward_to_next_line_start): Don't use the shortcut if
207 bidi-iterating.
208 (back_to_previous_visible_line_start): If handle_display_prop
209 pushed the iterator stack, restore the internal state of the bidi
210 iterator by calling bidi_pop_it same number of times.
211 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
212 and we are bidi-iterating, don't decrement the iterator position;
213 instead, set the first_elt flag in the bidi iterator, to produce
214 the same effect.
215 (reseat_1): Remove redundant setting of string_from_display_prop_p.
216 (push_display_prop): xassert that we are iterating a buffer.
217 (push_it, pop_it): Save and restore paragraph_embedding member.
218 (handle_single_display_spec, next_overlay_string)
219 (get_overlay_strings_1, reseat_1, reseat_to_string)
220 (push_display_prop): Set up the `unibyte' member of bidi_it.string
221 correctly. Don't assume unibyte strings are not bidi-reordered.
222 (compute_display_string_pos)
223 (compute_display_string_end): Fix handling the case of C string.
224 (push_it, pop_it): Save and restore from_disp_prop_p.
225 (handle_single_display_spec, push_display_prop): Set the
226 from_disp_prop_p flag.
227 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
228 (pop_it): Call iterate_out_of_display_property only if we are
229 popping after iteration over a string that came from a display
230 property. Fix a typo in popping stretch info. Add an assertion
231 for verifying that the iterator position is in sync with the bidi
232 iterator.
233 (handle_single_display_spec, get_overlay_strings_1)
234 (push_display_prop): Fix initialization of paragraph direction for
235 string when that of the parent object is not yet determined.
236 (reseat_1): Call bidi_init_it to resync the bidi
237 iterator with IT's position. (Bug#7616)
238 (find_row_edges): If ROW->start.pos gives position
239 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
240 (handle_stop, back_to_previous_visible_line_start, reseat_1):
241 Reset the from_disp_prop_p flag.
242 (SAVE_IT, RESTORE_IT): New macros.
243 (pos_visible_p, face_before_or_after_it_pos)
244 (back_to_previous_visible_line_start)
245 (move_it_in_display_line_to, move_it_in_display_line)
246 (move_it_to, move_it_vertically_backward, move_it_by_lines)
247 (try_scrolling, redisplay_window, display_line): Use them when
248 saving a temporary copy of the iterator and restoring it back.
249 (back_to_previous_visible_line_start, reseat_1)
250 (init_iterator): Empty the bidi cache "stack".
251 (move_it_in_display_line_to): If iterator ended up at
252 EOL, but we never saw any buffer positions smaller than
253 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
254 motion in bidi-reordered lines.
255 (move_it_in_display_line_to): Record prev_method and prev_pos
256 immediately before the call to set_iterator_to_next. Fixes cursor
257 motion in bidi-reordered lines with stretch glyphs and strings
258 displayed in margins. (Bug#8133) (Bug#8867)
259 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
260 TO_CHARPOS.
261 (pos_visible_p): Support positions in bidi-reordered lines. Save
262 and restore bidi cache.
263
264 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
265 (bidi_paragraph_info): Delete unused struct.
266 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
267 (bidi_cache_start): New variable.
268 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
269 to zero.
270 (bidi_cache_fetch_state, bidi_cache_search)
271 (bidi_cache_find_level_change, bidi_cache_iterator_state)
272 (bidi_cache_find, bidi_peek_at_next_level)
273 (bidi_level_of_next_char, bidi_find_other_level_edge)
274 (bidi_move_to_visually_next): Compare cache index with
275 bidi_cache_start rather than with zero.
276 (bidi_fetch_char): Accept new argument STRING; all callers
277 changed. Support iteration over a string. Support strings with
278 display properties. Support unibyte strings. Fix the type of
279 `len' according to what STRING_CHAR_AND_LENGTH expects.
280 (bidi_paragraph_init, bidi_resolve_explicit_1)
281 (bidi_resolve_explicit, bidi_resolve_weak)
282 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
283 iteration over a string.
284 (bidi_set_sor_type, bidi_resolve_explicit_1)
285 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
286 can now be zero (for strings); special values 0 and -1 were
287 changed to -1 and -2, respectively.
288 (bidi_char_at_pos): New function.
289 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
290 Call it instead of FETCH_MULTIBYTE_CHAR.
291 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
292 initialized to valid values.
293 (bidi_init_it): Don't initialize charpos and bytepos with invalid
294 values.
295 (bidi_level_of_next_char): Allow the sentinel "position" to pass
296 the test for valid cached positions. Fix the logic for looking up
297 the sentinel state in the cache. GCPRO the Lisp string we are
298 iterating.
299 (bidi_push_it, bidi_pop_it): New functions.
300 (bidi_initialize): Initialize the bidi cache start stack pointer.
301 (bidi_cache_ensure_space): New function, refactored from part of
302 bidi_cache_iterator_state. Don't assume the required size is just
303 one BIDI_CACHE_CHUNK away.
304 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
305 (bidi_count_bytes, bidi_char_at_pos): New functions.
306 (bidi_cache_search): Don't assume bidi_cache_last_idx is
307 always valid if bidi_cache_idx is valid.
308 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
309 is valid if it's going to be used.
310 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
311 (bidi_cache_fetch_state, bidi_cache_search)
312 (bidi_cache_find_level_change, bidi_cache_ensure_space)
313 (bidi_cache_iterator_state, bidi_cache_find)
314 (bidi_find_other_level_edge, bidi_cache_start_stack): All
315 variables related to cache indices are now EMACS_INT.
316
317 * dispextern.h (struct bidi_string_data): New structure.
318 (struct bidi_it): New member `string'. Make flag members be 1-bit
319 fields, and put them last in the struct.
320 (compute_display_string_pos, compute_display_string_end): Update
321 prototypes.
322 (bidi_push_it, bidi_pop_it): Add prototypes.
323 (struct iterator_stack_entry): New members bidi_p,
324 paragraph_embedding, and from_disp_prop_p.
325 (struct it): Member bidi_p is now a bit field 1 bit wide.
326 (bidi_shelve_cache, bidi_unshelve_cache): Declare
327 prototypes.
328
329 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
330 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
331 and vector-like objects.
332
333 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
334 cache around display iteration.
335
336 * window.c (Fwindow_end, window_scroll_pixel_based)
337 (displayed_window_lines, Frecenter): Save and restore the bidi
338 cache around display iteration.
339
340 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
341
342 * editfns.c (Fdelete_region): Clarify the use of the named
343 parameters (bug#6788).
344
345 2011-07-14 Martin Rudalics <rudalics@gmx.at>
346
347 * indent.c (Fvertical_motion): Set and restore w->pointm when
348 saving and restoring the window's buffer (Bug#9006).
349
350 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
351
352 * editfns.c (Fstring_to_char): Clarify just what is returned
353 (bug#6576). Text by Eli Zaretskii.
354
355 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
356
357 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
358
359 2011-07-13 Eli Zaretskii <eliz@gnu.org>
360
361 * buffer.c (mmap_find): Fix a typo.
362
363 2011-07-13 Johan Bockgård <bojohan@gnu.org>
364
365 Fix execution of x selection hooks.
366 * xselect.c (Qx_lost_selection_functions)
367 (Qx_sent_selection_functions): New vars.
368 (syms_of_xselect): DEFSYM them.
369 (x_handle_selection_request): Pass Qx_sent_selection_functions
370 rather than Vx_sent_selection_functions to Frun_hook_with_args.
371 (x_handle_selection_clear,x_clear_frame_selections):
372 Pass Qx_lost_selection_functions rather than
373 Vx_lost_selection_functions to Frun_hook_with_args.
374
375 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
376
377 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
378 The old code sometimes used this field without initializing it.
379
380 * alloc.c (gc_sweep): Don't read past end of array.
381 In theory, the old code could also have corrupted Emacs internals,
382 though it'd be very unlikely.
383
384 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
385
386 * character.c (Fcharacterp): Don't advertise optional ignored
387 argument. (Bug#4026)
388
389 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
390
391 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
392 key" (bug#4257).
393
394 * window.c (Fset_window_start): Doc fix (bug#4199).
395 (Fset_window_hscroll): Ditto.
396
397 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
398
399 Fix minor new problems caught by GCC 4.6.1.
400 * term.c (init_tty): Remove unused local.
401 * xsettings.c (store_monospaced_changed): Define this function only
402 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
403 not used otherwise.
404
405 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
406
407 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
408
409 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
410
411 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
412 are the mini-buffer and the echo area (bug#3320).
413
414 * term.c (init_tty): Remove support for supdup, c10 and perq
415 terminals, which are no longer supported (bug#1482).
416
417 2011-07-10 Johan Bockgård <bojohan@gnu.org>
418
419 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
420
421 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
422
423 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
424 for non-popups (Bug#3642).
425
426 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
427
428 * alloc.c (reset_malloc_hooks): Protoize.
429 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
430 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
431 * cm.c (losecursor): Likewise.
432 * data.c (fmod): Likewise.
433 * dispnew.c (swap_glyphs_in_rows): Likewise.
434 * emacs.c (memory_warning_signal): Likewise.
435 * floatfns.c (float_error): Likewise.
436 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
437 (otf_open, font_otf_capability, generate_otf_features)
438 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
439 Likewise.
440 * image.c (pbm_read_file): Likewise.
441 * indent.c (string_display_width): Likewise.
442 * intervals.c (check_for_interval, search_for_interval)
443 (inc_interval_count, count_intervals, root_interval)
444 (adjust_intervals_for_insertion, make_new_interval): Likewise.
445 * lread.c (defalias): Likewise.
446 * ralloc.c (r_alloc_check): Likewise.
447 * regex.c (set_image_of_range_1, set_image_of_range)
448 (regex_grow_registers): Likewise.
449 * sysdep.c (strerror): Likewise.
450 * termcap.c (valid_filename_p, tprint, main): Likewise.
451 * tparam.c (main): Likewise.
452 * unexhp9k800.c (run_time_remap, save_data_space)
453 (update_file_ptrs, read_header, write_header, calculate_checksum)
454 (copy_file, copy_rest, display_header): Likewise.
455 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
456 Likewise.
457 * xdisp.c (check_it): Likewise.
458 * xfaces.c (register_color, unregister_color, unregister_colors):
459 Likewise.
460 * xfns.c (print_fontset_result): Likewise.
461 * xrdb.c (member, fatal, main): Likewise.
462
463 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
464
465 Fix minor problems found by static checking (Bug#9031).
466 * chartab.c (char_table_set_range, map_sub_char_table):
467 Remove unused locals.
468 (uniprop_table): Now static.
469 * composite.c (_work_char): Remove unused static var.
470
471 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
472
473 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
474
475 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
476
477 * gtkutil.c (qttip_cb): Remove code without function.
478
479 2011-07-09 Eli Zaretskii <eliz@gnu.org>
480
481 * w32.c (pthread_sigmask): New stub.
482
483 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
484
485 Use pthread_sigmask, not sigprocmask (Bug#9010).
486 sigprocmask is portable only for single-threaded applications, and
487 Emacs can be multi-threaded when it uses GTK.
488 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
489 (LIBES): Use it.
490 * callproc.c (Fcall_process):
491 * process.c (create_process):
492 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
493 Use pthread_sigmask, not sigprocmask.
494
495 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
496
497 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
498 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
499 wrong (Bug#8591).
500
501 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
502
503 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
504 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
505 (xg_hide_tooltip): Fix comment.
506
507 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
508 in registerServicesMenuSendTypes.
509 (validRequestorForSendType): Don't check ns_return_types.
510
511 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
512 ns_return_type.
513
514 2011-07-08 Jason Rumney <jasonr@gnu.org>
515
516 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
517 frame struct members of non-existent frames (Bug#6284).
518
519 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
520
521 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
522 variable firstTime not needed on OSX >= 10.6.
523 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
524 >= 10.5. Use setKnobProportion, setDoubleValue.
525
526 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
527 (MAC_OS_X_VERSION_10_5): Define if not defined.
528 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
529 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
530 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
531
532 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
533 cString and lossyCString on OSX >= 10.4
534
535 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
536 sizeToFit on OSX >= 10.2.
537
538 * nsimage.m (allocInitFromFile): Don't use deprecated method
539 bestRepresentationForDevice on OSX >= 10.6.
540
541 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
542 to avoid warning.
543
544 * emacs.c: Declare unexec_init_emacs_zone.
545
546 * nsgui.h: Fix compiler warning about gnulib redefining verify.
547
548 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
549
550 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
551 on svcsMenu (Bug#8842).
552
553 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
554 ns_return_types.
555 (Fns_list_services): Just return Qnil on 10.6, code not working there.
556
557 * nsterm.m (QUTF8_STRING): Declare.
558 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
559 (validRequestorForSendType): Return type is (id).
560 Change indexOfObjectIdenticalTo to indexOfObject.
561 Check if we have local selection before returning self (Bug#8842).
562 (writeSelectionToPasteboard): Put local selection into paste board
563 if we have a local selection (Bug#8842).
564 (syms_of_nsterm): DEFSYM QUTF8_STRING.
565
566 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
567 (ns_get_local_selection): Declare.
568
569 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
570
571 * keymap.c (describe_map_tree): Don't insert a double newline at
572 the end of the buffer (bug#1169) and return whether we inserted
573 something.
574
575 * callint.c (Fcall_interactively): Change "reading args" to
576 "providing args" to try to clarify what it does (bug#1010).
577
578 2011-07-07 Kenichi Handa <handa@m17n.org>
579
580 * composite.c (composition_compute_stop_pos): Ignore a static
581 composition starting before CHARPOS (Bug#8915).
582
583 * xdisp.c (handle_composition_prop): Likewise.
584
585 2011-07-07 Eli Zaretskii <eliz@gnu.org>
586
587 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
588 (Bug#9015)
589
590 2011-07-07 Kenichi Handa <handa@m17n.org>
591
592 * character.h (unicode_category_t): New enum type.
593
594 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
595 (Qchar_code_property_table): New variable.
596 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
597 (UNIPROP_COMPRESSED_FORM_P): New macros.
598 (char_table_ascii): Uncompress the compressed values.
599 (sub_char_table_ref): New arg is_uniprop. Callers changed.
600 Uncompress the compressed values.
601 (sub_char_table_ref_and_range): Likewise.
602 (char_table_ref_and_range): Uncompress the compressed values.
603 (sub_char_table_set): New arg is_uniprop. Callers changed.
604 Uncompress the compressed values.
605 (sub_char_table_set_range): Args changed. Callers changed.
606 (char_table_set_range): Adjuted for the above change.
607 (map_sub_char_table): Delete args default_val and parent. Add arg
608 top. Give decoded values to a Lisp function.
609 (map_char_table): Adjusted for the above change. Give decoded
610 values to a Lisp function. Gcpro more variables.
611 (uniprop_table_uncompress)
612 (uniprop_decode_value_run_length): New functions.
613 (uniprop_decoder, uniprop_decoder_count): New variables.
614 (uniprop_get_decoder, uniprop_encode_value_character)
615 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
616 New functions.
617 (uniprop_encoder, uniprop_encoder_count): New variables.
618 (uniprop_get_encoder, uniprop_table)
619 (Funicode_property_table_internal, Fget_unicode_property_internal)
620 (Fput_unicode_property_internal): New functions.
621 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
622 Sunicode_property_table_internal, Sget_unicode_property_internal,
623 and Sput_unicode_property_internal. Defvar_lisp
624 char-code-property-alist.
625
626 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
627 Vunicode_category_table.
628
629 * font.c (font_range): Adjusted for the change of
630 Vunicode_category_table.
631
632 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
633
634 * m/iris4d.h: Remove file, move contents ...
635 * s/irix6-5.h: ... here.
636
637 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
638
639 Remove unportable assumption about struct layout (Bug#8884).
640 * alloc.c (mark_buffer):
641 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
642 (clone_per_buffer_values): Don't assume that
643 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
644 This isn't true in general, and it's particularly not true
645 if Emacs is configured with --with-wide-int.
646 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
647 New macros, used in the buffer.c change.
648
649 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
650
651 * xsettings.c: Use both GConf and GSettings if both are available.
652 (store_config_changed_event): Add comment.
653 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
654 (store_tool_bar_style_changed): New functions.
655 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
656 (struct xsettings): Move font inside HAVE_XFT.
657 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
658 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
659 Move inside HAVE_XFT.
660 (something_changed_gsettingsCB): Renamed from something_changedCB.
661 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
662 also.
663 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
664 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
665 (something_changed_gconfCB): Renamed from something_changedCB.
666 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
667 (parse_settings): Move check for font inside HAVE_XFT.
668 (read_settings, apply_xft_settings): Add comment.
669 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
670 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
671 call store_font_name_changed.
672 (xft_settings_event): Add comment.
673 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
674 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
675 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
676 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
677 (xsettings_initialize): Call init_gsettings last.
678 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
679 comment.
680
681 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
682
683 Random fixes. E.g., (random) never returned negative values.
684 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
685 subseconds part to the entropy, as that's a bit more random.
686 Prefer signed to unsigned, since the signedness doesn't matter and
687 in general we prefer signed. When given a limit, use a
688 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
689 latter isn't right if USE_2_TAGS_FOR_INTS.
690 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
691 not 0..VALMASK. Don't discard "excess" bits that random () returns.
692
693 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
694
695 * textprop.c (text_property_stickiness):
696 Obey Vtext_property_default_nonsticky.
697 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
698 * w32fns.c (syms_of_w32fns):
699 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
700
701 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
702
703 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
704 This is more efficient than Ffile_directory_p and avoids a minor race.
705
706 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
707
708 * buffer.c (Foverlay_put): Say what the return value is
709 (bug#7835).
710
711 * fileio.c (barf_or_query_if_file_exists): Check first if the file
712 is a directory before asking whether to use the file name
713 (bug#7564).
714 (barf_or_query_if_file_exists): Make the "File is a directory"
715 error be more correct.
716
717 * fns.c (Frequire): Remove the mention of the .gz files, since
718 that's installation-specific, but keep the mention of
719 `get-load-suffixes'.
720
721 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
722
723 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
724 Report string overflow if the output is too long.
725
726 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
727
728 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
729 (syms_of_gnutls): Remove duplicate DEFSYM for
730 Qgnutls_bootprop_verify_hostname_error, an error for
731 Qgnutls_bootprop_verify_error (which is no longer used).
732
733 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
734 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
735 Also (re)move comments that are misplaced or no longer relevant.
736
737 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
738
739 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
740
741 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
742
743 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
744 and background color parameters if they have been changed.
745
746 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
747
748 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
749
750 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
751
752 * xsettings.c (SYSTEM_FONT): Define only when used.
753 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
754
755 * keymap.c (access_keymap_1): Now static.
756
757 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
758
759 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
760 leave any prefix arg for the up event (Bug#1586).
761
762 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
764 * lread.c (syms_of_lread): Mention single symbols defined by
765 `defvar' or `defconst' (bug#7154).
766
767 * fns.c (Frequire): Mention .el.gz files (bug#7314).
768 (Frequire): Mention get-load-suffixes.
769
770 2011-07-02 Martin Rudalics <rudalics@gmx.at>
771
772 * window.h (window): Remove clone_number slot.
773 * window.c (Fwindow_clone_number, Fset_window_clone_number):
774 Remove.
775 (make_parent_window, make_window, saved_window)
776 (Fset_window_configuration, save_window_save): Don't deal with
777 clone numbers.
778 * buffer.c (Qclone_number): Remove declaration.
779 (sort_overlays, overlay_strings): Don't deal with clone numbers.
780
781 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
782
783 Add multiple inheritance to keymaps.
784 * keymap.c (Fmake_composed_keymap): New function.
785 (Fset_keymap_parent): Simplify.
786 (fix_submap_inheritance): Remove.
787 (access_keymap_1): New function extracted from access_keymap to handle
788 embedded parents and handle lists of maps.
789 (access_keymap): Use it.
790 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
791 (Fcopy_keymap): Handle embedded parents.
792 (Fcommand_remapping, define_as_prefix): Simplify.
793 (Fkey_binding): Simplify.
794 (syms_of_keymap): Move minibuffer-local-completion-map,
795 minibuffer-local-filename-completion-map,
796 minibuffer-local-must-match-map, and
797 minibuffer-local-filename-must-match-map to Elisp.
798 (syms_of_keymap): Defsubr make-composed-keymap.
799 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
800 (parse_menu_item): Trivial simplification.
801
802 2011-07-01 Glenn Morris <rgm@gnu.org>
803
804 * Makefile.in (SETTINGS_LIBS): Fix typo.
805
806 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
807
808 * coding.c (Fencode_coding_string): Record the last coding system
809 used, as the function doc string says (bug#8738).
810
811 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
812
813 * xsettings.c (store_monospaced_changed): Take new font as arg and
814 check for change against current_mono_font.
815 (EMACS_TYPE_SETTINGS): Remove this and related defines.
816 (emacs_settings_constructor, emacs_settings_get_property)
817 (emacs_settings_set_property, emacs_settings_class_init)
818 (emacs_settings_init, gsettings_obj): Remove.
819 (something_changedCB): New function for HAVE_GSETTINGS.
820 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
821 with value as argument.
822 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
823 g_settings_new (Bug#8967). Do not create gsettings_obj.
824 Remove calls to g_settings_bind. Connect something_changedCB to
825 "changed".
826
827 * xgselect.c: Add defined (HAVE_GSETTINGS).
828 (xgselect_initialize): Ditto.
829
830 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
831 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
832 xg_select.
833
834 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
835
836 * eval.c (struct backtrace): Simplify and port the data structure.
837 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
838 signed bit field, as this assumption is not portable and it makes
839 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
840 "char debug_on_exit : 1" as this is not portable either; instead,
841 use the portable "unsigned int debug_on_exit : 1". Remove unused
842 member evalargs. Remove obsolete comments about cc bombing out.
843
844 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
845
846 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
847 Let HAVE_GSETTINGS override HAVE_GCONF.
848 (store_monospaced_changed): New function.
849 (EMACS_SETTINGS): A new type derived from GObject to handle
850 GSettings notifications.
851 (emacs_settings_constructor, emacs_settings_get_property)
852 (emacs_settings_set_property, emacs_settings_class_init):
853 New functions.
854 (gsettings_client, gsettings_obj): New variables.
855 (GSETTINGS_SCHEMA): New define.
856 (something_changedCB): Call store_monospaced_changed.
857 (init_gsettings): New function.
858 (xsettings_initialize): Call init_gsettings.
859 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
860 to NULL.
861
862 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
863 GCONF_CFLAGS/LIBS.
864
865 2011-06-29 Martin Rudalics <rudalics@gmx.at>
866
867 * window.c (resize_root_window, grow_mini_window)
868 (shrink_mini_window): Rename Qresize_root_window to
869 Qwindow_resize_root_window and Qresize_root_window_vertically to
870 Qwindow_resize_root_window_vertically.
871
872 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
873
874 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
875
876 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
877
878 * makefile.w32-in: Redesign dependencies so they reflect more
879 clearly which files are directly included by each source file,
880 and not through other includes.
881
882 2011-06-27 Martin Rudalics <rudalics@gmx.at>
883
884 * buffer.c (Qclone_number): Declare static and DEFSYM it.
885 (sort_overlays, overlay_strings): When an overlay's clone number
886 matches the window's clone number process the overlay even if
887 the overlay's window property doesn't match the current window.
888
889 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
890 (Fwindow_hchild): Rename to Fwindow_left_child.
891 (Fwindow_next): Rename to Fwindow_next_sibling.
892 (Fwindow_prev): Rename to Fwindow_prev_sibling.
893 (resize_window_check): Rename to window_resize_check.
894 (resize_window_apply): Rename to window_resize_apply.
895 (Fresize_window_apply): Rename to Fwindow_resize_apply.
896 (Fdelete_other_windows_internal, resize_frame_windows)
897 (Fsplit_window_internal, Fdelete_window_internal)
898 (grow_mini_window, shrink_mini_window)
899 (Fresize_mini_window_internal): Fix callers accordingly.
900
901 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
902
903 * emacsgtkfixed.h: State that this is only used with Gtk+3.
904 (emacs_fixed_set_min_size): Remove.
905 (emacs_fixed_new): Take frame as argument.
906
907 * emacsgtkfixed.c: State that this is only used with Gtk+3.
908 (_EmacsFixedPrivate): Remove minwidth/height.
909 Add struct frame *f.
910 (emacs_fixed_init): Initialize priv->f.
911 (get_parent_class, emacs_fixed_set_min_size): Remove.
912 (emacs_fixed_new): Set priv->f to argument.
913 (emacs_fixed_get_preferred_width)
914 (emacs_fixed_get_preferred_height): Use min_width/height from
915 frames size_hint to set minimum and natural (Bug#8919).
916 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
917 and use min_width/height from frames size_hint to set
918 min_width/height (Bug#8919).
919
920 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
921 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
922 Fix indentation.
923
924 2011-06-26 Eli Zaretskii <eliz@gnu.org>
925
926 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
927 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
928 called at ZV.
929
930 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
931
932 * process.c (wait_reading_process_output): Bypass select if
933 waiting for a cell while ignoring keyboard input, and input is
934 pending. Suggested by Jan Djärv (Bug#8869).
935
936 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
937
938 Use gnulib's dup2 module instead of rolling our own.
939 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
940
941 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
942
943 * dispnew.c (scrolling_window): Before scrolling, turn off a
944 mouse-highlight in the window being scrolled.
945
946 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
947
948 Move DEFSYM to lisp.h and use everywhere.
949
950 * character.h (DEFSYM): Move declaration...
951 * lisp.h (DEFSYM): ...here.
952
953 * gnutls.c:
954 * minibuf.c:
955 * w32menu.c:
956 * w32proc.c:
957 * w32select.c: Don't include character.h.
958
959 * alloc.c (syms_of_alloc):
960 * buffer.c (syms_of_buffer):
961 * bytecode.c (syms_of_bytecode):
962 * callint.c (syms_of_callint):
963 * casefiddle.c (syms_of_casefiddle):
964 * casetab.c (init_casetab_once):
965 * category.c (init_category_once, syms_of_category):
966 * ccl.c (syms_of_ccl):
967 * cmds.c (syms_of_cmds):
968 * composite.c (syms_of_composite):
969 * dbusbind.c (syms_of_dbusbind):
970 * dired.c (syms_of_dired):
971 * dispnew.c (syms_of_display):
972 * doc.c (syms_of_doc):
973 * editfns.c (syms_of_editfns):
974 * emacs.c (syms_of_emacs):
975 * eval.c (syms_of_eval):
976 * fileio.c (syms_of_fileio):
977 * fns.c (syms_of_fns):
978 * frame.c (syms_of_frame):
979 * fringe.c (syms_of_fringe):
980 * insdel.c (syms_of_insdel):
981 * keymap.c (syms_of_keymap):
982 * lread.c (init_obarray, syms_of_lread):
983 * macros.c (syms_of_macros):
984 * msdos.c (syms_of_msdos):
985 * print.c (syms_of_print):
986 * process.c (syms_of_process):
987 * search.c (syms_of_search):
988 * sound.c (syms_of_sound):
989 * syntax.c (init_syntax_once, syms_of_syntax):
990 * terminal.c (syms_of_terminal):
991 * textprop.c (syms_of_textprop):
992 * undo.c (syms_of_undo):
993 * w32.c (globals_of_w32):
994 * window.c (syms_of_window):
995 * xdisp.c (syms_of_xdisp):
996 * xfaces.c (syms_of_xfaces):
997 * xfns.c (syms_of_xfns):
998 * xmenu.c (syms_of_xmenu):
999 * xsettings.c (syms_of_xsettings):
1000 * xterm.c (syms_of_xterm): Use DEFSYM.
1001
1002 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1003
1004 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1005
1006 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Integer and buffer overflow fixes (Bug#8873).
1009
1010 * print.c (printchar, strout): Check for string overflow.
1011 (PRINTPREPARE, printchar, strout):
1012 Don't set size unless allocation succeeds.
1013
1014 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1015 for sizes. Check for string overflow more accurately.
1016 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1017
1018 * macros.c: Integer and buffer overflow fixes.
1019 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1020 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1021 Use ptrdiff_t, not int, for sizes.
1022 Don't increment bufsize until after realloc succeeds.
1023 Check for size-calculation overflow.
1024 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1025
1026 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1027
1028 * lread.c: Integer overflow fixes.
1029 (read_integer): Radix is now EMACS_INT, not int,
1030 to improve quality of diagnostics for out-of-range radices.
1031 Calculate buffer size correctly for out-of-range radices.
1032 (read1): Check for integer overflow in radices, and in
1033 read-circle numbers.
1034 (read_escape): Avoid int overflow.
1035 (Fload, openp, read_buffer_size, read1)
1036 (substitute_object_recurse, read_vector, read_list, map_obarray):
1037 Use ptrdiff_t, not int, for sizes.
1038 (read1): Use EMACS_INT, not int, for sizes.
1039 Check for size overflow.
1040
1041 * image.c (cache_image): Check for size arithmetic overflow.
1042
1043 * lread.c: Integer overflow issues.
1044 (saved_doc_string_size, saved_doc_string_length)
1045 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1046 Now ptrdiff_t, not int.
1047 (read1): Don't assume doc string length fits in int. Check for
1048 out-of-range doc string lengths.
1049 (read_list): Don't assume file position fits in int.
1050 (read_escape): Check for hex character overflow.
1051
1052 2011-06-22 Leo Liu <sdl.web@gmail.com>
1053
1054 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1055 Move to minibuffer.el.
1056
1057 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1060 The following patches are for when GLYPH_DEBUG && !XASSERT.
1061 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1062 * dispnew.c (flush_stdout):
1063 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1064 Mark as externally visible.
1065 * dispnew.c (check_window_matrix_pointers): Now static.
1066 * dispnew.c (window_to_frame_vpos):
1067 * xfns.c (unwind_create_frame):
1068 * xterm.c (x_check_font): Remove unused local.
1069 * scroll.c (CHECK_BOUNDS):
1070 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1071 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1072 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1073 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1074 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1075 Now static.
1076 (debug_method_add): Use va_list and vsprintf rather than relying
1077 on undefined behavior with wrong number of arguments.
1078 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1079 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1080 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1081 since we're not interested in debugging glyphs with old libraries.
1082 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1083 GCC 4.6.0's static checking.
1084
1085 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1086
1087 Integer overflow and signedness fixes (Bug#8873).
1088 A few related buffer overrun fixes, too.
1089
1090 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1091
1092 * dispextern.h (struct face.stipple):
1093 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1094 (x_bitmap_mask, x_allocate_bitmap_record)
1095 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1096 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1097 (x_create_bitmap_from_xpm_data):
1098 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1099 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1100 (.bitmaps_last):
1101 * xfaces.c (load_pixmap):
1102 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1103 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1104 (.bitmaps_last, struct x_output.icon_bitmap):
1105 Use ptrdiff_t, not int, for bitmap indexes.
1106 (x_allocate_bitmap_record): Check for size overflow.
1107 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1108
1109 Use ptrdiff_t, not int, for overlay counts.
1110 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1111 * editfns.c (overlays_around, get_pos_property):
1112 * textprop.c (get_char_property_and_overlay):
1113 * xdisp.c (next_overlay_change, note_mouse_highlight):
1114 * xfaces.c (face_at_buffer_position):
1115 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1116 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1117 (Fnext_overlay_change, Fprevious_overlay_change)
1118 (mouse_face_overlay_overlaps, Foverlays_in):
1119 Use ptrdiff_t, not int, for sizes.
1120 (overlays_at, overlays_in): Check for size-calculation overflow.
1121
1122 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1123
1124 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1125 (x_session_initialize): Do not assume string length fits in int.
1126
1127 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1128 This is unlikely, but can occur if DPI is outlandish.
1129
1130 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1131 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1132
1133 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1134 * xrdb.c (magic_file_p, search_magic_path):
1135 Omit last arg SUFFIX; it was always 0. All callers changed.
1136 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1137
1138 * xfont.c (xfont_match): Avoid need for strlen.
1139
1140 * xfns.c: Don't assume strlen fits in int.
1141 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1142
1143 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1144 not unsigned long, as we prefer signed integers. All callers changed.
1145 Detect integer overflow in repeat count.
1146 (message_dolog): Don't assume print length fits in 39 bytes.
1147 (display_mode_element): Don't assume strlen fits in int.
1148
1149 * termcap.c: Don't assume sizes fit in int and never overflow.
1150 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1151 (gobble_line): Check for size-calculation overflow.
1152
1153 * minibuf.c (Fread_buffer):
1154 * lread.c (intern, intern_c_string):
1155 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1156 Don't assume string length fits in int.
1157
1158 * keyboard.c (parse_tool_bar_item):
1159 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1160
1161 * font.c: Don't assume string length fits in int.
1162 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1163 Use ptrdiff_t, not int.
1164 (font_intern_prop): Don't assume string length fits in int.
1165 Don't assume integer property fits in fixnum.
1166 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1167
1168 * filelock.c: Fix some buffer overrun and integer overflow issues.
1169 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1170 Reformulate so as not to need the command string.
1171 Invoke gzip -cd rather than gunzip, as it's more portable.
1172 (lock_info_type, lock_file_1, lock_file):
1173 Don't assume pid_t and time_t fit in unsigned long.
1174 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1175 (current_lock_owner): Prefer signed type for sizes.
1176 Use memcpy, not strncpy, where memcpy is what is really wanted.
1177 Don't assume (via atoi) that time_t and pid_t fit in int.
1178 Check for time_t and/or pid_t out of range, e.g., via a network share.
1179 Don't alloca where an auto var works fine.
1180
1181 * fileio.c: Fix some integer overflow issues.
1182 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1183 Don't assume string length fits in int.
1184 (directory_file_name): Don't assume string length fits in long.
1185 (make_temp_name): Don't assume pid fits in int, or that its print
1186 length is less than 20.
1187
1188 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1189
1190 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1191
1192 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1193
1194 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1195 We prefer signed integers, even for size calculations.
1196
1197 * emacs.c: Don't assume string length fits in 'int'.
1198 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1199 (main): Don't invoke strlen when not needed.
1200
1201 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1202 (XD_DEBUG_MESSAGE): Don't waste a byte.
1203
1204 * callproc.c (getenv_internal_1, getenv_internal)
1205 (Fgetenv_internal):
1206 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1207
1208 * lread.c (invalid_syntax): Omit length argument.
1209 All uses changed. This doesn't fix a bug, but it simplifies the
1210 code away from its former Hollerith-constant appearance, and it's
1211 one less 'int' to worry about when looking at integer-overflow issues.
1212 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1213
1214 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1215 This didn't break anything, but it didn't help either.
1216 It's confusing to put a bogus integer in a place where the actual
1217 value does not matter.
1218 (LIST_END_P): Remove unused macro and its bogus comment.
1219 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1220
1221 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1222 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1223 implementation.
1224 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1225 We prefer signed types, and the value cannot exceed the EMACS_INT
1226 range anyway (because otherwise the length would not be representable).
1227 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1228 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1229 This avoids a GCC warning when WIDE_EMACS_INT.
1230
1231 * indent.c (sane_tab_width): New function.
1232 (current_column, scan_for_column, Findent_to, position_indentation)
1233 (compute_motion): Use it. This is just for clarity.
1234 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1235
1236 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1237
1238 * lisp.h (lint_assume): New macro.
1239 * composite.c (composition_gstring_put_cache):
1240 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1241
1242 * editfns.c, insdel.c:
1243 Omit unnecessary forward decls, to simplify future changes.
1244
1245 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1246
1247 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1248
1249 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1250 Use much-faster test for byte-length change.
1251 Don't assume string byte-length fits in 'int'.
1252 Check that character arg fits in 'int'.
1253 (mapcar1): Declare byte as byte, for clarity.
1254
1255 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1256
1257 * fns.c (concat): Catch string overflow earlier.
1258 Do not rely on integer wraparound.
1259
1260 * dispextern.h (struct it.overlay_strings_charpos)
1261 (struct it.selective): Now EMACS_INT, not int.
1262 * xdisp.c (forward_to_next_line_start)
1263 (back_to_previous_visible_line_start)
1264 (reseat_at_next_visible_line_start, next_element_from_buffer):
1265 Don't arbitrarily truncate the value of 'selective' to int.
1266
1267 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1268
1269 * composite.c: Don't truncate sizes to 'int'.
1270 (composition_gstring_p, composition_reseat_it)
1271 (composition_adjust_point): Use EMACS_INT, not int.
1272 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1273 not EMACS_UINT, for indexes.
1274
1275 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1276
1277 * buffer.c: Include <verify.h>.
1278 (struct sortvec.priority, struct sortstr.priority):
1279 Now EMACS_INT, not int.
1280 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1281 (struct sortstr.size, record_overlay_string)
1282 (struct sortstrlist.size, struct sortlist.used):
1283 Don't truncate size to int.
1284 (record_overlay_string): Check for size-calculation overflow.
1285 (init_buffer_once): Check at compile-time, not run-time.
1286
1287 2011-06-22 Jim Meyering <meyering@redhat.com>
1288
1289 Don't leak an XBM-image-sized buffer
1290 * image.c (xbm_load): Free the image buffer after using it.
1291
1292 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Port to Sun C.
1295 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1296 that Sun C diagnosed.
1297 * fns.c (secure_hash): Fix pointer signedness issue.
1298 * intervals.c (static_offset_intervals): New function.
1299 (offset_intervals): Use it.
1300
1301 2011-06-21 Leo Liu <sdl.web@gmail.com>
1302
1303 * deps.mk (fns.o):
1304 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1305 sha512.h.
1306
1307 * fns.c (secure_hash): Rename from crypto_hash_function and change
1308 the first arg to accept symbols.
1309 (Fsecure_hash): New primitive.
1310 (syms_of_fns): New symbols.
1311
1312 2011-06-20 Deniz Dogan <deniz@dogan.se>
1313
1314 * process.c (Fset_process_buffer): Clarify return value in
1315 docstring.
1316
1317 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1318
1319 * dispnew.c (add_window_display_history): Use BVAR.
1320
1321 * xdisp.c (debug_method_add): Use BVAR.
1322 (check_window_end, dump_glyph_matrix, dump_glyph)
1323 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1324
1325 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1326 Likewise.
1327
1328 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1329 check till after the cache is created in init_frame_faces.
1330
1331 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1332
1333 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1334
1335 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1336
1337 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1338 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1339 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1340
1341 Improve buffer-overflow checking (Bug#8873).
1342 * fileio.c (Finsert_file_contents):
1343 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1344 Remove the old (too-loose) buffer overflow checks.
1345 They weren't needed, since make_gap checks for buffer overflow.
1346 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1347 The old code merely checked for Emacs fixnum overflow, and relied
1348 on undefined (wraparound) behavior. The new code avoids undefined
1349 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1350
1351 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1352 Tune. Don't use wider integers than needed. Don't use alloca.
1353 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1354
1355 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1356
1357 * insdel.c, lisp.h (buffer_overflow): New function.
1358 (insert_from_buffer_1, replace_range, replace_range_2):
1359 * insdel.c (make_gap_larger):
1360 * editfns.c (Finsert_char):
1361 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1362
1363 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1364
1365 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 Integer overflow and signedness fixes (Bug#8873).
1368
1369 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1370 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1371
1372 * fileio.c: Don't assume EMACS_INT fits in off_t.
1373 (emacs_lseek): New static function.
1374 (Finsert_file_contents, Fwrite_region): Use it.
1375 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1376
1377 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1378
1379 * fns.c: Don't overflow int when computing a list length.
1380 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1381 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1382 truncation on 64-bit hosts. Check for QUIT every
1383 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1384 faster and is responsive enough.
1385 (Flength): Report an error instead of overflowing an integer.
1386 (Fsafe_length): Return a float if the value is not representable
1387 as a fixnum. This shouldn't happen except in contrived situations.
1388 (Fnthcdr, Fsort): Don't assume list length fits in int.
1389 (Fcopy_sequence): Don't assume vector length fits in int.
1390
1391 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1392 (header_size, word_size): New constants.
1393 (allocate_vectorlike): Don't check size overflow here.
1394 (allocate_vector): Check it here instead, since this is the only
1395 caller of allocate_vectorlike that could cause overflow.
1396 Check that the new vector's length is representable as a fixnum.
1397
1398 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1399 The previous code was bogus. For example, next_almost_prime (32)
1400 returned 39, which is undesirable as it is a multiple of 3; and
1401 next_almost_prime (24) returned 25, which is a multiple of 5 so
1402 why was the code bothering to check for multiples of 7?
1403
1404 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1405
1406 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1407
1408 Variadic C functions now count arguments with ptrdiff_t.
1409 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1410 Back then I didn't know that the Emacs coding style prefers signed int.
1411 Also, in the meantime I found a few more instances where arguments
1412 were being counted with int, which may truncate counts on 64-bit
1413 machines, or EMACS_INT, which may be unnecessarily wide.
1414 * lisp.h (struct Lisp_Subr.function.aMANY)
1415 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1416 Arg counts are now ptrdiff_t, not size_t.
1417 All variadic functions and their callers changed accordingly.
1418 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1419 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1420 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1421 * callint.c (Fcall_interactively): Check arg count for overflow,
1422 to avoid potential buffer overrun. Use signed char, not 'int',
1423 for 'varies' array, so that we needn't bother to check its size
1424 calculation for overflow.
1425 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1426 * eval.c (apply_lambda):
1427 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1428 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1429 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1430
1431 * callint.c (Fcall_interactively): Don't use index var as event count.
1432
1433 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1434 * mem-limits.h (SIZE): Remove; no longer used.
1435
1436 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1437
1438 Remove unnecessary casts.
1439 * xterm.c (x_term_init):
1440 * xfns.c (x_set_border_pixel):
1441 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1442 These aren't needed now that we assume ANSI C.
1443
1444 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1445 It's more likely to cause problems (due to unsigned overflow)
1446 than to cure them.
1447
1448 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1449
1450 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1451
1452 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1453
1454 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1455
1456 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1457
1458 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1459
1460 GLYPH_CODE_FACE returns EMACS_INT, not int.
1461 * dispextern.h (merge_faces):
1462 * xfaces.c (merge_faces):
1463 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1464 Don't assume EMACS_INT fits in int.
1465
1466 * character.h (CHAR_VALID_P): Remove unused parameter.
1467 * fontset.c, lisp.h, xdisp.c: All uses changed.
1468
1469 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1470
1471 * fns.c (concat): Minor tuning based on overflow analysis.
1472 This doesn't fix any bugs. Use int to hold character, instead
1473 of constantly refetching from Emacs object. Use XFASTINT, not
1474 XINT, for value known to be a character. Don't bother comparing
1475 a single byte to 0400, as it's always less.
1476
1477 * floatfns.c (Fexpt):
1478 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1479
1480 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1481 for characters.
1482
1483 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1484
1485 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1486 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1487 incorrectly succeed when S was a string, because 4294967386 was
1488 truncated before it was used.
1489
1490 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1491 Otherwise, an out-of-range integer could cause undefined behavior
1492 on a 64-bit host.
1493
1494 * composite.c: Use int, not EMACS_INT, for characters.
1495 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1496 EMACS_INT, for values that are known to be in character range.
1497 This doesn't fix any bugs but is the usual style inside Emacs and
1498 may generate better code on 32-bit machines.
1499
1500 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1501 This is for reasons similar to the recent CHAR_STRING fix.
1502 * charset.c (Fencode_char): Check that character arg is actually
1503 a character. Pass an int to ENCODE_CHAR.
1504 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1505 wider than 'int', as a compile-time check to prevent future regressions
1506 in this area.
1507
1508 * character.c (char_string): Remove unnecessary casts.
1509
1510 Make sure a 64-bit char is never passed to CHAR_STRING.
1511 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1512 by silently ignoring the top 32 bits, allowing some values
1513 that were far too large to be valid characters.
1514 * character.h: Include <verify.h>.
1515 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1516 arguments are no wider than unsigned, as a compile-time check
1517 to prevent future regressions in this area.
1518 * data.c (Faset):
1519 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1520 (Fsubst_char_in_region):
1521 * fns.c (concat):
1522 * xdisp.c (decode_mode_spec_coding):
1523 Adjust to CHAR_STRING's new requirement.
1524 * editfns.c (Finsert_char, Fsubst_char_in_region):
1525 * fns.c (concat): Check that character args are actually
1526 characters. Without this test, these functions did the wrong
1527 thing with wildly out-of-range values on 64-bit hosts.
1528
1529 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1530 These casts should not be needed on 32-bit hosts, either.
1531 * keyboard.c (read_char):
1532 * lread.c (Fload): Remove casts to unsigned.
1533
1534 * lisp.h (UNSIGNED_CMP): New macro.
1535 This fixes comparison bugs on 64-bit hosts.
1536 (ASCII_CHAR_P): Use it.
1537 * casefiddle.c (casify_object):
1538 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1539 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1540 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1541 * dispextern.h (FACE_FROM_ID):
1542 * keyboard.c (read_char): Use UNSIGNED_CMP.
1543
1544 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1545 not to EMACS_INT, to avoid GCC warning.
1546
1547 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1548
1549 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1550 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1551 isn't needed on 32-bit machines.
1552
1553 * buffer.c (Fgenerate_new_buffer_name):
1554 Use EMACS_INT for count, not int.
1555 (advance_to_char_boundary): Return EMACS_INT, not int.
1556
1557 * data.c (Qcompiled_function): Now static.
1558
1559 * window.c (window_body_lines): Now static.
1560
1561 * image.c (gif_load): Rename local to avoid shadowing.
1562
1563 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1564 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1565 * alloc.c (make_save_value): Integer argument is now of type
1566 ptrdiff_t, not int.
1567 (mark_object): Use ptrdiff_t, not int.
1568 * lisp.h (pD): New macro.
1569 * print.c (print_object): Use it.
1570
1571 * alloc.c: Use EMACS_INT, not int, to count objects.
1572 (total_conses, total_markers, total_symbols, total_vector_size)
1573 (total_free_conses, total_free_markers, total_free_symbols)
1574 (total_free_floats, total_floats, total_free_intervals)
1575 (total_intervals, total_strings, total_free_strings):
1576 Now EMACS_INT, not int. All uses changed.
1577 (Fgarbage_collect): Compute overall total using a double, so that
1578 integer overflow is less likely to be a problem. Check for overflow
1579 when converting back to an integer.
1580 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1581 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1582 These were 'int' variables that could overflow on 64-bit hosts;
1583 they were never used, so remove them instead of repairing them.
1584 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1585 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1586 Previously, this ceilinged at INT_MAX, but that doesn't work on
1587 64-bit machines.
1588 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1589
1590 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1591 (allocate_vectorlike): Check for ptrdiff_t overflow.
1592 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1593 when a (possibly-narrower) signed value would do just as well.
1594 We prefer using signed arithmetic, to avoid comparison confusion.
1595
1596 * alloc.c: Catch some string size overflows that we were missing.
1597 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1598 for convenience in STRING_BYTES_MAX.
1599 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1600 The definition here is exact; the one in lisp.h was approximate.
1601 (allocate_string_data): Check for string overflow. This catches
1602 some instances we weren't catching before. Also, it catches
1603 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1604 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1605 and ptrdiff_t and EMACS_INT are both 64 bits.
1606
1607 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1608 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1609 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1610
1611 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1612
1613 * alloc.c (Fmake_string): Check for out-of-range init.
1614
1615 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1616
1617 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1618
1619 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1620
1621 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1622 xg_get_default_scrollbar_width.
1623
1624 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1625 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1626 (style_changed_cb): Call update_theme_scrollbar_width and call
1627 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1628 all frames (Bug#8505).
1629 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1630 Call gtk_window_set_resizable if HAVE_GTK3.
1631 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1632 and height if HAVE_GTK3 (Bug#8505).
1633 (scroll_bar_width_for_theme): New variable.
1634 (update_theme_scrollbar_width): New function.
1635 (xg_get_default_scrollbar_width): Move code to
1636 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1637 (xg_initialize): Call update_theme_scrollbar_width.
1638
1639 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1640
1641 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1642
1643 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1644
1645 * frame.c (make_frame): Call other_buffer_safely instead of
1646 other_buffer.
1647
1648 * window.c (temp_output_buffer_show): Call display_buffer with
1649 second argument Vtemp_buffer_show_specifiers and reset latter
1650 immediately after the call.
1651 (Vtemp_buffer_show_specifiers): New variable.
1652 (auto_window_vscroll_p, next_screen_context_lines)
1653 (Vscroll_preserve_screen_position): Remove leading asterisks from
1654 doc-strings.
1655
1656 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 Fix minor problems found by GCC 4.6.0 static checking.
1659 * buffer.c (Qclone_number): Remove for now, as it's unused.
1660 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1661 (record_buffer): Remove unused local.
1662 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1663 (set_frame_buffer_list): Remove; unused.
1664 * frame.h (other_visible_frames): Remove decl.
1665 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1666 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1667 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1668 if HAVE_GPM.
1669 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1670 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1671 Define only if HAVE_GPM.
1672 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1673 (update_hints_inhibit): Remove; never set. All uses removed.
1674 * widgetprv.h (emacsFrameClassRec): Remove decl.
1675 * window.c (delete_deletable_window): Now returns void, since it
1676 wasn't returning anything.
1677 (compare_window_configurations): Remove unused locals.
1678 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1679 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1680 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1681 the same widths as pointers. This follows up on the 2011-05-06 patch.
1682 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1683 * xterm.h: Likewise.
1684 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1685
1686 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1687
1688 * makefile.w32-in: Update dependencies.
1689 (LISP_H): Add lib/intprops.h.
1690
1691 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1692
1693 * image.c (gif_load): Add animation frame delay to the metadata.
1694 (syms_of_image): Use DEFSYM. New symbol `delay'.
1695
1696 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1697
1698 * window.c (delete_deletable_window): Re-add.
1699 (Fset_window_configuration): Rewrite to handle dead buffers and
1700 consequently deletable windows.
1701 (window_tree, Fwindow_tree): Remove. Supply functionality in
1702 window.el.
1703 (compare_window_configurations): Simplify code.
1704
1705 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1706
1707 * image.c (imagemagick_load_image): Fix type mismatch.
1708 (Fimagemagick_types): Likewise.
1709
1710 * window.h (replace_buffer_in_windows): Declare.
1711
1712 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1713
1714 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1715 Qclone_number. Remove external declaration of Qdelete_window.
1716 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1717 code.
1718 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1719 Qbuffer_list_update_hook if allowed.
1720 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1721 buffer list implementation.
1722 (other_buffer_safely): New function.
1723 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1724 calls to replace_buffer_in_windows and
1725 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1726 if allowed.
1727 (record_buffer): Inhibit quitting and rewrite using quittable
1728 functions. Run Qbuffer_list_update_hook if allowed.
1729 (Frecord_buffer, Funrecord_buffer): New functions.
1730 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1731 switch-to-buffer to window.el.
1732 (bury-buffer): Move to window.el.
1733 (Vbuffer_list_update_hook): New variable.
1734
1735 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1736 section.
1737
1738 * window.h (resize_frame_windows): Move up in code.
1739 (Fwindow_frame): Remove EXFUN.
1740 (replace_buffer_in_all_windows): Remove prototype.
1741 (replace_buffer_in_windows_safely): Add prototype.
1742
1743 * window.c: Declare Qdelete_window static again. Move down
1744 declaration of select_count.
1745 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1746 (Fother_window): Move to window.el.
1747 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1748 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1749 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1750 window.el.
1751 (replace_buffer_in_windows): Implement by calling
1752 Qreplace_buffer_in_windows.
1753 (replace_buffer_in_all_windows): Remove with some functionality
1754 moved into replace_buffer_in_windows_safely.
1755 (replace_buffer_in_windows_safely): New function.
1756 (select_window_norecord, select_frame_norecord): Move in front
1757 of run_window_configuration_change_hook. Remove now obsolete
1758 declarations.
1759 (Fset_window_buffer): Rewrite doc-string. Call
1760 Qrecord_window_buffer.
1761 (keys_of_window): Move binding for other-window to window.el.
1762
1763 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1764
1765 * dispextern.h (struct image): Replace data member, whose int_val
1766 and ptr_val fields were not used by anything, with a single
1767 lisp_val object.
1768
1769 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1770 (gif_clear_image, gif_load, imagemagick_load_image)
1771 (gs_clear_image, gs_load): Callers changed.
1772
1773 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * buffer.h: Include <time.h>, for time_t.
1776 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1777
1778 Fix minor problems found by static checking.
1779
1780 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1781
1782 Make identifiers static if they are not used in other modules.
1783 * data.c (Qcompiled_function, Qframe, Qvector):
1784 * image.c (QimageMagick, Qsvg):
1785 * minibuf.c (Qmetadata):
1786 * window.c (resize_window_check, resize_root_window): Now static.
1787 * window.h (resize_window_check, resize_root_window): Remove decls.
1788
1789 * window.c (window_deletion_count, delete_deletable_window):
1790 Remove; unused.
1791 (window_body_lines): Now static.
1792 (Fdelete_other_windows_internal): Mark vars as initialized.
1793 Make sure 'resize_failed' is initialized.
1794 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1795 (resize_window_apply): Remove unused local.
1796 * window.h (delete_deletable_window): Remove decl.
1797
1798 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1799 (imagemagick_load_image): Fix pointer signedness problem by changing
1800 last arg from unsigned char * to char *. All uses changed.
1801 Also, fix a local for similar reasons.
1802 Remove unused locals. Remove locals to avoid shadowing.
1803 (fn_rsvg_handle_free): Remove; unused.
1804 (svg_load, svg_load_image): Fix pointer signedness problem.
1805 (imagemagick_load_image): Don't use garbage pointer image_wand.
1806
1807 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1808
1809 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1810
1811 * image.c (gif_load): Fix omitted cast error introduced by
1812 2011-06-06 change.
1813
1814 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1815
1816 * window.h (resize_proportionally, orig_total_lines)
1817 (orig_top_line): Remove from window structure.
1818 (set_window_height, set_window_width, change_window_heights)
1819 (Fdelete_window): Remove prototypes.
1820 (resize_frame_windows): Remove duplicate declaration.
1821
1822 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1823
1824 * window.h (resize_frame_windows, resize_window_check)
1825 (delete_deletable_window, resize_root_window)
1826 (resize_frame_windows): Declare prototypes.
1827
1828 * window.c (resize_window_apply): Make definition be "static" to
1829 match the prototype.
1830
1831 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1832
1833 * window.c: Remove declarations of Qwindow_size_fixed,
1834 window_min_size_1, window_min_size_2, window_min_size,
1835 size_window, window_fixed_size_p, enlarge_window, delete_window.
1836 Remove static from declaration of Qdelete_window, it's
1837 temporarily needed by Fbury_buffer.
1838 (replace_window): Don't assign orig_top_line and
1839 orig_total_lines.
1840 (Fdelete_window, delete_window): Remove. Window deletion is
1841 handled by window.el.
1842 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1843 Fdelete_window calls with calls to Qdelete_window.
1844 (Fdelete_other_windows): Remove. Deleting other windows is
1845 handled by window.el.
1846 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1847 handled in window.el.
1848 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1849 Window minimum sizes are handled in window.el.
1850 (shrink_windows, size_window, set_window_height)
1851 (set_window_width, change_window_heights, window_height)
1852 (window_width, CURBEG, CURSIZE, enlarge_window)
1853 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1854 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1855 handled in window.el.
1856 (make_dummy_parent): Rename to make_parent_window and give it a
1857 second argument horflag.
1858 (make_window): Don't set resize_proportionally any more.
1859 (Fsplit_window): Remove. Windows are split in window.el.
1860 (save_restore_action, save_restore_orig_size)
1861 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1862 Resize mini windows in window.el.
1863 (grow_mini_window, shrink_mini_window): Implement by calling
1864 Qresize_root_window_vertically, resize_window_check and
1865 resize_window_apply.
1866 (saved_window, Fset_window_configuration, save_window_save): Do
1867 not handle orig_top_line, orig_total_lines, and
1868 resize_proportionally.
1869 (window_min_height, window_min_width): Move to window.el.
1870 (keys_of_window): Move bindings for delete-other-windows,
1871 split-window, delete-window and enlarge-window to window.el.
1872
1873 * buffer.c: Temporarily extern Qdelete_window.
1874 (Fbury_buffer): Temporarily call Qdelete_window instead of
1875 Fdelete_window (Fbury_buffer will move to window.el soon).
1876
1877 * frame.c (set_menu_bar_lines_1): Remove code handling
1878 orig_top_line and orig_total_lines.
1879
1880 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1881 set_window_height but set heights directly.
1882 (change_frame_size_1): Use resize_frame_windows.
1883
1884 * xdisp.c (init_xdisp): Don't use set_window_height but set
1885 heights directly.
1886
1887 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1888 resize_frame_windows instead of change_window_heights and run
1889 run_window_configuration_change_hook.
1890
1891 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1892 instead of change_window_heights and run
1893 run_window_configuration_change_hook.
1894
1895 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1896
1897 * window.c (replace_window): Rename second argument REPLACEMENT to
1898 NEW. New third argument SETFLAG. Rewrite.
1899 (delete_window, make_dummy_parent): Call replace_window with
1900 third argument 1.
1901 (window_list_1): Move down in code.
1902 (run_window_configuration_change_hook): Move set_buffer part
1903 before select_frame_norecord part in order to unwind correctly.
1904 Rename count1 to count.
1905 (recombine_windows, delete_deletable_window, resize_root_window)
1906 (Fdelete_other_windows_internal)
1907 (Frun_window_configuration_change_hook, make_parent_window)
1908 (resize_window_check, resize_window_apply, Fresize_window_apply)
1909 (resize_frame_windows, Fsplit_window_internal)
1910 (Fdelete_window_internal, Fresize_mini_window_internal): New
1911 functions.
1912 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1913
1914 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1915
1916 * window.h (window): Add some new members to window structure -
1917 normal_lines, normal_cols, new_total, new_normal, clone_number,
1918 splits, nest, prev_buffers, next_buffers.
1919 (WINDOW_TOTAL_SIZE): Move here from window.c.
1920 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1921
1922 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1923 Remove.
1924 (make_dummy_parent): Set new members of windows structure.
1925 (make_window): Move down in code. Handle new members of window
1926 structure.
1927 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1928 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1929 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1930 (Fset_window_prev_buffers, Fwindow_next_buffers)
1931 (Fset_window_next_buffers, Fset_window_clone_number): New
1932 functions.
1933 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1934 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1935 Doc-string fixes.
1936 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1937 Argument WINDOW can be now internal window too.
1938 (Fwindow_use_time): Move up in code.
1939 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1940 Rewrite doc-string.
1941 (Fset_window_configuration, saved_window)
1942 (Fcurrent_window_configuration, save_window_save): Handle new
1943 members of window structure.
1944 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1945 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1946 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1947 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1948 Qget_mru_window, Qresize_root_window,
1949 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1950 Qauto_buffer_name; staticpro them.
1951
1952 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1953
1954 * window.c (Fwindow_total_size, Fwindow_left_column)
1955 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1956 (Fwindow_list_1): New functions.
1957 (window_box_text_cols): Replace with window_body_cols.
1958 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1959 window_body_cols instead of window_box_text_cols.
1960 (delete_window, Fset_window_configuration): Call
1961 delete_all_subwindows with window as argument.
1962 (delete_all_subwindows): Take a window as argument and not a
1963 structure. Rewrite.
1964 (window_loop): Remove handling of GET_LRU_WINDOW and
1965 GET_LARGEST_WINDOW.
1966 (Fget_lru_window, Fget_largest_window): Move to window.el.
1967
1968 * window.h: Extern window_body_cols instead of
1969 window_box_text_cols. delete_all_subwindows now takes a
1970 Lisp_Object as argument.
1971
1972 * indent.c (compute_motion, Fcompute_motion): Use
1973 window_body_cols instead of window_box_text_cols.
1974
1975 * frame.c (delete_frame): Call delete_all_subwindows with root
1976 window as argument.
1977
1978 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1979
1980 * fns.c (Fputhash): Document return value.
1981
1982 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1983
1984 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1985
1986 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 Cons<->int and similar integer overflow fixes (Bug#8794).
1989
1990 Check for overflow when converting integer to cons and back.
1991 * charset.c (Fdefine_charset_internal, Fdecode_char):
1992 Use cons_to_unsigned to catch overflow.
1993 (Fencode_char): Use INTEGER_TO_CONS.
1994 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1995 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1996 * data.c (long_to_cons, cons_to_long): Remove.
1997 (cons_to_unsigned, cons_to_signed): New functions.
1998 These signal an error for invalid or out-of-range values.
1999 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2000 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2001 * font.c (Ffont_variation_glyphs):
2002 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2003 * lisp.h: Include <intprops.h>.
2004 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2005 (cons_to_signed, cons_to_unsigned): New decls.
2006 (long_to_cons, cons_to_long): Remove decls.
2007 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2008 (Fprimitive_undo): Use CONS_TO_INTEGER.
2009 * xfns.c (Fx_window_property): Likewise.
2010 * xselect.c: Include <limits.h>.
2011 (x_own_selection, selection_data_to_lisp_data):
2012 Use INTEGER_TO_CONS.
2013 (x_handle_selection_request, x_handle_selection_clear)
2014 (x_get_foreign_selection, Fx_disown_selection_internal)
2015 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2016 (lisp_data_to_selection_data): Use cons_to_unsigned.
2017 (x_fill_property_data): Use cons_to_signed.
2018 Report values out of range.
2019
2020 Check for buffer and string overflow more precisely.
2021 * buffer.h (BUF_BYTES_MAX): New macro.
2022 * lisp.h (STRING_BYTES_MAX): New macro.
2023 * alloc.c (Fmake_string):
2024 * character.c (string_escape_byte8):
2025 * coding.c (coding_alloc_by_realloc):
2026 * doprnt.c (doprnt):
2027 * editfns.c (Fformat):
2028 * eval.c (verror):
2029 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2030 since they may not be the same number.
2031 * editfns.c (Finsert_char):
2032 * fileio.c (Finsert_file_contents):
2033 Likewise for BUF_BYTES_MAX.
2034
2035 * image.c: Use ptrdiff_t, not int, for sizes.
2036 (slurp_file): Switch from int to ptrdiff_t.
2037 All uses changed.
2038 (slurp_file): Check that file size fits in both size_t (for
2039 malloc) and ptrdiff_t (for sanity and safety).
2040
2041 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2042 if b->modtime has its maximal value.
2043
2044 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2045
2046 Don't assume time_t can fit into int.
2047 * buffer.h (struct buffer.modtime): Now time_t, not int.
2048 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2049 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2050
2051 Minor fixes for signed vs unsigned integers.
2052 * character.h (MAYBE_UNIFY_CHAR):
2053 * charset.c (maybe_unify_char):
2054 * keyboard.c (read_char, reorder_modifiers):
2055 XINT -> XFASTINT, since the integer must be nonnegative.
2056 * ftfont.c (ftfont_spec_pattern):
2057 * keymap.c (access_keymap, silly_event_symbol_error):
2058 XUINT -> XFASTINT, since the integer must be nonnegative.
2059 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2060 since it makes no difference and we prefer signed.
2061 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2062 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2063 nonnegative.
2064
2065 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2066
2067 * window.h (Fwindow_frame): Declare.
2068
2069 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2072 (SPARE_MEMORY): Always define.
2073 (LARGE_REQUEST): Remove.
2074 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2075
2076 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2077
2078 * lisp.h: Move EXFUNS for Fframe_root_window,
2079 Fframe_first_window and Fset_frame_selected_window to window.h.
2080
2081 * window.h: Move EXFUNS for Fframe_root_window,
2082 Fframe_first_window and Fset_frame_selected_window here from
2083 lisp.h.
2084
2085 * frame.c (Fwindow_frame, Fframe_first_window)
2086 (Fframe_root_window, Fframe_selected_window)
2087 (Fset_frame_selected_window): Move to window.c.
2088 (Factive_minibuffer_window): Move to minibuf.c.
2089 (Fother_visible_frames_p): New function.
2090
2091 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2092
2093 * window.c (decode_window, decode_any_window): Move up in code.
2094 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2095 (inhibit_frame_unsplittable): Remove unused variable.
2096 (Fwindow_buffer): Move up and rewrite doc-string.
2097 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2098 (Fwindow_prev): New functions.
2099 (Fwindow_frame): Move here from frame.c. Accept any window as
2100 argument.
2101 (Fframe_root_window, Fframe_first_window)
2102 (Fframe_selected_window): Move here from frame.c. Accept frame
2103 or arbitrary window as argument. Update doc-strings.
2104 (Fminibuffer_window): Move up in code.
2105 (Fwindow_minibuffer_p): Move up in code and simplify.
2106 (Fset_frame_selected_window): Move here from frame.c.
2107 Marginal rewrite.
2108 (Fselected_window, select_window, Fselect_window): Move up in
2109 code. Minor doc-string fixes.
2110
2111 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2114 Do not assume that spare memory exists; that assumption is valid
2115 only if SYSTEM_MALLOC.
2116 (LARGE_REQUEST): New macro, so that the issue of large requests
2117 is separated from the issue of spare memory.
2118
2119 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2120
2121 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2122 format. (Bug#8806)
2123
2124 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2125
2126 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2127 before statements.
2128
2129 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2130
2131 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2132
2133 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2134
2135 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2136 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2137
2138 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2139
2140 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2141
2142 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2143
2144 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2145 (x_clipboard_manager_save): Add return value.
2146 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2147 New error handlers.
2148 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2149 Obey Vx_select_enable_clipboard_manager. Catch errors in
2150 x_clipboard_manager_save (Bug#8779).
2151 (Vx_select_enable_clipboard_manager): New variable.
2152 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2153
2154 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2155
2156 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2157
2158 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2159
2160 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2161 in the current matrix if keep_current_p is non-zero.
2162
2163 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2164
2165 * bidi.c (bidi_level_of_next_char): Fix last change.
2166
2167 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2168
2169 Support bidi reordering of text covered by display properties.
2170
2171 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2172 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2173 (bidi_cache_search, bidi_cache_iterator_state)
2174 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2175 (bidi_level_of_next_char, bidi_move_to_visually_next):
2176 Support character positions inside a run of characters covered by a
2177 display string.
2178 (bidi_paragraph_init, bidi_resolve_explicit_1)
2179 (bidi_level_of_next_char): Call bidi_fetch_char and
2180 bidi_fetch_char_advance instead of FETCH_CHAR and
2181 FETCH_CHAR_ADVANCE.
2182 (bidi_init_it): Initialize new members.
2183 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2184 definitions.
2185 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2186 instead of using explicit *_CHAR codes.
2187 (bidi_resolve_explicit, bidi_resolve_weak):
2188 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2189 bidirectional text is supported only in multibyte buffers.
2190 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2191 it to initialize the frame_window_p member of struct bidi_it.
2192 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2193 (bidi_resolve_explicit, bidi_resolve_weak)
2194 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2195 bidi_it->nchars is non-positive.
2196 (bidi_level_of_next_char): Don't try to lookup the cache for the
2197 next/previous character if nothing is cached there yet, or if we
2198 were just reseat()'ed to a new position.
2199
2200 * xdisp.c (set_cursor_from_row): Set start and stop points
2201 according to the row's direction when priming the loop that looks
2202 for the glyph on which to display cursor.
2203 (single_display_spec_intangible_p): Function deleted.
2204 (display_prop_intangible_p): Reimplement to call
2205 handle_display_spec instead of single_display_spec_intangible_p.
2206 Accept 3 additional arguments needed by handle_display_spec.
2207 This fixes incorrect cursor motion across display property with complex
2208 values: lists, `(when COND...)' forms, etc.
2209 (single_display_spec_string_p): Support property values that are
2210 lists with the argument STRING its top-level element.
2211 (display_prop_string_p): Fix the condition for processing a
2212 property that is a list to be consistent with handle_display_spec.
2213 (handle_display_spec): New function, refactored from the
2214 last portion of handle_display_prop.
2215 (compute_display_string_pos): Accept additional argument
2216 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2217 value of a `display' property is a "replacing spec".
2218 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2219 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2220 the display property, but just return a value indicating whether
2221 the display property will replace the characters it covers.
2222 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2223 frame_window_p members of struct bidi_it.
2224 (compute_display_string_pos, compute_display_string_end):
2225 New functions.
2226 (push_it): Accept second argument POSITION, where pop_it should
2227 jump to continue iteration.
2228 (reseat_1): Initialize bidi_it.disp_pos.
2229
2230 * keyboard.c (adjust_point_for_property): Adjust the call to
2231 display_prop_intangible_p to its new signature.
2232
2233 * dispextern.h (struct bidi_it): New member frame_window_p.
2234 (bidi_init_it): Update prototypes.
2235 (display_prop_intangible_p): Update prototype.
2236 (compute_display_string_pos, compute_display_string_end):
2237 Declare prototypes.
2238 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2239 EMACS_INT.
2240
2241 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 Malloc failure behavior now depends on size of allocation.
2244 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2245 * lisp.h: Change signatures accordingly.
2246 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2247 All callers changed. (Bug#8762)
2248
2249 * gnutls.c: Use Emacs's memory allocators.
2250 Without this change, the gnutls library would invoke malloc etc.
2251 directly, which causes problems on non-SYNC_INPUT hosts, and which
2252 runs afoul of improving memory_full behavior. (Bug#8761)
2253 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2254 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2255 xfree instead of the default malloc, realloc, free.
2256 (Fgnutls_boot): No need to check for memory allocation failure,
2257 since xmalloc does that for us.
2258
2259 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2260 * category.c (hash_get_category_set):
2261 * ccl.c (ccl_driver):
2262 * charset.c (Fdefine_charset_internal):
2263 * charset.h (struct charset.hash_index):
2264 * composite.c (get_composition_id, gstring_lookup_cache)
2265 (composition_gstring_put_cache):
2266 * composite.h (struct composition.hash_index):
2267 * dispextern.h (struct image.hash):
2268 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2269 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2270 (hashfn_equal, hashfn_user_defined, make_hash_table)
2271 (maybe_resize_hash_table, hash_lookup, hash_put)
2272 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2273 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2274 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2275 * image.c (make_image, search_image_cache, lookup_image)
2276 (xpm_put_color_table_h):
2277 * lisp.h (struct Lisp_Hash_Table):
2278 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2279 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2280 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2281 * alloc.c (allocate_vectorlike):
2282 Check for overflow in vector size calculations.
2283 * ccl.c (ccl_driver):
2284 Check for overflow when converting EMACS_INT to int.
2285 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2286 need to be updated by these changes.
2287 * fns.c (make_hash_table, maybe_resize_hash_table):
2288 Check for integer overflow with large hash tables.
2289 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2290 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2291 (SXHASH_REDUCE): New macro.
2292 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2293 Use it instead of discarding useful hash info with large hash values.
2294 (sxhash_float): New function.
2295 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2296 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2297 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2298 Rewrite to use FIXNUM_BITS, as this simplifies things.
2299 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2300 Adjust signatures to match updated version of code.
2301 (consing_since_gc): Now EMACS_INT, since a single hash table can
2302 use more than INT_MAX bytes.
2303
2304 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2305
2306 Make it possible to build with GCC-4.6+ -O2 -flto.
2307
2308 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2309
2310 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2311
2312 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2313 Call minibuffer-inactive-mode.
2314
2315 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2316
2317 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2318 Update dependencies.
2319
2320 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2321
2322 * data.c (init_data): Remove code for UTS, this system is not
2323 supported anymore.
2324
2325 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2326
2327 Don't force ./temacs to start in terminal mode.
2328
2329 * frame.c (make_initial_frame): Initialize faces in all cases, not
2330 only when CANNOT_DUMP is defined.
2331 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2332
2333 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2334
2335 * dispnew.c (add_window_display_history): Use const for the string
2336 pointer. Remove declaration, not needed.
2337
2338 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Use 'inline', not 'INLINE'.
2341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2342 * alloc.c, fontset.c (INLINE): Remove.
2343 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2344 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2345 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2346 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2347 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2348
2349 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2350
2351 Make it possible to run ./temacs.
2352
2353 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2354 syms_of_callproc does the same thing. Remove test for
2355 "initialized", do it in the caller.
2356 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2357
2358 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2359
2360 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2361 (read_minibuf): Use get_minibuffer.
2362 (syms_of_minibuf): Use DEFSYM.
2363 (Qmetadata): New var.
2364 * data.c (Qbuffer): Don't make it static.
2365 (syms_of_data): Use DEFSYM.
2366
2367 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2370 (CCL_CODE_MIN): New macro.
2371
2372 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2375
2376 * eval.c (Qdebug): Now static.
2377 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2378 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2379 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2380
2381 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2382
2383 * image.c: Various fixes to ImageMagick code comments.
2384 (Fimagemagick_types): Doc fix.
2385
2386 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 Minor fixes prompted by GCC 4.6.0 warnings.
2389
2390 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2391
2392 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2393 (x_clipboard_manager_save_all): Move extern decl to ...
2394 * xterm.h: ... here, so that it can be checked for consistency.
2395
2396 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2397
2398 * xselect.c (x_clipboard_manager_save_frame)
2399 (x_clipboard_manager_save_all): New functions.
2400 (Fx_clipboard_manager_save): Lisp function deleted.
2401
2402 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2403 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2404
2405 * xterm.h: Update prototype.
2406
2407 2011-05-28 William Xu <william.xwl@gmail.com>
2408
2409 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2410 exiting (Bug#8239).
2411
2412 2011-05-28 Jim Meyering <meyering@redhat.com>
2413
2414 Avoid a sign-extension bug in crypto_hash_function.
2415 * fns.c (to_uchar): Define.
2416 (crypto_hash_function): Use it to convert some newly-signed
2417 variables to unsigned, to avoid sign-extension bugs. For example,
2418 without this change, (md5 "truc") would evaluate to
2419 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2420 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2421 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2422
2423 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 Integer overflow fixes.
2426
2427 * dbusbind.c: Serial number integer overflow fixes.
2428 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2429 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2430 to hold a serial number that is too large for a fixnum.
2431 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2432 Check for serial numbers out of range. Decode any serial number
2433 that was so large that it became a float. (Bug#8722)
2434
2435 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2436 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2437 Use XFASTINT rather than XUINT when numbers are nonnegative.
2438 (xd_append_arg, Fdbus_method_return_internal):
2439 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2440 arguments, check that Lisp number is nonnegative, rather than
2441 silently wrapping negative numbers around. (Bug#8722)
2442 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2443 (Bug#8722)
2444
2445 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2446
2447 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2448
2449 ccl: add integer overflow checks
2450 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2451 (IN_INT_RANGE): New macros.
2452 (ccl_driver): Use them to check for integer overflow when
2453 decoding a CCL program. Many of the new checks are whether XINT (x)
2454 fits in int; it doesn't always, on 64-bit hosts. The new version
2455 doesn't catch all possible integer overflows, but it's an
2456 improvement. (Bug#8719)
2457
2458 * alloc.c (make_event_array): Use XINT, not XUINT.
2459 There's no need for unsigned here.
2460
2461 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2462 This follows up to the 2011-05-06 change that substituted uintptr_t
2463 for EMACS_INT. This case wasn't caught back then.
2464
2465 Rework Fformat to avoid integer overflow issues.
2466 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2467 now (part of C89). Include <verify.h>.
2468 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2469 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2470 (Fformat): Avoid the prepass trying to compute sizes; it was only
2471 approximate and thus did not catch overflow reliably. Instead, walk
2472 through the format just once, formatting and computing sizes as we go,
2473 checking for integer overflow at every step, and allocating a larger
2474 buffer as needed. Keep track separately whether the format is
2475 multibyte. Keep only the most-recently calculated precision, rather
2476 than them all. Record whether each argument has been converted to
2477 string. Use EMACS_INT, not int, for byte and char and arg counts.
2478 Support field widths and precisions larger than INT_MAX. Avoid
2479 sprintf's undefined behavior with conversion specifications such as %#d
2480 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2481 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2482 formatting out-of-range floating point numbers with int
2483 formats. (Bug#8668)
2484
2485 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2486
2487 * data.c: Avoid integer truncation in expressions involving floats.
2488 * data.c: Include <intprops.h>.
2489 (arith_driver): When there's an integer overflow in an expression
2490 involving floating point, convert the integers to floating point
2491 so that the resulting value does not suffer from catastrophic
2492 integer truncation. For example, on a 64-bit host (* 4
2493 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2494 Do not rely on undefined behavior after integer overflow.
2495
2496 merge count_size_as_multibyte, parse_str_to_multibyte
2497 * character.c, character.h (count_size_as_multibyte):
2498 Rename from parse_str_to_multibyte; all uses changed.
2499 Check for integer overflow.
2500 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2501 since it's now a duplicate of the other. This is more of
2502 a character than a buffer op, so better that it's in character.c.
2503 * fns.c, print.c: Adjust to above changes.
2504
2505 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2506
2507 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2508
2509 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2512 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2513 (x_clipboard_manager_save): Now static.
2514 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2515
2516 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2517 (crypto_hash_function): Now static.
2518 Fix pointer signedness problems. Avoid unnecessary initializations.
2519
2520 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2521
2522 * termhooks.h (Vselection_alist): Make it terminal-local.
2523
2524 * terminal.c (create_terminal): Initialize it.
2525
2526 * xselect.c: Support for clipboard managers.
2527 (Vselection_alist): Move to termhooks.h as terminal-local var.
2528 (LOCAL_SELECTION): New macro.
2529 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2530 (symbol_to_x_atom): Remove gratuitous arg.
2531 (x_handle_selection_request, lisp_data_to_selection_data)
2532 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2533 (x_own_selection, x_get_local_selection, x_convert_selection):
2534 New arg, specifying work frame. Use terminal-local Vselection_alist.
2535 (some_frame_on_display): Delete unused function.
2536 (Fx_own_selection_internal, Fx_get_selection_internal)
2537 (Fx_disown_selection_internal, Fx_selection_owner_p)
2538 (Fx_selection_exists_p): New optional frame arg.
2539 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2540 (x_handle_selection_clear): Don't treat other terminals with the
2541 same keyboard specially. Use the terminal-local Vselection_alist.
2542 (x_clear_frame_selections): Use Frun_hook_with_args.
2543
2544 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2545
2546 * xterm.h: Add support for those atoms.
2547
2548 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2549
2550 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2551 (converted_selections, conversion_fail_tag): New global variables.
2552 (x_selection_request_lisp_error): Free the above.
2553 (x_get_local_selection): Remove unnecessary code.
2554 (x_reply_selection_request): Args changed; handle arbitrary array
2555 of converted selections stored in converted_selections.
2556 Separate the XChangeProperty and SelectionNotify steps.
2557 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2558 (x_convert_selection): New function.
2559 (x_handle_selection_event): Simplify.
2560 (x_get_foreign_selection): Don't ignore incoming requests while
2561 waiting for an answer; this will fail when we implement
2562 SAVE_TARGETS, and seems unnecessary anyway.
2563 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2564 (Vx_sent_selection_functions): Doc fix.
2565
2566 2011-05-26 Leo Liu <sdl.web@gmail.com>
2567
2568 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2569
2570 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2571
2572 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2573
2574 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2575 for fringe update if it has periodic bitmap.
2576 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2577 and fringe_bitmap_periodic_p.
2578
2579 * fringe.c (get_fringe_bitmap_data): New function.
2580 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2581 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2582 row. Mark glyph row for fringe update if periodicity changed.
2583
2584 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2585 for fringe update unless it has periodic bitmap.
2586
2587 2011-05-25 Kenichi Handa <handa@m17n.org>
2588
2589 * xdisp.c (get_next_display_element): Set correct it->face_id for
2590 a static composition.
2591
2592 2011-05-24 Leo Liu <sdl.web@gmail.com>
2593
2594 * deps.mk (fns.o):
2595 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2596
2597 * fns.c (crypto_hash_function, Fsha1): New function.
2598 (Fmd5): Use crypto_hash_function.
2599 (syms_of_fns): Add Ssha1.
2600
2601 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * gnutls.c: Remove unused macros.
2604 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2605 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2606 Remove macros that are defined and never used.
2607 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2608
2609 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2610
2611 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2612 (Fx_get_selection_internal): Minor cleanup.
2613 (Fx_own_selection_internal): Rename arguments for consistency with
2614 select.el.
2615
2616 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2619
2620 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2621
2622 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2623
2624 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2625
2626 * dispnew.c (scrolling_window): Don't exclude the case that the
2627 last enabled row in the desired matrix touches the bottom boundary.
2628
2629 2011-05-21 Glenn Morris <rgm@gnu.org>
2630
2631 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2632 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2633 and add some more files.
2634
2635 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2636
2637 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2638 report_file_error introduced by the change from 2011-05-07.
2639
2640 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 * systime.h (Time): Define only if emacs is defined.
2643 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2644 where the include path doesn't have X11/X.h by default. See
2645 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2646
2647 2011-05-20 Kenichi Handa <handa@m17n.org>
2648
2649 * composite.c (find_automatic_composition): Fix previous change.
2650
2651 2011-05-20 Glenn Morris <rgm@gnu.org>
2652
2653 * lisp.mk: New file, split from Makefile.in.
2654 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2655 (shortlisp): Remove.
2656 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2657
2658 2011-05-19 Glenn Morris <rgm@gnu.org>
2659
2660 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2661 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2662 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2663 (lisp): Set the order to that of loadup.el.
2664 (shortlisp): Make it a copy of $lisp.
2665 (SOME_MACHINE_LISP): Remove.
2666 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2667 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2668
2669 2011-05-18 Kenichi Handa <handa@m17n.org>
2670
2671 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2672 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2673 (find_automatic_composition): Mostly rewrite for efficiency.
2674
2675 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2676
2677 * makefile.w32-in: Update dependencies.
2678
2679 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2680
2681 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2682 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2683
2684 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Fix some integer overflow issues, such as string length overflow.
2687
2688 * insdel.c (count_size_as_multibyte): Check for string overflow.
2689
2690 * character.c (lisp_string_width): Check for string overflow.
2691 Use EMACS_INT, not int, for string indexes and lengths; in
2692 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2693 the resulting string length overflows an EMACS_INT; instead,
2694 report a string overflow if no precision given. When checking for
2695 precision exhaustion, use a check that cannot possibly have
2696 integer overflow. (Bug#8675)
2697 * character.h (lisp_string_width): Adjust to new signature.
2698
2699 * alloc.c (string_overflow): New function.
2700 (Fmake_string): Use it. This doesn't change behavior, but saves
2701 a few bytes and will simplify future changes.
2702 * character.c (string_escape_byte8): Likewise.
2703 * lisp.h (string_overflow): New decl.
2704
2705 Fixups, following up to the user-interface timestamp change.
2706 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2707 for UI timestamps, instead of unsigned long.
2708 * msdos.c (mouse_get_pos): Likewise.
2709 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2710 * w32gui.h (Time): Define by including "systime.h" rather than by
2711 declaring it ourselves. (Bug#8664)
2712
2713 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2714 * image.c (clear_image_cache): Likewise.
2715
2716 * term.c (term_mouse_position): Don't assume time_t wraparound.
2717
2718 Be more systematic about user-interface timestamps.
2719 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2720 and sometimes 'EMACS_UINT', to represent these timestamps.
2721 This change causes it to use 'Time' uniformly, as that's what X uses.
2722 This makes the code easier to follow, and makes it easier to catch
2723 integer overflow bugs such as Bug#8664.
2724 * frame.c (Fmouse_position, Fmouse_pixel_position):
2725 Use Time, not unsigned long, for user-interface timestamps.
2726 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2727 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2728 * keyboard.h (last_event_timestamp): Likewise.
2729 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2730 * menu.h (xmenu_show): Likewise.
2731 * term.c (term_mouse_position): Likewise.
2732 * termhooks.h (struct input_event.timestamp): Likewise.
2733 (struct terminal.mouse_position_hook): Likewise.
2734 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2735 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2736 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2737 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2738 what it was before.
2739 * menu.h, termhooks.h: Include "systime.h", for Time.
2740
2741 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2742 Don't assume that the difference between two unsigned long values
2743 can fit into an integer. At this point, we know button_down_time
2744 <= event->timestamp, so the difference must be nonnegative, so
2745 there's no need to cast the result if double-click-time is
2746 nonnegative, as it should be; check that it's nonnegative, just in
2747 case. This bug is triggered when events are more than 2**31 ms
2748 apart (about 25 days). (Bug#8664)
2749
2750 * xselect.c (last_event_timestamp): Remove duplicate decl.
2751 (x_own_selection): Remove needless cast to unsigned long.
2752
2753 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2754 that always fit in int. Use a sentinel instead of a counter, to
2755 avoid a temp and to allay GCC's concerns about possible int overflow.
2756 * frame.h (struct frame): Use int for menu_bar_items_used
2757 instead of EMACS_INT, since it always fits in int.
2758
2759 * menu.c (grow_menu_items): Check for int overflow.
2760
2761 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2762
2763 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2764 Before, the code was not consistent. These values cannot exceed
2765 2**31 - 1 so there's no need to make them unsigned.
2766 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2767 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2768 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2769 as modifiers.
2770 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2771
2772 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2773 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2774 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2775 presumably because the widths might not match.
2776
2777 * window.c (size_window): Avoid needless test at loop start.
2778
2779 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2780
2781 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2782
2783 2011-05-12 Drew Adams <drew.adams@oracle.com>
2784
2785 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2786
2787 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2788
2789 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2790 `width' to `bar_area_x' and `bar_area_width', respectively.
2791 (x_scroll_run): Take account of fringe background extension.
2792
2793 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2794 Rename local vars `left' and `width' to `bar_area_x' and
2795 `bar_area_width', respectively.
2796 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2797 background extension.
2798
2799 2011-05-10 Jim Meyering <meyering@redhat.com>
2800
2801 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2802
2803 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * image.c (Finit_image_library): Return t for built-in image types,
2806 like pbm and xbm. (Bug#8640)
2807
2808 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2809
2810 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2811
2812 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2813
2814 * w32console.c (Fset_screen_color): Doc fix.
2815 (Fget_screen_color): New function.
2816 (syms_of_ntterm): Defsubr it.
2817
2818 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2819 unlink the temporary file if Fcall_process didn't create it in the
2820 first place.
2821 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2822 child process will be redirected to a file specified with `:file'.
2823 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2824 cue to call_process_cleanup not to close that handle.
2825
2826 2011-05-07 Ben Key <bkey76@gmail.com>
2827
2828 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2829 one of two shell specific rules, either bootstrap-temacs-CMD or
2830 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2831 to the previous implementation of the bootstrap-temacs rule.
2832 The bootstrap-temacs-CMD rule is similar to the previous
2833 implementation of the bootstrap-temacs rule except that it
2834 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2835 variable.
2836
2837 These changes, along with some changes to nt/configure.bat,
2838 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2839 earlier fix to add support for --cflags and --ldflags options
2840 that include quotes so that it works whether make uses cmd or
2841 sh as the shell.
2842
2843 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2844
2845 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2846 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2847 is a constant.
2848 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2849 a string. Handle both cases.
2850 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2851 (Fdbus_register_method): Use Qinvalid_function.
2852
2853 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2854
2855 * makefile.w32-in: Update dependencies.
2856 (LISP_H): Add inttypes.h and stdin.h.
2857 (PROCESS_H): Add unistd.h.
2858
2859 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2860
2861 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2862 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2863
2864 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2867
2868 * term.c (vfatal): Remove stray call to va_end.
2869 It's not needed and the C Standard doesn't allow it here anyway.
2870
2871 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2872 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2873
2874 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2875 bytes.
2876
2877 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2878
2879 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2880
2881 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2882
2883 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2884
2885 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2886
2887 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2888 * charset.c (Fdefine_charset_internal): Don't initialize
2889 charset.code_space[15]. The value was garbage, on hosts with
2890 32-bit int (Bug#8600).
2891
2892 * lread.c (read_integer): Be more consistent with string-to-number.
2893 Use string_to_number to do the actual conversion; this avoids
2894 rounding errors and fixes some other screwups. Without this fix,
2895 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2896 (digit_to_number): Move earlier, for benefit of read_integer.
2897 Return -1 if the digit is out of range for the base, -2 if it is
2898 not a digit in any supported base. (Bug#8602)
2899
2900 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2901
2902 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2903 to match comment at start of function. This also removes a
2904 GCC warning about overflow in a 32+64-bit port.
2905
2906 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2907
2908 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2909 Reported by Stefan Monnier in
2910 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2911 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2912 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2913
2914 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2915 (EMACS_UINTPTR): Likewise, with uintptr_t.
2916
2917 * lisp.h: Prefer 64-bit EMACS_INT if available.
2918 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2919 on 32-bit hosts that have 64-bit int, so that they can access
2920 large files.
2921 However, temporarily disable this change unless the temporary
2922 symbol WIDE_EMACS_INT is defined.
2923
2924 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2925
2926 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2927 This removes an assumption that EMACS_INT and long are the same
2928 width as pointers. The assumption is true for Emacs porting targets
2929 now, but we want to make other targets possible.
2930 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2931 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2932 In the rest of the code, change types of integers that hold casted
2933 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2934 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2935 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2936 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2937 No need to cast type when ORing.
2938 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2939 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2940 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2941 assume EMACS_INT is the same width as char *.
2942 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2943 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2944 Remove no-longer-needed casts.
2945 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2946 (xg_tool_bar_help_callback, xg_make_tool_item):
2947 Use EMACS_INTPTR to hold an integer
2948 that will be cast to void *; this can avoid a GCC warning
2949 if EMACS_INT is not the same width as void *.
2950 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2951 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2952 (current_message_1, set_message_1):
2953 Use a local to convert to proper width without a cast.
2954 * xmenu.c (dialog_selection_callback): Likewise.
2955
2956 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2957 Also, don't assume VALBITS / RAND_BITS is less than 5,
2958 and don't rely on undefined behavior when shifting a 1 left into
2959 the sign bit.
2960 * lisp.h (get_random): Change signature to match.
2961
2962 * lread.c (hash_string): Use size_t, not int, for hash computation.
2963 Normally we prefer signed values; but hashing is special, because
2964 it's better to use unsigned division on hash table sizes so that
2965 the remainder is nonnegative. Also, size_t is the natural width
2966 for hashing into memory. The previous code used 'int', which doesn't
2967 retain enough info to hash well into very large tables.
2968 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2969
2970 * dbusbind.c: Don't possibly lose pointer info when converting.
2971 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2972 Use XPNTR rather than XHASH, so that the high-order bits of
2973 the pointer aren't lost when converting through void *.
2974
2975 * eval.c (Fautoload): Don't double-shift a pointer.
2976
2977 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2978
2979 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2980
2981 * gnutls.c (DEF_GNUTLS_FN):
2982 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2983
2984 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2985
2986 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2987 marker. (Bug#8610)
2988
2989 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2990
2991 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2992 New version that can reserve upto 2GB of heap space.
2993
2994 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2997
2998 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2999
3000 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3001 `gnutls_certificate_set_x509_key_file'.
3002
3003 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3004
3005 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3006 Update dependencies.
3007
3008 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3009
3010 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3011 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3012 Remove unused parameter `fildes'.
3013 * process.c (read_process_output, send_process): Don't pass it.
3014
3015 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3016
3017 Fix previous change: the library cache is defined in w32.c.
3018 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3019 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3020
3021 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3022
3023 Implement dynamic loading of GnuTLS on Windows.
3024
3025 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3026 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3027 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3028 Declare.
3029
3030 * gnutls.c (Qgnutls_dll): Define.
3031 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3032 (gnutls_*): Declare function pointers.
3033 (init_gnutls_functions): New function to initialize function pointers.
3034 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3035 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3036 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3037 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3038 (emacs_gnutls_write, emacs_gnutls_read)
3039 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3040 (Fgnutls_available_p): New function.
3041 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3042 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3043 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3044
3045 * image.c: Include w32.h.
3046 (Vimage_type_cache): Delete.
3047 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3048 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3049 (w32_delayed_load): Move to w32.c.
3050
3051 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3052
3053 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3054 (w32_delayed_load): Move from image.c. When loading a library, record
3055 its filename in the :loaded-from property of the library id.
3056 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3057 Initialize and staticpro them.
3058 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3059
3060 * process.c: Include lisp.h before w32.h, not after.
3061 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3062 instead of gnutls_record_check_pending.
3063
3064 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3065
3066 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3067
3068 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3069 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3070 as passed in.
3071
3072 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3073
3074 * xterm.c (x_set_frame_alpha): Do not set property on anything
3075 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3076
3077 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3078
3079 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3080
3081 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3082
3083 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3084 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3085 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3086 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3087 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3088 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3089 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3090 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3091 (Qgnutls_bootprop_callbacks_verify): Make static.
3092
3093 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3094
3095 * callproc.c: Indentation fixup.
3096
3097 * sysdep.c (wait_for_termination_1): Make static.
3098 (wait_for_termination, interruptible_wait_for_termination):
3099 Move after wait_for_termination_1.
3100
3101 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3102
3103 * sysdep.c (interruptible_wait_for_termination): New function
3104 which is like wait_for_termination, but allows keyboard
3105 interruptions.
3106
3107 * callproc.c (Fcall_process): Add (:file "file") as an option for
3108 the STDOUT buffer.
3109 (Fcall_process_region): Ditto.
3110
3111 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3112
3113 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3114 rather than `XVECTOR (FOO)->size'.
3115
3116 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3117 inttypes.h, as a gnulib replacement is used if it not available in
3118 system headers.
3119
3120 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3121
3122 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3123 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3124 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3125
3126 * coding.c (coding_alloc_by_realloc): Error out if destination
3127 will grow beyond MOST_POSITIVE_FIXNUM.
3128 (decode_coding_emacs_mule): Abort if there isn't enough place in
3129 charbuf for the composition carryover bytes. Reserve an extra
3130 space for up to 2 characters produced in a loop.
3131 (decode_coding_iso_2022): Abort if there isn't enough place in
3132 charbuf for the composition carryover bytes.
3133
3134 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3135
3136 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3137 aborting when %lld or %lll format is passed.
3138 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3139 %llo or %llx format is passed. (Bug#8545)
3140
3141 * window.c (window_scroll_line_based): Use a marker instead of
3142 simple variables to record original value of point. (Bug#7952)
3143
3144 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3145 produced by %s or %c overflows available buffer space. (Bug#8545)
3146
3147 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3150 (SIZE_MAX): Move defn after all includes, as they might #define it.
3151
3152 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3155
3156 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3157
3158 * keyboard.c (Qdelayed_warnings_hook): Define.
3159 (command_loop_1): Run `delayed-warnings-hook'
3160 if Vdelayed_warnings_list is non-nil.
3161 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3162 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3163
3164 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3165
3166 * doprnt.c (doprnt): Don't return value smaller than the buffer
3167 size if the message was truncated. (Bug#8545).
3168
3169 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3172 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3173
3174 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3177
3178 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3179
3180 * makefile.w32-in: Update dependencies.
3181
3182 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3183
3184 Improve `doprnt' and its usage. (Bug#8545)
3185 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3186 `format_end'. Remove support for %l as a conversion specifier.
3187 Don't use xrealloc. Improve diagnostics when the %l size modifier
3188 is used. Update the commentary.
3189
3190 * eval.c (verror): Simplify calculation of size_t.
3191
3192 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3193 messages.
3194
3195 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3196
3197 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3198 change.
3199
3200 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3203 This makes this file independent of the recent pseudovector change.
3204
3205 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3206
3207 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3208
3209 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3210 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3211 Remove unused local.
3212 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3213
3214 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3215 GCC 4.6.0 optimizes based on type-based alias analysis.
3216 For example, if b is of type struct buffer * and v of type struct
3217 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3218 != &v->size, and therefore "v->size = 1; b->size = 2; return
3219 v->size;" must therefore return 1. This assumption is incorrect
3220 for Emacs, since it type-puns struct Lisp_Vector * with many other
3221 types. To fix this problem, this patch adds a new type struct
3222 vectorlike_header that documents the constraints on layout of vectors
3223 and pseudovectors, and helps optimizing compilers not get fooled
3224 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3225 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3226 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3227 the size member.
3228 (XSETPVECTYPE): Rewrite in terms of new macro.
3229 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3230 This is a bit clearer, and further avoids the possibility of
3231 undesirable aliasing.
3232 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3233 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3234 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3235 since Lisp_Subr is a special case (no "next" field).
3236 (ASIZE): Now uses header.size rather than size.
3237 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3238 to avoid the hassle of writing XVECTOR (foo)->header.size.
3239 (struct vectorlike_header): New type.
3240 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3241 object, to help avoid aliasing.
3242 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3243 (SUBRP): Likewise, since Lisp_Subr is a special case.
3244 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3245 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3246 (struct Lisp_Hash_Table): Combine first two members into a single
3247 struct vectorlike_header member. All uses of "size" and "next" members
3248 changed to be "header.size" and "header.next".
3249 * buffer.h (struct buffer): Likewise.
3250 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3251 * frame.h (struct frame): Likewise.
3252 * process.h (struct Lisp_Process): Likewise.
3253 * termhooks.h (struct terminal): Likewise.
3254 * window.c (struct save_window_data, struct saved_window): Likewise.
3255 * window.h (struct window): Likewise.
3256 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3257 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3258 * buffer.c (init_buffer_once): Likewise.
3259 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3260 special case.
3261 * process.c (Fformat_network_address): Use local var for size,
3262 for brevity.
3263
3264 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3265
3266 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3267 * data.c (atof): Remove decl; no longer used or needed.
3268 (digit_to_number): Move to lread.c.
3269 (Fstring_to_number): Use new string_to_number function, to be
3270 consistent with how the Lisp reader treats infinities and NaNs.
3271 Do not assume that floating-point numbers represent EMACS_INT
3272 without losing information; this is not true on most 64-bit hosts.
3273 Avoid double-rounding errors, by insisting on integers when
3274 parsing non-base-10 numbers, as the documentation specifies.
3275 * lisp.h (string_to_number): New decl, replacing ...
3276 (isfloat_string): Remove.
3277 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3278 (read1): Do not accept +. and -. as integers; this
3279 appears to have been a coding error. Similarly, do not accept
3280 strings like +-1e0 as floating point numbers. Do not report
3281 overflow for integer overflows unless the base is not 10 which
3282 means we have no simple and reliable way to continue.
3283 Break out the floating-point parsing into a new
3284 function string_to_number, so that Fstring_to_number parses
3285 floating point numbers consistently with the Lisp reader.
3286 (digit_to_number): Move here from data.c. Make it static inline.
3287 (E_CHAR, EXP_INT): Remove, replacing with ...
3288 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3289 (string_to_number): New function, replacing isfloat_string.
3290 This function checks for valid syntax and produces the resulting
3291 Lisp float number too. Rework it so that string-to-number
3292 no longer mishandles examples like "1.0e+". Use strtoumax,
3293 so that overflow for non-base-10 numbers is reported only when
3294 there's no portable and simple way to convert to floating point.
3295
3296 * textprop.c (set_text_properties_1): Rewrite for clarity,
3297 and to avoid GCC warning about integer overflow.
3298
3299 * intervals.h (struct interval): Use EMACS_INT for members
3300 where EMACS_UINT might cause problems. See
3301 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3302 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3303 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3304 All uses changed.
3305 (offset_intervals): Tell GCC not to worry about length overflow
3306 when negating a negative length.
3307
3308 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3309 (overrun_check_free): Likewise.
3310
3311 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3312 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3313 word size.
3314
3315 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3316 (gnutls_make_error): Rename local to avoid shadowing.
3317 (gnutls_emacs_global_deinit): ifdef out; not used.
3318 (Fgnutls_boot): Use const for pointer to readonly storage.
3319 Comment out unused local. Fix pointer signedness problems.
3320
3321 * lread.c (openp): Don't stuff size_t into an 'int'.
3322 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3323 about possible signed overflow.
3324
3325 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3326 (GDK_KEY_g): Don't define if already defined.
3327 (xg_prepare_tooltip): Avoid pointer signedness problem.
3328 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3329
3330 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3331 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3332
3333 * xfns.c (Fx_window_property): Simplify a bit,
3334 to make a bit faster and to avoid GCC 4.6.0 warning.
3335 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3336
3337 * fns.c (internal_equal): Don't assume size_t fits in int.
3338
3339 * alloc.c (compact_small_strings): Tighten assertion a little.
3340
3341 Replace pEd with more-general pI, and fix some printf arg casts.
3342 * lisp.h (pI): New macro, generalizing old pEd macro to other
3343 conversion specifiers. For example, use "...%"pI"d..." rather
3344 than "...%"pEd"...".
3345 (pEd): Remove. All uses replaced with similar uses of pI.
3346 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3347 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3348 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3349 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3350 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3351 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3352 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3353 64-bit hosts.
3354 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3355 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3356 * print.c (safe_debug_print, print_object): Likewise.
3357 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3358 to int.
3359 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3360 avoiding the 0 flag, which is not portable.
3361 * process.c (Fmake_network_process): Use pI to avoid cast.
3362 * region-cache.c (pp_cache): Likewise.
3363 * xdisp.c (decode_mode_spec): Likewise.
3364 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3365 behavior on 64-bit hosts with printf arg.
3366 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3367 (x_stop_queuing_selection_requests): Likewise.
3368 (x_get_window_property): Don't truncate byte count to an 'int'
3369 when tracing.
3370
3371 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3372 here, since it parses constructs like leading '-' and spaces,
3373 which are not wanted; and it overflows with large numbers.
3374 Instead, simply match F[0-9]+, which is what is wanted anyway.
3375
3376 * alloc.c: Remove unportable assumptions about struct layout.
3377 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3378 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3379 (allocate_vectorlike, make_pure_vector): Use the new macros,
3380 plus offsetof, to remove unportable assumptions about struct layout.
3381 These assumptions hold on all porting targets that I know of, but
3382 they are not guaranteed, they're easy to remove, and removing them
3383 makes further changes easier.
3384
3385 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3386 This doesn't fix a bug but makes the code clearer.
3387 (string_overrun_cookie): Now const. Use initializers that
3388 don't formally overflow signed char, to avoid warnings.
3389 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3390 can cause Emacs to crash when string overrun checking is enabled.
3391 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3392 multiple of sizeof (EMACS_INT); it need not be, if
3393 alignof(EMACS_INT) < sizeof (EMACS_INT).
3394 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3395
3396 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3397
3398 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3399
3400 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3401
3402 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3403 supposed to be handshaking. (Bug#8556)
3404 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3405
3406 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3407
3408 * lisp.h (Qdebug): List symbol.
3409 * eval.c (Qdebug): Restore global linkage.
3410 * keyboard.c (debug-on-event): New variable.
3411 (handle_user_signal): Break into debugger when debug-on-event
3412 matches the current signal symbol.
3413
3414 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3415
3416 * alloc.c (check_sblock, check_string_bytes)
3417 (check_string_free_list): Convert to standard C.
3418
3419 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3420
3421 * w32.c (emacs_gnutls_push): Fix typo.
3422
3423 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3424
3425 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3426 "cast to pointer from integer of different size".
3427
3428 Improve doprnt and its use in verror. (Bug#8545)
3429 * doprnt.c (doprnt): Document the set of format control sequences
3430 supported by the function. Use SAFE_ALLOCA instead of always
3431 using `alloca'.
3432
3433 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3434 is one byte too soon. Don't use xrealloc; instead xfree and
3435 xmalloc anew.
3436
3437 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3438
3439 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3440 callbacks stage.
3441
3442 * gnutls.c: Renamed global_initialized to
3443 gnutls_global_initialized. Added internals for the
3444 :verify-hostname-error, :verify-error, and :verify-flags
3445 parameters of `gnutls-boot' and documented those parameters in the
3446 docstring. Start callback support.
3447 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3448 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3449 on error. Return error code.
3450 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3451 (emacs_gnutls_read): Likewise.
3452 (Fgnutls_boot): Return handshake error code.
3453 (emacs_gnutls_handle_error): New function.
3454 (wsaerror_to_errno): Likewise.
3455
3456 * w32.h (emacs_gnutls_pull): Add prototype.
3457 (emacs_gnutls_push): Likewise.
3458
3459 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3460 (emacs_gnutls_push): Likewise.
3461
3462 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3463
3464 * process.c (wait_reading_process_output): Check if GnuTLS
3465 buffered some data internally if no FDs are set for TLS
3466 connections.
3467
3468 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3469 (LIBS): Link to USER_LIBS.
3470 ($(BLD)/gnutls.$(0)): New target.
3471
3472 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3473
3474 * xdisp.c (handle_single_display_spec): Rename the
3475 display_replaced_before_p argument into display_replaced_p, to
3476 make it consistent with the commentary. Fix typos in the
3477 commentary.
3478
3479 * textprop.c (syms_of_textprop): Remove dead code.
3480 (copy_text_properties): Delete obsolete commentary about an
3481 interface that was deleted long ago. Fix typos in the description
3482 of arguments.
3483
3484 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3485 to changes in oldXMenu/XMenu.h from 2011-04-16.
3486 <menu_help_message, prev_menu_help_message>: Constify.
3487 (IT_menu_make_room): menu->help_text is now `const char **';
3488 adjust.
3489
3490 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3491 to changes in oldXMenu/XMenu.h from 2011-04-16.
3492 (struct XMenu): Declare `help_text' `const char **'.
3493
3494 * xfaces.c <Qunspecified>: Make extern again.
3495
3496 * syntax.c: Include sys/types.h before including regex.h, as
3497 required by Posix.
3498
3499 * doc.c (get_doc_string): Improve the format passed to `error'.
3500
3501 * doprnt.c (doprnt): Improve commentary.
3502
3503 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3504
3505 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3506 them with etags.
3507
3508 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3509 changes in globals.h immediately force recompilation.
3510 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3511 $(CURDIR)/s/ms-w32.h.
3512 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3513
3514 * character.c (Fchar_direction): Function deleted.
3515 (syms_of_character): Don't defsubr it.
3516 <char-direction-table>: Deleted.
3517
3518 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3519
3520 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3521 * doprnt.c: Include limits.h.
3522 (SIZE_MAX): New macro.
3523 (doprnt): Return a size_t value. 2nd arg is now size_t.
3524 Many local variables are now size_t instead of int or unsigned.
3525 Improve overflow protection. Support `l' modifier for integer
3526 conversions. Support %l conversion. Don't assume an EMACS_INT
3527 argument for integer conversions and for %c.
3528
3529 * lisp.h (doprnt): Restore prototype.
3530
3531 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3532 $(SRC)/character.h.
3533
3534 * Makefile.in (base_obj): Add back doprnt.o.
3535
3536 * deps.mk (doprnt.o): Add back prerequisites.
3537 (callint.o): Depend on character.h.
3538
3539 * eval.c (internal_lisp_condition_case): Include the handler
3540 representation in the error message.
3541 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3542 when breaking from the loop.
3543
3544 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3545
3546 * callint.c (Fcall_interactively): When displaying error message
3547 about invalid control letter, pass the character's codepoint, not
3548 a pointer to its multibyte form. Improve display of the character
3549 in octal and display also its hex code.
3550
3551 * character.c (char_string): Use %x to display the (unsigned)
3552 codepoint of an invalid character, to avoid displaying a bogus
3553 negative value.
3554
3555 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3556 `error', not SYMBOL_NAME itself.
3557
3558 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3559 character arguments to `error'.
3560
3561 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3562 to `error' in error message about FINAL_CHAR argument. Make sure
3563 FINAL_CHAR is a character, and use %c when it is passed as
3564 argument to `error'.
3565
3566 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3567
3568 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3569
3570 * w32.c: Include <time.h>.
3571 (sys_localtime): New function.
3572
3573 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3574
3575 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3576
3577 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3578
3579 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3580
3581 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3582 zombies (Bug#8467).
3583
3584 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3585
3586 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3587 gl_state.e_property when gl_state.object is Qt.
3588
3589 * insdel.c (make_gap_larger): Remove limitation of buffer size
3590 to <= INT_MAX.
3591
3592 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3593
3594 * xdisp.c (lookup_glyphless_char_display)
3595 (produce_glyphless_glyph): Handle cons cell entry in
3596 glyphless-char-display.
3597 (Vglyphless_char_display): Document it.
3598
3599 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3600 glyphless-char-display.
3601
3602 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3605
3606 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3607
3608 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3609 definition for no-X builds.
3610
3611 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 Static checks with GCC 4.6.0 and non-default toolkits.
3614
3615 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3616
3617 * process.c (keyboard_bit_set): Define only if SIGIO.
3618 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3619 (send_process): Repair possible setjmp clobbering.
3620
3621 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3622
3623 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3624
3625 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3626
3627 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3628 Define only if needed.
3629
3630 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3631 by pacifying GCC about it. Maybe it's time to retire it?
3632 * xfaces.c (USG, __TIMEVAL__): Likewise.
3633
3634 * dispextern.h (struct redisplay_interface): Rename param
3635 to avoid shadowing.
3636 * termhooks.h (struct terminal): Likewise.
3637 * xterm.c (xembed_send_message): Likewise.
3638
3639 * insdel.c (make_gap_smaller): Define only if
3640 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3641
3642 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3643 it.
3644
3645 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3646 so that we aren't warned about unused symbols.
3647
3648 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3649
3650 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3651
3652 * xfns.c (x_real_positions): Mark locals as initialized.
3653
3654 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3655
3656 * xterm.c: Fix problems found by static analysis with other toolkits.
3657 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3658 (x_dispatch_event): Declare static if USE_GTK, and
3659 define if USE_GTK || USE_X_TOOLKIT.
3660 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3661 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3662 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3663 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3664
3665 * xmenu.c (menu_help_callback): Pointer type fixes.
3666 Use const pointers when pointing at readonly data. Avoid pointer
3667 signedness clashes.
3668 (FALSE): Remove unused macro.
3669 (update_frame_menubar): Remove unused decl.
3670
3671 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3672
3673 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3674 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3675 (single_menu_item): Rename local to avoid shadowing.
3676
3677 * keyboard.c (make_lispy_event): Remove unused local var.
3678
3679 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3680 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3681
3682 * bitmaps: Change bitmaps from unsigned char back to the X11
3683 compatible char. Avoid the old compiler warnings about
3684 out-of-range initializers by using, for example, '\xab' rather
3685 than 0xab.
3686
3687 * xgselect.c (xgselect_initialize): Check vs interface
3688 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3689
3690 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3691
3692 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3693 to read-only memory.
3694
3695 * fns.c (vector): Remove; this old hack is no longer needed.
3696
3697 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3698 Remove unused var.
3699 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3700
3701 * xrdb.c (x_load_resources): Omit unused local.
3702
3703 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3704 (x_window): Rename locals to avoid shadowing.
3705 (USG): Use the kludged USG macro, to pacify gcc.
3706
3707 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3708 (x_term_init): Remove local to avoid shadowing.
3709
3710 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3711
3712 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3713 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3714
3715 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3716
3717 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3718
3719 Fix regex.c, syntax.c and friends for buffers > 2GB.
3720 * syntax.h (struct gl_state_s): Declare character position members
3721 EMACS_INT.
3722
3723 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3724
3725 * textprop.c (verify_interval_modification, interval_of):
3726 Declare arguments EMACS_INT.
3727
3728 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3729 EMACS_INT.
3730
3731 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3732
3733 * indent.c (Fvertical_motion): Local variable it_start is now
3734 EMACS_INT.
3735
3736 * regex.c (re_match, re_match_2, re_match_2_internal)
3737 (bcmp_translate, regcomp, regexec, print_double_string)
3738 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3739 (re_compile_pattern, re_exec): Declare arguments and local
3740 variables `size_t' and `ssize_t' and return values `regoff_t', as
3741 appropriate.
3742 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3743 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3744 <compile_stack_type>: `size' and `avail' are now `size_t'.
3745
3746 * regex.h <regoff_t>: Use ssize_t, not int.
3747 (re_search, re_search_2, re_match, re_match_2): Arguments that
3748 specify buffer/string position and length are now ssize_t and
3749 size_t. Return type is regoff_t.
3750
3751 2011-04-16 Ben Key <bkey76@gmail.com>
3752
3753 * nsfont.m: Fixed bugs in ns_get_family and
3754 ns_descriptor_to_entity that were caused by using free to
3755 deallocate memory blocks that were allocated by xmalloc (via
3756 xstrdup). This caused Emacs to crash when compiled with
3757 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3758 --enable-checking=xmallocoverrun). xfree is now used to
3759 deallocate these memory blocks.
3760
3761 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3764
3765 emacs_write: Accept and return EMACS_INT for sizes.
3766 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3767 et seq.
3768 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3769 Accept and return EMACS_INT.
3770 (emacs_gnutls_write): Return the number of bytes written on
3771 partial writes.
3772 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3773 (emacs_read, emacs_write): Remove check for negative size, as the
3774 Emacs source code has been audited now.
3775 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3776 (emacs_read, emacs_write): Use it.
3777 * process.c (send_process): Adjust to the new signatures of
3778 emacs_write and emacs_gnutls_write. Do not attempt to store
3779 a byte offset into an 'int'; it might overflow.
3780 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3781
3782 * sound.c: Don't assume sizes fit in 'int'.
3783 (struct sound_device.period_size, alsa_period_size):
3784 Return EMACS_INT, not int.
3785 (struct sound_device.write, vox_write, alsa_write):
3786 Accept EMACS_INT, not int.
3787 (wav_play, au_play): Use EMACS_INT to store sizes and to
3788 record read return values.
3789
3790 2011-04-15 Ben Key <bkey76@gmail.com>
3791
3792 * keyboard.c (Qundefined): Don't declare static since it is used
3793 in nsfns.m.
3794 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3795 static since they are used in nsfont.m.
3796
3797 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3798
3799 * process.c (Qprocessp): Don't declare static.
3800 * lisp.h (Qprocessp): Declare again.
3801
3802 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3803
3804 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3805
3806 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Improve C-level modularity by making more things 'static'.
3809
3810 Don't publish debugger-only interfaces to other modules.
3811 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3812 (verify_bytepos, count_markers): Move decls to the only modules
3813 that need them.
3814 * region-cache.h (pp_cache): Likewise.
3815 * window.h (check_all_windows): Likewise.
3816 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3817
3818 * sysdep.c (croak): Now static, if
3819 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3820 * syssignal.h (croak): Declare only if not static.
3821
3822 * alloc.c (refill_memory_reserve): Now static if
3823 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3824 * lisp.h (refill_memory_reserve): Declare only if not static.
3825
3826 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3827 Define only if USE_LUCID.
3828
3829 * xrdb.c (x_customization_string, x_rm_string): Now static.
3830
3831 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3832 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3833
3834 * xdisp.c (draw_row_with_mouse_face): Now static.
3835 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3836
3837 * window.h (check_all_windows): Mark externally visible.
3838
3839 * window.c (window_deletion_count): Now static.
3840
3841 * undo.c: Make symbols static if they're not exported.
3842 (last_undo_buffer, last_boundary_position, pending_boundary):
3843 Now static.
3844
3845 * textprop.c (interval_insert_behind_hooks): Now static.
3846 (interval_insert_in_front_hooks): Likewise.
3847
3848 * term.c: Make symbols static if they're not exported.
3849 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3850 (max_frame_lines, tty_set_terminal_modes):
3851 (tty_reset_terminal_modes, tty_turn_off_highlight):
3852 (get_tty_terminal): Now static.
3853 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3854 * termhooks.h (term_mouse_moveto): Do not declare if
3855 HAVE_WINDOW_SYSTEM.
3856 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3857 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3858
3859 * sysdep.c: Make symbols static if they're not exported.
3860 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3861 Now static.
3862 (sigprocmask_set, full_mask): Remove; unused.
3863 (wait_debugging): Mark as visible.
3864 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3865 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3866
3867 * syntax.c (syntax_temp): Define only if !__GNUC__.
3868
3869 * sound.c (current_sound_device, current_sound): Now static.
3870
3871 * search.c (searchbufs, searchbuf_head): Now static.
3872
3873 * scroll.c (scroll_cost): Remove; unused.
3874 * dispextern.h (scroll_cost): Remove decl.
3875
3876 * region-cache.h (pp_cache): Mark as externally visible.
3877
3878 * process.c: Make symbols static if they're not exported.
3879 (process_tick, update_tick, create_process, chan_process):
3880 (Vprocess_alist, proc_buffered_char, datagram_access):
3881 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3882 (deactivate_process): Mark defn as static, as well as decl.
3883 * lisp.h (create_process): Remove decl.
3884 * process.h (chan_process, Vprocess_alist): Remove decls.
3885
3886 * print.c: Make symbols static if they're not exported.
3887 (print_depth, new_backquote_output, being_printed, print_buffer):
3888 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3889 (print_interval, print_number_index, initial_stderr_stream):
3890 Now static.
3891 * lisp.h (Fprinc): Remove decl.
3892 (debug_output_compilation_hack): Mark as externally visible.
3893
3894 * sysdep.c (croak): Move decl from here to syssignal.h.
3895 * syssignal.h (croak): Put it here, so the API can be checked when
3896 'croak' is called from dissociate_if_controlling_tty.
3897
3898 * minibuf.c: Make symbols static if they're not exported.
3899 (minibuf_save_list, choose_minibuf_frame): Now static.
3900 * lisp.h (choose_minibuf_frame): Remove decl.
3901
3902 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3903
3904 * lread.c: Make symbols static if they're not exported.
3905 (read_objects, initial_obarray, oblookup_last_bucket_number):
3906 Now static.
3907 (make_symbol): Remove; unused.
3908 * lisp.h (initial_obarray, make_symbol): Remove decls.
3909
3910 * keyboard.c: Make symbols static if they're not exported.
3911 (single_kboard, recent_keys_index, total_keys, recent_keys):
3912 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3913 (this_single_command_key_start, echoing, last_auto_save):
3914 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3915 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3916 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3917 (Vlispy_mouse_stem, double_click_count):
3918 Now static.
3919 (force_auto_save_soon): Define only if SIGDANGER.
3920 (ignore_mouse_drag_p): Now static if
3921 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3922 (print_help): Remove; unused.
3923 (stop_character, last_timer_event): Mark as externally visible.
3924 * keyboard.h (ignore_mouse_drag_p): Declare only if
3925 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3926 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3927 * lisp.h (echoing): Remove decl.
3928 (force_auto_save_soon): Declare only if SIGDANGER.
3929 * xdisp.c (redisplay_window): Simplify code, to make it more
3930 obvious that ignore_mouse_drag_p is not accessed if !defined
3931 USE_GTK && !defined HAVE_NS.
3932
3933 * intervals.c: Make symbols static if they're not exported.
3934 (merge_properties_sticky, merge_interval_right, delete_interval):
3935 Now static.
3936 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3937
3938 * insdel.c: Make symbols static if they're not exported.
3939 However, leave prepare_to_modify_buffer alone. It's never
3940 called from outside this function, but that appears to be a bug.
3941 (combine_after_change_list, combine_after_change_buffer):
3942 (adjust_after_replace, signal_before_change): Now static.
3943 (adjust_after_replace_noundo): Remove; unused.
3944 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3945 (signal_before_change): Remove decls.
3946
3947 * indent.c (val_compute_motion, val_vmotion): Now static.
3948
3949 * image.c: Make symbols static if they're not exported.
3950 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3951 if USE_GTK.
3952 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3953 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3954
3955 * fringe.c (standard_bitmaps): Now static.
3956 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3957
3958 * frame.c: Make symbols static if they're not exported.
3959 (x_report_frame_params, make_terminal_frame): Now static.
3960 (get_frame_param): Now static, unless HAVE_NS.
3961 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3962 (x_get_resource_string): Remove; not used.
3963 * frame.h (make_terminal_frame, x_report_frame_params):
3964 (x_get_resource_string); Remove decls.
3965 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3966 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3967
3968 * font.c, fontset.c: Make symbols static if they're not exported.
3969 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3970 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3971 * font.c (font_close_object): Now static.
3972 * font.h (font_close_object): Remove.
3973 * fontset.c (FONTSET_OBJLIST): Remove.
3974 (free_realized_fontset) #if-0 the body, which does nothing.
3975 (face_suitable_for_char_p): #if-0, as it's never called.
3976 * fontset.h (face_suitable_for_char_p): Remove decl.
3977 * xfaces.c (face_at_string_position):
3978 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3979 since 0 is always ASCII.
3980
3981 * fns.c (weak_hash_tables): Now static.
3982
3983 * fileio.c: Make symbols static if they're not exported.
3984 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3985 (Vwrite_region_annotation_buffers): Now static.
3986
3987 * eval.c: Make symbols static if they're not exported.
3988 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3989 * lisp.h (backtrace_list): Remove decl.
3990
3991 * emacs.c: Make symbols static if they're not exported.
3992 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3993 (fatal_error_code, fatal_error_signal_hook, standard_args):
3994 Now static.
3995 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3996 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3997 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3998 * lisp.h (fatal_error_signal_hook): Remove decl.
3999 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4000
4001 * editfns.c: Move a (normally-unused) function to its only use.
4002 * editfns.c, lisp.h (get_operating_system_release): Remove.
4003 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4004 worth the hassle of breaking this out.
4005
4006 * xterm.c: Make symbols static if they're not exported.
4007 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4008 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4009 (x_destroy_window, x_delete_display):
4010 Now static.
4011 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4012 (x_mouse_leave): Remove; unused.
4013 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4014 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4015 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4016 Remove decls.
4017 (x_mouse_leave): Declare only if WINDOWSNT.
4018 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4019 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4020 USE_X_TOOLKIT.
4021
4022 * ftxfont.c: Make symbols static if they're not exported.
4023 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4024 HAVE_FREETYPE.
4025 * font.h (ftxfont_driver): Likewise.
4026
4027 * xfns.c: Make symbols static if they're not exported.
4028 (x_last_font_name, x_display_info_for_name):
4029 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4030 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4031 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4032 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4033 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4034 (last_show_tip_args): Now static.
4035 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4036 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4037 (x_screen_planes): Remove; unused.
4038 * dispextern.h (x_screen_planes): Remove decl.
4039
4040 * dispnew.c: Make symbols static if they're not exported.
4041 * dispextern.h (redraw_garbaged_frames, scrolling):
4042 (increment_row_positions): Remove.
4043 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4044 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4045 Now static.
4046 (redraw_garbaged_frames): Remove; unused.
4047
4048 * xfaces.c: Make symbols static if they're not exported.
4049 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4050 Remove decls.
4051 * xterm.h (defined_color): Remove decls.
4052 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4053 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4054 (menu_face_changed_default, defined_color, free_realized_face):
4055 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4056 (ascii_face_of_lisp_face): Remove; unused.
4057
4058 * xdisp.c: Make symbols static if they're not exported.
4059 * dispextern.h (scratch_glyph_row, window_box_edges):
4060 (glyph_to_pixel_coords, set_cursor_from_row):
4061 (get_next_display_element, set_iterator_to_next):
4062 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4063 (show_mouse_face): Remove decls
4064 * frame.h (message_buf_print): Likewise.
4065 * lisp.h (pop_message, set_message, check_point_in_composition):
4066 Likewise.
4067 * xterm.h (set_vertical_scroll_bar): Likewise.
4068 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4069 (message_buf_print, scratch_glyph_row, displayed_buffer):
4070 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4071 (get_next_display_element, show_mouse_face, window_box_edges):
4072 (frame_to_window_pixel_xy, check_point_in_composition):
4073 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4074 (glyph_to_pixel_coords): Remove; unused.
4075
4076 * dired.c (file_name_completion): Now static.
4077
4078 * dbusbind.c (xd_in_read_queued_messages): Now static.
4079
4080 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4081 * data.c (circular_list_error): Remove.
4082
4083 * commands.h (last_point_position, last_point_position_buffer):
4084 (last_point_position_window): Remove decls.
4085 * keyboard.c: Make these variables static.
4086
4087 * coding.h (coding, code_convert_region, encode_coding_gap):
4088 Remove decls.
4089 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4090 (iso_code_class, detect_coding, code_convert_region): Now static.
4091 (encode_coding_gap): Remove; unused.
4092
4093 * chartab.c (chartab_chars, chartab_bits): Now static.
4094
4095 * charset.h (charset_iso_8859_1): Remove decl.
4096 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4097 Now static.
4098
4099 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4100 * ccl.c (Vccl_program_table): Now static.
4101 (check_ccl_update): Remove; unused.
4102
4103 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4104 * category.h: ... from here.
4105 * category.c (check_category_table, set_category_set): Now static.
4106
4107 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4108 * lisp.h: Remove these decls.
4109
4110 * buffer.c (buffer_count): Remove unused var.
4111
4112 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4113 so that it's not optimized away.
4114 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4115 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4116 exported only to the debugger.
4117
4118 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4119 * atimer.h (run_all_atimers): Remove; not exported.
4120
4121 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4122 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4123 was inaccessible from Lisp.
4124 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4125 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4126
4127 alloc.c: Import and export fewer symbols, and remove unused items.
4128 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4129 is defined.
4130 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4131 it's not optimized away by whole-program optimization.
4132 (message_enable_multibyte, free_misc): Remove.
4133 (catchlist, handlerlist, mark_backtrace):
4134 Declare only if BYTE_MARK_STACK.
4135 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4136 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4137 (message_enable_multibyte): Remove decl.
4138 (free_misc, interval_free_list, float_block, float_block_index):
4139 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4140 (cons_free_list, last_marked_index):
4141 Now static.
4142 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4143 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4144 (mark_backtrace): Define only if BYTE_MARK_STACK.
4145 * xdisp.c (message_enable_multibyte): Now static.
4146
4147 Declare Lisp_Object Q* variables to be 'static' if not exported.
4148 This makes it easier for human readers (and static analyzers)
4149 to see whether these variables are used from other modules.
4150 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4151 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4152 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4153 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4154 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4155 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4156 * xmenu.c, xselect.c:
4157 Declare Q* vars static if they are not used in other modules.
4158 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4159 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4160 Remove decls of unexported vars.
4161 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4162
4163 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4164
4165 Make Emacs functions such as Fatom 'static' by default.
4166 This makes it easier for human readers (and static analyzers)
4167 to see whether these functions can be called from other modules.
4168 DEFUN now defines a static function. To make the function external
4169 so that it can be used in other C modules, use the new macro DEFUE.
4170 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4171 (Finit_image_library):
4172 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4173 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4174 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4175 Remove decls, since these functions are now static.
4176 (Funintern, Fget_internal_run_time): New decls, since these functions
4177 were already external.
4178
4179 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4180 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4181 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4182 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4183 * keyboard.c, keymap.c, lread.c:
4184 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4185 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4186 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4187 Mark functions with DEFUE instead of DEFUN,
4188 if they are used in other modules.
4189 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4190 decls for now-static functions.
4191 * buffer.h (Fdelete_overlay): Remove decl.
4192 * callproc.c (Fgetenv_internal): Mark as internal.
4193 * composite.c (Fremove_list_of_text_properties): Remove decl.
4194 (Fcomposition_get_gstring): New forward static decl.
4195 * composite.h (Fcomposite_get_gstring): Remove decl.
4196 * dired.c (Ffile_attributes): New forward static decl.
4197 * doc.c (Fdocumntation_property): New forward static decl.
4198 * eval.c (Ffetch_bytecode): New forward static decl.
4199 (Funintern): Remove extern decl; now in .h file where it belongs.
4200 * fileio.c (Fmake_symbolic_link): New forward static decl.
4201 * image.c (Finit_image_library): New forward static decl.
4202 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4203 * intervals.h (Fprevious_property_change):
4204 (Fremove_list_of_text_properties): Remove decls.
4205 * keyboard.c (Fthis_command_keys): Remove decl.
4206 (Fcommand_execute): New forward static decl.
4207 * keymap.c (Flookup_key): New forward static decl.
4208 (Fcopy_keymap): Now static.
4209 * keymap.h (Flookup_key): Remove decl.
4210 * process.c (Fget_process): New forward static decl.
4211 (Fprocess_datagram_address): Mark as internal.
4212 * syntax.c (Fsyntax_table_p): New forward static decl.
4213 (skip_chars): Remove duplicate decl.
4214 * textprop.c (Fprevious_property_change): New forward static decl.
4215 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4216 Now internal.
4217 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4218 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4219
4220 * editfns.c (Fformat): Remove unreachable code.
4221
4222 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4223
4224 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4225 change. (Bug#8496)
4226
4227 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4228
4229 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4230 when at ZV. (Bug#8487)
4231
4232 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4233
4234 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4235 (Bug#8437)
4236 * keyboard.c (parse_tool_bar_item): Likewise.
4237 * sound.c (sound_cleanup, alsa_close): Likewise.
4238 * termcap.c (tgetent): Likewise.
4239 * xfns.c (x_default_font_parameter): Likewise.
4240 * xsettings.c (read_and_apply_settings): Likewise.
4241
4242 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4243 (overrun_check_free): Protoize.
4244
4245 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4246
4247 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4248 since callers should never pass a negative size.
4249 Change the signature to match that of plain 'read' and 'write'; see
4250 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4251 * lisp.h: Update prototypes of emacs_write and emacs_read.
4252
4253 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4254
4255 * xdisp.c (redisplay_window): Don't try to determine the character
4256 position of the scroll margin if the window start point w->startp
4257 is outside the buffer's accessible region. (Bug#8468)
4258
4259 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4260
4261 Fix write-region and its subroutines for buffers > 2GB.
4262 * fileio.c (a_write, e_write): Modify declaration of arguments and
4263 local variables to support buffers larger than 2GB.
4264 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4265
4266 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4267 argument, local variables, and return value.
4268
4269 * lisp.h: Update prototypes of emacs_write and emacs_read.
4270
4271 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4272
4273 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4274
4275 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4276
4277 Fix more problems found by GCC 4.6.0's static checks.
4278
4279 * xdisp.c (vmessage): Use a better test for character truncation.
4280
4281 * charset.c (load_charset_map): <, not <=, for optimization,
4282 and to avoid potential problems with integer overflow.
4283 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4284 * casetab.c (set_identity, shuffle): Likewise.
4285 * editfns.c (Fformat): Likewise.
4286 * syntax.c (skip_chars): Likewise.
4287
4288 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4289 This also lets GCC 4.6.0 generate slightly better loop code.
4290
4291 * callint.c (Fcall_interactively): <, not <=, for optimization.
4292 (Fcall_interactively): Count the number of arguments produced,
4293 not the number of arguments given. This is simpler and lets GCC
4294 4.6.0 generate slightly better code.
4295
4296 * ftfont.c: Distingish more carefully between FcChar8 and char.
4297 The previous code passed unsigned char * to a functions like
4298 strlen and xstrcasecmp that expect char *, which does not
4299 conform to the C standard.
4300 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4301 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4302 char * when the C standard requires it.
4303
4304 * keyboard.c (read_char): Remove unused var.
4305
4306 * eval.c: Port to Windows vsnprintf (Bug#8435).
4307 Include <limits.h>.
4308 (SIZE_MAX): Define if the headers do not.
4309 (verror): Do not give up if vsnprintf returns a negative count.
4310 Instead, grow the buffer. This ports to Windows vsnprintf, which
4311 does not conform to C99. Problem reported by Eli Zaretskii.
4312 Also, simplify the allocation scheme, by avoiding the need for
4313 calling realloc, and removing the ALLOCATED variable.
4314
4315 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4316
4317 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4318 But keep the doprint source code for now, as we might revamp it
4319 and use it again (Bug#8435).
4320 * lisp.h (doprnt): Remove.
4321 * Makefile.in (base_obj): Remove doprnt.o.
4322 * deps.mk (doprnt.o): Remove.
4323
4324 error: Print 32- and 64-bit integers portably (Bug#8435).
4325 Without this change, on typical 64-bit hosts error ("...%d...", N)
4326 was used to print both 32- and 64-bit integers N, which relied on
4327 undefined behavior.
4328 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4329 New macro.
4330 * lisp.h (error, verror): Mark as printf-like functions.
4331 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4332 Report overflow in size calculations when allocating printf buffer.
4333 Do not truncate output string at its first null byte.
4334 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4335 Truncate the output at a character boundary, since vsnprintf does not
4336 do that.
4337 * charset.c (check_iso_charset_parameter): Convert internal
4338 character to string before calling 'error', since %c now has the
4339 printf meaning.
4340 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4341 overflow when computing char to be passed to 'error'. Do not
4342 pass Lisp_Object to 'error'; pass the integer instead.
4343 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4344 formatted with plain %d.
4345
4346 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4347
4348 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4349
4350 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4351
4352 * xterm.c (x_catch_errors): Remove duplicate declaration.
4353
4354 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4355
4356 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4357
4358 2011-04-10 Jim Meyering <meyering@redhat.com>
4359
4360 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4361 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4362 return ssize_t not "int", and use size_t as the buffer length.
4363 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4364 * gnutls.h: Update declarations.
4365 * process.c (read_process_output): Use ssize_t, to match.
4366 (send_process): Likewise.
4367
4368 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4369
4370 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4371
4372 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4373
4374 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4375 Use unsigned char, to match FcChar8 type definition.
4376
4377 * xterm.c (handle_one_xevent):
4378 * xmenu.c (create_and_show_popup_menu):
4379 * xselect.c (x_decline_selection_request)
4380 (x_reply_selection_request): Avoid type-punned deref of X events.
4381
4382 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4383
4384 Fix some uses of `int' instead of EMACS_INT.
4385 * search.c (string_match_1, fast_string_match)
4386 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4387 (scan_buffer, find_next_newline_no_quit)
4388 (find_before_next_newline, search_command, Freplace_match)
4389 (Fmatch_data): Make some `int' variables be EMACS_INT.
4390
4391 * xdisp.c (display_count_lines): 3rd argument and return value now
4392 EMACS_INT. All callers changed.
4393 (pint2hrstr): Last argument is now EMACS_INT.
4394
4395 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4396 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4397 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4398 (decode_coding_utf_16, decode_coding_emacs_mule)
4399 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4400 (decode_coding_ccl, decode_coding_charset)
4401 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4402 (decode_coding_iso_2022, decode_coding_emacs_mule)
4403 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4404 <char_offset, last_offset>: Declare EMACS_INT.
4405 (encode_coding_utf_8, encode_coding_utf_16)
4406 (encode_coding_emacs_mule, encode_invocation_designation)
4407 (encode_designation_at_bol, encode_coding_iso_2022)
4408 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4409 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4410 Declare EMACS_INT.
4411 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4412 (encode_invocation_designation): Last argument P_NCHARS is now
4413 EMACS_INT.
4414 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4415 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4416
4417 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4418 All users changed.
4419
4420 * ccl.c (Fccl_execute_on_string): Declare some variables
4421 EMACS_INT.
4422
4423 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4424
4425 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4426
4427 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4428
4429 * process.c (Fformat_network_address): Doc fix.
4430
4431 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4432
4433 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4434
4435 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4436
4437 * keyboard.c (read_char): Call Lisp function help-form-show,
4438 instead of using internal_with_output_to_temp_buffer.
4439 (Qhelp_form_show): New var.
4440 (syms_of_keyboard): Use DEFSYM macro.
4441
4442 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4443
4444 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4445
4446 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4447
4448 * process.c (Flist_processes): Remove to Lisp.
4449 (list_processes_1): Delete.
4450
4451 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4452
4453 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4454
4455 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4456
4457 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 Fix more problems found by GCC 4.6.0's static checks.
4460
4461 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4462
4463 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4464
4465 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4466
4467 * xdisp.c (vmessage): Mark as a printf-like function.
4468
4469 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4470
4471 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4472
4473 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4474 printf-like functions.
4475 (tiff_load): Add casts to remove these marks before passing them
4476 to system-supplied API.
4477
4478 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4479
4480 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4481 This avoids several warnings with gcc -Wstrict-overflow.
4482 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4483 directly, rather than having caller test rule sign. This avoids
4484 some unnecessary tests.
4485 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4486 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4487 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4488
4489 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4490 (xfont_open): Avoid unnecessary tests.
4491
4492 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4493
4494 * composite.h, composite.c (composition_gstring_put_cache):
4495 Use EMACS_INT, not int, for length.
4496
4497 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4498 breaking out part of COMPOSITION_DECODE_RULE.
4499 (COMPOSITION_DECODE_RULE): Use it.
4500 * composite.c (get_composition_id): Remove unused local vars,
4501 by using the new macro.
4502
4503 * textprop.c (set_text_properties_1): Change while to do-while,
4504 since the condition is always true at first.
4505
4506 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4507 (interval_deletion_adjustment): Return unsigned value.
4508 All uses changed.
4509
4510 * process.c (list_processes_1, create_pty, read_process_output):
4511 (exec_sentinel): Remove vars that were set but not used.
4512 (create_pty): Remove unnecessary "volatile"s.
4513 (Fnetwork_interface_info): Avoid possibility of int overflow.
4514 (read_process_output): Do adaptive read buffering even if carryover.
4515 (read_process_output): Simplify nbytes computation if buffered.
4516
4517 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4518
4519 * syntax.c (scan_words): Remove var that was set but not used.
4520 (update_syntax_table): Use unsigned instead of int.
4521
4522 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4523 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4524 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4525
4526 * print.c (print_error_message): Avoid int overflow.
4527
4528 * font.c (font_list_entities): Redo for clarity,
4529 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4530
4531 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4532 (font_score): Avoid potential overflow in diff calculation.
4533
4534 * fns.c (substring_both): Remove var that is set but not used.
4535 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4536
4537 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4538
4539 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4540 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4541 can always succeed if overflow has undefined behavior.
4542
4543 * search.c (boyer_moore, wordify): Remove vars set but not used.
4544 (wordify): Omit three unnecessary tests.
4545
4546 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4547 All callers changed. This avoids the need for an unused var.
4548
4549 * casefiddle.c (casify_region): Remove var that is set but not used.
4550
4551 * dired.c (file_name_completion): Remove var that is set but not used.
4552
4553 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4554
4555 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4556 (Finsert_file_contents): Remove unnecessary code checking fd.
4557
4558 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4559 Check for integer overflow on size calculations.
4560
4561 * buffer.c (Fprevious_overlay_change): Remove var that is set
4562 but not used.
4563
4564 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4565 Remove vars that are set but not used.
4566 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4567 (timer_check_2): Mark vars as initialized.
4568
4569 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4570
4571 * image.c (lookup_image): Remove var that is set but not used.
4572 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4573
4574 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4575 that are set but not used.
4576
4577 * xfns.c (make_invisible_cursor): Don't return garbage
4578 if XCreateBitmapFromData fails (Bug#8410).
4579
4580 * xselect.c (x_get_local_selection, x_handle_property_notify):
4581 Remove vars that are set but not used.
4582
4583 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4584 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4585
4586 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4587 Remove var that is set but not used.
4588 (scroll_bar_windows_size): Now size_t, not int.
4589 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4590 Check for overflow.
4591
4592 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4593 (map_tty_color) [!defined MSDOS]: Likewise.
4594
4595 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4596
4597 * coding.c: Remove vars that are set but not used.
4598 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4599 All callers changed.
4600 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4601 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4602 (decode_coding_charset): Remove vars that are set but not used.
4603
4604 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4605 that is set but not used.
4606
4607 * print.c (print_object): Remove var that is set but not used.
4608
4609 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4610 The gnulib version avoids calling malloc in the usual case,
4611 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4612 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4613 * filelock.c (current_lock_owner): Likewise.
4614 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4615 * sysdep.c: Include allocator.h, careadlinkat.h.
4616 (emacs_no_realloc_allocator): New static constant.
4617 (emacs_readlink): New function.
4618 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4619 ../lib/careadlinkat.h.
4620
4621 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4622
4623 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4624 first non-nil return value).
4625
4626 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4627
4628 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4629 if not defined (Bug#8403).
4630
4631 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * xdisp.c (display_count_lines): Remove parameter `start',
4634 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4635 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4636 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4637 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4638 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4639 and thereabouts. All callers changed.
4640 (get_per_char_metric): Remove parameter `f', unused since
4641 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4642
4643 2011-04-02 Jim Meyering <meyering@redhat.com>
4644
4645 do not dereference NULL upon failed strdup
4646 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4647 (ns_get_family): Likewise.
4648
4649 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4650
4651 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4652
4653 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4654
4655 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4656 later (Bug#8403).
4657
4658 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4659
4660 Add lexical binding.
4661
4662 * window.c (Ftemp_output_buffer_show): New fun.
4663 (Fsave_window_excursion):
4664 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4665
4666 * lread.c (lisp_file_lexically_bound_p): New function.
4667 (Fload): Bind Qlexical_binding.
4668 (readevalloop): Remove `evalfun' arg.
4669 Bind Qinternal_interpreter_environment.
4670 (Feval_buffer): Bind Qlexical_binding.
4671 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4672 Mark as dynamic.
4673 (syms_of_lread): Declare `lexical-binding'.
4674
4675 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4676
4677 * keyboard.c (eval_dyn): New fun.
4678 (menu_item_eval_property): Use it.
4679
4680 * image.c (parse_image_spec): Use Ffunctionp.
4681
4682 * fns.c (concat, mapcar1): Accept byte-code-functions.
4683
4684 * eval.c (Fsetq): Handle lexical vars.
4685 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4686 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4687 (FletX, Flet): Obey lexical binding.
4688 (Fcommandp): Handle closures.
4689 (Feval): New `lexical' arg.
4690 (eval_sub): New function extracted from Feval. Use it almost
4691 everywhere where Feval was used. Look up vars in lexical env.
4692 Handle closures.
4693 (Ffunctionp): Move from subr.el.
4694 (Ffuncall): Handle closures.
4695 (apply_lambda): Remove `eval_flags'.
4696 (funcall_lambda): Handle closures and new byte-code-functions.
4697 (Fspecial_variable_p): New function.
4698 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4699 but without exporting it to Lisp.
4700
4701 * doc.c (Fdocumentation, store_function_docstring):
4702 * data.c (Finteractive_form): Handle closures.
4703
4704 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4705 interactive spec.
4706
4707 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4708 New byte-codes.
4709 (exec_byte_code): New function extracted from Fbyte_code to handle new
4710 calling convention for byte-code-functions. Add new byte-codes.
4711
4712 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4713
4714 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4715
4716 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4717
4718 * xdisp.c (redisplay_internal): Fix prototype.
4719
4720 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4721
4722 * xdisp.c (SCROLL_LIMIT): New macro.
4723 (try_scrolling): Use it when setting scroll_limit.
4724 Limit scrolling to 100 screen lines.
4725 (redisplay_window): Even when falling back on "recentering",
4726 position point in the window according to scroll-conservatively,
4727 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4728
4729 (try_scrolling): When point is above the window, allow searching
4730 as far as scroll_max, or one screenful, to compute vertical
4731 distance from PT to the scroll margin position. This prevents
4732 try_scrolling from unnecessarily failing when
4733 scroll-conservatively is set to a value slightly larger than the
4734 window height. Clean up the case of PT below the margin at bottom
4735 of window: scroll_max can no longer be INT_MAX. When aggressive
4736 scrolling is in use, don't let point enter the opposite scroll
4737 margin as result of the scroll.
4738 (syms_of_xdisp) <scroll-conservatively>: Document the
4739 threshold of 100 lines for never-recentering scrolling.
4740
4741 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * dispextern.h (move_it_by_lines):
4744 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4745 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4746 (message_log_check_duplicate): Remove parameters `prev_bol' and
4747 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4748 (redisplay_internal): Remove parameter `preserve_echo_area',
4749 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4750
4751 * indent.c (Fvertical_motion):
4752 * window.c (window_scroll_pixel_based, Frecenter):
4753 Don't pass `need_y_p' to `move_it_by_lines'.
4754
4755 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4756
4757 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4758 steal a few bits to be more compact.
4759 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4760 Remove unneeded casts.
4761
4762 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4763
4764 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4765
4766 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4767 binding" message (bug#7967).
4768
4769 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 Fix more problems found by GCC 4.6.0's static checks.
4772
4773 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4774 Remove unused local var.
4775
4776 * editfns.c (Fmessage_box): Remove unused local var.
4777
4778 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4779 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4780 Omit unused local vars.
4781 * window.c (shrink_windows): Omit unused local var.
4782 * menu.c (digest_single_submenu): Omit unused local var.
4783 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4784 Omit unused local var.
4785
4786 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4787 Don't assume string length fits in int.
4788 (keyremap_step, read_key_sequence): Use size_t for sizes.
4789 (read_key_sequence): Don't check last_real_key_start redundantly.
4790
4791 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4792 instead of alloca (Bug#8344).
4793
4794 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4795 (Fbacktrace_frame): Don't assume nframes fits in int.
4796
4797 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4798
4799 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4800 concerns.
4801
4802 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4803
4804 * cm.c (calccost): Turn while-do into do-while, for clarity.
4805
4806 * keyboard.c (syms_of_keyboard): Use the same style as later
4807 in this function when indexing through an array. This also
4808 works around GCC bug 48267.
4809
4810 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4811
4812 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4813
4814 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4815 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4816
4817 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4818 This avoids undefined behavior on integer overflow, and is a bit
4819 more convenient anyway since it is compared to a size_t variable.
4820
4821 Variadic C functions now count arguments with size_t, not int.
4822 This avoids an unnecessary limitation on 64-bit machines, which
4823 caused (substring ...) to crash on large vectors (Bug#8344).
4824 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4826 All variadic functions and their callers changed accordingly.
4827 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4828 * data.c (arith_driver, float_arith_driver): Likewise.
4829 * editfns.c (general_insert_function): Likewise.
4830 * eval.c (struct backtrace.nargs, interactive_p)
4831 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4832 (funcall_lambda, mark_backtrace): Likewise.
4833 * fns.c (concat): Likewise.
4834 * frame.c (x_set_frame_parameters): Likewise.
4835 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4836 0 if not found, not -1. All callers changed.
4837
4838 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4839 (stack_copy_size): Now size_t, not int.
4840 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4841
4842 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4845 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4846 All callers changed.
4847
4848 * lisp.h (multibyte_char_to_unibyte):
4849 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4850 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4851 * character.h (CHAR_TO_BYTE8):
4852 * cmds.c (internal_self_insert):
4853 * editfns.c (general_insert_function):
4854 * keymap.c (push_key_description):
4855 * search.c (Freplace_match):
4856 * xdisp.c (message_dolog, set_message_1): All callers changed.
4857
4858 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4859
4860 * keyboard.c (safe_run_hook_funcall): New function.
4861 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4862 don't set the hook to nil, but remove the offending function instead.
4863 (Qcommand_hook_internal): Remove, unused.
4864 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4865 Vcommand_hook_internal.
4866
4867 * eval.c (enum run_hooks_condition): Remove.
4868 (funcall_nil, funcall_not): New functions.
4869 (run_hook_with_args): Call each function through a `funcall' argument.
4870 Remove `cond' argument, now redundant.
4871 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4872 (Frun_hook_with_args_until_failure): Adjust accordingly.
4873 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4874
4875 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * dispextern.h (string_buffer_position): Remove declaration.
4878
4879 * print.c (strout): Remove parameter `multibyte', unused since
4880 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4881
4882 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4883 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4884 All callers changed.
4885
4886 * w32.c (_wsa_errlist): Use braces for struct initializers.
4887
4888 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4889 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4890 All callers changed.
4891 (string_buffer_position): Likewise. Also, make static (it's never
4892 used outside xdisp.c).
4893 (cursor_row_p): Remove parameter `w', unused since
4894 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4895 (decode_mode_spec): Remove parameter `precision', introduced during
4896 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4897 All callers changed.
4898
4899 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4900
4901 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4902
4903 2011-03-27 Anders Lindgren <andlind@gmail.com>
4904
4905 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4906 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4907 (ns_update_auto_hide_menu_bar): New functions.
4908 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4909 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4910 ns_constrain_all_frames.
4911 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4912 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4913
4914 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4915
4916 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4917
4918 2011-03-27 Glenn Morris <rgm@gnu.org>
4919
4920 * syssignal.h: Replace RETSIGTYPE with void.
4921 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4922 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4923 Replace SIGTYPE with void everywhere.
4924 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4925 * s/template.h (SIGTYPE): Remove commented out definition.
4926
4927 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4928
4929 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4930 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4931
4932 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * w32.c (read_unc_volume): Use parameter `henum', instead of
4935 global variable `wget_enum_handle'.
4936
4937 * keymap.c (describe_vector): Remove parameters `indices' and
4938 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4939 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4940
4941 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4942
4943 * keyboard.c (timer_check): Remove parameter `do_it_now',
4944 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4945 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4946 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4947
4948 * keyboard.c (read_char):
4949 * w32menu.c (w32_menu_display_help):
4950 * xmenu.c (show_help_event, menu_help_callback):
4951 Adjust calls to `show_help_echo'.
4952
4953 * gtkutil.c (xg_maybe_add_timer):
4954 * keyboard.c (readable_events):
4955 * process.c (wait_reading_process_output):
4956 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4957
4958 * insdel.c (adjust_markers_gap_motion):
4959 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4960 (gap_left, gap_right): Don't call it.
4961
4962 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4963
4964 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4965 incurred during fontification.
4966
4967 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4968
4969 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4970 (DEFVAR_PER_BUFFER): Don't pass it.
4971
4972 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4973 (scrolling_window): Don't pass it.
4974
4975 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4978
4979 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4980 and `suffix'.
4981 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4982 of variables specific to SELinux and computation of `encoded_absname'.
4983
4984 * image.c (XPutPixel): Remove unused variable `height'.
4985
4986 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4987
4988 * unexw32.c (get_section_info): Remove unused variable `section'.
4989
4990 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4991 (system_process_attributes): Remove unused variable `sess'.
4992 (sys_read): Remove unused variable `err'.
4993
4994 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4995 (w32_wnd_proc): Remove unused variable `isdead'.
4996 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4997 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4998 (x_create_tip_frame): Remove unused variable `tem'.
4999
5000 * w32inevt.c (w32_console_read_socket):
5001 Remove unused variable `no_events'.
5002
5003 * w32term.c (x_draw_composite_glyph_string_foreground):
5004 Remove unused variable `width'.
5005
5006 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5007
5008 * w32term.c (x_set_glyph_string_clipping):
5009 Don't pass uninitialized region to CombineRgn.
5010
5011 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5014 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5015 (Fx_close_connection): Remove unused variable `i'.
5016
5017 * w32font.c (w32font_draw): Return number of glyphs.
5018 (w32font_open_internal): Remove unused variable `i'.
5019 (w32font_driver): Add missing initializer.
5020
5021 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5022 (fill_in_menu): Remove unused variable `items_added'.
5023
5024 * w32term.c (last_mouse_press_frame): Remove static global variable.
5025 (w32_clip_to_row): Remove unused variable `f'.
5026 (x_delete_terminal): Remove unused variable `i'.
5027
5028 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5029 (NOTHING): Remove unused static global variable.
5030 (uniscribe_check_otf): Remove unused variable `table'.
5031 (uniscribe_font_driver): Add missing initializers.
5032
5033 2011-03-23 Julien Danjou <julien@danjou.info>
5034
5035 * term.c (Fsuspend_tty, Fresume_tty):
5036 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5037 * window.c (temp_output_buffer_show):
5038 * insdel.c (signal_before_change):
5039 * frame.c (Fhandle_switch_frame):
5040 * fileio.c (Fdo_auto_save):
5041 * emacs.c (Fkill_emacs):
5042 * editfns.c (save_excursion_restore):
5043 * cmds.c (internal_self_insert):
5044 * callint.c (Fcall_interactively):
5045 * buffer.c (Fkill_all_local_variables):
5046 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5047 Use Frun_hooks.
5048 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5049 unconditionnaly since it does the check itself.
5050
5051 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 Fix more problems found by GCC 4.5.2's static checks.
5054
5055 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5056 the first time through the loop, since we know p0 < p1 then.
5057 This also avoids a gcc -Wstrict-overflow warning.
5058
5059 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5060 leading to a memory leak, possible in functions like
5061 load_charset_map_from_file that can allocate an unbounded number
5062 of objects (Bug#8318).
5063
5064 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5065 that could (at least in theory) be that large.
5066
5067 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5068 This is less likely to overflow, and avoids undefined behavior if
5069 overflow does occur. All callers changed. Use strtoul to scan
5070 for the unsigned long integer.
5071 (pint2hrstr): Simplify and tune code slightly.
5072 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5073
5074 * scroll.c (do_scrolling): Work around GCC bug 48228.
5075 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5076
5077 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5078 This also avoids a warning with gcc -Wstrict-overflow.
5079 (validate_x_resource_name): Simplify count usage.
5080 This also avoids a warning with gcc -Wstrict-overflow.
5081
5082 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5083 fail (Bug#8306).
5084
5085 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5086
5087 * process.c (Fmake_network_process): Use socklen_t, not int,
5088 where POSIX says socklen_t is required in portable programs.
5089 This fixes a porting bug on hosts like 64-bit HP-UX, where
5090 socklen_t is wider than int (Bug#8277).
5091 (Fmake_network_process, server_accept_connection):
5092 (wait_reading_process_output, read_process_output):
5093 Likewise.
5094
5095 * process.c: Rename or move locals to avoid shadowing.
5096 (list_processes_1, Fmake_network_process):
5097 (read_process_output_error_handler, exec_sentinel_error_handler):
5098 Rename or move locals.
5099 (Fmake_network_process): Define label "retry_connect" only if needed.
5100 (Fnetwork_interface_info): Fix pointer signedness.
5101 (process_send_signal): Add cast to avoid pointer signedness problem.
5102 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5103 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5104
5105 Make tparam.h and terminfo.c consistent.
5106 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5107 Include tparam.h instead, since it declares them.
5108 * cm.h (PC): Remove extern decl; tparam.h now does this.
5109 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5110 * terminfo.c: Include tparam.h, to check interfaces.
5111 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5112 (tparam): Adjust signature to match interface in tparam.h;
5113 this removes some undefined behavior. Check that outstring and len
5114 are zero, which they always are with Emacs.
5115 * tparam.h (PC, BC, UP): New extern decls.
5116
5117 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5118 (xftfont_open): Rename locals to avoid shadowing.
5119
5120 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5121 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5122 (OTF_TAG_SYM): Omit macro if not needed.
5123 (ftfont_list): Remove unused local.
5124 (get_adstyle_property, ftfont_pattern_entity):
5125 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5126 Rename locals to avoid shadowing.
5127
5128 * xfont.c (xfont_list_family): Mark var as initialized.
5129
5130 * xml.c (make_dom): Now static.
5131
5132 * composite.c (composition_compute_stop_pos): Rename local to
5133 avoid shadowing.
5134 (composition_reseat_it): Remove unused locals.
5135 (find_automatic_composition, composition_adjust_point): Likewise.
5136 (composition_update_it): Mark var as initialized.
5137 (find_automatic_composition): Mark vars as initialized,
5138 with a FIXME (Bug#8290).
5139
5140 character.h: Rename locals to avoid shadowing.
5141 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5142 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5143 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5144 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5145 to avoid shadowing.
5146
5147 * textprop.c (property_change_between_p): Remove; unused.
5148
5149 * intervals.c (interval_start_pos): Now static.
5150
5151 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5152
5153 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5154 Rename locals to avoid shadowing.
5155
5156 * sound.c (wav_play, au_play, Fplay_sound_internal):
5157 Fix pointer signedness.
5158 (alsa_choose_format): Remove unused local var.
5159 (wav_play): Initialize a variable to 0, to prevent undefined
5160 behavior (Bug#8278).
5161
5162 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5163
5164 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5165
5166 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5167 clobbering (Bug#8298).
5168 * sysdep.c (sys_subshell): Likewise.
5169 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5170
5171 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5172 This should get cleaned up, so that child_setup has the
5173 same signature on all platforms.
5174
5175 * callproc.c (call_process_cleanup): Now static.
5176 (relocate_fd): Rename locals to avoid shadowing.
5177
5178 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5179
5180 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5181 not to be necessary, and produces flickering.
5182
5183 2011-03-20 Glenn Morris <rgm@gnu.org>
5184
5185 * config.in: Remove file.
5186
5187 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5190 are now in src/globals.h.
5191 (syms_of_minibuf): Remove spurious & from previous change.
5192
5193 2011-03-20 Leo <sdl.web@gmail.com>
5194
5195 * minibuf.c (completing-read-function): New variable.
5196 (completing-read-default): Rename from completing-read.
5197 (completing-read): Call completing-read-function.
5198
5199 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * xfaces.c (Fx_load_color_file):
5202 Read color file from absolute filename (bug#8250).
5203
5204 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5205
5206 * makefile.w32-in: Update dependencies.
5207
5208 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5209
5210 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5211
5212 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5213
5214 Fix more problems found by GCC 4.5.2's static checks.
5215
5216 * process.c (make_serial_process_unwind, send_process_trap):
5217 (sigchld_handler): Now static.
5218
5219 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5220 That way, the code declares only the vars that it needs.
5221 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5222 * s/cygwin.h (PTY_ITERATION): Likewise.
5223 * s/darwin.h (PTY_ITERATION): Likewise.
5224 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5225
5226 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5227 * process.c (allocate_pty): Don't declare stb unless it's needed.
5228
5229 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5230 (CONSTANTLIM): Remove; unused.
5231 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5232 Define only if needed.
5233
5234 * unexelf.c (unexec): Name an expression,
5235 to avoid gcc -Wbad-function-cast warning.
5236 Use a different way to cause a compilation error if anyone uses
5237 n rather than nn, a way that does not involve shadowing.
5238 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5239
5240 * deps.mk (unexalpha.o): Remove; unused.
5241
5242 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5243 * unexec.h: New file.
5244 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5245 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5246 Depend on unexec.h.
5247 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5248 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5249 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5250 Change as necessary to match prototype in unexec.h.
5251
5252 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5253 shadowing.
5254 (back_comment, skip_chars): Mark vars as initialized.
5255
5256 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5257 Rename locals to avoid shadowing.
5258
5259 * lread.c (read1): Rewrite so as not to use empty "else".
5260 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5261
5262 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5263
5264 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5265 warning when compiling print.c.
5266
5267 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5268 instead of using an uninitialized var.
5269 (font_sort_entities): Mark var as initialized.
5270
5271 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5272
5273 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5274 pointers to constants.
5275 (font_parse_fcname): Remove unused vars.
5276 (font_delete_unmatched): Now static.
5277 (font_get_spec): Remove; unused.
5278 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5279 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5280 Rename or move locals to avoid shadowing.
5281
5282 * fns.c (require_nesting_list, require_unwind): Now static.
5283 (Ffillarray): Rename locals to avoid shadowing.
5284
5285 * floatfns.c (domain_error2): Define only if needed.
5286 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5287
5288 * alloc.c (mark_backtrace): Move decl from here ...
5289 * lisp.h: ... to here, so that it can be checked.
5290
5291 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5292 (Fdefvar): Rewrite so as not to use empty "else".
5293 (lisp_indirect_variable): Name an expression,
5294 to avoid gcc -Wbad-function-cast warning.
5295 (Fdefvar): Rename locals to avoid shadowing.
5296
5297 * callint.c (quotify_arg, quotify_args): Now static.
5298 (Fcall_interactively): Rename locals to avoid shadowing.
5299 Use const pointer when appropriate.
5300
5301 * lisp.h (get_system_name, get_operating_system_release):
5302 Move decls here, to check interfaces.
5303 * process.c (get_operating_system_release): Move decl to lisp.h.
5304 * xrdb.c (get_system_name): Likewise.
5305 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5306 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5307 some of which prompt warnings from gcc -Wbad-function-cast.
5308 (Fformat_time_string, Fencode_time, Finsert_char):
5309 (Ftranslate_region_internal, Fformat):
5310 Rename or remove local vars to avoid shadowing.
5311 (Ftranslate_region_internal): Mark var as initialized.
5312
5313 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5314 avoid shadowing.
5315
5316 * lisp.h (eassert): Check that the argument compiles, even if
5317 ENABLE_CHECKING is not defined.
5318
5319 * data.c (Findirect_variable): Name an expression, to avoid
5320 gcc -Wbad-function-cast warning.
5321 (default_value, arithcompare, arith_driver, arith_error): Now static.
5322 (store_symval_forwarding): Rename local to avoid shadowing.
5323 (Fmake_variable_buffer_local, Fmake_local_variable):
5324 Mark variables as initialized.
5325 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5326
5327 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5328 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5329 Rename locals to avoid shadowing.
5330 (mark_stack): Move local variables into the #ifdef region where
5331 they're used.
5332 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5333 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5334 needed otherwise.
5335 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5336 (GC_STRING_CHARS): Remove; not used.
5337 (Fmemory_limit): Cast sbrk's returned value to char *.
5338
5339 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5340 avoids undefined behavior in theory.
5341
5342 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5343
5344 Use functions, not macros, for up- and down-casing (Bug#8254).
5345 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5346 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5347 to use the following functions instead of these macros.
5348 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5349 EMACS_INT, since callers assume the returned value fits in int.
5350 (upcase1): Likewise, for UPCASE_TABLE.
5351 (uppercasep, lowercasep, upcase): New static inline functions.
5352 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5353 the race-condition problem in the old DOWNCASE.
5354
5355 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5356 Rename locals to avoid shadowing.
5357 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5358 (regex_compile, re_search_2, re_match_2_internal):
5359 Remove unused local vars.
5360 (FREE_VAR): Rewrite so as not to use empty "else",
5361 which gcc can warn about.
5362 (regex_compile, re_match_2_internal): Mark locals as initialized.
5363 (RETALLOC_IF): Define only if needed.
5364 (WORDCHAR_P): Likewise. This one is never needed, but is used
5365 only in a comment talking about a compiler bug, so put inside
5366 the #if 0 of that comment.
5367 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5368 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5369 Remove; unused.
5370
5371 * search.c (boyer_moore): Rename locals to avoid shadowing.
5372 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5373 (PREV_CHAR_BOUNDARY): Likewise.
5374
5375 * search.c (simple_search): Remove unused var.
5376
5377 * dired.c (compile_pattern): Move decl from here ...
5378 * lisp.h: ... to here, so that it can be checked.
5379 (struct re_registers): New forward decl.
5380
5381 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5382
5383 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5384 All uses changed.
5385 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5386 Rename locals to avoid shadowing.
5387 (Fvertical_motion): Mark locals as initialized.
5388
5389 * casefiddle.c (casify_object, casify_region): Now static.
5390 (casify_region): Mark local as initialized.
5391
5392 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5393
5394 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5395 New macros, so that the caller can use some names other than
5396 gcpro1, gcpro2, etc.
5397 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5398 of the new macros.
5399 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5400 argument, for consistency with GCPRO2_VAR, etc: it is now the
5401 prefix of the variable, not the variable itself. All uses
5402 changed.
5403 * dired.c (directory_files_internal, file_name_completion):
5404 Rename locals to avoid shadowing.
5405
5406 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5407 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5408 dired.c's scmp function, had undefined behavior.
5409 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5410 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5411 * buffer.h: ... to here, because these macros use current_buffer,
5412 and the new implementation with inline functions needs to have
5413 current_buffer in scope now, rather than later when the macros
5414 are used.
5415 (downcase, upcase1): New static inline functions.
5416 (DOWNCASE, UPCASE1): Reimplement using these functions.
5417 This avoids undefined behavior in expressions like
5418 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5419 from race conditions in accessing the global variables
5420 case_temp1 and case_temp2.
5421 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5422 * lisp.h (case_temp1, case_temp2): Remove their decls.
5423 * character.h (ASCII_CHAR_P): Move from here ...
5424 * lisp.h: ... to here, so that the inline functions mentioned
5425 above can use them.
5426
5427 * dired.c (directory_files_internal_unwind): Now static.
5428
5429 * fileio.c (file_name_as_directory, directory_file_name):
5430 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5431 Now static.
5432 (file_name_as_directory): Use const pointers when appropriate.
5433 (Fexpand_file_name): Likewise. In particular, newdir might
5434 point at constant storage, so make it a const pointer.
5435 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5436 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5437 signedness issues.
5438 (Fset_file_times, Finsert_file_contents, auto_save_error):
5439 Rename locals to avoid shadowing.
5440
5441 * minibuf.c (choose_minibuf_frame_1): Now static.
5442 (Ftry_completion, Fall_completions): Rename or remove locals
5443 to avoid shadowing.
5444
5445 * marker.c (bytepos_to_charpos): Remove; unused.
5446
5447 * lisp.h (verify_bytepos, count_markers): New decls,
5448 so that gcc does not warn that these functions aren't declared.
5449
5450 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5451 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5452 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5453 (copy_text): Remove unused local var.
5454
5455 * filelock.c (within_one_second): Now static.
5456 (lock_file_1): Rename local to avoid shadowing.
5457
5458 * buffer.c (fix_overlays_before): Mark locals as initialized.
5459 (fix_start_end_in_overlays): Likewise. This function should be
5460 simplified by using pointers-to-pointers, but that's a different
5461 matter.
5462 (switch_to_buffer_1): Now static.
5463 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5464 (report_overlay_modification): Rename locals to avoid shadowing.
5465
5466 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5467 Fix pointer signedness issue.
5468 (sys_subshell): Mark local as volatile if checking for lint,
5469 to suppress a gcc -Wclobbered warning that does not seem to be right.
5470 (MAXPATHLEN): Define only if needed.
5471
5472 * process.c (serial_open, serial_configure): Move decls from here ...
5473 * systty.h: ... to here, so that they can be checked.
5474
5475 * fns.c (get_random, seed_random): Move extern decls from here ...
5476 * lisp.h: ... to here, so that they can be checked.
5477
5478 * sysdep.c (reset_io): Now static.
5479 (wait_for_termination_signal): Remove; unused.
5480
5481 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5482 (copy_keymap_item, append_key, push_text_char_description):
5483 Now static.
5484 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5485 (DENSE_TABLE_SIZE): Remove; unused.
5486 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5487 (describe_map_tree):
5488 Rename locals to avoid shadowing.
5489
5490 * keyboard.c: Declare functions static if they are not used elsewhere.
5491 (echo_char, echo_dash, cmd_error, top_level_2):
5492 (poll_for_input, handle_async_input): Now static.
5493 (read_char, kbd_buffer_get_event, make_lispy_position):
5494 (make_lispy_event, make_lispy_movement, apply_modifiers):
5495 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5496 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5497 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5498 (read_key_sequence, read_char): Mark locals as initialized.
5499 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5500
5501 * keyboard.h (make_ctrl_char): New decl.
5502 (mark_kboards): Move decl here ...
5503 * alloc.c (mark_kboards): ... from here.
5504
5505 * lisp.h (force_auto_save_soon): New decl.
5506
5507 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5508 (DEFINE_DUMMY_FUNCTION): New macro.
5509 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5510 Use it.
5511 (main): Add casts to avoid warnings
5512 if GCC considers string literals to be constants.
5513
5514 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5515
5516 * dbusbind.c: Pointer signedness fixes.
5517 (xd_signature, xd_append_arg, xd_initialize):
5518 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5519 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5520 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5521 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5522
5523 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5524 if GCC considers string literals to be constants.
5525 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5526
5527 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5528
5529 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5530 (print_preprocess, print_object): New macro to fix last change.
5531
5532 * print.c (print_preprocess): Don't forget font objects.
5533
5534 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5535
5536 * emacs.c (USAGE3): Doc fixes.
5537
5538 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5539
5540 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5541 structure.
5542
5543 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * lisp.h (VWindow_system, Qfile_name_history):
5546 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5547 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5548 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5549
5550 * w32select.c: Don't #include "keyboard.h".
5551 (run_protected): Add extern declaration for waiting_for_input.
5552
5553 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5554 * w32console.c (detect_input_pending, read_input_pending)
5555 (encode_terminal_code):
5556 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5557 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5558 (w32_system_caret_y, Qfile_name_history):
5559 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5560 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5561 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5562 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5563 * w32proc.c (Qlocal, report_file_error):
5564 * w32term.c (Vwindow_system, updating_frame):
5565 * w32uniscribe.c (initialized, uniscribe_font_driver):
5566 Remove unneeded extern declarations.
5567
5568 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5569
5570 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5571
5572 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5573
5574 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5575 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5576 These macros can no longer be used for assignment.
5577
5578 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5579 Assign struct members directly, instead of using BUF_BEGV etc.
5580 (record_buffer_markers, fetch_buffer_markers): New functions for
5581 recording and fetching special buffer markers.
5582 (set_buffer_internal_1, set_buffer_temp): Use them.
5583
5584 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5585
5586 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5587
5588 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5589 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5590
5591 * xdisp.c (hscroll_window_tree):
5592 (reconsider_clip_changes): Use PT instead of BUF_PT.
5593
5594 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5595
5596 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5597 $(EMACS_ROOT)/lib/intprops.h.
5598
5599 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5600
5601 Fix more problems found by GCC 4.5.2's static checks.
5602
5603 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5604 to unsigned char * to avoid compiler diagnostic.
5605 (xg_free_frame_widgets): Make it clear that a local variable is
5606 needed only if USE_GTK_TOOLTIP.
5607 (gdk_window_get_screen): Make it clear that this macro is needed
5608 only if USE_GTK_TOOLTIP.
5609 (int_gtk_range_get_value): New function, which avoids a diagnostic
5610 from gcc -Wbad-function-cast.
5611 (xg_set_toolkit_scroll_bar_thumb): Use it.
5612 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5613 diagnostic from gcc -Wbad-function-cast.
5614 (get_utf8_string, xg_get_file_with_chooser):
5615 Rename locals to avoid shadowing.
5616 (create_dialog): Move locals to avoid shadowing.
5617
5618 * xgselect.c (xg_select): Remove unused var.
5619
5620 * image.c (four_corners_best): Mark locals as initialized.
5621 (gif_load): Initialize transparent_p to zero (Bug#8238).
5622 Mark another local as initialized.
5623 (my_png_error, my_error_exit): Mark with NO_RETURN.
5624
5625 * image.c (clear_image_cache): Now static.
5626 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5627 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5628 (x_edge_detection): Remove unnecessary cast that
5629 gcc -Wbad-function-cast diagnoses.
5630 (gif_load): Fix pointer signedness.
5631 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5632 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5633
5634 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5635
5636 Improve quality of tests for time stamp overflow.
5637 For example, without this patch (encode-time 0 0 0 1 1
5638 1152921504606846976) returns the obviously-bogus value (-948597
5639 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5640 reports time overflow. See
5641 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5642 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5643 * editfns.c: Include limits.h and intprops.h.
5644 (TIME_T_MIN, TIME_T_MAX): New macros.
5645 (time_overflow): Move earlier, to before first use.
5646 (hi_time, lo_time): New functions, for an accurate test for
5647 out-of-range times.
5648 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5649 (Fget_internal_run_time): Don't assume time_t fits in int.
5650 (make_time): Use list2 instead of Fcons twice.
5651 (Fdecode_time): More accurate test for out-of-range times.
5652 (check_tm_member): New function.
5653 (Fencode_time): Use it, to test for out-of-range times.
5654 (lisp_time_argument): Don't rely on undefined left-shift and
5655 right-shift behavior when checking for time stamp overflow.
5656
5657 * editfns.c (time_overflow): New function, refactoring common code.
5658 (Fformat_time_string, Fdecode_time, Fencode_time):
5659 (Fcurrent_time_string): Use it.
5660
5661 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5662 * dired.c (make_time): Move to ...
5663 * editfns.c (make_time): ... here.
5664 * systime.h: Note the move.
5665
5666 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5667
5668 * fringe.c (update_window_fringes): Remove unused variables.
5669
5670 * unexmacosx.c (copy_data_segment): Also copy __got section.
5671 (Bug#8223)
5672
5673 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5674
5675 * termcap.c [MSDOS]: Include "msdos.h".
5676 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5677 Constify `char *' arguments and their references according to
5678 prototypes in tparam.h.
5679
5680 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5681
5682 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5683 Adapt all references accordingly.
5684
5685 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5686
5687 2011-03-11 Tom Tromey <tromey@redhat.com>
5688
5689 * buffer.c (syms_of_buffer): Remove obsolete comment.
5690
5691 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5692
5693 * termhooks.h (encode_terminal_code): Declare prototype.
5694
5695 * msdos.c (encode_terminal_code): Don't declare prototype.
5696
5697 * term.c (encode_terminal_code): Now external again, used by
5698 w32console.c and msdos.c.
5699
5700 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5701 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5702
5703 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5704
5705 Fix some minor problems found by GCC 4.5.2's static checks.
5706
5707 * fringe.c (update_window_fringes): Mark locals as initialized
5708 (Bug#8227).
5709 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5710
5711 * alloc.c (mark_fringe_data): Move decl from here ...
5712 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5713 to check its interface.
5714 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5715
5716 * fontset.c (free_realized_fontset): Now static.
5717 (Fset_fontset_font): Rename local to avoid shadowing.
5718 (fontset_font): Mark local as initialized.
5719 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5720
5721 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5722
5723 * xselect.c (x_disown_buffer_selections): Remove; not used.
5724 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5725 (x_own_selection, Fx_disown_selection_internal): Rename locals
5726 to avoid shadowing.
5727 (x_handle_dnd_message): Remove local to avoid shadowing.
5728
5729 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5730 so that the caller can use some name other than gcpro1.
5731 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5732 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5733 (Fx_backspace_delete_keys_p):
5734 Use them to avoid shadowing, and rename vars to avoid shadowing.
5735 (x_decode_color, x_set_name, x_window): Now static.
5736 (Fx_create_frame): Add braces to silence GCC warning.
5737 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5738 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5739 Remove unused locals.
5740 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5741 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5742 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5743 macros.
5744
5745 * xterm.h (x_mouse_leave): New decl.
5746
5747 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5748 Remove unused functions.
5749 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5750 (x_calc_absolute_position): Now static.
5751 (XTread_socket): Don't define label "out" unless it's used.
5752 Don't declare local "event" unless it's used.
5753 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5754 unless they are used.
5755 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5756 (x_fatal_error_signal): Remove; not used.
5757 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5758 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5759 (x_error_catcher, x_connection_closed, x_error_handler):
5760 (x_error_quitter, xembed_send_message, x_iconify_frame):
5761 (my_log_handler): Rename locals to avoid shadowing.
5762 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5763 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5764
5765 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5766 Rename or move locals to avoid shadowing.
5767 (tty_defined_color, merge_face_heights): Now static.
5768 (free_realized_faces_for_fontset): Remove; not used.
5769 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5770 does not deduce is never used uninitialized.
5771 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5772 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5773
5774 * terminal.c (store_terminal_param): Now static.
5775
5776 * xmenu.c (menu_highlight_callback): Now static.
5777 (set_frame_menubar): Remove unused local.
5778 (xmenu_show): Rename parameter to avoid shadowing.
5779 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5780 since they might point to immutable storage.
5781 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5782 since it's unused otherwise.
5783
5784 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5785 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5786 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5787 avoids a gcc -Wuninitialized diagnostic.
5788 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5789 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5790 does not deduce are never used uninitialized.
5791
5792 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5793
5794 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5795 * window.c (window_loop, size_window):
5796 (run_window_configuration_change_hook, enlarge_window): Likewise.
5797
5798 * window.c (display_buffer): Now static.
5799 (size_window): Mark variables that gcc -Wuninitialized
5800 does not deduce are never used uninitialized.
5801 * window.h (check_all_windows): New decl, to forestall
5802 gcc -Wmissing-prototypes diagnostic.
5803 * dispextern.h (bidi_dump_cached_states): Likewise.
5804
5805 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5806 shadowing.
5807 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5808 Include <limits.h>.
5809 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5810 and to avoid gcc -Wuninitialized warning.
5811 (load_charset_map): Mark variables that gcc -Wuninitialized
5812 does not deduce are never used uninitialized.
5813 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5814
5815 * coding.c (coding_set_source, coding_set_destination):
5816 Use "else { /* comment */ }" rather than "else /* comment */;"
5817 for clarity, and to avoid gcc -Wempty-body warning.
5818 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5819 a block, when the outer 'i' will do.
5820 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5821 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5822 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5823 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5824 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5825 Rename locals to avoid shadowing.
5826 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5827 * coding.c (emacs_mule_char, encode_invocation_designation):
5828 Now static, since they're not used elsewhere.
5829 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5830 (decode_coding_object, encode_coding_object, detect_coding_system):
5831 (decode_coding_emacs_mule): Mark variables that gcc
5832 -Wuninitialized does not deduce are never used uninitialized.
5833 (detect_coding_iso_2022): Initialize a local variable that might
5834 be used uninitialized. Leave a FIXME because it's not clear that
5835 this initialization is needed. (Bug#8211)
5836 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5837 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5838 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5839 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5840 Remove unused macros.
5841
5842 * category.c (hash_get_category_set): Remove unused local var.
5843 (copy_category_table): Now static, since it's not used elsewhere.
5844 * character.c (string_count_byte8): Likewise.
5845
5846 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5847 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5848
5849 * chartab.c (copy_sub_char_table): Now static, since it's not used
5850 elsewhere.
5851 (sub_char_table_ref_and_range, char_table_ref_and_range):
5852 Rename locals to avoid shadowing.
5853 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5854
5855 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5856 (BIDI_BOB): Remove unused macro.
5857
5858 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5859 deduce are never used uninitialized.
5860 * term.c (encode_terminal_code): Likewise.
5861
5862 * term.c (encode_terminal_code): Now static. Remove unused local.
5863
5864 * tparam.h: New file.
5865 * term.c, tparam.h: Include it.
5866 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5867 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5868 Move these decls to tparam.h, and make them agree with what
5869 is actually in tparam.c. The previous trick of using incompatible
5870 decls in different modules does not conform to the C standard.
5871 All callers of tparam changed to use tparam's actual API.
5872 * tparam.c (tparam1, tparam, tgoto):
5873 Use const pointers where appropriate.
5874
5875 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5876 * cm.h (struct cm): Likewise.
5877 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5878 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5879 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5880 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5881 (turn_on_face, init_tty): Likewise.
5882 * termchar.h (struct tty_display_info): Likewise.
5883
5884 * term.c (term_mouse_position): Rename local to avoid shadowing.
5885
5886 * alloc.c (mark_ttys): Move decl from here ...
5887 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5888
5889 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5890
5891 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5892
5893 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5894
5895 * search.c (compile_pattern_1): Remove argument regp, unused since
5896 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5897 (compile_pattern): Don't pass it.
5898
5899 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5900
5901 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5902 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5903 for ! HAVE_GTK3.
5904 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5905
5906 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5907
5908 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5909 gdk_window_get_screen, gdk_window_get_geometry,
5910 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5911 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5912 (xg_get_pixbuf_from_pixmap): New function.
5913 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5914 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5915 Call xg_get_pixbuf_from_pixmap instead of
5916 gdk_pixbuf_get_from_drawable.
5917 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5918 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5919 (xg_check_special_colors): Use GtkStyleContext and its functions
5920 for HAVE_GTK3.
5921 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5922 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5923 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5924 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5925 Call gtk_widget_get_preferred_size.
5926 (xg_frame_resized): gdk_window_get_geometry only takes 5
5927 parameters.
5928 (xg_win_to_widget, xg_event_is_for_menubar):
5929 Call gdk_x11_window_lookup_for_display.
5930 (xg_set_widget_bg): New function.
5931 (delete_cb): New function.
5932 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5933 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5934 (xg_set_background_color): Call xg_set_widget_bg.
5935 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5936 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5937 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5938 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5939 if ! HAVE_GTK3.
5940 (update_frame_tool_bar): Call gtk_widget_hide.
5941 (xg_initialize): Use GDK_KEY_g.
5942
5943 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5944 if ! HAVE_GTK3
5945 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5946
5947 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5948 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5949 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5950
5951 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5952
5953 * w32xfns.c (select_palette): Check success of RealizePalette against
5954 GDI_ERROR, not zero.
5955
5956 See ChangeLog.11 for earlier changes.
5957
5958 ;; Local Variables:
5959 ;; coding: utf-8
5960 ;; End:
5961
5962 Copyright (C) 2011 Free Software Foundation, Inc.
5963
5964 This file is part of GNU Emacs.
5965
5966 GNU Emacs is free software: you can redistribute it and/or modify
5967 it under the terms of the GNU General Public License as published by
5968 the Free Software Foundation, either version 3 of the License, or
5969 (at your option) any later version.
5970
5971 GNU Emacs is distributed in the hope that it will be useful,
5972 but WITHOUT ANY WARRANTY; without even the implied warranty of
5973 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5974 GNU General Public License for more details.
5975
5976 You should have received a copy of the GNU General Public License
5977 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.