1 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (forward_to_next_line_start): Allow to use the
4 no-display-properties-and-no-overlays under bidi display.
6 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8 * editfns.c (Fset_time_zone_rule): Document relationship with the
11 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12 the font entity extracted from the cache (Bug#8109).
14 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
16 * composite.c (autocmp_chars): Don't reset point. That is done by
17 restore_point_unwind (Bug#5984).
19 2011-08-07 Juri Linkov <juri@jurta.org>
21 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
22 to show the arg `TIME' instead of `TIMEVAL'.
24 2011-08-06 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
27 display property strides EOL and includes a newline, as in
28 longlines-mode. (Bug#9254)
29 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
30 word-wrap under bidirectional display. (Bug#9224)
32 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
33 is non-zero, even if the data buffer is NULL. Fixes a crash in
34 vertical-motion with longlines-mode. (Bug#9254)
36 2011-08-05 Eli Zaretskii <eliz@gnu.org>
38 * bidi.c <bidi_cache_total_alloc>: Now static.
39 (bidi_initialize): Initialize bidi_cache_total_alloc.
41 *xdisp.c (display_line): Release buffer allocated for shelved bidi
44 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
45 amount allocated this far in `bidi_cache_total_alloc'.
46 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
47 non-zero, only free the data buffer without restoring the cache
48 contents. All callers changed.
50 * dispextern.h (bidi_unshelve_cache): Update prototype.
52 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
53 (move_it_in_display_line, move_it_to)
54 (move_it_vertically_backward, move_it_by_lines): Replace the call
55 to xfree to an equivalent call to bidi_unshelve_cache.
56 (move_it_in_display_line_to): Fix logic of returning
57 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
59 2011-08-05 Eli Zaretskii <eliz@gnu.org>
61 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
62 came from a string character with a `cursor' property. (Bug#9229)
64 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
66 * Makefile.in (LIB_PTHREAD): New variable.
67 (LIBES): Add LIB_PTHREAD (Bug#9216).
69 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
70 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
72 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
74 * regex.c (re_iswctype): Remove some redundant boolean
77 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
79 * xterm.c (x_find_topmost_parent): New function.
80 (x_set_frame_alpha): Find topmost parent window with
81 x_find_topmost_parent and set the property there also (bug#9181).
82 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
84 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
86 * callproc.c (Fcall_process): Avoid vfork clobbering
87 the local vars buffer, coding_systems, current_dir.
89 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
91 * keymap.c (Fmake_composed_keymap): Move to subr.el.
93 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
95 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
96 so that it is not optimized away.
98 * xdisp.c (compute_display_string_pos): Remove unused local.
100 2011-08-02 Eli Zaretskii <eliz@gnu.org>
102 Fix slow cursor motion and scrolling in large buffers with
103 selective display, like Org Mode buffers. (Bug#9218)
105 * dispextern.h (struct bidi_it): New member disp_prop_p.
107 * xdisp.c: Remove one-slot cache of display string positions.
108 (compute_display_string_pos): Accept an additional argument
109 DISP_PROP_P; callers changed. Scan at most 5K characters forward
110 for a display string or property. If found, set DISP_PROP_P
113 * bidi.c (bidi_fetch_char): Accept an additional argument
114 DISP_PROP_P, and pass it to compute_display_string_pos.
115 Only handle text covered by a display string if DISP_PROP_P is returned
116 non-zero. All callers of bidi_fetch_char changed.
118 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
120 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
122 2010-12-03 Don March <don@ohspite.net>
124 * keymap.c (Fdefine_key): Fix non-prefix key error message when
125 last character M-[char] is translated to ESC [char] (bug#7541).
127 2011-08-02 Kenichi Handa <handa@m17n.org>
129 * lisp.h (uniprop_table): Extern it.
131 * chartab.c (uniprop_table): Make it non-static.
133 2011-08-01 Eli Zaretskii <eliz@gnu.org>
135 * xdisp.c (forward_to_next_line_start): Accept additional argument
136 BIDI_IT_PREV, and store into it the state of the bidi iterator had
138 (reseat_at_next_visible_line_start): Use the bidi iterator state
139 returned by forward_to_next_line_start to restore the state of
140 it->bidi_it after backing up to previous newline. (Bug#9212)
142 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
144 * regex.c (re_comp): Protoize.
145 (re_exec): Fix return type.
146 (regexec): Fix type of `ret'. (Bug#9203)
148 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
150 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
151 This is needed if max-image-size is a floating-point number.
153 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
155 * print.c (print_object): Print empty symbol as ##.
157 * lread.c (read1): Read ## as empty symbol.
159 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
161 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
162 setting frame foreground color (Bug#9175).
163 (x_set_background_color): Likewise.
165 * nsmenu.m (-setText): Size tooltip dimensions precisely to
167 (EmacsTooltip -init): Remove bezels and add shadows to
170 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
171 or scroll bar (Bug#8470).
173 * nsfont.m (nsfont_open): Remove assignment to voffset and
174 unnecessary vars hshink, expand, hd, full_height, min_height.
175 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
177 * nsterm.h (nsfont_info): Remove voffset field.
179 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
181 Implement strike-through and overline on NextStep (Bug#8863).
183 * nsfont.m (nsfont_open): Use underline position provided by font,
184 instead of hard-coded value of 2.
185 (nsfont_draw): Call ns_draw_text_decoration instead.
187 * nsterm.h: Add declaration for ns_draw_text_decoration.
189 * nsterm.m (ns_draw_text_decoration): New function for drawing
190 underline, overline, and strike-through.
191 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
192 ns_draw_text_decoration. Change treatment of cursor drawing to
193 accomodate underlining, etc.
195 2011-07-28 Eli Zaretskii <eliz@gnu.org>
197 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
200 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
202 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
203 Without this fix, if a signal arrives just after memory fills up,
204 'malloc' might be invoked reentrantly.
206 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
207 In other words, assume that every image size is allowed, on non-X
208 hosts. This assumption is probably wrong, but it lets Emacs compile.
210 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
212 * regex.c (re_iswctype): Convert return values to boolean.
214 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
216 * xdisp.c (compute_display_string_pos): Don't use cached display
217 string position if the buffer had its restriction changed.
220 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
222 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
224 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
226 Integer signedness and overflow and related fixes. (Bug#9079)
228 * bidi.c: Integer size and overflow fixes.
229 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
230 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
231 (bidi_cache_find_level_change, bidi_cache_ensure_space)
232 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
233 (bidi_find_other_level_edge):
234 Use ptrdiff_t instead of EMACS_INT where either will do.
235 This works better on 32-bit hosts configured --with-wide-int.
236 (bidi_cache_ensure_space): Check for size-calculation overflow.
237 Use % rather than repeated addition, for better worst-case speed.
238 Don't set bidi_cache_size until after xrealloc returns, because it
240 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
241 (bidi_cache_ensure_space): Also check that the bidi cache size
242 does not exceed that of the largest Lisp string or buffer. See Eli
243 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
245 * alloc.c (__malloc_size_t): Remove.
246 All uses replaced by size_t. See Andreas Schwab's note
247 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
249 * image.c: Improve checking for integer overflow.
250 (check_image_size): Assume that f is nonnull, since
251 it is always nonnull in practice. This is one less thing to
252 worry about when checking for integer overflow later.
253 (x_check_image_size): New function, which checks for integer
254 overflow issues inside X.
255 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
256 This removes the need for a memory_full check.
257 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
258 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
259 (xbm_read_bitmap_data): Change locals back to 'int', since
260 their values must fit in 'int'.
261 (xpm_load_image, png_load, tiff_load):
262 Invoke x_create_x_image_and_pixmap earlier,
263 to avoid much needless work if the image is too large.
264 (tiff_load): Treat overly large images as if
265 x_create_x_image_and_pixmap failed, not as malloc failures.
266 (gs_load): Use x_check_image_size.
268 * gtkutil.c: Omit integer casts.
269 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
270 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
272 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
274 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
275 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
276 would wrongly return t on a 64-bit host.
278 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
279 The plain *_OVERFLOW macros run afoul of GCC bug 49705
280 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
281 and therefore cause GCC to emit a bogus diagnostic in some cases.
283 * image.c: Integer signedness and overflow and related fixes.
284 This is not an exhaustive set of fixes, but it's time to
285 record what I've got.
286 (lookup_pixel_color, check_image_size): Remove redundant decls.
287 (check_image_size): Don't assume that arbitrary EMACS_INT values
288 fit in 'int', or that arbitrary 'double' values fit in 'int'.
289 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
290 (tiff_load, imagemagick_load_image):
291 Check for overflow in size calculations.
292 (x_create_x_image_and_pixmap): Remove unnecessary test for
293 xmalloc returning NULL; that can't happen.
294 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
295 (xpm_color_bucket): Use better integer hashing function.
296 (xpm_cache_color): Don't possibly over-allocate memory.
297 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
299 Use ptrdiff_t, not int or size_t, to record sizes.
300 (png_load): Don't assume values greater than 2**31 fit in 'int'.
301 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
302 either works, as we prefer signed integers.
303 (tiff_read_from_memory, tiff_write_from_memory):
304 Return tsize_t, not size_t, since that's what the TIFF API wants.
305 (tiff_read_from_memory): Don't fail simply because the read would
306 go past EOF; instead, return a short read.
307 (tiff_load): Omit no-longer-needed casts.
308 (Fimagemagick_types): Don't assume size fits into 'int'.
310 Improve hashing quality when configured --with-wide-int.
311 * fns.c (hash_string): New function, taken from sxhash_string.
312 Do not discard information about ASCII character case; this
313 discarding is no longer needed.
314 (sxhash-string): Use it. Change sig to match it. Caller changed.
315 * lisp.h: Declare it.
316 * lread.c (hash_string): Remove, since we now use fns.c's version.
317 The fns.c version returns a wider integer if --with-wide-int is
318 specified, so this should help the quality of the hashing a bit.
320 * emacs.c: Integer overflow minor fix.
321 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
322 Define only if GNU_LINUX.
323 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
325 * dispnew.c: Integer signedness and overflow fixes.
326 Remove unnecessary forward decls, that were a maintenance hassle.
327 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
329 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
330 (scrolling_window): Use ptrdiff_t, not int, for byte count.
331 (prepare_desired_row, line_draw_cost):
332 Use int, not unsigned, where either works.
333 (save_current_matrix, restore_current_matrix):
334 Use ptrdiff_t, not size_t, where either works.
335 (init_display): Check for overflow more accurately, and without
336 relying on undefined behavior.
338 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
339 Remove, replacing with the new symbols in lisp.h. All uses changed.
340 * fileio.c (make_temp_name):
341 * filelock.c (lock_file_1, lock_file):
342 * xdisp.c (message_dolog):
343 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
344 Use pMd etc. instead.
345 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
346 replacing the pWIDE etc. symbols removed from editfns.c.
348 * keyboard.h (num_input_events): Now uintmax_t.
349 This is (very slightly) less likely to mess up due to wraparound.
352 * buffer.c: Integer signedness fixes.
353 (alloc_buffer_text, enlarge_buffer_text):
354 Use ptrdiff_t rather than size_t when either will do, as we prefer
357 * alloc.c: Integer signedness and overflow fixes.
358 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
359 (__malloc_size_t): Default to size_t, not to int.
360 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
361 (Fgarbage_collect, mark_object_loop_halt, mark_object):
362 Prefer ptrdiff_t to size_t when either would do, as we prefer
364 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
365 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
366 Now const. Initialize with values that are in range even if char
368 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
369 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
370 These functions do the right thing with sizes > 2**32.
371 (check_depth): Now ptrdiff_t, not int.
372 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
373 Adjust to new way of storing sizes. Check for size overflow bugs
375 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
376 slightly wrong anyway, as it missed one instance of
377 XMALLOC_OVERRUN_CHECK_OVERHEAD.
378 (refill_memory_reserve): Omit needless cast to size_t.
379 (mark_object_loop_halt): Mark as externally visible.
381 * xselect.c: Integer signedness and overflow fixes.
382 (Fx_register_dnd_atom, x_handle_dnd_message):
383 Use ptrdiff_t, not size_t, since we prefer signed.
384 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
385 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
386 x_dnd_atoms_size and x_dnd_atoms_length.
388 * doprnt.c: Prefer signed to unsigned when either works.
392 * xdisp.c (vmessage):
393 Use ptrdiff_t, not size_t, when using or implementing doprnt,
394 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
395 prefer signed arithmetic to avoid comparison confusion.
396 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
399 Assume freestanding C89 headers, string.h, stdlib.h.
400 * data.c, doprnt.c, floatfns.c, print.c:
401 Include float.h unconditionally.
402 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
403 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
404 * regex.c: Likewise for stddef.h, string.h.
405 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
406 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
407 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
408 (STDC_HEADERS): Remove obsolete defines.
409 * sysdep.c: Include limits.h unconditionally.
411 Assume support for memcmp, memcpy, memmove, memset.
412 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
413 * regex.c (memcmp, memcpy):
414 Remove; we assume C89 now.
416 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
417 (__malloc_safe_bcopy): Remove; no longer needed.
419 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
420 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
421 well either way, and we prefer signed to unsigned.
423 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
425 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
426 closes the connection while we're reading (bug#9182).
428 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
430 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
431 are specified (Bug#9168).
433 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
435 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
436 Found by GCC static checking and --with-wide-int on a 32-bit host.
438 2011-07-25 Eli Zaretskii <eliz@gnu.org>
440 * xdisp.c (compute_display_string_pos): Fix logic of caching
441 previous display string position. Initialize cached_prev_pos to
442 -1. Fixes slow-down at the beginning of a buffer.
444 2011-07-24 Eli Zaretskii <eliz@gnu.org>
446 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
447 for attrs[LFACE_FONTSET_INDEX].
449 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
451 * xml.c (parse_region): Remove unused local
452 that was recently introduced.
454 2011-07-23 Eli Zaretskii <eliz@gnu.org>
456 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
457 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
459 * xdisp.c (move_it_in_display_line_to): Record the best matching
460 position for TO_CHARPOS while scanning the line, and restore it on
461 exit if none of the characters scanned was an exact match.
462 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
463 when exact match is impossible due to invisible text, and the
466 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
468 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
471 2011-07-22 Eli Zaretskii <eliz@gnu.org>
473 Fix a significant slow-down of cursor motion with C-n, C-p,
474 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
475 auto-repeat under bidi redisplay in fontified buffers.
476 * xdisp.c (compute_stop_pos_backwards): New function.
477 (next_element_from_buffer): Call compute_stop_pos_backwards to
478 find a suitable prev_stop when we find ourselves before
480 (reseat): Don't look for prev_stop, as that could mean a very long
482 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
483 <cached_disp_overlay_modiff>: Cache for last found display string
485 (compute_display_string_pos): Return the cached position if asked
486 about the same buffer in the same area of character positions, and
487 the buffer wasn't changed since the time the display string
490 2011-07-22 Eli Zaretskii <eliz@gnu.org>
492 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
493 is an integer, which is important for empty lines. (Bug#9149)
495 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
497 * frame.c (Fmodify_frame_parameters): In tty case, update the
498 default face if necessary (Bug#4238).
500 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
502 * editfns.c (Fstring_to_char): No need to explain what a character
503 is in the docstring (Bug#6576).
505 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
507 * xml.c (parse_region): Make sure we always return a tree.
509 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
511 * xml.c (parse_region): If a document contains only comments,
514 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
516 * xml.c (make_dom): Return comments, too.
518 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
521 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
522 and the surrounding thread.
523 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
524 rather than fgets, and retry after EINTR. Otherwise, 'emacs
525 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
527 * s/openbsd.h (BROKEN_SIGIO): Define.
528 * unexelf.c (unexec) [__OpenBSD__]:
529 Don't update the .mdebug section of the Alpha COFF symbol table.
531 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
533 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
536 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
538 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
539 This fixes some race conditions on the permissions of any newly
542 * alloc.c (valid_pointer_p): Use pipe, not open.
543 This fixes some permissions issues when debugging.
545 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
546 If fchown fails to set both uid and gid, try to set just gid,
547 as that is sometimes allowed. Adjust the file's mode to eliminate
548 setuid or setgid bits that are inappropriate if fchown fails.
550 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
552 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
553 to compare Lisp_Objects.
554 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
555 global_gnutls_log_level, don't mistake it for a Lisp_Object.
556 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
558 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
560 * lread.c (read_integer): Unread even EOF character.
561 (read1): Likewise. Properly record start position of symbol.
563 * lread.c (read1): Read `#:' as empty uninterned symbol if no
564 symbol character follows.
566 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
568 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
569 This works around a problem with the previous change to Fcopy_file.
570 Recent glibc declares fchown with __attribute__((warn_unused_result)),
571 and without this change, GCC might complain about discarding
572 fchown's return value.
574 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
576 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
578 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
580 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
582 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
584 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
585 it's used from the C level.
587 * process.c: Use the same condition for POLL_FOR_INPUT in both
588 keyboard.c and process.c (bug#1858).
590 2011-07-09 Lawrence Mitchell <wence@gmx.li>
592 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
593 (Fgnutls_boot): Use it.
595 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
597 * doc.c (Fsubstitute_command_keys): Revert last change.
599 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
601 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
602 quotes the next character, and doesn't affect other longer
603 sequences (bug#8935).
605 * lread.c (syms_of_lread): Clarify that is isn't only
606 `eval-buffer' and `eval-defun' that's affected by
607 `lexical-binding' (bug#8460).
609 2011-07-15 Eli Zaretskii <eliz@gnu.org>
611 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
612 bidi redisplay when a line includes both an image and is
615 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
617 Fix minor problems found by static checking.
618 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
619 (elsz): Now a signed constant, not a size_t var. We prefer signed
620 types to unsigned, to avoid integer comparison confusion. Without
621 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
622 "cannot optimize loop, the loop counter may overflow", a symptom
624 * indent.c (Fvertical_motion): Mark locals as initialized.
625 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
627 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
629 * search.c (Fre_search_backward): Mention `case-fold-search' in
630 all the re_search_* functions (bug#8138).
632 * keyboard.c (Fopen_dribble_file): Document when the file is
635 2011-07-14 Eli Zaretskii <eliz@gnu.org>
637 * bidi.c (bidi_dump_cached_states): Fix format of displaying
640 Support bidi reordering of display and overlay strings.
641 * xdisp.c (compute_display_string_pos)
642 (compute_display_string_end): Accept additional argument STRING.
643 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
644 (reseat_to_string): Initialize bidi_it->string.s and
645 bidi_it->string.schars.
646 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
647 NULL (avoids a crash in bidi_paragraph_init).
648 Initialize itb.string.lstring.
649 (init_iterator): Call bidi_init_it only of a valid
650 buffer position was specified. Initialize paragraph_embedding to
652 (reseat_to_string): Initialize the bidi iterator.
653 (display_string): If we need to ignore text properties of
654 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
655 original value of -1 will not work with bidi.)
656 (compute_display_string_pos): First arg is now struct
657 `text_pos *'; all callers changed. Support display properties on
659 (compute_display_string_end): Support display properties on Lisp
661 (init_iterator, reseat_1, reseat_to_string): Initialize the
662 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
663 when iterating on a string not from display properties).
664 (compute_display_string_pos, compute_display_string_end):
665 Fix calculation of the object to scan. Fixes an error when using
667 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
668 base_level_stop; instead, set base_level_stop to BEGV.
669 Fixes crashes in vertical-motion.
670 (next_element_from_buffer): Improve commentary for when
671 the iterator is before prev_stop.
672 (init_iterator): Initialize bidi_p from the default value of
673 bidi-display-reordering, not from buffer-local value. Use the
674 buffer-local value only if initializing for buffer iteration.
675 (handle_invisible_prop): Support invisible properties on strings
676 that are being bidi-reordered.
677 (set_iterator_to_next): Support bidi reordering of C strings and
679 (next_element_from_string): Support bidi reordering of Lisp
681 (handle_stop_backwards): Support Lisp strings as well.
682 (display_string): Support display of R2L glyph rows.
683 Use IT_STRING_CHARPOS when displaying from a Lisp string.
684 (init_iterator): Don't initialize it->bidi_p for strings
686 (reseat_to_string): Initialize it->bidi_p for strings here.
687 (next_element_from_string, next_element_from_c_string)
688 (next_element_from_buffer): Add xassert's for correspondence
689 between IT's object being iterated and it->bidi_it.string
691 (face_before_or_after_it_pos): Support bidi iteration.
692 (next_element_from_c_string): Handle the case of the first string
693 character that is not the first one in the visual order.
694 (get_visually_first_element): New function, refactored from common
695 parts of next_element_from_buffer, next_element_from_string, and
696 next_element_from_c_string.
697 (tool_bar_lines_needed, redisplay_tool_bar)
698 (display_menu_bar): Force left-to-right direction. Add a FIXME
699 comment for making that be controlled by a user option.
700 (push_it, pop_it): Save and restore the state of the
701 bidi iterator. Save and restore the bidi_p flag.
702 (pop_it): Iterate out of display property for string iteration as
704 (iterate_out_of_display_property): Support iteration over strings.
705 (handle_single_display_spec): Set up it->bidi_it for iteration
706 over a display string, and call bidi_init_it.
707 (handle_single_display_spec, next_overlay_string)
708 (get_overlay_strings_1, push_display_prop): Set up the bidi
709 iterator for displaying display or overlay strings.
710 (forward_to_next_line_start): Don't use the shortcut if
712 (back_to_previous_visible_line_start): If handle_display_prop
713 pushed the iterator stack, restore the internal state of the bidi
714 iterator by calling bidi_pop_it same number of times.
715 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
716 and we are bidi-iterating, don't decrement the iterator position;
717 instead, set the first_elt flag in the bidi iterator, to produce
719 (reseat_1): Remove redundant setting of string_from_display_prop_p.
720 (push_display_prop): xassert that we are iterating a buffer.
721 (push_it, pop_it): Save and restore paragraph_embedding member.
722 (handle_single_display_spec, next_overlay_string)
723 (get_overlay_strings_1, reseat_1, reseat_to_string)
724 (push_display_prop): Set up the `unibyte' member of bidi_it.string
725 correctly. Don't assume unibyte strings are not bidi-reordered.
726 (compute_display_string_pos)
727 (compute_display_string_end): Fix handling the case of C string.
728 (push_it, pop_it): Save and restore from_disp_prop_p.
729 (handle_single_display_spec, push_display_prop): Set the
730 from_disp_prop_p flag.
731 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
732 (pop_it): Call iterate_out_of_display_property only if we are
733 popping after iteration over a string that came from a display
734 property. Fix a typo in popping stretch info. Add an assertion
735 for verifying that the iterator position is in sync with the bidi
737 (handle_single_display_spec, get_overlay_strings_1)
738 (push_display_prop): Fix initialization of paragraph direction for
739 string when that of the parent object is not yet determined.
740 (reseat_1): Call bidi_init_it to resync the bidi
741 iterator with IT's position. (Bug#7616)
742 (find_row_edges): If ROW->start.pos gives position
743 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
744 (handle_stop, back_to_previous_visible_line_start, reseat_1):
745 Reset the from_disp_prop_p flag.
746 (SAVE_IT, RESTORE_IT): New macros.
747 (pos_visible_p, face_before_or_after_it_pos)
748 (back_to_previous_visible_line_start)
749 (move_it_in_display_line_to, move_it_in_display_line)
750 (move_it_to, move_it_vertically_backward, move_it_by_lines)
751 (try_scrolling, redisplay_window, display_line): Use them when
752 saving a temporary copy of the iterator and restoring it back.
753 (back_to_previous_visible_line_start, reseat_1)
754 (init_iterator): Empty the bidi cache "stack".
755 (move_it_in_display_line_to): If iterator ended up at
756 EOL, but we never saw any buffer positions smaller than
757 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
758 motion in bidi-reordered lines.
759 (move_it_in_display_line_to): Record prev_method and prev_pos
760 immediately before the call to set_iterator_to_next. Fixes cursor
761 motion in bidi-reordered lines with stretch glyphs and strings
762 displayed in margins. (Bug#8133) (Bug#8867)
763 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
765 (pos_visible_p): Support positions in bidi-reordered lines.
766 Save and restore bidi cache.
768 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
769 (bidi_paragraph_info): Delete unused struct.
770 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
771 (bidi_cache_start): New variable.
772 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
774 (bidi_cache_fetch_state, bidi_cache_search)
775 (bidi_cache_find_level_change, bidi_cache_iterator_state)
776 (bidi_cache_find, bidi_peek_at_next_level)
777 (bidi_level_of_next_char, bidi_find_other_level_edge)
778 (bidi_move_to_visually_next): Compare cache index with
779 bidi_cache_start rather than with zero.
780 (bidi_fetch_char): Accept new argument STRING; all callers
781 changed. Support iteration over a string. Support strings with
782 display properties. Support unibyte strings. Fix the type of
783 `len' according to what STRING_CHAR_AND_LENGTH expects.
784 (bidi_paragraph_init, bidi_resolve_explicit_1)
785 (bidi_resolve_explicit, bidi_resolve_weak)
786 (bidi_level_of_next_char, bidi_move_to_visually_next):
787 Support iteration over a string.
788 (bidi_set_sor_type, bidi_resolve_explicit_1)
789 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
790 can now be zero (for strings); special values 0 and -1 were
791 changed to -1 and -2, respectively.
792 (bidi_char_at_pos): New function.
793 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
794 Call it instead of FETCH_MULTIBYTE_CHAR.
795 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
796 initialized to valid values.
797 (bidi_init_it): Don't initialize charpos and bytepos with invalid
799 (bidi_level_of_next_char): Allow the sentinel "position" to pass
800 the test for valid cached positions. Fix the logic for looking up
801 the sentinel state in the cache. GCPRO the Lisp string we are
803 (bidi_push_it, bidi_pop_it): New functions.
804 (bidi_initialize): Initialize the bidi cache start stack pointer.
805 (bidi_cache_ensure_space): New function, refactored from part of
806 bidi_cache_iterator_state. Don't assume the required size is just
807 one BIDI_CACHE_CHUNK away.
808 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
809 (bidi_count_bytes, bidi_char_at_pos): New functions.
810 (bidi_cache_search): Don't assume bidi_cache_last_idx is
811 always valid if bidi_cache_idx is valid.
812 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
813 is valid if it's going to be used.
814 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
815 (bidi_cache_fetch_state, bidi_cache_search)
816 (bidi_cache_find_level_change, bidi_cache_ensure_space)
817 (bidi_cache_iterator_state, bidi_cache_find)
818 (bidi_find_other_level_edge, bidi_cache_start_stack):
819 All variables related to cache indices are now EMACS_INT.
821 * dispextern.h (struct bidi_string_data): New structure.
822 (struct bidi_it): New member `string'. Make flag members be 1-bit
823 fields, and put them last in the struct.
824 (compute_display_string_pos, compute_display_string_end):
826 (bidi_push_it, bidi_pop_it): Add prototypes.
827 (struct iterator_stack_entry): New members bidi_p,
828 paragraph_embedding, and from_disp_prop_p.
829 (struct it): Member bidi_p is now a bit field 1 bit wide.
830 (bidi_shelve_cache, bidi_unshelve_cache):
833 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
834 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
835 and vector-like objects.
837 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
838 cache around display iteration.
840 * window.c (Fwindow_end, window_scroll_pixel_based)
841 (displayed_window_lines, Frecenter): Save and restore the bidi
842 cache around display iteration.
844 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
846 * editfns.c (Fdelete_region): Clarify the use of the named
847 parameters (bug#6788).
849 2011-07-14 Martin Rudalics <rudalics@gmx.at>
851 * indent.c (Fvertical_motion): Set and restore w->pointm when
852 saving and restoring the window's buffer (Bug#9006).
854 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
856 * editfns.c (Fstring_to_char): Clarify just what is returned
857 (bug#6576). Text by Eli Zaretskii.
859 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
861 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
863 2011-07-13 Eli Zaretskii <eliz@gnu.org>
865 * buffer.c (mmap_find): Fix a typo.
867 2011-07-13 Johan Bockgård <bojohan@gnu.org>
869 Fix execution of x selection hooks.
870 * xselect.c (Qx_lost_selection_functions)
871 (Qx_sent_selection_functions): New vars.
872 (syms_of_xselect): DEFSYM them.
873 (x_handle_selection_request): Pass Qx_sent_selection_functions
874 rather than Vx_sent_selection_functions to Frun_hook_with_args.
875 (x_handle_selection_clear,x_clear_frame_selections):
876 Pass Qx_lost_selection_functions rather than
877 Vx_lost_selection_functions to Frun_hook_with_args.
879 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
881 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
882 The old code sometimes used this field without initializing it.
884 * alloc.c (gc_sweep): Don't read past end of array.
885 In theory, the old code could also have corrupted Emacs internals,
886 though it'd be very unlikely.
888 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
890 * character.c (Fcharacterp): Don't advertise optional ignored
893 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
895 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
898 * window.c (Fset_window_start): Doc fix (bug#4199).
899 (Fset_window_hscroll): Ditto.
901 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
903 Fix minor new problems caught by GCC 4.6.1.
904 * term.c (init_tty): Remove unused local.
905 * xsettings.c (store_monospaced_changed): Define this function only
906 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
909 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
911 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
913 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
915 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
916 are the mini-buffer and the echo area (bug#3320).
918 * term.c (init_tty): Remove support for supdup, c10 and perq
919 terminals, which are no longer supported (bug#1482).
921 2011-07-10 Johan Bockgård <bojohan@gnu.org>
923 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
925 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
927 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
928 for non-popups (Bug#3642).
930 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
932 * alloc.c (reset_malloc_hooks): Protoize.
933 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
934 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
935 * cm.c (losecursor): Likewise.
936 * data.c (fmod): Likewise.
937 * dispnew.c (swap_glyphs_in_rows): Likewise.
938 * emacs.c (memory_warning_signal): Likewise.
939 * floatfns.c (float_error): Likewise.
940 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
941 (otf_open, font_otf_capability, generate_otf_features)
942 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
944 * image.c (pbm_read_file): Likewise.
945 * indent.c (string_display_width): Likewise.
946 * intervals.c (check_for_interval, search_for_interval)
947 (inc_interval_count, count_intervals, root_interval)
948 (adjust_intervals_for_insertion, make_new_interval): Likewise.
949 * lread.c (defalias): Likewise.
950 * ralloc.c (r_alloc_check): Likewise.
951 * regex.c (set_image_of_range_1, set_image_of_range)
952 (regex_grow_registers): Likewise.
953 * sysdep.c (strerror): Likewise.
954 * termcap.c (valid_filename_p, tprint, main): Likewise.
955 * tparam.c (main): Likewise.
956 * unexhp9k800.c (run_time_remap, save_data_space)
957 (update_file_ptrs, read_header, write_header, calculate_checksum)
958 (copy_file, copy_rest, display_header): Likewise.
959 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
961 * xdisp.c (check_it): Likewise.
962 * xfaces.c (register_color, unregister_color, unregister_colors):
964 * xfns.c (print_fontset_result): Likewise.
965 * xrdb.c (member, fatal, main): Likewise.
967 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
969 Fix minor problems found by static checking (Bug#9031).
970 * chartab.c (char_table_set_range, map_sub_char_table):
971 Remove unused locals.
972 (uniprop_table): Now static.
973 * composite.c (_work_char): Remove unused static var.
975 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
977 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
979 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
981 * gtkutil.c (qttip_cb): Remove code without function.
983 2011-07-09 Eli Zaretskii <eliz@gnu.org>
985 * w32.c (pthread_sigmask): New stub.
987 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
989 Use pthread_sigmask, not sigprocmask (Bug#9010).
990 sigprocmask is portable only for single-threaded applications, and
991 Emacs can be multi-threaded when it uses GTK.
992 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
994 * callproc.c (Fcall_process):
995 * process.c (create_process):
996 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
997 Use pthread_sigmask, not sigprocmask.
999 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1001 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1002 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1005 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1007 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1008 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1009 (xg_hide_tooltip): Fix comment.
1011 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1012 in registerServicesMenuSendTypes.
1013 (validRequestorForSendType): Don't check ns_return_types.
1015 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1018 2011-07-08 Jason Rumney <jasonr@gnu.org>
1020 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1021 frame struct members of non-existent frames (Bug#6284).
1023 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1025 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1026 variable firstTime not needed on OSX >= 10.6.
1027 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1028 >= 10.5. Use setKnobProportion, setDoubleValue.
1030 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1031 (MAC_OS_X_VERSION_10_5): Define if not defined.
1032 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1033 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1034 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1036 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1037 cString and lossyCString on OSX >= 10.4
1039 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1040 sizeToFit on OSX >= 10.2.
1042 * nsimage.m (allocInitFromFile): Don't use deprecated method
1043 bestRepresentationForDevice on OSX >= 10.6.
1045 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1048 * emacs.c: Declare unexec_init_emacs_zone.
1050 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1052 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1054 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1055 on svcsMenu (Bug#8842).
1057 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1059 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1061 * nsterm.m (QUTF8_STRING): Declare.
1062 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1063 (validRequestorForSendType): Return type is (id).
1064 Change indexOfObjectIdenticalTo to indexOfObject.
1065 Check if we have local selection before returning self (Bug#8842).
1066 (writeSelectionToPasteboard): Put local selection into paste board
1067 if we have a local selection (Bug#8842).
1068 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1070 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1071 (ns_get_local_selection): Declare.
1073 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1075 * keymap.c (describe_map_tree): Don't insert a double newline at
1076 the end of the buffer (bug#1169) and return whether we inserted
1079 * callint.c (Fcall_interactively): Change "reading args" to
1080 "providing args" to try to clarify what it does (bug#1010).
1082 2011-07-07 Kenichi Handa <handa@m17n.org>
1084 * composite.c (composition_compute_stop_pos): Ignore a static
1085 composition starting before CHARPOS (Bug#8915).
1087 * xdisp.c (handle_composition_prop): Likewise.
1089 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1091 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1094 2011-07-07 Kenichi Handa <handa@m17n.org>
1096 * character.h (unicode_category_t): New enum type.
1098 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1099 (Qchar_code_property_table): New variable.
1100 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1101 (UNIPROP_COMPRESSED_FORM_P): New macros.
1102 (char_table_ascii): Uncompress the compressed values.
1103 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1104 Uncompress the compressed values.
1105 (sub_char_table_ref_and_range): Likewise.
1106 (char_table_ref_and_range): Uncompress the compressed values.
1107 (sub_char_table_set): New arg is_uniprop. Callers changed.
1108 Uncompress the compressed values.
1109 (sub_char_table_set_range): Args changed. Callers changed.
1110 (char_table_set_range): Adjuted for the above change.
1111 (map_sub_char_table): Delete args default_val and parent. Add arg
1112 top. Give decoded values to a Lisp function.
1113 (map_char_table): Adjust for the above change. Give decoded
1114 values to a Lisp function. Gcpro more variables.
1115 (uniprop_table_uncompress)
1116 (uniprop_decode_value_run_length): New functions.
1117 (uniprop_decoder, uniprop_decoder_count): New variables.
1118 (uniprop_get_decoder, uniprop_encode_value_character)
1119 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1121 (uniprop_encoder, uniprop_encoder_count): New variables.
1122 (uniprop_get_encoder, uniprop_table)
1123 (Funicode_property_table_internal, Fget_unicode_property_internal)
1124 (Fput_unicode_property_internal): New functions.
1125 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1126 Sunicode_property_table_internal, Sget_unicode_property_internal,
1127 and Sput_unicode_property_internal. Defvar_lisp
1128 char-code-property-alist.
1130 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1131 Vunicode_category_table.
1133 * font.c (font_range): Adjust for the change of
1134 Vunicode_category_table.
1136 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1138 * m/iris4d.h: Remove file, move contents ...
1139 * s/irix6-5.h: ... here.
1141 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1143 Remove unportable assumption about struct layout (Bug#8884).
1144 * alloc.c (mark_buffer):
1145 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1146 (clone_per_buffer_values): Don't assume that
1147 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1148 This isn't true in general, and it's particularly not true
1149 if Emacs is configured with --with-wide-int.
1150 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1151 New macros, used in the buffer.c change.
1153 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1155 * xsettings.c: Use both GConf and GSettings if both are available.
1156 (store_config_changed_event): Add comment.
1157 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1158 (store_tool_bar_style_changed): New functions.
1159 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1160 (struct xsettings): Move font inside HAVE_XFT.
1161 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1162 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1163 Move inside HAVE_XFT.
1164 (something_changed_gsettingsCB): Rename from something_changedCB.
1165 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1167 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1168 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1169 (something_changed_gconfCB): Rename from something_changedCB.
1170 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1171 (parse_settings): Move check for font inside HAVE_XFT.
1172 (read_settings, apply_xft_settings): Add comment.
1173 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1174 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1175 call store_font_name_changed.
1176 (xft_settings_event): Add comment.
1177 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1178 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1179 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1180 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1181 (xsettings_initialize): Call init_gsettings last.
1182 (xsettings_get_system_font, xsettings_get_system_normal_font):
1185 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1187 Random fixes. E.g., (random) never returned negative values.
1188 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1189 subseconds part to the entropy, as that's a bit more random.
1190 Prefer signed to unsigned, since the signedness doesn't matter and
1191 in general we prefer signed. When given a limit, use a
1192 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1193 latter isn't right if USE_2_TAGS_FOR_INTS.
1194 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1195 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1197 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1199 * textprop.c (text_property_stickiness):
1200 Obey Vtext_property_default_nonsticky.
1201 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1202 * w32fns.c (syms_of_w32fns):
1203 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1205 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1207 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1208 This is more efficient than Ffile_directory_p and avoids a minor race.
1210 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1212 * buffer.c (Foverlay_put): Say what the return value is
1215 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1216 is a directory before asking whether to use the file name
1218 (barf_or_query_if_file_exists): Make the "File is a directory"
1219 error be more correct.
1221 * fns.c (Frequire): Remove the mention of the .gz files, since
1222 that's installation-specific, but keep the mention of
1223 `get-load-suffixes'.
1225 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1227 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1228 Report string overflow if the output is too long.
1230 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1232 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1233 (syms_of_gnutls): Remove duplicate DEFSYM for
1234 Qgnutls_bootprop_verify_hostname_error, an error for
1235 Qgnutls_bootprop_verify_error (which is no longer used).
1237 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1238 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1239 Also (re)move comments that are misplaced or no longer relevant.
1241 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1245 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1247 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1248 and background color parameters if they have been changed.
1250 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1252 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1254 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1256 * xsettings.c (SYSTEM_FONT): Define only when used.
1257 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1259 * keymap.c (access_keymap_1): Now static.
1261 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1263 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1264 leave any prefix arg for the up event (Bug#1586).
1266 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1268 * lread.c (syms_of_lread): Mention single symbols defined by
1269 `defvar' or `defconst' (bug#7154).
1271 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1272 (Frequire): Mention get-load-suffixes.
1274 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1276 * window.h (window): Remove clone_number slot.
1277 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1279 (make_parent_window, make_window, saved_window)
1280 (Fset_window_configuration, save_window_save): Don't deal with
1282 * buffer.c (Qclone_number): Remove declaration.
1283 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1285 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1287 Add multiple inheritance to keymaps.
1288 * keymap.c (Fmake_composed_keymap): New function.
1289 (Fset_keymap_parent): Simplify.
1290 (fix_submap_inheritance): Remove.
1291 (access_keymap_1): New function extracted from access_keymap to handle
1292 embedded parents and handle lists of maps.
1293 (access_keymap): Use it.
1294 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1295 (Fcopy_keymap): Handle embedded parents.
1296 (Fcommand_remapping, define_as_prefix): Simplify.
1297 (Fkey_binding): Simplify.
1298 (syms_of_keymap): Move minibuffer-local-completion-map,
1299 minibuffer-local-filename-completion-map,
1300 minibuffer-local-must-match-map, and
1301 minibuffer-local-filename-must-match-map to Elisp.
1302 (syms_of_keymap): Defsubr make-composed-keymap.
1303 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1304 (parse_menu_item): Trivial simplification.
1306 2011-07-01 Glenn Morris <rgm@gnu.org>
1308 * Makefile.in (SETTINGS_LIBS): Fix typo.
1310 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1312 * coding.c (Fencode_coding_string): Record the last coding system
1313 used, as the function doc string says (bug#8738).
1315 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1317 * xsettings.c (store_monospaced_changed): Take new font as arg and
1318 check for change against current_mono_font.
1319 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1320 (emacs_settings_constructor, emacs_settings_get_property)
1321 (emacs_settings_set_property, emacs_settings_class_init)
1322 (emacs_settings_init, gsettings_obj): Remove.
1323 (something_changedCB): New function for HAVE_GSETTINGS.
1324 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1325 with value as argument.
1326 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1327 g_settings_new (Bug#8967). Do not create gsettings_obj.
1328 Remove calls to g_settings_bind. Connect something_changedCB to
1331 * xgselect.c: Add defined (HAVE_GSETTINGS).
1332 (xgselect_initialize): Ditto.
1334 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1335 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1338 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1340 * eval.c (struct backtrace): Simplify and port the data structure.
1341 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1342 signed bit field, as this assumption is not portable and it makes
1343 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1344 "char debug_on_exit : 1" as this is not portable either; instead,
1345 use the portable "unsigned int debug_on_exit : 1". Remove unused
1346 member evalargs. Remove obsolete comments about cc bombing out.
1348 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1350 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1351 Let HAVE_GSETTINGS override HAVE_GCONF.
1352 (store_monospaced_changed): New function.
1353 (EMACS_SETTINGS): A new type derived from GObject to handle
1354 GSettings notifications.
1355 (emacs_settings_constructor, emacs_settings_get_property)
1356 (emacs_settings_set_property, emacs_settings_class_init):
1358 (gsettings_client, gsettings_obj): New variables.
1359 (GSETTINGS_SCHEMA): New define.
1360 (something_changedCB): Call store_monospaced_changed.
1361 (init_gsettings): New function.
1362 (xsettings_initialize): Call init_gsettings.
1363 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1366 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1369 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1371 * window.c (resize_root_window, grow_mini_window)
1372 (shrink_mini_window): Rename Qresize_root_window to
1373 Qwindow_resize_root_window and Qresize_root_window_vertically to
1374 Qwindow_resize_root_window_vertically.
1376 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1378 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1380 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1382 * makefile.w32-in: Redesign dependencies so they reflect more
1383 clearly which files are directly included by each source file,
1384 and not through other includes.
1386 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1388 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1389 (sort_overlays, overlay_strings): When an overlay's clone number
1390 matches the window's clone number process the overlay even if
1391 the overlay's window property doesn't match the current window.
1393 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1394 (Fwindow_hchild): Rename to Fwindow_left_child.
1395 (Fwindow_next): Rename to Fwindow_next_sibling.
1396 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1397 (resize_window_check): Rename to window_resize_check.
1398 (resize_window_apply): Rename to window_resize_apply.
1399 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1400 (Fdelete_other_windows_internal, resize_frame_windows)
1401 (Fsplit_window_internal, Fdelete_window_internal)
1402 (grow_mini_window, shrink_mini_window)
1403 (Fresize_mini_window_internal): Fix callers accordingly.
1405 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1407 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1408 (emacs_fixed_set_min_size): Remove.
1409 (emacs_fixed_new): Take frame as argument.
1411 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1412 (_EmacsFixedPrivate): Remove minwidth/height.
1413 Add struct frame *f.
1414 (emacs_fixed_init): Initialize priv->f.
1415 (get_parent_class, emacs_fixed_set_min_size): Remove.
1416 (emacs_fixed_new): Set priv->f to argument.
1417 (emacs_fixed_get_preferred_width)
1418 (emacs_fixed_get_preferred_height): Use min_width/height from
1419 frames size_hint to set minimum and natural (Bug#8919).
1420 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1421 and use min_width/height from frames size_hint to set
1422 min_width/height (Bug#8919).
1424 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1425 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1428 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1430 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1431 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1434 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1436 * process.c (wait_reading_process_output): Bypass select if
1437 waiting for a cell while ignoring keyboard input, and input is
1438 pending. Suggested by Jan Djärv (Bug#8869).
1440 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1442 Use gnulib's dup2 module instead of rolling our own.
1443 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1445 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1447 * dispnew.c (scrolling_window): Before scrolling, turn off a
1448 mouse-highlight in the window being scrolled.
1450 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1452 Move DEFSYM to lisp.h and use everywhere.
1454 * character.h (DEFSYM): Move declaration...
1455 * lisp.h (DEFSYM): ...here.
1461 * w32select.c: Don't include character.h.
1463 * alloc.c (syms_of_alloc):
1464 * buffer.c (syms_of_buffer):
1465 * bytecode.c (syms_of_bytecode):
1466 * callint.c (syms_of_callint):
1467 * casefiddle.c (syms_of_casefiddle):
1468 * casetab.c (init_casetab_once):
1469 * category.c (init_category_once, syms_of_category):
1470 * ccl.c (syms_of_ccl):
1471 * cmds.c (syms_of_cmds):
1472 * composite.c (syms_of_composite):
1473 * dbusbind.c (syms_of_dbusbind):
1474 * dired.c (syms_of_dired):
1475 * dispnew.c (syms_of_display):
1476 * doc.c (syms_of_doc):
1477 * editfns.c (syms_of_editfns):
1478 * emacs.c (syms_of_emacs):
1479 * eval.c (syms_of_eval):
1480 * fileio.c (syms_of_fileio):
1481 * fns.c (syms_of_fns):
1482 * frame.c (syms_of_frame):
1483 * fringe.c (syms_of_fringe):
1484 * insdel.c (syms_of_insdel):
1485 * keymap.c (syms_of_keymap):
1486 * lread.c (init_obarray, syms_of_lread):
1487 * macros.c (syms_of_macros):
1488 * msdos.c (syms_of_msdos):
1489 * print.c (syms_of_print):
1490 * process.c (syms_of_process):
1491 * search.c (syms_of_search):
1492 * sound.c (syms_of_sound):
1493 * syntax.c (init_syntax_once, syms_of_syntax):
1494 * terminal.c (syms_of_terminal):
1495 * textprop.c (syms_of_textprop):
1496 * undo.c (syms_of_undo):
1497 * w32.c (globals_of_w32):
1498 * window.c (syms_of_window):
1499 * xdisp.c (syms_of_xdisp):
1500 * xfaces.c (syms_of_xfaces):
1501 * xfns.c (syms_of_xfns):
1502 * xmenu.c (syms_of_xmenu):
1503 * xsettings.c (syms_of_xsettings):
1504 * xterm.c (syms_of_xterm): Use DEFSYM.
1506 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1508 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1510 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1512 Integer and buffer overflow fixes (Bug#8873).
1514 * print.c (printchar, strout): Check for string overflow.
1515 (PRINTPREPARE, printchar, strout):
1516 Don't set size unless allocation succeeds.
1518 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1519 for sizes. Check for string overflow more accurately.
1520 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1522 * macros.c: Integer and buffer overflow fixes.
1523 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1524 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1525 Use ptrdiff_t, not int, for sizes.
1526 Don't increment bufsize until after realloc succeeds.
1527 Check for size-calculation overflow.
1528 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1530 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1532 * lread.c: Integer overflow fixes.
1533 (read_integer): Radix is now EMACS_INT, not int,
1534 to improve quality of diagnostics for out-of-range radices.
1535 Calculate buffer size correctly for out-of-range radices.
1536 (read1): Check for integer overflow in radices, and in
1537 read-circle numbers.
1538 (read_escape): Avoid int overflow.
1539 (Fload, openp, read_buffer_size, read1)
1540 (substitute_object_recurse, read_vector, read_list, map_obarray):
1541 Use ptrdiff_t, not int, for sizes.
1542 (read1): Use EMACS_INT, not int, for sizes.
1543 Check for size overflow.
1545 * image.c (cache_image): Check for size arithmetic overflow.
1547 * lread.c: Integer overflow issues.
1548 (saved_doc_string_size, saved_doc_string_length)
1549 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1550 Now ptrdiff_t, not int.
1551 (read1): Don't assume doc string length fits in int. Check for
1552 out-of-range doc string lengths.
1553 (read_list): Don't assume file position fits in int.
1554 (read_escape): Check for hex character overflow.
1556 2011-06-22 Leo Liu <sdl.web@gmail.com>
1558 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1559 Move to minibuffer.el.
1561 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1563 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1564 The following patches are for when GLYPH_DEBUG && !XASSERT.
1565 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1566 * dispnew.c (flush_stdout):
1567 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1568 Mark as externally visible.
1569 * dispnew.c (check_window_matrix_pointers): Now static.
1570 * dispnew.c (window_to_frame_vpos):
1571 * xfns.c (unwind_create_frame):
1572 * xterm.c (x_check_font): Remove unused local.
1573 * scroll.c (CHECK_BOUNDS):
1574 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1575 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1576 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1577 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1578 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1580 (debug_method_add): Use va_list and vsprintf rather than relying
1581 on undefined behavior with wrong number of arguments.
1582 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1583 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1584 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1585 since we're not interested in debugging glyphs with old libraries.
1586 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1587 GCC 4.6.0's static checking.
1589 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1591 Integer overflow and signedness fixes (Bug#8873).
1592 A few related buffer overrun fixes, too.
1594 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1596 * dispextern.h (struct face.stipple):
1597 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1598 (x_bitmap_mask, x_allocate_bitmap_record)
1599 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1600 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1601 (x_create_bitmap_from_xpm_data):
1602 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1603 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1605 * xfaces.c (load_pixmap):
1606 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1607 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1608 (.bitmaps_last, struct x_output.icon_bitmap):
1609 Use ptrdiff_t, not int, for bitmap indexes.
1610 (x_allocate_bitmap_record): Check for size overflow.
1611 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1613 Use ptrdiff_t, not int, for overlay counts.
1614 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1615 * editfns.c (overlays_around, get_pos_property):
1616 * textprop.c (get_char_property_and_overlay):
1617 * xdisp.c (next_overlay_change, note_mouse_highlight):
1618 * xfaces.c (face_at_buffer_position):
1619 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1620 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1621 (Fnext_overlay_change, Fprevious_overlay_change)
1622 (mouse_face_overlay_overlaps, Foverlays_in):
1623 Use ptrdiff_t, not int, for sizes.
1624 (overlays_at, overlays_in): Check for size-calculation overflow.
1626 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1628 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1629 (x_session_initialize): Do not assume string length fits in int.
1631 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1632 This is unlikely, but can occur if DPI is outlandish.
1634 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1635 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1637 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1638 * xrdb.c (magic_file_p, search_magic_path):
1639 Omit last arg SUFFIX; it was always 0. All callers changed.
1640 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1642 * xfont.c (xfont_match): Avoid need for strlen.
1644 * xfns.c: Don't assume strlen fits in int.
1645 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1647 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1648 not unsigned long, as we prefer signed integers. All callers changed.
1649 Detect integer overflow in repeat count.
1650 (message_dolog): Don't assume print length fits in 39 bytes.
1651 (display_mode_element): Don't assume strlen fits in int.
1653 * termcap.c: Don't assume sizes fit in int and never overflow.
1654 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1655 (gobble_line): Check for size-calculation overflow.
1657 * minibuf.c (Fread_buffer):
1658 * lread.c (intern, intern_c_string):
1659 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1660 Don't assume string length fits in int.
1662 * keyboard.c (parse_tool_bar_item):
1663 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1665 * font.c: Don't assume string length fits in int.
1666 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1667 Use ptrdiff_t, not int.
1668 (font_intern_prop): Don't assume string length fits in int.
1669 Don't assume integer property fits in fixnum.
1670 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1672 * filelock.c: Fix some buffer overrun and integer overflow issues.
1673 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1674 Reformulate so as not to need the command string.
1675 Invoke gzip -cd rather than gunzip, as it's more portable.
1676 (lock_info_type, lock_file_1, lock_file):
1677 Don't assume pid_t and time_t fit in unsigned long.
1678 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1679 (current_lock_owner): Prefer signed type for sizes.
1680 Use memcpy, not strncpy, where memcpy is what is really wanted.
1681 Don't assume (via atoi) that time_t and pid_t fit in int.
1682 Check for time_t and/or pid_t out of range, e.g., via a network share.
1683 Don't alloca where an auto var works fine.
1685 * fileio.c: Fix some integer overflow issues.
1686 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1687 Don't assume string length fits in int.
1688 (directory_file_name): Don't assume string length fits in long.
1689 (make_temp_name): Don't assume pid fits in int, or that its print
1690 length is less than 20.
1692 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1694 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1696 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1698 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1699 We prefer signed integers, even for size calculations.
1701 * emacs.c: Don't assume string length fits in 'int'.
1702 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1703 (main): Don't invoke strlen when not needed.
1705 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1706 (XD_DEBUG_MESSAGE): Don't waste a byte.
1708 * callproc.c (getenv_internal_1, getenv_internal)
1710 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1712 * lread.c (invalid_syntax): Omit length argument.
1713 All uses changed. This doesn't fix a bug, but it simplifies the
1714 code away from its former Hollerith-constant appearance, and it's
1715 one less 'int' to worry about when looking at integer-overflow issues.
1716 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1718 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1719 This didn't break anything, but it didn't help either.
1720 It's confusing to put a bogus integer in a place where the actual
1721 value does not matter.
1722 (LIST_END_P): Remove unused macro and its bogus comment.
1723 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1725 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1726 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1728 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1729 We prefer signed types, and the value cannot exceed the EMACS_INT
1730 range anyway (because otherwise the length would not be representable).
1731 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1732 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1733 This avoids a GCC warning when WIDE_EMACS_INT.
1735 * indent.c (sane_tab_width): New function.
1736 (current_column, scan_for_column, Findent_to, position_indentation)
1737 (compute_motion): Use it. This is just for clarity.
1738 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1740 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1742 * lisp.h (lint_assume): New macro.
1743 * composite.c (composition_gstring_put_cache):
1744 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1746 * editfns.c, insdel.c:
1747 Omit unnecessary forward decls, to simplify future changes.
1749 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1751 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1753 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1754 Use much-faster test for byte-length change.
1755 Don't assume string byte-length fits in 'int'.
1756 Check that character arg fits in 'int'.
1757 (mapcar1): Declare byte as byte, for clarity.
1759 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1761 * fns.c (concat): Catch string overflow earlier.
1762 Do not rely on integer wraparound.
1764 * dispextern.h (struct it.overlay_strings_charpos)
1765 (struct it.selective): Now EMACS_INT, not int.
1766 * xdisp.c (forward_to_next_line_start)
1767 (back_to_previous_visible_line_start)
1768 (reseat_at_next_visible_line_start, next_element_from_buffer):
1769 Don't arbitrarily truncate the value of 'selective' to int.
1771 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1773 * composite.c: Don't truncate sizes to 'int'.
1774 (composition_gstring_p, composition_reseat_it)
1775 (composition_adjust_point): Use EMACS_INT, not int.
1776 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1777 not EMACS_UINT, for indexes.
1779 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1781 * buffer.c: Include <verify.h>.
1782 (struct sortvec.priority, struct sortstr.priority):
1783 Now EMACS_INT, not int.
1784 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1785 (struct sortstr.size, record_overlay_string)
1786 (struct sortstrlist.size, struct sortlist.used):
1787 Don't truncate size to int.
1788 (record_overlay_string): Check for size-calculation overflow.
1789 (init_buffer_once): Check at compile-time, not run-time.
1791 2011-06-22 Jim Meyering <meyering@redhat.com>
1793 Don't leak an XBM-image-sized buffer
1794 * image.c (xbm_load): Free the image buffer after using it.
1796 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1799 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1800 that Sun C diagnosed.
1801 * fns.c (secure_hash): Fix pointer signedness issue.
1802 * intervals.c (static_offset_intervals): New function.
1803 (offset_intervals): Use it.
1805 2011-06-21 Leo Liu <sdl.web@gmail.com>
1808 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1811 * fns.c (secure_hash): Rename from crypto_hash_function and change
1812 the first arg to accept symbols.
1813 (Fsecure_hash): New primitive.
1814 (syms_of_fns): New symbols.
1816 2011-06-20 Deniz Dogan <deniz@dogan.se>
1818 * process.c (Fset_process_buffer): Clarify return value in
1821 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1823 * dispnew.c (add_window_display_history): Use BVAR.
1825 * xdisp.c (debug_method_add): Use BVAR.
1826 (check_window_end, dump_glyph_matrix, dump_glyph)
1827 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1829 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1832 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1833 check till after the cache is created in init_frame_faces.
1835 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1837 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1839 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1841 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1842 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1843 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1845 Improve buffer-overflow checking (Bug#8873).
1846 * fileio.c (Finsert_file_contents):
1847 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1848 Remove the old (too-loose) buffer overflow checks.
1849 They weren't needed, since make_gap checks for buffer overflow.
1850 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1851 The old code merely checked for Emacs fixnum overflow, and relied
1852 on undefined (wraparound) behavior. The new code avoids undefined
1853 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1855 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1856 Tune. Don't use wider integers than needed. Don't use alloca.
1857 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1859 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1861 * insdel.c, lisp.h (buffer_overflow): New function.
1862 (insert_from_buffer_1, replace_range, replace_range_2):
1863 * insdel.c (make_gap_larger):
1864 * editfns.c (Finsert_char):
1865 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1867 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1869 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1871 Integer overflow and signedness fixes (Bug#8873).
1873 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1874 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1876 * fileio.c: Don't assume EMACS_INT fits in off_t.
1877 (emacs_lseek): New static function.
1878 (Finsert_file_contents, Fwrite_region): Use it.
1879 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1881 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1883 * fns.c: Don't overflow int when computing a list length.
1884 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1885 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1886 truncation on 64-bit hosts. Check for QUIT every
1887 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1888 faster and is responsive enough.
1889 (Flength): Report an error instead of overflowing an integer.
1890 (Fsafe_length): Return a float if the value is not representable
1891 as a fixnum. This shouldn't happen except in contrived situations.
1892 (Fnthcdr, Fsort): Don't assume list length fits in int.
1893 (Fcopy_sequence): Don't assume vector length fits in int.
1895 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1896 (header_size, word_size): New constants.
1897 (allocate_vectorlike): Don't check size overflow here.
1898 (allocate_vector): Check it here instead, since this is the only
1899 caller of allocate_vectorlike that could cause overflow.
1900 Check that the new vector's length is representable as a fixnum.
1902 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1903 The previous code was bogus. For example, next_almost_prime (32)
1904 returned 39, which is undesirable as it is a multiple of 3; and
1905 next_almost_prime (24) returned 25, which is a multiple of 5 so
1906 why was the code bothering to check for multiples of 7?
1908 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1910 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1912 Variadic C functions now count arguments with ptrdiff_t.
1913 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1914 Back then I didn't know that the Emacs coding style prefers signed int.
1915 Also, in the meantime I found a few more instances where arguments
1916 were being counted with int, which may truncate counts on 64-bit
1917 machines, or EMACS_INT, which may be unnecessarily wide.
1918 * lisp.h (struct Lisp_Subr.function.aMANY)
1919 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1920 Arg counts are now ptrdiff_t, not size_t.
1921 All variadic functions and their callers changed accordingly.
1922 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1923 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1924 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1925 * callint.c (Fcall_interactively): Check arg count for overflow,
1926 to avoid potential buffer overrun. Use signed char, not 'int',
1927 for 'varies' array, so that we needn't bother to check its size
1928 calculation for overflow.
1929 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1930 * eval.c (apply_lambda):
1931 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1932 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1933 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1935 * callint.c (Fcall_interactively): Don't use index var as event count.
1937 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1938 * mem-limits.h (SIZE): Remove; no longer used.
1940 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1942 Remove unnecessary casts.
1943 * xterm.c (x_term_init):
1944 * xfns.c (x_set_border_pixel):
1945 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1946 These aren't needed now that we assume ANSI C.
1948 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1949 It's more likely to cause problems (due to unsigned overflow)
1952 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1954 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1956 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1958 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1960 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1962 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1964 GLYPH_CODE_FACE returns EMACS_INT, not int.
1965 * dispextern.h (merge_faces):
1966 * xfaces.c (merge_faces):
1967 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1968 Don't assume EMACS_INT fits in int.
1970 * character.h (CHAR_VALID_P): Remove unused parameter.
1971 * fontset.c, lisp.h, xdisp.c: All uses changed.
1973 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1975 * fns.c (concat): Minor tuning based on overflow analysis.
1976 This doesn't fix any bugs. Use int to hold character, instead
1977 of constantly refetching from Emacs object. Use XFASTINT, not
1978 XINT, for value known to be a character. Don't bother comparing
1979 a single byte to 0400, as it's always less.
1981 * floatfns.c (Fexpt):
1982 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1984 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1987 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1989 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1990 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1991 incorrectly succeed when S was a string, because 4294967386 was
1992 truncated before it was used.
1994 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1995 Otherwise, an out-of-range integer could cause undefined behavior
1998 * composite.c: Use int, not EMACS_INT, for characters.
1999 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2000 EMACS_INT, for values that are known to be in character range.
2001 This doesn't fix any bugs but is the usual style inside Emacs and
2002 may generate better code on 32-bit machines.
2004 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2005 This is for reasons similar to the recent CHAR_STRING fix.
2006 * charset.c (Fencode_char): Check that character arg is actually
2007 a character. Pass an int to ENCODE_CHAR.
2008 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2009 wider than 'int', as a compile-time check to prevent future regressions
2012 * character.c (char_string): Remove unnecessary casts.
2014 Make sure a 64-bit char is never passed to CHAR_STRING.
2015 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2016 by silently ignoring the top 32 bits, allowing some values
2017 that were far too large to be valid characters.
2018 * character.h: Include <verify.h>.
2019 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2020 arguments are no wider than unsigned, as a compile-time check
2021 to prevent future regressions in this area.
2023 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2024 (Fsubst_char_in_region):
2026 * xdisp.c (decode_mode_spec_coding):
2027 Adjust to CHAR_STRING's new requirement.
2028 * editfns.c (Finsert_char, Fsubst_char_in_region):
2029 * fns.c (concat): Check that character args are actually
2030 characters. Without this test, these functions did the wrong
2031 thing with wildly out-of-range values on 64-bit hosts.
2033 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2034 These casts should not be needed on 32-bit hosts, either.
2035 * keyboard.c (read_char):
2036 * lread.c (Fload): Remove casts to unsigned.
2038 * lisp.h (UNSIGNED_CMP): New macro.
2039 This fixes comparison bugs on 64-bit hosts.
2040 (ASCII_CHAR_P): Use it.
2041 * casefiddle.c (casify_object):
2042 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2043 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2044 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2045 * dispextern.h (FACE_FROM_ID):
2046 * keyboard.c (read_char): Use UNSIGNED_CMP.
2048 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2049 not to EMACS_INT, to avoid GCC warning.
2051 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2053 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2054 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2055 isn't needed on 32-bit machines.
2057 * buffer.c (Fgenerate_new_buffer_name):
2058 Use EMACS_INT for count, not int.
2059 (advance_to_char_boundary): Return EMACS_INT, not int.
2061 * data.c (Qcompiled_function): Now static.
2063 * window.c (window_body_lines): Now static.
2065 * image.c (gif_load): Rename local to avoid shadowing.
2067 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2068 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2069 * alloc.c (make_save_value): Integer argument is now of type
2071 (mark_object): Use ptrdiff_t, not int.
2072 * lisp.h (pD): New macro.
2073 * print.c (print_object): Use it.
2075 * alloc.c: Use EMACS_INT, not int, to count objects.
2076 (total_conses, total_markers, total_symbols, total_vector_size)
2077 (total_free_conses, total_free_markers, total_free_symbols)
2078 (total_free_floats, total_floats, total_free_intervals)
2079 (total_intervals, total_strings, total_free_strings):
2080 Now EMACS_INT, not int. All uses changed.
2081 (Fgarbage_collect): Compute overall total using a double, so that
2082 integer overflow is less likely to be a problem. Check for overflow
2083 when converting back to an integer.
2084 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2085 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2086 These were 'int' variables that could overflow on 64-bit hosts;
2087 they were never used, so remove them instead of repairing them.
2088 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2089 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2090 Previously, this ceilinged at INT_MAX, but that doesn't work on
2092 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2094 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2095 (allocate_vectorlike): Check for ptrdiff_t overflow.
2096 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2097 when a (possibly-narrower) signed value would do just as well.
2098 We prefer using signed arithmetic, to avoid comparison confusion.
2100 * alloc.c: Catch some string size overflows that we were missing.
2101 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2102 for convenience in STRING_BYTES_MAX.
2103 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2104 The definition here is exact; the one in lisp.h was approximate.
2105 (allocate_string_data): Check for string overflow. This catches
2106 some instances we weren't catching before. Also, it catches
2107 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2108 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2109 and ptrdiff_t and EMACS_INT are both 64 bits.
2111 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2112 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2113 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2115 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2117 * alloc.c (Fmake_string): Check for out-of-range init.
2119 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2121 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2123 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2125 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2126 xg_get_default_scrollbar_width.
2128 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2129 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2130 (style_changed_cb): Call update_theme_scrollbar_width and call
2131 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2132 all frames (Bug#8505).
2133 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2134 Call gtk_window_set_resizable if HAVE_GTK3.
2135 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2136 and height if HAVE_GTK3 (Bug#8505).
2137 (scroll_bar_width_for_theme): New variable.
2138 (update_theme_scrollbar_width): New function.
2139 (xg_get_default_scrollbar_width): Move code to
2140 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2141 (xg_initialize): Call update_theme_scrollbar_width.
2143 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2145 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2147 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2149 * frame.c (make_frame): Call other_buffer_safely instead of
2152 * window.c (temp_output_buffer_show): Call display_buffer with
2153 second argument Vtemp_buffer_show_specifiers and reset latter
2154 immediately after the call.
2155 (Vtemp_buffer_show_specifiers): New variable.
2156 (auto_window_vscroll_p, next_screen_context_lines)
2157 (Vscroll_preserve_screen_position): Remove leading asterisks from
2160 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2162 Fix minor problems found by GCC 4.6.0 static checking.
2163 * buffer.c (Qclone_number): Remove for now, as it's unused.
2164 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2165 (record_buffer): Remove unused local.
2166 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2167 (set_frame_buffer_list): Remove; unused.
2168 * frame.h (other_visible_frames): Remove decl.
2169 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2170 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2171 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2173 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2174 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2175 Define only if HAVE_GPM.
2176 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2177 (update_hints_inhibit): Remove; never set. All uses removed.
2178 * widgetprv.h (emacsFrameClassRec): Remove decl.
2179 * window.c (delete_deletable_window): Now returns void, since it
2180 wasn't returning anything.
2181 (compare_window_configurations): Remove unused locals.
2182 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2183 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2184 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2185 the same widths as pointers. This follows up on the 2011-05-06 patch.
2186 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2187 * xterm.h: Likewise.
2188 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2190 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2192 * makefile.w32-in: Update dependencies.
2193 (LISP_H): Add lib/intprops.h.
2195 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2197 * image.c (gif_load): Add animation frame delay to the metadata.
2198 (syms_of_image): Use DEFSYM. New symbol `delay'.
2200 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2202 * window.c (delete_deletable_window): Re-add.
2203 (Fset_window_configuration): Rewrite to handle dead buffers and
2204 consequently deletable windows.
2205 (window_tree, Fwindow_tree): Remove. Supply functionality in
2207 (compare_window_configurations): Simplify code.
2209 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2211 * image.c (imagemagick_load_image): Fix type mismatch.
2212 (Fimagemagick_types): Likewise.
2214 * window.h (replace_buffer_in_windows): Declare.
2216 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2218 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2219 Qclone_number. Remove external declaration of Qdelete_window.
2220 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2222 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2223 Run Qbuffer_list_update_hook if allowed.
2224 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2225 buffer list implementation.
2226 (other_buffer_safely): New function.
2227 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2228 calls to replace_buffer_in_windows and
2229 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2231 (record_buffer): Inhibit quitting and rewrite using quittable
2232 functions. Run Qbuffer_list_update_hook if allowed.
2233 (Frecord_buffer, Funrecord_buffer): New functions.
2234 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2235 Move switch-to-buffer to window.el.
2236 (bury-buffer): Move to window.el.
2237 (Vbuffer_list_update_hook): New variable.
2239 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2242 * window.h (resize_frame_windows): Move up in code.
2243 (Fwindow_frame): Remove EXFUN.
2244 (replace_buffer_in_all_windows): Remove prototype.
2245 (replace_buffer_in_windows_safely): Add prototype.
2247 * window.c: Declare Qdelete_window static again. Move down
2248 declaration of select_count.
2249 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2250 (Fother_window): Move to window.el.
2251 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2252 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2253 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2255 (replace_buffer_in_windows): Implement by calling
2256 Qreplace_buffer_in_windows.
2257 (replace_buffer_in_all_windows): Remove with some functionality
2258 moved into replace_buffer_in_windows_safely.
2259 (replace_buffer_in_windows_safely): New function.
2260 (select_window_norecord, select_frame_norecord): Move in front
2261 of run_window_configuration_change_hook. Remove now obsolete
2263 (Fset_window_buffer): Rewrite doc-string.
2264 Call Qrecord_window_buffer.
2265 (keys_of_window): Move binding for other-window to window.el.
2267 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2269 * dispextern.h (struct image): Replace data member, whose int_val
2270 and ptr_val fields were not used by anything, with a single
2273 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2274 (gif_clear_image, gif_load, imagemagick_load_image)
2275 (gs_clear_image, gs_load): Callers changed.
2277 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2279 * buffer.h: Include <time.h>, for time_t.
2280 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2282 Fix minor problems found by static checking.
2284 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2286 Make identifiers static if they are not used in other modules.
2287 * data.c (Qcompiled_function, Qframe, Qvector):
2288 * image.c (QimageMagick, Qsvg):
2289 * minibuf.c (Qmetadata):
2290 * window.c (resize_window_check, resize_root_window): Now static.
2291 * window.h (resize_window_check, resize_root_window): Remove decls.
2293 * window.c (window_deletion_count, delete_deletable_window):
2295 (window_body_lines): Now static.
2296 (Fdelete_other_windows_internal): Mark vars as initialized.
2297 Make sure 'resize_failed' is initialized.
2298 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2299 (resize_window_apply): Remove unused local.
2300 * window.h (delete_deletable_window): Remove decl.
2302 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2303 (imagemagick_load_image): Fix pointer signedness problem by changing
2304 last arg from unsigned char * to char *. All uses changed.
2305 Also, fix a local for similar reasons.
2306 Remove unused locals. Remove locals to avoid shadowing.
2307 (fn_rsvg_handle_free): Remove; unused.
2308 (svg_load, svg_load_image): Fix pointer signedness problem.
2309 (imagemagick_load_image): Don't use garbage pointer image_wand.
2311 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2313 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2315 * image.c (gif_load): Fix omitted cast error introduced by
2318 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2320 * window.h (resize_proportionally, orig_total_lines)
2321 (orig_top_line): Remove from window structure.
2322 (set_window_height, set_window_width, change_window_heights)
2323 (Fdelete_window): Remove prototypes.
2324 (resize_frame_windows): Remove duplicate declaration.
2326 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2328 * window.h (resize_frame_windows, resize_window_check)
2329 (delete_deletable_window, resize_root_window)
2330 (resize_frame_windows): Declare prototypes.
2332 * window.c (resize_window_apply): Make definition be "static" to
2333 match the prototype.
2335 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2337 * window.c: Remove declarations of Qwindow_size_fixed,
2338 window_min_size_1, window_min_size_2, window_min_size,
2339 size_window, window_fixed_size_p, enlarge_window, delete_window.
2340 Remove static from declaration of Qdelete_window, it's
2341 temporarily needed by Fbury_buffer.
2342 (replace_window): Don't assign orig_top_line and
2344 (Fdelete_window, delete_window): Remove. Window deletion is
2345 handled by window.el.
2346 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2347 Replace Fdelete_window calls with calls to Qdelete_window.
2348 (Fdelete_other_windows): Remove. Deleting other windows is
2349 handled by window.el.
2350 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2351 handled in window.el.
2352 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2353 Window minimum sizes are handled in window.el.
2354 (shrink_windows, size_window, set_window_height)
2355 (set_window_width, change_window_heights, window_height)
2356 (window_width, CURBEG, CURSIZE, enlarge_window)
2357 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2358 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2359 handled in window.el.
2360 (make_dummy_parent): Rename to make_parent_window and give it a
2361 second argument horflag.
2362 (make_window): Don't set resize_proportionally any more.
2363 (Fsplit_window): Remove. Windows are split in window.el.
2364 (save_restore_action, save_restore_orig_size)
2365 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2366 Resize mini windows in window.el.
2367 (grow_mini_window, shrink_mini_window): Implement by calling
2368 Qresize_root_window_vertically, resize_window_check and
2369 resize_window_apply.
2370 (saved_window, Fset_window_configuration, save_window_save):
2371 Do not handle orig_top_line, orig_total_lines, and
2372 resize_proportionally.
2373 (window_min_height, window_min_width): Move to window.el.
2374 (keys_of_window): Move bindings for delete-other-windows,
2375 split-window, delete-window and enlarge-window to window.el.
2377 * buffer.c: Temporarily extern Qdelete_window.
2378 (Fbury_buffer): Temporarily call Qdelete_window instead of
2379 Fdelete_window (Fbury_buffer will move to window.el soon).
2381 * frame.c (set_menu_bar_lines_1): Remove code handling
2382 orig_top_line and orig_total_lines.
2384 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2385 set_window_height but set heights directly.
2386 (change_frame_size_1): Use resize_frame_windows.
2388 * xdisp.c (init_xdisp): Don't use set_window_height but set
2391 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2392 Use resize_frame_windows instead of change_window_heights and run
2393 run_window_configuration_change_hook.
2395 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2396 instead of change_window_heights and run
2397 run_window_configuration_change_hook.
2399 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2401 * window.c (replace_window): Rename second argument REPLACEMENT to
2402 NEW. New third argument SETFLAG. Rewrite.
2403 (delete_window, make_dummy_parent): Call replace_window with
2405 (window_list_1): Move down in code.
2406 (run_window_configuration_change_hook): Move set_buffer part
2407 before select_frame_norecord part in order to unwind correctly.
2408 Rename count1 to count.
2409 (recombine_windows, delete_deletable_window, resize_root_window)
2410 (Fdelete_other_windows_internal)
2411 (Frun_window_configuration_change_hook, make_parent_window)
2412 (resize_window_check, resize_window_apply, Fresize_window_apply)
2413 (resize_frame_windows, Fsplit_window_internal)
2414 (Fdelete_window_internal, Fresize_mini_window_internal):
2416 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2418 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2420 * window.h (window): Add some new members to window structure -
2421 normal_lines, normal_cols, new_total, new_normal, clone_number,
2422 splits, nest, prev_buffers, next_buffers.
2423 (WINDOW_TOTAL_SIZE): Move here from window.c.
2424 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2426 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2428 (make_dummy_parent): Set new members of windows structure.
2429 (make_window): Move down in code. Handle new members of window
2431 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2432 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2433 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2434 (Fset_window_prev_buffers, Fwindow_next_buffers)
2435 (Fset_window_next_buffers, Fset_window_clone_number):
2437 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2438 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2440 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2441 Argument WINDOW can be now internal window too.
2442 (Fwindow_use_time): Move up in code.
2443 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2445 (Fset_window_configuration, saved_window)
2446 (Fcurrent_window_configuration, save_window_save): Handle new
2447 members of window structure.
2448 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2449 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2450 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2451 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2452 Qget_mru_window, Qresize_root_window,
2453 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2454 Qauto_buffer_name; staticpro them.
2456 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2458 * window.c (Fwindow_total_size, Fwindow_left_column)
2459 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2460 (Fwindow_list_1): New functions.
2461 (window_box_text_cols): Replace with window_body_cols.
2462 (Fwindow_width, Fscroll_left, Fscroll_right):
2463 Use window_body_cols instead of window_box_text_cols.
2464 (delete_window, Fset_window_configuration):
2465 Call delete_all_subwindows with window as argument.
2466 (delete_all_subwindows): Take a window as argument and not a
2468 (window_loop): Remove handling of GET_LRU_WINDOW and
2470 (Fget_lru_window, Fget_largest_window): Move to window.el.
2472 * window.h: Extern window_body_cols instead of
2473 window_box_text_cols. delete_all_subwindows now takes a
2474 Lisp_Object as argument.
2476 * indent.c (compute_motion, Fcompute_motion):
2477 Use window_body_cols instead of window_box_text_cols.
2479 * frame.c (delete_frame): Call delete_all_subwindows with root
2482 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2484 * fns.c (Fputhash): Document return value.
2486 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2488 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2490 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2492 Cons<->int and similar integer overflow fixes (Bug#8794).
2494 Check for overflow when converting integer to cons and back.
2495 * charset.c (Fdefine_charset_internal, Fdecode_char):
2496 Use cons_to_unsigned to catch overflow.
2497 (Fencode_char): Use INTEGER_TO_CONS.
2498 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2499 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2500 * data.c (long_to_cons, cons_to_long): Remove.
2501 (cons_to_unsigned, cons_to_signed): New functions.
2502 These signal an error for invalid or out-of-range values.
2503 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2504 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2505 * font.c (Ffont_variation_glyphs):
2506 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2507 * lisp.h: Include <intprops.h>.
2508 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2509 (cons_to_signed, cons_to_unsigned): New decls.
2510 (long_to_cons, cons_to_long): Remove decls.
2511 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2512 (Fprimitive_undo): Use CONS_TO_INTEGER.
2513 * xfns.c (Fx_window_property): Likewise.
2514 * xselect.c: Include <limits.h>.
2515 (x_own_selection, selection_data_to_lisp_data):
2516 Use INTEGER_TO_CONS.
2517 (x_handle_selection_request, x_handle_selection_clear)
2518 (x_get_foreign_selection, Fx_disown_selection_internal)
2519 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2520 (lisp_data_to_selection_data): Use cons_to_unsigned.
2521 (x_fill_property_data): Use cons_to_signed.
2522 Report values out of range.
2524 Check for buffer and string overflow more precisely.
2525 * buffer.h (BUF_BYTES_MAX): New macro.
2526 * lisp.h (STRING_BYTES_MAX): New macro.
2527 * alloc.c (Fmake_string):
2528 * character.c (string_escape_byte8):
2529 * coding.c (coding_alloc_by_realloc):
2530 * doprnt.c (doprnt):
2531 * editfns.c (Fformat):
2533 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2534 since they may not be the same number.
2535 * editfns.c (Finsert_char):
2536 * fileio.c (Finsert_file_contents):
2537 Likewise for BUF_BYTES_MAX.
2539 * image.c: Use ptrdiff_t, not int, for sizes.
2540 (slurp_file): Switch from int to ptrdiff_t.
2542 (slurp_file): Check that file size fits in both size_t (for
2543 malloc) and ptrdiff_t (for sanity and safety).
2545 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2546 if b->modtime has its maximal value.
2548 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2550 Don't assume time_t can fit into int.
2551 * buffer.h (struct buffer.modtime): Now time_t, not int.
2552 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2553 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2555 Minor fixes for signed vs unsigned integers.
2556 * character.h (MAYBE_UNIFY_CHAR):
2557 * charset.c (maybe_unify_char):
2558 * keyboard.c (read_char, reorder_modifiers):
2559 XINT -> XFASTINT, since the integer must be nonnegative.
2560 * ftfont.c (ftfont_spec_pattern):
2561 * keymap.c (access_keymap, silly_event_symbol_error):
2562 XUINT -> XFASTINT, since the integer must be nonnegative.
2563 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2564 since it makes no difference and we prefer signed.
2565 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2566 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2569 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2571 * window.h (Fwindow_frame): Declare.
2573 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2575 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2576 (SPARE_MEMORY): Always define.
2577 (LARGE_REQUEST): Remove.
2578 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2580 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2582 * lisp.h: Move EXFUNS for Fframe_root_window,
2583 Fframe_first_window and Fset_frame_selected_window to window.h.
2585 * window.h: Move EXFUNS for Fframe_root_window,
2586 Fframe_first_window and Fset_frame_selected_window here from
2589 * frame.c (Fwindow_frame, Fframe_first_window)
2590 (Fframe_root_window, Fframe_selected_window)
2591 (Fset_frame_selected_window): Move to window.c.
2592 (Factive_minibuffer_window): Move to minibuf.c.
2593 (Fother_visible_frames_p): New function.
2595 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2597 * window.c (decode_window, decode_any_window): Move up in code.
2598 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2599 (inhibit_frame_unsplittable): Remove unused variable.
2600 (Fwindow_buffer): Move up and rewrite doc-string.
2601 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2602 (Fwindow_prev): New functions.
2603 (Fwindow_frame): Move here from frame.c. Accept any window as
2605 (Fframe_root_window, Fframe_first_window)
2606 (Fframe_selected_window): Move here from frame.c. Accept frame
2607 or arbitrary window as argument. Update doc-strings.
2608 (Fminibuffer_window): Move up in code.
2609 (Fwindow_minibuffer_p): Move up in code and simplify.
2610 (Fset_frame_selected_window): Move here from frame.c.
2612 (Fselected_window, select_window, Fselect_window): Move up in
2613 code. Minor doc-string fixes.
2615 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2617 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2618 Do not assume that spare memory exists; that assumption is valid
2619 only if SYSTEM_MALLOC.
2620 (LARGE_REQUEST): New macro, so that the issue of large requests
2621 is separated from the issue of spare memory.
2623 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2625 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2628 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2630 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2633 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2635 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2637 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2639 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2640 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2642 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2644 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2646 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2648 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2649 (x_clipboard_manager_save): Add return value.
2650 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2652 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2653 Obey Vx_select_enable_clipboard_manager. Catch errors in
2654 x_clipboard_manager_save (Bug#8779).
2655 (Vx_select_enable_clipboard_manager): New variable.
2656 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2658 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2660 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2662 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2664 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2665 in the current matrix if keep_current_p is non-zero.
2667 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2669 * bidi.c (bidi_level_of_next_char): Fix last change.
2671 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2673 Support bidi reordering of text covered by display properties.
2675 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2676 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2677 (bidi_cache_search, bidi_cache_iterator_state)
2678 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2679 (bidi_level_of_next_char, bidi_move_to_visually_next):
2680 Support character positions inside a run of characters covered by a
2682 (bidi_paragraph_init, bidi_resolve_explicit_1)
2683 (bidi_level_of_next_char): Call bidi_fetch_char and
2684 bidi_fetch_char_advance instead of FETCH_CHAR and
2686 (bidi_init_it): Initialize new members.
2687 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2689 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2690 instead of using explicit *_CHAR codes.
2691 (bidi_resolve_explicit, bidi_resolve_weak):
2692 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2693 bidirectional text is supported only in multibyte buffers.
2694 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2695 it to initialize the frame_window_p member of struct bidi_it.
2696 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2697 (bidi_resolve_explicit, bidi_resolve_weak)
2698 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2699 bidi_it->nchars is non-positive.
2700 (bidi_level_of_next_char): Don't try to lookup the cache for the
2701 next/previous character if nothing is cached there yet, or if we
2702 were just reseat()'ed to a new position.
2704 * xdisp.c (set_cursor_from_row): Set start and stop points
2705 according to the row's direction when priming the loop that looks
2706 for the glyph on which to display cursor.
2707 (single_display_spec_intangible_p): Function deleted.
2708 (display_prop_intangible_p): Reimplement to call
2709 handle_display_spec instead of single_display_spec_intangible_p.
2710 Accept 3 additional arguments needed by handle_display_spec.
2711 This fixes incorrect cursor motion across display property with complex
2712 values: lists, `(when COND...)' forms, etc.
2713 (single_display_spec_string_p): Support property values that are
2714 lists with the argument STRING its top-level element.
2715 (display_prop_string_p): Fix the condition for processing a
2716 property that is a list to be consistent with handle_display_spec.
2717 (handle_display_spec): New function, refactored from the
2718 last portion of handle_display_prop.
2719 (compute_display_string_pos): Accept additional argument
2720 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2721 value of a `display' property is a "replacing spec".
2722 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2723 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2724 the display property, but just return a value indicating whether
2725 the display property will replace the characters it covers.
2726 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2727 frame_window_p members of struct bidi_it.
2728 (compute_display_string_pos, compute_display_string_end):
2730 (push_it): Accept second argument POSITION, where pop_it should
2731 jump to continue iteration.
2732 (reseat_1): Initialize bidi_it.disp_pos.
2734 * keyboard.c (adjust_point_for_property): Adjust the call to
2735 display_prop_intangible_p to its new signature.
2737 * dispextern.h (struct bidi_it): New member frame_window_p.
2738 (bidi_init_it): Update prototypes.
2739 (display_prop_intangible_p): Update prototype.
2740 (compute_display_string_pos, compute_display_string_end):
2742 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2745 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2747 Malloc failure behavior now depends on size of allocation.
2748 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2749 * lisp.h: Change signatures accordingly.
2750 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2751 All callers changed. (Bug#8762)
2753 * gnutls.c: Use Emacs's memory allocators.
2754 Without this change, the gnutls library would invoke malloc etc.
2755 directly, which causes problems on non-SYNC_INPUT hosts, and which
2756 runs afoul of improving memory_full behavior. (Bug#8761)
2757 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2758 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2759 xfree instead of the default malloc, realloc, free.
2760 (Fgnutls_boot): No need to check for memory allocation failure,
2761 since xmalloc does that for us.
2763 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2764 * category.c (hash_get_category_set):
2765 * ccl.c (ccl_driver):
2766 * charset.c (Fdefine_charset_internal):
2767 * charset.h (struct charset.hash_index):
2768 * composite.c (get_composition_id, gstring_lookup_cache)
2769 (composition_gstring_put_cache):
2770 * composite.h (struct composition.hash_index):
2771 * dispextern.h (struct image.hash):
2772 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2773 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2774 (hashfn_equal, hashfn_user_defined, make_hash_table)
2775 (maybe_resize_hash_table, hash_lookup, hash_put)
2776 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2777 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2778 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2779 * image.c (make_image, search_image_cache, lookup_image)
2780 (xpm_put_color_table_h):
2781 * lisp.h (struct Lisp_Hash_Table):
2782 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2783 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2784 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2785 * alloc.c (allocate_vectorlike):
2786 Check for overflow in vector size calculations.
2787 * ccl.c (ccl_driver):
2788 Check for overflow when converting EMACS_INT to int.
2789 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2790 need to be updated by these changes.
2791 * fns.c (make_hash_table, maybe_resize_hash_table):
2792 Check for integer overflow with large hash tables.
2793 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2794 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2795 (SXHASH_REDUCE): New macro.
2796 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2797 Use it instead of discarding useful hash info with large hash values.
2798 (sxhash_float): New function.
2799 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2800 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2801 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2802 Rewrite to use FIXNUM_BITS, as this simplifies things.
2803 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2804 Adjust signatures to match updated version of code.
2805 (consing_since_gc): Now EMACS_INT, since a single hash table can
2806 use more than INT_MAX bytes.
2808 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2810 Make it possible to build with GCC-4.6+ -O2 -flto.
2812 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2814 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2816 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2817 Call minibuffer-inactive-mode.
2819 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2821 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2822 Update dependencies.
2824 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2826 * data.c (init_data): Remove code for UTS, this system is not
2829 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2831 Don't force ./temacs to start in terminal mode.
2833 * frame.c (make_initial_frame): Initialize faces in all cases, not
2834 only when CANNOT_DUMP is defined.
2835 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2837 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2839 * dispnew.c (add_window_display_history): Use const for the string
2840 pointer. Remove declaration, not needed.
2842 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2844 Use 'inline', not 'INLINE'.
2845 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2846 * alloc.c, fontset.c (INLINE): Remove.
2847 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2848 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2849 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2850 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2851 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2853 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2855 Make it possible to run ./temacs.
2857 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2858 syms_of_callproc does the same thing. Remove test for
2859 "initialized", do it in the caller.
2860 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2862 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2864 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2865 (read_minibuf): Use get_minibuffer.
2866 (syms_of_minibuf): Use DEFSYM.
2867 (Qmetadata): New var.
2868 * data.c (Qbuffer): Don't make it static.
2869 (syms_of_data): Use DEFSYM.
2871 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2873 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2874 (CCL_CODE_MIN): New macro.
2876 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2878 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2880 * eval.c (Qdebug): Now static.
2881 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2882 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2883 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2885 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2887 * image.c: Various fixes to ImageMagick code comments.
2888 (Fimagemagick_types): Doc fix.
2890 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2892 Minor fixes prompted by GCC 4.6.0 warnings.
2894 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2896 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2897 (x_clipboard_manager_save_all): Move extern decl to ...
2898 * xterm.h: ... here, so that it can be checked for consistency.
2900 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2902 * xselect.c (x_clipboard_manager_save_frame)
2903 (x_clipboard_manager_save_all): New functions.
2904 (Fx_clipboard_manager_save): Lisp function deleted.
2906 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2907 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2909 * xterm.h: Update prototype.
2911 2011-05-28 William Xu <william.xwl@gmail.com>
2913 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2916 2011-05-28 Jim Meyering <meyering@redhat.com>
2918 Avoid a sign-extension bug in crypto_hash_function.
2919 * fns.c (to_uchar): Define.
2920 (crypto_hash_function): Use it to convert some newly-signed
2921 variables to unsigned, to avoid sign-extension bugs. For example,
2922 without this change, (md5 "truc") would evaluate to
2923 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2924 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2925 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2927 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2929 Integer overflow fixes.
2931 * dbusbind.c: Serial number integer overflow fixes.
2932 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2933 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2934 to hold a serial number that is too large for a fixnum.
2935 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2936 Check for serial numbers out of range. Decode any serial number
2937 that was so large that it became a float. (Bug#8722)
2939 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2940 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2941 Use XFASTINT rather than XUINT when numbers are nonnegative.
2942 (xd_append_arg, Fdbus_method_return_internal):
2943 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2944 arguments, check that Lisp number is nonnegative, rather than
2945 silently wrapping negative numbers around. (Bug#8722)
2946 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2949 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2951 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2953 ccl: add integer overflow checks
2954 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2955 (IN_INT_RANGE): New macros.
2956 (ccl_driver): Use them to check for integer overflow when
2957 decoding a CCL program. Many of the new checks are whether XINT (x)
2958 fits in int; it doesn't always, on 64-bit hosts. The new version
2959 doesn't catch all possible integer overflows, but it's an
2960 improvement. (Bug#8719)
2962 * alloc.c (make_event_array): Use XINT, not XUINT.
2963 There's no need for unsigned here.
2965 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2966 This follows up to the 2011-05-06 change that substituted uintptr_t
2967 for EMACS_INT. This case wasn't caught back then.
2969 Rework Fformat to avoid integer overflow issues.
2970 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2971 now (part of C89). Include <verify.h>.
2972 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2973 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2974 (Fformat): Avoid the prepass trying to compute sizes; it was only
2975 approximate and thus did not catch overflow reliably. Instead, walk
2976 through the format just once, formatting and computing sizes as we go,
2977 checking for integer overflow at every step, and allocating a larger
2978 buffer as needed. Keep track separately whether the format is
2979 multibyte. Keep only the most-recently calculated precision, rather
2980 than them all. Record whether each argument has been converted to
2981 string. Use EMACS_INT, not int, for byte and char and arg counts.
2982 Support field widths and precisions larger than INT_MAX. Avoid
2983 sprintf's undefined behavior with conversion specifications such as %#d
2984 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2985 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2986 formatting out-of-range floating point numbers with int
2989 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2991 * data.c: Avoid integer truncation in expressions involving floats.
2992 * data.c: Include <intprops.h>.
2993 (arith_driver): When there's an integer overflow in an expression
2994 involving floating point, convert the integers to floating point
2995 so that the resulting value does not suffer from catastrophic
2996 integer truncation. For example, on a 64-bit host (* 4
2997 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2998 Do not rely on undefined behavior after integer overflow.
3000 merge count_size_as_multibyte, parse_str_to_multibyte
3001 * character.c, character.h (count_size_as_multibyte):
3002 Rename from parse_str_to_multibyte; all uses changed.
3003 Check for integer overflow.
3004 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3005 since it's now a duplicate of the other. This is more of
3006 a character than a buffer op, so better that it's in character.c.
3007 * fns.c, print.c: Adjust to above changes.
3009 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3011 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3013 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3015 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3016 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3017 (x_clipboard_manager_save): Now static.
3018 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3020 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3021 (crypto_hash_function): Now static.
3022 Fix pointer signedness problems. Avoid unnecessary initializations.
3024 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3026 * termhooks.h (Vselection_alist): Make it terminal-local.
3028 * terminal.c (create_terminal): Initialize it.
3030 * xselect.c: Support for clipboard managers.
3031 (Vselection_alist): Move to termhooks.h as terminal-local var.
3032 (LOCAL_SELECTION): New macro.
3033 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3034 (symbol_to_x_atom): Remove gratuitous arg.
3035 (x_handle_selection_request, lisp_data_to_selection_data)
3036 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3037 (x_own_selection, x_get_local_selection, x_convert_selection):
3038 New arg, specifying work frame. Use terminal-local Vselection_alist.
3039 (some_frame_on_display): Delete unused function.
3040 (Fx_own_selection_internal, Fx_get_selection_internal)
3041 (Fx_disown_selection_internal, Fx_selection_owner_p)
3042 (Fx_selection_exists_p): New optional frame arg.
3043 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3044 (x_handle_selection_clear): Don't treat other terminals with the
3045 same keyboard specially. Use the terminal-local Vselection_alist.
3046 (x_clear_frame_selections): Use Frun_hook_with_args.
3048 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3050 * xterm.h: Add support for those atoms.
3052 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3054 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3055 (converted_selections, conversion_fail_tag): New global variables.
3056 (x_selection_request_lisp_error): Free the above.
3057 (x_get_local_selection): Remove unnecessary code.
3058 (x_reply_selection_request): Args changed; handle arbitrary array
3059 of converted selections stored in converted_selections.
3060 Separate the XChangeProperty and SelectionNotify steps.
3061 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3062 (x_convert_selection): New function.
3063 (x_handle_selection_event): Simplify.
3064 (x_get_foreign_selection): Don't ignore incoming requests while
3065 waiting for an answer; this will fail when we implement
3066 SAVE_TARGETS, and seems unnecessary anyway.
3067 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3068 (Vx_sent_selection_functions): Doc fix.
3070 2011-05-26 Leo Liu <sdl.web@gmail.com>
3072 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3074 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3076 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3078 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3079 for fringe update if it has periodic bitmap.
3080 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3081 and fringe_bitmap_periodic_p.
3083 * fringe.c (get_fringe_bitmap_data): New function.
3084 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3085 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3086 row. Mark glyph row for fringe update if periodicity changed.
3088 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3089 for fringe update unless it has periodic bitmap.
3091 2011-05-25 Kenichi Handa <handa@m17n.org>
3093 * xdisp.c (get_next_display_element): Set correct it->face_id for
3094 a static composition.
3096 2011-05-24 Leo Liu <sdl.web@gmail.com>
3099 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3101 * fns.c (crypto_hash_function, Fsha1): New function.
3102 (Fmd5): Use crypto_hash_function.
3103 (syms_of_fns): Add Ssha1.
3105 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3107 * gnutls.c: Remove unused macros.
3108 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3109 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3110 Remove macros that are defined and never used.
3111 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3113 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3115 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3116 (Fx_get_selection_internal): Minor cleanup.
3117 (Fx_own_selection_internal): Rename arguments for consistency with
3120 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3122 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3124 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3126 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3128 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3130 * dispnew.c (scrolling_window): Don't exclude the case that the
3131 last enabled row in the desired matrix touches the bottom boundary.
3133 2011-05-21 Glenn Morris <rgm@gnu.org>
3135 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3136 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3137 and add some more files.
3139 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3141 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3142 report_file_error introduced by the change from 2011-05-07.
3144 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3146 * systime.h (Time): Define only if emacs is defined.
3147 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3148 where the include path doesn't have X11/X.h by default. See
3149 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3151 2011-05-20 Kenichi Handa <handa@m17n.org>
3153 * composite.c (find_automatic_composition): Fix previous change.
3155 2011-05-20 Glenn Morris <rgm@gnu.org>
3157 * lisp.mk: New file, split from Makefile.in.
3158 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3159 (shortlisp): Remove.
3160 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3162 2011-05-19 Glenn Morris <rgm@gnu.org>
3164 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3165 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3166 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3167 (lisp): Set the order to that of loadup.el.
3168 (shortlisp): Make it a copy of $lisp.
3169 (SOME_MACHINE_LISP): Remove.
3170 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3171 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3173 2011-05-18 Kenichi Handa <handa@m17n.org>
3175 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3176 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3177 (find_automatic_composition): Mostly rewrite for efficiency.
3179 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3181 * makefile.w32-in: Update dependencies.
3183 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3185 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3186 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3188 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3190 Fix some integer overflow issues, such as string length overflow.
3192 * insdel.c (count_size_as_multibyte): Check for string overflow.
3194 * character.c (lisp_string_width): Check for string overflow.
3195 Use EMACS_INT, not int, for string indexes and lengths; in
3196 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3197 the resulting string length overflows an EMACS_INT; instead,
3198 report a string overflow if no precision given. When checking for
3199 precision exhaustion, use a check that cannot possibly have
3200 integer overflow. (Bug#8675)
3201 * character.h (lisp_string_width): Adjust to new signature.
3203 * alloc.c (string_overflow): New function.
3204 (Fmake_string): Use it. This doesn't change behavior, but saves
3205 a few bytes and will simplify future changes.
3206 * character.c (string_escape_byte8): Likewise.
3207 * lisp.h (string_overflow): New decl.
3209 Fixups, following up to the user-interface timestamp change.
3210 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3211 for UI timestamps, instead of unsigned long.
3212 * msdos.c (mouse_get_pos): Likewise.
3213 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3214 * w32gui.h (Time): Define by including "systime.h" rather than by
3215 declaring it ourselves. (Bug#8664)
3217 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3218 * image.c (clear_image_cache): Likewise.
3220 * term.c (term_mouse_position): Don't assume time_t wraparound.
3222 Be more systematic about user-interface timestamps.
3223 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3224 and sometimes 'EMACS_UINT', to represent these timestamps.
3225 This change causes it to use 'Time' uniformly, as that's what X uses.
3226 This makes the code easier to follow, and makes it easier to catch
3227 integer overflow bugs such as Bug#8664.
3228 * frame.c (Fmouse_position, Fmouse_pixel_position):
3229 Use Time, not unsigned long, for user-interface timestamps.
3230 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3231 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3232 * keyboard.h (last_event_timestamp): Likewise.
3233 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3234 * menu.h (xmenu_show): Likewise.
3235 * term.c (term_mouse_position): Likewise.
3236 * termhooks.h (struct input_event.timestamp): Likewise.
3237 (struct terminal.mouse_position_hook): Likewise.
3238 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3239 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3240 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3241 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3243 * menu.h, termhooks.h: Include "systime.h", for Time.
3245 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3246 Don't assume that the difference between two unsigned long values
3247 can fit into an integer. At this point, we know button_down_time
3248 <= event->timestamp, so the difference must be nonnegative, so
3249 there's no need to cast the result if double-click-time is
3250 nonnegative, as it should be; check that it's nonnegative, just in
3251 case. This bug is triggered when events are more than 2**31 ms
3252 apart (about 25 days). (Bug#8664)
3254 * xselect.c (last_event_timestamp): Remove duplicate decl.
3255 (x_own_selection): Remove needless cast to unsigned long.
3257 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3258 that always fit in int. Use a sentinel instead of a counter, to
3259 avoid a temp and to allay GCC's concerns about possible int overflow.
3260 * frame.h (struct frame): Use int for menu_bar_items_used
3261 instead of EMACS_INT, since it always fits in int.
3263 * menu.c (grow_menu_items): Check for int overflow.
3265 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3267 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3268 Before, the code was not consistent. These values cannot exceed
3269 2**31 - 1 so there's no need to make them unsigned.
3270 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3271 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3272 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3274 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3276 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3277 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3278 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3279 presumably because the widths might not match.
3281 * window.c (size_window): Avoid needless test at loop start.
3283 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3285 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3287 2011-05-12 Drew Adams <drew.adams@oracle.com>
3289 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3291 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3293 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3294 `width' to `bar_area_x' and `bar_area_width', respectively.
3295 (x_scroll_run): Take account of fringe background extension.
3297 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3298 Rename local vars `left' and `width' to `bar_area_x' and
3299 `bar_area_width', respectively.
3300 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3301 background extension.
3303 2011-05-10 Jim Meyering <meyering@redhat.com>
3305 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3307 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3309 * image.c (Finit_image_library): Return t for built-in image types,
3310 like pbm and xbm. (Bug#8640)
3312 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3314 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3316 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3318 * w32console.c (Fset_screen_color): Doc fix.
3319 (Fget_screen_color): New function.
3320 (syms_of_ntterm): Defsubr it.
3322 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3323 unlink the temporary file if Fcall_process didn't create it in the
3325 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3326 child process will be redirected to a file specified with `:file'.
3327 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3328 cue to call_process_cleanup not to close that handle.
3330 2011-05-07 Ben Key <bkey76@gmail.com>
3332 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3333 one of two shell specific rules, either bootstrap-temacs-CMD or
3334 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3335 to the previous implementation of the bootstrap-temacs rule.
3336 The bootstrap-temacs-CMD rule is similar to the previous
3337 implementation of the bootstrap-temacs rule except that it
3338 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3341 These changes, along with some changes to nt/configure.bat,
3342 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3343 earlier fix to add support for --cflags and --ldflags options
3344 that include quotes so that it works whether make uses cmd or
3347 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3349 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3350 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3352 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3353 a string. Handle both cases.
3354 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3355 (Fdbus_register_method): Use Qinvalid_function.
3357 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3359 * makefile.w32-in: Update dependencies.
3360 (LISP_H): Add inttypes.h and stdin.h.
3361 (PROCESS_H): Add unistd.h.
3363 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3365 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3366 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3368 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3370 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3372 * term.c (vfatal): Remove stray call to va_end.
3373 It's not needed and the C Standard doesn't allow it here anyway.
3375 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3376 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3378 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3381 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3383 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3385 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3387 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3389 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3391 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3392 * charset.c (Fdefine_charset_internal): Don't initialize
3393 charset.code_space[15]. The value was garbage, on hosts with
3394 32-bit int (Bug#8600).
3396 * lread.c (read_integer): Be more consistent with string-to-number.
3397 Use string_to_number to do the actual conversion; this avoids
3398 rounding errors and fixes some other screwups. Without this fix,
3399 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3400 (digit_to_number): Move earlier, for benefit of read_integer.
3401 Return -1 if the digit is out of range for the base, -2 if it is
3402 not a digit in any supported base. (Bug#8602)
3404 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3406 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3407 to match comment at start of function. This also removes a
3408 GCC warning about overflow in a 32+64-bit port.
3410 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3412 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3413 Reported by Stefan Monnier in
3414 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3415 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3416 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3418 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3419 (EMACS_UINTPTR): Likewise, with uintptr_t.
3421 * lisp.h: Prefer 64-bit EMACS_INT if available.
3422 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3423 on 32-bit hosts that have 64-bit int, so that they can access
3425 However, temporarily disable this change unless the temporary
3426 symbol WIDE_EMACS_INT is defined.
3428 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3430 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3431 This removes an assumption that EMACS_INT and long are the same
3432 width as pointers. The assumption is true for Emacs porting targets
3433 now, but we want to make other targets possible.
3434 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3435 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3436 In the rest of the code, change types of integers that hold casted
3437 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3438 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3439 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3440 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3441 No need to cast type when ORing.
3442 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3443 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3444 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3445 assume EMACS_INT is the same width as char *.
3446 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3447 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3448 Remove no-longer-needed casts.
3449 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3450 (xg_tool_bar_help_callback, xg_make_tool_item):
3451 Use EMACS_INTPTR to hold an integer
3452 that will be cast to void *; this can avoid a GCC warning
3453 if EMACS_INT is not the same width as void *.
3454 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3455 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3456 (current_message_1, set_message_1):
3457 Use a local to convert to proper width without a cast.
3458 * xmenu.c (dialog_selection_callback): Likewise.
3460 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3461 Also, don't assume VALBITS / RAND_BITS is less than 5,
3462 and don't rely on undefined behavior when shifting a 1 left into
3464 * lisp.h (get_random): Change signature to match.
3466 * lread.c (hash_string): Use size_t, not int, for hash computation.
3467 Normally we prefer signed values; but hashing is special, because
3468 it's better to use unsigned division on hash table sizes so that
3469 the remainder is nonnegative. Also, size_t is the natural width
3470 for hashing into memory. The previous code used 'int', which doesn't
3471 retain enough info to hash well into very large tables.
3472 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3474 * dbusbind.c: Don't possibly lose pointer info when converting.
3475 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3476 Use XPNTR rather than XHASH, so that the high-order bits of
3477 the pointer aren't lost when converting through void *.
3479 * eval.c (Fautoload): Don't double-shift a pointer.
3481 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3483 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3485 * gnutls.c (DEF_GNUTLS_FN):
3486 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3488 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3490 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3493 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3495 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3496 New version that can reserve upto 2GB of heap space.
3498 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3500 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3502 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3504 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3505 `gnutls_certificate_set_x509_key_file'.
3507 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3509 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3510 Update dependencies.
3512 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3514 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3515 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3516 Remove unused parameter `fildes'.
3517 * process.c (read_process_output, send_process): Don't pass it.
3519 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3521 Fix previous change: the library cache is defined in w32.c.
3522 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3523 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3525 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3527 Implement dynamic loading of GnuTLS on Windows.
3529 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3530 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3531 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3534 * gnutls.c (Qgnutls_dll): Define.
3535 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3536 (gnutls_*): Declare function pointers.
3537 (init_gnutls_functions): New function to initialize function pointers.
3538 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3539 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3540 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3541 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3542 (emacs_gnutls_write, emacs_gnutls_read)
3543 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3544 (Fgnutls_available_p): New function.
3545 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3546 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3547 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3549 * image.c: Include w32.h.
3550 (Vimage_type_cache): Delete.
3551 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3552 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3553 (w32_delayed_load): Move to w32.c.
3555 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3557 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3558 (w32_delayed_load): Move from image.c. When loading a library, record
3559 its filename in the :loaded-from property of the library id.
3560 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3561 Initialize and staticpro them.
3562 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3564 * process.c: Include lisp.h before w32.h, not after.
3565 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3566 instead of gnutls_record_check_pending.
3568 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3570 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3572 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3573 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3576 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3578 * xterm.c (x_set_frame_alpha): Do not set property on anything
3579 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3581 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3583 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3585 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3587 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3588 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3589 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3590 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3591 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3592 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3593 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3594 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3595 (Qgnutls_bootprop_callbacks_verify): Make static.
3597 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3599 * callproc.c: Indentation fixup.
3601 * sysdep.c (wait_for_termination_1): Make static.
3602 (wait_for_termination, interruptible_wait_for_termination):
3603 Move after wait_for_termination_1.
3605 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3607 * sysdep.c (interruptible_wait_for_termination): New function
3608 which is like wait_for_termination, but allows keyboard
3611 * callproc.c (Fcall_process): Add (:file "file") as an option for
3613 (Fcall_process_region): Ditto.
3615 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3617 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3618 rather than `XVECTOR (FOO)->size'.
3620 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3621 inttypes.h, as a gnulib replacement is used if it not available in
3624 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3626 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3627 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3628 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3630 * coding.c (coding_alloc_by_realloc): Error out if destination
3631 will grow beyond MOST_POSITIVE_FIXNUM.
3632 (decode_coding_emacs_mule): Abort if there isn't enough place in
3633 charbuf for the composition carryover bytes. Reserve an extra
3634 space for up to 2 characters produced in a loop.
3635 (decode_coding_iso_2022): Abort if there isn't enough place in
3636 charbuf for the composition carryover bytes.
3638 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3640 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3641 aborting when %lld or %lll format is passed.
3642 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3643 %llo or %llx format is passed. (Bug#8545)
3645 * window.c (window_scroll_line_based): Use a marker instead of
3646 simple variables to record original value of point. (Bug#7952)
3648 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3649 produced by %s or %c overflows available buffer space. (Bug#8545)
3651 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3653 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3654 (SIZE_MAX): Move defn after all includes, as they might #define it.
3656 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3658 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3660 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3662 * keyboard.c (Qdelayed_warnings_hook): Define.
3663 (command_loop_1): Run `delayed-warnings-hook'
3664 if Vdelayed_warnings_list is non-nil.
3665 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3666 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3668 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3670 * doprnt.c (doprnt): Don't return value smaller than the buffer
3671 size if the message was truncated. (Bug#8545).
3673 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3675 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3676 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3678 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3680 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3682 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3684 * makefile.w32-in: Update dependencies.
3686 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3688 Improve `doprnt' and its usage. (Bug#8545)
3689 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3690 `format_end'. Remove support for %l as a conversion specifier.
3691 Don't use xrealloc. Improve diagnostics when the %l size modifier
3692 is used. Update the commentary.
3694 * eval.c (verror): Simplify calculation of size_t.
3696 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3699 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3701 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3704 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3706 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3707 This makes this file independent of the recent pseudovector change.
3709 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3711 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3713 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3714 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3715 Remove unused local.
3716 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3718 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3719 GCC 4.6.0 optimizes based on type-based alias analysis.
3720 For example, if b is of type struct buffer * and v of type struct
3721 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3722 != &v->size, and therefore "v->size = 1; b->size = 2; return
3723 v->size;" must therefore return 1. This assumption is incorrect
3724 for Emacs, since it type-puns struct Lisp_Vector * with many other
3725 types. To fix this problem, this patch adds a new type struct
3726 vectorlike_header that documents the constraints on layout of vectors
3727 and pseudovectors, and helps optimizing compilers not get fooled
3728 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3729 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3730 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3732 (XSETPVECTYPE): Rewrite in terms of new macro.
3733 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3734 This is a bit clearer, and further avoids the possibility of
3735 undesirable aliasing.
3736 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3737 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3738 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3739 since Lisp_Subr is a special case (no "next" field).
3740 (ASIZE): Now uses header.size rather than size.
3741 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3742 to avoid the hassle of writing XVECTOR (foo)->header.size.
3743 (struct vectorlike_header): New type.
3744 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3745 object, to help avoid aliasing.
3746 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3747 (SUBRP): Likewise, since Lisp_Subr is a special case.
3748 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3749 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3750 (struct Lisp_Hash_Table): Combine first two members into a single
3751 struct vectorlike_header member. All uses of "size" and "next" members
3752 changed to be "header.size" and "header.next".
3753 * buffer.h (struct buffer): Likewise.
3754 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3755 * frame.h (struct frame): Likewise.
3756 * process.h (struct Lisp_Process): Likewise.
3757 * termhooks.h (struct terminal): Likewise.
3758 * window.c (struct save_window_data, struct saved_window): Likewise.
3759 * window.h (struct window): Likewise.
3760 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3761 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3762 * buffer.c (init_buffer_once): Likewise.
3763 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3765 * process.c (Fformat_network_address): Use local var for size,
3768 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3770 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3771 * data.c (atof): Remove decl; no longer used or needed.
3772 (digit_to_number): Move to lread.c.
3773 (Fstring_to_number): Use new string_to_number function, to be
3774 consistent with how the Lisp reader treats infinities and NaNs.
3775 Do not assume that floating-point numbers represent EMACS_INT
3776 without losing information; this is not true on most 64-bit hosts.
3777 Avoid double-rounding errors, by insisting on integers when
3778 parsing non-base-10 numbers, as the documentation specifies.
3779 * lisp.h (string_to_number): New decl, replacing ...
3780 (isfloat_string): Remove.
3781 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3782 (read1): Do not accept +. and -. as integers; this
3783 appears to have been a coding error. Similarly, do not accept
3784 strings like +-1e0 as floating point numbers. Do not report
3785 overflow for integer overflows unless the base is not 10 which
3786 means we have no simple and reliable way to continue.
3787 Break out the floating-point parsing into a new
3788 function string_to_number, so that Fstring_to_number parses
3789 floating point numbers consistently with the Lisp reader.
3790 (digit_to_number): Move here from data.c. Make it static inline.
3791 (E_CHAR, EXP_INT): Remove, replacing with ...
3792 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3793 (string_to_number): New function, replacing isfloat_string.
3794 This function checks for valid syntax and produces the resulting
3795 Lisp float number too. Rework it so that string-to-number
3796 no longer mishandles examples like "1.0e+". Use strtoumax,
3797 so that overflow for non-base-10 numbers is reported only when
3798 there's no portable and simple way to convert to floating point.
3800 * textprop.c (set_text_properties_1): Rewrite for clarity,
3801 and to avoid GCC warning about integer overflow.
3803 * intervals.h (struct interval): Use EMACS_INT for members
3804 where EMACS_UINT might cause problems. See
3805 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3806 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3807 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3809 (offset_intervals): Tell GCC not to worry about length overflow
3810 when negating a negative length.
3812 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3813 (overrun_check_free): Likewise.
3815 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3816 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3819 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3820 (gnutls_make_error): Rename local to avoid shadowing.
3821 (gnutls_emacs_global_deinit): ifdef out; not used.
3822 (Fgnutls_boot): Use const for pointer to readonly storage.
3823 Comment out unused local. Fix pointer signedness problems.
3825 * lread.c (openp): Don't stuff size_t into an 'int'.
3826 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3827 about possible signed overflow.
3829 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3830 (GDK_KEY_g): Don't define if already defined.
3831 (xg_prepare_tooltip): Avoid pointer signedness problem.
3832 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3834 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3835 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3837 * xfns.c (Fx_window_property): Simplify a bit,
3838 to make a bit faster and to avoid GCC 4.6.0 warning.
3839 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3841 * fns.c (internal_equal): Don't assume size_t fits in int.
3843 * alloc.c (compact_small_strings): Tighten assertion a little.
3845 Replace pEd with more-general pI, and fix some printf arg casts.
3846 * lisp.h (pI): New macro, generalizing old pEd macro to other
3847 conversion specifiers. For example, use "...%"pI"d..." rather
3848 than "...%"pEd"...".
3849 (pEd): Remove. All uses replaced with similar uses of pI.
3850 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3851 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3852 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3853 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3854 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3855 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3856 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3858 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3859 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3860 * print.c (safe_debug_print, print_object): Likewise.
3861 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3863 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3864 avoiding the 0 flag, which is not portable.
3865 * process.c (Fmake_network_process): Use pI to avoid cast.
3866 * region-cache.c (pp_cache): Likewise.
3867 * xdisp.c (decode_mode_spec): Likewise.
3868 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3869 behavior on 64-bit hosts with printf arg.
3870 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3871 (x_stop_queuing_selection_requests): Likewise.
3872 (x_get_window_property): Don't truncate byte count to an 'int'
3875 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3876 here, since it parses constructs like leading '-' and spaces,
3877 which are not wanted; and it overflows with large numbers.
3878 Instead, simply match F[0-9]+, which is what is wanted anyway.
3880 * alloc.c: Remove unportable assumptions about struct layout.
3881 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3882 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3883 (allocate_vectorlike, make_pure_vector): Use the new macros,
3884 plus offsetof, to remove unportable assumptions about struct layout.
3885 These assumptions hold on all porting targets that I know of, but
3886 they are not guaranteed, they're easy to remove, and removing them
3887 makes further changes easier.
3889 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3890 This doesn't fix a bug but makes the code clearer.
3891 (string_overrun_cookie): Now const. Use initializers that
3892 don't formally overflow signed char, to avoid warnings.
3893 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3894 can cause Emacs to crash when string overrun checking is enabled.
3895 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3896 multiple of sizeof (EMACS_INT); it need not be, if
3897 alignof(EMACS_INT) < sizeof (EMACS_INT).
3898 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3900 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3902 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3904 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3906 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3907 supposed to be handshaking. (Bug#8556)
3908 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3910 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3912 * lisp.h (Qdebug): List symbol.
3913 * eval.c (Qdebug): Restore global linkage.
3914 * keyboard.c (debug-on-event): New variable.
3915 (handle_user_signal): Break into debugger when debug-on-event
3916 matches the current signal symbol.
3918 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3920 * alloc.c (check_sblock, check_string_bytes)
3921 (check_string_free_list): Convert to standard C.
3923 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3925 * w32.c (emacs_gnutls_push): Fix typo.
3927 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3929 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3930 "cast to pointer from integer of different size".
3932 Improve doprnt and its use in verror. (Bug#8545)
3933 * doprnt.c (doprnt): Document the set of format control sequences
3934 supported by the function. Use SAFE_ALLOCA instead of always
3937 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3938 is one byte too soon. Don't use xrealloc; instead xfree and
3941 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3943 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3946 * gnutls.c: Renamed global_initialized to
3947 gnutls_global_initialized. Added internals for the
3948 :verify-hostname-error, :verify-error, and :verify-flags
3949 parameters of `gnutls-boot' and documented those parameters in the
3950 docstring. Start callback support.
3951 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3952 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3953 on error. Return error code.
3954 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3955 (emacs_gnutls_read): Likewise.
3956 (Fgnutls_boot): Return handshake error code.
3957 (emacs_gnutls_handle_error): New function.
3958 (wsaerror_to_errno): Likewise.
3960 * w32.h (emacs_gnutls_pull): Add prototype.
3961 (emacs_gnutls_push): Likewise.
3963 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3964 (emacs_gnutls_push): Likewise.
3966 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3968 * process.c (wait_reading_process_output): Check if GnuTLS
3969 buffered some data internally if no FDs are set for TLS
3972 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3973 (LIBS): Link to USER_LIBS.
3974 ($(BLD)/gnutls.$(0)): New target.
3976 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3978 * xdisp.c (handle_single_display_spec): Rename the
3979 display_replaced_before_p argument into display_replaced_p, to
3980 make it consistent with the commentary. Fix typos in the
3983 * textprop.c (syms_of_textprop): Remove dead code.
3984 (copy_text_properties): Delete obsolete commentary about an
3985 interface that was deleted long ago. Fix typos in the description
3988 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3989 to changes in oldXMenu/XMenu.h from 2011-04-16.
3990 <menu_help_message, prev_menu_help_message>: Constify.
3991 (IT_menu_make_room): menu->help_text is now `const char **';
3994 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3995 to changes in oldXMenu/XMenu.h from 2011-04-16.
3996 (struct XMenu): Declare `help_text' `const char **'.
3998 * xfaces.c <Qunspecified>: Make extern again.
4000 * syntax.c: Include sys/types.h before including regex.h, as
4003 * doc.c (get_doc_string): Improve the format passed to `error'.
4005 * doprnt.c (doprnt): Improve commentary.
4007 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4009 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4012 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4013 changes in globals.h immediately force recompilation.
4014 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4015 $(CURDIR)/s/ms-w32.h.
4016 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4018 * character.c (Fchar_direction): Function deleted.
4019 (syms_of_character): Don't defsubr it.
4020 <char-direction-table>: Deleted.
4022 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4024 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4025 * doprnt.c: Include limits.h.
4026 (SIZE_MAX): New macro.
4027 (doprnt): Return a size_t value. 2nd arg is now size_t.
4028 Many local variables are now size_t instead of int or unsigned.
4029 Improve overflow protection. Support `l' modifier for integer
4030 conversions. Support %l conversion. Don't assume an EMACS_INT
4031 argument for integer conversions and for %c.
4033 * lisp.h (doprnt): Restore prototype.
4035 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4038 * Makefile.in (base_obj): Add back doprnt.o.
4040 * deps.mk (doprnt.o): Add back prerequisites.
4041 (callint.o): Depend on character.h.
4043 * eval.c (internal_lisp_condition_case): Include the handler
4044 representation in the error message.
4045 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4046 when breaking from the loop.
4048 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4050 * callint.c (Fcall_interactively): When displaying error message
4051 about invalid control letter, pass the character's codepoint, not
4052 a pointer to its multibyte form. Improve display of the character
4053 in octal and display also its hex code.
4055 * character.c (char_string): Use %x to display the (unsigned)
4056 codepoint of an invalid character, to avoid displaying a bogus
4059 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4060 `error', not SYMBOL_NAME itself.
4062 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4063 character arguments to `error'.
4065 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4066 to `error' in error message about FINAL_CHAR argument. Make sure
4067 FINAL_CHAR is a character, and use %c when it is passed as
4068 argument to `error'.
4070 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4072 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4074 * w32.c: Include <time.h>.
4075 (sys_localtime): New function.
4077 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4079 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4081 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4083 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4085 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4088 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4090 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4091 gl_state.e_property when gl_state.object is Qt.
4093 * insdel.c (make_gap_larger): Remove limitation of buffer size
4096 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4098 * xdisp.c (lookup_glyphless_char_display)
4099 (produce_glyphless_glyph): Handle cons cell entry in
4100 glyphless-char-display.
4101 (Vglyphless_char_display): Document it.
4103 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4104 glyphless-char-display.
4106 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4108 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4110 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4112 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4113 definition for no-X builds.
4115 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4117 Static checks with GCC 4.6.0 and non-default toolkits.
4119 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4121 * process.c (keyboard_bit_set): Define only if SIGIO.
4122 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4123 (send_process): Repair possible setjmp clobbering.
4125 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4127 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4129 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4131 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4132 Define only if needed.
4134 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4135 by pacifying GCC about it. Maybe it's time to retire it?
4136 * xfaces.c (USG, __TIMEVAL__): Likewise.
4138 * dispextern.h (struct redisplay_interface): Rename param
4140 * termhooks.h (struct terminal): Likewise.
4141 * xterm.c (xembed_send_message): Likewise.
4143 * insdel.c (make_gap_smaller): Define only if
4144 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4146 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4149 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4150 so that we aren't warned about unused symbols.
4152 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4154 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4156 * xfns.c (x_real_positions): Mark locals as initialized.
4158 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4160 * xterm.c: Fix problems found by static analysis with other toolkits.
4161 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4162 (x_dispatch_event): Declare static if USE_GTK, and
4163 define if USE_GTK || USE_X_TOOLKIT.
4164 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4165 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4166 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4167 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4169 * xmenu.c (menu_help_callback): Pointer type fixes.
4170 Use const pointers when pointing at readonly data. Avoid pointer
4172 (FALSE): Remove unused macro.
4173 (update_frame_menubar): Remove unused decl.
4175 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4177 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4178 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4179 (single_menu_item): Rename local to avoid shadowing.
4181 * keyboard.c (make_lispy_event): Remove unused local var.
4183 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4184 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4186 * bitmaps: Change bitmaps from unsigned char back to the X11
4187 compatible char. Avoid the old compiler warnings about
4188 out-of-range initializers by using, for example, '\xab' rather
4191 * xgselect.c (xgselect_initialize): Check vs interface
4192 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4194 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4196 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4197 to read-only memory.
4199 * fns.c (vector): Remove; this old hack is no longer needed.
4201 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4203 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4205 * xrdb.c (x_load_resources): Omit unused local.
4207 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4208 (x_window): Rename locals to avoid shadowing.
4209 (USG): Use the kludged USG macro, to pacify gcc.
4211 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4212 (x_term_init): Remove local to avoid shadowing.
4214 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4216 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4217 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4219 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4221 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4223 Fix regex.c, syntax.c and friends for buffers > 2GB.
4224 * syntax.h (struct gl_state_s): Declare character position members
4227 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4229 * textprop.c (verify_interval_modification, interval_of):
4230 Declare arguments EMACS_INT.
4232 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4235 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4237 * indent.c (Fvertical_motion): Local variable it_start is now
4240 * regex.c (re_match, re_match_2, re_match_2_internal)
4241 (bcmp_translate, regcomp, regexec, print_double_string)
4242 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4243 (re_compile_pattern, re_exec): Declare arguments and local
4244 variables `size_t' and `ssize_t' and return values `regoff_t', as
4246 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4247 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4248 <compile_stack_type>: `size' and `avail' are now `size_t'.
4250 * regex.h <regoff_t>: Use ssize_t, not int.
4251 (re_search, re_search_2, re_match, re_match_2): Arguments that
4252 specify buffer/string position and length are now ssize_t and
4253 size_t. Return type is regoff_t.
4255 2011-04-16 Ben Key <bkey76@gmail.com>
4257 * nsfont.m: Fixed bugs in ns_get_family and
4258 ns_descriptor_to_entity that were caused by using free to
4259 deallocate memory blocks that were allocated by xmalloc (via
4260 xstrdup). This caused Emacs to crash when compiled with
4261 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4262 --enable-checking=xmallocoverrun). xfree is now used to
4263 deallocate these memory blocks.
4265 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4267 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4269 emacs_write: Accept and return EMACS_INT for sizes.
4270 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4272 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4273 Accept and return EMACS_INT.
4274 (emacs_gnutls_write): Return the number of bytes written on
4276 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4277 (emacs_read, emacs_write): Remove check for negative size, as the
4278 Emacs source code has been audited now.
4279 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4280 (emacs_read, emacs_write): Use it.
4281 * process.c (send_process): Adjust to the new signatures of
4282 emacs_write and emacs_gnutls_write. Do not attempt to store
4283 a byte offset into an 'int'; it might overflow.
4284 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4286 * sound.c: Don't assume sizes fit in 'int'.
4287 (struct sound_device.period_size, alsa_period_size):
4288 Return EMACS_INT, not int.
4289 (struct sound_device.write, vox_write, alsa_write):
4290 Accept EMACS_INT, not int.
4291 (wav_play, au_play): Use EMACS_INT to store sizes and to
4292 record read return values.
4294 2011-04-15 Ben Key <bkey76@gmail.com>
4296 * keyboard.c (Qundefined): Don't declare static since it is used
4298 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4299 static since they are used in nsfont.m.
4301 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4303 * process.c (Qprocessp): Don't declare static.
4304 * lisp.h (Qprocessp): Declare again.
4306 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4308 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4310 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4312 Improve C-level modularity by making more things 'static'.
4314 Don't publish debugger-only interfaces to other modules.
4315 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4316 (verify_bytepos, count_markers): Move decls to the only modules
4318 * region-cache.h (pp_cache): Likewise.
4319 * window.h (check_all_windows): Likewise.
4320 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4322 * sysdep.c (croak): Now static, if
4323 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4324 * syssignal.h (croak): Declare only if not static.
4326 * alloc.c (refill_memory_reserve): Now static if
4327 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4328 * lisp.h (refill_memory_reserve): Declare only if not static.
4330 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4331 Define only if USE_LUCID.
4333 * xrdb.c (x_customization_string, x_rm_string): Now static.
4335 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4336 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4338 * xdisp.c (draw_row_with_mouse_face): Now static.
4339 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4341 * window.h (check_all_windows): Mark externally visible.
4343 * window.c (window_deletion_count): Now static.
4345 * undo.c: Make symbols static if they're not exported.
4346 (last_undo_buffer, last_boundary_position, pending_boundary):
4349 * textprop.c (interval_insert_behind_hooks): Now static.
4350 (interval_insert_in_front_hooks): Likewise.
4352 * term.c: Make symbols static if they're not exported.
4353 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4354 (max_frame_lines, tty_set_terminal_modes):
4355 (tty_reset_terminal_modes, tty_turn_off_highlight):
4356 (get_tty_terminal): Now static.
4357 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4358 * termhooks.h (term_mouse_moveto): Do not declare if
4360 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4361 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4363 * sysdep.c: Make symbols static if they're not exported.
4364 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4366 (sigprocmask_set, full_mask): Remove; unused.
4367 (wait_debugging): Mark as visible.
4368 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4369 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4371 * syntax.c (syntax_temp): Define only if !__GNUC__.
4373 * sound.c (current_sound_device, current_sound): Now static.
4375 * search.c (searchbufs, searchbuf_head): Now static.
4377 * scroll.c (scroll_cost): Remove; unused.
4378 * dispextern.h (scroll_cost): Remove decl.
4380 * region-cache.h (pp_cache): Mark as externally visible.
4382 * process.c: Make symbols static if they're not exported.
4383 (process_tick, update_tick, create_process, chan_process):
4384 (Vprocess_alist, proc_buffered_char, datagram_access):
4385 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4386 (deactivate_process): Mark defn as static, as well as decl.
4387 * lisp.h (create_process): Remove decl.
4388 * process.h (chan_process, Vprocess_alist): Remove decls.
4390 * print.c: Make symbols static if they're not exported.
4391 (print_depth, new_backquote_output, being_printed, print_buffer):
4392 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4393 (print_interval, print_number_index, initial_stderr_stream):
4395 * lisp.h (Fprinc): Remove decl.
4396 (debug_output_compilation_hack): Mark as externally visible.
4398 * sysdep.c (croak): Move decl from here to syssignal.h.
4399 * syssignal.h (croak): Put it here, so the API can be checked when
4400 'croak' is called from dissociate_if_controlling_tty.
4402 * minibuf.c: Make symbols static if they're not exported.
4403 (minibuf_save_list, choose_minibuf_frame): Now static.
4404 * lisp.h (choose_minibuf_frame): Remove decl.
4406 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4408 * lread.c: Make symbols static if they're not exported.
4409 (read_objects, initial_obarray, oblookup_last_bucket_number):
4411 (make_symbol): Remove; unused.
4412 * lisp.h (initial_obarray, make_symbol): Remove decls.
4414 * keyboard.c: Make symbols static if they're not exported.
4415 (single_kboard, recent_keys_index, total_keys, recent_keys):
4416 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4417 (this_single_command_key_start, echoing, last_auto_save):
4418 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4419 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4420 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4421 (Vlispy_mouse_stem, double_click_count):
4423 (force_auto_save_soon): Define only if SIGDANGER.
4424 (ignore_mouse_drag_p): Now static if
4425 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4426 (print_help): Remove; unused.
4427 (stop_character, last_timer_event): Mark as externally visible.
4428 * keyboard.h (ignore_mouse_drag_p): Declare only if
4429 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4430 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4431 * lisp.h (echoing): Remove decl.
4432 (force_auto_save_soon): Declare only if SIGDANGER.
4433 * xdisp.c (redisplay_window): Simplify code, to make it more
4434 obvious that ignore_mouse_drag_p is not accessed if !defined
4435 USE_GTK && !defined HAVE_NS.
4437 * intervals.c: Make symbols static if they're not exported.
4438 (merge_properties_sticky, merge_interval_right, delete_interval):
4440 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4442 * insdel.c: Make symbols static if they're not exported.
4443 However, leave prepare_to_modify_buffer alone. It's never
4444 called from outside this function, but that appears to be a bug.
4445 (combine_after_change_list, combine_after_change_buffer):
4446 (adjust_after_replace, signal_before_change): Now static.
4447 (adjust_after_replace_noundo): Remove; unused.
4448 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4449 (signal_before_change): Remove decls.
4451 * indent.c (val_compute_motion, val_vmotion): Now static.
4453 * image.c: Make symbols static if they're not exported.
4454 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4456 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4457 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4459 * fringe.c (standard_bitmaps): Now static.
4460 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4462 * frame.c: Make symbols static if they're not exported.
4463 (x_report_frame_params, make_terminal_frame): Now static.
4464 (get_frame_param): Now static, unless HAVE_NS.
4465 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4466 (x_get_resource_string): Remove; not used.
4467 * frame.h (make_terminal_frame, x_report_frame_params):
4468 (x_get_resource_string); Remove decls.
4469 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4470 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4472 * font.c, fontset.c: Make symbols static if they're not exported.
4473 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4474 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4475 * font.c (font_close_object): Now static.
4476 * font.h (font_close_object): Remove.
4477 * fontset.c (FONTSET_OBJLIST): Remove.
4478 (free_realized_fontset) #if-0 the body, which does nothing.
4479 (face_suitable_for_char_p): #if-0, as it's never called.
4480 * fontset.h (face_suitable_for_char_p): Remove decl.
4481 * xfaces.c (face_at_string_position):
4482 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4483 since 0 is always ASCII.
4485 * fns.c (weak_hash_tables): Now static.
4487 * fileio.c: Make symbols static if they're not exported.
4488 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4489 (Vwrite_region_annotation_buffers): Now static.
4491 * eval.c: Make symbols static if they're not exported.
4492 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4493 * lisp.h (backtrace_list): Remove decl.
4495 * emacs.c: Make symbols static if they're not exported.
4496 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4497 (fatal_error_code, fatal_error_signal_hook, standard_args):
4499 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4500 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4501 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4502 * lisp.h (fatal_error_signal_hook): Remove decl.
4503 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4505 * editfns.c: Move a (normally-unused) function to its only use.
4506 * editfns.c, lisp.h (get_operating_system_release): Remove.
4507 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4508 worth the hassle of breaking this out.
4510 * xterm.c: Make symbols static if they're not exported.
4511 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4512 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4513 (x_destroy_window, x_delete_display):
4515 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4516 (x_mouse_leave): Remove; unused.
4517 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4518 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4519 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4521 (x_mouse_leave): Declare only if WINDOWSNT.
4522 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4523 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4526 * ftxfont.c: Make symbols static if they're not exported.
4527 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4529 * font.h (ftxfont_driver): Likewise.
4531 * xfns.c: Make symbols static if they're not exported.
4532 (x_last_font_name, x_display_info_for_name):
4533 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4534 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4535 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4536 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4537 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4538 (last_show_tip_args): Now static.
4539 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4540 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4541 (x_screen_planes): Remove; unused.
4542 * dispextern.h (x_screen_planes): Remove decl.
4544 * dispnew.c: Make symbols static if they're not exported.
4545 * dispextern.h (redraw_garbaged_frames, scrolling):
4546 (increment_row_positions): Remove.
4547 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4548 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4550 (redraw_garbaged_frames): Remove; unused.
4552 * xfaces.c: Make symbols static if they're not exported.
4553 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4555 * xterm.h (defined_color): Remove decls.
4556 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4557 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4558 (menu_face_changed_default, defined_color, free_realized_face):
4559 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4560 (ascii_face_of_lisp_face): Remove; unused.
4562 * xdisp.c: Make symbols static if they're not exported.
4563 * dispextern.h (scratch_glyph_row, window_box_edges):
4564 (glyph_to_pixel_coords, set_cursor_from_row):
4565 (get_next_display_element, set_iterator_to_next):
4566 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4567 (show_mouse_face): Remove decls
4568 * frame.h (message_buf_print): Likewise.
4569 * lisp.h (pop_message, set_message, check_point_in_composition):
4571 * xterm.h (set_vertical_scroll_bar): Likewise.
4572 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4573 (message_buf_print, scratch_glyph_row, displayed_buffer):
4574 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4575 (get_next_display_element, show_mouse_face, window_box_edges):
4576 (frame_to_window_pixel_xy, check_point_in_composition):
4577 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4578 (glyph_to_pixel_coords): Remove; unused.
4580 * dired.c (file_name_completion): Now static.
4582 * dbusbind.c (xd_in_read_queued_messages): Now static.
4584 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4585 * data.c (circular_list_error): Remove.
4587 * commands.h (last_point_position, last_point_position_buffer):
4588 (last_point_position_window): Remove decls.
4589 * keyboard.c: Make these variables static.
4591 * coding.h (coding, code_convert_region, encode_coding_gap):
4593 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4594 (iso_code_class, detect_coding, code_convert_region): Now static.
4595 (encode_coding_gap): Remove; unused.
4597 * chartab.c (chartab_chars, chartab_bits): Now static.
4599 * charset.h (charset_iso_8859_1): Remove decl.
4600 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4603 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4604 * ccl.c (Vccl_program_table): Now static.
4605 (check_ccl_update): Remove; unused.
4607 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4608 * category.h: ... from here.
4609 * category.c (check_category_table, set_category_set): Now static.
4611 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4612 * lisp.h: Remove these decls.
4614 * buffer.c (buffer_count): Remove unused var.
4616 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4617 so that it's not optimized away.
4618 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4619 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4620 exported only to the debugger.
4622 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4623 * atimer.h (run_all_atimers): Remove; not exported.
4625 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4626 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4627 was inaccessible from Lisp.
4628 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4629 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4631 alloc.c: Import and export fewer symbols, and remove unused items.
4632 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4634 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4635 it's not optimized away by whole-program optimization.
4636 (message_enable_multibyte, free_misc): Remove.
4637 (catchlist, handlerlist, mark_backtrace):
4638 Declare only if BYTE_MARK_STACK.
4639 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4640 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4641 (message_enable_multibyte): Remove decl.
4642 (free_misc, interval_free_list, float_block, float_block_index):
4643 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4644 (cons_free_list, last_marked_index):
4646 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4647 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4648 (mark_backtrace): Define only if BYTE_MARK_STACK.
4649 * xdisp.c (message_enable_multibyte): Now static.
4651 Declare Lisp_Object Q* variables to be 'static' if not exported.
4652 This makes it easier for human readers (and static analyzers)
4653 to see whether these variables are used from other modules.
4654 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4655 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4656 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4657 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4658 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4659 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4660 * xmenu.c, xselect.c:
4661 Declare Q* vars static if they are not used in other modules.
4662 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4663 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4664 Remove decls of unexported vars.
4665 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4667 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4669 Make Emacs functions such as Fatom 'static' by default.
4670 This makes it easier for human readers (and static analyzers)
4671 to see whether these functions can be called from other modules.
4672 DEFUN now defines a static function. To make the function external
4673 so that it can be used in other C modules, use the new macro DEFUE.
4674 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4675 (Finit_image_library):
4676 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4677 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4678 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4679 Remove decls, since these functions are now static.
4680 (Funintern, Fget_internal_run_time): New decls, since these functions
4681 were already external.
4683 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4684 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4685 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4686 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4687 * keyboard.c, keymap.c, lread.c:
4688 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4689 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4690 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4691 Mark functions with DEFUE instead of DEFUN,
4692 if they are used in other modules.
4693 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4694 decls for now-static functions.
4695 * buffer.h (Fdelete_overlay): Remove decl.
4696 * callproc.c (Fgetenv_internal): Mark as internal.
4697 * composite.c (Fremove_list_of_text_properties): Remove decl.
4698 (Fcomposition_get_gstring): New forward static decl.
4699 * composite.h (Fcomposite_get_gstring): Remove decl.
4700 * dired.c (Ffile_attributes): New forward static decl.
4701 * doc.c (Fdocumntation_property): New forward static decl.
4702 * eval.c (Ffetch_bytecode): New forward static decl.
4703 (Funintern): Remove extern decl; now in .h file where it belongs.
4704 * fileio.c (Fmake_symbolic_link): New forward static decl.
4705 * image.c (Finit_image_library): New forward static decl.
4706 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4707 * intervals.h (Fprevious_property_change):
4708 (Fremove_list_of_text_properties): Remove decls.
4709 * keyboard.c (Fthis_command_keys): Remove decl.
4710 (Fcommand_execute): New forward static decl.
4711 * keymap.c (Flookup_key): New forward static decl.
4712 (Fcopy_keymap): Now static.
4713 * keymap.h (Flookup_key): Remove decl.
4714 * process.c (Fget_process): New forward static decl.
4715 (Fprocess_datagram_address): Mark as internal.
4716 * syntax.c (Fsyntax_table_p): New forward static decl.
4717 (skip_chars): Remove duplicate decl.
4718 * textprop.c (Fprevious_property_change): New forward static decl.
4719 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4721 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4722 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4724 * editfns.c (Fformat): Remove unreachable code.
4726 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4728 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4731 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4733 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4734 when at ZV. (Bug#8487)
4736 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4738 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4740 * keyboard.c (parse_tool_bar_item): Likewise.
4741 * sound.c (sound_cleanup, alsa_close): Likewise.
4742 * termcap.c (tgetent): Likewise.
4743 * xfns.c (x_default_font_parameter): Likewise.
4744 * xsettings.c (read_and_apply_settings): Likewise.
4746 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4747 (overrun_check_free): Protoize.
4749 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4751 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4752 since callers should never pass a negative size.
4753 Change the signature to match that of plain 'read' and 'write'; see
4754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4755 * lisp.h: Update prototypes of emacs_write and emacs_read.
4757 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4759 * xdisp.c (redisplay_window): Don't try to determine the character
4760 position of the scroll margin if the window start point w->startp
4761 is outside the buffer's accessible region. (Bug#8468)
4763 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4765 Fix write-region and its subroutines for buffers > 2GB.
4766 * fileio.c (a_write, e_write): Modify declaration of arguments and
4767 local variables to support buffers larger than 2GB.
4768 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4770 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4771 argument, local variables, and return value.
4773 * lisp.h: Update prototypes of emacs_write and emacs_read.
4775 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4777 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4779 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4781 Fix more problems found by GCC 4.6.0's static checks.
4783 * xdisp.c (vmessage): Use a better test for character truncation.
4785 * charset.c (load_charset_map): <, not <=, for optimization,
4786 and to avoid potential problems with integer overflow.
4787 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4788 * casetab.c (set_identity, shuffle): Likewise.
4789 * editfns.c (Fformat): Likewise.
4790 * syntax.c (skip_chars): Likewise.
4792 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4793 This also lets GCC 4.6.0 generate slightly better loop code.
4795 * callint.c (Fcall_interactively): <, not <=, for optimization.
4796 (Fcall_interactively): Count the number of arguments produced,
4797 not the number of arguments given. This is simpler and lets GCC
4798 4.6.0 generate slightly better code.
4800 * ftfont.c: Distingish more carefully between FcChar8 and char.
4801 The previous code passed unsigned char * to a functions like
4802 strlen and xstrcasecmp that expect char *, which does not
4803 conform to the C standard.
4804 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4805 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4806 char * when the C standard requires it.
4808 * keyboard.c (read_char): Remove unused var.
4810 * eval.c: Port to Windows vsnprintf (Bug#8435).
4812 (SIZE_MAX): Define if the headers do not.
4813 (verror): Do not give up if vsnprintf returns a negative count.
4814 Instead, grow the buffer. This ports to Windows vsnprintf, which
4815 does not conform to C99. Problem reported by Eli Zaretskii.
4816 Also, simplify the allocation scheme, by avoiding the need for
4817 calling realloc, and removing the ALLOCATED variable.
4819 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4821 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4822 But keep the doprint source code for now, as we might revamp it
4823 and use it again (Bug#8435).
4824 * lisp.h (doprnt): Remove.
4825 * Makefile.in (base_obj): Remove doprnt.o.
4826 * deps.mk (doprnt.o): Remove.
4828 error: Print 32- and 64-bit integers portably (Bug#8435).
4829 Without this change, on typical 64-bit hosts error ("...%d...", N)
4830 was used to print both 32- and 64-bit integers N, which relied on
4832 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4834 * lisp.h (error, verror): Mark as printf-like functions.
4835 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4836 Report overflow in size calculations when allocating printf buffer.
4837 Do not truncate output string at its first null byte.
4838 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4839 Truncate the output at a character boundary, since vsnprintf does not
4841 * charset.c (check_iso_charset_parameter): Convert internal
4842 character to string before calling 'error', since %c now has the
4844 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4845 overflow when computing char to be passed to 'error'. Do not
4846 pass Lisp_Object to 'error'; pass the integer instead.
4847 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4848 formatted with plain %d.
4850 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4852 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4854 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4856 * xterm.c (x_catch_errors): Remove duplicate declaration.
4858 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4860 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4862 2011-04-10 Jim Meyering <meyering@redhat.com>
4864 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4865 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4866 return ssize_t not "int", and use size_t as the buffer length.
4867 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4868 * gnutls.h: Update declarations.
4869 * process.c (read_process_output): Use ssize_t, to match.
4870 (send_process): Likewise.
4872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4874 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4876 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4878 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4879 Use unsigned char, to match FcChar8 type definition.
4881 * xterm.c (handle_one_xevent):
4882 * xmenu.c (create_and_show_popup_menu):
4883 * xselect.c (x_decline_selection_request)
4884 (x_reply_selection_request): Avoid type-punned deref of X events.
4886 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4888 Fix some uses of `int' instead of EMACS_INT.
4889 * search.c (string_match_1, fast_string_match)
4890 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4891 (scan_buffer, find_next_newline_no_quit)
4892 (find_before_next_newline, search_command, Freplace_match)
4893 (Fmatch_data): Make some `int' variables be EMACS_INT.
4895 * xdisp.c (display_count_lines): 3rd argument and return value now
4896 EMACS_INT. All callers changed.
4897 (pint2hrstr): Last argument is now EMACS_INT.
4899 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4900 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4901 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4902 (decode_coding_utf_16, decode_coding_emacs_mule)
4903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4904 (decode_coding_ccl, decode_coding_charset)
4905 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4906 (decode_coding_iso_2022, decode_coding_emacs_mule)
4907 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4908 <char_offset, last_offset>: Declare EMACS_INT.
4909 (encode_coding_utf_8, encode_coding_utf_16)
4910 (encode_coding_emacs_mule, encode_invocation_designation)
4911 (encode_designation_at_bol, encode_coding_iso_2022)
4912 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4913 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4915 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4916 (encode_invocation_designation): Last argument P_NCHARS is now
4918 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4919 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4921 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4924 * ccl.c (Fccl_execute_on_string): Declare some variables
4927 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4929 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4931 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4933 * process.c (Fformat_network_address): Doc fix.
4935 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4937 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4939 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4941 * keyboard.c (read_char): Call Lisp function help-form-show,
4942 instead of using internal_with_output_to_temp_buffer.
4943 (Qhelp_form_show): New var.
4944 (syms_of_keyboard): Use DEFSYM macro.
4946 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4948 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4950 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4952 * process.c (Flist_processes): Remove to Lisp.
4953 (list_processes_1): Delete.
4955 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4957 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4959 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4961 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4963 Fix more problems found by GCC 4.6.0's static checks.
4965 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4967 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4969 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4971 * xdisp.c (vmessage): Mark as a printf-like function.
4973 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4975 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4977 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4978 printf-like functions.
4979 (tiff_load): Add casts to remove these marks before passing them
4980 to system-supplied API.
4982 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4984 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4985 This avoids several warnings with gcc -Wstrict-overflow.
4986 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4987 directly, rather than having caller test rule sign. This avoids
4988 some unnecessary tests.
4989 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4990 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4991 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4993 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4994 (xfont_open): Avoid unnecessary tests.
4996 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4998 * composite.h, composite.c (composition_gstring_put_cache):
4999 Use EMACS_INT, not int, for length.
5001 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5002 breaking out part of COMPOSITION_DECODE_RULE.
5003 (COMPOSITION_DECODE_RULE): Use it.
5004 * composite.c (get_composition_id): Remove unused local vars,
5005 by using the new macro.
5007 * textprop.c (set_text_properties_1): Change while to do-while,
5008 since the condition is always true at first.
5010 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5011 (interval_deletion_adjustment): Return unsigned value.
5014 * process.c (list_processes_1, create_pty, read_process_output):
5015 (exec_sentinel): Remove vars that were set but not used.
5016 (create_pty): Remove unnecessary "volatile"s.
5017 (Fnetwork_interface_info): Avoid possibility of int overflow.
5018 (read_process_output): Do adaptive read buffering even if carryover.
5019 (read_process_output): Simplify nbytes computation if buffered.
5021 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5023 * syntax.c (scan_words): Remove var that was set but not used.
5024 (update_syntax_table): Use unsigned instead of int.
5026 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5027 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5028 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5030 * print.c (print_error_message): Avoid int overflow.
5032 * font.c (font_list_entities): Redo for clarity,
5033 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5035 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5036 (font_score): Avoid potential overflow in diff calculation.
5038 * fns.c (substring_both): Remove var that is set but not used.
5039 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5041 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5043 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5044 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5045 can always succeed if overflow has undefined behavior.
5047 * search.c (boyer_moore, wordify): Remove vars set but not used.
5048 (wordify): Omit three unnecessary tests.
5050 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5051 All callers changed. This avoids the need for an unused var.
5053 * casefiddle.c (casify_region): Remove var that is set but not used.
5055 * dired.c (file_name_completion): Remove var that is set but not used.
5057 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5059 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5060 (Finsert_file_contents): Remove unnecessary code checking fd.
5062 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5063 Check for integer overflow on size calculations.
5065 * buffer.c (Fprevious_overlay_change): Remove var that is set
5068 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5069 Remove vars that are set but not used.
5070 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5071 (timer_check_2): Mark vars as initialized.
5073 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5075 * image.c (lookup_image): Remove var that is set but not used.
5076 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5078 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5079 that are set but not used.
5081 * xfns.c (make_invisible_cursor): Don't return garbage
5082 if XCreateBitmapFromData fails (Bug#8410).
5084 * xselect.c (x_get_local_selection, x_handle_property_notify):
5085 Remove vars that are set but not used.
5087 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5088 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5090 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5091 Remove var that is set but not used.
5092 (scroll_bar_windows_size): Now size_t, not int.
5093 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5096 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5097 (map_tty_color) [!defined MSDOS]: Likewise.
5099 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5101 * coding.c: Remove vars that are set but not used.
5102 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5103 All callers changed.
5104 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5105 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5106 (decode_coding_charset): Remove vars that are set but not used.
5108 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5109 that is set but not used.
5111 * print.c (print_object): Remove var that is set but not used.
5113 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5114 The gnulib version avoids calling malloc in the usual case,
5115 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5116 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5117 * filelock.c (current_lock_owner): Likewise.
5118 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5119 * sysdep.c: Include allocator.h, careadlinkat.h.
5120 (emacs_no_realloc_allocator): New static constant.
5121 (emacs_readlink): New function.
5122 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5123 ../lib/careadlinkat.h.
5125 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5127 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5128 first non-nil return value).
5130 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5132 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5133 if not defined (Bug#8403).
5135 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5137 * xdisp.c (display_count_lines): Remove parameter `start',
5138 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5139 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5140 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5141 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5142 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5143 and thereabouts. All callers changed.
5144 (get_per_char_metric): Remove parameter `f', unused since
5145 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5147 2011-04-02 Jim Meyering <meyering@redhat.com>
5149 do not dereference NULL upon failed strdup
5150 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5151 (ns_get_family): Likewise.
5153 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5155 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5157 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5159 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5162 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5164 Add lexical binding.
5166 * window.c (Ftemp_output_buffer_show): New fun.
5167 (Fsave_window_excursion):
5168 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5170 * lread.c (lisp_file_lexically_bound_p): New function.
5171 (Fload): Bind Qlexical_binding.
5172 (readevalloop): Remove `evalfun' arg.
5173 Bind Qinternal_interpreter_environment.
5174 (Feval_buffer): Bind Qlexical_binding.
5175 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5177 (syms_of_lread): Declare `lexical-binding'.
5179 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5181 * keyboard.c (eval_dyn): New fun.
5182 (menu_item_eval_property): Use it.
5184 * image.c (parse_image_spec): Use Ffunctionp.
5186 * fns.c (concat, mapcar1): Accept byte-code-functions.
5188 * eval.c (Fsetq): Handle lexical vars.
5189 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5190 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5191 (FletX, Flet): Obey lexical binding.
5192 (Fcommandp): Handle closures.
5193 (Feval): New `lexical' arg.
5194 (eval_sub): New function extracted from Feval. Use it almost
5195 everywhere where Feval was used. Look up vars in lexical env.
5197 (Ffunctionp): Move from subr.el.
5198 (Ffuncall): Handle closures.
5199 (apply_lambda): Remove `eval_flags'.
5200 (funcall_lambda): Handle closures and new byte-code-functions.
5201 (Fspecial_variable_p): New function.
5202 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5203 but without exporting it to Lisp.
5205 * doc.c (Fdocumentation, store_function_docstring):
5206 * data.c (Finteractive_form): Handle closures.
5208 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5211 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5213 (exec_byte_code): New function extracted from Fbyte_code to handle new
5214 calling convention for byte-code-functions. Add new byte-codes.
5216 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5218 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5220 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5222 * xdisp.c (redisplay_internal): Fix prototype.
5224 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5226 * xdisp.c (SCROLL_LIMIT): New macro.
5227 (try_scrolling): Use it when setting scroll_limit.
5228 Limit scrolling to 100 screen lines.
5229 (redisplay_window): Even when falling back on "recentering",
5230 position point in the window according to scroll-conservatively,
5231 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5233 (try_scrolling): When point is above the window, allow searching
5234 as far as scroll_max, or one screenful, to compute vertical
5235 distance from PT to the scroll margin position. This prevents
5236 try_scrolling from unnecessarily failing when
5237 scroll-conservatively is set to a value slightly larger than the
5238 window height. Clean up the case of PT below the margin at bottom
5239 of window: scroll_max can no longer be INT_MAX. When aggressive
5240 scrolling is in use, don't let point enter the opposite scroll
5241 margin as result of the scroll.
5242 (syms_of_xdisp) <scroll-conservatively>: Document the
5243 threshold of 100 lines for never-recentering scrolling.
5245 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5247 * dispextern.h (move_it_by_lines):
5248 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5249 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5250 (message_log_check_duplicate): Remove parameters `prev_bol' and
5251 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5252 (redisplay_internal): Remove parameter `preserve_echo_area',
5253 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5255 * indent.c (Fvertical_motion):
5256 * window.c (window_scroll_pixel_based, Frecenter):
5257 Don't pass `need_y_p' to `move_it_by_lines'.
5259 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5261 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5262 steal a few bits to be more compact.
5263 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5264 Remove unneeded casts.
5266 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5268 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5270 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5271 binding" message (bug#7967).
5273 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5275 Fix more problems found by GCC 4.6.0's static checks.
5277 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5278 Remove unused local var.
5280 * editfns.c (Fmessage_box): Remove unused local var.
5282 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5283 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5284 Omit unused local vars.
5285 * window.c (shrink_windows): Omit unused local var.
5286 * menu.c (digest_single_submenu): Omit unused local var.
5287 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5288 Omit unused local var.
5290 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5291 Don't assume string length fits in int.
5292 (keyremap_step, read_key_sequence): Use size_t for sizes.
5293 (read_key_sequence): Don't check last_real_key_start redundantly.
5295 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5296 instead of alloca (Bug#8344).
5298 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5299 (Fbacktrace_frame): Don't assume nframes fits in int.
5301 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5303 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5306 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5308 * cm.c (calccost): Turn while-do into do-while, for clarity.
5310 * keyboard.c (syms_of_keyboard): Use the same style as later
5311 in this function when indexing through an array. This also
5312 works around GCC bug 48267.
5314 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5316 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5318 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5319 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5321 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5322 This avoids undefined behavior on integer overflow, and is a bit
5323 more convenient anyway since it is compared to a size_t variable.
5325 Variadic C functions now count arguments with size_t, not int.
5326 This avoids an unnecessary limitation on 64-bit machines, which
5327 caused (substring ...) to crash on large vectors (Bug#8344).
5328 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5329 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5330 All variadic functions and their callers changed accordingly.
5331 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5332 * data.c (arith_driver, float_arith_driver): Likewise.
5333 * editfns.c (general_insert_function): Likewise.
5334 * eval.c (struct backtrace.nargs, interactive_p)
5335 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5336 (funcall_lambda, mark_backtrace): Likewise.
5337 * fns.c (concat): Likewise.
5338 * frame.c (x_set_frame_parameters): Likewise.
5339 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5340 0 if not found, not -1. All callers changed.
5342 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5343 (stack_copy_size): Now size_t, not int.
5344 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5346 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5348 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5349 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5350 All callers changed.
5352 * lisp.h (multibyte_char_to_unibyte):
5353 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5354 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5355 * character.h (CHAR_TO_BYTE8):
5356 * cmds.c (internal_self_insert):
5357 * editfns.c (general_insert_function):
5358 * keymap.c (push_key_description):
5359 * search.c (Freplace_match):
5360 * xdisp.c (message_dolog, set_message_1): All callers changed.
5362 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5364 * keyboard.c (safe_run_hook_funcall): New function.
5365 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5366 don't set the hook to nil, but remove the offending function instead.
5367 (Qcommand_hook_internal): Remove, unused.
5368 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5369 Vcommand_hook_internal.
5371 * eval.c (enum run_hooks_condition): Remove.
5372 (funcall_nil, funcall_not): New functions.
5373 (run_hook_with_args): Call each function through a `funcall' argument.
5374 Remove `cond' argument, now redundant.
5375 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5376 (Frun_hook_with_args_until_failure): Adjust accordingly.
5377 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5379 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5381 * dispextern.h (string_buffer_position): Remove declaration.
5383 * print.c (strout): Remove parameter `multibyte', unused since
5384 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5386 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5387 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5388 All callers changed.
5390 * w32.c (_wsa_errlist): Use braces for struct initializers.
5392 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5393 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5394 All callers changed.
5395 (string_buffer_position): Likewise. Also, make static (it's never
5396 used outside xdisp.c).
5397 (cursor_row_p): Remove parameter `w', unused since
5398 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5399 (decode_mode_spec): Remove parameter `precision', introduced during
5400 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5401 All callers changed.
5403 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5405 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5407 2011-03-27 Anders Lindgren <andlind@gmail.com>
5409 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5410 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5411 (ns_update_auto_hide_menu_bar): New functions.
5412 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5413 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5414 ns_constrain_all_frames.
5415 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5416 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5418 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5420 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5422 2011-03-27 Glenn Morris <rgm@gnu.org>
5424 * syssignal.h: Replace RETSIGTYPE with void.
5425 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5426 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5427 Replace SIGTYPE with void everywhere.
5428 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5429 * s/template.h (SIGTYPE): Remove commented out definition.
5431 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5433 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5434 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5436 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5438 * w32.c (read_unc_volume): Use parameter `henum', instead of
5439 global variable `wget_enum_handle'.
5441 * keymap.c (describe_vector): Remove parameters `indices' and
5442 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5443 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5445 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5447 * keyboard.c (timer_check): Remove parameter `do_it_now',
5448 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5449 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5450 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5452 * keyboard.c (read_char):
5453 * w32menu.c (w32_menu_display_help):
5454 * xmenu.c (show_help_event, menu_help_callback):
5455 Adjust calls to `show_help_echo'.
5457 * gtkutil.c (xg_maybe_add_timer):
5458 * keyboard.c (readable_events):
5459 * process.c (wait_reading_process_output):
5460 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5462 * insdel.c (adjust_markers_gap_motion):
5463 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5464 (gap_left, gap_right): Don't call it.
5466 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5468 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5469 incurred during fontification.
5471 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5473 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5474 (DEFVAR_PER_BUFFER): Don't pass it.
5476 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5477 (scrolling_window): Don't pass it.
5479 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5481 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5483 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5485 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5486 of variables specific to SELinux and computation of `encoded_absname'.
5488 * image.c (XPutPixel): Remove unused variable `height'.
5490 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5492 * unexw32.c (get_section_info): Remove unused variable `section'.
5494 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5495 (system_process_attributes): Remove unused variable `sess'.
5496 (sys_read): Remove unused variable `err'.
5498 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5499 (w32_wnd_proc): Remove unused variable `isdead'.
5500 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5501 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5502 (x_create_tip_frame): Remove unused variable `tem'.
5504 * w32inevt.c (w32_console_read_socket):
5505 Remove unused variable `no_events'.
5507 * w32term.c (x_draw_composite_glyph_string_foreground):
5508 Remove unused variable `width'.
5510 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5512 * w32term.c (x_set_glyph_string_clipping):
5513 Don't pass uninitialized region to CombineRgn.
5515 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5517 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5518 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5519 (Fx_close_connection): Remove unused variable `i'.
5521 * w32font.c (w32font_draw): Return number of glyphs.
5522 (w32font_open_internal): Remove unused variable `i'.
5523 (w32font_driver): Add missing initializer.
5525 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5526 (fill_in_menu): Remove unused variable `items_added'.
5528 * w32term.c (last_mouse_press_frame): Remove static global variable.
5529 (w32_clip_to_row): Remove unused variable `f'.
5530 (x_delete_terminal): Remove unused variable `i'.
5532 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5533 (NOTHING): Remove unused static global variable.
5534 (uniscribe_check_otf): Remove unused variable `table'.
5535 (uniscribe_font_driver): Add missing initializers.
5537 2011-03-23 Julien Danjou <julien@danjou.info>
5539 * term.c (Fsuspend_tty, Fresume_tty):
5540 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5541 * window.c (temp_output_buffer_show):
5542 * insdel.c (signal_before_change):
5543 * frame.c (Fhandle_switch_frame):
5544 * fileio.c (Fdo_auto_save):
5545 * emacs.c (Fkill_emacs):
5546 * editfns.c (save_excursion_restore):
5547 * cmds.c (internal_self_insert):
5548 * callint.c (Fcall_interactively):
5549 * buffer.c (Fkill_all_local_variables):
5550 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5552 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5553 unconditionnaly since it does the check itself.
5555 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5557 Fix more problems found by GCC 4.5.2's static checks.
5559 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5560 the first time through the loop, since we know p0 < p1 then.
5561 This also avoids a gcc -Wstrict-overflow warning.
5563 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5564 leading to a memory leak, possible in functions like
5565 load_charset_map_from_file that can allocate an unbounded number
5566 of objects (Bug#8318).
5568 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5569 that could (at least in theory) be that large.
5571 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5572 This is less likely to overflow, and avoids undefined behavior if
5573 overflow does occur. All callers changed. Use strtoul to scan
5574 for the unsigned long integer.
5575 (pint2hrstr): Simplify and tune code slightly.
5576 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5578 * scroll.c (do_scrolling): Work around GCC bug 48228.
5579 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5581 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5582 This also avoids a warning with gcc -Wstrict-overflow.
5583 (validate_x_resource_name): Simplify count usage.
5584 This also avoids a warning with gcc -Wstrict-overflow.
5586 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5589 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5591 * process.c (Fmake_network_process): Use socklen_t, not int,
5592 where POSIX says socklen_t is required in portable programs.
5593 This fixes a porting bug on hosts like 64-bit HP-UX, where
5594 socklen_t is wider than int (Bug#8277).
5595 (Fmake_network_process, server_accept_connection):
5596 (wait_reading_process_output, read_process_output):
5599 * process.c: Rename or move locals to avoid shadowing.
5600 (list_processes_1, Fmake_network_process):
5601 (read_process_output_error_handler, exec_sentinel_error_handler):
5602 Rename or move locals.
5603 (Fmake_network_process): Define label "retry_connect" only if needed.
5604 (Fnetwork_interface_info): Fix pointer signedness.
5605 (process_send_signal): Add cast to avoid pointer signedness problem.
5606 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5607 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5609 Make tparam.h and terminfo.c consistent.
5610 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5611 Include tparam.h instead, since it declares them.
5612 * cm.h (PC): Remove extern decl; tparam.h now does this.
5613 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5614 * terminfo.c: Include tparam.h, to check interfaces.
5615 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5616 (tparam): Adjust signature to match interface in tparam.h;
5617 this removes some undefined behavior. Check that outstring and len
5618 are zero, which they always are with Emacs.
5619 * tparam.h (PC, BC, UP): New extern decls.
5621 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5622 (xftfont_open): Rename locals to avoid shadowing.
5624 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5625 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5626 (OTF_TAG_SYM): Omit macro if not needed.
5627 (ftfont_list): Remove unused local.
5628 (get_adstyle_property, ftfont_pattern_entity):
5629 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5630 Rename locals to avoid shadowing.
5632 * xfont.c (xfont_list_family): Mark var as initialized.
5634 * xml.c (make_dom): Now static.
5636 * composite.c (composition_compute_stop_pos): Rename local to
5638 (composition_reseat_it): Remove unused locals.
5639 (find_automatic_composition, composition_adjust_point): Likewise.
5640 (composition_update_it): Mark var as initialized.
5641 (find_automatic_composition): Mark vars as initialized,
5642 with a FIXME (Bug#8290).
5644 character.h: Rename locals to avoid shadowing.
5645 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5646 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5647 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5648 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5651 * textprop.c (property_change_between_p): Remove; unused.
5653 * intervals.c (interval_start_pos): Now static.
5655 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5657 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5658 Rename locals to avoid shadowing.
5660 * sound.c (wav_play, au_play, Fplay_sound_internal):
5661 Fix pointer signedness.
5662 (alsa_choose_format): Remove unused local var.
5663 (wav_play): Initialize a variable to 0, to prevent undefined
5664 behavior (Bug#8278).
5666 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5668 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5670 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5671 clobbering (Bug#8298).
5672 * sysdep.c (sys_subshell): Likewise.
5673 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5675 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5676 This should get cleaned up, so that child_setup has the
5677 same signature on all platforms.
5679 * callproc.c (call_process_cleanup): Now static.
5680 (relocate_fd): Rename locals to avoid shadowing.
5682 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5684 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5685 not to be necessary, and produces flickering.
5687 2011-03-20 Glenn Morris <rgm@gnu.org>
5689 * config.in: Remove file.
5691 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5693 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5694 are now in src/globals.h.
5695 (syms_of_minibuf): Remove spurious & from previous change.
5697 2011-03-20 Leo <sdl.web@gmail.com>
5699 * minibuf.c (completing-read-function): New variable.
5700 (completing-read-default): Rename from completing-read.
5701 (completing-read): Call completing-read-function.
5703 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5705 * xfaces.c (Fx_load_color_file):
5706 Read color file from absolute filename (bug#8250).
5708 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5710 * makefile.w32-in: Update dependencies.
5712 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5714 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5716 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5718 Fix more problems found by GCC 4.5.2's static checks.
5720 * process.c (make_serial_process_unwind, send_process_trap):
5721 (sigchld_handler): Now static.
5723 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5724 That way, the code declares only the vars that it needs.
5725 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5726 * s/cygwin.h (PTY_ITERATION): Likewise.
5727 * s/darwin.h (PTY_ITERATION): Likewise.
5728 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5730 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5731 * process.c (allocate_pty): Don't declare stb unless it's needed.
5733 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5734 (CONSTANTLIM): Remove; unused.
5735 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5736 Define only if needed.
5738 * unexelf.c (unexec): Name an expression,
5739 to avoid gcc -Wbad-function-cast warning.
5740 Use a different way to cause a compilation error if anyone uses
5741 n rather than nn, a way that does not involve shadowing.
5742 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5744 * deps.mk (unexalpha.o): Remove; unused.
5746 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5747 * unexec.h: New file.
5748 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5749 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5751 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5752 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5753 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5754 Change as necessary to match prototype in unexec.h.
5756 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5758 (back_comment, skip_chars): Mark vars as initialized.
5760 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5761 Rename locals to avoid shadowing.
5763 * lread.c (read1): Rewrite so as not to use empty "else".
5764 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5766 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5768 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5769 warning when compiling print.c.
5771 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5772 instead of using an uninitialized var.
5773 (font_sort_entities): Mark var as initialized.
5775 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5777 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5778 pointers to constants.
5779 (font_parse_fcname): Remove unused vars.
5780 (font_delete_unmatched): Now static.
5781 (font_get_spec): Remove; unused.
5782 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5783 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5784 Rename or move locals to avoid shadowing.
5786 * fns.c (require_nesting_list, require_unwind): Now static.
5787 (Ffillarray): Rename locals to avoid shadowing.
5789 * floatfns.c (domain_error2): Define only if needed.
5790 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5792 * alloc.c (mark_backtrace): Move decl from here ...
5793 * lisp.h: ... to here, so that it can be checked.
5795 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5796 (Fdefvar): Rewrite so as not to use empty "else".
5797 (lisp_indirect_variable): Name an expression,
5798 to avoid gcc -Wbad-function-cast warning.
5799 (Fdefvar): Rename locals to avoid shadowing.
5801 * callint.c (quotify_arg, quotify_args): Now static.
5802 (Fcall_interactively): Rename locals to avoid shadowing.
5803 Use const pointer when appropriate.
5805 * lisp.h (get_system_name, get_operating_system_release):
5806 Move decls here, to check interfaces.
5807 * process.c (get_operating_system_release): Move decl to lisp.h.
5808 * xrdb.c (get_system_name): Likewise.
5809 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5810 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5811 some of which prompt warnings from gcc -Wbad-function-cast.
5812 (Fformat_time_string, Fencode_time, Finsert_char):
5813 (Ftranslate_region_internal, Fformat):
5814 Rename or remove local vars to avoid shadowing.
5815 (Ftranslate_region_internal): Mark var as initialized.
5817 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5820 * lisp.h (eassert): Check that the argument compiles, even if
5821 ENABLE_CHECKING is not defined.
5823 * data.c (Findirect_variable): Name an expression, to avoid
5824 gcc -Wbad-function-cast warning.
5825 (default_value, arithcompare, arith_driver, arith_error): Now static.
5826 (store_symval_forwarding): Rename local to avoid shadowing.
5827 (Fmake_variable_buffer_local, Fmake_local_variable):
5828 Mark variables as initialized.
5829 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5831 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5832 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5833 Rename locals to avoid shadowing.
5834 (mark_stack): Move local variables into the #ifdef region where
5836 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5837 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5839 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5840 (GC_STRING_CHARS): Remove; not used.
5841 (Fmemory_limit): Cast sbrk's returned value to char *.
5843 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5844 avoids undefined behavior in theory.
5846 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5848 Use functions, not macros, for up- and down-casing (Bug#8254).
5849 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5850 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5851 to use the following functions instead of these macros.
5852 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5853 EMACS_INT, since callers assume the returned value fits in int.
5854 (upcase1): Likewise, for UPCASE_TABLE.
5855 (uppercasep, lowercasep, upcase): New static inline functions.
5856 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5857 the race-condition problem in the old DOWNCASE.
5859 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5860 Rename locals to avoid shadowing.
5861 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5862 (regex_compile, re_search_2, re_match_2_internal):
5863 Remove unused local vars.
5864 (FREE_VAR): Rewrite so as not to use empty "else",
5865 which gcc can warn about.
5866 (regex_compile, re_match_2_internal): Mark locals as initialized.
5867 (RETALLOC_IF): Define only if needed.
5868 (WORDCHAR_P): Likewise. This one is never needed, but is used
5869 only in a comment talking about a compiler bug, so put inside
5870 the #if 0 of that comment.
5871 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5872 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5875 * search.c (boyer_moore): Rename locals to avoid shadowing.
5876 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5877 (PREV_CHAR_BOUNDARY): Likewise.
5879 * search.c (simple_search): Remove unused var.
5881 * dired.c (compile_pattern): Move decl from here ...
5882 * lisp.h: ... to here, so that it can be checked.
5883 (struct re_registers): New forward decl.
5885 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5887 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5889 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5890 Rename locals to avoid shadowing.
5891 (Fvertical_motion): Mark locals as initialized.
5893 * casefiddle.c (casify_object, casify_region): Now static.
5894 (casify_region): Mark local as initialized.
5896 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5898 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5899 New macros, so that the caller can use some names other than
5900 gcpro1, gcpro2, etc.
5901 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5903 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5904 argument, for consistency with GCPRO2_VAR, etc: it is now the
5905 prefix of the variable, not the variable itself. All uses
5907 * dired.c (directory_files_internal, file_name_completion):
5908 Rename locals to avoid shadowing.
5910 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5911 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5912 dired.c's scmp function, had undefined behavior.
5913 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5914 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5915 * buffer.h: ... to here, because these macros use current_buffer,
5916 and the new implementation with inline functions needs to have
5917 current_buffer in scope now, rather than later when the macros
5919 (downcase, upcase1): New static inline functions.
5920 (DOWNCASE, UPCASE1): Reimplement using these functions.
5921 This avoids undefined behavior in expressions like
5922 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5923 from race conditions in accessing the global variables
5924 case_temp1 and case_temp2.
5925 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5926 * lisp.h (case_temp1, case_temp2): Remove their decls.
5927 * character.h (ASCII_CHAR_P): Move from here ...
5928 * lisp.h: ... to here, so that the inline functions mentioned
5931 * dired.c (directory_files_internal_unwind): Now static.
5933 * fileio.c (file_name_as_directory, directory_file_name):
5934 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5936 (file_name_as_directory): Use const pointers when appropriate.
5937 (Fexpand_file_name): Likewise. In particular, newdir might
5938 point at constant storage, so make it a const pointer.
5939 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5940 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5942 (Fset_file_times, Finsert_file_contents, auto_save_error):
5943 Rename locals to avoid shadowing.
5945 * minibuf.c (choose_minibuf_frame_1): Now static.
5946 (Ftry_completion, Fall_completions): Rename or remove locals
5949 * marker.c (bytepos_to_charpos): Remove; unused.
5951 * lisp.h (verify_bytepos, count_markers): New decls,
5952 so that gcc does not warn that these functions aren't declared.
5954 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5955 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5956 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5957 (copy_text): Remove unused local var.
5959 * filelock.c (within_one_second): Now static.
5960 (lock_file_1): Rename local to avoid shadowing.
5962 * buffer.c (fix_overlays_before): Mark locals as initialized.
5963 (fix_start_end_in_overlays): Likewise. This function should be
5964 simplified by using pointers-to-pointers, but that's a different
5966 (switch_to_buffer_1): Now static.
5967 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5968 (report_overlay_modification): Rename locals to avoid shadowing.
5970 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5971 Fix pointer signedness issue.
5972 (sys_subshell): Mark local as volatile if checking for lint,
5973 to suppress a gcc -Wclobbered warning that does not seem to be right.
5974 (MAXPATHLEN): Define only if needed.
5976 * process.c (serial_open, serial_configure): Move decls from here ...
5977 * systty.h: ... to here, so that they can be checked.
5979 * fns.c (get_random, seed_random): Move extern decls from here ...
5980 * lisp.h: ... to here, so that they can be checked.
5982 * sysdep.c (reset_io): Now static.
5983 (wait_for_termination_signal): Remove; unused.
5985 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5986 (copy_keymap_item, append_key, push_text_char_description):
5988 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5989 (DENSE_TABLE_SIZE): Remove; unused.
5990 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5991 (describe_map_tree):
5992 Rename locals to avoid shadowing.
5994 * keyboard.c: Declare functions static if they are not used elsewhere.
5995 (echo_char, echo_dash, cmd_error, top_level_2):
5996 (poll_for_input, handle_async_input): Now static.
5997 (read_char, kbd_buffer_get_event, make_lispy_position):
5998 (make_lispy_event, make_lispy_movement, apply_modifiers):
5999 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6000 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6001 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6002 (read_key_sequence, read_char): Mark locals as initialized.
6003 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6005 * keyboard.h (make_ctrl_char): New decl.
6006 (mark_kboards): Move decl here ...
6007 * alloc.c (mark_kboards): ... from here.
6009 * lisp.h (force_auto_save_soon): New decl.
6011 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6012 (DEFINE_DUMMY_FUNCTION): New macro.
6013 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6015 (main): Add casts to avoid warnings
6016 if GCC considers string literals to be constants.
6018 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6020 * dbusbind.c: Pointer signedness fixes.
6021 (xd_signature, xd_append_arg, xd_initialize):
6022 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6024 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6025 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6027 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6028 if GCC considers string literals to be constants.
6029 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6031 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6033 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6034 (print_preprocess, print_object): New macro to fix last change.
6036 * print.c (print_preprocess): Don't forget font objects.
6038 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6040 * emacs.c (USAGE3): Doc fixes.
6042 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6044 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6047 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6049 * lisp.h (VWindow_system, Qfile_name_history):
6050 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6051 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6052 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6054 * w32select.c: Don't #include "keyboard.h".
6055 (run_protected): Add extern declaration for waiting_for_input.
6057 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6058 * w32console.c (detect_input_pending, read_input_pending)
6059 (encode_terminal_code):
6060 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6061 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6062 (w32_system_caret_y, Qfile_name_history):
6063 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6064 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6065 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6066 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6067 * w32proc.c (Qlocal, report_file_error):
6068 * w32term.c (Vwindow_system, updating_frame):
6069 * w32uniscribe.c (initialized, uniscribe_font_driver):
6070 Remove unneeded extern declarations.
6072 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6074 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6076 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6078 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6079 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6080 These macros can no longer be used for assignment.
6082 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6083 Assign struct members directly, instead of using BUF_BEGV etc.
6084 (record_buffer_markers, fetch_buffer_markers): New functions for
6085 recording and fetching special buffer markers.
6086 (set_buffer_internal_1, set_buffer_temp): Use them.
6088 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6090 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6092 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6093 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6095 * xdisp.c (hscroll_window_tree):
6096 (reconsider_clip_changes): Use PT instead of BUF_PT.
6098 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6100 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6101 $(EMACS_ROOT)/lib/intprops.h.
6103 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6105 Fix more problems found by GCC 4.5.2's static checks.
6107 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6108 to unsigned char * to avoid compiler diagnostic.
6109 (xg_free_frame_widgets): Make it clear that a local variable is
6110 needed only if USE_GTK_TOOLTIP.
6111 (gdk_window_get_screen): Make it clear that this macro is needed
6112 only if USE_GTK_TOOLTIP.
6113 (int_gtk_range_get_value): New function, which avoids a diagnostic
6114 from gcc -Wbad-function-cast.
6115 (xg_set_toolkit_scroll_bar_thumb): Use it.
6116 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6117 diagnostic from gcc -Wbad-function-cast.
6118 (get_utf8_string, xg_get_file_with_chooser):
6119 Rename locals to avoid shadowing.
6120 (create_dialog): Move locals to avoid shadowing.
6122 * xgselect.c (xg_select): Remove unused var.
6124 * image.c (four_corners_best): Mark locals as initialized.
6125 (gif_load): Initialize transparent_p to zero (Bug#8238).
6126 Mark another local as initialized.
6127 (my_png_error, my_error_exit): Mark with NO_RETURN.
6129 * image.c (clear_image_cache): Now static.
6130 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6131 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6132 (x_edge_detection): Remove unnecessary cast that
6133 gcc -Wbad-function-cast diagnoses.
6134 (gif_load): Fix pointer signedness.
6135 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6136 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6138 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6140 Improve quality of tests for time stamp overflow.
6141 For example, without this patch (encode-time 0 0 0 1 1
6142 1152921504606846976) returns the obviously-bogus value (-948597
6143 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6144 reports time overflow. See
6145 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6146 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6147 * editfns.c: Include limits.h and intprops.h.
6148 (TIME_T_MIN, TIME_T_MAX): New macros.
6149 (time_overflow): Move earlier, to before first use.
6150 (hi_time, lo_time): New functions, for an accurate test for
6152 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6153 (Fget_internal_run_time): Don't assume time_t fits in int.
6154 (make_time): Use list2 instead of Fcons twice.
6155 (Fdecode_time): More accurate test for out-of-range times.
6156 (check_tm_member): New function.
6157 (Fencode_time): Use it, to test for out-of-range times.
6158 (lisp_time_argument): Don't rely on undefined left-shift and
6159 right-shift behavior when checking for time stamp overflow.
6161 * editfns.c (time_overflow): New function, refactoring common code.
6162 (Fformat_time_string, Fdecode_time, Fencode_time):
6163 (Fcurrent_time_string): Use it.
6165 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6166 * dired.c (make_time): Move to ...
6167 * editfns.c (make_time): ... here.
6168 * systime.h: Note the move.
6170 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6172 * fringe.c (update_window_fringes): Remove unused variables.
6174 * unexmacosx.c (copy_data_segment): Also copy __got section.
6177 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6179 * termcap.c [MSDOS]: Include "msdos.h".
6180 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6181 Constify `char *' arguments and their references according to
6182 prototypes in tparam.h.
6184 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6186 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6187 Adapt all references accordingly.
6189 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6191 2011-03-11 Tom Tromey <tromey@redhat.com>
6193 * buffer.c (syms_of_buffer): Remove obsolete comment.
6195 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6197 * termhooks.h (encode_terminal_code): Declare prototype.
6199 * msdos.c (encode_terminal_code): Don't declare prototype.
6201 * term.c (encode_terminal_code): Now external again, used by
6202 w32console.c and msdos.c.
6204 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6205 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6207 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6209 Fix some minor problems found by GCC 4.5.2's static checks.
6211 * fringe.c (update_window_fringes): Mark locals as initialized
6213 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6215 * alloc.c (mark_fringe_data): Move decl from here ...
6216 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6217 to check its interface.
6218 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6220 * fontset.c (free_realized_fontset): Now static.
6221 (Fset_fontset_font): Rename local to avoid shadowing.
6222 (fontset_font): Mark local as initialized.
6223 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6225 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6227 * xselect.c (x_disown_buffer_selections): Remove; not used.
6228 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6229 (x_own_selection, Fx_disown_selection_internal): Rename locals
6231 (x_handle_dnd_message): Remove local to avoid shadowing.
6233 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6234 so that the caller can use some name other than gcpro1.
6235 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6236 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6237 (Fx_backspace_delete_keys_p):
6238 Use them to avoid shadowing, and rename vars to avoid shadowing.
6239 (x_decode_color, x_set_name, x_window): Now static.
6240 (Fx_create_frame): Add braces to silence GCC warning.
6241 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6242 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6243 Remove unused locals.
6244 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6245 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6246 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6249 * xterm.h (x_mouse_leave): New decl.
6251 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6252 Remove unused functions.
6253 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6254 (x_calc_absolute_position): Now static.
6255 (XTread_socket): Don't define label "out" unless it's used.
6256 Don't declare local "event" unless it's used.
6257 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6258 unless they are used.
6259 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6260 (x_fatal_error_signal): Remove; not used.
6261 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6262 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6263 (x_error_catcher, x_connection_closed, x_error_handler):
6264 (x_error_quitter, xembed_send_message, x_iconify_frame):
6265 (my_log_handler): Rename locals to avoid shadowing.
6266 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6267 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6269 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6270 Rename or move locals to avoid shadowing.
6271 (tty_defined_color, merge_face_heights): Now static.
6272 (free_realized_faces_for_fontset): Remove; not used.
6273 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6274 does not deduce is never used uninitialized.
6275 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6276 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6278 * terminal.c (store_terminal_param): Now static.
6280 * xmenu.c (menu_highlight_callback): Now static.
6281 (set_frame_menubar): Remove unused local.
6282 (xmenu_show): Rename parameter to avoid shadowing.
6283 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6284 since they might point to immutable storage.
6285 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6286 since it's unused otherwise.
6288 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6289 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6290 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6291 avoids a gcc -Wuninitialized diagnostic.
6292 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6293 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6294 does not deduce are never used uninitialized.
6296 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6298 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6299 * window.c (window_loop, size_window):
6300 (run_window_configuration_change_hook, enlarge_window): Likewise.
6302 * window.c (display_buffer): Now static.
6303 (size_window): Mark variables that gcc -Wuninitialized
6304 does not deduce are never used uninitialized.
6305 * window.h (check_all_windows): New decl, to forestall
6306 gcc -Wmissing-prototypes diagnostic.
6307 * dispextern.h (bidi_dump_cached_states): Likewise.
6309 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6311 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6313 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6314 and to avoid gcc -Wuninitialized warning.
6315 (load_charset_map): Mark variables that gcc -Wuninitialized
6316 does not deduce are never used uninitialized.
6317 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6319 * coding.c (coding_set_source, coding_set_destination):
6320 Use "else { /* comment */ }" rather than "else /* comment */;"
6321 for clarity, and to avoid gcc -Wempty-body warning.
6322 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6323 a block, when the outer 'i' will do.
6324 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6325 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6326 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6327 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6328 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6329 Rename locals to avoid shadowing.
6330 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6331 * coding.c (emacs_mule_char, encode_invocation_designation):
6332 Now static, since they're not used elsewhere.
6333 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6334 (decode_coding_object, encode_coding_object, detect_coding_system):
6335 (decode_coding_emacs_mule): Mark variables that gcc
6336 -Wuninitialized does not deduce are never used uninitialized.
6337 (detect_coding_iso_2022): Initialize a local variable that might
6338 be used uninitialized. Leave a FIXME because it's not clear that
6339 this initialization is needed. (Bug#8211)
6340 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6341 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6342 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6343 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6344 Remove unused macros.
6346 * category.c (hash_get_category_set): Remove unused local var.
6347 (copy_category_table): Now static, since it's not used elsewhere.
6348 * character.c (string_count_byte8): Likewise.
6350 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6351 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6353 * chartab.c (copy_sub_char_table): Now static, since it's not used
6355 (sub_char_table_ref_and_range, char_table_ref_and_range):
6356 Rename locals to avoid shadowing.
6357 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6359 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6360 (BIDI_BOB): Remove unused macro.
6362 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6363 deduce are never used uninitialized.
6364 * term.c (encode_terminal_code): Likewise.
6366 * term.c (encode_terminal_code): Now static. Remove unused local.
6368 * tparam.h: New file.
6369 * term.c, tparam.h: Include it.
6370 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6371 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6372 Move these decls to tparam.h, and make them agree with what
6373 is actually in tparam.c. The previous trick of using incompatible
6374 decls in different modules does not conform to the C standard.
6375 All callers of tparam changed to use tparam's actual API.
6376 * tparam.c (tparam1, tparam, tgoto):
6377 Use const pointers where appropriate.
6379 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6380 * cm.h (struct cm): Likewise.
6381 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6382 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6383 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6384 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6385 (turn_on_face, init_tty): Likewise.
6386 * termchar.h (struct tty_display_info): Likewise.
6388 * term.c (term_mouse_position): Rename local to avoid shadowing.
6390 * alloc.c (mark_ttys): Move decl from here ...
6391 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6393 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6395 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6397 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6399 * search.c (compile_pattern_1): Remove argument regp, unused since
6400 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6401 (compile_pattern): Don't pass it.
6403 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6405 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6406 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6408 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6410 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6412 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6413 gdk_window_get_screen, gdk_window_get_geometry,
6414 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6415 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6416 (xg_get_pixbuf_from_pixmap): New function.
6417 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6418 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6419 Call xg_get_pixbuf_from_pixmap instead of
6420 gdk_pixbuf_get_from_drawable.
6421 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6422 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6423 (xg_check_special_colors): Use GtkStyleContext and its functions
6425 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6426 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6427 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6428 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6429 Call gtk_widget_get_preferred_size.
6430 (xg_frame_resized): gdk_window_get_geometry only takes 5
6432 (xg_win_to_widget, xg_event_is_for_menubar):
6433 Call gdk_x11_window_lookup_for_display.
6434 (xg_set_widget_bg): New function.
6435 (delete_cb): New function.
6436 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6437 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6438 (xg_set_background_color): Call xg_set_widget_bg.
6439 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6440 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6441 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6442 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6444 (update_frame_tool_bar): Call gtk_widget_hide.
6445 (xg_initialize): Use GDK_KEY_g.
6447 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6449 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6451 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6452 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6453 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6455 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6457 * w32xfns.c (select_palette): Check success of RealizePalette against
6458 GDI_ERROR, not zero.
6460 See ChangeLog.11 for earlier changes.
6466 Copyright (C) 2011 Free Software Foundation, Inc.
6468 This file is part of GNU Emacs.
6470 GNU Emacs is free software: you can redistribute it and/or modify
6471 it under the terms of the GNU General Public License as published by
6472 the Free Software Foundation, either version 3 of the License, or
6473 (at your option) any later version.
6475 GNU Emacs is distributed in the hope that it will be useful,
6476 but WITHOUT ANY WARRANTY; without even the implied warranty of
6477 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6478 GNU General Public License for more details.
6480 You should have received a copy of the GNU General Public License
6481 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.