Fix bug #11063 with move_it_by_lines when there's a before-string at bol.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4 position we get to after a call to move_it_to fails the
5 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6 only if we wind up in a string from display property. (Bug#11063)
7
8 * window.c (Fdelete_other_windows_internal): Invalidate the row
9 and column information about mouse highlight, so that redisplay
10 restores it after reallocating the glyph matrices. (Bug#7464)
11
12 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
13 string comes from a `display' text property, use the buffer
14 position of that property as if we actually saw that position in
15 the row's glyphs.
16 (move_it_by_lines): Remove the assertion that
17 "it->current_x == 0 && it->hpos == 0" which can be legitimately
18 violated when there's a before-string at the beginning of a line.
19 (Bug#11063)
20
21 2012-03-30 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (append_space_for_newline): If the default face was
24 remapped, use the remapped face for the appended newline.
25 (extend_face_to_end_of_line): Use the remapped default face for
26 extending the face to the end of the line.
27 (display_line): Call extend_face_to_end_of_line when the default
28 face was remapped. (Bug#11068)
29
30 2012-03-29 Eli Zaretskii <eliz@gnu.org>
31
32 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
33
34 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
35
36 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
37
38 2012-03-27 Glenn Morris <rgm@gnu.org>
39
40 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
41 Doc fixes.
42
43 2012-03-26 Kenichi Handa <handa@m17n.org>
44
45 * dispextern.h (struct glyph): Fix previous change. Change the
46 bit length of glyphless.ch to 25 (Bug#11082).
47
48 2012-03-26 Chong Yidong <cyd@gnu.org>
49
50 * keyboard.c (Vselection_inhibit_update_commands): New variable.
51 (command_loop_1): Use it; inhibit selection update for
52 handle-select-window too (Bug#8996).
53
54 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
55
56 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
57
58 2012-03-25 Kenichi Handa <handa@m17n.org>
59
60 * dispextern.h (struct glyph): Change the bit length of
61 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
62
63 2012-03-24 Eli Zaretskii <eliz@gnu.org>
64
65 * s/ms-w32.h (tzname): Include time.h before redirecting to
66 _tzname. Fixes the MSVC build. (Bug#9960)
67
68 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
69
70 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
71 characters.
72
73 * xterm.c (XTread_socket): Only modify handling_signal if
74 !SYNC_INPUT. (Bug#11080)
75
76 2012-03-23 Eli Zaretskii <eliz@gnu.org>
77
78 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
79 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
80 when fetching a multibyte character consumes more bytes than
81 CHAR_BYTES returns, due to unification of CJK characters in
82 string_char. (Bug#11073)
83
84 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
85
86 * process.c (wait_reading_process_output): Handle pty disconnect
87 by refraining from sending oneself a SIGCHLD (bug#10933).
88
89 2012-03-22 Chong Yidong <cyd@gnu.org>
90
91 * dispextern.h (struct it): New member string_from_prefix_prop_p.
92
93 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
94 Mark string as coming from a prefix property.
95 (handle_face_prop): Use default face for prefix strings (Bug#4281).
96 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
97
98 2012-03-21 Chong Yidong <cyd@gnu.org>
99
100 * xfaces.c (Vface_remapping_alist): Doc fix.
101
102 2012-03-20 Eli Zaretskii <eliz@gnu.org>
103
104 * w32proc.c (Fw32_set_console_codepage)
105 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
106 Doc fixes.
107
108 2012-03-20 Chong Yidong <cyd@gnu.org>
109
110 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
111 to reflect default non-nil value of redisplay-dont-pause.
112
113 2012-03-19 Kenichi Handa <handa@m17n.org>
114
115 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
116 it fit in a valid range (Bug#11003).
117
118 2012-03-18 Eli Zaretskii <eliz@gnu.org>
119
120 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
121 that is not from display property, accept the row as a "cursor
122 row" if one of the string's character has a non-nil `cursor'
123 property. Fixes cursor positioning when there are newlines in
124 overlay strings, e.g. in icomplete.el. (Bug#11035)
125
126 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
127
128 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
129
130 2012-03-12 Chong Yidong <cyd@gnu.org>
131
132 * eval.c (inhibit_lisp_code): Rename from
133 inhibit_window_configuration_change_hook; move from window.c.
134
135 * xfns.c (unwind_create_frame_1, Fx_create_frame):
136 * window.c (run_window_configuration_change_hook)
137 (syms_of_window): Callers changed.
138
139 2012-03-11 Chong Yidong <cyd@gnu.org>
140
141 * keymap.c (Fkey_description): Doc fix (Bug#9700).
142
143 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
144
145 2012-03-10 Chong Yidong <cyd@gnu.org>
146
147 * frame.c (other_visible_frames): Don't assume the selected frame
148 is visible (Bug#10955).
149
150 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
151
152 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
153
154 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
155
156 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
157 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
158 zero (Bug#10954).
159
160 2012-03-03 Glenn Morris <rgm@gnu.org>
161
162 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
163
164 2012-03-02 Eli Zaretskii <eliz@gnu.org>
165
166 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
167 position past the first glyph_row that ends at ZV. (Bug#10902)
168 (redisplay_window, next_element_from_string): Fix typos in
169 comments.
170 (redisplay_window): Pass to move_it_vertically the margin in
171 pixels, not in screen lines.
172
173 2012-03-02 Glenn Morris <rgm@gnu.org>
174
175 * buffer.c (buffer-list-update-hook): Doc fix.
176
177 2012-02-29 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
180 push_it before setting up the iterator for the first overlay
181 string, even if we have an empty string loaded.
182 (next_overlay_string): If there's an empty string on the iterator
183 stack, pop the stack. (Bug#10903)
184
185 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
186
187 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
188 Suggested by Stefan Monnier in
189 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
190 * alloc.c (widen_to_Lisp_Object): New static function.
191 (mark_memory): Also mark Lisp_Objects by fetching pointer words
192 and widening them to Lisp_Objects. This would work even if
193 USE_LSB_TAG is defined and wide integers are used, which might
194 happen in a future version of Emacs.
195
196 2012-02-25 Chong Yidong <cyd@gnu.org>
197
198 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
199 Doc fix.
200
201 * xselect.c (Fx_selection_exists_p): Doc fix.
202 (x_clipboard_manager_save_all): Print an informative message
203 before saving to clipboard manager.
204
205 2012-02-24 Chong Yidong <cyd@gnu.org>
206
207 * keyboard.c (process_special_events): Handle all X selection
208 requests in kbd_buffer, not just the next one (Bug#8869).
209
210 2012-02-23 Chong Yidong <cyd@gnu.org>
211
212 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
213 call when setting menu-bar-lines and tool-bar-lines parameters.
214 (unwind_create_frame_1): New helper function.
215
216 * window.c (inhibit_window_configuration_change_hook): New var.
217 (run_window_configuration_change_hook): Obey it.
218 (syms_of_window): Initialize it.
219
220 2012-02-22 Chong Yidong <cyd@gnu.org>
221
222 * xterm.c (x_draw_image_relief): Add missing type check for
223 Vtool_bar_button_margin (Bug#10743).
224
225 2012-02-21 Chong Yidong <cyd@gnu.org>
226
227 * fileio.c (Vfile_name_handler_alist): Doc fix.
228
229 * buffer.c (Fget_file_buffer): Protect against invalid file
230 handler return value.
231
232 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
233
234 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
235 when computing $valmask.
236
237 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
238 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
239 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
240 It's useless in that case, and it can cause problems on hosts
241 that allocate halves of EMACS_INT values separately.
242 Reported by Dan Horák. Diagnosed by Andreas Schwab in
243 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
244 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
245 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
246 it avoids undefined behavior on hosts where shifting right by more
247 than the word width has undefined behavior.
248
249 2012-02-19 Chong Yidong <cyd@gnu.org>
250
251 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
252 (Funhandled_file_name_directory, Ffile_name_as_directory)
253 (Fdirectory_file_name, Fexpand_file_name)
254 (Fsubstitute_in_file_name): Protect against invalid file handler
255 return values (Bug#10845).
256
257 2012-02-18 Eli Zaretskii <eliz@gnu.org>
258
259 * .gdbinit (pitx): Fix incorrect references to fields of the
260 iterator stack.
261
262 2012-02-17 Chong Yidong <cyd@gnu.org>
263
264 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
265
266 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
267
268 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
269 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
270
271 2012-02-15 Chong Yidong <cyd@gnu.org>
272
273 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
274 marked as special. Also, starting docstrings with * is obsolete.
275
276 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
277
278 * gnutls.c (emacs_gnutls_write): Fix last change.
279
280 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
281
282 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
283 send_process.
284
285 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
286
287 * keymap.c (Fsingle_key_description): Handle char ranges.
288
289 2012-02-12 Chong Yidong <cyd@gnu.org>
290
291 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
292 as that creates a dangerous corner case.
293
294 * window.c (Fdelete_window_internal): Invalidate the mouse
295 highlight (Bug#9904).
296
297 2012-02-12 Glenn Morris <rgm@gnu.org>
298
299 * xselect.c (Fx_own_selection_internal)
300 (Fx_get_selection_internal, Fx_disown_selection_internal)
301 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
302 * nsselect.m (Fx_own_selection_internal)
303 (Fx_disown_selection_internal, Fx_selection_exists_p)
304 (Fx_selection_owner_p, Fx_get_selection_internal):
305 Sync docs and argument specs with the xselect.c versions.
306
307 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
308
309 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
310
311 2012-02-11 Eli Zaretskii <eliz@gnu.org>
312
313 * w32select.c (Fx_selection_exists_p): Sync doc string and
314 argument list with xselect.c. (Bug#10783)
315
316 * w16select.c (Fx_selection_exists_p): Sync doc string and
317 argument list with xselect.c. (Bug#10783)
318
319 2012-02-10 Glenn Morris <rgm@gnu.org>
320
321 * fns.c (Fsecure_hash): Doc fix.
322
323 2012-02-09 Kenichi Handa <handa@m17n.org>
324
325 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
326
327 2012-02-07 Chong Yidong <cyd@gnu.org>
328
329 * buffer.c (Fbuffer_local_variables)
330 (buffer_lisp_local_variables): Handle unbound vars correctly;
331 don't let Qunbound leak into Lisp.
332
333 2012-02-07 Glenn Morris <rgm@gnu.org>
334
335 * image.c (Fimagemagick_types): Doc fix.
336
337 * image.c (imagemagick-render-type): Change it from a lisp object
338 to an integer. Move the doc here from the lisp manual.
339 Treat all values not equal to 0 the same.
340
341 2012-02-06 Chong Yidong <cyd@gnu.org>
342
343 * doc.c (store_function_docstring): Avoid applying docstring of
344 alias to base function (Bug#2603).
345
346 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
347
348 * .gdbinit (pp1, pv1): Remove redundant defines.
349 (pr): Use pp.
350
351 2012-02-04 Chong Yidong <cyd@gnu.org>
352
353 * nsterm.m: Declare a global (Bug#10694).
354
355 2012-02-04 Eli Zaretskii <eliz@gnu.org>
356
357 * w32.c (get_emacs_configuration_options):
358 Include --enable-checking, if specified, in the return value.
359
360 2012-02-04 Martin Rudalics <rudalics@gmx.at>
361
362 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
363 after rounding frame sizes. (Bug#9723)
364
365 2012-02-04 Eli Zaretskii <eliz@gnu.org>
366
367 * keyboard.c (adjust_point_for_property): Don't position point
368 before BEGV. (Bug#10696)
369
370 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
371
372 Handle overflow when computing char display width (Bug#9496).
373 * character.c (char_width): Return EMACS_INT, not int.
374 (char_width, c_string_width): Check for overflow when
375 computing the width; this is possible now that individual
376 characters can have unbounded width. Problem introduced
377 by merge from Emacs 23 on 2012-01-19.
378
379 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
380
381 * dbusbind.c (Fdbus_register_method): Mention the return value
382 :ignore in the docstring.
383
384 2012-02-02 Glenn Morris <rgm@gnu.org>
385
386 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
387
388 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
389 Unconditionally set to t. (Bug#10673)
390 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
391 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
392 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
393
394 2012-02-02 Kenichi Handa <handa@m17n.org>
395
396 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
397 0, do not call append_composite_glyph.
398
399 2012-02-02 Kenichi Handa <handa@m17n.org>
400
401 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
402 NULL (Bug#6988).
403 (x_produce_glyphs): If the component of a composition is a null
404 string, set it->pixel_width to 1 to avoid zero-width glyph.
405
406 2012-02-01 Eli Zaretskii <eliz@gnu.org>
407
408 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
409 first 2 arguments are identical. This makes inserting large
410 output from a subprocess an order of magnitude faster on
411 MS-Windows, where all sbrk'ed memory is always contiguous.
412
413 2012-01-31 Glenn Morris <rgm@gnu.org>
414
415 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
416 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
417 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
418
419 2012-01-29 Glenn Morris <rgm@gnu.org>
420
421 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
422
423 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
424
425 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
426
427 2012-01-28 Chong Yidong <cyd@gnu.org>
428
429 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
430
431 2012-01-26 Chong Yidong <cyd@gnu.org>
432
433 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
434
435 * search.c (Fsearch_forward, Fsearch_backward): Document negative
436 repeat counts (Bug#10507).
437
438 2012-01-26 Glenn Morris <rgm@gnu.org>
439
440 * lread.c (syms_of_lread): Doc fix.
441
442 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
443
444 * coding.c (encode_designation_at_bol): Change return value to
445 EMACS_INT.
446
447 2012-01-25 Chong Yidong <cyd@gnu.org>
448
449 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
450
451 2012-01-21 Chong Yidong <cyd@gnu.org>
452
453 * floatfns.c (Fcopysign): Make the second argument non-optional,
454 since nil is not allowed anyway.
455
456 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
457
458 * process.c (read_process_output): Use p instead of XPROCESS (proc).
459 (send_process): Likewise.
460
461 2012-01-19 Martin Rudalics <rudalics@gmx.at>
462
463 * window.c (save_window_save, Fcurrent_window_configuration)
464 (Vwindow_persistent_parameters): Do not use Qstate.
465 Rewrite doc-strings.
466
467 2012-01-19 Kenichi Handa <handa@m17n.org>
468
469 * character.c (char_width): New function.
470 (Fchar_width, c_string_width, lisp_string_width):
471 Use char_width (Bug#9496).
472
473 2012-01-16 Martin Rudalics <rudalics@gmx.at>
474
475 * window.c (Vwindow_persistent_parameters): New variable.
476 (Fset_window_configuration, save_window_save): Handle persistent
477 window parameters.
478
479 2012-01-14 Eli Zaretskii <eliz@gnu.org>
480
481 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
482 thrashing the stack of the thread. (Bug#9087)
483
484 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
485
486 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
487
488 2012-01-11 Eli Zaretskii <eliz@gnu.org>
489
490 * xdisp.c (rows_from_pos_range): Handle the case where the
491 highlight ends on a newline. (Bug#10464)
492 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
493 he end column for display of highlight that ends on a newline
494 before a R2L line.
495
496 2012-01-11 Glenn Morris <rgm@gnu.org>
497
498 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
499 from load-path also when installation-directory is nil. (Bug#10208)
500
501 2012-01-10 Glenn Morris <rgm@gnu.org>
502
503 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
504
505 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
506 Update template values to be closer to their typical values these days.
507
508 2012-01-09 Eli Zaretskii <eliz@gnu.org>
509
510 * xdisp.c (rows_from_pos_range): Accept additional argument
511 DISP_STRING, and accept any glyph in a row whose object is that
512 string as eligible for mouse highlight. Fixes mouse highlight of
513 display strings from overlays. (Bug#10464)
514
515 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
516
517 emacs: fix an auto-save permissions race condition (Bug#10400)
518 * fileio.c (auto_saving_dir_umask): New static var.
519 (Fmake_directory_internal): Use it.
520 (do_auto_save_make_dir): Set it, instead of invoking chmod after
521 creating the directory. The old code temporarily assigns
522 too-generous permissions to the directory.
523 (do_auto_save_eh): Clear it.
524 (Fdo_auto_save): Catch all errors, not just file errors, so
525 that the var is always cleared.
526
527 2012-01-07 Eli Zaretskii <eliz@gnu.org>
528
529 * search.c (scan_buffer): Pass character positions to
530 know_region_cache, not byte positions. (Bug#6540)
531
532 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
533
534 * w32.c (sys_rename): Report EXDEV when rename of a directory
535 fails because the target is on another logical disk. (Bug#10284)
536
537 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
538
539 * xterm.c (x_embed_request_focus): New function.
540
541 * xterm.h: Add prototype.
542
543 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
544
545 2012-01-05 Glenn Morris <rgm@gnu.org>
546
547 * emacs.c (emacs_copyright): Update short copyright year to 2012.
548
549 2012-01-01 Eli Zaretskii <eliz@gnu.org>
550
551 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
552 Load gnutls_transport_set_lowat only if GnuTLS version is below
553 2.11.1.
554 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
555 GnuTLS versions below 2.11.1.
556
557 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
558
559 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
560 to the doc string advising against its use for altering the way
561 windows are scrolled.
562
563 2011-12-28 Kenichi Handa <handa@m17n.org>
564
565 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
566 coding-system ASCII compatible only when it does not produce BOM
567 on encoding (Bug#10383).
568
569 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
570
571 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
572 can scroll.
573 (create_and_show_popup_menu): Always use menu_position_func for
574 Gtk3 (Bug#10361).
575
576 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
577
578 * callint.c (Fcall_interactively): Don't truncate prompt string.
579
580 2011-12-23 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
583 property that ends at ZV, so that the bidi iteration could be
584 resumed from there (after widening). (Bug#10360)
585
586 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
587
588 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
589
590 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
591
592 * nsterm.m (x_free_frame_resources):
593 Release f->output_data.ns->miniimage.
594 (ns_index_color): Fix indentation. Do not retain
595 color_table->colors[i].
596
597 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
598 before returning.
599
600 * nsfns.m (x_set_background_color): Assign return value from
601 ns_index_color to face-background instead of NSColor*.
602 (ns_implicitly_set_icon_type): Fix indentation.
603 Change assignment in for loop to comparison.
604
605 * emacs.c (ns_pool): New variable.
606 (main): Assign ns_pool.
607 (Fkill_emacs): Call ns_release_autorelease_pool.
608
609 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
610 autorelease fdesc, release fdAttrs and tdict.
611 (ns_get_covering_families): Release charset.
612 (ns_findfonts): Release NSFontDescriptor created with new.
613 (ns_uni_to_glyphs): Fix indentation.
614 (setString): Release attrStr before assigning new value.
615
616 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
617
618 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
619 and NS_IMPL_COCOA.
620 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
621 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
622
623 2011-12-18 David Reitter <reitter@cmu.edu>
624
625 * nsterm.m (ns_term_init): Subscribe for notifications
626 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
627 to method trackingNotification in EmacsMenu.
628
629 * nsmenu.m (trackingMenu): New variable.
630 (trackingNotification): New method (from Aquamacs).
631 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
632 from Aquamacs (Bug#7030).
633
634 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
635
636 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
637 (symbol_to_nsstring): Fix indentation.
638 (ns_symbol_to_pb): New function.
639 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
640 (Fns_rotate_cut_buffers_internal): Remove.
641 (Fns_store_selection_internal): Rename from
642 Fns_store_cut_buffer_internal.
643 (ns_get_foreign_selection, Fx_own_selection_internal)
644 (Fx_disown_selection_internal, Fx_selection_exists_p)
645 (Fns_get_selection_internal, Fns_store_selection_internal):
646 Use ns_symbol_to_pb and check if return value is nil.
647 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
648 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
649 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
650 renamed to Sns_store_selection_internal.
651 (ns_handle_selection_request): Move code to Fx_own_selection_internal
652 and remove this function.
653 (ns_handle_selection_clear): Remove, never used.
654 (Fx_own_selection_internal): Move code from ns_handle_selection_request
655 here.
656
657 2011-12-17 Ken Brown <kbrown@cornell.edu>
658
659 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
660 GID is unknown (Bug#10257).
661
662 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
663
664 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
665 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
666 which caused a build failure on GNU/Linux IA-64. This problem was
667 introduced by my 2011-10-07 patch.
668
669 2011-12-15 Juri Linkov <juri@jurta.org>
670
671 * image.c (imagemagick_error): New function. (Bug#10112)
672 (imagemagick_load_image): Comment out `MagickSetResolution' call.
673 Use `imagemagick_error' where ImageMagick functions return
674 `MagickFalse'.
675 (Fimagemagick_types): Add `Fnreverse' to return the list in the
676 proper order.
677
678 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
679
680 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
681 fill background (Bug#8992).
682
683 2011-12-13 Martin Rudalics <rudalics@gmx.at>
684
685 * window.c (Vwindow_combination_resize)
686 (Vwindow_combination_limit): Use t instead of non-nil in
687 doc-strings.
688 (Vrecenter_redisplay): Add first sentence of doc-string on
689 separate line.
690 (Frecenter): Fix doc-string typo.
691
692 2011-12-11 Kenichi Handa <handa@m17n.org>
693
694 * coding.c (Funencodable_char_position): Pay attention to the
695 buffer text relocation (Bug#9389).
696
697 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
698
699 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
700 gtk_init (Bug#10100).
701
702 2011-12-10 Eli Zaretskii <eliz@gnu.org>
703
704 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
705 IT->string is nil. (Bug#10263)
706
707 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
708
709 * nsterm.h (x_free_frame_resources): Declare.
710
711 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
712 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
713
714 * nsterm.h (ns_get_defaults_value): Declare.
715
716 * nsterm.m (ns_default): Call ns_get_defaults_value.
717
718 2011-12-09 Eli Zaretskii <eliz@gnu.org>
719
720 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
721 (Bug#10170)
722
723 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
724
725 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
726 that where the value of an _OBJC_* symbol points to is in the .bss
727 section (Bug#10240).
728
729 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
730
731 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
732 after the loop to call ccl_driver at least once (Bug#8619).
733
734 2011-12-08 Kenichi Handa <handa@m17n.org>
735
736 * ftfont.c (get_adstyle_property): Fix previous change
737 (Bug#10233).
738
739 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
740
741 * w32.c (init_environment): If no_site_lisp, remove site-lisp
742 dirs from the default value of EMACSLOADPATH (bug#10208).
743
744 2011-12-07 Glenn Morris <rgm@gnu.org>
745
746 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
747 installation and source directories as well. (Bug#10208)
748
749 2011-12-06 Chong Yidong <cyd@gnu.org>
750
751 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
752
753 2011-12-06 Glenn Morris <rgm@gnu.org>
754
755 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
756 as an error, not just -1. (Bug#10217)
757
758 2011-12-05 Chong Yidong <cyd@gnu.org>
759
760 * keyboard.c (process_special_events): New function.
761 (swallow_events, Finput_pending_p): Use it (Bug#10195).
762
763 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
764
765 * coding.c (encode_designation_at_bol): Don't use uninitialized
766 local variable (Bug#9318).
767
768 2011-12-05 Kenichi Handa <handa@m17n.org>
769
770 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
771 return Qnil (Bug#8046, Bug#10193).
772
773 2011-12-05 Kenichi Handa <handa@m17n.org>
774
775 * coding.c (encode_designation_at_bol): New args charbuf_end and
776 dst. Return the number of produced bytes. Callers changed.
777 (coding_set_source): Return how many bytes coding->source was
778 relocated.
779 (coding_set_destination): Return how many bytes
780 coding->destination was relocated.
781 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
782 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
783
784 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
785
786 * coding.c (CODING_CHAR_CHARSET_P): New macro.
787 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
788 macro (Bug#9318).
789
790 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
791
792 The following changes are to fix Bug#9318.
793
794 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
795 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
796 (encode_coding_iso_2022, encode_coding_sjis)
797 (encode_coding_big5, encode_coding_charset): Use the above macros.
798
799 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
800
801 * lisp.h (process_quit_flag): Fix external declaration.
802
803 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
804
805 Don't macro-inline non-performance-critical code.
806 * eval.c (process_quit_flag): New function.
807 * lisp.h (QUIT): Use it.
808
809 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
810
811 * nsfns.m (get_geometry_from_preferences): New function.
812 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
813
814 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
815
816 * emacs.c (Qkill_emacs): Define.
817 (syms_of_emacs): Initialize it.
818 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
819 Qquit_flag to `kill-emacs' instead.
820 (quit_throw_to_read_char): Add parameter `from_signal'.
821 All callers changed. Call Fkill_emacs if requested and safe.
822 * lisp.h (QUIT): Call Fkill_emacs if requested.
823
824 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
825
826 * widget.c (update_wm_hints): Return if wmshell is null.
827 (widget_update_wm_size_hints): New function.
828
829 * widget.h (widget_update_wm_size_hints): Declare.
830
831 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
832 widget_update_wm_size_hints (Bug#10104).
833
834 2011-12-03 Eli Zaretskii <eliz@gnu.org>
835
836 * xdisp.c (handle_invisible_prop): If the invisible text ends just
837 before a newline, prepare the bidi iterator for consuming the
838 newline, and keep the current paragraph direction. (Bug#10183)
839 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
840
841 2011-12-02 Juri Linkov <juri@jurta.org>
842
843 * search.c (Fword_search_regexp): New Lisp function created from
844 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
845 (Fword_search_backward, Fword_search_forward)
846 (Fword_search_backward_lax, Fword_search_forward_lax):
847 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
848 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
849
850 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
851
852 * fileio.c (Finsert_file_contents): Move after-change-function call
853 to before the "handled:" label, since all "goto handled" appear in
854 cases where the *-change-functions have already been properly called
855 (bug#10117).
856
857 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
858
859 * keyboard.c (interrupt_signal): Don't call kill-emacs when
860 waiting for input. (Bug#10169)
861
862 2011-11-30 Eli Zaretskii <eliz@gnu.org>
863
864 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
865 verifies glyph row's hash code--we have just reallocated the
866 glyphs, so their contents can be complete garbage. (Bug#10164)
867
868 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
869
870 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
871
872 2011-11-30 Eli Zaretskii <eliz@gnu.org>
873
874 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
875 attributes are tested _before_ calling verify_row_hash, to protect
876 against GCC re-ordering of the tests. (Bug#10164)
877
878 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
879
880 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
881
882 * xterm.c (handle_one_xevent): Only set async_visible and friends
883 if net_wm_state_hidden_seen is non-zero (Bug#10002)
884 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
885 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
886
887 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
888
889 Remove GCPRO-related macros that exist only to avoid shadowing locals.
890 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
891 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
892 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
893 All uses changed to use GCPRO1 etc.
894 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
895 Revert to old implementation (i.e., before 2011-03-11).
896
897 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
898
899 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
900 of scroll runs so as to avoid assigning disabled bogus rows and
901 unnecessary graphics copy operations.
902
903 2011-11-27 Eli Zaretskii <eliz@gnu.org>
904
905 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
906 (snprintf) [_MSC_VER]: Redirect to _snprintf.
907 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
908 (malloc, free, realloc, calloc): Redirect to e_* only when
909 compiling Emacs.
910
911 * lisp.h (GCTYPEBITS): Move before first use.
912 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
913 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
914 this macro definition.
915
916 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
917 _MSC_VER.
918
919 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
920
921 * gtkutil.c (xg_create_frame_widgets):
922 Call gtk_window_set_has_resize_grip (FALSE) if that function is
923 present with Gtk+ 2.0.
924
925 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
926
927 * fileio.c (Finsert_file_contents): Undo previous change; see
928 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
929
930 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
931
932 Rename locals to avoid shadowing.
933 * fileio.c (Finsert_file_contents):
934 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
935 * process.c (wait_reading_process_output):
936 Rename inner 'proc' to 'p' to avoid shadowing.
937 Indent for consistency with usual Emacs style.
938
939 2011-11-25 Eli Zaretskii <eliz@gnu.org>
940
941 * xdisp.c (redisplay_window): If cursor row is not fully visible
942 after recentering, and scroll-conservatively is set to a large
943 number, scroll window by a few more lines to make the cursor fully
944 visible and out of scroll-margin. (Bug#10105)
945 (start_display): Don't move to the next line if the display should
946 start at a newline that is part of a display vector or an overlay
947 string. (Bug#10119)
948
949 2011-11-24 Juri Linkov <juri@jurta.org>
950
951 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
952 after the `MagickPingImage' call. (Bug#10112)
953
954 2011-11-23 Chong Yidong <cyd@gnu.org>
955
956 * window.c (Fcoordinates_in_window_p): Accept only live windows.
957
958 2011-11-23 Martin Rudalics <rudalics@gmx.at>
959
960 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
961 making another buffer current. (Bug#10114)
962
963 2011-11-23 Glenn Morris <rgm@gnu.org>
964
965 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
966
967 2011-11-23 Chong Yidong <cyd@gnu.org>
968
969 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
970 using it (Bug#5984).
971
972 2011-11-22 Eli Zaretskii <eliz@gnu.org>
973
974 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
975 and header-lines, as they don't have one computed for them.
976 (Bug#10098)
977
978 * .gdbinit (prow): Make displayed values more self-explaining.
979 Add row's hash code.
980
981 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
982
983 * process.c (wait_reading_process_output): Fix asynchrounous
984 GnuTLS socket handling on some versions of the GnuTLS library.
985 (wait_reading_process_output): Add comment and URL.
986
987 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
988
989 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
990
991 2011-11-21 Chong Yidong <cyd@gnu.org>
992
993 * window.c (Fnext_window, Fprevious_window): Doc fix.
994
995 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
998
999 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1002
1003 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1004
1005 * window.c (Fset_window_combination_limit): Rename argument
1006 STATUS to LIMIT.
1007 (Vwindow_combination_limit): Remove "status" from doc-string.
1008
1009 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1010
1011 * m/ibms390.h: Remove.
1012 * m/ibms390x.h: Don't include "ibms390.h".
1013
1014 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1015
1016 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1017 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1018
1019 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1020
1021 * casetab.c (Fset_case_table):
1022 * charset.c (Fcharset_after): Fix typos.
1023
1024 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1027 Otherwise, valgrind does not work on some platforms.
1028 Problem reported by Andreas Schwab in
1029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1030 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1031 is set, removing the need for VIRT_ADDRESS_VARIES.
1032 (PURE_P): Use a more-efficient implementation that needs just one
1033 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1034 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1035 to 4 (xorl, subq, cmpq, setbe).
1036 * alloc.c (pure): Always extern now, since that's the
1037 VIRT_ADDR_VARIES behavior.
1038 (PURE_POINTER_P): Use a single comparison, not two, for
1039 consistency with the new puresize.h.
1040 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1041 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1042 Remove VIRT_ADDR_VARIES no longer needed.
1043
1044 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1047 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1048 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1049 behave as if the cursor position were at the window margin.
1050
1051 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1052 and the cursor position is out of bounds, behave as if the cursor
1053 position were at the window margin. (Bug#10075)
1054
1055 2011-11-18 Chong Yidong <cyd@gnu.org>
1056
1057 * window.c (Fwindow_combination_limit): Make first argument
1058 non-optional, since it is meaningless for live windows like the
1059 selected window.
1060
1061 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1064
1065 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1068 (graft_intervals_into_buffer): Simplify.
1069
1070 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1071
1072 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1073 hash values of the two rows.
1074 (copy_row_except_pointers): Preserve the used[] arrays and the
1075 hash values of the two rows. (Bug#10035)
1076 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1077
1078 * xdisp.c (row_hash): New function, body extracted from
1079 compute_line_metrics.
1080 (compute_line_metrics): Call row_hash, instead of computing the
1081 hash code inline.
1082
1083 * dispnew.c (verify_row_hash): Call row_hash for computing the
1084 hash code of a row, instead of duplicating code from xdisp.c.
1085
1086 * dispextern.h (row_hash): Add prototype.
1087
1088 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1089
1090 * frame.c (delete_frame): Don't delete the terminal when the last
1091 X frame is closed if emacs is built with GTK toolkit.
1092
1093 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1094
1095 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1096
1097 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1098
1099 * window.c (Vwindow_splits): Rename to
1100 Vwindow_combination_resize. Suggested by Juri Linkov.
1101 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1102 of Vwindow_splits.
1103
1104 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * nsfns.m (Fns_font_name):
1107 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1108
1109 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1110
1111 * window.h (window): Rename slot "nest" to "combination_limit".
1112 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1113 (Fset_window_nest): Rename to Fset_window_combination_limit.
1114 (Vwindow_nest): Rename to Vwindow_combination_limit.
1115 (recombine_windows, make_parent_window, make_window)
1116 (Fsplit_window_internal, saved_window)
1117 (Fset_window_configuration, save_window_save): Rename all
1118 occurrences of window_nest to window_combination_limit.
1119
1120 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1121
1122 * image.c (imagemagick_load_image): Fix typo.
1123
1124 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (display_line): Move the call to
1127 highlight_trailing_whitespace before the call to
1128 compute_line_metrics, since the latter needs to see the final
1129 faces of all the glyphs to compute ROW's hash value.
1130 Fixes assertion violations in row_equal_p. (Bug#10035)
1131
1132 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1133
1134 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1135 just return (bug#10044).
1136
1137 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1138
1139 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1140 with user-defined heap size. Bump the default size of the temacs
1141 heap to 27MB, to avoid memory warning when running temacs.
1142 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1143
1144 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1145 current_matrix and desired_matrix. (Bug#9990)
1146 (verify_row_hash) [XASSERTS]: New function.
1147 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1148 that the hash value of glyph rows is correct.
1149
1150 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1151
1152 * window.h (window): Remove splits slot.
1153 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1154 (Fdelete_other_windows_internal, make_parent_window)
1155 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1156 (Fset_window_configuration, save_window_save): Don't deal with
1157 split status of windows.
1158 (saved_window): Remove splits slot.
1159 (Vwindow_splits): Rewrite doc-string.
1160
1161 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1162
1163 * xfns.c (unwind_create_frame):
1164 * nsfns.m (unwind_create_frame):
1165 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1166 Vframe_list (Bug#9999).
1167
1168 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1169
1170 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1171
1172 2011-11-11 Kenichi Handa <handa@m17n.org>
1173
1174 * callproc.c (Fcall_process): Set the member dst_multibyte of
1175 process_coding.
1176
1177 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1178
1179 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1180 avoid a crash (bug#9496).
1181
1182 2011-11-09 Chong Yidong <cyd@gnu.org>
1183
1184 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1185 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1186
1187 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1190
1191 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 Avoid some portability problems by eschewing 'extern inline' functions.
1194 The trivial performance wins aren't worth the portability hassles; see
1195 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1196 et seq.
1197 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1198 (window_box_width, window_box_left, window_box_left_offset)
1199 (window_box_right, window_box_right_offset): Undo previous change,
1200 by removing the "extern"s.
1201 * intervals.c (adjust_intervals_for_insertion)
1202 (adjust_intervals_for_deletion): Undo previous change,
1203 making these static again.
1204 (offset_intervals, temp_set_point_both, temp_set_point)
1205 (copy_intervals_to_string): No longer inline.
1206 * xdisp.c (window_text_bottom_y, window_box_width)
1207 (window_box_height, window_box_left_offset)
1208 (window_box_right_offset, window_box_left, window_box_right)
1209 (window_box): No longer inline.
1210
1211 2011-11-08 Chong Yidong <cyd@gnu.org>
1212
1213 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1214 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1215 Signal an error if not a live window.
1216 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1217 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1218
1219 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1220
1221 * lisp.h (syms_of_abbrev): Remove declaration.
1222 Reported by CHENG Gao <chenggao@royau.me>.
1223
1224 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1225
1226 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1227 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1228 of temacs in GUI mode.
1229
1230 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1231
1232 * window.h: Declare delete_all_child_windows instead of
1233 delete_all_subwindows.
1234 * window.c (Fwindow_nest, Fset_window_nest)
1235 (Fset_window_new_total, Fset_window_new_normal)
1236 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1237 (delete_all_subwindows): Rename to delete_all_child_windows.
1238 (Fdelete_other_windows_internal, Fset_window_configuration):
1239 Call delete_all_child_windows instead of delete_all_subwindows.
1240 * frame.c (delete_frame): Call delete_all_child_windows instead
1241 of delete_all_subwindows.
1242
1243 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1246 This is also needed for porting to any host where GC_MARK_STACK is
1247 not GC_MAKE_GCPROS_NOOPS.
1248 (which_symbols): Use it.
1249
1250 2011-11-07 Kenichi Handa <handa@m17n.org>
1251
1252 * coding.c (coding_set_destination): Check coding->src_pos only
1253 when coding->src_object is a buffer (bug#9910).
1254
1255 * process.c (send_process): Set the member src_multibyte of coding
1256 to 0 (bug#9911) when sending a unibyte text.
1257
1258 * callproc.c (Fcall_process): Set the member src_multibyte of
1259 process_coding to 0 (bug#9912).
1260
1261 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1262
1263 * xmenu.c (cleanup_widget_value_tree): New function.
1264 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1265 calling free_menubar_widget_value_tree directly (Bug#9830).
1266
1267 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 Fix some portability problems with 'inline'.
1270 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1271 (window_box_width, window_box_left, window_box_left_offset)
1272 (window_box_right, window_box_right_offset): Declare extern.
1273 Otherwise, these inline functions do not conform to C99 and
1274 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1275 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1276 * intervals.c (adjust_intervals_for_insertion)
1277 (adjust_intervals_for_deletion): Now extern, because otherwise the
1278 extern inline functions 'offset_intervals' couldn't refer to it.
1279 (static_offset_intervals): Remove.
1280 (offset_intervals): Rewrite using the old contents of
1281 static_offset_intervals. The old version didn't conform to C99
1282 because an extern inline function contained a reference to an
1283 identifier with static linkage.
1284
1285 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1286
1287 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1288 GC.
1289
1290 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1291
1292 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1293 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1294 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1295 return Qleft_to_right.
1296
1297 2011-11-06 Chong Yidong <cyd@gnu.org>
1298
1299 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1300 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1301 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1302 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1303 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1304 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1305 (Fwindow_vscroll): Doc fix.
1306 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1307 argument, since it makes no sense to pass a live window and for
1308 consistency with window-child.
1309
1310 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1311
1312 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1313 support MSVC.
1314
1315 2011-11-05 Jason Rumney <jasonr@gnu.org>
1316
1317 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1318 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1319 fonts (Bug#6029).
1320 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1321 bitwise arithmetic preventing use of unicode-sip and non-truetype
1322 opentype fonts.
1323
1324 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1325
1326 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1327 "emacs"-only part.
1328
1329 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1330 initialization code to keep similarity to xfns.c after changes
1331 from 2011-11-05.
1332
1333 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1334
1335 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1336 (unwind_create_frame): New function (Bug#9943).
1337 (Fx_create_frame): Restructure code to be more similar to the one in
1338 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1339 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1340 Move terminal->reference_count++ just before making the frame official
1341 (Bug#9943).
1342
1343 * nsterm.m (x_free_frame_resources): New function.
1344 (x_destroy_window): Move code to x_free_frame_resources.
1345
1346 * xfns.c (unwind_create_frame): Fix comment.
1347 (Fx_create_frame, x_create_tip_frame):
1348 Move terminal->reference_count++ just before making the frame
1349 official. Move initialization of image_cache_refcount and
1350 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1351
1352 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1353
1354 Support MSVC build with newer versions of Visual Studio.
1355 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1356 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1357 nt/gmake.defs.
1358
1359 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1360 which are not supported by MSVC.
1361 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1362 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1363 bitfields.
1364 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1365 types in bitfields.
1366 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1367
1368 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1369
1370 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1371
1372 Support MSVC build with newer versions of Visual Studio.
1373 * w32.c: Don't include w32api.h for MSVC.
1374 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1375
1376 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1377 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1378 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1379 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1380 e_* cousins.
1381 (alloca) [_MSC_VER]: Define to _alloca.
1382
1383 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1384
1385 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1386
1387 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (note_mouse_highlight): If either of
1390 previous/next-single-property-change returns nil, treat that as
1391 the beginning or the end of the buffer. (Bug#9955)
1392
1393 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1394
1395 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1396 label is not null (Bug#9951).
1397 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1398 may be NULL.
1399
1400 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1401
1402 * window.c (Fwindow_body_size): Mention in the doc string that the
1403 return value is in frame's canonical units. (Bug#9949)
1404
1405 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1406
1407 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1408
1409 * w32fns.c (unwind_create_frame): If needed, free the glyph
1410 matrices of the partially constructed frame. (Bug#9943)
1411 * xfns.c (unwind_create_frame): Likewise.
1412
1413 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1416 Don't stop backward scan on the continuation glyph, even though
1417 its CHARPOS is positive.
1418 (mouse_face_from_buffer_pos, note_mouse_highlight):
1419 Rename cover_string to disp_string.
1420
1421 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1422
1423 * window.c (temp_output_buffer_show): Don't use
1424 Vtemp_buffer_show_specifiers.
1425 (Vtemp_buffer_show_specifiers): Remove unused variable.
1426
1427 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1428
1429 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1430 past the beginning of the current glyph matrix.
1431
1432 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1433
1434 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1435 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1436 HAVE_GTK3 (Bug#9869).
1437
1438 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1439 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1440
1441 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1442
1443 * xterm.c: Declare x_handle_net_wm_state to return int.
1444 (handle_one_xevent): Check if we are iconified but don't have
1445 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1446 (get_current_wm_state): Return non-zero if not hidden,
1447 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1448 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1449 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1450 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1451
1452 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1455 so that this new function doesn't get optimized away by a
1456 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1457
1458 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1459
1460 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1461
1462 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1463
1464 Fix the `xbytecode' command.
1465 * .gdbinit (xprintbytestr): New command.
1466 (xwhichsymbols): Rename from `which'; all callers changed.
1467 (xbytecode): Print the byte-code string as well.
1468
1469 2011-10-29 Kim Storm <storm@cua.dk>
1470
1471 * alloc.c (which_symbols): New function.
1472
1473 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1474
1475 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1476 line. (Bug#9903)
1477
1478 2011-10-29 Glenn Morris <rgm@gnu.org>
1479
1480 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1481 Not clear what it was for, and it causes various bugs. (Bug#9839)
1482
1483 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1486 possible random value that matches one of those tested as
1487 condition to clear the mouse face.
1488
1489 2011-10-28 Chong Yidong <cyd@gnu.org>
1490
1491 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1492
1493 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1494
1495 * window.c (make_window): Initialize phys_cursor_on_p.
1496
1497 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1498
1499 * lisp.h (struct Lisp_Symbol): Update comments.
1500
1501 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1504
1505 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1506
1507 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1508 <oslsachem@gmail.com> for helping to debug this.
1509
1510 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1511 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1512 (g_b_init_get_glyph_outline_w): New static variables.
1513 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1514 (GetGlyphOutlineW_Proc): New typedefs.
1515 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1516 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1517 New functions.
1518 (w32font_open_internal, compute_metrics):
1519 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1520 instead of calling the "wide" APIs directly.
1521
1522 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1523
1524 * w32.h (syms_of_w32font): Add prototype.
1525
1526 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1529 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1530 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1531 (Fmove_to_window_line): Doc fix.
1532
1533 2011-10-27 Chong Yidong <cyd@gnu.org>
1534
1535 * process.c (make_process): Set gnutls_state to NULL.
1536
1537 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1538 non-NULL, regardless of GNUTLS_INITSTAGE.
1539 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1540 an error. Set process slots as soon as we allocate them.
1541
1542 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1543
1544 2011-10-27 Chong Yidong <cyd@gnu.org>
1545
1546 * gnutls.c (emacs_gnutls_deinit): New function.
1547 Deallocate credentials structures as well as calling gnutls_deinit.
1548 (Fgnutls_deinit, Fgnutls_boot): Use it.
1549
1550 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1551 (deactivate_process): Call emacs_gnutls_deinit.
1552
1553 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * image.c (x_create_x_image_and_pixmap):
1556 * w32.c (sys_rename, w32_delayed_load):
1557 * w32font.c (fill_in_logfont):
1558 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1559
1560 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1561
1562 * w32fns.c (w32_default_color_map): New function,
1563 extracted from Fw32_default_color_map.
1564 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1565
1566 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1569
1570 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * keyboard.c (test_undefined): New function (bug#9751).
1573 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1574
1575 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1576
1577 * sysdep.c (init_sys_modes): Fix the check for the controlling
1578 terminal (Bug#6649).
1579
1580 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1581
1582 * dispextern.h (struct bidi_it): New member next_en_type.
1583
1584 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1585 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1586 current character, check also for next_en_type being WEAK_EN.
1587 (bidi_resolve_weak): Don't enter the expensive loop if the current
1588 position is before next_en_pos. Record the bidi type of the first
1589 non-ET, non-BN character we find, in addition to its position.
1590 (bidi_level_of_next_char): Invalidate next_en_type when
1591 next_en_pos is over-stepped.
1592
1593 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1596 * editfns.c: Rewrite current-time-zone so that it invokes
1597 the equivalent of (format-time-string "%Z") to get the time zone name.
1598 This fixes a bug when the time zone name contains characters that
1599 need converting from the system time locale to Emacs internal format.
1600 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1601 that patch fixed format-time-string to do the conversion, but
1602 I forgot to fix current-time-zone.
1603 (format_time_string): New function, containing most of
1604 what Fformat_time_string used to contain.
1605 (Fformat_time_string): Rewrite in terms of format_time_string.
1606 This doesn't change this function's behavior.
1607 (current-time-zone): Rewrite to use format_time_string.
1608 This fixes the bug reported by Michael Schierl in
1609 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1610 Jason Rumney's 2007-06-07 change worked around this bug, but
1611 didn't fix it.
1612 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1613
1614 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1615
1616 * xdisp.c (start_display): If the character at POS is displayed
1617 via a display vector, reset IT->current.dpvec_index to zero.
1618 (try_window_reusing_current_matrix): If a line ends in a display
1619 vector or the next line starts in a display vector, continue
1620 redrawing the window even though the character position of
1621 start_row was reached.
1622 (Bug#9771, part 2)
1623
1624 2011-10-18 Chong Yidong <cyd@gnu.org>
1625
1626 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1627 with nobreak-char-display too.
1628
1629 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1630
1631 Fix part 3 of bug#9771.
1632 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1633 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1634 non-neutral characters if the current character is a paragraph
1635 separator (a.k.a. Newline). This avoids running the same
1636 expensive loop twice, once when we consume the preceding newline
1637 and the other time when the line actually needs to be displayed.
1638 Avoid the loop when we see neutrals on the base embedding level
1639 following a character whose directionality is the same as the
1640 paragraph's. This avoids running the expensive loop when a line
1641 ends in a long sequence of neutrals, like control characters.
1642 Add assertion against STRONG_AL type. Slightly rearrange code
1643 that determines the type of a neutral given the first non-neutral
1644 that follows it.
1645 (bidi_level_of_next_char): Set next_en_pos to zero when
1646 invalidating its info.
1647
1648 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1649
1650 * xdisp.c (push_display_prop): Determine whether to record string
1651 or buffer position by IT->string, not by IT->method. Allow
1652 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1653 (move_it_vertically_backward): Don't look for character position
1654 immediately after the newline when in a continuation line.
1655 (Bug#9771, part 1)
1656
1657 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1658
1659 * window.c (coordinates_in_window): Rewrite and delabelize
1660 vertical border check. (Bug#5357) (Bug#9618)
1661
1662 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1663
1664 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1665 errors in XSetWindowBorder (bug#9310).
1666
1667 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1668
1669 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1670 avoid crash when xmalloc overrun checking is enabled.
1671
1672 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1675 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1676 cursor motion with <left> and <right> arrow keys.
1677
1678 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1679 some callers set that themselves.
1680
1681 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1684 display string and the previous row comes from the same string and
1685 is empty. (Bug#9739) (Bug#9738)
1686
1687 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1688
1689 * doc.c (get_doc_string): Encode file name (bug#9735).
1690
1691 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1692
1693 * bidi.c (bidi_level_of_next_char):
1694 * xdisp.c (get_visually_first_element): Remove old incorrect
1695 comments regarding the Unicode Line Separator character.
1696
1697 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1698
1699 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1700
1701 * alloc.c (Fgc_status): Do not access beyond zombies array
1702 boundary if nzombies > MAX_ZOMBIES.
1703 * alloc.c (dump_zombies): Add missing format specifier.
1704
1705 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1708 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1709
1710 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1711 Some packages use them to denote characters with modifiers.
1712
1713 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1716 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1717 matching a pp-number. Rename parameter var to var1.
1718
1719 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1720
1721 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1722
1723 2011-10-08 Glenn Morris <rgm@gnu.org>
1724
1725 * callint.c (Fcall_interactively): Give a more explicit error for the
1726 'c' case with a non-character input. (Bug#8479)
1727
1728 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1731 lines.
1732 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1733 lines that are hscrolled on the left.
1734
1735 * dispnew.c (buffer_posn_from_coords): Account for a possible
1736 presence of header-line. (Bug#4426)
1737
1738 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1739
1740 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1741 Don't advertise functionality which we discourage or doesn't work.
1742
1743 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1746 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1747 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1748 this makes Emacs dump core during garbage collection on rare
1749 occasions. sizeof is obviously inferior to offsetof here, so
1750 stick with offsetof.
1751 (GC_POINTER_ALIGNMENT): New macro.
1752 (mark_memory): Omit 3rd (offset) arg; caller changed.
1753 Don't assume EMACS_INT alignment is the same as pointer alignment.
1754
1755 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1756
1757 * keyboard.c (read_key_sequence_remapped): New var.
1758 (read_key_sequence): Compute remapping in the right buffer.
1759 (command_loop_1): Use read_key_sequence's remapping directly.
1760
1761 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1762
1763 * dired.c (file_name_completion): Don't expand file name.
1764 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1765 before checking file name handler.
1766
1767 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1768 they've been requested explicitly (bug#9591).
1769
1770 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * keymap.c (Fsingle_key_description): Use make_specified_string
1773 instead of build_string to build string from push_key_description.
1774 (Bug#5193)
1775
1776 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1779 This fixes a Y2038 bug on 64-bit hosts.
1780 * buffer.c (reset_buffer):
1781 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1782 (Fclear_buffer_auto_save_failure):
1783 Use 0, not -1, to represent an unset failure time, since time_t
1784 might not be signed.
1785
1786 Remove dependency on glibc malloc internals.
1787 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1788 Move back here from lisp.h, but with their new implementations.
1789 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1790 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1791 * charset.c (charset_table_init): New static var.
1792 (syms_of_charset): Use it instead of xmalloc. This removes a
1793 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1794 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1795 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1796 Move back to alloc.c.
1797 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1798 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1799
1800 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1801
1802 * nsterm.m (windowDidResize): Call x_set_window_size only when
1803 ns_in_resize is true. Otherwise set pixelwidth/height and
1804 call change_frame_size (Bug#9628).
1805
1806 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1807
1808 Port --enable-checking=all to Fedora 14 x86-64.
1809 * charset.c (syms_of_charset): Also account for glibc malloc's
1810 internal overhead when calculating the initial malloc maximum.
1811
1812 Port --enable-checking=all to Fedora 14 x86.
1813 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1814 Move to lisp.h.
1815 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1816 (overrun_check_realloc, overrun_check_free):
1817 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1818 That way, xmalloc returns a properly-aligned pointer even if
1819 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1820 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1821 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1822 into account when calculating the initial malloc maximum.
1823 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1824 Move here from alloc.c, so that charset.c can use it too.
1825 Properly align; the old code wasn't right for common 32-bit hosts
1826 when configured with --enable-checking=all.
1827 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1828 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1829
1830 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1831
1832 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1833 use EDOM.
1834
1835 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1836
1837 * xdisp.c (compute_display_string_end): If there's no display
1838 string at CHARPOS, return -1.
1839
1840 * bidi.c (bidi_fetch_char): When compute_display_string_end
1841 returns a negative value, treat the character as a normal
1842 character not covered by a display string. (Bug#9624)
1843
1844 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * lread.c (Fread_from_string): Fix typo in docstring.
1847
1848 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1849
1850 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1851 newline, reseat the iterator instead of bidi-iterating there one
1852 character at a time. (Bug#9610)
1853 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1854 TO_CHARPOS if the bidi iterator is at base embedding level.
1855
1856 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1857
1858 * lread.c (readevalloop): Use correct code for NBSP.
1859 (read1): Likewise. (Bug#9608)
1860
1861 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1862
1863 * dbusbind.c (Fdbus_register_signal): When service is not
1864 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1865
1866 2011-09-25 Glenn Morris <rgm@gnu.org>
1867
1868 * buffer.c (truncate-lines): Doc fix.
1869
1870 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1871
1872 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1873 (Fset_window_next_buffers): Doc fix.
1874
1875 2011-09-24 Glenn Morris <rgm@gnu.org>
1876
1877 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1878
1879 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 Fix minor problems found by static checking.
1882 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1883 * indent.c (Fvertical_motion): Fix == vs = typo.
1884
1885 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1886
1887 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1888 Default value is now t. Doc fix.
1889
1890 * indent.c (Fvertical_motion): Compute and apply the overshoot
1891 logic when moving up, not only when moving down. Fix the
1892 confusing name and values of the it_overshoot_expected variable;
1893 logic changes accordingly. (Bug#9254) (Bug#9549)
1894
1895 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1896 CHARPOS is covered by a display string which includes newlines.
1897 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1898 is covered by a display string with embedded newlines.
1899
1900 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1901
1902 * dbusbind.c (Fdbus_register_signal): Add match rule to
1903 Vdbus_registered_objects_table. (Bug#9581)
1904 (Fdbus_register_method, Vdbus_registered_objects_table):
1905 Fix docstring.
1906
1907 2011-09-24 Jim Meyering <meyering@redhat.com>
1908
1909 do not ignore write error for any output size
1910 The previous change was incomplete.
1911 While it makes emacs --batch detect the vast majority of stdout
1912 write failures, errors were still ignored whenever the output size is
1913 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1914 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1915 && echo FAIL: ignored write error
1916 FAIL: ignored write error
1917 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1918 && echo FAIL: ignored write error
1919 FAIL: ignored write error
1920 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1921
1922 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1923
1924 * emacs.c (Fkill_emacs): In noninteractive mode exit
1925 non-successfully if a write error occurred on stdout. (Bug#9574)
1926
1927 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1930 the xassert test.
1931
1932 * dispextern.h (struct it): Update the comment documenting what
1933 can it->OBJECT be.
1934
1935 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1936
1937 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1938 a display string, extend search for cursor position to end of row.
1939 (find_row_edges): If the row ends in a newline from a display
1940 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1941 Handle the case of a display string with multiple newlines.
1942 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1943 non-empty line. Fixes confusing cursor motion with arrow keys at
1944 the beginning of a line that starts with whitespace.
1945
1946 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1947
1948 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1949 (bug#9493).
1950
1951 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1954 boolean (Bug#9154).
1955
1956 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (display_line): Record maximum and minimum buffer
1959 positions even if no glyphs were produced (e.g., by a zero-width
1960 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1961 buffer positions that will be removed from the glyph row because
1962 they don't fit.
1963 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1964 column is beyond frame width: don't subtract 1 "pixel" when
1965 computing width of the stretch.
1966 (reseat_at_next_visible_line_start): Undo the change made on
1967 2011-09-17 that saved paragraph information and restored it after
1968 the call to `reseat'. (Bug#9545)
1969
1970 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1971
1972 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1973 and turn window cursor on if cleared (Bug#9415).
1974
1975 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1976
1977 * search.c (boyer_moore): Take unibyte characters from pattern
1978 literally. (Bug#9458)
1979
1980 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1983
1984 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 Fix minor problem found by static checking.
1987 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1988 initialized, to pacify gcc -Wuninitialized.
1989
1990 * fileio.c: Report proper errno when syscall falls.
1991 (Finsert_file_contents): Save and restore errno,
1992 so that report_file_error outputs the correct diagnostic.
1993 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1994
1995 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1996
1997 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1998
1999 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2002 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2003
2004 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2005
2006 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2007 about the current paragraph and restore it after the call to reseat.
2008
2009 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2010 (bidi_find_paragraph_start): Search back for paragraph beginning
2011 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2012 (bidi_move_to_visually_next): Only trigger paragraph-related
2013 computations when the last character is a newline or at EOB, not
2014 just any NEUTRAL_B. (Bug#9470)
2015
2016 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2017 truncated lines if point is covered by a display string. (Bug#9524)
2018
2019 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2020
2021 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2022 (cons_to_x_long): New function.
2023 (lisp_data_to_selection_data): Use it. Correct the test for
2024 short-versus-long data; it was negated. Break out of vector
2025 loop, for efficiency, when a long datum is discovered.
2026
2027 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2028
2029 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2030
2031 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2032
2033 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2034 GCC PR/17406) by declaring this function with external scope.
2035
2036 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2039 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2040
2041 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2042
2043 * editfns.c (Fformat): Correctly handle text properties on "%%".
2044
2045 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2046
2047 * xterm.c (x_draw_composite_glyph_string_foreground):
2048 * w32term.c (x_draw_composite_glyph_string_foreground):
2049 * term.c (encode_terminal_code):
2050 * composite.c (composition_update_it, get_composition_id):
2051 * xdisp.c (get_next_display_element)
2052 (fill_composite_glyph_string): Add comments about special meaning
2053 of TAB characters in a composition.
2054
2055 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2058 This occurs when processing a multibyte format.
2059 Problem reported by Wolfgang Jenker.
2060
2061 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2062
2063 * xdisp.c (try_cursor_movement): Only check for exact match if
2064 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2065
2066 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2067
2068 Remove unused external symbols.
2069 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2070 * xdisp.c (calc_pixel_width_or_height): Now static.
2071 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2072 * indent.c (check_display_width):
2073 * w32term.c: Fix comment to match code.
2074 * xterm.c, xterm.h (x_catching_errors): Remove.
2075
2076 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * xselect.c: Use signed conversions more consistently (Bug#9498).
2079 (selection_data_to_lisp_data): Assume incoming selection data are
2080 signed integers, not unsigned. This is to be consistent with
2081 outgoing selection data, which was modified to use signed integers
2082 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2083 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2084 expects long, not unsigned long.
2085
2086 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2089 computation of loop end. Reported by Johan Bockgård
2090 <bojohan@gnu.org>.
2091
2092 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2093
2094 * frame.c (Fother_visible_frames_p): Function deleted.
2095
2096 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2097
2098 * indent.c (compute_motion): Process display vector front to back
2099 rather than the other way around. (Bug#2496)
2100
2101 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2102
2103 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2104
2105 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2106
2107 * minibuf.c (Fread_from_minibuffer): Doc fix.
2108
2109 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2112 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2113
2114 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2115
2116 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2117 value for non-existent files.
2118
2119 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2120
2121 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2122 set its "size" to -1. This will set the modtime_size field of
2123 the corresponding buffer to -1, which is what
2124 verify-visited-file-modtime expects for files that do not exist.
2125 (Bug#9139)
2126
2127 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2128
2129 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2130 here ...
2131 * lisp.h: ... from here. push_key_description is no longer
2132 defined in keyboard.c, so its declaration should not be in
2133 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2134 logically belongs with push_key_description.
2135
2136 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * buffer.h: Include <sys/types.h> instead of <time.h>.
2139 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2140 Problem reported by Herbert J. Skuhra.
2141
2142 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2143
2144 * xml.c (parse_region): Make the parsing work for
2145 non-comment-starting XML files again (bug#9144).
2146
2147 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2148
2149 * image.c (gif_load): Fix calculation of bottom and right corner.
2150 (Bug#9468)
2151
2152 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2155 redisplay in small windows.
2156
2157 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2158
2159 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2160
2161 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2162
2163 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2164 Operate on live windows only.
2165
2166 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2169
2170 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2173 only under bidi iteration.
2174
2175 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2178
2179 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2182 Without this fix, the command to link temacs failed due to an
2183 undefined symbol __builtin_isnan. This is because
2184 /usr/include/iso/math_c99.h #defines isnan(x) to
2185 __builtin_isnan(x), but the bundled gcc, which identifies itself
2186 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2187 a __builtin_isnan.
2188 * floatfns.c (isnan): #undef, and then #define to a clone of
2189 what's in data.c.
2190 (Fisnan): Always define, since it's always available now.
2191 (syms_of_floatfns): Always define isnan at the Lisp level.
2192
2193 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2196
2197 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2200 The previous code assumed that file offsets (off_t values) fit in
2201 EMACS_INT variables, which is not true on typical 32-bit hosts.
2202 The code messed up by falsely reporting buffer overflow in cases
2203 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2204 when "big" contains more than 2**29 bytes, even though this
2205 inserts just one byte and does not overflow the buffer.
2206 (Finsert_file_contents): Store file offsets as off_t
2207 values, not as EMACS_INT values. Check for overflow when
2208 converting between EMACS_INT and off_t. When checking for
2209 buffer overflow or for overlap, take the offsets into account.
2210 Don't use EMACS_INT for small values where int suffices.
2211 When checking for overlap, fix a typo: ZV was used where
2212 ZV_BYTE was intended.
2213 (Fwrite_region): Don't assume off_t fits into 'long'.
2214 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2215
2216 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2217
2218 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2219
2220 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2221
2222 sprintf-related integer and memory overflow issues (Bug#9412).
2223
2224 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2225 (esprintf, exprintf, evxprintf): New functions.
2226 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2227 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2228 (modify_event_symbol): Do not assume that the length of
2229 name_alist_or_stem is safe to alloca and fits in int.
2230 (Fexecute_extended_command): Likewise for function name and binding.
2231 (Frecursion_depth): Wrap around reliably on integer overflow.
2232 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2233 since some callers pass EMACS_INT values.
2234 (Fsingle_key_description): Don't crash if symbol name contains more
2235 than MAX_ALLOCA bytes.
2236 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2237 (get_minibuffer): Arg is now EMACS_INT, not int.
2238 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2239 (esprintf, exprintf, evxprintf): New decls.
2240 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2241
2242 * dbusbind.c (signature_cat): New function.
2243 (xd_signature, Fdbus_register_signal):
2244 Do not overrun buffer; instead, report string overflow.
2245
2246 * dispnew.c (add_window_display_history): Don't overrun buffer.
2247 Truncate instead; this is OK since it's just a log.
2248
2249 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2250 even if the time zone offset is outlandishly large.
2251 Don't mishandle offset == INT_MIN.
2252
2253 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2254 when creating daemon; the previous buffer-overflow check was incorrect.
2255
2256 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2257 which has the guts of the old verror function.
2258
2259 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2260 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2261
2262 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2263 (font_unparse_xlfd): Don't blindly alloca long strings.
2264 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2265 fits in int, when using sprintf. Use single snprintf to count
2266 length of string rather than counting it via multiple sprintfs;
2267 that's simpler and more reliable.
2268 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2269 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2270 sprintf, in case result does not fit in int.
2271
2272 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2273 (fontset_from_font): Print it.
2274
2275 * frame.c (tty_frame_count): Now printmax_t, not int.
2276 (make_terminal_frame, set_term_frame_name): Print it.
2277 (x_report_frame_params): In X, window IDs are unsigned long,
2278 not signed long, so print them as unsigned.
2279 (validate_x_resource_name): Check for implausibly long names,
2280 and don't assume name length fits in 'int'.
2281 (x_get_resource_string): Don't blindly alloca invocation name;
2282 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2283 not fit in int.
2284
2285 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2286 (xg_check_special_colors, xg_set_geometry):
2287 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2288
2289 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2290 Use esprintf, not sprintf, in case result does not fit in int.
2291
2292 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2293 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2294 it as a large positive number.
2295 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2296 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2297
2298 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2299 in case result does not fit in int.
2300
2301 * print.c (float_to_string): Detect width overflow more reliably.
2302 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2303 buffer overrun. Don't assume list length fits in 'int'. Treat
2304 print length of 0 as 0, not as infinity; to be consistent with other
2305 uses of print length in this function. Don't overflow print length
2306 index. Don't assume hash table size fits in 'long', or that
2307 vectorlike size fits in 'unsigned long'.
2308
2309 * process.c (make_process): Use printmax_t, not int, to format
2310 process-name gensyms.
2311
2312 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2313
2314 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2315 to avoid potential buffer overrun.
2316
2317 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2318 if X resource line is longer than 512 bytes.
2319
2320 * xfns.c (x_window): Make sprintf buffer a bit bigger
2321 to avoid potential buffer overrun.
2322
2323 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2324
2325 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2326
2327 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Integer overflow fixes for scrolling, etc.
2330 Without these, Emacs silently mishandles large integers sometimes.
2331 For example, "C-u 4294967297 M-x recenter" was treated as if
2332 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2333
2334 * xdisp.c (try_window_id): Check Emacs fixnum range before
2335 converting to 'int'.
2336
2337 * window.c (window_scroll_line_based, Frecenter):
2338 Check that an Emacs fixnum is in range before assigning it to 'int'.
2339 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2340 values converted from Emacs fixnums.
2341 (Frecenter): Don't wrap around a line count if it is out of 'int'
2342 range; instead, treat it as an extreme value.
2343 (Fset_window_configuration, compare_window_configurations):
2344 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2345
2346 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2347 that can exceed INT_MAX. Check that EMACS_INT value is in range
2348 before assigning it to the (possibly-narrower) index.
2349 (match_limit): Don't assume that a fixnum can fit in 'int'.
2350
2351 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2352 exceed INT_MAX.
2353
2354 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2355 (Fvertical_motion): Don't wrap around LINES values that don't fit
2356 in 'int'. Instead, treat them as extreme values. This is good
2357 enough for windows, which can't have more than INT_MAX lines anyway.
2358
2359 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2360
2361 * Require libxml/parser.h to avoid compilation warning.
2362
2363 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2364
2365 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2366 since this reportedly can destroy thread storage.
2367
2368 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2369
2370 * syntax.c (find_defun_start): Update all cache variables if
2371 exiting early (Bug#9401).
2372
2373 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2374
2375 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2376
2377 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2378 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2379 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2380
2381 * term.c (tty_append_glyph): New function.
2382 (produce_stretch_glyph): Static function and its prototype deleted.
2383
2384 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2385 Add prototypes.
2386
2387 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2390 when checking :margin (Bug#9390).
2391 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2392 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2393 so that the name doesn't mislead. All uses changed.
2394
2395 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2396
2397 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2398 set_tty_hooks.
2399
2400 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2401
2402 * xdisp.c (move_it_to): Don't bail out early when reaching
2403 position beyond to_charpos, if we are scanning backwards.
2404 (move_it_vertically_backward): When DY == 0, make sure we get to
2405 the first character in the line after the newline.
2406
2407 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2410 (ccl_driver): Do not generate an out-of-range pointer.
2411 (Fccl_execute_on_string): Remove unnecessary check for
2412 integer overflow, noted by Stefan Monnier in
2413 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2414 Remove a FIXME that didn't need fixing.
2415 Simplify the newly-introduced buffer reallocation code.
2416
2417 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2418
2419 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2420
2421 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Integer and memory overflow issues (Bug#9196).
2424
2425 * doc.c (get_doc_string): Rework so that
2426 get_doc_string_buffer_size is the actual buffer size, rather than
2427 being 1 less than the actual buffer size; this makes xpalloc more
2428 convenient.
2429
2430 * image.c (x_allocate_bitmap_record, cache_image):
2431 * xselect.c (Fx_register_dnd_atom):
2432 Simplify previous changes by using xpalloc.
2433
2434 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2435 since either will do and ptrdiff_t is convenient with xpalloc.
2436
2437 * charset.c (charset_table_size)
2438 (struct charset_sort_data.priority): Now ptrdiff_t.
2439 (charset_compare): Don't overflow if priorities differ greatly.
2440 (Fsort_charsets): Don't assume list length fits in int.
2441 Check for size-calculation overflow when allocating sort data.
2442 (syms_of_charset): Allocate an initial charset table that is
2443 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2444
2445 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2446
2447 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2448 The actual value is always <= INT_MAX, and leaving it unsigned made
2449 overflow checking harder.
2450
2451 * dispextern.h (struct glyph_matrix.rows_allocated)
2452 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2453 with xpalloc. The values are still always <= INT_MAX.
2454
2455 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2456
2457 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2458 (SAFE_NALLOCA): New macro.
2459
2460 * region-cache.c (struct boundary.pos, find_cache_boundary)
2461 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2462 (set_cache_region, invalidate_region_cache)
2463 (revalidate_region_cache, know_region_cache, region_cache_forward)
2464 (region_cache_backward, pp_cache):
2465 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2466 so that ptrdiff_t * can be passed to xpalloc.
2467 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2468 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2469 (pp_cache): Don't assume cache_len fits in int.
2470 * region-cache.h: Adjust extern decls to match.
2471
2472 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2473 EMACS_INT, since either will do, for xpalloc.
2474
2475 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2476 (xnmalloc, xnrealloc, xpalloc): New functions.
2477
2478 * bidi.c (bidi_shelve_header_size): New constant.
2479 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2480 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2481
2482 * bidi.c (bidi_cache_shrink):
2483 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2484 (overlay_strings):
2485 Don't update size of array until after memory allocation succeeds,
2486 because xmalloc/xrealloc may not return.
2487 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2488 now that we have proper integer overflow checking.
2489 (record_overlay_string, overlay_strings): Catch overflows when
2490 calculating size of overlay_str_buf.
2491
2492 * callproc.c (Fcall_process): Check for size overflow when
2493 calculating size of args2.
2494 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2495 Normally we prefer signed values, but sticking with ptrdiff_t would
2496 require adding more-complicated checks.
2497
2498 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2499 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2500 Redo buffer-overflow calculations to avoid integer overflow.
2501 Add a FIXME comment where memory seems to be over-allocated.
2502
2503 * character.c (Fstring): Check for size-calculation overflow.
2504
2505 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2506 unnecessary integer overflow. Check for size overflow.
2507 (encode_coding_object): Don't update size until xmalloc succeeds.
2508
2509 * composite.c (get_composition_id): Check for overflow in glyph
2510 length calculations.
2511
2512 Integer and memory overflow fixes for display code.
2513 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2514 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2515 (scrolling_window): Check for overflow in size calculations.
2516 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2517 Don't assume glyph table len fits in int.
2518 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2519 (row_table_size): Now ptrdiff_t, not int.
2520 (scrolling_window): Avoid overflow in size calculations.
2521 Don't update size until allocation succeeds.
2522 * fns.c (concat): Check for overflow in size calculations.
2523 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2524 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2525 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2526
2527 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2528 (get_doc_string): Check for size calculation overflow.
2529 Don't update size until allocation succeeds.
2530 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2531 EMACS_INT, where ptrdiff_t will do.
2532 (Fsubstitute_command_keys): Check for string overflow.
2533
2534 * editfns.c (set_time_zone_rule): Don't assume environment length
2535 fits in int.
2536 (message_length): Now ptrdiff_t, not int.
2537 (Fmessage_box): Don't update size until allocation succeeds.
2538 Don't assume message length fits in int.
2539 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2540
2541 * emacs.c (main): Do not reallocate argv, since there is a null at
2542 the end that can be overwritten, and this way there's no need to
2543 worry about size-calculation overflow.
2544 (sort_args): Check for size-calculation overflow.
2545
2546 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2547 alloc succeeds.
2548 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2549
2550 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2551 (x_set_scroll_bar_width, x_figure_window_size):
2552 Check for integer overflow.
2553 (x_set_alpha): Do not assume XINT fits in int.
2554
2555 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2556 This is for the members text_lines, text_cols, total_lines, total_cols,
2557 where the system imposes an 'int' limit.
2558
2559 * fringe.c (Fdefine_fringe_bitmap):
2560 Don't update size until alloc works.
2561
2562 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2563 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2564
2565 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2566 Check for size-calculation overflow.
2567 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2568 do, as we prefer signed integers.
2569 (id_to_widget.max_size, id_to_widget.used)
2570 (xg_store_widget_in_map, xg_remove_widget_from_map)
2571 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2572 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2573 Use and return ptrdiff_t, not int.
2574 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2575 * gtkutil.h: Change prototypes to match the above.
2576
2577 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2578 are duplicate now that they've been promoted to lisp.h.
2579 (x_allocate_bitmap_record, x_alloc_image_color)
2580 (make_image_cache, cache_image, xpm_load):
2581 Don't update size until alloc is done.
2582 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2583 (x_detect_edges):
2584 Check for size calculation overflow.
2585 (ct_colors_allocated_max): New constant.
2586 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2587 overflow.
2588
2589 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2590 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2591 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2592 Use ptrdiff_t, not int, to count maps.
2593 (read_char_minibuf_menu_prompt): Check for overflow in size
2594 calculations. Don't update size until allocation succeeds.
2595 Redo calculations to avoid overflow.
2596 * keyboard.h: Change prototypes to match the above.
2597
2598 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2599 to count maps.
2600 (current_minor_maps): Check for size calculation overflow.
2601 * keymap.h: Change prototypes to match the above.
2602
2603 * lread.c (read1, init_obarray): Don't update size until alloc done.
2604
2605 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2606 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2607
2608 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2609 Now ptrdiff_t, not int.
2610 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2611 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2612
2613 * process.c (Fnetwork_interface_list): Check for overflow
2614 in size calculation.
2615
2616 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2617
2618 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2619 overflow. Don't bother calling xmalloc when xrealloc will do.
2620
2621 * search.c (Freplace_match): Check for size calculation overflow.
2622 (Fset_match_data): Don't assume list lengths fit in 'int'.
2623
2624 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2625 for command line length. Do not attempt to address one before the
2626 beginning of an array, as that's not portable.
2627
2628 * term.c (max_frame_lines): Remove; unused.
2629 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2630 not int.
2631 (encode_terminal_code, calculate_costs): Check for size
2632 calculation overflow.
2633 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2634 table lengths and related sizes. Don't update size until alloc
2635 done. Redo calculations to avoid overflow.
2636 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2637
2638 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2639 subtracting pointers.
2640 (gobble_line): Check for overflow more carefully. Don't update size
2641 until alloc done.
2642
2643 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2644 Don't update size until alloc done.
2645 Redo size calculations to avoid overflow.
2646 Check for size calculation overflow.
2647 (main) [DEBUG]: Fix typo in invoking tparam1.
2648
2649 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2650 Use ptrdiff_t, not int, for sizes.
2651 (store_mode_line_noprop_char): Don't update size until alloc done.
2652
2653 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2654 Use ptrdiff_t, not int, for sizes.
2655 (Finternal_make_lisp_face, cache_face):
2656 Check for size calculation overflow.
2657 (cache_face): Treat size calculation overflows as if they were
2658 memory exhaustion (the usual treatment), rather than aborting.
2659
2660 * xfns.c (x_encode_text, x_set_name_internal)
2661 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2662 sizes, since they can exceed INT_MAX in size. Check for size
2663 calculation overflow.
2664
2665 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2666 (xg_select): Check for size calculation overflow.
2667 Don't update size until alloc done.
2668
2669 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2670 as sprintf is limited to int lengths.
2671
2672 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2673 (X_LONG_MIN): New macros.
2674 Use them to make the following changes clearer.
2675 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2676 This change doesn't affect the value now, but it may help remind
2677 future maintainers not to raise the value too much later.
2678 (SELECTION_QUANTUM): Remove, replacing with ...
2679 (selection_quantum): ... new function, which avoids overflow.
2680 All uses changed.
2681 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2682 assumption that selection length fits in 'int'.
2683 (x_reply_selection_request, x_handle_selection_request)
2684 (x_get_window_property, receive_incremental_selection)
2685 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2686 (lisp_data_to_selection_data, clean_local_selection_data):
2687 Use ptrdiff_t, not int, to record length of selection.
2688 (x_reply_selection_request, x_get_window_property)
2689 (receive_incremental_selection, x_property_data_to_lisp):
2690 Redo calculations to avoid overflow.
2691 (x_reply_selection_request): When sending hint, ceiling it at
2692 X_LONG_MAX rather than relying on wraparound overflow to send
2693 something.
2694 (x_get_window_property, receive_incremental_selection)
2695 (lisp_data_to_selection_data, x_property_data_to_lisp):
2696 Check for size-calculation overflow.
2697 (x_get_window_property, receive_incremental_selection)
2698 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2699 Don't store size until memory allocation succeeds.
2700 (x_get_window_property): Plug memory leak on memory exhaustion.
2701 Don't double-block input; malloc is safe here. Don't assume 2**34
2702 - 4 fits in unsigned long. Add an xassert to check
2703 XGetWindowProperty overflow. Be more careful about overflow
2704 calculations, and distinguish size from memory overflow better.
2705 (receive_incremental_selection): When tracing, don't assume
2706 unsigned int is less than INT_MAX.
2707 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2708 harmful) conversions of unsigned short to int.
2709 (lisp_data_to_selection_data): Don't assume that integers
2710 in the range -65535 through -1 fit in an X unsigned short.
2711 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2712 result parameters unless successful. Rely on cons_to_unsigned
2713 to report problems with elements; the old code wasn't right anyway.
2714 (x_check_property_data): Check for int overflow; we cannot use
2715 a wider type due to X limits.
2716 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2717
2718 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2719
2720 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2721 (x_term_init): Check for size calculation overflow.
2722 (x_color_cells): Don't store size until memory allocation succeeds.
2723 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2724 Don't assume alloca size is less than MAX_ALLOCA.
2725 (x_term_init): Don't assume length fits in int (sprintf is limited
2726 to int size).
2727
2728 Use ptrdiff_t for composition IDs.
2729 * character.c (lisp_string_width):
2730 * composite.c (composition_table_size, n_compositions)
2731 (get_composition_id, composition_gstring_from_id):
2732 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2733 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2734 * window.c (Frecenter):
2735 Use ptrdiff_t, not int, for composition IDs.
2736 * composite.c (get_composition_id): Check for integer overflow.
2737 * composite.h: Adjust prototypes to match the above changes.
2738
2739 Use ptrdiff_t for hash table indexes.
2740 * category.c (hash_get_category_set):
2741 * ccl.c (ccl_driver):
2742 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2743 * coding.c (coding_system_charset_list, detect_coding_system):
2744 * coding.h (struct coding_system.id):
2745 * composite.c (get_composition_id, gstring_lookup_cache):
2746 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2747 * image.c (xpm_get_color_table_h):
2748 * lisp.h (hash_lookup, hash_put):
2749 * minibuf.c (Ftest_completion):
2750 Use ptrdiff_t for hash table indexes, not int (which is too
2751 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2752 32-bit --with-wide-int hosts).
2753
2754 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2755 Add a FIXME comment about memory leaks.
2756 (syms_of_charset): Don't assume xmalloc returns.
2757
2758 Don't assume that stated character widths fit in int.
2759 * character.c (Fchar_width, c_string_width, lisp_string_width):
2760 * character.h (CHAR_WIDTH):
2761 * indent.c (MULTIBYTE_BYTES_WIDTH):
2762 Use sanitize_char_width to avoid undefined and/or bad behavior
2763 with outlandish widths.
2764 * character.h (sanitize_tab_width): Rename from sanitize_width,
2765 now that we have two such functions. All uses changed.
2766 (sanitize_char_width): New inline function.
2767
2768 Don't assume that tab-width fits in int.
2769 * character.h (sanitize_width): New inline function.
2770 (SANE_TAB_WIDTH): New macro.
2771 (ASCII_CHAR_WIDTH): Use it.
2772 * indent.c (sane_tab_width): Remove. All uses replaced by
2773 SANE_TAB_WIDTH (current_buffer).
2774 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2775
2776 * fileio.c: Integer overflow issues with file modes.
2777 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2778
2779 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2780 Remove unreachable code.
2781 (read_hex, load_charset_map_from_file): Check for integer overflow.
2782
2783 * xterm.c: Don't go over XClientMessageEvent limit.
2784 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2785 (x_send_scroll_bar_event): Likewise. Check that the size does not
2786 exceed limits imposed by XClientMessageEvent, as well as the usual
2787 ptrdiff_t and size_t limits.
2788
2789 * keyboard.c: Overflow, signedness and related fixes.
2790 (make_lispy_movement): Use same integer type in forward decl
2791 that is used in the definition.
2792 (read_key_sequence, keyremap_step):
2793 Change bufsize argument back to int, undoing my 2011-03-30 change.
2794 We prefer signed types, and int is wide enough here.
2795 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2796 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2797 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2798 length, not size_t. Use ptrdiff_t for index, not int.
2799 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2800 possibility of integer overflow.
2801
2802 Overflow, signedness and related fixes for images.
2803
2804 * dispextern.h (struct it.stack[0].u.image.image_id)
2805 (struct_it.image_id, struct image.id, struct image_cache.size)
2806 (struct image_cache.used, struct image_cache.ref_count):
2807 * gtkutil.c (update_frame_tool_bar):
2808 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2809 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2810 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2811 * nsmenu.m (update_frame_tool_bar):
2812 * xdisp.c (calc_pixel_width_or_height):
2813 * xfns.c (image_cache_refcount):
2814 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2815 on typical 64-bit hosts.
2816
2817 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2818 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2819 Omit unnecessary casts to int.
2820 (parse_image_spec): Check that integers fall into 'int' range
2821 when the callers expect that.
2822 (image_ascent): Redo ascent calculation to avoid int overflow.
2823 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2824 (lookup_image): Remove unnecessary tests.
2825 (xbm_image_p): Locals are now of int, not EMACS_INT,
2826 since parse_image_check makes sure they fit into int.
2827 (png_load, gif_load, svg_load_image):
2828 Prefer int to unsigned where either will do.
2829 (tiff_handler): New function, combining the cores of the
2830 old tiff_error_handler and tiff_warning_handler.
2831 This function is rewritten to use vsnprintf and thereby avoid
2832 stack buffer overflows. It uses only the features of vsnprintf
2833 that are common to both POSIX and native Microsoft.
2834 (tiff_error_handler, tiff_warning_handler): Use it.
2835 (tiff_load, gif_load, imagemagick_load_image):
2836 Don't assume :index value fits in 'int'.
2837 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2838 (imagemagick_load_image): Check that crop parameters fit into
2839 the integer types that MagickCropImage accepts. Don't assume
2840 Vimagemagick_render_type has a nonnegative value. Don't assume
2841 size_t fits in 'long'.
2842 (gs_load): Use printmax_t to print the widest integers possible.
2843 Check for integer overflow when computing image height and width.
2844
2845 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (redisplay_window): Don't force window start if point
2848 will be invisible in the resulting window. (Bug#9324)
2849
2850 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2851
2852 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2853 the display spec is of the form `(space ...)'.
2854 (handle_display_spec): Return the value returned by
2855 handle_single_display_spec, not just 1 or zero.
2856 (handle_single_display_spec): If the display spec is of the form
2857 `(space ...)', and specifies display in the text area, return 2
2858 rather than 1.
2859 (try_cursor_movement): Check for the need to scroll more
2860 accurately, and prefer exact match for point under bidi.
2861 Don't advance `row' beyond the last row of the window.
2862
2863 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2864 into disp_prop; all users changed.
2865
2866 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2867 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2868 for the text covered by the display property.
2869
2870 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2871
2872 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2873 Change return value to nil.
2874 (Frecord_buffer): Delete unused function.
2875
2876 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2877
2878 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2879 buffers, return left-to-right.
2880 (set_cursor_from_row): Consider candidate row a win if its glyph
2881 represents a newline and point is on that newline. Fixes cursor
2882 positioning on the newline at EOL of R2L text within L2R
2883 paragraph, and vice versa.
2884 (try_cursor_movement): Check continued rows, in addition to
2885 continuation rows. Fixes unwarranted scroll when point enters a
2886 continued line of R2L text within an L2R paragraph, or vice versa.
2887 (cursor_row_p): Consider the case of point being equal to
2888 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2889 from the end of a short line to the beginning of a continued line
2890 of R2L text within L2R paragraph.
2891 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2892 composed characters.
2893
2894 * bidi.c (bidi_check_type): Use xassert.
2895 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2896 members.
2897
2898 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2899
2900 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2901 a character.
2902
2903 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * nsfont.m (ns_otf_to_script): Fix typo.
2906
2907 2011-08-22 Kenichi Handa <handa@m17n.org>
2908
2909 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2910 extra slot even if the purpose is char-code-property-table.
2911
2912 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2913
2914 * xdisp.c (redisplay_window): When computing centering_position,
2915 account for the height of the header line. (Bug#8874)
2916
2917 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2918 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2919 candidate is selected by the mouse, and that candidate has a
2920 composed character under the mouse.
2921
2922 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2923 coordinates reported by pos-visible-in-window-p for a composed
2924 character in column zero.
2925
2926 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2927
2928 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2929
2930 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2933 consider it a hit if to_charpos is anywhere in the range of the
2934 composed buffer positions.
2935
2936 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2937
2938 * image.c (gif_load): Don't assume that each subimage has the same
2939 dimensions as the base image. Handle disposal method that is
2940 "undefined" by the gif spec (Bug#9335).
2941
2942 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2943
2944 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2945 (Fcondition_case): Document `debug' symbol in error handler.
2946
2947 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2948
2949 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2950 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2951 from an Org mode buffer to a Speedbar frame.
2952
2953 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2954 a composition, take its buffer position from IT->cmp_it.charpos.
2955 Fixes cursor positioning at the beginning of a line that begins
2956 with a composed character.
2957
2958 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2959
2960 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2961 character bidirectional type, use STRONG_L instead. Fixes crashes
2962 in a buffer produced by `describe-categories'.
2963
2964 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2965 members before the level stack, so they would be saved and
2966 restored when copying iterator state. Fixes incorrect reordering
2967 around TABs covered by display properties.
2968
2969 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2970
2971 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2972
2973 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2974
2975 * eval.c (internal_condition_case, internal_condition_case_1)
2976 (internal_condition_case_2, internal_condition_case_n):
2977 Remove unnecessary aborts (Bug#9081).
2978
2979 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2980
2981 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2982 has no `load' handler, try opening the file locally. (Bug#9311)
2983
2984 2011-08-16 Ken Brown <kbrown@cornell.edu>
2985
2986 * gmalloc.c: Expand comment.
2987
2988 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2989
2990 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2991 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2992
2993 2011-08-16 Ken Brown <kbrown@cornell.edu>
2994
2995 Fix memory allocation problems in Cygwin build (Bug#9273).
2996
2997 * unexcw.c ( __malloc_initialized): Declare external variable.
2998 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2999
3000 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3001 New variables.
3002 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3003 dumped emacs.
3004 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3005 in the static heap.
3006 [CYGWIN] (special_realloc): New function.
3007 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3008 requests to realloc storage in the static heap.
3009
3010 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3011
3012 * bidi.c (bidi_initialize): Remove unused local.
3013
3014 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3015
3016 * bidimirror.h:
3017 * biditype.h: Remove file.
3018 * makefile.w32-in ($(BLD)/bidi.$(O)):
3019 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3020
3021 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3022
3023 * chartab.c: Improve commentary for the uniprop_table API.
3024
3025 * bidi.c (bidi_paragraph_init): Support zero value of
3026 bidi_ignore_explicit_marks_for_paragraph_level.
3027 (bidi_initialize): Use uniprop_table instead of including
3028 biditype.h and bidimirror.h.
3029
3030 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3031 coordinates of the iterator when restoring from ppos_it.
3032 (Bug#9296)
3033
3034 2011-08-14 Kenichi Handa <handa@m17n.org>
3035
3036 * process.c (create_process): Call setup_process_coding_systems
3037 after the pid of the process is set to -1 (Bug#8162).
3038
3039 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3040
3041 * xdisp.c (move_it_in_display_line_to): Don't invoke
3042 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3043 ppos_it. Fixes vertical cursor motion when line beginning is
3044 covered by an image. (Bug#9296)
3045
3046 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3047
3048 * nsterm.h (ns_run_ascript): Declare.
3049 (NSAPP_DATA2_RUNASSCRIPT): Define.
3050
3051 * nsfns.m (as_script, as_result, as_status): New static variables.
3052 (ns_run_ascript): New function.
3053 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3054 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3055 the event loop. Get status from as_status (Bug#7276).
3056
3057 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3058 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3059 the event loop (Bug#7276).
3060
3061 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3062
3063 * gnutls.c (QCgnutls_bootprop_priority)
3064 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3065 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3066 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3067 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3068 (QCgnutls_bootprop_verify_hostname_error)
3069 (QCgnutls_bootprop_callbacks_verify): Rename from
3070 Qgnutls_bootprop_..., all uses changed.
3071
3072 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3073 uses changed.
3074
3075 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 * xfaces.c (Qframe_set_background_mode): Now static.
3078 * dispextern.h (Qframe_set_background_mode): Remove decl.
3079
3080 * process.c (Fnetwork_interface_info): Declare local only if needed.
3081
3082 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3083
3084 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3085 (Fnetwork_interface_list): Allocate in increments of bytes instead
3086 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3087 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3088 sockaddr.
3089 (struct ifflag_def): notrailers is smart on OSX.
3090 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3091 Get hardware address with getifaddrs if available.
3092
3093 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3094
3095 * xdisp.c (iterate_out_of_display_property): xassert that
3096 IT->position is set to within IT->object's boundaries. Break from
3097 the loop as soon as EOB is reached; avoids infloops in redisplay
3098 when IT->position is set up wrongly due to some bug.
3099 Set IT->current to match the bidi iterator unconditionally.
3100 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3101 entry. Force push_it to save on the stack the current
3102 buffer/string position, to be restored by pop_it. Fix flags in
3103 the iterator structure wrt the object coming from a display
3104 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3105 properties. (Bug#9284)
3106
3107 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3108
3109 * fontset.c (fontset_get_font_group): Add proper type checks.
3110 (Bug#9172)
3111
3112 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3113
3114 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3115 and LC_VERSION_MIN_MACOSX.
3116 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3117 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3118
3119 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3120
3121 * xdisp.c (forward_to_next_line_start): Allow to use the
3122 no-display-properties-and-no-overlays under bidi display.
3123 Set disp_pos in the bidi iterator to avoid searches for display
3124 properties and overlays.
3125
3126 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3127
3128 * editfns.c (Fset_time_zone_rule): Document relationship with the
3129 setenv function.
3130
3131 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3132 the font entity extracted from the cache (Bug#8109).
3133
3134 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3135
3136 * composite.c (autocmp_chars): Don't reset point. That is done by
3137 restore_point_unwind (Bug#5984).
3138
3139 2011-08-07 Juri Linkov <juri@jurta.org>
3140
3141 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3142 to show the arg `TIME' instead of `TIMEVAL'.
3143
3144 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3145
3146 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3147 display property strides EOL and includes a newline, as in
3148 longlines-mode. (Bug#9254)
3149 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3150 word-wrap under bidirectional display. (Bug#9224)
3151
3152 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3153 is non-zero, even if the data buffer is NULL. Fixes a crash in
3154 vertical-motion with longlines-mode. (Bug#9254)
3155
3156 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3157
3158 * bidi.c <bidi_cache_total_alloc>: Now static.
3159 (bidi_initialize): Initialize bidi_cache_total_alloc.
3160
3161 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3162 cache. (Bug#9221)
3163
3164 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3165 amount allocated this far in `bidi_cache_total_alloc'.
3166 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3167 non-zero, only free the data buffer without restoring the cache
3168 contents. All callers changed.
3169
3170 * dispextern.h (bidi_unshelve_cache): Update prototype.
3171
3172 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3173 (move_it_in_display_line, move_it_to)
3174 (move_it_vertically_backward, move_it_by_lines): Replace the call
3175 to xfree to an equivalent call to bidi_unshelve_cache.
3176 (move_it_in_display_line_to): Fix logic of returning
3177 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3178
3179 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3180
3181 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3182 came from a string character with a `cursor' property. (Bug#9229)
3183
3184 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3185
3186 * Makefile.in (LIB_PTHREAD): New variable.
3187 (LIBES): Add LIB_PTHREAD (Bug#9216).
3188
3189 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3190 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3191
3192 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3193
3194 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3195
3196 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3197
3198 * xterm.c (x_find_topmost_parent): New function.
3199 (x_set_frame_alpha): Find topmost parent window with
3200 x_find_topmost_parent and set the property there also (bug#9181).
3201 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3202
3203 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 * callproc.c (Fcall_process): Avoid vfork clobbering
3206 the local vars buffer, coding_systems, current_dir.
3207
3208 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3211
3212 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3215 so that it is not optimized away.
3216
3217 * xdisp.c (compute_display_string_pos): Remove unused local.
3218
3219 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3220
3221 Fix slow cursor motion and scrolling in large buffers with
3222 selective display, like Org Mode buffers. (Bug#9218)
3223
3224 * dispextern.h (struct bidi_it): New member disp_prop_p.
3225
3226 * xdisp.c: Remove one-slot cache of display string positions.
3227 (compute_display_string_pos): Accept an additional argument
3228 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3229 for a display string or property. If found, set DISP_PROP_P
3230 non-zero.
3231
3232 * bidi.c (bidi_fetch_char): Accept an additional argument
3233 DISP_PROP_P, and pass it to compute_display_string_pos.
3234 Only handle text covered by a display string if DISP_PROP_P is returned
3235 non-zero. All callers of bidi_fetch_char changed.
3236
3237 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3240
3241 2010-12-03 Don March <don@ohspite.net>
3242
3243 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3244 last character M-[char] is translated to ESC [char] (bug#7541).
3245
3246 2011-08-02 Kenichi Handa <handa@m17n.org>
3247
3248 * lisp.h (uniprop_table): Extern it.
3249
3250 * chartab.c (uniprop_table): Make it non-static.
3251
3252 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3253
3254 * xdisp.c (forward_to_next_line_start): Accept additional argument
3255 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3256 on the newline.
3257 (reseat_at_next_visible_line_start): Use the bidi iterator state
3258 returned by forward_to_next_line_start to restore the state of
3259 it->bidi_it after backing up to previous newline. (Bug#9212)
3260
3261 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3262
3263 * regex.c (re_comp): Protoize.
3264 (re_exec): Fix return type.
3265 (regexec): Fix type of `ret'. (Bug#9203)
3266
3267 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3270 This is needed if max-image-size is a floating-point number.
3271
3272 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3273
3274 * print.c (print_object): Print empty symbol as ##.
3275
3276 * lread.c (read1): Read ## as empty symbol.
3277
3278 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3279
3280 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3281 setting frame foreground color (Bug#9175).
3282 (x_set_background_color): Likewise.
3283
3284 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3285 contents (Bug#9176).
3286 (EmacsTooltip -init): Remove bezels and add shadows to
3287 tooltip windows.
3288
3289 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3290 or scroll bar (Bug#8470).
3291
3292 * nsfont.m (nsfont_open): Remove assignment to voffset and
3293 unnecessary vars hshink, expand, hd, full_height, min_height.
3294 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3295
3296 * nsterm.h (nsfont_info): Remove voffset field.
3297
3298 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3299
3300 Implement strike-through and overline on NextStep (Bug#8863).
3301
3302 * nsfont.m (nsfont_open): Use underline position provided by font,
3303 instead of hard-coded value of 2.
3304 (nsfont_draw): Call ns_draw_text_decoration instead.
3305
3306 * nsterm.h: Add declaration for ns_draw_text_decoration.
3307
3308 * nsterm.m (ns_draw_text_decoration): New function for drawing
3309 underline, overline, and strike-through.
3310 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3311 ns_draw_text_decoration. Change treatment of cursor drawing to
3312 accommodate underlining, etc.
3313
3314 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3315
3316 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3317 default.
3318
3319 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3322 Without this fix, if a signal arrives just after memory fills up,
3323 'malloc' might be invoked reentrantly.
3324
3325 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3326 In other words, assume that every image size is allowed, on non-X
3327 hosts. This assumption is probably wrong, but it lets Emacs compile.
3328
3329 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3330
3331 * regex.c (re_iswctype): Convert return values to boolean.
3332
3333 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3334
3335 * xdisp.c (compute_display_string_pos): Don't use cached display
3336 string position if the buffer had its restriction changed.
3337 (Bug#9184)
3338
3339 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3340
3341 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3342
3343 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Integer signedness and overflow and related fixes. (Bug#9079)
3346
3347 * bidi.c: Integer size and overflow fixes.
3348 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3349 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3350 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3351 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3352 (bidi_find_other_level_edge):
3353 Use ptrdiff_t instead of EMACS_INT where either will do.
3354 This works better on 32-bit hosts configured --with-wide-int.
3355 (bidi_cache_ensure_space): Check for size-calculation overflow.
3356 Use % rather than repeated addition, for better worst-case speed.
3357 Don't set bidi_cache_size until after xrealloc returns, because it
3358 might not return.
3359 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3360 (bidi_cache_ensure_space): Also check that the bidi cache size
3361 does not exceed that of the largest Lisp string or buffer. See Eli
3362 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3363
3364 * alloc.c (__malloc_size_t): Remove.
3365 All uses replaced by size_t. See Andreas Schwab's note
3366 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3367
3368 * image.c: Improve checking for integer overflow.
3369 (check_image_size): Assume that f is nonnull, since
3370 it is always nonnull in practice. This is one less thing to
3371 worry about when checking for integer overflow later.
3372 (x_check_image_size): New function, which checks for integer
3373 overflow issues inside X.
3374 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3375 This removes the need for a memory_full check.
3376 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3377 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3378 (xbm_read_bitmap_data): Change locals back to 'int', since
3379 their values must fit in 'int'.
3380 (xpm_load_image, png_load, tiff_load):
3381 Invoke x_create_x_image_and_pixmap earlier,
3382 to avoid much needless work if the image is too large.
3383 (tiff_load): Treat overly large images as if
3384 x_create_x_image_and_pixmap failed, not as malloc failures.
3385 (gs_load): Use x_check_image_size.
3386
3387 * gtkutil.c: Omit integer casts.
3388 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3389 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3390
3391 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3392
3393 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3394 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3395 would wrongly return t on a 64-bit host.
3396
3397 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3398 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3399 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3400 and therefore cause GCC to emit a bogus diagnostic in some cases.
3401
3402 * image.c: Integer signedness and overflow and related fixes.
3403 This is not an exhaustive set of fixes, but it's time to
3404 record what I've got.
3405 (lookup_pixel_color, check_image_size): Remove redundant decls.
3406 (check_image_size): Don't assume that arbitrary EMACS_INT values
3407 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3408 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3409 (tiff_load, imagemagick_load_image):
3410 Check for overflow in size calculations.
3411 (x_create_x_image_and_pixmap): Remove unnecessary test for
3412 xmalloc returning NULL; that can't happen.
3413 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3414 (xpm_color_bucket): Use better integer hashing function.
3415 (xpm_cache_color): Don't possibly over-allocate memory.
3416 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3417 (gif_memory_source):
3418 Use ptrdiff_t, not int or size_t, to record sizes.
3419 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3420 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3421 either works, as we prefer signed integers.
3422 (tiff_read_from_memory, tiff_write_from_memory):
3423 Return tsize_t, not size_t, since that's what the TIFF API wants.
3424 (tiff_read_from_memory): Don't fail simply because the read would
3425 go past EOF; instead, return a short read.
3426 (tiff_load): Omit no-longer-needed casts.
3427 (Fimagemagick_types): Don't assume size fits into 'int'.
3428
3429 Improve hashing quality when configured --with-wide-int.
3430 * fns.c (hash_string): New function, taken from sxhash_string.
3431 Do not discard information about ASCII character case; this
3432 discarding is no longer needed.
3433 (sxhash-string): Use it. Change sig to match it. Caller changed.
3434 * lisp.h: Declare it.
3435 * lread.c (hash_string): Remove, since we now use fns.c's version.
3436 The fns.c version returns a wider integer if --with-wide-int is
3437 specified, so this should help the quality of the hashing a bit.
3438
3439 * emacs.c: Integer overflow minor fix.
3440 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3441 Define only if GNU_LINUX.
3442 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3443
3444 * dispnew.c: Integer signedness and overflow fixes.
3445 Remove unnecessary forward decls, that were a maintenance hassle.
3446 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3447 All uses changed.
3448 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3449 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3450 (prepare_desired_row, line_draw_cost):
3451 Use int, not unsigned, where either works.
3452 (save_current_matrix, restore_current_matrix):
3453 Use ptrdiff_t, not size_t, where either works.
3454 (init_display): Check for overflow more accurately, and without
3455 relying on undefined behavior.
3456
3457 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3458 Remove, replacing with the new symbols in lisp.h. All uses changed.
3459 * fileio.c (make_temp_name):
3460 * filelock.c (lock_file_1, lock_file):
3461 * xdisp.c (message_dolog):
3462 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3463 Use pMd etc. instead.
3464 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3465 replacing the pWIDE etc. symbols removed from editfns.c.
3466
3467 * keyboard.h (num_input_events): Now uintmax_t.
3468 This is (very slightly) less likely to mess up due to wraparound.
3469 All uses changed.
3470
3471 * buffer.c: Integer signedness fixes.
3472 (alloc_buffer_text, enlarge_buffer_text):
3473 Use ptrdiff_t rather than size_t when either will do, as we prefer
3474 signed integers.
3475
3476 * alloc.c: Integer signedness and overflow fixes.
3477 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3478 (__malloc_size_t): Default to size_t, not to int.
3479 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3480 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3481 Prefer ptrdiff_t to size_t when either would do, as we prefer
3482 signed integers.
3483 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3484 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3485 Now const. Initialize with values that are in range even if char
3486 is signed.
3487 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3488 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3489 These functions do the right thing with sizes > 2**32.
3490 (check_depth): Now ptrdiff_t, not int.
3491 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3492 Adjust to new way of storing sizes. Check for size overflow bugs
3493 in rest of code.
3494 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3495 slightly wrong anyway, as it missed one instance of
3496 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3497 (refill_memory_reserve): Omit needless cast to size_t.
3498 (mark_object_loop_halt): Mark as externally visible.
3499
3500 * xselect.c: Integer signedness and overflow fixes.
3501 (Fx_register_dnd_atom, x_handle_dnd_message):
3502 Use ptrdiff_t, not size_t, since we prefer signed.
3503 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3504 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3505 x_dnd_atoms_size and x_dnd_atoms_length.
3506
3507 * doprnt.c: Prefer signed to unsigned when either works.
3508 * eval.c (verror):
3509 * doprnt.c (doprnt):
3510 * lisp.h (doprnt):
3511 * xdisp.c (vmessage):
3512 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3513 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3514 prefer signed arithmetic to avoid comparison confusion.
3515 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3516 but is a bit tricky.
3517
3518 Assume freestanding C89 headers, string.h, stdlib.h.
3519 * data.c, doprnt.c, floatfns.c, print.c:
3520 Include float.h unconditionally.
3521 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3522 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3523 * regex.c: Likewise for stddef.h, string.h.
3524 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3525 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3526 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3527 (STDC_HEADERS): Remove obsolete defines.
3528 * sysdep.c: Include limits.h unconditionally.
3529
3530 Assume support for memcmp, memcpy, memmove, memset.
3531 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3532 * regex.c (memcmp, memcpy):
3533 Remove; we assume C89 now.
3534
3535 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3536 (__malloc_safe_bcopy): Remove; no longer needed.
3537
3538 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3539 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3540 well either way, and we prefer signed to unsigned.
3541
3542 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543
3544 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3545 closes the connection while we're reading (bug#9182).
3546
3547 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3550 are specified (Bug#9168).
3551
3552 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3555 Found by GCC static checking and --with-wide-int on a 32-bit host.
3556
3557 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3558
3559 * xdisp.c (compute_display_string_pos): Fix logic of caching
3560 previous display string position. Initialize cached_prev_pos to
3561 -1. Fixes slow-down at the beginning of a buffer.
3562
3563 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3564
3565 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3566 for attrs[LFACE_FONTSET_INDEX].
3567
3568 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * xml.c (parse_region): Remove unused local
3571 that was recently introduced.
3572
3573 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3574
3575 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3576 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3577
3578 * xdisp.c (move_it_in_display_line_to): Record the best matching
3579 position for TO_CHARPOS while scanning the line, and restore it on
3580 exit if none of the characters scanned was an exact match.
3581 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3582 when exact match is impossible due to invisible text, and the
3583 lines are truncated.
3584
3585 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3588 for OSX >= 10.7.
3589
3590 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3591
3592 Fix a significant slow-down of cursor motion with C-n, C-p,
3593 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3594 auto-repeat under bidi redisplay in fontified buffers.
3595 * xdisp.c (compute_stop_pos_backwards): New function.
3596 (next_element_from_buffer): Call compute_stop_pos_backwards to
3597 find a suitable prev_stop when we find ourselves before
3598 base_level_stop.
3599 (reseat): Don't look for prev_stop, as that could mean a very long
3600 run.
3601 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3602 <cached_disp_overlay_modiff>: Cache for last found display string
3603 position.
3604 (compute_display_string_pos): Return the cached position if asked
3605 about the same buffer in the same area of character positions, and
3606 the buffer wasn't changed since the time the display string
3607 position was cached.
3608
3609 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3610
3611 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3612 is an integer, which is important for empty lines. (Bug#9149)
3613
3614 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3615
3616 * frame.c (Fmodify_frame_parameters): In tty case, update the
3617 default face if necessary (Bug#4238).
3618
3619 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3620
3621 * editfns.c (Fstring_to_char): No need to explain what a character
3622 is in the docstring (Bug#6576).
3623
3624 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3625
3626 * xml.c (parse_region): Make sure we always return a tree.
3627
3628 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3629
3630 * xml.c (parse_region): If a document contains only comments,
3631 return that, too.
3632
3633 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3634
3635 * xml.c (make_dom): Return comments, too.
3636
3637 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 Port to OpenBSD.
3640 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3641 and the surrounding thread.
3642 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3643 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3644 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3645 timer goes off.
3646 * s/openbsd.h (BROKEN_SIGIO): Define.
3647 * unexelf.c (unexec) [__OpenBSD__]:
3648 Don't update the .mdebug section of the Alpha COFF symbol table.
3649
3650 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3651
3652 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3653 (bug#8460).
3654
3655 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3658 This fixes some race conditions on the permissions of any newly
3659 created file.
3660
3661 * alloc.c (valid_pointer_p): Use pipe, not open.
3662 This fixes some permissions issues when debugging.
3663
3664 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3665 If fchown fails to set both uid and gid, try to set just gid,
3666 as that is sometimes allowed. Adjust the file's mode to eliminate
3667 setuid or setgid bits that are inappropriate if fchown fails.
3668
3669 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3670
3671 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3672 to compare Lisp_Objects.
3673 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3674 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3675 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3676
3677 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3678
3679 * lread.c (read_integer): Unread even EOF character.
3680 (read1): Likewise. Properly record start position of symbol.
3681
3682 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3683 symbol character follows.
3684
3685 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3688 This works around a problem with the previous change to Fcopy_file.
3689 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3690 and without this change, GCC might complain about discarding
3691 fchown's return value.
3692
3693 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3696
3697 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3700
3701 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3702
3703 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3704 it's used from the C level.
3705
3706 * process.c: Use the same condition for POLL_FOR_INPUT in both
3707 keyboard.c and process.c (bug#1858).
3708
3709 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3710
3711 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3712 (Fgnutls_boot): Use it.
3713
3714 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3715
3716 * doc.c (Fsubstitute_command_keys): Revert last change.
3717
3718 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3719
3720 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3721 quotes the next character, and doesn't affect other longer
3722 sequences (bug#8935).
3723
3724 * lread.c (syms_of_lread): Clarify that is isn't only
3725 `eval-buffer' and `eval-defun' that's affected by
3726 `lexical-binding' (bug#8460).
3727
3728 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3729
3730 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3731 bidi redisplay when a line includes both an image and is truncated.
3732
3733 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3734
3735 Fix minor problems found by static checking.
3736 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3737 (elsz): Now a signed constant, not a size_t var. We prefer signed
3738 types to unsigned, to avoid integer comparison confusion. Without
3739 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3740 "cannot optimize loop, the loop counter may overflow", a symptom
3741 of the confusion.
3742 * indent.c (Fvertical_motion): Mark locals as initialized.
3743 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3744
3745 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3746
3747 * search.c (Fre_search_backward): Mention `case-fold-search' in
3748 all the re_search_* functions (bug#8138).
3749
3750 * keyboard.c (Fopen_dribble_file): Document when the file is
3751 closed (bug#8056).
3752
3753 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3754
3755 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3756 bidi_cache_idx.
3757
3758 Support bidi reordering of display and overlay strings.
3759 * xdisp.c (compute_display_string_pos)
3760 (compute_display_string_end): Accept additional argument STRING.
3761 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3762 (reseat_to_string): Initialize bidi_it->string.s and
3763 bidi_it->string.schars.
3764 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3765 NULL (avoids a crash in bidi_paragraph_init).
3766 Initialize itb.string.lstring.
3767 (init_iterator): Call bidi_init_it only of a valid
3768 buffer position was specified. Initialize paragraph_embedding to
3769 L2R.
3770 (reseat_to_string): Initialize the bidi iterator.
3771 (display_string): If we need to ignore text properties of
3772 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3773 original value of -1 will not work with bidi.)
3774 (compute_display_string_pos): First arg is now struct
3775 `text_pos *'; all callers changed. Support display properties on
3776 Lisp strings.
3777 (compute_display_string_end): Support display properties on Lisp
3778 strings.
3779 (init_iterator, reseat_1, reseat_to_string): Initialize the
3780 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3781 when iterating on a string not from display properties).
3782 (compute_display_string_pos, compute_display_string_end):
3783 Fix calculation of the object to scan. Fixes an error when using
3784 arrow keys.
3785 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3786 base_level_stop; instead, set base_level_stop to BEGV.
3787 Fixes crashes in vertical-motion.
3788 (next_element_from_buffer): Improve commentary for when
3789 the iterator is before prev_stop.
3790 (init_iterator): Initialize bidi_p from the default value of
3791 bidi-display-reordering, not from buffer-local value. Use the
3792 buffer-local value only if initializing for buffer iteration.
3793 (handle_invisible_prop): Support invisible properties on strings
3794 that are being bidi-reordered.
3795 (set_iterator_to_next): Support bidi reordering of C strings and
3796 Lisp strings.
3797 (next_element_from_string): Support bidi reordering of Lisp
3798 strings.
3799 (handle_stop_backwards): Support Lisp strings as well.
3800 (display_string): Support display of R2L glyph rows.
3801 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3802 (init_iterator): Don't initialize it->bidi_p for strings
3803 here.
3804 (reseat_to_string): Initialize it->bidi_p for strings here.
3805 (next_element_from_string, next_element_from_c_string)
3806 (next_element_from_buffer): Add xassert's for correspondence
3807 between IT's object being iterated and it->bidi_it.string
3808 structure.
3809 (face_before_or_after_it_pos): Support bidi iteration.
3810 (next_element_from_c_string): Handle the case of the first string
3811 character that is not the first one in the visual order.
3812 (get_visually_first_element): New function, refactored from common
3813 parts of next_element_from_buffer, next_element_from_string, and
3814 next_element_from_c_string.
3815 (tool_bar_lines_needed, redisplay_tool_bar)
3816 (display_menu_bar): Force left-to-right direction. Add a FIXME
3817 comment for making that be controlled by a user option.
3818 (push_it, pop_it): Save and restore the state of the
3819 bidi iterator. Save and restore the bidi_p flag.
3820 (pop_it): Iterate out of display property for string iteration as
3821 well.
3822 (iterate_out_of_display_property): Support iteration over strings.
3823 (handle_single_display_spec): Set up it->bidi_it for iteration
3824 over a display string, and call bidi_init_it.
3825 (handle_single_display_spec, next_overlay_string)
3826 (get_overlay_strings_1, push_display_prop): Set up the bidi
3827 iterator for displaying display or overlay strings.
3828 (forward_to_next_line_start): Don't use the shortcut if
3829 bidi-iterating.
3830 (back_to_previous_visible_line_start): If handle_display_prop
3831 pushed the iterator stack, restore the internal state of the bidi
3832 iterator by calling bidi_pop_it same number of times.
3833 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3834 and we are bidi-iterating, don't decrement the iterator position;
3835 instead, set the first_elt flag in the bidi iterator, to produce
3836 the same effect.
3837 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3838 (push_display_prop): xassert that we are iterating a buffer.
3839 (push_it, pop_it): Save and restore paragraph_embedding member.
3840 (handle_single_display_spec, next_overlay_string)
3841 (get_overlay_strings_1, reseat_1, reseat_to_string)
3842 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3843 correctly. Don't assume unibyte strings are not bidi-reordered.
3844 (compute_display_string_pos)
3845 (compute_display_string_end): Fix handling the case of C string.
3846 (push_it, pop_it): Save and restore from_disp_prop_p.
3847 (handle_single_display_spec, push_display_prop): Set the
3848 from_disp_prop_p flag.
3849 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3850 (pop_it): Call iterate_out_of_display_property only if we are
3851 popping after iteration over a string that came from a display
3852 property. Fix a typo in popping stretch info. Add an assertion
3853 for verifying that the iterator position is in sync with the bidi
3854 iterator.
3855 (handle_single_display_spec, get_overlay_strings_1)
3856 (push_display_prop): Fix initialization of paragraph direction for
3857 string when that of the parent object is not yet determined.
3858 (reseat_1): Call bidi_init_it to resync the bidi
3859 iterator with IT's position. (Bug#7616)
3860 (find_row_edges): If ROW->start.pos gives position
3861 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3862 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3863 Reset the from_disp_prop_p flag.
3864 (SAVE_IT, RESTORE_IT): New macros.
3865 (pos_visible_p, face_before_or_after_it_pos)
3866 (back_to_previous_visible_line_start)
3867 (move_it_in_display_line_to, move_it_in_display_line)
3868 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3869 (try_scrolling, redisplay_window, display_line): Use them when
3870 saving a temporary copy of the iterator and restoring it back.
3871 (back_to_previous_visible_line_start, reseat_1)
3872 (init_iterator): Empty the bidi cache "stack".
3873 (move_it_in_display_line_to): If iterator ended up at
3874 EOL, but we never saw any buffer positions smaller than
3875 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3876 motion in bidi-reordered lines.
3877 (move_it_in_display_line_to): Record prev_method and prev_pos
3878 immediately before the call to set_iterator_to_next. Fixes cursor
3879 motion in bidi-reordered lines with stretch glyphs and strings
3880 displayed in margins. (Bug#8133) (Bug#8867)
3881 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3882 TO_CHARPOS.
3883 (pos_visible_p): Support positions in bidi-reordered lines.
3884 Save and restore bidi cache.
3885
3886 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3887 (bidi_paragraph_info): Delete unused struct.
3888 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3889 (bidi_cache_start): New variable.
3890 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3891 to zero.
3892 (bidi_cache_fetch_state, bidi_cache_search)
3893 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3894 (bidi_cache_find, bidi_peek_at_next_level)
3895 (bidi_level_of_next_char, bidi_find_other_level_edge)
3896 (bidi_move_to_visually_next): Compare cache index with
3897 bidi_cache_start rather than with zero.
3898 (bidi_fetch_char): Accept new argument STRING; all callers
3899 changed. Support iteration over a string. Support strings with
3900 display properties. Support unibyte strings. Fix the type of
3901 `len' according to what STRING_CHAR_AND_LENGTH expects.
3902 (bidi_paragraph_init, bidi_resolve_explicit_1)
3903 (bidi_resolve_explicit, bidi_resolve_weak)
3904 (bidi_level_of_next_char, bidi_move_to_visually_next):
3905 Support iteration over a string.
3906 (bidi_set_sor_type, bidi_resolve_explicit_1)
3907 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3908 can now be zero (for strings); special values 0 and -1 were
3909 changed to -1 and -2, respectively.
3910 (bidi_char_at_pos): New function.
3911 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3912 Call it instead of FETCH_MULTIBYTE_CHAR.
3913 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3914 initialized to valid values.
3915 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3916 values.
3917 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3918 the test for valid cached positions. Fix the logic for looking up
3919 the sentinel state in the cache. GCPRO the Lisp string we are
3920 iterating.
3921 (bidi_push_it, bidi_pop_it): New functions.
3922 (bidi_initialize): Initialize the bidi cache start stack pointer.
3923 (bidi_cache_ensure_space): New function, refactored from part of
3924 bidi_cache_iterator_state. Don't assume the required size is just
3925 one BIDI_CACHE_CHUNK away.
3926 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3927 (bidi_count_bytes, bidi_char_at_pos): New functions.
3928 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3929 always valid if bidi_cache_idx is valid.
3930 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3931 is valid if it's going to be used.
3932 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3933 (bidi_cache_fetch_state, bidi_cache_search)
3934 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3935 (bidi_cache_iterator_state, bidi_cache_find)
3936 (bidi_find_other_level_edge, bidi_cache_start_stack):
3937 All variables related to cache indices are now EMACS_INT.
3938
3939 * dispextern.h (struct bidi_string_data): New structure.
3940 (struct bidi_it): New member `string'. Make flag members be 1-bit
3941 fields, and put them last in the struct.
3942 (compute_display_string_pos, compute_display_string_end):
3943 Update prototypes.
3944 (bidi_push_it, bidi_pop_it): Add prototypes.
3945 (struct iterator_stack_entry): New members bidi_p,
3946 paragraph_embedding, and from_disp_prop_p.
3947 (struct it): Member bidi_p is now a bit field 1 bit wide.
3948 (bidi_shelve_cache, bidi_unshelve_cache):
3949 Declare prototypes.
3950
3951 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3952 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3953 and vector-like objects.
3954
3955 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3956 cache around display iteration.
3957
3958 * window.c (Fwindow_end, window_scroll_pixel_based)
3959 (displayed_window_lines, Frecenter): Save and restore the bidi
3960 cache around display iteration.
3961
3962 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963
3964 * editfns.c (Fdelete_region): Clarify the use of the named
3965 parameters (bug#6788).
3966
3967 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3968
3969 * indent.c (Fvertical_motion): Set and restore w->pointm when
3970 saving and restoring the window's buffer (Bug#9006).
3971
3972 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3973
3974 * editfns.c (Fstring_to_char): Clarify just what is returned
3975 (bug#6576). Text by Eli Zaretskii.
3976
3977 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3978
3979 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3980
3981 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3982
3983 * buffer.c (mmap_find): Fix a typo.
3984
3985 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3986
3987 Fix execution of x selection hooks.
3988 * xselect.c (Qx_lost_selection_functions)
3989 (Qx_sent_selection_functions): New vars.
3990 (syms_of_xselect): DEFSYM them.
3991 (x_handle_selection_request): Pass Qx_sent_selection_functions
3992 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3993 (x_handle_selection_clear,x_clear_frame_selections):
3994 Pass Qx_lost_selection_functions rather than
3995 Vx_lost_selection_functions to Frun_hook_with_args.
3996
3997 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4000 The old code sometimes used this field without initializing it.
4001
4002 * alloc.c (gc_sweep): Don't read past end of array.
4003 In theory, the old code could also have corrupted Emacs internals,
4004 though it'd be very unlikely.
4005
4006 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4007
4008 * character.c (Fcharacterp): Don't advertise optional ignored
4009 argument. (Bug#4026)
4010
4011 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4012
4013 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4014 key" (bug#4257).
4015
4016 * window.c (Fset_window_start): Doc fix (bug#4199).
4017 (Fset_window_hscroll): Ditto.
4018
4019 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 Fix minor new problems caught by GCC 4.6.1.
4022 * term.c (init_tty): Remove unused local.
4023 * xsettings.c (store_monospaced_changed): Define this function only
4024 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4025 not used otherwise.
4026
4027 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4030
4031 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4032
4033 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4034 are the mini-buffer and the echo area (bug#3320).
4035
4036 * term.c (init_tty): Remove support for supdup, c10 and perq
4037 terminals, which are no longer supported (bug#1482).
4038
4039 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4040
4041 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4042
4043 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4046 for non-popups (Bug#3642).
4047
4048 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4049
4050 * alloc.c (reset_malloc_hooks): Protoize.
4051 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4052 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4053 * cm.c (losecursor): Likewise.
4054 * data.c (fmod): Likewise.
4055 * dispnew.c (swap_glyphs_in_rows): Likewise.
4056 * emacs.c (memory_warning_signal): Likewise.
4057 * floatfns.c (float_error): Likewise.
4058 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4059 (otf_open, font_otf_capability, generate_otf_features)
4060 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4061 Likewise.
4062 * image.c (pbm_read_file): Likewise.
4063 * indent.c (string_display_width): Likewise.
4064 * intervals.c (check_for_interval, search_for_interval)
4065 (inc_interval_count, count_intervals, root_interval)
4066 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4067 * lread.c (defalias): Likewise.
4068 * ralloc.c (r_alloc_check): Likewise.
4069 * regex.c (set_image_of_range_1, set_image_of_range)
4070 (regex_grow_registers): Likewise.
4071 * sysdep.c (strerror): Likewise.
4072 * termcap.c (valid_filename_p, tprint, main): Likewise.
4073 * tparam.c (main): Likewise.
4074 * unexhp9k800.c (run_time_remap, save_data_space)
4075 (update_file_ptrs, read_header, write_header, calculate_checksum)
4076 (copy_file, copy_rest, display_header): Likewise.
4077 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4078 Likewise.
4079 * xdisp.c (check_it): Likewise.
4080 * xfaces.c (register_color, unregister_color, unregister_colors):
4081 Likewise.
4082 * xfns.c (print_fontset_result): Likewise.
4083 * xrdb.c (member, fatal, main): Likewise.
4084
4085 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 Fix minor problems found by static checking (Bug#9031).
4088 * chartab.c (char_table_set_range, map_sub_char_table):
4089 Remove unused locals.
4090 (uniprop_table): Now static.
4091 * composite.c (_work_char): Remove unused static var.
4092
4093 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4094
4095 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4096
4097 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4098
4099 * gtkutil.c (qttip_cb): Remove code without function.
4100
4101 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4102
4103 * w32.c (pthread_sigmask): New stub.
4104
4105 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 Use pthread_sigmask, not sigprocmask (Bug#9010).
4108 sigprocmask is portable only for single-threaded applications, and
4109 Emacs can be multi-threaded when it uses GTK.
4110 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4111 (LIBES): Use it.
4112 * callproc.c (Fcall_process):
4113 * process.c (create_process):
4114 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4115 Use pthread_sigmask, not sigprocmask.
4116
4117 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4118
4119 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4120 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4121 wrong (Bug#8591).
4122
4123 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4124
4125 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4126 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4127 (xg_hide_tooltip): Fix comment.
4128
4129 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4130 in registerServicesMenuSendTypes.
4131 (validRequestorForSendType): Don't check ns_return_types.
4132
4133 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4134 ns_return_type.
4135
4136 2011-07-08 Jason Rumney <jasonr@gnu.org>
4137
4138 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4139 SH_SHOW for hidden windows (Bug#5482).
4140
4141 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4142 frame struct members of non-existent frames (Bug#6284).
4143
4144 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4145
4146 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4147 variable firstTime not needed on OSX >= 10.6.
4148 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4149 >= 10.5. Use setKnobProportion, setDoubleValue.
4150
4151 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4152 (MAC_OS_X_VERSION_10_5): Define if not defined.
4153 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4154 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4155 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4156
4157 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4158 cString and lossyCString on OSX >= 10.4
4159
4160 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4161 sizeToFit on OSX >= 10.2.
4162
4163 * nsimage.m (allocInitFromFile): Don't use deprecated method
4164 bestRepresentationForDevice on OSX >= 10.6.
4165
4166 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4167 to avoid warning.
4168
4169 * emacs.c: Declare unexec_init_emacs_zone.
4170
4171 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4172
4173 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4174
4175 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4176 on svcsMenu (Bug#8842).
4177
4178 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4179 ns_return_types.
4180 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4181
4182 * nsterm.m (QUTF8_STRING): Declare.
4183 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4184 (validRequestorForSendType): Return type is (id).
4185 Change indexOfObjectIdenticalTo to indexOfObject.
4186 Check if we have local selection before returning self (Bug#8842).
4187 (writeSelectionToPasteboard): Put local selection into paste board
4188 if we have a local selection (Bug#8842).
4189 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4190
4191 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4192 (ns_get_local_selection): Declare.
4193
4194 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4195
4196 * keymap.c (describe_map_tree): Don't insert a double newline at
4197 the end of the buffer (bug#1169) and return whether we inserted
4198 something.
4199
4200 * callint.c (Fcall_interactively): Change "reading args" to
4201 "providing args" to try to clarify what it does (bug#1010).
4202
4203 2011-07-07 Kenichi Handa <handa@m17n.org>
4204
4205 * composite.c (composition_compute_stop_pos): Ignore a static
4206 composition starting before CHARPOS (Bug#8915).
4207
4208 * xdisp.c (handle_composition_prop): Likewise.
4209
4210 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4211
4212 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4213 (Bug#9015)
4214
4215 2011-07-07 Kenichi Handa <handa@m17n.org>
4216
4217 * character.h (unicode_category_t): New enum type.
4218
4219 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4220 (Qchar_code_property_table): New variable.
4221 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4222 (UNIPROP_COMPRESSED_FORM_P): New macros.
4223 (char_table_ascii): Uncompress the compressed values.
4224 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4225 Uncompress the compressed values.
4226 (sub_char_table_ref_and_range): Likewise.
4227 (char_table_ref_and_range): Uncompress the compressed values.
4228 (sub_char_table_set): New arg is_uniprop. Callers changed.
4229 Uncompress the compressed values.
4230 (sub_char_table_set_range): Args changed. Callers changed.
4231 (char_table_set_range): Adjuted for the above change.
4232 (map_sub_char_table): Delete args default_val and parent. Add arg
4233 top. Give decoded values to a Lisp function.
4234 (map_char_table): Adjust for the above change. Give decoded
4235 values to a Lisp function. Gcpro more variables.
4236 (uniprop_table_uncompress)
4237 (uniprop_decode_value_run_length): New functions.
4238 (uniprop_decoder, uniprop_decoder_count): New variables.
4239 (uniprop_get_decoder, uniprop_encode_value_character)
4240 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4241 New functions.
4242 (uniprop_encoder, uniprop_encoder_count): New variables.
4243 (uniprop_get_encoder, uniprop_table)
4244 (Funicode_property_table_internal, Fget_unicode_property_internal)
4245 (Fput_unicode_property_internal): New functions.
4246 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4247 Sunicode_property_table_internal, Sget_unicode_property_internal,
4248 and Sput_unicode_property_internal. Defvar_lisp
4249 char-code-property-alist.
4250
4251 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4252 Vunicode_category_table.
4253
4254 * font.c (font_range): Adjust for the change of
4255 Vunicode_category_table.
4256
4257 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4258
4259 * m/iris4d.h: Remove file, move contents ...
4260 * s/irix6-5.h: ... here.
4261
4262 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 Remove unportable assumption about struct layout (Bug#8884).
4265 * alloc.c (mark_buffer):
4266 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4267 (clone_per_buffer_values): Don't assume that
4268 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4269 This isn't true in general, and it's particularly not true
4270 if Emacs is configured with --with-wide-int.
4271 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4272 New macros, used in the buffer.c change.
4273
4274 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4275
4276 * xsettings.c: Use both GConf and GSettings if both are available.
4277 (store_config_changed_event): Add comment.
4278 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4279 (store_tool_bar_style_changed): New functions.
4280 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4281 (struct xsettings): Move font inside HAVE_XFT.
4282 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4283 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4284 Move inside HAVE_XFT.
4285 (something_changed_gsettingsCB): Rename from something_changedCB.
4286 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4287 also.
4288 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4289 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4290 (something_changed_gconfCB): Rename from something_changedCB.
4291 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4292 (parse_settings): Move check for font inside HAVE_XFT.
4293 (read_settings, apply_xft_settings): Add comment.
4294 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4295 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4296 call store_font_name_changed.
4297 (xft_settings_event): Add comment.
4298 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4299 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4300 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4301 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4302 (xsettings_initialize): Call init_gsettings last.
4303 (xsettings_get_system_font, xsettings_get_system_normal_font):
4304 Add comment.
4305
4306 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 Random fixes. E.g., (random) never returned negative values.
4309 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4310 subseconds part to the entropy, as that's a bit more random.
4311 Prefer signed to unsigned, since the signedness doesn't matter and
4312 in general we prefer signed. When given a limit, use a
4313 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4314 latter isn't right if USE_2_TAGS_FOR_INTS.
4315 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4316 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4317
4318 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4319
4320 * textprop.c (text_property_stickiness):
4321 Obey Vtext_property_default_nonsticky.
4322 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4323 * w32fns.c (syms_of_w32fns):
4324 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4325
4326 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4329 This is more efficient than Ffile_directory_p and avoids a minor race.
4330
4331 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4332
4333 * buffer.c (Foverlay_put): Say what the return value is
4334 (bug#7835).
4335
4336 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4337 is a directory before asking whether to use the file name
4338 (bug#7564).
4339 (barf_or_query_if_file_exists): Make the "File is a directory"
4340 error be more correct.
4341
4342 * fns.c (Frequire): Remove the mention of the .gz files, since
4343 that's installation-specific, but keep the mention of
4344 `get-load-suffixes'.
4345
4346 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4349 Report string overflow if the output is too long.
4350
4351 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4354 (syms_of_gnutls): Remove duplicate DEFSYM for
4355 Qgnutls_bootprop_verify_hostname_error, an error for
4356 Qgnutls_bootprop_verify_error (which is no longer used).
4357
4358 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4359 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4360 Also (re)move comments that are misplaced or no longer relevant.
4361
4362 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4363
4364 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4365
4366 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4367
4368 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4369 and background color parameters if they have been changed.
4370
4371 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4372
4373 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4374
4375 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 * xsettings.c (SYSTEM_FONT): Define only when used.
4378 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4379
4380 * keymap.c (access_keymap_1): Now static.
4381
4382 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4383
4384 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4385 leave any prefix arg for the up event (Bug#1586).
4386
4387 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4388
4389 * lread.c (syms_of_lread): Mention single symbols defined by
4390 `defvar' or `defconst' (bug#7154).
4391
4392 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4393 (Frequire): Mention get-load-suffixes.
4394
4395 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4396
4397 * window.h (window): Remove clone_number slot.
4398 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4399 Remove.
4400 (make_parent_window, make_window, saved_window)
4401 (Fset_window_configuration, save_window_save): Don't deal with
4402 clone numbers.
4403 * buffer.c (Qclone_number): Remove declaration.
4404 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4405
4406 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4407
4408 Add multiple inheritance to keymaps.
4409 * keymap.c (Fmake_composed_keymap): New function.
4410 (Fset_keymap_parent): Simplify.
4411 (fix_submap_inheritance): Remove.
4412 (access_keymap_1): New function extracted from access_keymap to handle
4413 embedded parents and handle lists of maps.
4414 (access_keymap): Use it.
4415 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4416 (Fcopy_keymap): Handle embedded parents.
4417 (Fcommand_remapping, define_as_prefix): Simplify.
4418 (Fkey_binding): Simplify.
4419 (syms_of_keymap): Move minibuffer-local-completion-map,
4420 minibuffer-local-filename-completion-map,
4421 minibuffer-local-must-match-map, and
4422 minibuffer-local-filename-must-match-map to Elisp.
4423 (syms_of_keymap): Defsubr make-composed-keymap.
4424 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4425 (parse_menu_item): Trivial simplification.
4426
4427 2011-07-01 Glenn Morris <rgm@gnu.org>
4428
4429 * Makefile.in (SETTINGS_LIBS): Fix typo.
4430
4431 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4432
4433 * coding.c (Fencode_coding_string): Record the last coding system
4434 used, as the function doc string says (bug#8738).
4435
4436 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4437
4438 * xsettings.c (store_monospaced_changed): Take new font as arg and
4439 check for change against current_mono_font.
4440 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4441 (emacs_settings_constructor, emacs_settings_get_property)
4442 (emacs_settings_set_property, emacs_settings_class_init)
4443 (emacs_settings_init, gsettings_obj): Remove.
4444 (something_changedCB): New function for HAVE_GSETTINGS.
4445 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4446 with value as argument.
4447 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4448 g_settings_new (Bug#8967). Do not create gsettings_obj.
4449 Remove calls to g_settings_bind. Connect something_changedCB to
4450 "changed".
4451
4452 * xgselect.c: Add defined (HAVE_GSETTINGS).
4453 (xgselect_initialize): Ditto.
4454
4455 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4456 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4457 xg_select.
4458
4459 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4460
4461 * eval.c (struct backtrace): Simplify and port the data structure.
4462 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4463 signed bit field, as this assumption is not portable and it makes
4464 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4465 "char debug_on_exit : 1" as this is not portable either; instead,
4466 use the portable "unsigned int debug_on_exit : 1". Remove unused
4467 member evalargs. Remove obsolete comments about cc bombing out.
4468
4469 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4472 Let HAVE_GSETTINGS override HAVE_GCONF.
4473 (store_monospaced_changed): New function.
4474 (EMACS_SETTINGS): A new type derived from GObject to handle
4475 GSettings notifications.
4476 (emacs_settings_constructor, emacs_settings_get_property)
4477 (emacs_settings_set_property, emacs_settings_class_init):
4478 New functions.
4479 (gsettings_client, gsettings_obj): New variables.
4480 (GSETTINGS_SCHEMA): New define.
4481 (something_changedCB): Call store_monospaced_changed.
4482 (init_gsettings): New function.
4483 (xsettings_initialize): Call init_gsettings.
4484 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4485 to NULL.
4486
4487 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4488 GCONF_CFLAGS/LIBS.
4489
4490 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4491
4492 * window.c (resize_root_window, grow_mini_window)
4493 (shrink_mini_window): Rename Qresize_root_window to
4494 Qwindow_resize_root_window and Qresize_root_window_vertically to
4495 Qwindow_resize_root_window_vertically.
4496
4497 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4500
4501 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4502
4503 * makefile.w32-in: Redesign dependencies so they reflect more
4504 clearly which files are directly included by each source file,
4505 and not through other includes.
4506
4507 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4508
4509 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4510 (sort_overlays, overlay_strings): When an overlay's clone number
4511 matches the window's clone number process the overlay even if
4512 the overlay's window property doesn't match the current window.
4513
4514 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4515 (Fwindow_hchild): Rename to Fwindow_left_child.
4516 (Fwindow_next): Rename to Fwindow_next_sibling.
4517 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4518 (resize_window_check): Rename to window_resize_check.
4519 (resize_window_apply): Rename to window_resize_apply.
4520 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4521 (Fdelete_other_windows_internal, resize_frame_windows)
4522 (Fsplit_window_internal, Fdelete_window_internal)
4523 (grow_mini_window, shrink_mini_window)
4524 (Fresize_mini_window_internal): Fix callers accordingly.
4525
4526 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4527
4528 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4529 (emacs_fixed_set_min_size): Remove.
4530 (emacs_fixed_new): Take frame as argument.
4531
4532 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4533 (_EmacsFixedPrivate): Remove minwidth/height.
4534 Add struct frame *f.
4535 (emacs_fixed_init): Initialize priv->f.
4536 (get_parent_class, emacs_fixed_set_min_size): Remove.
4537 (emacs_fixed_new): Set priv->f to argument.
4538 (emacs_fixed_get_preferred_width)
4539 (emacs_fixed_get_preferred_height): Use min_width/height from
4540 frames size_hint to set minimum and natural (Bug#8919).
4541 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4542 and use min_width/height from frames size_hint to set
4543 min_width/height (Bug#8919).
4544
4545 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4546 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4547 Fix indentation.
4548
4549 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4550
4551 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4552 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4553 called at ZV.
4554
4555 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4556
4557 * process.c (wait_reading_process_output): Bypass select if
4558 waiting for a cell while ignoring keyboard input, and input is
4559 pending. Suggested by Jan Djärv (Bug#8869).
4560
4561 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4562
4563 Use gnulib's dup2 module instead of rolling our own.
4564 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4565
4566 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4567
4568 * dispnew.c (scrolling_window): Before scrolling, turn off a
4569 mouse-highlight in the window being scrolled.
4570
4571 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4572
4573 Move DEFSYM to lisp.h and use everywhere.
4574
4575 * character.h (DEFSYM): Move declaration...
4576 * lisp.h (DEFSYM): ...here.
4577
4578 * gnutls.c:
4579 * minibuf.c:
4580 * w32menu.c:
4581 * w32proc.c:
4582 * w32select.c: Don't include character.h.
4583
4584 * alloc.c (syms_of_alloc):
4585 * buffer.c (syms_of_buffer):
4586 * bytecode.c (syms_of_bytecode):
4587 * callint.c (syms_of_callint):
4588 * casefiddle.c (syms_of_casefiddle):
4589 * casetab.c (init_casetab_once):
4590 * category.c (init_category_once, syms_of_category):
4591 * ccl.c (syms_of_ccl):
4592 * cmds.c (syms_of_cmds):
4593 * composite.c (syms_of_composite):
4594 * dbusbind.c (syms_of_dbusbind):
4595 * dired.c (syms_of_dired):
4596 * dispnew.c (syms_of_display):
4597 * doc.c (syms_of_doc):
4598 * editfns.c (syms_of_editfns):
4599 * emacs.c (syms_of_emacs):
4600 * eval.c (syms_of_eval):
4601 * fileio.c (syms_of_fileio):
4602 * fns.c (syms_of_fns):
4603 * frame.c (syms_of_frame):
4604 * fringe.c (syms_of_fringe):
4605 * insdel.c (syms_of_insdel):
4606 * keymap.c (syms_of_keymap):
4607 * lread.c (init_obarray, syms_of_lread):
4608 * macros.c (syms_of_macros):
4609 * msdos.c (syms_of_msdos):
4610 * print.c (syms_of_print):
4611 * process.c (syms_of_process):
4612 * search.c (syms_of_search):
4613 * sound.c (syms_of_sound):
4614 * syntax.c (init_syntax_once, syms_of_syntax):
4615 * terminal.c (syms_of_terminal):
4616 * textprop.c (syms_of_textprop):
4617 * undo.c (syms_of_undo):
4618 * w32.c (globals_of_w32):
4619 * window.c (syms_of_window):
4620 * xdisp.c (syms_of_xdisp):
4621 * xfaces.c (syms_of_xfaces):
4622 * xfns.c (syms_of_xfns):
4623 * xmenu.c (syms_of_xmenu):
4624 * xsettings.c (syms_of_xsettings):
4625 * xterm.c (syms_of_xterm): Use DEFSYM.
4626
4627 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4628
4629 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4630
4631 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 Integer and buffer overflow fixes (Bug#8873).
4634
4635 * print.c (printchar, strout): Check for string overflow.
4636 (PRINTPREPARE, printchar, strout):
4637 Don't set size unless allocation succeeds.
4638
4639 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4640 for sizes. Check for string overflow more accurately.
4641 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4642
4643 * macros.c: Integer and buffer overflow fixes.
4644 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4645 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4646 Use ptrdiff_t, not int, for sizes.
4647 Don't increment bufsize until after realloc succeeds.
4648 Check for size-calculation overflow.
4649 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4650
4651 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4652
4653 * lread.c: Integer overflow fixes.
4654 (read_integer): Radix is now EMACS_INT, not int,
4655 to improve quality of diagnostics for out-of-range radices.
4656 Calculate buffer size correctly for out-of-range radices.
4657 (read1): Check for integer overflow in radices, and in
4658 read-circle numbers.
4659 (read_escape): Avoid int overflow.
4660 (Fload, openp, read_buffer_size, read1)
4661 (substitute_object_recurse, read_vector, read_list, map_obarray):
4662 Use ptrdiff_t, not int, for sizes.
4663 (read1): Use EMACS_INT, not int, for sizes.
4664 Check for size overflow.
4665
4666 * image.c (cache_image): Check for size arithmetic overflow.
4667
4668 * lread.c: Integer overflow issues.
4669 (saved_doc_string_size, saved_doc_string_length)
4670 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4671 Now ptrdiff_t, not int.
4672 (read1): Don't assume doc string length fits in int. Check for
4673 out-of-range doc string lengths.
4674 (read_list): Don't assume file position fits in int.
4675 (read_escape): Check for hex character overflow.
4676
4677 2011-06-22 Leo Liu <sdl.web@gmail.com>
4678
4679 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4680 Move to minibuffer.el.
4681
4682 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4683
4684 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4685 The following patches are for when GLYPH_DEBUG && !XASSERT.
4686 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4687 * dispnew.c (flush_stdout):
4688 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4689 Mark as externally visible.
4690 * dispnew.c (check_window_matrix_pointers): Now static.
4691 * dispnew.c (window_to_frame_vpos):
4692 * xfns.c (unwind_create_frame):
4693 * xterm.c (x_check_font): Remove unused local.
4694 * scroll.c (CHECK_BOUNDS):
4695 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4696 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4697 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4698 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4699 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4700 Now static.
4701 (debug_method_add): Use va_list and vsprintf rather than relying
4702 on undefined behavior with wrong number of arguments.
4703 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4704 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4705 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4706 since we're not interested in debugging glyphs with old libraries.
4707 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4708 GCC 4.6.0's static checking.
4709
4710 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4711
4712 Integer overflow and signedness fixes (Bug#8873).
4713 A few related buffer overrun fixes, too.
4714
4715 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4716
4717 * dispextern.h (struct face.stipple):
4718 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4719 (x_bitmap_mask, x_allocate_bitmap_record)
4720 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4721 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4722 (x_create_bitmap_from_xpm_data):
4723 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4724 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4725 (.bitmaps_last):
4726 * xfaces.c (load_pixmap):
4727 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4728 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4729 (.bitmaps_last, struct x_output.icon_bitmap):
4730 Use ptrdiff_t, not int, for bitmap indexes.
4731 (x_allocate_bitmap_record): Check for size overflow.
4732 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4733
4734 Use ptrdiff_t, not int, for overlay counts.
4735 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4736 * editfns.c (overlays_around, get_pos_property):
4737 * textprop.c (get_char_property_and_overlay):
4738 * xdisp.c (next_overlay_change, note_mouse_highlight):
4739 * xfaces.c (face_at_buffer_position):
4740 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4741 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4742 (Fnext_overlay_change, Fprevious_overlay_change)
4743 (mouse_face_overlay_overlaps, Foverlays_in):
4744 Use ptrdiff_t, not int, for sizes.
4745 (overlays_at, overlays_in): Check for size-calculation overflow.
4746
4747 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4748
4749 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4750 (x_session_initialize): Do not assume string length fits in int.
4751
4752 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4753 This is unlikely, but can occur if DPI is outlandish.
4754
4755 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4756 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4757
4758 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4759 * xrdb.c (magic_file_p, search_magic_path):
4760 Omit last arg SUFFIX; it was always 0. All callers changed.
4761 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4762
4763 * xfont.c (xfont_match): Avoid need for strlen.
4764
4765 * xfns.c: Don't assume strlen fits in int.
4766 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4767
4768 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4769 not unsigned long, as we prefer signed integers. All callers changed.
4770 Detect integer overflow in repeat count.
4771 (message_dolog): Don't assume print length fits in 39 bytes.
4772 (display_mode_element): Don't assume strlen fits in int.
4773
4774 * termcap.c: Don't assume sizes fit in int and never overflow.
4775 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4776 (gobble_line): Check for size-calculation overflow.
4777
4778 * minibuf.c (Fread_buffer):
4779 * lread.c (intern, intern_c_string):
4780 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4781 Don't assume string length fits in int.
4782
4783 * keyboard.c (parse_tool_bar_item):
4784 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4785
4786 * font.c: Don't assume string length fits in int.
4787 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4788 Use ptrdiff_t, not int.
4789 (font_intern_prop): Don't assume string length fits in int.
4790 Don't assume integer property fits in fixnum.
4791 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4792
4793 * filelock.c: Fix some buffer overrun and integer overflow issues.
4794 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4795 Reformulate so as not to need the command string.
4796 Invoke gzip -cd rather than gunzip, as it's more portable.
4797 (lock_info_type, lock_file_1, lock_file):
4798 Don't assume pid_t and time_t fit in unsigned long.
4799 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4800 (current_lock_owner): Prefer signed type for sizes.
4801 Use memcpy, not strncpy, where memcpy is what is really wanted.
4802 Don't assume (via atoi) that time_t and pid_t fit in int.
4803 Check for time_t and/or pid_t out of range, e.g., via a network share.
4804 Don't alloca where an auto var works fine.
4805
4806 * fileio.c: Fix some integer overflow issues.
4807 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4808 Don't assume string length fits in int.
4809 (directory_file_name): Don't assume string length fits in long.
4810 (make_temp_name): Don't assume pid fits in int, or that its print
4811 length is less than 20.
4812
4813 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4814
4815 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4816
4817 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4818
4819 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4820 We prefer signed integers, even for size calculations.
4821
4822 * emacs.c: Don't assume string length fits in 'int'.
4823 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4824 (main): Don't invoke strlen when not needed.
4825
4826 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4827 (XD_DEBUG_MESSAGE): Don't waste a byte.
4828
4829 * callproc.c (getenv_internal_1, getenv_internal)
4830 (Fgetenv_internal):
4831 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4832
4833 * lread.c (invalid_syntax): Omit length argument.
4834 All uses changed. This doesn't fix a bug, but it simplifies the
4835 code away from its former Hollerith-constant appearance, and it's
4836 one less 'int' to worry about when looking at integer-overflow issues.
4837 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4838
4839 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4840 This didn't break anything, but it didn't help either.
4841 It's confusing to put a bogus integer in a place where the actual
4842 value does not matter.
4843 (LIST_END_P): Remove unused macro and its bogus comment.
4844 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4845
4846 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4847 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4848 implementation.
4849 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4850 We prefer signed types, and the value cannot exceed the EMACS_INT
4851 range anyway (because otherwise the length would not be representable).
4852 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4853 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4854 This avoids a GCC warning when WIDE_EMACS_INT.
4855
4856 * indent.c (sane_tab_width): New function.
4857 (current_column, scan_for_column, Findent_to, position_indentation)
4858 (compute_motion): Use it. This is just for clarity.
4859 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4860
4861 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4862
4863 * lisp.h (lint_assume): New macro.
4864 * composite.c (composition_gstring_put_cache):
4865 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4866
4867 * editfns.c, insdel.c:
4868 Omit unnecessary forward decls, to simplify future changes.
4869
4870 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4871
4872 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4873
4874 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4875 Use much-faster test for byte-length change.
4876 Don't assume string byte-length fits in 'int'.
4877 Check that character arg fits in 'int'.
4878 (mapcar1): Declare byte as byte, for clarity.
4879
4880 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4881
4882 * fns.c (concat): Catch string overflow earlier.
4883 Do not rely on integer wraparound.
4884
4885 * dispextern.h (struct it.overlay_strings_charpos)
4886 (struct it.selective): Now EMACS_INT, not int.
4887 * xdisp.c (forward_to_next_line_start)
4888 (back_to_previous_visible_line_start)
4889 (reseat_at_next_visible_line_start, next_element_from_buffer):
4890 Don't arbitrarily truncate the value of 'selective' to int.
4891
4892 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4893
4894 * composite.c: Don't truncate sizes to 'int'.
4895 (composition_gstring_p, composition_reseat_it)
4896 (composition_adjust_point): Use EMACS_INT, not int.
4897 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4898 not EMACS_UINT, for indexes.
4899
4900 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4901
4902 * buffer.c: Include <verify.h>.
4903 (struct sortvec.priority, struct sortstr.priority):
4904 Now EMACS_INT, not int.
4905 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4906 (struct sortstr.size, record_overlay_string)
4907 (struct sortstrlist.size, struct sortlist.used):
4908 Don't truncate size to int.
4909 (record_overlay_string): Check for size-calculation overflow.
4910 (init_buffer_once): Check at compile-time, not run-time.
4911
4912 2011-06-22 Jim Meyering <meyering@redhat.com>
4913
4914 Don't leak an XBM-image-sized buffer
4915 * image.c (xbm_load): Free the image buffer after using it.
4916
4917 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 Port to Sun C.
4920 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4921 that Sun C diagnosed.
4922 * fns.c (secure_hash): Fix pointer signedness issue.
4923 * intervals.c (static_offset_intervals): New function.
4924 (offset_intervals): Use it.
4925
4926 2011-06-21 Leo Liu <sdl.web@gmail.com>
4927
4928 * deps.mk (fns.o):
4929 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4930 sha512.h.
4931
4932 * fns.c (secure_hash): Rename from crypto_hash_function and change
4933 the first arg to accept symbols.
4934 (Fsecure_hash): New primitive.
4935 (syms_of_fns): New symbols.
4936
4937 2011-06-20 Deniz Dogan <deniz@dogan.se>
4938
4939 * process.c (Fset_process_buffer): Clarify return value in
4940 docstring.
4941
4942 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4943
4944 * dispnew.c (add_window_display_history): Use BVAR.
4945
4946 * xdisp.c (debug_method_add): Use BVAR.
4947 (check_window_end, dump_glyph_matrix, dump_glyph)
4948 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4949
4950 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4951 Likewise.
4952
4953 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4954 check till after the cache is created in init_frame_faces.
4955
4956 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4957
4958 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4959
4960 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4961
4962 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4963 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4964 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4965
4966 Improve buffer-overflow checking (Bug#8873).
4967 * fileio.c (Finsert_file_contents):
4968 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4969 Remove the old (too-loose) buffer overflow checks.
4970 They weren't needed, since make_gap checks for buffer overflow.
4971 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4972 The old code merely checked for Emacs fixnum overflow, and relied
4973 on undefined (wraparound) behavior. The new code avoids undefined
4974 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4975
4976 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4977 Tune. Don't use wider integers than needed. Don't use alloca.
4978 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4979
4980 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4981
4982 * insdel.c, lisp.h (buffer_overflow): New function.
4983 (insert_from_buffer_1, replace_range, replace_range_2):
4984 * insdel.c (make_gap_larger):
4985 * editfns.c (Finsert_char):
4986 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4987
4988 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4989
4990 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4991
4992 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4993
4994 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4995 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4996
4997 * fileio.c: Don't assume EMACS_INT fits in off_t.
4998 (emacs_lseek): New static function.
4999 (Finsert_file_contents, Fwrite_region): Use it.
5000 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5001
5002 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5003
5004 * fns.c: Don't overflow int when computing a list length.
5005 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5006 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5007 truncation on 64-bit hosts. Check for QUIT every
5008 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5009 faster and is responsive enough.
5010 (Flength): Report an error instead of overflowing an integer.
5011 (Fsafe_length): Return a float if the value is not representable
5012 as a fixnum. This shouldn't happen except in contrived situations.
5013 (Fnthcdr, Fsort): Don't assume list length fits in int.
5014 (Fcopy_sequence): Don't assume vector length fits in int.
5015
5016 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5017 (header_size, word_size): New constants.
5018 (allocate_vectorlike): Don't check size overflow here.
5019 (allocate_vector): Check it here instead, since this is the only
5020 caller of allocate_vectorlike that could cause overflow.
5021 Check that the new vector's length is representable as a fixnum.
5022
5023 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5024 The previous code was bogus. For example, next_almost_prime (32)
5025 returned 39, which is undesirable as it is a multiple of 3; and
5026 next_almost_prime (24) returned 25, which is a multiple of 5 so
5027 why was the code bothering to check for multiples of 7?
5028
5029 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5030
5031 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5032
5033 Variadic C functions now count arguments with ptrdiff_t.
5034 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5035 Back then I didn't know that the Emacs coding style prefers signed int.
5036 Also, in the meantime I found a few more instances where arguments
5037 were being counted with int, which may truncate counts on 64-bit
5038 machines, or EMACS_INT, which may be unnecessarily wide.
5039 * lisp.h (struct Lisp_Subr.function.aMANY)
5040 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5041 Arg counts are now ptrdiff_t, not size_t.
5042 All variadic functions and their callers changed accordingly.
5043 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5044 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5045 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5046 * callint.c (Fcall_interactively): Check arg count for overflow,
5047 to avoid potential buffer overrun. Use signed char, not 'int',
5048 for 'varies' array, so that we needn't bother to check its size
5049 calculation for overflow.
5050 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5051 * eval.c (apply_lambda):
5052 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5053 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5054 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5055
5056 * callint.c (Fcall_interactively): Don't use index var as event count.
5057
5058 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5059 * mem-limits.h (SIZE): Remove; no longer used.
5060
5061 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5062
5063 Remove unnecessary casts.
5064 * xterm.c (x_term_init):
5065 * xfns.c (x_set_border_pixel):
5066 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5067 These aren't needed now that we assume ANSI C.
5068
5069 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5070 It's more likely to cause problems (due to unsigned overflow)
5071 than to cure them.
5072
5073 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5074
5075 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5076
5077 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5078
5079 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5080
5081 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5082
5083 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5084
5085 GLYPH_CODE_FACE returns EMACS_INT, not int.
5086 * dispextern.h (merge_faces):
5087 * xfaces.c (merge_faces):
5088 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5089 Don't assume EMACS_INT fits in int.
5090
5091 * character.h (CHAR_VALID_P): Remove unused parameter.
5092 * fontset.c, lisp.h, xdisp.c: All uses changed.
5093
5094 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5095
5096 * fns.c (concat): Minor tuning based on overflow analysis.
5097 This doesn't fix any bugs. Use int to hold character, instead
5098 of constantly refetching from Emacs object. Use XFASTINT, not
5099 XINT, for value known to be a character. Don't bother comparing
5100 a single byte to 0400, as it's always less.
5101
5102 * floatfns.c (Fexpt):
5103 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5104
5105 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5106 for characters.
5107
5108 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5109
5110 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5111 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5112 incorrectly succeed when S was a string, because 4294967386 was
5113 truncated before it was used.
5114
5115 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5116 Otherwise, an out-of-range integer could cause undefined behavior
5117 on a 64-bit host.
5118
5119 * composite.c: Use int, not EMACS_INT, for characters.
5120 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5121 EMACS_INT, for values that are known to be in character range.
5122 This doesn't fix any bugs but is the usual style inside Emacs and
5123 may generate better code on 32-bit machines.
5124
5125 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5126 This is for reasons similar to the recent CHAR_STRING fix.
5127 * charset.c (Fencode_char): Check that character arg is actually
5128 a character. Pass an int to ENCODE_CHAR.
5129 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5130 wider than 'int', as a compile-time check to prevent future regressions
5131 in this area.
5132
5133 * character.c (char_string): Remove unnecessary casts.
5134
5135 Make sure a 64-bit char is never passed to CHAR_STRING.
5136 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5137 by silently ignoring the top 32 bits, allowing some values
5138 that were far too large to be valid characters.
5139 * character.h: Include <verify.h>.
5140 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5141 arguments are no wider than unsigned, as a compile-time check
5142 to prevent future regressions in this area.
5143 * data.c (Faset):
5144 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5145 (Fsubst_char_in_region):
5146 * fns.c (concat):
5147 * xdisp.c (decode_mode_spec_coding):
5148 Adjust to CHAR_STRING's new requirement.
5149 * editfns.c (Finsert_char, Fsubst_char_in_region):
5150 * fns.c (concat): Check that character args are actually
5151 characters. Without this test, these functions did the wrong
5152 thing with wildly out-of-range values on 64-bit hosts.
5153
5154 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5155 These casts should not be needed on 32-bit hosts, either.
5156 * keyboard.c (read_char):
5157 * lread.c (Fload): Remove casts to unsigned.
5158
5159 * lisp.h (UNSIGNED_CMP): New macro.
5160 This fixes comparison bugs on 64-bit hosts.
5161 (ASCII_CHAR_P): Use it.
5162 * casefiddle.c (casify_object):
5163 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5164 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5165 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5166 * dispextern.h (FACE_FROM_ID):
5167 * keyboard.c (read_char): Use UNSIGNED_CMP.
5168
5169 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5170 not to EMACS_INT, to avoid GCC warning.
5171
5172 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5173
5174 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5175 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5176 isn't needed on 32-bit machines.
5177
5178 * buffer.c (Fgenerate_new_buffer_name):
5179 Use EMACS_INT for count, not int.
5180 (advance_to_char_boundary): Return EMACS_INT, not int.
5181
5182 * data.c (Qcompiled_function): Now static.
5183
5184 * window.c (window_body_lines): Now static.
5185
5186 * image.c (gif_load): Rename local to avoid shadowing.
5187
5188 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5189 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5190 * alloc.c (make_save_value): Integer argument is now of type
5191 ptrdiff_t, not int.
5192 (mark_object): Use ptrdiff_t, not int.
5193 * lisp.h (pD): New macro.
5194 * print.c (print_object): Use it.
5195
5196 * alloc.c: Use EMACS_INT, not int, to count objects.
5197 (total_conses, total_markers, total_symbols, total_vector_size)
5198 (total_free_conses, total_free_markers, total_free_symbols)
5199 (total_free_floats, total_floats, total_free_intervals)
5200 (total_intervals, total_strings, total_free_strings):
5201 Now EMACS_INT, not int. All uses changed.
5202 (Fgarbage_collect): Compute overall total using a double, so that
5203 integer overflow is less likely to be a problem. Check for overflow
5204 when converting back to an integer.
5205 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5206 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5207 These were 'int' variables that could overflow on 64-bit hosts;
5208 they were never used, so remove them instead of repairing them.
5209 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5210 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5211 Previously, this ceilinged at INT_MAX, but that doesn't work on
5212 64-bit machines.
5213 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5214
5215 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5216 (allocate_vectorlike): Check for ptrdiff_t overflow.
5217 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5218 when a (possibly-narrower) signed value would do just as well.
5219 We prefer using signed arithmetic, to avoid comparison confusion.
5220
5221 * alloc.c: Catch some string size overflows that we were missing.
5222 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5223 for convenience in STRING_BYTES_MAX.
5224 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5225 The definition here is exact; the one in lisp.h was approximate.
5226 (allocate_string_data): Check for string overflow. This catches
5227 some instances we weren't catching before. Also, it catches
5228 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5229 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5230 and ptrdiff_t and EMACS_INT are both 64 bits.
5231
5232 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5233 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5234 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5235
5236 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5237
5238 * alloc.c (Fmake_string): Check for out-of-range init.
5239
5240 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5241
5242 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5243
5244 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5245
5246 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5247 xg_get_default_scrollbar_width.
5248
5249 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5250 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5251 (style_changed_cb): Call update_theme_scrollbar_width and call
5252 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5253 all frames (Bug#8505).
5254 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5255 Call gtk_window_set_resizable if HAVE_GTK3.
5256 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5257 and height if HAVE_GTK3 (Bug#8505).
5258 (scroll_bar_width_for_theme): New variable.
5259 (update_theme_scrollbar_width): New function.
5260 (xg_get_default_scrollbar_width): Move code to
5261 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5262 (xg_initialize): Call update_theme_scrollbar_width.
5263
5264 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5265
5266 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5267
5268 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5269
5270 * frame.c (make_frame): Call other_buffer_safely instead of
5271 other_buffer.
5272
5273 * window.c (temp_output_buffer_show): Call display_buffer with
5274 second argument Vtemp_buffer_show_specifiers and reset latter
5275 immediately after the call.
5276 (Vtemp_buffer_show_specifiers): New variable.
5277 (auto_window_vscroll_p, next_screen_context_lines)
5278 (Vscroll_preserve_screen_position): Remove leading asterisks from
5279 doc-strings.
5280
5281 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 Fix minor problems found by GCC 4.6.0 static checking.
5284 * buffer.c (Qclone_number): Remove for now, as it's unused.
5285 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5286 (record_buffer): Remove unused local.
5287 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5288 (set_frame_buffer_list): Remove; unused.
5289 * frame.h (other_visible_frames): Remove decl.
5290 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5291 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5292 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5293 if HAVE_GPM.
5294 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5295 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5296 Define only if HAVE_GPM.
5297 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5298 (update_hints_inhibit): Remove; never set. All uses removed.
5299 * widgetprv.h (emacsFrameClassRec): Remove decl.
5300 * window.c (delete_deletable_window): Now returns void, since it
5301 wasn't returning anything.
5302 (compare_window_configurations): Remove unused locals.
5303 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5304 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5305 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5306 the same widths as pointers. This follows up on the 2011-05-06 patch.
5307 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5308 * xterm.h: Likewise.
5309 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5310
5311 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * makefile.w32-in: Update dependencies.
5314 (LISP_H): Add lib/intprops.h.
5315
5316 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5317
5318 * image.c (gif_load): Add animation frame delay to the metadata.
5319 (syms_of_image): Use DEFSYM. New symbol `delay'.
5320
5321 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5322
5323 * window.c (delete_deletable_window): Re-add.
5324 (Fset_window_configuration): Rewrite to handle dead buffers and
5325 consequently deletable windows.
5326 (window_tree, Fwindow_tree): Remove. Supply functionality in
5327 window.el.
5328 (compare_window_configurations): Simplify code.
5329
5330 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5331
5332 * image.c (imagemagick_load_image): Fix type mismatch.
5333 (Fimagemagick_types): Likewise.
5334
5335 * window.h (replace_buffer_in_windows): Declare.
5336
5337 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5338
5339 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5340 Qclone_number. Remove external declaration of Qdelete_window.
5341 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5342 code.
5343 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5344 Run Qbuffer_list_update_hook if allowed.
5345 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5346 buffer list implementation.
5347 (other_buffer_safely): New function.
5348 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5349 calls to replace_buffer_in_windows and
5350 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5351 if allowed.
5352 (record_buffer): Inhibit quitting and rewrite using quittable
5353 functions. Run Qbuffer_list_update_hook if allowed.
5354 (Frecord_buffer, Funrecord_buffer): New functions.
5355 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5356 Move switch-to-buffer to window.el.
5357 (bury-buffer): Move to window.el.
5358 (Vbuffer_list_update_hook): New variable.
5359
5360 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5361 section.
5362
5363 * window.h (resize_frame_windows): Move up in code.
5364 (Fwindow_frame): Remove EXFUN.
5365 (replace_buffer_in_all_windows): Remove prototype.
5366 (replace_buffer_in_windows_safely): Add prototype.
5367
5368 * window.c: Declare Qdelete_window static again. Move down
5369 declaration of select_count.
5370 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5371 (Fother_window): Move to window.el.
5372 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5373 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5374 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5375 window.el.
5376 (replace_buffer_in_windows): Implement by calling
5377 Qreplace_buffer_in_windows.
5378 (replace_buffer_in_all_windows): Remove with some functionality
5379 moved into replace_buffer_in_windows_safely.
5380 (replace_buffer_in_windows_safely): New function.
5381 (select_window_norecord, select_frame_norecord): Move in front
5382 of run_window_configuration_change_hook. Remove now obsolete
5383 declarations.
5384 (Fset_window_buffer): Rewrite doc-string.
5385 Call Qrecord_window_buffer.
5386 (keys_of_window): Move binding for other-window to window.el.
5387
5388 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5389
5390 * dispextern.h (struct image): Replace data member, whose int_val
5391 and ptr_val fields were not used by anything, with a single
5392 lisp_val object.
5393
5394 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5395 (gif_clear_image, gif_load, imagemagick_load_image)
5396 (gs_clear_image, gs_load): Callers changed.
5397
5398 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5399
5400 * buffer.h: Include <time.h>, for time_t.
5401 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5402
5403 Fix minor problems found by static checking.
5404
5405 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5406
5407 Make identifiers static if they are not used in other modules.
5408 * data.c (Qcompiled_function, Qframe, Qvector):
5409 * image.c (QimageMagick, Qsvg):
5410 * minibuf.c (Qmetadata):
5411 * window.c (resize_window_check, resize_root_window): Now static.
5412 * window.h (resize_window_check, resize_root_window): Remove decls.
5413
5414 * window.c (window_deletion_count, delete_deletable_window):
5415 Remove; unused.
5416 (window_body_lines): Now static.
5417 (Fdelete_other_windows_internal): Mark vars as initialized.
5418 Make sure 'resize_failed' is initialized.
5419 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5420 (resize_window_apply): Remove unused local.
5421 * window.h (delete_deletable_window): Remove decl.
5422
5423 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5424 (imagemagick_load_image): Fix pointer signedness problem by changing
5425 last arg from unsigned char * to char *. All uses changed.
5426 Also, fix a local for similar reasons.
5427 Remove unused locals. Remove locals to avoid shadowing.
5428 (fn_rsvg_handle_free): Remove; unused.
5429 (svg_load, svg_load_image): Fix pointer signedness problem.
5430 (imagemagick_load_image): Don't use garbage pointer image_wand.
5431
5432 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5433
5434 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5435
5436 * image.c (gif_load): Fix omitted cast error introduced by
5437 2011-06-06 change.
5438
5439 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5440
5441 * window.h (resize_proportionally, orig_total_lines)
5442 (orig_top_line): Remove from window structure.
5443 (set_window_height, set_window_width, change_window_heights)
5444 (Fdelete_window): Remove prototypes.
5445 (resize_frame_windows): Remove duplicate declaration.
5446
5447 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5448
5449 * window.h (resize_frame_windows, resize_window_check)
5450 (delete_deletable_window, resize_root_window)
5451 (resize_frame_windows): Declare prototypes.
5452
5453 * window.c (resize_window_apply): Make definition be "static" to
5454 match the prototype.
5455
5456 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5457
5458 * window.c: Remove declarations of Qwindow_size_fixed,
5459 window_min_size_1, window_min_size_2, window_min_size,
5460 size_window, window_fixed_size_p, enlarge_window, delete_window.
5461 Remove static from declaration of Qdelete_window, it's
5462 temporarily needed by Fbury_buffer.
5463 (replace_window): Don't assign orig_top_line and
5464 orig_total_lines.
5465 (Fdelete_window, delete_window): Remove. Window deletion is
5466 handled by window.el.
5467 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5468 Replace Fdelete_window calls with calls to Qdelete_window.
5469 (Fdelete_other_windows): Remove. Deleting other windows is
5470 handled by window.el.
5471 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5472 handled in window.el.
5473 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5474 Window minimum sizes are handled in window.el.
5475 (shrink_windows, size_window, set_window_height)
5476 (set_window_width, change_window_heights, window_height)
5477 (window_width, CURBEG, CURSIZE, enlarge_window)
5478 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5479 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5480 handled in window.el.
5481 (make_dummy_parent): Rename to make_parent_window and give it a
5482 second argument horflag.
5483 (make_window): Don't set resize_proportionally any more.
5484 (Fsplit_window): Remove. Windows are split in window.el.
5485 (save_restore_action, save_restore_orig_size)
5486 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5487 Resize mini windows in window.el.
5488 (grow_mini_window, shrink_mini_window): Implement by calling
5489 Qresize_root_window_vertically, resize_window_check and
5490 resize_window_apply.
5491 (saved_window, Fset_window_configuration, save_window_save):
5492 Do not handle orig_top_line, orig_total_lines, and
5493 resize_proportionally.
5494 (window_min_height, window_min_width): Move to window.el.
5495 (keys_of_window): Move bindings for delete-other-windows,
5496 split-window, delete-window and enlarge-window to window.el.
5497
5498 * buffer.c: Temporarily extern Qdelete_window.
5499 (Fbury_buffer): Temporarily call Qdelete_window instead of
5500 Fdelete_window (Fbury_buffer will move to window.el soon).
5501
5502 * frame.c (set_menu_bar_lines_1): Remove code handling
5503 orig_top_line and orig_total_lines.
5504
5505 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5506 set_window_height but set heights directly.
5507 (change_frame_size_1): Use resize_frame_windows.
5508
5509 * xdisp.c (init_xdisp): Don't use set_window_height but set
5510 heights directly.
5511
5512 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5513 Use resize_frame_windows instead of change_window_heights and run
5514 run_window_configuration_change_hook.
5515
5516 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5517 instead of change_window_heights and run
5518 run_window_configuration_change_hook.
5519
5520 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5521
5522 * window.c (replace_window): Rename second argument REPLACEMENT to
5523 NEW. New third argument SETFLAG. Rewrite.
5524 (delete_window, make_dummy_parent): Call replace_window with
5525 third argument 1.
5526 (window_list_1): Move down in code.
5527 (run_window_configuration_change_hook): Move set_buffer part
5528 before select_frame_norecord part in order to unwind correctly.
5529 Rename count1 to count.
5530 (recombine_windows, delete_deletable_window, resize_root_window)
5531 (Fdelete_other_windows_internal)
5532 (Frun_window_configuration_change_hook, make_parent_window)
5533 (resize_window_check, resize_window_apply, Fresize_window_apply)
5534 (resize_frame_windows, Fsplit_window_internal)
5535 (Fdelete_window_internal, Fresize_mini_window_internal):
5536 New functions.
5537 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5538
5539 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5540
5541 * window.h (window): Add some new members to window structure -
5542 normal_lines, normal_cols, new_total, new_normal, clone_number,
5543 splits, nest, prev_buffers, next_buffers.
5544 (WINDOW_TOTAL_SIZE): Move here from window.c.
5545 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5546
5547 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5548 Remove.
5549 (make_dummy_parent): Set new members of windows structure.
5550 (make_window): Move down in code. Handle new members of window
5551 structure.
5552 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5553 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5554 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5555 (Fset_window_prev_buffers, Fwindow_next_buffers)
5556 (Fset_window_next_buffers, Fset_window_clone_number):
5557 New functions.
5558 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5559 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5560 Doc-string fixes.
5561 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5562 Argument WINDOW can be now internal window too.
5563 (Fwindow_use_time): Move up in code.
5564 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5565 Rewrite doc-string.
5566 (Fset_window_configuration, saved_window)
5567 (Fcurrent_window_configuration, save_window_save): Handle new
5568 members of window structure.
5569 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5570 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5571 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5572 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5573 Qget_mru_window, Qresize_root_window,
5574 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5575 Qauto_buffer_name; staticpro them.
5576
5577 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5578
5579 * window.c (Fwindow_total_size, Fwindow_left_column)
5580 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5581 (Fwindow_list_1): New functions.
5582 (window_box_text_cols): Replace with window_body_cols.
5583 (Fwindow_width, Fscroll_left, Fscroll_right):
5584 Use window_body_cols instead of window_box_text_cols.
5585 (delete_window, Fset_window_configuration):
5586 Call delete_all_subwindows with window as argument.
5587 (delete_all_subwindows): Take a window as argument and not a
5588 structure. Rewrite.
5589 (window_loop): Remove handling of GET_LRU_WINDOW and
5590 GET_LARGEST_WINDOW.
5591 (Fget_lru_window, Fget_largest_window): Move to window.el.
5592
5593 * window.h: Extern window_body_cols instead of
5594 window_box_text_cols. delete_all_subwindows now takes a
5595 Lisp_Object as argument.
5596
5597 * indent.c (compute_motion, Fcompute_motion):
5598 Use window_body_cols instead of window_box_text_cols.
5599
5600 * frame.c (delete_frame): Call delete_all_subwindows with root
5601 window as argument.
5602
5603 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5604
5605 * fns.c (Fputhash): Document return value.
5606
5607 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5608
5609 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5610
5611 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5612
5613 Cons<->int and similar integer overflow fixes (Bug#8794).
5614
5615 Check for overflow when converting integer to cons and back.
5616 * charset.c (Fdefine_charset_internal, Fdecode_char):
5617 Use cons_to_unsigned to catch overflow.
5618 (Fencode_char): Use INTEGER_TO_CONS.
5619 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5620 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5621 * data.c (long_to_cons, cons_to_long): Remove.
5622 (cons_to_unsigned, cons_to_signed): New functions.
5623 These signal an error for invalid or out-of-range values.
5624 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5625 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5626 * font.c (Ffont_variation_glyphs):
5627 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5628 * lisp.h: Include <intprops.h>.
5629 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5630 (cons_to_signed, cons_to_unsigned): New decls.
5631 (long_to_cons, cons_to_long): Remove decls.
5632 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5633 (Fprimitive_undo): Use CONS_TO_INTEGER.
5634 * xfns.c (Fx_window_property): Likewise.
5635 * xselect.c: Include <limits.h>.
5636 (x_own_selection, selection_data_to_lisp_data):
5637 Use INTEGER_TO_CONS.
5638 (x_handle_selection_request, x_handle_selection_clear)
5639 (x_get_foreign_selection, Fx_disown_selection_internal)
5640 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5641 (lisp_data_to_selection_data): Use cons_to_unsigned.
5642 (x_fill_property_data): Use cons_to_signed.
5643 Report values out of range.
5644
5645 Check for buffer and string overflow more precisely.
5646 * buffer.h (BUF_BYTES_MAX): New macro.
5647 * lisp.h (STRING_BYTES_MAX): New macro.
5648 * alloc.c (Fmake_string):
5649 * character.c (string_escape_byte8):
5650 * coding.c (coding_alloc_by_realloc):
5651 * doprnt.c (doprnt):
5652 * editfns.c (Fformat):
5653 * eval.c (verror):
5654 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5655 since they may not be the same number.
5656 * editfns.c (Finsert_char):
5657 * fileio.c (Finsert_file_contents):
5658 Likewise for BUF_BYTES_MAX.
5659
5660 * image.c: Use ptrdiff_t, not int, for sizes.
5661 (slurp_file): Switch from int to ptrdiff_t.
5662 All uses changed.
5663 (slurp_file): Check that file size fits in both size_t (for
5664 malloc) and ptrdiff_t (for sanity and safety).
5665
5666 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5667 if b->modtime has its maximal value.
5668
5669 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5670
5671 Don't assume time_t can fit into int.
5672 * buffer.h (struct buffer.modtime): Now time_t, not int.
5673 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5674 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5675
5676 Minor fixes for signed vs unsigned integers.
5677 * character.h (MAYBE_UNIFY_CHAR):
5678 * charset.c (maybe_unify_char):
5679 * keyboard.c (read_char, reorder_modifiers):
5680 XINT -> XFASTINT, since the integer must be nonnegative.
5681 * ftfont.c (ftfont_spec_pattern):
5682 * keymap.c (access_keymap, silly_event_symbol_error):
5683 XUINT -> XFASTINT, since the integer must be nonnegative.
5684 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5685 since it makes no difference and we prefer signed.
5686 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5687 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5688 nonnegative.
5689
5690 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5691
5692 * window.h (Fwindow_frame): Declare.
5693
5694 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5695
5696 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5697 (SPARE_MEMORY): Always define.
5698 (LARGE_REQUEST): Remove.
5699 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5700
5701 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5702
5703 * lisp.h: Move EXFUNS for Fframe_root_window,
5704 Fframe_first_window and Fset_frame_selected_window to window.h.
5705
5706 * window.h: Move EXFUNS for Fframe_root_window,
5707 Fframe_first_window and Fset_frame_selected_window here from
5708 lisp.h.
5709
5710 * frame.c (Fwindow_frame, Fframe_first_window)
5711 (Fframe_root_window, Fframe_selected_window)
5712 (Fset_frame_selected_window): Move to window.c.
5713 (Factive_minibuffer_window): Move to minibuf.c.
5714 (Fother_visible_frames_p): New function.
5715
5716 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5717
5718 * window.c (decode_window, decode_any_window): Move up in code.
5719 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5720 (inhibit_frame_unsplittable): Remove unused variable.
5721 (Fwindow_buffer): Move up and rewrite doc-string.
5722 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5723 (Fwindow_prev): New functions.
5724 (Fwindow_frame): Move here from frame.c. Accept any window as
5725 argument.
5726 (Fframe_root_window, Fframe_first_window)
5727 (Fframe_selected_window): Move here from frame.c. Accept frame
5728 or arbitrary window as argument. Update doc-strings.
5729 (Fminibuffer_window): Move up in code.
5730 (Fwindow_minibuffer_p): Move up in code and simplify.
5731 (Fset_frame_selected_window): Move here from frame.c.
5732 Marginal rewrite.
5733 (Fselected_window, select_window, Fselect_window): Move up in
5734 code. Minor doc-string fixes.
5735
5736 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5737
5738 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5739 Do not assume that spare memory exists; that assumption is valid
5740 only if SYSTEM_MALLOC.
5741 (LARGE_REQUEST): New macro, so that the issue of large requests
5742 is separated from the issue of spare memory.
5743
5744 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5745
5746 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5747 format. (Bug#8806)
5748
5749 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5750
5751 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5752 before statements.
5753
5754 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5755
5756 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5757
5758 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5759
5760 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5761 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5762
5763 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5764
5765 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5766
5767 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5768
5769 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5770 (x_clipboard_manager_save): Add return value.
5771 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5772 New error handlers.
5773 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5774 Obey Vx_select_enable_clipboard_manager. Catch errors in
5775 x_clipboard_manager_save (Bug#8779).
5776 (Vx_select_enable_clipboard_manager): New variable.
5777 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5778
5779 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5780
5781 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5782
5783 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5784
5785 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5786 in the current matrix if keep_current_p is non-zero.
5787
5788 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5789
5790 * bidi.c (bidi_level_of_next_char): Fix last change.
5791
5792 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5793
5794 Support bidi reordering of text covered by display properties.
5795
5796 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5797 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5798 (bidi_cache_search, bidi_cache_iterator_state)
5799 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5800 (bidi_level_of_next_char, bidi_move_to_visually_next):
5801 Support character positions inside a run of characters covered by a
5802 display string.
5803 (bidi_paragraph_init, bidi_resolve_explicit_1)
5804 (bidi_level_of_next_char): Call bidi_fetch_char and
5805 bidi_fetch_char_advance instead of FETCH_CHAR and
5806 FETCH_CHAR_ADVANCE.
5807 (bidi_init_it): Initialize new members.
5808 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5809 definitions.
5810 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5811 instead of using explicit *_CHAR codes.
5812 (bidi_resolve_explicit, bidi_resolve_weak):
5813 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5814 bidirectional text is supported only in multibyte buffers.
5815 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5816 it to initialize the frame_window_p member of struct bidi_it.
5817 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5818 (bidi_resolve_explicit, bidi_resolve_weak)
5819 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5820 bidi_it->nchars is non-positive.
5821 (bidi_level_of_next_char): Don't try to lookup the cache for the
5822 next/previous character if nothing is cached there yet, or if we
5823 were just reseat()'ed to a new position.
5824
5825 * xdisp.c (set_cursor_from_row): Set start and stop points
5826 according to the row's direction when priming the loop that looks
5827 for the glyph on which to display cursor.
5828 (single_display_spec_intangible_p): Function deleted.
5829 (display_prop_intangible_p): Reimplement to call
5830 handle_display_spec instead of single_display_spec_intangible_p.
5831 Accept 3 additional arguments needed by handle_display_spec.
5832 This fixes incorrect cursor motion across display property with complex
5833 values: lists, `(when COND...)' forms, etc.
5834 (single_display_spec_string_p): Support property values that are
5835 lists with the argument STRING its top-level element.
5836 (display_prop_string_p): Fix the condition for processing a
5837 property that is a list to be consistent with handle_display_spec.
5838 (handle_display_spec): New function, refactored from the
5839 last portion of handle_display_prop.
5840 (compute_display_string_pos): Accept additional argument
5841 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5842 value of a `display' property is a "replacing spec".
5843 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5844 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5845 the display property, but just return a value indicating whether
5846 the display property will replace the characters it covers.
5847 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5848 frame_window_p members of struct bidi_it.
5849 (compute_display_string_pos, compute_display_string_end):
5850 New functions.
5851 (push_it): Accept second argument POSITION, where pop_it should
5852 jump to continue iteration.
5853 (reseat_1): Initialize bidi_it.disp_pos.
5854
5855 * keyboard.c (adjust_point_for_property): Adjust the call to
5856 display_prop_intangible_p to its new signature.
5857
5858 * dispextern.h (struct bidi_it): New member frame_window_p.
5859 (bidi_init_it): Update prototypes.
5860 (display_prop_intangible_p): Update prototype.
5861 (compute_display_string_pos, compute_display_string_end):
5862 Declare prototypes.
5863 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5864 EMACS_INT.
5865
5866 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5867
5868 Malloc failure behavior now depends on size of allocation.
5869 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5870 * lisp.h: Change signatures accordingly.
5871 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5872 All callers changed. (Bug#8762)
5873
5874 * gnutls.c: Use Emacs's memory allocators.
5875 Without this change, the gnutls library would invoke malloc etc.
5876 directly, which causes problems on non-SYNC_INPUT hosts, and which
5877 runs afoul of improving memory_full behavior. (Bug#8761)
5878 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5879 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5880 xfree instead of the default malloc, realloc, free.
5881 (Fgnutls_boot): No need to check for memory allocation failure,
5882 since xmalloc does that for us.
5883
5884 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5885 * category.c (hash_get_category_set):
5886 * ccl.c (ccl_driver):
5887 * charset.c (Fdefine_charset_internal):
5888 * charset.h (struct charset.hash_index):
5889 * composite.c (get_composition_id, gstring_lookup_cache)
5890 (composition_gstring_put_cache):
5891 * composite.h (struct composition.hash_index):
5892 * dispextern.h (struct image.hash):
5893 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5894 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5895 (hashfn_equal, hashfn_user_defined, make_hash_table)
5896 (maybe_resize_hash_table, hash_lookup, hash_put)
5897 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5898 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5899 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5900 * image.c (make_image, search_image_cache, lookup_image)
5901 (xpm_put_color_table_h):
5902 * lisp.h (struct Lisp_Hash_Table):
5903 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5904 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5905 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5906 * alloc.c (allocate_vectorlike):
5907 Check for overflow in vector size calculations.
5908 * ccl.c (ccl_driver):
5909 Check for overflow when converting EMACS_INT to int.
5910 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5911 need to be updated by these changes.
5912 * fns.c (make_hash_table, maybe_resize_hash_table):
5913 Check for integer overflow with large hash tables.
5914 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5915 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5916 (SXHASH_REDUCE): New macro.
5917 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5918 Use it instead of discarding useful hash info with large hash values.
5919 (sxhash_float): New function.
5920 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5921 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5922 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5923 Rewrite to use FIXNUM_BITS, as this simplifies things.
5924 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5925 Adjust signatures to match updated version of code.
5926 (consing_since_gc): Now EMACS_INT, since a single hash table can
5927 use more than INT_MAX bytes.
5928
5929 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5930
5931 Make it possible to build with GCC-4.6+ -O2 -flto.
5932
5933 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5934
5935 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5936
5937 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5938 Call minibuffer-inactive-mode.
5939
5940 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5941
5942 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5943 Update dependencies.
5944
5945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5946
5947 * data.c (init_data): Remove code for UTS, this system is not
5948 supported anymore.
5949
5950 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5951
5952 Don't force ./temacs to start in terminal mode.
5953
5954 * frame.c (make_initial_frame): Initialize faces in all cases, not
5955 only when CANNOT_DUMP is defined.
5956 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5957
5958 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5959
5960 * dispnew.c (add_window_display_history): Use const for the string
5961 pointer. Remove declaration, not needed.
5962
5963 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 Use 'inline', not 'INLINE'.
5966 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5967 * alloc.c, fontset.c (INLINE): Remove.
5968 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5969 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5970 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5971 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5972 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5973
5974 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5975
5976 Make it possible to run ./temacs.
5977
5978 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5979 syms_of_callproc does the same thing. Remove test for
5980 "initialized", do it in the caller.
5981 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5982
5983 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5984
5985 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5986 (read_minibuf): Use get_minibuffer.
5987 (syms_of_minibuf): Use DEFSYM.
5988 (Qmetadata): New var.
5989 * data.c (Qbuffer): Don't make it static.
5990 (syms_of_data): Use DEFSYM.
5991
5992 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5995 (CCL_CODE_MIN): New macro.
5996
5997 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5998
5999 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6000
6001 * eval.c (Qdebug): Now static.
6002 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6003 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6004 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6005
6006 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6007
6008 * image.c: Various fixes to ImageMagick code comments.
6009 (Fimagemagick_types): Doc fix.
6010
6011 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6012
6013 Minor fixes prompted by GCC 4.6.0 warnings.
6014
6015 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6016
6017 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6018 (x_clipboard_manager_save_all): Move extern decl to ...
6019 * xterm.h: ... here, so that it can be checked for consistency.
6020
6021 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6022
6023 * xselect.c (x_clipboard_manager_save_frame)
6024 (x_clipboard_manager_save_all): New functions.
6025 (Fx_clipboard_manager_save): Lisp function deleted.
6026
6027 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6028 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6029
6030 * xterm.h: Update prototype.
6031
6032 2011-05-28 William Xu <william.xwl@gmail.com>
6033
6034 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6035 exiting (Bug#8239).
6036
6037 2011-05-28 Jim Meyering <meyering@redhat.com>
6038
6039 Avoid a sign-extension bug in crypto_hash_function.
6040 * fns.c (to_uchar): Define.
6041 (crypto_hash_function): Use it to convert some newly-signed
6042 variables to unsigned, to avoid sign-extension bugs. For example,
6043 without this change, (md5 "truc") would evaluate to
6044 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6045 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6046 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6047
6048 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6049
6050 Integer overflow fixes.
6051
6052 * dbusbind.c: Serial number integer overflow fixes.
6053 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6054 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6055 to hold a serial number that is too large for a fixnum.
6056 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6057 Check for serial numbers out of range. Decode any serial number
6058 that was so large that it became a float. (Bug#8722)
6059
6060 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6061 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6062 Use XFASTINT rather than XUINT when numbers are nonnegative.
6063 (xd_append_arg, Fdbus_method_return_internal):
6064 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6065 arguments, check that Lisp number is nonnegative, rather than
6066 silently wrapping negative numbers around. (Bug#8722)
6067 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6068 (Bug#8722)
6069
6070 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6071
6072 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6073
6074 ccl: Add integer overflow checks.
6075 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6076 (IN_INT_RANGE): New macros.
6077 (ccl_driver): Use them to check for integer overflow when
6078 decoding a CCL program. Many of the new checks are whether XINT (x)
6079 fits in int; it doesn't always, on 64-bit hosts. The new version
6080 doesn't catch all possible integer overflows, but it's an
6081 improvement. (Bug#8719)
6082
6083 * alloc.c (make_event_array): Use XINT, not XUINT.
6084 There's no need for unsigned here.
6085
6086 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6087 This follows up to the 2011-05-06 change that substituted uintptr_t
6088 for EMACS_INT. This case wasn't caught back then.
6089
6090 Rework Fformat to avoid integer overflow issues.
6091 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6092 now (part of C89). Include <verify.h>.
6093 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6094 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6095 (Fformat): Avoid the prepass trying to compute sizes; it was only
6096 approximate and thus did not catch overflow reliably. Instead, walk
6097 through the format just once, formatting and computing sizes as we go,
6098 checking for integer overflow at every step, and allocating a larger
6099 buffer as needed. Keep track separately whether the format is
6100 multibyte. Keep only the most-recently calculated precision, rather
6101 than them all. Record whether each argument has been converted to
6102 string. Use EMACS_INT, not int, for byte and char and arg counts.
6103 Support field widths and precisions larger than INT_MAX. Avoid
6104 sprintf's undefined behavior with conversion specifications such as %#d
6105 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6106 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6107 formatting out-of-range floating point numbers with int
6108 formats. (Bug#8668)
6109
6110 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6111
6112 * data.c: Avoid integer truncation in expressions involving floats.
6113 * data.c: Include <intprops.h>.
6114 (arith_driver): When there's an integer overflow in an expression
6115 involving floating point, convert the integers to floating point
6116 so that the resulting value does not suffer from catastrophic
6117 integer truncation. For example, on a 64-bit host (* 4
6118 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6119 Do not rely on undefined behavior after integer overflow.
6120
6121 merge count_size_as_multibyte, parse_str_to_multibyte
6122 * character.c, character.h (count_size_as_multibyte):
6123 Rename from parse_str_to_multibyte; all uses changed.
6124 Check for integer overflow.
6125 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6126 since it's now a duplicate of the other. This is more of
6127 a character than a buffer op, so better that it's in character.c.
6128 * fns.c, print.c: Adjust to above changes.
6129
6130 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6131
6132 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6133
6134 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6135
6136 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6137 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6138 (x_clipboard_manager_save): Now static.
6139 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6140
6141 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6142 (crypto_hash_function): Now static.
6143 Fix pointer signedness problems. Avoid unnecessary initializations.
6144
6145 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6146
6147 * termhooks.h (Vselection_alist): Make it terminal-local.
6148
6149 * terminal.c (create_terminal): Initialize it.
6150
6151 * xselect.c: Support for clipboard managers.
6152 (Vselection_alist): Move to termhooks.h as terminal-local var.
6153 (LOCAL_SELECTION): New macro.
6154 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6155 (symbol_to_x_atom): Remove gratuitous arg.
6156 (x_handle_selection_request, lisp_data_to_selection_data)
6157 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6158 (x_own_selection, x_get_local_selection, x_convert_selection):
6159 New arg, specifying work frame. Use terminal-local Vselection_alist.
6160 (some_frame_on_display): Delete unused function.
6161 (Fx_own_selection_internal, Fx_get_selection_internal)
6162 (Fx_disown_selection_internal, Fx_selection_owner_p)
6163 (Fx_selection_exists_p): New optional frame arg.
6164 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6165 (x_handle_selection_clear): Don't treat other terminals with the
6166 same keyboard specially. Use the terminal-local Vselection_alist.
6167 (x_clear_frame_selections): Use Frun_hook_with_args.
6168
6169 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6170
6171 * xterm.h: Add support for those atoms.
6172
6173 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6174
6175 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6176 (converted_selections, conversion_fail_tag): New global variables.
6177 (x_selection_request_lisp_error): Free the above.
6178 (x_get_local_selection): Remove unnecessary code.
6179 (x_reply_selection_request): Args changed; handle arbitrary array
6180 of converted selections stored in converted_selections.
6181 Separate the XChangeProperty and SelectionNotify steps.
6182 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6183 (x_convert_selection): New function.
6184 (x_handle_selection_event): Simplify.
6185 (x_get_foreign_selection): Don't ignore incoming requests while
6186 waiting for an answer; this will fail when we implement
6187 SAVE_TARGETS, and seems unnecessary anyway.
6188 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6189 (Vx_sent_selection_functions): Doc fix.
6190
6191 2011-05-26 Leo Liu <sdl.web@gmail.com>
6192
6193 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6194
6195 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6196
6197 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6198
6199 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6200 for fringe update if it has periodic bitmap.
6201 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6202 and fringe_bitmap_periodic_p.
6203
6204 * fringe.c (get_fringe_bitmap_data): New function.
6205 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6206 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6207 row. Mark glyph row for fringe update if periodicity changed.
6208
6209 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6210 for fringe update unless it has periodic bitmap.
6211
6212 2011-05-25 Kenichi Handa <handa@m17n.org>
6213
6214 * xdisp.c (get_next_display_element): Set correct it->face_id for
6215 a static composition.
6216
6217 2011-05-24 Leo Liu <sdl.web@gmail.com>
6218
6219 * deps.mk (fns.o):
6220 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6221
6222 * fns.c (crypto_hash_function, Fsha1): New function.
6223 (Fmd5): Use crypto_hash_function.
6224 (syms_of_fns): Add Ssha1.
6225
6226 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 * gnutls.c: Remove unused macros.
6229 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6230 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6231 Remove macros that are defined and never used.
6232 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6233
6234 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6235
6236 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6237 (Fx_get_selection_internal): Minor cleanup.
6238 (Fx_own_selection_internal): Rename arguments for consistency with
6239 select.el.
6240
6241 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6242
6243 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6244
6245 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6246
6247 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6248
6249 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6250
6251 * dispnew.c (scrolling_window): Don't exclude the case that the
6252 last enabled row in the desired matrix touches the bottom boundary.
6253
6254 2011-05-21 Glenn Morris <rgm@gnu.org>
6255
6256 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6257 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6258 and add some more files.
6259
6260 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6261
6262 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6263 report_file_error introduced by the change from 2011-05-07.
6264
6265 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6266
6267 * systime.h (Time): Define only if emacs is defined.
6268 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6269 where the include path doesn't have X11/X.h by default. See
6270 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6271
6272 2011-05-20 Kenichi Handa <handa@m17n.org>
6273
6274 * composite.c (find_automatic_composition): Fix previous change.
6275
6276 2011-05-20 Glenn Morris <rgm@gnu.org>
6277
6278 * lisp.mk: New file, split from Makefile.in.
6279 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6280 (shortlisp): Remove.
6281 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6282
6283 2011-05-19 Glenn Morris <rgm@gnu.org>
6284
6285 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6286 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6287 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6288 (lisp): Set the order to that of loadup.el.
6289 (shortlisp): Make it a copy of $lisp.
6290 (SOME_MACHINE_LISP): Remove.
6291 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6292 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6293
6294 2011-05-18 Kenichi Handa <handa@m17n.org>
6295
6296 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6297 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6298 (find_automatic_composition): Mostly rewrite for efficiency.
6299
6300 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6301
6302 * makefile.w32-in: Update dependencies.
6303
6304 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6305
6306 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6307 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6308
6309 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6310
6311 Fix some integer overflow issues, such as string length overflow.
6312
6313 * insdel.c (count_size_as_multibyte): Check for string overflow.
6314
6315 * character.c (lisp_string_width): Check for string overflow.
6316 Use EMACS_INT, not int, for string indexes and lengths; in
6317 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6318 the resulting string length overflows an EMACS_INT; instead,
6319 report a string overflow if no precision given. When checking for
6320 precision exhaustion, use a check that cannot possibly have
6321 integer overflow. (Bug#8675)
6322 * character.h (lisp_string_width): Adjust to new signature.
6323
6324 * alloc.c (string_overflow): New function.
6325 (Fmake_string): Use it. This doesn't change behavior, but saves
6326 a few bytes and will simplify future changes.
6327 * character.c (string_escape_byte8): Likewise.
6328 * lisp.h (string_overflow): New decl.
6329
6330 Fixups, following up to the user-interface timestamp change.
6331 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6332 for UI timestamps, instead of unsigned long.
6333 * msdos.c (mouse_get_pos): Likewise.
6334 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6335 * w32gui.h (Time): Define by including "systime.h" rather than by
6336 declaring it ourselves. (Bug#8664)
6337
6338 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6339 * image.c (clear_image_cache): Likewise.
6340
6341 * term.c (term_mouse_position): Don't assume time_t wraparound.
6342
6343 Be more systematic about user-interface timestamps.
6344 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6345 and sometimes 'EMACS_UINT', to represent these timestamps.
6346 This change causes it to use 'Time' uniformly, as that's what X uses.
6347 This makes the code easier to follow, and makes it easier to catch
6348 integer overflow bugs such as Bug#8664.
6349 * frame.c (Fmouse_position, Fmouse_pixel_position):
6350 Use Time, not unsigned long, for user-interface timestamps.
6351 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6352 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6353 * keyboard.h (last_event_timestamp): Likewise.
6354 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6355 * menu.h (xmenu_show): Likewise.
6356 * term.c (term_mouse_position): Likewise.
6357 * termhooks.h (struct input_event.timestamp): Likewise.
6358 (struct terminal.mouse_position_hook): Likewise.
6359 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6360 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6361 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6362 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6363 what it was before.
6364 * menu.h, termhooks.h: Include "systime.h", for Time.
6365
6366 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6367 Don't assume that the difference between two unsigned long values
6368 can fit into an integer. At this point, we know button_down_time
6369 <= event->timestamp, so the difference must be nonnegative, so
6370 there's no need to cast the result if double-click-time is
6371 nonnegative, as it should be; check that it's nonnegative, just in
6372 case. This bug is triggered when events are more than 2**31 ms
6373 apart (about 25 days). (Bug#8664)
6374
6375 * xselect.c (last_event_timestamp): Remove duplicate decl.
6376 (x_own_selection): Remove needless cast to unsigned long.
6377
6378 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6379 that always fit in int. Use a sentinel instead of a counter, to
6380 avoid a temp and to allay GCC's concerns about possible int overflow.
6381 * frame.h (struct frame): Use int for menu_bar_items_used
6382 instead of EMACS_INT, since it always fits in int.
6383
6384 * menu.c (grow_menu_items): Check for int overflow.
6385
6386 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6387
6388 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6389 Before, the code was not consistent. These values cannot exceed
6390 2**31 - 1 so there's no need to make them unsigned.
6391 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6392 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6393 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6394 as modifiers.
6395 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6396
6397 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6398 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6399 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6400 presumably because the widths might not match.
6401
6402 * window.c (size_window): Avoid needless test at loop start.
6403
6404 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6405
6406 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6407
6408 2011-05-12 Drew Adams <drew.adams@oracle.com>
6409
6410 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6411
6412 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6413
6414 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6415 `width' to `bar_area_x' and `bar_area_width', respectively.
6416 (x_scroll_run): Take account of fringe background extension.
6417
6418 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6419 Rename local vars `left' and `width' to `bar_area_x' and
6420 `bar_area_width', respectively.
6421 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6422 background extension.
6423
6424 2011-05-10 Jim Meyering <meyering@redhat.com>
6425
6426 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6427
6428 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6429
6430 * image.c (Finit_image_library): Return t for built-in image types,
6431 like pbm and xbm. (Bug#8640)
6432
6433 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6434
6435 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6436
6437 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6438
6439 * w32console.c (Fset_screen_color): Doc fix.
6440 (Fget_screen_color): New function.
6441 (syms_of_ntterm): Defsubr it.
6442
6443 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6444 unlink the temporary file if Fcall_process didn't create it in the
6445 first place.
6446 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6447 child process will be redirected to a file specified with `:file'.
6448 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6449 cue to call_process_cleanup not to close that handle.
6450
6451 2011-05-07 Ben Key <bkey76@gmail.com>
6452
6453 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6454 one of two shell specific rules, either bootstrap-temacs-CMD or
6455 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6456 to the previous implementation of the bootstrap-temacs rule.
6457 The bootstrap-temacs-CMD rule is similar to the previous
6458 implementation of the bootstrap-temacs rule except that it
6459 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6460 variable.
6461
6462 These changes, along with some changes to nt/configure.bat,
6463 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6464 earlier fix to add support for --cflags and --ldflags options
6465 that include quotes so that it works whether make uses cmd or
6466 sh as the shell.
6467
6468 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6469
6470 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6471 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6472 is a constant.
6473 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6474 a string. Handle both cases.
6475 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6476 (Fdbus_register_method): Use Qinvalid_function.
6477
6478 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6479
6480 * makefile.w32-in: Update dependencies.
6481 (LISP_H): Add inttypes.h and stdin.h.
6482 (PROCESS_H): Add unistd.h.
6483
6484 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6485
6486 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6487 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6488
6489 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6490
6491 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6492
6493 * term.c (vfatal): Remove stray call to va_end.
6494 It's not needed and the C Standard doesn't allow it here anyway.
6495
6496 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6497 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6498
6499 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6500 bytes.
6501
6502 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6503
6504 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6505
6506 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6507
6508 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6509
6510 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6511
6512 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6513 * charset.c (Fdefine_charset_internal): Don't initialize
6514 charset.code_space[15]. The value was garbage, on hosts with
6515 32-bit int (Bug#8600).
6516
6517 * lread.c (read_integer): Be more consistent with string-to-number.
6518 Use string_to_number to do the actual conversion; this avoids
6519 rounding errors and fixes some other screwups. Without this fix,
6520 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6521 (digit_to_number): Move earlier, for benefit of read_integer.
6522 Return -1 if the digit is out of range for the base, -2 if it is
6523 not a digit in any supported base. (Bug#8602)
6524
6525 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6526
6527 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6528 to match comment at start of function. This also removes a
6529 GCC warning about overflow in a 32+64-bit port.
6530
6531 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6532
6533 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6534 Reported by Stefan Monnier in
6535 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6536 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6537 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6538
6539 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6540 (EMACS_UINTPTR): Likewise, with uintptr_t.
6541
6542 * lisp.h: Prefer 64-bit EMACS_INT if available.
6543 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6544 on 32-bit hosts that have 64-bit int, so that they can access
6545 large files.
6546 However, temporarily disable this change unless the temporary
6547 symbol WIDE_EMACS_INT is defined.
6548
6549 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6550
6551 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6552 This removes an assumption that EMACS_INT and long are the same
6553 width as pointers. The assumption is true for Emacs porting targets
6554 now, but we want to make other targets possible.
6555 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6556 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6557 In the rest of the code, change types of integers that hold casted
6558 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6559 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6560 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6561 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6562 No need to cast type when ORing.
6563 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6564 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6565 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6566 assume EMACS_INT is the same width as char *.
6567 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6568 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6569 Remove no-longer-needed casts.
6570 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6571 (xg_tool_bar_help_callback, xg_make_tool_item):
6572 Use EMACS_INTPTR to hold an integer
6573 that will be cast to void *; this can avoid a GCC warning
6574 if EMACS_INT is not the same width as void *.
6575 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6576 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6577 (current_message_1, set_message_1):
6578 Use a local to convert to proper width without a cast.
6579 * xmenu.c (dialog_selection_callback): Likewise.
6580
6581 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6582 Also, don't assume VALBITS / RAND_BITS is less than 5,
6583 and don't rely on undefined behavior when shifting a 1 left into
6584 the sign bit.
6585 * lisp.h (get_random): Change signature to match.
6586
6587 * lread.c (hash_string): Use size_t, not int, for hash computation.
6588 Normally we prefer signed values; but hashing is special, because
6589 it's better to use unsigned division on hash table sizes so that
6590 the remainder is nonnegative. Also, size_t is the natural width
6591 for hashing into memory. The previous code used 'int', which doesn't
6592 retain enough info to hash well into very large tables.
6593 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6594
6595 * dbusbind.c: Don't possibly lose pointer info when converting.
6596 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6597 Use XPNTR rather than XHASH, so that the high-order bits of
6598 the pointer aren't lost when converting through void *.
6599
6600 * eval.c (Fautoload): Don't double-shift a pointer.
6601
6602 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6603
6604 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * gnutls.c (DEF_GNUTLS_FN):
6607 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6608
6609 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6610
6611 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6612 marker. (Bug#8610)
6613
6614 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6615
6616 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6617 New version that can reserve upto 2GB of heap space.
6618
6619 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6620
6621 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6622
6623 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6624
6625 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6626 `gnutls_certificate_set_x509_key_file'.
6627
6628 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6631 Update dependencies.
6632
6633 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6636 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6637 Remove unused parameter `fildes'.
6638 * process.c (read_process_output, send_process): Don't pass it.
6639
6640 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6641
6642 Fix previous change: the library cache is defined in w32.c.
6643 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6644 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6645
6646 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6647
6648 Implement dynamic loading of GnuTLS on Windows.
6649
6650 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6651 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6652 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6653 Declare.
6654
6655 * gnutls.c (Qgnutls_dll): Define.
6656 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6657 (gnutls_*): Declare function pointers.
6658 (init_gnutls_functions): New function to initialize function pointers.
6659 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6660 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6661 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6662 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6663 (emacs_gnutls_write, emacs_gnutls_read)
6664 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6665 (Fgnutls_available_p): New function.
6666 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6667 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6668 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6669
6670 * image.c: Include w32.h.
6671 (Vimage_type_cache): Delete.
6672 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6673 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6674 (w32_delayed_load): Move to w32.c.
6675
6676 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6677
6678 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6679 (w32_delayed_load): Move from image.c. When loading a library, record
6680 its filename in the :loaded-from property of the library id.
6681 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6682 Initialize and staticpro them.
6683 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6684
6685 * process.c: Include lisp.h before w32.h, not after.
6686 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6687 instead of gnutls_record_check_pending.
6688
6689 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6690
6691 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6692
6693 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6694 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6695 as passed in.
6696
6697 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6698
6699 * xterm.c (x_set_frame_alpha): Do not set property on anything
6700 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6701
6702 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6703
6704 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6705
6706 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6707
6708 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6709 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6710 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6711 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6712 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6713 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6714 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6715 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6716 (Qgnutls_bootprop_callbacks_verify): Make static.
6717
6718 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6719
6720 * callproc.c: Indentation fixup.
6721
6722 * sysdep.c (wait_for_termination_1): Make static.
6723 (wait_for_termination, interruptible_wait_for_termination):
6724 Move after wait_for_termination_1.
6725
6726 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6727
6728 * sysdep.c (interruptible_wait_for_termination): New function
6729 which is like wait_for_termination, but allows keyboard
6730 interruptions.
6731
6732 * callproc.c (Fcall_process): Add (:file "file") as an option for
6733 the STDOUT buffer.
6734 (Fcall_process_region): Ditto.
6735
6736 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6737
6738 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6739 rather than `XVECTOR (FOO)->size'.
6740
6741 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6742 inttypes.h, as a gnulib replacement is used if it not available in
6743 system headers.
6744
6745 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6746
6747 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6748 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6749 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6750
6751 * coding.c (coding_alloc_by_realloc): Error out if destination
6752 will grow beyond MOST_POSITIVE_FIXNUM.
6753 (decode_coding_emacs_mule): Abort if there isn't enough place in
6754 charbuf for the composition carryover bytes. Reserve an extra
6755 space for up to 2 characters produced in a loop.
6756 (decode_coding_iso_2022): Abort if there isn't enough place in
6757 charbuf for the composition carryover bytes.
6758
6759 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6760
6761 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6762 aborting when %lld or %lll format is passed.
6763 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6764 %llo or %llx format is passed. (Bug#8545)
6765
6766 * window.c (window_scroll_line_based): Use a marker instead of
6767 simple variables to record original value of point. (Bug#7952)
6768
6769 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6770 produced by %s or %c overflows available buffer space. (Bug#8545)
6771
6772 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6773
6774 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6775 (SIZE_MAX): Move defn after all includes, as they might #define it.
6776
6777 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6780
6781 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6782
6783 * keyboard.c (Qdelayed_warnings_hook): Define.
6784 (command_loop_1): Run `delayed-warnings-hook'
6785 if Vdelayed_warnings_list is non-nil.
6786 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6787 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6788
6789 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6790
6791 * doprnt.c (doprnt): Don't return value smaller than the buffer
6792 size if the message was truncated. (Bug#8545).
6793
6794 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6797 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6798
6799 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6800
6801 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6802
6803 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6804
6805 * makefile.w32-in: Update dependencies.
6806
6807 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6808
6809 Improve `doprnt' and its usage. (Bug#8545)
6810 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6811 `format_end'. Remove support for %l as a conversion specifier.
6812 Don't use xrealloc. Improve diagnostics when the %l size modifier
6813 is used. Update the commentary.
6814
6815 * eval.c (verror): Simplify calculation of size_t.
6816
6817 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6818 messages.
6819
6820 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6821
6822 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6823 change.
6824
6825 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6826
6827 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6828 This makes this file independent of the recent pseudovector change.
6829
6830 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6831
6832 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6833
6834 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6835 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6836 Remove unused local.
6837 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6838
6839 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6840 GCC 4.6.0 optimizes based on type-based alias analysis.
6841 For example, if b is of type struct buffer * and v of type struct
6842 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6843 != &v->size, and therefore "v->size = 1; b->size = 2; return
6844 v->size;" must therefore return 1. This assumption is incorrect
6845 for Emacs, since it type-puns struct Lisp_Vector * with many other
6846 types. To fix this problem, this patch adds a new type struct
6847 vectorlike_header that documents the constraints on layout of vectors
6848 and pseudovectors, and helps optimizing compilers not get fooled
6849 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6850 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6851 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6852 the size member.
6853 (XSETPVECTYPE): Rewrite in terms of new macro.
6854 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6855 This is a bit clearer, and further avoids the possibility of
6856 undesirable aliasing.
6857 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6858 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6859 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6860 since Lisp_Subr is a special case (no "next" field).
6861 (ASIZE): Now uses header.size rather than size.
6862 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6863 to avoid the hassle of writing XVECTOR (foo)->header.size.
6864 (struct vectorlike_header): New type.
6865 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6866 object, to help avoid aliasing.
6867 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6868 (SUBRP): Likewise, since Lisp_Subr is a special case.
6869 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6870 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6871 (struct Lisp_Hash_Table): Combine first two members into a single
6872 struct vectorlike_header member. All uses of "size" and "next" members
6873 changed to be "header.size" and "header.next".
6874 * buffer.h (struct buffer): Likewise.
6875 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6876 * frame.h (struct frame): Likewise.
6877 * process.h (struct Lisp_Process): Likewise.
6878 * termhooks.h (struct terminal): Likewise.
6879 * window.c (struct save_window_data, struct saved_window): Likewise.
6880 * window.h (struct window): Likewise.
6881 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6882 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6883 * buffer.c (init_buffer_once): Likewise.
6884 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6885 special case.
6886 * process.c (Fformat_network_address): Use local var for size,
6887 for brevity.
6888
6889 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6890
6891 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6892 * data.c (atof): Remove decl; no longer used or needed.
6893 (digit_to_number): Move to lread.c.
6894 (Fstring_to_number): Use new string_to_number function, to be
6895 consistent with how the Lisp reader treats infinities and NaNs.
6896 Do not assume that floating-point numbers represent EMACS_INT
6897 without losing information; this is not true on most 64-bit hosts.
6898 Avoid double-rounding errors, by insisting on integers when
6899 parsing non-base-10 numbers, as the documentation specifies.
6900 * lisp.h (string_to_number): New decl, replacing ...
6901 (isfloat_string): Remove.
6902 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6903 (read1): Do not accept +. and -. as integers; this
6904 appears to have been a coding error. Similarly, do not accept
6905 strings like +-1e0 as floating point numbers. Do not report
6906 overflow for integer overflows unless the base is not 10 which
6907 means we have no simple and reliable way to continue.
6908 Break out the floating-point parsing into a new
6909 function string_to_number, so that Fstring_to_number parses
6910 floating point numbers consistently with the Lisp reader.
6911 (digit_to_number): Move here from data.c. Make it static inline.
6912 (E_CHAR, EXP_INT): Remove, replacing with ...
6913 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6914 (string_to_number): New function, replacing isfloat_string.
6915 This function checks for valid syntax and produces the resulting
6916 Lisp float number too. Rework it so that string-to-number
6917 no longer mishandles examples like "1.0e+". Use strtoumax,
6918 so that overflow for non-base-10 numbers is reported only when
6919 there's no portable and simple way to convert to floating point.
6920
6921 * textprop.c (set_text_properties_1): Rewrite for clarity,
6922 and to avoid GCC warning about integer overflow.
6923
6924 * intervals.h (struct interval): Use EMACS_INT for members
6925 where EMACS_UINT might cause problems. See
6926 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6927 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6928 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6929 All uses changed.
6930 (offset_intervals): Tell GCC not to worry about length overflow
6931 when negating a negative length.
6932
6933 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6934 (overrun_check_free): Likewise.
6935
6936 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6937 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6938 word size.
6939
6940 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6941 (gnutls_make_error): Rename local to avoid shadowing.
6942 (gnutls_emacs_global_deinit): ifdef out; not used.
6943 (Fgnutls_boot): Use const for pointer to readonly storage.
6944 Comment out unused local. Fix pointer signedness problems.
6945
6946 * lread.c (openp): Don't stuff size_t into an 'int'.
6947 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6948 about possible signed overflow.
6949
6950 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6951 (GDK_KEY_g): Don't define if already defined.
6952 (xg_prepare_tooltip): Avoid pointer signedness problem.
6953 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6954
6955 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6956 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6957
6958 * xfns.c (Fx_window_property): Simplify a bit,
6959 to make a bit faster and to avoid GCC 4.6.0 warning.
6960 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6961
6962 * fns.c (internal_equal): Don't assume size_t fits in int.
6963
6964 * alloc.c (compact_small_strings): Tighten assertion a little.
6965
6966 Replace pEd with more-general pI, and fix some printf arg casts.
6967 * lisp.h (pI): New macro, generalizing old pEd macro to other
6968 conversion specifiers. For example, use "...%"pI"d..." rather
6969 than "...%"pEd"...".
6970 (pEd): Remove. All uses replaced with similar uses of pI.
6971 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6972 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6973 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6974 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6975 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6976 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6977 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6978 64-bit hosts.
6979 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6980 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6981 * print.c (safe_debug_print, print_object): Likewise.
6982 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6983 to int.
6984 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6985 avoiding the 0 flag, which is not portable.
6986 * process.c (Fmake_network_process): Use pI to avoid cast.
6987 * region-cache.c (pp_cache): Likewise.
6988 * xdisp.c (decode_mode_spec): Likewise.
6989 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6990 behavior on 64-bit hosts with printf arg.
6991 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6992 (x_stop_queuing_selection_requests): Likewise.
6993 (x_get_window_property): Don't truncate byte count to an 'int'
6994 when tracing.
6995
6996 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6997 here, since it parses constructs like leading '-' and spaces,
6998 which are not wanted; and it overflows with large numbers.
6999 Instead, simply match F[0-9]+, which is what is wanted anyway.
7000
7001 * alloc.c: Remove unportable assumptions about struct layout.
7002 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7003 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7004 (allocate_vectorlike, make_pure_vector): Use the new macros,
7005 plus offsetof, to remove unportable assumptions about struct layout.
7006 These assumptions hold on all porting targets that I know of, but
7007 they are not guaranteed, they're easy to remove, and removing them
7008 makes further changes easier.
7009
7010 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7011 This doesn't fix a bug but makes the code clearer.
7012 (string_overrun_cookie): Now const. Use initializers that
7013 don't formally overflow signed char, to avoid warnings.
7014 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7015 can cause Emacs to crash when string overrun checking is enabled.
7016 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7017 multiple of sizeof (EMACS_INT); it need not be, if
7018 alignof(EMACS_INT) < sizeof (EMACS_INT).
7019 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7020
7021 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7024
7025 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7026
7027 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7028 supposed to be handshaking. (Bug#8556)
7029 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7030
7031 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7032
7033 * lisp.h (Qdebug): List symbol.
7034 * eval.c (Qdebug): Restore global linkage.
7035 * keyboard.c (debug-on-event): New variable.
7036 (handle_user_signal): Break into debugger when debug-on-event
7037 matches the current signal symbol.
7038
7039 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7040
7041 * alloc.c (check_sblock, check_string_bytes)
7042 (check_string_free_list): Convert to standard C.
7043
7044 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7045
7046 * w32.c (emacs_gnutls_push): Fix typo.
7047
7048 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7049
7050 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7051 "cast to pointer from integer of different size".
7052
7053 Improve doprnt and its use in verror. (Bug#8545)
7054 * doprnt.c (doprnt): Document the set of format control sequences
7055 supported by the function. Use SAFE_ALLOCA instead of always
7056 using `alloca'.
7057
7058 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7059 is one byte too soon. Don't use xrealloc; instead xfree and
7060 xmalloc anew.
7061
7062 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7063
7064 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7065 callbacks stage.
7066
7067 * gnutls.c: Renamed global_initialized to
7068 gnutls_global_initialized. Added internals for the
7069 :verify-hostname-error, :verify-error, and :verify-flags
7070 parameters of `gnutls-boot' and documented those parameters in the
7071 docstring. Start callback support.
7072 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7073 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7074 on error. Return error code.
7075 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7076 (emacs_gnutls_read): Likewise.
7077 (Fgnutls_boot): Return handshake error code.
7078 (emacs_gnutls_handle_error): New function.
7079 (wsaerror_to_errno): Likewise.
7080
7081 * w32.h (emacs_gnutls_pull): Add prototype.
7082 (emacs_gnutls_push): Likewise.
7083
7084 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7085 (emacs_gnutls_push): Likewise.
7086
7087 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7088
7089 * process.c (wait_reading_process_output): Check if GnuTLS
7090 buffered some data internally if no FDs are set for TLS
7091 connections.
7092
7093 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7094 (LIBS): Link to USER_LIBS.
7095 ($(BLD)/gnutls.$(0)): New target.
7096
7097 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7098
7099 * xdisp.c (handle_single_display_spec): Rename the
7100 display_replaced_before_p argument into display_replaced_p, to
7101 make it consistent with the commentary. Fix typos in the
7102 commentary.
7103
7104 * textprop.c (syms_of_textprop): Remove dead code.
7105 (copy_text_properties): Delete obsolete commentary about an
7106 interface that was deleted long ago. Fix typos in the description
7107 of arguments.
7108
7109 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7110 to changes in oldXMenu/XMenu.h from 2011-04-16.
7111 <menu_help_message, prev_menu_help_message>: Constify.
7112 (IT_menu_make_room): menu->help_text is now `const char **';
7113 adjust.
7114
7115 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7116 to changes in oldXMenu/XMenu.h from 2011-04-16.
7117 (struct XMenu): Declare `help_text' `const char **'.
7118
7119 * xfaces.c <Qunspecified>: Make extern again.
7120
7121 * syntax.c: Include sys/types.h before including regex.h, as
7122 required by Posix.
7123
7124 * doc.c (get_doc_string): Improve the format passed to `error'.
7125
7126 * doprnt.c (doprnt): Improve commentary.
7127
7128 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7129
7130 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7131 them with etags.
7132
7133 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7134 changes in globals.h immediately force recompilation.
7135 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7136 $(CURDIR)/s/ms-w32.h.
7137 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7138
7139 * character.c (Fchar_direction): Function deleted.
7140 (syms_of_character): Don't defsubr it.
7141 <char-direction-table>: Deleted.
7142
7143 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7144
7145 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7146 * doprnt.c: Include limits.h.
7147 (SIZE_MAX): New macro.
7148 (doprnt): Return a size_t value. 2nd arg is now size_t.
7149 Many local variables are now size_t instead of int or unsigned.
7150 Improve overflow protection. Support `l' modifier for integer
7151 conversions. Support %l conversion. Don't assume an EMACS_INT
7152 argument for integer conversions and for %c.
7153
7154 * lisp.h (doprnt): Restore prototype.
7155
7156 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7157 $(SRC)/character.h.
7158
7159 * Makefile.in (base_obj): Add back doprnt.o.
7160
7161 * deps.mk (doprnt.o): Add back prerequisites.
7162 (callint.o): Depend on character.h.
7163
7164 * eval.c (internal_lisp_condition_case): Include the handler
7165 representation in the error message.
7166 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7167 when breaking from the loop.
7168
7169 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7170
7171 * callint.c (Fcall_interactively): When displaying error message
7172 about invalid control letter, pass the character's codepoint, not
7173 a pointer to its multibyte form. Improve display of the character
7174 in octal and display also its hex code.
7175
7176 * character.c (char_string): Use %x to display the (unsigned)
7177 codepoint of an invalid character, to avoid displaying a bogus
7178 negative value.
7179
7180 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7181 `error', not SYMBOL_NAME itself.
7182
7183 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7184 character arguments to `error'.
7185
7186 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7187 to `error' in error message about FINAL_CHAR argument. Make sure
7188 FINAL_CHAR is a character, and use %c when it is passed as
7189 argument to `error'.
7190
7191 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7192
7193 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7194
7195 * w32.c: Include <time.h>.
7196 (sys_localtime): New function.
7197
7198 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7199
7200 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7201
7202 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7203
7204 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7205
7206 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7207 zombies (Bug#8467).
7208
7209 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7210
7211 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7212 gl_state.e_property when gl_state.object is Qt.
7213
7214 * insdel.c (make_gap_larger): Remove limitation of buffer size
7215 to <= INT_MAX.
7216
7217 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7218
7219 * xdisp.c (lookup_glyphless_char_display)
7220 (produce_glyphless_glyph): Handle cons cell entry in
7221 glyphless-char-display.
7222 (Vglyphless_char_display): Document it.
7223
7224 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7225 glyphless-char-display.
7226
7227 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7228
7229 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7230
7231 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7232
7233 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7234 definition for no-X builds.
7235
7236 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7237
7238 Static checks with GCC 4.6.0 and non-default toolkits.
7239
7240 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7241
7242 * process.c (keyboard_bit_set): Define only if SIGIO.
7243 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7244 (send_process): Repair possible setjmp clobbering.
7245
7246 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7247
7248 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7249
7250 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7251
7252 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7253 Define only if needed.
7254
7255 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7256 by pacifying GCC about it. Maybe it's time to retire it?
7257 * xfaces.c (USG, __TIMEVAL__): Likewise.
7258
7259 * dispextern.h (struct redisplay_interface): Rename param
7260 to avoid shadowing.
7261 * termhooks.h (struct terminal): Likewise.
7262 * xterm.c (xembed_send_message): Likewise.
7263
7264 * insdel.c (make_gap_smaller): Define only if
7265 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7266
7267 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7268 it.
7269
7270 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7271 so that we aren't warned about unused symbols.
7272
7273 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7274
7275 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7276
7277 * xfns.c (x_real_positions): Mark locals as initialized.
7278
7279 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7280
7281 * xterm.c: Fix problems found by static analysis with other toolkits.
7282 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7283 (x_dispatch_event): Declare static if USE_GTK, and
7284 define if USE_GTK || USE_X_TOOLKIT.
7285 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7286 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7287 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7288 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7289
7290 * xmenu.c (menu_help_callback): Pointer type fixes.
7291 Use const pointers when pointing at readonly data. Avoid pointer
7292 signedness clashes.
7293 (FALSE): Remove unused macro.
7294 (update_frame_menubar): Remove unused decl.
7295
7296 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7297
7298 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7299 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7300 (single_menu_item): Rename local to avoid shadowing.
7301
7302 * keyboard.c (make_lispy_event): Remove unused local var.
7303
7304 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7305 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7306
7307 * bitmaps: Change bitmaps from unsigned char back to the X11
7308 compatible char. Avoid the old compiler warnings about
7309 out-of-range initializers by using, for example, '\xab' rather
7310 than 0xab.
7311
7312 * xgselect.c (xgselect_initialize): Check vs interface
7313 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7314
7315 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7316
7317 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7318 to read-only memory.
7319
7320 * fns.c (vector): Remove; this old hack is no longer needed.
7321
7322 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7323 Remove unused var.
7324 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7325
7326 * xrdb.c (x_load_resources): Omit unused local.
7327
7328 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7329 (x_window): Rename locals to avoid shadowing.
7330 (USG): Use the kludged USG macro, to pacify gcc.
7331
7332 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7333 (x_term_init): Remove local to avoid shadowing.
7334
7335 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7336
7337 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7338 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7339
7340 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7341
7342 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7343
7344 Fix regex.c, syntax.c and friends for buffers > 2GB.
7345 * syntax.h (struct gl_state_s): Declare character position members
7346 EMACS_INT.
7347
7348 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7349
7350 * textprop.c (verify_interval_modification, interval_of):
7351 Declare arguments EMACS_INT.
7352
7353 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7354 EMACS_INT.
7355
7356 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7357
7358 * indent.c (Fvertical_motion): Local variable it_start is now
7359 EMACS_INT.
7360
7361 * regex.c (re_match, re_match_2, re_match_2_internal)
7362 (bcmp_translate, regcomp, regexec, print_double_string)
7363 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7364 (re_compile_pattern, re_exec): Declare arguments and local
7365 variables `size_t' and `ssize_t' and return values `regoff_t', as
7366 appropriate.
7367 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7368 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7369 <compile_stack_type>: `size' and `avail' are now `size_t'.
7370
7371 * regex.h <regoff_t>: Use ssize_t, not int.
7372 (re_search, re_search_2, re_match, re_match_2): Arguments that
7373 specify buffer/string position and length are now ssize_t and
7374 size_t. Return type is regoff_t.
7375
7376 2011-04-16 Ben Key <bkey76@gmail.com>
7377
7378 * nsfont.m: Fixed bugs in ns_get_family and
7379 ns_descriptor_to_entity that were caused by using free to
7380 deallocate memory blocks that were allocated by xmalloc (via
7381 xstrdup). This caused Emacs to crash when compiled with
7382 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7383 --enable-checking=xmallocoverrun). xfree is now used to
7384 deallocate these memory blocks.
7385
7386 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7387
7388 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7389
7390 emacs_write: Accept and return EMACS_INT for sizes.
7391 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7392 et seq.
7393 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7394 Accept and return EMACS_INT.
7395 (emacs_gnutls_write): Return the number of bytes written on
7396 partial writes.
7397 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7398 (emacs_read, emacs_write): Remove check for negative size, as the
7399 Emacs source code has been audited now.
7400 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7401 (emacs_read, emacs_write): Use it.
7402 * process.c (send_process): Adjust to the new signatures of
7403 emacs_write and emacs_gnutls_write. Do not attempt to store
7404 a byte offset into an 'int'; it might overflow.
7405 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7406
7407 * sound.c: Don't assume sizes fit in 'int'.
7408 (struct sound_device.period_size, alsa_period_size):
7409 Return EMACS_INT, not int.
7410 (struct sound_device.write, vox_write, alsa_write):
7411 Accept EMACS_INT, not int.
7412 (wav_play, au_play): Use EMACS_INT to store sizes and to
7413 record read return values.
7414
7415 2011-04-15 Ben Key <bkey76@gmail.com>
7416
7417 * keyboard.c (Qundefined): Don't declare static since it is used
7418 in nsfns.m.
7419 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7420 static since they are used in nsfont.m.
7421
7422 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7423
7424 * process.c (Qprocessp): Don't declare static.
7425 * lisp.h (Qprocessp): Declare again.
7426
7427 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7428
7429 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7430
7431 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7432
7433 Improve C-level modularity by making more things 'static'.
7434
7435 Don't publish debugger-only interfaces to other modules.
7436 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7437 (verify_bytepos, count_markers): Move decls to the only modules
7438 that need them.
7439 * region-cache.h (pp_cache): Likewise.
7440 * window.h (check_all_windows): Likewise.
7441 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7442
7443 * sysdep.c (croak): Now static, if
7444 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7445 * syssignal.h (croak): Declare only if not static.
7446
7447 * alloc.c (refill_memory_reserve): Now static if
7448 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7449 * lisp.h (refill_memory_reserve): Declare only if not static.
7450
7451 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7452 Define only if USE_LUCID.
7453
7454 * xrdb.c (x_customization_string, x_rm_string): Now static.
7455
7456 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7457 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7458
7459 * xdisp.c (draw_row_with_mouse_face): Now static.
7460 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7461
7462 * window.h (check_all_windows): Mark externally visible.
7463
7464 * window.c (window_deletion_count): Now static.
7465
7466 * undo.c: Make symbols static if they're not exported.
7467 (last_undo_buffer, last_boundary_position, pending_boundary):
7468 Now static.
7469
7470 * textprop.c (interval_insert_behind_hooks): Now static.
7471 (interval_insert_in_front_hooks): Likewise.
7472
7473 * term.c: Make symbols static if they're not exported.
7474 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7475 (max_frame_lines, tty_set_terminal_modes):
7476 (tty_reset_terminal_modes, tty_turn_off_highlight):
7477 (get_tty_terminal): Now static.
7478 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7479 * termhooks.h (term_mouse_moveto): Do not declare if
7480 HAVE_WINDOW_SYSTEM.
7481 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7482 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7483
7484 * sysdep.c: Make symbols static if they're not exported.
7485 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7486 Now static.
7487 (sigprocmask_set, full_mask): Remove; unused.
7488 (wait_debugging): Mark as visible.
7489 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7490 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7491
7492 * syntax.c (syntax_temp): Define only if !__GNUC__.
7493
7494 * sound.c (current_sound_device, current_sound): Now static.
7495
7496 * search.c (searchbufs, searchbuf_head): Now static.
7497
7498 * scroll.c (scroll_cost): Remove; unused.
7499 * dispextern.h (scroll_cost): Remove decl.
7500
7501 * region-cache.h (pp_cache): Mark as externally visible.
7502
7503 * process.c: Make symbols static if they're not exported.
7504 (process_tick, update_tick, create_process, chan_process):
7505 (Vprocess_alist, proc_buffered_char, datagram_access):
7506 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7507 (deactivate_process): Mark defn as static, as well as decl.
7508 * lisp.h (create_process): Remove decl.
7509 * process.h (chan_process, Vprocess_alist): Remove decls.
7510
7511 * print.c: Make symbols static if they're not exported.
7512 (print_depth, new_backquote_output, being_printed, print_buffer):
7513 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7514 (print_interval, print_number_index, initial_stderr_stream):
7515 Now static.
7516 * lisp.h (Fprinc): Remove decl.
7517 (debug_output_compilation_hack): Mark as externally visible.
7518
7519 * sysdep.c (croak): Move decl from here to syssignal.h.
7520 * syssignal.h (croak): Put it here, so the API can be checked when
7521 'croak' is called from dissociate_if_controlling_tty.
7522
7523 * minibuf.c: Make symbols static if they're not exported.
7524 (minibuf_save_list, choose_minibuf_frame): Now static.
7525 * lisp.h (choose_minibuf_frame): Remove decl.
7526
7527 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7528
7529 * lread.c: Make symbols static if they're not exported.
7530 (read_objects, initial_obarray, oblookup_last_bucket_number):
7531 Now static.
7532 (make_symbol): Remove; unused.
7533 * lisp.h (initial_obarray, make_symbol): Remove decls.
7534
7535 * keyboard.c: Make symbols static if they're not exported.
7536 (single_kboard, recent_keys_index, total_keys, recent_keys):
7537 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7538 (this_single_command_key_start, echoing, last_auto_save):
7539 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7540 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7541 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7542 (Vlispy_mouse_stem, double_click_count):
7543 Now static.
7544 (force_auto_save_soon): Define only if SIGDANGER.
7545 (ignore_mouse_drag_p): Now static if
7546 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7547 (print_help): Remove; unused.
7548 (stop_character, last_timer_event): Mark as externally visible.
7549 * keyboard.h (ignore_mouse_drag_p): Declare only if
7550 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7551 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7552 * lisp.h (echoing): Remove decl.
7553 (force_auto_save_soon): Declare only if SIGDANGER.
7554 * xdisp.c (redisplay_window): Simplify code, to make it more
7555 obvious that ignore_mouse_drag_p is not accessed if !defined
7556 USE_GTK && !defined HAVE_NS.
7557
7558 * intervals.c: Make symbols static if they're not exported.
7559 (merge_properties_sticky, merge_interval_right, delete_interval):
7560 Now static.
7561 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7562
7563 * insdel.c: Make symbols static if they're not exported.
7564 However, leave prepare_to_modify_buffer alone. It's never
7565 called from outside this function, but that appears to be a bug.
7566 (combine_after_change_list, combine_after_change_buffer):
7567 (adjust_after_replace, signal_before_change): Now static.
7568 (adjust_after_replace_noundo): Remove; unused.
7569 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7570 (signal_before_change): Remove decls.
7571
7572 * indent.c (val_compute_motion, val_vmotion): Now static.
7573
7574 * image.c: Make symbols static if they're not exported.
7575 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7576 if USE_GTK.
7577 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7578 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7579
7580 * fringe.c (standard_bitmaps): Now static.
7581 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7582
7583 * frame.c: Make symbols static if they're not exported.
7584 (x_report_frame_params, make_terminal_frame): Now static.
7585 (get_frame_param): Now static, unless HAVE_NS.
7586 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7587 (x_get_resource_string): Remove; not used.
7588 * frame.h (make_terminal_frame, x_report_frame_params):
7589 (x_get_resource_string); Remove decls.
7590 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7591 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7592
7593 * font.c, fontset.c: Make symbols static if they're not exported.
7594 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7595 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7596 * font.c (font_close_object): Now static.
7597 * font.h (font_close_object): Remove.
7598 * fontset.c (FONTSET_OBJLIST): Remove.
7599 (free_realized_fontset) #if-0 the body, which does nothing.
7600 (face_suitable_for_char_p): #if-0, as it's never called.
7601 * fontset.h (face_suitable_for_char_p): Remove decl.
7602 * xfaces.c (face_at_string_position):
7603 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7604 since 0 is always ASCII.
7605
7606 * fns.c (weak_hash_tables): Now static.
7607
7608 * fileio.c: Make symbols static if they're not exported.
7609 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7610 (Vwrite_region_annotation_buffers): Now static.
7611
7612 * eval.c: Make symbols static if they're not exported.
7613 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7614 * lisp.h (backtrace_list): Remove decl.
7615
7616 * emacs.c: Make symbols static if they're not exported.
7617 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7618 (fatal_error_code, fatal_error_signal_hook, standard_args):
7619 Now static.
7620 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7621 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7622 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7623 * lisp.h (fatal_error_signal_hook): Remove decl.
7624 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7625
7626 * editfns.c: Move a (normally-unused) function to its only use.
7627 * editfns.c, lisp.h (get_operating_system_release): Remove.
7628 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7629 worth the hassle of breaking this out.
7630
7631 * xterm.c: Make symbols static if they're not exported.
7632 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7633 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7634 (x_destroy_window, x_delete_display):
7635 Now static.
7636 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7637 (x_mouse_leave): Remove; unused.
7638 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7639 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7640 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7641 Remove decls.
7642 (x_mouse_leave): Declare only if WINDOWSNT.
7643 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7644 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7645 USE_X_TOOLKIT.
7646
7647 * ftxfont.c: Make symbols static if they're not exported.
7648 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7649 HAVE_FREETYPE.
7650 * font.h (ftxfont_driver): Likewise.
7651
7652 * xfns.c: Make symbols static if they're not exported.
7653 (x_last_font_name, x_display_info_for_name):
7654 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7655 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7656 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7657 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7658 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7659 (last_show_tip_args): Now static.
7660 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7661 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7662 (x_screen_planes): Remove; unused.
7663 * dispextern.h (x_screen_planes): Remove decl.
7664
7665 * dispnew.c: Make symbols static if they're not exported.
7666 * dispextern.h (redraw_garbaged_frames, scrolling):
7667 (increment_row_positions): Remove.
7668 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7669 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7670 Now static.
7671 (redraw_garbaged_frames): Remove; unused.
7672
7673 * xfaces.c: Make symbols static if they're not exported.
7674 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7675 Remove decls.
7676 * xterm.h (defined_color): Remove decls.
7677 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7678 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7679 (menu_face_changed_default, defined_color, free_realized_face):
7680 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7681 (ascii_face_of_lisp_face): Remove; unused.
7682
7683 * xdisp.c: Make symbols static if they're not exported.
7684 * dispextern.h (scratch_glyph_row, window_box_edges):
7685 (glyph_to_pixel_coords, set_cursor_from_row):
7686 (get_next_display_element, set_iterator_to_next):
7687 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7688 (show_mouse_face): Remove decls
7689 * frame.h (message_buf_print): Likewise.
7690 * lisp.h (pop_message, set_message, check_point_in_composition):
7691 Likewise.
7692 * xterm.h (set_vertical_scroll_bar): Likewise.
7693 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7694 (message_buf_print, scratch_glyph_row, displayed_buffer):
7695 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7696 (get_next_display_element, show_mouse_face, window_box_edges):
7697 (frame_to_window_pixel_xy, check_point_in_composition):
7698 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7699 (glyph_to_pixel_coords): Remove; unused.
7700
7701 * dired.c (file_name_completion): Now static.
7702
7703 * dbusbind.c (xd_in_read_queued_messages): Now static.
7704
7705 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7706 * data.c (circular_list_error): Remove.
7707
7708 * commands.h (last_point_position, last_point_position_buffer):
7709 (last_point_position_window): Remove decls.
7710 * keyboard.c: Make these variables static.
7711
7712 * coding.h (coding, code_convert_region, encode_coding_gap):
7713 Remove decls.
7714 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7715 (iso_code_class, detect_coding, code_convert_region): Now static.
7716 (encode_coding_gap): Remove; unused.
7717
7718 * chartab.c (chartab_chars, chartab_bits): Now static.
7719
7720 * charset.h (charset_iso_8859_1): Remove decl.
7721 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7722 Now static.
7723
7724 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7725 * ccl.c (Vccl_program_table): Now static.
7726 (check_ccl_update): Remove; unused.
7727
7728 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7729 * category.h: ... from here.
7730 * category.c (check_category_table, set_category_set): Now static.
7731
7732 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7733 * lisp.h: Remove these decls.
7734
7735 * buffer.c (buffer_count): Remove unused var.
7736
7737 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7738 so that it's not optimized away.
7739 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7740 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7741 exported only to the debugger.
7742
7743 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7744 * atimer.h (run_all_atimers): Remove; not exported.
7745
7746 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7747 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7748 was inaccessible from Lisp.
7749 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7750 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7751
7752 alloc.c: Import and export fewer symbols, and remove unused items.
7753 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7754 is defined.
7755 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7756 it's not optimized away by whole-program optimization.
7757 (message_enable_multibyte, free_misc): Remove.
7758 (catchlist, handlerlist, mark_backtrace):
7759 Declare only if BYTE_MARK_STACK.
7760 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7761 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7762 (message_enable_multibyte): Remove decl.
7763 (free_misc, interval_free_list, float_block, float_block_index):
7764 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7765 (cons_free_list, last_marked_index):
7766 Now static.
7767 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7768 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7769 (mark_backtrace): Define only if BYTE_MARK_STACK.
7770 * xdisp.c (message_enable_multibyte): Now static.
7771
7772 Declare Lisp_Object Q* variables to be 'static' if not exported.
7773 This makes it easier for human readers (and static analyzers)
7774 to see whether these variables are used from other modules.
7775 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7776 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7777 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7778 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7779 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7780 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7781 * xmenu.c, xselect.c:
7782 Declare Q* vars static if they are not used in other modules.
7783 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7784 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7785 Remove decls of unexported vars.
7786 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7787
7788 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7789
7790 Make Emacs functions such as Fatom 'static' by default.
7791 This makes it easier for human readers (and static analyzers)
7792 to see whether these functions can be called from other modules.
7793 DEFUN now defines a static function. To make the function external
7794 so that it can be used in other C modules, use the new macro DEFUE.
7795 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7796 (Finit_image_library):
7797 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7798 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7799 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7800 Remove decls, since these functions are now static.
7801 (Funintern, Fget_internal_run_time): New decls, since these functions
7802 were already external.
7803
7804 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7805 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7806 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7807 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7808 * keyboard.c, keymap.c, lread.c:
7809 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7810 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7811 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7812 Mark functions with DEFUE instead of DEFUN,
7813 if they are used in other modules.
7814 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7815 decls for now-static functions.
7816 * buffer.h (Fdelete_overlay): Remove decl.
7817 * callproc.c (Fgetenv_internal): Mark as internal.
7818 * composite.c (Fremove_list_of_text_properties): Remove decl.
7819 (Fcomposition_get_gstring): New forward static decl.
7820 * composite.h (Fcomposite_get_gstring): Remove decl.
7821 * dired.c (Ffile_attributes): New forward static decl.
7822 * doc.c (Fdocumntation_property): New forward static decl.
7823 * eval.c (Ffetch_bytecode): New forward static decl.
7824 (Funintern): Remove extern decl; now in .h file where it belongs.
7825 * fileio.c (Fmake_symbolic_link): New forward static decl.
7826 * image.c (Finit_image_library): New forward static decl.
7827 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7828 * intervals.h (Fprevious_property_change):
7829 (Fremove_list_of_text_properties): Remove decls.
7830 * keyboard.c (Fthis_command_keys): Remove decl.
7831 (Fcommand_execute): New forward static decl.
7832 * keymap.c (Flookup_key): New forward static decl.
7833 (Fcopy_keymap): Now static.
7834 * keymap.h (Flookup_key): Remove decl.
7835 * process.c (Fget_process): New forward static decl.
7836 (Fprocess_datagram_address): Mark as internal.
7837 * syntax.c (Fsyntax_table_p): New forward static decl.
7838 (skip_chars): Remove duplicate decl.
7839 * textprop.c (Fprevious_property_change): New forward static decl.
7840 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7841 Now internal.
7842 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7843 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7844
7845 * editfns.c (Fformat): Remove unreachable code.
7846
7847 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7848
7849 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7850 change. (Bug#8496)
7851
7852 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7853
7854 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7855 when at ZV. (Bug#8487)
7856
7857 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7858
7859 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7860 (Bug#8437)
7861 * keyboard.c (parse_tool_bar_item): Likewise.
7862 * sound.c (sound_cleanup, alsa_close): Likewise.
7863 * termcap.c (tgetent): Likewise.
7864 * xfns.c (x_default_font_parameter): Likewise.
7865 * xsettings.c (read_and_apply_settings): Likewise.
7866
7867 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7868 (overrun_check_free): Protoize.
7869
7870 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7871
7872 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7873 since callers should never pass a negative size.
7874 Change the signature to match that of plain 'read' and 'write'; see
7875 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7876 * lisp.h: Update prototypes of emacs_write and emacs_read.
7877
7878 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7879
7880 * xdisp.c (redisplay_window): Don't try to determine the character
7881 position of the scroll margin if the window start point w->startp
7882 is outside the buffer's accessible region. (Bug#8468)
7883
7884 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7885
7886 Fix write-region and its subroutines for buffers > 2GB.
7887 * fileio.c (a_write, e_write): Modify declaration of arguments and
7888 local variables to support buffers larger than 2GB.
7889 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7890
7891 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7892 argument, local variables, and return value.
7893
7894 * lisp.h: Update prototypes of emacs_write and emacs_read.
7895
7896 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7897
7898 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7899
7900 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7901
7902 Fix more problems found by GCC 4.6.0's static checks.
7903
7904 * xdisp.c (vmessage): Use a better test for character truncation.
7905
7906 * charset.c (load_charset_map): <, not <=, for optimization,
7907 and to avoid potential problems with integer overflow.
7908 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7909 * casetab.c (set_identity, shuffle): Likewise.
7910 * editfns.c (Fformat): Likewise.
7911 * syntax.c (skip_chars): Likewise.
7912
7913 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7914 This also lets GCC 4.6.0 generate slightly better loop code.
7915
7916 * callint.c (Fcall_interactively): <, not <=, for optimization.
7917 (Fcall_interactively): Count the number of arguments produced,
7918 not the number of arguments given. This is simpler and lets GCC
7919 4.6.0 generate slightly better code.
7920
7921 * ftfont.c: Distingish more carefully between FcChar8 and char.
7922 The previous code passed unsigned char * to a functions like
7923 strlen and xstrcasecmp that expect char *, which does not
7924 conform to the C standard.
7925 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7926 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7927 char * when the C standard requires it.
7928
7929 * keyboard.c (read_char): Remove unused var.
7930
7931 * eval.c: Port to Windows vsnprintf (Bug#8435).
7932 Include <limits.h>.
7933 (SIZE_MAX): Define if the headers do not.
7934 (verror): Do not give up if vsnprintf returns a negative count.
7935 Instead, grow the buffer. This ports to Windows vsnprintf, which
7936 does not conform to C99. Problem reported by Eli Zaretskii.
7937 Also, simplify the allocation scheme, by avoiding the need for
7938 calling realloc, and removing the ALLOCATED variable.
7939
7940 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7941
7942 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7943 But keep the doprint source code for now, as we might revamp it
7944 and use it again (Bug#8435).
7945 * lisp.h (doprnt): Remove.
7946 * Makefile.in (base_obj): Remove doprnt.o.
7947 * deps.mk (doprnt.o): Remove.
7948
7949 error: Print 32- and 64-bit integers portably (Bug#8435).
7950 Without this change, on typical 64-bit hosts error ("...%d...", N)
7951 was used to print both 32- and 64-bit integers N, which relied on
7952 undefined behavior.
7953 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7954 * lisp.h (error, verror): Mark as printf-like functions.
7955 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7956 Report overflow in size calculations when allocating printf buffer.
7957 Do not truncate output string at its first null byte.
7958 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7959 Truncate the output at a character boundary, since vsnprintf does not
7960 do that.
7961 * charset.c (check_iso_charset_parameter): Convert internal
7962 character to string before calling 'error', since %c now has the
7963 printf meaning.
7964 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7965 overflow when computing char to be passed to 'error'. Do not
7966 pass Lisp_Object to 'error'; pass the integer instead.
7967 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7968 formatted with plain %d.
7969
7970 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7971
7972 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7973
7974 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7975
7976 * xterm.c (x_catch_errors): Remove duplicate declaration.
7977
7978 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7979
7980 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7981
7982 2011-04-10 Jim Meyering <meyering@redhat.com>
7983
7984 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7985 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7986 return ssize_t not "int", and use size_t as the buffer length.
7987 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7988 * gnutls.h: Update declarations.
7989 * process.c (read_process_output): Use ssize_t, to match.
7990 (send_process): Likewise.
7991
7992 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7993
7994 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7995
7996 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7997
7998 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7999 Use unsigned char, to match FcChar8 type definition.
8000
8001 * xterm.c (handle_one_xevent):
8002 * xmenu.c (create_and_show_popup_menu):
8003 * xselect.c (x_decline_selection_request)
8004 (x_reply_selection_request): Avoid type-punned deref of X events.
8005
8006 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8007
8008 Fix some uses of `int' instead of EMACS_INT.
8009 * search.c (string_match_1, fast_string_match)
8010 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8011 (scan_buffer, find_next_newline_no_quit)
8012 (find_before_next_newline, search_command, Freplace_match)
8013 (Fmatch_data): Make some `int' variables be EMACS_INT.
8014
8015 * xdisp.c (display_count_lines): 3rd argument and return value now
8016 EMACS_INT. All callers changed.
8017 (pint2hrstr): Last argument is now EMACS_INT.
8018
8019 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8020 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8021 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8022 (decode_coding_utf_16, decode_coding_emacs_mule)
8023 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8024 (decode_coding_ccl, decode_coding_charset)
8025 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8026 (decode_coding_iso_2022, decode_coding_emacs_mule)
8027 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8028 <char_offset, last_offset>: Declare EMACS_INT.
8029 (encode_coding_utf_8, encode_coding_utf_16)
8030 (encode_coding_emacs_mule, encode_invocation_designation)
8031 (encode_designation_at_bol, encode_coding_iso_2022)
8032 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8033 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8034 Declare EMACS_INT.
8035 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8036 (encode_invocation_designation): Last argument P_NCHARS is now
8037 EMACS_INT.
8038 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8039 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8040
8041 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8042 All users changed.
8043
8044 * ccl.c (Fccl_execute_on_string): Declare some variables
8045 EMACS_INT.
8046
8047 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8048
8049 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8050
8051 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8052
8053 * process.c (Fformat_network_address): Doc fix.
8054
8055 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8056
8057 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8058
8059 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8060
8061 * keyboard.c (read_char): Call Lisp function help-form-show,
8062 instead of using internal_with_output_to_temp_buffer.
8063 (Qhelp_form_show): New var.
8064 (syms_of_keyboard): Use DEFSYM macro.
8065
8066 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8067
8068 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8069
8070 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8071
8072 * process.c (Flist_processes): Remove to Lisp.
8073 (list_processes_1): Delete.
8074
8075 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8076
8077 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8078
8079 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8080
8081 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8082
8083 Fix more problems found by GCC 4.6.0's static checks.
8084
8085 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8086
8087 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8088
8089 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8090
8091 * xdisp.c (vmessage): Mark as a printf-like function.
8092
8093 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8094
8095 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8096
8097 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8098 printf-like functions.
8099 (tiff_load): Add casts to remove these marks before passing them
8100 to system-supplied API.
8101
8102 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8103
8104 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8105 This avoids several warnings with gcc -Wstrict-overflow.
8106 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8107 directly, rather than having caller test rule sign. This avoids
8108 some unnecessary tests.
8109 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8110 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8111 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8112
8113 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8114 (xfont_open): Avoid unnecessary tests.
8115
8116 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8117
8118 * composite.h, composite.c (composition_gstring_put_cache):
8119 Use EMACS_INT, not int, for length.
8120
8121 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8122 breaking out part of COMPOSITION_DECODE_RULE.
8123 (COMPOSITION_DECODE_RULE): Use it.
8124 * composite.c (get_composition_id): Remove unused local vars,
8125 by using the new macro.
8126
8127 * textprop.c (set_text_properties_1): Change while to do-while,
8128 since the condition is always true at first.
8129
8130 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8131 (interval_deletion_adjustment): Return unsigned value.
8132 All uses changed.
8133
8134 * process.c (list_processes_1, create_pty, read_process_output):
8135 (exec_sentinel): Remove vars that were set but not used.
8136 (create_pty): Remove unnecessary "volatile"s.
8137 (Fnetwork_interface_info): Avoid possibility of int overflow.
8138 (read_process_output): Do adaptive read buffering even if carryover.
8139 (read_process_output): Simplify nbytes computation if buffered.
8140
8141 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8142
8143 * syntax.c (scan_words): Remove var that was set but not used.
8144 (update_syntax_table): Use unsigned instead of int.
8145
8146 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8147 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8148 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8149
8150 * print.c (print_error_message): Avoid int overflow.
8151
8152 * font.c (font_list_entities): Redo for clarity,
8153 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8154
8155 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8156 (font_score): Avoid potential overflow in diff calculation.
8157
8158 * fns.c (substring_both): Remove var that is set but not used.
8159 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8160
8161 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8162
8163 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8164 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8165 can always succeed if overflow has undefined behavior.
8166
8167 * search.c (boyer_moore, wordify): Remove vars set but not used.
8168 (wordify): Omit three unnecessary tests.
8169
8170 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8171 All callers changed. This avoids the need for an unused var.
8172
8173 * casefiddle.c (casify_region): Remove var that is set but not used.
8174
8175 * dired.c (file_name_completion): Remove var that is set but not used.
8176
8177 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8178
8179 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8180 (Finsert_file_contents): Remove unnecessary code checking fd.
8181
8182 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8183 Check for integer overflow on size calculations.
8184
8185 * buffer.c (Fprevious_overlay_change): Remove var that is set
8186 but not used.
8187
8188 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8189 Remove vars that are set but not used.
8190 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8191 (timer_check_2): Mark vars as initialized.
8192
8193 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8194
8195 * image.c (lookup_image): Remove var that is set but not used.
8196 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8197
8198 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8199 that are set but not used.
8200
8201 * xfns.c (make_invisible_cursor): Don't return garbage
8202 if XCreateBitmapFromData fails (Bug#8410).
8203
8204 * xselect.c (x_get_local_selection, x_handle_property_notify):
8205 Remove vars that are set but not used.
8206
8207 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8208 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8209
8210 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8211 Remove var that is set but not used.
8212 (scroll_bar_windows_size): Now size_t, not int.
8213 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8214 Check for overflow.
8215
8216 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8217 (map_tty_color) [!defined MSDOS]: Likewise.
8218
8219 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8220
8221 * coding.c: Remove vars that are set but not used.
8222 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8223 All callers changed.
8224 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8225 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8226 (decode_coding_charset): Remove vars that are set but not used.
8227
8228 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8229 that is set but not used.
8230
8231 * print.c (print_object): Remove var that is set but not used.
8232
8233 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8234 The gnulib version avoids calling malloc in the usual case,
8235 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8236 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8237 * filelock.c (current_lock_owner): Likewise.
8238 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8239 * sysdep.c: Include allocator.h, careadlinkat.h.
8240 (emacs_no_realloc_allocator): New static constant.
8241 (emacs_readlink): New function.
8242 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8243 ../lib/careadlinkat.h.
8244
8245 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8246
8247 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8248 first non-nil return value).
8249
8250 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8251
8252 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8253 if not defined (Bug#8403).
8254
8255 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8256
8257 * xdisp.c (display_count_lines): Remove parameter `start',
8258 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8259 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8260 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8261 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8262 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8263 and thereabouts. All callers changed.
8264 (get_per_char_metric): Remove parameter `f', unused since
8265 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8266
8267 2011-04-02 Jim Meyering <meyering@redhat.com>
8268
8269 do not dereference NULL upon failed strdup
8270 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8271 (ns_get_family): Likewise.
8272
8273 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8276
8277 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8278
8279 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8280 later (Bug#8403).
8281
8282 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8283
8284 Add lexical binding.
8285
8286 * window.c (Ftemp_output_buffer_show): New fun.
8287 (Fsave_window_excursion):
8288 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8289
8290 * lread.c (lisp_file_lexically_bound_p): New function.
8291 (Fload): Bind Qlexical_binding.
8292 (readevalloop): Remove `evalfun' arg.
8293 Bind Qinternal_interpreter_environment.
8294 (Feval_buffer): Bind Qlexical_binding.
8295 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8296 Mark as dynamic.
8297 (syms_of_lread): Declare `lexical-binding'.
8298
8299 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8300
8301 * keyboard.c (eval_dyn): New fun.
8302 (menu_item_eval_property): Use it.
8303
8304 * image.c (parse_image_spec): Use Ffunctionp.
8305
8306 * fns.c (concat, mapcar1): Accept byte-code-functions.
8307
8308 * eval.c (Fsetq): Handle lexical vars.
8309 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8310 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8311 (FletX, Flet): Obey lexical binding.
8312 (Fcommandp): Handle closures.
8313 (Feval): New `lexical' arg.
8314 (eval_sub): New function extracted from Feval. Use it almost
8315 everywhere where Feval was used. Look up vars in lexical env.
8316 Handle closures.
8317 (Ffunctionp): Move from subr.el.
8318 (Ffuncall): Handle closures.
8319 (apply_lambda): Remove `eval_flags'.
8320 (funcall_lambda): Handle closures and new byte-code-functions.
8321 (Fspecial_variable_p): New function.
8322 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8323 but without exporting it to Lisp.
8324
8325 * doc.c (Fdocumentation, store_function_docstring):
8326 * data.c (Finteractive_form): Handle closures.
8327
8328 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8329 interactive spec.
8330
8331 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8332 New byte-codes.
8333 (exec_byte_code): New function extracted from Fbyte_code to handle new
8334 calling convention for byte-code-functions. Add new byte-codes.
8335
8336 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8337
8338 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8339
8340 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8341
8342 * xdisp.c (redisplay_internal): Fix prototype.
8343
8344 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8345
8346 * xdisp.c (SCROLL_LIMIT): New macro.
8347 (try_scrolling): Use it when setting scroll_limit.
8348 Limit scrolling to 100 screen lines.
8349 (redisplay_window): Even when falling back on "recentering",
8350 position point in the window according to scroll-conservatively,
8351 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8352
8353 (try_scrolling): When point is above the window, allow searching
8354 as far as scroll_max, or one screenful, to compute vertical
8355 distance from PT to the scroll margin position. This prevents
8356 try_scrolling from unnecessarily failing when
8357 scroll-conservatively is set to a value slightly larger than the
8358 window height. Clean up the case of PT below the margin at bottom
8359 of window: scroll_max can no longer be INT_MAX. When aggressive
8360 scrolling is in use, don't let point enter the opposite scroll
8361 margin as result of the scroll.
8362 (syms_of_xdisp) <scroll-conservatively>: Document the
8363 threshold of 100 lines for never-recentering scrolling.
8364
8365 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8366
8367 * dispextern.h (move_it_by_lines):
8368 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8369 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8370 (message_log_check_duplicate): Remove parameters `prev_bol' and
8371 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8372 (redisplay_internal): Remove parameter `preserve_echo_area',
8373 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8374
8375 * indent.c (Fvertical_motion):
8376 * window.c (window_scroll_pixel_based, Frecenter):
8377 Don't pass `need_y_p' to `move_it_by_lines'.
8378
8379 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8380
8381 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8382 steal a few bits to be more compact.
8383 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8384 Remove unneeded casts.
8385
8386 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8387
8388 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8389
8390 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8391 binding" message (bug#7967).
8392
8393 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8394
8395 Fix more problems found by GCC 4.6.0's static checks.
8396
8397 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8398 Remove unused local var.
8399
8400 * editfns.c (Fmessage_box): Remove unused local var.
8401
8402 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8403 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8404 Omit unused local vars.
8405 * window.c (shrink_windows): Omit unused local var.
8406 * menu.c (digest_single_submenu): Omit unused local var.
8407 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8408 Omit unused local var.
8409
8410 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8411 Don't assume string length fits in int.
8412 (keyremap_step, read_key_sequence): Use size_t for sizes.
8413 (read_key_sequence): Don't check last_real_key_start redundantly.
8414
8415 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8416 instead of alloca (Bug#8344).
8417
8418 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8419 (Fbacktrace_frame): Don't assume nframes fits in int.
8420
8421 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8422
8423 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8424 concerns.
8425
8426 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8427
8428 * cm.c (calccost): Turn while-do into do-while, for clarity.
8429
8430 * keyboard.c (syms_of_keyboard): Use the same style as later
8431 in this function when indexing through an array. This also
8432 works around GCC bug 48267.
8433
8434 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8435
8436 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8437
8438 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8439 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8440
8441 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8442 This avoids undefined behavior on integer overflow, and is a bit
8443 more convenient anyway since it is compared to a size_t variable.
8444
8445 Variadic C functions now count arguments with size_t, not int.
8446 This avoids an unnecessary limitation on 64-bit machines, which
8447 caused (substring ...) to crash on large vectors (Bug#8344).
8448 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8449 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8450 All variadic functions and their callers changed accordingly.
8451 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8452 * data.c (arith_driver, float_arith_driver): Likewise.
8453 * editfns.c (general_insert_function): Likewise.
8454 * eval.c (struct backtrace.nargs, interactive_p)
8455 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8456 (funcall_lambda, mark_backtrace): Likewise.
8457 * fns.c (concat): Likewise.
8458 * frame.c (x_set_frame_parameters): Likewise.
8459 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8460 0 if not found, not -1. All callers changed.
8461
8462 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8463 (stack_copy_size): Now size_t, not int.
8464 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8465
8466 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8467
8468 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8469 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8470 All callers changed.
8471
8472 * lisp.h (multibyte_char_to_unibyte):
8473 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8474 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8475 * character.h (CHAR_TO_BYTE8):
8476 * cmds.c (internal_self_insert):
8477 * editfns.c (general_insert_function):
8478 * keymap.c (push_key_description):
8479 * search.c (Freplace_match):
8480 * xdisp.c (message_dolog, set_message_1): All callers changed.
8481
8482 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8483
8484 * keyboard.c (safe_run_hook_funcall): New function.
8485 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8486 don't set the hook to nil, but remove the offending function instead.
8487 (Qcommand_hook_internal): Remove, unused.
8488 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8489 Vcommand_hook_internal.
8490
8491 * eval.c (enum run_hooks_condition): Remove.
8492 (funcall_nil, funcall_not): New functions.
8493 (run_hook_with_args): Call each function through a `funcall' argument.
8494 Remove `cond' argument, now redundant.
8495 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8496 (Frun_hook_with_args_until_failure): Adjust accordingly.
8497 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8498
8499 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8500
8501 * dispextern.h (string_buffer_position): Remove declaration.
8502
8503 * print.c (strout): Remove parameter `multibyte', unused since
8504 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8505
8506 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8507 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8508 All callers changed.
8509
8510 * w32.c (_wsa_errlist): Use braces for struct initializers.
8511
8512 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8513 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8514 All callers changed.
8515 (string_buffer_position): Likewise. Also, make static (it's never
8516 used outside xdisp.c).
8517 (cursor_row_p): Remove parameter `w', unused since
8518 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8519 (decode_mode_spec): Remove parameter `precision', introduced during
8520 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8521 All callers changed.
8522
8523 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8524
8525 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8526
8527 2011-03-27 Anders Lindgren <andlind@gmail.com>
8528
8529 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8530 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8531 (ns_update_auto_hide_menu_bar): New functions.
8532 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8533 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8534 ns_constrain_all_frames.
8535 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8536 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8537
8538 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8539
8540 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8541
8542 2011-03-27 Glenn Morris <rgm@gnu.org>
8543
8544 * syssignal.h: Replace RETSIGTYPE with void.
8545 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8546 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8547 Replace SIGTYPE with void everywhere.
8548 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8549 * s/template.h (SIGTYPE): Remove commented out definition.
8550
8551 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8552
8553 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8554 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8555
8556 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8557
8558 * w32.c (read_unc_volume): Use parameter `henum', instead of
8559 global variable `wget_enum_handle'.
8560
8561 * keymap.c (describe_vector): Remove parameters `indices' and
8562 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8563 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8564
8565 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8566
8567 * keyboard.c (timer_check): Remove parameter `do_it_now',
8568 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8569 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8570 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8571
8572 * keyboard.c (read_char):
8573 * w32menu.c (w32_menu_display_help):
8574 * xmenu.c (show_help_event, menu_help_callback):
8575 Adjust calls to `show_help_echo'.
8576
8577 * gtkutil.c (xg_maybe_add_timer):
8578 * keyboard.c (readable_events):
8579 * process.c (wait_reading_process_output):
8580 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8581
8582 * insdel.c (adjust_markers_gap_motion):
8583 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8584 (gap_left, gap_right): Don't call it.
8585
8586 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8587
8588 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8589 incurred during fontification.
8590
8591 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8592
8593 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8594 (DEFVAR_PER_BUFFER): Don't pass it.
8595
8596 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8597 (scrolling_window): Don't pass it.
8598
8599 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8600
8601 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8602
8603 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8604 and `suffix'.
8605 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8606 of variables specific to SELinux and computation of `encoded_absname'.
8607
8608 * image.c (XPutPixel): Remove unused variable `height'.
8609
8610 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8611
8612 * unexw32.c (get_section_info): Remove unused variable `section'.
8613
8614 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8615 (system_process_attributes): Remove unused variable `sess'.
8616 (sys_read): Remove unused variable `err'.
8617
8618 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8619 (w32_wnd_proc): Remove unused variable `isdead'.
8620 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8621 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8622 (x_create_tip_frame): Remove unused variable `tem'.
8623
8624 * w32inevt.c (w32_console_read_socket):
8625 Remove unused variable `no_events'.
8626
8627 * w32term.c (x_draw_composite_glyph_string_foreground):
8628 Remove unused variable `width'.
8629
8630 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8631
8632 * w32term.c (x_set_glyph_string_clipping):
8633 Don't pass uninitialized region to CombineRgn.
8634
8635 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8636
8637 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8638 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8639 (Fx_close_connection): Remove unused variable `i'.
8640
8641 * w32font.c (w32font_draw): Return number of glyphs.
8642 (w32font_open_internal): Remove unused variable `i'.
8643 (w32font_driver): Add missing initializer.
8644
8645 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8646 (fill_in_menu): Remove unused variable `items_added'.
8647
8648 * w32term.c (last_mouse_press_frame): Remove static global variable.
8649 (w32_clip_to_row): Remove unused variable `f'.
8650 (x_delete_terminal): Remove unused variable `i'.
8651
8652 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8653 (NOTHING): Remove unused static global variable.
8654 (uniscribe_check_otf): Remove unused variable `table'.
8655 (uniscribe_font_driver): Add missing initializers.
8656
8657 2011-03-23 Julien Danjou <julien@danjou.info>
8658
8659 * term.c (Fsuspend_tty, Fresume_tty):
8660 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8661 * window.c (temp_output_buffer_show):
8662 * insdel.c (signal_before_change):
8663 * frame.c (Fhandle_switch_frame):
8664 * fileio.c (Fdo_auto_save):
8665 * emacs.c (Fkill_emacs):
8666 * editfns.c (save_excursion_restore):
8667 * cmds.c (internal_self_insert):
8668 * callint.c (Fcall_interactively):
8669 * buffer.c (Fkill_all_local_variables):
8670 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8671 Use Frun_hooks.
8672 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8673 unconditionally since it does the check itself.
8674
8675 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8676
8677 Fix more problems found by GCC 4.5.2's static checks.
8678
8679 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8680 the first time through the loop, since we know p0 < p1 then.
8681 This also avoids a gcc -Wstrict-overflow warning.
8682
8683 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8684 leading to a memory leak, possible in functions like
8685 load_charset_map_from_file that can allocate an unbounded number
8686 of objects (Bug#8318).
8687
8688 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8689 that could (at least in theory) be that large.
8690
8691 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8692 This is less likely to overflow, and avoids undefined behavior if
8693 overflow does occur. All callers changed. Use strtoul to scan
8694 for the unsigned long integer.
8695 (pint2hrstr): Simplify and tune code slightly.
8696 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8697
8698 * scroll.c (do_scrolling): Work around GCC bug 48228.
8699 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8700
8701 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8702 This also avoids a warning with gcc -Wstrict-overflow.
8703 (validate_x_resource_name): Simplify count usage.
8704 This also avoids a warning with gcc -Wstrict-overflow.
8705
8706 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8707 fail (Bug#8306).
8708
8709 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8710
8711 * process.c (Fmake_network_process): Use socklen_t, not int,
8712 where POSIX says socklen_t is required in portable programs.
8713 This fixes a porting bug on hosts like 64-bit HP-UX, where
8714 socklen_t is wider than int (Bug#8277).
8715 (Fmake_network_process, server_accept_connection):
8716 (wait_reading_process_output, read_process_output):
8717 Likewise.
8718
8719 * process.c: Rename or move locals to avoid shadowing.
8720 (list_processes_1, Fmake_network_process):
8721 (read_process_output_error_handler, exec_sentinel_error_handler):
8722 Rename or move locals.
8723 (Fmake_network_process): Define label "retry_connect" only if needed.
8724 (Fnetwork_interface_info): Fix pointer signedness.
8725 (process_send_signal): Add cast to avoid pointer signedness problem.
8726 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8727 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8728
8729 Make tparam.h and terminfo.c consistent.
8730 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8731 Include tparam.h instead, since it declares them.
8732 * cm.h (PC): Remove extern decl; tparam.h now does this.
8733 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8734 * terminfo.c: Include tparam.h, to check interfaces.
8735 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8736 (tparam): Adjust signature to match interface in tparam.h;
8737 this removes some undefined behavior. Check that outstring and len
8738 are zero, which they always are with Emacs.
8739 * tparam.h (PC, BC, UP): New extern decls.
8740
8741 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8742 (xftfont_open): Rename locals to avoid shadowing.
8743
8744 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8745 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8746 (OTF_TAG_SYM): Omit macro if not needed.
8747 (ftfont_list): Remove unused local.
8748 (get_adstyle_property, ftfont_pattern_entity):
8749 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8750 Rename locals to avoid shadowing.
8751
8752 * xfont.c (xfont_list_family): Mark var as initialized.
8753
8754 * xml.c (make_dom): Now static.
8755
8756 * composite.c (composition_compute_stop_pos): Rename local to
8757 avoid shadowing.
8758 (composition_reseat_it): Remove unused locals.
8759 (find_automatic_composition, composition_adjust_point): Likewise.
8760 (composition_update_it): Mark var as initialized.
8761 (find_automatic_composition): Mark vars as initialized,
8762 with a FIXME (Bug#8290).
8763
8764 character.h: Rename locals to avoid shadowing.
8765 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8766 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8767 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8768 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8769 to avoid shadowing.
8770
8771 * textprop.c (property_change_between_p): Remove; unused.
8772
8773 * intervals.c (interval_start_pos): Now static.
8774
8775 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8776
8777 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8778 Rename locals to avoid shadowing.
8779
8780 * sound.c (wav_play, au_play, Fplay_sound_internal):
8781 Fix pointer signedness.
8782 (alsa_choose_format): Remove unused local var.
8783 (wav_play): Initialize a variable to 0, to prevent undefined
8784 behavior (Bug#8278).
8785
8786 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8787
8788 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8789
8790 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8791 clobbering (Bug#8298).
8792 * sysdep.c (sys_subshell): Likewise.
8793 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8794
8795 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8796 This should get cleaned up, so that child_setup has the
8797 same signature on all platforms.
8798
8799 * callproc.c (call_process_cleanup): Now static.
8800 (relocate_fd): Rename locals to avoid shadowing.
8801
8802 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8803
8804 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8805 not to be necessary, and produces flickering.
8806
8807 2011-03-20 Glenn Morris <rgm@gnu.org>
8808
8809 * config.in: Remove file.
8810
8811 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8814 are now in src/globals.h.
8815 (syms_of_minibuf): Remove spurious & from previous change.
8816
8817 2011-03-20 Leo Liu <sdl.web@gmail.com>
8818
8819 * minibuf.c (completing-read-function): New variable.
8820 (completing-read-default): Rename from completing-read.
8821 (completing-read): Call completing-read-function.
8822
8823 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8824
8825 * xfaces.c (Fx_load_color_file):
8826 Read color file from absolute filename (bug#8250).
8827
8828 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8829
8830 * makefile.w32-in: Update dependencies.
8831
8832 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8833
8834 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8835
8836 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8837
8838 Fix more problems found by GCC 4.5.2's static checks.
8839
8840 * process.c (make_serial_process_unwind, send_process_trap):
8841 (sigchld_handler): Now static.
8842
8843 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8844 That way, the code declares only the vars that it needs.
8845 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8846 * s/cygwin.h (PTY_ITERATION): Likewise.
8847 * s/darwin.h (PTY_ITERATION): Likewise.
8848 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8849
8850 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8851 * process.c (allocate_pty): Don't declare stb unless it's needed.
8852
8853 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8854 (CONSTANTLIM): Remove; unused.
8855 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8856 Define only if needed.
8857
8858 * unexelf.c (unexec): Name an expression,
8859 to avoid gcc -Wbad-function-cast warning.
8860 Use a different way to cause a compilation error if anyone uses
8861 n rather than nn, a way that does not involve shadowing.
8862 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8863
8864 * deps.mk (unexalpha.o): Remove; unused.
8865
8866 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8867 * unexec.h: New file.
8868 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8869 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8870 Depend on unexec.h.
8871 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8872 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8873 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8874 Change as necessary to match prototype in unexec.h.
8875
8876 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8877 shadowing.
8878 (back_comment, skip_chars): Mark vars as initialized.
8879
8880 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8881 Rename locals to avoid shadowing.
8882
8883 * lread.c (read1): Rewrite so as not to use empty "else".
8884 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8885
8886 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8887
8888 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8889 warning when compiling print.c.
8890
8891 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8892 instead of using an uninitialized var.
8893 (font_sort_entities): Mark var as initialized.
8894
8895 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8896
8897 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8898 pointers to constants.
8899 (font_parse_fcname): Remove unused vars.
8900 (font_delete_unmatched): Now static.
8901 (font_get_spec): Remove; unused.
8902 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8903 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8904 Rename or move locals to avoid shadowing.
8905
8906 * fns.c (require_nesting_list, require_unwind): Now static.
8907 (Ffillarray): Rename locals to avoid shadowing.
8908
8909 * floatfns.c (domain_error2): Define only if needed.
8910 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8911
8912 * alloc.c (mark_backtrace): Move decl from here ...
8913 * lisp.h: ... to here, so that it can be checked.
8914
8915 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8916 (Fdefvar): Rewrite so as not to use empty "else".
8917 (lisp_indirect_variable): Name an expression,
8918 to avoid gcc -Wbad-function-cast warning.
8919 (Fdefvar): Rename locals to avoid shadowing.
8920
8921 * callint.c (quotify_arg, quotify_args): Now static.
8922 (Fcall_interactively): Rename locals to avoid shadowing.
8923 Use const pointer when appropriate.
8924
8925 * lisp.h (get_system_name, get_operating_system_release):
8926 Move decls here, to check interfaces.
8927 * process.c (get_operating_system_release): Move decl to lisp.h.
8928 * xrdb.c (get_system_name): Likewise.
8929 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8930 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8931 some of which prompt warnings from gcc -Wbad-function-cast.
8932 (Fformat_time_string, Fencode_time, Finsert_char):
8933 (Ftranslate_region_internal, Fformat):
8934 Rename or remove local vars to avoid shadowing.
8935 (Ftranslate_region_internal): Mark var as initialized.
8936
8937 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8938 avoid shadowing.
8939
8940 * lisp.h (eassert): Check that the argument compiles, even if
8941 ENABLE_CHECKING is not defined.
8942
8943 * data.c (Findirect_variable): Name an expression, to avoid
8944 gcc -Wbad-function-cast warning.
8945 (default_value, arithcompare, arith_driver, arith_error): Now static.
8946 (store_symval_forwarding): Rename local to avoid shadowing.
8947 (Fmake_variable_buffer_local, Fmake_local_variable):
8948 Mark variables as initialized.
8949 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8950
8951 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8952 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8953 Rename locals to avoid shadowing.
8954 (mark_stack): Move local variables into the #ifdef region where
8955 they're used.
8956 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8957 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8958 needed otherwise.
8959 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8960 (GC_STRING_CHARS): Remove; not used.
8961 (Fmemory_limit): Cast sbrk's returned value to char *.
8962
8963 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8964 avoids undefined behavior in theory.
8965
8966 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8967
8968 Use functions, not macros, for up- and down-casing (Bug#8254).
8969 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8970 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8971 to use the following functions instead of these macros.
8972 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8973 EMACS_INT, since callers assume the returned value fits in int.
8974 (upcase1): Likewise, for UPCASE_TABLE.
8975 (uppercasep, lowercasep, upcase): New static inline functions.
8976 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8977 the race-condition problem in the old DOWNCASE.
8978
8979 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8980 Rename locals to avoid shadowing.
8981 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8982 (regex_compile, re_search_2, re_match_2_internal):
8983 Remove unused local vars.
8984 (FREE_VAR): Rewrite so as not to use empty "else",
8985 which gcc can warn about.
8986 (regex_compile, re_match_2_internal): Mark locals as initialized.
8987 (RETALLOC_IF): Define only if needed.
8988 (WORDCHAR_P): Likewise. This one is never needed, but is used
8989 only in a comment talking about a compiler bug, so put inside
8990 the #if 0 of that comment.
8991 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8992 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8993 Remove; unused.
8994
8995 * search.c (boyer_moore): Rename locals to avoid shadowing.
8996 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8997 (PREV_CHAR_BOUNDARY): Likewise.
8998
8999 * search.c (simple_search): Remove unused var.
9000
9001 * dired.c (compile_pattern): Move decl from here ...
9002 * lisp.h: ... to here, so that it can be checked.
9003 (struct re_registers): New forward decl.
9004
9005 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9006
9007 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9008 All uses changed.
9009 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9010 Rename locals to avoid shadowing.
9011 (Fvertical_motion): Mark locals as initialized.
9012
9013 * casefiddle.c (casify_object, casify_region): Now static.
9014 (casify_region): Mark local as initialized.
9015
9016 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9017
9018 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9019 New macros, so that the caller can use some names other than
9020 gcpro1, gcpro2, etc.
9021 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9022 of the new macros.
9023 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9024 argument, for consistency with GCPRO2_VAR, etc: it is now the
9025 prefix of the variable, not the variable itself. All uses
9026 changed.
9027 * dired.c (directory_files_internal, file_name_completion):
9028 Rename locals to avoid shadowing.
9029
9030 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9031 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9032 dired.c's scmp function, had undefined behavior.
9033 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9034 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9035 * buffer.h: ... to here, because these macros use current_buffer,
9036 and the new implementation with inline functions needs to have
9037 current_buffer in scope now, rather than later when the macros
9038 are used.
9039 (downcase, upcase1): New static inline functions.
9040 (DOWNCASE, UPCASE1): Reimplement using these functions.
9041 This avoids undefined behavior in expressions like
9042 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9043 from race conditions in accessing the global variables
9044 case_temp1 and case_temp2.
9045 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9046 * lisp.h (case_temp1, case_temp2): Remove their decls.
9047 * character.h (ASCII_CHAR_P): Move from here ...
9048 * lisp.h: ... to here, so that the inline functions mentioned
9049 above can use them.
9050
9051 * dired.c (directory_files_internal_unwind): Now static.
9052
9053 * fileio.c (file_name_as_directory, directory_file_name):
9054 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9055 Now static.
9056 (file_name_as_directory): Use const pointers when appropriate.
9057 (Fexpand_file_name): Likewise. In particular, newdir might
9058 point at constant storage, so make it a const pointer.
9059 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9060 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9061 signedness issues.
9062 (Fset_file_times, Finsert_file_contents, auto_save_error):
9063 Rename locals to avoid shadowing.
9064
9065 * minibuf.c (choose_minibuf_frame_1): Now static.
9066 (Ftry_completion, Fall_completions): Rename or remove locals
9067 to avoid shadowing.
9068
9069 * marker.c (bytepos_to_charpos): Remove; unused.
9070
9071 * lisp.h (verify_bytepos, count_markers): New decls,
9072 so that gcc does not warn that these functions aren't declared.
9073
9074 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9075 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9076 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9077 (copy_text): Remove unused local var.
9078
9079 * filelock.c (within_one_second): Now static.
9080 (lock_file_1): Rename local to avoid shadowing.
9081
9082 * buffer.c (fix_overlays_before): Mark locals as initialized.
9083 (fix_start_end_in_overlays): Likewise. This function should be
9084 simplified by using pointers-to-pointers, but that's a different
9085 matter.
9086 (switch_to_buffer_1): Now static.
9087 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9088 (report_overlay_modification): Rename locals to avoid shadowing.
9089
9090 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9091 Fix pointer signedness issue.
9092 (sys_subshell): Mark local as volatile if checking for lint,
9093 to suppress a gcc -Wclobbered warning that does not seem to be right.
9094 (MAXPATHLEN): Define only if needed.
9095
9096 * process.c (serial_open, serial_configure): Move decls from here ...
9097 * systty.h: ... to here, so that they can be checked.
9098
9099 * fns.c (get_random, seed_random): Move extern decls from here ...
9100 * lisp.h: ... to here, so that they can be checked.
9101
9102 * sysdep.c (reset_io): Now static.
9103 (wait_for_termination_signal): Remove; unused.
9104
9105 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9106 (copy_keymap_item, append_key, push_text_char_description):
9107 Now static.
9108 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9109 (DENSE_TABLE_SIZE): Remove; unused.
9110 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9111 (describe_map_tree):
9112 Rename locals to avoid shadowing.
9113
9114 * keyboard.c: Declare functions static if they are not used elsewhere.
9115 (echo_char, echo_dash, cmd_error, top_level_2):
9116 (poll_for_input, handle_async_input): Now static.
9117 (read_char, kbd_buffer_get_event, make_lispy_position):
9118 (make_lispy_event, make_lispy_movement, apply_modifiers):
9119 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9120 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9121 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9122 (read_key_sequence, read_char): Mark locals as initialized.
9123 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9124
9125 * keyboard.h (make_ctrl_char): New decl.
9126 (mark_kboards): Move decl here ...
9127 * alloc.c (mark_kboards): ... from here.
9128
9129 * lisp.h (force_auto_save_soon): New decl.
9130
9131 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9132 (DEFINE_DUMMY_FUNCTION): New macro.
9133 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9134 Use it.
9135 (main): Add casts to avoid warnings
9136 if GCC considers string literals to be constants.
9137
9138 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9139
9140 * dbusbind.c: Pointer signedness fixes.
9141 (xd_signature, xd_append_arg, xd_initialize):
9142 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9143 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9144 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9145 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9146
9147 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9148 if GCC considers string literals to be constants.
9149 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9150
9151 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9152
9153 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9154 (print_preprocess, print_object): New macro to fix last change.
9155
9156 * print.c (print_preprocess): Don't forget font objects.
9157
9158 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9159
9160 * emacs.c (USAGE3): Doc fixes.
9161
9162 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9163
9164 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9165 structure.
9166
9167 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9168
9169 * lisp.h (VWindow_system, Qfile_name_history):
9170 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9171 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9172 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9173
9174 * w32select.c: Don't #include "keyboard.h".
9175 (run_protected): Add extern declaration for waiting_for_input.
9176
9177 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9178 * w32console.c (detect_input_pending, read_input_pending)
9179 (encode_terminal_code):
9180 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9181 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9182 (w32_system_caret_y, Qfile_name_history):
9183 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9184 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9185 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9186 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9187 * w32proc.c (Qlocal, report_file_error):
9188 * w32term.c (Vwindow_system, updating_frame):
9189 * w32uniscribe.c (initialized, uniscribe_font_driver):
9190 Remove unneeded extern declarations.
9191
9192 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9193
9194 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9195
9196 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9197
9198 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9199 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9200 These macros can no longer be used for assignment.
9201
9202 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9203 Assign struct members directly, instead of using BUF_BEGV etc.
9204 (record_buffer_markers, fetch_buffer_markers): New functions for
9205 recording and fetching special buffer markers.
9206 (set_buffer_internal_1, set_buffer_temp): Use them.
9207
9208 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9209
9210 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9211
9212 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9213 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9214
9215 * xdisp.c (hscroll_window_tree):
9216 (reconsider_clip_changes): Use PT instead of BUF_PT.
9217
9218 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9219
9220 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9221 $(EMACS_ROOT)/lib/intprops.h.
9222
9223 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9224
9225 Fix more problems found by GCC 4.5.2's static checks.
9226
9227 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9228 to unsigned char * to avoid compiler diagnostic.
9229 (xg_free_frame_widgets): Make it clear that a local variable is
9230 needed only if USE_GTK_TOOLTIP.
9231 (gdk_window_get_screen): Make it clear that this macro is needed
9232 only if USE_GTK_TOOLTIP.
9233 (int_gtk_range_get_value): New function, which avoids a diagnostic
9234 from gcc -Wbad-function-cast.
9235 (xg_set_toolkit_scroll_bar_thumb): Use it.
9236 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9237 diagnostic from gcc -Wbad-function-cast.
9238 (get_utf8_string, xg_get_file_with_chooser):
9239 Rename locals to avoid shadowing.
9240 (create_dialog): Move locals to avoid shadowing.
9241
9242 * xgselect.c (xg_select): Remove unused var.
9243
9244 * image.c (four_corners_best): Mark locals as initialized.
9245 (gif_load): Initialize transparent_p to zero (Bug#8238).
9246 Mark another local as initialized.
9247 (my_png_error, my_error_exit): Mark with NO_RETURN.
9248
9249 * image.c (clear_image_cache): Now static.
9250 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9251 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9252 (x_edge_detection): Remove unnecessary cast that
9253 gcc -Wbad-function-cast diagnoses.
9254 (gif_load): Fix pointer signedness.
9255 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9256 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9257
9258 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9259
9260 Improve quality of tests for time stamp overflow.
9261 For example, without this patch (encode-time 0 0 0 1 1
9262 1152921504606846976) returns the obviously-bogus value (-948597
9263 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9264 reports time overflow. See
9265 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9266 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9267 * editfns.c: Include limits.h and intprops.h.
9268 (TIME_T_MIN, TIME_T_MAX): New macros.
9269 (time_overflow): Move earlier, to before first use.
9270 (hi_time, lo_time): New functions, for an accurate test for
9271 out-of-range times.
9272 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9273 (Fget_internal_run_time): Don't assume time_t fits in int.
9274 (make_time): Use list2 instead of Fcons twice.
9275 (Fdecode_time): More accurate test for out-of-range times.
9276 (check_tm_member): New function.
9277 (Fencode_time): Use it, to test for out-of-range times.
9278 (lisp_time_argument): Don't rely on undefined left-shift and
9279 right-shift behavior when checking for time stamp overflow.
9280
9281 * editfns.c (time_overflow): New function, refactoring common code.
9282 (Fformat_time_string, Fdecode_time, Fencode_time):
9283 (Fcurrent_time_string): Use it.
9284
9285 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9286 * dired.c (make_time): Move to ...
9287 * editfns.c (make_time): ... here.
9288 * systime.h: Note the move.
9289
9290 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9291
9292 * fringe.c (update_window_fringes): Remove unused variables.
9293
9294 * unexmacosx.c (copy_data_segment): Also copy __got section.
9295 (Bug#8223)
9296
9297 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9298
9299 * termcap.c [MSDOS]: Include "msdos.h".
9300 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9301 Constify `char *' arguments and their references according to
9302 prototypes in tparam.h.
9303
9304 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9305
9306 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9307 Adapt all references accordingly.
9308
9309 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9310
9311 2011-03-11 Tom Tromey <tromey@redhat.com>
9312
9313 * buffer.c (syms_of_buffer): Remove obsolete comment.
9314
9315 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9316
9317 * termhooks.h (encode_terminal_code): Declare prototype.
9318
9319 * msdos.c (encode_terminal_code): Don't declare prototype.
9320
9321 * term.c (encode_terminal_code): Now external again, used by
9322 w32console.c and msdos.c.
9323
9324 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9325 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9326
9327 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9328
9329 Fix some minor problems found by GCC 4.5.2's static checks.
9330
9331 * fringe.c (update_window_fringes): Mark locals as initialized
9332 (Bug#8227).
9333 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9334
9335 * alloc.c (mark_fringe_data): Move decl from here ...
9336 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9337 to check its interface.
9338 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9339
9340 * fontset.c (free_realized_fontset): Now static.
9341 (Fset_fontset_font): Rename local to avoid shadowing.
9342 (fontset_font): Mark local as initialized.
9343 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9344
9345 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9346
9347 * xselect.c (x_disown_buffer_selections): Remove; not used.
9348 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9349 (x_own_selection, Fx_disown_selection_internal): Rename locals
9350 to avoid shadowing.
9351 (x_handle_dnd_message): Remove local to avoid shadowing.
9352
9353 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9354 so that the caller can use some name other than gcpro1.
9355 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9356 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9357 (Fx_backspace_delete_keys_p):
9358 Use them to avoid shadowing, and rename vars to avoid shadowing.
9359 (x_decode_color, x_set_name, x_window): Now static.
9360 (Fx_create_frame): Add braces to silence GCC warning.
9361 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9362 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9363 Remove unused locals.
9364 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9365 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9366 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9367 macros.
9368
9369 * xterm.h (x_mouse_leave): New decl.
9370
9371 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9372 Remove unused functions.
9373 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9374 (x_calc_absolute_position): Now static.
9375 (XTread_socket): Don't define label "out" unless it's used.
9376 Don't declare local "event" unless it's used.
9377 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9378 unless they are used.
9379 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9380 (x_fatal_error_signal): Remove; not used.
9381 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9382 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9383 (x_error_catcher, x_connection_closed, x_error_handler):
9384 (x_error_quitter, xembed_send_message, x_iconify_frame):
9385 (my_log_handler): Rename locals to avoid shadowing.
9386 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9387 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9388
9389 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9390 Rename or move locals to avoid shadowing.
9391 (tty_defined_color, merge_face_heights): Now static.
9392 (free_realized_faces_for_fontset): Remove; not used.
9393 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9394 does not deduce is never used uninitialized.
9395 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9396 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9397
9398 * terminal.c (store_terminal_param): Now static.
9399
9400 * xmenu.c (menu_highlight_callback): Now static.
9401 (set_frame_menubar): Remove unused local.
9402 (xmenu_show): Rename parameter to avoid shadowing.
9403 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9404 since they might point to immutable storage.
9405 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9406 since it's unused otherwise.
9407
9408 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9409 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9410 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9411 avoids a gcc -Wuninitialized diagnostic.
9412 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9413 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9414 does not deduce are never used uninitialized.
9415
9416 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9417
9418 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9419 * window.c (window_loop, size_window):
9420 (run_window_configuration_change_hook, enlarge_window): Likewise.
9421
9422 * window.c (display_buffer): Now static.
9423 (size_window): Mark variables that gcc -Wuninitialized
9424 does not deduce are never used uninitialized.
9425 * window.h (check_all_windows): New decl, to forestall
9426 gcc -Wmissing-prototypes diagnostic.
9427 * dispextern.h (bidi_dump_cached_states): Likewise.
9428
9429 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9430 shadowing.
9431 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9432 Include <limits.h>.
9433 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9434 and to avoid gcc -Wuninitialized warning.
9435 (load_charset_map): Mark variables that gcc -Wuninitialized
9436 does not deduce are never used uninitialized.
9437 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9438
9439 * coding.c (coding_set_source, coding_set_destination):
9440 Use "else { /* comment */ }" rather than "else /* comment */;"
9441 for clarity, and to avoid gcc -Wempty-body warning.
9442 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9443 a block, when the outer 'i' will do.
9444 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9445 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9446 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9447 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9448 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9449 Rename locals to avoid shadowing.
9450 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9451 * coding.c (emacs_mule_char, encode_invocation_designation):
9452 Now static, since they're not used elsewhere.
9453 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9454 (decode_coding_object, encode_coding_object, detect_coding_system):
9455 (decode_coding_emacs_mule): Mark variables that gcc
9456 -Wuninitialized does not deduce are never used uninitialized.
9457 (detect_coding_iso_2022): Initialize a local variable that might
9458 be used uninitialized. Leave a FIXME because it's not clear that
9459 this initialization is needed. (Bug#8211)
9460 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9461 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9462 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9463 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9464 Remove unused macros.
9465
9466 * category.c (hash_get_category_set): Remove unused local var.
9467 (copy_category_table): Now static, since it's not used elsewhere.
9468 * character.c (string_count_byte8): Likewise.
9469
9470 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9471 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9472
9473 * chartab.c (copy_sub_char_table): Now static, since it's not used
9474 elsewhere.
9475 (sub_char_table_ref_and_range, char_table_ref_and_range):
9476 Rename locals to avoid shadowing.
9477 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9478
9479 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9480 (BIDI_BOB): Remove unused macro.
9481
9482 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9483 deduce are never used uninitialized.
9484 * term.c (encode_terminal_code): Likewise.
9485
9486 * term.c (encode_terminal_code): Now static. Remove unused local.
9487
9488 * tparam.h: New file.
9489 * term.c, tparam.h: Include it.
9490 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9491 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9492 Move these decls to tparam.h, and make them agree with what
9493 is actually in tparam.c. The previous trick of using incompatible
9494 decls in different modules does not conform to the C standard.
9495 All callers of tparam changed to use tparam's actual API.
9496 * tparam.c (tparam1, tparam, tgoto):
9497 Use const pointers where appropriate.
9498
9499 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9500 * cm.h (struct cm): Likewise.
9501 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9502 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9503 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9504 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9505 (turn_on_face, init_tty): Likewise.
9506 * termchar.h (struct tty_display_info): Likewise.
9507
9508 * term.c (term_mouse_position): Rename local to avoid shadowing.
9509
9510 * alloc.c (mark_ttys): Move decl from here ...
9511 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9512
9513 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9514
9515 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9516
9517 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9518
9519 * search.c (compile_pattern_1): Remove argument regp, unused since
9520 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9521 (compile_pattern): Don't pass it.
9522
9523 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9524
9525 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9526 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9527 for ! HAVE_GTK3.
9528 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9529
9530 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9531
9532 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9533 gdk_window_get_screen, gdk_window_get_geometry,
9534 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9535 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9536 (xg_get_pixbuf_from_pixmap): New function.
9537 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9538 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9539 Call xg_get_pixbuf_from_pixmap instead of
9540 gdk_pixbuf_get_from_drawable.
9541 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9542 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9543 (xg_check_special_colors): Use GtkStyleContext and its functions
9544 for HAVE_GTK3.
9545 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9546 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9547 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9548 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9549 Call gtk_widget_get_preferred_size.
9550 (xg_frame_resized): gdk_window_get_geometry only takes 5
9551 parameters.
9552 (xg_win_to_widget, xg_event_is_for_menubar):
9553 Call gdk_x11_window_lookup_for_display.
9554 (xg_set_widget_bg): New function.
9555 (delete_cb): New function.
9556 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9557 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9558 (xg_set_background_color): Call xg_set_widget_bg.
9559 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9560 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9561 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9562 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9563 if ! HAVE_GTK3.
9564 (update_frame_tool_bar): Call gtk_widget_hide.
9565 (xg_initialize): Use GDK_KEY_g.
9566
9567 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9568 if ! HAVE_GTK3
9569 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9570
9571 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9572 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9573 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9574
9575 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9576
9577 * w32xfns.c (select_palette): Check success of RealizePalette against
9578 GDI_ERROR, not zero.
9579
9580 See ChangeLog.11 for earlier changes.
9581
9582 ;; Local Variables:
9583 ;; coding: utf-8
9584 ;; End:
9585
9586 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9587
9588 This file is part of GNU Emacs.
9589
9590 GNU Emacs is free software: you can redistribute it and/or modify
9591 it under the terms of the GNU General Public License as published by
9592 the Free Software Foundation, either version 3 of the License, or
9593 (at your option) any later version.
9594
9595 GNU Emacs is distributed in the hope that it will be useful,
9596 but WITHOUT ANY WARRANTY; without even the implied warranty of
9597 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9598 GNU General Public License for more details.
9599
9600 You should have received a copy of the GNU General Public License
9601 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.