1 2012-01-31 Glenn Morris <rgm@gnu.org>
3 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6 2012-01-29 Glenn Morris <rgm@gnu.org>
8 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
10 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
12 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
14 2012-01-28 Chong Yidong <cyd@gnu.org>
17 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
19 2012-01-26 Chong Yidong <cyd@gnu.org>
21 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
23 * search.c (Fsearch_forward, Fsearch_backward): Document negative
24 repeat counts (Bug#10507).
26 2012-01-26 Glenn Morris <rgm@gnu.org>
28 * lread.c (syms_of_lread): Doc fix.
30 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
32 * coding.c (encode_designation_at_bol): Change return value to
35 2012-01-25 Chong Yidong <cyd@gnu.org>
37 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
39 2012-01-21 Chong Yidong <cyd@gnu.org>
41 * floatfns.c (Fcopysign): Make the second argument non-optional,
42 since nil is not allowed anyway.
44 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
46 * process.c (read_process_output): Use p instead of XPROCESS (proc).
47 (send_process): Likewise.
49 2012-01-19 Martin Rudalics <rudalics@gmx.at>
51 * window.c (save_window_save, Fcurrent_window_configuration)
52 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
55 2012-01-19 Kenichi Handa <handa@m17n.org>
57 * character.c (char_width): New function.
58 (Fchar_width, c_string_width, lisp_string_width):
59 Use char_width (Bug#9496).
61 2012-01-16 Martin Rudalics <rudalics@gmx.at>
63 * window.c (Vwindow_persistent_parameters): New variable.
64 (Fset_window_configuration, save_window_save): Handle persistent
67 2012-01-14 Eli Zaretskii <eliz@gnu.org>
69 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
70 thrashing the stack of the thread. (Bug#9087)
72 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
74 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
76 2012-01-11 Eli Zaretskii <eliz@gnu.org>
78 * xdisp.c (rows_from_pos_range): Handle the case where the
79 highlight ends on a newline. (Bug#10464)
80 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
81 he end column for display of highlight that ends on a newline
84 2012-01-11 Glenn Morris <rgm@gnu.org>
86 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
87 from load-path also when installation-directory is nil. (Bug#10208)
89 2012-01-10 Glenn Morris <rgm@gnu.org>
91 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
93 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
94 Update template values to be closer to their typical values these days.
96 2012-01-09 Eli Zaretskii <eliz@gnu.org>
98 * xdisp.c (rows_from_pos_range): Accept additional argument
99 DISP_STRING, and accept any glyph in a row whose object is that
100 string as eligible for mouse highlight. Fixes mouse highlight of
101 display strings from overlays. (Bug#10464)
103 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
105 emacs: fix an auto-save permissions race condition (Bug#10400)
106 * fileio.c (auto_saving_dir_umask): New static var.
107 (Fmake_directory_internal): Use it.
108 (do_auto_save_make_dir): Set it, instead of invoking chmod after
109 creating the directory. The old code temporarily assigns
110 too-generous permissions to the directory.
111 (do_auto_save_eh): Clear it.
112 (Fdo_auto_save): Catch all errors, not just file errors, so
113 that the var is always cleared.
115 2012-01-07 Eli Zaretskii <eliz@gnu.org>
117 * search.c (scan_buffer): Pass character positions to
118 know_region_cache, not byte positions. (Bug#6540)
120 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
122 * w32.c (sys_rename): Report EXDEV when rename of a directory
123 fails because the target is on another logical disk. (Bug#10284)
125 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
127 * xterm.c (x_embed_request_focus): New function.
129 * xterm.h: Add prototype.
131 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
133 2012-01-05 Glenn Morris <rgm@gnu.org>
135 * emacs.c (emacs_copyright): Update short copyright year to 2012.
137 2012-01-01 Eli Zaretskii <eliz@gnu.org>
139 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
140 Load gnutls_transport_set_lowat only if GnuTLS version is below
142 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
143 GnuTLS versions below 2.11.1.
145 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
147 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
148 to the doc string advising against its use for altering the way
149 windows are scrolled.
151 2011-12-28 Kenichi Handa <handa@m17n.org>
153 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
154 coding-system ASCII compatible only when it does not produce BOM
155 on encoding (Bug#10383).
157 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
159 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
161 (create_and_show_popup_menu): Always use menu_position_func for
164 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
166 * callint.c (Fcall_interactively): Don't truncate prompt string.
168 2011-12-23 Eli Zaretskii <eliz@gnu.org>
170 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
171 property that ends at ZV, so that the bidi iteration could be
172 resumed from there (after widening). (Bug#10360)
174 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
176 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
178 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
180 * nsterm.m (x_free_frame_resources):
181 Release f->output_data.ns->miniimage.
182 (ns_index_color): Fix indentation. Do not retain
183 color_table->colors[i].
185 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
188 * nsfns.m (x_set_background_color): Assign return value from
189 ns_index_color to face-background instead of NSColor*.
190 (ns_implicitly_set_icon_type): Fix indentation.
191 Change assignment in for loop to comparison.
193 * emacs.c (ns_pool): New variable.
194 (main): Assign ns_pool.
195 (Fkill_emacs): Call ns_release_autorelease_pool.
197 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
198 autorelease fdesc, release fdAttrs and tdict.
199 (ns_get_covering_families): Release charset.
200 (ns_findfonts): Release NSFontDescriptor created with new.
201 (ns_uni_to_glyphs): Fix indentation.
202 (setString): Release attrStr before assigning new value.
204 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
206 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
208 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
209 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
211 2011-12-18 David Reitter <reitter@cmu.edu>
213 * nsterm.m (ns_term_init): Subscribe for notifications
214 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
215 to method trackingNotification in EmacsMenu.
217 * nsmenu.m (trackingMenu): New variable.
218 (trackingNotification): New method (from Aquamacs).
219 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
220 from Aquamacs (Bug#7030).
222 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
224 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
225 (symbol_to_nsstring): Fix indentation.
226 (ns_symbol_to_pb): New function.
227 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
228 (Fns_rotate_cut_buffers_internal): Removed.
229 (Fns_store_selection_internal): Renamed from
230 Fns_store_cut_buffer_internal.
231 (ns_get_foreign_selection, Fx_own_selection_internal)
232 (Fx_disown_selection_internal, Fx_selection_exists_p)
233 (Fns_get_selection_internal, Fns_store_selection_internal):
234 Use ns_symbol_to_pb and check if return value is nil.
235 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
236 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
237 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
238 renamed to Sns_store_selection_internal.
239 (ns_handle_selection_request): Move code to Fx_own_selection_internal
240 and remove this function.
241 (ns_handle_selection_clear): Remove, never used.
242 (Fx_own_selection_internal): Move code from ns_handle_selection_request
245 2011-12-17 Ken Brown <kbrown@cornell.edu>
247 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
248 GID is unknown (Bug#10257).
250 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
252 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
253 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
254 which caused a build failure on GNU/Linux IA-64. This problem was
255 introduced by my 2011-10-07 patch.
257 2011-12-15 Juri Linkov <juri@jurta.org>
259 * image.c (imagemagick_error): New function. (Bug#10112)
260 (imagemagick_load_image): Comment out `MagickSetResolution' call.
261 Use `imagemagick_error' where ImageMagick functions return
263 (Fimagemagick_types): Add `Fnreverse' to return the list in the
266 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
268 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
269 fill background (Bug#8992).
271 2011-12-13 Martin Rudalics <rudalics@gmx.at>
273 * window.c (Vwindow_combination_resize)
274 (Vwindow_combination_limit): Use t instead of non-nil in
276 (Vrecenter_redisplay): Add first sentence of doc-string on
278 (Frecenter): Fix doc-string typo.
280 2011-12-11 Kenichi Handa <handa@m17n.org>
282 * coding.c (Funencodable_char_position): Pay attention to the
283 buffer text relocation (Bug#9389).
285 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
287 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
288 gtk_init (Bug#10100).
290 2011-12-10 Eli Zaretskii <eliz@gnu.org>
292 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
293 IT->string is nil. (Bug#10263)
295 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
297 * nsterm.h (x_free_frame_resources): Declare.
299 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
300 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
302 * nsterm.h (ns_get_defaults_value): Declare.
304 * nsterm.m (ns_default): Call ns_get_defaults_value.
306 2011-12-09 Eli Zaretskii <eliz@gnu.org>
308 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
311 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
313 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
314 that where the value of an _OBJC_* symbol points to is in the .bss
317 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
319 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
320 after the loop to call ccl_driver at least once (Bug#8619).
322 2011-12-08 Kenichi Handa <handa@m17n.org>
324 * ftfont.c (get_adstyle_property): Fix previous change
327 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
329 * w32.c (init_environment): If no_site_lisp, remove site-lisp
330 dirs from the default value of EMACSLOADPATH (bug#10208).
332 2011-12-07 Glenn Morris <rgm@gnu.org>
334 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
335 installation and source directories as well. (Bug#10208)
337 2011-12-06 Chong Yidong <cyd@gnu.org>
339 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
341 2011-12-06 Glenn Morris <rgm@gnu.org>
343 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
344 as an error, not just -1. (Bug#10217)
346 2011-12-05 Chong Yidong <cyd@gnu.org>
348 * keyboard.c (process_special_events): New function.
349 (swallow_events, Finput_pending_p): Use it (Bug#10195).
351 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
353 * coding.c (encode_designation_at_bol): Don't use uninitialized
354 local variable (Bug#9318).
356 2011-12-05 Kenichi Handa <handa@m17n.org>
358 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
359 return Qnil (Bug#8046, Bug#10193).
361 2011-12-05 Kenichi Handa <handa@m17n.org>
363 * coding.c (encode_designation_at_bol): New args charbuf_end and
364 dst. Return the number of produced bytes. Callers changed.
365 (coding_set_source): Return how many bytes coding->source was
367 (coding_set_destination): Return how many bytes
368 coding->destination was relocated.
369 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
370 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
372 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
374 * coding.c (CODING_CHAR_CHARSET_P): New macro.
375 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
378 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
380 The following changes are to fix Bug#9318.
382 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
383 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
384 (encode_coding_iso_2022, encode_coding_sjis)
385 (encode_coding_big5, encode_coding_charset): Use the above macros.
387 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
389 * lisp.h (process_quit_flag): Fix external declaration.
391 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
393 Don't macro-inline non-performance-critical code.
394 * eval.c (process_quit_flag): New function.
395 * lisp.h (QUIT): Use it.
397 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
399 * nsfns.m (get_geometry_from_preferences): New function.
400 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
402 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
404 * emacs.c (Qkill_emacs): Define.
405 (syms_of_emacs): Initialize it.
406 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
407 Qquit_flag to `kill-emacs' instead.
408 (quit_throw_to_read_char): Add parameter `from_signal'.
409 All callers changed. Call Fkill_emacs if requested and safe.
410 * lisp.h (QUIT): Call Fkill_emacs if requested.
412 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
414 * widget.c (update_wm_hints): Return if wmshell is null.
415 (widget_update_wm_size_hints): New function.
417 * widget.h (widget_update_wm_size_hints): Declare.
419 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
420 widget_update_wm_size_hints (Bug#10104).
422 2011-12-03 Eli Zaretskii <eliz@gnu.org>
424 * xdisp.c (handle_invisible_prop): If the invisible text ends just
425 before a newline, prepare the bidi iterator for consuming the
426 newline, and keep the current paragraph direction. (Bug#10183)
427 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
429 2011-12-02 Juri Linkov <juri@jurta.org>
431 * search.c (Fword_search_regexp): New Lisp function created from
432 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
433 (Fword_search_backward, Fword_search_forward)
434 (Fword_search_backward_lax, Fword_search_forward_lax):
435 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
436 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
438 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
440 * fileio.c (Finsert_file_contents): Move after-change-function call
441 to before the "handled:" label, since all "goto handled" appear in
442 cases where the *-change-functions have already been properly called
445 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
447 * keyboard.c (interrupt_signal): Don't call kill-emacs when
448 waiting for input. (Bug#10169)
450 2011-11-30 Eli Zaretskii <eliz@gnu.org>
452 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
453 verifies glyph row's hash code--we have just reallocated the
454 glyphs, so their contents can be complete garbage. (Bug#10164)
456 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
458 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
460 2011-11-30 Eli Zaretskii <eliz@gnu.org>
462 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
463 attributes are tested _before_ calling verify_row_hash, to protect
464 against GCC re-ordering of the tests. (Bug#10164)
466 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
468 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
470 * xterm.c (handle_one_xevent): Only set async_visible and friends
471 if net_wm_state_hidden_seen is non-zero (Bug#10002)
472 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
473 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
475 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
477 Remove GCPRO-related macros that exist only to avoid shadowing locals.
478 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
479 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
480 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
481 All uses changed to use GCPRO1 etc.
482 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
483 Revert to old implementation (i.e., before 2011-03-11).
485 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
487 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
488 of scroll runs so as to avoid assigning disabled bogus rows and
489 unnecessary graphics copy operations.
491 2011-11-27 Eli Zaretskii <eliz@gnu.org>
493 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
494 (snprintf) [_MSC_VER]: Redirect to _snprintf.
495 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
496 (malloc, free, realloc, calloc): Redirect to e_* only when
499 * lisp.h (GCTYPEBITS): Move before first use.
500 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
501 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
502 this macro definition.
504 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
507 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
509 * gtkutil.c (xg_create_frame_widgets):
510 Call gtk_window_set_has_resize_grip (FALSE) if that function is
511 present with Gtk+ 2.0.
513 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
515 * fileio.c (Finsert_file_contents): Undo previous change; see
516 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
518 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
520 Rename locals to avoid shadowing.
521 * fileio.c (Finsert_file_contents):
522 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
523 * process.c (wait_reading_process_output):
524 Rename inner 'proc' to 'p' to avoid shadowing.
525 Indent for consistency with usual Emacs style.
527 2011-11-25 Eli Zaretskii <eliz@gnu.org>
529 * xdisp.c (redisplay_window): If cursor row is not fully visible
530 after recentering, and scroll-conservatively is set to a large
531 number, scroll window by a few more lines to make the cursor fully
532 visible and out of scroll-margin. (Bug#10105)
533 (start_display): Don't move to the next line if the display should
534 start at a newline that is part of a display vector or an overlay
537 2011-11-24 Juri Linkov <juri@jurta.org>
539 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
540 after the `MagickPingImage' call. (Bug#10112)
542 2011-11-23 Chong Yidong <cyd@gnu.org>
544 * window.c (Fcoordinates_in_window_p): Accept only live windows.
546 2011-11-23 Martin Rudalics <rudalics@gmx.at>
548 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
549 making another buffer current. (Bug#10114)
551 2011-11-23 Glenn Morris <rgm@gnu.org>
553 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
555 2011-11-23 Chong Yidong <cyd@gnu.org>
557 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
560 2011-11-22 Eli Zaretskii <eliz@gnu.org>
562 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
563 and header-lines, as they don't have one computed for them.
566 * .gdbinit (prow): Make displayed values more self-explaining.
569 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
571 * process.c (wait_reading_process_output): Fix asynchrounous
572 GnuTLS socket handling on some versions of the GnuTLS library.
573 (wait_reading_process_output): Add comment and URL.
575 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
577 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
579 2011-11-21 Chong Yidong <cyd@gnu.org>
581 * window.c (Fnext_window, Fprevious_window): Doc fix.
583 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
585 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
587 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
589 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
591 2011-11-20 Martin Rudalics <rudalics@gmx.at>
593 * window.c (Fset_window_combination_limit): Rename argument
595 (Vwindow_combination_limit): Remove "status" from doc-string.
597 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
599 * m/ibms390.h: Remove.
600 * m/ibms390x.h: Don't include "ibms390.h".
602 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
604 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
605 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
607 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
609 * casetab.c (Fset_case_table):
610 * charset.c (Fcharset_after): Fix typos.
612 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
614 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
615 Otherwise, valgrind does not work on some platforms.
616 Problem reported by Andreas Schwab in
617 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
618 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
619 is set, removing the need for VIRT_ADDRESS_VARIES.
620 (PURE_P): Use a more-efficient implementation that needs just one
621 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
622 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
623 to 4 (xorl, subq, cmpq, setbe).
624 * alloc.c (pure): Always extern now, since that's the
625 VIRT_ADDR_VARIES behavior.
626 (PURE_POINTER_P): Use a single comparison, not two, for
627 consistency with the new puresize.h.
628 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
629 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
630 Remove VIRT_ADDR_VARIES no longer needed.
632 2011-11-19 Eli Zaretskii <eliz@gnu.org>
634 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
635 (erase_phys_cursor, update_window_cursor, show_mouse_face)
636 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
637 behave as if the cursor position were at the window margin.
639 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
640 and the cursor position is out of bounds, behave as if the cursor
641 position were at the window margin. (Bug#10075)
643 2011-11-18 Chong Yidong <cyd@gnu.org>
645 * window.c (Fwindow_combination_limit): Make first argument
646 non-optional, since it is meaningless for live windows like the
649 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
651 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
653 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
655 * intervals.c: Fix grafting over the whole buffer (bug#10071).
656 (graft_intervals_into_buffer): Simplify.
658 2011-11-18 Eli Zaretskii <eliz@gnu.org>
660 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
661 hash values of the two rows.
662 (copy_row_except_pointers): Preserve the used[] arrays and the
663 hash values of the two rows. (Bug#10035)
664 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
666 * xdisp.c (row_hash): New function, body extracted from
667 compute_line_metrics.
668 (compute_line_metrics): Call row_hash, instead of computing the
671 * dispnew.c (verify_row_hash): Call row_hash for computing the
672 hash code of a row, instead of duplicating code from xdisp.c.
674 * dispextern.h (row_hash): Add prototype.
676 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
678 * frame.c (delete_frame): Don't delete the terminal when the last
679 X frame is closed if emacs is built with GTK toolkit.
681 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
683 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
685 2011-11-17 Martin Rudalics <rudalics@gmx.at>
687 * window.c (Vwindow_splits): Rename to
688 Vwindow_combination_resize. Suggested by Juri Linkov.
689 (Fsplit_window_internal): Use Vwindow_combination_resize instead
692 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
694 * nsfns.m (Fns_font_name):
695 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
697 2011-11-16 Martin Rudalics <rudalics@gmx.at>
699 * window.h (window): Rename slot "nest" to "combination_limit".
700 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
701 (Fset_window_nest): Rename to Fset_window_combination_limit.
702 (Vwindow_nest): Rename to Vwindow_combination_limit.
703 (recombine_windows, make_parent_window, make_window)
704 (Fsplit_window_internal, saved_window)
705 (Fset_window_configuration, save_window_save): Rename all
706 occurrences of window_nest to window_combination_limit.
708 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
710 * image.c (imagemagick_load_image): Fix typo.
712 2011-11-14 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (display_line): Move the call to
715 highlight_trailing_whitespace before the call to
716 compute_line_metrics, since the latter needs to see the final
717 faces of all the glyphs to compute ROW's hash value.
718 Fixes assertion violations in row_equal_p. (Bug#10035)
720 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
722 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
723 just return (bug#10044).
725 2011-11-12 Eli Zaretskii <eliz@gnu.org>
727 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
728 with user-defined heap size. Bump the default size of the temacs
729 heap to 27MB, to avoid memory warning when running temacs.
730 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
732 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
733 current_matrix and desired_matrix. (Bug#9990)
734 (verify_row_hash) [XASSERTS]: New function.
735 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
736 that the hash value of glyph rows is correct.
738 2011-11-12 Martin Rudalics <rudalics@gmx.at>
740 * window.h (window): Remove splits slot.
741 * window.c (Fwindow_splits, Fset_window_splits): Remove.
742 (Fdelete_other_windows_internal, make_parent_window)
743 (make_window, Fsplit_window_internal, Fdelete_window_internal)
744 (Fset_window_configuration, save_window_save): Don't deal with
745 split status of windows.
746 (saved_window): Remove splits slot.
747 (Vwindow_splits): Rewrite doc-string.
749 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
751 * xfns.c (unwind_create_frame):
752 * nsfns.m (unwind_create_frame):
753 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
754 Vframe_list (Bug#9999).
756 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
758 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
760 2011-11-11 Kenichi Handa <handa@m17n.org>
762 * callproc.c (Fcall_process): Set the member dst_multibyte of
765 2011-11-11 Johan Bockgård <bojohan@gnu.org>
767 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
768 avoid a crash (bug#9496).
770 2011-11-09 Chong Yidong <cyd@gnu.org>
772 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
773 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
775 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
777 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
779 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
781 Avoid some portability problems by eschewing 'extern inline' functions.
782 The trivial performance wins aren't worth the portability hassles; see
783 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
785 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
786 (window_box_width, window_box_left, window_box_left_offset)
787 (window_box_right, window_box_right_offset): Undo previous change,
788 by removing the "extern"s.
789 * intervals.c (adjust_intervals_for_insertion)
790 (adjust_intervals_for_deletion): Undo previous change,
791 making these static again.
792 (offset_intervals, temp_set_point_both, temp_set_point)
793 (copy_intervals_to_string): No longer inline.
794 * xdisp.c (window_text_bottom_y, window_box_width)
795 (window_box_height, window_box_left_offset)
796 (window_box_right_offset, window_box_left, window_box_right)
797 (window_box): No longer inline.
799 2011-11-08 Chong Yidong <cyd@gnu.org>
801 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
802 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
803 Signal an error if not a live window.
804 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
805 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
807 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
809 * lisp.h (syms_of_abbrev): Remove declaration.
810 Reported by CHENG Gao <chenggao@royau.me>.
812 2011-11-07 Eli Zaretskii <eliz@gnu.org>
814 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
815 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
816 of temacs in GUI mode.
818 2011-11-07 Martin Rudalics <rudalics@gmx.at>
820 * window.h: Declare delete_all_child_windows instead of
821 delete_all_subwindows.
822 * window.c (Fwindow_nest, Fset_window_nest)
823 (Fset_window_new_total, Fset_window_new_normal)
824 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
825 (delete_all_subwindows): Rename to delete_all_child_windows.
826 (Fdelete_other_windows_internal, Fset_window_configuration):
827 Call delete_all_child_windows instead of delete_all_subwindows.
828 * frame.c (delete_frame): Call delete_all_child_windows instead
829 of delete_all_subwindows.
831 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
833 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
834 This is also needed for porting to any host where GC_MARK_STACK is
835 not GC_MAKE_GCPROS_NOOPS.
836 (which_symbols): Use it.
838 2011-11-07 Kenichi Handa <handa@m17n.org>
840 * coding.c (coding_set_destination): Check coding->src_pos only
841 when coding->src_object is a buffer (bug#9910).
843 * process.c (send_process): Set the member src_multibyte of coding
844 to 0 (bug#9911) when sending a unibyte text.
846 * callproc.c (Fcall_process): Set the member src_multibyte of
847 process_coding to 0 (bug#9912).
849 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
851 * xmenu.c (cleanup_widget_value_tree): New function.
852 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
853 calling free_menubar_widget_value_tree directly (Bug#9830).
855 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
857 Fix some portability problems with 'inline'.
858 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
859 (window_box_width, window_box_left, window_box_left_offset)
860 (window_box_right, window_box_right_offset): Declare extern.
861 Otherwise, these inline functions do not conform to C99 and
862 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
863 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
864 * intervals.c (adjust_intervals_for_insertion)
865 (adjust_intervals_for_deletion): Now extern, because otherwise the
866 extern inline functions 'offset_intervals' couldn't refer to it.
867 (static_offset_intervals): Remove.
868 (offset_intervals): Rewrite using the old contents of
869 static_offset_intervals. The old version didn't conform to C99
870 because an extern inline function contained a reference to an
871 identifier with static linkage.
873 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
875 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
878 2011-11-06 Eli Zaretskii <eliz@gnu.org>
880 * xdisp.c (init_iterator, reseat_to_string): Don't set the
881 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
882 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
883 return Qleft_to_right.
885 2011-11-06 Chong Yidong <cyd@gnu.org>
887 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
888 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
889 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
890 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
891 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
892 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
893 (Fwindow_vscroll): Doc fix.
894 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
895 argument, since it makes no sense to pass a live window and for
896 consistency with window-child.
898 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
900 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
903 2011-11-05 Jason Rumney <jasonr@gnu.org>
905 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
906 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
908 (add_font_entity_to_list): Fix logic errors in mixed boolean and
909 bitwise arithmetic preventing use of unicode-sip and non-truetype
912 2011-11-05 Eli Zaretskii <eliz@gnu.org>
914 * s/ms-w32.h (fstat, stat, utime): Move redirections to
917 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
918 initialization code to keep similarity to xfns.c after changes
921 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
923 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
924 (unwind_create_frame): New function (Bug#9943).
925 (Fx_create_frame): Restructure code to be more similar to the one in
926 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
927 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
928 Move terminal->reference_count++ just before making the frame official
931 * nsterm.m (x_free_frame_resources): New function.
932 (x_destroy_window): Move code to x_free_frame_resources.
934 * xfns.c (unwind_create_frame): Fix comment.
935 (Fx_create_frame, x_create_tip_frame):
936 Move terminal->reference_count++ just before making the frame
937 official. Move initialization of image_cache_refcount and
938 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
940 2011-11-05 Eli Zaretskii <eliz@gnu.org>
942 Support MSVC build with newer versions of Visual Studio.
943 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
944 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
947 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
948 which are not supported by MSVC.
949 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
950 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
952 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
954 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
956 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
958 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
960 Support MSVC build with newer versions of Visual Studio.
961 * w32.c: Don't include w32api.h for MSVC.
962 (init_environment) [_MSC_VER]: Call sys_access, not _access.
964 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
965 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
966 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
967 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
969 (alloca) [_MSC_VER]: Define to _alloca.
971 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
973 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
975 2011-11-04 Eli Zaretskii <eliz@gnu.org>
977 * xdisp.c (note_mouse_highlight): If either of
978 previous/next-single-property-change returns nil, treat that as
979 the beginning or the end of the buffer. (Bug#9955)
981 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
983 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
984 label is not null (Bug#9951).
985 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
988 2011-11-04 Eli Zaretskii <eliz@gnu.org>
990 * window.c (Fwindow_body_size): Mention in the doc string that the
991 return value is in frame's canonical units. (Bug#9949)
993 2011-11-03 Eli Zaretskii <eliz@gnu.org>
995 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
997 * w32fns.c (unwind_create_frame): If needed, free the glyph
998 matrices of the partially constructed frame. (Bug#9943)
999 * xfns.c (unwind_create_frame): Likewise.
1001 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1003 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1004 Don't stop backward scan on the continuation glyph, even though
1005 its CHARPOS is positive.
1006 (mouse_face_from_buffer_pos, note_mouse_highlight):
1007 Rename cover_string to disp_string.
1009 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1011 * window.c (temp_output_buffer_show): Don't use
1012 Vtemp_buffer_show_specifiers.
1013 (Vtemp_buffer_show_specifiers): Remove unused variable.
1015 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1017 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1018 past the beginning of the current glyph matrix.
1020 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1022 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1023 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1024 HAVE_GTK3 (Bug#9869).
1026 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1027 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1029 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1031 * xterm.c: Declare x_handle_net_wm_state to return int.
1032 (handle_one_xevent): Check if we are iconified but don't have
1033 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1034 (get_current_wm_state): Return non-zero if not hidden,
1035 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1036 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1037 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1038 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1040 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1042 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1043 so that this new function doesn't get optimized away by a
1044 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1046 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1048 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1050 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1052 Fix the `xbytecode' command.
1053 * .gdbinit (xprintbytestr): New command.
1054 (xwhichsymbols): Rename from `which'; all callers changed.
1055 (xbytecode): Print the byte-code string as well.
1057 2011-10-29 Kim Storm <storm@cua.dk>
1059 * alloc.c (which_symbols): New function.
1061 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1063 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1066 2011-10-29 Glenn Morris <rgm@gnu.org>
1068 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1069 Not clear what it was for, and it causes various bugs. (Bug#9839)
1071 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1073 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1074 possible random value that matches one of those tested as
1075 condition to clear the mouse face.
1077 2011-10-28 Chong Yidong <cyd@gnu.org>
1079 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1081 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1083 * window.c (make_window): Initialize phys_cursor_on_p.
1085 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1087 * lisp.h (struct Lisp_Symbol): Update comments.
1089 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1091 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1093 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1095 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1096 <oslsachem@gmail.com> for helping to debug this.
1098 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1099 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1100 (g_b_init_get_glyph_outline_w): New static variables.
1101 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1102 (GetGlyphOutlineW_Proc): New typedefs.
1103 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1104 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1106 (w32font_open_internal, compute_metrics):
1107 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1108 instead of calling the "wide" APIs directly.
1110 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1112 * w32.h (syms_of_w32font): Add prototype.
1114 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1116 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1117 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1118 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1119 (Fmove_to_window_line): Doc fix.
1121 2011-10-27 Chong Yidong <cyd@gnu.org>
1123 * process.c (make_process): Set gnutls_state to NULL.
1125 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1126 non-NULL, regardless of GNUTLS_INITSTAGE.
1127 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1128 an error. Set process slots as soon as we allocate them.
1130 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1132 2011-10-27 Chong Yidong <cyd@gnu.org>
1134 * gnutls.c (emacs_gnutls_deinit): New function.
1135 Deallocate credentials structures as well as calling gnutls_deinit.
1136 (Fgnutls_deinit, Fgnutls_boot): Use it.
1138 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1139 (deactivate_process): Call emacs_gnutls_deinit.
1141 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1143 * image.c (x_create_x_image_and_pixmap):
1144 * w32.c (sys_rename, w32_delayed_load):
1145 * w32font.c (fill_in_logfont):
1146 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1148 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1150 * w32fns.c (w32_default_color_map): New function,
1151 extracted from Fw32_default_color_map.
1152 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1154 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1156 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1158 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1160 * keyboard.c (test_undefined): New function (bug#9751).
1161 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1163 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1165 * sysdep.c (init_sys_modes): Fix the check for the controlling
1166 terminal (Bug#6649).
1168 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1170 * dispextern.h (struct bidi_it): New member next_en_type.
1172 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1173 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1174 current character, check also for next_en_type being WEAK_EN.
1175 (bidi_resolve_weak): Don't enter the expensive loop if the current
1176 position is before next_en_pos. Record the bidi type of the first
1177 non-ET, non-BN character we find, in addition to its position.
1178 (bidi_level_of_next_char): Invalidate next_en_type when
1179 next_en_pos is over-stepped.
1181 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1183 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1184 * editfns.c: Rewrite current-time-zone so that it invokes
1185 the equivalent of (format-time-string "%Z") to get the time zone name.
1186 This fixes a bug when the time zone name contains characters that
1187 need converting from the system time locale to Emacs internal format.
1188 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1189 that patch fixed format-time-string to do the conversion, but
1190 I forgot to fix current-time-zone.
1191 (format_time_string): New function, containing most of
1192 what Fformat_time_string used to contain.
1193 (Fformat_time_string): Rewrite in terms of format_time_string.
1194 This doesn't change this function's behavior.
1195 (current-time-zone): Rewrite to use format_time_string.
1196 This fixes the bug reported by Michael Schierl in
1197 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1198 Jason Rumney's 2007-06-07 change worked around this bug, but
1200 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1202 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1204 * xdisp.c (start_display): If the character at POS is displayed
1205 via a display vector, reset IT->current.dpvec_index to zero.
1206 (try_window_reusing_current_matrix): If a line ends in a display
1207 vector or the next line starts in a display vector, continue
1208 redrawing the window even though the character position of
1209 start_row was reached.
1212 2011-10-18 Chong Yidong <cyd@gnu.org>
1214 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1215 with nobreak-char-display too.
1217 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1219 Fix part 3 of bug#9771.
1220 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1221 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1222 non-neutral characters if the current character is a paragraph
1223 separator (a.k.a. Newline). This avoids running the same
1224 expensive loop twice, once when we consume the preceding newline
1225 and the other time when the line actually needs to be displayed.
1226 Avoid the loop when we see neutrals on the base embedding level
1227 following a character whose directionality is the same as the
1228 paragraph's. This avoids running the expensive loop when a line
1229 ends in a long sequence of neutrals, like control characters.
1230 Add assertion against STRONG_AL type. Slightly rearrange code
1231 that determines the type of a neutral given the first non-neutral
1233 (bidi_level_of_next_char): Set next_en_pos to zero when
1234 invalidating its info.
1236 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1238 * xdisp.c (push_display_prop): Determine whether to record string
1239 or buffer position by IT->string, not by IT->method. Allow
1240 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1241 (move_it_vertically_backward): Don't look for character position
1242 immediately after the newline when in a continuation line.
1245 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1247 * window.c (coordinates_in_window): Rewrite and delabelize
1248 vertical border check. (Bug#5357) (Bug#9618)
1250 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1252 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1253 errors in XSetWindowBorder (bug#9310).
1255 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1257 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1258 avoid crash when xmalloc overrun checking is enabled.
1260 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1263 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1264 cursor motion with <left> and <right> arrow keys.
1266 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1267 some callers set that themselves.
1269 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1271 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1272 display string and the previous row comes from the same string and
1273 is empty. (Bug#9739) (Bug#9738)
1275 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1277 * doc.c (get_doc_string): Encode file name (bug#9735).
1279 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1281 * bidi.c (bidi_level_of_next_char):
1282 * xdisp.c (get_visually_first_element): Remove old incorrect
1283 comments regarding the Unicode Line Separator character.
1285 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1287 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1289 * alloc.c (Fgc_status): Do not access beyond zombies array
1290 boundary if nzombies > MAX_ZOMBIES.
1291 * alloc.c (dump_zombies): Add missing format specifier.
1293 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1295 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1296 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1298 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1299 Some packages use them to denote characters with modifiers.
1301 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1303 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1304 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1305 matching a pp-number. Rename parameter var to var1.
1307 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1309 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1311 2011-10-08 Glenn Morris <rgm@gnu.org>
1313 * callint.c (Fcall_interactively): Give a more explicit error for the
1314 'c' case with a non-character input. (Bug#8479)
1316 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1318 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1320 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1321 lines that are hscrolled on the left.
1323 * dispnew.c (buffer_posn_from_coords): Account for a possible
1324 presence of header-line. (Bug#4426)
1326 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1328 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1329 Don't advertise functionality which we discourage or doesn't work.
1331 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1333 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1334 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1335 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1336 this makes Emacs dump core during garbage collection on rare
1337 occasions. sizeof is obviously inferior to offsetof here, so
1338 stick with offsetof.
1339 (GC_POINTER_ALIGNMENT): New macro.
1340 (mark_memory): Omit 3rd (offset) arg; caller changed.
1341 Don't assume EMACS_INT alignment is the same as pointer alignment.
1343 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1345 * keyboard.c (read_key_sequence_remapped): New var.
1346 (read_key_sequence): Compute remapping in the right buffer.
1347 (command_loop_1): Use read_key_sequence's remapping directly.
1349 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1351 * dired.c (file_name_completion): Don't expand file name.
1352 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1353 before checking file name handler.
1355 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1356 they've been requested explicitly (bug#9591).
1358 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1360 * keymap.c (Fsingle_key_description): Use make_specified_string
1361 instead of build_string to build string from push_key_description.
1364 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1366 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1367 This fixes a Y2038 bug on 64-bit hosts.
1368 * buffer.c (reset_buffer):
1369 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1370 (Fclear_buffer_auto_save_failure):
1371 Use 0, not -1, to represent an unset failure time, since time_t
1372 might not be signed.
1374 Remove dependency on glibc malloc internals.
1375 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1376 Move back here from lisp.h, but with their new implementations.
1377 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1378 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1379 * charset.c (charset_table_init): New static var.
1380 (syms_of_charset): Use it instead of xmalloc. This removes a
1381 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1382 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1383 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1384 Move back to alloc.c.
1385 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1386 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1388 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1390 * nsterm.m (windowDidResize): Call x_set_window_size only when
1391 ns_in_resize is true. Otherwise set pixelwidth/height and
1392 call change_frame_size (Bug#9628).
1394 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1396 Port --enable-checking=all to Fedora 14 x86-64.
1397 * charset.c (syms_of_charset): Also account for glibc malloc's
1398 internal overhead when calculating the initial malloc maximum.
1400 Port --enable-checking=all to Fedora 14 x86.
1401 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1403 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1404 (overrun_check_realloc, overrun_check_free):
1405 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1406 That way, xmalloc returns a properly-aligned pointer even if
1407 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1408 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1409 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1410 into account when calculating the initial malloc maximum.
1411 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1412 Move here from alloc.c, so that charset.c can use it too.
1413 Properly align; the old code wasn't right for common 32-bit hosts
1414 when configured with --enable-checking=all.
1415 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1416 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1418 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1420 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1423 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1425 * xdisp.c (compute_display_string_end): If there's no display
1426 string at CHARPOS, return -1.
1428 * bidi.c (bidi_fetch_char): When compute_display_string_end
1429 returns a negative value, treat the character as a normal
1430 character not covered by a display string. (Bug#9624)
1432 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1434 * lread.c (Fread_from_string): Fix typo in docstring.
1436 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1438 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1439 newline, reseat the iterator instead of bidi-iterating there one
1440 character at a time. (Bug#9610)
1441 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1442 TO_CHARPOS if the bidi iterator is at base embedding level.
1444 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1446 * lread.c (readevalloop): Use correct code for NBSP.
1447 (read1): Likewise. (Bug#9608)
1449 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1451 * dbusbind.c (Fdbus_register_signal): When service is not
1452 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1454 2011-09-25 Glenn Morris <rgm@gnu.org>
1456 * buffer.c (truncate-lines): Doc fix.
1458 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1460 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1461 (Fset_window_next_buffers): Doc fix.
1463 2011-09-24 Glenn Morris <rgm@gnu.org>
1465 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1467 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1469 Fix minor problems found by static checking.
1470 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1471 * indent.c (Fvertical_motion): Fix == vs = typo.
1473 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1475 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1476 Default value is now t. Doc fix.
1478 * indent.c (Fvertical_motion): Compute and apply the overshoot
1479 logic when moving up, not only when moving down. Fix the
1480 confusing name and values of the it_overshoot_expected variable;
1481 logic changes accordingly. (Bug#9254) (Bug#9549)
1483 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1484 CHARPOS is covered by a display string which includes newlines.
1485 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1486 is covered by a display string with embedded newlines.
1488 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1490 * dbusbind.c (Fdbus_register_signal): Add match rule to
1491 Vdbus_registered_objects_table. (Bug#9581)
1492 (Fdbus_register_method, Vdbus_registered_objects_table):
1495 2011-09-24 Jim Meyering <meyering@redhat.com>
1497 do not ignore write error for any output size
1498 The previous change was incomplete.
1499 While it makes emacs --batch detect the vast majority of stdout
1500 write failures, errors were still ignored whenever the output size is
1501 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1502 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1503 && echo FAIL: ignored write error
1504 FAIL: ignored write error
1505 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1506 && echo FAIL: ignored write error
1507 FAIL: ignored write error
1508 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1510 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1512 * emacs.c (Fkill_emacs): In noninteractive mode exit
1513 non-successfully if a write error occurred on stdout. (Bug#9574)
1515 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1517 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1520 * dispextern.h (struct it): Update the comment documenting what
1523 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1525 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1526 a display string, extend search for cursor position to end of row.
1527 (find_row_edges): If the row ends in a newline from a display
1528 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1529 Handle the case of a display string with multiple newlines.
1530 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1531 non-empty line. Fixes confusing cursor motion with arrow keys at
1532 the beginning of a line that starts with whitespace.
1534 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1536 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1539 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1541 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1544 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1546 * xdisp.c (display_line): Record maximum and minimum buffer
1547 positions even if no glyphs were produced (e.g., by a zero-width
1548 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1549 buffer positions that will be removed from the glyph row because
1551 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1552 column is beyond frame width: don't subtract 1 "pixel" when
1553 computing width of the stretch.
1554 (reseat_at_next_visible_line_start): Undo the change made on
1555 2011-09-17 that saved paragraph information and restored it after
1556 the call to `reseat'. (Bug#9545)
1558 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1560 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1561 and turn window cursor on if cleared (Bug#9415).
1563 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1565 * search.c (boyer_moore): Take unibyte characters from pattern
1566 literally. (Bug#9458)
1568 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1570 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1572 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1574 Fix minor problem found by static checking.
1575 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1576 initialized, to pacify gcc -Wuninitialized.
1578 * fileio.c: Report proper errno when syscall falls.
1579 (Finsert_file_contents): Save and restore errno,
1580 so that report_file_error outputs the correct diagnostic.
1581 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1583 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1585 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1587 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1589 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1590 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1592 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1594 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1595 about the current paragraph and restore it after the call to reseat.
1597 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1598 (bidi_find_paragraph_start): Search back for paragraph beginning
1599 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1600 (bidi_move_to_visually_next): Only trigger paragraph-related
1601 computations when the last character is a newline or at EOB, not
1602 just any NEUTRAL_B. (Bug#9470)
1604 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1605 truncated lines if point is covered by a display string. (Bug#9524)
1607 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1609 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1610 (cons_to_x_long): New function.
1611 (lisp_data_to_selection_data): Use it. Correct the test for
1612 short-versus-long data; it was negated. Break out of vector
1613 loop, for efficiency, when a long datum is discovered.
1615 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1617 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1619 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1621 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1622 GCC PR/17406) by declaring this function with external scope.
1624 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1626 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1627 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1629 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1631 * editfns.c (Fformat): Correctly handle text properties on "%%".
1633 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1635 * xterm.c (x_draw_composite_glyph_string_foreground):
1636 * w32term.c (x_draw_composite_glyph_string_foreground):
1637 * term.c (encode_terminal_code):
1638 * composite.c (composition_update_it, get_composition_id):
1639 * xdisp.c (get_next_display_element)
1640 (fill_composite_glyph_string): Add comments about special meaning
1641 of TAB characters in a composition.
1643 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1645 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1646 This occurs when processing a multibyte format.
1647 Problem reported by Wolfgang Jenker.
1649 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1651 * xdisp.c (try_cursor_movement): Only check for exact match if
1652 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1654 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1656 Remove unused external symbols.
1657 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1658 * xdisp.c (calc_pixel_width_or_height): Now static.
1659 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1660 * indent.c (check_display_width):
1661 * w32term.c: Fix comment to match code.
1662 * xterm.c, xterm.h (x_catching_errors): Remove.
1664 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1666 * xselect.c: Use signed conversions more consistently (Bug#9498).
1667 (selection_data_to_lisp_data): Assume incoming selection data are
1668 signed integers, not unsigned. This is to be consistent with
1669 outgoing selection data, which was modified to use signed integers
1670 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1671 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1672 expects long, not unsigned long.
1674 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1676 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1677 computation of loop end. Reported by Johan Bockgård
1680 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1682 * frame.c (Fother_visible_frames_p): Function deleted.
1684 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1686 * indent.c (compute_motion): Process display vector front to back
1687 rather than the other way around. (Bug#2496)
1689 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1691 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1693 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1695 * minibuf.c (Fread_from_minibuffer): Doc fix.
1697 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1699 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1700 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1702 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1704 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1705 value for non-existent files.
1707 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1709 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1710 set its "size" to -1. This will set the modtime_size field of
1711 the corresponding buffer to -1, which is what
1712 verify-visited-file-modtime expects for files that do not exist.
1715 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1717 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1719 * lisp.h: ... from here. push_key_description is no longer
1720 defined in keyboard.c, so its declaration should not be in
1721 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1722 logically belongs with push_key_description.
1724 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1726 * buffer.h: Include <sys/types.h> instead of <time.h>.
1727 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1728 Problem reported by Herbert J. Skuhra.
1730 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1732 * xml.c (parse_region): Make the parsing work for
1733 non-comment-starting XML files again (bug#9144).
1735 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1737 * image.c (gif_load): Fix calculation of bottom and right corner.
1740 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1742 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1743 redisplay in small windows.
1745 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1747 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1749 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1751 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1752 Operate on live windows only.
1754 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1756 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1758 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1760 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1761 only under bidi iteration.
1763 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1765 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1767 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1769 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1770 Without this fix, the command to link temacs failed due to an
1771 undefined symbol __builtin_isnan. This is because
1772 /usr/include/iso/math_c99.h #defines isnan(x) to
1773 __builtin_isnan(x), but the bundled gcc, which identifies itself
1774 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1776 * floatfns.c (isnan): #undef, and then #define to a clone of
1778 (Fisnan): Always define, since it's always available now.
1779 (syms_of_floatfns): Always define isnan at the Lisp level.
1781 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1783 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1785 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1787 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1788 The previous code assumed that file offsets (off_t values) fit in
1789 EMACS_INT variables, which is not true on typical 32-bit hosts.
1790 The code messed up by falsely reporting buffer overflow in cases
1791 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1792 when "big" contains more than 2**29 bytes, even though this
1793 inserts just one byte and does not overflow the buffer.
1794 (Finsert_file_contents): Store file offsets as off_t
1795 values, not as EMACS_INT values. Check for overflow when
1796 converting between EMACS_INT and off_t. When checking for
1797 buffer overflow or for overlap, take the offsets into account.
1798 Don't use EMACS_INT for small values where int suffices.
1799 When checking for overlap, fix a typo: ZV was used where
1800 ZV_BYTE was intended.
1801 (Fwrite_region): Don't assume off_t fits into 'long'.
1802 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1804 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1806 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1808 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1810 sprintf-related integer and memory overflow issues (Bug#9412).
1812 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1813 (esprintf, exprintf, evxprintf): New functions.
1814 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1815 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1816 (modify_event_symbol): Do not assume that the length of
1817 name_alist_or_stem is safe to alloca and fits in int.
1818 (Fexecute_extended_command): Likewise for function name and binding.
1819 (Frecursion_depth): Wrap around reliably on integer overflow.
1820 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1821 since some callers pass EMACS_INT values.
1822 (Fsingle_key_description): Don't crash if symbol name contains more
1823 than MAX_ALLOCA bytes.
1824 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1825 (get_minibuffer): Arg is now EMACS_INT, not int.
1826 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1827 (esprintf, exprintf, evxprintf): New decls.
1828 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1830 * dbusbind.c (signature_cat): New function.
1831 (xd_signature, Fdbus_register_signal):
1832 Do not overrun buffer; instead, report string overflow.
1834 * dispnew.c (add_window_display_history): Don't overrun buffer.
1835 Truncate instead; this is OK since it's just a log.
1837 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1838 even if the time zone offset is outlandishly large.
1839 Don't mishandle offset == INT_MIN.
1841 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1842 when creating daemon; the previous buffer-overflow check was incorrect.
1844 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1845 which has the guts of the old verror function.
1847 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1848 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1850 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1851 (font_unparse_xlfd): Don't blindly alloca long strings.
1852 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1853 fits in int, when using sprintf. Use single snprintf to count
1854 length of string rather than counting it via multiple sprintfs;
1855 that's simpler and more reliable.
1856 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1857 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1858 sprintf, in case result does not fit in int.
1860 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1861 (fontset_from_font): Print it.
1863 * frame.c (tty_frame_count): Now printmax_t, not int.
1864 (make_terminal_frame, set_term_frame_name): Print it.
1865 (x_report_frame_params): In X, window IDs are unsigned long,
1866 not signed long, so print them as unsigned.
1867 (validate_x_resource_name): Check for implausibly long names,
1868 and don't assume name length fits in 'int'.
1869 (x_get_resource_string): Don't blindly alloca invocation name;
1870 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1873 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1874 (xg_check_special_colors, xg_set_geometry):
1875 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1877 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1878 Use esprintf, not sprintf, in case result does not fit in int.
1880 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1881 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1882 it as a large positive number.
1883 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1884 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1886 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1887 in case result does not fit in int.
1889 * print.c (float_to_string): Detect width overflow more reliably.
1890 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1891 buffer overrun. Don't assume list length fits in 'int'. Treat
1892 print length of 0 as 0, not as infinity; to be consistent with other
1893 uses of print length in this function. Don't overflow print length
1894 index. Don't assume hash table size fits in 'long', or that
1895 vectorlike size fits in 'unsigned long'.
1897 * process.c (make_process): Use printmax_t, not int, to format
1898 process-name gensyms.
1900 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1902 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1903 to avoid potential buffer overrun.
1905 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1906 if X resource line is longer than 512 bytes.
1908 * xfns.c (x_window): Make sprintf buffer a bit bigger
1909 to avoid potential buffer overrun.
1911 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1913 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1915 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1917 Integer overflow fixes for scrolling, etc.
1918 Without these, Emacs silently mishandles large integers sometimes.
1919 For example, "C-u 4294967297 M-x recenter" was treated as if
1920 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1922 * xdisp.c (try_window_id): Check Emacs fixnum range before
1923 converting to 'int'.
1925 * window.c (window_scroll_line_based, Frecenter):
1926 Check that an Emacs fixnum is in range before assigning it to 'int'.
1927 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1928 values converted from Emacs fixnums.
1929 (Frecenter): Don't wrap around a line count if it is out of 'int'
1930 range; instead, treat it as an extreme value.
1931 (Fset_window_configuration, compare_window_configurations):
1932 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1934 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1935 that can exceed INT_MAX. Check that EMACS_INT value is in range
1936 before assigning it to the (possibly-narrower) index.
1937 (match_limit): Don't assume that a fixnum can fit in 'int'.
1939 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1942 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1943 (Fvertical_motion): Don't wrap around LINES values that don't fit
1944 in 'int'. Instead, treat them as extreme values. This is good
1945 enough for windows, which can't have more than INT_MAX lines anyway.
1947 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949 * Require libxml/parser.h to avoid compilation warning.
1951 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1953 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1954 since this reportedly can destroy thread storage.
1956 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1958 * syntax.c (find_defun_start): Update all cache variables if
1959 exiting early (Bug#9401).
1961 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1963 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1965 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1966 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1967 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1969 * term.c (tty_append_glyph): New function.
1970 (produce_stretch_glyph): Static function and its prototype deleted.
1972 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1975 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1977 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1978 when checking :margin (Bug#9390).
1979 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1980 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1981 so that the name doesn't mislead. All uses changed.
1983 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1985 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1988 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1990 * xdisp.c (move_it_to): Don't bail out early when reaching
1991 position beyond to_charpos, if we are scanning backwards.
1992 (move_it_vertically_backward): When DY == 0, make sure we get to
1993 the first character in the line after the newline.
1995 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1997 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1998 (ccl_driver): Do not generate an out-of-range pointer.
1999 (Fccl_execute_on_string): Remove unnecessary check for
2000 integer overflow, noted by Stefan Monnier in
2001 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2002 Remove a FIXME that didn't need fixing.
2003 Simplify the newly-introduced buffer reallocation code.
2005 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2007 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2009 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2011 Integer and memory overflow issues (Bug#9196).
2013 * doc.c (get_doc_string): Rework so that
2014 get_doc_string_buffer_size is the actual buffer size, rather than
2015 being 1 less than the actual buffer size; this makes xpalloc more
2018 * image.c (x_allocate_bitmap_record, cache_image):
2019 * xselect.c (Fx_register_dnd_atom):
2020 Simplify previous changes by using xpalloc.
2022 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2023 since either will do and ptrdiff_t is convenient with xpalloc.
2025 * charset.c (charset_table_size)
2026 (struct charset_sort_data.priority): Now ptrdiff_t.
2027 (charset_compare): Don't overflow if priorities differ greatly.
2028 (Fsort_charsets): Don't assume list length fits in int.
2029 Check for size-calculation overflow when allocating sort data.
2030 (syms_of_charset): Allocate an initial charset table that is
2031 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2033 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2035 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2036 The actual value is always <= INT_MAX, and leaving it unsigned made
2037 overflow checking harder.
2039 * dispextern.h (struct glyph_matrix.rows_allocated)
2040 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2041 with xpalloc. The values are still always <= INT_MAX.
2043 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2045 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2046 (SAFE_NALLOCA): New macro.
2048 * region-cache.c (struct boundary.pos, find_cache_boundary)
2049 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2050 (set_cache_region, invalidate_region_cache)
2051 (revalidate_region_cache, know_region_cache, region_cache_forward)
2052 (region_cache_backward, pp_cache):
2053 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2054 so that ptrdiff_t * can be passed to xpalloc.
2055 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2056 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2057 (pp_cache): Don't assume cache_len fits in int.
2058 * region-cache.h: Adjust extern decls to match.
2060 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2061 EMACS_INT, since either will do, for xpalloc.
2063 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2064 (xnmalloc, xnrealloc, xpalloc): New functions.
2066 * bidi.c (bidi_shelve_header_size): New constant.
2067 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2068 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2070 * bidi.c (bidi_cache_shrink):
2071 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2073 Don't update size of array until after memory allocation succeeds,
2074 because xmalloc/xrealloc may not return.
2075 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2076 now that we have proper integer overflow checking.
2077 (record_overlay_string, overlay_strings): Catch overflows when
2078 calculating size of overlay_str_buf.
2080 * callproc.c (Fcall_process): Check for size overflow when
2081 calculating size of args2.
2082 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2083 Normally we prefer signed values, but sticking with ptrdiff_t would
2084 require adding more-complicated checks.
2086 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2087 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2088 Redo buffer-overflow calculations to avoid integer overflow.
2089 Add a FIXME comment where memory seems to be over-allocated.
2091 * character.c (Fstring): Check for size-calculation overflow.
2093 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2094 unnecessary integer overflow. Check for size overflow.
2095 (encode_coding_object): Don't update size until xmalloc succeeds.
2097 * composite.c (get_composition_id): Check for overflow in glyph
2098 length calculations.
2100 Integer and memory overflow fixes for display code.
2101 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2102 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2103 (scrolling_window): Check for overflow in size calculations.
2104 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2105 Don't assume glyph table len fits in int.
2106 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2107 (row_table_size): Now ptrdiff_t, not int.
2108 (scrolling_window): Avoid overflow in size calculations.
2109 Don't update size until allocation succeeds.
2110 * fns.c (concat): Check for overflow in size calculations.
2111 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2112 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2113 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2115 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2116 (get_doc_string): Check for size calculation overflow.
2117 Don't update size until allocation succeeds.
2118 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2119 EMACS_INT, where ptrdiff_t will do.
2120 (Fsubstitute_command_keys): Check for string overflow.
2122 * editfns.c (set_time_zone_rule): Don't assume environment length
2124 (message_length): Now ptrdiff_t, not int.
2125 (Fmessage_box): Don't update size until allocation succeeds.
2126 Don't assume message length fits in int.
2127 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2129 * emacs.c (main): Do not reallocate argv, since there is a null at
2130 the end that can be overwritten, and this way there's no need to
2131 worry about size-calculation overflow.
2132 (sort_args): Check for size-calculation overflow.
2134 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2136 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2138 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2139 (x_set_scroll_bar_width, x_figure_window_size):
2140 Check for integer overflow.
2141 (x_set_alpha): Do not assume XINT fits in int.
2143 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2144 This is for the members text_lines, text_cols, total_lines, total_cols,
2145 where the system imposes an 'int' limit.
2147 * fringe.c (Fdefine_fringe_bitmap):
2148 Don't update size until alloc works.
2150 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2151 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2153 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2154 Check for size-calculation overflow.
2155 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2156 do, as we prefer signed integers.
2157 (id_to_widget.max_size, id_to_widget.used)
2158 (xg_store_widget_in_map, xg_remove_widget_from_map)
2159 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2160 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2161 Use and return ptrdiff_t, not int.
2162 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2163 * gtkutil.h: Change prototypes to match the above.
2165 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2166 are duplicate now that they've been promoted to lisp.h.
2167 (x_allocate_bitmap_record, x_alloc_image_color)
2168 (make_image_cache, cache_image, xpm_load):
2169 Don't update size until alloc is done.
2170 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2172 Check for size calculation overflow.
2173 (ct_colors_allocated_max): New constant.
2174 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2177 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2178 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2179 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2180 Use ptrdiff_t, not int, to count maps.
2181 (read_char_minibuf_menu_prompt): Check for overflow in size
2182 calculations. Don't update size until allocation succeeds.
2183 Redo calculations to avoid overflow.
2184 * keyboard.h: Change prototypes to match the above.
2186 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2188 (current_minor_maps): Check for size calculation overflow.
2189 * keymap.h: Change prototypes to match the above.
2191 * lread.c (read1, init_obarray): Don't update size until alloc done.
2193 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2194 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2196 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2197 Now ptrdiff_t, not int.
2198 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2199 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2201 * process.c (Fnetwork_interface_list): Check for overflow
2202 in size calculation.
2204 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2206 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2207 overflow. Don't bother calling xmalloc when xrealloc will do.
2209 * search.c (Freplace_match): Check for size calculation overflow.
2210 (Fset_match_data): Don't assume list lengths fit in 'int'.
2212 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2213 for command line length. Do not attempt to address one before the
2214 beginning of an array, as that's not portable.
2216 * term.c (max_frame_lines): Remove; unused.
2217 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2219 (encode_terminal_code, calculate_costs): Check for size
2220 calculation overflow.
2221 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2222 table lengths and related sizes. Don't update size until alloc
2223 done. Redo calculations to avoid overflow.
2224 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2226 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2227 subtracting pointers.
2228 (gobble_line): Check for overflow more carefully. Don't update size
2231 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2232 Don't update size until alloc done.
2233 Redo size calculations to avoid overflow.
2234 Check for size calculation overflow.
2235 (main) [DEBUG]: Fix typo in invoking tparam1.
2237 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2238 Use ptrdiff_t, not int, for sizes.
2239 (store_mode_line_noprop_char): Don't update size until alloc done.
2241 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2242 Use ptrdiff_t, not int, for sizes.
2243 (Finternal_make_lisp_face, cache_face):
2244 Check for size calculation overflow.
2245 (cache_face): Treat size calculation overflows as if they were
2246 memory exhaustion (the usual treatment), rather than aborting.
2248 * xfns.c (x_encode_text, x_set_name_internal)
2249 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2250 sizes, since they can exceed INT_MAX in size. Check for size
2251 calculation overflow.
2253 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2254 (xg_select): Check for size calculation overflow.
2255 Don't update size until alloc done.
2257 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2258 as sprintf is limited to int lengths.
2260 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2261 (X_LONG_MIN): New macros.
2262 Use them to make the following changes clearer.
2263 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2264 This change doesn't affect the value now, but it may help remind
2265 future maintainers not to raise the value too much later.
2266 (SELECTION_QUANTUM): Remove, replacing with ...
2267 (selection_quantum): ... new function, which avoids overflow.
2269 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2270 assumption that selection length fits in 'int'.
2271 (x_reply_selection_request, x_handle_selection_request)
2272 (x_get_window_property, receive_incremental_selection)
2273 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2274 (lisp_data_to_selection_data, clean_local_selection_data):
2275 Use ptrdiff_t, not int, to record length of selection.
2276 (x_reply_selection_request, x_get_window_property)
2277 (receive_incremental_selection, x_property_data_to_lisp):
2278 Redo calculations to avoid overflow.
2279 (x_reply_selection_request): When sending hint, ceiling it at
2280 X_LONG_MAX rather than relying on wraparound overflow to send
2282 (x_get_window_property, receive_incremental_selection)
2283 (lisp_data_to_selection_data, x_property_data_to_lisp):
2284 Check for size-calculation overflow.
2285 (x_get_window_property, receive_incremental_selection)
2286 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2287 Don't store size until memory allocation succeeds.
2288 (x_get_window_property): Plug memory leak on memory exhaustion.
2289 Don't double-block input; malloc is safe here. Don't assume 2**34
2290 - 4 fits in unsigned long. Add an xassert to check
2291 XGetWindowProperty overflow. Be more careful about overflow
2292 calculations, and distinguish size from memory overflow better.
2293 (receive_incremental_selection): When tracing, don't assume
2294 unsigned int is less than INT_MAX.
2295 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2296 harmful) conversions of unsigned short to int.
2297 (lisp_data_to_selection_data): Don't assume that integers
2298 in the range -65535 through -1 fit in an X unsigned short.
2299 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2300 result parameters unless successful. Rely on cons_to_unsigned
2301 to report problems with elements; the old code wasn't right anyway.
2302 (x_check_property_data): Check for int overflow; we cannot use
2303 a wider type due to X limits.
2304 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2306 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2308 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2309 (x_term_init): Check for size calculation overflow.
2310 (x_color_cells): Don't store size until memory allocation succeeds.
2311 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2312 Don't assume alloca size is less than MAX_ALLOCA.
2313 (x_term_init): Don't assume length fits in int (sprintf is limited
2316 Use ptrdiff_t for composition IDs.
2317 * character.c (lisp_string_width):
2318 * composite.c (composition_table_size, n_compositions)
2319 (get_composition_id, composition_gstring_from_id):
2320 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2321 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2322 * window.c (Frecenter):
2323 Use ptrdiff_t, not int, for composition IDs.
2324 * composite.c (get_composition_id): Check for integer overflow.
2325 * composite.h: Adjust prototypes to match the above changes.
2327 Use ptrdiff_t for hash table indexes.
2328 * category.c (hash_get_category_set):
2329 * ccl.c (ccl_driver):
2330 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2331 * coding.c (coding_system_charset_list, detect_coding_system):
2332 * coding.h (struct coding_system.id):
2333 * composite.c (get_composition_id, gstring_lookup_cache):
2334 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2335 * image.c (xpm_get_color_table_h):
2336 * lisp.h (hash_lookup, hash_put):
2337 * minibuf.c (Ftest_completion):
2338 Use ptrdiff_t for hash table indexes, not int (which is too
2339 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2340 32-bit --with-wide-int hosts).
2342 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2343 Add a FIXME comment about memory leaks.
2344 (syms_of_charset): Don't assume xmalloc returns.
2346 Don't assume that stated character widths fit in int.
2347 * character.c (Fchar_width, c_string_width, lisp_string_width):
2348 * character.h (CHAR_WIDTH):
2349 * indent.c (MULTIBYTE_BYTES_WIDTH):
2350 Use sanitize_char_width to avoid undefined and/or bad behavior
2351 with outlandish widths.
2352 * character.h (sanitize_tab_width): Rename from sanitize_width,
2353 now that we have two such functions. All uses changed.
2354 (sanitize_char_width): New inline function.
2356 Don't assume that tab-width fits in int.
2357 * character.h (sanitize_width): New inline function.
2358 (SANE_TAB_WIDTH): New macro.
2359 (ASCII_CHAR_WIDTH): Use it.
2360 * indent.c (sane_tab_width): Remove. All uses replaced by
2361 SANE_TAB_WIDTH (current_buffer).
2362 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2364 * fileio.c: Integer overflow issues with file modes.
2365 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2367 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2368 Remove unreachable code.
2369 (read_hex, load_charset_map_from_file): Check for integer overflow.
2371 * xterm.c: don't go over XClientMessageEvent limit
2372 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2373 (x_send_scroll_bar_event): Likewise. Check that the size does not
2374 exceed limits imposed by XClientMessageEvent, as well as the usual
2375 ptrdiff_t and size_t limits.
2377 * keyboard.c: Overflow, signedness and related fixes.
2378 (make_lispy_movement): Use same integer type in forward decl
2379 that is used in the definition.
2380 (read_key_sequence, keyremap_step):
2381 Change bufsize argument back to int, undoing my 2011-03-30 change.
2382 We prefer signed types, and int is wide enough here.
2383 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2384 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2385 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2386 length, not size_t. Use ptrdiff_t for index, not int.
2387 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2388 possibility of integer overflow.
2390 Overflow, signedness and related fixes for images.
2392 * dispextern.h (struct it.stack[0].u.image.image_id)
2393 (struct_it.image_id, struct image.id, struct image_cache.size)
2394 (struct image_cache.used, struct image_cache.ref_count):
2395 * gtkutil.c (update_frame_tool_bar):
2396 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2397 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2398 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2399 * nsmenu.m (update_frame_tool_bar):
2400 * xdisp.c (calc_pixel_width_or_height):
2401 * xfns.c (image_cache_refcount):
2402 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2403 on typical 64-bit hosts.
2405 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2406 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2407 Omit unnecessary casts to int.
2408 (parse_image_spec): Check that integers fall into 'int' range
2409 when the callers expect that.
2410 (image_ascent): Redo ascent calculation to avoid int overflow.
2411 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2412 (lookup_image): Remove unnecessary tests.
2413 (xbm_image_p): Locals are now of int, not EMACS_INT,
2414 since parse_image_check makes sure they fit into int.
2415 (png_load, gif_load, svg_load_image):
2416 Prefer int to unsigned where either will do.
2417 (tiff_handler): New function, combining the cores of the
2418 old tiff_error_handler and tiff_warning_handler.
2419 This function is rewritten to use vsnprintf and thereby avoid
2420 stack buffer overflows. It uses only the features of vsnprintf
2421 that are common to both POSIX and native Microsoft.
2422 (tiff_error_handler, tiff_warning_handler): Use it.
2423 (tiff_load, gif_load, imagemagick_load_image):
2424 Don't assume :index value fits in 'int'.
2425 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2426 (imagemagick_load_image): Check that crop parameters fit into
2427 the integer types that MagickCropImage accepts. Don't assume
2428 Vimagemagick_render_type has a nonnegative value. Don't assume
2429 size_t fits in 'long'.
2430 (gs_load): Use printmax_t to print the widest integers possible.
2431 Check for integer overflow when computing image height and width.
2433 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2435 * xdisp.c (redisplay_window): Don't force window start if point
2436 will be invisible in the resulting window. (Bug#9324)
2438 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2440 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2441 the display spec is of the form `(space ...)'.
2442 (handle_display_spec): Return the value returned by
2443 handle_single_display_spec, not just 1 or zero.
2444 (handle_single_display_spec): If the display spec is of the form
2445 `(space ...)', and specifies display in the text area, return 2
2447 (try_cursor_movement): Check for the need to scroll more
2448 accurately, and prefer exact match for point under bidi.
2449 Don't advance `row' beyond the last row of the window.
2451 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2452 into disp_prop; all users changed.
2454 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2455 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2456 for the text covered by the display property.
2458 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2460 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2461 Change return value to nil.
2462 (Frecord_buffer): Delete unused function.
2464 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2466 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2467 buffers, return left-to-right.
2468 (set_cursor_from_row): Consider candidate row a win if its glyph
2469 represents a newline and point is on that newline. Fixes cursor
2470 positioning on the newline at EOL of R2L text within L2R
2471 paragraph, and vice versa.
2472 (try_cursor_movement): Check continued rows, in addition to
2473 continuation rows. Fixes unwarranted scroll when point enters a
2474 continued line of R2L text within an L2R paragraph, or vice versa.
2475 (cursor_row_p): Consider the case of point being equal to
2476 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2477 from the end of a short line to the beginning of a continued line
2478 of R2L text within L2R paragraph.
2479 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2480 composed characters.
2482 * bidi.c (bidi_check_type): Use xassert.
2483 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2486 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2488 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2491 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2493 * nsfont.m (ns_otf_to_script): Fix typo.
2495 2011-08-22 Kenichi Handa <handa@m17n.org>
2497 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2498 extra slot even if the purpose is char-code-property-table.
2500 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2502 * xdisp.c (redisplay_window): When computing centering_position,
2503 account for the height of the header line. (Bug#8874)
2505 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2506 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2507 candidate is selected by the mouse, and that candidate has a
2508 composed character under the mouse.
2510 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2511 coordinates reported by pos-visible-in-window-p for a composed
2512 character in column zero.
2514 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2516 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2518 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2520 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2521 consider it a hit if to_charpos is anywhere in the range of the
2522 composed buffer positions.
2524 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2526 * image.c (gif_load): Don't assume that each subimage has the same
2527 dimensions as the base image. Handle disposal method that is
2528 "undefined" by the gif spec (Bug#9335).
2530 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2532 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2533 (Fcondition_case): Document `debug' symbol in error handler.
2535 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2537 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2538 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2539 from an Org mode buffer to a Speedbar frame.
2541 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2542 a composition, take its buffer position from IT->cmp_it.charpos.
2543 Fixes cursor positioning at the beginning of a line that begins
2544 with a composed character.
2546 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2548 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2549 character bidirectional type, use STRONG_L instead. Fixes crashes
2550 in a buffer produced by `describe-categories'.
2552 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2553 members before the level stack, so they would be saved and
2554 restored when copying iterator state. Fixes incorrect reordering
2555 around TABs covered by display properties.
2557 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2559 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2561 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2563 * eval.c (internal_condition_case, internal_condition_case_1)
2564 (internal_condition_case_2, internal_condition_case_n):
2565 Remove unnecessary aborts (Bug#9081).
2567 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2569 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2570 has no `load' handler, try opening the file locally. (Bug#9311)
2572 2011-08-16 Ken Brown <kbrown@cornell.edu>
2574 * gmalloc.c: Expand comment.
2576 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2578 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2579 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2581 2011-08-16 Ken Brown <kbrown@cornell.edu>
2583 Fix memory allocation problems in Cygwin build (Bug#9273).
2585 * unexcw.c ( __malloc_initialized): Declare external variable.
2586 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2588 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2590 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2592 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2594 [CYGWIN] (special_realloc): New function.
2595 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2596 requests to realloc storage in the static heap.
2598 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2600 * bidi.c (bidi_initialize): Remove unused local.
2602 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2605 * biditype.h: Remove file.
2606 * makefile.w32-in ($(BLD)/bidi.$(O)):
2607 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2609 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2611 * chartab.c: Improve commentary for the uniprop_table API.
2613 * bidi.c (bidi_paragraph_init): Support zero value of
2614 bidi_ignore_explicit_marks_for_paragraph_level.
2615 (bidi_initialize): Use uniprop_table instead of including
2616 biditype.h and bidimirror.h.
2618 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2619 coordinates of the iterator when restoring from ppos_it.
2622 2011-08-14 Kenichi Handa <handa@m17n.org>
2624 * process.c (create_process): Call setup_process_coding_systems
2625 after the pid of the process is set to -1 (Bug#8162).
2627 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2629 * xdisp.c (move_it_in_display_line_to): Don't invoke
2630 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2631 ppos_it. Fixes vertical cursor motion when line beginning is
2632 covered by an image. (Bug#9296)
2634 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2636 * nsterm.h (ns_run_ascript): Declare.
2637 (NSAPP_DATA2_RUNASSCRIPT): Define.
2639 * nsfns.m (as_script, as_result, as_status): New static variables.
2640 (ns_run_ascript): New function.
2641 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2642 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2643 the event loop. Get status from as_status (Bug#7276).
2645 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2646 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2647 the event loop (Bug#7276).
2649 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2651 * gnutls.c (QCgnutls_bootprop_priority)
2652 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2653 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2654 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2655 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2656 (QCgnutls_bootprop_verify_hostname_error)
2657 (QCgnutls_bootprop_callbacks_verify): Rename from
2658 Qgnutls_bootprop_..., all uses changed.
2660 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2663 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2665 * xfaces.c (Qframe_set_background_mode): Now static.
2666 * dispextern.h (Qframe_set_background_mode): Remove decl.
2668 * process.c (Fnetwork_interface_info): Declare local only if needed.
2670 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2672 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2673 (Fnetwork_interface_list): Allocate in increments of bytes instead
2674 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2675 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2677 (struct ifflag_def): notrailers is smart on OSX.
2678 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2679 Get hardware address with getifaddrs if available.
2681 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2683 * xdisp.c (iterate_out_of_display_property): xassert that
2684 IT->position is set to within IT->object's boundaries. Break from
2685 the loop as soon as EOB is reached; avoids infloops in redisplay
2686 when IT->position is set up wrongly due to some bug.
2687 Set IT->current to match the bidi iterator unconditionally.
2688 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2689 entry. Force push_it to save on the stack the current
2690 buffer/string position, to be restored by pop_it. Fix flags in
2691 the iterator structure wrt the object coming from a display
2692 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2693 properties. (Bug#9284)
2695 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2697 * fontset.c (fontset_get_font_group): Add proper type checks.
2700 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2702 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2703 and LC_VERSION_MIN_MACOSX.
2704 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2705 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2707 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2709 * xdisp.c (forward_to_next_line_start): Allow to use the
2710 no-display-properties-and-no-overlays under bidi display.
2711 Set disp_pos in the bidi iterator to avoid searches for display
2712 properties and overlays.
2714 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2716 * editfns.c (Fset_time_zone_rule): Document relationship with the
2719 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2720 the font entity extracted from the cache (Bug#8109).
2722 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2724 * composite.c (autocmp_chars): Don't reset point. That is done by
2725 restore_point_unwind (Bug#5984).
2727 2011-08-07 Juri Linkov <juri@jurta.org>
2729 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2730 to show the arg `TIME' instead of `TIMEVAL'.
2732 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2734 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2735 display property strides EOL and includes a newline, as in
2736 longlines-mode. (Bug#9254)
2737 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2738 word-wrap under bidirectional display. (Bug#9224)
2740 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2741 is non-zero, even if the data buffer is NULL. Fixes a crash in
2742 vertical-motion with longlines-mode. (Bug#9254)
2744 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2746 * bidi.c <bidi_cache_total_alloc>: Now static.
2747 (bidi_initialize): Initialize bidi_cache_total_alloc.
2749 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2752 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2753 amount allocated this far in `bidi_cache_total_alloc'.
2754 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2755 non-zero, only free the data buffer without restoring the cache
2756 contents. All callers changed.
2758 * dispextern.h (bidi_unshelve_cache): Update prototype.
2760 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2761 (move_it_in_display_line, move_it_to)
2762 (move_it_vertically_backward, move_it_by_lines): Replace the call
2763 to xfree to an equivalent call to bidi_unshelve_cache.
2764 (move_it_in_display_line_to): Fix logic of returning
2765 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2767 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2769 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2770 came from a string character with a `cursor' property. (Bug#9229)
2772 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2774 * Makefile.in (LIB_PTHREAD): New variable.
2775 (LIBES): Add LIB_PTHREAD (Bug#9216).
2777 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2778 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2780 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2782 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2784 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2786 * xterm.c (x_find_topmost_parent): New function.
2787 (x_set_frame_alpha): Find topmost parent window with
2788 x_find_topmost_parent and set the property there also (bug#9181).
2789 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2791 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2793 * callproc.c (Fcall_process): Avoid vfork clobbering
2794 the local vars buffer, coding_systems, current_dir.
2796 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2798 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2800 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2802 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2803 so that it is not optimized away.
2805 * xdisp.c (compute_display_string_pos): Remove unused local.
2807 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2809 Fix slow cursor motion and scrolling in large buffers with
2810 selective display, like Org Mode buffers. (Bug#9218)
2812 * dispextern.h (struct bidi_it): New member disp_prop_p.
2814 * xdisp.c: Remove one-slot cache of display string positions.
2815 (compute_display_string_pos): Accept an additional argument
2816 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2817 for a display string or property. If found, set DISP_PROP_P
2820 * bidi.c (bidi_fetch_char): Accept an additional argument
2821 DISP_PROP_P, and pass it to compute_display_string_pos.
2822 Only handle text covered by a display string if DISP_PROP_P is returned
2823 non-zero. All callers of bidi_fetch_char changed.
2825 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2827 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2829 2010-12-03 Don March <don@ohspite.net>
2831 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2832 last character M-[char] is translated to ESC [char] (bug#7541).
2834 2011-08-02 Kenichi Handa <handa@m17n.org>
2836 * lisp.h (uniprop_table): Extern it.
2838 * chartab.c (uniprop_table): Make it non-static.
2840 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2842 * xdisp.c (forward_to_next_line_start): Accept additional argument
2843 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2845 (reseat_at_next_visible_line_start): Use the bidi iterator state
2846 returned by forward_to_next_line_start to restore the state of
2847 it->bidi_it after backing up to previous newline. (Bug#9212)
2849 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2851 * regex.c (re_comp): Protoize.
2852 (re_exec): Fix return type.
2853 (regexec): Fix type of `ret'. (Bug#9203)
2855 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2857 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2858 This is needed if max-image-size is a floating-point number.
2860 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2862 * print.c (print_object): Print empty symbol as ##.
2864 * lread.c (read1): Read ## as empty symbol.
2866 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2868 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2869 setting frame foreground color (Bug#9175).
2870 (x_set_background_color): Likewise.
2872 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2873 contents (Bug#9176).
2874 (EmacsTooltip -init): Remove bezels and add shadows to
2877 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2878 or scroll bar (Bug#8470).
2880 * nsfont.m (nsfont_open): Remove assignment to voffset and
2881 unnecessary vars hshink, expand, hd, full_height, min_height.
2882 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2884 * nsterm.h (nsfont_info): Remove voffset field.
2886 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2888 Implement strike-through and overline on NextStep (Bug#8863).
2890 * nsfont.m (nsfont_open): Use underline position provided by font,
2891 instead of hard-coded value of 2.
2892 (nsfont_draw): Call ns_draw_text_decoration instead.
2894 * nsterm.h: Add declaration for ns_draw_text_decoration.
2896 * nsterm.m (ns_draw_text_decoration): New function for drawing
2897 underline, overline, and strike-through.
2898 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2899 ns_draw_text_decoration. Change treatment of cursor drawing to
2900 accommodate underlining, etc.
2902 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2904 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2907 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2909 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2910 Without this fix, if a signal arrives just after memory fills up,
2911 'malloc' might be invoked reentrantly.
2913 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2914 In other words, assume that every image size is allowed, on non-X
2915 hosts. This assumption is probably wrong, but it lets Emacs compile.
2917 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2919 * regex.c (re_iswctype): Convert return values to boolean.
2921 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2923 * xdisp.c (compute_display_string_pos): Don't use cached display
2924 string position if the buffer had its restriction changed.
2927 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2929 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2931 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2933 Integer signedness and overflow and related fixes. (Bug#9079)
2935 * bidi.c: Integer size and overflow fixes.
2936 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2937 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2938 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2939 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2940 (bidi_find_other_level_edge):
2941 Use ptrdiff_t instead of EMACS_INT where either will do.
2942 This works better on 32-bit hosts configured --with-wide-int.
2943 (bidi_cache_ensure_space): Check for size-calculation overflow.
2944 Use % rather than repeated addition, for better worst-case speed.
2945 Don't set bidi_cache_size until after xrealloc returns, because it
2947 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2948 (bidi_cache_ensure_space): Also check that the bidi cache size
2949 does not exceed that of the largest Lisp string or buffer. See Eli
2950 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2952 * alloc.c (__malloc_size_t): Remove.
2953 All uses replaced by size_t. See Andreas Schwab's note
2954 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2956 * image.c: Improve checking for integer overflow.
2957 (check_image_size): Assume that f is nonnull, since
2958 it is always nonnull in practice. This is one less thing to
2959 worry about when checking for integer overflow later.
2960 (x_check_image_size): New function, which checks for integer
2961 overflow issues inside X.
2962 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2963 This removes the need for a memory_full check.
2964 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2965 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2966 (xbm_read_bitmap_data): Change locals back to 'int', since
2967 their values must fit in 'int'.
2968 (xpm_load_image, png_load, tiff_load):
2969 Invoke x_create_x_image_and_pixmap earlier,
2970 to avoid much needless work if the image is too large.
2971 (tiff_load): Treat overly large images as if
2972 x_create_x_image_and_pixmap failed, not as malloc failures.
2973 (gs_load): Use x_check_image_size.
2975 * gtkutil.c: Omit integer casts.
2976 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2977 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2979 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2981 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2982 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2983 would wrongly return t on a 64-bit host.
2985 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2986 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2987 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2988 and therefore cause GCC to emit a bogus diagnostic in some cases.
2990 * image.c: Integer signedness and overflow and related fixes.
2991 This is not an exhaustive set of fixes, but it's time to
2992 record what I've got.
2993 (lookup_pixel_color, check_image_size): Remove redundant decls.
2994 (check_image_size): Don't assume that arbitrary EMACS_INT values
2995 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2996 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2997 (tiff_load, imagemagick_load_image):
2998 Check for overflow in size calculations.
2999 (x_create_x_image_and_pixmap): Remove unnecessary test for
3000 xmalloc returning NULL; that can't happen.
3001 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3002 (xpm_color_bucket): Use better integer hashing function.
3003 (xpm_cache_color): Don't possibly over-allocate memory.
3004 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3005 (gif_memory_source):
3006 Use ptrdiff_t, not int or size_t, to record sizes.
3007 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3008 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3009 either works, as we prefer signed integers.
3010 (tiff_read_from_memory, tiff_write_from_memory):
3011 Return tsize_t, not size_t, since that's what the TIFF API wants.
3012 (tiff_read_from_memory): Don't fail simply because the read would
3013 go past EOF; instead, return a short read.
3014 (tiff_load): Omit no-longer-needed casts.
3015 (Fimagemagick_types): Don't assume size fits into 'int'.
3017 Improve hashing quality when configured --with-wide-int.
3018 * fns.c (hash_string): New function, taken from sxhash_string.
3019 Do not discard information about ASCII character case; this
3020 discarding is no longer needed.
3021 (sxhash-string): Use it. Change sig to match it. Caller changed.
3022 * lisp.h: Declare it.
3023 * lread.c (hash_string): Remove, since we now use fns.c's version.
3024 The fns.c version returns a wider integer if --with-wide-int is
3025 specified, so this should help the quality of the hashing a bit.
3027 * emacs.c: Integer overflow minor fix.
3028 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3029 Define only if GNU_LINUX.
3030 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3032 * dispnew.c: Integer signedness and overflow fixes.
3033 Remove unnecessary forward decls, that were a maintenance hassle.
3034 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3036 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3037 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3038 (prepare_desired_row, line_draw_cost):
3039 Use int, not unsigned, where either works.
3040 (save_current_matrix, restore_current_matrix):
3041 Use ptrdiff_t, not size_t, where either works.
3042 (init_display): Check for overflow more accurately, and without
3043 relying on undefined behavior.
3045 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3046 Remove, replacing with the new symbols in lisp.h. All uses changed.
3047 * fileio.c (make_temp_name):
3048 * filelock.c (lock_file_1, lock_file):
3049 * xdisp.c (message_dolog):
3050 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3051 Use pMd etc. instead.
3052 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3053 replacing the pWIDE etc. symbols removed from editfns.c.
3055 * keyboard.h (num_input_events): Now uintmax_t.
3056 This is (very slightly) less likely to mess up due to wraparound.
3059 * buffer.c: Integer signedness fixes.
3060 (alloc_buffer_text, enlarge_buffer_text):
3061 Use ptrdiff_t rather than size_t when either will do, as we prefer
3064 * alloc.c: Integer signedness and overflow fixes.
3065 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3066 (__malloc_size_t): Default to size_t, not to int.
3067 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3068 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3069 Prefer ptrdiff_t to size_t when either would do, as we prefer
3071 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3072 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3073 Now const. Initialize with values that are in range even if char
3075 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3076 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3077 These functions do the right thing with sizes > 2**32.
3078 (check_depth): Now ptrdiff_t, not int.
3079 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3080 Adjust to new way of storing sizes. Check for size overflow bugs
3082 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3083 slightly wrong anyway, as it missed one instance of
3084 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3085 (refill_memory_reserve): Omit needless cast to size_t.
3086 (mark_object_loop_halt): Mark as externally visible.
3088 * xselect.c: Integer signedness and overflow fixes.
3089 (Fx_register_dnd_atom, x_handle_dnd_message):
3090 Use ptrdiff_t, not size_t, since we prefer signed.
3091 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3092 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3093 x_dnd_atoms_size and x_dnd_atoms_length.
3095 * doprnt.c: Prefer signed to unsigned when either works.
3097 * doprnt.c (doprnt):
3099 * xdisp.c (vmessage):
3100 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3101 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3102 prefer signed arithmetic to avoid comparison confusion.
3103 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3104 but is a bit tricky.
3106 Assume freestanding C89 headers, string.h, stdlib.h.
3107 * data.c, doprnt.c, floatfns.c, print.c:
3108 Include float.h unconditionally.
3109 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3110 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3111 * regex.c: Likewise for stddef.h, string.h.
3112 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3113 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3114 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3115 (STDC_HEADERS): Remove obsolete defines.
3116 * sysdep.c: Include limits.h unconditionally.
3118 Assume support for memcmp, memcpy, memmove, memset.
3119 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3120 * regex.c (memcmp, memcpy):
3121 Remove; we assume C89 now.
3123 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3124 (__malloc_safe_bcopy): Remove; no longer needed.
3126 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3127 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3128 well either way, and we prefer signed to unsigned.
3130 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3132 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3133 closes the connection while we're reading (bug#9182).
3135 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3137 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3138 are specified (Bug#9168).
3140 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3142 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3143 Found by GCC static checking and --with-wide-int on a 32-bit host.
3145 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3147 * xdisp.c (compute_display_string_pos): Fix logic of caching
3148 previous display string position. Initialize cached_prev_pos to
3149 -1. Fixes slow-down at the beginning of a buffer.
3151 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3153 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3154 for attrs[LFACE_FONTSET_INDEX].
3156 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3158 * xml.c (parse_region): Remove unused local
3159 that was recently introduced.
3161 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3163 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3164 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3166 * xdisp.c (move_it_in_display_line_to): Record the best matching
3167 position for TO_CHARPOS while scanning the line, and restore it on
3168 exit if none of the characters scanned was an exact match.
3169 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3170 when exact match is impossible due to invisible text, and the
3171 lines are truncated.
3173 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3175 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3178 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3180 Fix a significant slow-down of cursor motion with C-n, C-p,
3181 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3182 auto-repeat under bidi redisplay in fontified buffers.
3183 * xdisp.c (compute_stop_pos_backwards): New function.
3184 (next_element_from_buffer): Call compute_stop_pos_backwards to
3185 find a suitable prev_stop when we find ourselves before
3187 (reseat): Don't look for prev_stop, as that could mean a very long
3189 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3190 <cached_disp_overlay_modiff>: Cache for last found display string
3192 (compute_display_string_pos): Return the cached position if asked
3193 about the same buffer in the same area of character positions, and
3194 the buffer wasn't changed since the time the display string
3195 position was cached.
3197 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3199 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3200 is an integer, which is important for empty lines. (Bug#9149)
3202 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3204 * frame.c (Fmodify_frame_parameters): In tty case, update the
3205 default face if necessary (Bug#4238).
3207 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3209 * editfns.c (Fstring_to_char): No need to explain what a character
3210 is in the docstring (Bug#6576).
3212 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3214 * xml.c (parse_region): Make sure we always return a tree.
3216 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3218 * xml.c (parse_region): If a document contains only comments,
3221 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3223 * xml.c (make_dom): Return comments, too.
3225 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3228 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3229 and the surrounding thread.
3230 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3231 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3232 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3234 * s/openbsd.h (BROKEN_SIGIO): Define.
3235 * unexelf.c (unexec) [__OpenBSD__]:
3236 Don't update the .mdebug section of the Alpha COFF symbol table.
3238 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3240 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3243 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3245 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3246 This fixes some race conditions on the permissions of any newly
3249 * alloc.c (valid_pointer_p): Use pipe, not open.
3250 This fixes some permissions issues when debugging.
3252 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3253 If fchown fails to set both uid and gid, try to set just gid,
3254 as that is sometimes allowed. Adjust the file's mode to eliminate
3255 setuid or setgid bits that are inappropriate if fchown fails.
3257 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3259 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3260 to compare Lisp_Objects.
3261 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3262 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3263 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3265 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3267 * lread.c (read_integer): Unread even EOF character.
3268 (read1): Likewise. Properly record start position of symbol.
3270 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3271 symbol character follows.
3273 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3275 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3276 This works around a problem with the previous change to Fcopy_file.
3277 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3278 and without this change, GCC might complain about discarding
3279 fchown's return value.
3281 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3283 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3285 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3287 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3289 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3291 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3292 it's used from the C level.
3294 * process.c: Use the same condition for POLL_FOR_INPUT in both
3295 keyboard.c and process.c (bug#1858).
3297 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3299 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3300 (Fgnutls_boot): Use it.
3302 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3304 * doc.c (Fsubstitute_command_keys): Revert last change.
3306 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3308 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3309 quotes the next character, and doesn't affect other longer
3310 sequences (bug#8935).
3312 * lread.c (syms_of_lread): Clarify that is isn't only
3313 `eval-buffer' and `eval-defun' that's affected by
3314 `lexical-binding' (bug#8460).
3316 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3318 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3319 bidi redisplay when a line includes both an image and is truncated.
3321 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3323 Fix minor problems found by static checking.
3324 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3325 (elsz): Now a signed constant, not a size_t var. We prefer signed
3326 types to unsigned, to avoid integer comparison confusion. Without
3327 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3328 "cannot optimize loop, the loop counter may overflow", a symptom
3330 * indent.c (Fvertical_motion): Mark locals as initialized.
3331 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3333 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3335 * search.c (Fre_search_backward): Mention `case-fold-search' in
3336 all the re_search_* functions (bug#8138).
3338 * keyboard.c (Fopen_dribble_file): Document when the file is
3341 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3343 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3346 Support bidi reordering of display and overlay strings.
3347 * xdisp.c (compute_display_string_pos)
3348 (compute_display_string_end): Accept additional argument STRING.
3349 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3350 (reseat_to_string): Initialize bidi_it->string.s and
3351 bidi_it->string.schars.
3352 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3353 NULL (avoids a crash in bidi_paragraph_init).
3354 Initialize itb.string.lstring.
3355 (init_iterator): Call bidi_init_it only of a valid
3356 buffer position was specified. Initialize paragraph_embedding to
3358 (reseat_to_string): Initialize the bidi iterator.
3359 (display_string): If we need to ignore text properties of
3360 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3361 original value of -1 will not work with bidi.)
3362 (compute_display_string_pos): First arg is now struct
3363 `text_pos *'; all callers changed. Support display properties on
3365 (compute_display_string_end): Support display properties on Lisp
3367 (init_iterator, reseat_1, reseat_to_string): Initialize the
3368 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3369 when iterating on a string not from display properties).
3370 (compute_display_string_pos, compute_display_string_end):
3371 Fix calculation of the object to scan. Fixes an error when using
3373 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3374 base_level_stop; instead, set base_level_stop to BEGV.
3375 Fixes crashes in vertical-motion.
3376 (next_element_from_buffer): Improve commentary for when
3377 the iterator is before prev_stop.
3378 (init_iterator): Initialize bidi_p from the default value of
3379 bidi-display-reordering, not from buffer-local value. Use the
3380 buffer-local value only if initializing for buffer iteration.
3381 (handle_invisible_prop): Support invisible properties on strings
3382 that are being bidi-reordered.
3383 (set_iterator_to_next): Support bidi reordering of C strings and
3385 (next_element_from_string): Support bidi reordering of Lisp
3387 (handle_stop_backwards): Support Lisp strings as well.
3388 (display_string): Support display of R2L glyph rows.
3389 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3390 (init_iterator): Don't initialize it->bidi_p for strings
3392 (reseat_to_string): Initialize it->bidi_p for strings here.
3393 (next_element_from_string, next_element_from_c_string)
3394 (next_element_from_buffer): Add xassert's for correspondence
3395 between IT's object being iterated and it->bidi_it.string
3397 (face_before_or_after_it_pos): Support bidi iteration.
3398 (next_element_from_c_string): Handle the case of the first string
3399 character that is not the first one in the visual order.
3400 (get_visually_first_element): New function, refactored from common
3401 parts of next_element_from_buffer, next_element_from_string, and
3402 next_element_from_c_string.
3403 (tool_bar_lines_needed, redisplay_tool_bar)
3404 (display_menu_bar): Force left-to-right direction. Add a FIXME
3405 comment for making that be controlled by a user option.
3406 (push_it, pop_it): Save and restore the state of the
3407 bidi iterator. Save and restore the bidi_p flag.
3408 (pop_it): Iterate out of display property for string iteration as
3410 (iterate_out_of_display_property): Support iteration over strings.
3411 (handle_single_display_spec): Set up it->bidi_it for iteration
3412 over a display string, and call bidi_init_it.
3413 (handle_single_display_spec, next_overlay_string)
3414 (get_overlay_strings_1, push_display_prop): Set up the bidi
3415 iterator for displaying display or overlay strings.
3416 (forward_to_next_line_start): Don't use the shortcut if
3418 (back_to_previous_visible_line_start): If handle_display_prop
3419 pushed the iterator stack, restore the internal state of the bidi
3420 iterator by calling bidi_pop_it same number of times.
3421 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3422 and we are bidi-iterating, don't decrement the iterator position;
3423 instead, set the first_elt flag in the bidi iterator, to produce
3425 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3426 (push_display_prop): xassert that we are iterating a buffer.
3427 (push_it, pop_it): Save and restore paragraph_embedding member.
3428 (handle_single_display_spec, next_overlay_string)
3429 (get_overlay_strings_1, reseat_1, reseat_to_string)
3430 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3431 correctly. Don't assume unibyte strings are not bidi-reordered.
3432 (compute_display_string_pos)
3433 (compute_display_string_end): Fix handling the case of C string.
3434 (push_it, pop_it): Save and restore from_disp_prop_p.
3435 (handle_single_display_spec, push_display_prop): Set the
3436 from_disp_prop_p flag.
3437 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3438 (pop_it): Call iterate_out_of_display_property only if we are
3439 popping after iteration over a string that came from a display
3440 property. Fix a typo in popping stretch info. Add an assertion
3441 for verifying that the iterator position is in sync with the bidi
3443 (handle_single_display_spec, get_overlay_strings_1)
3444 (push_display_prop): Fix initialization of paragraph direction for
3445 string when that of the parent object is not yet determined.
3446 (reseat_1): Call bidi_init_it to resync the bidi
3447 iterator with IT's position. (Bug#7616)
3448 (find_row_edges): If ROW->start.pos gives position
3449 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3450 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3451 Reset the from_disp_prop_p flag.
3452 (SAVE_IT, RESTORE_IT): New macros.
3453 (pos_visible_p, face_before_or_after_it_pos)
3454 (back_to_previous_visible_line_start)
3455 (move_it_in_display_line_to, move_it_in_display_line)
3456 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3457 (try_scrolling, redisplay_window, display_line): Use them when
3458 saving a temporary copy of the iterator and restoring it back.
3459 (back_to_previous_visible_line_start, reseat_1)
3460 (init_iterator): Empty the bidi cache "stack".
3461 (move_it_in_display_line_to): If iterator ended up at
3462 EOL, but we never saw any buffer positions smaller than
3463 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3464 motion in bidi-reordered lines.
3465 (move_it_in_display_line_to): Record prev_method and prev_pos
3466 immediately before the call to set_iterator_to_next. Fixes cursor
3467 motion in bidi-reordered lines with stretch glyphs and strings
3468 displayed in margins. (Bug#8133) (Bug#8867)
3469 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3471 (pos_visible_p): Support positions in bidi-reordered lines.
3472 Save and restore bidi cache.
3474 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3475 (bidi_paragraph_info): Delete unused struct.
3476 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3477 (bidi_cache_start): New variable.
3478 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3480 (bidi_cache_fetch_state, bidi_cache_search)
3481 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3482 (bidi_cache_find, bidi_peek_at_next_level)
3483 (bidi_level_of_next_char, bidi_find_other_level_edge)
3484 (bidi_move_to_visually_next): Compare cache index with
3485 bidi_cache_start rather than with zero.
3486 (bidi_fetch_char): Accept new argument STRING; all callers
3487 changed. Support iteration over a string. Support strings with
3488 display properties. Support unibyte strings. Fix the type of
3489 `len' according to what STRING_CHAR_AND_LENGTH expects.
3490 (bidi_paragraph_init, bidi_resolve_explicit_1)
3491 (bidi_resolve_explicit, bidi_resolve_weak)
3492 (bidi_level_of_next_char, bidi_move_to_visually_next):
3493 Support iteration over a string.
3494 (bidi_set_sor_type, bidi_resolve_explicit_1)
3495 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3496 can now be zero (for strings); special values 0 and -1 were
3497 changed to -1 and -2, respectively.
3498 (bidi_char_at_pos): New function.
3499 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3500 Call it instead of FETCH_MULTIBYTE_CHAR.
3501 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3502 initialized to valid values.
3503 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3505 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3506 the test for valid cached positions. Fix the logic for looking up
3507 the sentinel state in the cache. GCPRO the Lisp string we are
3509 (bidi_push_it, bidi_pop_it): New functions.
3510 (bidi_initialize): Initialize the bidi cache start stack pointer.
3511 (bidi_cache_ensure_space): New function, refactored from part of
3512 bidi_cache_iterator_state. Don't assume the required size is just
3513 one BIDI_CACHE_CHUNK away.
3514 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3515 (bidi_count_bytes, bidi_char_at_pos): New functions.
3516 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3517 always valid if bidi_cache_idx is valid.
3518 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3519 is valid if it's going to be used.
3520 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3521 (bidi_cache_fetch_state, bidi_cache_search)
3522 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3523 (bidi_cache_iterator_state, bidi_cache_find)
3524 (bidi_find_other_level_edge, bidi_cache_start_stack):
3525 All variables related to cache indices are now EMACS_INT.
3527 * dispextern.h (struct bidi_string_data): New structure.
3528 (struct bidi_it): New member `string'. Make flag members be 1-bit
3529 fields, and put them last in the struct.
3530 (compute_display_string_pos, compute_display_string_end):
3532 (bidi_push_it, bidi_pop_it): Add prototypes.
3533 (struct iterator_stack_entry): New members bidi_p,
3534 paragraph_embedding, and from_disp_prop_p.
3535 (struct it): Member bidi_p is now a bit field 1 bit wide.
3536 (bidi_shelve_cache, bidi_unshelve_cache):
3539 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3540 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3541 and vector-like objects.
3543 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3544 cache around display iteration.
3546 * window.c (Fwindow_end, window_scroll_pixel_based)
3547 (displayed_window_lines, Frecenter): Save and restore the bidi
3548 cache around display iteration.
3550 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3552 * editfns.c (Fdelete_region): Clarify the use of the named
3553 parameters (bug#6788).
3555 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3557 * indent.c (Fvertical_motion): Set and restore w->pointm when
3558 saving and restoring the window's buffer (Bug#9006).
3560 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3562 * editfns.c (Fstring_to_char): Clarify just what is returned
3563 (bug#6576). Text by Eli Zaretskii.
3565 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3567 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3569 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3571 * buffer.c (mmap_find): Fix a typo.
3573 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3575 Fix execution of x selection hooks.
3576 * xselect.c (Qx_lost_selection_functions)
3577 (Qx_sent_selection_functions): New vars.
3578 (syms_of_xselect): DEFSYM them.
3579 (x_handle_selection_request): Pass Qx_sent_selection_functions
3580 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3581 (x_handle_selection_clear,x_clear_frame_selections):
3582 Pass Qx_lost_selection_functions rather than
3583 Vx_lost_selection_functions to Frun_hook_with_args.
3585 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3587 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3588 The old code sometimes used this field without initializing it.
3590 * alloc.c (gc_sweep): Don't read past end of array.
3591 In theory, the old code could also have corrupted Emacs internals,
3592 though it'd be very unlikely.
3594 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3596 * character.c (Fcharacterp): Don't advertise optional ignored
3597 argument. (Bug#4026)
3599 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3601 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3604 * window.c (Fset_window_start): Doc fix (bug#4199).
3605 (Fset_window_hscroll): Ditto.
3607 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3609 Fix minor new problems caught by GCC 4.6.1.
3610 * term.c (init_tty): Remove unused local.
3611 * xsettings.c (store_monospaced_changed): Define this function only
3612 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3615 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3617 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3619 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3621 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3622 are the mini-buffer and the echo area (bug#3320).
3624 * term.c (init_tty): Remove support for supdup, c10 and perq
3625 terminals, which are no longer supported (bug#1482).
3627 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3629 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3631 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3633 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3634 for non-popups (Bug#3642).
3636 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3638 * alloc.c (reset_malloc_hooks): Protoize.
3639 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3640 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3641 * cm.c (losecursor): Likewise.
3642 * data.c (fmod): Likewise.
3643 * dispnew.c (swap_glyphs_in_rows): Likewise.
3644 * emacs.c (memory_warning_signal): Likewise.
3645 * floatfns.c (float_error): Likewise.
3646 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3647 (otf_open, font_otf_capability, generate_otf_features)
3648 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3650 * image.c (pbm_read_file): Likewise.
3651 * indent.c (string_display_width): Likewise.
3652 * intervals.c (check_for_interval, search_for_interval)
3653 (inc_interval_count, count_intervals, root_interval)
3654 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3655 * lread.c (defalias): Likewise.
3656 * ralloc.c (r_alloc_check): Likewise.
3657 * regex.c (set_image_of_range_1, set_image_of_range)
3658 (regex_grow_registers): Likewise.
3659 * sysdep.c (strerror): Likewise.
3660 * termcap.c (valid_filename_p, tprint, main): Likewise.
3661 * tparam.c (main): Likewise.
3662 * unexhp9k800.c (run_time_remap, save_data_space)
3663 (update_file_ptrs, read_header, write_header, calculate_checksum)
3664 (copy_file, copy_rest, display_header): Likewise.
3665 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3667 * xdisp.c (check_it): Likewise.
3668 * xfaces.c (register_color, unregister_color, unregister_colors):
3670 * xfns.c (print_fontset_result): Likewise.
3671 * xrdb.c (member, fatal, main): Likewise.
3673 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3675 Fix minor problems found by static checking (Bug#9031).
3676 * chartab.c (char_table_set_range, map_sub_char_table):
3677 Remove unused locals.
3678 (uniprop_table): Now static.
3679 * composite.c (_work_char): Remove unused static var.
3681 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3683 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3685 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3687 * gtkutil.c (qttip_cb): Remove code without function.
3689 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3691 * w32.c (pthread_sigmask): New stub.
3693 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3695 Use pthread_sigmask, not sigprocmask (Bug#9010).
3696 sigprocmask is portable only for single-threaded applications, and
3697 Emacs can be multi-threaded when it uses GTK.
3698 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3700 * callproc.c (Fcall_process):
3701 * process.c (create_process):
3702 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3703 Use pthread_sigmask, not sigprocmask.
3705 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3707 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3708 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3711 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3713 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3714 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3715 (xg_hide_tooltip): Fix comment.
3717 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3718 in registerServicesMenuSendTypes.
3719 (validRequestorForSendType): Don't check ns_return_types.
3721 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3724 2011-07-08 Jason Rumney <jasonr@gnu.org>
3726 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3727 SH_SHOW for hidden windows (Bug#5482).
3729 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3730 frame struct members of non-existent frames (Bug#6284).
3732 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3734 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3735 variable firstTime not needed on OSX >= 10.6.
3736 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3737 >= 10.5. Use setKnobProportion, setDoubleValue.
3739 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3740 (MAC_OS_X_VERSION_10_5): Define if not defined.
3741 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3742 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3743 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3745 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3746 cString and lossyCString on OSX >= 10.4
3748 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3749 sizeToFit on OSX >= 10.2.
3751 * nsimage.m (allocInitFromFile): Don't use deprecated method
3752 bestRepresentationForDevice on OSX >= 10.6.
3754 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3757 * emacs.c: Declare unexec_init_emacs_zone.
3759 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3761 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3763 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3764 on svcsMenu (Bug#8842).
3766 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3768 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3770 * nsterm.m (QUTF8_STRING): Declare.
3771 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3772 (validRequestorForSendType): Return type is (id).
3773 Change indexOfObjectIdenticalTo to indexOfObject.
3774 Check if we have local selection before returning self (Bug#8842).
3775 (writeSelectionToPasteboard): Put local selection into paste board
3776 if we have a local selection (Bug#8842).
3777 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3779 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3780 (ns_get_local_selection): Declare.
3782 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3784 * keymap.c (describe_map_tree): Don't insert a double newline at
3785 the end of the buffer (bug#1169) and return whether we inserted
3788 * callint.c (Fcall_interactively): Change "reading args" to
3789 "providing args" to try to clarify what it does (bug#1010).
3791 2011-07-07 Kenichi Handa <handa@m17n.org>
3793 * composite.c (composition_compute_stop_pos): Ignore a static
3794 composition starting before CHARPOS (Bug#8915).
3796 * xdisp.c (handle_composition_prop): Likewise.
3798 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3800 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3803 2011-07-07 Kenichi Handa <handa@m17n.org>
3805 * character.h (unicode_category_t): New enum type.
3807 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3808 (Qchar_code_property_table): New variable.
3809 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3810 (UNIPROP_COMPRESSED_FORM_P): New macros.
3811 (char_table_ascii): Uncompress the compressed values.
3812 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3813 Uncompress the compressed values.
3814 (sub_char_table_ref_and_range): Likewise.
3815 (char_table_ref_and_range): Uncompress the compressed values.
3816 (sub_char_table_set): New arg is_uniprop. Callers changed.
3817 Uncompress the compressed values.
3818 (sub_char_table_set_range): Args changed. Callers changed.
3819 (char_table_set_range): Adjuted for the above change.
3820 (map_sub_char_table): Delete args default_val and parent. Add arg
3821 top. Give decoded values to a Lisp function.
3822 (map_char_table): Adjust for the above change. Give decoded
3823 values to a Lisp function. Gcpro more variables.
3824 (uniprop_table_uncompress)
3825 (uniprop_decode_value_run_length): New functions.
3826 (uniprop_decoder, uniprop_decoder_count): New variables.
3827 (uniprop_get_decoder, uniprop_encode_value_character)
3828 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3830 (uniprop_encoder, uniprop_encoder_count): New variables.
3831 (uniprop_get_encoder, uniprop_table)
3832 (Funicode_property_table_internal, Fget_unicode_property_internal)
3833 (Fput_unicode_property_internal): New functions.
3834 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3835 Sunicode_property_table_internal, Sget_unicode_property_internal,
3836 and Sput_unicode_property_internal. Defvar_lisp
3837 char-code-property-alist.
3839 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3840 Vunicode_category_table.
3842 * font.c (font_range): Adjust for the change of
3843 Vunicode_category_table.
3845 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3847 * m/iris4d.h: Remove file, move contents ...
3848 * s/irix6-5.h: ... here.
3850 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3852 Remove unportable assumption about struct layout (Bug#8884).
3853 * alloc.c (mark_buffer):
3854 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3855 (clone_per_buffer_values): Don't assume that
3856 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3857 This isn't true in general, and it's particularly not true
3858 if Emacs is configured with --with-wide-int.
3859 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3860 New macros, used in the buffer.c change.
3862 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3864 * xsettings.c: Use both GConf and GSettings if both are available.
3865 (store_config_changed_event): Add comment.
3866 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3867 (store_tool_bar_style_changed): New functions.
3868 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3869 (struct xsettings): Move font inside HAVE_XFT.
3870 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3871 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3872 Move inside HAVE_XFT.
3873 (something_changed_gsettingsCB): Rename from something_changedCB.
3874 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3876 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3877 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3878 (something_changed_gconfCB): Rename from something_changedCB.
3879 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3880 (parse_settings): Move check for font inside HAVE_XFT.
3881 (read_settings, apply_xft_settings): Add comment.
3882 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3883 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3884 call store_font_name_changed.
3885 (xft_settings_event): Add comment.
3886 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3887 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3888 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3889 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3890 (xsettings_initialize): Call init_gsettings last.
3891 (xsettings_get_system_font, xsettings_get_system_normal_font):
3894 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3896 Random fixes. E.g., (random) never returned negative values.
3897 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3898 subseconds part to the entropy, as that's a bit more random.
3899 Prefer signed to unsigned, since the signedness doesn't matter and
3900 in general we prefer signed. When given a limit, use a
3901 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3902 latter isn't right if USE_2_TAGS_FOR_INTS.
3903 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3904 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3906 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3908 * textprop.c (text_property_stickiness):
3909 Obey Vtext_property_default_nonsticky.
3910 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3911 * w32fns.c (syms_of_w32fns):
3912 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3914 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3916 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3917 This is more efficient than Ffile_directory_p and avoids a minor race.
3919 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3921 * buffer.c (Foverlay_put): Say what the return value is
3924 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3925 is a directory before asking whether to use the file name
3927 (barf_or_query_if_file_exists): Make the "File is a directory"
3928 error be more correct.
3930 * fns.c (Frequire): Remove the mention of the .gz files, since
3931 that's installation-specific, but keep the mention of
3932 `get-load-suffixes'.
3934 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3936 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3937 Report string overflow if the output is too long.
3939 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3941 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3942 (syms_of_gnutls): Remove duplicate DEFSYM for
3943 Qgnutls_bootprop_verify_hostname_error, an error for
3944 Qgnutls_bootprop_verify_error (which is no longer used).
3946 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3947 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3948 Also (re)move comments that are misplaced or no longer relevant.
3950 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3954 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3956 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3957 and background color parameters if they have been changed.
3959 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3963 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3965 * xsettings.c (SYSTEM_FONT): Define only when used.
3966 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3968 * keymap.c (access_keymap_1): Now static.
3970 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3972 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3973 leave any prefix arg for the up event (Bug#1586).
3975 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3977 * lread.c (syms_of_lread): Mention single symbols defined by
3978 `defvar' or `defconst' (bug#7154).
3980 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3981 (Frequire): Mention get-load-suffixes.
3983 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3985 * window.h (window): Remove clone_number slot.
3986 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3988 (make_parent_window, make_window, saved_window)
3989 (Fset_window_configuration, save_window_save): Don't deal with
3991 * buffer.c (Qclone_number): Remove declaration.
3992 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3994 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3996 Add multiple inheritance to keymaps.
3997 * keymap.c (Fmake_composed_keymap): New function.
3998 (Fset_keymap_parent): Simplify.
3999 (fix_submap_inheritance): Remove.
4000 (access_keymap_1): New function extracted from access_keymap to handle
4001 embedded parents and handle lists of maps.
4002 (access_keymap): Use it.
4003 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4004 (Fcopy_keymap): Handle embedded parents.
4005 (Fcommand_remapping, define_as_prefix): Simplify.
4006 (Fkey_binding): Simplify.
4007 (syms_of_keymap): Move minibuffer-local-completion-map,
4008 minibuffer-local-filename-completion-map,
4009 minibuffer-local-must-match-map, and
4010 minibuffer-local-filename-must-match-map to Elisp.
4011 (syms_of_keymap): Defsubr make-composed-keymap.
4012 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4013 (parse_menu_item): Trivial simplification.
4015 2011-07-01 Glenn Morris <rgm@gnu.org>
4017 * Makefile.in (SETTINGS_LIBS): Fix typo.
4019 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4021 * coding.c (Fencode_coding_string): Record the last coding system
4022 used, as the function doc string says (bug#8738).
4024 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4026 * xsettings.c (store_monospaced_changed): Take new font as arg and
4027 check for change against current_mono_font.
4028 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4029 (emacs_settings_constructor, emacs_settings_get_property)
4030 (emacs_settings_set_property, emacs_settings_class_init)
4031 (emacs_settings_init, gsettings_obj): Remove.
4032 (something_changedCB): New function for HAVE_GSETTINGS.
4033 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4034 with value as argument.
4035 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4036 g_settings_new (Bug#8967). Do not create gsettings_obj.
4037 Remove calls to g_settings_bind. Connect something_changedCB to
4040 * xgselect.c: Add defined (HAVE_GSETTINGS).
4041 (xgselect_initialize): Ditto.
4043 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4044 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4047 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4049 * eval.c (struct backtrace): Simplify and port the data structure.
4050 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4051 signed bit field, as this assumption is not portable and it makes
4052 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4053 "char debug_on_exit : 1" as this is not portable either; instead,
4054 use the portable "unsigned int debug_on_exit : 1". Remove unused
4055 member evalargs. Remove obsolete comments about cc bombing out.
4057 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4059 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4060 Let HAVE_GSETTINGS override HAVE_GCONF.
4061 (store_monospaced_changed): New function.
4062 (EMACS_SETTINGS): A new type derived from GObject to handle
4063 GSettings notifications.
4064 (emacs_settings_constructor, emacs_settings_get_property)
4065 (emacs_settings_set_property, emacs_settings_class_init):
4067 (gsettings_client, gsettings_obj): New variables.
4068 (GSETTINGS_SCHEMA): New define.
4069 (something_changedCB): Call store_monospaced_changed.
4070 (init_gsettings): New function.
4071 (xsettings_initialize): Call init_gsettings.
4072 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4075 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4078 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4080 * window.c (resize_root_window, grow_mini_window)
4081 (shrink_mini_window): Rename Qresize_root_window to
4082 Qwindow_resize_root_window and Qresize_root_window_vertically to
4083 Qwindow_resize_root_window_vertically.
4085 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4087 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4089 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4091 * makefile.w32-in: Redesign dependencies so they reflect more
4092 clearly which files are directly included by each source file,
4093 and not through other includes.
4095 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4097 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4098 (sort_overlays, overlay_strings): When an overlay's clone number
4099 matches the window's clone number process the overlay even if
4100 the overlay's window property doesn't match the current window.
4102 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4103 (Fwindow_hchild): Rename to Fwindow_left_child.
4104 (Fwindow_next): Rename to Fwindow_next_sibling.
4105 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4106 (resize_window_check): Rename to window_resize_check.
4107 (resize_window_apply): Rename to window_resize_apply.
4108 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4109 (Fdelete_other_windows_internal, resize_frame_windows)
4110 (Fsplit_window_internal, Fdelete_window_internal)
4111 (grow_mini_window, shrink_mini_window)
4112 (Fresize_mini_window_internal): Fix callers accordingly.
4114 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4116 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4117 (emacs_fixed_set_min_size): Remove.
4118 (emacs_fixed_new): Take frame as argument.
4120 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4121 (_EmacsFixedPrivate): Remove minwidth/height.
4122 Add struct frame *f.
4123 (emacs_fixed_init): Initialize priv->f.
4124 (get_parent_class, emacs_fixed_set_min_size): Remove.
4125 (emacs_fixed_new): Set priv->f to argument.
4126 (emacs_fixed_get_preferred_width)
4127 (emacs_fixed_get_preferred_height): Use min_width/height from
4128 frames size_hint to set minimum and natural (Bug#8919).
4129 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4130 and use min_width/height from frames size_hint to set
4131 min_width/height (Bug#8919).
4133 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4134 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4137 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4139 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4140 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4143 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4145 * process.c (wait_reading_process_output): Bypass select if
4146 waiting for a cell while ignoring keyboard input, and input is
4147 pending. Suggested by Jan Djärv (Bug#8869).
4149 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4151 Use gnulib's dup2 module instead of rolling our own.
4152 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4154 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4156 * dispnew.c (scrolling_window): Before scrolling, turn off a
4157 mouse-highlight in the window being scrolled.
4159 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4161 Move DEFSYM to lisp.h and use everywhere.
4163 * character.h (DEFSYM): Move declaration...
4164 * lisp.h (DEFSYM): ...here.
4170 * w32select.c: Don't include character.h.
4172 * alloc.c (syms_of_alloc):
4173 * buffer.c (syms_of_buffer):
4174 * bytecode.c (syms_of_bytecode):
4175 * callint.c (syms_of_callint):
4176 * casefiddle.c (syms_of_casefiddle):
4177 * casetab.c (init_casetab_once):
4178 * category.c (init_category_once, syms_of_category):
4179 * ccl.c (syms_of_ccl):
4180 * cmds.c (syms_of_cmds):
4181 * composite.c (syms_of_composite):
4182 * dbusbind.c (syms_of_dbusbind):
4183 * dired.c (syms_of_dired):
4184 * dispnew.c (syms_of_display):
4185 * doc.c (syms_of_doc):
4186 * editfns.c (syms_of_editfns):
4187 * emacs.c (syms_of_emacs):
4188 * eval.c (syms_of_eval):
4189 * fileio.c (syms_of_fileio):
4190 * fns.c (syms_of_fns):
4191 * frame.c (syms_of_frame):
4192 * fringe.c (syms_of_fringe):
4193 * insdel.c (syms_of_insdel):
4194 * keymap.c (syms_of_keymap):
4195 * lread.c (init_obarray, syms_of_lread):
4196 * macros.c (syms_of_macros):
4197 * msdos.c (syms_of_msdos):
4198 * print.c (syms_of_print):
4199 * process.c (syms_of_process):
4200 * search.c (syms_of_search):
4201 * sound.c (syms_of_sound):
4202 * syntax.c (init_syntax_once, syms_of_syntax):
4203 * terminal.c (syms_of_terminal):
4204 * textprop.c (syms_of_textprop):
4205 * undo.c (syms_of_undo):
4206 * w32.c (globals_of_w32):
4207 * window.c (syms_of_window):
4208 * xdisp.c (syms_of_xdisp):
4209 * xfaces.c (syms_of_xfaces):
4210 * xfns.c (syms_of_xfns):
4211 * xmenu.c (syms_of_xmenu):
4212 * xsettings.c (syms_of_xsettings):
4213 * xterm.c (syms_of_xterm): Use DEFSYM.
4215 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4217 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4219 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4221 Integer and buffer overflow fixes (Bug#8873).
4223 * print.c (printchar, strout): Check for string overflow.
4224 (PRINTPREPARE, printchar, strout):
4225 Don't set size unless allocation succeeds.
4227 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4228 for sizes. Check for string overflow more accurately.
4229 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4231 * macros.c: Integer and buffer overflow fixes.
4232 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4233 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4234 Use ptrdiff_t, not int, for sizes.
4235 Don't increment bufsize until after realloc succeeds.
4236 Check for size-calculation overflow.
4237 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4239 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4241 * lread.c: Integer overflow fixes.
4242 (read_integer): Radix is now EMACS_INT, not int,
4243 to improve quality of diagnostics for out-of-range radices.
4244 Calculate buffer size correctly for out-of-range radices.
4245 (read1): Check for integer overflow in radices, and in
4246 read-circle numbers.
4247 (read_escape): Avoid int overflow.
4248 (Fload, openp, read_buffer_size, read1)
4249 (substitute_object_recurse, read_vector, read_list, map_obarray):
4250 Use ptrdiff_t, not int, for sizes.
4251 (read1): Use EMACS_INT, not int, for sizes.
4252 Check for size overflow.
4254 * image.c (cache_image): Check for size arithmetic overflow.
4256 * lread.c: Integer overflow issues.
4257 (saved_doc_string_size, saved_doc_string_length)
4258 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4259 Now ptrdiff_t, not int.
4260 (read1): Don't assume doc string length fits in int. Check for
4261 out-of-range doc string lengths.
4262 (read_list): Don't assume file position fits in int.
4263 (read_escape): Check for hex character overflow.
4265 2011-06-22 Leo Liu <sdl.web@gmail.com>
4267 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4268 Move to minibuffer.el.
4270 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4272 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4273 The following patches are for when GLYPH_DEBUG && !XASSERT.
4274 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4275 * dispnew.c (flush_stdout):
4276 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4277 Mark as externally visible.
4278 * dispnew.c (check_window_matrix_pointers): Now static.
4279 * dispnew.c (window_to_frame_vpos):
4280 * xfns.c (unwind_create_frame):
4281 * xterm.c (x_check_font): Remove unused local.
4282 * scroll.c (CHECK_BOUNDS):
4283 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4284 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4285 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4286 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4287 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4289 (debug_method_add): Use va_list and vsprintf rather than relying
4290 on undefined behavior with wrong number of arguments.
4291 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4292 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4293 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4294 since we're not interested in debugging glyphs with old libraries.
4295 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4296 GCC 4.6.0's static checking.
4298 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4300 Integer overflow and signedness fixes (Bug#8873).
4301 A few related buffer overrun fixes, too.
4303 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4305 * dispextern.h (struct face.stipple):
4306 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4307 (x_bitmap_mask, x_allocate_bitmap_record)
4308 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4309 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4310 (x_create_bitmap_from_xpm_data):
4311 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4312 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4314 * xfaces.c (load_pixmap):
4315 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4316 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4317 (.bitmaps_last, struct x_output.icon_bitmap):
4318 Use ptrdiff_t, not int, for bitmap indexes.
4319 (x_allocate_bitmap_record): Check for size overflow.
4320 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4322 Use ptrdiff_t, not int, for overlay counts.
4323 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4324 * editfns.c (overlays_around, get_pos_property):
4325 * textprop.c (get_char_property_and_overlay):
4326 * xdisp.c (next_overlay_change, note_mouse_highlight):
4327 * xfaces.c (face_at_buffer_position):
4328 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4329 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4330 (Fnext_overlay_change, Fprevious_overlay_change)
4331 (mouse_face_overlay_overlaps, Foverlays_in):
4332 Use ptrdiff_t, not int, for sizes.
4333 (overlays_at, overlays_in): Check for size-calculation overflow.
4335 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4337 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4338 (x_session_initialize): Do not assume string length fits in int.
4340 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4341 This is unlikely, but can occur if DPI is outlandish.
4343 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4344 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4346 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4347 * xrdb.c (magic_file_p, search_magic_path):
4348 Omit last arg SUFFIX; it was always 0. All callers changed.
4349 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4351 * xfont.c (xfont_match): Avoid need for strlen.
4353 * xfns.c: Don't assume strlen fits in int.
4354 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4356 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4357 not unsigned long, as we prefer signed integers. All callers changed.
4358 Detect integer overflow in repeat count.
4359 (message_dolog): Don't assume print length fits in 39 bytes.
4360 (display_mode_element): Don't assume strlen fits in int.
4362 * termcap.c: Don't assume sizes fit in int and never overflow.
4363 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4364 (gobble_line): Check for size-calculation overflow.
4366 * minibuf.c (Fread_buffer):
4367 * lread.c (intern, intern_c_string):
4368 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4369 Don't assume string length fits in int.
4371 * keyboard.c (parse_tool_bar_item):
4372 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4374 * font.c: Don't assume string length fits in int.
4375 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4376 Use ptrdiff_t, not int.
4377 (font_intern_prop): Don't assume string length fits in int.
4378 Don't assume integer property fits in fixnum.
4379 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4381 * filelock.c: Fix some buffer overrun and integer overflow issues.
4382 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4383 Reformulate so as not to need the command string.
4384 Invoke gzip -cd rather than gunzip, as it's more portable.
4385 (lock_info_type, lock_file_1, lock_file):
4386 Don't assume pid_t and time_t fit in unsigned long.
4387 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4388 (current_lock_owner): Prefer signed type for sizes.
4389 Use memcpy, not strncpy, where memcpy is what is really wanted.
4390 Don't assume (via atoi) that time_t and pid_t fit in int.
4391 Check for time_t and/or pid_t out of range, e.g., via a network share.
4392 Don't alloca where an auto var works fine.
4394 * fileio.c: Fix some integer overflow issues.
4395 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4396 Don't assume string length fits in int.
4397 (directory_file_name): Don't assume string length fits in long.
4398 (make_temp_name): Don't assume pid fits in int, or that its print
4399 length is less than 20.
4401 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4403 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4405 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4407 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4408 We prefer signed integers, even for size calculations.
4410 * emacs.c: Don't assume string length fits in 'int'.
4411 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4412 (main): Don't invoke strlen when not needed.
4414 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4415 (XD_DEBUG_MESSAGE): Don't waste a byte.
4417 * callproc.c (getenv_internal_1, getenv_internal)
4419 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4421 * lread.c (invalid_syntax): Omit length argument.
4422 All uses changed. This doesn't fix a bug, but it simplifies the
4423 code away from its former Hollerith-constant appearance, and it's
4424 one less 'int' to worry about when looking at integer-overflow issues.
4425 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4427 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4428 This didn't break anything, but it didn't help either.
4429 It's confusing to put a bogus integer in a place where the actual
4430 value does not matter.
4431 (LIST_END_P): Remove unused macro and its bogus comment.
4432 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4434 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4435 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4437 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4438 We prefer signed types, and the value cannot exceed the EMACS_INT
4439 range anyway (because otherwise the length would not be representable).
4440 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4441 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4442 This avoids a GCC warning when WIDE_EMACS_INT.
4444 * indent.c (sane_tab_width): New function.
4445 (current_column, scan_for_column, Findent_to, position_indentation)
4446 (compute_motion): Use it. This is just for clarity.
4447 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4449 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4451 * lisp.h (lint_assume): New macro.
4452 * composite.c (composition_gstring_put_cache):
4453 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4455 * editfns.c, insdel.c:
4456 Omit unnecessary forward decls, to simplify future changes.
4458 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4460 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4462 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4463 Use much-faster test for byte-length change.
4464 Don't assume string byte-length fits in 'int'.
4465 Check that character arg fits in 'int'.
4466 (mapcar1): Declare byte as byte, for clarity.
4468 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4470 * fns.c (concat): Catch string overflow earlier.
4471 Do not rely on integer wraparound.
4473 * dispextern.h (struct it.overlay_strings_charpos)
4474 (struct it.selective): Now EMACS_INT, not int.
4475 * xdisp.c (forward_to_next_line_start)
4476 (back_to_previous_visible_line_start)
4477 (reseat_at_next_visible_line_start, next_element_from_buffer):
4478 Don't arbitrarily truncate the value of 'selective' to int.
4480 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4482 * composite.c: Don't truncate sizes to 'int'.
4483 (composition_gstring_p, composition_reseat_it)
4484 (composition_adjust_point): Use EMACS_INT, not int.
4485 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4486 not EMACS_UINT, for indexes.
4488 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4490 * buffer.c: Include <verify.h>.
4491 (struct sortvec.priority, struct sortstr.priority):
4492 Now EMACS_INT, not int.
4493 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4494 (struct sortstr.size, record_overlay_string)
4495 (struct sortstrlist.size, struct sortlist.used):
4496 Don't truncate size to int.
4497 (record_overlay_string): Check for size-calculation overflow.
4498 (init_buffer_once): Check at compile-time, not run-time.
4500 2011-06-22 Jim Meyering <meyering@redhat.com>
4502 Don't leak an XBM-image-sized buffer
4503 * image.c (xbm_load): Free the image buffer after using it.
4505 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4508 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4509 that Sun C diagnosed.
4510 * fns.c (secure_hash): Fix pointer signedness issue.
4511 * intervals.c (static_offset_intervals): New function.
4512 (offset_intervals): Use it.
4514 2011-06-21 Leo Liu <sdl.web@gmail.com>
4517 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4520 * fns.c (secure_hash): Rename from crypto_hash_function and change
4521 the first arg to accept symbols.
4522 (Fsecure_hash): New primitive.
4523 (syms_of_fns): New symbols.
4525 2011-06-20 Deniz Dogan <deniz@dogan.se>
4527 * process.c (Fset_process_buffer): Clarify return value in
4530 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4532 * dispnew.c (add_window_display_history): Use BVAR.
4534 * xdisp.c (debug_method_add): Use BVAR.
4535 (check_window_end, dump_glyph_matrix, dump_glyph)
4536 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4538 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4541 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4542 check till after the cache is created in init_frame_faces.
4544 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4546 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4548 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4550 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4551 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4552 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4554 Improve buffer-overflow checking (Bug#8873).
4555 * fileio.c (Finsert_file_contents):
4556 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4557 Remove the old (too-loose) buffer overflow checks.
4558 They weren't needed, since make_gap checks for buffer overflow.
4559 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4560 The old code merely checked for Emacs fixnum overflow, and relied
4561 on undefined (wraparound) behavior. The new code avoids undefined
4562 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4564 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4565 Tune. Don't use wider integers than needed. Don't use alloca.
4566 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4568 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4570 * insdel.c, lisp.h (buffer_overflow): New function.
4571 (insert_from_buffer_1, replace_range, replace_range_2):
4572 * insdel.c (make_gap_larger):
4573 * editfns.c (Finsert_char):
4574 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4576 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4578 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4580 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4582 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4583 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4585 * fileio.c: Don't assume EMACS_INT fits in off_t.
4586 (emacs_lseek): New static function.
4587 (Finsert_file_contents, Fwrite_region): Use it.
4588 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4590 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4592 * fns.c: Don't overflow int when computing a list length.
4593 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4594 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4595 truncation on 64-bit hosts. Check for QUIT every
4596 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4597 faster and is responsive enough.
4598 (Flength): Report an error instead of overflowing an integer.
4599 (Fsafe_length): Return a float if the value is not representable
4600 as a fixnum. This shouldn't happen except in contrived situations.
4601 (Fnthcdr, Fsort): Don't assume list length fits in int.
4602 (Fcopy_sequence): Don't assume vector length fits in int.
4604 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4605 (header_size, word_size): New constants.
4606 (allocate_vectorlike): Don't check size overflow here.
4607 (allocate_vector): Check it here instead, since this is the only
4608 caller of allocate_vectorlike that could cause overflow.
4609 Check that the new vector's length is representable as a fixnum.
4611 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4612 The previous code was bogus. For example, next_almost_prime (32)
4613 returned 39, which is undesirable as it is a multiple of 3; and
4614 next_almost_prime (24) returned 25, which is a multiple of 5 so
4615 why was the code bothering to check for multiples of 7?
4617 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4619 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4621 Variadic C functions now count arguments with ptrdiff_t.
4622 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4623 Back then I didn't know that the Emacs coding style prefers signed int.
4624 Also, in the meantime I found a few more instances where arguments
4625 were being counted with int, which may truncate counts on 64-bit
4626 machines, or EMACS_INT, which may be unnecessarily wide.
4627 * lisp.h (struct Lisp_Subr.function.aMANY)
4628 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4629 Arg counts are now ptrdiff_t, not size_t.
4630 All variadic functions and their callers changed accordingly.
4631 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4632 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4633 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4634 * callint.c (Fcall_interactively): Check arg count for overflow,
4635 to avoid potential buffer overrun. Use signed char, not 'int',
4636 for 'varies' array, so that we needn't bother to check its size
4637 calculation for overflow.
4638 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4639 * eval.c (apply_lambda):
4640 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4641 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4642 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4644 * callint.c (Fcall_interactively): Don't use index var as event count.
4646 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4647 * mem-limits.h (SIZE): Remove; no longer used.
4649 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4651 Remove unnecessary casts.
4652 * xterm.c (x_term_init):
4653 * xfns.c (x_set_border_pixel):
4654 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4655 These aren't needed now that we assume ANSI C.
4657 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4658 It's more likely to cause problems (due to unsigned overflow)
4661 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4663 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4665 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4667 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4669 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4671 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4673 GLYPH_CODE_FACE returns EMACS_INT, not int.
4674 * dispextern.h (merge_faces):
4675 * xfaces.c (merge_faces):
4676 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4677 Don't assume EMACS_INT fits in int.
4679 * character.h (CHAR_VALID_P): Remove unused parameter.
4680 * fontset.c, lisp.h, xdisp.c: All uses changed.
4682 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4684 * fns.c (concat): Minor tuning based on overflow analysis.
4685 This doesn't fix any bugs. Use int to hold character, instead
4686 of constantly refetching from Emacs object. Use XFASTINT, not
4687 XINT, for value known to be a character. Don't bother comparing
4688 a single byte to 0400, as it's always less.
4690 * floatfns.c (Fexpt):
4691 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4693 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4696 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4698 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4699 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4700 incorrectly succeed when S was a string, because 4294967386 was
4701 truncated before it was used.
4703 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4704 Otherwise, an out-of-range integer could cause undefined behavior
4707 * composite.c: Use int, not EMACS_INT, for characters.
4708 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4709 EMACS_INT, for values that are known to be in character range.
4710 This doesn't fix any bugs but is the usual style inside Emacs and
4711 may generate better code on 32-bit machines.
4713 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4714 This is for reasons similar to the recent CHAR_STRING fix.
4715 * charset.c (Fencode_char): Check that character arg is actually
4716 a character. Pass an int to ENCODE_CHAR.
4717 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4718 wider than 'int', as a compile-time check to prevent future regressions
4721 * character.c (char_string): Remove unnecessary casts.
4723 Make sure a 64-bit char is never passed to CHAR_STRING.
4724 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4725 by silently ignoring the top 32 bits, allowing some values
4726 that were far too large to be valid characters.
4727 * character.h: Include <verify.h>.
4728 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4729 arguments are no wider than unsigned, as a compile-time check
4730 to prevent future regressions in this area.
4732 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4733 (Fsubst_char_in_region):
4735 * xdisp.c (decode_mode_spec_coding):
4736 Adjust to CHAR_STRING's new requirement.
4737 * editfns.c (Finsert_char, Fsubst_char_in_region):
4738 * fns.c (concat): Check that character args are actually
4739 characters. Without this test, these functions did the wrong
4740 thing with wildly out-of-range values on 64-bit hosts.
4742 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4743 These casts should not be needed on 32-bit hosts, either.
4744 * keyboard.c (read_char):
4745 * lread.c (Fload): Remove casts to unsigned.
4747 * lisp.h (UNSIGNED_CMP): New macro.
4748 This fixes comparison bugs on 64-bit hosts.
4749 (ASCII_CHAR_P): Use it.
4750 * casefiddle.c (casify_object):
4751 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4752 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4753 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4754 * dispextern.h (FACE_FROM_ID):
4755 * keyboard.c (read_char): Use UNSIGNED_CMP.
4757 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4758 not to EMACS_INT, to avoid GCC warning.
4760 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4762 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4763 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4764 isn't needed on 32-bit machines.
4766 * buffer.c (Fgenerate_new_buffer_name):
4767 Use EMACS_INT for count, not int.
4768 (advance_to_char_boundary): Return EMACS_INT, not int.
4770 * data.c (Qcompiled_function): Now static.
4772 * window.c (window_body_lines): Now static.
4774 * image.c (gif_load): Rename local to avoid shadowing.
4776 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4777 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4778 * alloc.c (make_save_value): Integer argument is now of type
4780 (mark_object): Use ptrdiff_t, not int.
4781 * lisp.h (pD): New macro.
4782 * print.c (print_object): Use it.
4784 * alloc.c: Use EMACS_INT, not int, to count objects.
4785 (total_conses, total_markers, total_symbols, total_vector_size)
4786 (total_free_conses, total_free_markers, total_free_symbols)
4787 (total_free_floats, total_floats, total_free_intervals)
4788 (total_intervals, total_strings, total_free_strings):
4789 Now EMACS_INT, not int. All uses changed.
4790 (Fgarbage_collect): Compute overall total using a double, so that
4791 integer overflow is less likely to be a problem. Check for overflow
4792 when converting back to an integer.
4793 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4794 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4795 These were 'int' variables that could overflow on 64-bit hosts;
4796 they were never used, so remove them instead of repairing them.
4797 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4798 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4799 Previously, this ceilinged at INT_MAX, but that doesn't work on
4801 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4803 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4804 (allocate_vectorlike): Check for ptrdiff_t overflow.
4805 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4806 when a (possibly-narrower) signed value would do just as well.
4807 We prefer using signed arithmetic, to avoid comparison confusion.
4809 * alloc.c: Catch some string size overflows that we were missing.
4810 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4811 for convenience in STRING_BYTES_MAX.
4812 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4813 The definition here is exact; the one in lisp.h was approximate.
4814 (allocate_string_data): Check for string overflow. This catches
4815 some instances we weren't catching before. Also, it catches
4816 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4817 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4818 and ptrdiff_t and EMACS_INT are both 64 bits.
4820 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4821 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4822 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4824 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4826 * alloc.c (Fmake_string): Check for out-of-range init.
4828 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4830 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4832 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4834 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4835 xg_get_default_scrollbar_width.
4837 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4838 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4839 (style_changed_cb): Call update_theme_scrollbar_width and call
4840 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4841 all frames (Bug#8505).
4842 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4843 Call gtk_window_set_resizable if HAVE_GTK3.
4844 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4845 and height if HAVE_GTK3 (Bug#8505).
4846 (scroll_bar_width_for_theme): New variable.
4847 (update_theme_scrollbar_width): New function.
4848 (xg_get_default_scrollbar_width): Move code to
4849 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4850 (xg_initialize): Call update_theme_scrollbar_width.
4852 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4854 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4856 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4858 * frame.c (make_frame): Call other_buffer_safely instead of
4861 * window.c (temp_output_buffer_show): Call display_buffer with
4862 second argument Vtemp_buffer_show_specifiers and reset latter
4863 immediately after the call.
4864 (Vtemp_buffer_show_specifiers): New variable.
4865 (auto_window_vscroll_p, next_screen_context_lines)
4866 (Vscroll_preserve_screen_position): Remove leading asterisks from
4869 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4871 Fix minor problems found by GCC 4.6.0 static checking.
4872 * buffer.c (Qclone_number): Remove for now, as it's unused.
4873 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4874 (record_buffer): Remove unused local.
4875 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4876 (set_frame_buffer_list): Remove; unused.
4877 * frame.h (other_visible_frames): Remove decl.
4878 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4879 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4880 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4882 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4883 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4884 Define only if HAVE_GPM.
4885 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4886 (update_hints_inhibit): Remove; never set. All uses removed.
4887 * widgetprv.h (emacsFrameClassRec): Remove decl.
4888 * window.c (delete_deletable_window): Now returns void, since it
4889 wasn't returning anything.
4890 (compare_window_configurations): Remove unused locals.
4891 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4892 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4893 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4894 the same widths as pointers. This follows up on the 2011-05-06 patch.
4895 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4896 * xterm.h: Likewise.
4897 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4899 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4901 * makefile.w32-in: Update dependencies.
4902 (LISP_H): Add lib/intprops.h.
4904 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4906 * image.c (gif_load): Add animation frame delay to the metadata.
4907 (syms_of_image): Use DEFSYM. New symbol `delay'.
4909 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4911 * window.c (delete_deletable_window): Re-add.
4912 (Fset_window_configuration): Rewrite to handle dead buffers and
4913 consequently deletable windows.
4914 (window_tree, Fwindow_tree): Remove. Supply functionality in
4916 (compare_window_configurations): Simplify code.
4918 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4920 * image.c (imagemagick_load_image): Fix type mismatch.
4921 (Fimagemagick_types): Likewise.
4923 * window.h (replace_buffer_in_windows): Declare.
4925 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4927 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4928 Qclone_number. Remove external declaration of Qdelete_window.
4929 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4931 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4932 Run Qbuffer_list_update_hook if allowed.
4933 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4934 buffer list implementation.
4935 (other_buffer_safely): New function.
4936 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4937 calls to replace_buffer_in_windows and
4938 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4940 (record_buffer): Inhibit quitting and rewrite using quittable
4941 functions. Run Qbuffer_list_update_hook if allowed.
4942 (Frecord_buffer, Funrecord_buffer): New functions.
4943 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4944 Move switch-to-buffer to window.el.
4945 (bury-buffer): Move to window.el.
4946 (Vbuffer_list_update_hook): New variable.
4948 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4951 * window.h (resize_frame_windows): Move up in code.
4952 (Fwindow_frame): Remove EXFUN.
4953 (replace_buffer_in_all_windows): Remove prototype.
4954 (replace_buffer_in_windows_safely): Add prototype.
4956 * window.c: Declare Qdelete_window static again. Move down
4957 declaration of select_count.
4958 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4959 (Fother_window): Move to window.el.
4960 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4961 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4962 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4964 (replace_buffer_in_windows): Implement by calling
4965 Qreplace_buffer_in_windows.
4966 (replace_buffer_in_all_windows): Remove with some functionality
4967 moved into replace_buffer_in_windows_safely.
4968 (replace_buffer_in_windows_safely): New function.
4969 (select_window_norecord, select_frame_norecord): Move in front
4970 of run_window_configuration_change_hook. Remove now obsolete
4972 (Fset_window_buffer): Rewrite doc-string.
4973 Call Qrecord_window_buffer.
4974 (keys_of_window): Move binding for other-window to window.el.
4976 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4978 * dispextern.h (struct image): Replace data member, whose int_val
4979 and ptr_val fields were not used by anything, with a single
4982 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4983 (gif_clear_image, gif_load, imagemagick_load_image)
4984 (gs_clear_image, gs_load): Callers changed.
4986 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4988 * buffer.h: Include <time.h>, for time_t.
4989 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4991 Fix minor problems found by static checking.
4993 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4995 Make identifiers static if they are not used in other modules.
4996 * data.c (Qcompiled_function, Qframe, Qvector):
4997 * image.c (QimageMagick, Qsvg):
4998 * minibuf.c (Qmetadata):
4999 * window.c (resize_window_check, resize_root_window): Now static.
5000 * window.h (resize_window_check, resize_root_window): Remove decls.
5002 * window.c (window_deletion_count, delete_deletable_window):
5004 (window_body_lines): Now static.
5005 (Fdelete_other_windows_internal): Mark vars as initialized.
5006 Make sure 'resize_failed' is initialized.
5007 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5008 (resize_window_apply): Remove unused local.
5009 * window.h (delete_deletable_window): Remove decl.
5011 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5012 (imagemagick_load_image): Fix pointer signedness problem by changing
5013 last arg from unsigned char * to char *. All uses changed.
5014 Also, fix a local for similar reasons.
5015 Remove unused locals. Remove locals to avoid shadowing.
5016 (fn_rsvg_handle_free): Remove; unused.
5017 (svg_load, svg_load_image): Fix pointer signedness problem.
5018 (imagemagick_load_image): Don't use garbage pointer image_wand.
5020 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5022 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5024 * image.c (gif_load): Fix omitted cast error introduced by
5027 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5029 * window.h (resize_proportionally, orig_total_lines)
5030 (orig_top_line): Remove from window structure.
5031 (set_window_height, set_window_width, change_window_heights)
5032 (Fdelete_window): Remove prototypes.
5033 (resize_frame_windows): Remove duplicate declaration.
5035 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5037 * window.h (resize_frame_windows, resize_window_check)
5038 (delete_deletable_window, resize_root_window)
5039 (resize_frame_windows): Declare prototypes.
5041 * window.c (resize_window_apply): Make definition be "static" to
5042 match the prototype.
5044 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5046 * window.c: Remove declarations of Qwindow_size_fixed,
5047 window_min_size_1, window_min_size_2, window_min_size,
5048 size_window, window_fixed_size_p, enlarge_window, delete_window.
5049 Remove static from declaration of Qdelete_window, it's
5050 temporarily needed by Fbury_buffer.
5051 (replace_window): Don't assign orig_top_line and
5053 (Fdelete_window, delete_window): Remove. Window deletion is
5054 handled by window.el.
5055 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5056 Replace Fdelete_window calls with calls to Qdelete_window.
5057 (Fdelete_other_windows): Remove. Deleting other windows is
5058 handled by window.el.
5059 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5060 handled in window.el.
5061 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5062 Window minimum sizes are handled in window.el.
5063 (shrink_windows, size_window, set_window_height)
5064 (set_window_width, change_window_heights, window_height)
5065 (window_width, CURBEG, CURSIZE, enlarge_window)
5066 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5067 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5068 handled in window.el.
5069 (make_dummy_parent): Rename to make_parent_window and give it a
5070 second argument horflag.
5071 (make_window): Don't set resize_proportionally any more.
5072 (Fsplit_window): Remove. Windows are split in window.el.
5073 (save_restore_action, save_restore_orig_size)
5074 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5075 Resize mini windows in window.el.
5076 (grow_mini_window, shrink_mini_window): Implement by calling
5077 Qresize_root_window_vertically, resize_window_check and
5078 resize_window_apply.
5079 (saved_window, Fset_window_configuration, save_window_save):
5080 Do not handle orig_top_line, orig_total_lines, and
5081 resize_proportionally.
5082 (window_min_height, window_min_width): Move to window.el.
5083 (keys_of_window): Move bindings for delete-other-windows,
5084 split-window, delete-window and enlarge-window to window.el.
5086 * buffer.c: Temporarily extern Qdelete_window.
5087 (Fbury_buffer): Temporarily call Qdelete_window instead of
5088 Fdelete_window (Fbury_buffer will move to window.el soon).
5090 * frame.c (set_menu_bar_lines_1): Remove code handling
5091 orig_top_line and orig_total_lines.
5093 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5094 set_window_height but set heights directly.
5095 (change_frame_size_1): Use resize_frame_windows.
5097 * xdisp.c (init_xdisp): Don't use set_window_height but set
5100 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5101 Use resize_frame_windows instead of change_window_heights and run
5102 run_window_configuration_change_hook.
5104 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5105 instead of change_window_heights and run
5106 run_window_configuration_change_hook.
5108 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5110 * window.c (replace_window): Rename second argument REPLACEMENT to
5111 NEW. New third argument SETFLAG. Rewrite.
5112 (delete_window, make_dummy_parent): Call replace_window with
5114 (window_list_1): Move down in code.
5115 (run_window_configuration_change_hook): Move set_buffer part
5116 before select_frame_norecord part in order to unwind correctly.
5117 Rename count1 to count.
5118 (recombine_windows, delete_deletable_window, resize_root_window)
5119 (Fdelete_other_windows_internal)
5120 (Frun_window_configuration_change_hook, make_parent_window)
5121 (resize_window_check, resize_window_apply, Fresize_window_apply)
5122 (resize_frame_windows, Fsplit_window_internal)
5123 (Fdelete_window_internal, Fresize_mini_window_internal):
5125 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5127 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5129 * window.h (window): Add some new members to window structure -
5130 normal_lines, normal_cols, new_total, new_normal, clone_number,
5131 splits, nest, prev_buffers, next_buffers.
5132 (WINDOW_TOTAL_SIZE): Move here from window.c.
5133 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5135 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5137 (make_dummy_parent): Set new members of windows structure.
5138 (make_window): Move down in code. Handle new members of window
5140 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5141 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5142 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5143 (Fset_window_prev_buffers, Fwindow_next_buffers)
5144 (Fset_window_next_buffers, Fset_window_clone_number):
5146 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5147 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5149 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5150 Argument WINDOW can be now internal window too.
5151 (Fwindow_use_time): Move up in code.
5152 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5154 (Fset_window_configuration, saved_window)
5155 (Fcurrent_window_configuration, save_window_save): Handle new
5156 members of window structure.
5157 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5158 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5159 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5160 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5161 Qget_mru_window, Qresize_root_window,
5162 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5163 Qauto_buffer_name; staticpro them.
5165 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5167 * window.c (Fwindow_total_size, Fwindow_left_column)
5168 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5169 (Fwindow_list_1): New functions.
5170 (window_box_text_cols): Replace with window_body_cols.
5171 (Fwindow_width, Fscroll_left, Fscroll_right):
5172 Use window_body_cols instead of window_box_text_cols.
5173 (delete_window, Fset_window_configuration):
5174 Call delete_all_subwindows with window as argument.
5175 (delete_all_subwindows): Take a window as argument and not a
5177 (window_loop): Remove handling of GET_LRU_WINDOW and
5179 (Fget_lru_window, Fget_largest_window): Move to window.el.
5181 * window.h: Extern window_body_cols instead of
5182 window_box_text_cols. delete_all_subwindows now takes a
5183 Lisp_Object as argument.
5185 * indent.c (compute_motion, Fcompute_motion):
5186 Use window_body_cols instead of window_box_text_cols.
5188 * frame.c (delete_frame): Call delete_all_subwindows with root
5191 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5193 * fns.c (Fputhash): Document return value.
5195 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5197 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5199 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5201 Cons<->int and similar integer overflow fixes (Bug#8794).
5203 Check for overflow when converting integer to cons and back.
5204 * charset.c (Fdefine_charset_internal, Fdecode_char):
5205 Use cons_to_unsigned to catch overflow.
5206 (Fencode_char): Use INTEGER_TO_CONS.
5207 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5208 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5209 * data.c (long_to_cons, cons_to_long): Remove.
5210 (cons_to_unsigned, cons_to_signed): New functions.
5211 These signal an error for invalid or out-of-range values.
5212 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5213 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5214 * font.c (Ffont_variation_glyphs):
5215 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5216 * lisp.h: Include <intprops.h>.
5217 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5218 (cons_to_signed, cons_to_unsigned): New decls.
5219 (long_to_cons, cons_to_long): Remove decls.
5220 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5221 (Fprimitive_undo): Use CONS_TO_INTEGER.
5222 * xfns.c (Fx_window_property): Likewise.
5223 * xselect.c: Include <limits.h>.
5224 (x_own_selection, selection_data_to_lisp_data):
5225 Use INTEGER_TO_CONS.
5226 (x_handle_selection_request, x_handle_selection_clear)
5227 (x_get_foreign_selection, Fx_disown_selection_internal)
5228 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5229 (lisp_data_to_selection_data): Use cons_to_unsigned.
5230 (x_fill_property_data): Use cons_to_signed.
5231 Report values out of range.
5233 Check for buffer and string overflow more precisely.
5234 * buffer.h (BUF_BYTES_MAX): New macro.
5235 * lisp.h (STRING_BYTES_MAX): New macro.
5236 * alloc.c (Fmake_string):
5237 * character.c (string_escape_byte8):
5238 * coding.c (coding_alloc_by_realloc):
5239 * doprnt.c (doprnt):
5240 * editfns.c (Fformat):
5242 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5243 since they may not be the same number.
5244 * editfns.c (Finsert_char):
5245 * fileio.c (Finsert_file_contents):
5246 Likewise for BUF_BYTES_MAX.
5248 * image.c: Use ptrdiff_t, not int, for sizes.
5249 (slurp_file): Switch from int to ptrdiff_t.
5251 (slurp_file): Check that file size fits in both size_t (for
5252 malloc) and ptrdiff_t (for sanity and safety).
5254 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5255 if b->modtime has its maximal value.
5257 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5259 Don't assume time_t can fit into int.
5260 * buffer.h (struct buffer.modtime): Now time_t, not int.
5261 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5262 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5264 Minor fixes for signed vs unsigned integers.
5265 * character.h (MAYBE_UNIFY_CHAR):
5266 * charset.c (maybe_unify_char):
5267 * keyboard.c (read_char, reorder_modifiers):
5268 XINT -> XFASTINT, since the integer must be nonnegative.
5269 * ftfont.c (ftfont_spec_pattern):
5270 * keymap.c (access_keymap, silly_event_symbol_error):
5271 XUINT -> XFASTINT, since the integer must be nonnegative.
5272 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5273 since it makes no difference and we prefer signed.
5274 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5275 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5278 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5280 * window.h (Fwindow_frame): Declare.
5282 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5284 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5285 (SPARE_MEMORY): Always define.
5286 (LARGE_REQUEST): Remove.
5287 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5289 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5291 * lisp.h: Move EXFUNS for Fframe_root_window,
5292 Fframe_first_window and Fset_frame_selected_window to window.h.
5294 * window.h: Move EXFUNS for Fframe_root_window,
5295 Fframe_first_window and Fset_frame_selected_window here from
5298 * frame.c (Fwindow_frame, Fframe_first_window)
5299 (Fframe_root_window, Fframe_selected_window)
5300 (Fset_frame_selected_window): Move to window.c.
5301 (Factive_minibuffer_window): Move to minibuf.c.
5302 (Fother_visible_frames_p): New function.
5304 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5306 * window.c (decode_window, decode_any_window): Move up in code.
5307 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5308 (inhibit_frame_unsplittable): Remove unused variable.
5309 (Fwindow_buffer): Move up and rewrite doc-string.
5310 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5311 (Fwindow_prev): New functions.
5312 (Fwindow_frame): Move here from frame.c. Accept any window as
5314 (Fframe_root_window, Fframe_first_window)
5315 (Fframe_selected_window): Move here from frame.c. Accept frame
5316 or arbitrary window as argument. Update doc-strings.
5317 (Fminibuffer_window): Move up in code.
5318 (Fwindow_minibuffer_p): Move up in code and simplify.
5319 (Fset_frame_selected_window): Move here from frame.c.
5321 (Fselected_window, select_window, Fselect_window): Move up in
5322 code. Minor doc-string fixes.
5324 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5326 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5327 Do not assume that spare memory exists; that assumption is valid
5328 only if SYSTEM_MALLOC.
5329 (LARGE_REQUEST): New macro, so that the issue of large requests
5330 is separated from the issue of spare memory.
5332 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5334 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5337 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5339 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5342 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5344 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5346 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5348 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5349 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5351 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5353 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5355 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5357 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5358 (x_clipboard_manager_save): Add return value.
5359 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5361 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5362 Obey Vx_select_enable_clipboard_manager. Catch errors in
5363 x_clipboard_manager_save (Bug#8779).
5364 (Vx_select_enable_clipboard_manager): New variable.
5365 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5367 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5369 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5371 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5373 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5374 in the current matrix if keep_current_p is non-zero.
5376 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5378 * bidi.c (bidi_level_of_next_char): Fix last change.
5380 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5382 Support bidi reordering of text covered by display properties.
5384 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5385 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5386 (bidi_cache_search, bidi_cache_iterator_state)
5387 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5388 (bidi_level_of_next_char, bidi_move_to_visually_next):
5389 Support character positions inside a run of characters covered by a
5391 (bidi_paragraph_init, bidi_resolve_explicit_1)
5392 (bidi_level_of_next_char): Call bidi_fetch_char and
5393 bidi_fetch_char_advance instead of FETCH_CHAR and
5395 (bidi_init_it): Initialize new members.
5396 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5398 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5399 instead of using explicit *_CHAR codes.
5400 (bidi_resolve_explicit, bidi_resolve_weak):
5401 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5402 bidirectional text is supported only in multibyte buffers.
5403 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5404 it to initialize the frame_window_p member of struct bidi_it.
5405 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5406 (bidi_resolve_explicit, bidi_resolve_weak)
5407 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5408 bidi_it->nchars is non-positive.
5409 (bidi_level_of_next_char): Don't try to lookup the cache for the
5410 next/previous character if nothing is cached there yet, or if we
5411 were just reseat()'ed to a new position.
5413 * xdisp.c (set_cursor_from_row): Set start and stop points
5414 according to the row's direction when priming the loop that looks
5415 for the glyph on which to display cursor.
5416 (single_display_spec_intangible_p): Function deleted.
5417 (display_prop_intangible_p): Reimplement to call
5418 handle_display_spec instead of single_display_spec_intangible_p.
5419 Accept 3 additional arguments needed by handle_display_spec.
5420 This fixes incorrect cursor motion across display property with complex
5421 values: lists, `(when COND...)' forms, etc.
5422 (single_display_spec_string_p): Support property values that are
5423 lists with the argument STRING its top-level element.
5424 (display_prop_string_p): Fix the condition for processing a
5425 property that is a list to be consistent with handle_display_spec.
5426 (handle_display_spec): New function, refactored from the
5427 last portion of handle_display_prop.
5428 (compute_display_string_pos): Accept additional argument
5429 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5430 value of a `display' property is a "replacing spec".
5431 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5432 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5433 the display property, but just return a value indicating whether
5434 the display property will replace the characters it covers.
5435 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5436 frame_window_p members of struct bidi_it.
5437 (compute_display_string_pos, compute_display_string_end):
5439 (push_it): Accept second argument POSITION, where pop_it should
5440 jump to continue iteration.
5441 (reseat_1): Initialize bidi_it.disp_pos.
5443 * keyboard.c (adjust_point_for_property): Adjust the call to
5444 display_prop_intangible_p to its new signature.
5446 * dispextern.h (struct bidi_it): New member frame_window_p.
5447 (bidi_init_it): Update prototypes.
5448 (display_prop_intangible_p): Update prototype.
5449 (compute_display_string_pos, compute_display_string_end):
5451 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5454 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5456 Malloc failure behavior now depends on size of allocation.
5457 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5458 * lisp.h: Change signatures accordingly.
5459 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5460 All callers changed. (Bug#8762)
5462 * gnutls.c: Use Emacs's memory allocators.
5463 Without this change, the gnutls library would invoke malloc etc.
5464 directly, which causes problems on non-SYNC_INPUT hosts, and which
5465 runs afoul of improving memory_full behavior. (Bug#8761)
5466 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5467 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5468 xfree instead of the default malloc, realloc, free.
5469 (Fgnutls_boot): No need to check for memory allocation failure,
5470 since xmalloc does that for us.
5472 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5473 * category.c (hash_get_category_set):
5474 * ccl.c (ccl_driver):
5475 * charset.c (Fdefine_charset_internal):
5476 * charset.h (struct charset.hash_index):
5477 * composite.c (get_composition_id, gstring_lookup_cache)
5478 (composition_gstring_put_cache):
5479 * composite.h (struct composition.hash_index):
5480 * dispextern.h (struct image.hash):
5481 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5482 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5483 (hashfn_equal, hashfn_user_defined, make_hash_table)
5484 (maybe_resize_hash_table, hash_lookup, hash_put)
5485 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5486 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5487 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5488 * image.c (make_image, search_image_cache, lookup_image)
5489 (xpm_put_color_table_h):
5490 * lisp.h (struct Lisp_Hash_Table):
5491 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5492 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5493 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5494 * alloc.c (allocate_vectorlike):
5495 Check for overflow in vector size calculations.
5496 * ccl.c (ccl_driver):
5497 Check for overflow when converting EMACS_INT to int.
5498 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5499 need to be updated by these changes.
5500 * fns.c (make_hash_table, maybe_resize_hash_table):
5501 Check for integer overflow with large hash tables.
5502 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5503 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5504 (SXHASH_REDUCE): New macro.
5505 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5506 Use it instead of discarding useful hash info with large hash values.
5507 (sxhash_float): New function.
5508 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5509 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5510 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5511 Rewrite to use FIXNUM_BITS, as this simplifies things.
5512 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5513 Adjust signatures to match updated version of code.
5514 (consing_since_gc): Now EMACS_INT, since a single hash table can
5515 use more than INT_MAX bytes.
5517 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5519 Make it possible to build with GCC-4.6+ -O2 -flto.
5521 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5523 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5525 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5526 Call minibuffer-inactive-mode.
5528 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5530 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5531 Update dependencies.
5533 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5535 * data.c (init_data): Remove code for UTS, this system is not
5538 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5540 Don't force ./temacs to start in terminal mode.
5542 * frame.c (make_initial_frame): Initialize faces in all cases, not
5543 only when CANNOT_DUMP is defined.
5544 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5546 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5548 * dispnew.c (add_window_display_history): Use const for the string
5549 pointer. Remove declaration, not needed.
5551 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5553 Use 'inline', not 'INLINE'.
5554 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5555 * alloc.c, fontset.c (INLINE): Remove.
5556 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5557 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5558 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5559 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5560 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5562 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5564 Make it possible to run ./temacs.
5566 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5567 syms_of_callproc does the same thing. Remove test for
5568 "initialized", do it in the caller.
5569 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5571 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5573 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5574 (read_minibuf): Use get_minibuffer.
5575 (syms_of_minibuf): Use DEFSYM.
5576 (Qmetadata): New var.
5577 * data.c (Qbuffer): Don't make it static.
5578 (syms_of_data): Use DEFSYM.
5580 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5582 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5583 (CCL_CODE_MIN): New macro.
5585 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5587 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5589 * eval.c (Qdebug): Now static.
5590 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5591 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5592 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5594 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5596 * image.c: Various fixes to ImageMagick code comments.
5597 (Fimagemagick_types): Doc fix.
5599 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5601 Minor fixes prompted by GCC 4.6.0 warnings.
5603 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5605 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5606 (x_clipboard_manager_save_all): Move extern decl to ...
5607 * xterm.h: ... here, so that it can be checked for consistency.
5609 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5611 * xselect.c (x_clipboard_manager_save_frame)
5612 (x_clipboard_manager_save_all): New functions.
5613 (Fx_clipboard_manager_save): Lisp function deleted.
5615 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5616 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5618 * xterm.h: Update prototype.
5620 2011-05-28 William Xu <william.xwl@gmail.com>
5622 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5625 2011-05-28 Jim Meyering <meyering@redhat.com>
5627 Avoid a sign-extension bug in crypto_hash_function.
5628 * fns.c (to_uchar): Define.
5629 (crypto_hash_function): Use it to convert some newly-signed
5630 variables to unsigned, to avoid sign-extension bugs. For example,
5631 without this change, (md5 "truc") would evaluate to
5632 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5633 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5634 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5636 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5638 Integer overflow fixes.
5640 * dbusbind.c: Serial number integer overflow fixes.
5641 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5642 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5643 to hold a serial number that is too large for a fixnum.
5644 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5645 Check for serial numbers out of range. Decode any serial number
5646 that was so large that it became a float. (Bug#8722)
5648 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5649 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5650 Use XFASTINT rather than XUINT when numbers are nonnegative.
5651 (xd_append_arg, Fdbus_method_return_internal):
5652 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5653 arguments, check that Lisp number is nonnegative, rather than
5654 silently wrapping negative numbers around. (Bug#8722)
5655 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5658 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5660 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5662 ccl: add integer overflow checks
5663 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5664 (IN_INT_RANGE): New macros.
5665 (ccl_driver): Use them to check for integer overflow when
5666 decoding a CCL program. Many of the new checks are whether XINT (x)
5667 fits in int; it doesn't always, on 64-bit hosts. The new version
5668 doesn't catch all possible integer overflows, but it's an
5669 improvement. (Bug#8719)
5671 * alloc.c (make_event_array): Use XINT, not XUINT.
5672 There's no need for unsigned here.
5674 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5675 This follows up to the 2011-05-06 change that substituted uintptr_t
5676 for EMACS_INT. This case wasn't caught back then.
5678 Rework Fformat to avoid integer overflow issues.
5679 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5680 now (part of C89). Include <verify.h>.
5681 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5682 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5683 (Fformat): Avoid the prepass trying to compute sizes; it was only
5684 approximate and thus did not catch overflow reliably. Instead, walk
5685 through the format just once, formatting and computing sizes as we go,
5686 checking for integer overflow at every step, and allocating a larger
5687 buffer as needed. Keep track separately whether the format is
5688 multibyte. Keep only the most-recently calculated precision, rather
5689 than them all. Record whether each argument has been converted to
5690 string. Use EMACS_INT, not int, for byte and char and arg counts.
5691 Support field widths and precisions larger than INT_MAX. Avoid
5692 sprintf's undefined behavior with conversion specifications such as %#d
5693 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5694 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5695 formatting out-of-range floating point numbers with int
5698 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5700 * data.c: Avoid integer truncation in expressions involving floats.
5701 * data.c: Include <intprops.h>.
5702 (arith_driver): When there's an integer overflow in an expression
5703 involving floating point, convert the integers to floating point
5704 so that the resulting value does not suffer from catastrophic
5705 integer truncation. For example, on a 64-bit host (* 4
5706 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5707 Do not rely on undefined behavior after integer overflow.
5709 merge count_size_as_multibyte, parse_str_to_multibyte
5710 * character.c, character.h (count_size_as_multibyte):
5711 Rename from parse_str_to_multibyte; all uses changed.
5712 Check for integer overflow.
5713 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5714 since it's now a duplicate of the other. This is more of
5715 a character than a buffer op, so better that it's in character.c.
5716 * fns.c, print.c: Adjust to above changes.
5718 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5720 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5722 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5724 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5725 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5726 (x_clipboard_manager_save): Now static.
5727 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5729 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5730 (crypto_hash_function): Now static.
5731 Fix pointer signedness problems. Avoid unnecessary initializations.
5733 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5735 * termhooks.h (Vselection_alist): Make it terminal-local.
5737 * terminal.c (create_terminal): Initialize it.
5739 * xselect.c: Support for clipboard managers.
5740 (Vselection_alist): Move to termhooks.h as terminal-local var.
5741 (LOCAL_SELECTION): New macro.
5742 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5743 (symbol_to_x_atom): Remove gratuitous arg.
5744 (x_handle_selection_request, lisp_data_to_selection_data)
5745 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5746 (x_own_selection, x_get_local_selection, x_convert_selection):
5747 New arg, specifying work frame. Use terminal-local Vselection_alist.
5748 (some_frame_on_display): Delete unused function.
5749 (Fx_own_selection_internal, Fx_get_selection_internal)
5750 (Fx_disown_selection_internal, Fx_selection_owner_p)
5751 (Fx_selection_exists_p): New optional frame arg.
5752 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5753 (x_handle_selection_clear): Don't treat other terminals with the
5754 same keyboard specially. Use the terminal-local Vselection_alist.
5755 (x_clear_frame_selections): Use Frun_hook_with_args.
5757 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5759 * xterm.h: Add support for those atoms.
5761 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5763 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5764 (converted_selections, conversion_fail_tag): New global variables.
5765 (x_selection_request_lisp_error): Free the above.
5766 (x_get_local_selection): Remove unnecessary code.
5767 (x_reply_selection_request): Args changed; handle arbitrary array
5768 of converted selections stored in converted_selections.
5769 Separate the XChangeProperty and SelectionNotify steps.
5770 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5771 (x_convert_selection): New function.
5772 (x_handle_selection_event): Simplify.
5773 (x_get_foreign_selection): Don't ignore incoming requests while
5774 waiting for an answer; this will fail when we implement
5775 SAVE_TARGETS, and seems unnecessary anyway.
5776 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5777 (Vx_sent_selection_functions): Doc fix.
5779 2011-05-26 Leo Liu <sdl.web@gmail.com>
5781 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5783 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5785 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5787 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5788 for fringe update if it has periodic bitmap.
5789 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5790 and fringe_bitmap_periodic_p.
5792 * fringe.c (get_fringe_bitmap_data): New function.
5793 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5794 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5795 row. Mark glyph row for fringe update if periodicity changed.
5797 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5798 for fringe update unless it has periodic bitmap.
5800 2011-05-25 Kenichi Handa <handa@m17n.org>
5802 * xdisp.c (get_next_display_element): Set correct it->face_id for
5803 a static composition.
5805 2011-05-24 Leo Liu <sdl.web@gmail.com>
5808 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5810 * fns.c (crypto_hash_function, Fsha1): New function.
5811 (Fmd5): Use crypto_hash_function.
5812 (syms_of_fns): Add Ssha1.
5814 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5816 * gnutls.c: Remove unused macros.
5817 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5818 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5819 Remove macros that are defined and never used.
5820 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5822 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5824 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5825 (Fx_get_selection_internal): Minor cleanup.
5826 (Fx_own_selection_internal): Rename arguments for consistency with
5829 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5831 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5833 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5835 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5837 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5839 * dispnew.c (scrolling_window): Don't exclude the case that the
5840 last enabled row in the desired matrix touches the bottom boundary.
5842 2011-05-21 Glenn Morris <rgm@gnu.org>
5844 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5845 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5846 and add some more files.
5848 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5850 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5851 report_file_error introduced by the change from 2011-05-07.
5853 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5855 * systime.h (Time): Define only if emacs is defined.
5856 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5857 where the include path doesn't have X11/X.h by default. See
5858 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5860 2011-05-20 Kenichi Handa <handa@m17n.org>
5862 * composite.c (find_automatic_composition): Fix previous change.
5864 2011-05-20 Glenn Morris <rgm@gnu.org>
5866 * lisp.mk: New file, split from Makefile.in.
5867 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5868 (shortlisp): Remove.
5869 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5871 2011-05-19 Glenn Morris <rgm@gnu.org>
5873 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5874 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5875 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5876 (lisp): Set the order to that of loadup.el.
5877 (shortlisp): Make it a copy of $lisp.
5878 (SOME_MACHINE_LISP): Remove.
5879 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5880 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5882 2011-05-18 Kenichi Handa <handa@m17n.org>
5884 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5885 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5886 (find_automatic_composition): Mostly rewrite for efficiency.
5888 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5890 * makefile.w32-in: Update dependencies.
5892 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5894 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5895 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5897 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5899 Fix some integer overflow issues, such as string length overflow.
5901 * insdel.c (count_size_as_multibyte): Check for string overflow.
5903 * character.c (lisp_string_width): Check for string overflow.
5904 Use EMACS_INT, not int, for string indexes and lengths; in
5905 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5906 the resulting string length overflows an EMACS_INT; instead,
5907 report a string overflow if no precision given. When checking for
5908 precision exhaustion, use a check that cannot possibly have
5909 integer overflow. (Bug#8675)
5910 * character.h (lisp_string_width): Adjust to new signature.
5912 * alloc.c (string_overflow): New function.
5913 (Fmake_string): Use it. This doesn't change behavior, but saves
5914 a few bytes and will simplify future changes.
5915 * character.c (string_escape_byte8): Likewise.
5916 * lisp.h (string_overflow): New decl.
5918 Fixups, following up to the user-interface timestamp change.
5919 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5920 for UI timestamps, instead of unsigned long.
5921 * msdos.c (mouse_get_pos): Likewise.
5922 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5923 * w32gui.h (Time): Define by including "systime.h" rather than by
5924 declaring it ourselves. (Bug#8664)
5926 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5927 * image.c (clear_image_cache): Likewise.
5929 * term.c (term_mouse_position): Don't assume time_t wraparound.
5931 Be more systematic about user-interface timestamps.
5932 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5933 and sometimes 'EMACS_UINT', to represent these timestamps.
5934 This change causes it to use 'Time' uniformly, as that's what X uses.
5935 This makes the code easier to follow, and makes it easier to catch
5936 integer overflow bugs such as Bug#8664.
5937 * frame.c (Fmouse_position, Fmouse_pixel_position):
5938 Use Time, not unsigned long, for user-interface timestamps.
5939 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5940 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5941 * keyboard.h (last_event_timestamp): Likewise.
5942 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5943 * menu.h (xmenu_show): Likewise.
5944 * term.c (term_mouse_position): Likewise.
5945 * termhooks.h (struct input_event.timestamp): Likewise.
5946 (struct terminal.mouse_position_hook): Likewise.
5947 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5948 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5949 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5950 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5952 * menu.h, termhooks.h: Include "systime.h", for Time.
5954 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5955 Don't assume that the difference between two unsigned long values
5956 can fit into an integer. At this point, we know button_down_time
5957 <= event->timestamp, so the difference must be nonnegative, so
5958 there's no need to cast the result if double-click-time is
5959 nonnegative, as it should be; check that it's nonnegative, just in
5960 case. This bug is triggered when events are more than 2**31 ms
5961 apart (about 25 days). (Bug#8664)
5963 * xselect.c (last_event_timestamp): Remove duplicate decl.
5964 (x_own_selection): Remove needless cast to unsigned long.
5966 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5967 that always fit in int. Use a sentinel instead of a counter, to
5968 avoid a temp and to allay GCC's concerns about possible int overflow.
5969 * frame.h (struct frame): Use int for menu_bar_items_used
5970 instead of EMACS_INT, since it always fits in int.
5972 * menu.c (grow_menu_items): Check for int overflow.
5974 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5976 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5977 Before, the code was not consistent. These values cannot exceed
5978 2**31 - 1 so there's no need to make them unsigned.
5979 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5980 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5981 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5983 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5985 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5986 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5987 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5988 presumably because the widths might not match.
5990 * window.c (size_window): Avoid needless test at loop start.
5992 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5994 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5996 2011-05-12 Drew Adams <drew.adams@oracle.com>
5998 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6000 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6002 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6003 `width' to `bar_area_x' and `bar_area_width', respectively.
6004 (x_scroll_run): Take account of fringe background extension.
6006 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6007 Rename local vars `left' and `width' to `bar_area_x' and
6008 `bar_area_width', respectively.
6009 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6010 background extension.
6012 2011-05-10 Jim Meyering <meyering@redhat.com>
6014 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6016 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6018 * image.c (Finit_image_library): Return t for built-in image types,
6019 like pbm and xbm. (Bug#8640)
6021 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6023 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6025 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6027 * w32console.c (Fset_screen_color): Doc fix.
6028 (Fget_screen_color): New function.
6029 (syms_of_ntterm): Defsubr it.
6031 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6032 unlink the temporary file if Fcall_process didn't create it in the
6034 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6035 child process will be redirected to a file specified with `:file'.
6036 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6037 cue to call_process_cleanup not to close that handle.
6039 2011-05-07 Ben Key <bkey76@gmail.com>
6041 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6042 one of two shell specific rules, either bootstrap-temacs-CMD or
6043 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6044 to the previous implementation of the bootstrap-temacs rule.
6045 The bootstrap-temacs-CMD rule is similar to the previous
6046 implementation of the bootstrap-temacs rule except that it
6047 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6050 These changes, along with some changes to nt/configure.bat,
6051 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6052 earlier fix to add support for --cflags and --ldflags options
6053 that include quotes so that it works whether make uses cmd or
6056 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6058 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6059 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6061 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6062 a string. Handle both cases.
6063 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6064 (Fdbus_register_method): Use Qinvalid_function.
6066 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6068 * makefile.w32-in: Update dependencies.
6069 (LISP_H): Add inttypes.h and stdin.h.
6070 (PROCESS_H): Add unistd.h.
6072 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6074 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6075 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6077 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6079 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6081 * term.c (vfatal): Remove stray call to va_end.
6082 It's not needed and the C Standard doesn't allow it here anyway.
6084 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6085 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6087 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6090 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6092 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6094 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6096 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6098 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6100 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6101 * charset.c (Fdefine_charset_internal): Don't initialize
6102 charset.code_space[15]. The value was garbage, on hosts with
6103 32-bit int (Bug#8600).
6105 * lread.c (read_integer): Be more consistent with string-to-number.
6106 Use string_to_number to do the actual conversion; this avoids
6107 rounding errors and fixes some other screwups. Without this fix,
6108 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6109 (digit_to_number): Move earlier, for benefit of read_integer.
6110 Return -1 if the digit is out of range for the base, -2 if it is
6111 not a digit in any supported base. (Bug#8602)
6113 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6115 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6116 to match comment at start of function. This also removes a
6117 GCC warning about overflow in a 32+64-bit port.
6119 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6121 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6122 Reported by Stefan Monnier in
6123 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6124 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6125 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6127 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6128 (EMACS_UINTPTR): Likewise, with uintptr_t.
6130 * lisp.h: Prefer 64-bit EMACS_INT if available.
6131 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6132 on 32-bit hosts that have 64-bit int, so that they can access
6134 However, temporarily disable this change unless the temporary
6135 symbol WIDE_EMACS_INT is defined.
6137 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6139 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6140 This removes an assumption that EMACS_INT and long are the same
6141 width as pointers. The assumption is true for Emacs porting targets
6142 now, but we want to make other targets possible.
6143 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6144 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6145 In the rest of the code, change types of integers that hold casted
6146 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6147 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6148 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6149 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6150 No need to cast type when ORing.
6151 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6152 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6153 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6154 assume EMACS_INT is the same width as char *.
6155 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6156 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6157 Remove no-longer-needed casts.
6158 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6159 (xg_tool_bar_help_callback, xg_make_tool_item):
6160 Use EMACS_INTPTR to hold an integer
6161 that will be cast to void *; this can avoid a GCC warning
6162 if EMACS_INT is not the same width as void *.
6163 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6164 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6165 (current_message_1, set_message_1):
6166 Use a local to convert to proper width without a cast.
6167 * xmenu.c (dialog_selection_callback): Likewise.
6169 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6170 Also, don't assume VALBITS / RAND_BITS is less than 5,
6171 and don't rely on undefined behavior when shifting a 1 left into
6173 * lisp.h (get_random): Change signature to match.
6175 * lread.c (hash_string): Use size_t, not int, for hash computation.
6176 Normally we prefer signed values; but hashing is special, because
6177 it's better to use unsigned division on hash table sizes so that
6178 the remainder is nonnegative. Also, size_t is the natural width
6179 for hashing into memory. The previous code used 'int', which doesn't
6180 retain enough info to hash well into very large tables.
6181 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6183 * dbusbind.c: Don't possibly lose pointer info when converting.
6184 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6185 Use XPNTR rather than XHASH, so that the high-order bits of
6186 the pointer aren't lost when converting through void *.
6188 * eval.c (Fautoload): Don't double-shift a pointer.
6190 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6192 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6194 * gnutls.c (DEF_GNUTLS_FN):
6195 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6197 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6199 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6202 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6204 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6205 New version that can reserve upto 2GB of heap space.
6207 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6209 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6211 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6213 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6214 `gnutls_certificate_set_x509_key_file'.
6216 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6218 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6219 Update dependencies.
6221 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6223 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6224 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6225 Remove unused parameter `fildes'.
6226 * process.c (read_process_output, send_process): Don't pass it.
6228 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6230 Fix previous change: the library cache is defined in w32.c.
6231 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6232 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6234 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6236 Implement dynamic loading of GnuTLS on Windows.
6238 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6239 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6240 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6243 * gnutls.c (Qgnutls_dll): Define.
6244 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6245 (gnutls_*): Declare function pointers.
6246 (init_gnutls_functions): New function to initialize function pointers.
6247 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6248 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6249 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6250 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6251 (emacs_gnutls_write, emacs_gnutls_read)
6252 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6253 (Fgnutls_available_p): New function.
6254 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6255 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6256 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6258 * image.c: Include w32.h.
6259 (Vimage_type_cache): Delete.
6260 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6261 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6262 (w32_delayed_load): Move to w32.c.
6264 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6266 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6267 (w32_delayed_load): Move from image.c. When loading a library, record
6268 its filename in the :loaded-from property of the library id.
6269 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6270 Initialize and staticpro them.
6271 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6273 * process.c: Include lisp.h before w32.h, not after.
6274 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6275 instead of gnutls_record_check_pending.
6277 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6279 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6281 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6282 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6285 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6287 * xterm.c (x_set_frame_alpha): Do not set property on anything
6288 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6290 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6292 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6294 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6296 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6297 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6298 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6299 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6300 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6301 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6302 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6303 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6304 (Qgnutls_bootprop_callbacks_verify): Make static.
6306 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6308 * callproc.c: Indentation fixup.
6310 * sysdep.c (wait_for_termination_1): Make static.
6311 (wait_for_termination, interruptible_wait_for_termination):
6312 Move after wait_for_termination_1.
6314 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6316 * sysdep.c (interruptible_wait_for_termination): New function
6317 which is like wait_for_termination, but allows keyboard
6320 * callproc.c (Fcall_process): Add (:file "file") as an option for
6322 (Fcall_process_region): Ditto.
6324 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6326 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6327 rather than `XVECTOR (FOO)->size'.
6329 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6330 inttypes.h, as a gnulib replacement is used if it not available in
6333 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6335 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6336 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6337 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6339 * coding.c (coding_alloc_by_realloc): Error out if destination
6340 will grow beyond MOST_POSITIVE_FIXNUM.
6341 (decode_coding_emacs_mule): Abort if there isn't enough place in
6342 charbuf for the composition carryover bytes. Reserve an extra
6343 space for up to 2 characters produced in a loop.
6344 (decode_coding_iso_2022): Abort if there isn't enough place in
6345 charbuf for the composition carryover bytes.
6347 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6349 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6350 aborting when %lld or %lll format is passed.
6351 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6352 %llo or %llx format is passed. (Bug#8545)
6354 * window.c (window_scroll_line_based): Use a marker instead of
6355 simple variables to record original value of point. (Bug#7952)
6357 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6358 produced by %s or %c overflows available buffer space. (Bug#8545)
6360 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6362 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6363 (SIZE_MAX): Move defn after all includes, as they might #define it.
6365 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6367 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6369 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6371 * keyboard.c (Qdelayed_warnings_hook): Define.
6372 (command_loop_1): Run `delayed-warnings-hook'
6373 if Vdelayed_warnings_list is non-nil.
6374 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6375 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6377 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6379 * doprnt.c (doprnt): Don't return value smaller than the buffer
6380 size if the message was truncated. (Bug#8545).
6382 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6384 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6385 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6387 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6389 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6391 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6393 * makefile.w32-in: Update dependencies.
6395 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6397 Improve `doprnt' and its usage. (Bug#8545)
6398 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6399 `format_end'. Remove support for %l as a conversion specifier.
6400 Don't use xrealloc. Improve diagnostics when the %l size modifier
6401 is used. Update the commentary.
6403 * eval.c (verror): Simplify calculation of size_t.
6405 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6408 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6410 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6413 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6415 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6416 This makes this file independent of the recent pseudovector change.
6418 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6420 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6422 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6423 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6424 Remove unused local.
6425 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6427 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6428 GCC 4.6.0 optimizes based on type-based alias analysis.
6429 For example, if b is of type struct buffer * and v of type struct
6430 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6431 != &v->size, and therefore "v->size = 1; b->size = 2; return
6432 v->size;" must therefore return 1. This assumption is incorrect
6433 for Emacs, since it type-puns struct Lisp_Vector * with many other
6434 types. To fix this problem, this patch adds a new type struct
6435 vectorlike_header that documents the constraints on layout of vectors
6436 and pseudovectors, and helps optimizing compilers not get fooled
6437 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6438 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6439 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6441 (XSETPVECTYPE): Rewrite in terms of new macro.
6442 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6443 This is a bit clearer, and further avoids the possibility of
6444 undesirable aliasing.
6445 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6446 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6447 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6448 since Lisp_Subr is a special case (no "next" field).
6449 (ASIZE): Now uses header.size rather than size.
6450 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6451 to avoid the hassle of writing XVECTOR (foo)->header.size.
6452 (struct vectorlike_header): New type.
6453 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6454 object, to help avoid aliasing.
6455 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6456 (SUBRP): Likewise, since Lisp_Subr is a special case.
6457 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6458 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6459 (struct Lisp_Hash_Table): Combine first two members into a single
6460 struct vectorlike_header member. All uses of "size" and "next" members
6461 changed to be "header.size" and "header.next".
6462 * buffer.h (struct buffer): Likewise.
6463 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6464 * frame.h (struct frame): Likewise.
6465 * process.h (struct Lisp_Process): Likewise.
6466 * termhooks.h (struct terminal): Likewise.
6467 * window.c (struct save_window_data, struct saved_window): Likewise.
6468 * window.h (struct window): Likewise.
6469 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6470 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6471 * buffer.c (init_buffer_once): Likewise.
6472 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6474 * process.c (Fformat_network_address): Use local var for size,
6477 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6479 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6480 * data.c (atof): Remove decl; no longer used or needed.
6481 (digit_to_number): Move to lread.c.
6482 (Fstring_to_number): Use new string_to_number function, to be
6483 consistent with how the Lisp reader treats infinities and NaNs.
6484 Do not assume that floating-point numbers represent EMACS_INT
6485 without losing information; this is not true on most 64-bit hosts.
6486 Avoid double-rounding errors, by insisting on integers when
6487 parsing non-base-10 numbers, as the documentation specifies.
6488 * lisp.h (string_to_number): New decl, replacing ...
6489 (isfloat_string): Remove.
6490 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6491 (read1): Do not accept +. and -. as integers; this
6492 appears to have been a coding error. Similarly, do not accept
6493 strings like +-1e0 as floating point numbers. Do not report
6494 overflow for integer overflows unless the base is not 10 which
6495 means we have no simple and reliable way to continue.
6496 Break out the floating-point parsing into a new
6497 function string_to_number, so that Fstring_to_number parses
6498 floating point numbers consistently with the Lisp reader.
6499 (digit_to_number): Move here from data.c. Make it static inline.
6500 (E_CHAR, EXP_INT): Remove, replacing with ...
6501 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6502 (string_to_number): New function, replacing isfloat_string.
6503 This function checks for valid syntax and produces the resulting
6504 Lisp float number too. Rework it so that string-to-number
6505 no longer mishandles examples like "1.0e+". Use strtoumax,
6506 so that overflow for non-base-10 numbers is reported only when
6507 there's no portable and simple way to convert to floating point.
6509 * textprop.c (set_text_properties_1): Rewrite for clarity,
6510 and to avoid GCC warning about integer overflow.
6512 * intervals.h (struct interval): Use EMACS_INT for members
6513 where EMACS_UINT might cause problems. See
6514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6515 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6516 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6518 (offset_intervals): Tell GCC not to worry about length overflow
6519 when negating a negative length.
6521 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6522 (overrun_check_free): Likewise.
6524 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6525 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6528 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6529 (gnutls_make_error): Rename local to avoid shadowing.
6530 (gnutls_emacs_global_deinit): ifdef out; not used.
6531 (Fgnutls_boot): Use const for pointer to readonly storage.
6532 Comment out unused local. Fix pointer signedness problems.
6534 * lread.c (openp): Don't stuff size_t into an 'int'.
6535 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6536 about possible signed overflow.
6538 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6539 (GDK_KEY_g): Don't define if already defined.
6540 (xg_prepare_tooltip): Avoid pointer signedness problem.
6541 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6543 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6544 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6546 * xfns.c (Fx_window_property): Simplify a bit,
6547 to make a bit faster and to avoid GCC 4.6.0 warning.
6548 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6550 * fns.c (internal_equal): Don't assume size_t fits in int.
6552 * alloc.c (compact_small_strings): Tighten assertion a little.
6554 Replace pEd with more-general pI, and fix some printf arg casts.
6555 * lisp.h (pI): New macro, generalizing old pEd macro to other
6556 conversion specifiers. For example, use "...%"pI"d..." rather
6557 than "...%"pEd"...".
6558 (pEd): Remove. All uses replaced with similar uses of pI.
6559 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6560 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6561 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6562 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6563 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6564 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6565 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6567 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6568 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6569 * print.c (safe_debug_print, print_object): Likewise.
6570 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6572 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6573 avoiding the 0 flag, which is not portable.
6574 * process.c (Fmake_network_process): Use pI to avoid cast.
6575 * region-cache.c (pp_cache): Likewise.
6576 * xdisp.c (decode_mode_spec): Likewise.
6577 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6578 behavior on 64-bit hosts with printf arg.
6579 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6580 (x_stop_queuing_selection_requests): Likewise.
6581 (x_get_window_property): Don't truncate byte count to an 'int'
6584 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6585 here, since it parses constructs like leading '-' and spaces,
6586 which are not wanted; and it overflows with large numbers.
6587 Instead, simply match F[0-9]+, which is what is wanted anyway.
6589 * alloc.c: Remove unportable assumptions about struct layout.
6590 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6591 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6592 (allocate_vectorlike, make_pure_vector): Use the new macros,
6593 plus offsetof, to remove unportable assumptions about struct layout.
6594 These assumptions hold on all porting targets that I know of, but
6595 they are not guaranteed, they're easy to remove, and removing them
6596 makes further changes easier.
6598 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6599 This doesn't fix a bug but makes the code clearer.
6600 (string_overrun_cookie): Now const. Use initializers that
6601 don't formally overflow signed char, to avoid warnings.
6602 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6603 can cause Emacs to crash when string overrun checking is enabled.
6604 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6605 multiple of sizeof (EMACS_INT); it need not be, if
6606 alignof(EMACS_INT) < sizeof (EMACS_INT).
6607 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6609 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6611 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6613 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6615 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6616 supposed to be handshaking. (Bug#8556)
6617 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6619 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6621 * lisp.h (Qdebug): List symbol.
6622 * eval.c (Qdebug): Restore global linkage.
6623 * keyboard.c (debug-on-event): New variable.
6624 (handle_user_signal): Break into debugger when debug-on-event
6625 matches the current signal symbol.
6627 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6629 * alloc.c (check_sblock, check_string_bytes)
6630 (check_string_free_list): Convert to standard C.
6632 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6634 * w32.c (emacs_gnutls_push): Fix typo.
6636 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6638 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6639 "cast to pointer from integer of different size".
6641 Improve doprnt and its use in verror. (Bug#8545)
6642 * doprnt.c (doprnt): Document the set of format control sequences
6643 supported by the function. Use SAFE_ALLOCA instead of always
6646 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6647 is one byte too soon. Don't use xrealloc; instead xfree and
6650 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6652 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6655 * gnutls.c: Renamed global_initialized to
6656 gnutls_global_initialized. Added internals for the
6657 :verify-hostname-error, :verify-error, and :verify-flags
6658 parameters of `gnutls-boot' and documented those parameters in the
6659 docstring. Start callback support.
6660 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6661 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6662 on error. Return error code.
6663 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6664 (emacs_gnutls_read): Likewise.
6665 (Fgnutls_boot): Return handshake error code.
6666 (emacs_gnutls_handle_error): New function.
6667 (wsaerror_to_errno): Likewise.
6669 * w32.h (emacs_gnutls_pull): Add prototype.
6670 (emacs_gnutls_push): Likewise.
6672 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6673 (emacs_gnutls_push): Likewise.
6675 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6677 * process.c (wait_reading_process_output): Check if GnuTLS
6678 buffered some data internally if no FDs are set for TLS
6681 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6682 (LIBS): Link to USER_LIBS.
6683 ($(BLD)/gnutls.$(0)): New target.
6685 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6687 * xdisp.c (handle_single_display_spec): Rename the
6688 display_replaced_before_p argument into display_replaced_p, to
6689 make it consistent with the commentary. Fix typos in the
6692 * textprop.c (syms_of_textprop): Remove dead code.
6693 (copy_text_properties): Delete obsolete commentary about an
6694 interface that was deleted long ago. Fix typos in the description
6697 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6698 to changes in oldXMenu/XMenu.h from 2011-04-16.
6699 <menu_help_message, prev_menu_help_message>: Constify.
6700 (IT_menu_make_room): menu->help_text is now `const char **';
6703 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6704 to changes in oldXMenu/XMenu.h from 2011-04-16.
6705 (struct XMenu): Declare `help_text' `const char **'.
6707 * xfaces.c <Qunspecified>: Make extern again.
6709 * syntax.c: Include sys/types.h before including regex.h, as
6712 * doc.c (get_doc_string): Improve the format passed to `error'.
6714 * doprnt.c (doprnt): Improve commentary.
6716 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6718 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6721 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6722 changes in globals.h immediately force recompilation.
6723 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6724 $(CURDIR)/s/ms-w32.h.
6725 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6727 * character.c (Fchar_direction): Function deleted.
6728 (syms_of_character): Don't defsubr it.
6729 <char-direction-table>: Deleted.
6731 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6733 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6734 * doprnt.c: Include limits.h.
6735 (SIZE_MAX): New macro.
6736 (doprnt): Return a size_t value. 2nd arg is now size_t.
6737 Many local variables are now size_t instead of int or unsigned.
6738 Improve overflow protection. Support `l' modifier for integer
6739 conversions. Support %l conversion. Don't assume an EMACS_INT
6740 argument for integer conversions and for %c.
6742 * lisp.h (doprnt): Restore prototype.
6744 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6747 * Makefile.in (base_obj): Add back doprnt.o.
6749 * deps.mk (doprnt.o): Add back prerequisites.
6750 (callint.o): Depend on character.h.
6752 * eval.c (internal_lisp_condition_case): Include the handler
6753 representation in the error message.
6754 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6755 when breaking from the loop.
6757 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6759 * callint.c (Fcall_interactively): When displaying error message
6760 about invalid control letter, pass the character's codepoint, not
6761 a pointer to its multibyte form. Improve display of the character
6762 in octal and display also its hex code.
6764 * character.c (char_string): Use %x to display the (unsigned)
6765 codepoint of an invalid character, to avoid displaying a bogus
6768 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6769 `error', not SYMBOL_NAME itself.
6771 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6772 character arguments to `error'.
6774 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6775 to `error' in error message about FINAL_CHAR argument. Make sure
6776 FINAL_CHAR is a character, and use %c when it is passed as
6777 argument to `error'.
6779 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6781 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6783 * w32.c: Include <time.h>.
6784 (sys_localtime): New function.
6786 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6788 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6790 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6792 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6794 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6797 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6799 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6800 gl_state.e_property when gl_state.object is Qt.
6802 * insdel.c (make_gap_larger): Remove limitation of buffer size
6805 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6807 * xdisp.c (lookup_glyphless_char_display)
6808 (produce_glyphless_glyph): Handle cons cell entry in
6809 glyphless-char-display.
6810 (Vglyphless_char_display): Document it.
6812 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6813 glyphless-char-display.
6815 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6817 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6819 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6821 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6822 definition for no-X builds.
6824 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6826 Static checks with GCC 4.6.0 and non-default toolkits.
6828 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6830 * process.c (keyboard_bit_set): Define only if SIGIO.
6831 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6832 (send_process): Repair possible setjmp clobbering.
6834 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6836 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6838 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6840 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6841 Define only if needed.
6843 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6844 by pacifying GCC about it. Maybe it's time to retire it?
6845 * xfaces.c (USG, __TIMEVAL__): Likewise.
6847 * dispextern.h (struct redisplay_interface): Rename param
6849 * termhooks.h (struct terminal): Likewise.
6850 * xterm.c (xembed_send_message): Likewise.
6852 * insdel.c (make_gap_smaller): Define only if
6853 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6855 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6858 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6859 so that we aren't warned about unused symbols.
6861 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6863 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6865 * xfns.c (x_real_positions): Mark locals as initialized.
6867 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6869 * xterm.c: Fix problems found by static analysis with other toolkits.
6870 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6871 (x_dispatch_event): Declare static if USE_GTK, and
6872 define if USE_GTK || USE_X_TOOLKIT.
6873 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6874 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6875 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6876 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6878 * xmenu.c (menu_help_callback): Pointer type fixes.
6879 Use const pointers when pointing at readonly data. Avoid pointer
6881 (FALSE): Remove unused macro.
6882 (update_frame_menubar): Remove unused decl.
6884 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6886 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6887 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6888 (single_menu_item): Rename local to avoid shadowing.
6890 * keyboard.c (make_lispy_event): Remove unused local var.
6892 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6893 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6895 * bitmaps: Change bitmaps from unsigned char back to the X11
6896 compatible char. Avoid the old compiler warnings about
6897 out-of-range initializers by using, for example, '\xab' rather
6900 * xgselect.c (xgselect_initialize): Check vs interface
6901 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6903 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6905 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6906 to read-only memory.
6908 * fns.c (vector): Remove; this old hack is no longer needed.
6910 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6912 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6914 * xrdb.c (x_load_resources): Omit unused local.
6916 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6917 (x_window): Rename locals to avoid shadowing.
6918 (USG): Use the kludged USG macro, to pacify gcc.
6920 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6921 (x_term_init): Remove local to avoid shadowing.
6923 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6925 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6926 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6928 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6930 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6932 Fix regex.c, syntax.c and friends for buffers > 2GB.
6933 * syntax.h (struct gl_state_s): Declare character position members
6936 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6938 * textprop.c (verify_interval_modification, interval_of):
6939 Declare arguments EMACS_INT.
6941 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6944 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6946 * indent.c (Fvertical_motion): Local variable it_start is now
6949 * regex.c (re_match, re_match_2, re_match_2_internal)
6950 (bcmp_translate, regcomp, regexec, print_double_string)
6951 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6952 (re_compile_pattern, re_exec): Declare arguments and local
6953 variables `size_t' and `ssize_t' and return values `regoff_t', as
6955 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6956 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6957 <compile_stack_type>: `size' and `avail' are now `size_t'.
6959 * regex.h <regoff_t>: Use ssize_t, not int.
6960 (re_search, re_search_2, re_match, re_match_2): Arguments that
6961 specify buffer/string position and length are now ssize_t and
6962 size_t. Return type is regoff_t.
6964 2011-04-16 Ben Key <bkey76@gmail.com>
6966 * nsfont.m: Fixed bugs in ns_get_family and
6967 ns_descriptor_to_entity that were caused by using free to
6968 deallocate memory blocks that were allocated by xmalloc (via
6969 xstrdup). This caused Emacs to crash when compiled with
6970 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6971 --enable-checking=xmallocoverrun). xfree is now used to
6972 deallocate these memory blocks.
6974 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6976 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6978 emacs_write: Accept and return EMACS_INT for sizes.
6979 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6981 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6982 Accept and return EMACS_INT.
6983 (emacs_gnutls_write): Return the number of bytes written on
6985 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6986 (emacs_read, emacs_write): Remove check for negative size, as the
6987 Emacs source code has been audited now.
6988 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6989 (emacs_read, emacs_write): Use it.
6990 * process.c (send_process): Adjust to the new signatures of
6991 emacs_write and emacs_gnutls_write. Do not attempt to store
6992 a byte offset into an 'int'; it might overflow.
6993 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6995 * sound.c: Don't assume sizes fit in 'int'.
6996 (struct sound_device.period_size, alsa_period_size):
6997 Return EMACS_INT, not int.
6998 (struct sound_device.write, vox_write, alsa_write):
6999 Accept EMACS_INT, not int.
7000 (wav_play, au_play): Use EMACS_INT to store sizes and to
7001 record read return values.
7003 2011-04-15 Ben Key <bkey76@gmail.com>
7005 * keyboard.c (Qundefined): Don't declare static since it is used
7007 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7008 static since they are used in nsfont.m.
7010 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7012 * process.c (Qprocessp): Don't declare static.
7013 * lisp.h (Qprocessp): Declare again.
7015 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7017 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7019 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7021 Improve C-level modularity by making more things 'static'.
7023 Don't publish debugger-only interfaces to other modules.
7024 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7025 (verify_bytepos, count_markers): Move decls to the only modules
7027 * region-cache.h (pp_cache): Likewise.
7028 * window.h (check_all_windows): Likewise.
7029 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7031 * sysdep.c (croak): Now static, if
7032 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7033 * syssignal.h (croak): Declare only if not static.
7035 * alloc.c (refill_memory_reserve): Now static if
7036 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7037 * lisp.h (refill_memory_reserve): Declare only if not static.
7039 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7040 Define only if USE_LUCID.
7042 * xrdb.c (x_customization_string, x_rm_string): Now static.
7044 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7045 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7047 * xdisp.c (draw_row_with_mouse_face): Now static.
7048 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7050 * window.h (check_all_windows): Mark externally visible.
7052 * window.c (window_deletion_count): Now static.
7054 * undo.c: Make symbols static if they're not exported.
7055 (last_undo_buffer, last_boundary_position, pending_boundary):
7058 * textprop.c (interval_insert_behind_hooks): Now static.
7059 (interval_insert_in_front_hooks): Likewise.
7061 * term.c: Make symbols static if they're not exported.
7062 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7063 (max_frame_lines, tty_set_terminal_modes):
7064 (tty_reset_terminal_modes, tty_turn_off_highlight):
7065 (get_tty_terminal): Now static.
7066 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7067 * termhooks.h (term_mouse_moveto): Do not declare if
7069 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7070 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7072 * sysdep.c: Make symbols static if they're not exported.
7073 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7075 (sigprocmask_set, full_mask): Remove; unused.
7076 (wait_debugging): Mark as visible.
7077 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7078 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7080 * syntax.c (syntax_temp): Define only if !__GNUC__.
7082 * sound.c (current_sound_device, current_sound): Now static.
7084 * search.c (searchbufs, searchbuf_head): Now static.
7086 * scroll.c (scroll_cost): Remove; unused.
7087 * dispextern.h (scroll_cost): Remove decl.
7089 * region-cache.h (pp_cache): Mark as externally visible.
7091 * process.c: Make symbols static if they're not exported.
7092 (process_tick, update_tick, create_process, chan_process):
7093 (Vprocess_alist, proc_buffered_char, datagram_access):
7094 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7095 (deactivate_process): Mark defn as static, as well as decl.
7096 * lisp.h (create_process): Remove decl.
7097 * process.h (chan_process, Vprocess_alist): Remove decls.
7099 * print.c: Make symbols static if they're not exported.
7100 (print_depth, new_backquote_output, being_printed, print_buffer):
7101 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7102 (print_interval, print_number_index, initial_stderr_stream):
7104 * lisp.h (Fprinc): Remove decl.
7105 (debug_output_compilation_hack): Mark as externally visible.
7107 * sysdep.c (croak): Move decl from here to syssignal.h.
7108 * syssignal.h (croak): Put it here, so the API can be checked when
7109 'croak' is called from dissociate_if_controlling_tty.
7111 * minibuf.c: Make symbols static if they're not exported.
7112 (minibuf_save_list, choose_minibuf_frame): Now static.
7113 * lisp.h (choose_minibuf_frame): Remove decl.
7115 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7117 * lread.c: Make symbols static if they're not exported.
7118 (read_objects, initial_obarray, oblookup_last_bucket_number):
7120 (make_symbol): Remove; unused.
7121 * lisp.h (initial_obarray, make_symbol): Remove decls.
7123 * keyboard.c: Make symbols static if they're not exported.
7124 (single_kboard, recent_keys_index, total_keys, recent_keys):
7125 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7126 (this_single_command_key_start, echoing, last_auto_save):
7127 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7128 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7129 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7130 (Vlispy_mouse_stem, double_click_count):
7132 (force_auto_save_soon): Define only if SIGDANGER.
7133 (ignore_mouse_drag_p): Now static if
7134 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7135 (print_help): Remove; unused.
7136 (stop_character, last_timer_event): Mark as externally visible.
7137 * keyboard.h (ignore_mouse_drag_p): Declare only if
7138 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7139 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7140 * lisp.h (echoing): Remove decl.
7141 (force_auto_save_soon): Declare only if SIGDANGER.
7142 * xdisp.c (redisplay_window): Simplify code, to make it more
7143 obvious that ignore_mouse_drag_p is not accessed if !defined
7144 USE_GTK && !defined HAVE_NS.
7146 * intervals.c: Make symbols static if they're not exported.
7147 (merge_properties_sticky, merge_interval_right, delete_interval):
7149 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7151 * insdel.c: Make symbols static if they're not exported.
7152 However, leave prepare_to_modify_buffer alone. It's never
7153 called from outside this function, but that appears to be a bug.
7154 (combine_after_change_list, combine_after_change_buffer):
7155 (adjust_after_replace, signal_before_change): Now static.
7156 (adjust_after_replace_noundo): Remove; unused.
7157 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7158 (signal_before_change): Remove decls.
7160 * indent.c (val_compute_motion, val_vmotion): Now static.
7162 * image.c: Make symbols static if they're not exported.
7163 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7165 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7166 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7168 * fringe.c (standard_bitmaps): Now static.
7169 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7171 * frame.c: Make symbols static if they're not exported.
7172 (x_report_frame_params, make_terminal_frame): Now static.
7173 (get_frame_param): Now static, unless HAVE_NS.
7174 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7175 (x_get_resource_string): Remove; not used.
7176 * frame.h (make_terminal_frame, x_report_frame_params):
7177 (x_get_resource_string); Remove decls.
7178 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7179 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7181 * font.c, fontset.c: Make symbols static if they're not exported.
7182 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7183 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7184 * font.c (font_close_object): Now static.
7185 * font.h (font_close_object): Remove.
7186 * fontset.c (FONTSET_OBJLIST): Remove.
7187 (free_realized_fontset) #if-0 the body, which does nothing.
7188 (face_suitable_for_char_p): #if-0, as it's never called.
7189 * fontset.h (face_suitable_for_char_p): Remove decl.
7190 * xfaces.c (face_at_string_position):
7191 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7192 since 0 is always ASCII.
7194 * fns.c (weak_hash_tables): Now static.
7196 * fileio.c: Make symbols static if they're not exported.
7197 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7198 (Vwrite_region_annotation_buffers): Now static.
7200 * eval.c: Make symbols static if they're not exported.
7201 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7202 * lisp.h (backtrace_list): Remove decl.
7204 * emacs.c: Make symbols static if they're not exported.
7205 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7206 (fatal_error_code, fatal_error_signal_hook, standard_args):
7208 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7209 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7210 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7211 * lisp.h (fatal_error_signal_hook): Remove decl.
7212 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7214 * editfns.c: Move a (normally-unused) function to its only use.
7215 * editfns.c, lisp.h (get_operating_system_release): Remove.
7216 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7217 worth the hassle of breaking this out.
7219 * xterm.c: Make symbols static if they're not exported.
7220 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7221 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7222 (x_destroy_window, x_delete_display):
7224 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7225 (x_mouse_leave): Remove; unused.
7226 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7227 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7228 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7230 (x_mouse_leave): Declare only if WINDOWSNT.
7231 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7232 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7235 * ftxfont.c: Make symbols static if they're not exported.
7236 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7238 * font.h (ftxfont_driver): Likewise.
7240 * xfns.c: Make symbols static if they're not exported.
7241 (x_last_font_name, x_display_info_for_name):
7242 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7243 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7244 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7245 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7246 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7247 (last_show_tip_args): Now static.
7248 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7249 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7250 (x_screen_planes): Remove; unused.
7251 * dispextern.h (x_screen_planes): Remove decl.
7253 * dispnew.c: Make symbols static if they're not exported.
7254 * dispextern.h (redraw_garbaged_frames, scrolling):
7255 (increment_row_positions): Remove.
7256 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7257 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7259 (redraw_garbaged_frames): Remove; unused.
7261 * xfaces.c: Make symbols static if they're not exported.
7262 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7264 * xterm.h (defined_color): Remove decls.
7265 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7266 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7267 (menu_face_changed_default, defined_color, free_realized_face):
7268 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7269 (ascii_face_of_lisp_face): Remove; unused.
7271 * xdisp.c: Make symbols static if they're not exported.
7272 * dispextern.h (scratch_glyph_row, window_box_edges):
7273 (glyph_to_pixel_coords, set_cursor_from_row):
7274 (get_next_display_element, set_iterator_to_next):
7275 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7276 (show_mouse_face): Remove decls
7277 * frame.h (message_buf_print): Likewise.
7278 * lisp.h (pop_message, set_message, check_point_in_composition):
7280 * xterm.h (set_vertical_scroll_bar): Likewise.
7281 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7282 (message_buf_print, scratch_glyph_row, displayed_buffer):
7283 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7284 (get_next_display_element, show_mouse_face, window_box_edges):
7285 (frame_to_window_pixel_xy, check_point_in_composition):
7286 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7287 (glyph_to_pixel_coords): Remove; unused.
7289 * dired.c (file_name_completion): Now static.
7291 * dbusbind.c (xd_in_read_queued_messages): Now static.
7293 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7294 * data.c (circular_list_error): Remove.
7296 * commands.h (last_point_position, last_point_position_buffer):
7297 (last_point_position_window): Remove decls.
7298 * keyboard.c: Make these variables static.
7300 * coding.h (coding, code_convert_region, encode_coding_gap):
7302 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7303 (iso_code_class, detect_coding, code_convert_region): Now static.
7304 (encode_coding_gap): Remove; unused.
7306 * chartab.c (chartab_chars, chartab_bits): Now static.
7308 * charset.h (charset_iso_8859_1): Remove decl.
7309 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7312 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7313 * ccl.c (Vccl_program_table): Now static.
7314 (check_ccl_update): Remove; unused.
7316 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7317 * category.h: ... from here.
7318 * category.c (check_category_table, set_category_set): Now static.
7320 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7321 * lisp.h: Remove these decls.
7323 * buffer.c (buffer_count): Remove unused var.
7325 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7326 so that it's not optimized away.
7327 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7328 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7329 exported only to the debugger.
7331 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7332 * atimer.h (run_all_atimers): Remove; not exported.
7334 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7335 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7336 was inaccessible from Lisp.
7337 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7338 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7340 alloc.c: Import and export fewer symbols, and remove unused items.
7341 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7343 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7344 it's not optimized away by whole-program optimization.
7345 (message_enable_multibyte, free_misc): Remove.
7346 (catchlist, handlerlist, mark_backtrace):
7347 Declare only if BYTE_MARK_STACK.
7348 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7349 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7350 (message_enable_multibyte): Remove decl.
7351 (free_misc, interval_free_list, float_block, float_block_index):
7352 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7353 (cons_free_list, last_marked_index):
7355 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7356 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7357 (mark_backtrace): Define only if BYTE_MARK_STACK.
7358 * xdisp.c (message_enable_multibyte): Now static.
7360 Declare Lisp_Object Q* variables to be 'static' if not exported.
7361 This makes it easier for human readers (and static analyzers)
7362 to see whether these variables are used from other modules.
7363 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7364 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7365 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7366 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7367 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7368 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7369 * xmenu.c, xselect.c:
7370 Declare Q* vars static if they are not used in other modules.
7371 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7372 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7373 Remove decls of unexported vars.
7374 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7376 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7378 Make Emacs functions such as Fatom 'static' by default.
7379 This makes it easier for human readers (and static analyzers)
7380 to see whether these functions can be called from other modules.
7381 DEFUN now defines a static function. To make the function external
7382 so that it can be used in other C modules, use the new macro DEFUE.
7383 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7384 (Finit_image_library):
7385 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7386 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7387 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7388 Remove decls, since these functions are now static.
7389 (Funintern, Fget_internal_run_time): New decls, since these functions
7390 were already external.
7392 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7393 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7394 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7395 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7396 * keyboard.c, keymap.c, lread.c:
7397 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7398 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7399 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7400 Mark functions with DEFUE instead of DEFUN,
7401 if they are used in other modules.
7402 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7403 decls for now-static functions.
7404 * buffer.h (Fdelete_overlay): Remove decl.
7405 * callproc.c (Fgetenv_internal): Mark as internal.
7406 * composite.c (Fremove_list_of_text_properties): Remove decl.
7407 (Fcomposition_get_gstring): New forward static decl.
7408 * composite.h (Fcomposite_get_gstring): Remove decl.
7409 * dired.c (Ffile_attributes): New forward static decl.
7410 * doc.c (Fdocumntation_property): New forward static decl.
7411 * eval.c (Ffetch_bytecode): New forward static decl.
7412 (Funintern): Remove extern decl; now in .h file where it belongs.
7413 * fileio.c (Fmake_symbolic_link): New forward static decl.
7414 * image.c (Finit_image_library): New forward static decl.
7415 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7416 * intervals.h (Fprevious_property_change):
7417 (Fremove_list_of_text_properties): Remove decls.
7418 * keyboard.c (Fthis_command_keys): Remove decl.
7419 (Fcommand_execute): New forward static decl.
7420 * keymap.c (Flookup_key): New forward static decl.
7421 (Fcopy_keymap): Now static.
7422 * keymap.h (Flookup_key): Remove decl.
7423 * process.c (Fget_process): New forward static decl.
7424 (Fprocess_datagram_address): Mark as internal.
7425 * syntax.c (Fsyntax_table_p): New forward static decl.
7426 (skip_chars): Remove duplicate decl.
7427 * textprop.c (Fprevious_property_change): New forward static decl.
7428 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7430 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7431 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7433 * editfns.c (Fformat): Remove unreachable code.
7435 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7437 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7440 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7442 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7443 when at ZV. (Bug#8487)
7445 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7447 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7449 * keyboard.c (parse_tool_bar_item): Likewise.
7450 * sound.c (sound_cleanup, alsa_close): Likewise.
7451 * termcap.c (tgetent): Likewise.
7452 * xfns.c (x_default_font_parameter): Likewise.
7453 * xsettings.c (read_and_apply_settings): Likewise.
7455 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7456 (overrun_check_free): Protoize.
7458 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7460 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7461 since callers should never pass a negative size.
7462 Change the signature to match that of plain 'read' and 'write'; see
7463 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7464 * lisp.h: Update prototypes of emacs_write and emacs_read.
7466 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7468 * xdisp.c (redisplay_window): Don't try to determine the character
7469 position of the scroll margin if the window start point w->startp
7470 is outside the buffer's accessible region. (Bug#8468)
7472 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7474 Fix write-region and its subroutines for buffers > 2GB.
7475 * fileio.c (a_write, e_write): Modify declaration of arguments and
7476 local variables to support buffers larger than 2GB.
7477 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7479 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7480 argument, local variables, and return value.
7482 * lisp.h: Update prototypes of emacs_write and emacs_read.
7484 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7486 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7488 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7490 Fix more problems found by GCC 4.6.0's static checks.
7492 * xdisp.c (vmessage): Use a better test for character truncation.
7494 * charset.c (load_charset_map): <, not <=, for optimization,
7495 and to avoid potential problems with integer overflow.
7496 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7497 * casetab.c (set_identity, shuffle): Likewise.
7498 * editfns.c (Fformat): Likewise.
7499 * syntax.c (skip_chars): Likewise.
7501 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7502 This also lets GCC 4.6.0 generate slightly better loop code.
7504 * callint.c (Fcall_interactively): <, not <=, for optimization.
7505 (Fcall_interactively): Count the number of arguments produced,
7506 not the number of arguments given. This is simpler and lets GCC
7507 4.6.0 generate slightly better code.
7509 * ftfont.c: Distingish more carefully between FcChar8 and char.
7510 The previous code passed unsigned char * to a functions like
7511 strlen and xstrcasecmp that expect char *, which does not
7512 conform to the C standard.
7513 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7514 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7515 char * when the C standard requires it.
7517 * keyboard.c (read_char): Remove unused var.
7519 * eval.c: Port to Windows vsnprintf (Bug#8435).
7521 (SIZE_MAX): Define if the headers do not.
7522 (verror): Do not give up if vsnprintf returns a negative count.
7523 Instead, grow the buffer. This ports to Windows vsnprintf, which
7524 does not conform to C99. Problem reported by Eli Zaretskii.
7525 Also, simplify the allocation scheme, by avoiding the need for
7526 calling realloc, and removing the ALLOCATED variable.
7528 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7530 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7531 But keep the doprint source code for now, as we might revamp it
7532 and use it again (Bug#8435).
7533 * lisp.h (doprnt): Remove.
7534 * Makefile.in (base_obj): Remove doprnt.o.
7535 * deps.mk (doprnt.o): Remove.
7537 error: Print 32- and 64-bit integers portably (Bug#8435).
7538 Without this change, on typical 64-bit hosts error ("...%d...", N)
7539 was used to print both 32- and 64-bit integers N, which relied on
7541 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7543 * lisp.h (error, verror): Mark as printf-like functions.
7544 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7545 Report overflow in size calculations when allocating printf buffer.
7546 Do not truncate output string at its first null byte.
7547 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7548 Truncate the output at a character boundary, since vsnprintf does not
7550 * charset.c (check_iso_charset_parameter): Convert internal
7551 character to string before calling 'error', since %c now has the
7553 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7554 overflow when computing char to be passed to 'error'. Do not
7555 pass Lisp_Object to 'error'; pass the integer instead.
7556 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7557 formatted with plain %d.
7559 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7561 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7563 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7565 * xterm.c (x_catch_errors): Remove duplicate declaration.
7567 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7569 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7571 2011-04-10 Jim Meyering <meyering@redhat.com>
7573 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7574 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7575 return ssize_t not "int", and use size_t as the buffer length.
7576 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7577 * gnutls.h: Update declarations.
7578 * process.c (read_process_output): Use ssize_t, to match.
7579 (send_process): Likewise.
7581 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7583 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7585 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7587 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7588 Use unsigned char, to match FcChar8 type definition.
7590 * xterm.c (handle_one_xevent):
7591 * xmenu.c (create_and_show_popup_menu):
7592 * xselect.c (x_decline_selection_request)
7593 (x_reply_selection_request): Avoid type-punned deref of X events.
7595 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7597 Fix some uses of `int' instead of EMACS_INT.
7598 * search.c (string_match_1, fast_string_match)
7599 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7600 (scan_buffer, find_next_newline_no_quit)
7601 (find_before_next_newline, search_command, Freplace_match)
7602 (Fmatch_data): Make some `int' variables be EMACS_INT.
7604 * xdisp.c (display_count_lines): 3rd argument and return value now
7605 EMACS_INT. All callers changed.
7606 (pint2hrstr): Last argument is now EMACS_INT.
7608 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7609 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7610 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7611 (decode_coding_utf_16, decode_coding_emacs_mule)
7612 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7613 (decode_coding_ccl, decode_coding_charset)
7614 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7615 (decode_coding_iso_2022, decode_coding_emacs_mule)
7616 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7617 <char_offset, last_offset>: Declare EMACS_INT.
7618 (encode_coding_utf_8, encode_coding_utf_16)
7619 (encode_coding_emacs_mule, encode_invocation_designation)
7620 (encode_designation_at_bol, encode_coding_iso_2022)
7621 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7622 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7624 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7625 (encode_invocation_designation): Last argument P_NCHARS is now
7627 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7628 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7630 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7633 * ccl.c (Fccl_execute_on_string): Declare some variables
7636 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7638 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7640 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7642 * process.c (Fformat_network_address): Doc fix.
7644 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7646 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7648 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7650 * keyboard.c (read_char): Call Lisp function help-form-show,
7651 instead of using internal_with_output_to_temp_buffer.
7652 (Qhelp_form_show): New var.
7653 (syms_of_keyboard): Use DEFSYM macro.
7655 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7657 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7659 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7661 * process.c (Flist_processes): Remove to Lisp.
7662 (list_processes_1): Delete.
7664 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7666 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7668 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7670 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7672 Fix more problems found by GCC 4.6.0's static checks.
7674 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7676 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7678 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7680 * xdisp.c (vmessage): Mark as a printf-like function.
7682 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7684 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7686 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7687 printf-like functions.
7688 (tiff_load): Add casts to remove these marks before passing them
7689 to system-supplied API.
7691 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7693 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7694 This avoids several warnings with gcc -Wstrict-overflow.
7695 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7696 directly, rather than having caller test rule sign. This avoids
7697 some unnecessary tests.
7698 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7699 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7700 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7702 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7703 (xfont_open): Avoid unnecessary tests.
7705 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7707 * composite.h, composite.c (composition_gstring_put_cache):
7708 Use EMACS_INT, not int, for length.
7710 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7711 breaking out part of COMPOSITION_DECODE_RULE.
7712 (COMPOSITION_DECODE_RULE): Use it.
7713 * composite.c (get_composition_id): Remove unused local vars,
7714 by using the new macro.
7716 * textprop.c (set_text_properties_1): Change while to do-while,
7717 since the condition is always true at first.
7719 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7720 (interval_deletion_adjustment): Return unsigned value.
7723 * process.c (list_processes_1, create_pty, read_process_output):
7724 (exec_sentinel): Remove vars that were set but not used.
7725 (create_pty): Remove unnecessary "volatile"s.
7726 (Fnetwork_interface_info): Avoid possibility of int overflow.
7727 (read_process_output): Do adaptive read buffering even if carryover.
7728 (read_process_output): Simplify nbytes computation if buffered.
7730 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7732 * syntax.c (scan_words): Remove var that was set but not used.
7733 (update_syntax_table): Use unsigned instead of int.
7735 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7736 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7737 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7739 * print.c (print_error_message): Avoid int overflow.
7741 * font.c (font_list_entities): Redo for clarity,
7742 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7744 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7745 (font_score): Avoid potential overflow in diff calculation.
7747 * fns.c (substring_both): Remove var that is set but not used.
7748 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7750 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7752 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7753 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7754 can always succeed if overflow has undefined behavior.
7756 * search.c (boyer_moore, wordify): Remove vars set but not used.
7757 (wordify): Omit three unnecessary tests.
7759 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7760 All callers changed. This avoids the need for an unused var.
7762 * casefiddle.c (casify_region): Remove var that is set but not used.
7764 * dired.c (file_name_completion): Remove var that is set but not used.
7766 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7768 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7769 (Finsert_file_contents): Remove unnecessary code checking fd.
7771 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7772 Check for integer overflow on size calculations.
7774 * buffer.c (Fprevious_overlay_change): Remove var that is set
7777 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7778 Remove vars that are set but not used.
7779 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7780 (timer_check_2): Mark vars as initialized.
7782 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7784 * image.c (lookup_image): Remove var that is set but not used.
7785 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7787 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7788 that are set but not used.
7790 * xfns.c (make_invisible_cursor): Don't return garbage
7791 if XCreateBitmapFromData fails (Bug#8410).
7793 * xselect.c (x_get_local_selection, x_handle_property_notify):
7794 Remove vars that are set but not used.
7796 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7797 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7799 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7800 Remove var that is set but not used.
7801 (scroll_bar_windows_size): Now size_t, not int.
7802 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7805 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7806 (map_tty_color) [!defined MSDOS]: Likewise.
7808 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7810 * coding.c: Remove vars that are set but not used.
7811 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7812 All callers changed.
7813 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7814 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7815 (decode_coding_charset): Remove vars that are set but not used.
7817 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7818 that is set but not used.
7820 * print.c (print_object): Remove var that is set but not used.
7822 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7823 The gnulib version avoids calling malloc in the usual case,
7824 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7825 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7826 * filelock.c (current_lock_owner): Likewise.
7827 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7828 * sysdep.c: Include allocator.h, careadlinkat.h.
7829 (emacs_no_realloc_allocator): New static constant.
7830 (emacs_readlink): New function.
7831 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7832 ../lib/careadlinkat.h.
7834 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7836 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7837 first non-nil return value).
7839 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7841 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7842 if not defined (Bug#8403).
7844 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7846 * xdisp.c (display_count_lines): Remove parameter `start',
7847 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7848 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7849 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7850 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7851 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7852 and thereabouts. All callers changed.
7853 (get_per_char_metric): Remove parameter `f', unused since
7854 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7856 2011-04-02 Jim Meyering <meyering@redhat.com>
7858 do not dereference NULL upon failed strdup
7859 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7860 (ns_get_family): Likewise.
7862 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7864 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7866 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7868 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7871 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7873 Add lexical binding.
7875 * window.c (Ftemp_output_buffer_show): New fun.
7876 (Fsave_window_excursion):
7877 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7879 * lread.c (lisp_file_lexically_bound_p): New function.
7880 (Fload): Bind Qlexical_binding.
7881 (readevalloop): Remove `evalfun' arg.
7882 Bind Qinternal_interpreter_environment.
7883 (Feval_buffer): Bind Qlexical_binding.
7884 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7886 (syms_of_lread): Declare `lexical-binding'.
7888 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7890 * keyboard.c (eval_dyn): New fun.
7891 (menu_item_eval_property): Use it.
7893 * image.c (parse_image_spec): Use Ffunctionp.
7895 * fns.c (concat, mapcar1): Accept byte-code-functions.
7897 * eval.c (Fsetq): Handle lexical vars.
7898 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7899 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7900 (FletX, Flet): Obey lexical binding.
7901 (Fcommandp): Handle closures.
7902 (Feval): New `lexical' arg.
7903 (eval_sub): New function extracted from Feval. Use it almost
7904 everywhere where Feval was used. Look up vars in lexical env.
7906 (Ffunctionp): Move from subr.el.
7907 (Ffuncall): Handle closures.
7908 (apply_lambda): Remove `eval_flags'.
7909 (funcall_lambda): Handle closures and new byte-code-functions.
7910 (Fspecial_variable_p): New function.
7911 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7912 but without exporting it to Lisp.
7914 * doc.c (Fdocumentation, store_function_docstring):
7915 * data.c (Finteractive_form): Handle closures.
7917 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7920 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7922 (exec_byte_code): New function extracted from Fbyte_code to handle new
7923 calling convention for byte-code-functions. Add new byte-codes.
7925 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7927 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7929 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7931 * xdisp.c (redisplay_internal): Fix prototype.
7933 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7935 * xdisp.c (SCROLL_LIMIT): New macro.
7936 (try_scrolling): Use it when setting scroll_limit.
7937 Limit scrolling to 100 screen lines.
7938 (redisplay_window): Even when falling back on "recentering",
7939 position point in the window according to scroll-conservatively,
7940 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7942 (try_scrolling): When point is above the window, allow searching
7943 as far as scroll_max, or one screenful, to compute vertical
7944 distance from PT to the scroll margin position. This prevents
7945 try_scrolling from unnecessarily failing when
7946 scroll-conservatively is set to a value slightly larger than the
7947 window height. Clean up the case of PT below the margin at bottom
7948 of window: scroll_max can no longer be INT_MAX. When aggressive
7949 scrolling is in use, don't let point enter the opposite scroll
7950 margin as result of the scroll.
7951 (syms_of_xdisp) <scroll-conservatively>: Document the
7952 threshold of 100 lines for never-recentering scrolling.
7954 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7956 * dispextern.h (move_it_by_lines):
7957 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7958 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7959 (message_log_check_duplicate): Remove parameters `prev_bol' and
7960 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7961 (redisplay_internal): Remove parameter `preserve_echo_area',
7962 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7964 * indent.c (Fvertical_motion):
7965 * window.c (window_scroll_pixel_based, Frecenter):
7966 Don't pass `need_y_p' to `move_it_by_lines'.
7968 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7970 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7971 steal a few bits to be more compact.
7972 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7973 Remove unneeded casts.
7975 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7977 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7979 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7980 binding" message (bug#7967).
7982 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7984 Fix more problems found by GCC 4.6.0's static checks.
7986 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7987 Remove unused local var.
7989 * editfns.c (Fmessage_box): Remove unused local var.
7991 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7992 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7993 Omit unused local vars.
7994 * window.c (shrink_windows): Omit unused local var.
7995 * menu.c (digest_single_submenu): Omit unused local var.
7996 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7997 Omit unused local var.
7999 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8000 Don't assume string length fits in int.
8001 (keyremap_step, read_key_sequence): Use size_t for sizes.
8002 (read_key_sequence): Don't check last_real_key_start redundantly.
8004 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8005 instead of alloca (Bug#8344).
8007 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8008 (Fbacktrace_frame): Don't assume nframes fits in int.
8010 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8012 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8015 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8017 * cm.c (calccost): Turn while-do into do-while, for clarity.
8019 * keyboard.c (syms_of_keyboard): Use the same style as later
8020 in this function when indexing through an array. This also
8021 works around GCC bug 48267.
8023 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8025 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8027 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8028 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8030 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8031 This avoids undefined behavior on integer overflow, and is a bit
8032 more convenient anyway since it is compared to a size_t variable.
8034 Variadic C functions now count arguments with size_t, not int.
8035 This avoids an unnecessary limitation on 64-bit machines, which
8036 caused (substring ...) to crash on large vectors (Bug#8344).
8037 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8038 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8039 All variadic functions and their callers changed accordingly.
8040 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8041 * data.c (arith_driver, float_arith_driver): Likewise.
8042 * editfns.c (general_insert_function): Likewise.
8043 * eval.c (struct backtrace.nargs, interactive_p)
8044 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8045 (funcall_lambda, mark_backtrace): Likewise.
8046 * fns.c (concat): Likewise.
8047 * frame.c (x_set_frame_parameters): Likewise.
8048 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8049 0 if not found, not -1. All callers changed.
8051 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8052 (stack_copy_size): Now size_t, not int.
8053 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8055 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8057 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8058 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8059 All callers changed.
8061 * lisp.h (multibyte_char_to_unibyte):
8062 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8063 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8064 * character.h (CHAR_TO_BYTE8):
8065 * cmds.c (internal_self_insert):
8066 * editfns.c (general_insert_function):
8067 * keymap.c (push_key_description):
8068 * search.c (Freplace_match):
8069 * xdisp.c (message_dolog, set_message_1): All callers changed.
8071 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8073 * keyboard.c (safe_run_hook_funcall): New function.
8074 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8075 don't set the hook to nil, but remove the offending function instead.
8076 (Qcommand_hook_internal): Remove, unused.
8077 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8078 Vcommand_hook_internal.
8080 * eval.c (enum run_hooks_condition): Remove.
8081 (funcall_nil, funcall_not): New functions.
8082 (run_hook_with_args): Call each function through a `funcall' argument.
8083 Remove `cond' argument, now redundant.
8084 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8085 (Frun_hook_with_args_until_failure): Adjust accordingly.
8086 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8088 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8090 * dispextern.h (string_buffer_position): Remove declaration.
8092 * print.c (strout): Remove parameter `multibyte', unused since
8093 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8095 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8096 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8097 All callers changed.
8099 * w32.c (_wsa_errlist): Use braces for struct initializers.
8101 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8102 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8103 All callers changed.
8104 (string_buffer_position): Likewise. Also, make static (it's never
8105 used outside xdisp.c).
8106 (cursor_row_p): Remove parameter `w', unused since
8107 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8108 (decode_mode_spec): Remove parameter `precision', introduced during
8109 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8110 All callers changed.
8112 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8114 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8116 2011-03-27 Anders Lindgren <andlind@gmail.com>
8118 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8119 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8120 (ns_update_auto_hide_menu_bar): New functions.
8121 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8122 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8123 ns_constrain_all_frames.
8124 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8125 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8127 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8129 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8131 2011-03-27 Glenn Morris <rgm@gnu.org>
8133 * syssignal.h: Replace RETSIGTYPE with void.
8134 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8135 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8136 Replace SIGTYPE with void everywhere.
8137 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8138 * s/template.h (SIGTYPE): Remove commented out definition.
8140 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8142 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8143 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8145 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8147 * w32.c (read_unc_volume): Use parameter `henum', instead of
8148 global variable `wget_enum_handle'.
8150 * keymap.c (describe_vector): Remove parameters `indices' and
8151 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8152 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8154 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8156 * keyboard.c (timer_check): Remove parameter `do_it_now',
8157 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8158 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8159 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8161 * keyboard.c (read_char):
8162 * w32menu.c (w32_menu_display_help):
8163 * xmenu.c (show_help_event, menu_help_callback):
8164 Adjust calls to `show_help_echo'.
8166 * gtkutil.c (xg_maybe_add_timer):
8167 * keyboard.c (readable_events):
8168 * process.c (wait_reading_process_output):
8169 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8171 * insdel.c (adjust_markers_gap_motion):
8172 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8173 (gap_left, gap_right): Don't call it.
8175 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8177 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8178 incurred during fontification.
8180 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8182 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8183 (DEFVAR_PER_BUFFER): Don't pass it.
8185 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8186 (scrolling_window): Don't pass it.
8188 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8190 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8192 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8194 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8195 of variables specific to SELinux and computation of `encoded_absname'.
8197 * image.c (XPutPixel): Remove unused variable `height'.
8199 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8201 * unexw32.c (get_section_info): Remove unused variable `section'.
8203 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8204 (system_process_attributes): Remove unused variable `sess'.
8205 (sys_read): Remove unused variable `err'.
8207 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8208 (w32_wnd_proc): Remove unused variable `isdead'.
8209 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8210 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8211 (x_create_tip_frame): Remove unused variable `tem'.
8213 * w32inevt.c (w32_console_read_socket):
8214 Remove unused variable `no_events'.
8216 * w32term.c (x_draw_composite_glyph_string_foreground):
8217 Remove unused variable `width'.
8219 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8221 * w32term.c (x_set_glyph_string_clipping):
8222 Don't pass uninitialized region to CombineRgn.
8224 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8226 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8227 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8228 (Fx_close_connection): Remove unused variable `i'.
8230 * w32font.c (w32font_draw): Return number of glyphs.
8231 (w32font_open_internal): Remove unused variable `i'.
8232 (w32font_driver): Add missing initializer.
8234 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8235 (fill_in_menu): Remove unused variable `items_added'.
8237 * w32term.c (last_mouse_press_frame): Remove static global variable.
8238 (w32_clip_to_row): Remove unused variable `f'.
8239 (x_delete_terminal): Remove unused variable `i'.
8241 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8242 (NOTHING): Remove unused static global variable.
8243 (uniscribe_check_otf): Remove unused variable `table'.
8244 (uniscribe_font_driver): Add missing initializers.
8246 2011-03-23 Julien Danjou <julien@danjou.info>
8248 * term.c (Fsuspend_tty, Fresume_tty):
8249 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8250 * window.c (temp_output_buffer_show):
8251 * insdel.c (signal_before_change):
8252 * frame.c (Fhandle_switch_frame):
8253 * fileio.c (Fdo_auto_save):
8254 * emacs.c (Fkill_emacs):
8255 * editfns.c (save_excursion_restore):
8256 * cmds.c (internal_self_insert):
8257 * callint.c (Fcall_interactively):
8258 * buffer.c (Fkill_all_local_variables):
8259 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8261 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8262 unconditionally since it does the check itself.
8264 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8266 Fix more problems found by GCC 4.5.2's static checks.
8268 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8269 the first time through the loop, since we know p0 < p1 then.
8270 This also avoids a gcc -Wstrict-overflow warning.
8272 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8273 leading to a memory leak, possible in functions like
8274 load_charset_map_from_file that can allocate an unbounded number
8275 of objects (Bug#8318).
8277 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8278 that could (at least in theory) be that large.
8280 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8281 This is less likely to overflow, and avoids undefined behavior if
8282 overflow does occur. All callers changed. Use strtoul to scan
8283 for the unsigned long integer.
8284 (pint2hrstr): Simplify and tune code slightly.
8285 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8287 * scroll.c (do_scrolling): Work around GCC bug 48228.
8288 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8290 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8291 This also avoids a warning with gcc -Wstrict-overflow.
8292 (validate_x_resource_name): Simplify count usage.
8293 This also avoids a warning with gcc -Wstrict-overflow.
8295 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8298 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8300 * process.c (Fmake_network_process): Use socklen_t, not int,
8301 where POSIX says socklen_t is required in portable programs.
8302 This fixes a porting bug on hosts like 64-bit HP-UX, where
8303 socklen_t is wider than int (Bug#8277).
8304 (Fmake_network_process, server_accept_connection):
8305 (wait_reading_process_output, read_process_output):
8308 * process.c: Rename or move locals to avoid shadowing.
8309 (list_processes_1, Fmake_network_process):
8310 (read_process_output_error_handler, exec_sentinel_error_handler):
8311 Rename or move locals.
8312 (Fmake_network_process): Define label "retry_connect" only if needed.
8313 (Fnetwork_interface_info): Fix pointer signedness.
8314 (process_send_signal): Add cast to avoid pointer signedness problem.
8315 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8316 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8318 Make tparam.h and terminfo.c consistent.
8319 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8320 Include tparam.h instead, since it declares them.
8321 * cm.h (PC): Remove extern decl; tparam.h now does this.
8322 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8323 * terminfo.c: Include tparam.h, to check interfaces.
8324 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8325 (tparam): Adjust signature to match interface in tparam.h;
8326 this removes some undefined behavior. Check that outstring and len
8327 are zero, which they always are with Emacs.
8328 * tparam.h (PC, BC, UP): New extern decls.
8330 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8331 (xftfont_open): Rename locals to avoid shadowing.
8333 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8334 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8335 (OTF_TAG_SYM): Omit macro if not needed.
8336 (ftfont_list): Remove unused local.
8337 (get_adstyle_property, ftfont_pattern_entity):
8338 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8339 Rename locals to avoid shadowing.
8341 * xfont.c (xfont_list_family): Mark var as initialized.
8343 * xml.c (make_dom): Now static.
8345 * composite.c (composition_compute_stop_pos): Rename local to
8347 (composition_reseat_it): Remove unused locals.
8348 (find_automatic_composition, composition_adjust_point): Likewise.
8349 (composition_update_it): Mark var as initialized.
8350 (find_automatic_composition): Mark vars as initialized,
8351 with a FIXME (Bug#8290).
8353 character.h: Rename locals to avoid shadowing.
8354 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8355 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8356 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8357 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8360 * textprop.c (property_change_between_p): Remove; unused.
8362 * intervals.c (interval_start_pos): Now static.
8364 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8366 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8367 Rename locals to avoid shadowing.
8369 * sound.c (wav_play, au_play, Fplay_sound_internal):
8370 Fix pointer signedness.
8371 (alsa_choose_format): Remove unused local var.
8372 (wav_play): Initialize a variable to 0, to prevent undefined
8373 behavior (Bug#8278).
8375 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8377 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8379 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8380 clobbering (Bug#8298).
8381 * sysdep.c (sys_subshell): Likewise.
8382 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8384 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8385 This should get cleaned up, so that child_setup has the
8386 same signature on all platforms.
8388 * callproc.c (call_process_cleanup): Now static.
8389 (relocate_fd): Rename locals to avoid shadowing.
8391 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8393 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8394 not to be necessary, and produces flickering.
8396 2011-03-20 Glenn Morris <rgm@gnu.org>
8398 * config.in: Remove file.
8400 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8402 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8403 are now in src/globals.h.
8404 (syms_of_minibuf): Remove spurious & from previous change.
8406 2011-03-20 Leo Liu <sdl.web@gmail.com>
8408 * minibuf.c (completing-read-function): New variable.
8409 (completing-read-default): Rename from completing-read.
8410 (completing-read): Call completing-read-function.
8412 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8414 * xfaces.c (Fx_load_color_file):
8415 Read color file from absolute filename (bug#8250).
8417 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8419 * makefile.w32-in: Update dependencies.
8421 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8423 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8425 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8427 Fix more problems found by GCC 4.5.2's static checks.
8429 * process.c (make_serial_process_unwind, send_process_trap):
8430 (sigchld_handler): Now static.
8432 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8433 That way, the code declares only the vars that it needs.
8434 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8435 * s/cygwin.h (PTY_ITERATION): Likewise.
8436 * s/darwin.h (PTY_ITERATION): Likewise.
8437 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8439 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8440 * process.c (allocate_pty): Don't declare stb unless it's needed.
8442 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8443 (CONSTANTLIM): Remove; unused.
8444 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8445 Define only if needed.
8447 * unexelf.c (unexec): Name an expression,
8448 to avoid gcc -Wbad-function-cast warning.
8449 Use a different way to cause a compilation error if anyone uses
8450 n rather than nn, a way that does not involve shadowing.
8451 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8453 * deps.mk (unexalpha.o): Remove; unused.
8455 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8456 * unexec.h: New file.
8457 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8458 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8460 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8461 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8462 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8463 Change as necessary to match prototype in unexec.h.
8465 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8467 (back_comment, skip_chars): Mark vars as initialized.
8469 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8470 Rename locals to avoid shadowing.
8472 * lread.c (read1): Rewrite so as not to use empty "else".
8473 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8475 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8477 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8478 warning when compiling print.c.
8480 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8481 instead of using an uninitialized var.
8482 (font_sort_entities): Mark var as initialized.
8484 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8486 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8487 pointers to constants.
8488 (font_parse_fcname): Remove unused vars.
8489 (font_delete_unmatched): Now static.
8490 (font_get_spec): Remove; unused.
8491 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8492 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8493 Rename or move locals to avoid shadowing.
8495 * fns.c (require_nesting_list, require_unwind): Now static.
8496 (Ffillarray): Rename locals to avoid shadowing.
8498 * floatfns.c (domain_error2): Define only if needed.
8499 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8501 * alloc.c (mark_backtrace): Move decl from here ...
8502 * lisp.h: ... to here, so that it can be checked.
8504 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8505 (Fdefvar): Rewrite so as not to use empty "else".
8506 (lisp_indirect_variable): Name an expression,
8507 to avoid gcc -Wbad-function-cast warning.
8508 (Fdefvar): Rename locals to avoid shadowing.
8510 * callint.c (quotify_arg, quotify_args): Now static.
8511 (Fcall_interactively): Rename locals to avoid shadowing.
8512 Use const pointer when appropriate.
8514 * lisp.h (get_system_name, get_operating_system_release):
8515 Move decls here, to check interfaces.
8516 * process.c (get_operating_system_release): Move decl to lisp.h.
8517 * xrdb.c (get_system_name): Likewise.
8518 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8519 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8520 some of which prompt warnings from gcc -Wbad-function-cast.
8521 (Fformat_time_string, Fencode_time, Finsert_char):
8522 (Ftranslate_region_internal, Fformat):
8523 Rename or remove local vars to avoid shadowing.
8524 (Ftranslate_region_internal): Mark var as initialized.
8526 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8529 * lisp.h (eassert): Check that the argument compiles, even if
8530 ENABLE_CHECKING is not defined.
8532 * data.c (Findirect_variable): Name an expression, to avoid
8533 gcc -Wbad-function-cast warning.
8534 (default_value, arithcompare, arith_driver, arith_error): Now static.
8535 (store_symval_forwarding): Rename local to avoid shadowing.
8536 (Fmake_variable_buffer_local, Fmake_local_variable):
8537 Mark variables as initialized.
8538 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8540 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8541 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8542 Rename locals to avoid shadowing.
8543 (mark_stack): Move local variables into the #ifdef region where
8545 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8546 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8548 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8549 (GC_STRING_CHARS): Remove; not used.
8550 (Fmemory_limit): Cast sbrk's returned value to char *.
8552 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8553 avoids undefined behavior in theory.
8555 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8557 Use functions, not macros, for up- and down-casing (Bug#8254).
8558 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8559 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8560 to use the following functions instead of these macros.
8561 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8562 EMACS_INT, since callers assume the returned value fits in int.
8563 (upcase1): Likewise, for UPCASE_TABLE.
8564 (uppercasep, lowercasep, upcase): New static inline functions.
8565 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8566 the race-condition problem in the old DOWNCASE.
8568 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8569 Rename locals to avoid shadowing.
8570 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8571 (regex_compile, re_search_2, re_match_2_internal):
8572 Remove unused local vars.
8573 (FREE_VAR): Rewrite so as not to use empty "else",
8574 which gcc can warn about.
8575 (regex_compile, re_match_2_internal): Mark locals as initialized.
8576 (RETALLOC_IF): Define only if needed.
8577 (WORDCHAR_P): Likewise. This one is never needed, but is used
8578 only in a comment talking about a compiler bug, so put inside
8579 the #if 0 of that comment.
8580 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8581 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8584 * search.c (boyer_moore): Rename locals to avoid shadowing.
8585 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8586 (PREV_CHAR_BOUNDARY): Likewise.
8588 * search.c (simple_search): Remove unused var.
8590 * dired.c (compile_pattern): Move decl from here ...
8591 * lisp.h: ... to here, so that it can be checked.
8592 (struct re_registers): New forward decl.
8594 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8596 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8598 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8599 Rename locals to avoid shadowing.
8600 (Fvertical_motion): Mark locals as initialized.
8602 * casefiddle.c (casify_object, casify_region): Now static.
8603 (casify_region): Mark local as initialized.
8605 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8607 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8608 New macros, so that the caller can use some names other than
8609 gcpro1, gcpro2, etc.
8610 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8612 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8613 argument, for consistency with GCPRO2_VAR, etc: it is now the
8614 prefix of the variable, not the variable itself. All uses
8616 * dired.c (directory_files_internal, file_name_completion):
8617 Rename locals to avoid shadowing.
8619 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8620 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8621 dired.c's scmp function, had undefined behavior.
8622 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8623 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8624 * buffer.h: ... to here, because these macros use current_buffer,
8625 and the new implementation with inline functions needs to have
8626 current_buffer in scope now, rather than later when the macros
8628 (downcase, upcase1): New static inline functions.
8629 (DOWNCASE, UPCASE1): Reimplement using these functions.
8630 This avoids undefined behavior in expressions like
8631 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8632 from race conditions in accessing the global variables
8633 case_temp1 and case_temp2.
8634 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8635 * lisp.h (case_temp1, case_temp2): Remove their decls.
8636 * character.h (ASCII_CHAR_P): Move from here ...
8637 * lisp.h: ... to here, so that the inline functions mentioned
8640 * dired.c (directory_files_internal_unwind): Now static.
8642 * fileio.c (file_name_as_directory, directory_file_name):
8643 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8645 (file_name_as_directory): Use const pointers when appropriate.
8646 (Fexpand_file_name): Likewise. In particular, newdir might
8647 point at constant storage, so make it a const pointer.
8648 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8649 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8651 (Fset_file_times, Finsert_file_contents, auto_save_error):
8652 Rename locals to avoid shadowing.
8654 * minibuf.c (choose_minibuf_frame_1): Now static.
8655 (Ftry_completion, Fall_completions): Rename or remove locals
8658 * marker.c (bytepos_to_charpos): Remove; unused.
8660 * lisp.h (verify_bytepos, count_markers): New decls,
8661 so that gcc does not warn that these functions aren't declared.
8663 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8664 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8665 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8666 (copy_text): Remove unused local var.
8668 * filelock.c (within_one_second): Now static.
8669 (lock_file_1): Rename local to avoid shadowing.
8671 * buffer.c (fix_overlays_before): Mark locals as initialized.
8672 (fix_start_end_in_overlays): Likewise. This function should be
8673 simplified by using pointers-to-pointers, but that's a different
8675 (switch_to_buffer_1): Now static.
8676 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8677 (report_overlay_modification): Rename locals to avoid shadowing.
8679 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8680 Fix pointer signedness issue.
8681 (sys_subshell): Mark local as volatile if checking for lint,
8682 to suppress a gcc -Wclobbered warning that does not seem to be right.
8683 (MAXPATHLEN): Define only if needed.
8685 * process.c (serial_open, serial_configure): Move decls from here ...
8686 * systty.h: ... to here, so that they can be checked.
8688 * fns.c (get_random, seed_random): Move extern decls from here ...
8689 * lisp.h: ... to here, so that they can be checked.
8691 * sysdep.c (reset_io): Now static.
8692 (wait_for_termination_signal): Remove; unused.
8694 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8695 (copy_keymap_item, append_key, push_text_char_description):
8697 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8698 (DENSE_TABLE_SIZE): Remove; unused.
8699 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8700 (describe_map_tree):
8701 Rename locals to avoid shadowing.
8703 * keyboard.c: Declare functions static if they are not used elsewhere.
8704 (echo_char, echo_dash, cmd_error, top_level_2):
8705 (poll_for_input, handle_async_input): Now static.
8706 (read_char, kbd_buffer_get_event, make_lispy_position):
8707 (make_lispy_event, make_lispy_movement, apply_modifiers):
8708 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8709 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8710 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8711 (read_key_sequence, read_char): Mark locals as initialized.
8712 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8714 * keyboard.h (make_ctrl_char): New decl.
8715 (mark_kboards): Move decl here ...
8716 * alloc.c (mark_kboards): ... from here.
8718 * lisp.h (force_auto_save_soon): New decl.
8720 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8721 (DEFINE_DUMMY_FUNCTION): New macro.
8722 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8724 (main): Add casts to avoid warnings
8725 if GCC considers string literals to be constants.
8727 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8729 * dbusbind.c: Pointer signedness fixes.
8730 (xd_signature, xd_append_arg, xd_initialize):
8731 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8732 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8733 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8734 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8736 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8737 if GCC considers string literals to be constants.
8738 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8740 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8742 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8743 (print_preprocess, print_object): New macro to fix last change.
8745 * print.c (print_preprocess): Don't forget font objects.
8747 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8749 * emacs.c (USAGE3): Doc fixes.
8751 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8753 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8756 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8758 * lisp.h (VWindow_system, Qfile_name_history):
8759 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8760 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8761 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8763 * w32select.c: Don't #include "keyboard.h".
8764 (run_protected): Add extern declaration for waiting_for_input.
8766 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8767 * w32console.c (detect_input_pending, read_input_pending)
8768 (encode_terminal_code):
8769 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8770 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8771 (w32_system_caret_y, Qfile_name_history):
8772 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8773 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8774 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8775 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8776 * w32proc.c (Qlocal, report_file_error):
8777 * w32term.c (Vwindow_system, updating_frame):
8778 * w32uniscribe.c (initialized, uniscribe_font_driver):
8779 Remove unneeded extern declarations.
8781 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8783 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8785 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8787 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8788 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8789 These macros can no longer be used for assignment.
8791 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8792 Assign struct members directly, instead of using BUF_BEGV etc.
8793 (record_buffer_markers, fetch_buffer_markers): New functions for
8794 recording and fetching special buffer markers.
8795 (set_buffer_internal_1, set_buffer_temp): Use them.
8797 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8799 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8801 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8802 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8804 * xdisp.c (hscroll_window_tree):
8805 (reconsider_clip_changes): Use PT instead of BUF_PT.
8807 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8809 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8810 $(EMACS_ROOT)/lib/intprops.h.
8812 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8814 Fix more problems found by GCC 4.5.2's static checks.
8816 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8817 to unsigned char * to avoid compiler diagnostic.
8818 (xg_free_frame_widgets): Make it clear that a local variable is
8819 needed only if USE_GTK_TOOLTIP.
8820 (gdk_window_get_screen): Make it clear that this macro is needed
8821 only if USE_GTK_TOOLTIP.
8822 (int_gtk_range_get_value): New function, which avoids a diagnostic
8823 from gcc -Wbad-function-cast.
8824 (xg_set_toolkit_scroll_bar_thumb): Use it.
8825 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8826 diagnostic from gcc -Wbad-function-cast.
8827 (get_utf8_string, xg_get_file_with_chooser):
8828 Rename locals to avoid shadowing.
8829 (create_dialog): Move locals to avoid shadowing.
8831 * xgselect.c (xg_select): Remove unused var.
8833 * image.c (four_corners_best): Mark locals as initialized.
8834 (gif_load): Initialize transparent_p to zero (Bug#8238).
8835 Mark another local as initialized.
8836 (my_png_error, my_error_exit): Mark with NO_RETURN.
8838 * image.c (clear_image_cache): Now static.
8839 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8840 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8841 (x_edge_detection): Remove unnecessary cast that
8842 gcc -Wbad-function-cast diagnoses.
8843 (gif_load): Fix pointer signedness.
8844 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8845 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8847 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8849 Improve quality of tests for time stamp overflow.
8850 For example, without this patch (encode-time 0 0 0 1 1
8851 1152921504606846976) returns the obviously-bogus value (-948597
8852 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8853 reports time overflow. See
8854 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8855 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8856 * editfns.c: Include limits.h and intprops.h.
8857 (TIME_T_MIN, TIME_T_MAX): New macros.
8858 (time_overflow): Move earlier, to before first use.
8859 (hi_time, lo_time): New functions, for an accurate test for
8861 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8862 (Fget_internal_run_time): Don't assume time_t fits in int.
8863 (make_time): Use list2 instead of Fcons twice.
8864 (Fdecode_time): More accurate test for out-of-range times.
8865 (check_tm_member): New function.
8866 (Fencode_time): Use it, to test for out-of-range times.
8867 (lisp_time_argument): Don't rely on undefined left-shift and
8868 right-shift behavior when checking for time stamp overflow.
8870 * editfns.c (time_overflow): New function, refactoring common code.
8871 (Fformat_time_string, Fdecode_time, Fencode_time):
8872 (Fcurrent_time_string): Use it.
8874 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8875 * dired.c (make_time): Move to ...
8876 * editfns.c (make_time): ... here.
8877 * systime.h: Note the move.
8879 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8881 * fringe.c (update_window_fringes): Remove unused variables.
8883 * unexmacosx.c (copy_data_segment): Also copy __got section.
8886 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8888 * termcap.c [MSDOS]: Include "msdos.h".
8889 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8890 Constify `char *' arguments and their references according to
8891 prototypes in tparam.h.
8893 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8895 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8896 Adapt all references accordingly.
8898 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8900 2011-03-11 Tom Tromey <tromey@redhat.com>
8902 * buffer.c (syms_of_buffer): Remove obsolete comment.
8904 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8906 * termhooks.h (encode_terminal_code): Declare prototype.
8908 * msdos.c (encode_terminal_code): Don't declare prototype.
8910 * term.c (encode_terminal_code): Now external again, used by
8911 w32console.c and msdos.c.
8913 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8914 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8916 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8918 Fix some minor problems found by GCC 4.5.2's static checks.
8920 * fringe.c (update_window_fringes): Mark locals as initialized
8922 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8924 * alloc.c (mark_fringe_data): Move decl from here ...
8925 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8926 to check its interface.
8927 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8929 * fontset.c (free_realized_fontset): Now static.
8930 (Fset_fontset_font): Rename local to avoid shadowing.
8931 (fontset_font): Mark local as initialized.
8932 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8934 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8936 * xselect.c (x_disown_buffer_selections): Remove; not used.
8937 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8938 (x_own_selection, Fx_disown_selection_internal): Rename locals
8940 (x_handle_dnd_message): Remove local to avoid shadowing.
8942 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8943 so that the caller can use some name other than gcpro1.
8944 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8945 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8946 (Fx_backspace_delete_keys_p):
8947 Use them to avoid shadowing, and rename vars to avoid shadowing.
8948 (x_decode_color, x_set_name, x_window): Now static.
8949 (Fx_create_frame): Add braces to silence GCC warning.
8950 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8951 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8952 Remove unused locals.
8953 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8954 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8955 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8958 * xterm.h (x_mouse_leave): New decl.
8960 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8961 Remove unused functions.
8962 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8963 (x_calc_absolute_position): Now static.
8964 (XTread_socket): Don't define label "out" unless it's used.
8965 Don't declare local "event" unless it's used.
8966 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8967 unless they are used.
8968 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8969 (x_fatal_error_signal): Remove; not used.
8970 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8971 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8972 (x_error_catcher, x_connection_closed, x_error_handler):
8973 (x_error_quitter, xembed_send_message, x_iconify_frame):
8974 (my_log_handler): Rename locals to avoid shadowing.
8975 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8976 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8978 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8979 Rename or move locals to avoid shadowing.
8980 (tty_defined_color, merge_face_heights): Now static.
8981 (free_realized_faces_for_fontset): Remove; not used.
8982 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8983 does not deduce is never used uninitialized.
8984 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8985 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8987 * terminal.c (store_terminal_param): Now static.
8989 * xmenu.c (menu_highlight_callback): Now static.
8990 (set_frame_menubar): Remove unused local.
8991 (xmenu_show): Rename parameter to avoid shadowing.
8992 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8993 since they might point to immutable storage.
8994 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8995 since it's unused otherwise.
8997 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8998 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8999 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9000 avoids a gcc -Wuninitialized diagnostic.
9001 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9002 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9003 does not deduce are never used uninitialized.
9005 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9007 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9008 * window.c (window_loop, size_window):
9009 (run_window_configuration_change_hook, enlarge_window): Likewise.
9011 * window.c (display_buffer): Now static.
9012 (size_window): Mark variables that gcc -Wuninitialized
9013 does not deduce are never used uninitialized.
9014 * window.h (check_all_windows): New decl, to forestall
9015 gcc -Wmissing-prototypes diagnostic.
9016 * dispextern.h (bidi_dump_cached_states): Likewise.
9018 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9020 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9022 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9023 and to avoid gcc -Wuninitialized warning.
9024 (load_charset_map): Mark variables that gcc -Wuninitialized
9025 does not deduce are never used uninitialized.
9026 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9028 * coding.c (coding_set_source, coding_set_destination):
9029 Use "else { /* comment */ }" rather than "else /* comment */;"
9030 for clarity, and to avoid gcc -Wempty-body warning.
9031 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9032 a block, when the outer 'i' will do.
9033 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9034 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9035 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9036 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9037 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9038 Rename locals to avoid shadowing.
9039 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9040 * coding.c (emacs_mule_char, encode_invocation_designation):
9041 Now static, since they're not used elsewhere.
9042 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9043 (decode_coding_object, encode_coding_object, detect_coding_system):
9044 (decode_coding_emacs_mule): Mark variables that gcc
9045 -Wuninitialized does not deduce are never used uninitialized.
9046 (detect_coding_iso_2022): Initialize a local variable that might
9047 be used uninitialized. Leave a FIXME because it's not clear that
9048 this initialization is needed. (Bug#8211)
9049 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9050 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9051 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9052 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9053 Remove unused macros.
9055 * category.c (hash_get_category_set): Remove unused local var.
9056 (copy_category_table): Now static, since it's not used elsewhere.
9057 * character.c (string_count_byte8): Likewise.
9059 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9060 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9062 * chartab.c (copy_sub_char_table): Now static, since it's not used
9064 (sub_char_table_ref_and_range, char_table_ref_and_range):
9065 Rename locals to avoid shadowing.
9066 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9068 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9069 (BIDI_BOB): Remove unused macro.
9071 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9072 deduce are never used uninitialized.
9073 * term.c (encode_terminal_code): Likewise.
9075 * term.c (encode_terminal_code): Now static. Remove unused local.
9077 * tparam.h: New file.
9078 * term.c, tparam.h: Include it.
9079 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9080 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9081 Move these decls to tparam.h, and make them agree with what
9082 is actually in tparam.c. The previous trick of using incompatible
9083 decls in different modules does not conform to the C standard.
9084 All callers of tparam changed to use tparam's actual API.
9085 * tparam.c (tparam1, tparam, tgoto):
9086 Use const pointers where appropriate.
9088 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9089 * cm.h (struct cm): Likewise.
9090 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9091 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9092 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9093 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9094 (turn_on_face, init_tty): Likewise.
9095 * termchar.h (struct tty_display_info): Likewise.
9097 * term.c (term_mouse_position): Rename local to avoid shadowing.
9099 * alloc.c (mark_ttys): Move decl from here ...
9100 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9102 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9104 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9106 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9108 * search.c (compile_pattern_1): Remove argument regp, unused since
9109 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9110 (compile_pattern): Don't pass it.
9112 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9114 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9115 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9117 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9119 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9121 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9122 gdk_window_get_screen, gdk_window_get_geometry,
9123 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9124 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9125 (xg_get_pixbuf_from_pixmap): New function.
9126 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9127 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9128 Call xg_get_pixbuf_from_pixmap instead of
9129 gdk_pixbuf_get_from_drawable.
9130 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9131 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9132 (xg_check_special_colors): Use GtkStyleContext and its functions
9134 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9135 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9136 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9137 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9138 Call gtk_widget_get_preferred_size.
9139 (xg_frame_resized): gdk_window_get_geometry only takes 5
9141 (xg_win_to_widget, xg_event_is_for_menubar):
9142 Call gdk_x11_window_lookup_for_display.
9143 (xg_set_widget_bg): New function.
9144 (delete_cb): New function.
9145 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9146 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9147 (xg_set_background_color): Call xg_set_widget_bg.
9148 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9149 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9150 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9151 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9153 (update_frame_tool_bar): Call gtk_widget_hide.
9154 (xg_initialize): Use GDK_KEY_g.
9156 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9158 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9160 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9161 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9162 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9164 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9166 * w32xfns.c (select_palette): Check success of RealizePalette against
9167 GDI_ERROR, not zero.
9169 See ChangeLog.11 for earlier changes.
9175 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9177 This file is part of GNU Emacs.
9179 GNU Emacs is free software: you can redistribute it and/or modify
9180 it under the terms of the GNU General Public License as published by
9181 the Free Software Foundation, either version 3 of the License, or
9182 (at your option) any later version.
9184 GNU Emacs is distributed in the hope that it will be useful,
9185 but WITHOUT ANY WARRANTY; without even the implied warranty of
9186 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9187 GNU General Public License for more details.
9189 You should have received a copy of the GNU General Public License
9190 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.