* src/lread.c (init_obarray): Declare Qt and Qnil as special.
[bpt/emacs.git] / src / ChangeLog
1 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * lread.c (init_obarray): Declare Qt and Qnil as special.
4
5 2012-05-14 Glenn Morris <rgm@gnu.org>
6
7 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
8 Put "libexec" before "bin", for the sake of init_callproc_1.
9
10 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
11
12 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
13
14 * unexaix.c: Port to more-recent AIX compilers.
15 (report_error, report_error_1, make_hdr, copy_sym)
16 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
17 Make arguments const char *, not char *, to avoid violations of C
18 standard and to fix some AIX warnings reported by Gilles Pion.
19
20 2012-05-14 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
23 already have overlays loaded.
24 (handle_single_display_spec): Before returning without displaying
25 fringe bitmap, synchronize the bidi iterator with the main display
26 iterator, by calling iterate_out_of_display_property.
27 (iterate_out_of_display_property): Detect buffer iteration by
28 testing that it->string is a Lisp string.
29 (get_next_display_element): When the current object is exhausted,
30 and there's something on it->stack, call set_iterator_to_next to
31 proceed with what's on the stack, instead of returning zero.
32 (set_iterator_to_next): If called at the end of a Lisp string,
33 proceed to consider_string_end without incrementing string
34 position. Don't increment display vector index past the end of
35 the display vector. (Bug#11417)
36 (pos_visible_p): Don't report a position visible when move_it_to
37 stopped at the last line of window, which happens to be scanned
38 backwards by the bidi iteration. (Bug#11464)
39
40 2012-05-14 Eli Zaretskii <eliz@gnu.org>
41
42 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
43 and right-margin display specs even if the spec is invalid or we
44 are on a TTY, and thus unable to display on the fringes. That's
45 because the text with the property will not be displayed anyway,
46 so we need to signal to the caller that this is a "replacing"
47 display spec. This fixes display when the spec is invalid or we
48 are on a TTY.
49
50 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
51
52 * unexaix.c (make_hdr): Fix typo in prototype.
53 This bug broke the build on AIX. Problem reported by Gilles Pion.
54
55 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
56
57 * keyboard.c (kbd_buffer_get_event): Read special events also in
58 batch mode. (Bug#11415)
59
60 2012-05-12 Glenn Morris <rgm@gnu.org>
61
62 * ns.mk: Update for ns_appbindir no longer having trailing "/".
63
64 2012-05-12 Eli Zaretskii <eliz@gnu.org>
65
66 * lisp.mk (lisp): Add newcomment.elc.
67
68 2012-05-12 Glenn Morris <rgm@gnu.org>
69
70 * Makefile.in (MKDIR_P): New, set by configure.
71 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
72
73 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
74
75 Remove unused function hourglass_started.
76 * dispextern.h (hourglass_started):
77 * w32fns.c (hourglass_started):
78 * xdisp.c (hourglass_started): Remove.
79
80 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
81
82 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
83 Update dependencies.
84
85 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
86
87 * xgselect.c (xg_select): Put maxfds+1 into a var.
88 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
89
90 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
91
92 2012-05-10 Dave Abrahams <dave@boostpro.com>
93
94 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
95 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
96
97 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
98
99 * dbusbind.c (xd_registered_buses): New internal Lisp object.
100 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
101 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
102 Initialize xd_registered_buses.
103
104 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
105
106 Untag more efficiently if USE_LSB_TAG.
107 This is based on a proposal by YAMAMOTO Mitsuharu in
108 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
109 For an admittedly artificial (nth 8000 longlist) benchmark on
110 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
111 Emacs's overall text size by 1%.
112 * lisp.h (XUNTAG): New macro.
113 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
114 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
115 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
116 * eval.c (Fautoload):
117 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
118 * frame.h (XFRAME): Use XUNTAG.
119
120 Port recent dbusbind.c changes to 32-bit --with-wide-int.
121 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
122 Remove unportable assumptions about print widths of types like
123 dbus_uint32_t.
124 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
125 intptr_t when converting between pointer and integer, to avoid GCC
126 warnings about wrong width.
127
128 2012-05-09 Eli Zaretskii <eliz@gnu.org>
129
130 * w32proc.c (new_child): Force Windows to reserve only 64KB of
131 stack for each reader_thread, instead of defaulting to 8MB
132 determined by the linker. This avoids failures in creating
133 subprocesses on Windows 7, see the discussion in this thread:
134 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
135
136 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
137
138 Fix up display of the *Minibuf-0* buffer in the mini window.
139 * keyboard.c (read_char): Don't clear the echo area if there's no
140 message to clear.
141 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
142 contents of *Minibuf-0*) if there's no message displayed in its stead.
143
144 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
145
146 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
147 batch mode.
148
149 2012-05-06 Chong Yidong <cyd@gnu.org>
150
151 * lisp.mk (lisp): Update.
152
153 2012-05-05 Jim Meyering <meyering@redhat.com>
154
155 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
156
157 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
158
159 * data.c (PUT_ERROR): New macro.
160 (syms_of_data): Use it. Add new error type `user-error'.
161 * undo.c (user_error): New function.
162 (Fprimitive_undo): Use it.
163 * print.c (print_error_message): Adjust print style for `user-error'.
164 * keyboard.c (user_error): New function.
165 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
166
167 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
168
169 Do not limit current-time-string to years 1000..9999.
170 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
171 (Fcurrent_time_string): Support any year that is supported by the
172 underlying localtime representation. Don't use asctime, as it
173 has undefined behavior for years outside the range -999..9999.
174
175 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
176
177 Fix race conditions involving setenv, gmtime, localtime, asctime.
178 Without this fix, interrupts could mess up code that uses these
179 nonreentrant functions, since setting TZ invalidates existing
180 tm_zone or tzname values, and since most of these functions return
181 pointers to static storage.
182 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
183 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
184 Grow the critical sections to include not just invoking
185 localtime/gmtime, but also accessing these functions' results
186 including their tm_zone values if any, and any related TZ setting.
187 (format_time_string): Last arg is now struct tm *, not struct tm **,
188 so that the struct tm is saved in the critical section.
189 All callers changed. Simplify allocation of initial buffer, partly
190 motivated by the fact that memory allocation needs to be outside
191 the critical section.
192
193 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
194
195 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
196 with RESET_INTERVAL.
197
198 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
199 Remove duplicated buffer name initialization.
200
201 2012-05-02 Jim Meyering <jim@meyering.net>
202
203 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
204
205 * xfns.c (x_window): Use xstrdup (Bug#11375).
206
207 2012-05-02 Eli Zaretskii <eliz@gnu.org>
208
209 * xdisp.c (pos_visible_p): If already at a newline from the
210 display string before the 'while' loop, don't walk back the glyphs
211 from it3.glyph_row. Solves assertion violation when the display
212 string begins with a newline (egg.el). (Bug#11367)
213
214 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
215
216 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
217 Move to simple.el.
218
219 2012-05-01 Glenn Morris <rgm@gnu.org>
220
221 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
222 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
223 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
224 All were removed before 23.1.
225
226 * dispnew.c: Remove HAVE_LIBNCURSES test;
227 it is always true on relevant platforms.
228
229 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
230 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
231
232 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
233
234 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
235
236 * .gdbinit (xpr): Remove checks for no longer existing misc types.
237 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
238 Remove.
239
240 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
241
242 Do not avoid creating empty evaporating overlays (Bug#9642).
243 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
244 That is, do not delete an evaporating overlay if it becomes
245 empty after its bounds are adjusted to fit within its buffer.
246 This fix caused other problems, and I'm reverting it until we get
247 to the bottom of them.
248
249 2012-04-27 Chong Yidong <cyd@gnu.org>
250
251 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
252
253 2012-04-27 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (pos_visible_p): If the window start position is beyond
256 ZV, start the display from buffer beginning. Prevents assertion
257 violation in init_iterator when the minibuffer window is scrolled
258 via the scroll bar.
259
260 * window.c (window_scroll_pixel_based): Likewise.
261
262 2012-04-27 Chong Yidong <cyd@gnu.org>
263
264 * keymap.c (where_is_internal): Doc fix (Bug#10872).
265
266 2012-04-27 Glenn Morris <rgm@gnu.org>
267
268 * fileio.c (Fcopy_file, Fset_file_selinux_context):
269 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
270
271 2012-04-27 Eli Zaretskii <eliz@gnu.org>
272
273 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
274 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
275
276 2012-04-26 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
279 display element, check also the underlying string or buffer
280 character. (Bug#11341)
281
282 * w32menu.c: Include w32heap.h.
283 (add_menu_item): If the call to AppendMenuW (via
284 unicode_append_menu) fails, disable Unicode menus only if we are
285 running on Windows 9X/Me.
286
287 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
288
289 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
290 (xgetint): Add missing shift for LSB tags.
291
292 2012-04-24 Martin Rudalics <rudalics@gmx.at>
293
294 * keyboard.c (read_char): Don't wipe echo area for select window
295 events: These might get delayed via `mouse-autoselect-window'
296 (Bug#11304).
297
298 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
299
300 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
301 manipulation of :loaded-from data.
302
303 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
304
305 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
306 now a cons (bug#11311).
307
308 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
309
310 Do not create empty overlays with the evaporate property (Bug#9642).
311 * buffer.c (Fmove_overlay): Delete an evaporating overlay
312 if it becomes empty after its bounds are adjusted to fit within
313 its buffer. Without this fix, in a nonempty buffer (let ((o
314 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
315 yields an empty overlay that has the evaporate property, which is
316 not supposed to happen.
317
318 Fix minor GTK3 problems found by static checking.
319 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
320 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
321 (struct _EmacsFixedClass, emacs_fixed_get_type):
322 Move decls here from emacsgtkfixed.h, since they needn't be public.
323 (emacs_fixed_get_type): Now static.
324 (emacs_fixed_class_init): Omit unused local.
325 (emacs_fixed_child_type): Remove; unused.
326 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
327 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
328 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
329 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
330 (EMACS_FIXED_GET_CLASS): Remove; unused.
331 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
332
333 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
334 Problem reported by Juanma Barranquero for Windows -Wunused-function.
335
336 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
337
338 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
339 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
340 (__malloc_size_t, __malloc_ptrdiff_t):
341 Remove. All uses removed, replaced by the definiens if needed,
342 since we can assume C89 or better now.
343 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
344 (protect_malloc_state, align, get_contiguous_space)
345 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
346 (malloc_atfork_handler_child, malloc_enable_thread)
347 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
348 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
349 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
350 (special_realloc, _realloc_internal_nolock, _realloc_internal)
351 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
352 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
353 Define using prototypes, not old style.
354 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
355 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
356 (align): Don't assume that signed integer overflow wraps around.
357 Omit unused local var.
358 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
359 (_free_internal_nolock, memalign, mallochook, reallochook):
360 Omit no-longer-needed casts.
361 (valloc): Use getpagesize, not __getpagesize.
362 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
363 (struct hdr): The 'magic' member is now size_t, not unsigned long.
364
365 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
366
367 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
368
369 Move functions from C to Lisp. Make non-blocking method calls
370 the default. Implement further D-Bus standard interfaces.
371
372 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
373 (QCdbus_request_name_allow_replacement)
374 (QCdbus_request_name_replace_existing)
375 (QCdbus_request_name_do_not_queue)
376 (QCdbus_request_name_reply_primary_owner)
377 (QCdbus_request_name_reply_in_queue)
378 (QCdbus_request_name_reply_exists)
379 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
380 (QCdbus_registered_serial, QCdbus_registered_method)
381 (QCdbus_registered_signal): New Lisp objects.
382 (XD_DEBUG_MESSAGE): Use sizeof.
383 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
384 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
385 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
386 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
387 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
388 (xd_signature, xd_append_arg): Allow float for integer types.
389 (xd_get_connection_references): New function.
390 (xd_get_connection_address): Rename from xd_initialize.
391 Return cached address.
392 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
393 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
394 level.
395 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
396 Return number of refcounts.
397 (Fdbus_get_unique_name): Make stronger parameter check.
398 (Fdbus_message_internal): New defun.
399 (Fdbus_call_method, Fdbus_call_method_asynchronously)
400 (Fdbus_method_return_internal, Fdbus_method_error_internal)
401 (Fdbus_send_signal, Fdbus_register_service)
402 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
403 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
404 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
405 (Vdbus_compiled_version, Vdbus_runtime_version)
406 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
407 (Vdbus_message_type_method_return, Vdbus_message_type_error)
408 (Vdbus_message_type_signal): New defvars.
409 (Vdbus_registered_buses, Vdbus_registered_objects_table):
410 Adapt docstring.
411
412 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
413
414 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
415 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
416 Do not assume ptrdiff_t is the same width as 'int'.
417
418 * alloc.c: Handle unusual debugging option combinations.
419 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
420 since the two debugging options are incompatible.
421 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
422 is defined.
423 (mem_init, mem_insert, mem_insert_fixup):
424 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
425 (NEED_MEM_INSERT): Remove; no longer needed.
426
427 2012-04-22 Leo Liu <sdl.web@gmail.com>
428
429 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
430
431 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
432
433 * sysdep.c [__FreeBSD__]: Minor cleanups.
434 (list_system_processes, system_process_attributes) [__FreeBSD__]:
435 Use Emacs indenting style more consistently. Avoid some casts.
436 Use 'double' consistently rather than mixing 'float' and 'double'.
437
438 2012-04-21 Eduard Wiebe <usenet@pusto.de>
439
440 * sysdep.c (list_system_processes, system_process_attributes):
441 Add implementation for FreeBSD (Bug#5243).
442
443 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
444
445 * lisp.mk (lisp): Update.
446
447 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
448
449 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
450 It is never used otherwise.
451
452 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * print.c (print_preprocess): Only check print_depth if print-circle
455 is nil.
456 (print_object): Check for cycles even when print-circle is nil and
457 print-gensym is t, but only check print_depth if print-circle is nil.
458
459 2012-04-20 Chong Yidong <cyd@gnu.org>
460
461 * process.c (wait_reading_process_output): If EIO occurs on a pty,
462 set the status to "failed" and ensure that sentinel is run.
463
464 2012-04-20 Glenn Morris <rgm@gnu.org>
465
466 * process.c (Fset_process_inherit_coding_system_flag)
467 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
468 (Fmake_network_process, Fmake_serial_process): Doc fix.
469
470 2012-04-20 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (string_buffer_position_lim): Limit starting position to
473 BEGV.
474 (set_cursor_from_row): If called for a mode-line or header-line
475 row, return zero immediately.
476 (try_cursor_movement): If inside continuation line, don't back up
477 farther than the first row after the header line, if any.
478 Don't consider the header-line row as "partially visible", even if
479 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
480
481 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
482
483 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
484 (bug#11238).
485
486 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
487 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
488
489 configure: new option --enable-gcc-warnings (Bug#11207)
490 * Makefile.in (C_WARNINGS_SWITCH): Remove.
491 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
492 (ALL_CFLAGS): Use new macros rather than old.
493 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
494 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
495 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
496 -Wunused-result, -Wunused-variable. This should go away once
497 the Emacs and Gnulib regex code is merged.
498 (xmalloc, xrealloc): Now static.
499
500 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
501
502 * dired.c (Fsystem_groups): Remove unused local.
503
504 2012-04-17 Glenn Morris <rgm@gnu.org>
505
506 * dired.c (Fsystem_users): Doc fix.
507
508 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
509
510 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
511 (syms_of_dired): Add them.
512
513 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
514
515 Fix minor alloc.c problems found by static checking.
516 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
517 New extern decls, to avoid calling undeclared functions.
518 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
519 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
520 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
521 (NEED_MEM_INSERT): New macro.
522 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
523 Remove one incorrect comment and fix another.
524
525 Fix minor ralloc.c problems found by static checking.
526 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
527 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
528 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
529 (r_alloc_sbrk): Now static.
530
531 Improve ralloc.c interface checking.
532 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
533 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
534 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
535 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
536 [REL_ALLOC]: ... to here, to check interface.
537 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
538 Remove decls. This fixes an "It stinks!".
539
540 * alloc.c (which_symbols): Fix alignment issue / type clash.
541
542 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
543
544 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
545 (struct Lisp_Misc_Any): Likewise.
546 (struct Lisp_Free): Likewise.
547 * alloc.c (union aligned_Lisp_Symbol): Define.
548 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
549 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
550 (union aligned_Lisp_Misc): Define.
551 (MARKER_BLOCK_SIZE, struct marker_block): Use union
552 aligned_Lisp_Misc instead of union Lisp_Misc.
553 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
554
555 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
556
557 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
558 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
559 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
560 * s/netbsd.h, s/sol2-6.h:
561 Remove definition of GC_MARK_STACK, since the default now works.
562 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
563 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
564 no longer the default.
565 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
566
567 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
568
569 * lread.c (lisp_file_lexically_bound_p):
570 Fix hang at ";-*-\n" (bug#11238).
571
572 2012-04-14 Eli Zaretskii <eliz@gnu.org>
573
574 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
575 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
576
577 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
578
579 * nsterm.m (constrainFrameRect): Always constrain when there is only
580 one screen (Bug#10962).
581
582 2012-04-13 Ken Brown <kbrown@cornell.edu>
583
584 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
585
586 2012-04-13 Reuben Thomas <rrt@sc3d.org>
587
588 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
589
590 2012-04-11 Daniel Colascione <dancol@dancol.org>
591
592 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
593 against is gone. It's better to use vfork now so that when Cygwin
594 gains a new, working vfork, we use it automatically (bug#10398).
595
596 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
597
598 * window.c (save_window_save): Obey window-point-insertion-type.
599
600 2012-04-11 Glenn Morris <rgm@gnu.org>
601
602 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
603
604 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
605
606 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
607
608 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
609
610 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
611 (force_quit_count): New var.
612 (handle_interrupt): Use it.
613
614 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
615
616 * w32.c (w32_delayed_load): Record the full path of the library
617 being loaded (bug#10424).
618
619 2012-04-09 Glenn Morris <rgm@gnu.org>
620
621 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
622 not just in the obarray, before snarfing them. (Bug#11036)
623
624 * Makefile.in ($(leimdir)/leim-list.el):
625 Pass EMACS rather than BUILT_EMACS.
626
627 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
628
629 * process.c (make_process):
630 * process.h: Add integer `gnutls_handshakes_tried' member to
631 process struct.
632
633 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
634 Add convenience `GNUTLS_LOG2i' macro.
635
636 * gnutls.c (gnutls_log_function2i): Convenience log function.
637 (emacs_gnutls_read): Use new log functions,
638 `gnutls_handshakes_tried' process member, and
639 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
640 attempts per process (connection).
641
642 2012-04-09 Chong Yidong <cyd@gnu.org>
643
644 * eval.c (Fuser_variable_p, user_variable_p_eh)
645 (lisp_indirect_variable): Functions deleted.
646 (Fdefvar): Caller changed.
647
648 * callint.c (Finteractive, Fcall_interactively):
649 * minibuf.c (Fread_variable): Callers changed.
650
651 2012-04-09 Eli Zaretskii <eliz@gnu.org>
652
653 * xdisp.c (set_cursor_from_row): If the display string appears in
654 the buffer at position that is closer to point than the position
655 after the display string, display the cursor on the first glyph of
656 the display string. Fixes cursor display when a 'display' text
657 property immediately follows invisible text. (Bug#11094)
658
659 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
660
661 composite.c: use 'double' consistently
662 * composite.c (get_composition_id): Use 'double' consistently
663 instead of converting 'float' to 'double' and vice versa; this is
664 easier to understand and avoids a GCC warning.
665
666 2012-04-09 Glenn Morris <rgm@gnu.org>
667
668 * Makefile.in: Generate leim-list with bootstrap-emacs, in
669 preparation for dumping it with emacs. (Bug#4789)
670 (leimdir): New variable.
671 ($(leimdir)/leim-list.el): New rule.
672 (emacs$(EXEEXT)): Depend on leim-list.el.
673
674 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
675 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
676 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
677
678 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
679
680 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
681 proper alignment.
682
683 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
684
685 * xml.c (init_libxml2_functions) [WINDOWSNT]:
686 Remove unused local variable.
687
688 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
689
690 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
691 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
692 (mark_memory): Mark Lisp_Objects only if pointers might hide in
693 objects, as mark_maybe_pointer will catch them otherwise.
694 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
695 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
696
697 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
698
699 Fix typo that broke non-Windows builds.
700 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
701
702 2012-04-07 Eli Zaretskii <eliz@gnu.org>
703
704 Support building on MS-Windows with libxml2.
705
706 * makefile.w32-in (OBJ2): Add xml.$(O).
707 (GLOBAL_SOURCES): Add xml.c.
708 ($(BLD)/xml.$(O)): New dependency list.
709
710 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
711 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
712 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
713 [!WINDOWSNT]: New macros.
714 (init_libxml2_functions, libxml2_loaded_p): New functions.
715 (parse_region): Call fn_xmlCheckVersion instead of using the macro
716 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
717 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
718 Calls xmlCleanupParser only if libxml2 was loaded (or statically
719 linked in).
720 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
721 Call init_libxml2_functions before calling libxml2 functions.
722 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
723
724 * emacs.c: Don't include libxml/parser.h.
725 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
726 xmlCleanupParser directly.
727
728 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
729
730 2012-04-07 Eli Zaretskii <eliz@gnu.org>
731
732 * indent.c (Fvertical_motion): If there is a display string at
733 point, use it.vpos to compute how many lines to backtrack after
734 move_it_to point. (Bug#11133)
735
736 2012-04-06 Eli Zaretskii <eliz@gnu.org>
737
738 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
739 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
740 about subtle differences between FETCH_CHAR* and STRING_CHAR*
741 macros related to unification of CJK characters. For the details,
742 see the discussion following the message here:
743 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
744
745 2012-04-04 Chong Yidong <cyd@gnu.org>
746
747 * keyboard.c (Vdelayed_warnings_list): Doc fix.
748
749 2012-04-01 Eli Zaretskii <eliz@gnu.org>
750
751 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
752 instead of alloca. (Bug#11138)
753
754 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
755
756 * w32menu.c (is_simple_dialog): Properly check lisp types.
757 (Bug#11141)
758
759 2012-03-31 Eli Zaretskii <eliz@gnu.org>
760
761 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
762 position we get to after a call to move_it_to fails the
763 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
764 only if we wind up in a string from display property. (Bug#11063)
765
766 * window.c (Fdelete_other_windows_internal): Invalidate the row
767 and column information about mouse highlight, so that redisplay
768 restores it after reallocating the glyph matrices. (Bug#7464)
769
770 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
771 string comes from a `display' text property, use the buffer
772 position of that property as if we actually saw that position in
773 the row's glyphs.
774 (move_it_by_lines): Remove the assertion that
775 "it->current_x == 0 && it->hpos == 0" which can be legitimately
776 violated when there's a before-string at the beginning of a line.
777 (Bug#11063)
778
779 2012-03-30 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (append_space_for_newline): If the default face was
782 remapped, use the remapped face for the appended newline.
783 (extend_face_to_end_of_line): Use the remapped default face for
784 extending the face to the end of the line.
785 (display_line): Call extend_face_to_end_of_line when the default
786 face was remapped. (Bug#11068)
787
788 2012-03-29 Eli Zaretskii <eliz@gnu.org>
789
790 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
791
792 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
793
794 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
795
796 2012-03-27 Glenn Morris <rgm@gnu.org>
797
798 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
799 Doc fixes.
800
801 2012-03-26 Kenichi Handa <handa@m17n.org>
802
803 * dispextern.h (struct glyph): Fix previous change. Change the
804 bit length of glyphless.ch to 25 (Bug#11082).
805
806 2012-03-26 Chong Yidong <cyd@gnu.org>
807
808 * keyboard.c (Vselection_inhibit_update_commands): New variable.
809 (command_loop_1): Use it; inhibit selection update for
810 handle-select-window too (Bug#8996).
811
812 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
813
814 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
815
816 2012-03-25 Kenichi Handa <handa@m17n.org>
817
818 * dispextern.h (struct glyph): Change the bit length of
819 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
820
821 2012-03-24 Eli Zaretskii <eliz@gnu.org>
822
823 * s/ms-w32.h (tzname): Include time.h before redirecting to
824 _tzname. Fixes the MSVC build. (Bug#9960)
825
826 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
827
828 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
829 characters.
830
831 * xterm.c (XTread_socket): Only modify handling_signal if
832 !SYNC_INPUT. (Bug#11080)
833
834 2012-03-23 Eli Zaretskii <eliz@gnu.org>
835
836 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
837 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
838 when fetching a multibyte character consumes more bytes than
839 CHAR_BYTES returns, due to unification of CJK characters in
840 string_char. (Bug#11073)
841
842 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
843
844 * process.c (wait_reading_process_output): Handle pty disconnect
845 by refraining from sending oneself a SIGCHLD (bug#10933).
846
847 2012-03-22 Chong Yidong <cyd@gnu.org>
848
849 * dispextern.h (struct it): New member string_from_prefix_prop_p.
850
851 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
852 Mark string as coming from a prefix property.
853 (handle_face_prop): Use default face for prefix strings (Bug#4281).
854 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
855
856 2012-03-21 Chong Yidong <cyd@gnu.org>
857
858 * xfaces.c (Vface_remapping_alist): Doc fix.
859
860 2012-03-20 Eli Zaretskii <eliz@gnu.org>
861
862 * w32proc.c (Fw32_set_console_codepage)
863 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
864 Doc fixes.
865
866 2012-03-20 Chong Yidong <cyd@gnu.org>
867
868 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
869 to reflect default non-nil value of redisplay-dont-pause.
870
871 2012-03-19 Kenichi Handa <handa@m17n.org>
872
873 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
874 it fit in a valid range (Bug#11003).
875
876 2012-03-18 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
879 that is not from display property, accept the row as a "cursor
880 row" if one of the string's character has a non-nil `cursor'
881 property. Fixes cursor positioning when there are newlines in
882 overlay strings, e.g. in icomplete.el. (Bug#11035)
883
884 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
885
886 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
887
888 2012-03-12 Chong Yidong <cyd@gnu.org>
889
890 * eval.c (inhibit_lisp_code): Rename from
891 inhibit_window_configuration_change_hook; move from window.c.
892
893 * xfns.c (unwind_create_frame_1, Fx_create_frame):
894 * window.c (run_window_configuration_change_hook)
895 (syms_of_window): Callers changed.
896
897 2012-03-11 Chong Yidong <cyd@gnu.org>
898
899 * keymap.c (Fkey_description): Doc fix (Bug#9700).
900
901 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
902
903 2012-03-10 Chong Yidong <cyd@gnu.org>
904
905 * frame.c (other_visible_frames): Don't assume the selected frame
906 is visible (Bug#10955).
907
908 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
909
910 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
911
912 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
913
914 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
915 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
916 zero (Bug#10954).
917
918 2012-03-03 Glenn Morris <rgm@gnu.org>
919
920 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
921
922 2012-03-02 Eli Zaretskii <eliz@gnu.org>
923
924 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
925 position past the first glyph_row that ends at ZV. (Bug#10902)
926 (redisplay_window, next_element_from_string): Fix typos in
927 comments.
928 (redisplay_window): Pass to move_it_vertically the margin in
929 pixels, not in screen lines.
930
931 2012-03-02 Glenn Morris <rgm@gnu.org>
932
933 * buffer.c (buffer-list-update-hook): Doc fix.
934
935 2012-02-29 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
938 push_it before setting up the iterator for the first overlay
939 string, even if we have an empty string loaded.
940 (next_overlay_string): If there's an empty string on the iterator
941 stack, pop the stack. (Bug#10903)
942
943 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
944
945 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
946 Suggested by Stefan Monnier in
947 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
948 * alloc.c (widen_to_Lisp_Object): New static function.
949 (mark_memory): Also mark Lisp_Objects by fetching pointer words
950 and widening them to Lisp_Objects. This would work even if
951 USE_LSB_TAG is defined and wide integers are used, which might
952 happen in a future version of Emacs.
953
954 2012-02-25 Chong Yidong <cyd@gnu.org>
955
956 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
957 Doc fix.
958
959 * xselect.c (Fx_selection_exists_p): Doc fix.
960 (x_clipboard_manager_save_all): Print an informative message
961 before saving to clipboard manager.
962
963 2012-02-24 Chong Yidong <cyd@gnu.org>
964
965 * keyboard.c (process_special_events): Handle all X selection
966 requests in kbd_buffer, not just the next one (Bug#8869).
967
968 2012-02-23 Chong Yidong <cyd@gnu.org>
969
970 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
971 call when setting menu-bar-lines and tool-bar-lines parameters.
972 (unwind_create_frame_1): New helper function.
973
974 * window.c (inhibit_window_configuration_change_hook): New var.
975 (run_window_configuration_change_hook): Obey it.
976 (syms_of_window): Initialize it.
977
978 2012-02-22 Chong Yidong <cyd@gnu.org>
979
980 * xterm.c (x_draw_image_relief): Add missing type check for
981 Vtool_bar_button_margin (Bug#10743).
982
983 2012-02-21 Chong Yidong <cyd@gnu.org>
984
985 * fileio.c (Vfile_name_handler_alist): Doc fix.
986
987 * buffer.c (Fget_file_buffer): Protect against invalid file
988 handler return value.
989
990 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
991
992 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
993 when computing $valmask.
994
995 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
996 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
997 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
998 It's useless in that case, and it can cause problems on hosts
999 that allocate halves of EMACS_INT values separately.
1000 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1001 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1002 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1003 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1004 it avoids undefined behavior on hosts where shifting right by more
1005 than the word width has undefined behavior.
1006
1007 2012-02-19 Chong Yidong <cyd@gnu.org>
1008
1009 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1010 (Funhandled_file_name_directory, Ffile_name_as_directory)
1011 (Fdirectory_file_name, Fexpand_file_name)
1012 (Fsubstitute_in_file_name): Protect against invalid file handler
1013 return values (Bug#10845).
1014
1015 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1016
1017 * .gdbinit (pitx): Fix incorrect references to fields of the
1018 iterator stack.
1019
1020 2012-02-17 Chong Yidong <cyd@gnu.org>
1021
1022 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1023
1024 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1027 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1028
1029 2012-02-15 Chong Yidong <cyd@gnu.org>
1030
1031 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1032 marked as special. Also, starting docstrings with * is obsolete.
1033
1034 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1035
1036 * gnutls.c (emacs_gnutls_write): Fix last change.
1037
1038 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1039
1040 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1041 send_process.
1042
1043 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1044
1045 * keymap.c (Fsingle_key_description): Handle char ranges.
1046
1047 2012-02-12 Chong Yidong <cyd@gnu.org>
1048
1049 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1050 as that creates a dangerous corner case.
1051
1052 * window.c (Fdelete_window_internal): Invalidate the mouse
1053 highlight (Bug#9904).
1054
1055 2012-02-12 Glenn Morris <rgm@gnu.org>
1056
1057 * xselect.c (Fx_own_selection_internal)
1058 (Fx_get_selection_internal, Fx_disown_selection_internal)
1059 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1060 * nsselect.m (Fx_own_selection_internal)
1061 (Fx_disown_selection_internal, Fx_selection_exists_p)
1062 (Fx_selection_owner_p, Fx_get_selection_internal):
1063 Sync docs and argument specs with the xselect.c versions.
1064
1065 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1066
1067 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1068
1069 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1070
1071 * w32select.c (Fx_selection_exists_p): Sync doc string and
1072 argument list with xselect.c. (Bug#10783)
1073
1074 * w16select.c (Fx_selection_exists_p): Sync doc string and
1075 argument list with xselect.c. (Bug#10783)
1076
1077 2012-02-10 Glenn Morris <rgm@gnu.org>
1078
1079 * fns.c (Fsecure_hash): Doc fix.
1080
1081 2012-02-09 Kenichi Handa <handa@m17n.org>
1082
1083 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1084
1085 2012-02-07 Chong Yidong <cyd@gnu.org>
1086
1087 * buffer.c (Fbuffer_local_variables)
1088 (buffer_lisp_local_variables): Handle unbound vars correctly;
1089 don't let Qunbound leak into Lisp.
1090
1091 2012-02-07 Glenn Morris <rgm@gnu.org>
1092
1093 * image.c (Fimagemagick_types): Doc fix.
1094
1095 * image.c (imagemagick-render-type): Change it from a lisp object
1096 to an integer. Move the doc here from the lisp manual.
1097 Treat all values not equal to 0 the same.
1098
1099 2012-02-06 Chong Yidong <cyd@gnu.org>
1100
1101 * doc.c (store_function_docstring): Avoid applying docstring of
1102 alias to base function (Bug#2603).
1103
1104 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1105
1106 * .gdbinit (pp1, pv1): Remove redundant defines.
1107 (pr): Use pp.
1108
1109 2012-02-04 Chong Yidong <cyd@gnu.org>
1110
1111 * nsterm.m: Declare a global (Bug#10694).
1112
1113 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1114
1115 * w32.c (get_emacs_configuration_options):
1116 Include --enable-checking, if specified, in the return value.
1117
1118 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1119
1120 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1121 after rounding frame sizes. (Bug#9723)
1122
1123 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1124
1125 * keyboard.c (adjust_point_for_property): Don't position point
1126 before BEGV. (Bug#10696)
1127
1128 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 Handle overflow when computing char display width (Bug#9496).
1131 * character.c (char_width): Return EMACS_INT, not int.
1132 (char_width, c_string_width): Check for overflow when
1133 computing the width; this is possible now that individual
1134 characters can have unbounded width. Problem introduced
1135 by merge from Emacs 23 on 2012-01-19.
1136
1137 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1138
1139 * dbusbind.c (Fdbus_register_method): Mention the return value
1140 :ignore in the docstring.
1141
1142 2012-02-02 Glenn Morris <rgm@gnu.org>
1143
1144 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1145
1146 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1147 Unconditionally set to t. (Bug#10673)
1148 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1149 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1150 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1151
1152 2012-02-02 Kenichi Handa <handa@m17n.org>
1153
1154 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1155 0, do not call append_composite_glyph.
1156
1157 2012-02-02 Kenichi Handa <handa@m17n.org>
1158
1159 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1160 NULL (Bug#6988).
1161 (x_produce_glyphs): If the component of a composition is a null
1162 string, set it->pixel_width to 1 to avoid zero-width glyph.
1163
1164 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1165
1166 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1167 first 2 arguments are identical. This makes inserting large
1168 output from a subprocess an order of magnitude faster on
1169 MS-Windows, where all sbrk'ed memory is always contiguous.
1170
1171 2012-01-31 Glenn Morris <rgm@gnu.org>
1172
1173 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1174 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1175 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1176
1177 2012-01-29 Glenn Morris <rgm@gnu.org>
1178
1179 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1180
1181 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1182
1183 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1184
1185 2012-01-28 Chong Yidong <cyd@gnu.org>
1186
1187 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1188
1189 2012-01-26 Chong Yidong <cyd@gnu.org>
1190
1191 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1192
1193 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1194 repeat counts (Bug#10507).
1195
1196 2012-01-26 Glenn Morris <rgm@gnu.org>
1197
1198 * lread.c (syms_of_lread): Doc fix.
1199
1200 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1201
1202 * coding.c (encode_designation_at_bol): Change return value to
1203 EMACS_INT.
1204
1205 2012-01-25 Chong Yidong <cyd@gnu.org>
1206
1207 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1208
1209 2012-01-21 Chong Yidong <cyd@gnu.org>
1210
1211 * floatfns.c (Fcopysign): Make the second argument non-optional,
1212 since nil is not allowed anyway.
1213
1214 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1215
1216 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1217 (send_process): Likewise.
1218
1219 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1220
1221 * window.c (save_window_save, Fcurrent_window_configuration)
1222 (Vwindow_persistent_parameters): Do not use Qstate.
1223 Rewrite doc-strings.
1224
1225 2012-01-19 Kenichi Handa <handa@m17n.org>
1226
1227 * character.c (char_width): New function.
1228 (Fchar_width, c_string_width, lisp_string_width):
1229 Use char_width (Bug#9496).
1230
1231 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1232
1233 * window.c (Vwindow_persistent_parameters): New variable.
1234 (Fset_window_configuration, save_window_save): Handle persistent
1235 window parameters.
1236
1237 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1238
1239 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1240 thrashing the stack of the thread. (Bug#9087)
1241
1242 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1245
1246 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (rows_from_pos_range): Handle the case where the
1249 highlight ends on a newline. (Bug#10464)
1250 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1251 he end column for display of highlight that ends on a newline
1252 before a R2L line.
1253
1254 2012-01-11 Glenn Morris <rgm@gnu.org>
1255
1256 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1257 from load-path also when installation-directory is nil. (Bug#10208)
1258
1259 2012-01-10 Glenn Morris <rgm@gnu.org>
1260
1261 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1262
1263 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1264 Update template values to be closer to their typical values these days.
1265
1266 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (rows_from_pos_range): Accept additional argument
1269 DISP_STRING, and accept any glyph in a row whose object is that
1270 string as eligible for mouse highlight. Fixes mouse highlight of
1271 display strings from overlays. (Bug#10464)
1272
1273 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 emacs: fix an auto-save permissions race condition (Bug#10400)
1276 * fileio.c (auto_saving_dir_umask): New static var.
1277 (Fmake_directory_internal): Use it.
1278 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1279 creating the directory. The old code temporarily assigns
1280 too-generous permissions to the directory.
1281 (do_auto_save_eh): Clear it.
1282 (Fdo_auto_save): Catch all errors, not just file errors, so
1283 that the var is always cleared.
1284
1285 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1286
1287 * search.c (scan_buffer): Pass character positions to
1288 know_region_cache, not byte positions. (Bug#6540)
1289
1290 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1291
1292 * w32.c (sys_rename): Report EXDEV when rename of a directory
1293 fails because the target is on another logical disk. (Bug#10284)
1294
1295 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1296
1297 * xterm.c (x_embed_request_focus): New function.
1298
1299 * xterm.h: Add prototype.
1300
1301 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1302
1303 2012-01-05 Glenn Morris <rgm@gnu.org>
1304
1305 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1306
1307 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1308
1309 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1310 Load gnutls_transport_set_lowat only if GnuTLS version is below
1311 2.11.1.
1312 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1313 GnuTLS versions below 2.11.1.
1314
1315 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1316
1317 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1318 to the doc string advising against its use for altering the way
1319 windows are scrolled.
1320
1321 2011-12-28 Kenichi Handa <handa@m17n.org>
1322
1323 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1324 coding-system ASCII compatible only when it does not produce BOM
1325 on encoding (Bug#10383).
1326
1327 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1328
1329 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1330 can scroll.
1331 (create_and_show_popup_menu): Always use menu_position_func for
1332 Gtk3 (Bug#10361).
1333
1334 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * callint.c (Fcall_interactively): Don't truncate prompt string.
1337
1338 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1341 property that ends at ZV, so that the bidi iteration could be
1342 resumed from there (after widening). (Bug#10360)
1343
1344 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1347
1348 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1349
1350 * nsterm.m (x_free_frame_resources):
1351 Release f->output_data.ns->miniimage.
1352 (ns_index_color): Fix indentation. Do not retain
1353 color_table->colors[i].
1354
1355 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1356 before returning.
1357
1358 * nsfns.m (x_set_background_color): Assign return value from
1359 ns_index_color to face-background instead of NSColor*.
1360 (ns_implicitly_set_icon_type): Fix indentation.
1361 Change assignment in for loop to comparison.
1362
1363 * emacs.c (ns_pool): New variable.
1364 (main): Assign ns_pool.
1365 (Fkill_emacs): Call ns_release_autorelease_pool.
1366
1367 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1368 autorelease fdesc, release fdAttrs and tdict.
1369 (ns_get_covering_families): Release charset.
1370 (ns_findfonts): Release NSFontDescriptor created with new.
1371 (ns_uni_to_glyphs): Fix indentation.
1372 (setString): Release attrStr before assigning new value.
1373
1374 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1375
1376 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1377 and NS_IMPL_COCOA.
1378 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1379 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1380
1381 2011-12-18 David Reitter <reitter@cmu.edu>
1382
1383 * nsterm.m (ns_term_init): Subscribe for notifications
1384 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1385 to method trackingNotification in EmacsMenu.
1386
1387 * nsmenu.m (trackingMenu): New variable.
1388 (trackingNotification): New method (from Aquamacs).
1389 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1390 from Aquamacs (Bug#7030).
1391
1392 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1393
1394 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1395 (symbol_to_nsstring): Fix indentation.
1396 (ns_symbol_to_pb): New function.
1397 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1398 (Fns_rotate_cut_buffers_internal): Remove.
1399 (Fns_store_selection_internal): Rename from
1400 Fns_store_cut_buffer_internal.
1401 (ns_get_foreign_selection, Fx_own_selection_internal)
1402 (Fx_disown_selection_internal, Fx_selection_exists_p)
1403 (Fns_get_selection_internal, Fns_store_selection_internal):
1404 Use ns_symbol_to_pb and check if return value is nil.
1405 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1406 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1407 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1408 renamed to Sns_store_selection_internal.
1409 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1410 and remove this function.
1411 (ns_handle_selection_clear): Remove, never used.
1412 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1413 here.
1414
1415 2011-12-17 Ken Brown <kbrown@cornell.edu>
1416
1417 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1418 GID is unknown (Bug#10257).
1419
1420 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1421
1422 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1423 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1424 which caused a build failure on GNU/Linux IA-64. This problem was
1425 introduced by my 2011-10-07 patch.
1426
1427 2011-12-15 Juri Linkov <juri@jurta.org>
1428
1429 * image.c (imagemagick_error): New function. (Bug#10112)
1430 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1431 Use `imagemagick_error' where ImageMagick functions return
1432 `MagickFalse'.
1433 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1434 proper order.
1435
1436 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1437
1438 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1439 fill background (Bug#8992).
1440
1441 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1442
1443 * window.c (Vwindow_combination_resize)
1444 (Vwindow_combination_limit): Use t instead of non-nil in
1445 doc-strings.
1446 (Vrecenter_redisplay): Add first sentence of doc-string on
1447 separate line.
1448 (Frecenter): Fix doc-string typo.
1449
1450 2011-12-11 Kenichi Handa <handa@m17n.org>
1451
1452 * coding.c (Funencodable_char_position): Pay attention to the
1453 buffer text relocation (Bug#9389).
1454
1455 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1456
1457 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1458 gtk_init (Bug#10100).
1459
1460 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1461
1462 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1463 IT->string is nil. (Bug#10263)
1464
1465 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1466
1467 * nsterm.h (x_free_frame_resources): Declare.
1468
1469 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1470 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1471
1472 * nsterm.h (ns_get_defaults_value): Declare.
1473
1474 * nsterm.m (ns_default): Call ns_get_defaults_value.
1475
1476 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1477
1478 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1479 (Bug#10170)
1480
1481 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1482
1483 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1484 that where the value of an _OBJC_* symbol points to is in the .bss
1485 section (Bug#10240).
1486
1487 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1488
1489 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1490 after the loop to call ccl_driver at least once (Bug#8619).
1491
1492 2011-12-08 Kenichi Handa <handa@m17n.org>
1493
1494 * ftfont.c (get_adstyle_property): Fix previous change
1495 (Bug#10233).
1496
1497 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1500 dirs from the default value of EMACSLOADPATH (bug#10208).
1501
1502 2011-12-07 Glenn Morris <rgm@gnu.org>
1503
1504 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1505 installation and source directories as well. (Bug#10208)
1506
1507 2011-12-06 Chong Yidong <cyd@gnu.org>
1508
1509 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1510
1511 2011-12-06 Glenn Morris <rgm@gnu.org>
1512
1513 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1514 as an error, not just -1. (Bug#10217)
1515
1516 2011-12-05 Chong Yidong <cyd@gnu.org>
1517
1518 * keyboard.c (process_special_events): New function.
1519 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1520
1521 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * coding.c (encode_designation_at_bol): Don't use uninitialized
1524 local variable (Bug#9318).
1525
1526 2011-12-05 Kenichi Handa <handa@m17n.org>
1527
1528 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1529 return Qnil (Bug#8046, Bug#10193).
1530
1531 2011-12-05 Kenichi Handa <handa@m17n.org>
1532
1533 * coding.c (encode_designation_at_bol): New args charbuf_end and
1534 dst. Return the number of produced bytes. Callers changed.
1535 (coding_set_source): Return how many bytes coding->source was
1536 relocated.
1537 (coding_set_destination): Return how many bytes
1538 coding->destination was relocated.
1539 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1540 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1541
1542 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1543
1544 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1545 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1546 macro (Bug#9318).
1547
1548 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1549
1550 The following changes are to fix Bug#9318.
1551
1552 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1553 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1554 (encode_coding_iso_2022, encode_coding_sjis)
1555 (encode_coding_big5, encode_coding_charset): Use the above macros.
1556
1557 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * lisp.h (process_quit_flag): Fix external declaration.
1560
1561 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 Don't macro-inline non-performance-critical code.
1564 * eval.c (process_quit_flag): New function.
1565 * lisp.h (QUIT): Use it.
1566
1567 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1568
1569 * nsfns.m (get_geometry_from_preferences): New function.
1570 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1571
1572 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * emacs.c (Qkill_emacs): Define.
1575 (syms_of_emacs): Initialize it.
1576 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1577 Qquit_flag to `kill-emacs' instead.
1578 (quit_throw_to_read_char): Add parameter `from_signal'.
1579 All callers changed. Call Fkill_emacs if requested and safe.
1580 * lisp.h (QUIT): Call Fkill_emacs if requested.
1581
1582 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1583
1584 * widget.c (update_wm_hints): Return if wmshell is null.
1585 (widget_update_wm_size_hints): New function.
1586
1587 * widget.h (widget_update_wm_size_hints): Declare.
1588
1589 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1590 widget_update_wm_size_hints (Bug#10104).
1591
1592 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1593
1594 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1595 before a newline, prepare the bidi iterator for consuming the
1596 newline, and keep the current paragraph direction. (Bug#10183)
1597 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1598
1599 2011-12-02 Juri Linkov <juri@jurta.org>
1600
1601 * search.c (Fword_search_regexp): New Lisp function created from
1602 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1603 (Fword_search_backward, Fword_search_forward)
1604 (Fword_search_backward_lax, Fword_search_forward_lax):
1605 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1606 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1607
1608 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1609
1610 * fileio.c (Finsert_file_contents): Move after-change-function call
1611 to before the "handled:" label, since all "goto handled" appear in
1612 cases where the *-change-functions have already been properly called
1613 (bug#10117).
1614
1615 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1616
1617 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1618 waiting for input. (Bug#10169)
1619
1620 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1621
1622 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1623 verifies glyph row's hash code--we have just reallocated the
1624 glyphs, so their contents can be complete garbage. (Bug#10164)
1625
1626 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1627
1628 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1629
1630 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1631
1632 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1633 attributes are tested _before_ calling verify_row_hash, to protect
1634 against GCC re-ordering of the tests. (Bug#10164)
1635
1636 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1637
1638 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1639
1640 * xterm.c (handle_one_xevent): Only set async_visible and friends
1641 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1642 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1643 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1644
1645 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1648 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1649 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1650 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1651 All uses changed to use GCPRO1 etc.
1652 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1653 Revert to old implementation (i.e., before 2011-03-11).
1654
1655 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1656
1657 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1658 of scroll runs so as to avoid assigning disabled bogus rows and
1659 unnecessary graphics copy operations.
1660
1661 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1662
1663 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1664 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1665 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1666 (malloc, free, realloc, calloc): Redirect to e_* only when
1667 compiling Emacs.
1668
1669 * lisp.h (GCTYPEBITS): Move before first use.
1670 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1671 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1672 this macro definition.
1673
1674 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1675 _MSC_VER.
1676
1677 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1678
1679 * gtkutil.c (xg_create_frame_widgets):
1680 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1681 present with Gtk+ 2.0.
1682
1683 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * fileio.c (Finsert_file_contents): Undo previous change; see
1686 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1687
1688 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 Rename locals to avoid shadowing.
1691 * fileio.c (Finsert_file_contents):
1692 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1693 * process.c (wait_reading_process_output):
1694 Rename inner 'proc' to 'p' to avoid shadowing.
1695 Indent for consistency with usual Emacs style.
1696
1697 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1698
1699 * xdisp.c (redisplay_window): If cursor row is not fully visible
1700 after recentering, and scroll-conservatively is set to a large
1701 number, scroll window by a few more lines to make the cursor fully
1702 visible and out of scroll-margin. (Bug#10105)
1703 (start_display): Don't move to the next line if the display should
1704 start at a newline that is part of a display vector or an overlay
1705 string. (Bug#10119)
1706
1707 2011-11-24 Juri Linkov <juri@jurta.org>
1708
1709 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1710 after the `MagickPingImage' call. (Bug#10112)
1711
1712 2011-11-23 Chong Yidong <cyd@gnu.org>
1713
1714 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1715
1716 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1717
1718 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1719 making another buffer current. (Bug#10114)
1720
1721 2011-11-23 Glenn Morris <rgm@gnu.org>
1722
1723 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1724
1725 2011-11-23 Chong Yidong <cyd@gnu.org>
1726
1727 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1728 using it (Bug#5984).
1729
1730 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1731
1732 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1733 and header-lines, as they don't have one computed for them.
1734 (Bug#10098)
1735
1736 * .gdbinit (prow): Make displayed values more self-explaining.
1737 Add row's hash code.
1738
1739 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1740
1741 * process.c (wait_reading_process_output): Fix asynchrounous
1742 GnuTLS socket handling on some versions of the GnuTLS library.
1743 (wait_reading_process_output): Add comment and URL.
1744
1745 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1746
1747 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1748
1749 2011-11-21 Chong Yidong <cyd@gnu.org>
1750
1751 * window.c (Fnext_window, Fprevious_window): Doc fix.
1752
1753 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1754
1755 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1756
1757 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1758
1759 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1760
1761 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1762
1763 * window.c (Fset_window_combination_limit): Rename argument
1764 STATUS to LIMIT.
1765 (Vwindow_combination_limit): Remove "status" from doc-string.
1766
1767 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1768
1769 * m/ibms390.h: Remove.
1770 * m/ibms390x.h: Don't include "ibms390.h".
1771
1772 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1773
1774 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1775 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1776
1777 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * casetab.c (Fset_case_table):
1780 * charset.c (Fcharset_after): Fix typos.
1781
1782 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1785 Otherwise, valgrind does not work on some platforms.
1786 Problem reported by Andreas Schwab in
1787 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1788 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1789 is set, removing the need for VIRT_ADDRESS_VARIES.
1790 (PURE_P): Use a more-efficient implementation that needs just one
1791 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1792 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1793 to 4 (xorl, subq, cmpq, setbe).
1794 * alloc.c (pure): Always extern now, since that's the
1795 VIRT_ADDR_VARIES behavior.
1796 (PURE_POINTER_P): Use a single comparison, not two, for
1797 consistency with the new puresize.h.
1798 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1799 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1800 Remove VIRT_ADDR_VARIES no longer needed.
1801
1802 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1803
1804 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1805 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1806 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1807 behave as if the cursor position were at the window margin.
1808
1809 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1810 and the cursor position is out of bounds, behave as if the cursor
1811 position were at the window margin. (Bug#10075)
1812
1813 2011-11-18 Chong Yidong <cyd@gnu.org>
1814
1815 * window.c (Fwindow_combination_limit): Make first argument
1816 non-optional, since it is meaningless for live windows like the
1817 selected window.
1818
1819 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1822
1823 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1826 (graft_intervals_into_buffer): Simplify.
1827
1828 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1829
1830 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1831 hash values of the two rows.
1832 (copy_row_except_pointers): Preserve the used[] arrays and the
1833 hash values of the two rows. (Bug#10035)
1834 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1835
1836 * xdisp.c (row_hash): New function, body extracted from
1837 compute_line_metrics.
1838 (compute_line_metrics): Call row_hash, instead of computing the
1839 hash code inline.
1840
1841 * dispnew.c (verify_row_hash): Call row_hash for computing the
1842 hash code of a row, instead of duplicating code from xdisp.c.
1843
1844 * dispextern.h (row_hash): Add prototype.
1845
1846 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1847
1848 * frame.c (delete_frame): Don't delete the terminal when the last
1849 X frame is closed if emacs is built with GTK toolkit.
1850
1851 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1854
1855 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1856
1857 * window.c (Vwindow_splits): Rename to
1858 Vwindow_combination_resize. Suggested by Juri Linkov.
1859 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1860 of Vwindow_splits.
1861
1862 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * nsfns.m (Fns_font_name):
1865 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1866
1867 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1868
1869 * window.h (window): Rename slot "nest" to "combination_limit".
1870 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1871 (Fset_window_nest): Rename to Fset_window_combination_limit.
1872 (Vwindow_nest): Rename to Vwindow_combination_limit.
1873 (recombine_windows, make_parent_window, make_window)
1874 (Fsplit_window_internal, saved_window)
1875 (Fset_window_configuration, save_window_save): Rename all
1876 occurrences of window_nest to window_combination_limit.
1877
1878 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * image.c (imagemagick_load_image): Fix typo.
1881
1882 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1883
1884 * xdisp.c (display_line): Move the call to
1885 highlight_trailing_whitespace before the call to
1886 compute_line_metrics, since the latter needs to see the final
1887 faces of all the glyphs to compute ROW's hash value.
1888 Fixes assertion violations in row_equal_p. (Bug#10035)
1889
1890 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1891
1892 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1893 just return (bug#10044).
1894
1895 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1896
1897 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1898 with user-defined heap size. Bump the default size of the temacs
1899 heap to 27MB, to avoid memory warning when running temacs.
1900 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1901
1902 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1903 current_matrix and desired_matrix. (Bug#9990)
1904 (verify_row_hash) [XASSERTS]: New function.
1905 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1906 that the hash value of glyph rows is correct.
1907
1908 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1909
1910 * window.h (window): Remove splits slot.
1911 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1912 (Fdelete_other_windows_internal, make_parent_window)
1913 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1914 (Fset_window_configuration, save_window_save): Don't deal with
1915 split status of windows.
1916 (saved_window): Remove splits slot.
1917 (Vwindow_splits): Rewrite doc-string.
1918
1919 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * xfns.c (unwind_create_frame):
1922 * nsfns.m (unwind_create_frame):
1923 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1924 Vframe_list (Bug#9999).
1925
1926 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1929
1930 2011-11-11 Kenichi Handa <handa@m17n.org>
1931
1932 * callproc.c (Fcall_process): Set the member dst_multibyte of
1933 process_coding.
1934
1935 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1936
1937 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1938 avoid a crash (bug#9496).
1939
1940 2011-11-09 Chong Yidong <cyd@gnu.org>
1941
1942 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1943 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1944
1945 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1948
1949 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 Avoid some portability problems by eschewing 'extern inline' functions.
1952 The trivial performance wins aren't worth the portability hassles; see
1953 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1954 et seq.
1955 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1956 (window_box_width, window_box_left, window_box_left_offset)
1957 (window_box_right, window_box_right_offset): Undo previous change,
1958 by removing the "extern"s.
1959 * intervals.c (adjust_intervals_for_insertion)
1960 (adjust_intervals_for_deletion): Undo previous change,
1961 making these static again.
1962 (offset_intervals, temp_set_point_both, temp_set_point)
1963 (copy_intervals_to_string): No longer inline.
1964 * xdisp.c (window_text_bottom_y, window_box_width)
1965 (window_box_height, window_box_left_offset)
1966 (window_box_right_offset, window_box_left, window_box_right)
1967 (window_box): No longer inline.
1968
1969 2011-11-08 Chong Yidong <cyd@gnu.org>
1970
1971 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1972 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1973 Signal an error if not a live window.
1974 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1975 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1976
1977 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1978
1979 * lisp.h (syms_of_abbrev): Remove declaration.
1980 Reported by CHENG Gao <chenggao@royau.me>.
1981
1982 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1983
1984 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1985 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1986 of temacs in GUI mode.
1987
1988 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1989
1990 * window.h: Declare delete_all_child_windows instead of
1991 delete_all_subwindows.
1992 * window.c (Fwindow_nest, Fset_window_nest)
1993 (Fset_window_new_total, Fset_window_new_normal)
1994 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1995 (delete_all_subwindows): Rename to delete_all_child_windows.
1996 (Fdelete_other_windows_internal, Fset_window_configuration):
1997 Call delete_all_child_windows instead of delete_all_subwindows.
1998 * frame.c (delete_frame): Call delete_all_child_windows instead
1999 of delete_all_subwindows.
2000
2001 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2004 This is also needed for porting to any host where GC_MARK_STACK is
2005 not GC_MAKE_GCPROS_NOOPS.
2006 (which_symbols): Use it.
2007
2008 2011-11-07 Kenichi Handa <handa@m17n.org>
2009
2010 * coding.c (coding_set_destination): Check coding->src_pos only
2011 when coding->src_object is a buffer (bug#9910).
2012
2013 * process.c (send_process): Set the member src_multibyte of coding
2014 to 0 (bug#9911) when sending a unibyte text.
2015
2016 * callproc.c (Fcall_process): Set the member src_multibyte of
2017 process_coding to 0 (bug#9912).
2018
2019 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2020
2021 * xmenu.c (cleanup_widget_value_tree): New function.
2022 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2023 calling free_menubar_widget_value_tree directly (Bug#9830).
2024
2025 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Fix some portability problems with 'inline'.
2028 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2029 (window_box_width, window_box_left, window_box_left_offset)
2030 (window_box_right, window_box_right_offset): Declare extern.
2031 Otherwise, these inline functions do not conform to C99 and
2032 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2033 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2034 * intervals.c (adjust_intervals_for_insertion)
2035 (adjust_intervals_for_deletion): Now extern, because otherwise the
2036 extern inline functions 'offset_intervals' couldn't refer to it.
2037 (static_offset_intervals): Remove.
2038 (offset_intervals): Rewrite using the old contents of
2039 static_offset_intervals. The old version didn't conform to C99
2040 because an extern inline function contained a reference to an
2041 identifier with static linkage.
2042
2043 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2044
2045 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2046 GC.
2047
2048 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2049
2050 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2051 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2052 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2053 return Qleft_to_right.
2054
2055 2011-11-06 Chong Yidong <cyd@gnu.org>
2056
2057 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2058 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2059 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2060 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2061 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2062 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2063 (Fwindow_vscroll): Doc fix.
2064 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2065 argument, since it makes no sense to pass a live window and for
2066 consistency with window-child.
2067
2068 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2069
2070 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2071 support MSVC.
2072
2073 2011-11-05 Jason Rumney <jasonr@gnu.org>
2074
2075 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2076 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2077 fonts (Bug#6029).
2078 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2079 bitwise arithmetic preventing use of unicode-sip and non-truetype
2080 opentype fonts.
2081
2082 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2083
2084 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2085 "emacs"-only part.
2086
2087 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2088 initialization code to keep similarity to xfns.c after changes
2089 from 2011-11-05.
2090
2091 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2092
2093 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2094 (unwind_create_frame): New function (Bug#9943).
2095 (Fx_create_frame): Restructure code to be more similar to the one in
2096 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2097 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2098 Move terminal->reference_count++ just before making the frame official
2099 (Bug#9943).
2100
2101 * nsterm.m (x_free_frame_resources): New function.
2102 (x_destroy_window): Move code to x_free_frame_resources.
2103
2104 * xfns.c (unwind_create_frame): Fix comment.
2105 (Fx_create_frame, x_create_tip_frame):
2106 Move terminal->reference_count++ just before making the frame
2107 official. Move initialization of image_cache_refcount and
2108 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2109
2110 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2111
2112 Support MSVC build with newer versions of Visual Studio.
2113 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2114 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2115 nt/gmake.defs.
2116
2117 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2118 which are not supported by MSVC.
2119 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2120 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2121 bitfields.
2122 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2123 types in bitfields.
2124 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2125
2126 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2127
2128 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2129
2130 Support MSVC build with newer versions of Visual Studio.
2131 * w32.c: Don't include w32api.h for MSVC.
2132 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2133
2134 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2135 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2136 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2137 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2138 e_* cousins.
2139 (alloca) [_MSC_VER]: Define to _alloca.
2140
2141 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2142
2143 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2144
2145 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2146
2147 * xdisp.c (note_mouse_highlight): If either of
2148 previous/next-single-property-change returns nil, treat that as
2149 the beginning or the end of the buffer. (Bug#9955)
2150
2151 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2152
2153 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2154 label is not null (Bug#9951).
2155 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2156 may be NULL.
2157
2158 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2159
2160 * window.c (Fwindow_body_size): Mention in the doc string that the
2161 return value is in frame's canonical units. (Bug#9949)
2162
2163 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2164
2165 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2166
2167 * w32fns.c (unwind_create_frame): If needed, free the glyph
2168 matrices of the partially constructed frame. (Bug#9943)
2169 * xfns.c (unwind_create_frame): Likewise.
2170
2171 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2174 Don't stop backward scan on the continuation glyph, even though
2175 its CHARPOS is positive.
2176 (mouse_face_from_buffer_pos, note_mouse_highlight):
2177 Rename cover_string to disp_string.
2178
2179 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2180
2181 * window.c (temp_output_buffer_show): Don't use
2182 Vtemp_buffer_show_specifiers.
2183 (Vtemp_buffer_show_specifiers): Remove unused variable.
2184
2185 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2188 past the beginning of the current glyph matrix.
2189
2190 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2191
2192 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2193 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2194 HAVE_GTK3 (Bug#9869).
2195
2196 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2197 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2198
2199 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2200
2201 * xterm.c: Declare x_handle_net_wm_state to return int.
2202 (handle_one_xevent): Check if we are iconified but don't have
2203 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2204 (get_current_wm_state): Return non-zero if not hidden,
2205 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2206 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2207 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2208 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2209
2210 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2213 so that this new function doesn't get optimized away by a
2214 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2215
2216 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2217
2218 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2219
2220 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2221
2222 Fix the `xbytecode' command.
2223 * .gdbinit (xprintbytestr): New command.
2224 (xwhichsymbols): Rename from `which'; all callers changed.
2225 (xbytecode): Print the byte-code string as well.
2226
2227 2011-10-29 Kim Storm <storm@cua.dk>
2228
2229 * alloc.c (which_symbols): New function.
2230
2231 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2232
2233 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2234 line. (Bug#9903)
2235
2236 2011-10-29 Glenn Morris <rgm@gnu.org>
2237
2238 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2239 Not clear what it was for, and it causes various bugs. (Bug#9839)
2240
2241 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2242
2243 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2244 possible random value that matches one of those tested as
2245 condition to clear the mouse face.
2246
2247 2011-10-28 Chong Yidong <cyd@gnu.org>
2248
2249 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2250
2251 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2252
2253 * window.c (make_window): Initialize phys_cursor_on_p.
2254
2255 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2256
2257 * lisp.h (struct Lisp_Symbol): Update comments.
2258
2259 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2262
2263 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2264
2265 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2266 <oslsachem@gmail.com> for helping to debug this.
2267
2268 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2269 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2270 (g_b_init_get_glyph_outline_w): New static variables.
2271 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2272 (GetGlyphOutlineW_Proc): New typedefs.
2273 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2274 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2275 New functions.
2276 (w32font_open_internal, compute_metrics):
2277 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2278 instead of calling the "wide" APIs directly.
2279
2280 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2281
2282 * w32.h (syms_of_w32font): Add prototype.
2283
2284 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2285
2286 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2287 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2288 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2289 (Fmove_to_window_line): Doc fix.
2290
2291 2011-10-27 Chong Yidong <cyd@gnu.org>
2292
2293 * process.c (make_process): Set gnutls_state to NULL.
2294
2295 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2296 non-NULL, regardless of GNUTLS_INITSTAGE.
2297 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2298 an error. Set process slots as soon as we allocate them.
2299
2300 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2301
2302 2011-10-27 Chong Yidong <cyd@gnu.org>
2303
2304 * gnutls.c (emacs_gnutls_deinit): New function.
2305 Deallocate credentials structures as well as calling gnutls_deinit.
2306 (Fgnutls_deinit, Fgnutls_boot): Use it.
2307
2308 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2309 (deactivate_process): Call emacs_gnutls_deinit.
2310
2311 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * image.c (x_create_x_image_and_pixmap):
2314 * w32.c (sys_rename, w32_delayed_load):
2315 * w32font.c (fill_in_logfont):
2316 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2317
2318 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2319
2320 * w32fns.c (w32_default_color_map): New function,
2321 extracted from Fw32_default_color_map.
2322 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2323
2324 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2327
2328 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2329
2330 * keyboard.c (test_undefined): New function (bug#9751).
2331 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2332
2333 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2334
2335 * sysdep.c (init_sys_modes): Fix the check for the controlling
2336 terminal (Bug#6649).
2337
2338 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2339
2340 * dispextern.h (struct bidi_it): New member next_en_type.
2341
2342 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2343 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2344 current character, check also for next_en_type being WEAK_EN.
2345 (bidi_resolve_weak): Don't enter the expensive loop if the current
2346 position is before next_en_pos. Record the bidi type of the first
2347 non-ET, non-BN character we find, in addition to its position.
2348 (bidi_level_of_next_char): Invalidate next_en_type when
2349 next_en_pos is over-stepped.
2350
2351 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2354 * editfns.c: Rewrite current-time-zone so that it invokes
2355 the equivalent of (format-time-string "%Z") to get the time zone name.
2356 This fixes a bug when the time zone name contains characters that
2357 need converting from the system time locale to Emacs internal format.
2358 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2359 that patch fixed format-time-string to do the conversion, but
2360 I forgot to fix current-time-zone.
2361 (format_time_string): New function, containing most of
2362 what Fformat_time_string used to contain.
2363 (Fformat_time_string): Rewrite in terms of format_time_string.
2364 This doesn't change this function's behavior.
2365 (current-time-zone): Rewrite to use format_time_string.
2366 This fixes the bug reported by Michael Schierl in
2367 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2368 Jason Rumney's 2007-06-07 change worked around this bug, but
2369 didn't fix it.
2370 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2371
2372 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xdisp.c (start_display): If the character at POS is displayed
2375 via a display vector, reset IT->current.dpvec_index to zero.
2376 (try_window_reusing_current_matrix): If a line ends in a display
2377 vector or the next line starts in a display vector, continue
2378 redrawing the window even though the character position of
2379 start_row was reached.
2380 (Bug#9771, part 2)
2381
2382 2011-10-18 Chong Yidong <cyd@gnu.org>
2383
2384 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2385 with nobreak-char-display too.
2386
2387 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2388
2389 Fix part 3 of bug#9771.
2390 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2391 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2392 non-neutral characters if the current character is a paragraph
2393 separator (a.k.a. Newline). This avoids running the same
2394 expensive loop twice, once when we consume the preceding newline
2395 and the other time when the line actually needs to be displayed.
2396 Avoid the loop when we see neutrals on the base embedding level
2397 following a character whose directionality is the same as the
2398 paragraph's. This avoids running the expensive loop when a line
2399 ends in a long sequence of neutrals, like control characters.
2400 Add assertion against STRONG_AL type. Slightly rearrange code
2401 that determines the type of a neutral given the first non-neutral
2402 that follows it.
2403 (bidi_level_of_next_char): Set next_en_pos to zero when
2404 invalidating its info.
2405
2406 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2407
2408 * xdisp.c (push_display_prop): Determine whether to record string
2409 or buffer position by IT->string, not by IT->method. Allow
2410 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2411 (move_it_vertically_backward): Don't look for character position
2412 immediately after the newline when in a continuation line.
2413 (Bug#9771, part 1)
2414
2415 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2416
2417 * window.c (coordinates_in_window): Rewrite and delabelize
2418 vertical border check. (Bug#5357) (Bug#9618)
2419
2420 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2421
2422 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2423 errors in XSetWindowBorder (bug#9310).
2424
2425 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2426
2427 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2428 avoid crash when xmalloc overrun checking is enabled.
2429
2430 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2431
2432 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2433 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2434 cursor motion with <left> and <right> arrow keys.
2435
2436 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2437 some callers set that themselves.
2438
2439 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2442 display string and the previous row comes from the same string and
2443 is empty. (Bug#9739) (Bug#9738)
2444
2445 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2446
2447 * doc.c (get_doc_string): Encode file name (bug#9735).
2448
2449 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2450
2451 * bidi.c (bidi_level_of_next_char):
2452 * xdisp.c (get_visually_first_element): Remove old incorrect
2453 comments regarding the Unicode Line Separator character.
2454
2455 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2456
2457 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2458
2459 * alloc.c (Fgc_status): Do not access beyond zombies array
2460 boundary if nzombies > MAX_ZOMBIES.
2461 * alloc.c (dump_zombies): Add missing format specifier.
2462
2463 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2466 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2467
2468 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2469 Some packages use them to denote characters with modifiers.
2470
2471 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2472
2473 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2474 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2475 matching a pp-number. Rename parameter var to var1.
2476
2477 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2478
2479 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2480
2481 2011-10-08 Glenn Morris <rgm@gnu.org>
2482
2483 * callint.c (Fcall_interactively): Give a more explicit error for the
2484 'c' case with a non-character input. (Bug#8479)
2485
2486 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2489 lines.
2490 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2491 lines that are hscrolled on the left.
2492
2493 * dispnew.c (buffer_posn_from_coords): Account for a possible
2494 presence of header-line. (Bug#4426)
2495
2496 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2497
2498 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2499 Don't advertise functionality which we discourage or doesn't work.
2500
2501 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2504 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2505 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2506 this makes Emacs dump core during garbage collection on rare
2507 occasions. sizeof is obviously inferior to offsetof here, so
2508 stick with offsetof.
2509 (GC_POINTER_ALIGNMENT): New macro.
2510 (mark_memory): Omit 3rd (offset) arg; caller changed.
2511 Don't assume EMACS_INT alignment is the same as pointer alignment.
2512
2513 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2514
2515 * keyboard.c (read_key_sequence_remapped): New var.
2516 (read_key_sequence): Compute remapping in the right buffer.
2517 (command_loop_1): Use read_key_sequence's remapping directly.
2518
2519 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2520
2521 * dired.c (file_name_completion): Don't expand file name.
2522 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2523 before checking file name handler.
2524
2525 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2526 they've been requested explicitly (bug#9591).
2527
2528 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2529
2530 * keymap.c (Fsingle_key_description): Use make_specified_string
2531 instead of build_string to build string from push_key_description.
2532 (Bug#5193)
2533
2534 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2537 This fixes a Y2038 bug on 64-bit hosts.
2538 * buffer.c (reset_buffer):
2539 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2540 (Fclear_buffer_auto_save_failure):
2541 Use 0, not -1, to represent an unset failure time, since time_t
2542 might not be signed.
2543
2544 Remove dependency on glibc malloc internals.
2545 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2546 Move back here from lisp.h, but with their new implementations.
2547 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2548 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2549 * charset.c (charset_table_init): New static var.
2550 (syms_of_charset): Use it instead of xmalloc. This removes a
2551 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2552 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2553 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2554 Move back to alloc.c.
2555 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2556 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2557
2558 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * nsterm.m (windowDidResize): Call x_set_window_size only when
2561 ns_in_resize is true. Otherwise set pixelwidth/height and
2562 call change_frame_size (Bug#9628).
2563
2564 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Port --enable-checking=all to Fedora 14 x86-64.
2567 * charset.c (syms_of_charset): Also account for glibc malloc's
2568 internal overhead when calculating the initial malloc maximum.
2569
2570 Port --enable-checking=all to Fedora 14 x86.
2571 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2572 Move to lisp.h.
2573 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2574 (overrun_check_realloc, overrun_check_free):
2575 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2576 That way, xmalloc returns a properly-aligned pointer even if
2577 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2578 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2579 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2580 into account when calculating the initial malloc maximum.
2581 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2582 Move here from alloc.c, so that charset.c can use it too.
2583 Properly align; the old code wasn't right for common 32-bit hosts
2584 when configured with --enable-checking=all.
2585 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2586 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2587
2588 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2589
2590 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2591 use EDOM.
2592
2593 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2594
2595 * xdisp.c (compute_display_string_end): If there's no display
2596 string at CHARPOS, return -1.
2597
2598 * bidi.c (bidi_fetch_char): When compute_display_string_end
2599 returns a negative value, treat the character as a normal
2600 character not covered by a display string. (Bug#9624)
2601
2602 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2603
2604 * lread.c (Fread_from_string): Fix typo in docstring.
2605
2606 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2607
2608 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2609 newline, reseat the iterator instead of bidi-iterating there one
2610 character at a time. (Bug#9610)
2611 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2612 TO_CHARPOS if the bidi iterator is at base embedding level.
2613
2614 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * lread.c (readevalloop): Use correct code for NBSP.
2617 (read1): Likewise. (Bug#9608)
2618
2619 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2620
2621 * dbusbind.c (Fdbus_register_signal): When service is not
2622 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2623
2624 2011-09-25 Glenn Morris <rgm@gnu.org>
2625
2626 * buffer.c (truncate-lines): Doc fix.
2627
2628 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2629
2630 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2631 (Fset_window_next_buffers): Doc fix.
2632
2633 2011-09-24 Glenn Morris <rgm@gnu.org>
2634
2635 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2636
2637 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 Fix minor problems found by static checking.
2640 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2641 * indent.c (Fvertical_motion): Fix == vs = typo.
2642
2643 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2644
2645 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2646 Default value is now t. Doc fix.
2647
2648 * indent.c (Fvertical_motion): Compute and apply the overshoot
2649 logic when moving up, not only when moving down. Fix the
2650 confusing name and values of the it_overshoot_expected variable;
2651 logic changes accordingly. (Bug#9254) (Bug#9549)
2652
2653 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2654 CHARPOS is covered by a display string which includes newlines.
2655 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2656 is covered by a display string with embedded newlines.
2657
2658 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2659
2660 * dbusbind.c (Fdbus_register_signal): Add match rule to
2661 Vdbus_registered_objects_table. (Bug#9581)
2662 (Fdbus_register_method, Vdbus_registered_objects_table):
2663 Fix docstring.
2664
2665 2011-09-24 Jim Meyering <meyering@redhat.com>
2666
2667 do not ignore write error for any output size
2668 The previous change was incomplete.
2669 While it makes emacs --batch detect the vast majority of stdout
2670 write failures, errors were still ignored whenever the output size is
2671 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2672 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2673 && echo FAIL: ignored write error
2674 FAIL: ignored write error
2675 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2676 && echo FAIL: ignored write error
2677 FAIL: ignored write error
2678 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2679
2680 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2681
2682 * emacs.c (Fkill_emacs): In noninteractive mode exit
2683 non-successfully if a write error occurred on stdout. (Bug#9574)
2684
2685 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2688 the xassert test.
2689
2690 * dispextern.h (struct it): Update the comment documenting what
2691 can it->OBJECT be.
2692
2693 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2694
2695 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2696 a display string, extend search for cursor position to end of row.
2697 (find_row_edges): If the row ends in a newline from a display
2698 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2699 Handle the case of a display string with multiple newlines.
2700 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2701 non-empty line. Fixes confusing cursor motion with arrow keys at
2702 the beginning of a line that starts with whitespace.
2703
2704 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2705
2706 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2707 (bug#9493).
2708
2709 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2710
2711 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2712 boolean (Bug#9154).
2713
2714 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2715
2716 * xdisp.c (display_line): Record maximum and minimum buffer
2717 positions even if no glyphs were produced (e.g., by a zero-width
2718 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2719 buffer positions that will be removed from the glyph row because
2720 they don't fit.
2721 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2722 column is beyond frame width: don't subtract 1 "pixel" when
2723 computing width of the stretch.
2724 (reseat_at_next_visible_line_start): Undo the change made on
2725 2011-09-17 that saved paragraph information and restored it after
2726 the call to `reseat'. (Bug#9545)
2727
2728 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2729
2730 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2731 and turn window cursor on if cleared (Bug#9415).
2732
2733 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2734
2735 * search.c (boyer_moore): Take unibyte characters from pattern
2736 literally. (Bug#9458)
2737
2738 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2741
2742 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 Fix minor problem found by static checking.
2745 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2746 initialized, to pacify gcc -Wuninitialized.
2747
2748 * fileio.c: Report proper errno when syscall falls.
2749 (Finsert_file_contents): Save and restore errno,
2750 so that report_file_error outputs the correct diagnostic.
2751 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2752
2753 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2754
2755 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2756
2757 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2758
2759 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2760 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2761
2762 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2763
2764 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2765 about the current paragraph and restore it after the call to reseat.
2766
2767 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2768 (bidi_find_paragraph_start): Search back for paragraph beginning
2769 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2770 (bidi_move_to_visually_next): Only trigger paragraph-related
2771 computations when the last character is a newline or at EOB, not
2772 just any NEUTRAL_B. (Bug#9470)
2773
2774 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2775 truncated lines if point is covered by a display string. (Bug#9524)
2776
2777 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2780 (cons_to_x_long): New function.
2781 (lisp_data_to_selection_data): Use it. Correct the test for
2782 short-versus-long data; it was negated. Break out of vector
2783 loop, for efficiency, when a long datum is discovered.
2784
2785 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2786
2787 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2788
2789 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2790
2791 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2792 GCC PR/17406) by declaring this function with external scope.
2793
2794 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2797 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2798
2799 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2800
2801 * editfns.c (Fformat): Correctly handle text properties on "%%".
2802
2803 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2804
2805 * xterm.c (x_draw_composite_glyph_string_foreground):
2806 * w32term.c (x_draw_composite_glyph_string_foreground):
2807 * term.c (encode_terminal_code):
2808 * composite.c (composition_update_it, get_composition_id):
2809 * xdisp.c (get_next_display_element)
2810 (fill_composite_glyph_string): Add comments about special meaning
2811 of TAB characters in a composition.
2812
2813 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2816 This occurs when processing a multibyte format.
2817 Problem reported by Wolfgang Jenker.
2818
2819 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2820
2821 * xdisp.c (try_cursor_movement): Only check for exact match if
2822 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2823
2824 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 Remove unused external symbols.
2827 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2828 * xdisp.c (calc_pixel_width_or_height): Now static.
2829 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2830 * indent.c (check_display_width):
2831 * w32term.c: Fix comment to match code.
2832 * xterm.c, xterm.h (x_catching_errors): Remove.
2833
2834 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * xselect.c: Use signed conversions more consistently (Bug#9498).
2837 (selection_data_to_lisp_data): Assume incoming selection data are
2838 signed integers, not unsigned. This is to be consistent with
2839 outgoing selection data, which was modified to use signed integers
2840 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2841 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2842 expects long, not unsigned long.
2843
2844 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2845
2846 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2847 computation of loop end. Reported by Johan Bockgård
2848 <bojohan@gnu.org>.
2849
2850 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2851
2852 * frame.c (Fother_visible_frames_p): Function deleted.
2853
2854 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2855
2856 * indent.c (compute_motion): Process display vector front to back
2857 rather than the other way around. (Bug#2496)
2858
2859 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2862
2863 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2864
2865 * minibuf.c (Fread_from_minibuffer): Doc fix.
2866
2867 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2870 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2871
2872 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2873
2874 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2875 value for non-existent files.
2876
2877 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2878
2879 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2880 set its "size" to -1. This will set the modtime_size field of
2881 the corresponding buffer to -1, which is what
2882 verify-visited-file-modtime expects for files that do not exist.
2883 (Bug#9139)
2884
2885 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2886
2887 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2888 here ...
2889 * lisp.h: ... from here. push_key_description is no longer
2890 defined in keyboard.c, so its declaration should not be in
2891 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2892 logically belongs with push_key_description.
2893
2894 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2895
2896 * buffer.h: Include <sys/types.h> instead of <time.h>.
2897 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2898 Problem reported by Herbert J. Skuhra.
2899
2900 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2901
2902 * xml.c (parse_region): Make the parsing work for
2903 non-comment-starting XML files again (bug#9144).
2904
2905 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2906
2907 * image.c (gif_load): Fix calculation of bottom and right corner.
2908 (Bug#9468)
2909
2910 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2913 redisplay in small windows.
2914
2915 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2916
2917 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2918
2919 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2920
2921 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2922 Operate on live windows only.
2923
2924 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2925
2926 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2927
2928 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2931 only under bidi iteration.
2932
2933 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2934
2935 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2936
2937 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2940 Without this fix, the command to link temacs failed due to an
2941 undefined symbol __builtin_isnan. This is because
2942 /usr/include/iso/math_c99.h #defines isnan(x) to
2943 __builtin_isnan(x), but the bundled gcc, which identifies itself
2944 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2945 a __builtin_isnan.
2946 * floatfns.c (isnan): #undef, and then #define to a clone of
2947 what's in data.c.
2948 (Fisnan): Always define, since it's always available now.
2949 (syms_of_floatfns): Always define isnan at the Lisp level.
2950
2951 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2954
2955 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2958 The previous code assumed that file offsets (off_t values) fit in
2959 EMACS_INT variables, which is not true on typical 32-bit hosts.
2960 The code messed up by falsely reporting buffer overflow in cases
2961 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2962 when "big" contains more than 2**29 bytes, even though this
2963 inserts just one byte and does not overflow the buffer.
2964 (Finsert_file_contents): Store file offsets as off_t
2965 values, not as EMACS_INT values. Check for overflow when
2966 converting between EMACS_INT and off_t. When checking for
2967 buffer overflow or for overlap, take the offsets into account.
2968 Don't use EMACS_INT for small values where int suffices.
2969 When checking for overlap, fix a typo: ZV was used where
2970 ZV_BYTE was intended.
2971 (Fwrite_region): Don't assume off_t fits into 'long'.
2972 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2973
2974 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2975
2976 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2977
2978 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2979
2980 sprintf-related integer and memory overflow issues (Bug#9412).
2981
2982 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2983 (esprintf, exprintf, evxprintf): New functions.
2984 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2985 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2986 (modify_event_symbol): Do not assume that the length of
2987 name_alist_or_stem is safe to alloca and fits in int.
2988 (Fexecute_extended_command): Likewise for function name and binding.
2989 (Frecursion_depth): Wrap around reliably on integer overflow.
2990 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2991 since some callers pass EMACS_INT values.
2992 (Fsingle_key_description): Don't crash if symbol name contains more
2993 than MAX_ALLOCA bytes.
2994 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2995 (get_minibuffer): Arg is now EMACS_INT, not int.
2996 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2997 (esprintf, exprintf, evxprintf): New decls.
2998 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2999
3000 * dbusbind.c (signature_cat): New function.
3001 (xd_signature, Fdbus_register_signal):
3002 Do not overrun buffer; instead, report string overflow.
3003
3004 * dispnew.c (add_window_display_history): Don't overrun buffer.
3005 Truncate instead; this is OK since it's just a log.
3006
3007 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3008 even if the time zone offset is outlandishly large.
3009 Don't mishandle offset == INT_MIN.
3010
3011 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3012 when creating daemon; the previous buffer-overflow check was incorrect.
3013
3014 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3015 which has the guts of the old verror function.
3016
3017 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3018 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3019
3020 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3021 (font_unparse_xlfd): Don't blindly alloca long strings.
3022 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3023 fits in int, when using sprintf. Use single snprintf to count
3024 length of string rather than counting it via multiple sprintfs;
3025 that's simpler and more reliable.
3026 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3027 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3028 sprintf, in case result does not fit in int.
3029
3030 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3031 (fontset_from_font): Print it.
3032
3033 * frame.c (tty_frame_count): Now printmax_t, not int.
3034 (make_terminal_frame, set_term_frame_name): Print it.
3035 (x_report_frame_params): In X, window IDs are unsigned long,
3036 not signed long, so print them as unsigned.
3037 (validate_x_resource_name): Check for implausibly long names,
3038 and don't assume name length fits in 'int'.
3039 (x_get_resource_string): Don't blindly alloca invocation name;
3040 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3041 not fit in int.
3042
3043 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3044 (xg_check_special_colors, xg_set_geometry):
3045 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3046
3047 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3048 Use esprintf, not sprintf, in case result does not fit in int.
3049
3050 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3051 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3052 it as a large positive number.
3053 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3054 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3055
3056 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3057 in case result does not fit in int.
3058
3059 * print.c (float_to_string): Detect width overflow more reliably.
3060 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3061 buffer overrun. Don't assume list length fits in 'int'. Treat
3062 print length of 0 as 0, not as infinity; to be consistent with other
3063 uses of print length in this function. Don't overflow print length
3064 index. Don't assume hash table size fits in 'long', or that
3065 vectorlike size fits in 'unsigned long'.
3066
3067 * process.c (make_process): Use printmax_t, not int, to format
3068 process-name gensyms.
3069
3070 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3071
3072 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3073 to avoid potential buffer overrun.
3074
3075 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3076 if X resource line is longer than 512 bytes.
3077
3078 * xfns.c (x_window): Make sprintf buffer a bit bigger
3079 to avoid potential buffer overrun.
3080
3081 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3082
3083 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3084
3085 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3086
3087 Integer overflow fixes for scrolling, etc.
3088 Without these, Emacs silently mishandles large integers sometimes.
3089 For example, "C-u 4294967297 M-x recenter" was treated as if
3090 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3091
3092 * xdisp.c (try_window_id): Check Emacs fixnum range before
3093 converting to 'int'.
3094
3095 * window.c (window_scroll_line_based, Frecenter):
3096 Check that an Emacs fixnum is in range before assigning it to 'int'.
3097 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3098 values converted from Emacs fixnums.
3099 (Frecenter): Don't wrap around a line count if it is out of 'int'
3100 range; instead, treat it as an extreme value.
3101 (Fset_window_configuration, compare_window_configurations):
3102 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3103
3104 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3105 that can exceed INT_MAX. Check that EMACS_INT value is in range
3106 before assigning it to the (possibly-narrower) index.
3107 (match_limit): Don't assume that a fixnum can fit in 'int'.
3108
3109 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3110 exceed INT_MAX.
3111
3112 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3113 (Fvertical_motion): Don't wrap around LINES values that don't fit
3114 in 'int'. Instead, treat them as extreme values. This is good
3115 enough for windows, which can't have more than INT_MAX lines anyway.
3116
3117 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3118
3119 * Require libxml/parser.h to avoid compilation warning.
3120
3121 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3122
3123 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3124 since this reportedly can destroy thread storage.
3125
3126 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3127
3128 * syntax.c (find_defun_start): Update all cache variables if
3129 exiting early (Bug#9401).
3130
3131 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3132
3133 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3134
3135 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3136 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3137 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3138
3139 * term.c (tty_append_glyph): New function.
3140 (produce_stretch_glyph): Static function and its prototype deleted.
3141
3142 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3143 Add prototypes.
3144
3145 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3148 when checking :margin (Bug#9390).
3149 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3150 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3151 so that the name doesn't mislead. All uses changed.
3152
3153 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3154
3155 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3156 set_tty_hooks.
3157
3158 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3159
3160 * xdisp.c (move_it_to): Don't bail out early when reaching
3161 position beyond to_charpos, if we are scanning backwards.
3162 (move_it_vertically_backward): When DY == 0, make sure we get to
3163 the first character in the line after the newline.
3164
3165 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3168 (ccl_driver): Do not generate an out-of-range pointer.
3169 (Fccl_execute_on_string): Remove unnecessary check for
3170 integer overflow, noted by Stefan Monnier in
3171 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3172 Remove a FIXME that didn't need fixing.
3173 Simplify the newly-introduced buffer reallocation code.
3174
3175 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3178
3179 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 Integer and memory overflow issues (Bug#9196).
3182
3183 * doc.c (get_doc_string): Rework so that
3184 get_doc_string_buffer_size is the actual buffer size, rather than
3185 being 1 less than the actual buffer size; this makes xpalloc more
3186 convenient.
3187
3188 * image.c (x_allocate_bitmap_record, cache_image):
3189 * xselect.c (Fx_register_dnd_atom):
3190 Simplify previous changes by using xpalloc.
3191
3192 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3193 since either will do and ptrdiff_t is convenient with xpalloc.
3194
3195 * charset.c (charset_table_size)
3196 (struct charset_sort_data.priority): Now ptrdiff_t.
3197 (charset_compare): Don't overflow if priorities differ greatly.
3198 (Fsort_charsets): Don't assume list length fits in int.
3199 Check for size-calculation overflow when allocating sort data.
3200 (syms_of_charset): Allocate an initial charset table that is
3201 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3202
3203 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3204
3205 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3206 The actual value is always <= INT_MAX, and leaving it unsigned made
3207 overflow checking harder.
3208
3209 * dispextern.h (struct glyph_matrix.rows_allocated)
3210 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3211 with xpalloc. The values are still always <= INT_MAX.
3212
3213 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3214
3215 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3216 (SAFE_NALLOCA): New macro.
3217
3218 * region-cache.c (struct boundary.pos, find_cache_boundary)
3219 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3220 (set_cache_region, invalidate_region_cache)
3221 (revalidate_region_cache, know_region_cache, region_cache_forward)
3222 (region_cache_backward, pp_cache):
3223 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3224 so that ptrdiff_t * can be passed to xpalloc.
3225 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3226 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3227 (pp_cache): Don't assume cache_len fits in int.
3228 * region-cache.h: Adjust extern decls to match.
3229
3230 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3231 EMACS_INT, since either will do, for xpalloc.
3232
3233 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3234 (xnmalloc, xnrealloc, xpalloc): New functions.
3235
3236 * bidi.c (bidi_shelve_header_size): New constant.
3237 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3238 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3239
3240 * bidi.c (bidi_cache_shrink):
3241 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3242 (overlay_strings):
3243 Don't update size of array until after memory allocation succeeds,
3244 because xmalloc/xrealloc may not return.
3245 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3246 now that we have proper integer overflow checking.
3247 (record_overlay_string, overlay_strings): Catch overflows when
3248 calculating size of overlay_str_buf.
3249
3250 * callproc.c (Fcall_process): Check for size overflow when
3251 calculating size of args2.
3252 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3253 Normally we prefer signed values, but sticking with ptrdiff_t would
3254 require adding more-complicated checks.
3255
3256 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3257 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3258 Redo buffer-overflow calculations to avoid integer overflow.
3259 Add a FIXME comment where memory seems to be over-allocated.
3260
3261 * character.c (Fstring): Check for size-calculation overflow.
3262
3263 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3264 unnecessary integer overflow. Check for size overflow.
3265 (encode_coding_object): Don't update size until xmalloc succeeds.
3266
3267 * composite.c (get_composition_id): Check for overflow in glyph
3268 length calculations.
3269
3270 Integer and memory overflow fixes for display code.
3271 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3272 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3273 (scrolling_window): Check for overflow in size calculations.
3274 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3275 Don't assume glyph table len fits in int.
3276 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3277 (row_table_size): Now ptrdiff_t, not int.
3278 (scrolling_window): Avoid overflow in size calculations.
3279 Don't update size until allocation succeeds.
3280 * fns.c (concat): Check for overflow in size calculations.
3281 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3282 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3283 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3284
3285 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3286 (get_doc_string): Check for size calculation overflow.
3287 Don't update size until allocation succeeds.
3288 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3289 EMACS_INT, where ptrdiff_t will do.
3290 (Fsubstitute_command_keys): Check for string overflow.
3291
3292 * editfns.c (set_time_zone_rule): Don't assume environment length
3293 fits in int.
3294 (message_length): Now ptrdiff_t, not int.
3295 (Fmessage_box): Don't update size until allocation succeeds.
3296 Don't assume message length fits in int.
3297 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3298
3299 * emacs.c (main): Do not reallocate argv, since there is a null at
3300 the end that can be overwritten, and this way there's no need to
3301 worry about size-calculation overflow.
3302 (sort_args): Check for size-calculation overflow.
3303
3304 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3305 alloc succeeds.
3306 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3307
3308 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3309 (x_set_scroll_bar_width, x_figure_window_size):
3310 Check for integer overflow.
3311 (x_set_alpha): Do not assume XINT fits in int.
3312
3313 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3314 This is for the members text_lines, text_cols, total_lines, total_cols,
3315 where the system imposes an 'int' limit.
3316
3317 * fringe.c (Fdefine_fringe_bitmap):
3318 Don't update size until alloc works.
3319
3320 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3321 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3322
3323 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3324 Check for size-calculation overflow.
3325 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3326 do, as we prefer signed integers.
3327 (id_to_widget.max_size, id_to_widget.used)
3328 (xg_store_widget_in_map, xg_remove_widget_from_map)
3329 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3330 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3331 Use and return ptrdiff_t, not int.
3332 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3333 * gtkutil.h: Change prototypes to match the above.
3334
3335 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3336 are duplicate now that they've been promoted to lisp.h.
3337 (x_allocate_bitmap_record, x_alloc_image_color)
3338 (make_image_cache, cache_image, xpm_load):
3339 Don't update size until alloc is done.
3340 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3341 (x_detect_edges):
3342 Check for size calculation overflow.
3343 (ct_colors_allocated_max): New constant.
3344 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3345 overflow.
3346
3347 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3348 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3349 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3350 Use ptrdiff_t, not int, to count maps.
3351 (read_char_minibuf_menu_prompt): Check for overflow in size
3352 calculations. Don't update size until allocation succeeds.
3353 Redo calculations to avoid overflow.
3354 * keyboard.h: Change prototypes to match the above.
3355
3356 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3357 to count maps.
3358 (current_minor_maps): Check for size calculation overflow.
3359 * keymap.h: Change prototypes to match the above.
3360
3361 * lread.c (read1, init_obarray): Don't update size until alloc done.
3362
3363 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3364 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3365
3366 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3367 Now ptrdiff_t, not int.
3368 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3369 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3370
3371 * process.c (Fnetwork_interface_list): Check for overflow
3372 in size calculation.
3373
3374 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3375
3376 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3377 overflow. Don't bother calling xmalloc when xrealloc will do.
3378
3379 * search.c (Freplace_match): Check for size calculation overflow.
3380 (Fset_match_data): Don't assume list lengths fit in 'int'.
3381
3382 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3383 for command line length. Do not attempt to address one before the
3384 beginning of an array, as that's not portable.
3385
3386 * term.c (max_frame_lines): Remove; unused.
3387 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3388 not int.
3389 (encode_terminal_code, calculate_costs): Check for size
3390 calculation overflow.
3391 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3392 table lengths and related sizes. Don't update size until alloc
3393 done. Redo calculations to avoid overflow.
3394 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3395
3396 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3397 subtracting pointers.
3398 (gobble_line): Check for overflow more carefully. Don't update size
3399 until alloc done.
3400
3401 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3402 Don't update size until alloc done.
3403 Redo size calculations to avoid overflow.
3404 Check for size calculation overflow.
3405 (main) [DEBUG]: Fix typo in invoking tparam1.
3406
3407 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3408 Use ptrdiff_t, not int, for sizes.
3409 (store_mode_line_noprop_char): Don't update size until alloc done.
3410
3411 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3412 Use ptrdiff_t, not int, for sizes.
3413 (Finternal_make_lisp_face, cache_face):
3414 Check for size calculation overflow.
3415 (cache_face): Treat size calculation overflows as if they were
3416 memory exhaustion (the usual treatment), rather than aborting.
3417
3418 * xfns.c (x_encode_text, x_set_name_internal)
3419 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3420 sizes, since they can exceed INT_MAX in size. Check for size
3421 calculation overflow.
3422
3423 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3424 (xg_select): Check for size calculation overflow.
3425 Don't update size until alloc done.
3426
3427 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3428 as sprintf is limited to int lengths.
3429
3430 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3431 (X_LONG_MIN): New macros.
3432 Use them to make the following changes clearer.
3433 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3434 This change doesn't affect the value now, but it may help remind
3435 future maintainers not to raise the value too much later.
3436 (SELECTION_QUANTUM): Remove, replacing with ...
3437 (selection_quantum): ... new function, which avoids overflow.
3438 All uses changed.
3439 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3440 assumption that selection length fits in 'int'.
3441 (x_reply_selection_request, x_handle_selection_request)
3442 (x_get_window_property, receive_incremental_selection)
3443 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3444 (lisp_data_to_selection_data, clean_local_selection_data):
3445 Use ptrdiff_t, not int, to record length of selection.
3446 (x_reply_selection_request, x_get_window_property)
3447 (receive_incremental_selection, x_property_data_to_lisp):
3448 Redo calculations to avoid overflow.
3449 (x_reply_selection_request): When sending hint, ceiling it at
3450 X_LONG_MAX rather than relying on wraparound overflow to send
3451 something.
3452 (x_get_window_property, receive_incremental_selection)
3453 (lisp_data_to_selection_data, x_property_data_to_lisp):
3454 Check for size-calculation overflow.
3455 (x_get_window_property, receive_incremental_selection)
3456 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3457 Don't store size until memory allocation succeeds.
3458 (x_get_window_property): Plug memory leak on memory exhaustion.
3459 Don't double-block input; malloc is safe here. Don't assume 2**34
3460 - 4 fits in unsigned long. Add an xassert to check
3461 XGetWindowProperty overflow. Be more careful about overflow
3462 calculations, and distinguish size from memory overflow better.
3463 (receive_incremental_selection): When tracing, don't assume
3464 unsigned int is less than INT_MAX.
3465 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3466 harmful) conversions of unsigned short to int.
3467 (lisp_data_to_selection_data): Don't assume that integers
3468 in the range -65535 through -1 fit in an X unsigned short.
3469 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3470 result parameters unless successful. Rely on cons_to_unsigned
3471 to report problems with elements; the old code wasn't right anyway.
3472 (x_check_property_data): Check for int overflow; we cannot use
3473 a wider type due to X limits.
3474 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3475
3476 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3477
3478 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3479 (x_term_init): Check for size calculation overflow.
3480 (x_color_cells): Don't store size until memory allocation succeeds.
3481 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3482 Don't assume alloca size is less than MAX_ALLOCA.
3483 (x_term_init): Don't assume length fits in int (sprintf is limited
3484 to int size).
3485
3486 Use ptrdiff_t for composition IDs.
3487 * character.c (lisp_string_width):
3488 * composite.c (composition_table_size, n_compositions)
3489 (get_composition_id, composition_gstring_from_id):
3490 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3491 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3492 * window.c (Frecenter):
3493 Use ptrdiff_t, not int, for composition IDs.
3494 * composite.c (get_composition_id): Check for integer overflow.
3495 * composite.h: Adjust prototypes to match the above changes.
3496
3497 Use ptrdiff_t for hash table indexes.
3498 * category.c (hash_get_category_set):
3499 * ccl.c (ccl_driver):
3500 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3501 * coding.c (coding_system_charset_list, detect_coding_system):
3502 * coding.h (struct coding_system.id):
3503 * composite.c (get_composition_id, gstring_lookup_cache):
3504 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3505 * image.c (xpm_get_color_table_h):
3506 * lisp.h (hash_lookup, hash_put):
3507 * minibuf.c (Ftest_completion):
3508 Use ptrdiff_t for hash table indexes, not int (which is too
3509 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3510 32-bit --with-wide-int hosts).
3511
3512 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3513 Add a FIXME comment about memory leaks.
3514 (syms_of_charset): Don't assume xmalloc returns.
3515
3516 Don't assume that stated character widths fit in int.
3517 * character.c (Fchar_width, c_string_width, lisp_string_width):
3518 * character.h (CHAR_WIDTH):
3519 * indent.c (MULTIBYTE_BYTES_WIDTH):
3520 Use sanitize_char_width to avoid undefined and/or bad behavior
3521 with outlandish widths.
3522 * character.h (sanitize_tab_width): Rename from sanitize_width,
3523 now that we have two such functions. All uses changed.
3524 (sanitize_char_width): New inline function.
3525
3526 Don't assume that tab-width fits in int.
3527 * character.h (sanitize_width): New inline function.
3528 (SANE_TAB_WIDTH): New macro.
3529 (ASCII_CHAR_WIDTH): Use it.
3530 * indent.c (sane_tab_width): Remove. All uses replaced by
3531 SANE_TAB_WIDTH (current_buffer).
3532 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3533
3534 * fileio.c: Integer overflow issues with file modes.
3535 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3536
3537 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3538 Remove unreachable code.
3539 (read_hex, load_charset_map_from_file): Check for integer overflow.
3540
3541 * xterm.c: Don't go over XClientMessageEvent limit.
3542 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3543 (x_send_scroll_bar_event): Likewise. Check that the size does not
3544 exceed limits imposed by XClientMessageEvent, as well as the usual
3545 ptrdiff_t and size_t limits.
3546
3547 * keyboard.c: Overflow, signedness and related fixes.
3548 (make_lispy_movement): Use same integer type in forward decl
3549 that is used in the definition.
3550 (read_key_sequence, keyremap_step):
3551 Change bufsize argument back to int, undoing my 2011-03-30 change.
3552 We prefer signed types, and int is wide enough here.
3553 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3554 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3555 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3556 length, not size_t. Use ptrdiff_t for index, not int.
3557 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3558 possibility of integer overflow.
3559
3560 Overflow, signedness and related fixes for images.
3561
3562 * dispextern.h (struct it.stack[0].u.image.image_id)
3563 (struct_it.image_id, struct image.id, struct image_cache.size)
3564 (struct image_cache.used, struct image_cache.ref_count):
3565 * gtkutil.c (update_frame_tool_bar):
3566 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3567 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3568 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3569 * nsmenu.m (update_frame_tool_bar):
3570 * xdisp.c (calc_pixel_width_or_height):
3571 * xfns.c (image_cache_refcount):
3572 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3573 on typical 64-bit hosts.
3574
3575 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3576 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3577 Omit unnecessary casts to int.
3578 (parse_image_spec): Check that integers fall into 'int' range
3579 when the callers expect that.
3580 (image_ascent): Redo ascent calculation to avoid int overflow.
3581 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3582 (lookup_image): Remove unnecessary tests.
3583 (xbm_image_p): Locals are now of int, not EMACS_INT,
3584 since parse_image_check makes sure they fit into int.
3585 (png_load, gif_load, svg_load_image):
3586 Prefer int to unsigned where either will do.
3587 (tiff_handler): New function, combining the cores of the
3588 old tiff_error_handler and tiff_warning_handler.
3589 This function is rewritten to use vsnprintf and thereby avoid
3590 stack buffer overflows. It uses only the features of vsnprintf
3591 that are common to both POSIX and native Microsoft.
3592 (tiff_error_handler, tiff_warning_handler): Use it.
3593 (tiff_load, gif_load, imagemagick_load_image):
3594 Don't assume :index value fits in 'int'.
3595 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3596 (imagemagick_load_image): Check that crop parameters fit into
3597 the integer types that MagickCropImage accepts. Don't assume
3598 Vimagemagick_render_type has a nonnegative value. Don't assume
3599 size_t fits in 'long'.
3600 (gs_load): Use printmax_t to print the widest integers possible.
3601 Check for integer overflow when computing image height and width.
3602
3603 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3604
3605 * xdisp.c (redisplay_window): Don't force window start if point
3606 will be invisible in the resulting window. (Bug#9324)
3607
3608 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3609
3610 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3611 the display spec is of the form `(space ...)'.
3612 (handle_display_spec): Return the value returned by
3613 handle_single_display_spec, not just 1 or zero.
3614 (handle_single_display_spec): If the display spec is of the form
3615 `(space ...)', and specifies display in the text area, return 2
3616 rather than 1.
3617 (try_cursor_movement): Check for the need to scroll more
3618 accurately, and prefer exact match for point under bidi.
3619 Don't advance `row' beyond the last row of the window.
3620
3621 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3622 into disp_prop; all users changed.
3623
3624 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3625 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3626 for the text covered by the display property.
3627
3628 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3631 Change return value to nil.
3632 (Frecord_buffer): Delete unused function.
3633
3634 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3635
3636 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3637 buffers, return left-to-right.
3638 (set_cursor_from_row): Consider candidate row a win if its glyph
3639 represents a newline and point is on that newline. Fixes cursor
3640 positioning on the newline at EOL of R2L text within L2R
3641 paragraph, and vice versa.
3642 (try_cursor_movement): Check continued rows, in addition to
3643 continuation rows. Fixes unwarranted scroll when point enters a
3644 continued line of R2L text within an L2R paragraph, or vice versa.
3645 (cursor_row_p): Consider the case of point being equal to
3646 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3647 from the end of a short line to the beginning of a continued line
3648 of R2L text within L2R paragraph.
3649 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3650 composed characters.
3651
3652 * bidi.c (bidi_check_type): Use xassert.
3653 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3654 members.
3655
3656 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3657
3658 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3659 a character.
3660
3661 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3662
3663 * nsfont.m (ns_otf_to_script): Fix typo.
3664
3665 2011-08-22 Kenichi Handa <handa@m17n.org>
3666
3667 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3668 extra slot even if the purpose is char-code-property-table.
3669
3670 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3671
3672 * xdisp.c (redisplay_window): When computing centering_position,
3673 account for the height of the header line. (Bug#8874)
3674
3675 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3676 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3677 candidate is selected by the mouse, and that candidate has a
3678 composed character under the mouse.
3679
3680 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3681 coordinates reported by pos-visible-in-window-p for a composed
3682 character in column zero.
3683
3684 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3685
3686 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3687
3688 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3689
3690 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3691 consider it a hit if to_charpos is anywhere in the range of the
3692 composed buffer positions.
3693
3694 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3695
3696 * image.c (gif_load): Don't assume that each subimage has the same
3697 dimensions as the base image. Handle disposal method that is
3698 "undefined" by the gif spec (Bug#9335).
3699
3700 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3701
3702 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3703 (Fcondition_case): Document `debug' symbol in error handler.
3704
3705 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3706
3707 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3708 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3709 from an Org mode buffer to a Speedbar frame.
3710
3711 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3712 a composition, take its buffer position from IT->cmp_it.charpos.
3713 Fixes cursor positioning at the beginning of a line that begins
3714 with a composed character.
3715
3716 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3717
3718 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3719 character bidirectional type, use STRONG_L instead. Fixes crashes
3720 in a buffer produced by `describe-categories'.
3721
3722 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3723 members before the level stack, so they would be saved and
3724 restored when copying iterator state. Fixes incorrect reordering
3725 around TABs covered by display properties.
3726
3727 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3728
3729 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3730
3731 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3732
3733 * eval.c (internal_condition_case, internal_condition_case_1)
3734 (internal_condition_case_2, internal_condition_case_n):
3735 Remove unnecessary aborts (Bug#9081).
3736
3737 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3738
3739 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3740 has no `load' handler, try opening the file locally. (Bug#9311)
3741
3742 2011-08-16 Ken Brown <kbrown@cornell.edu>
3743
3744 * gmalloc.c: Expand comment.
3745
3746 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3747
3748 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3749 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3750
3751 2011-08-16 Ken Brown <kbrown@cornell.edu>
3752
3753 Fix memory allocation problems in Cygwin build (Bug#9273).
3754
3755 * unexcw.c ( __malloc_initialized): Declare external variable.
3756 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3757
3758 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3759 New variables.
3760 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3761 dumped emacs.
3762 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3763 in the static heap.
3764 [CYGWIN] (special_realloc): New function.
3765 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3766 requests to realloc storage in the static heap.
3767
3768 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * bidi.c (bidi_initialize): Remove unused local.
3771
3772 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3773
3774 * bidimirror.h:
3775 * biditype.h: Remove file.
3776 * makefile.w32-in ($(BLD)/bidi.$(O)):
3777 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3778
3779 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3780
3781 * chartab.c: Improve commentary for the uniprop_table API.
3782
3783 * bidi.c (bidi_paragraph_init): Support zero value of
3784 bidi_ignore_explicit_marks_for_paragraph_level.
3785 (bidi_initialize): Use uniprop_table instead of including
3786 biditype.h and bidimirror.h.
3787
3788 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3789 coordinates of the iterator when restoring from ppos_it.
3790 (Bug#9296)
3791
3792 2011-08-14 Kenichi Handa <handa@m17n.org>
3793
3794 * process.c (create_process): Call setup_process_coding_systems
3795 after the pid of the process is set to -1 (Bug#8162).
3796
3797 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3798
3799 * xdisp.c (move_it_in_display_line_to): Don't invoke
3800 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3801 ppos_it. Fixes vertical cursor motion when line beginning is
3802 covered by an image. (Bug#9296)
3803
3804 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3805
3806 * nsterm.h (ns_run_ascript): Declare.
3807 (NSAPP_DATA2_RUNASSCRIPT): Define.
3808
3809 * nsfns.m (as_script, as_result, as_status): New static variables.
3810 (ns_run_ascript): New function.
3811 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3812 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3813 the event loop. Get status from as_status (Bug#7276).
3814
3815 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3816 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3817 the event loop (Bug#7276).
3818
3819 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3820
3821 * gnutls.c (QCgnutls_bootprop_priority)
3822 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3823 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3824 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3825 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3826 (QCgnutls_bootprop_verify_hostname_error)
3827 (QCgnutls_bootprop_callbacks_verify): Rename from
3828 Qgnutls_bootprop_..., all uses changed.
3829
3830 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3831 uses changed.
3832
3833 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 * xfaces.c (Qframe_set_background_mode): Now static.
3836 * dispextern.h (Qframe_set_background_mode): Remove decl.
3837
3838 * process.c (Fnetwork_interface_info): Declare local only if needed.
3839
3840 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3841
3842 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3843 (Fnetwork_interface_list): Allocate in increments of bytes instead
3844 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3845 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3846 sockaddr.
3847 (struct ifflag_def): notrailers is smart on OSX.
3848 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3849 Get hardware address with getifaddrs if available.
3850
3851 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3852
3853 * xdisp.c (iterate_out_of_display_property): xassert that
3854 IT->position is set to within IT->object's boundaries. Break from
3855 the loop as soon as EOB is reached; avoids infloops in redisplay
3856 when IT->position is set up wrongly due to some bug.
3857 Set IT->current to match the bidi iterator unconditionally.
3858 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3859 entry. Force push_it to save on the stack the current
3860 buffer/string position, to be restored by pop_it. Fix flags in
3861 the iterator structure wrt the object coming from a display
3862 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3863 properties. (Bug#9284)
3864
3865 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3866
3867 * fontset.c (fontset_get_font_group): Add proper type checks.
3868 (Bug#9172)
3869
3870 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3871
3872 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3873 and LC_VERSION_MIN_MACOSX.
3874 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3875 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3876
3877 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3878
3879 * xdisp.c (forward_to_next_line_start): Allow to use the
3880 no-display-properties-and-no-overlays under bidi display.
3881 Set disp_pos in the bidi iterator to avoid searches for display
3882 properties and overlays.
3883
3884 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3885
3886 * editfns.c (Fset_time_zone_rule): Document relationship with the
3887 setenv function.
3888
3889 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3890 the font entity extracted from the cache (Bug#8109).
3891
3892 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3893
3894 * composite.c (autocmp_chars): Don't reset point. That is done by
3895 restore_point_unwind (Bug#5984).
3896
3897 2011-08-07 Juri Linkov <juri@jurta.org>
3898
3899 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3900 to show the arg `TIME' instead of `TIMEVAL'.
3901
3902 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3905 display property strides EOL and includes a newline, as in
3906 longlines-mode. (Bug#9254)
3907 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3908 word-wrap under bidirectional display. (Bug#9224)
3909
3910 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3911 is non-zero, even if the data buffer is NULL. Fixes a crash in
3912 vertical-motion with longlines-mode. (Bug#9254)
3913
3914 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3915
3916 * bidi.c <bidi_cache_total_alloc>: Now static.
3917 (bidi_initialize): Initialize bidi_cache_total_alloc.
3918
3919 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3920 cache. (Bug#9221)
3921
3922 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3923 amount allocated this far in `bidi_cache_total_alloc'.
3924 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3925 non-zero, only free the data buffer without restoring the cache
3926 contents. All callers changed.
3927
3928 * dispextern.h (bidi_unshelve_cache): Update prototype.
3929
3930 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3931 (move_it_in_display_line, move_it_to)
3932 (move_it_vertically_backward, move_it_by_lines): Replace the call
3933 to xfree to an equivalent call to bidi_unshelve_cache.
3934 (move_it_in_display_line_to): Fix logic of returning
3935 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3936
3937 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3938
3939 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3940 came from a string character with a `cursor' property. (Bug#9229)
3941
3942 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3943
3944 * Makefile.in (LIB_PTHREAD): New variable.
3945 (LIBES): Add LIB_PTHREAD (Bug#9216).
3946
3947 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3948 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3949
3950 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3951
3952 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3953
3954 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3955
3956 * xterm.c (x_find_topmost_parent): New function.
3957 (x_set_frame_alpha): Find topmost parent window with
3958 x_find_topmost_parent and set the property there also (bug#9181).
3959 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3960
3961 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3962
3963 * callproc.c (Fcall_process): Avoid vfork clobbering
3964 the local vars buffer, coding_systems, current_dir.
3965
3966 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3967
3968 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3969
3970 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3973 so that it is not optimized away.
3974
3975 * xdisp.c (compute_display_string_pos): Remove unused local.
3976
3977 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3978
3979 Fix slow cursor motion and scrolling in large buffers with
3980 selective display, like Org Mode buffers. (Bug#9218)
3981
3982 * dispextern.h (struct bidi_it): New member disp_prop_p.
3983
3984 * xdisp.c: Remove one-slot cache of display string positions.
3985 (compute_display_string_pos): Accept an additional argument
3986 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3987 for a display string or property. If found, set DISP_PROP_P
3988 non-zero.
3989
3990 * bidi.c (bidi_fetch_char): Accept an additional argument
3991 DISP_PROP_P, and pass it to compute_display_string_pos.
3992 Only handle text covered by a display string if DISP_PROP_P is returned
3993 non-zero. All callers of bidi_fetch_char changed.
3994
3995 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3996
3997 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3998
3999 2010-12-03 Don March <don@ohspite.net>
4000
4001 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4002 last character M-[char] is translated to ESC [char] (bug#7541).
4003
4004 2011-08-02 Kenichi Handa <handa@m17n.org>
4005
4006 * lisp.h (uniprop_table): Extern it.
4007
4008 * chartab.c (uniprop_table): Make it non-static.
4009
4010 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4011
4012 * xdisp.c (forward_to_next_line_start): Accept additional argument
4013 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4014 on the newline.
4015 (reseat_at_next_visible_line_start): Use the bidi iterator state
4016 returned by forward_to_next_line_start to restore the state of
4017 it->bidi_it after backing up to previous newline. (Bug#9212)
4018
4019 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4020
4021 * regex.c (re_comp): Protoize.
4022 (re_exec): Fix return type.
4023 (regexec): Fix type of `ret'. (Bug#9203)
4024
4025 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4028 This is needed if max-image-size is a floating-point number.
4029
4030 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4031
4032 * print.c (print_object): Print empty symbol as ##.
4033
4034 * lread.c (read1): Read ## as empty symbol.
4035
4036 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4037
4038 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4039 setting frame foreground color (Bug#9175).
4040 (x_set_background_color): Likewise.
4041
4042 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4043 contents (Bug#9176).
4044 (EmacsTooltip -init): Remove bezels and add shadows to
4045 tooltip windows.
4046
4047 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4048 or scroll bar (Bug#8470).
4049
4050 * nsfont.m (nsfont_open): Remove assignment to voffset and
4051 unnecessary vars hshink, expand, hd, full_height, min_height.
4052 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4053
4054 * nsterm.h (nsfont_info): Remove voffset field.
4055
4056 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4057
4058 Implement strike-through and overline on NextStep (Bug#8863).
4059
4060 * nsfont.m (nsfont_open): Use underline position provided by font,
4061 instead of hard-coded value of 2.
4062 (nsfont_draw): Call ns_draw_text_decoration instead.
4063
4064 * nsterm.h: Add declaration for ns_draw_text_decoration.
4065
4066 * nsterm.m (ns_draw_text_decoration): New function for drawing
4067 underline, overline, and strike-through.
4068 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4069 ns_draw_text_decoration. Change treatment of cursor drawing to
4070 accommodate underlining, etc.
4071
4072 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4073
4074 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4075 default.
4076
4077 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4080 Without this fix, if a signal arrives just after memory fills up,
4081 'malloc' might be invoked reentrantly.
4082
4083 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4084 In other words, assume that every image size is allowed, on non-X
4085 hosts. This assumption is probably wrong, but it lets Emacs compile.
4086
4087 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4088
4089 * regex.c (re_iswctype): Convert return values to boolean.
4090
4091 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4092
4093 * xdisp.c (compute_display_string_pos): Don't use cached display
4094 string position if the buffer had its restriction changed.
4095 (Bug#9184)
4096
4097 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4100
4101 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4102
4103 Integer signedness and overflow and related fixes. (Bug#9079)
4104
4105 * bidi.c: Integer size and overflow fixes.
4106 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4107 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4108 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4109 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4110 (bidi_find_other_level_edge):
4111 Use ptrdiff_t instead of EMACS_INT where either will do.
4112 This works better on 32-bit hosts configured --with-wide-int.
4113 (bidi_cache_ensure_space): Check for size-calculation overflow.
4114 Use % rather than repeated addition, for better worst-case speed.
4115 Don't set bidi_cache_size until after xrealloc returns, because it
4116 might not return.
4117 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4118 (bidi_cache_ensure_space): Also check that the bidi cache size
4119 does not exceed that of the largest Lisp string or buffer. See Eli
4120 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4121
4122 * alloc.c (__malloc_size_t): Remove.
4123 All uses replaced by size_t. See Andreas Schwab's note
4124 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4125
4126 * image.c: Improve checking for integer overflow.
4127 (check_image_size): Assume that f is nonnull, since
4128 it is always nonnull in practice. This is one less thing to
4129 worry about when checking for integer overflow later.
4130 (x_check_image_size): New function, which checks for integer
4131 overflow issues inside X.
4132 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4133 This removes the need for a memory_full check.
4134 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4135 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4136 (xbm_read_bitmap_data): Change locals back to 'int', since
4137 their values must fit in 'int'.
4138 (xpm_load_image, png_load, tiff_load):
4139 Invoke x_create_x_image_and_pixmap earlier,
4140 to avoid much needless work if the image is too large.
4141 (tiff_load): Treat overly large images as if
4142 x_create_x_image_and_pixmap failed, not as malloc failures.
4143 (gs_load): Use x_check_image_size.
4144
4145 * gtkutil.c: Omit integer casts.
4146 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4147 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4148
4149 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4150
4151 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4152 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4153 would wrongly return t on a 64-bit host.
4154
4155 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4156 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4157 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4158 and therefore cause GCC to emit a bogus diagnostic in some cases.
4159
4160 * image.c: Integer signedness and overflow and related fixes.
4161 This is not an exhaustive set of fixes, but it's time to
4162 record what I've got.
4163 (lookup_pixel_color, check_image_size): Remove redundant decls.
4164 (check_image_size): Don't assume that arbitrary EMACS_INT values
4165 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4166 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4167 (tiff_load, imagemagick_load_image):
4168 Check for overflow in size calculations.
4169 (x_create_x_image_and_pixmap): Remove unnecessary test for
4170 xmalloc returning NULL; that can't happen.
4171 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4172 (xpm_color_bucket): Use better integer hashing function.
4173 (xpm_cache_color): Don't possibly over-allocate memory.
4174 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4175 (gif_memory_source):
4176 Use ptrdiff_t, not int or size_t, to record sizes.
4177 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4178 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4179 either works, as we prefer signed integers.
4180 (tiff_read_from_memory, tiff_write_from_memory):
4181 Return tsize_t, not size_t, since that's what the TIFF API wants.
4182 (tiff_read_from_memory): Don't fail simply because the read would
4183 go past EOF; instead, return a short read.
4184 (tiff_load): Omit no-longer-needed casts.
4185 (Fimagemagick_types): Don't assume size fits into 'int'.
4186
4187 Improve hashing quality when configured --with-wide-int.
4188 * fns.c (hash_string): New function, taken from sxhash_string.
4189 Do not discard information about ASCII character case; this
4190 discarding is no longer needed.
4191 (sxhash-string): Use it. Change sig to match it. Caller changed.
4192 * lisp.h: Declare it.
4193 * lread.c (hash_string): Remove, since we now use fns.c's version.
4194 The fns.c version returns a wider integer if --with-wide-int is
4195 specified, so this should help the quality of the hashing a bit.
4196
4197 * emacs.c: Integer overflow minor fix.
4198 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4199 Define only if GNU_LINUX.
4200 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4201
4202 * dispnew.c: Integer signedness and overflow fixes.
4203 Remove unnecessary forward decls, that were a maintenance hassle.
4204 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4205 All uses changed.
4206 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4207 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4208 (prepare_desired_row, line_draw_cost):
4209 Use int, not unsigned, where either works.
4210 (save_current_matrix, restore_current_matrix):
4211 Use ptrdiff_t, not size_t, where either works.
4212 (init_display): Check for overflow more accurately, and without
4213 relying on undefined behavior.
4214
4215 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4216 Remove, replacing with the new symbols in lisp.h. All uses changed.
4217 * fileio.c (make_temp_name):
4218 * filelock.c (lock_file_1, lock_file):
4219 * xdisp.c (message_dolog):
4220 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4221 Use pMd etc. instead.
4222 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4223 replacing the pWIDE etc. symbols removed from editfns.c.
4224
4225 * keyboard.h (num_input_events): Now uintmax_t.
4226 This is (very slightly) less likely to mess up due to wraparound.
4227 All uses changed.
4228
4229 * buffer.c: Integer signedness fixes.
4230 (alloc_buffer_text, enlarge_buffer_text):
4231 Use ptrdiff_t rather than size_t when either will do, as we prefer
4232 signed integers.
4233
4234 * alloc.c: Integer signedness and overflow fixes.
4235 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4236 (__malloc_size_t): Default to size_t, not to int.
4237 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4238 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4239 Prefer ptrdiff_t to size_t when either would do, as we prefer
4240 signed integers.
4241 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4242 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4243 Now const. Initialize with values that are in range even if char
4244 is signed.
4245 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4246 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4247 These functions do the right thing with sizes > 2**32.
4248 (check_depth): Now ptrdiff_t, not int.
4249 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4250 Adjust to new way of storing sizes. Check for size overflow bugs
4251 in rest of code.
4252 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4253 slightly wrong anyway, as it missed one instance of
4254 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4255 (refill_memory_reserve): Omit needless cast to size_t.
4256 (mark_object_loop_halt): Mark as externally visible.
4257
4258 * xselect.c: Integer signedness and overflow fixes.
4259 (Fx_register_dnd_atom, x_handle_dnd_message):
4260 Use ptrdiff_t, not size_t, since we prefer signed.
4261 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4262 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4263 x_dnd_atoms_size and x_dnd_atoms_length.
4264
4265 * doprnt.c: Prefer signed to unsigned when either works.
4266 * eval.c (verror):
4267 * doprnt.c (doprnt):
4268 * lisp.h (doprnt):
4269 * xdisp.c (vmessage):
4270 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4271 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4272 prefer signed arithmetic to avoid comparison confusion.
4273 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4274 but is a bit tricky.
4275
4276 Assume freestanding C89 headers, string.h, stdlib.h.
4277 * data.c, doprnt.c, floatfns.c, print.c:
4278 Include float.h unconditionally.
4279 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4280 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4281 * regex.c: Likewise for stddef.h, string.h.
4282 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4283 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4284 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4285 (STDC_HEADERS): Remove obsolete defines.
4286 * sysdep.c: Include limits.h unconditionally.
4287
4288 Assume support for memcmp, memcpy, memmove, memset.
4289 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4290 * regex.c (memcmp, memcpy):
4291 Remove; we assume C89 now.
4292
4293 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4294 (__malloc_safe_bcopy): Remove; no longer needed.
4295
4296 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4297 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4298 well either way, and we prefer signed to unsigned.
4299
4300 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4301
4302 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4303 closes the connection while we're reading (bug#9182).
4304
4305 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4306
4307 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4308 are specified (Bug#9168).
4309
4310 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4313 Found by GCC static checking and --with-wide-int on a 32-bit host.
4314
4315 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4316
4317 * xdisp.c (compute_display_string_pos): Fix logic of caching
4318 previous display string position. Initialize cached_prev_pos to
4319 -1. Fixes slow-down at the beginning of a buffer.
4320
4321 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4322
4323 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4324 for attrs[LFACE_FONTSET_INDEX].
4325
4326 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 * xml.c (parse_region): Remove unused local
4329 that was recently introduced.
4330
4331 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4332
4333 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4334 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4335
4336 * xdisp.c (move_it_in_display_line_to): Record the best matching
4337 position for TO_CHARPOS while scanning the line, and restore it on
4338 exit if none of the characters scanned was an exact match.
4339 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4340 when exact match is impossible due to invisible text, and the
4341 lines are truncated.
4342
4343 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4344
4345 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4346 for OSX >= 10.7.
4347
4348 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4349
4350 Fix a significant slow-down of cursor motion with C-n, C-p,
4351 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4352 auto-repeat under bidi redisplay in fontified buffers.
4353 * xdisp.c (compute_stop_pos_backwards): New function.
4354 (next_element_from_buffer): Call compute_stop_pos_backwards to
4355 find a suitable prev_stop when we find ourselves before
4356 base_level_stop.
4357 (reseat): Don't look for prev_stop, as that could mean a very long
4358 run.
4359 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4360 <cached_disp_overlay_modiff>: Cache for last found display string
4361 position.
4362 (compute_display_string_pos): Return the cached position if asked
4363 about the same buffer in the same area of character positions, and
4364 the buffer wasn't changed since the time the display string
4365 position was cached.
4366
4367 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4368
4369 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4370 is an integer, which is important for empty lines. (Bug#9149)
4371
4372 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4373
4374 * frame.c (Fmodify_frame_parameters): In tty case, update the
4375 default face if necessary (Bug#4238).
4376
4377 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4378
4379 * editfns.c (Fstring_to_char): No need to explain what a character
4380 is in the docstring (Bug#6576).
4381
4382 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4383
4384 * xml.c (parse_region): Make sure we always return a tree.
4385
4386 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4387
4388 * xml.c (parse_region): If a document contains only comments,
4389 return that, too.
4390
4391 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4392
4393 * xml.c (make_dom): Return comments, too.
4394
4395 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4396
4397 Port to OpenBSD.
4398 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4399 and the surrounding thread.
4400 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4401 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4402 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4403 timer goes off.
4404 * s/openbsd.h (BROKEN_SIGIO): Define.
4405 * unexelf.c (unexec) [__OpenBSD__]:
4406 Don't update the .mdebug section of the Alpha COFF symbol table.
4407
4408 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4409
4410 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4411 (bug#8460).
4412
4413 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4416 This fixes some race conditions on the permissions of any newly
4417 created file.
4418
4419 * alloc.c (valid_pointer_p): Use pipe, not open.
4420 This fixes some permissions issues when debugging.
4421
4422 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4423 If fchown fails to set both uid and gid, try to set just gid,
4424 as that is sometimes allowed. Adjust the file's mode to eliminate
4425 setuid or setgid bits that are inappropriate if fchown fails.
4426
4427 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4428
4429 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4430 to compare Lisp_Objects.
4431 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4432 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4433 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4434
4435 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4436
4437 * lread.c (read_integer): Unread even EOF character.
4438 (read1): Likewise. Properly record start position of symbol.
4439
4440 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4441 symbol character follows.
4442
4443 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4444
4445 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4446 This works around a problem with the previous change to Fcopy_file.
4447 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4448 and without this change, GCC might complain about discarding
4449 fchown's return value.
4450
4451 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4454
4455 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4456
4457 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4458
4459 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4460
4461 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4462 it's used from the C level.
4463
4464 * process.c: Use the same condition for POLL_FOR_INPUT in both
4465 keyboard.c and process.c (bug#1858).
4466
4467 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4468
4469 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4470 (Fgnutls_boot): Use it.
4471
4472 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4473
4474 * doc.c (Fsubstitute_command_keys): Revert last change.
4475
4476 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4477
4478 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4479 quotes the next character, and doesn't affect other longer
4480 sequences (bug#8935).
4481
4482 * lread.c (syms_of_lread): Clarify that is isn't only
4483 `eval-buffer' and `eval-defun' that's affected by
4484 `lexical-binding' (bug#8460).
4485
4486 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4487
4488 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4489 bidi redisplay when a line includes both an image and is truncated.
4490
4491 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4492
4493 Fix minor problems found by static checking.
4494 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4495 (elsz): Now a signed constant, not a size_t var. We prefer signed
4496 types to unsigned, to avoid integer comparison confusion. Without
4497 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4498 "cannot optimize loop, the loop counter may overflow", a symptom
4499 of the confusion.
4500 * indent.c (Fvertical_motion): Mark locals as initialized.
4501 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4502
4503 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504
4505 * search.c (Fre_search_backward): Mention `case-fold-search' in
4506 all the re_search_* functions (bug#8138).
4507
4508 * keyboard.c (Fopen_dribble_file): Document when the file is
4509 closed (bug#8056).
4510
4511 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4512
4513 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4514 bidi_cache_idx.
4515
4516 Support bidi reordering of display and overlay strings.
4517 * xdisp.c (compute_display_string_pos)
4518 (compute_display_string_end): Accept additional argument STRING.
4519 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4520 (reseat_to_string): Initialize bidi_it->string.s and
4521 bidi_it->string.schars.
4522 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4523 NULL (avoids a crash in bidi_paragraph_init).
4524 Initialize itb.string.lstring.
4525 (init_iterator): Call bidi_init_it only of a valid
4526 buffer position was specified. Initialize paragraph_embedding to
4527 L2R.
4528 (reseat_to_string): Initialize the bidi iterator.
4529 (display_string): If we need to ignore text properties of
4530 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4531 original value of -1 will not work with bidi.)
4532 (compute_display_string_pos): First arg is now struct
4533 `text_pos *'; all callers changed. Support display properties on
4534 Lisp strings.
4535 (compute_display_string_end): Support display properties on Lisp
4536 strings.
4537 (init_iterator, reseat_1, reseat_to_string): Initialize the
4538 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4539 when iterating on a string not from display properties).
4540 (compute_display_string_pos, compute_display_string_end):
4541 Fix calculation of the object to scan. Fixes an error when using
4542 arrow keys.
4543 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4544 base_level_stop; instead, set base_level_stop to BEGV.
4545 Fixes crashes in vertical-motion.
4546 (next_element_from_buffer): Improve commentary for when
4547 the iterator is before prev_stop.
4548 (init_iterator): Initialize bidi_p from the default value of
4549 bidi-display-reordering, not from buffer-local value. Use the
4550 buffer-local value only if initializing for buffer iteration.
4551 (handle_invisible_prop): Support invisible properties on strings
4552 that are being bidi-reordered.
4553 (set_iterator_to_next): Support bidi reordering of C strings and
4554 Lisp strings.
4555 (next_element_from_string): Support bidi reordering of Lisp
4556 strings.
4557 (handle_stop_backwards): Support Lisp strings as well.
4558 (display_string): Support display of R2L glyph rows.
4559 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4560 (init_iterator): Don't initialize it->bidi_p for strings
4561 here.
4562 (reseat_to_string): Initialize it->bidi_p for strings here.
4563 (next_element_from_string, next_element_from_c_string)
4564 (next_element_from_buffer): Add xassert's for correspondence
4565 between IT's object being iterated and it->bidi_it.string
4566 structure.
4567 (face_before_or_after_it_pos): Support bidi iteration.
4568 (next_element_from_c_string): Handle the case of the first string
4569 character that is not the first one in the visual order.
4570 (get_visually_first_element): New function, refactored from common
4571 parts of next_element_from_buffer, next_element_from_string, and
4572 next_element_from_c_string.
4573 (tool_bar_lines_needed, redisplay_tool_bar)
4574 (display_menu_bar): Force left-to-right direction. Add a FIXME
4575 comment for making that be controlled by a user option.
4576 (push_it, pop_it): Save and restore the state of the
4577 bidi iterator. Save and restore the bidi_p flag.
4578 (pop_it): Iterate out of display property for string iteration as
4579 well.
4580 (iterate_out_of_display_property): Support iteration over strings.
4581 (handle_single_display_spec): Set up it->bidi_it for iteration
4582 over a display string, and call bidi_init_it.
4583 (handle_single_display_spec, next_overlay_string)
4584 (get_overlay_strings_1, push_display_prop): Set up the bidi
4585 iterator for displaying display or overlay strings.
4586 (forward_to_next_line_start): Don't use the shortcut if
4587 bidi-iterating.
4588 (back_to_previous_visible_line_start): If handle_display_prop
4589 pushed the iterator stack, restore the internal state of the bidi
4590 iterator by calling bidi_pop_it same number of times.
4591 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4592 and we are bidi-iterating, don't decrement the iterator position;
4593 instead, set the first_elt flag in the bidi iterator, to produce
4594 the same effect.
4595 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4596 (push_display_prop): xassert that we are iterating a buffer.
4597 (push_it, pop_it): Save and restore paragraph_embedding member.
4598 (handle_single_display_spec, next_overlay_string)
4599 (get_overlay_strings_1, reseat_1, reseat_to_string)
4600 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4601 correctly. Don't assume unibyte strings are not bidi-reordered.
4602 (compute_display_string_pos)
4603 (compute_display_string_end): Fix handling the case of C string.
4604 (push_it, pop_it): Save and restore from_disp_prop_p.
4605 (handle_single_display_spec, push_display_prop): Set the
4606 from_disp_prop_p flag.
4607 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4608 (pop_it): Call iterate_out_of_display_property only if we are
4609 popping after iteration over a string that came from a display
4610 property. Fix a typo in popping stretch info. Add an assertion
4611 for verifying that the iterator position is in sync with the bidi
4612 iterator.
4613 (handle_single_display_spec, get_overlay_strings_1)
4614 (push_display_prop): Fix initialization of paragraph direction for
4615 string when that of the parent object is not yet determined.
4616 (reseat_1): Call bidi_init_it to resync the bidi
4617 iterator with IT's position. (Bug#7616)
4618 (find_row_edges): If ROW->start.pos gives position
4619 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4620 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4621 Reset the from_disp_prop_p flag.
4622 (SAVE_IT, RESTORE_IT): New macros.
4623 (pos_visible_p, face_before_or_after_it_pos)
4624 (back_to_previous_visible_line_start)
4625 (move_it_in_display_line_to, move_it_in_display_line)
4626 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4627 (try_scrolling, redisplay_window, display_line): Use them when
4628 saving a temporary copy of the iterator and restoring it back.
4629 (back_to_previous_visible_line_start, reseat_1)
4630 (init_iterator): Empty the bidi cache "stack".
4631 (move_it_in_display_line_to): If iterator ended up at
4632 EOL, but we never saw any buffer positions smaller than
4633 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4634 motion in bidi-reordered lines.
4635 (move_it_in_display_line_to): Record prev_method and prev_pos
4636 immediately before the call to set_iterator_to_next. Fixes cursor
4637 motion in bidi-reordered lines with stretch glyphs and strings
4638 displayed in margins. (Bug#8133) (Bug#8867)
4639 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4640 TO_CHARPOS.
4641 (pos_visible_p): Support positions in bidi-reordered lines.
4642 Save and restore bidi cache.
4643
4644 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4645 (bidi_paragraph_info): Delete unused struct.
4646 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4647 (bidi_cache_start): New variable.
4648 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4649 to zero.
4650 (bidi_cache_fetch_state, bidi_cache_search)
4651 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4652 (bidi_cache_find, bidi_peek_at_next_level)
4653 (bidi_level_of_next_char, bidi_find_other_level_edge)
4654 (bidi_move_to_visually_next): Compare cache index with
4655 bidi_cache_start rather than with zero.
4656 (bidi_fetch_char): Accept new argument STRING; all callers
4657 changed. Support iteration over a string. Support strings with
4658 display properties. Support unibyte strings. Fix the type of
4659 `len' according to what STRING_CHAR_AND_LENGTH expects.
4660 (bidi_paragraph_init, bidi_resolve_explicit_1)
4661 (bidi_resolve_explicit, bidi_resolve_weak)
4662 (bidi_level_of_next_char, bidi_move_to_visually_next):
4663 Support iteration over a string.
4664 (bidi_set_sor_type, bidi_resolve_explicit_1)
4665 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4666 can now be zero (for strings); special values 0 and -1 were
4667 changed to -1 and -2, respectively.
4668 (bidi_char_at_pos): New function.
4669 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4670 Call it instead of FETCH_MULTIBYTE_CHAR.
4671 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4672 initialized to valid values.
4673 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4674 values.
4675 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4676 the test for valid cached positions. Fix the logic for looking up
4677 the sentinel state in the cache. GCPRO the Lisp string we are
4678 iterating.
4679 (bidi_push_it, bidi_pop_it): New functions.
4680 (bidi_initialize): Initialize the bidi cache start stack pointer.
4681 (bidi_cache_ensure_space): New function, refactored from part of
4682 bidi_cache_iterator_state. Don't assume the required size is just
4683 one BIDI_CACHE_CHUNK away.
4684 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4685 (bidi_count_bytes, bidi_char_at_pos): New functions.
4686 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4687 always valid if bidi_cache_idx is valid.
4688 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4689 is valid if it's going to be used.
4690 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4691 (bidi_cache_fetch_state, bidi_cache_search)
4692 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4693 (bidi_cache_iterator_state, bidi_cache_find)
4694 (bidi_find_other_level_edge, bidi_cache_start_stack):
4695 All variables related to cache indices are now EMACS_INT.
4696
4697 * dispextern.h (struct bidi_string_data): New structure.
4698 (struct bidi_it): New member `string'. Make flag members be 1-bit
4699 fields, and put them last in the struct.
4700 (compute_display_string_pos, compute_display_string_end):
4701 Update prototypes.
4702 (bidi_push_it, bidi_pop_it): Add prototypes.
4703 (struct iterator_stack_entry): New members bidi_p,
4704 paragraph_embedding, and from_disp_prop_p.
4705 (struct it): Member bidi_p is now a bit field 1 bit wide.
4706 (bidi_shelve_cache, bidi_unshelve_cache):
4707 Declare prototypes.
4708
4709 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4710 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4711 and vector-like objects.
4712
4713 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4714 cache around display iteration.
4715
4716 * window.c (Fwindow_end, window_scroll_pixel_based)
4717 (displayed_window_lines, Frecenter): Save and restore the bidi
4718 cache around display iteration.
4719
4720 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4721
4722 * editfns.c (Fdelete_region): Clarify the use of the named
4723 parameters (bug#6788).
4724
4725 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4726
4727 * indent.c (Fvertical_motion): Set and restore w->pointm when
4728 saving and restoring the window's buffer (Bug#9006).
4729
4730 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4731
4732 * editfns.c (Fstring_to_char): Clarify just what is returned
4733 (bug#6576). Text by Eli Zaretskii.
4734
4735 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4736
4737 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4738
4739 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4740
4741 * buffer.c (mmap_find): Fix a typo.
4742
4743 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4744
4745 Fix execution of x selection hooks.
4746 * xselect.c (Qx_lost_selection_functions)
4747 (Qx_sent_selection_functions): New vars.
4748 (syms_of_xselect): DEFSYM them.
4749 (x_handle_selection_request): Pass Qx_sent_selection_functions
4750 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4751 (x_handle_selection_clear,x_clear_frame_selections):
4752 Pass Qx_lost_selection_functions rather than
4753 Vx_lost_selection_functions to Frun_hook_with_args.
4754
4755 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4758 The old code sometimes used this field without initializing it.
4759
4760 * alloc.c (gc_sweep): Don't read past end of array.
4761 In theory, the old code could also have corrupted Emacs internals,
4762 though it'd be very unlikely.
4763
4764 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4765
4766 * character.c (Fcharacterp): Don't advertise optional ignored
4767 argument. (Bug#4026)
4768
4769 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4770
4771 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4772 key" (bug#4257).
4773
4774 * window.c (Fset_window_start): Doc fix (bug#4199).
4775 (Fset_window_hscroll): Ditto.
4776
4777 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4778
4779 Fix minor new problems caught by GCC 4.6.1.
4780 * term.c (init_tty): Remove unused local.
4781 * xsettings.c (store_monospaced_changed): Define this function only
4782 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4783 not used otherwise.
4784
4785 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4786
4787 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4788
4789 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4790
4791 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4792 are the mini-buffer and the echo area (bug#3320).
4793
4794 * term.c (init_tty): Remove support for supdup, c10 and perq
4795 terminals, which are no longer supported (bug#1482).
4796
4797 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4798
4799 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4800
4801 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4802
4803 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4804 for non-popups (Bug#3642).
4805
4806 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4807
4808 * alloc.c (reset_malloc_hooks): Protoize.
4809 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4810 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4811 * cm.c (losecursor): Likewise.
4812 * data.c (fmod): Likewise.
4813 * dispnew.c (swap_glyphs_in_rows): Likewise.
4814 * emacs.c (memory_warning_signal): Likewise.
4815 * floatfns.c (float_error): Likewise.
4816 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4817 (otf_open, font_otf_capability, generate_otf_features)
4818 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4819 Likewise.
4820 * image.c (pbm_read_file): Likewise.
4821 * indent.c (string_display_width): Likewise.
4822 * intervals.c (check_for_interval, search_for_interval)
4823 (inc_interval_count, count_intervals, root_interval)
4824 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4825 * lread.c (defalias): Likewise.
4826 * ralloc.c (r_alloc_check): Likewise.
4827 * regex.c (set_image_of_range_1, set_image_of_range)
4828 (regex_grow_registers): Likewise.
4829 * sysdep.c (strerror): Likewise.
4830 * termcap.c (valid_filename_p, tprint, main): Likewise.
4831 * tparam.c (main): Likewise.
4832 * unexhp9k800.c (run_time_remap, save_data_space)
4833 (update_file_ptrs, read_header, write_header, calculate_checksum)
4834 (copy_file, copy_rest, display_header): Likewise.
4835 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4836 Likewise.
4837 * xdisp.c (check_it): Likewise.
4838 * xfaces.c (register_color, unregister_color, unregister_colors):
4839 Likewise.
4840 * xfns.c (print_fontset_result): Likewise.
4841 * xrdb.c (member, fatal, main): Likewise.
4842
4843 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 Fix minor problems found by static checking (Bug#9031).
4846 * chartab.c (char_table_set_range, map_sub_char_table):
4847 Remove unused locals.
4848 (uniprop_table): Now static.
4849 * composite.c (_work_char): Remove unused static var.
4850
4851 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4852
4853 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4854
4855 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4856
4857 * gtkutil.c (qttip_cb): Remove code without function.
4858
4859 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4860
4861 * w32.c (pthread_sigmask): New stub.
4862
4863 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4864
4865 Use pthread_sigmask, not sigprocmask (Bug#9010).
4866 sigprocmask is portable only for single-threaded applications, and
4867 Emacs can be multi-threaded when it uses GTK.
4868 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4869 (LIBES): Use it.
4870 * callproc.c (Fcall_process):
4871 * process.c (create_process):
4872 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4873 Use pthread_sigmask, not sigprocmask.
4874
4875 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4876
4877 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4878 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4879 wrong (Bug#8591).
4880
4881 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4882
4883 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4884 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4885 (xg_hide_tooltip): Fix comment.
4886
4887 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4888 in registerServicesMenuSendTypes.
4889 (validRequestorForSendType): Don't check ns_return_types.
4890
4891 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4892 ns_return_type.
4893
4894 2011-07-08 Jason Rumney <jasonr@gnu.org>
4895
4896 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4897 SH_SHOW for hidden windows (Bug#5482).
4898
4899 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4900 frame struct members of non-existent frames (Bug#6284).
4901
4902 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4903
4904 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4905 variable firstTime not needed on OSX >= 10.6.
4906 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4907 >= 10.5. Use setKnobProportion, setDoubleValue.
4908
4909 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4910 (MAC_OS_X_VERSION_10_5): Define if not defined.
4911 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4912 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4913 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4914
4915 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4916 cString and lossyCString on OSX >= 10.4
4917
4918 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4919 sizeToFit on OSX >= 10.2.
4920
4921 * nsimage.m (allocInitFromFile): Don't use deprecated method
4922 bestRepresentationForDevice on OSX >= 10.6.
4923
4924 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4925 to avoid warning.
4926
4927 * emacs.c: Declare unexec_init_emacs_zone.
4928
4929 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4930
4931 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4932
4933 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4934 on svcsMenu (Bug#8842).
4935
4936 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4937 ns_return_types.
4938 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4939
4940 * nsterm.m (QUTF8_STRING): Declare.
4941 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4942 (validRequestorForSendType): Return type is (id).
4943 Change indexOfObjectIdenticalTo to indexOfObject.
4944 Check if we have local selection before returning self (Bug#8842).
4945 (writeSelectionToPasteboard): Put local selection into paste board
4946 if we have a local selection (Bug#8842).
4947 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4948
4949 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4950 (ns_get_local_selection): Declare.
4951
4952 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4953
4954 * keymap.c (describe_map_tree): Don't insert a double newline at
4955 the end of the buffer (bug#1169) and return whether we inserted
4956 something.
4957
4958 * callint.c (Fcall_interactively): Change "reading args" to
4959 "providing args" to try to clarify what it does (bug#1010).
4960
4961 2011-07-07 Kenichi Handa <handa@m17n.org>
4962
4963 * composite.c (composition_compute_stop_pos): Ignore a static
4964 composition starting before CHARPOS (Bug#8915).
4965
4966 * xdisp.c (handle_composition_prop): Likewise.
4967
4968 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4969
4970 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4971 (Bug#9015)
4972
4973 2011-07-07 Kenichi Handa <handa@m17n.org>
4974
4975 * character.h (unicode_category_t): New enum type.
4976
4977 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4978 (Qchar_code_property_table): New variable.
4979 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4980 (UNIPROP_COMPRESSED_FORM_P): New macros.
4981 (char_table_ascii): Uncompress the compressed values.
4982 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4983 Uncompress the compressed values.
4984 (sub_char_table_ref_and_range): Likewise.
4985 (char_table_ref_and_range): Uncompress the compressed values.
4986 (sub_char_table_set): New arg is_uniprop. Callers changed.
4987 Uncompress the compressed values.
4988 (sub_char_table_set_range): Args changed. Callers changed.
4989 (char_table_set_range): Adjuted for the above change.
4990 (map_sub_char_table): Delete args default_val and parent. Add arg
4991 top. Give decoded values to a Lisp function.
4992 (map_char_table): Adjust for the above change. Give decoded
4993 values to a Lisp function. Gcpro more variables.
4994 (uniprop_table_uncompress)
4995 (uniprop_decode_value_run_length): New functions.
4996 (uniprop_decoder, uniprop_decoder_count): New variables.
4997 (uniprop_get_decoder, uniprop_encode_value_character)
4998 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4999 New functions.
5000 (uniprop_encoder, uniprop_encoder_count): New variables.
5001 (uniprop_get_encoder, uniprop_table)
5002 (Funicode_property_table_internal, Fget_unicode_property_internal)
5003 (Fput_unicode_property_internal): New functions.
5004 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5005 Sunicode_property_table_internal, Sget_unicode_property_internal,
5006 and Sput_unicode_property_internal. Defvar_lisp
5007 char-code-property-alist.
5008
5009 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5010 Vunicode_category_table.
5011
5012 * font.c (font_range): Adjust for the change of
5013 Vunicode_category_table.
5014
5015 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5016
5017 * m/iris4d.h: Remove file, move contents ...
5018 * s/irix6-5.h: ... here.
5019
5020 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5021
5022 Remove unportable assumption about struct layout (Bug#8884).
5023 * alloc.c (mark_buffer):
5024 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5025 (clone_per_buffer_values): Don't assume that
5026 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5027 This isn't true in general, and it's particularly not true
5028 if Emacs is configured with --with-wide-int.
5029 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5030 New macros, used in the buffer.c change.
5031
5032 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5033
5034 * xsettings.c: Use both GConf and GSettings if both are available.
5035 (store_config_changed_event): Add comment.
5036 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5037 (store_tool_bar_style_changed): New functions.
5038 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5039 (struct xsettings): Move font inside HAVE_XFT.
5040 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5041 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5042 Move inside HAVE_XFT.
5043 (something_changed_gsettingsCB): Rename from something_changedCB.
5044 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5045 also.
5046 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5047 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5048 (something_changed_gconfCB): Rename from something_changedCB.
5049 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5050 (parse_settings): Move check for font inside HAVE_XFT.
5051 (read_settings, apply_xft_settings): Add comment.
5052 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5053 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5054 call store_font_name_changed.
5055 (xft_settings_event): Add comment.
5056 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5057 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5058 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5059 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5060 (xsettings_initialize): Call init_gsettings last.
5061 (xsettings_get_system_font, xsettings_get_system_normal_font):
5062 Add comment.
5063
5064 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5065
5066 Random fixes. E.g., (random) never returned negative values.
5067 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5068 subseconds part to the entropy, as that's a bit more random.
5069 Prefer signed to unsigned, since the signedness doesn't matter and
5070 in general we prefer signed. When given a limit, use a
5071 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5072 latter isn't right if USE_2_TAGS_FOR_INTS.
5073 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5074 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5075
5076 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5077
5078 * textprop.c (text_property_stickiness):
5079 Obey Vtext_property_default_nonsticky.
5080 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5081 * w32fns.c (syms_of_w32fns):
5082 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5083
5084 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5085
5086 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5087 This is more efficient than Ffile_directory_p and avoids a minor race.
5088
5089 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5090
5091 * buffer.c (Foverlay_put): Say what the return value is
5092 (bug#7835).
5093
5094 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5095 is a directory before asking whether to use the file name
5096 (bug#7564).
5097 (barf_or_query_if_file_exists): Make the "File is a directory"
5098 error be more correct.
5099
5100 * fns.c (Frequire): Remove the mention of the .gz files, since
5101 that's installation-specific, but keep the mention of
5102 `get-load-suffixes'.
5103
5104 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5105
5106 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5107 Report string overflow if the output is too long.
5108
5109 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5110
5111 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5112 (syms_of_gnutls): Remove duplicate DEFSYM for
5113 Qgnutls_bootprop_verify_hostname_error, an error for
5114 Qgnutls_bootprop_verify_error (which is no longer used).
5115
5116 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5117 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5118 Also (re)move comments that are misplaced or no longer relevant.
5119
5120 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5121
5122 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5123
5124 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5125
5126 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5127 and background color parameters if they have been changed.
5128
5129 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5130
5131 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5132
5133 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5134
5135 * xsettings.c (SYSTEM_FONT): Define only when used.
5136 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5137
5138 * keymap.c (access_keymap_1): Now static.
5139
5140 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5141
5142 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5143 leave any prefix arg for the up event (Bug#1586).
5144
5145 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5146
5147 * lread.c (syms_of_lread): Mention single symbols defined by
5148 `defvar' or `defconst' (bug#7154).
5149
5150 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5151 (Frequire): Mention get-load-suffixes.
5152
5153 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5154
5155 * window.h (window): Remove clone_number slot.
5156 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5157 Remove.
5158 (make_parent_window, make_window, saved_window)
5159 (Fset_window_configuration, save_window_save): Don't deal with
5160 clone numbers.
5161 * buffer.c (Qclone_number): Remove declaration.
5162 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5163
5164 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5165
5166 Add multiple inheritance to keymaps.
5167 * keymap.c (Fmake_composed_keymap): New function.
5168 (Fset_keymap_parent): Simplify.
5169 (fix_submap_inheritance): Remove.
5170 (access_keymap_1): New function extracted from access_keymap to handle
5171 embedded parents and handle lists of maps.
5172 (access_keymap): Use it.
5173 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5174 (Fcopy_keymap): Handle embedded parents.
5175 (Fcommand_remapping, define_as_prefix): Simplify.
5176 (Fkey_binding): Simplify.
5177 (syms_of_keymap): Move minibuffer-local-completion-map,
5178 minibuffer-local-filename-completion-map,
5179 minibuffer-local-must-match-map, and
5180 minibuffer-local-filename-must-match-map to Elisp.
5181 (syms_of_keymap): Defsubr make-composed-keymap.
5182 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5183 (parse_menu_item): Trivial simplification.
5184
5185 2011-07-01 Glenn Morris <rgm@gnu.org>
5186
5187 * Makefile.in (SETTINGS_LIBS): Fix typo.
5188
5189 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5190
5191 * coding.c (Fencode_coding_string): Record the last coding system
5192 used, as the function doc string says (bug#8738).
5193
5194 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5195
5196 * xsettings.c (store_monospaced_changed): Take new font as arg and
5197 check for change against current_mono_font.
5198 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5199 (emacs_settings_constructor, emacs_settings_get_property)
5200 (emacs_settings_set_property, emacs_settings_class_init)
5201 (emacs_settings_init, gsettings_obj): Remove.
5202 (something_changedCB): New function for HAVE_GSETTINGS.
5203 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5204 with value as argument.
5205 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5206 g_settings_new (Bug#8967). Do not create gsettings_obj.
5207 Remove calls to g_settings_bind. Connect something_changedCB to
5208 "changed".
5209
5210 * xgselect.c: Add defined (HAVE_GSETTINGS).
5211 (xgselect_initialize): Ditto.
5212
5213 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5214 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5215 xg_select.
5216
5217 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5218
5219 * eval.c (struct backtrace): Simplify and port the data structure.
5220 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5221 signed bit field, as this assumption is not portable and it makes
5222 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5223 "char debug_on_exit : 1" as this is not portable either; instead,
5224 use the portable "unsigned int debug_on_exit : 1". Remove unused
5225 member evalargs. Remove obsolete comments about cc bombing out.
5226
5227 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5228
5229 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5230 Let HAVE_GSETTINGS override HAVE_GCONF.
5231 (store_monospaced_changed): New function.
5232 (EMACS_SETTINGS): A new type derived from GObject to handle
5233 GSettings notifications.
5234 (emacs_settings_constructor, emacs_settings_get_property)
5235 (emacs_settings_set_property, emacs_settings_class_init):
5236 New functions.
5237 (gsettings_client, gsettings_obj): New variables.
5238 (GSETTINGS_SCHEMA): New define.
5239 (something_changedCB): Call store_monospaced_changed.
5240 (init_gsettings): New function.
5241 (xsettings_initialize): Call init_gsettings.
5242 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5243 to NULL.
5244
5245 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5246 GCONF_CFLAGS/LIBS.
5247
5248 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5249
5250 * window.c (resize_root_window, grow_mini_window)
5251 (shrink_mini_window): Rename Qresize_root_window to
5252 Qwindow_resize_root_window and Qresize_root_window_vertically to
5253 Qwindow_resize_root_window_vertically.
5254
5255 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5258
5259 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5260
5261 * makefile.w32-in: Redesign dependencies so they reflect more
5262 clearly which files are directly included by each source file,
5263 and not through other includes.
5264
5265 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5266
5267 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5268 (sort_overlays, overlay_strings): When an overlay's clone number
5269 matches the window's clone number process the overlay even if
5270 the overlay's window property doesn't match the current window.
5271
5272 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5273 (Fwindow_hchild): Rename to Fwindow_left_child.
5274 (Fwindow_next): Rename to Fwindow_next_sibling.
5275 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5276 (resize_window_check): Rename to window_resize_check.
5277 (resize_window_apply): Rename to window_resize_apply.
5278 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5279 (Fdelete_other_windows_internal, resize_frame_windows)
5280 (Fsplit_window_internal, Fdelete_window_internal)
5281 (grow_mini_window, shrink_mini_window)
5282 (Fresize_mini_window_internal): Fix callers accordingly.
5283
5284 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5285
5286 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5287 (emacs_fixed_set_min_size): Remove.
5288 (emacs_fixed_new): Take frame as argument.
5289
5290 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5291 (_EmacsFixedPrivate): Remove minwidth/height.
5292 Add struct frame *f.
5293 (emacs_fixed_init): Initialize priv->f.
5294 (get_parent_class, emacs_fixed_set_min_size): Remove.
5295 (emacs_fixed_new): Set priv->f to argument.
5296 (emacs_fixed_get_preferred_width)
5297 (emacs_fixed_get_preferred_height): Use min_width/height from
5298 frames size_hint to set minimum and natural (Bug#8919).
5299 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5300 and use min_width/height from frames size_hint to set
5301 min_width/height (Bug#8919).
5302
5303 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5304 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5305 Fix indentation.
5306
5307 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5308
5309 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5310 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5311 called at ZV.
5312
5313 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5314
5315 * process.c (wait_reading_process_output): Bypass select if
5316 waiting for a cell while ignoring keyboard input, and input is
5317 pending. Suggested by Jan Djärv (Bug#8869).
5318
5319 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5320
5321 Use gnulib's dup2 module instead of rolling our own.
5322 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5323
5324 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5325
5326 * dispnew.c (scrolling_window): Before scrolling, turn off a
5327 mouse-highlight in the window being scrolled.
5328
5329 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5330
5331 Move DEFSYM to lisp.h and use everywhere.
5332
5333 * character.h (DEFSYM): Move declaration...
5334 * lisp.h (DEFSYM): ...here.
5335
5336 * gnutls.c:
5337 * minibuf.c:
5338 * w32menu.c:
5339 * w32proc.c:
5340 * w32select.c: Don't include character.h.
5341
5342 * alloc.c (syms_of_alloc):
5343 * buffer.c (syms_of_buffer):
5344 * bytecode.c (syms_of_bytecode):
5345 * callint.c (syms_of_callint):
5346 * casefiddle.c (syms_of_casefiddle):
5347 * casetab.c (init_casetab_once):
5348 * category.c (init_category_once, syms_of_category):
5349 * ccl.c (syms_of_ccl):
5350 * cmds.c (syms_of_cmds):
5351 * composite.c (syms_of_composite):
5352 * dbusbind.c (syms_of_dbusbind):
5353 * dired.c (syms_of_dired):
5354 * dispnew.c (syms_of_display):
5355 * doc.c (syms_of_doc):
5356 * editfns.c (syms_of_editfns):
5357 * emacs.c (syms_of_emacs):
5358 * eval.c (syms_of_eval):
5359 * fileio.c (syms_of_fileio):
5360 * fns.c (syms_of_fns):
5361 * frame.c (syms_of_frame):
5362 * fringe.c (syms_of_fringe):
5363 * insdel.c (syms_of_insdel):
5364 * keymap.c (syms_of_keymap):
5365 * lread.c (init_obarray, syms_of_lread):
5366 * macros.c (syms_of_macros):
5367 * msdos.c (syms_of_msdos):
5368 * print.c (syms_of_print):
5369 * process.c (syms_of_process):
5370 * search.c (syms_of_search):
5371 * sound.c (syms_of_sound):
5372 * syntax.c (init_syntax_once, syms_of_syntax):
5373 * terminal.c (syms_of_terminal):
5374 * textprop.c (syms_of_textprop):
5375 * undo.c (syms_of_undo):
5376 * w32.c (globals_of_w32):
5377 * window.c (syms_of_window):
5378 * xdisp.c (syms_of_xdisp):
5379 * xfaces.c (syms_of_xfaces):
5380 * xfns.c (syms_of_xfns):
5381 * xmenu.c (syms_of_xmenu):
5382 * xsettings.c (syms_of_xsettings):
5383 * xterm.c (syms_of_xterm): Use DEFSYM.
5384
5385 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5386
5387 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5388
5389 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5390
5391 Integer and buffer overflow fixes (Bug#8873).
5392
5393 * print.c (printchar, strout): Check for string overflow.
5394 (PRINTPREPARE, printchar, strout):
5395 Don't set size unless allocation succeeds.
5396
5397 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5398 for sizes. Check for string overflow more accurately.
5399 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5400
5401 * macros.c: Integer and buffer overflow fixes.
5402 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5403 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5404 Use ptrdiff_t, not int, for sizes.
5405 Don't increment bufsize until after realloc succeeds.
5406 Check for size-calculation overflow.
5407 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5408
5409 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5410
5411 * lread.c: Integer overflow fixes.
5412 (read_integer): Radix is now EMACS_INT, not int,
5413 to improve quality of diagnostics for out-of-range radices.
5414 Calculate buffer size correctly for out-of-range radices.
5415 (read1): Check for integer overflow in radices, and in
5416 read-circle numbers.
5417 (read_escape): Avoid int overflow.
5418 (Fload, openp, read_buffer_size, read1)
5419 (substitute_object_recurse, read_vector, read_list, map_obarray):
5420 Use ptrdiff_t, not int, for sizes.
5421 (read1): Use EMACS_INT, not int, for sizes.
5422 Check for size overflow.
5423
5424 * image.c (cache_image): Check for size arithmetic overflow.
5425
5426 * lread.c: Integer overflow issues.
5427 (saved_doc_string_size, saved_doc_string_length)
5428 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5429 Now ptrdiff_t, not int.
5430 (read1): Don't assume doc string length fits in int. Check for
5431 out-of-range doc string lengths.
5432 (read_list): Don't assume file position fits in int.
5433 (read_escape): Check for hex character overflow.
5434
5435 2011-06-22 Leo Liu <sdl.web@gmail.com>
5436
5437 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5438 Move to minibuffer.el.
5439
5440 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5441
5442 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5443 The following patches are for when GLYPH_DEBUG && !XASSERT.
5444 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5445 * dispnew.c (flush_stdout):
5446 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5447 Mark as externally visible.
5448 * dispnew.c (check_window_matrix_pointers): Now static.
5449 * dispnew.c (window_to_frame_vpos):
5450 * xfns.c (unwind_create_frame):
5451 * xterm.c (x_check_font): Remove unused local.
5452 * scroll.c (CHECK_BOUNDS):
5453 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5454 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5455 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5456 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5457 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5458 Now static.
5459 (debug_method_add): Use va_list and vsprintf rather than relying
5460 on undefined behavior with wrong number of arguments.
5461 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5462 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5463 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5464 since we're not interested in debugging glyphs with old libraries.
5465 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5466 GCC 4.6.0's static checking.
5467
5468 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5469
5470 Integer overflow and signedness fixes (Bug#8873).
5471 A few related buffer overrun fixes, too.
5472
5473 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5474
5475 * dispextern.h (struct face.stipple):
5476 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5477 (x_bitmap_mask, x_allocate_bitmap_record)
5478 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5479 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5480 (x_create_bitmap_from_xpm_data):
5481 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5482 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5483 (.bitmaps_last):
5484 * xfaces.c (load_pixmap):
5485 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5486 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5487 (.bitmaps_last, struct x_output.icon_bitmap):
5488 Use ptrdiff_t, not int, for bitmap indexes.
5489 (x_allocate_bitmap_record): Check for size overflow.
5490 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5491
5492 Use ptrdiff_t, not int, for overlay counts.
5493 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5494 * editfns.c (overlays_around, get_pos_property):
5495 * textprop.c (get_char_property_and_overlay):
5496 * xdisp.c (next_overlay_change, note_mouse_highlight):
5497 * xfaces.c (face_at_buffer_position):
5498 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5499 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5500 (Fnext_overlay_change, Fprevious_overlay_change)
5501 (mouse_face_overlay_overlaps, Foverlays_in):
5502 Use ptrdiff_t, not int, for sizes.
5503 (overlays_at, overlays_in): Check for size-calculation overflow.
5504
5505 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5506
5507 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5508 (x_session_initialize): Do not assume string length fits in int.
5509
5510 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5511 This is unlikely, but can occur if DPI is outlandish.
5512
5513 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5514 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5515
5516 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5517 * xrdb.c (magic_file_p, search_magic_path):
5518 Omit last arg SUFFIX; it was always 0. All callers changed.
5519 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5520
5521 * xfont.c (xfont_match): Avoid need for strlen.
5522
5523 * xfns.c: Don't assume strlen fits in int.
5524 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5525
5526 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5527 not unsigned long, as we prefer signed integers. All callers changed.
5528 Detect integer overflow in repeat count.
5529 (message_dolog): Don't assume print length fits in 39 bytes.
5530 (display_mode_element): Don't assume strlen fits in int.
5531
5532 * termcap.c: Don't assume sizes fit in int and never overflow.
5533 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5534 (gobble_line): Check for size-calculation overflow.
5535
5536 * minibuf.c (Fread_buffer):
5537 * lread.c (intern, intern_c_string):
5538 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5539 Don't assume string length fits in int.
5540
5541 * keyboard.c (parse_tool_bar_item):
5542 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5543
5544 * font.c: Don't assume string length fits in int.
5545 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5546 Use ptrdiff_t, not int.
5547 (font_intern_prop): Don't assume string length fits in int.
5548 Don't assume integer property fits in fixnum.
5549 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5550
5551 * filelock.c: Fix some buffer overrun and integer overflow issues.
5552 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5553 Reformulate so as not to need the command string.
5554 Invoke gzip -cd rather than gunzip, as it's more portable.
5555 (lock_info_type, lock_file_1, lock_file):
5556 Don't assume pid_t and time_t fit in unsigned long.
5557 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5558 (current_lock_owner): Prefer signed type for sizes.
5559 Use memcpy, not strncpy, where memcpy is what is really wanted.
5560 Don't assume (via atoi) that time_t and pid_t fit in int.
5561 Check for time_t and/or pid_t out of range, e.g., via a network share.
5562 Don't alloca where an auto var works fine.
5563
5564 * fileio.c: Fix some integer overflow issues.
5565 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5566 Don't assume string length fits in int.
5567 (directory_file_name): Don't assume string length fits in long.
5568 (make_temp_name): Don't assume pid fits in int, or that its print
5569 length is less than 20.
5570
5571 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5572
5573 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5574
5575 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5576
5577 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5578 We prefer signed integers, even for size calculations.
5579
5580 * emacs.c: Don't assume string length fits in 'int'.
5581 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5582 (main): Don't invoke strlen when not needed.
5583
5584 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5585 (XD_DEBUG_MESSAGE): Don't waste a byte.
5586
5587 * callproc.c (getenv_internal_1, getenv_internal)
5588 (Fgetenv_internal):
5589 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5590
5591 * lread.c (invalid_syntax): Omit length argument.
5592 All uses changed. This doesn't fix a bug, but it simplifies the
5593 code away from its former Hollerith-constant appearance, and it's
5594 one less 'int' to worry about when looking at integer-overflow issues.
5595 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5596
5597 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5598 This didn't break anything, but it didn't help either.
5599 It's confusing to put a bogus integer in a place where the actual
5600 value does not matter.
5601 (LIST_END_P): Remove unused macro and its bogus comment.
5602 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5603
5604 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5605 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5606 implementation.
5607 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5608 We prefer signed types, and the value cannot exceed the EMACS_INT
5609 range anyway (because otherwise the length would not be representable).
5610 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5611 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5612 This avoids a GCC warning when WIDE_EMACS_INT.
5613
5614 * indent.c (sane_tab_width): New function.
5615 (current_column, scan_for_column, Findent_to, position_indentation)
5616 (compute_motion): Use it. This is just for clarity.
5617 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5618
5619 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5620
5621 * lisp.h (lint_assume): New macro.
5622 * composite.c (composition_gstring_put_cache):
5623 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5624
5625 * editfns.c, insdel.c:
5626 Omit unnecessary forward decls, to simplify future changes.
5627
5628 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5629
5630 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5631
5632 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5633 Use much-faster test for byte-length change.
5634 Don't assume string byte-length fits in 'int'.
5635 Check that character arg fits in 'int'.
5636 (mapcar1): Declare byte as byte, for clarity.
5637
5638 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5639
5640 * fns.c (concat): Catch string overflow earlier.
5641 Do not rely on integer wraparound.
5642
5643 * dispextern.h (struct it.overlay_strings_charpos)
5644 (struct it.selective): Now EMACS_INT, not int.
5645 * xdisp.c (forward_to_next_line_start)
5646 (back_to_previous_visible_line_start)
5647 (reseat_at_next_visible_line_start, next_element_from_buffer):
5648 Don't arbitrarily truncate the value of 'selective' to int.
5649
5650 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5651
5652 * composite.c: Don't truncate sizes to 'int'.
5653 (composition_gstring_p, composition_reseat_it)
5654 (composition_adjust_point): Use EMACS_INT, not int.
5655 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5656 not EMACS_UINT, for indexes.
5657
5658 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5659
5660 * buffer.c: Include <verify.h>.
5661 (struct sortvec.priority, struct sortstr.priority):
5662 Now EMACS_INT, not int.
5663 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5664 (struct sortstr.size, record_overlay_string)
5665 (struct sortstrlist.size, struct sortlist.used):
5666 Don't truncate size to int.
5667 (record_overlay_string): Check for size-calculation overflow.
5668 (init_buffer_once): Check at compile-time, not run-time.
5669
5670 2011-06-22 Jim Meyering <meyering@redhat.com>
5671
5672 Don't leak an XBM-image-sized buffer
5673 * image.c (xbm_load): Free the image buffer after using it.
5674
5675 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5676
5677 Port to Sun C.
5678 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5679 that Sun C diagnosed.
5680 * fns.c (secure_hash): Fix pointer signedness issue.
5681 * intervals.c (static_offset_intervals): New function.
5682 (offset_intervals): Use it.
5683
5684 2011-06-21 Leo Liu <sdl.web@gmail.com>
5685
5686 * deps.mk (fns.o):
5687 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5688 sha512.h.
5689
5690 * fns.c (secure_hash): Rename from crypto_hash_function and change
5691 the first arg to accept symbols.
5692 (Fsecure_hash): New primitive.
5693 (syms_of_fns): New symbols.
5694
5695 2011-06-20 Deniz Dogan <deniz@dogan.se>
5696
5697 * process.c (Fset_process_buffer): Clarify return value in
5698 docstring.
5699
5700 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5701
5702 * dispnew.c (add_window_display_history): Use BVAR.
5703
5704 * xdisp.c (debug_method_add): Use BVAR.
5705 (check_window_end, dump_glyph_matrix, dump_glyph)
5706 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5707
5708 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5709 Likewise.
5710
5711 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5712 check till after the cache is created in init_frame_faces.
5713
5714 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5715
5716 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5717
5718 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5721 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5722 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5723
5724 Improve buffer-overflow checking (Bug#8873).
5725 * fileio.c (Finsert_file_contents):
5726 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5727 Remove the old (too-loose) buffer overflow checks.
5728 They weren't needed, since make_gap checks for buffer overflow.
5729 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5730 The old code merely checked for Emacs fixnum overflow, and relied
5731 on undefined (wraparound) behavior. The new code avoids undefined
5732 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5733
5734 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5735 Tune. Don't use wider integers than needed. Don't use alloca.
5736 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5737
5738 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5739
5740 * insdel.c, lisp.h (buffer_overflow): New function.
5741 (insert_from_buffer_1, replace_range, replace_range_2):
5742 * insdel.c (make_gap_larger):
5743 * editfns.c (Finsert_char):
5744 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5745
5746 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5747
5748 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5751
5752 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5753 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5754
5755 * fileio.c: Don't assume EMACS_INT fits in off_t.
5756 (emacs_lseek): New static function.
5757 (Finsert_file_contents, Fwrite_region): Use it.
5758 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5759
5760 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5761
5762 * fns.c: Don't overflow int when computing a list length.
5763 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5764 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5765 truncation on 64-bit hosts. Check for QUIT every
5766 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5767 faster and is responsive enough.
5768 (Flength): Report an error instead of overflowing an integer.
5769 (Fsafe_length): Return a float if the value is not representable
5770 as a fixnum. This shouldn't happen except in contrived situations.
5771 (Fnthcdr, Fsort): Don't assume list length fits in int.
5772 (Fcopy_sequence): Don't assume vector length fits in int.
5773
5774 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5775 (header_size, word_size): New constants.
5776 (allocate_vectorlike): Don't check size overflow here.
5777 (allocate_vector): Check it here instead, since this is the only
5778 caller of allocate_vectorlike that could cause overflow.
5779 Check that the new vector's length is representable as a fixnum.
5780
5781 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5782 The previous code was bogus. For example, next_almost_prime (32)
5783 returned 39, which is undesirable as it is a multiple of 3; and
5784 next_almost_prime (24) returned 25, which is a multiple of 5 so
5785 why was the code bothering to check for multiples of 7?
5786
5787 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5788
5789 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5790
5791 Variadic C functions now count arguments with ptrdiff_t.
5792 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5793 Back then I didn't know that the Emacs coding style prefers signed int.
5794 Also, in the meantime I found a few more instances where arguments
5795 were being counted with int, which may truncate counts on 64-bit
5796 machines, or EMACS_INT, which may be unnecessarily wide.
5797 * lisp.h (struct Lisp_Subr.function.aMANY)
5798 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5799 Arg counts are now ptrdiff_t, not size_t.
5800 All variadic functions and their callers changed accordingly.
5801 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5802 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5803 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5804 * callint.c (Fcall_interactively): Check arg count for overflow,
5805 to avoid potential buffer overrun. Use signed char, not 'int',
5806 for 'varies' array, so that we needn't bother to check its size
5807 calculation for overflow.
5808 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5809 * eval.c (apply_lambda):
5810 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5811 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5812 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5813
5814 * callint.c (Fcall_interactively): Don't use index var as event count.
5815
5816 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5817 * mem-limits.h (SIZE): Remove; no longer used.
5818
5819 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5820
5821 Remove unnecessary casts.
5822 * xterm.c (x_term_init):
5823 * xfns.c (x_set_border_pixel):
5824 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5825 These aren't needed now that we assume ANSI C.
5826
5827 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5828 It's more likely to cause problems (due to unsigned overflow)
5829 than to cure them.
5830
5831 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5832
5833 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5834
5835 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5836
5837 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5838
5839 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5840
5841 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5842
5843 GLYPH_CODE_FACE returns EMACS_INT, not int.
5844 * dispextern.h (merge_faces):
5845 * xfaces.c (merge_faces):
5846 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5847 Don't assume EMACS_INT fits in int.
5848
5849 * character.h (CHAR_VALID_P): Remove unused parameter.
5850 * fontset.c, lisp.h, xdisp.c: All uses changed.
5851
5852 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5853
5854 * fns.c (concat): Minor tuning based on overflow analysis.
5855 This doesn't fix any bugs. Use int to hold character, instead
5856 of constantly refetching from Emacs object. Use XFASTINT, not
5857 XINT, for value known to be a character. Don't bother comparing
5858 a single byte to 0400, as it's always less.
5859
5860 * floatfns.c (Fexpt):
5861 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5862
5863 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5864 for characters.
5865
5866 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5867
5868 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5869 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5870 incorrectly succeed when S was a string, because 4294967386 was
5871 truncated before it was used.
5872
5873 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5874 Otherwise, an out-of-range integer could cause undefined behavior
5875 on a 64-bit host.
5876
5877 * composite.c: Use int, not EMACS_INT, for characters.
5878 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5879 EMACS_INT, for values that are known to be in character range.
5880 This doesn't fix any bugs but is the usual style inside Emacs and
5881 may generate better code on 32-bit machines.
5882
5883 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5884 This is for reasons similar to the recent CHAR_STRING fix.
5885 * charset.c (Fencode_char): Check that character arg is actually
5886 a character. Pass an int to ENCODE_CHAR.
5887 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5888 wider than 'int', as a compile-time check to prevent future regressions
5889 in this area.
5890
5891 * character.c (char_string): Remove unnecessary casts.
5892
5893 Make sure a 64-bit char is never passed to CHAR_STRING.
5894 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5895 by silently ignoring the top 32 bits, allowing some values
5896 that were far too large to be valid characters.
5897 * character.h: Include <verify.h>.
5898 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5899 arguments are no wider than unsigned, as a compile-time check
5900 to prevent future regressions in this area.
5901 * data.c (Faset):
5902 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5903 (Fsubst_char_in_region):
5904 * fns.c (concat):
5905 * xdisp.c (decode_mode_spec_coding):
5906 Adjust to CHAR_STRING's new requirement.
5907 * editfns.c (Finsert_char, Fsubst_char_in_region):
5908 * fns.c (concat): Check that character args are actually
5909 characters. Without this test, these functions did the wrong
5910 thing with wildly out-of-range values on 64-bit hosts.
5911
5912 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5913 These casts should not be needed on 32-bit hosts, either.
5914 * keyboard.c (read_char):
5915 * lread.c (Fload): Remove casts to unsigned.
5916
5917 * lisp.h (UNSIGNED_CMP): New macro.
5918 This fixes comparison bugs on 64-bit hosts.
5919 (ASCII_CHAR_P): Use it.
5920 * casefiddle.c (casify_object):
5921 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5922 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5923 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5924 * dispextern.h (FACE_FROM_ID):
5925 * keyboard.c (read_char): Use UNSIGNED_CMP.
5926
5927 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5928 not to EMACS_INT, to avoid GCC warning.
5929
5930 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5931
5932 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5933 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5934 isn't needed on 32-bit machines.
5935
5936 * buffer.c (Fgenerate_new_buffer_name):
5937 Use EMACS_INT for count, not int.
5938 (advance_to_char_boundary): Return EMACS_INT, not int.
5939
5940 * data.c (Qcompiled_function): Now static.
5941
5942 * window.c (window_body_lines): Now static.
5943
5944 * image.c (gif_load): Rename local to avoid shadowing.
5945
5946 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5947 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5948 * alloc.c (make_save_value): Integer argument is now of type
5949 ptrdiff_t, not int.
5950 (mark_object): Use ptrdiff_t, not int.
5951 * lisp.h (pD): New macro.
5952 * print.c (print_object): Use it.
5953
5954 * alloc.c: Use EMACS_INT, not int, to count objects.
5955 (total_conses, total_markers, total_symbols, total_vector_size)
5956 (total_free_conses, total_free_markers, total_free_symbols)
5957 (total_free_floats, total_floats, total_free_intervals)
5958 (total_intervals, total_strings, total_free_strings):
5959 Now EMACS_INT, not int. All uses changed.
5960 (Fgarbage_collect): Compute overall total using a double, so that
5961 integer overflow is less likely to be a problem. Check for overflow
5962 when converting back to an integer.
5963 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5964 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5965 These were 'int' variables that could overflow on 64-bit hosts;
5966 they were never used, so remove them instead of repairing them.
5967 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5968 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5969 Previously, this ceilinged at INT_MAX, but that doesn't work on
5970 64-bit machines.
5971 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5972
5973 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5974 (allocate_vectorlike): Check for ptrdiff_t overflow.
5975 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5976 when a (possibly-narrower) signed value would do just as well.
5977 We prefer using signed arithmetic, to avoid comparison confusion.
5978
5979 * alloc.c: Catch some string size overflows that we were missing.
5980 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5981 for convenience in STRING_BYTES_MAX.
5982 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5983 The definition here is exact; the one in lisp.h was approximate.
5984 (allocate_string_data): Check for string overflow. This catches
5985 some instances we weren't catching before. Also, it catches
5986 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5987 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5988 and ptrdiff_t and EMACS_INT are both 64 bits.
5989
5990 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5991 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5992 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5993
5994 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5995
5996 * alloc.c (Fmake_string): Check for out-of-range init.
5997
5998 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5999
6000 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6001
6002 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6003
6004 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6005 xg_get_default_scrollbar_width.
6006
6007 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6008 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6009 (style_changed_cb): Call update_theme_scrollbar_width and call
6010 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6011 all frames (Bug#8505).
6012 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6013 Call gtk_window_set_resizable if HAVE_GTK3.
6014 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6015 and height if HAVE_GTK3 (Bug#8505).
6016 (scroll_bar_width_for_theme): New variable.
6017 (update_theme_scrollbar_width): New function.
6018 (xg_get_default_scrollbar_width): Move code to
6019 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6020 (xg_initialize): Call update_theme_scrollbar_width.
6021
6022 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6023
6024 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6025
6026 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6027
6028 * frame.c (make_frame): Call other_buffer_safely instead of
6029 other_buffer.
6030
6031 * window.c (temp_output_buffer_show): Call display_buffer with
6032 second argument Vtemp_buffer_show_specifiers and reset latter
6033 immediately after the call.
6034 (Vtemp_buffer_show_specifiers): New variable.
6035 (auto_window_vscroll_p, next_screen_context_lines)
6036 (Vscroll_preserve_screen_position): Remove leading asterisks from
6037 doc-strings.
6038
6039 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 Fix minor problems found by GCC 4.6.0 static checking.
6042 * buffer.c (Qclone_number): Remove for now, as it's unused.
6043 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6044 (record_buffer): Remove unused local.
6045 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6046 (set_frame_buffer_list): Remove; unused.
6047 * frame.h (other_visible_frames): Remove decl.
6048 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6049 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6050 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6051 if HAVE_GPM.
6052 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6053 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6054 Define only if HAVE_GPM.
6055 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6056 (update_hints_inhibit): Remove; never set. All uses removed.
6057 * widgetprv.h (emacsFrameClassRec): Remove decl.
6058 * window.c (delete_deletable_window): Now returns void, since it
6059 wasn't returning anything.
6060 (compare_window_configurations): Remove unused locals.
6061 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6062 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6063 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6064 the same widths as pointers. This follows up on the 2011-05-06 patch.
6065 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6066 * xterm.h: Likewise.
6067 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6068
6069 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6070
6071 * makefile.w32-in: Update dependencies.
6072 (LISP_H): Add lib/intprops.h.
6073
6074 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6075
6076 * image.c (gif_load): Add animation frame delay to the metadata.
6077 (syms_of_image): Use DEFSYM. New symbol `delay'.
6078
6079 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6080
6081 * window.c (delete_deletable_window): Re-add.
6082 (Fset_window_configuration): Rewrite to handle dead buffers and
6083 consequently deletable windows.
6084 (window_tree, Fwindow_tree): Remove. Supply functionality in
6085 window.el.
6086 (compare_window_configurations): Simplify code.
6087
6088 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * image.c (imagemagick_load_image): Fix type mismatch.
6091 (Fimagemagick_types): Likewise.
6092
6093 * window.h (replace_buffer_in_windows): Declare.
6094
6095 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6096
6097 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6098 Qclone_number. Remove external declaration of Qdelete_window.
6099 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6100 code.
6101 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6102 Run Qbuffer_list_update_hook if allowed.
6103 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6104 buffer list implementation.
6105 (other_buffer_safely): New function.
6106 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6107 calls to replace_buffer_in_windows and
6108 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6109 if allowed.
6110 (record_buffer): Inhibit quitting and rewrite using quittable
6111 functions. Run Qbuffer_list_update_hook if allowed.
6112 (Frecord_buffer, Funrecord_buffer): New functions.
6113 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6114 Move switch-to-buffer to window.el.
6115 (bury-buffer): Move to window.el.
6116 (Vbuffer_list_update_hook): New variable.
6117
6118 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6119 section.
6120
6121 * window.h (resize_frame_windows): Move up in code.
6122 (Fwindow_frame): Remove EXFUN.
6123 (replace_buffer_in_all_windows): Remove prototype.
6124 (replace_buffer_in_windows_safely): Add prototype.
6125
6126 * window.c: Declare Qdelete_window static again. Move down
6127 declaration of select_count.
6128 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6129 (Fother_window): Move to window.el.
6130 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6131 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6132 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6133 window.el.
6134 (replace_buffer_in_windows): Implement by calling
6135 Qreplace_buffer_in_windows.
6136 (replace_buffer_in_all_windows): Remove with some functionality
6137 moved into replace_buffer_in_windows_safely.
6138 (replace_buffer_in_windows_safely): New function.
6139 (select_window_norecord, select_frame_norecord): Move in front
6140 of run_window_configuration_change_hook. Remove now obsolete
6141 declarations.
6142 (Fset_window_buffer): Rewrite doc-string.
6143 Call Qrecord_window_buffer.
6144 (keys_of_window): Move binding for other-window to window.el.
6145
6146 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6147
6148 * dispextern.h (struct image): Replace data member, whose int_val
6149 and ptr_val fields were not used by anything, with a single
6150 lisp_val object.
6151
6152 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6153 (gif_clear_image, gif_load, imagemagick_load_image)
6154 (gs_clear_image, gs_load): Callers changed.
6155
6156 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6157
6158 * buffer.h: Include <time.h>, for time_t.
6159 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6160
6161 Fix minor problems found by static checking.
6162
6163 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6164
6165 Make identifiers static if they are not used in other modules.
6166 * data.c (Qcompiled_function, Qframe, Qvector):
6167 * image.c (QimageMagick, Qsvg):
6168 * minibuf.c (Qmetadata):
6169 * window.c (resize_window_check, resize_root_window): Now static.
6170 * window.h (resize_window_check, resize_root_window): Remove decls.
6171
6172 * window.c (window_deletion_count, delete_deletable_window):
6173 Remove; unused.
6174 (window_body_lines): Now static.
6175 (Fdelete_other_windows_internal): Mark vars as initialized.
6176 Make sure 'resize_failed' is initialized.
6177 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6178 (resize_window_apply): Remove unused local.
6179 * window.h (delete_deletable_window): Remove decl.
6180
6181 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6182 (imagemagick_load_image): Fix pointer signedness problem by changing
6183 last arg from unsigned char * to char *. All uses changed.
6184 Also, fix a local for similar reasons.
6185 Remove unused locals. Remove locals to avoid shadowing.
6186 (fn_rsvg_handle_free): Remove; unused.
6187 (svg_load, svg_load_image): Fix pointer signedness problem.
6188 (imagemagick_load_image): Don't use garbage pointer image_wand.
6189
6190 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6191
6192 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6193
6194 * image.c (gif_load): Fix omitted cast error introduced by
6195 2011-06-06 change.
6196
6197 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6198
6199 * window.h (resize_proportionally, orig_total_lines)
6200 (orig_top_line): Remove from window structure.
6201 (set_window_height, set_window_width, change_window_heights)
6202 (Fdelete_window): Remove prototypes.
6203 (resize_frame_windows): Remove duplicate declaration.
6204
6205 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6206
6207 * window.h (resize_frame_windows, resize_window_check)
6208 (delete_deletable_window, resize_root_window)
6209 (resize_frame_windows): Declare prototypes.
6210
6211 * window.c (resize_window_apply): Make definition be "static" to
6212 match the prototype.
6213
6214 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6215
6216 * window.c: Remove declarations of Qwindow_size_fixed,
6217 window_min_size_1, window_min_size_2, window_min_size,
6218 size_window, window_fixed_size_p, enlarge_window, delete_window.
6219 Remove static from declaration of Qdelete_window, it's
6220 temporarily needed by Fbury_buffer.
6221 (replace_window): Don't assign orig_top_line and
6222 orig_total_lines.
6223 (Fdelete_window, delete_window): Remove. Window deletion is
6224 handled by window.el.
6225 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6226 Replace Fdelete_window calls with calls to Qdelete_window.
6227 (Fdelete_other_windows): Remove. Deleting other windows is
6228 handled by window.el.
6229 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6230 handled in window.el.
6231 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6232 Window minimum sizes are handled in window.el.
6233 (shrink_windows, size_window, set_window_height)
6234 (set_window_width, change_window_heights, window_height)
6235 (window_width, CURBEG, CURSIZE, enlarge_window)
6236 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6237 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6238 handled in window.el.
6239 (make_dummy_parent): Rename to make_parent_window and give it a
6240 second argument horflag.
6241 (make_window): Don't set resize_proportionally any more.
6242 (Fsplit_window): Remove. Windows are split in window.el.
6243 (save_restore_action, save_restore_orig_size)
6244 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6245 Resize mini windows in window.el.
6246 (grow_mini_window, shrink_mini_window): Implement by calling
6247 Qresize_root_window_vertically, resize_window_check and
6248 resize_window_apply.
6249 (saved_window, Fset_window_configuration, save_window_save):
6250 Do not handle orig_top_line, orig_total_lines, and
6251 resize_proportionally.
6252 (window_min_height, window_min_width): Move to window.el.
6253 (keys_of_window): Move bindings for delete-other-windows,
6254 split-window, delete-window and enlarge-window to window.el.
6255
6256 * buffer.c: Temporarily extern Qdelete_window.
6257 (Fbury_buffer): Temporarily call Qdelete_window instead of
6258 Fdelete_window (Fbury_buffer will move to window.el soon).
6259
6260 * frame.c (set_menu_bar_lines_1): Remove code handling
6261 orig_top_line and orig_total_lines.
6262
6263 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6264 set_window_height but set heights directly.
6265 (change_frame_size_1): Use resize_frame_windows.
6266
6267 * xdisp.c (init_xdisp): Don't use set_window_height but set
6268 heights directly.
6269
6270 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6271 Use resize_frame_windows instead of change_window_heights and run
6272 run_window_configuration_change_hook.
6273
6274 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6275 instead of change_window_heights and run
6276 run_window_configuration_change_hook.
6277
6278 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6279
6280 * window.c (replace_window): Rename second argument REPLACEMENT to
6281 NEW. New third argument SETFLAG. Rewrite.
6282 (delete_window, make_dummy_parent): Call replace_window with
6283 third argument 1.
6284 (window_list_1): Move down in code.
6285 (run_window_configuration_change_hook): Move set_buffer part
6286 before select_frame_norecord part in order to unwind correctly.
6287 Rename count1 to count.
6288 (recombine_windows, delete_deletable_window, resize_root_window)
6289 (Fdelete_other_windows_internal)
6290 (Frun_window_configuration_change_hook, make_parent_window)
6291 (resize_window_check, resize_window_apply, Fresize_window_apply)
6292 (resize_frame_windows, Fsplit_window_internal)
6293 (Fdelete_window_internal, Fresize_mini_window_internal):
6294 New functions.
6295 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6296
6297 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6298
6299 * window.h (window): Add some new members to window structure -
6300 normal_lines, normal_cols, new_total, new_normal, clone_number,
6301 splits, nest, prev_buffers, next_buffers.
6302 (WINDOW_TOTAL_SIZE): Move here from window.c.
6303 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6304
6305 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6306 Remove.
6307 (make_dummy_parent): Set new members of windows structure.
6308 (make_window): Move down in code. Handle new members of window
6309 structure.
6310 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6311 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6312 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6313 (Fset_window_prev_buffers, Fwindow_next_buffers)
6314 (Fset_window_next_buffers, Fset_window_clone_number):
6315 New functions.
6316 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6317 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6318 Doc-string fixes.
6319 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6320 Argument WINDOW can be now internal window too.
6321 (Fwindow_use_time): Move up in code.
6322 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6323 Rewrite doc-string.
6324 (Fset_window_configuration, saved_window)
6325 (Fcurrent_window_configuration, save_window_save): Handle new
6326 members of window structure.
6327 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6328 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6329 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6330 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6331 Qget_mru_window, Qresize_root_window,
6332 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6333 Qauto_buffer_name; staticpro them.
6334
6335 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6336
6337 * window.c (Fwindow_total_size, Fwindow_left_column)
6338 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6339 (Fwindow_list_1): New functions.
6340 (window_box_text_cols): Replace with window_body_cols.
6341 (Fwindow_width, Fscroll_left, Fscroll_right):
6342 Use window_body_cols instead of window_box_text_cols.
6343 (delete_window, Fset_window_configuration):
6344 Call delete_all_subwindows with window as argument.
6345 (delete_all_subwindows): Take a window as argument and not a
6346 structure. Rewrite.
6347 (window_loop): Remove handling of GET_LRU_WINDOW and
6348 GET_LARGEST_WINDOW.
6349 (Fget_lru_window, Fget_largest_window): Move to window.el.
6350
6351 * window.h: Extern window_body_cols instead of
6352 window_box_text_cols. delete_all_subwindows now takes a
6353 Lisp_Object as argument.
6354
6355 * indent.c (compute_motion, Fcompute_motion):
6356 Use window_body_cols instead of window_box_text_cols.
6357
6358 * frame.c (delete_frame): Call delete_all_subwindows with root
6359 window as argument.
6360
6361 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6362
6363 * fns.c (Fputhash): Document return value.
6364
6365 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6366
6367 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6368
6369 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6370
6371 Cons<->int and similar integer overflow fixes (Bug#8794).
6372
6373 Check for overflow when converting integer to cons and back.
6374 * charset.c (Fdefine_charset_internal, Fdecode_char):
6375 Use cons_to_unsigned to catch overflow.
6376 (Fencode_char): Use INTEGER_TO_CONS.
6377 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6378 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6379 * data.c (long_to_cons, cons_to_long): Remove.
6380 (cons_to_unsigned, cons_to_signed): New functions.
6381 These signal an error for invalid or out-of-range values.
6382 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6383 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6384 * font.c (Ffont_variation_glyphs):
6385 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6386 * lisp.h: Include <intprops.h>.
6387 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6388 (cons_to_signed, cons_to_unsigned): New decls.
6389 (long_to_cons, cons_to_long): Remove decls.
6390 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6391 (Fprimitive_undo): Use CONS_TO_INTEGER.
6392 * xfns.c (Fx_window_property): Likewise.
6393 * xselect.c: Include <limits.h>.
6394 (x_own_selection, selection_data_to_lisp_data):
6395 Use INTEGER_TO_CONS.
6396 (x_handle_selection_request, x_handle_selection_clear)
6397 (x_get_foreign_selection, Fx_disown_selection_internal)
6398 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6399 (lisp_data_to_selection_data): Use cons_to_unsigned.
6400 (x_fill_property_data): Use cons_to_signed.
6401 Report values out of range.
6402
6403 Check for buffer and string overflow more precisely.
6404 * buffer.h (BUF_BYTES_MAX): New macro.
6405 * lisp.h (STRING_BYTES_MAX): New macro.
6406 * alloc.c (Fmake_string):
6407 * character.c (string_escape_byte8):
6408 * coding.c (coding_alloc_by_realloc):
6409 * doprnt.c (doprnt):
6410 * editfns.c (Fformat):
6411 * eval.c (verror):
6412 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6413 since they may not be the same number.
6414 * editfns.c (Finsert_char):
6415 * fileio.c (Finsert_file_contents):
6416 Likewise for BUF_BYTES_MAX.
6417
6418 * image.c: Use ptrdiff_t, not int, for sizes.
6419 (slurp_file): Switch from int to ptrdiff_t.
6420 All uses changed.
6421 (slurp_file): Check that file size fits in both size_t (for
6422 malloc) and ptrdiff_t (for sanity and safety).
6423
6424 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6425 if b->modtime has its maximal value.
6426
6427 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6428
6429 Don't assume time_t can fit into int.
6430 * buffer.h (struct buffer.modtime): Now time_t, not int.
6431 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6432 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6433
6434 Minor fixes for signed vs unsigned integers.
6435 * character.h (MAYBE_UNIFY_CHAR):
6436 * charset.c (maybe_unify_char):
6437 * keyboard.c (read_char, reorder_modifiers):
6438 XINT -> XFASTINT, since the integer must be nonnegative.
6439 * ftfont.c (ftfont_spec_pattern):
6440 * keymap.c (access_keymap, silly_event_symbol_error):
6441 XUINT -> XFASTINT, since the integer must be nonnegative.
6442 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6443 since it makes no difference and we prefer signed.
6444 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6445 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6446 nonnegative.
6447
6448 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6449
6450 * window.h (Fwindow_frame): Declare.
6451
6452 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6453
6454 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6455 (SPARE_MEMORY): Always define.
6456 (LARGE_REQUEST): Remove.
6457 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6458
6459 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6460
6461 * lisp.h: Move EXFUNS for Fframe_root_window,
6462 Fframe_first_window and Fset_frame_selected_window to window.h.
6463
6464 * window.h: Move EXFUNS for Fframe_root_window,
6465 Fframe_first_window and Fset_frame_selected_window here from
6466 lisp.h.
6467
6468 * frame.c (Fwindow_frame, Fframe_first_window)
6469 (Fframe_root_window, Fframe_selected_window)
6470 (Fset_frame_selected_window): Move to window.c.
6471 (Factive_minibuffer_window): Move to minibuf.c.
6472 (Fother_visible_frames_p): New function.
6473
6474 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6475
6476 * window.c (decode_window, decode_any_window): Move up in code.
6477 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6478 (inhibit_frame_unsplittable): Remove unused variable.
6479 (Fwindow_buffer): Move up and rewrite doc-string.
6480 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6481 (Fwindow_prev): New functions.
6482 (Fwindow_frame): Move here from frame.c. Accept any window as
6483 argument.
6484 (Fframe_root_window, Fframe_first_window)
6485 (Fframe_selected_window): Move here from frame.c. Accept frame
6486 or arbitrary window as argument. Update doc-strings.
6487 (Fminibuffer_window): Move up in code.
6488 (Fwindow_minibuffer_p): Move up in code and simplify.
6489 (Fset_frame_selected_window): Move here from frame.c.
6490 Marginal rewrite.
6491 (Fselected_window, select_window, Fselect_window): Move up in
6492 code. Minor doc-string fixes.
6493
6494 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6497 Do not assume that spare memory exists; that assumption is valid
6498 only if SYSTEM_MALLOC.
6499 (LARGE_REQUEST): New macro, so that the issue of large requests
6500 is separated from the issue of spare memory.
6501
6502 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6503
6504 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6505 format. (Bug#8806)
6506
6507 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6508
6509 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6510 before statements.
6511
6512 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6513
6514 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6515
6516 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6517
6518 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6519 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6520
6521 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6522
6523 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6524
6525 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6526
6527 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6528 (x_clipboard_manager_save): Add return value.
6529 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6530 New error handlers.
6531 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6532 Obey Vx_select_enable_clipboard_manager. Catch errors in
6533 x_clipboard_manager_save (Bug#8779).
6534 (Vx_select_enable_clipboard_manager): New variable.
6535 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6536
6537 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6538
6539 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6540
6541 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6542
6543 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6544 in the current matrix if keep_current_p is non-zero.
6545
6546 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6547
6548 * bidi.c (bidi_level_of_next_char): Fix last change.
6549
6550 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6551
6552 Support bidi reordering of text covered by display properties.
6553
6554 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6555 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6556 (bidi_cache_search, bidi_cache_iterator_state)
6557 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6558 (bidi_level_of_next_char, bidi_move_to_visually_next):
6559 Support character positions inside a run of characters covered by a
6560 display string.
6561 (bidi_paragraph_init, bidi_resolve_explicit_1)
6562 (bidi_level_of_next_char): Call bidi_fetch_char and
6563 bidi_fetch_char_advance instead of FETCH_CHAR and
6564 FETCH_CHAR_ADVANCE.
6565 (bidi_init_it): Initialize new members.
6566 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6567 definitions.
6568 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6569 instead of using explicit *_CHAR codes.
6570 (bidi_resolve_explicit, bidi_resolve_weak):
6571 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6572 bidirectional text is supported only in multibyte buffers.
6573 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6574 it to initialize the frame_window_p member of struct bidi_it.
6575 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6576 (bidi_resolve_explicit, bidi_resolve_weak)
6577 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6578 bidi_it->nchars is non-positive.
6579 (bidi_level_of_next_char): Don't try to lookup the cache for the
6580 next/previous character if nothing is cached there yet, or if we
6581 were just reseat()'ed to a new position.
6582
6583 * xdisp.c (set_cursor_from_row): Set start and stop points
6584 according to the row's direction when priming the loop that looks
6585 for the glyph on which to display cursor.
6586 (single_display_spec_intangible_p): Function deleted.
6587 (display_prop_intangible_p): Reimplement to call
6588 handle_display_spec instead of single_display_spec_intangible_p.
6589 Accept 3 additional arguments needed by handle_display_spec.
6590 This fixes incorrect cursor motion across display property with complex
6591 values: lists, `(when COND...)' forms, etc.
6592 (single_display_spec_string_p): Support property values that are
6593 lists with the argument STRING its top-level element.
6594 (display_prop_string_p): Fix the condition for processing a
6595 property that is a list to be consistent with handle_display_spec.
6596 (handle_display_spec): New function, refactored from the
6597 last portion of handle_display_prop.
6598 (compute_display_string_pos): Accept additional argument
6599 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6600 value of a `display' property is a "replacing spec".
6601 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6602 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6603 the display property, but just return a value indicating whether
6604 the display property will replace the characters it covers.
6605 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6606 frame_window_p members of struct bidi_it.
6607 (compute_display_string_pos, compute_display_string_end):
6608 New functions.
6609 (push_it): Accept second argument POSITION, where pop_it should
6610 jump to continue iteration.
6611 (reseat_1): Initialize bidi_it.disp_pos.
6612
6613 * keyboard.c (adjust_point_for_property): Adjust the call to
6614 display_prop_intangible_p to its new signature.
6615
6616 * dispextern.h (struct bidi_it): New member frame_window_p.
6617 (bidi_init_it): Update prototypes.
6618 (display_prop_intangible_p): Update prototype.
6619 (compute_display_string_pos, compute_display_string_end):
6620 Declare prototypes.
6621 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6622 EMACS_INT.
6623
6624 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6625
6626 Malloc failure behavior now depends on size of allocation.
6627 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6628 * lisp.h: Change signatures accordingly.
6629 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6630 All callers changed. (Bug#8762)
6631
6632 * gnutls.c: Use Emacs's memory allocators.
6633 Without this change, the gnutls library would invoke malloc etc.
6634 directly, which causes problems on non-SYNC_INPUT hosts, and which
6635 runs afoul of improving memory_full behavior. (Bug#8761)
6636 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6637 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6638 xfree instead of the default malloc, realloc, free.
6639 (Fgnutls_boot): No need to check for memory allocation failure,
6640 since xmalloc does that for us.
6641
6642 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6643 * category.c (hash_get_category_set):
6644 * ccl.c (ccl_driver):
6645 * charset.c (Fdefine_charset_internal):
6646 * charset.h (struct charset.hash_index):
6647 * composite.c (get_composition_id, gstring_lookup_cache)
6648 (composition_gstring_put_cache):
6649 * composite.h (struct composition.hash_index):
6650 * dispextern.h (struct image.hash):
6651 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6652 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6653 (hashfn_equal, hashfn_user_defined, make_hash_table)
6654 (maybe_resize_hash_table, hash_lookup, hash_put)
6655 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6656 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6657 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6658 * image.c (make_image, search_image_cache, lookup_image)
6659 (xpm_put_color_table_h):
6660 * lisp.h (struct Lisp_Hash_Table):
6661 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6662 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6663 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6664 * alloc.c (allocate_vectorlike):
6665 Check for overflow in vector size calculations.
6666 * ccl.c (ccl_driver):
6667 Check for overflow when converting EMACS_INT to int.
6668 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6669 need to be updated by these changes.
6670 * fns.c (make_hash_table, maybe_resize_hash_table):
6671 Check for integer overflow with large hash tables.
6672 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6673 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6674 (SXHASH_REDUCE): New macro.
6675 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6676 Use it instead of discarding useful hash info with large hash values.
6677 (sxhash_float): New function.
6678 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6679 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6680 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6681 Rewrite to use FIXNUM_BITS, as this simplifies things.
6682 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6683 Adjust signatures to match updated version of code.
6684 (consing_since_gc): Now EMACS_INT, since a single hash table can
6685 use more than INT_MAX bytes.
6686
6687 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6688
6689 Make it possible to build with GCC-4.6+ -O2 -flto.
6690
6691 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6692
6693 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6694
6695 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6696 Call minibuffer-inactive-mode.
6697
6698 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6699
6700 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6701 Update dependencies.
6702
6703 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6704
6705 * data.c (init_data): Remove code for UTS, this system is not
6706 supported anymore.
6707
6708 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6709
6710 Don't force ./temacs to start in terminal mode.
6711
6712 * frame.c (make_initial_frame): Initialize faces in all cases, not
6713 only when CANNOT_DUMP is defined.
6714 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6715
6716 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6717
6718 * dispnew.c (add_window_display_history): Use const for the string
6719 pointer. Remove declaration, not needed.
6720
6721 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6722
6723 Use 'inline', not 'INLINE'.
6724 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6725 * alloc.c, fontset.c (INLINE): Remove.
6726 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6727 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6728 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6729 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6730 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6731
6732 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6733
6734 Make it possible to run ./temacs.
6735
6736 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6737 syms_of_callproc does the same thing. Remove test for
6738 "initialized", do it in the caller.
6739 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6740
6741 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6742
6743 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6744 (read_minibuf): Use get_minibuffer.
6745 (syms_of_minibuf): Use DEFSYM.
6746 (Qmetadata): New var.
6747 * data.c (Qbuffer): Don't make it static.
6748 (syms_of_data): Use DEFSYM.
6749
6750 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6751
6752 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6753 (CCL_CODE_MIN): New macro.
6754
6755 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6756
6757 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6758
6759 * eval.c (Qdebug): Now static.
6760 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6761 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6762 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6763
6764 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6765
6766 * image.c: Various fixes to ImageMagick code comments.
6767 (Fimagemagick_types): Doc fix.
6768
6769 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6770
6771 Minor fixes prompted by GCC 4.6.0 warnings.
6772
6773 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6774
6775 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6776 (x_clipboard_manager_save_all): Move extern decl to ...
6777 * xterm.h: ... here, so that it can be checked for consistency.
6778
6779 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6780
6781 * xselect.c (x_clipboard_manager_save_frame)
6782 (x_clipboard_manager_save_all): New functions.
6783 (Fx_clipboard_manager_save): Lisp function deleted.
6784
6785 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6786 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6787
6788 * xterm.h: Update prototype.
6789
6790 2011-05-28 William Xu <william.xwl@gmail.com>
6791
6792 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6793 exiting (Bug#8239).
6794
6795 2011-05-28 Jim Meyering <meyering@redhat.com>
6796
6797 Avoid a sign-extension bug in crypto_hash_function.
6798 * fns.c (to_uchar): Define.
6799 (crypto_hash_function): Use it to convert some newly-signed
6800 variables to unsigned, to avoid sign-extension bugs. For example,
6801 without this change, (md5 "truc") would evaluate to
6802 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6803 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6804 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6805
6806 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6807
6808 Integer overflow fixes.
6809
6810 * dbusbind.c: Serial number integer overflow fixes.
6811 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6812 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6813 to hold a serial number that is too large for a fixnum.
6814 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6815 Check for serial numbers out of range. Decode any serial number
6816 that was so large that it became a float. (Bug#8722)
6817
6818 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6819 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6820 Use XFASTINT rather than XUINT when numbers are nonnegative.
6821 (xd_append_arg, Fdbus_method_return_internal):
6822 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6823 arguments, check that Lisp number is nonnegative, rather than
6824 silently wrapping negative numbers around. (Bug#8722)
6825 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6826 (Bug#8722)
6827
6828 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6829
6830 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6831
6832 ccl: Add integer overflow checks.
6833 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6834 (IN_INT_RANGE): New macros.
6835 (ccl_driver): Use them to check for integer overflow when
6836 decoding a CCL program. Many of the new checks are whether XINT (x)
6837 fits in int; it doesn't always, on 64-bit hosts. The new version
6838 doesn't catch all possible integer overflows, but it's an
6839 improvement. (Bug#8719)
6840
6841 * alloc.c (make_event_array): Use XINT, not XUINT.
6842 There's no need for unsigned here.
6843
6844 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6845 This follows up to the 2011-05-06 change that substituted uintptr_t
6846 for EMACS_INT. This case wasn't caught back then.
6847
6848 Rework Fformat to avoid integer overflow issues.
6849 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6850 now (part of C89). Include <verify.h>.
6851 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6852 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6853 (Fformat): Avoid the prepass trying to compute sizes; it was only
6854 approximate and thus did not catch overflow reliably. Instead, walk
6855 through the format just once, formatting and computing sizes as we go,
6856 checking for integer overflow at every step, and allocating a larger
6857 buffer as needed. Keep track separately whether the format is
6858 multibyte. Keep only the most-recently calculated precision, rather
6859 than them all. Record whether each argument has been converted to
6860 string. Use EMACS_INT, not int, for byte and char and arg counts.
6861 Support field widths and precisions larger than INT_MAX. Avoid
6862 sprintf's undefined behavior with conversion specifications such as %#d
6863 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6864 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6865 formatting out-of-range floating point numbers with int
6866 formats. (Bug#8668)
6867
6868 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6869
6870 * data.c: Avoid integer truncation in expressions involving floats.
6871 * data.c: Include <intprops.h>.
6872 (arith_driver): When there's an integer overflow in an expression
6873 involving floating point, convert the integers to floating point
6874 so that the resulting value does not suffer from catastrophic
6875 integer truncation. For example, on a 64-bit host (* 4
6876 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6877 Do not rely on undefined behavior after integer overflow.
6878
6879 merge count_size_as_multibyte, parse_str_to_multibyte
6880 * character.c, character.h (count_size_as_multibyte):
6881 Rename from parse_str_to_multibyte; all uses changed.
6882 Check for integer overflow.
6883 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6884 since it's now a duplicate of the other. This is more of
6885 a character than a buffer op, so better that it's in character.c.
6886 * fns.c, print.c: Adjust to above changes.
6887
6888 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6891
6892 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6895 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6896 (x_clipboard_manager_save): Now static.
6897 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6898
6899 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6900 (crypto_hash_function): Now static.
6901 Fix pointer signedness problems. Avoid unnecessary initializations.
6902
6903 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6904
6905 * termhooks.h (Vselection_alist): Make it terminal-local.
6906
6907 * terminal.c (create_terminal): Initialize it.
6908
6909 * xselect.c: Support for clipboard managers.
6910 (Vselection_alist): Move to termhooks.h as terminal-local var.
6911 (LOCAL_SELECTION): New macro.
6912 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6913 (symbol_to_x_atom): Remove gratuitous arg.
6914 (x_handle_selection_request, lisp_data_to_selection_data)
6915 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6916 (x_own_selection, x_get_local_selection, x_convert_selection):
6917 New arg, specifying work frame. Use terminal-local Vselection_alist.
6918 (some_frame_on_display): Delete unused function.
6919 (Fx_own_selection_internal, Fx_get_selection_internal)
6920 (Fx_disown_selection_internal, Fx_selection_owner_p)
6921 (Fx_selection_exists_p): New optional frame arg.
6922 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6923 (x_handle_selection_clear): Don't treat other terminals with the
6924 same keyboard specially. Use the terminal-local Vselection_alist.
6925 (x_clear_frame_selections): Use Frun_hook_with_args.
6926
6927 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6928
6929 * xterm.h: Add support for those atoms.
6930
6931 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6932
6933 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6934 (converted_selections, conversion_fail_tag): New global variables.
6935 (x_selection_request_lisp_error): Free the above.
6936 (x_get_local_selection): Remove unnecessary code.
6937 (x_reply_selection_request): Args changed; handle arbitrary array
6938 of converted selections stored in converted_selections.
6939 Separate the XChangeProperty and SelectionNotify steps.
6940 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6941 (x_convert_selection): New function.
6942 (x_handle_selection_event): Simplify.
6943 (x_get_foreign_selection): Don't ignore incoming requests while
6944 waiting for an answer; this will fail when we implement
6945 SAVE_TARGETS, and seems unnecessary anyway.
6946 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6947 (Vx_sent_selection_functions): Doc fix.
6948
6949 2011-05-26 Leo Liu <sdl.web@gmail.com>
6950
6951 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6952
6953 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6954
6955 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6956
6957 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6958 for fringe update if it has periodic bitmap.
6959 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6960 and fringe_bitmap_periodic_p.
6961
6962 * fringe.c (get_fringe_bitmap_data): New function.
6963 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6964 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6965 row. Mark glyph row for fringe update if periodicity changed.
6966
6967 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6968 for fringe update unless it has periodic bitmap.
6969
6970 2011-05-25 Kenichi Handa <handa@m17n.org>
6971
6972 * xdisp.c (get_next_display_element): Set correct it->face_id for
6973 a static composition.
6974
6975 2011-05-24 Leo Liu <sdl.web@gmail.com>
6976
6977 * deps.mk (fns.o):
6978 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6979
6980 * fns.c (crypto_hash_function, Fsha1): New function.
6981 (Fmd5): Use crypto_hash_function.
6982 (syms_of_fns): Add Ssha1.
6983
6984 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 * gnutls.c: Remove unused macros.
6987 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6988 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6989 Remove macros that are defined and never used.
6990 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6991
6992 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6993
6994 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6995 (Fx_get_selection_internal): Minor cleanup.
6996 (Fx_own_selection_internal): Rename arguments for consistency with
6997 select.el.
6998
6999 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7000
7001 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7002
7003 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7004
7005 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7006
7007 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7008
7009 * dispnew.c (scrolling_window): Don't exclude the case that the
7010 last enabled row in the desired matrix touches the bottom boundary.
7011
7012 2011-05-21 Glenn Morris <rgm@gnu.org>
7013
7014 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7015 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7016 and add some more files.
7017
7018 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7019
7020 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7021 report_file_error introduced by the change from 2011-05-07.
7022
7023 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7024
7025 * systime.h (Time): Define only if emacs is defined.
7026 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7027 where the include path doesn't have X11/X.h by default. See
7028 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7029
7030 2011-05-20 Kenichi Handa <handa@m17n.org>
7031
7032 * composite.c (find_automatic_composition): Fix previous change.
7033
7034 2011-05-20 Glenn Morris <rgm@gnu.org>
7035
7036 * lisp.mk: New file, split from Makefile.in.
7037 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7038 (shortlisp): Remove.
7039 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7040
7041 2011-05-19 Glenn Morris <rgm@gnu.org>
7042
7043 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7044 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7045 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7046 (lisp): Set the order to that of loadup.el.
7047 (shortlisp): Make it a copy of $lisp.
7048 (SOME_MACHINE_LISP): Remove.
7049 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7050 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7051
7052 2011-05-18 Kenichi Handa <handa@m17n.org>
7053
7054 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7055 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7056 (find_automatic_composition): Mostly rewrite for efficiency.
7057
7058 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7059
7060 * makefile.w32-in: Update dependencies.
7061
7062 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7063
7064 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7065 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7066
7067 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7068
7069 Fix some integer overflow issues, such as string length overflow.
7070
7071 * insdel.c (count_size_as_multibyte): Check for string overflow.
7072
7073 * character.c (lisp_string_width): Check for string overflow.
7074 Use EMACS_INT, not int, for string indexes and lengths; in
7075 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7076 the resulting string length overflows an EMACS_INT; instead,
7077 report a string overflow if no precision given. When checking for
7078 precision exhaustion, use a check that cannot possibly have
7079 integer overflow. (Bug#8675)
7080 * character.h (lisp_string_width): Adjust to new signature.
7081
7082 * alloc.c (string_overflow): New function.
7083 (Fmake_string): Use it. This doesn't change behavior, but saves
7084 a few bytes and will simplify future changes.
7085 * character.c (string_escape_byte8): Likewise.
7086 * lisp.h (string_overflow): New decl.
7087
7088 Fixups, following up to the user-interface timestamp change.
7089 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7090 for UI timestamps, instead of unsigned long.
7091 * msdos.c (mouse_get_pos): Likewise.
7092 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7093 * w32gui.h (Time): Define by including "systime.h" rather than by
7094 declaring it ourselves. (Bug#8664)
7095
7096 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7097 * image.c (clear_image_cache): Likewise.
7098
7099 * term.c (term_mouse_position): Don't assume time_t wraparound.
7100
7101 Be more systematic about user-interface timestamps.
7102 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7103 and sometimes 'EMACS_UINT', to represent these timestamps.
7104 This change causes it to use 'Time' uniformly, as that's what X uses.
7105 This makes the code easier to follow, and makes it easier to catch
7106 integer overflow bugs such as Bug#8664.
7107 * frame.c (Fmouse_position, Fmouse_pixel_position):
7108 Use Time, not unsigned long, for user-interface timestamps.
7109 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7110 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7111 * keyboard.h (last_event_timestamp): Likewise.
7112 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7113 * menu.h (xmenu_show): Likewise.
7114 * term.c (term_mouse_position): Likewise.
7115 * termhooks.h (struct input_event.timestamp): Likewise.
7116 (struct terminal.mouse_position_hook): Likewise.
7117 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7118 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7119 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7120 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7121 what it was before.
7122 * menu.h, termhooks.h: Include "systime.h", for Time.
7123
7124 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7125 Don't assume that the difference between two unsigned long values
7126 can fit into an integer. At this point, we know button_down_time
7127 <= event->timestamp, so the difference must be nonnegative, so
7128 there's no need to cast the result if double-click-time is
7129 nonnegative, as it should be; check that it's nonnegative, just in
7130 case. This bug is triggered when events are more than 2**31 ms
7131 apart (about 25 days). (Bug#8664)
7132
7133 * xselect.c (last_event_timestamp): Remove duplicate decl.
7134 (x_own_selection): Remove needless cast to unsigned long.
7135
7136 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7137 that always fit in int. Use a sentinel instead of a counter, to
7138 avoid a temp and to allay GCC's concerns about possible int overflow.
7139 * frame.h (struct frame): Use int for menu_bar_items_used
7140 instead of EMACS_INT, since it always fits in int.
7141
7142 * menu.c (grow_menu_items): Check for int overflow.
7143
7144 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7145
7146 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7147 Before, the code was not consistent. These values cannot exceed
7148 2**31 - 1 so there's no need to make them unsigned.
7149 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7150 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7151 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7152 as modifiers.
7153 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7154
7155 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7156 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7157 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7158 presumably because the widths might not match.
7159
7160 * window.c (size_window): Avoid needless test at loop start.
7161
7162 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7163
7164 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7165
7166 2011-05-12 Drew Adams <drew.adams@oracle.com>
7167
7168 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7169
7170 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7171
7172 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7173 `width' to `bar_area_x' and `bar_area_width', respectively.
7174 (x_scroll_run): Take account of fringe background extension.
7175
7176 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7177 Rename local vars `left' and `width' to `bar_area_x' and
7178 `bar_area_width', respectively.
7179 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7180 background extension.
7181
7182 2011-05-10 Jim Meyering <meyering@redhat.com>
7183
7184 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7185
7186 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * image.c (Finit_image_library): Return t for built-in image types,
7189 like pbm and xbm. (Bug#8640)
7190
7191 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7192
7193 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7194
7195 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7196
7197 * w32console.c (Fset_screen_color): Doc fix.
7198 (Fget_screen_color): New function.
7199 (syms_of_ntterm): Defsubr it.
7200
7201 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7202 unlink the temporary file if Fcall_process didn't create it in the
7203 first place.
7204 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7205 child process will be redirected to a file specified with `:file'.
7206 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7207 cue to call_process_cleanup not to close that handle.
7208
7209 2011-05-07 Ben Key <bkey76@gmail.com>
7210
7211 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7212 one of two shell specific rules, either bootstrap-temacs-CMD or
7213 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7214 to the previous implementation of the bootstrap-temacs rule.
7215 The bootstrap-temacs-CMD rule is similar to the previous
7216 implementation of the bootstrap-temacs rule except that it
7217 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7218 variable.
7219
7220 These changes, along with some changes to nt/configure.bat,
7221 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7222 earlier fix to add support for --cflags and --ldflags options
7223 that include quotes so that it works whether make uses cmd or
7224 sh as the shell.
7225
7226 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7227
7228 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7229 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7230 is a constant.
7231 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7232 a string. Handle both cases.
7233 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7234 (Fdbus_register_method): Use Qinvalid_function.
7235
7236 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7237
7238 * makefile.w32-in: Update dependencies.
7239 (LISP_H): Add inttypes.h and stdin.h.
7240 (PROCESS_H): Add unistd.h.
7241
7242 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7243
7244 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7245 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7246
7247 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7248
7249 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7250
7251 * term.c (vfatal): Remove stray call to va_end.
7252 It's not needed and the C Standard doesn't allow it here anyway.
7253
7254 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7255 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7256
7257 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7258 bytes.
7259
7260 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7261
7262 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7263
7264 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7265
7266 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7267
7268 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7269
7270 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7271 * charset.c (Fdefine_charset_internal): Don't initialize
7272 charset.code_space[15]. The value was garbage, on hosts with
7273 32-bit int (Bug#8600).
7274
7275 * lread.c (read_integer): Be more consistent with string-to-number.
7276 Use string_to_number to do the actual conversion; this avoids
7277 rounding errors and fixes some other screwups. Without this fix,
7278 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7279 (digit_to_number): Move earlier, for benefit of read_integer.
7280 Return -1 if the digit is out of range for the base, -2 if it is
7281 not a digit in any supported base. (Bug#8602)
7282
7283 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7284
7285 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7286 to match comment at start of function. This also removes a
7287 GCC warning about overflow in a 32+64-bit port.
7288
7289 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7290
7291 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7292 Reported by Stefan Monnier in
7293 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7294 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7295 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7296
7297 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7298 (EMACS_UINTPTR): Likewise, with uintptr_t.
7299
7300 * lisp.h: Prefer 64-bit EMACS_INT if available.
7301 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7302 on 32-bit hosts that have 64-bit int, so that they can access
7303 large files.
7304 However, temporarily disable this change unless the temporary
7305 symbol WIDE_EMACS_INT is defined.
7306
7307 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7308
7309 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7310 This removes an assumption that EMACS_INT and long are the same
7311 width as pointers. The assumption is true for Emacs porting targets
7312 now, but we want to make other targets possible.
7313 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7314 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7315 In the rest of the code, change types of integers that hold casted
7316 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7317 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7318 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7319 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7320 No need to cast type when ORing.
7321 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7322 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7323 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7324 assume EMACS_INT is the same width as char *.
7325 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7326 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7327 Remove no-longer-needed casts.
7328 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7329 (xg_tool_bar_help_callback, xg_make_tool_item):
7330 Use EMACS_INTPTR to hold an integer
7331 that will be cast to void *; this can avoid a GCC warning
7332 if EMACS_INT is not the same width as void *.
7333 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7334 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7335 (current_message_1, set_message_1):
7336 Use a local to convert to proper width without a cast.
7337 * xmenu.c (dialog_selection_callback): Likewise.
7338
7339 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7340 Also, don't assume VALBITS / RAND_BITS is less than 5,
7341 and don't rely on undefined behavior when shifting a 1 left into
7342 the sign bit.
7343 * lisp.h (get_random): Change signature to match.
7344
7345 * lread.c (hash_string): Use size_t, not int, for hash computation.
7346 Normally we prefer signed values; but hashing is special, because
7347 it's better to use unsigned division on hash table sizes so that
7348 the remainder is nonnegative. Also, size_t is the natural width
7349 for hashing into memory. The previous code used 'int', which doesn't
7350 retain enough info to hash well into very large tables.
7351 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7352
7353 * dbusbind.c: Don't possibly lose pointer info when converting.
7354 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7355 Use XPNTR rather than XHASH, so that the high-order bits of
7356 the pointer aren't lost when converting through void *.
7357
7358 * eval.c (Fautoload): Don't double-shift a pointer.
7359
7360 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7361
7362 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7363
7364 * gnutls.c (DEF_GNUTLS_FN):
7365 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7366
7367 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7368
7369 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7370 marker. (Bug#8610)
7371
7372 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7373
7374 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7375 New version that can reserve upto 2GB of heap space.
7376
7377 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7378
7379 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7380
7381 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7382
7383 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7384 `gnutls_certificate_set_x509_key_file'.
7385
7386 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7387
7388 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7389 Update dependencies.
7390
7391 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7392
7393 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7394 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7395 Remove unused parameter `fildes'.
7396 * process.c (read_process_output, send_process): Don't pass it.
7397
7398 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7399
7400 Fix previous change: the library cache is defined in w32.c.
7401 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7402 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7403
7404 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7405
7406 Implement dynamic loading of GnuTLS on Windows.
7407
7408 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7409 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7410 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7411 Declare.
7412
7413 * gnutls.c (Qgnutls_dll): Define.
7414 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7415 (gnutls_*): Declare function pointers.
7416 (init_gnutls_functions): New function to initialize function pointers.
7417 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7418 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7419 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7420 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7421 (emacs_gnutls_write, emacs_gnutls_read)
7422 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7423 (Fgnutls_available_p): New function.
7424 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7425 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7426 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7427
7428 * image.c: Include w32.h.
7429 (Vimage_type_cache): Delete.
7430 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7431 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7432 (w32_delayed_load): Move to w32.c.
7433
7434 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7435
7436 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7437 (w32_delayed_load): Move from image.c. When loading a library, record
7438 its filename in the :loaded-from property of the library id.
7439 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7440 Initialize and staticpro them.
7441 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7442
7443 * process.c: Include lisp.h before w32.h, not after.
7444 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7445 instead of gnutls_record_check_pending.
7446
7447 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7448
7449 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7450
7451 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7452 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7453 as passed in.
7454
7455 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7456
7457 * xterm.c (x_set_frame_alpha): Do not set property on anything
7458 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7459
7460 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7461
7462 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7463
7464 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7467 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7468 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7469 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7470 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7471 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7472 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7473 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7474 (Qgnutls_bootprop_callbacks_verify): Make static.
7475
7476 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7477
7478 * callproc.c: Indentation fixup.
7479
7480 * sysdep.c (wait_for_termination_1): Make static.
7481 (wait_for_termination, interruptible_wait_for_termination):
7482 Move after wait_for_termination_1.
7483
7484 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7485
7486 * sysdep.c (interruptible_wait_for_termination): New function
7487 which is like wait_for_termination, but allows keyboard
7488 interruptions.
7489
7490 * callproc.c (Fcall_process): Add (:file "file") as an option for
7491 the STDOUT buffer.
7492 (Fcall_process_region): Ditto.
7493
7494 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7495
7496 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7497 rather than `XVECTOR (FOO)->size'.
7498
7499 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7500 inttypes.h, as a gnulib replacement is used if it not available in
7501 system headers.
7502
7503 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7504
7505 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7506 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7507 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7508
7509 * coding.c (coding_alloc_by_realloc): Error out if destination
7510 will grow beyond MOST_POSITIVE_FIXNUM.
7511 (decode_coding_emacs_mule): Abort if there isn't enough place in
7512 charbuf for the composition carryover bytes. Reserve an extra
7513 space for up to 2 characters produced in a loop.
7514 (decode_coding_iso_2022): Abort if there isn't enough place in
7515 charbuf for the composition carryover bytes.
7516
7517 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7518
7519 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7520 aborting when %lld or %lll format is passed.
7521 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7522 %llo or %llx format is passed. (Bug#8545)
7523
7524 * window.c (window_scroll_line_based): Use a marker instead of
7525 simple variables to record original value of point. (Bug#7952)
7526
7527 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7528 produced by %s or %c overflows available buffer space. (Bug#8545)
7529
7530 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7531
7532 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7533 (SIZE_MAX): Move defn after all includes, as they might #define it.
7534
7535 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7536
7537 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7538
7539 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7540
7541 * keyboard.c (Qdelayed_warnings_hook): Define.
7542 (command_loop_1): Run `delayed-warnings-hook'
7543 if Vdelayed_warnings_list is non-nil.
7544 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7545 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7546
7547 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7548
7549 * doprnt.c (doprnt): Don't return value smaller than the buffer
7550 size if the message was truncated. (Bug#8545).
7551
7552 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7555 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7556
7557 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7560
7561 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7562
7563 * makefile.w32-in: Update dependencies.
7564
7565 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7566
7567 Improve `doprnt' and its usage. (Bug#8545)
7568 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7569 `format_end'. Remove support for %l as a conversion specifier.
7570 Don't use xrealloc. Improve diagnostics when the %l size modifier
7571 is used. Update the commentary.
7572
7573 * eval.c (verror): Simplify calculation of size_t.
7574
7575 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7576 messages.
7577
7578 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7579
7580 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7581 change.
7582
7583 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7584
7585 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7586 This makes this file independent of the recent pseudovector change.
7587
7588 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7589
7590 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7591
7592 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7593 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7594 Remove unused local.
7595 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7596
7597 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7598 GCC 4.6.0 optimizes based on type-based alias analysis.
7599 For example, if b is of type struct buffer * and v of type struct
7600 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7601 != &v->size, and therefore "v->size = 1; b->size = 2; return
7602 v->size;" must therefore return 1. This assumption is incorrect
7603 for Emacs, since it type-puns struct Lisp_Vector * with many other
7604 types. To fix this problem, this patch adds a new type struct
7605 vectorlike_header that documents the constraints on layout of vectors
7606 and pseudovectors, and helps optimizing compilers not get fooled
7607 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7608 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7609 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7610 the size member.
7611 (XSETPVECTYPE): Rewrite in terms of new macro.
7612 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7613 This is a bit clearer, and further avoids the possibility of
7614 undesirable aliasing.
7615 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7616 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7617 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7618 since Lisp_Subr is a special case (no "next" field).
7619 (ASIZE): Now uses header.size rather than size.
7620 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7621 to avoid the hassle of writing XVECTOR (foo)->header.size.
7622 (struct vectorlike_header): New type.
7623 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7624 object, to help avoid aliasing.
7625 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7626 (SUBRP): Likewise, since Lisp_Subr is a special case.
7627 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7628 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7629 (struct Lisp_Hash_Table): Combine first two members into a single
7630 struct vectorlike_header member. All uses of "size" and "next" members
7631 changed to be "header.size" and "header.next".
7632 * buffer.h (struct buffer): Likewise.
7633 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7634 * frame.h (struct frame): Likewise.
7635 * process.h (struct Lisp_Process): Likewise.
7636 * termhooks.h (struct terminal): Likewise.
7637 * window.c (struct save_window_data, struct saved_window): Likewise.
7638 * window.h (struct window): Likewise.
7639 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7640 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7641 * buffer.c (init_buffer_once): Likewise.
7642 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7643 special case.
7644 * process.c (Fformat_network_address): Use local var for size,
7645 for brevity.
7646
7647 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7648
7649 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7650 * data.c (atof): Remove decl; no longer used or needed.
7651 (digit_to_number): Move to lread.c.
7652 (Fstring_to_number): Use new string_to_number function, to be
7653 consistent with how the Lisp reader treats infinities and NaNs.
7654 Do not assume that floating-point numbers represent EMACS_INT
7655 without losing information; this is not true on most 64-bit hosts.
7656 Avoid double-rounding errors, by insisting on integers when
7657 parsing non-base-10 numbers, as the documentation specifies.
7658 * lisp.h (string_to_number): New decl, replacing ...
7659 (isfloat_string): Remove.
7660 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7661 (read1): Do not accept +. and -. as integers; this
7662 appears to have been a coding error. Similarly, do not accept
7663 strings like +-1e0 as floating point numbers. Do not report
7664 overflow for integer overflows unless the base is not 10 which
7665 means we have no simple and reliable way to continue.
7666 Break out the floating-point parsing into a new
7667 function string_to_number, so that Fstring_to_number parses
7668 floating point numbers consistently with the Lisp reader.
7669 (digit_to_number): Move here from data.c. Make it static inline.
7670 (E_CHAR, EXP_INT): Remove, replacing with ...
7671 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7672 (string_to_number): New function, replacing isfloat_string.
7673 This function checks for valid syntax and produces the resulting
7674 Lisp float number too. Rework it so that string-to-number
7675 no longer mishandles examples like "1.0e+". Use strtoumax,
7676 so that overflow for non-base-10 numbers is reported only when
7677 there's no portable and simple way to convert to floating point.
7678
7679 * textprop.c (set_text_properties_1): Rewrite for clarity,
7680 and to avoid GCC warning about integer overflow.
7681
7682 * intervals.h (struct interval): Use EMACS_INT for members
7683 where EMACS_UINT might cause problems. See
7684 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7685 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7686 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7687 All uses changed.
7688 (offset_intervals): Tell GCC not to worry about length overflow
7689 when negating a negative length.
7690
7691 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7692 (overrun_check_free): Likewise.
7693
7694 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7695 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7696 word size.
7697
7698 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7699 (gnutls_make_error): Rename local to avoid shadowing.
7700 (gnutls_emacs_global_deinit): ifdef out; not used.
7701 (Fgnutls_boot): Use const for pointer to readonly storage.
7702 Comment out unused local. Fix pointer signedness problems.
7703
7704 * lread.c (openp): Don't stuff size_t into an 'int'.
7705 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7706 about possible signed overflow.
7707
7708 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7709 (GDK_KEY_g): Don't define if already defined.
7710 (xg_prepare_tooltip): Avoid pointer signedness problem.
7711 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7712
7713 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7714 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7715
7716 * xfns.c (Fx_window_property): Simplify a bit,
7717 to make a bit faster and to avoid GCC 4.6.0 warning.
7718 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7719
7720 * fns.c (internal_equal): Don't assume size_t fits in int.
7721
7722 * alloc.c (compact_small_strings): Tighten assertion a little.
7723
7724 Replace pEd with more-general pI, and fix some printf arg casts.
7725 * lisp.h (pI): New macro, generalizing old pEd macro to other
7726 conversion specifiers. For example, use "...%"pI"d..." rather
7727 than "...%"pEd"...".
7728 (pEd): Remove. All uses replaced with similar uses of pI.
7729 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7730 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7731 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7732 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7733 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7734 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7735 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7736 64-bit hosts.
7737 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7738 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7739 * print.c (safe_debug_print, print_object): Likewise.
7740 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7741 to int.
7742 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7743 avoiding the 0 flag, which is not portable.
7744 * process.c (Fmake_network_process): Use pI to avoid cast.
7745 * region-cache.c (pp_cache): Likewise.
7746 * xdisp.c (decode_mode_spec): Likewise.
7747 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7748 behavior on 64-bit hosts with printf arg.
7749 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7750 (x_stop_queuing_selection_requests): Likewise.
7751 (x_get_window_property): Don't truncate byte count to an 'int'
7752 when tracing.
7753
7754 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7755 here, since it parses constructs like leading '-' and spaces,
7756 which are not wanted; and it overflows with large numbers.
7757 Instead, simply match F[0-9]+, which is what is wanted anyway.
7758
7759 * alloc.c: Remove unportable assumptions about struct layout.
7760 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7761 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7762 (allocate_vectorlike, make_pure_vector): Use the new macros,
7763 plus offsetof, to remove unportable assumptions about struct layout.
7764 These assumptions hold on all porting targets that I know of, but
7765 they are not guaranteed, they're easy to remove, and removing them
7766 makes further changes easier.
7767
7768 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7769 This doesn't fix a bug but makes the code clearer.
7770 (string_overrun_cookie): Now const. Use initializers that
7771 don't formally overflow signed char, to avoid warnings.
7772 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7773 can cause Emacs to crash when string overrun checking is enabled.
7774 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7775 multiple of sizeof (EMACS_INT); it need not be, if
7776 alignof(EMACS_INT) < sizeof (EMACS_INT).
7777 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7778
7779 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7780
7781 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7782
7783 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7784
7785 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7786 supposed to be handshaking. (Bug#8556)
7787 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7788
7789 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7790
7791 * lisp.h (Qdebug): List symbol.
7792 * eval.c (Qdebug): Restore global linkage.
7793 * keyboard.c (debug-on-event): New variable.
7794 (handle_user_signal): Break into debugger when debug-on-event
7795 matches the current signal symbol.
7796
7797 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7798
7799 * alloc.c (check_sblock, check_string_bytes)
7800 (check_string_free_list): Convert to standard C.
7801
7802 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7803
7804 * w32.c (emacs_gnutls_push): Fix typo.
7805
7806 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7807
7808 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7809 "cast to pointer from integer of different size".
7810
7811 Improve doprnt and its use in verror. (Bug#8545)
7812 * doprnt.c (doprnt): Document the set of format control sequences
7813 supported by the function. Use SAFE_ALLOCA instead of always
7814 using `alloca'.
7815
7816 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7817 is one byte too soon. Don't use xrealloc; instead xfree and
7818 xmalloc anew.
7819
7820 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7821
7822 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7823 callbacks stage.
7824
7825 * gnutls.c: Renamed global_initialized to
7826 gnutls_global_initialized. Added internals for the
7827 :verify-hostname-error, :verify-error, and :verify-flags
7828 parameters of `gnutls-boot' and documented those parameters in the
7829 docstring. Start callback support.
7830 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7831 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7832 on error. Return error code.
7833 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7834 (emacs_gnutls_read): Likewise.
7835 (Fgnutls_boot): Return handshake error code.
7836 (emacs_gnutls_handle_error): New function.
7837 (wsaerror_to_errno): Likewise.
7838
7839 * w32.h (emacs_gnutls_pull): Add prototype.
7840 (emacs_gnutls_push): Likewise.
7841
7842 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7843 (emacs_gnutls_push): Likewise.
7844
7845 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7846
7847 * process.c (wait_reading_process_output): Check if GnuTLS
7848 buffered some data internally if no FDs are set for TLS
7849 connections.
7850
7851 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7852 (LIBS): Link to USER_LIBS.
7853 ($(BLD)/gnutls.$(0)): New target.
7854
7855 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7856
7857 * xdisp.c (handle_single_display_spec): Rename the
7858 display_replaced_before_p argument into display_replaced_p, to
7859 make it consistent with the commentary. Fix typos in the
7860 commentary.
7861
7862 * textprop.c (syms_of_textprop): Remove dead code.
7863 (copy_text_properties): Delete obsolete commentary about an
7864 interface that was deleted long ago. Fix typos in the description
7865 of arguments.
7866
7867 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7868 to changes in oldXMenu/XMenu.h from 2011-04-16.
7869 <menu_help_message, prev_menu_help_message>: Constify.
7870 (IT_menu_make_room): menu->help_text is now `const char **';
7871 adjust.
7872
7873 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7874 to changes in oldXMenu/XMenu.h from 2011-04-16.
7875 (struct XMenu): Declare `help_text' `const char **'.
7876
7877 * xfaces.c <Qunspecified>: Make extern again.
7878
7879 * syntax.c: Include sys/types.h before including regex.h, as
7880 required by POSIX.
7881
7882 * doc.c (get_doc_string): Improve the format passed to `error'.
7883
7884 * doprnt.c (doprnt): Improve commentary.
7885
7886 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7887
7888 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7889 them with etags.
7890
7891 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7892 changes in globals.h immediately force recompilation.
7893 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7894 $(CURDIR)/s/ms-w32.h.
7895 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7896
7897 * character.c (Fchar_direction): Function deleted.
7898 (syms_of_character): Don't defsubr it.
7899 <char-direction-table>: Deleted.
7900
7901 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7902
7903 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7904 * doprnt.c: Include limits.h.
7905 (SIZE_MAX): New macro.
7906 (doprnt): Return a size_t value. 2nd arg is now size_t.
7907 Many local variables are now size_t instead of int or unsigned.
7908 Improve overflow protection. Support `l' modifier for integer
7909 conversions. Support %l conversion. Don't assume an EMACS_INT
7910 argument for integer conversions and for %c.
7911
7912 * lisp.h (doprnt): Restore prototype.
7913
7914 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7915 $(SRC)/character.h.
7916
7917 * Makefile.in (base_obj): Add back doprnt.o.
7918
7919 * deps.mk (doprnt.o): Add back prerequisites.
7920 (callint.o): Depend on character.h.
7921
7922 * eval.c (internal_lisp_condition_case): Include the handler
7923 representation in the error message.
7924 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7925 when breaking from the loop.
7926
7927 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7928
7929 * callint.c (Fcall_interactively): When displaying error message
7930 about invalid control letter, pass the character's codepoint, not
7931 a pointer to its multibyte form. Improve display of the character
7932 in octal and display also its hex code.
7933
7934 * character.c (char_string): Use %x to display the (unsigned)
7935 codepoint of an invalid character, to avoid displaying a bogus
7936 negative value.
7937
7938 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7939 `error', not SYMBOL_NAME itself.
7940
7941 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7942 character arguments to `error'.
7943
7944 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7945 to `error' in error message about FINAL_CHAR argument. Make sure
7946 FINAL_CHAR is a character, and use %c when it is passed as
7947 argument to `error'.
7948
7949 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7950
7951 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7952
7953 * w32.c: Include <time.h>.
7954 (sys_localtime): New function.
7955
7956 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7957
7958 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7959
7960 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7961
7962 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7963
7964 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7965 zombies (Bug#8467).
7966
7967 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7968
7969 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7970 gl_state.e_property when gl_state.object is Qt.
7971
7972 * insdel.c (make_gap_larger): Remove limitation of buffer size
7973 to <= INT_MAX.
7974
7975 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7976
7977 * xdisp.c (lookup_glyphless_char_display)
7978 (produce_glyphless_glyph): Handle cons cell entry in
7979 glyphless-char-display.
7980 (Vglyphless_char_display): Document it.
7981
7982 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7983 glyphless-char-display.
7984
7985 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7986
7987 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7988
7989 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7990
7991 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7992 definition for no-X builds.
7993
7994 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7995
7996 Static checks with GCC 4.6.0 and non-default toolkits.
7997
7998 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7999
8000 * process.c (keyboard_bit_set): Define only if SIGIO.
8001 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8002 (send_process): Repair possible setjmp clobbering.
8003
8004 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8005
8006 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8007
8008 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8009
8010 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8011 Define only if needed.
8012
8013 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8014 by pacifying GCC about it. Maybe it's time to retire it?
8015 * xfaces.c (USG, __TIMEVAL__): Likewise.
8016
8017 * dispextern.h (struct redisplay_interface): Rename param
8018 to avoid shadowing.
8019 * termhooks.h (struct terminal): Likewise.
8020 * xterm.c (xembed_send_message): Likewise.
8021
8022 * insdel.c (make_gap_smaller): Define only if
8023 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8024
8025 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8026 it.
8027
8028 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8029 so that we aren't warned about unused symbols.
8030
8031 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8032
8033 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8034
8035 * xfns.c (x_real_positions): Mark locals as initialized.
8036
8037 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8038
8039 * xterm.c: Fix problems found by static analysis with other toolkits.
8040 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8041 (x_dispatch_event): Declare static if USE_GTK, and
8042 define if USE_GTK || USE_X_TOOLKIT.
8043 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8044 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8045 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8046 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8047
8048 * xmenu.c (menu_help_callback): Pointer type fixes.
8049 Use const pointers when pointing at readonly data. Avoid pointer
8050 signedness clashes.
8051 (FALSE): Remove unused macro.
8052 (update_frame_menubar): Remove unused decl.
8053
8054 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8055
8056 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8057 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8058 (single_menu_item): Rename local to avoid shadowing.
8059
8060 * keyboard.c (make_lispy_event): Remove unused local var.
8061
8062 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8063 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8064
8065 * bitmaps: Change bitmaps from unsigned char back to the X11
8066 compatible char. Avoid the old compiler warnings about
8067 out-of-range initializers by using, for example, '\xab' rather
8068 than 0xab.
8069
8070 * xgselect.c (xgselect_initialize): Check vs interface
8071 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8072
8073 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8074
8075 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8076 to read-only memory.
8077
8078 * fns.c (vector): Remove; this old hack is no longer needed.
8079
8080 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8081 Remove unused var.
8082 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8083
8084 * xrdb.c (x_load_resources): Omit unused local.
8085
8086 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8087 (x_window): Rename locals to avoid shadowing.
8088 (USG): Use the kludged USG macro, to pacify gcc.
8089
8090 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8091 (x_term_init): Remove local to avoid shadowing.
8092
8093 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8094
8095 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8096 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8097
8098 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8099
8100 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8101
8102 Fix regex.c, syntax.c and friends for buffers > 2GB.
8103 * syntax.h (struct gl_state_s): Declare character position members
8104 EMACS_INT.
8105
8106 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8107
8108 * textprop.c (verify_interval_modification, interval_of):
8109 Declare arguments EMACS_INT.
8110
8111 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8112 EMACS_INT.
8113
8114 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8115
8116 * indent.c (Fvertical_motion): Local variable it_start is now
8117 EMACS_INT.
8118
8119 * regex.c (re_match, re_match_2, re_match_2_internal)
8120 (bcmp_translate, regcomp, regexec, print_double_string)
8121 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8122 (re_compile_pattern, re_exec): Declare arguments and local
8123 variables `size_t' and `ssize_t' and return values `regoff_t', as
8124 appropriate.
8125 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8126 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8127 <compile_stack_type>: `size' and `avail' are now `size_t'.
8128
8129 * regex.h <regoff_t>: Use ssize_t, not int.
8130 (re_search, re_search_2, re_match, re_match_2): Arguments that
8131 specify buffer/string position and length are now ssize_t and
8132 size_t. Return type is regoff_t.
8133
8134 2011-04-16 Ben Key <bkey76@gmail.com>
8135
8136 * nsfont.m: Fixed bugs in ns_get_family and
8137 ns_descriptor_to_entity that were caused by using free to
8138 deallocate memory blocks that were allocated by xmalloc (via
8139 xstrdup). This caused Emacs to crash when compiled with
8140 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8141 --enable-checking=xmallocoverrun). xfree is now used to
8142 deallocate these memory blocks.
8143
8144 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8145
8146 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8147
8148 emacs_write: Accept and return EMACS_INT for sizes.
8149 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8150 et seq.
8151 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8152 Accept and return EMACS_INT.
8153 (emacs_gnutls_write): Return the number of bytes written on
8154 partial writes.
8155 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8156 (emacs_read, emacs_write): Remove check for negative size, as the
8157 Emacs source code has been audited now.
8158 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8159 (emacs_read, emacs_write): Use it.
8160 * process.c (send_process): Adjust to the new signatures of
8161 emacs_write and emacs_gnutls_write. Do not attempt to store
8162 a byte offset into an 'int'; it might overflow.
8163 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8164
8165 * sound.c: Don't assume sizes fit in 'int'.
8166 (struct sound_device.period_size, alsa_period_size):
8167 Return EMACS_INT, not int.
8168 (struct sound_device.write, vox_write, alsa_write):
8169 Accept EMACS_INT, not int.
8170 (wav_play, au_play): Use EMACS_INT to store sizes and to
8171 record read return values.
8172
8173 2011-04-15 Ben Key <bkey76@gmail.com>
8174
8175 * keyboard.c (Qundefined): Don't declare static since it is used
8176 in nsfns.m.
8177 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8178 static since they are used in nsfont.m.
8179
8180 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8181
8182 * process.c (Qprocessp): Don't declare static.
8183 * lisp.h (Qprocessp): Declare again.
8184
8185 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8186
8187 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8188
8189 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8190
8191 Improve C-level modularity by making more things 'static'.
8192
8193 Don't publish debugger-only interfaces to other modules.
8194 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8195 (verify_bytepos, count_markers): Move decls to the only modules
8196 that need them.
8197 * region-cache.h (pp_cache): Likewise.
8198 * window.h (check_all_windows): Likewise.
8199 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8200
8201 * sysdep.c (croak): Now static, if
8202 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8203 * syssignal.h (croak): Declare only if not static.
8204
8205 * alloc.c (refill_memory_reserve): Now static if
8206 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8207 * lisp.h (refill_memory_reserve): Declare only if not static.
8208
8209 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8210 Define only if USE_LUCID.
8211
8212 * xrdb.c (x_customization_string, x_rm_string): Now static.
8213
8214 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8215 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8216
8217 * xdisp.c (draw_row_with_mouse_face): Now static.
8218 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8219
8220 * window.h (check_all_windows): Mark externally visible.
8221
8222 * window.c (window_deletion_count): Now static.
8223
8224 * undo.c: Make symbols static if they're not exported.
8225 (last_undo_buffer, last_boundary_position, pending_boundary):
8226 Now static.
8227
8228 * textprop.c (interval_insert_behind_hooks): Now static.
8229 (interval_insert_in_front_hooks): Likewise.
8230
8231 * term.c: Make symbols static if they're not exported.
8232 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8233 (max_frame_lines, tty_set_terminal_modes):
8234 (tty_reset_terminal_modes, tty_turn_off_highlight):
8235 (get_tty_terminal): Now static.
8236 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8237 * termhooks.h (term_mouse_moveto): Do not declare if
8238 HAVE_WINDOW_SYSTEM.
8239 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8240 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8241
8242 * sysdep.c: Make symbols static if they're not exported.
8243 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8244 Now static.
8245 (sigprocmask_set, full_mask): Remove; unused.
8246 (wait_debugging): Mark as visible.
8247 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8248 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8249
8250 * syntax.c (syntax_temp): Define only if !__GNUC__.
8251
8252 * sound.c (current_sound_device, current_sound): Now static.
8253
8254 * search.c (searchbufs, searchbuf_head): Now static.
8255
8256 * scroll.c (scroll_cost): Remove; unused.
8257 * dispextern.h (scroll_cost): Remove decl.
8258
8259 * region-cache.h (pp_cache): Mark as externally visible.
8260
8261 * process.c: Make symbols static if they're not exported.
8262 (process_tick, update_tick, create_process, chan_process):
8263 (Vprocess_alist, proc_buffered_char, datagram_access):
8264 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8265 (deactivate_process): Mark defn as static, as well as decl.
8266 * lisp.h (create_process): Remove decl.
8267 * process.h (chan_process, Vprocess_alist): Remove decls.
8268
8269 * print.c: Make symbols static if they're not exported.
8270 (print_depth, new_backquote_output, being_printed, print_buffer):
8271 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8272 (print_interval, print_number_index, initial_stderr_stream):
8273 Now static.
8274 * lisp.h (Fprinc): Remove decl.
8275 (debug_output_compilation_hack): Mark as externally visible.
8276
8277 * sysdep.c (croak): Move decl from here to syssignal.h.
8278 * syssignal.h (croak): Put it here, so the API can be checked when
8279 'croak' is called from dissociate_if_controlling_tty.
8280
8281 * minibuf.c: Make symbols static if they're not exported.
8282 (minibuf_save_list, choose_minibuf_frame): Now static.
8283 * lisp.h (choose_minibuf_frame): Remove decl.
8284
8285 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8286
8287 * lread.c: Make symbols static if they're not exported.
8288 (read_objects, initial_obarray, oblookup_last_bucket_number):
8289 Now static.
8290 (make_symbol): Remove; unused.
8291 * lisp.h (initial_obarray, make_symbol): Remove decls.
8292
8293 * keyboard.c: Make symbols static if they're not exported.
8294 (single_kboard, recent_keys_index, total_keys, recent_keys):
8295 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8296 (this_single_command_key_start, echoing, last_auto_save):
8297 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8298 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8299 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8300 (Vlispy_mouse_stem, double_click_count):
8301 Now static.
8302 (force_auto_save_soon): Define only if SIGDANGER.
8303 (ignore_mouse_drag_p): Now static if
8304 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8305 (print_help): Remove; unused.
8306 (stop_character, last_timer_event): Mark as externally visible.
8307 * keyboard.h (ignore_mouse_drag_p): Declare only if
8308 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8309 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8310 * lisp.h (echoing): Remove decl.
8311 (force_auto_save_soon): Declare only if SIGDANGER.
8312 * xdisp.c (redisplay_window): Simplify code, to make it more
8313 obvious that ignore_mouse_drag_p is not accessed if !defined
8314 USE_GTK && !defined HAVE_NS.
8315
8316 * intervals.c: Make symbols static if they're not exported.
8317 (merge_properties_sticky, merge_interval_right, delete_interval):
8318 Now static.
8319 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8320
8321 * insdel.c: Make symbols static if they're not exported.
8322 However, leave prepare_to_modify_buffer alone. It's never
8323 called from outside this function, but that appears to be a bug.
8324 (combine_after_change_list, combine_after_change_buffer):
8325 (adjust_after_replace, signal_before_change): Now static.
8326 (adjust_after_replace_noundo): Remove; unused.
8327 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8328 (signal_before_change): Remove decls.
8329
8330 * indent.c (val_compute_motion, val_vmotion): Now static.
8331
8332 * image.c: Make symbols static if they're not exported.
8333 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8334 if USE_GTK.
8335 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8336 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8337
8338 * fringe.c (standard_bitmaps): Now static.
8339 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8340
8341 * frame.c: Make symbols static if they're not exported.
8342 (x_report_frame_params, make_terminal_frame): Now static.
8343 (get_frame_param): Now static, unless HAVE_NS.
8344 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8345 (x_get_resource_string): Remove; not used.
8346 * frame.h (make_terminal_frame, x_report_frame_params):
8347 (x_get_resource_string); Remove decls.
8348 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8349 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8350
8351 * font.c, fontset.c: Make symbols static if they're not exported.
8352 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8353 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8354 * font.c (font_close_object): Now static.
8355 * font.h (font_close_object): Remove.
8356 * fontset.c (FONTSET_OBJLIST): Remove.
8357 (free_realized_fontset) #if-0 the body, which does nothing.
8358 (face_suitable_for_char_p): #if-0, as it's never called.
8359 * fontset.h (face_suitable_for_char_p): Remove decl.
8360 * xfaces.c (face_at_string_position):
8361 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8362 since 0 is always ASCII.
8363
8364 * fns.c (weak_hash_tables): Now static.
8365
8366 * fileio.c: Make symbols static if they're not exported.
8367 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8368 (Vwrite_region_annotation_buffers): Now static.
8369
8370 * eval.c: Make symbols static if they're not exported.
8371 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8372 * lisp.h (backtrace_list): Remove decl.
8373
8374 * emacs.c: Make symbols static if they're not exported.
8375 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8376 (fatal_error_code, fatal_error_signal_hook, standard_args):
8377 Now static.
8378 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8379 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8380 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8381 * lisp.h (fatal_error_signal_hook): Remove decl.
8382 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8383
8384 * editfns.c: Move a (normally-unused) function to its only use.
8385 * editfns.c, lisp.h (get_operating_system_release): Remove.
8386 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8387 worth the hassle of breaking this out.
8388
8389 * xterm.c: Make symbols static if they're not exported.
8390 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8391 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8392 (x_destroy_window, x_delete_display):
8393 Now static.
8394 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8395 (x_mouse_leave): Remove; unused.
8396 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8397 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8398 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8399 Remove decls.
8400 (x_mouse_leave): Declare only if WINDOWSNT.
8401 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8402 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8403 USE_X_TOOLKIT.
8404
8405 * ftxfont.c: Make symbols static if they're not exported.
8406 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8407 HAVE_FREETYPE.
8408 * font.h (ftxfont_driver): Likewise.
8409
8410 * xfns.c: Make symbols static if they're not exported.
8411 (x_last_font_name, x_display_info_for_name):
8412 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8413 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8414 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8415 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8416 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8417 (last_show_tip_args): Now static.
8418 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8419 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8420 (x_screen_planes): Remove; unused.
8421 * dispextern.h (x_screen_planes): Remove decl.
8422
8423 * dispnew.c: Make symbols static if they're not exported.
8424 * dispextern.h (redraw_garbaged_frames, scrolling):
8425 (increment_row_positions): Remove.
8426 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8427 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8428 Now static.
8429 (redraw_garbaged_frames): Remove; unused.
8430
8431 * xfaces.c: Make symbols static if they're not exported.
8432 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8433 Remove decls.
8434 * xterm.h (defined_color): Remove decls.
8435 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8436 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8437 (menu_face_changed_default, defined_color, free_realized_face):
8438 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8439 (ascii_face_of_lisp_face): Remove; unused.
8440
8441 * xdisp.c: Make symbols static if they're not exported.
8442 * dispextern.h (scratch_glyph_row, window_box_edges):
8443 (glyph_to_pixel_coords, set_cursor_from_row):
8444 (get_next_display_element, set_iterator_to_next):
8445 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8446 (show_mouse_face): Remove decls
8447 * frame.h (message_buf_print): Likewise.
8448 * lisp.h (pop_message, set_message, check_point_in_composition):
8449 Likewise.
8450 * xterm.h (set_vertical_scroll_bar): Likewise.
8451 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8452 (message_buf_print, scratch_glyph_row, displayed_buffer):
8453 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8454 (get_next_display_element, show_mouse_face, window_box_edges):
8455 (frame_to_window_pixel_xy, check_point_in_composition):
8456 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8457 (glyph_to_pixel_coords): Remove; unused.
8458
8459 * dired.c (file_name_completion): Now static.
8460
8461 * dbusbind.c (xd_in_read_queued_messages): Now static.
8462
8463 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8464 * data.c (circular_list_error): Remove.
8465
8466 * commands.h (last_point_position, last_point_position_buffer):
8467 (last_point_position_window): Remove decls.
8468 * keyboard.c: Make these variables static.
8469
8470 * coding.h (coding, code_convert_region, encode_coding_gap):
8471 Remove decls.
8472 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8473 (iso_code_class, detect_coding, code_convert_region): Now static.
8474 (encode_coding_gap): Remove; unused.
8475
8476 * chartab.c (chartab_chars, chartab_bits): Now static.
8477
8478 * charset.h (charset_iso_8859_1): Remove decl.
8479 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8480 Now static.
8481
8482 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8483 * ccl.c (Vccl_program_table): Now static.
8484 (check_ccl_update): Remove; unused.
8485
8486 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8487 * category.h: ... from here.
8488 * category.c (check_category_table, set_category_set): Now static.
8489
8490 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8491 * lisp.h: Remove these decls.
8492
8493 * buffer.c (buffer_count): Remove unused var.
8494
8495 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8496 so that it's not optimized away.
8497 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8498 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8499 exported only to the debugger.
8500
8501 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8502 * atimer.h (run_all_atimers): Remove; not exported.
8503
8504 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8505 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8506 was inaccessible from Lisp.
8507 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8508 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8509
8510 alloc.c: Import and export fewer symbols, and remove unused items.
8511 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8512 is defined.
8513 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8514 it's not optimized away by whole-program optimization.
8515 (message_enable_multibyte, free_misc): Remove.
8516 (catchlist, handlerlist, mark_backtrace):
8517 Declare only if BYTE_MARK_STACK.
8518 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8519 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8520 (message_enable_multibyte): Remove decl.
8521 (free_misc, interval_free_list, float_block, float_block_index):
8522 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8523 (cons_free_list, last_marked_index):
8524 Now static.
8525 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8526 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8527 (mark_backtrace): Define only if BYTE_MARK_STACK.
8528 * xdisp.c (message_enable_multibyte): Now static.
8529
8530 Declare Lisp_Object Q* variables to be 'static' if not exported.
8531 This makes it easier for human readers (and static analyzers)
8532 to see whether these variables are used from other modules.
8533 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8534 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8535 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8536 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8537 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8538 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8539 * xmenu.c, xselect.c:
8540 Declare Q* vars static if they are not used in other modules.
8541 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8542 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8543 Remove decls of unexported vars.
8544 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8545
8546 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8547
8548 Make Emacs functions such as Fatom 'static' by default.
8549 This makes it easier for human readers (and static analyzers)
8550 to see whether these functions can be called from other modules.
8551 DEFUN now defines a static function. To make the function external
8552 so that it can be used in other C modules, use the new macro DEFUE.
8553 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8554 (Finit_image_library):
8555 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8556 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8557 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8558 Remove decls, since these functions are now static.
8559 (Funintern, Fget_internal_run_time): New decls, since these functions
8560 were already external.
8561
8562 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8563 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8564 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8565 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8566 * keyboard.c, keymap.c, lread.c:
8567 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8568 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8569 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8570 Mark functions with DEFUE instead of DEFUN,
8571 if they are used in other modules.
8572 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8573 decls for now-static functions.
8574 * buffer.h (Fdelete_overlay): Remove decl.
8575 * callproc.c (Fgetenv_internal): Mark as internal.
8576 * composite.c (Fremove_list_of_text_properties): Remove decl.
8577 (Fcomposition_get_gstring): New forward static decl.
8578 * composite.h (Fcomposite_get_gstring): Remove decl.
8579 * dired.c (Ffile_attributes): New forward static decl.
8580 * doc.c (Fdocumntation_property): New forward static decl.
8581 * eval.c (Ffetch_bytecode): New forward static decl.
8582 (Funintern): Remove extern decl; now in .h file where it belongs.
8583 * fileio.c (Fmake_symbolic_link): New forward static decl.
8584 * image.c (Finit_image_library): New forward static decl.
8585 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8586 * intervals.h (Fprevious_property_change):
8587 (Fremove_list_of_text_properties): Remove decls.
8588 * keyboard.c (Fthis_command_keys): Remove decl.
8589 (Fcommand_execute): New forward static decl.
8590 * keymap.c (Flookup_key): New forward static decl.
8591 (Fcopy_keymap): Now static.
8592 * keymap.h (Flookup_key): Remove decl.
8593 * process.c (Fget_process): New forward static decl.
8594 (Fprocess_datagram_address): Mark as internal.
8595 * syntax.c (Fsyntax_table_p): New forward static decl.
8596 (skip_chars): Remove duplicate decl.
8597 * textprop.c (Fprevious_property_change): New forward static decl.
8598 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8599 Now internal.
8600 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8601 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8602
8603 * editfns.c (Fformat): Remove unreachable code.
8604
8605 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8606
8607 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8608 change. (Bug#8496)
8609
8610 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8611
8612 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8613 when at ZV. (Bug#8487)
8614
8615 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8616
8617 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8618 (Bug#8437)
8619 * keyboard.c (parse_tool_bar_item): Likewise.
8620 * sound.c (sound_cleanup, alsa_close): Likewise.
8621 * termcap.c (tgetent): Likewise.
8622 * xfns.c (x_default_font_parameter): Likewise.
8623 * xsettings.c (read_and_apply_settings): Likewise.
8624
8625 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8626 (overrun_check_free): Protoize.
8627
8628 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8629
8630 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8631 since callers should never pass a negative size.
8632 Change the signature to match that of plain 'read' and 'write'; see
8633 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8634 * lisp.h: Update prototypes of emacs_write and emacs_read.
8635
8636 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8637
8638 * xdisp.c (redisplay_window): Don't try to determine the character
8639 position of the scroll margin if the window start point w->startp
8640 is outside the buffer's accessible region. (Bug#8468)
8641
8642 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8643
8644 Fix write-region and its subroutines for buffers > 2GB.
8645 * fileio.c (a_write, e_write): Modify declaration of arguments and
8646 local variables to support buffers larger than 2GB.
8647 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8648
8649 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8650 argument, local variables, and return value.
8651
8652 * lisp.h: Update prototypes of emacs_write and emacs_read.
8653
8654 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8655
8656 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8657
8658 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8659
8660 Fix more problems found by GCC 4.6.0's static checks.
8661
8662 * xdisp.c (vmessage): Use a better test for character truncation.
8663
8664 * charset.c (load_charset_map): <, not <=, for optimization,
8665 and to avoid potential problems with integer overflow.
8666 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8667 * casetab.c (set_identity, shuffle): Likewise.
8668 * editfns.c (Fformat): Likewise.
8669 * syntax.c (skip_chars): Likewise.
8670
8671 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8672 This also lets GCC 4.6.0 generate slightly better loop code.
8673
8674 * callint.c (Fcall_interactively): <, not <=, for optimization.
8675 (Fcall_interactively): Count the number of arguments produced,
8676 not the number of arguments given. This is simpler and lets GCC
8677 4.6.0 generate slightly better code.
8678
8679 * ftfont.c: Distingish more carefully between FcChar8 and char.
8680 The previous code passed unsigned char * to a functions like
8681 strlen and xstrcasecmp that expect char *, which does not
8682 conform to the C standard.
8683 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8684 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8685 char * when the C standard requires it.
8686
8687 * keyboard.c (read_char): Remove unused var.
8688
8689 * eval.c: Port to Windows vsnprintf (Bug#8435).
8690 Include <limits.h>.
8691 (SIZE_MAX): Define if the headers do not.
8692 (verror): Do not give up if vsnprintf returns a negative count.
8693 Instead, grow the buffer. This ports to Windows vsnprintf, which
8694 does not conform to C99. Problem reported by Eli Zaretskii.
8695 Also, simplify the allocation scheme, by avoiding the need for
8696 calling realloc, and removing the ALLOCATED variable.
8697
8698 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8699
8700 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8701 But keep the doprint source code for now, as we might revamp it
8702 and use it again (Bug#8435).
8703 * lisp.h (doprnt): Remove.
8704 * Makefile.in (base_obj): Remove doprnt.o.
8705 * deps.mk (doprnt.o): Remove.
8706
8707 error: Print 32- and 64-bit integers portably (Bug#8435).
8708 Without this change, on typical 64-bit hosts error ("...%d...", N)
8709 was used to print both 32- and 64-bit integers N, which relied on
8710 undefined behavior.
8711 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8712 * lisp.h (error, verror): Mark as printf-like functions.
8713 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8714 Report overflow in size calculations when allocating printf buffer.
8715 Do not truncate output string at its first null byte.
8716 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8717 Truncate the output at a character boundary, since vsnprintf does not
8718 do that.
8719 * charset.c (check_iso_charset_parameter): Convert internal
8720 character to string before calling 'error', since %c now has the
8721 printf meaning.
8722 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8723 overflow when computing char to be passed to 'error'. Do not
8724 pass Lisp_Object to 'error'; pass the integer instead.
8725 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8726 formatted with plain %d.
8727
8728 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8729
8730 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8731
8732 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8733
8734 * xterm.c (x_catch_errors): Remove duplicate declaration.
8735
8736 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8737
8738 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8739
8740 2011-04-10 Jim Meyering <meyering@redhat.com>
8741
8742 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8743 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8744 return ssize_t not "int", and use size_t as the buffer length.
8745 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8746 * gnutls.h: Update declarations.
8747 * process.c (read_process_output): Use ssize_t, to match.
8748 (send_process): Likewise.
8749
8750 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8751
8752 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8753
8754 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8755
8756 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8757 Use unsigned char, to match FcChar8 type definition.
8758
8759 * xterm.c (handle_one_xevent):
8760 * xmenu.c (create_and_show_popup_menu):
8761 * xselect.c (x_decline_selection_request)
8762 (x_reply_selection_request): Avoid type-punned deref of X events.
8763
8764 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8765
8766 Fix some uses of `int' instead of EMACS_INT.
8767 * search.c (string_match_1, fast_string_match)
8768 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8769 (scan_buffer, find_next_newline_no_quit)
8770 (find_before_next_newline, search_command, Freplace_match)
8771 (Fmatch_data): Make some `int' variables be EMACS_INT.
8772
8773 * xdisp.c (display_count_lines): 3rd argument and return value now
8774 EMACS_INT. All callers changed.
8775 (pint2hrstr): Last argument is now EMACS_INT.
8776
8777 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8778 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8779 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8780 (decode_coding_utf_16, decode_coding_emacs_mule)
8781 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8782 (decode_coding_ccl, decode_coding_charset)
8783 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8784 (decode_coding_iso_2022, decode_coding_emacs_mule)
8785 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8786 <char_offset, last_offset>: Declare EMACS_INT.
8787 (encode_coding_utf_8, encode_coding_utf_16)
8788 (encode_coding_emacs_mule, encode_invocation_designation)
8789 (encode_designation_at_bol, encode_coding_iso_2022)
8790 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8791 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8792 Declare EMACS_INT.
8793 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8794 (encode_invocation_designation): Last argument P_NCHARS is now
8795 EMACS_INT.
8796 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8797 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8798
8799 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8800 All users changed.
8801
8802 * ccl.c (Fccl_execute_on_string): Declare some variables
8803 EMACS_INT.
8804
8805 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8806
8807 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8808
8809 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8810
8811 * process.c (Fformat_network_address): Doc fix.
8812
8813 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8814
8815 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8816
8817 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8818
8819 * keyboard.c (read_char): Call Lisp function help-form-show,
8820 instead of using internal_with_output_to_temp_buffer.
8821 (Qhelp_form_show): New var.
8822 (syms_of_keyboard): Use DEFSYM macro.
8823
8824 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8825
8826 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8827
8828 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8829
8830 * process.c (Flist_processes): Remove to Lisp.
8831 (list_processes_1): Delete.
8832
8833 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8834
8835 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8836
8837 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8838
8839 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8840
8841 Fix more problems found by GCC 4.6.0's static checks.
8842
8843 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8844
8845 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8846
8847 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8848
8849 * xdisp.c (vmessage): Mark as a printf-like function.
8850
8851 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8852
8853 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8854
8855 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8856 printf-like functions.
8857 (tiff_load): Add casts to remove these marks before passing them
8858 to system-supplied API.
8859
8860 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8861
8862 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8863 This avoids several warnings with gcc -Wstrict-overflow.
8864 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8865 directly, rather than having caller test rule sign. This avoids
8866 some unnecessary tests.
8867 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8868 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8869 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8870
8871 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8872 (xfont_open): Avoid unnecessary tests.
8873
8874 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8875
8876 * composite.h, composite.c (composition_gstring_put_cache):
8877 Use EMACS_INT, not int, for length.
8878
8879 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8880 breaking out part of COMPOSITION_DECODE_RULE.
8881 (COMPOSITION_DECODE_RULE): Use it.
8882 * composite.c (get_composition_id): Remove unused local vars,
8883 by using the new macro.
8884
8885 * textprop.c (set_text_properties_1): Change while to do-while,
8886 since the condition is always true at first.
8887
8888 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8889 (interval_deletion_adjustment): Return unsigned value.
8890 All uses changed.
8891
8892 * process.c (list_processes_1, create_pty, read_process_output):
8893 (exec_sentinel): Remove vars that were set but not used.
8894 (create_pty): Remove unnecessary "volatile"s.
8895 (Fnetwork_interface_info): Avoid possibility of int overflow.
8896 (read_process_output): Do adaptive read buffering even if carryover.
8897 (read_process_output): Simplify nbytes computation if buffered.
8898
8899 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8900
8901 * syntax.c (scan_words): Remove var that was set but not used.
8902 (update_syntax_table): Use unsigned instead of int.
8903
8904 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8905 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8906 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8907
8908 * print.c (print_error_message): Avoid int overflow.
8909
8910 * font.c (font_list_entities): Redo for clarity,
8911 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8912
8913 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8914 (font_score): Avoid potential overflow in diff calculation.
8915
8916 * fns.c (substring_both): Remove var that is set but not used.
8917 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8918
8919 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8920
8921 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8922 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8923 can always succeed if overflow has undefined behavior.
8924
8925 * search.c (boyer_moore, wordify): Remove vars set but not used.
8926 (wordify): Omit three unnecessary tests.
8927
8928 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8929 All callers changed. This avoids the need for an unused var.
8930
8931 * casefiddle.c (casify_region): Remove var that is set but not used.
8932
8933 * dired.c (file_name_completion): Remove var that is set but not used.
8934
8935 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8936
8937 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8938 (Finsert_file_contents): Remove unnecessary code checking fd.
8939
8940 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8941 Check for integer overflow on size calculations.
8942
8943 * buffer.c (Fprevious_overlay_change): Remove var that is set
8944 but not used.
8945
8946 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8947 Remove vars that are set but not used.
8948 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8949 (timer_check_2): Mark vars as initialized.
8950
8951 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8952
8953 * image.c (lookup_image): Remove var that is set but not used.
8954 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8955
8956 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8957 that are set but not used.
8958
8959 * xfns.c (make_invisible_cursor): Don't return garbage
8960 if XCreateBitmapFromData fails (Bug#8410).
8961
8962 * xselect.c (x_get_local_selection, x_handle_property_notify):
8963 Remove vars that are set but not used.
8964
8965 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8966 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8967
8968 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8969 Remove var that is set but not used.
8970 (scroll_bar_windows_size): Now size_t, not int.
8971 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8972 Check for overflow.
8973
8974 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8975 (map_tty_color) [!defined MSDOS]: Likewise.
8976
8977 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8978
8979 * coding.c: Remove vars that are set but not used.
8980 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8981 All callers changed.
8982 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8983 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8984 (decode_coding_charset): Remove vars that are set but not used.
8985
8986 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8987 that is set but not used.
8988
8989 * print.c (print_object): Remove var that is set but not used.
8990
8991 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8992 The gnulib version avoids calling malloc in the usual case,
8993 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8994 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8995 * filelock.c (current_lock_owner): Likewise.
8996 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8997 * sysdep.c: Include allocator.h, careadlinkat.h.
8998 (emacs_no_realloc_allocator): New static constant.
8999 (emacs_readlink): New function.
9000 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9001 ../lib/careadlinkat.h.
9002
9003 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9004
9005 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9006 first non-nil return value).
9007
9008 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9009
9010 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9011 if not defined (Bug#8403).
9012
9013 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9014
9015 * xdisp.c (display_count_lines): Remove parameter `start',
9016 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9017 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9018 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9019 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9020 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9021 and thereabouts. All callers changed.
9022 (get_per_char_metric): Remove parameter `f', unused since
9023 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9024
9025 2011-04-02 Jim Meyering <meyering@redhat.com>
9026
9027 do not dereference NULL upon failed strdup
9028 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9029 (ns_get_family): Likewise.
9030
9031 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9032
9033 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9034
9035 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9036
9037 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9038 later (Bug#8403).
9039
9040 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9041
9042 Add lexical binding.
9043
9044 * window.c (Ftemp_output_buffer_show): New fun.
9045 (Fsave_window_excursion):
9046 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9047
9048 * lread.c (lisp_file_lexically_bound_p): New function.
9049 (Fload): Bind Qlexical_binding.
9050 (readevalloop): Remove `evalfun' arg.
9051 Bind Qinternal_interpreter_environment.
9052 (Feval_buffer): Bind Qlexical_binding.
9053 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9054 Mark as dynamic.
9055 (syms_of_lread): Declare `lexical-binding'.
9056
9057 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9058
9059 * keyboard.c (eval_dyn): New fun.
9060 (menu_item_eval_property): Use it.
9061
9062 * image.c (parse_image_spec): Use Ffunctionp.
9063
9064 * fns.c (concat, mapcar1): Accept byte-code-functions.
9065
9066 * eval.c (Fsetq): Handle lexical vars.
9067 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9068 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9069 (FletX, Flet): Obey lexical binding.
9070 (Fcommandp): Handle closures.
9071 (Feval): New `lexical' arg.
9072 (eval_sub): New function extracted from Feval. Use it almost
9073 everywhere where Feval was used. Look up vars in lexical env.
9074 Handle closures.
9075 (Ffunctionp): Move from subr.el.
9076 (Ffuncall): Handle closures.
9077 (apply_lambda): Remove `eval_flags'.
9078 (funcall_lambda): Handle closures and new byte-code-functions.
9079 (Fspecial_variable_p): New function.
9080 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9081 but without exporting it to Lisp.
9082
9083 * doc.c (Fdocumentation, store_function_docstring):
9084 * data.c (Finteractive_form): Handle closures.
9085
9086 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9087 interactive spec.
9088
9089 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9090 New byte-codes.
9091 (exec_byte_code): New function extracted from Fbyte_code to handle new
9092 calling convention for byte-code-functions. Add new byte-codes.
9093
9094 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9095
9096 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9097
9098 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9099
9100 * xdisp.c (redisplay_internal): Fix prototype.
9101
9102 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9103
9104 * xdisp.c (SCROLL_LIMIT): New macro.
9105 (try_scrolling): Use it when setting scroll_limit.
9106 Limit scrolling to 100 screen lines.
9107 (redisplay_window): Even when falling back on "recentering",
9108 position point in the window according to scroll-conservatively,
9109 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9110
9111 (try_scrolling): When point is above the window, allow searching
9112 as far as scroll_max, or one screenful, to compute vertical
9113 distance from PT to the scroll margin position. This prevents
9114 try_scrolling from unnecessarily failing when
9115 scroll-conservatively is set to a value slightly larger than the
9116 window height. Clean up the case of PT below the margin at bottom
9117 of window: scroll_max can no longer be INT_MAX. When aggressive
9118 scrolling is in use, don't let point enter the opposite scroll
9119 margin as result of the scroll.
9120 (syms_of_xdisp) <scroll-conservatively>: Document the
9121 threshold of 100 lines for never-recentering scrolling.
9122
9123 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9124
9125 * dispextern.h (move_it_by_lines):
9126 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9127 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9128 (message_log_check_duplicate): Remove parameters `prev_bol' and
9129 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9130 (redisplay_internal): Remove parameter `preserve_echo_area',
9131 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9132
9133 * indent.c (Fvertical_motion):
9134 * window.c (window_scroll_pixel_based, Frecenter):
9135 Don't pass `need_y_p' to `move_it_by_lines'.
9136
9137 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9138
9139 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9140 steal a few bits to be more compact.
9141 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9142 Remove unneeded casts.
9143
9144 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9145
9146 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9147
9148 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9149 binding" message (bug#7967).
9150
9151 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9152
9153 Fix more problems found by GCC 4.6.0's static checks.
9154
9155 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9156 Remove unused local var.
9157
9158 * editfns.c (Fmessage_box): Remove unused local var.
9159
9160 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9161 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9162 Omit unused local vars.
9163 * window.c (shrink_windows): Omit unused local var.
9164 * menu.c (digest_single_submenu): Omit unused local var.
9165 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9166 Omit unused local var.
9167
9168 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9169 Don't assume string length fits in int.
9170 (keyremap_step, read_key_sequence): Use size_t for sizes.
9171 (read_key_sequence): Don't check last_real_key_start redundantly.
9172
9173 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9174 instead of alloca (Bug#8344).
9175
9176 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9177 (Fbacktrace_frame): Don't assume nframes fits in int.
9178
9179 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9180
9181 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9182 concerns.
9183
9184 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9185
9186 * cm.c (calccost): Turn while-do into do-while, for clarity.
9187
9188 * keyboard.c (syms_of_keyboard): Use the same style as later
9189 in this function when indexing through an array. This also
9190 works around GCC bug 48267.
9191
9192 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9193
9194 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9195
9196 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9197 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9198
9199 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9200 This avoids undefined behavior on integer overflow, and is a bit
9201 more convenient anyway since it is compared to a size_t variable.
9202
9203 Variadic C functions now count arguments with size_t, not int.
9204 This avoids an unnecessary limitation on 64-bit machines, which
9205 caused (substring ...) to crash on large vectors (Bug#8344).
9206 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9207 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9208 All variadic functions and their callers changed accordingly.
9209 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9210 * data.c (arith_driver, float_arith_driver): Likewise.
9211 * editfns.c (general_insert_function): Likewise.
9212 * eval.c (struct backtrace.nargs, interactive_p)
9213 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9214 (funcall_lambda, mark_backtrace): Likewise.
9215 * fns.c (concat): Likewise.
9216 * frame.c (x_set_frame_parameters): Likewise.
9217 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9218 0 if not found, not -1. All callers changed.
9219
9220 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9221 (stack_copy_size): Now size_t, not int.
9222 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9223
9224 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9225
9226 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9227 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9228 All callers changed.
9229
9230 * lisp.h (multibyte_char_to_unibyte):
9231 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9232 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9233 * character.h (CHAR_TO_BYTE8):
9234 * cmds.c (internal_self_insert):
9235 * editfns.c (general_insert_function):
9236 * keymap.c (push_key_description):
9237 * search.c (Freplace_match):
9238 * xdisp.c (message_dolog, set_message_1): All callers changed.
9239
9240 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9241
9242 * keyboard.c (safe_run_hook_funcall): New function.
9243 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9244 don't set the hook to nil, but remove the offending function instead.
9245 (Qcommand_hook_internal): Remove, unused.
9246 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9247 Vcommand_hook_internal.
9248
9249 * eval.c (enum run_hooks_condition): Remove.
9250 (funcall_nil, funcall_not): New functions.
9251 (run_hook_with_args): Call each function through a `funcall' argument.
9252 Remove `cond' argument, now redundant.
9253 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9254 (Frun_hook_with_args_until_failure): Adjust accordingly.
9255 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9256
9257 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9258
9259 * dispextern.h (string_buffer_position): Remove declaration.
9260
9261 * print.c (strout): Remove parameter `multibyte', unused since
9262 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9263
9264 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9265 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9266 All callers changed.
9267
9268 * w32.c (_wsa_errlist): Use braces for struct initializers.
9269
9270 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9271 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9272 All callers changed.
9273 (string_buffer_position): Likewise. Also, make static (it's never
9274 used outside xdisp.c).
9275 (cursor_row_p): Remove parameter `w', unused since
9276 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9277 (decode_mode_spec): Remove parameter `precision', introduced during
9278 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9279 All callers changed.
9280
9281 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9282
9283 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9284
9285 2011-03-27 Anders Lindgren <andlind@gmail.com>
9286
9287 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9288 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9289 (ns_update_auto_hide_menu_bar): New functions.
9290 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9291 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9292 ns_constrain_all_frames.
9293 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9294 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9295
9296 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9297
9298 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9299
9300 2011-03-27 Glenn Morris <rgm@gnu.org>
9301
9302 * syssignal.h: Replace RETSIGTYPE with void.
9303 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9304 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9305 Replace SIGTYPE with void everywhere.
9306 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9307 * s/template.h (SIGTYPE): Remove commented out definition.
9308
9309 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9310
9311 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9312 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9313
9314 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9315
9316 * w32.c (read_unc_volume): Use parameter `henum', instead of
9317 global variable `wget_enum_handle'.
9318
9319 * keymap.c (describe_vector): Remove parameters `indices' and
9320 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9321 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9322
9323 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9324
9325 * keyboard.c (timer_check): Remove parameter `do_it_now',
9326 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9327 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9328 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9329
9330 * keyboard.c (read_char):
9331 * w32menu.c (w32_menu_display_help):
9332 * xmenu.c (show_help_event, menu_help_callback):
9333 Adjust calls to `show_help_echo'.
9334
9335 * gtkutil.c (xg_maybe_add_timer):
9336 * keyboard.c (readable_events):
9337 * process.c (wait_reading_process_output):
9338 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9339
9340 * insdel.c (adjust_markers_gap_motion):
9341 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9342 (gap_left, gap_right): Don't call it.
9343
9344 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9345
9346 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9347 incurred during fontification.
9348
9349 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9350
9351 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9352 (DEFVAR_PER_BUFFER): Don't pass it.
9353
9354 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9355 (scrolling_window): Don't pass it.
9356
9357 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9358
9359 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9360
9361 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9362 and `suffix'.
9363 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9364 of variables specific to SELinux and computation of `encoded_absname'.
9365
9366 * image.c (XPutPixel): Remove unused variable `height'.
9367
9368 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9369
9370 * unexw32.c (get_section_info): Remove unused variable `section'.
9371
9372 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9373 (system_process_attributes): Remove unused variable `sess'.
9374 (sys_read): Remove unused variable `err'.
9375
9376 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9377 (w32_wnd_proc): Remove unused variable `isdead'.
9378 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9379 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9380 (x_create_tip_frame): Remove unused variable `tem'.
9381
9382 * w32inevt.c (w32_console_read_socket):
9383 Remove unused variable `no_events'.
9384
9385 * w32term.c (x_draw_composite_glyph_string_foreground):
9386 Remove unused variable `width'.
9387
9388 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9389
9390 * w32term.c (x_set_glyph_string_clipping):
9391 Don't pass uninitialized region to CombineRgn.
9392
9393 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9394
9395 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9396 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9397 (Fx_close_connection): Remove unused variable `i'.
9398
9399 * w32font.c (w32font_draw): Return number of glyphs.
9400 (w32font_open_internal): Remove unused variable `i'.
9401 (w32font_driver): Add missing initializer.
9402
9403 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9404 (fill_in_menu): Remove unused variable `items_added'.
9405
9406 * w32term.c (last_mouse_press_frame): Remove static global variable.
9407 (w32_clip_to_row): Remove unused variable `f'.
9408 (x_delete_terminal): Remove unused variable `i'.
9409
9410 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9411 (NOTHING): Remove unused static global variable.
9412 (uniscribe_check_otf): Remove unused variable `table'.
9413 (uniscribe_font_driver): Add missing initializers.
9414
9415 2011-03-23 Julien Danjou <julien@danjou.info>
9416
9417 * term.c (Fsuspend_tty, Fresume_tty):
9418 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9419 * window.c (temp_output_buffer_show):
9420 * insdel.c (signal_before_change):
9421 * frame.c (Fhandle_switch_frame):
9422 * fileio.c (Fdo_auto_save):
9423 * emacs.c (Fkill_emacs):
9424 * editfns.c (save_excursion_restore):
9425 * cmds.c (internal_self_insert):
9426 * callint.c (Fcall_interactively):
9427 * buffer.c (Fkill_all_local_variables):
9428 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9429 Use Frun_hooks.
9430 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9431 unconditionally since it does the check itself.
9432
9433 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9434
9435 Fix more problems found by GCC 4.5.2's static checks.
9436
9437 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9438 the first time through the loop, since we know p0 < p1 then.
9439 This also avoids a gcc -Wstrict-overflow warning.
9440
9441 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9442 leading to a memory leak, possible in functions like
9443 load_charset_map_from_file that can allocate an unbounded number
9444 of objects (Bug#8318).
9445
9446 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9447 that could (at least in theory) be that large.
9448
9449 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9450 This is less likely to overflow, and avoids undefined behavior if
9451 overflow does occur. All callers changed. Use strtoul to scan
9452 for the unsigned long integer.
9453 (pint2hrstr): Simplify and tune code slightly.
9454 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9455
9456 * scroll.c (do_scrolling): Work around GCC bug 48228.
9457 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9458
9459 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9460 This also avoids a warning with gcc -Wstrict-overflow.
9461 (validate_x_resource_name): Simplify count usage.
9462 This also avoids a warning with gcc -Wstrict-overflow.
9463
9464 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9465 fail (Bug#8306).
9466
9467 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9468
9469 * process.c (Fmake_network_process): Use socklen_t, not int,
9470 where POSIX says socklen_t is required in portable programs.
9471 This fixes a porting bug on hosts like 64-bit HP-UX, where
9472 socklen_t is wider than int (Bug#8277).
9473 (Fmake_network_process, server_accept_connection):
9474 (wait_reading_process_output, read_process_output):
9475 Likewise.
9476
9477 * process.c: Rename or move locals to avoid shadowing.
9478 (list_processes_1, Fmake_network_process):
9479 (read_process_output_error_handler, exec_sentinel_error_handler):
9480 Rename or move locals.
9481 (Fmake_network_process): Define label "retry_connect" only if needed.
9482 (Fnetwork_interface_info): Fix pointer signedness.
9483 (process_send_signal): Add cast to avoid pointer signedness problem.
9484 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9485 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9486
9487 Make tparam.h and terminfo.c consistent.
9488 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9489 Include tparam.h instead, since it declares them.
9490 * cm.h (PC): Remove extern decl; tparam.h now does this.
9491 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9492 * terminfo.c: Include tparam.h, to check interfaces.
9493 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9494 (tparam): Adjust signature to match interface in tparam.h;
9495 this removes some undefined behavior. Check that outstring and len
9496 are zero, which they always are with Emacs.
9497 * tparam.h (PC, BC, UP): New extern decls.
9498
9499 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9500 (xftfont_open): Rename locals to avoid shadowing.
9501
9502 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9503 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9504 (OTF_TAG_SYM): Omit macro if not needed.
9505 (ftfont_list): Remove unused local.
9506 (get_adstyle_property, ftfont_pattern_entity):
9507 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9508 Rename locals to avoid shadowing.
9509
9510 * xfont.c (xfont_list_family): Mark var as initialized.
9511
9512 * xml.c (make_dom): Now static.
9513
9514 * composite.c (composition_compute_stop_pos): Rename local to
9515 avoid shadowing.
9516 (composition_reseat_it): Remove unused locals.
9517 (find_automatic_composition, composition_adjust_point): Likewise.
9518 (composition_update_it): Mark var as initialized.
9519 (find_automatic_composition): Mark vars as initialized,
9520 with a FIXME (Bug#8290).
9521
9522 character.h: Rename locals to avoid shadowing.
9523 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9524 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9525 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9526 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9527 to avoid shadowing.
9528
9529 * textprop.c (property_change_between_p): Remove; unused.
9530
9531 * intervals.c (interval_start_pos): Now static.
9532
9533 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9534
9535 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9536 Rename locals to avoid shadowing.
9537
9538 * sound.c (wav_play, au_play, Fplay_sound_internal):
9539 Fix pointer signedness.
9540 (alsa_choose_format): Remove unused local var.
9541 (wav_play): Initialize a variable to 0, to prevent undefined
9542 behavior (Bug#8278).
9543
9544 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9545
9546 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9547
9548 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9549 clobbering (Bug#8298).
9550 * sysdep.c (sys_subshell): Likewise.
9551 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9552
9553 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9554 This should get cleaned up, so that child_setup has the
9555 same signature on all platforms.
9556
9557 * callproc.c (call_process_cleanup): Now static.
9558 (relocate_fd): Rename locals to avoid shadowing.
9559
9560 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9561
9562 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9563 not to be necessary, and produces flickering.
9564
9565 2011-03-20 Glenn Morris <rgm@gnu.org>
9566
9567 * config.in: Remove file.
9568
9569 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9570
9571 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9572 are now in src/globals.h.
9573 (syms_of_minibuf): Remove spurious & from previous change.
9574
9575 2011-03-20 Leo Liu <sdl.web@gmail.com>
9576
9577 * minibuf.c (completing-read-function): New variable.
9578 (completing-read-default): Rename from completing-read.
9579 (completing-read): Call completing-read-function.
9580
9581 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9582
9583 * xfaces.c (Fx_load_color_file):
9584 Read color file from absolute filename (bug#8250).
9585
9586 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9587
9588 * makefile.w32-in: Update dependencies.
9589
9590 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9591
9592 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9593
9594 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9595
9596 Fix more problems found by GCC 4.5.2's static checks.
9597
9598 * process.c (make_serial_process_unwind, send_process_trap):
9599 (sigchld_handler): Now static.
9600
9601 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9602 That way, the code declares only the vars that it needs.
9603 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9604 * s/cygwin.h (PTY_ITERATION): Likewise.
9605 * s/darwin.h (PTY_ITERATION): Likewise.
9606 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9607
9608 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9609 * process.c (allocate_pty): Don't declare stb unless it's needed.
9610
9611 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9612 (CONSTANTLIM): Remove; unused.
9613 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9614 Define only if needed.
9615
9616 * unexelf.c (unexec): Name an expression,
9617 to avoid gcc -Wbad-function-cast warning.
9618 Use a different way to cause a compilation error if anyone uses
9619 n rather than nn, a way that does not involve shadowing.
9620 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9621
9622 * deps.mk (unexalpha.o): Remove; unused.
9623
9624 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9625 * unexec.h: New file.
9626 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9627 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9628 Depend on unexec.h.
9629 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9630 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9631 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9632 Change as necessary to match prototype in unexec.h.
9633
9634 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9635 shadowing.
9636 (back_comment, skip_chars): Mark vars as initialized.
9637
9638 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9639 Rename locals to avoid shadowing.
9640
9641 * lread.c (read1): Rewrite so as not to use empty "else".
9642 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9643
9644 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9645
9646 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9647 warning when compiling print.c.
9648
9649 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9650 instead of using an uninitialized var.
9651 (font_sort_entities): Mark var as initialized.
9652
9653 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9654
9655 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9656 pointers to constants.
9657 (font_parse_fcname): Remove unused vars.
9658 (font_delete_unmatched): Now static.
9659 (font_get_spec): Remove; unused.
9660 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9661 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9662 Rename or move locals to avoid shadowing.
9663
9664 * fns.c (require_nesting_list, require_unwind): Now static.
9665 (Ffillarray): Rename locals to avoid shadowing.
9666
9667 * floatfns.c (domain_error2): Define only if needed.
9668 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9669
9670 * alloc.c (mark_backtrace): Move decl from here ...
9671 * lisp.h: ... to here, so that it can be checked.
9672
9673 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9674 (Fdefvar): Rewrite so as not to use empty "else".
9675 (lisp_indirect_variable): Name an expression,
9676 to avoid gcc -Wbad-function-cast warning.
9677 (Fdefvar): Rename locals to avoid shadowing.
9678
9679 * callint.c (quotify_arg, quotify_args): Now static.
9680 (Fcall_interactively): Rename locals to avoid shadowing.
9681 Use const pointer when appropriate.
9682
9683 * lisp.h (get_system_name, get_operating_system_release):
9684 Move decls here, to check interfaces.
9685 * process.c (get_operating_system_release): Move decl to lisp.h.
9686 * xrdb.c (get_system_name): Likewise.
9687 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9688 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9689 some of which prompt warnings from gcc -Wbad-function-cast.
9690 (Fformat_time_string, Fencode_time, Finsert_char):
9691 (Ftranslate_region_internal, Fformat):
9692 Rename or remove local vars to avoid shadowing.
9693 (Ftranslate_region_internal): Mark var as initialized.
9694
9695 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9696 avoid shadowing.
9697
9698 * lisp.h (eassert): Check that the argument compiles, even if
9699 ENABLE_CHECKING is not defined.
9700
9701 * data.c (Findirect_variable): Name an expression, to avoid
9702 gcc -Wbad-function-cast warning.
9703 (default_value, arithcompare, arith_driver, arith_error): Now static.
9704 (store_symval_forwarding): Rename local to avoid shadowing.
9705 (Fmake_variable_buffer_local, Fmake_local_variable):
9706 Mark variables as initialized.
9707 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9708
9709 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9710 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9711 Rename locals to avoid shadowing.
9712 (mark_stack): Move local variables into the #ifdef region where
9713 they're used.
9714 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9715 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9716 needed otherwise.
9717 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9718 (GC_STRING_CHARS): Remove; not used.
9719 (Fmemory_limit): Cast sbrk's returned value to char *.
9720
9721 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9722 avoids undefined behavior in theory.
9723
9724 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9725
9726 Use functions, not macros, for up- and down-casing (Bug#8254).
9727 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9728 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9729 to use the following functions instead of these macros.
9730 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9731 EMACS_INT, since callers assume the returned value fits in int.
9732 (upcase1): Likewise, for UPCASE_TABLE.
9733 (uppercasep, lowercasep, upcase): New static inline functions.
9734 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9735 the race-condition problem in the old DOWNCASE.
9736
9737 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9738 Rename locals to avoid shadowing.
9739 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9740 (regex_compile, re_search_2, re_match_2_internal):
9741 Remove unused local vars.
9742 (FREE_VAR): Rewrite so as not to use empty "else",
9743 which gcc can warn about.
9744 (regex_compile, re_match_2_internal): Mark locals as initialized.
9745 (RETALLOC_IF): Define only if needed.
9746 (WORDCHAR_P): Likewise. This one is never needed, but is used
9747 only in a comment talking about a compiler bug, so put inside
9748 the #if 0 of that comment.
9749 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9750 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9751 Remove; unused.
9752
9753 * search.c (boyer_moore): Rename locals to avoid shadowing.
9754 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9755 (PREV_CHAR_BOUNDARY): Likewise.
9756
9757 * search.c (simple_search): Remove unused var.
9758
9759 * dired.c (compile_pattern): Move decl from here ...
9760 * lisp.h: ... to here, so that it can be checked.
9761 (struct re_registers): New forward decl.
9762
9763 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9764
9765 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9766 All uses changed.
9767 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9768 Rename locals to avoid shadowing.
9769 (Fvertical_motion): Mark locals as initialized.
9770
9771 * casefiddle.c (casify_object, casify_region): Now static.
9772 (casify_region): Mark local as initialized.
9773
9774 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9775
9776 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9777 New macros, so that the caller can use some names other than
9778 gcpro1, gcpro2, etc.
9779 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9780 of the new macros.
9781 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9782 argument, for consistency with GCPRO2_VAR, etc: it is now the
9783 prefix of the variable, not the variable itself. All uses
9784 changed.
9785 * dired.c (directory_files_internal, file_name_completion):
9786 Rename locals to avoid shadowing.
9787
9788 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9789 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9790 dired.c's scmp function, had undefined behavior.
9791 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9792 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9793 * buffer.h: ... to here, because these macros use current_buffer,
9794 and the new implementation with inline functions needs to have
9795 current_buffer in scope now, rather than later when the macros
9796 are used.
9797 (downcase, upcase1): New static inline functions.
9798 (DOWNCASE, UPCASE1): Reimplement using these functions.
9799 This avoids undefined behavior in expressions like
9800 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9801 from race conditions in accessing the global variables
9802 case_temp1 and case_temp2.
9803 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9804 * lisp.h (case_temp1, case_temp2): Remove their decls.
9805 * character.h (ASCII_CHAR_P): Move from here ...
9806 * lisp.h: ... to here, so that the inline functions mentioned
9807 above can use them.
9808
9809 * dired.c (directory_files_internal_unwind): Now static.
9810
9811 * fileio.c (file_name_as_directory, directory_file_name):
9812 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9813 Now static.
9814 (file_name_as_directory): Use const pointers when appropriate.
9815 (Fexpand_file_name): Likewise. In particular, newdir might
9816 point at constant storage, so make it a const pointer.
9817 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9818 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9819 signedness issues.
9820 (Fset_file_times, Finsert_file_contents, auto_save_error):
9821 Rename locals to avoid shadowing.
9822
9823 * minibuf.c (choose_minibuf_frame_1): Now static.
9824 (Ftry_completion, Fall_completions): Rename or remove locals
9825 to avoid shadowing.
9826
9827 * marker.c (bytepos_to_charpos): Remove; unused.
9828
9829 * lisp.h (verify_bytepos, count_markers): New decls,
9830 so that gcc does not warn that these functions aren't declared.
9831
9832 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9833 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9834 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9835 (copy_text): Remove unused local var.
9836
9837 * filelock.c (within_one_second): Now static.
9838 (lock_file_1): Rename local to avoid shadowing.
9839
9840 * buffer.c (fix_overlays_before): Mark locals as initialized.
9841 (fix_start_end_in_overlays): Likewise. This function should be
9842 simplified by using pointers-to-pointers, but that's a different
9843 matter.
9844 (switch_to_buffer_1): Now static.
9845 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9846 (report_overlay_modification): Rename locals to avoid shadowing.
9847
9848 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9849 Fix pointer signedness issue.
9850 (sys_subshell): Mark local as volatile if checking for lint,
9851 to suppress a gcc -Wclobbered warning that does not seem to be right.
9852 (MAXPATHLEN): Define only if needed.
9853
9854 * process.c (serial_open, serial_configure): Move decls from here ...
9855 * systty.h: ... to here, so that they can be checked.
9856
9857 * fns.c (get_random, seed_random): Move extern decls from here ...
9858 * lisp.h: ... to here, so that they can be checked.
9859
9860 * sysdep.c (reset_io): Now static.
9861 (wait_for_termination_signal): Remove; unused.
9862
9863 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9864 (copy_keymap_item, append_key, push_text_char_description):
9865 Now static.
9866 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9867 (DENSE_TABLE_SIZE): Remove; unused.
9868 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9869 (describe_map_tree):
9870 Rename locals to avoid shadowing.
9871
9872 * keyboard.c: Declare functions static if they are not used elsewhere.
9873 (echo_char, echo_dash, cmd_error, top_level_2):
9874 (poll_for_input, handle_async_input): Now static.
9875 (read_char, kbd_buffer_get_event, make_lispy_position):
9876 (make_lispy_event, make_lispy_movement, apply_modifiers):
9877 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9878 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9879 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9880 (read_key_sequence, read_char): Mark locals as initialized.
9881 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9882
9883 * keyboard.h (make_ctrl_char): New decl.
9884 (mark_kboards): Move decl here ...
9885 * alloc.c (mark_kboards): ... from here.
9886
9887 * lisp.h (force_auto_save_soon): New decl.
9888
9889 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9890 (DEFINE_DUMMY_FUNCTION): New macro.
9891 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9892 Use it.
9893 (main): Add casts to avoid warnings
9894 if GCC considers string literals to be constants.
9895
9896 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9897
9898 * dbusbind.c: Pointer signedness fixes.
9899 (xd_signature, xd_append_arg, xd_initialize):
9900 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9901 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9902 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9903 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9904
9905 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9906 if GCC considers string literals to be constants.
9907 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9908
9909 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9910
9911 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9912 (print_preprocess, print_object): New macro to fix last change.
9913
9914 * print.c (print_preprocess): Don't forget font objects.
9915
9916 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9917
9918 * emacs.c (USAGE3): Doc fixes.
9919
9920 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9921
9922 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9923 structure.
9924
9925 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9926
9927 * lisp.h (VWindow_system, Qfile_name_history):
9928 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9929 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9930 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9931
9932 * w32select.c: Don't #include "keyboard.h".
9933 (run_protected): Add extern declaration for waiting_for_input.
9934
9935 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9936 * w32console.c (detect_input_pending, read_input_pending)
9937 (encode_terminal_code):
9938 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9939 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9940 (w32_system_caret_y, Qfile_name_history):
9941 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9942 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9943 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9944 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9945 * w32proc.c (Qlocal, report_file_error):
9946 * w32term.c (Vwindow_system, updating_frame):
9947 * w32uniscribe.c (initialized, uniscribe_font_driver):
9948 Remove unneeded extern declarations.
9949
9950 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9951
9952 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9953
9954 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9955
9956 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9957 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9958 These macros can no longer be used for assignment.
9959
9960 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9961 Assign struct members directly, instead of using BUF_BEGV etc.
9962 (record_buffer_markers, fetch_buffer_markers): New functions for
9963 recording and fetching special buffer markers.
9964 (set_buffer_internal_1, set_buffer_temp): Use them.
9965
9966 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9967
9968 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9969
9970 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9971 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9972
9973 * xdisp.c (hscroll_window_tree):
9974 (reconsider_clip_changes): Use PT instead of BUF_PT.
9975
9976 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9977
9978 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9979 $(EMACS_ROOT)/lib/intprops.h.
9980
9981 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9982
9983 Fix more problems found by GCC 4.5.2's static checks.
9984
9985 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9986 to unsigned char * to avoid compiler diagnostic.
9987 (xg_free_frame_widgets): Make it clear that a local variable is
9988 needed only if USE_GTK_TOOLTIP.
9989 (gdk_window_get_screen): Make it clear that this macro is needed
9990 only if USE_GTK_TOOLTIP.
9991 (int_gtk_range_get_value): New function, which avoids a diagnostic
9992 from gcc -Wbad-function-cast.
9993 (xg_set_toolkit_scroll_bar_thumb): Use it.
9994 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9995 diagnostic from gcc -Wbad-function-cast.
9996 (get_utf8_string, xg_get_file_with_chooser):
9997 Rename locals to avoid shadowing.
9998 (create_dialog): Move locals to avoid shadowing.
9999
10000 * xgselect.c (xg_select): Remove unused var.
10001
10002 * image.c (four_corners_best): Mark locals as initialized.
10003 (gif_load): Initialize transparent_p to zero (Bug#8238).
10004 Mark another local as initialized.
10005 (my_png_error, my_error_exit): Mark with NO_RETURN.
10006
10007 * image.c (clear_image_cache): Now static.
10008 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10009 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10010 (x_edge_detection): Remove unnecessary cast that
10011 gcc -Wbad-function-cast diagnoses.
10012 (gif_load): Fix pointer signedness.
10013 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10014 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10015
10016 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10017
10018 Improve quality of tests for time stamp overflow.
10019 For example, without this patch (encode-time 0 0 0 1 1
10020 1152921504606846976) returns the obviously-bogus value (-948597
10021 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10022 reports time overflow. See
10023 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10024 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10025 * editfns.c: Include limits.h and intprops.h.
10026 (TIME_T_MIN, TIME_T_MAX): New macros.
10027 (time_overflow): Move earlier, to before first use.
10028 (hi_time, lo_time): New functions, for an accurate test for
10029 out-of-range times.
10030 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10031 (Fget_internal_run_time): Don't assume time_t fits in int.
10032 (make_time): Use list2 instead of Fcons twice.
10033 (Fdecode_time): More accurate test for out-of-range times.
10034 (check_tm_member): New function.
10035 (Fencode_time): Use it, to test for out-of-range times.
10036 (lisp_time_argument): Don't rely on undefined left-shift and
10037 right-shift behavior when checking for time stamp overflow.
10038
10039 * editfns.c (time_overflow): New function, refactoring common code.
10040 (Fformat_time_string, Fdecode_time, Fencode_time):
10041 (Fcurrent_time_string): Use it.
10042
10043 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10044 * dired.c (make_time): Move to ...
10045 * editfns.c (make_time): ... here.
10046 * systime.h: Note the move.
10047
10048 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10049
10050 * fringe.c (update_window_fringes): Remove unused variables.
10051
10052 * unexmacosx.c (copy_data_segment): Also copy __got section.
10053 (Bug#8223)
10054
10055 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10056
10057 * termcap.c [MSDOS]: Include "msdos.h".
10058 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10059 Constify `char *' arguments and their references according to
10060 prototypes in tparam.h.
10061
10062 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10063
10064 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10065 Adapt all references accordingly.
10066
10067 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10068
10069 2011-03-11 Tom Tromey <tromey@redhat.com>
10070
10071 * buffer.c (syms_of_buffer): Remove obsolete comment.
10072
10073 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10074
10075 * termhooks.h (encode_terminal_code): Declare prototype.
10076
10077 * msdos.c (encode_terminal_code): Don't declare prototype.
10078
10079 * term.c (encode_terminal_code): Now external again, used by
10080 w32console.c and msdos.c.
10081
10082 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10083 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10084
10085 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10086
10087 Fix some minor problems found by GCC 4.5.2's static checks.
10088
10089 * fringe.c (update_window_fringes): Mark locals as initialized
10090 (Bug#8227).
10091 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10092
10093 * alloc.c (mark_fringe_data): Move decl from here ...
10094 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10095 to check its interface.
10096 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10097
10098 * fontset.c (free_realized_fontset): Now static.
10099 (Fset_fontset_font): Rename local to avoid shadowing.
10100 (fontset_font): Mark local as initialized.
10101 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10102
10103 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10104
10105 * xselect.c (x_disown_buffer_selections): Remove; not used.
10106 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10107 (x_own_selection, Fx_disown_selection_internal): Rename locals
10108 to avoid shadowing.
10109 (x_handle_dnd_message): Remove local to avoid shadowing.
10110
10111 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10112 so that the caller can use some name other than gcpro1.
10113 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10114 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10115 (Fx_backspace_delete_keys_p):
10116 Use them to avoid shadowing, and rename vars to avoid shadowing.
10117 (x_decode_color, x_set_name, x_window): Now static.
10118 (Fx_create_frame): Add braces to silence GCC warning.
10119 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10120 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10121 Remove unused locals.
10122 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10123 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10124 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10125 macros.
10126
10127 * xterm.h (x_mouse_leave): New decl.
10128
10129 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10130 Remove unused functions.
10131 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10132 (x_calc_absolute_position): Now static.
10133 (XTread_socket): Don't define label "out" unless it's used.
10134 Don't declare local "event" unless it's used.
10135 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10136 unless they are used.
10137 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10138 (x_fatal_error_signal): Remove; not used.
10139 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10140 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10141 (x_error_catcher, x_connection_closed, x_error_handler):
10142 (x_error_quitter, xembed_send_message, x_iconify_frame):
10143 (my_log_handler): Rename locals to avoid shadowing.
10144 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10145 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10146
10147 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10148 Rename or move locals to avoid shadowing.
10149 (tty_defined_color, merge_face_heights): Now static.
10150 (free_realized_faces_for_fontset): Remove; not used.
10151 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10152 does not deduce is never used uninitialized.
10153 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10154 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10155
10156 * terminal.c (store_terminal_param): Now static.
10157
10158 * xmenu.c (menu_highlight_callback): Now static.
10159 (set_frame_menubar): Remove unused local.
10160 (xmenu_show): Rename parameter to avoid shadowing.
10161 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10162 since they might point to immutable storage.
10163 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10164 since it's unused otherwise.
10165
10166 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10167 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10168 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10169 avoids a gcc -Wuninitialized diagnostic.
10170 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10171 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10172 does not deduce are never used uninitialized.
10173
10174 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10175
10176 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10177 * window.c (window_loop, size_window):
10178 (run_window_configuration_change_hook, enlarge_window): Likewise.
10179
10180 * window.c (display_buffer): Now static.
10181 (size_window): Mark variables that gcc -Wuninitialized
10182 does not deduce are never used uninitialized.
10183 * window.h (check_all_windows): New decl, to forestall
10184 gcc -Wmissing-prototypes diagnostic.
10185 * dispextern.h (bidi_dump_cached_states): Likewise.
10186
10187 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10188 shadowing.
10189 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10190 Include <limits.h>.
10191 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10192 and to avoid gcc -Wuninitialized warning.
10193 (load_charset_map): Mark variables that gcc -Wuninitialized
10194 does not deduce are never used uninitialized.
10195 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10196
10197 * coding.c (coding_set_source, coding_set_destination):
10198 Use "else { /* comment */ }" rather than "else /* comment */;"
10199 for clarity, and to avoid gcc -Wempty-body warning.
10200 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10201 a block, when the outer 'i' will do.
10202 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10203 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10204 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10205 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10206 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10207 Rename locals to avoid shadowing.
10208 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10209 * coding.c (emacs_mule_char, encode_invocation_designation):
10210 Now static, since they're not used elsewhere.
10211 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10212 (decode_coding_object, encode_coding_object, detect_coding_system):
10213 (decode_coding_emacs_mule): Mark variables that gcc
10214 -Wuninitialized does not deduce are never used uninitialized.
10215 (detect_coding_iso_2022): Initialize a local variable that might
10216 be used uninitialized. Leave a FIXME because it's not clear that
10217 this initialization is needed. (Bug#8211)
10218 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10219 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10220 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10221 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10222 Remove unused macros.
10223
10224 * category.c (hash_get_category_set): Remove unused local var.
10225 (copy_category_table): Now static, since it's not used elsewhere.
10226 * character.c (string_count_byte8): Likewise.
10227
10228 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10229 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10230
10231 * chartab.c (copy_sub_char_table): Now static, since it's not used
10232 elsewhere.
10233 (sub_char_table_ref_and_range, char_table_ref_and_range):
10234 Rename locals to avoid shadowing.
10235 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10236
10237 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10238 (BIDI_BOB): Remove unused macro.
10239
10240 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10241 deduce are never used uninitialized.
10242 * term.c (encode_terminal_code): Likewise.
10243
10244 * term.c (encode_terminal_code): Now static. Remove unused local.
10245
10246 * tparam.h: New file.
10247 * term.c, tparam.h: Include it.
10248 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10249 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10250 Move these decls to tparam.h, and make them agree with what
10251 is actually in tparam.c. The previous trick of using incompatible
10252 decls in different modules does not conform to the C standard.
10253 All callers of tparam changed to use tparam's actual API.
10254 * tparam.c (tparam1, tparam, tgoto):
10255 Use const pointers where appropriate.
10256
10257 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10258 * cm.h (struct cm): Likewise.
10259 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10260 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10261 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10262 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10263 (turn_on_face, init_tty): Likewise.
10264 * termchar.h (struct tty_display_info): Likewise.
10265
10266 * term.c (term_mouse_position): Rename local to avoid shadowing.
10267
10268 * alloc.c (mark_ttys): Move decl from here ...
10269 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10270
10271 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10272
10273 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10274
10275 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10276
10277 * search.c (compile_pattern_1): Remove argument regp, unused since
10278 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10279 (compile_pattern): Don't pass it.
10280
10281 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10282
10283 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10284 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10285 for ! HAVE_GTK3.
10286 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10287
10288 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10289
10290 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10291 gdk_window_get_screen, gdk_window_get_geometry,
10292 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10293 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10294 (xg_get_pixbuf_from_pixmap): New function.
10295 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10296 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10297 Call xg_get_pixbuf_from_pixmap instead of
10298 gdk_pixbuf_get_from_drawable.
10299 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10300 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10301 (xg_check_special_colors): Use GtkStyleContext and its functions
10302 for HAVE_GTK3.
10303 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10304 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10305 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10306 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10307 Call gtk_widget_get_preferred_size.
10308 (xg_frame_resized): gdk_window_get_geometry only takes 5
10309 parameters.
10310 (xg_win_to_widget, xg_event_is_for_menubar):
10311 Call gdk_x11_window_lookup_for_display.
10312 (xg_set_widget_bg): New function.
10313 (delete_cb): New function.
10314 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10315 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10316 (xg_set_background_color): Call xg_set_widget_bg.
10317 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10318 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10319 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10320 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10321 if ! HAVE_GTK3.
10322 (update_frame_tool_bar): Call gtk_widget_hide.
10323 (xg_initialize): Use GDK_KEY_g.
10324
10325 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10326 if ! HAVE_GTK3
10327 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10328
10329 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10330 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10331 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10332
10333 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10334
10335 * w32xfns.c (select_palette): Check success of RealizePalette against
10336 GDI_ERROR, not zero.
10337
10338 See ChangeLog.11 for earlier changes.
10339
10340 ;; Local Variables:
10341 ;; coding: utf-8
10342 ;; End:
10343
10344 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10345
10346 This file is part of GNU Emacs.
10347
10348 GNU Emacs is free software: you can redistribute it and/or modify
10349 it under the terms of the GNU General Public License as published by
10350 the Free Software Foundation, either version 3 of the License, or
10351 (at your option) any later version.
10352
10353 GNU Emacs is distributed in the hope that it will be useful,
10354 but WITHOUT ANY WARRANTY; without even the implied warranty of
10355 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10356 GNU General Public License for more details.
10357
10358 You should have received a copy of the GNU General Public License
10359 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.