* window.c (Fdelete_window_internal): Invalidate the mouse highlight.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-12 Chong Yidong <cyd@gnu.org>
2
3 * window.c (Fdelete_window_internal): Invalidate the mouse
4 highlight (Bug#9904).
5
6 2012-02-12 Glenn Morris <rgm@gnu.org>
7
8 * xselect.c (Fx_own_selection_internal)
9 (Fx_get_selection_internal, Fx_disown_selection_internal)
10 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
11 * nsselect.m (Fx_own_selection_internal)
12 (Fx_disown_selection_internal, Fx_selection_exists_p)
13 (Fx_selection_owner_p, Fx_get_selection_internal):
14 Sync docs and argument specs with the xselect.c versions.
15
16 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
17
18 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
19
20 2012-02-11 Eli Zaretskii <eliz@gnu.org>
21
22 * w32select.c (Fx_selection_exists_p): Sync doc string and
23 argument list with xselect.c. (Bug#10783)
24
25 * w16select.c (Fx_selection_exists_p): Sync doc string and
26 argument list with xselect.c. (Bug#10783)
27
28 2012-02-10 Glenn Morris <rgm@gnu.org>
29
30 * fns.c (Fsecure_hash): Doc fix.
31
32 2012-02-09 Kenichi Handa <handa@m17n.org>
33
34 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
35
36 2012-02-07 Chong Yidong <cyd@gnu.org>
37
38 * buffer.c (Fbuffer_local_variables)
39 (buffer_lisp_local_variables): Handle unbound vars correctly;
40 don't let Qunbound leak into Lisp.
41
42 2012-02-07 Glenn Morris <rgm@gnu.org>
43
44 * image.c (Fimagemagick_types): Doc fix.
45
46 * image.c (imagemagick-render-type): Change it from a lisp object
47 to an integer. Move the doc here from the lisp manual.
48 Treat all values not equal to 0 the same.
49
50 2012-02-06 Chong Yidong <cyd@gnu.org>
51
52 * doc.c (store_function_docstring): Avoid applying docstring of
53 alias to base function (Bug#2603).
54
55 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
56
57 * .gdbinit (pp1, pv1): Remove redundant defines.
58 (pr): Use pp.
59
60 2012-02-04 Chong Yidong <cyd@gnu.org>
61
62 * nsterm.m: Declare a global (Bug#10694).
63
64 2012-02-04 Eli Zaretskii <eliz@gnu.org>
65
66 * w32.c (get_emacs_configuration_options): Include
67 --enable-checking, if specified, in the return value.
68
69 2012-02-04 Martin Rudalics <rudalics@gmx.at>
70
71 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
72 after rounding frame sizes. (Bug#9723)
73
74 2012-02-04 Eli Zaretskii <eliz@gnu.org>
75
76 * keyboard.c (adjust_point_for_property): Don't position point
77 before BEGV. (Bug#10696)
78
79 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
80
81 Handle overflow when computing char display width (Bug#9496).
82 * character.c (char_width): Return EMACS_INT, not int.
83 (char_width, c_string_width): Check for overflow when
84 computing the width; this is possible now that individual
85 characters can have unbounded width. Problem introduced
86 by merge from Emacs 23 on 2012-01-19.
87
88 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
89
90 * dbusbind.c (Fdbus_register_method): Mention the return value
91 :ignore in the docstring.
92
93 2012-02-02 Glenn Morris <rgm@gnu.org>
94
95 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
96
97 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
98 Unconditionally set to t. (Bug#10673)
99 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
100 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
101 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
102
103 2012-02-02 Kenichi Handa <handa@m17n.org>
104
105 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
106 0, do not call append_composite_glyph.
107
108 2012-02-02 Kenichi Handa <handa@m17n.org>
109
110 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
111 NULL (Bug#6988).
112 (x_produce_glyphs): If the component of a composition is a null
113 string, set it->pixel_width to 1 to avoid zero-width glyph.
114
115 2012-02-01 Eli Zaretskii <eliz@gnu.org>
116
117 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
118 first 2 arguments are identical. This makes inserting large
119 output from a subprocess an order of magnitude faster on
120 MS-Windows, where all sbrk'ed memory is always contiguous.
121
122 2012-01-31 Glenn Morris <rgm@gnu.org>
123
124 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
125 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
126 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
127
128 2012-01-29 Glenn Morris <rgm@gnu.org>
129
130 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
131
132 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
133
134 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
135
136 2012-01-28 Chong Yidong <cyd@gnu.org>
137
138 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
139
140 2012-01-26 Chong Yidong <cyd@gnu.org>
141
142 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
143
144 * search.c (Fsearch_forward, Fsearch_backward): Document negative
145 repeat counts (Bug#10507).
146
147 2012-01-26 Glenn Morris <rgm@gnu.org>
148
149 * lread.c (syms_of_lread): Doc fix.
150
151 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
152
153 * coding.c (encode_designation_at_bol): Change return value to
154 EMACS_INT.
155
156 2012-01-25 Chong Yidong <cyd@gnu.org>
157
158 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
159
160 2012-01-21 Chong Yidong <cyd@gnu.org>
161
162 * floatfns.c (Fcopysign): Make the second argument non-optional,
163 since nil is not allowed anyway.
164
165 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
166
167 * process.c (read_process_output): Use p instead of XPROCESS (proc).
168 (send_process): Likewise.
169
170 2012-01-19 Martin Rudalics <rudalics@gmx.at>
171
172 * window.c (save_window_save, Fcurrent_window_configuration)
173 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
174 doc-strings.
175
176 2012-01-19 Kenichi Handa <handa@m17n.org>
177
178 * character.c (char_width): New function.
179 (Fchar_width, c_string_width, lisp_string_width):
180 Use char_width (Bug#9496).
181
182 2012-01-16 Martin Rudalics <rudalics@gmx.at>
183
184 * window.c (Vwindow_persistent_parameters): New variable.
185 (Fset_window_configuration, save_window_save): Handle persistent
186 window parameters.
187
188 2012-01-14 Eli Zaretskii <eliz@gnu.org>
189
190 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
191 thrashing the stack of the thread. (Bug#9087)
192
193 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
194
195 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
196
197 2012-01-11 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (rows_from_pos_range): Handle the case where the
200 highlight ends on a newline. (Bug#10464)
201 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
202 he end column for display of highlight that ends on a newline
203 before a R2L line.
204
205 2012-01-11 Glenn Morris <rgm@gnu.org>
206
207 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
208 from load-path also when installation-directory is nil. (Bug#10208)
209
210 2012-01-10 Glenn Morris <rgm@gnu.org>
211
212 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
213
214 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
215 Update template values to be closer to their typical values these days.
216
217 2012-01-09 Eli Zaretskii <eliz@gnu.org>
218
219 * xdisp.c (rows_from_pos_range): Accept additional argument
220 DISP_STRING, and accept any glyph in a row whose object is that
221 string as eligible for mouse highlight. Fixes mouse highlight of
222 display strings from overlays. (Bug#10464)
223
224 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
225
226 emacs: fix an auto-save permissions race condition (Bug#10400)
227 * fileio.c (auto_saving_dir_umask): New static var.
228 (Fmake_directory_internal): Use it.
229 (do_auto_save_make_dir): Set it, instead of invoking chmod after
230 creating the directory. The old code temporarily assigns
231 too-generous permissions to the directory.
232 (do_auto_save_eh): Clear it.
233 (Fdo_auto_save): Catch all errors, not just file errors, so
234 that the var is always cleared.
235
236 2012-01-07 Eli Zaretskii <eliz@gnu.org>
237
238 * search.c (scan_buffer): Pass character positions to
239 know_region_cache, not byte positions. (Bug#6540)
240
241 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
242
243 * w32.c (sys_rename): Report EXDEV when rename of a directory
244 fails because the target is on another logical disk. (Bug#10284)
245
246 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
247
248 * xterm.c (x_embed_request_focus): New function.
249
250 * xterm.h: Add prototype.
251
252 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
253
254 2012-01-05 Glenn Morris <rgm@gnu.org>
255
256 * emacs.c (emacs_copyright): Update short copyright year to 2012.
257
258 2012-01-01 Eli Zaretskii <eliz@gnu.org>
259
260 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
261 Load gnutls_transport_set_lowat only if GnuTLS version is below
262 2.11.1.
263 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
264 GnuTLS versions below 2.11.1.
265
266 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
267
268 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
269 to the doc string advising against its use for altering the way
270 windows are scrolled.
271
272 2011-12-28 Kenichi Handa <handa@m17n.org>
273
274 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
275 coding-system ASCII compatible only when it does not produce BOM
276 on encoding (Bug#10383).
277
278 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
279
280 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
281 can scroll.
282 (create_and_show_popup_menu): Always use menu_position_func for
283 Gtk3 (Bug#10361).
284
285 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
286
287 * callint.c (Fcall_interactively): Don't truncate prompt string.
288
289 2011-12-23 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
292 property that ends at ZV, so that the bidi iteration could be
293 resumed from there (after widening). (Bug#10360)
294
295 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
296
297 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
298
299 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
300
301 * nsterm.m (x_free_frame_resources):
302 Release f->output_data.ns->miniimage.
303 (ns_index_color): Fix indentation. Do not retain
304 color_table->colors[i].
305
306 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
307 before returning.
308
309 * nsfns.m (x_set_background_color): Assign return value from
310 ns_index_color to face-background instead of NSColor*.
311 (ns_implicitly_set_icon_type): Fix indentation.
312 Change assignment in for loop to comparison.
313
314 * emacs.c (ns_pool): New variable.
315 (main): Assign ns_pool.
316 (Fkill_emacs): Call ns_release_autorelease_pool.
317
318 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
319 autorelease fdesc, release fdAttrs and tdict.
320 (ns_get_covering_families): Release charset.
321 (ns_findfonts): Release NSFontDescriptor created with new.
322 (ns_uni_to_glyphs): Fix indentation.
323 (setString): Release attrStr before assigning new value.
324
325 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
326
327 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
328 and NS_IMPL_COCOA.
329 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
330 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
331
332 2011-12-18 David Reitter <reitter@cmu.edu>
333
334 * nsterm.m (ns_term_init): Subscribe for notifications
335 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
336 to method trackingNotification in EmacsMenu.
337
338 * nsmenu.m (trackingMenu): New variable.
339 (trackingNotification): New method (from Aquamacs).
340 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
341 from Aquamacs (Bug#7030).
342
343 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
344
345 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
346 (symbol_to_nsstring): Fix indentation.
347 (ns_symbol_to_pb): New function.
348 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
349 (Fns_rotate_cut_buffers_internal): Removed.
350 (Fns_store_selection_internal): Renamed from
351 Fns_store_cut_buffer_internal.
352 (ns_get_foreign_selection, Fx_own_selection_internal)
353 (Fx_disown_selection_internal, Fx_selection_exists_p)
354 (Fns_get_selection_internal, Fns_store_selection_internal):
355 Use ns_symbol_to_pb and check if return value is nil.
356 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
357 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
358 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
359 renamed to Sns_store_selection_internal.
360 (ns_handle_selection_request): Move code to Fx_own_selection_internal
361 and remove this function.
362 (ns_handle_selection_clear): Remove, never used.
363 (Fx_own_selection_internal): Move code from ns_handle_selection_request
364 here.
365
366 2011-12-17 Ken Brown <kbrown@cornell.edu>
367
368 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
369 GID is unknown (Bug#10257).
370
371 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
372
373 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
374 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
375 which caused a build failure on GNU/Linux IA-64. This problem was
376 introduced by my 2011-10-07 patch.
377
378 2011-12-15 Juri Linkov <juri@jurta.org>
379
380 * image.c (imagemagick_error): New function. (Bug#10112)
381 (imagemagick_load_image): Comment out `MagickSetResolution' call.
382 Use `imagemagick_error' where ImageMagick functions return
383 `MagickFalse'.
384 (Fimagemagick_types): Add `Fnreverse' to return the list in the
385 proper order.
386
387 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
388
389 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
390 fill background (Bug#8992).
391
392 2011-12-13 Martin Rudalics <rudalics@gmx.at>
393
394 * window.c (Vwindow_combination_resize)
395 (Vwindow_combination_limit): Use t instead of non-nil in
396 doc-strings.
397 (Vrecenter_redisplay): Add first sentence of doc-string on
398 separate line.
399 (Frecenter): Fix doc-string typo.
400
401 2011-12-11 Kenichi Handa <handa@m17n.org>
402
403 * coding.c (Funencodable_char_position): Pay attention to the
404 buffer text relocation (Bug#9389).
405
406 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
407
408 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
409 gtk_init (Bug#10100).
410
411 2011-12-10 Eli Zaretskii <eliz@gnu.org>
412
413 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
414 IT->string is nil. (Bug#10263)
415
416 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
417
418 * nsterm.h (x_free_frame_resources): Declare.
419
420 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
421 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
422
423 * nsterm.h (ns_get_defaults_value): Declare.
424
425 * nsterm.m (ns_default): Call ns_get_defaults_value.
426
427 2011-12-09 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
430 (Bug#10170)
431
432 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
433
434 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
435 that where the value of an _OBJC_* symbol points to is in the .bss
436 section (Bug#10240).
437
438 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
439
440 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
441 after the loop to call ccl_driver at least once (Bug#8619).
442
443 2011-12-08 Kenichi Handa <handa@m17n.org>
444
445 * ftfont.c (get_adstyle_property): Fix previous change
446 (Bug#10233).
447
448 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
449
450 * w32.c (init_environment): If no_site_lisp, remove site-lisp
451 dirs from the default value of EMACSLOADPATH (bug#10208).
452
453 2011-12-07 Glenn Morris <rgm@gnu.org>
454
455 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
456 installation and source directories as well. (Bug#10208)
457
458 2011-12-06 Chong Yidong <cyd@gnu.org>
459
460 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
461
462 2011-12-06 Glenn Morris <rgm@gnu.org>
463
464 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
465 as an error, not just -1. (Bug#10217)
466
467 2011-12-05 Chong Yidong <cyd@gnu.org>
468
469 * keyboard.c (process_special_events): New function.
470 (swallow_events, Finput_pending_p): Use it (Bug#10195).
471
472 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
473
474 * coding.c (encode_designation_at_bol): Don't use uninitialized
475 local variable (Bug#9318).
476
477 2011-12-05 Kenichi Handa <handa@m17n.org>
478
479 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
480 return Qnil (Bug#8046, Bug#10193).
481
482 2011-12-05 Kenichi Handa <handa@m17n.org>
483
484 * coding.c (encode_designation_at_bol): New args charbuf_end and
485 dst. Return the number of produced bytes. Callers changed.
486 (coding_set_source): Return how many bytes coding->source was
487 relocated.
488 (coding_set_destination): Return how many bytes
489 coding->destination was relocated.
490 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
491 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
492
493 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
494
495 * coding.c (CODING_CHAR_CHARSET_P): New macro.
496 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
497 macro (Bug#9318).
498
499 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
500
501 The following changes are to fix Bug#9318.
502
503 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
504 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
505 (encode_coding_iso_2022, encode_coding_sjis)
506 (encode_coding_big5, encode_coding_charset): Use the above macros.
507
508 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
509
510 * lisp.h (process_quit_flag): Fix external declaration.
511
512 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
513
514 Don't macro-inline non-performance-critical code.
515 * eval.c (process_quit_flag): New function.
516 * lisp.h (QUIT): Use it.
517
518 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
519
520 * nsfns.m (get_geometry_from_preferences): New function.
521 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
522
523 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
524
525 * emacs.c (Qkill_emacs): Define.
526 (syms_of_emacs): Initialize it.
527 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
528 Qquit_flag to `kill-emacs' instead.
529 (quit_throw_to_read_char): Add parameter `from_signal'.
530 All callers changed. Call Fkill_emacs if requested and safe.
531 * lisp.h (QUIT): Call Fkill_emacs if requested.
532
533 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
534
535 * widget.c (update_wm_hints): Return if wmshell is null.
536 (widget_update_wm_size_hints): New function.
537
538 * widget.h (widget_update_wm_size_hints): Declare.
539
540 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
541 widget_update_wm_size_hints (Bug#10104).
542
543 2011-12-03 Eli Zaretskii <eliz@gnu.org>
544
545 * xdisp.c (handle_invisible_prop): If the invisible text ends just
546 before a newline, prepare the bidi iterator for consuming the
547 newline, and keep the current paragraph direction. (Bug#10183)
548 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
549
550 2011-12-02 Juri Linkov <juri@jurta.org>
551
552 * search.c (Fword_search_regexp): New Lisp function created from
553 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
554 (Fword_search_backward, Fword_search_forward)
555 (Fword_search_backward_lax, Fword_search_forward_lax):
556 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
557 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
558
559 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * fileio.c (Finsert_file_contents): Move after-change-function call
562 to before the "handled:" label, since all "goto handled" appear in
563 cases where the *-change-functions have already been properly called
564 (bug#10117).
565
566 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
567
568 * keyboard.c (interrupt_signal): Don't call kill-emacs when
569 waiting for input. (Bug#10169)
570
571 2011-11-30 Eli Zaretskii <eliz@gnu.org>
572
573 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
574 verifies glyph row's hash code--we have just reallocated the
575 glyphs, so their contents can be complete garbage. (Bug#10164)
576
577 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
578
579 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
580
581 2011-11-30 Eli Zaretskii <eliz@gnu.org>
582
583 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
584 attributes are tested _before_ calling verify_row_hash, to protect
585 against GCC re-ordering of the tests. (Bug#10164)
586
587 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
588
589 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
590
591 * xterm.c (handle_one_xevent): Only set async_visible and friends
592 if net_wm_state_hidden_seen is non-zero (Bug#10002)
593 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
594 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
595
596 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
597
598 Remove GCPRO-related macros that exist only to avoid shadowing locals.
599 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
600 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
601 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
602 All uses changed to use GCPRO1 etc.
603 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
604 Revert to old implementation (i.e., before 2011-03-11).
605
606 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
607
608 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
609 of scroll runs so as to avoid assigning disabled bogus rows and
610 unnecessary graphics copy operations.
611
612 2011-11-27 Eli Zaretskii <eliz@gnu.org>
613
614 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
615 (snprintf) [_MSC_VER]: Redirect to _snprintf.
616 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
617 (malloc, free, realloc, calloc): Redirect to e_* only when
618 compiling Emacs.
619
620 * lisp.h (GCTYPEBITS): Move before first use.
621 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
622 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
623 this macro definition.
624
625 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
626 _MSC_VER.
627
628 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
629
630 * gtkutil.c (xg_create_frame_widgets):
631 Call gtk_window_set_has_resize_grip (FALSE) if that function is
632 present with Gtk+ 2.0.
633
634 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
635
636 * fileio.c (Finsert_file_contents): Undo previous change; see
637 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
638
639 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
640
641 Rename locals to avoid shadowing.
642 * fileio.c (Finsert_file_contents):
643 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
644 * process.c (wait_reading_process_output):
645 Rename inner 'proc' to 'p' to avoid shadowing.
646 Indent for consistency with usual Emacs style.
647
648 2011-11-25 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (redisplay_window): If cursor row is not fully visible
651 after recentering, and scroll-conservatively is set to a large
652 number, scroll window by a few more lines to make the cursor fully
653 visible and out of scroll-margin. (Bug#10105)
654 (start_display): Don't move to the next line if the display should
655 start at a newline that is part of a display vector or an overlay
656 string. (Bug#10119)
657
658 2011-11-24 Juri Linkov <juri@jurta.org>
659
660 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
661 after the `MagickPingImage' call. (Bug#10112)
662
663 2011-11-23 Chong Yidong <cyd@gnu.org>
664
665 * window.c (Fcoordinates_in_window_p): Accept only live windows.
666
667 2011-11-23 Martin Rudalics <rudalics@gmx.at>
668
669 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
670 making another buffer current. (Bug#10114)
671
672 2011-11-23 Glenn Morris <rgm@gnu.org>
673
674 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
675
676 2011-11-23 Chong Yidong <cyd@gnu.org>
677
678 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
679 using it (Bug#5984).
680
681 2011-11-22 Eli Zaretskii <eliz@gnu.org>
682
683 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
684 and header-lines, as they don't have one computed for them.
685 (Bug#10098)
686
687 * .gdbinit (prow): Make displayed values more self-explaining.
688 Add row's hash code.
689
690 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
691
692 * process.c (wait_reading_process_output): Fix asynchrounous
693 GnuTLS socket handling on some versions of the GnuTLS library.
694 (wait_reading_process_output): Add comment and URL.
695
696 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
697
698 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
699
700 2011-11-21 Chong Yidong <cyd@gnu.org>
701
702 * window.c (Fnext_window, Fprevious_window): Doc fix.
703
704 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
705
706 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
707
708 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
709
710 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
711
712 2011-11-20 Martin Rudalics <rudalics@gmx.at>
713
714 * window.c (Fset_window_combination_limit): Rename argument
715 STATUS to LIMIT.
716 (Vwindow_combination_limit): Remove "status" from doc-string.
717
718 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
719
720 * m/ibms390.h: Remove.
721 * m/ibms390x.h: Don't include "ibms390.h".
722
723 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
724
725 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
726 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
727
728 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
729
730 * casetab.c (Fset_case_table):
731 * charset.c (Fcharset_after): Fix typos.
732
733 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
734
735 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
736 Otherwise, valgrind does not work on some platforms.
737 Problem reported by Andreas Schwab in
738 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
739 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
740 is set, removing the need for VIRT_ADDRESS_VARIES.
741 (PURE_P): Use a more-efficient implementation that needs just one
742 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
743 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
744 to 4 (xorl, subq, cmpq, setbe).
745 * alloc.c (pure): Always extern now, since that's the
746 VIRT_ADDR_VARIES behavior.
747 (PURE_POINTER_P): Use a single comparison, not two, for
748 consistency with the new puresize.h.
749 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
750 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
751 Remove VIRT_ADDR_VARIES no longer needed.
752
753 2011-11-19 Eli Zaretskii <eliz@gnu.org>
754
755 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
756 (erase_phys_cursor, update_window_cursor, show_mouse_face)
757 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
758 behave as if the cursor position were at the window margin.
759
760 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
761 and the cursor position is out of bounds, behave as if the cursor
762 position were at the window margin. (Bug#10075)
763
764 2011-11-18 Chong Yidong <cyd@gnu.org>
765
766 * window.c (Fwindow_combination_limit): Make first argument
767 non-optional, since it is meaningless for live windows like the
768 selected window.
769
770 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
771
772 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
773
774 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
775
776 * intervals.c: Fix grafting over the whole buffer (bug#10071).
777 (graft_intervals_into_buffer): Simplify.
778
779 2011-11-18 Eli Zaretskii <eliz@gnu.org>
780
781 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
782 hash values of the two rows.
783 (copy_row_except_pointers): Preserve the used[] arrays and the
784 hash values of the two rows. (Bug#10035)
785 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
786
787 * xdisp.c (row_hash): New function, body extracted from
788 compute_line_metrics.
789 (compute_line_metrics): Call row_hash, instead of computing the
790 hash code inline.
791
792 * dispnew.c (verify_row_hash): Call row_hash for computing the
793 hash code of a row, instead of duplicating code from xdisp.c.
794
795 * dispextern.h (row_hash): Add prototype.
796
797 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
798
799 * frame.c (delete_frame): Don't delete the terminal when the last
800 X frame is closed if emacs is built with GTK toolkit.
801
802 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
803
804 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
805
806 2011-11-17 Martin Rudalics <rudalics@gmx.at>
807
808 * window.c (Vwindow_splits): Rename to
809 Vwindow_combination_resize. Suggested by Juri Linkov.
810 (Fsplit_window_internal): Use Vwindow_combination_resize instead
811 of Vwindow_splits.
812
813 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
814
815 * nsfns.m (Fns_font_name):
816 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
817
818 2011-11-16 Martin Rudalics <rudalics@gmx.at>
819
820 * window.h (window): Rename slot "nest" to "combination_limit".
821 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
822 (Fset_window_nest): Rename to Fset_window_combination_limit.
823 (Vwindow_nest): Rename to Vwindow_combination_limit.
824 (recombine_windows, make_parent_window, make_window)
825 (Fsplit_window_internal, saved_window)
826 (Fset_window_configuration, save_window_save): Rename all
827 occurrences of window_nest to window_combination_limit.
828
829 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
830
831 * image.c (imagemagick_load_image): Fix typo.
832
833 2011-11-14 Eli Zaretskii <eliz@gnu.org>
834
835 * xdisp.c (display_line): Move the call to
836 highlight_trailing_whitespace before the call to
837 compute_line_metrics, since the latter needs to see the final
838 faces of all the glyphs to compute ROW's hash value.
839 Fixes assertion violations in row_equal_p. (Bug#10035)
840
841 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
842
843 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
844 just return (bug#10044).
845
846 2011-11-12 Eli Zaretskii <eliz@gnu.org>
847
848 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
849 with user-defined heap size. Bump the default size of the temacs
850 heap to 27MB, to avoid memory warning when running temacs.
851 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
852
853 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
854 current_matrix and desired_matrix. (Bug#9990)
855 (verify_row_hash) [XASSERTS]: New function.
856 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
857 that the hash value of glyph rows is correct.
858
859 2011-11-12 Martin Rudalics <rudalics@gmx.at>
860
861 * window.h (window): Remove splits slot.
862 * window.c (Fwindow_splits, Fset_window_splits): Remove.
863 (Fdelete_other_windows_internal, make_parent_window)
864 (make_window, Fsplit_window_internal, Fdelete_window_internal)
865 (Fset_window_configuration, save_window_save): Don't deal with
866 split status of windows.
867 (saved_window): Remove splits slot.
868 (Vwindow_splits): Rewrite doc-string.
869
870 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
871
872 * xfns.c (unwind_create_frame):
873 * nsfns.m (unwind_create_frame):
874 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
875 Vframe_list (Bug#9999).
876
877 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
878
879 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
880
881 2011-11-11 Kenichi Handa <handa@m17n.org>
882
883 * callproc.c (Fcall_process): Set the member dst_multibyte of
884 process_coding.
885
886 2011-11-11 Johan Bockgård <bojohan@gnu.org>
887
888 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
889 avoid a crash (bug#9496).
890
891 2011-11-09 Chong Yidong <cyd@gnu.org>
892
893 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
894 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
895
896 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
897
898 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
899
900 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
901
902 Avoid some portability problems by eschewing 'extern inline' functions.
903 The trivial performance wins aren't worth the portability hassles; see
904 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
905 et seq.
906 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
907 (window_box_width, window_box_left, window_box_left_offset)
908 (window_box_right, window_box_right_offset): Undo previous change,
909 by removing the "extern"s.
910 * intervals.c (adjust_intervals_for_insertion)
911 (adjust_intervals_for_deletion): Undo previous change,
912 making these static again.
913 (offset_intervals, temp_set_point_both, temp_set_point)
914 (copy_intervals_to_string): No longer inline.
915 * xdisp.c (window_text_bottom_y, window_box_width)
916 (window_box_height, window_box_left_offset)
917 (window_box_right_offset, window_box_left, window_box_right)
918 (window_box): No longer inline.
919
920 2011-11-08 Chong Yidong <cyd@gnu.org>
921
922 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
923 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
924 Signal an error if not a live window.
925 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
926 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
927
928 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
929
930 * lisp.h (syms_of_abbrev): Remove declaration.
931 Reported by CHENG Gao <chenggao@royau.me>.
932
933 2011-11-07 Eli Zaretskii <eliz@gnu.org>
934
935 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
936 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
937 of temacs in GUI mode.
938
939 2011-11-07 Martin Rudalics <rudalics@gmx.at>
940
941 * window.h: Declare delete_all_child_windows instead of
942 delete_all_subwindows.
943 * window.c (Fwindow_nest, Fset_window_nest)
944 (Fset_window_new_total, Fset_window_new_normal)
945 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
946 (delete_all_subwindows): Rename to delete_all_child_windows.
947 (Fdelete_other_windows_internal, Fset_window_configuration):
948 Call delete_all_child_windows instead of delete_all_subwindows.
949 * frame.c (delete_frame): Call delete_all_child_windows instead
950 of delete_all_subwindows.
951
952 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
953
954 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
955 This is also needed for porting to any host where GC_MARK_STACK is
956 not GC_MAKE_GCPROS_NOOPS.
957 (which_symbols): Use it.
958
959 2011-11-07 Kenichi Handa <handa@m17n.org>
960
961 * coding.c (coding_set_destination): Check coding->src_pos only
962 when coding->src_object is a buffer (bug#9910).
963
964 * process.c (send_process): Set the member src_multibyte of coding
965 to 0 (bug#9911) when sending a unibyte text.
966
967 * callproc.c (Fcall_process): Set the member src_multibyte of
968 process_coding to 0 (bug#9912).
969
970 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
971
972 * xmenu.c (cleanup_widget_value_tree): New function.
973 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
974 calling free_menubar_widget_value_tree directly (Bug#9830).
975
976 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
977
978 Fix some portability problems with 'inline'.
979 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
980 (window_box_width, window_box_left, window_box_left_offset)
981 (window_box_right, window_box_right_offset): Declare extern.
982 Otherwise, these inline functions do not conform to C99 and
983 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
984 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
985 * intervals.c (adjust_intervals_for_insertion)
986 (adjust_intervals_for_deletion): Now extern, because otherwise the
987 extern inline functions 'offset_intervals' couldn't refer to it.
988 (static_offset_intervals): Remove.
989 (offset_intervals): Rewrite using the old contents of
990 static_offset_intervals. The old version didn't conform to C99
991 because an extern inline function contained a reference to an
992 identifier with static linkage.
993
994 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
995
996 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
997 GC.
998
999 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1002 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1003 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1004 return Qleft_to_right.
1005
1006 2011-11-06 Chong Yidong <cyd@gnu.org>
1007
1008 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1009 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1010 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1011 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1012 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1013 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1014 (Fwindow_vscroll): Doc fix.
1015 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1016 argument, since it makes no sense to pass a live window and for
1017 consistency with window-child.
1018
1019 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1020
1021 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1022 support MSVC.
1023
1024 2011-11-05 Jason Rumney <jasonr@gnu.org>
1025
1026 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1027 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1028 fonts (Bug#6029).
1029 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1030 bitwise arithmetic preventing use of unicode-sip and non-truetype
1031 opentype fonts.
1032
1033 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1034
1035 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1036 "emacs"-only part.
1037
1038 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1039 initialization code to keep similarity to xfns.c after changes
1040 from 2011-11-05.
1041
1042 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1045 (unwind_create_frame): New function (Bug#9943).
1046 (Fx_create_frame): Restructure code to be more similar to the one in
1047 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1048 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1049 Move terminal->reference_count++ just before making the frame official
1050 (Bug#9943).
1051
1052 * nsterm.m (x_free_frame_resources): New function.
1053 (x_destroy_window): Move code to x_free_frame_resources.
1054
1055 * xfns.c (unwind_create_frame): Fix comment.
1056 (Fx_create_frame, x_create_tip_frame):
1057 Move terminal->reference_count++ just before making the frame
1058 official. Move initialization of image_cache_refcount and
1059 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1060
1061 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1062
1063 Support MSVC build with newer versions of Visual Studio.
1064 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1065 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1066 nt/gmake.defs.
1067
1068 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1069 which are not supported by MSVC.
1070 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1071 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1072 bitfields.
1073 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1074 types in bitfields.
1075 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1076
1077 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1078
1079 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1080
1081 Support MSVC build with newer versions of Visual Studio.
1082 * w32.c: Don't include w32api.h for MSVC.
1083 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1084
1085 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1086 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1087 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1088 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1089 e_* cousins.
1090 (alloca) [_MSC_VER]: Define to _alloca.
1091
1092 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1093
1094 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1095
1096 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (note_mouse_highlight): If either of
1099 previous/next-single-property-change returns nil, treat that as
1100 the beginning or the end of the buffer. (Bug#9955)
1101
1102 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1103
1104 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1105 label is not null (Bug#9951).
1106 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1107 may be NULL.
1108
1109 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1110
1111 * window.c (Fwindow_body_size): Mention in the doc string that the
1112 return value is in frame's canonical units. (Bug#9949)
1113
1114 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1117
1118 * w32fns.c (unwind_create_frame): If needed, free the glyph
1119 matrices of the partially constructed frame. (Bug#9943)
1120 * xfns.c (unwind_create_frame): Likewise.
1121
1122 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1125 Don't stop backward scan on the continuation glyph, even though
1126 its CHARPOS is positive.
1127 (mouse_face_from_buffer_pos, note_mouse_highlight):
1128 Rename cover_string to disp_string.
1129
1130 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1131
1132 * window.c (temp_output_buffer_show): Don't use
1133 Vtemp_buffer_show_specifiers.
1134 (Vtemp_buffer_show_specifiers): Remove unused variable.
1135
1136 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1137
1138 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1139 past the beginning of the current glyph matrix.
1140
1141 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1142
1143 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1144 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1145 HAVE_GTK3 (Bug#9869).
1146
1147 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1148 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1149
1150 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1151
1152 * xterm.c: Declare x_handle_net_wm_state to return int.
1153 (handle_one_xevent): Check if we are iconified but don't have
1154 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1155 (get_current_wm_state): Return non-zero if not hidden,
1156 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1157 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1158 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1159 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1160
1161 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1164 so that this new function doesn't get optimized away by a
1165 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1166
1167 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1168
1169 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1170
1171 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1172
1173 Fix the `xbytecode' command.
1174 * .gdbinit (xprintbytestr): New command.
1175 (xwhichsymbols): Rename from `which'; all callers changed.
1176 (xbytecode): Print the byte-code string as well.
1177
1178 2011-10-29 Kim Storm <storm@cua.dk>
1179
1180 * alloc.c (which_symbols): New function.
1181
1182 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1185 line. (Bug#9903)
1186
1187 2011-10-29 Glenn Morris <rgm@gnu.org>
1188
1189 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1190 Not clear what it was for, and it causes various bugs. (Bug#9839)
1191
1192 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1193
1194 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1195 possible random value that matches one of those tested as
1196 condition to clear the mouse face.
1197
1198 2011-10-28 Chong Yidong <cyd@gnu.org>
1199
1200 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1201
1202 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1203
1204 * window.c (make_window): Initialize phys_cursor_on_p.
1205
1206 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1207
1208 * lisp.h (struct Lisp_Symbol): Update comments.
1209
1210 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1213
1214 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1215
1216 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1217 <oslsachem@gmail.com> for helping to debug this.
1218
1219 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1220 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1221 (g_b_init_get_glyph_outline_w): New static variables.
1222 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1223 (GetGlyphOutlineW_Proc): New typedefs.
1224 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1225 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1226 New functions.
1227 (w32font_open_internal, compute_metrics):
1228 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1229 instead of calling the "wide" APIs directly.
1230
1231 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1232
1233 * w32.h (syms_of_w32font): Add prototype.
1234
1235 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1238 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1239 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1240 (Fmove_to_window_line): Doc fix.
1241
1242 2011-10-27 Chong Yidong <cyd@gnu.org>
1243
1244 * process.c (make_process): Set gnutls_state to NULL.
1245
1246 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1247 non-NULL, regardless of GNUTLS_INITSTAGE.
1248 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1249 an error. Set process slots as soon as we allocate them.
1250
1251 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1252
1253 2011-10-27 Chong Yidong <cyd@gnu.org>
1254
1255 * gnutls.c (emacs_gnutls_deinit): New function.
1256 Deallocate credentials structures as well as calling gnutls_deinit.
1257 (Fgnutls_deinit, Fgnutls_boot): Use it.
1258
1259 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1260 (deactivate_process): Call emacs_gnutls_deinit.
1261
1262 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1263
1264 * image.c (x_create_x_image_and_pixmap):
1265 * w32.c (sys_rename, w32_delayed_load):
1266 * w32font.c (fill_in_logfont):
1267 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1268
1269 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1270
1271 * w32fns.c (w32_default_color_map): New function,
1272 extracted from Fw32_default_color_map.
1273 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1274
1275 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1276
1277 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1278
1279 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1280
1281 * keyboard.c (test_undefined): New function (bug#9751).
1282 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1283
1284 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1285
1286 * sysdep.c (init_sys_modes): Fix the check for the controlling
1287 terminal (Bug#6649).
1288
1289 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1290
1291 * dispextern.h (struct bidi_it): New member next_en_type.
1292
1293 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1294 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1295 current character, check also for next_en_type being WEAK_EN.
1296 (bidi_resolve_weak): Don't enter the expensive loop if the current
1297 position is before next_en_pos. Record the bidi type of the first
1298 non-ET, non-BN character we find, in addition to its position.
1299 (bidi_level_of_next_char): Invalidate next_en_type when
1300 next_en_pos is over-stepped.
1301
1302 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1305 * editfns.c: Rewrite current-time-zone so that it invokes
1306 the equivalent of (format-time-string "%Z") to get the time zone name.
1307 This fixes a bug when the time zone name contains characters that
1308 need converting from the system time locale to Emacs internal format.
1309 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1310 that patch fixed format-time-string to do the conversion, but
1311 I forgot to fix current-time-zone.
1312 (format_time_string): New function, containing most of
1313 what Fformat_time_string used to contain.
1314 (Fformat_time_string): Rewrite in terms of format_time_string.
1315 This doesn't change this function's behavior.
1316 (current-time-zone): Rewrite to use format_time_string.
1317 This fixes the bug reported by Michael Schierl in
1318 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1319 Jason Rumney's 2007-06-07 change worked around this bug, but
1320 didn't fix it.
1321 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1322
1323 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1324
1325 * xdisp.c (start_display): If the character at POS is displayed
1326 via a display vector, reset IT->current.dpvec_index to zero.
1327 (try_window_reusing_current_matrix): If a line ends in a display
1328 vector or the next line starts in a display vector, continue
1329 redrawing the window even though the character position of
1330 start_row was reached.
1331 (Bug#9771, part 2)
1332
1333 2011-10-18 Chong Yidong <cyd@gnu.org>
1334
1335 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1336 with nobreak-char-display too.
1337
1338 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1339
1340 Fix part 3 of bug#9771.
1341 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1342 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1343 non-neutral characters if the current character is a paragraph
1344 separator (a.k.a. Newline). This avoids running the same
1345 expensive loop twice, once when we consume the preceding newline
1346 and the other time when the line actually needs to be displayed.
1347 Avoid the loop when we see neutrals on the base embedding level
1348 following a character whose directionality is the same as the
1349 paragraph's. This avoids running the expensive loop when a line
1350 ends in a long sequence of neutrals, like control characters.
1351 Add assertion against STRONG_AL type. Slightly rearrange code
1352 that determines the type of a neutral given the first non-neutral
1353 that follows it.
1354 (bidi_level_of_next_char): Set next_en_pos to zero when
1355 invalidating its info.
1356
1357 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (push_display_prop): Determine whether to record string
1360 or buffer position by IT->string, not by IT->method. Allow
1361 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1362 (move_it_vertically_backward): Don't look for character position
1363 immediately after the newline when in a continuation line.
1364 (Bug#9771, part 1)
1365
1366 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1367
1368 * window.c (coordinates_in_window): Rewrite and delabelize
1369 vertical border check. (Bug#5357) (Bug#9618)
1370
1371 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1372
1373 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1374 errors in XSetWindowBorder (bug#9310).
1375
1376 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1379 avoid crash when xmalloc overrun checking is enabled.
1380
1381 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1382
1383 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1384 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1385 cursor motion with <left> and <right> arrow keys.
1386
1387 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1388 some callers set that themselves.
1389
1390 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1393 display string and the previous row comes from the same string and
1394 is empty. (Bug#9739) (Bug#9738)
1395
1396 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1397
1398 * doc.c (get_doc_string): Encode file name (bug#9735).
1399
1400 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1401
1402 * bidi.c (bidi_level_of_next_char):
1403 * xdisp.c (get_visually_first_element): Remove old incorrect
1404 comments regarding the Unicode Line Separator character.
1405
1406 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1407
1408 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1409
1410 * alloc.c (Fgc_status): Do not access beyond zombies array
1411 boundary if nzombies > MAX_ZOMBIES.
1412 * alloc.c (dump_zombies): Add missing format specifier.
1413
1414 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1417 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1418
1419 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1420 Some packages use them to denote characters with modifiers.
1421
1422 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1423
1424 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1425 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1426 matching a pp-number. Rename parameter var to var1.
1427
1428 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1429
1430 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1431
1432 2011-10-08 Glenn Morris <rgm@gnu.org>
1433
1434 * callint.c (Fcall_interactively): Give a more explicit error for the
1435 'c' case with a non-character input. (Bug#8479)
1436
1437 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1438
1439 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1440 lines.
1441 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1442 lines that are hscrolled on the left.
1443
1444 * dispnew.c (buffer_posn_from_coords): Account for a possible
1445 presence of header-line. (Bug#4426)
1446
1447 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1448
1449 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1450 Don't advertise functionality which we discourage or doesn't work.
1451
1452 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1455 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1456 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1457 this makes Emacs dump core during garbage collection on rare
1458 occasions. sizeof is obviously inferior to offsetof here, so
1459 stick with offsetof.
1460 (GC_POINTER_ALIGNMENT): New macro.
1461 (mark_memory): Omit 3rd (offset) arg; caller changed.
1462 Don't assume EMACS_INT alignment is the same as pointer alignment.
1463
1464 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1465
1466 * keyboard.c (read_key_sequence_remapped): New var.
1467 (read_key_sequence): Compute remapping in the right buffer.
1468 (command_loop_1): Use read_key_sequence's remapping directly.
1469
1470 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1471
1472 * dired.c (file_name_completion): Don't expand file name.
1473 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1474 before checking file name handler.
1475
1476 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1477 they've been requested explicitly (bug#9591).
1478
1479 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * keymap.c (Fsingle_key_description): Use make_specified_string
1482 instead of build_string to build string from push_key_description.
1483 (Bug#5193)
1484
1485 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1488 This fixes a Y2038 bug on 64-bit hosts.
1489 * buffer.c (reset_buffer):
1490 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1491 (Fclear_buffer_auto_save_failure):
1492 Use 0, not -1, to represent an unset failure time, since time_t
1493 might not be signed.
1494
1495 Remove dependency on glibc malloc internals.
1496 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1497 Move back here from lisp.h, but with their new implementations.
1498 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1499 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1500 * charset.c (charset_table_init): New static var.
1501 (syms_of_charset): Use it instead of xmalloc. This removes a
1502 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1503 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1504 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1505 Move back to alloc.c.
1506 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1507 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1508
1509 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1510
1511 * nsterm.m (windowDidResize): Call x_set_window_size only when
1512 ns_in_resize is true. Otherwise set pixelwidth/height and
1513 call change_frame_size (Bug#9628).
1514
1515 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 Port --enable-checking=all to Fedora 14 x86-64.
1518 * charset.c (syms_of_charset): Also account for glibc malloc's
1519 internal overhead when calculating the initial malloc maximum.
1520
1521 Port --enable-checking=all to Fedora 14 x86.
1522 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1523 Move to lisp.h.
1524 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1525 (overrun_check_realloc, overrun_check_free):
1526 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1527 That way, xmalloc returns a properly-aligned pointer even if
1528 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1529 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1530 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1531 into account when calculating the initial malloc maximum.
1532 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1533 Move here from alloc.c, so that charset.c can use it too.
1534 Properly align; the old code wasn't right for common 32-bit hosts
1535 when configured with --enable-checking=all.
1536 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1537 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1538
1539 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1540
1541 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1542 use EDOM.
1543
1544 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1545
1546 * xdisp.c (compute_display_string_end): If there's no display
1547 string at CHARPOS, return -1.
1548
1549 * bidi.c (bidi_fetch_char): When compute_display_string_end
1550 returns a negative value, treat the character as a normal
1551 character not covered by a display string. (Bug#9624)
1552
1553 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * lread.c (Fread_from_string): Fix typo in docstring.
1556
1557 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1560 newline, reseat the iterator instead of bidi-iterating there one
1561 character at a time. (Bug#9610)
1562 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1563 TO_CHARPOS if the bidi iterator is at base embedding level.
1564
1565 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1566
1567 * lread.c (readevalloop): Use correct code for NBSP.
1568 (read1): Likewise. (Bug#9608)
1569
1570 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1571
1572 * dbusbind.c (Fdbus_register_signal): When service is not
1573 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1574
1575 2011-09-25 Glenn Morris <rgm@gnu.org>
1576
1577 * buffer.c (truncate-lines): Doc fix.
1578
1579 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1580
1581 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1582 (Fset_window_next_buffers): Doc fix.
1583
1584 2011-09-24 Glenn Morris <rgm@gnu.org>
1585
1586 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1587
1588 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 Fix minor problems found by static checking.
1591 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1592 * indent.c (Fvertical_motion): Fix == vs = typo.
1593
1594 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1595
1596 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1597 Default value is now t. Doc fix.
1598
1599 * indent.c (Fvertical_motion): Compute and apply the overshoot
1600 logic when moving up, not only when moving down. Fix the
1601 confusing name and values of the it_overshoot_expected variable;
1602 logic changes accordingly. (Bug#9254) (Bug#9549)
1603
1604 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1605 CHARPOS is covered by a display string which includes newlines.
1606 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1607 is covered by a display string with embedded newlines.
1608
1609 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1610
1611 * dbusbind.c (Fdbus_register_signal): Add match rule to
1612 Vdbus_registered_objects_table. (Bug#9581)
1613 (Fdbus_register_method, Vdbus_registered_objects_table):
1614 Fix docstring.
1615
1616 2011-09-24 Jim Meyering <meyering@redhat.com>
1617
1618 do not ignore write error for any output size
1619 The previous change was incomplete.
1620 While it makes emacs --batch detect the vast majority of stdout
1621 write failures, errors were still ignored whenever the output size is
1622 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1623 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1624 && echo FAIL: ignored write error
1625 FAIL: ignored write error
1626 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1627 && echo FAIL: ignored write error
1628 FAIL: ignored write error
1629 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1630
1631 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1632
1633 * emacs.c (Fkill_emacs): In noninteractive mode exit
1634 non-successfully if a write error occurred on stdout. (Bug#9574)
1635
1636 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1637
1638 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1639 the xassert test.
1640
1641 * dispextern.h (struct it): Update the comment documenting what
1642 can it->OBJECT be.
1643
1644 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1645
1646 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1647 a display string, extend search for cursor position to end of row.
1648 (find_row_edges): If the row ends in a newline from a display
1649 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1650 Handle the case of a display string with multiple newlines.
1651 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1652 non-empty line. Fixes confusing cursor motion with arrow keys at
1653 the beginning of a line that starts with whitespace.
1654
1655 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1656
1657 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1658 (bug#9493).
1659
1660 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1661
1662 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1663 boolean (Bug#9154).
1664
1665 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1666
1667 * xdisp.c (display_line): Record maximum and minimum buffer
1668 positions even if no glyphs were produced (e.g., by a zero-width
1669 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1670 buffer positions that will be removed from the glyph row because
1671 they don't fit.
1672 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1673 column is beyond frame width: don't subtract 1 "pixel" when
1674 computing width of the stretch.
1675 (reseat_at_next_visible_line_start): Undo the change made on
1676 2011-09-17 that saved paragraph information and restored it after
1677 the call to `reseat'. (Bug#9545)
1678
1679 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1680
1681 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1682 and turn window cursor on if cleared (Bug#9415).
1683
1684 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1685
1686 * search.c (boyer_moore): Take unibyte characters from pattern
1687 literally. (Bug#9458)
1688
1689 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1690
1691 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1692
1693 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 Fix minor problem found by static checking.
1696 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1697 initialized, to pacify gcc -Wuninitialized.
1698
1699 * fileio.c: Report proper errno when syscall falls.
1700 (Finsert_file_contents): Save and restore errno,
1701 so that report_file_error outputs the correct diagnostic.
1702 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1703
1704 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1705
1706 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1707
1708 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1711 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1712
1713 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1714
1715 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1716 about the current paragraph and restore it after the call to reseat.
1717
1718 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1719 (bidi_find_paragraph_start): Search back for paragraph beginning
1720 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1721 (bidi_move_to_visually_next): Only trigger paragraph-related
1722 computations when the last character is a newline or at EOB, not
1723 just any NEUTRAL_B. (Bug#9470)
1724
1725 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1726 truncated lines if point is covered by a display string. (Bug#9524)
1727
1728 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1731 (cons_to_x_long): New function.
1732 (lisp_data_to_selection_data): Use it. Correct the test for
1733 short-versus-long data; it was negated. Break out of vector
1734 loop, for efficiency, when a long datum is discovered.
1735
1736 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1739
1740 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1741
1742 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1743 GCC PR/17406) by declaring this function with external scope.
1744
1745 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1748 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1749
1750 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1751
1752 * editfns.c (Fformat): Correctly handle text properties on "%%".
1753
1754 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xterm.c (x_draw_composite_glyph_string_foreground):
1757 * w32term.c (x_draw_composite_glyph_string_foreground):
1758 * term.c (encode_terminal_code):
1759 * composite.c (composition_update_it, get_composition_id):
1760 * xdisp.c (get_next_display_element)
1761 (fill_composite_glyph_string): Add comments about special meaning
1762 of TAB characters in a composition.
1763
1764 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1767 This occurs when processing a multibyte format.
1768 Problem reported by Wolfgang Jenker.
1769
1770 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1771
1772 * xdisp.c (try_cursor_movement): Only check for exact match if
1773 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1774
1775 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 Remove unused external symbols.
1778 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1779 * xdisp.c (calc_pixel_width_or_height): Now static.
1780 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1781 * indent.c (check_display_width):
1782 * w32term.c: Fix comment to match code.
1783 * xterm.c, xterm.h (x_catching_errors): Remove.
1784
1785 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * xselect.c: Use signed conversions more consistently (Bug#9498).
1788 (selection_data_to_lisp_data): Assume incoming selection data are
1789 signed integers, not unsigned. This is to be consistent with
1790 outgoing selection data, which was modified to use signed integers
1791 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1792 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1793 expects long, not unsigned long.
1794
1795 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1796
1797 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1798 computation of loop end. Reported by Johan Bockgård
1799 <bojohan@gnu.org>.
1800
1801 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1802
1803 * frame.c (Fother_visible_frames_p): Function deleted.
1804
1805 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1806
1807 * indent.c (compute_motion): Process display vector front to back
1808 rather than the other way around. (Bug#2496)
1809
1810 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1811
1812 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1813
1814 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1815
1816 * minibuf.c (Fread_from_minibuffer): Doc fix.
1817
1818 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1821 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1822
1823 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1824
1825 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1826 value for non-existent files.
1827
1828 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1829
1830 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1831 set its "size" to -1. This will set the modtime_size field of
1832 the corresponding buffer to -1, which is what
1833 verify-visited-file-modtime expects for files that do not exist.
1834 (Bug#9139)
1835
1836 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1839 here ...
1840 * lisp.h: ... from here. push_key_description is no longer
1841 defined in keyboard.c, so its declaration should not be in
1842 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1843 logically belongs with push_key_description.
1844
1845 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * buffer.h: Include <sys/types.h> instead of <time.h>.
1848 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1849 Problem reported by Herbert J. Skuhra.
1850
1851 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1852
1853 * xml.c (parse_region): Make the parsing work for
1854 non-comment-starting XML files again (bug#9144).
1855
1856 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1857
1858 * image.c (gif_load): Fix calculation of bottom and right corner.
1859 (Bug#9468)
1860
1861 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1864 redisplay in small windows.
1865
1866 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1867
1868 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1869
1870 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1871
1872 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1873 Operate on live windows only.
1874
1875 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1878
1879 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1880
1881 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1882 only under bidi iteration.
1883
1884 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1885
1886 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1887
1888 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1891 Without this fix, the command to link temacs failed due to an
1892 undefined symbol __builtin_isnan. This is because
1893 /usr/include/iso/math_c99.h #defines isnan(x) to
1894 __builtin_isnan(x), but the bundled gcc, which identifies itself
1895 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1896 a __builtin_isnan.
1897 * floatfns.c (isnan): #undef, and then #define to a clone of
1898 what's in data.c.
1899 (Fisnan): Always define, since it's always available now.
1900 (syms_of_floatfns): Always define isnan at the Lisp level.
1901
1902 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1905
1906 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1909 The previous code assumed that file offsets (off_t values) fit in
1910 EMACS_INT variables, which is not true on typical 32-bit hosts.
1911 The code messed up by falsely reporting buffer overflow in cases
1912 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1913 when "big" contains more than 2**29 bytes, even though this
1914 inserts just one byte and does not overflow the buffer.
1915 (Finsert_file_contents): Store file offsets as off_t
1916 values, not as EMACS_INT values. Check for overflow when
1917 converting between EMACS_INT and off_t. When checking for
1918 buffer overflow or for overlap, take the offsets into account.
1919 Don't use EMACS_INT for small values where int suffices.
1920 When checking for overlap, fix a typo: ZV was used where
1921 ZV_BYTE was intended.
1922 (Fwrite_region): Don't assume off_t fits into 'long'.
1923 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1924
1925 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1926
1927 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1928
1929 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 sprintf-related integer and memory overflow issues (Bug#9412).
1932
1933 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1934 (esprintf, exprintf, evxprintf): New functions.
1935 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1936 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1937 (modify_event_symbol): Do not assume that the length of
1938 name_alist_or_stem is safe to alloca and fits in int.
1939 (Fexecute_extended_command): Likewise for function name and binding.
1940 (Frecursion_depth): Wrap around reliably on integer overflow.
1941 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1942 since some callers pass EMACS_INT values.
1943 (Fsingle_key_description): Don't crash if symbol name contains more
1944 than MAX_ALLOCA bytes.
1945 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1946 (get_minibuffer): Arg is now EMACS_INT, not int.
1947 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1948 (esprintf, exprintf, evxprintf): New decls.
1949 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1950
1951 * dbusbind.c (signature_cat): New function.
1952 (xd_signature, Fdbus_register_signal):
1953 Do not overrun buffer; instead, report string overflow.
1954
1955 * dispnew.c (add_window_display_history): Don't overrun buffer.
1956 Truncate instead; this is OK since it's just a log.
1957
1958 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1959 even if the time zone offset is outlandishly large.
1960 Don't mishandle offset == INT_MIN.
1961
1962 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1963 when creating daemon; the previous buffer-overflow check was incorrect.
1964
1965 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1966 which has the guts of the old verror function.
1967
1968 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1969 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1970
1971 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1972 (font_unparse_xlfd): Don't blindly alloca long strings.
1973 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1974 fits in int, when using sprintf. Use single snprintf to count
1975 length of string rather than counting it via multiple sprintfs;
1976 that's simpler and more reliable.
1977 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1978 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1979 sprintf, in case result does not fit in int.
1980
1981 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1982 (fontset_from_font): Print it.
1983
1984 * frame.c (tty_frame_count): Now printmax_t, not int.
1985 (make_terminal_frame, set_term_frame_name): Print it.
1986 (x_report_frame_params): In X, window IDs are unsigned long,
1987 not signed long, so print them as unsigned.
1988 (validate_x_resource_name): Check for implausibly long names,
1989 and don't assume name length fits in 'int'.
1990 (x_get_resource_string): Don't blindly alloca invocation name;
1991 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1992 not fit in int.
1993
1994 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1995 (xg_check_special_colors, xg_set_geometry):
1996 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1997
1998 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1999 Use esprintf, not sprintf, in case result does not fit in int.
2000
2001 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2002 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2003 it as a large positive number.
2004 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2005 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2006
2007 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2008 in case result does not fit in int.
2009
2010 * print.c (float_to_string): Detect width overflow more reliably.
2011 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2012 buffer overrun. Don't assume list length fits in 'int'. Treat
2013 print length of 0 as 0, not as infinity; to be consistent with other
2014 uses of print length in this function. Don't overflow print length
2015 index. Don't assume hash table size fits in 'long', or that
2016 vectorlike size fits in 'unsigned long'.
2017
2018 * process.c (make_process): Use printmax_t, not int, to format
2019 process-name gensyms.
2020
2021 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2022
2023 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2024 to avoid potential buffer overrun.
2025
2026 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2027 if X resource line is longer than 512 bytes.
2028
2029 * xfns.c (x_window): Make sprintf buffer a bit bigger
2030 to avoid potential buffer overrun.
2031
2032 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2033
2034 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2035
2036 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Integer overflow fixes for scrolling, etc.
2039 Without these, Emacs silently mishandles large integers sometimes.
2040 For example, "C-u 4294967297 M-x recenter" was treated as if
2041 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2042
2043 * xdisp.c (try_window_id): Check Emacs fixnum range before
2044 converting to 'int'.
2045
2046 * window.c (window_scroll_line_based, Frecenter):
2047 Check that an Emacs fixnum is in range before assigning it to 'int'.
2048 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2049 values converted from Emacs fixnums.
2050 (Frecenter): Don't wrap around a line count if it is out of 'int'
2051 range; instead, treat it as an extreme value.
2052 (Fset_window_configuration, compare_window_configurations):
2053 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2054
2055 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2056 that can exceed INT_MAX. Check that EMACS_INT value is in range
2057 before assigning it to the (possibly-narrower) index.
2058 (match_limit): Don't assume that a fixnum can fit in 'int'.
2059
2060 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2061 exceed INT_MAX.
2062
2063 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2064 (Fvertical_motion): Don't wrap around LINES values that don't fit
2065 in 'int'. Instead, treat them as extreme values. This is good
2066 enough for windows, which can't have more than INT_MAX lines anyway.
2067
2068 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2069
2070 * Require libxml/parser.h to avoid compilation warning.
2071
2072 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2073
2074 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2075 since this reportedly can destroy thread storage.
2076
2077 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2078
2079 * syntax.c (find_defun_start): Update all cache variables if
2080 exiting early (Bug#9401).
2081
2082 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2083
2084 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2085
2086 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2087 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2088 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2089
2090 * term.c (tty_append_glyph): New function.
2091 (produce_stretch_glyph): Static function and its prototype deleted.
2092
2093 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2094 Add prototypes.
2095
2096 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2099 when checking :margin (Bug#9390).
2100 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2101 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2102 so that the name doesn't mislead. All uses changed.
2103
2104 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2105
2106 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2107 set_tty_hooks.
2108
2109 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (move_it_to): Don't bail out early when reaching
2112 position beyond to_charpos, if we are scanning backwards.
2113 (move_it_vertically_backward): When DY == 0, make sure we get to
2114 the first character in the line after the newline.
2115
2116 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2119 (ccl_driver): Do not generate an out-of-range pointer.
2120 (Fccl_execute_on_string): Remove unnecessary check for
2121 integer overflow, noted by Stefan Monnier in
2122 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2123 Remove a FIXME that didn't need fixing.
2124 Simplify the newly-introduced buffer reallocation code.
2125
2126 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2127
2128 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2129
2130 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 Integer and memory overflow issues (Bug#9196).
2133
2134 * doc.c (get_doc_string): Rework so that
2135 get_doc_string_buffer_size is the actual buffer size, rather than
2136 being 1 less than the actual buffer size; this makes xpalloc more
2137 convenient.
2138
2139 * image.c (x_allocate_bitmap_record, cache_image):
2140 * xselect.c (Fx_register_dnd_atom):
2141 Simplify previous changes by using xpalloc.
2142
2143 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2144 since either will do and ptrdiff_t is convenient with xpalloc.
2145
2146 * charset.c (charset_table_size)
2147 (struct charset_sort_data.priority): Now ptrdiff_t.
2148 (charset_compare): Don't overflow if priorities differ greatly.
2149 (Fsort_charsets): Don't assume list length fits in int.
2150 Check for size-calculation overflow when allocating sort data.
2151 (syms_of_charset): Allocate an initial charset table that is
2152 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2153
2154 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2155
2156 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2157 The actual value is always <= INT_MAX, and leaving it unsigned made
2158 overflow checking harder.
2159
2160 * dispextern.h (struct glyph_matrix.rows_allocated)
2161 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2162 with xpalloc. The values are still always <= INT_MAX.
2163
2164 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2165
2166 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2167 (SAFE_NALLOCA): New macro.
2168
2169 * region-cache.c (struct boundary.pos, find_cache_boundary)
2170 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2171 (set_cache_region, invalidate_region_cache)
2172 (revalidate_region_cache, know_region_cache, region_cache_forward)
2173 (region_cache_backward, pp_cache):
2174 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2175 so that ptrdiff_t * can be passed to xpalloc.
2176 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2177 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2178 (pp_cache): Don't assume cache_len fits in int.
2179 * region-cache.h: Adjust extern decls to match.
2180
2181 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2182 EMACS_INT, since either will do, for xpalloc.
2183
2184 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2185 (xnmalloc, xnrealloc, xpalloc): New functions.
2186
2187 * bidi.c (bidi_shelve_header_size): New constant.
2188 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2189 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2190
2191 * bidi.c (bidi_cache_shrink):
2192 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2193 (overlay_strings):
2194 Don't update size of array until after memory allocation succeeds,
2195 because xmalloc/xrealloc may not return.
2196 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2197 now that we have proper integer overflow checking.
2198 (record_overlay_string, overlay_strings): Catch overflows when
2199 calculating size of overlay_str_buf.
2200
2201 * callproc.c (Fcall_process): Check for size overflow when
2202 calculating size of args2.
2203 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2204 Normally we prefer signed values, but sticking with ptrdiff_t would
2205 require adding more-complicated checks.
2206
2207 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2208 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2209 Redo buffer-overflow calculations to avoid integer overflow.
2210 Add a FIXME comment where memory seems to be over-allocated.
2211
2212 * character.c (Fstring): Check for size-calculation overflow.
2213
2214 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2215 unnecessary integer overflow. Check for size overflow.
2216 (encode_coding_object): Don't update size until xmalloc succeeds.
2217
2218 * composite.c (get_composition_id): Check for overflow in glyph
2219 length calculations.
2220
2221 Integer and memory overflow fixes for display code.
2222 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2223 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2224 (scrolling_window): Check for overflow in size calculations.
2225 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2226 Don't assume glyph table len fits in int.
2227 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2228 (row_table_size): Now ptrdiff_t, not int.
2229 (scrolling_window): Avoid overflow in size calculations.
2230 Don't update size until allocation succeeds.
2231 * fns.c (concat): Check for overflow in size calculations.
2232 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2233 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2234 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2235
2236 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2237 (get_doc_string): Check for size calculation overflow.
2238 Don't update size until allocation succeeds.
2239 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2240 EMACS_INT, where ptrdiff_t will do.
2241 (Fsubstitute_command_keys): Check for string overflow.
2242
2243 * editfns.c (set_time_zone_rule): Don't assume environment length
2244 fits in int.
2245 (message_length): Now ptrdiff_t, not int.
2246 (Fmessage_box): Don't update size until allocation succeeds.
2247 Don't assume message length fits in int.
2248 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2249
2250 * emacs.c (main): Do not reallocate argv, since there is a null at
2251 the end that can be overwritten, and this way there's no need to
2252 worry about size-calculation overflow.
2253 (sort_args): Check for size-calculation overflow.
2254
2255 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2256 alloc succeeds.
2257 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2258
2259 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2260 (x_set_scroll_bar_width, x_figure_window_size):
2261 Check for integer overflow.
2262 (x_set_alpha): Do not assume XINT fits in int.
2263
2264 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2265 This is for the members text_lines, text_cols, total_lines, total_cols,
2266 where the system imposes an 'int' limit.
2267
2268 * fringe.c (Fdefine_fringe_bitmap):
2269 Don't update size until alloc works.
2270
2271 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2272 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2273
2274 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2275 Check for size-calculation overflow.
2276 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2277 do, as we prefer signed integers.
2278 (id_to_widget.max_size, id_to_widget.used)
2279 (xg_store_widget_in_map, xg_remove_widget_from_map)
2280 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2281 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2282 Use and return ptrdiff_t, not int.
2283 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2284 * gtkutil.h: Change prototypes to match the above.
2285
2286 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2287 are duplicate now that they've been promoted to lisp.h.
2288 (x_allocate_bitmap_record, x_alloc_image_color)
2289 (make_image_cache, cache_image, xpm_load):
2290 Don't update size until alloc is done.
2291 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2292 (x_detect_edges):
2293 Check for size calculation overflow.
2294 (ct_colors_allocated_max): New constant.
2295 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2296 overflow.
2297
2298 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2299 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2300 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2301 Use ptrdiff_t, not int, to count maps.
2302 (read_char_minibuf_menu_prompt): Check for overflow in size
2303 calculations. Don't update size until allocation succeeds.
2304 Redo calculations to avoid overflow.
2305 * keyboard.h: Change prototypes to match the above.
2306
2307 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2308 to count maps.
2309 (current_minor_maps): Check for size calculation overflow.
2310 * keymap.h: Change prototypes to match the above.
2311
2312 * lread.c (read1, init_obarray): Don't update size until alloc done.
2313
2314 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2315 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2316
2317 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2318 Now ptrdiff_t, not int.
2319 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2320 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2321
2322 * process.c (Fnetwork_interface_list): Check for overflow
2323 in size calculation.
2324
2325 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2326
2327 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2328 overflow. Don't bother calling xmalloc when xrealloc will do.
2329
2330 * search.c (Freplace_match): Check for size calculation overflow.
2331 (Fset_match_data): Don't assume list lengths fit in 'int'.
2332
2333 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2334 for command line length. Do not attempt to address one before the
2335 beginning of an array, as that's not portable.
2336
2337 * term.c (max_frame_lines): Remove; unused.
2338 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2339 not int.
2340 (encode_terminal_code, calculate_costs): Check for size
2341 calculation overflow.
2342 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2343 table lengths and related sizes. Don't update size until alloc
2344 done. Redo calculations to avoid overflow.
2345 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2346
2347 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2348 subtracting pointers.
2349 (gobble_line): Check for overflow more carefully. Don't update size
2350 until alloc done.
2351
2352 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2353 Don't update size until alloc done.
2354 Redo size calculations to avoid overflow.
2355 Check for size calculation overflow.
2356 (main) [DEBUG]: Fix typo in invoking tparam1.
2357
2358 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2359 Use ptrdiff_t, not int, for sizes.
2360 (store_mode_line_noprop_char): Don't update size until alloc done.
2361
2362 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2363 Use ptrdiff_t, not int, for sizes.
2364 (Finternal_make_lisp_face, cache_face):
2365 Check for size calculation overflow.
2366 (cache_face): Treat size calculation overflows as if they were
2367 memory exhaustion (the usual treatment), rather than aborting.
2368
2369 * xfns.c (x_encode_text, x_set_name_internal)
2370 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2371 sizes, since they can exceed INT_MAX in size. Check for size
2372 calculation overflow.
2373
2374 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2375 (xg_select): Check for size calculation overflow.
2376 Don't update size until alloc done.
2377
2378 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2379 as sprintf is limited to int lengths.
2380
2381 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2382 (X_LONG_MIN): New macros.
2383 Use them to make the following changes clearer.
2384 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2385 This change doesn't affect the value now, but it may help remind
2386 future maintainers not to raise the value too much later.
2387 (SELECTION_QUANTUM): Remove, replacing with ...
2388 (selection_quantum): ... new function, which avoids overflow.
2389 All uses changed.
2390 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2391 assumption that selection length fits in 'int'.
2392 (x_reply_selection_request, x_handle_selection_request)
2393 (x_get_window_property, receive_incremental_selection)
2394 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2395 (lisp_data_to_selection_data, clean_local_selection_data):
2396 Use ptrdiff_t, not int, to record length of selection.
2397 (x_reply_selection_request, x_get_window_property)
2398 (receive_incremental_selection, x_property_data_to_lisp):
2399 Redo calculations to avoid overflow.
2400 (x_reply_selection_request): When sending hint, ceiling it at
2401 X_LONG_MAX rather than relying on wraparound overflow to send
2402 something.
2403 (x_get_window_property, receive_incremental_selection)
2404 (lisp_data_to_selection_data, x_property_data_to_lisp):
2405 Check for size-calculation overflow.
2406 (x_get_window_property, receive_incremental_selection)
2407 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2408 Don't store size until memory allocation succeeds.
2409 (x_get_window_property): Plug memory leak on memory exhaustion.
2410 Don't double-block input; malloc is safe here. Don't assume 2**34
2411 - 4 fits in unsigned long. Add an xassert to check
2412 XGetWindowProperty overflow. Be more careful about overflow
2413 calculations, and distinguish size from memory overflow better.
2414 (receive_incremental_selection): When tracing, don't assume
2415 unsigned int is less than INT_MAX.
2416 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2417 harmful) conversions of unsigned short to int.
2418 (lisp_data_to_selection_data): Don't assume that integers
2419 in the range -65535 through -1 fit in an X unsigned short.
2420 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2421 result parameters unless successful. Rely on cons_to_unsigned
2422 to report problems with elements; the old code wasn't right anyway.
2423 (x_check_property_data): Check for int overflow; we cannot use
2424 a wider type due to X limits.
2425 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2426
2427 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2428
2429 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2430 (x_term_init): Check for size calculation overflow.
2431 (x_color_cells): Don't store size until memory allocation succeeds.
2432 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2433 Don't assume alloca size is less than MAX_ALLOCA.
2434 (x_term_init): Don't assume length fits in int (sprintf is limited
2435 to int size).
2436
2437 Use ptrdiff_t for composition IDs.
2438 * character.c (lisp_string_width):
2439 * composite.c (composition_table_size, n_compositions)
2440 (get_composition_id, composition_gstring_from_id):
2441 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2442 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2443 * window.c (Frecenter):
2444 Use ptrdiff_t, not int, for composition IDs.
2445 * composite.c (get_composition_id): Check for integer overflow.
2446 * composite.h: Adjust prototypes to match the above changes.
2447
2448 Use ptrdiff_t for hash table indexes.
2449 * category.c (hash_get_category_set):
2450 * ccl.c (ccl_driver):
2451 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2452 * coding.c (coding_system_charset_list, detect_coding_system):
2453 * coding.h (struct coding_system.id):
2454 * composite.c (get_composition_id, gstring_lookup_cache):
2455 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2456 * image.c (xpm_get_color_table_h):
2457 * lisp.h (hash_lookup, hash_put):
2458 * minibuf.c (Ftest_completion):
2459 Use ptrdiff_t for hash table indexes, not int (which is too
2460 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2461 32-bit --with-wide-int hosts).
2462
2463 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2464 Add a FIXME comment about memory leaks.
2465 (syms_of_charset): Don't assume xmalloc returns.
2466
2467 Don't assume that stated character widths fit in int.
2468 * character.c (Fchar_width, c_string_width, lisp_string_width):
2469 * character.h (CHAR_WIDTH):
2470 * indent.c (MULTIBYTE_BYTES_WIDTH):
2471 Use sanitize_char_width to avoid undefined and/or bad behavior
2472 with outlandish widths.
2473 * character.h (sanitize_tab_width): Rename from sanitize_width,
2474 now that we have two such functions. All uses changed.
2475 (sanitize_char_width): New inline function.
2476
2477 Don't assume that tab-width fits in int.
2478 * character.h (sanitize_width): New inline function.
2479 (SANE_TAB_WIDTH): New macro.
2480 (ASCII_CHAR_WIDTH): Use it.
2481 * indent.c (sane_tab_width): Remove. All uses replaced by
2482 SANE_TAB_WIDTH (current_buffer).
2483 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2484
2485 * fileio.c: Integer overflow issues with file modes.
2486 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2487
2488 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2489 Remove unreachable code.
2490 (read_hex, load_charset_map_from_file): Check for integer overflow.
2491
2492 * xterm.c: Don't go over XClientMessageEvent limit.
2493 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2494 (x_send_scroll_bar_event): Likewise. Check that the size does not
2495 exceed limits imposed by XClientMessageEvent, as well as the usual
2496 ptrdiff_t and size_t limits.
2497
2498 * keyboard.c: Overflow, signedness and related fixes.
2499 (make_lispy_movement): Use same integer type in forward decl
2500 that is used in the definition.
2501 (read_key_sequence, keyremap_step):
2502 Change bufsize argument back to int, undoing my 2011-03-30 change.
2503 We prefer signed types, and int is wide enough here.
2504 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2505 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2506 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2507 length, not size_t. Use ptrdiff_t for index, not int.
2508 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2509 possibility of integer overflow.
2510
2511 Overflow, signedness and related fixes for images.
2512
2513 * dispextern.h (struct it.stack[0].u.image.image_id)
2514 (struct_it.image_id, struct image.id, struct image_cache.size)
2515 (struct image_cache.used, struct image_cache.ref_count):
2516 * gtkutil.c (update_frame_tool_bar):
2517 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2518 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2519 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2520 * nsmenu.m (update_frame_tool_bar):
2521 * xdisp.c (calc_pixel_width_or_height):
2522 * xfns.c (image_cache_refcount):
2523 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2524 on typical 64-bit hosts.
2525
2526 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2527 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2528 Omit unnecessary casts to int.
2529 (parse_image_spec): Check that integers fall into 'int' range
2530 when the callers expect that.
2531 (image_ascent): Redo ascent calculation to avoid int overflow.
2532 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2533 (lookup_image): Remove unnecessary tests.
2534 (xbm_image_p): Locals are now of int, not EMACS_INT,
2535 since parse_image_check makes sure they fit into int.
2536 (png_load, gif_load, svg_load_image):
2537 Prefer int to unsigned where either will do.
2538 (tiff_handler): New function, combining the cores of the
2539 old tiff_error_handler and tiff_warning_handler.
2540 This function is rewritten to use vsnprintf and thereby avoid
2541 stack buffer overflows. It uses only the features of vsnprintf
2542 that are common to both POSIX and native Microsoft.
2543 (tiff_error_handler, tiff_warning_handler): Use it.
2544 (tiff_load, gif_load, imagemagick_load_image):
2545 Don't assume :index value fits in 'int'.
2546 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2547 (imagemagick_load_image): Check that crop parameters fit into
2548 the integer types that MagickCropImage accepts. Don't assume
2549 Vimagemagick_render_type has a nonnegative value. Don't assume
2550 size_t fits in 'long'.
2551 (gs_load): Use printmax_t to print the widest integers possible.
2552 Check for integer overflow when computing image height and width.
2553
2554 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2555
2556 * xdisp.c (redisplay_window): Don't force window start if point
2557 will be invisible in the resulting window. (Bug#9324)
2558
2559 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2560
2561 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2562 the display spec is of the form `(space ...)'.
2563 (handle_display_spec): Return the value returned by
2564 handle_single_display_spec, not just 1 or zero.
2565 (handle_single_display_spec): If the display spec is of the form
2566 `(space ...)', and specifies display in the text area, return 2
2567 rather than 1.
2568 (try_cursor_movement): Check for the need to scroll more
2569 accurately, and prefer exact match for point under bidi.
2570 Don't advance `row' beyond the last row of the window.
2571
2572 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2573 into disp_prop; all users changed.
2574
2575 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2576 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2577 for the text covered by the display property.
2578
2579 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2580
2581 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2582 Change return value to nil.
2583 (Frecord_buffer): Delete unused function.
2584
2585 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2586
2587 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2588 buffers, return left-to-right.
2589 (set_cursor_from_row): Consider candidate row a win if its glyph
2590 represents a newline and point is on that newline. Fixes cursor
2591 positioning on the newline at EOL of R2L text within L2R
2592 paragraph, and vice versa.
2593 (try_cursor_movement): Check continued rows, in addition to
2594 continuation rows. Fixes unwarranted scroll when point enters a
2595 continued line of R2L text within an L2R paragraph, or vice versa.
2596 (cursor_row_p): Consider the case of point being equal to
2597 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2598 from the end of a short line to the beginning of a continued line
2599 of R2L text within L2R paragraph.
2600 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2601 composed characters.
2602
2603 * bidi.c (bidi_check_type): Use xassert.
2604 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2605 members.
2606
2607 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2608
2609 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2610 a character.
2611
2612 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2613
2614 * nsfont.m (ns_otf_to_script): Fix typo.
2615
2616 2011-08-22 Kenichi Handa <handa@m17n.org>
2617
2618 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2619 extra slot even if the purpose is char-code-property-table.
2620
2621 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (redisplay_window): When computing centering_position,
2624 account for the height of the header line. (Bug#8874)
2625
2626 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2627 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2628 candidate is selected by the mouse, and that candidate has a
2629 composed character under the mouse.
2630
2631 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2632 coordinates reported by pos-visible-in-window-p for a composed
2633 character in column zero.
2634
2635 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2636
2637 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2638
2639 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2640
2641 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2642 consider it a hit if to_charpos is anywhere in the range of the
2643 composed buffer positions.
2644
2645 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2646
2647 * image.c (gif_load): Don't assume that each subimage has the same
2648 dimensions as the base image. Handle disposal method that is
2649 "undefined" by the gif spec (Bug#9335).
2650
2651 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2654 (Fcondition_case): Document `debug' symbol in error handler.
2655
2656 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2659 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2660 from an Org mode buffer to a Speedbar frame.
2661
2662 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2663 a composition, take its buffer position from IT->cmp_it.charpos.
2664 Fixes cursor positioning at the beginning of a line that begins
2665 with a composed character.
2666
2667 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2668
2669 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2670 character bidirectional type, use STRONG_L instead. Fixes crashes
2671 in a buffer produced by `describe-categories'.
2672
2673 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2674 members before the level stack, so they would be saved and
2675 restored when copying iterator state. Fixes incorrect reordering
2676 around TABs covered by display properties.
2677
2678 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2679
2680 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2681
2682 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2683
2684 * eval.c (internal_condition_case, internal_condition_case_1)
2685 (internal_condition_case_2, internal_condition_case_n):
2686 Remove unnecessary aborts (Bug#9081).
2687
2688 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2689
2690 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2691 has no `load' handler, try opening the file locally. (Bug#9311)
2692
2693 2011-08-16 Ken Brown <kbrown@cornell.edu>
2694
2695 * gmalloc.c: Expand comment.
2696
2697 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2698
2699 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2700 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2701
2702 2011-08-16 Ken Brown <kbrown@cornell.edu>
2703
2704 Fix memory allocation problems in Cygwin build (Bug#9273).
2705
2706 * unexcw.c ( __malloc_initialized): Declare external variable.
2707 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2708
2709 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2710 New variables.
2711 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2712 dumped emacs.
2713 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2714 in the static heap.
2715 [CYGWIN] (special_realloc): New function.
2716 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2717 requests to realloc storage in the static heap.
2718
2719 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * bidi.c (bidi_initialize): Remove unused local.
2722
2723 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2724
2725 * bidimirror.h:
2726 * biditype.h: Remove file.
2727 * makefile.w32-in ($(BLD)/bidi.$(O)):
2728 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2729
2730 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2731
2732 * chartab.c: Improve commentary for the uniprop_table API.
2733
2734 * bidi.c (bidi_paragraph_init): Support zero value of
2735 bidi_ignore_explicit_marks_for_paragraph_level.
2736 (bidi_initialize): Use uniprop_table instead of including
2737 biditype.h and bidimirror.h.
2738
2739 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2740 coordinates of the iterator when restoring from ppos_it.
2741 (Bug#9296)
2742
2743 2011-08-14 Kenichi Handa <handa@m17n.org>
2744
2745 * process.c (create_process): Call setup_process_coding_systems
2746 after the pid of the process is set to -1 (Bug#8162).
2747
2748 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2749
2750 * xdisp.c (move_it_in_display_line_to): Don't invoke
2751 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2752 ppos_it. Fixes vertical cursor motion when line beginning is
2753 covered by an image. (Bug#9296)
2754
2755 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2756
2757 * nsterm.h (ns_run_ascript): Declare.
2758 (NSAPP_DATA2_RUNASSCRIPT): Define.
2759
2760 * nsfns.m (as_script, as_result, as_status): New static variables.
2761 (ns_run_ascript): New function.
2762 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2763 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2764 the event loop. Get status from as_status (Bug#7276).
2765
2766 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2767 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2768 the event loop (Bug#7276).
2769
2770 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2771
2772 * gnutls.c (QCgnutls_bootprop_priority)
2773 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2774 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2775 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2776 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2777 (QCgnutls_bootprop_verify_hostname_error)
2778 (QCgnutls_bootprop_callbacks_verify): Rename from
2779 Qgnutls_bootprop_..., all uses changed.
2780
2781 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2782 uses changed.
2783
2784 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * xfaces.c (Qframe_set_background_mode): Now static.
2787 * dispextern.h (Qframe_set_background_mode): Remove decl.
2788
2789 * process.c (Fnetwork_interface_info): Declare local only if needed.
2790
2791 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2792
2793 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2794 (Fnetwork_interface_list): Allocate in increments of bytes instead
2795 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2796 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2797 sockaddr.
2798 (struct ifflag_def): notrailers is smart on OSX.
2799 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2800 Get hardware address with getifaddrs if available.
2801
2802 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2803
2804 * xdisp.c (iterate_out_of_display_property): xassert that
2805 IT->position is set to within IT->object's boundaries. Break from
2806 the loop as soon as EOB is reached; avoids infloops in redisplay
2807 when IT->position is set up wrongly due to some bug.
2808 Set IT->current to match the bidi iterator unconditionally.
2809 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2810 entry. Force push_it to save on the stack the current
2811 buffer/string position, to be restored by pop_it. Fix flags in
2812 the iterator structure wrt the object coming from a display
2813 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2814 properties. (Bug#9284)
2815
2816 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2817
2818 * fontset.c (fontset_get_font_group): Add proper type checks.
2819 (Bug#9172)
2820
2821 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2822
2823 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2824 and LC_VERSION_MIN_MACOSX.
2825 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2826 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2827
2828 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2829
2830 * xdisp.c (forward_to_next_line_start): Allow to use the
2831 no-display-properties-and-no-overlays under bidi display.
2832 Set disp_pos in the bidi iterator to avoid searches for display
2833 properties and overlays.
2834
2835 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2836
2837 * editfns.c (Fset_time_zone_rule): Document relationship with the
2838 setenv function.
2839
2840 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2841 the font entity extracted from the cache (Bug#8109).
2842
2843 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2844
2845 * composite.c (autocmp_chars): Don't reset point. That is done by
2846 restore_point_unwind (Bug#5984).
2847
2848 2011-08-07 Juri Linkov <juri@jurta.org>
2849
2850 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2851 to show the arg `TIME' instead of `TIMEVAL'.
2852
2853 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2854
2855 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2856 display property strides EOL and includes a newline, as in
2857 longlines-mode. (Bug#9254)
2858 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2859 word-wrap under bidirectional display. (Bug#9224)
2860
2861 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2862 is non-zero, even if the data buffer is NULL. Fixes a crash in
2863 vertical-motion with longlines-mode. (Bug#9254)
2864
2865 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2866
2867 * bidi.c <bidi_cache_total_alloc>: Now static.
2868 (bidi_initialize): Initialize bidi_cache_total_alloc.
2869
2870 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2871 cache. (Bug#9221)
2872
2873 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2874 amount allocated this far in `bidi_cache_total_alloc'.
2875 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2876 non-zero, only free the data buffer without restoring the cache
2877 contents. All callers changed.
2878
2879 * dispextern.h (bidi_unshelve_cache): Update prototype.
2880
2881 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2882 (move_it_in_display_line, move_it_to)
2883 (move_it_vertically_backward, move_it_by_lines): Replace the call
2884 to xfree to an equivalent call to bidi_unshelve_cache.
2885 (move_it_in_display_line_to): Fix logic of returning
2886 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2887
2888 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2889
2890 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2891 came from a string character with a `cursor' property. (Bug#9229)
2892
2893 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2894
2895 * Makefile.in (LIB_PTHREAD): New variable.
2896 (LIBES): Add LIB_PTHREAD (Bug#9216).
2897
2898 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2899 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2900
2901 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2902
2903 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2904
2905 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2906
2907 * xterm.c (x_find_topmost_parent): New function.
2908 (x_set_frame_alpha): Find topmost parent window with
2909 x_find_topmost_parent and set the property there also (bug#9181).
2910 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2911
2912 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * callproc.c (Fcall_process): Avoid vfork clobbering
2915 the local vars buffer, coding_systems, current_dir.
2916
2917 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2920
2921 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2924 so that it is not optimized away.
2925
2926 * xdisp.c (compute_display_string_pos): Remove unused local.
2927
2928 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2929
2930 Fix slow cursor motion and scrolling in large buffers with
2931 selective display, like Org Mode buffers. (Bug#9218)
2932
2933 * dispextern.h (struct bidi_it): New member disp_prop_p.
2934
2935 * xdisp.c: Remove one-slot cache of display string positions.
2936 (compute_display_string_pos): Accept an additional argument
2937 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2938 for a display string or property. If found, set DISP_PROP_P
2939 non-zero.
2940
2941 * bidi.c (bidi_fetch_char): Accept an additional argument
2942 DISP_PROP_P, and pass it to compute_display_string_pos.
2943 Only handle text covered by a display string if DISP_PROP_P is returned
2944 non-zero. All callers of bidi_fetch_char changed.
2945
2946 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2949
2950 2010-12-03 Don March <don@ohspite.net>
2951
2952 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2953 last character M-[char] is translated to ESC [char] (bug#7541).
2954
2955 2011-08-02 Kenichi Handa <handa@m17n.org>
2956
2957 * lisp.h (uniprop_table): Extern it.
2958
2959 * chartab.c (uniprop_table): Make it non-static.
2960
2961 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2962
2963 * xdisp.c (forward_to_next_line_start): Accept additional argument
2964 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2965 on the newline.
2966 (reseat_at_next_visible_line_start): Use the bidi iterator state
2967 returned by forward_to_next_line_start to restore the state of
2968 it->bidi_it after backing up to previous newline. (Bug#9212)
2969
2970 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2971
2972 * regex.c (re_comp): Protoize.
2973 (re_exec): Fix return type.
2974 (regexec): Fix type of `ret'. (Bug#9203)
2975
2976 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2979 This is needed if max-image-size is a floating-point number.
2980
2981 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2982
2983 * print.c (print_object): Print empty symbol as ##.
2984
2985 * lread.c (read1): Read ## as empty symbol.
2986
2987 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2988
2989 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2990 setting frame foreground color (Bug#9175).
2991 (x_set_background_color): Likewise.
2992
2993 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2994 contents (Bug#9176).
2995 (EmacsTooltip -init): Remove bezels and add shadows to
2996 tooltip windows.
2997
2998 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2999 or scroll bar (Bug#8470).
3000
3001 * nsfont.m (nsfont_open): Remove assignment to voffset and
3002 unnecessary vars hshink, expand, hd, full_height, min_height.
3003 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3004
3005 * nsterm.h (nsfont_info): Remove voffset field.
3006
3007 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3008
3009 Implement strike-through and overline on NextStep (Bug#8863).
3010
3011 * nsfont.m (nsfont_open): Use underline position provided by font,
3012 instead of hard-coded value of 2.
3013 (nsfont_draw): Call ns_draw_text_decoration instead.
3014
3015 * nsterm.h: Add declaration for ns_draw_text_decoration.
3016
3017 * nsterm.m (ns_draw_text_decoration): New function for drawing
3018 underline, overline, and strike-through.
3019 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3020 ns_draw_text_decoration. Change treatment of cursor drawing to
3021 accommodate underlining, etc.
3022
3023 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3024
3025 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3026 default.
3027
3028 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3031 Without this fix, if a signal arrives just after memory fills up,
3032 'malloc' might be invoked reentrantly.
3033
3034 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3035 In other words, assume that every image size is allowed, on non-X
3036 hosts. This assumption is probably wrong, but it lets Emacs compile.
3037
3038 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3039
3040 * regex.c (re_iswctype): Convert return values to boolean.
3041
3042 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3043
3044 * xdisp.c (compute_display_string_pos): Don't use cached display
3045 string position if the buffer had its restriction changed.
3046 (Bug#9184)
3047
3048 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3051
3052 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 Integer signedness and overflow and related fixes. (Bug#9079)
3055
3056 * bidi.c: Integer size and overflow fixes.
3057 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3058 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3059 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3060 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3061 (bidi_find_other_level_edge):
3062 Use ptrdiff_t instead of EMACS_INT where either will do.
3063 This works better on 32-bit hosts configured --with-wide-int.
3064 (bidi_cache_ensure_space): Check for size-calculation overflow.
3065 Use % rather than repeated addition, for better worst-case speed.
3066 Don't set bidi_cache_size until after xrealloc returns, because it
3067 might not return.
3068 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3069 (bidi_cache_ensure_space): Also check that the bidi cache size
3070 does not exceed that of the largest Lisp string or buffer. See Eli
3071 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3072
3073 * alloc.c (__malloc_size_t): Remove.
3074 All uses replaced by size_t. See Andreas Schwab's note
3075 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3076
3077 * image.c: Improve checking for integer overflow.
3078 (check_image_size): Assume that f is nonnull, since
3079 it is always nonnull in practice. This is one less thing to
3080 worry about when checking for integer overflow later.
3081 (x_check_image_size): New function, which checks for integer
3082 overflow issues inside X.
3083 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3084 This removes the need for a memory_full check.
3085 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3086 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3087 (xbm_read_bitmap_data): Change locals back to 'int', since
3088 their values must fit in 'int'.
3089 (xpm_load_image, png_load, tiff_load):
3090 Invoke x_create_x_image_and_pixmap earlier,
3091 to avoid much needless work if the image is too large.
3092 (tiff_load): Treat overly large images as if
3093 x_create_x_image_and_pixmap failed, not as malloc failures.
3094 (gs_load): Use x_check_image_size.
3095
3096 * gtkutil.c: Omit integer casts.
3097 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3098 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3099
3100 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3101
3102 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3103 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3104 would wrongly return t on a 64-bit host.
3105
3106 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3107 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3108 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3109 and therefore cause GCC to emit a bogus diagnostic in some cases.
3110
3111 * image.c: Integer signedness and overflow and related fixes.
3112 This is not an exhaustive set of fixes, but it's time to
3113 record what I've got.
3114 (lookup_pixel_color, check_image_size): Remove redundant decls.
3115 (check_image_size): Don't assume that arbitrary EMACS_INT values
3116 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3117 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3118 (tiff_load, imagemagick_load_image):
3119 Check for overflow in size calculations.
3120 (x_create_x_image_and_pixmap): Remove unnecessary test for
3121 xmalloc returning NULL; that can't happen.
3122 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3123 (xpm_color_bucket): Use better integer hashing function.
3124 (xpm_cache_color): Don't possibly over-allocate memory.
3125 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3126 (gif_memory_source):
3127 Use ptrdiff_t, not int or size_t, to record sizes.
3128 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3129 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3130 either works, as we prefer signed integers.
3131 (tiff_read_from_memory, tiff_write_from_memory):
3132 Return tsize_t, not size_t, since that's what the TIFF API wants.
3133 (tiff_read_from_memory): Don't fail simply because the read would
3134 go past EOF; instead, return a short read.
3135 (tiff_load): Omit no-longer-needed casts.
3136 (Fimagemagick_types): Don't assume size fits into 'int'.
3137
3138 Improve hashing quality when configured --with-wide-int.
3139 * fns.c (hash_string): New function, taken from sxhash_string.
3140 Do not discard information about ASCII character case; this
3141 discarding is no longer needed.
3142 (sxhash-string): Use it. Change sig to match it. Caller changed.
3143 * lisp.h: Declare it.
3144 * lread.c (hash_string): Remove, since we now use fns.c's version.
3145 The fns.c version returns a wider integer if --with-wide-int is
3146 specified, so this should help the quality of the hashing a bit.
3147
3148 * emacs.c: Integer overflow minor fix.
3149 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3150 Define only if GNU_LINUX.
3151 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3152
3153 * dispnew.c: Integer signedness and overflow fixes.
3154 Remove unnecessary forward decls, that were a maintenance hassle.
3155 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3156 All uses changed.
3157 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3158 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3159 (prepare_desired_row, line_draw_cost):
3160 Use int, not unsigned, where either works.
3161 (save_current_matrix, restore_current_matrix):
3162 Use ptrdiff_t, not size_t, where either works.
3163 (init_display): Check for overflow more accurately, and without
3164 relying on undefined behavior.
3165
3166 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3167 Remove, replacing with the new symbols in lisp.h. All uses changed.
3168 * fileio.c (make_temp_name):
3169 * filelock.c (lock_file_1, lock_file):
3170 * xdisp.c (message_dolog):
3171 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3172 Use pMd etc. instead.
3173 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3174 replacing the pWIDE etc. symbols removed from editfns.c.
3175
3176 * keyboard.h (num_input_events): Now uintmax_t.
3177 This is (very slightly) less likely to mess up due to wraparound.
3178 All uses changed.
3179
3180 * buffer.c: Integer signedness fixes.
3181 (alloc_buffer_text, enlarge_buffer_text):
3182 Use ptrdiff_t rather than size_t when either will do, as we prefer
3183 signed integers.
3184
3185 * alloc.c: Integer signedness and overflow fixes.
3186 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3187 (__malloc_size_t): Default to size_t, not to int.
3188 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3189 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3190 Prefer ptrdiff_t to size_t when either would do, as we prefer
3191 signed integers.
3192 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3193 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3194 Now const. Initialize with values that are in range even if char
3195 is signed.
3196 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3197 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3198 These functions do the right thing with sizes > 2**32.
3199 (check_depth): Now ptrdiff_t, not int.
3200 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3201 Adjust to new way of storing sizes. Check for size overflow bugs
3202 in rest of code.
3203 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3204 slightly wrong anyway, as it missed one instance of
3205 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3206 (refill_memory_reserve): Omit needless cast to size_t.
3207 (mark_object_loop_halt): Mark as externally visible.
3208
3209 * xselect.c: Integer signedness and overflow fixes.
3210 (Fx_register_dnd_atom, x_handle_dnd_message):
3211 Use ptrdiff_t, not size_t, since we prefer signed.
3212 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3213 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3214 x_dnd_atoms_size and x_dnd_atoms_length.
3215
3216 * doprnt.c: Prefer signed to unsigned when either works.
3217 * eval.c (verror):
3218 * doprnt.c (doprnt):
3219 * lisp.h (doprnt):
3220 * xdisp.c (vmessage):
3221 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3222 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3223 prefer signed arithmetic to avoid comparison confusion.
3224 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3225 but is a bit tricky.
3226
3227 Assume freestanding C89 headers, string.h, stdlib.h.
3228 * data.c, doprnt.c, floatfns.c, print.c:
3229 Include float.h unconditionally.
3230 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3231 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3232 * regex.c: Likewise for stddef.h, string.h.
3233 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3234 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3235 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3236 (STDC_HEADERS): Remove obsolete defines.
3237 * sysdep.c: Include limits.h unconditionally.
3238
3239 Assume support for memcmp, memcpy, memmove, memset.
3240 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3241 * regex.c (memcmp, memcpy):
3242 Remove; we assume C89 now.
3243
3244 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3245 (__malloc_safe_bcopy): Remove; no longer needed.
3246
3247 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3248 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3249 well either way, and we prefer signed to unsigned.
3250
3251 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3252
3253 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3254 closes the connection while we're reading (bug#9182).
3255
3256 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3257
3258 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3259 are specified (Bug#9168).
3260
3261 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3264 Found by GCC static checking and --with-wide-int on a 32-bit host.
3265
3266 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3267
3268 * xdisp.c (compute_display_string_pos): Fix logic of caching
3269 previous display string position. Initialize cached_prev_pos to
3270 -1. Fixes slow-down at the beginning of a buffer.
3271
3272 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3273
3274 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3275 for attrs[LFACE_FONTSET_INDEX].
3276
3277 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * xml.c (parse_region): Remove unused local
3280 that was recently introduced.
3281
3282 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3285 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3286
3287 * xdisp.c (move_it_in_display_line_to): Record the best matching
3288 position for TO_CHARPOS while scanning the line, and restore it on
3289 exit if none of the characters scanned was an exact match.
3290 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3291 when exact match is impossible due to invisible text, and the
3292 lines are truncated.
3293
3294 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3295
3296 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3297 for OSX >= 10.7.
3298
3299 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3300
3301 Fix a significant slow-down of cursor motion with C-n, C-p,
3302 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3303 auto-repeat under bidi redisplay in fontified buffers.
3304 * xdisp.c (compute_stop_pos_backwards): New function.
3305 (next_element_from_buffer): Call compute_stop_pos_backwards to
3306 find a suitable prev_stop when we find ourselves before
3307 base_level_stop.
3308 (reseat): Don't look for prev_stop, as that could mean a very long
3309 run.
3310 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3311 <cached_disp_overlay_modiff>: Cache for last found display string
3312 position.
3313 (compute_display_string_pos): Return the cached position if asked
3314 about the same buffer in the same area of character positions, and
3315 the buffer wasn't changed since the time the display string
3316 position was cached.
3317
3318 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3321 is an integer, which is important for empty lines. (Bug#9149)
3322
3323 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3324
3325 * frame.c (Fmodify_frame_parameters): In tty case, update the
3326 default face if necessary (Bug#4238).
3327
3328 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * editfns.c (Fstring_to_char): No need to explain what a character
3331 is in the docstring (Bug#6576).
3332
3333 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3334
3335 * xml.c (parse_region): Make sure we always return a tree.
3336
3337 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3338
3339 * xml.c (parse_region): If a document contains only comments,
3340 return that, too.
3341
3342 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3343
3344 * xml.c (make_dom): Return comments, too.
3345
3346 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 Port to OpenBSD.
3349 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3350 and the surrounding thread.
3351 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3352 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3353 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3354 timer goes off.
3355 * s/openbsd.h (BROKEN_SIGIO): Define.
3356 * unexelf.c (unexec) [__OpenBSD__]:
3357 Don't update the .mdebug section of the Alpha COFF symbol table.
3358
3359 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3360
3361 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3362 (bug#8460).
3363
3364 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3367 This fixes some race conditions on the permissions of any newly
3368 created file.
3369
3370 * alloc.c (valid_pointer_p): Use pipe, not open.
3371 This fixes some permissions issues when debugging.
3372
3373 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3374 If fchown fails to set both uid and gid, try to set just gid,
3375 as that is sometimes allowed. Adjust the file's mode to eliminate
3376 setuid or setgid bits that are inappropriate if fchown fails.
3377
3378 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3381 to compare Lisp_Objects.
3382 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3383 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3384 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3385
3386 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3387
3388 * lread.c (read_integer): Unread even EOF character.
3389 (read1): Likewise. Properly record start position of symbol.
3390
3391 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3392 symbol character follows.
3393
3394 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3395
3396 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3397 This works around a problem with the previous change to Fcopy_file.
3398 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3399 and without this change, GCC might complain about discarding
3400 fchown's return value.
3401
3402 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3403
3404 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3405
3406 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3409
3410 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3411
3412 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3413 it's used from the C level.
3414
3415 * process.c: Use the same condition for POLL_FOR_INPUT in both
3416 keyboard.c and process.c (bug#1858).
3417
3418 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3419
3420 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3421 (Fgnutls_boot): Use it.
3422
3423 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3424
3425 * doc.c (Fsubstitute_command_keys): Revert last change.
3426
3427 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3428
3429 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3430 quotes the next character, and doesn't affect other longer
3431 sequences (bug#8935).
3432
3433 * lread.c (syms_of_lread): Clarify that is isn't only
3434 `eval-buffer' and `eval-defun' that's affected by
3435 `lexical-binding' (bug#8460).
3436
3437 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3438
3439 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3440 bidi redisplay when a line includes both an image and is truncated.
3441
3442 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Fix minor problems found by static checking.
3445 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3446 (elsz): Now a signed constant, not a size_t var. We prefer signed
3447 types to unsigned, to avoid integer comparison confusion. Without
3448 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3449 "cannot optimize loop, the loop counter may overflow", a symptom
3450 of the confusion.
3451 * indent.c (Fvertical_motion): Mark locals as initialized.
3452 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3453
3454 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3455
3456 * search.c (Fre_search_backward): Mention `case-fold-search' in
3457 all the re_search_* functions (bug#8138).
3458
3459 * keyboard.c (Fopen_dribble_file): Document when the file is
3460 closed (bug#8056).
3461
3462 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3463
3464 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3465 bidi_cache_idx.
3466
3467 Support bidi reordering of display and overlay strings.
3468 * xdisp.c (compute_display_string_pos)
3469 (compute_display_string_end): Accept additional argument STRING.
3470 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3471 (reseat_to_string): Initialize bidi_it->string.s and
3472 bidi_it->string.schars.
3473 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3474 NULL (avoids a crash in bidi_paragraph_init).
3475 Initialize itb.string.lstring.
3476 (init_iterator): Call bidi_init_it only of a valid
3477 buffer position was specified. Initialize paragraph_embedding to
3478 L2R.
3479 (reseat_to_string): Initialize the bidi iterator.
3480 (display_string): If we need to ignore text properties of
3481 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3482 original value of -1 will not work with bidi.)
3483 (compute_display_string_pos): First arg is now struct
3484 `text_pos *'; all callers changed. Support display properties on
3485 Lisp strings.
3486 (compute_display_string_end): Support display properties on Lisp
3487 strings.
3488 (init_iterator, reseat_1, reseat_to_string): Initialize the
3489 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3490 when iterating on a string not from display properties).
3491 (compute_display_string_pos, compute_display_string_end):
3492 Fix calculation of the object to scan. Fixes an error when using
3493 arrow keys.
3494 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3495 base_level_stop; instead, set base_level_stop to BEGV.
3496 Fixes crashes in vertical-motion.
3497 (next_element_from_buffer): Improve commentary for when
3498 the iterator is before prev_stop.
3499 (init_iterator): Initialize bidi_p from the default value of
3500 bidi-display-reordering, not from buffer-local value. Use the
3501 buffer-local value only if initializing for buffer iteration.
3502 (handle_invisible_prop): Support invisible properties on strings
3503 that are being bidi-reordered.
3504 (set_iterator_to_next): Support bidi reordering of C strings and
3505 Lisp strings.
3506 (next_element_from_string): Support bidi reordering of Lisp
3507 strings.
3508 (handle_stop_backwards): Support Lisp strings as well.
3509 (display_string): Support display of R2L glyph rows.
3510 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3511 (init_iterator): Don't initialize it->bidi_p for strings
3512 here.
3513 (reseat_to_string): Initialize it->bidi_p for strings here.
3514 (next_element_from_string, next_element_from_c_string)
3515 (next_element_from_buffer): Add xassert's for correspondence
3516 between IT's object being iterated and it->bidi_it.string
3517 structure.
3518 (face_before_or_after_it_pos): Support bidi iteration.
3519 (next_element_from_c_string): Handle the case of the first string
3520 character that is not the first one in the visual order.
3521 (get_visually_first_element): New function, refactored from common
3522 parts of next_element_from_buffer, next_element_from_string, and
3523 next_element_from_c_string.
3524 (tool_bar_lines_needed, redisplay_tool_bar)
3525 (display_menu_bar): Force left-to-right direction. Add a FIXME
3526 comment for making that be controlled by a user option.
3527 (push_it, pop_it): Save and restore the state of the
3528 bidi iterator. Save and restore the bidi_p flag.
3529 (pop_it): Iterate out of display property for string iteration as
3530 well.
3531 (iterate_out_of_display_property): Support iteration over strings.
3532 (handle_single_display_spec): Set up it->bidi_it for iteration
3533 over a display string, and call bidi_init_it.
3534 (handle_single_display_spec, next_overlay_string)
3535 (get_overlay_strings_1, push_display_prop): Set up the bidi
3536 iterator for displaying display or overlay strings.
3537 (forward_to_next_line_start): Don't use the shortcut if
3538 bidi-iterating.
3539 (back_to_previous_visible_line_start): If handle_display_prop
3540 pushed the iterator stack, restore the internal state of the bidi
3541 iterator by calling bidi_pop_it same number of times.
3542 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3543 and we are bidi-iterating, don't decrement the iterator position;
3544 instead, set the first_elt flag in the bidi iterator, to produce
3545 the same effect.
3546 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3547 (push_display_prop): xassert that we are iterating a buffer.
3548 (push_it, pop_it): Save and restore paragraph_embedding member.
3549 (handle_single_display_spec, next_overlay_string)
3550 (get_overlay_strings_1, reseat_1, reseat_to_string)
3551 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3552 correctly. Don't assume unibyte strings are not bidi-reordered.
3553 (compute_display_string_pos)
3554 (compute_display_string_end): Fix handling the case of C string.
3555 (push_it, pop_it): Save and restore from_disp_prop_p.
3556 (handle_single_display_spec, push_display_prop): Set the
3557 from_disp_prop_p flag.
3558 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3559 (pop_it): Call iterate_out_of_display_property only if we are
3560 popping after iteration over a string that came from a display
3561 property. Fix a typo in popping stretch info. Add an assertion
3562 for verifying that the iterator position is in sync with the bidi
3563 iterator.
3564 (handle_single_display_spec, get_overlay_strings_1)
3565 (push_display_prop): Fix initialization of paragraph direction for
3566 string when that of the parent object is not yet determined.
3567 (reseat_1): Call bidi_init_it to resync the bidi
3568 iterator with IT's position. (Bug#7616)
3569 (find_row_edges): If ROW->start.pos gives position
3570 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3571 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3572 Reset the from_disp_prop_p flag.
3573 (SAVE_IT, RESTORE_IT): New macros.
3574 (pos_visible_p, face_before_or_after_it_pos)
3575 (back_to_previous_visible_line_start)
3576 (move_it_in_display_line_to, move_it_in_display_line)
3577 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3578 (try_scrolling, redisplay_window, display_line): Use them when
3579 saving a temporary copy of the iterator and restoring it back.
3580 (back_to_previous_visible_line_start, reseat_1)
3581 (init_iterator): Empty the bidi cache "stack".
3582 (move_it_in_display_line_to): If iterator ended up at
3583 EOL, but we never saw any buffer positions smaller than
3584 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3585 motion in bidi-reordered lines.
3586 (move_it_in_display_line_to): Record prev_method and prev_pos
3587 immediately before the call to set_iterator_to_next. Fixes cursor
3588 motion in bidi-reordered lines with stretch glyphs and strings
3589 displayed in margins. (Bug#8133) (Bug#8867)
3590 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3591 TO_CHARPOS.
3592 (pos_visible_p): Support positions in bidi-reordered lines.
3593 Save and restore bidi cache.
3594
3595 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3596 (bidi_paragraph_info): Delete unused struct.
3597 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3598 (bidi_cache_start): New variable.
3599 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3600 to zero.
3601 (bidi_cache_fetch_state, bidi_cache_search)
3602 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3603 (bidi_cache_find, bidi_peek_at_next_level)
3604 (bidi_level_of_next_char, bidi_find_other_level_edge)
3605 (bidi_move_to_visually_next): Compare cache index with
3606 bidi_cache_start rather than with zero.
3607 (bidi_fetch_char): Accept new argument STRING; all callers
3608 changed. Support iteration over a string. Support strings with
3609 display properties. Support unibyte strings. Fix the type of
3610 `len' according to what STRING_CHAR_AND_LENGTH expects.
3611 (bidi_paragraph_init, bidi_resolve_explicit_1)
3612 (bidi_resolve_explicit, bidi_resolve_weak)
3613 (bidi_level_of_next_char, bidi_move_to_visually_next):
3614 Support iteration over a string.
3615 (bidi_set_sor_type, bidi_resolve_explicit_1)
3616 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3617 can now be zero (for strings); special values 0 and -1 were
3618 changed to -1 and -2, respectively.
3619 (bidi_char_at_pos): New function.
3620 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3621 Call it instead of FETCH_MULTIBYTE_CHAR.
3622 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3623 initialized to valid values.
3624 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3625 values.
3626 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3627 the test for valid cached positions. Fix the logic for looking up
3628 the sentinel state in the cache. GCPRO the Lisp string we are
3629 iterating.
3630 (bidi_push_it, bidi_pop_it): New functions.
3631 (bidi_initialize): Initialize the bidi cache start stack pointer.
3632 (bidi_cache_ensure_space): New function, refactored from part of
3633 bidi_cache_iterator_state. Don't assume the required size is just
3634 one BIDI_CACHE_CHUNK away.
3635 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3636 (bidi_count_bytes, bidi_char_at_pos): New functions.
3637 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3638 always valid if bidi_cache_idx is valid.
3639 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3640 is valid if it's going to be used.
3641 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3642 (bidi_cache_fetch_state, bidi_cache_search)
3643 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3644 (bidi_cache_iterator_state, bidi_cache_find)
3645 (bidi_find_other_level_edge, bidi_cache_start_stack):
3646 All variables related to cache indices are now EMACS_INT.
3647
3648 * dispextern.h (struct bidi_string_data): New structure.
3649 (struct bidi_it): New member `string'. Make flag members be 1-bit
3650 fields, and put them last in the struct.
3651 (compute_display_string_pos, compute_display_string_end):
3652 Update prototypes.
3653 (bidi_push_it, bidi_pop_it): Add prototypes.
3654 (struct iterator_stack_entry): New members bidi_p,
3655 paragraph_embedding, and from_disp_prop_p.
3656 (struct it): Member bidi_p is now a bit field 1 bit wide.
3657 (bidi_shelve_cache, bidi_unshelve_cache):
3658 Declare prototypes.
3659
3660 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3661 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3662 and vector-like objects.
3663
3664 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3665 cache around display iteration.
3666
3667 * window.c (Fwindow_end, window_scroll_pixel_based)
3668 (displayed_window_lines, Frecenter): Save and restore the bidi
3669 cache around display iteration.
3670
3671 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3672
3673 * editfns.c (Fdelete_region): Clarify the use of the named
3674 parameters (bug#6788).
3675
3676 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3677
3678 * indent.c (Fvertical_motion): Set and restore w->pointm when
3679 saving and restoring the window's buffer (Bug#9006).
3680
3681 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
3683 * editfns.c (Fstring_to_char): Clarify just what is returned
3684 (bug#6576). Text by Eli Zaretskii.
3685
3686 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3689
3690 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3691
3692 * buffer.c (mmap_find): Fix a typo.
3693
3694 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3695
3696 Fix execution of x selection hooks.
3697 * xselect.c (Qx_lost_selection_functions)
3698 (Qx_sent_selection_functions): New vars.
3699 (syms_of_xselect): DEFSYM them.
3700 (x_handle_selection_request): Pass Qx_sent_selection_functions
3701 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3702 (x_handle_selection_clear,x_clear_frame_selections):
3703 Pass Qx_lost_selection_functions rather than
3704 Vx_lost_selection_functions to Frun_hook_with_args.
3705
3706 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3709 The old code sometimes used this field without initializing it.
3710
3711 * alloc.c (gc_sweep): Don't read past end of array.
3712 In theory, the old code could also have corrupted Emacs internals,
3713 though it'd be very unlikely.
3714
3715 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * character.c (Fcharacterp): Don't advertise optional ignored
3718 argument. (Bug#4026)
3719
3720 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3721
3722 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3723 key" (bug#4257).
3724
3725 * window.c (Fset_window_start): Doc fix (bug#4199).
3726 (Fset_window_hscroll): Ditto.
3727
3728 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 Fix minor new problems caught by GCC 4.6.1.
3731 * term.c (init_tty): Remove unused local.
3732 * xsettings.c (store_monospaced_changed): Define this function only
3733 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3734 not used otherwise.
3735
3736 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3739
3740 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3741
3742 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3743 are the mini-buffer and the echo area (bug#3320).
3744
3745 * term.c (init_tty): Remove support for supdup, c10 and perq
3746 terminals, which are no longer supported (bug#1482).
3747
3748 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3749
3750 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3751
3752 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3753
3754 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3755 for non-popups (Bug#3642).
3756
3757 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3758
3759 * alloc.c (reset_malloc_hooks): Protoize.
3760 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3761 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3762 * cm.c (losecursor): Likewise.
3763 * data.c (fmod): Likewise.
3764 * dispnew.c (swap_glyphs_in_rows): Likewise.
3765 * emacs.c (memory_warning_signal): Likewise.
3766 * floatfns.c (float_error): Likewise.
3767 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3768 (otf_open, font_otf_capability, generate_otf_features)
3769 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3770 Likewise.
3771 * image.c (pbm_read_file): Likewise.
3772 * indent.c (string_display_width): Likewise.
3773 * intervals.c (check_for_interval, search_for_interval)
3774 (inc_interval_count, count_intervals, root_interval)
3775 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3776 * lread.c (defalias): Likewise.
3777 * ralloc.c (r_alloc_check): Likewise.
3778 * regex.c (set_image_of_range_1, set_image_of_range)
3779 (regex_grow_registers): Likewise.
3780 * sysdep.c (strerror): Likewise.
3781 * termcap.c (valid_filename_p, tprint, main): Likewise.
3782 * tparam.c (main): Likewise.
3783 * unexhp9k800.c (run_time_remap, save_data_space)
3784 (update_file_ptrs, read_header, write_header, calculate_checksum)
3785 (copy_file, copy_rest, display_header): Likewise.
3786 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3787 Likewise.
3788 * xdisp.c (check_it): Likewise.
3789 * xfaces.c (register_color, unregister_color, unregister_colors):
3790 Likewise.
3791 * xfns.c (print_fontset_result): Likewise.
3792 * xrdb.c (member, fatal, main): Likewise.
3793
3794 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 Fix minor problems found by static checking (Bug#9031).
3797 * chartab.c (char_table_set_range, map_sub_char_table):
3798 Remove unused locals.
3799 (uniprop_table): Now static.
3800 * composite.c (_work_char): Remove unused static var.
3801
3802 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3803
3804 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3805
3806 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3807
3808 * gtkutil.c (qttip_cb): Remove code without function.
3809
3810 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3811
3812 * w32.c (pthread_sigmask): New stub.
3813
3814 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 Use pthread_sigmask, not sigprocmask (Bug#9010).
3817 sigprocmask is portable only for single-threaded applications, and
3818 Emacs can be multi-threaded when it uses GTK.
3819 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3820 (LIBES): Use it.
3821 * callproc.c (Fcall_process):
3822 * process.c (create_process):
3823 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3824 Use pthread_sigmask, not sigprocmask.
3825
3826 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3827
3828 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3829 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3830 wrong (Bug#8591).
3831
3832 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3833
3834 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3835 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3836 (xg_hide_tooltip): Fix comment.
3837
3838 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3839 in registerServicesMenuSendTypes.
3840 (validRequestorForSendType): Don't check ns_return_types.
3841
3842 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3843 ns_return_type.
3844
3845 2011-07-08 Jason Rumney <jasonr@gnu.org>
3846
3847 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3848 SH_SHOW for hidden windows (Bug#5482).
3849
3850 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3851 frame struct members of non-existent frames (Bug#6284).
3852
3853 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3854
3855 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3856 variable firstTime not needed on OSX >= 10.6.
3857 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3858 >= 10.5. Use setKnobProportion, setDoubleValue.
3859
3860 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3861 (MAC_OS_X_VERSION_10_5): Define if not defined.
3862 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3863 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3864 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3865
3866 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3867 cString and lossyCString on OSX >= 10.4
3868
3869 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3870 sizeToFit on OSX >= 10.2.
3871
3872 * nsimage.m (allocInitFromFile): Don't use deprecated method
3873 bestRepresentationForDevice on OSX >= 10.6.
3874
3875 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3876 to avoid warning.
3877
3878 * emacs.c: Declare unexec_init_emacs_zone.
3879
3880 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3881
3882 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3883
3884 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3885 on svcsMenu (Bug#8842).
3886
3887 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3888 ns_return_types.
3889 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3890
3891 * nsterm.m (QUTF8_STRING): Declare.
3892 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3893 (validRequestorForSendType): Return type is (id).
3894 Change indexOfObjectIdenticalTo to indexOfObject.
3895 Check if we have local selection before returning self (Bug#8842).
3896 (writeSelectionToPasteboard): Put local selection into paste board
3897 if we have a local selection (Bug#8842).
3898 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3899
3900 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3901 (ns_get_local_selection): Declare.
3902
3903 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3904
3905 * keymap.c (describe_map_tree): Don't insert a double newline at
3906 the end of the buffer (bug#1169) and return whether we inserted
3907 something.
3908
3909 * callint.c (Fcall_interactively): Change "reading args" to
3910 "providing args" to try to clarify what it does (bug#1010).
3911
3912 2011-07-07 Kenichi Handa <handa@m17n.org>
3913
3914 * composite.c (composition_compute_stop_pos): Ignore a static
3915 composition starting before CHARPOS (Bug#8915).
3916
3917 * xdisp.c (handle_composition_prop): Likewise.
3918
3919 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3920
3921 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3922 (Bug#9015)
3923
3924 2011-07-07 Kenichi Handa <handa@m17n.org>
3925
3926 * character.h (unicode_category_t): New enum type.
3927
3928 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3929 (Qchar_code_property_table): New variable.
3930 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3931 (UNIPROP_COMPRESSED_FORM_P): New macros.
3932 (char_table_ascii): Uncompress the compressed values.
3933 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3934 Uncompress the compressed values.
3935 (sub_char_table_ref_and_range): Likewise.
3936 (char_table_ref_and_range): Uncompress the compressed values.
3937 (sub_char_table_set): New arg is_uniprop. Callers changed.
3938 Uncompress the compressed values.
3939 (sub_char_table_set_range): Args changed. Callers changed.
3940 (char_table_set_range): Adjuted for the above change.
3941 (map_sub_char_table): Delete args default_val and parent. Add arg
3942 top. Give decoded values to a Lisp function.
3943 (map_char_table): Adjust for the above change. Give decoded
3944 values to a Lisp function. Gcpro more variables.
3945 (uniprop_table_uncompress)
3946 (uniprop_decode_value_run_length): New functions.
3947 (uniprop_decoder, uniprop_decoder_count): New variables.
3948 (uniprop_get_decoder, uniprop_encode_value_character)
3949 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3950 New functions.
3951 (uniprop_encoder, uniprop_encoder_count): New variables.
3952 (uniprop_get_encoder, uniprop_table)
3953 (Funicode_property_table_internal, Fget_unicode_property_internal)
3954 (Fput_unicode_property_internal): New functions.
3955 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3956 Sunicode_property_table_internal, Sget_unicode_property_internal,
3957 and Sput_unicode_property_internal. Defvar_lisp
3958 char-code-property-alist.
3959
3960 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3961 Vunicode_category_table.
3962
3963 * font.c (font_range): Adjust for the change of
3964 Vunicode_category_table.
3965
3966 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3967
3968 * m/iris4d.h: Remove file, move contents ...
3969 * s/irix6-5.h: ... here.
3970
3971 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 Remove unportable assumption about struct layout (Bug#8884).
3974 * alloc.c (mark_buffer):
3975 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3976 (clone_per_buffer_values): Don't assume that
3977 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3978 This isn't true in general, and it's particularly not true
3979 if Emacs is configured with --with-wide-int.
3980 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3981 New macros, used in the buffer.c change.
3982
3983 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3984
3985 * xsettings.c: Use both GConf and GSettings if both are available.
3986 (store_config_changed_event): Add comment.
3987 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3988 (store_tool_bar_style_changed): New functions.
3989 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3990 (struct xsettings): Move font inside HAVE_XFT.
3991 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3992 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3993 Move inside HAVE_XFT.
3994 (something_changed_gsettingsCB): Rename from something_changedCB.
3995 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3996 also.
3997 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3998 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3999 (something_changed_gconfCB): Rename from something_changedCB.
4000 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4001 (parse_settings): Move check for font inside HAVE_XFT.
4002 (read_settings, apply_xft_settings): Add comment.
4003 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4004 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4005 call store_font_name_changed.
4006 (xft_settings_event): Add comment.
4007 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4008 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4009 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4010 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4011 (xsettings_initialize): Call init_gsettings last.
4012 (xsettings_get_system_font, xsettings_get_system_normal_font):
4013 Add comment.
4014
4015 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 Random fixes. E.g., (random) never returned negative values.
4018 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4019 subseconds part to the entropy, as that's a bit more random.
4020 Prefer signed to unsigned, since the signedness doesn't matter and
4021 in general we prefer signed. When given a limit, use a
4022 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4023 latter isn't right if USE_2_TAGS_FOR_INTS.
4024 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4025 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4026
4027 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 * textprop.c (text_property_stickiness):
4030 Obey Vtext_property_default_nonsticky.
4031 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4032 * w32fns.c (syms_of_w32fns):
4033 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4034
4035 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4038 This is more efficient than Ffile_directory_p and avoids a minor race.
4039
4040 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4041
4042 * buffer.c (Foverlay_put): Say what the return value is
4043 (bug#7835).
4044
4045 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4046 is a directory before asking whether to use the file name
4047 (bug#7564).
4048 (barf_or_query_if_file_exists): Make the "File is a directory"
4049 error be more correct.
4050
4051 * fns.c (Frequire): Remove the mention of the .gz files, since
4052 that's installation-specific, but keep the mention of
4053 `get-load-suffixes'.
4054
4055 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4058 Report string overflow if the output is too long.
4059
4060 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4061
4062 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4063 (syms_of_gnutls): Remove duplicate DEFSYM for
4064 Qgnutls_bootprop_verify_hostname_error, an error for
4065 Qgnutls_bootprop_verify_error (which is no longer used).
4066
4067 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4068 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4069 Also (re)move comments that are misplaced or no longer relevant.
4070
4071 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4072
4073 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4074
4075 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4078 and background color parameters if they have been changed.
4079
4080 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4081
4082 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4083
4084 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4085
4086 * xsettings.c (SYSTEM_FONT): Define only when used.
4087 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4088
4089 * keymap.c (access_keymap_1): Now static.
4090
4091 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4092
4093 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4094 leave any prefix arg for the up event (Bug#1586).
4095
4096 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4097
4098 * lread.c (syms_of_lread): Mention single symbols defined by
4099 `defvar' or `defconst' (bug#7154).
4100
4101 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4102 (Frequire): Mention get-load-suffixes.
4103
4104 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4105
4106 * window.h (window): Remove clone_number slot.
4107 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4108 Remove.
4109 (make_parent_window, make_window, saved_window)
4110 (Fset_window_configuration, save_window_save): Don't deal with
4111 clone numbers.
4112 * buffer.c (Qclone_number): Remove declaration.
4113 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4114
4115 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4116
4117 Add multiple inheritance to keymaps.
4118 * keymap.c (Fmake_composed_keymap): New function.
4119 (Fset_keymap_parent): Simplify.
4120 (fix_submap_inheritance): Remove.
4121 (access_keymap_1): New function extracted from access_keymap to handle
4122 embedded parents and handle lists of maps.
4123 (access_keymap): Use it.
4124 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4125 (Fcopy_keymap): Handle embedded parents.
4126 (Fcommand_remapping, define_as_prefix): Simplify.
4127 (Fkey_binding): Simplify.
4128 (syms_of_keymap): Move minibuffer-local-completion-map,
4129 minibuffer-local-filename-completion-map,
4130 minibuffer-local-must-match-map, and
4131 minibuffer-local-filename-must-match-map to Elisp.
4132 (syms_of_keymap): Defsubr make-composed-keymap.
4133 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4134 (parse_menu_item): Trivial simplification.
4135
4136 2011-07-01 Glenn Morris <rgm@gnu.org>
4137
4138 * Makefile.in (SETTINGS_LIBS): Fix typo.
4139
4140 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4141
4142 * coding.c (Fencode_coding_string): Record the last coding system
4143 used, as the function doc string says (bug#8738).
4144
4145 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4146
4147 * xsettings.c (store_monospaced_changed): Take new font as arg and
4148 check for change against current_mono_font.
4149 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4150 (emacs_settings_constructor, emacs_settings_get_property)
4151 (emacs_settings_set_property, emacs_settings_class_init)
4152 (emacs_settings_init, gsettings_obj): Remove.
4153 (something_changedCB): New function for HAVE_GSETTINGS.
4154 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4155 with value as argument.
4156 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4157 g_settings_new (Bug#8967). Do not create gsettings_obj.
4158 Remove calls to g_settings_bind. Connect something_changedCB to
4159 "changed".
4160
4161 * xgselect.c: Add defined (HAVE_GSETTINGS).
4162 (xgselect_initialize): Ditto.
4163
4164 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4165 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4166 xg_select.
4167
4168 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 * eval.c (struct backtrace): Simplify and port the data structure.
4171 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4172 signed bit field, as this assumption is not portable and it makes
4173 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4174 "char debug_on_exit : 1" as this is not portable either; instead,
4175 use the portable "unsigned int debug_on_exit : 1". Remove unused
4176 member evalargs. Remove obsolete comments about cc bombing out.
4177
4178 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4179
4180 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4181 Let HAVE_GSETTINGS override HAVE_GCONF.
4182 (store_monospaced_changed): New function.
4183 (EMACS_SETTINGS): A new type derived from GObject to handle
4184 GSettings notifications.
4185 (emacs_settings_constructor, emacs_settings_get_property)
4186 (emacs_settings_set_property, emacs_settings_class_init):
4187 New functions.
4188 (gsettings_client, gsettings_obj): New variables.
4189 (GSETTINGS_SCHEMA): New define.
4190 (something_changedCB): Call store_monospaced_changed.
4191 (init_gsettings): New function.
4192 (xsettings_initialize): Call init_gsettings.
4193 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4194 to NULL.
4195
4196 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4197 GCONF_CFLAGS/LIBS.
4198
4199 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4200
4201 * window.c (resize_root_window, grow_mini_window)
4202 (shrink_mini_window): Rename Qresize_root_window to
4203 Qwindow_resize_root_window and Qresize_root_window_vertically to
4204 Qwindow_resize_root_window_vertically.
4205
4206 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4207
4208 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4209
4210 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4211
4212 * makefile.w32-in: Redesign dependencies so they reflect more
4213 clearly which files are directly included by each source file,
4214 and not through other includes.
4215
4216 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4217
4218 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4219 (sort_overlays, overlay_strings): When an overlay's clone number
4220 matches the window's clone number process the overlay even if
4221 the overlay's window property doesn't match the current window.
4222
4223 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4224 (Fwindow_hchild): Rename to Fwindow_left_child.
4225 (Fwindow_next): Rename to Fwindow_next_sibling.
4226 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4227 (resize_window_check): Rename to window_resize_check.
4228 (resize_window_apply): Rename to window_resize_apply.
4229 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4230 (Fdelete_other_windows_internal, resize_frame_windows)
4231 (Fsplit_window_internal, Fdelete_window_internal)
4232 (grow_mini_window, shrink_mini_window)
4233 (Fresize_mini_window_internal): Fix callers accordingly.
4234
4235 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4236
4237 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4238 (emacs_fixed_set_min_size): Remove.
4239 (emacs_fixed_new): Take frame as argument.
4240
4241 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4242 (_EmacsFixedPrivate): Remove minwidth/height.
4243 Add struct frame *f.
4244 (emacs_fixed_init): Initialize priv->f.
4245 (get_parent_class, emacs_fixed_set_min_size): Remove.
4246 (emacs_fixed_new): Set priv->f to argument.
4247 (emacs_fixed_get_preferred_width)
4248 (emacs_fixed_get_preferred_height): Use min_width/height from
4249 frames size_hint to set minimum and natural (Bug#8919).
4250 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4251 and use min_width/height from frames size_hint to set
4252 min_width/height (Bug#8919).
4253
4254 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4255 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4256 Fix indentation.
4257
4258 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4259
4260 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4261 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4262 called at ZV.
4263
4264 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * process.c (wait_reading_process_output): Bypass select if
4267 waiting for a cell while ignoring keyboard input, and input is
4268 pending. Suggested by Jan Djärv (Bug#8869).
4269
4270 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 Use gnulib's dup2 module instead of rolling our own.
4273 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4274
4275 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4276
4277 * dispnew.c (scrolling_window): Before scrolling, turn off a
4278 mouse-highlight in the window being scrolled.
4279
4280 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4281
4282 Move DEFSYM to lisp.h and use everywhere.
4283
4284 * character.h (DEFSYM): Move declaration...
4285 * lisp.h (DEFSYM): ...here.
4286
4287 * gnutls.c:
4288 * minibuf.c:
4289 * w32menu.c:
4290 * w32proc.c:
4291 * w32select.c: Don't include character.h.
4292
4293 * alloc.c (syms_of_alloc):
4294 * buffer.c (syms_of_buffer):
4295 * bytecode.c (syms_of_bytecode):
4296 * callint.c (syms_of_callint):
4297 * casefiddle.c (syms_of_casefiddle):
4298 * casetab.c (init_casetab_once):
4299 * category.c (init_category_once, syms_of_category):
4300 * ccl.c (syms_of_ccl):
4301 * cmds.c (syms_of_cmds):
4302 * composite.c (syms_of_composite):
4303 * dbusbind.c (syms_of_dbusbind):
4304 * dired.c (syms_of_dired):
4305 * dispnew.c (syms_of_display):
4306 * doc.c (syms_of_doc):
4307 * editfns.c (syms_of_editfns):
4308 * emacs.c (syms_of_emacs):
4309 * eval.c (syms_of_eval):
4310 * fileio.c (syms_of_fileio):
4311 * fns.c (syms_of_fns):
4312 * frame.c (syms_of_frame):
4313 * fringe.c (syms_of_fringe):
4314 * insdel.c (syms_of_insdel):
4315 * keymap.c (syms_of_keymap):
4316 * lread.c (init_obarray, syms_of_lread):
4317 * macros.c (syms_of_macros):
4318 * msdos.c (syms_of_msdos):
4319 * print.c (syms_of_print):
4320 * process.c (syms_of_process):
4321 * search.c (syms_of_search):
4322 * sound.c (syms_of_sound):
4323 * syntax.c (init_syntax_once, syms_of_syntax):
4324 * terminal.c (syms_of_terminal):
4325 * textprop.c (syms_of_textprop):
4326 * undo.c (syms_of_undo):
4327 * w32.c (globals_of_w32):
4328 * window.c (syms_of_window):
4329 * xdisp.c (syms_of_xdisp):
4330 * xfaces.c (syms_of_xfaces):
4331 * xfns.c (syms_of_xfns):
4332 * xmenu.c (syms_of_xmenu):
4333 * xsettings.c (syms_of_xsettings):
4334 * xterm.c (syms_of_xterm): Use DEFSYM.
4335
4336 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4337
4338 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4339
4340 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 Integer and buffer overflow fixes (Bug#8873).
4343
4344 * print.c (printchar, strout): Check for string overflow.
4345 (PRINTPREPARE, printchar, strout):
4346 Don't set size unless allocation succeeds.
4347
4348 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4349 for sizes. Check for string overflow more accurately.
4350 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4351
4352 * macros.c: Integer and buffer overflow fixes.
4353 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4354 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4355 Use ptrdiff_t, not int, for sizes.
4356 Don't increment bufsize until after realloc succeeds.
4357 Check for size-calculation overflow.
4358 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4359
4360 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4361
4362 * lread.c: Integer overflow fixes.
4363 (read_integer): Radix is now EMACS_INT, not int,
4364 to improve quality of diagnostics for out-of-range radices.
4365 Calculate buffer size correctly for out-of-range radices.
4366 (read1): Check for integer overflow in radices, and in
4367 read-circle numbers.
4368 (read_escape): Avoid int overflow.
4369 (Fload, openp, read_buffer_size, read1)
4370 (substitute_object_recurse, read_vector, read_list, map_obarray):
4371 Use ptrdiff_t, not int, for sizes.
4372 (read1): Use EMACS_INT, not int, for sizes.
4373 Check for size overflow.
4374
4375 * image.c (cache_image): Check for size arithmetic overflow.
4376
4377 * lread.c: Integer overflow issues.
4378 (saved_doc_string_size, saved_doc_string_length)
4379 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4380 Now ptrdiff_t, not int.
4381 (read1): Don't assume doc string length fits in int. Check for
4382 out-of-range doc string lengths.
4383 (read_list): Don't assume file position fits in int.
4384 (read_escape): Check for hex character overflow.
4385
4386 2011-06-22 Leo Liu <sdl.web@gmail.com>
4387
4388 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4389 Move to minibuffer.el.
4390
4391 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4394 The following patches are for when GLYPH_DEBUG && !XASSERT.
4395 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4396 * dispnew.c (flush_stdout):
4397 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4398 Mark as externally visible.
4399 * dispnew.c (check_window_matrix_pointers): Now static.
4400 * dispnew.c (window_to_frame_vpos):
4401 * xfns.c (unwind_create_frame):
4402 * xterm.c (x_check_font): Remove unused local.
4403 * scroll.c (CHECK_BOUNDS):
4404 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4405 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4406 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4407 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4408 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4409 Now static.
4410 (debug_method_add): Use va_list and vsprintf rather than relying
4411 on undefined behavior with wrong number of arguments.
4412 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4413 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4414 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4415 since we're not interested in debugging glyphs with old libraries.
4416 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4417 GCC 4.6.0's static checking.
4418
4419 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 Integer overflow and signedness fixes (Bug#8873).
4422 A few related buffer overrun fixes, too.
4423
4424 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4425
4426 * dispextern.h (struct face.stipple):
4427 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4428 (x_bitmap_mask, x_allocate_bitmap_record)
4429 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4430 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4431 (x_create_bitmap_from_xpm_data):
4432 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4433 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4434 (.bitmaps_last):
4435 * xfaces.c (load_pixmap):
4436 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4437 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4438 (.bitmaps_last, struct x_output.icon_bitmap):
4439 Use ptrdiff_t, not int, for bitmap indexes.
4440 (x_allocate_bitmap_record): Check for size overflow.
4441 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4442
4443 Use ptrdiff_t, not int, for overlay counts.
4444 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4445 * editfns.c (overlays_around, get_pos_property):
4446 * textprop.c (get_char_property_and_overlay):
4447 * xdisp.c (next_overlay_change, note_mouse_highlight):
4448 * xfaces.c (face_at_buffer_position):
4449 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4450 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4451 (Fnext_overlay_change, Fprevious_overlay_change)
4452 (mouse_face_overlay_overlaps, Foverlays_in):
4453 Use ptrdiff_t, not int, for sizes.
4454 (overlays_at, overlays_in): Check for size-calculation overflow.
4455
4456 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4457
4458 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4459 (x_session_initialize): Do not assume string length fits in int.
4460
4461 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4462 This is unlikely, but can occur if DPI is outlandish.
4463
4464 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4465 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4466
4467 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4468 * xrdb.c (magic_file_p, search_magic_path):
4469 Omit last arg SUFFIX; it was always 0. All callers changed.
4470 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4471
4472 * xfont.c (xfont_match): Avoid need for strlen.
4473
4474 * xfns.c: Don't assume strlen fits in int.
4475 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4476
4477 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4478 not unsigned long, as we prefer signed integers. All callers changed.
4479 Detect integer overflow in repeat count.
4480 (message_dolog): Don't assume print length fits in 39 bytes.
4481 (display_mode_element): Don't assume strlen fits in int.
4482
4483 * termcap.c: Don't assume sizes fit in int and never overflow.
4484 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4485 (gobble_line): Check for size-calculation overflow.
4486
4487 * minibuf.c (Fread_buffer):
4488 * lread.c (intern, intern_c_string):
4489 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4490 Don't assume string length fits in int.
4491
4492 * keyboard.c (parse_tool_bar_item):
4493 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4494
4495 * font.c: Don't assume string length fits in int.
4496 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4497 Use ptrdiff_t, not int.
4498 (font_intern_prop): Don't assume string length fits in int.
4499 Don't assume integer property fits in fixnum.
4500 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4501
4502 * filelock.c: Fix some buffer overrun and integer overflow issues.
4503 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4504 Reformulate so as not to need the command string.
4505 Invoke gzip -cd rather than gunzip, as it's more portable.
4506 (lock_info_type, lock_file_1, lock_file):
4507 Don't assume pid_t and time_t fit in unsigned long.
4508 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4509 (current_lock_owner): Prefer signed type for sizes.
4510 Use memcpy, not strncpy, where memcpy is what is really wanted.
4511 Don't assume (via atoi) that time_t and pid_t fit in int.
4512 Check for time_t and/or pid_t out of range, e.g., via a network share.
4513 Don't alloca where an auto var works fine.
4514
4515 * fileio.c: Fix some integer overflow issues.
4516 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4517 Don't assume string length fits in int.
4518 (directory_file_name): Don't assume string length fits in long.
4519 (make_temp_name): Don't assume pid fits in int, or that its print
4520 length is less than 20.
4521
4522 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4523
4524 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4525
4526 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4527
4528 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4529 We prefer signed integers, even for size calculations.
4530
4531 * emacs.c: Don't assume string length fits in 'int'.
4532 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4533 (main): Don't invoke strlen when not needed.
4534
4535 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4536 (XD_DEBUG_MESSAGE): Don't waste a byte.
4537
4538 * callproc.c (getenv_internal_1, getenv_internal)
4539 (Fgetenv_internal):
4540 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4541
4542 * lread.c (invalid_syntax): Omit length argument.
4543 All uses changed. This doesn't fix a bug, but it simplifies the
4544 code away from its former Hollerith-constant appearance, and it's
4545 one less 'int' to worry about when looking at integer-overflow issues.
4546 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4547
4548 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4549 This didn't break anything, but it didn't help either.
4550 It's confusing to put a bogus integer in a place where the actual
4551 value does not matter.
4552 (LIST_END_P): Remove unused macro and its bogus comment.
4553 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4554
4555 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4556 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4557 implementation.
4558 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4559 We prefer signed types, and the value cannot exceed the EMACS_INT
4560 range anyway (because otherwise the length would not be representable).
4561 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4562 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4563 This avoids a GCC warning when WIDE_EMACS_INT.
4564
4565 * indent.c (sane_tab_width): New function.
4566 (current_column, scan_for_column, Findent_to, position_indentation)
4567 (compute_motion): Use it. This is just for clarity.
4568 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4569
4570 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4571
4572 * lisp.h (lint_assume): New macro.
4573 * composite.c (composition_gstring_put_cache):
4574 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4575
4576 * editfns.c, insdel.c:
4577 Omit unnecessary forward decls, to simplify future changes.
4578
4579 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4580
4581 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4582
4583 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4584 Use much-faster test for byte-length change.
4585 Don't assume string byte-length fits in 'int'.
4586 Check that character arg fits in 'int'.
4587 (mapcar1): Declare byte as byte, for clarity.
4588
4589 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4590
4591 * fns.c (concat): Catch string overflow earlier.
4592 Do not rely on integer wraparound.
4593
4594 * dispextern.h (struct it.overlay_strings_charpos)
4595 (struct it.selective): Now EMACS_INT, not int.
4596 * xdisp.c (forward_to_next_line_start)
4597 (back_to_previous_visible_line_start)
4598 (reseat_at_next_visible_line_start, next_element_from_buffer):
4599 Don't arbitrarily truncate the value of 'selective' to int.
4600
4601 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4602
4603 * composite.c: Don't truncate sizes to 'int'.
4604 (composition_gstring_p, composition_reseat_it)
4605 (composition_adjust_point): Use EMACS_INT, not int.
4606 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4607 not EMACS_UINT, for indexes.
4608
4609 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4610
4611 * buffer.c: Include <verify.h>.
4612 (struct sortvec.priority, struct sortstr.priority):
4613 Now EMACS_INT, not int.
4614 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4615 (struct sortstr.size, record_overlay_string)
4616 (struct sortstrlist.size, struct sortlist.used):
4617 Don't truncate size to int.
4618 (record_overlay_string): Check for size-calculation overflow.
4619 (init_buffer_once): Check at compile-time, not run-time.
4620
4621 2011-06-22 Jim Meyering <meyering@redhat.com>
4622
4623 Don't leak an XBM-image-sized buffer
4624 * image.c (xbm_load): Free the image buffer after using it.
4625
4626 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 Port to Sun C.
4629 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4630 that Sun C diagnosed.
4631 * fns.c (secure_hash): Fix pointer signedness issue.
4632 * intervals.c (static_offset_intervals): New function.
4633 (offset_intervals): Use it.
4634
4635 2011-06-21 Leo Liu <sdl.web@gmail.com>
4636
4637 * deps.mk (fns.o):
4638 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4639 sha512.h.
4640
4641 * fns.c (secure_hash): Rename from crypto_hash_function and change
4642 the first arg to accept symbols.
4643 (Fsecure_hash): New primitive.
4644 (syms_of_fns): New symbols.
4645
4646 2011-06-20 Deniz Dogan <deniz@dogan.se>
4647
4648 * process.c (Fset_process_buffer): Clarify return value in
4649 docstring.
4650
4651 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4652
4653 * dispnew.c (add_window_display_history): Use BVAR.
4654
4655 * xdisp.c (debug_method_add): Use BVAR.
4656 (check_window_end, dump_glyph_matrix, dump_glyph)
4657 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4658
4659 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4660 Likewise.
4661
4662 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4663 check till after the cache is created in init_frame_faces.
4664
4665 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4666
4667 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4668
4669 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4672 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4673 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4674
4675 Improve buffer-overflow checking (Bug#8873).
4676 * fileio.c (Finsert_file_contents):
4677 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4678 Remove the old (too-loose) buffer overflow checks.
4679 They weren't needed, since make_gap checks for buffer overflow.
4680 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4681 The old code merely checked for Emacs fixnum overflow, and relied
4682 on undefined (wraparound) behavior. The new code avoids undefined
4683 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4684
4685 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4686 Tune. Don't use wider integers than needed. Don't use alloca.
4687 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4688
4689 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4690
4691 * insdel.c, lisp.h (buffer_overflow): New function.
4692 (insert_from_buffer_1, replace_range, replace_range_2):
4693 * insdel.c (make_gap_larger):
4694 * editfns.c (Finsert_char):
4695 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4696
4697 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4698
4699 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4700
4701 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4702
4703 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4704 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4705
4706 * fileio.c: Don't assume EMACS_INT fits in off_t.
4707 (emacs_lseek): New static function.
4708 (Finsert_file_contents, Fwrite_region): Use it.
4709 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4710
4711 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4712
4713 * fns.c: Don't overflow int when computing a list length.
4714 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4715 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4716 truncation on 64-bit hosts. Check for QUIT every
4717 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4718 faster and is responsive enough.
4719 (Flength): Report an error instead of overflowing an integer.
4720 (Fsafe_length): Return a float if the value is not representable
4721 as a fixnum. This shouldn't happen except in contrived situations.
4722 (Fnthcdr, Fsort): Don't assume list length fits in int.
4723 (Fcopy_sequence): Don't assume vector length fits in int.
4724
4725 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4726 (header_size, word_size): New constants.
4727 (allocate_vectorlike): Don't check size overflow here.
4728 (allocate_vector): Check it here instead, since this is the only
4729 caller of allocate_vectorlike that could cause overflow.
4730 Check that the new vector's length is representable as a fixnum.
4731
4732 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4733 The previous code was bogus. For example, next_almost_prime (32)
4734 returned 39, which is undesirable as it is a multiple of 3; and
4735 next_almost_prime (24) returned 25, which is a multiple of 5 so
4736 why was the code bothering to check for multiples of 7?
4737
4738 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4739
4740 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4741
4742 Variadic C functions now count arguments with ptrdiff_t.
4743 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4744 Back then I didn't know that the Emacs coding style prefers signed int.
4745 Also, in the meantime I found a few more instances where arguments
4746 were being counted with int, which may truncate counts on 64-bit
4747 machines, or EMACS_INT, which may be unnecessarily wide.
4748 * lisp.h (struct Lisp_Subr.function.aMANY)
4749 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4750 Arg counts are now ptrdiff_t, not size_t.
4751 All variadic functions and their callers changed accordingly.
4752 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4753 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4754 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4755 * callint.c (Fcall_interactively): Check arg count for overflow,
4756 to avoid potential buffer overrun. Use signed char, not 'int',
4757 for 'varies' array, so that we needn't bother to check its size
4758 calculation for overflow.
4759 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4760 * eval.c (apply_lambda):
4761 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4762 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4763 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4764
4765 * callint.c (Fcall_interactively): Don't use index var as event count.
4766
4767 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4768 * mem-limits.h (SIZE): Remove; no longer used.
4769
4770 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4771
4772 Remove unnecessary casts.
4773 * xterm.c (x_term_init):
4774 * xfns.c (x_set_border_pixel):
4775 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4776 These aren't needed now that we assume ANSI C.
4777
4778 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4779 It's more likely to cause problems (due to unsigned overflow)
4780 than to cure them.
4781
4782 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4783
4784 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4785
4786 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4787
4788 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4789
4790 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4791
4792 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4793
4794 GLYPH_CODE_FACE returns EMACS_INT, not int.
4795 * dispextern.h (merge_faces):
4796 * xfaces.c (merge_faces):
4797 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4798 Don't assume EMACS_INT fits in int.
4799
4800 * character.h (CHAR_VALID_P): Remove unused parameter.
4801 * fontset.c, lisp.h, xdisp.c: All uses changed.
4802
4803 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4804
4805 * fns.c (concat): Minor tuning based on overflow analysis.
4806 This doesn't fix any bugs. Use int to hold character, instead
4807 of constantly refetching from Emacs object. Use XFASTINT, not
4808 XINT, for value known to be a character. Don't bother comparing
4809 a single byte to 0400, as it's always less.
4810
4811 * floatfns.c (Fexpt):
4812 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4813
4814 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4815 for characters.
4816
4817 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4818
4819 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4820 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4821 incorrectly succeed when S was a string, because 4294967386 was
4822 truncated before it was used.
4823
4824 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4825 Otherwise, an out-of-range integer could cause undefined behavior
4826 on a 64-bit host.
4827
4828 * composite.c: Use int, not EMACS_INT, for characters.
4829 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4830 EMACS_INT, for values that are known to be in character range.
4831 This doesn't fix any bugs but is the usual style inside Emacs and
4832 may generate better code on 32-bit machines.
4833
4834 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4835 This is for reasons similar to the recent CHAR_STRING fix.
4836 * charset.c (Fencode_char): Check that character arg is actually
4837 a character. Pass an int to ENCODE_CHAR.
4838 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4839 wider than 'int', as a compile-time check to prevent future regressions
4840 in this area.
4841
4842 * character.c (char_string): Remove unnecessary casts.
4843
4844 Make sure a 64-bit char is never passed to CHAR_STRING.
4845 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4846 by silently ignoring the top 32 bits, allowing some values
4847 that were far too large to be valid characters.
4848 * character.h: Include <verify.h>.
4849 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4850 arguments are no wider than unsigned, as a compile-time check
4851 to prevent future regressions in this area.
4852 * data.c (Faset):
4853 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4854 (Fsubst_char_in_region):
4855 * fns.c (concat):
4856 * xdisp.c (decode_mode_spec_coding):
4857 Adjust to CHAR_STRING's new requirement.
4858 * editfns.c (Finsert_char, Fsubst_char_in_region):
4859 * fns.c (concat): Check that character args are actually
4860 characters. Without this test, these functions did the wrong
4861 thing with wildly out-of-range values on 64-bit hosts.
4862
4863 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4864 These casts should not be needed on 32-bit hosts, either.
4865 * keyboard.c (read_char):
4866 * lread.c (Fload): Remove casts to unsigned.
4867
4868 * lisp.h (UNSIGNED_CMP): New macro.
4869 This fixes comparison bugs on 64-bit hosts.
4870 (ASCII_CHAR_P): Use it.
4871 * casefiddle.c (casify_object):
4872 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4873 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4874 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4875 * dispextern.h (FACE_FROM_ID):
4876 * keyboard.c (read_char): Use UNSIGNED_CMP.
4877
4878 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4879 not to EMACS_INT, to avoid GCC warning.
4880
4881 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4882
4883 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4884 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4885 isn't needed on 32-bit machines.
4886
4887 * buffer.c (Fgenerate_new_buffer_name):
4888 Use EMACS_INT for count, not int.
4889 (advance_to_char_boundary): Return EMACS_INT, not int.
4890
4891 * data.c (Qcompiled_function): Now static.
4892
4893 * window.c (window_body_lines): Now static.
4894
4895 * image.c (gif_load): Rename local to avoid shadowing.
4896
4897 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4898 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4899 * alloc.c (make_save_value): Integer argument is now of type
4900 ptrdiff_t, not int.
4901 (mark_object): Use ptrdiff_t, not int.
4902 * lisp.h (pD): New macro.
4903 * print.c (print_object): Use it.
4904
4905 * alloc.c: Use EMACS_INT, not int, to count objects.
4906 (total_conses, total_markers, total_symbols, total_vector_size)
4907 (total_free_conses, total_free_markers, total_free_symbols)
4908 (total_free_floats, total_floats, total_free_intervals)
4909 (total_intervals, total_strings, total_free_strings):
4910 Now EMACS_INT, not int. All uses changed.
4911 (Fgarbage_collect): Compute overall total using a double, so that
4912 integer overflow is less likely to be a problem. Check for overflow
4913 when converting back to an integer.
4914 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4915 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4916 These were 'int' variables that could overflow on 64-bit hosts;
4917 they were never used, so remove them instead of repairing them.
4918 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4919 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4920 Previously, this ceilinged at INT_MAX, but that doesn't work on
4921 64-bit machines.
4922 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4923
4924 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4925 (allocate_vectorlike): Check for ptrdiff_t overflow.
4926 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4927 when a (possibly-narrower) signed value would do just as well.
4928 We prefer using signed arithmetic, to avoid comparison confusion.
4929
4930 * alloc.c: Catch some string size overflows that we were missing.
4931 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4932 for convenience in STRING_BYTES_MAX.
4933 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4934 The definition here is exact; the one in lisp.h was approximate.
4935 (allocate_string_data): Check for string overflow. This catches
4936 some instances we weren't catching before. Also, it catches
4937 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4938 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4939 and ptrdiff_t and EMACS_INT are both 64 bits.
4940
4941 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4942 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4943 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4944
4945 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4946
4947 * alloc.c (Fmake_string): Check for out-of-range init.
4948
4949 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4950
4951 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4952
4953 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4954
4955 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4956 xg_get_default_scrollbar_width.
4957
4958 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4959 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4960 (style_changed_cb): Call update_theme_scrollbar_width and call
4961 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4962 all frames (Bug#8505).
4963 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4964 Call gtk_window_set_resizable if HAVE_GTK3.
4965 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4966 and height if HAVE_GTK3 (Bug#8505).
4967 (scroll_bar_width_for_theme): New variable.
4968 (update_theme_scrollbar_width): New function.
4969 (xg_get_default_scrollbar_width): Move code to
4970 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4971 (xg_initialize): Call update_theme_scrollbar_width.
4972
4973 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4974
4975 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4976
4977 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4978
4979 * frame.c (make_frame): Call other_buffer_safely instead of
4980 other_buffer.
4981
4982 * window.c (temp_output_buffer_show): Call display_buffer with
4983 second argument Vtemp_buffer_show_specifiers and reset latter
4984 immediately after the call.
4985 (Vtemp_buffer_show_specifiers): New variable.
4986 (auto_window_vscroll_p, next_screen_context_lines)
4987 (Vscroll_preserve_screen_position): Remove leading asterisks from
4988 doc-strings.
4989
4990 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4991
4992 Fix minor problems found by GCC 4.6.0 static checking.
4993 * buffer.c (Qclone_number): Remove for now, as it's unused.
4994 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4995 (record_buffer): Remove unused local.
4996 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4997 (set_frame_buffer_list): Remove; unused.
4998 * frame.h (other_visible_frames): Remove decl.
4999 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5000 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5001 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5002 if HAVE_GPM.
5003 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5004 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5005 Define only if HAVE_GPM.
5006 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5007 (update_hints_inhibit): Remove; never set. All uses removed.
5008 * widgetprv.h (emacsFrameClassRec): Remove decl.
5009 * window.c (delete_deletable_window): Now returns void, since it
5010 wasn't returning anything.
5011 (compare_window_configurations): Remove unused locals.
5012 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5013 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5014 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5015 the same widths as pointers. This follows up on the 2011-05-06 patch.
5016 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5017 * xterm.h: Likewise.
5018 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5019
5020 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5021
5022 * makefile.w32-in: Update dependencies.
5023 (LISP_H): Add lib/intprops.h.
5024
5025 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5026
5027 * image.c (gif_load): Add animation frame delay to the metadata.
5028 (syms_of_image): Use DEFSYM. New symbol `delay'.
5029
5030 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5031
5032 * window.c (delete_deletable_window): Re-add.
5033 (Fset_window_configuration): Rewrite to handle dead buffers and
5034 consequently deletable windows.
5035 (window_tree, Fwindow_tree): Remove. Supply functionality in
5036 window.el.
5037 (compare_window_configurations): Simplify code.
5038
5039 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5040
5041 * image.c (imagemagick_load_image): Fix type mismatch.
5042 (Fimagemagick_types): Likewise.
5043
5044 * window.h (replace_buffer_in_windows): Declare.
5045
5046 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5047
5048 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5049 Qclone_number. Remove external declaration of Qdelete_window.
5050 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5051 code.
5052 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5053 Run Qbuffer_list_update_hook if allowed.
5054 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5055 buffer list implementation.
5056 (other_buffer_safely): New function.
5057 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5058 calls to replace_buffer_in_windows and
5059 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5060 if allowed.
5061 (record_buffer): Inhibit quitting and rewrite using quittable
5062 functions. Run Qbuffer_list_update_hook if allowed.
5063 (Frecord_buffer, Funrecord_buffer): New functions.
5064 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5065 Move switch-to-buffer to window.el.
5066 (bury-buffer): Move to window.el.
5067 (Vbuffer_list_update_hook): New variable.
5068
5069 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5070 section.
5071
5072 * window.h (resize_frame_windows): Move up in code.
5073 (Fwindow_frame): Remove EXFUN.
5074 (replace_buffer_in_all_windows): Remove prototype.
5075 (replace_buffer_in_windows_safely): Add prototype.
5076
5077 * window.c: Declare Qdelete_window static again. Move down
5078 declaration of select_count.
5079 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5080 (Fother_window): Move to window.el.
5081 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5082 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5083 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5084 window.el.
5085 (replace_buffer_in_windows): Implement by calling
5086 Qreplace_buffer_in_windows.
5087 (replace_buffer_in_all_windows): Remove with some functionality
5088 moved into replace_buffer_in_windows_safely.
5089 (replace_buffer_in_windows_safely): New function.
5090 (select_window_norecord, select_frame_norecord): Move in front
5091 of run_window_configuration_change_hook. Remove now obsolete
5092 declarations.
5093 (Fset_window_buffer): Rewrite doc-string.
5094 Call Qrecord_window_buffer.
5095 (keys_of_window): Move binding for other-window to window.el.
5096
5097 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * dispextern.h (struct image): Replace data member, whose int_val
5100 and ptr_val fields were not used by anything, with a single
5101 lisp_val object.
5102
5103 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5104 (gif_clear_image, gif_load, imagemagick_load_image)
5105 (gs_clear_image, gs_load): Callers changed.
5106
5107 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * buffer.h: Include <time.h>, for time_t.
5110 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5111
5112 Fix minor problems found by static checking.
5113
5114 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5115
5116 Make identifiers static if they are not used in other modules.
5117 * data.c (Qcompiled_function, Qframe, Qvector):
5118 * image.c (QimageMagick, Qsvg):
5119 * minibuf.c (Qmetadata):
5120 * window.c (resize_window_check, resize_root_window): Now static.
5121 * window.h (resize_window_check, resize_root_window): Remove decls.
5122
5123 * window.c (window_deletion_count, delete_deletable_window):
5124 Remove; unused.
5125 (window_body_lines): Now static.
5126 (Fdelete_other_windows_internal): Mark vars as initialized.
5127 Make sure 'resize_failed' is initialized.
5128 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5129 (resize_window_apply): Remove unused local.
5130 * window.h (delete_deletable_window): Remove decl.
5131
5132 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5133 (imagemagick_load_image): Fix pointer signedness problem by changing
5134 last arg from unsigned char * to char *. All uses changed.
5135 Also, fix a local for similar reasons.
5136 Remove unused locals. Remove locals to avoid shadowing.
5137 (fn_rsvg_handle_free): Remove; unused.
5138 (svg_load, svg_load_image): Fix pointer signedness problem.
5139 (imagemagick_load_image): Don't use garbage pointer image_wand.
5140
5141 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5142
5143 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5144
5145 * image.c (gif_load): Fix omitted cast error introduced by
5146 2011-06-06 change.
5147
5148 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5149
5150 * window.h (resize_proportionally, orig_total_lines)
5151 (orig_top_line): Remove from window structure.
5152 (set_window_height, set_window_width, change_window_heights)
5153 (Fdelete_window): Remove prototypes.
5154 (resize_frame_windows): Remove duplicate declaration.
5155
5156 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5157
5158 * window.h (resize_frame_windows, resize_window_check)
5159 (delete_deletable_window, resize_root_window)
5160 (resize_frame_windows): Declare prototypes.
5161
5162 * window.c (resize_window_apply): Make definition be "static" to
5163 match the prototype.
5164
5165 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5166
5167 * window.c: Remove declarations of Qwindow_size_fixed,
5168 window_min_size_1, window_min_size_2, window_min_size,
5169 size_window, window_fixed_size_p, enlarge_window, delete_window.
5170 Remove static from declaration of Qdelete_window, it's
5171 temporarily needed by Fbury_buffer.
5172 (replace_window): Don't assign orig_top_line and
5173 orig_total_lines.
5174 (Fdelete_window, delete_window): Remove. Window deletion is
5175 handled by window.el.
5176 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5177 Replace Fdelete_window calls with calls to Qdelete_window.
5178 (Fdelete_other_windows): Remove. Deleting other windows is
5179 handled by window.el.
5180 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5181 handled in window.el.
5182 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5183 Window minimum sizes are handled in window.el.
5184 (shrink_windows, size_window, set_window_height)
5185 (set_window_width, change_window_heights, window_height)
5186 (window_width, CURBEG, CURSIZE, enlarge_window)
5187 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5188 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5189 handled in window.el.
5190 (make_dummy_parent): Rename to make_parent_window and give it a
5191 second argument horflag.
5192 (make_window): Don't set resize_proportionally any more.
5193 (Fsplit_window): Remove. Windows are split in window.el.
5194 (save_restore_action, save_restore_orig_size)
5195 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5196 Resize mini windows in window.el.
5197 (grow_mini_window, shrink_mini_window): Implement by calling
5198 Qresize_root_window_vertically, resize_window_check and
5199 resize_window_apply.
5200 (saved_window, Fset_window_configuration, save_window_save):
5201 Do not handle orig_top_line, orig_total_lines, and
5202 resize_proportionally.
5203 (window_min_height, window_min_width): Move to window.el.
5204 (keys_of_window): Move bindings for delete-other-windows,
5205 split-window, delete-window and enlarge-window to window.el.
5206
5207 * buffer.c: Temporarily extern Qdelete_window.
5208 (Fbury_buffer): Temporarily call Qdelete_window instead of
5209 Fdelete_window (Fbury_buffer will move to window.el soon).
5210
5211 * frame.c (set_menu_bar_lines_1): Remove code handling
5212 orig_top_line and orig_total_lines.
5213
5214 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5215 set_window_height but set heights directly.
5216 (change_frame_size_1): Use resize_frame_windows.
5217
5218 * xdisp.c (init_xdisp): Don't use set_window_height but set
5219 heights directly.
5220
5221 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5222 Use resize_frame_windows instead of change_window_heights and run
5223 run_window_configuration_change_hook.
5224
5225 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5226 instead of change_window_heights and run
5227 run_window_configuration_change_hook.
5228
5229 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5230
5231 * window.c (replace_window): Rename second argument REPLACEMENT to
5232 NEW. New third argument SETFLAG. Rewrite.
5233 (delete_window, make_dummy_parent): Call replace_window with
5234 third argument 1.
5235 (window_list_1): Move down in code.
5236 (run_window_configuration_change_hook): Move set_buffer part
5237 before select_frame_norecord part in order to unwind correctly.
5238 Rename count1 to count.
5239 (recombine_windows, delete_deletable_window, resize_root_window)
5240 (Fdelete_other_windows_internal)
5241 (Frun_window_configuration_change_hook, make_parent_window)
5242 (resize_window_check, resize_window_apply, Fresize_window_apply)
5243 (resize_frame_windows, Fsplit_window_internal)
5244 (Fdelete_window_internal, Fresize_mini_window_internal):
5245 New functions.
5246 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5247
5248 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5249
5250 * window.h (window): Add some new members to window structure -
5251 normal_lines, normal_cols, new_total, new_normal, clone_number,
5252 splits, nest, prev_buffers, next_buffers.
5253 (WINDOW_TOTAL_SIZE): Move here from window.c.
5254 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5255
5256 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5257 Remove.
5258 (make_dummy_parent): Set new members of windows structure.
5259 (make_window): Move down in code. Handle new members of window
5260 structure.
5261 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5262 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5263 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5264 (Fset_window_prev_buffers, Fwindow_next_buffers)
5265 (Fset_window_next_buffers, Fset_window_clone_number):
5266 New functions.
5267 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5268 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5269 Doc-string fixes.
5270 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5271 Argument WINDOW can be now internal window too.
5272 (Fwindow_use_time): Move up in code.
5273 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5274 Rewrite doc-string.
5275 (Fset_window_configuration, saved_window)
5276 (Fcurrent_window_configuration, save_window_save): Handle new
5277 members of window structure.
5278 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5279 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5280 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5281 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5282 Qget_mru_window, Qresize_root_window,
5283 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5284 Qauto_buffer_name; staticpro them.
5285
5286 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5287
5288 * window.c (Fwindow_total_size, Fwindow_left_column)
5289 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5290 (Fwindow_list_1): New functions.
5291 (window_box_text_cols): Replace with window_body_cols.
5292 (Fwindow_width, Fscroll_left, Fscroll_right):
5293 Use window_body_cols instead of window_box_text_cols.
5294 (delete_window, Fset_window_configuration):
5295 Call delete_all_subwindows with window as argument.
5296 (delete_all_subwindows): Take a window as argument and not a
5297 structure. Rewrite.
5298 (window_loop): Remove handling of GET_LRU_WINDOW and
5299 GET_LARGEST_WINDOW.
5300 (Fget_lru_window, Fget_largest_window): Move to window.el.
5301
5302 * window.h: Extern window_body_cols instead of
5303 window_box_text_cols. delete_all_subwindows now takes a
5304 Lisp_Object as argument.
5305
5306 * indent.c (compute_motion, Fcompute_motion):
5307 Use window_body_cols instead of window_box_text_cols.
5308
5309 * frame.c (delete_frame): Call delete_all_subwindows with root
5310 window as argument.
5311
5312 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5313
5314 * fns.c (Fputhash): Document return value.
5315
5316 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5317
5318 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5319
5320 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 Cons<->int and similar integer overflow fixes (Bug#8794).
5323
5324 Check for overflow when converting integer to cons and back.
5325 * charset.c (Fdefine_charset_internal, Fdecode_char):
5326 Use cons_to_unsigned to catch overflow.
5327 (Fencode_char): Use INTEGER_TO_CONS.
5328 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5329 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5330 * data.c (long_to_cons, cons_to_long): Remove.
5331 (cons_to_unsigned, cons_to_signed): New functions.
5332 These signal an error for invalid or out-of-range values.
5333 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5334 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5335 * font.c (Ffont_variation_glyphs):
5336 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5337 * lisp.h: Include <intprops.h>.
5338 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5339 (cons_to_signed, cons_to_unsigned): New decls.
5340 (long_to_cons, cons_to_long): Remove decls.
5341 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5342 (Fprimitive_undo): Use CONS_TO_INTEGER.
5343 * xfns.c (Fx_window_property): Likewise.
5344 * xselect.c: Include <limits.h>.
5345 (x_own_selection, selection_data_to_lisp_data):
5346 Use INTEGER_TO_CONS.
5347 (x_handle_selection_request, x_handle_selection_clear)
5348 (x_get_foreign_selection, Fx_disown_selection_internal)
5349 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5350 (lisp_data_to_selection_data): Use cons_to_unsigned.
5351 (x_fill_property_data): Use cons_to_signed.
5352 Report values out of range.
5353
5354 Check for buffer and string overflow more precisely.
5355 * buffer.h (BUF_BYTES_MAX): New macro.
5356 * lisp.h (STRING_BYTES_MAX): New macro.
5357 * alloc.c (Fmake_string):
5358 * character.c (string_escape_byte8):
5359 * coding.c (coding_alloc_by_realloc):
5360 * doprnt.c (doprnt):
5361 * editfns.c (Fformat):
5362 * eval.c (verror):
5363 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5364 since they may not be the same number.
5365 * editfns.c (Finsert_char):
5366 * fileio.c (Finsert_file_contents):
5367 Likewise for BUF_BYTES_MAX.
5368
5369 * image.c: Use ptrdiff_t, not int, for sizes.
5370 (slurp_file): Switch from int to ptrdiff_t.
5371 All uses changed.
5372 (slurp_file): Check that file size fits in both size_t (for
5373 malloc) and ptrdiff_t (for sanity and safety).
5374
5375 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5376 if b->modtime has its maximal value.
5377
5378 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5379
5380 Don't assume time_t can fit into int.
5381 * buffer.h (struct buffer.modtime): Now time_t, not int.
5382 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5383 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5384
5385 Minor fixes for signed vs unsigned integers.
5386 * character.h (MAYBE_UNIFY_CHAR):
5387 * charset.c (maybe_unify_char):
5388 * keyboard.c (read_char, reorder_modifiers):
5389 XINT -> XFASTINT, since the integer must be nonnegative.
5390 * ftfont.c (ftfont_spec_pattern):
5391 * keymap.c (access_keymap, silly_event_symbol_error):
5392 XUINT -> XFASTINT, since the integer must be nonnegative.
5393 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5394 since it makes no difference and we prefer signed.
5395 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5396 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5397 nonnegative.
5398
5399 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5400
5401 * window.h (Fwindow_frame): Declare.
5402
5403 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5406 (SPARE_MEMORY): Always define.
5407 (LARGE_REQUEST): Remove.
5408 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5409
5410 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5411
5412 * lisp.h: Move EXFUNS for Fframe_root_window,
5413 Fframe_first_window and Fset_frame_selected_window to window.h.
5414
5415 * window.h: Move EXFUNS for Fframe_root_window,
5416 Fframe_first_window and Fset_frame_selected_window here from
5417 lisp.h.
5418
5419 * frame.c (Fwindow_frame, Fframe_first_window)
5420 (Fframe_root_window, Fframe_selected_window)
5421 (Fset_frame_selected_window): Move to window.c.
5422 (Factive_minibuffer_window): Move to minibuf.c.
5423 (Fother_visible_frames_p): New function.
5424
5425 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5426
5427 * window.c (decode_window, decode_any_window): Move up in code.
5428 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5429 (inhibit_frame_unsplittable): Remove unused variable.
5430 (Fwindow_buffer): Move up and rewrite doc-string.
5431 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5432 (Fwindow_prev): New functions.
5433 (Fwindow_frame): Move here from frame.c. Accept any window as
5434 argument.
5435 (Fframe_root_window, Fframe_first_window)
5436 (Fframe_selected_window): Move here from frame.c. Accept frame
5437 or arbitrary window as argument. Update doc-strings.
5438 (Fminibuffer_window): Move up in code.
5439 (Fwindow_minibuffer_p): Move up in code and simplify.
5440 (Fset_frame_selected_window): Move here from frame.c.
5441 Marginal rewrite.
5442 (Fselected_window, select_window, Fselect_window): Move up in
5443 code. Minor doc-string fixes.
5444
5445 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5446
5447 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5448 Do not assume that spare memory exists; that assumption is valid
5449 only if SYSTEM_MALLOC.
5450 (LARGE_REQUEST): New macro, so that the issue of large requests
5451 is separated from the issue of spare memory.
5452
5453 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5454
5455 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5456 format. (Bug#8806)
5457
5458 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5459
5460 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5461 before statements.
5462
5463 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5464
5465 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5466
5467 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5468
5469 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5470 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5471
5472 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5473
5474 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5475
5476 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5477
5478 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5479 (x_clipboard_manager_save): Add return value.
5480 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5481 New error handlers.
5482 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5483 Obey Vx_select_enable_clipboard_manager. Catch errors in
5484 x_clipboard_manager_save (Bug#8779).
5485 (Vx_select_enable_clipboard_manager): New variable.
5486 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5487
5488 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5489
5490 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5491
5492 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5493
5494 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5495 in the current matrix if keep_current_p is non-zero.
5496
5497 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5498
5499 * bidi.c (bidi_level_of_next_char): Fix last change.
5500
5501 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5502
5503 Support bidi reordering of text covered by display properties.
5504
5505 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5506 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5507 (bidi_cache_search, bidi_cache_iterator_state)
5508 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5509 (bidi_level_of_next_char, bidi_move_to_visually_next):
5510 Support character positions inside a run of characters covered by a
5511 display string.
5512 (bidi_paragraph_init, bidi_resolve_explicit_1)
5513 (bidi_level_of_next_char): Call bidi_fetch_char and
5514 bidi_fetch_char_advance instead of FETCH_CHAR and
5515 FETCH_CHAR_ADVANCE.
5516 (bidi_init_it): Initialize new members.
5517 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5518 definitions.
5519 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5520 instead of using explicit *_CHAR codes.
5521 (bidi_resolve_explicit, bidi_resolve_weak):
5522 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5523 bidirectional text is supported only in multibyte buffers.
5524 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5525 it to initialize the frame_window_p member of struct bidi_it.
5526 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5527 (bidi_resolve_explicit, bidi_resolve_weak)
5528 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5529 bidi_it->nchars is non-positive.
5530 (bidi_level_of_next_char): Don't try to lookup the cache for the
5531 next/previous character if nothing is cached there yet, or if we
5532 were just reseat()'ed to a new position.
5533
5534 * xdisp.c (set_cursor_from_row): Set start and stop points
5535 according to the row's direction when priming the loop that looks
5536 for the glyph on which to display cursor.
5537 (single_display_spec_intangible_p): Function deleted.
5538 (display_prop_intangible_p): Reimplement to call
5539 handle_display_spec instead of single_display_spec_intangible_p.
5540 Accept 3 additional arguments needed by handle_display_spec.
5541 This fixes incorrect cursor motion across display property with complex
5542 values: lists, `(when COND...)' forms, etc.
5543 (single_display_spec_string_p): Support property values that are
5544 lists with the argument STRING its top-level element.
5545 (display_prop_string_p): Fix the condition for processing a
5546 property that is a list to be consistent with handle_display_spec.
5547 (handle_display_spec): New function, refactored from the
5548 last portion of handle_display_prop.
5549 (compute_display_string_pos): Accept additional argument
5550 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5551 value of a `display' property is a "replacing spec".
5552 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5553 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5554 the display property, but just return a value indicating whether
5555 the display property will replace the characters it covers.
5556 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5557 frame_window_p members of struct bidi_it.
5558 (compute_display_string_pos, compute_display_string_end):
5559 New functions.
5560 (push_it): Accept second argument POSITION, where pop_it should
5561 jump to continue iteration.
5562 (reseat_1): Initialize bidi_it.disp_pos.
5563
5564 * keyboard.c (adjust_point_for_property): Adjust the call to
5565 display_prop_intangible_p to its new signature.
5566
5567 * dispextern.h (struct bidi_it): New member frame_window_p.
5568 (bidi_init_it): Update prototypes.
5569 (display_prop_intangible_p): Update prototype.
5570 (compute_display_string_pos, compute_display_string_end):
5571 Declare prototypes.
5572 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5573 EMACS_INT.
5574
5575 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 Malloc failure behavior now depends on size of allocation.
5578 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5579 * lisp.h: Change signatures accordingly.
5580 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5581 All callers changed. (Bug#8762)
5582
5583 * gnutls.c: Use Emacs's memory allocators.
5584 Without this change, the gnutls library would invoke malloc etc.
5585 directly, which causes problems on non-SYNC_INPUT hosts, and which
5586 runs afoul of improving memory_full behavior. (Bug#8761)
5587 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5588 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5589 xfree instead of the default malloc, realloc, free.
5590 (Fgnutls_boot): No need to check for memory allocation failure,
5591 since xmalloc does that for us.
5592
5593 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5594 * category.c (hash_get_category_set):
5595 * ccl.c (ccl_driver):
5596 * charset.c (Fdefine_charset_internal):
5597 * charset.h (struct charset.hash_index):
5598 * composite.c (get_composition_id, gstring_lookup_cache)
5599 (composition_gstring_put_cache):
5600 * composite.h (struct composition.hash_index):
5601 * dispextern.h (struct image.hash):
5602 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5603 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5604 (hashfn_equal, hashfn_user_defined, make_hash_table)
5605 (maybe_resize_hash_table, hash_lookup, hash_put)
5606 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5607 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5608 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5609 * image.c (make_image, search_image_cache, lookup_image)
5610 (xpm_put_color_table_h):
5611 * lisp.h (struct Lisp_Hash_Table):
5612 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5613 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5614 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5615 * alloc.c (allocate_vectorlike):
5616 Check for overflow in vector size calculations.
5617 * ccl.c (ccl_driver):
5618 Check for overflow when converting EMACS_INT to int.
5619 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5620 need to be updated by these changes.
5621 * fns.c (make_hash_table, maybe_resize_hash_table):
5622 Check for integer overflow with large hash tables.
5623 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5624 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5625 (SXHASH_REDUCE): New macro.
5626 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5627 Use it instead of discarding useful hash info with large hash values.
5628 (sxhash_float): New function.
5629 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5630 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5631 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5632 Rewrite to use FIXNUM_BITS, as this simplifies things.
5633 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5634 Adjust signatures to match updated version of code.
5635 (consing_since_gc): Now EMACS_INT, since a single hash table can
5636 use more than INT_MAX bytes.
5637
5638 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5639
5640 Make it possible to build with GCC-4.6+ -O2 -flto.
5641
5642 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5643
5644 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5645
5646 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5647 Call minibuffer-inactive-mode.
5648
5649 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5650
5651 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5652 Update dependencies.
5653
5654 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5655
5656 * data.c (init_data): Remove code for UTS, this system is not
5657 supported anymore.
5658
5659 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5660
5661 Don't force ./temacs to start in terminal mode.
5662
5663 * frame.c (make_initial_frame): Initialize faces in all cases, not
5664 only when CANNOT_DUMP is defined.
5665 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5666
5667 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5668
5669 * dispnew.c (add_window_display_history): Use const for the string
5670 pointer. Remove declaration, not needed.
5671
5672 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 Use 'inline', not 'INLINE'.
5675 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5676 * alloc.c, fontset.c (INLINE): Remove.
5677 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5678 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5679 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5680 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5681 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5682
5683 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5684
5685 Make it possible to run ./temacs.
5686
5687 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5688 syms_of_callproc does the same thing. Remove test for
5689 "initialized", do it in the caller.
5690 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5691
5692 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5693
5694 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5695 (read_minibuf): Use get_minibuffer.
5696 (syms_of_minibuf): Use DEFSYM.
5697 (Qmetadata): New var.
5698 * data.c (Qbuffer): Don't make it static.
5699 (syms_of_data): Use DEFSYM.
5700
5701 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5702
5703 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5704 (CCL_CODE_MIN): New macro.
5705
5706 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5707
5708 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5709
5710 * eval.c (Qdebug): Now static.
5711 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5712 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5713 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5714
5715 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5716
5717 * image.c: Various fixes to ImageMagick code comments.
5718 (Fimagemagick_types): Doc fix.
5719
5720 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5721
5722 Minor fixes prompted by GCC 4.6.0 warnings.
5723
5724 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5725
5726 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5727 (x_clipboard_manager_save_all): Move extern decl to ...
5728 * xterm.h: ... here, so that it can be checked for consistency.
5729
5730 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5731
5732 * xselect.c (x_clipboard_manager_save_frame)
5733 (x_clipboard_manager_save_all): New functions.
5734 (Fx_clipboard_manager_save): Lisp function deleted.
5735
5736 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5737 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5738
5739 * xterm.h: Update prototype.
5740
5741 2011-05-28 William Xu <william.xwl@gmail.com>
5742
5743 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5744 exiting (Bug#8239).
5745
5746 2011-05-28 Jim Meyering <meyering@redhat.com>
5747
5748 Avoid a sign-extension bug in crypto_hash_function.
5749 * fns.c (to_uchar): Define.
5750 (crypto_hash_function): Use it to convert some newly-signed
5751 variables to unsigned, to avoid sign-extension bugs. For example,
5752 without this change, (md5 "truc") would evaluate to
5753 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5754 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5755 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5756
5757 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5758
5759 Integer overflow fixes.
5760
5761 * dbusbind.c: Serial number integer overflow fixes.
5762 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5763 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5764 to hold a serial number that is too large for a fixnum.
5765 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5766 Check for serial numbers out of range. Decode any serial number
5767 that was so large that it became a float. (Bug#8722)
5768
5769 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5770 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5771 Use XFASTINT rather than XUINT when numbers are nonnegative.
5772 (xd_append_arg, Fdbus_method_return_internal):
5773 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5774 arguments, check that Lisp number is nonnegative, rather than
5775 silently wrapping negative numbers around. (Bug#8722)
5776 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5777 (Bug#8722)
5778
5779 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5780
5781 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5782
5783 ccl: Add integer overflow checks.
5784 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5785 (IN_INT_RANGE): New macros.
5786 (ccl_driver): Use them to check for integer overflow when
5787 decoding a CCL program. Many of the new checks are whether XINT (x)
5788 fits in int; it doesn't always, on 64-bit hosts. The new version
5789 doesn't catch all possible integer overflows, but it's an
5790 improvement. (Bug#8719)
5791
5792 * alloc.c (make_event_array): Use XINT, not XUINT.
5793 There's no need for unsigned here.
5794
5795 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5796 This follows up to the 2011-05-06 change that substituted uintptr_t
5797 for EMACS_INT. This case wasn't caught back then.
5798
5799 Rework Fformat to avoid integer overflow issues.
5800 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5801 now (part of C89). Include <verify.h>.
5802 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5803 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5804 (Fformat): Avoid the prepass trying to compute sizes; it was only
5805 approximate and thus did not catch overflow reliably. Instead, walk
5806 through the format just once, formatting and computing sizes as we go,
5807 checking for integer overflow at every step, and allocating a larger
5808 buffer as needed. Keep track separately whether the format is
5809 multibyte. Keep only the most-recently calculated precision, rather
5810 than them all. Record whether each argument has been converted to
5811 string. Use EMACS_INT, not int, for byte and char and arg counts.
5812 Support field widths and precisions larger than INT_MAX. Avoid
5813 sprintf's undefined behavior with conversion specifications such as %#d
5814 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5815 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5816 formatting out-of-range floating point numbers with int
5817 formats. (Bug#8668)
5818
5819 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5820
5821 * data.c: Avoid integer truncation in expressions involving floats.
5822 * data.c: Include <intprops.h>.
5823 (arith_driver): When there's an integer overflow in an expression
5824 involving floating point, convert the integers to floating point
5825 so that the resulting value does not suffer from catastrophic
5826 integer truncation. For example, on a 64-bit host (* 4
5827 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5828 Do not rely on undefined behavior after integer overflow.
5829
5830 merge count_size_as_multibyte, parse_str_to_multibyte
5831 * character.c, character.h (count_size_as_multibyte):
5832 Rename from parse_str_to_multibyte; all uses changed.
5833 Check for integer overflow.
5834 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5835 since it's now a duplicate of the other. This is more of
5836 a character than a buffer op, so better that it's in character.c.
5837 * fns.c, print.c: Adjust to above changes.
5838
5839 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5842
5843 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5846 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5847 (x_clipboard_manager_save): Now static.
5848 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5849
5850 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5851 (crypto_hash_function): Now static.
5852 Fix pointer signedness problems. Avoid unnecessary initializations.
5853
5854 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5855
5856 * termhooks.h (Vselection_alist): Make it terminal-local.
5857
5858 * terminal.c (create_terminal): Initialize it.
5859
5860 * xselect.c: Support for clipboard managers.
5861 (Vselection_alist): Move to termhooks.h as terminal-local var.
5862 (LOCAL_SELECTION): New macro.
5863 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5864 (symbol_to_x_atom): Remove gratuitous arg.
5865 (x_handle_selection_request, lisp_data_to_selection_data)
5866 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5867 (x_own_selection, x_get_local_selection, x_convert_selection):
5868 New arg, specifying work frame. Use terminal-local Vselection_alist.
5869 (some_frame_on_display): Delete unused function.
5870 (Fx_own_selection_internal, Fx_get_selection_internal)
5871 (Fx_disown_selection_internal, Fx_selection_owner_p)
5872 (Fx_selection_exists_p): New optional frame arg.
5873 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5874 (x_handle_selection_clear): Don't treat other terminals with the
5875 same keyboard specially. Use the terminal-local Vselection_alist.
5876 (x_clear_frame_selections): Use Frun_hook_with_args.
5877
5878 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5879
5880 * xterm.h: Add support for those atoms.
5881
5882 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5883
5884 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5885 (converted_selections, conversion_fail_tag): New global variables.
5886 (x_selection_request_lisp_error): Free the above.
5887 (x_get_local_selection): Remove unnecessary code.
5888 (x_reply_selection_request): Args changed; handle arbitrary array
5889 of converted selections stored in converted_selections.
5890 Separate the XChangeProperty and SelectionNotify steps.
5891 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5892 (x_convert_selection): New function.
5893 (x_handle_selection_event): Simplify.
5894 (x_get_foreign_selection): Don't ignore incoming requests while
5895 waiting for an answer; this will fail when we implement
5896 SAVE_TARGETS, and seems unnecessary anyway.
5897 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5898 (Vx_sent_selection_functions): Doc fix.
5899
5900 2011-05-26 Leo Liu <sdl.web@gmail.com>
5901
5902 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5903
5904 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5905
5906 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5907
5908 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5909 for fringe update if it has periodic bitmap.
5910 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5911 and fringe_bitmap_periodic_p.
5912
5913 * fringe.c (get_fringe_bitmap_data): New function.
5914 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5915 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5916 row. Mark glyph row for fringe update if periodicity changed.
5917
5918 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5919 for fringe update unless it has periodic bitmap.
5920
5921 2011-05-25 Kenichi Handa <handa@m17n.org>
5922
5923 * xdisp.c (get_next_display_element): Set correct it->face_id for
5924 a static composition.
5925
5926 2011-05-24 Leo Liu <sdl.web@gmail.com>
5927
5928 * deps.mk (fns.o):
5929 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5930
5931 * fns.c (crypto_hash_function, Fsha1): New function.
5932 (Fmd5): Use crypto_hash_function.
5933 (syms_of_fns): Add Ssha1.
5934
5935 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5936
5937 * gnutls.c: Remove unused macros.
5938 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5939 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5940 Remove macros that are defined and never used.
5941 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5942
5943 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5944
5945 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5946 (Fx_get_selection_internal): Minor cleanup.
5947 (Fx_own_selection_internal): Rename arguments for consistency with
5948 select.el.
5949
5950 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5953
5954 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5955
5956 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5957
5958 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5959
5960 * dispnew.c (scrolling_window): Don't exclude the case that the
5961 last enabled row in the desired matrix touches the bottom boundary.
5962
5963 2011-05-21 Glenn Morris <rgm@gnu.org>
5964
5965 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5966 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5967 and add some more files.
5968
5969 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5970
5971 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5972 report_file_error introduced by the change from 2011-05-07.
5973
5974 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5975
5976 * systime.h (Time): Define only if emacs is defined.
5977 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5978 where the include path doesn't have X11/X.h by default. See
5979 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5980
5981 2011-05-20 Kenichi Handa <handa@m17n.org>
5982
5983 * composite.c (find_automatic_composition): Fix previous change.
5984
5985 2011-05-20 Glenn Morris <rgm@gnu.org>
5986
5987 * lisp.mk: New file, split from Makefile.in.
5988 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5989 (shortlisp): Remove.
5990 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5991
5992 2011-05-19 Glenn Morris <rgm@gnu.org>
5993
5994 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5995 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5996 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5997 (lisp): Set the order to that of loadup.el.
5998 (shortlisp): Make it a copy of $lisp.
5999 (SOME_MACHINE_LISP): Remove.
6000 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6001 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6002
6003 2011-05-18 Kenichi Handa <handa@m17n.org>
6004
6005 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6006 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6007 (find_automatic_composition): Mostly rewrite for efficiency.
6008
6009 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * makefile.w32-in: Update dependencies.
6012
6013 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6014
6015 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6016 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6017
6018 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6019
6020 Fix some integer overflow issues, such as string length overflow.
6021
6022 * insdel.c (count_size_as_multibyte): Check for string overflow.
6023
6024 * character.c (lisp_string_width): Check for string overflow.
6025 Use EMACS_INT, not int, for string indexes and lengths; in
6026 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6027 the resulting string length overflows an EMACS_INT; instead,
6028 report a string overflow if no precision given. When checking for
6029 precision exhaustion, use a check that cannot possibly have
6030 integer overflow. (Bug#8675)
6031 * character.h (lisp_string_width): Adjust to new signature.
6032
6033 * alloc.c (string_overflow): New function.
6034 (Fmake_string): Use it. This doesn't change behavior, but saves
6035 a few bytes and will simplify future changes.
6036 * character.c (string_escape_byte8): Likewise.
6037 * lisp.h (string_overflow): New decl.
6038
6039 Fixups, following up to the user-interface timestamp change.
6040 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6041 for UI timestamps, instead of unsigned long.
6042 * msdos.c (mouse_get_pos): Likewise.
6043 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6044 * w32gui.h (Time): Define by including "systime.h" rather than by
6045 declaring it ourselves. (Bug#8664)
6046
6047 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6048 * image.c (clear_image_cache): Likewise.
6049
6050 * term.c (term_mouse_position): Don't assume time_t wraparound.
6051
6052 Be more systematic about user-interface timestamps.
6053 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6054 and sometimes 'EMACS_UINT', to represent these timestamps.
6055 This change causes it to use 'Time' uniformly, as that's what X uses.
6056 This makes the code easier to follow, and makes it easier to catch
6057 integer overflow bugs such as Bug#8664.
6058 * frame.c (Fmouse_position, Fmouse_pixel_position):
6059 Use Time, not unsigned long, for user-interface timestamps.
6060 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6061 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6062 * keyboard.h (last_event_timestamp): Likewise.
6063 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6064 * menu.h (xmenu_show): Likewise.
6065 * term.c (term_mouse_position): Likewise.
6066 * termhooks.h (struct input_event.timestamp): Likewise.
6067 (struct terminal.mouse_position_hook): Likewise.
6068 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6069 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6070 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6071 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6072 what it was before.
6073 * menu.h, termhooks.h: Include "systime.h", for Time.
6074
6075 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6076 Don't assume that the difference between two unsigned long values
6077 can fit into an integer. At this point, we know button_down_time
6078 <= event->timestamp, so the difference must be nonnegative, so
6079 there's no need to cast the result if double-click-time is
6080 nonnegative, as it should be; check that it's nonnegative, just in
6081 case. This bug is triggered when events are more than 2**31 ms
6082 apart (about 25 days). (Bug#8664)
6083
6084 * xselect.c (last_event_timestamp): Remove duplicate decl.
6085 (x_own_selection): Remove needless cast to unsigned long.
6086
6087 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6088 that always fit in int. Use a sentinel instead of a counter, to
6089 avoid a temp and to allay GCC's concerns about possible int overflow.
6090 * frame.h (struct frame): Use int for menu_bar_items_used
6091 instead of EMACS_INT, since it always fits in int.
6092
6093 * menu.c (grow_menu_items): Check for int overflow.
6094
6095 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6096
6097 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6098 Before, the code was not consistent. These values cannot exceed
6099 2**31 - 1 so there's no need to make them unsigned.
6100 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6101 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6102 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6103 as modifiers.
6104 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6105
6106 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6107 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6108 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6109 presumably because the widths might not match.
6110
6111 * window.c (size_window): Avoid needless test at loop start.
6112
6113 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6114
6115 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6116
6117 2011-05-12 Drew Adams <drew.adams@oracle.com>
6118
6119 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6120
6121 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6122
6123 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6124 `width' to `bar_area_x' and `bar_area_width', respectively.
6125 (x_scroll_run): Take account of fringe background extension.
6126
6127 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6128 Rename local vars `left' and `width' to `bar_area_x' and
6129 `bar_area_width', respectively.
6130 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6131 background extension.
6132
6133 2011-05-10 Jim Meyering <meyering@redhat.com>
6134
6135 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6136
6137 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6138
6139 * image.c (Finit_image_library): Return t for built-in image types,
6140 like pbm and xbm. (Bug#8640)
6141
6142 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6143
6144 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6145
6146 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6147
6148 * w32console.c (Fset_screen_color): Doc fix.
6149 (Fget_screen_color): New function.
6150 (syms_of_ntterm): Defsubr it.
6151
6152 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6153 unlink the temporary file if Fcall_process didn't create it in the
6154 first place.
6155 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6156 child process will be redirected to a file specified with `:file'.
6157 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6158 cue to call_process_cleanup not to close that handle.
6159
6160 2011-05-07 Ben Key <bkey76@gmail.com>
6161
6162 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6163 one of two shell specific rules, either bootstrap-temacs-CMD or
6164 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6165 to the previous implementation of the bootstrap-temacs rule.
6166 The bootstrap-temacs-CMD rule is similar to the previous
6167 implementation of the bootstrap-temacs rule except that it
6168 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6169 variable.
6170
6171 These changes, along with some changes to nt/configure.bat,
6172 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6173 earlier fix to add support for --cflags and --ldflags options
6174 that include quotes so that it works whether make uses cmd or
6175 sh as the shell.
6176
6177 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6178
6179 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6180 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6181 is a constant.
6182 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6183 a string. Handle both cases.
6184 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6185 (Fdbus_register_method): Use Qinvalid_function.
6186
6187 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6188
6189 * makefile.w32-in: Update dependencies.
6190 (LISP_H): Add inttypes.h and stdin.h.
6191 (PROCESS_H): Add unistd.h.
6192
6193 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6194
6195 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6196 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6197
6198 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6199
6200 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6201
6202 * term.c (vfatal): Remove stray call to va_end.
6203 It's not needed and the C Standard doesn't allow it here anyway.
6204
6205 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6206 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6207
6208 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6209 bytes.
6210
6211 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6212
6213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6214
6215 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6216
6217 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6218
6219 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6220
6221 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6222 * charset.c (Fdefine_charset_internal): Don't initialize
6223 charset.code_space[15]. The value was garbage, on hosts with
6224 32-bit int (Bug#8600).
6225
6226 * lread.c (read_integer): Be more consistent with string-to-number.
6227 Use string_to_number to do the actual conversion; this avoids
6228 rounding errors and fixes some other screwups. Without this fix,
6229 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6230 (digit_to_number): Move earlier, for benefit of read_integer.
6231 Return -1 if the digit is out of range for the base, -2 if it is
6232 not a digit in any supported base. (Bug#8602)
6233
6234 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6235
6236 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6237 to match comment at start of function. This also removes a
6238 GCC warning about overflow in a 32+64-bit port.
6239
6240 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6241
6242 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6243 Reported by Stefan Monnier in
6244 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6245 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6246 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6247
6248 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6249 (EMACS_UINTPTR): Likewise, with uintptr_t.
6250
6251 * lisp.h: Prefer 64-bit EMACS_INT if available.
6252 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6253 on 32-bit hosts that have 64-bit int, so that they can access
6254 large files.
6255 However, temporarily disable this change unless the temporary
6256 symbol WIDE_EMACS_INT is defined.
6257
6258 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6259
6260 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6261 This removes an assumption that EMACS_INT and long are the same
6262 width as pointers. The assumption is true for Emacs porting targets
6263 now, but we want to make other targets possible.
6264 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6265 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6266 In the rest of the code, change types of integers that hold casted
6267 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6268 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6269 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6270 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6271 No need to cast type when ORing.
6272 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6273 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6274 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6275 assume EMACS_INT is the same width as char *.
6276 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6277 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6278 Remove no-longer-needed casts.
6279 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6280 (xg_tool_bar_help_callback, xg_make_tool_item):
6281 Use EMACS_INTPTR to hold an integer
6282 that will be cast to void *; this can avoid a GCC warning
6283 if EMACS_INT is not the same width as void *.
6284 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6285 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6286 (current_message_1, set_message_1):
6287 Use a local to convert to proper width without a cast.
6288 * xmenu.c (dialog_selection_callback): Likewise.
6289
6290 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6291 Also, don't assume VALBITS / RAND_BITS is less than 5,
6292 and don't rely on undefined behavior when shifting a 1 left into
6293 the sign bit.
6294 * lisp.h (get_random): Change signature to match.
6295
6296 * lread.c (hash_string): Use size_t, not int, for hash computation.
6297 Normally we prefer signed values; but hashing is special, because
6298 it's better to use unsigned division on hash table sizes so that
6299 the remainder is nonnegative. Also, size_t is the natural width
6300 for hashing into memory. The previous code used 'int', which doesn't
6301 retain enough info to hash well into very large tables.
6302 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6303
6304 * dbusbind.c: Don't possibly lose pointer info when converting.
6305 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6306 Use XPNTR rather than XHASH, so that the high-order bits of
6307 the pointer aren't lost when converting through void *.
6308
6309 * eval.c (Fautoload): Don't double-shift a pointer.
6310
6311 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6312
6313 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6314
6315 * gnutls.c (DEF_GNUTLS_FN):
6316 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6317
6318 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6319
6320 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6321 marker. (Bug#8610)
6322
6323 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6324
6325 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6326 New version that can reserve upto 2GB of heap space.
6327
6328 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6329
6330 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6331
6332 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6333
6334 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6335 `gnutls_certificate_set_x509_key_file'.
6336
6337 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6340 Update dependencies.
6341
6342 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6343
6344 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6345 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6346 Remove unused parameter `fildes'.
6347 * process.c (read_process_output, send_process): Don't pass it.
6348
6349 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6350
6351 Fix previous change: the library cache is defined in w32.c.
6352 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6353 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6354
6355 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6356
6357 Implement dynamic loading of GnuTLS on Windows.
6358
6359 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6360 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6361 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6362 Declare.
6363
6364 * gnutls.c (Qgnutls_dll): Define.
6365 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6366 (gnutls_*): Declare function pointers.
6367 (init_gnutls_functions): New function to initialize function pointers.
6368 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6369 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6370 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6371 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6372 (emacs_gnutls_write, emacs_gnutls_read)
6373 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6374 (Fgnutls_available_p): New function.
6375 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6376 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6377 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6378
6379 * image.c: Include w32.h.
6380 (Vimage_type_cache): Delete.
6381 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6382 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6383 (w32_delayed_load): Move to w32.c.
6384
6385 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6386
6387 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6388 (w32_delayed_load): Move from image.c. When loading a library, record
6389 its filename in the :loaded-from property of the library id.
6390 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6391 Initialize and staticpro them.
6392 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6393
6394 * process.c: Include lisp.h before w32.h, not after.
6395 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6396 instead of gnutls_record_check_pending.
6397
6398 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6399
6400 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6401
6402 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6403 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6404 as passed in.
6405
6406 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6407
6408 * xterm.c (x_set_frame_alpha): Do not set property on anything
6409 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6410
6411 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6412
6413 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6414
6415 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6416
6417 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6418 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6419 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6420 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6421 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6422 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6423 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6424 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6425 (Qgnutls_bootprop_callbacks_verify): Make static.
6426
6427 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6428
6429 * callproc.c: Indentation fixup.
6430
6431 * sysdep.c (wait_for_termination_1): Make static.
6432 (wait_for_termination, interruptible_wait_for_termination):
6433 Move after wait_for_termination_1.
6434
6435 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6436
6437 * sysdep.c (interruptible_wait_for_termination): New function
6438 which is like wait_for_termination, but allows keyboard
6439 interruptions.
6440
6441 * callproc.c (Fcall_process): Add (:file "file") as an option for
6442 the STDOUT buffer.
6443 (Fcall_process_region): Ditto.
6444
6445 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6446
6447 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6448 rather than `XVECTOR (FOO)->size'.
6449
6450 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6451 inttypes.h, as a gnulib replacement is used if it not available in
6452 system headers.
6453
6454 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6455
6456 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6457 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6458 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6459
6460 * coding.c (coding_alloc_by_realloc): Error out if destination
6461 will grow beyond MOST_POSITIVE_FIXNUM.
6462 (decode_coding_emacs_mule): Abort if there isn't enough place in
6463 charbuf for the composition carryover bytes. Reserve an extra
6464 space for up to 2 characters produced in a loop.
6465 (decode_coding_iso_2022): Abort if there isn't enough place in
6466 charbuf for the composition carryover bytes.
6467
6468 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6469
6470 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6471 aborting when %lld or %lll format is passed.
6472 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6473 %llo or %llx format is passed. (Bug#8545)
6474
6475 * window.c (window_scroll_line_based): Use a marker instead of
6476 simple variables to record original value of point. (Bug#7952)
6477
6478 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6479 produced by %s or %c overflows available buffer space. (Bug#8545)
6480
6481 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6482
6483 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6484 (SIZE_MAX): Move defn after all includes, as they might #define it.
6485
6486 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6487
6488 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6489
6490 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6491
6492 * keyboard.c (Qdelayed_warnings_hook): Define.
6493 (command_loop_1): Run `delayed-warnings-hook'
6494 if Vdelayed_warnings_list is non-nil.
6495 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6496 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6497
6498 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6499
6500 * doprnt.c (doprnt): Don't return value smaller than the buffer
6501 size if the message was truncated. (Bug#8545).
6502
6503 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6506 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6507
6508 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6509
6510 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6511
6512 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * makefile.w32-in: Update dependencies.
6515
6516 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6517
6518 Improve `doprnt' and its usage. (Bug#8545)
6519 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6520 `format_end'. Remove support for %l as a conversion specifier.
6521 Don't use xrealloc. Improve diagnostics when the %l size modifier
6522 is used. Update the commentary.
6523
6524 * eval.c (verror): Simplify calculation of size_t.
6525
6526 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6527 messages.
6528
6529 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6530
6531 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6532 change.
6533
6534 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6535
6536 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6537 This makes this file independent of the recent pseudovector change.
6538
6539 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6540
6541 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6542
6543 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6544 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6545 Remove unused local.
6546 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6547
6548 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6549 GCC 4.6.0 optimizes based on type-based alias analysis.
6550 For example, if b is of type struct buffer * and v of type struct
6551 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6552 != &v->size, and therefore "v->size = 1; b->size = 2; return
6553 v->size;" must therefore return 1. This assumption is incorrect
6554 for Emacs, since it type-puns struct Lisp_Vector * with many other
6555 types. To fix this problem, this patch adds a new type struct
6556 vectorlike_header that documents the constraints on layout of vectors
6557 and pseudovectors, and helps optimizing compilers not get fooled
6558 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6559 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6560 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6561 the size member.
6562 (XSETPVECTYPE): Rewrite in terms of new macro.
6563 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6564 This is a bit clearer, and further avoids the possibility of
6565 undesirable aliasing.
6566 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6567 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6568 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6569 since Lisp_Subr is a special case (no "next" field).
6570 (ASIZE): Now uses header.size rather than size.
6571 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6572 to avoid the hassle of writing XVECTOR (foo)->header.size.
6573 (struct vectorlike_header): New type.
6574 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6575 object, to help avoid aliasing.
6576 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6577 (SUBRP): Likewise, since Lisp_Subr is a special case.
6578 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6579 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6580 (struct Lisp_Hash_Table): Combine first two members into a single
6581 struct vectorlike_header member. All uses of "size" and "next" members
6582 changed to be "header.size" and "header.next".
6583 * buffer.h (struct buffer): Likewise.
6584 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6585 * frame.h (struct frame): Likewise.
6586 * process.h (struct Lisp_Process): Likewise.
6587 * termhooks.h (struct terminal): Likewise.
6588 * window.c (struct save_window_data, struct saved_window): Likewise.
6589 * window.h (struct window): Likewise.
6590 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6591 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6592 * buffer.c (init_buffer_once): Likewise.
6593 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6594 special case.
6595 * process.c (Fformat_network_address): Use local var for size,
6596 for brevity.
6597
6598 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6599
6600 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6601 * data.c (atof): Remove decl; no longer used or needed.
6602 (digit_to_number): Move to lread.c.
6603 (Fstring_to_number): Use new string_to_number function, to be
6604 consistent with how the Lisp reader treats infinities and NaNs.
6605 Do not assume that floating-point numbers represent EMACS_INT
6606 without losing information; this is not true on most 64-bit hosts.
6607 Avoid double-rounding errors, by insisting on integers when
6608 parsing non-base-10 numbers, as the documentation specifies.
6609 * lisp.h (string_to_number): New decl, replacing ...
6610 (isfloat_string): Remove.
6611 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6612 (read1): Do not accept +. and -. as integers; this
6613 appears to have been a coding error. Similarly, do not accept
6614 strings like +-1e0 as floating point numbers. Do not report
6615 overflow for integer overflows unless the base is not 10 which
6616 means we have no simple and reliable way to continue.
6617 Break out the floating-point parsing into a new
6618 function string_to_number, so that Fstring_to_number parses
6619 floating point numbers consistently with the Lisp reader.
6620 (digit_to_number): Move here from data.c. Make it static inline.
6621 (E_CHAR, EXP_INT): Remove, replacing with ...
6622 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6623 (string_to_number): New function, replacing isfloat_string.
6624 This function checks for valid syntax and produces the resulting
6625 Lisp float number too. Rework it so that string-to-number
6626 no longer mishandles examples like "1.0e+". Use strtoumax,
6627 so that overflow for non-base-10 numbers is reported only when
6628 there's no portable and simple way to convert to floating point.
6629
6630 * textprop.c (set_text_properties_1): Rewrite for clarity,
6631 and to avoid GCC warning about integer overflow.
6632
6633 * intervals.h (struct interval): Use EMACS_INT for members
6634 where EMACS_UINT might cause problems. See
6635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6636 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6637 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6638 All uses changed.
6639 (offset_intervals): Tell GCC not to worry about length overflow
6640 when negating a negative length.
6641
6642 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6643 (overrun_check_free): Likewise.
6644
6645 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6646 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6647 word size.
6648
6649 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6650 (gnutls_make_error): Rename local to avoid shadowing.
6651 (gnutls_emacs_global_deinit): ifdef out; not used.
6652 (Fgnutls_boot): Use const for pointer to readonly storage.
6653 Comment out unused local. Fix pointer signedness problems.
6654
6655 * lread.c (openp): Don't stuff size_t into an 'int'.
6656 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6657 about possible signed overflow.
6658
6659 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6660 (GDK_KEY_g): Don't define if already defined.
6661 (xg_prepare_tooltip): Avoid pointer signedness problem.
6662 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6663
6664 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6665 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6666
6667 * xfns.c (Fx_window_property): Simplify a bit,
6668 to make a bit faster and to avoid GCC 4.6.0 warning.
6669 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6670
6671 * fns.c (internal_equal): Don't assume size_t fits in int.
6672
6673 * alloc.c (compact_small_strings): Tighten assertion a little.
6674
6675 Replace pEd with more-general pI, and fix some printf arg casts.
6676 * lisp.h (pI): New macro, generalizing old pEd macro to other
6677 conversion specifiers. For example, use "...%"pI"d..." rather
6678 than "...%"pEd"...".
6679 (pEd): Remove. All uses replaced with similar uses of pI.
6680 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6681 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6682 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6683 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6684 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6685 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6686 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6687 64-bit hosts.
6688 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6689 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6690 * print.c (safe_debug_print, print_object): Likewise.
6691 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6692 to int.
6693 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6694 avoiding the 0 flag, which is not portable.
6695 * process.c (Fmake_network_process): Use pI to avoid cast.
6696 * region-cache.c (pp_cache): Likewise.
6697 * xdisp.c (decode_mode_spec): Likewise.
6698 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6699 behavior on 64-bit hosts with printf arg.
6700 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6701 (x_stop_queuing_selection_requests): Likewise.
6702 (x_get_window_property): Don't truncate byte count to an 'int'
6703 when tracing.
6704
6705 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6706 here, since it parses constructs like leading '-' and spaces,
6707 which are not wanted; and it overflows with large numbers.
6708 Instead, simply match F[0-9]+, which is what is wanted anyway.
6709
6710 * alloc.c: Remove unportable assumptions about struct layout.
6711 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6712 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6713 (allocate_vectorlike, make_pure_vector): Use the new macros,
6714 plus offsetof, to remove unportable assumptions about struct layout.
6715 These assumptions hold on all porting targets that I know of, but
6716 they are not guaranteed, they're easy to remove, and removing them
6717 makes further changes easier.
6718
6719 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6720 This doesn't fix a bug but makes the code clearer.
6721 (string_overrun_cookie): Now const. Use initializers that
6722 don't formally overflow signed char, to avoid warnings.
6723 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6724 can cause Emacs to crash when string overrun checking is enabled.
6725 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6726 multiple of sizeof (EMACS_INT); it need not be, if
6727 alignof(EMACS_INT) < sizeof (EMACS_INT).
6728 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6729
6730 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6731
6732 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6733
6734 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6735
6736 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6737 supposed to be handshaking. (Bug#8556)
6738 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6739
6740 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6741
6742 * lisp.h (Qdebug): List symbol.
6743 * eval.c (Qdebug): Restore global linkage.
6744 * keyboard.c (debug-on-event): New variable.
6745 (handle_user_signal): Break into debugger when debug-on-event
6746 matches the current signal symbol.
6747
6748 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6749
6750 * alloc.c (check_sblock, check_string_bytes)
6751 (check_string_free_list): Convert to standard C.
6752
6753 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6754
6755 * w32.c (emacs_gnutls_push): Fix typo.
6756
6757 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6758
6759 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6760 "cast to pointer from integer of different size".
6761
6762 Improve doprnt and its use in verror. (Bug#8545)
6763 * doprnt.c (doprnt): Document the set of format control sequences
6764 supported by the function. Use SAFE_ALLOCA instead of always
6765 using `alloca'.
6766
6767 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6768 is one byte too soon. Don't use xrealloc; instead xfree and
6769 xmalloc anew.
6770
6771 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6772
6773 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6774 callbacks stage.
6775
6776 * gnutls.c: Renamed global_initialized to
6777 gnutls_global_initialized. Added internals for the
6778 :verify-hostname-error, :verify-error, and :verify-flags
6779 parameters of `gnutls-boot' and documented those parameters in the
6780 docstring. Start callback support.
6781 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6782 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6783 on error. Return error code.
6784 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6785 (emacs_gnutls_read): Likewise.
6786 (Fgnutls_boot): Return handshake error code.
6787 (emacs_gnutls_handle_error): New function.
6788 (wsaerror_to_errno): Likewise.
6789
6790 * w32.h (emacs_gnutls_pull): Add prototype.
6791 (emacs_gnutls_push): Likewise.
6792
6793 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6794 (emacs_gnutls_push): Likewise.
6795
6796 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6797
6798 * process.c (wait_reading_process_output): Check if GnuTLS
6799 buffered some data internally if no FDs are set for TLS
6800 connections.
6801
6802 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6803 (LIBS): Link to USER_LIBS.
6804 ($(BLD)/gnutls.$(0)): New target.
6805
6806 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6807
6808 * xdisp.c (handle_single_display_spec): Rename the
6809 display_replaced_before_p argument into display_replaced_p, to
6810 make it consistent with the commentary. Fix typos in the
6811 commentary.
6812
6813 * textprop.c (syms_of_textprop): Remove dead code.
6814 (copy_text_properties): Delete obsolete commentary about an
6815 interface that was deleted long ago. Fix typos in the description
6816 of arguments.
6817
6818 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6819 to changes in oldXMenu/XMenu.h from 2011-04-16.
6820 <menu_help_message, prev_menu_help_message>: Constify.
6821 (IT_menu_make_room): menu->help_text is now `const char **';
6822 adjust.
6823
6824 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6825 to changes in oldXMenu/XMenu.h from 2011-04-16.
6826 (struct XMenu): Declare `help_text' `const char **'.
6827
6828 * xfaces.c <Qunspecified>: Make extern again.
6829
6830 * syntax.c: Include sys/types.h before including regex.h, as
6831 required by Posix.
6832
6833 * doc.c (get_doc_string): Improve the format passed to `error'.
6834
6835 * doprnt.c (doprnt): Improve commentary.
6836
6837 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6838
6839 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6840 them with etags.
6841
6842 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6843 changes in globals.h immediately force recompilation.
6844 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6845 $(CURDIR)/s/ms-w32.h.
6846 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6847
6848 * character.c (Fchar_direction): Function deleted.
6849 (syms_of_character): Don't defsubr it.
6850 <char-direction-table>: Deleted.
6851
6852 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6853
6854 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6855 * doprnt.c: Include limits.h.
6856 (SIZE_MAX): New macro.
6857 (doprnt): Return a size_t value. 2nd arg is now size_t.
6858 Many local variables are now size_t instead of int or unsigned.
6859 Improve overflow protection. Support `l' modifier for integer
6860 conversions. Support %l conversion. Don't assume an EMACS_INT
6861 argument for integer conversions and for %c.
6862
6863 * lisp.h (doprnt): Restore prototype.
6864
6865 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6866 $(SRC)/character.h.
6867
6868 * Makefile.in (base_obj): Add back doprnt.o.
6869
6870 * deps.mk (doprnt.o): Add back prerequisites.
6871 (callint.o): Depend on character.h.
6872
6873 * eval.c (internal_lisp_condition_case): Include the handler
6874 representation in the error message.
6875 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6876 when breaking from the loop.
6877
6878 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6879
6880 * callint.c (Fcall_interactively): When displaying error message
6881 about invalid control letter, pass the character's codepoint, not
6882 a pointer to its multibyte form. Improve display of the character
6883 in octal and display also its hex code.
6884
6885 * character.c (char_string): Use %x to display the (unsigned)
6886 codepoint of an invalid character, to avoid displaying a bogus
6887 negative value.
6888
6889 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6890 `error', not SYMBOL_NAME itself.
6891
6892 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6893 character arguments to `error'.
6894
6895 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6896 to `error' in error message about FINAL_CHAR argument. Make sure
6897 FINAL_CHAR is a character, and use %c when it is passed as
6898 argument to `error'.
6899
6900 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6901
6902 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6903
6904 * w32.c: Include <time.h>.
6905 (sys_localtime): New function.
6906
6907 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6908
6909 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6910
6911 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6912
6913 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6914
6915 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6916 zombies (Bug#8467).
6917
6918 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6919
6920 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6921 gl_state.e_property when gl_state.object is Qt.
6922
6923 * insdel.c (make_gap_larger): Remove limitation of buffer size
6924 to <= INT_MAX.
6925
6926 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6927
6928 * xdisp.c (lookup_glyphless_char_display)
6929 (produce_glyphless_glyph): Handle cons cell entry in
6930 glyphless-char-display.
6931 (Vglyphless_char_display): Document it.
6932
6933 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6934 glyphless-char-display.
6935
6936 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6937
6938 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6939
6940 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6941
6942 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6943 definition for no-X builds.
6944
6945 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6946
6947 Static checks with GCC 4.6.0 and non-default toolkits.
6948
6949 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6950
6951 * process.c (keyboard_bit_set): Define only if SIGIO.
6952 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6953 (send_process): Repair possible setjmp clobbering.
6954
6955 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6956
6957 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6958
6959 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6960
6961 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6962 Define only if needed.
6963
6964 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6965 by pacifying GCC about it. Maybe it's time to retire it?
6966 * xfaces.c (USG, __TIMEVAL__): Likewise.
6967
6968 * dispextern.h (struct redisplay_interface): Rename param
6969 to avoid shadowing.
6970 * termhooks.h (struct terminal): Likewise.
6971 * xterm.c (xembed_send_message): Likewise.
6972
6973 * insdel.c (make_gap_smaller): Define only if
6974 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6975
6976 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6977 it.
6978
6979 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6980 so that we aren't warned about unused symbols.
6981
6982 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6983
6984 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6985
6986 * xfns.c (x_real_positions): Mark locals as initialized.
6987
6988 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6989
6990 * xterm.c: Fix problems found by static analysis with other toolkits.
6991 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6992 (x_dispatch_event): Declare static if USE_GTK, and
6993 define if USE_GTK || USE_X_TOOLKIT.
6994 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6995 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6996 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6997 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6998
6999 * xmenu.c (menu_help_callback): Pointer type fixes.
7000 Use const pointers when pointing at readonly data. Avoid pointer
7001 signedness clashes.
7002 (FALSE): Remove unused macro.
7003 (update_frame_menubar): Remove unused decl.
7004
7005 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7006
7007 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7008 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7009 (single_menu_item): Rename local to avoid shadowing.
7010
7011 * keyboard.c (make_lispy_event): Remove unused local var.
7012
7013 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7014 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7015
7016 * bitmaps: Change bitmaps from unsigned char back to the X11
7017 compatible char. Avoid the old compiler warnings about
7018 out-of-range initializers by using, for example, '\xab' rather
7019 than 0xab.
7020
7021 * xgselect.c (xgselect_initialize): Check vs interface
7022 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7023
7024 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7025
7026 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7027 to read-only memory.
7028
7029 * fns.c (vector): Remove; this old hack is no longer needed.
7030
7031 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7032 Remove unused var.
7033 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7034
7035 * xrdb.c (x_load_resources): Omit unused local.
7036
7037 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7038 (x_window): Rename locals to avoid shadowing.
7039 (USG): Use the kludged USG macro, to pacify gcc.
7040
7041 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7042 (x_term_init): Remove local to avoid shadowing.
7043
7044 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7045
7046 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7047 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7048
7049 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7050
7051 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7052
7053 Fix regex.c, syntax.c and friends for buffers > 2GB.
7054 * syntax.h (struct gl_state_s): Declare character position members
7055 EMACS_INT.
7056
7057 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7058
7059 * textprop.c (verify_interval_modification, interval_of):
7060 Declare arguments EMACS_INT.
7061
7062 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7063 EMACS_INT.
7064
7065 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7066
7067 * indent.c (Fvertical_motion): Local variable it_start is now
7068 EMACS_INT.
7069
7070 * regex.c (re_match, re_match_2, re_match_2_internal)
7071 (bcmp_translate, regcomp, regexec, print_double_string)
7072 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7073 (re_compile_pattern, re_exec): Declare arguments and local
7074 variables `size_t' and `ssize_t' and return values `regoff_t', as
7075 appropriate.
7076 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7077 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7078 <compile_stack_type>: `size' and `avail' are now `size_t'.
7079
7080 * regex.h <regoff_t>: Use ssize_t, not int.
7081 (re_search, re_search_2, re_match, re_match_2): Arguments that
7082 specify buffer/string position and length are now ssize_t and
7083 size_t. Return type is regoff_t.
7084
7085 2011-04-16 Ben Key <bkey76@gmail.com>
7086
7087 * nsfont.m: Fixed bugs in ns_get_family and
7088 ns_descriptor_to_entity that were caused by using free to
7089 deallocate memory blocks that were allocated by xmalloc (via
7090 xstrdup). This caused Emacs to crash when compiled with
7091 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7092 --enable-checking=xmallocoverrun). xfree is now used to
7093 deallocate these memory blocks.
7094
7095 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7096
7097 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7098
7099 emacs_write: Accept and return EMACS_INT for sizes.
7100 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7101 et seq.
7102 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7103 Accept and return EMACS_INT.
7104 (emacs_gnutls_write): Return the number of bytes written on
7105 partial writes.
7106 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7107 (emacs_read, emacs_write): Remove check for negative size, as the
7108 Emacs source code has been audited now.
7109 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7110 (emacs_read, emacs_write): Use it.
7111 * process.c (send_process): Adjust to the new signatures of
7112 emacs_write and emacs_gnutls_write. Do not attempt to store
7113 a byte offset into an 'int'; it might overflow.
7114 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7115
7116 * sound.c: Don't assume sizes fit in 'int'.
7117 (struct sound_device.period_size, alsa_period_size):
7118 Return EMACS_INT, not int.
7119 (struct sound_device.write, vox_write, alsa_write):
7120 Accept EMACS_INT, not int.
7121 (wav_play, au_play): Use EMACS_INT to store sizes and to
7122 record read return values.
7123
7124 2011-04-15 Ben Key <bkey76@gmail.com>
7125
7126 * keyboard.c (Qundefined): Don't declare static since it is used
7127 in nsfns.m.
7128 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7129 static since they are used in nsfont.m.
7130
7131 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7132
7133 * process.c (Qprocessp): Don't declare static.
7134 * lisp.h (Qprocessp): Declare again.
7135
7136 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7137
7138 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7139
7140 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7141
7142 Improve C-level modularity by making more things 'static'.
7143
7144 Don't publish debugger-only interfaces to other modules.
7145 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7146 (verify_bytepos, count_markers): Move decls to the only modules
7147 that need them.
7148 * region-cache.h (pp_cache): Likewise.
7149 * window.h (check_all_windows): Likewise.
7150 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7151
7152 * sysdep.c (croak): Now static, if
7153 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7154 * syssignal.h (croak): Declare only if not static.
7155
7156 * alloc.c (refill_memory_reserve): Now static if
7157 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7158 * lisp.h (refill_memory_reserve): Declare only if not static.
7159
7160 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7161 Define only if USE_LUCID.
7162
7163 * xrdb.c (x_customization_string, x_rm_string): Now static.
7164
7165 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7166 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7167
7168 * xdisp.c (draw_row_with_mouse_face): Now static.
7169 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7170
7171 * window.h (check_all_windows): Mark externally visible.
7172
7173 * window.c (window_deletion_count): Now static.
7174
7175 * undo.c: Make symbols static if they're not exported.
7176 (last_undo_buffer, last_boundary_position, pending_boundary):
7177 Now static.
7178
7179 * textprop.c (interval_insert_behind_hooks): Now static.
7180 (interval_insert_in_front_hooks): Likewise.
7181
7182 * term.c: Make symbols static if they're not exported.
7183 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7184 (max_frame_lines, tty_set_terminal_modes):
7185 (tty_reset_terminal_modes, tty_turn_off_highlight):
7186 (get_tty_terminal): Now static.
7187 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7188 * termhooks.h (term_mouse_moveto): Do not declare if
7189 HAVE_WINDOW_SYSTEM.
7190 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7191 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7192
7193 * sysdep.c: Make symbols static if they're not exported.
7194 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7195 Now static.
7196 (sigprocmask_set, full_mask): Remove; unused.
7197 (wait_debugging): Mark as visible.
7198 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7199 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7200
7201 * syntax.c (syntax_temp): Define only if !__GNUC__.
7202
7203 * sound.c (current_sound_device, current_sound): Now static.
7204
7205 * search.c (searchbufs, searchbuf_head): Now static.
7206
7207 * scroll.c (scroll_cost): Remove; unused.
7208 * dispextern.h (scroll_cost): Remove decl.
7209
7210 * region-cache.h (pp_cache): Mark as externally visible.
7211
7212 * process.c: Make symbols static if they're not exported.
7213 (process_tick, update_tick, create_process, chan_process):
7214 (Vprocess_alist, proc_buffered_char, datagram_access):
7215 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7216 (deactivate_process): Mark defn as static, as well as decl.
7217 * lisp.h (create_process): Remove decl.
7218 * process.h (chan_process, Vprocess_alist): Remove decls.
7219
7220 * print.c: Make symbols static if they're not exported.
7221 (print_depth, new_backquote_output, being_printed, print_buffer):
7222 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7223 (print_interval, print_number_index, initial_stderr_stream):
7224 Now static.
7225 * lisp.h (Fprinc): Remove decl.
7226 (debug_output_compilation_hack): Mark as externally visible.
7227
7228 * sysdep.c (croak): Move decl from here to syssignal.h.
7229 * syssignal.h (croak): Put it here, so the API can be checked when
7230 'croak' is called from dissociate_if_controlling_tty.
7231
7232 * minibuf.c: Make symbols static if they're not exported.
7233 (minibuf_save_list, choose_minibuf_frame): Now static.
7234 * lisp.h (choose_minibuf_frame): Remove decl.
7235
7236 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7237
7238 * lread.c: Make symbols static if they're not exported.
7239 (read_objects, initial_obarray, oblookup_last_bucket_number):
7240 Now static.
7241 (make_symbol): Remove; unused.
7242 * lisp.h (initial_obarray, make_symbol): Remove decls.
7243
7244 * keyboard.c: Make symbols static if they're not exported.
7245 (single_kboard, recent_keys_index, total_keys, recent_keys):
7246 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7247 (this_single_command_key_start, echoing, last_auto_save):
7248 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7249 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7250 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7251 (Vlispy_mouse_stem, double_click_count):
7252 Now static.
7253 (force_auto_save_soon): Define only if SIGDANGER.
7254 (ignore_mouse_drag_p): Now static if
7255 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7256 (print_help): Remove; unused.
7257 (stop_character, last_timer_event): Mark as externally visible.
7258 * keyboard.h (ignore_mouse_drag_p): Declare only if
7259 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7260 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7261 * lisp.h (echoing): Remove decl.
7262 (force_auto_save_soon): Declare only if SIGDANGER.
7263 * xdisp.c (redisplay_window): Simplify code, to make it more
7264 obvious that ignore_mouse_drag_p is not accessed if !defined
7265 USE_GTK && !defined HAVE_NS.
7266
7267 * intervals.c: Make symbols static if they're not exported.
7268 (merge_properties_sticky, merge_interval_right, delete_interval):
7269 Now static.
7270 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7271
7272 * insdel.c: Make symbols static if they're not exported.
7273 However, leave prepare_to_modify_buffer alone. It's never
7274 called from outside this function, but that appears to be a bug.
7275 (combine_after_change_list, combine_after_change_buffer):
7276 (adjust_after_replace, signal_before_change): Now static.
7277 (adjust_after_replace_noundo): Remove; unused.
7278 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7279 (signal_before_change): Remove decls.
7280
7281 * indent.c (val_compute_motion, val_vmotion): Now static.
7282
7283 * image.c: Make symbols static if they're not exported.
7284 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7285 if USE_GTK.
7286 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7287 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7288
7289 * fringe.c (standard_bitmaps): Now static.
7290 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7291
7292 * frame.c: Make symbols static if they're not exported.
7293 (x_report_frame_params, make_terminal_frame): Now static.
7294 (get_frame_param): Now static, unless HAVE_NS.
7295 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7296 (x_get_resource_string): Remove; not used.
7297 * frame.h (make_terminal_frame, x_report_frame_params):
7298 (x_get_resource_string); Remove decls.
7299 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7300 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7301
7302 * font.c, fontset.c: Make symbols static if they're not exported.
7303 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7304 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7305 * font.c (font_close_object): Now static.
7306 * font.h (font_close_object): Remove.
7307 * fontset.c (FONTSET_OBJLIST): Remove.
7308 (free_realized_fontset) #if-0 the body, which does nothing.
7309 (face_suitable_for_char_p): #if-0, as it's never called.
7310 * fontset.h (face_suitable_for_char_p): Remove decl.
7311 * xfaces.c (face_at_string_position):
7312 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7313 since 0 is always ASCII.
7314
7315 * fns.c (weak_hash_tables): Now static.
7316
7317 * fileio.c: Make symbols static if they're not exported.
7318 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7319 (Vwrite_region_annotation_buffers): Now static.
7320
7321 * eval.c: Make symbols static if they're not exported.
7322 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7323 * lisp.h (backtrace_list): Remove decl.
7324
7325 * emacs.c: Make symbols static if they're not exported.
7326 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7327 (fatal_error_code, fatal_error_signal_hook, standard_args):
7328 Now static.
7329 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7330 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7331 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7332 * lisp.h (fatal_error_signal_hook): Remove decl.
7333 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7334
7335 * editfns.c: Move a (normally-unused) function to its only use.
7336 * editfns.c, lisp.h (get_operating_system_release): Remove.
7337 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7338 worth the hassle of breaking this out.
7339
7340 * xterm.c: Make symbols static if they're not exported.
7341 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7342 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7343 (x_destroy_window, x_delete_display):
7344 Now static.
7345 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7346 (x_mouse_leave): Remove; unused.
7347 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7348 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7349 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7350 Remove decls.
7351 (x_mouse_leave): Declare only if WINDOWSNT.
7352 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7353 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7354 USE_X_TOOLKIT.
7355
7356 * ftxfont.c: Make symbols static if they're not exported.
7357 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7358 HAVE_FREETYPE.
7359 * font.h (ftxfont_driver): Likewise.
7360
7361 * xfns.c: Make symbols static if they're not exported.
7362 (x_last_font_name, x_display_info_for_name):
7363 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7364 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7365 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7366 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7367 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7368 (last_show_tip_args): Now static.
7369 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7370 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7371 (x_screen_planes): Remove; unused.
7372 * dispextern.h (x_screen_planes): Remove decl.
7373
7374 * dispnew.c: Make symbols static if they're not exported.
7375 * dispextern.h (redraw_garbaged_frames, scrolling):
7376 (increment_row_positions): Remove.
7377 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7378 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7379 Now static.
7380 (redraw_garbaged_frames): Remove; unused.
7381
7382 * xfaces.c: Make symbols static if they're not exported.
7383 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7384 Remove decls.
7385 * xterm.h (defined_color): Remove decls.
7386 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7387 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7388 (menu_face_changed_default, defined_color, free_realized_face):
7389 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7390 (ascii_face_of_lisp_face): Remove; unused.
7391
7392 * xdisp.c: Make symbols static if they're not exported.
7393 * dispextern.h (scratch_glyph_row, window_box_edges):
7394 (glyph_to_pixel_coords, set_cursor_from_row):
7395 (get_next_display_element, set_iterator_to_next):
7396 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7397 (show_mouse_face): Remove decls
7398 * frame.h (message_buf_print): Likewise.
7399 * lisp.h (pop_message, set_message, check_point_in_composition):
7400 Likewise.
7401 * xterm.h (set_vertical_scroll_bar): Likewise.
7402 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7403 (message_buf_print, scratch_glyph_row, displayed_buffer):
7404 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7405 (get_next_display_element, show_mouse_face, window_box_edges):
7406 (frame_to_window_pixel_xy, check_point_in_composition):
7407 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7408 (glyph_to_pixel_coords): Remove; unused.
7409
7410 * dired.c (file_name_completion): Now static.
7411
7412 * dbusbind.c (xd_in_read_queued_messages): Now static.
7413
7414 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7415 * data.c (circular_list_error): Remove.
7416
7417 * commands.h (last_point_position, last_point_position_buffer):
7418 (last_point_position_window): Remove decls.
7419 * keyboard.c: Make these variables static.
7420
7421 * coding.h (coding, code_convert_region, encode_coding_gap):
7422 Remove decls.
7423 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7424 (iso_code_class, detect_coding, code_convert_region): Now static.
7425 (encode_coding_gap): Remove; unused.
7426
7427 * chartab.c (chartab_chars, chartab_bits): Now static.
7428
7429 * charset.h (charset_iso_8859_1): Remove decl.
7430 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7431 Now static.
7432
7433 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7434 * ccl.c (Vccl_program_table): Now static.
7435 (check_ccl_update): Remove; unused.
7436
7437 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7438 * category.h: ... from here.
7439 * category.c (check_category_table, set_category_set): Now static.
7440
7441 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7442 * lisp.h: Remove these decls.
7443
7444 * buffer.c (buffer_count): Remove unused var.
7445
7446 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7447 so that it's not optimized away.
7448 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7449 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7450 exported only to the debugger.
7451
7452 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7453 * atimer.h (run_all_atimers): Remove; not exported.
7454
7455 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7456 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7457 was inaccessible from Lisp.
7458 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7459 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7460
7461 alloc.c: Import and export fewer symbols, and remove unused items.
7462 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7463 is defined.
7464 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7465 it's not optimized away by whole-program optimization.
7466 (message_enable_multibyte, free_misc): Remove.
7467 (catchlist, handlerlist, mark_backtrace):
7468 Declare only if BYTE_MARK_STACK.
7469 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7470 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7471 (message_enable_multibyte): Remove decl.
7472 (free_misc, interval_free_list, float_block, float_block_index):
7473 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7474 (cons_free_list, last_marked_index):
7475 Now static.
7476 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7477 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7478 (mark_backtrace): Define only if BYTE_MARK_STACK.
7479 * xdisp.c (message_enable_multibyte): Now static.
7480
7481 Declare Lisp_Object Q* variables to be 'static' if not exported.
7482 This makes it easier for human readers (and static analyzers)
7483 to see whether these variables are used from other modules.
7484 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7485 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7486 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7487 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7488 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7489 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7490 * xmenu.c, xselect.c:
7491 Declare Q* vars static if they are not used in other modules.
7492 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7493 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7494 Remove decls of unexported vars.
7495 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7496
7497 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7498
7499 Make Emacs functions such as Fatom 'static' by default.
7500 This makes it easier for human readers (and static analyzers)
7501 to see whether these functions can be called from other modules.
7502 DEFUN now defines a static function. To make the function external
7503 so that it can be used in other C modules, use the new macro DEFUE.
7504 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7505 (Finit_image_library):
7506 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7507 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7508 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7509 Remove decls, since these functions are now static.
7510 (Funintern, Fget_internal_run_time): New decls, since these functions
7511 were already external.
7512
7513 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7514 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7515 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7516 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7517 * keyboard.c, keymap.c, lread.c:
7518 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7519 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7520 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7521 Mark functions with DEFUE instead of DEFUN,
7522 if they are used in other modules.
7523 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7524 decls for now-static functions.
7525 * buffer.h (Fdelete_overlay): Remove decl.
7526 * callproc.c (Fgetenv_internal): Mark as internal.
7527 * composite.c (Fremove_list_of_text_properties): Remove decl.
7528 (Fcomposition_get_gstring): New forward static decl.
7529 * composite.h (Fcomposite_get_gstring): Remove decl.
7530 * dired.c (Ffile_attributes): New forward static decl.
7531 * doc.c (Fdocumntation_property): New forward static decl.
7532 * eval.c (Ffetch_bytecode): New forward static decl.
7533 (Funintern): Remove extern decl; now in .h file where it belongs.
7534 * fileio.c (Fmake_symbolic_link): New forward static decl.
7535 * image.c (Finit_image_library): New forward static decl.
7536 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7537 * intervals.h (Fprevious_property_change):
7538 (Fremove_list_of_text_properties): Remove decls.
7539 * keyboard.c (Fthis_command_keys): Remove decl.
7540 (Fcommand_execute): New forward static decl.
7541 * keymap.c (Flookup_key): New forward static decl.
7542 (Fcopy_keymap): Now static.
7543 * keymap.h (Flookup_key): Remove decl.
7544 * process.c (Fget_process): New forward static decl.
7545 (Fprocess_datagram_address): Mark as internal.
7546 * syntax.c (Fsyntax_table_p): New forward static decl.
7547 (skip_chars): Remove duplicate decl.
7548 * textprop.c (Fprevious_property_change): New forward static decl.
7549 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7550 Now internal.
7551 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7552 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7553
7554 * editfns.c (Fformat): Remove unreachable code.
7555
7556 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7557
7558 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7559 change. (Bug#8496)
7560
7561 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7562
7563 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7564 when at ZV. (Bug#8487)
7565
7566 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7567
7568 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7569 (Bug#8437)
7570 * keyboard.c (parse_tool_bar_item): Likewise.
7571 * sound.c (sound_cleanup, alsa_close): Likewise.
7572 * termcap.c (tgetent): Likewise.
7573 * xfns.c (x_default_font_parameter): Likewise.
7574 * xsettings.c (read_and_apply_settings): Likewise.
7575
7576 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7577 (overrun_check_free): Protoize.
7578
7579 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7580
7581 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7582 since callers should never pass a negative size.
7583 Change the signature to match that of plain 'read' and 'write'; see
7584 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7585 * lisp.h: Update prototypes of emacs_write and emacs_read.
7586
7587 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7588
7589 * xdisp.c (redisplay_window): Don't try to determine the character
7590 position of the scroll margin if the window start point w->startp
7591 is outside the buffer's accessible region. (Bug#8468)
7592
7593 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7594
7595 Fix write-region and its subroutines for buffers > 2GB.
7596 * fileio.c (a_write, e_write): Modify declaration of arguments and
7597 local variables to support buffers larger than 2GB.
7598 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7599
7600 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7601 argument, local variables, and return value.
7602
7603 * lisp.h: Update prototypes of emacs_write and emacs_read.
7604
7605 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7606
7607 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7608
7609 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7610
7611 Fix more problems found by GCC 4.6.0's static checks.
7612
7613 * xdisp.c (vmessage): Use a better test for character truncation.
7614
7615 * charset.c (load_charset_map): <, not <=, for optimization,
7616 and to avoid potential problems with integer overflow.
7617 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7618 * casetab.c (set_identity, shuffle): Likewise.
7619 * editfns.c (Fformat): Likewise.
7620 * syntax.c (skip_chars): Likewise.
7621
7622 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7623 This also lets GCC 4.6.0 generate slightly better loop code.
7624
7625 * callint.c (Fcall_interactively): <, not <=, for optimization.
7626 (Fcall_interactively): Count the number of arguments produced,
7627 not the number of arguments given. This is simpler and lets GCC
7628 4.6.0 generate slightly better code.
7629
7630 * ftfont.c: Distingish more carefully between FcChar8 and char.
7631 The previous code passed unsigned char * to a functions like
7632 strlen and xstrcasecmp that expect char *, which does not
7633 conform to the C standard.
7634 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7635 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7636 char * when the C standard requires it.
7637
7638 * keyboard.c (read_char): Remove unused var.
7639
7640 * eval.c: Port to Windows vsnprintf (Bug#8435).
7641 Include <limits.h>.
7642 (SIZE_MAX): Define if the headers do not.
7643 (verror): Do not give up if vsnprintf returns a negative count.
7644 Instead, grow the buffer. This ports to Windows vsnprintf, which
7645 does not conform to C99. Problem reported by Eli Zaretskii.
7646 Also, simplify the allocation scheme, by avoiding the need for
7647 calling realloc, and removing the ALLOCATED variable.
7648
7649 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7650
7651 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7652 But keep the doprint source code for now, as we might revamp it
7653 and use it again (Bug#8435).
7654 * lisp.h (doprnt): Remove.
7655 * Makefile.in (base_obj): Remove doprnt.o.
7656 * deps.mk (doprnt.o): Remove.
7657
7658 error: Print 32- and 64-bit integers portably (Bug#8435).
7659 Without this change, on typical 64-bit hosts error ("...%d...", N)
7660 was used to print both 32- and 64-bit integers N, which relied on
7661 undefined behavior.
7662 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7663 New macro.
7664 * lisp.h (error, verror): Mark as printf-like functions.
7665 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7666 Report overflow in size calculations when allocating printf buffer.
7667 Do not truncate output string at its first null byte.
7668 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7669 Truncate the output at a character boundary, since vsnprintf does not
7670 do that.
7671 * charset.c (check_iso_charset_parameter): Convert internal
7672 character to string before calling 'error', since %c now has the
7673 printf meaning.
7674 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7675 overflow when computing char to be passed to 'error'. Do not
7676 pass Lisp_Object to 'error'; pass the integer instead.
7677 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7678 formatted with plain %d.
7679
7680 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7681
7682 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7683
7684 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7685
7686 * xterm.c (x_catch_errors): Remove duplicate declaration.
7687
7688 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7689
7690 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7691
7692 2011-04-10 Jim Meyering <meyering@redhat.com>
7693
7694 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7695 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7696 return ssize_t not "int", and use size_t as the buffer length.
7697 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7698 * gnutls.h: Update declarations.
7699 * process.c (read_process_output): Use ssize_t, to match.
7700 (send_process): Likewise.
7701
7702 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7703
7704 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7705
7706 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7707
7708 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7709 Use unsigned char, to match FcChar8 type definition.
7710
7711 * xterm.c (handle_one_xevent):
7712 * xmenu.c (create_and_show_popup_menu):
7713 * xselect.c (x_decline_selection_request)
7714 (x_reply_selection_request): Avoid type-punned deref of X events.
7715
7716 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7717
7718 Fix some uses of `int' instead of EMACS_INT.
7719 * search.c (string_match_1, fast_string_match)
7720 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7721 (scan_buffer, find_next_newline_no_quit)
7722 (find_before_next_newline, search_command, Freplace_match)
7723 (Fmatch_data): Make some `int' variables be EMACS_INT.
7724
7725 * xdisp.c (display_count_lines): 3rd argument and return value now
7726 EMACS_INT. All callers changed.
7727 (pint2hrstr): Last argument is now EMACS_INT.
7728
7729 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7730 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7731 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7732 (decode_coding_utf_16, decode_coding_emacs_mule)
7733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7734 (decode_coding_ccl, decode_coding_charset)
7735 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7736 (decode_coding_iso_2022, decode_coding_emacs_mule)
7737 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7738 <char_offset, last_offset>: Declare EMACS_INT.
7739 (encode_coding_utf_8, encode_coding_utf_16)
7740 (encode_coding_emacs_mule, encode_invocation_designation)
7741 (encode_designation_at_bol, encode_coding_iso_2022)
7742 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7743 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7744 Declare EMACS_INT.
7745 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7746 (encode_invocation_designation): Last argument P_NCHARS is now
7747 EMACS_INT.
7748 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7749 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7750
7751 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7752 All users changed.
7753
7754 * ccl.c (Fccl_execute_on_string): Declare some variables
7755 EMACS_INT.
7756
7757 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7758
7759 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7760
7761 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7762
7763 * process.c (Fformat_network_address): Doc fix.
7764
7765 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7766
7767 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7768
7769 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7770
7771 * keyboard.c (read_char): Call Lisp function help-form-show,
7772 instead of using internal_with_output_to_temp_buffer.
7773 (Qhelp_form_show): New var.
7774 (syms_of_keyboard): Use DEFSYM macro.
7775
7776 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7777
7778 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7779
7780 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7781
7782 * process.c (Flist_processes): Remove to Lisp.
7783 (list_processes_1): Delete.
7784
7785 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7786
7787 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7788
7789 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7790
7791 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 Fix more problems found by GCC 4.6.0's static checks.
7794
7795 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7796
7797 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7798
7799 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7800
7801 * xdisp.c (vmessage): Mark as a printf-like function.
7802
7803 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7804
7805 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7806
7807 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7808 printf-like functions.
7809 (tiff_load): Add casts to remove these marks before passing them
7810 to system-supplied API.
7811
7812 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7813
7814 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7815 This avoids several warnings with gcc -Wstrict-overflow.
7816 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7817 directly, rather than having caller test rule sign. This avoids
7818 some unnecessary tests.
7819 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7820 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7821 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7822
7823 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7824 (xfont_open): Avoid unnecessary tests.
7825
7826 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7827
7828 * composite.h, composite.c (composition_gstring_put_cache):
7829 Use EMACS_INT, not int, for length.
7830
7831 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7832 breaking out part of COMPOSITION_DECODE_RULE.
7833 (COMPOSITION_DECODE_RULE): Use it.
7834 * composite.c (get_composition_id): Remove unused local vars,
7835 by using the new macro.
7836
7837 * textprop.c (set_text_properties_1): Change while to do-while,
7838 since the condition is always true at first.
7839
7840 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7841 (interval_deletion_adjustment): Return unsigned value.
7842 All uses changed.
7843
7844 * process.c (list_processes_1, create_pty, read_process_output):
7845 (exec_sentinel): Remove vars that were set but not used.
7846 (create_pty): Remove unnecessary "volatile"s.
7847 (Fnetwork_interface_info): Avoid possibility of int overflow.
7848 (read_process_output): Do adaptive read buffering even if carryover.
7849 (read_process_output): Simplify nbytes computation if buffered.
7850
7851 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7852
7853 * syntax.c (scan_words): Remove var that was set but not used.
7854 (update_syntax_table): Use unsigned instead of int.
7855
7856 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7857 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7858 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7859
7860 * print.c (print_error_message): Avoid int overflow.
7861
7862 * font.c (font_list_entities): Redo for clarity,
7863 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7864
7865 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7866 (font_score): Avoid potential overflow in diff calculation.
7867
7868 * fns.c (substring_both): Remove var that is set but not used.
7869 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7870
7871 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7872
7873 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7874 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7875 can always succeed if overflow has undefined behavior.
7876
7877 * search.c (boyer_moore, wordify): Remove vars set but not used.
7878 (wordify): Omit three unnecessary tests.
7879
7880 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7881 All callers changed. This avoids the need for an unused var.
7882
7883 * casefiddle.c (casify_region): Remove var that is set but not used.
7884
7885 * dired.c (file_name_completion): Remove var that is set but not used.
7886
7887 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7888
7889 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7890 (Finsert_file_contents): Remove unnecessary code checking fd.
7891
7892 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7893 Check for integer overflow on size calculations.
7894
7895 * buffer.c (Fprevious_overlay_change): Remove var that is set
7896 but not used.
7897
7898 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7899 Remove vars that are set but not used.
7900 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7901 (timer_check_2): Mark vars as initialized.
7902
7903 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7904
7905 * image.c (lookup_image): Remove var that is set but not used.
7906 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7907
7908 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7909 that are set but not used.
7910
7911 * xfns.c (make_invisible_cursor): Don't return garbage
7912 if XCreateBitmapFromData fails (Bug#8410).
7913
7914 * xselect.c (x_get_local_selection, x_handle_property_notify):
7915 Remove vars that are set but not used.
7916
7917 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7918 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7919
7920 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7921 Remove var that is set but not used.
7922 (scroll_bar_windows_size): Now size_t, not int.
7923 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7924 Check for overflow.
7925
7926 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7927 (map_tty_color) [!defined MSDOS]: Likewise.
7928
7929 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7930
7931 * coding.c: Remove vars that are set but not used.
7932 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7933 All callers changed.
7934 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7935 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7936 (decode_coding_charset): Remove vars that are set but not used.
7937
7938 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7939 that is set but not used.
7940
7941 * print.c (print_object): Remove var that is set but not used.
7942
7943 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7944 The gnulib version avoids calling malloc in the usual case,
7945 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7946 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7947 * filelock.c (current_lock_owner): Likewise.
7948 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7949 * sysdep.c: Include allocator.h, careadlinkat.h.
7950 (emacs_no_realloc_allocator): New static constant.
7951 (emacs_readlink): New function.
7952 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7953 ../lib/careadlinkat.h.
7954
7955 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7956
7957 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7958 first non-nil return value).
7959
7960 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7961
7962 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7963 if not defined (Bug#8403).
7964
7965 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7966
7967 * xdisp.c (display_count_lines): Remove parameter `start',
7968 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7969 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7970 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7971 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7972 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7973 and thereabouts. All callers changed.
7974 (get_per_char_metric): Remove parameter `f', unused since
7975 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7976
7977 2011-04-02 Jim Meyering <meyering@redhat.com>
7978
7979 do not dereference NULL upon failed strdup
7980 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7981 (ns_get_family): Likewise.
7982
7983 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7984
7985 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7986
7987 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7988
7989 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7990 later (Bug#8403).
7991
7992 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7993
7994 Add lexical binding.
7995
7996 * window.c (Ftemp_output_buffer_show): New fun.
7997 (Fsave_window_excursion):
7998 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7999
8000 * lread.c (lisp_file_lexically_bound_p): New function.
8001 (Fload): Bind Qlexical_binding.
8002 (readevalloop): Remove `evalfun' arg.
8003 Bind Qinternal_interpreter_environment.
8004 (Feval_buffer): Bind Qlexical_binding.
8005 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8006 Mark as dynamic.
8007 (syms_of_lread): Declare `lexical-binding'.
8008
8009 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8010
8011 * keyboard.c (eval_dyn): New fun.
8012 (menu_item_eval_property): Use it.
8013
8014 * image.c (parse_image_spec): Use Ffunctionp.
8015
8016 * fns.c (concat, mapcar1): Accept byte-code-functions.
8017
8018 * eval.c (Fsetq): Handle lexical vars.
8019 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8020 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8021 (FletX, Flet): Obey lexical binding.
8022 (Fcommandp): Handle closures.
8023 (Feval): New `lexical' arg.
8024 (eval_sub): New function extracted from Feval. Use it almost
8025 everywhere where Feval was used. Look up vars in lexical env.
8026 Handle closures.
8027 (Ffunctionp): Move from subr.el.
8028 (Ffuncall): Handle closures.
8029 (apply_lambda): Remove `eval_flags'.
8030 (funcall_lambda): Handle closures and new byte-code-functions.
8031 (Fspecial_variable_p): New function.
8032 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8033 but without exporting it to Lisp.
8034
8035 * doc.c (Fdocumentation, store_function_docstring):
8036 * data.c (Finteractive_form): Handle closures.
8037
8038 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8039 interactive spec.
8040
8041 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8042 New byte-codes.
8043 (exec_byte_code): New function extracted from Fbyte_code to handle new
8044 calling convention for byte-code-functions. Add new byte-codes.
8045
8046 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8047
8048 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8049
8050 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * xdisp.c (redisplay_internal): Fix prototype.
8053
8054 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8055
8056 * xdisp.c (SCROLL_LIMIT): New macro.
8057 (try_scrolling): Use it when setting scroll_limit.
8058 Limit scrolling to 100 screen lines.
8059 (redisplay_window): Even when falling back on "recentering",
8060 position point in the window according to scroll-conservatively,
8061 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8062
8063 (try_scrolling): When point is above the window, allow searching
8064 as far as scroll_max, or one screenful, to compute vertical
8065 distance from PT to the scroll margin position. This prevents
8066 try_scrolling from unnecessarily failing when
8067 scroll-conservatively is set to a value slightly larger than the
8068 window height. Clean up the case of PT below the margin at bottom
8069 of window: scroll_max can no longer be INT_MAX. When aggressive
8070 scrolling is in use, don't let point enter the opposite scroll
8071 margin as result of the scroll.
8072 (syms_of_xdisp) <scroll-conservatively>: Document the
8073 threshold of 100 lines for never-recentering scrolling.
8074
8075 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8076
8077 * dispextern.h (move_it_by_lines):
8078 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8079 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8080 (message_log_check_duplicate): Remove parameters `prev_bol' and
8081 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8082 (redisplay_internal): Remove parameter `preserve_echo_area',
8083 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8084
8085 * indent.c (Fvertical_motion):
8086 * window.c (window_scroll_pixel_based, Frecenter):
8087 Don't pass `need_y_p' to `move_it_by_lines'.
8088
8089 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8090
8091 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8092 steal a few bits to be more compact.
8093 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8094 Remove unneeded casts.
8095
8096 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8097
8098 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8099
8100 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8101 binding" message (bug#7967).
8102
8103 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8104
8105 Fix more problems found by GCC 4.6.0's static checks.
8106
8107 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8108 Remove unused local var.
8109
8110 * editfns.c (Fmessage_box): Remove unused local var.
8111
8112 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8113 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8114 Omit unused local vars.
8115 * window.c (shrink_windows): Omit unused local var.
8116 * menu.c (digest_single_submenu): Omit unused local var.
8117 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8118 Omit unused local var.
8119
8120 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8121 Don't assume string length fits in int.
8122 (keyremap_step, read_key_sequence): Use size_t for sizes.
8123 (read_key_sequence): Don't check last_real_key_start redundantly.
8124
8125 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8126 instead of alloca (Bug#8344).
8127
8128 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8129 (Fbacktrace_frame): Don't assume nframes fits in int.
8130
8131 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8132
8133 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8134 concerns.
8135
8136 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8137
8138 * cm.c (calccost): Turn while-do into do-while, for clarity.
8139
8140 * keyboard.c (syms_of_keyboard): Use the same style as later
8141 in this function when indexing through an array. This also
8142 works around GCC bug 48267.
8143
8144 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8145
8146 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8147
8148 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8149 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8150
8151 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8152 This avoids undefined behavior on integer overflow, and is a bit
8153 more convenient anyway since it is compared to a size_t variable.
8154
8155 Variadic C functions now count arguments with size_t, not int.
8156 This avoids an unnecessary limitation on 64-bit machines, which
8157 caused (substring ...) to crash on large vectors (Bug#8344).
8158 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8160 All variadic functions and their callers changed accordingly.
8161 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8162 * data.c (arith_driver, float_arith_driver): Likewise.
8163 * editfns.c (general_insert_function): Likewise.
8164 * eval.c (struct backtrace.nargs, interactive_p)
8165 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8166 (funcall_lambda, mark_backtrace): Likewise.
8167 * fns.c (concat): Likewise.
8168 * frame.c (x_set_frame_parameters): Likewise.
8169 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8170 0 if not found, not -1. All callers changed.
8171
8172 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8173 (stack_copy_size): Now size_t, not int.
8174 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8175
8176 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8177
8178 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8179 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8180 All callers changed.
8181
8182 * lisp.h (multibyte_char_to_unibyte):
8183 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8184 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8185 * character.h (CHAR_TO_BYTE8):
8186 * cmds.c (internal_self_insert):
8187 * editfns.c (general_insert_function):
8188 * keymap.c (push_key_description):
8189 * search.c (Freplace_match):
8190 * xdisp.c (message_dolog, set_message_1): All callers changed.
8191
8192 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8193
8194 * keyboard.c (safe_run_hook_funcall): New function.
8195 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8196 don't set the hook to nil, but remove the offending function instead.
8197 (Qcommand_hook_internal): Remove, unused.
8198 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8199 Vcommand_hook_internal.
8200
8201 * eval.c (enum run_hooks_condition): Remove.
8202 (funcall_nil, funcall_not): New functions.
8203 (run_hook_with_args): Call each function through a `funcall' argument.
8204 Remove `cond' argument, now redundant.
8205 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8206 (Frun_hook_with_args_until_failure): Adjust accordingly.
8207 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8208
8209 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8210
8211 * dispextern.h (string_buffer_position): Remove declaration.
8212
8213 * print.c (strout): Remove parameter `multibyte', unused since
8214 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8215
8216 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8217 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8218 All callers changed.
8219
8220 * w32.c (_wsa_errlist): Use braces for struct initializers.
8221
8222 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8223 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8224 All callers changed.
8225 (string_buffer_position): Likewise. Also, make static (it's never
8226 used outside xdisp.c).
8227 (cursor_row_p): Remove parameter `w', unused since
8228 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8229 (decode_mode_spec): Remove parameter `precision', introduced during
8230 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8231 All callers changed.
8232
8233 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8234
8235 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8236
8237 2011-03-27 Anders Lindgren <andlind@gmail.com>
8238
8239 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8240 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8241 (ns_update_auto_hide_menu_bar): New functions.
8242 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8243 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8244 ns_constrain_all_frames.
8245 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8246 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8247
8248 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8249
8250 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8251
8252 2011-03-27 Glenn Morris <rgm@gnu.org>
8253
8254 * syssignal.h: Replace RETSIGTYPE with void.
8255 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8256 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8257 Replace SIGTYPE with void everywhere.
8258 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8259 * s/template.h (SIGTYPE): Remove commented out definition.
8260
8261 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8262
8263 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8264 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8265
8266 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8267
8268 * w32.c (read_unc_volume): Use parameter `henum', instead of
8269 global variable `wget_enum_handle'.
8270
8271 * keymap.c (describe_vector): Remove parameters `indices' and
8272 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8273 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8274
8275 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8276
8277 * keyboard.c (timer_check): Remove parameter `do_it_now',
8278 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8279 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8280 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8281
8282 * keyboard.c (read_char):
8283 * w32menu.c (w32_menu_display_help):
8284 * xmenu.c (show_help_event, menu_help_callback):
8285 Adjust calls to `show_help_echo'.
8286
8287 * gtkutil.c (xg_maybe_add_timer):
8288 * keyboard.c (readable_events):
8289 * process.c (wait_reading_process_output):
8290 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8291
8292 * insdel.c (adjust_markers_gap_motion):
8293 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8294 (gap_left, gap_right): Don't call it.
8295
8296 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8297
8298 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8299 incurred during fontification.
8300
8301 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8302
8303 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8304 (DEFVAR_PER_BUFFER): Don't pass it.
8305
8306 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8307 (scrolling_window): Don't pass it.
8308
8309 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8310
8311 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8312
8313 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8314 and `suffix'.
8315 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8316 of variables specific to SELinux and computation of `encoded_absname'.
8317
8318 * image.c (XPutPixel): Remove unused variable `height'.
8319
8320 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8321
8322 * unexw32.c (get_section_info): Remove unused variable `section'.
8323
8324 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8325 (system_process_attributes): Remove unused variable `sess'.
8326 (sys_read): Remove unused variable `err'.
8327
8328 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8329 (w32_wnd_proc): Remove unused variable `isdead'.
8330 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8331 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8332 (x_create_tip_frame): Remove unused variable `tem'.
8333
8334 * w32inevt.c (w32_console_read_socket):
8335 Remove unused variable `no_events'.
8336
8337 * w32term.c (x_draw_composite_glyph_string_foreground):
8338 Remove unused variable `width'.
8339
8340 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8341
8342 * w32term.c (x_set_glyph_string_clipping):
8343 Don't pass uninitialized region to CombineRgn.
8344
8345 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8346
8347 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8348 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8349 (Fx_close_connection): Remove unused variable `i'.
8350
8351 * w32font.c (w32font_draw): Return number of glyphs.
8352 (w32font_open_internal): Remove unused variable `i'.
8353 (w32font_driver): Add missing initializer.
8354
8355 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8356 (fill_in_menu): Remove unused variable `items_added'.
8357
8358 * w32term.c (last_mouse_press_frame): Remove static global variable.
8359 (w32_clip_to_row): Remove unused variable `f'.
8360 (x_delete_terminal): Remove unused variable `i'.
8361
8362 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8363 (NOTHING): Remove unused static global variable.
8364 (uniscribe_check_otf): Remove unused variable `table'.
8365 (uniscribe_font_driver): Add missing initializers.
8366
8367 2011-03-23 Julien Danjou <julien@danjou.info>
8368
8369 * term.c (Fsuspend_tty, Fresume_tty):
8370 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8371 * window.c (temp_output_buffer_show):
8372 * insdel.c (signal_before_change):
8373 * frame.c (Fhandle_switch_frame):
8374 * fileio.c (Fdo_auto_save):
8375 * emacs.c (Fkill_emacs):
8376 * editfns.c (save_excursion_restore):
8377 * cmds.c (internal_self_insert):
8378 * callint.c (Fcall_interactively):
8379 * buffer.c (Fkill_all_local_variables):
8380 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8381 Use Frun_hooks.
8382 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8383 unconditionally since it does the check itself.
8384
8385 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8386
8387 Fix more problems found by GCC 4.5.2's static checks.
8388
8389 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8390 the first time through the loop, since we know p0 < p1 then.
8391 This also avoids a gcc -Wstrict-overflow warning.
8392
8393 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8394 leading to a memory leak, possible in functions like
8395 load_charset_map_from_file that can allocate an unbounded number
8396 of objects (Bug#8318).
8397
8398 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8399 that could (at least in theory) be that large.
8400
8401 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8402 This is less likely to overflow, and avoids undefined behavior if
8403 overflow does occur. All callers changed. Use strtoul to scan
8404 for the unsigned long integer.
8405 (pint2hrstr): Simplify and tune code slightly.
8406 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8407
8408 * scroll.c (do_scrolling): Work around GCC bug 48228.
8409 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8410
8411 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8412 This also avoids a warning with gcc -Wstrict-overflow.
8413 (validate_x_resource_name): Simplify count usage.
8414 This also avoids a warning with gcc -Wstrict-overflow.
8415
8416 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8417 fail (Bug#8306).
8418
8419 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8420
8421 * process.c (Fmake_network_process): Use socklen_t, not int,
8422 where POSIX says socklen_t is required in portable programs.
8423 This fixes a porting bug on hosts like 64-bit HP-UX, where
8424 socklen_t is wider than int (Bug#8277).
8425 (Fmake_network_process, server_accept_connection):
8426 (wait_reading_process_output, read_process_output):
8427 Likewise.
8428
8429 * process.c: Rename or move locals to avoid shadowing.
8430 (list_processes_1, Fmake_network_process):
8431 (read_process_output_error_handler, exec_sentinel_error_handler):
8432 Rename or move locals.
8433 (Fmake_network_process): Define label "retry_connect" only if needed.
8434 (Fnetwork_interface_info): Fix pointer signedness.
8435 (process_send_signal): Add cast to avoid pointer signedness problem.
8436 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8437 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8438
8439 Make tparam.h and terminfo.c consistent.
8440 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8441 Include tparam.h instead, since it declares them.
8442 * cm.h (PC): Remove extern decl; tparam.h now does this.
8443 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8444 * terminfo.c: Include tparam.h, to check interfaces.
8445 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8446 (tparam): Adjust signature to match interface in tparam.h;
8447 this removes some undefined behavior. Check that outstring and len
8448 are zero, which they always are with Emacs.
8449 * tparam.h (PC, BC, UP): New extern decls.
8450
8451 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8452 (xftfont_open): Rename locals to avoid shadowing.
8453
8454 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8455 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8456 (OTF_TAG_SYM): Omit macro if not needed.
8457 (ftfont_list): Remove unused local.
8458 (get_adstyle_property, ftfont_pattern_entity):
8459 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8460 Rename locals to avoid shadowing.
8461
8462 * xfont.c (xfont_list_family): Mark var as initialized.
8463
8464 * xml.c (make_dom): Now static.
8465
8466 * composite.c (composition_compute_stop_pos): Rename local to
8467 avoid shadowing.
8468 (composition_reseat_it): Remove unused locals.
8469 (find_automatic_composition, composition_adjust_point): Likewise.
8470 (composition_update_it): Mark var as initialized.
8471 (find_automatic_composition): Mark vars as initialized,
8472 with a FIXME (Bug#8290).
8473
8474 character.h: Rename locals to avoid shadowing.
8475 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8476 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8477 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8478 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8479 to avoid shadowing.
8480
8481 * textprop.c (property_change_between_p): Remove; unused.
8482
8483 * intervals.c (interval_start_pos): Now static.
8484
8485 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8486
8487 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8488 Rename locals to avoid shadowing.
8489
8490 * sound.c (wav_play, au_play, Fplay_sound_internal):
8491 Fix pointer signedness.
8492 (alsa_choose_format): Remove unused local var.
8493 (wav_play): Initialize a variable to 0, to prevent undefined
8494 behavior (Bug#8278).
8495
8496 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8497
8498 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8499
8500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8501 clobbering (Bug#8298).
8502 * sysdep.c (sys_subshell): Likewise.
8503 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8504
8505 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8506 This should get cleaned up, so that child_setup has the
8507 same signature on all platforms.
8508
8509 * callproc.c (call_process_cleanup): Now static.
8510 (relocate_fd): Rename locals to avoid shadowing.
8511
8512 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8513
8514 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8515 not to be necessary, and produces flickering.
8516
8517 2011-03-20 Glenn Morris <rgm@gnu.org>
8518
8519 * config.in: Remove file.
8520
8521 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8522
8523 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8524 are now in src/globals.h.
8525 (syms_of_minibuf): Remove spurious & from previous change.
8526
8527 2011-03-20 Leo Liu <sdl.web@gmail.com>
8528
8529 * minibuf.c (completing-read-function): New variable.
8530 (completing-read-default): Rename from completing-read.
8531 (completing-read): Call completing-read-function.
8532
8533 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8534
8535 * xfaces.c (Fx_load_color_file):
8536 Read color file from absolute filename (bug#8250).
8537
8538 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8539
8540 * makefile.w32-in: Update dependencies.
8541
8542 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8543
8544 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8545
8546 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8547
8548 Fix more problems found by GCC 4.5.2's static checks.
8549
8550 * process.c (make_serial_process_unwind, send_process_trap):
8551 (sigchld_handler): Now static.
8552
8553 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8554 That way, the code declares only the vars that it needs.
8555 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8556 * s/cygwin.h (PTY_ITERATION): Likewise.
8557 * s/darwin.h (PTY_ITERATION): Likewise.
8558 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8559
8560 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8561 * process.c (allocate_pty): Don't declare stb unless it's needed.
8562
8563 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8564 (CONSTANTLIM): Remove; unused.
8565 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8566 Define only if needed.
8567
8568 * unexelf.c (unexec): Name an expression,
8569 to avoid gcc -Wbad-function-cast warning.
8570 Use a different way to cause a compilation error if anyone uses
8571 n rather than nn, a way that does not involve shadowing.
8572 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8573
8574 * deps.mk (unexalpha.o): Remove; unused.
8575
8576 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8577 * unexec.h: New file.
8578 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8579 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8580 Depend on unexec.h.
8581 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8582 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8583 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8584 Change as necessary to match prototype in unexec.h.
8585
8586 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8587 shadowing.
8588 (back_comment, skip_chars): Mark vars as initialized.
8589
8590 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8591 Rename locals to avoid shadowing.
8592
8593 * lread.c (read1): Rewrite so as not to use empty "else".
8594 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8595
8596 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8597
8598 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8599 warning when compiling print.c.
8600
8601 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8602 instead of using an uninitialized var.
8603 (font_sort_entities): Mark var as initialized.
8604
8605 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8606
8607 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8608 pointers to constants.
8609 (font_parse_fcname): Remove unused vars.
8610 (font_delete_unmatched): Now static.
8611 (font_get_spec): Remove; unused.
8612 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8613 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8614 Rename or move locals to avoid shadowing.
8615
8616 * fns.c (require_nesting_list, require_unwind): Now static.
8617 (Ffillarray): Rename locals to avoid shadowing.
8618
8619 * floatfns.c (domain_error2): Define only if needed.
8620 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8621
8622 * alloc.c (mark_backtrace): Move decl from here ...
8623 * lisp.h: ... to here, so that it can be checked.
8624
8625 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8626 (Fdefvar): Rewrite so as not to use empty "else".
8627 (lisp_indirect_variable): Name an expression,
8628 to avoid gcc -Wbad-function-cast warning.
8629 (Fdefvar): Rename locals to avoid shadowing.
8630
8631 * callint.c (quotify_arg, quotify_args): Now static.
8632 (Fcall_interactively): Rename locals to avoid shadowing.
8633 Use const pointer when appropriate.
8634
8635 * lisp.h (get_system_name, get_operating_system_release):
8636 Move decls here, to check interfaces.
8637 * process.c (get_operating_system_release): Move decl to lisp.h.
8638 * xrdb.c (get_system_name): Likewise.
8639 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8640 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8641 some of which prompt warnings from gcc -Wbad-function-cast.
8642 (Fformat_time_string, Fencode_time, Finsert_char):
8643 (Ftranslate_region_internal, Fformat):
8644 Rename or remove local vars to avoid shadowing.
8645 (Ftranslate_region_internal): Mark var as initialized.
8646
8647 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8648 avoid shadowing.
8649
8650 * lisp.h (eassert): Check that the argument compiles, even if
8651 ENABLE_CHECKING is not defined.
8652
8653 * data.c (Findirect_variable): Name an expression, to avoid
8654 gcc -Wbad-function-cast warning.
8655 (default_value, arithcompare, arith_driver, arith_error): Now static.
8656 (store_symval_forwarding): Rename local to avoid shadowing.
8657 (Fmake_variable_buffer_local, Fmake_local_variable):
8658 Mark variables as initialized.
8659 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8660
8661 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8662 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8663 Rename locals to avoid shadowing.
8664 (mark_stack): Move local variables into the #ifdef region where
8665 they're used.
8666 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8667 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8668 needed otherwise.
8669 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8670 (GC_STRING_CHARS): Remove; not used.
8671 (Fmemory_limit): Cast sbrk's returned value to char *.
8672
8673 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8674 avoids undefined behavior in theory.
8675
8676 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8677
8678 Use functions, not macros, for up- and down-casing (Bug#8254).
8679 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8681 to use the following functions instead of these macros.
8682 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8683 EMACS_INT, since callers assume the returned value fits in int.
8684 (upcase1): Likewise, for UPCASE_TABLE.
8685 (uppercasep, lowercasep, upcase): New static inline functions.
8686 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8687 the race-condition problem in the old DOWNCASE.
8688
8689 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8690 Rename locals to avoid shadowing.
8691 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8692 (regex_compile, re_search_2, re_match_2_internal):
8693 Remove unused local vars.
8694 (FREE_VAR): Rewrite so as not to use empty "else",
8695 which gcc can warn about.
8696 (regex_compile, re_match_2_internal): Mark locals as initialized.
8697 (RETALLOC_IF): Define only if needed.
8698 (WORDCHAR_P): Likewise. This one is never needed, but is used
8699 only in a comment talking about a compiler bug, so put inside
8700 the #if 0 of that comment.
8701 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8702 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8703 Remove; unused.
8704
8705 * search.c (boyer_moore): Rename locals to avoid shadowing.
8706 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8707 (PREV_CHAR_BOUNDARY): Likewise.
8708
8709 * search.c (simple_search): Remove unused var.
8710
8711 * dired.c (compile_pattern): Move decl from here ...
8712 * lisp.h: ... to here, so that it can be checked.
8713 (struct re_registers): New forward decl.
8714
8715 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8716
8717 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8718 All uses changed.
8719 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8720 Rename locals to avoid shadowing.
8721 (Fvertical_motion): Mark locals as initialized.
8722
8723 * casefiddle.c (casify_object, casify_region): Now static.
8724 (casify_region): Mark local as initialized.
8725
8726 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8727
8728 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8729 New macros, so that the caller can use some names other than
8730 gcpro1, gcpro2, etc.
8731 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8732 of the new macros.
8733 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8734 argument, for consistency with GCPRO2_VAR, etc: it is now the
8735 prefix of the variable, not the variable itself. All uses
8736 changed.
8737 * dired.c (directory_files_internal, file_name_completion):
8738 Rename locals to avoid shadowing.
8739
8740 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8741 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8742 dired.c's scmp function, had undefined behavior.
8743 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8745 * buffer.h: ... to here, because these macros use current_buffer,
8746 and the new implementation with inline functions needs to have
8747 current_buffer in scope now, rather than later when the macros
8748 are used.
8749 (downcase, upcase1): New static inline functions.
8750 (DOWNCASE, UPCASE1): Reimplement using these functions.
8751 This avoids undefined behavior in expressions like
8752 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8753 from race conditions in accessing the global variables
8754 case_temp1 and case_temp2.
8755 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8756 * lisp.h (case_temp1, case_temp2): Remove their decls.
8757 * character.h (ASCII_CHAR_P): Move from here ...
8758 * lisp.h: ... to here, so that the inline functions mentioned
8759 above can use them.
8760
8761 * dired.c (directory_files_internal_unwind): Now static.
8762
8763 * fileio.c (file_name_as_directory, directory_file_name):
8764 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8765 Now static.
8766 (file_name_as_directory): Use const pointers when appropriate.
8767 (Fexpand_file_name): Likewise. In particular, newdir might
8768 point at constant storage, so make it a const pointer.
8769 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8770 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8771 signedness issues.
8772 (Fset_file_times, Finsert_file_contents, auto_save_error):
8773 Rename locals to avoid shadowing.
8774
8775 * minibuf.c (choose_minibuf_frame_1): Now static.
8776 (Ftry_completion, Fall_completions): Rename or remove locals
8777 to avoid shadowing.
8778
8779 * marker.c (bytepos_to_charpos): Remove; unused.
8780
8781 * lisp.h (verify_bytepos, count_markers): New decls,
8782 so that gcc does not warn that these functions aren't declared.
8783
8784 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8785 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8786 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8787 (copy_text): Remove unused local var.
8788
8789 * filelock.c (within_one_second): Now static.
8790 (lock_file_1): Rename local to avoid shadowing.
8791
8792 * buffer.c (fix_overlays_before): Mark locals as initialized.
8793 (fix_start_end_in_overlays): Likewise. This function should be
8794 simplified by using pointers-to-pointers, but that's a different
8795 matter.
8796 (switch_to_buffer_1): Now static.
8797 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8798 (report_overlay_modification): Rename locals to avoid shadowing.
8799
8800 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8801 Fix pointer signedness issue.
8802 (sys_subshell): Mark local as volatile if checking for lint,
8803 to suppress a gcc -Wclobbered warning that does not seem to be right.
8804 (MAXPATHLEN): Define only if needed.
8805
8806 * process.c (serial_open, serial_configure): Move decls from here ...
8807 * systty.h: ... to here, so that they can be checked.
8808
8809 * fns.c (get_random, seed_random): Move extern decls from here ...
8810 * lisp.h: ... to here, so that they can be checked.
8811
8812 * sysdep.c (reset_io): Now static.
8813 (wait_for_termination_signal): Remove; unused.
8814
8815 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8816 (copy_keymap_item, append_key, push_text_char_description):
8817 Now static.
8818 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8819 (DENSE_TABLE_SIZE): Remove; unused.
8820 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8821 (describe_map_tree):
8822 Rename locals to avoid shadowing.
8823
8824 * keyboard.c: Declare functions static if they are not used elsewhere.
8825 (echo_char, echo_dash, cmd_error, top_level_2):
8826 (poll_for_input, handle_async_input): Now static.
8827 (read_char, kbd_buffer_get_event, make_lispy_position):
8828 (make_lispy_event, make_lispy_movement, apply_modifiers):
8829 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8830 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8831 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8832 (read_key_sequence, read_char): Mark locals as initialized.
8833 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8834
8835 * keyboard.h (make_ctrl_char): New decl.
8836 (mark_kboards): Move decl here ...
8837 * alloc.c (mark_kboards): ... from here.
8838
8839 * lisp.h (force_auto_save_soon): New decl.
8840
8841 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8842 (DEFINE_DUMMY_FUNCTION): New macro.
8843 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8844 Use it.
8845 (main): Add casts to avoid warnings
8846 if GCC considers string literals to be constants.
8847
8848 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8849
8850 * dbusbind.c: Pointer signedness fixes.
8851 (xd_signature, xd_append_arg, xd_initialize):
8852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8854 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8855 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8856
8857 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8858 if GCC considers string literals to be constants.
8859 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8860
8861 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8862
8863 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8864 (print_preprocess, print_object): New macro to fix last change.
8865
8866 * print.c (print_preprocess): Don't forget font objects.
8867
8868 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8869
8870 * emacs.c (USAGE3): Doc fixes.
8871
8872 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8873
8874 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8875 structure.
8876
8877 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8878
8879 * lisp.h (VWindow_system, Qfile_name_history):
8880 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8881 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8882 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8883
8884 * w32select.c: Don't #include "keyboard.h".
8885 (run_protected): Add extern declaration for waiting_for_input.
8886
8887 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8888 * w32console.c (detect_input_pending, read_input_pending)
8889 (encode_terminal_code):
8890 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8891 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8892 (w32_system_caret_y, Qfile_name_history):
8893 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8894 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8895 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8896 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8897 * w32proc.c (Qlocal, report_file_error):
8898 * w32term.c (Vwindow_system, updating_frame):
8899 * w32uniscribe.c (initialized, uniscribe_font_driver):
8900 Remove unneeded extern declarations.
8901
8902 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8903
8904 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8905
8906 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8907
8908 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8909 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8910 These macros can no longer be used for assignment.
8911
8912 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8913 Assign struct members directly, instead of using BUF_BEGV etc.
8914 (record_buffer_markers, fetch_buffer_markers): New functions for
8915 recording and fetching special buffer markers.
8916 (set_buffer_internal_1, set_buffer_temp): Use them.
8917
8918 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8919
8920 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8921
8922 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8923 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8924
8925 * xdisp.c (hscroll_window_tree):
8926 (reconsider_clip_changes): Use PT instead of BUF_PT.
8927
8928 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8929
8930 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8931 $(EMACS_ROOT)/lib/intprops.h.
8932
8933 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8934
8935 Fix more problems found by GCC 4.5.2's static checks.
8936
8937 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8938 to unsigned char * to avoid compiler diagnostic.
8939 (xg_free_frame_widgets): Make it clear that a local variable is
8940 needed only if USE_GTK_TOOLTIP.
8941 (gdk_window_get_screen): Make it clear that this macro is needed
8942 only if USE_GTK_TOOLTIP.
8943 (int_gtk_range_get_value): New function, which avoids a diagnostic
8944 from gcc -Wbad-function-cast.
8945 (xg_set_toolkit_scroll_bar_thumb): Use it.
8946 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8947 diagnostic from gcc -Wbad-function-cast.
8948 (get_utf8_string, xg_get_file_with_chooser):
8949 Rename locals to avoid shadowing.
8950 (create_dialog): Move locals to avoid shadowing.
8951
8952 * xgselect.c (xg_select): Remove unused var.
8953
8954 * image.c (four_corners_best): Mark locals as initialized.
8955 (gif_load): Initialize transparent_p to zero (Bug#8238).
8956 Mark another local as initialized.
8957 (my_png_error, my_error_exit): Mark with NO_RETURN.
8958
8959 * image.c (clear_image_cache): Now static.
8960 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8961 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8962 (x_edge_detection): Remove unnecessary cast that
8963 gcc -Wbad-function-cast diagnoses.
8964 (gif_load): Fix pointer signedness.
8965 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8966 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8967
8968 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 Improve quality of tests for time stamp overflow.
8971 For example, without this patch (encode-time 0 0 0 1 1
8972 1152921504606846976) returns the obviously-bogus value (-948597
8973 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8974 reports time overflow. See
8975 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8976 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8977 * editfns.c: Include limits.h and intprops.h.
8978 (TIME_T_MIN, TIME_T_MAX): New macros.
8979 (time_overflow): Move earlier, to before first use.
8980 (hi_time, lo_time): New functions, for an accurate test for
8981 out-of-range times.
8982 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8983 (Fget_internal_run_time): Don't assume time_t fits in int.
8984 (make_time): Use list2 instead of Fcons twice.
8985 (Fdecode_time): More accurate test for out-of-range times.
8986 (check_tm_member): New function.
8987 (Fencode_time): Use it, to test for out-of-range times.
8988 (lisp_time_argument): Don't rely on undefined left-shift and
8989 right-shift behavior when checking for time stamp overflow.
8990
8991 * editfns.c (time_overflow): New function, refactoring common code.
8992 (Fformat_time_string, Fdecode_time, Fencode_time):
8993 (Fcurrent_time_string): Use it.
8994
8995 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8996 * dired.c (make_time): Move to ...
8997 * editfns.c (make_time): ... here.
8998 * systime.h: Note the move.
8999
9000 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9001
9002 * fringe.c (update_window_fringes): Remove unused variables.
9003
9004 * unexmacosx.c (copy_data_segment): Also copy __got section.
9005 (Bug#8223)
9006
9007 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9008
9009 * termcap.c [MSDOS]: Include "msdos.h".
9010 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9011 Constify `char *' arguments and their references according to
9012 prototypes in tparam.h.
9013
9014 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9015
9016 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9017 Adapt all references accordingly.
9018
9019 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9020
9021 2011-03-11 Tom Tromey <tromey@redhat.com>
9022
9023 * buffer.c (syms_of_buffer): Remove obsolete comment.
9024
9025 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9026
9027 * termhooks.h (encode_terminal_code): Declare prototype.
9028
9029 * msdos.c (encode_terminal_code): Don't declare prototype.
9030
9031 * term.c (encode_terminal_code): Now external again, used by
9032 w32console.c and msdos.c.
9033
9034 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9035 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9036
9037 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9038
9039 Fix some minor problems found by GCC 4.5.2's static checks.
9040
9041 * fringe.c (update_window_fringes): Mark locals as initialized
9042 (Bug#8227).
9043 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9044
9045 * alloc.c (mark_fringe_data): Move decl from here ...
9046 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9047 to check its interface.
9048 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9049
9050 * fontset.c (free_realized_fontset): Now static.
9051 (Fset_fontset_font): Rename local to avoid shadowing.
9052 (fontset_font): Mark local as initialized.
9053 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9054
9055 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9056
9057 * xselect.c (x_disown_buffer_selections): Remove; not used.
9058 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9059 (x_own_selection, Fx_disown_selection_internal): Rename locals
9060 to avoid shadowing.
9061 (x_handle_dnd_message): Remove local to avoid shadowing.
9062
9063 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9064 so that the caller can use some name other than gcpro1.
9065 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9066 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9067 (Fx_backspace_delete_keys_p):
9068 Use them to avoid shadowing, and rename vars to avoid shadowing.
9069 (x_decode_color, x_set_name, x_window): Now static.
9070 (Fx_create_frame): Add braces to silence GCC warning.
9071 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9072 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9073 Remove unused locals.
9074 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9075 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9076 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9077 macros.
9078
9079 * xterm.h (x_mouse_leave): New decl.
9080
9081 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9082 Remove unused functions.
9083 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9084 (x_calc_absolute_position): Now static.
9085 (XTread_socket): Don't define label "out" unless it's used.
9086 Don't declare local "event" unless it's used.
9087 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9088 unless they are used.
9089 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9090 (x_fatal_error_signal): Remove; not used.
9091 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9092 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9093 (x_error_catcher, x_connection_closed, x_error_handler):
9094 (x_error_quitter, xembed_send_message, x_iconify_frame):
9095 (my_log_handler): Rename locals to avoid shadowing.
9096 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9097 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9098
9099 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9100 Rename or move locals to avoid shadowing.
9101 (tty_defined_color, merge_face_heights): Now static.
9102 (free_realized_faces_for_fontset): Remove; not used.
9103 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9104 does not deduce is never used uninitialized.
9105 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9106 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9107
9108 * terminal.c (store_terminal_param): Now static.
9109
9110 * xmenu.c (menu_highlight_callback): Now static.
9111 (set_frame_menubar): Remove unused local.
9112 (xmenu_show): Rename parameter to avoid shadowing.
9113 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9114 since they might point to immutable storage.
9115 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9116 since it's unused otherwise.
9117
9118 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9119 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9120 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9121 avoids a gcc -Wuninitialized diagnostic.
9122 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9123 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9124 does not deduce are never used uninitialized.
9125
9126 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9127
9128 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9129 * window.c (window_loop, size_window):
9130 (run_window_configuration_change_hook, enlarge_window): Likewise.
9131
9132 * window.c (display_buffer): Now static.
9133 (size_window): Mark variables that gcc -Wuninitialized
9134 does not deduce are never used uninitialized.
9135 * window.h (check_all_windows): New decl, to forestall
9136 gcc -Wmissing-prototypes diagnostic.
9137 * dispextern.h (bidi_dump_cached_states): Likewise.
9138
9139 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9140 shadowing.
9141 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9142 Include <limits.h>.
9143 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9144 and to avoid gcc -Wuninitialized warning.
9145 (load_charset_map): Mark variables that gcc -Wuninitialized
9146 does not deduce are never used uninitialized.
9147 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9148
9149 * coding.c (coding_set_source, coding_set_destination):
9150 Use "else { /* comment */ }" rather than "else /* comment */;"
9151 for clarity, and to avoid gcc -Wempty-body warning.
9152 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9153 a block, when the outer 'i' will do.
9154 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9155 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9157 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9158 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9159 Rename locals to avoid shadowing.
9160 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9161 * coding.c (emacs_mule_char, encode_invocation_designation):
9162 Now static, since they're not used elsewhere.
9163 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9164 (decode_coding_object, encode_coding_object, detect_coding_system):
9165 (decode_coding_emacs_mule): Mark variables that gcc
9166 -Wuninitialized does not deduce are never used uninitialized.
9167 (detect_coding_iso_2022): Initialize a local variable that might
9168 be used uninitialized. Leave a FIXME because it's not clear that
9169 this initialization is needed. (Bug#8211)
9170 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9171 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9172 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9173 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9174 Remove unused macros.
9175
9176 * category.c (hash_get_category_set): Remove unused local var.
9177 (copy_category_table): Now static, since it's not used elsewhere.
9178 * character.c (string_count_byte8): Likewise.
9179
9180 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9181 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9182
9183 * chartab.c (copy_sub_char_table): Now static, since it's not used
9184 elsewhere.
9185 (sub_char_table_ref_and_range, char_table_ref_and_range):
9186 Rename locals to avoid shadowing.
9187 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9188
9189 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9190 (BIDI_BOB): Remove unused macro.
9191
9192 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9193 deduce are never used uninitialized.
9194 * term.c (encode_terminal_code): Likewise.
9195
9196 * term.c (encode_terminal_code): Now static. Remove unused local.
9197
9198 * tparam.h: New file.
9199 * term.c, tparam.h: Include it.
9200 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9201 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9202 Move these decls to tparam.h, and make them agree with what
9203 is actually in tparam.c. The previous trick of using incompatible
9204 decls in different modules does not conform to the C standard.
9205 All callers of tparam changed to use tparam's actual API.
9206 * tparam.c (tparam1, tparam, tgoto):
9207 Use const pointers where appropriate.
9208
9209 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9210 * cm.h (struct cm): Likewise.
9211 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9212 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9213 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9214 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9215 (turn_on_face, init_tty): Likewise.
9216 * termchar.h (struct tty_display_info): Likewise.
9217
9218 * term.c (term_mouse_position): Rename local to avoid shadowing.
9219
9220 * alloc.c (mark_ttys): Move decl from here ...
9221 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9222
9223 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9224
9225 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9226
9227 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9228
9229 * search.c (compile_pattern_1): Remove argument regp, unused since
9230 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9231 (compile_pattern): Don't pass it.
9232
9233 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9234
9235 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9236 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9237 for ! HAVE_GTK3.
9238 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9239
9240 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9241
9242 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9243 gdk_window_get_screen, gdk_window_get_geometry,
9244 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9245 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9246 (xg_get_pixbuf_from_pixmap): New function.
9247 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9248 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9249 Call xg_get_pixbuf_from_pixmap instead of
9250 gdk_pixbuf_get_from_drawable.
9251 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9252 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9253 (xg_check_special_colors): Use GtkStyleContext and its functions
9254 for HAVE_GTK3.
9255 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9256 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9257 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9258 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9259 Call gtk_widget_get_preferred_size.
9260 (xg_frame_resized): gdk_window_get_geometry only takes 5
9261 parameters.
9262 (xg_win_to_widget, xg_event_is_for_menubar):
9263 Call gdk_x11_window_lookup_for_display.
9264 (xg_set_widget_bg): New function.
9265 (delete_cb): New function.
9266 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9267 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9268 (xg_set_background_color): Call xg_set_widget_bg.
9269 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9270 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9271 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9272 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9273 if ! HAVE_GTK3.
9274 (update_frame_tool_bar): Call gtk_widget_hide.
9275 (xg_initialize): Use GDK_KEY_g.
9276
9277 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9278 if ! HAVE_GTK3
9279 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9280
9281 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9282 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9283 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9284
9285 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9286
9287 * w32xfns.c (select_palette): Check success of RealizePalette against
9288 GDI_ERROR, not zero.
9289
9290 See ChangeLog.11 for earlier changes.
9291
9292 ;; Local Variables:
9293 ;; coding: utf-8
9294 ;; End:
9295
9296 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9297
9298 This file is part of GNU Emacs.
9299
9300 GNU Emacs is free software: you can redistribute it and/or modify
9301 it under the terms of the GNU General Public License as published by
9302 the Free Software Foundation, either version 3 of the License, or
9303 (at your option) any later version.
9304
9305 GNU Emacs is distributed in the hope that it will be useful,
9306 but WITHOUT ANY WARRANTY; without even the implied warranty of
9307 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9308 GNU General Public License for more details.
9309
9310 You should have received a copy of the GNU General Public License
9311 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.