1 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3 Integer overflow and signedness fixes (Bug#8873).
4 A few related buffer overrun fixes, too.
6 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8 * dispextern.h (struct face.stipple):
9 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10 (x_bitmap_mask, x_allocate_bitmap_record)
11 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13 (x_create_bitmap_from_xpm_data):
14 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
15 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
17 * xfaces.c (load_pixmap):
18 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
19 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
20 (.bitmaps_last, struct x_output.icon_bitmap):
21 Use ptrdiff_t, not int, for bitmap indexes.
22 (x_allocate_bitmap_record): Check for size overflow.
23 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
25 Use ptrdiff_t, not int, for overlay counts.
26 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
27 * editfns.c (overlays_around, get_pos_property):
28 * textprop.c (get_char_property_and_overlay):
29 * xdisp.c (next_overlay_change, note_mouse_highlight):
30 * xfaces.c (face_at_buffer_position):
31 * buffer.c (OVERLAY_COUNT_MAX): New macro.
32 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
33 (Fnext_overlay_change, Fprevious_overlay_change)
34 (mouse_face_overlay_overlaps, Foverlays_in):
35 Use ptrdiff_t, not int, for sizes.
36 (overlays_at, overlays_in): Check for size-calculation overflow.
38 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
40 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
41 (x_session_initialize): Do not assume string length fits in int.
43 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
44 This is unlikely, but can occur if DPI is outlandish.
46 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
47 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
49 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
50 * xrdb.c (magic_file_p, search_magic_path):
51 Omit last arg SUFFIX; it was always 0. All callers changed.
52 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
54 * xfont.c (xfont_match): Avoid need for strlen.
56 * xfns.c: Don't assume strlen fits in int.
57 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
59 * xdisp.c (message_log_check_duplicate): Return intmax_t,
60 not unsigned long, as we prefer signed integers. All callers changed.
61 Detect integer overflow in repeat count.
62 (message_dolog): Don't assume print length fits in 39 bytes.
63 (display_mode_element): Don't assume strlen fits in int.
65 * termcap.c: Don't assume sizes fit in int and never overflow.
66 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
67 (gobble_line): Check for size-calculation overflow.
69 * minibuf.c (Fread_buffer):
70 * lread.c (intern, intern_c_string):
71 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
72 Don't assume string length fits in int.
74 * keyboard.c (parse_tool_bar_item):
75 * gtkutil.c (style_changed_cb): Avoid need for strlen.
77 * font.c: Don't assume string length fits in int.
78 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
79 Use ptrdiff_t, not int.
80 (font_intern_prop): Don't assume string length fits in int.
81 Don't assume integer property fits in fixnum.
82 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
84 * filelock.c: Fix some buffer overrun and integer overflow issues.
85 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
86 Reformulate so as not to need the command string.
87 Invoke gzip -cd rather than gunzip, as it's more portable.
88 (lock_info_type, lock_file_1, lock_file):
89 Don't assume pid_t and time_t fit in unsigned long.
90 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
91 (current_lock_owner): Prefer signed type for sizes.
92 Use memcpy, not strncpy, where memcpy is what is really wanted.
93 Don't assume (via atoi) that time_t and pid_t fit in int.
94 Check for time_t and/or pid_t out of range, e.g., via a network share.
95 Don't alloca where an auto var works fine.
97 * fileio.c: Fix some integer overflow issues.
98 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
99 Don't assume string length fits in int.
100 (directory_file_name): Don't assume string length fits in long.
101 (make_temp_name): Don't assume pid fits in int, or that its print
102 length is less than 20.
104 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
106 * coding.c (make_subsidiaries): Don't assume string length fits in int.
108 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
110 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
111 We prefer signed integers, even for size calculations.
113 * emacs.c: Don't assume string length fits in 'int'.
114 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
115 (main): Don't invoke strlen when not needed.
117 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
118 (XD_DEBUG_MESSAGE): Don't waste a byte.
120 * callproc.c (getenv_internal_1, getenv_internal)
122 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
124 * lread.c (invalid_syntax): Omit length argument.
125 All uses changed. This doesn't fix a bug, but it simplifies the
126 code away from its former Hollerith-constant appearance, and it's
127 one less 'int' to worry about when looking at integer-overflow issues.
128 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
130 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
131 This didn't break anything, but it didn't help either.
132 It's confusing to put a bogus integer in a place where the actual
133 value does not matter.
134 (LIST_END_P): Remove unused macro and its bogus comment.
135 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
137 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
138 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
140 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
141 We prefer signed types, and the value cannot exceed the EMACS_INT
142 range anyway (because otherwise the length would not be representable).
143 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
144 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
145 This avoids a GCC warning when WIDE_EMACS_INT.
147 * indent.c (sane_tab_width): New function.
148 (current_column, scan_for_column, Findent_to, position_indentation)
149 (compute_motion): Use it. This is just for clarity.
150 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
152 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
154 * lisp.h (lint_assume): New macro.
155 * composite.c (composition_gstring_put_cache):
156 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
158 * editfns.c, insdel.c:
159 Omit unnecessary forward decls, to simplify future changes.
161 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
163 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
165 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
166 Use much-faster test for byte-length change.
167 Don't assume string byte-length fits in 'int'.
168 Check that character arg fits in 'int'.
169 (mapcar1): Declare byte as byte, for clarity.
171 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
173 * fns.c (concat): Catch string overflow earlier.
174 Do not rely on integer wraparound.
176 * dispextern.h (struct it.overlay_strings_charpos)
177 (struct it.selective): Now EMACS_INT, not int.
178 * xdisp.c (forward_to_next_line_start)
179 (back_to_previous_visible_line_start)
180 (reseat_at_next_visible_line_start, next_element_from_buffer):
181 Don't arbitrarily truncate the value of 'selective' to int.
183 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
185 * composite.c: Don't truncate sizes to 'int'.
186 (composition_gstring_p, composition_reseat_it)
187 (composition_adjust_point): Use EMACS_INT, not int.
188 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
189 not EMACS_UINT, for indexes.
191 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
193 * buffer.c: Include <verify.h>.
194 (struct sortvec.priority, struct sortstr.priority):
195 Now EMACS_INT, not int.
196 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
197 (struct sortstr.size, record_overlay_string)
198 (struct sortstrlist.size, struct sortlist.used):
199 Don't truncate size to int.
200 (record_overlay_string): Check for size-calculation overflow.
201 (init_buffer_once): Check at compile-time, not run-time.
203 2011-06-22 Jim Meyering <meyering@redhat.com>
205 don't leak an XBM-image-sized buffer
206 * image.c (xbm_load): Free the image buffer after using it.
208 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
211 * composite.c (find_automatic_composition): Omit needless 'return 0;'
212 that Sun C diagnosed.
213 * fns.c (secure_hash): Fix pointer signedness issue.
214 * intervals.c (static_offset_intervals): New function.
215 (offset_intervals): Use it.
217 2011-06-21 Leo Liu <sdl.web@gmail.com>
220 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
223 * fns.c (secure_hash): Rename from crypto_hash_function and change
224 the first arg to accept symbols.
225 (Fsecure_hash): New primtive.
226 (syms_of_fns): New symbols.
228 2011-06-20 Deniz Dogan <deniz@dogan.se>
230 * process.c (Fset_process_buffer): Clarify return value in
233 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
235 * dispnew.c (add_window_display_history): Use BVAR.
237 * xdisp.c (debug_method_add): Use BVAR.
238 (check_window_end, dump_glyph_matrix, dump_glyph)
239 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
241 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
244 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
245 check till after the cache is created in init_frame_faces.
247 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
249 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
251 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
253 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
254 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
255 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
257 Improve buffer-overflow checking (Bug#8873).
258 * fileio.c (Finsert_file_contents):
259 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
260 Remove the old (too-loose) buffer overflow checks.
261 They weren't needed, since make_gap checks for buffer overflow.
262 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
263 The old code merely checked for Emacs fixnum overflow, and relied
264 on undefined (wraparound) behavior. The new code avoids undefined
265 behavior, and also checks for ptrdiff_t and/or size_t overflow.
267 * editfns.c (Finsert_char): Don't dump core with very negative counts.
268 Tune. Don't use wider integers than needed. Don't use alloca.
269 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
271 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
273 * insdel.c, lisp.h (buffer_overflow): New function.
274 (insert_from_buffer_1, replace_range, replace_range_2):
275 * insdel.c (make_gap_larger):
276 * editfns.c (Finsert_char):
277 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
279 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
281 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
283 Integer overflow and signedness fixes (Bug#8873).
285 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
286 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
288 * fileio.c: Don't assume EMACS_INT fits in off_t.
289 (emacs_lseek): New static function.
290 (Finsert_file_contents, Fwrite_region): Use it.
291 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
293 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
295 * fns.c: Don't overflow int when computing a list length.
296 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
297 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
298 truncation on 64-bit hosts. Check for QUIT every
299 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
300 faster and is responsive enough.
301 (Flength): Report an error instead of overflowing an integer.
302 (Fsafe_length): Return a float if the value is not representable
303 as a fixnum. This shouldn't happen except in contrived situations.
304 (Fnthcdr, Fsort): Don't assume list length fits in int.
305 (Fcopy_sequence): Don't assume vector length fits in int.
307 * alloc.c: Check that resized vectors' lengths fit in fixnums.
308 (header_size, word_size): New constants.
309 (allocate_vectorlike): Don't check size overflow here.
310 (allocate_vector): Check it here instead, since this is the only
311 caller of allocate_vectorlike that could cause overflow.
312 Check that the new vector's length is representable as a fixnum.
314 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
315 The previous code was bogus. For example, next_almost_prime (32)
316 returned 39, which is undesirable as it is a multiple of 3; and
317 next_almost_prime (24) returned 25, which is a multiple of 5 so
318 why was the code bothering to check for multiples of 7?
320 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
322 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
324 Variadic C functions now count arguments with ptrdiff_t.
325 This partly undoes my 2011-03-30 change, which replaced int with size_t.
326 Back then I didn't know that the Emacs coding style prefers signed int.
327 Also, in the meantime I found a few more instances where arguments
328 were being counted with int, which may truncate counts on 64-bit
329 machines, or EMACS_INT, which may be unnecessarily wide.
330 * lisp.h (struct Lisp_Subr.function.aMANY)
331 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
332 Arg counts are now ptrdiff_t, not size_t.
333 All variadic functions and their callers changed accordingly.
334 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
335 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
336 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
337 * callint.c (Fcall_interactively): Check arg count for overflow,
338 to avoid potential buffer overrun. Use signed char, not 'int',
339 for 'varies' array, so that we needn't bother to check its size
340 calculation for overflow.
341 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
342 * eval.c (apply_lambda):
343 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
344 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
345 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
347 * callint.c (Fcall_interactively): Don't use index var as event count.
349 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
350 * mem-limits.h (SIZE): Remove; no longer used.
352 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
354 Remove unnecessary casts.
355 * xterm.c (x_term_init):
356 * xfns.c (x_set_border_pixel):
357 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
358 These aren't needed now that we assume ANSI C.
360 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
361 It's more likely to cause problems (due to unsigned overflow)
364 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
366 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
368 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
370 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
372 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
374 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
376 GLYPH_CODE_FACE returns EMACS_INT, not int.
377 * dispextern.h (merge_faces):
378 * xfaces.c (merge_faces):
379 * xdisp.c (get_next_display_element, next_element_from_display_vector):
380 Don't assume EMACS_INT fits in int.
382 * character.h (CHAR_VALID_P): Remove unused parameter.
383 * fontset.c, lisp.h, xdisp.c: All uses changed.
385 * editfns.c (Ftranslate_region_internal): Omit redundant test.
387 * fns.c (concat): Minor tuning based on overflow analysis.
388 This doesn't fix any bugs. Use int to hold character, instead
389 of constantly refetching from Emacs object. Use XFASTINT, not
390 XINT, for value known to be a character. Don't bother comparing
391 a single byte to 0400, as it's always less.
393 * floatfns.c (Fexpt):
394 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
396 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
399 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
401 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
402 Without this fix, on a 64-bit host (aset S 0 4294967386) would
403 incorrectly succeed when S was a string, because 4294967386 was
404 truncated before it was used.
406 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
407 Otherwise, an out-of-range integer could cause undefined behavior
410 * composite.c: Use int, not EMACS_INT, for characters.
411 (fill_gstring_body, composition_compute_stop_pos): Use int, not
412 EMACS_INT, for values that are known to be in character range.
413 This doesn't fix any bugs but is the usual style inside Emacs and
414 may generate better code on 32-bit machines.
416 Make sure a 64-bit char is never passed to ENCODE_CHAR.
417 This is for reasons similar to the recent CHAR_STRING fix.
418 * charset.c (Fencode_char): Check that character arg is actually
419 a character. Pass an int to ENCODE_CHAR.
420 * charset.h (ENCODE_CHAR): Verify that the character argument is no
421 wider than 'int', as a compile-time check to prevent future regressions
424 * character.c (char_string): Remove unnecessary casts.
426 Make sure a 64-bit char is never passed to CHAR_STRING.
427 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
428 by silently ignoring the top 32 bits, allowing some values
429 that were far too large to be valid characters.
430 * character.h: Include <verify.h>.
431 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
432 arguments are no wider than unsigned, as a compile-time check
433 to prevent future regressions in this area.
435 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
436 (Fsubst_char_in_region):
438 * xdisp.c (decode_mode_spec_coding):
439 Adjust to CHAR_STRING's new requirement.
440 * editfns.c (Finsert_char, Fsubst_char_in_region):
441 * fns.c (concat): Check that character args are actually
442 characters. Without this test, these functions did the wrong
443 thing with wildly out-of-range values on 64-bit hosts.
445 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
446 These casts should not be needed on 32-bit hosts, either.
447 * keyboard.c (read_char):
448 * lread.c (Fload): Remove casts to unsigned.
450 * lisp.h (UNSIGNED_CMP): New macro.
451 This fixes comparison bugs on 64-bit hosts.
452 (ASCII_CHAR_P): Use it.
453 * casefiddle.c (casify_object):
454 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
455 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
456 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
457 * dispextern.h (FACE_FROM_ID):
458 * keyboard.c (read_char): Use UNSIGNED_CMP.
460 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
461 not to EMACS_INT, to avoid GCC warning.
463 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
465 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
466 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
467 isn't needed on 32-bit machines.
469 * buffer.c (Fgenerate_new_buffer_name):
470 Use EMACS_INT for count, not int.
471 (advance_to_char_boundary): Return EMACS_INT, not int.
473 * data.c (Qcompiled_function): Now static.
475 * window.c (window_body_lines): Now static.
477 * image.c (gif_load): Rename local to avoid shadowing.
479 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
480 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
481 * alloc.c (make_save_value): Integer argument is now of type
483 (mark_object): Use ptrdiff_t, not int.
484 * lisp.h (pD): New macro.
485 * print.c (print_object): Use it.
487 * alloc.c: Use EMACS_INT, not int, to count objects.
488 (total_conses, total_markers, total_symbols, total_vector_size)
489 (total_free_conses, total_free_markers, total_free_symbols)
490 (total_free_floats, total_floats, total_free_intervals)
491 (total_intervals, total_strings, total_free_strings):
492 Now EMACS_INT, not int. All uses changed.
493 (Fgarbage_collect): Compute overall total using a double, so that
494 integer overflow is less likely to be a problem. Check for overflow
495 when converting back to an integer.
496 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
497 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
498 These were 'int' variables that could overflow on 64-bit hosts;
499 they were never used, so remove them instead of repairing them.
500 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
501 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
502 Previously, this ceilinged at INT_MAX, but that doesn't work on
504 (allocate_pseudovector): Don't use EMACS_INT when int would do.
506 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
507 (allocate_vectorlike): Check for ptrdiff_t overflow.
508 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
509 when a (possibly-narrower) signed value would do just as well.
510 We prefer using signed arithmetic, to avoid comparison confusion.
512 * alloc.c: Catch some string size overflows that we were missing.
513 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
514 for convenience in STRING_BYTES_MAX.
515 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
516 The definition here is exact; the one in lisp.h was approximate.
517 (allocate_string_data): Check for string overflow. This catches
518 some instances we weren't catching before. Also, it catches
519 size_t overflow on (unusual) hosts where SIZE_MAX <= min
520 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
521 and ptrdiff_t and EMACS_INT are both 64 bits.
523 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
524 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
525 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
527 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
529 * alloc.c (Fmake_string): Check for out-of-range init.
531 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
533 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
535 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
537 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
538 xg_get_default_scrollbar_width.
540 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
541 (int_gtk_range_get_value): Move to the scroll bar part of the file.
542 (style_changed_cb): Call update_theme_scrollbar_width and call
543 x_set_scroll_bar_default_width and xg_frame_set_char_size for
544 all frames (Bug#8505).
545 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
546 Call gtk_window_set_resizable if HAVE_GTK3.
547 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
548 and height if HAVE_GTK3 (Bug#8505).
549 (scroll_bar_width_for_theme): New variable.
550 (update_theme_scrollbar_width): New function.
551 (xg_get_default_scrollbar_width): Move code to
552 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
553 (xg_initialize): Call update_theme_scrollbar_width.
555 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
557 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
559 2011-06-12 Martin Rudalics <rudalics@gmx.at>
561 * frame.c (make_frame): Call other_buffer_safely instead of
564 * window.c (temp_output_buffer_show): Call display_buffer with
565 second argument Vtemp_buffer_show_specifiers and reset latter
566 immediately after the call.
567 (Vtemp_buffer_show_specifiers): New variable.
568 (auto_window_vscroll_p, next_screen_context_lines)
569 (Vscroll_preserve_screen_position): Remove leading asterisks from
572 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
574 Fix minor problems found by GCC 4.6.0 static checking.
575 * buffer.c (Qclone_number): Remove for now, as it's unused.
576 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
577 (record_buffer): Remove unused local.
578 * frame.c (other_visible_frames, frame_buffer_list): Now static.
579 (set_frame_buffer_list): Remove; unused.
580 * frame.h (other_visible_frames): Remove decl.
581 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
582 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
583 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
585 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
586 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
587 Define only if HAVE_GPM.
588 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
589 (update_hints_inhibit): Remove; never set. All uses removed.
590 * widgetprv.h (emacsFrameClassRec): Remove decl.
591 * window.c (delete_deletable_window): Now returns void, since it
592 wasn't returning anything.
593 (compare_window_configurations): Remove unused locals.
594 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
595 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
596 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
597 the same widths as pointers. This follows up on the 2011-05-06 patch.
598 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
600 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
602 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
604 * makefile.w32-in: Update dependencies.
605 (LISP_H): Add lib/intprops.h.
607 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
609 * image.c (gif_load): Add animation frame delay to the metadata.
610 (syms_of_image): Use DEFSYM. New symbol `delay'.
612 2011-06-11 Martin Rudalics <rudalics@gmx.at>
614 * window.c (delete_deletable_window): Re-add.
615 (Fset_window_configuration): Rewrite to handle dead buffers and
616 consequently deletable windows.
617 (window_tree, Fwindow_tree): Remove. Supply functionality in
619 (compare_window_configurations): Simplify code.
621 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
623 * image.c (imagemagick_load_image): Fix type mismatch.
624 (Fimagemagick_types): Likewise.
626 * window.h (replace_buffer_in_windows): Declare.
628 2011-06-11 Martin Rudalics <rudalics@gmx.at>
630 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
631 Qclone_number. Remove external declaration of Qdelete_window.
632 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
634 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
635 Qbuffer_list_update_hook if allowed.
636 (Fother_buffer): Rewrite doc-string. Major rewrite for new
637 buffer list implementation.
638 (other_buffer_safely): New function.
639 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
640 calls to replace_buffer_in_windows and
641 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
643 (record_buffer): Inhibit quitting and rewrite using quittable
644 functions. Run Qbuffer_list_update_hook if allowed.
645 (Frecord_buffer, Funrecord_buffer): New functions.
646 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
647 switch-to-buffer to window.el.
648 (bury-buffer): Move to window.el.
649 (Vbuffer_list_update_hook): New variable.
651 * lisp.h (other_buffer_safely): Add prototype in buffer.c
654 * window.h (resize_frame_windows): Move up in code.
655 (Fwindow_frame): Remove EXFUN.
656 (replace_buffer_in_all_windows): Remove prototype.
657 (replace_buffer_in_windows_safely): Add prototype.
659 * window.c: Declare Qdelete_window static again. Move down
660 declaration of select_count.
661 (Fnext_window, Fprevious_window): Rewrite doc-strings.
662 (Fother_window): Move to window.el.
663 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
664 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
665 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
667 (replace_buffer_in_windows): Implement by calling
668 Qreplace_buffer_in_windows.
669 (replace_buffer_in_all_windows): Remove with some functionality
670 moved into replace_buffer_in_windows_safely.
671 (replace_buffer_in_windows_safely): New function.
672 (select_window_norecord, select_frame_norecord): Move in front
673 of run_window_configuration_change_hook. Remove now obsolete
675 (Fset_window_buffer): Rewrite doc-string. Call
676 Qrecord_window_buffer.
677 (keys_of_window): Move binding for other-window to window.el.
679 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
681 * dispextern.h (struct image): Replace data member, whose int_val
682 and ptr_val fields were not used by anything, with a single
685 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
686 (gif_clear_image, gif_load, imagemagick_load_image)
687 (gs_clear_image, gs_load): Callers changed.
689 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
691 * buffer.h: Include <time.h>, for time_t.
692 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
694 Fix minor problems found by static checking.
696 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
698 Make identifiers static if they are not used in other modules.
699 * data.c (Qcompiled_function, Qframe, Qvector):
700 * image.c (QimageMagick, Qsvg):
701 * minibuf.c (Qmetadata):
702 * window.c (resize_window_check, resize_root_window): Now static.
703 * window.h (resize_window_check, resize_root_window): Remove decls.
705 * window.c (window_deletion_count, delete_deletable_window):
707 (window_body_lines): Now static.
708 (Fdelete_other_windows_internal): Mark vars as initialized.
709 Make sure 'resize_failed' is initialized.
710 (run_window_configuration_change_hook): Rename local to avoid shadowing.
711 (resize_window_apply): Remove unused local.
712 * window.h (delete_deletable_window): Remove decl.
714 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
715 (imagemagick_load_image): Fix pointer signedness problem by changing
716 last arg from unsigned char * to char *. All uses changed.
717 Also, fix a local for similar reasons.
718 Remove unused locals. Remove locals to avoid shadowing.
719 (fn_rsvg_handle_free): Remove; unused.
720 (svg_load, svg_load_image): Fix pointer signedness problem.
721 (imagemagick_load_image): Don't use garbage pointer image_wand.
723 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
725 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
727 * image.c (gif_load): Fix omitted cast error introduced by
730 2011-06-10 Martin Rudalics <rudalics@gmx.at>
732 * window.h (resize_proportionally, orig_total_lines)
733 (orig_top_line): Remove from window structure.
734 (set_window_height, set_window_width, change_window_heights)
735 (Fdelete_window): Remove prototypes.
736 (resize_frame_windows): Remove duplicate declaration.
738 2011-06-10 Eli Zaretskii <eliz@gnu.org>
740 * window.h (resize_frame_windows, resize_window_check)
741 (delete_deletable_window, resize_root_window)
742 (resize_frame_windows): Declare prototypes.
744 * window.c (resize_window_apply): Make definition be "static" to
747 2011-06-10 Martin Rudalics <rudalics@gmx.at>
749 * window.c: Remove declarations of Qwindow_size_fixed,
750 window_min_size_1, window_min_size_2, window_min_size,
751 size_window, window_fixed_size_p, enlarge_window, delete_window.
752 Remove static from declaration of Qdelete_window, it's
753 temporarily needed by Fbury_buffer.
754 (replace_window): Don't assign orig_top_line and
756 (Fdelete_window, delete_window): Remove. Window deletion is
757 handled by window.el.
758 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
759 Fdelete_window calls with calls to Qdelete_window.
760 (Fdelete_other_windows): Remove. Deleting other windows is
761 handled by window.el.
762 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
763 handled in window.el.
764 (window_min_size_2, window_min_size_1, window_min_size): Remove.
765 Window minimum sizes are handled in window.el.
766 (shrink_windows, size_window, set_window_height)
767 (set_window_width, change_window_heights, window_height)
768 (window_width, CURBEG, CURSIZE, enlarge_window)
769 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
770 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
771 handled in window.el.
772 (make_dummy_parent): Rename to make_parent_window and give it a
773 second argument horflag.
774 (make_window): Don't set resize_proportionally any more.
775 (Fsplit_window): Remove. Windows are split in window.el.
776 (save_restore_action, save_restore_orig_size)
777 (shrink_window_lowest_first, save_restore_orig_size): Remove.
778 Resize mini windows in window.el.
779 (grow_mini_window, shrink_mini_window): Implement by calling
780 Qresize_root_window_vertically, resize_window_check and
782 (saved_window, Fset_window_configuration, save_window_save): Do
783 not handle orig_top_line, orig_total_lines, and
784 resize_proportionally.
785 (window_min_height, window_min_width): Move to window.el.
786 (keys_of_window): Move bindings for delete-other-windows,
787 split-window, delete-window and enlarge-window to window.el.
789 * buffer.c: Temporarily extern Qdelete_window.
790 (Fbury_buffer): Temporarily call Qdelete_window instead of
791 Fdelete_window (Fbury_buffer will move to window.el soon).
793 * frame.c (set_menu_bar_lines_1): Remove code handling
794 orig_top_line and orig_total_lines.
796 * dispnew.c (adjust_frame_glyphs_initially): Don't use
797 set_window_height but set heights directly.
798 (change_frame_size_1): Use resize_frame_windows.
800 * xdisp.c (init_xdisp): Don't use set_window_height but set
803 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
804 resize_frame_windows instead of change_window_heights and run
805 run_window_configuration_change_hook.
807 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
808 instead of change_window_heights and run
809 run_window_configuration_change_hook.
811 2011-06-09 Martin Rudalics <rudalics@gmx.at>
813 * window.c (replace_window): Rename second argument REPLACEMENT to
814 NEW. New third argument SETFLAG. Rewrite.
815 (delete_window, make_dummy_parent): Call replace_window with
817 (window_list_1): Move down in code.
818 (run_window_configuration_change_hook): Move set_buffer part
819 before select_frame_norecord part in order to unwind correctly.
820 Rename count1 to count.
821 (recombine_windows, delete_deletable_window, resize_root_window)
822 (Fdelete_other_windows_internal)
823 (Frun_window_configuration_change_hook, make_parent_window)
824 (resize_window_check, resize_window_apply, Fresize_window_apply)
825 (resize_frame_windows, Fsplit_window_internal)
826 (Fdelete_window_internal, Fresize_mini_window_internal): New
828 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
830 2011-06-08 Martin Rudalics <rudalics@gmx.at>
832 * window.h (window): Add some new members to window structure -
833 normal_lines, normal_cols, new_total, new_normal, clone_number,
834 splits, nest, prev_buffers, next_buffers.
835 (WINDOW_TOTAL_SIZE): Move here from window.c.
836 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
838 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
840 (make_dummy_parent): Set new members of windows structure.
841 (make_window): Move down in code. Handle new members of window
843 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
844 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
845 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
846 (Fset_window_prev_buffers, Fwindow_next_buffers)
847 (Fset_window_next_buffers, Fset_window_clone_number): New
849 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
850 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
852 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
853 Argument WINDOW can be now internal window too.
854 (Fwindow_use_time): Move up in code.
855 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
857 (Fset_window_configuration, saved_window)
858 (Fcurrent_window_configuration, save_window_save): Handle new
859 members of window structure.
860 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
861 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
862 (syms_of_window): New Lisp objects Qrecord_window_buffer,
863 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
864 Qget_mru_window, Qresize_root_window,
865 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
866 Qauto_buffer_name; staticpro them.
868 2011-06-07 Martin Rudalics <rudalics@gmx.at>
870 * window.c (Fwindow_total_size, Fwindow_left_column)
871 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
872 (Fwindow_list_1): New functions.
873 (window_box_text_cols): Replace with window_body_cols.
874 (Fwindow_width, Fscroll_left, Fscroll_right): Use
875 window_body_cols instead of window_box_text_cols.
876 (delete_window, Fset_window_configuration): Call
877 delete_all_subwindows with window as argument.
878 (delete_all_subwindows): Take a window as argument and not a
880 (window_loop): Remove handling of GET_LRU_WINDOW and
882 (Fget_lru_window, Fget_largest_window): Move to window.el.
884 * window.h: Extern window_body_cols instead of
885 window_box_text_cols. delete_all_subwindows now takes a
886 Lisp_Object as argument.
888 * indent.c (compute_motion, Fcompute_motion): Use
889 window_body_cols instead of window_box_text_cols.
891 * frame.c (delete_frame): Call delete_all_subwindows with root
894 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
896 * fns.c (Fputhash): Document return value.
898 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
900 * image.c (gif_load): Implement gif89a spec "no disposal" method.
902 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
904 Cons<->int and similar integer overflow fixes (Bug#8794).
906 Check for overflow when converting integer to cons and back.
907 * charset.c (Fdefine_charset_internal, Fdecode_char):
908 Use cons_to_unsigned to catch overflow.
909 (Fencode_char): Use INTEGER_TO_CONS.
910 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
911 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
912 * data.c (long_to_cons, cons_to_long): Remove.
913 (cons_to_unsigned, cons_to_signed): New functions.
914 These signal an error for invalid or out-of-range values.
915 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
916 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
917 * font.c (Ffont_variation_glyphs):
918 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
919 * lisp.h: Include <intprops.h>.
920 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
921 (cons_to_signed, cons_to_unsigned): New decls.
922 (long_to_cons, cons_to_long): Remove decls.
923 * undo.c (record_first_change): Use INTEGER_TO_CONS.
924 (Fprimitive_undo): Use CONS_TO_INTEGER.
925 * xfns.c (Fx_window_property): Likewise.
926 * xselect.c: Include <limits.h>.
927 (x_own_selection, selection_data_to_lisp_data):
929 (x_handle_selection_request, x_handle_selection_clear)
930 (x_get_foreign_selection, Fx_disown_selection_internal)
931 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
932 (lisp_data_to_selection_data): Use cons_to_unsigned.
933 (x_fill_property_data): Use cons_to_signed.
934 Report values out of range.
936 Check for buffer and string overflow more precisely.
937 * buffer.h (BUF_BYTES_MAX): New macro.
938 * lisp.h (STRING_BYTES_MAX): New macro.
939 * alloc.c (Fmake_string):
940 * character.c (string_escape_byte8):
941 * coding.c (coding_alloc_by_realloc):
943 * editfns.c (Fformat):
945 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
946 since they may not be the same number.
947 * editfns.c (Finsert_char):
948 * fileio.c (Finsert_file_contents):
949 Likewise for BUF_BYTES_MAX.
951 * image.c: Use ptrdiff_t, not int, for sizes.
952 (slurp_file): Switch from int to ptrdiff_t.
954 (slurp_file): Check that file size fits in both size_t (for
955 malloc) and ptrdiff_t (for sanity and safety).
957 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
958 if b->modtime has its maximal value.
960 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
962 Don't assume time_t can fit into int.
963 * buffer.h (struct buffer.modtime): Now time_t, not int.
964 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
965 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
967 Minor fixes for signed vs unsigned integers.
968 * character.h (MAYBE_UNIFY_CHAR):
969 * charset.c (maybe_unify_char):
970 * keyboard.c (read_char, reorder_modifiers):
971 XINT -> XFASTINT, since the integer must be nonnegative.
972 * ftfont.c (ftfont_spec_pattern):
973 * keymap.c (access_keymap, silly_event_symbol_error):
974 XUINT -> XFASTINT, since the integer must be nonnegative.
975 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
976 since it makes no difference and we prefer signed.
977 * keyboard.c (record_char): Use XUINT when all the neighbors do.
978 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
981 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
983 * window.h (Fwindow_frame): Declare.
985 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
987 * alloc.c: Simplify handling of large-request failures (Bug#8800).
988 (SPARE_MEMORY): Always define.
989 (LARGE_REQUEST): Remove.
990 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
992 2011-06-06 Martin Rudalics <rudalics@gmx.at>
994 * lisp.h: Move EXFUNS for Fframe_root_window,
995 Fframe_first_window and Fset_frame_selected_window to window.h.
997 * window.h: Move EXFUNS for Fframe_root_window,
998 Fframe_first_window and Fset_frame_selected_window here from
1001 * frame.c (Fwindow_frame, Fframe_first_window)
1002 (Fframe_root_window, Fframe_selected_window)
1003 (Fset_frame_selected_window): Move to window.c.
1004 (Factive_minibuffer_window): Move to minibuf.c.
1005 (Fother_visible_frames_p): New function.
1007 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1009 * window.c (decode_window, decode_any_window): Move up in code.
1010 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1011 (inhibit_frame_unsplittable): Remove unused variable.
1012 (Fwindow_buffer): Move up and rewrite doc-string.
1013 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1014 (Fwindow_prev): New functions.
1015 (Fwindow_frame): Move here from frame.c. Accept any window as
1017 (Fframe_root_window, Fframe_first_window)
1018 (Fframe_selected_window): Move here from frame.c. Accept frame
1019 or arbitrary window as argument. Update doc-strings.
1020 (Fminibuffer_window): Move up in code.
1021 (Fwindow_minibuffer_p): Move up in code and simplify.
1022 (Fset_frame_selected_window): Move here from frame.c.
1024 (Fselected_window, select_window, Fselect_window): Move up in
1025 code. Minor doc-string fixes.
1027 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1029 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1030 Do not assume that spare memory exists; that assumption is valid
1031 only if SYSTEM_MALLOC.
1032 (LARGE_REQUEST): New macro, so that the issue of large requests
1033 is separated from the issue of spare memory.
1035 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1037 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1040 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1042 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1045 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1047 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1049 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1051 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1052 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1054 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1056 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1058 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1060 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1061 (x_clipboard_manager_save): Add return value.
1062 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1064 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1065 Obey Vx_select_enable_clipboard_manager. Catch errors in
1066 x_clipboard_manager_save (Bug#8779).
1067 (Vx_select_enable_clipboard_manager): New variable.
1068 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1070 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1072 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1074 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1076 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1077 in the current matrix if keep_current_p is non-zero.
1079 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1081 * bidi.c (bidi_level_of_next_char): Fix last change.
1083 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1085 Support bidi reordering of text covered by display properties.
1087 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1088 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1089 (bidi_cache_search, bidi_cache_iterator_state)
1090 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1091 (bidi_level_of_next_char, bidi_move_to_visually_next):
1092 Support character positions inside a run of characters covered by a
1094 (bidi_paragraph_init, bidi_resolve_explicit_1)
1095 (bidi_level_of_next_char): Call bidi_fetch_char and
1096 bidi_fetch_char_advance instead of FETCH_CHAR and
1098 (bidi_init_it): Initialize new members.
1099 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1101 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1102 instead of using explicit *_CHAR codes.
1103 (bidi_resolve_explicit, bidi_resolve_weak):
1104 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1105 bidirectional text is supported only in multibyte buffers.
1106 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1107 it to initialize the frame_window_p member of struct bidi_it.
1108 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1109 (bidi_resolve_explicit, bidi_resolve_weak)
1110 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1111 bidi_it->nchars is non-positive.
1112 (bidi_level_of_next_char): Don't try to lookup the cache for the
1113 next/previous character if nothing is cached there yet, or if we
1114 were just reseat()'ed to a new position.
1116 * xdisp.c (set_cursor_from_row): Set start and stop points
1117 according to the row's direction when priming the loop that looks
1118 for the glyph on which to display cursor.
1119 (single_display_spec_intangible_p): Function deleted.
1120 (display_prop_intangible_p): Reimplement to call
1121 handle_display_spec instead of single_display_spec_intangible_p.
1122 Accept 3 additional arguments needed by handle_display_spec.
1123 This fixes incorrect cursor motion across display property with complex
1124 values: lists, `(when COND...)' forms, etc.
1125 (single_display_spec_string_p): Support property values that are
1126 lists with the argument STRING its top-level element.
1127 (display_prop_string_p): Fix the condition for processing a
1128 property that is a list to be consistent with handle_display_spec.
1129 (handle_display_spec): New function, refactored from the
1130 last portion of handle_display_prop.
1131 (compute_display_string_pos): Accept additional argument
1132 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1133 value of a `display' property is a "replacing spec".
1134 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1135 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1136 the display property, but just return a value indicating whether
1137 the display property will replace the characters it covers.
1138 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1139 frame_window_p members of struct bidi_it.
1140 (compute_display_string_pos, compute_display_string_end):
1142 (push_it): Accept second argument POSITION, where pop_it should
1143 jump to continue iteration.
1144 (reseat_1): Initialize bidi_it.disp_pos.
1146 * keyboard.c (adjust_point_for_property): Adjust the call to
1147 display_prop_intangible_p to its new signature.
1149 * dispextern.h (struct bidi_it): New member frame_window_p.
1150 (bidi_init_it): Update prototypes.
1151 (display_prop_intangible_p): Update prototype.
1152 (compute_display_string_pos, compute_display_string_end):
1154 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1157 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1159 Malloc failure behavior now depends on size of allocation.
1160 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1161 * lisp.h: Change signatures accordingly.
1162 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1163 All callers changed. (Bug#8762)
1165 * gnutls.c: Use Emacs's memory allocators.
1166 Without this change, the gnutls library would invoke malloc etc.
1167 directly, which causes problems on non-SYNC_INPUT hosts, and which
1168 runs afoul of improving memory_full behavior. (Bug#8761)
1169 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1170 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1171 xfree instead of the default malloc, realloc, free.
1172 (Fgnutls_boot): No need to check for memory allocation failure,
1173 since xmalloc does that for us.
1175 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1176 * category.c (hash_get_category_set):
1177 * ccl.c (ccl_driver):
1178 * charset.c (Fdefine_charset_internal):
1179 * charset.h (struct charset.hash_index):
1180 * composite.c (get_composition_id, gstring_lookup_cache)
1181 (composition_gstring_put_cache):
1182 * composite.h (struct composition.hash_index):
1183 * dispextern.h (struct image.hash):
1184 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1185 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1186 (hashfn_equal, hashfn_user_defined, make_hash_table)
1187 (maybe_resize_hash_table, hash_lookup, hash_put)
1188 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1189 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1190 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1191 * image.c (make_image, search_image_cache, lookup_image)
1192 (xpm_put_color_table_h):
1193 * lisp.h (struct Lisp_Hash_Table):
1194 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1195 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1196 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1197 * alloc.c (allocate_vectorlike):
1198 Check for overflow in vector size calculations.
1199 * ccl.c (ccl_driver):
1200 Check for overflow when converting EMACS_INT to int.
1201 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1202 need to be updated by these changes.
1203 * fns.c (make_hash_table, maybe_resize_hash_table):
1204 Check for integer overflow with large hash tables.
1205 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1206 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1207 (SXHASH_REDUCE): New macro.
1208 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1209 Use it instead of discarding useful hash info with large hash values.
1210 (sxhash_float): New function.
1211 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1212 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1213 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1214 Rewrite to use FIXNUM_BITS, as this simplifies things.
1215 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1216 Adjust signatures to match updated version of code.
1217 (consing_since_gc): Now EMACS_INT, since a single hash table can
1218 use more than INT_MAX bytes.
1220 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1222 Make it possible to build with GCC-4.6+ -O2 -flto.
1224 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1226 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1228 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1229 Call minibuffer-inactive-mode.
1231 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1233 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1234 Update dependencies.
1236 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1238 * data.c (init_data): Remove code for UTS, this system is not
1241 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1243 Don't force ./temacs to start in terminal mode.
1245 * frame.c (make_initial_frame): Initialize faces in all cases, not
1246 only when CANNOT_DUMP is defined.
1247 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1249 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1251 * dispnew.c (add_window_display_history): Use const for the string
1252 pointer. Remove declaration, not needed.
1254 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1256 Use 'inline', not 'INLINE'.
1257 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1258 * alloc.c, fontset.c (INLINE): Remove.
1259 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1260 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1261 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1262 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1263 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1265 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1267 Make it possible to run ./temacs.
1269 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1270 syms_of_callproc does the same thing. Remove test for
1271 "initialized", do it in the caller.
1272 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1274 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1276 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1277 (read_minibuf): Use get_minibuffer.
1278 (syms_of_minibuf): Use DEFSYM.
1279 (Qmetadata): New var.
1280 * data.c (Qbuffer): Don't make it static.
1281 (syms_of_data): Use DEFSYM.
1283 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1285 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1286 (CCL_CODE_MIN): New macro.
1288 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1290 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1292 * eval.c (Qdebug): Now static.
1293 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1294 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1295 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1297 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1299 * image.c: Various fixes to ImageMagick code comments.
1300 (Fimagemagick_types): Doc fix.
1302 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1304 Minor fixes prompted by GCC 4.6.0 warnings.
1306 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1308 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1309 (x_clipboard_manager_save_all): Move extern decl to ...
1310 * xterm.h: ... here, so that it can be checked for consistency.
1312 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1314 * xselect.c (x_clipboard_manager_save_frame)
1315 (x_clipboard_manager_save_all): New functions.
1316 (Fx_clipboard_manager_save): Lisp function deleted.
1318 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1319 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1321 * xterm.h: Update prototype.
1323 2011-05-28 William Xu <william.xwl@gmail.com>
1325 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1328 2011-05-28 Jim Meyering <meyering@redhat.com>
1330 Avoid a sign-extension bug in crypto_hash_function.
1331 * fns.c (to_uchar): Define.
1332 (crypto_hash_function): Use it to convert some newly-signed
1333 variables to unsigned, to avoid sign-extension bugs. For example,
1334 without this change, (md5 "truc") would evaluate to
1335 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1336 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1337 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1339 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1341 Integer overflow fixes.
1343 * dbusbind.c: Serial number integer overflow fixes.
1344 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1345 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1346 to hold a serial number that is too large for a fixnum.
1347 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1348 Check for serial numbers out of range. Decode any serial number
1349 that was so large that it became a float. (Bug#8722)
1351 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1352 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1353 Use XFASTINT rather than XUINT when numbers are nonnegative.
1354 (xd_append_arg, Fdbus_method_return_internal):
1355 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1356 arguments, check that Lisp number is nonnegative, rather than
1357 silently wrapping negative numbers around. (Bug#8722)
1358 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1361 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1363 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1365 ccl: add integer overflow checks
1366 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1367 (IN_INT_RANGE): New macros.
1368 (ccl_driver): Use them to check for integer overflow when
1369 decoding a CCL program. Many of the new checks are whether XINT (x)
1370 fits in int; it doesn't always, on 64-bit hosts. The new version
1371 doesn't catch all possible integer overflows, but it's an
1372 improvement. (Bug#8719)
1374 * alloc.c (make_event_array): Use XINT, not XUINT.
1375 There's no need for unsigned here.
1377 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1378 This follows up to the 2011-05-06 change that substituted uintptr_t
1379 for EMACS_INT. This case wasn't caught back then.
1381 Rework Fformat to avoid integer overflow issues.
1382 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1383 now (part of C89). Include <verify.h>.
1384 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1385 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1386 (Fformat): Avoid the prepass trying to compute sizes; it was only
1387 approximate and thus did not catch overflow reliably. Instead, walk
1388 through the format just once, formatting and computing sizes as we go,
1389 checking for integer overflow at every step, and allocating a larger
1390 buffer as needed. Keep track separately whether the format is
1391 multibyte. Keep only the most-recently calculated precision, rather
1392 than them all. Record whether each argument has been converted to
1393 string. Use EMACS_INT, not int, for byte and char and arg counts.
1394 Support field widths and precisions larger than INT_MAX. Avoid
1395 sprintf's undefined behavior with conversion specifications such as %#d
1396 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1397 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1398 formatting out-of-range floating point numbers with int
1401 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1403 * data.c: Avoid integer truncation in expressions involving floats.
1404 * data.c: Include <intprops.h>.
1405 (arith_driver): When there's an integer overflow in an expression
1406 involving floating point, convert the integers to floating point
1407 so that the resulting value does not suffer from catastrophic
1408 integer truncation. For example, on a 64-bit host (* 4
1409 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1410 Do not rely on undefined behavior after integer overflow.
1412 merge count_size_as_multibyte, parse_str_to_multibyte
1413 * character.c, character.h (count_size_as_multibyte):
1414 Rename from parse_str_to_multibyte; all uses changed.
1415 Check for integer overflow.
1416 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1417 since it's now a duplicate of the other. This is more of
1418 a character than a buffer op, so better that it's in character.c.
1419 * fns.c, print.c: Adjust to above changes.
1421 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1423 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1425 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1427 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1428 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1429 (x_clipboard_manager_save): Now static.
1430 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1432 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1433 (crypto_hash_function): Now static.
1434 Fix pointer signedness problems. Avoid unnecessary initializations.
1436 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1438 * termhooks.h (Vselection_alist): Make it terminal-local.
1440 * terminal.c (create_terminal): Initialize it.
1442 * xselect.c: Support for clipboard managers.
1443 (Vselection_alist): Move to termhooks.h as terminal-local var.
1444 (LOCAL_SELECTION): New macro.
1445 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1446 (symbol_to_x_atom): Remove gratuitous arg.
1447 (x_handle_selection_request, lisp_data_to_selection_data)
1448 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1449 (x_own_selection, x_get_local_selection, x_convert_selection):
1450 New arg, specifying work frame. Use terminal-local Vselection_alist.
1451 (some_frame_on_display): Delete unused function.
1452 (Fx_own_selection_internal, Fx_get_selection_internal)
1453 (Fx_disown_selection_internal, Fx_selection_owner_p)
1454 (Fx_selection_exists_p): New optional frame arg.
1455 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1456 (x_handle_selection_clear): Don't treat other terminals with the
1457 same keyboard specially. Use the terminal-local Vselection_alist.
1458 (x_clear_frame_selections): Use Frun_hook_with_args.
1460 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1462 * xterm.h: Add support for those atoms.
1464 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1466 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1467 (converted_selections, conversion_fail_tag): New global variables.
1468 (x_selection_request_lisp_error): Free the above.
1469 (x_get_local_selection): Remove unnecessary code.
1470 (x_reply_selection_request): Args changed; handle arbitrary array
1471 of converted selections stored in converted_selections.
1472 Separate the XChangeProperty and SelectionNotify steps.
1473 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1474 (x_convert_selection): New function.
1475 (x_handle_selection_event): Simplify.
1476 (x_get_foreign_selection): Don't ignore incoming requests while
1477 waiting for an answer; this will fail when we implement
1478 SAVE_TARGETS, and seems unnecessary anyway.
1479 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1480 (Vx_sent_selection_functions): Doc fix.
1482 2011-05-26 Leo Liu <sdl.web@gmail.com>
1484 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1486 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1488 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1490 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1491 for fringe update if it has periodic bitmap.
1492 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1493 and fringe_bitmap_periodic_p.
1495 * fringe.c (get_fringe_bitmap_data): New function.
1496 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1497 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1498 row. Mark glyph row for fringe update if periodicity changed.
1500 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1501 for fringe update unless it has periodic bitmap.
1503 2011-05-25 Kenichi Handa <handa@m17n.org>
1505 * xdisp.c (get_next_display_element): Set correct it->face_id for
1506 a static composition.
1508 2011-05-24 Leo Liu <sdl.web@gmail.com>
1511 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1513 * fns.c (crypto_hash_function, Fsha1): New function.
1514 (Fmd5): Use crypto_hash_function.
1515 (syms_of_fns): Add Ssha1.
1517 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1519 * gnutls.c: Remove unused macros.
1520 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1521 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1522 Remove macros that are defined and never used.
1523 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1525 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1527 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1528 (Fx_get_selection_internal): Minor cleanup.
1529 (Fx_own_selection_internal): Rename arguments for consistency with
1532 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1534 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1536 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1538 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1540 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1542 * dispnew.c (scrolling_window): Don't exclude the case that the
1543 last enabled row in the desired matrix touches the bottom boundary.
1545 2011-05-21 Glenn Morris <rgm@gnu.org>
1547 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1548 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1549 and add some more files.
1551 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1553 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1554 report_file_error introduced by the change from 2011-05-07.
1556 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1558 * systime.h (Time): Define only if emacs is defined.
1559 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1560 where the include path doesn't have X11/X.h by default. See
1561 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1563 2011-05-20 Kenichi Handa <handa@m17n.org>
1565 * composite.c (find_automatic_composition): Fix previous change.
1567 2011-05-20 Glenn Morris <rgm@gnu.org>
1569 * lisp.mk: New file, split from Makefile.in.
1570 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1571 (shortlisp): Remove.
1572 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1574 2011-05-19 Glenn Morris <rgm@gnu.org>
1576 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1577 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1578 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1579 (lisp): Set the order to that of loadup.el.
1580 (shortlisp): Make it a copy of $lisp.
1581 (SOME_MACHINE_LISP): Remove.
1582 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1583 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1585 2011-05-18 Kenichi Handa <handa@m17n.org>
1587 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1588 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1589 (find_automatic_composition): Mostly rewrite for efficiency.
1591 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1593 * makefile.w32-in: Update dependencies.
1595 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1597 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1598 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1600 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1602 Fix some integer overflow issues, such as string length overflow.
1604 * insdel.c (count_size_as_multibyte): Check for string overflow.
1606 * character.c (lisp_string_width): Check for string overflow.
1607 Use EMACS_INT, not int, for string indexes and lengths; in
1608 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1609 the resulting string length overflows an EMACS_INT; instead,
1610 report a string overflow if no precision given. When checking for
1611 precision exhaustion, use a check that cannot possibly have
1612 integer overflow. (Bug#8675)
1613 * character.h (lisp_string_width): Adjust to new signature.
1615 * alloc.c (string_overflow): New function.
1616 (Fmake_string): Use it. This doesn't change behavior, but saves
1617 a few bytes and will simplify future changes.
1618 * character.c (string_escape_byte8): Likewise.
1619 * lisp.h (string_overflow): New decl.
1621 Fixups, following up to the user-interface timestamp change.
1622 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1623 for UI timestamps, instead of unsigned long.
1624 * msdos.c (mouse_get_pos): Likewise.
1625 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1626 * w32gui.h (Time): Define by including "systime.h" rather than by
1627 declaring it ourselves. (Bug#8664)
1629 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1630 * image.c (clear_image_cache): Likewise.
1632 * term.c (term_mouse_position): Don't assume time_t wraparound.
1634 Be more systematic about user-interface timestamps.
1635 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1636 and sometimes 'EMACS_UINT', to represent these timestamps.
1637 This change causes it to use 'Time' uniformly, as that's what X uses.
1638 This makes the code easier to follow, and makes it easier to catch
1639 integer overflow bugs such as Bug#8664.
1640 * frame.c (Fmouse_position, Fmouse_pixel_position):
1641 Use Time, not unsigned long, for user-interface timestamps.
1642 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1643 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1644 * keyboard.h (last_event_timestamp): Likewise.
1645 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1646 * menu.h (xmenu_show): Likewise.
1647 * term.c (term_mouse_position): Likewise.
1648 * termhooks.h (struct input_event.timestamp): Likewise.
1649 (struct terminal.mouse_position_hook): Likewise.
1650 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1651 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1652 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1653 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1655 * menu.h, termhooks.h: Include "systime.h", for Time.
1657 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1658 Don't assume that the difference between two unsigned long values
1659 can fit into an integer. At this point, we know button_down_time
1660 <= event->timestamp, so the difference must be nonnegative, so
1661 there's no need to cast the result if double-click-time is
1662 nonnegative, as it should be; check that it's nonnegative, just in
1663 case. This bug is triggered when events are more than 2**31 ms
1664 apart (about 25 days). (Bug#8664)
1666 * xselect.c (last_event_timestamp): Remove duplicate decl.
1667 (x_own_selection): Remove needless cast to unsigned long.
1669 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1670 that always fit in int. Use a sentinel instead of a counter, to
1671 avoid a temp and to allay GCC's concerns about possible int overflow.
1672 * frame.h (struct frame): Use int for menu_bar_items_used
1673 instead of EMACS_INT, since it always fits in int.
1675 * menu.c (grow_menu_items): Check for int overflow.
1677 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1679 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1680 Before, the code was not consistent. These values cannot exceed
1681 2**31 - 1 so there's no need to make them unsigned.
1682 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1683 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1684 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1686 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1688 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1689 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1690 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1691 presumably because the widths might not match.
1693 * window.c (size_window): Avoid needless test at loop start.
1695 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1697 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1699 2011-05-12 Drew Adams <drew.adams@oracle.com>
1701 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1703 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1705 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1706 `width' to `bar_area_x' and `bar_area_width', respectively.
1707 (x_scroll_run): Take account of fringe background extension.
1709 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1710 Rename local vars `left' and `width' to `bar_area_x' and
1711 `bar_area_width', respectively.
1712 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1713 background extension.
1715 2011-05-10 Jim Meyering <meyering@redhat.com>
1717 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1719 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1721 * image.c (Finit_image_library): Return t for built-in image types,
1722 like pbm and xbm. (Bug#8640)
1724 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1726 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1728 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1730 * w32console.c (Fset_screen_color): Doc fix.
1731 (Fget_screen_color): New function.
1732 (syms_of_ntterm): Defsubr it.
1734 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1735 unlink the temporary file if Fcall_process didn't create it in the
1737 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1738 child process will be redirected to a file specified with `:file'.
1739 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1740 cue to call_process_cleanup not to close that handle.
1742 2011-05-07 Ben Key <bkey76@gmail.com>
1744 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1745 one of two shell specific rules, either bootstrap-temacs-CMD or
1746 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1747 to the previous implementation of the bootstrap-temacs rule.
1748 The bootstrap-temacs-CMD rule is similar to the previous
1749 implementation of the bootstrap-temacs rule except that it
1750 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1753 These changes, along with some changes to nt/configure.bat,
1754 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1755 earlier fix to add support for --cflags and --ldflags options
1756 that include quotes so that it works whether make uses cmd or
1759 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1761 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1762 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1764 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1765 a string. Handle both cases.
1766 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1767 (Fdbus_register_method): Use Qinvalid_function.
1769 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1771 * makefile.w32-in: Update dependencies.
1772 (LISP_H): Add inttypes.h and stdin.h.
1773 (PROCESS_H): Add unistd.h.
1775 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1777 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1778 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1780 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1782 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1784 * term.c (vfatal): Remove stray call to va_end.
1785 It's not needed and the C Standard doesn't allow it here anyway.
1787 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1788 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1790 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1793 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1795 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1797 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1799 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1801 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1803 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1804 * charset.c (Fdefine_charset_internal): Don't initialize
1805 charset.code_space[15]. The value was garbage, on hosts with
1806 32-bit int (Bug#8600).
1808 * lread.c (read_integer): Be more consistent with string-to-number.
1809 Use string_to_number to do the actual conversion; this avoids
1810 rounding errors and fixes some other screwups. Without this fix,
1811 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1812 (digit_to_number): Move earlier, for benefit of read_integer.
1813 Return -1 if the digit is out of range for the base, -2 if it is
1814 not a digit in any supported base. (Bug#8602)
1816 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1818 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1819 to match comment at start of function. This also removes a
1820 GCC warning about overflow in a 32+64-bit port.
1822 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1824 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1825 Reported by Stefan Monnier in
1826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1827 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1828 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1830 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1831 (EMACS_UINTPTR): Likewise, with uintptr_t.
1833 * lisp.h: Prefer 64-bit EMACS_INT if available.
1834 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1835 on 32-bit hosts that have 64-bit int, so that they can access
1837 However, temporarily disable this change unless the temporary
1838 symbol WIDE_EMACS_INT is defined.
1840 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1842 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1843 This removes an assumption that EMACS_INT and long are the same
1844 width as pointers. The assumption is true for Emacs porting targets
1845 now, but we want to make other targets possible.
1846 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1847 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1848 In the rest of the code, change types of integers that hold casted
1849 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1850 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1851 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1852 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1853 No need to cast type when ORing.
1854 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1855 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1856 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1857 assume EMACS_INT is the same width as char *.
1858 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1859 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1860 Remove no-longer-needed casts.
1861 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1862 (xg_tool_bar_help_callback, xg_make_tool_item):
1863 Use EMACS_INTPTR to hold an integer
1864 that will be cast to void *; this can avoid a GCC warning
1865 if EMACS_INT is not the same width as void *.
1866 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1867 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1868 (current_message_1, set_message_1):
1869 Use a local to convert to proper width without a cast.
1870 * xmenu.c (dialog_selection_callback): Likewise.
1872 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1873 Also, don't assume VALBITS / RAND_BITS is less than 5,
1874 and don't rely on undefined behavior when shifting a 1 left into
1876 * lisp.h (get_random): Change signature to match.
1878 * lread.c (hash_string): Use size_t, not int, for hash computation.
1879 Normally we prefer signed values; but hashing is special, because
1880 it's better to use unsigned division on hash table sizes so that
1881 the remainder is nonnegative. Also, size_t is the natural width
1882 for hashing into memory. The previous code used 'int', which doesn't
1883 retain enough info to hash well into very large tables.
1884 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1886 * dbusbind.c: Don't possibly lose pointer info when converting.
1887 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1888 Use XPNTR rather than XHASH, so that the high-order bits of
1889 the pointer aren't lost when converting through void *.
1891 * eval.c (Fautoload): Don't double-shift a pointer.
1893 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1895 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1897 * gnutls.c (DEF_GNUTLS_FN):
1898 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1900 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1902 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1905 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1907 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1908 New version that can reserve upto 2GB of heap space.
1910 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1912 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1914 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1916 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1917 `gnutls_certificate_set_x509_key_file'.
1919 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1921 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1922 Update dependencies.
1924 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1926 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1927 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1928 Remove unused parameter `fildes'.
1929 * process.c (read_process_output, send_process): Don't pass it.
1931 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1933 Fix previous change: the library cache is defined in w32.c.
1934 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1935 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1937 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1939 Implement dynamic loading of GnuTLS on Windows.
1941 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1942 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1943 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1946 * gnutls.c (Qgnutls_dll): Define.
1947 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1948 (gnutls_*): Declare function pointers.
1949 (init_gnutls_functions): New function to initialize function pointers.
1950 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1951 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1952 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1953 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1954 (emacs_gnutls_write, emacs_gnutls_read)
1955 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1956 (Fgnutls_available_p): New function.
1957 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1958 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1959 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1961 * image.c: Include w32.h.
1962 (Vimage_type_cache): Delete.
1963 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1964 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1965 (w32_delayed_load): Move to w32.c.
1967 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1969 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1970 (w32_delayed_load): Move from image.c. When loading a library, record
1971 its filename in the :loaded-from property of the library id.
1972 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1973 Initialize and staticpro them.
1974 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1976 * process.c: Include lisp.h before w32.h, not after.
1977 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1978 instead of gnutls_record_check_pending.
1980 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1982 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1984 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1985 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1988 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1990 * xterm.c (x_set_frame_alpha): Do not set property on anything
1991 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1993 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1995 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1997 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1999 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2000 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2001 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2002 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2003 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2004 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2005 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2006 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2007 (Qgnutls_bootprop_callbacks_verify): Make static.
2009 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2011 * callproc.c: Indentation fixup.
2013 * sysdep.c (wait_for_termination_1): Make static.
2014 (wait_for_termination, interruptible_wait_for_termination):
2015 Move after wait_for_termination_1.
2017 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2019 * sysdep.c (interruptible_wait_for_termination): New function
2020 which is like wait_for_termination, but allows keyboard
2023 * callproc.c (Fcall_process): Add (:file "file") as an option for
2025 (Fcall_process_region): Ditto.
2027 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2029 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2030 rather than `XVECTOR (FOO)->size'.
2032 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2033 inttypes.h, as a gnulib replacement is used if it not available in
2036 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2038 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2039 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2040 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2042 * coding.c (coding_alloc_by_realloc): Error out if destination
2043 will grow beyond MOST_POSITIVE_FIXNUM.
2044 (decode_coding_emacs_mule): Abort if there isn't enough place in
2045 charbuf for the composition carryover bytes. Reserve an extra
2046 space for up to 2 characters produced in a loop.
2047 (decode_coding_iso_2022): Abort if there isn't enough place in
2048 charbuf for the composition carryover bytes.
2050 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2052 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2053 aborting when %lld or %lll format is passed.
2054 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2055 %llo or %llx format is passed. (Bug#8545)
2057 * window.c (window_scroll_line_based): Use a marker instead of
2058 simple variables to record original value of point. (Bug#7952)
2060 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2061 produced by %s or %c overflows available buffer space. (Bug#8545)
2063 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2065 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2066 (SIZE_MAX): Move defn after all includes, as they might #define it.
2068 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2070 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2072 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2074 * keyboard.c (Qdelayed_warnings_hook): Define.
2075 (command_loop_1): Run `delayed-warnings-hook'
2076 if Vdelayed_warnings_list is non-nil.
2077 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2078 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2080 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2082 * doprnt.c (doprnt): Don't return value smaller than the buffer
2083 size if the message was truncated. (Bug#8545).
2085 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2087 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2088 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2090 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2092 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2094 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2096 * makefile.w32-in: Update dependencies.
2098 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2100 Improve `doprnt' and its usage. (Bug#8545)
2101 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2102 `format_end'. Remove support for %l as a conversion specifier.
2103 Don't use xrealloc. Improve diagnostics when the %l size modifier
2104 is used. Update the commentary.
2106 * eval.c (verror): Simplify calculation of size_t.
2108 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2111 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2113 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2116 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2118 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2119 This makes this file independent of the recent pseudovector change.
2121 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2123 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2125 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2126 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2127 Remove unused local.
2128 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2130 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2131 GCC 4.6.0 optimizes based on type-based alias analysis.
2132 For example, if b is of type struct buffer * and v of type struct
2133 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2134 != &v->size, and therefore "v->size = 1; b->size = 2; return
2135 v->size;" must therefore return 1. This assumption is incorrect
2136 for Emacs, since it type-puns struct Lisp_Vector * with many other
2137 types. To fix this problem, this patch adds a new type struct
2138 vectorlike_header that documents the constraints on layout of vectors
2139 and pseudovectors, and helps optimizing compilers not get fooled
2140 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2141 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2142 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2144 (XSETPVECTYPE): Rewrite in terms of new macro.
2145 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2146 This is a bit clearer, and further avoids the possibility of
2147 undesirable aliasing.
2148 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2149 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2150 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2151 since Lisp_Subr is a special case (no "next" field).
2152 (ASIZE): Now uses header.size rather than size.
2153 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2154 to avoid the hassle of writing XVECTOR (foo)->header.size.
2155 (struct vectorlike_header): New type.
2156 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2157 object, to help avoid aliasing.
2158 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2159 (SUBRP): Likewise, since Lisp_Subr is a special case.
2160 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2161 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2162 (struct Lisp_Hash_Table): Combine first two members into a single
2163 struct vectorlike_header member. All uses of "size" and "next" members
2164 changed to be "header.size" and "header.next".
2165 * buffer.h (struct buffer): Likewise.
2166 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2167 * frame.h (struct frame): Likewise.
2168 * process.h (struct Lisp_Process): Likewise.
2169 * termhooks.h (struct terminal): Likewise.
2170 * window.c (struct save_window_data, struct saved_window): Likewise.
2171 * window.h (struct window): Likewise.
2172 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2173 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2174 * buffer.c (init_buffer_once): Likewise.
2175 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2177 * process.c (Fformat_network_address): Use local var for size,
2180 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2182 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2183 * data.c (atof): Remove decl; no longer used or needed.
2184 (digit_to_number): Move to lread.c.
2185 (Fstring_to_number): Use new string_to_number function, to be
2186 consistent with how the Lisp reader treats infinities and NaNs.
2187 Do not assume that floating-point numbers represent EMACS_INT
2188 without losing information; this is not true on most 64-bit hosts.
2189 Avoid double-rounding errors, by insisting on integers when
2190 parsing non-base-10 numbers, as the documentation specifies.
2191 * lisp.h (string_to_number): New decl, replacing ...
2192 (isfloat_string): Remove.
2193 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2194 (read1): Do not accept +. and -. as integers; this
2195 appears to have been a coding error. Similarly, do not accept
2196 strings like +-1e0 as floating point numbers. Do not report
2197 overflow for integer overflows unless the base is not 10 which
2198 means we have no simple and reliable way to continue.
2199 Break out the floating-point parsing into a new
2200 function string_to_number, so that Fstring_to_number parses
2201 floating point numbers consistently with the Lisp reader.
2202 (digit_to_number): Move here from data.c. Make it static inline.
2203 (E_CHAR, EXP_INT): Remove, replacing with ...
2204 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2205 (string_to_number): New function, replacing isfloat_string.
2206 This function checks for valid syntax and produces the resulting
2207 Lisp float number too. Rework it so that string-to-number
2208 no longer mishandles examples like "1.0e+". Use strtoumax,
2209 so that overflow for non-base-10 numbers is reported only when
2210 there's no portable and simple way to convert to floating point.
2212 * textprop.c (set_text_properties_1): Rewrite for clarity,
2213 and to avoid GCC warning about integer overflow.
2215 * intervals.h (struct interval): Use EMACS_INT for members
2216 where EMACS_UINT might cause problems. See
2217 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2218 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2219 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2221 (offset_intervals): Tell GCC not to worry about length overflow
2222 when negating a negative length.
2224 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2225 (overrun_check_free): Likewise.
2227 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2228 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2231 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2232 (gnutls_make_error): Rename local to avoid shadowing.
2233 (gnutls_emacs_global_deinit): ifdef out; not used.
2234 (Fgnutls_boot): Use const for pointer to readonly storage.
2235 Comment out unused local. Fix pointer signedness problems.
2237 * lread.c (openp): Don't stuff size_t into an 'int'.
2238 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2239 about possible signed overflow.
2241 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2242 (GDK_KEY_g): Don't define if already defined.
2243 (xg_prepare_tooltip): Avoid pointer signedness problem.
2244 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2246 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2247 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2249 * xfns.c (Fx_window_property): Simplify a bit,
2250 to make a bit faster and to avoid GCC 4.6.0 warning.
2251 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2253 * fns.c (internal_equal): Don't assume size_t fits in int.
2255 * alloc.c (compact_small_strings): Tighten assertion a little.
2257 Replace pEd with more-general pI, and fix some printf arg casts.
2258 * lisp.h (pI): New macro, generalizing old pEd macro to other
2259 conversion specifiers. For example, use "...%"pI"d..." rather
2260 than "...%"pEd"...".
2261 (pEd): Remove. All uses replaced with similar uses of pI.
2262 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2263 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2264 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2265 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2266 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2267 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2268 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2270 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2271 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2272 * print.c (safe_debug_print, print_object): Likewise.
2273 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2275 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2276 avoiding the 0 flag, which is not portable.
2277 * process.c (Fmake_network_process): Use pI to avoid cast.
2278 * region-cache.c (pp_cache): Likewise.
2279 * xdisp.c (decode_mode_spec): Likewise.
2280 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2281 behavior on 64-bit hosts with printf arg.
2282 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2283 (x_stop_queuing_selection_requests): Likewise.
2284 (x_get_window_property): Don't truncate byte count to an 'int'
2287 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2288 here, since it parses constructs like leading '-' and spaces,
2289 which are not wanted; and it overflows with large numbers.
2290 Instead, simply match F[0-9]+, which is what is wanted anyway.
2292 * alloc.c: Remove unportable assumptions about struct layout.
2293 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2294 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2295 (allocate_vectorlike, make_pure_vector): Use the new macros,
2296 plus offsetof, to remove unportable assumptions about struct layout.
2297 These assumptions hold on all porting targets that I know of, but
2298 they are not guaranteed, they're easy to remove, and removing them
2299 makes further changes easier.
2301 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2302 This doesn't fix a bug but makes the code clearer.
2303 (string_overrun_cookie): Now const. Use initializers that
2304 don't formally overflow signed char, to avoid warnings.
2305 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2306 can cause Emacs to crash when string overrun checking is enabled.
2307 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2308 multiple of sizeof (EMACS_INT); it need not be, if
2309 alignof(EMACS_INT) < sizeof (EMACS_INT).
2310 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2312 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2314 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2316 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2318 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2319 supposed to be handshaking. (Bug#8556)
2320 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2322 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2324 * lisp.h (Qdebug): List symbol.
2325 * eval.c (Qdebug): Restore global linkage.
2326 * keyboard.c (debug-on-event): New variable.
2327 (handle_user_signal): Break into debugger when debug-on-event
2328 matches the current signal symbol.
2330 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2332 * alloc.c (check_sblock, check_string_bytes)
2333 (check_string_free_list): Convert to standard C.
2335 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2337 * w32.c (emacs_gnutls_push): Fix typo.
2339 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2341 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2342 "cast to pointer from integer of different size".
2344 Improve doprnt and its use in verror. (Bug#8545)
2345 * doprnt.c (doprnt): Document the set of format control sequences
2346 supported by the function. Use SAFE_ALLOCA instead of always
2349 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2350 is one byte too soon. Don't use xrealloc; instead xfree and
2353 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2355 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2358 * gnutls.c: Renamed global_initialized to
2359 gnutls_global_initialized. Added internals for the
2360 :verify-hostname-error, :verify-error, and :verify-flags
2361 parameters of `gnutls-boot' and documented those parameters in the
2362 docstring. Start callback support.
2363 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2364 unless a fatal error occured. Call gnutls_alert_send_appropriate
2365 on error. Return error code.
2366 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2367 (emacs_gnutls_read): Likewise.
2368 (Fgnutls_boot): Return handshake error code.
2369 (emacs_gnutls_handle_error): New function.
2370 (wsaerror_to_errno): Likewise.
2372 * w32.h (emacs_gnutls_pull): Add prototype.
2373 (emacs_gnutls_push): Likewise.
2375 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2376 (emacs_gnutls_push): Likewise.
2378 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2380 * process.c (wait_reading_process_output): Check if GnuTLS
2381 buffered some data internally if no FDs are set for TLS
2384 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2385 (LIBS): Link to USER_LIBS.
2386 ($(BLD)/gnutls.$(0)): New target.
2388 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2390 * xdisp.c (handle_single_display_spec): Rename the
2391 display_replaced_before_p argument into display_replaced_p, to
2392 make it consistent with the commentary. Fix typos in the
2395 * textprop.c (syms_of_textprop): Remove dead code.
2396 (copy_text_properties): Delete obsolete commentary about an
2397 interface that was deleted long ago. Fix typos in the description
2400 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2401 to changes in oldXMenu/XMenu.h from 2011-04-16.
2402 <menu_help_message, prev_menu_help_message>: Constify.
2403 (IT_menu_make_room): menu->help_text is now `const char **';
2406 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2407 to changes in oldXMenu/XMenu.h from 2011-04-16.
2408 (struct XMenu): Declare `help_text' `const char **'.
2410 * xfaces.c <Qunspecified>: Make extern again.
2412 * syntax.c: Include sys/types.h before including regex.h, as
2415 * doc.c (get_doc_string): Improve the format passed to `error'.
2417 * doprnt.c (doprnt): Improve commentary.
2419 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2421 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2424 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2425 changes in globals.h immediately force recompilation.
2426 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2427 $(CURDIR)/s/ms-w32.h.
2428 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2430 * character.c (Fchar_direction): Function deleted.
2431 (syms_of_character): Don't defsubr it.
2432 <char-direction-table>: Deleted.
2434 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2436 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2437 * doprnt.c: Include limits.h.
2438 (SIZE_MAX): New macro.
2439 (doprnt): Return a size_t value. 2nd arg is now size_t.
2440 Many local variables are now size_t instead of int or unsigned.
2441 Improve overflow protection. Support `l' modifier for integer
2442 conversions. Support %l conversion. Don't assume an EMACS_INT
2443 argument for integer conversions and for %c.
2445 * lisp.h (doprnt): Restore prototype.
2447 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2450 * Makefile.in (base_obj): Add back doprnt.o.
2452 * deps.mk (doprnt.o): Add back prerequisites.
2453 (callint.o): Depend on character.h.
2455 * eval.c (internal_lisp_condition_case): Include the handler
2456 representation in the error message.
2457 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2458 when breaking from the loop.
2460 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2462 * callint.c (Fcall_interactively): When displaying error message
2463 about invalid control letter, pass the character's codepoint, not
2464 a pointer to its multibyte form. Improve display of the character
2465 in octal and display also its hex code.
2467 * character.c (char_string): Use %x to display the (unsigned)
2468 codepoint of an invalid character, to avoid displaying a bogus
2471 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2472 `error', not SYMBOL_NAME itself.
2474 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2475 character arguments to `error'.
2477 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2478 to `error' in error message about FINAL_CHAR argument. Make sure
2479 FINAL_CHAR is a character, and use %c when it is passed as
2480 argument to `error'.
2482 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2484 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2486 * w32.c: Include <time.h>.
2487 (sys_localtime): New function.
2489 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2491 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2493 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2495 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2497 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2500 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2502 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2503 gl_state.e_property when gl_state.object is Qt.
2505 * insdel.c (make_gap_larger): Remove limitation of buffer size
2508 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2510 * xdisp.c (lookup_glyphless_char_display)
2511 (produce_glyphless_glyph): Handle cons cell entry in
2512 glyphless-char-display.
2513 (Vglyphless_char_display): Document it.
2515 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2516 glyphless-char-display.
2518 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2520 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2522 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2525 definition for no-X builds.
2527 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2529 Static checks with GCC 4.6.0 and non-default toolkits.
2531 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2533 * process.c (keyboard_bit_set): Define only if SIGIO.
2534 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2535 (send_process): Repair possible setjmp clobbering.
2537 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2539 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2541 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2543 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2544 Define only if needed.
2546 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2547 by pacifying GCC about it. Maybe it's time to retire it?
2548 * xfaces.c (USG, __TIMEVAL__): Likewise.
2550 * dispextern.h (struct redisplay_interface): Rename param
2552 * termhooks.h (struct terminal): Likewise.
2553 * xterm.c (xembed_send_message): Likewise.
2555 * insdel.c (make_gap_smaller): Define only if
2556 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2558 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2561 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2562 so that we aren't warned about unused symbols.
2564 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2566 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2568 * xfns.c (x_real_positions): Mark locals as initialized.
2570 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2572 * xterm.c: Fix problems found by static analysis with other toolkits.
2573 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2574 (x_dispatch_event): Declare static if USE_GTK, and
2575 define if USE_GTK || USE_X_TOOLKIT.
2576 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2577 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2578 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2579 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2581 * xmenu.c (menu_help_callback): Pointer type fixes.
2582 Use const pointers when pointing at readonly data. Avoid pointer
2584 (FALSE): Remove unused macro.
2585 (update_frame_menubar): Remove unused decl.
2587 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2589 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2590 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2591 (single_menu_item): Rename local to avoid shadowing.
2593 * keyboard.c (make_lispy_event): Remove unused local var.
2595 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2596 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2598 * bitmaps: Change bitmaps from unsigned char back to the X11
2599 compatible char. Avoid the old compiler warnings about
2600 out-of-range initializers by using, for example, '\xab' rather
2603 * xgselect.c (xgselect_initialize): Check vs interface
2604 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2606 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2608 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2609 to read-only memory.
2611 * fns.c (vector): Remove; this old hack is no longer needed.
2613 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2615 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2617 * xrdb.c (x_load_resources): Omit unused local.
2619 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2620 (x_window): Rename locals to avoid shadowing.
2621 (USG): Use the kludged USG macro, to pacify gcc.
2623 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2624 (x_term_init): Remove local to avoid shadowing.
2626 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2628 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2629 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2631 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2633 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2635 Fix regex.c, syntax.c and friends for buffers > 2GB.
2636 * syntax.h (struct gl_state_s): Declare character position members
2639 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2641 * textprop.c (verify_interval_modification, interval_of):
2642 Declare arguments EMACS_INT.
2644 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2647 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2649 * indent.c (Fvertical_motion): Local variable it_start is now
2652 * regex.c (re_match, re_match_2, re_match_2_internal)
2653 (bcmp_translate, regcomp, regexec, print_double_string)
2654 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2655 (re_compile_pattern, re_exec): Declare arguments and local
2656 variables `size_t' and `ssize_t' and return values `regoff_t', as
2658 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2659 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2660 <compile_stack_type>: `size' and `avail' are now `size_t'.
2662 * regex.h <regoff_t>: Use ssize_t, not int.
2663 (re_search, re_search_2, re_match, re_match_2): Arguments that
2664 specify buffer/string position and length are now ssize_t and
2665 size_t. Return type is regoff_t.
2667 2011-04-16 Ben Key <bkey76@gmail.com>
2669 * nsfont.m: Fixed bugs in ns_get_family and
2670 ns_descriptor_to_entity that were caused by using free to
2671 deallocate memory blocks that were allocated by xmalloc (via
2672 xstrdup). This caused Emacs to crash when compiled with
2673 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2674 --enable-checking=xmallocoverrun). xfree is now used to
2675 deallocate these memory blocks.
2677 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2679 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2681 emacs_write: Accept and return EMACS_INT for sizes.
2682 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2684 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2685 Accept and return EMACS_INT.
2686 (emacs_gnutls_write): Return the number of bytes written on
2688 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2689 (emacs_read, emacs_write): Remove check for negative size, as the
2690 Emacs source code has been audited now.
2691 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2692 (emacs_read, emacs_write): Use it.
2693 * process.c (send_process): Adjust to the new signatures of
2694 emacs_write and emacs_gnutls_write. Do not attempt to store
2695 a byte offset into an 'int'; it might overflow.
2696 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2698 * sound.c: Don't assume sizes fit in 'int'.
2699 (struct sound_device.period_size, alsa_period_size):
2700 Return EMACS_INT, not int.
2701 (struct sound_device.write, vox_write, alsa_write):
2702 Accept EMACS_INT, not int.
2703 (wav_play, au_play): Use EMACS_INT to store sizes and to
2704 record read return values.
2706 2011-04-15 Ben Key <bkey76@gmail.com>
2708 * keyboard.c (Qundefined): Don't declare static since it is used
2710 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2711 static since they are used in nsfont.m.
2713 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2715 * process.c (Qprocessp): Don't declare static.
2716 * lisp.h (Qprocessp): Declare again.
2718 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2720 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2722 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2724 Improve C-level modularity by making more things 'static'.
2726 Don't publish debugger-only interfaces to other modules.
2727 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2728 (verify_bytepos, count_markers): Move decls to the only modules
2730 * region-cache.h (pp_cache): Likewise.
2731 * window.h (check_all_windows): Likewise.
2732 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2734 * sysdep.c (croak): Now static, if
2735 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2736 * syssignal.h (croak): Declare only if not static.
2738 * alloc.c (refill_memory_reserve): Now static if
2739 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2740 * lisp.h (refill_memory_reserve): Declare only if not static.
2742 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2743 Define only if USE_LUCID.
2745 * xrdb.c (x_customization_string, x_rm_string): Now static.
2747 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2748 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2750 * xdisp.c (draw_row_with_mouse_face): Now static.
2751 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2753 * window.h (check_all_windows): Mark externally visible.
2755 * window.c (window_deletion_count): Now static.
2757 * undo.c: Make symbols static if they're not exported.
2758 (last_undo_buffer, last_boundary_position, pending_boundary):
2761 * textprop.c (interval_insert_behind_hooks): Now static.
2762 (interval_insert_in_front_hooks): Likewise.
2764 * term.c: Make symbols static if they're not exported.
2765 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2766 (max_frame_lines, tty_set_terminal_modes):
2767 (tty_reset_terminal_modes, tty_turn_off_highlight):
2768 (get_tty_terminal): Now static.
2769 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2770 * termhooks.h (term_mouse_moveto): Do not declare if
2772 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2773 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2775 * sysdep.c: Make symbols static if they're not exported.
2776 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2778 (sigprocmask_set, full_mask): Remove; unused.
2779 (wait_debugging): Mark as visible.
2780 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2781 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2783 * syntax.c (syntax_temp): Define only if !__GNUC__.
2785 * sound.c (current_sound_device, current_sound): Now static.
2787 * search.c (searchbufs, searchbuf_head): Now static.
2789 * scroll.c (scroll_cost): Remove; unused.
2790 * dispextern.h (scroll_cost): Remove decl.
2792 * region-cache.h (pp_cache): Mark as externally visible.
2794 * process.c: Make symbols static if they're not exported.
2795 (process_tick, update_tick, create_process, chan_process):
2796 (Vprocess_alist, proc_buffered_char, datagram_access):
2797 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2798 (deactivate_process): Mark defn as static, as well as decl.
2799 * lisp.h (create_process): Remove decl.
2800 * process.h (chan_process, Vprocess_alist): Remove decls.
2802 * print.c: Make symbols static if they're not exported.
2803 (print_depth, new_backquote_output, being_printed, print_buffer):
2804 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2805 (print_interval, print_number_index, initial_stderr_stream):
2807 * lisp.h (Fprinc): Remove decl.
2808 (debug_output_compilation_hack): Mark as externally visible.
2810 * sysdep.c (croak): Move decl from here to syssignal.h.
2811 * syssignal.h (croak): Put it here, so the API can be checked when
2812 'croak' is called from dissociate_if_controlling_tty.
2814 * minibuf.c: Make symbols static if they're not exported.
2815 (minibuf_save_list, choose_minibuf_frame): Now static.
2816 * lisp.h (choose_minibuf_frame): Remove decl.
2818 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2820 * lread.c: Make symbols static if they're not exported.
2821 (read_objects, initial_obarray, oblookup_last_bucket_number):
2823 (make_symbol): Remove; unused.
2824 * lisp.h (initial_obarray, make_symbol): Remove decls.
2826 * keyboard.c: Make symbols static if they're not exported.
2827 (single_kboard, recent_keys_index, total_keys, recent_keys):
2828 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2829 (this_single_command_key_start, echoing, last_auto_save):
2830 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2831 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2832 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2833 (Vlispy_mouse_stem, double_click_count):
2835 (force_auto_save_soon): Define only if SIGDANGER.
2836 (ignore_mouse_drag_p): Now static if
2837 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2838 (print_help): Remove; unused.
2839 (stop_character, last_timer_event): Mark as externally visible.
2840 * keyboard.h (ignore_mouse_drag_p): Declare only if
2841 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2842 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2843 * lisp.h (echoing): Remove decl.
2844 (force_auto_save_soon): Declare only if SIGDANGER.
2845 * xdisp.c (redisplay_window): Simplify code, to make it more
2846 obvious that ignore_mouse_drag_p is not accessed if !defined
2847 USE_GTK && !defined HAVE_NS.
2849 * intervals.c: Make symbols static if they're not exported.
2850 (merge_properties_sticky, merge_interval_right, delete_interval):
2852 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2854 * insdel.c: Make symbols static if they're not exported.
2855 However, leave prepare_to_modify_buffer alone. It's never
2856 called from outside this function, but that appears to be a bug.
2857 (combine_after_change_list, combine_after_change_buffer):
2858 (adjust_after_replace, signal_before_change): Now static.
2859 (adjust_after_replace_noundo): Remove; unused.
2860 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2861 (signal_before_change): Remove decls.
2863 * indent.c (val_compute_motion, val_vmotion): Now static.
2865 * image.c: Make symbols static if they're not exported.
2866 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2868 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2869 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2871 * fringe.c (standard_bitmaps): Now static.
2872 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2874 * frame.c: Make symbols static if they're not exported.
2875 (x_report_frame_params, make_terminal_frame): Now static.
2876 (get_frame_param): Now static, unless HAVE_NS.
2877 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2878 (x_get_resource_string): Remove; not used.
2879 * frame.h (make_terminal_frame, x_report_frame_params):
2880 (x_get_resource_string); Remove decls.
2881 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2882 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2884 * font.c, fontset.c: Make symbols static if they're not exported.
2885 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2886 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2887 * font.c (font_close_object): Now static.
2888 * font.h (font_close_object): Remove.
2889 * fontset.c (FONTSET_OBJLIST): Remove.
2890 (free_realized_fontset) #if-0 the body, which does nothing.
2891 (face_suitable_for_char_p): #if-0, as it's never called.
2892 * fontset.h (face_suitable_for_char_p): Remove decl.
2893 * xfaces.c (face_at_string_position):
2894 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2895 since 0 is always ASCII.
2897 * fns.c (weak_hash_tables): Now static.
2899 * fileio.c: Make symbols static if they're not exported.
2900 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2901 (Vwrite_region_annotation_buffers): Now static.
2903 * eval.c: Make symbols static if they're not exported.
2904 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2905 * lisp.h (backtrace_list): Remove decl.
2907 * emacs.c: Make symbols static if they're not exported.
2908 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2909 (fatal_error_code, fatal_error_signal_hook, standard_args):
2911 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2912 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2913 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2914 * lisp.h (fatal_error_signal_hook): Remove decl.
2915 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2917 * editfns.c: Move a (normally-unused) function to its only use.
2918 * editfns.c, lisp.h (get_operating_system_release): Remove.
2919 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2920 worth the hassle of breaking this out.
2922 * xterm.c: Make symbols static if they're not exported.
2923 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2924 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2925 (x_destroy_window, x_delete_display):
2927 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2928 (x_mouse_leave): Remove; unused.
2929 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2930 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2931 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2933 (x_mouse_leave): Declare only if WINDOWSNT.
2934 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2935 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2938 * ftxfont.c: Make symbols static if they're not exported.
2939 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2941 * font.h (ftxfont_driver): Likewise.
2943 * xfns.c: Make symbols static if they're not exported.
2944 (x_last_font_name, x_display_info_for_name):
2945 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2946 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2947 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2948 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2949 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2950 (last_show_tip_args): Now static.
2951 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2952 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2953 (x_screen_planes): Remove; unused.
2954 * dispextern.h (x_screen_planes): Remove decl.
2956 * dispnew.c: Make symbols static if they're not exported.
2957 * dispextern.h (redraw_garbaged_frames, scrolling):
2958 (increment_row_positions): Remove.
2959 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2960 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2962 (redraw_garbaged_frames): Remove; unused.
2964 * xfaces.c: Make symbols static if they're not exported.
2965 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2967 * xterm.h (defined_color): Remove decls.
2968 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2969 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2970 (menu_face_changed_default, defined_color, free_realized_face):
2971 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2972 (ascii_face_of_lisp_face): Remove; unused.
2974 * xdisp.c: Make symbols static if they're not exported.
2975 * dispextern.h (scratch_glyph_row, window_box_edges):
2976 (glyph_to_pixel_coords, set_cursor_from_row):
2977 (get_next_display_element, set_iterator_to_next):
2978 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2979 (show_mouse_face): Remove decls
2980 * frame.h (message_buf_print): Likewise.
2981 * lisp.h (pop_message, set_message, check_point_in_composition):
2983 * xterm.h (set_vertical_scroll_bar): Likewise.
2984 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2985 (message_buf_print, scratch_glyph_row, displayed_buffer):
2986 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2987 (get_next_display_element, show_mouse_face, window_box_edges):
2988 (frame_to_window_pixel_xy, check_point_in_composition):
2989 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2990 (glyph_to_pixel_coords): Remove; unused.
2992 * dired.c (file_name_completion): Now static.
2994 * dbusbind.c (xd_in_read_queued_messages): Now static.
2996 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2997 * data.c (circular_list_error): Remove.
2999 * commands.h (last_point_position, last_point_position_buffer):
3000 (last_point_position_window): Remove decls.
3001 * keyboard.c: Make these variables static.
3003 * coding.h (coding, code_convert_region, encode_coding_gap):
3005 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3006 (iso_code_class, detect_coding, code_convert_region): Now static.
3007 (encode_coding_gap): Remove; unused.
3009 * chartab.c (chartab_chars, chartab_bits): Now static.
3011 * charset.h (charset_iso_8859_1): Remove decl.
3012 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3015 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3016 * ccl.c (Vccl_program_table): Now static.
3017 (check_ccl_update): Remove; unused.
3019 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3020 * category.h: ... from here.
3021 * category.c (check_category_table, set_category_set): Now static.
3023 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3024 * lisp.h: Remove these decls.
3026 * buffer.c (buffer_count): Remove unused var.
3028 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3029 so that it's not optimized away.
3030 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3031 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3032 exported only to the debugger.
3034 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3035 * atimer.h (run_all_atimers): Remove; not exported.
3037 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3038 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3039 was inaccessible from Lisp.
3040 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3041 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3043 alloc.c: Import and export fewer symbols, and remove unused items.
3044 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3046 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3047 it's not optimized away by whole-program optimization.
3048 (message_enable_multibyte, free_misc): Remove.
3049 (catchlist, handlerlist, mark_backtrace):
3050 Declare only if BYTE_MARK_STACK.
3051 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3052 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3053 (message_enable_multibyte): Remove decl.
3054 (free_misc, interval_free_list, float_block, float_block_index):
3055 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3056 (cons_free_list, last_marked_index):
3058 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3059 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3060 (mark_backtrace): Define only if BYTE_MARK_STACK.
3061 * xdisp.c (message_enable_multibyte): Now static.
3063 Declare Lisp_Object Q* variables to be 'static' if not exported.
3064 This makes it easier for human readers (and static analyzers)
3065 to see whether these variables are used from other modules.
3066 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3067 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3068 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3069 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3070 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3071 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3072 * xmenu.c, xselect.c:
3073 Declare Q* vars static if they are not used in other modules.
3074 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3075 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3076 Remove decls of unexported vars.
3077 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3079 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3081 Make Emacs functions such as Fatom 'static' by default.
3082 This makes it easier for human readers (and static analyzers)
3083 to see whether these functions can be called from other modules.
3084 DEFUN now defines a static function. To make the function external
3085 so that it can be used in other C modules, use the new macro DEFUE.
3086 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3087 (Finit_image_library):
3088 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3089 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3090 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3091 Remove decls, since these functions are now static.
3092 (Funintern, Fget_internal_run_time): New decls, since these functions
3093 were already external.
3095 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3096 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3097 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3098 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3099 * keyboard.c, keymap.c, lread.c:
3100 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3101 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3102 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3103 Mark functions with DEFUE instead of DEFUN,
3104 if they are used in other modules.
3105 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3106 decls for now-static functions.
3107 * buffer.h (Fdelete_overlay): Remove decl.
3108 * callproc.c (Fgetenv_internal): Mark as internal.
3109 * composite.c (Fremove_list_of_text_properties): Remove decl.
3110 (Fcomposition_get_gstring): New forward static decl.
3111 * composite.h (Fcomposite_get_gstring): Remove decl.
3112 * dired.c (Ffile_attributes): New forward static decl.
3113 * doc.c (Fdocumntation_property): New forward static decl.
3114 * eval.c (Ffetch_bytecode): New forward static decl.
3115 (Funintern): Remove extern decl; now in .h file where it belongs.
3116 * fileio.c (Fmake_symbolic_link): New forward static decl.
3117 * image.c (Finit_image_library): New forward static decl.
3118 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3119 * intervals.h (Fprevious_property_change):
3120 (Fremove_list_of_text_properties): Remove decls.
3121 * keyboard.c (Fthis_command_keys): Remove decl.
3122 (Fcommand_execute): New forward static decl.
3123 * keymap.c (Flookup_key): New forward static decl.
3124 (Fcopy_keymap): Now static.
3125 * keymap.h (Flookup_key): Remove decl.
3126 * process.c (Fget_process): New forward static decl.
3127 (Fprocess_datagram_address): Mark as internal.
3128 * syntax.c (Fsyntax_table_p): New forward static decl.
3129 (skip_chars): Remove duplicate decl.
3130 * textprop.c (Fprevious_property_change): New forward static decl.
3131 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3133 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3134 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3136 * editfns.c (Fformat): Remove unreachable code.
3138 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3140 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3143 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3145 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3146 when at ZV. (Bug#8487)
3148 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3150 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3152 * keyboard.c (parse_tool_bar_item): Likewise.
3153 * sound.c (sound_cleanup, alsa_close): Likewise.
3154 * termcap.c (tgetent): Likewise.
3155 * xfns.c (x_default_font_parameter): Likewise.
3156 * xsettings.c (read_and_apply_settings): Likewise.
3158 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3159 (overrun_check_free): Protoize.
3161 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3163 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3164 since callers should never pass a negative size.
3165 Change the signature to match that of plain 'read' and 'write'; see
3166 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3167 * lisp.h: Update prototypes of emacs_write and emacs_read.
3169 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3171 * xdisp.c (redisplay_window): Don't try to determine the character
3172 position of the scroll margin if the window start point w->startp
3173 is outside the buffer's accessible region. (Bug#8468)
3175 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3177 Fix write-region and its subroutines for buffers > 2GB.
3178 * fileio.c (a_write, e_write): Modify declaration of arguments and
3179 local variables to support buffers larger than 2GB.
3180 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3182 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3183 argument, local variables, and return value.
3185 * lisp.h: Update prototypes of emacs_write and emacs_read.
3187 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3189 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3191 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3193 Fix more problems found by GCC 4.6.0's static checks.
3195 * xdisp.c (vmessage): Use a better test for character truncation.
3197 * charset.c (load_charset_map): <, not <=, for optimization,
3198 and to avoid potential problems with integer overflow.
3199 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3200 * casetab.c (set_identity, shuffle): Likewise.
3201 * editfns.c (Fformat): Likewise.
3202 * syntax.c (skip_chars): Likewise.
3204 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3205 This also lets GCC 4.6.0 generate slightly better loop code.
3207 * callint.c (Fcall_interactively): <, not <=, for optimization.
3208 (Fcall_interactively): Count the number of arguments produced,
3209 not the number of arguments given. This is simpler and lets GCC
3210 4.6.0 generate slightly better code.
3212 * ftfont.c: Distingish more carefully between FcChar8 and char.
3213 The previous code passed unsigned char * to a functions like
3214 strlen and xstrcasecmp that expect char *, which does not
3215 conform to the C standard.
3216 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3217 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3218 char * when the C standard requires it.
3220 * keyboard.c (read_char): Remove unused var.
3222 * eval.c: Port to Windows vsnprintf (Bug#8435).
3224 (SIZE_MAX): Define if the headers do not.
3225 (verror): Do not give up if vsnprintf returns a negative count.
3226 Instead, grow the buffer. This ports to Windows vsnprintf, which
3227 does not conform to C99. Problem reported by Eli Zaretskii.
3228 Also, simplify the allocation scheme, by avoiding the need for
3229 calling realloc, and removing the ALLOCATED variable.
3231 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3233 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3234 But keep the doprint source code for now, as we might revamp it
3235 and use it again (Bug#8435).
3236 * lisp.h (doprnt): Remove.
3237 * Makefile.in (base_obj): Remove doprnt.o.
3238 * deps.mk (doprnt.o): Remove.
3240 error: Print 32- and 64-bit integers portably (Bug#8435).
3241 Without this change, on typical 64-bit hosts error ("...%d...", N)
3242 was used to print both 32- and 64-bit integers N, which relied on
3244 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3246 * lisp.h (error, verror): Mark as printf-like functions.
3247 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3248 Report overflow in size calculations when allocating printf buffer.
3249 Do not truncate output string at its first null byte.
3250 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3251 Truncate the output at a character boundary, since vsnprintf does not
3253 * charset.c (check_iso_charset_parameter): Convert internal
3254 character to string before calling 'error', since %c now has the
3256 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3257 overflow when computing char to be passed to 'error'. Do not
3258 pass Lisp_Object to 'error'; pass the integer instead.
3259 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3260 formatted with plain %d.
3262 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3264 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3266 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3268 * xterm.c (x_catch_errors): Remove duplicate declaration.
3270 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3272 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3274 2011-04-10 Jim Meyering <meyering@redhat.com>
3276 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3277 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3278 return ssize_t not "int", and use size_t as the buffer length.
3279 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3280 * gnutls.h: Update declarations.
3281 * process.c (read_process_output): Use ssize_t, to match.
3282 (send_process): Likewise.
3284 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3286 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3288 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3290 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3291 Use unsigned char, to match FcChar8 type definition.
3293 * xterm.c (handle_one_xevent):
3294 * xmenu.c (create_and_show_popup_menu):
3295 * xselect.c (x_decline_selection_request)
3296 (x_reply_selection_request): Avoid type-punned deref of X events.
3298 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3300 Fix some uses of `int' instead of EMACS_INT.
3301 * search.c (string_match_1, fast_string_match)
3302 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3303 (scan_buffer, find_next_newline_no_quit)
3304 (find_before_next_newline, search_command, Freplace_match)
3305 (Fmatch_data): Make some `int' variables be EMACS_INT.
3307 * xdisp.c (display_count_lines): 3rd argument and return value now
3308 EMACS_INT. All callers changed.
3309 (pint2hrstr): Last argument is now EMACS_INT.
3311 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3312 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3313 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3314 (decode_coding_utf_16, decode_coding_emacs_mule)
3315 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3316 (decode_coding_ccl, decode_coding_charset)
3317 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3318 (decode_coding_iso_2022, decode_coding_emacs_mule)
3319 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3320 <char_offset, last_offset>: Declare EMACS_INT.
3321 (encode_coding_utf_8, encode_coding_utf_16)
3322 (encode_coding_emacs_mule, encode_invocation_designation)
3323 (encode_designation_at_bol, encode_coding_iso_2022)
3324 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3325 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3327 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3328 (encode_invocation_designation): Last argument P_NCHARS is now
3330 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3331 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3333 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3336 * ccl.c (Fccl_execute_on_string): Declare some variables
3339 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3341 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3343 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3345 * process.c (Fformat_network_address): Doc fix.
3347 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3349 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3351 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3353 * keyboard.c (read_char): Call Lisp function help-form-show,
3354 instead of using internal_with_output_to_temp_buffer.
3355 (Qhelp_form_show): New var.
3356 (syms_of_keyboard): Use DEFSYM macro.
3358 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3360 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3362 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3364 * process.c (Flist_processes): Remove to Lisp.
3365 (list_processes_1): Delete.
3367 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3369 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3371 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3373 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3375 Fix more problems found by GCC 4.6.0's static checks.
3377 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3379 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3381 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3383 * xdisp.c (vmessage): Mark as a printf-like function.
3385 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3387 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3389 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3390 printf-like functions.
3391 (tiff_load): Add casts to remove these marks before passing them
3392 to system-supplied API.
3394 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3396 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3397 This avoids several warnings with gcc -Wstrict-overflow.
3398 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3399 directly, rather than having caller test rule sign. This avoids
3400 some unnecessary tests.
3401 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3402 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3403 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3405 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3406 (xfont_open): Avoid unnecessary tests.
3408 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3410 * composite.h, composite.c (composition_gstring_put_cache):
3411 Use EMACS_INT, not int, for length.
3413 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3414 breaking out part of COMPOSITION_DECODE_RULE.
3415 (COMPOSITION_DECODE_RULE): Use it.
3416 * composite.c (get_composition_id): Remove unused local vars,
3417 by using the new macro.
3419 * textprop.c (set_text_properties_1): Change while to do-while,
3420 since the condition is always true at first.
3422 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3423 (interval_deletion_adjustment): Return unsigned value.
3426 * process.c (list_processes_1, create_pty, read_process_output):
3427 (exec_sentinel): Remove vars that were set but not used.
3428 (create_pty): Remove unnecessary "volatile"s.
3429 (Fnetwork_interface_info): Avoid possibility of int overflow.
3430 (read_process_output): Do adaptive read buffering even if carryover.
3431 (read_process_output): Simplify nbytes computation if buffered.
3433 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3435 * syntax.c (scan_words): Remove var that was set but not used.
3436 (update_syntax_table): Use unsigned instead of int.
3438 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3439 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3440 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3442 * print.c (print_error_message): Avoid int overflow.
3444 * font.c (font_list_entities): Redo for clarity,
3445 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3447 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3448 (font_score): Avoid potential overflow in diff calculation.
3450 * fns.c (substring_both): Remove var that is set but not used.
3451 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3453 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3455 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3456 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3457 can always succeed if overflow has undefined behavior.
3459 * search.c (boyer_moore, wordify): Remove vars set but not used.
3460 (wordify): Omit three unnecessary tests.
3462 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3463 All callers changed. This avoids the need for an unused var.
3465 * casefiddle.c (casify_region): Remove var that is set but not used.
3467 * dired.c (file_name_completion): Remove var that is set but not used.
3469 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3471 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3472 (Finsert_file_contents): Remove unnecessary code checking fd.
3474 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3475 Check for integer overflow on size calculations.
3477 * buffer.c (Fprevious_overlay_change): Remove var that is set
3480 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3481 Remove vars that are set but not used.
3482 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3483 (timer_check_2): Mark vars as initialized.
3485 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3487 * image.c (lookup_image): Remove var that is set but not used.
3488 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3490 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3491 that are set but not used.
3493 * xfns.c (make_invisible_cursor): Don't return garbage
3494 if XCreateBitmapFromData fails (Bug#8410).
3496 * xselect.c (x_get_local_selection, x_handle_property_notify):
3497 Remove vars that are set but not used.
3499 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3500 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3502 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3503 Remove var that is set but not used.
3504 (scroll_bar_windows_size): Now size_t, not int.
3505 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3508 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3509 (map_tty_color) [!defined MSDOS]: Likewise.
3511 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3513 * coding.c: Remove vars that are set but not used.
3514 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3515 All callers changed.
3516 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3517 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3518 (decode_coding_charset): Remove vars that are set but not used.
3520 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3521 that is set but not used.
3523 * print.c (print_object): Remove var that is set but not used.
3525 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3526 The gnulib version avoids calling malloc in the usual case,
3527 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3528 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3529 * filelock.c (current_lock_owner): Likewise.
3530 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3531 * sysdep.c: Include allocator.h, careadlinkat.h.
3532 (emacs_no_realloc_allocator): New static constant.
3533 (emacs_readlink): New function.
3534 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3535 ../lib/careadlinkat.h.
3537 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3539 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3540 first non-nil return value).
3542 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3544 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3545 if not defined (Bug#8403).
3547 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3549 * xdisp.c (display_count_lines): Remove parameter `start',
3550 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3551 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3552 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3553 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3554 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3555 and thereabouts. All callers changed.
3556 (get_per_char_metric): Remove parameter `f', unused since
3557 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3559 2011-04-02 Jim Meyering <meyering@redhat.com>
3561 do not dereference NULL upon failed strdup
3562 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3563 (ns_get_family): Likewise.
3565 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3567 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3569 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3571 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3574 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3576 Add lexical binding.
3578 * window.c (Ftemp_output_buffer_show): New fun.
3579 (Fsave_window_excursion):
3580 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3582 * lread.c (lisp_file_lexically_bound_p): New function.
3583 (Fload): Bind Qlexical_binding.
3584 (readevalloop): Remove `evalfun' arg.
3585 Bind Qinternal_interpreter_environment.
3586 (Feval_buffer): Bind Qlexical_binding.
3587 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3589 (syms_of_lread): Declare `lexical-binding'.
3591 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3593 * keyboard.c (eval_dyn): New fun.
3594 (menu_item_eval_property): Use it.
3596 * image.c (parse_image_spec): Use Ffunctionp.
3598 * fns.c (concat, mapcar1): Accept byte-code-functions.
3600 * eval.c (Fsetq): Handle lexical vars.
3601 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3602 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3603 (FletX, Flet): Obey lexical binding.
3604 (Fcommandp): Handle closures.
3605 (Feval): New `lexical' arg.
3606 (eval_sub): New function extracted from Feval. Use it almost
3607 everywhere where Feval was used. Look up vars in lexical env.
3609 (Ffunctionp): Move from subr.el.
3610 (Ffuncall): Handle closures.
3611 (apply_lambda): Remove `eval_flags'.
3612 (funcall_lambda): Handle closures and new byte-code-functions.
3613 (Fspecial_variable_p): New function.
3614 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3615 but without exporting it to Lisp.
3617 * doc.c (Fdocumentation, store_function_docstring):
3618 * data.c (Finteractive_form): Handle closures.
3620 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3623 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3625 (exec_byte_code): New function extracted from Fbyte_code to handle new
3626 calling convention for byte-code-functions. Add new byte-codes.
3628 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3630 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3632 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3634 * xdisp.c (redisplay_internal): Fix prototype.
3636 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3638 * xdisp.c (SCROLL_LIMIT): New macro.
3639 (try_scrolling): Use it when setting scroll_limit.
3640 Limit scrolling to 100 screen lines.
3641 (redisplay_window): Even when falling back on "recentering",
3642 position point in the window according to scroll-conservatively,
3643 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3645 (try_scrolling): When point is above the window, allow searching
3646 as far as scroll_max, or one screenful, to compute vertical
3647 distance from PT to the scroll margin position. This prevents
3648 try_scrolling from unnecessarily failing when
3649 scroll-conservatively is set to a value slightly larger than the
3650 window height. Clean up the case of PT below the margin at bottom
3651 of window: scroll_max can no longer be INT_MAX. When aggressive
3652 scrolling is in use, don't let point enter the opposite scroll
3653 margin as result of the scroll.
3654 (syms_of_xdisp) <scroll-conservatively>: Document the
3655 threshold of 100 lines for never-recentering scrolling.
3657 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3659 * dispextern.h (move_it_by_lines):
3660 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3661 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3662 (message_log_check_duplicate): Remove parameters `prev_bol' and
3663 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3664 (redisplay_internal): Remove parameter `preserve_echo_area',
3665 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3667 * indent.c (Fvertical_motion):
3668 * window.c (window_scroll_pixel_based, Frecenter):
3669 Don't pass `need_y_p' to `move_it_by_lines'.
3671 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3673 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3674 steal a few bits to be more compact.
3675 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3676 Remove unneeded casts.
3678 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3680 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3682 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3683 binding" message (bug#7967).
3685 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3687 Fix more problems found by GCC 4.6.0's static checks.
3689 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3690 Remove unused local var.
3692 * editfns.c (Fmessage_box): Remove unused local var.
3694 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3695 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3696 Omit unused local vars.
3697 * window.c (shrink_windows): Omit unused local var.
3698 * menu.c (digest_single_submenu): Omit unused local var.
3699 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3700 Omit unused local var.
3702 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3703 Don't assume string length fits in int.
3704 (keyremap_step, read_key_sequence): Use size_t for sizes.
3705 (read_key_sequence): Don't check last_real_key_start redundantly.
3707 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3708 instead of alloca (Bug#8344).
3710 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3711 (Fbacktrace_frame): Don't assume nframes fits in int.
3713 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3715 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3718 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3720 * cm.c (calccost): Turn while-do into do-while, for clarity.
3722 * keyboard.c (syms_of_keyboard): Use the same style as later
3723 in this function when indexing through an array. This also
3724 works around GCC bug 48267.
3726 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3728 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3730 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3731 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3733 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3734 This avoids undefined behavior on integer overflow, and is a bit
3735 more convenient anyway since it is compared to a size_t variable.
3737 Variadic C functions now count arguments with size_t, not int.
3738 This avoids an unnecessary limitation on 64-bit machines, which
3739 caused (substring ...) to crash on large vectors (Bug#8344).
3740 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3741 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3742 All variadic functions and their callers changed accordingly.
3743 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3744 * data.c (arith_driver, float_arith_driver): Likewise.
3745 * editfns.c (general_insert_function): Likewise.
3746 * eval.c (struct backtrace.nargs, interactive_p)
3747 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3748 (funcall_lambda, mark_backtrace): Likewise.
3749 * fns.c (concat): Likewise.
3750 * frame.c (x_set_frame_parameters): Likewise.
3751 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3752 0 if not found, not -1. All callers changed.
3754 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3755 (stack_copy_size): Now size_t, not int.
3756 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3758 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3760 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3761 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3762 All callers changed.
3764 * lisp.h (multibyte_char_to_unibyte):
3765 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3766 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3767 * character.h (CHAR_TO_BYTE8):
3768 * cmds.c (internal_self_insert):
3769 * editfns.c (general_insert_function):
3770 * keymap.c (push_key_description):
3771 * search.c (Freplace_match):
3772 * xdisp.c (message_dolog, set_message_1): All callers changed.
3774 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3776 * keyboard.c (safe_run_hook_funcall): New function.
3777 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3778 don't set the hook to nil, but remove the offending function instead.
3779 (Qcommand_hook_internal): Remove, unused.
3780 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3781 Vcommand_hook_internal.
3783 * eval.c (enum run_hooks_condition): Remove.
3784 (funcall_nil, funcall_not): New functions.
3785 (run_hook_with_args): Call each function through a `funcall' argument.
3786 Remove `cond' argument, now redundant.
3787 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3788 (Frun_hook_with_args_until_failure): Adjust accordingly.
3789 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3791 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3793 * dispextern.h (string_buffer_position): Remove declaration.
3795 * print.c (strout): Remove parameter `multibyte', unused since
3796 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3798 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3799 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3800 All callers changed.
3802 * w32.c (_wsa_errlist): Use braces for struct initializers.
3804 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3805 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3806 All callers changed.
3807 (string_buffer_position): Likewise. Also, make static (it's never
3808 used outside xdisp.c).
3809 (cursor_row_p): Remove parameter `w', unused since
3810 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3811 (decode_mode_spec): Remove parameter `precision', introduced during
3812 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3813 All callers changed.
3815 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3817 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3819 2011-03-27 Anders Lindgren <andlind@gmail.com>
3821 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3822 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3823 (ns_update_auto_hide_menu_bar): New functions.
3824 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3825 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3826 ns_constrain_all_frames.
3827 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3828 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3830 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3832 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3834 2011-03-27 Glenn Morris <rgm@gnu.org>
3836 * syssignal.h: Replace RETSIGTYPE with void.
3837 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3838 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3839 Replace SIGTYPE with void everywhere.
3840 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3841 * s/template.h (SIGTYPE): Remove commented out definition.
3843 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3845 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3846 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3848 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3850 * w32.c (read_unc_volume): Use parameter `henum', instead of
3851 global variable `wget_enum_handle'.
3853 * keymap.c (describe_vector): Remove parameters `indices' and
3854 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3855 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3857 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3859 * keyboard.c (timer_check): Remove parameter `do_it_now',
3860 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3861 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3862 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3864 * keyboard.c (read_char):
3865 * w32menu.c (w32_menu_display_help):
3866 * xmenu.c (show_help_event, menu_help_callback):
3867 Adjust calls to `show_help_echo'.
3869 * gtkutil.c (xg_maybe_add_timer):
3870 * keyboard.c (readable_events):
3871 * process.c (wait_reading_process_output):
3872 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3874 * insdel.c (adjust_markers_gap_motion):
3875 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3876 (gap_left, gap_right): Don't call it.
3878 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3880 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3881 incurred during fontification.
3883 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3885 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3886 (DEFVAR_PER_BUFFER): Don't pass it.
3888 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3889 (scrolling_window): Don't pass it.
3891 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3893 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3895 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3897 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3898 of variables specific to SELinux and computation of `encoded_absname'.
3900 * image.c (XPutPixel): Remove unused variable `height'.
3902 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3904 * unexw32.c (get_section_info): Remove unused variable `section'.
3906 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3907 (system_process_attributes): Remove unused variable `sess'.
3908 (sys_read): Remove unused variable `err'.
3910 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3911 (w32_wnd_proc): Remove unused variable `isdead'.
3912 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3913 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3914 (x_create_tip_frame): Remove unused variable `tem'.
3916 * w32inevt.c (w32_console_read_socket):
3917 Remove unused variable `no_events'.
3919 * w32term.c (x_draw_composite_glyph_string_foreground):
3920 Remove unused variable `width'.
3922 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3924 * w32term.c (x_set_glyph_string_clipping):
3925 Don't pass uninitialized region to CombineRgn.
3927 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3929 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3930 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3931 (Fx_close_connection): Remove unused variable `i'.
3933 * w32font.c (w32font_draw): Return number of glyphs.
3934 (w32font_open_internal): Remove unused variable `i'.
3935 (w32font_driver): Add missing initializer.
3937 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3938 (fill_in_menu): Remove unused variable `items_added'.
3940 * w32term.c (last_mouse_press_frame): Remove static global variable.
3941 (w32_clip_to_row): Remove unused variable `f'.
3942 (x_delete_terminal): Remove unused variable `i'.
3944 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3945 (NOTHING): Remove unused static global variable.
3946 (uniscribe_check_otf): Remove unused variable `table'.
3947 (uniscribe_font_driver): Add missing initializers.
3949 2011-03-23 Julien Danjou <julien@danjou.info>
3951 * term.c (Fsuspend_tty, Fresume_tty):
3952 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3953 * window.c (temp_output_buffer_show):
3954 * insdel.c (signal_before_change):
3955 * frame.c (Fhandle_switch_frame):
3956 * fileio.c (Fdo_auto_save):
3957 * emacs.c (Fkill_emacs):
3958 * editfns.c (save_excursion_restore):
3959 * cmds.c (internal_self_insert):
3960 * callint.c (Fcall_interactively):
3961 * buffer.c (Fkill_all_local_variables):
3962 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3964 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3965 unconditionnaly since it does the check itself.
3967 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3969 Fix more problems found by GCC 4.5.2's static checks.
3971 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3972 the first time through the loop, since we know p0 < p1 then.
3973 This also avoids a gcc -Wstrict-overflow warning.
3975 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3976 leading to a memory leak, possible in functions like
3977 load_charset_map_from_file that can allocate an unbounded number
3978 of objects (Bug#8318).
3980 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3981 that could (at least in theory) be that large.
3983 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3984 This is less likely to overflow, and avoids undefined behavior if
3985 overflow does occur. All callers changed. Use strtoul to scan
3986 for the unsigned long integer.
3987 (pint2hrstr): Simplify and tune code slightly.
3988 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3990 * scroll.c (do_scrolling): Work around GCC bug 48228.
3991 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3993 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3994 This also avoids a warning with gcc -Wstrict-overflow.
3995 (validate_x_resource_name): Simplify count usage.
3996 This also avoids a warning with gcc -Wstrict-overflow.
3998 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4001 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4003 * process.c (Fmake_network_process): Use socklen_t, not int,
4004 where POSIX says socklen_t is required in portable programs.
4005 This fixes a porting bug on hosts like 64-bit HP-UX, where
4006 socklen_t is wider than int (Bug#8277).
4007 (Fmake_network_process, server_accept_connection):
4008 (wait_reading_process_output, read_process_output):
4011 * process.c: Rename or move locals to avoid shadowing.
4012 (list_processes_1, Fmake_network_process):
4013 (read_process_output_error_handler, exec_sentinel_error_handler):
4014 Rename or move locals.
4015 (Fmake_network_process): Define label "retry_connect" only if needed.
4016 (Fnetwork_interface_info): Fix pointer signedness.
4017 (process_send_signal): Add cast to avoid pointer signedness problem.
4018 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4019 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4021 Make tparam.h and terminfo.c consistent.
4022 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4023 Include tparam.h instead, since it declares them.
4024 * cm.h (PC): Remove extern decl; tparam.h now does this.
4025 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4026 * terminfo.c: Include tparam.h, to check interfaces.
4027 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4028 (tparam): Adjust signature to match interface in tparam.h;
4029 this removes some undefined behavior. Check that outstring and len
4030 are zero, which they always are with Emacs.
4031 * tparam.h (PC, BC, UP): New extern decls.
4033 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4034 (xftfont_open): Rename locals to avoid shadowing.
4036 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4037 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4038 (OTF_TAG_SYM): Omit macro if not needed.
4039 (ftfont_list): Remove unused local.
4040 (get_adstyle_property, ftfont_pattern_entity):
4041 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4042 Rename locals to avoid shadowing.
4044 * xfont.c (xfont_list_family): Mark var as initialized.
4046 * xml.c (make_dom): Now static.
4048 * composite.c (composition_compute_stop_pos): Rename local to
4050 (composition_reseat_it): Remove unused locals.
4051 (find_automatic_composition, composition_adjust_point): Likewise.
4052 (composition_update_it): Mark var as initialized.
4053 (find_automatic_composition): Mark vars as initialized,
4054 with a FIXME (Bug#8290).
4056 character.h: Rename locals to avoid shadowing.
4057 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4058 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4059 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4060 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4063 * textprop.c (property_change_between_p): Remove; unused.
4065 * intervals.c (interval_start_pos): Now static.
4067 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4069 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4070 Rename locals to avoid shadowing.
4072 * sound.c (wav_play, au_play, Fplay_sound_internal):
4073 Fix pointer signedness.
4074 (alsa_choose_format): Remove unused local var.
4075 (wav_play): Initialize a variable to 0, to prevent undefined
4076 behavior (Bug#8278).
4078 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4080 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4082 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4083 clobbering (Bug#8298).
4084 * sysdep.c (sys_subshell): Likewise.
4085 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4087 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4088 This should get cleaned up, so that child_setup has the
4089 same signature on all platforms.
4091 * callproc.c (call_process_cleanup): Now static.
4092 (relocate_fd): Rename locals to avoid shadowing.
4094 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4096 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4097 not to be necessary, and produces flickering.
4099 2011-03-20 Glenn Morris <rgm@gnu.org>
4101 * config.in: Remove file.
4103 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4105 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4106 are now in src/globals.h.
4107 (syms_of_minibuf): Remove spurious & from previous change.
4109 2011-03-20 Leo <sdl.web@gmail.com>
4111 * minibuf.c (completing-read-function): New variable.
4112 (completing-read-default): Rename from completing-read.
4113 (completing-read): Call completing-read-function.
4115 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4117 * xfaces.c (Fx_load_color_file):
4118 Read color file from absolute filename (bug#8250).
4120 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4122 * makefile.w32-in: Update dependencies.
4124 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4126 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4128 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4130 Fix more problems found by GCC 4.5.2's static checks.
4132 * process.c (make_serial_process_unwind, send_process_trap):
4133 (sigchld_handler): Now static.
4135 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4136 That way, the code declares only the vars that it needs.
4137 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4138 * s/cygwin.h (PTY_ITERATION): Likewise.
4139 * s/darwin.h (PTY_ITERATION): Likewise.
4140 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4142 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4143 * process.c (allocate_pty): Don't declare stb unless it's needed.
4145 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4146 (CONSTANTLIM): Remove; unused.
4147 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4148 Define only if needed.
4150 * unexelf.c (unexec): Name an expression,
4151 to avoid gcc -Wbad-function-cast warning.
4152 Use a different way to cause a compilation error if anyone uses
4153 n rather than nn, a way that does not involve shadowing.
4154 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4156 * deps.mk (unexalpha.o): Remove; unused.
4158 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4159 * unexec.h: New file.
4160 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4161 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4163 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4164 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4165 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4166 Change as necessary to match prototype in unexec.h.
4168 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4170 (back_comment, skip_chars): Mark vars as initialized.
4172 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4173 Rename locals to avoid shadowing.
4175 * lread.c (read1): Rewrite so as not to use empty "else".
4176 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4178 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4180 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4181 warning when compiling print.c.
4183 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4184 instead of using an uninitialized var.
4185 (font_sort_entities): Mark var as initialized.
4187 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4189 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4190 pointers to constants.
4191 (font_parse_fcname): Remove unused vars.
4192 (font_delete_unmatched): Now static.
4193 (font_get_spec): Remove; unused.
4194 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4195 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4196 Rename or move locals to avoid shadowing.
4198 * fns.c (require_nesting_list, require_unwind): Now static.
4199 (Ffillarray): Rename locals to avoid shadowing.
4201 * floatfns.c (domain_error2): Define only if needed.
4202 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4204 * alloc.c (mark_backtrace): Move decl from here ...
4205 * lisp.h: ... to here, so that it can be checked.
4207 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4208 (Fdefvar): Rewrite so as not to use empty "else".
4209 (lisp_indirect_variable): Name an expression,
4210 to avoid gcc -Wbad-function-cast warning.
4211 (Fdefvar): Rename locals to avoid shadowing.
4213 * callint.c (quotify_arg, quotify_args): Now static.
4214 (Fcall_interactively): Rename locals to avoid shadowing.
4215 Use const pointer when appropriate.
4217 * lisp.h (get_system_name, get_operating_system_release):
4218 Move decls here, to check interfaces.
4219 * process.c (get_operating_system_release): Move decl to lisp.h.
4220 * xrdb.c (get_system_name): Likewise.
4221 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4222 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4223 some of which prompt warnings from gcc -Wbad-function-cast.
4224 (Fformat_time_string, Fencode_time, Finsert_char):
4225 (Ftranslate_region_internal, Fformat):
4226 Rename or remove local vars to avoid shadowing.
4227 (Ftranslate_region_internal): Mark var as initialized.
4229 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4232 * lisp.h (eassert): Check that the argument compiles, even if
4233 ENABLE_CHECKING is not defined.
4235 * data.c (Findirect_variable): Name an expression, to avoid
4236 gcc -Wbad-function-cast warning.
4237 (default_value, arithcompare, arith_driver, arith_error): Now static.
4238 (store_symval_forwarding): Rename local to avoid shadowing.
4239 (Fmake_variable_buffer_local, Fmake_local_variable):
4240 Mark variables as initialized.
4241 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4243 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4244 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4245 Rename locals to avoid shadowing.
4246 (mark_stack): Move local variables into the #ifdef region where
4248 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4249 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4251 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4252 (GC_STRING_CHARS): Remove; not used.
4253 (Fmemory_limit): Cast sbrk's returned value to char *.
4255 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4256 avoids undefined behavior in theory.
4258 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4260 Use functions, not macros, for up- and down-casing (Bug#8254).
4261 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4262 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4263 to use the following functions instead of these macros.
4264 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4265 EMACS_INT, since callers assume the returned value fits in int.
4266 (upcase1): Likewise, for UPCASE_TABLE.
4267 (uppercasep, lowercasep, upcase): New static inline functions.
4268 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4269 the race-condition problem in the old DOWNCASE.
4271 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4272 Rename locals to avoid shadowing.
4273 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4274 (regex_compile, re_search_2, re_match_2_internal):
4275 Remove unused local vars.
4276 (FREE_VAR): Rewrite so as not to use empty "else",
4277 which gcc can warn about.
4278 (regex_compile, re_match_2_internal): Mark locals as initialized.
4279 (RETALLOC_IF): Define only if needed.
4280 (WORDCHAR_P): Likewise. This one is never needed, but is used
4281 only in a comment talking about a compiler bug, so put inside
4282 the #if 0 of that comment.
4283 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4284 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4287 * search.c (boyer_moore): Rename locals to avoid shadowing.
4288 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4289 (PREV_CHAR_BOUNDARY): Likewise.
4291 * search.c (simple_search): Remove unused var.
4293 * dired.c (compile_pattern): Move decl from here ...
4294 * lisp.h: ... to here, so that it can be checked.
4295 (struct re_registers): New forward decl.
4297 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4299 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4301 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4302 Rename locals to avoid shadowing.
4303 (Fvertical_motion): Mark locals as initialized.
4305 * casefiddle.c (casify_object, casify_region): Now static.
4306 (casify_region): Mark local as initialized.
4308 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4310 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4311 New macros, so that the caller can use some names other than
4312 gcpro1, gcpro2, etc.
4313 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4315 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4316 argument, for consistency with GCPRO2_VAR, etc: it is now the
4317 prefix of the variable, not the variable itself. All uses
4319 * dired.c (directory_files_internal, file_name_completion):
4320 Rename locals to avoid shadowing.
4322 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4323 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4324 dired.c's scmp function, had undefined behavior.
4325 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4326 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4327 * buffer.h: ... to here, because these macros use current_buffer,
4328 and the new implementation with inline functions needs to have
4329 current_buffer in scope now, rather than later when the macros
4331 (downcase, upcase1): New static inline functions.
4332 (DOWNCASE, UPCASE1): Reimplement using these functions.
4333 This avoids undefined behavior in expressions like
4334 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4335 from race conditions in accessing the global variables
4336 case_temp1 and case_temp2.
4337 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4338 * lisp.h (case_temp1, case_temp2): Remove their decls.
4339 * character.h (ASCII_CHAR_P): Move from here ...
4340 * lisp.h: ... to here, so that the inline functions mentioned
4343 * dired.c (directory_files_internal_unwind): Now static.
4345 * fileio.c (file_name_as_directory, directory_file_name):
4346 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4348 (file_name_as_directory): Use const pointers when appropriate.
4349 (Fexpand_file_name): Likewise. In particular, newdir might
4350 point at constant storage, so make it a const pointer.
4351 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4352 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4354 (Fset_file_times, Finsert_file_contents, auto_save_error):
4355 Rename locals to avoid shadowing.
4357 * minibuf.c (choose_minibuf_frame_1): Now static.
4358 (Ftry_completion, Fall_completions): Rename or remove locals
4361 * marker.c (bytepos_to_charpos): Remove; unused.
4363 * lisp.h (verify_bytepos, count_markers): New decls,
4364 so that gcc does not warn that these functions aren't declared.
4366 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4367 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4368 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4369 (copy_text): Remove unused local var.
4371 * filelock.c (within_one_second): Now static.
4372 (lock_file_1): Rename local to avoid shadowing.
4374 * buffer.c (fix_overlays_before): Mark locals as initialized.
4375 (fix_start_end_in_overlays): Likewise. This function should be
4376 simplified by using pointers-to-pointers, but that's a different
4378 (switch_to_buffer_1): Now static.
4379 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4380 (report_overlay_modification): Rename locals to avoid shadowing.
4382 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4383 Fix pointer signedness issue.
4384 (sys_subshell): Mark local as volatile if checking for lint,
4385 to suppress a gcc -Wclobbered warning that does not seem to be right.
4386 (MAXPATHLEN): Define only if needed.
4388 * process.c (serial_open, serial_configure): Move decls from here ...
4389 * systty.h: ... to here, so that they can be checked.
4391 * fns.c (get_random, seed_random): Move extern decls from here ...
4392 * lisp.h: ... to here, so that they can be checked.
4394 * sysdep.c (reset_io): Now static.
4395 (wait_for_termination_signal): Remove; unused.
4397 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4398 (copy_keymap_item, append_key, push_text_char_description):
4400 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4401 (DENSE_TABLE_SIZE): Remove; unused.
4402 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4403 (describe_map_tree):
4404 Rename locals to avoid shadowing.
4406 * keyboard.c: Declare functions static if they are not used elsewhere.
4407 (echo_char, echo_dash, cmd_error, top_level_2):
4408 (poll_for_input, handle_async_input): Now static.
4409 (read_char, kbd_buffer_get_event, make_lispy_position):
4410 (make_lispy_event, make_lispy_movement, apply_modifiers):
4411 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4412 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4413 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4414 (read_key_sequence, read_char): Mark locals as initialized.
4415 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4417 * keyboard.h (make_ctrl_char): New decl.
4418 (mark_kboards): Move decl here ...
4419 * alloc.c (mark_kboards): ... from here.
4421 * lisp.h (force_auto_save_soon): New decl.
4423 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4424 (DEFINE_DUMMY_FUNCTION): New macro.
4425 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4427 (main): Add casts to avoid warnings
4428 if GCC considers string literals to be constants.
4430 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4432 * dbusbind.c: Pointer signedness fixes.
4433 (xd_signature, xd_append_arg, xd_initialize):
4434 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4435 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4436 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4437 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4439 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4440 if GCC considers string literals to be constants.
4441 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4443 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4445 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4446 (print_preprocess, print_object): New macro to fix last change.
4448 * print.c (print_preprocess): Don't forget font objects.
4450 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4452 * emacs.c (USAGE3): Doc fixes.
4454 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4456 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4459 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4461 * lisp.h (VWindow_system, Qfile_name_history):
4462 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4463 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4464 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4466 * w32select.c: Don't #include "keyboard.h".
4467 (run_protected): Add extern declaration for waiting_for_input.
4469 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4470 * w32console.c (detect_input_pending, read_input_pending)
4471 (encode_terminal_code):
4472 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4473 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4474 (w32_system_caret_y, Qfile_name_history):
4475 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4476 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4477 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4478 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4479 * w32proc.c (Qlocal, report_file_error):
4480 * w32term.c (Vwindow_system, updating_frame):
4481 * w32uniscribe.c (initialized, uniscribe_font_driver):
4482 Remove unneeded extern declarations.
4484 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4486 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4488 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4490 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4491 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4492 These macros can no longer be used for assignment.
4494 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4495 Assign struct members directly, instead of using BUF_BEGV etc.
4496 (record_buffer_markers, fetch_buffer_markers): New functions for
4497 recording and fetching special buffer markers.
4498 (set_buffer_internal_1, set_buffer_temp): Use them.
4500 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4502 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4504 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4505 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4507 * xdisp.c (hscroll_window_tree):
4508 (reconsider_clip_changes): Use PT instead of BUF_PT.
4510 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4512 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4513 $(EMACS_ROOT)/lib/intprops.h.
4515 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4517 Fix more problems found by GCC 4.5.2's static checks.
4519 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4520 to unsigned char * to avoid compiler diagnostic.
4521 (xg_free_frame_widgets): Make it clear that a local variable is
4522 needed only if USE_GTK_TOOLTIP.
4523 (gdk_window_get_screen): Make it clear that this macro is needed
4524 only if USE_GTK_TOOLTIP.
4525 (int_gtk_range_get_value): New function, which avoids a diagnostic
4526 from gcc -Wbad-function-cast.
4527 (xg_set_toolkit_scroll_bar_thumb): Use it.
4528 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4529 diagnostic from gcc -Wbad-function-cast.
4530 (get_utf8_string, xg_get_file_with_chooser):
4531 Rename locals to avoid shadowing.
4532 (create_dialog): Move locals to avoid shadowing.
4534 * xgselect.c (xg_select): Remove unused var.
4536 * image.c (four_corners_best): Mark locals as initialized.
4537 (gif_load): Initialize transparent_p to zero (Bug#8238).
4538 Mark another local as initialized.
4539 (my_png_error, my_error_exit): Mark with NO_RETURN.
4541 * image.c (clear_image_cache): Now static.
4542 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4543 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4544 (x_edge_detection): Remove unnecessary cast that
4545 gcc -Wbad-function-cast diagnoses.
4546 (gif_load): Fix pointer signedness.
4547 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4548 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4550 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4552 Improve quality of tests for time stamp overflow.
4553 For example, without this patch (encode-time 0 0 0 1 1
4554 1152921504606846976) returns the obviously-bogus value (-948597
4555 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4556 reports time overflow. See
4557 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4558 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4559 * editfns.c: Include limits.h and intprops.h.
4560 (TIME_T_MIN, TIME_T_MAX): New macros.
4561 (time_overflow): Move earlier, to before first use.
4562 (hi_time, lo_time): New functions, for an accurate test for
4564 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4565 (Fget_internal_run_time): Don't assume time_t fits in int.
4566 (make_time): Use list2 instead of Fcons twice.
4567 (Fdecode_time): More accurate test for out-of-range times.
4568 (check_tm_member): New function.
4569 (Fencode_time): Use it, to test for out-of-range times.
4570 (lisp_time_argument): Don't rely on undefined left-shift and
4571 right-shift behavior when checking for time stamp overflow.
4573 * editfns.c (time_overflow): New function, refactoring common code.
4574 (Fformat_time_string, Fdecode_time, Fencode_time):
4575 (Fcurrent_time_string): Use it.
4577 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4578 * dired.c (make_time): Move to ...
4579 * editfns.c (make_time): ... here.
4580 * systime.h: Note the move.
4582 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4584 * fringe.c (update_window_fringes): Remove unused variables.
4586 * unexmacosx.c (copy_data_segment): Also copy __got section.
4589 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4591 * termcap.c [MSDOS]: Include "msdos.h".
4592 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4593 Constify `char *' arguments and their references according to
4594 prototypes in tparam.h.
4596 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4598 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4599 Adapt all references accordingly.
4601 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4603 2011-03-11 Tom Tromey <tromey@redhat.com>
4605 * buffer.c (syms_of_buffer): Remove obsolete comment.
4607 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4609 * termhooks.h (encode_terminal_code): Declare prototype.
4611 * msdos.c (encode_terminal_code): Don't declare prototype.
4613 * term.c (encode_terminal_code): Now external again, used by
4614 w32console.c and msdos.c.
4616 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4617 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4619 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4621 Fix some minor problems found by GCC 4.5.2's static checks.
4623 * fringe.c (update_window_fringes): Mark locals as initialized
4625 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4627 * alloc.c (mark_fringe_data): Move decl from here ...
4628 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4629 to check its interface.
4630 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4632 * fontset.c (free_realized_fontset): Now static.
4633 (Fset_fontset_font): Rename local to avoid shadowing.
4634 (fontset_font): Mark local as initialized.
4635 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4637 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4639 * xselect.c (x_disown_buffer_selections): Remove; not used.
4640 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4641 (x_own_selection, Fx_disown_selection_internal): Rename locals
4643 (x_handle_dnd_message): Remove local to avoid shadowing.
4645 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4646 so that the caller can use some name other than gcpro1.
4647 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4648 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4649 (Fx_backspace_delete_keys_p):
4650 Use them to avoid shadowing, and rename vars to avoid shadowing.
4651 (x_decode_color, x_set_name, x_window): Now static.
4652 (Fx_create_frame): Add braces to silence GCC warning.
4653 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4654 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4655 Remove unused locals.
4656 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4657 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4658 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4661 * xterm.h (x_mouse_leave): New decl.
4663 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4664 Remove unused functions.
4665 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4666 (x_calc_absolute_position): Now static.
4667 (XTread_socket): Don't define label "out" unless it's used.
4668 Don't declare local "event" unless it's used.
4669 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4670 unless they are used.
4671 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4672 (x_fatal_error_signal): Remove; not used.
4673 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4674 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4675 (x_error_catcher, x_connection_closed, x_error_handler):
4676 (x_error_quitter, xembed_send_message, x_iconify_frame):
4677 (my_log_handler): Rename locals to avoid shadowing.
4678 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4679 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4681 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4682 Rename or move locals to avoid shadowing.
4683 (tty_defined_color, merge_face_heights): Now static.
4684 (free_realized_faces_for_fontset): Remove; not used.
4685 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4686 does not deduce is never used uninitialized.
4687 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4688 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4690 * terminal.c (store_terminal_param): Now static.
4692 * xmenu.c (menu_highlight_callback): Now static.
4693 (set_frame_menubar): Remove unused local.
4694 (xmenu_show): Rename parameter to avoid shadowing.
4695 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4696 since they might point to immutable storage.
4697 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4698 since it's unused otherwise.
4700 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4701 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4702 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4703 avoids a gcc -Wuninitialized diagnostic.
4704 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4705 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4706 does not deduce are never used uninitialized.
4708 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4710 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4711 * window.c (window_loop, size_window):
4712 (run_window_configuration_change_hook, enlarge_window): Likewise.
4714 * window.c (display_buffer): Now static.
4715 (size_window): Mark variables that gcc -Wuninitialized
4716 does not deduce are never used uninitialized.
4717 * window.h (check_all_windows): New decl, to forestall
4718 gcc -Wmissing-prototypes diagnostic.
4719 * dispextern.h (bidi_dump_cached_states): Likewise.
4721 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4723 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4725 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4726 and to avoid gcc -Wuninitialized warning.
4727 (load_charset_map): Mark variables that gcc -Wuninitialized
4728 does not deduce are never used uninitialized.
4729 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4731 * coding.c (coding_set_source, coding_set_destination):
4732 Use "else { /* comment */ }" rather than "else /* comment */;"
4733 for clarity, and to avoid gcc -Wempty-body warning.
4734 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4735 a block, when the outer 'i' will do.
4736 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4737 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4738 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4739 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4740 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4741 Rename locals to avoid shadowing.
4742 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4743 * coding.c (emacs_mule_char, encode_invocation_designation):
4744 Now static, since they're not used elsewhere.
4745 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4746 (decode_coding_object, encode_coding_object, detect_coding_system):
4747 (decode_coding_emacs_mule): Mark variables that gcc
4748 -Wuninitialized does not deduce are never used uninitialized.
4749 (detect_coding_iso_2022): Initialize a local variable that might
4750 be used uninitialized. Leave a FIXME because it's not clear that
4751 this initialization is needed. (Bug#8211)
4752 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4753 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4754 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4755 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4756 Remove unused macros.
4758 * category.c (hash_get_category_set): Remove unused local var.
4759 (copy_category_table): Now static, since it's not used elsewhere.
4760 * character.c (string_count_byte8): Likewise.
4762 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4763 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4765 * chartab.c (copy_sub_char_table): Now static, since it's not used
4767 (sub_char_table_ref_and_range, char_table_ref_and_range):
4768 Rename locals to avoid shadowing.
4769 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4771 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4772 (BIDI_BOB): Remove unused macro.
4774 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4775 deduce are never used uninitialized.
4776 * term.c (encode_terminal_code): Likewise.
4778 * term.c (encode_terminal_code): Now static. Remove unused local.
4780 * tparam.h: New file.
4781 * term.c, tparam.h: Include it.
4782 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4783 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4784 Move these decls to tparam.h, and make them agree with what
4785 is actually in tparam.c. The previous trick of using incompatible
4786 decls in different modules does not conform to the C standard.
4787 All callers of tparam changed to use tparam's actual API.
4788 * tparam.c (tparam1, tparam, tgoto):
4789 Use const pointers where appropriate.
4791 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4792 * cm.h (struct cm): Likewise.
4793 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4794 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4795 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4796 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4797 (turn_on_face, init_tty): Likewise.
4798 * termchar.h (struct tty_display_info): Likewise.
4800 * term.c (term_mouse_position): Rename local to avoid shadowing.
4802 * alloc.c (mark_ttys): Move decl from here ...
4803 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4805 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4807 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4809 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4811 * search.c (compile_pattern_1): Remove argument regp, unused since
4812 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4813 (compile_pattern): Don't pass it.
4815 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4817 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4818 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4820 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4822 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4824 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4825 gdk_window_get_screen, gdk_window_get_geometry,
4826 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4827 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4828 (xg_get_pixbuf_from_pixmap): New function.
4829 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4830 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4831 Call xg_get_pixbuf_from_pixmap instead of
4832 gdk_pixbuf_get_from_drawable.
4833 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4834 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4835 (xg_check_special_colors): Use GtkStyleContext and its functions
4837 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4838 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4839 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4840 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4841 Call gtk_widget_get_preferred_size.
4842 (xg_frame_resized): gdk_window_get_geometry only takes 5
4844 (xg_win_to_widget, xg_event_is_for_menubar):
4845 Call gdk_x11_window_lookup_for_display.
4846 (xg_set_widget_bg): New function.
4847 (delete_cb): New function.
4848 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4849 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4850 (xg_set_background_color): Call xg_set_widget_bg.
4851 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4852 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4853 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4854 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4856 (update_frame_tool_bar): Call gtk_widget_hide.
4857 (xg_initialize): Use GDK_KEY_g.
4859 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4861 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4863 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4864 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4865 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4867 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4869 * w32xfns.c (select_palette): Check success of RealizePalette against
4870 GDI_ERROR, not zero.
4872 See ChangeLog.11 for earlier changes.
4878 Copyright (C) 2011 Free Software Foundation, Inc.
4880 This file is part of GNU Emacs.
4882 GNU Emacs is free software: you can redistribute it and/or modify
4883 it under the terms of the GNU General Public License as published by
4884 the Free Software Foundation, either version 3 of the License, or
4885 (at your option) any later version.
4887 GNU Emacs is distributed in the hope that it will be useful,
4888 but WITHOUT ANY WARRANTY; without even the implied warranty of
4889 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4890 GNU General Public License for more details.
4892 You should have received a copy of the GNU General Public License
4893 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.