1 2012-02-24 Chong Yidong <cyd@gnu.org>
3 * keyboard.c (process_special_events): Handle all X selection
4 requests in kbd_buffer, not just the next one (Bug#8869).
6 2012-02-23 Chong Yidong <cyd@gnu.org>
8 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9 call when setting menu-bar-lines and tool-bar-lines parameters.
10 (unwind_create_frame_1): New helper function.
12 * window.c (inhibit_window_configuration_change_hook): New var.
13 (run_window_configuration_change_hook): Obey it.
14 (syms_of_window): Initialize it.
16 2012-02-22 Chong Yidong <cyd@gnu.org>
18 * xterm.c (x_draw_image_relief): Add missing type check for
19 Vtool_bar_button_margin (Bug#10743).
21 2012-02-21 Chong Yidong <cyd@gnu.org>
23 * fileio.c (Vfile_name_handler_alist): Doc fix.
25 * buffer.c (Fget_file_buffer): Protect against invalid file
28 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
30 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
31 when computing $valmask.
33 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
34 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
35 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
36 It's useless in that case, and it can cause problems on hosts
37 that allocate halves of EMACS_INT values separately.
38 Reported by Dan Horák. Diagnosed by Andreas Schwab in
39 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
40 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
41 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
42 it avoids undefined behavior on hosts where shifting right by more
43 than the word width has undefined behavior.
45 2012-02-19 Chong Yidong <cyd@gnu.org>
47 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
48 (Funhandled_file_name_directory, Ffile_name_as_directory)
49 (Fdirectory_file_name, Fexpand_file_name)
50 (Fsubstitute_in_file_name): Protect against invalid file handler
51 return values (Bug#10845).
53 2012-02-18 Eli Zaretskii <eliz@gnu.org>
55 * .gdbinit (pitx): Fix incorrect references to fields of the
58 2012-02-17 Chong Yidong <cyd@gnu.org>
60 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
62 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
64 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
65 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
67 2012-02-15 Chong Yidong <cyd@gnu.org>
69 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
70 marked as special. Also, starting docstrings with * is obsolete.
72 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
74 * gnutls.c (emacs_gnutls_write): Fix last change.
76 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
78 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
81 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
83 * keymap.c (Fsingle_key_description): Handle char ranges.
85 2012-02-12 Chong Yidong <cyd@gnu.org>
87 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
88 as that creates a dangerous corner case.
90 * window.c (Fdelete_window_internal): Invalidate the mouse
93 2012-02-12 Glenn Morris <rgm@gnu.org>
95 * xselect.c (Fx_own_selection_internal)
96 (Fx_get_selection_internal, Fx_disown_selection_internal)
97 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
98 * nsselect.m (Fx_own_selection_internal)
99 (Fx_disown_selection_internal, Fx_selection_exists_p)
100 (Fx_selection_owner_p, Fx_get_selection_internal):
101 Sync docs and argument specs with the xselect.c versions.
103 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
105 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
107 2012-02-11 Eli Zaretskii <eliz@gnu.org>
109 * w32select.c (Fx_selection_exists_p): Sync doc string and
110 argument list with xselect.c. (Bug#10783)
112 * w16select.c (Fx_selection_exists_p): Sync doc string and
113 argument list with xselect.c. (Bug#10783)
115 2012-02-10 Glenn Morris <rgm@gnu.org>
117 * fns.c (Fsecure_hash): Doc fix.
119 2012-02-09 Kenichi Handa <handa@m17n.org>
121 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
123 2012-02-07 Chong Yidong <cyd@gnu.org>
125 * buffer.c (Fbuffer_local_variables)
126 (buffer_lisp_local_variables): Handle unbound vars correctly;
127 don't let Qunbound leak into Lisp.
129 2012-02-07 Glenn Morris <rgm@gnu.org>
131 * image.c (Fimagemagick_types): Doc fix.
133 * image.c (imagemagick-render-type): Change it from a lisp object
134 to an integer. Move the doc here from the lisp manual.
135 Treat all values not equal to 0 the same.
137 2012-02-06 Chong Yidong <cyd@gnu.org>
139 * doc.c (store_function_docstring): Avoid applying docstring of
140 alias to base function (Bug#2603).
142 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
144 * .gdbinit (pp1, pv1): Remove redundant defines.
147 2012-02-04 Chong Yidong <cyd@gnu.org>
149 * nsterm.m: Declare a global (Bug#10694).
151 2012-02-04 Eli Zaretskii <eliz@gnu.org>
153 * w32.c (get_emacs_configuration_options): Include
154 --enable-checking, if specified, in the return value.
156 2012-02-04 Martin Rudalics <rudalics@gmx.at>
158 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
159 after rounding frame sizes. (Bug#9723)
161 2012-02-04 Eli Zaretskii <eliz@gnu.org>
163 * keyboard.c (adjust_point_for_property): Don't position point
164 before BEGV. (Bug#10696)
166 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
168 Handle overflow when computing char display width (Bug#9496).
169 * character.c (char_width): Return EMACS_INT, not int.
170 (char_width, c_string_width): Check for overflow when
171 computing the width; this is possible now that individual
172 characters can have unbounded width. Problem introduced
173 by merge from Emacs 23 on 2012-01-19.
175 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
177 * dbusbind.c (Fdbus_register_method): Mention the return value
178 :ignore in the docstring.
180 2012-02-02 Glenn Morris <rgm@gnu.org>
182 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
184 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
185 Unconditionally set to t. (Bug#10673)
186 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
187 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
188 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
190 2012-02-02 Kenichi Handa <handa@m17n.org>
192 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
193 0, do not call append_composite_glyph.
195 2012-02-02 Kenichi Handa <handa@m17n.org>
197 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
199 (x_produce_glyphs): If the component of a composition is a null
200 string, set it->pixel_width to 1 to avoid zero-width glyph.
202 2012-02-01 Eli Zaretskii <eliz@gnu.org>
204 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
205 first 2 arguments are identical. This makes inserting large
206 output from a subprocess an order of magnitude faster on
207 MS-Windows, where all sbrk'ed memory is always contiguous.
209 2012-01-31 Glenn Morris <rgm@gnu.org>
211 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
212 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
213 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
215 2012-01-29 Glenn Morris <rgm@gnu.org>
217 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
219 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
221 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
223 2012-01-28 Chong Yidong <cyd@gnu.org>
225 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
227 2012-01-26 Chong Yidong <cyd@gnu.org>
229 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
231 * search.c (Fsearch_forward, Fsearch_backward): Document negative
232 repeat counts (Bug#10507).
234 2012-01-26 Glenn Morris <rgm@gnu.org>
236 * lread.c (syms_of_lread): Doc fix.
238 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
240 * coding.c (encode_designation_at_bol): Change return value to
243 2012-01-25 Chong Yidong <cyd@gnu.org>
245 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
247 2012-01-21 Chong Yidong <cyd@gnu.org>
249 * floatfns.c (Fcopysign): Make the second argument non-optional,
250 since nil is not allowed anyway.
252 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
254 * process.c (read_process_output): Use p instead of XPROCESS (proc).
255 (send_process): Likewise.
257 2012-01-19 Martin Rudalics <rudalics@gmx.at>
259 * window.c (save_window_save, Fcurrent_window_configuration)
260 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
263 2012-01-19 Kenichi Handa <handa@m17n.org>
265 * character.c (char_width): New function.
266 (Fchar_width, c_string_width, lisp_string_width):
267 Use char_width (Bug#9496).
269 2012-01-16 Martin Rudalics <rudalics@gmx.at>
271 * window.c (Vwindow_persistent_parameters): New variable.
272 (Fset_window_configuration, save_window_save): Handle persistent
275 2012-01-14 Eli Zaretskii <eliz@gnu.org>
277 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
278 thrashing the stack of the thread. (Bug#9087)
280 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
282 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
284 2012-01-11 Eli Zaretskii <eliz@gnu.org>
286 * xdisp.c (rows_from_pos_range): Handle the case where the
287 highlight ends on a newline. (Bug#10464)
288 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
289 he end column for display of highlight that ends on a newline
292 2012-01-11 Glenn Morris <rgm@gnu.org>
294 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
295 from load-path also when installation-directory is nil. (Bug#10208)
297 2012-01-10 Glenn Morris <rgm@gnu.org>
299 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
301 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
302 Update template values to be closer to their typical values these days.
304 2012-01-09 Eli Zaretskii <eliz@gnu.org>
306 * xdisp.c (rows_from_pos_range): Accept additional argument
307 DISP_STRING, and accept any glyph in a row whose object is that
308 string as eligible for mouse highlight. Fixes mouse highlight of
309 display strings from overlays. (Bug#10464)
311 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
313 emacs: fix an auto-save permissions race condition (Bug#10400)
314 * fileio.c (auto_saving_dir_umask): New static var.
315 (Fmake_directory_internal): Use it.
316 (do_auto_save_make_dir): Set it, instead of invoking chmod after
317 creating the directory. The old code temporarily assigns
318 too-generous permissions to the directory.
319 (do_auto_save_eh): Clear it.
320 (Fdo_auto_save): Catch all errors, not just file errors, so
321 that the var is always cleared.
323 2012-01-07 Eli Zaretskii <eliz@gnu.org>
325 * search.c (scan_buffer): Pass character positions to
326 know_region_cache, not byte positions. (Bug#6540)
328 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
330 * w32.c (sys_rename): Report EXDEV when rename of a directory
331 fails because the target is on another logical disk. (Bug#10284)
333 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
335 * xterm.c (x_embed_request_focus): New function.
337 * xterm.h: Add prototype.
339 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
341 2012-01-05 Glenn Morris <rgm@gnu.org>
343 * emacs.c (emacs_copyright): Update short copyright year to 2012.
345 2012-01-01 Eli Zaretskii <eliz@gnu.org>
347 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
348 Load gnutls_transport_set_lowat only if GnuTLS version is below
350 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
351 GnuTLS versions below 2.11.1.
353 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
355 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
356 to the doc string advising against its use for altering the way
357 windows are scrolled.
359 2011-12-28 Kenichi Handa <handa@m17n.org>
361 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
362 coding-system ASCII compatible only when it does not produce BOM
363 on encoding (Bug#10383).
365 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
367 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
369 (create_and_show_popup_menu): Always use menu_position_func for
372 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
374 * callint.c (Fcall_interactively): Don't truncate prompt string.
376 2011-12-23 Eli Zaretskii <eliz@gnu.org>
378 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
379 property that ends at ZV, so that the bidi iteration could be
380 resumed from there (after widening). (Bug#10360)
382 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
384 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
386 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
388 * nsterm.m (x_free_frame_resources):
389 Release f->output_data.ns->miniimage.
390 (ns_index_color): Fix indentation. Do not retain
391 color_table->colors[i].
393 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
396 * nsfns.m (x_set_background_color): Assign return value from
397 ns_index_color to face-background instead of NSColor*.
398 (ns_implicitly_set_icon_type): Fix indentation.
399 Change assignment in for loop to comparison.
401 * emacs.c (ns_pool): New variable.
402 (main): Assign ns_pool.
403 (Fkill_emacs): Call ns_release_autorelease_pool.
405 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
406 autorelease fdesc, release fdAttrs and tdict.
407 (ns_get_covering_families): Release charset.
408 (ns_findfonts): Release NSFontDescriptor created with new.
409 (ns_uni_to_glyphs): Fix indentation.
410 (setString): Release attrStr before assigning new value.
412 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
414 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
416 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
417 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
419 2011-12-18 David Reitter <reitter@cmu.edu>
421 * nsterm.m (ns_term_init): Subscribe for notifications
422 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
423 to method trackingNotification in EmacsMenu.
425 * nsmenu.m (trackingMenu): New variable.
426 (trackingNotification): New method (from Aquamacs).
427 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
428 from Aquamacs (Bug#7030).
430 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
432 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
433 (symbol_to_nsstring): Fix indentation.
434 (ns_symbol_to_pb): New function.
435 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
436 (Fns_rotate_cut_buffers_internal): Removed.
437 (Fns_store_selection_internal): Renamed from
438 Fns_store_cut_buffer_internal.
439 (ns_get_foreign_selection, Fx_own_selection_internal)
440 (Fx_disown_selection_internal, Fx_selection_exists_p)
441 (Fns_get_selection_internal, Fns_store_selection_internal):
442 Use ns_symbol_to_pb and check if return value is nil.
443 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
444 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
445 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
446 renamed to Sns_store_selection_internal.
447 (ns_handle_selection_request): Move code to Fx_own_selection_internal
448 and remove this function.
449 (ns_handle_selection_clear): Remove, never used.
450 (Fx_own_selection_internal): Move code from ns_handle_selection_request
453 2011-12-17 Ken Brown <kbrown@cornell.edu>
455 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
456 GID is unknown (Bug#10257).
458 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
460 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
461 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
462 which caused a build failure on GNU/Linux IA-64. This problem was
463 introduced by my 2011-10-07 patch.
465 2011-12-15 Juri Linkov <juri@jurta.org>
467 * image.c (imagemagick_error): New function. (Bug#10112)
468 (imagemagick_load_image): Comment out `MagickSetResolution' call.
469 Use `imagemagick_error' where ImageMagick functions return
471 (Fimagemagick_types): Add `Fnreverse' to return the list in the
474 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
476 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
477 fill background (Bug#8992).
479 2011-12-13 Martin Rudalics <rudalics@gmx.at>
481 * window.c (Vwindow_combination_resize)
482 (Vwindow_combination_limit): Use t instead of non-nil in
484 (Vrecenter_redisplay): Add first sentence of doc-string on
486 (Frecenter): Fix doc-string typo.
488 2011-12-11 Kenichi Handa <handa@m17n.org>
490 * coding.c (Funencodable_char_position): Pay attention to the
491 buffer text relocation (Bug#9389).
493 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
495 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
496 gtk_init (Bug#10100).
498 2011-12-10 Eli Zaretskii <eliz@gnu.org>
500 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
501 IT->string is nil. (Bug#10263)
503 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
505 * nsterm.h (x_free_frame_resources): Declare.
507 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
508 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
510 * nsterm.h (ns_get_defaults_value): Declare.
512 * nsterm.m (ns_default): Call ns_get_defaults_value.
514 2011-12-09 Eli Zaretskii <eliz@gnu.org>
516 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
519 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
521 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
522 that where the value of an _OBJC_* symbol points to is in the .bss
525 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
527 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
528 after the loop to call ccl_driver at least once (Bug#8619).
530 2011-12-08 Kenichi Handa <handa@m17n.org>
532 * ftfont.c (get_adstyle_property): Fix previous change
535 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
537 * w32.c (init_environment): If no_site_lisp, remove site-lisp
538 dirs from the default value of EMACSLOADPATH (bug#10208).
540 2011-12-07 Glenn Morris <rgm@gnu.org>
542 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
543 installation and source directories as well. (Bug#10208)
545 2011-12-06 Chong Yidong <cyd@gnu.org>
547 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
549 2011-12-06 Glenn Morris <rgm@gnu.org>
551 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
552 as an error, not just -1. (Bug#10217)
554 2011-12-05 Chong Yidong <cyd@gnu.org>
556 * keyboard.c (process_special_events): New function.
557 (swallow_events, Finput_pending_p): Use it (Bug#10195).
559 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
561 * coding.c (encode_designation_at_bol): Don't use uninitialized
562 local variable (Bug#9318).
564 2011-12-05 Kenichi Handa <handa@m17n.org>
566 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
567 return Qnil (Bug#8046, Bug#10193).
569 2011-12-05 Kenichi Handa <handa@m17n.org>
571 * coding.c (encode_designation_at_bol): New args charbuf_end and
572 dst. Return the number of produced bytes. Callers changed.
573 (coding_set_source): Return how many bytes coding->source was
575 (coding_set_destination): Return how many bytes
576 coding->destination was relocated.
577 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
578 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
580 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
582 * coding.c (CODING_CHAR_CHARSET_P): New macro.
583 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
586 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
588 The following changes are to fix Bug#9318.
590 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
591 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
592 (encode_coding_iso_2022, encode_coding_sjis)
593 (encode_coding_big5, encode_coding_charset): Use the above macros.
595 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
597 * lisp.h (process_quit_flag): Fix external declaration.
599 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
601 Don't macro-inline non-performance-critical code.
602 * eval.c (process_quit_flag): New function.
603 * lisp.h (QUIT): Use it.
605 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
607 * nsfns.m (get_geometry_from_preferences): New function.
608 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
610 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
612 * emacs.c (Qkill_emacs): Define.
613 (syms_of_emacs): Initialize it.
614 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
615 Qquit_flag to `kill-emacs' instead.
616 (quit_throw_to_read_char): Add parameter `from_signal'.
617 All callers changed. Call Fkill_emacs if requested and safe.
618 * lisp.h (QUIT): Call Fkill_emacs if requested.
620 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
622 * widget.c (update_wm_hints): Return if wmshell is null.
623 (widget_update_wm_size_hints): New function.
625 * widget.h (widget_update_wm_size_hints): Declare.
627 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
628 widget_update_wm_size_hints (Bug#10104).
630 2011-12-03 Eli Zaretskii <eliz@gnu.org>
632 * xdisp.c (handle_invisible_prop): If the invisible text ends just
633 before a newline, prepare the bidi iterator for consuming the
634 newline, and keep the current paragraph direction. (Bug#10183)
635 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
637 2011-12-02 Juri Linkov <juri@jurta.org>
639 * search.c (Fword_search_regexp): New Lisp function created from
640 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
641 (Fword_search_backward, Fword_search_forward)
642 (Fword_search_backward_lax, Fword_search_forward_lax):
643 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
644 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
646 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
648 * fileio.c (Finsert_file_contents): Move after-change-function call
649 to before the "handled:" label, since all "goto handled" appear in
650 cases where the *-change-functions have already been properly called
653 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
655 * keyboard.c (interrupt_signal): Don't call kill-emacs when
656 waiting for input. (Bug#10169)
658 2011-11-30 Eli Zaretskii <eliz@gnu.org>
660 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
661 verifies glyph row's hash code--we have just reallocated the
662 glyphs, so their contents can be complete garbage. (Bug#10164)
664 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
666 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
668 2011-11-30 Eli Zaretskii <eliz@gnu.org>
670 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
671 attributes are tested _before_ calling verify_row_hash, to protect
672 against GCC re-ordering of the tests. (Bug#10164)
674 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
676 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
678 * xterm.c (handle_one_xevent): Only set async_visible and friends
679 if net_wm_state_hidden_seen is non-zero (Bug#10002)
680 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
681 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
683 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
685 Remove GCPRO-related macros that exist only to avoid shadowing locals.
686 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
687 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
688 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
689 All uses changed to use GCPRO1 etc.
690 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
691 Revert to old implementation (i.e., before 2011-03-11).
693 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
695 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
696 of scroll runs so as to avoid assigning disabled bogus rows and
697 unnecessary graphics copy operations.
699 2011-11-27 Eli Zaretskii <eliz@gnu.org>
701 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
702 (snprintf) [_MSC_VER]: Redirect to _snprintf.
703 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
704 (malloc, free, realloc, calloc): Redirect to e_* only when
707 * lisp.h (GCTYPEBITS): Move before first use.
708 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
709 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
710 this macro definition.
712 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
715 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
717 * gtkutil.c (xg_create_frame_widgets):
718 Call gtk_window_set_has_resize_grip (FALSE) if that function is
719 present with Gtk+ 2.0.
721 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
723 * fileio.c (Finsert_file_contents): Undo previous change; see
724 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
726 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
728 Rename locals to avoid shadowing.
729 * fileio.c (Finsert_file_contents):
730 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
731 * process.c (wait_reading_process_output):
732 Rename inner 'proc' to 'p' to avoid shadowing.
733 Indent for consistency with usual Emacs style.
735 2011-11-25 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (redisplay_window): If cursor row is not fully visible
738 after recentering, and scroll-conservatively is set to a large
739 number, scroll window by a few more lines to make the cursor fully
740 visible and out of scroll-margin. (Bug#10105)
741 (start_display): Don't move to the next line if the display should
742 start at a newline that is part of a display vector or an overlay
745 2011-11-24 Juri Linkov <juri@jurta.org>
747 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
748 after the `MagickPingImage' call. (Bug#10112)
750 2011-11-23 Chong Yidong <cyd@gnu.org>
752 * window.c (Fcoordinates_in_window_p): Accept only live windows.
754 2011-11-23 Martin Rudalics <rudalics@gmx.at>
756 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
757 making another buffer current. (Bug#10114)
759 2011-11-23 Glenn Morris <rgm@gnu.org>
761 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
763 2011-11-23 Chong Yidong <cyd@gnu.org>
765 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
768 2011-11-22 Eli Zaretskii <eliz@gnu.org>
770 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
771 and header-lines, as they don't have one computed for them.
774 * .gdbinit (prow): Make displayed values more self-explaining.
777 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
779 * process.c (wait_reading_process_output): Fix asynchrounous
780 GnuTLS socket handling on some versions of the GnuTLS library.
781 (wait_reading_process_output): Add comment and URL.
783 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
785 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
787 2011-11-21 Chong Yidong <cyd@gnu.org>
789 * window.c (Fnext_window, Fprevious_window): Doc fix.
791 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
793 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
795 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
797 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
799 2011-11-20 Martin Rudalics <rudalics@gmx.at>
801 * window.c (Fset_window_combination_limit): Rename argument
803 (Vwindow_combination_limit): Remove "status" from doc-string.
805 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
807 * m/ibms390.h: Remove.
808 * m/ibms390x.h: Don't include "ibms390.h".
810 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
812 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
813 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
815 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
817 * casetab.c (Fset_case_table):
818 * charset.c (Fcharset_after): Fix typos.
820 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
822 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
823 Otherwise, valgrind does not work on some platforms.
824 Problem reported by Andreas Schwab in
825 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
826 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
827 is set, removing the need for VIRT_ADDRESS_VARIES.
828 (PURE_P): Use a more-efficient implementation that needs just one
829 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
830 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
831 to 4 (xorl, subq, cmpq, setbe).
832 * alloc.c (pure): Always extern now, since that's the
833 VIRT_ADDR_VARIES behavior.
834 (PURE_POINTER_P): Use a single comparison, not two, for
835 consistency with the new puresize.h.
836 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
837 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
838 Remove VIRT_ADDR_VARIES no longer needed.
840 2011-11-19 Eli Zaretskii <eliz@gnu.org>
842 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
843 (erase_phys_cursor, update_window_cursor, show_mouse_face)
844 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
845 behave as if the cursor position were at the window margin.
847 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
848 and the cursor position is out of bounds, behave as if the cursor
849 position were at the window margin. (Bug#10075)
851 2011-11-18 Chong Yidong <cyd@gnu.org>
853 * window.c (Fwindow_combination_limit): Make first argument
854 non-optional, since it is meaningless for live windows like the
857 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
859 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
861 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
863 * intervals.c: Fix grafting over the whole buffer (bug#10071).
864 (graft_intervals_into_buffer): Simplify.
866 2011-11-18 Eli Zaretskii <eliz@gnu.org>
868 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
869 hash values of the two rows.
870 (copy_row_except_pointers): Preserve the used[] arrays and the
871 hash values of the two rows. (Bug#10035)
872 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
874 * xdisp.c (row_hash): New function, body extracted from
875 compute_line_metrics.
876 (compute_line_metrics): Call row_hash, instead of computing the
879 * dispnew.c (verify_row_hash): Call row_hash for computing the
880 hash code of a row, instead of duplicating code from xdisp.c.
882 * dispextern.h (row_hash): Add prototype.
884 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
886 * frame.c (delete_frame): Don't delete the terminal when the last
887 X frame is closed if emacs is built with GTK toolkit.
889 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
891 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
893 2011-11-17 Martin Rudalics <rudalics@gmx.at>
895 * window.c (Vwindow_splits): Rename to
896 Vwindow_combination_resize. Suggested by Juri Linkov.
897 (Fsplit_window_internal): Use Vwindow_combination_resize instead
900 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
902 * nsfns.m (Fns_font_name):
903 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
905 2011-11-16 Martin Rudalics <rudalics@gmx.at>
907 * window.h (window): Rename slot "nest" to "combination_limit".
908 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
909 (Fset_window_nest): Rename to Fset_window_combination_limit.
910 (Vwindow_nest): Rename to Vwindow_combination_limit.
911 (recombine_windows, make_parent_window, make_window)
912 (Fsplit_window_internal, saved_window)
913 (Fset_window_configuration, save_window_save): Rename all
914 occurrences of window_nest to window_combination_limit.
916 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
918 * image.c (imagemagick_load_image): Fix typo.
920 2011-11-14 Eli Zaretskii <eliz@gnu.org>
922 * xdisp.c (display_line): Move the call to
923 highlight_trailing_whitespace before the call to
924 compute_line_metrics, since the latter needs to see the final
925 faces of all the glyphs to compute ROW's hash value.
926 Fixes assertion violations in row_equal_p. (Bug#10035)
928 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
930 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
931 just return (bug#10044).
933 2011-11-12 Eli Zaretskii <eliz@gnu.org>
935 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
936 with user-defined heap size. Bump the default size of the temacs
937 heap to 27MB, to avoid memory warning when running temacs.
938 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
940 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
941 current_matrix and desired_matrix. (Bug#9990)
942 (verify_row_hash) [XASSERTS]: New function.
943 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
944 that the hash value of glyph rows is correct.
946 2011-11-12 Martin Rudalics <rudalics@gmx.at>
948 * window.h (window): Remove splits slot.
949 * window.c (Fwindow_splits, Fset_window_splits): Remove.
950 (Fdelete_other_windows_internal, make_parent_window)
951 (make_window, Fsplit_window_internal, Fdelete_window_internal)
952 (Fset_window_configuration, save_window_save): Don't deal with
953 split status of windows.
954 (saved_window): Remove splits slot.
955 (Vwindow_splits): Rewrite doc-string.
957 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
959 * xfns.c (unwind_create_frame):
960 * nsfns.m (unwind_create_frame):
961 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
962 Vframe_list (Bug#9999).
964 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
966 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
968 2011-11-11 Kenichi Handa <handa@m17n.org>
970 * callproc.c (Fcall_process): Set the member dst_multibyte of
973 2011-11-11 Johan Bockgård <bojohan@gnu.org>
975 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
976 avoid a crash (bug#9496).
978 2011-11-09 Chong Yidong <cyd@gnu.org>
980 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
981 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
983 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
985 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
987 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
989 Avoid some portability problems by eschewing 'extern inline' functions.
990 The trivial performance wins aren't worth the portability hassles; see
991 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
993 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
994 (window_box_width, window_box_left, window_box_left_offset)
995 (window_box_right, window_box_right_offset): Undo previous change,
996 by removing the "extern"s.
997 * intervals.c (adjust_intervals_for_insertion)
998 (adjust_intervals_for_deletion): Undo previous change,
999 making these static again.
1000 (offset_intervals, temp_set_point_both, temp_set_point)
1001 (copy_intervals_to_string): No longer inline.
1002 * xdisp.c (window_text_bottom_y, window_box_width)
1003 (window_box_height, window_box_left_offset)
1004 (window_box_right_offset, window_box_left, window_box_right)
1005 (window_box): No longer inline.
1007 2011-11-08 Chong Yidong <cyd@gnu.org>
1009 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1010 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1011 Signal an error if not a live window.
1012 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1013 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1015 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1017 * lisp.h (syms_of_abbrev): Remove declaration.
1018 Reported by CHENG Gao <chenggao@royau.me>.
1020 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1022 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1023 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1024 of temacs in GUI mode.
1026 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1028 * window.h: Declare delete_all_child_windows instead of
1029 delete_all_subwindows.
1030 * window.c (Fwindow_nest, Fset_window_nest)
1031 (Fset_window_new_total, Fset_window_new_normal)
1032 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1033 (delete_all_subwindows): Rename to delete_all_child_windows.
1034 (Fdelete_other_windows_internal, Fset_window_configuration):
1035 Call delete_all_child_windows instead of delete_all_subwindows.
1036 * frame.c (delete_frame): Call delete_all_child_windows instead
1037 of delete_all_subwindows.
1039 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1041 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1042 This is also needed for porting to any host where GC_MARK_STACK is
1043 not GC_MAKE_GCPROS_NOOPS.
1044 (which_symbols): Use it.
1046 2011-11-07 Kenichi Handa <handa@m17n.org>
1048 * coding.c (coding_set_destination): Check coding->src_pos only
1049 when coding->src_object is a buffer (bug#9910).
1051 * process.c (send_process): Set the member src_multibyte of coding
1052 to 0 (bug#9911) when sending a unibyte text.
1054 * callproc.c (Fcall_process): Set the member src_multibyte of
1055 process_coding to 0 (bug#9912).
1057 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1059 * xmenu.c (cleanup_widget_value_tree): New function.
1060 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1061 calling free_menubar_widget_value_tree directly (Bug#9830).
1063 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1065 Fix some portability problems with 'inline'.
1066 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1067 (window_box_width, window_box_left, window_box_left_offset)
1068 (window_box_right, window_box_right_offset): Declare extern.
1069 Otherwise, these inline functions do not conform to C99 and
1070 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1072 * intervals.c (adjust_intervals_for_insertion)
1073 (adjust_intervals_for_deletion): Now extern, because otherwise the
1074 extern inline functions 'offset_intervals' couldn't refer to it.
1075 (static_offset_intervals): Remove.
1076 (offset_intervals): Rewrite using the old contents of
1077 static_offset_intervals. The old version didn't conform to C99
1078 because an extern inline function contained a reference to an
1079 identifier with static linkage.
1081 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1083 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1086 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1088 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1089 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1090 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1091 return Qleft_to_right.
1093 2011-11-06 Chong Yidong <cyd@gnu.org>
1095 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1096 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1097 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1098 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1099 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1100 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1101 (Fwindow_vscroll): Doc fix.
1102 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1103 argument, since it makes no sense to pass a live window and for
1104 consistency with window-child.
1106 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1108 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1111 2011-11-05 Jason Rumney <jasonr@gnu.org>
1113 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1114 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1116 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1117 bitwise arithmetic preventing use of unicode-sip and non-truetype
1120 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1122 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1125 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1126 initialization code to keep similarity to xfns.c after changes
1129 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1131 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1132 (unwind_create_frame): New function (Bug#9943).
1133 (Fx_create_frame): Restructure code to be more similar to the one in
1134 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1135 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1136 Move terminal->reference_count++ just before making the frame official
1139 * nsterm.m (x_free_frame_resources): New function.
1140 (x_destroy_window): Move code to x_free_frame_resources.
1142 * xfns.c (unwind_create_frame): Fix comment.
1143 (Fx_create_frame, x_create_tip_frame):
1144 Move terminal->reference_count++ just before making the frame
1145 official. Move initialization of image_cache_refcount and
1146 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1148 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1150 Support MSVC build with newer versions of Visual Studio.
1151 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1152 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1155 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1156 which are not supported by MSVC.
1157 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1158 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1160 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1162 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1164 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1166 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1168 Support MSVC build with newer versions of Visual Studio.
1169 * w32.c: Don't include w32api.h for MSVC.
1170 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1172 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1173 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1174 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1175 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1177 (alloca) [_MSC_VER]: Define to _alloca.
1179 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1181 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1183 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1185 * xdisp.c (note_mouse_highlight): If either of
1186 previous/next-single-property-change returns nil, treat that as
1187 the beginning or the end of the buffer. (Bug#9955)
1189 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1191 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1192 label is not null (Bug#9951).
1193 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1196 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1198 * window.c (Fwindow_body_size): Mention in the doc string that the
1199 return value is in frame's canonical units. (Bug#9949)
1201 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1205 * w32fns.c (unwind_create_frame): If needed, free the glyph
1206 matrices of the partially constructed frame. (Bug#9943)
1207 * xfns.c (unwind_create_frame): Likewise.
1209 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1211 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1212 Don't stop backward scan on the continuation glyph, even though
1213 its CHARPOS is positive.
1214 (mouse_face_from_buffer_pos, note_mouse_highlight):
1215 Rename cover_string to disp_string.
1217 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1219 * window.c (temp_output_buffer_show): Don't use
1220 Vtemp_buffer_show_specifiers.
1221 (Vtemp_buffer_show_specifiers): Remove unused variable.
1223 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1225 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1226 past the beginning of the current glyph matrix.
1228 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1230 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1231 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1232 HAVE_GTK3 (Bug#9869).
1234 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1235 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1237 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1239 * xterm.c: Declare x_handle_net_wm_state to return int.
1240 (handle_one_xevent): Check if we are iconified but don't have
1241 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1242 (get_current_wm_state): Return non-zero if not hidden,
1243 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1244 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1245 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1246 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1248 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1250 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1251 so that this new function doesn't get optimized away by a
1252 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1254 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1256 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1258 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1260 Fix the `xbytecode' command.
1261 * .gdbinit (xprintbytestr): New command.
1262 (xwhichsymbols): Rename from `which'; all callers changed.
1263 (xbytecode): Print the byte-code string as well.
1265 2011-10-29 Kim Storm <storm@cua.dk>
1267 * alloc.c (which_symbols): New function.
1269 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1271 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1274 2011-10-29 Glenn Morris <rgm@gnu.org>
1276 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1277 Not clear what it was for, and it causes various bugs. (Bug#9839)
1279 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1281 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1282 possible random value that matches one of those tested as
1283 condition to clear the mouse face.
1285 2011-10-28 Chong Yidong <cyd@gnu.org>
1287 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1289 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1291 * window.c (make_window): Initialize phys_cursor_on_p.
1293 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1295 * lisp.h (struct Lisp_Symbol): Update comments.
1297 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1299 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1301 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1303 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1304 <oslsachem@gmail.com> for helping to debug this.
1306 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1307 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1308 (g_b_init_get_glyph_outline_w): New static variables.
1309 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1310 (GetGlyphOutlineW_Proc): New typedefs.
1311 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1312 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1314 (w32font_open_internal, compute_metrics):
1315 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1316 instead of calling the "wide" APIs directly.
1318 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1320 * w32.h (syms_of_w32font): Add prototype.
1322 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1324 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1325 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1326 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1327 (Fmove_to_window_line): Doc fix.
1329 2011-10-27 Chong Yidong <cyd@gnu.org>
1331 * process.c (make_process): Set gnutls_state to NULL.
1333 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1334 non-NULL, regardless of GNUTLS_INITSTAGE.
1335 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1336 an error. Set process slots as soon as we allocate them.
1338 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1340 2011-10-27 Chong Yidong <cyd@gnu.org>
1342 * gnutls.c (emacs_gnutls_deinit): New function.
1343 Deallocate credentials structures as well as calling gnutls_deinit.
1344 (Fgnutls_deinit, Fgnutls_boot): Use it.
1346 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1347 (deactivate_process): Call emacs_gnutls_deinit.
1349 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1351 * image.c (x_create_x_image_and_pixmap):
1352 * w32.c (sys_rename, w32_delayed_load):
1353 * w32font.c (fill_in_logfont):
1354 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1356 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1358 * w32fns.c (w32_default_color_map): New function,
1359 extracted from Fw32_default_color_map.
1360 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1362 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1364 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1366 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1368 * keyboard.c (test_undefined): New function (bug#9751).
1369 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1371 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1373 * sysdep.c (init_sys_modes): Fix the check for the controlling
1374 terminal (Bug#6649).
1376 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1378 * dispextern.h (struct bidi_it): New member next_en_type.
1380 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1381 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1382 current character, check also for next_en_type being WEAK_EN.
1383 (bidi_resolve_weak): Don't enter the expensive loop if the current
1384 position is before next_en_pos. Record the bidi type of the first
1385 non-ET, non-BN character we find, in addition to its position.
1386 (bidi_level_of_next_char): Invalidate next_en_type when
1387 next_en_pos is over-stepped.
1389 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1391 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1392 * editfns.c: Rewrite current-time-zone so that it invokes
1393 the equivalent of (format-time-string "%Z") to get the time zone name.
1394 This fixes a bug when the time zone name contains characters that
1395 need converting from the system time locale to Emacs internal format.
1396 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1397 that patch fixed format-time-string to do the conversion, but
1398 I forgot to fix current-time-zone.
1399 (format_time_string): New function, containing most of
1400 what Fformat_time_string used to contain.
1401 (Fformat_time_string): Rewrite in terms of format_time_string.
1402 This doesn't change this function's behavior.
1403 (current-time-zone): Rewrite to use format_time_string.
1404 This fixes the bug reported by Michael Schierl in
1405 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1406 Jason Rumney's 2007-06-07 change worked around this bug, but
1408 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1410 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1412 * xdisp.c (start_display): If the character at POS is displayed
1413 via a display vector, reset IT->current.dpvec_index to zero.
1414 (try_window_reusing_current_matrix): If a line ends in a display
1415 vector or the next line starts in a display vector, continue
1416 redrawing the window even though the character position of
1417 start_row was reached.
1420 2011-10-18 Chong Yidong <cyd@gnu.org>
1422 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1423 with nobreak-char-display too.
1425 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1427 Fix part 3 of bug#9771.
1428 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1429 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1430 non-neutral characters if the current character is a paragraph
1431 separator (a.k.a. Newline). This avoids running the same
1432 expensive loop twice, once when we consume the preceding newline
1433 and the other time when the line actually needs to be displayed.
1434 Avoid the loop when we see neutrals on the base embedding level
1435 following a character whose directionality is the same as the
1436 paragraph's. This avoids running the expensive loop when a line
1437 ends in a long sequence of neutrals, like control characters.
1438 Add assertion against STRONG_AL type. Slightly rearrange code
1439 that determines the type of a neutral given the first non-neutral
1441 (bidi_level_of_next_char): Set next_en_pos to zero when
1442 invalidating its info.
1444 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (push_display_prop): Determine whether to record string
1447 or buffer position by IT->string, not by IT->method. Allow
1448 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1449 (move_it_vertically_backward): Don't look for character position
1450 immediately after the newline when in a continuation line.
1453 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1455 * window.c (coordinates_in_window): Rewrite and delabelize
1456 vertical border check. (Bug#5357) (Bug#9618)
1458 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1460 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1461 errors in XSetWindowBorder (bug#9310).
1463 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1465 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1466 avoid crash when xmalloc overrun checking is enabled.
1468 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1470 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1471 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1472 cursor motion with <left> and <right> arrow keys.
1474 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1475 some callers set that themselves.
1477 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1480 display string and the previous row comes from the same string and
1481 is empty. (Bug#9739) (Bug#9738)
1483 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1485 * doc.c (get_doc_string): Encode file name (bug#9735).
1487 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1489 * bidi.c (bidi_level_of_next_char):
1490 * xdisp.c (get_visually_first_element): Remove old incorrect
1491 comments regarding the Unicode Line Separator character.
1493 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1495 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1497 * alloc.c (Fgc_status): Do not access beyond zombies array
1498 boundary if nzombies > MAX_ZOMBIES.
1499 * alloc.c (dump_zombies): Add missing format specifier.
1501 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1503 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1504 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1506 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1507 Some packages use them to denote characters with modifiers.
1509 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1511 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1512 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1513 matching a pp-number. Rename parameter var to var1.
1515 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1517 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1519 2011-10-08 Glenn Morris <rgm@gnu.org>
1521 * callint.c (Fcall_interactively): Give a more explicit error for the
1522 'c' case with a non-character input. (Bug#8479)
1524 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1528 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1529 lines that are hscrolled on the left.
1531 * dispnew.c (buffer_posn_from_coords): Account for a possible
1532 presence of header-line. (Bug#4426)
1534 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1536 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1537 Don't advertise functionality which we discourage or doesn't work.
1539 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1541 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1542 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1543 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1544 this makes Emacs dump core during garbage collection on rare
1545 occasions. sizeof is obviously inferior to offsetof here, so
1546 stick with offsetof.
1547 (GC_POINTER_ALIGNMENT): New macro.
1548 (mark_memory): Omit 3rd (offset) arg; caller changed.
1549 Don't assume EMACS_INT alignment is the same as pointer alignment.
1551 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1553 * keyboard.c (read_key_sequence_remapped): New var.
1554 (read_key_sequence): Compute remapping in the right buffer.
1555 (command_loop_1): Use read_key_sequence's remapping directly.
1557 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1559 * dired.c (file_name_completion): Don't expand file name.
1560 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1561 before checking file name handler.
1563 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1564 they've been requested explicitly (bug#9591).
1566 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1568 * keymap.c (Fsingle_key_description): Use make_specified_string
1569 instead of build_string to build string from push_key_description.
1572 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1574 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1575 This fixes a Y2038 bug on 64-bit hosts.
1576 * buffer.c (reset_buffer):
1577 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1578 (Fclear_buffer_auto_save_failure):
1579 Use 0, not -1, to represent an unset failure time, since time_t
1580 might not be signed.
1582 Remove dependency on glibc malloc internals.
1583 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1584 Move back here from lisp.h, but with their new implementations.
1585 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1586 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1587 * charset.c (charset_table_init): New static var.
1588 (syms_of_charset): Use it instead of xmalloc. This removes a
1589 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1590 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1591 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1592 Move back to alloc.c.
1593 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1594 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1596 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1598 * nsterm.m (windowDidResize): Call x_set_window_size only when
1599 ns_in_resize is true. Otherwise set pixelwidth/height and
1600 call change_frame_size (Bug#9628).
1602 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1604 Port --enable-checking=all to Fedora 14 x86-64.
1605 * charset.c (syms_of_charset): Also account for glibc malloc's
1606 internal overhead when calculating the initial malloc maximum.
1608 Port --enable-checking=all to Fedora 14 x86.
1609 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1611 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1612 (overrun_check_realloc, overrun_check_free):
1613 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1614 That way, xmalloc returns a properly-aligned pointer even if
1615 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1616 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1617 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1618 into account when calculating the initial malloc maximum.
1619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1620 Move here from alloc.c, so that charset.c can use it too.
1621 Properly align; the old code wasn't right for common 32-bit hosts
1622 when configured with --enable-checking=all.
1623 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1624 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1626 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1628 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1631 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1633 * xdisp.c (compute_display_string_end): If there's no display
1634 string at CHARPOS, return -1.
1636 * bidi.c (bidi_fetch_char): When compute_display_string_end
1637 returns a negative value, treat the character as a normal
1638 character not covered by a display string. (Bug#9624)
1640 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1642 * lread.c (Fread_from_string): Fix typo in docstring.
1644 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1646 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1647 newline, reseat the iterator instead of bidi-iterating there one
1648 character at a time. (Bug#9610)
1649 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1650 TO_CHARPOS if the bidi iterator is at base embedding level.
1652 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1654 * lread.c (readevalloop): Use correct code for NBSP.
1655 (read1): Likewise. (Bug#9608)
1657 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1659 * dbusbind.c (Fdbus_register_signal): When service is not
1660 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1662 2011-09-25 Glenn Morris <rgm@gnu.org>
1664 * buffer.c (truncate-lines): Doc fix.
1666 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1668 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1669 (Fset_window_next_buffers): Doc fix.
1671 2011-09-24 Glenn Morris <rgm@gnu.org>
1673 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1675 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1677 Fix minor problems found by static checking.
1678 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1679 * indent.c (Fvertical_motion): Fix == vs = typo.
1681 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1683 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1684 Default value is now t. Doc fix.
1686 * indent.c (Fvertical_motion): Compute and apply the overshoot
1687 logic when moving up, not only when moving down. Fix the
1688 confusing name and values of the it_overshoot_expected variable;
1689 logic changes accordingly. (Bug#9254) (Bug#9549)
1691 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1692 CHARPOS is covered by a display string which includes newlines.
1693 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1694 is covered by a display string with embedded newlines.
1696 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1698 * dbusbind.c (Fdbus_register_signal): Add match rule to
1699 Vdbus_registered_objects_table. (Bug#9581)
1700 (Fdbus_register_method, Vdbus_registered_objects_table):
1703 2011-09-24 Jim Meyering <meyering@redhat.com>
1705 do not ignore write error for any output size
1706 The previous change was incomplete.
1707 While it makes emacs --batch detect the vast majority of stdout
1708 write failures, errors were still ignored whenever the output size is
1709 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1710 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1711 && echo FAIL: ignored write error
1712 FAIL: ignored write error
1713 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1714 && echo FAIL: ignored write error
1715 FAIL: ignored write error
1716 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1718 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1720 * emacs.c (Fkill_emacs): In noninteractive mode exit
1721 non-successfully if a write error occurred on stdout. (Bug#9574)
1723 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1725 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1728 * dispextern.h (struct it): Update the comment documenting what
1731 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1734 a display string, extend search for cursor position to end of row.
1735 (find_row_edges): If the row ends in a newline from a display
1736 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1737 Handle the case of a display string with multiple newlines.
1738 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1739 non-empty line. Fixes confusing cursor motion with arrow keys at
1740 the beginning of a line that starts with whitespace.
1742 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1744 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1747 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1749 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1752 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1754 * xdisp.c (display_line): Record maximum and minimum buffer
1755 positions even if no glyphs were produced (e.g., by a zero-width
1756 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1757 buffer positions that will be removed from the glyph row because
1759 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1760 column is beyond frame width: don't subtract 1 "pixel" when
1761 computing width of the stretch.
1762 (reseat_at_next_visible_line_start): Undo the change made on
1763 2011-09-17 that saved paragraph information and restored it after
1764 the call to `reseat'. (Bug#9545)
1766 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1768 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1769 and turn window cursor on if cleared (Bug#9415).
1771 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1773 * search.c (boyer_moore): Take unibyte characters from pattern
1774 literally. (Bug#9458)
1776 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1778 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1780 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1782 Fix minor problem found by static checking.
1783 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1784 initialized, to pacify gcc -Wuninitialized.
1786 * fileio.c: Report proper errno when syscall falls.
1787 (Finsert_file_contents): Save and restore errno,
1788 so that report_file_error outputs the correct diagnostic.
1789 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1791 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1793 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1795 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1797 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1798 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1800 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1802 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1803 about the current paragraph and restore it after the call to reseat.
1805 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1806 (bidi_find_paragraph_start): Search back for paragraph beginning
1807 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1808 (bidi_move_to_visually_next): Only trigger paragraph-related
1809 computations when the last character is a newline or at EOB, not
1810 just any NEUTRAL_B. (Bug#9470)
1812 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1813 truncated lines if point is covered by a display string. (Bug#9524)
1815 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1817 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1818 (cons_to_x_long): New function.
1819 (lisp_data_to_selection_data): Use it. Correct the test for
1820 short-versus-long data; it was negated. Break out of vector
1821 loop, for efficiency, when a long datum is discovered.
1823 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1825 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1827 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1829 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1830 GCC PR/17406) by declaring this function with external scope.
1832 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1834 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1835 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1837 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1839 * editfns.c (Fformat): Correctly handle text properties on "%%".
1841 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1843 * xterm.c (x_draw_composite_glyph_string_foreground):
1844 * w32term.c (x_draw_composite_glyph_string_foreground):
1845 * term.c (encode_terminal_code):
1846 * composite.c (composition_update_it, get_composition_id):
1847 * xdisp.c (get_next_display_element)
1848 (fill_composite_glyph_string): Add comments about special meaning
1849 of TAB characters in a composition.
1851 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1853 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1854 This occurs when processing a multibyte format.
1855 Problem reported by Wolfgang Jenker.
1857 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1859 * xdisp.c (try_cursor_movement): Only check for exact match if
1860 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1862 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1864 Remove unused external symbols.
1865 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1866 * xdisp.c (calc_pixel_width_or_height): Now static.
1867 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1868 * indent.c (check_display_width):
1869 * w32term.c: Fix comment to match code.
1870 * xterm.c, xterm.h (x_catching_errors): Remove.
1872 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1874 * xselect.c: Use signed conversions more consistently (Bug#9498).
1875 (selection_data_to_lisp_data): Assume incoming selection data are
1876 signed integers, not unsigned. This is to be consistent with
1877 outgoing selection data, which was modified to use signed integers
1878 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1879 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1880 expects long, not unsigned long.
1882 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1885 computation of loop end. Reported by Johan Bockgård
1888 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1890 * frame.c (Fother_visible_frames_p): Function deleted.
1892 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1894 * indent.c (compute_motion): Process display vector front to back
1895 rather than the other way around. (Bug#2496)
1897 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1899 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1901 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1903 * minibuf.c (Fread_from_minibuffer): Doc fix.
1905 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1907 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1908 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1910 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1912 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1913 value for non-existent files.
1915 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1917 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1918 set its "size" to -1. This will set the modtime_size field of
1919 the corresponding buffer to -1, which is what
1920 verify-visited-file-modtime expects for files that do not exist.
1923 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1925 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1927 * lisp.h: ... from here. push_key_description is no longer
1928 defined in keyboard.c, so its declaration should not be in
1929 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1930 logically belongs with push_key_description.
1932 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1934 * buffer.h: Include <sys/types.h> instead of <time.h>.
1935 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1936 Problem reported by Herbert J. Skuhra.
1938 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940 * xml.c (parse_region): Make the parsing work for
1941 non-comment-starting XML files again (bug#9144).
1943 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1945 * image.c (gif_load): Fix calculation of bottom and right corner.
1948 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1950 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1951 redisplay in small windows.
1953 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1955 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1957 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1959 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1960 Operate on live windows only.
1962 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1964 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1966 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1968 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1969 only under bidi iteration.
1971 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1973 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1975 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1977 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1978 Without this fix, the command to link temacs failed due to an
1979 undefined symbol __builtin_isnan. This is because
1980 /usr/include/iso/math_c99.h #defines isnan(x) to
1981 __builtin_isnan(x), but the bundled gcc, which identifies itself
1982 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1984 * floatfns.c (isnan): #undef, and then #define to a clone of
1986 (Fisnan): Always define, since it's always available now.
1987 (syms_of_floatfns): Always define isnan at the Lisp level.
1989 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1991 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1993 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1995 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1996 The previous code assumed that file offsets (off_t values) fit in
1997 EMACS_INT variables, which is not true on typical 32-bit hosts.
1998 The code messed up by falsely reporting buffer overflow in cases
1999 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2000 when "big" contains more than 2**29 bytes, even though this
2001 inserts just one byte and does not overflow the buffer.
2002 (Finsert_file_contents): Store file offsets as off_t
2003 values, not as EMACS_INT values. Check for overflow when
2004 converting between EMACS_INT and off_t. When checking for
2005 buffer overflow or for overlap, take the offsets into account.
2006 Don't use EMACS_INT for small values where int suffices.
2007 When checking for overlap, fix a typo: ZV was used where
2008 ZV_BYTE was intended.
2009 (Fwrite_region): Don't assume off_t fits into 'long'.
2010 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2012 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2014 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2016 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2018 sprintf-related integer and memory overflow issues (Bug#9412).
2020 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2021 (esprintf, exprintf, evxprintf): New functions.
2022 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2023 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2024 (modify_event_symbol): Do not assume that the length of
2025 name_alist_or_stem is safe to alloca and fits in int.
2026 (Fexecute_extended_command): Likewise for function name and binding.
2027 (Frecursion_depth): Wrap around reliably on integer overflow.
2028 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2029 since some callers pass EMACS_INT values.
2030 (Fsingle_key_description): Don't crash if symbol name contains more
2031 than MAX_ALLOCA bytes.
2032 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2033 (get_minibuffer): Arg is now EMACS_INT, not int.
2034 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2035 (esprintf, exprintf, evxprintf): New decls.
2036 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2038 * dbusbind.c (signature_cat): New function.
2039 (xd_signature, Fdbus_register_signal):
2040 Do not overrun buffer; instead, report string overflow.
2042 * dispnew.c (add_window_display_history): Don't overrun buffer.
2043 Truncate instead; this is OK since it's just a log.
2045 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2046 even if the time zone offset is outlandishly large.
2047 Don't mishandle offset == INT_MIN.
2049 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2050 when creating daemon; the previous buffer-overflow check was incorrect.
2052 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2053 which has the guts of the old verror function.
2055 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2056 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2058 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2059 (font_unparse_xlfd): Don't blindly alloca long strings.
2060 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2061 fits in int, when using sprintf. Use single snprintf to count
2062 length of string rather than counting it via multiple sprintfs;
2063 that's simpler and more reliable.
2064 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2065 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2066 sprintf, in case result does not fit in int.
2068 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2069 (fontset_from_font): Print it.
2071 * frame.c (tty_frame_count): Now printmax_t, not int.
2072 (make_terminal_frame, set_term_frame_name): Print it.
2073 (x_report_frame_params): In X, window IDs are unsigned long,
2074 not signed long, so print them as unsigned.
2075 (validate_x_resource_name): Check for implausibly long names,
2076 and don't assume name length fits in 'int'.
2077 (x_get_resource_string): Don't blindly alloca invocation name;
2078 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2081 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2082 (xg_check_special_colors, xg_set_geometry):
2083 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2085 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2086 Use esprintf, not sprintf, in case result does not fit in int.
2088 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2089 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2090 it as a large positive number.
2091 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2092 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2094 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2095 in case result does not fit in int.
2097 * print.c (float_to_string): Detect width overflow more reliably.
2098 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2099 buffer overrun. Don't assume list length fits in 'int'. Treat
2100 print length of 0 as 0, not as infinity; to be consistent with other
2101 uses of print length in this function. Don't overflow print length
2102 index. Don't assume hash table size fits in 'long', or that
2103 vectorlike size fits in 'unsigned long'.
2105 * process.c (make_process): Use printmax_t, not int, to format
2106 process-name gensyms.
2108 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2110 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2111 to avoid potential buffer overrun.
2113 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2114 if X resource line is longer than 512 bytes.
2116 * xfns.c (x_window): Make sprintf buffer a bit bigger
2117 to avoid potential buffer overrun.
2119 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2121 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2123 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2125 Integer overflow fixes for scrolling, etc.
2126 Without these, Emacs silently mishandles large integers sometimes.
2127 For example, "C-u 4294967297 M-x recenter" was treated as if
2128 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2130 * xdisp.c (try_window_id): Check Emacs fixnum range before
2131 converting to 'int'.
2133 * window.c (window_scroll_line_based, Frecenter):
2134 Check that an Emacs fixnum is in range before assigning it to 'int'.
2135 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2136 values converted from Emacs fixnums.
2137 (Frecenter): Don't wrap around a line count if it is out of 'int'
2138 range; instead, treat it as an extreme value.
2139 (Fset_window_configuration, compare_window_configurations):
2140 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2142 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2143 that can exceed INT_MAX. Check that EMACS_INT value is in range
2144 before assigning it to the (possibly-narrower) index.
2145 (match_limit): Don't assume that a fixnum can fit in 'int'.
2147 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2150 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2151 (Fvertical_motion): Don't wrap around LINES values that don't fit
2152 in 'int'. Instead, treat them as extreme values. This is good
2153 enough for windows, which can't have more than INT_MAX lines anyway.
2155 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2157 * Require libxml/parser.h to avoid compilation warning.
2159 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2161 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2162 since this reportedly can destroy thread storage.
2164 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2166 * syntax.c (find_defun_start): Update all cache variables if
2167 exiting early (Bug#9401).
2169 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2171 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2173 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2174 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2175 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2177 * term.c (tty_append_glyph): New function.
2178 (produce_stretch_glyph): Static function and its prototype deleted.
2180 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2183 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2185 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2186 when checking :margin (Bug#9390).
2187 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2188 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2189 so that the name doesn't mislead. All uses changed.
2191 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2193 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2196 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2198 * xdisp.c (move_it_to): Don't bail out early when reaching
2199 position beyond to_charpos, if we are scanning backwards.
2200 (move_it_vertically_backward): When DY == 0, make sure we get to
2201 the first character in the line after the newline.
2203 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2205 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2206 (ccl_driver): Do not generate an out-of-range pointer.
2207 (Fccl_execute_on_string): Remove unnecessary check for
2208 integer overflow, noted by Stefan Monnier in
2209 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2210 Remove a FIXME that didn't need fixing.
2211 Simplify the newly-introduced buffer reallocation code.
2213 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2215 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2217 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2219 Integer and memory overflow issues (Bug#9196).
2221 * doc.c (get_doc_string): Rework so that
2222 get_doc_string_buffer_size is the actual buffer size, rather than
2223 being 1 less than the actual buffer size; this makes xpalloc more
2226 * image.c (x_allocate_bitmap_record, cache_image):
2227 * xselect.c (Fx_register_dnd_atom):
2228 Simplify previous changes by using xpalloc.
2230 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2231 since either will do and ptrdiff_t is convenient with xpalloc.
2233 * charset.c (charset_table_size)
2234 (struct charset_sort_data.priority): Now ptrdiff_t.
2235 (charset_compare): Don't overflow if priorities differ greatly.
2236 (Fsort_charsets): Don't assume list length fits in int.
2237 Check for size-calculation overflow when allocating sort data.
2238 (syms_of_charset): Allocate an initial charset table that is
2239 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2241 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2243 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2244 The actual value is always <= INT_MAX, and leaving it unsigned made
2245 overflow checking harder.
2247 * dispextern.h (struct glyph_matrix.rows_allocated)
2248 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2249 with xpalloc. The values are still always <= INT_MAX.
2251 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2253 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2254 (SAFE_NALLOCA): New macro.
2256 * region-cache.c (struct boundary.pos, find_cache_boundary)
2257 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2258 (set_cache_region, invalidate_region_cache)
2259 (revalidate_region_cache, know_region_cache, region_cache_forward)
2260 (region_cache_backward, pp_cache):
2261 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2262 so that ptrdiff_t * can be passed to xpalloc.
2263 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2264 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2265 (pp_cache): Don't assume cache_len fits in int.
2266 * region-cache.h: Adjust extern decls to match.
2268 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2269 EMACS_INT, since either will do, for xpalloc.
2271 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2272 (xnmalloc, xnrealloc, xpalloc): New functions.
2274 * bidi.c (bidi_shelve_header_size): New constant.
2275 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2276 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2278 * bidi.c (bidi_cache_shrink):
2279 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2281 Don't update size of array until after memory allocation succeeds,
2282 because xmalloc/xrealloc may not return.
2283 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2284 now that we have proper integer overflow checking.
2285 (record_overlay_string, overlay_strings): Catch overflows when
2286 calculating size of overlay_str_buf.
2288 * callproc.c (Fcall_process): Check for size overflow when
2289 calculating size of args2.
2290 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2291 Normally we prefer signed values, but sticking with ptrdiff_t would
2292 require adding more-complicated checks.
2294 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2295 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2296 Redo buffer-overflow calculations to avoid integer overflow.
2297 Add a FIXME comment where memory seems to be over-allocated.
2299 * character.c (Fstring): Check for size-calculation overflow.
2301 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2302 unnecessary integer overflow. Check for size overflow.
2303 (encode_coding_object): Don't update size until xmalloc succeeds.
2305 * composite.c (get_composition_id): Check for overflow in glyph
2306 length calculations.
2308 Integer and memory overflow fixes for display code.
2309 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2310 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2311 (scrolling_window): Check for overflow in size calculations.
2312 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2313 Don't assume glyph table len fits in int.
2314 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2315 (row_table_size): Now ptrdiff_t, not int.
2316 (scrolling_window): Avoid overflow in size calculations.
2317 Don't update size until allocation succeeds.
2318 * fns.c (concat): Check for overflow in size calculations.
2319 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2320 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2321 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2323 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2324 (get_doc_string): Check for size calculation overflow.
2325 Don't update size until allocation succeeds.
2326 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2327 EMACS_INT, where ptrdiff_t will do.
2328 (Fsubstitute_command_keys): Check for string overflow.
2330 * editfns.c (set_time_zone_rule): Don't assume environment length
2332 (message_length): Now ptrdiff_t, not int.
2333 (Fmessage_box): Don't update size until allocation succeeds.
2334 Don't assume message length fits in int.
2335 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2337 * emacs.c (main): Do not reallocate argv, since there is a null at
2338 the end that can be overwritten, and this way there's no need to
2339 worry about size-calculation overflow.
2340 (sort_args): Check for size-calculation overflow.
2342 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2344 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2346 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2347 (x_set_scroll_bar_width, x_figure_window_size):
2348 Check for integer overflow.
2349 (x_set_alpha): Do not assume XINT fits in int.
2351 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2352 This is for the members text_lines, text_cols, total_lines, total_cols,
2353 where the system imposes an 'int' limit.
2355 * fringe.c (Fdefine_fringe_bitmap):
2356 Don't update size until alloc works.
2358 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2359 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2361 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2362 Check for size-calculation overflow.
2363 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2364 do, as we prefer signed integers.
2365 (id_to_widget.max_size, id_to_widget.used)
2366 (xg_store_widget_in_map, xg_remove_widget_from_map)
2367 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2368 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2369 Use and return ptrdiff_t, not int.
2370 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2371 * gtkutil.h: Change prototypes to match the above.
2373 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2374 are duplicate now that they've been promoted to lisp.h.
2375 (x_allocate_bitmap_record, x_alloc_image_color)
2376 (make_image_cache, cache_image, xpm_load):
2377 Don't update size until alloc is done.
2378 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2380 Check for size calculation overflow.
2381 (ct_colors_allocated_max): New constant.
2382 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2385 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2386 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2387 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2388 Use ptrdiff_t, not int, to count maps.
2389 (read_char_minibuf_menu_prompt): Check for overflow in size
2390 calculations. Don't update size until allocation succeeds.
2391 Redo calculations to avoid overflow.
2392 * keyboard.h: Change prototypes to match the above.
2394 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2396 (current_minor_maps): Check for size calculation overflow.
2397 * keymap.h: Change prototypes to match the above.
2399 * lread.c (read1, init_obarray): Don't update size until alloc done.
2401 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2402 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2404 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2405 Now ptrdiff_t, not int.
2406 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2407 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2409 * process.c (Fnetwork_interface_list): Check for overflow
2410 in size calculation.
2412 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2414 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2415 overflow. Don't bother calling xmalloc when xrealloc will do.
2417 * search.c (Freplace_match): Check for size calculation overflow.
2418 (Fset_match_data): Don't assume list lengths fit in 'int'.
2420 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2421 for command line length. Do not attempt to address one before the
2422 beginning of an array, as that's not portable.
2424 * term.c (max_frame_lines): Remove; unused.
2425 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2427 (encode_terminal_code, calculate_costs): Check for size
2428 calculation overflow.
2429 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2430 table lengths and related sizes. Don't update size until alloc
2431 done. Redo calculations to avoid overflow.
2432 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2434 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2435 subtracting pointers.
2436 (gobble_line): Check for overflow more carefully. Don't update size
2439 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2440 Don't update size until alloc done.
2441 Redo size calculations to avoid overflow.
2442 Check for size calculation overflow.
2443 (main) [DEBUG]: Fix typo in invoking tparam1.
2445 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2446 Use ptrdiff_t, not int, for sizes.
2447 (store_mode_line_noprop_char): Don't update size until alloc done.
2449 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2450 Use ptrdiff_t, not int, for sizes.
2451 (Finternal_make_lisp_face, cache_face):
2452 Check for size calculation overflow.
2453 (cache_face): Treat size calculation overflows as if they were
2454 memory exhaustion (the usual treatment), rather than aborting.
2456 * xfns.c (x_encode_text, x_set_name_internal)
2457 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2458 sizes, since they can exceed INT_MAX in size. Check for size
2459 calculation overflow.
2461 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2462 (xg_select): Check for size calculation overflow.
2463 Don't update size until alloc done.
2465 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2466 as sprintf is limited to int lengths.
2468 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2469 (X_LONG_MIN): New macros.
2470 Use them to make the following changes clearer.
2471 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2472 This change doesn't affect the value now, but it may help remind
2473 future maintainers not to raise the value too much later.
2474 (SELECTION_QUANTUM): Remove, replacing with ...
2475 (selection_quantum): ... new function, which avoids overflow.
2477 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2478 assumption that selection length fits in 'int'.
2479 (x_reply_selection_request, x_handle_selection_request)
2480 (x_get_window_property, receive_incremental_selection)
2481 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2482 (lisp_data_to_selection_data, clean_local_selection_data):
2483 Use ptrdiff_t, not int, to record length of selection.
2484 (x_reply_selection_request, x_get_window_property)
2485 (receive_incremental_selection, x_property_data_to_lisp):
2486 Redo calculations to avoid overflow.
2487 (x_reply_selection_request): When sending hint, ceiling it at
2488 X_LONG_MAX rather than relying on wraparound overflow to send
2490 (x_get_window_property, receive_incremental_selection)
2491 (lisp_data_to_selection_data, x_property_data_to_lisp):
2492 Check for size-calculation overflow.
2493 (x_get_window_property, receive_incremental_selection)
2494 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2495 Don't store size until memory allocation succeeds.
2496 (x_get_window_property): Plug memory leak on memory exhaustion.
2497 Don't double-block input; malloc is safe here. Don't assume 2**34
2498 - 4 fits in unsigned long. Add an xassert to check
2499 XGetWindowProperty overflow. Be more careful about overflow
2500 calculations, and distinguish size from memory overflow better.
2501 (receive_incremental_selection): When tracing, don't assume
2502 unsigned int is less than INT_MAX.
2503 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2504 harmful) conversions of unsigned short to int.
2505 (lisp_data_to_selection_data): Don't assume that integers
2506 in the range -65535 through -1 fit in an X unsigned short.
2507 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2508 result parameters unless successful. Rely on cons_to_unsigned
2509 to report problems with elements; the old code wasn't right anyway.
2510 (x_check_property_data): Check for int overflow; we cannot use
2511 a wider type due to X limits.
2512 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2514 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2516 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2517 (x_term_init): Check for size calculation overflow.
2518 (x_color_cells): Don't store size until memory allocation succeeds.
2519 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2520 Don't assume alloca size is less than MAX_ALLOCA.
2521 (x_term_init): Don't assume length fits in int (sprintf is limited
2524 Use ptrdiff_t for composition IDs.
2525 * character.c (lisp_string_width):
2526 * composite.c (composition_table_size, n_compositions)
2527 (get_composition_id, composition_gstring_from_id):
2528 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2529 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2530 * window.c (Frecenter):
2531 Use ptrdiff_t, not int, for composition IDs.
2532 * composite.c (get_composition_id): Check for integer overflow.
2533 * composite.h: Adjust prototypes to match the above changes.
2535 Use ptrdiff_t for hash table indexes.
2536 * category.c (hash_get_category_set):
2537 * ccl.c (ccl_driver):
2538 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2539 * coding.c (coding_system_charset_list, detect_coding_system):
2540 * coding.h (struct coding_system.id):
2541 * composite.c (get_composition_id, gstring_lookup_cache):
2542 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2543 * image.c (xpm_get_color_table_h):
2544 * lisp.h (hash_lookup, hash_put):
2545 * minibuf.c (Ftest_completion):
2546 Use ptrdiff_t for hash table indexes, not int (which is too
2547 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2548 32-bit --with-wide-int hosts).
2550 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2551 Add a FIXME comment about memory leaks.
2552 (syms_of_charset): Don't assume xmalloc returns.
2554 Don't assume that stated character widths fit in int.
2555 * character.c (Fchar_width, c_string_width, lisp_string_width):
2556 * character.h (CHAR_WIDTH):
2557 * indent.c (MULTIBYTE_BYTES_WIDTH):
2558 Use sanitize_char_width to avoid undefined and/or bad behavior
2559 with outlandish widths.
2560 * character.h (sanitize_tab_width): Rename from sanitize_width,
2561 now that we have two such functions. All uses changed.
2562 (sanitize_char_width): New inline function.
2564 Don't assume that tab-width fits in int.
2565 * character.h (sanitize_width): New inline function.
2566 (SANE_TAB_WIDTH): New macro.
2567 (ASCII_CHAR_WIDTH): Use it.
2568 * indent.c (sane_tab_width): Remove. All uses replaced by
2569 SANE_TAB_WIDTH (current_buffer).
2570 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2572 * fileio.c: Integer overflow issues with file modes.
2573 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2575 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2576 Remove unreachable code.
2577 (read_hex, load_charset_map_from_file): Check for integer overflow.
2579 * xterm.c: Don't go over XClientMessageEvent limit.
2580 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2581 (x_send_scroll_bar_event): Likewise. Check that the size does not
2582 exceed limits imposed by XClientMessageEvent, as well as the usual
2583 ptrdiff_t and size_t limits.
2585 * keyboard.c: Overflow, signedness and related fixes.
2586 (make_lispy_movement): Use same integer type in forward decl
2587 that is used in the definition.
2588 (read_key_sequence, keyremap_step):
2589 Change bufsize argument back to int, undoing my 2011-03-30 change.
2590 We prefer signed types, and int is wide enough here.
2591 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2592 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2593 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2594 length, not size_t. Use ptrdiff_t for index, not int.
2595 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2596 possibility of integer overflow.
2598 Overflow, signedness and related fixes for images.
2600 * dispextern.h (struct it.stack[0].u.image.image_id)
2601 (struct_it.image_id, struct image.id, struct image_cache.size)
2602 (struct image_cache.used, struct image_cache.ref_count):
2603 * gtkutil.c (update_frame_tool_bar):
2604 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2605 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2606 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2607 * nsmenu.m (update_frame_tool_bar):
2608 * xdisp.c (calc_pixel_width_or_height):
2609 * xfns.c (image_cache_refcount):
2610 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2611 on typical 64-bit hosts.
2613 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2614 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2615 Omit unnecessary casts to int.
2616 (parse_image_spec): Check that integers fall into 'int' range
2617 when the callers expect that.
2618 (image_ascent): Redo ascent calculation to avoid int overflow.
2619 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2620 (lookup_image): Remove unnecessary tests.
2621 (xbm_image_p): Locals are now of int, not EMACS_INT,
2622 since parse_image_check makes sure they fit into int.
2623 (png_load, gif_load, svg_load_image):
2624 Prefer int to unsigned where either will do.
2625 (tiff_handler): New function, combining the cores of the
2626 old tiff_error_handler and tiff_warning_handler.
2627 This function is rewritten to use vsnprintf and thereby avoid
2628 stack buffer overflows. It uses only the features of vsnprintf
2629 that are common to both POSIX and native Microsoft.
2630 (tiff_error_handler, tiff_warning_handler): Use it.
2631 (tiff_load, gif_load, imagemagick_load_image):
2632 Don't assume :index value fits in 'int'.
2633 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2634 (imagemagick_load_image): Check that crop parameters fit into
2635 the integer types that MagickCropImage accepts. Don't assume
2636 Vimagemagick_render_type has a nonnegative value. Don't assume
2637 size_t fits in 'long'.
2638 (gs_load): Use printmax_t to print the widest integers possible.
2639 Check for integer overflow when computing image height and width.
2641 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2643 * xdisp.c (redisplay_window): Don't force window start if point
2644 will be invisible in the resulting window. (Bug#9324)
2646 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2648 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2649 the display spec is of the form `(space ...)'.
2650 (handle_display_spec): Return the value returned by
2651 handle_single_display_spec, not just 1 or zero.
2652 (handle_single_display_spec): If the display spec is of the form
2653 `(space ...)', and specifies display in the text area, return 2
2655 (try_cursor_movement): Check for the need to scroll more
2656 accurately, and prefer exact match for point under bidi.
2657 Don't advance `row' beyond the last row of the window.
2659 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2660 into disp_prop; all users changed.
2662 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2663 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2664 for the text covered by the display property.
2666 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2668 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2669 Change return value to nil.
2670 (Frecord_buffer): Delete unused function.
2672 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2674 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2675 buffers, return left-to-right.
2676 (set_cursor_from_row): Consider candidate row a win if its glyph
2677 represents a newline and point is on that newline. Fixes cursor
2678 positioning on the newline at EOL of R2L text within L2R
2679 paragraph, and vice versa.
2680 (try_cursor_movement): Check continued rows, in addition to
2681 continuation rows. Fixes unwarranted scroll when point enters a
2682 continued line of R2L text within an L2R paragraph, or vice versa.
2683 (cursor_row_p): Consider the case of point being equal to
2684 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2685 from the end of a short line to the beginning of a continued line
2686 of R2L text within L2R paragraph.
2687 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2688 composed characters.
2690 * bidi.c (bidi_check_type): Use xassert.
2691 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2694 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2696 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2699 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2701 * nsfont.m (ns_otf_to_script): Fix typo.
2703 2011-08-22 Kenichi Handa <handa@m17n.org>
2705 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2706 extra slot even if the purpose is char-code-property-table.
2708 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2710 * xdisp.c (redisplay_window): When computing centering_position,
2711 account for the height of the header line. (Bug#8874)
2713 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2714 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2715 candidate is selected by the mouse, and that candidate has a
2716 composed character under the mouse.
2718 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2719 coordinates reported by pos-visible-in-window-p for a composed
2720 character in column zero.
2722 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2724 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2726 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2728 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2729 consider it a hit if to_charpos is anywhere in the range of the
2730 composed buffer positions.
2732 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2734 * image.c (gif_load): Don't assume that each subimage has the same
2735 dimensions as the base image. Handle disposal method that is
2736 "undefined" by the gif spec (Bug#9335).
2738 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2740 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2741 (Fcondition_case): Document `debug' symbol in error handler.
2743 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2745 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2746 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2747 from an Org mode buffer to a Speedbar frame.
2749 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2750 a composition, take its buffer position from IT->cmp_it.charpos.
2751 Fixes cursor positioning at the beginning of a line that begins
2752 with a composed character.
2754 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2756 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2757 character bidirectional type, use STRONG_L instead. Fixes crashes
2758 in a buffer produced by `describe-categories'.
2760 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2761 members before the level stack, so they would be saved and
2762 restored when copying iterator state. Fixes incorrect reordering
2763 around TABs covered by display properties.
2765 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2767 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2769 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2771 * eval.c (internal_condition_case, internal_condition_case_1)
2772 (internal_condition_case_2, internal_condition_case_n):
2773 Remove unnecessary aborts (Bug#9081).
2775 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2777 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2778 has no `load' handler, try opening the file locally. (Bug#9311)
2780 2011-08-16 Ken Brown <kbrown@cornell.edu>
2782 * gmalloc.c: Expand comment.
2784 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2786 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2787 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2789 2011-08-16 Ken Brown <kbrown@cornell.edu>
2791 Fix memory allocation problems in Cygwin build (Bug#9273).
2793 * unexcw.c ( __malloc_initialized): Declare external variable.
2794 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2796 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2798 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2800 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2802 [CYGWIN] (special_realloc): New function.
2803 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2804 requests to realloc storage in the static heap.
2806 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2808 * bidi.c (bidi_initialize): Remove unused local.
2810 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2813 * biditype.h: Remove file.
2814 * makefile.w32-in ($(BLD)/bidi.$(O)):
2815 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2817 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2819 * chartab.c: Improve commentary for the uniprop_table API.
2821 * bidi.c (bidi_paragraph_init): Support zero value of
2822 bidi_ignore_explicit_marks_for_paragraph_level.
2823 (bidi_initialize): Use uniprop_table instead of including
2824 biditype.h and bidimirror.h.
2826 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2827 coordinates of the iterator when restoring from ppos_it.
2830 2011-08-14 Kenichi Handa <handa@m17n.org>
2832 * process.c (create_process): Call setup_process_coding_systems
2833 after the pid of the process is set to -1 (Bug#8162).
2835 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2837 * xdisp.c (move_it_in_display_line_to): Don't invoke
2838 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2839 ppos_it. Fixes vertical cursor motion when line beginning is
2840 covered by an image. (Bug#9296)
2842 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2844 * nsterm.h (ns_run_ascript): Declare.
2845 (NSAPP_DATA2_RUNASSCRIPT): Define.
2847 * nsfns.m (as_script, as_result, as_status): New static variables.
2848 (ns_run_ascript): New function.
2849 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2850 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2851 the event loop. Get status from as_status (Bug#7276).
2853 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2854 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2855 the event loop (Bug#7276).
2857 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2859 * gnutls.c (QCgnutls_bootprop_priority)
2860 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2861 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2862 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2863 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2864 (QCgnutls_bootprop_verify_hostname_error)
2865 (QCgnutls_bootprop_callbacks_verify): Rename from
2866 Qgnutls_bootprop_..., all uses changed.
2868 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2871 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2873 * xfaces.c (Qframe_set_background_mode): Now static.
2874 * dispextern.h (Qframe_set_background_mode): Remove decl.
2876 * process.c (Fnetwork_interface_info): Declare local only if needed.
2878 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2880 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2881 (Fnetwork_interface_list): Allocate in increments of bytes instead
2882 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2883 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2885 (struct ifflag_def): notrailers is smart on OSX.
2886 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2887 Get hardware address with getifaddrs if available.
2889 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2891 * xdisp.c (iterate_out_of_display_property): xassert that
2892 IT->position is set to within IT->object's boundaries. Break from
2893 the loop as soon as EOB is reached; avoids infloops in redisplay
2894 when IT->position is set up wrongly due to some bug.
2895 Set IT->current to match the bidi iterator unconditionally.
2896 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2897 entry. Force push_it to save on the stack the current
2898 buffer/string position, to be restored by pop_it. Fix flags in
2899 the iterator structure wrt the object coming from a display
2900 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2901 properties. (Bug#9284)
2903 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2905 * fontset.c (fontset_get_font_group): Add proper type checks.
2908 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2910 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2911 and LC_VERSION_MIN_MACOSX.
2912 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2913 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2915 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2917 * xdisp.c (forward_to_next_line_start): Allow to use the
2918 no-display-properties-and-no-overlays under bidi display.
2919 Set disp_pos in the bidi iterator to avoid searches for display
2920 properties and overlays.
2922 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2924 * editfns.c (Fset_time_zone_rule): Document relationship with the
2927 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2928 the font entity extracted from the cache (Bug#8109).
2930 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2932 * composite.c (autocmp_chars): Don't reset point. That is done by
2933 restore_point_unwind (Bug#5984).
2935 2011-08-07 Juri Linkov <juri@jurta.org>
2937 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2938 to show the arg `TIME' instead of `TIMEVAL'.
2940 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2943 display property strides EOL and includes a newline, as in
2944 longlines-mode. (Bug#9254)
2945 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2946 word-wrap under bidirectional display. (Bug#9224)
2948 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2949 is non-zero, even if the data buffer is NULL. Fixes a crash in
2950 vertical-motion with longlines-mode. (Bug#9254)
2952 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2954 * bidi.c <bidi_cache_total_alloc>: Now static.
2955 (bidi_initialize): Initialize bidi_cache_total_alloc.
2957 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2960 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2961 amount allocated this far in `bidi_cache_total_alloc'.
2962 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2963 non-zero, only free the data buffer without restoring the cache
2964 contents. All callers changed.
2966 * dispextern.h (bidi_unshelve_cache): Update prototype.
2968 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2969 (move_it_in_display_line, move_it_to)
2970 (move_it_vertically_backward, move_it_by_lines): Replace the call
2971 to xfree to an equivalent call to bidi_unshelve_cache.
2972 (move_it_in_display_line_to): Fix logic of returning
2973 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2975 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2978 came from a string character with a `cursor' property. (Bug#9229)
2980 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2982 * Makefile.in (LIB_PTHREAD): New variable.
2983 (LIBES): Add LIB_PTHREAD (Bug#9216).
2985 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2986 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2988 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2990 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2992 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2994 * xterm.c (x_find_topmost_parent): New function.
2995 (x_set_frame_alpha): Find topmost parent window with
2996 x_find_topmost_parent and set the property there also (bug#9181).
2997 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2999 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3001 * callproc.c (Fcall_process): Avoid vfork clobbering
3002 the local vars buffer, coding_systems, current_dir.
3004 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3006 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3008 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3010 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3011 so that it is not optimized away.
3013 * xdisp.c (compute_display_string_pos): Remove unused local.
3015 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3017 Fix slow cursor motion and scrolling in large buffers with
3018 selective display, like Org Mode buffers. (Bug#9218)
3020 * dispextern.h (struct bidi_it): New member disp_prop_p.
3022 * xdisp.c: Remove one-slot cache of display string positions.
3023 (compute_display_string_pos): Accept an additional argument
3024 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3025 for a display string or property. If found, set DISP_PROP_P
3028 * bidi.c (bidi_fetch_char): Accept an additional argument
3029 DISP_PROP_P, and pass it to compute_display_string_pos.
3030 Only handle text covered by a display string if DISP_PROP_P is returned
3031 non-zero. All callers of bidi_fetch_char changed.
3033 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3035 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3037 2010-12-03 Don March <don@ohspite.net>
3039 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3040 last character M-[char] is translated to ESC [char] (bug#7541).
3042 2011-08-02 Kenichi Handa <handa@m17n.org>
3044 * lisp.h (uniprop_table): Extern it.
3046 * chartab.c (uniprop_table): Make it non-static.
3048 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3050 * xdisp.c (forward_to_next_line_start): Accept additional argument
3051 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3053 (reseat_at_next_visible_line_start): Use the bidi iterator state
3054 returned by forward_to_next_line_start to restore the state of
3055 it->bidi_it after backing up to previous newline. (Bug#9212)
3057 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3059 * regex.c (re_comp): Protoize.
3060 (re_exec): Fix return type.
3061 (regexec): Fix type of `ret'. (Bug#9203)
3063 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3065 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3066 This is needed if max-image-size is a floating-point number.
3068 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3070 * print.c (print_object): Print empty symbol as ##.
3072 * lread.c (read1): Read ## as empty symbol.
3074 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3076 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3077 setting frame foreground color (Bug#9175).
3078 (x_set_background_color): Likewise.
3080 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3081 contents (Bug#9176).
3082 (EmacsTooltip -init): Remove bezels and add shadows to
3085 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3086 or scroll bar (Bug#8470).
3088 * nsfont.m (nsfont_open): Remove assignment to voffset and
3089 unnecessary vars hshink, expand, hd, full_height, min_height.
3090 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3092 * nsterm.h (nsfont_info): Remove voffset field.
3094 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3096 Implement strike-through and overline on NextStep (Bug#8863).
3098 * nsfont.m (nsfont_open): Use underline position provided by font,
3099 instead of hard-coded value of 2.
3100 (nsfont_draw): Call ns_draw_text_decoration instead.
3102 * nsterm.h: Add declaration for ns_draw_text_decoration.
3104 * nsterm.m (ns_draw_text_decoration): New function for drawing
3105 underline, overline, and strike-through.
3106 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3107 ns_draw_text_decoration. Change treatment of cursor drawing to
3108 accommodate underlining, etc.
3110 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3112 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3115 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3117 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3118 Without this fix, if a signal arrives just after memory fills up,
3119 'malloc' might be invoked reentrantly.
3121 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3122 In other words, assume that every image size is allowed, on non-X
3123 hosts. This assumption is probably wrong, but it lets Emacs compile.
3125 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3127 * regex.c (re_iswctype): Convert return values to boolean.
3129 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3131 * xdisp.c (compute_display_string_pos): Don't use cached display
3132 string position if the buffer had its restriction changed.
3135 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3137 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3139 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3141 Integer signedness and overflow and related fixes. (Bug#9079)
3143 * bidi.c: Integer size and overflow fixes.
3144 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3145 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3146 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3147 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3148 (bidi_find_other_level_edge):
3149 Use ptrdiff_t instead of EMACS_INT where either will do.
3150 This works better on 32-bit hosts configured --with-wide-int.
3151 (bidi_cache_ensure_space): Check for size-calculation overflow.
3152 Use % rather than repeated addition, for better worst-case speed.
3153 Don't set bidi_cache_size until after xrealloc returns, because it
3155 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3156 (bidi_cache_ensure_space): Also check that the bidi cache size
3157 does not exceed that of the largest Lisp string or buffer. See Eli
3158 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3160 * alloc.c (__malloc_size_t): Remove.
3161 All uses replaced by size_t. See Andreas Schwab's note
3162 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3164 * image.c: Improve checking for integer overflow.
3165 (check_image_size): Assume that f is nonnull, since
3166 it is always nonnull in practice. This is one less thing to
3167 worry about when checking for integer overflow later.
3168 (x_check_image_size): New function, which checks for integer
3169 overflow issues inside X.
3170 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3171 This removes the need for a memory_full check.
3172 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3173 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3174 (xbm_read_bitmap_data): Change locals back to 'int', since
3175 their values must fit in 'int'.
3176 (xpm_load_image, png_load, tiff_load):
3177 Invoke x_create_x_image_and_pixmap earlier,
3178 to avoid much needless work if the image is too large.
3179 (tiff_load): Treat overly large images as if
3180 x_create_x_image_and_pixmap failed, not as malloc failures.
3181 (gs_load): Use x_check_image_size.
3183 * gtkutil.c: Omit integer casts.
3184 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3185 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3187 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3189 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3190 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3191 would wrongly return t on a 64-bit host.
3193 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3194 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3195 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3196 and therefore cause GCC to emit a bogus diagnostic in some cases.
3198 * image.c: Integer signedness and overflow and related fixes.
3199 This is not an exhaustive set of fixes, but it's time to
3200 record what I've got.
3201 (lookup_pixel_color, check_image_size): Remove redundant decls.
3202 (check_image_size): Don't assume that arbitrary EMACS_INT values
3203 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3204 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3205 (tiff_load, imagemagick_load_image):
3206 Check for overflow in size calculations.
3207 (x_create_x_image_and_pixmap): Remove unnecessary test for
3208 xmalloc returning NULL; that can't happen.
3209 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3210 (xpm_color_bucket): Use better integer hashing function.
3211 (xpm_cache_color): Don't possibly over-allocate memory.
3212 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3213 (gif_memory_source):
3214 Use ptrdiff_t, not int or size_t, to record sizes.
3215 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3216 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3217 either works, as we prefer signed integers.
3218 (tiff_read_from_memory, tiff_write_from_memory):
3219 Return tsize_t, not size_t, since that's what the TIFF API wants.
3220 (tiff_read_from_memory): Don't fail simply because the read would
3221 go past EOF; instead, return a short read.
3222 (tiff_load): Omit no-longer-needed casts.
3223 (Fimagemagick_types): Don't assume size fits into 'int'.
3225 Improve hashing quality when configured --with-wide-int.
3226 * fns.c (hash_string): New function, taken from sxhash_string.
3227 Do not discard information about ASCII character case; this
3228 discarding is no longer needed.
3229 (sxhash-string): Use it. Change sig to match it. Caller changed.
3230 * lisp.h: Declare it.
3231 * lread.c (hash_string): Remove, since we now use fns.c's version.
3232 The fns.c version returns a wider integer if --with-wide-int is
3233 specified, so this should help the quality of the hashing a bit.
3235 * emacs.c: Integer overflow minor fix.
3236 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3237 Define only if GNU_LINUX.
3238 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3240 * dispnew.c: Integer signedness and overflow fixes.
3241 Remove unnecessary forward decls, that were a maintenance hassle.
3242 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3244 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3245 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3246 (prepare_desired_row, line_draw_cost):
3247 Use int, not unsigned, where either works.
3248 (save_current_matrix, restore_current_matrix):
3249 Use ptrdiff_t, not size_t, where either works.
3250 (init_display): Check for overflow more accurately, and without
3251 relying on undefined behavior.
3253 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3254 Remove, replacing with the new symbols in lisp.h. All uses changed.
3255 * fileio.c (make_temp_name):
3256 * filelock.c (lock_file_1, lock_file):
3257 * xdisp.c (message_dolog):
3258 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3259 Use pMd etc. instead.
3260 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3261 replacing the pWIDE etc. symbols removed from editfns.c.
3263 * keyboard.h (num_input_events): Now uintmax_t.
3264 This is (very slightly) less likely to mess up due to wraparound.
3267 * buffer.c: Integer signedness fixes.
3268 (alloc_buffer_text, enlarge_buffer_text):
3269 Use ptrdiff_t rather than size_t when either will do, as we prefer
3272 * alloc.c: Integer signedness and overflow fixes.
3273 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3274 (__malloc_size_t): Default to size_t, not to int.
3275 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3276 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3277 Prefer ptrdiff_t to size_t when either would do, as we prefer
3279 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3280 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3281 Now const. Initialize with values that are in range even if char
3283 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3284 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3285 These functions do the right thing with sizes > 2**32.
3286 (check_depth): Now ptrdiff_t, not int.
3287 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3288 Adjust to new way of storing sizes. Check for size overflow bugs
3290 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3291 slightly wrong anyway, as it missed one instance of
3292 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3293 (refill_memory_reserve): Omit needless cast to size_t.
3294 (mark_object_loop_halt): Mark as externally visible.
3296 * xselect.c: Integer signedness and overflow fixes.
3297 (Fx_register_dnd_atom, x_handle_dnd_message):
3298 Use ptrdiff_t, not size_t, since we prefer signed.
3299 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3300 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3301 x_dnd_atoms_size and x_dnd_atoms_length.
3303 * doprnt.c: Prefer signed to unsigned when either works.
3305 * doprnt.c (doprnt):
3307 * xdisp.c (vmessage):
3308 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3309 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3310 prefer signed arithmetic to avoid comparison confusion.
3311 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3312 but is a bit tricky.
3314 Assume freestanding C89 headers, string.h, stdlib.h.
3315 * data.c, doprnt.c, floatfns.c, print.c:
3316 Include float.h unconditionally.
3317 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3318 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3319 * regex.c: Likewise for stddef.h, string.h.
3320 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3321 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3322 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3323 (STDC_HEADERS): Remove obsolete defines.
3324 * sysdep.c: Include limits.h unconditionally.
3326 Assume support for memcmp, memcpy, memmove, memset.
3327 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3328 * regex.c (memcmp, memcpy):
3329 Remove; we assume C89 now.
3331 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3332 (__malloc_safe_bcopy): Remove; no longer needed.
3334 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3335 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3336 well either way, and we prefer signed to unsigned.
3338 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3340 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3341 closes the connection while we're reading (bug#9182).
3343 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3345 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3346 are specified (Bug#9168).
3348 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3350 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3351 Found by GCC static checking and --with-wide-int on a 32-bit host.
3353 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (compute_display_string_pos): Fix logic of caching
3356 previous display string position. Initialize cached_prev_pos to
3357 -1. Fixes slow-down at the beginning of a buffer.
3359 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3361 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3362 for attrs[LFACE_FONTSET_INDEX].
3364 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3366 * xml.c (parse_region): Remove unused local
3367 that was recently introduced.
3369 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3371 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3372 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3374 * xdisp.c (move_it_in_display_line_to): Record the best matching
3375 position for TO_CHARPOS while scanning the line, and restore it on
3376 exit if none of the characters scanned was an exact match.
3377 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3378 when exact match is impossible due to invisible text, and the
3379 lines are truncated.
3381 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3383 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3386 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3388 Fix a significant slow-down of cursor motion with C-n, C-p,
3389 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3390 auto-repeat under bidi redisplay in fontified buffers.
3391 * xdisp.c (compute_stop_pos_backwards): New function.
3392 (next_element_from_buffer): Call compute_stop_pos_backwards to
3393 find a suitable prev_stop when we find ourselves before
3395 (reseat): Don't look for prev_stop, as that could mean a very long
3397 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3398 <cached_disp_overlay_modiff>: Cache for last found display string
3400 (compute_display_string_pos): Return the cached position if asked
3401 about the same buffer in the same area of character positions, and
3402 the buffer wasn't changed since the time the display string
3403 position was cached.
3405 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3407 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3408 is an integer, which is important for empty lines. (Bug#9149)
3410 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3412 * frame.c (Fmodify_frame_parameters): In tty case, update the
3413 default face if necessary (Bug#4238).
3415 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3417 * editfns.c (Fstring_to_char): No need to explain what a character
3418 is in the docstring (Bug#6576).
3420 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3422 * xml.c (parse_region): Make sure we always return a tree.
3424 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3426 * xml.c (parse_region): If a document contains only comments,
3429 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3431 * xml.c (make_dom): Return comments, too.
3433 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3436 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3437 and the surrounding thread.
3438 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3439 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3440 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3442 * s/openbsd.h (BROKEN_SIGIO): Define.
3443 * unexelf.c (unexec) [__OpenBSD__]:
3444 Don't update the .mdebug section of the Alpha COFF symbol table.
3446 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3448 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3451 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3453 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3454 This fixes some race conditions on the permissions of any newly
3457 * alloc.c (valid_pointer_p): Use pipe, not open.
3458 This fixes some permissions issues when debugging.
3460 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3461 If fchown fails to set both uid and gid, try to set just gid,
3462 as that is sometimes allowed. Adjust the file's mode to eliminate
3463 setuid or setgid bits that are inappropriate if fchown fails.
3465 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3467 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3468 to compare Lisp_Objects.
3469 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3470 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3471 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3473 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3475 * lread.c (read_integer): Unread even EOF character.
3476 (read1): Likewise. Properly record start position of symbol.
3478 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3479 symbol character follows.
3481 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3483 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3484 This works around a problem with the previous change to Fcopy_file.
3485 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3486 and without this change, GCC might complain about discarding
3487 fchown's return value.
3489 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3491 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3493 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3495 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3497 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3499 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3500 it's used from the C level.
3502 * process.c: Use the same condition for POLL_FOR_INPUT in both
3503 keyboard.c and process.c (bug#1858).
3505 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3507 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3508 (Fgnutls_boot): Use it.
3510 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3512 * doc.c (Fsubstitute_command_keys): Revert last change.
3514 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3516 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3517 quotes the next character, and doesn't affect other longer
3518 sequences (bug#8935).
3520 * lread.c (syms_of_lread): Clarify that is isn't only
3521 `eval-buffer' and `eval-defun' that's affected by
3522 `lexical-binding' (bug#8460).
3524 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3526 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3527 bidi redisplay when a line includes both an image and is truncated.
3529 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3531 Fix minor problems found by static checking.
3532 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3533 (elsz): Now a signed constant, not a size_t var. We prefer signed
3534 types to unsigned, to avoid integer comparison confusion. Without
3535 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3536 "cannot optimize loop, the loop counter may overflow", a symptom
3538 * indent.c (Fvertical_motion): Mark locals as initialized.
3539 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3541 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3543 * search.c (Fre_search_backward): Mention `case-fold-search' in
3544 all the re_search_* functions (bug#8138).
3546 * keyboard.c (Fopen_dribble_file): Document when the file is
3549 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3551 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3554 Support bidi reordering of display and overlay strings.
3555 * xdisp.c (compute_display_string_pos)
3556 (compute_display_string_end): Accept additional argument STRING.
3557 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3558 (reseat_to_string): Initialize bidi_it->string.s and
3559 bidi_it->string.schars.
3560 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3561 NULL (avoids a crash in bidi_paragraph_init).
3562 Initialize itb.string.lstring.
3563 (init_iterator): Call bidi_init_it only of a valid
3564 buffer position was specified. Initialize paragraph_embedding to
3566 (reseat_to_string): Initialize the bidi iterator.
3567 (display_string): If we need to ignore text properties of
3568 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3569 original value of -1 will not work with bidi.)
3570 (compute_display_string_pos): First arg is now struct
3571 `text_pos *'; all callers changed. Support display properties on
3573 (compute_display_string_end): Support display properties on Lisp
3575 (init_iterator, reseat_1, reseat_to_string): Initialize the
3576 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3577 when iterating on a string not from display properties).
3578 (compute_display_string_pos, compute_display_string_end):
3579 Fix calculation of the object to scan. Fixes an error when using
3581 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3582 base_level_stop; instead, set base_level_stop to BEGV.
3583 Fixes crashes in vertical-motion.
3584 (next_element_from_buffer): Improve commentary for when
3585 the iterator is before prev_stop.
3586 (init_iterator): Initialize bidi_p from the default value of
3587 bidi-display-reordering, not from buffer-local value. Use the
3588 buffer-local value only if initializing for buffer iteration.
3589 (handle_invisible_prop): Support invisible properties on strings
3590 that are being bidi-reordered.
3591 (set_iterator_to_next): Support bidi reordering of C strings and
3593 (next_element_from_string): Support bidi reordering of Lisp
3595 (handle_stop_backwards): Support Lisp strings as well.
3596 (display_string): Support display of R2L glyph rows.
3597 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3598 (init_iterator): Don't initialize it->bidi_p for strings
3600 (reseat_to_string): Initialize it->bidi_p for strings here.
3601 (next_element_from_string, next_element_from_c_string)
3602 (next_element_from_buffer): Add xassert's for correspondence
3603 between IT's object being iterated and it->bidi_it.string
3605 (face_before_or_after_it_pos): Support bidi iteration.
3606 (next_element_from_c_string): Handle the case of the first string
3607 character that is not the first one in the visual order.
3608 (get_visually_first_element): New function, refactored from common
3609 parts of next_element_from_buffer, next_element_from_string, and
3610 next_element_from_c_string.
3611 (tool_bar_lines_needed, redisplay_tool_bar)
3612 (display_menu_bar): Force left-to-right direction. Add a FIXME
3613 comment for making that be controlled by a user option.
3614 (push_it, pop_it): Save and restore the state of the
3615 bidi iterator. Save and restore the bidi_p flag.
3616 (pop_it): Iterate out of display property for string iteration as
3618 (iterate_out_of_display_property): Support iteration over strings.
3619 (handle_single_display_spec): Set up it->bidi_it for iteration
3620 over a display string, and call bidi_init_it.
3621 (handle_single_display_spec, next_overlay_string)
3622 (get_overlay_strings_1, push_display_prop): Set up the bidi
3623 iterator for displaying display or overlay strings.
3624 (forward_to_next_line_start): Don't use the shortcut if
3626 (back_to_previous_visible_line_start): If handle_display_prop
3627 pushed the iterator stack, restore the internal state of the bidi
3628 iterator by calling bidi_pop_it same number of times.
3629 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3630 and we are bidi-iterating, don't decrement the iterator position;
3631 instead, set the first_elt flag in the bidi iterator, to produce
3633 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3634 (push_display_prop): xassert that we are iterating a buffer.
3635 (push_it, pop_it): Save and restore paragraph_embedding member.
3636 (handle_single_display_spec, next_overlay_string)
3637 (get_overlay_strings_1, reseat_1, reseat_to_string)
3638 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3639 correctly. Don't assume unibyte strings are not bidi-reordered.
3640 (compute_display_string_pos)
3641 (compute_display_string_end): Fix handling the case of C string.
3642 (push_it, pop_it): Save and restore from_disp_prop_p.
3643 (handle_single_display_spec, push_display_prop): Set the
3644 from_disp_prop_p flag.
3645 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3646 (pop_it): Call iterate_out_of_display_property only if we are
3647 popping after iteration over a string that came from a display
3648 property. Fix a typo in popping stretch info. Add an assertion
3649 for verifying that the iterator position is in sync with the bidi
3651 (handle_single_display_spec, get_overlay_strings_1)
3652 (push_display_prop): Fix initialization of paragraph direction for
3653 string when that of the parent object is not yet determined.
3654 (reseat_1): Call bidi_init_it to resync the bidi
3655 iterator with IT's position. (Bug#7616)
3656 (find_row_edges): If ROW->start.pos gives position
3657 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3658 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3659 Reset the from_disp_prop_p flag.
3660 (SAVE_IT, RESTORE_IT): New macros.
3661 (pos_visible_p, face_before_or_after_it_pos)
3662 (back_to_previous_visible_line_start)
3663 (move_it_in_display_line_to, move_it_in_display_line)
3664 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3665 (try_scrolling, redisplay_window, display_line): Use them when
3666 saving a temporary copy of the iterator and restoring it back.
3667 (back_to_previous_visible_line_start, reseat_1)
3668 (init_iterator): Empty the bidi cache "stack".
3669 (move_it_in_display_line_to): If iterator ended up at
3670 EOL, but we never saw any buffer positions smaller than
3671 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3672 motion in bidi-reordered lines.
3673 (move_it_in_display_line_to): Record prev_method and prev_pos
3674 immediately before the call to set_iterator_to_next. Fixes cursor
3675 motion in bidi-reordered lines with stretch glyphs and strings
3676 displayed in margins. (Bug#8133) (Bug#8867)
3677 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3679 (pos_visible_p): Support positions in bidi-reordered lines.
3680 Save and restore bidi cache.
3682 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3683 (bidi_paragraph_info): Delete unused struct.
3684 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3685 (bidi_cache_start): New variable.
3686 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3688 (bidi_cache_fetch_state, bidi_cache_search)
3689 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3690 (bidi_cache_find, bidi_peek_at_next_level)
3691 (bidi_level_of_next_char, bidi_find_other_level_edge)
3692 (bidi_move_to_visually_next): Compare cache index with
3693 bidi_cache_start rather than with zero.
3694 (bidi_fetch_char): Accept new argument STRING; all callers
3695 changed. Support iteration over a string. Support strings with
3696 display properties. Support unibyte strings. Fix the type of
3697 `len' according to what STRING_CHAR_AND_LENGTH expects.
3698 (bidi_paragraph_init, bidi_resolve_explicit_1)
3699 (bidi_resolve_explicit, bidi_resolve_weak)
3700 (bidi_level_of_next_char, bidi_move_to_visually_next):
3701 Support iteration over a string.
3702 (bidi_set_sor_type, bidi_resolve_explicit_1)
3703 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3704 can now be zero (for strings); special values 0 and -1 were
3705 changed to -1 and -2, respectively.
3706 (bidi_char_at_pos): New function.
3707 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3708 Call it instead of FETCH_MULTIBYTE_CHAR.
3709 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3710 initialized to valid values.
3711 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3713 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3714 the test for valid cached positions. Fix the logic for looking up
3715 the sentinel state in the cache. GCPRO the Lisp string we are
3717 (bidi_push_it, bidi_pop_it): New functions.
3718 (bidi_initialize): Initialize the bidi cache start stack pointer.
3719 (bidi_cache_ensure_space): New function, refactored from part of
3720 bidi_cache_iterator_state. Don't assume the required size is just
3721 one BIDI_CACHE_CHUNK away.
3722 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3723 (bidi_count_bytes, bidi_char_at_pos): New functions.
3724 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3725 always valid if bidi_cache_idx is valid.
3726 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3727 is valid if it's going to be used.
3728 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3729 (bidi_cache_fetch_state, bidi_cache_search)
3730 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3731 (bidi_cache_iterator_state, bidi_cache_find)
3732 (bidi_find_other_level_edge, bidi_cache_start_stack):
3733 All variables related to cache indices are now EMACS_INT.
3735 * dispextern.h (struct bidi_string_data): New structure.
3736 (struct bidi_it): New member `string'. Make flag members be 1-bit
3737 fields, and put them last in the struct.
3738 (compute_display_string_pos, compute_display_string_end):
3740 (bidi_push_it, bidi_pop_it): Add prototypes.
3741 (struct iterator_stack_entry): New members bidi_p,
3742 paragraph_embedding, and from_disp_prop_p.
3743 (struct it): Member bidi_p is now a bit field 1 bit wide.
3744 (bidi_shelve_cache, bidi_unshelve_cache):
3747 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3748 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3749 and vector-like objects.
3751 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3752 cache around display iteration.
3754 * window.c (Fwindow_end, window_scroll_pixel_based)
3755 (displayed_window_lines, Frecenter): Save and restore the bidi
3756 cache around display iteration.
3758 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3760 * editfns.c (Fdelete_region): Clarify the use of the named
3761 parameters (bug#6788).
3763 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3765 * indent.c (Fvertical_motion): Set and restore w->pointm when
3766 saving and restoring the window's buffer (Bug#9006).
3768 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3770 * editfns.c (Fstring_to_char): Clarify just what is returned
3771 (bug#6576). Text by Eli Zaretskii.
3773 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3775 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3777 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3779 * buffer.c (mmap_find): Fix a typo.
3781 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3783 Fix execution of x selection hooks.
3784 * xselect.c (Qx_lost_selection_functions)
3785 (Qx_sent_selection_functions): New vars.
3786 (syms_of_xselect): DEFSYM them.
3787 (x_handle_selection_request): Pass Qx_sent_selection_functions
3788 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3789 (x_handle_selection_clear,x_clear_frame_selections):
3790 Pass Qx_lost_selection_functions rather than
3791 Vx_lost_selection_functions to Frun_hook_with_args.
3793 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3795 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3796 The old code sometimes used this field without initializing it.
3798 * alloc.c (gc_sweep): Don't read past end of array.
3799 In theory, the old code could also have corrupted Emacs internals,
3800 though it'd be very unlikely.
3802 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3804 * character.c (Fcharacterp): Don't advertise optional ignored
3805 argument. (Bug#4026)
3807 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3809 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3812 * window.c (Fset_window_start): Doc fix (bug#4199).
3813 (Fset_window_hscroll): Ditto.
3815 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3817 Fix minor new problems caught by GCC 4.6.1.
3818 * term.c (init_tty): Remove unused local.
3819 * xsettings.c (store_monospaced_changed): Define this function only
3820 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3823 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3825 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3827 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3829 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3830 are the mini-buffer and the echo area (bug#3320).
3832 * term.c (init_tty): Remove support for supdup, c10 and perq
3833 terminals, which are no longer supported (bug#1482).
3835 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3837 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3839 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3841 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3842 for non-popups (Bug#3642).
3844 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3846 * alloc.c (reset_malloc_hooks): Protoize.
3847 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3848 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3849 * cm.c (losecursor): Likewise.
3850 * data.c (fmod): Likewise.
3851 * dispnew.c (swap_glyphs_in_rows): Likewise.
3852 * emacs.c (memory_warning_signal): Likewise.
3853 * floatfns.c (float_error): Likewise.
3854 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3855 (otf_open, font_otf_capability, generate_otf_features)
3856 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3858 * image.c (pbm_read_file): Likewise.
3859 * indent.c (string_display_width): Likewise.
3860 * intervals.c (check_for_interval, search_for_interval)
3861 (inc_interval_count, count_intervals, root_interval)
3862 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3863 * lread.c (defalias): Likewise.
3864 * ralloc.c (r_alloc_check): Likewise.
3865 * regex.c (set_image_of_range_1, set_image_of_range)
3866 (regex_grow_registers): Likewise.
3867 * sysdep.c (strerror): Likewise.
3868 * termcap.c (valid_filename_p, tprint, main): Likewise.
3869 * tparam.c (main): Likewise.
3870 * unexhp9k800.c (run_time_remap, save_data_space)
3871 (update_file_ptrs, read_header, write_header, calculate_checksum)
3872 (copy_file, copy_rest, display_header): Likewise.
3873 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3875 * xdisp.c (check_it): Likewise.
3876 * xfaces.c (register_color, unregister_color, unregister_colors):
3878 * xfns.c (print_fontset_result): Likewise.
3879 * xrdb.c (member, fatal, main): Likewise.
3881 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3883 Fix minor problems found by static checking (Bug#9031).
3884 * chartab.c (char_table_set_range, map_sub_char_table):
3885 Remove unused locals.
3886 (uniprop_table): Now static.
3887 * composite.c (_work_char): Remove unused static var.
3889 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3891 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3893 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3895 * gtkutil.c (qttip_cb): Remove code without function.
3897 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3899 * w32.c (pthread_sigmask): New stub.
3901 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3903 Use pthread_sigmask, not sigprocmask (Bug#9010).
3904 sigprocmask is portable only for single-threaded applications, and
3905 Emacs can be multi-threaded when it uses GTK.
3906 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3908 * callproc.c (Fcall_process):
3909 * process.c (create_process):
3910 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3911 Use pthread_sigmask, not sigprocmask.
3913 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3915 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3916 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3919 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3921 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3922 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3923 (xg_hide_tooltip): Fix comment.
3925 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3926 in registerServicesMenuSendTypes.
3927 (validRequestorForSendType): Don't check ns_return_types.
3929 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3932 2011-07-08 Jason Rumney <jasonr@gnu.org>
3934 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3935 SH_SHOW for hidden windows (Bug#5482).
3937 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3938 frame struct members of non-existent frames (Bug#6284).
3940 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3942 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3943 variable firstTime not needed on OSX >= 10.6.
3944 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3945 >= 10.5. Use setKnobProportion, setDoubleValue.
3947 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3948 (MAC_OS_X_VERSION_10_5): Define if not defined.
3949 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3950 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3951 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3953 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3954 cString and lossyCString on OSX >= 10.4
3956 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3957 sizeToFit on OSX >= 10.2.
3959 * nsimage.m (allocInitFromFile): Don't use deprecated method
3960 bestRepresentationForDevice on OSX >= 10.6.
3962 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3965 * emacs.c: Declare unexec_init_emacs_zone.
3967 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3969 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3971 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3972 on svcsMenu (Bug#8842).
3974 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3976 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3978 * nsterm.m (QUTF8_STRING): Declare.
3979 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3980 (validRequestorForSendType): Return type is (id).
3981 Change indexOfObjectIdenticalTo to indexOfObject.
3982 Check if we have local selection before returning self (Bug#8842).
3983 (writeSelectionToPasteboard): Put local selection into paste board
3984 if we have a local selection (Bug#8842).
3985 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3987 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3988 (ns_get_local_selection): Declare.
3990 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3992 * keymap.c (describe_map_tree): Don't insert a double newline at
3993 the end of the buffer (bug#1169) and return whether we inserted
3996 * callint.c (Fcall_interactively): Change "reading args" to
3997 "providing args" to try to clarify what it does (bug#1010).
3999 2011-07-07 Kenichi Handa <handa@m17n.org>
4001 * composite.c (composition_compute_stop_pos): Ignore a static
4002 composition starting before CHARPOS (Bug#8915).
4004 * xdisp.c (handle_composition_prop): Likewise.
4006 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4008 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4011 2011-07-07 Kenichi Handa <handa@m17n.org>
4013 * character.h (unicode_category_t): New enum type.
4015 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4016 (Qchar_code_property_table): New variable.
4017 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4018 (UNIPROP_COMPRESSED_FORM_P): New macros.
4019 (char_table_ascii): Uncompress the compressed values.
4020 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4021 Uncompress the compressed values.
4022 (sub_char_table_ref_and_range): Likewise.
4023 (char_table_ref_and_range): Uncompress the compressed values.
4024 (sub_char_table_set): New arg is_uniprop. Callers changed.
4025 Uncompress the compressed values.
4026 (sub_char_table_set_range): Args changed. Callers changed.
4027 (char_table_set_range): Adjuted for the above change.
4028 (map_sub_char_table): Delete args default_val and parent. Add arg
4029 top. Give decoded values to a Lisp function.
4030 (map_char_table): Adjust for the above change. Give decoded
4031 values to a Lisp function. Gcpro more variables.
4032 (uniprop_table_uncompress)
4033 (uniprop_decode_value_run_length): New functions.
4034 (uniprop_decoder, uniprop_decoder_count): New variables.
4035 (uniprop_get_decoder, uniprop_encode_value_character)
4036 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4038 (uniprop_encoder, uniprop_encoder_count): New variables.
4039 (uniprop_get_encoder, uniprop_table)
4040 (Funicode_property_table_internal, Fget_unicode_property_internal)
4041 (Fput_unicode_property_internal): New functions.
4042 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4043 Sunicode_property_table_internal, Sget_unicode_property_internal,
4044 and Sput_unicode_property_internal. Defvar_lisp
4045 char-code-property-alist.
4047 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4048 Vunicode_category_table.
4050 * font.c (font_range): Adjust for the change of
4051 Vunicode_category_table.
4053 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4055 * m/iris4d.h: Remove file, move contents ...
4056 * s/irix6-5.h: ... here.
4058 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4060 Remove unportable assumption about struct layout (Bug#8884).
4061 * alloc.c (mark_buffer):
4062 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4063 (clone_per_buffer_values): Don't assume that
4064 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4065 This isn't true in general, and it's particularly not true
4066 if Emacs is configured with --with-wide-int.
4067 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4068 New macros, used in the buffer.c change.
4070 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4072 * xsettings.c: Use both GConf and GSettings if both are available.
4073 (store_config_changed_event): Add comment.
4074 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4075 (store_tool_bar_style_changed): New functions.
4076 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4077 (struct xsettings): Move font inside HAVE_XFT.
4078 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4079 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4080 Move inside HAVE_XFT.
4081 (something_changed_gsettingsCB): Rename from something_changedCB.
4082 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4084 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4085 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4086 (something_changed_gconfCB): Rename from something_changedCB.
4087 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4088 (parse_settings): Move check for font inside HAVE_XFT.
4089 (read_settings, apply_xft_settings): Add comment.
4090 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4091 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4092 call store_font_name_changed.
4093 (xft_settings_event): Add comment.
4094 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4095 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4096 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4097 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4098 (xsettings_initialize): Call init_gsettings last.
4099 (xsettings_get_system_font, xsettings_get_system_normal_font):
4102 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4104 Random fixes. E.g., (random) never returned negative values.
4105 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4106 subseconds part to the entropy, as that's a bit more random.
4107 Prefer signed to unsigned, since the signedness doesn't matter and
4108 in general we prefer signed. When given a limit, use a
4109 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4110 latter isn't right if USE_2_TAGS_FOR_INTS.
4111 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4112 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4114 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4116 * textprop.c (text_property_stickiness):
4117 Obey Vtext_property_default_nonsticky.
4118 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4119 * w32fns.c (syms_of_w32fns):
4120 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4122 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4124 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4125 This is more efficient than Ffile_directory_p and avoids a minor race.
4127 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4129 * buffer.c (Foverlay_put): Say what the return value is
4132 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4133 is a directory before asking whether to use the file name
4135 (barf_or_query_if_file_exists): Make the "File is a directory"
4136 error be more correct.
4138 * fns.c (Frequire): Remove the mention of the .gz files, since
4139 that's installation-specific, but keep the mention of
4140 `get-load-suffixes'.
4142 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4144 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4145 Report string overflow if the output is too long.
4147 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4149 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4150 (syms_of_gnutls): Remove duplicate DEFSYM for
4151 Qgnutls_bootprop_verify_hostname_error, an error for
4152 Qgnutls_bootprop_verify_error (which is no longer used).
4154 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4155 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4156 Also (re)move comments that are misplaced or no longer relevant.
4158 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4160 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4162 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4164 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4165 and background color parameters if they have been changed.
4167 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4171 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4173 * xsettings.c (SYSTEM_FONT): Define only when used.
4174 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4176 * keymap.c (access_keymap_1): Now static.
4178 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4180 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4181 leave any prefix arg for the up event (Bug#1586).
4183 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4185 * lread.c (syms_of_lread): Mention single symbols defined by
4186 `defvar' or `defconst' (bug#7154).
4188 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4189 (Frequire): Mention get-load-suffixes.
4191 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4193 * window.h (window): Remove clone_number slot.
4194 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4196 (make_parent_window, make_window, saved_window)
4197 (Fset_window_configuration, save_window_save): Don't deal with
4199 * buffer.c (Qclone_number): Remove declaration.
4200 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4202 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4204 Add multiple inheritance to keymaps.
4205 * keymap.c (Fmake_composed_keymap): New function.
4206 (Fset_keymap_parent): Simplify.
4207 (fix_submap_inheritance): Remove.
4208 (access_keymap_1): New function extracted from access_keymap to handle
4209 embedded parents and handle lists of maps.
4210 (access_keymap): Use it.
4211 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4212 (Fcopy_keymap): Handle embedded parents.
4213 (Fcommand_remapping, define_as_prefix): Simplify.
4214 (Fkey_binding): Simplify.
4215 (syms_of_keymap): Move minibuffer-local-completion-map,
4216 minibuffer-local-filename-completion-map,
4217 minibuffer-local-must-match-map, and
4218 minibuffer-local-filename-must-match-map to Elisp.
4219 (syms_of_keymap): Defsubr make-composed-keymap.
4220 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4221 (parse_menu_item): Trivial simplification.
4223 2011-07-01 Glenn Morris <rgm@gnu.org>
4225 * Makefile.in (SETTINGS_LIBS): Fix typo.
4227 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4229 * coding.c (Fencode_coding_string): Record the last coding system
4230 used, as the function doc string says (bug#8738).
4232 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4234 * xsettings.c (store_monospaced_changed): Take new font as arg and
4235 check for change against current_mono_font.
4236 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4237 (emacs_settings_constructor, emacs_settings_get_property)
4238 (emacs_settings_set_property, emacs_settings_class_init)
4239 (emacs_settings_init, gsettings_obj): Remove.
4240 (something_changedCB): New function for HAVE_GSETTINGS.
4241 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4242 with value as argument.
4243 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4244 g_settings_new (Bug#8967). Do not create gsettings_obj.
4245 Remove calls to g_settings_bind. Connect something_changedCB to
4248 * xgselect.c: Add defined (HAVE_GSETTINGS).
4249 (xgselect_initialize): Ditto.
4251 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4252 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4255 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4257 * eval.c (struct backtrace): Simplify and port the data structure.
4258 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4259 signed bit field, as this assumption is not portable and it makes
4260 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4261 "char debug_on_exit : 1" as this is not portable either; instead,
4262 use the portable "unsigned int debug_on_exit : 1". Remove unused
4263 member evalargs. Remove obsolete comments about cc bombing out.
4265 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4267 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4268 Let HAVE_GSETTINGS override HAVE_GCONF.
4269 (store_monospaced_changed): New function.
4270 (EMACS_SETTINGS): A new type derived from GObject to handle
4271 GSettings notifications.
4272 (emacs_settings_constructor, emacs_settings_get_property)
4273 (emacs_settings_set_property, emacs_settings_class_init):
4275 (gsettings_client, gsettings_obj): New variables.
4276 (GSETTINGS_SCHEMA): New define.
4277 (something_changedCB): Call store_monospaced_changed.
4278 (init_gsettings): New function.
4279 (xsettings_initialize): Call init_gsettings.
4280 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4283 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4286 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4288 * window.c (resize_root_window, grow_mini_window)
4289 (shrink_mini_window): Rename Qresize_root_window to
4290 Qwindow_resize_root_window and Qresize_root_window_vertically to
4291 Qwindow_resize_root_window_vertically.
4293 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4295 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4297 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4299 * makefile.w32-in: Redesign dependencies so they reflect more
4300 clearly which files are directly included by each source file,
4301 and not through other includes.
4303 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4305 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4306 (sort_overlays, overlay_strings): When an overlay's clone number
4307 matches the window's clone number process the overlay even if
4308 the overlay's window property doesn't match the current window.
4310 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4311 (Fwindow_hchild): Rename to Fwindow_left_child.
4312 (Fwindow_next): Rename to Fwindow_next_sibling.
4313 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4314 (resize_window_check): Rename to window_resize_check.
4315 (resize_window_apply): Rename to window_resize_apply.
4316 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4317 (Fdelete_other_windows_internal, resize_frame_windows)
4318 (Fsplit_window_internal, Fdelete_window_internal)
4319 (grow_mini_window, shrink_mini_window)
4320 (Fresize_mini_window_internal): Fix callers accordingly.
4322 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4324 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4325 (emacs_fixed_set_min_size): Remove.
4326 (emacs_fixed_new): Take frame as argument.
4328 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4329 (_EmacsFixedPrivate): Remove minwidth/height.
4330 Add struct frame *f.
4331 (emacs_fixed_init): Initialize priv->f.
4332 (get_parent_class, emacs_fixed_set_min_size): Remove.
4333 (emacs_fixed_new): Set priv->f to argument.
4334 (emacs_fixed_get_preferred_width)
4335 (emacs_fixed_get_preferred_height): Use min_width/height from
4336 frames size_hint to set minimum and natural (Bug#8919).
4337 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4338 and use min_width/height from frames size_hint to set
4339 min_width/height (Bug#8919).
4341 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4342 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4345 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4347 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4348 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4351 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4353 * process.c (wait_reading_process_output): Bypass select if
4354 waiting for a cell while ignoring keyboard input, and input is
4355 pending. Suggested by Jan Djärv (Bug#8869).
4357 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4359 Use gnulib's dup2 module instead of rolling our own.
4360 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4362 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4364 * dispnew.c (scrolling_window): Before scrolling, turn off a
4365 mouse-highlight in the window being scrolled.
4367 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4369 Move DEFSYM to lisp.h and use everywhere.
4371 * character.h (DEFSYM): Move declaration...
4372 * lisp.h (DEFSYM): ...here.
4378 * w32select.c: Don't include character.h.
4380 * alloc.c (syms_of_alloc):
4381 * buffer.c (syms_of_buffer):
4382 * bytecode.c (syms_of_bytecode):
4383 * callint.c (syms_of_callint):
4384 * casefiddle.c (syms_of_casefiddle):
4385 * casetab.c (init_casetab_once):
4386 * category.c (init_category_once, syms_of_category):
4387 * ccl.c (syms_of_ccl):
4388 * cmds.c (syms_of_cmds):
4389 * composite.c (syms_of_composite):
4390 * dbusbind.c (syms_of_dbusbind):
4391 * dired.c (syms_of_dired):
4392 * dispnew.c (syms_of_display):
4393 * doc.c (syms_of_doc):
4394 * editfns.c (syms_of_editfns):
4395 * emacs.c (syms_of_emacs):
4396 * eval.c (syms_of_eval):
4397 * fileio.c (syms_of_fileio):
4398 * fns.c (syms_of_fns):
4399 * frame.c (syms_of_frame):
4400 * fringe.c (syms_of_fringe):
4401 * insdel.c (syms_of_insdel):
4402 * keymap.c (syms_of_keymap):
4403 * lread.c (init_obarray, syms_of_lread):
4404 * macros.c (syms_of_macros):
4405 * msdos.c (syms_of_msdos):
4406 * print.c (syms_of_print):
4407 * process.c (syms_of_process):
4408 * search.c (syms_of_search):
4409 * sound.c (syms_of_sound):
4410 * syntax.c (init_syntax_once, syms_of_syntax):
4411 * terminal.c (syms_of_terminal):
4412 * textprop.c (syms_of_textprop):
4413 * undo.c (syms_of_undo):
4414 * w32.c (globals_of_w32):
4415 * window.c (syms_of_window):
4416 * xdisp.c (syms_of_xdisp):
4417 * xfaces.c (syms_of_xfaces):
4418 * xfns.c (syms_of_xfns):
4419 * xmenu.c (syms_of_xmenu):
4420 * xsettings.c (syms_of_xsettings):
4421 * xterm.c (syms_of_xterm): Use DEFSYM.
4423 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4425 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4427 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4429 Integer and buffer overflow fixes (Bug#8873).
4431 * print.c (printchar, strout): Check for string overflow.
4432 (PRINTPREPARE, printchar, strout):
4433 Don't set size unless allocation succeeds.
4435 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4436 for sizes. Check for string overflow more accurately.
4437 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4439 * macros.c: Integer and buffer overflow fixes.
4440 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4441 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4442 Use ptrdiff_t, not int, for sizes.
4443 Don't increment bufsize until after realloc succeeds.
4444 Check for size-calculation overflow.
4445 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4447 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4449 * lread.c: Integer overflow fixes.
4450 (read_integer): Radix is now EMACS_INT, not int,
4451 to improve quality of diagnostics for out-of-range radices.
4452 Calculate buffer size correctly for out-of-range radices.
4453 (read1): Check for integer overflow in radices, and in
4454 read-circle numbers.
4455 (read_escape): Avoid int overflow.
4456 (Fload, openp, read_buffer_size, read1)
4457 (substitute_object_recurse, read_vector, read_list, map_obarray):
4458 Use ptrdiff_t, not int, for sizes.
4459 (read1): Use EMACS_INT, not int, for sizes.
4460 Check for size overflow.
4462 * image.c (cache_image): Check for size arithmetic overflow.
4464 * lread.c: Integer overflow issues.
4465 (saved_doc_string_size, saved_doc_string_length)
4466 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4467 Now ptrdiff_t, not int.
4468 (read1): Don't assume doc string length fits in int. Check for
4469 out-of-range doc string lengths.
4470 (read_list): Don't assume file position fits in int.
4471 (read_escape): Check for hex character overflow.
4473 2011-06-22 Leo Liu <sdl.web@gmail.com>
4475 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4476 Move to minibuffer.el.
4478 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4480 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4481 The following patches are for when GLYPH_DEBUG && !XASSERT.
4482 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4483 * dispnew.c (flush_stdout):
4484 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4485 Mark as externally visible.
4486 * dispnew.c (check_window_matrix_pointers): Now static.
4487 * dispnew.c (window_to_frame_vpos):
4488 * xfns.c (unwind_create_frame):
4489 * xterm.c (x_check_font): Remove unused local.
4490 * scroll.c (CHECK_BOUNDS):
4491 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4492 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4493 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4494 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4495 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4497 (debug_method_add): Use va_list and vsprintf rather than relying
4498 on undefined behavior with wrong number of arguments.
4499 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4500 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4501 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4502 since we're not interested in debugging glyphs with old libraries.
4503 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4504 GCC 4.6.0's static checking.
4506 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4508 Integer overflow and signedness fixes (Bug#8873).
4509 A few related buffer overrun fixes, too.
4511 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4513 * dispextern.h (struct face.stipple):
4514 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4515 (x_bitmap_mask, x_allocate_bitmap_record)
4516 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4517 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4518 (x_create_bitmap_from_xpm_data):
4519 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4520 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4522 * xfaces.c (load_pixmap):
4523 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4524 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4525 (.bitmaps_last, struct x_output.icon_bitmap):
4526 Use ptrdiff_t, not int, for bitmap indexes.
4527 (x_allocate_bitmap_record): Check for size overflow.
4528 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4530 Use ptrdiff_t, not int, for overlay counts.
4531 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4532 * editfns.c (overlays_around, get_pos_property):
4533 * textprop.c (get_char_property_and_overlay):
4534 * xdisp.c (next_overlay_change, note_mouse_highlight):
4535 * xfaces.c (face_at_buffer_position):
4536 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4537 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4538 (Fnext_overlay_change, Fprevious_overlay_change)
4539 (mouse_face_overlay_overlaps, Foverlays_in):
4540 Use ptrdiff_t, not int, for sizes.
4541 (overlays_at, overlays_in): Check for size-calculation overflow.
4543 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4545 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4546 (x_session_initialize): Do not assume string length fits in int.
4548 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4549 This is unlikely, but can occur if DPI is outlandish.
4551 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4552 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4554 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4555 * xrdb.c (magic_file_p, search_magic_path):
4556 Omit last arg SUFFIX; it was always 0. All callers changed.
4557 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4559 * xfont.c (xfont_match): Avoid need for strlen.
4561 * xfns.c: Don't assume strlen fits in int.
4562 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4564 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4565 not unsigned long, as we prefer signed integers. All callers changed.
4566 Detect integer overflow in repeat count.
4567 (message_dolog): Don't assume print length fits in 39 bytes.
4568 (display_mode_element): Don't assume strlen fits in int.
4570 * termcap.c: Don't assume sizes fit in int and never overflow.
4571 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4572 (gobble_line): Check for size-calculation overflow.
4574 * minibuf.c (Fread_buffer):
4575 * lread.c (intern, intern_c_string):
4576 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4577 Don't assume string length fits in int.
4579 * keyboard.c (parse_tool_bar_item):
4580 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4582 * font.c: Don't assume string length fits in int.
4583 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4584 Use ptrdiff_t, not int.
4585 (font_intern_prop): Don't assume string length fits in int.
4586 Don't assume integer property fits in fixnum.
4587 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4589 * filelock.c: Fix some buffer overrun and integer overflow issues.
4590 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4591 Reformulate so as not to need the command string.
4592 Invoke gzip -cd rather than gunzip, as it's more portable.
4593 (lock_info_type, lock_file_1, lock_file):
4594 Don't assume pid_t and time_t fit in unsigned long.
4595 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4596 (current_lock_owner): Prefer signed type for sizes.
4597 Use memcpy, not strncpy, where memcpy is what is really wanted.
4598 Don't assume (via atoi) that time_t and pid_t fit in int.
4599 Check for time_t and/or pid_t out of range, e.g., via a network share.
4600 Don't alloca where an auto var works fine.
4602 * fileio.c: Fix some integer overflow issues.
4603 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4604 Don't assume string length fits in int.
4605 (directory_file_name): Don't assume string length fits in long.
4606 (make_temp_name): Don't assume pid fits in int, or that its print
4607 length is less than 20.
4609 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4611 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4613 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4615 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4616 We prefer signed integers, even for size calculations.
4618 * emacs.c: Don't assume string length fits in 'int'.
4619 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4620 (main): Don't invoke strlen when not needed.
4622 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4623 (XD_DEBUG_MESSAGE): Don't waste a byte.
4625 * callproc.c (getenv_internal_1, getenv_internal)
4627 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4629 * lread.c (invalid_syntax): Omit length argument.
4630 All uses changed. This doesn't fix a bug, but it simplifies the
4631 code away from its former Hollerith-constant appearance, and it's
4632 one less 'int' to worry about when looking at integer-overflow issues.
4633 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4635 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4636 This didn't break anything, but it didn't help either.
4637 It's confusing to put a bogus integer in a place where the actual
4638 value does not matter.
4639 (LIST_END_P): Remove unused macro and its bogus comment.
4640 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4642 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4643 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4645 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4646 We prefer signed types, and the value cannot exceed the EMACS_INT
4647 range anyway (because otherwise the length would not be representable).
4648 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4649 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4650 This avoids a GCC warning when WIDE_EMACS_INT.
4652 * indent.c (sane_tab_width): New function.
4653 (current_column, scan_for_column, Findent_to, position_indentation)
4654 (compute_motion): Use it. This is just for clarity.
4655 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4657 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4659 * lisp.h (lint_assume): New macro.
4660 * composite.c (composition_gstring_put_cache):
4661 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4663 * editfns.c, insdel.c:
4664 Omit unnecessary forward decls, to simplify future changes.
4666 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4668 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4670 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4671 Use much-faster test for byte-length change.
4672 Don't assume string byte-length fits in 'int'.
4673 Check that character arg fits in 'int'.
4674 (mapcar1): Declare byte as byte, for clarity.
4676 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4678 * fns.c (concat): Catch string overflow earlier.
4679 Do not rely on integer wraparound.
4681 * dispextern.h (struct it.overlay_strings_charpos)
4682 (struct it.selective): Now EMACS_INT, not int.
4683 * xdisp.c (forward_to_next_line_start)
4684 (back_to_previous_visible_line_start)
4685 (reseat_at_next_visible_line_start, next_element_from_buffer):
4686 Don't arbitrarily truncate the value of 'selective' to int.
4688 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4690 * composite.c: Don't truncate sizes to 'int'.
4691 (composition_gstring_p, composition_reseat_it)
4692 (composition_adjust_point): Use EMACS_INT, not int.
4693 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4694 not EMACS_UINT, for indexes.
4696 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4698 * buffer.c: Include <verify.h>.
4699 (struct sortvec.priority, struct sortstr.priority):
4700 Now EMACS_INT, not int.
4701 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4702 (struct sortstr.size, record_overlay_string)
4703 (struct sortstrlist.size, struct sortlist.used):
4704 Don't truncate size to int.
4705 (record_overlay_string): Check for size-calculation overflow.
4706 (init_buffer_once): Check at compile-time, not run-time.
4708 2011-06-22 Jim Meyering <meyering@redhat.com>
4710 Don't leak an XBM-image-sized buffer
4711 * image.c (xbm_load): Free the image buffer after using it.
4713 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4716 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4717 that Sun C diagnosed.
4718 * fns.c (secure_hash): Fix pointer signedness issue.
4719 * intervals.c (static_offset_intervals): New function.
4720 (offset_intervals): Use it.
4722 2011-06-21 Leo Liu <sdl.web@gmail.com>
4725 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4728 * fns.c (secure_hash): Rename from crypto_hash_function and change
4729 the first arg to accept symbols.
4730 (Fsecure_hash): New primitive.
4731 (syms_of_fns): New symbols.
4733 2011-06-20 Deniz Dogan <deniz@dogan.se>
4735 * process.c (Fset_process_buffer): Clarify return value in
4738 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4740 * dispnew.c (add_window_display_history): Use BVAR.
4742 * xdisp.c (debug_method_add): Use BVAR.
4743 (check_window_end, dump_glyph_matrix, dump_glyph)
4744 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4746 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4749 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4750 check till after the cache is created in init_frame_faces.
4752 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4754 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4756 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4758 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4759 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4760 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4762 Improve buffer-overflow checking (Bug#8873).
4763 * fileio.c (Finsert_file_contents):
4764 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4765 Remove the old (too-loose) buffer overflow checks.
4766 They weren't needed, since make_gap checks for buffer overflow.
4767 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4768 The old code merely checked for Emacs fixnum overflow, and relied
4769 on undefined (wraparound) behavior. The new code avoids undefined
4770 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4772 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4773 Tune. Don't use wider integers than needed. Don't use alloca.
4774 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4776 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4778 * insdel.c, lisp.h (buffer_overflow): New function.
4779 (insert_from_buffer_1, replace_range, replace_range_2):
4780 * insdel.c (make_gap_larger):
4781 * editfns.c (Finsert_char):
4782 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4784 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4786 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4788 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4790 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4791 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4793 * fileio.c: Don't assume EMACS_INT fits in off_t.
4794 (emacs_lseek): New static function.
4795 (Finsert_file_contents, Fwrite_region): Use it.
4796 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4798 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4800 * fns.c: Don't overflow int when computing a list length.
4801 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4802 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4803 truncation on 64-bit hosts. Check for QUIT every
4804 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4805 faster and is responsive enough.
4806 (Flength): Report an error instead of overflowing an integer.
4807 (Fsafe_length): Return a float if the value is not representable
4808 as a fixnum. This shouldn't happen except in contrived situations.
4809 (Fnthcdr, Fsort): Don't assume list length fits in int.
4810 (Fcopy_sequence): Don't assume vector length fits in int.
4812 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4813 (header_size, word_size): New constants.
4814 (allocate_vectorlike): Don't check size overflow here.
4815 (allocate_vector): Check it here instead, since this is the only
4816 caller of allocate_vectorlike that could cause overflow.
4817 Check that the new vector's length is representable as a fixnum.
4819 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4820 The previous code was bogus. For example, next_almost_prime (32)
4821 returned 39, which is undesirable as it is a multiple of 3; and
4822 next_almost_prime (24) returned 25, which is a multiple of 5 so
4823 why was the code bothering to check for multiples of 7?
4825 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4827 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4829 Variadic C functions now count arguments with ptrdiff_t.
4830 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4831 Back then I didn't know that the Emacs coding style prefers signed int.
4832 Also, in the meantime I found a few more instances where arguments
4833 were being counted with int, which may truncate counts on 64-bit
4834 machines, or EMACS_INT, which may be unnecessarily wide.
4835 * lisp.h (struct Lisp_Subr.function.aMANY)
4836 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4837 Arg counts are now ptrdiff_t, not size_t.
4838 All variadic functions and their callers changed accordingly.
4839 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4840 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4841 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4842 * callint.c (Fcall_interactively): Check arg count for overflow,
4843 to avoid potential buffer overrun. Use signed char, not 'int',
4844 for 'varies' array, so that we needn't bother to check its size
4845 calculation for overflow.
4846 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4847 * eval.c (apply_lambda):
4848 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4849 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4850 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4852 * callint.c (Fcall_interactively): Don't use index var as event count.
4854 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4855 * mem-limits.h (SIZE): Remove; no longer used.
4857 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4859 Remove unnecessary casts.
4860 * xterm.c (x_term_init):
4861 * xfns.c (x_set_border_pixel):
4862 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4863 These aren't needed now that we assume ANSI C.
4865 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4866 It's more likely to cause problems (due to unsigned overflow)
4869 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4871 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4873 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4875 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4877 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4879 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4881 GLYPH_CODE_FACE returns EMACS_INT, not int.
4882 * dispextern.h (merge_faces):
4883 * xfaces.c (merge_faces):
4884 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4885 Don't assume EMACS_INT fits in int.
4887 * character.h (CHAR_VALID_P): Remove unused parameter.
4888 * fontset.c, lisp.h, xdisp.c: All uses changed.
4890 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4892 * fns.c (concat): Minor tuning based on overflow analysis.
4893 This doesn't fix any bugs. Use int to hold character, instead
4894 of constantly refetching from Emacs object. Use XFASTINT, not
4895 XINT, for value known to be a character. Don't bother comparing
4896 a single byte to 0400, as it's always less.
4898 * floatfns.c (Fexpt):
4899 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4901 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4904 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4906 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4907 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4908 incorrectly succeed when S was a string, because 4294967386 was
4909 truncated before it was used.
4911 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4912 Otherwise, an out-of-range integer could cause undefined behavior
4915 * composite.c: Use int, not EMACS_INT, for characters.
4916 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4917 EMACS_INT, for values that are known to be in character range.
4918 This doesn't fix any bugs but is the usual style inside Emacs and
4919 may generate better code on 32-bit machines.
4921 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4922 This is for reasons similar to the recent CHAR_STRING fix.
4923 * charset.c (Fencode_char): Check that character arg is actually
4924 a character. Pass an int to ENCODE_CHAR.
4925 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4926 wider than 'int', as a compile-time check to prevent future regressions
4929 * character.c (char_string): Remove unnecessary casts.
4931 Make sure a 64-bit char is never passed to CHAR_STRING.
4932 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4933 by silently ignoring the top 32 bits, allowing some values
4934 that were far too large to be valid characters.
4935 * character.h: Include <verify.h>.
4936 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4937 arguments are no wider than unsigned, as a compile-time check
4938 to prevent future regressions in this area.
4940 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4941 (Fsubst_char_in_region):
4943 * xdisp.c (decode_mode_spec_coding):
4944 Adjust to CHAR_STRING's new requirement.
4945 * editfns.c (Finsert_char, Fsubst_char_in_region):
4946 * fns.c (concat): Check that character args are actually
4947 characters. Without this test, these functions did the wrong
4948 thing with wildly out-of-range values on 64-bit hosts.
4950 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4951 These casts should not be needed on 32-bit hosts, either.
4952 * keyboard.c (read_char):
4953 * lread.c (Fload): Remove casts to unsigned.
4955 * lisp.h (UNSIGNED_CMP): New macro.
4956 This fixes comparison bugs on 64-bit hosts.
4957 (ASCII_CHAR_P): Use it.
4958 * casefiddle.c (casify_object):
4959 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4960 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4961 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4962 * dispextern.h (FACE_FROM_ID):
4963 * keyboard.c (read_char): Use UNSIGNED_CMP.
4965 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4966 not to EMACS_INT, to avoid GCC warning.
4968 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4970 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4971 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4972 isn't needed on 32-bit machines.
4974 * buffer.c (Fgenerate_new_buffer_name):
4975 Use EMACS_INT for count, not int.
4976 (advance_to_char_boundary): Return EMACS_INT, not int.
4978 * data.c (Qcompiled_function): Now static.
4980 * window.c (window_body_lines): Now static.
4982 * image.c (gif_load): Rename local to avoid shadowing.
4984 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4985 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4986 * alloc.c (make_save_value): Integer argument is now of type
4988 (mark_object): Use ptrdiff_t, not int.
4989 * lisp.h (pD): New macro.
4990 * print.c (print_object): Use it.
4992 * alloc.c: Use EMACS_INT, not int, to count objects.
4993 (total_conses, total_markers, total_symbols, total_vector_size)
4994 (total_free_conses, total_free_markers, total_free_symbols)
4995 (total_free_floats, total_floats, total_free_intervals)
4996 (total_intervals, total_strings, total_free_strings):
4997 Now EMACS_INT, not int. All uses changed.
4998 (Fgarbage_collect): Compute overall total using a double, so that
4999 integer overflow is less likely to be a problem. Check for overflow
5000 when converting back to an integer.
5001 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5002 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5003 These were 'int' variables that could overflow on 64-bit hosts;
5004 they were never used, so remove them instead of repairing them.
5005 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5006 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5007 Previously, this ceilinged at INT_MAX, but that doesn't work on
5009 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5011 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5012 (allocate_vectorlike): Check for ptrdiff_t overflow.
5013 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5014 when a (possibly-narrower) signed value would do just as well.
5015 We prefer using signed arithmetic, to avoid comparison confusion.
5017 * alloc.c: Catch some string size overflows that we were missing.
5018 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5019 for convenience in STRING_BYTES_MAX.
5020 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5021 The definition here is exact; the one in lisp.h was approximate.
5022 (allocate_string_data): Check for string overflow. This catches
5023 some instances we weren't catching before. Also, it catches
5024 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5025 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5026 and ptrdiff_t and EMACS_INT are both 64 bits.
5028 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5029 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5030 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5032 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5034 * alloc.c (Fmake_string): Check for out-of-range init.
5036 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5038 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5040 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5042 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5043 xg_get_default_scrollbar_width.
5045 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5046 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5047 (style_changed_cb): Call update_theme_scrollbar_width and call
5048 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5049 all frames (Bug#8505).
5050 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5051 Call gtk_window_set_resizable if HAVE_GTK3.
5052 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5053 and height if HAVE_GTK3 (Bug#8505).
5054 (scroll_bar_width_for_theme): New variable.
5055 (update_theme_scrollbar_width): New function.
5056 (xg_get_default_scrollbar_width): Move code to
5057 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5058 (xg_initialize): Call update_theme_scrollbar_width.
5060 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5062 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5064 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5066 * frame.c (make_frame): Call other_buffer_safely instead of
5069 * window.c (temp_output_buffer_show): Call display_buffer with
5070 second argument Vtemp_buffer_show_specifiers and reset latter
5071 immediately after the call.
5072 (Vtemp_buffer_show_specifiers): New variable.
5073 (auto_window_vscroll_p, next_screen_context_lines)
5074 (Vscroll_preserve_screen_position): Remove leading asterisks from
5077 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5079 Fix minor problems found by GCC 4.6.0 static checking.
5080 * buffer.c (Qclone_number): Remove for now, as it's unused.
5081 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5082 (record_buffer): Remove unused local.
5083 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5084 (set_frame_buffer_list): Remove; unused.
5085 * frame.h (other_visible_frames): Remove decl.
5086 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5087 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5088 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5090 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5091 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5092 Define only if HAVE_GPM.
5093 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5094 (update_hints_inhibit): Remove; never set. All uses removed.
5095 * widgetprv.h (emacsFrameClassRec): Remove decl.
5096 * window.c (delete_deletable_window): Now returns void, since it
5097 wasn't returning anything.
5098 (compare_window_configurations): Remove unused locals.
5099 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5100 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5101 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5102 the same widths as pointers. This follows up on the 2011-05-06 patch.
5103 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5104 * xterm.h: Likewise.
5105 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5107 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5109 * makefile.w32-in: Update dependencies.
5110 (LISP_H): Add lib/intprops.h.
5112 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5114 * image.c (gif_load): Add animation frame delay to the metadata.
5115 (syms_of_image): Use DEFSYM. New symbol `delay'.
5117 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5119 * window.c (delete_deletable_window): Re-add.
5120 (Fset_window_configuration): Rewrite to handle dead buffers and
5121 consequently deletable windows.
5122 (window_tree, Fwindow_tree): Remove. Supply functionality in
5124 (compare_window_configurations): Simplify code.
5126 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5128 * image.c (imagemagick_load_image): Fix type mismatch.
5129 (Fimagemagick_types): Likewise.
5131 * window.h (replace_buffer_in_windows): Declare.
5133 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5135 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5136 Qclone_number. Remove external declaration of Qdelete_window.
5137 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5139 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5140 Run Qbuffer_list_update_hook if allowed.
5141 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5142 buffer list implementation.
5143 (other_buffer_safely): New function.
5144 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5145 calls to replace_buffer_in_windows and
5146 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5148 (record_buffer): Inhibit quitting and rewrite using quittable
5149 functions. Run Qbuffer_list_update_hook if allowed.
5150 (Frecord_buffer, Funrecord_buffer): New functions.
5151 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5152 Move switch-to-buffer to window.el.
5153 (bury-buffer): Move to window.el.
5154 (Vbuffer_list_update_hook): New variable.
5156 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5159 * window.h (resize_frame_windows): Move up in code.
5160 (Fwindow_frame): Remove EXFUN.
5161 (replace_buffer_in_all_windows): Remove prototype.
5162 (replace_buffer_in_windows_safely): Add prototype.
5164 * window.c: Declare Qdelete_window static again. Move down
5165 declaration of select_count.
5166 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5167 (Fother_window): Move to window.el.
5168 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5169 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5170 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5172 (replace_buffer_in_windows): Implement by calling
5173 Qreplace_buffer_in_windows.
5174 (replace_buffer_in_all_windows): Remove with some functionality
5175 moved into replace_buffer_in_windows_safely.
5176 (replace_buffer_in_windows_safely): New function.
5177 (select_window_norecord, select_frame_norecord): Move in front
5178 of run_window_configuration_change_hook. Remove now obsolete
5180 (Fset_window_buffer): Rewrite doc-string.
5181 Call Qrecord_window_buffer.
5182 (keys_of_window): Move binding for other-window to window.el.
5184 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5186 * dispextern.h (struct image): Replace data member, whose int_val
5187 and ptr_val fields were not used by anything, with a single
5190 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5191 (gif_clear_image, gif_load, imagemagick_load_image)
5192 (gs_clear_image, gs_load): Callers changed.
5194 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5196 * buffer.h: Include <time.h>, for time_t.
5197 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5199 Fix minor problems found by static checking.
5201 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5203 Make identifiers static if they are not used in other modules.
5204 * data.c (Qcompiled_function, Qframe, Qvector):
5205 * image.c (QimageMagick, Qsvg):
5206 * minibuf.c (Qmetadata):
5207 * window.c (resize_window_check, resize_root_window): Now static.
5208 * window.h (resize_window_check, resize_root_window): Remove decls.
5210 * window.c (window_deletion_count, delete_deletable_window):
5212 (window_body_lines): Now static.
5213 (Fdelete_other_windows_internal): Mark vars as initialized.
5214 Make sure 'resize_failed' is initialized.
5215 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5216 (resize_window_apply): Remove unused local.
5217 * window.h (delete_deletable_window): Remove decl.
5219 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5220 (imagemagick_load_image): Fix pointer signedness problem by changing
5221 last arg from unsigned char * to char *. All uses changed.
5222 Also, fix a local for similar reasons.
5223 Remove unused locals. Remove locals to avoid shadowing.
5224 (fn_rsvg_handle_free): Remove; unused.
5225 (svg_load, svg_load_image): Fix pointer signedness problem.
5226 (imagemagick_load_image): Don't use garbage pointer image_wand.
5228 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5230 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5232 * image.c (gif_load): Fix omitted cast error introduced by
5235 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5237 * window.h (resize_proportionally, orig_total_lines)
5238 (orig_top_line): Remove from window structure.
5239 (set_window_height, set_window_width, change_window_heights)
5240 (Fdelete_window): Remove prototypes.
5241 (resize_frame_windows): Remove duplicate declaration.
5243 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5245 * window.h (resize_frame_windows, resize_window_check)
5246 (delete_deletable_window, resize_root_window)
5247 (resize_frame_windows): Declare prototypes.
5249 * window.c (resize_window_apply): Make definition be "static" to
5250 match the prototype.
5252 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5254 * window.c: Remove declarations of Qwindow_size_fixed,
5255 window_min_size_1, window_min_size_2, window_min_size,
5256 size_window, window_fixed_size_p, enlarge_window, delete_window.
5257 Remove static from declaration of Qdelete_window, it's
5258 temporarily needed by Fbury_buffer.
5259 (replace_window): Don't assign orig_top_line and
5261 (Fdelete_window, delete_window): Remove. Window deletion is
5262 handled by window.el.
5263 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5264 Replace Fdelete_window calls with calls to Qdelete_window.
5265 (Fdelete_other_windows): Remove. Deleting other windows is
5266 handled by window.el.
5267 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5268 handled in window.el.
5269 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5270 Window minimum sizes are handled in window.el.
5271 (shrink_windows, size_window, set_window_height)
5272 (set_window_width, change_window_heights, window_height)
5273 (window_width, CURBEG, CURSIZE, enlarge_window)
5274 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5275 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5276 handled in window.el.
5277 (make_dummy_parent): Rename to make_parent_window and give it a
5278 second argument horflag.
5279 (make_window): Don't set resize_proportionally any more.
5280 (Fsplit_window): Remove. Windows are split in window.el.
5281 (save_restore_action, save_restore_orig_size)
5282 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5283 Resize mini windows in window.el.
5284 (grow_mini_window, shrink_mini_window): Implement by calling
5285 Qresize_root_window_vertically, resize_window_check and
5286 resize_window_apply.
5287 (saved_window, Fset_window_configuration, save_window_save):
5288 Do not handle orig_top_line, orig_total_lines, and
5289 resize_proportionally.
5290 (window_min_height, window_min_width): Move to window.el.
5291 (keys_of_window): Move bindings for delete-other-windows,
5292 split-window, delete-window and enlarge-window to window.el.
5294 * buffer.c: Temporarily extern Qdelete_window.
5295 (Fbury_buffer): Temporarily call Qdelete_window instead of
5296 Fdelete_window (Fbury_buffer will move to window.el soon).
5298 * frame.c (set_menu_bar_lines_1): Remove code handling
5299 orig_top_line and orig_total_lines.
5301 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5302 set_window_height but set heights directly.
5303 (change_frame_size_1): Use resize_frame_windows.
5305 * xdisp.c (init_xdisp): Don't use set_window_height but set
5308 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5309 Use resize_frame_windows instead of change_window_heights and run
5310 run_window_configuration_change_hook.
5312 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5313 instead of change_window_heights and run
5314 run_window_configuration_change_hook.
5316 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5318 * window.c (replace_window): Rename second argument REPLACEMENT to
5319 NEW. New third argument SETFLAG. Rewrite.
5320 (delete_window, make_dummy_parent): Call replace_window with
5322 (window_list_1): Move down in code.
5323 (run_window_configuration_change_hook): Move set_buffer part
5324 before select_frame_norecord part in order to unwind correctly.
5325 Rename count1 to count.
5326 (recombine_windows, delete_deletable_window, resize_root_window)
5327 (Fdelete_other_windows_internal)
5328 (Frun_window_configuration_change_hook, make_parent_window)
5329 (resize_window_check, resize_window_apply, Fresize_window_apply)
5330 (resize_frame_windows, Fsplit_window_internal)
5331 (Fdelete_window_internal, Fresize_mini_window_internal):
5333 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5335 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5337 * window.h (window): Add some new members to window structure -
5338 normal_lines, normal_cols, new_total, new_normal, clone_number,
5339 splits, nest, prev_buffers, next_buffers.
5340 (WINDOW_TOTAL_SIZE): Move here from window.c.
5341 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5343 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5345 (make_dummy_parent): Set new members of windows structure.
5346 (make_window): Move down in code. Handle new members of window
5348 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5349 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5350 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5351 (Fset_window_prev_buffers, Fwindow_next_buffers)
5352 (Fset_window_next_buffers, Fset_window_clone_number):
5354 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5355 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5357 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5358 Argument WINDOW can be now internal window too.
5359 (Fwindow_use_time): Move up in code.
5360 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5362 (Fset_window_configuration, saved_window)
5363 (Fcurrent_window_configuration, save_window_save): Handle new
5364 members of window structure.
5365 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5366 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5367 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5368 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5369 Qget_mru_window, Qresize_root_window,
5370 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5371 Qauto_buffer_name; staticpro them.
5373 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5375 * window.c (Fwindow_total_size, Fwindow_left_column)
5376 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5377 (Fwindow_list_1): New functions.
5378 (window_box_text_cols): Replace with window_body_cols.
5379 (Fwindow_width, Fscroll_left, Fscroll_right):
5380 Use window_body_cols instead of window_box_text_cols.
5381 (delete_window, Fset_window_configuration):
5382 Call delete_all_subwindows with window as argument.
5383 (delete_all_subwindows): Take a window as argument and not a
5385 (window_loop): Remove handling of GET_LRU_WINDOW and
5387 (Fget_lru_window, Fget_largest_window): Move to window.el.
5389 * window.h: Extern window_body_cols instead of
5390 window_box_text_cols. delete_all_subwindows now takes a
5391 Lisp_Object as argument.
5393 * indent.c (compute_motion, Fcompute_motion):
5394 Use window_body_cols instead of window_box_text_cols.
5396 * frame.c (delete_frame): Call delete_all_subwindows with root
5399 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5401 * fns.c (Fputhash): Document return value.
5403 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5405 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5407 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5409 Cons<->int and similar integer overflow fixes (Bug#8794).
5411 Check for overflow when converting integer to cons and back.
5412 * charset.c (Fdefine_charset_internal, Fdecode_char):
5413 Use cons_to_unsigned to catch overflow.
5414 (Fencode_char): Use INTEGER_TO_CONS.
5415 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5416 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5417 * data.c (long_to_cons, cons_to_long): Remove.
5418 (cons_to_unsigned, cons_to_signed): New functions.
5419 These signal an error for invalid or out-of-range values.
5420 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5421 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5422 * font.c (Ffont_variation_glyphs):
5423 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5424 * lisp.h: Include <intprops.h>.
5425 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5426 (cons_to_signed, cons_to_unsigned): New decls.
5427 (long_to_cons, cons_to_long): Remove decls.
5428 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5429 (Fprimitive_undo): Use CONS_TO_INTEGER.
5430 * xfns.c (Fx_window_property): Likewise.
5431 * xselect.c: Include <limits.h>.
5432 (x_own_selection, selection_data_to_lisp_data):
5433 Use INTEGER_TO_CONS.
5434 (x_handle_selection_request, x_handle_selection_clear)
5435 (x_get_foreign_selection, Fx_disown_selection_internal)
5436 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5437 (lisp_data_to_selection_data): Use cons_to_unsigned.
5438 (x_fill_property_data): Use cons_to_signed.
5439 Report values out of range.
5441 Check for buffer and string overflow more precisely.
5442 * buffer.h (BUF_BYTES_MAX): New macro.
5443 * lisp.h (STRING_BYTES_MAX): New macro.
5444 * alloc.c (Fmake_string):
5445 * character.c (string_escape_byte8):
5446 * coding.c (coding_alloc_by_realloc):
5447 * doprnt.c (doprnt):
5448 * editfns.c (Fformat):
5450 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5451 since they may not be the same number.
5452 * editfns.c (Finsert_char):
5453 * fileio.c (Finsert_file_contents):
5454 Likewise for BUF_BYTES_MAX.
5456 * image.c: Use ptrdiff_t, not int, for sizes.
5457 (slurp_file): Switch from int to ptrdiff_t.
5459 (slurp_file): Check that file size fits in both size_t (for
5460 malloc) and ptrdiff_t (for sanity and safety).
5462 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5463 if b->modtime has its maximal value.
5465 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5467 Don't assume time_t can fit into int.
5468 * buffer.h (struct buffer.modtime): Now time_t, not int.
5469 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5470 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5472 Minor fixes for signed vs unsigned integers.
5473 * character.h (MAYBE_UNIFY_CHAR):
5474 * charset.c (maybe_unify_char):
5475 * keyboard.c (read_char, reorder_modifiers):
5476 XINT -> XFASTINT, since the integer must be nonnegative.
5477 * ftfont.c (ftfont_spec_pattern):
5478 * keymap.c (access_keymap, silly_event_symbol_error):
5479 XUINT -> XFASTINT, since the integer must be nonnegative.
5480 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5481 since it makes no difference and we prefer signed.
5482 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5483 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5486 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5488 * window.h (Fwindow_frame): Declare.
5490 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5492 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5493 (SPARE_MEMORY): Always define.
5494 (LARGE_REQUEST): Remove.
5495 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5497 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5499 * lisp.h: Move EXFUNS for Fframe_root_window,
5500 Fframe_first_window and Fset_frame_selected_window to window.h.
5502 * window.h: Move EXFUNS for Fframe_root_window,
5503 Fframe_first_window and Fset_frame_selected_window here from
5506 * frame.c (Fwindow_frame, Fframe_first_window)
5507 (Fframe_root_window, Fframe_selected_window)
5508 (Fset_frame_selected_window): Move to window.c.
5509 (Factive_minibuffer_window): Move to minibuf.c.
5510 (Fother_visible_frames_p): New function.
5512 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5514 * window.c (decode_window, decode_any_window): Move up in code.
5515 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5516 (inhibit_frame_unsplittable): Remove unused variable.
5517 (Fwindow_buffer): Move up and rewrite doc-string.
5518 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5519 (Fwindow_prev): New functions.
5520 (Fwindow_frame): Move here from frame.c. Accept any window as
5522 (Fframe_root_window, Fframe_first_window)
5523 (Fframe_selected_window): Move here from frame.c. Accept frame
5524 or arbitrary window as argument. Update doc-strings.
5525 (Fminibuffer_window): Move up in code.
5526 (Fwindow_minibuffer_p): Move up in code and simplify.
5527 (Fset_frame_selected_window): Move here from frame.c.
5529 (Fselected_window, select_window, Fselect_window): Move up in
5530 code. Minor doc-string fixes.
5532 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5534 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5535 Do not assume that spare memory exists; that assumption is valid
5536 only if SYSTEM_MALLOC.
5537 (LARGE_REQUEST): New macro, so that the issue of large requests
5538 is separated from the issue of spare memory.
5540 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5542 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5545 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5547 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5550 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5552 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5554 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5556 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5557 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5559 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5561 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5563 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5565 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5566 (x_clipboard_manager_save): Add return value.
5567 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5569 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5570 Obey Vx_select_enable_clipboard_manager. Catch errors in
5571 x_clipboard_manager_save (Bug#8779).
5572 (Vx_select_enable_clipboard_manager): New variable.
5573 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5575 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5577 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5579 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5581 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5582 in the current matrix if keep_current_p is non-zero.
5584 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5586 * bidi.c (bidi_level_of_next_char): Fix last change.
5588 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5590 Support bidi reordering of text covered by display properties.
5592 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5593 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5594 (bidi_cache_search, bidi_cache_iterator_state)
5595 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5596 (bidi_level_of_next_char, bidi_move_to_visually_next):
5597 Support character positions inside a run of characters covered by a
5599 (bidi_paragraph_init, bidi_resolve_explicit_1)
5600 (bidi_level_of_next_char): Call bidi_fetch_char and
5601 bidi_fetch_char_advance instead of FETCH_CHAR and
5603 (bidi_init_it): Initialize new members.
5604 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5606 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5607 instead of using explicit *_CHAR codes.
5608 (bidi_resolve_explicit, bidi_resolve_weak):
5609 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5610 bidirectional text is supported only in multibyte buffers.
5611 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5612 it to initialize the frame_window_p member of struct bidi_it.
5613 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5614 (bidi_resolve_explicit, bidi_resolve_weak)
5615 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5616 bidi_it->nchars is non-positive.
5617 (bidi_level_of_next_char): Don't try to lookup the cache for the
5618 next/previous character if nothing is cached there yet, or if we
5619 were just reseat()'ed to a new position.
5621 * xdisp.c (set_cursor_from_row): Set start and stop points
5622 according to the row's direction when priming the loop that looks
5623 for the glyph on which to display cursor.
5624 (single_display_spec_intangible_p): Function deleted.
5625 (display_prop_intangible_p): Reimplement to call
5626 handle_display_spec instead of single_display_spec_intangible_p.
5627 Accept 3 additional arguments needed by handle_display_spec.
5628 This fixes incorrect cursor motion across display property with complex
5629 values: lists, `(when COND...)' forms, etc.
5630 (single_display_spec_string_p): Support property values that are
5631 lists with the argument STRING its top-level element.
5632 (display_prop_string_p): Fix the condition for processing a
5633 property that is a list to be consistent with handle_display_spec.
5634 (handle_display_spec): New function, refactored from the
5635 last portion of handle_display_prop.
5636 (compute_display_string_pos): Accept additional argument
5637 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5638 value of a `display' property is a "replacing spec".
5639 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5640 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5641 the display property, but just return a value indicating whether
5642 the display property will replace the characters it covers.
5643 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5644 frame_window_p members of struct bidi_it.
5645 (compute_display_string_pos, compute_display_string_end):
5647 (push_it): Accept second argument POSITION, where pop_it should
5648 jump to continue iteration.
5649 (reseat_1): Initialize bidi_it.disp_pos.
5651 * keyboard.c (adjust_point_for_property): Adjust the call to
5652 display_prop_intangible_p to its new signature.
5654 * dispextern.h (struct bidi_it): New member frame_window_p.
5655 (bidi_init_it): Update prototypes.
5656 (display_prop_intangible_p): Update prototype.
5657 (compute_display_string_pos, compute_display_string_end):
5659 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5662 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5664 Malloc failure behavior now depends on size of allocation.
5665 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5666 * lisp.h: Change signatures accordingly.
5667 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5668 All callers changed. (Bug#8762)
5670 * gnutls.c: Use Emacs's memory allocators.
5671 Without this change, the gnutls library would invoke malloc etc.
5672 directly, which causes problems on non-SYNC_INPUT hosts, and which
5673 runs afoul of improving memory_full behavior. (Bug#8761)
5674 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5675 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5676 xfree instead of the default malloc, realloc, free.
5677 (Fgnutls_boot): No need to check for memory allocation failure,
5678 since xmalloc does that for us.
5680 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5681 * category.c (hash_get_category_set):
5682 * ccl.c (ccl_driver):
5683 * charset.c (Fdefine_charset_internal):
5684 * charset.h (struct charset.hash_index):
5685 * composite.c (get_composition_id, gstring_lookup_cache)
5686 (composition_gstring_put_cache):
5687 * composite.h (struct composition.hash_index):
5688 * dispextern.h (struct image.hash):
5689 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5690 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5691 (hashfn_equal, hashfn_user_defined, make_hash_table)
5692 (maybe_resize_hash_table, hash_lookup, hash_put)
5693 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5694 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5695 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5696 * image.c (make_image, search_image_cache, lookup_image)
5697 (xpm_put_color_table_h):
5698 * lisp.h (struct Lisp_Hash_Table):
5699 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5700 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5701 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5702 * alloc.c (allocate_vectorlike):
5703 Check for overflow in vector size calculations.
5704 * ccl.c (ccl_driver):
5705 Check for overflow when converting EMACS_INT to int.
5706 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5707 need to be updated by these changes.
5708 * fns.c (make_hash_table, maybe_resize_hash_table):
5709 Check for integer overflow with large hash tables.
5710 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5711 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5712 (SXHASH_REDUCE): New macro.
5713 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5714 Use it instead of discarding useful hash info with large hash values.
5715 (sxhash_float): New function.
5716 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5717 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5718 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5719 Rewrite to use FIXNUM_BITS, as this simplifies things.
5720 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5721 Adjust signatures to match updated version of code.
5722 (consing_since_gc): Now EMACS_INT, since a single hash table can
5723 use more than INT_MAX bytes.
5725 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5727 Make it possible to build with GCC-4.6+ -O2 -flto.
5729 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5731 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5733 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5734 Call minibuffer-inactive-mode.
5736 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5738 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5739 Update dependencies.
5741 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5743 * data.c (init_data): Remove code for UTS, this system is not
5746 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5748 Don't force ./temacs to start in terminal mode.
5750 * frame.c (make_initial_frame): Initialize faces in all cases, not
5751 only when CANNOT_DUMP is defined.
5752 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5754 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5756 * dispnew.c (add_window_display_history): Use const for the string
5757 pointer. Remove declaration, not needed.
5759 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5761 Use 'inline', not 'INLINE'.
5762 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5763 * alloc.c, fontset.c (INLINE): Remove.
5764 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5765 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5766 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5767 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5768 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5770 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5772 Make it possible to run ./temacs.
5774 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5775 syms_of_callproc does the same thing. Remove test for
5776 "initialized", do it in the caller.
5777 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5779 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5781 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5782 (read_minibuf): Use get_minibuffer.
5783 (syms_of_minibuf): Use DEFSYM.
5784 (Qmetadata): New var.
5785 * data.c (Qbuffer): Don't make it static.
5786 (syms_of_data): Use DEFSYM.
5788 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5790 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5791 (CCL_CODE_MIN): New macro.
5793 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5795 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5797 * eval.c (Qdebug): Now static.
5798 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5799 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5800 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5802 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5804 * image.c: Various fixes to ImageMagick code comments.
5805 (Fimagemagick_types): Doc fix.
5807 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5809 Minor fixes prompted by GCC 4.6.0 warnings.
5811 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5813 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5814 (x_clipboard_manager_save_all): Move extern decl to ...
5815 * xterm.h: ... here, so that it can be checked for consistency.
5817 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5819 * xselect.c (x_clipboard_manager_save_frame)
5820 (x_clipboard_manager_save_all): New functions.
5821 (Fx_clipboard_manager_save): Lisp function deleted.
5823 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5824 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5826 * xterm.h: Update prototype.
5828 2011-05-28 William Xu <william.xwl@gmail.com>
5830 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5833 2011-05-28 Jim Meyering <meyering@redhat.com>
5835 Avoid a sign-extension bug in crypto_hash_function.
5836 * fns.c (to_uchar): Define.
5837 (crypto_hash_function): Use it to convert some newly-signed
5838 variables to unsigned, to avoid sign-extension bugs. For example,
5839 without this change, (md5 "truc") would evaluate to
5840 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5841 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5842 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5844 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5846 Integer overflow fixes.
5848 * dbusbind.c: Serial number integer overflow fixes.
5849 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5850 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5851 to hold a serial number that is too large for a fixnum.
5852 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5853 Check for serial numbers out of range. Decode any serial number
5854 that was so large that it became a float. (Bug#8722)
5856 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5857 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5858 Use XFASTINT rather than XUINT when numbers are nonnegative.
5859 (xd_append_arg, Fdbus_method_return_internal):
5860 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5861 arguments, check that Lisp number is nonnegative, rather than
5862 silently wrapping negative numbers around. (Bug#8722)
5863 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5866 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5868 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5870 ccl: Add integer overflow checks.
5871 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5872 (IN_INT_RANGE): New macros.
5873 (ccl_driver): Use them to check for integer overflow when
5874 decoding a CCL program. Many of the new checks are whether XINT (x)
5875 fits in int; it doesn't always, on 64-bit hosts. The new version
5876 doesn't catch all possible integer overflows, but it's an
5877 improvement. (Bug#8719)
5879 * alloc.c (make_event_array): Use XINT, not XUINT.
5880 There's no need for unsigned here.
5882 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5883 This follows up to the 2011-05-06 change that substituted uintptr_t
5884 for EMACS_INT. This case wasn't caught back then.
5886 Rework Fformat to avoid integer overflow issues.
5887 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5888 now (part of C89). Include <verify.h>.
5889 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5890 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5891 (Fformat): Avoid the prepass trying to compute sizes; it was only
5892 approximate and thus did not catch overflow reliably. Instead, walk
5893 through the format just once, formatting and computing sizes as we go,
5894 checking for integer overflow at every step, and allocating a larger
5895 buffer as needed. Keep track separately whether the format is
5896 multibyte. Keep only the most-recently calculated precision, rather
5897 than them all. Record whether each argument has been converted to
5898 string. Use EMACS_INT, not int, for byte and char and arg counts.
5899 Support field widths and precisions larger than INT_MAX. Avoid
5900 sprintf's undefined behavior with conversion specifications such as %#d
5901 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5902 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5903 formatting out-of-range floating point numbers with int
5906 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5908 * data.c: Avoid integer truncation in expressions involving floats.
5909 * data.c: Include <intprops.h>.
5910 (arith_driver): When there's an integer overflow in an expression
5911 involving floating point, convert the integers to floating point
5912 so that the resulting value does not suffer from catastrophic
5913 integer truncation. For example, on a 64-bit host (* 4
5914 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5915 Do not rely on undefined behavior after integer overflow.
5917 merge count_size_as_multibyte, parse_str_to_multibyte
5918 * character.c, character.h (count_size_as_multibyte):
5919 Rename from parse_str_to_multibyte; all uses changed.
5920 Check for integer overflow.
5921 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5922 since it's now a duplicate of the other. This is more of
5923 a character than a buffer op, so better that it's in character.c.
5924 * fns.c, print.c: Adjust to above changes.
5926 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5928 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5930 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5932 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5933 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5934 (x_clipboard_manager_save): Now static.
5935 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5937 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5938 (crypto_hash_function): Now static.
5939 Fix pointer signedness problems. Avoid unnecessary initializations.
5941 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5943 * termhooks.h (Vselection_alist): Make it terminal-local.
5945 * terminal.c (create_terminal): Initialize it.
5947 * xselect.c: Support for clipboard managers.
5948 (Vselection_alist): Move to termhooks.h as terminal-local var.
5949 (LOCAL_SELECTION): New macro.
5950 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5951 (symbol_to_x_atom): Remove gratuitous arg.
5952 (x_handle_selection_request, lisp_data_to_selection_data)
5953 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5954 (x_own_selection, x_get_local_selection, x_convert_selection):
5955 New arg, specifying work frame. Use terminal-local Vselection_alist.
5956 (some_frame_on_display): Delete unused function.
5957 (Fx_own_selection_internal, Fx_get_selection_internal)
5958 (Fx_disown_selection_internal, Fx_selection_owner_p)
5959 (Fx_selection_exists_p): New optional frame arg.
5960 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5961 (x_handle_selection_clear): Don't treat other terminals with the
5962 same keyboard specially. Use the terminal-local Vselection_alist.
5963 (x_clear_frame_selections): Use Frun_hook_with_args.
5965 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5967 * xterm.h: Add support for those atoms.
5969 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5971 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5972 (converted_selections, conversion_fail_tag): New global variables.
5973 (x_selection_request_lisp_error): Free the above.
5974 (x_get_local_selection): Remove unnecessary code.
5975 (x_reply_selection_request): Args changed; handle arbitrary array
5976 of converted selections stored in converted_selections.
5977 Separate the XChangeProperty and SelectionNotify steps.
5978 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5979 (x_convert_selection): New function.
5980 (x_handle_selection_event): Simplify.
5981 (x_get_foreign_selection): Don't ignore incoming requests while
5982 waiting for an answer; this will fail when we implement
5983 SAVE_TARGETS, and seems unnecessary anyway.
5984 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5985 (Vx_sent_selection_functions): Doc fix.
5987 2011-05-26 Leo Liu <sdl.web@gmail.com>
5989 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5991 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5993 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5995 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5996 for fringe update if it has periodic bitmap.
5997 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5998 and fringe_bitmap_periodic_p.
6000 * fringe.c (get_fringe_bitmap_data): New function.
6001 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6002 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6003 row. Mark glyph row for fringe update if periodicity changed.
6005 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6006 for fringe update unless it has periodic bitmap.
6008 2011-05-25 Kenichi Handa <handa@m17n.org>
6010 * xdisp.c (get_next_display_element): Set correct it->face_id for
6011 a static composition.
6013 2011-05-24 Leo Liu <sdl.web@gmail.com>
6016 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6018 * fns.c (crypto_hash_function, Fsha1): New function.
6019 (Fmd5): Use crypto_hash_function.
6020 (syms_of_fns): Add Ssha1.
6022 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6024 * gnutls.c: Remove unused macros.
6025 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6026 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6027 Remove macros that are defined and never used.
6028 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6030 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6032 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6033 (Fx_get_selection_internal): Minor cleanup.
6034 (Fx_own_selection_internal): Rename arguments for consistency with
6037 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6039 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6041 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6043 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6045 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6047 * dispnew.c (scrolling_window): Don't exclude the case that the
6048 last enabled row in the desired matrix touches the bottom boundary.
6050 2011-05-21 Glenn Morris <rgm@gnu.org>
6052 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6053 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6054 and add some more files.
6056 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6058 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6059 report_file_error introduced by the change from 2011-05-07.
6061 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6063 * systime.h (Time): Define only if emacs is defined.
6064 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6065 where the include path doesn't have X11/X.h by default. See
6066 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6068 2011-05-20 Kenichi Handa <handa@m17n.org>
6070 * composite.c (find_automatic_composition): Fix previous change.
6072 2011-05-20 Glenn Morris <rgm@gnu.org>
6074 * lisp.mk: New file, split from Makefile.in.
6075 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6076 (shortlisp): Remove.
6077 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6079 2011-05-19 Glenn Morris <rgm@gnu.org>
6081 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6082 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6083 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6084 (lisp): Set the order to that of loadup.el.
6085 (shortlisp): Make it a copy of $lisp.
6086 (SOME_MACHINE_LISP): Remove.
6087 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6088 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6090 2011-05-18 Kenichi Handa <handa@m17n.org>
6092 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6093 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6094 (find_automatic_composition): Mostly rewrite for efficiency.
6096 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6098 * makefile.w32-in: Update dependencies.
6100 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6102 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6103 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6105 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6107 Fix some integer overflow issues, such as string length overflow.
6109 * insdel.c (count_size_as_multibyte): Check for string overflow.
6111 * character.c (lisp_string_width): Check for string overflow.
6112 Use EMACS_INT, not int, for string indexes and lengths; in
6113 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6114 the resulting string length overflows an EMACS_INT; instead,
6115 report a string overflow if no precision given. When checking for
6116 precision exhaustion, use a check that cannot possibly have
6117 integer overflow. (Bug#8675)
6118 * character.h (lisp_string_width): Adjust to new signature.
6120 * alloc.c (string_overflow): New function.
6121 (Fmake_string): Use it. This doesn't change behavior, but saves
6122 a few bytes and will simplify future changes.
6123 * character.c (string_escape_byte8): Likewise.
6124 * lisp.h (string_overflow): New decl.
6126 Fixups, following up to the user-interface timestamp change.
6127 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6128 for UI timestamps, instead of unsigned long.
6129 * msdos.c (mouse_get_pos): Likewise.
6130 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6131 * w32gui.h (Time): Define by including "systime.h" rather than by
6132 declaring it ourselves. (Bug#8664)
6134 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6135 * image.c (clear_image_cache): Likewise.
6137 * term.c (term_mouse_position): Don't assume time_t wraparound.
6139 Be more systematic about user-interface timestamps.
6140 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6141 and sometimes 'EMACS_UINT', to represent these timestamps.
6142 This change causes it to use 'Time' uniformly, as that's what X uses.
6143 This makes the code easier to follow, and makes it easier to catch
6144 integer overflow bugs such as Bug#8664.
6145 * frame.c (Fmouse_position, Fmouse_pixel_position):
6146 Use Time, not unsigned long, for user-interface timestamps.
6147 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6148 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6149 * keyboard.h (last_event_timestamp): Likewise.
6150 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6151 * menu.h (xmenu_show): Likewise.
6152 * term.c (term_mouse_position): Likewise.
6153 * termhooks.h (struct input_event.timestamp): Likewise.
6154 (struct terminal.mouse_position_hook): Likewise.
6155 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6156 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6157 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6158 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6160 * menu.h, termhooks.h: Include "systime.h", for Time.
6162 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6163 Don't assume that the difference between two unsigned long values
6164 can fit into an integer. At this point, we know button_down_time
6165 <= event->timestamp, so the difference must be nonnegative, so
6166 there's no need to cast the result if double-click-time is
6167 nonnegative, as it should be; check that it's nonnegative, just in
6168 case. This bug is triggered when events are more than 2**31 ms
6169 apart (about 25 days). (Bug#8664)
6171 * xselect.c (last_event_timestamp): Remove duplicate decl.
6172 (x_own_selection): Remove needless cast to unsigned long.
6174 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6175 that always fit in int. Use a sentinel instead of a counter, to
6176 avoid a temp and to allay GCC's concerns about possible int overflow.
6177 * frame.h (struct frame): Use int for menu_bar_items_used
6178 instead of EMACS_INT, since it always fits in int.
6180 * menu.c (grow_menu_items): Check for int overflow.
6182 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6184 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6185 Before, the code was not consistent. These values cannot exceed
6186 2**31 - 1 so there's no need to make them unsigned.
6187 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6188 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6189 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6191 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6193 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6194 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6195 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6196 presumably because the widths might not match.
6198 * window.c (size_window): Avoid needless test at loop start.
6200 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6202 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6204 2011-05-12 Drew Adams <drew.adams@oracle.com>
6206 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6208 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6210 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6211 `width' to `bar_area_x' and `bar_area_width', respectively.
6212 (x_scroll_run): Take account of fringe background extension.
6214 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6215 Rename local vars `left' and `width' to `bar_area_x' and
6216 `bar_area_width', respectively.
6217 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6218 background extension.
6220 2011-05-10 Jim Meyering <meyering@redhat.com>
6222 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6224 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6226 * image.c (Finit_image_library): Return t for built-in image types,
6227 like pbm and xbm. (Bug#8640)
6229 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6231 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6233 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6235 * w32console.c (Fset_screen_color): Doc fix.
6236 (Fget_screen_color): New function.
6237 (syms_of_ntterm): Defsubr it.
6239 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6240 unlink the temporary file if Fcall_process didn't create it in the
6242 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6243 child process will be redirected to a file specified with `:file'.
6244 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6245 cue to call_process_cleanup not to close that handle.
6247 2011-05-07 Ben Key <bkey76@gmail.com>
6249 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6250 one of two shell specific rules, either bootstrap-temacs-CMD or
6251 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6252 to the previous implementation of the bootstrap-temacs rule.
6253 The bootstrap-temacs-CMD rule is similar to the previous
6254 implementation of the bootstrap-temacs rule except that it
6255 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6258 These changes, along with some changes to nt/configure.bat,
6259 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6260 earlier fix to add support for --cflags and --ldflags options
6261 that include quotes so that it works whether make uses cmd or
6264 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6266 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6267 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6269 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6270 a string. Handle both cases.
6271 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6272 (Fdbus_register_method): Use Qinvalid_function.
6274 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6276 * makefile.w32-in: Update dependencies.
6277 (LISP_H): Add inttypes.h and stdin.h.
6278 (PROCESS_H): Add unistd.h.
6280 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6282 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6283 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6285 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6287 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6289 * term.c (vfatal): Remove stray call to va_end.
6290 It's not needed and the C Standard doesn't allow it here anyway.
6292 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6293 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6295 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6298 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6302 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6304 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6306 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6308 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6309 * charset.c (Fdefine_charset_internal): Don't initialize
6310 charset.code_space[15]. The value was garbage, on hosts with
6311 32-bit int (Bug#8600).
6313 * lread.c (read_integer): Be more consistent with string-to-number.
6314 Use string_to_number to do the actual conversion; this avoids
6315 rounding errors and fixes some other screwups. Without this fix,
6316 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6317 (digit_to_number): Move earlier, for benefit of read_integer.
6318 Return -1 if the digit is out of range for the base, -2 if it is
6319 not a digit in any supported base. (Bug#8602)
6321 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6323 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6324 to match comment at start of function. This also removes a
6325 GCC warning about overflow in a 32+64-bit port.
6327 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6329 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6330 Reported by Stefan Monnier in
6331 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6332 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6333 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6335 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6336 (EMACS_UINTPTR): Likewise, with uintptr_t.
6338 * lisp.h: Prefer 64-bit EMACS_INT if available.
6339 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6340 on 32-bit hosts that have 64-bit int, so that they can access
6342 However, temporarily disable this change unless the temporary
6343 symbol WIDE_EMACS_INT is defined.
6345 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6347 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6348 This removes an assumption that EMACS_INT and long are the same
6349 width as pointers. The assumption is true for Emacs porting targets
6350 now, but we want to make other targets possible.
6351 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6352 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6353 In the rest of the code, change types of integers that hold casted
6354 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6355 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6356 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6357 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6358 No need to cast type when ORing.
6359 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6360 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6361 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6362 assume EMACS_INT is the same width as char *.
6363 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6364 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6365 Remove no-longer-needed casts.
6366 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6367 (xg_tool_bar_help_callback, xg_make_tool_item):
6368 Use EMACS_INTPTR to hold an integer
6369 that will be cast to void *; this can avoid a GCC warning
6370 if EMACS_INT is not the same width as void *.
6371 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6372 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6373 (current_message_1, set_message_1):
6374 Use a local to convert to proper width without a cast.
6375 * xmenu.c (dialog_selection_callback): Likewise.
6377 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6378 Also, don't assume VALBITS / RAND_BITS is less than 5,
6379 and don't rely on undefined behavior when shifting a 1 left into
6381 * lisp.h (get_random): Change signature to match.
6383 * lread.c (hash_string): Use size_t, not int, for hash computation.
6384 Normally we prefer signed values; but hashing is special, because
6385 it's better to use unsigned division on hash table sizes so that
6386 the remainder is nonnegative. Also, size_t is the natural width
6387 for hashing into memory. The previous code used 'int', which doesn't
6388 retain enough info to hash well into very large tables.
6389 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6391 * dbusbind.c: Don't possibly lose pointer info when converting.
6392 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6393 Use XPNTR rather than XHASH, so that the high-order bits of
6394 the pointer aren't lost when converting through void *.
6396 * eval.c (Fautoload): Don't double-shift a pointer.
6398 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6400 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6402 * gnutls.c (DEF_GNUTLS_FN):
6403 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6405 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6407 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6410 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6412 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6413 New version that can reserve upto 2GB of heap space.
6415 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6417 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6419 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6421 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6422 `gnutls_certificate_set_x509_key_file'.
6424 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6426 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6427 Update dependencies.
6429 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6431 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6432 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6433 Remove unused parameter `fildes'.
6434 * process.c (read_process_output, send_process): Don't pass it.
6436 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6438 Fix previous change: the library cache is defined in w32.c.
6439 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6440 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6442 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6444 Implement dynamic loading of GnuTLS on Windows.
6446 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6447 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6448 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6451 * gnutls.c (Qgnutls_dll): Define.
6452 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6453 (gnutls_*): Declare function pointers.
6454 (init_gnutls_functions): New function to initialize function pointers.
6455 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6456 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6458 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6459 (emacs_gnutls_write, emacs_gnutls_read)
6460 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6461 (Fgnutls_available_p): New function.
6462 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6463 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6464 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6466 * image.c: Include w32.h.
6467 (Vimage_type_cache): Delete.
6468 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6469 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6470 (w32_delayed_load): Move to w32.c.
6472 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6474 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6475 (w32_delayed_load): Move from image.c. When loading a library, record
6476 its filename in the :loaded-from property of the library id.
6477 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6478 Initialize and staticpro them.
6479 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6481 * process.c: Include lisp.h before w32.h, not after.
6482 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6483 instead of gnutls_record_check_pending.
6485 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6487 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6489 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6490 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6493 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6495 * xterm.c (x_set_frame_alpha): Do not set property on anything
6496 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6498 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6500 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6502 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6504 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6505 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6506 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6507 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6508 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6509 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6510 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6511 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6512 (Qgnutls_bootprop_callbacks_verify): Make static.
6514 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6516 * callproc.c: Indentation fixup.
6518 * sysdep.c (wait_for_termination_1): Make static.
6519 (wait_for_termination, interruptible_wait_for_termination):
6520 Move after wait_for_termination_1.
6522 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6524 * sysdep.c (interruptible_wait_for_termination): New function
6525 which is like wait_for_termination, but allows keyboard
6528 * callproc.c (Fcall_process): Add (:file "file") as an option for
6530 (Fcall_process_region): Ditto.
6532 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6534 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6535 rather than `XVECTOR (FOO)->size'.
6537 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6538 inttypes.h, as a gnulib replacement is used if it not available in
6541 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6543 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6544 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6545 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6547 * coding.c (coding_alloc_by_realloc): Error out if destination
6548 will grow beyond MOST_POSITIVE_FIXNUM.
6549 (decode_coding_emacs_mule): Abort if there isn't enough place in
6550 charbuf for the composition carryover bytes. Reserve an extra
6551 space for up to 2 characters produced in a loop.
6552 (decode_coding_iso_2022): Abort if there isn't enough place in
6553 charbuf for the composition carryover bytes.
6555 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6557 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6558 aborting when %lld or %lll format is passed.
6559 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6560 %llo or %llx format is passed. (Bug#8545)
6562 * window.c (window_scroll_line_based): Use a marker instead of
6563 simple variables to record original value of point. (Bug#7952)
6565 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6566 produced by %s or %c overflows available buffer space. (Bug#8545)
6568 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6570 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6571 (SIZE_MAX): Move defn after all includes, as they might #define it.
6573 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6575 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6577 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6579 * keyboard.c (Qdelayed_warnings_hook): Define.
6580 (command_loop_1): Run `delayed-warnings-hook'
6581 if Vdelayed_warnings_list is non-nil.
6582 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6583 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6585 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6587 * doprnt.c (doprnt): Don't return value smaller than the buffer
6588 size if the message was truncated. (Bug#8545).
6590 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6592 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6593 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6595 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6597 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6599 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6601 * makefile.w32-in: Update dependencies.
6603 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6605 Improve `doprnt' and its usage. (Bug#8545)
6606 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6607 `format_end'. Remove support for %l as a conversion specifier.
6608 Don't use xrealloc. Improve diagnostics when the %l size modifier
6609 is used. Update the commentary.
6611 * eval.c (verror): Simplify calculation of size_t.
6613 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6616 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6618 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6621 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6623 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6624 This makes this file independent of the recent pseudovector change.
6626 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6628 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6630 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6631 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6632 Remove unused local.
6633 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6635 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6636 GCC 4.6.0 optimizes based on type-based alias analysis.
6637 For example, if b is of type struct buffer * and v of type struct
6638 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6639 != &v->size, and therefore "v->size = 1; b->size = 2; return
6640 v->size;" must therefore return 1. This assumption is incorrect
6641 for Emacs, since it type-puns struct Lisp_Vector * with many other
6642 types. To fix this problem, this patch adds a new type struct
6643 vectorlike_header that documents the constraints on layout of vectors
6644 and pseudovectors, and helps optimizing compilers not get fooled
6645 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6646 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6647 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6649 (XSETPVECTYPE): Rewrite in terms of new macro.
6650 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6651 This is a bit clearer, and further avoids the possibility of
6652 undesirable aliasing.
6653 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6654 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6655 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6656 since Lisp_Subr is a special case (no "next" field).
6657 (ASIZE): Now uses header.size rather than size.
6658 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6659 to avoid the hassle of writing XVECTOR (foo)->header.size.
6660 (struct vectorlike_header): New type.
6661 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6662 object, to help avoid aliasing.
6663 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6664 (SUBRP): Likewise, since Lisp_Subr is a special case.
6665 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6666 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6667 (struct Lisp_Hash_Table): Combine first two members into a single
6668 struct vectorlike_header member. All uses of "size" and "next" members
6669 changed to be "header.size" and "header.next".
6670 * buffer.h (struct buffer): Likewise.
6671 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6672 * frame.h (struct frame): Likewise.
6673 * process.h (struct Lisp_Process): Likewise.
6674 * termhooks.h (struct terminal): Likewise.
6675 * window.c (struct save_window_data, struct saved_window): Likewise.
6676 * window.h (struct window): Likewise.
6677 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6678 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6679 * buffer.c (init_buffer_once): Likewise.
6680 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6682 * process.c (Fformat_network_address): Use local var for size,
6685 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6687 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6688 * data.c (atof): Remove decl; no longer used or needed.
6689 (digit_to_number): Move to lread.c.
6690 (Fstring_to_number): Use new string_to_number function, to be
6691 consistent with how the Lisp reader treats infinities and NaNs.
6692 Do not assume that floating-point numbers represent EMACS_INT
6693 without losing information; this is not true on most 64-bit hosts.
6694 Avoid double-rounding errors, by insisting on integers when
6695 parsing non-base-10 numbers, as the documentation specifies.
6696 * lisp.h (string_to_number): New decl, replacing ...
6697 (isfloat_string): Remove.
6698 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6699 (read1): Do not accept +. and -. as integers; this
6700 appears to have been a coding error. Similarly, do not accept
6701 strings like +-1e0 as floating point numbers. Do not report
6702 overflow for integer overflows unless the base is not 10 which
6703 means we have no simple and reliable way to continue.
6704 Break out the floating-point parsing into a new
6705 function string_to_number, so that Fstring_to_number parses
6706 floating point numbers consistently with the Lisp reader.
6707 (digit_to_number): Move here from data.c. Make it static inline.
6708 (E_CHAR, EXP_INT): Remove, replacing with ...
6709 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6710 (string_to_number): New function, replacing isfloat_string.
6711 This function checks for valid syntax and produces the resulting
6712 Lisp float number too. Rework it so that string-to-number
6713 no longer mishandles examples like "1.0e+". Use strtoumax,
6714 so that overflow for non-base-10 numbers is reported only when
6715 there's no portable and simple way to convert to floating point.
6717 * textprop.c (set_text_properties_1): Rewrite for clarity,
6718 and to avoid GCC warning about integer overflow.
6720 * intervals.h (struct interval): Use EMACS_INT for members
6721 where EMACS_UINT might cause problems. See
6722 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6723 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6724 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6726 (offset_intervals): Tell GCC not to worry about length overflow
6727 when negating a negative length.
6729 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6730 (overrun_check_free): Likewise.
6732 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6733 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6736 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6737 (gnutls_make_error): Rename local to avoid shadowing.
6738 (gnutls_emacs_global_deinit): ifdef out; not used.
6739 (Fgnutls_boot): Use const for pointer to readonly storage.
6740 Comment out unused local. Fix pointer signedness problems.
6742 * lread.c (openp): Don't stuff size_t into an 'int'.
6743 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6744 about possible signed overflow.
6746 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6747 (GDK_KEY_g): Don't define if already defined.
6748 (xg_prepare_tooltip): Avoid pointer signedness problem.
6749 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6751 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6752 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6754 * xfns.c (Fx_window_property): Simplify a bit,
6755 to make a bit faster and to avoid GCC 4.6.0 warning.
6756 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6758 * fns.c (internal_equal): Don't assume size_t fits in int.
6760 * alloc.c (compact_small_strings): Tighten assertion a little.
6762 Replace pEd with more-general pI, and fix some printf arg casts.
6763 * lisp.h (pI): New macro, generalizing old pEd macro to other
6764 conversion specifiers. For example, use "...%"pI"d..." rather
6765 than "...%"pEd"...".
6766 (pEd): Remove. All uses replaced with similar uses of pI.
6767 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6768 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6769 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6770 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6771 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6772 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6773 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6775 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6776 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6777 * print.c (safe_debug_print, print_object): Likewise.
6778 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6780 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6781 avoiding the 0 flag, which is not portable.
6782 * process.c (Fmake_network_process): Use pI to avoid cast.
6783 * region-cache.c (pp_cache): Likewise.
6784 * xdisp.c (decode_mode_spec): Likewise.
6785 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6786 behavior on 64-bit hosts with printf arg.
6787 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6788 (x_stop_queuing_selection_requests): Likewise.
6789 (x_get_window_property): Don't truncate byte count to an 'int'
6792 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6793 here, since it parses constructs like leading '-' and spaces,
6794 which are not wanted; and it overflows with large numbers.
6795 Instead, simply match F[0-9]+, which is what is wanted anyway.
6797 * alloc.c: Remove unportable assumptions about struct layout.
6798 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6799 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6800 (allocate_vectorlike, make_pure_vector): Use the new macros,
6801 plus offsetof, to remove unportable assumptions about struct layout.
6802 These assumptions hold on all porting targets that I know of, but
6803 they are not guaranteed, they're easy to remove, and removing them
6804 makes further changes easier.
6806 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6807 This doesn't fix a bug but makes the code clearer.
6808 (string_overrun_cookie): Now const. Use initializers that
6809 don't formally overflow signed char, to avoid warnings.
6810 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6811 can cause Emacs to crash when string overrun checking is enabled.
6812 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6813 multiple of sizeof (EMACS_INT); it need not be, if
6814 alignof(EMACS_INT) < sizeof (EMACS_INT).
6815 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6817 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6819 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6821 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6823 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6824 supposed to be handshaking. (Bug#8556)
6825 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6827 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6829 * lisp.h (Qdebug): List symbol.
6830 * eval.c (Qdebug): Restore global linkage.
6831 * keyboard.c (debug-on-event): New variable.
6832 (handle_user_signal): Break into debugger when debug-on-event
6833 matches the current signal symbol.
6835 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6837 * alloc.c (check_sblock, check_string_bytes)
6838 (check_string_free_list): Convert to standard C.
6840 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6842 * w32.c (emacs_gnutls_push): Fix typo.
6844 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6846 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6847 "cast to pointer from integer of different size".
6849 Improve doprnt and its use in verror. (Bug#8545)
6850 * doprnt.c (doprnt): Document the set of format control sequences
6851 supported by the function. Use SAFE_ALLOCA instead of always
6854 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6855 is one byte too soon. Don't use xrealloc; instead xfree and
6858 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6860 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6863 * gnutls.c: Renamed global_initialized to
6864 gnutls_global_initialized. Added internals for the
6865 :verify-hostname-error, :verify-error, and :verify-flags
6866 parameters of `gnutls-boot' and documented those parameters in the
6867 docstring. Start callback support.
6868 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6869 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6870 on error. Return error code.
6871 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6872 (emacs_gnutls_read): Likewise.
6873 (Fgnutls_boot): Return handshake error code.
6874 (emacs_gnutls_handle_error): New function.
6875 (wsaerror_to_errno): Likewise.
6877 * w32.h (emacs_gnutls_pull): Add prototype.
6878 (emacs_gnutls_push): Likewise.
6880 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6881 (emacs_gnutls_push): Likewise.
6883 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6885 * process.c (wait_reading_process_output): Check if GnuTLS
6886 buffered some data internally if no FDs are set for TLS
6889 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6890 (LIBS): Link to USER_LIBS.
6891 ($(BLD)/gnutls.$(0)): New target.
6893 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6895 * xdisp.c (handle_single_display_spec): Rename the
6896 display_replaced_before_p argument into display_replaced_p, to
6897 make it consistent with the commentary. Fix typos in the
6900 * textprop.c (syms_of_textprop): Remove dead code.
6901 (copy_text_properties): Delete obsolete commentary about an
6902 interface that was deleted long ago. Fix typos in the description
6905 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6906 to changes in oldXMenu/XMenu.h from 2011-04-16.
6907 <menu_help_message, prev_menu_help_message>: Constify.
6908 (IT_menu_make_room): menu->help_text is now `const char **';
6911 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6912 to changes in oldXMenu/XMenu.h from 2011-04-16.
6913 (struct XMenu): Declare `help_text' `const char **'.
6915 * xfaces.c <Qunspecified>: Make extern again.
6917 * syntax.c: Include sys/types.h before including regex.h, as
6920 * doc.c (get_doc_string): Improve the format passed to `error'.
6922 * doprnt.c (doprnt): Improve commentary.
6924 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6926 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6929 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6930 changes in globals.h immediately force recompilation.
6931 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6932 $(CURDIR)/s/ms-w32.h.
6933 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6935 * character.c (Fchar_direction): Function deleted.
6936 (syms_of_character): Don't defsubr it.
6937 <char-direction-table>: Deleted.
6939 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6941 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6942 * doprnt.c: Include limits.h.
6943 (SIZE_MAX): New macro.
6944 (doprnt): Return a size_t value. 2nd arg is now size_t.
6945 Many local variables are now size_t instead of int or unsigned.
6946 Improve overflow protection. Support `l' modifier for integer
6947 conversions. Support %l conversion. Don't assume an EMACS_INT
6948 argument for integer conversions and for %c.
6950 * lisp.h (doprnt): Restore prototype.
6952 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6955 * Makefile.in (base_obj): Add back doprnt.o.
6957 * deps.mk (doprnt.o): Add back prerequisites.
6958 (callint.o): Depend on character.h.
6960 * eval.c (internal_lisp_condition_case): Include the handler
6961 representation in the error message.
6962 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6963 when breaking from the loop.
6965 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6967 * callint.c (Fcall_interactively): When displaying error message
6968 about invalid control letter, pass the character's codepoint, not
6969 a pointer to its multibyte form. Improve display of the character
6970 in octal and display also its hex code.
6972 * character.c (char_string): Use %x to display the (unsigned)
6973 codepoint of an invalid character, to avoid displaying a bogus
6976 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6977 `error', not SYMBOL_NAME itself.
6979 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6980 character arguments to `error'.
6982 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6983 to `error' in error message about FINAL_CHAR argument. Make sure
6984 FINAL_CHAR is a character, and use %c when it is passed as
6985 argument to `error'.
6987 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6989 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6991 * w32.c: Include <time.h>.
6992 (sys_localtime): New function.
6994 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6996 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6998 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7000 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7002 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7005 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7007 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7008 gl_state.e_property when gl_state.object is Qt.
7010 * insdel.c (make_gap_larger): Remove limitation of buffer size
7013 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7015 * xdisp.c (lookup_glyphless_char_display)
7016 (produce_glyphless_glyph): Handle cons cell entry in
7017 glyphless-char-display.
7018 (Vglyphless_char_display): Document it.
7020 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7021 glyphless-char-display.
7023 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7025 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7027 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7029 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7030 definition for no-X builds.
7032 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7034 Static checks with GCC 4.6.0 and non-default toolkits.
7036 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7038 * process.c (keyboard_bit_set): Define only if SIGIO.
7039 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7040 (send_process): Repair possible setjmp clobbering.
7042 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7044 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7046 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7048 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7049 Define only if needed.
7051 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7052 by pacifying GCC about it. Maybe it's time to retire it?
7053 * xfaces.c (USG, __TIMEVAL__): Likewise.
7055 * dispextern.h (struct redisplay_interface): Rename param
7057 * termhooks.h (struct terminal): Likewise.
7058 * xterm.c (xembed_send_message): Likewise.
7060 * insdel.c (make_gap_smaller): Define only if
7061 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7063 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7066 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7067 so that we aren't warned about unused symbols.
7069 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7071 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7073 * xfns.c (x_real_positions): Mark locals as initialized.
7075 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7077 * xterm.c: Fix problems found by static analysis with other toolkits.
7078 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7079 (x_dispatch_event): Declare static if USE_GTK, and
7080 define if USE_GTK || USE_X_TOOLKIT.
7081 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7082 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7083 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7084 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7086 * xmenu.c (menu_help_callback): Pointer type fixes.
7087 Use const pointers when pointing at readonly data. Avoid pointer
7089 (FALSE): Remove unused macro.
7090 (update_frame_menubar): Remove unused decl.
7092 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7094 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7095 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7096 (single_menu_item): Rename local to avoid shadowing.
7098 * keyboard.c (make_lispy_event): Remove unused local var.
7100 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7101 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7103 * bitmaps: Change bitmaps from unsigned char back to the X11
7104 compatible char. Avoid the old compiler warnings about
7105 out-of-range initializers by using, for example, '\xab' rather
7108 * xgselect.c (xgselect_initialize): Check vs interface
7109 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7111 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7113 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7114 to read-only memory.
7116 * fns.c (vector): Remove; this old hack is no longer needed.
7118 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7120 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7122 * xrdb.c (x_load_resources): Omit unused local.
7124 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7125 (x_window): Rename locals to avoid shadowing.
7126 (USG): Use the kludged USG macro, to pacify gcc.
7128 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7129 (x_term_init): Remove local to avoid shadowing.
7131 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7133 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7134 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7136 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7138 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7140 Fix regex.c, syntax.c and friends for buffers > 2GB.
7141 * syntax.h (struct gl_state_s): Declare character position members
7144 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7146 * textprop.c (verify_interval_modification, interval_of):
7147 Declare arguments EMACS_INT.
7149 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7152 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7154 * indent.c (Fvertical_motion): Local variable it_start is now
7157 * regex.c (re_match, re_match_2, re_match_2_internal)
7158 (bcmp_translate, regcomp, regexec, print_double_string)
7159 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7160 (re_compile_pattern, re_exec): Declare arguments and local
7161 variables `size_t' and `ssize_t' and return values `regoff_t', as
7163 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7164 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7165 <compile_stack_type>: `size' and `avail' are now `size_t'.
7167 * regex.h <regoff_t>: Use ssize_t, not int.
7168 (re_search, re_search_2, re_match, re_match_2): Arguments that
7169 specify buffer/string position and length are now ssize_t and
7170 size_t. Return type is regoff_t.
7172 2011-04-16 Ben Key <bkey76@gmail.com>
7174 * nsfont.m: Fixed bugs in ns_get_family and
7175 ns_descriptor_to_entity that were caused by using free to
7176 deallocate memory blocks that were allocated by xmalloc (via
7177 xstrdup). This caused Emacs to crash when compiled with
7178 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7179 --enable-checking=xmallocoverrun). xfree is now used to
7180 deallocate these memory blocks.
7182 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7184 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7186 emacs_write: Accept and return EMACS_INT for sizes.
7187 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7189 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7190 Accept and return EMACS_INT.
7191 (emacs_gnutls_write): Return the number of bytes written on
7193 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7194 (emacs_read, emacs_write): Remove check for negative size, as the
7195 Emacs source code has been audited now.
7196 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7197 (emacs_read, emacs_write): Use it.
7198 * process.c (send_process): Adjust to the new signatures of
7199 emacs_write and emacs_gnutls_write. Do not attempt to store
7200 a byte offset into an 'int'; it might overflow.
7201 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7203 * sound.c: Don't assume sizes fit in 'int'.
7204 (struct sound_device.period_size, alsa_period_size):
7205 Return EMACS_INT, not int.
7206 (struct sound_device.write, vox_write, alsa_write):
7207 Accept EMACS_INT, not int.
7208 (wav_play, au_play): Use EMACS_INT to store sizes and to
7209 record read return values.
7211 2011-04-15 Ben Key <bkey76@gmail.com>
7213 * keyboard.c (Qundefined): Don't declare static since it is used
7215 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7216 static since they are used in nsfont.m.
7218 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7220 * process.c (Qprocessp): Don't declare static.
7221 * lisp.h (Qprocessp): Declare again.
7223 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7225 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7227 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7229 Improve C-level modularity by making more things 'static'.
7231 Don't publish debugger-only interfaces to other modules.
7232 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7233 (verify_bytepos, count_markers): Move decls to the only modules
7235 * region-cache.h (pp_cache): Likewise.
7236 * window.h (check_all_windows): Likewise.
7237 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7239 * sysdep.c (croak): Now static, if
7240 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7241 * syssignal.h (croak): Declare only if not static.
7243 * alloc.c (refill_memory_reserve): Now static if
7244 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7245 * lisp.h (refill_memory_reserve): Declare only if not static.
7247 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7248 Define only if USE_LUCID.
7250 * xrdb.c (x_customization_string, x_rm_string): Now static.
7252 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7253 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7255 * xdisp.c (draw_row_with_mouse_face): Now static.
7256 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7258 * window.h (check_all_windows): Mark externally visible.
7260 * window.c (window_deletion_count): Now static.
7262 * undo.c: Make symbols static if they're not exported.
7263 (last_undo_buffer, last_boundary_position, pending_boundary):
7266 * textprop.c (interval_insert_behind_hooks): Now static.
7267 (interval_insert_in_front_hooks): Likewise.
7269 * term.c: Make symbols static if they're not exported.
7270 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7271 (max_frame_lines, tty_set_terminal_modes):
7272 (tty_reset_terminal_modes, tty_turn_off_highlight):
7273 (get_tty_terminal): Now static.
7274 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7275 * termhooks.h (term_mouse_moveto): Do not declare if
7277 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7278 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7280 * sysdep.c: Make symbols static if they're not exported.
7281 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7283 (sigprocmask_set, full_mask): Remove; unused.
7284 (wait_debugging): Mark as visible.
7285 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7286 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7288 * syntax.c (syntax_temp): Define only if !__GNUC__.
7290 * sound.c (current_sound_device, current_sound): Now static.
7292 * search.c (searchbufs, searchbuf_head): Now static.
7294 * scroll.c (scroll_cost): Remove; unused.
7295 * dispextern.h (scroll_cost): Remove decl.
7297 * region-cache.h (pp_cache): Mark as externally visible.
7299 * process.c: Make symbols static if they're not exported.
7300 (process_tick, update_tick, create_process, chan_process):
7301 (Vprocess_alist, proc_buffered_char, datagram_access):
7302 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7303 (deactivate_process): Mark defn as static, as well as decl.
7304 * lisp.h (create_process): Remove decl.
7305 * process.h (chan_process, Vprocess_alist): Remove decls.
7307 * print.c: Make symbols static if they're not exported.
7308 (print_depth, new_backquote_output, being_printed, print_buffer):
7309 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7310 (print_interval, print_number_index, initial_stderr_stream):
7312 * lisp.h (Fprinc): Remove decl.
7313 (debug_output_compilation_hack): Mark as externally visible.
7315 * sysdep.c (croak): Move decl from here to syssignal.h.
7316 * syssignal.h (croak): Put it here, so the API can be checked when
7317 'croak' is called from dissociate_if_controlling_tty.
7319 * minibuf.c: Make symbols static if they're not exported.
7320 (minibuf_save_list, choose_minibuf_frame): Now static.
7321 * lisp.h (choose_minibuf_frame): Remove decl.
7323 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7325 * lread.c: Make symbols static if they're not exported.
7326 (read_objects, initial_obarray, oblookup_last_bucket_number):
7328 (make_symbol): Remove; unused.
7329 * lisp.h (initial_obarray, make_symbol): Remove decls.
7331 * keyboard.c: Make symbols static if they're not exported.
7332 (single_kboard, recent_keys_index, total_keys, recent_keys):
7333 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7334 (this_single_command_key_start, echoing, last_auto_save):
7335 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7336 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7337 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7338 (Vlispy_mouse_stem, double_click_count):
7340 (force_auto_save_soon): Define only if SIGDANGER.
7341 (ignore_mouse_drag_p): Now static if
7342 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7343 (print_help): Remove; unused.
7344 (stop_character, last_timer_event): Mark as externally visible.
7345 * keyboard.h (ignore_mouse_drag_p): Declare only if
7346 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7347 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7348 * lisp.h (echoing): Remove decl.
7349 (force_auto_save_soon): Declare only if SIGDANGER.
7350 * xdisp.c (redisplay_window): Simplify code, to make it more
7351 obvious that ignore_mouse_drag_p is not accessed if !defined
7352 USE_GTK && !defined HAVE_NS.
7354 * intervals.c: Make symbols static if they're not exported.
7355 (merge_properties_sticky, merge_interval_right, delete_interval):
7357 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7359 * insdel.c: Make symbols static if they're not exported.
7360 However, leave prepare_to_modify_buffer alone. It's never
7361 called from outside this function, but that appears to be a bug.
7362 (combine_after_change_list, combine_after_change_buffer):
7363 (adjust_after_replace, signal_before_change): Now static.
7364 (adjust_after_replace_noundo): Remove; unused.
7365 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7366 (signal_before_change): Remove decls.
7368 * indent.c (val_compute_motion, val_vmotion): Now static.
7370 * image.c: Make symbols static if they're not exported.
7371 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7373 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7374 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7376 * fringe.c (standard_bitmaps): Now static.
7377 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7379 * frame.c: Make symbols static if they're not exported.
7380 (x_report_frame_params, make_terminal_frame): Now static.
7381 (get_frame_param): Now static, unless HAVE_NS.
7382 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7383 (x_get_resource_string): Remove; not used.
7384 * frame.h (make_terminal_frame, x_report_frame_params):
7385 (x_get_resource_string); Remove decls.
7386 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7387 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7389 * font.c, fontset.c: Make symbols static if they're not exported.
7390 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7391 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7392 * font.c (font_close_object): Now static.
7393 * font.h (font_close_object): Remove.
7394 * fontset.c (FONTSET_OBJLIST): Remove.
7395 (free_realized_fontset) #if-0 the body, which does nothing.
7396 (face_suitable_for_char_p): #if-0, as it's never called.
7397 * fontset.h (face_suitable_for_char_p): Remove decl.
7398 * xfaces.c (face_at_string_position):
7399 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7400 since 0 is always ASCII.
7402 * fns.c (weak_hash_tables): Now static.
7404 * fileio.c: Make symbols static if they're not exported.
7405 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7406 (Vwrite_region_annotation_buffers): Now static.
7408 * eval.c: Make symbols static if they're not exported.
7409 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7410 * lisp.h (backtrace_list): Remove decl.
7412 * emacs.c: Make symbols static if they're not exported.
7413 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7414 (fatal_error_code, fatal_error_signal_hook, standard_args):
7416 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7417 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7418 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7419 * lisp.h (fatal_error_signal_hook): Remove decl.
7420 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7422 * editfns.c: Move a (normally-unused) function to its only use.
7423 * editfns.c, lisp.h (get_operating_system_release): Remove.
7424 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7425 worth the hassle of breaking this out.
7427 * xterm.c: Make symbols static if they're not exported.
7428 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7429 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7430 (x_destroy_window, x_delete_display):
7432 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7433 (x_mouse_leave): Remove; unused.
7434 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7435 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7436 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7438 (x_mouse_leave): Declare only if WINDOWSNT.
7439 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7440 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7443 * ftxfont.c: Make symbols static if they're not exported.
7444 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7446 * font.h (ftxfont_driver): Likewise.
7448 * xfns.c: Make symbols static if they're not exported.
7449 (x_last_font_name, x_display_info_for_name):
7450 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7451 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7452 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7453 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7454 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7455 (last_show_tip_args): Now static.
7456 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7457 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7458 (x_screen_planes): Remove; unused.
7459 * dispextern.h (x_screen_planes): Remove decl.
7461 * dispnew.c: Make symbols static if they're not exported.
7462 * dispextern.h (redraw_garbaged_frames, scrolling):
7463 (increment_row_positions): Remove.
7464 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7465 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7467 (redraw_garbaged_frames): Remove; unused.
7469 * xfaces.c: Make symbols static if they're not exported.
7470 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7472 * xterm.h (defined_color): Remove decls.
7473 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7474 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7475 (menu_face_changed_default, defined_color, free_realized_face):
7476 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7477 (ascii_face_of_lisp_face): Remove; unused.
7479 * xdisp.c: Make symbols static if they're not exported.
7480 * dispextern.h (scratch_glyph_row, window_box_edges):
7481 (glyph_to_pixel_coords, set_cursor_from_row):
7482 (get_next_display_element, set_iterator_to_next):
7483 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7484 (show_mouse_face): Remove decls
7485 * frame.h (message_buf_print): Likewise.
7486 * lisp.h (pop_message, set_message, check_point_in_composition):
7488 * xterm.h (set_vertical_scroll_bar): Likewise.
7489 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7490 (message_buf_print, scratch_glyph_row, displayed_buffer):
7491 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7492 (get_next_display_element, show_mouse_face, window_box_edges):
7493 (frame_to_window_pixel_xy, check_point_in_composition):
7494 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7495 (glyph_to_pixel_coords): Remove; unused.
7497 * dired.c (file_name_completion): Now static.
7499 * dbusbind.c (xd_in_read_queued_messages): Now static.
7501 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7502 * data.c (circular_list_error): Remove.
7504 * commands.h (last_point_position, last_point_position_buffer):
7505 (last_point_position_window): Remove decls.
7506 * keyboard.c: Make these variables static.
7508 * coding.h (coding, code_convert_region, encode_coding_gap):
7510 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7511 (iso_code_class, detect_coding, code_convert_region): Now static.
7512 (encode_coding_gap): Remove; unused.
7514 * chartab.c (chartab_chars, chartab_bits): Now static.
7516 * charset.h (charset_iso_8859_1): Remove decl.
7517 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7520 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7521 * ccl.c (Vccl_program_table): Now static.
7522 (check_ccl_update): Remove; unused.
7524 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7525 * category.h: ... from here.
7526 * category.c (check_category_table, set_category_set): Now static.
7528 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7529 * lisp.h: Remove these decls.
7531 * buffer.c (buffer_count): Remove unused var.
7533 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7534 so that it's not optimized away.
7535 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7536 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7537 exported only to the debugger.
7539 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7540 * atimer.h (run_all_atimers): Remove; not exported.
7542 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7543 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7544 was inaccessible from Lisp.
7545 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7546 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7548 alloc.c: Import and export fewer symbols, and remove unused items.
7549 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7551 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7552 it's not optimized away by whole-program optimization.
7553 (message_enable_multibyte, free_misc): Remove.
7554 (catchlist, handlerlist, mark_backtrace):
7555 Declare only if BYTE_MARK_STACK.
7556 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7557 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7558 (message_enable_multibyte): Remove decl.
7559 (free_misc, interval_free_list, float_block, float_block_index):
7560 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7561 (cons_free_list, last_marked_index):
7563 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7564 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7565 (mark_backtrace): Define only if BYTE_MARK_STACK.
7566 * xdisp.c (message_enable_multibyte): Now static.
7568 Declare Lisp_Object Q* variables to be 'static' if not exported.
7569 This makes it easier for human readers (and static analyzers)
7570 to see whether these variables are used from other modules.
7571 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7572 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7573 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7574 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7575 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7576 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7577 * xmenu.c, xselect.c:
7578 Declare Q* vars static if they are not used in other modules.
7579 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7580 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7581 Remove decls of unexported vars.
7582 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7584 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7586 Make Emacs functions such as Fatom 'static' by default.
7587 This makes it easier for human readers (and static analyzers)
7588 to see whether these functions can be called from other modules.
7589 DEFUN now defines a static function. To make the function external
7590 so that it can be used in other C modules, use the new macro DEFUE.
7591 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7592 (Finit_image_library):
7593 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7594 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7595 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7596 Remove decls, since these functions are now static.
7597 (Funintern, Fget_internal_run_time): New decls, since these functions
7598 were already external.
7600 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7601 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7602 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7603 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7604 * keyboard.c, keymap.c, lread.c:
7605 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7606 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7607 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7608 Mark functions with DEFUE instead of DEFUN,
7609 if they are used in other modules.
7610 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7611 decls for now-static functions.
7612 * buffer.h (Fdelete_overlay): Remove decl.
7613 * callproc.c (Fgetenv_internal): Mark as internal.
7614 * composite.c (Fremove_list_of_text_properties): Remove decl.
7615 (Fcomposition_get_gstring): New forward static decl.
7616 * composite.h (Fcomposite_get_gstring): Remove decl.
7617 * dired.c (Ffile_attributes): New forward static decl.
7618 * doc.c (Fdocumntation_property): New forward static decl.
7619 * eval.c (Ffetch_bytecode): New forward static decl.
7620 (Funintern): Remove extern decl; now in .h file where it belongs.
7621 * fileio.c (Fmake_symbolic_link): New forward static decl.
7622 * image.c (Finit_image_library): New forward static decl.
7623 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7624 * intervals.h (Fprevious_property_change):
7625 (Fremove_list_of_text_properties): Remove decls.
7626 * keyboard.c (Fthis_command_keys): Remove decl.
7627 (Fcommand_execute): New forward static decl.
7628 * keymap.c (Flookup_key): New forward static decl.
7629 (Fcopy_keymap): Now static.
7630 * keymap.h (Flookup_key): Remove decl.
7631 * process.c (Fget_process): New forward static decl.
7632 (Fprocess_datagram_address): Mark as internal.
7633 * syntax.c (Fsyntax_table_p): New forward static decl.
7634 (skip_chars): Remove duplicate decl.
7635 * textprop.c (Fprevious_property_change): New forward static decl.
7636 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7638 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7639 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7641 * editfns.c (Fformat): Remove unreachable code.
7643 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7645 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7648 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7650 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7651 when at ZV. (Bug#8487)
7653 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7655 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7657 * keyboard.c (parse_tool_bar_item): Likewise.
7658 * sound.c (sound_cleanup, alsa_close): Likewise.
7659 * termcap.c (tgetent): Likewise.
7660 * xfns.c (x_default_font_parameter): Likewise.
7661 * xsettings.c (read_and_apply_settings): Likewise.
7663 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7664 (overrun_check_free): Protoize.
7666 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7668 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7669 since callers should never pass a negative size.
7670 Change the signature to match that of plain 'read' and 'write'; see
7671 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7672 * lisp.h: Update prototypes of emacs_write and emacs_read.
7674 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7676 * xdisp.c (redisplay_window): Don't try to determine the character
7677 position of the scroll margin if the window start point w->startp
7678 is outside the buffer's accessible region. (Bug#8468)
7680 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7682 Fix write-region and its subroutines for buffers > 2GB.
7683 * fileio.c (a_write, e_write): Modify declaration of arguments and
7684 local variables to support buffers larger than 2GB.
7685 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7687 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7688 argument, local variables, and return value.
7690 * lisp.h: Update prototypes of emacs_write and emacs_read.
7692 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7694 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7696 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7698 Fix more problems found by GCC 4.6.0's static checks.
7700 * xdisp.c (vmessage): Use a better test for character truncation.
7702 * charset.c (load_charset_map): <, not <=, for optimization,
7703 and to avoid potential problems with integer overflow.
7704 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7705 * casetab.c (set_identity, shuffle): Likewise.
7706 * editfns.c (Fformat): Likewise.
7707 * syntax.c (skip_chars): Likewise.
7709 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7710 This also lets GCC 4.6.0 generate slightly better loop code.
7712 * callint.c (Fcall_interactively): <, not <=, for optimization.
7713 (Fcall_interactively): Count the number of arguments produced,
7714 not the number of arguments given. This is simpler and lets GCC
7715 4.6.0 generate slightly better code.
7717 * ftfont.c: Distingish more carefully between FcChar8 and char.
7718 The previous code passed unsigned char * to a functions like
7719 strlen and xstrcasecmp that expect char *, which does not
7720 conform to the C standard.
7721 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7722 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7723 char * when the C standard requires it.
7725 * keyboard.c (read_char): Remove unused var.
7727 * eval.c: Port to Windows vsnprintf (Bug#8435).
7729 (SIZE_MAX): Define if the headers do not.
7730 (verror): Do not give up if vsnprintf returns a negative count.
7731 Instead, grow the buffer. This ports to Windows vsnprintf, which
7732 does not conform to C99. Problem reported by Eli Zaretskii.
7733 Also, simplify the allocation scheme, by avoiding the need for
7734 calling realloc, and removing the ALLOCATED variable.
7736 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7738 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7739 But keep the doprint source code for now, as we might revamp it
7740 and use it again (Bug#8435).
7741 * lisp.h (doprnt): Remove.
7742 * Makefile.in (base_obj): Remove doprnt.o.
7743 * deps.mk (doprnt.o): Remove.
7745 error: Print 32- and 64-bit integers portably (Bug#8435).
7746 Without this change, on typical 64-bit hosts error ("...%d...", N)
7747 was used to print both 32- and 64-bit integers N, which relied on
7749 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7751 * lisp.h (error, verror): Mark as printf-like functions.
7752 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7753 Report overflow in size calculations when allocating printf buffer.
7754 Do not truncate output string at its first null byte.
7755 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7756 Truncate the output at a character boundary, since vsnprintf does not
7758 * charset.c (check_iso_charset_parameter): Convert internal
7759 character to string before calling 'error', since %c now has the
7761 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7762 overflow when computing char to be passed to 'error'. Do not
7763 pass Lisp_Object to 'error'; pass the integer instead.
7764 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7765 formatted with plain %d.
7767 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7769 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7771 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7773 * xterm.c (x_catch_errors): Remove duplicate declaration.
7775 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7777 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7779 2011-04-10 Jim Meyering <meyering@redhat.com>
7781 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7782 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7783 return ssize_t not "int", and use size_t as the buffer length.
7784 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7785 * gnutls.h: Update declarations.
7786 * process.c (read_process_output): Use ssize_t, to match.
7787 (send_process): Likewise.
7789 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7791 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7793 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7795 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7796 Use unsigned char, to match FcChar8 type definition.
7798 * xterm.c (handle_one_xevent):
7799 * xmenu.c (create_and_show_popup_menu):
7800 * xselect.c (x_decline_selection_request)
7801 (x_reply_selection_request): Avoid type-punned deref of X events.
7803 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7805 Fix some uses of `int' instead of EMACS_INT.
7806 * search.c (string_match_1, fast_string_match)
7807 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7808 (scan_buffer, find_next_newline_no_quit)
7809 (find_before_next_newline, search_command, Freplace_match)
7810 (Fmatch_data): Make some `int' variables be EMACS_INT.
7812 * xdisp.c (display_count_lines): 3rd argument and return value now
7813 EMACS_INT. All callers changed.
7814 (pint2hrstr): Last argument is now EMACS_INT.
7816 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7817 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7818 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7819 (decode_coding_utf_16, decode_coding_emacs_mule)
7820 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7821 (decode_coding_ccl, decode_coding_charset)
7822 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7823 (decode_coding_iso_2022, decode_coding_emacs_mule)
7824 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7825 <char_offset, last_offset>: Declare EMACS_INT.
7826 (encode_coding_utf_8, encode_coding_utf_16)
7827 (encode_coding_emacs_mule, encode_invocation_designation)
7828 (encode_designation_at_bol, encode_coding_iso_2022)
7829 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7830 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7832 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7833 (encode_invocation_designation): Last argument P_NCHARS is now
7835 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7836 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7838 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7841 * ccl.c (Fccl_execute_on_string): Declare some variables
7844 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7846 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7848 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7850 * process.c (Fformat_network_address): Doc fix.
7852 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7854 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7856 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7858 * keyboard.c (read_char): Call Lisp function help-form-show,
7859 instead of using internal_with_output_to_temp_buffer.
7860 (Qhelp_form_show): New var.
7861 (syms_of_keyboard): Use DEFSYM macro.
7863 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7865 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7867 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7869 * process.c (Flist_processes): Remove to Lisp.
7870 (list_processes_1): Delete.
7872 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7874 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7876 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7878 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7880 Fix more problems found by GCC 4.6.0's static checks.
7882 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7884 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7886 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7888 * xdisp.c (vmessage): Mark as a printf-like function.
7890 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7892 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7894 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7895 printf-like functions.
7896 (tiff_load): Add casts to remove these marks before passing them
7897 to system-supplied API.
7899 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7901 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7902 This avoids several warnings with gcc -Wstrict-overflow.
7903 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7904 directly, rather than having caller test rule sign. This avoids
7905 some unnecessary tests.
7906 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7907 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7908 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7910 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7911 (xfont_open): Avoid unnecessary tests.
7913 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7915 * composite.h, composite.c (composition_gstring_put_cache):
7916 Use EMACS_INT, not int, for length.
7918 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7919 breaking out part of COMPOSITION_DECODE_RULE.
7920 (COMPOSITION_DECODE_RULE): Use it.
7921 * composite.c (get_composition_id): Remove unused local vars,
7922 by using the new macro.
7924 * textprop.c (set_text_properties_1): Change while to do-while,
7925 since the condition is always true at first.
7927 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7928 (interval_deletion_adjustment): Return unsigned value.
7931 * process.c (list_processes_1, create_pty, read_process_output):
7932 (exec_sentinel): Remove vars that were set but not used.
7933 (create_pty): Remove unnecessary "volatile"s.
7934 (Fnetwork_interface_info): Avoid possibility of int overflow.
7935 (read_process_output): Do adaptive read buffering even if carryover.
7936 (read_process_output): Simplify nbytes computation if buffered.
7938 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7940 * syntax.c (scan_words): Remove var that was set but not used.
7941 (update_syntax_table): Use unsigned instead of int.
7943 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7944 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7945 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7947 * print.c (print_error_message): Avoid int overflow.
7949 * font.c (font_list_entities): Redo for clarity,
7950 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7952 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7953 (font_score): Avoid potential overflow in diff calculation.
7955 * fns.c (substring_both): Remove var that is set but not used.
7956 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7958 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7960 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7961 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7962 can always succeed if overflow has undefined behavior.
7964 * search.c (boyer_moore, wordify): Remove vars set but not used.
7965 (wordify): Omit three unnecessary tests.
7967 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7968 All callers changed. This avoids the need for an unused var.
7970 * casefiddle.c (casify_region): Remove var that is set but not used.
7972 * dired.c (file_name_completion): Remove var that is set but not used.
7974 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7976 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7977 (Finsert_file_contents): Remove unnecessary code checking fd.
7979 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7980 Check for integer overflow on size calculations.
7982 * buffer.c (Fprevious_overlay_change): Remove var that is set
7985 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7986 Remove vars that are set but not used.
7987 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7988 (timer_check_2): Mark vars as initialized.
7990 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7992 * image.c (lookup_image): Remove var that is set but not used.
7993 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7995 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7996 that are set but not used.
7998 * xfns.c (make_invisible_cursor): Don't return garbage
7999 if XCreateBitmapFromData fails (Bug#8410).
8001 * xselect.c (x_get_local_selection, x_handle_property_notify):
8002 Remove vars that are set but not used.
8004 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8005 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8007 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8008 Remove var that is set but not used.
8009 (scroll_bar_windows_size): Now size_t, not int.
8010 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8013 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8014 (map_tty_color) [!defined MSDOS]: Likewise.
8016 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8018 * coding.c: Remove vars that are set but not used.
8019 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8020 All callers changed.
8021 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8022 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8023 (decode_coding_charset): Remove vars that are set but not used.
8025 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8026 that is set but not used.
8028 * print.c (print_object): Remove var that is set but not used.
8030 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8031 The gnulib version avoids calling malloc in the usual case,
8032 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8033 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8034 * filelock.c (current_lock_owner): Likewise.
8035 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8036 * sysdep.c: Include allocator.h, careadlinkat.h.
8037 (emacs_no_realloc_allocator): New static constant.
8038 (emacs_readlink): New function.
8039 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8040 ../lib/careadlinkat.h.
8042 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8044 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8045 first non-nil return value).
8047 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8049 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8050 if not defined (Bug#8403).
8052 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8054 * xdisp.c (display_count_lines): Remove parameter `start',
8055 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8056 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8057 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8058 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8059 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8060 and thereabouts. All callers changed.
8061 (get_per_char_metric): Remove parameter `f', unused since
8062 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8064 2011-04-02 Jim Meyering <meyering@redhat.com>
8066 do not dereference NULL upon failed strdup
8067 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8068 (ns_get_family): Likewise.
8070 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8072 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8074 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8076 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8079 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8081 Add lexical binding.
8083 * window.c (Ftemp_output_buffer_show): New fun.
8084 (Fsave_window_excursion):
8085 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8087 * lread.c (lisp_file_lexically_bound_p): New function.
8088 (Fload): Bind Qlexical_binding.
8089 (readevalloop): Remove `evalfun' arg.
8090 Bind Qinternal_interpreter_environment.
8091 (Feval_buffer): Bind Qlexical_binding.
8092 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8094 (syms_of_lread): Declare `lexical-binding'.
8096 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8098 * keyboard.c (eval_dyn): New fun.
8099 (menu_item_eval_property): Use it.
8101 * image.c (parse_image_spec): Use Ffunctionp.
8103 * fns.c (concat, mapcar1): Accept byte-code-functions.
8105 * eval.c (Fsetq): Handle lexical vars.
8106 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8107 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8108 (FletX, Flet): Obey lexical binding.
8109 (Fcommandp): Handle closures.
8110 (Feval): New `lexical' arg.
8111 (eval_sub): New function extracted from Feval. Use it almost
8112 everywhere where Feval was used. Look up vars in lexical env.
8114 (Ffunctionp): Move from subr.el.
8115 (Ffuncall): Handle closures.
8116 (apply_lambda): Remove `eval_flags'.
8117 (funcall_lambda): Handle closures and new byte-code-functions.
8118 (Fspecial_variable_p): New function.
8119 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8120 but without exporting it to Lisp.
8122 * doc.c (Fdocumentation, store_function_docstring):
8123 * data.c (Finteractive_form): Handle closures.
8125 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8128 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8130 (exec_byte_code): New function extracted from Fbyte_code to handle new
8131 calling convention for byte-code-functions. Add new byte-codes.
8133 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8135 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8137 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8139 * xdisp.c (redisplay_internal): Fix prototype.
8141 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8143 * xdisp.c (SCROLL_LIMIT): New macro.
8144 (try_scrolling): Use it when setting scroll_limit.
8145 Limit scrolling to 100 screen lines.
8146 (redisplay_window): Even when falling back on "recentering",
8147 position point in the window according to scroll-conservatively,
8148 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8150 (try_scrolling): When point is above the window, allow searching
8151 as far as scroll_max, or one screenful, to compute vertical
8152 distance from PT to the scroll margin position. This prevents
8153 try_scrolling from unnecessarily failing when
8154 scroll-conservatively is set to a value slightly larger than the
8155 window height. Clean up the case of PT below the margin at bottom
8156 of window: scroll_max can no longer be INT_MAX. When aggressive
8157 scrolling is in use, don't let point enter the opposite scroll
8158 margin as result of the scroll.
8159 (syms_of_xdisp) <scroll-conservatively>: Document the
8160 threshold of 100 lines for never-recentering scrolling.
8162 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8164 * dispextern.h (move_it_by_lines):
8165 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8166 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8167 (message_log_check_duplicate): Remove parameters `prev_bol' and
8168 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8169 (redisplay_internal): Remove parameter `preserve_echo_area',
8170 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8172 * indent.c (Fvertical_motion):
8173 * window.c (window_scroll_pixel_based, Frecenter):
8174 Don't pass `need_y_p' to `move_it_by_lines'.
8176 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8178 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8179 steal a few bits to be more compact.
8180 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8181 Remove unneeded casts.
8183 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8185 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8187 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8188 binding" message (bug#7967).
8190 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8192 Fix more problems found by GCC 4.6.0's static checks.
8194 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8195 Remove unused local var.
8197 * editfns.c (Fmessage_box): Remove unused local var.
8199 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8200 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8201 Omit unused local vars.
8202 * window.c (shrink_windows): Omit unused local var.
8203 * menu.c (digest_single_submenu): Omit unused local var.
8204 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8205 Omit unused local var.
8207 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8208 Don't assume string length fits in int.
8209 (keyremap_step, read_key_sequence): Use size_t for sizes.
8210 (read_key_sequence): Don't check last_real_key_start redundantly.
8212 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8213 instead of alloca (Bug#8344).
8215 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8216 (Fbacktrace_frame): Don't assume nframes fits in int.
8218 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8220 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8223 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8225 * cm.c (calccost): Turn while-do into do-while, for clarity.
8227 * keyboard.c (syms_of_keyboard): Use the same style as later
8228 in this function when indexing through an array. This also
8229 works around GCC bug 48267.
8231 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8233 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8235 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8236 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8238 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8239 This avoids undefined behavior on integer overflow, and is a bit
8240 more convenient anyway since it is compared to a size_t variable.
8242 Variadic C functions now count arguments with size_t, not int.
8243 This avoids an unnecessary limitation on 64-bit machines, which
8244 caused (substring ...) to crash on large vectors (Bug#8344).
8245 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8246 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8247 All variadic functions and their callers changed accordingly.
8248 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8249 * data.c (arith_driver, float_arith_driver): Likewise.
8250 * editfns.c (general_insert_function): Likewise.
8251 * eval.c (struct backtrace.nargs, interactive_p)
8252 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8253 (funcall_lambda, mark_backtrace): Likewise.
8254 * fns.c (concat): Likewise.
8255 * frame.c (x_set_frame_parameters): Likewise.
8256 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8257 0 if not found, not -1. All callers changed.
8259 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8260 (stack_copy_size): Now size_t, not int.
8261 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8263 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8265 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8266 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8267 All callers changed.
8269 * lisp.h (multibyte_char_to_unibyte):
8270 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8271 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8272 * character.h (CHAR_TO_BYTE8):
8273 * cmds.c (internal_self_insert):
8274 * editfns.c (general_insert_function):
8275 * keymap.c (push_key_description):
8276 * search.c (Freplace_match):
8277 * xdisp.c (message_dolog, set_message_1): All callers changed.
8279 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8281 * keyboard.c (safe_run_hook_funcall): New function.
8282 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8283 don't set the hook to nil, but remove the offending function instead.
8284 (Qcommand_hook_internal): Remove, unused.
8285 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8286 Vcommand_hook_internal.
8288 * eval.c (enum run_hooks_condition): Remove.
8289 (funcall_nil, funcall_not): New functions.
8290 (run_hook_with_args): Call each function through a `funcall' argument.
8291 Remove `cond' argument, now redundant.
8292 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8293 (Frun_hook_with_args_until_failure): Adjust accordingly.
8294 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8296 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8298 * dispextern.h (string_buffer_position): Remove declaration.
8300 * print.c (strout): Remove parameter `multibyte', unused since
8301 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8303 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8304 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8305 All callers changed.
8307 * w32.c (_wsa_errlist): Use braces for struct initializers.
8309 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8310 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8311 All callers changed.
8312 (string_buffer_position): Likewise. Also, make static (it's never
8313 used outside xdisp.c).
8314 (cursor_row_p): Remove parameter `w', unused since
8315 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8316 (decode_mode_spec): Remove parameter `precision', introduced during
8317 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8318 All callers changed.
8320 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8322 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8324 2011-03-27 Anders Lindgren <andlind@gmail.com>
8326 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8327 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8328 (ns_update_auto_hide_menu_bar): New functions.
8329 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8330 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8331 ns_constrain_all_frames.
8332 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8333 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8335 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8337 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8339 2011-03-27 Glenn Morris <rgm@gnu.org>
8341 * syssignal.h: Replace RETSIGTYPE with void.
8342 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8343 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8344 Replace SIGTYPE with void everywhere.
8345 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8346 * s/template.h (SIGTYPE): Remove commented out definition.
8348 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8350 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8351 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8353 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8355 * w32.c (read_unc_volume): Use parameter `henum', instead of
8356 global variable `wget_enum_handle'.
8358 * keymap.c (describe_vector): Remove parameters `indices' and
8359 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8360 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8362 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8364 * keyboard.c (timer_check): Remove parameter `do_it_now',
8365 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8366 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8367 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8369 * keyboard.c (read_char):
8370 * w32menu.c (w32_menu_display_help):
8371 * xmenu.c (show_help_event, menu_help_callback):
8372 Adjust calls to `show_help_echo'.
8374 * gtkutil.c (xg_maybe_add_timer):
8375 * keyboard.c (readable_events):
8376 * process.c (wait_reading_process_output):
8377 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8379 * insdel.c (adjust_markers_gap_motion):
8380 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8381 (gap_left, gap_right): Don't call it.
8383 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8385 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8386 incurred during fontification.
8388 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8390 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8391 (DEFVAR_PER_BUFFER): Don't pass it.
8393 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8394 (scrolling_window): Don't pass it.
8396 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8398 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8400 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8402 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8403 of variables specific to SELinux and computation of `encoded_absname'.
8405 * image.c (XPutPixel): Remove unused variable `height'.
8407 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8409 * unexw32.c (get_section_info): Remove unused variable `section'.
8411 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8412 (system_process_attributes): Remove unused variable `sess'.
8413 (sys_read): Remove unused variable `err'.
8415 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8416 (w32_wnd_proc): Remove unused variable `isdead'.
8417 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8418 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8419 (x_create_tip_frame): Remove unused variable `tem'.
8421 * w32inevt.c (w32_console_read_socket):
8422 Remove unused variable `no_events'.
8424 * w32term.c (x_draw_composite_glyph_string_foreground):
8425 Remove unused variable `width'.
8427 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8429 * w32term.c (x_set_glyph_string_clipping):
8430 Don't pass uninitialized region to CombineRgn.
8432 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8434 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8435 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8436 (Fx_close_connection): Remove unused variable `i'.
8438 * w32font.c (w32font_draw): Return number of glyphs.
8439 (w32font_open_internal): Remove unused variable `i'.
8440 (w32font_driver): Add missing initializer.
8442 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8443 (fill_in_menu): Remove unused variable `items_added'.
8445 * w32term.c (last_mouse_press_frame): Remove static global variable.
8446 (w32_clip_to_row): Remove unused variable `f'.
8447 (x_delete_terminal): Remove unused variable `i'.
8449 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8450 (NOTHING): Remove unused static global variable.
8451 (uniscribe_check_otf): Remove unused variable `table'.
8452 (uniscribe_font_driver): Add missing initializers.
8454 2011-03-23 Julien Danjou <julien@danjou.info>
8456 * term.c (Fsuspend_tty, Fresume_tty):
8457 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8458 * window.c (temp_output_buffer_show):
8459 * insdel.c (signal_before_change):
8460 * frame.c (Fhandle_switch_frame):
8461 * fileio.c (Fdo_auto_save):
8462 * emacs.c (Fkill_emacs):
8463 * editfns.c (save_excursion_restore):
8464 * cmds.c (internal_self_insert):
8465 * callint.c (Fcall_interactively):
8466 * buffer.c (Fkill_all_local_variables):
8467 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8469 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8470 unconditionally since it does the check itself.
8472 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8474 Fix more problems found by GCC 4.5.2's static checks.
8476 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8477 the first time through the loop, since we know p0 < p1 then.
8478 This also avoids a gcc -Wstrict-overflow warning.
8480 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8481 leading to a memory leak, possible in functions like
8482 load_charset_map_from_file that can allocate an unbounded number
8483 of objects (Bug#8318).
8485 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8486 that could (at least in theory) be that large.
8488 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8489 This is less likely to overflow, and avoids undefined behavior if
8490 overflow does occur. All callers changed. Use strtoul to scan
8491 for the unsigned long integer.
8492 (pint2hrstr): Simplify and tune code slightly.
8493 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8495 * scroll.c (do_scrolling): Work around GCC bug 48228.
8496 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8498 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8499 This also avoids a warning with gcc -Wstrict-overflow.
8500 (validate_x_resource_name): Simplify count usage.
8501 This also avoids a warning with gcc -Wstrict-overflow.
8503 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8506 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8508 * process.c (Fmake_network_process): Use socklen_t, not int,
8509 where POSIX says socklen_t is required in portable programs.
8510 This fixes a porting bug on hosts like 64-bit HP-UX, where
8511 socklen_t is wider than int (Bug#8277).
8512 (Fmake_network_process, server_accept_connection):
8513 (wait_reading_process_output, read_process_output):
8516 * process.c: Rename or move locals to avoid shadowing.
8517 (list_processes_1, Fmake_network_process):
8518 (read_process_output_error_handler, exec_sentinel_error_handler):
8519 Rename or move locals.
8520 (Fmake_network_process): Define label "retry_connect" only if needed.
8521 (Fnetwork_interface_info): Fix pointer signedness.
8522 (process_send_signal): Add cast to avoid pointer signedness problem.
8523 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8524 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8526 Make tparam.h and terminfo.c consistent.
8527 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8528 Include tparam.h instead, since it declares them.
8529 * cm.h (PC): Remove extern decl; tparam.h now does this.
8530 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8531 * terminfo.c: Include tparam.h, to check interfaces.
8532 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8533 (tparam): Adjust signature to match interface in tparam.h;
8534 this removes some undefined behavior. Check that outstring and len
8535 are zero, which they always are with Emacs.
8536 * tparam.h (PC, BC, UP): New extern decls.
8538 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8539 (xftfont_open): Rename locals to avoid shadowing.
8541 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8542 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8543 (OTF_TAG_SYM): Omit macro if not needed.
8544 (ftfont_list): Remove unused local.
8545 (get_adstyle_property, ftfont_pattern_entity):
8546 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8547 Rename locals to avoid shadowing.
8549 * xfont.c (xfont_list_family): Mark var as initialized.
8551 * xml.c (make_dom): Now static.
8553 * composite.c (composition_compute_stop_pos): Rename local to
8555 (composition_reseat_it): Remove unused locals.
8556 (find_automatic_composition, composition_adjust_point): Likewise.
8557 (composition_update_it): Mark var as initialized.
8558 (find_automatic_composition): Mark vars as initialized,
8559 with a FIXME (Bug#8290).
8561 character.h: Rename locals to avoid shadowing.
8562 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8563 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8564 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8565 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8568 * textprop.c (property_change_between_p): Remove; unused.
8570 * intervals.c (interval_start_pos): Now static.
8572 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8574 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8575 Rename locals to avoid shadowing.
8577 * sound.c (wav_play, au_play, Fplay_sound_internal):
8578 Fix pointer signedness.
8579 (alsa_choose_format): Remove unused local var.
8580 (wav_play): Initialize a variable to 0, to prevent undefined
8581 behavior (Bug#8278).
8583 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8585 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8587 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8588 clobbering (Bug#8298).
8589 * sysdep.c (sys_subshell): Likewise.
8590 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8592 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8593 This should get cleaned up, so that child_setup has the
8594 same signature on all platforms.
8596 * callproc.c (call_process_cleanup): Now static.
8597 (relocate_fd): Rename locals to avoid shadowing.
8599 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8601 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8602 not to be necessary, and produces flickering.
8604 2011-03-20 Glenn Morris <rgm@gnu.org>
8606 * config.in: Remove file.
8608 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8610 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8611 are now in src/globals.h.
8612 (syms_of_minibuf): Remove spurious & from previous change.
8614 2011-03-20 Leo Liu <sdl.web@gmail.com>
8616 * minibuf.c (completing-read-function): New variable.
8617 (completing-read-default): Rename from completing-read.
8618 (completing-read): Call completing-read-function.
8620 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8622 * xfaces.c (Fx_load_color_file):
8623 Read color file from absolute filename (bug#8250).
8625 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8627 * makefile.w32-in: Update dependencies.
8629 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8631 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8633 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8635 Fix more problems found by GCC 4.5.2's static checks.
8637 * process.c (make_serial_process_unwind, send_process_trap):
8638 (sigchld_handler): Now static.
8640 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8641 That way, the code declares only the vars that it needs.
8642 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8643 * s/cygwin.h (PTY_ITERATION): Likewise.
8644 * s/darwin.h (PTY_ITERATION): Likewise.
8645 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8647 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8648 * process.c (allocate_pty): Don't declare stb unless it's needed.
8650 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8651 (CONSTANTLIM): Remove; unused.
8652 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8653 Define only if needed.
8655 * unexelf.c (unexec): Name an expression,
8656 to avoid gcc -Wbad-function-cast warning.
8657 Use a different way to cause a compilation error if anyone uses
8658 n rather than nn, a way that does not involve shadowing.
8659 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8661 * deps.mk (unexalpha.o): Remove; unused.
8663 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8664 * unexec.h: New file.
8665 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8666 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8668 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8669 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8670 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8671 Change as necessary to match prototype in unexec.h.
8673 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8675 (back_comment, skip_chars): Mark vars as initialized.
8677 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8678 Rename locals to avoid shadowing.
8680 * lread.c (read1): Rewrite so as not to use empty "else".
8681 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8683 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8685 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8686 warning when compiling print.c.
8688 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8689 instead of using an uninitialized var.
8690 (font_sort_entities): Mark var as initialized.
8692 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8694 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8695 pointers to constants.
8696 (font_parse_fcname): Remove unused vars.
8697 (font_delete_unmatched): Now static.
8698 (font_get_spec): Remove; unused.
8699 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8700 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8701 Rename or move locals to avoid shadowing.
8703 * fns.c (require_nesting_list, require_unwind): Now static.
8704 (Ffillarray): Rename locals to avoid shadowing.
8706 * floatfns.c (domain_error2): Define only if needed.
8707 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8709 * alloc.c (mark_backtrace): Move decl from here ...
8710 * lisp.h: ... to here, so that it can be checked.
8712 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8713 (Fdefvar): Rewrite so as not to use empty "else".
8714 (lisp_indirect_variable): Name an expression,
8715 to avoid gcc -Wbad-function-cast warning.
8716 (Fdefvar): Rename locals to avoid shadowing.
8718 * callint.c (quotify_arg, quotify_args): Now static.
8719 (Fcall_interactively): Rename locals to avoid shadowing.
8720 Use const pointer when appropriate.
8722 * lisp.h (get_system_name, get_operating_system_release):
8723 Move decls here, to check interfaces.
8724 * process.c (get_operating_system_release): Move decl to lisp.h.
8725 * xrdb.c (get_system_name): Likewise.
8726 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8727 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8728 some of which prompt warnings from gcc -Wbad-function-cast.
8729 (Fformat_time_string, Fencode_time, Finsert_char):
8730 (Ftranslate_region_internal, Fformat):
8731 Rename or remove local vars to avoid shadowing.
8732 (Ftranslate_region_internal): Mark var as initialized.
8734 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8737 * lisp.h (eassert): Check that the argument compiles, even if
8738 ENABLE_CHECKING is not defined.
8740 * data.c (Findirect_variable): Name an expression, to avoid
8741 gcc -Wbad-function-cast warning.
8742 (default_value, arithcompare, arith_driver, arith_error): Now static.
8743 (store_symval_forwarding): Rename local to avoid shadowing.
8744 (Fmake_variable_buffer_local, Fmake_local_variable):
8745 Mark variables as initialized.
8746 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8748 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8749 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8750 Rename locals to avoid shadowing.
8751 (mark_stack): Move local variables into the #ifdef region where
8753 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8754 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8756 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8757 (GC_STRING_CHARS): Remove; not used.
8758 (Fmemory_limit): Cast sbrk's returned value to char *.
8760 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8761 avoids undefined behavior in theory.
8763 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8765 Use functions, not macros, for up- and down-casing (Bug#8254).
8766 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8767 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8768 to use the following functions instead of these macros.
8769 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8770 EMACS_INT, since callers assume the returned value fits in int.
8771 (upcase1): Likewise, for UPCASE_TABLE.
8772 (uppercasep, lowercasep, upcase): New static inline functions.
8773 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8774 the race-condition problem in the old DOWNCASE.
8776 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8777 Rename locals to avoid shadowing.
8778 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8779 (regex_compile, re_search_2, re_match_2_internal):
8780 Remove unused local vars.
8781 (FREE_VAR): Rewrite so as not to use empty "else",
8782 which gcc can warn about.
8783 (regex_compile, re_match_2_internal): Mark locals as initialized.
8784 (RETALLOC_IF): Define only if needed.
8785 (WORDCHAR_P): Likewise. This one is never needed, but is used
8786 only in a comment talking about a compiler bug, so put inside
8787 the #if 0 of that comment.
8788 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8789 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8792 * search.c (boyer_moore): Rename locals to avoid shadowing.
8793 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8794 (PREV_CHAR_BOUNDARY): Likewise.
8796 * search.c (simple_search): Remove unused var.
8798 * dired.c (compile_pattern): Move decl from here ...
8799 * lisp.h: ... to here, so that it can be checked.
8800 (struct re_registers): New forward decl.
8802 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8804 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8806 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8807 Rename locals to avoid shadowing.
8808 (Fvertical_motion): Mark locals as initialized.
8810 * casefiddle.c (casify_object, casify_region): Now static.
8811 (casify_region): Mark local as initialized.
8813 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8815 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8816 New macros, so that the caller can use some names other than
8817 gcpro1, gcpro2, etc.
8818 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8820 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8821 argument, for consistency with GCPRO2_VAR, etc: it is now the
8822 prefix of the variable, not the variable itself. All uses
8824 * dired.c (directory_files_internal, file_name_completion):
8825 Rename locals to avoid shadowing.
8827 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8828 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8829 dired.c's scmp function, had undefined behavior.
8830 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8831 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8832 * buffer.h: ... to here, because these macros use current_buffer,
8833 and the new implementation with inline functions needs to have
8834 current_buffer in scope now, rather than later when the macros
8836 (downcase, upcase1): New static inline functions.
8837 (DOWNCASE, UPCASE1): Reimplement using these functions.
8838 This avoids undefined behavior in expressions like
8839 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8840 from race conditions in accessing the global variables
8841 case_temp1 and case_temp2.
8842 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8843 * lisp.h (case_temp1, case_temp2): Remove their decls.
8844 * character.h (ASCII_CHAR_P): Move from here ...
8845 * lisp.h: ... to here, so that the inline functions mentioned
8848 * dired.c (directory_files_internal_unwind): Now static.
8850 * fileio.c (file_name_as_directory, directory_file_name):
8851 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8853 (file_name_as_directory): Use const pointers when appropriate.
8854 (Fexpand_file_name): Likewise. In particular, newdir might
8855 point at constant storage, so make it a const pointer.
8856 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8857 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8859 (Fset_file_times, Finsert_file_contents, auto_save_error):
8860 Rename locals to avoid shadowing.
8862 * minibuf.c (choose_minibuf_frame_1): Now static.
8863 (Ftry_completion, Fall_completions): Rename or remove locals
8866 * marker.c (bytepos_to_charpos): Remove; unused.
8868 * lisp.h (verify_bytepos, count_markers): New decls,
8869 so that gcc does not warn that these functions aren't declared.
8871 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8872 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8873 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8874 (copy_text): Remove unused local var.
8876 * filelock.c (within_one_second): Now static.
8877 (lock_file_1): Rename local to avoid shadowing.
8879 * buffer.c (fix_overlays_before): Mark locals as initialized.
8880 (fix_start_end_in_overlays): Likewise. This function should be
8881 simplified by using pointers-to-pointers, but that's a different
8883 (switch_to_buffer_1): Now static.
8884 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8885 (report_overlay_modification): Rename locals to avoid shadowing.
8887 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8888 Fix pointer signedness issue.
8889 (sys_subshell): Mark local as volatile if checking for lint,
8890 to suppress a gcc -Wclobbered warning that does not seem to be right.
8891 (MAXPATHLEN): Define only if needed.
8893 * process.c (serial_open, serial_configure): Move decls from here ...
8894 * systty.h: ... to here, so that they can be checked.
8896 * fns.c (get_random, seed_random): Move extern decls from here ...
8897 * lisp.h: ... to here, so that they can be checked.
8899 * sysdep.c (reset_io): Now static.
8900 (wait_for_termination_signal): Remove; unused.
8902 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8903 (copy_keymap_item, append_key, push_text_char_description):
8905 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8906 (DENSE_TABLE_SIZE): Remove; unused.
8907 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8908 (describe_map_tree):
8909 Rename locals to avoid shadowing.
8911 * keyboard.c: Declare functions static if they are not used elsewhere.
8912 (echo_char, echo_dash, cmd_error, top_level_2):
8913 (poll_for_input, handle_async_input): Now static.
8914 (read_char, kbd_buffer_get_event, make_lispy_position):
8915 (make_lispy_event, make_lispy_movement, apply_modifiers):
8916 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8917 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8918 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8919 (read_key_sequence, read_char): Mark locals as initialized.
8920 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8922 * keyboard.h (make_ctrl_char): New decl.
8923 (mark_kboards): Move decl here ...
8924 * alloc.c (mark_kboards): ... from here.
8926 * lisp.h (force_auto_save_soon): New decl.
8928 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8929 (DEFINE_DUMMY_FUNCTION): New macro.
8930 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8932 (main): Add casts to avoid warnings
8933 if GCC considers string literals to be constants.
8935 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8937 * dbusbind.c: Pointer signedness fixes.
8938 (xd_signature, xd_append_arg, xd_initialize):
8939 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8940 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8941 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8942 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8944 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8945 if GCC considers string literals to be constants.
8946 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8948 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8950 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8951 (print_preprocess, print_object): New macro to fix last change.
8953 * print.c (print_preprocess): Don't forget font objects.
8955 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8957 * emacs.c (USAGE3): Doc fixes.
8959 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8961 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8964 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8966 * lisp.h (VWindow_system, Qfile_name_history):
8967 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8968 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8969 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8971 * w32select.c: Don't #include "keyboard.h".
8972 (run_protected): Add extern declaration for waiting_for_input.
8974 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8975 * w32console.c (detect_input_pending, read_input_pending)
8976 (encode_terminal_code):
8977 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8978 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8979 (w32_system_caret_y, Qfile_name_history):
8980 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8981 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8982 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8983 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8984 * w32proc.c (Qlocal, report_file_error):
8985 * w32term.c (Vwindow_system, updating_frame):
8986 * w32uniscribe.c (initialized, uniscribe_font_driver):
8987 Remove unneeded extern declarations.
8989 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8991 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8993 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8995 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8996 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8997 These macros can no longer be used for assignment.
8999 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9000 Assign struct members directly, instead of using BUF_BEGV etc.
9001 (record_buffer_markers, fetch_buffer_markers): New functions for
9002 recording and fetching special buffer markers.
9003 (set_buffer_internal_1, set_buffer_temp): Use them.
9005 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9007 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9009 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9010 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9012 * xdisp.c (hscroll_window_tree):
9013 (reconsider_clip_changes): Use PT instead of BUF_PT.
9015 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9017 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9018 $(EMACS_ROOT)/lib/intprops.h.
9020 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9022 Fix more problems found by GCC 4.5.2's static checks.
9024 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9025 to unsigned char * to avoid compiler diagnostic.
9026 (xg_free_frame_widgets): Make it clear that a local variable is
9027 needed only if USE_GTK_TOOLTIP.
9028 (gdk_window_get_screen): Make it clear that this macro is needed
9029 only if USE_GTK_TOOLTIP.
9030 (int_gtk_range_get_value): New function, which avoids a diagnostic
9031 from gcc -Wbad-function-cast.
9032 (xg_set_toolkit_scroll_bar_thumb): Use it.
9033 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9034 diagnostic from gcc -Wbad-function-cast.
9035 (get_utf8_string, xg_get_file_with_chooser):
9036 Rename locals to avoid shadowing.
9037 (create_dialog): Move locals to avoid shadowing.
9039 * xgselect.c (xg_select): Remove unused var.
9041 * image.c (four_corners_best): Mark locals as initialized.
9042 (gif_load): Initialize transparent_p to zero (Bug#8238).
9043 Mark another local as initialized.
9044 (my_png_error, my_error_exit): Mark with NO_RETURN.
9046 * image.c (clear_image_cache): Now static.
9047 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9048 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9049 (x_edge_detection): Remove unnecessary cast that
9050 gcc -Wbad-function-cast diagnoses.
9051 (gif_load): Fix pointer signedness.
9052 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9053 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9055 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9057 Improve quality of tests for time stamp overflow.
9058 For example, without this patch (encode-time 0 0 0 1 1
9059 1152921504606846976) returns the obviously-bogus value (-948597
9060 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9061 reports time overflow. See
9062 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9063 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9064 * editfns.c: Include limits.h and intprops.h.
9065 (TIME_T_MIN, TIME_T_MAX): New macros.
9066 (time_overflow): Move earlier, to before first use.
9067 (hi_time, lo_time): New functions, for an accurate test for
9069 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9070 (Fget_internal_run_time): Don't assume time_t fits in int.
9071 (make_time): Use list2 instead of Fcons twice.
9072 (Fdecode_time): More accurate test for out-of-range times.
9073 (check_tm_member): New function.
9074 (Fencode_time): Use it, to test for out-of-range times.
9075 (lisp_time_argument): Don't rely on undefined left-shift and
9076 right-shift behavior when checking for time stamp overflow.
9078 * editfns.c (time_overflow): New function, refactoring common code.
9079 (Fformat_time_string, Fdecode_time, Fencode_time):
9080 (Fcurrent_time_string): Use it.
9082 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9083 * dired.c (make_time): Move to ...
9084 * editfns.c (make_time): ... here.
9085 * systime.h: Note the move.
9087 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9089 * fringe.c (update_window_fringes): Remove unused variables.
9091 * unexmacosx.c (copy_data_segment): Also copy __got section.
9094 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9096 * termcap.c [MSDOS]: Include "msdos.h".
9097 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9098 Constify `char *' arguments and their references according to
9099 prototypes in tparam.h.
9101 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9103 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9104 Adapt all references accordingly.
9106 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9108 2011-03-11 Tom Tromey <tromey@redhat.com>
9110 * buffer.c (syms_of_buffer): Remove obsolete comment.
9112 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9114 * termhooks.h (encode_terminal_code): Declare prototype.
9116 * msdos.c (encode_terminal_code): Don't declare prototype.
9118 * term.c (encode_terminal_code): Now external again, used by
9119 w32console.c and msdos.c.
9121 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9122 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9124 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9126 Fix some minor problems found by GCC 4.5.2's static checks.
9128 * fringe.c (update_window_fringes): Mark locals as initialized
9130 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9132 * alloc.c (mark_fringe_data): Move decl from here ...
9133 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9134 to check its interface.
9135 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9137 * fontset.c (free_realized_fontset): Now static.
9138 (Fset_fontset_font): Rename local to avoid shadowing.
9139 (fontset_font): Mark local as initialized.
9140 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9142 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9144 * xselect.c (x_disown_buffer_selections): Remove; not used.
9145 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9146 (x_own_selection, Fx_disown_selection_internal): Rename locals
9148 (x_handle_dnd_message): Remove local to avoid shadowing.
9150 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9151 so that the caller can use some name other than gcpro1.
9152 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9153 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9154 (Fx_backspace_delete_keys_p):
9155 Use them to avoid shadowing, and rename vars to avoid shadowing.
9156 (x_decode_color, x_set_name, x_window): Now static.
9157 (Fx_create_frame): Add braces to silence GCC warning.
9158 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9159 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9160 Remove unused locals.
9161 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9162 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9163 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9166 * xterm.h (x_mouse_leave): New decl.
9168 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9169 Remove unused functions.
9170 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9171 (x_calc_absolute_position): Now static.
9172 (XTread_socket): Don't define label "out" unless it's used.
9173 Don't declare local "event" unless it's used.
9174 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9175 unless they are used.
9176 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9177 (x_fatal_error_signal): Remove; not used.
9178 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9179 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9180 (x_error_catcher, x_connection_closed, x_error_handler):
9181 (x_error_quitter, xembed_send_message, x_iconify_frame):
9182 (my_log_handler): Rename locals to avoid shadowing.
9183 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9184 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9186 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9187 Rename or move locals to avoid shadowing.
9188 (tty_defined_color, merge_face_heights): Now static.
9189 (free_realized_faces_for_fontset): Remove; not used.
9190 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9191 does not deduce is never used uninitialized.
9192 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9193 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9195 * terminal.c (store_terminal_param): Now static.
9197 * xmenu.c (menu_highlight_callback): Now static.
9198 (set_frame_menubar): Remove unused local.
9199 (xmenu_show): Rename parameter to avoid shadowing.
9200 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9201 since they might point to immutable storage.
9202 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9203 since it's unused otherwise.
9205 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9206 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9207 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9208 avoids a gcc -Wuninitialized diagnostic.
9209 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9210 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9211 does not deduce are never used uninitialized.
9213 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9215 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9216 * window.c (window_loop, size_window):
9217 (run_window_configuration_change_hook, enlarge_window): Likewise.
9219 * window.c (display_buffer): Now static.
9220 (size_window): Mark variables that gcc -Wuninitialized
9221 does not deduce are never used uninitialized.
9222 * window.h (check_all_windows): New decl, to forestall
9223 gcc -Wmissing-prototypes diagnostic.
9224 * dispextern.h (bidi_dump_cached_states): Likewise.
9226 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9228 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9230 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9231 and to avoid gcc -Wuninitialized warning.
9232 (load_charset_map): Mark variables that gcc -Wuninitialized
9233 does not deduce are never used uninitialized.
9234 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9236 * coding.c (coding_set_source, coding_set_destination):
9237 Use "else { /* comment */ }" rather than "else /* comment */;"
9238 for clarity, and to avoid gcc -Wempty-body warning.
9239 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9240 a block, when the outer 'i' will do.
9241 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9242 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9243 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9244 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9245 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9246 Rename locals to avoid shadowing.
9247 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9248 * coding.c (emacs_mule_char, encode_invocation_designation):
9249 Now static, since they're not used elsewhere.
9250 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9251 (decode_coding_object, encode_coding_object, detect_coding_system):
9252 (decode_coding_emacs_mule): Mark variables that gcc
9253 -Wuninitialized does not deduce are never used uninitialized.
9254 (detect_coding_iso_2022): Initialize a local variable that might
9255 be used uninitialized. Leave a FIXME because it's not clear that
9256 this initialization is needed. (Bug#8211)
9257 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9258 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9259 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9260 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9261 Remove unused macros.
9263 * category.c (hash_get_category_set): Remove unused local var.
9264 (copy_category_table): Now static, since it's not used elsewhere.
9265 * character.c (string_count_byte8): Likewise.
9267 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9268 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9270 * chartab.c (copy_sub_char_table): Now static, since it's not used
9272 (sub_char_table_ref_and_range, char_table_ref_and_range):
9273 Rename locals to avoid shadowing.
9274 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9276 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9277 (BIDI_BOB): Remove unused macro.
9279 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9280 deduce are never used uninitialized.
9281 * term.c (encode_terminal_code): Likewise.
9283 * term.c (encode_terminal_code): Now static. Remove unused local.
9285 * tparam.h: New file.
9286 * term.c, tparam.h: Include it.
9287 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9288 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9289 Move these decls to tparam.h, and make them agree with what
9290 is actually in tparam.c. The previous trick of using incompatible
9291 decls in different modules does not conform to the C standard.
9292 All callers of tparam changed to use tparam's actual API.
9293 * tparam.c (tparam1, tparam, tgoto):
9294 Use const pointers where appropriate.
9296 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9297 * cm.h (struct cm): Likewise.
9298 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9299 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9300 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9301 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9302 (turn_on_face, init_tty): Likewise.
9303 * termchar.h (struct tty_display_info): Likewise.
9305 * term.c (term_mouse_position): Rename local to avoid shadowing.
9307 * alloc.c (mark_ttys): Move decl from here ...
9308 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9310 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9312 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9314 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9316 * search.c (compile_pattern_1): Remove argument regp, unused since
9317 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9318 (compile_pattern): Don't pass it.
9320 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9322 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9323 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9325 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9327 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9329 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9330 gdk_window_get_screen, gdk_window_get_geometry,
9331 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9332 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9333 (xg_get_pixbuf_from_pixmap): New function.
9334 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9335 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9336 Call xg_get_pixbuf_from_pixmap instead of
9337 gdk_pixbuf_get_from_drawable.
9338 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9339 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9340 (xg_check_special_colors): Use GtkStyleContext and its functions
9342 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9343 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9344 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9345 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9346 Call gtk_widget_get_preferred_size.
9347 (xg_frame_resized): gdk_window_get_geometry only takes 5
9349 (xg_win_to_widget, xg_event_is_for_menubar):
9350 Call gdk_x11_window_lookup_for_display.
9351 (xg_set_widget_bg): New function.
9352 (delete_cb): New function.
9353 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9354 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9355 (xg_set_background_color): Call xg_set_widget_bg.
9356 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9357 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9358 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9359 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9361 (update_frame_tool_bar): Call gtk_widget_hide.
9362 (xg_initialize): Use GDK_KEY_g.
9364 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9366 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9368 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9369 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9370 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9372 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9374 * w32xfns.c (select_palette): Check success of RealizePalette against
9375 GDI_ERROR, not zero.
9377 See ChangeLog.11 for earlier changes.
9383 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9385 This file is part of GNU Emacs.
9387 GNU Emacs is free software: you can redistribute it and/or modify
9388 it under the terms of the GNU General Public License as published by
9389 the Free Software Foundation, either version 3 of the License, or
9390 (at your option) any later version.
9392 GNU Emacs is distributed in the hope that it will be useful,
9393 but WITHOUT ANY WARRANTY; without even the implied warranty of
9394 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9395 GNU General Public License for more details.
9397 You should have received a copy of the GNU General Public License
9398 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.