* buffer.c (struct sortstr.size, record_overlay_string): Don't truncate size to int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.c (struct sortvec.priority, struct sortstr.priority):
4 Now EMACS_INT, not int.
5 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6 (struct sortstr.size, record_overlay_string): Don't truncate size to int.
7
8 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9
10 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13
14 Improve buffer-overflow checking (Bug#8873).
15 * fileio.c (Finsert_file_contents):
16 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
17 Remove the old (too-loose) buffer overflow checks.
18 They weren't needed, since make_gap checks for buffer overflow.
19 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
20 The old code merely checked for Emacs fixnum overflow, and relied
21 on undefined (wraparound) behavior. The new code avoids undefined
22 behavior, and also checks for ptrdiff_t and/or size_t overflow.
23
24 * editfns.c (Finsert_char): Don't dump core with very negative counts.
25 Tune. Don't use wider integers than needed. Don't use alloca.
26 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
27
28 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
29
30 * insdel.c, lisp.h (buffer_overflow): New function.
31 (insert_from_buffer_1, replace_range, replace_range_2):
32 * insdel.c (make_gap_larger):
33 * editfns.c (Finsert_char):
34 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
35
36 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
37
38 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
39
40 Integer overflow and signedness fixes (Bug#8873).
41
42 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
43 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
44
45 * fileio.c: Don't assume EMACS_INT fits in off_t.
46 (emacs_lseek): New static function.
47 (Finsert_file_contents, Fwrite_region): Use it.
48 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
49
50 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
51
52 * fns.c: Don't overflow int when computing a list length.
53 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
54 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
55 truncation on 64-bit hosts. Check for QUIT every
56 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
57 faster and is responsive enough.
58 (Flength): Report an error instead of overflowing an integer.
59 (Fsafe_length): Return a float if the value is not representable
60 as a fixnum. This shouldn't happen except in contrived situations.
61 (Fnthcdr, Fsort): Don't assume list length fits in int.
62 (Fcopy_sequence): Don't assume vector length fits in int.
63
64 * alloc.c: Check that resized vectors' lengths fit in fixnums.
65 (header_size, word_size): New constants.
66 (allocate_vectorlike): Don't check size overflow here.
67 (allocate_vector): Check it here instead, since this is the only
68 caller of allocate_vectorlike that could cause overflow.
69 Check that the new vector's length is representable as a fixnum.
70
71 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
72 The previous code was bogus. For example, next_almost_prime (32)
73 returned 39, which is undesirable as it is a multiple of 3; and
74 next_almost_prime (24) returned 25, which is a multiple of 5 so
75 why was the code bothering to check for multiples of 7?
76
77 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
78
79 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
80
81 Variadic C functions now count arguments with ptrdiff_t.
82 This partly undoes my 2011-03-30 change, which replaced int with size_t.
83 Back then I didn't know that the Emacs coding style prefers signed int.
84 Also, in the meantime I found a few more instances where arguments
85 were being counted with int, which may truncate counts on 64-bit
86 machines, or EMACS_INT, which may be unnecessarily wide.
87 * lisp.h (struct Lisp_Subr.function.aMANY)
88 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
89 Arg counts are now ptrdiff_t, not size_t.
90 All variadic functions and their callers changed accordingly.
91 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
92 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
93 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
94 * callint.c (Fcall_interactively): Check arg count for overflow,
95 to avoid potential buffer overrun. Use signed char, not 'int',
96 for 'varies' array, so that we needn't bother to check its size
97 calculation for overflow.
98 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
99 * eval.c (apply_lambda):
100 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
101 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
102 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
103
104 * callint.c (Fcall_interactively): Don't use index var as event count.
105
106 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
107 * mem-limits.h (SIZE): Remove; no longer used.
108
109 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
110
111 Remove unnecessary casts.
112 * xterm.c (x_term_init):
113 * xfns.c (x_set_border_pixel):
114 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
115 These aren't needed now that we assume ANSI C.
116
117 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
118 It's more likely to cause problems (due to unsigned overflow)
119 than to cure them.
120
121 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
122
123 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
124
125 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
126
127 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
128
129 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
130
131 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
132
133 GLYPH_CODE_FACE returns EMACS_INT, not int.
134 * dispextern.h (merge_faces):
135 * xfaces.c (merge_faces):
136 * xdisp.c (get_next_display_element, next_element_from_display_vector):
137 Don't assume EMACS_INT fits in int.
138
139 * character.h (CHAR_VALID_P): Remove unused parameter.
140 * fontset.c, lisp.h, xdisp.c: All uses changed.
141
142 * editfns.c (Ftranslate_region_internal): Omit redundant test.
143
144 * fns.c (concat): Minor tuning based on overflow analysis.
145 This doesn't fix any bugs. Use int to hold character, instead
146 of constantly refetching from Emacs object. Use XFASTINT, not
147 XINT, for value known to be a character. Don't bother comparing
148 a single byte to 0400, as it's always less.
149
150 * floatfns.c (Fexpt):
151 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
152
153 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
154 for characters.
155
156 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
157
158 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
159 Without this fix, on a 64-bit host (aset S 0 4294967386) would
160 incorrectly succeed when S was a string, because 4294967386 was
161 truncated before it was used.
162
163 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
164 Otherwise, an out-of-range integer could cause undefined behavior
165 on a 64-bit host.
166
167 * composite.c: Use int, not EMACS_INT, for characters.
168 (fill_gstring_body, composition_compute_stop_pos): Use int, not
169 EMACS_INT, for values that are known to be in character range.
170 This doesn't fix any bugs but is the usual style inside Emacs and
171 may generate better code on 32-bit machines.
172
173 Make sure a 64-bit char is never passed to ENCODE_CHAR.
174 This is for reasons similar to the recent CHAR_STRING fix.
175 * charset.c (Fencode_char): Check that character arg is actually
176 a character. Pass an int to ENCODE_CHAR.
177 * charset.h (ENCODE_CHAR): Verify that the character argument is no
178 wider than 'int', as a compile-time check to prevent future regressions
179 in this area.
180
181 * character.c (char_string): Remove unnecessary casts.
182
183 Make sure a 64-bit char is never passed to CHAR_STRING.
184 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
185 by silently ignoring the top 32 bits, allowing some values
186 that were far too large to be valid characters.
187 * character.h: Include <verify.h>.
188 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
189 arguments are no wider than unsigned, as a compile-time check
190 to prevent future regressions in this area.
191 * data.c (Faset):
192 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
193 (Fsubst_char_in_region):
194 * fns.c (concat):
195 * xdisp.c (decode_mode_spec_coding):
196 Adjust to CHAR_STRING's new requirement.
197 * editfns.c (Finsert_char, Fsubst_char_in_region):
198 * fns.c (concat): Check that character args are actually
199 characters. Without this test, these functions did the wrong
200 thing with wildly out-of-range values on 64-bit hosts.
201
202 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
203 These casts should not be needed on 32-bit hosts, either.
204 * keyboard.c (read_char):
205 * lread.c (Fload): Remove casts to unsigned.
206
207 * lisp.h (UNSIGNED_CMP): New macro.
208 This fixes comparison bugs on 64-bit hosts.
209 (ASCII_CHAR_P): Use it.
210 * casefiddle.c (casify_object):
211 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
212 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
213 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
214 * dispextern.h (FACE_FROM_ID):
215 * keyboard.c (read_char): Use UNSIGNED_CMP.
216
217 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
218 not to EMACS_INT, to avoid GCC warning.
219
220 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
221
222 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
223 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
224 isn't needed on 32-bit machines.
225
226 * buffer.c (Fgenerate_new_buffer_name):
227 Use EMACS_INT for count, not int.
228 (advance_to_char_boundary): Return EMACS_INT, not int.
229
230 * data.c (Qcompiled_function): Now static.
231
232 * window.c (window_body_lines): Now static.
233
234 * image.c (gif_load): Rename local to avoid shadowing.
235
236 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
237 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
238 * alloc.c (make_save_value): Integer argument is now of type
239 ptrdiff_t, not int.
240 (mark_object): Use ptrdiff_t, not int.
241 * lisp.h (pD): New macro.
242 * print.c (print_object): Use it.
243
244 * alloc.c: Use EMACS_INT, not int, to count objects.
245 (total_conses, total_markers, total_symbols, total_vector_size)
246 (total_free_conses, total_free_markers, total_free_symbols)
247 (total_free_floats, total_floats, total_free_intervals)
248 (total_intervals, total_strings, total_free_strings):
249 Now EMACS_INT, not int. All uses changed.
250 (Fgarbage_collect): Compute overall total using a double, so that
251 integer overflow is less likely to be a problem. Check for overflow
252 when converting back to an integer.
253 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
254 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
255 These were 'int' variables that could overflow on 64-bit hosts;
256 they were never used, so remove them instead of repairing them.
257 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
258 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
259 Previously, this ceilinged at INT_MAX, but that doesn't work on
260 64-bit machines.
261 (allocate_pseudovector): Don't use EMACS_INT when int would do.
262
263 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
264 (allocate_vectorlike): Check for ptrdiff_t overflow.
265 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
266 when a (possibly-narrower) signed value would do just as well.
267 We prefer using signed arithmetic, to avoid comparison confusion.
268
269 * alloc.c: Catch some string size overflows that we were missing.
270 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
271 for convenience in STRING_BYTES_MAX.
272 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
273 The definition here is exact; the one in lisp.h was approximate.
274 (allocate_string_data): Check for string overflow. This catches
275 some instances we weren't catching before. Also, it catches
276 size_t overflow on (unusual) hosts where SIZE_MAX <= min
277 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
278 and ptrdiff_t and EMACS_INT are both 64 bits.
279
280 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
281 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
282 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
283
284 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
285
286 * alloc.c (Fmake_string): Check for out-of-range init.
287
288 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
291
292 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
293
294 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
295 xg_get_default_scrollbar_width.
296
297 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
298 (int_gtk_range_get_value): Move to the scroll bar part of the file.
299 (style_changed_cb): Call update_theme_scrollbar_width and call
300 x_set_scroll_bar_default_width and xg_frame_set_char_size for
301 all frames (Bug#8505).
302 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
303 Call gtk_window_set_resizable if HAVE_GTK3.
304 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
305 and height if HAVE_GTK3 (Bug#8505).
306 (scroll_bar_width_for_theme): New variable.
307 (update_theme_scrollbar_width): New function.
308 (xg_get_default_scrollbar_width): Move code to
309 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
310 (xg_initialize): Call update_theme_scrollbar_width.
311
312 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
313
314 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
315
316 2011-06-12 Martin Rudalics <rudalics@gmx.at>
317
318 * frame.c (make_frame): Call other_buffer_safely instead of
319 other_buffer.
320
321 * window.c (temp_output_buffer_show): Call display_buffer with
322 second argument Vtemp_buffer_show_specifiers and reset latter
323 immediately after the call.
324 (Vtemp_buffer_show_specifiers): New variable.
325 (auto_window_vscroll_p, next_screen_context_lines)
326 (Vscroll_preserve_screen_position): Remove leading asterisks from
327 doc-strings.
328
329 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
330
331 Fix minor problems found by GCC 4.6.0 static checking.
332 * buffer.c (Qclone_number): Remove for now, as it's unused.
333 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
334 (record_buffer): Remove unused local.
335 * frame.c (other_visible_frames, frame_buffer_list): Now static.
336 (set_frame_buffer_list): Remove; unused.
337 * frame.h (other_visible_frames): Remove decl.
338 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
339 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
340 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
341 if HAVE_GPM.
342 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
343 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
344 Define only if HAVE_GPM.
345 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
346 (update_hints_inhibit): Remove; never set. All uses removed.
347 * widgetprv.h (emacsFrameClassRec): Remove decl.
348 * window.c (delete_deletable_window): Now returns void, since it
349 wasn't returning anything.
350 (compare_window_configurations): Remove unused locals.
351 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
352 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
353 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
354 the same widths as pointers. This follows up on the 2011-05-06 patch.
355 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
356 * xterm.h: Likewise.
357 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
358
359 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
360
361 * makefile.w32-in: Update dependencies.
362 (LISP_H): Add lib/intprops.h.
363
364 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
365
366 * image.c (gif_load): Add animation frame delay to the metadata.
367 (syms_of_image): Use DEFSYM. New symbol `delay'.
368
369 2011-06-11 Martin Rudalics <rudalics@gmx.at>
370
371 * window.c (delete_deletable_window): Re-add.
372 (Fset_window_configuration): Rewrite to handle dead buffers and
373 consequently deletable windows.
374 (window_tree, Fwindow_tree): Remove. Supply functionality in
375 window.el.
376 (compare_window_configurations): Simplify code.
377
378 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
379
380 * image.c (imagemagick_load_image): Fix type mismatch.
381 (Fimagemagick_types): Likewise.
382
383 * window.h (replace_buffer_in_windows): Declare.
384
385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
386
387 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
388 Qclone_number. Remove external declaration of Qdelete_window.
389 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
390 code.
391 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
392 Qbuffer_list_update_hook if allowed.
393 (Fother_buffer): Rewrite doc-string. Major rewrite for new
394 buffer list implementation.
395 (other_buffer_safely): New function.
396 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
397 calls to replace_buffer_in_windows and
398 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
399 if allowed.
400 (record_buffer): Inhibit quitting and rewrite using quittable
401 functions. Run Qbuffer_list_update_hook if allowed.
402 (Frecord_buffer, Funrecord_buffer): New functions.
403 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
404 switch-to-buffer to window.el.
405 (bury-buffer): Move to window.el.
406 (Vbuffer_list_update_hook): New variable.
407
408 * lisp.h (other_buffer_safely): Add prototype in buffer.c
409 section.
410
411 * window.h (resize_frame_windows): Move up in code.
412 (Fwindow_frame): Remove EXFUN.
413 (replace_buffer_in_all_windows): Remove prototype.
414 (replace_buffer_in_windows_safely): Add prototype.
415
416 * window.c: Declare Qdelete_window static again. Move down
417 declaration of select_count.
418 (Fnext_window, Fprevious_window): Rewrite doc-strings.
419 (Fother_window): Move to window.el.
420 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
421 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
422 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
423 window.el.
424 (replace_buffer_in_windows): Implement by calling
425 Qreplace_buffer_in_windows.
426 (replace_buffer_in_all_windows): Remove with some functionality
427 moved into replace_buffer_in_windows_safely.
428 (replace_buffer_in_windows_safely): New function.
429 (select_window_norecord, select_frame_norecord): Move in front
430 of run_window_configuration_change_hook. Remove now obsolete
431 declarations.
432 (Fset_window_buffer): Rewrite doc-string. Call
433 Qrecord_window_buffer.
434 (keys_of_window): Move binding for other-window to window.el.
435
436 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
437
438 * dispextern.h (struct image): Replace data member, whose int_val
439 and ptr_val fields were not used by anything, with a single
440 lisp_val object.
441
442 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
443 (gif_clear_image, gif_load, imagemagick_load_image)
444 (gs_clear_image, gs_load): Callers changed.
445
446 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
447
448 * buffer.h: Include <time.h>, for time_t.
449 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
450
451 Fix minor problems found by static checking.
452
453 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
454
455 Make identifiers static if they are not used in other modules.
456 * data.c (Qcompiled_function, Qframe, Qvector):
457 * image.c (QimageMagick, Qsvg):
458 * minibuf.c (Qmetadata):
459 * window.c (resize_window_check, resize_root_window): Now static.
460 * window.h (resize_window_check, resize_root_window): Remove decls.
461
462 * window.c (window_deletion_count, delete_deletable_window):
463 Remove; unused.
464 (window_body_lines): Now static.
465 (Fdelete_other_windows_internal): Mark vars as initialized.
466 Make sure 'resize_failed' is initialized.
467 (run_window_configuration_change_hook): Rename local to avoid shadowing.
468 (resize_window_apply): Remove unused local.
469 * window.h (delete_deletable_window): Remove decl.
470
471 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
472 (imagemagick_load_image): Fix pointer signedness problem by changing
473 last arg from unsigned char * to char *. All uses changed.
474 Also, fix a local for similar reasons.
475 Remove unused locals. Remove locals to avoid shadowing.
476 (fn_rsvg_handle_free): Remove; unused.
477 (svg_load, svg_load_image): Fix pointer signedness problem.
478 (imagemagick_load_image): Don't use garbage pointer image_wand.
479
480 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
481
482 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
483
484 * image.c (gif_load): Fix omitted cast error introduced by
485 2011-06-06 change.
486
487 2011-06-10 Martin Rudalics <rudalics@gmx.at>
488
489 * window.h (resize_proportionally, orig_total_lines)
490 (orig_top_line): Remove from window structure.
491 (set_window_height, set_window_width, change_window_heights)
492 (Fdelete_window): Remove prototypes.
493 (resize_frame_windows): Remove duplicate declaration.
494
495 2011-06-10 Eli Zaretskii <eliz@gnu.org>
496
497 * window.h (resize_frame_windows, resize_window_check)
498 (delete_deletable_window, resize_root_window)
499 (resize_frame_windows): Declare prototypes.
500
501 * window.c (resize_window_apply): Make definition be "static" to
502 match the prototype.
503
504 2011-06-10 Martin Rudalics <rudalics@gmx.at>
505
506 * window.c: Remove declarations of Qwindow_size_fixed,
507 window_min_size_1, window_min_size_2, window_min_size,
508 size_window, window_fixed_size_p, enlarge_window, delete_window.
509 Remove static from declaration of Qdelete_window, it's
510 temporarily needed by Fbury_buffer.
511 (replace_window): Don't assign orig_top_line and
512 orig_total_lines.
513 (Fdelete_window, delete_window): Remove. Window deletion is
514 handled by window.el.
515 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
516 Fdelete_window calls with calls to Qdelete_window.
517 (Fdelete_other_windows): Remove. Deleting other windows is
518 handled by window.el.
519 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
520 handled in window.el.
521 (window_min_size_2, window_min_size_1, window_min_size): Remove.
522 Window minimum sizes are handled in window.el.
523 (shrink_windows, size_window, set_window_height)
524 (set_window_width, change_window_heights, window_height)
525 (window_width, CURBEG, CURSIZE, enlarge_window)
526 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
527 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
528 handled in window.el.
529 (make_dummy_parent): Rename to make_parent_window and give it a
530 second argument horflag.
531 (make_window): Don't set resize_proportionally any more.
532 (Fsplit_window): Remove. Windows are split in window.el.
533 (save_restore_action, save_restore_orig_size)
534 (shrink_window_lowest_first, save_restore_orig_size): Remove.
535 Resize mini windows in window.el.
536 (grow_mini_window, shrink_mini_window): Implement by calling
537 Qresize_root_window_vertically, resize_window_check and
538 resize_window_apply.
539 (saved_window, Fset_window_configuration, save_window_save): Do
540 not handle orig_top_line, orig_total_lines, and
541 resize_proportionally.
542 (window_min_height, window_min_width): Move to window.el.
543 (keys_of_window): Move bindings for delete-other-windows,
544 split-window, delete-window and enlarge-window to window.el.
545
546 * buffer.c: Temporarily extern Qdelete_window.
547 (Fbury_buffer): Temporarily call Qdelete_window instead of
548 Fdelete_window (Fbury_buffer will move to window.el soon).
549
550 * frame.c (set_menu_bar_lines_1): Remove code handling
551 orig_top_line and orig_total_lines.
552
553 * dispnew.c (adjust_frame_glyphs_initially): Don't use
554 set_window_height but set heights directly.
555 (change_frame_size_1): Use resize_frame_windows.
556
557 * xdisp.c (init_xdisp): Don't use set_window_height but set
558 heights directly.
559
560 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
561 resize_frame_windows instead of change_window_heights and run
562 run_window_configuration_change_hook.
563
564 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
565 instead of change_window_heights and run
566 run_window_configuration_change_hook.
567
568 2011-06-09 Martin Rudalics <rudalics@gmx.at>
569
570 * window.c (replace_window): Rename second argument REPLACEMENT to
571 NEW. New third argument SETFLAG. Rewrite.
572 (delete_window, make_dummy_parent): Call replace_window with
573 third argument 1.
574 (window_list_1): Move down in code.
575 (run_window_configuration_change_hook): Move set_buffer part
576 before select_frame_norecord part in order to unwind correctly.
577 Rename count1 to count.
578 (recombine_windows, delete_deletable_window, resize_root_window)
579 (Fdelete_other_windows_internal)
580 (Frun_window_configuration_change_hook, make_parent_window)
581 (resize_window_check, resize_window_apply, Fresize_window_apply)
582 (resize_frame_windows, Fsplit_window_internal)
583 (Fdelete_window_internal, Fresize_mini_window_internal): New
584 functions.
585 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
586
587 2011-06-08 Martin Rudalics <rudalics@gmx.at>
588
589 * window.h (window): Add some new members to window structure -
590 normal_lines, normal_cols, new_total, new_normal, clone_number,
591 splits, nest, prev_buffers, next_buffers.
592 (WINDOW_TOTAL_SIZE): Move here from window.c.
593 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
594
595 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
596 Remove.
597 (make_dummy_parent): Set new members of windows structure.
598 (make_window): Move down in code. Handle new members of window
599 structure.
600 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
601 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
602 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
603 (Fset_window_prev_buffers, Fwindow_next_buffers)
604 (Fset_window_next_buffers, Fset_window_clone_number): New
605 functions.
606 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
607 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
608 Doc-string fixes.
609 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
610 Argument WINDOW can be now internal window too.
611 (Fwindow_use_time): Move up in code.
612 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
613 Rewrite doc-string.
614 (Fset_window_configuration, saved_window)
615 (Fcurrent_window_configuration, save_window_save): Handle new
616 members of window structure.
617 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
618 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
619 (syms_of_window): New Lisp objects Qrecord_window_buffer,
620 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
621 Qget_mru_window, Qresize_root_window,
622 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
623 Qauto_buffer_name; staticpro them.
624
625 2011-06-07 Martin Rudalics <rudalics@gmx.at>
626
627 * window.c (Fwindow_total_size, Fwindow_left_column)
628 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
629 (Fwindow_list_1): New functions.
630 (window_box_text_cols): Replace with window_body_cols.
631 (Fwindow_width, Fscroll_left, Fscroll_right): Use
632 window_body_cols instead of window_box_text_cols.
633 (delete_window, Fset_window_configuration): Call
634 delete_all_subwindows with window as argument.
635 (delete_all_subwindows): Take a window as argument and not a
636 structure. Rewrite.
637 (window_loop): Remove handling of GET_LRU_WINDOW and
638 GET_LARGEST_WINDOW.
639 (Fget_lru_window, Fget_largest_window): Move to window.el.
640
641 * window.h: Extern window_body_cols instead of
642 window_box_text_cols. delete_all_subwindows now takes a
643 Lisp_Object as argument.
644
645 * indent.c (compute_motion, Fcompute_motion): Use
646 window_body_cols instead of window_box_text_cols.
647
648 * frame.c (delete_frame): Call delete_all_subwindows with root
649 window as argument.
650
651 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
652
653 * fns.c (Fputhash): Document return value.
654
655 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
656
657 * image.c (gif_load): Implement gif89a spec "no disposal" method.
658
659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
660
661 Cons<->int and similar integer overflow fixes (Bug#8794).
662
663 Check for overflow when converting integer to cons and back.
664 * charset.c (Fdefine_charset_internal, Fdecode_char):
665 Use cons_to_unsigned to catch overflow.
666 (Fencode_char): Use INTEGER_TO_CONS.
667 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
668 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
669 * data.c (long_to_cons, cons_to_long): Remove.
670 (cons_to_unsigned, cons_to_signed): New functions.
671 These signal an error for invalid or out-of-range values.
672 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
673 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
674 * font.c (Ffont_variation_glyphs):
675 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
676 * lisp.h: Include <intprops.h>.
677 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
678 (cons_to_signed, cons_to_unsigned): New decls.
679 (long_to_cons, cons_to_long): Remove decls.
680 * undo.c (record_first_change): Use INTEGER_TO_CONS.
681 (Fprimitive_undo): Use CONS_TO_INTEGER.
682 * xfns.c (Fx_window_property): Likewise.
683 * xselect.c: Include <limits.h>.
684 (x_own_selection, selection_data_to_lisp_data):
685 Use INTEGER_TO_CONS.
686 (x_handle_selection_request, x_handle_selection_clear)
687 (x_get_foreign_selection, Fx_disown_selection_internal)
688 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
689 (lisp_data_to_selection_data): Use cons_to_unsigned.
690 (x_fill_property_data): Use cons_to_signed.
691 Report values out of range.
692
693 Check for buffer and string overflow more precisely.
694 * buffer.h (BUF_BYTES_MAX): New macro.
695 * lisp.h (STRING_BYTES_MAX): New macro.
696 * alloc.c (Fmake_string):
697 * character.c (string_escape_byte8):
698 * coding.c (coding_alloc_by_realloc):
699 * doprnt.c (doprnt):
700 * editfns.c (Fformat):
701 * eval.c (verror):
702 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
703 since they may not be the same number.
704 * editfns.c (Finsert_char):
705 * fileio.c (Finsert_file_contents):
706 Likewise for BUF_BYTES_MAX.
707
708 * image.c: Use ptrdiff_t, not int, for sizes.
709 (slurp_file): Switch from int to ptrdiff_t.
710 All uses changed.
711 (slurp_file): Check that file size fits in both size_t (for
712 malloc) and ptrdiff_t (for sanity and safety).
713
714 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
715 if b->modtime has its maximal value.
716
717 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
718
719 Don't assume time_t can fit into int.
720 * buffer.h (struct buffer.modtime): Now time_t, not int.
721 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
722 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
723
724 Minor fixes for signed vs unsigned integers.
725 * character.h (MAYBE_UNIFY_CHAR):
726 * charset.c (maybe_unify_char):
727 * keyboard.c (read_char, reorder_modifiers):
728 XINT -> XFASTINT, since the integer must be nonnegative.
729 * ftfont.c (ftfont_spec_pattern):
730 * keymap.c (access_keymap, silly_event_symbol_error):
731 XUINT -> XFASTINT, since the integer must be nonnegative.
732 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
733 since it makes no difference and we prefer signed.
734 * keyboard.c (record_char): Use XUINT when all the neighbors do.
735 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
736 nonnegative.
737
738 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * window.h (Fwindow_frame): Declare.
741
742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
743
744 * alloc.c: Simplify handling of large-request failures (Bug#8800).
745 (SPARE_MEMORY): Always define.
746 (LARGE_REQUEST): Remove.
747 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
748
749 2011-06-06 Martin Rudalics <rudalics@gmx.at>
750
751 * lisp.h: Move EXFUNS for Fframe_root_window,
752 Fframe_first_window and Fset_frame_selected_window to window.h.
753
754 * window.h: Move EXFUNS for Fframe_root_window,
755 Fframe_first_window and Fset_frame_selected_window here from
756 lisp.h.
757
758 * frame.c (Fwindow_frame, Fframe_first_window)
759 (Fframe_root_window, Fframe_selected_window)
760 (Fset_frame_selected_window): Move to window.c.
761 (Factive_minibuffer_window): Move to minibuf.c.
762 (Fother_visible_frames_p): New function.
763
764 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
765
766 * window.c (decode_window, decode_any_window): Move up in code.
767 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
768 (inhibit_frame_unsplittable): Remove unused variable.
769 (Fwindow_buffer): Move up and rewrite doc-string.
770 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
771 (Fwindow_prev): New functions.
772 (Fwindow_frame): Move here from frame.c. Accept any window as
773 argument.
774 (Fframe_root_window, Fframe_first_window)
775 (Fframe_selected_window): Move here from frame.c. Accept frame
776 or arbitrary window as argument. Update doc-strings.
777 (Fminibuffer_window): Move up in code.
778 (Fwindow_minibuffer_p): Move up in code and simplify.
779 (Fset_frame_selected_window): Move here from frame.c.
780 Marginal rewrite.
781 (Fselected_window, select_window, Fselect_window): Move up in
782 code. Minor doc-string fixes.
783
784 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
785
786 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
787 Do not assume that spare memory exists; that assumption is valid
788 only if SYSTEM_MALLOC.
789 (LARGE_REQUEST): New macro, so that the issue of large requests
790 is separated from the issue of spare memory.
791
792 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
793
794 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
795 format. (Bug#8806)
796
797 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
798
799 * xfns.c (x_set_scroll_bar_default_width): Move declarations
800 before statements.
801
802 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
803
804 * gtkutil.c (xg_get_default_scrollbar_width): New function.
805
806 * gtkutil.h: Declare xg_get_default_scrollbar_width.
807
808 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
809 min width by calling x_set_scroll_bar_default_width (Bug#8505).
810
811 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
812
813 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
814
815 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
816
817 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
818 (x_clipboard_manager_save): Add return value.
819 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
820 New error handlers.
821 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
822 Obey Vx_select_enable_clipboard_manager. Catch errors in
823 x_clipboard_manager_save (Bug#8779).
824 (Vx_select_enable_clipboard_manager): New variable.
825 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
826
827 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
828
829 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
830
831 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
832
833 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
834 in the current matrix if keep_current_p is non-zero.
835
836 2011-06-04 Eli Zaretskii <eliz@gnu.org>
837
838 * bidi.c (bidi_level_of_next_char): Fix last change.
839
840 2011-06-03 Eli Zaretskii <eliz@gnu.org>
841
842 Support bidi reordering of text covered by display properties.
843
844 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
845 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
846 (bidi_cache_search, bidi_cache_iterator_state)
847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
848 (bidi_level_of_next_char, bidi_move_to_visually_next):
849 Support character positions inside a run of characters covered by a
850 display string.
851 (bidi_paragraph_init, bidi_resolve_explicit_1)
852 (bidi_level_of_next_char): Call bidi_fetch_char and
853 bidi_fetch_char_advance instead of FETCH_CHAR and
854 FETCH_CHAR_ADVANCE.
855 (bidi_init_it): Initialize new members.
856 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
857 definitions.
858 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
859 instead of using explicit *_CHAR codes.
860 (bidi_resolve_explicit, bidi_resolve_weak):
861 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
862 bidirectional text is supported only in multibyte buffers.
863 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
864 it to initialize the frame_window_p member of struct bidi_it.
865 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
866 (bidi_resolve_explicit, bidi_resolve_weak)
867 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
868 bidi_it->nchars is non-positive.
869 (bidi_level_of_next_char): Don't try to lookup the cache for the
870 next/previous character if nothing is cached there yet, or if we
871 were just reseat()'ed to a new position.
872
873 * xdisp.c (set_cursor_from_row): Set start and stop points
874 according to the row's direction when priming the loop that looks
875 for the glyph on which to display cursor.
876 (single_display_spec_intangible_p): Function deleted.
877 (display_prop_intangible_p): Reimplement to call
878 handle_display_spec instead of single_display_spec_intangible_p.
879 Accept 3 additional arguments needed by handle_display_spec.
880 This fixes incorrect cursor motion across display property with complex
881 values: lists, `(when COND...)' forms, etc.
882 (single_display_spec_string_p): Support property values that are
883 lists with the argument STRING its top-level element.
884 (display_prop_string_p): Fix the condition for processing a
885 property that is a list to be consistent with handle_display_spec.
886 (handle_display_spec): New function, refactored from the
887 last portion of handle_display_prop.
888 (compute_display_string_pos): Accept additional argument
889 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
890 value of a `display' property is a "replacing spec".
891 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
892 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
893 the display property, but just return a value indicating whether
894 the display property will replace the characters it covers.
895 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
896 frame_window_p members of struct bidi_it.
897 (compute_display_string_pos, compute_display_string_end):
898 New functions.
899 (push_it): Accept second argument POSITION, where pop_it should
900 jump to continue iteration.
901 (reseat_1): Initialize bidi_it.disp_pos.
902
903 * keyboard.c (adjust_point_for_property): Adjust the call to
904 display_prop_intangible_p to its new signature.
905
906 * dispextern.h (struct bidi_it): New member frame_window_p.
907 (bidi_init_it): Update prototypes.
908 (display_prop_intangible_p): Update prototype.
909 (compute_display_string_pos, compute_display_string_end):
910 Declare prototypes.
911 (struct bidi_it): New members nchars and disp_pos. ch_len is now
912 EMACS_INT.
913
914 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
915
916 Malloc failure behavior now depends on size of allocation.
917 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
918 * lisp.h: Change signatures accordingly.
919 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
920 All callers changed. (Bug#8762)
921
922 * gnutls.c: Use Emacs's memory allocators.
923 Without this change, the gnutls library would invoke malloc etc.
924 directly, which causes problems on non-SYNC_INPUT hosts, and which
925 runs afoul of improving memory_full behavior. (Bug#8761)
926 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
927 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
928 xfree instead of the default malloc, realloc, free.
929 (Fgnutls_boot): No need to check for memory allocation failure,
930 since xmalloc does that for us.
931
932 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
933 * category.c (hash_get_category_set):
934 * ccl.c (ccl_driver):
935 * charset.c (Fdefine_charset_internal):
936 * charset.h (struct charset.hash_index):
937 * composite.c (get_composition_id, gstring_lookup_cache)
938 (composition_gstring_put_cache):
939 * composite.h (struct composition.hash_index):
940 * dispextern.h (struct image.hash):
941 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
942 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
943 (hashfn_equal, hashfn_user_defined, make_hash_table)
944 (maybe_resize_hash_table, hash_lookup, hash_put)
945 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
947 (Fsxhash, Fgethash, Fputhash, Fmaphash):
948 * image.c (make_image, search_image_cache, lookup_image)
949 (xpm_put_color_table_h):
950 * lisp.h (struct Lisp_Hash_Table):
951 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
952 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
953 for hashes and hash indexes, instead of 'unsigned' and 'int'.
954 * alloc.c (allocate_vectorlike):
955 Check for overflow in vector size calculations.
956 * ccl.c (ccl_driver):
957 Check for overflow when converting EMACS_INT to int.
958 * fns.c, image.c: Remove unnecessary static decls that would otherwise
959 need to be updated by these changes.
960 * fns.c (make_hash_table, maybe_resize_hash_table):
961 Check for integer overflow with large hash tables.
962 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
963 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
964 (SXHASH_REDUCE): New macro.
965 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
966 Use it instead of discarding useful hash info with large hash values.
967 (sxhash_float): New function.
968 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
969 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
970 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
971 Rewrite to use FIXNUM_BITS, as this simplifies things.
972 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
973 Adjust signatures to match updated version of code.
974 (consing_since_gc): Now EMACS_INT, since a single hash table can
975 use more than INT_MAX bytes.
976
977 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
978
979 Make it possible to build with GCC-4.6+ -O2 -flto.
980
981 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
982
983 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
984
985 * minibuf.c (get_minibuffer, read_minibuf_unwind):
986 Call minibuffer-inactive-mode.
987
988 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
989
990 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
991 Update dependencies.
992
993 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
994
995 * data.c (init_data): Remove code for UTS, this system is not
996 supported anymore.
997
998 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
999
1000 Don't force ./temacs to start in terminal mode.
1001
1002 * frame.c (make_initial_frame): Initialize faces in all cases, not
1003 only when CANNOT_DUMP is defined.
1004 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1005
1006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1007
1008 * dispnew.c (add_window_display_history): Use const for the string
1009 pointer. Remove declaration, not needed.
1010
1011 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 Use 'inline', not 'INLINE'.
1014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1015 * alloc.c, fontset.c (INLINE): Remove.
1016 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1017 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1018 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1019 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1020 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1021
1022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1023
1024 Make it possible to run ./temacs.
1025
1026 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1027 syms_of_callproc does the same thing. Remove test for
1028 "initialized", do it in the caller.
1029 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1030
1031 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1032
1033 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1034 (read_minibuf): Use get_minibuffer.
1035 (syms_of_minibuf): Use DEFSYM.
1036 (Qmetadata): New var.
1037 * data.c (Qbuffer): Don't make it static.
1038 (syms_of_data): Use DEFSYM.
1039
1040 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1043 (CCL_CODE_MIN): New macro.
1044
1045 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1048
1049 * eval.c (Qdebug): Now static.
1050 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1051 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1052 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1053
1054 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1055
1056 * image.c: Various fixes to ImageMagick code comments.
1057 (Fimagemagick_types): Doc fix.
1058
1059 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 Minor fixes prompted by GCC 4.6.0 warnings.
1062
1063 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1064
1065 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1066 (x_clipboard_manager_save_all): Move extern decl to ...
1067 * xterm.h: ... here, so that it can be checked for consistency.
1068
1069 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * xselect.c (x_clipboard_manager_save_frame)
1072 (x_clipboard_manager_save_all): New functions.
1073 (Fx_clipboard_manager_save): Lisp function deleted.
1074
1075 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1076 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1077
1078 * xterm.h: Update prototype.
1079
1080 2011-05-28 William Xu <william.xwl@gmail.com>
1081
1082 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1083 exiting (Bug#8239).
1084
1085 2011-05-28 Jim Meyering <meyering@redhat.com>
1086
1087 Avoid a sign-extension bug in crypto_hash_function.
1088 * fns.c (to_uchar): Define.
1089 (crypto_hash_function): Use it to convert some newly-signed
1090 variables to unsigned, to avoid sign-extension bugs. For example,
1091 without this change, (md5 "truc") would evaluate to
1092 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1093 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1094 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1095
1096 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1097
1098 Integer overflow fixes.
1099
1100 * dbusbind.c: Serial number integer overflow fixes.
1101 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1102 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1103 to hold a serial number that is too large for a fixnum.
1104 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1105 Check for serial numbers out of range. Decode any serial number
1106 that was so large that it became a float. (Bug#8722)
1107
1108 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1110 Use XFASTINT rather than XUINT when numbers are nonnegative.
1111 (xd_append_arg, Fdbus_method_return_internal):
1112 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1113 arguments, check that Lisp number is nonnegative, rather than
1114 silently wrapping negative numbers around. (Bug#8722)
1115 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1116 (Bug#8722)
1117
1118 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1119
1120 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1121
1122 ccl: add integer overflow checks
1123 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1124 (IN_INT_RANGE): New macros.
1125 (ccl_driver): Use them to check for integer overflow when
1126 decoding a CCL program. Many of the new checks are whether XINT (x)
1127 fits in int; it doesn't always, on 64-bit hosts. The new version
1128 doesn't catch all possible integer overflows, but it's an
1129 improvement. (Bug#8719)
1130
1131 * alloc.c (make_event_array): Use XINT, not XUINT.
1132 There's no need for unsigned here.
1133
1134 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1135 This follows up to the 2011-05-06 change that substituted uintptr_t
1136 for EMACS_INT. This case wasn't caught back then.
1137
1138 Rework Fformat to avoid integer overflow issues.
1139 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1140 now (part of C89). Include <verify.h>.
1141 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1142 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1143 (Fformat): Avoid the prepass trying to compute sizes; it was only
1144 approximate and thus did not catch overflow reliably. Instead, walk
1145 through the format just once, formatting and computing sizes as we go,
1146 checking for integer overflow at every step, and allocating a larger
1147 buffer as needed. Keep track separately whether the format is
1148 multibyte. Keep only the most-recently calculated precision, rather
1149 than them all. Record whether each argument has been converted to
1150 string. Use EMACS_INT, not int, for byte and char and arg counts.
1151 Support field widths and precisions larger than INT_MAX. Avoid
1152 sprintf's undefined behavior with conversion specifications such as %#d
1153 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1154 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1155 formatting out-of-range floating point numbers with int
1156 formats. (Bug#8668)
1157
1158 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1159
1160 * data.c: Avoid integer truncation in expressions involving floats.
1161 * data.c: Include <intprops.h>.
1162 (arith_driver): When there's an integer overflow in an expression
1163 involving floating point, convert the integers to floating point
1164 so that the resulting value does not suffer from catastrophic
1165 integer truncation. For example, on a 64-bit host (* 4
1166 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1167 Do not rely on undefined behavior after integer overflow.
1168
1169 merge count_size_as_multibyte, parse_str_to_multibyte
1170 * character.c, character.h (count_size_as_multibyte):
1171 Rename from parse_str_to_multibyte; all uses changed.
1172 Check for integer overflow.
1173 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1174 since it's now a duplicate of the other. This is more of
1175 a character than a buffer op, so better that it's in character.c.
1176 * fns.c, print.c: Adjust to above changes.
1177
1178 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1179
1180 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1181
1182 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1185 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1186 (x_clipboard_manager_save): Now static.
1187 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1188
1189 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1190 (crypto_hash_function): Now static.
1191 Fix pointer signedness problems. Avoid unnecessary initializations.
1192
1193 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1194
1195 * termhooks.h (Vselection_alist): Make it terminal-local.
1196
1197 * terminal.c (create_terminal): Initialize it.
1198
1199 * xselect.c: Support for clipboard managers.
1200 (Vselection_alist): Move to termhooks.h as terminal-local var.
1201 (LOCAL_SELECTION): New macro.
1202 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1203 (symbol_to_x_atom): Remove gratuitous arg.
1204 (x_handle_selection_request, lisp_data_to_selection_data)
1205 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1206 (x_own_selection, x_get_local_selection, x_convert_selection):
1207 New arg, specifying work frame. Use terminal-local Vselection_alist.
1208 (some_frame_on_display): Delete unused function.
1209 (Fx_own_selection_internal, Fx_get_selection_internal)
1210 (Fx_disown_selection_internal, Fx_selection_owner_p)
1211 (Fx_selection_exists_p): New optional frame arg.
1212 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1213 (x_handle_selection_clear): Don't treat other terminals with the
1214 same keyboard specially. Use the terminal-local Vselection_alist.
1215 (x_clear_frame_selections): Use Frun_hook_with_args.
1216
1217 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1218
1219 * xterm.h: Add support for those atoms.
1220
1221 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1222
1223 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1224 (converted_selections, conversion_fail_tag): New global variables.
1225 (x_selection_request_lisp_error): Free the above.
1226 (x_get_local_selection): Remove unnecessary code.
1227 (x_reply_selection_request): Args changed; handle arbitrary array
1228 of converted selections stored in converted_selections.
1229 Separate the XChangeProperty and SelectionNotify steps.
1230 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1231 (x_convert_selection): New function.
1232 (x_handle_selection_event): Simplify.
1233 (x_get_foreign_selection): Don't ignore incoming requests while
1234 waiting for an answer; this will fail when we implement
1235 SAVE_TARGETS, and seems unnecessary anyway.
1236 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1237 (Vx_sent_selection_functions): Doc fix.
1238
1239 2011-05-26 Leo Liu <sdl.web@gmail.com>
1240
1241 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1242
1243 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1244
1245 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1246
1247 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1248 for fringe update if it has periodic bitmap.
1249 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1250 and fringe_bitmap_periodic_p.
1251
1252 * fringe.c (get_fringe_bitmap_data): New function.
1253 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1254 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1255 row. Mark glyph row for fringe update if periodicity changed.
1256
1257 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1258 for fringe update unless it has periodic bitmap.
1259
1260 2011-05-25 Kenichi Handa <handa@m17n.org>
1261
1262 * xdisp.c (get_next_display_element): Set correct it->face_id for
1263 a static composition.
1264
1265 2011-05-24 Leo Liu <sdl.web@gmail.com>
1266
1267 * deps.mk (fns.o):
1268 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1269
1270 * fns.c (crypto_hash_function, Fsha1): New function.
1271 (Fmd5): Use crypto_hash_function.
1272 (syms_of_fns): Add Ssha1.
1273
1274 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 * gnutls.c: Remove unused macros.
1277 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1278 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1279 Remove macros that are defined and never used.
1280 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1281
1282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1285 (Fx_get_selection_internal): Minor cleanup.
1286 (Fx_own_selection_internal): Rename arguments for consistency with
1287 select.el.
1288
1289 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1292
1293 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1294
1295 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1296
1297 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1298
1299 * dispnew.c (scrolling_window): Don't exclude the case that the
1300 last enabled row in the desired matrix touches the bottom boundary.
1301
1302 2011-05-21 Glenn Morris <rgm@gnu.org>
1303
1304 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1305 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1306 and add some more files.
1307
1308 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1309
1310 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1311 report_file_error introduced by the change from 2011-05-07.
1312
1313 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * systime.h (Time): Define only if emacs is defined.
1316 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1317 where the include path doesn't have X11/X.h by default. See
1318 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1319
1320 2011-05-20 Kenichi Handa <handa@m17n.org>
1321
1322 * composite.c (find_automatic_composition): Fix previous change.
1323
1324 2011-05-20 Glenn Morris <rgm@gnu.org>
1325
1326 * lisp.mk: New file, split from Makefile.in.
1327 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1328 (shortlisp): Remove.
1329 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1330
1331 2011-05-19 Glenn Morris <rgm@gnu.org>
1332
1333 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1334 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1335 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1336 (lisp): Set the order to that of loadup.el.
1337 (shortlisp): Make it a copy of $lisp.
1338 (SOME_MACHINE_LISP): Remove.
1339 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1340 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1341
1342 2011-05-18 Kenichi Handa <handa@m17n.org>
1343
1344 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1345 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1346 (find_automatic_composition): Mostly rewrite for efficiency.
1347
1348 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * makefile.w32-in: Update dependencies.
1351
1352 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1353
1354 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1355 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1356
1357 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Fix some integer overflow issues, such as string length overflow.
1360
1361 * insdel.c (count_size_as_multibyte): Check for string overflow.
1362
1363 * character.c (lisp_string_width): Check for string overflow.
1364 Use EMACS_INT, not int, for string indexes and lengths; in
1365 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1366 the resulting string length overflows an EMACS_INT; instead,
1367 report a string overflow if no precision given. When checking for
1368 precision exhaustion, use a check that cannot possibly have
1369 integer overflow. (Bug#8675)
1370 * character.h (lisp_string_width): Adjust to new signature.
1371
1372 * alloc.c (string_overflow): New function.
1373 (Fmake_string): Use it. This doesn't change behavior, but saves
1374 a few bytes and will simplify future changes.
1375 * character.c (string_escape_byte8): Likewise.
1376 * lisp.h (string_overflow): New decl.
1377
1378 Fixups, following up to the user-interface timestamp change.
1379 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1380 for UI timestamps, instead of unsigned long.
1381 * msdos.c (mouse_get_pos): Likewise.
1382 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1383 * w32gui.h (Time): Define by including "systime.h" rather than by
1384 declaring it ourselves. (Bug#8664)
1385
1386 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1387 * image.c (clear_image_cache): Likewise.
1388
1389 * term.c (term_mouse_position): Don't assume time_t wraparound.
1390
1391 Be more systematic about user-interface timestamps.
1392 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1393 and sometimes 'EMACS_UINT', to represent these timestamps.
1394 This change causes it to use 'Time' uniformly, as that's what X uses.
1395 This makes the code easier to follow, and makes it easier to catch
1396 integer overflow bugs such as Bug#8664.
1397 * frame.c (Fmouse_position, Fmouse_pixel_position):
1398 Use Time, not unsigned long, for user-interface timestamps.
1399 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1400 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1401 * keyboard.h (last_event_timestamp): Likewise.
1402 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1403 * menu.h (xmenu_show): Likewise.
1404 * term.c (term_mouse_position): Likewise.
1405 * termhooks.h (struct input_event.timestamp): Likewise.
1406 (struct terminal.mouse_position_hook): Likewise.
1407 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1408 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1409 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1410 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1411 what it was before.
1412 * menu.h, termhooks.h: Include "systime.h", for Time.
1413
1414 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1415 Don't assume that the difference between two unsigned long values
1416 can fit into an integer. At this point, we know button_down_time
1417 <= event->timestamp, so the difference must be nonnegative, so
1418 there's no need to cast the result if double-click-time is
1419 nonnegative, as it should be; check that it's nonnegative, just in
1420 case. This bug is triggered when events are more than 2**31 ms
1421 apart (about 25 days). (Bug#8664)
1422
1423 * xselect.c (last_event_timestamp): Remove duplicate decl.
1424 (x_own_selection): Remove needless cast to unsigned long.
1425
1426 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1427 that always fit in int. Use a sentinel instead of a counter, to
1428 avoid a temp and to allay GCC's concerns about possible int overflow.
1429 * frame.h (struct frame): Use int for menu_bar_items_used
1430 instead of EMACS_INT, since it always fits in int.
1431
1432 * menu.c (grow_menu_items): Check for int overflow.
1433
1434 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1435
1436 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1437 Before, the code was not consistent. These values cannot exceed
1438 2**31 - 1 so there's no need to make them unsigned.
1439 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1440 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1441 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1442 as modifiers.
1443 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1444
1445 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1446 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1447 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1448 presumably because the widths might not match.
1449
1450 * window.c (size_window): Avoid needless test at loop start.
1451
1452 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1453
1454 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1455
1456 2011-05-12 Drew Adams <drew.adams@oracle.com>
1457
1458 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1459
1460 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1461
1462 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1463 `width' to `bar_area_x' and `bar_area_width', respectively.
1464 (x_scroll_run): Take account of fringe background extension.
1465
1466 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1467 Rename local vars `left' and `width' to `bar_area_x' and
1468 `bar_area_width', respectively.
1469 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1470 background extension.
1471
1472 2011-05-10 Jim Meyering <meyering@redhat.com>
1473
1474 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1475
1476 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1477
1478 * image.c (Finit_image_library): Return t for built-in image types,
1479 like pbm and xbm. (Bug#8640)
1480
1481 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1482
1483 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1484
1485 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1486
1487 * w32console.c (Fset_screen_color): Doc fix.
1488 (Fget_screen_color): New function.
1489 (syms_of_ntterm): Defsubr it.
1490
1491 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1492 unlink the temporary file if Fcall_process didn't create it in the
1493 first place.
1494 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1495 child process will be redirected to a file specified with `:file'.
1496 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1497 cue to call_process_cleanup not to close that handle.
1498
1499 2011-05-07 Ben Key <bkey76@gmail.com>
1500
1501 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1502 one of two shell specific rules, either bootstrap-temacs-CMD or
1503 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1504 to the previous implementation of the bootstrap-temacs rule.
1505 The bootstrap-temacs-CMD rule is similar to the previous
1506 implementation of the bootstrap-temacs rule except that it
1507 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1508 variable.
1509
1510 These changes, along with some changes to nt/configure.bat,
1511 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1512 earlier fix to add support for --cflags and --ldflags options
1513 that include quotes so that it works whether make uses cmd or
1514 sh as the shell.
1515
1516 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1517
1518 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1519 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1520 is a constant.
1521 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1522 a string. Handle both cases.
1523 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1524 (Fdbus_register_method): Use Qinvalid_function.
1525
1526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * makefile.w32-in: Update dependencies.
1529 (LISP_H): Add inttypes.h and stdin.h.
1530 (PROCESS_H): Add unistd.h.
1531
1532 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1533
1534 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1535 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1536
1537 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1540
1541 * term.c (vfatal): Remove stray call to va_end.
1542 It's not needed and the C Standard doesn't allow it here anyway.
1543
1544 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1545 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1546
1547 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1548 bytes.
1549
1550 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1551
1552 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1553
1554 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1555
1556 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1557
1558 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1559
1560 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1561 * charset.c (Fdefine_charset_internal): Don't initialize
1562 charset.code_space[15]. The value was garbage, on hosts with
1563 32-bit int (Bug#8600).
1564
1565 * lread.c (read_integer): Be more consistent with string-to-number.
1566 Use string_to_number to do the actual conversion; this avoids
1567 rounding errors and fixes some other screwups. Without this fix,
1568 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1569 (digit_to_number): Move earlier, for benefit of read_integer.
1570 Return -1 if the digit is out of range for the base, -2 if it is
1571 not a digit in any supported base. (Bug#8602)
1572
1573 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1574
1575 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1576 to match comment at start of function. This also removes a
1577 GCC warning about overflow in a 32+64-bit port.
1578
1579 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1580
1581 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1582 Reported by Stefan Monnier in
1583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1584 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1585 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1586
1587 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1588 (EMACS_UINTPTR): Likewise, with uintptr_t.
1589
1590 * lisp.h: Prefer 64-bit EMACS_INT if available.
1591 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1592 on 32-bit hosts that have 64-bit int, so that they can access
1593 large files.
1594 However, temporarily disable this change unless the temporary
1595 symbol WIDE_EMACS_INT is defined.
1596
1597 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1598
1599 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1600 This removes an assumption that EMACS_INT and long are the same
1601 width as pointers. The assumption is true for Emacs porting targets
1602 now, but we want to make other targets possible.
1603 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1604 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1605 In the rest of the code, change types of integers that hold casted
1606 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1607 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1608 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1609 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1610 No need to cast type when ORing.
1611 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1612 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1613 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1614 assume EMACS_INT is the same width as char *.
1615 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1616 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1617 Remove no-longer-needed casts.
1618 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1619 (xg_tool_bar_help_callback, xg_make_tool_item):
1620 Use EMACS_INTPTR to hold an integer
1621 that will be cast to void *; this can avoid a GCC warning
1622 if EMACS_INT is not the same width as void *.
1623 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1624 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1625 (current_message_1, set_message_1):
1626 Use a local to convert to proper width without a cast.
1627 * xmenu.c (dialog_selection_callback): Likewise.
1628
1629 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1630 Also, don't assume VALBITS / RAND_BITS is less than 5,
1631 and don't rely on undefined behavior when shifting a 1 left into
1632 the sign bit.
1633 * lisp.h (get_random): Change signature to match.
1634
1635 * lread.c (hash_string): Use size_t, not int, for hash computation.
1636 Normally we prefer signed values; but hashing is special, because
1637 it's better to use unsigned division on hash table sizes so that
1638 the remainder is nonnegative. Also, size_t is the natural width
1639 for hashing into memory. The previous code used 'int', which doesn't
1640 retain enough info to hash well into very large tables.
1641 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1642
1643 * dbusbind.c: Don't possibly lose pointer info when converting.
1644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1645 Use XPNTR rather than XHASH, so that the high-order bits of
1646 the pointer aren't lost when converting through void *.
1647
1648 * eval.c (Fautoload): Don't double-shift a pointer.
1649
1650 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1651
1652 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1653
1654 * gnutls.c (DEF_GNUTLS_FN):
1655 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1656
1657 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1658
1659 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1660 marker. (Bug#8610)
1661
1662 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1663
1664 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1665 New version that can reserve upto 2GB of heap space.
1666
1667 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1670
1671 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1672
1673 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1674 `gnutls_certificate_set_x509_key_file'.
1675
1676 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1679 Update dependencies.
1680
1681 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1684 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1685 Remove unused parameter `fildes'.
1686 * process.c (read_process_output, send_process): Don't pass it.
1687
1688 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1689
1690 Fix previous change: the library cache is defined in w32.c.
1691 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1692 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1693
1694 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1695
1696 Implement dynamic loading of GnuTLS on Windows.
1697
1698 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1699 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1700 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1701 Declare.
1702
1703 * gnutls.c (Qgnutls_dll): Define.
1704 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1705 (gnutls_*): Declare function pointers.
1706 (init_gnutls_functions): New function to initialize function pointers.
1707 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1708 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1710 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1711 (emacs_gnutls_write, emacs_gnutls_read)
1712 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1713 (Fgnutls_available_p): New function.
1714 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1715 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1716 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1717
1718 * image.c: Include w32.h.
1719 (Vimage_type_cache): Delete.
1720 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1721 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1722 (w32_delayed_load): Move to w32.c.
1723
1724 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1725
1726 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1727 (w32_delayed_load): Move from image.c. When loading a library, record
1728 its filename in the :loaded-from property of the library id.
1729 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1730 Initialize and staticpro them.
1731 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1732
1733 * process.c: Include lisp.h before w32.h, not after.
1734 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1735 instead of gnutls_record_check_pending.
1736
1737 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1738
1739 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1740
1741 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1742 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1743 as passed in.
1744
1745 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1746
1747 * xterm.c (x_set_frame_alpha): Do not set property on anything
1748 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1749
1750 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1751
1752 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1753
1754 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1757 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1758 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1759 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1760 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1761 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1762 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1763 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1764 (Qgnutls_bootprop_callbacks_verify): Make static.
1765
1766 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1767
1768 * callproc.c: Indentation fixup.
1769
1770 * sysdep.c (wait_for_termination_1): Make static.
1771 (wait_for_termination, interruptible_wait_for_termination):
1772 Move after wait_for_termination_1.
1773
1774 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1775
1776 * sysdep.c (interruptible_wait_for_termination): New function
1777 which is like wait_for_termination, but allows keyboard
1778 interruptions.
1779
1780 * callproc.c (Fcall_process): Add (:file "file") as an option for
1781 the STDOUT buffer.
1782 (Fcall_process_region): Ditto.
1783
1784 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1785
1786 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1787 rather than `XVECTOR (FOO)->size'.
1788
1789 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1790 inttypes.h, as a gnulib replacement is used if it not available in
1791 system headers.
1792
1793 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1794
1795 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1796 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1797 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1798
1799 * coding.c (coding_alloc_by_realloc): Error out if destination
1800 will grow beyond MOST_POSITIVE_FIXNUM.
1801 (decode_coding_emacs_mule): Abort if there isn't enough place in
1802 charbuf for the composition carryover bytes. Reserve an extra
1803 space for up to 2 characters produced in a loop.
1804 (decode_coding_iso_2022): Abort if there isn't enough place in
1805 charbuf for the composition carryover bytes.
1806
1807 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1808
1809 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1810 aborting when %lld or %lll format is passed.
1811 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1812 %llo or %llx format is passed. (Bug#8545)
1813
1814 * window.c (window_scroll_line_based): Use a marker instead of
1815 simple variables to record original value of point. (Bug#7952)
1816
1817 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1818 produced by %s or %c overflows available buffer space. (Bug#8545)
1819
1820 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1821
1822 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1823 (SIZE_MAX): Move defn after all includes, as they might #define it.
1824
1825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1828
1829 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * keyboard.c (Qdelayed_warnings_hook): Define.
1832 (command_loop_1): Run `delayed-warnings-hook'
1833 if Vdelayed_warnings_list is non-nil.
1834 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1835 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1836
1837 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1838
1839 * doprnt.c (doprnt): Don't return value smaller than the buffer
1840 size if the message was truncated. (Bug#8545).
1841
1842 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1845 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1846
1847 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1850
1851 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * makefile.w32-in: Update dependencies.
1854
1855 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1856
1857 Improve `doprnt' and its usage. (Bug#8545)
1858 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1859 `format_end'. Remove support for %l as a conversion specifier.
1860 Don't use xrealloc. Improve diagnostics when the %l size modifier
1861 is used. Update the commentary.
1862
1863 * eval.c (verror): Simplify calculation of size_t.
1864
1865 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1866 messages.
1867
1868 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1869
1870 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1871 change.
1872
1873 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1876 This makes this file independent of the recent pseudovector change.
1877
1878 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1881
1882 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1883 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1884 Remove unused local.
1885 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1886
1887 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1888 GCC 4.6.0 optimizes based on type-based alias analysis.
1889 For example, if b is of type struct buffer * and v of type struct
1890 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1891 != &v->size, and therefore "v->size = 1; b->size = 2; return
1892 v->size;" must therefore return 1. This assumption is incorrect
1893 for Emacs, since it type-puns struct Lisp_Vector * with many other
1894 types. To fix this problem, this patch adds a new type struct
1895 vectorlike_header that documents the constraints on layout of vectors
1896 and pseudovectors, and helps optimizing compilers not get fooled
1897 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1898 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1899 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1900 the size member.
1901 (XSETPVECTYPE): Rewrite in terms of new macro.
1902 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1903 This is a bit clearer, and further avoids the possibility of
1904 undesirable aliasing.
1905 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1906 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1907 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1908 since Lisp_Subr is a special case (no "next" field).
1909 (ASIZE): Now uses header.size rather than size.
1910 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1911 to avoid the hassle of writing XVECTOR (foo)->header.size.
1912 (struct vectorlike_header): New type.
1913 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1914 object, to help avoid aliasing.
1915 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1916 (SUBRP): Likewise, since Lisp_Subr is a special case.
1917 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1918 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1919 (struct Lisp_Hash_Table): Combine first two members into a single
1920 struct vectorlike_header member. All uses of "size" and "next" members
1921 changed to be "header.size" and "header.next".
1922 * buffer.h (struct buffer): Likewise.
1923 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1924 * frame.h (struct frame): Likewise.
1925 * process.h (struct Lisp_Process): Likewise.
1926 * termhooks.h (struct terminal): Likewise.
1927 * window.c (struct save_window_data, struct saved_window): Likewise.
1928 * window.h (struct window): Likewise.
1929 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1930 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1931 * buffer.c (init_buffer_once): Likewise.
1932 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1933 special case.
1934 * process.c (Fformat_network_address): Use local var for size,
1935 for brevity.
1936
1937 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1938
1939 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1940 * data.c (atof): Remove decl; no longer used or needed.
1941 (digit_to_number): Move to lread.c.
1942 (Fstring_to_number): Use new string_to_number function, to be
1943 consistent with how the Lisp reader treats infinities and NaNs.
1944 Do not assume that floating-point numbers represent EMACS_INT
1945 without losing information; this is not true on most 64-bit hosts.
1946 Avoid double-rounding errors, by insisting on integers when
1947 parsing non-base-10 numbers, as the documentation specifies.
1948 * lisp.h (string_to_number): New decl, replacing ...
1949 (isfloat_string): Remove.
1950 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1951 (read1): Do not accept +. and -. as integers; this
1952 appears to have been a coding error. Similarly, do not accept
1953 strings like +-1e0 as floating point numbers. Do not report
1954 overflow for integer overflows unless the base is not 10 which
1955 means we have no simple and reliable way to continue.
1956 Break out the floating-point parsing into a new
1957 function string_to_number, so that Fstring_to_number parses
1958 floating point numbers consistently with the Lisp reader.
1959 (digit_to_number): Move here from data.c. Make it static inline.
1960 (E_CHAR, EXP_INT): Remove, replacing with ...
1961 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1962 (string_to_number): New function, replacing isfloat_string.
1963 This function checks for valid syntax and produces the resulting
1964 Lisp float number too. Rework it so that string-to-number
1965 no longer mishandles examples like "1.0e+". Use strtoumax,
1966 so that overflow for non-base-10 numbers is reported only when
1967 there's no portable and simple way to convert to floating point.
1968
1969 * textprop.c (set_text_properties_1): Rewrite for clarity,
1970 and to avoid GCC warning about integer overflow.
1971
1972 * intervals.h (struct interval): Use EMACS_INT for members
1973 where EMACS_UINT might cause problems. See
1974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1975 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1976 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1977 All uses changed.
1978 (offset_intervals): Tell GCC not to worry about length overflow
1979 when negating a negative length.
1980
1981 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1982 (overrun_check_free): Likewise.
1983
1984 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1985 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1986 word size.
1987
1988 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1989 (gnutls_make_error): Rename local to avoid shadowing.
1990 (gnutls_emacs_global_deinit): ifdef out; not used.
1991 (Fgnutls_boot): Use const for pointer to readonly storage.
1992 Comment out unused local. Fix pointer signedness problems.
1993
1994 * lread.c (openp): Don't stuff size_t into an 'int'.
1995 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1996 about possible signed overflow.
1997
1998 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1999 (GDK_KEY_g): Don't define if already defined.
2000 (xg_prepare_tooltip): Avoid pointer signedness problem.
2001 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2002
2003 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2004 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2005
2006 * xfns.c (Fx_window_property): Simplify a bit,
2007 to make a bit faster and to avoid GCC 4.6.0 warning.
2008 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2009
2010 * fns.c (internal_equal): Don't assume size_t fits in int.
2011
2012 * alloc.c (compact_small_strings): Tighten assertion a little.
2013
2014 Replace pEd with more-general pI, and fix some printf arg casts.
2015 * lisp.h (pI): New macro, generalizing old pEd macro to other
2016 conversion specifiers. For example, use "...%"pI"d..." rather
2017 than "...%"pEd"...".
2018 (pEd): Remove. All uses replaced with similar uses of pI.
2019 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2020 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2021 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2022 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2023 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2024 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2025 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2026 64-bit hosts.
2027 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2028 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2029 * print.c (safe_debug_print, print_object): Likewise.
2030 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2031 to int.
2032 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2033 avoiding the 0 flag, which is not portable.
2034 * process.c (Fmake_network_process): Use pI to avoid cast.
2035 * region-cache.c (pp_cache): Likewise.
2036 * xdisp.c (decode_mode_spec): Likewise.
2037 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2038 behavior on 64-bit hosts with printf arg.
2039 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2040 (x_stop_queuing_selection_requests): Likewise.
2041 (x_get_window_property): Don't truncate byte count to an 'int'
2042 when tracing.
2043
2044 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2045 here, since it parses constructs like leading '-' and spaces,
2046 which are not wanted; and it overflows with large numbers.
2047 Instead, simply match F[0-9]+, which is what is wanted anyway.
2048
2049 * alloc.c: Remove unportable assumptions about struct layout.
2050 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2051 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2052 (allocate_vectorlike, make_pure_vector): Use the new macros,
2053 plus offsetof, to remove unportable assumptions about struct layout.
2054 These assumptions hold on all porting targets that I know of, but
2055 they are not guaranteed, they're easy to remove, and removing them
2056 makes further changes easier.
2057
2058 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2059 This doesn't fix a bug but makes the code clearer.
2060 (string_overrun_cookie): Now const. Use initializers that
2061 don't formally overflow signed char, to avoid warnings.
2062 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2063 can cause Emacs to crash when string overrun checking is enabled.
2064 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2065 multiple of sizeof (EMACS_INT); it need not be, if
2066 alignof(EMACS_INT) < sizeof (EMACS_INT).
2067 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2068
2069 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2070
2071 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2072
2073 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2074
2075 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2076 supposed to be handshaking. (Bug#8556)
2077 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2078
2079 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2080
2081 * lisp.h (Qdebug): List symbol.
2082 * eval.c (Qdebug): Restore global linkage.
2083 * keyboard.c (debug-on-event): New variable.
2084 (handle_user_signal): Break into debugger when debug-on-event
2085 matches the current signal symbol.
2086
2087 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2088
2089 * alloc.c (check_sblock, check_string_bytes)
2090 (check_string_free_list): Convert to standard C.
2091
2092 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2093
2094 * w32.c (emacs_gnutls_push): Fix typo.
2095
2096 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2097
2098 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2099 "cast to pointer from integer of different size".
2100
2101 Improve doprnt and its use in verror. (Bug#8545)
2102 * doprnt.c (doprnt): Document the set of format control sequences
2103 supported by the function. Use SAFE_ALLOCA instead of always
2104 using `alloca'.
2105
2106 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2107 is one byte too soon. Don't use xrealloc; instead xfree and
2108 xmalloc anew.
2109
2110 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2111
2112 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2113 callbacks stage.
2114
2115 * gnutls.c: Renamed global_initialized to
2116 gnutls_global_initialized. Added internals for the
2117 :verify-hostname-error, :verify-error, and :verify-flags
2118 parameters of `gnutls-boot' and documented those parameters in the
2119 docstring. Start callback support.
2120 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2121 unless a fatal error occured. Call gnutls_alert_send_appropriate
2122 on error. Return error code.
2123 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2124 (emacs_gnutls_read): Likewise.
2125 (Fgnutls_boot): Return handshake error code.
2126 (emacs_gnutls_handle_error): New function.
2127 (wsaerror_to_errno): Likewise.
2128
2129 * w32.h (emacs_gnutls_pull): Add prototype.
2130 (emacs_gnutls_push): Likewise.
2131
2132 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2133 (emacs_gnutls_push): Likewise.
2134
2135 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2136
2137 * process.c (wait_reading_process_output): Check if GnuTLS
2138 buffered some data internally if no FDs are set for TLS
2139 connections.
2140
2141 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2142 (LIBS): Link to USER_LIBS.
2143 ($(BLD)/gnutls.$(0)): New target.
2144
2145 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2146
2147 * xdisp.c (handle_single_display_spec): Rename the
2148 display_replaced_before_p argument into display_replaced_p, to
2149 make it consistent with the commentary. Fix typos in the
2150 commentary.
2151
2152 * textprop.c (syms_of_textprop): Remove dead code.
2153 (copy_text_properties): Delete obsolete commentary about an
2154 interface that was deleted long ago. Fix typos in the description
2155 of arguments.
2156
2157 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2158 to changes in oldXMenu/XMenu.h from 2011-04-16.
2159 <menu_help_message, prev_menu_help_message>: Constify.
2160 (IT_menu_make_room): menu->help_text is now `const char **';
2161 adjust.
2162
2163 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2164 to changes in oldXMenu/XMenu.h from 2011-04-16.
2165 (struct XMenu): Declare `help_text' `const char **'.
2166
2167 * xfaces.c <Qunspecified>: Make extern again.
2168
2169 * syntax.c: Include sys/types.h before including regex.h, as
2170 required by Posix.
2171
2172 * doc.c (get_doc_string): Improve the format passed to `error'.
2173
2174 * doprnt.c (doprnt): Improve commentary.
2175
2176 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2177
2178 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2179 them with etags.
2180
2181 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2182 changes in globals.h immediately force recompilation.
2183 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2184 $(CURDIR)/s/ms-w32.h.
2185 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2186
2187 * character.c (Fchar_direction): Function deleted.
2188 (syms_of_character): Don't defsubr it.
2189 <char-direction-table>: Deleted.
2190
2191 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2192
2193 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2194 * doprnt.c: Include limits.h.
2195 (SIZE_MAX): New macro.
2196 (doprnt): Return a size_t value. 2nd arg is now size_t.
2197 Many local variables are now size_t instead of int or unsigned.
2198 Improve overflow protection. Support `l' modifier for integer
2199 conversions. Support %l conversion. Don't assume an EMACS_INT
2200 argument for integer conversions and for %c.
2201
2202 * lisp.h (doprnt): Restore prototype.
2203
2204 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2205 $(SRC)/character.h.
2206
2207 * Makefile.in (base_obj): Add back doprnt.o.
2208
2209 * deps.mk (doprnt.o): Add back prerequisites.
2210 (callint.o): Depend on character.h.
2211
2212 * eval.c (internal_lisp_condition_case): Include the handler
2213 representation in the error message.
2214 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2215 when breaking from the loop.
2216
2217 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2218
2219 * callint.c (Fcall_interactively): When displaying error message
2220 about invalid control letter, pass the character's codepoint, not
2221 a pointer to its multibyte form. Improve display of the character
2222 in octal and display also its hex code.
2223
2224 * character.c (char_string): Use %x to display the (unsigned)
2225 codepoint of an invalid character, to avoid displaying a bogus
2226 negative value.
2227
2228 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2229 `error', not SYMBOL_NAME itself.
2230
2231 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2232 character arguments to `error'.
2233
2234 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2235 to `error' in error message about FINAL_CHAR argument. Make sure
2236 FINAL_CHAR is a character, and use %c when it is passed as
2237 argument to `error'.
2238
2239 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2240
2241 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2242
2243 * w32.c: Include <time.h>.
2244 (sys_localtime): New function.
2245
2246 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2247
2248 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2249
2250 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2251
2252 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2253
2254 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2255 zombies (Bug#8467).
2256
2257 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2258
2259 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2260 gl_state.e_property when gl_state.object is Qt.
2261
2262 * insdel.c (make_gap_larger): Remove limitation of buffer size
2263 to <= INT_MAX.
2264
2265 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2266
2267 * xdisp.c (lookup_glyphless_char_display)
2268 (produce_glyphless_glyph): Handle cons cell entry in
2269 glyphless-char-display.
2270 (Vglyphless_char_display): Document it.
2271
2272 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2273 glyphless-char-display.
2274
2275 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2276
2277 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2278
2279 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2280
2281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2282 definition for no-X builds.
2283
2284 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2285
2286 Static checks with GCC 4.6.0 and non-default toolkits.
2287
2288 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2289
2290 * process.c (keyboard_bit_set): Define only if SIGIO.
2291 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2292 (send_process): Repair possible setjmp clobbering.
2293
2294 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2295
2296 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2297
2298 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2299
2300 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2301 Define only if needed.
2302
2303 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2304 by pacifying GCC about it. Maybe it's time to retire it?
2305 * xfaces.c (USG, __TIMEVAL__): Likewise.
2306
2307 * dispextern.h (struct redisplay_interface): Rename param
2308 to avoid shadowing.
2309 * termhooks.h (struct terminal): Likewise.
2310 * xterm.c (xembed_send_message): Likewise.
2311
2312 * insdel.c (make_gap_smaller): Define only if
2313 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2314
2315 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2316 it.
2317
2318 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2319 so that we aren't warned about unused symbols.
2320
2321 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2322
2323 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2324
2325 * xfns.c (x_real_positions): Mark locals as initialized.
2326
2327 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2328
2329 * xterm.c: Fix problems found by static analysis with other toolkits.
2330 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2331 (x_dispatch_event): Declare static if USE_GTK, and
2332 define if USE_GTK || USE_X_TOOLKIT.
2333 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2334 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2335 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2336 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2337
2338 * xmenu.c (menu_help_callback): Pointer type fixes.
2339 Use const pointers when pointing at readonly data. Avoid pointer
2340 signedness clashes.
2341 (FALSE): Remove unused macro.
2342 (update_frame_menubar): Remove unused decl.
2343
2344 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2345
2346 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2347 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2348 (single_menu_item): Rename local to avoid shadowing.
2349
2350 * keyboard.c (make_lispy_event): Remove unused local var.
2351
2352 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2353 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2354
2355 * bitmaps: Change bitmaps from unsigned char back to the X11
2356 compatible char. Avoid the old compiler warnings about
2357 out-of-range initializers by using, for example, '\xab' rather
2358 than 0xab.
2359
2360 * xgselect.c (xgselect_initialize): Check vs interface
2361 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2362
2363 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2364
2365 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2366 to read-only memory.
2367
2368 * fns.c (vector): Remove; this old hack is no longer needed.
2369
2370 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2371 Remove unused var.
2372 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2373
2374 * xrdb.c (x_load_resources): Omit unused local.
2375
2376 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2377 (x_window): Rename locals to avoid shadowing.
2378 (USG): Use the kludged USG macro, to pacify gcc.
2379
2380 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2381 (x_term_init): Remove local to avoid shadowing.
2382
2383 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2384
2385 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2386 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2387
2388 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2389
2390 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2391
2392 Fix regex.c, syntax.c and friends for buffers > 2GB.
2393 * syntax.h (struct gl_state_s): Declare character position members
2394 EMACS_INT.
2395
2396 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2397
2398 * textprop.c (verify_interval_modification, interval_of):
2399 Declare arguments EMACS_INT.
2400
2401 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2402 EMACS_INT.
2403
2404 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2405
2406 * indent.c (Fvertical_motion): Local variable it_start is now
2407 EMACS_INT.
2408
2409 * regex.c (re_match, re_match_2, re_match_2_internal)
2410 (bcmp_translate, regcomp, regexec, print_double_string)
2411 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2412 (re_compile_pattern, re_exec): Declare arguments and local
2413 variables `size_t' and `ssize_t' and return values `regoff_t', as
2414 appropriate.
2415 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2416 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2417 <compile_stack_type>: `size' and `avail' are now `size_t'.
2418
2419 * regex.h <regoff_t>: Use ssize_t, not int.
2420 (re_search, re_search_2, re_match, re_match_2): Arguments that
2421 specify buffer/string position and length are now ssize_t and
2422 size_t. Return type is regoff_t.
2423
2424 2011-04-16 Ben Key <bkey76@gmail.com>
2425
2426 * nsfont.m: Fixed bugs in ns_get_family and
2427 ns_descriptor_to_entity that were caused by using free to
2428 deallocate memory blocks that were allocated by xmalloc (via
2429 xstrdup). This caused Emacs to crash when compiled with
2430 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2431 --enable-checking=xmallocoverrun). xfree is now used to
2432 deallocate these memory blocks.
2433
2434 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2437
2438 emacs_write: Accept and return EMACS_INT for sizes.
2439 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2440 et seq.
2441 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2442 Accept and return EMACS_INT.
2443 (emacs_gnutls_write): Return the number of bytes written on
2444 partial writes.
2445 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2446 (emacs_read, emacs_write): Remove check for negative size, as the
2447 Emacs source code has been audited now.
2448 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2449 (emacs_read, emacs_write): Use it.
2450 * process.c (send_process): Adjust to the new signatures of
2451 emacs_write and emacs_gnutls_write. Do not attempt to store
2452 a byte offset into an 'int'; it might overflow.
2453 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2454
2455 * sound.c: Don't assume sizes fit in 'int'.
2456 (struct sound_device.period_size, alsa_period_size):
2457 Return EMACS_INT, not int.
2458 (struct sound_device.write, vox_write, alsa_write):
2459 Accept EMACS_INT, not int.
2460 (wav_play, au_play): Use EMACS_INT to store sizes and to
2461 record read return values.
2462
2463 2011-04-15 Ben Key <bkey76@gmail.com>
2464
2465 * keyboard.c (Qundefined): Don't declare static since it is used
2466 in nsfns.m.
2467 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2468 static since they are used in nsfont.m.
2469
2470 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2471
2472 * process.c (Qprocessp): Don't declare static.
2473 * lisp.h (Qprocessp): Declare again.
2474
2475 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2478
2479 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 Improve C-level modularity by making more things 'static'.
2482
2483 Don't publish debugger-only interfaces to other modules.
2484 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2485 (verify_bytepos, count_markers): Move decls to the only modules
2486 that need them.
2487 * region-cache.h (pp_cache): Likewise.
2488 * window.h (check_all_windows): Likewise.
2489 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2490
2491 * sysdep.c (croak): Now static, if
2492 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2493 * syssignal.h (croak): Declare only if not static.
2494
2495 * alloc.c (refill_memory_reserve): Now static if
2496 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2497 * lisp.h (refill_memory_reserve): Declare only if not static.
2498
2499 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2500 Define only if USE_LUCID.
2501
2502 * xrdb.c (x_customization_string, x_rm_string): Now static.
2503
2504 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2505 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2506
2507 * xdisp.c (draw_row_with_mouse_face): Now static.
2508 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2509
2510 * window.h (check_all_windows): Mark externally visible.
2511
2512 * window.c (window_deletion_count): Now static.
2513
2514 * undo.c: Make symbols static if they're not exported.
2515 (last_undo_buffer, last_boundary_position, pending_boundary):
2516 Now static.
2517
2518 * textprop.c (interval_insert_behind_hooks): Now static.
2519 (interval_insert_in_front_hooks): Likewise.
2520
2521 * term.c: Make symbols static if they're not exported.
2522 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2523 (max_frame_lines, tty_set_terminal_modes):
2524 (tty_reset_terminal_modes, tty_turn_off_highlight):
2525 (get_tty_terminal): Now static.
2526 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2527 * termhooks.h (term_mouse_moveto): Do not declare if
2528 HAVE_WINDOW_SYSTEM.
2529 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2530 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2531
2532 * sysdep.c: Make symbols static if they're not exported.
2533 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2534 Now static.
2535 (sigprocmask_set, full_mask): Remove; unused.
2536 (wait_debugging): Mark as visible.
2537 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2538 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2539
2540 * syntax.c (syntax_temp): Define only if !__GNUC__.
2541
2542 * sound.c (current_sound_device, current_sound): Now static.
2543
2544 * search.c (searchbufs, searchbuf_head): Now static.
2545
2546 * scroll.c (scroll_cost): Remove; unused.
2547 * dispextern.h (scroll_cost): Remove decl.
2548
2549 * region-cache.h (pp_cache): Mark as externally visible.
2550
2551 * process.c: Make symbols static if they're not exported.
2552 (process_tick, update_tick, create_process, chan_process):
2553 (Vprocess_alist, proc_buffered_char, datagram_access):
2554 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2555 (deactivate_process): Mark defn as static, as well as decl.
2556 * lisp.h (create_process): Remove decl.
2557 * process.h (chan_process, Vprocess_alist): Remove decls.
2558
2559 * print.c: Make symbols static if they're not exported.
2560 (print_depth, new_backquote_output, being_printed, print_buffer):
2561 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2562 (print_interval, print_number_index, initial_stderr_stream):
2563 Now static.
2564 * lisp.h (Fprinc): Remove decl.
2565 (debug_output_compilation_hack): Mark as externally visible.
2566
2567 * sysdep.c (croak): Move decl from here to syssignal.h.
2568 * syssignal.h (croak): Put it here, so the API can be checked when
2569 'croak' is called from dissociate_if_controlling_tty.
2570
2571 * minibuf.c: Make symbols static if they're not exported.
2572 (minibuf_save_list, choose_minibuf_frame): Now static.
2573 * lisp.h (choose_minibuf_frame): Remove decl.
2574
2575 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2576
2577 * lread.c: Make symbols static if they're not exported.
2578 (read_objects, initial_obarray, oblookup_last_bucket_number):
2579 Now static.
2580 (make_symbol): Remove; unused.
2581 * lisp.h (initial_obarray, make_symbol): Remove decls.
2582
2583 * keyboard.c: Make symbols static if they're not exported.
2584 (single_kboard, recent_keys_index, total_keys, recent_keys):
2585 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2586 (this_single_command_key_start, echoing, last_auto_save):
2587 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2588 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2589 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2590 (Vlispy_mouse_stem, double_click_count):
2591 Now static.
2592 (force_auto_save_soon): Define only if SIGDANGER.
2593 (ignore_mouse_drag_p): Now static if
2594 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2595 (print_help): Remove; unused.
2596 (stop_character, last_timer_event): Mark as externally visible.
2597 * keyboard.h (ignore_mouse_drag_p): Declare only if
2598 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2599 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2600 * lisp.h (echoing): Remove decl.
2601 (force_auto_save_soon): Declare only if SIGDANGER.
2602 * xdisp.c (redisplay_window): Simplify code, to make it more
2603 obvious that ignore_mouse_drag_p is not accessed if !defined
2604 USE_GTK && !defined HAVE_NS.
2605
2606 * intervals.c: Make symbols static if they're not exported.
2607 (merge_properties_sticky, merge_interval_right, delete_interval):
2608 Now static.
2609 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2610
2611 * insdel.c: Make symbols static if they're not exported.
2612 However, leave prepare_to_modify_buffer alone. It's never
2613 called from outside this function, but that appears to be a bug.
2614 (combine_after_change_list, combine_after_change_buffer):
2615 (adjust_after_replace, signal_before_change): Now static.
2616 (adjust_after_replace_noundo): Remove; unused.
2617 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2618 (signal_before_change): Remove decls.
2619
2620 * indent.c (val_compute_motion, val_vmotion): Now static.
2621
2622 * image.c: Make symbols static if they're not exported.
2623 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2624 if USE_GTK.
2625 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2626 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2627
2628 * fringe.c (standard_bitmaps): Now static.
2629 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2630
2631 * frame.c: Make symbols static if they're not exported.
2632 (x_report_frame_params, make_terminal_frame): Now static.
2633 (get_frame_param): Now static, unless HAVE_NS.
2634 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2635 (x_get_resource_string): Remove; not used.
2636 * frame.h (make_terminal_frame, x_report_frame_params):
2637 (x_get_resource_string); Remove decls.
2638 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2639 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2640
2641 * font.c, fontset.c: Make symbols static if they're not exported.
2642 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2643 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2644 * font.c (font_close_object): Now static.
2645 * font.h (font_close_object): Remove.
2646 * fontset.c (FONTSET_OBJLIST): Remove.
2647 (free_realized_fontset) #if-0 the body, which does nothing.
2648 (face_suitable_for_char_p): #if-0, as it's never called.
2649 * fontset.h (face_suitable_for_char_p): Remove decl.
2650 * xfaces.c (face_at_string_position):
2651 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2652 since 0 is always ASCII.
2653
2654 * fns.c (weak_hash_tables): Now static.
2655
2656 * fileio.c: Make symbols static if they're not exported.
2657 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2658 (Vwrite_region_annotation_buffers): Now static.
2659
2660 * eval.c: Make symbols static if they're not exported.
2661 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2662 * lisp.h (backtrace_list): Remove decl.
2663
2664 * emacs.c: Make symbols static if they're not exported.
2665 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2666 (fatal_error_code, fatal_error_signal_hook, standard_args):
2667 Now static.
2668 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2669 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2670 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2671 * lisp.h (fatal_error_signal_hook): Remove decl.
2672 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2673
2674 * editfns.c: Move a (normally-unused) function to its only use.
2675 * editfns.c, lisp.h (get_operating_system_release): Remove.
2676 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2677 worth the hassle of breaking this out.
2678
2679 * xterm.c: Make symbols static if they're not exported.
2680 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2681 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2682 (x_destroy_window, x_delete_display):
2683 Now static.
2684 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2685 (x_mouse_leave): Remove; unused.
2686 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2687 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2688 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2689 Remove decls.
2690 (x_mouse_leave): Declare only if WINDOWSNT.
2691 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2692 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2693 USE_X_TOOLKIT.
2694
2695 * ftxfont.c: Make symbols static if they're not exported.
2696 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2697 HAVE_FREETYPE.
2698 * font.h (ftxfont_driver): Likewise.
2699
2700 * xfns.c: Make symbols static if they're not exported.
2701 (x_last_font_name, x_display_info_for_name):
2702 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2703 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2704 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2705 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2706 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2707 (last_show_tip_args): Now static.
2708 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2709 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2710 (x_screen_planes): Remove; unused.
2711 * dispextern.h (x_screen_planes): Remove decl.
2712
2713 * dispnew.c: Make symbols static if they're not exported.
2714 * dispextern.h (redraw_garbaged_frames, scrolling):
2715 (increment_row_positions): Remove.
2716 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2717 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2718 Now static.
2719 (redraw_garbaged_frames): Remove; unused.
2720
2721 * xfaces.c: Make symbols static if they're not exported.
2722 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2723 Remove decls.
2724 * xterm.h (defined_color): Remove decls.
2725 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2726 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2727 (menu_face_changed_default, defined_color, free_realized_face):
2728 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2729 (ascii_face_of_lisp_face): Remove; unused.
2730
2731 * xdisp.c: Make symbols static if they're not exported.
2732 * dispextern.h (scratch_glyph_row, window_box_edges):
2733 (glyph_to_pixel_coords, set_cursor_from_row):
2734 (get_next_display_element, set_iterator_to_next):
2735 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2736 (show_mouse_face): Remove decls
2737 * frame.h (message_buf_print): Likewise.
2738 * lisp.h (pop_message, set_message, check_point_in_composition):
2739 Likewise.
2740 * xterm.h (set_vertical_scroll_bar): Likewise.
2741 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2742 (message_buf_print, scratch_glyph_row, displayed_buffer):
2743 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2744 (get_next_display_element, show_mouse_face, window_box_edges):
2745 (frame_to_window_pixel_xy, check_point_in_composition):
2746 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2747 (glyph_to_pixel_coords): Remove; unused.
2748
2749 * dired.c (file_name_completion): Now static.
2750
2751 * dbusbind.c (xd_in_read_queued_messages): Now static.
2752
2753 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2754 * data.c (circular_list_error): Remove.
2755
2756 * commands.h (last_point_position, last_point_position_buffer):
2757 (last_point_position_window): Remove decls.
2758 * keyboard.c: Make these variables static.
2759
2760 * coding.h (coding, code_convert_region, encode_coding_gap):
2761 Remove decls.
2762 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2763 (iso_code_class, detect_coding, code_convert_region): Now static.
2764 (encode_coding_gap): Remove; unused.
2765
2766 * chartab.c (chartab_chars, chartab_bits): Now static.
2767
2768 * charset.h (charset_iso_8859_1): Remove decl.
2769 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2770 Now static.
2771
2772 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2773 * ccl.c (Vccl_program_table): Now static.
2774 (check_ccl_update): Remove; unused.
2775
2776 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2777 * category.h: ... from here.
2778 * category.c (check_category_table, set_category_set): Now static.
2779
2780 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2781 * lisp.h: Remove these decls.
2782
2783 * buffer.c (buffer_count): Remove unused var.
2784
2785 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2786 so that it's not optimized away.
2787 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2788 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2789 exported only to the debugger.
2790
2791 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2792 * atimer.h (run_all_atimers): Remove; not exported.
2793
2794 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2795 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2796 was inaccessible from Lisp.
2797 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2798 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2799
2800 alloc.c: Import and export fewer symbols, and remove unused items.
2801 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2802 is defined.
2803 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2804 it's not optimized away by whole-program optimization.
2805 (message_enable_multibyte, free_misc): Remove.
2806 (catchlist, handlerlist, mark_backtrace):
2807 Declare only if BYTE_MARK_STACK.
2808 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2809 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2810 (message_enable_multibyte): Remove decl.
2811 (free_misc, interval_free_list, float_block, float_block_index):
2812 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2813 (cons_free_list, last_marked_index):
2814 Now static.
2815 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2816 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2817 (mark_backtrace): Define only if BYTE_MARK_STACK.
2818 * xdisp.c (message_enable_multibyte): Now static.
2819
2820 Declare Lisp_Object Q* variables to be 'static' if not exported.
2821 This makes it easier for human readers (and static analyzers)
2822 to see whether these variables are used from other modules.
2823 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2824 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2825 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2826 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2827 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2828 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2829 * xmenu.c, xselect.c:
2830 Declare Q* vars static if they are not used in other modules.
2831 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2832 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2833 Remove decls of unexported vars.
2834 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2835
2836 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2837
2838 Make Emacs functions such as Fatom 'static' by default.
2839 This makes it easier for human readers (and static analyzers)
2840 to see whether these functions can be called from other modules.
2841 DEFUN now defines a static function. To make the function external
2842 so that it can be used in other C modules, use the new macro DEFUE.
2843 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2844 (Finit_image_library):
2845 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2846 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2847 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2848 Remove decls, since these functions are now static.
2849 (Funintern, Fget_internal_run_time): New decls, since these functions
2850 were already external.
2851
2852 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2853 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2854 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2855 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2856 * keyboard.c, keymap.c, lread.c:
2857 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2858 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2859 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2860 Mark functions with DEFUE instead of DEFUN,
2861 if they are used in other modules.
2862 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2863 decls for now-static functions.
2864 * buffer.h (Fdelete_overlay): Remove decl.
2865 * callproc.c (Fgetenv_internal): Mark as internal.
2866 * composite.c (Fremove_list_of_text_properties): Remove decl.
2867 (Fcomposition_get_gstring): New forward static decl.
2868 * composite.h (Fcomposite_get_gstring): Remove decl.
2869 * dired.c (Ffile_attributes): New forward static decl.
2870 * doc.c (Fdocumntation_property): New forward static decl.
2871 * eval.c (Ffetch_bytecode): New forward static decl.
2872 (Funintern): Remove extern decl; now in .h file where it belongs.
2873 * fileio.c (Fmake_symbolic_link): New forward static decl.
2874 * image.c (Finit_image_library): New forward static decl.
2875 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2876 * intervals.h (Fprevious_property_change):
2877 (Fremove_list_of_text_properties): Remove decls.
2878 * keyboard.c (Fthis_command_keys): Remove decl.
2879 (Fcommand_execute): New forward static decl.
2880 * keymap.c (Flookup_key): New forward static decl.
2881 (Fcopy_keymap): Now static.
2882 * keymap.h (Flookup_key): Remove decl.
2883 * process.c (Fget_process): New forward static decl.
2884 (Fprocess_datagram_address): Mark as internal.
2885 * syntax.c (Fsyntax_table_p): New forward static decl.
2886 (skip_chars): Remove duplicate decl.
2887 * textprop.c (Fprevious_property_change): New forward static decl.
2888 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2889 Now internal.
2890 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2891 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2892
2893 * editfns.c (Fformat): Remove unreachable code.
2894
2895 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2896
2897 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2898 change. (Bug#8496)
2899
2900 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2901
2902 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2903 when at ZV. (Bug#8487)
2904
2905 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2906
2907 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2908 (Bug#8437)
2909 * keyboard.c (parse_tool_bar_item): Likewise.
2910 * sound.c (sound_cleanup, alsa_close): Likewise.
2911 * termcap.c (tgetent): Likewise.
2912 * xfns.c (x_default_font_parameter): Likewise.
2913 * xsettings.c (read_and_apply_settings): Likewise.
2914
2915 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2916 (overrun_check_free): Protoize.
2917
2918 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2919
2920 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2921 since callers should never pass a negative size.
2922 Change the signature to match that of plain 'read' and 'write'; see
2923 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2924 * lisp.h: Update prototypes of emacs_write and emacs_read.
2925
2926 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2927
2928 * xdisp.c (redisplay_window): Don't try to determine the character
2929 position of the scroll margin if the window start point w->startp
2930 is outside the buffer's accessible region. (Bug#8468)
2931
2932 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2933
2934 Fix write-region and its subroutines for buffers > 2GB.
2935 * fileio.c (a_write, e_write): Modify declaration of arguments and
2936 local variables to support buffers larger than 2GB.
2937 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2938
2939 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2940 argument, local variables, and return value.
2941
2942 * lisp.h: Update prototypes of emacs_write and emacs_read.
2943
2944 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2945
2946 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2949
2950 Fix more problems found by GCC 4.6.0's static checks.
2951
2952 * xdisp.c (vmessage): Use a better test for character truncation.
2953
2954 * charset.c (load_charset_map): <, not <=, for optimization,
2955 and to avoid potential problems with integer overflow.
2956 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2957 * casetab.c (set_identity, shuffle): Likewise.
2958 * editfns.c (Fformat): Likewise.
2959 * syntax.c (skip_chars): Likewise.
2960
2961 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2962 This also lets GCC 4.6.0 generate slightly better loop code.
2963
2964 * callint.c (Fcall_interactively): <, not <=, for optimization.
2965 (Fcall_interactively): Count the number of arguments produced,
2966 not the number of arguments given. This is simpler and lets GCC
2967 4.6.0 generate slightly better code.
2968
2969 * ftfont.c: Distingish more carefully between FcChar8 and char.
2970 The previous code passed unsigned char * to a functions like
2971 strlen and xstrcasecmp that expect char *, which does not
2972 conform to the C standard.
2973 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2974 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2975 char * when the C standard requires it.
2976
2977 * keyboard.c (read_char): Remove unused var.
2978
2979 * eval.c: Port to Windows vsnprintf (Bug#8435).
2980 Include <limits.h>.
2981 (SIZE_MAX): Define if the headers do not.
2982 (verror): Do not give up if vsnprintf returns a negative count.
2983 Instead, grow the buffer. This ports to Windows vsnprintf, which
2984 does not conform to C99. Problem reported by Eli Zaretskii.
2985 Also, simplify the allocation scheme, by avoiding the need for
2986 calling realloc, and removing the ALLOCATED variable.
2987
2988 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2989
2990 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2991 But keep the doprint source code for now, as we might revamp it
2992 and use it again (Bug#8435).
2993 * lisp.h (doprnt): Remove.
2994 * Makefile.in (base_obj): Remove doprnt.o.
2995 * deps.mk (doprnt.o): Remove.
2996
2997 error: Print 32- and 64-bit integers portably (Bug#8435).
2998 Without this change, on typical 64-bit hosts error ("...%d...", N)
2999 was used to print both 32- and 64-bit integers N, which relied on
3000 undefined behavior.
3001 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3002 New macro.
3003 * lisp.h (error, verror): Mark as printf-like functions.
3004 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3005 Report overflow in size calculations when allocating printf buffer.
3006 Do not truncate output string at its first null byte.
3007 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3008 Truncate the output at a character boundary, since vsnprintf does not
3009 do that.
3010 * charset.c (check_iso_charset_parameter): Convert internal
3011 character to string before calling 'error', since %c now has the
3012 printf meaning.
3013 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3014 overflow when computing char to be passed to 'error'. Do not
3015 pass Lisp_Object to 'error'; pass the integer instead.
3016 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3017 formatted with plain %d.
3018
3019 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3020
3021 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3022
3023 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3024
3025 * xterm.c (x_catch_errors): Remove duplicate declaration.
3026
3027 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3028
3029 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3030
3031 2011-04-10 Jim Meyering <meyering@redhat.com>
3032
3033 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3034 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3035 return ssize_t not "int", and use size_t as the buffer length.
3036 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3037 * gnutls.h: Update declarations.
3038 * process.c (read_process_output): Use ssize_t, to match.
3039 (send_process): Likewise.
3040
3041 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3042
3043 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3044
3045 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3046
3047 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3048 Use unsigned char, to match FcChar8 type definition.
3049
3050 * xterm.c (handle_one_xevent):
3051 * xmenu.c (create_and_show_popup_menu):
3052 * xselect.c (x_decline_selection_request)
3053 (x_reply_selection_request): Avoid type-punned deref of X events.
3054
3055 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3056
3057 Fix some uses of `int' instead of EMACS_INT.
3058 * search.c (string_match_1, fast_string_match)
3059 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3060 (scan_buffer, find_next_newline_no_quit)
3061 (find_before_next_newline, search_command, Freplace_match)
3062 (Fmatch_data): Make some `int' variables be EMACS_INT.
3063
3064 * xdisp.c (display_count_lines): 3rd argument and return value now
3065 EMACS_INT. All callers changed.
3066 (pint2hrstr): Last argument is now EMACS_INT.
3067
3068 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3069 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3070 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3071 (decode_coding_utf_16, decode_coding_emacs_mule)
3072 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3073 (decode_coding_ccl, decode_coding_charset)
3074 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3075 (decode_coding_iso_2022, decode_coding_emacs_mule)
3076 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3077 <char_offset, last_offset>: Declare EMACS_INT.
3078 (encode_coding_utf_8, encode_coding_utf_16)
3079 (encode_coding_emacs_mule, encode_invocation_designation)
3080 (encode_designation_at_bol, encode_coding_iso_2022)
3081 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3082 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3083 Declare EMACS_INT.
3084 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3085 (encode_invocation_designation): Last argument P_NCHARS is now
3086 EMACS_INT.
3087 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3088 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3089
3090 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3091 All users changed.
3092
3093 * ccl.c (Fccl_execute_on_string): Declare some variables
3094 EMACS_INT.
3095
3096 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3097
3098 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3099
3100 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3101
3102 * process.c (Fformat_network_address): Doc fix.
3103
3104 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3105
3106 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3107
3108 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3109
3110 * keyboard.c (read_char): Call Lisp function help-form-show,
3111 instead of using internal_with_output_to_temp_buffer.
3112 (Qhelp_form_show): New var.
3113 (syms_of_keyboard): Use DEFSYM macro.
3114
3115 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3116
3117 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3118
3119 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3120
3121 * process.c (Flist_processes): Remove to Lisp.
3122 (list_processes_1): Delete.
3123
3124 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3125
3126 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3127
3128 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3129
3130 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 Fix more problems found by GCC 4.6.0's static checks.
3133
3134 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3135
3136 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3137
3138 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3139
3140 * xdisp.c (vmessage): Mark as a printf-like function.
3141
3142 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3143
3144 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3145
3146 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3147 printf-like functions.
3148 (tiff_load): Add casts to remove these marks before passing them
3149 to system-supplied API.
3150
3151 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3152
3153 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3154 This avoids several warnings with gcc -Wstrict-overflow.
3155 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3156 directly, rather than having caller test rule sign. This avoids
3157 some unnecessary tests.
3158 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3159 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3160 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3161
3162 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3163 (xfont_open): Avoid unnecessary tests.
3164
3165 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3166
3167 * composite.h, composite.c (composition_gstring_put_cache):
3168 Use EMACS_INT, not int, for length.
3169
3170 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3171 breaking out part of COMPOSITION_DECODE_RULE.
3172 (COMPOSITION_DECODE_RULE): Use it.
3173 * composite.c (get_composition_id): Remove unused local vars,
3174 by using the new macro.
3175
3176 * textprop.c (set_text_properties_1): Change while to do-while,
3177 since the condition is always true at first.
3178
3179 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3180 (interval_deletion_adjustment): Return unsigned value.
3181 All uses changed.
3182
3183 * process.c (list_processes_1, create_pty, read_process_output):
3184 (exec_sentinel): Remove vars that were set but not used.
3185 (create_pty): Remove unnecessary "volatile"s.
3186 (Fnetwork_interface_info): Avoid possibility of int overflow.
3187 (read_process_output): Do adaptive read buffering even if carryover.
3188 (read_process_output): Simplify nbytes computation if buffered.
3189
3190 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3191
3192 * syntax.c (scan_words): Remove var that was set but not used.
3193 (update_syntax_table): Use unsigned instead of int.
3194
3195 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3196 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3197 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3198
3199 * print.c (print_error_message): Avoid int overflow.
3200
3201 * font.c (font_list_entities): Redo for clarity,
3202 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3203
3204 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3205 (font_score): Avoid potential overflow in diff calculation.
3206
3207 * fns.c (substring_both): Remove var that is set but not used.
3208 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3209
3210 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3211
3212 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3213 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3214 can always succeed if overflow has undefined behavior.
3215
3216 * search.c (boyer_moore, wordify): Remove vars set but not used.
3217 (wordify): Omit three unnecessary tests.
3218
3219 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3220 All callers changed. This avoids the need for an unused var.
3221
3222 * casefiddle.c (casify_region): Remove var that is set but not used.
3223
3224 * dired.c (file_name_completion): Remove var that is set but not used.
3225
3226 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3227
3228 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3229 (Finsert_file_contents): Remove unnecessary code checking fd.
3230
3231 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3232 Check for integer overflow on size calculations.
3233
3234 * buffer.c (Fprevious_overlay_change): Remove var that is set
3235 but not used.
3236
3237 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3238 Remove vars that are set but not used.
3239 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3240 (timer_check_2): Mark vars as initialized.
3241
3242 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3243
3244 * image.c (lookup_image): Remove var that is set but not used.
3245 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3246
3247 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3248 that are set but not used.
3249
3250 * xfns.c (make_invisible_cursor): Don't return garbage
3251 if XCreateBitmapFromData fails (Bug#8410).
3252
3253 * xselect.c (x_get_local_selection, x_handle_property_notify):
3254 Remove vars that are set but not used.
3255
3256 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3257 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3258
3259 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3260 Remove var that is set but not used.
3261 (scroll_bar_windows_size): Now size_t, not int.
3262 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3263 Check for overflow.
3264
3265 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3266 (map_tty_color) [!defined MSDOS]: Likewise.
3267
3268 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3269
3270 * coding.c: Remove vars that are set but not used.
3271 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3272 All callers changed.
3273 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3274 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3275 (decode_coding_charset): Remove vars that are set but not used.
3276
3277 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3278 that is set but not used.
3279
3280 * print.c (print_object): Remove var that is set but not used.
3281
3282 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3283 The gnulib version avoids calling malloc in the usual case,
3284 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3285 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3286 * filelock.c (current_lock_owner): Likewise.
3287 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3288 * sysdep.c: Include allocator.h, careadlinkat.h.
3289 (emacs_no_realloc_allocator): New static constant.
3290 (emacs_readlink): New function.
3291 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3292 ../lib/careadlinkat.h.
3293
3294 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3295
3296 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3297 first non-nil return value).
3298
3299 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3300
3301 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3302 if not defined (Bug#8403).
3303
3304 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3305
3306 * xdisp.c (display_count_lines): Remove parameter `start',
3307 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3308 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3309 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3310 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3311 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3312 and thereabouts. All callers changed.
3313 (get_per_char_metric): Remove parameter `f', unused since
3314 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3315
3316 2011-04-02 Jim Meyering <meyering@redhat.com>
3317
3318 do not dereference NULL upon failed strdup
3319 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3320 (ns_get_family): Likewise.
3321
3322 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3323
3324 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3325
3326 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3329 later (Bug#8403).
3330
3331 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3332
3333 Add lexical binding.
3334
3335 * window.c (Ftemp_output_buffer_show): New fun.
3336 (Fsave_window_excursion):
3337 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3338
3339 * lread.c (lisp_file_lexically_bound_p): New function.
3340 (Fload): Bind Qlexical_binding.
3341 (readevalloop): Remove `evalfun' arg.
3342 Bind Qinternal_interpreter_environment.
3343 (Feval_buffer): Bind Qlexical_binding.
3344 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3345 Mark as dynamic.
3346 (syms_of_lread): Declare `lexical-binding'.
3347
3348 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3349
3350 * keyboard.c (eval_dyn): New fun.
3351 (menu_item_eval_property): Use it.
3352
3353 * image.c (parse_image_spec): Use Ffunctionp.
3354
3355 * fns.c (concat, mapcar1): Accept byte-code-functions.
3356
3357 * eval.c (Fsetq): Handle lexical vars.
3358 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3359 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3360 (FletX, Flet): Obey lexical binding.
3361 (Fcommandp): Handle closures.
3362 (Feval): New `lexical' arg.
3363 (eval_sub): New function extracted from Feval. Use it almost
3364 everywhere where Feval was used. Look up vars in lexical env.
3365 Handle closures.
3366 (Ffunctionp): Move from subr.el.
3367 (Ffuncall): Handle closures.
3368 (apply_lambda): Remove `eval_flags'.
3369 (funcall_lambda): Handle closures and new byte-code-functions.
3370 (Fspecial_variable_p): New function.
3371 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3372 but without exporting it to Lisp.
3373
3374 * doc.c (Fdocumentation, store_function_docstring):
3375 * data.c (Finteractive_form): Handle closures.
3376
3377 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3378 interactive spec.
3379
3380 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3381 New byte-codes.
3382 (exec_byte_code): New function extracted from Fbyte_code to handle new
3383 calling convention for byte-code-functions. Add new byte-codes.
3384
3385 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3386
3387 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3388
3389 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * xdisp.c (redisplay_internal): Fix prototype.
3392
3393 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3394
3395 * xdisp.c (SCROLL_LIMIT): New macro.
3396 (try_scrolling): Use it when setting scroll_limit.
3397 Limit scrolling to 100 screen lines.
3398 (redisplay_window): Even when falling back on "recentering",
3399 position point in the window according to scroll-conservatively,
3400 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3401
3402 (try_scrolling): When point is above the window, allow searching
3403 as far as scroll_max, or one screenful, to compute vertical
3404 distance from PT to the scroll margin position. This prevents
3405 try_scrolling from unnecessarily failing when
3406 scroll-conservatively is set to a value slightly larger than the
3407 window height. Clean up the case of PT below the margin at bottom
3408 of window: scroll_max can no longer be INT_MAX. When aggressive
3409 scrolling is in use, don't let point enter the opposite scroll
3410 margin as result of the scroll.
3411 (syms_of_xdisp) <scroll-conservatively>: Document the
3412 threshold of 100 lines for never-recentering scrolling.
3413
3414 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3415
3416 * dispextern.h (move_it_by_lines):
3417 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3418 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3419 (message_log_check_duplicate): Remove parameters `prev_bol' and
3420 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3421 (redisplay_internal): Remove parameter `preserve_echo_area',
3422 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3423
3424 * indent.c (Fvertical_motion):
3425 * window.c (window_scroll_pixel_based, Frecenter):
3426 Don't pass `need_y_p' to `move_it_by_lines'.
3427
3428 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3429
3430 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3431 steal a few bits to be more compact.
3432 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3433 Remove unneeded casts.
3434
3435 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3436
3437 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3438
3439 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3440 binding" message (bug#7967).
3441
3442 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Fix more problems found by GCC 4.6.0's static checks.
3445
3446 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3447 Remove unused local var.
3448
3449 * editfns.c (Fmessage_box): Remove unused local var.
3450
3451 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3452 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3453 Omit unused local vars.
3454 * window.c (shrink_windows): Omit unused local var.
3455 * menu.c (digest_single_submenu): Omit unused local var.
3456 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3457 Omit unused local var.
3458
3459 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3460 Don't assume string length fits in int.
3461 (keyremap_step, read_key_sequence): Use size_t for sizes.
3462 (read_key_sequence): Don't check last_real_key_start redundantly.
3463
3464 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3465 instead of alloca (Bug#8344).
3466
3467 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3468 (Fbacktrace_frame): Don't assume nframes fits in int.
3469
3470 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3471
3472 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3473 concerns.
3474
3475 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3476
3477 * cm.c (calccost): Turn while-do into do-while, for clarity.
3478
3479 * keyboard.c (syms_of_keyboard): Use the same style as later
3480 in this function when indexing through an array. This also
3481 works around GCC bug 48267.
3482
3483 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3484
3485 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3486
3487 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3488 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3489
3490 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3491 This avoids undefined behavior on integer overflow, and is a bit
3492 more convenient anyway since it is compared to a size_t variable.
3493
3494 Variadic C functions now count arguments with size_t, not int.
3495 This avoids an unnecessary limitation on 64-bit machines, which
3496 caused (substring ...) to crash on large vectors (Bug#8344).
3497 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3498 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3499 All variadic functions and their callers changed accordingly.
3500 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3501 * data.c (arith_driver, float_arith_driver): Likewise.
3502 * editfns.c (general_insert_function): Likewise.
3503 * eval.c (struct backtrace.nargs, interactive_p)
3504 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3505 (funcall_lambda, mark_backtrace): Likewise.
3506 * fns.c (concat): Likewise.
3507 * frame.c (x_set_frame_parameters): Likewise.
3508 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3509 0 if not found, not -1. All callers changed.
3510
3511 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3512 (stack_copy_size): Now size_t, not int.
3513 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3514
3515 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3516
3517 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3518 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3519 All callers changed.
3520
3521 * lisp.h (multibyte_char_to_unibyte):
3522 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3523 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3524 * character.h (CHAR_TO_BYTE8):
3525 * cmds.c (internal_self_insert):
3526 * editfns.c (general_insert_function):
3527 * keymap.c (push_key_description):
3528 * search.c (Freplace_match):
3529 * xdisp.c (message_dolog, set_message_1): All callers changed.
3530
3531 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3532
3533 * keyboard.c (safe_run_hook_funcall): New function.
3534 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3535 don't set the hook to nil, but remove the offending function instead.
3536 (Qcommand_hook_internal): Remove, unused.
3537 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3538 Vcommand_hook_internal.
3539
3540 * eval.c (enum run_hooks_condition): Remove.
3541 (funcall_nil, funcall_not): New functions.
3542 (run_hook_with_args): Call each function through a `funcall' argument.
3543 Remove `cond' argument, now redundant.
3544 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3545 (Frun_hook_with_args_until_failure): Adjust accordingly.
3546 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3547
3548 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3549
3550 * dispextern.h (string_buffer_position): Remove declaration.
3551
3552 * print.c (strout): Remove parameter `multibyte', unused since
3553 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3554
3555 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3556 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3557 All callers changed.
3558
3559 * w32.c (_wsa_errlist): Use braces for struct initializers.
3560
3561 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3562 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3563 All callers changed.
3564 (string_buffer_position): Likewise. Also, make static (it's never
3565 used outside xdisp.c).
3566 (cursor_row_p): Remove parameter `w', unused since
3567 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3568 (decode_mode_spec): Remove parameter `precision', introduced during
3569 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3570 All callers changed.
3571
3572 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3573
3574 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3575
3576 2011-03-27 Anders Lindgren <andlind@gmail.com>
3577
3578 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3579 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3580 (ns_update_auto_hide_menu_bar): New functions.
3581 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3582 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3583 ns_constrain_all_frames.
3584 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3585 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3586
3587 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3588
3589 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3590
3591 2011-03-27 Glenn Morris <rgm@gnu.org>
3592
3593 * syssignal.h: Replace RETSIGTYPE with void.
3594 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3595 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3596 Replace SIGTYPE with void everywhere.
3597 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3598 * s/template.h (SIGTYPE): Remove commented out definition.
3599
3600 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3601
3602 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3603 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3604
3605 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * w32.c (read_unc_volume): Use parameter `henum', instead of
3608 global variable `wget_enum_handle'.
3609
3610 * keymap.c (describe_vector): Remove parameters `indices' and
3611 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3612 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3613
3614 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3615
3616 * keyboard.c (timer_check): Remove parameter `do_it_now',
3617 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3618 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3619 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3620
3621 * keyboard.c (read_char):
3622 * w32menu.c (w32_menu_display_help):
3623 * xmenu.c (show_help_event, menu_help_callback):
3624 Adjust calls to `show_help_echo'.
3625
3626 * gtkutil.c (xg_maybe_add_timer):
3627 * keyboard.c (readable_events):
3628 * process.c (wait_reading_process_output):
3629 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3630
3631 * insdel.c (adjust_markers_gap_motion):
3632 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3633 (gap_left, gap_right): Don't call it.
3634
3635 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3636
3637 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3638 incurred during fontification.
3639
3640 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3641
3642 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3643 (DEFVAR_PER_BUFFER): Don't pass it.
3644
3645 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3646 (scrolling_window): Don't pass it.
3647
3648 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3649
3650 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3651
3652 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3653 and `suffix'.
3654 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3655 of variables specific to SELinux and computation of `encoded_absname'.
3656
3657 * image.c (XPutPixel): Remove unused variable `height'.
3658
3659 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3660
3661 * unexw32.c (get_section_info): Remove unused variable `section'.
3662
3663 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3664 (system_process_attributes): Remove unused variable `sess'.
3665 (sys_read): Remove unused variable `err'.
3666
3667 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3668 (w32_wnd_proc): Remove unused variable `isdead'.
3669 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3670 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3671 (x_create_tip_frame): Remove unused variable `tem'.
3672
3673 * w32inevt.c (w32_console_read_socket):
3674 Remove unused variable `no_events'.
3675
3676 * w32term.c (x_draw_composite_glyph_string_foreground):
3677 Remove unused variable `width'.
3678
3679 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3680
3681 * w32term.c (x_set_glyph_string_clipping):
3682 Don't pass uninitialized region to CombineRgn.
3683
3684 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3687 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3688 (Fx_close_connection): Remove unused variable `i'.
3689
3690 * w32font.c (w32font_draw): Return number of glyphs.
3691 (w32font_open_internal): Remove unused variable `i'.
3692 (w32font_driver): Add missing initializer.
3693
3694 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3695 (fill_in_menu): Remove unused variable `items_added'.
3696
3697 * w32term.c (last_mouse_press_frame): Remove static global variable.
3698 (w32_clip_to_row): Remove unused variable `f'.
3699 (x_delete_terminal): Remove unused variable `i'.
3700
3701 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3702 (NOTHING): Remove unused static global variable.
3703 (uniscribe_check_otf): Remove unused variable `table'.
3704 (uniscribe_font_driver): Add missing initializers.
3705
3706 2011-03-23 Julien Danjou <julien@danjou.info>
3707
3708 * term.c (Fsuspend_tty, Fresume_tty):
3709 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3710 * window.c (temp_output_buffer_show):
3711 * insdel.c (signal_before_change):
3712 * frame.c (Fhandle_switch_frame):
3713 * fileio.c (Fdo_auto_save):
3714 * emacs.c (Fkill_emacs):
3715 * editfns.c (save_excursion_restore):
3716 * cmds.c (internal_self_insert):
3717 * callint.c (Fcall_interactively):
3718 * buffer.c (Fkill_all_local_variables):
3719 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3720 Use Frun_hooks.
3721 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3722 unconditionnaly since it does the check itself.
3723
3724 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 Fix more problems found by GCC 4.5.2's static checks.
3727
3728 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3729 the first time through the loop, since we know p0 < p1 then.
3730 This also avoids a gcc -Wstrict-overflow warning.
3731
3732 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3733 leading to a memory leak, possible in functions like
3734 load_charset_map_from_file that can allocate an unbounded number
3735 of objects (Bug#8318).
3736
3737 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3738 that could (at least in theory) be that large.
3739
3740 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3741 This is less likely to overflow, and avoids undefined behavior if
3742 overflow does occur. All callers changed. Use strtoul to scan
3743 for the unsigned long integer.
3744 (pint2hrstr): Simplify and tune code slightly.
3745 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3746
3747 * scroll.c (do_scrolling): Work around GCC bug 48228.
3748 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3749
3750 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3751 This also avoids a warning with gcc -Wstrict-overflow.
3752 (validate_x_resource_name): Simplify count usage.
3753 This also avoids a warning with gcc -Wstrict-overflow.
3754
3755 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3756 fail (Bug#8306).
3757
3758 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3759
3760 * process.c (Fmake_network_process): Use socklen_t, not int,
3761 where POSIX says socklen_t is required in portable programs.
3762 This fixes a porting bug on hosts like 64-bit HP-UX, where
3763 socklen_t is wider than int (Bug#8277).
3764 (Fmake_network_process, server_accept_connection):
3765 (wait_reading_process_output, read_process_output):
3766 Likewise.
3767
3768 * process.c: Rename or move locals to avoid shadowing.
3769 (list_processes_1, Fmake_network_process):
3770 (read_process_output_error_handler, exec_sentinel_error_handler):
3771 Rename or move locals.
3772 (Fmake_network_process): Define label "retry_connect" only if needed.
3773 (Fnetwork_interface_info): Fix pointer signedness.
3774 (process_send_signal): Add cast to avoid pointer signedness problem.
3775 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3776 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3777
3778 Make tparam.h and terminfo.c consistent.
3779 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3780 Include tparam.h instead, since it declares them.
3781 * cm.h (PC): Remove extern decl; tparam.h now does this.
3782 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3783 * terminfo.c: Include tparam.h, to check interfaces.
3784 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3785 (tparam): Adjust signature to match interface in tparam.h;
3786 this removes some undefined behavior. Check that outstring and len
3787 are zero, which they always are with Emacs.
3788 * tparam.h (PC, BC, UP): New extern decls.
3789
3790 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3791 (xftfont_open): Rename locals to avoid shadowing.
3792
3793 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3794 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3795 (OTF_TAG_SYM): Omit macro if not needed.
3796 (ftfont_list): Remove unused local.
3797 (get_adstyle_property, ftfont_pattern_entity):
3798 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3799 Rename locals to avoid shadowing.
3800
3801 * xfont.c (xfont_list_family): Mark var as initialized.
3802
3803 * xml.c (make_dom): Now static.
3804
3805 * composite.c (composition_compute_stop_pos): Rename local to
3806 avoid shadowing.
3807 (composition_reseat_it): Remove unused locals.
3808 (find_automatic_composition, composition_adjust_point): Likewise.
3809 (composition_update_it): Mark var as initialized.
3810 (find_automatic_composition): Mark vars as initialized,
3811 with a FIXME (Bug#8290).
3812
3813 character.h: Rename locals to avoid shadowing.
3814 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3815 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3816 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3817 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3818 to avoid shadowing.
3819
3820 * textprop.c (property_change_between_p): Remove; unused.
3821
3822 * intervals.c (interval_start_pos): Now static.
3823
3824 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3825
3826 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3827 Rename locals to avoid shadowing.
3828
3829 * sound.c (wav_play, au_play, Fplay_sound_internal):
3830 Fix pointer signedness.
3831 (alsa_choose_format): Remove unused local var.
3832 (wav_play): Initialize a variable to 0, to prevent undefined
3833 behavior (Bug#8278).
3834
3835 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3836
3837 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3838
3839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3840 clobbering (Bug#8298).
3841 * sysdep.c (sys_subshell): Likewise.
3842 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3843
3844 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3845 This should get cleaned up, so that child_setup has the
3846 same signature on all platforms.
3847
3848 * callproc.c (call_process_cleanup): Now static.
3849 (relocate_fd): Rename locals to avoid shadowing.
3850
3851 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3852
3853 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3854 not to be necessary, and produces flickering.
3855
3856 2011-03-20 Glenn Morris <rgm@gnu.org>
3857
3858 * config.in: Remove file.
3859
3860 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3863 are now in src/globals.h.
3864 (syms_of_minibuf): Remove spurious & from previous change.
3865
3866 2011-03-20 Leo <sdl.web@gmail.com>
3867
3868 * minibuf.c (completing-read-function): New variable.
3869 (completing-read-default): Rename from completing-read.
3870 (completing-read): Call completing-read-function.
3871
3872 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3873
3874 * xfaces.c (Fx_load_color_file):
3875 Read color file from absolute filename (bug#8250).
3876
3877 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * makefile.w32-in: Update dependencies.
3880
3881 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3882
3883 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3884
3885 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 Fix more problems found by GCC 4.5.2's static checks.
3888
3889 * process.c (make_serial_process_unwind, send_process_trap):
3890 (sigchld_handler): Now static.
3891
3892 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3893 That way, the code declares only the vars that it needs.
3894 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3895 * s/cygwin.h (PTY_ITERATION): Likewise.
3896 * s/darwin.h (PTY_ITERATION): Likewise.
3897 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3898
3899 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3900 * process.c (allocate_pty): Don't declare stb unless it's needed.
3901
3902 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3903 (CONSTANTLIM): Remove; unused.
3904 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3905 Define only if needed.
3906
3907 * unexelf.c (unexec): Name an expression,
3908 to avoid gcc -Wbad-function-cast warning.
3909 Use a different way to cause a compilation error if anyone uses
3910 n rather than nn, a way that does not involve shadowing.
3911 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3912
3913 * deps.mk (unexalpha.o): Remove; unused.
3914
3915 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3916 * unexec.h: New file.
3917 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3918 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3919 Depend on unexec.h.
3920 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3921 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3922 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3923 Change as necessary to match prototype in unexec.h.
3924
3925 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3926 shadowing.
3927 (back_comment, skip_chars): Mark vars as initialized.
3928
3929 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3930 Rename locals to avoid shadowing.
3931
3932 * lread.c (read1): Rewrite so as not to use empty "else".
3933 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3934
3935 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3936
3937 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3938 warning when compiling print.c.
3939
3940 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3941 instead of using an uninitialized var.
3942 (font_sort_entities): Mark var as initialized.
3943
3944 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3945
3946 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3947 pointers to constants.
3948 (font_parse_fcname): Remove unused vars.
3949 (font_delete_unmatched): Now static.
3950 (font_get_spec): Remove; unused.
3951 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3952 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3953 Rename or move locals to avoid shadowing.
3954
3955 * fns.c (require_nesting_list, require_unwind): Now static.
3956 (Ffillarray): Rename locals to avoid shadowing.
3957
3958 * floatfns.c (domain_error2): Define only if needed.
3959 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3960
3961 * alloc.c (mark_backtrace): Move decl from here ...
3962 * lisp.h: ... to here, so that it can be checked.
3963
3964 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3965 (Fdefvar): Rewrite so as not to use empty "else".
3966 (lisp_indirect_variable): Name an expression,
3967 to avoid gcc -Wbad-function-cast warning.
3968 (Fdefvar): Rename locals to avoid shadowing.
3969
3970 * callint.c (quotify_arg, quotify_args): Now static.
3971 (Fcall_interactively): Rename locals to avoid shadowing.
3972 Use const pointer when appropriate.
3973
3974 * lisp.h (get_system_name, get_operating_system_release):
3975 Move decls here, to check interfaces.
3976 * process.c (get_operating_system_release): Move decl to lisp.h.
3977 * xrdb.c (get_system_name): Likewise.
3978 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3979 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3980 some of which prompt warnings from gcc -Wbad-function-cast.
3981 (Fformat_time_string, Fencode_time, Finsert_char):
3982 (Ftranslate_region_internal, Fformat):
3983 Rename or remove local vars to avoid shadowing.
3984 (Ftranslate_region_internal): Mark var as initialized.
3985
3986 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3987 avoid shadowing.
3988
3989 * lisp.h (eassert): Check that the argument compiles, even if
3990 ENABLE_CHECKING is not defined.
3991
3992 * data.c (Findirect_variable): Name an expression, to avoid
3993 gcc -Wbad-function-cast warning.
3994 (default_value, arithcompare, arith_driver, arith_error): Now static.
3995 (store_symval_forwarding): Rename local to avoid shadowing.
3996 (Fmake_variable_buffer_local, Fmake_local_variable):
3997 Mark variables as initialized.
3998 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3999
4000 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4001 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4002 Rename locals to avoid shadowing.
4003 (mark_stack): Move local variables into the #ifdef region where
4004 they're used.
4005 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4006 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4007 needed otherwise.
4008 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4009 (GC_STRING_CHARS): Remove; not used.
4010 (Fmemory_limit): Cast sbrk's returned value to char *.
4011
4012 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4013 avoids undefined behavior in theory.
4014
4015 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4016
4017 Use functions, not macros, for up- and down-casing (Bug#8254).
4018 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4019 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4020 to use the following functions instead of these macros.
4021 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4022 EMACS_INT, since callers assume the returned value fits in int.
4023 (upcase1): Likewise, for UPCASE_TABLE.
4024 (uppercasep, lowercasep, upcase): New static inline functions.
4025 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4026 the race-condition problem in the old DOWNCASE.
4027
4028 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4029 Rename locals to avoid shadowing.
4030 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4031 (regex_compile, re_search_2, re_match_2_internal):
4032 Remove unused local vars.
4033 (FREE_VAR): Rewrite so as not to use empty "else",
4034 which gcc can warn about.
4035 (regex_compile, re_match_2_internal): Mark locals as initialized.
4036 (RETALLOC_IF): Define only if needed.
4037 (WORDCHAR_P): Likewise. This one is never needed, but is used
4038 only in a comment talking about a compiler bug, so put inside
4039 the #if 0 of that comment.
4040 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4041 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4042 Remove; unused.
4043
4044 * search.c (boyer_moore): Rename locals to avoid shadowing.
4045 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4046 (PREV_CHAR_BOUNDARY): Likewise.
4047
4048 * search.c (simple_search): Remove unused var.
4049
4050 * dired.c (compile_pattern): Move decl from here ...
4051 * lisp.h: ... to here, so that it can be checked.
4052 (struct re_registers): New forward decl.
4053
4054 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4055
4056 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4057 All uses changed.
4058 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4059 Rename locals to avoid shadowing.
4060 (Fvertical_motion): Mark locals as initialized.
4061
4062 * casefiddle.c (casify_object, casify_region): Now static.
4063 (casify_region): Mark local as initialized.
4064
4065 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4066
4067 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4068 New macros, so that the caller can use some names other than
4069 gcpro1, gcpro2, etc.
4070 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4071 of the new macros.
4072 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4073 argument, for consistency with GCPRO2_VAR, etc: it is now the
4074 prefix of the variable, not the variable itself. All uses
4075 changed.
4076 * dired.c (directory_files_internal, file_name_completion):
4077 Rename locals to avoid shadowing.
4078
4079 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4080 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4081 dired.c's scmp function, had undefined behavior.
4082 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4083 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4084 * buffer.h: ... to here, because these macros use current_buffer,
4085 and the new implementation with inline functions needs to have
4086 current_buffer in scope now, rather than later when the macros
4087 are used.
4088 (downcase, upcase1): New static inline functions.
4089 (DOWNCASE, UPCASE1): Reimplement using these functions.
4090 This avoids undefined behavior in expressions like
4091 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4092 from race conditions in accessing the global variables
4093 case_temp1 and case_temp2.
4094 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4095 * lisp.h (case_temp1, case_temp2): Remove their decls.
4096 * character.h (ASCII_CHAR_P): Move from here ...
4097 * lisp.h: ... to here, so that the inline functions mentioned
4098 above can use them.
4099
4100 * dired.c (directory_files_internal_unwind): Now static.
4101
4102 * fileio.c (file_name_as_directory, directory_file_name):
4103 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4104 Now static.
4105 (file_name_as_directory): Use const pointers when appropriate.
4106 (Fexpand_file_name): Likewise. In particular, newdir might
4107 point at constant storage, so make it a const pointer.
4108 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4109 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4110 signedness issues.
4111 (Fset_file_times, Finsert_file_contents, auto_save_error):
4112 Rename locals to avoid shadowing.
4113
4114 * minibuf.c (choose_minibuf_frame_1): Now static.
4115 (Ftry_completion, Fall_completions): Rename or remove locals
4116 to avoid shadowing.
4117
4118 * marker.c (bytepos_to_charpos): Remove; unused.
4119
4120 * lisp.h (verify_bytepos, count_markers): New decls,
4121 so that gcc does not warn that these functions aren't declared.
4122
4123 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4124 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4125 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4126 (copy_text): Remove unused local var.
4127
4128 * filelock.c (within_one_second): Now static.
4129 (lock_file_1): Rename local to avoid shadowing.
4130
4131 * buffer.c (fix_overlays_before): Mark locals as initialized.
4132 (fix_start_end_in_overlays): Likewise. This function should be
4133 simplified by using pointers-to-pointers, but that's a different
4134 matter.
4135 (switch_to_buffer_1): Now static.
4136 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4137 (report_overlay_modification): Rename locals to avoid shadowing.
4138
4139 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4140 Fix pointer signedness issue.
4141 (sys_subshell): Mark local as volatile if checking for lint,
4142 to suppress a gcc -Wclobbered warning that does not seem to be right.
4143 (MAXPATHLEN): Define only if needed.
4144
4145 * process.c (serial_open, serial_configure): Move decls from here ...
4146 * systty.h: ... to here, so that they can be checked.
4147
4148 * fns.c (get_random, seed_random): Move extern decls from here ...
4149 * lisp.h: ... to here, so that they can be checked.
4150
4151 * sysdep.c (reset_io): Now static.
4152 (wait_for_termination_signal): Remove; unused.
4153
4154 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4155 (copy_keymap_item, append_key, push_text_char_description):
4156 Now static.
4157 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4158 (DENSE_TABLE_SIZE): Remove; unused.
4159 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4160 (describe_map_tree):
4161 Rename locals to avoid shadowing.
4162
4163 * keyboard.c: Declare functions static if they are not used elsewhere.
4164 (echo_char, echo_dash, cmd_error, top_level_2):
4165 (poll_for_input, handle_async_input): Now static.
4166 (read_char, kbd_buffer_get_event, make_lispy_position):
4167 (make_lispy_event, make_lispy_movement, apply_modifiers):
4168 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4169 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4170 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4171 (read_key_sequence, read_char): Mark locals as initialized.
4172 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4173
4174 * keyboard.h (make_ctrl_char): New decl.
4175 (mark_kboards): Move decl here ...
4176 * alloc.c (mark_kboards): ... from here.
4177
4178 * lisp.h (force_auto_save_soon): New decl.
4179
4180 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4181 (DEFINE_DUMMY_FUNCTION): New macro.
4182 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4183 Use it.
4184 (main): Add casts to avoid warnings
4185 if GCC considers string literals to be constants.
4186
4187 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4188
4189 * dbusbind.c: Pointer signedness fixes.
4190 (xd_signature, xd_append_arg, xd_initialize):
4191 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4192 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4193 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4194 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4195
4196 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4197 if GCC considers string literals to be constants.
4198 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4199
4200 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4201
4202 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4203 (print_preprocess, print_object): New macro to fix last change.
4204
4205 * print.c (print_preprocess): Don't forget font objects.
4206
4207 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4208
4209 * emacs.c (USAGE3): Doc fixes.
4210
4211 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4212
4213 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4214 structure.
4215
4216 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * lisp.h (VWindow_system, Qfile_name_history):
4219 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4220 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4221 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4222
4223 * w32select.c: Don't #include "keyboard.h".
4224 (run_protected): Add extern declaration for waiting_for_input.
4225
4226 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4227 * w32console.c (detect_input_pending, read_input_pending)
4228 (encode_terminal_code):
4229 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4230 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4231 (w32_system_caret_y, Qfile_name_history):
4232 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4233 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4234 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4235 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4236 * w32proc.c (Qlocal, report_file_error):
4237 * w32term.c (Vwindow_system, updating_frame):
4238 * w32uniscribe.c (initialized, uniscribe_font_driver):
4239 Remove unneeded extern declarations.
4240
4241 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4242
4243 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4244
4245 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4246
4247 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4248 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4249 These macros can no longer be used for assignment.
4250
4251 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4252 Assign struct members directly, instead of using BUF_BEGV etc.
4253 (record_buffer_markers, fetch_buffer_markers): New functions for
4254 recording and fetching special buffer markers.
4255 (set_buffer_internal_1, set_buffer_temp): Use them.
4256
4257 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4258
4259 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4260
4261 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4262 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4263
4264 * xdisp.c (hscroll_window_tree):
4265 (reconsider_clip_changes): Use PT instead of BUF_PT.
4266
4267 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4268
4269 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4270 $(EMACS_ROOT)/lib/intprops.h.
4271
4272 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4273
4274 Fix more problems found by GCC 4.5.2's static checks.
4275
4276 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4277 to unsigned char * to avoid compiler diagnostic.
4278 (xg_free_frame_widgets): Make it clear that a local variable is
4279 needed only if USE_GTK_TOOLTIP.
4280 (gdk_window_get_screen): Make it clear that this macro is needed
4281 only if USE_GTK_TOOLTIP.
4282 (int_gtk_range_get_value): New function, which avoids a diagnostic
4283 from gcc -Wbad-function-cast.
4284 (xg_set_toolkit_scroll_bar_thumb): Use it.
4285 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4286 diagnostic from gcc -Wbad-function-cast.
4287 (get_utf8_string, xg_get_file_with_chooser):
4288 Rename locals to avoid shadowing.
4289 (create_dialog): Move locals to avoid shadowing.
4290
4291 * xgselect.c (xg_select): Remove unused var.
4292
4293 * image.c (four_corners_best): Mark locals as initialized.
4294 (gif_load): Initialize transparent_p to zero (Bug#8238).
4295 Mark another local as initialized.
4296 (my_png_error, my_error_exit): Mark with NO_RETURN.
4297
4298 * image.c (clear_image_cache): Now static.
4299 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4300 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4301 (x_edge_detection): Remove unnecessary cast that
4302 gcc -Wbad-function-cast diagnoses.
4303 (gif_load): Fix pointer signedness.
4304 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4305 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4306
4307 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 Improve quality of tests for time stamp overflow.
4310 For example, without this patch (encode-time 0 0 0 1 1
4311 1152921504606846976) returns the obviously-bogus value (-948597
4312 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4313 reports time overflow. See
4314 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4315 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4316 * editfns.c: Include limits.h and intprops.h.
4317 (TIME_T_MIN, TIME_T_MAX): New macros.
4318 (time_overflow): Move earlier, to before first use.
4319 (hi_time, lo_time): New functions, for an accurate test for
4320 out-of-range times.
4321 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4322 (Fget_internal_run_time): Don't assume time_t fits in int.
4323 (make_time): Use list2 instead of Fcons twice.
4324 (Fdecode_time): More accurate test for out-of-range times.
4325 (check_tm_member): New function.
4326 (Fencode_time): Use it, to test for out-of-range times.
4327 (lisp_time_argument): Don't rely on undefined left-shift and
4328 right-shift behavior when checking for time stamp overflow.
4329
4330 * editfns.c (time_overflow): New function, refactoring common code.
4331 (Fformat_time_string, Fdecode_time, Fencode_time):
4332 (Fcurrent_time_string): Use it.
4333
4334 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4335 * dired.c (make_time): Move to ...
4336 * editfns.c (make_time): ... here.
4337 * systime.h: Note the move.
4338
4339 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4340
4341 * fringe.c (update_window_fringes): Remove unused variables.
4342
4343 * unexmacosx.c (copy_data_segment): Also copy __got section.
4344 (Bug#8223)
4345
4346 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4347
4348 * termcap.c [MSDOS]: Include "msdos.h".
4349 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4350 Constify `char *' arguments and their references according to
4351 prototypes in tparam.h.
4352
4353 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4354
4355 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4356 Adapt all references accordingly.
4357
4358 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4359
4360 2011-03-11 Tom Tromey <tromey@redhat.com>
4361
4362 * buffer.c (syms_of_buffer): Remove obsolete comment.
4363
4364 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4365
4366 * termhooks.h (encode_terminal_code): Declare prototype.
4367
4368 * msdos.c (encode_terminal_code): Don't declare prototype.
4369
4370 * term.c (encode_terminal_code): Now external again, used by
4371 w32console.c and msdos.c.
4372
4373 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4374 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4375
4376 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4377
4378 Fix some minor problems found by GCC 4.5.2's static checks.
4379
4380 * fringe.c (update_window_fringes): Mark locals as initialized
4381 (Bug#8227).
4382 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4383
4384 * alloc.c (mark_fringe_data): Move decl from here ...
4385 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4386 to check its interface.
4387 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4388
4389 * fontset.c (free_realized_fontset): Now static.
4390 (Fset_fontset_font): Rename local to avoid shadowing.
4391 (fontset_font): Mark local as initialized.
4392 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4393
4394 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4395
4396 * xselect.c (x_disown_buffer_selections): Remove; not used.
4397 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4398 (x_own_selection, Fx_disown_selection_internal): Rename locals
4399 to avoid shadowing.
4400 (x_handle_dnd_message): Remove local to avoid shadowing.
4401
4402 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4403 so that the caller can use some name other than gcpro1.
4404 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4405 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4406 (Fx_backspace_delete_keys_p):
4407 Use them to avoid shadowing, and rename vars to avoid shadowing.
4408 (x_decode_color, x_set_name, x_window): Now static.
4409 (Fx_create_frame): Add braces to silence GCC warning.
4410 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4411 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4412 Remove unused locals.
4413 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4414 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4415 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4416 macros.
4417
4418 * xterm.h (x_mouse_leave): New decl.
4419
4420 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4421 Remove unused functions.
4422 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4423 (x_calc_absolute_position): Now static.
4424 (XTread_socket): Don't define label "out" unless it's used.
4425 Don't declare local "event" unless it's used.
4426 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4427 unless they are used.
4428 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4429 (x_fatal_error_signal): Remove; not used.
4430 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4431 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4432 (x_error_catcher, x_connection_closed, x_error_handler):
4433 (x_error_quitter, xembed_send_message, x_iconify_frame):
4434 (my_log_handler): Rename locals to avoid shadowing.
4435 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4436 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4437
4438 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4439 Rename or move locals to avoid shadowing.
4440 (tty_defined_color, merge_face_heights): Now static.
4441 (free_realized_faces_for_fontset): Remove; not used.
4442 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4443 does not deduce is never used uninitialized.
4444 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4445 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4446
4447 * terminal.c (store_terminal_param): Now static.
4448
4449 * xmenu.c (menu_highlight_callback): Now static.
4450 (set_frame_menubar): Remove unused local.
4451 (xmenu_show): Rename parameter to avoid shadowing.
4452 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4453 since they might point to immutable storage.
4454 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4455 since it's unused otherwise.
4456
4457 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4458 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4459 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4460 avoids a gcc -Wuninitialized diagnostic.
4461 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4462 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4463 does not deduce are never used uninitialized.
4464
4465 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4466
4467 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4468 * window.c (window_loop, size_window):
4469 (run_window_configuration_change_hook, enlarge_window): Likewise.
4470
4471 * window.c (display_buffer): Now static.
4472 (size_window): Mark variables that gcc -Wuninitialized
4473 does not deduce are never used uninitialized.
4474 * window.h (check_all_windows): New decl, to forestall
4475 gcc -Wmissing-prototypes diagnostic.
4476 * dispextern.h (bidi_dump_cached_states): Likewise.
4477
4478 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4479 shadowing.
4480 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4481 Include <limits.h>.
4482 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4483 and to avoid gcc -Wuninitialized warning.
4484 (load_charset_map): Mark variables that gcc -Wuninitialized
4485 does not deduce are never used uninitialized.
4486 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4487
4488 * coding.c (coding_set_source, coding_set_destination):
4489 Use "else { /* comment */ }" rather than "else /* comment */;"
4490 for clarity, and to avoid gcc -Wempty-body warning.
4491 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4492 a block, when the outer 'i' will do.
4493 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4494 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4495 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4496 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4497 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4498 Rename locals to avoid shadowing.
4499 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4500 * coding.c (emacs_mule_char, encode_invocation_designation):
4501 Now static, since they're not used elsewhere.
4502 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4503 (decode_coding_object, encode_coding_object, detect_coding_system):
4504 (decode_coding_emacs_mule): Mark variables that gcc
4505 -Wuninitialized does not deduce are never used uninitialized.
4506 (detect_coding_iso_2022): Initialize a local variable that might
4507 be used uninitialized. Leave a FIXME because it's not clear that
4508 this initialization is needed. (Bug#8211)
4509 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4510 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4511 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4512 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4513 Remove unused macros.
4514
4515 * category.c (hash_get_category_set): Remove unused local var.
4516 (copy_category_table): Now static, since it's not used elsewhere.
4517 * character.c (string_count_byte8): Likewise.
4518
4519 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4520 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4521
4522 * chartab.c (copy_sub_char_table): Now static, since it's not used
4523 elsewhere.
4524 (sub_char_table_ref_and_range, char_table_ref_and_range):
4525 Rename locals to avoid shadowing.
4526 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4527
4528 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4529 (BIDI_BOB): Remove unused macro.
4530
4531 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4532 deduce are never used uninitialized.
4533 * term.c (encode_terminal_code): Likewise.
4534
4535 * term.c (encode_terminal_code): Now static. Remove unused local.
4536
4537 * tparam.h: New file.
4538 * term.c, tparam.h: Include it.
4539 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4540 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4541 Move these decls to tparam.h, and make them agree with what
4542 is actually in tparam.c. The previous trick of using incompatible
4543 decls in different modules does not conform to the C standard.
4544 All callers of tparam changed to use tparam's actual API.
4545 * tparam.c (tparam1, tparam, tgoto):
4546 Use const pointers where appropriate.
4547
4548 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4549 * cm.h (struct cm): Likewise.
4550 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4551 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4552 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4553 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4554 (turn_on_face, init_tty): Likewise.
4555 * termchar.h (struct tty_display_info): Likewise.
4556
4557 * term.c (term_mouse_position): Rename local to avoid shadowing.
4558
4559 * alloc.c (mark_ttys): Move decl from here ...
4560 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4561
4562 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4563
4564 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4565
4566 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4567
4568 * search.c (compile_pattern_1): Remove argument regp, unused since
4569 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4570 (compile_pattern): Don't pass it.
4571
4572 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4573
4574 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4575 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4576 for ! HAVE_GTK3.
4577 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4578
4579 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4580
4581 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4582 gdk_window_get_screen, gdk_window_get_geometry,
4583 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4584 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4585 (xg_get_pixbuf_from_pixmap): New function.
4586 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4587 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4588 Call xg_get_pixbuf_from_pixmap instead of
4589 gdk_pixbuf_get_from_drawable.
4590 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4591 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4592 (xg_check_special_colors): Use GtkStyleContext and its functions
4593 for HAVE_GTK3.
4594 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4595 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4596 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4597 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4598 Call gtk_widget_get_preferred_size.
4599 (xg_frame_resized): gdk_window_get_geometry only takes 5
4600 parameters.
4601 (xg_win_to_widget, xg_event_is_for_menubar):
4602 Call gdk_x11_window_lookup_for_display.
4603 (xg_set_widget_bg): New function.
4604 (delete_cb): New function.
4605 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4606 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4607 (xg_set_background_color): Call xg_set_widget_bg.
4608 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4609 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4610 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4611 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4612 if ! HAVE_GTK3.
4613 (update_frame_tool_bar): Call gtk_widget_hide.
4614 (xg_initialize): Use GDK_KEY_g.
4615
4616 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4617 if ! HAVE_GTK3
4618 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4619
4620 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4621 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4622 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4623
4624 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4625
4626 * w32xfns.c (select_palette): Check success of RealizePalette against
4627 GDI_ERROR, not zero.
4628
4629 See ChangeLog.11 for earlier changes.
4630
4631 ;; Local Variables:
4632 ;; coding: utf-8
4633 ;; End:
4634
4635 Copyright (C) 2011 Free Software Foundation, Inc.
4636
4637 This file is part of GNU Emacs.
4638
4639 GNU Emacs is free software: you can redistribute it and/or modify
4640 it under the terms of the GNU General Public License as published by
4641 the Free Software Foundation, either version 3 of the License, or
4642 (at your option) any later version.
4643
4644 GNU Emacs is distributed in the hope that it will be useful,
4645 but WITHOUT ANY WARRANTY; without even the implied warranty of
4646 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4647 GNU General Public License for more details.
4648
4649 You should have received a copy of the GNU General Public License
4650 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.