1 2011-10-27 Paul Eggert <eggert@cs.ucla.edu>
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
178 (Fread_coding_system, Fdetect_coding_region)
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
182 (consume_chars): Rewrite to not calculate an address outside buffer.
183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
184 Don't access memory outside of the args array.
185 (Fdefine_coding_system_internal): Check for charset-id overflow.
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
271 (Fformat_time_string): Remove now-unnecessary check.
272 lisp_time_argument checks for out-of-range usec now.
273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
276 (init_cmdargs, Fdump_emacs):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
279 the bottom (typically) 32 bits of the fixnum.
280 * eval.c (specpdl_size, call_debugger):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (when_entered_debugger, Fbacktrace_debug):
283 Don't assume fixnum can fit in int.
284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
285 the object just before a buffer; this is not portable.
286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
287 (grow_specpdl, unbind_to):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
290 (grow_specpdl): Simplify allocation by using xpalloc.
291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (Fcopy_file, non_regular_nbytes, read_non_regular)
299 (Finsert_file_contents):
300 Use int, not EMACS_INT, where int is wide enough.
301 (READ_BUF_SIZE): Verify that it fits in int.
302 (Finsert_file_contents): Check that counts are in proper range,
303 rather than assuming fixnums fit into ptrdiff_t etc.
304 Don't assume fixnums fit into int.
305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
308 (string_char_to_byte, string_byte_to_char)
309 (string_make_multibyte, string_to_multibyte)
310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
312 (substring_both, Fdelete, internal_equal, Ffillarray)
313 (Fclear_string, mapcar1)
314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
316 (larger_vector, make_hash_table, maybe_resize_hash_table)
317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
318 (Fmaphash, secure_hash):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (concat): Check for string index and length overflow.
321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (larger_vector): New API (vec, incr_min, size_max) replaces old
325 one (vec, new_size, init). This catches size overflow.
326 INIT was removed because it was always Qnil.
328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
329 the upper bound on a hash table index size.
330 (make_hash_table, maybe_resize_hash_table): Use it.
331 (secure_hash): Computer start_byte and end_byte only after
332 they're known to be in ptrdiff_t range.
333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
334 (Ffont_get_glyphs, Ffont_at):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
337 (Flist_fonts, Fopen_font):
338 Don't assume fixnum can fit in int.
339 (check_gstring): Don't assume index can fit in int.
340 (font_match_p): Check that fixnum is a character, not a nonnegative
341 fixnum, since the later code needs to stuff it into an int.
342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
344 conversion overflow issues.
345 (Fopen_font): Check for integer out of range.
346 (Ffont_get_glyphs): Don't assume index can fit in int.
347 * font.h: Adjust decls to match defn changes elsewhere.
348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
351 printmax_t, where ptrdiff_t is wide enough.
352 (Finternal_char_font):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
356 (Fset_frame_position, x_set_frame_parameters)
357 (x_set_line_spacing, x_set_border_width)
358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
359 Check that fixnums are in proper range for system types.
360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
363 Use SAFE_ALLOCA_LISP, not alloca.
364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
365 intptr_t is wide enough.
366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
369 Check for fixnum out of range.
370 * ftfont.c (ftfont_list): Don't assume index fits in int.
371 Check that fixnums are in proper range for system types.
372 (ftfont_shape_by_flt):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
377 Check that fixnums are in proper range for system types.
378 * gnutls.h: Adjust decls to match defn changes elsewhere.
379 * gtkutil.c (xg_dialog_run):
380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
381 (update_frame_tool_bar):
382 Check that fixnums are in proper range for system types.
383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
384 (lookup_image): Check that fixnums are in range for system types.
385 * indent.c (last_known_column, last_known_column_point):
386 (current_column_bol_cache):
387 (skip_invisible, current_column, check_display_width):
388 (check_display_width, scan_for_column, current_column_1)
389 (Findent_to, Fcurrent_indentation, position_indentation)
390 (indented_beyond_p, Fmove_to_column, compute_motion):
391 (Fcompute_motion, Fvertical_motion):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (last_known_column_modified): Use EMACS_INT, not int.
394 (check_display_width):
396 Check that fixnums and floats are in proper range for system types.
397 (compute_motion): Don't assume index or fixnum fits in int.
398 (compute_motion, Fcompute_motion):
399 Use int, not EMACS_INT, when it is wide enough.
400 (vmotion): Omit local var start_hpos that is always 0; that way
401 we don't need to worry about overflow in expressions involving it.
402 * indent.h: Adjust decls to match defn changes elsewhere.
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 Use int, not EMACS_INT, where int is wide enough.
406 Remove unused members ovstring_chars_done and tab_offset;
408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
411 (make_gap, copy_text, insert, insert_and_inherit)
412 (insert_before_markers, insert_before_markers_and_inherit)
413 (insert_1, count_combining_before, count_combining_after)
414 (insert_1_both, insert_from_string)
415 (insert_from_string_before_markers, insert_from_string_1)
416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
417 (adjust_after_replace, adjust_after_insert, replace_range)
418 (replace_range_2, del_range, del_range_1, del_range_byte)
419 (del_range_both, del_range_2, modify_region)
420 (prepare_to_modify_buffer, signal_before_change)
421 (signal_after_change, Fcombine_after_change_execute):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
424 (balance_an_interval, split_interval_right, split_interval_left)
425 (find_interval, next_interval, update_interval)
426 (adjust_intervals_for_insertion, delete_node, delete_interval)
427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
428 (static_offset_intervals, offset_intervals)
429 (merge_interval_right, merge_interval_left, make_new_interval)
430 (graft_intervals_into_buffer, temp_set_point_both)
431 (temp_set_point, set_point, adjust_for_invis_intang)
432 (set_point_both, move_if_not_intangible, get_property_and_range)
433 (get_local_map, copy_intervals, copy_intervals_to_string)
434 (compare_string_intervals, set_intervals_multibyte_1):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * intervals.h: Adjust decls to match defn changes elsewhere.
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 * keyboard.c (this_command_key_count, this_single_command_key_start)
440 (before_command_key_count, before_command_echo_length, echo_now)
441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (last_non_minibuf_size, last_point_position, echo_truncate)
447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
450 (stuff_buffered_input):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (last_auto_save, command_loop_1, read_char):
453 Use EMACS_INT, not int, to avoid integer overflow.
454 (record_char): Avoid overflow in total_keys computation.
455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
456 * keyboard.h: Adjust decls to match defn changes elsewhere.
457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
458 (Fkey_description, Fdescribe_vector, Flookup_key):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (click_position): New function, to check that positions are in range.
461 (Fcurrent_active_maps):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faccessible_keymaps, Fkey_description):
465 (preferred_sequence_p):
466 Don't assume fixnum can fit into int.
467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
468 Check for integer overflow in size calculations.
469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
470 avoid mishandling large integers.
471 * lisp.h: Adjust decls to match defn changes elsewhere.
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
474 (struct Lisp_Marker):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
481 Assume the arg has valid form, since it always does.
482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
483 unsigned integer system type.
484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
488 (duration_to_sec_usec): New decl.
489 * lread.c (read_from_string_index, read_from_string_index_byte)
490 (read_from_string_limit, readchar, unreadchar, openp)
491 (read_internal_start, read1, oblookup):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fload, readevalloop, Feval_buffer, Feval_region):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (openp): Check for out-of-range argument to 'access'.
496 (read1): Use int, not EMACS_INT, where int is wide enough.
497 Don't assume fixnum fits into int.
498 Fix off-by-one error that can read outside a buffer.
499 (read_filtered_event): Use duration_to_sec_usec
500 to do proper overflow checking on durations.
501 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
503 (Fexecute_kbd_macro):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
506 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
507 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
508 (set_marker_both, set_marker_restricted_both, marker_position)
509 (marker_byte_position, Fbuffer_has_markers_at):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
512 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
513 It now merely ensures that the menu is large enough, without
514 necessarily growing it, as this avoids some integer overflow issues.
516 (keymap_panes, parse_single_submenu, Fx_popup_menu):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
519 Use SAFE_ALLOCA_LISP, not alloca.
520 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
521 to EMACS_INT. Check that fixnums are in proper range for system types.
522 * minibuf.c (minibuf_prompt_width, string_to_object)
523 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
524 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 (get_minibuffer, read_minibuf_unwind):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
529 this simplifies overflow checking. All callers changed.
530 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
533 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
534 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
535 Check that fixnums are in proper range for system types.
536 (Fx_create_frame, Fx_show_tip):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 * nsfont.m (ns_findfonts, nsfont_list_family):
539 Don't assume fixnum fits in long.
540 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
544 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
546 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
547 (PRINTDECLARE, PRINTPREPARE):
548 (strout, print_string):
549 (print, print_preprocess, print_check_string_charset_prop)
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
553 (temp_output_buffer_setup, Fprin1_to_string, print_object):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
556 (printchar, strout): Use xpalloc to catch size calculation overflow.
557 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
558 (print_error_message): Use SAFE_ALLOCA, not alloca.
559 (print_object): Use int, not EMACS_INT, where int is wide enough.
560 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
561 (Fset_process_window_size, Fformat_network_address)
562 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
564 Check that fixnums are in proper range for system types.
565 (Fsignal_process): Simplify by avoiding a goto.
566 Check for process-ids out of pid_t range rather than relying on
568 (Fformat_network_address, read_process_output, send_process)
569 (Fprocess_send_region, status_notify):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
572 (wait_reading_process_output, read_process_output, exec_sentinel):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
575 (Faccept_process_output): Use duration_to_sec_usec to do proper
576 overflow checking on durations.
577 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
578 Don't assume pid_t fits in int.
579 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
580 configured --with-wide-int.
581 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
582 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
583 * search.c (looking_at_1, string_match_1):
584 (fast_string_match, fast_c_string_match_ignore_case)
585 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
586 (scan_newline, find_before_next_newline, search_command)
587 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
588 (set_search_regs, wordify):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (string_match_1, search_buffer, set_search_regs):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (wordify): Check for overflow in size calculation.
596 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
597 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
598 Check that fixnums are in proper range for system types.
599 * sound.c (struct sound_device)
600 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (Fplay_sound_internal):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 * syntax.c (struct lisp_parse_state, find_start_modiff)
605 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
606 (Fparse_partial_sexp):
607 Don't assume fixnums can fit in int.
608 (struct lisp_parse_state, find_start_pos, find_start_value)
609 (find_start_value_byte, find_start_begv)
610 (update_syntax_table, char_quoted, dec_bytepos)
611 (find_defun_start, prev_char_comend_first, back_comment):
612 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
613 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Finternal_describe_syntax_value): Check that match_lisp is a
616 character, not an integer, since the code stuffs it into int.
617 (scan_words, scan_sexps_forward):
618 Check that fixnums are in proper range for system types.
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 (scan_sexps_forward):
622 Use CHARACTERP, not INTEGERP, since the value must fit into int.
623 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
624 * syntax.h: Adjust decls to match defn changes elsewhere.
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 * sysdep.c (wait_for_termination_1, wait_for_termination)
628 (interruptible_wait_for_termination, mkdir):
629 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
630 (emacs_read, emacs_write):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
633 and double all fit in int.
634 * term.c (set_tty_color_mode):
635 Check that fixnums are in proper range for system types.
636 * termhooks.h (struct input_event):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 * textprop.c (validate_interval_range, interval_of)
639 (Fadd_text_properties, set_text_properties_1)
640 (Fremove_text_properties, Fremove_list_of_text_properties)
641 (Ftext_property_any, Ftext_property_not_all)
642 (copy_text_properties, text_property_list, extend_property_ranges)
643 (verify_interval_modification):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 (Fnext_single_char_property_change)
646 (Fprevious_single_char_property_change):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 (copy_text_properties):
649 Check for integer overflow in index calculation.
650 * undo.c (last_boundary_position, record_point, record_insert)
651 (record_delete, record_marker_adjustment, record_change)
652 (record_property_change):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
657 (Fx_hide_tip, Fx_file_dialog):
658 * w32menu.c (set_frame_menubar):
659 Use ptrdiff_t, not int, for consistency with rest of code.
660 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
661 (select_window, Fdelete_other_windows_internal)
662 (window_scroll_pixel_based, window_scroll_line_based)
663 (Frecenter, Fset_window_configuration):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (Fset_window_hscroll, run_window_configuration_change_hook)
666 (set_window_buffer, temp_output_buffer_show, scroll_command)
667 (Fscroll_other_window, Frecenter):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
670 Don't assume fixnum fits in int.
671 (Fset_window_scroll_bars):
672 Check that fixnums are in proper range for system types.
673 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
674 (string_pos, c_string_pos, number_of_chars, init_iterator)
675 (in_ellipses_for_invisible_text_p, init_from_display_pos)
676 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
677 (compute_display_string_end, handle_face_prop)
678 (face_before_or_after_it_pos, handle_invisible_prop)
679 (handle_display_prop, handle_display_spec, handle_single_display_spec)
680 (display_prop_intangible_p, string_buffer_position_lim)
681 (string_buffer_position, handle_composition_prop, load_overlay_strings)
682 (get_overlay_strings_1, get_overlay_strings)
683 (iterate_out_of_display_property, forward_to_next_line_start)
684 (back_to_previous_visible_line_start, reseat, reseat_to_string)
685 (get_next_display_element, set_iterator_to_next)
686 (get_visually_first_element, compute_stop_pos_backwards)
687 (handle_stop_backwards, next_element_from_buffer)
688 (move_it_in_display_line_to, move_it_in_display_line)
689 (move_it_to, move_it_vertically_backward, move_it_by_lines)
690 (add_to_log, message_dolog, message_log_check_duplicate)
691 (message2, message2_nolog, message3, message3_nolog
692 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
693 (current_message_1, truncate_echo_area, truncate_message_1)
694 (set_message, set_message_1, store_mode_line_noprop)
695 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
696 (text_outside_line_unchanged_p, check_point_in_composition)
697 (reconsider_clip_changes)
698 (redisplay_internal, set_cursor_from_row, try_scrolling)
699 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
700 (redisplay_window, find_last_unchanged_at_beg_row)
701 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
702 (trailing_whitespace_p, find_row_edges, display_line)
703 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
704 (display_mode_element, store_mode_line_string)
705 (pint2str, pint2hrstr, decode_mode_spec)
706 (display_count_lines, display_string, draw_glyphs)
707 (x_produce_glyphs, x_insert_glyphs)
708 (rows_from_pos_range, mouse_face_from_buffer_pos)
709 (fast_find_string_pos, mouse_face_from_string_pos)
710 (note_mode_line_or_margin_highlight, note_mouse_highlight):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (safe_call, init_from_display_pos, handle_fontified_prop)
713 (handle_single_display_spec, load_overlay_strings)
714 (with_echo_area_buffer, setup_echo_area_for_printing)
715 (display_echo_area, echo_area_display)
716 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
717 (update_tool_bar, hscroll_window_tree, redisplay_internal)
718 (redisplay_window, dump_glyph_row, display_mode_line)
719 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
720 (handle_display_spec, display_prop_string_p):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (handle_single_display_spec, build_desired_tool_bar_string)
723 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
724 (get_specified_cursor_type):
725 Check that fixnums are in proper range for system types.
726 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
728 Don't assume fixnums fit in int.
729 (compare_overlay_entries):
730 Avoid mishandling comparisons due to subtraction overflow.
731 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
732 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
733 (handle_tool_bar_click):
734 Use int, not unsigned, since we prefer signed and the signedness
736 (get_next_display_element, next_element_from_display_vector):
737 Use int, not EMACS_INT, when int is wide enough.
738 (start_hourglass): Use duration_to_sec_usec to do proper
739 overflow checking on durations.
740 * xfaces.c (Fbitmap_spec_p):
741 Check that fixnums are in proper range for system types.
742 (compare_fonts_by_sort_order):
743 Avoid mishandling comparisons due to subtraction overflow.
744 (Fx_family_fonts, realize_basic_faces):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 Don't assume fixnum fits in int.
748 Use SAFE_ALLOCA_LISP, not alloca.
749 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
750 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
751 (face_at_buffer_position, face_for_overlay_string)
752 (face_at_string_position):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
755 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
757 Check that fixnums are in proper range for system types.
758 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
759 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fx_change_window_property): Don't assume fixnums fit in int.
762 * xfont.c (xfont_chars_supported):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
765 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 * xml.c (parse_region):
768 * xrdb.c (magic_file_p):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
771 (x_get_local_selection, x_reply_selection_request)
772 (x_handle_selection_request, wait_for_property_change):
773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
774 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
775 short is wide enough.
776 (x_send_client_event): Don't assume fixnum fits in int.
777 * xterm.c (x_x_to_emacs_modifiers):
778 Don't assume EMACS_INT overflows nicely into int.
779 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
781 (handle_one_xevent): NATNUMP can eval its arg twice.
782 (x_connection_closed):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 * xterm.h: Adjust decls to match defn changes elsewhere.
785 (struct scroll_bar): Use struct vectorlike_header
786 rather than rolling our own approximation.
787 (SCROLL_BAR_VEC_SIZE): Remove; not used.
789 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
791 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
792 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
793 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
794 (Fmove_to_window_line): Doc fix.
796 2011-10-27 Chong Yidong <cyd@gnu.org>
798 * process.c (make_process): Set gnutls_state to NULL.
800 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
801 non-NULL, regardless of GNUTLS_INITSTAGE.
802 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
803 an error. Set process slots as soon as we allocate them.
805 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
807 2011-10-27 Chong Yidong <cyd@gnu.org>
809 * gnutls.c (emacs_gnutls_deinit): New function. Deallocate
810 credentials structures as well as calling gnutls_deinit.
811 (Fgnutls_deinit, Fgnutls_boot): Use it.
813 * process.c (make_process): Initialize GnuTLS credentials to NULL.
814 (deactivate_process): Call emacs_gnutls_deinit.
816 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
818 * image.c (x_create_x_image_and_pixmap):
819 * w32.c (sys_rename, w32_delayed_load):
820 * w32font.c (fill_in_logfont):
821 * w32reg.c (x_get_string_resource): Silence compiler warnings.
823 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
825 * w32fns.c (w32_default_color_map): New function,
826 extracted from Fw32_default_color_map.
827 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
829 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
831 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
833 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
835 * keyboard.c (test_undefined): New function (bug#9751).
836 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
838 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
840 * sysdep.c (init_sys_modes): Fix the check for the controlling
843 2011-10-20 Eli Zaretskii <eliz@gnu.org>
845 * dispextern.h (struct bidi_it): New member next_en_type.
847 * bidi.c (bidi_line_init): Initialize the next_en_type member.
848 (bidi_resolve_explicit_1): When next_en_pos is valid for the
849 current character, check also for next_en_type being WEAK_EN.
850 (bidi_resolve_weak): Don't enter the expensive loop if the current
851 position is before next_en_pos. Record the bidi type of the first
852 non-ET, non-BN character we find, in addition to its position.
853 (bidi_level_of_next_char): Invalidate next_en_type when
854 next_en_pos is over-stepped.
856 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
858 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
859 * editfns.c: Rewrite current-time-zone so that it invokes
860 the equivalent of (format-time-string "%Z") to get the time zone name.
861 This fixes a bug when the time zone name contains characters that
862 need converting from the system time locale to Emacs internal format.
863 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
864 that patch fixed format-time-string to do the conversion, but
865 I forgot to fix current-time-zone.
866 (format_time_string): New function, containing most of
867 what Fformat_time_string used to contain.
868 (Fformat_time_string): Rewrite in terms of format_time_string.
869 This doesn't change this function's behavior.
870 (current-time-zone): Rewrite to use format_time_string.
871 This fixes the bug reported by Michael Schierl in
872 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
873 Jason Rumney's 2007-06-07 change worked around this bug, but
875 * systime.h (tzname, timezone): Remove no-longer-used declarations.
877 2011-10-19 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (start_display): If the character at POS is displayed
880 via a display vector, reset IT->current.dpvec_index to zero.
881 (try_window_reusing_current_matrix): If a line ends in a display
882 vector or the next line starts in a display vector, continue
883 redrawing the window even though the character position of
884 start_row was reached.
887 2011-10-18 Chong Yidong <cyd@gnu.org>
889 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
890 with nobreak-char-display too.
892 2011-10-18 Eli Zaretskii <eliz@gnu.org>
894 Fix part 3 of bug#9771.
895 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
896 (bidi_resolve_neutral): Don't enter the expensive loop looking for
897 non-neutral characters if the current character is a paragraph
898 separator (a.k.a. Newline). This avoids running the same
899 expensive loop twice, once when we consume the preceding newline
900 and the other time when the line actually needs to be displayed.
901 Avoid the loop when we see neutrals on the base embedding level
902 following a character whose directionality is the same as the
903 paragraph's. This avoids running the expensive loop when a line
904 ends in a long sequence of neutrals, like control characters.
905 Add assertion against STRONG_AL type. Slightly rearrange code
906 that determines the type of a neutral given the first non-neutral
908 (bidi_level_of_next_char): Set next_en_pos to zero when
909 invalidating its info.
911 2011-10-17 Eli Zaretskii <eliz@gnu.org>
913 * xdisp.c (push_display_prop): Determine whether to record string
914 or buffer position by IT->string, not by IT->method. Allow
915 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
916 (move_it_vertically_backward): Don't look for character position
917 immediately after the newline when in a continuation line.
920 2011-10-15 Martin Rudalics <rudalics@gmx.at>
922 * window.c (coordinates_in_window): Rewrite and delabelize
923 vertical border check. (Bug#5357) (Bug#9618)
925 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
927 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
928 errors in XSetWindowBorder (bug#9310).
930 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
932 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
933 avoid crash when xmalloc overrun checking is enabled.
935 2011-10-13 Eli Zaretskii <eliz@gnu.org>
937 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
938 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
939 cursor motion with <left> and <right> arrow keys.
941 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
942 some callers set that themselves.
944 2011-10-12 Eli Zaretskii <eliz@gnu.org>
946 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
947 display string and the previous row comes from the same string and
948 is empty. (Bug#9739) (Bug#9738)
950 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
952 * doc.c (get_doc_string): Encode file name (bug#9735).
954 2011-10-12 Eli Zaretskii <eliz@gnu.org>
956 * bidi.c (bidi_level_of_next_char):
957 * xdisp.c (get_visually_first_element): Remove old incorrect
958 comments regarding the Unicode Line Separator character.
960 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
962 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
964 * alloc.c (Fgc_status): Do not access beyond zombies array
965 boundary if nzombies > MAX_ZOMBIES.
966 * alloc.c (dump_zombies): Add missing format specifier.
968 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
970 * xdisp.c (set_cursor_from_row): Simplify conditionals,
971 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
973 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
974 Some packages use them to denote characters with modifiers.
976 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
978 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
979 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
980 matching a pp-number. Rename parameter var to var1.
982 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
984 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
986 2011-10-08 Glenn Morris <rgm@gnu.org>
988 * callint.c (Fcall_interactively): Give a more explicit error for the
989 'c' case with a non-character input. (Bug#8479)
991 2011-10-08 Eli Zaretskii <eliz@gnu.org>
993 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
995 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
996 lines that are hscrolled on the left.
998 * dispnew.c (buffer_posn_from_coords): Account for a possible
999 presence of header-line. (Bug#4426)
1001 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1003 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1004 Don't advertise functionality which we discourage or doesn't work.
1006 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1008 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1009 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1010 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1011 this makes Emacs dump core during garbage collection on rare
1012 occasions. sizeof is obviously inferior to offsetof here, so
1013 stick with offsetof.
1014 (GC_POINTER_ALIGNMENT): New macro.
1015 (mark_memory): Omit 3rd (offset) arg; caller changed.
1016 Don't assume EMACS_INT alignment is the same as pointer alignment.
1018 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1020 * keyboard.c (read_key_sequence_remapped): New var.
1021 (read_key_sequence): Compute remapping in the right buffer.
1022 (command_loop_1): Use read_key_sequence's remapping directly.
1024 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1026 * dired.c (file_name_completion): Don't expand file name.
1027 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1028 before checking file name handler.
1030 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1031 they've been requested explicitly (bug#9591).
1033 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1035 * keymap.c (Fsingle_key_description): Use make_specified_string
1036 instead of build_string to build string from push_key_description.
1039 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1041 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1042 This fixes a Y2038 bug on 64-bit hosts.
1043 * buffer.c (reset_buffer):
1044 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1045 (Fclear_buffer_auto_save_failure):
1046 Use 0, not -1, to represent an unset failure time, since time_t
1047 might not be signed.
1049 Remove dependency on glibc malloc internals.
1050 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1051 Move back here from lisp.h, but with their new implementations.
1052 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1053 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1054 * charset.c (charset_table_init): New static var.
1055 (syms_of_charset): Use it instead of xmalloc. This removes a
1056 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1057 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1058 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1059 Move back to alloc.c.
1060 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1061 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1063 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1065 * nsterm.m (windowDidResize): Call x_set_window_size only when
1066 ns_in_resize is true. Otherwise set pixelwidth/height and
1067 call change_frame_size (Bug#9628).
1069 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1071 Port --enable-checking=all to Fedora 14 x86-64.
1072 * charset.c (syms_of_charset): Also account for glibc malloc's
1073 internal overhead when calculating the initial malloc maximum.
1075 Port --enable-checking=all to Fedora 14 x86.
1076 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1078 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1079 (overrun_check_realloc, overrun_check_free):
1080 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1081 That way, xmalloc returns a properly-aligned pointer even if
1082 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1083 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1084 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1085 into account when calculating the initial malloc maximum.
1086 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1087 Move here from alloc.c, so that charset.c can use it too.
1088 Properly align; the old code wasn't right for common 32-bit hosts
1089 when configured with --enable-checking=all.
1090 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1091 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1093 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1095 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1098 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1100 * xdisp.c (compute_display_string_end): If there's no display
1101 string at CHARPOS, return -1.
1103 * bidi.c (bidi_fetch_char): When compute_display_string_end
1104 returns a negative value, treat the character as a normal
1105 character not covered by a display string. (Bug#9624)
1107 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1109 * lread.c (Fread_from_string): Fix typo in docstring.
1111 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1113 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1114 newline, reseat the iterator instead of bidi-iterating there one
1115 character at a time. (Bug#9610)
1116 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1117 TO_CHARPOS if the bidi iterator is at base embedding level.
1119 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1121 * lread.c (readevalloop): Use correct code for NBSP.
1122 (read1): Likewise. (Bug#9608)
1124 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1126 * dbusbind.c (Fdbus_register_signal): When service is not
1127 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1129 2011-09-25 Glenn Morris <rgm@gnu.org>
1131 * buffer.c (truncate-lines): Doc fix.
1133 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1135 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1136 (Fset_window_next_buffers): Doc fix.
1138 2011-09-24 Glenn Morris <rgm@gnu.org>
1140 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1142 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1144 Fix minor problems found by static checking.
1145 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1146 * indent.c (Fvertical_motion): Fix == vs = typo.
1148 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1150 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1151 Default value is now t. Doc fix.
1153 * indent.c (Fvertical_motion): Compute and apply the overshoot
1154 logic when moving up, not only when moving down. Fix the
1155 confusing name and values of the it_overshoot_expected variable;
1156 logic changes accordingly. (Bug#9254) (Bug#9549)
1158 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1159 CHARPOS is covered by a display string which includes newlines.
1160 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1161 is covered by a display string with embedded newlines.
1163 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1165 * dbusbind.c (Fdbus_register_signal): Add match rule to
1166 Vdbus_registered_objects_table. (Bug#9581)
1167 (Fdbus_register_method, Vdbus_registered_objects_table):
1170 2011-09-24 Jim Meyering <meyering@redhat.com>
1172 do not ignore write error for any output size
1173 The previous change was incomplete.
1174 While it makes emacs --batch detect the vast majority of stdout
1175 write failures, errors were still ignored whenever the output size is
1176 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1177 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1178 && echo FAIL: ignored write error
1179 FAIL: ignored write error
1180 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1181 && echo FAIL: ignored write error
1182 FAIL: ignored write error
1183 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1185 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1187 * emacs.c (Fkill_emacs): In noninteractive mode exit
1188 non-successfully if a write error occurred on stdout. (Bug#9574)
1190 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1192 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1195 * dispextern.h (struct it): Update the comment documenting what
1198 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1200 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1201 a display string, extend search for cursor position to end of row.
1202 (find_row_edges): If the row ends in a newline from a display
1203 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1204 Handle the case of a display string with multiple newlines.
1205 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1206 non-empty line. Fixes confusing cursor motion with arrow keys at
1207 the beginning of a line that starts with whitespace.
1209 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1211 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1214 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1216 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1219 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1221 * xdisp.c (display_line): Record maximum and minimum buffer
1222 positions even if no glyphs were produced (e.g., by a zero-width
1223 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1224 buffer positions that will be removed from the glyph row because
1226 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1227 column is beyond frame width: don't subtract 1 "pixel" when
1228 computing width of the stretch.
1229 (reseat_at_next_visible_line_start): Undo the change made on
1230 2011-09-17 that saved paragraph information and restored it after
1231 the call to `reseat'. (Bug#9545)
1233 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1235 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1236 and turn window cursor on if cleared (Bug#9415).
1238 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1240 * search.c (boyer_moore): Take unibyte characters from pattern
1241 literally. (Bug#9458)
1243 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1245 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1247 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1249 Fix minor problem found by static checking.
1250 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1251 initialized, to pacify gcc -Wuninitialized.
1253 * fileio.c: Report proper errno when syscall falls.
1254 (Finsert_file_contents): Save and restore errno,
1255 so that report_file_error outputs the correct diagnostic.
1256 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1258 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1260 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1262 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1265 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1267 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1269 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1270 about the current paragraph and restore it after the call to reseat.
1272 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1273 (bidi_find_paragraph_start): Search back for paragraph beginning
1274 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1275 (bidi_move_to_visually_next): Only trigger paragraph-related
1276 computations when the last character is a newline or at EOB, not
1277 just any NEUTRAL_B. (Bug#9470)
1279 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1280 truncated lines if point is covered by a display string. (Bug#9524)
1282 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1284 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1285 (cons_to_x_long): New function.
1286 (lisp_data_to_selection_data): Use it. Correct the test for
1287 short-versus-long data; it was negated. Break out of vector
1288 loop, for efficiency, when a long datum is discovered.
1290 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1292 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1294 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1296 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1297 GCC PR/17406) by declaring this function with external scope.
1299 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1301 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1302 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1304 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1306 * editfns.c (Fformat): Correctly handle text properties on "%%".
1308 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1310 * xterm.c (x_draw_composite_glyph_string_foreground):
1311 * w32term.c (x_draw_composite_glyph_string_foreground):
1312 * term.c (encode_terminal_code):
1313 * composite.c (composition_update_it, get_composition_id):
1314 * xdisp.c (get_next_display_element)
1315 (fill_composite_glyph_string): Add comments about special meaning
1316 of TAB characters in a composition.
1318 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1320 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1321 This occurs when processing a multibyte format.
1322 Problem reported by Wolfgang Jenker.
1324 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1326 * xdisp.c (try_cursor_movement): Only check for exact match if
1327 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1329 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1331 Remove unused external symbols.
1332 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1333 * xdisp.c (calc_pixel_width_or_height): Now static.
1334 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1335 * indent.c (check_display_width):
1336 * w32term.c: Fix comment to match code.
1337 * xterm.c, xterm.h (x_catching_errors): Remove.
1339 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1341 * xselect.c: Use signed conversions more consistently (Bug#9498).
1342 (selection_data_to_lisp_data): Assume incoming selection data are
1343 signed integers, not unsigned. This is to be consistent with
1344 outgoing selection data, which was modified to use signed integers
1345 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1346 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1347 expects long, not unsigned long.
1349 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1351 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1352 computation of loop end. Reported by Johan Bockgård
1355 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1357 * frame.c (Fother_visible_frames_p): Function deleted.
1359 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1361 * indent.c (compute_motion): Process display vector front to back
1362 rather than the other way around. (Bug#2496)
1364 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1366 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1368 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1370 * minibuf.c (Fread_from_minibuffer): Doc fix.
1372 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1374 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1375 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1377 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1379 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1380 value for non-existent files.
1382 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1384 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1385 set its "size" to -1. This will set the modtime_size field of
1386 the corresponding buffer to -1, which is what
1387 verify-visited-file-modtime expects for files that do not exist.
1390 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1392 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1394 * lisp.h: ... from here. push_key_description is no longer
1395 defined in keyboard.c, so its declaration should not be in
1396 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1397 logically belongs with push_key_description.
1399 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1401 * buffer.h: Include <sys/types.h> instead of <time.h>.
1402 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1403 Problem reported by Herbert J. Skuhra.
1405 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1407 * xml.c (parse_region): Make the parsing work for
1408 non-comment-starting XML files again (bug#9144).
1410 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1412 * image.c (gif_load): Fix calculation of bottom and right corner.
1415 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1417 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1418 redisplay in small windows.
1420 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1422 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1424 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1426 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1427 Operate on live windows only.
1429 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1431 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1433 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1435 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1436 only under bidi iteration.
1438 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1440 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1442 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1444 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1445 Without this fix, the command to link temacs failed due to an
1446 undefined symbol __builtin_isnan. This is because
1447 /usr/include/iso/math_c99.h #defines isnan(x) to
1448 __builtin_isnan(x), but the bundled gcc, which identifies itself
1449 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1451 * floatfns.c (isnan): #undef, and then #define to a clone of
1453 (Fisnan): Always define, since it's always available now.
1454 (syms_of_floatfns): Always define isnan at the Lisp level.
1456 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1458 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1460 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1462 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1463 The previous code assumed that file offsets (off_t values) fit in
1464 EMACS_INT variables, which is not true on typical 32-bit hosts.
1465 The code messed up by falsely reporting buffer overflow in cases
1466 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1467 when "big" contains more than 2**29 bytes, even though this
1468 inserts just one byte and does not overflow the buffer.
1469 (Finsert_file_contents): Store file offsets as off_t
1470 values, not as EMACS_INT values. Check for overflow when
1471 converting between EMACS_INT and off_t. When checking for
1472 buffer overflow or for overlap, take the offsets into account.
1473 Don't use EMACS_INT for small values where int suffices.
1474 When checking for overlap, fix a typo: ZV was used where
1475 ZV_BYTE was intended.
1476 (Fwrite_region): Don't assume off_t fits into 'long'.
1477 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1479 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1481 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1483 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1485 sprintf-related integer and memory overflow issues (Bug#9412).
1487 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1488 (esprintf, exprintf, evxprintf): New functions.
1489 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1490 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1491 (modify_event_symbol): Do not assume that the length of
1492 name_alist_or_stem is safe to alloca and fits in int.
1493 (Fexecute_extended_command): Likewise for function name and binding.
1494 (Frecursion_depth): Wrap around reliably on integer overflow.
1495 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1496 since some callers pass EMACS_INT values.
1497 (Fsingle_key_description): Don't crash if symbol name contains more
1498 than MAX_ALLOCA bytes.
1499 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1500 (get_minibuffer): Arg is now EMACS_INT, not int.
1501 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1502 (esprintf, exprintf, evxprintf): New decls.
1503 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1505 * dbusbind.c (signature_cat): New function.
1506 (xd_signature, Fdbus_register_signal):
1507 Do not overrun buffer; instead, report string overflow.
1509 * dispnew.c (add_window_display_history): Don't overrun buffer.
1510 Truncate instead; this is OK since it's just a log.
1512 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1513 even if the time zone offset is outlandishly large.
1514 Don't mishandle offset == INT_MIN.
1516 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1517 when creating daemon; the previous buffer-overflow check was incorrect.
1519 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1520 which has the guts of the old verror function.
1522 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1523 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1525 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1526 (font_unparse_xlfd): Don't blindly alloca long strings.
1527 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1528 fits in int, when using sprintf. Use single snprintf to count
1529 length of string rather than counting it via multiple sprintfs;
1530 that's simpler and more reliable.
1531 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1532 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1533 sprintf, in case result does not fit in int.
1535 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1536 (fontset_from_font): Print it.
1538 * frame.c (tty_frame_count): Now printmax_t, not int.
1539 (make_terminal_frame, set_term_frame_name): Print it.
1540 (x_report_frame_params): In X, window IDs are unsigned long,
1541 not signed long, so print them as unsigned.
1542 (validate_x_resource_name): Check for implausibly long names,
1543 and don't assume name length fits in 'int'.
1544 (x_get_resource_string): Don't blindly alloca invocation name;
1545 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1548 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1549 (xg_check_special_colors, xg_set_geometry):
1550 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1552 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1553 Use esprintf, not sprintf, in case result does not fit in int.
1555 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1556 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1557 it as a large positive number.
1558 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1559 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1561 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1562 in case result does not fit in int.
1564 * print.c (float_to_string): Detect width overflow more reliably.
1565 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1566 buffer overrun. Don't assume list length fits in 'int'. Treat
1567 print length of 0 as 0, not as infinity; to be consistent with other
1568 uses of print length in this function. Don't overflow print length
1569 index. Don't assume hash table size fits in 'long', or that
1570 vectorlike size fits in 'unsigned long'.
1572 * process.c (make_process): Use printmax_t, not int, to format
1573 process-name gensyms.
1575 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1577 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1578 to avoid potential buffer overrun.
1580 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1581 if X resource line is longer than 512 bytes.
1583 * xfns.c (x_window): Make sprintf buffer a bit bigger
1584 to avoid potential buffer overrun.
1586 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1588 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1590 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1592 Integer overflow fixes for scrolling, etc.
1593 Without these, Emacs silently mishandles large integers sometimes.
1594 For example, "C-u 4294967297 M-x recenter" was treated as if
1595 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1597 * xdisp.c (try_window_id): Check Emacs fixnum range before
1598 converting to 'int'.
1600 * window.c (window_scroll_line_based, Frecenter):
1601 Check that an Emacs fixnum is in range before assigning it to 'int'.
1602 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1603 values converted from Emacs fixnums.
1604 (Frecenter): Don't wrap around a line count if it is out of 'int'
1605 range; instead, treat it as an extreme value.
1606 (Fset_window_configuration, compare_window_configurations):
1607 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1609 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1610 that can exceed INT_MAX. Check that EMACS_INT value is in range
1611 before assigning it to the (possibly-narrower) index.
1612 (match_limit): Don't assume that a fixnum can fit in 'int'.
1614 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1617 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1618 (Fvertical_motion): Don't wrap around LINES values that don't fit
1619 in 'int'. Instead, treat them as extreme values. This is good
1620 enough for windows, which can't have more than INT_MAX lines anyway.
1622 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1624 * Require libxml/parser.h to avoid compilation warning.
1626 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1628 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1629 since this reportedly can destroy thread storage.
1631 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1633 * syntax.c (find_defun_start): Update all cache variables if
1634 exiting early (Bug#9401).
1636 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1638 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1640 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1641 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1642 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1644 * term.c (tty_append_glyph): New function.
1645 (produce_stretch_glyph): Static function and its prototype deleted.
1647 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1650 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1652 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1653 when checking :margin (Bug#9390).
1654 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1655 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1656 so that the name doesn't mislead. All uses changed.
1658 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1660 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1663 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1665 * xdisp.c (move_it_to): Don't bail out early when reaching
1666 position beyond to_charpos, if we are scanning backwards.
1667 (move_it_vertically_backward): When DY == 0, make sure we get to
1668 the first character in the line after the newline.
1670 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1672 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1673 (ccl_driver): Do not generate an out-of-range pointer.
1674 (Fccl_execute_on_string): Remove unnecessary check for
1675 integer overflow, noted by Stefan Monnier in
1676 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1677 Remove a FIXME that didn't need fixing.
1678 Simplify the newly-introduced buffer reallocation code.
1680 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1682 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1684 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1686 Integer and memory overflow issues (Bug#9196).
1688 * doc.c (get_doc_string): Rework so that
1689 get_doc_string_buffer_size is the actual buffer size, rather than
1690 being 1 less than the actual buffer size; this makes xpalloc more
1693 * image.c (x_allocate_bitmap_record, cache_image):
1694 * xselect.c (Fx_register_dnd_atom):
1695 Simplify previous changes by using xpalloc.
1697 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1698 since either will do and ptrdiff_t is convenient with xpalloc.
1700 * charset.c (charset_table_size)
1701 (struct charset_sort_data.priority): Now ptrdiff_t.
1702 (charset_compare): Don't overflow if priorities differ greatly.
1703 (Fsort_charsets): Don't assume list length fits in int.
1704 Check for size-calculation overflow when allocating sort data.
1705 (syms_of_charset): Allocate an initial charset table that is
1706 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1708 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1710 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1711 The actual value is always <= INT_MAX, and leaving it unsigned made
1712 overflow checking harder.
1714 * dispextern.h (struct glyph_matrix.rows_allocated)
1715 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1716 with xpalloc. The values are still always <= INT_MAX.
1718 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1720 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1721 (SAFE_NALLOCA): New macro.
1723 * region-cache.c (struct boundary.pos, find_cache_boundary)
1724 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1725 (set_cache_region, invalidate_region_cache)
1726 (revalidate_region_cache, know_region_cache, region_cache_forward)
1727 (region_cache_backward, pp_cache):
1728 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1729 so that ptrdiff_t * can be passed to xpalloc.
1730 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1731 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1732 (pp_cache): Don't assume cache_len fits in int.
1733 * region-cache.h: Adjust extern decls to match.
1735 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1736 EMACS_INT, since either will do, for xpalloc.
1738 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1739 (xnmalloc, xnrealloc, xpalloc): New functions.
1741 * bidi.c (bidi_shelve_header_size): New constant.
1742 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1743 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1745 * bidi.c (bidi_cache_shrink):
1746 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1748 Don't update size of array until after memory allocation succeeds,
1749 because xmalloc/xrealloc may not return.
1750 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1751 now that we have proper integer overflow checking.
1752 (record_overlay_string, overlay_strings): Catch overflows when
1753 calculating size of overlay_str_buf.
1755 * callproc.c (Fcall_process): Check for size overflow when
1756 calculating size of args2.
1757 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1758 Normally we prefer signed values, but sticking with ptrdiff_t would
1759 require adding more-complicated checks.
1761 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1762 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1763 Redo buffer-overflow calculations to avoid integer overflow.
1764 Add a FIXME comment where memory seems to be over-allocated.
1766 * character.c (Fstring): Check for size-calculation overflow.
1768 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1769 unnecessary integer overflow. Check for size overflow.
1770 (encode_coding_object): Don't update size until xmalloc succeeds.
1772 * composite.c (get_composition_id): Check for overflow in glyph
1773 length calculations.
1775 Integer and memory overflow fixes for display code.
1776 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1777 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1778 (scrolling_window): Check for overflow in size calculations.
1779 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1780 Don't assume glyph table len fits in int.
1781 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1782 (row_table_size): Now ptrdiff_t, not int.
1783 (scrolling_window): Avoid overflow in size calculations.
1784 Don't update size until allocation succeeds.
1785 * fns.c (concat): Check for overflow in size calculations.
1786 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1787 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1788 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1790 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1791 (get_doc_string): Check for size calculation overflow.
1792 Don't update size until allocation succeeds.
1793 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1794 EMACS_INT, where ptrdiff_t will do.
1795 (Fsubstitute_command_keys): Check for string overflow.
1797 * editfns.c (set_time_zone_rule): Don't assume environment length
1799 (message_length): Now ptrdiff_t, not int.
1800 (Fmessage_box): Don't update size until allocation succeeds.
1801 Don't assume message length fits in int.
1802 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1804 * emacs.c (main): Do not reallocate argv, since there is a null at
1805 the end that can be overwritten, and this way there's no need to
1806 worry about size-calculation overflow.
1807 (sort_args): Check for size-calculation overflow.
1809 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1811 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1813 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1814 (x_set_scroll_bar_width, x_figure_window_size):
1815 Check for integer overflow.
1816 (x_set_alpha): Do not assume XINT fits in int.
1818 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1819 This is for the members text_lines, text_cols, total_lines, total_cols,
1820 where the system imposes an 'int' limit.
1822 * fringe.c (Fdefine_fringe_bitmap):
1823 Don't update size until alloc works.
1825 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1826 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1828 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1829 Check for size-calculation overflow.
1830 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1831 do, as we prefer signed integers.
1832 (id_to_widget.max_size, id_to_widget.used)
1833 (xg_store_widget_in_map, xg_remove_widget_from_map)
1834 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1835 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1836 Use and return ptrdiff_t, not int.
1837 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1838 * gtkutil.h: Change prototypes to match the above.
1840 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1841 are duplicate now that they've been promoted to lisp.h.
1842 (x_allocate_bitmap_record, x_alloc_image_color)
1843 (make_image_cache, cache_image, xpm_load):
1844 Don't update size until alloc is done.
1845 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1847 Check for size calculation overflow.
1848 (ct_colors_allocated_max): New constant.
1849 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1852 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1853 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1854 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1855 Use ptrdiff_t, not int, to count maps.
1856 (read_char_minibuf_menu_prompt): Check for overflow in size
1857 calculations. Don't update size until allocation succeeds.
1858 Redo calculations to avoid overflow.
1859 * keyboard.h: Change prototypes to match the above.
1861 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1863 (current_minor_maps): Check for size calculation overflow.
1864 * keymap.h: Change prototypes to match the above.
1866 * lread.c (read1, init_obarray): Don't update size until alloc done.
1868 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1869 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1871 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1872 Now ptrdiff_t, not int.
1873 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1874 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1876 * process.c (Fnetwork_interface_list): Check for overflow
1877 in size calculation.
1879 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1881 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1882 overflow. Don't bother calling xmalloc when xrealloc will do.
1884 * search.c (Freplace_match): Check for size calculation overflow.
1885 (Fset_match_data): Don't assume list lengths fit in 'int'.
1887 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1888 for command line length. Do not attempt to address one before the
1889 beginning of an array, as that's not portable.
1891 * term.c (max_frame_lines): Remove; unused.
1892 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1894 (encode_terminal_code, calculate_costs): Check for size
1895 calculation overflow.
1896 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1897 table lengths and related sizes. Don't update size until alloc
1898 done. Redo calculations to avoid overflow.
1899 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1901 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1902 subtracting pointers.
1903 (gobble_line): Check for overflow more carefully. Don't update size
1906 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1907 Don't update size until alloc done.
1908 Redo size calculations to avoid overflow.
1909 Check for size calculation overflow.
1910 (main) [DEBUG]: Fix typo in invoking tparam1.
1912 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1913 Use ptrdiff_t, not int, for sizes.
1914 (store_mode_line_noprop_char): Don't update size until alloc done.
1916 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1917 Use ptrdiff_t, not int, for sizes.
1918 (Finternal_make_lisp_face, cache_face):
1919 Check for size calculation overflow.
1920 (cache_face): Treat size calculation overflows as if they were
1921 memory exhaustion (the usual treatment), rather than aborting.
1923 * xfns.c (x_encode_text, x_set_name_internal)
1924 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1925 sizes, since they can exceed INT_MAX in size. Check for size
1926 calculation overflow.
1928 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1929 (xg_select): Check for size calculation overflow.
1930 Don't update size until alloc done.
1932 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1933 as sprintf is limited to int lengths.
1935 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1936 (X_LONG_MIN): New macros.
1937 Use them to make the following changes clearer.
1938 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1939 This change doesn't affect the value now, but it may help remind
1940 future maintainers not to raise the value too much later.
1941 (SELECTION_QUANTUM): Remove, replacing with ...
1942 (selection_quantum): ... new function, which avoids overflow.
1944 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1945 assumption that selection length fits in 'int'.
1946 (x_reply_selection_request, x_handle_selection_request)
1947 (x_get_window_property, receive_incremental_selection)
1948 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1949 (lisp_data_to_selection_data, clean_local_selection_data):
1950 Use ptrdiff_t, not int, to record length of selection.
1951 (x_reply_selection_request, x_get_window_property)
1952 (receive_incremental_selection, x_property_data_to_lisp):
1953 Redo calculations to avoid overflow.
1954 (x_reply_selection_request): When sending hint, ceiling it at
1955 X_LONG_MAX rather than relying on wraparound overflow to send
1957 (x_get_window_property, receive_incremental_selection)
1958 (lisp_data_to_selection_data, x_property_data_to_lisp):
1959 Check for size-calculation overflow.
1960 (x_get_window_property, receive_incremental_selection)
1961 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1962 Don't store size until memory allocation succeeds.
1963 (x_get_window_property): Plug memory leak on memory exhaustion.
1964 Don't double-block input; malloc is safe here. Don't assume 2**34
1965 - 4 fits in unsigned long. Add an xassert to check
1966 XGetWindowProperty overflow. Be more careful about overflow
1967 calculations, and distinguish size from memory overflow better.
1968 (receive_incremental_selection): When tracing, don't assume
1969 unsigned int is less than INT_MAX.
1970 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1971 harmful) conversions of unsigned short to int.
1972 (lisp_data_to_selection_data): Don't assume that integers
1973 in the range -65535 through -1 fit in an X unsigned short.
1974 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1975 result parameters unless successful. Rely on cons_to_unsigned
1976 to report problems with elements; the old code wasn't right anyway.
1977 (x_check_property_data): Check for int overflow; we cannot use
1978 a wider type due to X limits.
1979 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1981 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1983 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1984 (x_term_init): Check for size calculation overflow.
1985 (x_color_cells): Don't store size until memory allocation succeeds.
1986 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1987 Don't assume alloca size is less than MAX_ALLOCA.
1988 (x_term_init): Don't assume length fits in int (sprintf is limited
1991 Use ptrdiff_t for composition IDs.
1992 * character.c (lisp_string_width):
1993 * composite.c (composition_table_size, n_compositions)
1994 (get_composition_id, composition_gstring_from_id):
1995 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1996 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1997 * window.c (Frecenter):
1998 Use ptrdiff_t, not int, for composition IDs.
1999 * composite.c (get_composition_id): Check for integer overflow.
2000 * composite.h: Adjust prototypes to match the above changes.
2002 Use ptrdiff_t for hash table indexes.
2003 * category.c (hash_get_category_set):
2004 * ccl.c (ccl_driver):
2005 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2006 * coding.c (coding_system_charset_list, detect_coding_system):
2007 * coding.h (struct coding_system.id):
2008 * composite.c (get_composition_id, gstring_lookup_cache):
2009 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2010 * image.c (xpm_get_color_table_h):
2011 * lisp.h (hash_lookup, hash_put):
2012 * minibuf.c (Ftest_completion):
2013 Use ptrdiff_t for hash table indexes, not int (which is too
2014 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2015 32-bit --with-wide-int hosts).
2017 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2018 Add a FIXME comment about memory leaks.
2019 (syms_of_charset): Don't assume xmalloc returns.
2021 Don't assume that stated character widths fit in int.
2022 * character.c (Fchar_width, c_string_width, lisp_string_width):
2023 * character.h (CHAR_WIDTH):
2024 * indent.c (MULTIBYTE_BYTES_WIDTH):
2025 Use sanitize_char_width to avoid undefined and/or bad behavior
2026 with outlandish widths.
2027 * character.h (sanitize_tab_width): Rename from sanitize_width,
2028 now that we have two such functions. All uses changed.
2029 (sanitize_char_width): New inline function.
2031 Don't assume that tab-width fits in int.
2032 * character.h (sanitize_width): New inline function.
2033 (SANE_TAB_WIDTH): New macro.
2034 (ASCII_CHAR_WIDTH): Use it.
2035 * indent.c (sane_tab_width): Remove. All uses replaced by
2036 SANE_TAB_WIDTH (current_buffer).
2037 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2039 * fileio.c: Integer overflow issues with file modes.
2040 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2042 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2043 Remove unreachable code.
2044 (read_hex, load_charset_map_from_file): Check for integer overflow.
2046 * xterm.c: don't go over XClientMessageEvent limit
2047 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2048 (x_send_scroll_bar_event): Likewise. Check that the size does not
2049 exceed limits imposed by XClientMessageEvent, as well as the usual
2050 ptrdiff_t and size_t limits.
2052 * keyboard.c: Overflow, signedness and related fixes.
2053 (make_lispy_movement): Use same integer type in forward decl
2054 that is used in the definition.
2055 (read_key_sequence, keyremap_step):
2056 Change bufsize argument back to int, undoing my 2011-03-30 change.
2057 We prefer signed types, and int is wide enough here.
2058 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2059 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2060 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2061 length, not size_t. Use ptrdiff_t for index, not int.
2062 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2063 possibility of integer overflow.
2065 Overflow, signedness and related fixes for images.
2067 * dispextern.h (struct it.stack[0].u.image.image_id)
2068 (struct_it.image_id, struct image.id, struct image_cache.size)
2069 (struct image_cache.used, struct image_cache.ref_count):
2070 * gtkutil.c (update_frame_tool_bar):
2071 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2072 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2073 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2074 * nsmenu.m (update_frame_tool_bar):
2075 * xdisp.c (calc_pixel_width_or_height):
2076 * xfns.c (image_cache_refcount):
2077 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2078 on typical 64-bit hosts.
2080 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2081 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2082 Omit unnecessary casts to int.
2083 (parse_image_spec): Check that integers fall into 'int' range
2084 when the callers expect that.
2085 (image_ascent): Redo ascent calculation to avoid int overflow.
2086 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2087 (lookup_image): Remove unnecessary tests.
2088 (xbm_image_p): Locals are now of int, not EMACS_INT,
2089 since parse_image_check makes sure they fit into int.
2090 (png_load, gif_load, svg_load_image):
2091 Prefer int to unsigned where either will do.
2092 (tiff_handler): New function, combining the cores of the
2093 old tiff_error_handler and tiff_warning_handler.
2094 This function is rewritten to use vsnprintf and thereby avoid
2095 stack buffer overflows. It uses only the features of vsnprintf
2096 that are common to both POSIX and native Microsoft.
2097 (tiff_error_handler, tiff_warning_handler): Use it.
2098 (tiff_load, gif_load, imagemagick_load_image):
2099 Don't assume :index value fits in 'int'.
2100 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2101 (imagemagick_load_image): Check that crop parameters fit into
2102 the integer types that MagickCropImage accepts. Don't assume
2103 Vimagemagick_render_type has a nonnegative value. Don't assume
2104 size_t fits in 'long'.
2105 (gs_load): Use printmax_t to print the widest integers possible.
2106 Check for integer overflow when computing image height and width.
2108 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2110 * xdisp.c (redisplay_window): Don't force window start if point
2111 will be invisible in the resulting window. (Bug#9324)
2113 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2115 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2116 the display spec is of the form `(space ...)'.
2117 (handle_display_spec): Return the value returned by
2118 handle_single_display_spec, not just 1 or zero.
2119 (handle_single_display_spec): If the display spec is of the form
2120 `(space ...)', and specifies display in the text area, return 2
2122 (try_cursor_movement): Check for the need to scroll more
2123 accurately, and prefer exact match for point under bidi.
2124 Don't advance `row' beyond the last row of the window.
2126 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2127 into disp_prop; all users changed.
2129 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2130 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2131 for the text covered by the display property.
2133 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2135 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2136 Change return value to nil.
2137 (Frecord_buffer): Delete unused function.
2139 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2142 buffers, return left-to-right.
2143 (set_cursor_from_row): Consider candidate row a win if its glyph
2144 represents a newline and point is on that newline. Fixes cursor
2145 positioning on the newline at EOL of R2L text within L2R
2146 paragraph, and vice versa.
2147 (try_cursor_movement): Check continued rows, in addition to
2148 continuation rows. Fixes unwarranted scroll when point enters a
2149 continued line of R2L text within an L2R paragraph, or vice versa.
2150 (cursor_row_p): Consider the case of point being equal to
2151 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2152 from the end of a short line to the beginning of a continued line
2153 of R2L text within L2R paragraph.
2154 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2155 composed characters.
2157 * bidi.c (bidi_check_type): Use xassert.
2158 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2161 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2163 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2166 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2168 * nsfont.m (ns_otf_to_script): Fix typo.
2170 2011-08-22 Kenichi Handa <handa@m17n.org>
2172 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2173 extra slot even if the purpose is char-code-property-table.
2175 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2177 * xdisp.c (redisplay_window): When computing centering_position,
2178 account for the height of the header line. (Bug#8874)
2180 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2181 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2182 candidate is selected by the mouse, and that candidate has a
2183 composed character under the mouse.
2185 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2186 coordinates reported by pos-visible-in-window-p for a composed
2187 character in column zero.
2189 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2191 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2193 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2195 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2196 consider it a hit if to_charpos is anywhere in the range of the
2197 composed buffer positions.
2199 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2201 * image.c (gif_load): Don't assume that each subimage has the same
2202 dimensions as the base image. Handle disposal method that is
2203 "undefined" by the gif spec (Bug#9335).
2205 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2207 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2208 (Fcondition_case): Document `debug' symbol in error handler.
2210 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2212 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2213 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2214 from an Org mode buffer to a Speedbar frame.
2216 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2217 a composition, take its buffer position from IT->cmp_it.charpos.
2218 Fixes cursor positioning at the beginning of a line that begins
2219 with a composed character.
2221 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2223 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2224 character bidirectional type, use STRONG_L instead. Fixes crashes
2225 in a buffer produced by `describe-categories'.
2227 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2228 members before the level stack, so they would be saved and
2229 restored when copying iterator state. Fixes incorrect reordering
2230 around TABs covered by display properties.
2232 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2234 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2236 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2238 * eval.c (internal_condition_case, internal_condition_case_1)
2239 (internal_condition_case_2, internal_condition_case_n):
2240 Remove unnecessary aborts (Bug#9081).
2242 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2244 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2245 has no `load' handler, try opening the file locally. (Bug#9311)
2247 2011-08-16 Ken Brown <kbrown@cornell.edu>
2249 * gmalloc.c: Expand comment.
2251 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2253 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2254 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2256 2011-08-16 Ken Brown <kbrown@cornell.edu>
2258 Fix memory allocation problems in Cygwin build (Bug#9273).
2260 * unexcw.c ( __malloc_initialized): Declare external variable.
2261 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2263 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2265 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2267 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2269 [CYGWIN] (special_realloc): New function.
2270 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2271 requests to realloc storage in the static heap.
2273 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2275 * bidi.c (bidi_initialize): Remove unused local.
2277 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2280 * biditype.h: Remove file.
2281 * makefile.w32-in ($(BLD)/bidi.$(O)):
2282 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2284 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2286 * chartab.c: Improve commentary for the uniprop_table API.
2288 * bidi.c (bidi_paragraph_init): Support zero value of
2289 bidi_ignore_explicit_marks_for_paragraph_level.
2290 (bidi_initialize): Use uniprop_table instead of including
2291 biditype.h and bidimirror.h.
2293 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2294 coordinates of the iterator when restoring from ppos_it.
2297 2011-08-14 Kenichi Handa <handa@m17n.org>
2299 * process.c (create_process): Call setup_process_coding_systems
2300 after the pid of the process is set to -1 (Bug#8162).
2302 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2304 * xdisp.c (move_it_in_display_line_to): Don't invoke
2305 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2306 ppos_it. Fixes vertical cursor motion when line beginning is
2307 covered by an image. (Bug#9296)
2309 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2311 * nsterm.h (ns_run_ascript): Declare.
2312 (NSAPP_DATA2_RUNASSCRIPT): Define.
2314 * nsfns.m (as_script, as_result, as_status): New static variables.
2315 (ns_run_ascript): New function.
2316 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2317 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2318 the event loop. Get status from as_status (Bug#7276).
2320 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2321 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2322 the event loop (Bug#7276).
2324 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2326 * gnutls.c (QCgnutls_bootprop_priority)
2327 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2328 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2329 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2330 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2331 (QCgnutls_bootprop_verify_hostname_error)
2332 (QCgnutls_bootprop_callbacks_verify): Rename from
2333 Qgnutls_bootprop_..., all uses changed.
2335 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2338 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2340 * xfaces.c (Qframe_set_background_mode): Now static.
2341 * dispextern.h (Qframe_set_background_mode): Remove decl.
2343 * process.c (Fnetwork_interface_info): Declare local only if needed.
2345 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2347 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2348 (Fnetwork_interface_list): Allocate in increments of bytes instead
2349 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2350 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2352 (struct ifflag_def): notrailers is smart on OSX.
2353 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2354 Get hardware address with getifaddrs if available.
2356 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2358 * xdisp.c (iterate_out_of_display_property): xassert that
2359 IT->position is set to within IT->object's boundaries. Break from
2360 the loop as soon as EOB is reached; avoids infloops in redisplay
2361 when IT->position is set up wrongly due to some bug.
2362 Set IT->current to match the bidi iterator unconditionally.
2363 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2364 entry. Force push_it to save on the stack the current
2365 buffer/string position, to be restored by pop_it. Fix flags in
2366 the iterator structure wrt the object coming from a display
2367 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2368 properties. (Bug#9284)
2370 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2372 * fontset.c (fontset_get_font_group): Add proper type checks.
2375 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2377 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2378 and LC_VERSION_MIN_MACOSX.
2379 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2380 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2382 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2384 * xdisp.c (forward_to_next_line_start): Allow to use the
2385 no-display-properties-and-no-overlays under bidi display.
2386 Set disp_pos in the bidi iterator to avoid searches for display
2387 properties and overlays.
2389 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2391 * editfns.c (Fset_time_zone_rule): Document relationship with the
2394 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2395 the font entity extracted from the cache (Bug#8109).
2397 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2399 * composite.c (autocmp_chars): Don't reset point. That is done by
2400 restore_point_unwind (Bug#5984).
2402 2011-08-07 Juri Linkov <juri@jurta.org>
2404 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2405 to show the arg `TIME' instead of `TIMEVAL'.
2407 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2409 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2410 display property strides EOL and includes a newline, as in
2411 longlines-mode. (Bug#9254)
2412 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2413 word-wrap under bidirectional display. (Bug#9224)
2415 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2416 is non-zero, even if the data buffer is NULL. Fixes a crash in
2417 vertical-motion with longlines-mode. (Bug#9254)
2419 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2421 * bidi.c <bidi_cache_total_alloc>: Now static.
2422 (bidi_initialize): Initialize bidi_cache_total_alloc.
2424 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2427 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2428 amount allocated this far in `bidi_cache_total_alloc'.
2429 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2430 non-zero, only free the data buffer without restoring the cache
2431 contents. All callers changed.
2433 * dispextern.h (bidi_unshelve_cache): Update prototype.
2435 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2436 (move_it_in_display_line, move_it_to)
2437 (move_it_vertically_backward, move_it_by_lines): Replace the call
2438 to xfree to an equivalent call to bidi_unshelve_cache.
2439 (move_it_in_display_line_to): Fix logic of returning
2440 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2442 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2444 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2445 came from a string character with a `cursor' property. (Bug#9229)
2447 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2449 * Makefile.in (LIB_PTHREAD): New variable.
2450 (LIBES): Add LIB_PTHREAD (Bug#9216).
2452 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2453 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2455 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2457 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2459 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2461 * xterm.c (x_find_topmost_parent): New function.
2462 (x_set_frame_alpha): Find topmost parent window with
2463 x_find_topmost_parent and set the property there also (bug#9181).
2464 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2466 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2468 * callproc.c (Fcall_process): Avoid vfork clobbering
2469 the local vars buffer, coding_systems, current_dir.
2471 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2473 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2475 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2477 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2478 so that it is not optimized away.
2480 * xdisp.c (compute_display_string_pos): Remove unused local.
2482 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2484 Fix slow cursor motion and scrolling in large buffers with
2485 selective display, like Org Mode buffers. (Bug#9218)
2487 * dispextern.h (struct bidi_it): New member disp_prop_p.
2489 * xdisp.c: Remove one-slot cache of display string positions.
2490 (compute_display_string_pos): Accept an additional argument
2491 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2492 for a display string or property. If found, set DISP_PROP_P
2495 * bidi.c (bidi_fetch_char): Accept an additional argument
2496 DISP_PROP_P, and pass it to compute_display_string_pos.
2497 Only handle text covered by a display string if DISP_PROP_P is returned
2498 non-zero. All callers of bidi_fetch_char changed.
2500 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2502 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2504 2010-12-03 Don March <don@ohspite.net>
2506 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2507 last character M-[char] is translated to ESC [char] (bug#7541).
2509 2011-08-02 Kenichi Handa <handa@m17n.org>
2511 * lisp.h (uniprop_table): Extern it.
2513 * chartab.c (uniprop_table): Make it non-static.
2515 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2517 * xdisp.c (forward_to_next_line_start): Accept additional argument
2518 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2520 (reseat_at_next_visible_line_start): Use the bidi iterator state
2521 returned by forward_to_next_line_start to restore the state of
2522 it->bidi_it after backing up to previous newline. (Bug#9212)
2524 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2526 * regex.c (re_comp): Protoize.
2527 (re_exec): Fix return type.
2528 (regexec): Fix type of `ret'. (Bug#9203)
2530 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2532 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2533 This is needed if max-image-size is a floating-point number.
2535 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2537 * print.c (print_object): Print empty symbol as ##.
2539 * lread.c (read1): Read ## as empty symbol.
2541 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2543 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2544 setting frame foreground color (Bug#9175).
2545 (x_set_background_color): Likewise.
2547 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2548 contents (Bug#9176).
2549 (EmacsTooltip -init): Remove bezels and add shadows to
2552 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2553 or scroll bar (Bug#8470).
2555 * nsfont.m (nsfont_open): Remove assignment to voffset and
2556 unnecessary vars hshink, expand, hd, full_height, min_height.
2557 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2559 * nsterm.h (nsfont_info): Remove voffset field.
2561 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2563 Implement strike-through and overline on NextStep (Bug#8863).
2565 * nsfont.m (nsfont_open): Use underline position provided by font,
2566 instead of hard-coded value of 2.
2567 (nsfont_draw): Call ns_draw_text_decoration instead.
2569 * nsterm.h: Add declaration for ns_draw_text_decoration.
2571 * nsterm.m (ns_draw_text_decoration): New function for drawing
2572 underline, overline, and strike-through.
2573 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2574 ns_draw_text_decoration. Change treatment of cursor drawing to
2575 accommodate underlining, etc.
2577 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2579 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2582 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2584 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2585 Without this fix, if a signal arrives just after memory fills up,
2586 'malloc' might be invoked reentrantly.
2588 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2589 In other words, assume that every image size is allowed, on non-X
2590 hosts. This assumption is probably wrong, but it lets Emacs compile.
2592 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2594 * regex.c (re_iswctype): Convert return values to boolean.
2596 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2598 * xdisp.c (compute_display_string_pos): Don't use cached display
2599 string position if the buffer had its restriction changed.
2602 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2604 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2606 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2608 Integer signedness and overflow and related fixes. (Bug#9079)
2610 * bidi.c: Integer size and overflow fixes.
2611 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2612 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2613 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2614 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2615 (bidi_find_other_level_edge):
2616 Use ptrdiff_t instead of EMACS_INT where either will do.
2617 This works better on 32-bit hosts configured --with-wide-int.
2618 (bidi_cache_ensure_space): Check for size-calculation overflow.
2619 Use % rather than repeated addition, for better worst-case speed.
2620 Don't set bidi_cache_size until after xrealloc returns, because it
2622 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2623 (bidi_cache_ensure_space): Also check that the bidi cache size
2624 does not exceed that of the largest Lisp string or buffer. See Eli
2625 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2627 * alloc.c (__malloc_size_t): Remove.
2628 All uses replaced by size_t. See Andreas Schwab's note
2629 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2631 * image.c: Improve checking for integer overflow.
2632 (check_image_size): Assume that f is nonnull, since
2633 it is always nonnull in practice. This is one less thing to
2634 worry about when checking for integer overflow later.
2635 (x_check_image_size): New function, which checks for integer
2636 overflow issues inside X.
2637 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2638 This removes the need for a memory_full check.
2639 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2640 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2641 (xbm_read_bitmap_data): Change locals back to 'int', since
2642 their values must fit in 'int'.
2643 (xpm_load_image, png_load, tiff_load):
2644 Invoke x_create_x_image_and_pixmap earlier,
2645 to avoid much needless work if the image is too large.
2646 (tiff_load): Treat overly large images as if
2647 x_create_x_image_and_pixmap failed, not as malloc failures.
2648 (gs_load): Use x_check_image_size.
2650 * gtkutil.c: Omit integer casts.
2651 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2652 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2654 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2656 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2657 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2658 would wrongly return t on a 64-bit host.
2660 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2661 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2662 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2663 and therefore cause GCC to emit a bogus diagnostic in some cases.
2665 * image.c: Integer signedness and overflow and related fixes.
2666 This is not an exhaustive set of fixes, but it's time to
2667 record what I've got.
2668 (lookup_pixel_color, check_image_size): Remove redundant decls.
2669 (check_image_size): Don't assume that arbitrary EMACS_INT values
2670 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2671 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2672 (tiff_load, imagemagick_load_image):
2673 Check for overflow in size calculations.
2674 (x_create_x_image_and_pixmap): Remove unnecessary test for
2675 xmalloc returning NULL; that can't happen.
2676 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2677 (xpm_color_bucket): Use better integer hashing function.
2678 (xpm_cache_color): Don't possibly over-allocate memory.
2679 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2680 (gif_memory_source):
2681 Use ptrdiff_t, not int or size_t, to record sizes.
2682 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2683 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2684 either works, as we prefer signed integers.
2685 (tiff_read_from_memory, tiff_write_from_memory):
2686 Return tsize_t, not size_t, since that's what the TIFF API wants.
2687 (tiff_read_from_memory): Don't fail simply because the read would
2688 go past EOF; instead, return a short read.
2689 (tiff_load): Omit no-longer-needed casts.
2690 (Fimagemagick_types): Don't assume size fits into 'int'.
2692 Improve hashing quality when configured --with-wide-int.
2693 * fns.c (hash_string): New function, taken from sxhash_string.
2694 Do not discard information about ASCII character case; this
2695 discarding is no longer needed.
2696 (sxhash-string): Use it. Change sig to match it. Caller changed.
2697 * lisp.h: Declare it.
2698 * lread.c (hash_string): Remove, since we now use fns.c's version.
2699 The fns.c version returns a wider integer if --with-wide-int is
2700 specified, so this should help the quality of the hashing a bit.
2702 * emacs.c: Integer overflow minor fix.
2703 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2704 Define only if GNU_LINUX.
2705 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2707 * dispnew.c: Integer signedness and overflow fixes.
2708 Remove unnecessary forward decls, that were a maintenance hassle.
2709 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2711 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2712 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2713 (prepare_desired_row, line_draw_cost):
2714 Use int, not unsigned, where either works.
2715 (save_current_matrix, restore_current_matrix):
2716 Use ptrdiff_t, not size_t, where either works.
2717 (init_display): Check for overflow more accurately, and without
2718 relying on undefined behavior.
2720 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2721 Remove, replacing with the new symbols in lisp.h. All uses changed.
2722 * fileio.c (make_temp_name):
2723 * filelock.c (lock_file_1, lock_file):
2724 * xdisp.c (message_dolog):
2725 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2726 Use pMd etc. instead.
2727 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2728 replacing the pWIDE etc. symbols removed from editfns.c.
2730 * keyboard.h (num_input_events): Now uintmax_t.
2731 This is (very slightly) less likely to mess up due to wraparound.
2734 * buffer.c: Integer signedness fixes.
2735 (alloc_buffer_text, enlarge_buffer_text):
2736 Use ptrdiff_t rather than size_t when either will do, as we prefer
2739 * alloc.c: Integer signedness and overflow fixes.
2740 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2741 (__malloc_size_t): Default to size_t, not to int.
2742 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2743 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2744 Prefer ptrdiff_t to size_t when either would do, as we prefer
2746 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2747 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2748 Now const. Initialize with values that are in range even if char
2750 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2751 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2752 These functions do the right thing with sizes > 2**32.
2753 (check_depth): Now ptrdiff_t, not int.
2754 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2755 Adjust to new way of storing sizes. Check for size overflow bugs
2757 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2758 slightly wrong anyway, as it missed one instance of
2759 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2760 (refill_memory_reserve): Omit needless cast to size_t.
2761 (mark_object_loop_halt): Mark as externally visible.
2763 * xselect.c: Integer signedness and overflow fixes.
2764 (Fx_register_dnd_atom, x_handle_dnd_message):
2765 Use ptrdiff_t, not size_t, since we prefer signed.
2766 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2767 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2768 x_dnd_atoms_size and x_dnd_atoms_length.
2770 * doprnt.c: Prefer signed to unsigned when either works.
2772 * doprnt.c (doprnt):
2774 * xdisp.c (vmessage):
2775 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2776 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2777 prefer signed arithmetic to avoid comparison confusion.
2778 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2779 but is a bit tricky.
2781 Assume freestanding C89 headers, string.h, stdlib.h.
2782 * data.c, doprnt.c, floatfns.c, print.c:
2783 Include float.h unconditionally.
2784 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2785 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2786 * regex.c: Likewise for stddef.h, string.h.
2787 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2788 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2789 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2790 (STDC_HEADERS): Remove obsolete defines.
2791 * sysdep.c: Include limits.h unconditionally.
2793 Assume support for memcmp, memcpy, memmove, memset.
2794 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2795 * regex.c (memcmp, memcpy):
2796 Remove; we assume C89 now.
2798 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2799 (__malloc_safe_bcopy): Remove; no longer needed.
2801 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2802 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2803 well either way, and we prefer signed to unsigned.
2805 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2807 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2808 closes the connection while we're reading (bug#9182).
2810 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2812 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2813 are specified (Bug#9168).
2815 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2817 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2818 Found by GCC static checking and --with-wide-int on a 32-bit host.
2820 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2822 * xdisp.c (compute_display_string_pos): Fix logic of caching
2823 previous display string position. Initialize cached_prev_pos to
2824 -1. Fixes slow-down at the beginning of a buffer.
2826 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2828 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2829 for attrs[LFACE_FONTSET_INDEX].
2831 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2833 * xml.c (parse_region): Remove unused local
2834 that was recently introduced.
2836 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2838 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2839 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2841 * xdisp.c (move_it_in_display_line_to): Record the best matching
2842 position for TO_CHARPOS while scanning the line, and restore it on
2843 exit if none of the characters scanned was an exact match.
2844 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2845 when exact match is impossible due to invisible text, and the
2846 lines are truncated.
2848 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2850 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2853 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2855 Fix a significant slow-down of cursor motion with C-n, C-p,
2856 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2857 auto-repeat under bidi redisplay in fontified buffers.
2858 * xdisp.c (compute_stop_pos_backwards): New function.
2859 (next_element_from_buffer): Call compute_stop_pos_backwards to
2860 find a suitable prev_stop when we find ourselves before
2862 (reseat): Don't look for prev_stop, as that could mean a very long
2864 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2865 <cached_disp_overlay_modiff>: Cache for last found display string
2867 (compute_display_string_pos): Return the cached position if asked
2868 about the same buffer in the same area of character positions, and
2869 the buffer wasn't changed since the time the display string
2870 position was cached.
2872 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2874 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2875 is an integer, which is important for empty lines. (Bug#9149)
2877 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2879 * frame.c (Fmodify_frame_parameters): In tty case, update the
2880 default face if necessary (Bug#4238).
2882 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2884 * editfns.c (Fstring_to_char): No need to explain what a character
2885 is in the docstring (Bug#6576).
2887 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2889 * xml.c (parse_region): Make sure we always return a tree.
2891 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2893 * xml.c (parse_region): If a document contains only comments,
2896 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2898 * xml.c (make_dom): Return comments, too.
2900 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2903 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2904 and the surrounding thread.
2905 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2906 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2907 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2909 * s/openbsd.h (BROKEN_SIGIO): Define.
2910 * unexelf.c (unexec) [__OpenBSD__]:
2911 Don't update the .mdebug section of the Alpha COFF symbol table.
2913 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2915 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2918 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2920 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2921 This fixes some race conditions on the permissions of any newly
2924 * alloc.c (valid_pointer_p): Use pipe, not open.
2925 This fixes some permissions issues when debugging.
2927 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2928 If fchown fails to set both uid and gid, try to set just gid,
2929 as that is sometimes allowed. Adjust the file's mode to eliminate
2930 setuid or setgid bits that are inappropriate if fchown fails.
2932 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2934 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2935 to compare Lisp_Objects.
2936 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2937 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2938 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2940 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2942 * lread.c (read_integer): Unread even EOF character.
2943 (read1): Likewise. Properly record start position of symbol.
2945 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2946 symbol character follows.
2948 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2950 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2951 This works around a problem with the previous change to Fcopy_file.
2952 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2953 and without this change, GCC might complain about discarding
2954 fchown's return value.
2956 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2958 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2960 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2962 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2964 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2966 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2967 it's used from the C level.
2969 * process.c: Use the same condition for POLL_FOR_INPUT in both
2970 keyboard.c and process.c (bug#1858).
2972 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2974 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2975 (Fgnutls_boot): Use it.
2977 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2979 * doc.c (Fsubstitute_command_keys): Revert last change.
2981 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2983 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2984 quotes the next character, and doesn't affect other longer
2985 sequences (bug#8935).
2987 * lread.c (syms_of_lread): Clarify that is isn't only
2988 `eval-buffer' and `eval-defun' that's affected by
2989 `lexical-binding' (bug#8460).
2991 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2993 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2994 bidi redisplay when a line includes both an image and is truncated.
2996 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2998 Fix minor problems found by static checking.
2999 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3000 (elsz): Now a signed constant, not a size_t var. We prefer signed
3001 types to unsigned, to avoid integer comparison confusion. Without
3002 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3003 "cannot optimize loop, the loop counter may overflow", a symptom
3005 * indent.c (Fvertical_motion): Mark locals as initialized.
3006 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3008 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3010 * search.c (Fre_search_backward): Mention `case-fold-search' in
3011 all the re_search_* functions (bug#8138).
3013 * keyboard.c (Fopen_dribble_file): Document when the file is
3016 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3018 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3021 Support bidi reordering of display and overlay strings.
3022 * xdisp.c (compute_display_string_pos)
3023 (compute_display_string_end): Accept additional argument STRING.
3024 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3025 (reseat_to_string): Initialize bidi_it->string.s and
3026 bidi_it->string.schars.
3027 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3028 NULL (avoids a crash in bidi_paragraph_init).
3029 Initialize itb.string.lstring.
3030 (init_iterator): Call bidi_init_it only of a valid
3031 buffer position was specified. Initialize paragraph_embedding to
3033 (reseat_to_string): Initialize the bidi iterator.
3034 (display_string): If we need to ignore text properties of
3035 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3036 original value of -1 will not work with bidi.)
3037 (compute_display_string_pos): First arg is now struct
3038 `text_pos *'; all callers changed. Support display properties on
3040 (compute_display_string_end): Support display properties on Lisp
3042 (init_iterator, reseat_1, reseat_to_string): Initialize the
3043 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3044 when iterating on a string not from display properties).
3045 (compute_display_string_pos, compute_display_string_end):
3046 Fix calculation of the object to scan. Fixes an error when using
3048 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3049 base_level_stop; instead, set base_level_stop to BEGV.
3050 Fixes crashes in vertical-motion.
3051 (next_element_from_buffer): Improve commentary for when
3052 the iterator is before prev_stop.
3053 (init_iterator): Initialize bidi_p from the default value of
3054 bidi-display-reordering, not from buffer-local value. Use the
3055 buffer-local value only if initializing for buffer iteration.
3056 (handle_invisible_prop): Support invisible properties on strings
3057 that are being bidi-reordered.
3058 (set_iterator_to_next): Support bidi reordering of C strings and
3060 (next_element_from_string): Support bidi reordering of Lisp
3062 (handle_stop_backwards): Support Lisp strings as well.
3063 (display_string): Support display of R2L glyph rows.
3064 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3065 (init_iterator): Don't initialize it->bidi_p for strings
3067 (reseat_to_string): Initialize it->bidi_p for strings here.
3068 (next_element_from_string, next_element_from_c_string)
3069 (next_element_from_buffer): Add xassert's for correspondence
3070 between IT's object being iterated and it->bidi_it.string
3072 (face_before_or_after_it_pos): Support bidi iteration.
3073 (next_element_from_c_string): Handle the case of the first string
3074 character that is not the first one in the visual order.
3075 (get_visually_first_element): New function, refactored from common
3076 parts of next_element_from_buffer, next_element_from_string, and
3077 next_element_from_c_string.
3078 (tool_bar_lines_needed, redisplay_tool_bar)
3079 (display_menu_bar): Force left-to-right direction. Add a FIXME
3080 comment for making that be controlled by a user option.
3081 (push_it, pop_it): Save and restore the state of the
3082 bidi iterator. Save and restore the bidi_p flag.
3083 (pop_it): Iterate out of display property for string iteration as
3085 (iterate_out_of_display_property): Support iteration over strings.
3086 (handle_single_display_spec): Set up it->bidi_it for iteration
3087 over a display string, and call bidi_init_it.
3088 (handle_single_display_spec, next_overlay_string)
3089 (get_overlay_strings_1, push_display_prop): Set up the bidi
3090 iterator for displaying display or overlay strings.
3091 (forward_to_next_line_start): Don't use the shortcut if
3093 (back_to_previous_visible_line_start): If handle_display_prop
3094 pushed the iterator stack, restore the internal state of the bidi
3095 iterator by calling bidi_pop_it same number of times.
3096 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3097 and we are bidi-iterating, don't decrement the iterator position;
3098 instead, set the first_elt flag in the bidi iterator, to produce
3100 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3101 (push_display_prop): xassert that we are iterating a buffer.
3102 (push_it, pop_it): Save and restore paragraph_embedding member.
3103 (handle_single_display_spec, next_overlay_string)
3104 (get_overlay_strings_1, reseat_1, reseat_to_string)
3105 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3106 correctly. Don't assume unibyte strings are not bidi-reordered.
3107 (compute_display_string_pos)
3108 (compute_display_string_end): Fix handling the case of C string.
3109 (push_it, pop_it): Save and restore from_disp_prop_p.
3110 (handle_single_display_spec, push_display_prop): Set the
3111 from_disp_prop_p flag.
3112 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3113 (pop_it): Call iterate_out_of_display_property only if we are
3114 popping after iteration over a string that came from a display
3115 property. Fix a typo in popping stretch info. Add an assertion
3116 for verifying that the iterator position is in sync with the bidi
3118 (handle_single_display_spec, get_overlay_strings_1)
3119 (push_display_prop): Fix initialization of paragraph direction for
3120 string when that of the parent object is not yet determined.
3121 (reseat_1): Call bidi_init_it to resync the bidi
3122 iterator with IT's position. (Bug#7616)
3123 (find_row_edges): If ROW->start.pos gives position
3124 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3125 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3126 Reset the from_disp_prop_p flag.
3127 (SAVE_IT, RESTORE_IT): New macros.
3128 (pos_visible_p, face_before_or_after_it_pos)
3129 (back_to_previous_visible_line_start)
3130 (move_it_in_display_line_to, move_it_in_display_line)
3131 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3132 (try_scrolling, redisplay_window, display_line): Use them when
3133 saving a temporary copy of the iterator and restoring it back.
3134 (back_to_previous_visible_line_start, reseat_1)
3135 (init_iterator): Empty the bidi cache "stack".
3136 (move_it_in_display_line_to): If iterator ended up at
3137 EOL, but we never saw any buffer positions smaller than
3138 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3139 motion in bidi-reordered lines.
3140 (move_it_in_display_line_to): Record prev_method and prev_pos
3141 immediately before the call to set_iterator_to_next. Fixes cursor
3142 motion in bidi-reordered lines with stretch glyphs and strings
3143 displayed in margins. (Bug#8133) (Bug#8867)
3144 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3146 (pos_visible_p): Support positions in bidi-reordered lines.
3147 Save and restore bidi cache.
3149 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3150 (bidi_paragraph_info): Delete unused struct.
3151 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3152 (bidi_cache_start): New variable.
3153 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3155 (bidi_cache_fetch_state, bidi_cache_search)
3156 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3157 (bidi_cache_find, bidi_peek_at_next_level)
3158 (bidi_level_of_next_char, bidi_find_other_level_edge)
3159 (bidi_move_to_visually_next): Compare cache index with
3160 bidi_cache_start rather than with zero.
3161 (bidi_fetch_char): Accept new argument STRING; all callers
3162 changed. Support iteration over a string. Support strings with
3163 display properties. Support unibyte strings. Fix the type of
3164 `len' according to what STRING_CHAR_AND_LENGTH expects.
3165 (bidi_paragraph_init, bidi_resolve_explicit_1)
3166 (bidi_resolve_explicit, bidi_resolve_weak)
3167 (bidi_level_of_next_char, bidi_move_to_visually_next):
3168 Support iteration over a string.
3169 (bidi_set_sor_type, bidi_resolve_explicit_1)
3170 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3171 can now be zero (for strings); special values 0 and -1 were
3172 changed to -1 and -2, respectively.
3173 (bidi_char_at_pos): New function.
3174 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3175 Call it instead of FETCH_MULTIBYTE_CHAR.
3176 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3177 initialized to valid values.
3178 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3180 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3181 the test for valid cached positions. Fix the logic for looking up
3182 the sentinel state in the cache. GCPRO the Lisp string we are
3184 (bidi_push_it, bidi_pop_it): New functions.
3185 (bidi_initialize): Initialize the bidi cache start stack pointer.
3186 (bidi_cache_ensure_space): New function, refactored from part of
3187 bidi_cache_iterator_state. Don't assume the required size is just
3188 one BIDI_CACHE_CHUNK away.
3189 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3190 (bidi_count_bytes, bidi_char_at_pos): New functions.
3191 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3192 always valid if bidi_cache_idx is valid.
3193 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3194 is valid if it's going to be used.
3195 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3196 (bidi_cache_fetch_state, bidi_cache_search)
3197 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3198 (bidi_cache_iterator_state, bidi_cache_find)
3199 (bidi_find_other_level_edge, bidi_cache_start_stack):
3200 All variables related to cache indices are now EMACS_INT.
3202 * dispextern.h (struct bidi_string_data): New structure.
3203 (struct bidi_it): New member `string'. Make flag members be 1-bit
3204 fields, and put them last in the struct.
3205 (compute_display_string_pos, compute_display_string_end):
3207 (bidi_push_it, bidi_pop_it): Add prototypes.
3208 (struct iterator_stack_entry): New members bidi_p,
3209 paragraph_embedding, and from_disp_prop_p.
3210 (struct it): Member bidi_p is now a bit field 1 bit wide.
3211 (bidi_shelve_cache, bidi_unshelve_cache):
3214 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3215 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3216 and vector-like objects.
3218 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3219 cache around display iteration.
3221 * window.c (Fwindow_end, window_scroll_pixel_based)
3222 (displayed_window_lines, Frecenter): Save and restore the bidi
3223 cache around display iteration.
3225 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3227 * editfns.c (Fdelete_region): Clarify the use of the named
3228 parameters (bug#6788).
3230 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3232 * indent.c (Fvertical_motion): Set and restore w->pointm when
3233 saving and restoring the window's buffer (Bug#9006).
3235 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3237 * editfns.c (Fstring_to_char): Clarify just what is returned
3238 (bug#6576). Text by Eli Zaretskii.
3240 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3242 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3244 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3246 * buffer.c (mmap_find): Fix a typo.
3248 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3250 Fix execution of x selection hooks.
3251 * xselect.c (Qx_lost_selection_functions)
3252 (Qx_sent_selection_functions): New vars.
3253 (syms_of_xselect): DEFSYM them.
3254 (x_handle_selection_request): Pass Qx_sent_selection_functions
3255 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3256 (x_handle_selection_clear,x_clear_frame_selections):
3257 Pass Qx_lost_selection_functions rather than
3258 Vx_lost_selection_functions to Frun_hook_with_args.
3260 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3262 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3263 The old code sometimes used this field without initializing it.
3265 * alloc.c (gc_sweep): Don't read past end of array.
3266 In theory, the old code could also have corrupted Emacs internals,
3267 though it'd be very unlikely.
3269 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3271 * character.c (Fcharacterp): Don't advertise optional ignored
3272 argument. (Bug#4026)
3274 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3276 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3279 * window.c (Fset_window_start): Doc fix (bug#4199).
3280 (Fset_window_hscroll): Ditto.
3282 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3284 Fix minor new problems caught by GCC 4.6.1.
3285 * term.c (init_tty): Remove unused local.
3286 * xsettings.c (store_monospaced_changed): Define this function only
3287 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3290 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3292 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3294 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3296 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3297 are the mini-buffer and the echo area (bug#3320).
3299 * term.c (init_tty): Remove support for supdup, c10 and perq
3300 terminals, which are no longer supported (bug#1482).
3302 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3304 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3306 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3308 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3309 for non-popups (Bug#3642).
3311 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3313 * alloc.c (reset_malloc_hooks): Protoize.
3314 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3315 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3316 * cm.c (losecursor): Likewise.
3317 * data.c (fmod): Likewise.
3318 * dispnew.c (swap_glyphs_in_rows): Likewise.
3319 * emacs.c (memory_warning_signal): Likewise.
3320 * floatfns.c (float_error): Likewise.
3321 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3322 (otf_open, font_otf_capability, generate_otf_features)
3323 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3325 * image.c (pbm_read_file): Likewise.
3326 * indent.c (string_display_width): Likewise.
3327 * intervals.c (check_for_interval, search_for_interval)
3328 (inc_interval_count, count_intervals, root_interval)
3329 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3330 * lread.c (defalias): Likewise.
3331 * ralloc.c (r_alloc_check): Likewise.
3332 * regex.c (set_image_of_range_1, set_image_of_range)
3333 (regex_grow_registers): Likewise.
3334 * sysdep.c (strerror): Likewise.
3335 * termcap.c (valid_filename_p, tprint, main): Likewise.
3336 * tparam.c (main): Likewise.
3337 * unexhp9k800.c (run_time_remap, save_data_space)
3338 (update_file_ptrs, read_header, write_header, calculate_checksum)
3339 (copy_file, copy_rest, display_header): Likewise.
3340 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3342 * xdisp.c (check_it): Likewise.
3343 * xfaces.c (register_color, unregister_color, unregister_colors):
3345 * xfns.c (print_fontset_result): Likewise.
3346 * xrdb.c (member, fatal, main): Likewise.
3348 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3350 Fix minor problems found by static checking (Bug#9031).
3351 * chartab.c (char_table_set_range, map_sub_char_table):
3352 Remove unused locals.
3353 (uniprop_table): Now static.
3354 * composite.c (_work_char): Remove unused static var.
3356 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3358 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3360 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3362 * gtkutil.c (qttip_cb): Remove code without function.
3364 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3366 * w32.c (pthread_sigmask): New stub.
3368 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3370 Use pthread_sigmask, not sigprocmask (Bug#9010).
3371 sigprocmask is portable only for single-threaded applications, and
3372 Emacs can be multi-threaded when it uses GTK.
3373 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3375 * callproc.c (Fcall_process):
3376 * process.c (create_process):
3377 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3378 Use pthread_sigmask, not sigprocmask.
3380 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3382 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3383 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3386 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3388 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3389 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3390 (xg_hide_tooltip): Fix comment.
3392 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3393 in registerServicesMenuSendTypes.
3394 (validRequestorForSendType): Don't check ns_return_types.
3396 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3399 2011-07-08 Jason Rumney <jasonr@gnu.org>
3401 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3402 frame struct members of non-existent frames (Bug#6284).
3404 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3406 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3407 variable firstTime not needed on OSX >= 10.6.
3408 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3409 >= 10.5. Use setKnobProportion, setDoubleValue.
3411 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3412 (MAC_OS_X_VERSION_10_5): Define if not defined.
3413 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3414 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3415 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3417 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3418 cString and lossyCString on OSX >= 10.4
3420 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3421 sizeToFit on OSX >= 10.2.
3423 * nsimage.m (allocInitFromFile): Don't use deprecated method
3424 bestRepresentationForDevice on OSX >= 10.6.
3426 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3429 * emacs.c: Declare unexec_init_emacs_zone.
3431 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3433 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3435 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3436 on svcsMenu (Bug#8842).
3438 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3440 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3442 * nsterm.m (QUTF8_STRING): Declare.
3443 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3444 (validRequestorForSendType): Return type is (id).
3445 Change indexOfObjectIdenticalTo to indexOfObject.
3446 Check if we have local selection before returning self (Bug#8842).
3447 (writeSelectionToPasteboard): Put local selection into paste board
3448 if we have a local selection (Bug#8842).
3449 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3451 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3452 (ns_get_local_selection): Declare.
3454 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3456 * keymap.c (describe_map_tree): Don't insert a double newline at
3457 the end of the buffer (bug#1169) and return whether we inserted
3460 * callint.c (Fcall_interactively): Change "reading args" to
3461 "providing args" to try to clarify what it does (bug#1010).
3463 2011-07-07 Kenichi Handa <handa@m17n.org>
3465 * composite.c (composition_compute_stop_pos): Ignore a static
3466 composition starting before CHARPOS (Bug#8915).
3468 * xdisp.c (handle_composition_prop): Likewise.
3470 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3472 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3475 2011-07-07 Kenichi Handa <handa@m17n.org>
3477 * character.h (unicode_category_t): New enum type.
3479 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3480 (Qchar_code_property_table): New variable.
3481 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3482 (UNIPROP_COMPRESSED_FORM_P): New macros.
3483 (char_table_ascii): Uncompress the compressed values.
3484 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3485 Uncompress the compressed values.
3486 (sub_char_table_ref_and_range): Likewise.
3487 (char_table_ref_and_range): Uncompress the compressed values.
3488 (sub_char_table_set): New arg is_uniprop. Callers changed.
3489 Uncompress the compressed values.
3490 (sub_char_table_set_range): Args changed. Callers changed.
3491 (char_table_set_range): Adjuted for the above change.
3492 (map_sub_char_table): Delete args default_val and parent. Add arg
3493 top. Give decoded values to a Lisp function.
3494 (map_char_table): Adjust for the above change. Give decoded
3495 values to a Lisp function. Gcpro more variables.
3496 (uniprop_table_uncompress)
3497 (uniprop_decode_value_run_length): New functions.
3498 (uniprop_decoder, uniprop_decoder_count): New variables.
3499 (uniprop_get_decoder, uniprop_encode_value_character)
3500 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3502 (uniprop_encoder, uniprop_encoder_count): New variables.
3503 (uniprop_get_encoder, uniprop_table)
3504 (Funicode_property_table_internal, Fget_unicode_property_internal)
3505 (Fput_unicode_property_internal): New functions.
3506 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3507 Sunicode_property_table_internal, Sget_unicode_property_internal,
3508 and Sput_unicode_property_internal. Defvar_lisp
3509 char-code-property-alist.
3511 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3512 Vunicode_category_table.
3514 * font.c (font_range): Adjust for the change of
3515 Vunicode_category_table.
3517 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3519 * m/iris4d.h: Remove file, move contents ...
3520 * s/irix6-5.h: ... here.
3522 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3524 Remove unportable assumption about struct layout (Bug#8884).
3525 * alloc.c (mark_buffer):
3526 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3527 (clone_per_buffer_values): Don't assume that
3528 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3529 This isn't true in general, and it's particularly not true
3530 if Emacs is configured with --with-wide-int.
3531 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3532 New macros, used in the buffer.c change.
3534 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3536 * xsettings.c: Use both GConf and GSettings if both are available.
3537 (store_config_changed_event): Add comment.
3538 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3539 (store_tool_bar_style_changed): New functions.
3540 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3541 (struct xsettings): Move font inside HAVE_XFT.
3542 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3543 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3544 Move inside HAVE_XFT.
3545 (something_changed_gsettingsCB): Rename from something_changedCB.
3546 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3548 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3549 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3550 (something_changed_gconfCB): Rename from something_changedCB.
3551 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3552 (parse_settings): Move check for font inside HAVE_XFT.
3553 (read_settings, apply_xft_settings): Add comment.
3554 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3555 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3556 call store_font_name_changed.
3557 (xft_settings_event): Add comment.
3558 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3559 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3560 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3561 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3562 (xsettings_initialize): Call init_gsettings last.
3563 (xsettings_get_system_font, xsettings_get_system_normal_font):
3566 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3568 Random fixes. E.g., (random) never returned negative values.
3569 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3570 subseconds part to the entropy, as that's a bit more random.
3571 Prefer signed to unsigned, since the signedness doesn't matter and
3572 in general we prefer signed. When given a limit, use a
3573 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3574 latter isn't right if USE_2_TAGS_FOR_INTS.
3575 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3576 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3578 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3580 * textprop.c (text_property_stickiness):
3581 Obey Vtext_property_default_nonsticky.
3582 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3583 * w32fns.c (syms_of_w32fns):
3584 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3586 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3588 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3589 This is more efficient than Ffile_directory_p and avoids a minor race.
3591 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3593 * buffer.c (Foverlay_put): Say what the return value is
3596 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3597 is a directory before asking whether to use the file name
3599 (barf_or_query_if_file_exists): Make the "File is a directory"
3600 error be more correct.
3602 * fns.c (Frequire): Remove the mention of the .gz files, since
3603 that's installation-specific, but keep the mention of
3604 `get-load-suffixes'.
3606 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3608 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3609 Report string overflow if the output is too long.
3611 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3613 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3614 (syms_of_gnutls): Remove duplicate DEFSYM for
3615 Qgnutls_bootprop_verify_hostname_error, an error for
3616 Qgnutls_bootprop_verify_error (which is no longer used).
3618 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3619 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3620 Also (re)move comments that are misplaced or no longer relevant.
3622 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3624 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3626 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3628 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3629 and background color parameters if they have been changed.
3631 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3633 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3635 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3637 * xsettings.c (SYSTEM_FONT): Define only when used.
3638 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3640 * keymap.c (access_keymap_1): Now static.
3642 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3644 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3645 leave any prefix arg for the up event (Bug#1586).
3647 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3649 * lread.c (syms_of_lread): Mention single symbols defined by
3650 `defvar' or `defconst' (bug#7154).
3652 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3653 (Frequire): Mention get-load-suffixes.
3655 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3657 * window.h (window): Remove clone_number slot.
3658 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3660 (make_parent_window, make_window, saved_window)
3661 (Fset_window_configuration, save_window_save): Don't deal with
3663 * buffer.c (Qclone_number): Remove declaration.
3664 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3666 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3668 Add multiple inheritance to keymaps.
3669 * keymap.c (Fmake_composed_keymap): New function.
3670 (Fset_keymap_parent): Simplify.
3671 (fix_submap_inheritance): Remove.
3672 (access_keymap_1): New function extracted from access_keymap to handle
3673 embedded parents and handle lists of maps.
3674 (access_keymap): Use it.
3675 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3676 (Fcopy_keymap): Handle embedded parents.
3677 (Fcommand_remapping, define_as_prefix): Simplify.
3678 (Fkey_binding): Simplify.
3679 (syms_of_keymap): Move minibuffer-local-completion-map,
3680 minibuffer-local-filename-completion-map,
3681 minibuffer-local-must-match-map, and
3682 minibuffer-local-filename-must-match-map to Elisp.
3683 (syms_of_keymap): Defsubr make-composed-keymap.
3684 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3685 (parse_menu_item): Trivial simplification.
3687 2011-07-01 Glenn Morris <rgm@gnu.org>
3689 * Makefile.in (SETTINGS_LIBS): Fix typo.
3691 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3693 * coding.c (Fencode_coding_string): Record the last coding system
3694 used, as the function doc string says (bug#8738).
3696 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3698 * xsettings.c (store_monospaced_changed): Take new font as arg and
3699 check for change against current_mono_font.
3700 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3701 (emacs_settings_constructor, emacs_settings_get_property)
3702 (emacs_settings_set_property, emacs_settings_class_init)
3703 (emacs_settings_init, gsettings_obj): Remove.
3704 (something_changedCB): New function for HAVE_GSETTINGS.
3705 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3706 with value as argument.
3707 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3708 g_settings_new (Bug#8967). Do not create gsettings_obj.
3709 Remove calls to g_settings_bind. Connect something_changedCB to
3712 * xgselect.c: Add defined (HAVE_GSETTINGS).
3713 (xgselect_initialize): Ditto.
3715 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3716 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3719 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3721 * eval.c (struct backtrace): Simplify and port the data structure.
3722 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3723 signed bit field, as this assumption is not portable and it makes
3724 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3725 "char debug_on_exit : 1" as this is not portable either; instead,
3726 use the portable "unsigned int debug_on_exit : 1". Remove unused
3727 member evalargs. Remove obsolete comments about cc bombing out.
3729 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3731 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3732 Let HAVE_GSETTINGS override HAVE_GCONF.
3733 (store_monospaced_changed): New function.
3734 (EMACS_SETTINGS): A new type derived from GObject to handle
3735 GSettings notifications.
3736 (emacs_settings_constructor, emacs_settings_get_property)
3737 (emacs_settings_set_property, emacs_settings_class_init):
3739 (gsettings_client, gsettings_obj): New variables.
3740 (GSETTINGS_SCHEMA): New define.
3741 (something_changedCB): Call store_monospaced_changed.
3742 (init_gsettings): New function.
3743 (xsettings_initialize): Call init_gsettings.
3744 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3747 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3750 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3752 * window.c (resize_root_window, grow_mini_window)
3753 (shrink_mini_window): Rename Qresize_root_window to
3754 Qwindow_resize_root_window and Qresize_root_window_vertically to
3755 Qwindow_resize_root_window_vertically.
3757 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3759 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3761 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3763 * makefile.w32-in: Redesign dependencies so they reflect more
3764 clearly which files are directly included by each source file,
3765 and not through other includes.
3767 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3769 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3770 (sort_overlays, overlay_strings): When an overlay's clone number
3771 matches the window's clone number process the overlay even if
3772 the overlay's window property doesn't match the current window.
3774 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3775 (Fwindow_hchild): Rename to Fwindow_left_child.
3776 (Fwindow_next): Rename to Fwindow_next_sibling.
3777 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3778 (resize_window_check): Rename to window_resize_check.
3779 (resize_window_apply): Rename to window_resize_apply.
3780 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3781 (Fdelete_other_windows_internal, resize_frame_windows)
3782 (Fsplit_window_internal, Fdelete_window_internal)
3783 (grow_mini_window, shrink_mini_window)
3784 (Fresize_mini_window_internal): Fix callers accordingly.
3786 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3788 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3789 (emacs_fixed_set_min_size): Remove.
3790 (emacs_fixed_new): Take frame as argument.
3792 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3793 (_EmacsFixedPrivate): Remove minwidth/height.
3794 Add struct frame *f.
3795 (emacs_fixed_init): Initialize priv->f.
3796 (get_parent_class, emacs_fixed_set_min_size): Remove.
3797 (emacs_fixed_new): Set priv->f to argument.
3798 (emacs_fixed_get_preferred_width)
3799 (emacs_fixed_get_preferred_height): Use min_width/height from
3800 frames size_hint to set minimum and natural (Bug#8919).
3801 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3802 and use min_width/height from frames size_hint to set
3803 min_width/height (Bug#8919).
3805 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3806 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3809 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3811 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3812 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3815 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3817 * process.c (wait_reading_process_output): Bypass select if
3818 waiting for a cell while ignoring keyboard input, and input is
3819 pending. Suggested by Jan Djärv (Bug#8869).
3821 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3823 Use gnulib's dup2 module instead of rolling our own.
3824 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3826 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3828 * dispnew.c (scrolling_window): Before scrolling, turn off a
3829 mouse-highlight in the window being scrolled.
3831 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3833 Move DEFSYM to lisp.h and use everywhere.
3835 * character.h (DEFSYM): Move declaration...
3836 * lisp.h (DEFSYM): ...here.
3842 * w32select.c: Don't include character.h.
3844 * alloc.c (syms_of_alloc):
3845 * buffer.c (syms_of_buffer):
3846 * bytecode.c (syms_of_bytecode):
3847 * callint.c (syms_of_callint):
3848 * casefiddle.c (syms_of_casefiddle):
3849 * casetab.c (init_casetab_once):
3850 * category.c (init_category_once, syms_of_category):
3851 * ccl.c (syms_of_ccl):
3852 * cmds.c (syms_of_cmds):
3853 * composite.c (syms_of_composite):
3854 * dbusbind.c (syms_of_dbusbind):
3855 * dired.c (syms_of_dired):
3856 * dispnew.c (syms_of_display):
3857 * doc.c (syms_of_doc):
3858 * editfns.c (syms_of_editfns):
3859 * emacs.c (syms_of_emacs):
3860 * eval.c (syms_of_eval):
3861 * fileio.c (syms_of_fileio):
3862 * fns.c (syms_of_fns):
3863 * frame.c (syms_of_frame):
3864 * fringe.c (syms_of_fringe):
3865 * insdel.c (syms_of_insdel):
3866 * keymap.c (syms_of_keymap):
3867 * lread.c (init_obarray, syms_of_lread):
3868 * macros.c (syms_of_macros):
3869 * msdos.c (syms_of_msdos):
3870 * print.c (syms_of_print):
3871 * process.c (syms_of_process):
3872 * search.c (syms_of_search):
3873 * sound.c (syms_of_sound):
3874 * syntax.c (init_syntax_once, syms_of_syntax):
3875 * terminal.c (syms_of_terminal):
3876 * textprop.c (syms_of_textprop):
3877 * undo.c (syms_of_undo):
3878 * w32.c (globals_of_w32):
3879 * window.c (syms_of_window):
3880 * xdisp.c (syms_of_xdisp):
3881 * xfaces.c (syms_of_xfaces):
3882 * xfns.c (syms_of_xfns):
3883 * xmenu.c (syms_of_xmenu):
3884 * xsettings.c (syms_of_xsettings):
3885 * xterm.c (syms_of_xterm): Use DEFSYM.
3887 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3889 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3891 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3893 Integer and buffer overflow fixes (Bug#8873).
3895 * print.c (printchar, strout): Check for string overflow.
3896 (PRINTPREPARE, printchar, strout):
3897 Don't set size unless allocation succeeds.
3899 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3900 for sizes. Check for string overflow more accurately.
3901 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3903 * macros.c: Integer and buffer overflow fixes.
3904 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3905 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3906 Use ptrdiff_t, not int, for sizes.
3907 Don't increment bufsize until after realloc succeeds.
3908 Check for size-calculation overflow.
3909 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3911 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3913 * lread.c: Integer overflow fixes.
3914 (read_integer): Radix is now EMACS_INT, not int,
3915 to improve quality of diagnostics for out-of-range radices.
3916 Calculate buffer size correctly for out-of-range radices.
3917 (read1): Check for integer overflow in radices, and in
3918 read-circle numbers.
3919 (read_escape): Avoid int overflow.
3920 (Fload, openp, read_buffer_size, read1)
3921 (substitute_object_recurse, read_vector, read_list, map_obarray):
3922 Use ptrdiff_t, not int, for sizes.
3923 (read1): Use EMACS_INT, not int, for sizes.
3924 Check for size overflow.
3926 * image.c (cache_image): Check for size arithmetic overflow.
3928 * lread.c: Integer overflow issues.
3929 (saved_doc_string_size, saved_doc_string_length)
3930 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3931 Now ptrdiff_t, not int.
3932 (read1): Don't assume doc string length fits in int. Check for
3933 out-of-range doc string lengths.
3934 (read_list): Don't assume file position fits in int.
3935 (read_escape): Check for hex character overflow.
3937 2011-06-22 Leo Liu <sdl.web@gmail.com>
3939 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3940 Move to minibuffer.el.
3942 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3944 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3945 The following patches are for when GLYPH_DEBUG && !XASSERT.
3946 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3947 * dispnew.c (flush_stdout):
3948 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3949 Mark as externally visible.
3950 * dispnew.c (check_window_matrix_pointers): Now static.
3951 * dispnew.c (window_to_frame_vpos):
3952 * xfns.c (unwind_create_frame):
3953 * xterm.c (x_check_font): Remove unused local.
3954 * scroll.c (CHECK_BOUNDS):
3955 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3956 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3957 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3958 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3959 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3961 (debug_method_add): Use va_list and vsprintf rather than relying
3962 on undefined behavior with wrong number of arguments.
3963 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3964 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3965 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3966 since we're not interested in debugging glyphs with old libraries.
3967 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3968 GCC 4.6.0's static checking.
3970 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3972 Integer overflow and signedness fixes (Bug#8873).
3973 A few related buffer overrun fixes, too.
3975 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3977 * dispextern.h (struct face.stipple):
3978 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3979 (x_bitmap_mask, x_allocate_bitmap_record)
3980 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3981 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3982 (x_create_bitmap_from_xpm_data):
3983 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3984 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3986 * xfaces.c (load_pixmap):
3987 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3988 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3989 (.bitmaps_last, struct x_output.icon_bitmap):
3990 Use ptrdiff_t, not int, for bitmap indexes.
3991 (x_allocate_bitmap_record): Check for size overflow.
3992 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3994 Use ptrdiff_t, not int, for overlay counts.
3995 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3996 * editfns.c (overlays_around, get_pos_property):
3997 * textprop.c (get_char_property_and_overlay):
3998 * xdisp.c (next_overlay_change, note_mouse_highlight):
3999 * xfaces.c (face_at_buffer_position):
4000 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4001 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4002 (Fnext_overlay_change, Fprevious_overlay_change)
4003 (mouse_face_overlay_overlaps, Foverlays_in):
4004 Use ptrdiff_t, not int, for sizes.
4005 (overlays_at, overlays_in): Check for size-calculation overflow.
4007 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4009 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4010 (x_session_initialize): Do not assume string length fits in int.
4012 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4013 This is unlikely, but can occur if DPI is outlandish.
4015 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4016 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4018 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4019 * xrdb.c (magic_file_p, search_magic_path):
4020 Omit last arg SUFFIX; it was always 0. All callers changed.
4021 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4023 * xfont.c (xfont_match): Avoid need for strlen.
4025 * xfns.c: Don't assume strlen fits in int.
4026 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4028 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4029 not unsigned long, as we prefer signed integers. All callers changed.
4030 Detect integer overflow in repeat count.
4031 (message_dolog): Don't assume print length fits in 39 bytes.
4032 (display_mode_element): Don't assume strlen fits in int.
4034 * termcap.c: Don't assume sizes fit in int and never overflow.
4035 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4036 (gobble_line): Check for size-calculation overflow.
4038 * minibuf.c (Fread_buffer):
4039 * lread.c (intern, intern_c_string):
4040 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4041 Don't assume string length fits in int.
4043 * keyboard.c (parse_tool_bar_item):
4044 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4046 * font.c: Don't assume string length fits in int.
4047 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4048 Use ptrdiff_t, not int.
4049 (font_intern_prop): Don't assume string length fits in int.
4050 Don't assume integer property fits in fixnum.
4051 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4053 * filelock.c: Fix some buffer overrun and integer overflow issues.
4054 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4055 Reformulate so as not to need the command string.
4056 Invoke gzip -cd rather than gunzip, as it's more portable.
4057 (lock_info_type, lock_file_1, lock_file):
4058 Don't assume pid_t and time_t fit in unsigned long.
4059 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4060 (current_lock_owner): Prefer signed type for sizes.
4061 Use memcpy, not strncpy, where memcpy is what is really wanted.
4062 Don't assume (via atoi) that time_t and pid_t fit in int.
4063 Check for time_t and/or pid_t out of range, e.g., via a network share.
4064 Don't alloca where an auto var works fine.
4066 * fileio.c: Fix some integer overflow issues.
4067 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4068 Don't assume string length fits in int.
4069 (directory_file_name): Don't assume string length fits in long.
4070 (make_temp_name): Don't assume pid fits in int, or that its print
4071 length is less than 20.
4073 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4075 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4077 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4079 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4080 We prefer signed integers, even for size calculations.
4082 * emacs.c: Don't assume string length fits in 'int'.
4083 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4084 (main): Don't invoke strlen when not needed.
4086 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4087 (XD_DEBUG_MESSAGE): Don't waste a byte.
4089 * callproc.c (getenv_internal_1, getenv_internal)
4091 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4093 * lread.c (invalid_syntax): Omit length argument.
4094 All uses changed. This doesn't fix a bug, but it simplifies the
4095 code away from its former Hollerith-constant appearance, and it's
4096 one less 'int' to worry about when looking at integer-overflow issues.
4097 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4099 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4100 This didn't break anything, but it didn't help either.
4101 It's confusing to put a bogus integer in a place where the actual
4102 value does not matter.
4103 (LIST_END_P): Remove unused macro and its bogus comment.
4104 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4106 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4107 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4109 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4110 We prefer signed types, and the value cannot exceed the EMACS_INT
4111 range anyway (because otherwise the length would not be representable).
4112 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4113 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4114 This avoids a GCC warning when WIDE_EMACS_INT.
4116 * indent.c (sane_tab_width): New function.
4117 (current_column, scan_for_column, Findent_to, position_indentation)
4118 (compute_motion): Use it. This is just for clarity.
4119 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4121 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4123 * lisp.h (lint_assume): New macro.
4124 * composite.c (composition_gstring_put_cache):
4125 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4127 * editfns.c, insdel.c:
4128 Omit unnecessary forward decls, to simplify future changes.
4130 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4132 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4134 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4135 Use much-faster test for byte-length change.
4136 Don't assume string byte-length fits in 'int'.
4137 Check that character arg fits in 'int'.
4138 (mapcar1): Declare byte as byte, for clarity.
4140 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4142 * fns.c (concat): Catch string overflow earlier.
4143 Do not rely on integer wraparound.
4145 * dispextern.h (struct it.overlay_strings_charpos)
4146 (struct it.selective): Now EMACS_INT, not int.
4147 * xdisp.c (forward_to_next_line_start)
4148 (back_to_previous_visible_line_start)
4149 (reseat_at_next_visible_line_start, next_element_from_buffer):
4150 Don't arbitrarily truncate the value of 'selective' to int.
4152 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4154 * composite.c: Don't truncate sizes to 'int'.
4155 (composition_gstring_p, composition_reseat_it)
4156 (composition_adjust_point): Use EMACS_INT, not int.
4157 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4158 not EMACS_UINT, for indexes.
4160 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4162 * buffer.c: Include <verify.h>.
4163 (struct sortvec.priority, struct sortstr.priority):
4164 Now EMACS_INT, not int.
4165 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4166 (struct sortstr.size, record_overlay_string)
4167 (struct sortstrlist.size, struct sortlist.used):
4168 Don't truncate size to int.
4169 (record_overlay_string): Check for size-calculation overflow.
4170 (init_buffer_once): Check at compile-time, not run-time.
4172 2011-06-22 Jim Meyering <meyering@redhat.com>
4174 Don't leak an XBM-image-sized buffer
4175 * image.c (xbm_load): Free the image buffer after using it.
4177 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4180 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4181 that Sun C diagnosed.
4182 * fns.c (secure_hash): Fix pointer signedness issue.
4183 * intervals.c (static_offset_intervals): New function.
4184 (offset_intervals): Use it.
4186 2011-06-21 Leo Liu <sdl.web@gmail.com>
4189 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4192 * fns.c (secure_hash): Rename from crypto_hash_function and change
4193 the first arg to accept symbols.
4194 (Fsecure_hash): New primitive.
4195 (syms_of_fns): New symbols.
4197 2011-06-20 Deniz Dogan <deniz@dogan.se>
4199 * process.c (Fset_process_buffer): Clarify return value in
4202 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4204 * dispnew.c (add_window_display_history): Use BVAR.
4206 * xdisp.c (debug_method_add): Use BVAR.
4207 (check_window_end, dump_glyph_matrix, dump_glyph)
4208 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4210 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4213 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4214 check till after the cache is created in init_frame_faces.
4216 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4218 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4220 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4222 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4223 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4224 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4226 Improve buffer-overflow checking (Bug#8873).
4227 * fileio.c (Finsert_file_contents):
4228 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4229 Remove the old (too-loose) buffer overflow checks.
4230 They weren't needed, since make_gap checks for buffer overflow.
4231 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4232 The old code merely checked for Emacs fixnum overflow, and relied
4233 on undefined (wraparound) behavior. The new code avoids undefined
4234 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4236 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4237 Tune. Don't use wider integers than needed. Don't use alloca.
4238 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4240 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4242 * insdel.c, lisp.h (buffer_overflow): New function.
4243 (insert_from_buffer_1, replace_range, replace_range_2):
4244 * insdel.c (make_gap_larger):
4245 * editfns.c (Finsert_char):
4246 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4248 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4250 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4252 Integer overflow and signedness fixes (Bug#8873).
4254 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4255 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4257 * fileio.c: Don't assume EMACS_INT fits in off_t.
4258 (emacs_lseek): New static function.
4259 (Finsert_file_contents, Fwrite_region): Use it.
4260 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4262 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4264 * fns.c: Don't overflow int when computing a list length.
4265 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4266 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4267 truncation on 64-bit hosts. Check for QUIT every
4268 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4269 faster and is responsive enough.
4270 (Flength): Report an error instead of overflowing an integer.
4271 (Fsafe_length): Return a float if the value is not representable
4272 as a fixnum. This shouldn't happen except in contrived situations.
4273 (Fnthcdr, Fsort): Don't assume list length fits in int.
4274 (Fcopy_sequence): Don't assume vector length fits in int.
4276 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4277 (header_size, word_size): New constants.
4278 (allocate_vectorlike): Don't check size overflow here.
4279 (allocate_vector): Check it here instead, since this is the only
4280 caller of allocate_vectorlike that could cause overflow.
4281 Check that the new vector's length is representable as a fixnum.
4283 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4284 The previous code was bogus. For example, next_almost_prime (32)
4285 returned 39, which is undesirable as it is a multiple of 3; and
4286 next_almost_prime (24) returned 25, which is a multiple of 5 so
4287 why was the code bothering to check for multiples of 7?
4289 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4291 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4293 Variadic C functions now count arguments with ptrdiff_t.
4294 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4295 Back then I didn't know that the Emacs coding style prefers signed int.
4296 Also, in the meantime I found a few more instances where arguments
4297 were being counted with int, which may truncate counts on 64-bit
4298 machines, or EMACS_INT, which may be unnecessarily wide.
4299 * lisp.h (struct Lisp_Subr.function.aMANY)
4300 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4301 Arg counts are now ptrdiff_t, not size_t.
4302 All variadic functions and their callers changed accordingly.
4303 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4304 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4305 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4306 * callint.c (Fcall_interactively): Check arg count for overflow,
4307 to avoid potential buffer overrun. Use signed char, not 'int',
4308 for 'varies' array, so that we needn't bother to check its size
4309 calculation for overflow.
4310 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4311 * eval.c (apply_lambda):
4312 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4313 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4314 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4316 * callint.c (Fcall_interactively): Don't use index var as event count.
4318 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4319 * mem-limits.h (SIZE): Remove; no longer used.
4321 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4323 Remove unnecessary casts.
4324 * xterm.c (x_term_init):
4325 * xfns.c (x_set_border_pixel):
4326 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4327 These aren't needed now that we assume ANSI C.
4329 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4330 It's more likely to cause problems (due to unsigned overflow)
4333 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4335 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4337 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4339 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4341 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4343 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4345 GLYPH_CODE_FACE returns EMACS_INT, not int.
4346 * dispextern.h (merge_faces):
4347 * xfaces.c (merge_faces):
4348 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4349 Don't assume EMACS_INT fits in int.
4351 * character.h (CHAR_VALID_P): Remove unused parameter.
4352 * fontset.c, lisp.h, xdisp.c: All uses changed.
4354 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4356 * fns.c (concat): Minor tuning based on overflow analysis.
4357 This doesn't fix any bugs. Use int to hold character, instead
4358 of constantly refetching from Emacs object. Use XFASTINT, not
4359 XINT, for value known to be a character. Don't bother comparing
4360 a single byte to 0400, as it's always less.
4362 * floatfns.c (Fexpt):
4363 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4365 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4368 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4370 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4371 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4372 incorrectly succeed when S was a string, because 4294967386 was
4373 truncated before it was used.
4375 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4376 Otherwise, an out-of-range integer could cause undefined behavior
4379 * composite.c: Use int, not EMACS_INT, for characters.
4380 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4381 EMACS_INT, for values that are known to be in character range.
4382 This doesn't fix any bugs but is the usual style inside Emacs and
4383 may generate better code on 32-bit machines.
4385 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4386 This is for reasons similar to the recent CHAR_STRING fix.
4387 * charset.c (Fencode_char): Check that character arg is actually
4388 a character. Pass an int to ENCODE_CHAR.
4389 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4390 wider than 'int', as a compile-time check to prevent future regressions
4393 * character.c (char_string): Remove unnecessary casts.
4395 Make sure a 64-bit char is never passed to CHAR_STRING.
4396 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4397 by silently ignoring the top 32 bits, allowing some values
4398 that were far too large to be valid characters.
4399 * character.h: Include <verify.h>.
4400 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4401 arguments are no wider than unsigned, as a compile-time check
4402 to prevent future regressions in this area.
4404 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4405 (Fsubst_char_in_region):
4407 * xdisp.c (decode_mode_spec_coding):
4408 Adjust to CHAR_STRING's new requirement.
4409 * editfns.c (Finsert_char, Fsubst_char_in_region):
4410 * fns.c (concat): Check that character args are actually
4411 characters. Without this test, these functions did the wrong
4412 thing with wildly out-of-range values on 64-bit hosts.
4414 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4415 These casts should not be needed on 32-bit hosts, either.
4416 * keyboard.c (read_char):
4417 * lread.c (Fload): Remove casts to unsigned.
4419 * lisp.h (UNSIGNED_CMP): New macro.
4420 This fixes comparison bugs on 64-bit hosts.
4421 (ASCII_CHAR_P): Use it.
4422 * casefiddle.c (casify_object):
4423 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4424 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4425 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4426 * dispextern.h (FACE_FROM_ID):
4427 * keyboard.c (read_char): Use UNSIGNED_CMP.
4429 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4430 not to EMACS_INT, to avoid GCC warning.
4432 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4434 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4435 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4436 isn't needed on 32-bit machines.
4438 * buffer.c (Fgenerate_new_buffer_name):
4439 Use EMACS_INT for count, not int.
4440 (advance_to_char_boundary): Return EMACS_INT, not int.
4442 * data.c (Qcompiled_function): Now static.
4444 * window.c (window_body_lines): Now static.
4446 * image.c (gif_load): Rename local to avoid shadowing.
4448 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4449 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4450 * alloc.c (make_save_value): Integer argument is now of type
4452 (mark_object): Use ptrdiff_t, not int.
4453 * lisp.h (pD): New macro.
4454 * print.c (print_object): Use it.
4456 * alloc.c: Use EMACS_INT, not int, to count objects.
4457 (total_conses, total_markers, total_symbols, total_vector_size)
4458 (total_free_conses, total_free_markers, total_free_symbols)
4459 (total_free_floats, total_floats, total_free_intervals)
4460 (total_intervals, total_strings, total_free_strings):
4461 Now EMACS_INT, not int. All uses changed.
4462 (Fgarbage_collect): Compute overall total using a double, so that
4463 integer overflow is less likely to be a problem. Check for overflow
4464 when converting back to an integer.
4465 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4466 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4467 These were 'int' variables that could overflow on 64-bit hosts;
4468 they were never used, so remove them instead of repairing them.
4469 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4470 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4471 Previously, this ceilinged at INT_MAX, but that doesn't work on
4473 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4475 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4476 (allocate_vectorlike): Check for ptrdiff_t overflow.
4477 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4478 when a (possibly-narrower) signed value would do just as well.
4479 We prefer using signed arithmetic, to avoid comparison confusion.
4481 * alloc.c: Catch some string size overflows that we were missing.
4482 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4483 for convenience in STRING_BYTES_MAX.
4484 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4485 The definition here is exact; the one in lisp.h was approximate.
4486 (allocate_string_data): Check for string overflow. This catches
4487 some instances we weren't catching before. Also, it catches
4488 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4489 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4490 and ptrdiff_t and EMACS_INT are both 64 bits.
4492 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4493 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4494 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4496 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4498 * alloc.c (Fmake_string): Check for out-of-range init.
4500 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4502 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4504 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4506 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4507 xg_get_default_scrollbar_width.
4509 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4510 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4511 (style_changed_cb): Call update_theme_scrollbar_width and call
4512 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4513 all frames (Bug#8505).
4514 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4515 Call gtk_window_set_resizable if HAVE_GTK3.
4516 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4517 and height if HAVE_GTK3 (Bug#8505).
4518 (scroll_bar_width_for_theme): New variable.
4519 (update_theme_scrollbar_width): New function.
4520 (xg_get_default_scrollbar_width): Move code to
4521 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4522 (xg_initialize): Call update_theme_scrollbar_width.
4524 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4526 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4528 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4530 * frame.c (make_frame): Call other_buffer_safely instead of
4533 * window.c (temp_output_buffer_show): Call display_buffer with
4534 second argument Vtemp_buffer_show_specifiers and reset latter
4535 immediately after the call.
4536 (Vtemp_buffer_show_specifiers): New variable.
4537 (auto_window_vscroll_p, next_screen_context_lines)
4538 (Vscroll_preserve_screen_position): Remove leading asterisks from
4541 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4543 Fix minor problems found by GCC 4.6.0 static checking.
4544 * buffer.c (Qclone_number): Remove for now, as it's unused.
4545 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4546 (record_buffer): Remove unused local.
4547 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4548 (set_frame_buffer_list): Remove; unused.
4549 * frame.h (other_visible_frames): Remove decl.
4550 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4551 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4552 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4554 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4555 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4556 Define only if HAVE_GPM.
4557 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4558 (update_hints_inhibit): Remove; never set. All uses removed.
4559 * widgetprv.h (emacsFrameClassRec): Remove decl.
4560 * window.c (delete_deletable_window): Now returns void, since it
4561 wasn't returning anything.
4562 (compare_window_configurations): Remove unused locals.
4563 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4564 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4565 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4566 the same widths as pointers. This follows up on the 2011-05-06 patch.
4567 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4568 * xterm.h: Likewise.
4569 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4571 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4573 * makefile.w32-in: Update dependencies.
4574 (LISP_H): Add lib/intprops.h.
4576 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4578 * image.c (gif_load): Add animation frame delay to the metadata.
4579 (syms_of_image): Use DEFSYM. New symbol `delay'.
4581 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4583 * window.c (delete_deletable_window): Re-add.
4584 (Fset_window_configuration): Rewrite to handle dead buffers and
4585 consequently deletable windows.
4586 (window_tree, Fwindow_tree): Remove. Supply functionality in
4588 (compare_window_configurations): Simplify code.
4590 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4592 * image.c (imagemagick_load_image): Fix type mismatch.
4593 (Fimagemagick_types): Likewise.
4595 * window.h (replace_buffer_in_windows): Declare.
4597 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4599 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4600 Qclone_number. Remove external declaration of Qdelete_window.
4601 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4603 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4604 Run Qbuffer_list_update_hook if allowed.
4605 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4606 buffer list implementation.
4607 (other_buffer_safely): New function.
4608 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4609 calls to replace_buffer_in_windows and
4610 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4612 (record_buffer): Inhibit quitting and rewrite using quittable
4613 functions. Run Qbuffer_list_update_hook if allowed.
4614 (Frecord_buffer, Funrecord_buffer): New functions.
4615 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4616 Move switch-to-buffer to window.el.
4617 (bury-buffer): Move to window.el.
4618 (Vbuffer_list_update_hook): New variable.
4620 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4623 * window.h (resize_frame_windows): Move up in code.
4624 (Fwindow_frame): Remove EXFUN.
4625 (replace_buffer_in_all_windows): Remove prototype.
4626 (replace_buffer_in_windows_safely): Add prototype.
4628 * window.c: Declare Qdelete_window static again. Move down
4629 declaration of select_count.
4630 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4631 (Fother_window): Move to window.el.
4632 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4633 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4634 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4636 (replace_buffer_in_windows): Implement by calling
4637 Qreplace_buffer_in_windows.
4638 (replace_buffer_in_all_windows): Remove with some functionality
4639 moved into replace_buffer_in_windows_safely.
4640 (replace_buffer_in_windows_safely): New function.
4641 (select_window_norecord, select_frame_norecord): Move in front
4642 of run_window_configuration_change_hook. Remove now obsolete
4644 (Fset_window_buffer): Rewrite doc-string.
4645 Call Qrecord_window_buffer.
4646 (keys_of_window): Move binding for other-window to window.el.
4648 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4650 * dispextern.h (struct image): Replace data member, whose int_val
4651 and ptr_val fields were not used by anything, with a single
4654 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4655 (gif_clear_image, gif_load, imagemagick_load_image)
4656 (gs_clear_image, gs_load): Callers changed.
4658 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4660 * buffer.h: Include <time.h>, for time_t.
4661 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4663 Fix minor problems found by static checking.
4665 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4667 Make identifiers static if they are not used in other modules.
4668 * data.c (Qcompiled_function, Qframe, Qvector):
4669 * image.c (QimageMagick, Qsvg):
4670 * minibuf.c (Qmetadata):
4671 * window.c (resize_window_check, resize_root_window): Now static.
4672 * window.h (resize_window_check, resize_root_window): Remove decls.
4674 * window.c (window_deletion_count, delete_deletable_window):
4676 (window_body_lines): Now static.
4677 (Fdelete_other_windows_internal): Mark vars as initialized.
4678 Make sure 'resize_failed' is initialized.
4679 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4680 (resize_window_apply): Remove unused local.
4681 * window.h (delete_deletable_window): Remove decl.
4683 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4684 (imagemagick_load_image): Fix pointer signedness problem by changing
4685 last arg from unsigned char * to char *. All uses changed.
4686 Also, fix a local for similar reasons.
4687 Remove unused locals. Remove locals to avoid shadowing.
4688 (fn_rsvg_handle_free): Remove; unused.
4689 (svg_load, svg_load_image): Fix pointer signedness problem.
4690 (imagemagick_load_image): Don't use garbage pointer image_wand.
4692 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4694 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4696 * image.c (gif_load): Fix omitted cast error introduced by
4699 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4701 * window.h (resize_proportionally, orig_total_lines)
4702 (orig_top_line): Remove from window structure.
4703 (set_window_height, set_window_width, change_window_heights)
4704 (Fdelete_window): Remove prototypes.
4705 (resize_frame_windows): Remove duplicate declaration.
4707 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4709 * window.h (resize_frame_windows, resize_window_check)
4710 (delete_deletable_window, resize_root_window)
4711 (resize_frame_windows): Declare prototypes.
4713 * window.c (resize_window_apply): Make definition be "static" to
4714 match the prototype.
4716 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4718 * window.c: Remove declarations of Qwindow_size_fixed,
4719 window_min_size_1, window_min_size_2, window_min_size,
4720 size_window, window_fixed_size_p, enlarge_window, delete_window.
4721 Remove static from declaration of Qdelete_window, it's
4722 temporarily needed by Fbury_buffer.
4723 (replace_window): Don't assign orig_top_line and
4725 (Fdelete_window, delete_window): Remove. Window deletion is
4726 handled by window.el.
4727 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4728 Replace Fdelete_window calls with calls to Qdelete_window.
4729 (Fdelete_other_windows): Remove. Deleting other windows is
4730 handled by window.el.
4731 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4732 handled in window.el.
4733 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4734 Window minimum sizes are handled in window.el.
4735 (shrink_windows, size_window, set_window_height)
4736 (set_window_width, change_window_heights, window_height)
4737 (window_width, CURBEG, CURSIZE, enlarge_window)
4738 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4739 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4740 handled in window.el.
4741 (make_dummy_parent): Rename to make_parent_window and give it a
4742 second argument horflag.
4743 (make_window): Don't set resize_proportionally any more.
4744 (Fsplit_window): Remove. Windows are split in window.el.
4745 (save_restore_action, save_restore_orig_size)
4746 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4747 Resize mini windows in window.el.
4748 (grow_mini_window, shrink_mini_window): Implement by calling
4749 Qresize_root_window_vertically, resize_window_check and
4750 resize_window_apply.
4751 (saved_window, Fset_window_configuration, save_window_save):
4752 Do not handle orig_top_line, orig_total_lines, and
4753 resize_proportionally.
4754 (window_min_height, window_min_width): Move to window.el.
4755 (keys_of_window): Move bindings for delete-other-windows,
4756 split-window, delete-window and enlarge-window to window.el.
4758 * buffer.c: Temporarily extern Qdelete_window.
4759 (Fbury_buffer): Temporarily call Qdelete_window instead of
4760 Fdelete_window (Fbury_buffer will move to window.el soon).
4762 * frame.c (set_menu_bar_lines_1): Remove code handling
4763 orig_top_line and orig_total_lines.
4765 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4766 set_window_height but set heights directly.
4767 (change_frame_size_1): Use resize_frame_windows.
4769 * xdisp.c (init_xdisp): Don't use set_window_height but set
4772 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4773 Use resize_frame_windows instead of change_window_heights and run
4774 run_window_configuration_change_hook.
4776 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4777 instead of change_window_heights and run
4778 run_window_configuration_change_hook.
4780 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4782 * window.c (replace_window): Rename second argument REPLACEMENT to
4783 NEW. New third argument SETFLAG. Rewrite.
4784 (delete_window, make_dummy_parent): Call replace_window with
4786 (window_list_1): Move down in code.
4787 (run_window_configuration_change_hook): Move set_buffer part
4788 before select_frame_norecord part in order to unwind correctly.
4789 Rename count1 to count.
4790 (recombine_windows, delete_deletable_window, resize_root_window)
4791 (Fdelete_other_windows_internal)
4792 (Frun_window_configuration_change_hook, make_parent_window)
4793 (resize_window_check, resize_window_apply, Fresize_window_apply)
4794 (resize_frame_windows, Fsplit_window_internal)
4795 (Fdelete_window_internal, Fresize_mini_window_internal):
4797 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4799 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4801 * window.h (window): Add some new members to window structure -
4802 normal_lines, normal_cols, new_total, new_normal, clone_number,
4803 splits, nest, prev_buffers, next_buffers.
4804 (WINDOW_TOTAL_SIZE): Move here from window.c.
4805 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4807 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4809 (make_dummy_parent): Set new members of windows structure.
4810 (make_window): Move down in code. Handle new members of window
4812 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4813 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4814 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4815 (Fset_window_prev_buffers, Fwindow_next_buffers)
4816 (Fset_window_next_buffers, Fset_window_clone_number):
4818 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4819 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4821 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4822 Argument WINDOW can be now internal window too.
4823 (Fwindow_use_time): Move up in code.
4824 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4826 (Fset_window_configuration, saved_window)
4827 (Fcurrent_window_configuration, save_window_save): Handle new
4828 members of window structure.
4829 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4830 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4831 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4832 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4833 Qget_mru_window, Qresize_root_window,
4834 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4835 Qauto_buffer_name; staticpro them.
4837 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4839 * window.c (Fwindow_total_size, Fwindow_left_column)
4840 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4841 (Fwindow_list_1): New functions.
4842 (window_box_text_cols): Replace with window_body_cols.
4843 (Fwindow_width, Fscroll_left, Fscroll_right):
4844 Use window_body_cols instead of window_box_text_cols.
4845 (delete_window, Fset_window_configuration):
4846 Call delete_all_subwindows with window as argument.
4847 (delete_all_subwindows): Take a window as argument and not a
4849 (window_loop): Remove handling of GET_LRU_WINDOW and
4851 (Fget_lru_window, Fget_largest_window): Move to window.el.
4853 * window.h: Extern window_body_cols instead of
4854 window_box_text_cols. delete_all_subwindows now takes a
4855 Lisp_Object as argument.
4857 * indent.c (compute_motion, Fcompute_motion):
4858 Use window_body_cols instead of window_box_text_cols.
4860 * frame.c (delete_frame): Call delete_all_subwindows with root
4863 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4865 * fns.c (Fputhash): Document return value.
4867 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4869 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4871 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4873 Cons<->int and similar integer overflow fixes (Bug#8794).
4875 Check for overflow when converting integer to cons and back.
4876 * charset.c (Fdefine_charset_internal, Fdecode_char):
4877 Use cons_to_unsigned to catch overflow.
4878 (Fencode_char): Use INTEGER_TO_CONS.
4879 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4880 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4881 * data.c (long_to_cons, cons_to_long): Remove.
4882 (cons_to_unsigned, cons_to_signed): New functions.
4883 These signal an error for invalid or out-of-range values.
4884 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4885 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4886 * font.c (Ffont_variation_glyphs):
4887 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4888 * lisp.h: Include <intprops.h>.
4889 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4890 (cons_to_signed, cons_to_unsigned): New decls.
4891 (long_to_cons, cons_to_long): Remove decls.
4892 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4893 (Fprimitive_undo): Use CONS_TO_INTEGER.
4894 * xfns.c (Fx_window_property): Likewise.
4895 * xselect.c: Include <limits.h>.
4896 (x_own_selection, selection_data_to_lisp_data):
4897 Use INTEGER_TO_CONS.
4898 (x_handle_selection_request, x_handle_selection_clear)
4899 (x_get_foreign_selection, Fx_disown_selection_internal)
4900 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4901 (lisp_data_to_selection_data): Use cons_to_unsigned.
4902 (x_fill_property_data): Use cons_to_signed.
4903 Report values out of range.
4905 Check for buffer and string overflow more precisely.
4906 * buffer.h (BUF_BYTES_MAX): New macro.
4907 * lisp.h (STRING_BYTES_MAX): New macro.
4908 * alloc.c (Fmake_string):
4909 * character.c (string_escape_byte8):
4910 * coding.c (coding_alloc_by_realloc):
4911 * doprnt.c (doprnt):
4912 * editfns.c (Fformat):
4914 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4915 since they may not be the same number.
4916 * editfns.c (Finsert_char):
4917 * fileio.c (Finsert_file_contents):
4918 Likewise for BUF_BYTES_MAX.
4920 * image.c: Use ptrdiff_t, not int, for sizes.
4921 (slurp_file): Switch from int to ptrdiff_t.
4923 (slurp_file): Check that file size fits in both size_t (for
4924 malloc) and ptrdiff_t (for sanity and safety).
4926 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4927 if b->modtime has its maximal value.
4929 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4931 Don't assume time_t can fit into int.
4932 * buffer.h (struct buffer.modtime): Now time_t, not int.
4933 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4934 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4936 Minor fixes for signed vs unsigned integers.
4937 * character.h (MAYBE_UNIFY_CHAR):
4938 * charset.c (maybe_unify_char):
4939 * keyboard.c (read_char, reorder_modifiers):
4940 XINT -> XFASTINT, since the integer must be nonnegative.
4941 * ftfont.c (ftfont_spec_pattern):
4942 * keymap.c (access_keymap, silly_event_symbol_error):
4943 XUINT -> XFASTINT, since the integer must be nonnegative.
4944 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4945 since it makes no difference and we prefer signed.
4946 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4947 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4950 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4952 * window.h (Fwindow_frame): Declare.
4954 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4956 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4957 (SPARE_MEMORY): Always define.
4958 (LARGE_REQUEST): Remove.
4959 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4961 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4963 * lisp.h: Move EXFUNS for Fframe_root_window,
4964 Fframe_first_window and Fset_frame_selected_window to window.h.
4966 * window.h: Move EXFUNS for Fframe_root_window,
4967 Fframe_first_window and Fset_frame_selected_window here from
4970 * frame.c (Fwindow_frame, Fframe_first_window)
4971 (Fframe_root_window, Fframe_selected_window)
4972 (Fset_frame_selected_window): Move to window.c.
4973 (Factive_minibuffer_window): Move to minibuf.c.
4974 (Fother_visible_frames_p): New function.
4976 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4978 * window.c (decode_window, decode_any_window): Move up in code.
4979 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4980 (inhibit_frame_unsplittable): Remove unused variable.
4981 (Fwindow_buffer): Move up and rewrite doc-string.
4982 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4983 (Fwindow_prev): New functions.
4984 (Fwindow_frame): Move here from frame.c. Accept any window as
4986 (Fframe_root_window, Fframe_first_window)
4987 (Fframe_selected_window): Move here from frame.c. Accept frame
4988 or arbitrary window as argument. Update doc-strings.
4989 (Fminibuffer_window): Move up in code.
4990 (Fwindow_minibuffer_p): Move up in code and simplify.
4991 (Fset_frame_selected_window): Move here from frame.c.
4993 (Fselected_window, select_window, Fselect_window): Move up in
4994 code. Minor doc-string fixes.
4996 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4998 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4999 Do not assume that spare memory exists; that assumption is valid
5000 only if SYSTEM_MALLOC.
5001 (LARGE_REQUEST): New macro, so that the issue of large requests
5002 is separated from the issue of spare memory.
5004 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5006 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5009 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5011 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5014 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5016 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5018 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5020 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5021 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5023 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5025 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5027 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5029 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5030 (x_clipboard_manager_save): Add return value.
5031 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5033 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5034 Obey Vx_select_enable_clipboard_manager. Catch errors in
5035 x_clipboard_manager_save (Bug#8779).
5036 (Vx_select_enable_clipboard_manager): New variable.
5037 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5039 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5041 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5043 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5045 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5046 in the current matrix if keep_current_p is non-zero.
5048 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5050 * bidi.c (bidi_level_of_next_char): Fix last change.
5052 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5054 Support bidi reordering of text covered by display properties.
5056 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5057 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5058 (bidi_cache_search, bidi_cache_iterator_state)
5059 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5060 (bidi_level_of_next_char, bidi_move_to_visually_next):
5061 Support character positions inside a run of characters covered by a
5063 (bidi_paragraph_init, bidi_resolve_explicit_1)
5064 (bidi_level_of_next_char): Call bidi_fetch_char and
5065 bidi_fetch_char_advance instead of FETCH_CHAR and
5067 (bidi_init_it): Initialize new members.
5068 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5070 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5071 instead of using explicit *_CHAR codes.
5072 (bidi_resolve_explicit, bidi_resolve_weak):
5073 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5074 bidirectional text is supported only in multibyte buffers.
5075 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5076 it to initialize the frame_window_p member of struct bidi_it.
5077 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5078 (bidi_resolve_explicit, bidi_resolve_weak)
5079 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5080 bidi_it->nchars is non-positive.
5081 (bidi_level_of_next_char): Don't try to lookup the cache for the
5082 next/previous character if nothing is cached there yet, or if we
5083 were just reseat()'ed to a new position.
5085 * xdisp.c (set_cursor_from_row): Set start and stop points
5086 according to the row's direction when priming the loop that looks
5087 for the glyph on which to display cursor.
5088 (single_display_spec_intangible_p): Function deleted.
5089 (display_prop_intangible_p): Reimplement to call
5090 handle_display_spec instead of single_display_spec_intangible_p.
5091 Accept 3 additional arguments needed by handle_display_spec.
5092 This fixes incorrect cursor motion across display property with complex
5093 values: lists, `(when COND...)' forms, etc.
5094 (single_display_spec_string_p): Support property values that are
5095 lists with the argument STRING its top-level element.
5096 (display_prop_string_p): Fix the condition for processing a
5097 property that is a list to be consistent with handle_display_spec.
5098 (handle_display_spec): New function, refactored from the
5099 last portion of handle_display_prop.
5100 (compute_display_string_pos): Accept additional argument
5101 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5102 value of a `display' property is a "replacing spec".
5103 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5104 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5105 the display property, but just return a value indicating whether
5106 the display property will replace the characters it covers.
5107 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5108 frame_window_p members of struct bidi_it.
5109 (compute_display_string_pos, compute_display_string_end):
5111 (push_it): Accept second argument POSITION, where pop_it should
5112 jump to continue iteration.
5113 (reseat_1): Initialize bidi_it.disp_pos.
5115 * keyboard.c (adjust_point_for_property): Adjust the call to
5116 display_prop_intangible_p to its new signature.
5118 * dispextern.h (struct bidi_it): New member frame_window_p.
5119 (bidi_init_it): Update prototypes.
5120 (display_prop_intangible_p): Update prototype.
5121 (compute_display_string_pos, compute_display_string_end):
5123 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5126 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5128 Malloc failure behavior now depends on size of allocation.
5129 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5130 * lisp.h: Change signatures accordingly.
5131 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5132 All callers changed. (Bug#8762)
5134 * gnutls.c: Use Emacs's memory allocators.
5135 Without this change, the gnutls library would invoke malloc etc.
5136 directly, which causes problems on non-SYNC_INPUT hosts, and which
5137 runs afoul of improving memory_full behavior. (Bug#8761)
5138 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5139 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5140 xfree instead of the default malloc, realloc, free.
5141 (Fgnutls_boot): No need to check for memory allocation failure,
5142 since xmalloc does that for us.
5144 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5145 * category.c (hash_get_category_set):
5146 * ccl.c (ccl_driver):
5147 * charset.c (Fdefine_charset_internal):
5148 * charset.h (struct charset.hash_index):
5149 * composite.c (get_composition_id, gstring_lookup_cache)
5150 (composition_gstring_put_cache):
5151 * composite.h (struct composition.hash_index):
5152 * dispextern.h (struct image.hash):
5153 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5154 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5155 (hashfn_equal, hashfn_user_defined, make_hash_table)
5156 (maybe_resize_hash_table, hash_lookup, hash_put)
5157 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5158 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5159 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5160 * image.c (make_image, search_image_cache, lookup_image)
5161 (xpm_put_color_table_h):
5162 * lisp.h (struct Lisp_Hash_Table):
5163 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5164 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5165 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5166 * alloc.c (allocate_vectorlike):
5167 Check for overflow in vector size calculations.
5168 * ccl.c (ccl_driver):
5169 Check for overflow when converting EMACS_INT to int.
5170 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5171 need to be updated by these changes.
5172 * fns.c (make_hash_table, maybe_resize_hash_table):
5173 Check for integer overflow with large hash tables.
5174 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5175 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5176 (SXHASH_REDUCE): New macro.
5177 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5178 Use it instead of discarding useful hash info with large hash values.
5179 (sxhash_float): New function.
5180 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5181 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5182 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5183 Rewrite to use FIXNUM_BITS, as this simplifies things.
5184 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5185 Adjust signatures to match updated version of code.
5186 (consing_since_gc): Now EMACS_INT, since a single hash table can
5187 use more than INT_MAX bytes.
5189 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5191 Make it possible to build with GCC-4.6+ -O2 -flto.
5193 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5195 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5197 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5198 Call minibuffer-inactive-mode.
5200 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5202 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5203 Update dependencies.
5205 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5207 * data.c (init_data): Remove code for UTS, this system is not
5210 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5212 Don't force ./temacs to start in terminal mode.
5214 * frame.c (make_initial_frame): Initialize faces in all cases, not
5215 only when CANNOT_DUMP is defined.
5216 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5218 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5220 * dispnew.c (add_window_display_history): Use const for the string
5221 pointer. Remove declaration, not needed.
5223 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5225 Use 'inline', not 'INLINE'.
5226 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5227 * alloc.c, fontset.c (INLINE): Remove.
5228 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5229 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5230 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5231 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5232 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5234 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5236 Make it possible to run ./temacs.
5238 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5239 syms_of_callproc does the same thing. Remove test for
5240 "initialized", do it in the caller.
5241 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5243 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5245 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5246 (read_minibuf): Use get_minibuffer.
5247 (syms_of_minibuf): Use DEFSYM.
5248 (Qmetadata): New var.
5249 * data.c (Qbuffer): Don't make it static.
5250 (syms_of_data): Use DEFSYM.
5252 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5254 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5255 (CCL_CODE_MIN): New macro.
5257 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5259 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5261 * eval.c (Qdebug): Now static.
5262 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5263 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5264 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5266 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5268 * image.c: Various fixes to ImageMagick code comments.
5269 (Fimagemagick_types): Doc fix.
5271 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5273 Minor fixes prompted by GCC 4.6.0 warnings.
5275 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5277 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5278 (x_clipboard_manager_save_all): Move extern decl to ...
5279 * xterm.h: ... here, so that it can be checked for consistency.
5281 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5283 * xselect.c (x_clipboard_manager_save_frame)
5284 (x_clipboard_manager_save_all): New functions.
5285 (Fx_clipboard_manager_save): Lisp function deleted.
5287 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5288 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5290 * xterm.h: Update prototype.
5292 2011-05-28 William Xu <william.xwl@gmail.com>
5294 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5297 2011-05-28 Jim Meyering <meyering@redhat.com>
5299 Avoid a sign-extension bug in crypto_hash_function.
5300 * fns.c (to_uchar): Define.
5301 (crypto_hash_function): Use it to convert some newly-signed
5302 variables to unsigned, to avoid sign-extension bugs. For example,
5303 without this change, (md5 "truc") would evaluate to
5304 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5305 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5306 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5308 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5310 Integer overflow fixes.
5312 * dbusbind.c: Serial number integer overflow fixes.
5313 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5314 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5315 to hold a serial number that is too large for a fixnum.
5316 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5317 Check for serial numbers out of range. Decode any serial number
5318 that was so large that it became a float. (Bug#8722)
5320 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5321 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5322 Use XFASTINT rather than XUINT when numbers are nonnegative.
5323 (xd_append_arg, Fdbus_method_return_internal):
5324 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5325 arguments, check that Lisp number is nonnegative, rather than
5326 silently wrapping negative numbers around. (Bug#8722)
5327 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5330 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5332 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5334 ccl: add integer overflow checks
5335 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5336 (IN_INT_RANGE): New macros.
5337 (ccl_driver): Use them to check for integer overflow when
5338 decoding a CCL program. Many of the new checks are whether XINT (x)
5339 fits in int; it doesn't always, on 64-bit hosts. The new version
5340 doesn't catch all possible integer overflows, but it's an
5341 improvement. (Bug#8719)
5343 * alloc.c (make_event_array): Use XINT, not XUINT.
5344 There's no need for unsigned here.
5346 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5347 This follows up to the 2011-05-06 change that substituted uintptr_t
5348 for EMACS_INT. This case wasn't caught back then.
5350 Rework Fformat to avoid integer overflow issues.
5351 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5352 now (part of C89). Include <verify.h>.
5353 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5354 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5355 (Fformat): Avoid the prepass trying to compute sizes; it was only
5356 approximate and thus did not catch overflow reliably. Instead, walk
5357 through the format just once, formatting and computing sizes as we go,
5358 checking for integer overflow at every step, and allocating a larger
5359 buffer as needed. Keep track separately whether the format is
5360 multibyte. Keep only the most-recently calculated precision, rather
5361 than them all. Record whether each argument has been converted to
5362 string. Use EMACS_INT, not int, for byte and char and arg counts.
5363 Support field widths and precisions larger than INT_MAX. Avoid
5364 sprintf's undefined behavior with conversion specifications such as %#d
5365 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5366 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5367 formatting out-of-range floating point numbers with int
5370 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5372 * data.c: Avoid integer truncation in expressions involving floats.
5373 * data.c: Include <intprops.h>.
5374 (arith_driver): When there's an integer overflow in an expression
5375 involving floating point, convert the integers to floating point
5376 so that the resulting value does not suffer from catastrophic
5377 integer truncation. For example, on a 64-bit host (* 4
5378 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5379 Do not rely on undefined behavior after integer overflow.
5381 merge count_size_as_multibyte, parse_str_to_multibyte
5382 * character.c, character.h (count_size_as_multibyte):
5383 Rename from parse_str_to_multibyte; all uses changed.
5384 Check for integer overflow.
5385 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5386 since it's now a duplicate of the other. This is more of
5387 a character than a buffer op, so better that it's in character.c.
5388 * fns.c, print.c: Adjust to above changes.
5390 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5392 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5394 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5396 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5397 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5398 (x_clipboard_manager_save): Now static.
5399 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5401 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5402 (crypto_hash_function): Now static.
5403 Fix pointer signedness problems. Avoid unnecessary initializations.
5405 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5407 * termhooks.h (Vselection_alist): Make it terminal-local.
5409 * terminal.c (create_terminal): Initialize it.
5411 * xselect.c: Support for clipboard managers.
5412 (Vselection_alist): Move to termhooks.h as terminal-local var.
5413 (LOCAL_SELECTION): New macro.
5414 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5415 (symbol_to_x_atom): Remove gratuitous arg.
5416 (x_handle_selection_request, lisp_data_to_selection_data)
5417 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5418 (x_own_selection, x_get_local_selection, x_convert_selection):
5419 New arg, specifying work frame. Use terminal-local Vselection_alist.
5420 (some_frame_on_display): Delete unused function.
5421 (Fx_own_selection_internal, Fx_get_selection_internal)
5422 (Fx_disown_selection_internal, Fx_selection_owner_p)
5423 (Fx_selection_exists_p): New optional frame arg.
5424 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5425 (x_handle_selection_clear): Don't treat other terminals with the
5426 same keyboard specially. Use the terminal-local Vselection_alist.
5427 (x_clear_frame_selections): Use Frun_hook_with_args.
5429 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5431 * xterm.h: Add support for those atoms.
5433 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5435 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5436 (converted_selections, conversion_fail_tag): New global variables.
5437 (x_selection_request_lisp_error): Free the above.
5438 (x_get_local_selection): Remove unnecessary code.
5439 (x_reply_selection_request): Args changed; handle arbitrary array
5440 of converted selections stored in converted_selections.
5441 Separate the XChangeProperty and SelectionNotify steps.
5442 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5443 (x_convert_selection): New function.
5444 (x_handle_selection_event): Simplify.
5445 (x_get_foreign_selection): Don't ignore incoming requests while
5446 waiting for an answer; this will fail when we implement
5447 SAVE_TARGETS, and seems unnecessary anyway.
5448 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5449 (Vx_sent_selection_functions): Doc fix.
5451 2011-05-26 Leo Liu <sdl.web@gmail.com>
5453 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5455 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5457 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5459 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5460 for fringe update if it has periodic bitmap.
5461 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5462 and fringe_bitmap_periodic_p.
5464 * fringe.c (get_fringe_bitmap_data): New function.
5465 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5466 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5467 row. Mark glyph row for fringe update if periodicity changed.
5469 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5470 for fringe update unless it has periodic bitmap.
5472 2011-05-25 Kenichi Handa <handa@m17n.org>
5474 * xdisp.c (get_next_display_element): Set correct it->face_id for
5475 a static composition.
5477 2011-05-24 Leo Liu <sdl.web@gmail.com>
5480 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5482 * fns.c (crypto_hash_function, Fsha1): New function.
5483 (Fmd5): Use crypto_hash_function.
5484 (syms_of_fns): Add Ssha1.
5486 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5488 * gnutls.c: Remove unused macros.
5489 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5490 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5491 Remove macros that are defined and never used.
5492 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5494 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5496 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5497 (Fx_get_selection_internal): Minor cleanup.
5498 (Fx_own_selection_internal): Rename arguments for consistency with
5501 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5503 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5505 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5507 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5509 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5511 * dispnew.c (scrolling_window): Don't exclude the case that the
5512 last enabled row in the desired matrix touches the bottom boundary.
5514 2011-05-21 Glenn Morris <rgm@gnu.org>
5516 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5517 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5518 and add some more files.
5520 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5522 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5523 report_file_error introduced by the change from 2011-05-07.
5525 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5527 * systime.h (Time): Define only if emacs is defined.
5528 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5529 where the include path doesn't have X11/X.h by default. See
5530 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5532 2011-05-20 Kenichi Handa <handa@m17n.org>
5534 * composite.c (find_automatic_composition): Fix previous change.
5536 2011-05-20 Glenn Morris <rgm@gnu.org>
5538 * lisp.mk: New file, split from Makefile.in.
5539 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5540 (shortlisp): Remove.
5541 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5543 2011-05-19 Glenn Morris <rgm@gnu.org>
5545 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5546 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5547 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5548 (lisp): Set the order to that of loadup.el.
5549 (shortlisp): Make it a copy of $lisp.
5550 (SOME_MACHINE_LISP): Remove.
5551 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5552 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5554 2011-05-18 Kenichi Handa <handa@m17n.org>
5556 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5557 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5558 (find_automatic_composition): Mostly rewrite for efficiency.
5560 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5562 * makefile.w32-in: Update dependencies.
5564 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5566 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5567 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5569 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5571 Fix some integer overflow issues, such as string length overflow.
5573 * insdel.c (count_size_as_multibyte): Check for string overflow.
5575 * character.c (lisp_string_width): Check for string overflow.
5576 Use EMACS_INT, not int, for string indexes and lengths; in
5577 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5578 the resulting string length overflows an EMACS_INT; instead,
5579 report a string overflow if no precision given. When checking for
5580 precision exhaustion, use a check that cannot possibly have
5581 integer overflow. (Bug#8675)
5582 * character.h (lisp_string_width): Adjust to new signature.
5584 * alloc.c (string_overflow): New function.
5585 (Fmake_string): Use it. This doesn't change behavior, but saves
5586 a few bytes and will simplify future changes.
5587 * character.c (string_escape_byte8): Likewise.
5588 * lisp.h (string_overflow): New decl.
5590 Fixups, following up to the user-interface timestamp change.
5591 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5592 for UI timestamps, instead of unsigned long.
5593 * msdos.c (mouse_get_pos): Likewise.
5594 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5595 * w32gui.h (Time): Define by including "systime.h" rather than by
5596 declaring it ourselves. (Bug#8664)
5598 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5599 * image.c (clear_image_cache): Likewise.
5601 * term.c (term_mouse_position): Don't assume time_t wraparound.
5603 Be more systematic about user-interface timestamps.
5604 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5605 and sometimes 'EMACS_UINT', to represent these timestamps.
5606 This change causes it to use 'Time' uniformly, as that's what X uses.
5607 This makes the code easier to follow, and makes it easier to catch
5608 integer overflow bugs such as Bug#8664.
5609 * frame.c (Fmouse_position, Fmouse_pixel_position):
5610 Use Time, not unsigned long, for user-interface timestamps.
5611 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5612 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5613 * keyboard.h (last_event_timestamp): Likewise.
5614 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5615 * menu.h (xmenu_show): Likewise.
5616 * term.c (term_mouse_position): Likewise.
5617 * termhooks.h (struct input_event.timestamp): Likewise.
5618 (struct terminal.mouse_position_hook): Likewise.
5619 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5620 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5621 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5622 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5624 * menu.h, termhooks.h: Include "systime.h", for Time.
5626 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5627 Don't assume that the difference between two unsigned long values
5628 can fit into an integer. At this point, we know button_down_time
5629 <= event->timestamp, so the difference must be nonnegative, so
5630 there's no need to cast the result if double-click-time is
5631 nonnegative, as it should be; check that it's nonnegative, just in
5632 case. This bug is triggered when events are more than 2**31 ms
5633 apart (about 25 days). (Bug#8664)
5635 * xselect.c (last_event_timestamp): Remove duplicate decl.
5636 (x_own_selection): Remove needless cast to unsigned long.
5638 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5639 that always fit in int. Use a sentinel instead of a counter, to
5640 avoid a temp and to allay GCC's concerns about possible int overflow.
5641 * frame.h (struct frame): Use int for menu_bar_items_used
5642 instead of EMACS_INT, since it always fits in int.
5644 * menu.c (grow_menu_items): Check for int overflow.
5646 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5648 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5649 Before, the code was not consistent. These values cannot exceed
5650 2**31 - 1 so there's no need to make them unsigned.
5651 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5652 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5653 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5655 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5657 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5658 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5659 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5660 presumably because the widths might not match.
5662 * window.c (size_window): Avoid needless test at loop start.
5664 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5666 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5668 2011-05-12 Drew Adams <drew.adams@oracle.com>
5670 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5672 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5674 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5675 `width' to `bar_area_x' and `bar_area_width', respectively.
5676 (x_scroll_run): Take account of fringe background extension.
5678 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5679 Rename local vars `left' and `width' to `bar_area_x' and
5680 `bar_area_width', respectively.
5681 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5682 background extension.
5684 2011-05-10 Jim Meyering <meyering@redhat.com>
5686 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5688 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5690 * image.c (Finit_image_library): Return t for built-in image types,
5691 like pbm and xbm. (Bug#8640)
5693 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5695 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5697 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5699 * w32console.c (Fset_screen_color): Doc fix.
5700 (Fget_screen_color): New function.
5701 (syms_of_ntterm): Defsubr it.
5703 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5704 unlink the temporary file if Fcall_process didn't create it in the
5706 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5707 child process will be redirected to a file specified with `:file'.
5708 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5709 cue to call_process_cleanup not to close that handle.
5711 2011-05-07 Ben Key <bkey76@gmail.com>
5713 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5714 one of two shell specific rules, either bootstrap-temacs-CMD or
5715 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5716 to the previous implementation of the bootstrap-temacs rule.
5717 The bootstrap-temacs-CMD rule is similar to the previous
5718 implementation of the bootstrap-temacs rule except that it
5719 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5722 These changes, along with some changes to nt/configure.bat,
5723 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5724 earlier fix to add support for --cflags and --ldflags options
5725 that include quotes so that it works whether make uses cmd or
5728 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5730 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5731 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5733 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5734 a string. Handle both cases.
5735 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5736 (Fdbus_register_method): Use Qinvalid_function.
5738 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5740 * makefile.w32-in: Update dependencies.
5741 (LISP_H): Add inttypes.h and stdin.h.
5742 (PROCESS_H): Add unistd.h.
5744 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5746 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5747 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5749 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5751 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5753 * term.c (vfatal): Remove stray call to va_end.
5754 It's not needed and the C Standard doesn't allow it here anyway.
5756 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5757 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5759 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5762 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5764 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5766 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5768 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5770 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5772 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5773 * charset.c (Fdefine_charset_internal): Don't initialize
5774 charset.code_space[15]. The value was garbage, on hosts with
5775 32-bit int (Bug#8600).
5777 * lread.c (read_integer): Be more consistent with string-to-number.
5778 Use string_to_number to do the actual conversion; this avoids
5779 rounding errors and fixes some other screwups. Without this fix,
5780 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5781 (digit_to_number): Move earlier, for benefit of read_integer.
5782 Return -1 if the digit is out of range for the base, -2 if it is
5783 not a digit in any supported base. (Bug#8602)
5785 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5787 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5788 to match comment at start of function. This also removes a
5789 GCC warning about overflow in a 32+64-bit port.
5791 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5793 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5794 Reported by Stefan Monnier in
5795 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5796 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5797 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5799 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5800 (EMACS_UINTPTR): Likewise, with uintptr_t.
5802 * lisp.h: Prefer 64-bit EMACS_INT if available.
5803 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5804 on 32-bit hosts that have 64-bit int, so that they can access
5806 However, temporarily disable this change unless the temporary
5807 symbol WIDE_EMACS_INT is defined.
5809 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5811 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5812 This removes an assumption that EMACS_INT and long are the same
5813 width as pointers. The assumption is true for Emacs porting targets
5814 now, but we want to make other targets possible.
5815 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5816 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5817 In the rest of the code, change types of integers that hold casted
5818 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5819 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5820 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5821 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5822 No need to cast type when ORing.
5823 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5824 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5825 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5826 assume EMACS_INT is the same width as char *.
5827 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5828 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5829 Remove no-longer-needed casts.
5830 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5831 (xg_tool_bar_help_callback, xg_make_tool_item):
5832 Use EMACS_INTPTR to hold an integer
5833 that will be cast to void *; this can avoid a GCC warning
5834 if EMACS_INT is not the same width as void *.
5835 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5836 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5837 (current_message_1, set_message_1):
5838 Use a local to convert to proper width without a cast.
5839 * xmenu.c (dialog_selection_callback): Likewise.
5841 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5842 Also, don't assume VALBITS / RAND_BITS is less than 5,
5843 and don't rely on undefined behavior when shifting a 1 left into
5845 * lisp.h (get_random): Change signature to match.
5847 * lread.c (hash_string): Use size_t, not int, for hash computation.
5848 Normally we prefer signed values; but hashing is special, because
5849 it's better to use unsigned division on hash table sizes so that
5850 the remainder is nonnegative. Also, size_t is the natural width
5851 for hashing into memory. The previous code used 'int', which doesn't
5852 retain enough info to hash well into very large tables.
5853 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5855 * dbusbind.c: Don't possibly lose pointer info when converting.
5856 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5857 Use XPNTR rather than XHASH, so that the high-order bits of
5858 the pointer aren't lost when converting through void *.
5860 * eval.c (Fautoload): Don't double-shift a pointer.
5862 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5864 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5866 * gnutls.c (DEF_GNUTLS_FN):
5867 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5869 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5871 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5874 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5876 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5877 New version that can reserve upto 2GB of heap space.
5879 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5881 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5883 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5885 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5886 `gnutls_certificate_set_x509_key_file'.
5888 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5890 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5891 Update dependencies.
5893 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5895 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5896 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5897 Remove unused parameter `fildes'.
5898 * process.c (read_process_output, send_process): Don't pass it.
5900 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5902 Fix previous change: the library cache is defined in w32.c.
5903 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5904 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5906 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5908 Implement dynamic loading of GnuTLS on Windows.
5910 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5911 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5912 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5915 * gnutls.c (Qgnutls_dll): Define.
5916 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5917 (gnutls_*): Declare function pointers.
5918 (init_gnutls_functions): New function to initialize function pointers.
5919 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5920 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5921 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5922 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5923 (emacs_gnutls_write, emacs_gnutls_read)
5924 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5925 (Fgnutls_available_p): New function.
5926 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5927 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5928 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5930 * image.c: Include w32.h.
5931 (Vimage_type_cache): Delete.
5932 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5933 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5934 (w32_delayed_load): Move to w32.c.
5936 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5938 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5939 (w32_delayed_load): Move from image.c. When loading a library, record
5940 its filename in the :loaded-from property of the library id.
5941 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5942 Initialize and staticpro them.
5943 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5945 * process.c: Include lisp.h before w32.h, not after.
5946 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5947 instead of gnutls_record_check_pending.
5949 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5951 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5953 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5954 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5957 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5959 * xterm.c (x_set_frame_alpha): Do not set property on anything
5960 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5962 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5964 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5966 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5968 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5969 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5970 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5971 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5972 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5973 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5974 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5975 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5976 (Qgnutls_bootprop_callbacks_verify): Make static.
5978 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5980 * callproc.c: Indentation fixup.
5982 * sysdep.c (wait_for_termination_1): Make static.
5983 (wait_for_termination, interruptible_wait_for_termination):
5984 Move after wait_for_termination_1.
5986 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5988 * sysdep.c (interruptible_wait_for_termination): New function
5989 which is like wait_for_termination, but allows keyboard
5992 * callproc.c (Fcall_process): Add (:file "file") as an option for
5994 (Fcall_process_region): Ditto.
5996 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5998 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5999 rather than `XVECTOR (FOO)->size'.
6001 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6002 inttypes.h, as a gnulib replacement is used if it not available in
6005 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6007 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6008 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6009 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6011 * coding.c (coding_alloc_by_realloc): Error out if destination
6012 will grow beyond MOST_POSITIVE_FIXNUM.
6013 (decode_coding_emacs_mule): Abort if there isn't enough place in
6014 charbuf for the composition carryover bytes. Reserve an extra
6015 space for up to 2 characters produced in a loop.
6016 (decode_coding_iso_2022): Abort if there isn't enough place in
6017 charbuf for the composition carryover bytes.
6019 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6021 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6022 aborting when %lld or %lll format is passed.
6023 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6024 %llo or %llx format is passed. (Bug#8545)
6026 * window.c (window_scroll_line_based): Use a marker instead of
6027 simple variables to record original value of point. (Bug#7952)
6029 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6030 produced by %s or %c overflows available buffer space. (Bug#8545)
6032 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6034 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6035 (SIZE_MAX): Move defn after all includes, as they might #define it.
6037 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6039 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6041 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6043 * keyboard.c (Qdelayed_warnings_hook): Define.
6044 (command_loop_1): Run `delayed-warnings-hook'
6045 if Vdelayed_warnings_list is non-nil.
6046 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6047 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6049 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6051 * doprnt.c (doprnt): Don't return value smaller than the buffer
6052 size if the message was truncated. (Bug#8545).
6054 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6056 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6057 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6059 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6061 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6063 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6065 * makefile.w32-in: Update dependencies.
6067 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6069 Improve `doprnt' and its usage. (Bug#8545)
6070 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6071 `format_end'. Remove support for %l as a conversion specifier.
6072 Don't use xrealloc. Improve diagnostics when the %l size modifier
6073 is used. Update the commentary.
6075 * eval.c (verror): Simplify calculation of size_t.
6077 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6080 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6082 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6085 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6087 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6088 This makes this file independent of the recent pseudovector change.
6090 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6092 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6094 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6095 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6096 Remove unused local.
6097 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6099 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6100 GCC 4.6.0 optimizes based on type-based alias analysis.
6101 For example, if b is of type struct buffer * and v of type struct
6102 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6103 != &v->size, and therefore "v->size = 1; b->size = 2; return
6104 v->size;" must therefore return 1. This assumption is incorrect
6105 for Emacs, since it type-puns struct Lisp_Vector * with many other
6106 types. To fix this problem, this patch adds a new type struct
6107 vectorlike_header that documents the constraints on layout of vectors
6108 and pseudovectors, and helps optimizing compilers not get fooled
6109 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6110 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6111 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6113 (XSETPVECTYPE): Rewrite in terms of new macro.
6114 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6115 This is a bit clearer, and further avoids the possibility of
6116 undesirable aliasing.
6117 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6118 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6119 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6120 since Lisp_Subr is a special case (no "next" field).
6121 (ASIZE): Now uses header.size rather than size.
6122 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6123 to avoid the hassle of writing XVECTOR (foo)->header.size.
6124 (struct vectorlike_header): New type.
6125 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6126 object, to help avoid aliasing.
6127 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6128 (SUBRP): Likewise, since Lisp_Subr is a special case.
6129 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6130 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6131 (struct Lisp_Hash_Table): Combine first two members into a single
6132 struct vectorlike_header member. All uses of "size" and "next" members
6133 changed to be "header.size" and "header.next".
6134 * buffer.h (struct buffer): Likewise.
6135 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6136 * frame.h (struct frame): Likewise.
6137 * process.h (struct Lisp_Process): Likewise.
6138 * termhooks.h (struct terminal): Likewise.
6139 * window.c (struct save_window_data, struct saved_window): Likewise.
6140 * window.h (struct window): Likewise.
6141 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6142 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6143 * buffer.c (init_buffer_once): Likewise.
6144 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6146 * process.c (Fformat_network_address): Use local var for size,
6149 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6151 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6152 * data.c (atof): Remove decl; no longer used or needed.
6153 (digit_to_number): Move to lread.c.
6154 (Fstring_to_number): Use new string_to_number function, to be
6155 consistent with how the Lisp reader treats infinities and NaNs.
6156 Do not assume that floating-point numbers represent EMACS_INT
6157 without losing information; this is not true on most 64-bit hosts.
6158 Avoid double-rounding errors, by insisting on integers when
6159 parsing non-base-10 numbers, as the documentation specifies.
6160 * lisp.h (string_to_number): New decl, replacing ...
6161 (isfloat_string): Remove.
6162 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6163 (read1): Do not accept +. and -. as integers; this
6164 appears to have been a coding error. Similarly, do not accept
6165 strings like +-1e0 as floating point numbers. Do not report
6166 overflow for integer overflows unless the base is not 10 which
6167 means we have no simple and reliable way to continue.
6168 Break out the floating-point parsing into a new
6169 function string_to_number, so that Fstring_to_number parses
6170 floating point numbers consistently with the Lisp reader.
6171 (digit_to_number): Move here from data.c. Make it static inline.
6172 (E_CHAR, EXP_INT): Remove, replacing with ...
6173 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6174 (string_to_number): New function, replacing isfloat_string.
6175 This function checks for valid syntax and produces the resulting
6176 Lisp float number too. Rework it so that string-to-number
6177 no longer mishandles examples like "1.0e+". Use strtoumax,
6178 so that overflow for non-base-10 numbers is reported only when
6179 there's no portable and simple way to convert to floating point.
6181 * textprop.c (set_text_properties_1): Rewrite for clarity,
6182 and to avoid GCC warning about integer overflow.
6184 * intervals.h (struct interval): Use EMACS_INT for members
6185 where EMACS_UINT might cause problems. See
6186 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6187 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6188 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6190 (offset_intervals): Tell GCC not to worry about length overflow
6191 when negating a negative length.
6193 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6194 (overrun_check_free): Likewise.
6196 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6197 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6200 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6201 (gnutls_make_error): Rename local to avoid shadowing.
6202 (gnutls_emacs_global_deinit): ifdef out; not used.
6203 (Fgnutls_boot): Use const for pointer to readonly storage.
6204 Comment out unused local. Fix pointer signedness problems.
6206 * lread.c (openp): Don't stuff size_t into an 'int'.
6207 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6208 about possible signed overflow.
6210 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6211 (GDK_KEY_g): Don't define if already defined.
6212 (xg_prepare_tooltip): Avoid pointer signedness problem.
6213 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6215 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6216 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6218 * xfns.c (Fx_window_property): Simplify a bit,
6219 to make a bit faster and to avoid GCC 4.6.0 warning.
6220 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6222 * fns.c (internal_equal): Don't assume size_t fits in int.
6224 * alloc.c (compact_small_strings): Tighten assertion a little.
6226 Replace pEd with more-general pI, and fix some printf arg casts.
6227 * lisp.h (pI): New macro, generalizing old pEd macro to other
6228 conversion specifiers. For example, use "...%"pI"d..." rather
6229 than "...%"pEd"...".
6230 (pEd): Remove. All uses replaced with similar uses of pI.
6231 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6232 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6233 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6234 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6235 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6236 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6237 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6239 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6240 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6241 * print.c (safe_debug_print, print_object): Likewise.
6242 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6244 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6245 avoiding the 0 flag, which is not portable.
6246 * process.c (Fmake_network_process): Use pI to avoid cast.
6247 * region-cache.c (pp_cache): Likewise.
6248 * xdisp.c (decode_mode_spec): Likewise.
6249 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6250 behavior on 64-bit hosts with printf arg.
6251 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6252 (x_stop_queuing_selection_requests): Likewise.
6253 (x_get_window_property): Don't truncate byte count to an 'int'
6256 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6257 here, since it parses constructs like leading '-' and spaces,
6258 which are not wanted; and it overflows with large numbers.
6259 Instead, simply match F[0-9]+, which is what is wanted anyway.
6261 * alloc.c: Remove unportable assumptions about struct layout.
6262 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6263 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6264 (allocate_vectorlike, make_pure_vector): Use the new macros,
6265 plus offsetof, to remove unportable assumptions about struct layout.
6266 These assumptions hold on all porting targets that I know of, but
6267 they are not guaranteed, they're easy to remove, and removing them
6268 makes further changes easier.
6270 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6271 This doesn't fix a bug but makes the code clearer.
6272 (string_overrun_cookie): Now const. Use initializers that
6273 don't formally overflow signed char, to avoid warnings.
6274 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6275 can cause Emacs to crash when string overrun checking is enabled.
6276 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6277 multiple of sizeof (EMACS_INT); it need not be, if
6278 alignof(EMACS_INT) < sizeof (EMACS_INT).
6279 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6281 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6283 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6285 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6287 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6288 supposed to be handshaking. (Bug#8556)
6289 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6291 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6293 * lisp.h (Qdebug): List symbol.
6294 * eval.c (Qdebug): Restore global linkage.
6295 * keyboard.c (debug-on-event): New variable.
6296 (handle_user_signal): Break into debugger when debug-on-event
6297 matches the current signal symbol.
6299 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6301 * alloc.c (check_sblock, check_string_bytes)
6302 (check_string_free_list): Convert to standard C.
6304 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6306 * w32.c (emacs_gnutls_push): Fix typo.
6308 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6310 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6311 "cast to pointer from integer of different size".
6313 Improve doprnt and its use in verror. (Bug#8545)
6314 * doprnt.c (doprnt): Document the set of format control sequences
6315 supported by the function. Use SAFE_ALLOCA instead of always
6318 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6319 is one byte too soon. Don't use xrealloc; instead xfree and
6322 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6324 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6327 * gnutls.c: Renamed global_initialized to
6328 gnutls_global_initialized. Added internals for the
6329 :verify-hostname-error, :verify-error, and :verify-flags
6330 parameters of `gnutls-boot' and documented those parameters in the
6331 docstring. Start callback support.
6332 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6333 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6334 on error. Return error code.
6335 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6336 (emacs_gnutls_read): Likewise.
6337 (Fgnutls_boot): Return handshake error code.
6338 (emacs_gnutls_handle_error): New function.
6339 (wsaerror_to_errno): Likewise.
6341 * w32.h (emacs_gnutls_pull): Add prototype.
6342 (emacs_gnutls_push): Likewise.
6344 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6345 (emacs_gnutls_push): Likewise.
6347 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6349 * process.c (wait_reading_process_output): Check if GnuTLS
6350 buffered some data internally if no FDs are set for TLS
6353 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6354 (LIBS): Link to USER_LIBS.
6355 ($(BLD)/gnutls.$(0)): New target.
6357 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6359 * xdisp.c (handle_single_display_spec): Rename the
6360 display_replaced_before_p argument into display_replaced_p, to
6361 make it consistent with the commentary. Fix typos in the
6364 * textprop.c (syms_of_textprop): Remove dead code.
6365 (copy_text_properties): Delete obsolete commentary about an
6366 interface that was deleted long ago. Fix typos in the description
6369 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6370 to changes in oldXMenu/XMenu.h from 2011-04-16.
6371 <menu_help_message, prev_menu_help_message>: Constify.
6372 (IT_menu_make_room): menu->help_text is now `const char **';
6375 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6376 to changes in oldXMenu/XMenu.h from 2011-04-16.
6377 (struct XMenu): Declare `help_text' `const char **'.
6379 * xfaces.c <Qunspecified>: Make extern again.
6381 * syntax.c: Include sys/types.h before including regex.h, as
6384 * doc.c (get_doc_string): Improve the format passed to `error'.
6386 * doprnt.c (doprnt): Improve commentary.
6388 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6390 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6393 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6394 changes in globals.h immediately force recompilation.
6395 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6396 $(CURDIR)/s/ms-w32.h.
6397 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6399 * character.c (Fchar_direction): Function deleted.
6400 (syms_of_character): Don't defsubr it.
6401 <char-direction-table>: Deleted.
6403 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6405 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6406 * doprnt.c: Include limits.h.
6407 (SIZE_MAX): New macro.
6408 (doprnt): Return a size_t value. 2nd arg is now size_t.
6409 Many local variables are now size_t instead of int or unsigned.
6410 Improve overflow protection. Support `l' modifier for integer
6411 conversions. Support %l conversion. Don't assume an EMACS_INT
6412 argument for integer conversions and for %c.
6414 * lisp.h (doprnt): Restore prototype.
6416 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6419 * Makefile.in (base_obj): Add back doprnt.o.
6421 * deps.mk (doprnt.o): Add back prerequisites.
6422 (callint.o): Depend on character.h.
6424 * eval.c (internal_lisp_condition_case): Include the handler
6425 representation in the error message.
6426 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6427 when breaking from the loop.
6429 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6431 * callint.c (Fcall_interactively): When displaying error message
6432 about invalid control letter, pass the character's codepoint, not
6433 a pointer to its multibyte form. Improve display of the character
6434 in octal and display also its hex code.
6436 * character.c (char_string): Use %x to display the (unsigned)
6437 codepoint of an invalid character, to avoid displaying a bogus
6440 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6441 `error', not SYMBOL_NAME itself.
6443 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6444 character arguments to `error'.
6446 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6447 to `error' in error message about FINAL_CHAR argument. Make sure
6448 FINAL_CHAR is a character, and use %c when it is passed as
6449 argument to `error'.
6451 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6453 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6455 * w32.c: Include <time.h>.
6456 (sys_localtime): New function.
6458 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6460 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6462 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6464 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6466 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6469 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6471 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6472 gl_state.e_property when gl_state.object is Qt.
6474 * insdel.c (make_gap_larger): Remove limitation of buffer size
6477 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6479 * xdisp.c (lookup_glyphless_char_display)
6480 (produce_glyphless_glyph): Handle cons cell entry in
6481 glyphless-char-display.
6482 (Vglyphless_char_display): Document it.
6484 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6485 glyphless-char-display.
6487 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6489 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6491 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6493 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6494 definition for no-X builds.
6496 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6498 Static checks with GCC 4.6.0 and non-default toolkits.
6500 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6502 * process.c (keyboard_bit_set): Define only if SIGIO.
6503 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6504 (send_process): Repair possible setjmp clobbering.
6506 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6508 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6510 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6512 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6513 Define only if needed.
6515 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6516 by pacifying GCC about it. Maybe it's time to retire it?
6517 * xfaces.c (USG, __TIMEVAL__): Likewise.
6519 * dispextern.h (struct redisplay_interface): Rename param
6521 * termhooks.h (struct terminal): Likewise.
6522 * xterm.c (xembed_send_message): Likewise.
6524 * insdel.c (make_gap_smaller): Define only if
6525 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6527 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6530 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6531 so that we aren't warned about unused symbols.
6533 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6535 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6537 * xfns.c (x_real_positions): Mark locals as initialized.
6539 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6541 * xterm.c: Fix problems found by static analysis with other toolkits.
6542 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6543 (x_dispatch_event): Declare static if USE_GTK, and
6544 define if USE_GTK || USE_X_TOOLKIT.
6545 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6546 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6547 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6548 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6550 * xmenu.c (menu_help_callback): Pointer type fixes.
6551 Use const pointers when pointing at readonly data. Avoid pointer
6553 (FALSE): Remove unused macro.
6554 (update_frame_menubar): Remove unused decl.
6556 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6558 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6559 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6560 (single_menu_item): Rename local to avoid shadowing.
6562 * keyboard.c (make_lispy_event): Remove unused local var.
6564 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6565 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6567 * bitmaps: Change bitmaps from unsigned char back to the X11
6568 compatible char. Avoid the old compiler warnings about
6569 out-of-range initializers by using, for example, '\xab' rather
6572 * xgselect.c (xgselect_initialize): Check vs interface
6573 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6575 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6577 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6578 to read-only memory.
6580 * fns.c (vector): Remove; this old hack is no longer needed.
6582 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6584 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6586 * xrdb.c (x_load_resources): Omit unused local.
6588 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6589 (x_window): Rename locals to avoid shadowing.
6590 (USG): Use the kludged USG macro, to pacify gcc.
6592 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6593 (x_term_init): Remove local to avoid shadowing.
6595 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6597 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6598 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6600 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6602 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6604 Fix regex.c, syntax.c and friends for buffers > 2GB.
6605 * syntax.h (struct gl_state_s): Declare character position members
6608 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6610 * textprop.c (verify_interval_modification, interval_of):
6611 Declare arguments EMACS_INT.
6613 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6616 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6618 * indent.c (Fvertical_motion): Local variable it_start is now
6621 * regex.c (re_match, re_match_2, re_match_2_internal)
6622 (bcmp_translate, regcomp, regexec, print_double_string)
6623 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6624 (re_compile_pattern, re_exec): Declare arguments and local
6625 variables `size_t' and `ssize_t' and return values `regoff_t', as
6627 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6628 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6629 <compile_stack_type>: `size' and `avail' are now `size_t'.
6631 * regex.h <regoff_t>: Use ssize_t, not int.
6632 (re_search, re_search_2, re_match, re_match_2): Arguments that
6633 specify buffer/string position and length are now ssize_t and
6634 size_t. Return type is regoff_t.
6636 2011-04-16 Ben Key <bkey76@gmail.com>
6638 * nsfont.m: Fixed bugs in ns_get_family and
6639 ns_descriptor_to_entity that were caused by using free to
6640 deallocate memory blocks that were allocated by xmalloc (via
6641 xstrdup). This caused Emacs to crash when compiled with
6642 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6643 --enable-checking=xmallocoverrun). xfree is now used to
6644 deallocate these memory blocks.
6646 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6648 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6650 emacs_write: Accept and return EMACS_INT for sizes.
6651 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6653 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6654 Accept and return EMACS_INT.
6655 (emacs_gnutls_write): Return the number of bytes written on
6657 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6658 (emacs_read, emacs_write): Remove check for negative size, as the
6659 Emacs source code has been audited now.
6660 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6661 (emacs_read, emacs_write): Use it.
6662 * process.c (send_process): Adjust to the new signatures of
6663 emacs_write and emacs_gnutls_write. Do not attempt to store
6664 a byte offset into an 'int'; it might overflow.
6665 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6667 * sound.c: Don't assume sizes fit in 'int'.
6668 (struct sound_device.period_size, alsa_period_size):
6669 Return EMACS_INT, not int.
6670 (struct sound_device.write, vox_write, alsa_write):
6671 Accept EMACS_INT, not int.
6672 (wav_play, au_play): Use EMACS_INT to store sizes and to
6673 record read return values.
6675 2011-04-15 Ben Key <bkey76@gmail.com>
6677 * keyboard.c (Qundefined): Don't declare static since it is used
6679 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6680 static since they are used in nsfont.m.
6682 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6684 * process.c (Qprocessp): Don't declare static.
6685 * lisp.h (Qprocessp): Declare again.
6687 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6689 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6691 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6693 Improve C-level modularity by making more things 'static'.
6695 Don't publish debugger-only interfaces to other modules.
6696 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6697 (verify_bytepos, count_markers): Move decls to the only modules
6699 * region-cache.h (pp_cache): Likewise.
6700 * window.h (check_all_windows): Likewise.
6701 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6703 * sysdep.c (croak): Now static, if
6704 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6705 * syssignal.h (croak): Declare only if not static.
6707 * alloc.c (refill_memory_reserve): Now static if
6708 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6709 * lisp.h (refill_memory_reserve): Declare only if not static.
6711 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6712 Define only if USE_LUCID.
6714 * xrdb.c (x_customization_string, x_rm_string): Now static.
6716 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6717 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6719 * xdisp.c (draw_row_with_mouse_face): Now static.
6720 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6722 * window.h (check_all_windows): Mark externally visible.
6724 * window.c (window_deletion_count): Now static.
6726 * undo.c: Make symbols static if they're not exported.
6727 (last_undo_buffer, last_boundary_position, pending_boundary):
6730 * textprop.c (interval_insert_behind_hooks): Now static.
6731 (interval_insert_in_front_hooks): Likewise.
6733 * term.c: Make symbols static if they're not exported.
6734 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6735 (max_frame_lines, tty_set_terminal_modes):
6736 (tty_reset_terminal_modes, tty_turn_off_highlight):
6737 (get_tty_terminal): Now static.
6738 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6739 * termhooks.h (term_mouse_moveto): Do not declare if
6741 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6742 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6744 * sysdep.c: Make symbols static if they're not exported.
6745 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6747 (sigprocmask_set, full_mask): Remove; unused.
6748 (wait_debugging): Mark as visible.
6749 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6750 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6752 * syntax.c (syntax_temp): Define only if !__GNUC__.
6754 * sound.c (current_sound_device, current_sound): Now static.
6756 * search.c (searchbufs, searchbuf_head): Now static.
6758 * scroll.c (scroll_cost): Remove; unused.
6759 * dispextern.h (scroll_cost): Remove decl.
6761 * region-cache.h (pp_cache): Mark as externally visible.
6763 * process.c: Make symbols static if they're not exported.
6764 (process_tick, update_tick, create_process, chan_process):
6765 (Vprocess_alist, proc_buffered_char, datagram_access):
6766 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6767 (deactivate_process): Mark defn as static, as well as decl.
6768 * lisp.h (create_process): Remove decl.
6769 * process.h (chan_process, Vprocess_alist): Remove decls.
6771 * print.c: Make symbols static if they're not exported.
6772 (print_depth, new_backquote_output, being_printed, print_buffer):
6773 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6774 (print_interval, print_number_index, initial_stderr_stream):
6776 * lisp.h (Fprinc): Remove decl.
6777 (debug_output_compilation_hack): Mark as externally visible.
6779 * sysdep.c (croak): Move decl from here to syssignal.h.
6780 * syssignal.h (croak): Put it here, so the API can be checked when
6781 'croak' is called from dissociate_if_controlling_tty.
6783 * minibuf.c: Make symbols static if they're not exported.
6784 (minibuf_save_list, choose_minibuf_frame): Now static.
6785 * lisp.h (choose_minibuf_frame): Remove decl.
6787 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6789 * lread.c: Make symbols static if they're not exported.
6790 (read_objects, initial_obarray, oblookup_last_bucket_number):
6792 (make_symbol): Remove; unused.
6793 * lisp.h (initial_obarray, make_symbol): Remove decls.
6795 * keyboard.c: Make symbols static if they're not exported.
6796 (single_kboard, recent_keys_index, total_keys, recent_keys):
6797 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6798 (this_single_command_key_start, echoing, last_auto_save):
6799 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6800 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6801 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6802 (Vlispy_mouse_stem, double_click_count):
6804 (force_auto_save_soon): Define only if SIGDANGER.
6805 (ignore_mouse_drag_p): Now static if
6806 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6807 (print_help): Remove; unused.
6808 (stop_character, last_timer_event): Mark as externally visible.
6809 * keyboard.h (ignore_mouse_drag_p): Declare only if
6810 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6811 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6812 * lisp.h (echoing): Remove decl.
6813 (force_auto_save_soon): Declare only if SIGDANGER.
6814 * xdisp.c (redisplay_window): Simplify code, to make it more
6815 obvious that ignore_mouse_drag_p is not accessed if !defined
6816 USE_GTK && !defined HAVE_NS.
6818 * intervals.c: Make symbols static if they're not exported.
6819 (merge_properties_sticky, merge_interval_right, delete_interval):
6821 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6823 * insdel.c: Make symbols static if they're not exported.
6824 However, leave prepare_to_modify_buffer alone. It's never
6825 called from outside this function, but that appears to be a bug.
6826 (combine_after_change_list, combine_after_change_buffer):
6827 (adjust_after_replace, signal_before_change): Now static.
6828 (adjust_after_replace_noundo): Remove; unused.
6829 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6830 (signal_before_change): Remove decls.
6832 * indent.c (val_compute_motion, val_vmotion): Now static.
6834 * image.c: Make symbols static if they're not exported.
6835 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6837 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6838 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6840 * fringe.c (standard_bitmaps): Now static.
6841 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6843 * frame.c: Make symbols static if they're not exported.
6844 (x_report_frame_params, make_terminal_frame): Now static.
6845 (get_frame_param): Now static, unless HAVE_NS.
6846 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6847 (x_get_resource_string): Remove; not used.
6848 * frame.h (make_terminal_frame, x_report_frame_params):
6849 (x_get_resource_string); Remove decls.
6850 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6851 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6853 * font.c, fontset.c: Make symbols static if they're not exported.
6854 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6855 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6856 * font.c (font_close_object): Now static.
6857 * font.h (font_close_object): Remove.
6858 * fontset.c (FONTSET_OBJLIST): Remove.
6859 (free_realized_fontset) #if-0 the body, which does nothing.
6860 (face_suitable_for_char_p): #if-0, as it's never called.
6861 * fontset.h (face_suitable_for_char_p): Remove decl.
6862 * xfaces.c (face_at_string_position):
6863 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6864 since 0 is always ASCII.
6866 * fns.c (weak_hash_tables): Now static.
6868 * fileio.c: Make symbols static if they're not exported.
6869 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6870 (Vwrite_region_annotation_buffers): Now static.
6872 * eval.c: Make symbols static if they're not exported.
6873 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6874 * lisp.h (backtrace_list): Remove decl.
6876 * emacs.c: Make symbols static if they're not exported.
6877 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6878 (fatal_error_code, fatal_error_signal_hook, standard_args):
6880 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6881 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6882 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6883 * lisp.h (fatal_error_signal_hook): Remove decl.
6884 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6886 * editfns.c: Move a (normally-unused) function to its only use.
6887 * editfns.c, lisp.h (get_operating_system_release): Remove.
6888 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6889 worth the hassle of breaking this out.
6891 * xterm.c: Make symbols static if they're not exported.
6892 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6893 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6894 (x_destroy_window, x_delete_display):
6896 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6897 (x_mouse_leave): Remove; unused.
6898 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6899 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6900 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6902 (x_mouse_leave): Declare only if WINDOWSNT.
6903 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6904 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6907 * ftxfont.c: Make symbols static if they're not exported.
6908 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6910 * font.h (ftxfont_driver): Likewise.
6912 * xfns.c: Make symbols static if they're not exported.
6913 (x_last_font_name, x_display_info_for_name):
6914 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6915 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6916 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6917 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6918 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6919 (last_show_tip_args): Now static.
6920 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6921 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6922 (x_screen_planes): Remove; unused.
6923 * dispextern.h (x_screen_planes): Remove decl.
6925 * dispnew.c: Make symbols static if they're not exported.
6926 * dispextern.h (redraw_garbaged_frames, scrolling):
6927 (increment_row_positions): Remove.
6928 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6929 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6931 (redraw_garbaged_frames): Remove; unused.
6933 * xfaces.c: Make symbols static if they're not exported.
6934 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6936 * xterm.h (defined_color): Remove decls.
6937 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6938 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6939 (menu_face_changed_default, defined_color, free_realized_face):
6940 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6941 (ascii_face_of_lisp_face): Remove; unused.
6943 * xdisp.c: Make symbols static if they're not exported.
6944 * dispextern.h (scratch_glyph_row, window_box_edges):
6945 (glyph_to_pixel_coords, set_cursor_from_row):
6946 (get_next_display_element, set_iterator_to_next):
6947 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6948 (show_mouse_face): Remove decls
6949 * frame.h (message_buf_print): Likewise.
6950 * lisp.h (pop_message, set_message, check_point_in_composition):
6952 * xterm.h (set_vertical_scroll_bar): Likewise.
6953 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6954 (message_buf_print, scratch_glyph_row, displayed_buffer):
6955 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6956 (get_next_display_element, show_mouse_face, window_box_edges):
6957 (frame_to_window_pixel_xy, check_point_in_composition):
6958 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6959 (glyph_to_pixel_coords): Remove; unused.
6961 * dired.c (file_name_completion): Now static.
6963 * dbusbind.c (xd_in_read_queued_messages): Now static.
6965 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6966 * data.c (circular_list_error): Remove.
6968 * commands.h (last_point_position, last_point_position_buffer):
6969 (last_point_position_window): Remove decls.
6970 * keyboard.c: Make these variables static.
6972 * coding.h (coding, code_convert_region, encode_coding_gap):
6974 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6975 (iso_code_class, detect_coding, code_convert_region): Now static.
6976 (encode_coding_gap): Remove; unused.
6978 * chartab.c (chartab_chars, chartab_bits): Now static.
6980 * charset.h (charset_iso_8859_1): Remove decl.
6981 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6984 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6985 * ccl.c (Vccl_program_table): Now static.
6986 (check_ccl_update): Remove; unused.
6988 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6989 * category.h: ... from here.
6990 * category.c (check_category_table, set_category_set): Now static.
6992 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6993 * lisp.h: Remove these decls.
6995 * buffer.c (buffer_count): Remove unused var.
6997 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6998 so that it's not optimized away.
6999 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7000 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7001 exported only to the debugger.
7003 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7004 * atimer.h (run_all_atimers): Remove; not exported.
7006 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7007 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7008 was inaccessible from Lisp.
7009 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7010 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7012 alloc.c: Import and export fewer symbols, and remove unused items.
7013 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7015 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7016 it's not optimized away by whole-program optimization.
7017 (message_enable_multibyte, free_misc): Remove.
7018 (catchlist, handlerlist, mark_backtrace):
7019 Declare only if BYTE_MARK_STACK.
7020 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7021 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7022 (message_enable_multibyte): Remove decl.
7023 (free_misc, interval_free_list, float_block, float_block_index):
7024 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7025 (cons_free_list, last_marked_index):
7027 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7028 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7029 (mark_backtrace): Define only if BYTE_MARK_STACK.
7030 * xdisp.c (message_enable_multibyte): Now static.
7032 Declare Lisp_Object Q* variables to be 'static' if not exported.
7033 This makes it easier for human readers (and static analyzers)
7034 to see whether these variables are used from other modules.
7035 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7036 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7037 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7038 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7039 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7040 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7041 * xmenu.c, xselect.c:
7042 Declare Q* vars static if they are not used in other modules.
7043 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7044 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7045 Remove decls of unexported vars.
7046 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7048 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7050 Make Emacs functions such as Fatom 'static' by default.
7051 This makes it easier for human readers (and static analyzers)
7052 to see whether these functions can be called from other modules.
7053 DEFUN now defines a static function. To make the function external
7054 so that it can be used in other C modules, use the new macro DEFUE.
7055 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7056 (Finit_image_library):
7057 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7058 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7059 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7060 Remove decls, since these functions are now static.
7061 (Funintern, Fget_internal_run_time): New decls, since these functions
7062 were already external.
7064 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7065 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7066 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7067 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7068 * keyboard.c, keymap.c, lread.c:
7069 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7070 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7071 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7072 Mark functions with DEFUE instead of DEFUN,
7073 if they are used in other modules.
7074 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7075 decls for now-static functions.
7076 * buffer.h (Fdelete_overlay): Remove decl.
7077 * callproc.c (Fgetenv_internal): Mark as internal.
7078 * composite.c (Fremove_list_of_text_properties): Remove decl.
7079 (Fcomposition_get_gstring): New forward static decl.
7080 * composite.h (Fcomposite_get_gstring): Remove decl.
7081 * dired.c (Ffile_attributes): New forward static decl.
7082 * doc.c (Fdocumntation_property): New forward static decl.
7083 * eval.c (Ffetch_bytecode): New forward static decl.
7084 (Funintern): Remove extern decl; now in .h file where it belongs.
7085 * fileio.c (Fmake_symbolic_link): New forward static decl.
7086 * image.c (Finit_image_library): New forward static decl.
7087 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7088 * intervals.h (Fprevious_property_change):
7089 (Fremove_list_of_text_properties): Remove decls.
7090 * keyboard.c (Fthis_command_keys): Remove decl.
7091 (Fcommand_execute): New forward static decl.
7092 * keymap.c (Flookup_key): New forward static decl.
7093 (Fcopy_keymap): Now static.
7094 * keymap.h (Flookup_key): Remove decl.
7095 * process.c (Fget_process): New forward static decl.
7096 (Fprocess_datagram_address): Mark as internal.
7097 * syntax.c (Fsyntax_table_p): New forward static decl.
7098 (skip_chars): Remove duplicate decl.
7099 * textprop.c (Fprevious_property_change): New forward static decl.
7100 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7102 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7103 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7105 * editfns.c (Fformat): Remove unreachable code.
7107 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7109 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7112 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7114 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7115 when at ZV. (Bug#8487)
7117 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7119 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7121 * keyboard.c (parse_tool_bar_item): Likewise.
7122 * sound.c (sound_cleanup, alsa_close): Likewise.
7123 * termcap.c (tgetent): Likewise.
7124 * xfns.c (x_default_font_parameter): Likewise.
7125 * xsettings.c (read_and_apply_settings): Likewise.
7127 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7128 (overrun_check_free): Protoize.
7130 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7132 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7133 since callers should never pass a negative size.
7134 Change the signature to match that of plain 'read' and 'write'; see
7135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7136 * lisp.h: Update prototypes of emacs_write and emacs_read.
7138 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7140 * xdisp.c (redisplay_window): Don't try to determine the character
7141 position of the scroll margin if the window start point w->startp
7142 is outside the buffer's accessible region. (Bug#8468)
7144 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7146 Fix write-region and its subroutines for buffers > 2GB.
7147 * fileio.c (a_write, e_write): Modify declaration of arguments and
7148 local variables to support buffers larger than 2GB.
7149 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7151 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7152 argument, local variables, and return value.
7154 * lisp.h: Update prototypes of emacs_write and emacs_read.
7156 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7158 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7160 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7162 Fix more problems found by GCC 4.6.0's static checks.
7164 * xdisp.c (vmessage): Use a better test for character truncation.
7166 * charset.c (load_charset_map): <, not <=, for optimization,
7167 and to avoid potential problems with integer overflow.
7168 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7169 * casetab.c (set_identity, shuffle): Likewise.
7170 * editfns.c (Fformat): Likewise.
7171 * syntax.c (skip_chars): Likewise.
7173 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7174 This also lets GCC 4.6.0 generate slightly better loop code.
7176 * callint.c (Fcall_interactively): <, not <=, for optimization.
7177 (Fcall_interactively): Count the number of arguments produced,
7178 not the number of arguments given. This is simpler and lets GCC
7179 4.6.0 generate slightly better code.
7181 * ftfont.c: Distingish more carefully between FcChar8 and char.
7182 The previous code passed unsigned char * to a functions like
7183 strlen and xstrcasecmp that expect char *, which does not
7184 conform to the C standard.
7185 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7186 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7187 char * when the C standard requires it.
7189 * keyboard.c (read_char): Remove unused var.
7191 * eval.c: Port to Windows vsnprintf (Bug#8435).
7193 (SIZE_MAX): Define if the headers do not.
7194 (verror): Do not give up if vsnprintf returns a negative count.
7195 Instead, grow the buffer. This ports to Windows vsnprintf, which
7196 does not conform to C99. Problem reported by Eli Zaretskii.
7197 Also, simplify the allocation scheme, by avoiding the need for
7198 calling realloc, and removing the ALLOCATED variable.
7200 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7202 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7203 But keep the doprint source code for now, as we might revamp it
7204 and use it again (Bug#8435).
7205 * lisp.h (doprnt): Remove.
7206 * Makefile.in (base_obj): Remove doprnt.o.
7207 * deps.mk (doprnt.o): Remove.
7209 error: Print 32- and 64-bit integers portably (Bug#8435).
7210 Without this change, on typical 64-bit hosts error ("...%d...", N)
7211 was used to print both 32- and 64-bit integers N, which relied on
7213 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7215 * lisp.h (error, verror): Mark as printf-like functions.
7216 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7217 Report overflow in size calculations when allocating printf buffer.
7218 Do not truncate output string at its first null byte.
7219 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7220 Truncate the output at a character boundary, since vsnprintf does not
7222 * charset.c (check_iso_charset_parameter): Convert internal
7223 character to string before calling 'error', since %c now has the
7225 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7226 overflow when computing char to be passed to 'error'. Do not
7227 pass Lisp_Object to 'error'; pass the integer instead.
7228 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7229 formatted with plain %d.
7231 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7233 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7235 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7237 * xterm.c (x_catch_errors): Remove duplicate declaration.
7239 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7241 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7243 2011-04-10 Jim Meyering <meyering@redhat.com>
7245 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7246 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7247 return ssize_t not "int", and use size_t as the buffer length.
7248 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7249 * gnutls.h: Update declarations.
7250 * process.c (read_process_output): Use ssize_t, to match.
7251 (send_process): Likewise.
7253 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7255 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7257 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7259 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7260 Use unsigned char, to match FcChar8 type definition.
7262 * xterm.c (handle_one_xevent):
7263 * xmenu.c (create_and_show_popup_menu):
7264 * xselect.c (x_decline_selection_request)
7265 (x_reply_selection_request): Avoid type-punned deref of X events.
7267 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7269 Fix some uses of `int' instead of EMACS_INT.
7270 * search.c (string_match_1, fast_string_match)
7271 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7272 (scan_buffer, find_next_newline_no_quit)
7273 (find_before_next_newline, search_command, Freplace_match)
7274 (Fmatch_data): Make some `int' variables be EMACS_INT.
7276 * xdisp.c (display_count_lines): 3rd argument and return value now
7277 EMACS_INT. All callers changed.
7278 (pint2hrstr): Last argument is now EMACS_INT.
7280 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7281 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7282 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7283 (decode_coding_utf_16, decode_coding_emacs_mule)
7284 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7285 (decode_coding_ccl, decode_coding_charset)
7286 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7287 (decode_coding_iso_2022, decode_coding_emacs_mule)
7288 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7289 <char_offset, last_offset>: Declare EMACS_INT.
7290 (encode_coding_utf_8, encode_coding_utf_16)
7291 (encode_coding_emacs_mule, encode_invocation_designation)
7292 (encode_designation_at_bol, encode_coding_iso_2022)
7293 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7294 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7296 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7297 (encode_invocation_designation): Last argument P_NCHARS is now
7299 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7300 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7302 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7305 * ccl.c (Fccl_execute_on_string): Declare some variables
7308 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7310 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7312 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7314 * process.c (Fformat_network_address): Doc fix.
7316 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7318 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7320 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7322 * keyboard.c (read_char): Call Lisp function help-form-show,
7323 instead of using internal_with_output_to_temp_buffer.
7324 (Qhelp_form_show): New var.
7325 (syms_of_keyboard): Use DEFSYM macro.
7327 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7329 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7331 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7333 * process.c (Flist_processes): Remove to Lisp.
7334 (list_processes_1): Delete.
7336 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7338 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7340 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7342 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7344 Fix more problems found by GCC 4.6.0's static checks.
7346 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7348 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7350 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7352 * xdisp.c (vmessage): Mark as a printf-like function.
7354 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7356 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7358 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7359 printf-like functions.
7360 (tiff_load): Add casts to remove these marks before passing them
7361 to system-supplied API.
7363 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7365 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7366 This avoids several warnings with gcc -Wstrict-overflow.
7367 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7368 directly, rather than having caller test rule sign. This avoids
7369 some unnecessary tests.
7370 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7371 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7372 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7374 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7375 (xfont_open): Avoid unnecessary tests.
7377 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7379 * composite.h, composite.c (composition_gstring_put_cache):
7380 Use EMACS_INT, not int, for length.
7382 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7383 breaking out part of COMPOSITION_DECODE_RULE.
7384 (COMPOSITION_DECODE_RULE): Use it.
7385 * composite.c (get_composition_id): Remove unused local vars,
7386 by using the new macro.
7388 * textprop.c (set_text_properties_1): Change while to do-while,
7389 since the condition is always true at first.
7391 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7392 (interval_deletion_adjustment): Return unsigned value.
7395 * process.c (list_processes_1, create_pty, read_process_output):
7396 (exec_sentinel): Remove vars that were set but not used.
7397 (create_pty): Remove unnecessary "volatile"s.
7398 (Fnetwork_interface_info): Avoid possibility of int overflow.
7399 (read_process_output): Do adaptive read buffering even if carryover.
7400 (read_process_output): Simplify nbytes computation if buffered.
7402 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7404 * syntax.c (scan_words): Remove var that was set but not used.
7405 (update_syntax_table): Use unsigned instead of int.
7407 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7408 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7409 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7411 * print.c (print_error_message): Avoid int overflow.
7413 * font.c (font_list_entities): Redo for clarity,
7414 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7416 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7417 (font_score): Avoid potential overflow in diff calculation.
7419 * fns.c (substring_both): Remove var that is set but not used.
7420 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7422 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7424 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7425 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7426 can always succeed if overflow has undefined behavior.
7428 * search.c (boyer_moore, wordify): Remove vars set but not used.
7429 (wordify): Omit three unnecessary tests.
7431 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7432 All callers changed. This avoids the need for an unused var.
7434 * casefiddle.c (casify_region): Remove var that is set but not used.
7436 * dired.c (file_name_completion): Remove var that is set but not used.
7438 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7440 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7441 (Finsert_file_contents): Remove unnecessary code checking fd.
7443 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7444 Check for integer overflow on size calculations.
7446 * buffer.c (Fprevious_overlay_change): Remove var that is set
7449 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7450 Remove vars that are set but not used.
7451 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7452 (timer_check_2): Mark vars as initialized.
7454 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7456 * image.c (lookup_image): Remove var that is set but not used.
7457 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7459 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7460 that are set but not used.
7462 * xfns.c (make_invisible_cursor): Don't return garbage
7463 if XCreateBitmapFromData fails (Bug#8410).
7465 * xselect.c (x_get_local_selection, x_handle_property_notify):
7466 Remove vars that are set but not used.
7468 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7469 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7471 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7472 Remove var that is set but not used.
7473 (scroll_bar_windows_size): Now size_t, not int.
7474 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7477 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7478 (map_tty_color) [!defined MSDOS]: Likewise.
7480 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7482 * coding.c: Remove vars that are set but not used.
7483 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7484 All callers changed.
7485 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7486 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7487 (decode_coding_charset): Remove vars that are set but not used.
7489 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7490 that is set but not used.
7492 * print.c (print_object): Remove var that is set but not used.
7494 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7495 The gnulib version avoids calling malloc in the usual case,
7496 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7497 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7498 * filelock.c (current_lock_owner): Likewise.
7499 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7500 * sysdep.c: Include allocator.h, careadlinkat.h.
7501 (emacs_no_realloc_allocator): New static constant.
7502 (emacs_readlink): New function.
7503 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7504 ../lib/careadlinkat.h.
7506 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7508 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7509 first non-nil return value).
7511 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7513 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7514 if not defined (Bug#8403).
7516 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7518 * xdisp.c (display_count_lines): Remove parameter `start',
7519 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7520 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7521 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7522 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7523 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7524 and thereabouts. All callers changed.
7525 (get_per_char_metric): Remove parameter `f', unused since
7526 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7528 2011-04-02 Jim Meyering <meyering@redhat.com>
7530 do not dereference NULL upon failed strdup
7531 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7532 (ns_get_family): Likewise.
7534 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7536 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7538 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7540 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7543 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7545 Add lexical binding.
7547 * window.c (Ftemp_output_buffer_show): New fun.
7548 (Fsave_window_excursion):
7549 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7551 * lread.c (lisp_file_lexically_bound_p): New function.
7552 (Fload): Bind Qlexical_binding.
7553 (readevalloop): Remove `evalfun' arg.
7554 Bind Qinternal_interpreter_environment.
7555 (Feval_buffer): Bind Qlexical_binding.
7556 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7558 (syms_of_lread): Declare `lexical-binding'.
7560 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7562 * keyboard.c (eval_dyn): New fun.
7563 (menu_item_eval_property): Use it.
7565 * image.c (parse_image_spec): Use Ffunctionp.
7567 * fns.c (concat, mapcar1): Accept byte-code-functions.
7569 * eval.c (Fsetq): Handle lexical vars.
7570 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7571 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7572 (FletX, Flet): Obey lexical binding.
7573 (Fcommandp): Handle closures.
7574 (Feval): New `lexical' arg.
7575 (eval_sub): New function extracted from Feval. Use it almost
7576 everywhere where Feval was used. Look up vars in lexical env.
7578 (Ffunctionp): Move from subr.el.
7579 (Ffuncall): Handle closures.
7580 (apply_lambda): Remove `eval_flags'.
7581 (funcall_lambda): Handle closures and new byte-code-functions.
7582 (Fspecial_variable_p): New function.
7583 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7584 but without exporting it to Lisp.
7586 * doc.c (Fdocumentation, store_function_docstring):
7587 * data.c (Finteractive_form): Handle closures.
7589 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7592 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7594 (exec_byte_code): New function extracted from Fbyte_code to handle new
7595 calling convention for byte-code-functions. Add new byte-codes.
7597 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7599 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7601 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7603 * xdisp.c (redisplay_internal): Fix prototype.
7605 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7607 * xdisp.c (SCROLL_LIMIT): New macro.
7608 (try_scrolling): Use it when setting scroll_limit.
7609 Limit scrolling to 100 screen lines.
7610 (redisplay_window): Even when falling back on "recentering",
7611 position point in the window according to scroll-conservatively,
7612 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7614 (try_scrolling): When point is above the window, allow searching
7615 as far as scroll_max, or one screenful, to compute vertical
7616 distance from PT to the scroll margin position. This prevents
7617 try_scrolling from unnecessarily failing when
7618 scroll-conservatively is set to a value slightly larger than the
7619 window height. Clean up the case of PT below the margin at bottom
7620 of window: scroll_max can no longer be INT_MAX. When aggressive
7621 scrolling is in use, don't let point enter the opposite scroll
7622 margin as result of the scroll.
7623 (syms_of_xdisp) <scroll-conservatively>: Document the
7624 threshold of 100 lines for never-recentering scrolling.
7626 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7628 * dispextern.h (move_it_by_lines):
7629 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7630 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7631 (message_log_check_duplicate): Remove parameters `prev_bol' and
7632 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7633 (redisplay_internal): Remove parameter `preserve_echo_area',
7634 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7636 * indent.c (Fvertical_motion):
7637 * window.c (window_scroll_pixel_based, Frecenter):
7638 Don't pass `need_y_p' to `move_it_by_lines'.
7640 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7642 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7643 steal a few bits to be more compact.
7644 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7645 Remove unneeded casts.
7647 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7649 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7651 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7652 binding" message (bug#7967).
7654 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7656 Fix more problems found by GCC 4.6.0's static checks.
7658 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7659 Remove unused local var.
7661 * editfns.c (Fmessage_box): Remove unused local var.
7663 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7664 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7665 Omit unused local vars.
7666 * window.c (shrink_windows): Omit unused local var.
7667 * menu.c (digest_single_submenu): Omit unused local var.
7668 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7669 Omit unused local var.
7671 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7672 Don't assume string length fits in int.
7673 (keyremap_step, read_key_sequence): Use size_t for sizes.
7674 (read_key_sequence): Don't check last_real_key_start redundantly.
7676 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7677 instead of alloca (Bug#8344).
7679 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7680 (Fbacktrace_frame): Don't assume nframes fits in int.
7682 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7684 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7687 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7689 * cm.c (calccost): Turn while-do into do-while, for clarity.
7691 * keyboard.c (syms_of_keyboard): Use the same style as later
7692 in this function when indexing through an array. This also
7693 works around GCC bug 48267.
7695 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7697 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7699 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7700 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7702 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7703 This avoids undefined behavior on integer overflow, and is a bit
7704 more convenient anyway since it is compared to a size_t variable.
7706 Variadic C functions now count arguments with size_t, not int.
7707 This avoids an unnecessary limitation on 64-bit machines, which
7708 caused (substring ...) to crash on large vectors (Bug#8344).
7709 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7710 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7711 All variadic functions and their callers changed accordingly.
7712 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7713 * data.c (arith_driver, float_arith_driver): Likewise.
7714 * editfns.c (general_insert_function): Likewise.
7715 * eval.c (struct backtrace.nargs, interactive_p)
7716 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7717 (funcall_lambda, mark_backtrace): Likewise.
7718 * fns.c (concat): Likewise.
7719 * frame.c (x_set_frame_parameters): Likewise.
7720 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7721 0 if not found, not -1. All callers changed.
7723 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7724 (stack_copy_size): Now size_t, not int.
7725 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7727 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7729 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7730 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7731 All callers changed.
7733 * lisp.h (multibyte_char_to_unibyte):
7734 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7735 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7736 * character.h (CHAR_TO_BYTE8):
7737 * cmds.c (internal_self_insert):
7738 * editfns.c (general_insert_function):
7739 * keymap.c (push_key_description):
7740 * search.c (Freplace_match):
7741 * xdisp.c (message_dolog, set_message_1): All callers changed.
7743 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7745 * keyboard.c (safe_run_hook_funcall): New function.
7746 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7747 don't set the hook to nil, but remove the offending function instead.
7748 (Qcommand_hook_internal): Remove, unused.
7749 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7750 Vcommand_hook_internal.
7752 * eval.c (enum run_hooks_condition): Remove.
7753 (funcall_nil, funcall_not): New functions.
7754 (run_hook_with_args): Call each function through a `funcall' argument.
7755 Remove `cond' argument, now redundant.
7756 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7757 (Frun_hook_with_args_until_failure): Adjust accordingly.
7758 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7760 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7762 * dispextern.h (string_buffer_position): Remove declaration.
7764 * print.c (strout): Remove parameter `multibyte', unused since
7765 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7767 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7768 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7769 All callers changed.
7771 * w32.c (_wsa_errlist): Use braces for struct initializers.
7773 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7774 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7775 All callers changed.
7776 (string_buffer_position): Likewise. Also, make static (it's never
7777 used outside xdisp.c).
7778 (cursor_row_p): Remove parameter `w', unused since
7779 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7780 (decode_mode_spec): Remove parameter `precision', introduced during
7781 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7782 All callers changed.
7784 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7786 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7788 2011-03-27 Anders Lindgren <andlind@gmail.com>
7790 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7791 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7792 (ns_update_auto_hide_menu_bar): New functions.
7793 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7794 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7795 ns_constrain_all_frames.
7796 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7797 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7799 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7801 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7803 2011-03-27 Glenn Morris <rgm@gnu.org>
7805 * syssignal.h: Replace RETSIGTYPE with void.
7806 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7807 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7808 Replace SIGTYPE with void everywhere.
7809 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7810 * s/template.h (SIGTYPE): Remove commented out definition.
7812 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7814 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7815 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7817 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7819 * w32.c (read_unc_volume): Use parameter `henum', instead of
7820 global variable `wget_enum_handle'.
7822 * keymap.c (describe_vector): Remove parameters `indices' and
7823 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7824 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7826 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7828 * keyboard.c (timer_check): Remove parameter `do_it_now',
7829 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7830 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7831 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7833 * keyboard.c (read_char):
7834 * w32menu.c (w32_menu_display_help):
7835 * xmenu.c (show_help_event, menu_help_callback):
7836 Adjust calls to `show_help_echo'.
7838 * gtkutil.c (xg_maybe_add_timer):
7839 * keyboard.c (readable_events):
7840 * process.c (wait_reading_process_output):
7841 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7843 * insdel.c (adjust_markers_gap_motion):
7844 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7845 (gap_left, gap_right): Don't call it.
7847 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7849 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7850 incurred during fontification.
7852 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7854 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7855 (DEFVAR_PER_BUFFER): Don't pass it.
7857 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7858 (scrolling_window): Don't pass it.
7860 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7862 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7864 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7866 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7867 of variables specific to SELinux and computation of `encoded_absname'.
7869 * image.c (XPutPixel): Remove unused variable `height'.
7871 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7873 * unexw32.c (get_section_info): Remove unused variable `section'.
7875 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7876 (system_process_attributes): Remove unused variable `sess'.
7877 (sys_read): Remove unused variable `err'.
7879 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7880 (w32_wnd_proc): Remove unused variable `isdead'.
7881 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7882 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7883 (x_create_tip_frame): Remove unused variable `tem'.
7885 * w32inevt.c (w32_console_read_socket):
7886 Remove unused variable `no_events'.
7888 * w32term.c (x_draw_composite_glyph_string_foreground):
7889 Remove unused variable `width'.
7891 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7893 * w32term.c (x_set_glyph_string_clipping):
7894 Don't pass uninitialized region to CombineRgn.
7896 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7898 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7899 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7900 (Fx_close_connection): Remove unused variable `i'.
7902 * w32font.c (w32font_draw): Return number of glyphs.
7903 (w32font_open_internal): Remove unused variable `i'.
7904 (w32font_driver): Add missing initializer.
7906 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7907 (fill_in_menu): Remove unused variable `items_added'.
7909 * w32term.c (last_mouse_press_frame): Remove static global variable.
7910 (w32_clip_to_row): Remove unused variable `f'.
7911 (x_delete_terminal): Remove unused variable `i'.
7913 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7914 (NOTHING): Remove unused static global variable.
7915 (uniscribe_check_otf): Remove unused variable `table'.
7916 (uniscribe_font_driver): Add missing initializers.
7918 2011-03-23 Julien Danjou <julien@danjou.info>
7920 * term.c (Fsuspend_tty, Fresume_tty):
7921 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7922 * window.c (temp_output_buffer_show):
7923 * insdel.c (signal_before_change):
7924 * frame.c (Fhandle_switch_frame):
7925 * fileio.c (Fdo_auto_save):
7926 * emacs.c (Fkill_emacs):
7927 * editfns.c (save_excursion_restore):
7928 * cmds.c (internal_self_insert):
7929 * callint.c (Fcall_interactively):
7930 * buffer.c (Fkill_all_local_variables):
7931 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7933 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7934 unconditionnaly since it does the check itself.
7936 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7938 Fix more problems found by GCC 4.5.2's static checks.
7940 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7941 the first time through the loop, since we know p0 < p1 then.
7942 This also avoids a gcc -Wstrict-overflow warning.
7944 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7945 leading to a memory leak, possible in functions like
7946 load_charset_map_from_file that can allocate an unbounded number
7947 of objects (Bug#8318).
7949 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7950 that could (at least in theory) be that large.
7952 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7953 This is less likely to overflow, and avoids undefined behavior if
7954 overflow does occur. All callers changed. Use strtoul to scan
7955 for the unsigned long integer.
7956 (pint2hrstr): Simplify and tune code slightly.
7957 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7959 * scroll.c (do_scrolling): Work around GCC bug 48228.
7960 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7962 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7963 This also avoids a warning with gcc -Wstrict-overflow.
7964 (validate_x_resource_name): Simplify count usage.
7965 This also avoids a warning with gcc -Wstrict-overflow.
7967 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7970 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7972 * process.c (Fmake_network_process): Use socklen_t, not int,
7973 where POSIX says socklen_t is required in portable programs.
7974 This fixes a porting bug on hosts like 64-bit HP-UX, where
7975 socklen_t is wider than int (Bug#8277).
7976 (Fmake_network_process, server_accept_connection):
7977 (wait_reading_process_output, read_process_output):
7980 * process.c: Rename or move locals to avoid shadowing.
7981 (list_processes_1, Fmake_network_process):
7982 (read_process_output_error_handler, exec_sentinel_error_handler):
7983 Rename or move locals.
7984 (Fmake_network_process): Define label "retry_connect" only if needed.
7985 (Fnetwork_interface_info): Fix pointer signedness.
7986 (process_send_signal): Add cast to avoid pointer signedness problem.
7987 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7988 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7990 Make tparam.h and terminfo.c consistent.
7991 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7992 Include tparam.h instead, since it declares them.
7993 * cm.h (PC): Remove extern decl; tparam.h now does this.
7994 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7995 * terminfo.c: Include tparam.h, to check interfaces.
7996 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7997 (tparam): Adjust signature to match interface in tparam.h;
7998 this removes some undefined behavior. Check that outstring and len
7999 are zero, which they always are with Emacs.
8000 * tparam.h (PC, BC, UP): New extern decls.
8002 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8003 (xftfont_open): Rename locals to avoid shadowing.
8005 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8006 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8007 (OTF_TAG_SYM): Omit macro if not needed.
8008 (ftfont_list): Remove unused local.
8009 (get_adstyle_property, ftfont_pattern_entity):
8010 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8011 Rename locals to avoid shadowing.
8013 * xfont.c (xfont_list_family): Mark var as initialized.
8015 * xml.c (make_dom): Now static.
8017 * composite.c (composition_compute_stop_pos): Rename local to
8019 (composition_reseat_it): Remove unused locals.
8020 (find_automatic_composition, composition_adjust_point): Likewise.
8021 (composition_update_it): Mark var as initialized.
8022 (find_automatic_composition): Mark vars as initialized,
8023 with a FIXME (Bug#8290).
8025 character.h: Rename locals to avoid shadowing.
8026 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8027 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8028 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8029 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8032 * textprop.c (property_change_between_p): Remove; unused.
8034 * intervals.c (interval_start_pos): Now static.
8036 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8038 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8039 Rename locals to avoid shadowing.
8041 * sound.c (wav_play, au_play, Fplay_sound_internal):
8042 Fix pointer signedness.
8043 (alsa_choose_format): Remove unused local var.
8044 (wav_play): Initialize a variable to 0, to prevent undefined
8045 behavior (Bug#8278).
8047 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8049 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8051 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8052 clobbering (Bug#8298).
8053 * sysdep.c (sys_subshell): Likewise.
8054 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8056 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8057 This should get cleaned up, so that child_setup has the
8058 same signature on all platforms.
8060 * callproc.c (call_process_cleanup): Now static.
8061 (relocate_fd): Rename locals to avoid shadowing.
8063 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8065 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8066 not to be necessary, and produces flickering.
8068 2011-03-20 Glenn Morris <rgm@gnu.org>
8070 * config.in: Remove file.
8072 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8074 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8075 are now in src/globals.h.
8076 (syms_of_minibuf): Remove spurious & from previous change.
8078 2011-03-20 Leo <sdl.web@gmail.com>
8080 * minibuf.c (completing-read-function): New variable.
8081 (completing-read-default): Rename from completing-read.
8082 (completing-read): Call completing-read-function.
8084 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8086 * xfaces.c (Fx_load_color_file):
8087 Read color file from absolute filename (bug#8250).
8089 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8091 * makefile.w32-in: Update dependencies.
8093 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8095 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8097 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8099 Fix more problems found by GCC 4.5.2's static checks.
8101 * process.c (make_serial_process_unwind, send_process_trap):
8102 (sigchld_handler): Now static.
8104 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8105 That way, the code declares only the vars that it needs.
8106 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8107 * s/cygwin.h (PTY_ITERATION): Likewise.
8108 * s/darwin.h (PTY_ITERATION): Likewise.
8109 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8111 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8112 * process.c (allocate_pty): Don't declare stb unless it's needed.
8114 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8115 (CONSTANTLIM): Remove; unused.
8116 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8117 Define only if needed.
8119 * unexelf.c (unexec): Name an expression,
8120 to avoid gcc -Wbad-function-cast warning.
8121 Use a different way to cause a compilation error if anyone uses
8122 n rather than nn, a way that does not involve shadowing.
8123 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8125 * deps.mk (unexalpha.o): Remove; unused.
8127 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8128 * unexec.h: New file.
8129 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8130 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8132 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8133 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8134 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8135 Change as necessary to match prototype in unexec.h.
8137 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8139 (back_comment, skip_chars): Mark vars as initialized.
8141 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8142 Rename locals to avoid shadowing.
8144 * lread.c (read1): Rewrite so as not to use empty "else".
8145 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8147 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8149 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8150 warning when compiling print.c.
8152 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8153 instead of using an uninitialized var.
8154 (font_sort_entities): Mark var as initialized.
8156 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8158 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8159 pointers to constants.
8160 (font_parse_fcname): Remove unused vars.
8161 (font_delete_unmatched): Now static.
8162 (font_get_spec): Remove; unused.
8163 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8164 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8165 Rename or move locals to avoid shadowing.
8167 * fns.c (require_nesting_list, require_unwind): Now static.
8168 (Ffillarray): Rename locals to avoid shadowing.
8170 * floatfns.c (domain_error2): Define only if needed.
8171 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8173 * alloc.c (mark_backtrace): Move decl from here ...
8174 * lisp.h: ... to here, so that it can be checked.
8176 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8177 (Fdefvar): Rewrite so as not to use empty "else".
8178 (lisp_indirect_variable): Name an expression,
8179 to avoid gcc -Wbad-function-cast warning.
8180 (Fdefvar): Rename locals to avoid shadowing.
8182 * callint.c (quotify_arg, quotify_args): Now static.
8183 (Fcall_interactively): Rename locals to avoid shadowing.
8184 Use const pointer when appropriate.
8186 * lisp.h (get_system_name, get_operating_system_release):
8187 Move decls here, to check interfaces.
8188 * process.c (get_operating_system_release): Move decl to lisp.h.
8189 * xrdb.c (get_system_name): Likewise.
8190 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8191 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8192 some of which prompt warnings from gcc -Wbad-function-cast.
8193 (Fformat_time_string, Fencode_time, Finsert_char):
8194 (Ftranslate_region_internal, Fformat):
8195 Rename or remove local vars to avoid shadowing.
8196 (Ftranslate_region_internal): Mark var as initialized.
8198 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8201 * lisp.h (eassert): Check that the argument compiles, even if
8202 ENABLE_CHECKING is not defined.
8204 * data.c (Findirect_variable): Name an expression, to avoid
8205 gcc -Wbad-function-cast warning.
8206 (default_value, arithcompare, arith_driver, arith_error): Now static.
8207 (store_symval_forwarding): Rename local to avoid shadowing.
8208 (Fmake_variable_buffer_local, Fmake_local_variable):
8209 Mark variables as initialized.
8210 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8212 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8213 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8214 Rename locals to avoid shadowing.
8215 (mark_stack): Move local variables into the #ifdef region where
8217 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8218 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8220 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8221 (GC_STRING_CHARS): Remove; not used.
8222 (Fmemory_limit): Cast sbrk's returned value to char *.
8224 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8225 avoids undefined behavior in theory.
8227 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8229 Use functions, not macros, for up- and down-casing (Bug#8254).
8230 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8231 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8232 to use the following functions instead of these macros.
8233 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8234 EMACS_INT, since callers assume the returned value fits in int.
8235 (upcase1): Likewise, for UPCASE_TABLE.
8236 (uppercasep, lowercasep, upcase): New static inline functions.
8237 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8238 the race-condition problem in the old DOWNCASE.
8240 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8241 Rename locals to avoid shadowing.
8242 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8243 (regex_compile, re_search_2, re_match_2_internal):
8244 Remove unused local vars.
8245 (FREE_VAR): Rewrite so as not to use empty "else",
8246 which gcc can warn about.
8247 (regex_compile, re_match_2_internal): Mark locals as initialized.
8248 (RETALLOC_IF): Define only if needed.
8249 (WORDCHAR_P): Likewise. This one is never needed, but is used
8250 only in a comment talking about a compiler bug, so put inside
8251 the #if 0 of that comment.
8252 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8253 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8256 * search.c (boyer_moore): Rename locals to avoid shadowing.
8257 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8258 (PREV_CHAR_BOUNDARY): Likewise.
8260 * search.c (simple_search): Remove unused var.
8262 * dired.c (compile_pattern): Move decl from here ...
8263 * lisp.h: ... to here, so that it can be checked.
8264 (struct re_registers): New forward decl.
8266 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8268 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8270 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8271 Rename locals to avoid shadowing.
8272 (Fvertical_motion): Mark locals as initialized.
8274 * casefiddle.c (casify_object, casify_region): Now static.
8275 (casify_region): Mark local as initialized.
8277 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8279 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8280 New macros, so that the caller can use some names other than
8281 gcpro1, gcpro2, etc.
8282 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8284 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8285 argument, for consistency with GCPRO2_VAR, etc: it is now the
8286 prefix of the variable, not the variable itself. All uses
8288 * dired.c (directory_files_internal, file_name_completion):
8289 Rename locals to avoid shadowing.
8291 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8292 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8293 dired.c's scmp function, had undefined behavior.
8294 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8295 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8296 * buffer.h: ... to here, because these macros use current_buffer,
8297 and the new implementation with inline functions needs to have
8298 current_buffer in scope now, rather than later when the macros
8300 (downcase, upcase1): New static inline functions.
8301 (DOWNCASE, UPCASE1): Reimplement using these functions.
8302 This avoids undefined behavior in expressions like
8303 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8304 from race conditions in accessing the global variables
8305 case_temp1 and case_temp2.
8306 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8307 * lisp.h (case_temp1, case_temp2): Remove their decls.
8308 * character.h (ASCII_CHAR_P): Move from here ...
8309 * lisp.h: ... to here, so that the inline functions mentioned
8312 * dired.c (directory_files_internal_unwind): Now static.
8314 * fileio.c (file_name_as_directory, directory_file_name):
8315 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8317 (file_name_as_directory): Use const pointers when appropriate.
8318 (Fexpand_file_name): Likewise. In particular, newdir might
8319 point at constant storage, so make it a const pointer.
8320 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8321 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8323 (Fset_file_times, Finsert_file_contents, auto_save_error):
8324 Rename locals to avoid shadowing.
8326 * minibuf.c (choose_minibuf_frame_1): Now static.
8327 (Ftry_completion, Fall_completions): Rename or remove locals
8330 * marker.c (bytepos_to_charpos): Remove; unused.
8332 * lisp.h (verify_bytepos, count_markers): New decls,
8333 so that gcc does not warn that these functions aren't declared.
8335 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8336 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8337 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8338 (copy_text): Remove unused local var.
8340 * filelock.c (within_one_second): Now static.
8341 (lock_file_1): Rename local to avoid shadowing.
8343 * buffer.c (fix_overlays_before): Mark locals as initialized.
8344 (fix_start_end_in_overlays): Likewise. This function should be
8345 simplified by using pointers-to-pointers, but that's a different
8347 (switch_to_buffer_1): Now static.
8348 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8349 (report_overlay_modification): Rename locals to avoid shadowing.
8351 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8352 Fix pointer signedness issue.
8353 (sys_subshell): Mark local as volatile if checking for lint,
8354 to suppress a gcc -Wclobbered warning that does not seem to be right.
8355 (MAXPATHLEN): Define only if needed.
8357 * process.c (serial_open, serial_configure): Move decls from here ...
8358 * systty.h: ... to here, so that they can be checked.
8360 * fns.c (get_random, seed_random): Move extern decls from here ...
8361 * lisp.h: ... to here, so that they can be checked.
8363 * sysdep.c (reset_io): Now static.
8364 (wait_for_termination_signal): Remove; unused.
8366 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8367 (copy_keymap_item, append_key, push_text_char_description):
8369 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8370 (DENSE_TABLE_SIZE): Remove; unused.
8371 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8372 (describe_map_tree):
8373 Rename locals to avoid shadowing.
8375 * keyboard.c: Declare functions static if they are not used elsewhere.
8376 (echo_char, echo_dash, cmd_error, top_level_2):
8377 (poll_for_input, handle_async_input): Now static.
8378 (read_char, kbd_buffer_get_event, make_lispy_position):
8379 (make_lispy_event, make_lispy_movement, apply_modifiers):
8380 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8381 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8382 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8383 (read_key_sequence, read_char): Mark locals as initialized.
8384 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8386 * keyboard.h (make_ctrl_char): New decl.
8387 (mark_kboards): Move decl here ...
8388 * alloc.c (mark_kboards): ... from here.
8390 * lisp.h (force_auto_save_soon): New decl.
8392 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8393 (DEFINE_DUMMY_FUNCTION): New macro.
8394 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8396 (main): Add casts to avoid warnings
8397 if GCC considers string literals to be constants.
8399 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8401 * dbusbind.c: Pointer signedness fixes.
8402 (xd_signature, xd_append_arg, xd_initialize):
8403 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8404 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8405 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8406 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8408 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8409 if GCC considers string literals to be constants.
8410 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8412 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8414 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8415 (print_preprocess, print_object): New macro to fix last change.
8417 * print.c (print_preprocess): Don't forget font objects.
8419 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8421 * emacs.c (USAGE3): Doc fixes.
8423 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8425 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8428 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8430 * lisp.h (VWindow_system, Qfile_name_history):
8431 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8432 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8433 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8435 * w32select.c: Don't #include "keyboard.h".
8436 (run_protected): Add extern declaration for waiting_for_input.
8438 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8439 * w32console.c (detect_input_pending, read_input_pending)
8440 (encode_terminal_code):
8441 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8442 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8443 (w32_system_caret_y, Qfile_name_history):
8444 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8445 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8446 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8447 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8448 * w32proc.c (Qlocal, report_file_error):
8449 * w32term.c (Vwindow_system, updating_frame):
8450 * w32uniscribe.c (initialized, uniscribe_font_driver):
8451 Remove unneeded extern declarations.
8453 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8455 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8457 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8459 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8460 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8461 These macros can no longer be used for assignment.
8463 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8464 Assign struct members directly, instead of using BUF_BEGV etc.
8465 (record_buffer_markers, fetch_buffer_markers): New functions for
8466 recording and fetching special buffer markers.
8467 (set_buffer_internal_1, set_buffer_temp): Use them.
8469 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8471 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8473 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8474 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8476 * xdisp.c (hscroll_window_tree):
8477 (reconsider_clip_changes): Use PT instead of BUF_PT.
8479 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8481 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8482 $(EMACS_ROOT)/lib/intprops.h.
8484 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8486 Fix more problems found by GCC 4.5.2's static checks.
8488 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8489 to unsigned char * to avoid compiler diagnostic.
8490 (xg_free_frame_widgets): Make it clear that a local variable is
8491 needed only if USE_GTK_TOOLTIP.
8492 (gdk_window_get_screen): Make it clear that this macro is needed
8493 only if USE_GTK_TOOLTIP.
8494 (int_gtk_range_get_value): New function, which avoids a diagnostic
8495 from gcc -Wbad-function-cast.
8496 (xg_set_toolkit_scroll_bar_thumb): Use it.
8497 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8498 diagnostic from gcc -Wbad-function-cast.
8499 (get_utf8_string, xg_get_file_with_chooser):
8500 Rename locals to avoid shadowing.
8501 (create_dialog): Move locals to avoid shadowing.
8503 * xgselect.c (xg_select): Remove unused var.
8505 * image.c (four_corners_best): Mark locals as initialized.
8506 (gif_load): Initialize transparent_p to zero (Bug#8238).
8507 Mark another local as initialized.
8508 (my_png_error, my_error_exit): Mark with NO_RETURN.
8510 * image.c (clear_image_cache): Now static.
8511 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8512 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8513 (x_edge_detection): Remove unnecessary cast that
8514 gcc -Wbad-function-cast diagnoses.
8515 (gif_load): Fix pointer signedness.
8516 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8517 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8519 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8521 Improve quality of tests for time stamp overflow.
8522 For example, without this patch (encode-time 0 0 0 1 1
8523 1152921504606846976) returns the obviously-bogus value (-948597
8524 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8525 reports time overflow. See
8526 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8527 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8528 * editfns.c: Include limits.h and intprops.h.
8529 (TIME_T_MIN, TIME_T_MAX): New macros.
8530 (time_overflow): Move earlier, to before first use.
8531 (hi_time, lo_time): New functions, for an accurate test for
8533 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8534 (Fget_internal_run_time): Don't assume time_t fits in int.
8535 (make_time): Use list2 instead of Fcons twice.
8536 (Fdecode_time): More accurate test for out-of-range times.
8537 (check_tm_member): New function.
8538 (Fencode_time): Use it, to test for out-of-range times.
8539 (lisp_time_argument): Don't rely on undefined left-shift and
8540 right-shift behavior when checking for time stamp overflow.
8542 * editfns.c (time_overflow): New function, refactoring common code.
8543 (Fformat_time_string, Fdecode_time, Fencode_time):
8544 (Fcurrent_time_string): Use it.
8546 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8547 * dired.c (make_time): Move to ...
8548 * editfns.c (make_time): ... here.
8549 * systime.h: Note the move.
8551 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8553 * fringe.c (update_window_fringes): Remove unused variables.
8555 * unexmacosx.c (copy_data_segment): Also copy __got section.
8558 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8560 * termcap.c [MSDOS]: Include "msdos.h".
8561 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8562 Constify `char *' arguments and their references according to
8563 prototypes in tparam.h.
8565 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8567 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8568 Adapt all references accordingly.
8570 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8572 2011-03-11 Tom Tromey <tromey@redhat.com>
8574 * buffer.c (syms_of_buffer): Remove obsolete comment.
8576 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8578 * termhooks.h (encode_terminal_code): Declare prototype.
8580 * msdos.c (encode_terminal_code): Don't declare prototype.
8582 * term.c (encode_terminal_code): Now external again, used by
8583 w32console.c and msdos.c.
8585 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8586 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8588 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8590 Fix some minor problems found by GCC 4.5.2's static checks.
8592 * fringe.c (update_window_fringes): Mark locals as initialized
8594 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8596 * alloc.c (mark_fringe_data): Move decl from here ...
8597 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8598 to check its interface.
8599 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8601 * fontset.c (free_realized_fontset): Now static.
8602 (Fset_fontset_font): Rename local to avoid shadowing.
8603 (fontset_font): Mark local as initialized.
8604 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8606 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8608 * xselect.c (x_disown_buffer_selections): Remove; not used.
8609 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8610 (x_own_selection, Fx_disown_selection_internal): Rename locals
8612 (x_handle_dnd_message): Remove local to avoid shadowing.
8614 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8615 so that the caller can use some name other than gcpro1.
8616 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8617 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8618 (Fx_backspace_delete_keys_p):
8619 Use them to avoid shadowing, and rename vars to avoid shadowing.
8620 (x_decode_color, x_set_name, x_window): Now static.
8621 (Fx_create_frame): Add braces to silence GCC warning.
8622 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8623 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8624 Remove unused locals.
8625 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8626 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8627 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8630 * xterm.h (x_mouse_leave): New decl.
8632 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8633 Remove unused functions.
8634 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8635 (x_calc_absolute_position): Now static.
8636 (XTread_socket): Don't define label "out" unless it's used.
8637 Don't declare local "event" unless it's used.
8638 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8639 unless they are used.
8640 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8641 (x_fatal_error_signal): Remove; not used.
8642 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8643 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8644 (x_error_catcher, x_connection_closed, x_error_handler):
8645 (x_error_quitter, xembed_send_message, x_iconify_frame):
8646 (my_log_handler): Rename locals to avoid shadowing.
8647 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8648 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8650 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8651 Rename or move locals to avoid shadowing.
8652 (tty_defined_color, merge_face_heights): Now static.
8653 (free_realized_faces_for_fontset): Remove; not used.
8654 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8655 does not deduce is never used uninitialized.
8656 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8657 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8659 * terminal.c (store_terminal_param): Now static.
8661 * xmenu.c (menu_highlight_callback): Now static.
8662 (set_frame_menubar): Remove unused local.
8663 (xmenu_show): Rename parameter to avoid shadowing.
8664 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8665 since they might point to immutable storage.
8666 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8667 since it's unused otherwise.
8669 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8670 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8671 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8672 avoids a gcc -Wuninitialized diagnostic.
8673 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8674 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8675 does not deduce are never used uninitialized.
8677 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8679 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8680 * window.c (window_loop, size_window):
8681 (run_window_configuration_change_hook, enlarge_window): Likewise.
8683 * window.c (display_buffer): Now static.
8684 (size_window): Mark variables that gcc -Wuninitialized
8685 does not deduce are never used uninitialized.
8686 * window.h (check_all_windows): New decl, to forestall
8687 gcc -Wmissing-prototypes diagnostic.
8688 * dispextern.h (bidi_dump_cached_states): Likewise.
8690 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8692 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8694 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8695 and to avoid gcc -Wuninitialized warning.
8696 (load_charset_map): Mark variables that gcc -Wuninitialized
8697 does not deduce are never used uninitialized.
8698 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8700 * coding.c (coding_set_source, coding_set_destination):
8701 Use "else { /* comment */ }" rather than "else /* comment */;"
8702 for clarity, and to avoid gcc -Wempty-body warning.
8703 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8704 a block, when the outer 'i' will do.
8705 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8706 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8707 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8708 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8709 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8710 Rename locals to avoid shadowing.
8711 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8712 * coding.c (emacs_mule_char, encode_invocation_designation):
8713 Now static, since they're not used elsewhere.
8714 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8715 (decode_coding_object, encode_coding_object, detect_coding_system):
8716 (decode_coding_emacs_mule): Mark variables that gcc
8717 -Wuninitialized does not deduce are never used uninitialized.
8718 (detect_coding_iso_2022): Initialize a local variable that might
8719 be used uninitialized. Leave a FIXME because it's not clear that
8720 this initialization is needed. (Bug#8211)
8721 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8722 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8723 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8724 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8725 Remove unused macros.
8727 * category.c (hash_get_category_set): Remove unused local var.
8728 (copy_category_table): Now static, since it's not used elsewhere.
8729 * character.c (string_count_byte8): Likewise.
8731 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8732 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8734 * chartab.c (copy_sub_char_table): Now static, since it's not used
8736 (sub_char_table_ref_and_range, char_table_ref_and_range):
8737 Rename locals to avoid shadowing.
8738 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8740 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8741 (BIDI_BOB): Remove unused macro.
8743 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8744 deduce are never used uninitialized.
8745 * term.c (encode_terminal_code): Likewise.
8747 * term.c (encode_terminal_code): Now static. Remove unused local.
8749 * tparam.h: New file.
8750 * term.c, tparam.h: Include it.
8751 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8752 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8753 Move these decls to tparam.h, and make them agree with what
8754 is actually in tparam.c. The previous trick of using incompatible
8755 decls in different modules does not conform to the C standard.
8756 All callers of tparam changed to use tparam's actual API.
8757 * tparam.c (tparam1, tparam, tgoto):
8758 Use const pointers where appropriate.
8760 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8761 * cm.h (struct cm): Likewise.
8762 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8763 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8764 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8765 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8766 (turn_on_face, init_tty): Likewise.
8767 * termchar.h (struct tty_display_info): Likewise.
8769 * term.c (term_mouse_position): Rename local to avoid shadowing.
8771 * alloc.c (mark_ttys): Move decl from here ...
8772 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8774 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8776 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8778 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8780 * search.c (compile_pattern_1): Remove argument regp, unused since
8781 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8782 (compile_pattern): Don't pass it.
8784 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8786 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8787 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8789 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8791 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8793 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8794 gdk_window_get_screen, gdk_window_get_geometry,
8795 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8796 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8797 (xg_get_pixbuf_from_pixmap): New function.
8798 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8799 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8800 Call xg_get_pixbuf_from_pixmap instead of
8801 gdk_pixbuf_get_from_drawable.
8802 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8803 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8804 (xg_check_special_colors): Use GtkStyleContext and its functions
8806 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8807 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8808 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8809 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8810 Call gtk_widget_get_preferred_size.
8811 (xg_frame_resized): gdk_window_get_geometry only takes 5
8813 (xg_win_to_widget, xg_event_is_for_menubar):
8814 Call gdk_x11_window_lookup_for_display.
8815 (xg_set_widget_bg): New function.
8816 (delete_cb): New function.
8817 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8818 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8819 (xg_set_background_color): Call xg_set_widget_bg.
8820 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8821 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8822 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8823 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8825 (update_frame_tool_bar): Call gtk_widget_hide.
8826 (xg_initialize): Use GDK_KEY_g.
8828 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8830 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8832 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8833 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8834 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8836 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8838 * w32xfns.c (select_palette): Check success of RealizePalette against
8839 GDI_ERROR, not zero.
8841 See ChangeLog.11 for earlier changes.
8847 Copyright (C) 2011 Free Software Foundation, Inc.
8849 This file is part of GNU Emacs.
8851 GNU Emacs is free software: you can redistribute it and/or modify
8852 it under the terms of the GNU General Public License as published by
8853 the Free Software Foundation, either version 3 of the License, or
8854 (at your option) any later version.
8856 GNU Emacs is distributed in the hope that it will be useful,
8857 but WITHOUT ANY WARRANTY; without even the implied warranty of
8858 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8859 GNU General Public License for more details.
8861 You should have received a copy of the GNU General Public License
8862 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.