1 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8 2012-05-18 Eli Zaretskii <eliz@gnu.org>
10 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
12 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
13 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
15 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
16 reference to image_cache->refcount.
17 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
19 2012-05-17 Juri Linkov <juri@jurta.org>
21 * search.c (Fword_search_regexp, Fword_search_backward)
22 (Fword_search_forward, Fword_search_backward_lax)
23 (Fword_search_forward_lax): Move functions to isearch.el
24 (bug#10145, bug#11381).
26 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
28 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
30 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
32 * lread.c (init_obarray): Declare Qt and Qnil as special.
34 2012-05-14 Glenn Morris <rgm@gnu.org>
36 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
37 Put "libexec" before "bin", for the sake of init_callproc_1.
39 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
41 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
43 * unexaix.c: Port to more-recent AIX compilers.
44 (report_error, report_error_1, make_hdr, copy_sym)
45 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
46 Make arguments const char *, not char *, to avoid violations of C
47 standard and to fix some AIX warnings reported by Gilles Pion.
49 2012-05-14 Eli Zaretskii <eliz@gnu.org>
51 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
52 already have overlays loaded.
53 (handle_single_display_spec): Before returning without displaying
54 fringe bitmap, synchronize the bidi iterator with the main display
55 iterator, by calling iterate_out_of_display_property.
56 (iterate_out_of_display_property): Detect buffer iteration by
57 testing that it->string is a Lisp string.
58 (get_next_display_element): When the current object is exhausted,
59 and there's something on it->stack, call set_iterator_to_next to
60 proceed with what's on the stack, instead of returning zero.
61 (set_iterator_to_next): If called at the end of a Lisp string,
62 proceed to consider_string_end without incrementing string
63 position. Don't increment display vector index past the end of
64 the display vector. (Bug#11417)
65 (pos_visible_p): Don't report a position visible when move_it_to
66 stopped at the last line of window, which happens to be scanned
67 backwards by the bidi iteration. (Bug#11464)
69 2012-05-14 Eli Zaretskii <eliz@gnu.org>
71 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
72 and right-margin display specs even if the spec is invalid or we
73 are on a TTY, and thus unable to display on the fringes. That's
74 because the text with the property will not be displayed anyway,
75 so we need to signal to the caller that this is a "replacing"
76 display spec. This fixes display when the spec is invalid or we
79 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
81 * unexaix.c (make_hdr): Fix typo in prototype.
82 This bug broke the build on AIX. Problem reported by Gilles Pion.
84 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
86 * keyboard.c (kbd_buffer_get_event): Read special events also in
87 batch mode. (Bug#11415)
89 2012-05-12 Glenn Morris <rgm@gnu.org>
91 * ns.mk: Update for ns_appbindir no longer having trailing "/".
93 2012-05-12 Eli Zaretskii <eliz@gnu.org>
95 * lisp.mk (lisp): Add newcomment.elc.
97 2012-05-12 Glenn Morris <rgm@gnu.org>
99 * Makefile.in (MKDIR_P): New, set by configure.
100 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
102 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
104 Remove unused function hourglass_started.
105 * dispextern.h (hourglass_started):
106 * w32fns.c (hourglass_started):
107 * xdisp.c (hourglass_started): Remove.
109 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
111 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
114 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
116 * xgselect.c (xg_select): Put maxfds+1 into a var.
117 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
119 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
121 2012-05-10 Dave Abrahams <dave@boostpro.com>
123 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
124 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
126 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
128 * dbusbind.c (xd_registered_buses): New internal Lisp object.
129 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
130 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
131 Initialize xd_registered_buses.
133 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
135 Untag more efficiently if USE_LSB_TAG.
136 This is based on a proposal by YAMAMOTO Mitsuharu in
137 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
138 For an admittedly artificial (nth 8000 longlist) benchmark on
139 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
140 Emacs's overall text size by 1%.
141 * lisp.h (XUNTAG): New macro.
142 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
143 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
144 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
145 * eval.c (Fautoload):
146 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
147 * frame.h (XFRAME): Use XUNTAG.
149 Port recent dbusbind.c changes to 32-bit --with-wide-int.
150 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
151 Remove unportable assumptions about print widths of types like
153 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
154 intptr_t when converting between pointer and integer, to avoid GCC
155 warnings about wrong width.
157 2012-05-09 Eli Zaretskii <eliz@gnu.org>
159 * w32proc.c (new_child): Force Windows to reserve only 64KB of
160 stack for each reader_thread, instead of defaulting to 8MB
161 determined by the linker. This avoids failures in creating
162 subprocesses on Windows 7, see the discussion in this thread:
163 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
165 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
167 Fix up display of the *Minibuf-0* buffer in the mini window.
168 * keyboard.c (read_char): Don't clear the echo area if there's no
170 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
171 contents of *Minibuf-0*) if there's no message displayed in its stead.
173 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
175 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
178 2012-05-06 Chong Yidong <cyd@gnu.org>
180 * lisp.mk (lisp): Update.
182 2012-05-05 Jim Meyering <meyering@redhat.com>
184 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
186 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
188 * data.c (PUT_ERROR): New macro.
189 (syms_of_data): Use it. Add new error type `user-error'.
190 * undo.c (user_error): New function.
191 (Fprimitive_undo): Use it.
192 * print.c (print_error_message): Adjust print style for `user-error'.
193 * keyboard.c (user_error): New function.
194 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
196 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
198 Do not limit current-time-string to years 1000..9999.
199 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
200 (Fcurrent_time_string): Support any year that is supported by the
201 underlying localtime representation. Don't use asctime, as it
202 has undefined behavior for years outside the range -999..9999.
204 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
206 Fix race conditions involving setenv, gmtime, localtime, asctime.
207 Without this fix, interrupts could mess up code that uses these
208 nonreentrant functions, since setting TZ invalidates existing
209 tm_zone or tzname values, and since most of these functions return
210 pointers to static storage.
211 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
212 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
213 Grow the critical sections to include not just invoking
214 localtime/gmtime, but also accessing these functions' results
215 including their tm_zone values if any, and any related TZ setting.
216 (format_time_string): Last arg is now struct tm *, not struct tm **,
217 so that the struct tm is saved in the critical section.
218 All callers changed. Simplify allocation of initial buffer, partly
219 motivated by the fact that memory allocation needs to be outside
220 the critical section.
222 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
224 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
227 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
228 Remove duplicated buffer name initialization.
230 2012-05-02 Jim Meyering <jim@meyering.net>
232 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
234 * xfns.c (x_window): Use xstrdup (Bug#11375).
236 2012-05-02 Eli Zaretskii <eliz@gnu.org>
238 * xdisp.c (pos_visible_p): If already at a newline from the
239 display string before the 'while' loop, don't walk back the glyphs
240 from it3.glyph_row. Solves assertion violation when the display
241 string begins with a newline (egg.el). (Bug#11367)
243 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
245 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
248 2012-05-01 Glenn Morris <rgm@gnu.org>
250 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
251 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
252 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
253 All were removed before 23.1.
255 * dispnew.c: Remove HAVE_LIBNCURSES test;
256 it is always true on relevant platforms.
258 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
259 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
261 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
263 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
265 * .gdbinit (xpr): Remove checks for no longer existing misc types.
266 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
269 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
271 Do not avoid creating empty evaporating overlays (Bug#9642).
272 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
273 That is, do not delete an evaporating overlay if it becomes
274 empty after its bounds are adjusted to fit within its buffer.
275 This fix caused other problems, and I'm reverting it until we get
276 to the bottom of them.
278 2012-04-27 Chong Yidong <cyd@gnu.org>
280 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
282 2012-04-27 Eli Zaretskii <eliz@gnu.org>
284 * xdisp.c (pos_visible_p): If the window start position is beyond
285 ZV, start the display from buffer beginning. Prevents assertion
286 violation in init_iterator when the minibuffer window is scrolled
289 * window.c (window_scroll_pixel_based): Likewise.
291 2012-04-27 Chong Yidong <cyd@gnu.org>
293 * keymap.c (where_is_internal): Doc fix (Bug#10872).
295 2012-04-27 Glenn Morris <rgm@gnu.org>
297 * fileio.c (Fcopy_file, Fset_file_selinux_context):
298 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
300 2012-04-27 Eli Zaretskii <eliz@gnu.org>
302 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
303 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
305 2012-04-26 Eli Zaretskii <eliz@gnu.org>
307 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
308 display element, check also the underlying string or buffer
309 character. (Bug#11341)
311 * w32menu.c: Include w32heap.h.
312 (add_menu_item): If the call to AppendMenuW (via
313 unicode_append_menu) fails, disable Unicode menus only if we are
314 running on Windows 9X/Me.
316 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
318 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
319 (xgetint): Add missing shift for LSB tags.
321 2012-04-24 Martin Rudalics <rudalics@gmx.at>
323 * keyboard.c (read_char): Don't wipe echo area for select window
324 events: These might get delayed via `mouse-autoselect-window'
327 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
329 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
330 manipulation of :loaded-from data.
332 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
334 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
335 now a cons (bug#11311).
337 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
339 Do not create empty overlays with the evaporate property (Bug#9642).
340 * buffer.c (Fmove_overlay): Delete an evaporating overlay
341 if it becomes empty after its bounds are adjusted to fit within
342 its buffer. Without this fix, in a nonempty buffer (let ((o
343 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
344 yields an empty overlay that has the evaporate property, which is
345 not supposed to happen.
347 Fix minor GTK3 problems found by static checking.
348 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
349 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
350 (struct _EmacsFixedClass, emacs_fixed_get_type):
351 Move decls here from emacsgtkfixed.h, since they needn't be public.
352 (emacs_fixed_get_type): Now static.
353 (emacs_fixed_class_init): Omit unused local.
354 (emacs_fixed_child_type): Remove; unused.
355 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
356 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
357 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
358 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
359 (EMACS_FIXED_GET_CLASS): Remove; unused.
360 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
362 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
363 Problem reported by Juanma Barranquero for Windows -Wunused-function.
365 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
367 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
368 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
369 (__malloc_size_t, __malloc_ptrdiff_t):
370 Remove. All uses removed, replaced by the definiens if needed,
371 since we can assume C89 or better now.
372 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
373 (protect_malloc_state, align, get_contiguous_space)
374 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
375 (malloc_atfork_handler_child, malloc_enable_thread)
376 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
377 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
378 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
379 (special_realloc, _realloc_internal_nolock, _realloc_internal)
380 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
381 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
382 Define using prototypes, not old style.
383 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
384 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
385 (align): Don't assume that signed integer overflow wraps around.
386 Omit unused local var.
387 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
388 (_free_internal_nolock, memalign, mallochook, reallochook):
389 Omit no-longer-needed casts.
390 (valloc): Use getpagesize, not __getpagesize.
391 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
392 (struct hdr): The 'magic' member is now size_t, not unsigned long.
394 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
396 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
398 Move functions from C to Lisp. Make non-blocking method calls
399 the default. Implement further D-Bus standard interfaces.
401 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
402 (QCdbus_request_name_allow_replacement)
403 (QCdbus_request_name_replace_existing)
404 (QCdbus_request_name_do_not_queue)
405 (QCdbus_request_name_reply_primary_owner)
406 (QCdbus_request_name_reply_in_queue)
407 (QCdbus_request_name_reply_exists)
408 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
409 (QCdbus_registered_serial, QCdbus_registered_method)
410 (QCdbus_registered_signal): New Lisp objects.
411 (XD_DEBUG_MESSAGE): Use sizeof.
412 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
413 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
414 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
415 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
416 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
417 (xd_signature, xd_append_arg): Allow float for integer types.
418 (xd_get_connection_references): New function.
419 (xd_get_connection_address): Rename from xd_initialize.
420 Return cached address.
421 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
422 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
424 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
425 Return number of refcounts.
426 (Fdbus_get_unique_name): Make stronger parameter check.
427 (Fdbus_message_internal): New defun.
428 (Fdbus_call_method, Fdbus_call_method_asynchronously)
429 (Fdbus_method_return_internal, Fdbus_method_error_internal)
430 (Fdbus_send_signal, Fdbus_register_service)
431 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
432 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
433 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
434 (Vdbus_compiled_version, Vdbus_runtime_version)
435 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
436 (Vdbus_message_type_method_return, Vdbus_message_type_error)
437 (Vdbus_message_type_signal): New defvars.
438 (Vdbus_registered_buses, Vdbus_registered_objects_table):
441 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
443 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
444 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
445 Do not assume ptrdiff_t is the same width as 'int'.
447 * alloc.c: Handle unusual debugging option combinations.
448 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
449 since the two debugging options are incompatible.
450 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
452 (mem_init, mem_insert, mem_insert_fixup):
453 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
454 (NEED_MEM_INSERT): Remove; no longer needed.
456 2012-04-22 Leo Liu <sdl.web@gmail.com>
458 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
460 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
462 * sysdep.c [__FreeBSD__]: Minor cleanups.
463 (list_system_processes, system_process_attributes) [__FreeBSD__]:
464 Use Emacs indenting style more consistently. Avoid some casts.
465 Use 'double' consistently rather than mixing 'float' and 'double'.
467 2012-04-21 Eduard Wiebe <usenet@pusto.de>
469 * sysdep.c (list_system_processes, system_process_attributes):
470 Add implementation for FreeBSD (Bug#5243).
472 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
474 * lisp.mk (lisp): Update.
476 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
478 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
479 It is never used otherwise.
481 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
483 * print.c (print_preprocess): Only check print_depth if print-circle
485 (print_object): Check for cycles even when print-circle is nil and
486 print-gensym is t, but only check print_depth if print-circle is nil.
488 2012-04-20 Chong Yidong <cyd@gnu.org>
490 * process.c (wait_reading_process_output): If EIO occurs on a pty,
491 set the status to "failed" and ensure that sentinel is run.
493 2012-04-20 Glenn Morris <rgm@gnu.org>
495 * process.c (Fset_process_inherit_coding_system_flag)
496 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
497 (Fmake_network_process, Fmake_serial_process): Doc fix.
499 2012-04-20 Eli Zaretskii <eliz@gnu.org>
501 * xdisp.c (string_buffer_position_lim): Limit starting position to
503 (set_cursor_from_row): If called for a mode-line or header-line
504 row, return zero immediately.
505 (try_cursor_movement): If inside continuation line, don't back up
506 farther than the first row after the header line, if any.
507 Don't consider the header-line row as "partially visible", even if
508 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
510 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
512 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
515 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
516 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
518 configure: new option --enable-gcc-warnings (Bug#11207)
519 * Makefile.in (C_WARNINGS_SWITCH): Remove.
520 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
521 (ALL_CFLAGS): Use new macros rather than old.
522 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
523 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
524 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
525 -Wunused-result, -Wunused-variable. This should go away once
526 the Emacs and Gnulib regex code is merged.
527 (xmalloc, xrealloc): Now static.
529 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
531 * dired.c (Fsystem_groups): Remove unused local.
533 2012-04-17 Glenn Morris <rgm@gnu.org>
535 * dired.c (Fsystem_users): Doc fix.
537 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
539 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
540 (syms_of_dired): Add them.
542 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
544 Fix minor alloc.c problems found by static checking.
545 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
546 New extern decls, to avoid calling undeclared functions.
547 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
548 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
549 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
550 (NEED_MEM_INSERT): New macro.
551 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
552 Remove one incorrect comment and fix another.
554 Fix minor ralloc.c problems found by static checking.
555 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
556 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
557 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
558 (r_alloc_sbrk): Now static.
560 Improve ralloc.c interface checking.
561 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
562 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
563 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
564 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
565 [REL_ALLOC]: ... to here, to check interface.
566 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
567 Remove decls. This fixes an "It stinks!".
569 * alloc.c (which_symbols): Fix alignment issue / type clash.
571 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
573 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
574 (struct Lisp_Misc_Any): Likewise.
575 (struct Lisp_Free): Likewise.
576 * alloc.c (union aligned_Lisp_Symbol): Define.
577 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
578 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
579 (union aligned_Lisp_Misc): Define.
580 (MARKER_BLOCK_SIZE, struct marker_block): Use union
581 aligned_Lisp_Misc instead of union Lisp_Misc.
582 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
584 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
586 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
587 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
588 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
589 * s/netbsd.h, s/sol2-6.h:
590 Remove definition of GC_MARK_STACK, since the default now works.
591 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
592 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
593 no longer the default.
594 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
596 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
598 * lread.c (lisp_file_lexically_bound_p):
599 Fix hang at ";-*-\n" (bug#11238).
601 2012-04-14 Eli Zaretskii <eliz@gnu.org>
603 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
604 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
606 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
608 * nsterm.m (constrainFrameRect): Always constrain when there is only
609 one screen (Bug#10962).
611 2012-04-13 Ken Brown <kbrown@cornell.edu>
613 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
615 2012-04-13 Reuben Thomas <rrt@sc3d.org>
617 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
619 2012-04-11 Daniel Colascione <dancol@dancol.org>
621 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
622 against is gone. It's better to use vfork now so that when Cygwin
623 gains a new, working vfork, we use it automatically (bug#10398).
625 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
627 * window.c (save_window_save): Obey window-point-insertion-type.
629 2012-04-11 Glenn Morris <rgm@gnu.org>
631 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
633 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
635 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
637 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
639 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
640 (force_quit_count): New var.
641 (handle_interrupt): Use it.
643 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
645 * w32.c (w32_delayed_load): Record the full path of the library
646 being loaded (bug#10424).
648 2012-04-09 Glenn Morris <rgm@gnu.org>
650 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
651 not just in the obarray, before snarfing them. (Bug#11036)
653 * Makefile.in ($(leimdir)/leim-list.el):
654 Pass EMACS rather than BUILT_EMACS.
656 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
658 * process.c (make_process):
659 * process.h: Add integer `gnutls_handshakes_tried' member to
662 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
663 Add convenience `GNUTLS_LOG2i' macro.
665 * gnutls.c (gnutls_log_function2i): Convenience log function.
666 (emacs_gnutls_read): Use new log functions,
667 `gnutls_handshakes_tried' process member, and
668 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
669 attempts per process (connection).
671 2012-04-09 Chong Yidong <cyd@gnu.org>
673 * eval.c (Fuser_variable_p, user_variable_p_eh)
674 (lisp_indirect_variable): Functions deleted.
675 (Fdefvar): Caller changed.
677 * callint.c (Finteractive, Fcall_interactively):
678 * minibuf.c (Fread_variable): Callers changed.
680 2012-04-09 Eli Zaretskii <eliz@gnu.org>
682 * xdisp.c (set_cursor_from_row): If the display string appears in
683 the buffer at position that is closer to point than the position
684 after the display string, display the cursor on the first glyph of
685 the display string. Fixes cursor display when a 'display' text
686 property immediately follows invisible text. (Bug#11094)
688 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
690 composite.c: use 'double' consistently
691 * composite.c (get_composition_id): Use 'double' consistently
692 instead of converting 'float' to 'double' and vice versa; this is
693 easier to understand and avoids a GCC warning.
695 2012-04-09 Glenn Morris <rgm@gnu.org>
697 * Makefile.in: Generate leim-list with bootstrap-emacs, in
698 preparation for dumping it with emacs. (Bug#4789)
699 (leimdir): New variable.
700 ($(leimdir)/leim-list.el): New rule.
701 (emacs$(EXEEXT)): Depend on leim-list.el.
703 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
704 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
705 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
707 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
709 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
712 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
714 * xml.c (init_libxml2_functions) [WINDOWSNT]:
715 Remove unused local variable.
717 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
719 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
720 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
721 (mark_memory): Mark Lisp_Objects only if pointers might hide in
722 objects, as mark_maybe_pointer will catch them otherwise.
723 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
724 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
726 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
728 Fix typo that broke non-Windows builds.
729 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
731 2012-04-07 Eli Zaretskii <eliz@gnu.org>
733 Support building on MS-Windows with libxml2.
735 * makefile.w32-in (OBJ2): Add xml.$(O).
736 (GLOBAL_SOURCES): Add xml.c.
737 ($(BLD)/xml.$(O)): New dependency list.
739 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
740 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
741 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
742 [!WINDOWSNT]: New macros.
743 (init_libxml2_functions, libxml2_loaded_p): New functions.
744 (parse_region): Call fn_xmlCheckVersion instead of using the macro
745 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
746 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
747 Calls xmlCleanupParser only if libxml2 was loaded (or statically
749 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
750 Call init_libxml2_functions before calling libxml2 functions.
751 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
753 * emacs.c: Don't include libxml/parser.h.
754 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
755 xmlCleanupParser directly.
757 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
759 2012-04-07 Eli Zaretskii <eliz@gnu.org>
761 * indent.c (Fvertical_motion): If there is a display string at
762 point, use it.vpos to compute how many lines to backtrack after
763 move_it_to point. (Bug#11133)
765 2012-04-06 Eli Zaretskii <eliz@gnu.org>
767 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
768 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
769 about subtle differences between FETCH_CHAR* and STRING_CHAR*
770 macros related to unification of CJK characters. For the details,
771 see the discussion following the message here:
772 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
774 2012-04-04 Chong Yidong <cyd@gnu.org>
776 * keyboard.c (Vdelayed_warnings_list): Doc fix.
778 2012-04-01 Eli Zaretskii <eliz@gnu.org>
780 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
781 instead of alloca. (Bug#11138)
783 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
785 * w32menu.c (is_simple_dialog): Properly check lisp types.
788 2012-03-31 Eli Zaretskii <eliz@gnu.org>
790 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
791 position we get to after a call to move_it_to fails the
792 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
793 only if we wind up in a string from display property. (Bug#11063)
795 * window.c (Fdelete_other_windows_internal): Invalidate the row
796 and column information about mouse highlight, so that redisplay
797 restores it after reallocating the glyph matrices. (Bug#7464)
799 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
800 string comes from a `display' text property, use the buffer
801 position of that property as if we actually saw that position in
803 (move_it_by_lines): Remove the assertion that
804 "it->current_x == 0 && it->hpos == 0" which can be legitimately
805 violated when there's a before-string at the beginning of a line.
808 2012-03-30 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (append_space_for_newline): If the default face was
811 remapped, use the remapped face for the appended newline.
812 (extend_face_to_end_of_line): Use the remapped default face for
813 extending the face to the end of the line.
814 (display_line): Call extend_face_to_end_of_line when the default
815 face was remapped. (Bug#11068)
817 2012-03-29 Eli Zaretskii <eliz@gnu.org>
819 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
821 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
823 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
825 2012-03-27 Glenn Morris <rgm@gnu.org>
827 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
830 2012-03-26 Kenichi Handa <handa@m17n.org>
832 * dispextern.h (struct glyph): Fix previous change. Change the
833 bit length of glyphless.ch to 25 (Bug#11082).
835 2012-03-26 Chong Yidong <cyd@gnu.org>
837 * keyboard.c (Vselection_inhibit_update_commands): New variable.
838 (command_loop_1): Use it; inhibit selection update for
839 handle-select-window too (Bug#8996).
841 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
843 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
845 2012-03-25 Kenichi Handa <handa@m17n.org>
847 * dispextern.h (struct glyph): Change the bit length of
848 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
850 2012-03-24 Eli Zaretskii <eliz@gnu.org>
852 * s/ms-w32.h (tzname): Include time.h before redirecting to
853 _tzname. Fixes the MSVC build. (Bug#9960)
855 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
857 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
860 * xterm.c (XTread_socket): Only modify handling_signal if
861 !SYNC_INPUT. (Bug#11080)
863 2012-03-23 Eli Zaretskii <eliz@gnu.org>
865 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
866 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
867 when fetching a multibyte character consumes more bytes than
868 CHAR_BYTES returns, due to unification of CJK characters in
869 string_char. (Bug#11073)
871 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
873 * process.c (wait_reading_process_output): Handle pty disconnect
874 by refraining from sending oneself a SIGCHLD (bug#10933).
876 2012-03-22 Chong Yidong <cyd@gnu.org>
878 * dispextern.h (struct it): New member string_from_prefix_prop_p.
880 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
881 Mark string as coming from a prefix property.
882 (handle_face_prop): Use default face for prefix strings (Bug#4281).
883 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
885 2012-03-21 Chong Yidong <cyd@gnu.org>
887 * xfaces.c (Vface_remapping_alist): Doc fix.
889 2012-03-20 Eli Zaretskii <eliz@gnu.org>
891 * w32proc.c (Fw32_set_console_codepage)
892 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
895 2012-03-20 Chong Yidong <cyd@gnu.org>
897 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
898 to reflect default non-nil value of redisplay-dont-pause.
900 2012-03-19 Kenichi Handa <handa@m17n.org>
902 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
903 it fit in a valid range (Bug#11003).
905 2012-03-18 Eli Zaretskii <eliz@gnu.org>
907 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
908 that is not from display property, accept the row as a "cursor
909 row" if one of the string's character has a non-nil `cursor'
910 property. Fixes cursor positioning when there are newlines in
911 overlay strings, e.g. in icomplete.el. (Bug#11035)
913 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
915 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
917 2012-03-12 Chong Yidong <cyd@gnu.org>
919 * eval.c (inhibit_lisp_code): Rename from
920 inhibit_window_configuration_change_hook; move from window.c.
922 * xfns.c (unwind_create_frame_1, Fx_create_frame):
923 * window.c (run_window_configuration_change_hook)
924 (syms_of_window): Callers changed.
926 2012-03-11 Chong Yidong <cyd@gnu.org>
928 * keymap.c (Fkey_description): Doc fix (Bug#9700).
930 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
932 2012-03-10 Chong Yidong <cyd@gnu.org>
934 * frame.c (other_visible_frames): Don't assume the selected frame
935 is visible (Bug#10955).
937 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
939 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
941 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
943 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
944 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
947 2012-03-03 Glenn Morris <rgm@gnu.org>
949 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
951 2012-03-02 Eli Zaretskii <eliz@gnu.org>
953 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
954 position past the first glyph_row that ends at ZV. (Bug#10902)
955 (redisplay_window, next_element_from_string): Fix typos in
957 (redisplay_window): Pass to move_it_vertically the margin in
958 pixels, not in screen lines.
960 2012-03-02 Glenn Morris <rgm@gnu.org>
962 * buffer.c (buffer-list-update-hook): Doc fix.
964 2012-02-29 Eli Zaretskii <eliz@gnu.org>
966 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
967 push_it before setting up the iterator for the first overlay
968 string, even if we have an empty string loaded.
969 (next_overlay_string): If there's an empty string on the iterator
970 stack, pop the stack. (Bug#10903)
972 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
974 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
975 Suggested by Stefan Monnier in
976 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
977 * alloc.c (widen_to_Lisp_Object): New static function.
978 (mark_memory): Also mark Lisp_Objects by fetching pointer words
979 and widening them to Lisp_Objects. This would work even if
980 USE_LSB_TAG is defined and wide integers are used, which might
981 happen in a future version of Emacs.
983 2012-02-25 Chong Yidong <cyd@gnu.org>
985 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
988 * xselect.c (Fx_selection_exists_p): Doc fix.
989 (x_clipboard_manager_save_all): Print an informative message
990 before saving to clipboard manager.
992 2012-02-24 Chong Yidong <cyd@gnu.org>
994 * keyboard.c (process_special_events): Handle all X selection
995 requests in kbd_buffer, not just the next one (Bug#8869).
997 2012-02-23 Chong Yidong <cyd@gnu.org>
999 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1000 call when setting menu-bar-lines and tool-bar-lines parameters.
1001 (unwind_create_frame_1): New helper function.
1003 * window.c (inhibit_window_configuration_change_hook): New var.
1004 (run_window_configuration_change_hook): Obey it.
1005 (syms_of_window): Initialize it.
1007 2012-02-22 Chong Yidong <cyd@gnu.org>
1009 * xterm.c (x_draw_image_relief): Add missing type check for
1010 Vtool_bar_button_margin (Bug#10743).
1012 2012-02-21 Chong Yidong <cyd@gnu.org>
1014 * fileio.c (Vfile_name_handler_alist): Doc fix.
1016 * buffer.c (Fget_file_buffer): Protect against invalid file
1017 handler return value.
1019 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1021 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1022 when computing $valmask.
1024 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1025 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1026 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1027 It's useless in that case, and it can cause problems on hosts
1028 that allocate halves of EMACS_INT values separately.
1029 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1030 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1031 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1032 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1033 it avoids undefined behavior on hosts where shifting right by more
1034 than the word width has undefined behavior.
1036 2012-02-19 Chong Yidong <cyd@gnu.org>
1038 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1039 (Funhandled_file_name_directory, Ffile_name_as_directory)
1040 (Fdirectory_file_name, Fexpand_file_name)
1041 (Fsubstitute_in_file_name): Protect against invalid file handler
1042 return values (Bug#10845).
1044 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1046 * .gdbinit (pitx): Fix incorrect references to fields of the
1049 2012-02-17 Chong Yidong <cyd@gnu.org>
1051 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1053 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1055 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1056 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1058 2012-02-15 Chong Yidong <cyd@gnu.org>
1060 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1061 marked as special. Also, starting docstrings with * is obsolete.
1063 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1065 * gnutls.c (emacs_gnutls_write): Fix last change.
1067 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1069 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1072 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1074 * keymap.c (Fsingle_key_description): Handle char ranges.
1076 2012-02-12 Chong Yidong <cyd@gnu.org>
1078 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1079 as that creates a dangerous corner case.
1081 * window.c (Fdelete_window_internal): Invalidate the mouse
1082 highlight (Bug#9904).
1084 2012-02-12 Glenn Morris <rgm@gnu.org>
1086 * xselect.c (Fx_own_selection_internal)
1087 (Fx_get_selection_internal, Fx_disown_selection_internal)
1088 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1089 * nsselect.m (Fx_own_selection_internal)
1090 (Fx_disown_selection_internal, Fx_selection_exists_p)
1091 (Fx_selection_owner_p, Fx_get_selection_internal):
1092 Sync docs and argument specs with the xselect.c versions.
1094 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1096 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1098 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1100 * w32select.c (Fx_selection_exists_p): Sync doc string and
1101 argument list with xselect.c. (Bug#10783)
1103 * w16select.c (Fx_selection_exists_p): Sync doc string and
1104 argument list with xselect.c. (Bug#10783)
1106 2012-02-10 Glenn Morris <rgm@gnu.org>
1108 * fns.c (Fsecure_hash): Doc fix.
1110 2012-02-09 Kenichi Handa <handa@m17n.org>
1112 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1114 2012-02-07 Chong Yidong <cyd@gnu.org>
1116 * buffer.c (Fbuffer_local_variables)
1117 (buffer_lisp_local_variables): Handle unbound vars correctly;
1118 don't let Qunbound leak into Lisp.
1120 2012-02-07 Glenn Morris <rgm@gnu.org>
1122 * image.c (Fimagemagick_types): Doc fix.
1124 * image.c (imagemagick-render-type): Change it from a lisp object
1125 to an integer. Move the doc here from the lisp manual.
1126 Treat all values not equal to 0 the same.
1128 2012-02-06 Chong Yidong <cyd@gnu.org>
1130 * doc.c (store_function_docstring): Avoid applying docstring of
1131 alias to base function (Bug#2603).
1133 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1135 * .gdbinit (pp1, pv1): Remove redundant defines.
1138 2012-02-04 Chong Yidong <cyd@gnu.org>
1140 * nsterm.m: Declare a global (Bug#10694).
1142 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1144 * w32.c (get_emacs_configuration_options):
1145 Include --enable-checking, if specified, in the return value.
1147 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1149 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1150 after rounding frame sizes. (Bug#9723)
1152 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1154 * keyboard.c (adjust_point_for_property): Don't position point
1155 before BEGV. (Bug#10696)
1157 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1159 Handle overflow when computing char display width (Bug#9496).
1160 * character.c (char_width): Return EMACS_INT, not int.
1161 (char_width, c_string_width): Check for overflow when
1162 computing the width; this is possible now that individual
1163 characters can have unbounded width. Problem introduced
1164 by merge from Emacs 23 on 2012-01-19.
1166 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1168 * dbusbind.c (Fdbus_register_method): Mention the return value
1169 :ignore in the docstring.
1171 2012-02-02 Glenn Morris <rgm@gnu.org>
1173 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1175 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1176 Unconditionally set to t. (Bug#10673)
1177 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1178 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1179 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1181 2012-02-02 Kenichi Handa <handa@m17n.org>
1183 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1184 0, do not call append_composite_glyph.
1186 2012-02-02 Kenichi Handa <handa@m17n.org>
1188 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1190 (x_produce_glyphs): If the component of a composition is a null
1191 string, set it->pixel_width to 1 to avoid zero-width glyph.
1193 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1195 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1196 first 2 arguments are identical. This makes inserting large
1197 output from a subprocess an order of magnitude faster on
1198 MS-Windows, where all sbrk'ed memory is always contiguous.
1200 2012-01-31 Glenn Morris <rgm@gnu.org>
1202 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1203 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1204 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1206 2012-01-29 Glenn Morris <rgm@gnu.org>
1208 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1210 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1212 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1214 2012-01-28 Chong Yidong <cyd@gnu.org>
1216 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1218 2012-01-26 Chong Yidong <cyd@gnu.org>
1220 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1222 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1223 repeat counts (Bug#10507).
1225 2012-01-26 Glenn Morris <rgm@gnu.org>
1227 * lread.c (syms_of_lread): Doc fix.
1229 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1231 * coding.c (encode_designation_at_bol): Change return value to
1234 2012-01-25 Chong Yidong <cyd@gnu.org>
1236 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1238 2012-01-21 Chong Yidong <cyd@gnu.org>
1240 * floatfns.c (Fcopysign): Make the second argument non-optional,
1241 since nil is not allowed anyway.
1243 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1245 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1246 (send_process): Likewise.
1248 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1250 * window.c (save_window_save, Fcurrent_window_configuration)
1251 (Vwindow_persistent_parameters): Do not use Qstate.
1252 Rewrite doc-strings.
1254 2012-01-19 Kenichi Handa <handa@m17n.org>
1256 * character.c (char_width): New function.
1257 (Fchar_width, c_string_width, lisp_string_width):
1258 Use char_width (Bug#9496).
1260 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1262 * window.c (Vwindow_persistent_parameters): New variable.
1263 (Fset_window_configuration, save_window_save): Handle persistent
1266 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1268 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1269 thrashing the stack of the thread. (Bug#9087)
1271 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1273 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1275 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1277 * xdisp.c (rows_from_pos_range): Handle the case where the
1278 highlight ends on a newline. (Bug#10464)
1279 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1280 he end column for display of highlight that ends on a newline
1283 2012-01-11 Glenn Morris <rgm@gnu.org>
1285 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1286 from load-path also when installation-directory is nil. (Bug#10208)
1288 2012-01-10 Glenn Morris <rgm@gnu.org>
1290 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1292 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1293 Update template values to be closer to their typical values these days.
1295 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1297 * xdisp.c (rows_from_pos_range): Accept additional argument
1298 DISP_STRING, and accept any glyph in a row whose object is that
1299 string as eligible for mouse highlight. Fixes mouse highlight of
1300 display strings from overlays. (Bug#10464)
1302 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1304 emacs: fix an auto-save permissions race condition (Bug#10400)
1305 * fileio.c (auto_saving_dir_umask): New static var.
1306 (Fmake_directory_internal): Use it.
1307 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1308 creating the directory. The old code temporarily assigns
1309 too-generous permissions to the directory.
1310 (do_auto_save_eh): Clear it.
1311 (Fdo_auto_save): Catch all errors, not just file errors, so
1312 that the var is always cleared.
1314 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1316 * search.c (scan_buffer): Pass character positions to
1317 know_region_cache, not byte positions. (Bug#6540)
1319 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1321 * w32.c (sys_rename): Report EXDEV when rename of a directory
1322 fails because the target is on another logical disk. (Bug#10284)
1324 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1326 * xterm.c (x_embed_request_focus): New function.
1328 * xterm.h: Add prototype.
1330 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1332 2012-01-05 Glenn Morris <rgm@gnu.org>
1334 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1336 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1338 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1339 Load gnutls_transport_set_lowat only if GnuTLS version is below
1341 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1342 GnuTLS versions below 2.11.1.
1344 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1346 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1347 to the doc string advising against its use for altering the way
1348 windows are scrolled.
1350 2011-12-28 Kenichi Handa <handa@m17n.org>
1352 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1353 coding-system ASCII compatible only when it does not produce BOM
1354 on encoding (Bug#10383).
1356 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1358 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1360 (create_and_show_popup_menu): Always use menu_position_func for
1363 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1365 * callint.c (Fcall_interactively): Don't truncate prompt string.
1367 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1369 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1370 property that ends at ZV, so that the bidi iteration could be
1371 resumed from there (after widening). (Bug#10360)
1373 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1375 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1377 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1379 * nsterm.m (x_free_frame_resources):
1380 Release f->output_data.ns->miniimage.
1381 (ns_index_color): Fix indentation. Do not retain
1382 color_table->colors[i].
1384 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1387 * nsfns.m (x_set_background_color): Assign return value from
1388 ns_index_color to face-background instead of NSColor*.
1389 (ns_implicitly_set_icon_type): Fix indentation.
1390 Change assignment in for loop to comparison.
1392 * emacs.c (ns_pool): New variable.
1393 (main): Assign ns_pool.
1394 (Fkill_emacs): Call ns_release_autorelease_pool.
1396 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1397 autorelease fdesc, release fdAttrs and tdict.
1398 (ns_get_covering_families): Release charset.
1399 (ns_findfonts): Release NSFontDescriptor created with new.
1400 (ns_uni_to_glyphs): Fix indentation.
1401 (setString): Release attrStr before assigning new value.
1403 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1405 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1407 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1408 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1410 2011-12-18 David Reitter <reitter@cmu.edu>
1412 * nsterm.m (ns_term_init): Subscribe for notifications
1413 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1414 to method trackingNotification in EmacsMenu.
1416 * nsmenu.m (trackingMenu): New variable.
1417 (trackingNotification): New method (from Aquamacs).
1418 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1419 from Aquamacs (Bug#7030).
1421 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1423 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1424 (symbol_to_nsstring): Fix indentation.
1425 (ns_symbol_to_pb): New function.
1426 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1427 (Fns_rotate_cut_buffers_internal): Remove.
1428 (Fns_store_selection_internal): Rename from
1429 Fns_store_cut_buffer_internal.
1430 (ns_get_foreign_selection, Fx_own_selection_internal)
1431 (Fx_disown_selection_internal, Fx_selection_exists_p)
1432 (Fns_get_selection_internal, Fns_store_selection_internal):
1433 Use ns_symbol_to_pb and check if return value is nil.
1434 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1435 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1436 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1437 renamed to Sns_store_selection_internal.
1438 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1439 and remove this function.
1440 (ns_handle_selection_clear): Remove, never used.
1441 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1444 2011-12-17 Ken Brown <kbrown@cornell.edu>
1446 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1447 GID is unknown (Bug#10257).
1449 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1451 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1452 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1453 which caused a build failure on GNU/Linux IA-64. This problem was
1454 introduced by my 2011-10-07 patch.
1456 2011-12-15 Juri Linkov <juri@jurta.org>
1458 * image.c (imagemagick_error): New function. (Bug#10112)
1459 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1460 Use `imagemagick_error' where ImageMagick functions return
1462 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1465 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1467 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1468 fill background (Bug#8992).
1470 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1472 * window.c (Vwindow_combination_resize)
1473 (Vwindow_combination_limit): Use t instead of non-nil in
1475 (Vrecenter_redisplay): Add first sentence of doc-string on
1477 (Frecenter): Fix doc-string typo.
1479 2011-12-11 Kenichi Handa <handa@m17n.org>
1481 * coding.c (Funencodable_char_position): Pay attention to the
1482 buffer text relocation (Bug#9389).
1484 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1486 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1487 gtk_init (Bug#10100).
1489 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1491 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1492 IT->string is nil. (Bug#10263)
1494 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1496 * nsterm.h (x_free_frame_resources): Declare.
1498 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1499 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1501 * nsterm.h (ns_get_defaults_value): Declare.
1503 * nsterm.m (ns_default): Call ns_get_defaults_value.
1505 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1507 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1510 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1512 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1513 that where the value of an _OBJC_* symbol points to is in the .bss
1514 section (Bug#10240).
1516 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1518 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1519 after the loop to call ccl_driver at least once (Bug#8619).
1521 2011-12-08 Kenichi Handa <handa@m17n.org>
1523 * ftfont.c (get_adstyle_property): Fix previous change
1526 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1528 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1529 dirs from the default value of EMACSLOADPATH (bug#10208).
1531 2011-12-07 Glenn Morris <rgm@gnu.org>
1533 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1534 installation and source directories as well. (Bug#10208)
1536 2011-12-06 Chong Yidong <cyd@gnu.org>
1538 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1540 2011-12-06 Glenn Morris <rgm@gnu.org>
1542 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1543 as an error, not just -1. (Bug#10217)
1545 2011-12-05 Chong Yidong <cyd@gnu.org>
1547 * keyboard.c (process_special_events): New function.
1548 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1550 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1552 * coding.c (encode_designation_at_bol): Don't use uninitialized
1553 local variable (Bug#9318).
1555 2011-12-05 Kenichi Handa <handa@m17n.org>
1557 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1558 return Qnil (Bug#8046, Bug#10193).
1560 2011-12-05 Kenichi Handa <handa@m17n.org>
1562 * coding.c (encode_designation_at_bol): New args charbuf_end and
1563 dst. Return the number of produced bytes. Callers changed.
1564 (coding_set_source): Return how many bytes coding->source was
1566 (coding_set_destination): Return how many bytes
1567 coding->destination was relocated.
1568 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1569 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1571 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1573 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1574 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1577 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1579 The following changes are to fix Bug#9318.
1581 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1582 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1583 (encode_coding_iso_2022, encode_coding_sjis)
1584 (encode_coding_big5, encode_coding_charset): Use the above macros.
1586 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1588 * lisp.h (process_quit_flag): Fix external declaration.
1590 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1592 Don't macro-inline non-performance-critical code.
1593 * eval.c (process_quit_flag): New function.
1594 * lisp.h (QUIT): Use it.
1596 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1598 * nsfns.m (get_geometry_from_preferences): New function.
1599 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1601 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1603 * emacs.c (Qkill_emacs): Define.
1604 (syms_of_emacs): Initialize it.
1605 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1606 Qquit_flag to `kill-emacs' instead.
1607 (quit_throw_to_read_char): Add parameter `from_signal'.
1608 All callers changed. Call Fkill_emacs if requested and safe.
1609 * lisp.h (QUIT): Call Fkill_emacs if requested.
1611 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1613 * widget.c (update_wm_hints): Return if wmshell is null.
1614 (widget_update_wm_size_hints): New function.
1616 * widget.h (widget_update_wm_size_hints): Declare.
1618 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1619 widget_update_wm_size_hints (Bug#10104).
1621 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1623 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1624 before a newline, prepare the bidi iterator for consuming the
1625 newline, and keep the current paragraph direction. (Bug#10183)
1626 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1628 2011-12-02 Juri Linkov <juri@jurta.org>
1630 * search.c (Fword_search_regexp): New Lisp function created from
1631 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1632 (Fword_search_backward, Fword_search_forward)
1633 (Fword_search_backward_lax, Fword_search_forward_lax):
1634 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1635 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1637 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * fileio.c (Finsert_file_contents): Move after-change-function call
1640 to before the "handled:" label, since all "goto handled" appear in
1641 cases where the *-change-functions have already been properly called
1644 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1646 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1647 waiting for input. (Bug#10169)
1649 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1651 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1652 verifies glyph row's hash code--we have just reallocated the
1653 glyphs, so their contents can be complete garbage. (Bug#10164)
1655 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1657 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1659 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1661 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1662 attributes are tested _before_ calling verify_row_hash, to protect
1663 against GCC re-ordering of the tests. (Bug#10164)
1665 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1667 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1669 * xterm.c (handle_one_xevent): Only set async_visible and friends
1670 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1671 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1672 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1674 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1676 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1677 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1678 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1679 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1680 All uses changed to use GCPRO1 etc.
1681 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1682 Revert to old implementation (i.e., before 2011-03-11).
1684 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1686 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1687 of scroll runs so as to avoid assigning disabled bogus rows and
1688 unnecessary graphics copy operations.
1690 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1692 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1693 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1694 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1695 (malloc, free, realloc, calloc): Redirect to e_* only when
1698 * lisp.h (GCTYPEBITS): Move before first use.
1699 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1700 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1701 this macro definition.
1703 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1706 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1708 * gtkutil.c (xg_create_frame_widgets):
1709 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1710 present with Gtk+ 2.0.
1712 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1714 * fileio.c (Finsert_file_contents): Undo previous change; see
1715 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1717 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1719 Rename locals to avoid shadowing.
1720 * fileio.c (Finsert_file_contents):
1721 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1722 * process.c (wait_reading_process_output):
1723 Rename inner 'proc' to 'p' to avoid shadowing.
1724 Indent for consistency with usual Emacs style.
1726 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1728 * xdisp.c (redisplay_window): If cursor row is not fully visible
1729 after recentering, and scroll-conservatively is set to a large
1730 number, scroll window by a few more lines to make the cursor fully
1731 visible and out of scroll-margin. (Bug#10105)
1732 (start_display): Don't move to the next line if the display should
1733 start at a newline that is part of a display vector or an overlay
1736 2011-11-24 Juri Linkov <juri@jurta.org>
1738 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1739 after the `MagickPingImage' call. (Bug#10112)
1741 2011-11-23 Chong Yidong <cyd@gnu.org>
1743 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1745 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1747 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1748 making another buffer current. (Bug#10114)
1750 2011-11-23 Glenn Morris <rgm@gnu.org>
1752 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1754 2011-11-23 Chong Yidong <cyd@gnu.org>
1756 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1757 using it (Bug#5984).
1759 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1761 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1762 and header-lines, as they don't have one computed for them.
1765 * .gdbinit (prow): Make displayed values more self-explaining.
1766 Add row's hash code.
1768 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1770 * process.c (wait_reading_process_output): Fix asynchrounous
1771 GnuTLS socket handling on some versions of the GnuTLS library.
1772 (wait_reading_process_output): Add comment and URL.
1774 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1776 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1778 2011-11-21 Chong Yidong <cyd@gnu.org>
1780 * window.c (Fnext_window, Fprevious_window): Doc fix.
1782 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1784 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1786 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1788 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1790 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1792 * window.c (Fset_window_combination_limit): Rename argument
1794 (Vwindow_combination_limit): Remove "status" from doc-string.
1796 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1798 * m/ibms390.h: Remove.
1799 * m/ibms390x.h: Don't include "ibms390.h".
1801 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1803 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1804 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1806 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1808 * casetab.c (Fset_case_table):
1809 * charset.c (Fcharset_after): Fix typos.
1811 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1813 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1814 Otherwise, valgrind does not work on some platforms.
1815 Problem reported by Andreas Schwab in
1816 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1817 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1818 is set, removing the need for VIRT_ADDRESS_VARIES.
1819 (PURE_P): Use a more-efficient implementation that needs just one
1820 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1821 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1822 to 4 (xorl, subq, cmpq, setbe).
1823 * alloc.c (pure): Always extern now, since that's the
1824 VIRT_ADDR_VARIES behavior.
1825 (PURE_POINTER_P): Use a single comparison, not two, for
1826 consistency with the new puresize.h.
1827 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1828 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1829 Remove VIRT_ADDR_VARIES no longer needed.
1831 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1833 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1834 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1835 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1836 behave as if the cursor position were at the window margin.
1838 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1839 and the cursor position is out of bounds, behave as if the cursor
1840 position were at the window margin. (Bug#10075)
1842 2011-11-18 Chong Yidong <cyd@gnu.org>
1844 * window.c (Fwindow_combination_limit): Make first argument
1845 non-optional, since it is meaningless for live windows like the
1848 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1850 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1852 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1854 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1855 (graft_intervals_into_buffer): Simplify.
1857 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1859 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1860 hash values of the two rows.
1861 (copy_row_except_pointers): Preserve the used[] arrays and the
1862 hash values of the two rows. (Bug#10035)
1863 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1865 * xdisp.c (row_hash): New function, body extracted from
1866 compute_line_metrics.
1867 (compute_line_metrics): Call row_hash, instead of computing the
1870 * dispnew.c (verify_row_hash): Call row_hash for computing the
1871 hash code of a row, instead of duplicating code from xdisp.c.
1873 * dispextern.h (row_hash): Add prototype.
1875 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1877 * frame.c (delete_frame): Don't delete the terminal when the last
1878 X frame is closed if emacs is built with GTK toolkit.
1880 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1882 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1884 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1886 * window.c (Vwindow_splits): Rename to
1887 Vwindow_combination_resize. Suggested by Juri Linkov.
1888 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1891 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1893 * nsfns.m (Fns_font_name):
1894 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1896 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1898 * window.h (window): Rename slot "nest" to "combination_limit".
1899 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1900 (Fset_window_nest): Rename to Fset_window_combination_limit.
1901 (Vwindow_nest): Rename to Vwindow_combination_limit.
1902 (recombine_windows, make_parent_window, make_window)
1903 (Fsplit_window_internal, saved_window)
1904 (Fset_window_configuration, save_window_save): Rename all
1905 occurrences of window_nest to window_combination_limit.
1907 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1909 * image.c (imagemagick_load_image): Fix typo.
1911 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1913 * xdisp.c (display_line): Move the call to
1914 highlight_trailing_whitespace before the call to
1915 compute_line_metrics, since the latter needs to see the final
1916 faces of all the glyphs to compute ROW's hash value.
1917 Fixes assertion violations in row_equal_p. (Bug#10035)
1919 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1921 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1922 just return (bug#10044).
1924 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1926 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1927 with user-defined heap size. Bump the default size of the temacs
1928 heap to 27MB, to avoid memory warning when running temacs.
1929 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1931 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1932 current_matrix and desired_matrix. (Bug#9990)
1933 (verify_row_hash) [XASSERTS]: New function.
1934 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1935 that the hash value of glyph rows is correct.
1937 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1939 * window.h (window): Remove splits slot.
1940 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1941 (Fdelete_other_windows_internal, make_parent_window)
1942 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1943 (Fset_window_configuration, save_window_save): Don't deal with
1944 split status of windows.
1945 (saved_window): Remove splits slot.
1946 (Vwindow_splits): Rewrite doc-string.
1948 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1950 * xfns.c (unwind_create_frame):
1951 * nsfns.m (unwind_create_frame):
1952 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1953 Vframe_list (Bug#9999).
1955 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1957 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1959 2011-11-11 Kenichi Handa <handa@m17n.org>
1961 * callproc.c (Fcall_process): Set the member dst_multibyte of
1964 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1966 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1967 avoid a crash (bug#9496).
1969 2011-11-09 Chong Yidong <cyd@gnu.org>
1971 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1972 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1974 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1976 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1978 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1980 Avoid some portability problems by eschewing 'extern inline' functions.
1981 The trivial performance wins aren't worth the portability hassles; see
1982 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1984 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1985 (window_box_width, window_box_left, window_box_left_offset)
1986 (window_box_right, window_box_right_offset): Undo previous change,
1987 by removing the "extern"s.
1988 * intervals.c (adjust_intervals_for_insertion)
1989 (adjust_intervals_for_deletion): Undo previous change,
1990 making these static again.
1991 (offset_intervals, temp_set_point_both, temp_set_point)
1992 (copy_intervals_to_string): No longer inline.
1993 * xdisp.c (window_text_bottom_y, window_box_width)
1994 (window_box_height, window_box_left_offset)
1995 (window_box_right_offset, window_box_left, window_box_right)
1996 (window_box): No longer inline.
1998 2011-11-08 Chong Yidong <cyd@gnu.org>
2000 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2001 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2002 Signal an error if not a live window.
2003 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2004 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2006 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2008 * lisp.h (syms_of_abbrev): Remove declaration.
2009 Reported by CHENG Gao <chenggao@royau.me>.
2011 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2013 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2014 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2015 of temacs in GUI mode.
2017 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2019 * window.h: Declare delete_all_child_windows instead of
2020 delete_all_subwindows.
2021 * window.c (Fwindow_nest, Fset_window_nest)
2022 (Fset_window_new_total, Fset_window_new_normal)
2023 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2024 (delete_all_subwindows): Rename to delete_all_child_windows.
2025 (Fdelete_other_windows_internal, Fset_window_configuration):
2026 Call delete_all_child_windows instead of delete_all_subwindows.
2027 * frame.c (delete_frame): Call delete_all_child_windows instead
2028 of delete_all_subwindows.
2030 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2032 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2033 This is also needed for porting to any host where GC_MARK_STACK is
2034 not GC_MAKE_GCPROS_NOOPS.
2035 (which_symbols): Use it.
2037 2011-11-07 Kenichi Handa <handa@m17n.org>
2039 * coding.c (coding_set_destination): Check coding->src_pos only
2040 when coding->src_object is a buffer (bug#9910).
2042 * process.c (send_process): Set the member src_multibyte of coding
2043 to 0 (bug#9911) when sending a unibyte text.
2045 * callproc.c (Fcall_process): Set the member src_multibyte of
2046 process_coding to 0 (bug#9912).
2048 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2050 * xmenu.c (cleanup_widget_value_tree): New function.
2051 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2052 calling free_menubar_widget_value_tree directly (Bug#9830).
2054 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2056 Fix some portability problems with 'inline'.
2057 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2058 (window_box_width, window_box_left, window_box_left_offset)
2059 (window_box_right, window_box_right_offset): Declare extern.
2060 Otherwise, these inline functions do not conform to C99 and
2061 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2062 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2063 * intervals.c (adjust_intervals_for_insertion)
2064 (adjust_intervals_for_deletion): Now extern, because otherwise the
2065 extern inline functions 'offset_intervals' couldn't refer to it.
2066 (static_offset_intervals): Remove.
2067 (offset_intervals): Rewrite using the old contents of
2068 static_offset_intervals. The old version didn't conform to C99
2069 because an extern inline function contained a reference to an
2070 identifier with static linkage.
2072 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2074 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2077 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2079 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2080 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2081 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2082 return Qleft_to_right.
2084 2011-11-06 Chong Yidong <cyd@gnu.org>
2086 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2087 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2088 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2089 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2090 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2091 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2092 (Fwindow_vscroll): Doc fix.
2093 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2094 argument, since it makes no sense to pass a live window and for
2095 consistency with window-child.
2097 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2099 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2102 2011-11-05 Jason Rumney <jasonr@gnu.org>
2104 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2105 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2107 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2108 bitwise arithmetic preventing use of unicode-sip and non-truetype
2111 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2113 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2116 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2117 initialization code to keep similarity to xfns.c after changes
2120 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2122 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2123 (unwind_create_frame): New function (Bug#9943).
2124 (Fx_create_frame): Restructure code to be more similar to the one in
2125 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2126 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2127 Move terminal->reference_count++ just before making the frame official
2130 * nsterm.m (x_free_frame_resources): New function.
2131 (x_destroy_window): Move code to x_free_frame_resources.
2133 * xfns.c (unwind_create_frame): Fix comment.
2134 (Fx_create_frame, x_create_tip_frame):
2135 Move terminal->reference_count++ just before making the frame
2136 official. Move initialization of image_cache_refcount and
2137 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2139 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2141 Support MSVC build with newer versions of Visual Studio.
2142 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2143 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2146 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2147 which are not supported by MSVC.
2148 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2149 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2151 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2153 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2155 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2157 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2159 Support MSVC build with newer versions of Visual Studio.
2160 * w32.c: Don't include w32api.h for MSVC.
2161 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2163 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2164 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2165 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2166 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2168 (alloca) [_MSC_VER]: Define to _alloca.
2170 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2172 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2174 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (note_mouse_highlight): If either of
2177 previous/next-single-property-change returns nil, treat that as
2178 the beginning or the end of the buffer. (Bug#9955)
2180 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2182 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2183 label is not null (Bug#9951).
2184 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2187 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2189 * window.c (Fwindow_body_size): Mention in the doc string that the
2190 return value is in frame's canonical units. (Bug#9949)
2192 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2194 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2196 * w32fns.c (unwind_create_frame): If needed, free the glyph
2197 matrices of the partially constructed frame. (Bug#9943)
2198 * xfns.c (unwind_create_frame): Likewise.
2200 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2202 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2203 Don't stop backward scan on the continuation glyph, even though
2204 its CHARPOS is positive.
2205 (mouse_face_from_buffer_pos, note_mouse_highlight):
2206 Rename cover_string to disp_string.
2208 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2210 * window.c (temp_output_buffer_show): Don't use
2211 Vtemp_buffer_show_specifiers.
2212 (Vtemp_buffer_show_specifiers): Remove unused variable.
2214 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2216 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2217 past the beginning of the current glyph matrix.
2219 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2221 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2222 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2223 HAVE_GTK3 (Bug#9869).
2225 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2226 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2228 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2230 * xterm.c: Declare x_handle_net_wm_state to return int.
2231 (handle_one_xevent): Check if we are iconified but don't have
2232 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2233 (get_current_wm_state): Return non-zero if not hidden,
2234 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2235 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2236 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2237 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2239 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2241 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2242 so that this new function doesn't get optimized away by a
2243 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2245 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2247 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2249 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2251 Fix the `xbytecode' command.
2252 * .gdbinit (xprintbytestr): New command.
2253 (xwhichsymbols): Rename from `which'; all callers changed.
2254 (xbytecode): Print the byte-code string as well.
2256 2011-10-29 Kim Storm <storm@cua.dk>
2258 * alloc.c (which_symbols): New function.
2260 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2262 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2265 2011-10-29 Glenn Morris <rgm@gnu.org>
2267 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2268 Not clear what it was for, and it causes various bugs. (Bug#9839)
2270 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2272 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2273 possible random value that matches one of those tested as
2274 condition to clear the mouse face.
2276 2011-10-28 Chong Yidong <cyd@gnu.org>
2278 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2280 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2282 * window.c (make_window): Initialize phys_cursor_on_p.
2284 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2286 * lisp.h (struct Lisp_Symbol): Update comments.
2288 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2290 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2292 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2294 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2295 <oslsachem@gmail.com> for helping to debug this.
2297 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2298 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2299 (g_b_init_get_glyph_outline_w): New static variables.
2300 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2301 (GetGlyphOutlineW_Proc): New typedefs.
2302 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2303 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2305 (w32font_open_internal, compute_metrics):
2306 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2307 instead of calling the "wide" APIs directly.
2309 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2311 * w32.h (syms_of_w32font): Add prototype.
2313 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2315 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2316 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2317 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2318 (Fmove_to_window_line): Doc fix.
2320 2011-10-27 Chong Yidong <cyd@gnu.org>
2322 * process.c (make_process): Set gnutls_state to NULL.
2324 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2325 non-NULL, regardless of GNUTLS_INITSTAGE.
2326 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2327 an error. Set process slots as soon as we allocate them.
2329 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2331 2011-10-27 Chong Yidong <cyd@gnu.org>
2333 * gnutls.c (emacs_gnutls_deinit): New function.
2334 Deallocate credentials structures as well as calling gnutls_deinit.
2335 (Fgnutls_deinit, Fgnutls_boot): Use it.
2337 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2338 (deactivate_process): Call emacs_gnutls_deinit.
2340 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2342 * image.c (x_create_x_image_and_pixmap):
2343 * w32.c (sys_rename, w32_delayed_load):
2344 * w32font.c (fill_in_logfont):
2345 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2347 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2349 * w32fns.c (w32_default_color_map): New function,
2350 extracted from Fw32_default_color_map.
2351 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2353 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2355 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2357 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2359 * keyboard.c (test_undefined): New function (bug#9751).
2360 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2362 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2364 * sysdep.c (init_sys_modes): Fix the check for the controlling
2365 terminal (Bug#6649).
2367 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2369 * dispextern.h (struct bidi_it): New member next_en_type.
2371 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2372 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2373 current character, check also for next_en_type being WEAK_EN.
2374 (bidi_resolve_weak): Don't enter the expensive loop if the current
2375 position is before next_en_pos. Record the bidi type of the first
2376 non-ET, non-BN character we find, in addition to its position.
2377 (bidi_level_of_next_char): Invalidate next_en_type when
2378 next_en_pos is over-stepped.
2380 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2382 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2383 * editfns.c: Rewrite current-time-zone so that it invokes
2384 the equivalent of (format-time-string "%Z") to get the time zone name.
2385 This fixes a bug when the time zone name contains characters that
2386 need converting from the system time locale to Emacs internal format.
2387 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2388 that patch fixed format-time-string to do the conversion, but
2389 I forgot to fix current-time-zone.
2390 (format_time_string): New function, containing most of
2391 what Fformat_time_string used to contain.
2392 (Fformat_time_string): Rewrite in terms of format_time_string.
2393 This doesn't change this function's behavior.
2394 (current-time-zone): Rewrite to use format_time_string.
2395 This fixes the bug reported by Michael Schierl in
2396 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2397 Jason Rumney's 2007-06-07 change worked around this bug, but
2399 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2401 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2403 * xdisp.c (start_display): If the character at POS is displayed
2404 via a display vector, reset IT->current.dpvec_index to zero.
2405 (try_window_reusing_current_matrix): If a line ends in a display
2406 vector or the next line starts in a display vector, continue
2407 redrawing the window even though the character position of
2408 start_row was reached.
2411 2011-10-18 Chong Yidong <cyd@gnu.org>
2413 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2414 with nobreak-char-display too.
2416 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2418 Fix part 3 of bug#9771.
2419 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2420 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2421 non-neutral characters if the current character is a paragraph
2422 separator (a.k.a. Newline). This avoids running the same
2423 expensive loop twice, once when we consume the preceding newline
2424 and the other time when the line actually needs to be displayed.
2425 Avoid the loop when we see neutrals on the base embedding level
2426 following a character whose directionality is the same as the
2427 paragraph's. This avoids running the expensive loop when a line
2428 ends in a long sequence of neutrals, like control characters.
2429 Add assertion against STRONG_AL type. Slightly rearrange code
2430 that determines the type of a neutral given the first non-neutral
2432 (bidi_level_of_next_char): Set next_en_pos to zero when
2433 invalidating its info.
2435 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2437 * xdisp.c (push_display_prop): Determine whether to record string
2438 or buffer position by IT->string, not by IT->method. Allow
2439 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2440 (move_it_vertically_backward): Don't look for character position
2441 immediately after the newline when in a continuation line.
2444 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2446 * window.c (coordinates_in_window): Rewrite and delabelize
2447 vertical border check. (Bug#5357) (Bug#9618)
2449 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2451 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2452 errors in XSetWindowBorder (bug#9310).
2454 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2456 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2457 avoid crash when xmalloc overrun checking is enabled.
2459 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2461 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2462 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2463 cursor motion with <left> and <right> arrow keys.
2465 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2466 some callers set that themselves.
2468 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2470 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2471 display string and the previous row comes from the same string and
2472 is empty. (Bug#9739) (Bug#9738)
2474 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2476 * doc.c (get_doc_string): Encode file name (bug#9735).
2478 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2480 * bidi.c (bidi_level_of_next_char):
2481 * xdisp.c (get_visually_first_element): Remove old incorrect
2482 comments regarding the Unicode Line Separator character.
2484 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2486 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2488 * alloc.c (Fgc_status): Do not access beyond zombies array
2489 boundary if nzombies > MAX_ZOMBIES.
2490 * alloc.c (dump_zombies): Add missing format specifier.
2492 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2494 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2495 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2497 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2498 Some packages use them to denote characters with modifiers.
2500 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2502 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2503 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2504 matching a pp-number. Rename parameter var to var1.
2506 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2508 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2510 2011-10-08 Glenn Morris <rgm@gnu.org>
2512 * callint.c (Fcall_interactively): Give a more explicit error for the
2513 'c' case with a non-character input. (Bug#8479)
2515 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2517 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2519 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2520 lines that are hscrolled on the left.
2522 * dispnew.c (buffer_posn_from_coords): Account for a possible
2523 presence of header-line. (Bug#4426)
2525 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2527 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2528 Don't advertise functionality which we discourage or doesn't work.
2530 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2532 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2533 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2534 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2535 this makes Emacs dump core during garbage collection on rare
2536 occasions. sizeof is obviously inferior to offsetof here, so
2537 stick with offsetof.
2538 (GC_POINTER_ALIGNMENT): New macro.
2539 (mark_memory): Omit 3rd (offset) arg; caller changed.
2540 Don't assume EMACS_INT alignment is the same as pointer alignment.
2542 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2544 * keyboard.c (read_key_sequence_remapped): New var.
2545 (read_key_sequence): Compute remapping in the right buffer.
2546 (command_loop_1): Use read_key_sequence's remapping directly.
2548 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2550 * dired.c (file_name_completion): Don't expand file name.
2551 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2552 before checking file name handler.
2554 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2555 they've been requested explicitly (bug#9591).
2557 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2559 * keymap.c (Fsingle_key_description): Use make_specified_string
2560 instead of build_string to build string from push_key_description.
2563 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2565 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2566 This fixes a Y2038 bug on 64-bit hosts.
2567 * buffer.c (reset_buffer):
2568 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2569 (Fclear_buffer_auto_save_failure):
2570 Use 0, not -1, to represent an unset failure time, since time_t
2571 might not be signed.
2573 Remove dependency on glibc malloc internals.
2574 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2575 Move back here from lisp.h, but with their new implementations.
2576 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2577 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2578 * charset.c (charset_table_init): New static var.
2579 (syms_of_charset): Use it instead of xmalloc. This removes a
2580 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2581 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2582 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2583 Move back to alloc.c.
2584 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2585 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2587 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2589 * nsterm.m (windowDidResize): Call x_set_window_size only when
2590 ns_in_resize is true. Otherwise set pixelwidth/height and
2591 call change_frame_size (Bug#9628).
2593 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2595 Port --enable-checking=all to Fedora 14 x86-64.
2596 * charset.c (syms_of_charset): Also account for glibc malloc's
2597 internal overhead when calculating the initial malloc maximum.
2599 Port --enable-checking=all to Fedora 14 x86.
2600 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2602 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2603 (overrun_check_realloc, overrun_check_free):
2604 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2605 That way, xmalloc returns a properly-aligned pointer even if
2606 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2607 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2608 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2609 into account when calculating the initial malloc maximum.
2610 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2611 Move here from alloc.c, so that charset.c can use it too.
2612 Properly align; the old code wasn't right for common 32-bit hosts
2613 when configured with --enable-checking=all.
2614 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2615 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2617 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2619 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2622 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2624 * xdisp.c (compute_display_string_end): If there's no display
2625 string at CHARPOS, return -1.
2627 * bidi.c (bidi_fetch_char): When compute_display_string_end
2628 returns a negative value, treat the character as a normal
2629 character not covered by a display string. (Bug#9624)
2631 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2633 * lread.c (Fread_from_string): Fix typo in docstring.
2635 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2637 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2638 newline, reseat the iterator instead of bidi-iterating there one
2639 character at a time. (Bug#9610)
2640 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2641 TO_CHARPOS if the bidi iterator is at base embedding level.
2643 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2645 * lread.c (readevalloop): Use correct code for NBSP.
2646 (read1): Likewise. (Bug#9608)
2648 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2650 * dbusbind.c (Fdbus_register_signal): When service is not
2651 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2653 2011-09-25 Glenn Morris <rgm@gnu.org>
2655 * buffer.c (truncate-lines): Doc fix.
2657 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2659 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2660 (Fset_window_next_buffers): Doc fix.
2662 2011-09-24 Glenn Morris <rgm@gnu.org>
2664 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2666 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2668 Fix minor problems found by static checking.
2669 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2670 * indent.c (Fvertical_motion): Fix == vs = typo.
2672 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2674 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2675 Default value is now t. Doc fix.
2677 * indent.c (Fvertical_motion): Compute and apply the overshoot
2678 logic when moving up, not only when moving down. Fix the
2679 confusing name and values of the it_overshoot_expected variable;
2680 logic changes accordingly. (Bug#9254) (Bug#9549)
2682 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2683 CHARPOS is covered by a display string which includes newlines.
2684 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2685 is covered by a display string with embedded newlines.
2687 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2689 * dbusbind.c (Fdbus_register_signal): Add match rule to
2690 Vdbus_registered_objects_table. (Bug#9581)
2691 (Fdbus_register_method, Vdbus_registered_objects_table):
2694 2011-09-24 Jim Meyering <meyering@redhat.com>
2696 do not ignore write error for any output size
2697 The previous change was incomplete.
2698 While it makes emacs --batch detect the vast majority of stdout
2699 write failures, errors were still ignored whenever the output size is
2700 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2701 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2702 && echo FAIL: ignored write error
2703 FAIL: ignored write error
2704 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2705 && echo FAIL: ignored write error
2706 FAIL: ignored write error
2707 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2709 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2711 * emacs.c (Fkill_emacs): In noninteractive mode exit
2712 non-successfully if a write error occurred on stdout. (Bug#9574)
2714 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2716 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2719 * dispextern.h (struct it): Update the comment documenting what
2722 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2724 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2725 a display string, extend search for cursor position to end of row.
2726 (find_row_edges): If the row ends in a newline from a display
2727 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2728 Handle the case of a display string with multiple newlines.
2729 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2730 non-empty line. Fixes confusing cursor motion with arrow keys at
2731 the beginning of a line that starts with whitespace.
2733 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2735 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2738 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2740 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2743 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2745 * xdisp.c (display_line): Record maximum and minimum buffer
2746 positions even if no glyphs were produced (e.g., by a zero-width
2747 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2748 buffer positions that will be removed from the glyph row because
2750 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2751 column is beyond frame width: don't subtract 1 "pixel" when
2752 computing width of the stretch.
2753 (reseat_at_next_visible_line_start): Undo the change made on
2754 2011-09-17 that saved paragraph information and restored it after
2755 the call to `reseat'. (Bug#9545)
2757 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2759 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2760 and turn window cursor on if cleared (Bug#9415).
2762 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2764 * search.c (boyer_moore): Take unibyte characters from pattern
2765 literally. (Bug#9458)
2767 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2769 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2771 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2773 Fix minor problem found by static checking.
2774 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2775 initialized, to pacify gcc -Wuninitialized.
2777 * fileio.c: Report proper errno when syscall falls.
2778 (Finsert_file_contents): Save and restore errno,
2779 so that report_file_error outputs the correct diagnostic.
2780 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2782 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2784 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2786 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2788 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2789 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2791 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2793 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2794 about the current paragraph and restore it after the call to reseat.
2796 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2797 (bidi_find_paragraph_start): Search back for paragraph beginning
2798 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2799 (bidi_move_to_visually_next): Only trigger paragraph-related
2800 computations when the last character is a newline or at EOB, not
2801 just any NEUTRAL_B. (Bug#9470)
2803 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2804 truncated lines if point is covered by a display string. (Bug#9524)
2806 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2808 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2809 (cons_to_x_long): New function.
2810 (lisp_data_to_selection_data): Use it. Correct the test for
2811 short-versus-long data; it was negated. Break out of vector
2812 loop, for efficiency, when a long datum is discovered.
2814 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2816 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2818 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2820 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2821 GCC PR/17406) by declaring this function with external scope.
2823 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2825 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2826 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2828 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2830 * editfns.c (Fformat): Correctly handle text properties on "%%".
2832 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2834 * xterm.c (x_draw_composite_glyph_string_foreground):
2835 * w32term.c (x_draw_composite_glyph_string_foreground):
2836 * term.c (encode_terminal_code):
2837 * composite.c (composition_update_it, get_composition_id):
2838 * xdisp.c (get_next_display_element)
2839 (fill_composite_glyph_string): Add comments about special meaning
2840 of TAB characters in a composition.
2842 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2844 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2845 This occurs when processing a multibyte format.
2846 Problem reported by Wolfgang Jenker.
2848 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2850 * xdisp.c (try_cursor_movement): Only check for exact match if
2851 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2853 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2855 Remove unused external symbols.
2856 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2857 * xdisp.c (calc_pixel_width_or_height): Now static.
2858 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2859 * indent.c (check_display_width):
2860 * w32term.c: Fix comment to match code.
2861 * xterm.c, xterm.h (x_catching_errors): Remove.
2863 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2865 * xselect.c: Use signed conversions more consistently (Bug#9498).
2866 (selection_data_to_lisp_data): Assume incoming selection data are
2867 signed integers, not unsigned. This is to be consistent with
2868 outgoing selection data, which was modified to use signed integers
2869 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2870 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2871 expects long, not unsigned long.
2873 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2875 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2876 computation of loop end. Reported by Johan Bockgård
2879 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2881 * frame.c (Fother_visible_frames_p): Function deleted.
2883 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2885 * indent.c (compute_motion): Process display vector front to back
2886 rather than the other way around. (Bug#2496)
2888 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2890 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2892 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2894 * minibuf.c (Fread_from_minibuffer): Doc fix.
2896 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2898 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2899 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2901 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2904 value for non-existent files.
2906 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2908 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2909 set its "size" to -1. This will set the modtime_size field of
2910 the corresponding buffer to -1, which is what
2911 verify-visited-file-modtime expects for files that do not exist.
2914 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2916 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2918 * lisp.h: ... from here. push_key_description is no longer
2919 defined in keyboard.c, so its declaration should not be in
2920 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2921 logically belongs with push_key_description.
2923 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2925 * buffer.h: Include <sys/types.h> instead of <time.h>.
2926 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2927 Problem reported by Herbert J. Skuhra.
2929 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2931 * xml.c (parse_region): Make the parsing work for
2932 non-comment-starting XML files again (bug#9144).
2934 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2936 * image.c (gif_load): Fix calculation of bottom and right corner.
2939 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2941 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2942 redisplay in small windows.
2944 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2946 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2948 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2950 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2951 Operate on live windows only.
2953 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2955 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2957 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2960 only under bidi iteration.
2962 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2964 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2966 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2968 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2969 Without this fix, the command to link temacs failed due to an
2970 undefined symbol __builtin_isnan. This is because
2971 /usr/include/iso/math_c99.h #defines isnan(x) to
2972 __builtin_isnan(x), but the bundled gcc, which identifies itself
2973 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2975 * floatfns.c (isnan): #undef, and then #define to a clone of
2977 (Fisnan): Always define, since it's always available now.
2978 (syms_of_floatfns): Always define isnan at the Lisp level.
2980 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2982 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2984 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2986 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2987 The previous code assumed that file offsets (off_t values) fit in
2988 EMACS_INT variables, which is not true on typical 32-bit hosts.
2989 The code messed up by falsely reporting buffer overflow in cases
2990 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2991 when "big" contains more than 2**29 bytes, even though this
2992 inserts just one byte and does not overflow the buffer.
2993 (Finsert_file_contents): Store file offsets as off_t
2994 values, not as EMACS_INT values. Check for overflow when
2995 converting between EMACS_INT and off_t. When checking for
2996 buffer overflow or for overlap, take the offsets into account.
2997 Don't use EMACS_INT for small values where int suffices.
2998 When checking for overlap, fix a typo: ZV was used where
2999 ZV_BYTE was intended.
3000 (Fwrite_region): Don't assume off_t fits into 'long'.
3001 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3003 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3005 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3007 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3009 sprintf-related integer and memory overflow issues (Bug#9412).
3011 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3012 (esprintf, exprintf, evxprintf): New functions.
3013 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3014 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3015 (modify_event_symbol): Do not assume that the length of
3016 name_alist_or_stem is safe to alloca and fits in int.
3017 (Fexecute_extended_command): Likewise for function name and binding.
3018 (Frecursion_depth): Wrap around reliably on integer overflow.
3019 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3020 since some callers pass EMACS_INT values.
3021 (Fsingle_key_description): Don't crash if symbol name contains more
3022 than MAX_ALLOCA bytes.
3023 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3024 (get_minibuffer): Arg is now EMACS_INT, not int.
3025 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3026 (esprintf, exprintf, evxprintf): New decls.
3027 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3029 * dbusbind.c (signature_cat): New function.
3030 (xd_signature, Fdbus_register_signal):
3031 Do not overrun buffer; instead, report string overflow.
3033 * dispnew.c (add_window_display_history): Don't overrun buffer.
3034 Truncate instead; this is OK since it's just a log.
3036 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3037 even if the time zone offset is outlandishly large.
3038 Don't mishandle offset == INT_MIN.
3040 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3041 when creating daemon; the previous buffer-overflow check was incorrect.
3043 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3044 which has the guts of the old verror function.
3046 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3047 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3049 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3050 (font_unparse_xlfd): Don't blindly alloca long strings.
3051 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3052 fits in int, when using sprintf. Use single snprintf to count
3053 length of string rather than counting it via multiple sprintfs;
3054 that's simpler and more reliable.
3055 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3056 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3057 sprintf, in case result does not fit in int.
3059 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3060 (fontset_from_font): Print it.
3062 * frame.c (tty_frame_count): Now printmax_t, not int.
3063 (make_terminal_frame, set_term_frame_name): Print it.
3064 (x_report_frame_params): In X, window IDs are unsigned long,
3065 not signed long, so print them as unsigned.
3066 (validate_x_resource_name): Check for implausibly long names,
3067 and don't assume name length fits in 'int'.
3068 (x_get_resource_string): Don't blindly alloca invocation name;
3069 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3072 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3073 (xg_check_special_colors, xg_set_geometry):
3074 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3076 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3077 Use esprintf, not sprintf, in case result does not fit in int.
3079 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3080 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3081 it as a large positive number.
3082 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3083 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3085 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3086 in case result does not fit in int.
3088 * print.c (float_to_string): Detect width overflow more reliably.
3089 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3090 buffer overrun. Don't assume list length fits in 'int'. Treat
3091 print length of 0 as 0, not as infinity; to be consistent with other
3092 uses of print length in this function. Don't overflow print length
3093 index. Don't assume hash table size fits in 'long', or that
3094 vectorlike size fits in 'unsigned long'.
3096 * process.c (make_process): Use printmax_t, not int, to format
3097 process-name gensyms.
3099 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3101 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3102 to avoid potential buffer overrun.
3104 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3105 if X resource line is longer than 512 bytes.
3107 * xfns.c (x_window): Make sprintf buffer a bit bigger
3108 to avoid potential buffer overrun.
3110 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3112 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3114 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3116 Integer overflow fixes for scrolling, etc.
3117 Without these, Emacs silently mishandles large integers sometimes.
3118 For example, "C-u 4294967297 M-x recenter" was treated as if
3119 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3121 * xdisp.c (try_window_id): Check Emacs fixnum range before
3122 converting to 'int'.
3124 * window.c (window_scroll_line_based, Frecenter):
3125 Check that an Emacs fixnum is in range before assigning it to 'int'.
3126 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3127 values converted from Emacs fixnums.
3128 (Frecenter): Don't wrap around a line count if it is out of 'int'
3129 range; instead, treat it as an extreme value.
3130 (Fset_window_configuration, compare_window_configurations):
3131 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3133 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3134 that can exceed INT_MAX. Check that EMACS_INT value is in range
3135 before assigning it to the (possibly-narrower) index.
3136 (match_limit): Don't assume that a fixnum can fit in 'int'.
3138 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3141 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3142 (Fvertical_motion): Don't wrap around LINES values that don't fit
3143 in 'int'. Instead, treat them as extreme values. This is good
3144 enough for windows, which can't have more than INT_MAX lines anyway.
3146 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3148 * Require libxml/parser.h to avoid compilation warning.
3150 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3152 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3153 since this reportedly can destroy thread storage.
3155 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3157 * syntax.c (find_defun_start): Update all cache variables if
3158 exiting early (Bug#9401).
3160 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3162 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3164 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3165 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3166 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3168 * term.c (tty_append_glyph): New function.
3169 (produce_stretch_glyph): Static function and its prototype deleted.
3171 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3174 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3176 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3177 when checking :margin (Bug#9390).
3178 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3179 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3180 so that the name doesn't mislead. All uses changed.
3182 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3184 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3187 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3189 * xdisp.c (move_it_to): Don't bail out early when reaching
3190 position beyond to_charpos, if we are scanning backwards.
3191 (move_it_vertically_backward): When DY == 0, make sure we get to
3192 the first character in the line after the newline.
3194 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3196 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3197 (ccl_driver): Do not generate an out-of-range pointer.
3198 (Fccl_execute_on_string): Remove unnecessary check for
3199 integer overflow, noted by Stefan Monnier in
3200 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3201 Remove a FIXME that didn't need fixing.
3202 Simplify the newly-introduced buffer reallocation code.
3204 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3206 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3208 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3210 Integer and memory overflow issues (Bug#9196).
3212 * doc.c (get_doc_string): Rework so that
3213 get_doc_string_buffer_size is the actual buffer size, rather than
3214 being 1 less than the actual buffer size; this makes xpalloc more
3217 * image.c (x_allocate_bitmap_record, cache_image):
3218 * xselect.c (Fx_register_dnd_atom):
3219 Simplify previous changes by using xpalloc.
3221 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3222 since either will do and ptrdiff_t is convenient with xpalloc.
3224 * charset.c (charset_table_size)
3225 (struct charset_sort_data.priority): Now ptrdiff_t.
3226 (charset_compare): Don't overflow if priorities differ greatly.
3227 (Fsort_charsets): Don't assume list length fits in int.
3228 Check for size-calculation overflow when allocating sort data.
3229 (syms_of_charset): Allocate an initial charset table that is
3230 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3232 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3234 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3235 The actual value is always <= INT_MAX, and leaving it unsigned made
3236 overflow checking harder.
3238 * dispextern.h (struct glyph_matrix.rows_allocated)
3239 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3240 with xpalloc. The values are still always <= INT_MAX.
3242 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3244 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3245 (SAFE_NALLOCA): New macro.
3247 * region-cache.c (struct boundary.pos, find_cache_boundary)
3248 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3249 (set_cache_region, invalidate_region_cache)
3250 (revalidate_region_cache, know_region_cache, region_cache_forward)
3251 (region_cache_backward, pp_cache):
3252 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3253 so that ptrdiff_t * can be passed to xpalloc.
3254 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3255 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3256 (pp_cache): Don't assume cache_len fits in int.
3257 * region-cache.h: Adjust extern decls to match.
3259 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3260 EMACS_INT, since either will do, for xpalloc.
3262 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3263 (xnmalloc, xnrealloc, xpalloc): New functions.
3265 * bidi.c (bidi_shelve_header_size): New constant.
3266 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3267 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3269 * bidi.c (bidi_cache_shrink):
3270 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3272 Don't update size of array until after memory allocation succeeds,
3273 because xmalloc/xrealloc may not return.
3274 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3275 now that we have proper integer overflow checking.
3276 (record_overlay_string, overlay_strings): Catch overflows when
3277 calculating size of overlay_str_buf.
3279 * callproc.c (Fcall_process): Check for size overflow when
3280 calculating size of args2.
3281 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3282 Normally we prefer signed values, but sticking with ptrdiff_t would
3283 require adding more-complicated checks.
3285 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3286 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3287 Redo buffer-overflow calculations to avoid integer overflow.
3288 Add a FIXME comment where memory seems to be over-allocated.
3290 * character.c (Fstring): Check for size-calculation overflow.
3292 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3293 unnecessary integer overflow. Check for size overflow.
3294 (encode_coding_object): Don't update size until xmalloc succeeds.
3296 * composite.c (get_composition_id): Check for overflow in glyph
3297 length calculations.
3299 Integer and memory overflow fixes for display code.
3300 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3301 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3302 (scrolling_window): Check for overflow in size calculations.
3303 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3304 Don't assume glyph table len fits in int.
3305 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3306 (row_table_size): Now ptrdiff_t, not int.
3307 (scrolling_window): Avoid overflow in size calculations.
3308 Don't update size until allocation succeeds.
3309 * fns.c (concat): Check for overflow in size calculations.
3310 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3311 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3312 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3314 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3315 (get_doc_string): Check for size calculation overflow.
3316 Don't update size until allocation succeeds.
3317 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3318 EMACS_INT, where ptrdiff_t will do.
3319 (Fsubstitute_command_keys): Check for string overflow.
3321 * editfns.c (set_time_zone_rule): Don't assume environment length
3323 (message_length): Now ptrdiff_t, not int.
3324 (Fmessage_box): Don't update size until allocation succeeds.
3325 Don't assume message length fits in int.
3326 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3328 * emacs.c (main): Do not reallocate argv, since there is a null at
3329 the end that can be overwritten, and this way there's no need to
3330 worry about size-calculation overflow.
3331 (sort_args): Check for size-calculation overflow.
3333 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3335 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3337 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3338 (x_set_scroll_bar_width, x_figure_window_size):
3339 Check for integer overflow.
3340 (x_set_alpha): Do not assume XINT fits in int.
3342 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3343 This is for the members text_lines, text_cols, total_lines, total_cols,
3344 where the system imposes an 'int' limit.
3346 * fringe.c (Fdefine_fringe_bitmap):
3347 Don't update size until alloc works.
3349 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3350 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3352 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3353 Check for size-calculation overflow.
3354 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3355 do, as we prefer signed integers.
3356 (id_to_widget.max_size, id_to_widget.used)
3357 (xg_store_widget_in_map, xg_remove_widget_from_map)
3358 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3359 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3360 Use and return ptrdiff_t, not int.
3361 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3362 * gtkutil.h: Change prototypes to match the above.
3364 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3365 are duplicate now that they've been promoted to lisp.h.
3366 (x_allocate_bitmap_record, x_alloc_image_color)
3367 (make_image_cache, cache_image, xpm_load):
3368 Don't update size until alloc is done.
3369 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3371 Check for size calculation overflow.
3372 (ct_colors_allocated_max): New constant.
3373 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3376 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3377 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3378 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3379 Use ptrdiff_t, not int, to count maps.
3380 (read_char_minibuf_menu_prompt): Check for overflow in size
3381 calculations. Don't update size until allocation succeeds.
3382 Redo calculations to avoid overflow.
3383 * keyboard.h: Change prototypes to match the above.
3385 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3387 (current_minor_maps): Check for size calculation overflow.
3388 * keymap.h: Change prototypes to match the above.
3390 * lread.c (read1, init_obarray): Don't update size until alloc done.
3392 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3393 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3395 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3396 Now ptrdiff_t, not int.
3397 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3398 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3400 * process.c (Fnetwork_interface_list): Check for overflow
3401 in size calculation.
3403 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3405 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3406 overflow. Don't bother calling xmalloc when xrealloc will do.
3408 * search.c (Freplace_match): Check for size calculation overflow.
3409 (Fset_match_data): Don't assume list lengths fit in 'int'.
3411 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3412 for command line length. Do not attempt to address one before the
3413 beginning of an array, as that's not portable.
3415 * term.c (max_frame_lines): Remove; unused.
3416 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3418 (encode_terminal_code, calculate_costs): Check for size
3419 calculation overflow.
3420 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3421 table lengths and related sizes. Don't update size until alloc
3422 done. Redo calculations to avoid overflow.
3423 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3425 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3426 subtracting pointers.
3427 (gobble_line): Check for overflow more carefully. Don't update size
3430 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3431 Don't update size until alloc done.
3432 Redo size calculations to avoid overflow.
3433 Check for size calculation overflow.
3434 (main) [DEBUG]: Fix typo in invoking tparam1.
3436 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3437 Use ptrdiff_t, not int, for sizes.
3438 (store_mode_line_noprop_char): Don't update size until alloc done.
3440 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3441 Use ptrdiff_t, not int, for sizes.
3442 (Finternal_make_lisp_face, cache_face):
3443 Check for size calculation overflow.
3444 (cache_face): Treat size calculation overflows as if they were
3445 memory exhaustion (the usual treatment), rather than aborting.
3447 * xfns.c (x_encode_text, x_set_name_internal)
3448 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3449 sizes, since they can exceed INT_MAX in size. Check for size
3450 calculation overflow.
3452 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3453 (xg_select): Check for size calculation overflow.
3454 Don't update size until alloc done.
3456 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3457 as sprintf is limited to int lengths.
3459 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3460 (X_LONG_MIN): New macros.
3461 Use them to make the following changes clearer.
3462 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3463 This change doesn't affect the value now, but it may help remind
3464 future maintainers not to raise the value too much later.
3465 (SELECTION_QUANTUM): Remove, replacing with ...
3466 (selection_quantum): ... new function, which avoids overflow.
3468 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3469 assumption that selection length fits in 'int'.
3470 (x_reply_selection_request, x_handle_selection_request)
3471 (x_get_window_property, receive_incremental_selection)
3472 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3473 (lisp_data_to_selection_data, clean_local_selection_data):
3474 Use ptrdiff_t, not int, to record length of selection.
3475 (x_reply_selection_request, x_get_window_property)
3476 (receive_incremental_selection, x_property_data_to_lisp):
3477 Redo calculations to avoid overflow.
3478 (x_reply_selection_request): When sending hint, ceiling it at
3479 X_LONG_MAX rather than relying on wraparound overflow to send
3481 (x_get_window_property, receive_incremental_selection)
3482 (lisp_data_to_selection_data, x_property_data_to_lisp):
3483 Check for size-calculation overflow.
3484 (x_get_window_property, receive_incremental_selection)
3485 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3486 Don't store size until memory allocation succeeds.
3487 (x_get_window_property): Plug memory leak on memory exhaustion.
3488 Don't double-block input; malloc is safe here. Don't assume 2**34
3489 - 4 fits in unsigned long. Add an xassert to check
3490 XGetWindowProperty overflow. Be more careful about overflow
3491 calculations, and distinguish size from memory overflow better.
3492 (receive_incremental_selection): When tracing, don't assume
3493 unsigned int is less than INT_MAX.
3494 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3495 harmful) conversions of unsigned short to int.
3496 (lisp_data_to_selection_data): Don't assume that integers
3497 in the range -65535 through -1 fit in an X unsigned short.
3498 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3499 result parameters unless successful. Rely on cons_to_unsigned
3500 to report problems with elements; the old code wasn't right anyway.
3501 (x_check_property_data): Check for int overflow; we cannot use
3502 a wider type due to X limits.
3503 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3505 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3507 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3508 (x_term_init): Check for size calculation overflow.
3509 (x_color_cells): Don't store size until memory allocation succeeds.
3510 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3511 Don't assume alloca size is less than MAX_ALLOCA.
3512 (x_term_init): Don't assume length fits in int (sprintf is limited
3515 Use ptrdiff_t for composition IDs.
3516 * character.c (lisp_string_width):
3517 * composite.c (composition_table_size, n_compositions)
3518 (get_composition_id, composition_gstring_from_id):
3519 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3520 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3521 * window.c (Frecenter):
3522 Use ptrdiff_t, not int, for composition IDs.
3523 * composite.c (get_composition_id): Check for integer overflow.
3524 * composite.h: Adjust prototypes to match the above changes.
3526 Use ptrdiff_t for hash table indexes.
3527 * category.c (hash_get_category_set):
3528 * ccl.c (ccl_driver):
3529 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3530 * coding.c (coding_system_charset_list, detect_coding_system):
3531 * coding.h (struct coding_system.id):
3532 * composite.c (get_composition_id, gstring_lookup_cache):
3533 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3534 * image.c (xpm_get_color_table_h):
3535 * lisp.h (hash_lookup, hash_put):
3536 * minibuf.c (Ftest_completion):
3537 Use ptrdiff_t for hash table indexes, not int (which is too
3538 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3539 32-bit --with-wide-int hosts).
3541 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3542 Add a FIXME comment about memory leaks.
3543 (syms_of_charset): Don't assume xmalloc returns.
3545 Don't assume that stated character widths fit in int.
3546 * character.c (Fchar_width, c_string_width, lisp_string_width):
3547 * character.h (CHAR_WIDTH):
3548 * indent.c (MULTIBYTE_BYTES_WIDTH):
3549 Use sanitize_char_width to avoid undefined and/or bad behavior
3550 with outlandish widths.
3551 * character.h (sanitize_tab_width): Rename from sanitize_width,
3552 now that we have two such functions. All uses changed.
3553 (sanitize_char_width): New inline function.
3555 Don't assume that tab-width fits in int.
3556 * character.h (sanitize_width): New inline function.
3557 (SANE_TAB_WIDTH): New macro.
3558 (ASCII_CHAR_WIDTH): Use it.
3559 * indent.c (sane_tab_width): Remove. All uses replaced by
3560 SANE_TAB_WIDTH (current_buffer).
3561 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3563 * fileio.c: Integer overflow issues with file modes.
3564 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3566 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3567 Remove unreachable code.
3568 (read_hex, load_charset_map_from_file): Check for integer overflow.
3570 * xterm.c: Don't go over XClientMessageEvent limit.
3571 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3572 (x_send_scroll_bar_event): Likewise. Check that the size does not
3573 exceed limits imposed by XClientMessageEvent, as well as the usual
3574 ptrdiff_t and size_t limits.
3576 * keyboard.c: Overflow, signedness and related fixes.
3577 (make_lispy_movement): Use same integer type in forward decl
3578 that is used in the definition.
3579 (read_key_sequence, keyremap_step):
3580 Change bufsize argument back to int, undoing my 2011-03-30 change.
3581 We prefer signed types, and int is wide enough here.
3582 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3583 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3584 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3585 length, not size_t. Use ptrdiff_t for index, not int.
3586 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3587 possibility of integer overflow.
3589 Overflow, signedness and related fixes for images.
3591 * dispextern.h (struct it.stack[0].u.image.image_id)
3592 (struct_it.image_id, struct image.id, struct image_cache.size)
3593 (struct image_cache.used, struct image_cache.ref_count):
3594 * gtkutil.c (update_frame_tool_bar):
3595 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3596 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3597 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3598 * nsmenu.m (update_frame_tool_bar):
3599 * xdisp.c (calc_pixel_width_or_height):
3600 * xfns.c (image_cache_refcount):
3601 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3602 on typical 64-bit hosts.
3604 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3605 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3606 Omit unnecessary casts to int.
3607 (parse_image_spec): Check that integers fall into 'int' range
3608 when the callers expect that.
3609 (image_ascent): Redo ascent calculation to avoid int overflow.
3610 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3611 (lookup_image): Remove unnecessary tests.
3612 (xbm_image_p): Locals are now of int, not EMACS_INT,
3613 since parse_image_check makes sure they fit into int.
3614 (png_load, gif_load, svg_load_image):
3615 Prefer int to unsigned where either will do.
3616 (tiff_handler): New function, combining the cores of the
3617 old tiff_error_handler and tiff_warning_handler.
3618 This function is rewritten to use vsnprintf and thereby avoid
3619 stack buffer overflows. It uses only the features of vsnprintf
3620 that are common to both POSIX and native Microsoft.
3621 (tiff_error_handler, tiff_warning_handler): Use it.
3622 (tiff_load, gif_load, imagemagick_load_image):
3623 Don't assume :index value fits in 'int'.
3624 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3625 (imagemagick_load_image): Check that crop parameters fit into
3626 the integer types that MagickCropImage accepts. Don't assume
3627 Vimagemagick_render_type has a nonnegative value. Don't assume
3628 size_t fits in 'long'.
3629 (gs_load): Use printmax_t to print the widest integers possible.
3630 Check for integer overflow when computing image height and width.
3632 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3634 * xdisp.c (redisplay_window): Don't force window start if point
3635 will be invisible in the resulting window. (Bug#9324)
3637 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3639 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3640 the display spec is of the form `(space ...)'.
3641 (handle_display_spec): Return the value returned by
3642 handle_single_display_spec, not just 1 or zero.
3643 (handle_single_display_spec): If the display spec is of the form
3644 `(space ...)', and specifies display in the text area, return 2
3646 (try_cursor_movement): Check for the need to scroll more
3647 accurately, and prefer exact match for point under bidi.
3648 Don't advance `row' beyond the last row of the window.
3650 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3651 into disp_prop; all users changed.
3653 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3654 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3655 for the text covered by the display property.
3657 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3659 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3660 Change return value to nil.
3661 (Frecord_buffer): Delete unused function.
3663 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3665 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3666 buffers, return left-to-right.
3667 (set_cursor_from_row): Consider candidate row a win if its glyph
3668 represents a newline and point is on that newline. Fixes cursor
3669 positioning on the newline at EOL of R2L text within L2R
3670 paragraph, and vice versa.
3671 (try_cursor_movement): Check continued rows, in addition to
3672 continuation rows. Fixes unwarranted scroll when point enters a
3673 continued line of R2L text within an L2R paragraph, or vice versa.
3674 (cursor_row_p): Consider the case of point being equal to
3675 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3676 from the end of a short line to the beginning of a continued line
3677 of R2L text within L2R paragraph.
3678 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3679 composed characters.
3681 * bidi.c (bidi_check_type): Use xassert.
3682 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3685 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3687 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3690 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3692 * nsfont.m (ns_otf_to_script): Fix typo.
3694 2011-08-22 Kenichi Handa <handa@m17n.org>
3696 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3697 extra slot even if the purpose is char-code-property-table.
3699 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3701 * xdisp.c (redisplay_window): When computing centering_position,
3702 account for the height of the header line. (Bug#8874)
3704 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3705 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3706 candidate is selected by the mouse, and that candidate has a
3707 composed character under the mouse.
3709 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3710 coordinates reported by pos-visible-in-window-p for a composed
3711 character in column zero.
3713 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3715 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3717 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3720 consider it a hit if to_charpos is anywhere in the range of the
3721 composed buffer positions.
3723 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3725 * image.c (gif_load): Don't assume that each subimage has the same
3726 dimensions as the base image. Handle disposal method that is
3727 "undefined" by the gif spec (Bug#9335).
3729 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3731 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3732 (Fcondition_case): Document `debug' symbol in error handler.
3734 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3736 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3737 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3738 from an Org mode buffer to a Speedbar frame.
3740 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3741 a composition, take its buffer position from IT->cmp_it.charpos.
3742 Fixes cursor positioning at the beginning of a line that begins
3743 with a composed character.
3745 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3747 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3748 character bidirectional type, use STRONG_L instead. Fixes crashes
3749 in a buffer produced by `describe-categories'.
3751 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3752 members before the level stack, so they would be saved and
3753 restored when copying iterator state. Fixes incorrect reordering
3754 around TABs covered by display properties.
3756 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3758 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3760 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3762 * eval.c (internal_condition_case, internal_condition_case_1)
3763 (internal_condition_case_2, internal_condition_case_n):
3764 Remove unnecessary aborts (Bug#9081).
3766 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3768 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3769 has no `load' handler, try opening the file locally. (Bug#9311)
3771 2011-08-16 Ken Brown <kbrown@cornell.edu>
3773 * gmalloc.c: Expand comment.
3775 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3777 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3778 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3780 2011-08-16 Ken Brown <kbrown@cornell.edu>
3782 Fix memory allocation problems in Cygwin build (Bug#9273).
3784 * unexcw.c ( __malloc_initialized): Declare external variable.
3785 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3787 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3789 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3791 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3793 [CYGWIN] (special_realloc): New function.
3794 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3795 requests to realloc storage in the static heap.
3797 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3799 * bidi.c (bidi_initialize): Remove unused local.
3801 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3804 * biditype.h: Remove file.
3805 * makefile.w32-in ($(BLD)/bidi.$(O)):
3806 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3808 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3810 * chartab.c: Improve commentary for the uniprop_table API.
3812 * bidi.c (bidi_paragraph_init): Support zero value of
3813 bidi_ignore_explicit_marks_for_paragraph_level.
3814 (bidi_initialize): Use uniprop_table instead of including
3815 biditype.h and bidimirror.h.
3817 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3818 coordinates of the iterator when restoring from ppos_it.
3821 2011-08-14 Kenichi Handa <handa@m17n.org>
3823 * process.c (create_process): Call setup_process_coding_systems
3824 after the pid of the process is set to -1 (Bug#8162).
3826 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3828 * xdisp.c (move_it_in_display_line_to): Don't invoke
3829 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3830 ppos_it. Fixes vertical cursor motion when line beginning is
3831 covered by an image. (Bug#9296)
3833 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3835 * nsterm.h (ns_run_ascript): Declare.
3836 (NSAPP_DATA2_RUNASSCRIPT): Define.
3838 * nsfns.m (as_script, as_result, as_status): New static variables.
3839 (ns_run_ascript): New function.
3840 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3841 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3842 the event loop. Get status from as_status (Bug#7276).
3844 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3845 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3846 the event loop (Bug#7276).
3848 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3850 * gnutls.c (QCgnutls_bootprop_priority)
3851 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3852 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3853 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3854 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3855 (QCgnutls_bootprop_verify_hostname_error)
3856 (QCgnutls_bootprop_callbacks_verify): Rename from
3857 Qgnutls_bootprop_..., all uses changed.
3859 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3862 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3864 * xfaces.c (Qframe_set_background_mode): Now static.
3865 * dispextern.h (Qframe_set_background_mode): Remove decl.
3867 * process.c (Fnetwork_interface_info): Declare local only if needed.
3869 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3871 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3872 (Fnetwork_interface_list): Allocate in increments of bytes instead
3873 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3874 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3876 (struct ifflag_def): notrailers is smart on OSX.
3877 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3878 Get hardware address with getifaddrs if available.
3880 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3882 * xdisp.c (iterate_out_of_display_property): xassert that
3883 IT->position is set to within IT->object's boundaries. Break from
3884 the loop as soon as EOB is reached; avoids infloops in redisplay
3885 when IT->position is set up wrongly due to some bug.
3886 Set IT->current to match the bidi iterator unconditionally.
3887 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3888 entry. Force push_it to save on the stack the current
3889 buffer/string position, to be restored by pop_it. Fix flags in
3890 the iterator structure wrt the object coming from a display
3891 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3892 properties. (Bug#9284)
3894 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3896 * fontset.c (fontset_get_font_group): Add proper type checks.
3899 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3901 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3902 and LC_VERSION_MIN_MACOSX.
3903 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3904 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3906 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3908 * xdisp.c (forward_to_next_line_start): Allow to use the
3909 no-display-properties-and-no-overlays under bidi display.
3910 Set disp_pos in the bidi iterator to avoid searches for display
3911 properties and overlays.
3913 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3915 * editfns.c (Fset_time_zone_rule): Document relationship with the
3918 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3919 the font entity extracted from the cache (Bug#8109).
3921 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3923 * composite.c (autocmp_chars): Don't reset point. That is done by
3924 restore_point_unwind (Bug#5984).
3926 2011-08-07 Juri Linkov <juri@jurta.org>
3928 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3929 to show the arg `TIME' instead of `TIMEVAL'.
3931 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3933 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3934 display property strides EOL and includes a newline, as in
3935 longlines-mode. (Bug#9254)
3936 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3937 word-wrap under bidirectional display. (Bug#9224)
3939 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3940 is non-zero, even if the data buffer is NULL. Fixes a crash in
3941 vertical-motion with longlines-mode. (Bug#9254)
3943 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3945 * bidi.c <bidi_cache_total_alloc>: Now static.
3946 (bidi_initialize): Initialize bidi_cache_total_alloc.
3948 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3951 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3952 amount allocated this far in `bidi_cache_total_alloc'.
3953 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3954 non-zero, only free the data buffer without restoring the cache
3955 contents. All callers changed.
3957 * dispextern.h (bidi_unshelve_cache): Update prototype.
3959 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3960 (move_it_in_display_line, move_it_to)
3961 (move_it_vertically_backward, move_it_by_lines): Replace the call
3962 to xfree to an equivalent call to bidi_unshelve_cache.
3963 (move_it_in_display_line_to): Fix logic of returning
3964 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3966 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3968 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3969 came from a string character with a `cursor' property. (Bug#9229)
3971 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3973 * Makefile.in (LIB_PTHREAD): New variable.
3974 (LIBES): Add LIB_PTHREAD (Bug#9216).
3976 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3977 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3979 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3981 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3983 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3985 * xterm.c (x_find_topmost_parent): New function.
3986 (x_set_frame_alpha): Find topmost parent window with
3987 x_find_topmost_parent and set the property there also (bug#9181).
3988 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3990 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3992 * callproc.c (Fcall_process): Avoid vfork clobbering
3993 the local vars buffer, coding_systems, current_dir.
3995 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3997 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3999 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4001 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4002 so that it is not optimized away.
4004 * xdisp.c (compute_display_string_pos): Remove unused local.
4006 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4008 Fix slow cursor motion and scrolling in large buffers with
4009 selective display, like Org Mode buffers. (Bug#9218)
4011 * dispextern.h (struct bidi_it): New member disp_prop_p.
4013 * xdisp.c: Remove one-slot cache of display string positions.
4014 (compute_display_string_pos): Accept an additional argument
4015 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4016 for a display string or property. If found, set DISP_PROP_P
4019 * bidi.c (bidi_fetch_char): Accept an additional argument
4020 DISP_PROP_P, and pass it to compute_display_string_pos.
4021 Only handle text covered by a display string if DISP_PROP_P is returned
4022 non-zero. All callers of bidi_fetch_char changed.
4024 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4026 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4028 2010-12-03 Don March <don@ohspite.net>
4030 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4031 last character M-[char] is translated to ESC [char] (bug#7541).
4033 2011-08-02 Kenichi Handa <handa@m17n.org>
4035 * lisp.h (uniprop_table): Extern it.
4037 * chartab.c (uniprop_table): Make it non-static.
4039 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4041 * xdisp.c (forward_to_next_line_start): Accept additional argument
4042 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4044 (reseat_at_next_visible_line_start): Use the bidi iterator state
4045 returned by forward_to_next_line_start to restore the state of
4046 it->bidi_it after backing up to previous newline. (Bug#9212)
4048 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4050 * regex.c (re_comp): Protoize.
4051 (re_exec): Fix return type.
4052 (regexec): Fix type of `ret'. (Bug#9203)
4054 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4056 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4057 This is needed if max-image-size is a floating-point number.
4059 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4061 * print.c (print_object): Print empty symbol as ##.
4063 * lread.c (read1): Read ## as empty symbol.
4065 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4067 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4068 setting frame foreground color (Bug#9175).
4069 (x_set_background_color): Likewise.
4071 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4072 contents (Bug#9176).
4073 (EmacsTooltip -init): Remove bezels and add shadows to
4076 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4077 or scroll bar (Bug#8470).
4079 * nsfont.m (nsfont_open): Remove assignment to voffset and
4080 unnecessary vars hshink, expand, hd, full_height, min_height.
4081 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4083 * nsterm.h (nsfont_info): Remove voffset field.
4085 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4087 Implement strike-through and overline on NextStep (Bug#8863).
4089 * nsfont.m (nsfont_open): Use underline position provided by font,
4090 instead of hard-coded value of 2.
4091 (nsfont_draw): Call ns_draw_text_decoration instead.
4093 * nsterm.h: Add declaration for ns_draw_text_decoration.
4095 * nsterm.m (ns_draw_text_decoration): New function for drawing
4096 underline, overline, and strike-through.
4097 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4098 ns_draw_text_decoration. Change treatment of cursor drawing to
4099 accommodate underlining, etc.
4101 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4103 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4106 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4108 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4109 Without this fix, if a signal arrives just after memory fills up,
4110 'malloc' might be invoked reentrantly.
4112 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4113 In other words, assume that every image size is allowed, on non-X
4114 hosts. This assumption is probably wrong, but it lets Emacs compile.
4116 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4118 * regex.c (re_iswctype): Convert return values to boolean.
4120 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4122 * xdisp.c (compute_display_string_pos): Don't use cached display
4123 string position if the buffer had its restriction changed.
4126 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4128 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4130 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4132 Integer signedness and overflow and related fixes. (Bug#9079)
4134 * bidi.c: Integer size and overflow fixes.
4135 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4136 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4137 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4138 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4139 (bidi_find_other_level_edge):
4140 Use ptrdiff_t instead of EMACS_INT where either will do.
4141 This works better on 32-bit hosts configured --with-wide-int.
4142 (bidi_cache_ensure_space): Check for size-calculation overflow.
4143 Use % rather than repeated addition, for better worst-case speed.
4144 Don't set bidi_cache_size until after xrealloc returns, because it
4146 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4147 (bidi_cache_ensure_space): Also check that the bidi cache size
4148 does not exceed that of the largest Lisp string or buffer. See Eli
4149 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4151 * alloc.c (__malloc_size_t): Remove.
4152 All uses replaced by size_t. See Andreas Schwab's note
4153 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4155 * image.c: Improve checking for integer overflow.
4156 (check_image_size): Assume that f is nonnull, since
4157 it is always nonnull in practice. This is one less thing to
4158 worry about when checking for integer overflow later.
4159 (x_check_image_size): New function, which checks for integer
4160 overflow issues inside X.
4161 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4162 This removes the need for a memory_full check.
4163 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4164 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4165 (xbm_read_bitmap_data): Change locals back to 'int', since
4166 their values must fit in 'int'.
4167 (xpm_load_image, png_load, tiff_load):
4168 Invoke x_create_x_image_and_pixmap earlier,
4169 to avoid much needless work if the image is too large.
4170 (tiff_load): Treat overly large images as if
4171 x_create_x_image_and_pixmap failed, not as malloc failures.
4172 (gs_load): Use x_check_image_size.
4174 * gtkutil.c: Omit integer casts.
4175 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4176 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4178 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4180 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4181 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4182 would wrongly return t on a 64-bit host.
4184 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4185 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4186 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4187 and therefore cause GCC to emit a bogus diagnostic in some cases.
4189 * image.c: Integer signedness and overflow and related fixes.
4190 This is not an exhaustive set of fixes, but it's time to
4191 record what I've got.
4192 (lookup_pixel_color, check_image_size): Remove redundant decls.
4193 (check_image_size): Don't assume that arbitrary EMACS_INT values
4194 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4195 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4196 (tiff_load, imagemagick_load_image):
4197 Check for overflow in size calculations.
4198 (x_create_x_image_and_pixmap): Remove unnecessary test for
4199 xmalloc returning NULL; that can't happen.
4200 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4201 (xpm_color_bucket): Use better integer hashing function.
4202 (xpm_cache_color): Don't possibly over-allocate memory.
4203 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4204 (gif_memory_source):
4205 Use ptrdiff_t, not int or size_t, to record sizes.
4206 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4207 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4208 either works, as we prefer signed integers.
4209 (tiff_read_from_memory, tiff_write_from_memory):
4210 Return tsize_t, not size_t, since that's what the TIFF API wants.
4211 (tiff_read_from_memory): Don't fail simply because the read would
4212 go past EOF; instead, return a short read.
4213 (tiff_load): Omit no-longer-needed casts.
4214 (Fimagemagick_types): Don't assume size fits into 'int'.
4216 Improve hashing quality when configured --with-wide-int.
4217 * fns.c (hash_string): New function, taken from sxhash_string.
4218 Do not discard information about ASCII character case; this
4219 discarding is no longer needed.
4220 (sxhash-string): Use it. Change sig to match it. Caller changed.
4221 * lisp.h: Declare it.
4222 * lread.c (hash_string): Remove, since we now use fns.c's version.
4223 The fns.c version returns a wider integer if --with-wide-int is
4224 specified, so this should help the quality of the hashing a bit.
4226 * emacs.c: Integer overflow minor fix.
4227 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4228 Define only if GNU_LINUX.
4229 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4231 * dispnew.c: Integer signedness and overflow fixes.
4232 Remove unnecessary forward decls, that were a maintenance hassle.
4233 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4235 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4236 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4237 (prepare_desired_row, line_draw_cost):
4238 Use int, not unsigned, where either works.
4239 (save_current_matrix, restore_current_matrix):
4240 Use ptrdiff_t, not size_t, where either works.
4241 (init_display): Check for overflow more accurately, and without
4242 relying on undefined behavior.
4244 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4245 Remove, replacing with the new symbols in lisp.h. All uses changed.
4246 * fileio.c (make_temp_name):
4247 * filelock.c (lock_file_1, lock_file):
4248 * xdisp.c (message_dolog):
4249 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4250 Use pMd etc. instead.
4251 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4252 replacing the pWIDE etc. symbols removed from editfns.c.
4254 * keyboard.h (num_input_events): Now uintmax_t.
4255 This is (very slightly) less likely to mess up due to wraparound.
4258 * buffer.c: Integer signedness fixes.
4259 (alloc_buffer_text, enlarge_buffer_text):
4260 Use ptrdiff_t rather than size_t when either will do, as we prefer
4263 * alloc.c: Integer signedness and overflow fixes.
4264 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4265 (__malloc_size_t): Default to size_t, not to int.
4266 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4267 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4268 Prefer ptrdiff_t to size_t when either would do, as we prefer
4270 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4271 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4272 Now const. Initialize with values that are in range even if char
4274 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4275 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4276 These functions do the right thing with sizes > 2**32.
4277 (check_depth): Now ptrdiff_t, not int.
4278 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4279 Adjust to new way of storing sizes. Check for size overflow bugs
4281 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4282 slightly wrong anyway, as it missed one instance of
4283 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4284 (refill_memory_reserve): Omit needless cast to size_t.
4285 (mark_object_loop_halt): Mark as externally visible.
4287 * xselect.c: Integer signedness and overflow fixes.
4288 (Fx_register_dnd_atom, x_handle_dnd_message):
4289 Use ptrdiff_t, not size_t, since we prefer signed.
4290 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4291 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4292 x_dnd_atoms_size and x_dnd_atoms_length.
4294 * doprnt.c: Prefer signed to unsigned when either works.
4296 * doprnt.c (doprnt):
4298 * xdisp.c (vmessage):
4299 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4300 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4301 prefer signed arithmetic to avoid comparison confusion.
4302 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4303 but is a bit tricky.
4305 Assume freestanding C89 headers, string.h, stdlib.h.
4306 * data.c, doprnt.c, floatfns.c, print.c:
4307 Include float.h unconditionally.
4308 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4309 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4310 * regex.c: Likewise for stddef.h, string.h.
4311 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4312 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4313 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4314 (STDC_HEADERS): Remove obsolete defines.
4315 * sysdep.c: Include limits.h unconditionally.
4317 Assume support for memcmp, memcpy, memmove, memset.
4318 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4319 * regex.c (memcmp, memcpy):
4320 Remove; we assume C89 now.
4322 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4323 (__malloc_safe_bcopy): Remove; no longer needed.
4325 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4326 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4327 well either way, and we prefer signed to unsigned.
4329 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4331 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4332 closes the connection while we're reading (bug#9182).
4334 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4336 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4337 are specified (Bug#9168).
4339 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4341 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4342 Found by GCC static checking and --with-wide-int on a 32-bit host.
4344 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4346 * xdisp.c (compute_display_string_pos): Fix logic of caching
4347 previous display string position. Initialize cached_prev_pos to
4348 -1. Fixes slow-down at the beginning of a buffer.
4350 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4352 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4353 for attrs[LFACE_FONTSET_INDEX].
4355 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4357 * xml.c (parse_region): Remove unused local
4358 that was recently introduced.
4360 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4362 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4363 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4365 * xdisp.c (move_it_in_display_line_to): Record the best matching
4366 position for TO_CHARPOS while scanning the line, and restore it on
4367 exit if none of the characters scanned was an exact match.
4368 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4369 when exact match is impossible due to invisible text, and the
4370 lines are truncated.
4372 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4374 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4377 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4379 Fix a significant slow-down of cursor motion with C-n, C-p,
4380 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4381 auto-repeat under bidi redisplay in fontified buffers.
4382 * xdisp.c (compute_stop_pos_backwards): New function.
4383 (next_element_from_buffer): Call compute_stop_pos_backwards to
4384 find a suitable prev_stop when we find ourselves before
4386 (reseat): Don't look for prev_stop, as that could mean a very long
4388 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4389 <cached_disp_overlay_modiff>: Cache for last found display string
4391 (compute_display_string_pos): Return the cached position if asked
4392 about the same buffer in the same area of character positions, and
4393 the buffer wasn't changed since the time the display string
4394 position was cached.
4396 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4398 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4399 is an integer, which is important for empty lines. (Bug#9149)
4401 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4403 * frame.c (Fmodify_frame_parameters): In tty case, update the
4404 default face if necessary (Bug#4238).
4406 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4408 * editfns.c (Fstring_to_char): No need to explain what a character
4409 is in the docstring (Bug#6576).
4411 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4413 * xml.c (parse_region): Make sure we always return a tree.
4415 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4417 * xml.c (parse_region): If a document contains only comments,
4420 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4422 * xml.c (make_dom): Return comments, too.
4424 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4427 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4428 and the surrounding thread.
4429 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4430 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4431 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4433 * s/openbsd.h (BROKEN_SIGIO): Define.
4434 * unexelf.c (unexec) [__OpenBSD__]:
4435 Don't update the .mdebug section of the Alpha COFF symbol table.
4437 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4439 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4442 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4444 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4445 This fixes some race conditions on the permissions of any newly
4448 * alloc.c (valid_pointer_p): Use pipe, not open.
4449 This fixes some permissions issues when debugging.
4451 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4452 If fchown fails to set both uid and gid, try to set just gid,
4453 as that is sometimes allowed. Adjust the file's mode to eliminate
4454 setuid or setgid bits that are inappropriate if fchown fails.
4456 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4458 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4459 to compare Lisp_Objects.
4460 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4461 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4462 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4464 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4466 * lread.c (read_integer): Unread even EOF character.
4467 (read1): Likewise. Properly record start position of symbol.
4469 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4470 symbol character follows.
4472 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4474 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4475 This works around a problem with the previous change to Fcopy_file.
4476 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4477 and without this change, GCC might complain about discarding
4478 fchown's return value.
4480 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4482 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4484 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4486 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4488 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4490 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4491 it's used from the C level.
4493 * process.c: Use the same condition for POLL_FOR_INPUT in both
4494 keyboard.c and process.c (bug#1858).
4496 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4498 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4499 (Fgnutls_boot): Use it.
4501 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4503 * doc.c (Fsubstitute_command_keys): Revert last change.
4505 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4507 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4508 quotes the next character, and doesn't affect other longer
4509 sequences (bug#8935).
4511 * lread.c (syms_of_lread): Clarify that is isn't only
4512 `eval-buffer' and `eval-defun' that's affected by
4513 `lexical-binding' (bug#8460).
4515 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4517 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4518 bidi redisplay when a line includes both an image and is truncated.
4520 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4522 Fix minor problems found by static checking.
4523 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4524 (elsz): Now a signed constant, not a size_t var. We prefer signed
4525 types to unsigned, to avoid integer comparison confusion. Without
4526 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4527 "cannot optimize loop, the loop counter may overflow", a symptom
4529 * indent.c (Fvertical_motion): Mark locals as initialized.
4530 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4532 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4534 * search.c (Fre_search_backward): Mention `case-fold-search' in
4535 all the re_search_* functions (bug#8138).
4537 * keyboard.c (Fopen_dribble_file): Document when the file is
4540 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4542 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4545 Support bidi reordering of display and overlay strings.
4546 * xdisp.c (compute_display_string_pos)
4547 (compute_display_string_end): Accept additional argument STRING.
4548 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4549 (reseat_to_string): Initialize bidi_it->string.s and
4550 bidi_it->string.schars.
4551 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4552 NULL (avoids a crash in bidi_paragraph_init).
4553 Initialize itb.string.lstring.
4554 (init_iterator): Call bidi_init_it only of a valid
4555 buffer position was specified. Initialize paragraph_embedding to
4557 (reseat_to_string): Initialize the bidi iterator.
4558 (display_string): If we need to ignore text properties of
4559 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4560 original value of -1 will not work with bidi.)
4561 (compute_display_string_pos): First arg is now struct
4562 `text_pos *'; all callers changed. Support display properties on
4564 (compute_display_string_end): Support display properties on Lisp
4566 (init_iterator, reseat_1, reseat_to_string): Initialize the
4567 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4568 when iterating on a string not from display properties).
4569 (compute_display_string_pos, compute_display_string_end):
4570 Fix calculation of the object to scan. Fixes an error when using
4572 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4573 base_level_stop; instead, set base_level_stop to BEGV.
4574 Fixes crashes in vertical-motion.
4575 (next_element_from_buffer): Improve commentary for when
4576 the iterator is before prev_stop.
4577 (init_iterator): Initialize bidi_p from the default value of
4578 bidi-display-reordering, not from buffer-local value. Use the
4579 buffer-local value only if initializing for buffer iteration.
4580 (handle_invisible_prop): Support invisible properties on strings
4581 that are being bidi-reordered.
4582 (set_iterator_to_next): Support bidi reordering of C strings and
4584 (next_element_from_string): Support bidi reordering of Lisp
4586 (handle_stop_backwards): Support Lisp strings as well.
4587 (display_string): Support display of R2L glyph rows.
4588 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4589 (init_iterator): Don't initialize it->bidi_p for strings
4591 (reseat_to_string): Initialize it->bidi_p for strings here.
4592 (next_element_from_string, next_element_from_c_string)
4593 (next_element_from_buffer): Add xassert's for correspondence
4594 between IT's object being iterated and it->bidi_it.string
4596 (face_before_or_after_it_pos): Support bidi iteration.
4597 (next_element_from_c_string): Handle the case of the first string
4598 character that is not the first one in the visual order.
4599 (get_visually_first_element): New function, refactored from common
4600 parts of next_element_from_buffer, next_element_from_string, and
4601 next_element_from_c_string.
4602 (tool_bar_lines_needed, redisplay_tool_bar)
4603 (display_menu_bar): Force left-to-right direction. Add a FIXME
4604 comment for making that be controlled by a user option.
4605 (push_it, pop_it): Save and restore the state of the
4606 bidi iterator. Save and restore the bidi_p flag.
4607 (pop_it): Iterate out of display property for string iteration as
4609 (iterate_out_of_display_property): Support iteration over strings.
4610 (handle_single_display_spec): Set up it->bidi_it for iteration
4611 over a display string, and call bidi_init_it.
4612 (handle_single_display_spec, next_overlay_string)
4613 (get_overlay_strings_1, push_display_prop): Set up the bidi
4614 iterator for displaying display or overlay strings.
4615 (forward_to_next_line_start): Don't use the shortcut if
4617 (back_to_previous_visible_line_start): If handle_display_prop
4618 pushed the iterator stack, restore the internal state of the bidi
4619 iterator by calling bidi_pop_it same number of times.
4620 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4621 and we are bidi-iterating, don't decrement the iterator position;
4622 instead, set the first_elt flag in the bidi iterator, to produce
4624 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4625 (push_display_prop): xassert that we are iterating a buffer.
4626 (push_it, pop_it): Save and restore paragraph_embedding member.
4627 (handle_single_display_spec, next_overlay_string)
4628 (get_overlay_strings_1, reseat_1, reseat_to_string)
4629 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4630 correctly. Don't assume unibyte strings are not bidi-reordered.
4631 (compute_display_string_pos)
4632 (compute_display_string_end): Fix handling the case of C string.
4633 (push_it, pop_it): Save and restore from_disp_prop_p.
4634 (handle_single_display_spec, push_display_prop): Set the
4635 from_disp_prop_p flag.
4636 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4637 (pop_it): Call iterate_out_of_display_property only if we are
4638 popping after iteration over a string that came from a display
4639 property. Fix a typo in popping stretch info. Add an assertion
4640 for verifying that the iterator position is in sync with the bidi
4642 (handle_single_display_spec, get_overlay_strings_1)
4643 (push_display_prop): Fix initialization of paragraph direction for
4644 string when that of the parent object is not yet determined.
4645 (reseat_1): Call bidi_init_it to resync the bidi
4646 iterator with IT's position. (Bug#7616)
4647 (find_row_edges): If ROW->start.pos gives position
4648 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4649 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4650 Reset the from_disp_prop_p flag.
4651 (SAVE_IT, RESTORE_IT): New macros.
4652 (pos_visible_p, face_before_or_after_it_pos)
4653 (back_to_previous_visible_line_start)
4654 (move_it_in_display_line_to, move_it_in_display_line)
4655 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4656 (try_scrolling, redisplay_window, display_line): Use them when
4657 saving a temporary copy of the iterator and restoring it back.
4658 (back_to_previous_visible_line_start, reseat_1)
4659 (init_iterator): Empty the bidi cache "stack".
4660 (move_it_in_display_line_to): If iterator ended up at
4661 EOL, but we never saw any buffer positions smaller than
4662 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4663 motion in bidi-reordered lines.
4664 (move_it_in_display_line_to): Record prev_method and prev_pos
4665 immediately before the call to set_iterator_to_next. Fixes cursor
4666 motion in bidi-reordered lines with stretch glyphs and strings
4667 displayed in margins. (Bug#8133) (Bug#8867)
4668 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4670 (pos_visible_p): Support positions in bidi-reordered lines.
4671 Save and restore bidi cache.
4673 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4674 (bidi_paragraph_info): Delete unused struct.
4675 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4676 (bidi_cache_start): New variable.
4677 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4679 (bidi_cache_fetch_state, bidi_cache_search)
4680 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4681 (bidi_cache_find, bidi_peek_at_next_level)
4682 (bidi_level_of_next_char, bidi_find_other_level_edge)
4683 (bidi_move_to_visually_next): Compare cache index with
4684 bidi_cache_start rather than with zero.
4685 (bidi_fetch_char): Accept new argument STRING; all callers
4686 changed. Support iteration over a string. Support strings with
4687 display properties. Support unibyte strings. Fix the type of
4688 `len' according to what STRING_CHAR_AND_LENGTH expects.
4689 (bidi_paragraph_init, bidi_resolve_explicit_1)
4690 (bidi_resolve_explicit, bidi_resolve_weak)
4691 (bidi_level_of_next_char, bidi_move_to_visually_next):
4692 Support iteration over a string.
4693 (bidi_set_sor_type, bidi_resolve_explicit_1)
4694 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4695 can now be zero (for strings); special values 0 and -1 were
4696 changed to -1 and -2, respectively.
4697 (bidi_char_at_pos): New function.
4698 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4699 Call it instead of FETCH_MULTIBYTE_CHAR.
4700 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4701 initialized to valid values.
4702 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4704 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4705 the test for valid cached positions. Fix the logic for looking up
4706 the sentinel state in the cache. GCPRO the Lisp string we are
4708 (bidi_push_it, bidi_pop_it): New functions.
4709 (bidi_initialize): Initialize the bidi cache start stack pointer.
4710 (bidi_cache_ensure_space): New function, refactored from part of
4711 bidi_cache_iterator_state. Don't assume the required size is just
4712 one BIDI_CACHE_CHUNK away.
4713 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4714 (bidi_count_bytes, bidi_char_at_pos): New functions.
4715 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4716 always valid if bidi_cache_idx is valid.
4717 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4718 is valid if it's going to be used.
4719 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4720 (bidi_cache_fetch_state, bidi_cache_search)
4721 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4722 (bidi_cache_iterator_state, bidi_cache_find)
4723 (bidi_find_other_level_edge, bidi_cache_start_stack):
4724 All variables related to cache indices are now EMACS_INT.
4726 * dispextern.h (struct bidi_string_data): New structure.
4727 (struct bidi_it): New member `string'. Make flag members be 1-bit
4728 fields, and put them last in the struct.
4729 (compute_display_string_pos, compute_display_string_end):
4731 (bidi_push_it, bidi_pop_it): Add prototypes.
4732 (struct iterator_stack_entry): New members bidi_p,
4733 paragraph_embedding, and from_disp_prop_p.
4734 (struct it): Member bidi_p is now a bit field 1 bit wide.
4735 (bidi_shelve_cache, bidi_unshelve_cache):
4738 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4739 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4740 and vector-like objects.
4742 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4743 cache around display iteration.
4745 * window.c (Fwindow_end, window_scroll_pixel_based)
4746 (displayed_window_lines, Frecenter): Save and restore the bidi
4747 cache around display iteration.
4749 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4751 * editfns.c (Fdelete_region): Clarify the use of the named
4752 parameters (bug#6788).
4754 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4756 * indent.c (Fvertical_motion): Set and restore w->pointm when
4757 saving and restoring the window's buffer (Bug#9006).
4759 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4761 * editfns.c (Fstring_to_char): Clarify just what is returned
4762 (bug#6576). Text by Eli Zaretskii.
4764 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4766 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4768 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4770 * buffer.c (mmap_find): Fix a typo.
4772 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4774 Fix execution of x selection hooks.
4775 * xselect.c (Qx_lost_selection_functions)
4776 (Qx_sent_selection_functions): New vars.
4777 (syms_of_xselect): DEFSYM them.
4778 (x_handle_selection_request): Pass Qx_sent_selection_functions
4779 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4780 (x_handle_selection_clear,x_clear_frame_selections):
4781 Pass Qx_lost_selection_functions rather than
4782 Vx_lost_selection_functions to Frun_hook_with_args.
4784 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4786 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4787 The old code sometimes used this field without initializing it.
4789 * alloc.c (gc_sweep): Don't read past end of array.
4790 In theory, the old code could also have corrupted Emacs internals,
4791 though it'd be very unlikely.
4793 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4795 * character.c (Fcharacterp): Don't advertise optional ignored
4796 argument. (Bug#4026)
4798 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4800 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4803 * window.c (Fset_window_start): Doc fix (bug#4199).
4804 (Fset_window_hscroll): Ditto.
4806 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4808 Fix minor new problems caught by GCC 4.6.1.
4809 * term.c (init_tty): Remove unused local.
4810 * xsettings.c (store_monospaced_changed): Define this function only
4811 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4814 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4816 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4818 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4820 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4821 are the mini-buffer and the echo area (bug#3320).
4823 * term.c (init_tty): Remove support for supdup, c10 and perq
4824 terminals, which are no longer supported (bug#1482).
4826 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4828 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4830 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4832 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4833 for non-popups (Bug#3642).
4835 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4837 * alloc.c (reset_malloc_hooks): Protoize.
4838 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4839 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4840 * cm.c (losecursor): Likewise.
4841 * data.c (fmod): Likewise.
4842 * dispnew.c (swap_glyphs_in_rows): Likewise.
4843 * emacs.c (memory_warning_signal): Likewise.
4844 * floatfns.c (float_error): Likewise.
4845 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4846 (otf_open, font_otf_capability, generate_otf_features)
4847 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4849 * image.c (pbm_read_file): Likewise.
4850 * indent.c (string_display_width): Likewise.
4851 * intervals.c (check_for_interval, search_for_interval)
4852 (inc_interval_count, count_intervals, root_interval)
4853 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4854 * lread.c (defalias): Likewise.
4855 * ralloc.c (r_alloc_check): Likewise.
4856 * regex.c (set_image_of_range_1, set_image_of_range)
4857 (regex_grow_registers): Likewise.
4858 * sysdep.c (strerror): Likewise.
4859 * termcap.c (valid_filename_p, tprint, main): Likewise.
4860 * tparam.c (main): Likewise.
4861 * unexhp9k800.c (run_time_remap, save_data_space)
4862 (update_file_ptrs, read_header, write_header, calculate_checksum)
4863 (copy_file, copy_rest, display_header): Likewise.
4864 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4866 * xdisp.c (check_it): Likewise.
4867 * xfaces.c (register_color, unregister_color, unregister_colors):
4869 * xfns.c (print_fontset_result): Likewise.
4870 * xrdb.c (member, fatal, main): Likewise.
4872 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4874 Fix minor problems found by static checking (Bug#9031).
4875 * chartab.c (char_table_set_range, map_sub_char_table):
4876 Remove unused locals.
4877 (uniprop_table): Now static.
4878 * composite.c (_work_char): Remove unused static var.
4880 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4882 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4884 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4886 * gtkutil.c (qttip_cb): Remove code without function.
4888 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4890 * w32.c (pthread_sigmask): New stub.
4892 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4894 Use pthread_sigmask, not sigprocmask (Bug#9010).
4895 sigprocmask is portable only for single-threaded applications, and
4896 Emacs can be multi-threaded when it uses GTK.
4897 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4899 * callproc.c (Fcall_process):
4900 * process.c (create_process):
4901 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4902 Use pthread_sigmask, not sigprocmask.
4904 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4906 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4907 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4910 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4912 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4913 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4914 (xg_hide_tooltip): Fix comment.
4916 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4917 in registerServicesMenuSendTypes.
4918 (validRequestorForSendType): Don't check ns_return_types.
4920 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4923 2011-07-08 Jason Rumney <jasonr@gnu.org>
4925 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4926 SH_SHOW for hidden windows (Bug#5482).
4928 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4929 frame struct members of non-existent frames (Bug#6284).
4931 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4933 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4934 variable firstTime not needed on OSX >= 10.6.
4935 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4936 >= 10.5. Use setKnobProportion, setDoubleValue.
4938 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4939 (MAC_OS_X_VERSION_10_5): Define if not defined.
4940 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4941 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4942 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4944 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4945 cString and lossyCString on OSX >= 10.4
4947 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4948 sizeToFit on OSX >= 10.2.
4950 * nsimage.m (allocInitFromFile): Don't use deprecated method
4951 bestRepresentationForDevice on OSX >= 10.6.
4953 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4956 * emacs.c: Declare unexec_init_emacs_zone.
4958 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4960 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4962 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4963 on svcsMenu (Bug#8842).
4965 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4967 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4969 * nsterm.m (QUTF8_STRING): Declare.
4970 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4971 (validRequestorForSendType): Return type is (id).
4972 Change indexOfObjectIdenticalTo to indexOfObject.
4973 Check if we have local selection before returning self (Bug#8842).
4974 (writeSelectionToPasteboard): Put local selection into paste board
4975 if we have a local selection (Bug#8842).
4976 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4978 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4979 (ns_get_local_selection): Declare.
4981 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4983 * keymap.c (describe_map_tree): Don't insert a double newline at
4984 the end of the buffer (bug#1169) and return whether we inserted
4987 * callint.c (Fcall_interactively): Change "reading args" to
4988 "providing args" to try to clarify what it does (bug#1010).
4990 2011-07-07 Kenichi Handa <handa@m17n.org>
4992 * composite.c (composition_compute_stop_pos): Ignore a static
4993 composition starting before CHARPOS (Bug#8915).
4995 * xdisp.c (handle_composition_prop): Likewise.
4997 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4999 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5002 2011-07-07 Kenichi Handa <handa@m17n.org>
5004 * character.h (unicode_category_t): New enum type.
5006 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5007 (Qchar_code_property_table): New variable.
5008 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5009 (UNIPROP_COMPRESSED_FORM_P): New macros.
5010 (char_table_ascii): Uncompress the compressed values.
5011 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5012 Uncompress the compressed values.
5013 (sub_char_table_ref_and_range): Likewise.
5014 (char_table_ref_and_range): Uncompress the compressed values.
5015 (sub_char_table_set): New arg is_uniprop. Callers changed.
5016 Uncompress the compressed values.
5017 (sub_char_table_set_range): Args changed. Callers changed.
5018 (char_table_set_range): Adjuted for the above change.
5019 (map_sub_char_table): Delete args default_val and parent. Add arg
5020 top. Give decoded values to a Lisp function.
5021 (map_char_table): Adjust for the above change. Give decoded
5022 values to a Lisp function. Gcpro more variables.
5023 (uniprop_table_uncompress)
5024 (uniprop_decode_value_run_length): New functions.
5025 (uniprop_decoder, uniprop_decoder_count): New variables.
5026 (uniprop_get_decoder, uniprop_encode_value_character)
5027 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5029 (uniprop_encoder, uniprop_encoder_count): New variables.
5030 (uniprop_get_encoder, uniprop_table)
5031 (Funicode_property_table_internal, Fget_unicode_property_internal)
5032 (Fput_unicode_property_internal): New functions.
5033 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5034 Sunicode_property_table_internal, Sget_unicode_property_internal,
5035 and Sput_unicode_property_internal. Defvar_lisp
5036 char-code-property-alist.
5038 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5039 Vunicode_category_table.
5041 * font.c (font_range): Adjust for the change of
5042 Vunicode_category_table.
5044 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5046 * m/iris4d.h: Remove file, move contents ...
5047 * s/irix6-5.h: ... here.
5049 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5051 Remove unportable assumption about struct layout (Bug#8884).
5052 * alloc.c (mark_buffer):
5053 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5054 (clone_per_buffer_values): Don't assume that
5055 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5056 This isn't true in general, and it's particularly not true
5057 if Emacs is configured with --with-wide-int.
5058 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5059 New macros, used in the buffer.c change.
5061 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5063 * xsettings.c: Use both GConf and GSettings if both are available.
5064 (store_config_changed_event): Add comment.
5065 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5066 (store_tool_bar_style_changed): New functions.
5067 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5068 (struct xsettings): Move font inside HAVE_XFT.
5069 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5070 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5071 Move inside HAVE_XFT.
5072 (something_changed_gsettingsCB): Rename from something_changedCB.
5073 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5075 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5076 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5077 (something_changed_gconfCB): Rename from something_changedCB.
5078 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5079 (parse_settings): Move check for font inside HAVE_XFT.
5080 (read_settings, apply_xft_settings): Add comment.
5081 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5082 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5083 call store_font_name_changed.
5084 (xft_settings_event): Add comment.
5085 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5086 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5087 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5088 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5089 (xsettings_initialize): Call init_gsettings last.
5090 (xsettings_get_system_font, xsettings_get_system_normal_font):
5093 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5095 Random fixes. E.g., (random) never returned negative values.
5096 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5097 subseconds part to the entropy, as that's a bit more random.
5098 Prefer signed to unsigned, since the signedness doesn't matter and
5099 in general we prefer signed. When given a limit, use a
5100 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5101 latter isn't right if USE_2_TAGS_FOR_INTS.
5102 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5103 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5105 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5107 * textprop.c (text_property_stickiness):
5108 Obey Vtext_property_default_nonsticky.
5109 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5110 * w32fns.c (syms_of_w32fns):
5111 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5113 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5115 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5116 This is more efficient than Ffile_directory_p and avoids a minor race.
5118 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5120 * buffer.c (Foverlay_put): Say what the return value is
5123 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5124 is a directory before asking whether to use the file name
5126 (barf_or_query_if_file_exists): Make the "File is a directory"
5127 error be more correct.
5129 * fns.c (Frequire): Remove the mention of the .gz files, since
5130 that's installation-specific, but keep the mention of
5131 `get-load-suffixes'.
5133 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5135 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5136 Report string overflow if the output is too long.
5138 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5140 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5141 (syms_of_gnutls): Remove duplicate DEFSYM for
5142 Qgnutls_bootprop_verify_hostname_error, an error for
5143 Qgnutls_bootprop_verify_error (which is no longer used).
5145 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5146 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5147 Also (re)move comments that are misplaced or no longer relevant.
5149 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5151 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5153 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5155 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5156 and background color parameters if they have been changed.
5158 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5160 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5162 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5164 * xsettings.c (SYSTEM_FONT): Define only when used.
5165 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5167 * keymap.c (access_keymap_1): Now static.
5169 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5171 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5172 leave any prefix arg for the up event (Bug#1586).
5174 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5176 * lread.c (syms_of_lread): Mention single symbols defined by
5177 `defvar' or `defconst' (bug#7154).
5179 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5180 (Frequire): Mention get-load-suffixes.
5182 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5184 * window.h (window): Remove clone_number slot.
5185 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5187 (make_parent_window, make_window, saved_window)
5188 (Fset_window_configuration, save_window_save): Don't deal with
5190 * buffer.c (Qclone_number): Remove declaration.
5191 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5193 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5195 Add multiple inheritance to keymaps.
5196 * keymap.c (Fmake_composed_keymap): New function.
5197 (Fset_keymap_parent): Simplify.
5198 (fix_submap_inheritance): Remove.
5199 (access_keymap_1): New function extracted from access_keymap to handle
5200 embedded parents and handle lists of maps.
5201 (access_keymap): Use it.
5202 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5203 (Fcopy_keymap): Handle embedded parents.
5204 (Fcommand_remapping, define_as_prefix): Simplify.
5205 (Fkey_binding): Simplify.
5206 (syms_of_keymap): Move minibuffer-local-completion-map,
5207 minibuffer-local-filename-completion-map,
5208 minibuffer-local-must-match-map, and
5209 minibuffer-local-filename-must-match-map to Elisp.
5210 (syms_of_keymap): Defsubr make-composed-keymap.
5211 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5212 (parse_menu_item): Trivial simplification.
5214 2011-07-01 Glenn Morris <rgm@gnu.org>
5216 * Makefile.in (SETTINGS_LIBS): Fix typo.
5218 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5220 * coding.c (Fencode_coding_string): Record the last coding system
5221 used, as the function doc string says (bug#8738).
5223 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5225 * xsettings.c (store_monospaced_changed): Take new font as arg and
5226 check for change against current_mono_font.
5227 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5228 (emacs_settings_constructor, emacs_settings_get_property)
5229 (emacs_settings_set_property, emacs_settings_class_init)
5230 (emacs_settings_init, gsettings_obj): Remove.
5231 (something_changedCB): New function for HAVE_GSETTINGS.
5232 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5233 with value as argument.
5234 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5235 g_settings_new (Bug#8967). Do not create gsettings_obj.
5236 Remove calls to g_settings_bind. Connect something_changedCB to
5239 * xgselect.c: Add defined (HAVE_GSETTINGS).
5240 (xgselect_initialize): Ditto.
5242 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5243 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5246 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5248 * eval.c (struct backtrace): Simplify and port the data structure.
5249 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5250 signed bit field, as this assumption is not portable and it makes
5251 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5252 "char debug_on_exit : 1" as this is not portable either; instead,
5253 use the portable "unsigned int debug_on_exit : 1". Remove unused
5254 member evalargs. Remove obsolete comments about cc bombing out.
5256 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5258 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5259 Let HAVE_GSETTINGS override HAVE_GCONF.
5260 (store_monospaced_changed): New function.
5261 (EMACS_SETTINGS): A new type derived from GObject to handle
5262 GSettings notifications.
5263 (emacs_settings_constructor, emacs_settings_get_property)
5264 (emacs_settings_set_property, emacs_settings_class_init):
5266 (gsettings_client, gsettings_obj): New variables.
5267 (GSETTINGS_SCHEMA): New define.
5268 (something_changedCB): Call store_monospaced_changed.
5269 (init_gsettings): New function.
5270 (xsettings_initialize): Call init_gsettings.
5271 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5274 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5277 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5279 * window.c (resize_root_window, grow_mini_window)
5280 (shrink_mini_window): Rename Qresize_root_window to
5281 Qwindow_resize_root_window and Qresize_root_window_vertically to
5282 Qwindow_resize_root_window_vertically.
5284 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5286 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5288 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5290 * makefile.w32-in: Redesign dependencies so they reflect more
5291 clearly which files are directly included by each source file,
5292 and not through other includes.
5294 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5296 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5297 (sort_overlays, overlay_strings): When an overlay's clone number
5298 matches the window's clone number process the overlay even if
5299 the overlay's window property doesn't match the current window.
5301 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5302 (Fwindow_hchild): Rename to Fwindow_left_child.
5303 (Fwindow_next): Rename to Fwindow_next_sibling.
5304 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5305 (resize_window_check): Rename to window_resize_check.
5306 (resize_window_apply): Rename to window_resize_apply.
5307 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5308 (Fdelete_other_windows_internal, resize_frame_windows)
5309 (Fsplit_window_internal, Fdelete_window_internal)
5310 (grow_mini_window, shrink_mini_window)
5311 (Fresize_mini_window_internal): Fix callers accordingly.
5313 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5315 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5316 (emacs_fixed_set_min_size): Remove.
5317 (emacs_fixed_new): Take frame as argument.
5319 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5320 (_EmacsFixedPrivate): Remove minwidth/height.
5321 Add struct frame *f.
5322 (emacs_fixed_init): Initialize priv->f.
5323 (get_parent_class, emacs_fixed_set_min_size): Remove.
5324 (emacs_fixed_new): Set priv->f to argument.
5325 (emacs_fixed_get_preferred_width)
5326 (emacs_fixed_get_preferred_height): Use min_width/height from
5327 frames size_hint to set minimum and natural (Bug#8919).
5328 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5329 and use min_width/height from frames size_hint to set
5330 min_width/height (Bug#8919).
5332 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5333 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5336 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5338 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5339 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5342 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5344 * process.c (wait_reading_process_output): Bypass select if
5345 waiting for a cell while ignoring keyboard input, and input is
5346 pending. Suggested by Jan Djärv (Bug#8869).
5348 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5350 Use gnulib's dup2 module instead of rolling our own.
5351 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5353 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5355 * dispnew.c (scrolling_window): Before scrolling, turn off a
5356 mouse-highlight in the window being scrolled.
5358 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5360 Move DEFSYM to lisp.h and use everywhere.
5362 * character.h (DEFSYM): Move declaration...
5363 * lisp.h (DEFSYM): ...here.
5369 * w32select.c: Don't include character.h.
5371 * alloc.c (syms_of_alloc):
5372 * buffer.c (syms_of_buffer):
5373 * bytecode.c (syms_of_bytecode):
5374 * callint.c (syms_of_callint):
5375 * casefiddle.c (syms_of_casefiddle):
5376 * casetab.c (init_casetab_once):
5377 * category.c (init_category_once, syms_of_category):
5378 * ccl.c (syms_of_ccl):
5379 * cmds.c (syms_of_cmds):
5380 * composite.c (syms_of_composite):
5381 * dbusbind.c (syms_of_dbusbind):
5382 * dired.c (syms_of_dired):
5383 * dispnew.c (syms_of_display):
5384 * doc.c (syms_of_doc):
5385 * editfns.c (syms_of_editfns):
5386 * emacs.c (syms_of_emacs):
5387 * eval.c (syms_of_eval):
5388 * fileio.c (syms_of_fileio):
5389 * fns.c (syms_of_fns):
5390 * frame.c (syms_of_frame):
5391 * fringe.c (syms_of_fringe):
5392 * insdel.c (syms_of_insdel):
5393 * keymap.c (syms_of_keymap):
5394 * lread.c (init_obarray, syms_of_lread):
5395 * macros.c (syms_of_macros):
5396 * msdos.c (syms_of_msdos):
5397 * print.c (syms_of_print):
5398 * process.c (syms_of_process):
5399 * search.c (syms_of_search):
5400 * sound.c (syms_of_sound):
5401 * syntax.c (init_syntax_once, syms_of_syntax):
5402 * terminal.c (syms_of_terminal):
5403 * textprop.c (syms_of_textprop):
5404 * undo.c (syms_of_undo):
5405 * w32.c (globals_of_w32):
5406 * window.c (syms_of_window):
5407 * xdisp.c (syms_of_xdisp):
5408 * xfaces.c (syms_of_xfaces):
5409 * xfns.c (syms_of_xfns):
5410 * xmenu.c (syms_of_xmenu):
5411 * xsettings.c (syms_of_xsettings):
5412 * xterm.c (syms_of_xterm): Use DEFSYM.
5414 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5416 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5418 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5420 Integer and buffer overflow fixes (Bug#8873).
5422 * print.c (printchar, strout): Check for string overflow.
5423 (PRINTPREPARE, printchar, strout):
5424 Don't set size unless allocation succeeds.
5426 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5427 for sizes. Check for string overflow more accurately.
5428 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5430 * macros.c: Integer and buffer overflow fixes.
5431 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5432 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5433 Use ptrdiff_t, not int, for sizes.
5434 Don't increment bufsize until after realloc succeeds.
5435 Check for size-calculation overflow.
5436 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5438 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5440 * lread.c: Integer overflow fixes.
5441 (read_integer): Radix is now EMACS_INT, not int,
5442 to improve quality of diagnostics for out-of-range radices.
5443 Calculate buffer size correctly for out-of-range radices.
5444 (read1): Check for integer overflow in radices, and in
5445 read-circle numbers.
5446 (read_escape): Avoid int overflow.
5447 (Fload, openp, read_buffer_size, read1)
5448 (substitute_object_recurse, read_vector, read_list, map_obarray):
5449 Use ptrdiff_t, not int, for sizes.
5450 (read1): Use EMACS_INT, not int, for sizes.
5451 Check for size overflow.
5453 * image.c (cache_image): Check for size arithmetic overflow.
5455 * lread.c: Integer overflow issues.
5456 (saved_doc_string_size, saved_doc_string_length)
5457 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5458 Now ptrdiff_t, not int.
5459 (read1): Don't assume doc string length fits in int. Check for
5460 out-of-range doc string lengths.
5461 (read_list): Don't assume file position fits in int.
5462 (read_escape): Check for hex character overflow.
5464 2011-06-22 Leo Liu <sdl.web@gmail.com>
5466 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5467 Move to minibuffer.el.
5469 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5471 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5472 The following patches are for when GLYPH_DEBUG && !XASSERT.
5473 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5474 * dispnew.c (flush_stdout):
5475 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5476 Mark as externally visible.
5477 * dispnew.c (check_window_matrix_pointers): Now static.
5478 * dispnew.c (window_to_frame_vpos):
5479 * xfns.c (unwind_create_frame):
5480 * xterm.c (x_check_font): Remove unused local.
5481 * scroll.c (CHECK_BOUNDS):
5482 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5483 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5484 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5485 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5486 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5488 (debug_method_add): Use va_list and vsprintf rather than relying
5489 on undefined behavior with wrong number of arguments.
5490 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5491 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5492 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5493 since we're not interested in debugging glyphs with old libraries.
5494 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5495 GCC 4.6.0's static checking.
5497 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5499 Integer overflow and signedness fixes (Bug#8873).
5500 A few related buffer overrun fixes, too.
5502 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5504 * dispextern.h (struct face.stipple):
5505 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5506 (x_bitmap_mask, x_allocate_bitmap_record)
5507 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5508 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5509 (x_create_bitmap_from_xpm_data):
5510 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5511 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5513 * xfaces.c (load_pixmap):
5514 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5515 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5516 (.bitmaps_last, struct x_output.icon_bitmap):
5517 Use ptrdiff_t, not int, for bitmap indexes.
5518 (x_allocate_bitmap_record): Check for size overflow.
5519 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5521 Use ptrdiff_t, not int, for overlay counts.
5522 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5523 * editfns.c (overlays_around, get_pos_property):
5524 * textprop.c (get_char_property_and_overlay):
5525 * xdisp.c (next_overlay_change, note_mouse_highlight):
5526 * xfaces.c (face_at_buffer_position):
5527 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5528 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5529 (Fnext_overlay_change, Fprevious_overlay_change)
5530 (mouse_face_overlay_overlaps, Foverlays_in):
5531 Use ptrdiff_t, not int, for sizes.
5532 (overlays_at, overlays_in): Check for size-calculation overflow.
5534 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5536 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5537 (x_session_initialize): Do not assume string length fits in int.
5539 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5540 This is unlikely, but can occur if DPI is outlandish.
5542 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5543 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5545 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5546 * xrdb.c (magic_file_p, search_magic_path):
5547 Omit last arg SUFFIX; it was always 0. All callers changed.
5548 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5550 * xfont.c (xfont_match): Avoid need for strlen.
5552 * xfns.c: Don't assume strlen fits in int.
5553 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5555 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5556 not unsigned long, as we prefer signed integers. All callers changed.
5557 Detect integer overflow in repeat count.
5558 (message_dolog): Don't assume print length fits in 39 bytes.
5559 (display_mode_element): Don't assume strlen fits in int.
5561 * termcap.c: Don't assume sizes fit in int and never overflow.
5562 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5563 (gobble_line): Check for size-calculation overflow.
5565 * minibuf.c (Fread_buffer):
5566 * lread.c (intern, intern_c_string):
5567 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5568 Don't assume string length fits in int.
5570 * keyboard.c (parse_tool_bar_item):
5571 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5573 * font.c: Don't assume string length fits in int.
5574 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5575 Use ptrdiff_t, not int.
5576 (font_intern_prop): Don't assume string length fits in int.
5577 Don't assume integer property fits in fixnum.
5578 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5580 * filelock.c: Fix some buffer overrun and integer overflow issues.
5581 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5582 Reformulate so as not to need the command string.
5583 Invoke gzip -cd rather than gunzip, as it's more portable.
5584 (lock_info_type, lock_file_1, lock_file):
5585 Don't assume pid_t and time_t fit in unsigned long.
5586 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5587 (current_lock_owner): Prefer signed type for sizes.
5588 Use memcpy, not strncpy, where memcpy is what is really wanted.
5589 Don't assume (via atoi) that time_t and pid_t fit in int.
5590 Check for time_t and/or pid_t out of range, e.g., via a network share.
5591 Don't alloca where an auto var works fine.
5593 * fileio.c: Fix some integer overflow issues.
5594 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5595 Don't assume string length fits in int.
5596 (directory_file_name): Don't assume string length fits in long.
5597 (make_temp_name): Don't assume pid fits in int, or that its print
5598 length is less than 20.
5600 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5602 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5604 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5606 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5607 We prefer signed integers, even for size calculations.
5609 * emacs.c: Don't assume string length fits in 'int'.
5610 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5611 (main): Don't invoke strlen when not needed.
5613 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5614 (XD_DEBUG_MESSAGE): Don't waste a byte.
5616 * callproc.c (getenv_internal_1, getenv_internal)
5618 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5620 * lread.c (invalid_syntax): Omit length argument.
5621 All uses changed. This doesn't fix a bug, but it simplifies the
5622 code away from its former Hollerith-constant appearance, and it's
5623 one less 'int' to worry about when looking at integer-overflow issues.
5624 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5626 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5627 This didn't break anything, but it didn't help either.
5628 It's confusing to put a bogus integer in a place where the actual
5629 value does not matter.
5630 (LIST_END_P): Remove unused macro and its bogus comment.
5631 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5633 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5634 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5636 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5637 We prefer signed types, and the value cannot exceed the EMACS_INT
5638 range anyway (because otherwise the length would not be representable).
5639 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5640 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5641 This avoids a GCC warning when WIDE_EMACS_INT.
5643 * indent.c (sane_tab_width): New function.
5644 (current_column, scan_for_column, Findent_to, position_indentation)
5645 (compute_motion): Use it. This is just for clarity.
5646 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5648 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5650 * lisp.h (lint_assume): New macro.
5651 * composite.c (composition_gstring_put_cache):
5652 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5654 * editfns.c, insdel.c:
5655 Omit unnecessary forward decls, to simplify future changes.
5657 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5659 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5661 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5662 Use much-faster test for byte-length change.
5663 Don't assume string byte-length fits in 'int'.
5664 Check that character arg fits in 'int'.
5665 (mapcar1): Declare byte as byte, for clarity.
5667 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5669 * fns.c (concat): Catch string overflow earlier.
5670 Do not rely on integer wraparound.
5672 * dispextern.h (struct it.overlay_strings_charpos)
5673 (struct it.selective): Now EMACS_INT, not int.
5674 * xdisp.c (forward_to_next_line_start)
5675 (back_to_previous_visible_line_start)
5676 (reseat_at_next_visible_line_start, next_element_from_buffer):
5677 Don't arbitrarily truncate the value of 'selective' to int.
5679 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5681 * composite.c: Don't truncate sizes to 'int'.
5682 (composition_gstring_p, composition_reseat_it)
5683 (composition_adjust_point): Use EMACS_INT, not int.
5684 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5685 not EMACS_UINT, for indexes.
5687 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5689 * buffer.c: Include <verify.h>.
5690 (struct sortvec.priority, struct sortstr.priority):
5691 Now EMACS_INT, not int.
5692 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5693 (struct sortstr.size, record_overlay_string)
5694 (struct sortstrlist.size, struct sortlist.used):
5695 Don't truncate size to int.
5696 (record_overlay_string): Check for size-calculation overflow.
5697 (init_buffer_once): Check at compile-time, not run-time.
5699 2011-06-22 Jim Meyering <meyering@redhat.com>
5701 Don't leak an XBM-image-sized buffer
5702 * image.c (xbm_load): Free the image buffer after using it.
5704 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5707 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5708 that Sun C diagnosed.
5709 * fns.c (secure_hash): Fix pointer signedness issue.
5710 * intervals.c (static_offset_intervals): New function.
5711 (offset_intervals): Use it.
5713 2011-06-21 Leo Liu <sdl.web@gmail.com>
5716 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5719 * fns.c (secure_hash): Rename from crypto_hash_function and change
5720 the first arg to accept symbols.
5721 (Fsecure_hash): New primitive.
5722 (syms_of_fns): New symbols.
5724 2011-06-20 Deniz Dogan <deniz@dogan.se>
5726 * process.c (Fset_process_buffer): Clarify return value in
5729 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5731 * dispnew.c (add_window_display_history): Use BVAR.
5733 * xdisp.c (debug_method_add): Use BVAR.
5734 (check_window_end, dump_glyph_matrix, dump_glyph)
5735 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5737 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5740 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5741 check till after the cache is created in init_frame_faces.
5743 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5745 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5747 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5749 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5750 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5751 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5753 Improve buffer-overflow checking (Bug#8873).
5754 * fileio.c (Finsert_file_contents):
5755 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5756 Remove the old (too-loose) buffer overflow checks.
5757 They weren't needed, since make_gap checks for buffer overflow.
5758 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5759 The old code merely checked for Emacs fixnum overflow, and relied
5760 on undefined (wraparound) behavior. The new code avoids undefined
5761 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5763 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5764 Tune. Don't use wider integers than needed. Don't use alloca.
5765 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5767 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5769 * insdel.c, lisp.h (buffer_overflow): New function.
5770 (insert_from_buffer_1, replace_range, replace_range_2):
5771 * insdel.c (make_gap_larger):
5772 * editfns.c (Finsert_char):
5773 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5775 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5777 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5779 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5781 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5782 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5784 * fileio.c: Don't assume EMACS_INT fits in off_t.
5785 (emacs_lseek): New static function.
5786 (Finsert_file_contents, Fwrite_region): Use it.
5787 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5789 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5791 * fns.c: Don't overflow int when computing a list length.
5792 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5793 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5794 truncation on 64-bit hosts. Check for QUIT every
5795 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5796 faster and is responsive enough.
5797 (Flength): Report an error instead of overflowing an integer.
5798 (Fsafe_length): Return a float if the value is not representable
5799 as a fixnum. This shouldn't happen except in contrived situations.
5800 (Fnthcdr, Fsort): Don't assume list length fits in int.
5801 (Fcopy_sequence): Don't assume vector length fits in int.
5803 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5804 (header_size, word_size): New constants.
5805 (allocate_vectorlike): Don't check size overflow here.
5806 (allocate_vector): Check it here instead, since this is the only
5807 caller of allocate_vectorlike that could cause overflow.
5808 Check that the new vector's length is representable as a fixnum.
5810 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5811 The previous code was bogus. For example, next_almost_prime (32)
5812 returned 39, which is undesirable as it is a multiple of 3; and
5813 next_almost_prime (24) returned 25, which is a multiple of 5 so
5814 why was the code bothering to check for multiples of 7?
5816 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5818 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5820 Variadic C functions now count arguments with ptrdiff_t.
5821 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5822 Back then I didn't know that the Emacs coding style prefers signed int.
5823 Also, in the meantime I found a few more instances where arguments
5824 were being counted with int, which may truncate counts on 64-bit
5825 machines, or EMACS_INT, which may be unnecessarily wide.
5826 * lisp.h (struct Lisp_Subr.function.aMANY)
5827 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5828 Arg counts are now ptrdiff_t, not size_t.
5829 All variadic functions and their callers changed accordingly.
5830 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5831 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5832 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5833 * callint.c (Fcall_interactively): Check arg count for overflow,
5834 to avoid potential buffer overrun. Use signed char, not 'int',
5835 for 'varies' array, so that we needn't bother to check its size
5836 calculation for overflow.
5837 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5838 * eval.c (apply_lambda):
5839 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5840 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5841 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5843 * callint.c (Fcall_interactively): Don't use index var as event count.
5845 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5846 * mem-limits.h (SIZE): Remove; no longer used.
5848 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5850 Remove unnecessary casts.
5851 * xterm.c (x_term_init):
5852 * xfns.c (x_set_border_pixel):
5853 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5854 These aren't needed now that we assume ANSI C.
5856 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5857 It's more likely to cause problems (due to unsigned overflow)
5860 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5862 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5864 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5866 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5868 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5870 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5872 GLYPH_CODE_FACE returns EMACS_INT, not int.
5873 * dispextern.h (merge_faces):
5874 * xfaces.c (merge_faces):
5875 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5876 Don't assume EMACS_INT fits in int.
5878 * character.h (CHAR_VALID_P): Remove unused parameter.
5879 * fontset.c, lisp.h, xdisp.c: All uses changed.
5881 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5883 * fns.c (concat): Minor tuning based on overflow analysis.
5884 This doesn't fix any bugs. Use int to hold character, instead
5885 of constantly refetching from Emacs object. Use XFASTINT, not
5886 XINT, for value known to be a character. Don't bother comparing
5887 a single byte to 0400, as it's always less.
5889 * floatfns.c (Fexpt):
5890 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5892 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5895 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5897 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5898 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5899 incorrectly succeed when S was a string, because 4294967386 was
5900 truncated before it was used.
5902 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5903 Otherwise, an out-of-range integer could cause undefined behavior
5906 * composite.c: Use int, not EMACS_INT, for characters.
5907 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5908 EMACS_INT, for values that are known to be in character range.
5909 This doesn't fix any bugs but is the usual style inside Emacs and
5910 may generate better code on 32-bit machines.
5912 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5913 This is for reasons similar to the recent CHAR_STRING fix.
5914 * charset.c (Fencode_char): Check that character arg is actually
5915 a character. Pass an int to ENCODE_CHAR.
5916 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5917 wider than 'int', as a compile-time check to prevent future regressions
5920 * character.c (char_string): Remove unnecessary casts.
5922 Make sure a 64-bit char is never passed to CHAR_STRING.
5923 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5924 by silently ignoring the top 32 bits, allowing some values
5925 that were far too large to be valid characters.
5926 * character.h: Include <verify.h>.
5927 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5928 arguments are no wider than unsigned, as a compile-time check
5929 to prevent future regressions in this area.
5931 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5932 (Fsubst_char_in_region):
5934 * xdisp.c (decode_mode_spec_coding):
5935 Adjust to CHAR_STRING's new requirement.
5936 * editfns.c (Finsert_char, Fsubst_char_in_region):
5937 * fns.c (concat): Check that character args are actually
5938 characters. Without this test, these functions did the wrong
5939 thing with wildly out-of-range values on 64-bit hosts.
5941 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5942 These casts should not be needed on 32-bit hosts, either.
5943 * keyboard.c (read_char):
5944 * lread.c (Fload): Remove casts to unsigned.
5946 * lisp.h (UNSIGNED_CMP): New macro.
5947 This fixes comparison bugs on 64-bit hosts.
5948 (ASCII_CHAR_P): Use it.
5949 * casefiddle.c (casify_object):
5950 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5951 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5952 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5953 * dispextern.h (FACE_FROM_ID):
5954 * keyboard.c (read_char): Use UNSIGNED_CMP.
5956 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5957 not to EMACS_INT, to avoid GCC warning.
5959 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5961 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5962 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5963 isn't needed on 32-bit machines.
5965 * buffer.c (Fgenerate_new_buffer_name):
5966 Use EMACS_INT for count, not int.
5967 (advance_to_char_boundary): Return EMACS_INT, not int.
5969 * data.c (Qcompiled_function): Now static.
5971 * window.c (window_body_lines): Now static.
5973 * image.c (gif_load): Rename local to avoid shadowing.
5975 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5976 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5977 * alloc.c (make_save_value): Integer argument is now of type
5979 (mark_object): Use ptrdiff_t, not int.
5980 * lisp.h (pD): New macro.
5981 * print.c (print_object): Use it.
5983 * alloc.c: Use EMACS_INT, not int, to count objects.
5984 (total_conses, total_markers, total_symbols, total_vector_size)
5985 (total_free_conses, total_free_markers, total_free_symbols)
5986 (total_free_floats, total_floats, total_free_intervals)
5987 (total_intervals, total_strings, total_free_strings):
5988 Now EMACS_INT, not int. All uses changed.
5989 (Fgarbage_collect): Compute overall total using a double, so that
5990 integer overflow is less likely to be a problem. Check for overflow
5991 when converting back to an integer.
5992 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5993 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5994 These were 'int' variables that could overflow on 64-bit hosts;
5995 they were never used, so remove them instead of repairing them.
5996 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5997 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5998 Previously, this ceilinged at INT_MAX, but that doesn't work on
6000 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6002 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6003 (allocate_vectorlike): Check for ptrdiff_t overflow.
6004 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6005 when a (possibly-narrower) signed value would do just as well.
6006 We prefer using signed arithmetic, to avoid comparison confusion.
6008 * alloc.c: Catch some string size overflows that we were missing.
6009 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6010 for convenience in STRING_BYTES_MAX.
6011 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6012 The definition here is exact; the one in lisp.h was approximate.
6013 (allocate_string_data): Check for string overflow. This catches
6014 some instances we weren't catching before. Also, it catches
6015 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6016 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6017 and ptrdiff_t and EMACS_INT are both 64 bits.
6019 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6020 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6021 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6023 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6025 * alloc.c (Fmake_string): Check for out-of-range init.
6027 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6029 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6031 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6033 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6034 xg_get_default_scrollbar_width.
6036 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6037 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6038 (style_changed_cb): Call update_theme_scrollbar_width and call
6039 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6040 all frames (Bug#8505).
6041 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6042 Call gtk_window_set_resizable if HAVE_GTK3.
6043 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6044 and height if HAVE_GTK3 (Bug#8505).
6045 (scroll_bar_width_for_theme): New variable.
6046 (update_theme_scrollbar_width): New function.
6047 (xg_get_default_scrollbar_width): Move code to
6048 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6049 (xg_initialize): Call update_theme_scrollbar_width.
6051 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6053 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6055 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6057 * frame.c (make_frame): Call other_buffer_safely instead of
6060 * window.c (temp_output_buffer_show): Call display_buffer with
6061 second argument Vtemp_buffer_show_specifiers and reset latter
6062 immediately after the call.
6063 (Vtemp_buffer_show_specifiers): New variable.
6064 (auto_window_vscroll_p, next_screen_context_lines)
6065 (Vscroll_preserve_screen_position): Remove leading asterisks from
6068 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6070 Fix minor problems found by GCC 4.6.0 static checking.
6071 * buffer.c (Qclone_number): Remove for now, as it's unused.
6072 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6073 (record_buffer): Remove unused local.
6074 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6075 (set_frame_buffer_list): Remove; unused.
6076 * frame.h (other_visible_frames): Remove decl.
6077 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6078 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6079 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6081 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6082 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6083 Define only if HAVE_GPM.
6084 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6085 (update_hints_inhibit): Remove; never set. All uses removed.
6086 * widgetprv.h (emacsFrameClassRec): Remove decl.
6087 * window.c (delete_deletable_window): Now returns void, since it
6088 wasn't returning anything.
6089 (compare_window_configurations): Remove unused locals.
6090 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6091 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6092 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6093 the same widths as pointers. This follows up on the 2011-05-06 patch.
6094 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6095 * xterm.h: Likewise.
6096 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6098 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6100 * makefile.w32-in: Update dependencies.
6101 (LISP_H): Add lib/intprops.h.
6103 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6105 * image.c (gif_load): Add animation frame delay to the metadata.
6106 (syms_of_image): Use DEFSYM. New symbol `delay'.
6108 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6110 * window.c (delete_deletable_window): Re-add.
6111 (Fset_window_configuration): Rewrite to handle dead buffers and
6112 consequently deletable windows.
6113 (window_tree, Fwindow_tree): Remove. Supply functionality in
6115 (compare_window_configurations): Simplify code.
6117 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6119 * image.c (imagemagick_load_image): Fix type mismatch.
6120 (Fimagemagick_types): Likewise.
6122 * window.h (replace_buffer_in_windows): Declare.
6124 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6126 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6127 Qclone_number. Remove external declaration of Qdelete_window.
6128 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6130 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6131 Run Qbuffer_list_update_hook if allowed.
6132 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6133 buffer list implementation.
6134 (other_buffer_safely): New function.
6135 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6136 calls to replace_buffer_in_windows and
6137 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6139 (record_buffer): Inhibit quitting and rewrite using quittable
6140 functions. Run Qbuffer_list_update_hook if allowed.
6141 (Frecord_buffer, Funrecord_buffer): New functions.
6142 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6143 Move switch-to-buffer to window.el.
6144 (bury-buffer): Move to window.el.
6145 (Vbuffer_list_update_hook): New variable.
6147 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6150 * window.h (resize_frame_windows): Move up in code.
6151 (Fwindow_frame): Remove EXFUN.
6152 (replace_buffer_in_all_windows): Remove prototype.
6153 (replace_buffer_in_windows_safely): Add prototype.
6155 * window.c: Declare Qdelete_window static again. Move down
6156 declaration of select_count.
6157 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6158 (Fother_window): Move to window.el.
6159 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6160 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6161 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6163 (replace_buffer_in_windows): Implement by calling
6164 Qreplace_buffer_in_windows.
6165 (replace_buffer_in_all_windows): Remove with some functionality
6166 moved into replace_buffer_in_windows_safely.
6167 (replace_buffer_in_windows_safely): New function.
6168 (select_window_norecord, select_frame_norecord): Move in front
6169 of run_window_configuration_change_hook. Remove now obsolete
6171 (Fset_window_buffer): Rewrite doc-string.
6172 Call Qrecord_window_buffer.
6173 (keys_of_window): Move binding for other-window to window.el.
6175 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6177 * dispextern.h (struct image): Replace data member, whose int_val
6178 and ptr_val fields were not used by anything, with a single
6181 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6182 (gif_clear_image, gif_load, imagemagick_load_image)
6183 (gs_clear_image, gs_load): Callers changed.
6185 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6187 * buffer.h: Include <time.h>, for time_t.
6188 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6190 Fix minor problems found by static checking.
6192 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6194 Make identifiers static if they are not used in other modules.
6195 * data.c (Qcompiled_function, Qframe, Qvector):
6196 * image.c (QimageMagick, Qsvg):
6197 * minibuf.c (Qmetadata):
6198 * window.c (resize_window_check, resize_root_window): Now static.
6199 * window.h (resize_window_check, resize_root_window): Remove decls.
6201 * window.c (window_deletion_count, delete_deletable_window):
6203 (window_body_lines): Now static.
6204 (Fdelete_other_windows_internal): Mark vars as initialized.
6205 Make sure 'resize_failed' is initialized.
6206 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6207 (resize_window_apply): Remove unused local.
6208 * window.h (delete_deletable_window): Remove decl.
6210 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6211 (imagemagick_load_image): Fix pointer signedness problem by changing
6212 last arg from unsigned char * to char *. All uses changed.
6213 Also, fix a local for similar reasons.
6214 Remove unused locals. Remove locals to avoid shadowing.
6215 (fn_rsvg_handle_free): Remove; unused.
6216 (svg_load, svg_load_image): Fix pointer signedness problem.
6217 (imagemagick_load_image): Don't use garbage pointer image_wand.
6219 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6221 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6223 * image.c (gif_load): Fix omitted cast error introduced by
6226 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6228 * window.h (resize_proportionally, orig_total_lines)
6229 (orig_top_line): Remove from window structure.
6230 (set_window_height, set_window_width, change_window_heights)
6231 (Fdelete_window): Remove prototypes.
6232 (resize_frame_windows): Remove duplicate declaration.
6234 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6236 * window.h (resize_frame_windows, resize_window_check)
6237 (delete_deletable_window, resize_root_window)
6238 (resize_frame_windows): Declare prototypes.
6240 * window.c (resize_window_apply): Make definition be "static" to
6241 match the prototype.
6243 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6245 * window.c: Remove declarations of Qwindow_size_fixed,
6246 window_min_size_1, window_min_size_2, window_min_size,
6247 size_window, window_fixed_size_p, enlarge_window, delete_window.
6248 Remove static from declaration of Qdelete_window, it's
6249 temporarily needed by Fbury_buffer.
6250 (replace_window): Don't assign orig_top_line and
6252 (Fdelete_window, delete_window): Remove. Window deletion is
6253 handled by window.el.
6254 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6255 Replace Fdelete_window calls with calls to Qdelete_window.
6256 (Fdelete_other_windows): Remove. Deleting other windows is
6257 handled by window.el.
6258 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6259 handled in window.el.
6260 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6261 Window minimum sizes are handled in window.el.
6262 (shrink_windows, size_window, set_window_height)
6263 (set_window_width, change_window_heights, window_height)
6264 (window_width, CURBEG, CURSIZE, enlarge_window)
6265 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6266 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6267 handled in window.el.
6268 (make_dummy_parent): Rename to make_parent_window and give it a
6269 second argument horflag.
6270 (make_window): Don't set resize_proportionally any more.
6271 (Fsplit_window): Remove. Windows are split in window.el.
6272 (save_restore_action, save_restore_orig_size)
6273 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6274 Resize mini windows in window.el.
6275 (grow_mini_window, shrink_mini_window): Implement by calling
6276 Qresize_root_window_vertically, resize_window_check and
6277 resize_window_apply.
6278 (saved_window, Fset_window_configuration, save_window_save):
6279 Do not handle orig_top_line, orig_total_lines, and
6280 resize_proportionally.
6281 (window_min_height, window_min_width): Move to window.el.
6282 (keys_of_window): Move bindings for delete-other-windows,
6283 split-window, delete-window and enlarge-window to window.el.
6285 * buffer.c: Temporarily extern Qdelete_window.
6286 (Fbury_buffer): Temporarily call Qdelete_window instead of
6287 Fdelete_window (Fbury_buffer will move to window.el soon).
6289 * frame.c (set_menu_bar_lines_1): Remove code handling
6290 orig_top_line and orig_total_lines.
6292 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6293 set_window_height but set heights directly.
6294 (change_frame_size_1): Use resize_frame_windows.
6296 * xdisp.c (init_xdisp): Don't use set_window_height but set
6299 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6300 Use resize_frame_windows instead of change_window_heights and run
6301 run_window_configuration_change_hook.
6303 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6304 instead of change_window_heights and run
6305 run_window_configuration_change_hook.
6307 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6309 * window.c (replace_window): Rename second argument REPLACEMENT to
6310 NEW. New third argument SETFLAG. Rewrite.
6311 (delete_window, make_dummy_parent): Call replace_window with
6313 (window_list_1): Move down in code.
6314 (run_window_configuration_change_hook): Move set_buffer part
6315 before select_frame_norecord part in order to unwind correctly.
6316 Rename count1 to count.
6317 (recombine_windows, delete_deletable_window, resize_root_window)
6318 (Fdelete_other_windows_internal)
6319 (Frun_window_configuration_change_hook, make_parent_window)
6320 (resize_window_check, resize_window_apply, Fresize_window_apply)
6321 (resize_frame_windows, Fsplit_window_internal)
6322 (Fdelete_window_internal, Fresize_mini_window_internal):
6324 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6326 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6328 * window.h (window): Add some new members to window structure -
6329 normal_lines, normal_cols, new_total, new_normal, clone_number,
6330 splits, nest, prev_buffers, next_buffers.
6331 (WINDOW_TOTAL_SIZE): Move here from window.c.
6332 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6334 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6336 (make_dummy_parent): Set new members of windows structure.
6337 (make_window): Move down in code. Handle new members of window
6339 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6340 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6341 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6342 (Fset_window_prev_buffers, Fwindow_next_buffers)
6343 (Fset_window_next_buffers, Fset_window_clone_number):
6345 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6346 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6348 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6349 Argument WINDOW can be now internal window too.
6350 (Fwindow_use_time): Move up in code.
6351 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6353 (Fset_window_configuration, saved_window)
6354 (Fcurrent_window_configuration, save_window_save): Handle new
6355 members of window structure.
6356 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6357 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6358 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6359 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6360 Qget_mru_window, Qresize_root_window,
6361 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6362 Qauto_buffer_name; staticpro them.
6364 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6366 * window.c (Fwindow_total_size, Fwindow_left_column)
6367 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6368 (Fwindow_list_1): New functions.
6369 (window_box_text_cols): Replace with window_body_cols.
6370 (Fwindow_width, Fscroll_left, Fscroll_right):
6371 Use window_body_cols instead of window_box_text_cols.
6372 (delete_window, Fset_window_configuration):
6373 Call delete_all_subwindows with window as argument.
6374 (delete_all_subwindows): Take a window as argument and not a
6376 (window_loop): Remove handling of GET_LRU_WINDOW and
6378 (Fget_lru_window, Fget_largest_window): Move to window.el.
6380 * window.h: Extern window_body_cols instead of
6381 window_box_text_cols. delete_all_subwindows now takes a
6382 Lisp_Object as argument.
6384 * indent.c (compute_motion, Fcompute_motion):
6385 Use window_body_cols instead of window_box_text_cols.
6387 * frame.c (delete_frame): Call delete_all_subwindows with root
6390 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6392 * fns.c (Fputhash): Document return value.
6394 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6396 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6398 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6400 Cons<->int and similar integer overflow fixes (Bug#8794).
6402 Check for overflow when converting integer to cons and back.
6403 * charset.c (Fdefine_charset_internal, Fdecode_char):
6404 Use cons_to_unsigned to catch overflow.
6405 (Fencode_char): Use INTEGER_TO_CONS.
6406 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6407 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6408 * data.c (long_to_cons, cons_to_long): Remove.
6409 (cons_to_unsigned, cons_to_signed): New functions.
6410 These signal an error for invalid or out-of-range values.
6411 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6412 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6413 * font.c (Ffont_variation_glyphs):
6414 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6415 * lisp.h: Include <intprops.h>.
6416 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6417 (cons_to_signed, cons_to_unsigned): New decls.
6418 (long_to_cons, cons_to_long): Remove decls.
6419 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6420 (Fprimitive_undo): Use CONS_TO_INTEGER.
6421 * xfns.c (Fx_window_property): Likewise.
6422 * xselect.c: Include <limits.h>.
6423 (x_own_selection, selection_data_to_lisp_data):
6424 Use INTEGER_TO_CONS.
6425 (x_handle_selection_request, x_handle_selection_clear)
6426 (x_get_foreign_selection, Fx_disown_selection_internal)
6427 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6428 (lisp_data_to_selection_data): Use cons_to_unsigned.
6429 (x_fill_property_data): Use cons_to_signed.
6430 Report values out of range.
6432 Check for buffer and string overflow more precisely.
6433 * buffer.h (BUF_BYTES_MAX): New macro.
6434 * lisp.h (STRING_BYTES_MAX): New macro.
6435 * alloc.c (Fmake_string):
6436 * character.c (string_escape_byte8):
6437 * coding.c (coding_alloc_by_realloc):
6438 * doprnt.c (doprnt):
6439 * editfns.c (Fformat):
6441 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6442 since they may not be the same number.
6443 * editfns.c (Finsert_char):
6444 * fileio.c (Finsert_file_contents):
6445 Likewise for BUF_BYTES_MAX.
6447 * image.c: Use ptrdiff_t, not int, for sizes.
6448 (slurp_file): Switch from int to ptrdiff_t.
6450 (slurp_file): Check that file size fits in both size_t (for
6451 malloc) and ptrdiff_t (for sanity and safety).
6453 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6454 if b->modtime has its maximal value.
6456 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6458 Don't assume time_t can fit into int.
6459 * buffer.h (struct buffer.modtime): Now time_t, not int.
6460 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6461 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6463 Minor fixes for signed vs unsigned integers.
6464 * character.h (MAYBE_UNIFY_CHAR):
6465 * charset.c (maybe_unify_char):
6466 * keyboard.c (read_char, reorder_modifiers):
6467 XINT -> XFASTINT, since the integer must be nonnegative.
6468 * ftfont.c (ftfont_spec_pattern):
6469 * keymap.c (access_keymap, silly_event_symbol_error):
6470 XUINT -> XFASTINT, since the integer must be nonnegative.
6471 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6472 since it makes no difference and we prefer signed.
6473 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6474 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6477 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6479 * window.h (Fwindow_frame): Declare.
6481 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6483 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6484 (SPARE_MEMORY): Always define.
6485 (LARGE_REQUEST): Remove.
6486 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6488 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6490 * lisp.h: Move EXFUNS for Fframe_root_window,
6491 Fframe_first_window and Fset_frame_selected_window to window.h.
6493 * window.h: Move EXFUNS for Fframe_root_window,
6494 Fframe_first_window and Fset_frame_selected_window here from
6497 * frame.c (Fwindow_frame, Fframe_first_window)
6498 (Fframe_root_window, Fframe_selected_window)
6499 (Fset_frame_selected_window): Move to window.c.
6500 (Factive_minibuffer_window): Move to minibuf.c.
6501 (Fother_visible_frames_p): New function.
6503 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6505 * window.c (decode_window, decode_any_window): Move up in code.
6506 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6507 (inhibit_frame_unsplittable): Remove unused variable.
6508 (Fwindow_buffer): Move up and rewrite doc-string.
6509 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6510 (Fwindow_prev): New functions.
6511 (Fwindow_frame): Move here from frame.c. Accept any window as
6513 (Fframe_root_window, Fframe_first_window)
6514 (Fframe_selected_window): Move here from frame.c. Accept frame
6515 or arbitrary window as argument. Update doc-strings.
6516 (Fminibuffer_window): Move up in code.
6517 (Fwindow_minibuffer_p): Move up in code and simplify.
6518 (Fset_frame_selected_window): Move here from frame.c.
6520 (Fselected_window, select_window, Fselect_window): Move up in
6521 code. Minor doc-string fixes.
6523 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6525 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6526 Do not assume that spare memory exists; that assumption is valid
6527 only if SYSTEM_MALLOC.
6528 (LARGE_REQUEST): New macro, so that the issue of large requests
6529 is separated from the issue of spare memory.
6531 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6533 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6536 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6538 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6541 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6543 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6545 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6547 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6548 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6550 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6552 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6554 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6556 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6557 (x_clipboard_manager_save): Add return value.
6558 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6560 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6561 Obey Vx_select_enable_clipboard_manager. Catch errors in
6562 x_clipboard_manager_save (Bug#8779).
6563 (Vx_select_enable_clipboard_manager): New variable.
6564 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6566 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6568 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6570 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6572 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6573 in the current matrix if keep_current_p is non-zero.
6575 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6577 * bidi.c (bidi_level_of_next_char): Fix last change.
6579 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6581 Support bidi reordering of text covered by display properties.
6583 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6584 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6585 (bidi_cache_search, bidi_cache_iterator_state)
6586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6587 (bidi_level_of_next_char, bidi_move_to_visually_next):
6588 Support character positions inside a run of characters covered by a
6590 (bidi_paragraph_init, bidi_resolve_explicit_1)
6591 (bidi_level_of_next_char): Call bidi_fetch_char and
6592 bidi_fetch_char_advance instead of FETCH_CHAR and
6594 (bidi_init_it): Initialize new members.
6595 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6597 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6598 instead of using explicit *_CHAR codes.
6599 (bidi_resolve_explicit, bidi_resolve_weak):
6600 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6601 bidirectional text is supported only in multibyte buffers.
6602 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6603 it to initialize the frame_window_p member of struct bidi_it.
6604 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6605 (bidi_resolve_explicit, bidi_resolve_weak)
6606 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6607 bidi_it->nchars is non-positive.
6608 (bidi_level_of_next_char): Don't try to lookup the cache for the
6609 next/previous character if nothing is cached there yet, or if we
6610 were just reseat()'ed to a new position.
6612 * xdisp.c (set_cursor_from_row): Set start and stop points
6613 according to the row's direction when priming the loop that looks
6614 for the glyph on which to display cursor.
6615 (single_display_spec_intangible_p): Function deleted.
6616 (display_prop_intangible_p): Reimplement to call
6617 handle_display_spec instead of single_display_spec_intangible_p.
6618 Accept 3 additional arguments needed by handle_display_spec.
6619 This fixes incorrect cursor motion across display property with complex
6620 values: lists, `(when COND...)' forms, etc.
6621 (single_display_spec_string_p): Support property values that are
6622 lists with the argument STRING its top-level element.
6623 (display_prop_string_p): Fix the condition for processing a
6624 property that is a list to be consistent with handle_display_spec.
6625 (handle_display_spec): New function, refactored from the
6626 last portion of handle_display_prop.
6627 (compute_display_string_pos): Accept additional argument
6628 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6629 value of a `display' property is a "replacing spec".
6630 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6631 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6632 the display property, but just return a value indicating whether
6633 the display property will replace the characters it covers.
6634 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6635 frame_window_p members of struct bidi_it.
6636 (compute_display_string_pos, compute_display_string_end):
6638 (push_it): Accept second argument POSITION, where pop_it should
6639 jump to continue iteration.
6640 (reseat_1): Initialize bidi_it.disp_pos.
6642 * keyboard.c (adjust_point_for_property): Adjust the call to
6643 display_prop_intangible_p to its new signature.
6645 * dispextern.h (struct bidi_it): New member frame_window_p.
6646 (bidi_init_it): Update prototypes.
6647 (display_prop_intangible_p): Update prototype.
6648 (compute_display_string_pos, compute_display_string_end):
6650 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6653 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6655 Malloc failure behavior now depends on size of allocation.
6656 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6657 * lisp.h: Change signatures accordingly.
6658 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6659 All callers changed. (Bug#8762)
6661 * gnutls.c: Use Emacs's memory allocators.
6662 Without this change, the gnutls library would invoke malloc etc.
6663 directly, which causes problems on non-SYNC_INPUT hosts, and which
6664 runs afoul of improving memory_full behavior. (Bug#8761)
6665 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6666 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6667 xfree instead of the default malloc, realloc, free.
6668 (Fgnutls_boot): No need to check for memory allocation failure,
6669 since xmalloc does that for us.
6671 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6672 * category.c (hash_get_category_set):
6673 * ccl.c (ccl_driver):
6674 * charset.c (Fdefine_charset_internal):
6675 * charset.h (struct charset.hash_index):
6676 * composite.c (get_composition_id, gstring_lookup_cache)
6677 (composition_gstring_put_cache):
6678 * composite.h (struct composition.hash_index):
6679 * dispextern.h (struct image.hash):
6680 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6681 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6682 (hashfn_equal, hashfn_user_defined, make_hash_table)
6683 (maybe_resize_hash_table, hash_lookup, hash_put)
6684 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6685 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6686 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6687 * image.c (make_image, search_image_cache, lookup_image)
6688 (xpm_put_color_table_h):
6689 * lisp.h (struct Lisp_Hash_Table):
6690 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6691 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6692 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6693 * alloc.c (allocate_vectorlike):
6694 Check for overflow in vector size calculations.
6695 * ccl.c (ccl_driver):
6696 Check for overflow when converting EMACS_INT to int.
6697 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6698 need to be updated by these changes.
6699 * fns.c (make_hash_table, maybe_resize_hash_table):
6700 Check for integer overflow with large hash tables.
6701 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6702 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6703 (SXHASH_REDUCE): New macro.
6704 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6705 Use it instead of discarding useful hash info with large hash values.
6706 (sxhash_float): New function.
6707 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6708 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6709 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6710 Rewrite to use FIXNUM_BITS, as this simplifies things.
6711 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6712 Adjust signatures to match updated version of code.
6713 (consing_since_gc): Now EMACS_INT, since a single hash table can
6714 use more than INT_MAX bytes.
6716 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6718 Make it possible to build with GCC-4.6+ -O2 -flto.
6720 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6722 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6724 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6725 Call minibuffer-inactive-mode.
6727 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6729 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6730 Update dependencies.
6732 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6734 * data.c (init_data): Remove code for UTS, this system is not
6737 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6739 Don't force ./temacs to start in terminal mode.
6741 * frame.c (make_initial_frame): Initialize faces in all cases, not
6742 only when CANNOT_DUMP is defined.
6743 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6745 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6747 * dispnew.c (add_window_display_history): Use const for the string
6748 pointer. Remove declaration, not needed.
6750 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6752 Use 'inline', not 'INLINE'.
6753 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6754 * alloc.c, fontset.c (INLINE): Remove.
6755 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6756 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6757 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6758 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6759 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6761 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6763 Make it possible to run ./temacs.
6765 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6766 syms_of_callproc does the same thing. Remove test for
6767 "initialized", do it in the caller.
6768 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6770 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6772 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6773 (read_minibuf): Use get_minibuffer.
6774 (syms_of_minibuf): Use DEFSYM.
6775 (Qmetadata): New var.
6776 * data.c (Qbuffer): Don't make it static.
6777 (syms_of_data): Use DEFSYM.
6779 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6781 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6782 (CCL_CODE_MIN): New macro.
6784 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6786 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6788 * eval.c (Qdebug): Now static.
6789 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6790 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6791 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6793 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6795 * image.c: Various fixes to ImageMagick code comments.
6796 (Fimagemagick_types): Doc fix.
6798 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6800 Minor fixes prompted by GCC 4.6.0 warnings.
6802 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6804 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6805 (x_clipboard_manager_save_all): Move extern decl to ...
6806 * xterm.h: ... here, so that it can be checked for consistency.
6808 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6810 * xselect.c (x_clipboard_manager_save_frame)
6811 (x_clipboard_manager_save_all): New functions.
6812 (Fx_clipboard_manager_save): Lisp function deleted.
6814 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6815 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6817 * xterm.h: Update prototype.
6819 2011-05-28 William Xu <william.xwl@gmail.com>
6821 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6824 2011-05-28 Jim Meyering <meyering@redhat.com>
6826 Avoid a sign-extension bug in crypto_hash_function.
6827 * fns.c (to_uchar): Define.
6828 (crypto_hash_function): Use it to convert some newly-signed
6829 variables to unsigned, to avoid sign-extension bugs. For example,
6830 without this change, (md5 "truc") would evaluate to
6831 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6832 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6833 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6835 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6837 Integer overflow fixes.
6839 * dbusbind.c: Serial number integer overflow fixes.
6840 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6841 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6842 to hold a serial number that is too large for a fixnum.
6843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6844 Check for serial numbers out of range. Decode any serial number
6845 that was so large that it became a float. (Bug#8722)
6847 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6848 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6849 Use XFASTINT rather than XUINT when numbers are nonnegative.
6850 (xd_append_arg, Fdbus_method_return_internal):
6851 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6852 arguments, check that Lisp number is nonnegative, rather than
6853 silently wrapping negative numbers around. (Bug#8722)
6854 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6857 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6859 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6861 ccl: Add integer overflow checks.
6862 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6863 (IN_INT_RANGE): New macros.
6864 (ccl_driver): Use them to check for integer overflow when
6865 decoding a CCL program. Many of the new checks are whether XINT (x)
6866 fits in int; it doesn't always, on 64-bit hosts. The new version
6867 doesn't catch all possible integer overflows, but it's an
6868 improvement. (Bug#8719)
6870 * alloc.c (make_event_array): Use XINT, not XUINT.
6871 There's no need for unsigned here.
6873 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6874 This follows up to the 2011-05-06 change that substituted uintptr_t
6875 for EMACS_INT. This case wasn't caught back then.
6877 Rework Fformat to avoid integer overflow issues.
6878 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6879 now (part of C89). Include <verify.h>.
6880 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6881 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6882 (Fformat): Avoid the prepass trying to compute sizes; it was only
6883 approximate and thus did not catch overflow reliably. Instead, walk
6884 through the format just once, formatting and computing sizes as we go,
6885 checking for integer overflow at every step, and allocating a larger
6886 buffer as needed. Keep track separately whether the format is
6887 multibyte. Keep only the most-recently calculated precision, rather
6888 than them all. Record whether each argument has been converted to
6889 string. Use EMACS_INT, not int, for byte and char and arg counts.
6890 Support field widths and precisions larger than INT_MAX. Avoid
6891 sprintf's undefined behavior with conversion specifications such as %#d
6892 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6893 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6894 formatting out-of-range floating point numbers with int
6897 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6899 * data.c: Avoid integer truncation in expressions involving floats.
6900 * data.c: Include <intprops.h>.
6901 (arith_driver): When there's an integer overflow in an expression
6902 involving floating point, convert the integers to floating point
6903 so that the resulting value does not suffer from catastrophic
6904 integer truncation. For example, on a 64-bit host (* 4
6905 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6906 Do not rely on undefined behavior after integer overflow.
6908 merge count_size_as_multibyte, parse_str_to_multibyte
6909 * character.c, character.h (count_size_as_multibyte):
6910 Rename from parse_str_to_multibyte; all uses changed.
6911 Check for integer overflow.
6912 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6913 since it's now a duplicate of the other. This is more of
6914 a character than a buffer op, so better that it's in character.c.
6915 * fns.c, print.c: Adjust to above changes.
6917 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6919 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6921 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6923 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6924 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6925 (x_clipboard_manager_save): Now static.
6926 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6928 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6929 (crypto_hash_function): Now static.
6930 Fix pointer signedness problems. Avoid unnecessary initializations.
6932 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6934 * termhooks.h (Vselection_alist): Make it terminal-local.
6936 * terminal.c (create_terminal): Initialize it.
6938 * xselect.c: Support for clipboard managers.
6939 (Vselection_alist): Move to termhooks.h as terminal-local var.
6940 (LOCAL_SELECTION): New macro.
6941 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6942 (symbol_to_x_atom): Remove gratuitous arg.
6943 (x_handle_selection_request, lisp_data_to_selection_data)
6944 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6945 (x_own_selection, x_get_local_selection, x_convert_selection):
6946 New arg, specifying work frame. Use terminal-local Vselection_alist.
6947 (some_frame_on_display): Delete unused function.
6948 (Fx_own_selection_internal, Fx_get_selection_internal)
6949 (Fx_disown_selection_internal, Fx_selection_owner_p)
6950 (Fx_selection_exists_p): New optional frame arg.
6951 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6952 (x_handle_selection_clear): Don't treat other terminals with the
6953 same keyboard specially. Use the terminal-local Vselection_alist.
6954 (x_clear_frame_selections): Use Frun_hook_with_args.
6956 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6958 * xterm.h: Add support for those atoms.
6960 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6962 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6963 (converted_selections, conversion_fail_tag): New global variables.
6964 (x_selection_request_lisp_error): Free the above.
6965 (x_get_local_selection): Remove unnecessary code.
6966 (x_reply_selection_request): Args changed; handle arbitrary array
6967 of converted selections stored in converted_selections.
6968 Separate the XChangeProperty and SelectionNotify steps.
6969 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6970 (x_convert_selection): New function.
6971 (x_handle_selection_event): Simplify.
6972 (x_get_foreign_selection): Don't ignore incoming requests while
6973 waiting for an answer; this will fail when we implement
6974 SAVE_TARGETS, and seems unnecessary anyway.
6975 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6976 (Vx_sent_selection_functions): Doc fix.
6978 2011-05-26 Leo Liu <sdl.web@gmail.com>
6980 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6982 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6984 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6986 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6987 for fringe update if it has periodic bitmap.
6988 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6989 and fringe_bitmap_periodic_p.
6991 * fringe.c (get_fringe_bitmap_data): New function.
6992 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6993 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6994 row. Mark glyph row for fringe update if periodicity changed.
6996 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6997 for fringe update unless it has periodic bitmap.
6999 2011-05-25 Kenichi Handa <handa@m17n.org>
7001 * xdisp.c (get_next_display_element): Set correct it->face_id for
7002 a static composition.
7004 2011-05-24 Leo Liu <sdl.web@gmail.com>
7007 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7009 * fns.c (crypto_hash_function, Fsha1): New function.
7010 (Fmd5): Use crypto_hash_function.
7011 (syms_of_fns): Add Ssha1.
7013 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7015 * gnutls.c: Remove unused macros.
7016 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7017 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7018 Remove macros that are defined and never used.
7019 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7021 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7023 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7024 (Fx_get_selection_internal): Minor cleanup.
7025 (Fx_own_selection_internal): Rename arguments for consistency with
7028 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7030 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7032 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7034 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7036 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7038 * dispnew.c (scrolling_window): Don't exclude the case that the
7039 last enabled row in the desired matrix touches the bottom boundary.
7041 2011-05-21 Glenn Morris <rgm@gnu.org>
7043 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7044 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7045 and add some more files.
7047 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7049 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7050 report_file_error introduced by the change from 2011-05-07.
7052 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7054 * systime.h (Time): Define only if emacs is defined.
7055 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7056 where the include path doesn't have X11/X.h by default. See
7057 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7059 2011-05-20 Kenichi Handa <handa@m17n.org>
7061 * composite.c (find_automatic_composition): Fix previous change.
7063 2011-05-20 Glenn Morris <rgm@gnu.org>
7065 * lisp.mk: New file, split from Makefile.in.
7066 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7067 (shortlisp): Remove.
7068 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7070 2011-05-19 Glenn Morris <rgm@gnu.org>
7072 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7073 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7074 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7075 (lisp): Set the order to that of loadup.el.
7076 (shortlisp): Make it a copy of $lisp.
7077 (SOME_MACHINE_LISP): Remove.
7078 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7079 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7081 2011-05-18 Kenichi Handa <handa@m17n.org>
7083 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7084 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7085 (find_automatic_composition): Mostly rewrite for efficiency.
7087 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7089 * makefile.w32-in: Update dependencies.
7091 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7093 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7094 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7096 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7098 Fix some integer overflow issues, such as string length overflow.
7100 * insdel.c (count_size_as_multibyte): Check for string overflow.
7102 * character.c (lisp_string_width): Check for string overflow.
7103 Use EMACS_INT, not int, for string indexes and lengths; in
7104 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7105 the resulting string length overflows an EMACS_INT; instead,
7106 report a string overflow if no precision given. When checking for
7107 precision exhaustion, use a check that cannot possibly have
7108 integer overflow. (Bug#8675)
7109 * character.h (lisp_string_width): Adjust to new signature.
7111 * alloc.c (string_overflow): New function.
7112 (Fmake_string): Use it. This doesn't change behavior, but saves
7113 a few bytes and will simplify future changes.
7114 * character.c (string_escape_byte8): Likewise.
7115 * lisp.h (string_overflow): New decl.
7117 Fixups, following up to the user-interface timestamp change.
7118 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7119 for UI timestamps, instead of unsigned long.
7120 * msdos.c (mouse_get_pos): Likewise.
7121 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7122 * w32gui.h (Time): Define by including "systime.h" rather than by
7123 declaring it ourselves. (Bug#8664)
7125 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7126 * image.c (clear_image_cache): Likewise.
7128 * term.c (term_mouse_position): Don't assume time_t wraparound.
7130 Be more systematic about user-interface timestamps.
7131 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7132 and sometimes 'EMACS_UINT', to represent these timestamps.
7133 This change causes it to use 'Time' uniformly, as that's what X uses.
7134 This makes the code easier to follow, and makes it easier to catch
7135 integer overflow bugs such as Bug#8664.
7136 * frame.c (Fmouse_position, Fmouse_pixel_position):
7137 Use Time, not unsigned long, for user-interface timestamps.
7138 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7139 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7140 * keyboard.h (last_event_timestamp): Likewise.
7141 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7142 * menu.h (xmenu_show): Likewise.
7143 * term.c (term_mouse_position): Likewise.
7144 * termhooks.h (struct input_event.timestamp): Likewise.
7145 (struct terminal.mouse_position_hook): Likewise.
7146 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7147 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7148 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7149 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7151 * menu.h, termhooks.h: Include "systime.h", for Time.
7153 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7154 Don't assume that the difference between two unsigned long values
7155 can fit into an integer. At this point, we know button_down_time
7156 <= event->timestamp, so the difference must be nonnegative, so
7157 there's no need to cast the result if double-click-time is
7158 nonnegative, as it should be; check that it's nonnegative, just in
7159 case. This bug is triggered when events are more than 2**31 ms
7160 apart (about 25 days). (Bug#8664)
7162 * xselect.c (last_event_timestamp): Remove duplicate decl.
7163 (x_own_selection): Remove needless cast to unsigned long.
7165 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7166 that always fit in int. Use a sentinel instead of a counter, to
7167 avoid a temp and to allay GCC's concerns about possible int overflow.
7168 * frame.h (struct frame): Use int for menu_bar_items_used
7169 instead of EMACS_INT, since it always fits in int.
7171 * menu.c (grow_menu_items): Check for int overflow.
7173 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7175 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7176 Before, the code was not consistent. These values cannot exceed
7177 2**31 - 1 so there's no need to make them unsigned.
7178 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7179 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7180 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7182 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7184 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7185 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7186 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7187 presumably because the widths might not match.
7189 * window.c (size_window): Avoid needless test at loop start.
7191 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7193 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7195 2011-05-12 Drew Adams <drew.adams@oracle.com>
7197 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7199 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7201 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7202 `width' to `bar_area_x' and `bar_area_width', respectively.
7203 (x_scroll_run): Take account of fringe background extension.
7205 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7206 Rename local vars `left' and `width' to `bar_area_x' and
7207 `bar_area_width', respectively.
7208 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7209 background extension.
7211 2011-05-10 Jim Meyering <meyering@redhat.com>
7213 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7215 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7217 * image.c (Finit_image_library): Return t for built-in image types,
7218 like pbm and xbm. (Bug#8640)
7220 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7222 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7224 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7226 * w32console.c (Fset_screen_color): Doc fix.
7227 (Fget_screen_color): New function.
7228 (syms_of_ntterm): Defsubr it.
7230 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7231 unlink the temporary file if Fcall_process didn't create it in the
7233 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7234 child process will be redirected to a file specified with `:file'.
7235 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7236 cue to call_process_cleanup not to close that handle.
7238 2011-05-07 Ben Key <bkey76@gmail.com>
7240 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7241 one of two shell specific rules, either bootstrap-temacs-CMD or
7242 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7243 to the previous implementation of the bootstrap-temacs rule.
7244 The bootstrap-temacs-CMD rule is similar to the previous
7245 implementation of the bootstrap-temacs rule except that it
7246 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7249 These changes, along with some changes to nt/configure.bat,
7250 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7251 earlier fix to add support for --cflags and --ldflags options
7252 that include quotes so that it works whether make uses cmd or
7255 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7257 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7258 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7260 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7261 a string. Handle both cases.
7262 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7263 (Fdbus_register_method): Use Qinvalid_function.
7265 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7267 * makefile.w32-in: Update dependencies.
7268 (LISP_H): Add inttypes.h and stdin.h.
7269 (PROCESS_H): Add unistd.h.
7271 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7273 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7274 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7276 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7278 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7280 * term.c (vfatal): Remove stray call to va_end.
7281 It's not needed and the C Standard doesn't allow it here anyway.
7283 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7284 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7286 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7289 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7293 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7295 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7297 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7299 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7300 * charset.c (Fdefine_charset_internal): Don't initialize
7301 charset.code_space[15]. The value was garbage, on hosts with
7302 32-bit int (Bug#8600).
7304 * lread.c (read_integer): Be more consistent with string-to-number.
7305 Use string_to_number to do the actual conversion; this avoids
7306 rounding errors and fixes some other screwups. Without this fix,
7307 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7308 (digit_to_number): Move earlier, for benefit of read_integer.
7309 Return -1 if the digit is out of range for the base, -2 if it is
7310 not a digit in any supported base. (Bug#8602)
7312 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7314 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7315 to match comment at start of function. This also removes a
7316 GCC warning about overflow in a 32+64-bit port.
7318 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7320 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7321 Reported by Stefan Monnier in
7322 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7324 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7326 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7327 (EMACS_UINTPTR): Likewise, with uintptr_t.
7329 * lisp.h: Prefer 64-bit EMACS_INT if available.
7330 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7331 on 32-bit hosts that have 64-bit int, so that they can access
7333 However, temporarily disable this change unless the temporary
7334 symbol WIDE_EMACS_INT is defined.
7336 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7338 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7339 This removes an assumption that EMACS_INT and long are the same
7340 width as pointers. The assumption is true for Emacs porting targets
7341 now, but we want to make other targets possible.
7342 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7343 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7344 In the rest of the code, change types of integers that hold casted
7345 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7346 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7347 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7348 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7349 No need to cast type when ORing.
7350 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7351 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7352 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7353 assume EMACS_INT is the same width as char *.
7354 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7355 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7356 Remove no-longer-needed casts.
7357 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7358 (xg_tool_bar_help_callback, xg_make_tool_item):
7359 Use EMACS_INTPTR to hold an integer
7360 that will be cast to void *; this can avoid a GCC warning
7361 if EMACS_INT is not the same width as void *.
7362 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7363 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7364 (current_message_1, set_message_1):
7365 Use a local to convert to proper width without a cast.
7366 * xmenu.c (dialog_selection_callback): Likewise.
7368 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7369 Also, don't assume VALBITS / RAND_BITS is less than 5,
7370 and don't rely on undefined behavior when shifting a 1 left into
7372 * lisp.h (get_random): Change signature to match.
7374 * lread.c (hash_string): Use size_t, not int, for hash computation.
7375 Normally we prefer signed values; but hashing is special, because
7376 it's better to use unsigned division on hash table sizes so that
7377 the remainder is nonnegative. Also, size_t is the natural width
7378 for hashing into memory. The previous code used 'int', which doesn't
7379 retain enough info to hash well into very large tables.
7380 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7382 * dbusbind.c: Don't possibly lose pointer info when converting.
7383 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7384 Use XPNTR rather than XHASH, so that the high-order bits of
7385 the pointer aren't lost when converting through void *.
7387 * eval.c (Fautoload): Don't double-shift a pointer.
7389 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7391 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7393 * gnutls.c (DEF_GNUTLS_FN):
7394 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7396 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7398 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7401 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7403 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7404 New version that can reserve upto 2GB of heap space.
7406 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7408 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7410 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7412 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7413 `gnutls_certificate_set_x509_key_file'.
7415 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7417 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7418 Update dependencies.
7420 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7422 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7423 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7424 Remove unused parameter `fildes'.
7425 * process.c (read_process_output, send_process): Don't pass it.
7427 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7429 Fix previous change: the library cache is defined in w32.c.
7430 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7431 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7433 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7435 Implement dynamic loading of GnuTLS on Windows.
7437 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7438 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7439 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7442 * gnutls.c (Qgnutls_dll): Define.
7443 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7444 (gnutls_*): Declare function pointers.
7445 (init_gnutls_functions): New function to initialize function pointers.
7446 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7447 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7448 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7449 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7450 (emacs_gnutls_write, emacs_gnutls_read)
7451 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7452 (Fgnutls_available_p): New function.
7453 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7454 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7455 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7457 * image.c: Include w32.h.
7458 (Vimage_type_cache): Delete.
7459 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7460 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7461 (w32_delayed_load): Move to w32.c.
7463 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7465 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7466 (w32_delayed_load): Move from image.c. When loading a library, record
7467 its filename in the :loaded-from property of the library id.
7468 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7469 Initialize and staticpro them.
7470 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7472 * process.c: Include lisp.h before w32.h, not after.
7473 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7474 instead of gnutls_record_check_pending.
7476 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7478 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7480 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7481 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7484 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7486 * xterm.c (x_set_frame_alpha): Do not set property on anything
7487 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7489 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7491 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7493 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7495 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7496 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7497 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7498 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7499 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7500 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7501 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7502 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7503 (Qgnutls_bootprop_callbacks_verify): Make static.
7505 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7507 * callproc.c: Indentation fixup.
7509 * sysdep.c (wait_for_termination_1): Make static.
7510 (wait_for_termination, interruptible_wait_for_termination):
7511 Move after wait_for_termination_1.
7513 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7515 * sysdep.c (interruptible_wait_for_termination): New function
7516 which is like wait_for_termination, but allows keyboard
7519 * callproc.c (Fcall_process): Add (:file "file") as an option for
7521 (Fcall_process_region): Ditto.
7523 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7525 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7526 rather than `XVECTOR (FOO)->size'.
7528 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7529 inttypes.h, as a gnulib replacement is used if it not available in
7532 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7534 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7535 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7536 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7538 * coding.c (coding_alloc_by_realloc): Error out if destination
7539 will grow beyond MOST_POSITIVE_FIXNUM.
7540 (decode_coding_emacs_mule): Abort if there isn't enough place in
7541 charbuf for the composition carryover bytes. Reserve an extra
7542 space for up to 2 characters produced in a loop.
7543 (decode_coding_iso_2022): Abort if there isn't enough place in
7544 charbuf for the composition carryover bytes.
7546 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7548 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7549 aborting when %lld or %lll format is passed.
7550 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7551 %llo or %llx format is passed. (Bug#8545)
7553 * window.c (window_scroll_line_based): Use a marker instead of
7554 simple variables to record original value of point. (Bug#7952)
7556 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7557 produced by %s or %c overflows available buffer space. (Bug#8545)
7559 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7561 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7562 (SIZE_MAX): Move defn after all includes, as they might #define it.
7564 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7566 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7568 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7570 * keyboard.c (Qdelayed_warnings_hook): Define.
7571 (command_loop_1): Run `delayed-warnings-hook'
7572 if Vdelayed_warnings_list is non-nil.
7573 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7574 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7576 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7578 * doprnt.c (doprnt): Don't return value smaller than the buffer
7579 size if the message was truncated. (Bug#8545).
7581 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7583 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7584 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7586 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7588 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7590 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7592 * makefile.w32-in: Update dependencies.
7594 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7596 Improve `doprnt' and its usage. (Bug#8545)
7597 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7598 `format_end'. Remove support for %l as a conversion specifier.
7599 Don't use xrealloc. Improve diagnostics when the %l size modifier
7600 is used. Update the commentary.
7602 * eval.c (verror): Simplify calculation of size_t.
7604 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7607 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7609 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7612 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7614 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7615 This makes this file independent of the recent pseudovector change.
7617 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7619 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7621 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7622 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7623 Remove unused local.
7624 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7626 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7627 GCC 4.6.0 optimizes based on type-based alias analysis.
7628 For example, if b is of type struct buffer * and v of type struct
7629 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7630 != &v->size, and therefore "v->size = 1; b->size = 2; return
7631 v->size;" must therefore return 1. This assumption is incorrect
7632 for Emacs, since it type-puns struct Lisp_Vector * with many other
7633 types. To fix this problem, this patch adds a new type struct
7634 vectorlike_header that documents the constraints on layout of vectors
7635 and pseudovectors, and helps optimizing compilers not get fooled
7636 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7637 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7638 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7640 (XSETPVECTYPE): Rewrite in terms of new macro.
7641 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7642 This is a bit clearer, and further avoids the possibility of
7643 undesirable aliasing.
7644 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7645 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7646 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7647 since Lisp_Subr is a special case (no "next" field).
7648 (ASIZE): Now uses header.size rather than size.
7649 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7650 to avoid the hassle of writing XVECTOR (foo)->header.size.
7651 (struct vectorlike_header): New type.
7652 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7653 object, to help avoid aliasing.
7654 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7655 (SUBRP): Likewise, since Lisp_Subr is a special case.
7656 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7657 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7658 (struct Lisp_Hash_Table): Combine first two members into a single
7659 struct vectorlike_header member. All uses of "size" and "next" members
7660 changed to be "header.size" and "header.next".
7661 * buffer.h (struct buffer): Likewise.
7662 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7663 * frame.h (struct frame): Likewise.
7664 * process.h (struct Lisp_Process): Likewise.
7665 * termhooks.h (struct terminal): Likewise.
7666 * window.c (struct save_window_data, struct saved_window): Likewise.
7667 * window.h (struct window): Likewise.
7668 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7669 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7670 * buffer.c (init_buffer_once): Likewise.
7671 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7673 * process.c (Fformat_network_address): Use local var for size,
7676 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7678 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7679 * data.c (atof): Remove decl; no longer used or needed.
7680 (digit_to_number): Move to lread.c.
7681 (Fstring_to_number): Use new string_to_number function, to be
7682 consistent with how the Lisp reader treats infinities and NaNs.
7683 Do not assume that floating-point numbers represent EMACS_INT
7684 without losing information; this is not true on most 64-bit hosts.
7685 Avoid double-rounding errors, by insisting on integers when
7686 parsing non-base-10 numbers, as the documentation specifies.
7687 * lisp.h (string_to_number): New decl, replacing ...
7688 (isfloat_string): Remove.
7689 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7690 (read1): Do not accept +. and -. as integers; this
7691 appears to have been a coding error. Similarly, do not accept
7692 strings like +-1e0 as floating point numbers. Do not report
7693 overflow for integer overflows unless the base is not 10 which
7694 means we have no simple and reliable way to continue.
7695 Break out the floating-point parsing into a new
7696 function string_to_number, so that Fstring_to_number parses
7697 floating point numbers consistently with the Lisp reader.
7698 (digit_to_number): Move here from data.c. Make it static inline.
7699 (E_CHAR, EXP_INT): Remove, replacing with ...
7700 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7701 (string_to_number): New function, replacing isfloat_string.
7702 This function checks for valid syntax and produces the resulting
7703 Lisp float number too. Rework it so that string-to-number
7704 no longer mishandles examples like "1.0e+". Use strtoumax,
7705 so that overflow for non-base-10 numbers is reported only when
7706 there's no portable and simple way to convert to floating point.
7708 * textprop.c (set_text_properties_1): Rewrite for clarity,
7709 and to avoid GCC warning about integer overflow.
7711 * intervals.h (struct interval): Use EMACS_INT for members
7712 where EMACS_UINT might cause problems. See
7713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7714 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7715 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7717 (offset_intervals): Tell GCC not to worry about length overflow
7718 when negating a negative length.
7720 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7721 (overrun_check_free): Likewise.
7723 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7724 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7727 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7728 (gnutls_make_error): Rename local to avoid shadowing.
7729 (gnutls_emacs_global_deinit): ifdef out; not used.
7730 (Fgnutls_boot): Use const for pointer to readonly storage.
7731 Comment out unused local. Fix pointer signedness problems.
7733 * lread.c (openp): Don't stuff size_t into an 'int'.
7734 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7735 about possible signed overflow.
7737 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7738 (GDK_KEY_g): Don't define if already defined.
7739 (xg_prepare_tooltip): Avoid pointer signedness problem.
7740 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7742 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7743 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7745 * xfns.c (Fx_window_property): Simplify a bit,
7746 to make a bit faster and to avoid GCC 4.6.0 warning.
7747 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7749 * fns.c (internal_equal): Don't assume size_t fits in int.
7751 * alloc.c (compact_small_strings): Tighten assertion a little.
7753 Replace pEd with more-general pI, and fix some printf arg casts.
7754 * lisp.h (pI): New macro, generalizing old pEd macro to other
7755 conversion specifiers. For example, use "...%"pI"d..." rather
7756 than "...%"pEd"...".
7757 (pEd): Remove. All uses replaced with similar uses of pI.
7758 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7759 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7760 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7761 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7762 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7763 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7764 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7766 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7767 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7768 * print.c (safe_debug_print, print_object): Likewise.
7769 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7771 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7772 avoiding the 0 flag, which is not portable.
7773 * process.c (Fmake_network_process): Use pI to avoid cast.
7774 * region-cache.c (pp_cache): Likewise.
7775 * xdisp.c (decode_mode_spec): Likewise.
7776 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7777 behavior on 64-bit hosts with printf arg.
7778 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7779 (x_stop_queuing_selection_requests): Likewise.
7780 (x_get_window_property): Don't truncate byte count to an 'int'
7783 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7784 here, since it parses constructs like leading '-' and spaces,
7785 which are not wanted; and it overflows with large numbers.
7786 Instead, simply match F[0-9]+, which is what is wanted anyway.
7788 * alloc.c: Remove unportable assumptions about struct layout.
7789 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7790 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7791 (allocate_vectorlike, make_pure_vector): Use the new macros,
7792 plus offsetof, to remove unportable assumptions about struct layout.
7793 These assumptions hold on all porting targets that I know of, but
7794 they are not guaranteed, they're easy to remove, and removing them
7795 makes further changes easier.
7797 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7798 This doesn't fix a bug but makes the code clearer.
7799 (string_overrun_cookie): Now const. Use initializers that
7800 don't formally overflow signed char, to avoid warnings.
7801 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7802 can cause Emacs to crash when string overrun checking is enabled.
7803 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7804 multiple of sizeof (EMACS_INT); it need not be, if
7805 alignof(EMACS_INT) < sizeof (EMACS_INT).
7806 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7808 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7810 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7812 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7814 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7815 supposed to be handshaking. (Bug#8556)
7816 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7818 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7820 * lisp.h (Qdebug): List symbol.
7821 * eval.c (Qdebug): Restore global linkage.
7822 * keyboard.c (debug-on-event): New variable.
7823 (handle_user_signal): Break into debugger when debug-on-event
7824 matches the current signal symbol.
7826 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7828 * alloc.c (check_sblock, check_string_bytes)
7829 (check_string_free_list): Convert to standard C.
7831 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7833 * w32.c (emacs_gnutls_push): Fix typo.
7835 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7837 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7838 "cast to pointer from integer of different size".
7840 Improve doprnt and its use in verror. (Bug#8545)
7841 * doprnt.c (doprnt): Document the set of format control sequences
7842 supported by the function. Use SAFE_ALLOCA instead of always
7845 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7846 is one byte too soon. Don't use xrealloc; instead xfree and
7849 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7851 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7854 * gnutls.c: Renamed global_initialized to
7855 gnutls_global_initialized. Added internals for the
7856 :verify-hostname-error, :verify-error, and :verify-flags
7857 parameters of `gnutls-boot' and documented those parameters in the
7858 docstring. Start callback support.
7859 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7860 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7861 on error. Return error code.
7862 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7863 (emacs_gnutls_read): Likewise.
7864 (Fgnutls_boot): Return handshake error code.
7865 (emacs_gnutls_handle_error): New function.
7866 (wsaerror_to_errno): Likewise.
7868 * w32.h (emacs_gnutls_pull): Add prototype.
7869 (emacs_gnutls_push): Likewise.
7871 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7872 (emacs_gnutls_push): Likewise.
7874 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7876 * process.c (wait_reading_process_output): Check if GnuTLS
7877 buffered some data internally if no FDs are set for TLS
7880 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7881 (LIBS): Link to USER_LIBS.
7882 ($(BLD)/gnutls.$(0)): New target.
7884 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7886 * xdisp.c (handle_single_display_spec): Rename the
7887 display_replaced_before_p argument into display_replaced_p, to
7888 make it consistent with the commentary. Fix typos in the
7891 * textprop.c (syms_of_textprop): Remove dead code.
7892 (copy_text_properties): Delete obsolete commentary about an
7893 interface that was deleted long ago. Fix typos in the description
7896 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7897 to changes in oldXMenu/XMenu.h from 2011-04-16.
7898 <menu_help_message, prev_menu_help_message>: Constify.
7899 (IT_menu_make_room): menu->help_text is now `const char **';
7902 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7903 to changes in oldXMenu/XMenu.h from 2011-04-16.
7904 (struct XMenu): Declare `help_text' `const char **'.
7906 * xfaces.c <Qunspecified>: Make extern again.
7908 * syntax.c: Include sys/types.h before including regex.h, as
7911 * doc.c (get_doc_string): Improve the format passed to `error'.
7913 * doprnt.c (doprnt): Improve commentary.
7915 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7917 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7920 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7921 changes in globals.h immediately force recompilation.
7922 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7923 $(CURDIR)/s/ms-w32.h.
7924 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7926 * character.c (Fchar_direction): Function deleted.
7927 (syms_of_character): Don't defsubr it.
7928 <char-direction-table>: Deleted.
7930 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7932 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7933 * doprnt.c: Include limits.h.
7934 (SIZE_MAX): New macro.
7935 (doprnt): Return a size_t value. 2nd arg is now size_t.
7936 Many local variables are now size_t instead of int or unsigned.
7937 Improve overflow protection. Support `l' modifier for integer
7938 conversions. Support %l conversion. Don't assume an EMACS_INT
7939 argument for integer conversions and for %c.
7941 * lisp.h (doprnt): Restore prototype.
7943 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7946 * Makefile.in (base_obj): Add back doprnt.o.
7948 * deps.mk (doprnt.o): Add back prerequisites.
7949 (callint.o): Depend on character.h.
7951 * eval.c (internal_lisp_condition_case): Include the handler
7952 representation in the error message.
7953 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7954 when breaking from the loop.
7956 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7958 * callint.c (Fcall_interactively): When displaying error message
7959 about invalid control letter, pass the character's codepoint, not
7960 a pointer to its multibyte form. Improve display of the character
7961 in octal and display also its hex code.
7963 * character.c (char_string): Use %x to display the (unsigned)
7964 codepoint of an invalid character, to avoid displaying a bogus
7967 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7968 `error', not SYMBOL_NAME itself.
7970 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7971 character arguments to `error'.
7973 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7974 to `error' in error message about FINAL_CHAR argument. Make sure
7975 FINAL_CHAR is a character, and use %c when it is passed as
7976 argument to `error'.
7978 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7980 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7982 * w32.c: Include <time.h>.
7983 (sys_localtime): New function.
7985 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7987 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7989 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7991 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7993 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7996 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7998 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7999 gl_state.e_property when gl_state.object is Qt.
8001 * insdel.c (make_gap_larger): Remove limitation of buffer size
8004 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8006 * xdisp.c (lookup_glyphless_char_display)
8007 (produce_glyphless_glyph): Handle cons cell entry in
8008 glyphless-char-display.
8009 (Vglyphless_char_display): Document it.
8011 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8012 glyphless-char-display.
8014 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8016 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8018 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8020 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8021 definition for no-X builds.
8023 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8025 Static checks with GCC 4.6.0 and non-default toolkits.
8027 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8029 * process.c (keyboard_bit_set): Define only if SIGIO.
8030 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8031 (send_process): Repair possible setjmp clobbering.
8033 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8035 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8037 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8039 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8040 Define only if needed.
8042 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8043 by pacifying GCC about it. Maybe it's time to retire it?
8044 * xfaces.c (USG, __TIMEVAL__): Likewise.
8046 * dispextern.h (struct redisplay_interface): Rename param
8048 * termhooks.h (struct terminal): Likewise.
8049 * xterm.c (xembed_send_message): Likewise.
8051 * insdel.c (make_gap_smaller): Define only if
8052 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8054 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8057 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8058 so that we aren't warned about unused symbols.
8060 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8062 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8064 * xfns.c (x_real_positions): Mark locals as initialized.
8066 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8068 * xterm.c: Fix problems found by static analysis with other toolkits.
8069 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8070 (x_dispatch_event): Declare static if USE_GTK, and
8071 define if USE_GTK || USE_X_TOOLKIT.
8072 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8073 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8074 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8075 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8077 * xmenu.c (menu_help_callback): Pointer type fixes.
8078 Use const pointers when pointing at readonly data. Avoid pointer
8080 (FALSE): Remove unused macro.
8081 (update_frame_menubar): Remove unused decl.
8083 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8085 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8086 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8087 (single_menu_item): Rename local to avoid shadowing.
8089 * keyboard.c (make_lispy_event): Remove unused local var.
8091 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8092 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8094 * bitmaps: Change bitmaps from unsigned char back to the X11
8095 compatible char. Avoid the old compiler warnings about
8096 out-of-range initializers by using, for example, '\xab' rather
8099 * xgselect.c (xgselect_initialize): Check vs interface
8100 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8102 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8104 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8105 to read-only memory.
8107 * fns.c (vector): Remove; this old hack is no longer needed.
8109 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8111 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8113 * xrdb.c (x_load_resources): Omit unused local.
8115 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8116 (x_window): Rename locals to avoid shadowing.
8117 (USG): Use the kludged USG macro, to pacify gcc.
8119 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8120 (x_term_init): Remove local to avoid shadowing.
8122 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8124 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8125 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8127 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8129 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8131 Fix regex.c, syntax.c and friends for buffers > 2GB.
8132 * syntax.h (struct gl_state_s): Declare character position members
8135 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8137 * textprop.c (verify_interval_modification, interval_of):
8138 Declare arguments EMACS_INT.
8140 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8143 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8145 * indent.c (Fvertical_motion): Local variable it_start is now
8148 * regex.c (re_match, re_match_2, re_match_2_internal)
8149 (bcmp_translate, regcomp, regexec, print_double_string)
8150 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8151 (re_compile_pattern, re_exec): Declare arguments and local
8152 variables `size_t' and `ssize_t' and return values `regoff_t', as
8154 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8155 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8156 <compile_stack_type>: `size' and `avail' are now `size_t'.
8158 * regex.h <regoff_t>: Use ssize_t, not int.
8159 (re_search, re_search_2, re_match, re_match_2): Arguments that
8160 specify buffer/string position and length are now ssize_t and
8161 size_t. Return type is regoff_t.
8163 2011-04-16 Ben Key <bkey76@gmail.com>
8165 * nsfont.m: Fixed bugs in ns_get_family and
8166 ns_descriptor_to_entity that were caused by using free to
8167 deallocate memory blocks that were allocated by xmalloc (via
8168 xstrdup). This caused Emacs to crash when compiled with
8169 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8170 --enable-checking=xmallocoverrun). xfree is now used to
8171 deallocate these memory blocks.
8173 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8175 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8177 emacs_write: Accept and return EMACS_INT for sizes.
8178 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8180 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8181 Accept and return EMACS_INT.
8182 (emacs_gnutls_write): Return the number of bytes written on
8184 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8185 (emacs_read, emacs_write): Remove check for negative size, as the
8186 Emacs source code has been audited now.
8187 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8188 (emacs_read, emacs_write): Use it.
8189 * process.c (send_process): Adjust to the new signatures of
8190 emacs_write and emacs_gnutls_write. Do not attempt to store
8191 a byte offset into an 'int'; it might overflow.
8192 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8194 * sound.c: Don't assume sizes fit in 'int'.
8195 (struct sound_device.period_size, alsa_period_size):
8196 Return EMACS_INT, not int.
8197 (struct sound_device.write, vox_write, alsa_write):
8198 Accept EMACS_INT, not int.
8199 (wav_play, au_play): Use EMACS_INT to store sizes and to
8200 record read return values.
8202 2011-04-15 Ben Key <bkey76@gmail.com>
8204 * keyboard.c (Qundefined): Don't declare static since it is used
8206 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8207 static since they are used in nsfont.m.
8209 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8211 * process.c (Qprocessp): Don't declare static.
8212 * lisp.h (Qprocessp): Declare again.
8214 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8216 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8218 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8220 Improve C-level modularity by making more things 'static'.
8222 Don't publish debugger-only interfaces to other modules.
8223 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8224 (verify_bytepos, count_markers): Move decls to the only modules
8226 * region-cache.h (pp_cache): Likewise.
8227 * window.h (check_all_windows): Likewise.
8228 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8230 * sysdep.c (croak): Now static, if
8231 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8232 * syssignal.h (croak): Declare only if not static.
8234 * alloc.c (refill_memory_reserve): Now static if
8235 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8236 * lisp.h (refill_memory_reserve): Declare only if not static.
8238 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8239 Define only if USE_LUCID.
8241 * xrdb.c (x_customization_string, x_rm_string): Now static.
8243 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8244 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8246 * xdisp.c (draw_row_with_mouse_face): Now static.
8247 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8249 * window.h (check_all_windows): Mark externally visible.
8251 * window.c (window_deletion_count): Now static.
8253 * undo.c: Make symbols static if they're not exported.
8254 (last_undo_buffer, last_boundary_position, pending_boundary):
8257 * textprop.c (interval_insert_behind_hooks): Now static.
8258 (interval_insert_in_front_hooks): Likewise.
8260 * term.c: Make symbols static if they're not exported.
8261 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8262 (max_frame_lines, tty_set_terminal_modes):
8263 (tty_reset_terminal_modes, tty_turn_off_highlight):
8264 (get_tty_terminal): Now static.
8265 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8266 * termhooks.h (term_mouse_moveto): Do not declare if
8268 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8269 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8271 * sysdep.c: Make symbols static if they're not exported.
8272 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8274 (sigprocmask_set, full_mask): Remove; unused.
8275 (wait_debugging): Mark as visible.
8276 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8277 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8279 * syntax.c (syntax_temp): Define only if !__GNUC__.
8281 * sound.c (current_sound_device, current_sound): Now static.
8283 * search.c (searchbufs, searchbuf_head): Now static.
8285 * scroll.c (scroll_cost): Remove; unused.
8286 * dispextern.h (scroll_cost): Remove decl.
8288 * region-cache.h (pp_cache): Mark as externally visible.
8290 * process.c: Make symbols static if they're not exported.
8291 (process_tick, update_tick, create_process, chan_process):
8292 (Vprocess_alist, proc_buffered_char, datagram_access):
8293 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8294 (deactivate_process): Mark defn as static, as well as decl.
8295 * lisp.h (create_process): Remove decl.
8296 * process.h (chan_process, Vprocess_alist): Remove decls.
8298 * print.c: Make symbols static if they're not exported.
8299 (print_depth, new_backquote_output, being_printed, print_buffer):
8300 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8301 (print_interval, print_number_index, initial_stderr_stream):
8303 * lisp.h (Fprinc): Remove decl.
8304 (debug_output_compilation_hack): Mark as externally visible.
8306 * sysdep.c (croak): Move decl from here to syssignal.h.
8307 * syssignal.h (croak): Put it here, so the API can be checked when
8308 'croak' is called from dissociate_if_controlling_tty.
8310 * minibuf.c: Make symbols static if they're not exported.
8311 (minibuf_save_list, choose_minibuf_frame): Now static.
8312 * lisp.h (choose_minibuf_frame): Remove decl.
8314 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8316 * lread.c: Make symbols static if they're not exported.
8317 (read_objects, initial_obarray, oblookup_last_bucket_number):
8319 (make_symbol): Remove; unused.
8320 * lisp.h (initial_obarray, make_symbol): Remove decls.
8322 * keyboard.c: Make symbols static if they're not exported.
8323 (single_kboard, recent_keys_index, total_keys, recent_keys):
8324 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8325 (this_single_command_key_start, echoing, last_auto_save):
8326 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8327 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8328 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8329 (Vlispy_mouse_stem, double_click_count):
8331 (force_auto_save_soon): Define only if SIGDANGER.
8332 (ignore_mouse_drag_p): Now static if
8333 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8334 (print_help): Remove; unused.
8335 (stop_character, last_timer_event): Mark as externally visible.
8336 * keyboard.h (ignore_mouse_drag_p): Declare only if
8337 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8338 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8339 * lisp.h (echoing): Remove decl.
8340 (force_auto_save_soon): Declare only if SIGDANGER.
8341 * xdisp.c (redisplay_window): Simplify code, to make it more
8342 obvious that ignore_mouse_drag_p is not accessed if !defined
8343 USE_GTK && !defined HAVE_NS.
8345 * intervals.c: Make symbols static if they're not exported.
8346 (merge_properties_sticky, merge_interval_right, delete_interval):
8348 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8350 * insdel.c: Make symbols static if they're not exported.
8351 However, leave prepare_to_modify_buffer alone. It's never
8352 called from outside this function, but that appears to be a bug.
8353 (combine_after_change_list, combine_after_change_buffer):
8354 (adjust_after_replace, signal_before_change): Now static.
8355 (adjust_after_replace_noundo): Remove; unused.
8356 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8357 (signal_before_change): Remove decls.
8359 * indent.c (val_compute_motion, val_vmotion): Now static.
8361 * image.c: Make symbols static if they're not exported.
8362 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8364 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8365 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8367 * fringe.c (standard_bitmaps): Now static.
8368 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8370 * frame.c: Make symbols static if they're not exported.
8371 (x_report_frame_params, make_terminal_frame): Now static.
8372 (get_frame_param): Now static, unless HAVE_NS.
8373 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8374 (x_get_resource_string): Remove; not used.
8375 * frame.h (make_terminal_frame, x_report_frame_params):
8376 (x_get_resource_string); Remove decls.
8377 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8378 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8380 * font.c, fontset.c: Make symbols static if they're not exported.
8381 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8382 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8383 * font.c (font_close_object): Now static.
8384 * font.h (font_close_object): Remove.
8385 * fontset.c (FONTSET_OBJLIST): Remove.
8386 (free_realized_fontset) #if-0 the body, which does nothing.
8387 (face_suitable_for_char_p): #if-0, as it's never called.
8388 * fontset.h (face_suitable_for_char_p): Remove decl.
8389 * xfaces.c (face_at_string_position):
8390 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8391 since 0 is always ASCII.
8393 * fns.c (weak_hash_tables): Now static.
8395 * fileio.c: Make symbols static if they're not exported.
8396 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8397 (Vwrite_region_annotation_buffers): Now static.
8399 * eval.c: Make symbols static if they're not exported.
8400 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8401 * lisp.h (backtrace_list): Remove decl.
8403 * emacs.c: Make symbols static if they're not exported.
8404 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8405 (fatal_error_code, fatal_error_signal_hook, standard_args):
8407 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8408 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8409 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8410 * lisp.h (fatal_error_signal_hook): Remove decl.
8411 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8413 * editfns.c: Move a (normally-unused) function to its only use.
8414 * editfns.c, lisp.h (get_operating_system_release): Remove.
8415 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8416 worth the hassle of breaking this out.
8418 * xterm.c: Make symbols static if they're not exported.
8419 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8420 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8421 (x_destroy_window, x_delete_display):
8423 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8424 (x_mouse_leave): Remove; unused.
8425 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8426 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8427 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8429 (x_mouse_leave): Declare only if WINDOWSNT.
8430 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8431 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8434 * ftxfont.c: Make symbols static if they're not exported.
8435 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8437 * font.h (ftxfont_driver): Likewise.
8439 * xfns.c: Make symbols static if they're not exported.
8440 (x_last_font_name, x_display_info_for_name):
8441 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8442 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8443 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8444 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8445 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8446 (last_show_tip_args): Now static.
8447 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8448 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8449 (x_screen_planes): Remove; unused.
8450 * dispextern.h (x_screen_planes): Remove decl.
8452 * dispnew.c: Make symbols static if they're not exported.
8453 * dispextern.h (redraw_garbaged_frames, scrolling):
8454 (increment_row_positions): Remove.
8455 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8456 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8458 (redraw_garbaged_frames): Remove; unused.
8460 * xfaces.c: Make symbols static if they're not exported.
8461 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8463 * xterm.h (defined_color): Remove decls.
8464 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8465 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8466 (menu_face_changed_default, defined_color, free_realized_face):
8467 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8468 (ascii_face_of_lisp_face): Remove; unused.
8470 * xdisp.c: Make symbols static if they're not exported.
8471 * dispextern.h (scratch_glyph_row, window_box_edges):
8472 (glyph_to_pixel_coords, set_cursor_from_row):
8473 (get_next_display_element, set_iterator_to_next):
8474 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8475 (show_mouse_face): Remove decls
8476 * frame.h (message_buf_print): Likewise.
8477 * lisp.h (pop_message, set_message, check_point_in_composition):
8479 * xterm.h (set_vertical_scroll_bar): Likewise.
8480 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8481 (message_buf_print, scratch_glyph_row, displayed_buffer):
8482 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8483 (get_next_display_element, show_mouse_face, window_box_edges):
8484 (frame_to_window_pixel_xy, check_point_in_composition):
8485 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8486 (glyph_to_pixel_coords): Remove; unused.
8488 * dired.c (file_name_completion): Now static.
8490 * dbusbind.c (xd_in_read_queued_messages): Now static.
8492 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8493 * data.c (circular_list_error): Remove.
8495 * commands.h (last_point_position, last_point_position_buffer):
8496 (last_point_position_window): Remove decls.
8497 * keyboard.c: Make these variables static.
8499 * coding.h (coding, code_convert_region, encode_coding_gap):
8501 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8502 (iso_code_class, detect_coding, code_convert_region): Now static.
8503 (encode_coding_gap): Remove; unused.
8505 * chartab.c (chartab_chars, chartab_bits): Now static.
8507 * charset.h (charset_iso_8859_1): Remove decl.
8508 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8511 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8512 * ccl.c (Vccl_program_table): Now static.
8513 (check_ccl_update): Remove; unused.
8515 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8516 * category.h: ... from here.
8517 * category.c (check_category_table, set_category_set): Now static.
8519 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8520 * lisp.h: Remove these decls.
8522 * buffer.c (buffer_count): Remove unused var.
8524 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8525 so that it's not optimized away.
8526 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8527 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8528 exported only to the debugger.
8530 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8531 * atimer.h (run_all_atimers): Remove; not exported.
8533 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8534 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8535 was inaccessible from Lisp.
8536 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8537 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8539 alloc.c: Import and export fewer symbols, and remove unused items.
8540 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8542 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8543 it's not optimized away by whole-program optimization.
8544 (message_enable_multibyte, free_misc): Remove.
8545 (catchlist, handlerlist, mark_backtrace):
8546 Declare only if BYTE_MARK_STACK.
8547 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8548 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8549 (message_enable_multibyte): Remove decl.
8550 (free_misc, interval_free_list, float_block, float_block_index):
8551 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8552 (cons_free_list, last_marked_index):
8554 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8555 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8556 (mark_backtrace): Define only if BYTE_MARK_STACK.
8557 * xdisp.c (message_enable_multibyte): Now static.
8559 Declare Lisp_Object Q* variables to be 'static' if not exported.
8560 This makes it easier for human readers (and static analyzers)
8561 to see whether these variables are used from other modules.
8562 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8563 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8564 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8565 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8566 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8567 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8568 * xmenu.c, xselect.c:
8569 Declare Q* vars static if they are not used in other modules.
8570 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8571 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8572 Remove decls of unexported vars.
8573 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8575 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8577 Make Emacs functions such as Fatom 'static' by default.
8578 This makes it easier for human readers (and static analyzers)
8579 to see whether these functions can be called from other modules.
8580 DEFUN now defines a static function. To make the function external
8581 so that it can be used in other C modules, use the new macro DEFUE.
8582 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8583 (Finit_image_library):
8584 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8585 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8586 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8587 Remove decls, since these functions are now static.
8588 (Funintern, Fget_internal_run_time): New decls, since these functions
8589 were already external.
8591 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8592 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8593 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8594 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8595 * keyboard.c, keymap.c, lread.c:
8596 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8597 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8598 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8599 Mark functions with DEFUE instead of DEFUN,
8600 if they are used in other modules.
8601 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8602 decls for now-static functions.
8603 * buffer.h (Fdelete_overlay): Remove decl.
8604 * callproc.c (Fgetenv_internal): Mark as internal.
8605 * composite.c (Fremove_list_of_text_properties): Remove decl.
8606 (Fcomposition_get_gstring): New forward static decl.
8607 * composite.h (Fcomposite_get_gstring): Remove decl.
8608 * dired.c (Ffile_attributes): New forward static decl.
8609 * doc.c (Fdocumntation_property): New forward static decl.
8610 * eval.c (Ffetch_bytecode): New forward static decl.
8611 (Funintern): Remove extern decl; now in .h file where it belongs.
8612 * fileio.c (Fmake_symbolic_link): New forward static decl.
8613 * image.c (Finit_image_library): New forward static decl.
8614 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8615 * intervals.h (Fprevious_property_change):
8616 (Fremove_list_of_text_properties): Remove decls.
8617 * keyboard.c (Fthis_command_keys): Remove decl.
8618 (Fcommand_execute): New forward static decl.
8619 * keymap.c (Flookup_key): New forward static decl.
8620 (Fcopy_keymap): Now static.
8621 * keymap.h (Flookup_key): Remove decl.
8622 * process.c (Fget_process): New forward static decl.
8623 (Fprocess_datagram_address): Mark as internal.
8624 * syntax.c (Fsyntax_table_p): New forward static decl.
8625 (skip_chars): Remove duplicate decl.
8626 * textprop.c (Fprevious_property_change): New forward static decl.
8627 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8629 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8630 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8632 * editfns.c (Fformat): Remove unreachable code.
8634 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8636 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8639 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8641 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8642 when at ZV. (Bug#8487)
8644 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8646 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8648 * keyboard.c (parse_tool_bar_item): Likewise.
8649 * sound.c (sound_cleanup, alsa_close): Likewise.
8650 * termcap.c (tgetent): Likewise.
8651 * xfns.c (x_default_font_parameter): Likewise.
8652 * xsettings.c (read_and_apply_settings): Likewise.
8654 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8655 (overrun_check_free): Protoize.
8657 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8659 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8660 since callers should never pass a negative size.
8661 Change the signature to match that of plain 'read' and 'write'; see
8662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8663 * lisp.h: Update prototypes of emacs_write and emacs_read.
8665 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8667 * xdisp.c (redisplay_window): Don't try to determine the character
8668 position of the scroll margin if the window start point w->startp
8669 is outside the buffer's accessible region. (Bug#8468)
8671 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8673 Fix write-region and its subroutines for buffers > 2GB.
8674 * fileio.c (a_write, e_write): Modify declaration of arguments and
8675 local variables to support buffers larger than 2GB.
8676 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8678 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8679 argument, local variables, and return value.
8681 * lisp.h: Update prototypes of emacs_write and emacs_read.
8683 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8685 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8687 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8689 Fix more problems found by GCC 4.6.0's static checks.
8691 * xdisp.c (vmessage): Use a better test for character truncation.
8693 * charset.c (load_charset_map): <, not <=, for optimization,
8694 and to avoid potential problems with integer overflow.
8695 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8696 * casetab.c (set_identity, shuffle): Likewise.
8697 * editfns.c (Fformat): Likewise.
8698 * syntax.c (skip_chars): Likewise.
8700 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8701 This also lets GCC 4.6.0 generate slightly better loop code.
8703 * callint.c (Fcall_interactively): <, not <=, for optimization.
8704 (Fcall_interactively): Count the number of arguments produced,
8705 not the number of arguments given. This is simpler and lets GCC
8706 4.6.0 generate slightly better code.
8708 * ftfont.c: Distingish more carefully between FcChar8 and char.
8709 The previous code passed unsigned char * to a functions like
8710 strlen and xstrcasecmp that expect char *, which does not
8711 conform to the C standard.
8712 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8713 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8714 char * when the C standard requires it.
8716 * keyboard.c (read_char): Remove unused var.
8718 * eval.c: Port to Windows vsnprintf (Bug#8435).
8720 (SIZE_MAX): Define if the headers do not.
8721 (verror): Do not give up if vsnprintf returns a negative count.
8722 Instead, grow the buffer. This ports to Windows vsnprintf, which
8723 does not conform to C99. Problem reported by Eli Zaretskii.
8724 Also, simplify the allocation scheme, by avoiding the need for
8725 calling realloc, and removing the ALLOCATED variable.
8727 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8729 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8730 But keep the doprint source code for now, as we might revamp it
8731 and use it again (Bug#8435).
8732 * lisp.h (doprnt): Remove.
8733 * Makefile.in (base_obj): Remove doprnt.o.
8734 * deps.mk (doprnt.o): Remove.
8736 error: Print 32- and 64-bit integers portably (Bug#8435).
8737 Without this change, on typical 64-bit hosts error ("...%d...", N)
8738 was used to print both 32- and 64-bit integers N, which relied on
8740 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8741 * lisp.h (error, verror): Mark as printf-like functions.
8742 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8743 Report overflow in size calculations when allocating printf buffer.
8744 Do not truncate output string at its first null byte.
8745 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8746 Truncate the output at a character boundary, since vsnprintf does not
8748 * charset.c (check_iso_charset_parameter): Convert internal
8749 character to string before calling 'error', since %c now has the
8751 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8752 overflow when computing char to be passed to 'error'. Do not
8753 pass Lisp_Object to 'error'; pass the integer instead.
8754 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8755 formatted with plain %d.
8757 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8759 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8761 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8763 * xterm.c (x_catch_errors): Remove duplicate declaration.
8765 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8767 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8769 2011-04-10 Jim Meyering <meyering@redhat.com>
8771 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8772 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8773 return ssize_t not "int", and use size_t as the buffer length.
8774 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8775 * gnutls.h: Update declarations.
8776 * process.c (read_process_output): Use ssize_t, to match.
8777 (send_process): Likewise.
8779 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8781 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8783 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8785 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8786 Use unsigned char, to match FcChar8 type definition.
8788 * xterm.c (handle_one_xevent):
8789 * xmenu.c (create_and_show_popup_menu):
8790 * xselect.c (x_decline_selection_request)
8791 (x_reply_selection_request): Avoid type-punned deref of X events.
8793 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8795 Fix some uses of `int' instead of EMACS_INT.
8796 * search.c (string_match_1, fast_string_match)
8797 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8798 (scan_buffer, find_next_newline_no_quit)
8799 (find_before_next_newline, search_command, Freplace_match)
8800 (Fmatch_data): Make some `int' variables be EMACS_INT.
8802 * xdisp.c (display_count_lines): 3rd argument and return value now
8803 EMACS_INT. All callers changed.
8804 (pint2hrstr): Last argument is now EMACS_INT.
8806 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8807 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8808 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8809 (decode_coding_utf_16, decode_coding_emacs_mule)
8810 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8811 (decode_coding_ccl, decode_coding_charset)
8812 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8813 (decode_coding_iso_2022, decode_coding_emacs_mule)
8814 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8815 <char_offset, last_offset>: Declare EMACS_INT.
8816 (encode_coding_utf_8, encode_coding_utf_16)
8817 (encode_coding_emacs_mule, encode_invocation_designation)
8818 (encode_designation_at_bol, encode_coding_iso_2022)
8819 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8820 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8822 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8823 (encode_invocation_designation): Last argument P_NCHARS is now
8825 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8826 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8828 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8831 * ccl.c (Fccl_execute_on_string): Declare some variables
8834 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8836 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8838 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8840 * process.c (Fformat_network_address): Doc fix.
8842 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8844 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8846 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8848 * keyboard.c (read_char): Call Lisp function help-form-show,
8849 instead of using internal_with_output_to_temp_buffer.
8850 (Qhelp_form_show): New var.
8851 (syms_of_keyboard): Use DEFSYM macro.
8853 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8855 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8857 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8859 * process.c (Flist_processes): Remove to Lisp.
8860 (list_processes_1): Delete.
8862 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8864 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8866 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8868 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8870 Fix more problems found by GCC 4.6.0's static checks.
8872 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8874 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8876 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8878 * xdisp.c (vmessage): Mark as a printf-like function.
8880 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8882 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8884 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8885 printf-like functions.
8886 (tiff_load): Add casts to remove these marks before passing them
8887 to system-supplied API.
8889 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8891 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8892 This avoids several warnings with gcc -Wstrict-overflow.
8893 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8894 directly, rather than having caller test rule sign. This avoids
8895 some unnecessary tests.
8896 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8897 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8898 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8900 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8901 (xfont_open): Avoid unnecessary tests.
8903 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8905 * composite.h, composite.c (composition_gstring_put_cache):
8906 Use EMACS_INT, not int, for length.
8908 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8909 breaking out part of COMPOSITION_DECODE_RULE.
8910 (COMPOSITION_DECODE_RULE): Use it.
8911 * composite.c (get_composition_id): Remove unused local vars,
8912 by using the new macro.
8914 * textprop.c (set_text_properties_1): Change while to do-while,
8915 since the condition is always true at first.
8917 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8918 (interval_deletion_adjustment): Return unsigned value.
8921 * process.c (list_processes_1, create_pty, read_process_output):
8922 (exec_sentinel): Remove vars that were set but not used.
8923 (create_pty): Remove unnecessary "volatile"s.
8924 (Fnetwork_interface_info): Avoid possibility of int overflow.
8925 (read_process_output): Do adaptive read buffering even if carryover.
8926 (read_process_output): Simplify nbytes computation if buffered.
8928 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8930 * syntax.c (scan_words): Remove var that was set but not used.
8931 (update_syntax_table): Use unsigned instead of int.
8933 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8934 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8935 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8937 * print.c (print_error_message): Avoid int overflow.
8939 * font.c (font_list_entities): Redo for clarity,
8940 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8942 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8943 (font_score): Avoid potential overflow in diff calculation.
8945 * fns.c (substring_both): Remove var that is set but not used.
8946 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8948 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8950 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8951 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8952 can always succeed if overflow has undefined behavior.
8954 * search.c (boyer_moore, wordify): Remove vars set but not used.
8955 (wordify): Omit three unnecessary tests.
8957 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8958 All callers changed. This avoids the need for an unused var.
8960 * casefiddle.c (casify_region): Remove var that is set but not used.
8962 * dired.c (file_name_completion): Remove var that is set but not used.
8964 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8966 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8967 (Finsert_file_contents): Remove unnecessary code checking fd.
8969 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8970 Check for integer overflow on size calculations.
8972 * buffer.c (Fprevious_overlay_change): Remove var that is set
8975 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8976 Remove vars that are set but not used.
8977 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8978 (timer_check_2): Mark vars as initialized.
8980 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8982 * image.c (lookup_image): Remove var that is set but not used.
8983 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8985 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8986 that are set but not used.
8988 * xfns.c (make_invisible_cursor): Don't return garbage
8989 if XCreateBitmapFromData fails (Bug#8410).
8991 * xselect.c (x_get_local_selection, x_handle_property_notify):
8992 Remove vars that are set but not used.
8994 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8995 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8997 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8998 Remove var that is set but not used.
8999 (scroll_bar_windows_size): Now size_t, not int.
9000 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9003 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9004 (map_tty_color) [!defined MSDOS]: Likewise.
9006 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9008 * coding.c: Remove vars that are set but not used.
9009 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9010 All callers changed.
9011 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9012 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9013 (decode_coding_charset): Remove vars that are set but not used.
9015 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9016 that is set but not used.
9018 * print.c (print_object): Remove var that is set but not used.
9020 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9021 The gnulib version avoids calling malloc in the usual case,
9022 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9023 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9024 * filelock.c (current_lock_owner): Likewise.
9025 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9026 * sysdep.c: Include allocator.h, careadlinkat.h.
9027 (emacs_no_realloc_allocator): New static constant.
9028 (emacs_readlink): New function.
9029 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9030 ../lib/careadlinkat.h.
9032 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9034 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9035 first non-nil return value).
9037 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9039 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9040 if not defined (Bug#8403).
9042 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9044 * xdisp.c (display_count_lines): Remove parameter `start',
9045 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9046 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9047 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9048 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9049 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9050 and thereabouts. All callers changed.
9051 (get_per_char_metric): Remove parameter `f', unused since
9052 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9054 2011-04-02 Jim Meyering <meyering@redhat.com>
9056 do not dereference NULL upon failed strdup
9057 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9058 (ns_get_family): Likewise.
9060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9062 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9064 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9066 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9069 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9071 Add lexical binding.
9073 * window.c (Ftemp_output_buffer_show): New fun.
9074 (Fsave_window_excursion):
9075 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9077 * lread.c (lisp_file_lexically_bound_p): New function.
9078 (Fload): Bind Qlexical_binding.
9079 (readevalloop): Remove `evalfun' arg.
9080 Bind Qinternal_interpreter_environment.
9081 (Feval_buffer): Bind Qlexical_binding.
9082 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9084 (syms_of_lread): Declare `lexical-binding'.
9086 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9088 * keyboard.c (eval_dyn): New fun.
9089 (menu_item_eval_property): Use it.
9091 * image.c (parse_image_spec): Use Ffunctionp.
9093 * fns.c (concat, mapcar1): Accept byte-code-functions.
9095 * eval.c (Fsetq): Handle lexical vars.
9096 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9097 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9098 (FletX, Flet): Obey lexical binding.
9099 (Fcommandp): Handle closures.
9100 (Feval): New `lexical' arg.
9101 (eval_sub): New function extracted from Feval. Use it almost
9102 everywhere where Feval was used. Look up vars in lexical env.
9104 (Ffunctionp): Move from subr.el.
9105 (Ffuncall): Handle closures.
9106 (apply_lambda): Remove `eval_flags'.
9107 (funcall_lambda): Handle closures and new byte-code-functions.
9108 (Fspecial_variable_p): New function.
9109 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9110 but without exporting it to Lisp.
9112 * doc.c (Fdocumentation, store_function_docstring):
9113 * data.c (Finteractive_form): Handle closures.
9115 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9118 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9120 (exec_byte_code): New function extracted from Fbyte_code to handle new
9121 calling convention for byte-code-functions. Add new byte-codes.
9123 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9125 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9127 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9129 * xdisp.c (redisplay_internal): Fix prototype.
9131 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9133 * xdisp.c (SCROLL_LIMIT): New macro.
9134 (try_scrolling): Use it when setting scroll_limit.
9135 Limit scrolling to 100 screen lines.
9136 (redisplay_window): Even when falling back on "recentering",
9137 position point in the window according to scroll-conservatively,
9138 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9140 (try_scrolling): When point is above the window, allow searching
9141 as far as scroll_max, or one screenful, to compute vertical
9142 distance from PT to the scroll margin position. This prevents
9143 try_scrolling from unnecessarily failing when
9144 scroll-conservatively is set to a value slightly larger than the
9145 window height. Clean up the case of PT below the margin at bottom
9146 of window: scroll_max can no longer be INT_MAX. When aggressive
9147 scrolling is in use, don't let point enter the opposite scroll
9148 margin as result of the scroll.
9149 (syms_of_xdisp) <scroll-conservatively>: Document the
9150 threshold of 100 lines for never-recentering scrolling.
9152 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9154 * dispextern.h (move_it_by_lines):
9155 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9156 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9157 (message_log_check_duplicate): Remove parameters `prev_bol' and
9158 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9159 (redisplay_internal): Remove parameter `preserve_echo_area',
9160 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9162 * indent.c (Fvertical_motion):
9163 * window.c (window_scroll_pixel_based, Frecenter):
9164 Don't pass `need_y_p' to `move_it_by_lines'.
9166 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9168 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9169 steal a few bits to be more compact.
9170 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9171 Remove unneeded casts.
9173 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9175 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9177 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9178 binding" message (bug#7967).
9180 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9182 Fix more problems found by GCC 4.6.0's static checks.
9184 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9185 Remove unused local var.
9187 * editfns.c (Fmessage_box): Remove unused local var.
9189 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9190 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9191 Omit unused local vars.
9192 * window.c (shrink_windows): Omit unused local var.
9193 * menu.c (digest_single_submenu): Omit unused local var.
9194 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9195 Omit unused local var.
9197 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9198 Don't assume string length fits in int.
9199 (keyremap_step, read_key_sequence): Use size_t for sizes.
9200 (read_key_sequence): Don't check last_real_key_start redundantly.
9202 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9203 instead of alloca (Bug#8344).
9205 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9206 (Fbacktrace_frame): Don't assume nframes fits in int.
9208 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9210 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9213 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9215 * cm.c (calccost): Turn while-do into do-while, for clarity.
9217 * keyboard.c (syms_of_keyboard): Use the same style as later
9218 in this function when indexing through an array. This also
9219 works around GCC bug 48267.
9221 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9223 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9225 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9226 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9228 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9229 This avoids undefined behavior on integer overflow, and is a bit
9230 more convenient anyway since it is compared to a size_t variable.
9232 Variadic C functions now count arguments with size_t, not int.
9233 This avoids an unnecessary limitation on 64-bit machines, which
9234 caused (substring ...) to crash on large vectors (Bug#8344).
9235 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9236 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9237 All variadic functions and their callers changed accordingly.
9238 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9239 * data.c (arith_driver, float_arith_driver): Likewise.
9240 * editfns.c (general_insert_function): Likewise.
9241 * eval.c (struct backtrace.nargs, interactive_p)
9242 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9243 (funcall_lambda, mark_backtrace): Likewise.
9244 * fns.c (concat): Likewise.
9245 * frame.c (x_set_frame_parameters): Likewise.
9246 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9247 0 if not found, not -1. All callers changed.
9249 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9250 (stack_copy_size): Now size_t, not int.
9251 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9253 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9255 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9256 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9257 All callers changed.
9259 * lisp.h (multibyte_char_to_unibyte):
9260 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9261 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9262 * character.h (CHAR_TO_BYTE8):
9263 * cmds.c (internal_self_insert):
9264 * editfns.c (general_insert_function):
9265 * keymap.c (push_key_description):
9266 * search.c (Freplace_match):
9267 * xdisp.c (message_dolog, set_message_1): All callers changed.
9269 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9271 * keyboard.c (safe_run_hook_funcall): New function.
9272 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9273 don't set the hook to nil, but remove the offending function instead.
9274 (Qcommand_hook_internal): Remove, unused.
9275 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9276 Vcommand_hook_internal.
9278 * eval.c (enum run_hooks_condition): Remove.
9279 (funcall_nil, funcall_not): New functions.
9280 (run_hook_with_args): Call each function through a `funcall' argument.
9281 Remove `cond' argument, now redundant.
9282 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9283 (Frun_hook_with_args_until_failure): Adjust accordingly.
9284 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9286 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9288 * dispextern.h (string_buffer_position): Remove declaration.
9290 * print.c (strout): Remove parameter `multibyte', unused since
9291 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9293 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9294 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9295 All callers changed.
9297 * w32.c (_wsa_errlist): Use braces for struct initializers.
9299 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9300 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9301 All callers changed.
9302 (string_buffer_position): Likewise. Also, make static (it's never
9303 used outside xdisp.c).
9304 (cursor_row_p): Remove parameter `w', unused since
9305 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9306 (decode_mode_spec): Remove parameter `precision', introduced during
9307 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9308 All callers changed.
9310 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9312 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9314 2011-03-27 Anders Lindgren <andlind@gmail.com>
9316 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9317 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9318 (ns_update_auto_hide_menu_bar): New functions.
9319 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9320 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9321 ns_constrain_all_frames.
9322 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9323 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9325 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9327 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9329 2011-03-27 Glenn Morris <rgm@gnu.org>
9331 * syssignal.h: Replace RETSIGTYPE with void.
9332 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9333 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9334 Replace SIGTYPE with void everywhere.
9335 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9336 * s/template.h (SIGTYPE): Remove commented out definition.
9338 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9340 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9341 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9343 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9345 * w32.c (read_unc_volume): Use parameter `henum', instead of
9346 global variable `wget_enum_handle'.
9348 * keymap.c (describe_vector): Remove parameters `indices' and
9349 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9350 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9352 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9354 * keyboard.c (timer_check): Remove parameter `do_it_now',
9355 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9356 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9357 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9359 * keyboard.c (read_char):
9360 * w32menu.c (w32_menu_display_help):
9361 * xmenu.c (show_help_event, menu_help_callback):
9362 Adjust calls to `show_help_echo'.
9364 * gtkutil.c (xg_maybe_add_timer):
9365 * keyboard.c (readable_events):
9366 * process.c (wait_reading_process_output):
9367 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9369 * insdel.c (adjust_markers_gap_motion):
9370 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9371 (gap_left, gap_right): Don't call it.
9373 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9375 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9376 incurred during fontification.
9378 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9380 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9381 (DEFVAR_PER_BUFFER): Don't pass it.
9383 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9384 (scrolling_window): Don't pass it.
9386 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9388 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9390 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9392 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9393 of variables specific to SELinux and computation of `encoded_absname'.
9395 * image.c (XPutPixel): Remove unused variable `height'.
9397 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9399 * unexw32.c (get_section_info): Remove unused variable `section'.
9401 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9402 (system_process_attributes): Remove unused variable `sess'.
9403 (sys_read): Remove unused variable `err'.
9405 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9406 (w32_wnd_proc): Remove unused variable `isdead'.
9407 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9408 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9409 (x_create_tip_frame): Remove unused variable `tem'.
9411 * w32inevt.c (w32_console_read_socket):
9412 Remove unused variable `no_events'.
9414 * w32term.c (x_draw_composite_glyph_string_foreground):
9415 Remove unused variable `width'.
9417 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9419 * w32term.c (x_set_glyph_string_clipping):
9420 Don't pass uninitialized region to CombineRgn.
9422 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9424 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9425 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9426 (Fx_close_connection): Remove unused variable `i'.
9428 * w32font.c (w32font_draw): Return number of glyphs.
9429 (w32font_open_internal): Remove unused variable `i'.
9430 (w32font_driver): Add missing initializer.
9432 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9433 (fill_in_menu): Remove unused variable `items_added'.
9435 * w32term.c (last_mouse_press_frame): Remove static global variable.
9436 (w32_clip_to_row): Remove unused variable `f'.
9437 (x_delete_terminal): Remove unused variable `i'.
9439 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9440 (NOTHING): Remove unused static global variable.
9441 (uniscribe_check_otf): Remove unused variable `table'.
9442 (uniscribe_font_driver): Add missing initializers.
9444 2011-03-23 Julien Danjou <julien@danjou.info>
9446 * term.c (Fsuspend_tty, Fresume_tty):
9447 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9448 * window.c (temp_output_buffer_show):
9449 * insdel.c (signal_before_change):
9450 * frame.c (Fhandle_switch_frame):
9451 * fileio.c (Fdo_auto_save):
9452 * emacs.c (Fkill_emacs):
9453 * editfns.c (save_excursion_restore):
9454 * cmds.c (internal_self_insert):
9455 * callint.c (Fcall_interactively):
9456 * buffer.c (Fkill_all_local_variables):
9457 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9459 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9460 unconditionally since it does the check itself.
9462 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9464 Fix more problems found by GCC 4.5.2's static checks.
9466 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9467 the first time through the loop, since we know p0 < p1 then.
9468 This also avoids a gcc -Wstrict-overflow warning.
9470 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9471 leading to a memory leak, possible in functions like
9472 load_charset_map_from_file that can allocate an unbounded number
9473 of objects (Bug#8318).
9475 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9476 that could (at least in theory) be that large.
9478 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9479 This is less likely to overflow, and avoids undefined behavior if
9480 overflow does occur. All callers changed. Use strtoul to scan
9481 for the unsigned long integer.
9482 (pint2hrstr): Simplify and tune code slightly.
9483 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9485 * scroll.c (do_scrolling): Work around GCC bug 48228.
9486 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9488 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9489 This also avoids a warning with gcc -Wstrict-overflow.
9490 (validate_x_resource_name): Simplify count usage.
9491 This also avoids a warning with gcc -Wstrict-overflow.
9493 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9496 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9498 * process.c (Fmake_network_process): Use socklen_t, not int,
9499 where POSIX says socklen_t is required in portable programs.
9500 This fixes a porting bug on hosts like 64-bit HP-UX, where
9501 socklen_t is wider than int (Bug#8277).
9502 (Fmake_network_process, server_accept_connection):
9503 (wait_reading_process_output, read_process_output):
9506 * process.c: Rename or move locals to avoid shadowing.
9507 (list_processes_1, Fmake_network_process):
9508 (read_process_output_error_handler, exec_sentinel_error_handler):
9509 Rename or move locals.
9510 (Fmake_network_process): Define label "retry_connect" only if needed.
9511 (Fnetwork_interface_info): Fix pointer signedness.
9512 (process_send_signal): Add cast to avoid pointer signedness problem.
9513 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9514 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9516 Make tparam.h and terminfo.c consistent.
9517 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9518 Include tparam.h instead, since it declares them.
9519 * cm.h (PC): Remove extern decl; tparam.h now does this.
9520 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9521 * terminfo.c: Include tparam.h, to check interfaces.
9522 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9523 (tparam): Adjust signature to match interface in tparam.h;
9524 this removes some undefined behavior. Check that outstring and len
9525 are zero, which they always are with Emacs.
9526 * tparam.h (PC, BC, UP): New extern decls.
9528 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9529 (xftfont_open): Rename locals to avoid shadowing.
9531 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9532 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9533 (OTF_TAG_SYM): Omit macro if not needed.
9534 (ftfont_list): Remove unused local.
9535 (get_adstyle_property, ftfont_pattern_entity):
9536 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9537 Rename locals to avoid shadowing.
9539 * xfont.c (xfont_list_family): Mark var as initialized.
9541 * xml.c (make_dom): Now static.
9543 * composite.c (composition_compute_stop_pos): Rename local to
9545 (composition_reseat_it): Remove unused locals.
9546 (find_automatic_composition, composition_adjust_point): Likewise.
9547 (composition_update_it): Mark var as initialized.
9548 (find_automatic_composition): Mark vars as initialized,
9549 with a FIXME (Bug#8290).
9551 character.h: Rename locals to avoid shadowing.
9552 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9553 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9554 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9555 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9558 * textprop.c (property_change_between_p): Remove; unused.
9560 * intervals.c (interval_start_pos): Now static.
9562 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9564 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9565 Rename locals to avoid shadowing.
9567 * sound.c (wav_play, au_play, Fplay_sound_internal):
9568 Fix pointer signedness.
9569 (alsa_choose_format): Remove unused local var.
9570 (wav_play): Initialize a variable to 0, to prevent undefined
9571 behavior (Bug#8278).
9573 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9575 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9577 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9578 clobbering (Bug#8298).
9579 * sysdep.c (sys_subshell): Likewise.
9580 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9582 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9583 This should get cleaned up, so that child_setup has the
9584 same signature on all platforms.
9586 * callproc.c (call_process_cleanup): Now static.
9587 (relocate_fd): Rename locals to avoid shadowing.
9589 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9591 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9592 not to be necessary, and produces flickering.
9594 2011-03-20 Glenn Morris <rgm@gnu.org>
9596 * config.in: Remove file.
9598 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9600 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9601 are now in src/globals.h.
9602 (syms_of_minibuf): Remove spurious & from previous change.
9604 2011-03-20 Leo Liu <sdl.web@gmail.com>
9606 * minibuf.c (completing-read-function): New variable.
9607 (completing-read-default): Rename from completing-read.
9608 (completing-read): Call completing-read-function.
9610 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9612 * xfaces.c (Fx_load_color_file):
9613 Read color file from absolute filename (bug#8250).
9615 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9617 * makefile.w32-in: Update dependencies.
9619 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9621 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9623 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9625 Fix more problems found by GCC 4.5.2's static checks.
9627 * process.c (make_serial_process_unwind, send_process_trap):
9628 (sigchld_handler): Now static.
9630 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9631 That way, the code declares only the vars that it needs.
9632 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9633 * s/cygwin.h (PTY_ITERATION): Likewise.
9634 * s/darwin.h (PTY_ITERATION): Likewise.
9635 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9637 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9638 * process.c (allocate_pty): Don't declare stb unless it's needed.
9640 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9641 (CONSTANTLIM): Remove; unused.
9642 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9643 Define only if needed.
9645 * unexelf.c (unexec): Name an expression,
9646 to avoid gcc -Wbad-function-cast warning.
9647 Use a different way to cause a compilation error if anyone uses
9648 n rather than nn, a way that does not involve shadowing.
9649 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9651 * deps.mk (unexalpha.o): Remove; unused.
9653 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9654 * unexec.h: New file.
9655 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9656 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9658 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9659 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9660 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9661 Change as necessary to match prototype in unexec.h.
9663 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9665 (back_comment, skip_chars): Mark vars as initialized.
9667 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9668 Rename locals to avoid shadowing.
9670 * lread.c (read1): Rewrite so as not to use empty "else".
9671 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9673 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9675 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9676 warning when compiling print.c.
9678 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9679 instead of using an uninitialized var.
9680 (font_sort_entities): Mark var as initialized.
9682 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9684 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9685 pointers to constants.
9686 (font_parse_fcname): Remove unused vars.
9687 (font_delete_unmatched): Now static.
9688 (font_get_spec): Remove; unused.
9689 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9690 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9691 Rename or move locals to avoid shadowing.
9693 * fns.c (require_nesting_list, require_unwind): Now static.
9694 (Ffillarray): Rename locals to avoid shadowing.
9696 * floatfns.c (domain_error2): Define only if needed.
9697 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9699 * alloc.c (mark_backtrace): Move decl from here ...
9700 * lisp.h: ... to here, so that it can be checked.
9702 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9703 (Fdefvar): Rewrite so as not to use empty "else".
9704 (lisp_indirect_variable): Name an expression,
9705 to avoid gcc -Wbad-function-cast warning.
9706 (Fdefvar): Rename locals to avoid shadowing.
9708 * callint.c (quotify_arg, quotify_args): Now static.
9709 (Fcall_interactively): Rename locals to avoid shadowing.
9710 Use const pointer when appropriate.
9712 * lisp.h (get_system_name, get_operating_system_release):
9713 Move decls here, to check interfaces.
9714 * process.c (get_operating_system_release): Move decl to lisp.h.
9715 * xrdb.c (get_system_name): Likewise.
9716 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9717 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9718 some of which prompt warnings from gcc -Wbad-function-cast.
9719 (Fformat_time_string, Fencode_time, Finsert_char):
9720 (Ftranslate_region_internal, Fformat):
9721 Rename or remove local vars to avoid shadowing.
9722 (Ftranslate_region_internal): Mark var as initialized.
9724 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9727 * lisp.h (eassert): Check that the argument compiles, even if
9728 ENABLE_CHECKING is not defined.
9730 * data.c (Findirect_variable): Name an expression, to avoid
9731 gcc -Wbad-function-cast warning.
9732 (default_value, arithcompare, arith_driver, arith_error): Now static.
9733 (store_symval_forwarding): Rename local to avoid shadowing.
9734 (Fmake_variable_buffer_local, Fmake_local_variable):
9735 Mark variables as initialized.
9736 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9738 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9739 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9740 Rename locals to avoid shadowing.
9741 (mark_stack): Move local variables into the #ifdef region where
9743 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9744 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9746 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9747 (GC_STRING_CHARS): Remove; not used.
9748 (Fmemory_limit): Cast sbrk's returned value to char *.
9750 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9751 avoids undefined behavior in theory.
9753 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9755 Use functions, not macros, for up- and down-casing (Bug#8254).
9756 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9757 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9758 to use the following functions instead of these macros.
9759 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9760 EMACS_INT, since callers assume the returned value fits in int.
9761 (upcase1): Likewise, for UPCASE_TABLE.
9762 (uppercasep, lowercasep, upcase): New static inline functions.
9763 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9764 the race-condition problem in the old DOWNCASE.
9766 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9767 Rename locals to avoid shadowing.
9768 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9769 (regex_compile, re_search_2, re_match_2_internal):
9770 Remove unused local vars.
9771 (FREE_VAR): Rewrite so as not to use empty "else",
9772 which gcc can warn about.
9773 (regex_compile, re_match_2_internal): Mark locals as initialized.
9774 (RETALLOC_IF): Define only if needed.
9775 (WORDCHAR_P): Likewise. This one is never needed, but is used
9776 only in a comment talking about a compiler bug, so put inside
9777 the #if 0 of that comment.
9778 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9779 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9782 * search.c (boyer_moore): Rename locals to avoid shadowing.
9783 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9784 (PREV_CHAR_BOUNDARY): Likewise.
9786 * search.c (simple_search): Remove unused var.
9788 * dired.c (compile_pattern): Move decl from here ...
9789 * lisp.h: ... to here, so that it can be checked.
9790 (struct re_registers): New forward decl.
9792 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9794 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9796 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9797 Rename locals to avoid shadowing.
9798 (Fvertical_motion): Mark locals as initialized.
9800 * casefiddle.c (casify_object, casify_region): Now static.
9801 (casify_region): Mark local as initialized.
9803 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9805 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9806 New macros, so that the caller can use some names other than
9807 gcpro1, gcpro2, etc.
9808 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9810 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9811 argument, for consistency with GCPRO2_VAR, etc: it is now the
9812 prefix of the variable, not the variable itself. All uses
9814 * dired.c (directory_files_internal, file_name_completion):
9815 Rename locals to avoid shadowing.
9817 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9818 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9819 dired.c's scmp function, had undefined behavior.
9820 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9821 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9822 * buffer.h: ... to here, because these macros use current_buffer,
9823 and the new implementation with inline functions needs to have
9824 current_buffer in scope now, rather than later when the macros
9826 (downcase, upcase1): New static inline functions.
9827 (DOWNCASE, UPCASE1): Reimplement using these functions.
9828 This avoids undefined behavior in expressions like
9829 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9830 from race conditions in accessing the global variables
9831 case_temp1 and case_temp2.
9832 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9833 * lisp.h (case_temp1, case_temp2): Remove their decls.
9834 * character.h (ASCII_CHAR_P): Move from here ...
9835 * lisp.h: ... to here, so that the inline functions mentioned
9838 * dired.c (directory_files_internal_unwind): Now static.
9840 * fileio.c (file_name_as_directory, directory_file_name):
9841 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9843 (file_name_as_directory): Use const pointers when appropriate.
9844 (Fexpand_file_name): Likewise. In particular, newdir might
9845 point at constant storage, so make it a const pointer.
9846 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9847 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9849 (Fset_file_times, Finsert_file_contents, auto_save_error):
9850 Rename locals to avoid shadowing.
9852 * minibuf.c (choose_minibuf_frame_1): Now static.
9853 (Ftry_completion, Fall_completions): Rename or remove locals
9856 * marker.c (bytepos_to_charpos): Remove; unused.
9858 * lisp.h (verify_bytepos, count_markers): New decls,
9859 so that gcc does not warn that these functions aren't declared.
9861 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9862 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9863 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9864 (copy_text): Remove unused local var.
9866 * filelock.c (within_one_second): Now static.
9867 (lock_file_1): Rename local to avoid shadowing.
9869 * buffer.c (fix_overlays_before): Mark locals as initialized.
9870 (fix_start_end_in_overlays): Likewise. This function should be
9871 simplified by using pointers-to-pointers, but that's a different
9873 (switch_to_buffer_1): Now static.
9874 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9875 (report_overlay_modification): Rename locals to avoid shadowing.
9877 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9878 Fix pointer signedness issue.
9879 (sys_subshell): Mark local as volatile if checking for lint,
9880 to suppress a gcc -Wclobbered warning that does not seem to be right.
9881 (MAXPATHLEN): Define only if needed.
9883 * process.c (serial_open, serial_configure): Move decls from here ...
9884 * systty.h: ... to here, so that they can be checked.
9886 * fns.c (get_random, seed_random): Move extern decls from here ...
9887 * lisp.h: ... to here, so that they can be checked.
9889 * sysdep.c (reset_io): Now static.
9890 (wait_for_termination_signal): Remove; unused.
9892 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9893 (copy_keymap_item, append_key, push_text_char_description):
9895 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9896 (DENSE_TABLE_SIZE): Remove; unused.
9897 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9898 (describe_map_tree):
9899 Rename locals to avoid shadowing.
9901 * keyboard.c: Declare functions static if they are not used elsewhere.
9902 (echo_char, echo_dash, cmd_error, top_level_2):
9903 (poll_for_input, handle_async_input): Now static.
9904 (read_char, kbd_buffer_get_event, make_lispy_position):
9905 (make_lispy_event, make_lispy_movement, apply_modifiers):
9906 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9907 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9908 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9909 (read_key_sequence, read_char): Mark locals as initialized.
9910 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9912 * keyboard.h (make_ctrl_char): New decl.
9913 (mark_kboards): Move decl here ...
9914 * alloc.c (mark_kboards): ... from here.
9916 * lisp.h (force_auto_save_soon): New decl.
9918 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9919 (DEFINE_DUMMY_FUNCTION): New macro.
9920 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9922 (main): Add casts to avoid warnings
9923 if GCC considers string literals to be constants.
9925 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9927 * dbusbind.c: Pointer signedness fixes.
9928 (xd_signature, xd_append_arg, xd_initialize):
9929 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9930 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9931 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9932 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9934 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9935 if GCC considers string literals to be constants.
9936 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9938 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9940 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9941 (print_preprocess, print_object): New macro to fix last change.
9943 * print.c (print_preprocess): Don't forget font objects.
9945 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9947 * emacs.c (USAGE3): Doc fixes.
9949 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9951 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9954 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9956 * lisp.h (VWindow_system, Qfile_name_history):
9957 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9958 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9959 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9961 * w32select.c: Don't #include "keyboard.h".
9962 (run_protected): Add extern declaration for waiting_for_input.
9964 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9965 * w32console.c (detect_input_pending, read_input_pending)
9966 (encode_terminal_code):
9967 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9968 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9969 (w32_system_caret_y, Qfile_name_history):
9970 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9971 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9972 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9973 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9974 * w32proc.c (Qlocal, report_file_error):
9975 * w32term.c (Vwindow_system, updating_frame):
9976 * w32uniscribe.c (initialized, uniscribe_font_driver):
9977 Remove unneeded extern declarations.
9979 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9981 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9983 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9985 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9986 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9987 These macros can no longer be used for assignment.
9989 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9990 Assign struct members directly, instead of using BUF_BEGV etc.
9991 (record_buffer_markers, fetch_buffer_markers): New functions for
9992 recording and fetching special buffer markers.
9993 (set_buffer_internal_1, set_buffer_temp): Use them.
9995 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9997 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9999 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10000 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10002 * xdisp.c (hscroll_window_tree):
10003 (reconsider_clip_changes): Use PT instead of BUF_PT.
10005 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10007 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10008 $(EMACS_ROOT)/lib/intprops.h.
10010 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10012 Fix more problems found by GCC 4.5.2's static checks.
10014 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10015 to unsigned char * to avoid compiler diagnostic.
10016 (xg_free_frame_widgets): Make it clear that a local variable is
10017 needed only if USE_GTK_TOOLTIP.
10018 (gdk_window_get_screen): Make it clear that this macro is needed
10019 only if USE_GTK_TOOLTIP.
10020 (int_gtk_range_get_value): New function, which avoids a diagnostic
10021 from gcc -Wbad-function-cast.
10022 (xg_set_toolkit_scroll_bar_thumb): Use it.
10023 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10024 diagnostic from gcc -Wbad-function-cast.
10025 (get_utf8_string, xg_get_file_with_chooser):
10026 Rename locals to avoid shadowing.
10027 (create_dialog): Move locals to avoid shadowing.
10029 * xgselect.c (xg_select): Remove unused var.
10031 * image.c (four_corners_best): Mark locals as initialized.
10032 (gif_load): Initialize transparent_p to zero (Bug#8238).
10033 Mark another local as initialized.
10034 (my_png_error, my_error_exit): Mark with NO_RETURN.
10036 * image.c (clear_image_cache): Now static.
10037 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10038 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10039 (x_edge_detection): Remove unnecessary cast that
10040 gcc -Wbad-function-cast diagnoses.
10041 (gif_load): Fix pointer signedness.
10042 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10043 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10045 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10047 Improve quality of tests for time stamp overflow.
10048 For example, without this patch (encode-time 0 0 0 1 1
10049 1152921504606846976) returns the obviously-bogus value (-948597
10050 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10051 reports time overflow. See
10052 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10053 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10054 * editfns.c: Include limits.h and intprops.h.
10055 (TIME_T_MIN, TIME_T_MAX): New macros.
10056 (time_overflow): Move earlier, to before first use.
10057 (hi_time, lo_time): New functions, for an accurate test for
10058 out-of-range times.
10059 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10060 (Fget_internal_run_time): Don't assume time_t fits in int.
10061 (make_time): Use list2 instead of Fcons twice.
10062 (Fdecode_time): More accurate test for out-of-range times.
10063 (check_tm_member): New function.
10064 (Fencode_time): Use it, to test for out-of-range times.
10065 (lisp_time_argument): Don't rely on undefined left-shift and
10066 right-shift behavior when checking for time stamp overflow.
10068 * editfns.c (time_overflow): New function, refactoring common code.
10069 (Fformat_time_string, Fdecode_time, Fencode_time):
10070 (Fcurrent_time_string): Use it.
10072 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10073 * dired.c (make_time): Move to ...
10074 * editfns.c (make_time): ... here.
10075 * systime.h: Note the move.
10077 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10079 * fringe.c (update_window_fringes): Remove unused variables.
10081 * unexmacosx.c (copy_data_segment): Also copy __got section.
10084 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10086 * termcap.c [MSDOS]: Include "msdos.h".
10087 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10088 Constify `char *' arguments and their references according to
10089 prototypes in tparam.h.
10091 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10093 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10094 Adapt all references accordingly.
10096 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10098 2011-03-11 Tom Tromey <tromey@redhat.com>
10100 * buffer.c (syms_of_buffer): Remove obsolete comment.
10102 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10104 * termhooks.h (encode_terminal_code): Declare prototype.
10106 * msdos.c (encode_terminal_code): Don't declare prototype.
10108 * term.c (encode_terminal_code): Now external again, used by
10109 w32console.c and msdos.c.
10111 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10112 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10114 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10116 Fix some minor problems found by GCC 4.5.2's static checks.
10118 * fringe.c (update_window_fringes): Mark locals as initialized
10120 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10122 * alloc.c (mark_fringe_data): Move decl from here ...
10123 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10124 to check its interface.
10125 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10127 * fontset.c (free_realized_fontset): Now static.
10128 (Fset_fontset_font): Rename local to avoid shadowing.
10129 (fontset_font): Mark local as initialized.
10130 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10132 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10134 * xselect.c (x_disown_buffer_selections): Remove; not used.
10135 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10136 (x_own_selection, Fx_disown_selection_internal): Rename locals
10137 to avoid shadowing.
10138 (x_handle_dnd_message): Remove local to avoid shadowing.
10140 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10141 so that the caller can use some name other than gcpro1.
10142 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10143 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10144 (Fx_backspace_delete_keys_p):
10145 Use them to avoid shadowing, and rename vars to avoid shadowing.
10146 (x_decode_color, x_set_name, x_window): Now static.
10147 (Fx_create_frame): Add braces to silence GCC warning.
10148 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10149 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10150 Remove unused locals.
10151 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10152 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10153 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10156 * xterm.h (x_mouse_leave): New decl.
10158 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10159 Remove unused functions.
10160 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10161 (x_calc_absolute_position): Now static.
10162 (XTread_socket): Don't define label "out" unless it's used.
10163 Don't declare local "event" unless it's used.
10164 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10165 unless they are used.
10166 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10167 (x_fatal_error_signal): Remove; not used.
10168 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10169 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10170 (x_error_catcher, x_connection_closed, x_error_handler):
10171 (x_error_quitter, xembed_send_message, x_iconify_frame):
10172 (my_log_handler): Rename locals to avoid shadowing.
10173 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10174 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10176 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10177 Rename or move locals to avoid shadowing.
10178 (tty_defined_color, merge_face_heights): Now static.
10179 (free_realized_faces_for_fontset): Remove; not used.
10180 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10181 does not deduce is never used uninitialized.
10182 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10183 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10185 * terminal.c (store_terminal_param): Now static.
10187 * xmenu.c (menu_highlight_callback): Now static.
10188 (set_frame_menubar): Remove unused local.
10189 (xmenu_show): Rename parameter to avoid shadowing.
10190 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10191 since they might point to immutable storage.
10192 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10193 since it's unused otherwise.
10195 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10196 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10197 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10198 avoids a gcc -Wuninitialized diagnostic.
10199 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10200 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10201 does not deduce are never used uninitialized.
10203 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10205 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10206 * window.c (window_loop, size_window):
10207 (run_window_configuration_change_hook, enlarge_window): Likewise.
10209 * window.c (display_buffer): Now static.
10210 (size_window): Mark variables that gcc -Wuninitialized
10211 does not deduce are never used uninitialized.
10212 * window.h (check_all_windows): New decl, to forestall
10213 gcc -Wmissing-prototypes diagnostic.
10214 * dispextern.h (bidi_dump_cached_states): Likewise.
10216 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10218 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10219 Include <limits.h>.
10220 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10221 and to avoid gcc -Wuninitialized warning.
10222 (load_charset_map): Mark variables that gcc -Wuninitialized
10223 does not deduce are never used uninitialized.
10224 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10226 * coding.c (coding_set_source, coding_set_destination):
10227 Use "else { /* comment */ }" rather than "else /* comment */;"
10228 for clarity, and to avoid gcc -Wempty-body warning.
10229 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10230 a block, when the outer 'i' will do.
10231 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10232 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10233 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10234 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10235 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10236 Rename locals to avoid shadowing.
10237 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10238 * coding.c (emacs_mule_char, encode_invocation_designation):
10239 Now static, since they're not used elsewhere.
10240 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10241 (decode_coding_object, encode_coding_object, detect_coding_system):
10242 (decode_coding_emacs_mule): Mark variables that gcc
10243 -Wuninitialized does not deduce are never used uninitialized.
10244 (detect_coding_iso_2022): Initialize a local variable that might
10245 be used uninitialized. Leave a FIXME because it's not clear that
10246 this initialization is needed. (Bug#8211)
10247 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10248 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10249 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10250 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10251 Remove unused macros.
10253 * category.c (hash_get_category_set): Remove unused local var.
10254 (copy_category_table): Now static, since it's not used elsewhere.
10255 * character.c (string_count_byte8): Likewise.
10257 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10258 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10260 * chartab.c (copy_sub_char_table): Now static, since it's not used
10262 (sub_char_table_ref_and_range, char_table_ref_and_range):
10263 Rename locals to avoid shadowing.
10264 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10266 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10267 (BIDI_BOB): Remove unused macro.
10269 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10270 deduce are never used uninitialized.
10271 * term.c (encode_terminal_code): Likewise.
10273 * term.c (encode_terminal_code): Now static. Remove unused local.
10275 * tparam.h: New file.
10276 * term.c, tparam.h: Include it.
10277 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10278 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10279 Move these decls to tparam.h, and make them agree with what
10280 is actually in tparam.c. The previous trick of using incompatible
10281 decls in different modules does not conform to the C standard.
10282 All callers of tparam changed to use tparam's actual API.
10283 * tparam.c (tparam1, tparam, tgoto):
10284 Use const pointers where appropriate.
10286 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10287 * cm.h (struct cm): Likewise.
10288 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10289 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10290 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10291 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10292 (turn_on_face, init_tty): Likewise.
10293 * termchar.h (struct tty_display_info): Likewise.
10295 * term.c (term_mouse_position): Rename local to avoid shadowing.
10297 * alloc.c (mark_ttys): Move decl from here ...
10298 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10300 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10302 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10304 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10306 * search.c (compile_pattern_1): Remove argument regp, unused since
10307 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10308 (compile_pattern): Don't pass it.
10310 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10312 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10313 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10315 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10317 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10319 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10320 gdk_window_get_screen, gdk_window_get_geometry,
10321 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10322 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10323 (xg_get_pixbuf_from_pixmap): New function.
10324 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10325 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10326 Call xg_get_pixbuf_from_pixmap instead of
10327 gdk_pixbuf_get_from_drawable.
10328 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10329 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10330 (xg_check_special_colors): Use GtkStyleContext and its functions
10332 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10333 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10334 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10335 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10336 Call gtk_widget_get_preferred_size.
10337 (xg_frame_resized): gdk_window_get_geometry only takes 5
10339 (xg_win_to_widget, xg_event_is_for_menubar):
10340 Call gdk_x11_window_lookup_for_display.
10341 (xg_set_widget_bg): New function.
10342 (delete_cb): New function.
10343 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10344 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10345 (xg_set_background_color): Call xg_set_widget_bg.
10346 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10347 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10348 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10349 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10351 (update_frame_tool_bar): Call gtk_widget_hide.
10352 (xg_initialize): Use GDK_KEY_g.
10354 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10356 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10358 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10359 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10360 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10362 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10364 * w32xfns.c (select_palette): Check success of RealizePalette against
10365 GDI_ERROR, not zero.
10367 See ChangeLog.11 for earlier changes.
10369 ;; Local Variables:
10373 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10375 This file is part of GNU Emacs.
10377 GNU Emacs is free software: you can redistribute it and/or modify
10378 it under the terms of the GNU General Public License as published by
10379 the Free Software Foundation, either version 3 of the License, or
10380 (at your option) any later version.
10382 GNU Emacs is distributed in the hope that it will be useful,
10383 but WITHOUT ANY WARRANTY; without even the implied warranty of
10384 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10385 GNU General Public License for more details.
10387 You should have received a copy of the GNU General Public License
10388 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.