1 2012-03-26 Chong Yidong <cyd@gnu.org>
3 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4 (command_loop_1): Use it; inhibit selection update for
5 handle-select-window too (Bug#8996).
7 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
9 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific
12 2012-03-25 Kenichi Handa <handa@m17n.org>
14 * dispextern.h (struct glyph): Change the bit length of
15 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
17 2012-03-24 Eli Zaretskii <eliz@gnu.org>
19 * s/ms-w32.h (tzname): Include time.h before redirecting to
20 _tzname. Fixes the MSVC build. (Bug#9960)
22 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
24 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
27 * xterm.c (XTread_socket): Only modify handling_signal if
28 !SYNC_INPUT. (Bug#11080)
30 2012-03-23 Eli Zaretskii <eliz@gnu.org>
32 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
33 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
34 when fetching a multibyte character consumes more bytes than
35 CHAR_BYTES returns, due to unification of CJK characters in
36 string_char. (Bug#11073)
38 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
40 * process.c (wait_reading_process_output): Handle pty disconnect
41 by refraining from sending oneself a SIGCHLD (bug#10933).
43 2012-03-22 Chong Yidong <cyd@gnu.org>
45 * dispextern.h (struct it): New member string_from_prefix_prop_p.
47 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
48 Mark string as coming from a prefix property.
49 (handle_face_prop): Use default face for prefix strings (Bug#4281).
50 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
52 2012-03-21 Chong Yidong <cyd@gnu.org>
54 * xfaces.c (Vface_remapping_alist): Doc fix.
56 2012-03-20 Eli Zaretskii <eliz@gnu.org>
58 * w32proc.c (Fw32_set_console_codepage)
59 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
62 2012-03-20 Chong Yidong <cyd@gnu.org>
64 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
65 to reflect default non-nil value of redisplay-dont-pause.
67 2012-03-19 Kenichi Handa <handa@m17n.org>
69 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
70 it fit in a valid range (Bug#11003).
72 2012-03-18 Eli Zaretskii <eliz@gnu.org>
74 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
75 that is not from display property, accept the row as a "cursor
76 row" if one of the string's character has a non-nil `cursor'
77 property. Fixes cursor positioning when there are newlines in
78 overlay strings, e.g. in icomplete.el. (Bug#11035)
80 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
82 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
84 2012-03-12 Chong Yidong <cyd@gnu.org>
86 * eval.c (inhibit_lisp_code): Rename from
87 inhibit_window_configuration_change_hook; move from window.c.
89 * xfns.c (unwind_create_frame_1, Fx_create_frame):
90 * window.c (run_window_configuration_change_hook)
91 (syms_of_window): Callers changed.
93 2012-03-11 Chong Yidong <cyd@gnu.org>
95 * keymap.c (Fkey_description): Doc fix (Bug#9700).
97 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
99 2012-03-10 Chong Yidong <cyd@gnu.org>
101 * frame.c (other_visible_frames): Don't assume the selected frame
102 is visible (Bug#10955).
104 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
106 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
108 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
110 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
111 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
114 2012-03-03 Glenn Morris <rgm@gnu.org>
116 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
118 2012-03-02 Eli Zaretskii <eliz@gnu.org>
120 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
121 position past the first glyph_row that ends at ZV. (Bug#10902)
122 (redisplay_window, next_element_from_string): Fix typos in
124 (redisplay_window): Pass to move_it_vertically the margin in
125 pixels, not in screen lines.
127 2012-03-02 Glenn Morris <rgm@gnu.org>
129 * buffer.c (buffer-list-update-hook): Doc fix.
131 2012-02-29 Eli Zaretskii <eliz@gnu.org>
133 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
134 push_it before setting up the iterator for the first overlay
135 string, even if we have an empty string loaded.
136 (next_overlay_string): If there's an empty string on the iterator
137 stack, pop the stack. (Bug#10903)
139 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
141 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
142 Suggested by Stefan Monnier in
143 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
144 * alloc.c (widen_to_Lisp_Object): New static function.
145 (mark_memory): Also mark Lisp_Objects by fetching pointer words
146 and widening them to Lisp_Objects. This would work even if
147 USE_LSB_TAG is defined and wide integers are used, which might
148 happen in a future version of Emacs.
150 2012-02-25 Chong Yidong <cyd@gnu.org>
152 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
155 * xselect.c (Fx_selection_exists_p): Doc fix.
156 (x_clipboard_manager_save_all): Print an informative message
157 before saving to clipboard manager.
159 2012-02-24 Chong Yidong <cyd@gnu.org>
161 * keyboard.c (process_special_events): Handle all X selection
162 requests in kbd_buffer, not just the next one (Bug#8869).
164 2012-02-23 Chong Yidong <cyd@gnu.org>
166 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
167 call when setting menu-bar-lines and tool-bar-lines parameters.
168 (unwind_create_frame_1): New helper function.
170 * window.c (inhibit_window_configuration_change_hook): New var.
171 (run_window_configuration_change_hook): Obey it.
172 (syms_of_window): Initialize it.
174 2012-02-22 Chong Yidong <cyd@gnu.org>
176 * xterm.c (x_draw_image_relief): Add missing type check for
177 Vtool_bar_button_margin (Bug#10743).
179 2012-02-21 Chong Yidong <cyd@gnu.org>
181 * fileio.c (Vfile_name_handler_alist): Doc fix.
183 * buffer.c (Fget_file_buffer): Protect against invalid file
184 handler return value.
186 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
188 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
189 when computing $valmask.
191 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
192 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
193 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
194 It's useless in that case, and it can cause problems on hosts
195 that allocate halves of EMACS_INT values separately.
196 Reported by Dan Horák. Diagnosed by Andreas Schwab in
197 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
198 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
199 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
200 it avoids undefined behavior on hosts where shifting right by more
201 than the word width has undefined behavior.
203 2012-02-19 Chong Yidong <cyd@gnu.org>
205 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
206 (Funhandled_file_name_directory, Ffile_name_as_directory)
207 (Fdirectory_file_name, Fexpand_file_name)
208 (Fsubstitute_in_file_name): Protect against invalid file handler
209 return values (Bug#10845).
211 2012-02-18 Eli Zaretskii <eliz@gnu.org>
213 * .gdbinit (pitx): Fix incorrect references to fields of the
216 2012-02-17 Chong Yidong <cyd@gnu.org>
218 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
220 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
222 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
223 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
225 2012-02-15 Chong Yidong <cyd@gnu.org>
227 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
228 marked as special. Also, starting docstrings with * is obsolete.
230 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
232 * gnutls.c (emacs_gnutls_write): Fix last change.
234 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
236 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
239 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
241 * keymap.c (Fsingle_key_description): Handle char ranges.
243 2012-02-12 Chong Yidong <cyd@gnu.org>
245 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
246 as that creates a dangerous corner case.
248 * window.c (Fdelete_window_internal): Invalidate the mouse
249 highlight (Bug#9904).
251 2012-02-12 Glenn Morris <rgm@gnu.org>
253 * xselect.c (Fx_own_selection_internal)
254 (Fx_get_selection_internal, Fx_disown_selection_internal)
255 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
256 * nsselect.m (Fx_own_selection_internal)
257 (Fx_disown_selection_internal, Fx_selection_exists_p)
258 (Fx_selection_owner_p, Fx_get_selection_internal):
259 Sync docs and argument specs with the xselect.c versions.
261 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
263 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
265 2012-02-11 Eli Zaretskii <eliz@gnu.org>
267 * w32select.c (Fx_selection_exists_p): Sync doc string and
268 argument list with xselect.c. (Bug#10783)
270 * w16select.c (Fx_selection_exists_p): Sync doc string and
271 argument list with xselect.c. (Bug#10783)
273 2012-02-10 Glenn Morris <rgm@gnu.org>
275 * fns.c (Fsecure_hash): Doc fix.
277 2012-02-09 Kenichi Handa <handa@m17n.org>
279 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
281 2012-02-07 Chong Yidong <cyd@gnu.org>
283 * buffer.c (Fbuffer_local_variables)
284 (buffer_lisp_local_variables): Handle unbound vars correctly;
285 don't let Qunbound leak into Lisp.
287 2012-02-07 Glenn Morris <rgm@gnu.org>
289 * image.c (Fimagemagick_types): Doc fix.
291 * image.c (imagemagick-render-type): Change it from a lisp object
292 to an integer. Move the doc here from the lisp manual.
293 Treat all values not equal to 0 the same.
295 2012-02-06 Chong Yidong <cyd@gnu.org>
297 * doc.c (store_function_docstring): Avoid applying docstring of
298 alias to base function (Bug#2603).
300 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
302 * .gdbinit (pp1, pv1): Remove redundant defines.
305 2012-02-04 Chong Yidong <cyd@gnu.org>
307 * nsterm.m: Declare a global (Bug#10694).
309 2012-02-04 Eli Zaretskii <eliz@gnu.org>
311 * w32.c (get_emacs_configuration_options):
312 Include --enable-checking, if specified, in the return value.
314 2012-02-04 Martin Rudalics <rudalics@gmx.at>
316 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
317 after rounding frame sizes. (Bug#9723)
319 2012-02-04 Eli Zaretskii <eliz@gnu.org>
321 * keyboard.c (adjust_point_for_property): Don't position point
322 before BEGV. (Bug#10696)
324 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
326 Handle overflow when computing char display width (Bug#9496).
327 * character.c (char_width): Return EMACS_INT, not int.
328 (char_width, c_string_width): Check for overflow when
329 computing the width; this is possible now that individual
330 characters can have unbounded width. Problem introduced
331 by merge from Emacs 23 on 2012-01-19.
333 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
335 * dbusbind.c (Fdbus_register_method): Mention the return value
336 :ignore in the docstring.
338 2012-02-02 Glenn Morris <rgm@gnu.org>
340 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
342 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
343 Unconditionally set to t. (Bug#10673)
344 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
345 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
346 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
348 2012-02-02 Kenichi Handa <handa@m17n.org>
350 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
351 0, do not call append_composite_glyph.
353 2012-02-02 Kenichi Handa <handa@m17n.org>
355 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
357 (x_produce_glyphs): If the component of a composition is a null
358 string, set it->pixel_width to 1 to avoid zero-width glyph.
360 2012-02-01 Eli Zaretskii <eliz@gnu.org>
362 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
363 first 2 arguments are identical. This makes inserting large
364 output from a subprocess an order of magnitude faster on
365 MS-Windows, where all sbrk'ed memory is always contiguous.
367 2012-01-31 Glenn Morris <rgm@gnu.org>
369 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
370 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
371 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
373 2012-01-29 Glenn Morris <rgm@gnu.org>
375 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
377 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
379 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
381 2012-01-28 Chong Yidong <cyd@gnu.org>
383 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
385 2012-01-26 Chong Yidong <cyd@gnu.org>
387 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
389 * search.c (Fsearch_forward, Fsearch_backward): Document negative
390 repeat counts (Bug#10507).
392 2012-01-26 Glenn Morris <rgm@gnu.org>
394 * lread.c (syms_of_lread): Doc fix.
396 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
398 * coding.c (encode_designation_at_bol): Change return value to
401 2012-01-25 Chong Yidong <cyd@gnu.org>
403 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
405 2012-01-21 Chong Yidong <cyd@gnu.org>
407 * floatfns.c (Fcopysign): Make the second argument non-optional,
408 since nil is not allowed anyway.
410 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
412 * process.c (read_process_output): Use p instead of XPROCESS (proc).
413 (send_process): Likewise.
415 2012-01-19 Martin Rudalics <rudalics@gmx.at>
417 * window.c (save_window_save, Fcurrent_window_configuration)
418 (Vwindow_persistent_parameters): Do not use Qstate.
421 2012-01-19 Kenichi Handa <handa@m17n.org>
423 * character.c (char_width): New function.
424 (Fchar_width, c_string_width, lisp_string_width):
425 Use char_width (Bug#9496).
427 2012-01-16 Martin Rudalics <rudalics@gmx.at>
429 * window.c (Vwindow_persistent_parameters): New variable.
430 (Fset_window_configuration, save_window_save): Handle persistent
433 2012-01-14 Eli Zaretskii <eliz@gnu.org>
435 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
436 thrashing the stack of the thread. (Bug#9087)
438 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
440 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
442 2012-01-11 Eli Zaretskii <eliz@gnu.org>
444 * xdisp.c (rows_from_pos_range): Handle the case where the
445 highlight ends on a newline. (Bug#10464)
446 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
447 he end column for display of highlight that ends on a newline
450 2012-01-11 Glenn Morris <rgm@gnu.org>
452 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
453 from load-path also when installation-directory is nil. (Bug#10208)
455 2012-01-10 Glenn Morris <rgm@gnu.org>
457 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
459 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
460 Update template values to be closer to their typical values these days.
462 2012-01-09 Eli Zaretskii <eliz@gnu.org>
464 * xdisp.c (rows_from_pos_range): Accept additional argument
465 DISP_STRING, and accept any glyph in a row whose object is that
466 string as eligible for mouse highlight. Fixes mouse highlight of
467 display strings from overlays. (Bug#10464)
469 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
471 emacs: fix an auto-save permissions race condition (Bug#10400)
472 * fileio.c (auto_saving_dir_umask): New static var.
473 (Fmake_directory_internal): Use it.
474 (do_auto_save_make_dir): Set it, instead of invoking chmod after
475 creating the directory. The old code temporarily assigns
476 too-generous permissions to the directory.
477 (do_auto_save_eh): Clear it.
478 (Fdo_auto_save): Catch all errors, not just file errors, so
479 that the var is always cleared.
481 2012-01-07 Eli Zaretskii <eliz@gnu.org>
483 * search.c (scan_buffer): Pass character positions to
484 know_region_cache, not byte positions. (Bug#6540)
486 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
488 * w32.c (sys_rename): Report EXDEV when rename of a directory
489 fails because the target is on another logical disk. (Bug#10284)
491 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
493 * xterm.c (x_embed_request_focus): New function.
495 * xterm.h: Add prototype.
497 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
499 2012-01-05 Glenn Morris <rgm@gnu.org>
501 * emacs.c (emacs_copyright): Update short copyright year to 2012.
503 2012-01-01 Eli Zaretskii <eliz@gnu.org>
505 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
506 Load gnutls_transport_set_lowat only if GnuTLS version is below
508 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
509 GnuTLS versions below 2.11.1.
511 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
513 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
514 to the doc string advising against its use for altering the way
515 windows are scrolled.
517 2011-12-28 Kenichi Handa <handa@m17n.org>
519 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
520 coding-system ASCII compatible only when it does not produce BOM
521 on encoding (Bug#10383).
523 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
525 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
527 (create_and_show_popup_menu): Always use menu_position_func for
530 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
532 * callint.c (Fcall_interactively): Don't truncate prompt string.
534 2011-12-23 Eli Zaretskii <eliz@gnu.org>
536 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
537 property that ends at ZV, so that the bidi iteration could be
538 resumed from there (after widening). (Bug#10360)
540 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
542 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
544 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
546 * nsterm.m (x_free_frame_resources):
547 Release f->output_data.ns->miniimage.
548 (ns_index_color): Fix indentation. Do not retain
549 color_table->colors[i].
551 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
554 * nsfns.m (x_set_background_color): Assign return value from
555 ns_index_color to face-background instead of NSColor*.
556 (ns_implicitly_set_icon_type): Fix indentation.
557 Change assignment in for loop to comparison.
559 * emacs.c (ns_pool): New variable.
560 (main): Assign ns_pool.
561 (Fkill_emacs): Call ns_release_autorelease_pool.
563 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
564 autorelease fdesc, release fdAttrs and tdict.
565 (ns_get_covering_families): Release charset.
566 (ns_findfonts): Release NSFontDescriptor created with new.
567 (ns_uni_to_glyphs): Fix indentation.
568 (setString): Release attrStr before assigning new value.
570 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
572 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
574 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
575 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
577 2011-12-18 David Reitter <reitter@cmu.edu>
579 * nsterm.m (ns_term_init): Subscribe for notifications
580 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
581 to method trackingNotification in EmacsMenu.
583 * nsmenu.m (trackingMenu): New variable.
584 (trackingNotification): New method (from Aquamacs).
585 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
586 from Aquamacs (Bug#7030).
588 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
590 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
591 (symbol_to_nsstring): Fix indentation.
592 (ns_symbol_to_pb): New function.
593 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
594 (Fns_rotate_cut_buffers_internal): Remove.
595 (Fns_store_selection_internal): Rename from
596 Fns_store_cut_buffer_internal.
597 (ns_get_foreign_selection, Fx_own_selection_internal)
598 (Fx_disown_selection_internal, Fx_selection_exists_p)
599 (Fns_get_selection_internal, Fns_store_selection_internal):
600 Use ns_symbol_to_pb and check if return value is nil.
601 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
602 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
603 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
604 renamed to Sns_store_selection_internal.
605 (ns_handle_selection_request): Move code to Fx_own_selection_internal
606 and remove this function.
607 (ns_handle_selection_clear): Remove, never used.
608 (Fx_own_selection_internal): Move code from ns_handle_selection_request
611 2011-12-17 Ken Brown <kbrown@cornell.edu>
613 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
614 GID is unknown (Bug#10257).
616 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
618 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
619 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
620 which caused a build failure on GNU/Linux IA-64. This problem was
621 introduced by my 2011-10-07 patch.
623 2011-12-15 Juri Linkov <juri@jurta.org>
625 * image.c (imagemagick_error): New function. (Bug#10112)
626 (imagemagick_load_image): Comment out `MagickSetResolution' call.
627 Use `imagemagick_error' where ImageMagick functions return
629 (Fimagemagick_types): Add `Fnreverse' to return the list in the
632 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
634 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
635 fill background (Bug#8992).
637 2011-12-13 Martin Rudalics <rudalics@gmx.at>
639 * window.c (Vwindow_combination_resize)
640 (Vwindow_combination_limit): Use t instead of non-nil in
642 (Vrecenter_redisplay): Add first sentence of doc-string on
644 (Frecenter): Fix doc-string typo.
646 2011-12-11 Kenichi Handa <handa@m17n.org>
648 * coding.c (Funencodable_char_position): Pay attention to the
649 buffer text relocation (Bug#9389).
651 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
653 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
654 gtk_init (Bug#10100).
656 2011-12-10 Eli Zaretskii <eliz@gnu.org>
658 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
659 IT->string is nil. (Bug#10263)
661 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
663 * nsterm.h (x_free_frame_resources): Declare.
665 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
666 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
668 * nsterm.h (ns_get_defaults_value): Declare.
670 * nsterm.m (ns_default): Call ns_get_defaults_value.
672 2011-12-09 Eli Zaretskii <eliz@gnu.org>
674 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
677 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
679 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
680 that where the value of an _OBJC_* symbol points to is in the .bss
683 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
685 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
686 after the loop to call ccl_driver at least once (Bug#8619).
688 2011-12-08 Kenichi Handa <handa@m17n.org>
690 * ftfont.c (get_adstyle_property): Fix previous change
693 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
695 * w32.c (init_environment): If no_site_lisp, remove site-lisp
696 dirs from the default value of EMACSLOADPATH (bug#10208).
698 2011-12-07 Glenn Morris <rgm@gnu.org>
700 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
701 installation and source directories as well. (Bug#10208)
703 2011-12-06 Chong Yidong <cyd@gnu.org>
705 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
707 2011-12-06 Glenn Morris <rgm@gnu.org>
709 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
710 as an error, not just -1. (Bug#10217)
712 2011-12-05 Chong Yidong <cyd@gnu.org>
714 * keyboard.c (process_special_events): New function.
715 (swallow_events, Finput_pending_p): Use it (Bug#10195).
717 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
719 * coding.c (encode_designation_at_bol): Don't use uninitialized
720 local variable (Bug#9318).
722 2011-12-05 Kenichi Handa <handa@m17n.org>
724 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
725 return Qnil (Bug#8046, Bug#10193).
727 2011-12-05 Kenichi Handa <handa@m17n.org>
729 * coding.c (encode_designation_at_bol): New args charbuf_end and
730 dst. Return the number of produced bytes. Callers changed.
731 (coding_set_source): Return how many bytes coding->source was
733 (coding_set_destination): Return how many bytes
734 coding->destination was relocated.
735 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
736 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
738 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
740 * coding.c (CODING_CHAR_CHARSET_P): New macro.
741 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
744 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
746 The following changes are to fix Bug#9318.
748 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
749 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
750 (encode_coding_iso_2022, encode_coding_sjis)
751 (encode_coding_big5, encode_coding_charset): Use the above macros.
753 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
755 * lisp.h (process_quit_flag): Fix external declaration.
757 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
759 Don't macro-inline non-performance-critical code.
760 * eval.c (process_quit_flag): New function.
761 * lisp.h (QUIT): Use it.
763 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
765 * nsfns.m (get_geometry_from_preferences): New function.
766 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
768 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
770 * emacs.c (Qkill_emacs): Define.
771 (syms_of_emacs): Initialize it.
772 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
773 Qquit_flag to `kill-emacs' instead.
774 (quit_throw_to_read_char): Add parameter `from_signal'.
775 All callers changed. Call Fkill_emacs if requested and safe.
776 * lisp.h (QUIT): Call Fkill_emacs if requested.
778 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
780 * widget.c (update_wm_hints): Return if wmshell is null.
781 (widget_update_wm_size_hints): New function.
783 * widget.h (widget_update_wm_size_hints): Declare.
785 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
786 widget_update_wm_size_hints (Bug#10104).
788 2011-12-03 Eli Zaretskii <eliz@gnu.org>
790 * xdisp.c (handle_invisible_prop): If the invisible text ends just
791 before a newline, prepare the bidi iterator for consuming the
792 newline, and keep the current paragraph direction. (Bug#10183)
793 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
795 2011-12-02 Juri Linkov <juri@jurta.org>
797 * search.c (Fword_search_regexp): New Lisp function created from
798 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
799 (Fword_search_backward, Fword_search_forward)
800 (Fword_search_backward_lax, Fword_search_forward_lax):
801 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
802 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
804 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
806 * fileio.c (Finsert_file_contents): Move after-change-function call
807 to before the "handled:" label, since all "goto handled" appear in
808 cases where the *-change-functions have already been properly called
811 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
813 * keyboard.c (interrupt_signal): Don't call kill-emacs when
814 waiting for input. (Bug#10169)
816 2011-11-30 Eli Zaretskii <eliz@gnu.org>
818 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
819 verifies glyph row's hash code--we have just reallocated the
820 glyphs, so their contents can be complete garbage. (Bug#10164)
822 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
824 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
826 2011-11-30 Eli Zaretskii <eliz@gnu.org>
828 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
829 attributes are tested _before_ calling verify_row_hash, to protect
830 against GCC re-ordering of the tests. (Bug#10164)
832 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
834 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
836 * xterm.c (handle_one_xevent): Only set async_visible and friends
837 if net_wm_state_hidden_seen is non-zero (Bug#10002)
838 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
839 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
841 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
843 Remove GCPRO-related macros that exist only to avoid shadowing locals.
844 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
845 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
846 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
847 All uses changed to use GCPRO1 etc.
848 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
849 Revert to old implementation (i.e., before 2011-03-11).
851 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
853 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
854 of scroll runs so as to avoid assigning disabled bogus rows and
855 unnecessary graphics copy operations.
857 2011-11-27 Eli Zaretskii <eliz@gnu.org>
859 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
860 (snprintf) [_MSC_VER]: Redirect to _snprintf.
861 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
862 (malloc, free, realloc, calloc): Redirect to e_* only when
865 * lisp.h (GCTYPEBITS): Move before first use.
866 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
867 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
868 this macro definition.
870 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
873 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
875 * gtkutil.c (xg_create_frame_widgets):
876 Call gtk_window_set_has_resize_grip (FALSE) if that function is
877 present with Gtk+ 2.0.
879 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
881 * fileio.c (Finsert_file_contents): Undo previous change; see
882 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
884 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
886 Rename locals to avoid shadowing.
887 * fileio.c (Finsert_file_contents):
888 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
889 * process.c (wait_reading_process_output):
890 Rename inner 'proc' to 'p' to avoid shadowing.
891 Indent for consistency with usual Emacs style.
893 2011-11-25 Eli Zaretskii <eliz@gnu.org>
895 * xdisp.c (redisplay_window): If cursor row is not fully visible
896 after recentering, and scroll-conservatively is set to a large
897 number, scroll window by a few more lines to make the cursor fully
898 visible and out of scroll-margin. (Bug#10105)
899 (start_display): Don't move to the next line if the display should
900 start at a newline that is part of a display vector or an overlay
903 2011-11-24 Juri Linkov <juri@jurta.org>
905 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
906 after the `MagickPingImage' call. (Bug#10112)
908 2011-11-23 Chong Yidong <cyd@gnu.org>
910 * window.c (Fcoordinates_in_window_p): Accept only live windows.
912 2011-11-23 Martin Rudalics <rudalics@gmx.at>
914 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
915 making another buffer current. (Bug#10114)
917 2011-11-23 Glenn Morris <rgm@gnu.org>
919 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
921 2011-11-23 Chong Yidong <cyd@gnu.org>
923 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
926 2011-11-22 Eli Zaretskii <eliz@gnu.org>
928 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
929 and header-lines, as they don't have one computed for them.
932 * .gdbinit (prow): Make displayed values more self-explaining.
935 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
937 * process.c (wait_reading_process_output): Fix asynchrounous
938 GnuTLS socket handling on some versions of the GnuTLS library.
939 (wait_reading_process_output): Add comment and URL.
941 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
943 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
945 2011-11-21 Chong Yidong <cyd@gnu.org>
947 * window.c (Fnext_window, Fprevious_window): Doc fix.
949 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
951 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
953 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
955 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
957 2011-11-20 Martin Rudalics <rudalics@gmx.at>
959 * window.c (Fset_window_combination_limit): Rename argument
961 (Vwindow_combination_limit): Remove "status" from doc-string.
963 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
965 * m/ibms390.h: Remove.
966 * m/ibms390x.h: Don't include "ibms390.h".
968 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
970 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
971 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
973 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
975 * casetab.c (Fset_case_table):
976 * charset.c (Fcharset_after): Fix typos.
978 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
980 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
981 Otherwise, valgrind does not work on some platforms.
982 Problem reported by Andreas Schwab in
983 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
984 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
985 is set, removing the need for VIRT_ADDRESS_VARIES.
986 (PURE_P): Use a more-efficient implementation that needs just one
987 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
988 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
989 to 4 (xorl, subq, cmpq, setbe).
990 * alloc.c (pure): Always extern now, since that's the
991 VIRT_ADDR_VARIES behavior.
992 (PURE_POINTER_P): Use a single comparison, not two, for
993 consistency with the new puresize.h.
994 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
995 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
996 Remove VIRT_ADDR_VARIES no longer needed.
998 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1000 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1001 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1002 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1003 behave as if the cursor position were at the window margin.
1005 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1006 and the cursor position is out of bounds, behave as if the cursor
1007 position were at the window margin. (Bug#10075)
1009 2011-11-18 Chong Yidong <cyd@gnu.org>
1011 * window.c (Fwindow_combination_limit): Make first argument
1012 non-optional, since it is meaningless for live windows like the
1015 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1017 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1019 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1021 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1022 (graft_intervals_into_buffer): Simplify.
1024 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1026 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1027 hash values of the two rows.
1028 (copy_row_except_pointers): Preserve the used[] arrays and the
1029 hash values of the two rows. (Bug#10035)
1030 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1032 * xdisp.c (row_hash): New function, body extracted from
1033 compute_line_metrics.
1034 (compute_line_metrics): Call row_hash, instead of computing the
1037 * dispnew.c (verify_row_hash): Call row_hash for computing the
1038 hash code of a row, instead of duplicating code from xdisp.c.
1040 * dispextern.h (row_hash): Add prototype.
1042 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1044 * frame.c (delete_frame): Don't delete the terminal when the last
1045 X frame is closed if emacs is built with GTK toolkit.
1047 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1049 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1051 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1053 * window.c (Vwindow_splits): Rename to
1054 Vwindow_combination_resize. Suggested by Juri Linkov.
1055 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1058 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1060 * nsfns.m (Fns_font_name):
1061 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1063 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1065 * window.h (window): Rename slot "nest" to "combination_limit".
1066 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1067 (Fset_window_nest): Rename to Fset_window_combination_limit.
1068 (Vwindow_nest): Rename to Vwindow_combination_limit.
1069 (recombine_windows, make_parent_window, make_window)
1070 (Fsplit_window_internal, saved_window)
1071 (Fset_window_configuration, save_window_save): Rename all
1072 occurrences of window_nest to window_combination_limit.
1074 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1076 * image.c (imagemagick_load_image): Fix typo.
1078 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1080 * xdisp.c (display_line): Move the call to
1081 highlight_trailing_whitespace before the call to
1082 compute_line_metrics, since the latter needs to see the final
1083 faces of all the glyphs to compute ROW's hash value.
1084 Fixes assertion violations in row_equal_p. (Bug#10035)
1086 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1088 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1089 just return (bug#10044).
1091 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1093 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1094 with user-defined heap size. Bump the default size of the temacs
1095 heap to 27MB, to avoid memory warning when running temacs.
1096 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1098 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1099 current_matrix and desired_matrix. (Bug#9990)
1100 (verify_row_hash) [XASSERTS]: New function.
1101 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1102 that the hash value of glyph rows is correct.
1104 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1106 * window.h (window): Remove splits slot.
1107 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1108 (Fdelete_other_windows_internal, make_parent_window)
1109 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1110 (Fset_window_configuration, save_window_save): Don't deal with
1111 split status of windows.
1112 (saved_window): Remove splits slot.
1113 (Vwindow_splits): Rewrite doc-string.
1115 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1117 * xfns.c (unwind_create_frame):
1118 * nsfns.m (unwind_create_frame):
1119 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1120 Vframe_list (Bug#9999).
1122 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1124 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1126 2011-11-11 Kenichi Handa <handa@m17n.org>
1128 * callproc.c (Fcall_process): Set the member dst_multibyte of
1131 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1133 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1134 avoid a crash (bug#9496).
1136 2011-11-09 Chong Yidong <cyd@gnu.org>
1138 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1139 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1141 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1143 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1145 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1147 Avoid some portability problems by eschewing 'extern inline' functions.
1148 The trivial performance wins aren't worth the portability hassles; see
1149 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1152 (window_box_width, window_box_left, window_box_left_offset)
1153 (window_box_right, window_box_right_offset): Undo previous change,
1154 by removing the "extern"s.
1155 * intervals.c (adjust_intervals_for_insertion)
1156 (adjust_intervals_for_deletion): Undo previous change,
1157 making these static again.
1158 (offset_intervals, temp_set_point_both, temp_set_point)
1159 (copy_intervals_to_string): No longer inline.
1160 * xdisp.c (window_text_bottom_y, window_box_width)
1161 (window_box_height, window_box_left_offset)
1162 (window_box_right_offset, window_box_left, window_box_right)
1163 (window_box): No longer inline.
1165 2011-11-08 Chong Yidong <cyd@gnu.org>
1167 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1168 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1169 Signal an error if not a live window.
1170 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1171 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1173 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1175 * lisp.h (syms_of_abbrev): Remove declaration.
1176 Reported by CHENG Gao <chenggao@royau.me>.
1178 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1180 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1181 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1182 of temacs in GUI mode.
1184 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1186 * window.h: Declare delete_all_child_windows instead of
1187 delete_all_subwindows.
1188 * window.c (Fwindow_nest, Fset_window_nest)
1189 (Fset_window_new_total, Fset_window_new_normal)
1190 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1191 (delete_all_subwindows): Rename to delete_all_child_windows.
1192 (Fdelete_other_windows_internal, Fset_window_configuration):
1193 Call delete_all_child_windows instead of delete_all_subwindows.
1194 * frame.c (delete_frame): Call delete_all_child_windows instead
1195 of delete_all_subwindows.
1197 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1199 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1200 This is also needed for porting to any host where GC_MARK_STACK is
1201 not GC_MAKE_GCPROS_NOOPS.
1202 (which_symbols): Use it.
1204 2011-11-07 Kenichi Handa <handa@m17n.org>
1206 * coding.c (coding_set_destination): Check coding->src_pos only
1207 when coding->src_object is a buffer (bug#9910).
1209 * process.c (send_process): Set the member src_multibyte of coding
1210 to 0 (bug#9911) when sending a unibyte text.
1212 * callproc.c (Fcall_process): Set the member src_multibyte of
1213 process_coding to 0 (bug#9912).
1215 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1217 * xmenu.c (cleanup_widget_value_tree): New function.
1218 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1219 calling free_menubar_widget_value_tree directly (Bug#9830).
1221 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1223 Fix some portability problems with 'inline'.
1224 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1225 (window_box_width, window_box_left, window_box_left_offset)
1226 (window_box_right, window_box_right_offset): Declare extern.
1227 Otherwise, these inline functions do not conform to C99 and
1228 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1229 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1230 * intervals.c (adjust_intervals_for_insertion)
1231 (adjust_intervals_for_deletion): Now extern, because otherwise the
1232 extern inline functions 'offset_intervals' couldn't refer to it.
1233 (static_offset_intervals): Remove.
1234 (offset_intervals): Rewrite using the old contents of
1235 static_offset_intervals. The old version didn't conform to C99
1236 because an extern inline function contained a reference to an
1237 identifier with static linkage.
1239 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1241 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1244 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1246 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1247 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1248 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1249 return Qleft_to_right.
1251 2011-11-06 Chong Yidong <cyd@gnu.org>
1253 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1254 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1255 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1256 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1257 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1258 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1259 (Fwindow_vscroll): Doc fix.
1260 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1261 argument, since it makes no sense to pass a live window and for
1262 consistency with window-child.
1264 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1266 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1269 2011-11-05 Jason Rumney <jasonr@gnu.org>
1271 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1272 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1274 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1275 bitwise arithmetic preventing use of unicode-sip and non-truetype
1278 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1280 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1283 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1284 initialization code to keep similarity to xfns.c after changes
1287 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1289 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1290 (unwind_create_frame): New function (Bug#9943).
1291 (Fx_create_frame): Restructure code to be more similar to the one in
1292 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1293 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1294 Move terminal->reference_count++ just before making the frame official
1297 * nsterm.m (x_free_frame_resources): New function.
1298 (x_destroy_window): Move code to x_free_frame_resources.
1300 * xfns.c (unwind_create_frame): Fix comment.
1301 (Fx_create_frame, x_create_tip_frame):
1302 Move terminal->reference_count++ just before making the frame
1303 official. Move initialization of image_cache_refcount and
1304 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1306 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1308 Support MSVC build with newer versions of Visual Studio.
1309 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1310 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1313 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1314 which are not supported by MSVC.
1315 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1316 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1318 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1320 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1322 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1324 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1326 Support MSVC build with newer versions of Visual Studio.
1327 * w32.c: Don't include w32api.h for MSVC.
1328 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1330 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1331 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1332 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1333 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1335 (alloca) [_MSC_VER]: Define to _alloca.
1337 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1339 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1341 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (note_mouse_highlight): If either of
1344 previous/next-single-property-change returns nil, treat that as
1345 the beginning or the end of the buffer. (Bug#9955)
1347 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1349 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1350 label is not null (Bug#9951).
1351 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1354 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1356 * window.c (Fwindow_body_size): Mention in the doc string that the
1357 return value is in frame's canonical units. (Bug#9949)
1359 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1361 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1363 * w32fns.c (unwind_create_frame): If needed, free the glyph
1364 matrices of the partially constructed frame. (Bug#9943)
1365 * xfns.c (unwind_create_frame): Likewise.
1367 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1369 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1370 Don't stop backward scan on the continuation glyph, even though
1371 its CHARPOS is positive.
1372 (mouse_face_from_buffer_pos, note_mouse_highlight):
1373 Rename cover_string to disp_string.
1375 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1377 * window.c (temp_output_buffer_show): Don't use
1378 Vtemp_buffer_show_specifiers.
1379 (Vtemp_buffer_show_specifiers): Remove unused variable.
1381 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1383 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1384 past the beginning of the current glyph matrix.
1386 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1388 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1389 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1390 HAVE_GTK3 (Bug#9869).
1392 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1393 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1395 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1397 * xterm.c: Declare x_handle_net_wm_state to return int.
1398 (handle_one_xevent): Check if we are iconified but don't have
1399 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1400 (get_current_wm_state): Return non-zero if not hidden,
1401 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1402 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1403 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1404 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1406 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1408 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1409 so that this new function doesn't get optimized away by a
1410 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1412 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1414 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1416 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1418 Fix the `xbytecode' command.
1419 * .gdbinit (xprintbytestr): New command.
1420 (xwhichsymbols): Rename from `which'; all callers changed.
1421 (xbytecode): Print the byte-code string as well.
1423 2011-10-29 Kim Storm <storm@cua.dk>
1425 * alloc.c (which_symbols): New function.
1427 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1429 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1432 2011-10-29 Glenn Morris <rgm@gnu.org>
1434 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1435 Not clear what it was for, and it causes various bugs. (Bug#9839)
1437 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1439 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1440 possible random value that matches one of those tested as
1441 condition to clear the mouse face.
1443 2011-10-28 Chong Yidong <cyd@gnu.org>
1445 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1447 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1449 * window.c (make_window): Initialize phys_cursor_on_p.
1451 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1453 * lisp.h (struct Lisp_Symbol): Update comments.
1455 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1457 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1459 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1461 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1462 <oslsachem@gmail.com> for helping to debug this.
1464 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1465 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1466 (g_b_init_get_glyph_outline_w): New static variables.
1467 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1468 (GetGlyphOutlineW_Proc): New typedefs.
1469 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1470 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1472 (w32font_open_internal, compute_metrics):
1473 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1474 instead of calling the "wide" APIs directly.
1476 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1478 * w32.h (syms_of_w32font): Add prototype.
1480 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1482 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1483 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1484 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1485 (Fmove_to_window_line): Doc fix.
1487 2011-10-27 Chong Yidong <cyd@gnu.org>
1489 * process.c (make_process): Set gnutls_state to NULL.
1491 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1492 non-NULL, regardless of GNUTLS_INITSTAGE.
1493 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1494 an error. Set process slots as soon as we allocate them.
1496 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1498 2011-10-27 Chong Yidong <cyd@gnu.org>
1500 * gnutls.c (emacs_gnutls_deinit): New function.
1501 Deallocate credentials structures as well as calling gnutls_deinit.
1502 (Fgnutls_deinit, Fgnutls_boot): Use it.
1504 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1505 (deactivate_process): Call emacs_gnutls_deinit.
1507 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1509 * image.c (x_create_x_image_and_pixmap):
1510 * w32.c (sys_rename, w32_delayed_load):
1511 * w32font.c (fill_in_logfont):
1512 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1514 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1516 * w32fns.c (w32_default_color_map): New function,
1517 extracted from Fw32_default_color_map.
1518 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1520 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1522 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1524 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1526 * keyboard.c (test_undefined): New function (bug#9751).
1527 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1529 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1531 * sysdep.c (init_sys_modes): Fix the check for the controlling
1532 terminal (Bug#6649).
1534 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1536 * dispextern.h (struct bidi_it): New member next_en_type.
1538 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1539 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1540 current character, check also for next_en_type being WEAK_EN.
1541 (bidi_resolve_weak): Don't enter the expensive loop if the current
1542 position is before next_en_pos. Record the bidi type of the first
1543 non-ET, non-BN character we find, in addition to its position.
1544 (bidi_level_of_next_char): Invalidate next_en_type when
1545 next_en_pos is over-stepped.
1547 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1549 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1550 * editfns.c: Rewrite current-time-zone so that it invokes
1551 the equivalent of (format-time-string "%Z") to get the time zone name.
1552 This fixes a bug when the time zone name contains characters that
1553 need converting from the system time locale to Emacs internal format.
1554 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1555 that patch fixed format-time-string to do the conversion, but
1556 I forgot to fix current-time-zone.
1557 (format_time_string): New function, containing most of
1558 what Fformat_time_string used to contain.
1559 (Fformat_time_string): Rewrite in terms of format_time_string.
1560 This doesn't change this function's behavior.
1561 (current-time-zone): Rewrite to use format_time_string.
1562 This fixes the bug reported by Michael Schierl in
1563 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1564 Jason Rumney's 2007-06-07 change worked around this bug, but
1566 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1568 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1570 * xdisp.c (start_display): If the character at POS is displayed
1571 via a display vector, reset IT->current.dpvec_index to zero.
1572 (try_window_reusing_current_matrix): If a line ends in a display
1573 vector or the next line starts in a display vector, continue
1574 redrawing the window even though the character position of
1575 start_row was reached.
1578 2011-10-18 Chong Yidong <cyd@gnu.org>
1580 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1581 with nobreak-char-display too.
1583 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1585 Fix part 3 of bug#9771.
1586 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1587 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1588 non-neutral characters if the current character is a paragraph
1589 separator (a.k.a. Newline). This avoids running the same
1590 expensive loop twice, once when we consume the preceding newline
1591 and the other time when the line actually needs to be displayed.
1592 Avoid the loop when we see neutrals on the base embedding level
1593 following a character whose directionality is the same as the
1594 paragraph's. This avoids running the expensive loop when a line
1595 ends in a long sequence of neutrals, like control characters.
1596 Add assertion against STRONG_AL type. Slightly rearrange code
1597 that determines the type of a neutral given the first non-neutral
1599 (bidi_level_of_next_char): Set next_en_pos to zero when
1600 invalidating its info.
1602 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1604 * xdisp.c (push_display_prop): Determine whether to record string
1605 or buffer position by IT->string, not by IT->method. Allow
1606 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1607 (move_it_vertically_backward): Don't look for character position
1608 immediately after the newline when in a continuation line.
1611 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1613 * window.c (coordinates_in_window): Rewrite and delabelize
1614 vertical border check. (Bug#5357) (Bug#9618)
1616 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1618 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1619 errors in XSetWindowBorder (bug#9310).
1621 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1623 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1624 avoid crash when xmalloc overrun checking is enabled.
1626 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1628 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1629 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1630 cursor motion with <left> and <right> arrow keys.
1632 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1633 some callers set that themselves.
1635 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1637 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1638 display string and the previous row comes from the same string and
1639 is empty. (Bug#9739) (Bug#9738)
1641 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1643 * doc.c (get_doc_string): Encode file name (bug#9735).
1645 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1647 * bidi.c (bidi_level_of_next_char):
1648 * xdisp.c (get_visually_first_element): Remove old incorrect
1649 comments regarding the Unicode Line Separator character.
1651 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1653 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1655 * alloc.c (Fgc_status): Do not access beyond zombies array
1656 boundary if nzombies > MAX_ZOMBIES.
1657 * alloc.c (dump_zombies): Add missing format specifier.
1659 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1661 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1662 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1664 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1665 Some packages use them to denote characters with modifiers.
1667 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1669 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1670 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1671 matching a pp-number. Rename parameter var to var1.
1673 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1675 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1677 2011-10-08 Glenn Morris <rgm@gnu.org>
1679 * callint.c (Fcall_interactively): Give a more explicit error for the
1680 'c' case with a non-character input. (Bug#8479)
1682 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1684 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1686 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1687 lines that are hscrolled on the left.
1689 * dispnew.c (buffer_posn_from_coords): Account for a possible
1690 presence of header-line. (Bug#4426)
1692 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1694 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1695 Don't advertise functionality which we discourage or doesn't work.
1697 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1699 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1700 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1701 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1702 this makes Emacs dump core during garbage collection on rare
1703 occasions. sizeof is obviously inferior to offsetof here, so
1704 stick with offsetof.
1705 (GC_POINTER_ALIGNMENT): New macro.
1706 (mark_memory): Omit 3rd (offset) arg; caller changed.
1707 Don't assume EMACS_INT alignment is the same as pointer alignment.
1709 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1711 * keyboard.c (read_key_sequence_remapped): New var.
1712 (read_key_sequence): Compute remapping in the right buffer.
1713 (command_loop_1): Use read_key_sequence's remapping directly.
1715 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1717 * dired.c (file_name_completion): Don't expand file name.
1718 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1719 before checking file name handler.
1721 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1722 they've been requested explicitly (bug#9591).
1724 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1726 * keymap.c (Fsingle_key_description): Use make_specified_string
1727 instead of build_string to build string from push_key_description.
1730 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1732 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1733 This fixes a Y2038 bug on 64-bit hosts.
1734 * buffer.c (reset_buffer):
1735 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1736 (Fclear_buffer_auto_save_failure):
1737 Use 0, not -1, to represent an unset failure time, since time_t
1738 might not be signed.
1740 Remove dependency on glibc malloc internals.
1741 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1742 Move back here from lisp.h, but with their new implementations.
1743 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1744 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1745 * charset.c (charset_table_init): New static var.
1746 (syms_of_charset): Use it instead of xmalloc. This removes a
1747 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1748 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1749 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1750 Move back to alloc.c.
1751 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1752 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1754 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1756 * nsterm.m (windowDidResize): Call x_set_window_size only when
1757 ns_in_resize is true. Otherwise set pixelwidth/height and
1758 call change_frame_size (Bug#9628).
1760 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1762 Port --enable-checking=all to Fedora 14 x86-64.
1763 * charset.c (syms_of_charset): Also account for glibc malloc's
1764 internal overhead when calculating the initial malloc maximum.
1766 Port --enable-checking=all to Fedora 14 x86.
1767 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1769 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1770 (overrun_check_realloc, overrun_check_free):
1771 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1772 That way, xmalloc returns a properly-aligned pointer even if
1773 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1774 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1775 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1776 into account when calculating the initial malloc maximum.
1777 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1778 Move here from alloc.c, so that charset.c can use it too.
1779 Properly align; the old code wasn't right for common 32-bit hosts
1780 when configured with --enable-checking=all.
1781 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1782 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1784 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1786 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1789 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1791 * xdisp.c (compute_display_string_end): If there's no display
1792 string at CHARPOS, return -1.
1794 * bidi.c (bidi_fetch_char): When compute_display_string_end
1795 returns a negative value, treat the character as a normal
1796 character not covered by a display string. (Bug#9624)
1798 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1800 * lread.c (Fread_from_string): Fix typo in docstring.
1802 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1804 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1805 newline, reseat the iterator instead of bidi-iterating there one
1806 character at a time. (Bug#9610)
1807 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1808 TO_CHARPOS if the bidi iterator is at base embedding level.
1810 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1812 * lread.c (readevalloop): Use correct code for NBSP.
1813 (read1): Likewise. (Bug#9608)
1815 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1817 * dbusbind.c (Fdbus_register_signal): When service is not
1818 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1820 2011-09-25 Glenn Morris <rgm@gnu.org>
1822 * buffer.c (truncate-lines): Doc fix.
1824 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1826 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1827 (Fset_window_next_buffers): Doc fix.
1829 2011-09-24 Glenn Morris <rgm@gnu.org>
1831 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1833 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1835 Fix minor problems found by static checking.
1836 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1837 * indent.c (Fvertical_motion): Fix == vs = typo.
1839 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1841 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1842 Default value is now t. Doc fix.
1844 * indent.c (Fvertical_motion): Compute and apply the overshoot
1845 logic when moving up, not only when moving down. Fix the
1846 confusing name and values of the it_overshoot_expected variable;
1847 logic changes accordingly. (Bug#9254) (Bug#9549)
1849 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1850 CHARPOS is covered by a display string which includes newlines.
1851 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1852 is covered by a display string with embedded newlines.
1854 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1856 * dbusbind.c (Fdbus_register_signal): Add match rule to
1857 Vdbus_registered_objects_table. (Bug#9581)
1858 (Fdbus_register_method, Vdbus_registered_objects_table):
1861 2011-09-24 Jim Meyering <meyering@redhat.com>
1863 do not ignore write error for any output size
1864 The previous change was incomplete.
1865 While it makes emacs --batch detect the vast majority of stdout
1866 write failures, errors were still ignored whenever the output size is
1867 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1868 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1869 && echo FAIL: ignored write error
1870 FAIL: ignored write error
1871 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1872 && echo FAIL: ignored write error
1873 FAIL: ignored write error
1874 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1876 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1878 * emacs.c (Fkill_emacs): In noninteractive mode exit
1879 non-successfully if a write error occurred on stdout. (Bug#9574)
1881 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1883 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1886 * dispextern.h (struct it): Update the comment documenting what
1889 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1891 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1892 a display string, extend search for cursor position to end of row.
1893 (find_row_edges): If the row ends in a newline from a display
1894 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1895 Handle the case of a display string with multiple newlines.
1896 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1897 non-empty line. Fixes confusing cursor motion with arrow keys at
1898 the beginning of a line that starts with whitespace.
1900 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1902 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1905 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1907 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1910 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1912 * xdisp.c (display_line): Record maximum and minimum buffer
1913 positions even if no glyphs were produced (e.g., by a zero-width
1914 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1915 buffer positions that will be removed from the glyph row because
1917 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1918 column is beyond frame width: don't subtract 1 "pixel" when
1919 computing width of the stretch.
1920 (reseat_at_next_visible_line_start): Undo the change made on
1921 2011-09-17 that saved paragraph information and restored it after
1922 the call to `reseat'. (Bug#9545)
1924 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1926 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1927 and turn window cursor on if cleared (Bug#9415).
1929 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1931 * search.c (boyer_moore): Take unibyte characters from pattern
1932 literally. (Bug#9458)
1934 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1936 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1938 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1940 Fix minor problem found by static checking.
1941 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1942 initialized, to pacify gcc -Wuninitialized.
1944 * fileio.c: Report proper errno when syscall falls.
1945 (Finsert_file_contents): Save and restore errno,
1946 so that report_file_error outputs the correct diagnostic.
1947 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1949 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1951 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1953 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1955 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1956 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1958 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1960 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1961 about the current paragraph and restore it after the call to reseat.
1963 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1964 (bidi_find_paragraph_start): Search back for paragraph beginning
1965 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1966 (bidi_move_to_visually_next): Only trigger paragraph-related
1967 computations when the last character is a newline or at EOB, not
1968 just any NEUTRAL_B. (Bug#9470)
1970 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1971 truncated lines if point is covered by a display string. (Bug#9524)
1973 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1975 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1976 (cons_to_x_long): New function.
1977 (lisp_data_to_selection_data): Use it. Correct the test for
1978 short-versus-long data; it was negated. Break out of vector
1979 loop, for efficiency, when a long datum is discovered.
1981 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1983 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1985 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1987 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1988 GCC PR/17406) by declaring this function with external scope.
1990 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1992 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1993 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1995 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1997 * editfns.c (Fformat): Correctly handle text properties on "%%".
1999 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2001 * xterm.c (x_draw_composite_glyph_string_foreground):
2002 * w32term.c (x_draw_composite_glyph_string_foreground):
2003 * term.c (encode_terminal_code):
2004 * composite.c (composition_update_it, get_composition_id):
2005 * xdisp.c (get_next_display_element)
2006 (fill_composite_glyph_string): Add comments about special meaning
2007 of TAB characters in a composition.
2009 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2011 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2012 This occurs when processing a multibyte format.
2013 Problem reported by Wolfgang Jenker.
2015 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2017 * xdisp.c (try_cursor_movement): Only check for exact match if
2018 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2020 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2022 Remove unused external symbols.
2023 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2024 * xdisp.c (calc_pixel_width_or_height): Now static.
2025 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2026 * indent.c (check_display_width):
2027 * w32term.c: Fix comment to match code.
2028 * xterm.c, xterm.h (x_catching_errors): Remove.
2030 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2032 * xselect.c: Use signed conversions more consistently (Bug#9498).
2033 (selection_data_to_lisp_data): Assume incoming selection data are
2034 signed integers, not unsigned. This is to be consistent with
2035 outgoing selection data, which was modified to use signed integers
2036 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2037 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2038 expects long, not unsigned long.
2040 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2043 computation of loop end. Reported by Johan Bockgård
2046 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2048 * frame.c (Fother_visible_frames_p): Function deleted.
2050 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2052 * indent.c (compute_motion): Process display vector front to back
2053 rather than the other way around. (Bug#2496)
2055 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2057 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2059 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2061 * minibuf.c (Fread_from_minibuffer): Doc fix.
2063 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2065 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2066 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2068 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2070 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2071 value for non-existent files.
2073 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2075 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2076 set its "size" to -1. This will set the modtime_size field of
2077 the corresponding buffer to -1, which is what
2078 verify-visited-file-modtime expects for files that do not exist.
2081 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2083 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2085 * lisp.h: ... from here. push_key_description is no longer
2086 defined in keyboard.c, so its declaration should not be in
2087 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2088 logically belongs with push_key_description.
2090 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2092 * buffer.h: Include <sys/types.h> instead of <time.h>.
2093 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2094 Problem reported by Herbert J. Skuhra.
2096 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2098 * xml.c (parse_region): Make the parsing work for
2099 non-comment-starting XML files again (bug#9144).
2101 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2103 * image.c (gif_load): Fix calculation of bottom and right corner.
2106 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2108 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2109 redisplay in small windows.
2111 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2113 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2115 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2117 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2118 Operate on live windows only.
2120 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2122 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2124 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2126 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2127 only under bidi iteration.
2129 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2131 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2133 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2135 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2136 Without this fix, the command to link temacs failed due to an
2137 undefined symbol __builtin_isnan. This is because
2138 /usr/include/iso/math_c99.h #defines isnan(x) to
2139 __builtin_isnan(x), but the bundled gcc, which identifies itself
2140 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2142 * floatfns.c (isnan): #undef, and then #define to a clone of
2144 (Fisnan): Always define, since it's always available now.
2145 (syms_of_floatfns): Always define isnan at the Lisp level.
2147 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2149 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2151 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2153 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2154 The previous code assumed that file offsets (off_t values) fit in
2155 EMACS_INT variables, which is not true on typical 32-bit hosts.
2156 The code messed up by falsely reporting buffer overflow in cases
2157 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2158 when "big" contains more than 2**29 bytes, even though this
2159 inserts just one byte and does not overflow the buffer.
2160 (Finsert_file_contents): Store file offsets as off_t
2161 values, not as EMACS_INT values. Check for overflow when
2162 converting between EMACS_INT and off_t. When checking for
2163 buffer overflow or for overlap, take the offsets into account.
2164 Don't use EMACS_INT for small values where int suffices.
2165 When checking for overlap, fix a typo: ZV was used where
2166 ZV_BYTE was intended.
2167 (Fwrite_region): Don't assume off_t fits into 'long'.
2168 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2170 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2172 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2174 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2176 sprintf-related integer and memory overflow issues (Bug#9412).
2178 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2179 (esprintf, exprintf, evxprintf): New functions.
2180 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2181 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2182 (modify_event_symbol): Do not assume that the length of
2183 name_alist_or_stem is safe to alloca and fits in int.
2184 (Fexecute_extended_command): Likewise for function name and binding.
2185 (Frecursion_depth): Wrap around reliably on integer overflow.
2186 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2187 since some callers pass EMACS_INT values.
2188 (Fsingle_key_description): Don't crash if symbol name contains more
2189 than MAX_ALLOCA bytes.
2190 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2191 (get_minibuffer): Arg is now EMACS_INT, not int.
2192 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2193 (esprintf, exprintf, evxprintf): New decls.
2194 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2196 * dbusbind.c (signature_cat): New function.
2197 (xd_signature, Fdbus_register_signal):
2198 Do not overrun buffer; instead, report string overflow.
2200 * dispnew.c (add_window_display_history): Don't overrun buffer.
2201 Truncate instead; this is OK since it's just a log.
2203 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2204 even if the time zone offset is outlandishly large.
2205 Don't mishandle offset == INT_MIN.
2207 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2208 when creating daemon; the previous buffer-overflow check was incorrect.
2210 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2211 which has the guts of the old verror function.
2213 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2214 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2216 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2217 (font_unparse_xlfd): Don't blindly alloca long strings.
2218 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2219 fits in int, when using sprintf. Use single snprintf to count
2220 length of string rather than counting it via multiple sprintfs;
2221 that's simpler and more reliable.
2222 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2223 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2224 sprintf, in case result does not fit in int.
2226 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2227 (fontset_from_font): Print it.
2229 * frame.c (tty_frame_count): Now printmax_t, not int.
2230 (make_terminal_frame, set_term_frame_name): Print it.
2231 (x_report_frame_params): In X, window IDs are unsigned long,
2232 not signed long, so print them as unsigned.
2233 (validate_x_resource_name): Check for implausibly long names,
2234 and don't assume name length fits in 'int'.
2235 (x_get_resource_string): Don't blindly alloca invocation name;
2236 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2239 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2240 (xg_check_special_colors, xg_set_geometry):
2241 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2243 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2244 Use esprintf, not sprintf, in case result does not fit in int.
2246 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2247 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2248 it as a large positive number.
2249 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2250 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2252 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2253 in case result does not fit in int.
2255 * print.c (float_to_string): Detect width overflow more reliably.
2256 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2257 buffer overrun. Don't assume list length fits in 'int'. Treat
2258 print length of 0 as 0, not as infinity; to be consistent with other
2259 uses of print length in this function. Don't overflow print length
2260 index. Don't assume hash table size fits in 'long', or that
2261 vectorlike size fits in 'unsigned long'.
2263 * process.c (make_process): Use printmax_t, not int, to format
2264 process-name gensyms.
2266 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2268 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2269 to avoid potential buffer overrun.
2271 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2272 if X resource line is longer than 512 bytes.
2274 * xfns.c (x_window): Make sprintf buffer a bit bigger
2275 to avoid potential buffer overrun.
2277 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2279 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2281 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2283 Integer overflow fixes for scrolling, etc.
2284 Without these, Emacs silently mishandles large integers sometimes.
2285 For example, "C-u 4294967297 M-x recenter" was treated as if
2286 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2288 * xdisp.c (try_window_id): Check Emacs fixnum range before
2289 converting to 'int'.
2291 * window.c (window_scroll_line_based, Frecenter):
2292 Check that an Emacs fixnum is in range before assigning it to 'int'.
2293 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2294 values converted from Emacs fixnums.
2295 (Frecenter): Don't wrap around a line count if it is out of 'int'
2296 range; instead, treat it as an extreme value.
2297 (Fset_window_configuration, compare_window_configurations):
2298 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2300 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2301 that can exceed INT_MAX. Check that EMACS_INT value is in range
2302 before assigning it to the (possibly-narrower) index.
2303 (match_limit): Don't assume that a fixnum can fit in 'int'.
2305 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2308 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2309 (Fvertical_motion): Don't wrap around LINES values that don't fit
2310 in 'int'. Instead, treat them as extreme values. This is good
2311 enough for windows, which can't have more than INT_MAX lines anyway.
2313 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2315 * Require libxml/parser.h to avoid compilation warning.
2317 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2319 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2320 since this reportedly can destroy thread storage.
2322 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2324 * syntax.c (find_defun_start): Update all cache variables if
2325 exiting early (Bug#9401).
2327 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2329 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2331 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2332 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2333 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2335 * term.c (tty_append_glyph): New function.
2336 (produce_stretch_glyph): Static function and its prototype deleted.
2338 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2341 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2343 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2344 when checking :margin (Bug#9390).
2345 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2346 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2347 so that the name doesn't mislead. All uses changed.
2349 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2351 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2354 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2356 * xdisp.c (move_it_to): Don't bail out early when reaching
2357 position beyond to_charpos, if we are scanning backwards.
2358 (move_it_vertically_backward): When DY == 0, make sure we get to
2359 the first character in the line after the newline.
2361 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2363 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2364 (ccl_driver): Do not generate an out-of-range pointer.
2365 (Fccl_execute_on_string): Remove unnecessary check for
2366 integer overflow, noted by Stefan Monnier in
2367 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2368 Remove a FIXME that didn't need fixing.
2369 Simplify the newly-introduced buffer reallocation code.
2371 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2373 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2375 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2377 Integer and memory overflow issues (Bug#9196).
2379 * doc.c (get_doc_string): Rework so that
2380 get_doc_string_buffer_size is the actual buffer size, rather than
2381 being 1 less than the actual buffer size; this makes xpalloc more
2384 * image.c (x_allocate_bitmap_record, cache_image):
2385 * xselect.c (Fx_register_dnd_atom):
2386 Simplify previous changes by using xpalloc.
2388 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2389 since either will do and ptrdiff_t is convenient with xpalloc.
2391 * charset.c (charset_table_size)
2392 (struct charset_sort_data.priority): Now ptrdiff_t.
2393 (charset_compare): Don't overflow if priorities differ greatly.
2394 (Fsort_charsets): Don't assume list length fits in int.
2395 Check for size-calculation overflow when allocating sort data.
2396 (syms_of_charset): Allocate an initial charset table that is
2397 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2399 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2401 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2402 The actual value is always <= INT_MAX, and leaving it unsigned made
2403 overflow checking harder.
2405 * dispextern.h (struct glyph_matrix.rows_allocated)
2406 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2407 with xpalloc. The values are still always <= INT_MAX.
2409 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2411 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2412 (SAFE_NALLOCA): New macro.
2414 * region-cache.c (struct boundary.pos, find_cache_boundary)
2415 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2416 (set_cache_region, invalidate_region_cache)
2417 (revalidate_region_cache, know_region_cache, region_cache_forward)
2418 (region_cache_backward, pp_cache):
2419 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2420 so that ptrdiff_t * can be passed to xpalloc.
2421 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2422 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2423 (pp_cache): Don't assume cache_len fits in int.
2424 * region-cache.h: Adjust extern decls to match.
2426 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2427 EMACS_INT, since either will do, for xpalloc.
2429 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2430 (xnmalloc, xnrealloc, xpalloc): New functions.
2432 * bidi.c (bidi_shelve_header_size): New constant.
2433 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2434 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2436 * bidi.c (bidi_cache_shrink):
2437 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2439 Don't update size of array until after memory allocation succeeds,
2440 because xmalloc/xrealloc may not return.
2441 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2442 now that we have proper integer overflow checking.
2443 (record_overlay_string, overlay_strings): Catch overflows when
2444 calculating size of overlay_str_buf.
2446 * callproc.c (Fcall_process): Check for size overflow when
2447 calculating size of args2.
2448 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2449 Normally we prefer signed values, but sticking with ptrdiff_t would
2450 require adding more-complicated checks.
2452 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2453 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2454 Redo buffer-overflow calculations to avoid integer overflow.
2455 Add a FIXME comment where memory seems to be over-allocated.
2457 * character.c (Fstring): Check for size-calculation overflow.
2459 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2460 unnecessary integer overflow. Check for size overflow.
2461 (encode_coding_object): Don't update size until xmalloc succeeds.
2463 * composite.c (get_composition_id): Check for overflow in glyph
2464 length calculations.
2466 Integer and memory overflow fixes for display code.
2467 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2468 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2469 (scrolling_window): Check for overflow in size calculations.
2470 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2471 Don't assume glyph table len fits in int.
2472 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2473 (row_table_size): Now ptrdiff_t, not int.
2474 (scrolling_window): Avoid overflow in size calculations.
2475 Don't update size until allocation succeeds.
2476 * fns.c (concat): Check for overflow in size calculations.
2477 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2478 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2479 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2481 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2482 (get_doc_string): Check for size calculation overflow.
2483 Don't update size until allocation succeeds.
2484 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2485 EMACS_INT, where ptrdiff_t will do.
2486 (Fsubstitute_command_keys): Check for string overflow.
2488 * editfns.c (set_time_zone_rule): Don't assume environment length
2490 (message_length): Now ptrdiff_t, not int.
2491 (Fmessage_box): Don't update size until allocation succeeds.
2492 Don't assume message length fits in int.
2493 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2495 * emacs.c (main): Do not reallocate argv, since there is a null at
2496 the end that can be overwritten, and this way there's no need to
2497 worry about size-calculation overflow.
2498 (sort_args): Check for size-calculation overflow.
2500 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2502 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2504 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2505 (x_set_scroll_bar_width, x_figure_window_size):
2506 Check for integer overflow.
2507 (x_set_alpha): Do not assume XINT fits in int.
2509 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2510 This is for the members text_lines, text_cols, total_lines, total_cols,
2511 where the system imposes an 'int' limit.
2513 * fringe.c (Fdefine_fringe_bitmap):
2514 Don't update size until alloc works.
2516 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2517 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2519 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2520 Check for size-calculation overflow.
2521 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2522 do, as we prefer signed integers.
2523 (id_to_widget.max_size, id_to_widget.used)
2524 (xg_store_widget_in_map, xg_remove_widget_from_map)
2525 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2526 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2527 Use and return ptrdiff_t, not int.
2528 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2529 * gtkutil.h: Change prototypes to match the above.
2531 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2532 are duplicate now that they've been promoted to lisp.h.
2533 (x_allocate_bitmap_record, x_alloc_image_color)
2534 (make_image_cache, cache_image, xpm_load):
2535 Don't update size until alloc is done.
2536 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2538 Check for size calculation overflow.
2539 (ct_colors_allocated_max): New constant.
2540 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2543 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2544 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2545 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2546 Use ptrdiff_t, not int, to count maps.
2547 (read_char_minibuf_menu_prompt): Check for overflow in size
2548 calculations. Don't update size until allocation succeeds.
2549 Redo calculations to avoid overflow.
2550 * keyboard.h: Change prototypes to match the above.
2552 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2554 (current_minor_maps): Check for size calculation overflow.
2555 * keymap.h: Change prototypes to match the above.
2557 * lread.c (read1, init_obarray): Don't update size until alloc done.
2559 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2560 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2562 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2563 Now ptrdiff_t, not int.
2564 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2565 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2567 * process.c (Fnetwork_interface_list): Check for overflow
2568 in size calculation.
2570 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2572 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2573 overflow. Don't bother calling xmalloc when xrealloc will do.
2575 * search.c (Freplace_match): Check for size calculation overflow.
2576 (Fset_match_data): Don't assume list lengths fit in 'int'.
2578 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2579 for command line length. Do not attempt to address one before the
2580 beginning of an array, as that's not portable.
2582 * term.c (max_frame_lines): Remove; unused.
2583 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2585 (encode_terminal_code, calculate_costs): Check for size
2586 calculation overflow.
2587 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2588 table lengths and related sizes. Don't update size until alloc
2589 done. Redo calculations to avoid overflow.
2590 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2592 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2593 subtracting pointers.
2594 (gobble_line): Check for overflow more carefully. Don't update size
2597 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2598 Don't update size until alloc done.
2599 Redo size calculations to avoid overflow.
2600 Check for size calculation overflow.
2601 (main) [DEBUG]: Fix typo in invoking tparam1.
2603 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2604 Use ptrdiff_t, not int, for sizes.
2605 (store_mode_line_noprop_char): Don't update size until alloc done.
2607 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2608 Use ptrdiff_t, not int, for sizes.
2609 (Finternal_make_lisp_face, cache_face):
2610 Check for size calculation overflow.
2611 (cache_face): Treat size calculation overflows as if they were
2612 memory exhaustion (the usual treatment), rather than aborting.
2614 * xfns.c (x_encode_text, x_set_name_internal)
2615 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2616 sizes, since they can exceed INT_MAX in size. Check for size
2617 calculation overflow.
2619 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2620 (xg_select): Check for size calculation overflow.
2621 Don't update size until alloc done.
2623 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2624 as sprintf is limited to int lengths.
2626 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2627 (X_LONG_MIN): New macros.
2628 Use them to make the following changes clearer.
2629 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2630 This change doesn't affect the value now, but it may help remind
2631 future maintainers not to raise the value too much later.
2632 (SELECTION_QUANTUM): Remove, replacing with ...
2633 (selection_quantum): ... new function, which avoids overflow.
2635 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2636 assumption that selection length fits in 'int'.
2637 (x_reply_selection_request, x_handle_selection_request)
2638 (x_get_window_property, receive_incremental_selection)
2639 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2640 (lisp_data_to_selection_data, clean_local_selection_data):
2641 Use ptrdiff_t, not int, to record length of selection.
2642 (x_reply_selection_request, x_get_window_property)
2643 (receive_incremental_selection, x_property_data_to_lisp):
2644 Redo calculations to avoid overflow.
2645 (x_reply_selection_request): When sending hint, ceiling it at
2646 X_LONG_MAX rather than relying on wraparound overflow to send
2648 (x_get_window_property, receive_incremental_selection)
2649 (lisp_data_to_selection_data, x_property_data_to_lisp):
2650 Check for size-calculation overflow.
2651 (x_get_window_property, receive_incremental_selection)
2652 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2653 Don't store size until memory allocation succeeds.
2654 (x_get_window_property): Plug memory leak on memory exhaustion.
2655 Don't double-block input; malloc is safe here. Don't assume 2**34
2656 - 4 fits in unsigned long. Add an xassert to check
2657 XGetWindowProperty overflow. Be more careful about overflow
2658 calculations, and distinguish size from memory overflow better.
2659 (receive_incremental_selection): When tracing, don't assume
2660 unsigned int is less than INT_MAX.
2661 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2662 harmful) conversions of unsigned short to int.
2663 (lisp_data_to_selection_data): Don't assume that integers
2664 in the range -65535 through -1 fit in an X unsigned short.
2665 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2666 result parameters unless successful. Rely on cons_to_unsigned
2667 to report problems with elements; the old code wasn't right anyway.
2668 (x_check_property_data): Check for int overflow; we cannot use
2669 a wider type due to X limits.
2670 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2672 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2674 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2675 (x_term_init): Check for size calculation overflow.
2676 (x_color_cells): Don't store size until memory allocation succeeds.
2677 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2678 Don't assume alloca size is less than MAX_ALLOCA.
2679 (x_term_init): Don't assume length fits in int (sprintf is limited
2682 Use ptrdiff_t for composition IDs.
2683 * character.c (lisp_string_width):
2684 * composite.c (composition_table_size, n_compositions)
2685 (get_composition_id, composition_gstring_from_id):
2686 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2687 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2688 * window.c (Frecenter):
2689 Use ptrdiff_t, not int, for composition IDs.
2690 * composite.c (get_composition_id): Check for integer overflow.
2691 * composite.h: Adjust prototypes to match the above changes.
2693 Use ptrdiff_t for hash table indexes.
2694 * category.c (hash_get_category_set):
2695 * ccl.c (ccl_driver):
2696 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2697 * coding.c (coding_system_charset_list, detect_coding_system):
2698 * coding.h (struct coding_system.id):
2699 * composite.c (get_composition_id, gstring_lookup_cache):
2700 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2701 * image.c (xpm_get_color_table_h):
2702 * lisp.h (hash_lookup, hash_put):
2703 * minibuf.c (Ftest_completion):
2704 Use ptrdiff_t for hash table indexes, not int (which is too
2705 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2706 32-bit --with-wide-int hosts).
2708 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2709 Add a FIXME comment about memory leaks.
2710 (syms_of_charset): Don't assume xmalloc returns.
2712 Don't assume that stated character widths fit in int.
2713 * character.c (Fchar_width, c_string_width, lisp_string_width):
2714 * character.h (CHAR_WIDTH):
2715 * indent.c (MULTIBYTE_BYTES_WIDTH):
2716 Use sanitize_char_width to avoid undefined and/or bad behavior
2717 with outlandish widths.
2718 * character.h (sanitize_tab_width): Rename from sanitize_width,
2719 now that we have two such functions. All uses changed.
2720 (sanitize_char_width): New inline function.
2722 Don't assume that tab-width fits in int.
2723 * character.h (sanitize_width): New inline function.
2724 (SANE_TAB_WIDTH): New macro.
2725 (ASCII_CHAR_WIDTH): Use it.
2726 * indent.c (sane_tab_width): Remove. All uses replaced by
2727 SANE_TAB_WIDTH (current_buffer).
2728 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2730 * fileio.c: Integer overflow issues with file modes.
2731 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2733 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2734 Remove unreachable code.
2735 (read_hex, load_charset_map_from_file): Check for integer overflow.
2737 * xterm.c: Don't go over XClientMessageEvent limit.
2738 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2739 (x_send_scroll_bar_event): Likewise. Check that the size does not
2740 exceed limits imposed by XClientMessageEvent, as well as the usual
2741 ptrdiff_t and size_t limits.
2743 * keyboard.c: Overflow, signedness and related fixes.
2744 (make_lispy_movement): Use same integer type in forward decl
2745 that is used in the definition.
2746 (read_key_sequence, keyremap_step):
2747 Change bufsize argument back to int, undoing my 2011-03-30 change.
2748 We prefer signed types, and int is wide enough here.
2749 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2750 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2751 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2752 length, not size_t. Use ptrdiff_t for index, not int.
2753 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2754 possibility of integer overflow.
2756 Overflow, signedness and related fixes for images.
2758 * dispextern.h (struct it.stack[0].u.image.image_id)
2759 (struct_it.image_id, struct image.id, struct image_cache.size)
2760 (struct image_cache.used, struct image_cache.ref_count):
2761 * gtkutil.c (update_frame_tool_bar):
2762 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2763 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2764 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2765 * nsmenu.m (update_frame_tool_bar):
2766 * xdisp.c (calc_pixel_width_or_height):
2767 * xfns.c (image_cache_refcount):
2768 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2769 on typical 64-bit hosts.
2771 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2772 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2773 Omit unnecessary casts to int.
2774 (parse_image_spec): Check that integers fall into 'int' range
2775 when the callers expect that.
2776 (image_ascent): Redo ascent calculation to avoid int overflow.
2777 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2778 (lookup_image): Remove unnecessary tests.
2779 (xbm_image_p): Locals are now of int, not EMACS_INT,
2780 since parse_image_check makes sure they fit into int.
2781 (png_load, gif_load, svg_load_image):
2782 Prefer int to unsigned where either will do.
2783 (tiff_handler): New function, combining the cores of the
2784 old tiff_error_handler and tiff_warning_handler.
2785 This function is rewritten to use vsnprintf and thereby avoid
2786 stack buffer overflows. It uses only the features of vsnprintf
2787 that are common to both POSIX and native Microsoft.
2788 (tiff_error_handler, tiff_warning_handler): Use it.
2789 (tiff_load, gif_load, imagemagick_load_image):
2790 Don't assume :index value fits in 'int'.
2791 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2792 (imagemagick_load_image): Check that crop parameters fit into
2793 the integer types that MagickCropImage accepts. Don't assume
2794 Vimagemagick_render_type has a nonnegative value. Don't assume
2795 size_t fits in 'long'.
2796 (gs_load): Use printmax_t to print the widest integers possible.
2797 Check for integer overflow when computing image height and width.
2799 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2801 * xdisp.c (redisplay_window): Don't force window start if point
2802 will be invisible in the resulting window. (Bug#9324)
2804 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2806 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2807 the display spec is of the form `(space ...)'.
2808 (handle_display_spec): Return the value returned by
2809 handle_single_display_spec, not just 1 or zero.
2810 (handle_single_display_spec): If the display spec is of the form
2811 `(space ...)', and specifies display in the text area, return 2
2813 (try_cursor_movement): Check for the need to scroll more
2814 accurately, and prefer exact match for point under bidi.
2815 Don't advance `row' beyond the last row of the window.
2817 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2818 into disp_prop; all users changed.
2820 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2821 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2822 for the text covered by the display property.
2824 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2826 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2827 Change return value to nil.
2828 (Frecord_buffer): Delete unused function.
2830 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2832 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2833 buffers, return left-to-right.
2834 (set_cursor_from_row): Consider candidate row a win if its glyph
2835 represents a newline and point is on that newline. Fixes cursor
2836 positioning on the newline at EOL of R2L text within L2R
2837 paragraph, and vice versa.
2838 (try_cursor_movement): Check continued rows, in addition to
2839 continuation rows. Fixes unwarranted scroll when point enters a
2840 continued line of R2L text within an L2R paragraph, or vice versa.
2841 (cursor_row_p): Consider the case of point being equal to
2842 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2843 from the end of a short line to the beginning of a continued line
2844 of R2L text within L2R paragraph.
2845 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2846 composed characters.
2848 * bidi.c (bidi_check_type): Use xassert.
2849 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2852 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2854 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2857 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2859 * nsfont.m (ns_otf_to_script): Fix typo.
2861 2011-08-22 Kenichi Handa <handa@m17n.org>
2863 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2864 extra slot even if the purpose is char-code-property-table.
2866 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2868 * xdisp.c (redisplay_window): When computing centering_position,
2869 account for the height of the header line. (Bug#8874)
2871 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2872 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2873 candidate is selected by the mouse, and that candidate has a
2874 composed character under the mouse.
2876 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2877 coordinates reported by pos-visible-in-window-p for a composed
2878 character in column zero.
2880 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2882 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2884 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2886 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2887 consider it a hit if to_charpos is anywhere in the range of the
2888 composed buffer positions.
2890 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2892 * image.c (gif_load): Don't assume that each subimage has the same
2893 dimensions as the base image. Handle disposal method that is
2894 "undefined" by the gif spec (Bug#9335).
2896 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2898 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2899 (Fcondition_case): Document `debug' symbol in error handler.
2901 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2903 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2904 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2905 from an Org mode buffer to a Speedbar frame.
2907 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2908 a composition, take its buffer position from IT->cmp_it.charpos.
2909 Fixes cursor positioning at the beginning of a line that begins
2910 with a composed character.
2912 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2914 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2915 character bidirectional type, use STRONG_L instead. Fixes crashes
2916 in a buffer produced by `describe-categories'.
2918 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2919 members before the level stack, so they would be saved and
2920 restored when copying iterator state. Fixes incorrect reordering
2921 around TABs covered by display properties.
2923 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2925 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2927 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2929 * eval.c (internal_condition_case, internal_condition_case_1)
2930 (internal_condition_case_2, internal_condition_case_n):
2931 Remove unnecessary aborts (Bug#9081).
2933 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2935 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2936 has no `load' handler, try opening the file locally. (Bug#9311)
2938 2011-08-16 Ken Brown <kbrown@cornell.edu>
2940 * gmalloc.c: Expand comment.
2942 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2944 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2945 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2947 2011-08-16 Ken Brown <kbrown@cornell.edu>
2949 Fix memory allocation problems in Cygwin build (Bug#9273).
2951 * unexcw.c ( __malloc_initialized): Declare external variable.
2952 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2954 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2956 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2958 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2960 [CYGWIN] (special_realloc): New function.
2961 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2962 requests to realloc storage in the static heap.
2964 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2966 * bidi.c (bidi_initialize): Remove unused local.
2968 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2971 * biditype.h: Remove file.
2972 * makefile.w32-in ($(BLD)/bidi.$(O)):
2973 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2975 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2977 * chartab.c: Improve commentary for the uniprop_table API.
2979 * bidi.c (bidi_paragraph_init): Support zero value of
2980 bidi_ignore_explicit_marks_for_paragraph_level.
2981 (bidi_initialize): Use uniprop_table instead of including
2982 biditype.h and bidimirror.h.
2984 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2985 coordinates of the iterator when restoring from ppos_it.
2988 2011-08-14 Kenichi Handa <handa@m17n.org>
2990 * process.c (create_process): Call setup_process_coding_systems
2991 after the pid of the process is set to -1 (Bug#8162).
2993 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2995 * xdisp.c (move_it_in_display_line_to): Don't invoke
2996 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2997 ppos_it. Fixes vertical cursor motion when line beginning is
2998 covered by an image. (Bug#9296)
3000 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3002 * nsterm.h (ns_run_ascript): Declare.
3003 (NSAPP_DATA2_RUNASSCRIPT): Define.
3005 * nsfns.m (as_script, as_result, as_status): New static variables.
3006 (ns_run_ascript): New function.
3007 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3008 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3009 the event loop. Get status from as_status (Bug#7276).
3011 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3012 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3013 the event loop (Bug#7276).
3015 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3017 * gnutls.c (QCgnutls_bootprop_priority)
3018 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3019 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3020 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3021 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3022 (QCgnutls_bootprop_verify_hostname_error)
3023 (QCgnutls_bootprop_callbacks_verify): Rename from
3024 Qgnutls_bootprop_..., all uses changed.
3026 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3029 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3031 * xfaces.c (Qframe_set_background_mode): Now static.
3032 * dispextern.h (Qframe_set_background_mode): Remove decl.
3034 * process.c (Fnetwork_interface_info): Declare local only if needed.
3036 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3038 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3039 (Fnetwork_interface_list): Allocate in increments of bytes instead
3040 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3041 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3043 (struct ifflag_def): notrailers is smart on OSX.
3044 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3045 Get hardware address with getifaddrs if available.
3047 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3049 * xdisp.c (iterate_out_of_display_property): xassert that
3050 IT->position is set to within IT->object's boundaries. Break from
3051 the loop as soon as EOB is reached; avoids infloops in redisplay
3052 when IT->position is set up wrongly due to some bug.
3053 Set IT->current to match the bidi iterator unconditionally.
3054 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3055 entry. Force push_it to save on the stack the current
3056 buffer/string position, to be restored by pop_it. Fix flags in
3057 the iterator structure wrt the object coming from a display
3058 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3059 properties. (Bug#9284)
3061 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3063 * fontset.c (fontset_get_font_group): Add proper type checks.
3066 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3068 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3069 and LC_VERSION_MIN_MACOSX.
3070 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3071 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3073 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3075 * xdisp.c (forward_to_next_line_start): Allow to use the
3076 no-display-properties-and-no-overlays under bidi display.
3077 Set disp_pos in the bidi iterator to avoid searches for display
3078 properties and overlays.
3080 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3082 * editfns.c (Fset_time_zone_rule): Document relationship with the
3085 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3086 the font entity extracted from the cache (Bug#8109).
3088 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3090 * composite.c (autocmp_chars): Don't reset point. That is done by
3091 restore_point_unwind (Bug#5984).
3093 2011-08-07 Juri Linkov <juri@jurta.org>
3095 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3096 to show the arg `TIME' instead of `TIMEVAL'.
3098 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3100 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3101 display property strides EOL and includes a newline, as in
3102 longlines-mode. (Bug#9254)
3103 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3104 word-wrap under bidirectional display. (Bug#9224)
3106 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3107 is non-zero, even if the data buffer is NULL. Fixes a crash in
3108 vertical-motion with longlines-mode. (Bug#9254)
3110 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3112 * bidi.c <bidi_cache_total_alloc>: Now static.
3113 (bidi_initialize): Initialize bidi_cache_total_alloc.
3115 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3118 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3119 amount allocated this far in `bidi_cache_total_alloc'.
3120 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3121 non-zero, only free the data buffer without restoring the cache
3122 contents. All callers changed.
3124 * dispextern.h (bidi_unshelve_cache): Update prototype.
3126 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3127 (move_it_in_display_line, move_it_to)
3128 (move_it_vertically_backward, move_it_by_lines): Replace the call
3129 to xfree to an equivalent call to bidi_unshelve_cache.
3130 (move_it_in_display_line_to): Fix logic of returning
3131 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3133 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3135 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3136 came from a string character with a `cursor' property. (Bug#9229)
3138 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3140 * Makefile.in (LIB_PTHREAD): New variable.
3141 (LIBES): Add LIB_PTHREAD (Bug#9216).
3143 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3144 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3146 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3148 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3150 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3152 * xterm.c (x_find_topmost_parent): New function.
3153 (x_set_frame_alpha): Find topmost parent window with
3154 x_find_topmost_parent and set the property there also (bug#9181).
3155 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3157 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3159 * callproc.c (Fcall_process): Avoid vfork clobbering
3160 the local vars buffer, coding_systems, current_dir.
3162 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3164 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3166 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3168 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3169 so that it is not optimized away.
3171 * xdisp.c (compute_display_string_pos): Remove unused local.
3173 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3175 Fix slow cursor motion and scrolling in large buffers with
3176 selective display, like Org Mode buffers. (Bug#9218)
3178 * dispextern.h (struct bidi_it): New member disp_prop_p.
3180 * xdisp.c: Remove one-slot cache of display string positions.
3181 (compute_display_string_pos): Accept an additional argument
3182 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3183 for a display string or property. If found, set DISP_PROP_P
3186 * bidi.c (bidi_fetch_char): Accept an additional argument
3187 DISP_PROP_P, and pass it to compute_display_string_pos.
3188 Only handle text covered by a display string if DISP_PROP_P is returned
3189 non-zero. All callers of bidi_fetch_char changed.
3191 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3193 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3195 2010-12-03 Don March <don@ohspite.net>
3197 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3198 last character M-[char] is translated to ESC [char] (bug#7541).
3200 2011-08-02 Kenichi Handa <handa@m17n.org>
3202 * lisp.h (uniprop_table): Extern it.
3204 * chartab.c (uniprop_table): Make it non-static.
3206 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3208 * xdisp.c (forward_to_next_line_start): Accept additional argument
3209 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3211 (reseat_at_next_visible_line_start): Use the bidi iterator state
3212 returned by forward_to_next_line_start to restore the state of
3213 it->bidi_it after backing up to previous newline. (Bug#9212)
3215 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3217 * regex.c (re_comp): Protoize.
3218 (re_exec): Fix return type.
3219 (regexec): Fix type of `ret'. (Bug#9203)
3221 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3223 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3224 This is needed if max-image-size is a floating-point number.
3226 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3228 * print.c (print_object): Print empty symbol as ##.
3230 * lread.c (read1): Read ## as empty symbol.
3232 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3234 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3235 setting frame foreground color (Bug#9175).
3236 (x_set_background_color): Likewise.
3238 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3239 contents (Bug#9176).
3240 (EmacsTooltip -init): Remove bezels and add shadows to
3243 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3244 or scroll bar (Bug#8470).
3246 * nsfont.m (nsfont_open): Remove assignment to voffset and
3247 unnecessary vars hshink, expand, hd, full_height, min_height.
3248 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3250 * nsterm.h (nsfont_info): Remove voffset field.
3252 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3254 Implement strike-through and overline on NextStep (Bug#8863).
3256 * nsfont.m (nsfont_open): Use underline position provided by font,
3257 instead of hard-coded value of 2.
3258 (nsfont_draw): Call ns_draw_text_decoration instead.
3260 * nsterm.h: Add declaration for ns_draw_text_decoration.
3262 * nsterm.m (ns_draw_text_decoration): New function for drawing
3263 underline, overline, and strike-through.
3264 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3265 ns_draw_text_decoration. Change treatment of cursor drawing to
3266 accommodate underlining, etc.
3268 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3270 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3275 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3276 Without this fix, if a signal arrives just after memory fills up,
3277 'malloc' might be invoked reentrantly.
3279 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3280 In other words, assume that every image size is allowed, on non-X
3281 hosts. This assumption is probably wrong, but it lets Emacs compile.
3283 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3285 * regex.c (re_iswctype): Convert return values to boolean.
3287 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3289 * xdisp.c (compute_display_string_pos): Don't use cached display
3290 string position if the buffer had its restriction changed.
3293 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3297 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3299 Integer signedness and overflow and related fixes. (Bug#9079)
3301 * bidi.c: Integer size and overflow fixes.
3302 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3303 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3304 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3305 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3306 (bidi_find_other_level_edge):
3307 Use ptrdiff_t instead of EMACS_INT where either will do.
3308 This works better on 32-bit hosts configured --with-wide-int.
3309 (bidi_cache_ensure_space): Check for size-calculation overflow.
3310 Use % rather than repeated addition, for better worst-case speed.
3311 Don't set bidi_cache_size until after xrealloc returns, because it
3313 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3314 (bidi_cache_ensure_space): Also check that the bidi cache size
3315 does not exceed that of the largest Lisp string or buffer. See Eli
3316 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3318 * alloc.c (__malloc_size_t): Remove.
3319 All uses replaced by size_t. See Andreas Schwab's note
3320 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3322 * image.c: Improve checking for integer overflow.
3323 (check_image_size): Assume that f is nonnull, since
3324 it is always nonnull in practice. This is one less thing to
3325 worry about when checking for integer overflow later.
3326 (x_check_image_size): New function, which checks for integer
3327 overflow issues inside X.
3328 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3329 This removes the need for a memory_full check.
3330 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3331 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3332 (xbm_read_bitmap_data): Change locals back to 'int', since
3333 their values must fit in 'int'.
3334 (xpm_load_image, png_load, tiff_load):
3335 Invoke x_create_x_image_and_pixmap earlier,
3336 to avoid much needless work if the image is too large.
3337 (tiff_load): Treat overly large images as if
3338 x_create_x_image_and_pixmap failed, not as malloc failures.
3339 (gs_load): Use x_check_image_size.
3341 * gtkutil.c: Omit integer casts.
3342 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3343 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3345 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3347 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3348 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3349 would wrongly return t on a 64-bit host.
3351 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3352 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3353 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3354 and therefore cause GCC to emit a bogus diagnostic in some cases.
3356 * image.c: Integer signedness and overflow and related fixes.
3357 This is not an exhaustive set of fixes, but it's time to
3358 record what I've got.
3359 (lookup_pixel_color, check_image_size): Remove redundant decls.
3360 (check_image_size): Don't assume that arbitrary EMACS_INT values
3361 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3362 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3363 (tiff_load, imagemagick_load_image):
3364 Check for overflow in size calculations.
3365 (x_create_x_image_and_pixmap): Remove unnecessary test for
3366 xmalloc returning NULL; that can't happen.
3367 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3368 (xpm_color_bucket): Use better integer hashing function.
3369 (xpm_cache_color): Don't possibly over-allocate memory.
3370 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3371 (gif_memory_source):
3372 Use ptrdiff_t, not int or size_t, to record sizes.
3373 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3374 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3375 either works, as we prefer signed integers.
3376 (tiff_read_from_memory, tiff_write_from_memory):
3377 Return tsize_t, not size_t, since that's what the TIFF API wants.
3378 (tiff_read_from_memory): Don't fail simply because the read would
3379 go past EOF; instead, return a short read.
3380 (tiff_load): Omit no-longer-needed casts.
3381 (Fimagemagick_types): Don't assume size fits into 'int'.
3383 Improve hashing quality when configured --with-wide-int.
3384 * fns.c (hash_string): New function, taken from sxhash_string.
3385 Do not discard information about ASCII character case; this
3386 discarding is no longer needed.
3387 (sxhash-string): Use it. Change sig to match it. Caller changed.
3388 * lisp.h: Declare it.
3389 * lread.c (hash_string): Remove, since we now use fns.c's version.
3390 The fns.c version returns a wider integer if --with-wide-int is
3391 specified, so this should help the quality of the hashing a bit.
3393 * emacs.c: Integer overflow minor fix.
3394 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3395 Define only if GNU_LINUX.
3396 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3398 * dispnew.c: Integer signedness and overflow fixes.
3399 Remove unnecessary forward decls, that were a maintenance hassle.
3400 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3402 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3403 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3404 (prepare_desired_row, line_draw_cost):
3405 Use int, not unsigned, where either works.
3406 (save_current_matrix, restore_current_matrix):
3407 Use ptrdiff_t, not size_t, where either works.
3408 (init_display): Check for overflow more accurately, and without
3409 relying on undefined behavior.
3411 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3412 Remove, replacing with the new symbols in lisp.h. All uses changed.
3413 * fileio.c (make_temp_name):
3414 * filelock.c (lock_file_1, lock_file):
3415 * xdisp.c (message_dolog):
3416 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3417 Use pMd etc. instead.
3418 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3419 replacing the pWIDE etc. symbols removed from editfns.c.
3421 * keyboard.h (num_input_events): Now uintmax_t.
3422 This is (very slightly) less likely to mess up due to wraparound.
3425 * buffer.c: Integer signedness fixes.
3426 (alloc_buffer_text, enlarge_buffer_text):
3427 Use ptrdiff_t rather than size_t when either will do, as we prefer
3430 * alloc.c: Integer signedness and overflow fixes.
3431 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3432 (__malloc_size_t): Default to size_t, not to int.
3433 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3434 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3435 Prefer ptrdiff_t to size_t when either would do, as we prefer
3437 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3438 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3439 Now const. Initialize with values that are in range even if char
3441 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3442 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3443 These functions do the right thing with sizes > 2**32.
3444 (check_depth): Now ptrdiff_t, not int.
3445 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3446 Adjust to new way of storing sizes. Check for size overflow bugs
3448 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3449 slightly wrong anyway, as it missed one instance of
3450 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3451 (refill_memory_reserve): Omit needless cast to size_t.
3452 (mark_object_loop_halt): Mark as externally visible.
3454 * xselect.c: Integer signedness and overflow fixes.
3455 (Fx_register_dnd_atom, x_handle_dnd_message):
3456 Use ptrdiff_t, not size_t, since we prefer signed.
3457 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3458 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3459 x_dnd_atoms_size and x_dnd_atoms_length.
3461 * doprnt.c: Prefer signed to unsigned when either works.
3463 * doprnt.c (doprnt):
3465 * xdisp.c (vmessage):
3466 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3467 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3468 prefer signed arithmetic to avoid comparison confusion.
3469 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3470 but is a bit tricky.
3472 Assume freestanding C89 headers, string.h, stdlib.h.
3473 * data.c, doprnt.c, floatfns.c, print.c:
3474 Include float.h unconditionally.
3475 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3476 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3477 * regex.c: Likewise for stddef.h, string.h.
3478 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3479 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3480 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3481 (STDC_HEADERS): Remove obsolete defines.
3482 * sysdep.c: Include limits.h unconditionally.
3484 Assume support for memcmp, memcpy, memmove, memset.
3485 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3486 * regex.c (memcmp, memcpy):
3487 Remove; we assume C89 now.
3489 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3490 (__malloc_safe_bcopy): Remove; no longer needed.
3492 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3493 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3494 well either way, and we prefer signed to unsigned.
3496 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3499 closes the connection while we're reading (bug#9182).
3501 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3503 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3504 are specified (Bug#9168).
3506 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3508 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3509 Found by GCC static checking and --with-wide-int on a 32-bit host.
3511 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3513 * xdisp.c (compute_display_string_pos): Fix logic of caching
3514 previous display string position. Initialize cached_prev_pos to
3515 -1. Fixes slow-down at the beginning of a buffer.
3517 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3519 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3520 for attrs[LFACE_FONTSET_INDEX].
3522 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3524 * xml.c (parse_region): Remove unused local
3525 that was recently introduced.
3527 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3529 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3530 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3532 * xdisp.c (move_it_in_display_line_to): Record the best matching
3533 position for TO_CHARPOS while scanning the line, and restore it on
3534 exit if none of the characters scanned was an exact match.
3535 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3536 when exact match is impossible due to invisible text, and the
3537 lines are truncated.
3539 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3541 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3544 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3546 Fix a significant slow-down of cursor motion with C-n, C-p,
3547 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3548 auto-repeat under bidi redisplay in fontified buffers.
3549 * xdisp.c (compute_stop_pos_backwards): New function.
3550 (next_element_from_buffer): Call compute_stop_pos_backwards to
3551 find a suitable prev_stop when we find ourselves before
3553 (reseat): Don't look for prev_stop, as that could mean a very long
3555 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3556 <cached_disp_overlay_modiff>: Cache for last found display string
3558 (compute_display_string_pos): Return the cached position if asked
3559 about the same buffer in the same area of character positions, and
3560 the buffer wasn't changed since the time the display string
3561 position was cached.
3563 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3565 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3566 is an integer, which is important for empty lines. (Bug#9149)
3568 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3570 * frame.c (Fmodify_frame_parameters): In tty case, update the
3571 default face if necessary (Bug#4238).
3573 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3575 * editfns.c (Fstring_to_char): No need to explain what a character
3576 is in the docstring (Bug#6576).
3578 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580 * xml.c (parse_region): Make sure we always return a tree.
3582 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3584 * xml.c (parse_region): If a document contains only comments,
3587 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3589 * xml.c (make_dom): Return comments, too.
3591 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3594 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3595 and the surrounding thread.
3596 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3597 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3598 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3600 * s/openbsd.h (BROKEN_SIGIO): Define.
3601 * unexelf.c (unexec) [__OpenBSD__]:
3602 Don't update the .mdebug section of the Alpha COFF symbol table.
3604 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3606 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3609 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3611 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3612 This fixes some race conditions on the permissions of any newly
3615 * alloc.c (valid_pointer_p): Use pipe, not open.
3616 This fixes some permissions issues when debugging.
3618 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3619 If fchown fails to set both uid and gid, try to set just gid,
3620 as that is sometimes allowed. Adjust the file's mode to eliminate
3621 setuid or setgid bits that are inappropriate if fchown fails.
3623 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3625 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3626 to compare Lisp_Objects.
3627 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3628 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3629 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3631 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3633 * lread.c (read_integer): Unread even EOF character.
3634 (read1): Likewise. Properly record start position of symbol.
3636 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3637 symbol character follows.
3639 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3641 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3642 This works around a problem with the previous change to Fcopy_file.
3643 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3644 and without this change, GCC might complain about discarding
3645 fchown's return value.
3647 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3649 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3651 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3653 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3655 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3657 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3658 it's used from the C level.
3660 * process.c: Use the same condition for POLL_FOR_INPUT in both
3661 keyboard.c and process.c (bug#1858).
3663 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3665 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3666 (Fgnutls_boot): Use it.
3668 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3670 * doc.c (Fsubstitute_command_keys): Revert last change.
3672 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3674 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3675 quotes the next character, and doesn't affect other longer
3676 sequences (bug#8935).
3678 * lread.c (syms_of_lread): Clarify that is isn't only
3679 `eval-buffer' and `eval-defun' that's affected by
3680 `lexical-binding' (bug#8460).
3682 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3684 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3685 bidi redisplay when a line includes both an image and is truncated.
3687 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3689 Fix minor problems found by static checking.
3690 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3691 (elsz): Now a signed constant, not a size_t var. We prefer signed
3692 types to unsigned, to avoid integer comparison confusion. Without
3693 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3694 "cannot optimize loop, the loop counter may overflow", a symptom
3696 * indent.c (Fvertical_motion): Mark locals as initialized.
3697 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3699 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3701 * search.c (Fre_search_backward): Mention `case-fold-search' in
3702 all the re_search_* functions (bug#8138).
3704 * keyboard.c (Fopen_dribble_file): Document when the file is
3707 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3709 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3712 Support bidi reordering of display and overlay strings.
3713 * xdisp.c (compute_display_string_pos)
3714 (compute_display_string_end): Accept additional argument STRING.
3715 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3716 (reseat_to_string): Initialize bidi_it->string.s and
3717 bidi_it->string.schars.
3718 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3719 NULL (avoids a crash in bidi_paragraph_init).
3720 Initialize itb.string.lstring.
3721 (init_iterator): Call bidi_init_it only of a valid
3722 buffer position was specified. Initialize paragraph_embedding to
3724 (reseat_to_string): Initialize the bidi iterator.
3725 (display_string): If we need to ignore text properties of
3726 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3727 original value of -1 will not work with bidi.)
3728 (compute_display_string_pos): First arg is now struct
3729 `text_pos *'; all callers changed. Support display properties on
3731 (compute_display_string_end): Support display properties on Lisp
3733 (init_iterator, reseat_1, reseat_to_string): Initialize the
3734 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3735 when iterating on a string not from display properties).
3736 (compute_display_string_pos, compute_display_string_end):
3737 Fix calculation of the object to scan. Fixes an error when using
3739 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3740 base_level_stop; instead, set base_level_stop to BEGV.
3741 Fixes crashes in vertical-motion.
3742 (next_element_from_buffer): Improve commentary for when
3743 the iterator is before prev_stop.
3744 (init_iterator): Initialize bidi_p from the default value of
3745 bidi-display-reordering, not from buffer-local value. Use the
3746 buffer-local value only if initializing for buffer iteration.
3747 (handle_invisible_prop): Support invisible properties on strings
3748 that are being bidi-reordered.
3749 (set_iterator_to_next): Support bidi reordering of C strings and
3751 (next_element_from_string): Support bidi reordering of Lisp
3753 (handle_stop_backwards): Support Lisp strings as well.
3754 (display_string): Support display of R2L glyph rows.
3755 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3756 (init_iterator): Don't initialize it->bidi_p for strings
3758 (reseat_to_string): Initialize it->bidi_p for strings here.
3759 (next_element_from_string, next_element_from_c_string)
3760 (next_element_from_buffer): Add xassert's for correspondence
3761 between IT's object being iterated and it->bidi_it.string
3763 (face_before_or_after_it_pos): Support bidi iteration.
3764 (next_element_from_c_string): Handle the case of the first string
3765 character that is not the first one in the visual order.
3766 (get_visually_first_element): New function, refactored from common
3767 parts of next_element_from_buffer, next_element_from_string, and
3768 next_element_from_c_string.
3769 (tool_bar_lines_needed, redisplay_tool_bar)
3770 (display_menu_bar): Force left-to-right direction. Add a FIXME
3771 comment for making that be controlled by a user option.
3772 (push_it, pop_it): Save and restore the state of the
3773 bidi iterator. Save and restore the bidi_p flag.
3774 (pop_it): Iterate out of display property for string iteration as
3776 (iterate_out_of_display_property): Support iteration over strings.
3777 (handle_single_display_spec): Set up it->bidi_it for iteration
3778 over a display string, and call bidi_init_it.
3779 (handle_single_display_spec, next_overlay_string)
3780 (get_overlay_strings_1, push_display_prop): Set up the bidi
3781 iterator for displaying display or overlay strings.
3782 (forward_to_next_line_start): Don't use the shortcut if
3784 (back_to_previous_visible_line_start): If handle_display_prop
3785 pushed the iterator stack, restore the internal state of the bidi
3786 iterator by calling bidi_pop_it same number of times.
3787 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3788 and we are bidi-iterating, don't decrement the iterator position;
3789 instead, set the first_elt flag in the bidi iterator, to produce
3791 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3792 (push_display_prop): xassert that we are iterating a buffer.
3793 (push_it, pop_it): Save and restore paragraph_embedding member.
3794 (handle_single_display_spec, next_overlay_string)
3795 (get_overlay_strings_1, reseat_1, reseat_to_string)
3796 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3797 correctly. Don't assume unibyte strings are not bidi-reordered.
3798 (compute_display_string_pos)
3799 (compute_display_string_end): Fix handling the case of C string.
3800 (push_it, pop_it): Save and restore from_disp_prop_p.
3801 (handle_single_display_spec, push_display_prop): Set the
3802 from_disp_prop_p flag.
3803 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3804 (pop_it): Call iterate_out_of_display_property only if we are
3805 popping after iteration over a string that came from a display
3806 property. Fix a typo in popping stretch info. Add an assertion
3807 for verifying that the iterator position is in sync with the bidi
3809 (handle_single_display_spec, get_overlay_strings_1)
3810 (push_display_prop): Fix initialization of paragraph direction for
3811 string when that of the parent object is not yet determined.
3812 (reseat_1): Call bidi_init_it to resync the bidi
3813 iterator with IT's position. (Bug#7616)
3814 (find_row_edges): If ROW->start.pos gives position
3815 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3816 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3817 Reset the from_disp_prop_p flag.
3818 (SAVE_IT, RESTORE_IT): New macros.
3819 (pos_visible_p, face_before_or_after_it_pos)
3820 (back_to_previous_visible_line_start)
3821 (move_it_in_display_line_to, move_it_in_display_line)
3822 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3823 (try_scrolling, redisplay_window, display_line): Use them when
3824 saving a temporary copy of the iterator and restoring it back.
3825 (back_to_previous_visible_line_start, reseat_1)
3826 (init_iterator): Empty the bidi cache "stack".
3827 (move_it_in_display_line_to): If iterator ended up at
3828 EOL, but we never saw any buffer positions smaller than
3829 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3830 motion in bidi-reordered lines.
3831 (move_it_in_display_line_to): Record prev_method and prev_pos
3832 immediately before the call to set_iterator_to_next. Fixes cursor
3833 motion in bidi-reordered lines with stretch glyphs and strings
3834 displayed in margins. (Bug#8133) (Bug#8867)
3835 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3837 (pos_visible_p): Support positions in bidi-reordered lines.
3838 Save and restore bidi cache.
3840 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3841 (bidi_paragraph_info): Delete unused struct.
3842 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3843 (bidi_cache_start): New variable.
3844 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3846 (bidi_cache_fetch_state, bidi_cache_search)
3847 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3848 (bidi_cache_find, bidi_peek_at_next_level)
3849 (bidi_level_of_next_char, bidi_find_other_level_edge)
3850 (bidi_move_to_visually_next): Compare cache index with
3851 bidi_cache_start rather than with zero.
3852 (bidi_fetch_char): Accept new argument STRING; all callers
3853 changed. Support iteration over a string. Support strings with
3854 display properties. Support unibyte strings. Fix the type of
3855 `len' according to what STRING_CHAR_AND_LENGTH expects.
3856 (bidi_paragraph_init, bidi_resolve_explicit_1)
3857 (bidi_resolve_explicit, bidi_resolve_weak)
3858 (bidi_level_of_next_char, bidi_move_to_visually_next):
3859 Support iteration over a string.
3860 (bidi_set_sor_type, bidi_resolve_explicit_1)
3861 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3862 can now be zero (for strings); special values 0 and -1 were
3863 changed to -1 and -2, respectively.
3864 (bidi_char_at_pos): New function.
3865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3866 Call it instead of FETCH_MULTIBYTE_CHAR.
3867 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3868 initialized to valid values.
3869 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3871 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3872 the test for valid cached positions. Fix the logic for looking up
3873 the sentinel state in the cache. GCPRO the Lisp string we are
3875 (bidi_push_it, bidi_pop_it): New functions.
3876 (bidi_initialize): Initialize the bidi cache start stack pointer.
3877 (bidi_cache_ensure_space): New function, refactored from part of
3878 bidi_cache_iterator_state. Don't assume the required size is just
3879 one BIDI_CACHE_CHUNK away.
3880 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3881 (bidi_count_bytes, bidi_char_at_pos): New functions.
3882 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3883 always valid if bidi_cache_idx is valid.
3884 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3885 is valid if it's going to be used.
3886 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3887 (bidi_cache_fetch_state, bidi_cache_search)
3888 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3889 (bidi_cache_iterator_state, bidi_cache_find)
3890 (bidi_find_other_level_edge, bidi_cache_start_stack):
3891 All variables related to cache indices are now EMACS_INT.
3893 * dispextern.h (struct bidi_string_data): New structure.
3894 (struct bidi_it): New member `string'. Make flag members be 1-bit
3895 fields, and put them last in the struct.
3896 (compute_display_string_pos, compute_display_string_end):
3898 (bidi_push_it, bidi_pop_it): Add prototypes.
3899 (struct iterator_stack_entry): New members bidi_p,
3900 paragraph_embedding, and from_disp_prop_p.
3901 (struct it): Member bidi_p is now a bit field 1 bit wide.
3902 (bidi_shelve_cache, bidi_unshelve_cache):
3905 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3906 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3907 and vector-like objects.
3909 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3910 cache around display iteration.
3912 * window.c (Fwindow_end, window_scroll_pixel_based)
3913 (displayed_window_lines, Frecenter): Save and restore the bidi
3914 cache around display iteration.
3916 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3918 * editfns.c (Fdelete_region): Clarify the use of the named
3919 parameters (bug#6788).
3921 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3923 * indent.c (Fvertical_motion): Set and restore w->pointm when
3924 saving and restoring the window's buffer (Bug#9006).
3926 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3928 * editfns.c (Fstring_to_char): Clarify just what is returned
3929 (bug#6576). Text by Eli Zaretskii.
3931 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3933 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3935 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3937 * buffer.c (mmap_find): Fix a typo.
3939 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3941 Fix execution of x selection hooks.
3942 * xselect.c (Qx_lost_selection_functions)
3943 (Qx_sent_selection_functions): New vars.
3944 (syms_of_xselect): DEFSYM them.
3945 (x_handle_selection_request): Pass Qx_sent_selection_functions
3946 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3947 (x_handle_selection_clear,x_clear_frame_selections):
3948 Pass Qx_lost_selection_functions rather than
3949 Vx_lost_selection_functions to Frun_hook_with_args.
3951 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3953 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3954 The old code sometimes used this field without initializing it.
3956 * alloc.c (gc_sweep): Don't read past end of array.
3957 In theory, the old code could also have corrupted Emacs internals,
3958 though it'd be very unlikely.
3960 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3962 * character.c (Fcharacterp): Don't advertise optional ignored
3963 argument. (Bug#4026)
3965 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3967 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3970 * window.c (Fset_window_start): Doc fix (bug#4199).
3971 (Fset_window_hscroll): Ditto.
3973 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3975 Fix minor new problems caught by GCC 4.6.1.
3976 * term.c (init_tty): Remove unused local.
3977 * xsettings.c (store_monospaced_changed): Define this function only
3978 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3981 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3983 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3985 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3987 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3988 are the mini-buffer and the echo area (bug#3320).
3990 * term.c (init_tty): Remove support for supdup, c10 and perq
3991 terminals, which are no longer supported (bug#1482).
3993 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3995 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3997 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3999 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4000 for non-popups (Bug#3642).
4002 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4004 * alloc.c (reset_malloc_hooks): Protoize.
4005 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4006 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4007 * cm.c (losecursor): Likewise.
4008 * data.c (fmod): Likewise.
4009 * dispnew.c (swap_glyphs_in_rows): Likewise.
4010 * emacs.c (memory_warning_signal): Likewise.
4011 * floatfns.c (float_error): Likewise.
4012 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4013 (otf_open, font_otf_capability, generate_otf_features)
4014 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4016 * image.c (pbm_read_file): Likewise.
4017 * indent.c (string_display_width): Likewise.
4018 * intervals.c (check_for_interval, search_for_interval)
4019 (inc_interval_count, count_intervals, root_interval)
4020 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4021 * lread.c (defalias): Likewise.
4022 * ralloc.c (r_alloc_check): Likewise.
4023 * regex.c (set_image_of_range_1, set_image_of_range)
4024 (regex_grow_registers): Likewise.
4025 * sysdep.c (strerror): Likewise.
4026 * termcap.c (valid_filename_p, tprint, main): Likewise.
4027 * tparam.c (main): Likewise.
4028 * unexhp9k800.c (run_time_remap, save_data_space)
4029 (update_file_ptrs, read_header, write_header, calculate_checksum)
4030 (copy_file, copy_rest, display_header): Likewise.
4031 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4033 * xdisp.c (check_it): Likewise.
4034 * xfaces.c (register_color, unregister_color, unregister_colors):
4036 * xfns.c (print_fontset_result): Likewise.
4037 * xrdb.c (member, fatal, main): Likewise.
4039 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4041 Fix minor problems found by static checking (Bug#9031).
4042 * chartab.c (char_table_set_range, map_sub_char_table):
4043 Remove unused locals.
4044 (uniprop_table): Now static.
4045 * composite.c (_work_char): Remove unused static var.
4047 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4049 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4051 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4053 * gtkutil.c (qttip_cb): Remove code without function.
4055 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4057 * w32.c (pthread_sigmask): New stub.
4059 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4061 Use pthread_sigmask, not sigprocmask (Bug#9010).
4062 sigprocmask is portable only for single-threaded applications, and
4063 Emacs can be multi-threaded when it uses GTK.
4064 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4066 * callproc.c (Fcall_process):
4067 * process.c (create_process):
4068 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4069 Use pthread_sigmask, not sigprocmask.
4071 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4073 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4074 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4077 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4079 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4080 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4081 (xg_hide_tooltip): Fix comment.
4083 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4084 in registerServicesMenuSendTypes.
4085 (validRequestorForSendType): Don't check ns_return_types.
4087 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4090 2011-07-08 Jason Rumney <jasonr@gnu.org>
4092 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4093 SH_SHOW for hidden windows (Bug#5482).
4095 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4096 frame struct members of non-existent frames (Bug#6284).
4098 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4100 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4101 variable firstTime not needed on OSX >= 10.6.
4102 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4103 >= 10.5. Use setKnobProportion, setDoubleValue.
4105 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4106 (MAC_OS_X_VERSION_10_5): Define if not defined.
4107 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4108 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4109 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4111 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4112 cString and lossyCString on OSX >= 10.4
4114 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4115 sizeToFit on OSX >= 10.2.
4117 * nsimage.m (allocInitFromFile): Don't use deprecated method
4118 bestRepresentationForDevice on OSX >= 10.6.
4120 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4123 * emacs.c: Declare unexec_init_emacs_zone.
4125 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4127 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4129 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4130 on svcsMenu (Bug#8842).
4132 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4134 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4136 * nsterm.m (QUTF8_STRING): Declare.
4137 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4138 (validRequestorForSendType): Return type is (id).
4139 Change indexOfObjectIdenticalTo to indexOfObject.
4140 Check if we have local selection before returning self (Bug#8842).
4141 (writeSelectionToPasteboard): Put local selection into paste board
4142 if we have a local selection (Bug#8842).
4143 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4145 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4146 (ns_get_local_selection): Declare.
4148 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4150 * keymap.c (describe_map_tree): Don't insert a double newline at
4151 the end of the buffer (bug#1169) and return whether we inserted
4154 * callint.c (Fcall_interactively): Change "reading args" to
4155 "providing args" to try to clarify what it does (bug#1010).
4157 2011-07-07 Kenichi Handa <handa@m17n.org>
4159 * composite.c (composition_compute_stop_pos): Ignore a static
4160 composition starting before CHARPOS (Bug#8915).
4162 * xdisp.c (handle_composition_prop): Likewise.
4164 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4166 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4169 2011-07-07 Kenichi Handa <handa@m17n.org>
4171 * character.h (unicode_category_t): New enum type.
4173 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4174 (Qchar_code_property_table): New variable.
4175 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4176 (UNIPROP_COMPRESSED_FORM_P): New macros.
4177 (char_table_ascii): Uncompress the compressed values.
4178 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4179 Uncompress the compressed values.
4180 (sub_char_table_ref_and_range): Likewise.
4181 (char_table_ref_and_range): Uncompress the compressed values.
4182 (sub_char_table_set): New arg is_uniprop. Callers changed.
4183 Uncompress the compressed values.
4184 (sub_char_table_set_range): Args changed. Callers changed.
4185 (char_table_set_range): Adjuted for the above change.
4186 (map_sub_char_table): Delete args default_val and parent. Add arg
4187 top. Give decoded values to a Lisp function.
4188 (map_char_table): Adjust for the above change. Give decoded
4189 values to a Lisp function. Gcpro more variables.
4190 (uniprop_table_uncompress)
4191 (uniprop_decode_value_run_length): New functions.
4192 (uniprop_decoder, uniprop_decoder_count): New variables.
4193 (uniprop_get_decoder, uniprop_encode_value_character)
4194 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4196 (uniprop_encoder, uniprop_encoder_count): New variables.
4197 (uniprop_get_encoder, uniprop_table)
4198 (Funicode_property_table_internal, Fget_unicode_property_internal)
4199 (Fput_unicode_property_internal): New functions.
4200 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4201 Sunicode_property_table_internal, Sget_unicode_property_internal,
4202 and Sput_unicode_property_internal. Defvar_lisp
4203 char-code-property-alist.
4205 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4206 Vunicode_category_table.
4208 * font.c (font_range): Adjust for the change of
4209 Vunicode_category_table.
4211 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4213 * m/iris4d.h: Remove file, move contents ...
4214 * s/irix6-5.h: ... here.
4216 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4218 Remove unportable assumption about struct layout (Bug#8884).
4219 * alloc.c (mark_buffer):
4220 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4221 (clone_per_buffer_values): Don't assume that
4222 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4223 This isn't true in general, and it's particularly not true
4224 if Emacs is configured with --with-wide-int.
4225 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4226 New macros, used in the buffer.c change.
4228 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4230 * xsettings.c: Use both GConf and GSettings if both are available.
4231 (store_config_changed_event): Add comment.
4232 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4233 (store_tool_bar_style_changed): New functions.
4234 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4235 (struct xsettings): Move font inside HAVE_XFT.
4236 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4237 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4238 Move inside HAVE_XFT.
4239 (something_changed_gsettingsCB): Rename from something_changedCB.
4240 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4242 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4243 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4244 (something_changed_gconfCB): Rename from something_changedCB.
4245 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4246 (parse_settings): Move check for font inside HAVE_XFT.
4247 (read_settings, apply_xft_settings): Add comment.
4248 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4249 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4250 call store_font_name_changed.
4251 (xft_settings_event): Add comment.
4252 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4253 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4254 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4255 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4256 (xsettings_initialize): Call init_gsettings last.
4257 (xsettings_get_system_font, xsettings_get_system_normal_font):
4260 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4262 Random fixes. E.g., (random) never returned negative values.
4263 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4264 subseconds part to the entropy, as that's a bit more random.
4265 Prefer signed to unsigned, since the signedness doesn't matter and
4266 in general we prefer signed. When given a limit, use a
4267 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4268 latter isn't right if USE_2_TAGS_FOR_INTS.
4269 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4270 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4272 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4274 * textprop.c (text_property_stickiness):
4275 Obey Vtext_property_default_nonsticky.
4276 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4277 * w32fns.c (syms_of_w32fns):
4278 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4280 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4282 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4283 This is more efficient than Ffile_directory_p and avoids a minor race.
4285 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4287 * buffer.c (Foverlay_put): Say what the return value is
4290 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4291 is a directory before asking whether to use the file name
4293 (barf_or_query_if_file_exists): Make the "File is a directory"
4294 error be more correct.
4296 * fns.c (Frequire): Remove the mention of the .gz files, since
4297 that's installation-specific, but keep the mention of
4298 `get-load-suffixes'.
4300 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4302 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4303 Report string overflow if the output is too long.
4305 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4307 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4308 (syms_of_gnutls): Remove duplicate DEFSYM for
4309 Qgnutls_bootprop_verify_hostname_error, an error for
4310 Qgnutls_bootprop_verify_error (which is no longer used).
4312 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4313 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4314 Also (re)move comments that are misplaced or no longer relevant.
4316 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4318 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4320 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4322 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4323 and background color parameters if they have been changed.
4325 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4327 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4329 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4331 * xsettings.c (SYSTEM_FONT): Define only when used.
4332 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4334 * keymap.c (access_keymap_1): Now static.
4336 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4338 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4339 leave any prefix arg for the up event (Bug#1586).
4341 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4343 * lread.c (syms_of_lread): Mention single symbols defined by
4344 `defvar' or `defconst' (bug#7154).
4346 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4347 (Frequire): Mention get-load-suffixes.
4349 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4351 * window.h (window): Remove clone_number slot.
4352 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4354 (make_parent_window, make_window, saved_window)
4355 (Fset_window_configuration, save_window_save): Don't deal with
4357 * buffer.c (Qclone_number): Remove declaration.
4358 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4360 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4362 Add multiple inheritance to keymaps.
4363 * keymap.c (Fmake_composed_keymap): New function.
4364 (Fset_keymap_parent): Simplify.
4365 (fix_submap_inheritance): Remove.
4366 (access_keymap_1): New function extracted from access_keymap to handle
4367 embedded parents and handle lists of maps.
4368 (access_keymap): Use it.
4369 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4370 (Fcopy_keymap): Handle embedded parents.
4371 (Fcommand_remapping, define_as_prefix): Simplify.
4372 (Fkey_binding): Simplify.
4373 (syms_of_keymap): Move minibuffer-local-completion-map,
4374 minibuffer-local-filename-completion-map,
4375 minibuffer-local-must-match-map, and
4376 minibuffer-local-filename-must-match-map to Elisp.
4377 (syms_of_keymap): Defsubr make-composed-keymap.
4378 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4379 (parse_menu_item): Trivial simplification.
4381 2011-07-01 Glenn Morris <rgm@gnu.org>
4383 * Makefile.in (SETTINGS_LIBS): Fix typo.
4385 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4387 * coding.c (Fencode_coding_string): Record the last coding system
4388 used, as the function doc string says (bug#8738).
4390 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4392 * xsettings.c (store_monospaced_changed): Take new font as arg and
4393 check for change against current_mono_font.
4394 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4395 (emacs_settings_constructor, emacs_settings_get_property)
4396 (emacs_settings_set_property, emacs_settings_class_init)
4397 (emacs_settings_init, gsettings_obj): Remove.
4398 (something_changedCB): New function for HAVE_GSETTINGS.
4399 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4400 with value as argument.
4401 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4402 g_settings_new (Bug#8967). Do not create gsettings_obj.
4403 Remove calls to g_settings_bind. Connect something_changedCB to
4406 * xgselect.c: Add defined (HAVE_GSETTINGS).
4407 (xgselect_initialize): Ditto.
4409 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4410 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4413 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4415 * eval.c (struct backtrace): Simplify and port the data structure.
4416 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4417 signed bit field, as this assumption is not portable and it makes
4418 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4419 "char debug_on_exit : 1" as this is not portable either; instead,
4420 use the portable "unsigned int debug_on_exit : 1". Remove unused
4421 member evalargs. Remove obsolete comments about cc bombing out.
4423 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4425 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4426 Let HAVE_GSETTINGS override HAVE_GCONF.
4427 (store_monospaced_changed): New function.
4428 (EMACS_SETTINGS): A new type derived from GObject to handle
4429 GSettings notifications.
4430 (emacs_settings_constructor, emacs_settings_get_property)
4431 (emacs_settings_set_property, emacs_settings_class_init):
4433 (gsettings_client, gsettings_obj): New variables.
4434 (GSETTINGS_SCHEMA): New define.
4435 (something_changedCB): Call store_monospaced_changed.
4436 (init_gsettings): New function.
4437 (xsettings_initialize): Call init_gsettings.
4438 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4441 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4444 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4446 * window.c (resize_root_window, grow_mini_window)
4447 (shrink_mini_window): Rename Qresize_root_window to
4448 Qwindow_resize_root_window and Qresize_root_window_vertically to
4449 Qwindow_resize_root_window_vertically.
4451 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4453 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4455 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4457 * makefile.w32-in: Redesign dependencies so they reflect more
4458 clearly which files are directly included by each source file,
4459 and not through other includes.
4461 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4463 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4464 (sort_overlays, overlay_strings): When an overlay's clone number
4465 matches the window's clone number process the overlay even if
4466 the overlay's window property doesn't match the current window.
4468 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4469 (Fwindow_hchild): Rename to Fwindow_left_child.
4470 (Fwindow_next): Rename to Fwindow_next_sibling.
4471 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4472 (resize_window_check): Rename to window_resize_check.
4473 (resize_window_apply): Rename to window_resize_apply.
4474 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4475 (Fdelete_other_windows_internal, resize_frame_windows)
4476 (Fsplit_window_internal, Fdelete_window_internal)
4477 (grow_mini_window, shrink_mini_window)
4478 (Fresize_mini_window_internal): Fix callers accordingly.
4480 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4482 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4483 (emacs_fixed_set_min_size): Remove.
4484 (emacs_fixed_new): Take frame as argument.
4486 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4487 (_EmacsFixedPrivate): Remove minwidth/height.
4488 Add struct frame *f.
4489 (emacs_fixed_init): Initialize priv->f.
4490 (get_parent_class, emacs_fixed_set_min_size): Remove.
4491 (emacs_fixed_new): Set priv->f to argument.
4492 (emacs_fixed_get_preferred_width)
4493 (emacs_fixed_get_preferred_height): Use min_width/height from
4494 frames size_hint to set minimum and natural (Bug#8919).
4495 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4496 and use min_width/height from frames size_hint to set
4497 min_width/height (Bug#8919).
4499 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4500 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4503 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4505 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4506 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4509 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4511 * process.c (wait_reading_process_output): Bypass select if
4512 waiting for a cell while ignoring keyboard input, and input is
4513 pending. Suggested by Jan Djärv (Bug#8869).
4515 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4517 Use gnulib's dup2 module instead of rolling our own.
4518 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4520 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4522 * dispnew.c (scrolling_window): Before scrolling, turn off a
4523 mouse-highlight in the window being scrolled.
4525 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4527 Move DEFSYM to lisp.h and use everywhere.
4529 * character.h (DEFSYM): Move declaration...
4530 * lisp.h (DEFSYM): ...here.
4536 * w32select.c: Don't include character.h.
4538 * alloc.c (syms_of_alloc):
4539 * buffer.c (syms_of_buffer):
4540 * bytecode.c (syms_of_bytecode):
4541 * callint.c (syms_of_callint):
4542 * casefiddle.c (syms_of_casefiddle):
4543 * casetab.c (init_casetab_once):
4544 * category.c (init_category_once, syms_of_category):
4545 * ccl.c (syms_of_ccl):
4546 * cmds.c (syms_of_cmds):
4547 * composite.c (syms_of_composite):
4548 * dbusbind.c (syms_of_dbusbind):
4549 * dired.c (syms_of_dired):
4550 * dispnew.c (syms_of_display):
4551 * doc.c (syms_of_doc):
4552 * editfns.c (syms_of_editfns):
4553 * emacs.c (syms_of_emacs):
4554 * eval.c (syms_of_eval):
4555 * fileio.c (syms_of_fileio):
4556 * fns.c (syms_of_fns):
4557 * frame.c (syms_of_frame):
4558 * fringe.c (syms_of_fringe):
4559 * insdel.c (syms_of_insdel):
4560 * keymap.c (syms_of_keymap):
4561 * lread.c (init_obarray, syms_of_lread):
4562 * macros.c (syms_of_macros):
4563 * msdos.c (syms_of_msdos):
4564 * print.c (syms_of_print):
4565 * process.c (syms_of_process):
4566 * search.c (syms_of_search):
4567 * sound.c (syms_of_sound):
4568 * syntax.c (init_syntax_once, syms_of_syntax):
4569 * terminal.c (syms_of_terminal):
4570 * textprop.c (syms_of_textprop):
4571 * undo.c (syms_of_undo):
4572 * w32.c (globals_of_w32):
4573 * window.c (syms_of_window):
4574 * xdisp.c (syms_of_xdisp):
4575 * xfaces.c (syms_of_xfaces):
4576 * xfns.c (syms_of_xfns):
4577 * xmenu.c (syms_of_xmenu):
4578 * xsettings.c (syms_of_xsettings):
4579 * xterm.c (syms_of_xterm): Use DEFSYM.
4581 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4583 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4585 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4587 Integer and buffer overflow fixes (Bug#8873).
4589 * print.c (printchar, strout): Check for string overflow.
4590 (PRINTPREPARE, printchar, strout):
4591 Don't set size unless allocation succeeds.
4593 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4594 for sizes. Check for string overflow more accurately.
4595 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4597 * macros.c: Integer and buffer overflow fixes.
4598 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4599 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4600 Use ptrdiff_t, not int, for sizes.
4601 Don't increment bufsize until after realloc succeeds.
4602 Check for size-calculation overflow.
4603 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4605 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4607 * lread.c: Integer overflow fixes.
4608 (read_integer): Radix is now EMACS_INT, not int,
4609 to improve quality of diagnostics for out-of-range radices.
4610 Calculate buffer size correctly for out-of-range radices.
4611 (read1): Check for integer overflow in radices, and in
4612 read-circle numbers.
4613 (read_escape): Avoid int overflow.
4614 (Fload, openp, read_buffer_size, read1)
4615 (substitute_object_recurse, read_vector, read_list, map_obarray):
4616 Use ptrdiff_t, not int, for sizes.
4617 (read1): Use EMACS_INT, not int, for sizes.
4618 Check for size overflow.
4620 * image.c (cache_image): Check for size arithmetic overflow.
4622 * lread.c: Integer overflow issues.
4623 (saved_doc_string_size, saved_doc_string_length)
4624 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4625 Now ptrdiff_t, not int.
4626 (read1): Don't assume doc string length fits in int. Check for
4627 out-of-range doc string lengths.
4628 (read_list): Don't assume file position fits in int.
4629 (read_escape): Check for hex character overflow.
4631 2011-06-22 Leo Liu <sdl.web@gmail.com>
4633 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4634 Move to minibuffer.el.
4636 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4638 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4639 The following patches are for when GLYPH_DEBUG && !XASSERT.
4640 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4641 * dispnew.c (flush_stdout):
4642 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4643 Mark as externally visible.
4644 * dispnew.c (check_window_matrix_pointers): Now static.
4645 * dispnew.c (window_to_frame_vpos):
4646 * xfns.c (unwind_create_frame):
4647 * xterm.c (x_check_font): Remove unused local.
4648 * scroll.c (CHECK_BOUNDS):
4649 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4650 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4651 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4652 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4653 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4655 (debug_method_add): Use va_list and vsprintf rather than relying
4656 on undefined behavior with wrong number of arguments.
4657 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4658 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4659 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4660 since we're not interested in debugging glyphs with old libraries.
4661 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4662 GCC 4.6.0's static checking.
4664 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4666 Integer overflow and signedness fixes (Bug#8873).
4667 A few related buffer overrun fixes, too.
4669 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4671 * dispextern.h (struct face.stipple):
4672 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4673 (x_bitmap_mask, x_allocate_bitmap_record)
4674 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4675 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4676 (x_create_bitmap_from_xpm_data):
4677 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4678 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4680 * xfaces.c (load_pixmap):
4681 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4682 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4683 (.bitmaps_last, struct x_output.icon_bitmap):
4684 Use ptrdiff_t, not int, for bitmap indexes.
4685 (x_allocate_bitmap_record): Check for size overflow.
4686 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4688 Use ptrdiff_t, not int, for overlay counts.
4689 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4690 * editfns.c (overlays_around, get_pos_property):
4691 * textprop.c (get_char_property_and_overlay):
4692 * xdisp.c (next_overlay_change, note_mouse_highlight):
4693 * xfaces.c (face_at_buffer_position):
4694 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4695 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4696 (Fnext_overlay_change, Fprevious_overlay_change)
4697 (mouse_face_overlay_overlaps, Foverlays_in):
4698 Use ptrdiff_t, not int, for sizes.
4699 (overlays_at, overlays_in): Check for size-calculation overflow.
4701 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4703 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4704 (x_session_initialize): Do not assume string length fits in int.
4706 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4707 This is unlikely, but can occur if DPI is outlandish.
4709 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4710 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4712 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4713 * xrdb.c (magic_file_p, search_magic_path):
4714 Omit last arg SUFFIX; it was always 0. All callers changed.
4715 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4717 * xfont.c (xfont_match): Avoid need for strlen.
4719 * xfns.c: Don't assume strlen fits in int.
4720 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4722 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4723 not unsigned long, as we prefer signed integers. All callers changed.
4724 Detect integer overflow in repeat count.
4725 (message_dolog): Don't assume print length fits in 39 bytes.
4726 (display_mode_element): Don't assume strlen fits in int.
4728 * termcap.c: Don't assume sizes fit in int and never overflow.
4729 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4730 (gobble_line): Check for size-calculation overflow.
4732 * minibuf.c (Fread_buffer):
4733 * lread.c (intern, intern_c_string):
4734 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4735 Don't assume string length fits in int.
4737 * keyboard.c (parse_tool_bar_item):
4738 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4740 * font.c: Don't assume string length fits in int.
4741 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4742 Use ptrdiff_t, not int.
4743 (font_intern_prop): Don't assume string length fits in int.
4744 Don't assume integer property fits in fixnum.
4745 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4747 * filelock.c: Fix some buffer overrun and integer overflow issues.
4748 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4749 Reformulate so as not to need the command string.
4750 Invoke gzip -cd rather than gunzip, as it's more portable.
4751 (lock_info_type, lock_file_1, lock_file):
4752 Don't assume pid_t and time_t fit in unsigned long.
4753 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4754 (current_lock_owner): Prefer signed type for sizes.
4755 Use memcpy, not strncpy, where memcpy is what is really wanted.
4756 Don't assume (via atoi) that time_t and pid_t fit in int.
4757 Check for time_t and/or pid_t out of range, e.g., via a network share.
4758 Don't alloca where an auto var works fine.
4760 * fileio.c: Fix some integer overflow issues.
4761 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4762 Don't assume string length fits in int.
4763 (directory_file_name): Don't assume string length fits in long.
4764 (make_temp_name): Don't assume pid fits in int, or that its print
4765 length is less than 20.
4767 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4769 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4771 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4773 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4774 We prefer signed integers, even for size calculations.
4776 * emacs.c: Don't assume string length fits in 'int'.
4777 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4778 (main): Don't invoke strlen when not needed.
4780 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4781 (XD_DEBUG_MESSAGE): Don't waste a byte.
4783 * callproc.c (getenv_internal_1, getenv_internal)
4785 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4787 * lread.c (invalid_syntax): Omit length argument.
4788 All uses changed. This doesn't fix a bug, but it simplifies the
4789 code away from its former Hollerith-constant appearance, and it's
4790 one less 'int' to worry about when looking at integer-overflow issues.
4791 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4793 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4794 This didn't break anything, but it didn't help either.
4795 It's confusing to put a bogus integer in a place where the actual
4796 value does not matter.
4797 (LIST_END_P): Remove unused macro and its bogus comment.
4798 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4800 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4801 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4803 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4804 We prefer signed types, and the value cannot exceed the EMACS_INT
4805 range anyway (because otherwise the length would not be representable).
4806 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4807 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4808 This avoids a GCC warning when WIDE_EMACS_INT.
4810 * indent.c (sane_tab_width): New function.
4811 (current_column, scan_for_column, Findent_to, position_indentation)
4812 (compute_motion): Use it. This is just for clarity.
4813 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4815 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4817 * lisp.h (lint_assume): New macro.
4818 * composite.c (composition_gstring_put_cache):
4819 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4821 * editfns.c, insdel.c:
4822 Omit unnecessary forward decls, to simplify future changes.
4824 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4826 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4828 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4829 Use much-faster test for byte-length change.
4830 Don't assume string byte-length fits in 'int'.
4831 Check that character arg fits in 'int'.
4832 (mapcar1): Declare byte as byte, for clarity.
4834 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4836 * fns.c (concat): Catch string overflow earlier.
4837 Do not rely on integer wraparound.
4839 * dispextern.h (struct it.overlay_strings_charpos)
4840 (struct it.selective): Now EMACS_INT, not int.
4841 * xdisp.c (forward_to_next_line_start)
4842 (back_to_previous_visible_line_start)
4843 (reseat_at_next_visible_line_start, next_element_from_buffer):
4844 Don't arbitrarily truncate the value of 'selective' to int.
4846 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4848 * composite.c: Don't truncate sizes to 'int'.
4849 (composition_gstring_p, composition_reseat_it)
4850 (composition_adjust_point): Use EMACS_INT, not int.
4851 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4852 not EMACS_UINT, for indexes.
4854 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4856 * buffer.c: Include <verify.h>.
4857 (struct sortvec.priority, struct sortstr.priority):
4858 Now EMACS_INT, not int.
4859 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4860 (struct sortstr.size, record_overlay_string)
4861 (struct sortstrlist.size, struct sortlist.used):
4862 Don't truncate size to int.
4863 (record_overlay_string): Check for size-calculation overflow.
4864 (init_buffer_once): Check at compile-time, not run-time.
4866 2011-06-22 Jim Meyering <meyering@redhat.com>
4868 Don't leak an XBM-image-sized buffer
4869 * image.c (xbm_load): Free the image buffer after using it.
4871 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4874 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4875 that Sun C diagnosed.
4876 * fns.c (secure_hash): Fix pointer signedness issue.
4877 * intervals.c (static_offset_intervals): New function.
4878 (offset_intervals): Use it.
4880 2011-06-21 Leo Liu <sdl.web@gmail.com>
4883 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4886 * fns.c (secure_hash): Rename from crypto_hash_function and change
4887 the first arg to accept symbols.
4888 (Fsecure_hash): New primitive.
4889 (syms_of_fns): New symbols.
4891 2011-06-20 Deniz Dogan <deniz@dogan.se>
4893 * process.c (Fset_process_buffer): Clarify return value in
4896 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4898 * dispnew.c (add_window_display_history): Use BVAR.
4900 * xdisp.c (debug_method_add): Use BVAR.
4901 (check_window_end, dump_glyph_matrix, dump_glyph)
4902 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4904 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4907 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4908 check till after the cache is created in init_frame_faces.
4910 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4912 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4914 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4916 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4917 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4918 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4920 Improve buffer-overflow checking (Bug#8873).
4921 * fileio.c (Finsert_file_contents):
4922 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4923 Remove the old (too-loose) buffer overflow checks.
4924 They weren't needed, since make_gap checks for buffer overflow.
4925 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4926 The old code merely checked for Emacs fixnum overflow, and relied
4927 on undefined (wraparound) behavior. The new code avoids undefined
4928 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4930 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4931 Tune. Don't use wider integers than needed. Don't use alloca.
4932 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4934 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4936 * insdel.c, lisp.h (buffer_overflow): New function.
4937 (insert_from_buffer_1, replace_range, replace_range_2):
4938 * insdel.c (make_gap_larger):
4939 * editfns.c (Finsert_char):
4940 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4942 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4944 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4946 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4948 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4949 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4951 * fileio.c: Don't assume EMACS_INT fits in off_t.
4952 (emacs_lseek): New static function.
4953 (Finsert_file_contents, Fwrite_region): Use it.
4954 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4956 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4958 * fns.c: Don't overflow int when computing a list length.
4959 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4960 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4961 truncation on 64-bit hosts. Check for QUIT every
4962 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4963 faster and is responsive enough.
4964 (Flength): Report an error instead of overflowing an integer.
4965 (Fsafe_length): Return a float if the value is not representable
4966 as a fixnum. This shouldn't happen except in contrived situations.
4967 (Fnthcdr, Fsort): Don't assume list length fits in int.
4968 (Fcopy_sequence): Don't assume vector length fits in int.
4970 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4971 (header_size, word_size): New constants.
4972 (allocate_vectorlike): Don't check size overflow here.
4973 (allocate_vector): Check it here instead, since this is the only
4974 caller of allocate_vectorlike that could cause overflow.
4975 Check that the new vector's length is representable as a fixnum.
4977 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4978 The previous code was bogus. For example, next_almost_prime (32)
4979 returned 39, which is undesirable as it is a multiple of 3; and
4980 next_almost_prime (24) returned 25, which is a multiple of 5 so
4981 why was the code bothering to check for multiples of 7?
4983 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4985 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4987 Variadic C functions now count arguments with ptrdiff_t.
4988 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4989 Back then I didn't know that the Emacs coding style prefers signed int.
4990 Also, in the meantime I found a few more instances where arguments
4991 were being counted with int, which may truncate counts on 64-bit
4992 machines, or EMACS_INT, which may be unnecessarily wide.
4993 * lisp.h (struct Lisp_Subr.function.aMANY)
4994 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4995 Arg counts are now ptrdiff_t, not size_t.
4996 All variadic functions and their callers changed accordingly.
4997 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4998 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4999 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5000 * callint.c (Fcall_interactively): Check arg count for overflow,
5001 to avoid potential buffer overrun. Use signed char, not 'int',
5002 for 'varies' array, so that we needn't bother to check its size
5003 calculation for overflow.
5004 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5005 * eval.c (apply_lambda):
5006 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5007 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5008 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5010 * callint.c (Fcall_interactively): Don't use index var as event count.
5012 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5013 * mem-limits.h (SIZE): Remove; no longer used.
5015 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5017 Remove unnecessary casts.
5018 * xterm.c (x_term_init):
5019 * xfns.c (x_set_border_pixel):
5020 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5021 These aren't needed now that we assume ANSI C.
5023 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5024 It's more likely to cause problems (due to unsigned overflow)
5027 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5029 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5031 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5033 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5035 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5037 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5039 GLYPH_CODE_FACE returns EMACS_INT, not int.
5040 * dispextern.h (merge_faces):
5041 * xfaces.c (merge_faces):
5042 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5043 Don't assume EMACS_INT fits in int.
5045 * character.h (CHAR_VALID_P): Remove unused parameter.
5046 * fontset.c, lisp.h, xdisp.c: All uses changed.
5048 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5050 * fns.c (concat): Minor tuning based on overflow analysis.
5051 This doesn't fix any bugs. Use int to hold character, instead
5052 of constantly refetching from Emacs object. Use XFASTINT, not
5053 XINT, for value known to be a character. Don't bother comparing
5054 a single byte to 0400, as it's always less.
5056 * floatfns.c (Fexpt):
5057 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5059 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5062 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5064 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5065 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5066 incorrectly succeed when S was a string, because 4294967386 was
5067 truncated before it was used.
5069 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5070 Otherwise, an out-of-range integer could cause undefined behavior
5073 * composite.c: Use int, not EMACS_INT, for characters.
5074 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5075 EMACS_INT, for values that are known to be in character range.
5076 This doesn't fix any bugs but is the usual style inside Emacs and
5077 may generate better code on 32-bit machines.
5079 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5080 This is for reasons similar to the recent CHAR_STRING fix.
5081 * charset.c (Fencode_char): Check that character arg is actually
5082 a character. Pass an int to ENCODE_CHAR.
5083 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5084 wider than 'int', as a compile-time check to prevent future regressions
5087 * character.c (char_string): Remove unnecessary casts.
5089 Make sure a 64-bit char is never passed to CHAR_STRING.
5090 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5091 by silently ignoring the top 32 bits, allowing some values
5092 that were far too large to be valid characters.
5093 * character.h: Include <verify.h>.
5094 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5095 arguments are no wider than unsigned, as a compile-time check
5096 to prevent future regressions in this area.
5098 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5099 (Fsubst_char_in_region):
5101 * xdisp.c (decode_mode_spec_coding):
5102 Adjust to CHAR_STRING's new requirement.
5103 * editfns.c (Finsert_char, Fsubst_char_in_region):
5104 * fns.c (concat): Check that character args are actually
5105 characters. Without this test, these functions did the wrong
5106 thing with wildly out-of-range values on 64-bit hosts.
5108 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5109 These casts should not be needed on 32-bit hosts, either.
5110 * keyboard.c (read_char):
5111 * lread.c (Fload): Remove casts to unsigned.
5113 * lisp.h (UNSIGNED_CMP): New macro.
5114 This fixes comparison bugs on 64-bit hosts.
5115 (ASCII_CHAR_P): Use it.
5116 * casefiddle.c (casify_object):
5117 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5118 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5119 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5120 * dispextern.h (FACE_FROM_ID):
5121 * keyboard.c (read_char): Use UNSIGNED_CMP.
5123 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5124 not to EMACS_INT, to avoid GCC warning.
5126 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5128 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5129 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5130 isn't needed on 32-bit machines.
5132 * buffer.c (Fgenerate_new_buffer_name):
5133 Use EMACS_INT for count, not int.
5134 (advance_to_char_boundary): Return EMACS_INT, not int.
5136 * data.c (Qcompiled_function): Now static.
5138 * window.c (window_body_lines): Now static.
5140 * image.c (gif_load): Rename local to avoid shadowing.
5142 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5143 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5144 * alloc.c (make_save_value): Integer argument is now of type
5146 (mark_object): Use ptrdiff_t, not int.
5147 * lisp.h (pD): New macro.
5148 * print.c (print_object): Use it.
5150 * alloc.c: Use EMACS_INT, not int, to count objects.
5151 (total_conses, total_markers, total_symbols, total_vector_size)
5152 (total_free_conses, total_free_markers, total_free_symbols)
5153 (total_free_floats, total_floats, total_free_intervals)
5154 (total_intervals, total_strings, total_free_strings):
5155 Now EMACS_INT, not int. All uses changed.
5156 (Fgarbage_collect): Compute overall total using a double, so that
5157 integer overflow is less likely to be a problem. Check for overflow
5158 when converting back to an integer.
5159 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5160 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5161 These were 'int' variables that could overflow on 64-bit hosts;
5162 they were never used, so remove them instead of repairing them.
5163 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5164 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5165 Previously, this ceilinged at INT_MAX, but that doesn't work on
5167 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5169 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5170 (allocate_vectorlike): Check for ptrdiff_t overflow.
5171 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5172 when a (possibly-narrower) signed value would do just as well.
5173 We prefer using signed arithmetic, to avoid comparison confusion.
5175 * alloc.c: Catch some string size overflows that we were missing.
5176 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5177 for convenience in STRING_BYTES_MAX.
5178 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5179 The definition here is exact; the one in lisp.h was approximate.
5180 (allocate_string_data): Check for string overflow. This catches
5181 some instances we weren't catching before. Also, it catches
5182 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5183 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5184 and ptrdiff_t and EMACS_INT are both 64 bits.
5186 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5187 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5188 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5190 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5192 * alloc.c (Fmake_string): Check for out-of-range init.
5194 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5196 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5198 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5200 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5201 xg_get_default_scrollbar_width.
5203 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5204 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5205 (style_changed_cb): Call update_theme_scrollbar_width and call
5206 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5207 all frames (Bug#8505).
5208 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5209 Call gtk_window_set_resizable if HAVE_GTK3.
5210 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5211 and height if HAVE_GTK3 (Bug#8505).
5212 (scroll_bar_width_for_theme): New variable.
5213 (update_theme_scrollbar_width): New function.
5214 (xg_get_default_scrollbar_width): Move code to
5215 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5216 (xg_initialize): Call update_theme_scrollbar_width.
5218 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5220 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5222 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5224 * frame.c (make_frame): Call other_buffer_safely instead of
5227 * window.c (temp_output_buffer_show): Call display_buffer with
5228 second argument Vtemp_buffer_show_specifiers and reset latter
5229 immediately after the call.
5230 (Vtemp_buffer_show_specifiers): New variable.
5231 (auto_window_vscroll_p, next_screen_context_lines)
5232 (Vscroll_preserve_screen_position): Remove leading asterisks from
5235 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5237 Fix minor problems found by GCC 4.6.0 static checking.
5238 * buffer.c (Qclone_number): Remove for now, as it's unused.
5239 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5240 (record_buffer): Remove unused local.
5241 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5242 (set_frame_buffer_list): Remove; unused.
5243 * frame.h (other_visible_frames): Remove decl.
5244 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5245 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5246 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5248 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5249 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5250 Define only if HAVE_GPM.
5251 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5252 (update_hints_inhibit): Remove; never set. All uses removed.
5253 * widgetprv.h (emacsFrameClassRec): Remove decl.
5254 * window.c (delete_deletable_window): Now returns void, since it
5255 wasn't returning anything.
5256 (compare_window_configurations): Remove unused locals.
5257 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5258 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5259 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5260 the same widths as pointers. This follows up on the 2011-05-06 patch.
5261 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5262 * xterm.h: Likewise.
5263 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5265 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5267 * makefile.w32-in: Update dependencies.
5268 (LISP_H): Add lib/intprops.h.
5270 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5272 * image.c (gif_load): Add animation frame delay to the metadata.
5273 (syms_of_image): Use DEFSYM. New symbol `delay'.
5275 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5277 * window.c (delete_deletable_window): Re-add.
5278 (Fset_window_configuration): Rewrite to handle dead buffers and
5279 consequently deletable windows.
5280 (window_tree, Fwindow_tree): Remove. Supply functionality in
5282 (compare_window_configurations): Simplify code.
5284 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5286 * image.c (imagemagick_load_image): Fix type mismatch.
5287 (Fimagemagick_types): Likewise.
5289 * window.h (replace_buffer_in_windows): Declare.
5291 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5293 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5294 Qclone_number. Remove external declaration of Qdelete_window.
5295 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5297 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5298 Run Qbuffer_list_update_hook if allowed.
5299 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5300 buffer list implementation.
5301 (other_buffer_safely): New function.
5302 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5303 calls to replace_buffer_in_windows and
5304 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5306 (record_buffer): Inhibit quitting and rewrite using quittable
5307 functions. Run Qbuffer_list_update_hook if allowed.
5308 (Frecord_buffer, Funrecord_buffer): New functions.
5309 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5310 Move switch-to-buffer to window.el.
5311 (bury-buffer): Move to window.el.
5312 (Vbuffer_list_update_hook): New variable.
5314 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5317 * window.h (resize_frame_windows): Move up in code.
5318 (Fwindow_frame): Remove EXFUN.
5319 (replace_buffer_in_all_windows): Remove prototype.
5320 (replace_buffer_in_windows_safely): Add prototype.
5322 * window.c: Declare Qdelete_window static again. Move down
5323 declaration of select_count.
5324 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5325 (Fother_window): Move to window.el.
5326 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5327 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5328 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5330 (replace_buffer_in_windows): Implement by calling
5331 Qreplace_buffer_in_windows.
5332 (replace_buffer_in_all_windows): Remove with some functionality
5333 moved into replace_buffer_in_windows_safely.
5334 (replace_buffer_in_windows_safely): New function.
5335 (select_window_norecord, select_frame_norecord): Move in front
5336 of run_window_configuration_change_hook. Remove now obsolete
5338 (Fset_window_buffer): Rewrite doc-string.
5339 Call Qrecord_window_buffer.
5340 (keys_of_window): Move binding for other-window to window.el.
5342 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5344 * dispextern.h (struct image): Replace data member, whose int_val
5345 and ptr_val fields were not used by anything, with a single
5348 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5349 (gif_clear_image, gif_load, imagemagick_load_image)
5350 (gs_clear_image, gs_load): Callers changed.
5352 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5354 * buffer.h: Include <time.h>, for time_t.
5355 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5357 Fix minor problems found by static checking.
5359 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5361 Make identifiers static if they are not used in other modules.
5362 * data.c (Qcompiled_function, Qframe, Qvector):
5363 * image.c (QimageMagick, Qsvg):
5364 * minibuf.c (Qmetadata):
5365 * window.c (resize_window_check, resize_root_window): Now static.
5366 * window.h (resize_window_check, resize_root_window): Remove decls.
5368 * window.c (window_deletion_count, delete_deletable_window):
5370 (window_body_lines): Now static.
5371 (Fdelete_other_windows_internal): Mark vars as initialized.
5372 Make sure 'resize_failed' is initialized.
5373 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5374 (resize_window_apply): Remove unused local.
5375 * window.h (delete_deletable_window): Remove decl.
5377 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5378 (imagemagick_load_image): Fix pointer signedness problem by changing
5379 last arg from unsigned char * to char *. All uses changed.
5380 Also, fix a local for similar reasons.
5381 Remove unused locals. Remove locals to avoid shadowing.
5382 (fn_rsvg_handle_free): Remove; unused.
5383 (svg_load, svg_load_image): Fix pointer signedness problem.
5384 (imagemagick_load_image): Don't use garbage pointer image_wand.
5386 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5388 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5390 * image.c (gif_load): Fix omitted cast error introduced by
5393 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5395 * window.h (resize_proportionally, orig_total_lines)
5396 (orig_top_line): Remove from window structure.
5397 (set_window_height, set_window_width, change_window_heights)
5398 (Fdelete_window): Remove prototypes.
5399 (resize_frame_windows): Remove duplicate declaration.
5401 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5403 * window.h (resize_frame_windows, resize_window_check)
5404 (delete_deletable_window, resize_root_window)
5405 (resize_frame_windows): Declare prototypes.
5407 * window.c (resize_window_apply): Make definition be "static" to
5408 match the prototype.
5410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5412 * window.c: Remove declarations of Qwindow_size_fixed,
5413 window_min_size_1, window_min_size_2, window_min_size,
5414 size_window, window_fixed_size_p, enlarge_window, delete_window.
5415 Remove static from declaration of Qdelete_window, it's
5416 temporarily needed by Fbury_buffer.
5417 (replace_window): Don't assign orig_top_line and
5419 (Fdelete_window, delete_window): Remove. Window deletion is
5420 handled by window.el.
5421 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5422 Replace Fdelete_window calls with calls to Qdelete_window.
5423 (Fdelete_other_windows): Remove. Deleting other windows is
5424 handled by window.el.
5425 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5426 handled in window.el.
5427 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5428 Window minimum sizes are handled in window.el.
5429 (shrink_windows, size_window, set_window_height)
5430 (set_window_width, change_window_heights, window_height)
5431 (window_width, CURBEG, CURSIZE, enlarge_window)
5432 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5433 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5434 handled in window.el.
5435 (make_dummy_parent): Rename to make_parent_window and give it a
5436 second argument horflag.
5437 (make_window): Don't set resize_proportionally any more.
5438 (Fsplit_window): Remove. Windows are split in window.el.
5439 (save_restore_action, save_restore_orig_size)
5440 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5441 Resize mini windows in window.el.
5442 (grow_mini_window, shrink_mini_window): Implement by calling
5443 Qresize_root_window_vertically, resize_window_check and
5444 resize_window_apply.
5445 (saved_window, Fset_window_configuration, save_window_save):
5446 Do not handle orig_top_line, orig_total_lines, and
5447 resize_proportionally.
5448 (window_min_height, window_min_width): Move to window.el.
5449 (keys_of_window): Move bindings for delete-other-windows,
5450 split-window, delete-window and enlarge-window to window.el.
5452 * buffer.c: Temporarily extern Qdelete_window.
5453 (Fbury_buffer): Temporarily call Qdelete_window instead of
5454 Fdelete_window (Fbury_buffer will move to window.el soon).
5456 * frame.c (set_menu_bar_lines_1): Remove code handling
5457 orig_top_line and orig_total_lines.
5459 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5460 set_window_height but set heights directly.
5461 (change_frame_size_1): Use resize_frame_windows.
5463 * xdisp.c (init_xdisp): Don't use set_window_height but set
5466 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5467 Use resize_frame_windows instead of change_window_heights and run
5468 run_window_configuration_change_hook.
5470 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5471 instead of change_window_heights and run
5472 run_window_configuration_change_hook.
5474 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5476 * window.c (replace_window): Rename second argument REPLACEMENT to
5477 NEW. New third argument SETFLAG. Rewrite.
5478 (delete_window, make_dummy_parent): Call replace_window with
5480 (window_list_1): Move down in code.
5481 (run_window_configuration_change_hook): Move set_buffer part
5482 before select_frame_norecord part in order to unwind correctly.
5483 Rename count1 to count.
5484 (recombine_windows, delete_deletable_window, resize_root_window)
5485 (Fdelete_other_windows_internal)
5486 (Frun_window_configuration_change_hook, make_parent_window)
5487 (resize_window_check, resize_window_apply, Fresize_window_apply)
5488 (resize_frame_windows, Fsplit_window_internal)
5489 (Fdelete_window_internal, Fresize_mini_window_internal):
5491 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5493 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5495 * window.h (window): Add some new members to window structure -
5496 normal_lines, normal_cols, new_total, new_normal, clone_number,
5497 splits, nest, prev_buffers, next_buffers.
5498 (WINDOW_TOTAL_SIZE): Move here from window.c.
5499 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5501 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5503 (make_dummy_parent): Set new members of windows structure.
5504 (make_window): Move down in code. Handle new members of window
5506 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5507 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5508 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5509 (Fset_window_prev_buffers, Fwindow_next_buffers)
5510 (Fset_window_next_buffers, Fset_window_clone_number):
5512 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5513 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5515 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5516 Argument WINDOW can be now internal window too.
5517 (Fwindow_use_time): Move up in code.
5518 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5520 (Fset_window_configuration, saved_window)
5521 (Fcurrent_window_configuration, save_window_save): Handle new
5522 members of window structure.
5523 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5524 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5525 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5526 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5527 Qget_mru_window, Qresize_root_window,
5528 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5529 Qauto_buffer_name; staticpro them.
5531 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5533 * window.c (Fwindow_total_size, Fwindow_left_column)
5534 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5535 (Fwindow_list_1): New functions.
5536 (window_box_text_cols): Replace with window_body_cols.
5537 (Fwindow_width, Fscroll_left, Fscroll_right):
5538 Use window_body_cols instead of window_box_text_cols.
5539 (delete_window, Fset_window_configuration):
5540 Call delete_all_subwindows with window as argument.
5541 (delete_all_subwindows): Take a window as argument and not a
5543 (window_loop): Remove handling of GET_LRU_WINDOW and
5545 (Fget_lru_window, Fget_largest_window): Move to window.el.
5547 * window.h: Extern window_body_cols instead of
5548 window_box_text_cols. delete_all_subwindows now takes a
5549 Lisp_Object as argument.
5551 * indent.c (compute_motion, Fcompute_motion):
5552 Use window_body_cols instead of window_box_text_cols.
5554 * frame.c (delete_frame): Call delete_all_subwindows with root
5557 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5559 * fns.c (Fputhash): Document return value.
5561 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5563 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5565 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5567 Cons<->int and similar integer overflow fixes (Bug#8794).
5569 Check for overflow when converting integer to cons and back.
5570 * charset.c (Fdefine_charset_internal, Fdecode_char):
5571 Use cons_to_unsigned to catch overflow.
5572 (Fencode_char): Use INTEGER_TO_CONS.
5573 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5574 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5575 * data.c (long_to_cons, cons_to_long): Remove.
5576 (cons_to_unsigned, cons_to_signed): New functions.
5577 These signal an error for invalid or out-of-range values.
5578 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5579 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5580 * font.c (Ffont_variation_glyphs):
5581 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5582 * lisp.h: Include <intprops.h>.
5583 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5584 (cons_to_signed, cons_to_unsigned): New decls.
5585 (long_to_cons, cons_to_long): Remove decls.
5586 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5587 (Fprimitive_undo): Use CONS_TO_INTEGER.
5588 * xfns.c (Fx_window_property): Likewise.
5589 * xselect.c: Include <limits.h>.
5590 (x_own_selection, selection_data_to_lisp_data):
5591 Use INTEGER_TO_CONS.
5592 (x_handle_selection_request, x_handle_selection_clear)
5593 (x_get_foreign_selection, Fx_disown_selection_internal)
5594 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5595 (lisp_data_to_selection_data): Use cons_to_unsigned.
5596 (x_fill_property_data): Use cons_to_signed.
5597 Report values out of range.
5599 Check for buffer and string overflow more precisely.
5600 * buffer.h (BUF_BYTES_MAX): New macro.
5601 * lisp.h (STRING_BYTES_MAX): New macro.
5602 * alloc.c (Fmake_string):
5603 * character.c (string_escape_byte8):
5604 * coding.c (coding_alloc_by_realloc):
5605 * doprnt.c (doprnt):
5606 * editfns.c (Fformat):
5608 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5609 since they may not be the same number.
5610 * editfns.c (Finsert_char):
5611 * fileio.c (Finsert_file_contents):
5612 Likewise for BUF_BYTES_MAX.
5614 * image.c: Use ptrdiff_t, not int, for sizes.
5615 (slurp_file): Switch from int to ptrdiff_t.
5617 (slurp_file): Check that file size fits in both size_t (for
5618 malloc) and ptrdiff_t (for sanity and safety).
5620 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5621 if b->modtime has its maximal value.
5623 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5625 Don't assume time_t can fit into int.
5626 * buffer.h (struct buffer.modtime): Now time_t, not int.
5627 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5628 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5630 Minor fixes for signed vs unsigned integers.
5631 * character.h (MAYBE_UNIFY_CHAR):
5632 * charset.c (maybe_unify_char):
5633 * keyboard.c (read_char, reorder_modifiers):
5634 XINT -> XFASTINT, since the integer must be nonnegative.
5635 * ftfont.c (ftfont_spec_pattern):
5636 * keymap.c (access_keymap, silly_event_symbol_error):
5637 XUINT -> XFASTINT, since the integer must be nonnegative.
5638 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5639 since it makes no difference and we prefer signed.
5640 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5641 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5644 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5646 * window.h (Fwindow_frame): Declare.
5648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5650 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5651 (SPARE_MEMORY): Always define.
5652 (LARGE_REQUEST): Remove.
5653 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5655 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5657 * lisp.h: Move EXFUNS for Fframe_root_window,
5658 Fframe_first_window and Fset_frame_selected_window to window.h.
5660 * window.h: Move EXFUNS for Fframe_root_window,
5661 Fframe_first_window and Fset_frame_selected_window here from
5664 * frame.c (Fwindow_frame, Fframe_first_window)
5665 (Fframe_root_window, Fframe_selected_window)
5666 (Fset_frame_selected_window): Move to window.c.
5667 (Factive_minibuffer_window): Move to minibuf.c.
5668 (Fother_visible_frames_p): New function.
5670 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5672 * window.c (decode_window, decode_any_window): Move up in code.
5673 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5674 (inhibit_frame_unsplittable): Remove unused variable.
5675 (Fwindow_buffer): Move up and rewrite doc-string.
5676 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5677 (Fwindow_prev): New functions.
5678 (Fwindow_frame): Move here from frame.c. Accept any window as
5680 (Fframe_root_window, Fframe_first_window)
5681 (Fframe_selected_window): Move here from frame.c. Accept frame
5682 or arbitrary window as argument. Update doc-strings.
5683 (Fminibuffer_window): Move up in code.
5684 (Fwindow_minibuffer_p): Move up in code and simplify.
5685 (Fset_frame_selected_window): Move here from frame.c.
5687 (Fselected_window, select_window, Fselect_window): Move up in
5688 code. Minor doc-string fixes.
5690 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5692 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5693 Do not assume that spare memory exists; that assumption is valid
5694 only if SYSTEM_MALLOC.
5695 (LARGE_REQUEST): New macro, so that the issue of large requests
5696 is separated from the issue of spare memory.
5698 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5700 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5703 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5705 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5708 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5710 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5712 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5714 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5715 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5717 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5719 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5721 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5723 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5724 (x_clipboard_manager_save): Add return value.
5725 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5727 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5728 Obey Vx_select_enable_clipboard_manager. Catch errors in
5729 x_clipboard_manager_save (Bug#8779).
5730 (Vx_select_enable_clipboard_manager): New variable.
5731 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5733 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5735 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5737 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5739 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5740 in the current matrix if keep_current_p is non-zero.
5742 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5744 * bidi.c (bidi_level_of_next_char): Fix last change.
5746 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5748 Support bidi reordering of text covered by display properties.
5750 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5751 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5752 (bidi_cache_search, bidi_cache_iterator_state)
5753 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5754 (bidi_level_of_next_char, bidi_move_to_visually_next):
5755 Support character positions inside a run of characters covered by a
5757 (bidi_paragraph_init, bidi_resolve_explicit_1)
5758 (bidi_level_of_next_char): Call bidi_fetch_char and
5759 bidi_fetch_char_advance instead of FETCH_CHAR and
5761 (bidi_init_it): Initialize new members.
5762 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5764 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5765 instead of using explicit *_CHAR codes.
5766 (bidi_resolve_explicit, bidi_resolve_weak):
5767 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5768 bidirectional text is supported only in multibyte buffers.
5769 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5770 it to initialize the frame_window_p member of struct bidi_it.
5771 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5772 (bidi_resolve_explicit, bidi_resolve_weak)
5773 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5774 bidi_it->nchars is non-positive.
5775 (bidi_level_of_next_char): Don't try to lookup the cache for the
5776 next/previous character if nothing is cached there yet, or if we
5777 were just reseat()'ed to a new position.
5779 * xdisp.c (set_cursor_from_row): Set start and stop points
5780 according to the row's direction when priming the loop that looks
5781 for the glyph on which to display cursor.
5782 (single_display_spec_intangible_p): Function deleted.
5783 (display_prop_intangible_p): Reimplement to call
5784 handle_display_spec instead of single_display_spec_intangible_p.
5785 Accept 3 additional arguments needed by handle_display_spec.
5786 This fixes incorrect cursor motion across display property with complex
5787 values: lists, `(when COND...)' forms, etc.
5788 (single_display_spec_string_p): Support property values that are
5789 lists with the argument STRING its top-level element.
5790 (display_prop_string_p): Fix the condition for processing a
5791 property that is a list to be consistent with handle_display_spec.
5792 (handle_display_spec): New function, refactored from the
5793 last portion of handle_display_prop.
5794 (compute_display_string_pos): Accept additional argument
5795 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5796 value of a `display' property is a "replacing spec".
5797 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5798 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5799 the display property, but just return a value indicating whether
5800 the display property will replace the characters it covers.
5801 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5802 frame_window_p members of struct bidi_it.
5803 (compute_display_string_pos, compute_display_string_end):
5805 (push_it): Accept second argument POSITION, where pop_it should
5806 jump to continue iteration.
5807 (reseat_1): Initialize bidi_it.disp_pos.
5809 * keyboard.c (adjust_point_for_property): Adjust the call to
5810 display_prop_intangible_p to its new signature.
5812 * dispextern.h (struct bidi_it): New member frame_window_p.
5813 (bidi_init_it): Update prototypes.
5814 (display_prop_intangible_p): Update prototype.
5815 (compute_display_string_pos, compute_display_string_end):
5817 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5820 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5822 Malloc failure behavior now depends on size of allocation.
5823 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5824 * lisp.h: Change signatures accordingly.
5825 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5826 All callers changed. (Bug#8762)
5828 * gnutls.c: Use Emacs's memory allocators.
5829 Without this change, the gnutls library would invoke malloc etc.
5830 directly, which causes problems on non-SYNC_INPUT hosts, and which
5831 runs afoul of improving memory_full behavior. (Bug#8761)
5832 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5833 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5834 xfree instead of the default malloc, realloc, free.
5835 (Fgnutls_boot): No need to check for memory allocation failure,
5836 since xmalloc does that for us.
5838 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5839 * category.c (hash_get_category_set):
5840 * ccl.c (ccl_driver):
5841 * charset.c (Fdefine_charset_internal):
5842 * charset.h (struct charset.hash_index):
5843 * composite.c (get_composition_id, gstring_lookup_cache)
5844 (composition_gstring_put_cache):
5845 * composite.h (struct composition.hash_index):
5846 * dispextern.h (struct image.hash):
5847 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5848 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5849 (hashfn_equal, hashfn_user_defined, make_hash_table)
5850 (maybe_resize_hash_table, hash_lookup, hash_put)
5851 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5852 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5853 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5854 * image.c (make_image, search_image_cache, lookup_image)
5855 (xpm_put_color_table_h):
5856 * lisp.h (struct Lisp_Hash_Table):
5857 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5858 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5859 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5860 * alloc.c (allocate_vectorlike):
5861 Check for overflow in vector size calculations.
5862 * ccl.c (ccl_driver):
5863 Check for overflow when converting EMACS_INT to int.
5864 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5865 need to be updated by these changes.
5866 * fns.c (make_hash_table, maybe_resize_hash_table):
5867 Check for integer overflow with large hash tables.
5868 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5869 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5870 (SXHASH_REDUCE): New macro.
5871 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5872 Use it instead of discarding useful hash info with large hash values.
5873 (sxhash_float): New function.
5874 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5875 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5876 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5877 Rewrite to use FIXNUM_BITS, as this simplifies things.
5878 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5879 Adjust signatures to match updated version of code.
5880 (consing_since_gc): Now EMACS_INT, since a single hash table can
5881 use more than INT_MAX bytes.
5883 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5885 Make it possible to build with GCC-4.6+ -O2 -flto.
5887 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5889 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5891 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5892 Call minibuffer-inactive-mode.
5894 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5896 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5897 Update dependencies.
5899 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5901 * data.c (init_data): Remove code for UTS, this system is not
5904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5906 Don't force ./temacs to start in terminal mode.
5908 * frame.c (make_initial_frame): Initialize faces in all cases, not
5909 only when CANNOT_DUMP is defined.
5910 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5914 * dispnew.c (add_window_display_history): Use const for the string
5915 pointer. Remove declaration, not needed.
5917 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5919 Use 'inline', not 'INLINE'.
5920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5921 * alloc.c, fontset.c (INLINE): Remove.
5922 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5923 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5924 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5925 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5926 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5928 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5930 Make it possible to run ./temacs.
5932 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5933 syms_of_callproc does the same thing. Remove test for
5934 "initialized", do it in the caller.
5935 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5937 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5939 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5940 (read_minibuf): Use get_minibuffer.
5941 (syms_of_minibuf): Use DEFSYM.
5942 (Qmetadata): New var.
5943 * data.c (Qbuffer): Don't make it static.
5944 (syms_of_data): Use DEFSYM.
5946 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5948 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5949 (CCL_CODE_MIN): New macro.
5951 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5953 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5955 * eval.c (Qdebug): Now static.
5956 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5957 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5958 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5960 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5962 * image.c: Various fixes to ImageMagick code comments.
5963 (Fimagemagick_types): Doc fix.
5965 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5967 Minor fixes prompted by GCC 4.6.0 warnings.
5969 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5971 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5972 (x_clipboard_manager_save_all): Move extern decl to ...
5973 * xterm.h: ... here, so that it can be checked for consistency.
5975 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5977 * xselect.c (x_clipboard_manager_save_frame)
5978 (x_clipboard_manager_save_all): New functions.
5979 (Fx_clipboard_manager_save): Lisp function deleted.
5981 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5982 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5984 * xterm.h: Update prototype.
5986 2011-05-28 William Xu <william.xwl@gmail.com>
5988 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5991 2011-05-28 Jim Meyering <meyering@redhat.com>
5993 Avoid a sign-extension bug in crypto_hash_function.
5994 * fns.c (to_uchar): Define.
5995 (crypto_hash_function): Use it to convert some newly-signed
5996 variables to unsigned, to avoid sign-extension bugs. For example,
5997 without this change, (md5 "truc") would evaluate to
5998 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5999 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6000 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6002 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6004 Integer overflow fixes.
6006 * dbusbind.c: Serial number integer overflow fixes.
6007 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6008 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6009 to hold a serial number that is too large for a fixnum.
6010 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6011 Check for serial numbers out of range. Decode any serial number
6012 that was so large that it became a float. (Bug#8722)
6014 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6015 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6016 Use XFASTINT rather than XUINT when numbers are nonnegative.
6017 (xd_append_arg, Fdbus_method_return_internal):
6018 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6019 arguments, check that Lisp number is nonnegative, rather than
6020 silently wrapping negative numbers around. (Bug#8722)
6021 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6024 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6026 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6028 ccl: Add integer overflow checks.
6029 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6030 (IN_INT_RANGE): New macros.
6031 (ccl_driver): Use them to check for integer overflow when
6032 decoding a CCL program. Many of the new checks are whether XINT (x)
6033 fits in int; it doesn't always, on 64-bit hosts. The new version
6034 doesn't catch all possible integer overflows, but it's an
6035 improvement. (Bug#8719)
6037 * alloc.c (make_event_array): Use XINT, not XUINT.
6038 There's no need for unsigned here.
6040 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6041 This follows up to the 2011-05-06 change that substituted uintptr_t
6042 for EMACS_INT. This case wasn't caught back then.
6044 Rework Fformat to avoid integer overflow issues.
6045 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6046 now (part of C89). Include <verify.h>.
6047 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6048 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6049 (Fformat): Avoid the prepass trying to compute sizes; it was only
6050 approximate and thus did not catch overflow reliably. Instead, walk
6051 through the format just once, formatting and computing sizes as we go,
6052 checking for integer overflow at every step, and allocating a larger
6053 buffer as needed. Keep track separately whether the format is
6054 multibyte. Keep only the most-recently calculated precision, rather
6055 than them all. Record whether each argument has been converted to
6056 string. Use EMACS_INT, not int, for byte and char and arg counts.
6057 Support field widths and precisions larger than INT_MAX. Avoid
6058 sprintf's undefined behavior with conversion specifications such as %#d
6059 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6060 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6061 formatting out-of-range floating point numbers with int
6064 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6066 * data.c: Avoid integer truncation in expressions involving floats.
6067 * data.c: Include <intprops.h>.
6068 (arith_driver): When there's an integer overflow in an expression
6069 involving floating point, convert the integers to floating point
6070 so that the resulting value does not suffer from catastrophic
6071 integer truncation. For example, on a 64-bit host (* 4
6072 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6073 Do not rely on undefined behavior after integer overflow.
6075 merge count_size_as_multibyte, parse_str_to_multibyte
6076 * character.c, character.h (count_size_as_multibyte):
6077 Rename from parse_str_to_multibyte; all uses changed.
6078 Check for integer overflow.
6079 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6080 since it's now a duplicate of the other. This is more of
6081 a character than a buffer op, so better that it's in character.c.
6082 * fns.c, print.c: Adjust to above changes.
6084 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6086 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6088 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6090 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6091 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6092 (x_clipboard_manager_save): Now static.
6093 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6095 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6096 (crypto_hash_function): Now static.
6097 Fix pointer signedness problems. Avoid unnecessary initializations.
6099 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6101 * termhooks.h (Vselection_alist): Make it terminal-local.
6103 * terminal.c (create_terminal): Initialize it.
6105 * xselect.c: Support for clipboard managers.
6106 (Vselection_alist): Move to termhooks.h as terminal-local var.
6107 (LOCAL_SELECTION): New macro.
6108 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6109 (symbol_to_x_atom): Remove gratuitous arg.
6110 (x_handle_selection_request, lisp_data_to_selection_data)
6111 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6112 (x_own_selection, x_get_local_selection, x_convert_selection):
6113 New arg, specifying work frame. Use terminal-local Vselection_alist.
6114 (some_frame_on_display): Delete unused function.
6115 (Fx_own_selection_internal, Fx_get_selection_internal)
6116 (Fx_disown_selection_internal, Fx_selection_owner_p)
6117 (Fx_selection_exists_p): New optional frame arg.
6118 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6119 (x_handle_selection_clear): Don't treat other terminals with the
6120 same keyboard specially. Use the terminal-local Vselection_alist.
6121 (x_clear_frame_selections): Use Frun_hook_with_args.
6123 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6125 * xterm.h: Add support for those atoms.
6127 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6129 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6130 (converted_selections, conversion_fail_tag): New global variables.
6131 (x_selection_request_lisp_error): Free the above.
6132 (x_get_local_selection): Remove unnecessary code.
6133 (x_reply_selection_request): Args changed; handle arbitrary array
6134 of converted selections stored in converted_selections.
6135 Separate the XChangeProperty and SelectionNotify steps.
6136 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6137 (x_convert_selection): New function.
6138 (x_handle_selection_event): Simplify.
6139 (x_get_foreign_selection): Don't ignore incoming requests while
6140 waiting for an answer; this will fail when we implement
6141 SAVE_TARGETS, and seems unnecessary anyway.
6142 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6143 (Vx_sent_selection_functions): Doc fix.
6145 2011-05-26 Leo Liu <sdl.web@gmail.com>
6147 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6149 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6151 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6153 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6154 for fringe update if it has periodic bitmap.
6155 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6156 and fringe_bitmap_periodic_p.
6158 * fringe.c (get_fringe_bitmap_data): New function.
6159 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6160 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6161 row. Mark glyph row for fringe update if periodicity changed.
6163 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6164 for fringe update unless it has periodic bitmap.
6166 2011-05-25 Kenichi Handa <handa@m17n.org>
6168 * xdisp.c (get_next_display_element): Set correct it->face_id for
6169 a static composition.
6171 2011-05-24 Leo Liu <sdl.web@gmail.com>
6174 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6176 * fns.c (crypto_hash_function, Fsha1): New function.
6177 (Fmd5): Use crypto_hash_function.
6178 (syms_of_fns): Add Ssha1.
6180 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6182 * gnutls.c: Remove unused macros.
6183 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6184 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6185 Remove macros that are defined and never used.
6186 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6188 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6190 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6191 (Fx_get_selection_internal): Minor cleanup.
6192 (Fx_own_selection_internal): Rename arguments for consistency with
6195 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6197 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6199 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6201 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6203 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6205 * dispnew.c (scrolling_window): Don't exclude the case that the
6206 last enabled row in the desired matrix touches the bottom boundary.
6208 2011-05-21 Glenn Morris <rgm@gnu.org>
6210 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6211 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6212 and add some more files.
6214 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6216 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6217 report_file_error introduced by the change from 2011-05-07.
6219 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6221 * systime.h (Time): Define only if emacs is defined.
6222 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6223 where the include path doesn't have X11/X.h by default. See
6224 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6226 2011-05-20 Kenichi Handa <handa@m17n.org>
6228 * composite.c (find_automatic_composition): Fix previous change.
6230 2011-05-20 Glenn Morris <rgm@gnu.org>
6232 * lisp.mk: New file, split from Makefile.in.
6233 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6234 (shortlisp): Remove.
6235 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6237 2011-05-19 Glenn Morris <rgm@gnu.org>
6239 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6240 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6241 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6242 (lisp): Set the order to that of loadup.el.
6243 (shortlisp): Make it a copy of $lisp.
6244 (SOME_MACHINE_LISP): Remove.
6245 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6246 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6248 2011-05-18 Kenichi Handa <handa@m17n.org>
6250 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6251 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6252 (find_automatic_composition): Mostly rewrite for efficiency.
6254 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6256 * makefile.w32-in: Update dependencies.
6258 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6260 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6261 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6263 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6265 Fix some integer overflow issues, such as string length overflow.
6267 * insdel.c (count_size_as_multibyte): Check for string overflow.
6269 * character.c (lisp_string_width): Check for string overflow.
6270 Use EMACS_INT, not int, for string indexes and lengths; in
6271 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6272 the resulting string length overflows an EMACS_INT; instead,
6273 report a string overflow if no precision given. When checking for
6274 precision exhaustion, use a check that cannot possibly have
6275 integer overflow. (Bug#8675)
6276 * character.h (lisp_string_width): Adjust to new signature.
6278 * alloc.c (string_overflow): New function.
6279 (Fmake_string): Use it. This doesn't change behavior, but saves
6280 a few bytes and will simplify future changes.
6281 * character.c (string_escape_byte8): Likewise.
6282 * lisp.h (string_overflow): New decl.
6284 Fixups, following up to the user-interface timestamp change.
6285 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6286 for UI timestamps, instead of unsigned long.
6287 * msdos.c (mouse_get_pos): Likewise.
6288 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6289 * w32gui.h (Time): Define by including "systime.h" rather than by
6290 declaring it ourselves. (Bug#8664)
6292 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6293 * image.c (clear_image_cache): Likewise.
6295 * term.c (term_mouse_position): Don't assume time_t wraparound.
6297 Be more systematic about user-interface timestamps.
6298 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6299 and sometimes 'EMACS_UINT', to represent these timestamps.
6300 This change causes it to use 'Time' uniformly, as that's what X uses.
6301 This makes the code easier to follow, and makes it easier to catch
6302 integer overflow bugs such as Bug#8664.
6303 * frame.c (Fmouse_position, Fmouse_pixel_position):
6304 Use Time, not unsigned long, for user-interface timestamps.
6305 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6306 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6307 * keyboard.h (last_event_timestamp): Likewise.
6308 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6309 * menu.h (xmenu_show): Likewise.
6310 * term.c (term_mouse_position): Likewise.
6311 * termhooks.h (struct input_event.timestamp): Likewise.
6312 (struct terminal.mouse_position_hook): Likewise.
6313 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6314 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6315 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6316 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6318 * menu.h, termhooks.h: Include "systime.h", for Time.
6320 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6321 Don't assume that the difference between two unsigned long values
6322 can fit into an integer. At this point, we know button_down_time
6323 <= event->timestamp, so the difference must be nonnegative, so
6324 there's no need to cast the result if double-click-time is
6325 nonnegative, as it should be; check that it's nonnegative, just in
6326 case. This bug is triggered when events are more than 2**31 ms
6327 apart (about 25 days). (Bug#8664)
6329 * xselect.c (last_event_timestamp): Remove duplicate decl.
6330 (x_own_selection): Remove needless cast to unsigned long.
6332 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6333 that always fit in int. Use a sentinel instead of a counter, to
6334 avoid a temp and to allay GCC's concerns about possible int overflow.
6335 * frame.h (struct frame): Use int for menu_bar_items_used
6336 instead of EMACS_INT, since it always fits in int.
6338 * menu.c (grow_menu_items): Check for int overflow.
6340 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6342 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6343 Before, the code was not consistent. These values cannot exceed
6344 2**31 - 1 so there's no need to make them unsigned.
6345 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6346 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6347 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6349 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6351 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6352 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6353 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6354 presumably because the widths might not match.
6356 * window.c (size_window): Avoid needless test at loop start.
6358 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6360 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6362 2011-05-12 Drew Adams <drew.adams@oracle.com>
6364 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6366 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6368 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6369 `width' to `bar_area_x' and `bar_area_width', respectively.
6370 (x_scroll_run): Take account of fringe background extension.
6372 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6373 Rename local vars `left' and `width' to `bar_area_x' and
6374 `bar_area_width', respectively.
6375 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6376 background extension.
6378 2011-05-10 Jim Meyering <meyering@redhat.com>
6380 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6382 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6384 * image.c (Finit_image_library): Return t for built-in image types,
6385 like pbm and xbm. (Bug#8640)
6387 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6389 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6391 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6393 * w32console.c (Fset_screen_color): Doc fix.
6394 (Fget_screen_color): New function.
6395 (syms_of_ntterm): Defsubr it.
6397 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6398 unlink the temporary file if Fcall_process didn't create it in the
6400 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6401 child process will be redirected to a file specified with `:file'.
6402 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6403 cue to call_process_cleanup not to close that handle.
6405 2011-05-07 Ben Key <bkey76@gmail.com>
6407 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6408 one of two shell specific rules, either bootstrap-temacs-CMD or
6409 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6410 to the previous implementation of the bootstrap-temacs rule.
6411 The bootstrap-temacs-CMD rule is similar to the previous
6412 implementation of the bootstrap-temacs rule except that it
6413 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6416 These changes, along with some changes to nt/configure.bat,
6417 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6418 earlier fix to add support for --cflags and --ldflags options
6419 that include quotes so that it works whether make uses cmd or
6422 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6424 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6425 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6427 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6428 a string. Handle both cases.
6429 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6430 (Fdbus_register_method): Use Qinvalid_function.
6432 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6434 * makefile.w32-in: Update dependencies.
6435 (LISP_H): Add inttypes.h and stdin.h.
6436 (PROCESS_H): Add unistd.h.
6438 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6440 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6441 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6443 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6445 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6447 * term.c (vfatal): Remove stray call to va_end.
6448 It's not needed and the C Standard doesn't allow it here anyway.
6450 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6451 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6453 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6456 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6458 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6460 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6462 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6464 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6466 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6467 * charset.c (Fdefine_charset_internal): Don't initialize
6468 charset.code_space[15]. The value was garbage, on hosts with
6469 32-bit int (Bug#8600).
6471 * lread.c (read_integer): Be more consistent with string-to-number.
6472 Use string_to_number to do the actual conversion; this avoids
6473 rounding errors and fixes some other screwups. Without this fix,
6474 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6475 (digit_to_number): Move earlier, for benefit of read_integer.
6476 Return -1 if the digit is out of range for the base, -2 if it is
6477 not a digit in any supported base. (Bug#8602)
6479 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6481 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6482 to match comment at start of function. This also removes a
6483 GCC warning about overflow in a 32+64-bit port.
6485 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6487 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6488 Reported by Stefan Monnier in
6489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6490 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6491 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6493 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6494 (EMACS_UINTPTR): Likewise, with uintptr_t.
6496 * lisp.h: Prefer 64-bit EMACS_INT if available.
6497 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6498 on 32-bit hosts that have 64-bit int, so that they can access
6500 However, temporarily disable this change unless the temporary
6501 symbol WIDE_EMACS_INT is defined.
6503 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6505 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6506 This removes an assumption that EMACS_INT and long are the same
6507 width as pointers. The assumption is true for Emacs porting targets
6508 now, but we want to make other targets possible.
6509 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6510 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6511 In the rest of the code, change types of integers that hold casted
6512 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6513 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6514 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6515 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6516 No need to cast type when ORing.
6517 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6518 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6519 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6520 assume EMACS_INT is the same width as char *.
6521 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6522 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6523 Remove no-longer-needed casts.
6524 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6525 (xg_tool_bar_help_callback, xg_make_tool_item):
6526 Use EMACS_INTPTR to hold an integer
6527 that will be cast to void *; this can avoid a GCC warning
6528 if EMACS_INT is not the same width as void *.
6529 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6530 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6531 (current_message_1, set_message_1):
6532 Use a local to convert to proper width without a cast.
6533 * xmenu.c (dialog_selection_callback): Likewise.
6535 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6536 Also, don't assume VALBITS / RAND_BITS is less than 5,
6537 and don't rely on undefined behavior when shifting a 1 left into
6539 * lisp.h (get_random): Change signature to match.
6541 * lread.c (hash_string): Use size_t, not int, for hash computation.
6542 Normally we prefer signed values; but hashing is special, because
6543 it's better to use unsigned division on hash table sizes so that
6544 the remainder is nonnegative. Also, size_t is the natural width
6545 for hashing into memory. The previous code used 'int', which doesn't
6546 retain enough info to hash well into very large tables.
6547 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6549 * dbusbind.c: Don't possibly lose pointer info when converting.
6550 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6551 Use XPNTR rather than XHASH, so that the high-order bits of
6552 the pointer aren't lost when converting through void *.
6554 * eval.c (Fautoload): Don't double-shift a pointer.
6556 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6558 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6560 * gnutls.c (DEF_GNUTLS_FN):
6561 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6563 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6565 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6568 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6570 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6571 New version that can reserve upto 2GB of heap space.
6573 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6575 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6577 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6579 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6580 `gnutls_certificate_set_x509_key_file'.
6582 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6584 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6585 Update dependencies.
6587 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6589 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6590 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6591 Remove unused parameter `fildes'.
6592 * process.c (read_process_output, send_process): Don't pass it.
6594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6596 Fix previous change: the library cache is defined in w32.c.
6597 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6598 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6600 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6602 Implement dynamic loading of GnuTLS on Windows.
6604 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6605 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6606 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6609 * gnutls.c (Qgnutls_dll): Define.
6610 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6611 (gnutls_*): Declare function pointers.
6612 (init_gnutls_functions): New function to initialize function pointers.
6613 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6614 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6615 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6616 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6617 (emacs_gnutls_write, emacs_gnutls_read)
6618 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6619 (Fgnutls_available_p): New function.
6620 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6621 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6622 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6624 * image.c: Include w32.h.
6625 (Vimage_type_cache): Delete.
6626 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6627 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6628 (w32_delayed_load): Move to w32.c.
6630 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6632 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6633 (w32_delayed_load): Move from image.c. When loading a library, record
6634 its filename in the :loaded-from property of the library id.
6635 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6636 Initialize and staticpro them.
6637 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6639 * process.c: Include lisp.h before w32.h, not after.
6640 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6641 instead of gnutls_record_check_pending.
6643 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6645 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6647 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6648 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6651 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6653 * xterm.c (x_set_frame_alpha): Do not set property on anything
6654 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6656 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6658 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6660 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6662 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6663 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6664 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6665 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6666 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6667 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6668 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6669 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6670 (Qgnutls_bootprop_callbacks_verify): Make static.
6672 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6674 * callproc.c: Indentation fixup.
6676 * sysdep.c (wait_for_termination_1): Make static.
6677 (wait_for_termination, interruptible_wait_for_termination):
6678 Move after wait_for_termination_1.
6680 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6682 * sysdep.c (interruptible_wait_for_termination): New function
6683 which is like wait_for_termination, but allows keyboard
6686 * callproc.c (Fcall_process): Add (:file "file") as an option for
6688 (Fcall_process_region): Ditto.
6690 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6692 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6693 rather than `XVECTOR (FOO)->size'.
6695 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6696 inttypes.h, as a gnulib replacement is used if it not available in
6699 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6701 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6702 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6703 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6705 * coding.c (coding_alloc_by_realloc): Error out if destination
6706 will grow beyond MOST_POSITIVE_FIXNUM.
6707 (decode_coding_emacs_mule): Abort if there isn't enough place in
6708 charbuf for the composition carryover bytes. Reserve an extra
6709 space for up to 2 characters produced in a loop.
6710 (decode_coding_iso_2022): Abort if there isn't enough place in
6711 charbuf for the composition carryover bytes.
6713 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6715 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6716 aborting when %lld or %lll format is passed.
6717 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6718 %llo or %llx format is passed. (Bug#8545)
6720 * window.c (window_scroll_line_based): Use a marker instead of
6721 simple variables to record original value of point. (Bug#7952)
6723 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6724 produced by %s or %c overflows available buffer space. (Bug#8545)
6726 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6728 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6729 (SIZE_MAX): Move defn after all includes, as they might #define it.
6731 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6733 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6735 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6737 * keyboard.c (Qdelayed_warnings_hook): Define.
6738 (command_loop_1): Run `delayed-warnings-hook'
6739 if Vdelayed_warnings_list is non-nil.
6740 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6741 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6743 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6745 * doprnt.c (doprnt): Don't return value smaller than the buffer
6746 size if the message was truncated. (Bug#8545).
6748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6750 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6751 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6753 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6755 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6757 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6759 * makefile.w32-in: Update dependencies.
6761 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6763 Improve `doprnt' and its usage. (Bug#8545)
6764 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6765 `format_end'. Remove support for %l as a conversion specifier.
6766 Don't use xrealloc. Improve diagnostics when the %l size modifier
6767 is used. Update the commentary.
6769 * eval.c (verror): Simplify calculation of size_t.
6771 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6774 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6776 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6779 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6781 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6782 This makes this file independent of the recent pseudovector change.
6784 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6786 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6788 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6789 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6790 Remove unused local.
6791 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6793 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6794 GCC 4.6.0 optimizes based on type-based alias analysis.
6795 For example, if b is of type struct buffer * and v of type struct
6796 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6797 != &v->size, and therefore "v->size = 1; b->size = 2; return
6798 v->size;" must therefore return 1. This assumption is incorrect
6799 for Emacs, since it type-puns struct Lisp_Vector * with many other
6800 types. To fix this problem, this patch adds a new type struct
6801 vectorlike_header that documents the constraints on layout of vectors
6802 and pseudovectors, and helps optimizing compilers not get fooled
6803 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6804 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6805 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6807 (XSETPVECTYPE): Rewrite in terms of new macro.
6808 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6809 This is a bit clearer, and further avoids the possibility of
6810 undesirable aliasing.
6811 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6812 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6813 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6814 since Lisp_Subr is a special case (no "next" field).
6815 (ASIZE): Now uses header.size rather than size.
6816 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6817 to avoid the hassle of writing XVECTOR (foo)->header.size.
6818 (struct vectorlike_header): New type.
6819 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6820 object, to help avoid aliasing.
6821 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6822 (SUBRP): Likewise, since Lisp_Subr is a special case.
6823 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6824 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6825 (struct Lisp_Hash_Table): Combine first two members into a single
6826 struct vectorlike_header member. All uses of "size" and "next" members
6827 changed to be "header.size" and "header.next".
6828 * buffer.h (struct buffer): Likewise.
6829 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6830 * frame.h (struct frame): Likewise.
6831 * process.h (struct Lisp_Process): Likewise.
6832 * termhooks.h (struct terminal): Likewise.
6833 * window.c (struct save_window_data, struct saved_window): Likewise.
6834 * window.h (struct window): Likewise.
6835 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6836 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6837 * buffer.c (init_buffer_once): Likewise.
6838 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6840 * process.c (Fformat_network_address): Use local var for size,
6843 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6845 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6846 * data.c (atof): Remove decl; no longer used or needed.
6847 (digit_to_number): Move to lread.c.
6848 (Fstring_to_number): Use new string_to_number function, to be
6849 consistent with how the Lisp reader treats infinities and NaNs.
6850 Do not assume that floating-point numbers represent EMACS_INT
6851 without losing information; this is not true on most 64-bit hosts.
6852 Avoid double-rounding errors, by insisting on integers when
6853 parsing non-base-10 numbers, as the documentation specifies.
6854 * lisp.h (string_to_number): New decl, replacing ...
6855 (isfloat_string): Remove.
6856 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6857 (read1): Do not accept +. and -. as integers; this
6858 appears to have been a coding error. Similarly, do not accept
6859 strings like +-1e0 as floating point numbers. Do not report
6860 overflow for integer overflows unless the base is not 10 which
6861 means we have no simple and reliable way to continue.
6862 Break out the floating-point parsing into a new
6863 function string_to_number, so that Fstring_to_number parses
6864 floating point numbers consistently with the Lisp reader.
6865 (digit_to_number): Move here from data.c. Make it static inline.
6866 (E_CHAR, EXP_INT): Remove, replacing with ...
6867 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6868 (string_to_number): New function, replacing isfloat_string.
6869 This function checks for valid syntax and produces the resulting
6870 Lisp float number too. Rework it so that string-to-number
6871 no longer mishandles examples like "1.0e+". Use strtoumax,
6872 so that overflow for non-base-10 numbers is reported only when
6873 there's no portable and simple way to convert to floating point.
6875 * textprop.c (set_text_properties_1): Rewrite for clarity,
6876 and to avoid GCC warning about integer overflow.
6878 * intervals.h (struct interval): Use EMACS_INT for members
6879 where EMACS_UINT might cause problems. See
6880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6881 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6882 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6884 (offset_intervals): Tell GCC not to worry about length overflow
6885 when negating a negative length.
6887 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6888 (overrun_check_free): Likewise.
6890 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6891 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6894 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6895 (gnutls_make_error): Rename local to avoid shadowing.
6896 (gnutls_emacs_global_deinit): ifdef out; not used.
6897 (Fgnutls_boot): Use const for pointer to readonly storage.
6898 Comment out unused local. Fix pointer signedness problems.
6900 * lread.c (openp): Don't stuff size_t into an 'int'.
6901 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6902 about possible signed overflow.
6904 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6905 (GDK_KEY_g): Don't define if already defined.
6906 (xg_prepare_tooltip): Avoid pointer signedness problem.
6907 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6909 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6910 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6912 * xfns.c (Fx_window_property): Simplify a bit,
6913 to make a bit faster and to avoid GCC 4.6.0 warning.
6914 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6916 * fns.c (internal_equal): Don't assume size_t fits in int.
6918 * alloc.c (compact_small_strings): Tighten assertion a little.
6920 Replace pEd with more-general pI, and fix some printf arg casts.
6921 * lisp.h (pI): New macro, generalizing old pEd macro to other
6922 conversion specifiers. For example, use "...%"pI"d..." rather
6923 than "...%"pEd"...".
6924 (pEd): Remove. All uses replaced with similar uses of pI.
6925 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6926 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6927 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6928 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6929 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6930 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6931 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6933 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6934 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6935 * print.c (safe_debug_print, print_object): Likewise.
6936 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6938 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6939 avoiding the 0 flag, which is not portable.
6940 * process.c (Fmake_network_process): Use pI to avoid cast.
6941 * region-cache.c (pp_cache): Likewise.
6942 * xdisp.c (decode_mode_spec): Likewise.
6943 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6944 behavior on 64-bit hosts with printf arg.
6945 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6946 (x_stop_queuing_selection_requests): Likewise.
6947 (x_get_window_property): Don't truncate byte count to an 'int'
6950 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6951 here, since it parses constructs like leading '-' and spaces,
6952 which are not wanted; and it overflows with large numbers.
6953 Instead, simply match F[0-9]+, which is what is wanted anyway.
6955 * alloc.c: Remove unportable assumptions about struct layout.
6956 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6957 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6958 (allocate_vectorlike, make_pure_vector): Use the new macros,
6959 plus offsetof, to remove unportable assumptions about struct layout.
6960 These assumptions hold on all porting targets that I know of, but
6961 they are not guaranteed, they're easy to remove, and removing them
6962 makes further changes easier.
6964 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6965 This doesn't fix a bug but makes the code clearer.
6966 (string_overrun_cookie): Now const. Use initializers that
6967 don't formally overflow signed char, to avoid warnings.
6968 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6969 can cause Emacs to crash when string overrun checking is enabled.
6970 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6971 multiple of sizeof (EMACS_INT); it need not be, if
6972 alignof(EMACS_INT) < sizeof (EMACS_INT).
6973 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6975 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6977 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6979 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6981 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6982 supposed to be handshaking. (Bug#8556)
6983 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6985 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6987 * lisp.h (Qdebug): List symbol.
6988 * eval.c (Qdebug): Restore global linkage.
6989 * keyboard.c (debug-on-event): New variable.
6990 (handle_user_signal): Break into debugger when debug-on-event
6991 matches the current signal symbol.
6993 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6995 * alloc.c (check_sblock, check_string_bytes)
6996 (check_string_free_list): Convert to standard C.
6998 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7000 * w32.c (emacs_gnutls_push): Fix typo.
7002 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7004 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7005 "cast to pointer from integer of different size".
7007 Improve doprnt and its use in verror. (Bug#8545)
7008 * doprnt.c (doprnt): Document the set of format control sequences
7009 supported by the function. Use SAFE_ALLOCA instead of always
7012 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7013 is one byte too soon. Don't use xrealloc; instead xfree and
7016 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7018 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7021 * gnutls.c: Renamed global_initialized to
7022 gnutls_global_initialized. Added internals for the
7023 :verify-hostname-error, :verify-error, and :verify-flags
7024 parameters of `gnutls-boot' and documented those parameters in the
7025 docstring. Start callback support.
7026 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7027 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7028 on error. Return error code.
7029 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7030 (emacs_gnutls_read): Likewise.
7031 (Fgnutls_boot): Return handshake error code.
7032 (emacs_gnutls_handle_error): New function.
7033 (wsaerror_to_errno): Likewise.
7035 * w32.h (emacs_gnutls_pull): Add prototype.
7036 (emacs_gnutls_push): Likewise.
7038 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7039 (emacs_gnutls_push): Likewise.
7041 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7043 * process.c (wait_reading_process_output): Check if GnuTLS
7044 buffered some data internally if no FDs are set for TLS
7047 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7048 (LIBS): Link to USER_LIBS.
7049 ($(BLD)/gnutls.$(0)): New target.
7051 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7053 * xdisp.c (handle_single_display_spec): Rename the
7054 display_replaced_before_p argument into display_replaced_p, to
7055 make it consistent with the commentary. Fix typos in the
7058 * textprop.c (syms_of_textprop): Remove dead code.
7059 (copy_text_properties): Delete obsolete commentary about an
7060 interface that was deleted long ago. Fix typos in the description
7063 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7064 to changes in oldXMenu/XMenu.h from 2011-04-16.
7065 <menu_help_message, prev_menu_help_message>: Constify.
7066 (IT_menu_make_room): menu->help_text is now `const char **';
7069 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7070 to changes in oldXMenu/XMenu.h from 2011-04-16.
7071 (struct XMenu): Declare `help_text' `const char **'.
7073 * xfaces.c <Qunspecified>: Make extern again.
7075 * syntax.c: Include sys/types.h before including regex.h, as
7078 * doc.c (get_doc_string): Improve the format passed to `error'.
7080 * doprnt.c (doprnt): Improve commentary.
7082 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7084 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7087 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7088 changes in globals.h immediately force recompilation.
7089 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7090 $(CURDIR)/s/ms-w32.h.
7091 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7093 * character.c (Fchar_direction): Function deleted.
7094 (syms_of_character): Don't defsubr it.
7095 <char-direction-table>: Deleted.
7097 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7099 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7100 * doprnt.c: Include limits.h.
7101 (SIZE_MAX): New macro.
7102 (doprnt): Return a size_t value. 2nd arg is now size_t.
7103 Many local variables are now size_t instead of int or unsigned.
7104 Improve overflow protection. Support `l' modifier for integer
7105 conversions. Support %l conversion. Don't assume an EMACS_INT
7106 argument for integer conversions and for %c.
7108 * lisp.h (doprnt): Restore prototype.
7110 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7113 * Makefile.in (base_obj): Add back doprnt.o.
7115 * deps.mk (doprnt.o): Add back prerequisites.
7116 (callint.o): Depend on character.h.
7118 * eval.c (internal_lisp_condition_case): Include the handler
7119 representation in the error message.
7120 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7121 when breaking from the loop.
7123 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7125 * callint.c (Fcall_interactively): When displaying error message
7126 about invalid control letter, pass the character's codepoint, not
7127 a pointer to its multibyte form. Improve display of the character
7128 in octal and display also its hex code.
7130 * character.c (char_string): Use %x to display the (unsigned)
7131 codepoint of an invalid character, to avoid displaying a bogus
7134 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7135 `error', not SYMBOL_NAME itself.
7137 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7138 character arguments to `error'.
7140 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7141 to `error' in error message about FINAL_CHAR argument. Make sure
7142 FINAL_CHAR is a character, and use %c when it is passed as
7143 argument to `error'.
7145 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7147 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7149 * w32.c: Include <time.h>.
7150 (sys_localtime): New function.
7152 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7154 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7156 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7158 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7160 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7163 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7165 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7166 gl_state.e_property when gl_state.object is Qt.
7168 * insdel.c (make_gap_larger): Remove limitation of buffer size
7171 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7173 * xdisp.c (lookup_glyphless_char_display)
7174 (produce_glyphless_glyph): Handle cons cell entry in
7175 glyphless-char-display.
7176 (Vglyphless_char_display): Document it.
7178 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7179 glyphless-char-display.
7181 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7183 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7185 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7187 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7188 definition for no-X builds.
7190 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7192 Static checks with GCC 4.6.0 and non-default toolkits.
7194 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7196 * process.c (keyboard_bit_set): Define only if SIGIO.
7197 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7198 (send_process): Repair possible setjmp clobbering.
7200 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7202 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7204 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7206 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7207 Define only if needed.
7209 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7210 by pacifying GCC about it. Maybe it's time to retire it?
7211 * xfaces.c (USG, __TIMEVAL__): Likewise.
7213 * dispextern.h (struct redisplay_interface): Rename param
7215 * termhooks.h (struct terminal): Likewise.
7216 * xterm.c (xembed_send_message): Likewise.
7218 * insdel.c (make_gap_smaller): Define only if
7219 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7221 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7224 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7225 so that we aren't warned about unused symbols.
7227 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7229 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7231 * xfns.c (x_real_positions): Mark locals as initialized.
7233 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7235 * xterm.c: Fix problems found by static analysis with other toolkits.
7236 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7237 (x_dispatch_event): Declare static if USE_GTK, and
7238 define if USE_GTK || USE_X_TOOLKIT.
7239 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7240 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7241 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7242 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7244 * xmenu.c (menu_help_callback): Pointer type fixes.
7245 Use const pointers when pointing at readonly data. Avoid pointer
7247 (FALSE): Remove unused macro.
7248 (update_frame_menubar): Remove unused decl.
7250 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7252 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7253 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7254 (single_menu_item): Rename local to avoid shadowing.
7256 * keyboard.c (make_lispy_event): Remove unused local var.
7258 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7259 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7261 * bitmaps: Change bitmaps from unsigned char back to the X11
7262 compatible char. Avoid the old compiler warnings about
7263 out-of-range initializers by using, for example, '\xab' rather
7266 * xgselect.c (xgselect_initialize): Check vs interface
7267 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7269 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7271 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7272 to read-only memory.
7274 * fns.c (vector): Remove; this old hack is no longer needed.
7276 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7278 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7280 * xrdb.c (x_load_resources): Omit unused local.
7282 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7283 (x_window): Rename locals to avoid shadowing.
7284 (USG): Use the kludged USG macro, to pacify gcc.
7286 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7287 (x_term_init): Remove local to avoid shadowing.
7289 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7291 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7292 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7294 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7296 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7298 Fix regex.c, syntax.c and friends for buffers > 2GB.
7299 * syntax.h (struct gl_state_s): Declare character position members
7302 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7304 * textprop.c (verify_interval_modification, interval_of):
7305 Declare arguments EMACS_INT.
7307 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7310 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7312 * indent.c (Fvertical_motion): Local variable it_start is now
7315 * regex.c (re_match, re_match_2, re_match_2_internal)
7316 (bcmp_translate, regcomp, regexec, print_double_string)
7317 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7318 (re_compile_pattern, re_exec): Declare arguments and local
7319 variables `size_t' and `ssize_t' and return values `regoff_t', as
7321 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7322 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7323 <compile_stack_type>: `size' and `avail' are now `size_t'.
7325 * regex.h <regoff_t>: Use ssize_t, not int.
7326 (re_search, re_search_2, re_match, re_match_2): Arguments that
7327 specify buffer/string position and length are now ssize_t and
7328 size_t. Return type is regoff_t.
7330 2011-04-16 Ben Key <bkey76@gmail.com>
7332 * nsfont.m: Fixed bugs in ns_get_family and
7333 ns_descriptor_to_entity that were caused by using free to
7334 deallocate memory blocks that were allocated by xmalloc (via
7335 xstrdup). This caused Emacs to crash when compiled with
7336 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7337 --enable-checking=xmallocoverrun). xfree is now used to
7338 deallocate these memory blocks.
7340 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7342 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7344 emacs_write: Accept and return EMACS_INT for sizes.
7345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7347 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7348 Accept and return EMACS_INT.
7349 (emacs_gnutls_write): Return the number of bytes written on
7351 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7352 (emacs_read, emacs_write): Remove check for negative size, as the
7353 Emacs source code has been audited now.
7354 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7355 (emacs_read, emacs_write): Use it.
7356 * process.c (send_process): Adjust to the new signatures of
7357 emacs_write and emacs_gnutls_write. Do not attempt to store
7358 a byte offset into an 'int'; it might overflow.
7359 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7361 * sound.c: Don't assume sizes fit in 'int'.
7362 (struct sound_device.period_size, alsa_period_size):
7363 Return EMACS_INT, not int.
7364 (struct sound_device.write, vox_write, alsa_write):
7365 Accept EMACS_INT, not int.
7366 (wav_play, au_play): Use EMACS_INT to store sizes and to
7367 record read return values.
7369 2011-04-15 Ben Key <bkey76@gmail.com>
7371 * keyboard.c (Qundefined): Don't declare static since it is used
7373 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7374 static since they are used in nsfont.m.
7376 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7378 * process.c (Qprocessp): Don't declare static.
7379 * lisp.h (Qprocessp): Declare again.
7381 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7383 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7385 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7387 Improve C-level modularity by making more things 'static'.
7389 Don't publish debugger-only interfaces to other modules.
7390 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7391 (verify_bytepos, count_markers): Move decls to the only modules
7393 * region-cache.h (pp_cache): Likewise.
7394 * window.h (check_all_windows): Likewise.
7395 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7397 * sysdep.c (croak): Now static, if
7398 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7399 * syssignal.h (croak): Declare only if not static.
7401 * alloc.c (refill_memory_reserve): Now static if
7402 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7403 * lisp.h (refill_memory_reserve): Declare only if not static.
7405 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7406 Define only if USE_LUCID.
7408 * xrdb.c (x_customization_string, x_rm_string): Now static.
7410 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7411 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7413 * xdisp.c (draw_row_with_mouse_face): Now static.
7414 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7416 * window.h (check_all_windows): Mark externally visible.
7418 * window.c (window_deletion_count): Now static.
7420 * undo.c: Make symbols static if they're not exported.
7421 (last_undo_buffer, last_boundary_position, pending_boundary):
7424 * textprop.c (interval_insert_behind_hooks): Now static.
7425 (interval_insert_in_front_hooks): Likewise.
7427 * term.c: Make symbols static if they're not exported.
7428 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7429 (max_frame_lines, tty_set_terminal_modes):
7430 (tty_reset_terminal_modes, tty_turn_off_highlight):
7431 (get_tty_terminal): Now static.
7432 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7433 * termhooks.h (term_mouse_moveto): Do not declare if
7435 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7436 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7438 * sysdep.c: Make symbols static if they're not exported.
7439 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7441 (sigprocmask_set, full_mask): Remove; unused.
7442 (wait_debugging): Mark as visible.
7443 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7444 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7446 * syntax.c (syntax_temp): Define only if !__GNUC__.
7448 * sound.c (current_sound_device, current_sound): Now static.
7450 * search.c (searchbufs, searchbuf_head): Now static.
7452 * scroll.c (scroll_cost): Remove; unused.
7453 * dispextern.h (scroll_cost): Remove decl.
7455 * region-cache.h (pp_cache): Mark as externally visible.
7457 * process.c: Make symbols static if they're not exported.
7458 (process_tick, update_tick, create_process, chan_process):
7459 (Vprocess_alist, proc_buffered_char, datagram_access):
7460 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7461 (deactivate_process): Mark defn as static, as well as decl.
7462 * lisp.h (create_process): Remove decl.
7463 * process.h (chan_process, Vprocess_alist): Remove decls.
7465 * print.c: Make symbols static if they're not exported.
7466 (print_depth, new_backquote_output, being_printed, print_buffer):
7467 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7468 (print_interval, print_number_index, initial_stderr_stream):
7470 * lisp.h (Fprinc): Remove decl.
7471 (debug_output_compilation_hack): Mark as externally visible.
7473 * sysdep.c (croak): Move decl from here to syssignal.h.
7474 * syssignal.h (croak): Put it here, so the API can be checked when
7475 'croak' is called from dissociate_if_controlling_tty.
7477 * minibuf.c: Make symbols static if they're not exported.
7478 (minibuf_save_list, choose_minibuf_frame): Now static.
7479 * lisp.h (choose_minibuf_frame): Remove decl.
7481 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7483 * lread.c: Make symbols static if they're not exported.
7484 (read_objects, initial_obarray, oblookup_last_bucket_number):
7486 (make_symbol): Remove; unused.
7487 * lisp.h (initial_obarray, make_symbol): Remove decls.
7489 * keyboard.c: Make symbols static if they're not exported.
7490 (single_kboard, recent_keys_index, total_keys, recent_keys):
7491 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7492 (this_single_command_key_start, echoing, last_auto_save):
7493 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7494 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7495 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7496 (Vlispy_mouse_stem, double_click_count):
7498 (force_auto_save_soon): Define only if SIGDANGER.
7499 (ignore_mouse_drag_p): Now static if
7500 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7501 (print_help): Remove; unused.
7502 (stop_character, last_timer_event): Mark as externally visible.
7503 * keyboard.h (ignore_mouse_drag_p): Declare only if
7504 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7505 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7506 * lisp.h (echoing): Remove decl.
7507 (force_auto_save_soon): Declare only if SIGDANGER.
7508 * xdisp.c (redisplay_window): Simplify code, to make it more
7509 obvious that ignore_mouse_drag_p is not accessed if !defined
7510 USE_GTK && !defined HAVE_NS.
7512 * intervals.c: Make symbols static if they're not exported.
7513 (merge_properties_sticky, merge_interval_right, delete_interval):
7515 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7517 * insdel.c: Make symbols static if they're not exported.
7518 However, leave prepare_to_modify_buffer alone. It's never
7519 called from outside this function, but that appears to be a bug.
7520 (combine_after_change_list, combine_after_change_buffer):
7521 (adjust_after_replace, signal_before_change): Now static.
7522 (adjust_after_replace_noundo): Remove; unused.
7523 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7524 (signal_before_change): Remove decls.
7526 * indent.c (val_compute_motion, val_vmotion): Now static.
7528 * image.c: Make symbols static if they're not exported.
7529 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7531 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7532 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7534 * fringe.c (standard_bitmaps): Now static.
7535 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7537 * frame.c: Make symbols static if they're not exported.
7538 (x_report_frame_params, make_terminal_frame): Now static.
7539 (get_frame_param): Now static, unless HAVE_NS.
7540 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7541 (x_get_resource_string): Remove; not used.
7542 * frame.h (make_terminal_frame, x_report_frame_params):
7543 (x_get_resource_string); Remove decls.
7544 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7545 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7547 * font.c, fontset.c: Make symbols static if they're not exported.
7548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7549 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7550 * font.c (font_close_object): Now static.
7551 * font.h (font_close_object): Remove.
7552 * fontset.c (FONTSET_OBJLIST): Remove.
7553 (free_realized_fontset) #if-0 the body, which does nothing.
7554 (face_suitable_for_char_p): #if-0, as it's never called.
7555 * fontset.h (face_suitable_for_char_p): Remove decl.
7556 * xfaces.c (face_at_string_position):
7557 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7558 since 0 is always ASCII.
7560 * fns.c (weak_hash_tables): Now static.
7562 * fileio.c: Make symbols static if they're not exported.
7563 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7564 (Vwrite_region_annotation_buffers): Now static.
7566 * eval.c: Make symbols static if they're not exported.
7567 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7568 * lisp.h (backtrace_list): Remove decl.
7570 * emacs.c: Make symbols static if they're not exported.
7571 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7572 (fatal_error_code, fatal_error_signal_hook, standard_args):
7574 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7575 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7576 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7577 * lisp.h (fatal_error_signal_hook): Remove decl.
7578 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7580 * editfns.c: Move a (normally-unused) function to its only use.
7581 * editfns.c, lisp.h (get_operating_system_release): Remove.
7582 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7583 worth the hassle of breaking this out.
7585 * xterm.c: Make symbols static if they're not exported.
7586 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7587 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7588 (x_destroy_window, x_delete_display):
7590 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7591 (x_mouse_leave): Remove; unused.
7592 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7593 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7594 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7596 (x_mouse_leave): Declare only if WINDOWSNT.
7597 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7598 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7601 * ftxfont.c: Make symbols static if they're not exported.
7602 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7604 * font.h (ftxfont_driver): Likewise.
7606 * xfns.c: Make symbols static if they're not exported.
7607 (x_last_font_name, x_display_info_for_name):
7608 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7609 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7610 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7611 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7612 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7613 (last_show_tip_args): Now static.
7614 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7615 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7616 (x_screen_planes): Remove; unused.
7617 * dispextern.h (x_screen_planes): Remove decl.
7619 * dispnew.c: Make symbols static if they're not exported.
7620 * dispextern.h (redraw_garbaged_frames, scrolling):
7621 (increment_row_positions): Remove.
7622 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7623 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7625 (redraw_garbaged_frames): Remove; unused.
7627 * xfaces.c: Make symbols static if they're not exported.
7628 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7630 * xterm.h (defined_color): Remove decls.
7631 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7632 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7633 (menu_face_changed_default, defined_color, free_realized_face):
7634 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7635 (ascii_face_of_lisp_face): Remove; unused.
7637 * xdisp.c: Make symbols static if they're not exported.
7638 * dispextern.h (scratch_glyph_row, window_box_edges):
7639 (glyph_to_pixel_coords, set_cursor_from_row):
7640 (get_next_display_element, set_iterator_to_next):
7641 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7642 (show_mouse_face): Remove decls
7643 * frame.h (message_buf_print): Likewise.
7644 * lisp.h (pop_message, set_message, check_point_in_composition):
7646 * xterm.h (set_vertical_scroll_bar): Likewise.
7647 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7648 (message_buf_print, scratch_glyph_row, displayed_buffer):
7649 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7650 (get_next_display_element, show_mouse_face, window_box_edges):
7651 (frame_to_window_pixel_xy, check_point_in_composition):
7652 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7653 (glyph_to_pixel_coords): Remove; unused.
7655 * dired.c (file_name_completion): Now static.
7657 * dbusbind.c (xd_in_read_queued_messages): Now static.
7659 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7660 * data.c (circular_list_error): Remove.
7662 * commands.h (last_point_position, last_point_position_buffer):
7663 (last_point_position_window): Remove decls.
7664 * keyboard.c: Make these variables static.
7666 * coding.h (coding, code_convert_region, encode_coding_gap):
7668 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7669 (iso_code_class, detect_coding, code_convert_region): Now static.
7670 (encode_coding_gap): Remove; unused.
7672 * chartab.c (chartab_chars, chartab_bits): Now static.
7674 * charset.h (charset_iso_8859_1): Remove decl.
7675 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7678 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7679 * ccl.c (Vccl_program_table): Now static.
7680 (check_ccl_update): Remove; unused.
7682 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7683 * category.h: ... from here.
7684 * category.c (check_category_table, set_category_set): Now static.
7686 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7687 * lisp.h: Remove these decls.
7689 * buffer.c (buffer_count): Remove unused var.
7691 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7692 so that it's not optimized away.
7693 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7694 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7695 exported only to the debugger.
7697 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7698 * atimer.h (run_all_atimers): Remove; not exported.
7700 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7701 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7702 was inaccessible from Lisp.
7703 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7704 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7706 alloc.c: Import and export fewer symbols, and remove unused items.
7707 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7709 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7710 it's not optimized away by whole-program optimization.
7711 (message_enable_multibyte, free_misc): Remove.
7712 (catchlist, handlerlist, mark_backtrace):
7713 Declare only if BYTE_MARK_STACK.
7714 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7715 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7716 (message_enable_multibyte): Remove decl.
7717 (free_misc, interval_free_list, float_block, float_block_index):
7718 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7719 (cons_free_list, last_marked_index):
7721 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7722 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7723 (mark_backtrace): Define only if BYTE_MARK_STACK.
7724 * xdisp.c (message_enable_multibyte): Now static.
7726 Declare Lisp_Object Q* variables to be 'static' if not exported.
7727 This makes it easier for human readers (and static analyzers)
7728 to see whether these variables are used from other modules.
7729 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7730 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7731 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7732 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7733 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7734 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7735 * xmenu.c, xselect.c:
7736 Declare Q* vars static if they are not used in other modules.
7737 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7738 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7739 Remove decls of unexported vars.
7740 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7742 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7744 Make Emacs functions such as Fatom 'static' by default.
7745 This makes it easier for human readers (and static analyzers)
7746 to see whether these functions can be called from other modules.
7747 DEFUN now defines a static function. To make the function external
7748 so that it can be used in other C modules, use the new macro DEFUE.
7749 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7750 (Finit_image_library):
7751 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7752 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7753 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7754 Remove decls, since these functions are now static.
7755 (Funintern, Fget_internal_run_time): New decls, since these functions
7756 were already external.
7758 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7759 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7760 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7761 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7762 * keyboard.c, keymap.c, lread.c:
7763 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7764 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7765 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7766 Mark functions with DEFUE instead of DEFUN,
7767 if they are used in other modules.
7768 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7769 decls for now-static functions.
7770 * buffer.h (Fdelete_overlay): Remove decl.
7771 * callproc.c (Fgetenv_internal): Mark as internal.
7772 * composite.c (Fremove_list_of_text_properties): Remove decl.
7773 (Fcomposition_get_gstring): New forward static decl.
7774 * composite.h (Fcomposite_get_gstring): Remove decl.
7775 * dired.c (Ffile_attributes): New forward static decl.
7776 * doc.c (Fdocumntation_property): New forward static decl.
7777 * eval.c (Ffetch_bytecode): New forward static decl.
7778 (Funintern): Remove extern decl; now in .h file where it belongs.
7779 * fileio.c (Fmake_symbolic_link): New forward static decl.
7780 * image.c (Finit_image_library): New forward static decl.
7781 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7782 * intervals.h (Fprevious_property_change):
7783 (Fremove_list_of_text_properties): Remove decls.
7784 * keyboard.c (Fthis_command_keys): Remove decl.
7785 (Fcommand_execute): New forward static decl.
7786 * keymap.c (Flookup_key): New forward static decl.
7787 (Fcopy_keymap): Now static.
7788 * keymap.h (Flookup_key): Remove decl.
7789 * process.c (Fget_process): New forward static decl.
7790 (Fprocess_datagram_address): Mark as internal.
7791 * syntax.c (Fsyntax_table_p): New forward static decl.
7792 (skip_chars): Remove duplicate decl.
7793 * textprop.c (Fprevious_property_change): New forward static decl.
7794 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7796 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7797 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7799 * editfns.c (Fformat): Remove unreachable code.
7801 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7803 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7806 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7808 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7809 when at ZV. (Bug#8487)
7811 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7813 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7815 * keyboard.c (parse_tool_bar_item): Likewise.
7816 * sound.c (sound_cleanup, alsa_close): Likewise.
7817 * termcap.c (tgetent): Likewise.
7818 * xfns.c (x_default_font_parameter): Likewise.
7819 * xsettings.c (read_and_apply_settings): Likewise.
7821 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7822 (overrun_check_free): Protoize.
7824 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7826 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7827 since callers should never pass a negative size.
7828 Change the signature to match that of plain 'read' and 'write'; see
7829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7830 * lisp.h: Update prototypes of emacs_write and emacs_read.
7832 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7834 * xdisp.c (redisplay_window): Don't try to determine the character
7835 position of the scroll margin if the window start point w->startp
7836 is outside the buffer's accessible region. (Bug#8468)
7838 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7840 Fix write-region and its subroutines for buffers > 2GB.
7841 * fileio.c (a_write, e_write): Modify declaration of arguments and
7842 local variables to support buffers larger than 2GB.
7843 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7845 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7846 argument, local variables, and return value.
7848 * lisp.h: Update prototypes of emacs_write and emacs_read.
7850 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7852 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7854 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7856 Fix more problems found by GCC 4.6.0's static checks.
7858 * xdisp.c (vmessage): Use a better test for character truncation.
7860 * charset.c (load_charset_map): <, not <=, for optimization,
7861 and to avoid potential problems with integer overflow.
7862 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7863 * casetab.c (set_identity, shuffle): Likewise.
7864 * editfns.c (Fformat): Likewise.
7865 * syntax.c (skip_chars): Likewise.
7867 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7868 This also lets GCC 4.6.0 generate slightly better loop code.
7870 * callint.c (Fcall_interactively): <, not <=, for optimization.
7871 (Fcall_interactively): Count the number of arguments produced,
7872 not the number of arguments given. This is simpler and lets GCC
7873 4.6.0 generate slightly better code.
7875 * ftfont.c: Distingish more carefully between FcChar8 and char.
7876 The previous code passed unsigned char * to a functions like
7877 strlen and xstrcasecmp that expect char *, which does not
7878 conform to the C standard.
7879 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7880 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7881 char * when the C standard requires it.
7883 * keyboard.c (read_char): Remove unused var.
7885 * eval.c: Port to Windows vsnprintf (Bug#8435).
7887 (SIZE_MAX): Define if the headers do not.
7888 (verror): Do not give up if vsnprintf returns a negative count.
7889 Instead, grow the buffer. This ports to Windows vsnprintf, which
7890 does not conform to C99. Problem reported by Eli Zaretskii.
7891 Also, simplify the allocation scheme, by avoiding the need for
7892 calling realloc, and removing the ALLOCATED variable.
7894 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7896 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7897 But keep the doprint source code for now, as we might revamp it
7898 and use it again (Bug#8435).
7899 * lisp.h (doprnt): Remove.
7900 * Makefile.in (base_obj): Remove doprnt.o.
7901 * deps.mk (doprnt.o): Remove.
7903 error: Print 32- and 64-bit integers portably (Bug#8435).
7904 Without this change, on typical 64-bit hosts error ("...%d...", N)
7905 was used to print both 32- and 64-bit integers N, which relied on
7907 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7908 * lisp.h (error, verror): Mark as printf-like functions.
7909 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7910 Report overflow in size calculations when allocating printf buffer.
7911 Do not truncate output string at its first null byte.
7912 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7913 Truncate the output at a character boundary, since vsnprintf does not
7915 * charset.c (check_iso_charset_parameter): Convert internal
7916 character to string before calling 'error', since %c now has the
7918 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7919 overflow when computing char to be passed to 'error'. Do not
7920 pass Lisp_Object to 'error'; pass the integer instead.
7921 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7922 formatted with plain %d.
7924 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7926 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7928 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7930 * xterm.c (x_catch_errors): Remove duplicate declaration.
7932 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7934 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7936 2011-04-10 Jim Meyering <meyering@redhat.com>
7938 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7939 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7940 return ssize_t not "int", and use size_t as the buffer length.
7941 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7942 * gnutls.h: Update declarations.
7943 * process.c (read_process_output): Use ssize_t, to match.
7944 (send_process): Likewise.
7946 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7948 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7950 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7952 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7953 Use unsigned char, to match FcChar8 type definition.
7955 * xterm.c (handle_one_xevent):
7956 * xmenu.c (create_and_show_popup_menu):
7957 * xselect.c (x_decline_selection_request)
7958 (x_reply_selection_request): Avoid type-punned deref of X events.
7960 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7962 Fix some uses of `int' instead of EMACS_INT.
7963 * search.c (string_match_1, fast_string_match)
7964 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7965 (scan_buffer, find_next_newline_no_quit)
7966 (find_before_next_newline, search_command, Freplace_match)
7967 (Fmatch_data): Make some `int' variables be EMACS_INT.
7969 * xdisp.c (display_count_lines): 3rd argument and return value now
7970 EMACS_INT. All callers changed.
7971 (pint2hrstr): Last argument is now EMACS_INT.
7973 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7974 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7975 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7976 (decode_coding_utf_16, decode_coding_emacs_mule)
7977 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7978 (decode_coding_ccl, decode_coding_charset)
7979 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7980 (decode_coding_iso_2022, decode_coding_emacs_mule)
7981 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7982 <char_offset, last_offset>: Declare EMACS_INT.
7983 (encode_coding_utf_8, encode_coding_utf_16)
7984 (encode_coding_emacs_mule, encode_invocation_designation)
7985 (encode_designation_at_bol, encode_coding_iso_2022)
7986 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7987 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7989 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7990 (encode_invocation_designation): Last argument P_NCHARS is now
7992 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7993 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7995 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7998 * ccl.c (Fccl_execute_on_string): Declare some variables
8001 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8003 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8005 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8007 * process.c (Fformat_network_address): Doc fix.
8009 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8011 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8013 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8015 * keyboard.c (read_char): Call Lisp function help-form-show,
8016 instead of using internal_with_output_to_temp_buffer.
8017 (Qhelp_form_show): New var.
8018 (syms_of_keyboard): Use DEFSYM macro.
8020 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8022 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8024 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8026 * process.c (Flist_processes): Remove to Lisp.
8027 (list_processes_1): Delete.
8029 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8031 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8033 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8035 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8037 Fix more problems found by GCC 4.6.0's static checks.
8039 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8041 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8043 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8045 * xdisp.c (vmessage): Mark as a printf-like function.
8047 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8049 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8051 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8052 printf-like functions.
8053 (tiff_load): Add casts to remove these marks before passing them
8054 to system-supplied API.
8056 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8058 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8059 This avoids several warnings with gcc -Wstrict-overflow.
8060 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8061 directly, rather than having caller test rule sign. This avoids
8062 some unnecessary tests.
8063 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8064 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8065 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8067 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8068 (xfont_open): Avoid unnecessary tests.
8070 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8072 * composite.h, composite.c (composition_gstring_put_cache):
8073 Use EMACS_INT, not int, for length.
8075 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8076 breaking out part of COMPOSITION_DECODE_RULE.
8077 (COMPOSITION_DECODE_RULE): Use it.
8078 * composite.c (get_composition_id): Remove unused local vars,
8079 by using the new macro.
8081 * textprop.c (set_text_properties_1): Change while to do-while,
8082 since the condition is always true at first.
8084 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8085 (interval_deletion_adjustment): Return unsigned value.
8088 * process.c (list_processes_1, create_pty, read_process_output):
8089 (exec_sentinel): Remove vars that were set but not used.
8090 (create_pty): Remove unnecessary "volatile"s.
8091 (Fnetwork_interface_info): Avoid possibility of int overflow.
8092 (read_process_output): Do adaptive read buffering even if carryover.
8093 (read_process_output): Simplify nbytes computation if buffered.
8095 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8097 * syntax.c (scan_words): Remove var that was set but not used.
8098 (update_syntax_table): Use unsigned instead of int.
8100 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8101 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8102 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8104 * print.c (print_error_message): Avoid int overflow.
8106 * font.c (font_list_entities): Redo for clarity,
8107 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8109 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8110 (font_score): Avoid potential overflow in diff calculation.
8112 * fns.c (substring_both): Remove var that is set but not used.
8113 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8115 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8117 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8118 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8119 can always succeed if overflow has undefined behavior.
8121 * search.c (boyer_moore, wordify): Remove vars set but not used.
8122 (wordify): Omit three unnecessary tests.
8124 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8125 All callers changed. This avoids the need for an unused var.
8127 * casefiddle.c (casify_region): Remove var that is set but not used.
8129 * dired.c (file_name_completion): Remove var that is set but not used.
8131 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8133 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8134 (Finsert_file_contents): Remove unnecessary code checking fd.
8136 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8137 Check for integer overflow on size calculations.
8139 * buffer.c (Fprevious_overlay_change): Remove var that is set
8142 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8143 Remove vars that are set but not used.
8144 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8145 (timer_check_2): Mark vars as initialized.
8147 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8149 * image.c (lookup_image): Remove var that is set but not used.
8150 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8152 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8153 that are set but not used.
8155 * xfns.c (make_invisible_cursor): Don't return garbage
8156 if XCreateBitmapFromData fails (Bug#8410).
8158 * xselect.c (x_get_local_selection, x_handle_property_notify):
8159 Remove vars that are set but not used.
8161 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8162 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8164 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8165 Remove var that is set but not used.
8166 (scroll_bar_windows_size): Now size_t, not int.
8167 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8170 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8171 (map_tty_color) [!defined MSDOS]: Likewise.
8173 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8175 * coding.c: Remove vars that are set but not used.
8176 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8177 All callers changed.
8178 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8179 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8180 (decode_coding_charset): Remove vars that are set but not used.
8182 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8183 that is set but not used.
8185 * print.c (print_object): Remove var that is set but not used.
8187 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8188 The gnulib version avoids calling malloc in the usual case,
8189 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8190 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8191 * filelock.c (current_lock_owner): Likewise.
8192 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8193 * sysdep.c: Include allocator.h, careadlinkat.h.
8194 (emacs_no_realloc_allocator): New static constant.
8195 (emacs_readlink): New function.
8196 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8197 ../lib/careadlinkat.h.
8199 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8201 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8202 first non-nil return value).
8204 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8206 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8207 if not defined (Bug#8403).
8209 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8211 * xdisp.c (display_count_lines): Remove parameter `start',
8212 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8213 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8214 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8215 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8216 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8217 and thereabouts. All callers changed.
8218 (get_per_char_metric): Remove parameter `f', unused since
8219 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8221 2011-04-02 Jim Meyering <meyering@redhat.com>
8223 do not dereference NULL upon failed strdup
8224 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8225 (ns_get_family): Likewise.
8227 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8229 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8231 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8233 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8236 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8238 Add lexical binding.
8240 * window.c (Ftemp_output_buffer_show): New fun.
8241 (Fsave_window_excursion):
8242 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8244 * lread.c (lisp_file_lexically_bound_p): New function.
8245 (Fload): Bind Qlexical_binding.
8246 (readevalloop): Remove `evalfun' arg.
8247 Bind Qinternal_interpreter_environment.
8248 (Feval_buffer): Bind Qlexical_binding.
8249 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8251 (syms_of_lread): Declare `lexical-binding'.
8253 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8255 * keyboard.c (eval_dyn): New fun.
8256 (menu_item_eval_property): Use it.
8258 * image.c (parse_image_spec): Use Ffunctionp.
8260 * fns.c (concat, mapcar1): Accept byte-code-functions.
8262 * eval.c (Fsetq): Handle lexical vars.
8263 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8264 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8265 (FletX, Flet): Obey lexical binding.
8266 (Fcommandp): Handle closures.
8267 (Feval): New `lexical' arg.
8268 (eval_sub): New function extracted from Feval. Use it almost
8269 everywhere where Feval was used. Look up vars in lexical env.
8271 (Ffunctionp): Move from subr.el.
8272 (Ffuncall): Handle closures.
8273 (apply_lambda): Remove `eval_flags'.
8274 (funcall_lambda): Handle closures and new byte-code-functions.
8275 (Fspecial_variable_p): New function.
8276 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8277 but without exporting it to Lisp.
8279 * doc.c (Fdocumentation, store_function_docstring):
8280 * data.c (Finteractive_form): Handle closures.
8282 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8285 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8287 (exec_byte_code): New function extracted from Fbyte_code to handle new
8288 calling convention for byte-code-functions. Add new byte-codes.
8290 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8292 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8294 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8296 * xdisp.c (redisplay_internal): Fix prototype.
8298 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8300 * xdisp.c (SCROLL_LIMIT): New macro.
8301 (try_scrolling): Use it when setting scroll_limit.
8302 Limit scrolling to 100 screen lines.
8303 (redisplay_window): Even when falling back on "recentering",
8304 position point in the window according to scroll-conservatively,
8305 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8307 (try_scrolling): When point is above the window, allow searching
8308 as far as scroll_max, or one screenful, to compute vertical
8309 distance from PT to the scroll margin position. This prevents
8310 try_scrolling from unnecessarily failing when
8311 scroll-conservatively is set to a value slightly larger than the
8312 window height. Clean up the case of PT below the margin at bottom
8313 of window: scroll_max can no longer be INT_MAX. When aggressive
8314 scrolling is in use, don't let point enter the opposite scroll
8315 margin as result of the scroll.
8316 (syms_of_xdisp) <scroll-conservatively>: Document the
8317 threshold of 100 lines for never-recentering scrolling.
8319 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8321 * dispextern.h (move_it_by_lines):
8322 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8323 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8324 (message_log_check_duplicate): Remove parameters `prev_bol' and
8325 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8326 (redisplay_internal): Remove parameter `preserve_echo_area',
8327 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8329 * indent.c (Fvertical_motion):
8330 * window.c (window_scroll_pixel_based, Frecenter):
8331 Don't pass `need_y_p' to `move_it_by_lines'.
8333 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8335 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8336 steal a few bits to be more compact.
8337 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8338 Remove unneeded casts.
8340 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8342 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8344 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8345 binding" message (bug#7967).
8347 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8349 Fix more problems found by GCC 4.6.0's static checks.
8351 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8352 Remove unused local var.
8354 * editfns.c (Fmessage_box): Remove unused local var.
8356 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8357 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8358 Omit unused local vars.
8359 * window.c (shrink_windows): Omit unused local var.
8360 * menu.c (digest_single_submenu): Omit unused local var.
8361 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8362 Omit unused local var.
8364 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8365 Don't assume string length fits in int.
8366 (keyremap_step, read_key_sequence): Use size_t for sizes.
8367 (read_key_sequence): Don't check last_real_key_start redundantly.
8369 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8370 instead of alloca (Bug#8344).
8372 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8373 (Fbacktrace_frame): Don't assume nframes fits in int.
8375 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8377 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8380 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8382 * cm.c (calccost): Turn while-do into do-while, for clarity.
8384 * keyboard.c (syms_of_keyboard): Use the same style as later
8385 in this function when indexing through an array. This also
8386 works around GCC bug 48267.
8388 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8390 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8392 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8393 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8395 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8396 This avoids undefined behavior on integer overflow, and is a bit
8397 more convenient anyway since it is compared to a size_t variable.
8399 Variadic C functions now count arguments with size_t, not int.
8400 This avoids an unnecessary limitation on 64-bit machines, which
8401 caused (substring ...) to crash on large vectors (Bug#8344).
8402 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8404 All variadic functions and their callers changed accordingly.
8405 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8406 * data.c (arith_driver, float_arith_driver): Likewise.
8407 * editfns.c (general_insert_function): Likewise.
8408 * eval.c (struct backtrace.nargs, interactive_p)
8409 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8410 (funcall_lambda, mark_backtrace): Likewise.
8411 * fns.c (concat): Likewise.
8412 * frame.c (x_set_frame_parameters): Likewise.
8413 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8414 0 if not found, not -1. All callers changed.
8416 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8417 (stack_copy_size): Now size_t, not int.
8418 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8420 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8422 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8423 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8424 All callers changed.
8426 * lisp.h (multibyte_char_to_unibyte):
8427 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8428 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8429 * character.h (CHAR_TO_BYTE8):
8430 * cmds.c (internal_self_insert):
8431 * editfns.c (general_insert_function):
8432 * keymap.c (push_key_description):
8433 * search.c (Freplace_match):
8434 * xdisp.c (message_dolog, set_message_1): All callers changed.
8436 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8438 * keyboard.c (safe_run_hook_funcall): New function.
8439 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8440 don't set the hook to nil, but remove the offending function instead.
8441 (Qcommand_hook_internal): Remove, unused.
8442 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8443 Vcommand_hook_internal.
8445 * eval.c (enum run_hooks_condition): Remove.
8446 (funcall_nil, funcall_not): New functions.
8447 (run_hook_with_args): Call each function through a `funcall' argument.
8448 Remove `cond' argument, now redundant.
8449 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8450 (Frun_hook_with_args_until_failure): Adjust accordingly.
8451 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8453 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8455 * dispextern.h (string_buffer_position): Remove declaration.
8457 * print.c (strout): Remove parameter `multibyte', unused since
8458 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8460 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8461 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8462 All callers changed.
8464 * w32.c (_wsa_errlist): Use braces for struct initializers.
8466 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8467 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8468 All callers changed.
8469 (string_buffer_position): Likewise. Also, make static (it's never
8470 used outside xdisp.c).
8471 (cursor_row_p): Remove parameter `w', unused since
8472 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8473 (decode_mode_spec): Remove parameter `precision', introduced during
8474 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8475 All callers changed.
8477 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8479 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8481 2011-03-27 Anders Lindgren <andlind@gmail.com>
8483 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8484 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8485 (ns_update_auto_hide_menu_bar): New functions.
8486 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8487 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8488 ns_constrain_all_frames.
8489 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8490 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8492 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8494 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8496 2011-03-27 Glenn Morris <rgm@gnu.org>
8498 * syssignal.h: Replace RETSIGTYPE with void.
8499 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8500 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8501 Replace SIGTYPE with void everywhere.
8502 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8503 * s/template.h (SIGTYPE): Remove commented out definition.
8505 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8507 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8508 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8510 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8512 * w32.c (read_unc_volume): Use parameter `henum', instead of
8513 global variable `wget_enum_handle'.
8515 * keymap.c (describe_vector): Remove parameters `indices' and
8516 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8517 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8519 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8521 * keyboard.c (timer_check): Remove parameter `do_it_now',
8522 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8523 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8524 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8526 * keyboard.c (read_char):
8527 * w32menu.c (w32_menu_display_help):
8528 * xmenu.c (show_help_event, menu_help_callback):
8529 Adjust calls to `show_help_echo'.
8531 * gtkutil.c (xg_maybe_add_timer):
8532 * keyboard.c (readable_events):
8533 * process.c (wait_reading_process_output):
8534 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8536 * insdel.c (adjust_markers_gap_motion):
8537 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8538 (gap_left, gap_right): Don't call it.
8540 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8542 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8543 incurred during fontification.
8545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8547 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8548 (DEFVAR_PER_BUFFER): Don't pass it.
8550 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8551 (scrolling_window): Don't pass it.
8553 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8555 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8557 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8559 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8560 of variables specific to SELinux and computation of `encoded_absname'.
8562 * image.c (XPutPixel): Remove unused variable `height'.
8564 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8566 * unexw32.c (get_section_info): Remove unused variable `section'.
8568 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8569 (system_process_attributes): Remove unused variable `sess'.
8570 (sys_read): Remove unused variable `err'.
8572 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8573 (w32_wnd_proc): Remove unused variable `isdead'.
8574 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8575 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8576 (x_create_tip_frame): Remove unused variable `tem'.
8578 * w32inevt.c (w32_console_read_socket):
8579 Remove unused variable `no_events'.
8581 * w32term.c (x_draw_composite_glyph_string_foreground):
8582 Remove unused variable `width'.
8584 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8586 * w32term.c (x_set_glyph_string_clipping):
8587 Don't pass uninitialized region to CombineRgn.
8589 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8591 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8592 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8593 (Fx_close_connection): Remove unused variable `i'.
8595 * w32font.c (w32font_draw): Return number of glyphs.
8596 (w32font_open_internal): Remove unused variable `i'.
8597 (w32font_driver): Add missing initializer.
8599 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8600 (fill_in_menu): Remove unused variable `items_added'.
8602 * w32term.c (last_mouse_press_frame): Remove static global variable.
8603 (w32_clip_to_row): Remove unused variable `f'.
8604 (x_delete_terminal): Remove unused variable `i'.
8606 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8607 (NOTHING): Remove unused static global variable.
8608 (uniscribe_check_otf): Remove unused variable `table'.
8609 (uniscribe_font_driver): Add missing initializers.
8611 2011-03-23 Julien Danjou <julien@danjou.info>
8613 * term.c (Fsuspend_tty, Fresume_tty):
8614 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8615 * window.c (temp_output_buffer_show):
8616 * insdel.c (signal_before_change):
8617 * frame.c (Fhandle_switch_frame):
8618 * fileio.c (Fdo_auto_save):
8619 * emacs.c (Fkill_emacs):
8620 * editfns.c (save_excursion_restore):
8621 * cmds.c (internal_self_insert):
8622 * callint.c (Fcall_interactively):
8623 * buffer.c (Fkill_all_local_variables):
8624 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8626 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8627 unconditionally since it does the check itself.
8629 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8631 Fix more problems found by GCC 4.5.2's static checks.
8633 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8634 the first time through the loop, since we know p0 < p1 then.
8635 This also avoids a gcc -Wstrict-overflow warning.
8637 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8638 leading to a memory leak, possible in functions like
8639 load_charset_map_from_file that can allocate an unbounded number
8640 of objects (Bug#8318).
8642 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8643 that could (at least in theory) be that large.
8645 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8646 This is less likely to overflow, and avoids undefined behavior if
8647 overflow does occur. All callers changed. Use strtoul to scan
8648 for the unsigned long integer.
8649 (pint2hrstr): Simplify and tune code slightly.
8650 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8652 * scroll.c (do_scrolling): Work around GCC bug 48228.
8653 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8655 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8656 This also avoids a warning with gcc -Wstrict-overflow.
8657 (validate_x_resource_name): Simplify count usage.
8658 This also avoids a warning with gcc -Wstrict-overflow.
8660 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8663 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8665 * process.c (Fmake_network_process): Use socklen_t, not int,
8666 where POSIX says socklen_t is required in portable programs.
8667 This fixes a porting bug on hosts like 64-bit HP-UX, where
8668 socklen_t is wider than int (Bug#8277).
8669 (Fmake_network_process, server_accept_connection):
8670 (wait_reading_process_output, read_process_output):
8673 * process.c: Rename or move locals to avoid shadowing.
8674 (list_processes_1, Fmake_network_process):
8675 (read_process_output_error_handler, exec_sentinel_error_handler):
8676 Rename or move locals.
8677 (Fmake_network_process): Define label "retry_connect" only if needed.
8678 (Fnetwork_interface_info): Fix pointer signedness.
8679 (process_send_signal): Add cast to avoid pointer signedness problem.
8680 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8681 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8683 Make tparam.h and terminfo.c consistent.
8684 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8685 Include tparam.h instead, since it declares them.
8686 * cm.h (PC): Remove extern decl; tparam.h now does this.
8687 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8688 * terminfo.c: Include tparam.h, to check interfaces.
8689 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8690 (tparam): Adjust signature to match interface in tparam.h;
8691 this removes some undefined behavior. Check that outstring and len
8692 are zero, which they always are with Emacs.
8693 * tparam.h (PC, BC, UP): New extern decls.
8695 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8696 (xftfont_open): Rename locals to avoid shadowing.
8698 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8699 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8700 (OTF_TAG_SYM): Omit macro if not needed.
8701 (ftfont_list): Remove unused local.
8702 (get_adstyle_property, ftfont_pattern_entity):
8703 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8704 Rename locals to avoid shadowing.
8706 * xfont.c (xfont_list_family): Mark var as initialized.
8708 * xml.c (make_dom): Now static.
8710 * composite.c (composition_compute_stop_pos): Rename local to
8712 (composition_reseat_it): Remove unused locals.
8713 (find_automatic_composition, composition_adjust_point): Likewise.
8714 (composition_update_it): Mark var as initialized.
8715 (find_automatic_composition): Mark vars as initialized,
8716 with a FIXME (Bug#8290).
8718 character.h: Rename locals to avoid shadowing.
8719 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8720 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8721 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8722 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8725 * textprop.c (property_change_between_p): Remove; unused.
8727 * intervals.c (interval_start_pos): Now static.
8729 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8731 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8732 Rename locals to avoid shadowing.
8734 * sound.c (wav_play, au_play, Fplay_sound_internal):
8735 Fix pointer signedness.
8736 (alsa_choose_format): Remove unused local var.
8737 (wav_play): Initialize a variable to 0, to prevent undefined
8738 behavior (Bug#8278).
8740 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8742 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8744 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8745 clobbering (Bug#8298).
8746 * sysdep.c (sys_subshell): Likewise.
8747 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8749 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8750 This should get cleaned up, so that child_setup has the
8751 same signature on all platforms.
8753 * callproc.c (call_process_cleanup): Now static.
8754 (relocate_fd): Rename locals to avoid shadowing.
8756 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8758 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8759 not to be necessary, and produces flickering.
8761 2011-03-20 Glenn Morris <rgm@gnu.org>
8763 * config.in: Remove file.
8765 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8767 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8768 are now in src/globals.h.
8769 (syms_of_minibuf): Remove spurious & from previous change.
8771 2011-03-20 Leo Liu <sdl.web@gmail.com>
8773 * minibuf.c (completing-read-function): New variable.
8774 (completing-read-default): Rename from completing-read.
8775 (completing-read): Call completing-read-function.
8777 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8779 * xfaces.c (Fx_load_color_file):
8780 Read color file from absolute filename (bug#8250).
8782 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8784 * makefile.w32-in: Update dependencies.
8786 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8788 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8790 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8792 Fix more problems found by GCC 4.5.2's static checks.
8794 * process.c (make_serial_process_unwind, send_process_trap):
8795 (sigchld_handler): Now static.
8797 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8798 That way, the code declares only the vars that it needs.
8799 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8800 * s/cygwin.h (PTY_ITERATION): Likewise.
8801 * s/darwin.h (PTY_ITERATION): Likewise.
8802 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8804 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8805 * process.c (allocate_pty): Don't declare stb unless it's needed.
8807 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8808 (CONSTANTLIM): Remove; unused.
8809 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8810 Define only if needed.
8812 * unexelf.c (unexec): Name an expression,
8813 to avoid gcc -Wbad-function-cast warning.
8814 Use a different way to cause a compilation error if anyone uses
8815 n rather than nn, a way that does not involve shadowing.
8816 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8818 * deps.mk (unexalpha.o): Remove; unused.
8820 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8821 * unexec.h: New file.
8822 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8823 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8825 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8826 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8827 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8828 Change as necessary to match prototype in unexec.h.
8830 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8832 (back_comment, skip_chars): Mark vars as initialized.
8834 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8835 Rename locals to avoid shadowing.
8837 * lread.c (read1): Rewrite so as not to use empty "else".
8838 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8840 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8842 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8843 warning when compiling print.c.
8845 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8846 instead of using an uninitialized var.
8847 (font_sort_entities): Mark var as initialized.
8849 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8851 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8852 pointers to constants.
8853 (font_parse_fcname): Remove unused vars.
8854 (font_delete_unmatched): Now static.
8855 (font_get_spec): Remove; unused.
8856 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8857 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8858 Rename or move locals to avoid shadowing.
8860 * fns.c (require_nesting_list, require_unwind): Now static.
8861 (Ffillarray): Rename locals to avoid shadowing.
8863 * floatfns.c (domain_error2): Define only if needed.
8864 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8866 * alloc.c (mark_backtrace): Move decl from here ...
8867 * lisp.h: ... to here, so that it can be checked.
8869 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8870 (Fdefvar): Rewrite so as not to use empty "else".
8871 (lisp_indirect_variable): Name an expression,
8872 to avoid gcc -Wbad-function-cast warning.
8873 (Fdefvar): Rename locals to avoid shadowing.
8875 * callint.c (quotify_arg, quotify_args): Now static.
8876 (Fcall_interactively): Rename locals to avoid shadowing.
8877 Use const pointer when appropriate.
8879 * lisp.h (get_system_name, get_operating_system_release):
8880 Move decls here, to check interfaces.
8881 * process.c (get_operating_system_release): Move decl to lisp.h.
8882 * xrdb.c (get_system_name): Likewise.
8883 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8884 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8885 some of which prompt warnings from gcc -Wbad-function-cast.
8886 (Fformat_time_string, Fencode_time, Finsert_char):
8887 (Ftranslate_region_internal, Fformat):
8888 Rename or remove local vars to avoid shadowing.
8889 (Ftranslate_region_internal): Mark var as initialized.
8891 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8894 * lisp.h (eassert): Check that the argument compiles, even if
8895 ENABLE_CHECKING is not defined.
8897 * data.c (Findirect_variable): Name an expression, to avoid
8898 gcc -Wbad-function-cast warning.
8899 (default_value, arithcompare, arith_driver, arith_error): Now static.
8900 (store_symval_forwarding): Rename local to avoid shadowing.
8901 (Fmake_variable_buffer_local, Fmake_local_variable):
8902 Mark variables as initialized.
8903 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8905 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8906 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8907 Rename locals to avoid shadowing.
8908 (mark_stack): Move local variables into the #ifdef region where
8910 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8911 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8913 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8914 (GC_STRING_CHARS): Remove; not used.
8915 (Fmemory_limit): Cast sbrk's returned value to char *.
8917 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8918 avoids undefined behavior in theory.
8920 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8922 Use functions, not macros, for up- and down-casing (Bug#8254).
8923 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8924 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8925 to use the following functions instead of these macros.
8926 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8927 EMACS_INT, since callers assume the returned value fits in int.
8928 (upcase1): Likewise, for UPCASE_TABLE.
8929 (uppercasep, lowercasep, upcase): New static inline functions.
8930 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8931 the race-condition problem in the old DOWNCASE.
8933 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8934 Rename locals to avoid shadowing.
8935 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8936 (regex_compile, re_search_2, re_match_2_internal):
8937 Remove unused local vars.
8938 (FREE_VAR): Rewrite so as not to use empty "else",
8939 which gcc can warn about.
8940 (regex_compile, re_match_2_internal): Mark locals as initialized.
8941 (RETALLOC_IF): Define only if needed.
8942 (WORDCHAR_P): Likewise. This one is never needed, but is used
8943 only in a comment talking about a compiler bug, so put inside
8944 the #if 0 of that comment.
8945 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8946 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8949 * search.c (boyer_moore): Rename locals to avoid shadowing.
8950 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8951 (PREV_CHAR_BOUNDARY): Likewise.
8953 * search.c (simple_search): Remove unused var.
8955 * dired.c (compile_pattern): Move decl from here ...
8956 * lisp.h: ... to here, so that it can be checked.
8957 (struct re_registers): New forward decl.
8959 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8961 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8963 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8964 Rename locals to avoid shadowing.
8965 (Fvertical_motion): Mark locals as initialized.
8967 * casefiddle.c (casify_object, casify_region): Now static.
8968 (casify_region): Mark local as initialized.
8970 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8972 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8973 New macros, so that the caller can use some names other than
8974 gcpro1, gcpro2, etc.
8975 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8977 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8978 argument, for consistency with GCPRO2_VAR, etc: it is now the
8979 prefix of the variable, not the variable itself. All uses
8981 * dired.c (directory_files_internal, file_name_completion):
8982 Rename locals to avoid shadowing.
8984 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8985 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8986 dired.c's scmp function, had undefined behavior.
8987 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8989 * buffer.h: ... to here, because these macros use current_buffer,
8990 and the new implementation with inline functions needs to have
8991 current_buffer in scope now, rather than later when the macros
8993 (downcase, upcase1): New static inline functions.
8994 (DOWNCASE, UPCASE1): Reimplement using these functions.
8995 This avoids undefined behavior in expressions like
8996 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8997 from race conditions in accessing the global variables
8998 case_temp1 and case_temp2.
8999 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9000 * lisp.h (case_temp1, case_temp2): Remove their decls.
9001 * character.h (ASCII_CHAR_P): Move from here ...
9002 * lisp.h: ... to here, so that the inline functions mentioned
9005 * dired.c (directory_files_internal_unwind): Now static.
9007 * fileio.c (file_name_as_directory, directory_file_name):
9008 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9010 (file_name_as_directory): Use const pointers when appropriate.
9011 (Fexpand_file_name): Likewise. In particular, newdir might
9012 point at constant storage, so make it a const pointer.
9013 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9014 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9016 (Fset_file_times, Finsert_file_contents, auto_save_error):
9017 Rename locals to avoid shadowing.
9019 * minibuf.c (choose_minibuf_frame_1): Now static.
9020 (Ftry_completion, Fall_completions): Rename or remove locals
9023 * marker.c (bytepos_to_charpos): Remove; unused.
9025 * lisp.h (verify_bytepos, count_markers): New decls,
9026 so that gcc does not warn that these functions aren't declared.
9028 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9029 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9030 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9031 (copy_text): Remove unused local var.
9033 * filelock.c (within_one_second): Now static.
9034 (lock_file_1): Rename local to avoid shadowing.
9036 * buffer.c (fix_overlays_before): Mark locals as initialized.
9037 (fix_start_end_in_overlays): Likewise. This function should be
9038 simplified by using pointers-to-pointers, but that's a different
9040 (switch_to_buffer_1): Now static.
9041 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9042 (report_overlay_modification): Rename locals to avoid shadowing.
9044 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9045 Fix pointer signedness issue.
9046 (sys_subshell): Mark local as volatile if checking for lint,
9047 to suppress a gcc -Wclobbered warning that does not seem to be right.
9048 (MAXPATHLEN): Define only if needed.
9050 * process.c (serial_open, serial_configure): Move decls from here ...
9051 * systty.h: ... to here, so that they can be checked.
9053 * fns.c (get_random, seed_random): Move extern decls from here ...
9054 * lisp.h: ... to here, so that they can be checked.
9056 * sysdep.c (reset_io): Now static.
9057 (wait_for_termination_signal): Remove; unused.
9059 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9060 (copy_keymap_item, append_key, push_text_char_description):
9062 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9063 (DENSE_TABLE_SIZE): Remove; unused.
9064 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9065 (describe_map_tree):
9066 Rename locals to avoid shadowing.
9068 * keyboard.c: Declare functions static if they are not used elsewhere.
9069 (echo_char, echo_dash, cmd_error, top_level_2):
9070 (poll_for_input, handle_async_input): Now static.
9071 (read_char, kbd_buffer_get_event, make_lispy_position):
9072 (make_lispy_event, make_lispy_movement, apply_modifiers):
9073 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9074 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9075 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9076 (read_key_sequence, read_char): Mark locals as initialized.
9077 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9079 * keyboard.h (make_ctrl_char): New decl.
9080 (mark_kboards): Move decl here ...
9081 * alloc.c (mark_kboards): ... from here.
9083 * lisp.h (force_auto_save_soon): New decl.
9085 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9086 (DEFINE_DUMMY_FUNCTION): New macro.
9087 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9089 (main): Add casts to avoid warnings
9090 if GCC considers string literals to be constants.
9092 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9094 * dbusbind.c: Pointer signedness fixes.
9095 (xd_signature, xd_append_arg, xd_initialize):
9096 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9097 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9098 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9099 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9101 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9102 if GCC considers string literals to be constants.
9103 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9105 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9107 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9108 (print_preprocess, print_object): New macro to fix last change.
9110 * print.c (print_preprocess): Don't forget font objects.
9112 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9114 * emacs.c (USAGE3): Doc fixes.
9116 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9118 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9121 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9123 * lisp.h (VWindow_system, Qfile_name_history):
9124 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9125 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9126 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9128 * w32select.c: Don't #include "keyboard.h".
9129 (run_protected): Add extern declaration for waiting_for_input.
9131 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9132 * w32console.c (detect_input_pending, read_input_pending)
9133 (encode_terminal_code):
9134 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9135 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9136 (w32_system_caret_y, Qfile_name_history):
9137 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9138 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9139 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9140 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9141 * w32proc.c (Qlocal, report_file_error):
9142 * w32term.c (Vwindow_system, updating_frame):
9143 * w32uniscribe.c (initialized, uniscribe_font_driver):
9144 Remove unneeded extern declarations.
9146 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9148 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9150 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9152 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9153 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9154 These macros can no longer be used for assignment.
9156 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9157 Assign struct members directly, instead of using BUF_BEGV etc.
9158 (record_buffer_markers, fetch_buffer_markers): New functions for
9159 recording and fetching special buffer markers.
9160 (set_buffer_internal_1, set_buffer_temp): Use them.
9162 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9164 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9166 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9167 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9169 * xdisp.c (hscroll_window_tree):
9170 (reconsider_clip_changes): Use PT instead of BUF_PT.
9172 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9174 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9175 $(EMACS_ROOT)/lib/intprops.h.
9177 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9179 Fix more problems found by GCC 4.5.2's static checks.
9181 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9182 to unsigned char * to avoid compiler diagnostic.
9183 (xg_free_frame_widgets): Make it clear that a local variable is
9184 needed only if USE_GTK_TOOLTIP.
9185 (gdk_window_get_screen): Make it clear that this macro is needed
9186 only if USE_GTK_TOOLTIP.
9187 (int_gtk_range_get_value): New function, which avoids a diagnostic
9188 from gcc -Wbad-function-cast.
9189 (xg_set_toolkit_scroll_bar_thumb): Use it.
9190 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9191 diagnostic from gcc -Wbad-function-cast.
9192 (get_utf8_string, xg_get_file_with_chooser):
9193 Rename locals to avoid shadowing.
9194 (create_dialog): Move locals to avoid shadowing.
9196 * xgselect.c (xg_select): Remove unused var.
9198 * image.c (four_corners_best): Mark locals as initialized.
9199 (gif_load): Initialize transparent_p to zero (Bug#8238).
9200 Mark another local as initialized.
9201 (my_png_error, my_error_exit): Mark with NO_RETURN.
9203 * image.c (clear_image_cache): Now static.
9204 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9205 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9206 (x_edge_detection): Remove unnecessary cast that
9207 gcc -Wbad-function-cast diagnoses.
9208 (gif_load): Fix pointer signedness.
9209 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9210 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9212 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9214 Improve quality of tests for time stamp overflow.
9215 For example, without this patch (encode-time 0 0 0 1 1
9216 1152921504606846976) returns the obviously-bogus value (-948597
9217 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9218 reports time overflow. See
9219 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9220 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9221 * editfns.c: Include limits.h and intprops.h.
9222 (TIME_T_MIN, TIME_T_MAX): New macros.
9223 (time_overflow): Move earlier, to before first use.
9224 (hi_time, lo_time): New functions, for an accurate test for
9226 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9227 (Fget_internal_run_time): Don't assume time_t fits in int.
9228 (make_time): Use list2 instead of Fcons twice.
9229 (Fdecode_time): More accurate test for out-of-range times.
9230 (check_tm_member): New function.
9231 (Fencode_time): Use it, to test for out-of-range times.
9232 (lisp_time_argument): Don't rely on undefined left-shift and
9233 right-shift behavior when checking for time stamp overflow.
9235 * editfns.c (time_overflow): New function, refactoring common code.
9236 (Fformat_time_string, Fdecode_time, Fencode_time):
9237 (Fcurrent_time_string): Use it.
9239 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9240 * dired.c (make_time): Move to ...
9241 * editfns.c (make_time): ... here.
9242 * systime.h: Note the move.
9244 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9246 * fringe.c (update_window_fringes): Remove unused variables.
9248 * unexmacosx.c (copy_data_segment): Also copy __got section.
9251 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9253 * termcap.c [MSDOS]: Include "msdos.h".
9254 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9255 Constify `char *' arguments and their references according to
9256 prototypes in tparam.h.
9258 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9260 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9261 Adapt all references accordingly.
9263 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9265 2011-03-11 Tom Tromey <tromey@redhat.com>
9267 * buffer.c (syms_of_buffer): Remove obsolete comment.
9269 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9271 * termhooks.h (encode_terminal_code): Declare prototype.
9273 * msdos.c (encode_terminal_code): Don't declare prototype.
9275 * term.c (encode_terminal_code): Now external again, used by
9276 w32console.c and msdos.c.
9278 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9279 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9281 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9283 Fix some minor problems found by GCC 4.5.2's static checks.
9285 * fringe.c (update_window_fringes): Mark locals as initialized
9287 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9289 * alloc.c (mark_fringe_data): Move decl from here ...
9290 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9291 to check its interface.
9292 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9294 * fontset.c (free_realized_fontset): Now static.
9295 (Fset_fontset_font): Rename local to avoid shadowing.
9296 (fontset_font): Mark local as initialized.
9297 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9299 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9301 * xselect.c (x_disown_buffer_selections): Remove; not used.
9302 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9303 (x_own_selection, Fx_disown_selection_internal): Rename locals
9305 (x_handle_dnd_message): Remove local to avoid shadowing.
9307 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9308 so that the caller can use some name other than gcpro1.
9309 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9310 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9311 (Fx_backspace_delete_keys_p):
9312 Use them to avoid shadowing, and rename vars to avoid shadowing.
9313 (x_decode_color, x_set_name, x_window): Now static.
9314 (Fx_create_frame): Add braces to silence GCC warning.
9315 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9316 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9317 Remove unused locals.
9318 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9319 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9320 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9323 * xterm.h (x_mouse_leave): New decl.
9325 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9326 Remove unused functions.
9327 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9328 (x_calc_absolute_position): Now static.
9329 (XTread_socket): Don't define label "out" unless it's used.
9330 Don't declare local "event" unless it's used.
9331 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9332 unless they are used.
9333 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9334 (x_fatal_error_signal): Remove; not used.
9335 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9336 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9337 (x_error_catcher, x_connection_closed, x_error_handler):
9338 (x_error_quitter, xembed_send_message, x_iconify_frame):
9339 (my_log_handler): Rename locals to avoid shadowing.
9340 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9341 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9343 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9344 Rename or move locals to avoid shadowing.
9345 (tty_defined_color, merge_face_heights): Now static.
9346 (free_realized_faces_for_fontset): Remove; not used.
9347 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9348 does not deduce is never used uninitialized.
9349 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9350 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9352 * terminal.c (store_terminal_param): Now static.
9354 * xmenu.c (menu_highlight_callback): Now static.
9355 (set_frame_menubar): Remove unused local.
9356 (xmenu_show): Rename parameter to avoid shadowing.
9357 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9358 since they might point to immutable storage.
9359 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9360 since it's unused otherwise.
9362 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9363 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9364 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9365 avoids a gcc -Wuninitialized diagnostic.
9366 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9367 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9368 does not deduce are never used uninitialized.
9370 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9372 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9373 * window.c (window_loop, size_window):
9374 (run_window_configuration_change_hook, enlarge_window): Likewise.
9376 * window.c (display_buffer): Now static.
9377 (size_window): Mark variables that gcc -Wuninitialized
9378 does not deduce are never used uninitialized.
9379 * window.h (check_all_windows): New decl, to forestall
9380 gcc -Wmissing-prototypes diagnostic.
9381 * dispextern.h (bidi_dump_cached_states): Likewise.
9383 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9385 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9387 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9388 and to avoid gcc -Wuninitialized warning.
9389 (load_charset_map): Mark variables that gcc -Wuninitialized
9390 does not deduce are never used uninitialized.
9391 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9393 * coding.c (coding_set_source, coding_set_destination):
9394 Use "else { /* comment */ }" rather than "else /* comment */;"
9395 for clarity, and to avoid gcc -Wempty-body warning.
9396 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9397 a block, when the outer 'i' will do.
9398 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9399 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9400 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9401 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9402 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9403 Rename locals to avoid shadowing.
9404 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9405 * coding.c (emacs_mule_char, encode_invocation_designation):
9406 Now static, since they're not used elsewhere.
9407 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9408 (decode_coding_object, encode_coding_object, detect_coding_system):
9409 (decode_coding_emacs_mule): Mark variables that gcc
9410 -Wuninitialized does not deduce are never used uninitialized.
9411 (detect_coding_iso_2022): Initialize a local variable that might
9412 be used uninitialized. Leave a FIXME because it's not clear that
9413 this initialization is needed. (Bug#8211)
9414 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9415 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9416 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9417 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9418 Remove unused macros.
9420 * category.c (hash_get_category_set): Remove unused local var.
9421 (copy_category_table): Now static, since it's not used elsewhere.
9422 * character.c (string_count_byte8): Likewise.
9424 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9425 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9427 * chartab.c (copy_sub_char_table): Now static, since it's not used
9429 (sub_char_table_ref_and_range, char_table_ref_and_range):
9430 Rename locals to avoid shadowing.
9431 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9433 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9434 (BIDI_BOB): Remove unused macro.
9436 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9437 deduce are never used uninitialized.
9438 * term.c (encode_terminal_code): Likewise.
9440 * term.c (encode_terminal_code): Now static. Remove unused local.
9442 * tparam.h: New file.
9443 * term.c, tparam.h: Include it.
9444 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9445 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9446 Move these decls to tparam.h, and make them agree with what
9447 is actually in tparam.c. The previous trick of using incompatible
9448 decls in different modules does not conform to the C standard.
9449 All callers of tparam changed to use tparam's actual API.
9450 * tparam.c (tparam1, tparam, tgoto):
9451 Use const pointers where appropriate.
9453 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9454 * cm.h (struct cm): Likewise.
9455 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9456 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9457 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9458 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9459 (turn_on_face, init_tty): Likewise.
9460 * termchar.h (struct tty_display_info): Likewise.
9462 * term.c (term_mouse_position): Rename local to avoid shadowing.
9464 * alloc.c (mark_ttys): Move decl from here ...
9465 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9467 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9469 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9471 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9473 * search.c (compile_pattern_1): Remove argument regp, unused since
9474 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9475 (compile_pattern): Don't pass it.
9477 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9479 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9480 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9482 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9484 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9486 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9487 gdk_window_get_screen, gdk_window_get_geometry,
9488 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9489 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9490 (xg_get_pixbuf_from_pixmap): New function.
9491 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9492 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9493 Call xg_get_pixbuf_from_pixmap instead of
9494 gdk_pixbuf_get_from_drawable.
9495 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9496 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9497 (xg_check_special_colors): Use GtkStyleContext and its functions
9499 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9500 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9501 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9502 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9503 Call gtk_widget_get_preferred_size.
9504 (xg_frame_resized): gdk_window_get_geometry only takes 5
9506 (xg_win_to_widget, xg_event_is_for_menubar):
9507 Call gdk_x11_window_lookup_for_display.
9508 (xg_set_widget_bg): New function.
9509 (delete_cb): New function.
9510 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9511 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9512 (xg_set_background_color): Call xg_set_widget_bg.
9513 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9514 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9515 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9516 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9518 (update_frame_tool_bar): Call gtk_widget_hide.
9519 (xg_initialize): Use GDK_KEY_g.
9521 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9523 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9525 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9526 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9527 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9529 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9531 * w32xfns.c (select_palette): Check success of RealizePalette against
9532 GDI_ERROR, not zero.
9534 See ChangeLog.11 for earlier changes.
9540 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9542 This file is part of GNU Emacs.
9544 GNU Emacs is free software: you can redistribute it and/or modify
9545 it under the terms of the GNU General Public License as published by
9546 the Free Software Foundation, either version 3 of the License, or
9547 (at your option) any later version.
9549 GNU Emacs is distributed in the hope that it will be useful,
9550 but WITHOUT ANY WARRANTY; without even the implied warranty of
9551 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9552 GNU General Public License for more details.
9554 You should have received a copy of the GNU General Public License
9555 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.