1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * tparam.c: Integer and memory overflow fixes.
4 (tparam1): Use ptrdiff_t, not int, for sizes.
5 Don't update size until alloc done.
6 Redo size calculations to avoid overflow.
7 Check for size calculation overflow.
9 * termcap.c: Integer and memory overflow issues.
10 (tgetent): Use ptrdiff_t, not int, to record results of
12 (gobble_line): Check for overflow more carefully. Don't update size
15 * term.c: Integer and memory overflow issues.
16 (max_frame_lines): Remove; unused.
17 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
19 (encode_terminal_code, calculate_costs): Check for size
21 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
22 table lengths and related sizes. Don't update size until alloc
23 done. Redo calculations to avoid overflow.
24 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
26 * sysdep.c: Integer and memory overflow issues.
27 (system_process_attributes): Use ptrdiff_t, not int, for command
28 line length. Do not attempt to address one before the beginning
29 of an array, as that's not portable.
31 * search.c: Integer and memory overflow fixes.
32 (Freplace_match): Check for size calculation overflow.
33 (Fset_match_data): Don't assume list lengths fit in 'int'.
35 * scroll.c: Integer and memory overflow fixes.
36 (do_line_insertion_deletion_costs): Check for size calculation overflow.
37 Don't bother calling xmalloc when xrealloc will do.
39 * region-cache.c (move_cache_gap): Check for size calculation overflow.
41 * process.c (Fnetwork_interface_list): Check for overflow
44 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
45 Now ptrdiff_t, not int.
46 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
47 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
49 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
52 * macros.c: Integer and memory overflow fixes.
53 (Fstart_kbd_macro): Don't update size until alloc done.
54 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
56 * lread.c (read1, init_obarray): Don't update size until alloc done.
58 * keymap.c: Integer overflow fixes.
59 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
60 (current_minor_maps): Check for size calculation overflow.
61 * keymap.h: Change prototypes to match the above.
63 * keyboard.c: Integer and memory overflow fixes.
64 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
65 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
66 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
67 (read_char_minibuf_menu_prompt): Check for overflow in size
68 calculations. Don't update size until allocation succeeds. Redo
69 calculations to avoid overflow.
70 * keyboard.h: Change prototypes to match the above.
72 * image.c: Integer and memory overflow fixes.
73 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
74 now that they've been promoted to lisp.h.
75 (x_allocate_bitmap_record, x_alloc_image_color)
76 (make_image_cache, cache_image, xpm_load):
77 Don't update size until alloc is done.
78 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
80 Check for size calculation overflow.
81 (ct_colors_allocated_max): New constant.
82 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
85 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
87 * gtkutil.c: Integer overflow fixes.
88 (get_utf8_string, xg_store_widget_in_map):
89 Check for size-calculation overflow.
90 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
91 do, as we prefer signed integers.
92 (id_to_widget.max_size, id_to_widget.used)
93 (xg_store_widget_in_map, xg_remove_widget_from_map)
94 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
95 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
96 Use and return ptrdiff_t, not int.
97 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
98 * gtkutil.h: Change prototypes to match the above.
100 * ftfont.c: Check for size overflow.
101 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
102 Check for integer overflow in size calculations.
104 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
106 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
107 This is for the members text_lines, text_cols, total_lines, total_cols,
108 where the system imposes an 'int' limit.
110 * frame.c: Integer overflow fixes.
111 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
112 (x_figure_window_size): Check for integer overflow.
113 (x_set_alpha): Do not assume XINT fits in int.
115 * eval.c: Integer and memory overflow fixes.
116 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
117 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
119 * emacs.c (main, sort_args): Check for size-calculation overflow.
121 * editfns.c: Integer and memory overflow fixes.
122 (set_time_zone_rule): Don't assume environment length fits in int.
123 (message_length): Now ptrdiff_t, not int.
124 (Fmessage_box): Don't update size until allocation succeeds.
125 Don't assume message length fits in int.
126 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
128 * doc.c: Integer and memory overflow fixes.
129 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
130 (get_doc_string): Check for size calculation overflow.
131 Don't update size until allocation succeeds.
132 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
133 EMACS_INT, where ptrdiff_t will do.
134 (Fsubstitute_command_keys): Check for string overflow.
136 Integer and memory overflow fixes for display code.
137 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
138 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
139 Check for overflow in size calculations.
140 (line_draw_cost, realloc_glyph_pool, add_row_entry):
141 Don't assume glyph table len fits in int.
142 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
143 (row_table_size): Now ptrdiff_t, not int.
144 (scrolling_window): Avoid overflow in size calculations.
145 Don't update size until allocation succeeds.
146 * fns.c (concat): Check for overflow in size calculations.
147 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
148 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
149 (NEXT_ALMOST_PRIME_LIMIT): New constant.
151 * composite.c: Integer overflow fixes.
152 (get_composition_id): Check for overflow in glyph length calculations.
154 * coding.c: Integer and memory overflow fixes.
155 (produce_chars): Redo buffer-overflow calculations to avoid
156 unnecessary integer overflow. Check for size overflow.
157 (encode_coding_object): Don't update size until xmalloc succeeds.
159 * character.c (Fstring): Check for size-calculation overflow.
161 * ccl.c: Integer and memory overflow fixes.
162 (Fccl_execute_on_string): Check for memory overflow.
163 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
164 Redo buffer-overflow calculations to avoid integer overflow.
166 * callproc.c (child_setup): Don't assume strlen fits in int.
168 * buffer.c: Memory overflow fixes.
169 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
170 Don't update size of array until after memory allocation succeeds,
171 because xmalloc/xrealloc may not return.
173 * bidi.c: Integer overflow fix.
174 (bidi_shelve_header_size): New constant.
175 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
176 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
178 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
180 Use ptrdiff_t for composition IDs.
181 * character.c (lisp_string_width):
182 * composite.c (composition_table_size, n_compositions)
183 (get_composition_id, composition_gstring_from_id):
184 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
185 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
186 * window.c (Frecenter):
187 Use ptrdiff_t, not int, for composition IDs.
188 * composite.c (get_composition_id): Check for integer overflow.
189 * composite.h: Adjust prototypes to match the above changes.
191 Use ptrdiff_t for hash table indexes.
192 * category.c (hash_get_category_set):
193 * ccl.c (ccl_driver):
194 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
195 * coding.c (coding_system_charset_list, detect_coding_system):
196 * coding.h (struct coding_system.id):
197 * composite.c (get_composition_id, gstring_lookup_cache):
198 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
199 * image.c (xpm_get_color_table_h):
200 * lisp.h (hash_lookup, hash_put):
201 * minibuf.c (Ftest_completion):
202 Use ptrdiff_t for hash table indexes, not int (which is too
203 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
204 32-bit --with-wide-int hosts).
206 * charset.c (Fdefine_charset_internal): Check for integer overflow.
207 Add a FIXME comment about memory leaks.
208 (syms_of_charset): Don't assume xmalloc returns.
210 Don't assume that stated character widths fit in int.
211 * character.c (Fchar_width, c_string_width, lisp_string_width):
212 * character.h (CHAR_WIDTH):
213 * indent.c (MULTIBYTE_BYTES_WIDTH):
214 Use sanitize_char_width to avoid undefined and/or bad behavior
215 with outlandish widths.
216 * character.h (sanitize_tab_width): Renamed from sanitize_width,
217 now that we have two such functions. All uses changed.
218 (sanitize_char_width): New inline function.
220 Don't assume that tab-width fits in int.
221 * character.h (sanitize_width): New inline function.
222 (SANE_TAB_WIDTH): New macro.
223 (ASCII_CHAR_WIDTH): Use it.
224 * indent.c (sane_tab_width): Remove. All uses replaced by
225 SANE_TAB_WIDTH (current_buffer).
226 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
228 * fileio.c: Integer overflow issues with file modes.
229 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
231 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
232 Remove unreachable code.
233 (read_hex, load_charset_map_from_file): Check for integer overflow.
235 * xterm.c: don't go over XClientMessageEvent limit
236 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
237 (x_send_scroll_bar_event): Likewise. Check that the size does not
238 exceed limits imposed by XClientMessageEvent, as well as the usual
239 ptrdiff_t and size_t limits.
241 * keyboard.c: Overflow, signedness and related fixes.
242 (make_lispy_movement): Use same integer type in forward decl
243 that is used in the definition.
244 (read_key_sequence, keyremap_step):
245 Change bufsize argument back to int, undoing my 2011-03-30 change.
246 We prefer signed types, and int is wide enough here.
247 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
248 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
249 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
250 length, not size_t. Use ptrdiff_t for index, not int.
251 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
252 possibility of integer overflow.
254 Overflow, signedness and related fixes for images.
256 * dispextern.h (struct it.stack[0].u.image.image_id)
257 (struct_it.image_id, struct image.id, struct image_cache.size)
258 (struct image_cache.used, struct image_cache.ref_count):
259 * gtkutil.c (update_frame_tool_bar):
260 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
261 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
262 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
263 * nsmenu.m (update_frame_tool_bar):
264 * xdisp.c (calc_pixel_width_or_height):
265 * xfns.c (image_cache_refcount):
266 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
267 on typical 64-bit hosts.
269 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
270 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
271 Omit unnecessary casts to int.
272 (parse_image_spec): Check that integers fall into 'int' range
273 when the callers expect that.
274 (image_ascent): Redo ascent calculation to avoid int overflow.
275 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
276 (lookup_image): Remove unnecessary tests.
277 (xbm_image_p): Locals are now of int, not EMACS_INT,
278 since parse_image_check makes sure they fit into int.
279 (png_load, gif_load, svg_load_image):
280 Prefer int to unsigned where either will do.
281 (tiff_handler): New function, combining the cores of the
282 old tiff_error_handler and tiff_warning_handler. This
283 function is rewritten to use vsnprintf and thereby avoid
284 stack buffer overflows. It uses only the features of vsnprintf
285 that are common to both POSIX and native Microsoft.
286 (tiff_error_handler, tiff_warning_handler): Use it.
287 (tiff_load, gif_load, imagemagick_load_image):
288 Don't assume :index value fits in 'int'.
289 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
290 (imagemagick_load_image): Check that crop parameters fit into
291 the integer types that MagickCropImage accepts. Don't assume
292 Vimagemagick_render_type has a nonnegative value. Don't assume
293 size_t fits in 'long'.
294 (gs_load): Use printmax_t to print the widest integers possible.
295 Check for integer overflow when computing image height and width.
297 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
299 Integer signedness and overflow and related fixes. (Bug#9079)
301 * bidi.c: Integer size and overflow fixes.
302 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
303 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
304 (bidi_cache_find_level_change, bidi_cache_ensure_space)
305 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
306 (bidi_find_other_level_edge):
307 Use ptrdiff_t instead of EMACS_INT where either will do.
308 This works better on 32-bit hosts configured --with-wide-int.
309 (bidi_cache_ensure_space): Check for size-calculation overflow.
310 Use % rather than repeated addition, for better worst-case speed.
311 Don't set bidi_cache_size until after xrealloc returns, because it
313 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
314 (bidi_cache_ensure_space): Also check that the bidi cache size
315 does not exceed that of the largest Lisp string or buffer. See Eli
316 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
318 * alloc.c (__malloc_size_t): Remove.
319 All uses replaced by size_t. See Andreas Schwab's note
320 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
322 * image.c: Improve checking for integer overflow.
323 (check_image_size): Assume that f is nonnull, since
324 it is always nonnull in practice. This is one less thing to
325 worry about when checking for integer overflow later.
326 (x_check_image_size): New function, which checks for integer
327 overflow issues inside X.
328 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
329 This removes the need for a memory_full check.
330 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
331 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
332 (xbm_read_bitmap_data): Change locals back to 'int', since
333 their values must fit in 'int'.
334 (xpm_load_image, png_load, tiff_load):
335 Invoke x_create_x_image_and_pixmap earlier,
336 to avoid much needless work if the image is too large.
337 (tiff_load): Treat overly large images as if
338 x_create_x_image_and_pixmap failed, not as malloc failures.
339 (gs_load): Use x_check_image_size.
341 * gtkutil.c: Omit integer casts.
342 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
343 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
345 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
347 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
348 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
349 would wrongly return t on a 64-bit host.
351 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
352 The plain *_OVERFLOW macros run afoul of GCC bug 49705
353 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
354 and therefore cause GCC to emit a bogus diagnostic in some cases.
356 * image.c: Integer signedness and overflow and related fixes.
357 This is not an exhaustive set of fixes, but it's time to
358 record what I've got.
359 (lookup_pixel_color, check_image_size): Remove redundant decls.
360 (check_image_size): Don't assume that arbitrary EMACS_INT values
361 fit in 'int', or that arbitrary 'double' values fit in 'int'.
362 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
363 (tiff_load, imagemagick_load_image):
364 Check for overflow in size calculations.
365 (x_create_x_image_and_pixmap): Remove unnecessary test for
366 xmalloc returning NULL; that can't happen.
367 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
368 (xpm_color_bucket): Use better integer hashing function.
369 (xpm_cache_color): Don't possibly over-allocate memory.
370 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
372 Use ptrdiff_t, not int or size_t, to record sizes.
373 (png_load): Don't assume values greater than 2**31 fit in 'int'.
374 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
375 either works, as we prefer signed integers.
376 (tiff_read_from_memory, tiff_write_from_memory):
377 Return tsize_t, not size_t, since that's what the TIFF API wants.
378 (tiff_read_from_memory): Don't fail simply because the read would
379 go past EOF; instead, return a short read.
380 (tiff_load): Omit no-longer-needed casts.
381 (Fimagemagick_types): Don't assume size fits into 'int'.
383 Improve hashing quality when configured --with-wide-int.
384 * fns.c (hash_string): New function, taken from sxhash_string.
385 Do not discard information about ASCII character case; this
386 discarding is no longer needed.
387 (sxhash-string): Use it. Change sig to match it. Caller changed.
388 * lisp.h: Declare it.
389 * lread.c (hash_string): Remove, since we now use fns.c's version.
390 The fns.c version returns a wider integer if --with-wide-int is
391 specified, so this should help the quality of the hashing a bit.
393 * emacs.c: Integer overflow minor fix.
394 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
395 Define only if GNU_LINUX.
396 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
398 * dispnew.c: Integer signedness and overflow fixes.
399 Remove unnecessary forward decls, that were a maintenance hassle.
400 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
402 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
403 (scrolling_window): Use ptrdiff_t, not int, for byte count.
404 (prepare_desired_row, line_draw_cost):
405 Use int, not unsigned, where either works.
406 (save_current_matrix, restore_current_matrix):
407 Use ptrdiff_t, not size_t, where either works.
408 (init_display): Check for overflow more accurately, and without
409 relying on undefined behavior.
411 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
412 Remove, replacing with the new symbols in lisp.h. All uses changed.
413 * fileio.c (make_temp_name):
414 * filelock.c (lock_file_1, lock_file):
415 * xdisp.c (message_dolog):
416 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
417 Use pMd etc. instead.
418 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
419 replacing the pWIDE etc. symbols removed from editfns.c.
421 * keyboard.h (num_input_events): Now uintmax_t.
422 This is (very slightly) less likely to mess up due to wraparound.
425 * buffer.c: Integer signedness fixes.
426 (alloc_buffer_text, enlarge_buffer_text):
427 Use ptrdiff_t rather than size_t when either will do, as we prefer
430 * alloc.c: Integer signedness and overflow fixes.
431 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
432 (__malloc_size_t): Default to size_t, not to int.
433 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
434 (Fgarbage_collect, mark_object_loop_halt, mark_object):
435 Prefer ptrdiff_t to size_t when either would do, as we prefer
437 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
438 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
439 Now const. Initialize with values that are in range even if char
441 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
442 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
443 These functions do the right thing with sizes > 2**32.
444 (check_depth): Now ptrdiff_t, not int.
445 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
446 Adjust to new way of storing sizes. Check for size overflow bugs
448 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
449 slightly wrong anyway, as it missed one instance of
450 XMALLOC_OVERRUN_CHECK_OVERHEAD.
451 (refill_memory_reserve): Omit needless cast to size_t.
452 (mark_object_loop_halt): Mark as externally visible.
454 * xselect.c: Integer signedness and overflow fixes.
455 (Fx_register_dnd_atom, x_handle_dnd_message):
456 Use ptrdiff_t, not size_t, since we prefer signed.
457 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
458 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
459 x_dnd_atoms_size and x_dnd_atoms_length.
461 * doprnt.c: Prefer signed to unsigned when either works.
465 * xdisp.c (vmessage):
466 Use ptrdiff_t, not size_t, when using or implementing doprnt,
467 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
468 prefer signed arithmetic to avoid comparison confusion.
469 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
472 Assume freestanding C89 headers, string.h, stdlib.h.
473 * data.c, doprnt.c, floatfns.c, print.c:
474 Include float.h unconditionally.
475 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
476 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
477 * regex.c: Likewise for stddef.h, string.h.
478 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
479 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
480 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
481 (STDC_HEADERS): Remove obsolete defines.
482 * sysdep.c: Include limits.h unconditionally.
484 Assume support for memcmp, memcpy, memmove, memset.
485 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
486 * regex.c (memcmp, memcpy):
487 Remove; we assume C89 now.
489 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
490 (__malloc_safe_bcopy): Remove; no longer needed.
492 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
493 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
494 well either way, and we prefer signed to unsigned.
496 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
499 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
500 and the surrounding thread.
501 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
502 rather than fgets, and retry after EINTR. Otherwise, 'emacs
503 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
505 * s/openbsd.h (BROKEN_SIGIO): Define.
506 * unexelf.c (unexec) [__OpenBSD__]:
507 Don't update the .mdebug section of the Alpha COFF symbol table.
509 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
511 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
514 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
516 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
517 This fixes some race conditions on the permissions of any newly
520 * alloc.c (valid_pointer_p): Use pipe, not open.
521 This fixes some permissions issues when debugging.
523 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
524 If fchown fails to set both uid and gid, try to set just gid,
525 as that is sometimes allowed. Adjust the file's mode to eliminate
526 setuid or setgid bits that are inappropriate if fchown fails.
528 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
530 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
531 to compare Lisp_Objects.
532 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
533 global_gnutls_log_level, don't mistake it for a Lisp_Object.
534 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
536 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
538 * lread.c (read_integer): Unread even EOF character.
539 (read1): Likewise. Properly record start position of symbol.
541 * lread.c (read1): Read `#:' as empty uninterned symbol if no
542 symbol character follows.
544 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
546 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
547 This works around a problem with the previous change to Fcopy_file.
548 Recent glibc declares fchown with __attribute__((warn_unused_result)),
549 and without this change, GCC might complain about discarding
550 fchown's return value.
552 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
554 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
556 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
558 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
560 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
562 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
563 it's used from the C level.
565 * process.c: Use the same condition for POLL_FOR_INPUT in both
566 keyboard.c and process.c (bug#1858).
568 2011-07-09 Lawrence Mitchell <wence@gmx.li>
570 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
571 (Fgnutls_boot): Use it.
573 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
575 * doc.c (Fsubstitute_command_keys): Revert last change.
577 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
579 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
580 quotes the next character, and doesn't affect other longer
581 sequences (bug#8935).
583 * lread.c (syms_of_lread): Clarify that is isn't only
584 `eval-buffer' and `eval-defun' that's affected by
585 `lexical-binding' (bug#8460).
587 2011-07-15 Eli Zaretskii <eliz@gnu.org>
589 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
590 bidi redisplay when a line includes both an image and is
593 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
595 Fix minor problems found by static checking.
596 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
597 (elsz): Now a signed constant, not a size_t var. We prefer signed
598 types to unsigned, to avoid integer comparison confusion. Without
599 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
600 "cannot optimize loop, the loop counter may overflow", a symptom
602 * indent.c (Fvertical_motion): Mark locals as initialized.
603 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
605 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
607 * search.c (Fre_search_backward): Mention `case-fold-search' in
608 all the re_search_* functions (bug#8138).
610 * keyboard.c (Fopen_dribble_file): Document when the file is
613 2011-07-14 Eli Zaretskii <eliz@gnu.org>
615 * bidi.c (bidi_dump_cached_states): Fix format of displaying
618 Support bidi reordering of display and overlay strings.
619 * xdisp.c (compute_display_string_pos)
620 (compute_display_string_end): Accept additional argument STRING.
621 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
622 (reseat_to_string): Initialize bidi_it->string.s and
623 bidi_it->string.schars.
624 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
625 NULL (avoids a crash in bidi_paragraph_init). Initialize
627 (init_iterator): Call bidi_init_it only of a valid
628 buffer position was specified. Initialize paragraph_embedding to
630 (reseat_to_string): Initialize the bidi iterator.
631 (display_string): If we need to ignore text properties of
632 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
633 original value of -1 will not work with bidi.)
634 (compute_display_string_pos): First arg is now struct
635 `text_pos *'; all callers changed. Support display properties on
637 (compute_display_string_end): Support display properties on Lisp
639 (init_iterator, reseat_1, reseat_to_string): Initialize the
640 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
641 when iterating on a string not from display properties).
642 (compute_display_string_pos, compute_display_string_end): Fix
643 calculation of the object to scan. Fixes an error when using
645 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
646 base_level_stop; instead, set base_level_stop to BEGV. Fixes
647 crashes in vertical-motion.
648 (next_element_from_buffer): Improve commentary for when
649 the iterator is before prev_stop.
650 (init_iterator): Initialize bidi_p from the default value of
651 bidi-display-reordering, not from buffer-local value. Use the
652 buffer-local value only if initializing for buffer iteration.
653 (handle_invisible_prop): Support invisible properties on strings
654 that are being bidi-reordered.
655 (set_iterator_to_next): Support bidi reordering of C strings and
657 (next_element_from_string): Support bidi reordering of Lisp
659 (handle_stop_backwards): Support Lisp strings as well.
660 (display_string): Support display of R2L glyph rows. Use
661 IT_STRING_CHARPOS when displaying from a Lisp string.
662 (init_iterator): Don't initialize it->bidi_p for strings
664 (reseat_to_string): Initialize it->bidi_p for strings here.
665 (next_element_from_string, next_element_from_c_string)
666 (next_element_from_buffer): Add xassert's for correspondence
667 between IT's object being iterated and it->bidi_it.string
669 (face_before_or_after_it_pos): Support bidi iteration.
670 (next_element_from_c_string): Handle the case of the first string
671 character that is not the first one in the visual order.
672 (get_visually_first_element): New function, refactored from common
673 parts of next_element_from_buffer, next_element_from_string, and
674 next_element_from_c_string.
675 (tool_bar_lines_needed, redisplay_tool_bar)
676 (display_menu_bar): Force left-to-right direction. Add a FIXME
677 comment for making that be controlled by a user option.
678 (push_it, pop_it): Save and restore the state of the
679 bidi iterator. Save and restore the bidi_p flag.
680 (pop_it): Iterate out of display property for string iteration as
682 (iterate_out_of_display_property): Support iteration over strings.
683 (handle_single_display_spec): Set up it->bidi_it for iteration
684 over a display string, and call bidi_init_it.
685 (handle_single_display_spec, next_overlay_string)
686 (get_overlay_strings_1, push_display_prop): Set up the bidi
687 iterator for displaying display or overlay strings.
688 (forward_to_next_line_start): Don't use the shortcut if
690 (back_to_previous_visible_line_start): If handle_display_prop
691 pushed the iterator stack, restore the internal state of the bidi
692 iterator by calling bidi_pop_it same number of times.
693 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
694 and we are bidi-iterating, don't decrement the iterator position;
695 instead, set the first_elt flag in the bidi iterator, to produce
697 (reseat_1): Remove redundant setting of string_from_display_prop_p.
698 (push_display_prop): xassert that we are iterating a buffer.
699 (push_it, pop_it): Save and restore paragraph_embedding member.
700 (handle_single_display_spec, next_overlay_string)
701 (get_overlay_strings_1, reseat_1, reseat_to_string)
702 (push_display_prop): Set up the `unibyte' member of bidi_it.string
703 correctly. Don't assume unibyte strings are not bidi-reordered.
704 (compute_display_string_pos)
705 (compute_display_string_end): Fix handling the case of C string.
706 (push_it, pop_it): Save and restore from_disp_prop_p.
707 (handle_single_display_spec, push_display_prop): Set the
708 from_disp_prop_p flag.
709 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
710 (pop_it): Call iterate_out_of_display_property only if we are
711 popping after iteration over a string that came from a display
712 property. Fix a typo in popping stretch info. Add an assertion
713 for verifying that the iterator position is in sync with the bidi
715 (handle_single_display_spec, get_overlay_strings_1)
716 (push_display_prop): Fix initialization of paragraph direction for
717 string when that of the parent object is not yet determined.
718 (reseat_1): Call bidi_init_it to resync the bidi
719 iterator with IT's position. (Bug#7616)
720 (find_row_edges): If ROW->start.pos gives position
721 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
722 (handle_stop, back_to_previous_visible_line_start, reseat_1):
723 Reset the from_disp_prop_p flag.
724 (SAVE_IT, RESTORE_IT): New macros.
725 (pos_visible_p, face_before_or_after_it_pos)
726 (back_to_previous_visible_line_start)
727 (move_it_in_display_line_to, move_it_in_display_line)
728 (move_it_to, move_it_vertically_backward, move_it_by_lines)
729 (try_scrolling, redisplay_window, display_line): Use them when
730 saving a temporary copy of the iterator and restoring it back.
731 (back_to_previous_visible_line_start, reseat_1)
732 (init_iterator): Empty the bidi cache "stack".
733 (move_it_in_display_line_to): If iterator ended up at
734 EOL, but we never saw any buffer positions smaller than
735 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
736 motion in bidi-reordered lines.
737 (move_it_in_display_line_to): Record prev_method and prev_pos
738 immediately before the call to set_iterator_to_next. Fixes cursor
739 motion in bidi-reordered lines with stretch glyphs and strings
740 displayed in margins. (Bug#8133) (Bug#8867)
741 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
743 (pos_visible_p): Support positions in bidi-reordered lines. Save
744 and restore bidi cache.
746 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
747 (bidi_paragraph_info): Delete unused struct.
748 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
749 (bidi_cache_start): New variable.
750 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
752 (bidi_cache_fetch_state, bidi_cache_search)
753 (bidi_cache_find_level_change, bidi_cache_iterator_state)
754 (bidi_cache_find, bidi_peek_at_next_level)
755 (bidi_level_of_next_char, bidi_find_other_level_edge)
756 (bidi_move_to_visually_next): Compare cache index with
757 bidi_cache_start rather than with zero.
758 (bidi_fetch_char): Accept new argument STRING; all callers
759 changed. Support iteration over a string. Support strings with
760 display properties. Support unibyte strings. Fix the type of
761 `len' according to what STRING_CHAR_AND_LENGTH expects.
762 (bidi_paragraph_init, bidi_resolve_explicit_1)
763 (bidi_resolve_explicit, bidi_resolve_weak)
764 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
765 iteration over a string.
766 (bidi_set_sor_type, bidi_resolve_explicit_1)
767 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
768 can now be zero (for strings); special values 0 and -1 were
769 changed to -1 and -2, respectively.
770 (bidi_char_at_pos): New function.
771 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
772 Call it instead of FETCH_MULTIBYTE_CHAR.
773 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
774 initialized to valid values.
775 (bidi_init_it): Don't initialize charpos and bytepos with invalid
777 (bidi_level_of_next_char): Allow the sentinel "position" to pass
778 the test for valid cached positions. Fix the logic for looking up
779 the sentinel state in the cache. GCPRO the Lisp string we are
781 (bidi_push_it, bidi_pop_it): New functions.
782 (bidi_initialize): Initialize the bidi cache start stack pointer.
783 (bidi_cache_ensure_space): New function, refactored from part of
784 bidi_cache_iterator_state. Don't assume the required size is just
785 one BIDI_CACHE_CHUNK away.
786 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
787 (bidi_count_bytes, bidi_char_at_pos): New functions.
788 (bidi_cache_search): Don't assume bidi_cache_last_idx is
789 always valid if bidi_cache_idx is valid.
790 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
791 is valid if it's going to be used.
792 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
793 (bidi_cache_fetch_state, bidi_cache_search)
794 (bidi_cache_find_level_change, bidi_cache_ensure_space)
795 (bidi_cache_iterator_state, bidi_cache_find)
796 (bidi_find_other_level_edge, bidi_cache_start_stack): All
797 variables related to cache indices are now EMACS_INT.
799 * dispextern.h (struct bidi_string_data): New structure.
800 (struct bidi_it): New member `string'. Make flag members be 1-bit
801 fields, and put them last in the struct.
802 (compute_display_string_pos, compute_display_string_end): Update
804 (bidi_push_it, bidi_pop_it): Add prototypes.
805 (struct iterator_stack_entry): New members bidi_p,
806 paragraph_embedding, and from_disp_prop_p.
807 (struct it): Member bidi_p is now a bit field 1 bit wide.
808 (bidi_shelve_cache, bidi_unshelve_cache): Declare
811 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
812 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
813 and vector-like objects.
815 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
816 cache around display iteration.
818 * window.c (Fwindow_end, window_scroll_pixel_based)
819 (displayed_window_lines, Frecenter): Save and restore the bidi
820 cache around display iteration.
822 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
824 * editfns.c (Fdelete_region): Clarify the use of the named
825 parameters (bug#6788).
827 2011-07-14 Martin Rudalics <rudalics@gmx.at>
829 * indent.c (Fvertical_motion): Set and restore w->pointm when
830 saving and restoring the window's buffer (Bug#9006).
832 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
834 * editfns.c (Fstring_to_char): Clarify just what is returned
835 (bug#6576). Text by Eli Zaretskii.
837 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
839 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
841 2011-07-13 Eli Zaretskii <eliz@gnu.org>
843 * buffer.c (mmap_find): Fix a typo.
845 2011-07-13 Johan Bockgård <bojohan@gnu.org>
847 Fix execution of x selection hooks.
848 * xselect.c (Qx_lost_selection_functions)
849 (Qx_sent_selection_functions): New vars.
850 (syms_of_xselect): DEFSYM them.
851 (x_handle_selection_request): Pass Qx_sent_selection_functions
852 rather than Vx_sent_selection_functions to Frun_hook_with_args.
853 (x_handle_selection_clear,x_clear_frame_selections):
854 Pass Qx_lost_selection_functions rather than
855 Vx_lost_selection_functions to Frun_hook_with_args.
857 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
859 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
860 The old code sometimes used this field without initializing it.
862 * alloc.c (gc_sweep): Don't read past end of array.
863 In theory, the old code could also have corrupted Emacs internals,
864 though it'd be very unlikely.
866 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
868 * character.c (Fcharacterp): Don't advertise optional ignored
871 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
873 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
876 * window.c (Fset_window_start): Doc fix (bug#4199).
877 (Fset_window_hscroll): Ditto.
879 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
881 Fix minor new problems caught by GCC 4.6.1.
882 * term.c (init_tty): Remove unused local.
883 * xsettings.c (store_monospaced_changed): Define this function only
884 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
887 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
889 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
891 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
893 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
894 are the mini-buffer and the echo area (bug#3320).
896 * term.c (init_tty): Remove support for supdup, c10 and perq
897 terminals, which are no longer supported (bug#1482).
899 2011-07-10 Johan Bockgård <bojohan@gnu.org>
901 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
903 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
905 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
906 for non-popups (Bug#3642).
908 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
910 * alloc.c (reset_malloc_hooks): Protoize.
911 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
912 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
913 * cm.c (losecursor): Likewise.
914 * data.c (fmod): Likewise.
915 * dispnew.c (swap_glyphs_in_rows): Likewise.
916 * emacs.c (memory_warning_signal): Likewise.
917 * floatfns.c (float_error): Likewise.
918 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
919 (otf_open, font_otf_capability, generate_otf_features)
920 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
922 * image.c (pbm_read_file): Likewise.
923 * indent.c (string_display_width): Likewise.
924 * intervals.c (check_for_interval, search_for_interval)
925 (inc_interval_count, count_intervals, root_interval)
926 (adjust_intervals_for_insertion, make_new_interval): Likewise.
927 * lread.c (defalias): Likewise.
928 * ralloc.c (r_alloc_check): Likewise.
929 * regex.c (set_image_of_range_1, set_image_of_range)
930 (regex_grow_registers): Likewise.
931 * sysdep.c (strerror): Likewise.
932 * termcap.c (valid_filename_p, tprint, main): Likewise.
933 * tparam.c (main): Likewise.
934 * unexhp9k800.c (run_time_remap, save_data_space)
935 (update_file_ptrs, read_header, write_header, calculate_checksum)
936 (copy_file, copy_rest, display_header): Likewise.
937 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
939 * xdisp.c (check_it): Likewise.
940 * xfaces.c (register_color, unregister_color, unregister_colors):
942 * xfns.c (print_fontset_result): Likewise.
943 * xrdb.c (member, fatal, main): Likewise.
945 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
947 Fix minor problems found by static checking (Bug#9031).
948 * chartab.c (char_table_set_range, map_sub_char_table):
949 Remove unused locals.
950 (uniprop_table): Now static.
951 * composite.c (_work_char): Remove unused static var.
953 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
955 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
957 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
959 * gtkutil.c (qttip_cb): Remove code without function.
961 2011-07-09 Eli Zaretskii <eliz@gnu.org>
963 * w32.c (pthread_sigmask): New stub.
965 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
967 Use pthread_sigmask, not sigprocmask (Bug#9010).
968 sigprocmask is portable only for single-threaded applications, and
969 Emacs can be multi-threaded when it uses GTK.
970 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
972 * callproc.c (Fcall_process):
973 * process.c (create_process):
974 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
975 Use pthread_sigmask, not sigprocmask.
977 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
979 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
980 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
983 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
985 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
986 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
987 (xg_hide_tooltip): Fix comment.
989 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
990 in registerServicesMenuSendTypes.
991 (validRequestorForSendType): Don't check ns_return_types.
993 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
996 2011-07-08 Jason Rumney <jasonr@gnu.org>
998 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
999 frame struct members of non-existent frames (Bug#6284).
1001 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1003 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1004 variable firstTime not needed on OSX >= 10.6.
1005 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1006 >= 10.5. Use setKnobProportion, setDoubleValue.
1008 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1009 (MAC_OS_X_VERSION_10_5): Define if not defined.
1010 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1011 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1012 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1014 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1015 cString and lossyCString on OSX >= 10.4
1017 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1018 sizeToFit on OSX >= 10.2.
1020 * nsimage.m (allocInitFromFile): Don't use deprecated method
1021 bestRepresentationForDevice on OSX >= 10.6.
1023 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1026 * emacs.c: Declare unexec_init_emacs_zone.
1028 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1030 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1032 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1033 on svcsMenu (Bug#8842).
1035 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1037 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1039 * nsterm.m (QUTF8_STRING): Declare.
1040 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1041 (validRequestorForSendType): Return type is (id).
1042 Change indexOfObjectIdenticalTo to indexOfObject.
1043 Check if we have local selection before returning self (Bug#8842).
1044 (writeSelectionToPasteboard): Put local selection into paste board
1045 if we have a local selection (Bug#8842).
1046 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1048 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1049 (ns_get_local_selection): Declare.
1051 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1053 * keymap.c (describe_map_tree): Don't insert a double newline at
1054 the end of the buffer (bug#1169) and return whether we inserted
1057 * callint.c (Fcall_interactively): Change "reading args" to
1058 "providing args" to try to clarify what it does (bug#1010).
1060 2011-07-07 Kenichi Handa <handa@m17n.org>
1062 * composite.c (composition_compute_stop_pos): Ignore a static
1063 composition starting before CHARPOS (Bug#8915).
1065 * xdisp.c (handle_composition_prop): Likewise.
1067 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1069 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1072 2011-07-07 Kenichi Handa <handa@m17n.org>
1074 * character.h (unicode_category_t): New enum type.
1076 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1077 (Qchar_code_property_table): New variable.
1078 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1079 (UNIPROP_COMPRESSED_FORM_P): New macros.
1080 (char_table_ascii): Uncompress the compressed values.
1081 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1082 Uncompress the compressed values.
1083 (sub_char_table_ref_and_range): Likewise.
1084 (char_table_ref_and_range): Uncompress the compressed values.
1085 (sub_char_table_set): New arg is_uniprop. Callers changed.
1086 Uncompress the compressed values.
1087 (sub_char_table_set_range): Args changed. Callers changed.
1088 (char_table_set_range): Adjuted for the above change.
1089 (map_sub_char_table): Delete args default_val and parent. Add arg
1090 top. Give decoded values to a Lisp function.
1091 (map_char_table): Adjusted for the above change. Give decoded
1092 values to a Lisp function. Gcpro more variables.
1093 (uniprop_table_uncompress)
1094 (uniprop_decode_value_run_length): New functions.
1095 (uniprop_decoder, uniprop_decoder_count): New variables.
1096 (uniprop_get_decoder, uniprop_encode_value_character)
1097 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1099 (uniprop_encoder, uniprop_encoder_count): New variables.
1100 (uniprop_get_encoder, uniprop_table)
1101 (Funicode_property_table_internal, Fget_unicode_property_internal)
1102 (Fput_unicode_property_internal): New functions.
1103 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1104 Sunicode_property_table_internal, Sget_unicode_property_internal,
1105 and Sput_unicode_property_internal. Defvar_lisp
1106 char-code-property-alist.
1108 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1109 Vunicode_category_table.
1111 * font.c (font_range): Adjusted for the change of
1112 Vunicode_category_table.
1114 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1116 * m/iris4d.h: Remove file, move contents ...
1117 * s/irix6-5.h: ... here.
1119 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1121 Remove unportable assumption about struct layout (Bug#8884).
1122 * alloc.c (mark_buffer):
1123 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1124 (clone_per_buffer_values): Don't assume that
1125 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1126 This isn't true in general, and it's particularly not true
1127 if Emacs is configured with --with-wide-int.
1128 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1129 New macros, used in the buffer.c change.
1131 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1133 * xsettings.c: Use both GConf and GSettings if both are available.
1134 (store_config_changed_event): Add comment.
1135 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1136 (store_tool_bar_style_changed): New functions.
1137 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1138 (struct xsettings): Move font inside HAVE_XFT.
1139 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1140 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1141 Move inside HAVE_XFT.
1142 (something_changed_gsettingsCB): Renamed from something_changedCB.
1143 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1145 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1146 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1147 (something_changed_gconfCB): Renamed from something_changedCB.
1148 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1149 (parse_settings): Move check for font inside HAVE_XFT.
1150 (read_settings, apply_xft_settings): Add comment.
1151 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1152 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1153 call store_font_name_changed.
1154 (xft_settings_event): Add comment.
1155 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1156 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1157 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1158 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1159 (xsettings_initialize): Call init_gsettings last.
1160 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1163 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1165 Random fixes. E.g., (random) never returned negative values.
1166 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1167 subseconds part to the entropy, as that's a bit more random.
1168 Prefer signed to unsigned, since the signedness doesn't matter and
1169 in general we prefer signed. When given a limit, use a
1170 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1171 latter isn't right if USE_2_TAGS_FOR_INTS.
1172 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1173 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1175 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1177 * textprop.c (text_property_stickiness):
1178 Obey Vtext_property_default_nonsticky.
1179 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1180 * w32fns.c (syms_of_w32fns):
1181 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1183 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1185 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1186 This is more efficient than Ffile_directory_p and avoids a minor race.
1188 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190 * buffer.c (Foverlay_put): Say what the return value is
1193 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1194 is a directory before asking whether to use the file name
1196 (barf_or_query_if_file_exists): Make the "File is a directory"
1197 error be more correct.
1199 * fns.c (Frequire): Remove the mention of the .gz files, since
1200 that's installation-specific, but keep the mention of
1201 `get-load-suffixes'.
1203 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1205 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1206 Report string overflow if the output is too long.
1208 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1210 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1211 (syms_of_gnutls): Remove duplicate DEFSYM for
1212 Qgnutls_bootprop_verify_hostname_error, an error for
1213 Qgnutls_bootprop_verify_error (which is no longer used).
1215 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1216 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1217 Also (re)move comments that are misplaced or no longer relevant.
1219 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1221 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1223 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1225 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1226 and background color parameters if they have been changed.
1228 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1230 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1232 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1234 * xsettings.c (SYSTEM_FONT): Define only when used.
1235 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1237 * keymap.c (access_keymap_1): Now static.
1239 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1241 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1242 leave any prefix arg for the up event (Bug#1586).
1244 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1246 * lread.c (syms_of_lread): Mention single symbols defined by
1247 `defvar' or `defconst' (bug#7154).
1249 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1250 (Frequire): Mention get-load-suffixes.
1252 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1254 * window.h (window): Remove clone_number slot.
1255 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1257 (make_parent_window, make_window, saved_window)
1258 (Fset_window_configuration, save_window_save): Don't deal with
1260 * buffer.c (Qclone_number): Remove declaration.
1261 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1263 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1265 Add multiple inheritance to keymaps.
1266 * keymap.c (Fmake_composed_keymap): New function.
1267 (Fset_keymap_parent): Simplify.
1268 (fix_submap_inheritance): Remove.
1269 (access_keymap_1): New function extracted from access_keymap to handle
1270 embedded parents and handle lists of maps.
1271 (access_keymap): Use it.
1272 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1273 (Fcopy_keymap): Handle embedded parents.
1274 (Fcommand_remapping, define_as_prefix): Simplify.
1275 (Fkey_binding): Simplify.
1276 (syms_of_keymap): Move minibuffer-local-completion-map,
1277 minibuffer-local-filename-completion-map,
1278 minibuffer-local-must-match-map, and
1279 minibuffer-local-filename-must-match-map to Elisp.
1280 (syms_of_keymap): Defsubr make-composed-keymap.
1281 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1282 (parse_menu_item): Trivial simplification.
1284 2011-07-01 Glenn Morris <rgm@gnu.org>
1286 * Makefile.in (SETTINGS_LIBS): Fix typo.
1288 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1290 * coding.c (Fencode_coding_string): Record the last coding system
1291 used, as the function doc string says (bug#8738).
1293 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1295 * xsettings.c (store_monospaced_changed): Take new font as arg and
1296 check for change against current_mono_font.
1297 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1298 (emacs_settings_constructor, emacs_settings_get_property)
1299 (emacs_settings_set_property, emacs_settings_class_init)
1300 (emacs_settings_init, gsettings_obj): Remove.
1301 (something_changedCB): New function for HAVE_GSETTINGS.
1302 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1303 with value as argument.
1304 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1305 g_settings_new (Bug#8967). Do not create gsettings_obj.
1306 Remove calls to g_settings_bind. Connect something_changedCB to
1309 * xgselect.c: Add defined (HAVE_GSETTINGS).
1310 (xgselect_initialize): Ditto.
1312 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1313 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1316 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1318 * eval.c (struct backtrace): Simplify and port the data structure.
1319 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1320 signed bit field, as this assumption is not portable and it makes
1321 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1322 "char debug_on_exit : 1" as this is not portable either; instead,
1323 use the portable "unsigned int debug_on_exit : 1". Remove unused
1324 member evalargs. Remove obsolete comments about cc bombing out.
1326 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1328 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1329 Let HAVE_GSETTINGS override HAVE_GCONF.
1330 (store_monospaced_changed): New function.
1331 (EMACS_SETTINGS): A new type derived from GObject to handle
1332 GSettings notifications.
1333 (emacs_settings_constructor, emacs_settings_get_property)
1334 (emacs_settings_set_property, emacs_settings_class_init):
1336 (gsettings_client, gsettings_obj): New variables.
1337 (GSETTINGS_SCHEMA): New define.
1338 (something_changedCB): Call store_monospaced_changed.
1339 (init_gsettings): New function.
1340 (xsettings_initialize): Call init_gsettings.
1341 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1344 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1347 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1349 * window.c (resize_root_window, grow_mini_window)
1350 (shrink_mini_window): Rename Qresize_root_window to
1351 Qwindow_resize_root_window and Qresize_root_window_vertically to
1352 Qwindow_resize_root_window_vertically.
1354 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1356 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1358 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1360 * makefile.w32-in: Redesign dependencies so they reflect more
1361 clearly which files are directly included by each source file,
1362 and not through other includes.
1364 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1366 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1367 (sort_overlays, overlay_strings): When an overlay's clone number
1368 matches the window's clone number process the overlay even if
1369 the overlay's window property doesn't match the current window.
1371 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1372 (Fwindow_hchild): Rename to Fwindow_left_child.
1373 (Fwindow_next): Rename to Fwindow_next_sibling.
1374 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1375 (resize_window_check): Rename to window_resize_check.
1376 (resize_window_apply): Rename to window_resize_apply.
1377 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1378 (Fdelete_other_windows_internal, resize_frame_windows)
1379 (Fsplit_window_internal, Fdelete_window_internal)
1380 (grow_mini_window, shrink_mini_window)
1381 (Fresize_mini_window_internal): Fix callers accordingly.
1383 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1385 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1386 (emacs_fixed_set_min_size): Remove.
1387 (emacs_fixed_new): Take frame as argument.
1389 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1390 (_EmacsFixedPrivate): Remove minwidth/height.
1391 Add struct frame *f.
1392 (emacs_fixed_init): Initialize priv->f.
1393 (get_parent_class, emacs_fixed_set_min_size): Remove.
1394 (emacs_fixed_new): Set priv->f to argument.
1395 (emacs_fixed_get_preferred_width)
1396 (emacs_fixed_get_preferred_height): Use min_width/height from
1397 frames size_hint to set minimum and natural (Bug#8919).
1398 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1399 and use min_width/height from frames size_hint to set
1400 min_width/height (Bug#8919).
1402 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1403 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1406 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1408 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1409 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1412 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1414 * process.c (wait_reading_process_output): Bypass select if
1415 waiting for a cell while ignoring keyboard input, and input is
1416 pending. Suggested by Jan Djärv (Bug#8869).
1418 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1420 Use gnulib's dup2 module instead of rolling our own.
1421 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1423 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1425 * dispnew.c (scrolling_window): Before scrolling, turn off a
1426 mouse-highlight in the window being scrolled.
1428 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1430 Move DEFSYM to lisp.h and use everywhere.
1432 * character.h (DEFSYM): Move declaration...
1433 * lisp.h (DEFSYM): ...here.
1439 * w32select.c: Don't include character.h.
1441 * alloc.c (syms_of_alloc):
1442 * buffer.c (syms_of_buffer):
1443 * bytecode.c (syms_of_bytecode):
1444 * callint.c (syms_of_callint):
1445 * casefiddle.c (syms_of_casefiddle):
1446 * casetab.c (init_casetab_once):
1447 * category.c (init_category_once, syms_of_category):
1448 * ccl.c (syms_of_ccl):
1449 * cmds.c (syms_of_cmds):
1450 * composite.c (syms_of_composite):
1451 * dbusbind.c (syms_of_dbusbind):
1452 * dired.c (syms_of_dired):
1453 * dispnew.c (syms_of_display):
1454 * doc.c (syms_of_doc):
1455 * editfns.c (syms_of_editfns):
1456 * emacs.c (syms_of_emacs):
1457 * eval.c (syms_of_eval):
1458 * fileio.c (syms_of_fileio):
1459 * fns.c (syms_of_fns):
1460 * frame.c (syms_of_frame):
1461 * fringe.c (syms_of_fringe):
1462 * insdel.c (syms_of_insdel):
1463 * keymap.c (syms_of_keymap):
1464 * lread.c (init_obarray, syms_of_lread):
1465 * macros.c (syms_of_macros):
1466 * msdos.c (syms_of_msdos):
1467 * print.c (syms_of_print):
1468 * process.c (syms_of_process):
1469 * search.c (syms_of_search):
1470 * sound.c (syms_of_sound):
1471 * syntax.c (init_syntax_once, syms_of_syntax):
1472 * terminal.c (syms_of_terminal):
1473 * textprop.c (syms_of_textprop):
1474 * undo.c (syms_of_undo):
1475 * w32.c (globals_of_w32):
1476 * window.c (syms_of_window):
1477 * xdisp.c (syms_of_xdisp):
1478 * xfaces.c (syms_of_xfaces):
1479 * xfns.c (syms_of_xfns):
1480 * xmenu.c (syms_of_xmenu):
1481 * xsettings.c (syms_of_xsettings):
1482 * xterm.c (syms_of_xterm): Use DEFSYM.
1484 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1486 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1488 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1490 Integer and buffer overflow fixes (Bug#8873).
1492 * print.c (printchar, strout): Check for string overflow.
1493 (PRINTPREPARE, printchar, strout):
1494 Don't set size unless allocation succeeds.
1496 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1497 for sizes. Check for string overflow more accurately.
1498 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1500 * macros.c: Integer and buffer overflow fixes.
1501 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1502 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1503 Use ptrdiff_t, not int, for sizes.
1504 Don't increment bufsize until after realloc succeeds.
1505 Check for size-calculation overflow.
1506 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1508 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1510 * lread.c: Integer overflow fixes.
1511 (read_integer): Radix is now EMACS_INT, not int,
1512 to improve quality of diagnostics for out-of-range radices.
1513 Calculate buffer size correctly for out-of-range radices.
1514 (read1): Check for integer overflow in radices, and in
1515 read-circle numbers.
1516 (read_escape): Avoid int overflow.
1517 (Fload, openp, read_buffer_size, read1)
1518 (substitute_object_recurse, read_vector, read_list, map_obarray):
1519 Use ptrdiff_t, not int, for sizes.
1520 (read1): Use EMACS_INT, not int, for sizes.
1521 Check for size overflow.
1523 * image.c (cache_image): Check for size arithmetic overflow.
1525 * lread.c: Integer overflow issues.
1526 (saved_doc_string_size, saved_doc_string_length)
1527 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1528 Now ptrdiff_t, not int.
1529 (read1): Don't assume doc string length fits in int. Check for
1530 out-of-range doc string lengths.
1531 (read_list): Don't assume file position fits in int.
1532 (read_escape): Check for hex character overflow.
1534 2011-06-22 Leo Liu <sdl.web@gmail.com>
1536 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1537 Move to minibuffer.el.
1539 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1541 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1542 The following patches are for when GLYPH_DEBUG && !XASSERT.
1543 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1544 * dispnew.c (flush_stdout):
1545 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1546 Mark as externally visible.
1547 * dispnew.c (check_window_matrix_pointers): Now static.
1548 * dispnew.c (window_to_frame_vpos):
1549 * xfns.c (unwind_create_frame):
1550 * xterm.c (x_check_font): Remove unused local.
1551 * scroll.c (CHECK_BOUNDS):
1552 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1553 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1554 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1555 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1556 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1558 (debug_method_add): Use va_list and vsprintf rather than relying
1559 on undefined behavior with wrong number of arguments.
1560 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1561 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1562 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1563 since we're not interested in debugging glyphs with old libraries.
1564 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1565 GCC 4.6.0's static checking.
1567 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1569 Integer overflow and signedness fixes (Bug#8873).
1570 A few related buffer overrun fixes, too.
1572 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1574 * dispextern.h (struct face.stipple):
1575 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1576 (x_bitmap_mask, x_allocate_bitmap_record)
1577 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1578 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1579 (x_create_bitmap_from_xpm_data):
1580 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1581 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1583 * xfaces.c (load_pixmap):
1584 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1585 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1586 (.bitmaps_last, struct x_output.icon_bitmap):
1587 Use ptrdiff_t, not int, for bitmap indexes.
1588 (x_allocate_bitmap_record): Check for size overflow.
1589 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1591 Use ptrdiff_t, not int, for overlay counts.
1592 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1593 * editfns.c (overlays_around, get_pos_property):
1594 * textprop.c (get_char_property_and_overlay):
1595 * xdisp.c (next_overlay_change, note_mouse_highlight):
1596 * xfaces.c (face_at_buffer_position):
1597 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1598 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1599 (Fnext_overlay_change, Fprevious_overlay_change)
1600 (mouse_face_overlay_overlaps, Foverlays_in):
1601 Use ptrdiff_t, not int, for sizes.
1602 (overlays_at, overlays_in): Check for size-calculation overflow.
1604 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1606 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1607 (x_session_initialize): Do not assume string length fits in int.
1609 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1610 This is unlikely, but can occur if DPI is outlandish.
1612 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1613 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1615 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1616 * xrdb.c (magic_file_p, search_magic_path):
1617 Omit last arg SUFFIX; it was always 0. All callers changed.
1618 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1620 * xfont.c (xfont_match): Avoid need for strlen.
1622 * xfns.c: Don't assume strlen fits in int.
1623 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1625 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1626 not unsigned long, as we prefer signed integers. All callers changed.
1627 Detect integer overflow in repeat count.
1628 (message_dolog): Don't assume print length fits in 39 bytes.
1629 (display_mode_element): Don't assume strlen fits in int.
1631 * termcap.c: Don't assume sizes fit in int and never overflow.
1632 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1633 (gobble_line): Check for size-calculation overflow.
1635 * minibuf.c (Fread_buffer):
1636 * lread.c (intern, intern_c_string):
1637 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1638 Don't assume string length fits in int.
1640 * keyboard.c (parse_tool_bar_item):
1641 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1643 * font.c: Don't assume string length fits in int.
1644 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1645 Use ptrdiff_t, not int.
1646 (font_intern_prop): Don't assume string length fits in int.
1647 Don't assume integer property fits in fixnum.
1648 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1650 * filelock.c: Fix some buffer overrun and integer overflow issues.
1651 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1652 Reformulate so as not to need the command string.
1653 Invoke gzip -cd rather than gunzip, as it's more portable.
1654 (lock_info_type, lock_file_1, lock_file):
1655 Don't assume pid_t and time_t fit in unsigned long.
1656 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1657 (current_lock_owner): Prefer signed type for sizes.
1658 Use memcpy, not strncpy, where memcpy is what is really wanted.
1659 Don't assume (via atoi) that time_t and pid_t fit in int.
1660 Check for time_t and/or pid_t out of range, e.g., via a network share.
1661 Don't alloca where an auto var works fine.
1663 * fileio.c: Fix some integer overflow issues.
1664 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1665 Don't assume string length fits in int.
1666 (directory_file_name): Don't assume string length fits in long.
1667 (make_temp_name): Don't assume pid fits in int, or that its print
1668 length is less than 20.
1670 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1672 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1674 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1676 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1677 We prefer signed integers, even for size calculations.
1679 * emacs.c: Don't assume string length fits in 'int'.
1680 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1681 (main): Don't invoke strlen when not needed.
1683 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1684 (XD_DEBUG_MESSAGE): Don't waste a byte.
1686 * callproc.c (getenv_internal_1, getenv_internal)
1688 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1690 * lread.c (invalid_syntax): Omit length argument.
1691 All uses changed. This doesn't fix a bug, but it simplifies the
1692 code away from its former Hollerith-constant appearance, and it's
1693 one less 'int' to worry about when looking at integer-overflow issues.
1694 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1696 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1697 This didn't break anything, but it didn't help either.
1698 It's confusing to put a bogus integer in a place where the actual
1699 value does not matter.
1700 (LIST_END_P): Remove unused macro and its bogus comment.
1701 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1703 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1704 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1706 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1707 We prefer signed types, and the value cannot exceed the EMACS_INT
1708 range anyway (because otherwise the length would not be representable).
1709 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1710 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1711 This avoids a GCC warning when WIDE_EMACS_INT.
1713 * indent.c (sane_tab_width): New function.
1714 (current_column, scan_for_column, Findent_to, position_indentation)
1715 (compute_motion): Use it. This is just for clarity.
1716 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1718 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1720 * lisp.h (lint_assume): New macro.
1721 * composite.c (composition_gstring_put_cache):
1722 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1724 * editfns.c, insdel.c:
1725 Omit unnecessary forward decls, to simplify future changes.
1727 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1729 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1731 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1732 Use much-faster test for byte-length change.
1733 Don't assume string byte-length fits in 'int'.
1734 Check that character arg fits in 'int'.
1735 (mapcar1): Declare byte as byte, for clarity.
1737 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1739 * fns.c (concat): Catch string overflow earlier.
1740 Do not rely on integer wraparound.
1742 * dispextern.h (struct it.overlay_strings_charpos)
1743 (struct it.selective): Now EMACS_INT, not int.
1744 * xdisp.c (forward_to_next_line_start)
1745 (back_to_previous_visible_line_start)
1746 (reseat_at_next_visible_line_start, next_element_from_buffer):
1747 Don't arbitrarily truncate the value of 'selective' to int.
1749 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1751 * composite.c: Don't truncate sizes to 'int'.
1752 (composition_gstring_p, composition_reseat_it)
1753 (composition_adjust_point): Use EMACS_INT, not int.
1754 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1755 not EMACS_UINT, for indexes.
1757 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1759 * buffer.c: Include <verify.h>.
1760 (struct sortvec.priority, struct sortstr.priority):
1761 Now EMACS_INT, not int.
1762 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1763 (struct sortstr.size, record_overlay_string)
1764 (struct sortstrlist.size, struct sortlist.used):
1765 Don't truncate size to int.
1766 (record_overlay_string): Check for size-calculation overflow.
1767 (init_buffer_once): Check at compile-time, not run-time.
1769 2011-06-22 Jim Meyering <meyering@redhat.com>
1771 Don't leak an XBM-image-sized buffer
1772 * image.c (xbm_load): Free the image buffer after using it.
1774 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1777 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1778 that Sun C diagnosed.
1779 * fns.c (secure_hash): Fix pointer signedness issue.
1780 * intervals.c (static_offset_intervals): New function.
1781 (offset_intervals): Use it.
1783 2011-06-21 Leo Liu <sdl.web@gmail.com>
1786 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1789 * fns.c (secure_hash): Rename from crypto_hash_function and change
1790 the first arg to accept symbols.
1791 (Fsecure_hash): New primitive.
1792 (syms_of_fns): New symbols.
1794 2011-06-20 Deniz Dogan <deniz@dogan.se>
1796 * process.c (Fset_process_buffer): Clarify return value in
1799 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1801 * dispnew.c (add_window_display_history): Use BVAR.
1803 * xdisp.c (debug_method_add): Use BVAR.
1804 (check_window_end, dump_glyph_matrix, dump_glyph)
1805 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1807 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1810 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1811 check till after the cache is created in init_frame_faces.
1813 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1815 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1817 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1819 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1820 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1821 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1823 Improve buffer-overflow checking (Bug#8873).
1824 * fileio.c (Finsert_file_contents):
1825 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1826 Remove the old (too-loose) buffer overflow checks.
1827 They weren't needed, since make_gap checks for buffer overflow.
1828 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1829 The old code merely checked for Emacs fixnum overflow, and relied
1830 on undefined (wraparound) behavior. The new code avoids undefined
1831 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1833 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1834 Tune. Don't use wider integers than needed. Don't use alloca.
1835 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1837 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1839 * insdel.c, lisp.h (buffer_overflow): New function.
1840 (insert_from_buffer_1, replace_range, replace_range_2):
1841 * insdel.c (make_gap_larger):
1842 * editfns.c (Finsert_char):
1843 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1845 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1847 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1849 Integer overflow and signedness fixes (Bug#8873).
1851 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1852 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1854 * fileio.c: Don't assume EMACS_INT fits in off_t.
1855 (emacs_lseek): New static function.
1856 (Finsert_file_contents, Fwrite_region): Use it.
1857 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1859 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1861 * fns.c: Don't overflow int when computing a list length.
1862 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1863 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1864 truncation on 64-bit hosts. Check for QUIT every
1865 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1866 faster and is responsive enough.
1867 (Flength): Report an error instead of overflowing an integer.
1868 (Fsafe_length): Return a float if the value is not representable
1869 as a fixnum. This shouldn't happen except in contrived situations.
1870 (Fnthcdr, Fsort): Don't assume list length fits in int.
1871 (Fcopy_sequence): Don't assume vector length fits in int.
1873 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1874 (header_size, word_size): New constants.
1875 (allocate_vectorlike): Don't check size overflow here.
1876 (allocate_vector): Check it here instead, since this is the only
1877 caller of allocate_vectorlike that could cause overflow.
1878 Check that the new vector's length is representable as a fixnum.
1880 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1881 The previous code was bogus. For example, next_almost_prime (32)
1882 returned 39, which is undesirable as it is a multiple of 3; and
1883 next_almost_prime (24) returned 25, which is a multiple of 5 so
1884 why was the code bothering to check for multiples of 7?
1886 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1888 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1890 Variadic C functions now count arguments with ptrdiff_t.
1891 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1892 Back then I didn't know that the Emacs coding style prefers signed int.
1893 Also, in the meantime I found a few more instances where arguments
1894 were being counted with int, which may truncate counts on 64-bit
1895 machines, or EMACS_INT, which may be unnecessarily wide.
1896 * lisp.h (struct Lisp_Subr.function.aMANY)
1897 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1898 Arg counts are now ptrdiff_t, not size_t.
1899 All variadic functions and their callers changed accordingly.
1900 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1901 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1902 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1903 * callint.c (Fcall_interactively): Check arg count for overflow,
1904 to avoid potential buffer overrun. Use signed char, not 'int',
1905 for 'varies' array, so that we needn't bother to check its size
1906 calculation for overflow.
1907 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1908 * eval.c (apply_lambda):
1909 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1910 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1911 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1913 * callint.c (Fcall_interactively): Don't use index var as event count.
1915 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1916 * mem-limits.h (SIZE): Remove; no longer used.
1918 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1920 Remove unnecessary casts.
1921 * xterm.c (x_term_init):
1922 * xfns.c (x_set_border_pixel):
1923 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1924 These aren't needed now that we assume ANSI C.
1926 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1927 It's more likely to cause problems (due to unsigned overflow)
1930 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1932 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1934 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1936 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1938 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1940 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1942 GLYPH_CODE_FACE returns EMACS_INT, not int.
1943 * dispextern.h (merge_faces):
1944 * xfaces.c (merge_faces):
1945 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1946 Don't assume EMACS_INT fits in int.
1948 * character.h (CHAR_VALID_P): Remove unused parameter.
1949 * fontset.c, lisp.h, xdisp.c: All uses changed.
1951 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1953 * fns.c (concat): Minor tuning based on overflow analysis.
1954 This doesn't fix any bugs. Use int to hold character, instead
1955 of constantly refetching from Emacs object. Use XFASTINT, not
1956 XINT, for value known to be a character. Don't bother comparing
1957 a single byte to 0400, as it's always less.
1959 * floatfns.c (Fexpt):
1960 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1962 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1965 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1967 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1968 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1969 incorrectly succeed when S was a string, because 4294967386 was
1970 truncated before it was used.
1972 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1973 Otherwise, an out-of-range integer could cause undefined behavior
1976 * composite.c: Use int, not EMACS_INT, for characters.
1977 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1978 EMACS_INT, for values that are known to be in character range.
1979 This doesn't fix any bugs but is the usual style inside Emacs and
1980 may generate better code on 32-bit machines.
1982 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1983 This is for reasons similar to the recent CHAR_STRING fix.
1984 * charset.c (Fencode_char): Check that character arg is actually
1985 a character. Pass an int to ENCODE_CHAR.
1986 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1987 wider than 'int', as a compile-time check to prevent future regressions
1990 * character.c (char_string): Remove unnecessary casts.
1992 Make sure a 64-bit char is never passed to CHAR_STRING.
1993 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1994 by silently ignoring the top 32 bits, allowing some values
1995 that were far too large to be valid characters.
1996 * character.h: Include <verify.h>.
1997 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1998 arguments are no wider than unsigned, as a compile-time check
1999 to prevent future regressions in this area.
2001 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2002 (Fsubst_char_in_region):
2004 * xdisp.c (decode_mode_spec_coding):
2005 Adjust to CHAR_STRING's new requirement.
2006 * editfns.c (Finsert_char, Fsubst_char_in_region):
2007 * fns.c (concat): Check that character args are actually
2008 characters. Without this test, these functions did the wrong
2009 thing with wildly out-of-range values on 64-bit hosts.
2011 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2012 These casts should not be needed on 32-bit hosts, either.
2013 * keyboard.c (read_char):
2014 * lread.c (Fload): Remove casts to unsigned.
2016 * lisp.h (UNSIGNED_CMP): New macro.
2017 This fixes comparison bugs on 64-bit hosts.
2018 (ASCII_CHAR_P): Use it.
2019 * casefiddle.c (casify_object):
2020 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2021 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2022 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2023 * dispextern.h (FACE_FROM_ID):
2024 * keyboard.c (read_char): Use UNSIGNED_CMP.
2026 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2027 not to EMACS_INT, to avoid GCC warning.
2029 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2031 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2032 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2033 isn't needed on 32-bit machines.
2035 * buffer.c (Fgenerate_new_buffer_name):
2036 Use EMACS_INT for count, not int.
2037 (advance_to_char_boundary): Return EMACS_INT, not int.
2039 * data.c (Qcompiled_function): Now static.
2041 * window.c (window_body_lines): Now static.
2043 * image.c (gif_load): Rename local to avoid shadowing.
2045 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2046 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2047 * alloc.c (make_save_value): Integer argument is now of type
2049 (mark_object): Use ptrdiff_t, not int.
2050 * lisp.h (pD): New macro.
2051 * print.c (print_object): Use it.
2053 * alloc.c: Use EMACS_INT, not int, to count objects.
2054 (total_conses, total_markers, total_symbols, total_vector_size)
2055 (total_free_conses, total_free_markers, total_free_symbols)
2056 (total_free_floats, total_floats, total_free_intervals)
2057 (total_intervals, total_strings, total_free_strings):
2058 Now EMACS_INT, not int. All uses changed.
2059 (Fgarbage_collect): Compute overall total using a double, so that
2060 integer overflow is less likely to be a problem. Check for overflow
2061 when converting back to an integer.
2062 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2063 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2064 These were 'int' variables that could overflow on 64-bit hosts;
2065 they were never used, so remove them instead of repairing them.
2066 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2067 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2068 Previously, this ceilinged at INT_MAX, but that doesn't work on
2070 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2072 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2073 (allocate_vectorlike): Check for ptrdiff_t overflow.
2074 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2075 when a (possibly-narrower) signed value would do just as well.
2076 We prefer using signed arithmetic, to avoid comparison confusion.
2078 * alloc.c: Catch some string size overflows that we were missing.
2079 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2080 for convenience in STRING_BYTES_MAX.
2081 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2082 The definition here is exact; the one in lisp.h was approximate.
2083 (allocate_string_data): Check for string overflow. This catches
2084 some instances we weren't catching before. Also, it catches
2085 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2086 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2087 and ptrdiff_t and EMACS_INT are both 64 bits.
2089 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2090 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2091 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2093 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2095 * alloc.c (Fmake_string): Check for out-of-range init.
2097 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2099 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2101 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2103 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2104 xg_get_default_scrollbar_width.
2106 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2107 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2108 (style_changed_cb): Call update_theme_scrollbar_width and call
2109 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2110 all frames (Bug#8505).
2111 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2112 Call gtk_window_set_resizable if HAVE_GTK3.
2113 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2114 and height if HAVE_GTK3 (Bug#8505).
2115 (scroll_bar_width_for_theme): New variable.
2116 (update_theme_scrollbar_width): New function.
2117 (xg_get_default_scrollbar_width): Move code to
2118 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2119 (xg_initialize): Call update_theme_scrollbar_width.
2121 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2123 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2125 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2127 * frame.c (make_frame): Call other_buffer_safely instead of
2130 * window.c (temp_output_buffer_show): Call display_buffer with
2131 second argument Vtemp_buffer_show_specifiers and reset latter
2132 immediately after the call.
2133 (Vtemp_buffer_show_specifiers): New variable.
2134 (auto_window_vscroll_p, next_screen_context_lines)
2135 (Vscroll_preserve_screen_position): Remove leading asterisks from
2138 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2140 Fix minor problems found by GCC 4.6.0 static checking.
2141 * buffer.c (Qclone_number): Remove for now, as it's unused.
2142 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2143 (record_buffer): Remove unused local.
2144 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2145 (set_frame_buffer_list): Remove; unused.
2146 * frame.h (other_visible_frames): Remove decl.
2147 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2148 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2149 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2151 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2152 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2153 Define only if HAVE_GPM.
2154 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2155 (update_hints_inhibit): Remove; never set. All uses removed.
2156 * widgetprv.h (emacsFrameClassRec): Remove decl.
2157 * window.c (delete_deletable_window): Now returns void, since it
2158 wasn't returning anything.
2159 (compare_window_configurations): Remove unused locals.
2160 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2161 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2162 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2163 the same widths as pointers. This follows up on the 2011-05-06 patch.
2164 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2165 * xterm.h: Likewise.
2166 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2168 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2170 * makefile.w32-in: Update dependencies.
2171 (LISP_H): Add lib/intprops.h.
2173 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2175 * image.c (gif_load): Add animation frame delay to the metadata.
2176 (syms_of_image): Use DEFSYM. New symbol `delay'.
2178 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2180 * window.c (delete_deletable_window): Re-add.
2181 (Fset_window_configuration): Rewrite to handle dead buffers and
2182 consequently deletable windows.
2183 (window_tree, Fwindow_tree): Remove. Supply functionality in
2185 (compare_window_configurations): Simplify code.
2187 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2189 * image.c (imagemagick_load_image): Fix type mismatch.
2190 (Fimagemagick_types): Likewise.
2192 * window.h (replace_buffer_in_windows): Declare.
2194 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2196 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2197 Qclone_number. Remove external declaration of Qdelete_window.
2198 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2200 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2201 Qbuffer_list_update_hook if allowed.
2202 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2203 buffer list implementation.
2204 (other_buffer_safely): New function.
2205 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2206 calls to replace_buffer_in_windows and
2207 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2209 (record_buffer): Inhibit quitting and rewrite using quittable
2210 functions. Run Qbuffer_list_update_hook if allowed.
2211 (Frecord_buffer, Funrecord_buffer): New functions.
2212 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2213 switch-to-buffer to window.el.
2214 (bury-buffer): Move to window.el.
2215 (Vbuffer_list_update_hook): New variable.
2217 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2220 * window.h (resize_frame_windows): Move up in code.
2221 (Fwindow_frame): Remove EXFUN.
2222 (replace_buffer_in_all_windows): Remove prototype.
2223 (replace_buffer_in_windows_safely): Add prototype.
2225 * window.c: Declare Qdelete_window static again. Move down
2226 declaration of select_count.
2227 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2228 (Fother_window): Move to window.el.
2229 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2230 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2231 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2233 (replace_buffer_in_windows): Implement by calling
2234 Qreplace_buffer_in_windows.
2235 (replace_buffer_in_all_windows): Remove with some functionality
2236 moved into replace_buffer_in_windows_safely.
2237 (replace_buffer_in_windows_safely): New function.
2238 (select_window_norecord, select_frame_norecord): Move in front
2239 of run_window_configuration_change_hook. Remove now obsolete
2241 (Fset_window_buffer): Rewrite doc-string. Call
2242 Qrecord_window_buffer.
2243 (keys_of_window): Move binding for other-window to window.el.
2245 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2247 * dispextern.h (struct image): Replace data member, whose int_val
2248 and ptr_val fields were not used by anything, with a single
2251 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2252 (gif_clear_image, gif_load, imagemagick_load_image)
2253 (gs_clear_image, gs_load): Callers changed.
2255 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2257 * buffer.h: Include <time.h>, for time_t.
2258 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2260 Fix minor problems found by static checking.
2262 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2264 Make identifiers static if they are not used in other modules.
2265 * data.c (Qcompiled_function, Qframe, Qvector):
2266 * image.c (QimageMagick, Qsvg):
2267 * minibuf.c (Qmetadata):
2268 * window.c (resize_window_check, resize_root_window): Now static.
2269 * window.h (resize_window_check, resize_root_window): Remove decls.
2271 * window.c (window_deletion_count, delete_deletable_window):
2273 (window_body_lines): Now static.
2274 (Fdelete_other_windows_internal): Mark vars as initialized.
2275 Make sure 'resize_failed' is initialized.
2276 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2277 (resize_window_apply): Remove unused local.
2278 * window.h (delete_deletable_window): Remove decl.
2280 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2281 (imagemagick_load_image): Fix pointer signedness problem by changing
2282 last arg from unsigned char * to char *. All uses changed.
2283 Also, fix a local for similar reasons.
2284 Remove unused locals. Remove locals to avoid shadowing.
2285 (fn_rsvg_handle_free): Remove; unused.
2286 (svg_load, svg_load_image): Fix pointer signedness problem.
2287 (imagemagick_load_image): Don't use garbage pointer image_wand.
2289 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2291 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2293 * image.c (gif_load): Fix omitted cast error introduced by
2296 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2298 * window.h (resize_proportionally, orig_total_lines)
2299 (orig_top_line): Remove from window structure.
2300 (set_window_height, set_window_width, change_window_heights)
2301 (Fdelete_window): Remove prototypes.
2302 (resize_frame_windows): Remove duplicate declaration.
2304 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2306 * window.h (resize_frame_windows, resize_window_check)
2307 (delete_deletable_window, resize_root_window)
2308 (resize_frame_windows): Declare prototypes.
2310 * window.c (resize_window_apply): Make definition be "static" to
2311 match the prototype.
2313 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2315 * window.c: Remove declarations of Qwindow_size_fixed,
2316 window_min_size_1, window_min_size_2, window_min_size,
2317 size_window, window_fixed_size_p, enlarge_window, delete_window.
2318 Remove static from declaration of Qdelete_window, it's
2319 temporarily needed by Fbury_buffer.
2320 (replace_window): Don't assign orig_top_line and
2322 (Fdelete_window, delete_window): Remove. Window deletion is
2323 handled by window.el.
2324 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2325 Fdelete_window calls with calls to Qdelete_window.
2326 (Fdelete_other_windows): Remove. Deleting other windows is
2327 handled by window.el.
2328 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2329 handled in window.el.
2330 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2331 Window minimum sizes are handled in window.el.
2332 (shrink_windows, size_window, set_window_height)
2333 (set_window_width, change_window_heights, window_height)
2334 (window_width, CURBEG, CURSIZE, enlarge_window)
2335 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2336 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2337 handled in window.el.
2338 (make_dummy_parent): Rename to make_parent_window and give it a
2339 second argument horflag.
2340 (make_window): Don't set resize_proportionally any more.
2341 (Fsplit_window): Remove. Windows are split in window.el.
2342 (save_restore_action, save_restore_orig_size)
2343 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2344 Resize mini windows in window.el.
2345 (grow_mini_window, shrink_mini_window): Implement by calling
2346 Qresize_root_window_vertically, resize_window_check and
2347 resize_window_apply.
2348 (saved_window, Fset_window_configuration, save_window_save): Do
2349 not handle orig_top_line, orig_total_lines, and
2350 resize_proportionally.
2351 (window_min_height, window_min_width): Move to window.el.
2352 (keys_of_window): Move bindings for delete-other-windows,
2353 split-window, delete-window and enlarge-window to window.el.
2355 * buffer.c: Temporarily extern Qdelete_window.
2356 (Fbury_buffer): Temporarily call Qdelete_window instead of
2357 Fdelete_window (Fbury_buffer will move to window.el soon).
2359 * frame.c (set_menu_bar_lines_1): Remove code handling
2360 orig_top_line and orig_total_lines.
2362 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2363 set_window_height but set heights directly.
2364 (change_frame_size_1): Use resize_frame_windows.
2366 * xdisp.c (init_xdisp): Don't use set_window_height but set
2369 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2370 resize_frame_windows instead of change_window_heights and run
2371 run_window_configuration_change_hook.
2373 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2374 instead of change_window_heights and run
2375 run_window_configuration_change_hook.
2377 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2379 * window.c (replace_window): Rename second argument REPLACEMENT to
2380 NEW. New third argument SETFLAG. Rewrite.
2381 (delete_window, make_dummy_parent): Call replace_window with
2383 (window_list_1): Move down in code.
2384 (run_window_configuration_change_hook): Move set_buffer part
2385 before select_frame_norecord part in order to unwind correctly.
2386 Rename count1 to count.
2387 (recombine_windows, delete_deletable_window, resize_root_window)
2388 (Fdelete_other_windows_internal)
2389 (Frun_window_configuration_change_hook, make_parent_window)
2390 (resize_window_check, resize_window_apply, Fresize_window_apply)
2391 (resize_frame_windows, Fsplit_window_internal)
2392 (Fdelete_window_internal, Fresize_mini_window_internal): New
2394 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2396 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2398 * window.h (window): Add some new members to window structure -
2399 normal_lines, normal_cols, new_total, new_normal, clone_number,
2400 splits, nest, prev_buffers, next_buffers.
2401 (WINDOW_TOTAL_SIZE): Move here from window.c.
2402 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2404 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2406 (make_dummy_parent): Set new members of windows structure.
2407 (make_window): Move down in code. Handle new members of window
2409 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2410 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2411 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2412 (Fset_window_prev_buffers, Fwindow_next_buffers)
2413 (Fset_window_next_buffers, Fset_window_clone_number): New
2415 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2416 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2418 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2419 Argument WINDOW can be now internal window too.
2420 (Fwindow_use_time): Move up in code.
2421 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2423 (Fset_window_configuration, saved_window)
2424 (Fcurrent_window_configuration, save_window_save): Handle new
2425 members of window structure.
2426 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2427 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2428 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2429 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2430 Qget_mru_window, Qresize_root_window,
2431 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2432 Qauto_buffer_name; staticpro them.
2434 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2436 * window.c (Fwindow_total_size, Fwindow_left_column)
2437 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2438 (Fwindow_list_1): New functions.
2439 (window_box_text_cols): Replace with window_body_cols.
2440 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2441 window_body_cols instead of window_box_text_cols.
2442 (delete_window, Fset_window_configuration): Call
2443 delete_all_subwindows with window as argument.
2444 (delete_all_subwindows): Take a window as argument and not a
2446 (window_loop): Remove handling of GET_LRU_WINDOW and
2448 (Fget_lru_window, Fget_largest_window): Move to window.el.
2450 * window.h: Extern window_body_cols instead of
2451 window_box_text_cols. delete_all_subwindows now takes a
2452 Lisp_Object as argument.
2454 * indent.c (compute_motion, Fcompute_motion): Use
2455 window_body_cols instead of window_box_text_cols.
2457 * frame.c (delete_frame): Call delete_all_subwindows with root
2460 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2462 * fns.c (Fputhash): Document return value.
2464 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2466 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2468 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2470 Cons<->int and similar integer overflow fixes (Bug#8794).
2472 Check for overflow when converting integer to cons and back.
2473 * charset.c (Fdefine_charset_internal, Fdecode_char):
2474 Use cons_to_unsigned to catch overflow.
2475 (Fencode_char): Use INTEGER_TO_CONS.
2476 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2477 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2478 * data.c (long_to_cons, cons_to_long): Remove.
2479 (cons_to_unsigned, cons_to_signed): New functions.
2480 These signal an error for invalid or out-of-range values.
2481 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2482 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2483 * font.c (Ffont_variation_glyphs):
2484 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2485 * lisp.h: Include <intprops.h>.
2486 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2487 (cons_to_signed, cons_to_unsigned): New decls.
2488 (long_to_cons, cons_to_long): Remove decls.
2489 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2490 (Fprimitive_undo): Use CONS_TO_INTEGER.
2491 * xfns.c (Fx_window_property): Likewise.
2492 * xselect.c: Include <limits.h>.
2493 (x_own_selection, selection_data_to_lisp_data):
2494 Use INTEGER_TO_CONS.
2495 (x_handle_selection_request, x_handle_selection_clear)
2496 (x_get_foreign_selection, Fx_disown_selection_internal)
2497 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2498 (lisp_data_to_selection_data): Use cons_to_unsigned.
2499 (x_fill_property_data): Use cons_to_signed.
2500 Report values out of range.
2502 Check for buffer and string overflow more precisely.
2503 * buffer.h (BUF_BYTES_MAX): New macro.
2504 * lisp.h (STRING_BYTES_MAX): New macro.
2505 * alloc.c (Fmake_string):
2506 * character.c (string_escape_byte8):
2507 * coding.c (coding_alloc_by_realloc):
2508 * doprnt.c (doprnt):
2509 * editfns.c (Fformat):
2511 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2512 since they may not be the same number.
2513 * editfns.c (Finsert_char):
2514 * fileio.c (Finsert_file_contents):
2515 Likewise for BUF_BYTES_MAX.
2517 * image.c: Use ptrdiff_t, not int, for sizes.
2518 (slurp_file): Switch from int to ptrdiff_t.
2520 (slurp_file): Check that file size fits in both size_t (for
2521 malloc) and ptrdiff_t (for sanity and safety).
2523 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2524 if b->modtime has its maximal value.
2526 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2528 Don't assume time_t can fit into int.
2529 * buffer.h (struct buffer.modtime): Now time_t, not int.
2530 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2531 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2533 Minor fixes for signed vs unsigned integers.
2534 * character.h (MAYBE_UNIFY_CHAR):
2535 * charset.c (maybe_unify_char):
2536 * keyboard.c (read_char, reorder_modifiers):
2537 XINT -> XFASTINT, since the integer must be nonnegative.
2538 * ftfont.c (ftfont_spec_pattern):
2539 * keymap.c (access_keymap, silly_event_symbol_error):
2540 XUINT -> XFASTINT, since the integer must be nonnegative.
2541 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2542 since it makes no difference and we prefer signed.
2543 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2544 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2547 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2549 * window.h (Fwindow_frame): Declare.
2551 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2553 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2554 (SPARE_MEMORY): Always define.
2555 (LARGE_REQUEST): Remove.
2556 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2558 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2560 * lisp.h: Move EXFUNS for Fframe_root_window,
2561 Fframe_first_window and Fset_frame_selected_window to window.h.
2563 * window.h: Move EXFUNS for Fframe_root_window,
2564 Fframe_first_window and Fset_frame_selected_window here from
2567 * frame.c (Fwindow_frame, Fframe_first_window)
2568 (Fframe_root_window, Fframe_selected_window)
2569 (Fset_frame_selected_window): Move to window.c.
2570 (Factive_minibuffer_window): Move to minibuf.c.
2571 (Fother_visible_frames_p): New function.
2573 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2575 * window.c (decode_window, decode_any_window): Move up in code.
2576 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2577 (inhibit_frame_unsplittable): Remove unused variable.
2578 (Fwindow_buffer): Move up and rewrite doc-string.
2579 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2580 (Fwindow_prev): New functions.
2581 (Fwindow_frame): Move here from frame.c. Accept any window as
2583 (Fframe_root_window, Fframe_first_window)
2584 (Fframe_selected_window): Move here from frame.c. Accept frame
2585 or arbitrary window as argument. Update doc-strings.
2586 (Fminibuffer_window): Move up in code.
2587 (Fwindow_minibuffer_p): Move up in code and simplify.
2588 (Fset_frame_selected_window): Move here from frame.c.
2590 (Fselected_window, select_window, Fselect_window): Move up in
2591 code. Minor doc-string fixes.
2593 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2595 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2596 Do not assume that spare memory exists; that assumption is valid
2597 only if SYSTEM_MALLOC.
2598 (LARGE_REQUEST): New macro, so that the issue of large requests
2599 is separated from the issue of spare memory.
2601 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2603 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2606 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2608 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2611 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2613 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2615 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2617 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2618 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2620 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2622 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2624 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2626 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2627 (x_clipboard_manager_save): Add return value.
2628 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2630 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2631 Obey Vx_select_enable_clipboard_manager. Catch errors in
2632 x_clipboard_manager_save (Bug#8779).
2633 (Vx_select_enable_clipboard_manager): New variable.
2634 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2636 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2638 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2640 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2642 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2643 in the current matrix if keep_current_p is non-zero.
2645 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2647 * bidi.c (bidi_level_of_next_char): Fix last change.
2649 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2651 Support bidi reordering of text covered by display properties.
2653 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2654 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2655 (bidi_cache_search, bidi_cache_iterator_state)
2656 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2657 (bidi_level_of_next_char, bidi_move_to_visually_next):
2658 Support character positions inside a run of characters covered by a
2660 (bidi_paragraph_init, bidi_resolve_explicit_1)
2661 (bidi_level_of_next_char): Call bidi_fetch_char and
2662 bidi_fetch_char_advance instead of FETCH_CHAR and
2664 (bidi_init_it): Initialize new members.
2665 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2667 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2668 instead of using explicit *_CHAR codes.
2669 (bidi_resolve_explicit, bidi_resolve_weak):
2670 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2671 bidirectional text is supported only in multibyte buffers.
2672 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2673 it to initialize the frame_window_p member of struct bidi_it.
2674 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2675 (bidi_resolve_explicit, bidi_resolve_weak)
2676 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2677 bidi_it->nchars is non-positive.
2678 (bidi_level_of_next_char): Don't try to lookup the cache for the
2679 next/previous character if nothing is cached there yet, or if we
2680 were just reseat()'ed to a new position.
2682 * xdisp.c (set_cursor_from_row): Set start and stop points
2683 according to the row's direction when priming the loop that looks
2684 for the glyph on which to display cursor.
2685 (single_display_spec_intangible_p): Function deleted.
2686 (display_prop_intangible_p): Reimplement to call
2687 handle_display_spec instead of single_display_spec_intangible_p.
2688 Accept 3 additional arguments needed by handle_display_spec.
2689 This fixes incorrect cursor motion across display property with complex
2690 values: lists, `(when COND...)' forms, etc.
2691 (single_display_spec_string_p): Support property values that are
2692 lists with the argument STRING its top-level element.
2693 (display_prop_string_p): Fix the condition for processing a
2694 property that is a list to be consistent with handle_display_spec.
2695 (handle_display_spec): New function, refactored from the
2696 last portion of handle_display_prop.
2697 (compute_display_string_pos): Accept additional argument
2698 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2699 value of a `display' property is a "replacing spec".
2700 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2701 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2702 the display property, but just return a value indicating whether
2703 the display property will replace the characters it covers.
2704 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2705 frame_window_p members of struct bidi_it.
2706 (compute_display_string_pos, compute_display_string_end):
2708 (push_it): Accept second argument POSITION, where pop_it should
2709 jump to continue iteration.
2710 (reseat_1): Initialize bidi_it.disp_pos.
2712 * keyboard.c (adjust_point_for_property): Adjust the call to
2713 display_prop_intangible_p to its new signature.
2715 * dispextern.h (struct bidi_it): New member frame_window_p.
2716 (bidi_init_it): Update prototypes.
2717 (display_prop_intangible_p): Update prototype.
2718 (compute_display_string_pos, compute_display_string_end):
2720 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2723 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2725 Malloc failure behavior now depends on size of allocation.
2726 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2727 * lisp.h: Change signatures accordingly.
2728 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2729 All callers changed. (Bug#8762)
2731 * gnutls.c: Use Emacs's memory allocators.
2732 Without this change, the gnutls library would invoke malloc etc.
2733 directly, which causes problems on non-SYNC_INPUT hosts, and which
2734 runs afoul of improving memory_full behavior. (Bug#8761)
2735 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2736 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2737 xfree instead of the default malloc, realloc, free.
2738 (Fgnutls_boot): No need to check for memory allocation failure,
2739 since xmalloc does that for us.
2741 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2742 * category.c (hash_get_category_set):
2743 * ccl.c (ccl_driver):
2744 * charset.c (Fdefine_charset_internal):
2745 * charset.h (struct charset.hash_index):
2746 * composite.c (get_composition_id, gstring_lookup_cache)
2747 (composition_gstring_put_cache):
2748 * composite.h (struct composition.hash_index):
2749 * dispextern.h (struct image.hash):
2750 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2751 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2752 (hashfn_equal, hashfn_user_defined, make_hash_table)
2753 (maybe_resize_hash_table, hash_lookup, hash_put)
2754 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2755 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2756 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2757 * image.c (make_image, search_image_cache, lookup_image)
2758 (xpm_put_color_table_h):
2759 * lisp.h (struct Lisp_Hash_Table):
2760 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2761 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2762 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2763 * alloc.c (allocate_vectorlike):
2764 Check for overflow in vector size calculations.
2765 * ccl.c (ccl_driver):
2766 Check for overflow when converting EMACS_INT to int.
2767 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2768 need to be updated by these changes.
2769 * fns.c (make_hash_table, maybe_resize_hash_table):
2770 Check for integer overflow with large hash tables.
2771 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2772 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2773 (SXHASH_REDUCE): New macro.
2774 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2775 Use it instead of discarding useful hash info with large hash values.
2776 (sxhash_float): New function.
2777 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2778 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2779 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2780 Rewrite to use FIXNUM_BITS, as this simplifies things.
2781 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2782 Adjust signatures to match updated version of code.
2783 (consing_since_gc): Now EMACS_INT, since a single hash table can
2784 use more than INT_MAX bytes.
2786 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2788 Make it possible to build with GCC-4.6+ -O2 -flto.
2790 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2792 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2794 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2795 Call minibuffer-inactive-mode.
2797 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2799 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2800 Update dependencies.
2802 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2804 * data.c (init_data): Remove code for UTS, this system is not
2807 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2809 Don't force ./temacs to start in terminal mode.
2811 * frame.c (make_initial_frame): Initialize faces in all cases, not
2812 only when CANNOT_DUMP is defined.
2813 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2815 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2817 * dispnew.c (add_window_display_history): Use const for the string
2818 pointer. Remove declaration, not needed.
2820 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2822 Use 'inline', not 'INLINE'.
2823 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2824 * alloc.c, fontset.c (INLINE): Remove.
2825 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2826 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2827 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2828 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2829 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2831 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2833 Make it possible to run ./temacs.
2835 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2836 syms_of_callproc does the same thing. Remove test for
2837 "initialized", do it in the caller.
2838 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2840 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2842 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2843 (read_minibuf): Use get_minibuffer.
2844 (syms_of_minibuf): Use DEFSYM.
2845 (Qmetadata): New var.
2846 * data.c (Qbuffer): Don't make it static.
2847 (syms_of_data): Use DEFSYM.
2849 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2851 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2852 (CCL_CODE_MIN): New macro.
2854 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2856 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2858 * eval.c (Qdebug): Now static.
2859 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2860 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2861 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2863 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2865 * image.c: Various fixes to ImageMagick code comments.
2866 (Fimagemagick_types): Doc fix.
2868 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2870 Minor fixes prompted by GCC 4.6.0 warnings.
2872 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2874 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2875 (x_clipboard_manager_save_all): Move extern decl to ...
2876 * xterm.h: ... here, so that it can be checked for consistency.
2878 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2880 * xselect.c (x_clipboard_manager_save_frame)
2881 (x_clipboard_manager_save_all): New functions.
2882 (Fx_clipboard_manager_save): Lisp function deleted.
2884 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2885 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2887 * xterm.h: Update prototype.
2889 2011-05-28 William Xu <william.xwl@gmail.com>
2891 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2894 2011-05-28 Jim Meyering <meyering@redhat.com>
2896 Avoid a sign-extension bug in crypto_hash_function.
2897 * fns.c (to_uchar): Define.
2898 (crypto_hash_function): Use it to convert some newly-signed
2899 variables to unsigned, to avoid sign-extension bugs. For example,
2900 without this change, (md5 "truc") would evaluate to
2901 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2902 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2903 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2905 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2907 Integer overflow fixes.
2909 * dbusbind.c: Serial number integer overflow fixes.
2910 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2911 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2912 to hold a serial number that is too large for a fixnum.
2913 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2914 Check for serial numbers out of range. Decode any serial number
2915 that was so large that it became a float. (Bug#8722)
2917 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2918 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2919 Use XFASTINT rather than XUINT when numbers are nonnegative.
2920 (xd_append_arg, Fdbus_method_return_internal):
2921 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2922 arguments, check that Lisp number is nonnegative, rather than
2923 silently wrapping negative numbers around. (Bug#8722)
2924 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2927 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2929 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2931 ccl: add integer overflow checks
2932 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2933 (IN_INT_RANGE): New macros.
2934 (ccl_driver): Use them to check for integer overflow when
2935 decoding a CCL program. Many of the new checks are whether XINT (x)
2936 fits in int; it doesn't always, on 64-bit hosts. The new version
2937 doesn't catch all possible integer overflows, but it's an
2938 improvement. (Bug#8719)
2940 * alloc.c (make_event_array): Use XINT, not XUINT.
2941 There's no need for unsigned here.
2943 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2944 This follows up to the 2011-05-06 change that substituted uintptr_t
2945 for EMACS_INT. This case wasn't caught back then.
2947 Rework Fformat to avoid integer overflow issues.
2948 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2949 now (part of C89). Include <verify.h>.
2950 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2951 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2952 (Fformat): Avoid the prepass trying to compute sizes; it was only
2953 approximate and thus did not catch overflow reliably. Instead, walk
2954 through the format just once, formatting and computing sizes as we go,
2955 checking for integer overflow at every step, and allocating a larger
2956 buffer as needed. Keep track separately whether the format is
2957 multibyte. Keep only the most-recently calculated precision, rather
2958 than them all. Record whether each argument has been converted to
2959 string. Use EMACS_INT, not int, for byte and char and arg counts.
2960 Support field widths and precisions larger than INT_MAX. Avoid
2961 sprintf's undefined behavior with conversion specifications such as %#d
2962 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2963 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2964 formatting out-of-range floating point numbers with int
2967 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2969 * data.c: Avoid integer truncation in expressions involving floats.
2970 * data.c: Include <intprops.h>.
2971 (arith_driver): When there's an integer overflow in an expression
2972 involving floating point, convert the integers to floating point
2973 so that the resulting value does not suffer from catastrophic
2974 integer truncation. For example, on a 64-bit host (* 4
2975 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2976 Do not rely on undefined behavior after integer overflow.
2978 merge count_size_as_multibyte, parse_str_to_multibyte
2979 * character.c, character.h (count_size_as_multibyte):
2980 Rename from parse_str_to_multibyte; all uses changed.
2981 Check for integer overflow.
2982 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2983 since it's now a duplicate of the other. This is more of
2984 a character than a buffer op, so better that it's in character.c.
2985 * fns.c, print.c: Adjust to above changes.
2987 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2989 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2991 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2993 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2994 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2995 (x_clipboard_manager_save): Now static.
2996 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2998 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2999 (crypto_hash_function): Now static.
3000 Fix pointer signedness problems. Avoid unnecessary initializations.
3002 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3004 * termhooks.h (Vselection_alist): Make it terminal-local.
3006 * terminal.c (create_terminal): Initialize it.
3008 * xselect.c: Support for clipboard managers.
3009 (Vselection_alist): Move to termhooks.h as terminal-local var.
3010 (LOCAL_SELECTION): New macro.
3011 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3012 (symbol_to_x_atom): Remove gratuitous arg.
3013 (x_handle_selection_request, lisp_data_to_selection_data)
3014 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3015 (x_own_selection, x_get_local_selection, x_convert_selection):
3016 New arg, specifying work frame. Use terminal-local Vselection_alist.
3017 (some_frame_on_display): Delete unused function.
3018 (Fx_own_selection_internal, Fx_get_selection_internal)
3019 (Fx_disown_selection_internal, Fx_selection_owner_p)
3020 (Fx_selection_exists_p): New optional frame arg.
3021 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3022 (x_handle_selection_clear): Don't treat other terminals with the
3023 same keyboard specially. Use the terminal-local Vselection_alist.
3024 (x_clear_frame_selections): Use Frun_hook_with_args.
3026 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3028 * xterm.h: Add support for those atoms.
3030 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3032 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3033 (converted_selections, conversion_fail_tag): New global variables.
3034 (x_selection_request_lisp_error): Free the above.
3035 (x_get_local_selection): Remove unnecessary code.
3036 (x_reply_selection_request): Args changed; handle arbitrary array
3037 of converted selections stored in converted_selections.
3038 Separate the XChangeProperty and SelectionNotify steps.
3039 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3040 (x_convert_selection): New function.
3041 (x_handle_selection_event): Simplify.
3042 (x_get_foreign_selection): Don't ignore incoming requests while
3043 waiting for an answer; this will fail when we implement
3044 SAVE_TARGETS, and seems unnecessary anyway.
3045 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3046 (Vx_sent_selection_functions): Doc fix.
3048 2011-05-26 Leo Liu <sdl.web@gmail.com>
3050 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3052 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3054 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3056 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3057 for fringe update if it has periodic bitmap.
3058 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3059 and fringe_bitmap_periodic_p.
3061 * fringe.c (get_fringe_bitmap_data): New function.
3062 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3063 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3064 row. Mark glyph row for fringe update if periodicity changed.
3066 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3067 for fringe update unless it has periodic bitmap.
3069 2011-05-25 Kenichi Handa <handa@m17n.org>
3071 * xdisp.c (get_next_display_element): Set correct it->face_id for
3072 a static composition.
3074 2011-05-24 Leo Liu <sdl.web@gmail.com>
3077 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3079 * fns.c (crypto_hash_function, Fsha1): New function.
3080 (Fmd5): Use crypto_hash_function.
3081 (syms_of_fns): Add Ssha1.
3083 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3085 * gnutls.c: Remove unused macros.
3086 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3087 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3088 Remove macros that are defined and never used.
3089 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3091 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3093 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3094 (Fx_get_selection_internal): Minor cleanup.
3095 (Fx_own_selection_internal): Rename arguments for consistency with
3098 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3100 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3102 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3104 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3106 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3108 * dispnew.c (scrolling_window): Don't exclude the case that the
3109 last enabled row in the desired matrix touches the bottom boundary.
3111 2011-05-21 Glenn Morris <rgm@gnu.org>
3113 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3114 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3115 and add some more files.
3117 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3119 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3120 report_file_error introduced by the change from 2011-05-07.
3122 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3124 * systime.h (Time): Define only if emacs is defined.
3125 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3126 where the include path doesn't have X11/X.h by default. See
3127 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3129 2011-05-20 Kenichi Handa <handa@m17n.org>
3131 * composite.c (find_automatic_composition): Fix previous change.
3133 2011-05-20 Glenn Morris <rgm@gnu.org>
3135 * lisp.mk: New file, split from Makefile.in.
3136 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3137 (shortlisp): Remove.
3138 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3140 2011-05-19 Glenn Morris <rgm@gnu.org>
3142 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3143 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3144 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3145 (lisp): Set the order to that of loadup.el.
3146 (shortlisp): Make it a copy of $lisp.
3147 (SOME_MACHINE_LISP): Remove.
3148 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3149 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3151 2011-05-18 Kenichi Handa <handa@m17n.org>
3153 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3154 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3155 (find_automatic_composition): Mostly rewrite for efficiency.
3157 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3159 * makefile.w32-in: Update dependencies.
3161 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3163 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3164 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3166 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3168 Fix some integer overflow issues, such as string length overflow.
3170 * insdel.c (count_size_as_multibyte): Check for string overflow.
3172 * character.c (lisp_string_width): Check for string overflow.
3173 Use EMACS_INT, not int, for string indexes and lengths; in
3174 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3175 the resulting string length overflows an EMACS_INT; instead,
3176 report a string overflow if no precision given. When checking for
3177 precision exhaustion, use a check that cannot possibly have
3178 integer overflow. (Bug#8675)
3179 * character.h (lisp_string_width): Adjust to new signature.
3181 * alloc.c (string_overflow): New function.
3182 (Fmake_string): Use it. This doesn't change behavior, but saves
3183 a few bytes and will simplify future changes.
3184 * character.c (string_escape_byte8): Likewise.
3185 * lisp.h (string_overflow): New decl.
3187 Fixups, following up to the user-interface timestamp change.
3188 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3189 for UI timestamps, instead of unsigned long.
3190 * msdos.c (mouse_get_pos): Likewise.
3191 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3192 * w32gui.h (Time): Define by including "systime.h" rather than by
3193 declaring it ourselves. (Bug#8664)
3195 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3196 * image.c (clear_image_cache): Likewise.
3198 * term.c (term_mouse_position): Don't assume time_t wraparound.
3200 Be more systematic about user-interface timestamps.
3201 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3202 and sometimes 'EMACS_UINT', to represent these timestamps.
3203 This change causes it to use 'Time' uniformly, as that's what X uses.
3204 This makes the code easier to follow, and makes it easier to catch
3205 integer overflow bugs such as Bug#8664.
3206 * frame.c (Fmouse_position, Fmouse_pixel_position):
3207 Use Time, not unsigned long, for user-interface timestamps.
3208 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3209 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3210 * keyboard.h (last_event_timestamp): Likewise.
3211 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3212 * menu.h (xmenu_show): Likewise.
3213 * term.c (term_mouse_position): Likewise.
3214 * termhooks.h (struct input_event.timestamp): Likewise.
3215 (struct terminal.mouse_position_hook): Likewise.
3216 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3217 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3218 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3219 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3221 * menu.h, termhooks.h: Include "systime.h", for Time.
3223 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3224 Don't assume that the difference between two unsigned long values
3225 can fit into an integer. At this point, we know button_down_time
3226 <= event->timestamp, so the difference must be nonnegative, so
3227 there's no need to cast the result if double-click-time is
3228 nonnegative, as it should be; check that it's nonnegative, just in
3229 case. This bug is triggered when events are more than 2**31 ms
3230 apart (about 25 days). (Bug#8664)
3232 * xselect.c (last_event_timestamp): Remove duplicate decl.
3233 (x_own_selection): Remove needless cast to unsigned long.
3235 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3236 that always fit in int. Use a sentinel instead of a counter, to
3237 avoid a temp and to allay GCC's concerns about possible int overflow.
3238 * frame.h (struct frame): Use int for menu_bar_items_used
3239 instead of EMACS_INT, since it always fits in int.
3241 * menu.c (grow_menu_items): Check for int overflow.
3243 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3245 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3246 Before, the code was not consistent. These values cannot exceed
3247 2**31 - 1 so there's no need to make them unsigned.
3248 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3249 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3250 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3252 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3254 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3255 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3256 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3257 presumably because the widths might not match.
3259 * window.c (size_window): Avoid needless test at loop start.
3261 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3263 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3265 2011-05-12 Drew Adams <drew.adams@oracle.com>
3267 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3269 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3271 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3272 `width' to `bar_area_x' and `bar_area_width', respectively.
3273 (x_scroll_run): Take account of fringe background extension.
3275 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3276 Rename local vars `left' and `width' to `bar_area_x' and
3277 `bar_area_width', respectively.
3278 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3279 background extension.
3281 2011-05-10 Jim Meyering <meyering@redhat.com>
3283 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3285 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3287 * image.c (Finit_image_library): Return t for built-in image types,
3288 like pbm and xbm. (Bug#8640)
3290 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3292 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3294 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3296 * w32console.c (Fset_screen_color): Doc fix.
3297 (Fget_screen_color): New function.
3298 (syms_of_ntterm): Defsubr it.
3300 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3301 unlink the temporary file if Fcall_process didn't create it in the
3303 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3304 child process will be redirected to a file specified with `:file'.
3305 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3306 cue to call_process_cleanup not to close that handle.
3308 2011-05-07 Ben Key <bkey76@gmail.com>
3310 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3311 one of two shell specific rules, either bootstrap-temacs-CMD or
3312 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3313 to the previous implementation of the bootstrap-temacs rule.
3314 The bootstrap-temacs-CMD rule is similar to the previous
3315 implementation of the bootstrap-temacs rule except that it
3316 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3319 These changes, along with some changes to nt/configure.bat,
3320 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3321 earlier fix to add support for --cflags and --ldflags options
3322 that include quotes so that it works whether make uses cmd or
3325 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3327 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3328 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3330 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3331 a string. Handle both cases.
3332 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3333 (Fdbus_register_method): Use Qinvalid_function.
3335 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3337 * makefile.w32-in: Update dependencies.
3338 (LISP_H): Add inttypes.h and stdin.h.
3339 (PROCESS_H): Add unistd.h.
3341 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3343 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3344 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3346 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3348 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3350 * term.c (vfatal): Remove stray call to va_end.
3351 It's not needed and the C Standard doesn't allow it here anyway.
3353 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3354 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3356 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3359 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3363 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3365 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3367 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3369 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3370 * charset.c (Fdefine_charset_internal): Don't initialize
3371 charset.code_space[15]. The value was garbage, on hosts with
3372 32-bit int (Bug#8600).
3374 * lread.c (read_integer): Be more consistent with string-to-number.
3375 Use string_to_number to do the actual conversion; this avoids
3376 rounding errors and fixes some other screwups. Without this fix,
3377 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3378 (digit_to_number): Move earlier, for benefit of read_integer.
3379 Return -1 if the digit is out of range for the base, -2 if it is
3380 not a digit in any supported base. (Bug#8602)
3382 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3384 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3385 to match comment at start of function. This also removes a
3386 GCC warning about overflow in a 32+64-bit port.
3388 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3390 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3391 Reported by Stefan Monnier in
3392 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3393 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3394 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3396 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3397 (EMACS_UINTPTR): Likewise, with uintptr_t.
3399 * lisp.h: Prefer 64-bit EMACS_INT if available.
3400 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3401 on 32-bit hosts that have 64-bit int, so that they can access
3403 However, temporarily disable this change unless the temporary
3404 symbol WIDE_EMACS_INT is defined.
3406 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3408 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3409 This removes an assumption that EMACS_INT and long are the same
3410 width as pointers. The assumption is true for Emacs porting targets
3411 now, but we want to make other targets possible.
3412 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3413 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3414 In the rest of the code, change types of integers that hold casted
3415 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3416 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3417 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3418 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3419 No need to cast type when ORing.
3420 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3421 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3422 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3423 assume EMACS_INT is the same width as char *.
3424 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3425 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3426 Remove no-longer-needed casts.
3427 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3428 (xg_tool_bar_help_callback, xg_make_tool_item):
3429 Use EMACS_INTPTR to hold an integer
3430 that will be cast to void *; this can avoid a GCC warning
3431 if EMACS_INT is not the same width as void *.
3432 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3433 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3434 (current_message_1, set_message_1):
3435 Use a local to convert to proper width without a cast.
3436 * xmenu.c (dialog_selection_callback): Likewise.
3438 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3439 Also, don't assume VALBITS / RAND_BITS is less than 5,
3440 and don't rely on undefined behavior when shifting a 1 left into
3442 * lisp.h (get_random): Change signature to match.
3444 * lread.c (hash_string): Use size_t, not int, for hash computation.
3445 Normally we prefer signed values; but hashing is special, because
3446 it's better to use unsigned division on hash table sizes so that
3447 the remainder is nonnegative. Also, size_t is the natural width
3448 for hashing into memory. The previous code used 'int', which doesn't
3449 retain enough info to hash well into very large tables.
3450 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3452 * dbusbind.c: Don't possibly lose pointer info when converting.
3453 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3454 Use XPNTR rather than XHASH, so that the high-order bits of
3455 the pointer aren't lost when converting through void *.
3457 * eval.c (Fautoload): Don't double-shift a pointer.
3459 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3461 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3463 * gnutls.c (DEF_GNUTLS_FN):
3464 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3466 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3468 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3471 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3473 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3474 New version that can reserve upto 2GB of heap space.
3476 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3478 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3480 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3482 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3483 `gnutls_certificate_set_x509_key_file'.
3485 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3487 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3488 Update dependencies.
3490 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3492 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3493 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3494 Remove unused parameter `fildes'.
3495 * process.c (read_process_output, send_process): Don't pass it.
3497 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3499 Fix previous change: the library cache is defined in w32.c.
3500 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3501 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3503 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3505 Implement dynamic loading of GnuTLS on Windows.
3507 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3508 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3509 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3512 * gnutls.c (Qgnutls_dll): Define.
3513 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3514 (gnutls_*): Declare function pointers.
3515 (init_gnutls_functions): New function to initialize function pointers.
3516 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3517 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3518 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3519 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3520 (emacs_gnutls_write, emacs_gnutls_read)
3521 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3522 (Fgnutls_available_p): New function.
3523 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3524 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3525 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3527 * image.c: Include w32.h.
3528 (Vimage_type_cache): Delete.
3529 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3530 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3531 (w32_delayed_load): Move to w32.c.
3533 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3535 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3536 (w32_delayed_load): Move from image.c. When loading a library, record
3537 its filename in the :loaded-from property of the library id.
3538 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3539 Initialize and staticpro them.
3540 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3542 * process.c: Include lisp.h before w32.h, not after.
3543 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3544 instead of gnutls_record_check_pending.
3546 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3548 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3550 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3551 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3554 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3556 * xterm.c (x_set_frame_alpha): Do not set property on anything
3557 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3559 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3561 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3563 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3565 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3566 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3567 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3568 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3569 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3570 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3571 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3572 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3573 (Qgnutls_bootprop_callbacks_verify): Make static.
3575 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3577 * callproc.c: Indentation fixup.
3579 * sysdep.c (wait_for_termination_1): Make static.
3580 (wait_for_termination, interruptible_wait_for_termination):
3581 Move after wait_for_termination_1.
3583 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3585 * sysdep.c (interruptible_wait_for_termination): New function
3586 which is like wait_for_termination, but allows keyboard
3589 * callproc.c (Fcall_process): Add (:file "file") as an option for
3591 (Fcall_process_region): Ditto.
3593 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3595 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3596 rather than `XVECTOR (FOO)->size'.
3598 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3599 inttypes.h, as a gnulib replacement is used if it not available in
3602 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3604 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3605 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3606 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3608 * coding.c (coding_alloc_by_realloc): Error out if destination
3609 will grow beyond MOST_POSITIVE_FIXNUM.
3610 (decode_coding_emacs_mule): Abort if there isn't enough place in
3611 charbuf for the composition carryover bytes. Reserve an extra
3612 space for up to 2 characters produced in a loop.
3613 (decode_coding_iso_2022): Abort if there isn't enough place in
3614 charbuf for the composition carryover bytes.
3616 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3618 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3619 aborting when %lld or %lll format is passed.
3620 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3621 %llo or %llx format is passed. (Bug#8545)
3623 * window.c (window_scroll_line_based): Use a marker instead of
3624 simple variables to record original value of point. (Bug#7952)
3626 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3627 produced by %s or %c overflows available buffer space. (Bug#8545)
3629 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3631 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3632 (SIZE_MAX): Move defn after all includes, as they might #define it.
3634 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3636 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3638 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3640 * keyboard.c (Qdelayed_warnings_hook): Define.
3641 (command_loop_1): Run `delayed-warnings-hook'
3642 if Vdelayed_warnings_list is non-nil.
3643 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3644 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3646 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3648 * doprnt.c (doprnt): Don't return value smaller than the buffer
3649 size if the message was truncated. (Bug#8545).
3651 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3653 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3654 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3656 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3658 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3660 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3662 * makefile.w32-in: Update dependencies.
3664 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3666 Improve `doprnt' and its usage. (Bug#8545)
3667 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3668 `format_end'. Remove support for %l as a conversion specifier.
3669 Don't use xrealloc. Improve diagnostics when the %l size modifier
3670 is used. Update the commentary.
3672 * eval.c (verror): Simplify calculation of size_t.
3674 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3677 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3679 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3682 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3684 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3685 This makes this file independent of the recent pseudovector change.
3687 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3689 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3691 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3692 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3693 Remove unused local.
3694 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3696 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3697 GCC 4.6.0 optimizes based on type-based alias analysis.
3698 For example, if b is of type struct buffer * and v of type struct
3699 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3700 != &v->size, and therefore "v->size = 1; b->size = 2; return
3701 v->size;" must therefore return 1. This assumption is incorrect
3702 for Emacs, since it type-puns struct Lisp_Vector * with many other
3703 types. To fix this problem, this patch adds a new type struct
3704 vectorlike_header that documents the constraints on layout of vectors
3705 and pseudovectors, and helps optimizing compilers not get fooled
3706 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3707 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3708 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3710 (XSETPVECTYPE): Rewrite in terms of new macro.
3711 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3712 This is a bit clearer, and further avoids the possibility of
3713 undesirable aliasing.
3714 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3715 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3716 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3717 since Lisp_Subr is a special case (no "next" field).
3718 (ASIZE): Now uses header.size rather than size.
3719 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3720 to avoid the hassle of writing XVECTOR (foo)->header.size.
3721 (struct vectorlike_header): New type.
3722 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3723 object, to help avoid aliasing.
3724 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3725 (SUBRP): Likewise, since Lisp_Subr is a special case.
3726 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3727 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3728 (struct Lisp_Hash_Table): Combine first two members into a single
3729 struct vectorlike_header member. All uses of "size" and "next" members
3730 changed to be "header.size" and "header.next".
3731 * buffer.h (struct buffer): Likewise.
3732 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3733 * frame.h (struct frame): Likewise.
3734 * process.h (struct Lisp_Process): Likewise.
3735 * termhooks.h (struct terminal): Likewise.
3736 * window.c (struct save_window_data, struct saved_window): Likewise.
3737 * window.h (struct window): Likewise.
3738 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3739 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3740 * buffer.c (init_buffer_once): Likewise.
3741 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3743 * process.c (Fformat_network_address): Use local var for size,
3746 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3748 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3749 * data.c (atof): Remove decl; no longer used or needed.
3750 (digit_to_number): Move to lread.c.
3751 (Fstring_to_number): Use new string_to_number function, to be
3752 consistent with how the Lisp reader treats infinities and NaNs.
3753 Do not assume that floating-point numbers represent EMACS_INT
3754 without losing information; this is not true on most 64-bit hosts.
3755 Avoid double-rounding errors, by insisting on integers when
3756 parsing non-base-10 numbers, as the documentation specifies.
3757 * lisp.h (string_to_number): New decl, replacing ...
3758 (isfloat_string): Remove.
3759 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3760 (read1): Do not accept +. and -. as integers; this
3761 appears to have been a coding error. Similarly, do not accept
3762 strings like +-1e0 as floating point numbers. Do not report
3763 overflow for integer overflows unless the base is not 10 which
3764 means we have no simple and reliable way to continue.
3765 Break out the floating-point parsing into a new
3766 function string_to_number, so that Fstring_to_number parses
3767 floating point numbers consistently with the Lisp reader.
3768 (digit_to_number): Move here from data.c. Make it static inline.
3769 (E_CHAR, EXP_INT): Remove, replacing with ...
3770 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3771 (string_to_number): New function, replacing isfloat_string.
3772 This function checks for valid syntax and produces the resulting
3773 Lisp float number too. Rework it so that string-to-number
3774 no longer mishandles examples like "1.0e+". Use strtoumax,
3775 so that overflow for non-base-10 numbers is reported only when
3776 there's no portable and simple way to convert to floating point.
3778 * textprop.c (set_text_properties_1): Rewrite for clarity,
3779 and to avoid GCC warning about integer overflow.
3781 * intervals.h (struct interval): Use EMACS_INT for members
3782 where EMACS_UINT might cause problems. See
3783 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3784 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3785 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3787 (offset_intervals): Tell GCC not to worry about length overflow
3788 when negating a negative length.
3790 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3791 (overrun_check_free): Likewise.
3793 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3794 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3797 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3798 (gnutls_make_error): Rename local to avoid shadowing.
3799 (gnutls_emacs_global_deinit): ifdef out; not used.
3800 (Fgnutls_boot): Use const for pointer to readonly storage.
3801 Comment out unused local. Fix pointer signedness problems.
3803 * lread.c (openp): Don't stuff size_t into an 'int'.
3804 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3805 about possible signed overflow.
3807 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3808 (GDK_KEY_g): Don't define if already defined.
3809 (xg_prepare_tooltip): Avoid pointer signedness problem.
3810 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3812 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3813 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3815 * xfns.c (Fx_window_property): Simplify a bit,
3816 to make a bit faster and to avoid GCC 4.6.0 warning.
3817 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3819 * fns.c (internal_equal): Don't assume size_t fits in int.
3821 * alloc.c (compact_small_strings): Tighten assertion a little.
3823 Replace pEd with more-general pI, and fix some printf arg casts.
3824 * lisp.h (pI): New macro, generalizing old pEd macro to other
3825 conversion specifiers. For example, use "...%"pI"d..." rather
3826 than "...%"pEd"...".
3827 (pEd): Remove. All uses replaced with similar uses of pI.
3828 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3829 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3830 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3831 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3832 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3833 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3834 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3836 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3837 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3838 * print.c (safe_debug_print, print_object): Likewise.
3839 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3841 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3842 avoiding the 0 flag, which is not portable.
3843 * process.c (Fmake_network_process): Use pI to avoid cast.
3844 * region-cache.c (pp_cache): Likewise.
3845 * xdisp.c (decode_mode_spec): Likewise.
3846 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3847 behavior on 64-bit hosts with printf arg.
3848 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3849 (x_stop_queuing_selection_requests): Likewise.
3850 (x_get_window_property): Don't truncate byte count to an 'int'
3853 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3854 here, since it parses constructs like leading '-' and spaces,
3855 which are not wanted; and it overflows with large numbers.
3856 Instead, simply match F[0-9]+, which is what is wanted anyway.
3858 * alloc.c: Remove unportable assumptions about struct layout.
3859 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3860 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3861 (allocate_vectorlike, make_pure_vector): Use the new macros,
3862 plus offsetof, to remove unportable assumptions about struct layout.
3863 These assumptions hold on all porting targets that I know of, but
3864 they are not guaranteed, they're easy to remove, and removing them
3865 makes further changes easier.
3867 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3868 This doesn't fix a bug but makes the code clearer.
3869 (string_overrun_cookie): Now const. Use initializers that
3870 don't formally overflow signed char, to avoid warnings.
3871 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3872 can cause Emacs to crash when string overrun checking is enabled.
3873 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3874 multiple of sizeof (EMACS_INT); it need not be, if
3875 alignof(EMACS_INT) < sizeof (EMACS_INT).
3876 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3878 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3880 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3882 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3884 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3885 supposed to be handshaking. (Bug#8556)
3886 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3888 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3890 * lisp.h (Qdebug): List symbol.
3891 * eval.c (Qdebug): Restore global linkage.
3892 * keyboard.c (debug-on-event): New variable.
3893 (handle_user_signal): Break into debugger when debug-on-event
3894 matches the current signal symbol.
3896 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3898 * alloc.c (check_sblock, check_string_bytes)
3899 (check_string_free_list): Convert to standard C.
3901 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3903 * w32.c (emacs_gnutls_push): Fix typo.
3905 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3907 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3908 "cast to pointer from integer of different size".
3910 Improve doprnt and its use in verror. (Bug#8545)
3911 * doprnt.c (doprnt): Document the set of format control sequences
3912 supported by the function. Use SAFE_ALLOCA instead of always
3915 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3916 is one byte too soon. Don't use xrealloc; instead xfree and
3919 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3921 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3924 * gnutls.c: Renamed global_initialized to
3925 gnutls_global_initialized. Added internals for the
3926 :verify-hostname-error, :verify-error, and :verify-flags
3927 parameters of `gnutls-boot' and documented those parameters in the
3928 docstring. Start callback support.
3929 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3930 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3931 on error. Return error code.
3932 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3933 (emacs_gnutls_read): Likewise.
3934 (Fgnutls_boot): Return handshake error code.
3935 (emacs_gnutls_handle_error): New function.
3936 (wsaerror_to_errno): Likewise.
3938 * w32.h (emacs_gnutls_pull): Add prototype.
3939 (emacs_gnutls_push): Likewise.
3941 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3942 (emacs_gnutls_push): Likewise.
3944 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3946 * process.c (wait_reading_process_output): Check if GnuTLS
3947 buffered some data internally if no FDs are set for TLS
3950 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3951 (LIBS): Link to USER_LIBS.
3952 ($(BLD)/gnutls.$(0)): New target.
3954 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3956 * xdisp.c (handle_single_display_spec): Rename the
3957 display_replaced_before_p argument into display_replaced_p, to
3958 make it consistent with the commentary. Fix typos in the
3961 * textprop.c (syms_of_textprop): Remove dead code.
3962 (copy_text_properties): Delete obsolete commentary about an
3963 interface that was deleted long ago. Fix typos in the description
3966 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3967 to changes in oldXMenu/XMenu.h from 2011-04-16.
3968 <menu_help_message, prev_menu_help_message>: Constify.
3969 (IT_menu_make_room): menu->help_text is now `const char **';
3972 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3973 to changes in oldXMenu/XMenu.h from 2011-04-16.
3974 (struct XMenu): Declare `help_text' `const char **'.
3976 * xfaces.c <Qunspecified>: Make extern again.
3978 * syntax.c: Include sys/types.h before including regex.h, as
3981 * doc.c (get_doc_string): Improve the format passed to `error'.
3983 * doprnt.c (doprnt): Improve commentary.
3985 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3987 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3990 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3991 changes in globals.h immediately force recompilation.
3992 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3993 $(CURDIR)/s/ms-w32.h.
3994 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3996 * character.c (Fchar_direction): Function deleted.
3997 (syms_of_character): Don't defsubr it.
3998 <char-direction-table>: Deleted.
4000 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4002 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4003 * doprnt.c: Include limits.h.
4004 (SIZE_MAX): New macro.
4005 (doprnt): Return a size_t value. 2nd arg is now size_t.
4006 Many local variables are now size_t instead of int or unsigned.
4007 Improve overflow protection. Support `l' modifier for integer
4008 conversions. Support %l conversion. Don't assume an EMACS_INT
4009 argument for integer conversions and for %c.
4011 * lisp.h (doprnt): Restore prototype.
4013 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4016 * Makefile.in (base_obj): Add back doprnt.o.
4018 * deps.mk (doprnt.o): Add back prerequisites.
4019 (callint.o): Depend on character.h.
4021 * eval.c (internal_lisp_condition_case): Include the handler
4022 representation in the error message.
4023 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4024 when breaking from the loop.
4026 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4028 * callint.c (Fcall_interactively): When displaying error message
4029 about invalid control letter, pass the character's codepoint, not
4030 a pointer to its multibyte form. Improve display of the character
4031 in octal and display also its hex code.
4033 * character.c (char_string): Use %x to display the (unsigned)
4034 codepoint of an invalid character, to avoid displaying a bogus
4037 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4038 `error', not SYMBOL_NAME itself.
4040 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4041 character arguments to `error'.
4043 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4044 to `error' in error message about FINAL_CHAR argument. Make sure
4045 FINAL_CHAR is a character, and use %c when it is passed as
4046 argument to `error'.
4048 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4050 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4052 * w32.c: Include <time.h>.
4053 (sys_localtime): New function.
4055 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4057 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4059 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4061 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4063 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4066 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4068 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4069 gl_state.e_property when gl_state.object is Qt.
4071 * insdel.c (make_gap_larger): Remove limitation of buffer size
4074 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4076 * xdisp.c (lookup_glyphless_char_display)
4077 (produce_glyphless_glyph): Handle cons cell entry in
4078 glyphless-char-display.
4079 (Vglyphless_char_display): Document it.
4081 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4082 glyphless-char-display.
4084 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4086 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4088 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4090 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4091 definition for no-X builds.
4093 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4095 Static checks with GCC 4.6.0 and non-default toolkits.
4097 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4099 * process.c (keyboard_bit_set): Define only if SIGIO.
4100 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4101 (send_process): Repair possible setjmp clobbering.
4103 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4105 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4107 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4109 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4110 Define only if needed.
4112 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4113 by pacifying GCC about it. Maybe it's time to retire it?
4114 * xfaces.c (USG, __TIMEVAL__): Likewise.
4116 * dispextern.h (struct redisplay_interface): Rename param
4118 * termhooks.h (struct terminal): Likewise.
4119 * xterm.c (xembed_send_message): Likewise.
4121 * insdel.c (make_gap_smaller): Define only if
4122 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4124 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4127 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4128 so that we aren't warned about unused symbols.
4130 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4132 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4134 * xfns.c (x_real_positions): Mark locals as initialized.
4136 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4138 * xterm.c: Fix problems found by static analysis with other toolkits.
4139 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4140 (x_dispatch_event): Declare static if USE_GTK, and
4141 define if USE_GTK || USE_X_TOOLKIT.
4142 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4143 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4144 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4145 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4147 * xmenu.c (menu_help_callback): Pointer type fixes.
4148 Use const pointers when pointing at readonly data. Avoid pointer
4150 (FALSE): Remove unused macro.
4151 (update_frame_menubar): Remove unused decl.
4153 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4155 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4156 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4157 (single_menu_item): Rename local to avoid shadowing.
4159 * keyboard.c (make_lispy_event): Remove unused local var.
4161 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4162 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4164 * bitmaps: Change bitmaps from unsigned char back to the X11
4165 compatible char. Avoid the old compiler warnings about
4166 out-of-range initializers by using, for example, '\xab' rather
4169 * xgselect.c (xgselect_initialize): Check vs interface
4170 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4172 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4174 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4175 to read-only memory.
4177 * fns.c (vector): Remove; this old hack is no longer needed.
4179 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4181 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4183 * xrdb.c (x_load_resources): Omit unused local.
4185 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4186 (x_window): Rename locals to avoid shadowing.
4187 (USG): Use the kludged USG macro, to pacify gcc.
4189 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4190 (x_term_init): Remove local to avoid shadowing.
4192 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4194 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4195 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4197 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4199 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4201 Fix regex.c, syntax.c and friends for buffers > 2GB.
4202 * syntax.h (struct gl_state_s): Declare character position members
4205 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4207 * textprop.c (verify_interval_modification, interval_of):
4208 Declare arguments EMACS_INT.
4210 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4213 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4215 * indent.c (Fvertical_motion): Local variable it_start is now
4218 * regex.c (re_match, re_match_2, re_match_2_internal)
4219 (bcmp_translate, regcomp, regexec, print_double_string)
4220 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4221 (re_compile_pattern, re_exec): Declare arguments and local
4222 variables `size_t' and `ssize_t' and return values `regoff_t', as
4224 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4225 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4226 <compile_stack_type>: `size' and `avail' are now `size_t'.
4228 * regex.h <regoff_t>: Use ssize_t, not int.
4229 (re_search, re_search_2, re_match, re_match_2): Arguments that
4230 specify buffer/string position and length are now ssize_t and
4231 size_t. Return type is regoff_t.
4233 2011-04-16 Ben Key <bkey76@gmail.com>
4235 * nsfont.m: Fixed bugs in ns_get_family and
4236 ns_descriptor_to_entity that were caused by using free to
4237 deallocate memory blocks that were allocated by xmalloc (via
4238 xstrdup). This caused Emacs to crash when compiled with
4239 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4240 --enable-checking=xmallocoverrun). xfree is now used to
4241 deallocate these memory blocks.
4243 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4245 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4247 emacs_write: Accept and return EMACS_INT for sizes.
4248 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4250 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4251 Accept and return EMACS_INT.
4252 (emacs_gnutls_write): Return the number of bytes written on
4254 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4255 (emacs_read, emacs_write): Remove check for negative size, as the
4256 Emacs source code has been audited now.
4257 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4258 (emacs_read, emacs_write): Use it.
4259 * process.c (send_process): Adjust to the new signatures of
4260 emacs_write and emacs_gnutls_write. Do not attempt to store
4261 a byte offset into an 'int'; it might overflow.
4262 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4264 * sound.c: Don't assume sizes fit in 'int'.
4265 (struct sound_device.period_size, alsa_period_size):
4266 Return EMACS_INT, not int.
4267 (struct sound_device.write, vox_write, alsa_write):
4268 Accept EMACS_INT, not int.
4269 (wav_play, au_play): Use EMACS_INT to store sizes and to
4270 record read return values.
4272 2011-04-15 Ben Key <bkey76@gmail.com>
4274 * keyboard.c (Qundefined): Don't declare static since it is used
4276 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4277 static since they are used in nsfont.m.
4279 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4281 * process.c (Qprocessp): Don't declare static.
4282 * lisp.h (Qprocessp): Declare again.
4284 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4286 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4288 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4290 Improve C-level modularity by making more things 'static'.
4292 Don't publish debugger-only interfaces to other modules.
4293 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4294 (verify_bytepos, count_markers): Move decls to the only modules
4296 * region-cache.h (pp_cache): Likewise.
4297 * window.h (check_all_windows): Likewise.
4298 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4300 * sysdep.c (croak): Now static, if
4301 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4302 * syssignal.h (croak): Declare only if not static.
4304 * alloc.c (refill_memory_reserve): Now static if
4305 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4306 * lisp.h (refill_memory_reserve): Declare only if not static.
4308 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4309 Define only if USE_LUCID.
4311 * xrdb.c (x_customization_string, x_rm_string): Now static.
4313 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4314 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4316 * xdisp.c (draw_row_with_mouse_face): Now static.
4317 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4319 * window.h (check_all_windows): Mark externally visible.
4321 * window.c (window_deletion_count): Now static.
4323 * undo.c: Make symbols static if they're not exported.
4324 (last_undo_buffer, last_boundary_position, pending_boundary):
4327 * textprop.c (interval_insert_behind_hooks): Now static.
4328 (interval_insert_in_front_hooks): Likewise.
4330 * term.c: Make symbols static if they're not exported.
4331 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4332 (max_frame_lines, tty_set_terminal_modes):
4333 (tty_reset_terminal_modes, tty_turn_off_highlight):
4334 (get_tty_terminal): Now static.
4335 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4336 * termhooks.h (term_mouse_moveto): Do not declare if
4338 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4339 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4341 * sysdep.c: Make symbols static if they're not exported.
4342 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4344 (sigprocmask_set, full_mask): Remove; unused.
4345 (wait_debugging): Mark as visible.
4346 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4347 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4349 * syntax.c (syntax_temp): Define only if !__GNUC__.
4351 * sound.c (current_sound_device, current_sound): Now static.
4353 * search.c (searchbufs, searchbuf_head): Now static.
4355 * scroll.c (scroll_cost): Remove; unused.
4356 * dispextern.h (scroll_cost): Remove decl.
4358 * region-cache.h (pp_cache): Mark as externally visible.
4360 * process.c: Make symbols static if they're not exported.
4361 (process_tick, update_tick, create_process, chan_process):
4362 (Vprocess_alist, proc_buffered_char, datagram_access):
4363 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4364 (deactivate_process): Mark defn as static, as well as decl.
4365 * lisp.h (create_process): Remove decl.
4366 * process.h (chan_process, Vprocess_alist): Remove decls.
4368 * print.c: Make symbols static if they're not exported.
4369 (print_depth, new_backquote_output, being_printed, print_buffer):
4370 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4371 (print_interval, print_number_index, initial_stderr_stream):
4373 * lisp.h (Fprinc): Remove decl.
4374 (debug_output_compilation_hack): Mark as externally visible.
4376 * sysdep.c (croak): Move decl from here to syssignal.h.
4377 * syssignal.h (croak): Put it here, so the API can be checked when
4378 'croak' is called from dissociate_if_controlling_tty.
4380 * minibuf.c: Make symbols static if they're not exported.
4381 (minibuf_save_list, choose_minibuf_frame): Now static.
4382 * lisp.h (choose_minibuf_frame): Remove decl.
4384 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4386 * lread.c: Make symbols static if they're not exported.
4387 (read_objects, initial_obarray, oblookup_last_bucket_number):
4389 (make_symbol): Remove; unused.
4390 * lisp.h (initial_obarray, make_symbol): Remove decls.
4392 * keyboard.c: Make symbols static if they're not exported.
4393 (single_kboard, recent_keys_index, total_keys, recent_keys):
4394 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4395 (this_single_command_key_start, echoing, last_auto_save):
4396 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4397 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4398 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4399 (Vlispy_mouse_stem, double_click_count):
4401 (force_auto_save_soon): Define only if SIGDANGER.
4402 (ignore_mouse_drag_p): Now static if
4403 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4404 (print_help): Remove; unused.
4405 (stop_character, last_timer_event): Mark as externally visible.
4406 * keyboard.h (ignore_mouse_drag_p): Declare only if
4407 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4408 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4409 * lisp.h (echoing): Remove decl.
4410 (force_auto_save_soon): Declare only if SIGDANGER.
4411 * xdisp.c (redisplay_window): Simplify code, to make it more
4412 obvious that ignore_mouse_drag_p is not accessed if !defined
4413 USE_GTK && !defined HAVE_NS.
4415 * intervals.c: Make symbols static if they're not exported.
4416 (merge_properties_sticky, merge_interval_right, delete_interval):
4418 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4420 * insdel.c: Make symbols static if they're not exported.
4421 However, leave prepare_to_modify_buffer alone. It's never
4422 called from outside this function, but that appears to be a bug.
4423 (combine_after_change_list, combine_after_change_buffer):
4424 (adjust_after_replace, signal_before_change): Now static.
4425 (adjust_after_replace_noundo): Remove; unused.
4426 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4427 (signal_before_change): Remove decls.
4429 * indent.c (val_compute_motion, val_vmotion): Now static.
4431 * image.c: Make symbols static if they're not exported.
4432 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4434 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4435 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4437 * fringe.c (standard_bitmaps): Now static.
4438 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4440 * frame.c: Make symbols static if they're not exported.
4441 (x_report_frame_params, make_terminal_frame): Now static.
4442 (get_frame_param): Now static, unless HAVE_NS.
4443 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4444 (x_get_resource_string): Remove; not used.
4445 * frame.h (make_terminal_frame, x_report_frame_params):
4446 (x_get_resource_string); Remove decls.
4447 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4448 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4450 * font.c, fontset.c: Make symbols static if they're not exported.
4451 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4452 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4453 * font.c (font_close_object): Now static.
4454 * font.h (font_close_object): Remove.
4455 * fontset.c (FONTSET_OBJLIST): Remove.
4456 (free_realized_fontset) #if-0 the body, which does nothing.
4457 (face_suitable_for_char_p): #if-0, as it's never called.
4458 * fontset.h (face_suitable_for_char_p): Remove decl.
4459 * xfaces.c (face_at_string_position):
4460 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4461 since 0 is always ASCII.
4463 * fns.c (weak_hash_tables): Now static.
4465 * fileio.c: Make symbols static if they're not exported.
4466 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4467 (Vwrite_region_annotation_buffers): Now static.
4469 * eval.c: Make symbols static if they're not exported.
4470 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4471 * lisp.h (backtrace_list): Remove decl.
4473 * emacs.c: Make symbols static if they're not exported.
4474 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4475 (fatal_error_code, fatal_error_signal_hook, standard_args):
4477 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4478 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4479 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4480 * lisp.h (fatal_error_signal_hook): Remove decl.
4481 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4483 * editfns.c: Move a (normally-unused) function to its only use.
4484 * editfns.c, lisp.h (get_operating_system_release): Remove.
4485 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4486 worth the hassle of breaking this out.
4488 * xterm.c: Make symbols static if they're not exported.
4489 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4490 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4491 (x_destroy_window, x_delete_display):
4493 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4494 (x_mouse_leave): Remove; unused.
4495 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4496 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4497 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4499 (x_mouse_leave): Declare only if WINDOWSNT.
4500 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4501 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4504 * ftxfont.c: Make symbols static if they're not exported.
4505 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4507 * font.h (ftxfont_driver): Likewise.
4509 * xfns.c: Make symbols static if they're not exported.
4510 (x_last_font_name, x_display_info_for_name):
4511 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4512 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4513 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4514 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4515 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4516 (last_show_tip_args): Now static.
4517 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4518 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4519 (x_screen_planes): Remove; unused.
4520 * dispextern.h (x_screen_planes): Remove decl.
4522 * dispnew.c: Make symbols static if they're not exported.
4523 * dispextern.h (redraw_garbaged_frames, scrolling):
4524 (increment_row_positions): Remove.
4525 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4526 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4528 (redraw_garbaged_frames): Remove; unused.
4530 * xfaces.c: Make symbols static if they're not exported.
4531 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4533 * xterm.h (defined_color): Remove decls.
4534 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4535 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4536 (menu_face_changed_default, defined_color, free_realized_face):
4537 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4538 (ascii_face_of_lisp_face): Remove; unused.
4540 * xdisp.c: Make symbols static if they're not exported.
4541 * dispextern.h (scratch_glyph_row, window_box_edges):
4542 (glyph_to_pixel_coords, set_cursor_from_row):
4543 (get_next_display_element, set_iterator_to_next):
4544 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4545 (show_mouse_face): Remove decls
4546 * frame.h (message_buf_print): Likewise.
4547 * lisp.h (pop_message, set_message, check_point_in_composition):
4549 * xterm.h (set_vertical_scroll_bar): Likewise.
4550 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4551 (message_buf_print, scratch_glyph_row, displayed_buffer):
4552 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4553 (get_next_display_element, show_mouse_face, window_box_edges):
4554 (frame_to_window_pixel_xy, check_point_in_composition):
4555 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4556 (glyph_to_pixel_coords): Remove; unused.
4558 * dired.c (file_name_completion): Now static.
4560 * dbusbind.c (xd_in_read_queued_messages): Now static.
4562 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4563 * data.c (circular_list_error): Remove.
4565 * commands.h (last_point_position, last_point_position_buffer):
4566 (last_point_position_window): Remove decls.
4567 * keyboard.c: Make these variables static.
4569 * coding.h (coding, code_convert_region, encode_coding_gap):
4571 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4572 (iso_code_class, detect_coding, code_convert_region): Now static.
4573 (encode_coding_gap): Remove; unused.
4575 * chartab.c (chartab_chars, chartab_bits): Now static.
4577 * charset.h (charset_iso_8859_1): Remove decl.
4578 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4581 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4582 * ccl.c (Vccl_program_table): Now static.
4583 (check_ccl_update): Remove; unused.
4585 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4586 * category.h: ... from here.
4587 * category.c (check_category_table, set_category_set): Now static.
4589 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4590 * lisp.h: Remove these decls.
4592 * buffer.c (buffer_count): Remove unused var.
4594 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4595 so that it's not optimized away.
4596 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4597 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4598 exported only to the debugger.
4600 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4601 * atimer.h (run_all_atimers): Remove; not exported.
4603 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4604 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4605 was inaccessible from Lisp.
4606 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4607 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4609 alloc.c: Import and export fewer symbols, and remove unused items.
4610 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4612 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4613 it's not optimized away by whole-program optimization.
4614 (message_enable_multibyte, free_misc): Remove.
4615 (catchlist, handlerlist, mark_backtrace):
4616 Declare only if BYTE_MARK_STACK.
4617 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4618 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4619 (message_enable_multibyte): Remove decl.
4620 (free_misc, interval_free_list, float_block, float_block_index):
4621 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4622 (cons_free_list, last_marked_index):
4624 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4625 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4626 (mark_backtrace): Define only if BYTE_MARK_STACK.
4627 * xdisp.c (message_enable_multibyte): Now static.
4629 Declare Lisp_Object Q* variables to be 'static' if not exported.
4630 This makes it easier for human readers (and static analyzers)
4631 to see whether these variables are used from other modules.
4632 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4633 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4634 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4635 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4636 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4637 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4638 * xmenu.c, xselect.c:
4639 Declare Q* vars static if they are not used in other modules.
4640 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4641 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4642 Remove decls of unexported vars.
4643 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4645 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4647 Make Emacs functions such as Fatom 'static' by default.
4648 This makes it easier for human readers (and static analyzers)
4649 to see whether these functions can be called from other modules.
4650 DEFUN now defines a static function. To make the function external
4651 so that it can be used in other C modules, use the new macro DEFUE.
4652 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4653 (Finit_image_library):
4654 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4655 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4656 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4657 Remove decls, since these functions are now static.
4658 (Funintern, Fget_internal_run_time): New decls, since these functions
4659 were already external.
4661 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4662 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4663 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4664 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4665 * keyboard.c, keymap.c, lread.c:
4666 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4667 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4668 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4669 Mark functions with DEFUE instead of DEFUN,
4670 if they are used in other modules.
4671 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4672 decls for now-static functions.
4673 * buffer.h (Fdelete_overlay): Remove decl.
4674 * callproc.c (Fgetenv_internal): Mark as internal.
4675 * composite.c (Fremove_list_of_text_properties): Remove decl.
4676 (Fcomposition_get_gstring): New forward static decl.
4677 * composite.h (Fcomposite_get_gstring): Remove decl.
4678 * dired.c (Ffile_attributes): New forward static decl.
4679 * doc.c (Fdocumntation_property): New forward static decl.
4680 * eval.c (Ffetch_bytecode): New forward static decl.
4681 (Funintern): Remove extern decl; now in .h file where it belongs.
4682 * fileio.c (Fmake_symbolic_link): New forward static decl.
4683 * image.c (Finit_image_library): New forward static decl.
4684 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4685 * intervals.h (Fprevious_property_change):
4686 (Fremove_list_of_text_properties): Remove decls.
4687 * keyboard.c (Fthis_command_keys): Remove decl.
4688 (Fcommand_execute): New forward static decl.
4689 * keymap.c (Flookup_key): New forward static decl.
4690 (Fcopy_keymap): Now static.
4691 * keymap.h (Flookup_key): Remove decl.
4692 * process.c (Fget_process): New forward static decl.
4693 (Fprocess_datagram_address): Mark as internal.
4694 * syntax.c (Fsyntax_table_p): New forward static decl.
4695 (skip_chars): Remove duplicate decl.
4696 * textprop.c (Fprevious_property_change): New forward static decl.
4697 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4699 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4700 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4702 * editfns.c (Fformat): Remove unreachable code.
4704 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4706 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4709 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4711 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4712 when at ZV. (Bug#8487)
4714 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4716 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4718 * keyboard.c (parse_tool_bar_item): Likewise.
4719 * sound.c (sound_cleanup, alsa_close): Likewise.
4720 * termcap.c (tgetent): Likewise.
4721 * xfns.c (x_default_font_parameter): Likewise.
4722 * xsettings.c (read_and_apply_settings): Likewise.
4724 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4725 (overrun_check_free): Protoize.
4727 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4729 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4730 since callers should never pass a negative size.
4731 Change the signature to match that of plain 'read' and 'write'; see
4732 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4733 * lisp.h: Update prototypes of emacs_write and emacs_read.
4735 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4737 * xdisp.c (redisplay_window): Don't try to determine the character
4738 position of the scroll margin if the window start point w->startp
4739 is outside the buffer's accessible region. (Bug#8468)
4741 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4743 Fix write-region and its subroutines for buffers > 2GB.
4744 * fileio.c (a_write, e_write): Modify declaration of arguments and
4745 local variables to support buffers larger than 2GB.
4746 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4748 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4749 argument, local variables, and return value.
4751 * lisp.h: Update prototypes of emacs_write and emacs_read.
4753 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4755 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4757 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4759 Fix more problems found by GCC 4.6.0's static checks.
4761 * xdisp.c (vmessage): Use a better test for character truncation.
4763 * charset.c (load_charset_map): <, not <=, for optimization,
4764 and to avoid potential problems with integer overflow.
4765 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4766 * casetab.c (set_identity, shuffle): Likewise.
4767 * editfns.c (Fformat): Likewise.
4768 * syntax.c (skip_chars): Likewise.
4770 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4771 This also lets GCC 4.6.0 generate slightly better loop code.
4773 * callint.c (Fcall_interactively): <, not <=, for optimization.
4774 (Fcall_interactively): Count the number of arguments produced,
4775 not the number of arguments given. This is simpler and lets GCC
4776 4.6.0 generate slightly better code.
4778 * ftfont.c: Distingish more carefully between FcChar8 and char.
4779 The previous code passed unsigned char * to a functions like
4780 strlen and xstrcasecmp that expect char *, which does not
4781 conform to the C standard.
4782 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4783 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4784 char * when the C standard requires it.
4786 * keyboard.c (read_char): Remove unused var.
4788 * eval.c: Port to Windows vsnprintf (Bug#8435).
4790 (SIZE_MAX): Define if the headers do not.
4791 (verror): Do not give up if vsnprintf returns a negative count.
4792 Instead, grow the buffer. This ports to Windows vsnprintf, which
4793 does not conform to C99. Problem reported by Eli Zaretskii.
4794 Also, simplify the allocation scheme, by avoiding the need for
4795 calling realloc, and removing the ALLOCATED variable.
4797 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4799 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4800 But keep the doprint source code for now, as we might revamp it
4801 and use it again (Bug#8435).
4802 * lisp.h (doprnt): Remove.
4803 * Makefile.in (base_obj): Remove doprnt.o.
4804 * deps.mk (doprnt.o): Remove.
4806 error: Print 32- and 64-bit integers portably (Bug#8435).
4807 Without this change, on typical 64-bit hosts error ("...%d...", N)
4808 was used to print both 32- and 64-bit integers N, which relied on
4810 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4812 * lisp.h (error, verror): Mark as printf-like functions.
4813 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4814 Report overflow in size calculations when allocating printf buffer.
4815 Do not truncate output string at its first null byte.
4816 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4817 Truncate the output at a character boundary, since vsnprintf does not
4819 * charset.c (check_iso_charset_parameter): Convert internal
4820 character to string before calling 'error', since %c now has the
4822 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4823 overflow when computing char to be passed to 'error'. Do not
4824 pass Lisp_Object to 'error'; pass the integer instead.
4825 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4826 formatted with plain %d.
4828 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4830 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4832 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4834 * xterm.c (x_catch_errors): Remove duplicate declaration.
4836 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4838 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4840 2011-04-10 Jim Meyering <meyering@redhat.com>
4842 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4843 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4844 return ssize_t not "int", and use size_t as the buffer length.
4845 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4846 * gnutls.h: Update declarations.
4847 * process.c (read_process_output): Use ssize_t, to match.
4848 (send_process): Likewise.
4850 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4852 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4854 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4856 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4857 Use unsigned char, to match FcChar8 type definition.
4859 * xterm.c (handle_one_xevent):
4860 * xmenu.c (create_and_show_popup_menu):
4861 * xselect.c (x_decline_selection_request)
4862 (x_reply_selection_request): Avoid type-punned deref of X events.
4864 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4866 Fix some uses of `int' instead of EMACS_INT.
4867 * search.c (string_match_1, fast_string_match)
4868 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4869 (scan_buffer, find_next_newline_no_quit)
4870 (find_before_next_newline, search_command, Freplace_match)
4871 (Fmatch_data): Make some `int' variables be EMACS_INT.
4873 * xdisp.c (display_count_lines): 3rd argument and return value now
4874 EMACS_INT. All callers changed.
4875 (pint2hrstr): Last argument is now EMACS_INT.
4877 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4878 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4879 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4880 (decode_coding_utf_16, decode_coding_emacs_mule)
4881 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4882 (decode_coding_ccl, decode_coding_charset)
4883 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4884 (decode_coding_iso_2022, decode_coding_emacs_mule)
4885 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4886 <char_offset, last_offset>: Declare EMACS_INT.
4887 (encode_coding_utf_8, encode_coding_utf_16)
4888 (encode_coding_emacs_mule, encode_invocation_designation)
4889 (encode_designation_at_bol, encode_coding_iso_2022)
4890 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4891 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4893 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4894 (encode_invocation_designation): Last argument P_NCHARS is now
4896 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4897 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4899 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4902 * ccl.c (Fccl_execute_on_string): Declare some variables
4905 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4907 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4909 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4911 * process.c (Fformat_network_address): Doc fix.
4913 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4915 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4917 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4919 * keyboard.c (read_char): Call Lisp function help-form-show,
4920 instead of using internal_with_output_to_temp_buffer.
4921 (Qhelp_form_show): New var.
4922 (syms_of_keyboard): Use DEFSYM macro.
4924 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4926 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4928 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4930 * process.c (Flist_processes): Remove to Lisp.
4931 (list_processes_1): Delete.
4933 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4935 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4937 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4939 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4941 Fix more problems found by GCC 4.6.0's static checks.
4943 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4945 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4947 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4949 * xdisp.c (vmessage): Mark as a printf-like function.
4951 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4953 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4955 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4956 printf-like functions.
4957 (tiff_load): Add casts to remove these marks before passing them
4958 to system-supplied API.
4960 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4962 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4963 This avoids several warnings with gcc -Wstrict-overflow.
4964 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4965 directly, rather than having caller test rule sign. This avoids
4966 some unnecessary tests.
4967 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4968 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4969 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4971 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4972 (xfont_open): Avoid unnecessary tests.
4974 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4976 * composite.h, composite.c (composition_gstring_put_cache):
4977 Use EMACS_INT, not int, for length.
4979 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4980 breaking out part of COMPOSITION_DECODE_RULE.
4981 (COMPOSITION_DECODE_RULE): Use it.
4982 * composite.c (get_composition_id): Remove unused local vars,
4983 by using the new macro.
4985 * textprop.c (set_text_properties_1): Change while to do-while,
4986 since the condition is always true at first.
4988 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4989 (interval_deletion_adjustment): Return unsigned value.
4992 * process.c (list_processes_1, create_pty, read_process_output):
4993 (exec_sentinel): Remove vars that were set but not used.
4994 (create_pty): Remove unnecessary "volatile"s.
4995 (Fnetwork_interface_info): Avoid possibility of int overflow.
4996 (read_process_output): Do adaptive read buffering even if carryover.
4997 (read_process_output): Simplify nbytes computation if buffered.
4999 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5001 * syntax.c (scan_words): Remove var that was set but not used.
5002 (update_syntax_table): Use unsigned instead of int.
5004 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5005 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5006 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5008 * print.c (print_error_message): Avoid int overflow.
5010 * font.c (font_list_entities): Redo for clarity,
5011 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5013 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5014 (font_score): Avoid potential overflow in diff calculation.
5016 * fns.c (substring_both): Remove var that is set but not used.
5017 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5019 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5021 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5022 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5023 can always succeed if overflow has undefined behavior.
5025 * search.c (boyer_moore, wordify): Remove vars set but not used.
5026 (wordify): Omit three unnecessary tests.
5028 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5029 All callers changed. This avoids the need for an unused var.
5031 * casefiddle.c (casify_region): Remove var that is set but not used.
5033 * dired.c (file_name_completion): Remove var that is set but not used.
5035 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5037 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5038 (Finsert_file_contents): Remove unnecessary code checking fd.
5040 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5041 Check for integer overflow on size calculations.
5043 * buffer.c (Fprevious_overlay_change): Remove var that is set
5046 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5047 Remove vars that are set but not used.
5048 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5049 (timer_check_2): Mark vars as initialized.
5051 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5053 * image.c (lookup_image): Remove var that is set but not used.
5054 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5056 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5057 that are set but not used.
5059 * xfns.c (make_invisible_cursor): Don't return garbage
5060 if XCreateBitmapFromData fails (Bug#8410).
5062 * xselect.c (x_get_local_selection, x_handle_property_notify):
5063 Remove vars that are set but not used.
5065 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5066 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5068 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5069 Remove var that is set but not used.
5070 (scroll_bar_windows_size): Now size_t, not int.
5071 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5074 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5075 (map_tty_color) [!defined MSDOS]: Likewise.
5077 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5079 * coding.c: Remove vars that are set but not used.
5080 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5081 All callers changed.
5082 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5083 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5084 (decode_coding_charset): Remove vars that are set but not used.
5086 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5087 that is set but not used.
5089 * print.c (print_object): Remove var that is set but not used.
5091 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5092 The gnulib version avoids calling malloc in the usual case,
5093 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5094 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5095 * filelock.c (current_lock_owner): Likewise.
5096 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5097 * sysdep.c: Include allocator.h, careadlinkat.h.
5098 (emacs_no_realloc_allocator): New static constant.
5099 (emacs_readlink): New function.
5100 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5101 ../lib/careadlinkat.h.
5103 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5105 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5106 first non-nil return value).
5108 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5110 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5111 if not defined (Bug#8403).
5113 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5115 * xdisp.c (display_count_lines): Remove parameter `start',
5116 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5117 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5118 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5119 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5120 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5121 and thereabouts. All callers changed.
5122 (get_per_char_metric): Remove parameter `f', unused since
5123 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5125 2011-04-02 Jim Meyering <meyering@redhat.com>
5127 do not dereference NULL upon failed strdup
5128 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5129 (ns_get_family): Likewise.
5131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5133 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5135 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5137 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5140 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5142 Add lexical binding.
5144 * window.c (Ftemp_output_buffer_show): New fun.
5145 (Fsave_window_excursion):
5146 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5148 * lread.c (lisp_file_lexically_bound_p): New function.
5149 (Fload): Bind Qlexical_binding.
5150 (readevalloop): Remove `evalfun' arg.
5151 Bind Qinternal_interpreter_environment.
5152 (Feval_buffer): Bind Qlexical_binding.
5153 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5155 (syms_of_lread): Declare `lexical-binding'.
5157 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5159 * keyboard.c (eval_dyn): New fun.
5160 (menu_item_eval_property): Use it.
5162 * image.c (parse_image_spec): Use Ffunctionp.
5164 * fns.c (concat, mapcar1): Accept byte-code-functions.
5166 * eval.c (Fsetq): Handle lexical vars.
5167 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5168 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5169 (FletX, Flet): Obey lexical binding.
5170 (Fcommandp): Handle closures.
5171 (Feval): New `lexical' arg.
5172 (eval_sub): New function extracted from Feval. Use it almost
5173 everywhere where Feval was used. Look up vars in lexical env.
5175 (Ffunctionp): Move from subr.el.
5176 (Ffuncall): Handle closures.
5177 (apply_lambda): Remove `eval_flags'.
5178 (funcall_lambda): Handle closures and new byte-code-functions.
5179 (Fspecial_variable_p): New function.
5180 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5181 but without exporting it to Lisp.
5183 * doc.c (Fdocumentation, store_function_docstring):
5184 * data.c (Finteractive_form): Handle closures.
5186 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5189 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5191 (exec_byte_code): New function extracted from Fbyte_code to handle new
5192 calling convention for byte-code-functions. Add new byte-codes.
5194 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5196 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5198 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5200 * xdisp.c (redisplay_internal): Fix prototype.
5202 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5204 * xdisp.c (SCROLL_LIMIT): New macro.
5205 (try_scrolling): Use it when setting scroll_limit.
5206 Limit scrolling to 100 screen lines.
5207 (redisplay_window): Even when falling back on "recentering",
5208 position point in the window according to scroll-conservatively,
5209 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5211 (try_scrolling): When point is above the window, allow searching
5212 as far as scroll_max, or one screenful, to compute vertical
5213 distance from PT to the scroll margin position. This prevents
5214 try_scrolling from unnecessarily failing when
5215 scroll-conservatively is set to a value slightly larger than the
5216 window height. Clean up the case of PT below the margin at bottom
5217 of window: scroll_max can no longer be INT_MAX. When aggressive
5218 scrolling is in use, don't let point enter the opposite scroll
5219 margin as result of the scroll.
5220 (syms_of_xdisp) <scroll-conservatively>: Document the
5221 threshold of 100 lines for never-recentering scrolling.
5223 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5225 * dispextern.h (move_it_by_lines):
5226 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5227 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5228 (message_log_check_duplicate): Remove parameters `prev_bol' and
5229 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5230 (redisplay_internal): Remove parameter `preserve_echo_area',
5231 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5233 * indent.c (Fvertical_motion):
5234 * window.c (window_scroll_pixel_based, Frecenter):
5235 Don't pass `need_y_p' to `move_it_by_lines'.
5237 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5239 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5240 steal a few bits to be more compact.
5241 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5242 Remove unneeded casts.
5244 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5246 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5248 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5249 binding" message (bug#7967).
5251 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5253 Fix more problems found by GCC 4.6.0's static checks.
5255 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5256 Remove unused local var.
5258 * editfns.c (Fmessage_box): Remove unused local var.
5260 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5261 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5262 Omit unused local vars.
5263 * window.c (shrink_windows): Omit unused local var.
5264 * menu.c (digest_single_submenu): Omit unused local var.
5265 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5266 Omit unused local var.
5268 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5269 Don't assume string length fits in int.
5270 (keyremap_step, read_key_sequence): Use size_t for sizes.
5271 (read_key_sequence): Don't check last_real_key_start redundantly.
5273 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5274 instead of alloca (Bug#8344).
5276 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5277 (Fbacktrace_frame): Don't assume nframes fits in int.
5279 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5281 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5284 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5286 * cm.c (calccost): Turn while-do into do-while, for clarity.
5288 * keyboard.c (syms_of_keyboard): Use the same style as later
5289 in this function when indexing through an array. This also
5290 works around GCC bug 48267.
5292 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5294 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5296 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5297 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5299 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5300 This avoids undefined behavior on integer overflow, and is a bit
5301 more convenient anyway since it is compared to a size_t variable.
5303 Variadic C functions now count arguments with size_t, not int.
5304 This avoids an unnecessary limitation on 64-bit machines, which
5305 caused (substring ...) to crash on large vectors (Bug#8344).
5306 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5307 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5308 All variadic functions and their callers changed accordingly.
5309 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5310 * data.c (arith_driver, float_arith_driver): Likewise.
5311 * editfns.c (general_insert_function): Likewise.
5312 * eval.c (struct backtrace.nargs, interactive_p)
5313 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5314 (funcall_lambda, mark_backtrace): Likewise.
5315 * fns.c (concat): Likewise.
5316 * frame.c (x_set_frame_parameters): Likewise.
5317 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5318 0 if not found, not -1. All callers changed.
5320 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5321 (stack_copy_size): Now size_t, not int.
5322 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5324 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5326 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5327 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5328 All callers changed.
5330 * lisp.h (multibyte_char_to_unibyte):
5331 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5332 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5333 * character.h (CHAR_TO_BYTE8):
5334 * cmds.c (internal_self_insert):
5335 * editfns.c (general_insert_function):
5336 * keymap.c (push_key_description):
5337 * search.c (Freplace_match):
5338 * xdisp.c (message_dolog, set_message_1): All callers changed.
5340 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5342 * keyboard.c (safe_run_hook_funcall): New function.
5343 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5344 don't set the hook to nil, but remove the offending function instead.
5345 (Qcommand_hook_internal): Remove, unused.
5346 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5347 Vcommand_hook_internal.
5349 * eval.c (enum run_hooks_condition): Remove.
5350 (funcall_nil, funcall_not): New functions.
5351 (run_hook_with_args): Call each function through a `funcall' argument.
5352 Remove `cond' argument, now redundant.
5353 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5354 (Frun_hook_with_args_until_failure): Adjust accordingly.
5355 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5357 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5359 * dispextern.h (string_buffer_position): Remove declaration.
5361 * print.c (strout): Remove parameter `multibyte', unused since
5362 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5364 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5365 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5366 All callers changed.
5368 * w32.c (_wsa_errlist): Use braces for struct initializers.
5370 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5371 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5372 All callers changed.
5373 (string_buffer_position): Likewise. Also, make static (it's never
5374 used outside xdisp.c).
5375 (cursor_row_p): Remove parameter `w', unused since
5376 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5377 (decode_mode_spec): Remove parameter `precision', introduced during
5378 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5379 All callers changed.
5381 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5383 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5385 2011-03-27 Anders Lindgren <andlind@gmail.com>
5387 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5388 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5389 (ns_update_auto_hide_menu_bar): New functions.
5390 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5391 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5392 ns_constrain_all_frames.
5393 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5394 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5396 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5398 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5400 2011-03-27 Glenn Morris <rgm@gnu.org>
5402 * syssignal.h: Replace RETSIGTYPE with void.
5403 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5404 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5405 Replace SIGTYPE with void everywhere.
5406 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5407 * s/template.h (SIGTYPE): Remove commented out definition.
5409 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5411 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5412 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5414 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5416 * w32.c (read_unc_volume): Use parameter `henum', instead of
5417 global variable `wget_enum_handle'.
5419 * keymap.c (describe_vector): Remove parameters `indices' and
5420 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5421 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5423 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5425 * keyboard.c (timer_check): Remove parameter `do_it_now',
5426 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5427 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5428 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5430 * keyboard.c (read_char):
5431 * w32menu.c (w32_menu_display_help):
5432 * xmenu.c (show_help_event, menu_help_callback):
5433 Adjust calls to `show_help_echo'.
5435 * gtkutil.c (xg_maybe_add_timer):
5436 * keyboard.c (readable_events):
5437 * process.c (wait_reading_process_output):
5438 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5440 * insdel.c (adjust_markers_gap_motion):
5441 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5442 (gap_left, gap_right): Don't call it.
5444 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5446 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5447 incurred during fontification.
5449 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5451 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5452 (DEFVAR_PER_BUFFER): Don't pass it.
5454 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5455 (scrolling_window): Don't pass it.
5457 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5459 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5461 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5463 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5464 of variables specific to SELinux and computation of `encoded_absname'.
5466 * image.c (XPutPixel): Remove unused variable `height'.
5468 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5470 * unexw32.c (get_section_info): Remove unused variable `section'.
5472 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5473 (system_process_attributes): Remove unused variable `sess'.
5474 (sys_read): Remove unused variable `err'.
5476 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5477 (w32_wnd_proc): Remove unused variable `isdead'.
5478 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5479 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5480 (x_create_tip_frame): Remove unused variable `tem'.
5482 * w32inevt.c (w32_console_read_socket):
5483 Remove unused variable `no_events'.
5485 * w32term.c (x_draw_composite_glyph_string_foreground):
5486 Remove unused variable `width'.
5488 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5490 * w32term.c (x_set_glyph_string_clipping):
5491 Don't pass uninitialized region to CombineRgn.
5493 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5495 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5496 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5497 (Fx_close_connection): Remove unused variable `i'.
5499 * w32font.c (w32font_draw): Return number of glyphs.
5500 (w32font_open_internal): Remove unused variable `i'.
5501 (w32font_driver): Add missing initializer.
5503 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5504 (fill_in_menu): Remove unused variable `items_added'.
5506 * w32term.c (last_mouse_press_frame): Remove static global variable.
5507 (w32_clip_to_row): Remove unused variable `f'.
5508 (x_delete_terminal): Remove unused variable `i'.
5510 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5511 (NOTHING): Remove unused static global variable.
5512 (uniscribe_check_otf): Remove unused variable `table'.
5513 (uniscribe_font_driver): Add missing initializers.
5515 2011-03-23 Julien Danjou <julien@danjou.info>
5517 * term.c (Fsuspend_tty, Fresume_tty):
5518 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5519 * window.c (temp_output_buffer_show):
5520 * insdel.c (signal_before_change):
5521 * frame.c (Fhandle_switch_frame):
5522 * fileio.c (Fdo_auto_save):
5523 * emacs.c (Fkill_emacs):
5524 * editfns.c (save_excursion_restore):
5525 * cmds.c (internal_self_insert):
5526 * callint.c (Fcall_interactively):
5527 * buffer.c (Fkill_all_local_variables):
5528 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5530 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5531 unconditionnaly since it does the check itself.
5533 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5535 Fix more problems found by GCC 4.5.2's static checks.
5537 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5538 the first time through the loop, since we know p0 < p1 then.
5539 This also avoids a gcc -Wstrict-overflow warning.
5541 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5542 leading to a memory leak, possible in functions like
5543 load_charset_map_from_file that can allocate an unbounded number
5544 of objects (Bug#8318).
5546 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5547 that could (at least in theory) be that large.
5549 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5550 This is less likely to overflow, and avoids undefined behavior if
5551 overflow does occur. All callers changed. Use strtoul to scan
5552 for the unsigned long integer.
5553 (pint2hrstr): Simplify and tune code slightly.
5554 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5556 * scroll.c (do_scrolling): Work around GCC bug 48228.
5557 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5559 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5560 This also avoids a warning with gcc -Wstrict-overflow.
5561 (validate_x_resource_name): Simplify count usage.
5562 This also avoids a warning with gcc -Wstrict-overflow.
5564 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5567 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5569 * process.c (Fmake_network_process): Use socklen_t, not int,
5570 where POSIX says socklen_t is required in portable programs.
5571 This fixes a porting bug on hosts like 64-bit HP-UX, where
5572 socklen_t is wider than int (Bug#8277).
5573 (Fmake_network_process, server_accept_connection):
5574 (wait_reading_process_output, read_process_output):
5577 * process.c: Rename or move locals to avoid shadowing.
5578 (list_processes_1, Fmake_network_process):
5579 (read_process_output_error_handler, exec_sentinel_error_handler):
5580 Rename or move locals.
5581 (Fmake_network_process): Define label "retry_connect" only if needed.
5582 (Fnetwork_interface_info): Fix pointer signedness.
5583 (process_send_signal): Add cast to avoid pointer signedness problem.
5584 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5585 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5587 Make tparam.h and terminfo.c consistent.
5588 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5589 Include tparam.h instead, since it declares them.
5590 * cm.h (PC): Remove extern decl; tparam.h now does this.
5591 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5592 * terminfo.c: Include tparam.h, to check interfaces.
5593 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5594 (tparam): Adjust signature to match interface in tparam.h;
5595 this removes some undefined behavior. Check that outstring and len
5596 are zero, which they always are with Emacs.
5597 * tparam.h (PC, BC, UP): New extern decls.
5599 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5600 (xftfont_open): Rename locals to avoid shadowing.
5602 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5603 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5604 (OTF_TAG_SYM): Omit macro if not needed.
5605 (ftfont_list): Remove unused local.
5606 (get_adstyle_property, ftfont_pattern_entity):
5607 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5608 Rename locals to avoid shadowing.
5610 * xfont.c (xfont_list_family): Mark var as initialized.
5612 * xml.c (make_dom): Now static.
5614 * composite.c (composition_compute_stop_pos): Rename local to
5616 (composition_reseat_it): Remove unused locals.
5617 (find_automatic_composition, composition_adjust_point): Likewise.
5618 (composition_update_it): Mark var as initialized.
5619 (find_automatic_composition): Mark vars as initialized,
5620 with a FIXME (Bug#8290).
5622 character.h: Rename locals to avoid shadowing.
5623 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5624 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5625 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5626 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5629 * textprop.c (property_change_between_p): Remove; unused.
5631 * intervals.c (interval_start_pos): Now static.
5633 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5635 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5636 Rename locals to avoid shadowing.
5638 * sound.c (wav_play, au_play, Fplay_sound_internal):
5639 Fix pointer signedness.
5640 (alsa_choose_format): Remove unused local var.
5641 (wav_play): Initialize a variable to 0, to prevent undefined
5642 behavior (Bug#8278).
5644 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5646 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5648 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5649 clobbering (Bug#8298).
5650 * sysdep.c (sys_subshell): Likewise.
5651 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5653 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5654 This should get cleaned up, so that child_setup has the
5655 same signature on all platforms.
5657 * callproc.c (call_process_cleanup): Now static.
5658 (relocate_fd): Rename locals to avoid shadowing.
5660 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5662 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5663 not to be necessary, and produces flickering.
5665 2011-03-20 Glenn Morris <rgm@gnu.org>
5667 * config.in: Remove file.
5669 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5671 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5672 are now in src/globals.h.
5673 (syms_of_minibuf): Remove spurious & from previous change.
5675 2011-03-20 Leo <sdl.web@gmail.com>
5677 * minibuf.c (completing-read-function): New variable.
5678 (completing-read-default): Rename from completing-read.
5679 (completing-read): Call completing-read-function.
5681 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5683 * xfaces.c (Fx_load_color_file):
5684 Read color file from absolute filename (bug#8250).
5686 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5688 * makefile.w32-in: Update dependencies.
5690 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5692 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5694 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5696 Fix more problems found by GCC 4.5.2's static checks.
5698 * process.c (make_serial_process_unwind, send_process_trap):
5699 (sigchld_handler): Now static.
5701 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5702 That way, the code declares only the vars that it needs.
5703 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5704 * s/cygwin.h (PTY_ITERATION): Likewise.
5705 * s/darwin.h (PTY_ITERATION): Likewise.
5706 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5708 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5709 * process.c (allocate_pty): Don't declare stb unless it's needed.
5711 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5712 (CONSTANTLIM): Remove; unused.
5713 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5714 Define only if needed.
5716 * unexelf.c (unexec): Name an expression,
5717 to avoid gcc -Wbad-function-cast warning.
5718 Use a different way to cause a compilation error if anyone uses
5719 n rather than nn, a way that does not involve shadowing.
5720 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5722 * deps.mk (unexalpha.o): Remove; unused.
5724 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5725 * unexec.h: New file.
5726 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5727 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5729 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5730 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5731 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5732 Change as necessary to match prototype in unexec.h.
5734 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5736 (back_comment, skip_chars): Mark vars as initialized.
5738 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5739 Rename locals to avoid shadowing.
5741 * lread.c (read1): Rewrite so as not to use empty "else".
5742 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5744 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5746 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5747 warning when compiling print.c.
5749 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5750 instead of using an uninitialized var.
5751 (font_sort_entities): Mark var as initialized.
5753 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5755 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5756 pointers to constants.
5757 (font_parse_fcname): Remove unused vars.
5758 (font_delete_unmatched): Now static.
5759 (font_get_spec): Remove; unused.
5760 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5761 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5762 Rename or move locals to avoid shadowing.
5764 * fns.c (require_nesting_list, require_unwind): Now static.
5765 (Ffillarray): Rename locals to avoid shadowing.
5767 * floatfns.c (domain_error2): Define only if needed.
5768 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5770 * alloc.c (mark_backtrace): Move decl from here ...
5771 * lisp.h: ... to here, so that it can be checked.
5773 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5774 (Fdefvar): Rewrite so as not to use empty "else".
5775 (lisp_indirect_variable): Name an expression,
5776 to avoid gcc -Wbad-function-cast warning.
5777 (Fdefvar): Rename locals to avoid shadowing.
5779 * callint.c (quotify_arg, quotify_args): Now static.
5780 (Fcall_interactively): Rename locals to avoid shadowing.
5781 Use const pointer when appropriate.
5783 * lisp.h (get_system_name, get_operating_system_release):
5784 Move decls here, to check interfaces.
5785 * process.c (get_operating_system_release): Move decl to lisp.h.
5786 * xrdb.c (get_system_name): Likewise.
5787 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5788 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5789 some of which prompt warnings from gcc -Wbad-function-cast.
5790 (Fformat_time_string, Fencode_time, Finsert_char):
5791 (Ftranslate_region_internal, Fformat):
5792 Rename or remove local vars to avoid shadowing.
5793 (Ftranslate_region_internal): Mark var as initialized.
5795 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5798 * lisp.h (eassert): Check that the argument compiles, even if
5799 ENABLE_CHECKING is not defined.
5801 * data.c (Findirect_variable): Name an expression, to avoid
5802 gcc -Wbad-function-cast warning.
5803 (default_value, arithcompare, arith_driver, arith_error): Now static.
5804 (store_symval_forwarding): Rename local to avoid shadowing.
5805 (Fmake_variable_buffer_local, Fmake_local_variable):
5806 Mark variables as initialized.
5807 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5809 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5810 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5811 Rename locals to avoid shadowing.
5812 (mark_stack): Move local variables into the #ifdef region where
5814 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5815 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5817 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5818 (GC_STRING_CHARS): Remove; not used.
5819 (Fmemory_limit): Cast sbrk's returned value to char *.
5821 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5822 avoids undefined behavior in theory.
5824 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5826 Use functions, not macros, for up- and down-casing (Bug#8254).
5827 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5828 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5829 to use the following functions instead of these macros.
5830 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5831 EMACS_INT, since callers assume the returned value fits in int.
5832 (upcase1): Likewise, for UPCASE_TABLE.
5833 (uppercasep, lowercasep, upcase): New static inline functions.
5834 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5835 the race-condition problem in the old DOWNCASE.
5837 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5838 Rename locals to avoid shadowing.
5839 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5840 (regex_compile, re_search_2, re_match_2_internal):
5841 Remove unused local vars.
5842 (FREE_VAR): Rewrite so as not to use empty "else",
5843 which gcc can warn about.
5844 (regex_compile, re_match_2_internal): Mark locals as initialized.
5845 (RETALLOC_IF): Define only if needed.
5846 (WORDCHAR_P): Likewise. This one is never needed, but is used
5847 only in a comment talking about a compiler bug, so put inside
5848 the #if 0 of that comment.
5849 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5850 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5853 * search.c (boyer_moore): Rename locals to avoid shadowing.
5854 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5855 (PREV_CHAR_BOUNDARY): Likewise.
5857 * search.c (simple_search): Remove unused var.
5859 * dired.c (compile_pattern): Move decl from here ...
5860 * lisp.h: ... to here, so that it can be checked.
5861 (struct re_registers): New forward decl.
5863 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5865 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5867 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5868 Rename locals to avoid shadowing.
5869 (Fvertical_motion): Mark locals as initialized.
5871 * casefiddle.c (casify_object, casify_region): Now static.
5872 (casify_region): Mark local as initialized.
5874 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5876 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5877 New macros, so that the caller can use some names other than
5878 gcpro1, gcpro2, etc.
5879 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5881 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5882 argument, for consistency with GCPRO2_VAR, etc: it is now the
5883 prefix of the variable, not the variable itself. All uses
5885 * dired.c (directory_files_internal, file_name_completion):
5886 Rename locals to avoid shadowing.
5888 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5889 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5890 dired.c's scmp function, had undefined behavior.
5891 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5892 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5893 * buffer.h: ... to here, because these macros use current_buffer,
5894 and the new implementation with inline functions needs to have
5895 current_buffer in scope now, rather than later when the macros
5897 (downcase, upcase1): New static inline functions.
5898 (DOWNCASE, UPCASE1): Reimplement using these functions.
5899 This avoids undefined behavior in expressions like
5900 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5901 from race conditions in accessing the global variables
5902 case_temp1 and case_temp2.
5903 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5904 * lisp.h (case_temp1, case_temp2): Remove their decls.
5905 * character.h (ASCII_CHAR_P): Move from here ...
5906 * lisp.h: ... to here, so that the inline functions mentioned
5909 * dired.c (directory_files_internal_unwind): Now static.
5911 * fileio.c (file_name_as_directory, directory_file_name):
5912 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5914 (file_name_as_directory): Use const pointers when appropriate.
5915 (Fexpand_file_name): Likewise. In particular, newdir might
5916 point at constant storage, so make it a const pointer.
5917 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5918 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5920 (Fset_file_times, Finsert_file_contents, auto_save_error):
5921 Rename locals to avoid shadowing.
5923 * minibuf.c (choose_minibuf_frame_1): Now static.
5924 (Ftry_completion, Fall_completions): Rename or remove locals
5927 * marker.c (bytepos_to_charpos): Remove; unused.
5929 * lisp.h (verify_bytepos, count_markers): New decls,
5930 so that gcc does not warn that these functions aren't declared.
5932 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5933 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5934 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5935 (copy_text): Remove unused local var.
5937 * filelock.c (within_one_second): Now static.
5938 (lock_file_1): Rename local to avoid shadowing.
5940 * buffer.c (fix_overlays_before): Mark locals as initialized.
5941 (fix_start_end_in_overlays): Likewise. This function should be
5942 simplified by using pointers-to-pointers, but that's a different
5944 (switch_to_buffer_1): Now static.
5945 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5946 (report_overlay_modification): Rename locals to avoid shadowing.
5948 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5949 Fix pointer signedness issue.
5950 (sys_subshell): Mark local as volatile if checking for lint,
5951 to suppress a gcc -Wclobbered warning that does not seem to be right.
5952 (MAXPATHLEN): Define only if needed.
5954 * process.c (serial_open, serial_configure): Move decls from here ...
5955 * systty.h: ... to here, so that they can be checked.
5957 * fns.c (get_random, seed_random): Move extern decls from here ...
5958 * lisp.h: ... to here, so that they can be checked.
5960 * sysdep.c (reset_io): Now static.
5961 (wait_for_termination_signal): Remove; unused.
5963 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5964 (copy_keymap_item, append_key, push_text_char_description):
5966 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5967 (DENSE_TABLE_SIZE): Remove; unused.
5968 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5969 (describe_map_tree):
5970 Rename locals to avoid shadowing.
5972 * keyboard.c: Declare functions static if they are not used elsewhere.
5973 (echo_char, echo_dash, cmd_error, top_level_2):
5974 (poll_for_input, handle_async_input): Now static.
5975 (read_char, kbd_buffer_get_event, make_lispy_position):
5976 (make_lispy_event, make_lispy_movement, apply_modifiers):
5977 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5978 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5979 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5980 (read_key_sequence, read_char): Mark locals as initialized.
5981 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5983 * keyboard.h (make_ctrl_char): New decl.
5984 (mark_kboards): Move decl here ...
5985 * alloc.c (mark_kboards): ... from here.
5987 * lisp.h (force_auto_save_soon): New decl.
5989 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5990 (DEFINE_DUMMY_FUNCTION): New macro.
5991 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5993 (main): Add casts to avoid warnings
5994 if GCC considers string literals to be constants.
5996 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5998 * dbusbind.c: Pointer signedness fixes.
5999 (xd_signature, xd_append_arg, xd_initialize):
6000 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6001 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6002 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6003 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6005 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6006 if GCC considers string literals to be constants.
6007 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6009 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6011 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6012 (print_preprocess, print_object): New macro to fix last change.
6014 * print.c (print_preprocess): Don't forget font objects.
6016 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6018 * emacs.c (USAGE3): Doc fixes.
6020 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6022 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6025 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6027 * lisp.h (VWindow_system, Qfile_name_history):
6028 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6029 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6030 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6032 * w32select.c: Don't #include "keyboard.h".
6033 (run_protected): Add extern declaration for waiting_for_input.
6035 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6036 * w32console.c (detect_input_pending, read_input_pending)
6037 (encode_terminal_code):
6038 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6039 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6040 (w32_system_caret_y, Qfile_name_history):
6041 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6042 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6043 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6044 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6045 * w32proc.c (Qlocal, report_file_error):
6046 * w32term.c (Vwindow_system, updating_frame):
6047 * w32uniscribe.c (initialized, uniscribe_font_driver):
6048 Remove unneeded extern declarations.
6050 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6052 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6054 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6056 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6057 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6058 These macros can no longer be used for assignment.
6060 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6061 Assign struct members directly, instead of using BUF_BEGV etc.
6062 (record_buffer_markers, fetch_buffer_markers): New functions for
6063 recording and fetching special buffer markers.
6064 (set_buffer_internal_1, set_buffer_temp): Use them.
6066 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6068 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6070 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6071 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6073 * xdisp.c (hscroll_window_tree):
6074 (reconsider_clip_changes): Use PT instead of BUF_PT.
6076 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6078 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6079 $(EMACS_ROOT)/lib/intprops.h.
6081 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6083 Fix more problems found by GCC 4.5.2's static checks.
6085 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6086 to unsigned char * to avoid compiler diagnostic.
6087 (xg_free_frame_widgets): Make it clear that a local variable is
6088 needed only if USE_GTK_TOOLTIP.
6089 (gdk_window_get_screen): Make it clear that this macro is needed
6090 only if USE_GTK_TOOLTIP.
6091 (int_gtk_range_get_value): New function, which avoids a diagnostic
6092 from gcc -Wbad-function-cast.
6093 (xg_set_toolkit_scroll_bar_thumb): Use it.
6094 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6095 diagnostic from gcc -Wbad-function-cast.
6096 (get_utf8_string, xg_get_file_with_chooser):
6097 Rename locals to avoid shadowing.
6098 (create_dialog): Move locals to avoid shadowing.
6100 * xgselect.c (xg_select): Remove unused var.
6102 * image.c (four_corners_best): Mark locals as initialized.
6103 (gif_load): Initialize transparent_p to zero (Bug#8238).
6104 Mark another local as initialized.
6105 (my_png_error, my_error_exit): Mark with NO_RETURN.
6107 * image.c (clear_image_cache): Now static.
6108 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6109 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6110 (x_edge_detection): Remove unnecessary cast that
6111 gcc -Wbad-function-cast diagnoses.
6112 (gif_load): Fix pointer signedness.
6113 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6114 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6116 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6118 Improve quality of tests for time stamp overflow.
6119 For example, without this patch (encode-time 0 0 0 1 1
6120 1152921504606846976) returns the obviously-bogus value (-948597
6121 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6122 reports time overflow. See
6123 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6124 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6125 * editfns.c: Include limits.h and intprops.h.
6126 (TIME_T_MIN, TIME_T_MAX): New macros.
6127 (time_overflow): Move earlier, to before first use.
6128 (hi_time, lo_time): New functions, for an accurate test for
6130 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6131 (Fget_internal_run_time): Don't assume time_t fits in int.
6132 (make_time): Use list2 instead of Fcons twice.
6133 (Fdecode_time): More accurate test for out-of-range times.
6134 (check_tm_member): New function.
6135 (Fencode_time): Use it, to test for out-of-range times.
6136 (lisp_time_argument): Don't rely on undefined left-shift and
6137 right-shift behavior when checking for time stamp overflow.
6139 * editfns.c (time_overflow): New function, refactoring common code.
6140 (Fformat_time_string, Fdecode_time, Fencode_time):
6141 (Fcurrent_time_string): Use it.
6143 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6144 * dired.c (make_time): Move to ...
6145 * editfns.c (make_time): ... here.
6146 * systime.h: Note the move.
6148 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6150 * fringe.c (update_window_fringes): Remove unused variables.
6152 * unexmacosx.c (copy_data_segment): Also copy __got section.
6155 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6157 * termcap.c [MSDOS]: Include "msdos.h".
6158 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6159 Constify `char *' arguments and their references according to
6160 prototypes in tparam.h.
6162 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6164 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6165 Adapt all references accordingly.
6167 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6169 2011-03-11 Tom Tromey <tromey@redhat.com>
6171 * buffer.c (syms_of_buffer): Remove obsolete comment.
6173 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6175 * termhooks.h (encode_terminal_code): Declare prototype.
6177 * msdos.c (encode_terminal_code): Don't declare prototype.
6179 * term.c (encode_terminal_code): Now external again, used by
6180 w32console.c and msdos.c.
6182 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6183 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6185 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6187 Fix some minor problems found by GCC 4.5.2's static checks.
6189 * fringe.c (update_window_fringes): Mark locals as initialized
6191 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6193 * alloc.c (mark_fringe_data): Move decl from here ...
6194 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6195 to check its interface.
6196 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6198 * fontset.c (free_realized_fontset): Now static.
6199 (Fset_fontset_font): Rename local to avoid shadowing.
6200 (fontset_font): Mark local as initialized.
6201 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6203 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6205 * xselect.c (x_disown_buffer_selections): Remove; not used.
6206 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6207 (x_own_selection, Fx_disown_selection_internal): Rename locals
6209 (x_handle_dnd_message): Remove local to avoid shadowing.
6211 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6212 so that the caller can use some name other than gcpro1.
6213 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6214 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6215 (Fx_backspace_delete_keys_p):
6216 Use them to avoid shadowing, and rename vars to avoid shadowing.
6217 (x_decode_color, x_set_name, x_window): Now static.
6218 (Fx_create_frame): Add braces to silence GCC warning.
6219 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6220 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6221 Remove unused locals.
6222 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6223 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6224 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6227 * xterm.h (x_mouse_leave): New decl.
6229 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6230 Remove unused functions.
6231 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6232 (x_calc_absolute_position): Now static.
6233 (XTread_socket): Don't define label "out" unless it's used.
6234 Don't declare local "event" unless it's used.
6235 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6236 unless they are used.
6237 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6238 (x_fatal_error_signal): Remove; not used.
6239 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6240 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6241 (x_error_catcher, x_connection_closed, x_error_handler):
6242 (x_error_quitter, xembed_send_message, x_iconify_frame):
6243 (my_log_handler): Rename locals to avoid shadowing.
6244 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6245 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6247 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6248 Rename or move locals to avoid shadowing.
6249 (tty_defined_color, merge_face_heights): Now static.
6250 (free_realized_faces_for_fontset): Remove; not used.
6251 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6252 does not deduce is never used uninitialized.
6253 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6254 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6256 * terminal.c (store_terminal_param): Now static.
6258 * xmenu.c (menu_highlight_callback): Now static.
6259 (set_frame_menubar): Remove unused local.
6260 (xmenu_show): Rename parameter to avoid shadowing.
6261 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6262 since they might point to immutable storage.
6263 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6264 since it's unused otherwise.
6266 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6267 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6268 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6269 avoids a gcc -Wuninitialized diagnostic.
6270 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6271 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6272 does not deduce are never used uninitialized.
6274 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6276 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6277 * window.c (window_loop, size_window):
6278 (run_window_configuration_change_hook, enlarge_window): Likewise.
6280 * window.c (display_buffer): Now static.
6281 (size_window): Mark variables that gcc -Wuninitialized
6282 does not deduce are never used uninitialized.
6283 * window.h (check_all_windows): New decl, to forestall
6284 gcc -Wmissing-prototypes diagnostic.
6285 * dispextern.h (bidi_dump_cached_states): Likewise.
6287 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6289 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6291 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6292 and to avoid gcc -Wuninitialized warning.
6293 (load_charset_map): Mark variables that gcc -Wuninitialized
6294 does not deduce are never used uninitialized.
6295 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6297 * coding.c (coding_set_source, coding_set_destination):
6298 Use "else { /* comment */ }" rather than "else /* comment */;"
6299 for clarity, and to avoid gcc -Wempty-body warning.
6300 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6301 a block, when the outer 'i' will do.
6302 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6303 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6304 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6305 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6306 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6307 Rename locals to avoid shadowing.
6308 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6309 * coding.c (emacs_mule_char, encode_invocation_designation):
6310 Now static, since they're not used elsewhere.
6311 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6312 (decode_coding_object, encode_coding_object, detect_coding_system):
6313 (decode_coding_emacs_mule): Mark variables that gcc
6314 -Wuninitialized does not deduce are never used uninitialized.
6315 (detect_coding_iso_2022): Initialize a local variable that might
6316 be used uninitialized. Leave a FIXME because it's not clear that
6317 this initialization is needed. (Bug#8211)
6318 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6319 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6320 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6321 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6322 Remove unused macros.
6324 * category.c (hash_get_category_set): Remove unused local var.
6325 (copy_category_table): Now static, since it's not used elsewhere.
6326 * character.c (string_count_byte8): Likewise.
6328 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6329 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6331 * chartab.c (copy_sub_char_table): Now static, since it's not used
6333 (sub_char_table_ref_and_range, char_table_ref_and_range):
6334 Rename locals to avoid shadowing.
6335 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6337 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6338 (BIDI_BOB): Remove unused macro.
6340 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6341 deduce are never used uninitialized.
6342 * term.c (encode_terminal_code): Likewise.
6344 * term.c (encode_terminal_code): Now static. Remove unused local.
6346 * tparam.h: New file.
6347 * term.c, tparam.h: Include it.
6348 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6349 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6350 Move these decls to tparam.h, and make them agree with what
6351 is actually in tparam.c. The previous trick of using incompatible
6352 decls in different modules does not conform to the C standard.
6353 All callers of tparam changed to use tparam's actual API.
6354 * tparam.c (tparam1, tparam, tgoto):
6355 Use const pointers where appropriate.
6357 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6358 * cm.h (struct cm): Likewise.
6359 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6360 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6361 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6362 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6363 (turn_on_face, init_tty): Likewise.
6364 * termchar.h (struct tty_display_info): Likewise.
6366 * term.c (term_mouse_position): Rename local to avoid shadowing.
6368 * alloc.c (mark_ttys): Move decl from here ...
6369 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6371 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6373 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6375 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6377 * search.c (compile_pattern_1): Remove argument regp, unused since
6378 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6379 (compile_pattern): Don't pass it.
6381 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6383 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6384 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6386 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6388 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6390 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6391 gdk_window_get_screen, gdk_window_get_geometry,
6392 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6393 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6394 (xg_get_pixbuf_from_pixmap): New function.
6395 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6396 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6397 Call xg_get_pixbuf_from_pixmap instead of
6398 gdk_pixbuf_get_from_drawable.
6399 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6400 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6401 (xg_check_special_colors): Use GtkStyleContext and its functions
6403 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6404 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6405 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6406 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6407 Call gtk_widget_get_preferred_size.
6408 (xg_frame_resized): gdk_window_get_geometry only takes 5
6410 (xg_win_to_widget, xg_event_is_for_menubar):
6411 Call gdk_x11_window_lookup_for_display.
6412 (xg_set_widget_bg): New function.
6413 (delete_cb): New function.
6414 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6415 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6416 (xg_set_background_color): Call xg_set_widget_bg.
6417 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6418 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6419 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6420 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6422 (update_frame_tool_bar): Call gtk_widget_hide.
6423 (xg_initialize): Use GDK_KEY_g.
6425 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6427 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6429 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6430 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6431 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6433 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6435 * w32xfns.c (select_palette): Check success of RealizePalette against
6436 GDI_ERROR, not zero.
6438 See ChangeLog.11 for earlier changes.
6444 Copyright (C) 2011 Free Software Foundation, Inc.
6446 This file is part of GNU Emacs.
6448 GNU Emacs is free software: you can redistribute it and/or modify
6449 it under the terms of the GNU General Public License as published by
6450 the Free Software Foundation, either version 3 of the License, or
6451 (at your option) any later version.
6453 GNU Emacs is distributed in the hope that it will be useful,
6454 but WITHOUT ANY WARRANTY; without even the implied warranty of
6455 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6456 GNU General Public License for more details.
6458 You should have received a copy of the GNU General Public License
6459 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.