1 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6 * xterm.c (XTread_socket): Only modify handling_signal if
7 !SYNC_INPUT. (Bug#11080)
9 2012-03-23 Eli Zaretskii <eliz@gnu.org>
11 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
12 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
13 when fetching a multibyte character consumes more bytes than
14 CHAR_BYTES returns, due to unification of CJK characters in
15 string_char. (Bug#11073)
17 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
19 * process.c (wait_reading_process_output): Handle pty disconnect
20 by refraining from sending oneself a SIGCHLD (bug#10933).
22 2012-03-22 Chong Yidong <cyd@gnu.org>
24 * dispextern.h (struct it): New member string_from_prefix_prop_p.
26 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
27 Mark string as coming from a prefix property.
28 (handle_face_prop): Use default face for prefix strings (Bug#4281).
29 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
31 2012-03-21 Chong Yidong <cyd@gnu.org>
33 * xfaces.c (Vface_remapping_alist): Doc fix.
35 2012-03-20 Eli Zaretskii <eliz@gnu.org>
37 * w32proc.c (Fw32_set_console_codepage)
38 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
41 2012-03-20 Chong Yidong <cyd@gnu.org>
43 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
44 to reflect default non-nil value of redisplay-dont-pause.
46 2012-03-19 Kenichi Handa <handa@m17n.org>
48 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
49 it fit in a valid range (Bug#11003).
51 2012-03-18 Eli Zaretskii <eliz@gnu.org>
53 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
54 that is not from display property, accept the row as a "cursor
55 row" if one of the string's character has a non-nil `cursor'
56 property. Fixes cursor positioning when there are newlines in
57 overlay strings, e.g. in icomplete.el. (Bug#11035)
59 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
61 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
63 2012-03-12 Chong Yidong <cyd@gnu.org>
65 * eval.c (inhibit_lisp_code): Rename from
66 inhibit_window_configuration_change_hook; move from window.c.
68 * xfns.c (unwind_create_frame_1, Fx_create_frame):
69 * window.c (run_window_configuration_change_hook)
70 (syms_of_window): Callers changed.
72 2012-03-11 Chong Yidong <cyd@gnu.org>
74 * keymap.c (Fkey_description): Doc fix (Bug#9700).
76 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
78 2012-03-10 Chong Yidong <cyd@gnu.org>
80 * frame.c (other_visible_frames): Don't assume the selected frame
81 is visible (Bug#10955).
83 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
85 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
87 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
89 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
90 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
93 2012-03-03 Glenn Morris <rgm@gnu.org>
95 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
97 2012-03-02 Eli Zaretskii <eliz@gnu.org>
99 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
100 position past the first glyph_row that ends at ZV. (Bug#10902)
101 (redisplay_window, next_element_from_string): Fix typos in
103 (redisplay_window): Pass to move_it_vertically the margin in
104 pixels, not in screen lines.
106 2012-03-02 Glenn Morris <rgm@gnu.org>
108 * buffer.c (buffer-list-update-hook): Doc fix.
110 2012-02-29 Eli Zaretskii <eliz@gnu.org>
112 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
113 push_it before setting up the iterator for the first overlay
114 string, even if we have an empty string loaded.
115 (next_overlay_string): If there's an empty string on the iterator
116 stack, pop the stack. (Bug#10903)
118 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
120 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
121 Suggested by Stefan Monnier in
122 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
123 * alloc.c (widen_to_Lisp_Object): New static function.
124 (mark_memory): Also mark Lisp_Objects by fetching pointer words
125 and widening them to Lisp_Objects. This would work even if
126 USE_LSB_TAG is defined and wide integers are used, which might
127 happen in a future version of Emacs.
129 2012-02-25 Chong Yidong <cyd@gnu.org>
131 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
134 * xselect.c (Fx_selection_exists_p): Doc fix.
135 (x_clipboard_manager_save_all): Print an informative message
136 before saving to clipboard manager.
138 2012-02-24 Chong Yidong <cyd@gnu.org>
140 * keyboard.c (process_special_events): Handle all X selection
141 requests in kbd_buffer, not just the next one (Bug#8869).
143 2012-02-23 Chong Yidong <cyd@gnu.org>
145 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
146 call when setting menu-bar-lines and tool-bar-lines parameters.
147 (unwind_create_frame_1): New helper function.
149 * window.c (inhibit_window_configuration_change_hook): New var.
150 (run_window_configuration_change_hook): Obey it.
151 (syms_of_window): Initialize it.
153 2012-02-22 Chong Yidong <cyd@gnu.org>
155 * xterm.c (x_draw_image_relief): Add missing type check for
156 Vtool_bar_button_margin (Bug#10743).
158 2012-02-21 Chong Yidong <cyd@gnu.org>
160 * fileio.c (Vfile_name_handler_alist): Doc fix.
162 * buffer.c (Fget_file_buffer): Protect against invalid file
163 handler return value.
165 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
167 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
168 when computing $valmask.
170 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
171 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
172 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
173 It's useless in that case, and it can cause problems on hosts
174 that allocate halves of EMACS_INT values separately.
175 Reported by Dan Horák. Diagnosed by Andreas Schwab in
176 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
177 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
178 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
179 it avoids undefined behavior on hosts where shifting right by more
180 than the word width has undefined behavior.
182 2012-02-19 Chong Yidong <cyd@gnu.org>
184 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
185 (Funhandled_file_name_directory, Ffile_name_as_directory)
186 (Fdirectory_file_name, Fexpand_file_name)
187 (Fsubstitute_in_file_name): Protect against invalid file handler
188 return values (Bug#10845).
190 2012-02-18 Eli Zaretskii <eliz@gnu.org>
192 * .gdbinit (pitx): Fix incorrect references to fields of the
195 2012-02-17 Chong Yidong <cyd@gnu.org>
197 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
199 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
201 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
202 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
204 2012-02-15 Chong Yidong <cyd@gnu.org>
206 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
207 marked as special. Also, starting docstrings with * is obsolete.
209 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
211 * gnutls.c (emacs_gnutls_write): Fix last change.
213 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
215 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
218 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
220 * keymap.c (Fsingle_key_description): Handle char ranges.
222 2012-02-12 Chong Yidong <cyd@gnu.org>
224 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
225 as that creates a dangerous corner case.
227 * window.c (Fdelete_window_internal): Invalidate the mouse
228 highlight (Bug#9904).
230 2012-02-12 Glenn Morris <rgm@gnu.org>
232 * xselect.c (Fx_own_selection_internal)
233 (Fx_get_selection_internal, Fx_disown_selection_internal)
234 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
235 * nsselect.m (Fx_own_selection_internal)
236 (Fx_disown_selection_internal, Fx_selection_exists_p)
237 (Fx_selection_owner_p, Fx_get_selection_internal):
238 Sync docs and argument specs with the xselect.c versions.
240 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
242 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
244 2012-02-11 Eli Zaretskii <eliz@gnu.org>
246 * w32select.c (Fx_selection_exists_p): Sync doc string and
247 argument list with xselect.c. (Bug#10783)
249 * w16select.c (Fx_selection_exists_p): Sync doc string and
250 argument list with xselect.c. (Bug#10783)
252 2012-02-10 Glenn Morris <rgm@gnu.org>
254 * fns.c (Fsecure_hash): Doc fix.
256 2012-02-09 Kenichi Handa <handa@m17n.org>
258 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
260 2012-02-07 Chong Yidong <cyd@gnu.org>
262 * buffer.c (Fbuffer_local_variables)
263 (buffer_lisp_local_variables): Handle unbound vars correctly;
264 don't let Qunbound leak into Lisp.
266 2012-02-07 Glenn Morris <rgm@gnu.org>
268 * image.c (Fimagemagick_types): Doc fix.
270 * image.c (imagemagick-render-type): Change it from a lisp object
271 to an integer. Move the doc here from the lisp manual.
272 Treat all values not equal to 0 the same.
274 2012-02-06 Chong Yidong <cyd@gnu.org>
276 * doc.c (store_function_docstring): Avoid applying docstring of
277 alias to base function (Bug#2603).
279 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
281 * .gdbinit (pp1, pv1): Remove redundant defines.
284 2012-02-04 Chong Yidong <cyd@gnu.org>
286 * nsterm.m: Declare a global (Bug#10694).
288 2012-02-04 Eli Zaretskii <eliz@gnu.org>
290 * w32.c (get_emacs_configuration_options):
291 Include --enable-checking, if specified, in the return value.
293 2012-02-04 Martin Rudalics <rudalics@gmx.at>
295 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
296 after rounding frame sizes. (Bug#9723)
298 2012-02-04 Eli Zaretskii <eliz@gnu.org>
300 * keyboard.c (adjust_point_for_property): Don't position point
301 before BEGV. (Bug#10696)
303 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
305 Handle overflow when computing char display width (Bug#9496).
306 * character.c (char_width): Return EMACS_INT, not int.
307 (char_width, c_string_width): Check for overflow when
308 computing the width; this is possible now that individual
309 characters can have unbounded width. Problem introduced
310 by merge from Emacs 23 on 2012-01-19.
312 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
314 * dbusbind.c (Fdbus_register_method): Mention the return value
315 :ignore in the docstring.
317 2012-02-02 Glenn Morris <rgm@gnu.org>
319 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
321 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
322 Unconditionally set to t. (Bug#10673)
323 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
324 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
325 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
327 2012-02-02 Kenichi Handa <handa@m17n.org>
329 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
330 0, do not call append_composite_glyph.
332 2012-02-02 Kenichi Handa <handa@m17n.org>
334 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
336 (x_produce_glyphs): If the component of a composition is a null
337 string, set it->pixel_width to 1 to avoid zero-width glyph.
339 2012-02-01 Eli Zaretskii <eliz@gnu.org>
341 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
342 first 2 arguments are identical. This makes inserting large
343 output from a subprocess an order of magnitude faster on
344 MS-Windows, where all sbrk'ed memory is always contiguous.
346 2012-01-31 Glenn Morris <rgm@gnu.org>
348 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
349 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
350 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
352 2012-01-29 Glenn Morris <rgm@gnu.org>
354 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
356 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
358 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
360 2012-01-28 Chong Yidong <cyd@gnu.org>
362 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
364 2012-01-26 Chong Yidong <cyd@gnu.org>
366 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
368 * search.c (Fsearch_forward, Fsearch_backward): Document negative
369 repeat counts (Bug#10507).
371 2012-01-26 Glenn Morris <rgm@gnu.org>
373 * lread.c (syms_of_lread): Doc fix.
375 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
377 * coding.c (encode_designation_at_bol): Change return value to
380 2012-01-25 Chong Yidong <cyd@gnu.org>
382 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
384 2012-01-21 Chong Yidong <cyd@gnu.org>
386 * floatfns.c (Fcopysign): Make the second argument non-optional,
387 since nil is not allowed anyway.
389 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
391 * process.c (read_process_output): Use p instead of XPROCESS (proc).
392 (send_process): Likewise.
394 2012-01-19 Martin Rudalics <rudalics@gmx.at>
396 * window.c (save_window_save, Fcurrent_window_configuration)
397 (Vwindow_persistent_parameters): Do not use Qstate.
400 2012-01-19 Kenichi Handa <handa@m17n.org>
402 * character.c (char_width): New function.
403 (Fchar_width, c_string_width, lisp_string_width):
404 Use char_width (Bug#9496).
406 2012-01-16 Martin Rudalics <rudalics@gmx.at>
408 * window.c (Vwindow_persistent_parameters): New variable.
409 (Fset_window_configuration, save_window_save): Handle persistent
412 2012-01-14 Eli Zaretskii <eliz@gnu.org>
414 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
415 thrashing the stack of the thread. (Bug#9087)
417 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
419 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
421 2012-01-11 Eli Zaretskii <eliz@gnu.org>
423 * xdisp.c (rows_from_pos_range): Handle the case where the
424 highlight ends on a newline. (Bug#10464)
425 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
426 he end column for display of highlight that ends on a newline
429 2012-01-11 Glenn Morris <rgm@gnu.org>
431 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
432 from load-path also when installation-directory is nil. (Bug#10208)
434 2012-01-10 Glenn Morris <rgm@gnu.org>
436 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
438 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
439 Update template values to be closer to their typical values these days.
441 2012-01-09 Eli Zaretskii <eliz@gnu.org>
443 * xdisp.c (rows_from_pos_range): Accept additional argument
444 DISP_STRING, and accept any glyph in a row whose object is that
445 string as eligible for mouse highlight. Fixes mouse highlight of
446 display strings from overlays. (Bug#10464)
448 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
450 emacs: fix an auto-save permissions race condition (Bug#10400)
451 * fileio.c (auto_saving_dir_umask): New static var.
452 (Fmake_directory_internal): Use it.
453 (do_auto_save_make_dir): Set it, instead of invoking chmod after
454 creating the directory. The old code temporarily assigns
455 too-generous permissions to the directory.
456 (do_auto_save_eh): Clear it.
457 (Fdo_auto_save): Catch all errors, not just file errors, so
458 that the var is always cleared.
460 2012-01-07 Eli Zaretskii <eliz@gnu.org>
462 * search.c (scan_buffer): Pass character positions to
463 know_region_cache, not byte positions. (Bug#6540)
465 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
467 * w32.c (sys_rename): Report EXDEV when rename of a directory
468 fails because the target is on another logical disk. (Bug#10284)
470 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
472 * xterm.c (x_embed_request_focus): New function.
474 * xterm.h: Add prototype.
476 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
478 2012-01-05 Glenn Morris <rgm@gnu.org>
480 * emacs.c (emacs_copyright): Update short copyright year to 2012.
482 2012-01-01 Eli Zaretskii <eliz@gnu.org>
484 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
485 Load gnutls_transport_set_lowat only if GnuTLS version is below
487 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
488 GnuTLS versions below 2.11.1.
490 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
492 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
493 to the doc string advising against its use for altering the way
494 windows are scrolled.
496 2011-12-28 Kenichi Handa <handa@m17n.org>
498 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
499 coding-system ASCII compatible only when it does not produce BOM
500 on encoding (Bug#10383).
502 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
504 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
506 (create_and_show_popup_menu): Always use menu_position_func for
509 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
511 * callint.c (Fcall_interactively): Don't truncate prompt string.
513 2011-12-23 Eli Zaretskii <eliz@gnu.org>
515 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
516 property that ends at ZV, so that the bidi iteration could be
517 resumed from there (after widening). (Bug#10360)
519 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
521 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
523 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
525 * nsterm.m (x_free_frame_resources):
526 Release f->output_data.ns->miniimage.
527 (ns_index_color): Fix indentation. Do not retain
528 color_table->colors[i].
530 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
533 * nsfns.m (x_set_background_color): Assign return value from
534 ns_index_color to face-background instead of NSColor*.
535 (ns_implicitly_set_icon_type): Fix indentation.
536 Change assignment in for loop to comparison.
538 * emacs.c (ns_pool): New variable.
539 (main): Assign ns_pool.
540 (Fkill_emacs): Call ns_release_autorelease_pool.
542 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
543 autorelease fdesc, release fdAttrs and tdict.
544 (ns_get_covering_families): Release charset.
545 (ns_findfonts): Release NSFontDescriptor created with new.
546 (ns_uni_to_glyphs): Fix indentation.
547 (setString): Release attrStr before assigning new value.
549 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
551 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
553 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
554 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
556 2011-12-18 David Reitter <reitter@cmu.edu>
558 * nsterm.m (ns_term_init): Subscribe for notifications
559 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
560 to method trackingNotification in EmacsMenu.
562 * nsmenu.m (trackingMenu): New variable.
563 (trackingNotification): New method (from Aquamacs).
564 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
565 from Aquamacs (Bug#7030).
567 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
569 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
570 (symbol_to_nsstring): Fix indentation.
571 (ns_symbol_to_pb): New function.
572 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
573 (Fns_rotate_cut_buffers_internal): Remove.
574 (Fns_store_selection_internal): Rename from
575 Fns_store_cut_buffer_internal.
576 (ns_get_foreign_selection, Fx_own_selection_internal)
577 (Fx_disown_selection_internal, Fx_selection_exists_p)
578 (Fns_get_selection_internal, Fns_store_selection_internal):
579 Use ns_symbol_to_pb and check if return value is nil.
580 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
581 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
582 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
583 renamed to Sns_store_selection_internal.
584 (ns_handle_selection_request): Move code to Fx_own_selection_internal
585 and remove this function.
586 (ns_handle_selection_clear): Remove, never used.
587 (Fx_own_selection_internal): Move code from ns_handle_selection_request
590 2011-12-17 Ken Brown <kbrown@cornell.edu>
592 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
593 GID is unknown (Bug#10257).
595 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
597 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
598 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
599 which caused a build failure on GNU/Linux IA-64. This problem was
600 introduced by my 2011-10-07 patch.
602 2011-12-15 Juri Linkov <juri@jurta.org>
604 * image.c (imagemagick_error): New function. (Bug#10112)
605 (imagemagick_load_image): Comment out `MagickSetResolution' call.
606 Use `imagemagick_error' where ImageMagick functions return
608 (Fimagemagick_types): Add `Fnreverse' to return the list in the
611 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
613 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
614 fill background (Bug#8992).
616 2011-12-13 Martin Rudalics <rudalics@gmx.at>
618 * window.c (Vwindow_combination_resize)
619 (Vwindow_combination_limit): Use t instead of non-nil in
621 (Vrecenter_redisplay): Add first sentence of doc-string on
623 (Frecenter): Fix doc-string typo.
625 2011-12-11 Kenichi Handa <handa@m17n.org>
627 * coding.c (Funencodable_char_position): Pay attention to the
628 buffer text relocation (Bug#9389).
630 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
632 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
633 gtk_init (Bug#10100).
635 2011-12-10 Eli Zaretskii <eliz@gnu.org>
637 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
638 IT->string is nil. (Bug#10263)
640 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
642 * nsterm.h (x_free_frame_resources): Declare.
644 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
645 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
647 * nsterm.h (ns_get_defaults_value): Declare.
649 * nsterm.m (ns_default): Call ns_get_defaults_value.
651 2011-12-09 Eli Zaretskii <eliz@gnu.org>
653 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
656 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
658 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
659 that where the value of an _OBJC_* symbol points to is in the .bss
662 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
664 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
665 after the loop to call ccl_driver at least once (Bug#8619).
667 2011-12-08 Kenichi Handa <handa@m17n.org>
669 * ftfont.c (get_adstyle_property): Fix previous change
672 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
674 * w32.c (init_environment): If no_site_lisp, remove site-lisp
675 dirs from the default value of EMACSLOADPATH (bug#10208).
677 2011-12-07 Glenn Morris <rgm@gnu.org>
679 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
680 installation and source directories as well. (Bug#10208)
682 2011-12-06 Chong Yidong <cyd@gnu.org>
684 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
686 2011-12-06 Glenn Morris <rgm@gnu.org>
688 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
689 as an error, not just -1. (Bug#10217)
691 2011-12-05 Chong Yidong <cyd@gnu.org>
693 * keyboard.c (process_special_events): New function.
694 (swallow_events, Finput_pending_p): Use it (Bug#10195).
696 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
698 * coding.c (encode_designation_at_bol): Don't use uninitialized
699 local variable (Bug#9318).
701 2011-12-05 Kenichi Handa <handa@m17n.org>
703 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
704 return Qnil (Bug#8046, Bug#10193).
706 2011-12-05 Kenichi Handa <handa@m17n.org>
708 * coding.c (encode_designation_at_bol): New args charbuf_end and
709 dst. Return the number of produced bytes. Callers changed.
710 (coding_set_source): Return how many bytes coding->source was
712 (coding_set_destination): Return how many bytes
713 coding->destination was relocated.
714 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
715 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
717 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
719 * coding.c (CODING_CHAR_CHARSET_P): New macro.
720 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
723 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
725 The following changes are to fix Bug#9318.
727 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
728 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
729 (encode_coding_iso_2022, encode_coding_sjis)
730 (encode_coding_big5, encode_coding_charset): Use the above macros.
732 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
734 * lisp.h (process_quit_flag): Fix external declaration.
736 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
738 Don't macro-inline non-performance-critical code.
739 * eval.c (process_quit_flag): New function.
740 * lisp.h (QUIT): Use it.
742 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
744 * nsfns.m (get_geometry_from_preferences): New function.
745 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
747 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
749 * emacs.c (Qkill_emacs): Define.
750 (syms_of_emacs): Initialize it.
751 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
752 Qquit_flag to `kill-emacs' instead.
753 (quit_throw_to_read_char): Add parameter `from_signal'.
754 All callers changed. Call Fkill_emacs if requested and safe.
755 * lisp.h (QUIT): Call Fkill_emacs if requested.
757 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
759 * widget.c (update_wm_hints): Return if wmshell is null.
760 (widget_update_wm_size_hints): New function.
762 * widget.h (widget_update_wm_size_hints): Declare.
764 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
765 widget_update_wm_size_hints (Bug#10104).
767 2011-12-03 Eli Zaretskii <eliz@gnu.org>
769 * xdisp.c (handle_invisible_prop): If the invisible text ends just
770 before a newline, prepare the bidi iterator for consuming the
771 newline, and keep the current paragraph direction. (Bug#10183)
772 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
774 2011-12-02 Juri Linkov <juri@jurta.org>
776 * search.c (Fword_search_regexp): New Lisp function created from
777 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
778 (Fword_search_backward, Fword_search_forward)
779 (Fword_search_backward_lax, Fword_search_forward_lax):
780 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
781 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
783 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
785 * fileio.c (Finsert_file_contents): Move after-change-function call
786 to before the "handled:" label, since all "goto handled" appear in
787 cases where the *-change-functions have already been properly called
790 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
792 * keyboard.c (interrupt_signal): Don't call kill-emacs when
793 waiting for input. (Bug#10169)
795 2011-11-30 Eli Zaretskii <eliz@gnu.org>
797 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
798 verifies glyph row's hash code--we have just reallocated the
799 glyphs, so their contents can be complete garbage. (Bug#10164)
801 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
803 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
805 2011-11-30 Eli Zaretskii <eliz@gnu.org>
807 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
808 attributes are tested _before_ calling verify_row_hash, to protect
809 against GCC re-ordering of the tests. (Bug#10164)
811 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
813 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
815 * xterm.c (handle_one_xevent): Only set async_visible and friends
816 if net_wm_state_hidden_seen is non-zero (Bug#10002)
817 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
818 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
820 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
822 Remove GCPRO-related macros that exist only to avoid shadowing locals.
823 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
824 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
825 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
826 All uses changed to use GCPRO1 etc.
827 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
828 Revert to old implementation (i.e., before 2011-03-11).
830 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
832 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
833 of scroll runs so as to avoid assigning disabled bogus rows and
834 unnecessary graphics copy operations.
836 2011-11-27 Eli Zaretskii <eliz@gnu.org>
838 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
839 (snprintf) [_MSC_VER]: Redirect to _snprintf.
840 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
841 (malloc, free, realloc, calloc): Redirect to e_* only when
844 * lisp.h (GCTYPEBITS): Move before first use.
845 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
846 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
847 this macro definition.
849 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
852 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
854 * gtkutil.c (xg_create_frame_widgets):
855 Call gtk_window_set_has_resize_grip (FALSE) if that function is
856 present with Gtk+ 2.0.
858 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
860 * fileio.c (Finsert_file_contents): Undo previous change; see
861 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
863 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
865 Rename locals to avoid shadowing.
866 * fileio.c (Finsert_file_contents):
867 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
868 * process.c (wait_reading_process_output):
869 Rename inner 'proc' to 'p' to avoid shadowing.
870 Indent for consistency with usual Emacs style.
872 2011-11-25 Eli Zaretskii <eliz@gnu.org>
874 * xdisp.c (redisplay_window): If cursor row is not fully visible
875 after recentering, and scroll-conservatively is set to a large
876 number, scroll window by a few more lines to make the cursor fully
877 visible and out of scroll-margin. (Bug#10105)
878 (start_display): Don't move to the next line if the display should
879 start at a newline that is part of a display vector or an overlay
882 2011-11-24 Juri Linkov <juri@jurta.org>
884 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
885 after the `MagickPingImage' call. (Bug#10112)
887 2011-11-23 Chong Yidong <cyd@gnu.org>
889 * window.c (Fcoordinates_in_window_p): Accept only live windows.
891 2011-11-23 Martin Rudalics <rudalics@gmx.at>
893 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
894 making another buffer current. (Bug#10114)
896 2011-11-23 Glenn Morris <rgm@gnu.org>
898 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
900 2011-11-23 Chong Yidong <cyd@gnu.org>
902 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
905 2011-11-22 Eli Zaretskii <eliz@gnu.org>
907 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
908 and header-lines, as they don't have one computed for them.
911 * .gdbinit (prow): Make displayed values more self-explaining.
914 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
916 * process.c (wait_reading_process_output): Fix asynchrounous
917 GnuTLS socket handling on some versions of the GnuTLS library.
918 (wait_reading_process_output): Add comment and URL.
920 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
922 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
924 2011-11-21 Chong Yidong <cyd@gnu.org>
926 * window.c (Fnext_window, Fprevious_window): Doc fix.
928 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
930 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
932 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
934 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
936 2011-11-20 Martin Rudalics <rudalics@gmx.at>
938 * window.c (Fset_window_combination_limit): Rename argument
940 (Vwindow_combination_limit): Remove "status" from doc-string.
942 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
944 * m/ibms390.h: Remove.
945 * m/ibms390x.h: Don't include "ibms390.h".
947 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
949 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
950 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
952 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
954 * casetab.c (Fset_case_table):
955 * charset.c (Fcharset_after): Fix typos.
957 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
959 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
960 Otherwise, valgrind does not work on some platforms.
961 Problem reported by Andreas Schwab in
962 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
963 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
964 is set, removing the need for VIRT_ADDRESS_VARIES.
965 (PURE_P): Use a more-efficient implementation that needs just one
966 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
967 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
968 to 4 (xorl, subq, cmpq, setbe).
969 * alloc.c (pure): Always extern now, since that's the
970 VIRT_ADDR_VARIES behavior.
971 (PURE_POINTER_P): Use a single comparison, not two, for
972 consistency with the new puresize.h.
973 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
974 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
975 Remove VIRT_ADDR_VARIES no longer needed.
977 2011-11-19 Eli Zaretskii <eliz@gnu.org>
979 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
980 (erase_phys_cursor, update_window_cursor, show_mouse_face)
981 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
982 behave as if the cursor position were at the window margin.
984 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
985 and the cursor position is out of bounds, behave as if the cursor
986 position were at the window margin. (Bug#10075)
988 2011-11-18 Chong Yidong <cyd@gnu.org>
990 * window.c (Fwindow_combination_limit): Make first argument
991 non-optional, since it is meaningless for live windows like the
994 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
996 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
998 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1000 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1001 (graft_intervals_into_buffer): Simplify.
1003 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1005 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1006 hash values of the two rows.
1007 (copy_row_except_pointers): Preserve the used[] arrays and the
1008 hash values of the two rows. (Bug#10035)
1009 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1011 * xdisp.c (row_hash): New function, body extracted from
1012 compute_line_metrics.
1013 (compute_line_metrics): Call row_hash, instead of computing the
1016 * dispnew.c (verify_row_hash): Call row_hash for computing the
1017 hash code of a row, instead of duplicating code from xdisp.c.
1019 * dispextern.h (row_hash): Add prototype.
1021 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1023 * frame.c (delete_frame): Don't delete the terminal when the last
1024 X frame is closed if emacs is built with GTK toolkit.
1026 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1028 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1030 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1032 * window.c (Vwindow_splits): Rename to
1033 Vwindow_combination_resize. Suggested by Juri Linkov.
1034 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1037 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1039 * nsfns.m (Fns_font_name):
1040 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1042 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1044 * window.h (window): Rename slot "nest" to "combination_limit".
1045 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1046 (Fset_window_nest): Rename to Fset_window_combination_limit.
1047 (Vwindow_nest): Rename to Vwindow_combination_limit.
1048 (recombine_windows, make_parent_window, make_window)
1049 (Fsplit_window_internal, saved_window)
1050 (Fset_window_configuration, save_window_save): Rename all
1051 occurrences of window_nest to window_combination_limit.
1053 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1055 * image.c (imagemagick_load_image): Fix typo.
1057 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1059 * xdisp.c (display_line): Move the call to
1060 highlight_trailing_whitespace before the call to
1061 compute_line_metrics, since the latter needs to see the final
1062 faces of all the glyphs to compute ROW's hash value.
1063 Fixes assertion violations in row_equal_p. (Bug#10035)
1065 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1067 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1068 just return (bug#10044).
1070 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1072 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1073 with user-defined heap size. Bump the default size of the temacs
1074 heap to 27MB, to avoid memory warning when running temacs.
1075 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1077 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1078 current_matrix and desired_matrix. (Bug#9990)
1079 (verify_row_hash) [XASSERTS]: New function.
1080 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1081 that the hash value of glyph rows is correct.
1083 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1085 * window.h (window): Remove splits slot.
1086 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1087 (Fdelete_other_windows_internal, make_parent_window)
1088 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1089 (Fset_window_configuration, save_window_save): Don't deal with
1090 split status of windows.
1091 (saved_window): Remove splits slot.
1092 (Vwindow_splits): Rewrite doc-string.
1094 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1096 * xfns.c (unwind_create_frame):
1097 * nsfns.m (unwind_create_frame):
1098 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1099 Vframe_list (Bug#9999).
1101 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1103 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1105 2011-11-11 Kenichi Handa <handa@m17n.org>
1107 * callproc.c (Fcall_process): Set the member dst_multibyte of
1110 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1112 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1113 avoid a crash (bug#9496).
1115 2011-11-09 Chong Yidong <cyd@gnu.org>
1117 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1118 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1120 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1122 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1124 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1126 Avoid some portability problems by eschewing 'extern inline' functions.
1127 The trivial performance wins aren't worth the portability hassles; see
1128 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1130 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1131 (window_box_width, window_box_left, window_box_left_offset)
1132 (window_box_right, window_box_right_offset): Undo previous change,
1133 by removing the "extern"s.
1134 * intervals.c (adjust_intervals_for_insertion)
1135 (adjust_intervals_for_deletion): Undo previous change,
1136 making these static again.
1137 (offset_intervals, temp_set_point_both, temp_set_point)
1138 (copy_intervals_to_string): No longer inline.
1139 * xdisp.c (window_text_bottom_y, window_box_width)
1140 (window_box_height, window_box_left_offset)
1141 (window_box_right_offset, window_box_left, window_box_right)
1142 (window_box): No longer inline.
1144 2011-11-08 Chong Yidong <cyd@gnu.org>
1146 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1147 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1148 Signal an error if not a live window.
1149 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1150 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1152 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1154 * lisp.h (syms_of_abbrev): Remove declaration.
1155 Reported by CHENG Gao <chenggao@royau.me>.
1157 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1159 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1160 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1161 of temacs in GUI mode.
1163 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1165 * window.h: Declare delete_all_child_windows instead of
1166 delete_all_subwindows.
1167 * window.c (Fwindow_nest, Fset_window_nest)
1168 (Fset_window_new_total, Fset_window_new_normal)
1169 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1170 (delete_all_subwindows): Rename to delete_all_child_windows.
1171 (Fdelete_other_windows_internal, Fset_window_configuration):
1172 Call delete_all_child_windows instead of delete_all_subwindows.
1173 * frame.c (delete_frame): Call delete_all_child_windows instead
1174 of delete_all_subwindows.
1176 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1178 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1179 This is also needed for porting to any host where GC_MARK_STACK is
1180 not GC_MAKE_GCPROS_NOOPS.
1181 (which_symbols): Use it.
1183 2011-11-07 Kenichi Handa <handa@m17n.org>
1185 * coding.c (coding_set_destination): Check coding->src_pos only
1186 when coding->src_object is a buffer (bug#9910).
1188 * process.c (send_process): Set the member src_multibyte of coding
1189 to 0 (bug#9911) when sending a unibyte text.
1191 * callproc.c (Fcall_process): Set the member src_multibyte of
1192 process_coding to 0 (bug#9912).
1194 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1196 * xmenu.c (cleanup_widget_value_tree): New function.
1197 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1198 calling free_menubar_widget_value_tree directly (Bug#9830).
1200 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1202 Fix some portability problems with 'inline'.
1203 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1204 (window_box_width, window_box_left, window_box_left_offset)
1205 (window_box_right, window_box_right_offset): Declare extern.
1206 Otherwise, these inline functions do not conform to C99 and
1207 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1208 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1209 * intervals.c (adjust_intervals_for_insertion)
1210 (adjust_intervals_for_deletion): Now extern, because otherwise the
1211 extern inline functions 'offset_intervals' couldn't refer to it.
1212 (static_offset_intervals): Remove.
1213 (offset_intervals): Rewrite using the old contents of
1214 static_offset_intervals. The old version didn't conform to C99
1215 because an extern inline function contained a reference to an
1216 identifier with static linkage.
1218 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1220 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1223 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1225 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1226 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1227 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1228 return Qleft_to_right.
1230 2011-11-06 Chong Yidong <cyd@gnu.org>
1232 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1233 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1234 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1235 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1236 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1237 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1238 (Fwindow_vscroll): Doc fix.
1239 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1240 argument, since it makes no sense to pass a live window and for
1241 consistency with window-child.
1243 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1245 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1248 2011-11-05 Jason Rumney <jasonr@gnu.org>
1250 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1251 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1253 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1254 bitwise arithmetic preventing use of unicode-sip and non-truetype
1257 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1259 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1262 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1263 initialization code to keep similarity to xfns.c after changes
1266 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1268 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1269 (unwind_create_frame): New function (Bug#9943).
1270 (Fx_create_frame): Restructure code to be more similar to the one in
1271 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1272 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1273 Move terminal->reference_count++ just before making the frame official
1276 * nsterm.m (x_free_frame_resources): New function.
1277 (x_destroy_window): Move code to x_free_frame_resources.
1279 * xfns.c (unwind_create_frame): Fix comment.
1280 (Fx_create_frame, x_create_tip_frame):
1281 Move terminal->reference_count++ just before making the frame
1282 official. Move initialization of image_cache_refcount and
1283 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1285 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1287 Support MSVC build with newer versions of Visual Studio.
1288 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1289 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1292 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1293 which are not supported by MSVC.
1294 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1295 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1297 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1299 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1301 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1303 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1305 Support MSVC build with newer versions of Visual Studio.
1306 * w32.c: Don't include w32api.h for MSVC.
1307 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1309 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1310 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1311 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1312 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1314 (alloca) [_MSC_VER]: Define to _alloca.
1316 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1318 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1320 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1322 * xdisp.c (note_mouse_highlight): If either of
1323 previous/next-single-property-change returns nil, treat that as
1324 the beginning or the end of the buffer. (Bug#9955)
1326 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1328 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1329 label is not null (Bug#9951).
1330 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1333 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1335 * window.c (Fwindow_body_size): Mention in the doc string that the
1336 return value is in frame's canonical units. (Bug#9949)
1338 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1340 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1342 * w32fns.c (unwind_create_frame): If needed, free the glyph
1343 matrices of the partially constructed frame. (Bug#9943)
1344 * xfns.c (unwind_create_frame): Likewise.
1346 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1348 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1349 Don't stop backward scan on the continuation glyph, even though
1350 its CHARPOS is positive.
1351 (mouse_face_from_buffer_pos, note_mouse_highlight):
1352 Rename cover_string to disp_string.
1354 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1356 * window.c (temp_output_buffer_show): Don't use
1357 Vtemp_buffer_show_specifiers.
1358 (Vtemp_buffer_show_specifiers): Remove unused variable.
1360 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1362 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1363 past the beginning of the current glyph matrix.
1365 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1367 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1368 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1369 HAVE_GTK3 (Bug#9869).
1371 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1372 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1374 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1376 * xterm.c: Declare x_handle_net_wm_state to return int.
1377 (handle_one_xevent): Check if we are iconified but don't have
1378 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1379 (get_current_wm_state): Return non-zero if not hidden,
1380 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1381 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1382 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1383 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1385 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1387 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1388 so that this new function doesn't get optimized away by a
1389 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1391 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1393 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1395 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1397 Fix the `xbytecode' command.
1398 * .gdbinit (xprintbytestr): New command.
1399 (xwhichsymbols): Rename from `which'; all callers changed.
1400 (xbytecode): Print the byte-code string as well.
1402 2011-10-29 Kim Storm <storm@cua.dk>
1404 * alloc.c (which_symbols): New function.
1406 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1408 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1411 2011-10-29 Glenn Morris <rgm@gnu.org>
1413 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1414 Not clear what it was for, and it causes various bugs. (Bug#9839)
1416 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1418 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1419 possible random value that matches one of those tested as
1420 condition to clear the mouse face.
1422 2011-10-28 Chong Yidong <cyd@gnu.org>
1424 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1426 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1428 * window.c (make_window): Initialize phys_cursor_on_p.
1430 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1432 * lisp.h (struct Lisp_Symbol): Update comments.
1434 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1436 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1438 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1440 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1441 <oslsachem@gmail.com> for helping to debug this.
1443 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1444 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1445 (g_b_init_get_glyph_outline_w): New static variables.
1446 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1447 (GetGlyphOutlineW_Proc): New typedefs.
1448 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1449 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1451 (w32font_open_internal, compute_metrics):
1452 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1453 instead of calling the "wide" APIs directly.
1455 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1457 * w32.h (syms_of_w32font): Add prototype.
1459 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1461 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1462 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1463 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1464 (Fmove_to_window_line): Doc fix.
1466 2011-10-27 Chong Yidong <cyd@gnu.org>
1468 * process.c (make_process): Set gnutls_state to NULL.
1470 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1471 non-NULL, regardless of GNUTLS_INITSTAGE.
1472 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1473 an error. Set process slots as soon as we allocate them.
1475 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1477 2011-10-27 Chong Yidong <cyd@gnu.org>
1479 * gnutls.c (emacs_gnutls_deinit): New function.
1480 Deallocate credentials structures as well as calling gnutls_deinit.
1481 (Fgnutls_deinit, Fgnutls_boot): Use it.
1483 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1484 (deactivate_process): Call emacs_gnutls_deinit.
1486 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1488 * image.c (x_create_x_image_and_pixmap):
1489 * w32.c (sys_rename, w32_delayed_load):
1490 * w32font.c (fill_in_logfont):
1491 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1493 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1495 * w32fns.c (w32_default_color_map): New function,
1496 extracted from Fw32_default_color_map.
1497 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1499 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1501 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1503 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1505 * keyboard.c (test_undefined): New function (bug#9751).
1506 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1508 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1510 * sysdep.c (init_sys_modes): Fix the check for the controlling
1511 terminal (Bug#6649).
1513 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1515 * dispextern.h (struct bidi_it): New member next_en_type.
1517 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1518 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1519 current character, check also for next_en_type being WEAK_EN.
1520 (bidi_resolve_weak): Don't enter the expensive loop if the current
1521 position is before next_en_pos. Record the bidi type of the first
1522 non-ET, non-BN character we find, in addition to its position.
1523 (bidi_level_of_next_char): Invalidate next_en_type when
1524 next_en_pos is over-stepped.
1526 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1528 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1529 * editfns.c: Rewrite current-time-zone so that it invokes
1530 the equivalent of (format-time-string "%Z") to get the time zone name.
1531 This fixes a bug when the time zone name contains characters that
1532 need converting from the system time locale to Emacs internal format.
1533 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1534 that patch fixed format-time-string to do the conversion, but
1535 I forgot to fix current-time-zone.
1536 (format_time_string): New function, containing most of
1537 what Fformat_time_string used to contain.
1538 (Fformat_time_string): Rewrite in terms of format_time_string.
1539 This doesn't change this function's behavior.
1540 (current-time-zone): Rewrite to use format_time_string.
1541 This fixes the bug reported by Michael Schierl in
1542 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1543 Jason Rumney's 2007-06-07 change worked around this bug, but
1545 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1547 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1549 * xdisp.c (start_display): If the character at POS is displayed
1550 via a display vector, reset IT->current.dpvec_index to zero.
1551 (try_window_reusing_current_matrix): If a line ends in a display
1552 vector or the next line starts in a display vector, continue
1553 redrawing the window even though the character position of
1554 start_row was reached.
1557 2011-10-18 Chong Yidong <cyd@gnu.org>
1559 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1560 with nobreak-char-display too.
1562 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1564 Fix part 3 of bug#9771.
1565 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1566 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1567 non-neutral characters if the current character is a paragraph
1568 separator (a.k.a. Newline). This avoids running the same
1569 expensive loop twice, once when we consume the preceding newline
1570 and the other time when the line actually needs to be displayed.
1571 Avoid the loop when we see neutrals on the base embedding level
1572 following a character whose directionality is the same as the
1573 paragraph's. This avoids running the expensive loop when a line
1574 ends in a long sequence of neutrals, like control characters.
1575 Add assertion against STRONG_AL type. Slightly rearrange code
1576 that determines the type of a neutral given the first non-neutral
1578 (bidi_level_of_next_char): Set next_en_pos to zero when
1579 invalidating its info.
1581 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1583 * xdisp.c (push_display_prop): Determine whether to record string
1584 or buffer position by IT->string, not by IT->method. Allow
1585 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1586 (move_it_vertically_backward): Don't look for character position
1587 immediately after the newline when in a continuation line.
1590 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1592 * window.c (coordinates_in_window): Rewrite and delabelize
1593 vertical border check. (Bug#5357) (Bug#9618)
1595 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1597 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1598 errors in XSetWindowBorder (bug#9310).
1600 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1602 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1603 avoid crash when xmalloc overrun checking is enabled.
1605 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1607 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1608 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1609 cursor motion with <left> and <right> arrow keys.
1611 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1612 some callers set that themselves.
1614 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1616 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1617 display string and the previous row comes from the same string and
1618 is empty. (Bug#9739) (Bug#9738)
1620 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1622 * doc.c (get_doc_string): Encode file name (bug#9735).
1624 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1626 * bidi.c (bidi_level_of_next_char):
1627 * xdisp.c (get_visually_first_element): Remove old incorrect
1628 comments regarding the Unicode Line Separator character.
1630 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1632 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1634 * alloc.c (Fgc_status): Do not access beyond zombies array
1635 boundary if nzombies > MAX_ZOMBIES.
1636 * alloc.c (dump_zombies): Add missing format specifier.
1638 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1640 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1641 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1643 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1644 Some packages use them to denote characters with modifiers.
1646 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1648 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1649 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1650 matching a pp-number. Rename parameter var to var1.
1652 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1654 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1656 2011-10-08 Glenn Morris <rgm@gnu.org>
1658 * callint.c (Fcall_interactively): Give a more explicit error for the
1659 'c' case with a non-character input. (Bug#8479)
1661 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1663 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1665 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1666 lines that are hscrolled on the left.
1668 * dispnew.c (buffer_posn_from_coords): Account for a possible
1669 presence of header-line. (Bug#4426)
1671 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1673 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1674 Don't advertise functionality which we discourage or doesn't work.
1676 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1678 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1679 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1680 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1681 this makes Emacs dump core during garbage collection on rare
1682 occasions. sizeof is obviously inferior to offsetof here, so
1683 stick with offsetof.
1684 (GC_POINTER_ALIGNMENT): New macro.
1685 (mark_memory): Omit 3rd (offset) arg; caller changed.
1686 Don't assume EMACS_INT alignment is the same as pointer alignment.
1688 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1690 * keyboard.c (read_key_sequence_remapped): New var.
1691 (read_key_sequence): Compute remapping in the right buffer.
1692 (command_loop_1): Use read_key_sequence's remapping directly.
1694 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1696 * dired.c (file_name_completion): Don't expand file name.
1697 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1698 before checking file name handler.
1700 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1701 they've been requested explicitly (bug#9591).
1703 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1705 * keymap.c (Fsingle_key_description): Use make_specified_string
1706 instead of build_string to build string from push_key_description.
1709 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1711 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1712 This fixes a Y2038 bug on 64-bit hosts.
1713 * buffer.c (reset_buffer):
1714 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1715 (Fclear_buffer_auto_save_failure):
1716 Use 0, not -1, to represent an unset failure time, since time_t
1717 might not be signed.
1719 Remove dependency on glibc malloc internals.
1720 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1721 Move back here from lisp.h, but with their new implementations.
1722 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1723 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1724 * charset.c (charset_table_init): New static var.
1725 (syms_of_charset): Use it instead of xmalloc. This removes a
1726 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1727 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1728 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1729 Move back to alloc.c.
1730 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1731 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1733 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1735 * nsterm.m (windowDidResize): Call x_set_window_size only when
1736 ns_in_resize is true. Otherwise set pixelwidth/height and
1737 call change_frame_size (Bug#9628).
1739 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1741 Port --enable-checking=all to Fedora 14 x86-64.
1742 * charset.c (syms_of_charset): Also account for glibc malloc's
1743 internal overhead when calculating the initial malloc maximum.
1745 Port --enable-checking=all to Fedora 14 x86.
1746 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1748 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1749 (overrun_check_realloc, overrun_check_free):
1750 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1751 That way, xmalloc returns a properly-aligned pointer even if
1752 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1753 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1754 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1755 into account when calculating the initial malloc maximum.
1756 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1757 Move here from alloc.c, so that charset.c can use it too.
1758 Properly align; the old code wasn't right for common 32-bit hosts
1759 when configured with --enable-checking=all.
1760 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1761 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1763 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1765 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1768 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1770 * xdisp.c (compute_display_string_end): If there's no display
1771 string at CHARPOS, return -1.
1773 * bidi.c (bidi_fetch_char): When compute_display_string_end
1774 returns a negative value, treat the character as a normal
1775 character not covered by a display string. (Bug#9624)
1777 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1779 * lread.c (Fread_from_string): Fix typo in docstring.
1781 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1783 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1784 newline, reseat the iterator instead of bidi-iterating there one
1785 character at a time. (Bug#9610)
1786 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1787 TO_CHARPOS if the bidi iterator is at base embedding level.
1789 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1791 * lread.c (readevalloop): Use correct code for NBSP.
1792 (read1): Likewise. (Bug#9608)
1794 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1796 * dbusbind.c (Fdbus_register_signal): When service is not
1797 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1799 2011-09-25 Glenn Morris <rgm@gnu.org>
1801 * buffer.c (truncate-lines): Doc fix.
1803 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1805 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1806 (Fset_window_next_buffers): Doc fix.
1808 2011-09-24 Glenn Morris <rgm@gnu.org>
1810 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1812 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1814 Fix minor problems found by static checking.
1815 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1816 * indent.c (Fvertical_motion): Fix == vs = typo.
1818 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1820 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1821 Default value is now t. Doc fix.
1823 * indent.c (Fvertical_motion): Compute and apply the overshoot
1824 logic when moving up, not only when moving down. Fix the
1825 confusing name and values of the it_overshoot_expected variable;
1826 logic changes accordingly. (Bug#9254) (Bug#9549)
1828 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1829 CHARPOS is covered by a display string which includes newlines.
1830 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1831 is covered by a display string with embedded newlines.
1833 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1835 * dbusbind.c (Fdbus_register_signal): Add match rule to
1836 Vdbus_registered_objects_table. (Bug#9581)
1837 (Fdbus_register_method, Vdbus_registered_objects_table):
1840 2011-09-24 Jim Meyering <meyering@redhat.com>
1842 do not ignore write error for any output size
1843 The previous change was incomplete.
1844 While it makes emacs --batch detect the vast majority of stdout
1845 write failures, errors were still ignored whenever the output size is
1846 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1847 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1848 && echo FAIL: ignored write error
1849 FAIL: ignored write error
1850 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1851 && echo FAIL: ignored write error
1852 FAIL: ignored write error
1853 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1855 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1857 * emacs.c (Fkill_emacs): In noninteractive mode exit
1858 non-successfully if a write error occurred on stdout. (Bug#9574)
1860 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1862 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1865 * dispextern.h (struct it): Update the comment documenting what
1868 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1870 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1871 a display string, extend search for cursor position to end of row.
1872 (find_row_edges): If the row ends in a newline from a display
1873 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1874 Handle the case of a display string with multiple newlines.
1875 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1876 non-empty line. Fixes confusing cursor motion with arrow keys at
1877 the beginning of a line that starts with whitespace.
1879 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1881 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1884 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1886 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1889 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1891 * xdisp.c (display_line): Record maximum and minimum buffer
1892 positions even if no glyphs were produced (e.g., by a zero-width
1893 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1894 buffer positions that will be removed from the glyph row because
1896 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1897 column is beyond frame width: don't subtract 1 "pixel" when
1898 computing width of the stretch.
1899 (reseat_at_next_visible_line_start): Undo the change made on
1900 2011-09-17 that saved paragraph information and restored it after
1901 the call to `reseat'. (Bug#9545)
1903 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1905 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1906 and turn window cursor on if cleared (Bug#9415).
1908 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1910 * search.c (boyer_moore): Take unibyte characters from pattern
1911 literally. (Bug#9458)
1913 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1915 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1917 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1919 Fix minor problem found by static checking.
1920 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1921 initialized, to pacify gcc -Wuninitialized.
1923 * fileio.c: Report proper errno when syscall falls.
1924 (Finsert_file_contents): Save and restore errno,
1925 so that report_file_error outputs the correct diagnostic.
1926 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1928 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1930 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1932 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1935 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1937 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1939 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1940 about the current paragraph and restore it after the call to reseat.
1942 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1943 (bidi_find_paragraph_start): Search back for paragraph beginning
1944 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1945 (bidi_move_to_visually_next): Only trigger paragraph-related
1946 computations when the last character is a newline or at EOB, not
1947 just any NEUTRAL_B. (Bug#9470)
1949 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1950 truncated lines if point is covered by a display string. (Bug#9524)
1952 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1954 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1955 (cons_to_x_long): New function.
1956 (lisp_data_to_selection_data): Use it. Correct the test for
1957 short-versus-long data; it was negated. Break out of vector
1958 loop, for efficiency, when a long datum is discovered.
1960 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1962 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1964 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1966 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1967 GCC PR/17406) by declaring this function with external scope.
1969 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1971 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1972 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1974 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1976 * editfns.c (Fformat): Correctly handle text properties on "%%".
1978 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1980 * xterm.c (x_draw_composite_glyph_string_foreground):
1981 * w32term.c (x_draw_composite_glyph_string_foreground):
1982 * term.c (encode_terminal_code):
1983 * composite.c (composition_update_it, get_composition_id):
1984 * xdisp.c (get_next_display_element)
1985 (fill_composite_glyph_string): Add comments about special meaning
1986 of TAB characters in a composition.
1988 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1990 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1991 This occurs when processing a multibyte format.
1992 Problem reported by Wolfgang Jenker.
1994 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1996 * xdisp.c (try_cursor_movement): Only check for exact match if
1997 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1999 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2001 Remove unused external symbols.
2002 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2003 * xdisp.c (calc_pixel_width_or_height): Now static.
2004 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2005 * indent.c (check_display_width):
2006 * w32term.c: Fix comment to match code.
2007 * xterm.c, xterm.h (x_catching_errors): Remove.
2009 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2011 * xselect.c: Use signed conversions more consistently (Bug#9498).
2012 (selection_data_to_lisp_data): Assume incoming selection data are
2013 signed integers, not unsigned. This is to be consistent with
2014 outgoing selection data, which was modified to use signed integers
2015 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2016 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2017 expects long, not unsigned long.
2019 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2021 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2022 computation of loop end. Reported by Johan Bockgård
2025 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2027 * frame.c (Fother_visible_frames_p): Function deleted.
2029 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2031 * indent.c (compute_motion): Process display vector front to back
2032 rather than the other way around. (Bug#2496)
2034 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2036 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2038 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2040 * minibuf.c (Fread_from_minibuffer): Doc fix.
2042 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2044 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2045 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2047 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2049 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2050 value for non-existent files.
2052 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2054 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2055 set its "size" to -1. This will set the modtime_size field of
2056 the corresponding buffer to -1, which is what
2057 verify-visited-file-modtime expects for files that do not exist.
2060 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2062 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2064 * lisp.h: ... from here. push_key_description is no longer
2065 defined in keyboard.c, so its declaration should not be in
2066 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2067 logically belongs with push_key_description.
2069 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2071 * buffer.h: Include <sys/types.h> instead of <time.h>.
2072 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2073 Problem reported by Herbert J. Skuhra.
2075 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2077 * xml.c (parse_region): Make the parsing work for
2078 non-comment-starting XML files again (bug#9144).
2080 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2082 * image.c (gif_load): Fix calculation of bottom and right corner.
2085 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2087 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2088 redisplay in small windows.
2090 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2092 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2094 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2096 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2097 Operate on live windows only.
2099 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2101 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2103 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2105 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2106 only under bidi iteration.
2108 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2110 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2112 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2114 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2115 Without this fix, the command to link temacs failed due to an
2116 undefined symbol __builtin_isnan. This is because
2117 /usr/include/iso/math_c99.h #defines isnan(x) to
2118 __builtin_isnan(x), but the bundled gcc, which identifies itself
2119 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2121 * floatfns.c (isnan): #undef, and then #define to a clone of
2123 (Fisnan): Always define, since it's always available now.
2124 (syms_of_floatfns): Always define isnan at the Lisp level.
2126 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2128 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2130 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2132 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2133 The previous code assumed that file offsets (off_t values) fit in
2134 EMACS_INT variables, which is not true on typical 32-bit hosts.
2135 The code messed up by falsely reporting buffer overflow in cases
2136 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2137 when "big" contains more than 2**29 bytes, even though this
2138 inserts just one byte and does not overflow the buffer.
2139 (Finsert_file_contents): Store file offsets as off_t
2140 values, not as EMACS_INT values. Check for overflow when
2141 converting between EMACS_INT and off_t. When checking for
2142 buffer overflow or for overlap, take the offsets into account.
2143 Don't use EMACS_INT for small values where int suffices.
2144 When checking for overlap, fix a typo: ZV was used where
2145 ZV_BYTE was intended.
2146 (Fwrite_region): Don't assume off_t fits into 'long'.
2147 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2149 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2151 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2153 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2155 sprintf-related integer and memory overflow issues (Bug#9412).
2157 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2158 (esprintf, exprintf, evxprintf): New functions.
2159 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2160 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2161 (modify_event_symbol): Do not assume that the length of
2162 name_alist_or_stem is safe to alloca and fits in int.
2163 (Fexecute_extended_command): Likewise for function name and binding.
2164 (Frecursion_depth): Wrap around reliably on integer overflow.
2165 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2166 since some callers pass EMACS_INT values.
2167 (Fsingle_key_description): Don't crash if symbol name contains more
2168 than MAX_ALLOCA bytes.
2169 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2170 (get_minibuffer): Arg is now EMACS_INT, not int.
2171 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2172 (esprintf, exprintf, evxprintf): New decls.
2173 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2175 * dbusbind.c (signature_cat): New function.
2176 (xd_signature, Fdbus_register_signal):
2177 Do not overrun buffer; instead, report string overflow.
2179 * dispnew.c (add_window_display_history): Don't overrun buffer.
2180 Truncate instead; this is OK since it's just a log.
2182 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2183 even if the time zone offset is outlandishly large.
2184 Don't mishandle offset == INT_MIN.
2186 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2187 when creating daemon; the previous buffer-overflow check was incorrect.
2189 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2190 which has the guts of the old verror function.
2192 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2193 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2195 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2196 (font_unparse_xlfd): Don't blindly alloca long strings.
2197 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2198 fits in int, when using sprintf. Use single snprintf to count
2199 length of string rather than counting it via multiple sprintfs;
2200 that's simpler and more reliable.
2201 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2202 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2203 sprintf, in case result does not fit in int.
2205 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2206 (fontset_from_font): Print it.
2208 * frame.c (tty_frame_count): Now printmax_t, not int.
2209 (make_terminal_frame, set_term_frame_name): Print it.
2210 (x_report_frame_params): In X, window IDs are unsigned long,
2211 not signed long, so print them as unsigned.
2212 (validate_x_resource_name): Check for implausibly long names,
2213 and don't assume name length fits in 'int'.
2214 (x_get_resource_string): Don't blindly alloca invocation name;
2215 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2218 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2219 (xg_check_special_colors, xg_set_geometry):
2220 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2222 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2223 Use esprintf, not sprintf, in case result does not fit in int.
2225 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2226 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2227 it as a large positive number.
2228 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2229 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2231 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2232 in case result does not fit in int.
2234 * print.c (float_to_string): Detect width overflow more reliably.
2235 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2236 buffer overrun. Don't assume list length fits in 'int'. Treat
2237 print length of 0 as 0, not as infinity; to be consistent with other
2238 uses of print length in this function. Don't overflow print length
2239 index. Don't assume hash table size fits in 'long', or that
2240 vectorlike size fits in 'unsigned long'.
2242 * process.c (make_process): Use printmax_t, not int, to format
2243 process-name gensyms.
2245 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2247 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2248 to avoid potential buffer overrun.
2250 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2251 if X resource line is longer than 512 bytes.
2253 * xfns.c (x_window): Make sprintf buffer a bit bigger
2254 to avoid potential buffer overrun.
2256 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2258 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2260 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2262 Integer overflow fixes for scrolling, etc.
2263 Without these, Emacs silently mishandles large integers sometimes.
2264 For example, "C-u 4294967297 M-x recenter" was treated as if
2265 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2267 * xdisp.c (try_window_id): Check Emacs fixnum range before
2268 converting to 'int'.
2270 * window.c (window_scroll_line_based, Frecenter):
2271 Check that an Emacs fixnum is in range before assigning it to 'int'.
2272 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2273 values converted from Emacs fixnums.
2274 (Frecenter): Don't wrap around a line count if it is out of 'int'
2275 range; instead, treat it as an extreme value.
2276 (Fset_window_configuration, compare_window_configurations):
2277 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2279 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2280 that can exceed INT_MAX. Check that EMACS_INT value is in range
2281 before assigning it to the (possibly-narrower) index.
2282 (match_limit): Don't assume that a fixnum can fit in 'int'.
2284 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2287 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2288 (Fvertical_motion): Don't wrap around LINES values that don't fit
2289 in 'int'. Instead, treat them as extreme values. This is good
2290 enough for windows, which can't have more than INT_MAX lines anyway.
2292 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2294 * Require libxml/parser.h to avoid compilation warning.
2296 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2298 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2299 since this reportedly can destroy thread storage.
2301 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2303 * syntax.c (find_defun_start): Update all cache variables if
2304 exiting early (Bug#9401).
2306 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2308 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2310 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2311 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2312 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2314 * term.c (tty_append_glyph): New function.
2315 (produce_stretch_glyph): Static function and its prototype deleted.
2317 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2320 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2322 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2323 when checking :margin (Bug#9390).
2324 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2325 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2326 so that the name doesn't mislead. All uses changed.
2328 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2330 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2333 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2335 * xdisp.c (move_it_to): Don't bail out early when reaching
2336 position beyond to_charpos, if we are scanning backwards.
2337 (move_it_vertically_backward): When DY == 0, make sure we get to
2338 the first character in the line after the newline.
2340 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2342 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2343 (ccl_driver): Do not generate an out-of-range pointer.
2344 (Fccl_execute_on_string): Remove unnecessary check for
2345 integer overflow, noted by Stefan Monnier in
2346 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2347 Remove a FIXME that didn't need fixing.
2348 Simplify the newly-introduced buffer reallocation code.
2350 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2352 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2354 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2356 Integer and memory overflow issues (Bug#9196).
2358 * doc.c (get_doc_string): Rework so that
2359 get_doc_string_buffer_size is the actual buffer size, rather than
2360 being 1 less than the actual buffer size; this makes xpalloc more
2363 * image.c (x_allocate_bitmap_record, cache_image):
2364 * xselect.c (Fx_register_dnd_atom):
2365 Simplify previous changes by using xpalloc.
2367 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2368 since either will do and ptrdiff_t is convenient with xpalloc.
2370 * charset.c (charset_table_size)
2371 (struct charset_sort_data.priority): Now ptrdiff_t.
2372 (charset_compare): Don't overflow if priorities differ greatly.
2373 (Fsort_charsets): Don't assume list length fits in int.
2374 Check for size-calculation overflow when allocating sort data.
2375 (syms_of_charset): Allocate an initial charset table that is
2376 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2378 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2380 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2381 The actual value is always <= INT_MAX, and leaving it unsigned made
2382 overflow checking harder.
2384 * dispextern.h (struct glyph_matrix.rows_allocated)
2385 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2386 with xpalloc. The values are still always <= INT_MAX.
2388 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2390 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2391 (SAFE_NALLOCA): New macro.
2393 * region-cache.c (struct boundary.pos, find_cache_boundary)
2394 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2395 (set_cache_region, invalidate_region_cache)
2396 (revalidate_region_cache, know_region_cache, region_cache_forward)
2397 (region_cache_backward, pp_cache):
2398 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2399 so that ptrdiff_t * can be passed to xpalloc.
2400 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2401 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2402 (pp_cache): Don't assume cache_len fits in int.
2403 * region-cache.h: Adjust extern decls to match.
2405 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2406 EMACS_INT, since either will do, for xpalloc.
2408 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2409 (xnmalloc, xnrealloc, xpalloc): New functions.
2411 * bidi.c (bidi_shelve_header_size): New constant.
2412 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2413 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2415 * bidi.c (bidi_cache_shrink):
2416 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2418 Don't update size of array until after memory allocation succeeds,
2419 because xmalloc/xrealloc may not return.
2420 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2421 now that we have proper integer overflow checking.
2422 (record_overlay_string, overlay_strings): Catch overflows when
2423 calculating size of overlay_str_buf.
2425 * callproc.c (Fcall_process): Check for size overflow when
2426 calculating size of args2.
2427 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2428 Normally we prefer signed values, but sticking with ptrdiff_t would
2429 require adding more-complicated checks.
2431 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2432 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2433 Redo buffer-overflow calculations to avoid integer overflow.
2434 Add a FIXME comment where memory seems to be over-allocated.
2436 * character.c (Fstring): Check for size-calculation overflow.
2438 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2439 unnecessary integer overflow. Check for size overflow.
2440 (encode_coding_object): Don't update size until xmalloc succeeds.
2442 * composite.c (get_composition_id): Check for overflow in glyph
2443 length calculations.
2445 Integer and memory overflow fixes for display code.
2446 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2447 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2448 (scrolling_window): Check for overflow in size calculations.
2449 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2450 Don't assume glyph table len fits in int.
2451 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2452 (row_table_size): Now ptrdiff_t, not int.
2453 (scrolling_window): Avoid overflow in size calculations.
2454 Don't update size until allocation succeeds.
2455 * fns.c (concat): Check for overflow in size calculations.
2456 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2457 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2458 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2460 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2461 (get_doc_string): Check for size calculation overflow.
2462 Don't update size until allocation succeeds.
2463 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2464 EMACS_INT, where ptrdiff_t will do.
2465 (Fsubstitute_command_keys): Check for string overflow.
2467 * editfns.c (set_time_zone_rule): Don't assume environment length
2469 (message_length): Now ptrdiff_t, not int.
2470 (Fmessage_box): Don't update size until allocation succeeds.
2471 Don't assume message length fits in int.
2472 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2474 * emacs.c (main): Do not reallocate argv, since there is a null at
2475 the end that can be overwritten, and this way there's no need to
2476 worry about size-calculation overflow.
2477 (sort_args): Check for size-calculation overflow.
2479 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2481 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2483 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2484 (x_set_scroll_bar_width, x_figure_window_size):
2485 Check for integer overflow.
2486 (x_set_alpha): Do not assume XINT fits in int.
2488 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2489 This is for the members text_lines, text_cols, total_lines, total_cols,
2490 where the system imposes an 'int' limit.
2492 * fringe.c (Fdefine_fringe_bitmap):
2493 Don't update size until alloc works.
2495 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2496 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2498 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2499 Check for size-calculation overflow.
2500 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2501 do, as we prefer signed integers.
2502 (id_to_widget.max_size, id_to_widget.used)
2503 (xg_store_widget_in_map, xg_remove_widget_from_map)
2504 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2505 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2506 Use and return ptrdiff_t, not int.
2507 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2508 * gtkutil.h: Change prototypes to match the above.
2510 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2511 are duplicate now that they've been promoted to lisp.h.
2512 (x_allocate_bitmap_record, x_alloc_image_color)
2513 (make_image_cache, cache_image, xpm_load):
2514 Don't update size until alloc is done.
2515 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2517 Check for size calculation overflow.
2518 (ct_colors_allocated_max): New constant.
2519 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2522 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2523 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2524 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2525 Use ptrdiff_t, not int, to count maps.
2526 (read_char_minibuf_menu_prompt): Check for overflow in size
2527 calculations. Don't update size until allocation succeeds.
2528 Redo calculations to avoid overflow.
2529 * keyboard.h: Change prototypes to match the above.
2531 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2533 (current_minor_maps): Check for size calculation overflow.
2534 * keymap.h: Change prototypes to match the above.
2536 * lread.c (read1, init_obarray): Don't update size until alloc done.
2538 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2539 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2541 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2542 Now ptrdiff_t, not int.
2543 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2544 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2546 * process.c (Fnetwork_interface_list): Check for overflow
2547 in size calculation.
2549 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2551 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2552 overflow. Don't bother calling xmalloc when xrealloc will do.
2554 * search.c (Freplace_match): Check for size calculation overflow.
2555 (Fset_match_data): Don't assume list lengths fit in 'int'.
2557 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2558 for command line length. Do not attempt to address one before the
2559 beginning of an array, as that's not portable.
2561 * term.c (max_frame_lines): Remove; unused.
2562 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2564 (encode_terminal_code, calculate_costs): Check for size
2565 calculation overflow.
2566 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2567 table lengths and related sizes. Don't update size until alloc
2568 done. Redo calculations to avoid overflow.
2569 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2571 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2572 subtracting pointers.
2573 (gobble_line): Check for overflow more carefully. Don't update size
2576 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2577 Don't update size until alloc done.
2578 Redo size calculations to avoid overflow.
2579 Check for size calculation overflow.
2580 (main) [DEBUG]: Fix typo in invoking tparam1.
2582 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2583 Use ptrdiff_t, not int, for sizes.
2584 (store_mode_line_noprop_char): Don't update size until alloc done.
2586 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2587 Use ptrdiff_t, not int, for sizes.
2588 (Finternal_make_lisp_face, cache_face):
2589 Check for size calculation overflow.
2590 (cache_face): Treat size calculation overflows as if they were
2591 memory exhaustion (the usual treatment), rather than aborting.
2593 * xfns.c (x_encode_text, x_set_name_internal)
2594 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2595 sizes, since they can exceed INT_MAX in size. Check for size
2596 calculation overflow.
2598 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2599 (xg_select): Check for size calculation overflow.
2600 Don't update size until alloc done.
2602 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2603 as sprintf is limited to int lengths.
2605 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2606 (X_LONG_MIN): New macros.
2607 Use them to make the following changes clearer.
2608 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2609 This change doesn't affect the value now, but it may help remind
2610 future maintainers not to raise the value too much later.
2611 (SELECTION_QUANTUM): Remove, replacing with ...
2612 (selection_quantum): ... new function, which avoids overflow.
2614 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2615 assumption that selection length fits in 'int'.
2616 (x_reply_selection_request, x_handle_selection_request)
2617 (x_get_window_property, receive_incremental_selection)
2618 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2619 (lisp_data_to_selection_data, clean_local_selection_data):
2620 Use ptrdiff_t, not int, to record length of selection.
2621 (x_reply_selection_request, x_get_window_property)
2622 (receive_incremental_selection, x_property_data_to_lisp):
2623 Redo calculations to avoid overflow.
2624 (x_reply_selection_request): When sending hint, ceiling it at
2625 X_LONG_MAX rather than relying on wraparound overflow to send
2627 (x_get_window_property, receive_incremental_selection)
2628 (lisp_data_to_selection_data, x_property_data_to_lisp):
2629 Check for size-calculation overflow.
2630 (x_get_window_property, receive_incremental_selection)
2631 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2632 Don't store size until memory allocation succeeds.
2633 (x_get_window_property): Plug memory leak on memory exhaustion.
2634 Don't double-block input; malloc is safe here. Don't assume 2**34
2635 - 4 fits in unsigned long. Add an xassert to check
2636 XGetWindowProperty overflow. Be more careful about overflow
2637 calculations, and distinguish size from memory overflow better.
2638 (receive_incremental_selection): When tracing, don't assume
2639 unsigned int is less than INT_MAX.
2640 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2641 harmful) conversions of unsigned short to int.
2642 (lisp_data_to_selection_data): Don't assume that integers
2643 in the range -65535 through -1 fit in an X unsigned short.
2644 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2645 result parameters unless successful. Rely on cons_to_unsigned
2646 to report problems with elements; the old code wasn't right anyway.
2647 (x_check_property_data): Check for int overflow; we cannot use
2648 a wider type due to X limits.
2649 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2651 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2653 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2654 (x_term_init): Check for size calculation overflow.
2655 (x_color_cells): Don't store size until memory allocation succeeds.
2656 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2657 Don't assume alloca size is less than MAX_ALLOCA.
2658 (x_term_init): Don't assume length fits in int (sprintf is limited
2661 Use ptrdiff_t for composition IDs.
2662 * character.c (lisp_string_width):
2663 * composite.c (composition_table_size, n_compositions)
2664 (get_composition_id, composition_gstring_from_id):
2665 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2666 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2667 * window.c (Frecenter):
2668 Use ptrdiff_t, not int, for composition IDs.
2669 * composite.c (get_composition_id): Check for integer overflow.
2670 * composite.h: Adjust prototypes to match the above changes.
2672 Use ptrdiff_t for hash table indexes.
2673 * category.c (hash_get_category_set):
2674 * ccl.c (ccl_driver):
2675 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2676 * coding.c (coding_system_charset_list, detect_coding_system):
2677 * coding.h (struct coding_system.id):
2678 * composite.c (get_composition_id, gstring_lookup_cache):
2679 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2680 * image.c (xpm_get_color_table_h):
2681 * lisp.h (hash_lookup, hash_put):
2682 * minibuf.c (Ftest_completion):
2683 Use ptrdiff_t for hash table indexes, not int (which is too
2684 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2685 32-bit --with-wide-int hosts).
2687 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2688 Add a FIXME comment about memory leaks.
2689 (syms_of_charset): Don't assume xmalloc returns.
2691 Don't assume that stated character widths fit in int.
2692 * character.c (Fchar_width, c_string_width, lisp_string_width):
2693 * character.h (CHAR_WIDTH):
2694 * indent.c (MULTIBYTE_BYTES_WIDTH):
2695 Use sanitize_char_width to avoid undefined and/or bad behavior
2696 with outlandish widths.
2697 * character.h (sanitize_tab_width): Rename from sanitize_width,
2698 now that we have two such functions. All uses changed.
2699 (sanitize_char_width): New inline function.
2701 Don't assume that tab-width fits in int.
2702 * character.h (sanitize_width): New inline function.
2703 (SANE_TAB_WIDTH): New macro.
2704 (ASCII_CHAR_WIDTH): Use it.
2705 * indent.c (sane_tab_width): Remove. All uses replaced by
2706 SANE_TAB_WIDTH (current_buffer).
2707 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2709 * fileio.c: Integer overflow issues with file modes.
2710 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2712 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2713 Remove unreachable code.
2714 (read_hex, load_charset_map_from_file): Check for integer overflow.
2716 * xterm.c: Don't go over XClientMessageEvent limit.
2717 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2718 (x_send_scroll_bar_event): Likewise. Check that the size does not
2719 exceed limits imposed by XClientMessageEvent, as well as the usual
2720 ptrdiff_t and size_t limits.
2722 * keyboard.c: Overflow, signedness and related fixes.
2723 (make_lispy_movement): Use same integer type in forward decl
2724 that is used in the definition.
2725 (read_key_sequence, keyremap_step):
2726 Change bufsize argument back to int, undoing my 2011-03-30 change.
2727 We prefer signed types, and int is wide enough here.
2728 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2729 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2730 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2731 length, not size_t. Use ptrdiff_t for index, not int.
2732 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2733 possibility of integer overflow.
2735 Overflow, signedness and related fixes for images.
2737 * dispextern.h (struct it.stack[0].u.image.image_id)
2738 (struct_it.image_id, struct image.id, struct image_cache.size)
2739 (struct image_cache.used, struct image_cache.ref_count):
2740 * gtkutil.c (update_frame_tool_bar):
2741 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2742 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2743 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2744 * nsmenu.m (update_frame_tool_bar):
2745 * xdisp.c (calc_pixel_width_or_height):
2746 * xfns.c (image_cache_refcount):
2747 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2748 on typical 64-bit hosts.
2750 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2751 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2752 Omit unnecessary casts to int.
2753 (parse_image_spec): Check that integers fall into 'int' range
2754 when the callers expect that.
2755 (image_ascent): Redo ascent calculation to avoid int overflow.
2756 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2757 (lookup_image): Remove unnecessary tests.
2758 (xbm_image_p): Locals are now of int, not EMACS_INT,
2759 since parse_image_check makes sure they fit into int.
2760 (png_load, gif_load, svg_load_image):
2761 Prefer int to unsigned where either will do.
2762 (tiff_handler): New function, combining the cores of the
2763 old tiff_error_handler and tiff_warning_handler.
2764 This function is rewritten to use vsnprintf and thereby avoid
2765 stack buffer overflows. It uses only the features of vsnprintf
2766 that are common to both POSIX and native Microsoft.
2767 (tiff_error_handler, tiff_warning_handler): Use it.
2768 (tiff_load, gif_load, imagemagick_load_image):
2769 Don't assume :index value fits in 'int'.
2770 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2771 (imagemagick_load_image): Check that crop parameters fit into
2772 the integer types that MagickCropImage accepts. Don't assume
2773 Vimagemagick_render_type has a nonnegative value. Don't assume
2774 size_t fits in 'long'.
2775 (gs_load): Use printmax_t to print the widest integers possible.
2776 Check for integer overflow when computing image height and width.
2778 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2780 * xdisp.c (redisplay_window): Don't force window start if point
2781 will be invisible in the resulting window. (Bug#9324)
2783 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2785 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2786 the display spec is of the form `(space ...)'.
2787 (handle_display_spec): Return the value returned by
2788 handle_single_display_spec, not just 1 or zero.
2789 (handle_single_display_spec): If the display spec is of the form
2790 `(space ...)', and specifies display in the text area, return 2
2792 (try_cursor_movement): Check for the need to scroll more
2793 accurately, and prefer exact match for point under bidi.
2794 Don't advance `row' beyond the last row of the window.
2796 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2797 into disp_prop; all users changed.
2799 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2800 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2801 for the text covered by the display property.
2803 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2805 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2806 Change return value to nil.
2807 (Frecord_buffer): Delete unused function.
2809 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2811 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2812 buffers, return left-to-right.
2813 (set_cursor_from_row): Consider candidate row a win if its glyph
2814 represents a newline and point is on that newline. Fixes cursor
2815 positioning on the newline at EOL of R2L text within L2R
2816 paragraph, and vice versa.
2817 (try_cursor_movement): Check continued rows, in addition to
2818 continuation rows. Fixes unwarranted scroll when point enters a
2819 continued line of R2L text within an L2R paragraph, or vice versa.
2820 (cursor_row_p): Consider the case of point being equal to
2821 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2822 from the end of a short line to the beginning of a continued line
2823 of R2L text within L2R paragraph.
2824 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2825 composed characters.
2827 * bidi.c (bidi_check_type): Use xassert.
2828 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2831 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2833 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2836 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2838 * nsfont.m (ns_otf_to_script): Fix typo.
2840 2011-08-22 Kenichi Handa <handa@m17n.org>
2842 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2843 extra slot even if the purpose is char-code-property-table.
2845 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2847 * xdisp.c (redisplay_window): When computing centering_position,
2848 account for the height of the header line. (Bug#8874)
2850 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2851 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2852 candidate is selected by the mouse, and that candidate has a
2853 composed character under the mouse.
2855 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2856 coordinates reported by pos-visible-in-window-p for a composed
2857 character in column zero.
2859 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2861 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2863 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2866 consider it a hit if to_charpos is anywhere in the range of the
2867 composed buffer positions.
2869 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2871 * image.c (gif_load): Don't assume that each subimage has the same
2872 dimensions as the base image. Handle disposal method that is
2873 "undefined" by the gif spec (Bug#9335).
2875 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2877 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2878 (Fcondition_case): Document `debug' symbol in error handler.
2880 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2882 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2883 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2884 from an Org mode buffer to a Speedbar frame.
2886 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2887 a composition, take its buffer position from IT->cmp_it.charpos.
2888 Fixes cursor positioning at the beginning of a line that begins
2889 with a composed character.
2891 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2893 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2894 character bidirectional type, use STRONG_L instead. Fixes crashes
2895 in a buffer produced by `describe-categories'.
2897 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2898 members before the level stack, so they would be saved and
2899 restored when copying iterator state. Fixes incorrect reordering
2900 around TABs covered by display properties.
2902 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2904 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2906 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2908 * eval.c (internal_condition_case, internal_condition_case_1)
2909 (internal_condition_case_2, internal_condition_case_n):
2910 Remove unnecessary aborts (Bug#9081).
2912 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2914 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2915 has no `load' handler, try opening the file locally. (Bug#9311)
2917 2011-08-16 Ken Brown <kbrown@cornell.edu>
2919 * gmalloc.c: Expand comment.
2921 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2923 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2924 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2926 2011-08-16 Ken Brown <kbrown@cornell.edu>
2928 Fix memory allocation problems in Cygwin build (Bug#9273).
2930 * unexcw.c ( __malloc_initialized): Declare external variable.
2931 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2933 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2935 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2937 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2939 [CYGWIN] (special_realloc): New function.
2940 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2941 requests to realloc storage in the static heap.
2943 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2945 * bidi.c (bidi_initialize): Remove unused local.
2947 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2950 * biditype.h: Remove file.
2951 * makefile.w32-in ($(BLD)/bidi.$(O)):
2952 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2954 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2956 * chartab.c: Improve commentary for the uniprop_table API.
2958 * bidi.c (bidi_paragraph_init): Support zero value of
2959 bidi_ignore_explicit_marks_for_paragraph_level.
2960 (bidi_initialize): Use uniprop_table instead of including
2961 biditype.h and bidimirror.h.
2963 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2964 coordinates of the iterator when restoring from ppos_it.
2967 2011-08-14 Kenichi Handa <handa@m17n.org>
2969 * process.c (create_process): Call setup_process_coding_systems
2970 after the pid of the process is set to -1 (Bug#8162).
2972 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2974 * xdisp.c (move_it_in_display_line_to): Don't invoke
2975 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2976 ppos_it. Fixes vertical cursor motion when line beginning is
2977 covered by an image. (Bug#9296)
2979 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2981 * nsterm.h (ns_run_ascript): Declare.
2982 (NSAPP_DATA2_RUNASSCRIPT): Define.
2984 * nsfns.m (as_script, as_result, as_status): New static variables.
2985 (ns_run_ascript): New function.
2986 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2987 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2988 the event loop. Get status from as_status (Bug#7276).
2990 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2991 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2992 the event loop (Bug#7276).
2994 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2996 * gnutls.c (QCgnutls_bootprop_priority)
2997 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2998 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2999 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3000 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3001 (QCgnutls_bootprop_verify_hostname_error)
3002 (QCgnutls_bootprop_callbacks_verify): Rename from
3003 Qgnutls_bootprop_..., all uses changed.
3005 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3008 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3010 * xfaces.c (Qframe_set_background_mode): Now static.
3011 * dispextern.h (Qframe_set_background_mode): Remove decl.
3013 * process.c (Fnetwork_interface_info): Declare local only if needed.
3015 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3017 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3018 (Fnetwork_interface_list): Allocate in increments of bytes instead
3019 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3020 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3022 (struct ifflag_def): notrailers is smart on OSX.
3023 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3024 Get hardware address with getifaddrs if available.
3026 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (iterate_out_of_display_property): xassert that
3029 IT->position is set to within IT->object's boundaries. Break from
3030 the loop as soon as EOB is reached; avoids infloops in redisplay
3031 when IT->position is set up wrongly due to some bug.
3032 Set IT->current to match the bidi iterator unconditionally.
3033 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3034 entry. Force push_it to save on the stack the current
3035 buffer/string position, to be restored by pop_it. Fix flags in
3036 the iterator structure wrt the object coming from a display
3037 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3038 properties. (Bug#9284)
3040 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3042 * fontset.c (fontset_get_font_group): Add proper type checks.
3045 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3047 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3048 and LC_VERSION_MIN_MACOSX.
3049 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3050 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3052 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3054 * xdisp.c (forward_to_next_line_start): Allow to use the
3055 no-display-properties-and-no-overlays under bidi display.
3056 Set disp_pos in the bidi iterator to avoid searches for display
3057 properties and overlays.
3059 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3061 * editfns.c (Fset_time_zone_rule): Document relationship with the
3064 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3065 the font entity extracted from the cache (Bug#8109).
3067 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3069 * composite.c (autocmp_chars): Don't reset point. That is done by
3070 restore_point_unwind (Bug#5984).
3072 2011-08-07 Juri Linkov <juri@jurta.org>
3074 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3075 to show the arg `TIME' instead of `TIMEVAL'.
3077 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3079 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3080 display property strides EOL and includes a newline, as in
3081 longlines-mode. (Bug#9254)
3082 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3083 word-wrap under bidirectional display. (Bug#9224)
3085 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3086 is non-zero, even if the data buffer is NULL. Fixes a crash in
3087 vertical-motion with longlines-mode. (Bug#9254)
3089 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3091 * bidi.c <bidi_cache_total_alloc>: Now static.
3092 (bidi_initialize): Initialize bidi_cache_total_alloc.
3094 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3097 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3098 amount allocated this far in `bidi_cache_total_alloc'.
3099 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3100 non-zero, only free the data buffer without restoring the cache
3101 contents. All callers changed.
3103 * dispextern.h (bidi_unshelve_cache): Update prototype.
3105 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3106 (move_it_in_display_line, move_it_to)
3107 (move_it_vertically_backward, move_it_by_lines): Replace the call
3108 to xfree to an equivalent call to bidi_unshelve_cache.
3109 (move_it_in_display_line_to): Fix logic of returning
3110 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3112 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3114 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3115 came from a string character with a `cursor' property. (Bug#9229)
3117 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3119 * Makefile.in (LIB_PTHREAD): New variable.
3120 (LIBES): Add LIB_PTHREAD (Bug#9216).
3122 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3123 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3125 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3127 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3129 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3131 * xterm.c (x_find_topmost_parent): New function.
3132 (x_set_frame_alpha): Find topmost parent window with
3133 x_find_topmost_parent and set the property there also (bug#9181).
3134 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3136 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3138 * callproc.c (Fcall_process): Avoid vfork clobbering
3139 the local vars buffer, coding_systems, current_dir.
3141 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3143 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3145 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3147 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3148 so that it is not optimized away.
3150 * xdisp.c (compute_display_string_pos): Remove unused local.
3152 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3154 Fix slow cursor motion and scrolling in large buffers with
3155 selective display, like Org Mode buffers. (Bug#9218)
3157 * dispextern.h (struct bidi_it): New member disp_prop_p.
3159 * xdisp.c: Remove one-slot cache of display string positions.
3160 (compute_display_string_pos): Accept an additional argument
3161 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3162 for a display string or property. If found, set DISP_PROP_P
3165 * bidi.c (bidi_fetch_char): Accept an additional argument
3166 DISP_PROP_P, and pass it to compute_display_string_pos.
3167 Only handle text covered by a display string if DISP_PROP_P is returned
3168 non-zero. All callers of bidi_fetch_char changed.
3170 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3172 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3174 2010-12-03 Don March <don@ohspite.net>
3176 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3177 last character M-[char] is translated to ESC [char] (bug#7541).
3179 2011-08-02 Kenichi Handa <handa@m17n.org>
3181 * lisp.h (uniprop_table): Extern it.
3183 * chartab.c (uniprop_table): Make it non-static.
3185 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3187 * xdisp.c (forward_to_next_line_start): Accept additional argument
3188 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3190 (reseat_at_next_visible_line_start): Use the bidi iterator state
3191 returned by forward_to_next_line_start to restore the state of
3192 it->bidi_it after backing up to previous newline. (Bug#9212)
3194 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3196 * regex.c (re_comp): Protoize.
3197 (re_exec): Fix return type.
3198 (regexec): Fix type of `ret'. (Bug#9203)
3200 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3202 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3203 This is needed if max-image-size is a floating-point number.
3205 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3207 * print.c (print_object): Print empty symbol as ##.
3209 * lread.c (read1): Read ## as empty symbol.
3211 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3213 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3214 setting frame foreground color (Bug#9175).
3215 (x_set_background_color): Likewise.
3217 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3218 contents (Bug#9176).
3219 (EmacsTooltip -init): Remove bezels and add shadows to
3222 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3223 or scroll bar (Bug#8470).
3225 * nsfont.m (nsfont_open): Remove assignment to voffset and
3226 unnecessary vars hshink, expand, hd, full_height, min_height.
3227 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3229 * nsterm.h (nsfont_info): Remove voffset field.
3231 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3233 Implement strike-through and overline on NextStep (Bug#8863).
3235 * nsfont.m (nsfont_open): Use underline position provided by font,
3236 instead of hard-coded value of 2.
3237 (nsfont_draw): Call ns_draw_text_decoration instead.
3239 * nsterm.h: Add declaration for ns_draw_text_decoration.
3241 * nsterm.m (ns_draw_text_decoration): New function for drawing
3242 underline, overline, and strike-through.
3243 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3244 ns_draw_text_decoration. Change treatment of cursor drawing to
3245 accommodate underlining, etc.
3247 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3249 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3252 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3254 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3255 Without this fix, if a signal arrives just after memory fills up,
3256 'malloc' might be invoked reentrantly.
3258 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3259 In other words, assume that every image size is allowed, on non-X
3260 hosts. This assumption is probably wrong, but it lets Emacs compile.
3262 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3264 * regex.c (re_iswctype): Convert return values to boolean.
3266 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3268 * xdisp.c (compute_display_string_pos): Don't use cached display
3269 string position if the buffer had its restriction changed.
3272 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3274 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3276 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3278 Integer signedness and overflow and related fixes. (Bug#9079)
3280 * bidi.c: Integer size and overflow fixes.
3281 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3282 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3283 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3284 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3285 (bidi_find_other_level_edge):
3286 Use ptrdiff_t instead of EMACS_INT where either will do.
3287 This works better on 32-bit hosts configured --with-wide-int.
3288 (bidi_cache_ensure_space): Check for size-calculation overflow.
3289 Use % rather than repeated addition, for better worst-case speed.
3290 Don't set bidi_cache_size until after xrealloc returns, because it
3292 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3293 (bidi_cache_ensure_space): Also check that the bidi cache size
3294 does not exceed that of the largest Lisp string or buffer. See Eli
3295 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3297 * alloc.c (__malloc_size_t): Remove.
3298 All uses replaced by size_t. See Andreas Schwab's note
3299 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3301 * image.c: Improve checking for integer overflow.
3302 (check_image_size): Assume that f is nonnull, since
3303 it is always nonnull in practice. This is one less thing to
3304 worry about when checking for integer overflow later.
3305 (x_check_image_size): New function, which checks for integer
3306 overflow issues inside X.
3307 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3308 This removes the need for a memory_full check.
3309 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3310 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3311 (xbm_read_bitmap_data): Change locals back to 'int', since
3312 their values must fit in 'int'.
3313 (xpm_load_image, png_load, tiff_load):
3314 Invoke x_create_x_image_and_pixmap earlier,
3315 to avoid much needless work if the image is too large.
3316 (tiff_load): Treat overly large images as if
3317 x_create_x_image_and_pixmap failed, not as malloc failures.
3318 (gs_load): Use x_check_image_size.
3320 * gtkutil.c: Omit integer casts.
3321 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3322 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3324 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3326 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3327 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3328 would wrongly return t on a 64-bit host.
3330 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3331 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3332 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3333 and therefore cause GCC to emit a bogus diagnostic in some cases.
3335 * image.c: Integer signedness and overflow and related fixes.
3336 This is not an exhaustive set of fixes, but it's time to
3337 record what I've got.
3338 (lookup_pixel_color, check_image_size): Remove redundant decls.
3339 (check_image_size): Don't assume that arbitrary EMACS_INT values
3340 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3341 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3342 (tiff_load, imagemagick_load_image):
3343 Check for overflow in size calculations.
3344 (x_create_x_image_and_pixmap): Remove unnecessary test for
3345 xmalloc returning NULL; that can't happen.
3346 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3347 (xpm_color_bucket): Use better integer hashing function.
3348 (xpm_cache_color): Don't possibly over-allocate memory.
3349 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3350 (gif_memory_source):
3351 Use ptrdiff_t, not int or size_t, to record sizes.
3352 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3353 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3354 either works, as we prefer signed integers.
3355 (tiff_read_from_memory, tiff_write_from_memory):
3356 Return tsize_t, not size_t, since that's what the TIFF API wants.
3357 (tiff_read_from_memory): Don't fail simply because the read would
3358 go past EOF; instead, return a short read.
3359 (tiff_load): Omit no-longer-needed casts.
3360 (Fimagemagick_types): Don't assume size fits into 'int'.
3362 Improve hashing quality when configured --with-wide-int.
3363 * fns.c (hash_string): New function, taken from sxhash_string.
3364 Do not discard information about ASCII character case; this
3365 discarding is no longer needed.
3366 (sxhash-string): Use it. Change sig to match it. Caller changed.
3367 * lisp.h: Declare it.
3368 * lread.c (hash_string): Remove, since we now use fns.c's version.
3369 The fns.c version returns a wider integer if --with-wide-int is
3370 specified, so this should help the quality of the hashing a bit.
3372 * emacs.c: Integer overflow minor fix.
3373 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3374 Define only if GNU_LINUX.
3375 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3377 * dispnew.c: Integer signedness and overflow fixes.
3378 Remove unnecessary forward decls, that were a maintenance hassle.
3379 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3381 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3382 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3383 (prepare_desired_row, line_draw_cost):
3384 Use int, not unsigned, where either works.
3385 (save_current_matrix, restore_current_matrix):
3386 Use ptrdiff_t, not size_t, where either works.
3387 (init_display): Check for overflow more accurately, and without
3388 relying on undefined behavior.
3390 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3391 Remove, replacing with the new symbols in lisp.h. All uses changed.
3392 * fileio.c (make_temp_name):
3393 * filelock.c (lock_file_1, lock_file):
3394 * xdisp.c (message_dolog):
3395 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3396 Use pMd etc. instead.
3397 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3398 replacing the pWIDE etc. symbols removed from editfns.c.
3400 * keyboard.h (num_input_events): Now uintmax_t.
3401 This is (very slightly) less likely to mess up due to wraparound.
3404 * buffer.c: Integer signedness fixes.
3405 (alloc_buffer_text, enlarge_buffer_text):
3406 Use ptrdiff_t rather than size_t when either will do, as we prefer
3409 * alloc.c: Integer signedness and overflow fixes.
3410 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3411 (__malloc_size_t): Default to size_t, not to int.
3412 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3413 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3414 Prefer ptrdiff_t to size_t when either would do, as we prefer
3416 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3417 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3418 Now const. Initialize with values that are in range even if char
3420 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3421 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3422 These functions do the right thing with sizes > 2**32.
3423 (check_depth): Now ptrdiff_t, not int.
3424 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3425 Adjust to new way of storing sizes. Check for size overflow bugs
3427 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3428 slightly wrong anyway, as it missed one instance of
3429 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3430 (refill_memory_reserve): Omit needless cast to size_t.
3431 (mark_object_loop_halt): Mark as externally visible.
3433 * xselect.c: Integer signedness and overflow fixes.
3434 (Fx_register_dnd_atom, x_handle_dnd_message):
3435 Use ptrdiff_t, not size_t, since we prefer signed.
3436 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3437 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3438 x_dnd_atoms_size and x_dnd_atoms_length.
3440 * doprnt.c: Prefer signed to unsigned when either works.
3442 * doprnt.c (doprnt):
3444 * xdisp.c (vmessage):
3445 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3446 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3447 prefer signed arithmetic to avoid comparison confusion.
3448 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3449 but is a bit tricky.
3451 Assume freestanding C89 headers, string.h, stdlib.h.
3452 * data.c, doprnt.c, floatfns.c, print.c:
3453 Include float.h unconditionally.
3454 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3455 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3456 * regex.c: Likewise for stddef.h, string.h.
3457 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3458 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3459 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3460 (STDC_HEADERS): Remove obsolete defines.
3461 * sysdep.c: Include limits.h unconditionally.
3463 Assume support for memcmp, memcpy, memmove, memset.
3464 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3465 * regex.c (memcmp, memcpy):
3466 Remove; we assume C89 now.
3468 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3469 (__malloc_safe_bcopy): Remove; no longer needed.
3471 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3472 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3473 well either way, and we prefer signed to unsigned.
3475 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3477 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3478 closes the connection while we're reading (bug#9182).
3480 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3482 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3483 are specified (Bug#9168).
3485 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3487 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3488 Found by GCC static checking and --with-wide-int on a 32-bit host.
3490 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3492 * xdisp.c (compute_display_string_pos): Fix logic of caching
3493 previous display string position. Initialize cached_prev_pos to
3494 -1. Fixes slow-down at the beginning of a buffer.
3496 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3498 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3499 for attrs[LFACE_FONTSET_INDEX].
3501 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3503 * xml.c (parse_region): Remove unused local
3504 that was recently introduced.
3506 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3508 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3509 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3511 * xdisp.c (move_it_in_display_line_to): Record the best matching
3512 position for TO_CHARPOS while scanning the line, and restore it on
3513 exit if none of the characters scanned was an exact match.
3514 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3515 when exact match is impossible due to invisible text, and the
3516 lines are truncated.
3518 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3520 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3523 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3525 Fix a significant slow-down of cursor motion with C-n, C-p,
3526 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3527 auto-repeat under bidi redisplay in fontified buffers.
3528 * xdisp.c (compute_stop_pos_backwards): New function.
3529 (next_element_from_buffer): Call compute_stop_pos_backwards to
3530 find a suitable prev_stop when we find ourselves before
3532 (reseat): Don't look for prev_stop, as that could mean a very long
3534 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3535 <cached_disp_overlay_modiff>: Cache for last found display string
3537 (compute_display_string_pos): Return the cached position if asked
3538 about the same buffer in the same area of character positions, and
3539 the buffer wasn't changed since the time the display string
3540 position was cached.
3542 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3544 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3545 is an integer, which is important for empty lines. (Bug#9149)
3547 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3549 * frame.c (Fmodify_frame_parameters): In tty case, update the
3550 default face if necessary (Bug#4238).
3552 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3554 * editfns.c (Fstring_to_char): No need to explain what a character
3555 is in the docstring (Bug#6576).
3557 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3559 * xml.c (parse_region): Make sure we always return a tree.
3561 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3563 * xml.c (parse_region): If a document contains only comments,
3566 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3568 * xml.c (make_dom): Return comments, too.
3570 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3573 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3574 and the surrounding thread.
3575 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3576 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3577 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3579 * s/openbsd.h (BROKEN_SIGIO): Define.
3580 * unexelf.c (unexec) [__OpenBSD__]:
3581 Don't update the .mdebug section of the Alpha COFF symbol table.
3583 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3585 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3588 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3590 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3591 This fixes some race conditions on the permissions of any newly
3594 * alloc.c (valid_pointer_p): Use pipe, not open.
3595 This fixes some permissions issues when debugging.
3597 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3598 If fchown fails to set both uid and gid, try to set just gid,
3599 as that is sometimes allowed. Adjust the file's mode to eliminate
3600 setuid or setgid bits that are inappropriate if fchown fails.
3602 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3604 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3605 to compare Lisp_Objects.
3606 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3607 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3608 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3610 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3612 * lread.c (read_integer): Unread even EOF character.
3613 (read1): Likewise. Properly record start position of symbol.
3615 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3616 symbol character follows.
3618 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3620 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3621 This works around a problem with the previous change to Fcopy_file.
3622 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3623 and without this change, GCC might complain about discarding
3624 fchown's return value.
3626 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3628 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3630 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3632 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3634 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3636 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3637 it's used from the C level.
3639 * process.c: Use the same condition for POLL_FOR_INPUT in both
3640 keyboard.c and process.c (bug#1858).
3642 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3644 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3645 (Fgnutls_boot): Use it.
3647 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3649 * doc.c (Fsubstitute_command_keys): Revert last change.
3651 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3653 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3654 quotes the next character, and doesn't affect other longer
3655 sequences (bug#8935).
3657 * lread.c (syms_of_lread): Clarify that is isn't only
3658 `eval-buffer' and `eval-defun' that's affected by
3659 `lexical-binding' (bug#8460).
3661 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3663 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3664 bidi redisplay when a line includes both an image and is truncated.
3666 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3668 Fix minor problems found by static checking.
3669 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3670 (elsz): Now a signed constant, not a size_t var. We prefer signed
3671 types to unsigned, to avoid integer comparison confusion. Without
3672 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3673 "cannot optimize loop, the loop counter may overflow", a symptom
3675 * indent.c (Fvertical_motion): Mark locals as initialized.
3676 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3678 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3680 * search.c (Fre_search_backward): Mention `case-fold-search' in
3681 all the re_search_* functions (bug#8138).
3683 * keyboard.c (Fopen_dribble_file): Document when the file is
3686 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3688 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3691 Support bidi reordering of display and overlay strings.
3692 * xdisp.c (compute_display_string_pos)
3693 (compute_display_string_end): Accept additional argument STRING.
3694 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3695 (reseat_to_string): Initialize bidi_it->string.s and
3696 bidi_it->string.schars.
3697 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3698 NULL (avoids a crash in bidi_paragraph_init).
3699 Initialize itb.string.lstring.
3700 (init_iterator): Call bidi_init_it only of a valid
3701 buffer position was specified. Initialize paragraph_embedding to
3703 (reseat_to_string): Initialize the bidi iterator.
3704 (display_string): If we need to ignore text properties of
3705 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3706 original value of -1 will not work with bidi.)
3707 (compute_display_string_pos): First arg is now struct
3708 `text_pos *'; all callers changed. Support display properties on
3710 (compute_display_string_end): Support display properties on Lisp
3712 (init_iterator, reseat_1, reseat_to_string): Initialize the
3713 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3714 when iterating on a string not from display properties).
3715 (compute_display_string_pos, compute_display_string_end):
3716 Fix calculation of the object to scan. Fixes an error when using
3718 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3719 base_level_stop; instead, set base_level_stop to BEGV.
3720 Fixes crashes in vertical-motion.
3721 (next_element_from_buffer): Improve commentary for when
3722 the iterator is before prev_stop.
3723 (init_iterator): Initialize bidi_p from the default value of
3724 bidi-display-reordering, not from buffer-local value. Use the
3725 buffer-local value only if initializing for buffer iteration.
3726 (handle_invisible_prop): Support invisible properties on strings
3727 that are being bidi-reordered.
3728 (set_iterator_to_next): Support bidi reordering of C strings and
3730 (next_element_from_string): Support bidi reordering of Lisp
3732 (handle_stop_backwards): Support Lisp strings as well.
3733 (display_string): Support display of R2L glyph rows.
3734 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3735 (init_iterator): Don't initialize it->bidi_p for strings
3737 (reseat_to_string): Initialize it->bidi_p for strings here.
3738 (next_element_from_string, next_element_from_c_string)
3739 (next_element_from_buffer): Add xassert's for correspondence
3740 between IT's object being iterated and it->bidi_it.string
3742 (face_before_or_after_it_pos): Support bidi iteration.
3743 (next_element_from_c_string): Handle the case of the first string
3744 character that is not the first one in the visual order.
3745 (get_visually_first_element): New function, refactored from common
3746 parts of next_element_from_buffer, next_element_from_string, and
3747 next_element_from_c_string.
3748 (tool_bar_lines_needed, redisplay_tool_bar)
3749 (display_menu_bar): Force left-to-right direction. Add a FIXME
3750 comment for making that be controlled by a user option.
3751 (push_it, pop_it): Save and restore the state of the
3752 bidi iterator. Save and restore the bidi_p flag.
3753 (pop_it): Iterate out of display property for string iteration as
3755 (iterate_out_of_display_property): Support iteration over strings.
3756 (handle_single_display_spec): Set up it->bidi_it for iteration
3757 over a display string, and call bidi_init_it.
3758 (handle_single_display_spec, next_overlay_string)
3759 (get_overlay_strings_1, push_display_prop): Set up the bidi
3760 iterator for displaying display or overlay strings.
3761 (forward_to_next_line_start): Don't use the shortcut if
3763 (back_to_previous_visible_line_start): If handle_display_prop
3764 pushed the iterator stack, restore the internal state of the bidi
3765 iterator by calling bidi_pop_it same number of times.
3766 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3767 and we are bidi-iterating, don't decrement the iterator position;
3768 instead, set the first_elt flag in the bidi iterator, to produce
3770 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3771 (push_display_prop): xassert that we are iterating a buffer.
3772 (push_it, pop_it): Save and restore paragraph_embedding member.
3773 (handle_single_display_spec, next_overlay_string)
3774 (get_overlay_strings_1, reseat_1, reseat_to_string)
3775 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3776 correctly. Don't assume unibyte strings are not bidi-reordered.
3777 (compute_display_string_pos)
3778 (compute_display_string_end): Fix handling the case of C string.
3779 (push_it, pop_it): Save and restore from_disp_prop_p.
3780 (handle_single_display_spec, push_display_prop): Set the
3781 from_disp_prop_p flag.
3782 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3783 (pop_it): Call iterate_out_of_display_property only if we are
3784 popping after iteration over a string that came from a display
3785 property. Fix a typo in popping stretch info. Add an assertion
3786 for verifying that the iterator position is in sync with the bidi
3788 (handle_single_display_spec, get_overlay_strings_1)
3789 (push_display_prop): Fix initialization of paragraph direction for
3790 string when that of the parent object is not yet determined.
3791 (reseat_1): Call bidi_init_it to resync the bidi
3792 iterator with IT's position. (Bug#7616)
3793 (find_row_edges): If ROW->start.pos gives position
3794 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3795 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3796 Reset the from_disp_prop_p flag.
3797 (SAVE_IT, RESTORE_IT): New macros.
3798 (pos_visible_p, face_before_or_after_it_pos)
3799 (back_to_previous_visible_line_start)
3800 (move_it_in_display_line_to, move_it_in_display_line)
3801 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3802 (try_scrolling, redisplay_window, display_line): Use them when
3803 saving a temporary copy of the iterator and restoring it back.
3804 (back_to_previous_visible_line_start, reseat_1)
3805 (init_iterator): Empty the bidi cache "stack".
3806 (move_it_in_display_line_to): If iterator ended up at
3807 EOL, but we never saw any buffer positions smaller than
3808 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3809 motion in bidi-reordered lines.
3810 (move_it_in_display_line_to): Record prev_method and prev_pos
3811 immediately before the call to set_iterator_to_next. Fixes cursor
3812 motion in bidi-reordered lines with stretch glyphs and strings
3813 displayed in margins. (Bug#8133) (Bug#8867)
3814 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3816 (pos_visible_p): Support positions in bidi-reordered lines.
3817 Save and restore bidi cache.
3819 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3820 (bidi_paragraph_info): Delete unused struct.
3821 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3822 (bidi_cache_start): New variable.
3823 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3825 (bidi_cache_fetch_state, bidi_cache_search)
3826 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3827 (bidi_cache_find, bidi_peek_at_next_level)
3828 (bidi_level_of_next_char, bidi_find_other_level_edge)
3829 (bidi_move_to_visually_next): Compare cache index with
3830 bidi_cache_start rather than with zero.
3831 (bidi_fetch_char): Accept new argument STRING; all callers
3832 changed. Support iteration over a string. Support strings with
3833 display properties. Support unibyte strings. Fix the type of
3834 `len' according to what STRING_CHAR_AND_LENGTH expects.
3835 (bidi_paragraph_init, bidi_resolve_explicit_1)
3836 (bidi_resolve_explicit, bidi_resolve_weak)
3837 (bidi_level_of_next_char, bidi_move_to_visually_next):
3838 Support iteration over a string.
3839 (bidi_set_sor_type, bidi_resolve_explicit_1)
3840 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3841 can now be zero (for strings); special values 0 and -1 were
3842 changed to -1 and -2, respectively.
3843 (bidi_char_at_pos): New function.
3844 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3845 Call it instead of FETCH_MULTIBYTE_CHAR.
3846 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3847 initialized to valid values.
3848 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3850 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3851 the test for valid cached positions. Fix the logic for looking up
3852 the sentinel state in the cache. GCPRO the Lisp string we are
3854 (bidi_push_it, bidi_pop_it): New functions.
3855 (bidi_initialize): Initialize the bidi cache start stack pointer.
3856 (bidi_cache_ensure_space): New function, refactored from part of
3857 bidi_cache_iterator_state. Don't assume the required size is just
3858 one BIDI_CACHE_CHUNK away.
3859 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3860 (bidi_count_bytes, bidi_char_at_pos): New functions.
3861 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3862 always valid if bidi_cache_idx is valid.
3863 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3864 is valid if it's going to be used.
3865 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3866 (bidi_cache_fetch_state, bidi_cache_search)
3867 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3868 (bidi_cache_iterator_state, bidi_cache_find)
3869 (bidi_find_other_level_edge, bidi_cache_start_stack):
3870 All variables related to cache indices are now EMACS_INT.
3872 * dispextern.h (struct bidi_string_data): New structure.
3873 (struct bidi_it): New member `string'. Make flag members be 1-bit
3874 fields, and put them last in the struct.
3875 (compute_display_string_pos, compute_display_string_end):
3877 (bidi_push_it, bidi_pop_it): Add prototypes.
3878 (struct iterator_stack_entry): New members bidi_p,
3879 paragraph_embedding, and from_disp_prop_p.
3880 (struct it): Member bidi_p is now a bit field 1 bit wide.
3881 (bidi_shelve_cache, bidi_unshelve_cache):
3884 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3885 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3886 and vector-like objects.
3888 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3889 cache around display iteration.
3891 * window.c (Fwindow_end, window_scroll_pixel_based)
3892 (displayed_window_lines, Frecenter): Save and restore the bidi
3893 cache around display iteration.
3895 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897 * editfns.c (Fdelete_region): Clarify the use of the named
3898 parameters (bug#6788).
3900 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3902 * indent.c (Fvertical_motion): Set and restore w->pointm when
3903 saving and restoring the window's buffer (Bug#9006).
3905 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3907 * editfns.c (Fstring_to_char): Clarify just what is returned
3908 (bug#6576). Text by Eli Zaretskii.
3910 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3912 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3914 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3916 * buffer.c (mmap_find): Fix a typo.
3918 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3920 Fix execution of x selection hooks.
3921 * xselect.c (Qx_lost_selection_functions)
3922 (Qx_sent_selection_functions): New vars.
3923 (syms_of_xselect): DEFSYM them.
3924 (x_handle_selection_request): Pass Qx_sent_selection_functions
3925 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3926 (x_handle_selection_clear,x_clear_frame_selections):
3927 Pass Qx_lost_selection_functions rather than
3928 Vx_lost_selection_functions to Frun_hook_with_args.
3930 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3932 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3933 The old code sometimes used this field without initializing it.
3935 * alloc.c (gc_sweep): Don't read past end of array.
3936 In theory, the old code could also have corrupted Emacs internals,
3937 though it'd be very unlikely.
3939 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3941 * character.c (Fcharacterp): Don't advertise optional ignored
3942 argument. (Bug#4026)
3944 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3946 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3949 * window.c (Fset_window_start): Doc fix (bug#4199).
3950 (Fset_window_hscroll): Ditto.
3952 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3954 Fix minor new problems caught by GCC 4.6.1.
3955 * term.c (init_tty): Remove unused local.
3956 * xsettings.c (store_monospaced_changed): Define this function only
3957 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3960 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3962 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3964 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3966 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3967 are the mini-buffer and the echo area (bug#3320).
3969 * term.c (init_tty): Remove support for supdup, c10 and perq
3970 terminals, which are no longer supported (bug#1482).
3972 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3974 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3976 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3978 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3979 for non-popups (Bug#3642).
3981 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3983 * alloc.c (reset_malloc_hooks): Protoize.
3984 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3985 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3986 * cm.c (losecursor): Likewise.
3987 * data.c (fmod): Likewise.
3988 * dispnew.c (swap_glyphs_in_rows): Likewise.
3989 * emacs.c (memory_warning_signal): Likewise.
3990 * floatfns.c (float_error): Likewise.
3991 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3992 (otf_open, font_otf_capability, generate_otf_features)
3993 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3995 * image.c (pbm_read_file): Likewise.
3996 * indent.c (string_display_width): Likewise.
3997 * intervals.c (check_for_interval, search_for_interval)
3998 (inc_interval_count, count_intervals, root_interval)
3999 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4000 * lread.c (defalias): Likewise.
4001 * ralloc.c (r_alloc_check): Likewise.
4002 * regex.c (set_image_of_range_1, set_image_of_range)
4003 (regex_grow_registers): Likewise.
4004 * sysdep.c (strerror): Likewise.
4005 * termcap.c (valid_filename_p, tprint, main): Likewise.
4006 * tparam.c (main): Likewise.
4007 * unexhp9k800.c (run_time_remap, save_data_space)
4008 (update_file_ptrs, read_header, write_header, calculate_checksum)
4009 (copy_file, copy_rest, display_header): Likewise.
4010 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4012 * xdisp.c (check_it): Likewise.
4013 * xfaces.c (register_color, unregister_color, unregister_colors):
4015 * xfns.c (print_fontset_result): Likewise.
4016 * xrdb.c (member, fatal, main): Likewise.
4018 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4020 Fix minor problems found by static checking (Bug#9031).
4021 * chartab.c (char_table_set_range, map_sub_char_table):
4022 Remove unused locals.
4023 (uniprop_table): Now static.
4024 * composite.c (_work_char): Remove unused static var.
4026 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4028 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4030 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4032 * gtkutil.c (qttip_cb): Remove code without function.
4034 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4036 * w32.c (pthread_sigmask): New stub.
4038 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4040 Use pthread_sigmask, not sigprocmask (Bug#9010).
4041 sigprocmask is portable only for single-threaded applications, and
4042 Emacs can be multi-threaded when it uses GTK.
4043 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4045 * callproc.c (Fcall_process):
4046 * process.c (create_process):
4047 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4048 Use pthread_sigmask, not sigprocmask.
4050 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4052 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4053 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4056 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4058 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4059 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4060 (xg_hide_tooltip): Fix comment.
4062 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4063 in registerServicesMenuSendTypes.
4064 (validRequestorForSendType): Don't check ns_return_types.
4066 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4069 2011-07-08 Jason Rumney <jasonr@gnu.org>
4071 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4072 SH_SHOW for hidden windows (Bug#5482).
4074 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4075 frame struct members of non-existent frames (Bug#6284).
4077 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4079 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4080 variable firstTime not needed on OSX >= 10.6.
4081 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4082 >= 10.5. Use setKnobProportion, setDoubleValue.
4084 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4085 (MAC_OS_X_VERSION_10_5): Define if not defined.
4086 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4087 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4088 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4090 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4091 cString and lossyCString on OSX >= 10.4
4093 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4094 sizeToFit on OSX >= 10.2.
4096 * nsimage.m (allocInitFromFile): Don't use deprecated method
4097 bestRepresentationForDevice on OSX >= 10.6.
4099 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4102 * emacs.c: Declare unexec_init_emacs_zone.
4104 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4106 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4108 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4109 on svcsMenu (Bug#8842).
4111 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4113 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4115 * nsterm.m (QUTF8_STRING): Declare.
4116 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4117 (validRequestorForSendType): Return type is (id).
4118 Change indexOfObjectIdenticalTo to indexOfObject.
4119 Check if we have local selection before returning self (Bug#8842).
4120 (writeSelectionToPasteboard): Put local selection into paste board
4121 if we have a local selection (Bug#8842).
4122 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4124 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4125 (ns_get_local_selection): Declare.
4127 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4129 * keymap.c (describe_map_tree): Don't insert a double newline at
4130 the end of the buffer (bug#1169) and return whether we inserted
4133 * callint.c (Fcall_interactively): Change "reading args" to
4134 "providing args" to try to clarify what it does (bug#1010).
4136 2011-07-07 Kenichi Handa <handa@m17n.org>
4138 * composite.c (composition_compute_stop_pos): Ignore a static
4139 composition starting before CHARPOS (Bug#8915).
4141 * xdisp.c (handle_composition_prop): Likewise.
4143 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4145 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4148 2011-07-07 Kenichi Handa <handa@m17n.org>
4150 * character.h (unicode_category_t): New enum type.
4152 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4153 (Qchar_code_property_table): New variable.
4154 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4155 (UNIPROP_COMPRESSED_FORM_P): New macros.
4156 (char_table_ascii): Uncompress the compressed values.
4157 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4158 Uncompress the compressed values.
4159 (sub_char_table_ref_and_range): Likewise.
4160 (char_table_ref_and_range): Uncompress the compressed values.
4161 (sub_char_table_set): New arg is_uniprop. Callers changed.
4162 Uncompress the compressed values.
4163 (sub_char_table_set_range): Args changed. Callers changed.
4164 (char_table_set_range): Adjuted for the above change.
4165 (map_sub_char_table): Delete args default_val and parent. Add arg
4166 top. Give decoded values to a Lisp function.
4167 (map_char_table): Adjust for the above change. Give decoded
4168 values to a Lisp function. Gcpro more variables.
4169 (uniprop_table_uncompress)
4170 (uniprop_decode_value_run_length): New functions.
4171 (uniprop_decoder, uniprop_decoder_count): New variables.
4172 (uniprop_get_decoder, uniprop_encode_value_character)
4173 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4175 (uniprop_encoder, uniprop_encoder_count): New variables.
4176 (uniprop_get_encoder, uniprop_table)
4177 (Funicode_property_table_internal, Fget_unicode_property_internal)
4178 (Fput_unicode_property_internal): New functions.
4179 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4180 Sunicode_property_table_internal, Sget_unicode_property_internal,
4181 and Sput_unicode_property_internal. Defvar_lisp
4182 char-code-property-alist.
4184 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4185 Vunicode_category_table.
4187 * font.c (font_range): Adjust for the change of
4188 Vunicode_category_table.
4190 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4192 * m/iris4d.h: Remove file, move contents ...
4193 * s/irix6-5.h: ... here.
4195 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4197 Remove unportable assumption about struct layout (Bug#8884).
4198 * alloc.c (mark_buffer):
4199 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4200 (clone_per_buffer_values): Don't assume that
4201 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4202 This isn't true in general, and it's particularly not true
4203 if Emacs is configured with --with-wide-int.
4204 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4205 New macros, used in the buffer.c change.
4207 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4209 * xsettings.c: Use both GConf and GSettings if both are available.
4210 (store_config_changed_event): Add comment.
4211 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4212 (store_tool_bar_style_changed): New functions.
4213 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4214 (struct xsettings): Move font inside HAVE_XFT.
4215 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4216 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4217 Move inside HAVE_XFT.
4218 (something_changed_gsettingsCB): Rename from something_changedCB.
4219 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4221 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4222 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4223 (something_changed_gconfCB): Rename from something_changedCB.
4224 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4225 (parse_settings): Move check for font inside HAVE_XFT.
4226 (read_settings, apply_xft_settings): Add comment.
4227 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4228 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4229 call store_font_name_changed.
4230 (xft_settings_event): Add comment.
4231 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4232 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4233 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4234 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4235 (xsettings_initialize): Call init_gsettings last.
4236 (xsettings_get_system_font, xsettings_get_system_normal_font):
4239 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4241 Random fixes. E.g., (random) never returned negative values.
4242 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4243 subseconds part to the entropy, as that's a bit more random.
4244 Prefer signed to unsigned, since the signedness doesn't matter and
4245 in general we prefer signed. When given a limit, use a
4246 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4247 latter isn't right if USE_2_TAGS_FOR_INTS.
4248 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4249 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4251 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4253 * textprop.c (text_property_stickiness):
4254 Obey Vtext_property_default_nonsticky.
4255 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4256 * w32fns.c (syms_of_w32fns):
4257 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4259 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4261 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4262 This is more efficient than Ffile_directory_p and avoids a minor race.
4264 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4266 * buffer.c (Foverlay_put): Say what the return value is
4269 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4270 is a directory before asking whether to use the file name
4272 (barf_or_query_if_file_exists): Make the "File is a directory"
4273 error be more correct.
4275 * fns.c (Frequire): Remove the mention of the .gz files, since
4276 that's installation-specific, but keep the mention of
4277 `get-load-suffixes'.
4279 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4281 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4282 Report string overflow if the output is too long.
4284 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4286 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4287 (syms_of_gnutls): Remove duplicate DEFSYM for
4288 Qgnutls_bootprop_verify_hostname_error, an error for
4289 Qgnutls_bootprop_verify_error (which is no longer used).
4291 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4292 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4293 Also (re)move comments that are misplaced or no longer relevant.
4295 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4297 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4299 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4301 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4302 and background color parameters if they have been changed.
4304 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4306 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4308 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4310 * xsettings.c (SYSTEM_FONT): Define only when used.
4311 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4313 * keymap.c (access_keymap_1): Now static.
4315 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4317 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4318 leave any prefix arg for the up event (Bug#1586).
4320 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4322 * lread.c (syms_of_lread): Mention single symbols defined by
4323 `defvar' or `defconst' (bug#7154).
4325 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4326 (Frequire): Mention get-load-suffixes.
4328 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4330 * window.h (window): Remove clone_number slot.
4331 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4333 (make_parent_window, make_window, saved_window)
4334 (Fset_window_configuration, save_window_save): Don't deal with
4336 * buffer.c (Qclone_number): Remove declaration.
4337 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4339 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4341 Add multiple inheritance to keymaps.
4342 * keymap.c (Fmake_composed_keymap): New function.
4343 (Fset_keymap_parent): Simplify.
4344 (fix_submap_inheritance): Remove.
4345 (access_keymap_1): New function extracted from access_keymap to handle
4346 embedded parents and handle lists of maps.
4347 (access_keymap): Use it.
4348 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4349 (Fcopy_keymap): Handle embedded parents.
4350 (Fcommand_remapping, define_as_prefix): Simplify.
4351 (Fkey_binding): Simplify.
4352 (syms_of_keymap): Move minibuffer-local-completion-map,
4353 minibuffer-local-filename-completion-map,
4354 minibuffer-local-must-match-map, and
4355 minibuffer-local-filename-must-match-map to Elisp.
4356 (syms_of_keymap): Defsubr make-composed-keymap.
4357 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4358 (parse_menu_item): Trivial simplification.
4360 2011-07-01 Glenn Morris <rgm@gnu.org>
4362 * Makefile.in (SETTINGS_LIBS): Fix typo.
4364 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4366 * coding.c (Fencode_coding_string): Record the last coding system
4367 used, as the function doc string says (bug#8738).
4369 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4371 * xsettings.c (store_monospaced_changed): Take new font as arg and
4372 check for change against current_mono_font.
4373 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4374 (emacs_settings_constructor, emacs_settings_get_property)
4375 (emacs_settings_set_property, emacs_settings_class_init)
4376 (emacs_settings_init, gsettings_obj): Remove.
4377 (something_changedCB): New function for HAVE_GSETTINGS.
4378 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4379 with value as argument.
4380 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4381 g_settings_new (Bug#8967). Do not create gsettings_obj.
4382 Remove calls to g_settings_bind. Connect something_changedCB to
4385 * xgselect.c: Add defined (HAVE_GSETTINGS).
4386 (xgselect_initialize): Ditto.
4388 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4389 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4392 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4394 * eval.c (struct backtrace): Simplify and port the data structure.
4395 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4396 signed bit field, as this assumption is not portable and it makes
4397 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4398 "char debug_on_exit : 1" as this is not portable either; instead,
4399 use the portable "unsigned int debug_on_exit : 1". Remove unused
4400 member evalargs. Remove obsolete comments about cc bombing out.
4402 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4404 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4405 Let HAVE_GSETTINGS override HAVE_GCONF.
4406 (store_monospaced_changed): New function.
4407 (EMACS_SETTINGS): A new type derived from GObject to handle
4408 GSettings notifications.
4409 (emacs_settings_constructor, emacs_settings_get_property)
4410 (emacs_settings_set_property, emacs_settings_class_init):
4412 (gsettings_client, gsettings_obj): New variables.
4413 (GSETTINGS_SCHEMA): New define.
4414 (something_changedCB): Call store_monospaced_changed.
4415 (init_gsettings): New function.
4416 (xsettings_initialize): Call init_gsettings.
4417 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4420 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4423 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4425 * window.c (resize_root_window, grow_mini_window)
4426 (shrink_mini_window): Rename Qresize_root_window to
4427 Qwindow_resize_root_window and Qresize_root_window_vertically to
4428 Qwindow_resize_root_window_vertically.
4430 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4432 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4434 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4436 * makefile.w32-in: Redesign dependencies so they reflect more
4437 clearly which files are directly included by each source file,
4438 and not through other includes.
4440 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4442 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4443 (sort_overlays, overlay_strings): When an overlay's clone number
4444 matches the window's clone number process the overlay even if
4445 the overlay's window property doesn't match the current window.
4447 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4448 (Fwindow_hchild): Rename to Fwindow_left_child.
4449 (Fwindow_next): Rename to Fwindow_next_sibling.
4450 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4451 (resize_window_check): Rename to window_resize_check.
4452 (resize_window_apply): Rename to window_resize_apply.
4453 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4454 (Fdelete_other_windows_internal, resize_frame_windows)
4455 (Fsplit_window_internal, Fdelete_window_internal)
4456 (grow_mini_window, shrink_mini_window)
4457 (Fresize_mini_window_internal): Fix callers accordingly.
4459 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4461 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4462 (emacs_fixed_set_min_size): Remove.
4463 (emacs_fixed_new): Take frame as argument.
4465 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4466 (_EmacsFixedPrivate): Remove minwidth/height.
4467 Add struct frame *f.
4468 (emacs_fixed_init): Initialize priv->f.
4469 (get_parent_class, emacs_fixed_set_min_size): Remove.
4470 (emacs_fixed_new): Set priv->f to argument.
4471 (emacs_fixed_get_preferred_width)
4472 (emacs_fixed_get_preferred_height): Use min_width/height from
4473 frames size_hint to set minimum and natural (Bug#8919).
4474 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4475 and use min_width/height from frames size_hint to set
4476 min_width/height (Bug#8919).
4478 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4479 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4482 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4484 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4485 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4488 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4490 * process.c (wait_reading_process_output): Bypass select if
4491 waiting for a cell while ignoring keyboard input, and input is
4492 pending. Suggested by Jan Djärv (Bug#8869).
4494 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4496 Use gnulib's dup2 module instead of rolling our own.
4497 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4499 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4501 * dispnew.c (scrolling_window): Before scrolling, turn off a
4502 mouse-highlight in the window being scrolled.
4504 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4506 Move DEFSYM to lisp.h and use everywhere.
4508 * character.h (DEFSYM): Move declaration...
4509 * lisp.h (DEFSYM): ...here.
4515 * w32select.c: Don't include character.h.
4517 * alloc.c (syms_of_alloc):
4518 * buffer.c (syms_of_buffer):
4519 * bytecode.c (syms_of_bytecode):
4520 * callint.c (syms_of_callint):
4521 * casefiddle.c (syms_of_casefiddle):
4522 * casetab.c (init_casetab_once):
4523 * category.c (init_category_once, syms_of_category):
4524 * ccl.c (syms_of_ccl):
4525 * cmds.c (syms_of_cmds):
4526 * composite.c (syms_of_composite):
4527 * dbusbind.c (syms_of_dbusbind):
4528 * dired.c (syms_of_dired):
4529 * dispnew.c (syms_of_display):
4530 * doc.c (syms_of_doc):
4531 * editfns.c (syms_of_editfns):
4532 * emacs.c (syms_of_emacs):
4533 * eval.c (syms_of_eval):
4534 * fileio.c (syms_of_fileio):
4535 * fns.c (syms_of_fns):
4536 * frame.c (syms_of_frame):
4537 * fringe.c (syms_of_fringe):
4538 * insdel.c (syms_of_insdel):
4539 * keymap.c (syms_of_keymap):
4540 * lread.c (init_obarray, syms_of_lread):
4541 * macros.c (syms_of_macros):
4542 * msdos.c (syms_of_msdos):
4543 * print.c (syms_of_print):
4544 * process.c (syms_of_process):
4545 * search.c (syms_of_search):
4546 * sound.c (syms_of_sound):
4547 * syntax.c (init_syntax_once, syms_of_syntax):
4548 * terminal.c (syms_of_terminal):
4549 * textprop.c (syms_of_textprop):
4550 * undo.c (syms_of_undo):
4551 * w32.c (globals_of_w32):
4552 * window.c (syms_of_window):
4553 * xdisp.c (syms_of_xdisp):
4554 * xfaces.c (syms_of_xfaces):
4555 * xfns.c (syms_of_xfns):
4556 * xmenu.c (syms_of_xmenu):
4557 * xsettings.c (syms_of_xsettings):
4558 * xterm.c (syms_of_xterm): Use DEFSYM.
4560 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4562 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4564 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4566 Integer and buffer overflow fixes (Bug#8873).
4568 * print.c (printchar, strout): Check for string overflow.
4569 (PRINTPREPARE, printchar, strout):
4570 Don't set size unless allocation succeeds.
4572 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4573 for sizes. Check for string overflow more accurately.
4574 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4576 * macros.c: Integer and buffer overflow fixes.
4577 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4578 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4579 Use ptrdiff_t, not int, for sizes.
4580 Don't increment bufsize until after realloc succeeds.
4581 Check for size-calculation overflow.
4582 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4584 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4586 * lread.c: Integer overflow fixes.
4587 (read_integer): Radix is now EMACS_INT, not int,
4588 to improve quality of diagnostics for out-of-range radices.
4589 Calculate buffer size correctly for out-of-range radices.
4590 (read1): Check for integer overflow in radices, and in
4591 read-circle numbers.
4592 (read_escape): Avoid int overflow.
4593 (Fload, openp, read_buffer_size, read1)
4594 (substitute_object_recurse, read_vector, read_list, map_obarray):
4595 Use ptrdiff_t, not int, for sizes.
4596 (read1): Use EMACS_INT, not int, for sizes.
4597 Check for size overflow.
4599 * image.c (cache_image): Check for size arithmetic overflow.
4601 * lread.c: Integer overflow issues.
4602 (saved_doc_string_size, saved_doc_string_length)
4603 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4604 Now ptrdiff_t, not int.
4605 (read1): Don't assume doc string length fits in int. Check for
4606 out-of-range doc string lengths.
4607 (read_list): Don't assume file position fits in int.
4608 (read_escape): Check for hex character overflow.
4610 2011-06-22 Leo Liu <sdl.web@gmail.com>
4612 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4613 Move to minibuffer.el.
4615 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4617 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4618 The following patches are for when GLYPH_DEBUG && !XASSERT.
4619 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4620 * dispnew.c (flush_stdout):
4621 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4622 Mark as externally visible.
4623 * dispnew.c (check_window_matrix_pointers): Now static.
4624 * dispnew.c (window_to_frame_vpos):
4625 * xfns.c (unwind_create_frame):
4626 * xterm.c (x_check_font): Remove unused local.
4627 * scroll.c (CHECK_BOUNDS):
4628 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4629 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4630 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4631 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4632 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4634 (debug_method_add): Use va_list and vsprintf rather than relying
4635 on undefined behavior with wrong number of arguments.
4636 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4637 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4638 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4639 since we're not interested in debugging glyphs with old libraries.
4640 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4641 GCC 4.6.0's static checking.
4643 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4645 Integer overflow and signedness fixes (Bug#8873).
4646 A few related buffer overrun fixes, too.
4648 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4650 * dispextern.h (struct face.stipple):
4651 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4652 (x_bitmap_mask, x_allocate_bitmap_record)
4653 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4654 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4655 (x_create_bitmap_from_xpm_data):
4656 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4657 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4659 * xfaces.c (load_pixmap):
4660 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4661 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4662 (.bitmaps_last, struct x_output.icon_bitmap):
4663 Use ptrdiff_t, not int, for bitmap indexes.
4664 (x_allocate_bitmap_record): Check for size overflow.
4665 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4667 Use ptrdiff_t, not int, for overlay counts.
4668 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4669 * editfns.c (overlays_around, get_pos_property):
4670 * textprop.c (get_char_property_and_overlay):
4671 * xdisp.c (next_overlay_change, note_mouse_highlight):
4672 * xfaces.c (face_at_buffer_position):
4673 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4674 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4675 (Fnext_overlay_change, Fprevious_overlay_change)
4676 (mouse_face_overlay_overlaps, Foverlays_in):
4677 Use ptrdiff_t, not int, for sizes.
4678 (overlays_at, overlays_in): Check for size-calculation overflow.
4680 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4682 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4683 (x_session_initialize): Do not assume string length fits in int.
4685 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4686 This is unlikely, but can occur if DPI is outlandish.
4688 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4689 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4691 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4692 * xrdb.c (magic_file_p, search_magic_path):
4693 Omit last arg SUFFIX; it was always 0. All callers changed.
4694 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4696 * xfont.c (xfont_match): Avoid need for strlen.
4698 * xfns.c: Don't assume strlen fits in int.
4699 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4701 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4702 not unsigned long, as we prefer signed integers. All callers changed.
4703 Detect integer overflow in repeat count.
4704 (message_dolog): Don't assume print length fits in 39 bytes.
4705 (display_mode_element): Don't assume strlen fits in int.
4707 * termcap.c: Don't assume sizes fit in int and never overflow.
4708 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4709 (gobble_line): Check for size-calculation overflow.
4711 * minibuf.c (Fread_buffer):
4712 * lread.c (intern, intern_c_string):
4713 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4714 Don't assume string length fits in int.
4716 * keyboard.c (parse_tool_bar_item):
4717 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4719 * font.c: Don't assume string length fits in int.
4720 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4721 Use ptrdiff_t, not int.
4722 (font_intern_prop): Don't assume string length fits in int.
4723 Don't assume integer property fits in fixnum.
4724 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4726 * filelock.c: Fix some buffer overrun and integer overflow issues.
4727 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4728 Reformulate so as not to need the command string.
4729 Invoke gzip -cd rather than gunzip, as it's more portable.
4730 (lock_info_type, lock_file_1, lock_file):
4731 Don't assume pid_t and time_t fit in unsigned long.
4732 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4733 (current_lock_owner): Prefer signed type for sizes.
4734 Use memcpy, not strncpy, where memcpy is what is really wanted.
4735 Don't assume (via atoi) that time_t and pid_t fit in int.
4736 Check for time_t and/or pid_t out of range, e.g., via a network share.
4737 Don't alloca where an auto var works fine.
4739 * fileio.c: Fix some integer overflow issues.
4740 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4741 Don't assume string length fits in int.
4742 (directory_file_name): Don't assume string length fits in long.
4743 (make_temp_name): Don't assume pid fits in int, or that its print
4744 length is less than 20.
4746 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4748 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4750 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4752 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4753 We prefer signed integers, even for size calculations.
4755 * emacs.c: Don't assume string length fits in 'int'.
4756 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4757 (main): Don't invoke strlen when not needed.
4759 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4760 (XD_DEBUG_MESSAGE): Don't waste a byte.
4762 * callproc.c (getenv_internal_1, getenv_internal)
4764 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4766 * lread.c (invalid_syntax): Omit length argument.
4767 All uses changed. This doesn't fix a bug, but it simplifies the
4768 code away from its former Hollerith-constant appearance, and it's
4769 one less 'int' to worry about when looking at integer-overflow issues.
4770 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4772 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4773 This didn't break anything, but it didn't help either.
4774 It's confusing to put a bogus integer in a place where the actual
4775 value does not matter.
4776 (LIST_END_P): Remove unused macro and its bogus comment.
4777 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4779 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4780 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4782 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4783 We prefer signed types, and the value cannot exceed the EMACS_INT
4784 range anyway (because otherwise the length would not be representable).
4785 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4786 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4787 This avoids a GCC warning when WIDE_EMACS_INT.
4789 * indent.c (sane_tab_width): New function.
4790 (current_column, scan_for_column, Findent_to, position_indentation)
4791 (compute_motion): Use it. This is just for clarity.
4792 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4794 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4796 * lisp.h (lint_assume): New macro.
4797 * composite.c (composition_gstring_put_cache):
4798 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4800 * editfns.c, insdel.c:
4801 Omit unnecessary forward decls, to simplify future changes.
4803 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4805 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4807 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4808 Use much-faster test for byte-length change.
4809 Don't assume string byte-length fits in 'int'.
4810 Check that character arg fits in 'int'.
4811 (mapcar1): Declare byte as byte, for clarity.
4813 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4815 * fns.c (concat): Catch string overflow earlier.
4816 Do not rely on integer wraparound.
4818 * dispextern.h (struct it.overlay_strings_charpos)
4819 (struct it.selective): Now EMACS_INT, not int.
4820 * xdisp.c (forward_to_next_line_start)
4821 (back_to_previous_visible_line_start)
4822 (reseat_at_next_visible_line_start, next_element_from_buffer):
4823 Don't arbitrarily truncate the value of 'selective' to int.
4825 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4827 * composite.c: Don't truncate sizes to 'int'.
4828 (composition_gstring_p, composition_reseat_it)
4829 (composition_adjust_point): Use EMACS_INT, not int.
4830 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4831 not EMACS_UINT, for indexes.
4833 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4835 * buffer.c: Include <verify.h>.
4836 (struct sortvec.priority, struct sortstr.priority):
4837 Now EMACS_INT, not int.
4838 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4839 (struct sortstr.size, record_overlay_string)
4840 (struct sortstrlist.size, struct sortlist.used):
4841 Don't truncate size to int.
4842 (record_overlay_string): Check for size-calculation overflow.
4843 (init_buffer_once): Check at compile-time, not run-time.
4845 2011-06-22 Jim Meyering <meyering@redhat.com>
4847 Don't leak an XBM-image-sized buffer
4848 * image.c (xbm_load): Free the image buffer after using it.
4850 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4853 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4854 that Sun C diagnosed.
4855 * fns.c (secure_hash): Fix pointer signedness issue.
4856 * intervals.c (static_offset_intervals): New function.
4857 (offset_intervals): Use it.
4859 2011-06-21 Leo Liu <sdl.web@gmail.com>
4862 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4865 * fns.c (secure_hash): Rename from crypto_hash_function and change
4866 the first arg to accept symbols.
4867 (Fsecure_hash): New primitive.
4868 (syms_of_fns): New symbols.
4870 2011-06-20 Deniz Dogan <deniz@dogan.se>
4872 * process.c (Fset_process_buffer): Clarify return value in
4875 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4877 * dispnew.c (add_window_display_history): Use BVAR.
4879 * xdisp.c (debug_method_add): Use BVAR.
4880 (check_window_end, dump_glyph_matrix, dump_glyph)
4881 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4883 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4886 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4887 check till after the cache is created in init_frame_faces.
4889 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4891 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4893 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4895 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4896 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4897 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4899 Improve buffer-overflow checking (Bug#8873).
4900 * fileio.c (Finsert_file_contents):
4901 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4902 Remove the old (too-loose) buffer overflow checks.
4903 They weren't needed, since make_gap checks for buffer overflow.
4904 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4905 The old code merely checked for Emacs fixnum overflow, and relied
4906 on undefined (wraparound) behavior. The new code avoids undefined
4907 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4909 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4910 Tune. Don't use wider integers than needed. Don't use alloca.
4911 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4913 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4915 * insdel.c, lisp.h (buffer_overflow): New function.
4916 (insert_from_buffer_1, replace_range, replace_range_2):
4917 * insdel.c (make_gap_larger):
4918 * editfns.c (Finsert_char):
4919 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4921 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4923 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4925 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4927 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4928 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4930 * fileio.c: Don't assume EMACS_INT fits in off_t.
4931 (emacs_lseek): New static function.
4932 (Finsert_file_contents, Fwrite_region): Use it.
4933 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4935 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4937 * fns.c: Don't overflow int when computing a list length.
4938 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4939 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4940 truncation on 64-bit hosts. Check for QUIT every
4941 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4942 faster and is responsive enough.
4943 (Flength): Report an error instead of overflowing an integer.
4944 (Fsafe_length): Return a float if the value is not representable
4945 as a fixnum. This shouldn't happen except in contrived situations.
4946 (Fnthcdr, Fsort): Don't assume list length fits in int.
4947 (Fcopy_sequence): Don't assume vector length fits in int.
4949 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4950 (header_size, word_size): New constants.
4951 (allocate_vectorlike): Don't check size overflow here.
4952 (allocate_vector): Check it here instead, since this is the only
4953 caller of allocate_vectorlike that could cause overflow.
4954 Check that the new vector's length is representable as a fixnum.
4956 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4957 The previous code was bogus. For example, next_almost_prime (32)
4958 returned 39, which is undesirable as it is a multiple of 3; and
4959 next_almost_prime (24) returned 25, which is a multiple of 5 so
4960 why was the code bothering to check for multiples of 7?
4962 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4964 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4966 Variadic C functions now count arguments with ptrdiff_t.
4967 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4968 Back then I didn't know that the Emacs coding style prefers signed int.
4969 Also, in the meantime I found a few more instances where arguments
4970 were being counted with int, which may truncate counts on 64-bit
4971 machines, or EMACS_INT, which may be unnecessarily wide.
4972 * lisp.h (struct Lisp_Subr.function.aMANY)
4973 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4974 Arg counts are now ptrdiff_t, not size_t.
4975 All variadic functions and their callers changed accordingly.
4976 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4977 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4978 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4979 * callint.c (Fcall_interactively): Check arg count for overflow,
4980 to avoid potential buffer overrun. Use signed char, not 'int',
4981 for 'varies' array, so that we needn't bother to check its size
4982 calculation for overflow.
4983 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4984 * eval.c (apply_lambda):
4985 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4986 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4987 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4989 * callint.c (Fcall_interactively): Don't use index var as event count.
4991 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4992 * mem-limits.h (SIZE): Remove; no longer used.
4994 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4996 Remove unnecessary casts.
4997 * xterm.c (x_term_init):
4998 * xfns.c (x_set_border_pixel):
4999 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5000 These aren't needed now that we assume ANSI C.
5002 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5003 It's more likely to cause problems (due to unsigned overflow)
5006 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5008 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5010 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5012 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5014 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5016 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5018 GLYPH_CODE_FACE returns EMACS_INT, not int.
5019 * dispextern.h (merge_faces):
5020 * xfaces.c (merge_faces):
5021 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5022 Don't assume EMACS_INT fits in int.
5024 * character.h (CHAR_VALID_P): Remove unused parameter.
5025 * fontset.c, lisp.h, xdisp.c: All uses changed.
5027 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5029 * fns.c (concat): Minor tuning based on overflow analysis.
5030 This doesn't fix any bugs. Use int to hold character, instead
5031 of constantly refetching from Emacs object. Use XFASTINT, not
5032 XINT, for value known to be a character. Don't bother comparing
5033 a single byte to 0400, as it's always less.
5035 * floatfns.c (Fexpt):
5036 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5038 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5041 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5043 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5044 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5045 incorrectly succeed when S was a string, because 4294967386 was
5046 truncated before it was used.
5048 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5049 Otherwise, an out-of-range integer could cause undefined behavior
5052 * composite.c: Use int, not EMACS_INT, for characters.
5053 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5054 EMACS_INT, for values that are known to be in character range.
5055 This doesn't fix any bugs but is the usual style inside Emacs and
5056 may generate better code on 32-bit machines.
5058 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5059 This is for reasons similar to the recent CHAR_STRING fix.
5060 * charset.c (Fencode_char): Check that character arg is actually
5061 a character. Pass an int to ENCODE_CHAR.
5062 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5063 wider than 'int', as a compile-time check to prevent future regressions
5066 * character.c (char_string): Remove unnecessary casts.
5068 Make sure a 64-bit char is never passed to CHAR_STRING.
5069 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5070 by silently ignoring the top 32 bits, allowing some values
5071 that were far too large to be valid characters.
5072 * character.h: Include <verify.h>.
5073 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5074 arguments are no wider than unsigned, as a compile-time check
5075 to prevent future regressions in this area.
5077 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5078 (Fsubst_char_in_region):
5080 * xdisp.c (decode_mode_spec_coding):
5081 Adjust to CHAR_STRING's new requirement.
5082 * editfns.c (Finsert_char, Fsubst_char_in_region):
5083 * fns.c (concat): Check that character args are actually
5084 characters. Without this test, these functions did the wrong
5085 thing with wildly out-of-range values on 64-bit hosts.
5087 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5088 These casts should not be needed on 32-bit hosts, either.
5089 * keyboard.c (read_char):
5090 * lread.c (Fload): Remove casts to unsigned.
5092 * lisp.h (UNSIGNED_CMP): New macro.
5093 This fixes comparison bugs on 64-bit hosts.
5094 (ASCII_CHAR_P): Use it.
5095 * casefiddle.c (casify_object):
5096 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5097 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5098 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5099 * dispextern.h (FACE_FROM_ID):
5100 * keyboard.c (read_char): Use UNSIGNED_CMP.
5102 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5103 not to EMACS_INT, to avoid GCC warning.
5105 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5107 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5108 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5109 isn't needed on 32-bit machines.
5111 * buffer.c (Fgenerate_new_buffer_name):
5112 Use EMACS_INT for count, not int.
5113 (advance_to_char_boundary): Return EMACS_INT, not int.
5115 * data.c (Qcompiled_function): Now static.
5117 * window.c (window_body_lines): Now static.
5119 * image.c (gif_load): Rename local to avoid shadowing.
5121 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5122 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5123 * alloc.c (make_save_value): Integer argument is now of type
5125 (mark_object): Use ptrdiff_t, not int.
5126 * lisp.h (pD): New macro.
5127 * print.c (print_object): Use it.
5129 * alloc.c: Use EMACS_INT, not int, to count objects.
5130 (total_conses, total_markers, total_symbols, total_vector_size)
5131 (total_free_conses, total_free_markers, total_free_symbols)
5132 (total_free_floats, total_floats, total_free_intervals)
5133 (total_intervals, total_strings, total_free_strings):
5134 Now EMACS_INT, not int. All uses changed.
5135 (Fgarbage_collect): Compute overall total using a double, so that
5136 integer overflow is less likely to be a problem. Check for overflow
5137 when converting back to an integer.
5138 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5139 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5140 These were 'int' variables that could overflow on 64-bit hosts;
5141 they were never used, so remove them instead of repairing them.
5142 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5143 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5144 Previously, this ceilinged at INT_MAX, but that doesn't work on
5146 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5148 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5149 (allocate_vectorlike): Check for ptrdiff_t overflow.
5150 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5151 when a (possibly-narrower) signed value would do just as well.
5152 We prefer using signed arithmetic, to avoid comparison confusion.
5154 * alloc.c: Catch some string size overflows that we were missing.
5155 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5156 for convenience in STRING_BYTES_MAX.
5157 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5158 The definition here is exact; the one in lisp.h was approximate.
5159 (allocate_string_data): Check for string overflow. This catches
5160 some instances we weren't catching before. Also, it catches
5161 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5162 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5163 and ptrdiff_t and EMACS_INT are both 64 bits.
5165 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5166 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5167 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5169 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5171 * alloc.c (Fmake_string): Check for out-of-range init.
5173 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5175 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5177 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5179 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5180 xg_get_default_scrollbar_width.
5182 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5183 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5184 (style_changed_cb): Call update_theme_scrollbar_width and call
5185 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5186 all frames (Bug#8505).
5187 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5188 Call gtk_window_set_resizable if HAVE_GTK3.
5189 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5190 and height if HAVE_GTK3 (Bug#8505).
5191 (scroll_bar_width_for_theme): New variable.
5192 (update_theme_scrollbar_width): New function.
5193 (xg_get_default_scrollbar_width): Move code to
5194 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5195 (xg_initialize): Call update_theme_scrollbar_width.
5197 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5199 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5201 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5203 * frame.c (make_frame): Call other_buffer_safely instead of
5206 * window.c (temp_output_buffer_show): Call display_buffer with
5207 second argument Vtemp_buffer_show_specifiers and reset latter
5208 immediately after the call.
5209 (Vtemp_buffer_show_specifiers): New variable.
5210 (auto_window_vscroll_p, next_screen_context_lines)
5211 (Vscroll_preserve_screen_position): Remove leading asterisks from
5214 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5216 Fix minor problems found by GCC 4.6.0 static checking.
5217 * buffer.c (Qclone_number): Remove for now, as it's unused.
5218 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5219 (record_buffer): Remove unused local.
5220 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5221 (set_frame_buffer_list): Remove; unused.
5222 * frame.h (other_visible_frames): Remove decl.
5223 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5224 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5225 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5227 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5228 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5229 Define only if HAVE_GPM.
5230 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5231 (update_hints_inhibit): Remove; never set. All uses removed.
5232 * widgetprv.h (emacsFrameClassRec): Remove decl.
5233 * window.c (delete_deletable_window): Now returns void, since it
5234 wasn't returning anything.
5235 (compare_window_configurations): Remove unused locals.
5236 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5237 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5238 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5239 the same widths as pointers. This follows up on the 2011-05-06 patch.
5240 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5241 * xterm.h: Likewise.
5242 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5244 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5246 * makefile.w32-in: Update dependencies.
5247 (LISP_H): Add lib/intprops.h.
5249 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5251 * image.c (gif_load): Add animation frame delay to the metadata.
5252 (syms_of_image): Use DEFSYM. New symbol `delay'.
5254 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5256 * window.c (delete_deletable_window): Re-add.
5257 (Fset_window_configuration): Rewrite to handle dead buffers and
5258 consequently deletable windows.
5259 (window_tree, Fwindow_tree): Remove. Supply functionality in
5261 (compare_window_configurations): Simplify code.
5263 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5265 * image.c (imagemagick_load_image): Fix type mismatch.
5266 (Fimagemagick_types): Likewise.
5268 * window.h (replace_buffer_in_windows): Declare.
5270 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5272 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5273 Qclone_number. Remove external declaration of Qdelete_window.
5274 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5276 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5277 Run Qbuffer_list_update_hook if allowed.
5278 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5279 buffer list implementation.
5280 (other_buffer_safely): New function.
5281 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5282 calls to replace_buffer_in_windows and
5283 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5285 (record_buffer): Inhibit quitting and rewrite using quittable
5286 functions. Run Qbuffer_list_update_hook if allowed.
5287 (Frecord_buffer, Funrecord_buffer): New functions.
5288 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5289 Move switch-to-buffer to window.el.
5290 (bury-buffer): Move to window.el.
5291 (Vbuffer_list_update_hook): New variable.
5293 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5296 * window.h (resize_frame_windows): Move up in code.
5297 (Fwindow_frame): Remove EXFUN.
5298 (replace_buffer_in_all_windows): Remove prototype.
5299 (replace_buffer_in_windows_safely): Add prototype.
5301 * window.c: Declare Qdelete_window static again. Move down
5302 declaration of select_count.
5303 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5304 (Fother_window): Move to window.el.
5305 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5306 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5307 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5309 (replace_buffer_in_windows): Implement by calling
5310 Qreplace_buffer_in_windows.
5311 (replace_buffer_in_all_windows): Remove with some functionality
5312 moved into replace_buffer_in_windows_safely.
5313 (replace_buffer_in_windows_safely): New function.
5314 (select_window_norecord, select_frame_norecord): Move in front
5315 of run_window_configuration_change_hook. Remove now obsolete
5317 (Fset_window_buffer): Rewrite doc-string.
5318 Call Qrecord_window_buffer.
5319 (keys_of_window): Move binding for other-window to window.el.
5321 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5323 * dispextern.h (struct image): Replace data member, whose int_val
5324 and ptr_val fields were not used by anything, with a single
5327 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5328 (gif_clear_image, gif_load, imagemagick_load_image)
5329 (gs_clear_image, gs_load): Callers changed.
5331 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5333 * buffer.h: Include <time.h>, for time_t.
5334 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5336 Fix minor problems found by static checking.
5338 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5340 Make identifiers static if they are not used in other modules.
5341 * data.c (Qcompiled_function, Qframe, Qvector):
5342 * image.c (QimageMagick, Qsvg):
5343 * minibuf.c (Qmetadata):
5344 * window.c (resize_window_check, resize_root_window): Now static.
5345 * window.h (resize_window_check, resize_root_window): Remove decls.
5347 * window.c (window_deletion_count, delete_deletable_window):
5349 (window_body_lines): Now static.
5350 (Fdelete_other_windows_internal): Mark vars as initialized.
5351 Make sure 'resize_failed' is initialized.
5352 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5353 (resize_window_apply): Remove unused local.
5354 * window.h (delete_deletable_window): Remove decl.
5356 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5357 (imagemagick_load_image): Fix pointer signedness problem by changing
5358 last arg from unsigned char * to char *. All uses changed.
5359 Also, fix a local for similar reasons.
5360 Remove unused locals. Remove locals to avoid shadowing.
5361 (fn_rsvg_handle_free): Remove; unused.
5362 (svg_load, svg_load_image): Fix pointer signedness problem.
5363 (imagemagick_load_image): Don't use garbage pointer image_wand.
5365 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5367 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5369 * image.c (gif_load): Fix omitted cast error introduced by
5372 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5374 * window.h (resize_proportionally, orig_total_lines)
5375 (orig_top_line): Remove from window structure.
5376 (set_window_height, set_window_width, change_window_heights)
5377 (Fdelete_window): Remove prototypes.
5378 (resize_frame_windows): Remove duplicate declaration.
5380 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5382 * window.h (resize_frame_windows, resize_window_check)
5383 (delete_deletable_window, resize_root_window)
5384 (resize_frame_windows): Declare prototypes.
5386 * window.c (resize_window_apply): Make definition be "static" to
5387 match the prototype.
5389 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5391 * window.c: Remove declarations of Qwindow_size_fixed,
5392 window_min_size_1, window_min_size_2, window_min_size,
5393 size_window, window_fixed_size_p, enlarge_window, delete_window.
5394 Remove static from declaration of Qdelete_window, it's
5395 temporarily needed by Fbury_buffer.
5396 (replace_window): Don't assign orig_top_line and
5398 (Fdelete_window, delete_window): Remove. Window deletion is
5399 handled by window.el.
5400 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5401 Replace Fdelete_window calls with calls to Qdelete_window.
5402 (Fdelete_other_windows): Remove. Deleting other windows is
5403 handled by window.el.
5404 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5405 handled in window.el.
5406 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5407 Window minimum sizes are handled in window.el.
5408 (shrink_windows, size_window, set_window_height)
5409 (set_window_width, change_window_heights, window_height)
5410 (window_width, CURBEG, CURSIZE, enlarge_window)
5411 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5412 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5413 handled in window.el.
5414 (make_dummy_parent): Rename to make_parent_window and give it a
5415 second argument horflag.
5416 (make_window): Don't set resize_proportionally any more.
5417 (Fsplit_window): Remove. Windows are split in window.el.
5418 (save_restore_action, save_restore_orig_size)
5419 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5420 Resize mini windows in window.el.
5421 (grow_mini_window, shrink_mini_window): Implement by calling
5422 Qresize_root_window_vertically, resize_window_check and
5423 resize_window_apply.
5424 (saved_window, Fset_window_configuration, save_window_save):
5425 Do not handle orig_top_line, orig_total_lines, and
5426 resize_proportionally.
5427 (window_min_height, window_min_width): Move to window.el.
5428 (keys_of_window): Move bindings for delete-other-windows,
5429 split-window, delete-window and enlarge-window to window.el.
5431 * buffer.c: Temporarily extern Qdelete_window.
5432 (Fbury_buffer): Temporarily call Qdelete_window instead of
5433 Fdelete_window (Fbury_buffer will move to window.el soon).
5435 * frame.c (set_menu_bar_lines_1): Remove code handling
5436 orig_top_line and orig_total_lines.
5438 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5439 set_window_height but set heights directly.
5440 (change_frame_size_1): Use resize_frame_windows.
5442 * xdisp.c (init_xdisp): Don't use set_window_height but set
5445 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5446 Use resize_frame_windows instead of change_window_heights and run
5447 run_window_configuration_change_hook.
5449 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5450 instead of change_window_heights and run
5451 run_window_configuration_change_hook.
5453 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5455 * window.c (replace_window): Rename second argument REPLACEMENT to
5456 NEW. New third argument SETFLAG. Rewrite.
5457 (delete_window, make_dummy_parent): Call replace_window with
5459 (window_list_1): Move down in code.
5460 (run_window_configuration_change_hook): Move set_buffer part
5461 before select_frame_norecord part in order to unwind correctly.
5462 Rename count1 to count.
5463 (recombine_windows, delete_deletable_window, resize_root_window)
5464 (Fdelete_other_windows_internal)
5465 (Frun_window_configuration_change_hook, make_parent_window)
5466 (resize_window_check, resize_window_apply, Fresize_window_apply)
5467 (resize_frame_windows, Fsplit_window_internal)
5468 (Fdelete_window_internal, Fresize_mini_window_internal):
5470 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5472 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5474 * window.h (window): Add some new members to window structure -
5475 normal_lines, normal_cols, new_total, new_normal, clone_number,
5476 splits, nest, prev_buffers, next_buffers.
5477 (WINDOW_TOTAL_SIZE): Move here from window.c.
5478 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5480 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5482 (make_dummy_parent): Set new members of windows structure.
5483 (make_window): Move down in code. Handle new members of window
5485 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5486 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5487 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5488 (Fset_window_prev_buffers, Fwindow_next_buffers)
5489 (Fset_window_next_buffers, Fset_window_clone_number):
5491 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5492 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5494 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5495 Argument WINDOW can be now internal window too.
5496 (Fwindow_use_time): Move up in code.
5497 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5499 (Fset_window_configuration, saved_window)
5500 (Fcurrent_window_configuration, save_window_save): Handle new
5501 members of window structure.
5502 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5503 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5504 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5505 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5506 Qget_mru_window, Qresize_root_window,
5507 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5508 Qauto_buffer_name; staticpro them.
5510 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5512 * window.c (Fwindow_total_size, Fwindow_left_column)
5513 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5514 (Fwindow_list_1): New functions.
5515 (window_box_text_cols): Replace with window_body_cols.
5516 (Fwindow_width, Fscroll_left, Fscroll_right):
5517 Use window_body_cols instead of window_box_text_cols.
5518 (delete_window, Fset_window_configuration):
5519 Call delete_all_subwindows with window as argument.
5520 (delete_all_subwindows): Take a window as argument and not a
5522 (window_loop): Remove handling of GET_LRU_WINDOW and
5524 (Fget_lru_window, Fget_largest_window): Move to window.el.
5526 * window.h: Extern window_body_cols instead of
5527 window_box_text_cols. delete_all_subwindows now takes a
5528 Lisp_Object as argument.
5530 * indent.c (compute_motion, Fcompute_motion):
5531 Use window_body_cols instead of window_box_text_cols.
5533 * frame.c (delete_frame): Call delete_all_subwindows with root
5536 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5538 * fns.c (Fputhash): Document return value.
5540 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5542 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5544 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5546 Cons<->int and similar integer overflow fixes (Bug#8794).
5548 Check for overflow when converting integer to cons and back.
5549 * charset.c (Fdefine_charset_internal, Fdecode_char):
5550 Use cons_to_unsigned to catch overflow.
5551 (Fencode_char): Use INTEGER_TO_CONS.
5552 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5553 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5554 * data.c (long_to_cons, cons_to_long): Remove.
5555 (cons_to_unsigned, cons_to_signed): New functions.
5556 These signal an error for invalid or out-of-range values.
5557 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5558 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5559 * font.c (Ffont_variation_glyphs):
5560 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5561 * lisp.h: Include <intprops.h>.
5562 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5563 (cons_to_signed, cons_to_unsigned): New decls.
5564 (long_to_cons, cons_to_long): Remove decls.
5565 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5566 (Fprimitive_undo): Use CONS_TO_INTEGER.
5567 * xfns.c (Fx_window_property): Likewise.
5568 * xselect.c: Include <limits.h>.
5569 (x_own_selection, selection_data_to_lisp_data):
5570 Use INTEGER_TO_CONS.
5571 (x_handle_selection_request, x_handle_selection_clear)
5572 (x_get_foreign_selection, Fx_disown_selection_internal)
5573 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5574 (lisp_data_to_selection_data): Use cons_to_unsigned.
5575 (x_fill_property_data): Use cons_to_signed.
5576 Report values out of range.
5578 Check for buffer and string overflow more precisely.
5579 * buffer.h (BUF_BYTES_MAX): New macro.
5580 * lisp.h (STRING_BYTES_MAX): New macro.
5581 * alloc.c (Fmake_string):
5582 * character.c (string_escape_byte8):
5583 * coding.c (coding_alloc_by_realloc):
5584 * doprnt.c (doprnt):
5585 * editfns.c (Fformat):
5587 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5588 since they may not be the same number.
5589 * editfns.c (Finsert_char):
5590 * fileio.c (Finsert_file_contents):
5591 Likewise for BUF_BYTES_MAX.
5593 * image.c: Use ptrdiff_t, not int, for sizes.
5594 (slurp_file): Switch from int to ptrdiff_t.
5596 (slurp_file): Check that file size fits in both size_t (for
5597 malloc) and ptrdiff_t (for sanity and safety).
5599 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5600 if b->modtime has its maximal value.
5602 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5604 Don't assume time_t can fit into int.
5605 * buffer.h (struct buffer.modtime): Now time_t, not int.
5606 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5607 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5609 Minor fixes for signed vs unsigned integers.
5610 * character.h (MAYBE_UNIFY_CHAR):
5611 * charset.c (maybe_unify_char):
5612 * keyboard.c (read_char, reorder_modifiers):
5613 XINT -> XFASTINT, since the integer must be nonnegative.
5614 * ftfont.c (ftfont_spec_pattern):
5615 * keymap.c (access_keymap, silly_event_symbol_error):
5616 XUINT -> XFASTINT, since the integer must be nonnegative.
5617 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5618 since it makes no difference and we prefer signed.
5619 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5620 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5623 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5625 * window.h (Fwindow_frame): Declare.
5627 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5629 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5630 (SPARE_MEMORY): Always define.
5631 (LARGE_REQUEST): Remove.
5632 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5634 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5636 * lisp.h: Move EXFUNS for Fframe_root_window,
5637 Fframe_first_window and Fset_frame_selected_window to window.h.
5639 * window.h: Move EXFUNS for Fframe_root_window,
5640 Fframe_first_window and Fset_frame_selected_window here from
5643 * frame.c (Fwindow_frame, Fframe_first_window)
5644 (Fframe_root_window, Fframe_selected_window)
5645 (Fset_frame_selected_window): Move to window.c.
5646 (Factive_minibuffer_window): Move to minibuf.c.
5647 (Fother_visible_frames_p): New function.
5649 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5651 * window.c (decode_window, decode_any_window): Move up in code.
5652 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5653 (inhibit_frame_unsplittable): Remove unused variable.
5654 (Fwindow_buffer): Move up and rewrite doc-string.
5655 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5656 (Fwindow_prev): New functions.
5657 (Fwindow_frame): Move here from frame.c. Accept any window as
5659 (Fframe_root_window, Fframe_first_window)
5660 (Fframe_selected_window): Move here from frame.c. Accept frame
5661 or arbitrary window as argument. Update doc-strings.
5662 (Fminibuffer_window): Move up in code.
5663 (Fwindow_minibuffer_p): Move up in code and simplify.
5664 (Fset_frame_selected_window): Move here from frame.c.
5666 (Fselected_window, select_window, Fselect_window): Move up in
5667 code. Minor doc-string fixes.
5669 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5671 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5672 Do not assume that spare memory exists; that assumption is valid
5673 only if SYSTEM_MALLOC.
5674 (LARGE_REQUEST): New macro, so that the issue of large requests
5675 is separated from the issue of spare memory.
5677 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5679 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5682 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5684 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5687 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5689 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5691 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5693 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5694 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5696 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5698 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5700 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5702 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5703 (x_clipboard_manager_save): Add return value.
5704 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5706 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5707 Obey Vx_select_enable_clipboard_manager. Catch errors in
5708 x_clipboard_manager_save (Bug#8779).
5709 (Vx_select_enable_clipboard_manager): New variable.
5710 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5712 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5714 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5716 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5718 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5719 in the current matrix if keep_current_p is non-zero.
5721 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5723 * bidi.c (bidi_level_of_next_char): Fix last change.
5725 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5727 Support bidi reordering of text covered by display properties.
5729 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5730 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5731 (bidi_cache_search, bidi_cache_iterator_state)
5732 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5733 (bidi_level_of_next_char, bidi_move_to_visually_next):
5734 Support character positions inside a run of characters covered by a
5736 (bidi_paragraph_init, bidi_resolve_explicit_1)
5737 (bidi_level_of_next_char): Call bidi_fetch_char and
5738 bidi_fetch_char_advance instead of FETCH_CHAR and
5740 (bidi_init_it): Initialize new members.
5741 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5743 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5744 instead of using explicit *_CHAR codes.
5745 (bidi_resolve_explicit, bidi_resolve_weak):
5746 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5747 bidirectional text is supported only in multibyte buffers.
5748 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5749 it to initialize the frame_window_p member of struct bidi_it.
5750 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5751 (bidi_resolve_explicit, bidi_resolve_weak)
5752 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5753 bidi_it->nchars is non-positive.
5754 (bidi_level_of_next_char): Don't try to lookup the cache for the
5755 next/previous character if nothing is cached there yet, or if we
5756 were just reseat()'ed to a new position.
5758 * xdisp.c (set_cursor_from_row): Set start and stop points
5759 according to the row's direction when priming the loop that looks
5760 for the glyph on which to display cursor.
5761 (single_display_spec_intangible_p): Function deleted.
5762 (display_prop_intangible_p): Reimplement to call
5763 handle_display_spec instead of single_display_spec_intangible_p.
5764 Accept 3 additional arguments needed by handle_display_spec.
5765 This fixes incorrect cursor motion across display property with complex
5766 values: lists, `(when COND...)' forms, etc.
5767 (single_display_spec_string_p): Support property values that are
5768 lists with the argument STRING its top-level element.
5769 (display_prop_string_p): Fix the condition for processing a
5770 property that is a list to be consistent with handle_display_spec.
5771 (handle_display_spec): New function, refactored from the
5772 last portion of handle_display_prop.
5773 (compute_display_string_pos): Accept additional argument
5774 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5775 value of a `display' property is a "replacing spec".
5776 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5777 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5778 the display property, but just return a value indicating whether
5779 the display property will replace the characters it covers.
5780 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5781 frame_window_p members of struct bidi_it.
5782 (compute_display_string_pos, compute_display_string_end):
5784 (push_it): Accept second argument POSITION, where pop_it should
5785 jump to continue iteration.
5786 (reseat_1): Initialize bidi_it.disp_pos.
5788 * keyboard.c (adjust_point_for_property): Adjust the call to
5789 display_prop_intangible_p to its new signature.
5791 * dispextern.h (struct bidi_it): New member frame_window_p.
5792 (bidi_init_it): Update prototypes.
5793 (display_prop_intangible_p): Update prototype.
5794 (compute_display_string_pos, compute_display_string_end):
5796 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5799 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5801 Malloc failure behavior now depends on size of allocation.
5802 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5803 * lisp.h: Change signatures accordingly.
5804 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5805 All callers changed. (Bug#8762)
5807 * gnutls.c: Use Emacs's memory allocators.
5808 Without this change, the gnutls library would invoke malloc etc.
5809 directly, which causes problems on non-SYNC_INPUT hosts, and which
5810 runs afoul of improving memory_full behavior. (Bug#8761)
5811 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5812 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5813 xfree instead of the default malloc, realloc, free.
5814 (Fgnutls_boot): No need to check for memory allocation failure,
5815 since xmalloc does that for us.
5817 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5818 * category.c (hash_get_category_set):
5819 * ccl.c (ccl_driver):
5820 * charset.c (Fdefine_charset_internal):
5821 * charset.h (struct charset.hash_index):
5822 * composite.c (get_composition_id, gstring_lookup_cache)
5823 (composition_gstring_put_cache):
5824 * composite.h (struct composition.hash_index):
5825 * dispextern.h (struct image.hash):
5826 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5827 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5828 (hashfn_equal, hashfn_user_defined, make_hash_table)
5829 (maybe_resize_hash_table, hash_lookup, hash_put)
5830 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5831 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5832 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5833 * image.c (make_image, search_image_cache, lookup_image)
5834 (xpm_put_color_table_h):
5835 * lisp.h (struct Lisp_Hash_Table):
5836 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5837 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5838 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5839 * alloc.c (allocate_vectorlike):
5840 Check for overflow in vector size calculations.
5841 * ccl.c (ccl_driver):
5842 Check for overflow when converting EMACS_INT to int.
5843 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5844 need to be updated by these changes.
5845 * fns.c (make_hash_table, maybe_resize_hash_table):
5846 Check for integer overflow with large hash tables.
5847 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5848 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5849 (SXHASH_REDUCE): New macro.
5850 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5851 Use it instead of discarding useful hash info with large hash values.
5852 (sxhash_float): New function.
5853 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5854 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5855 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5856 Rewrite to use FIXNUM_BITS, as this simplifies things.
5857 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5858 Adjust signatures to match updated version of code.
5859 (consing_since_gc): Now EMACS_INT, since a single hash table can
5860 use more than INT_MAX bytes.
5862 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5864 Make it possible to build with GCC-4.6+ -O2 -flto.
5866 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5868 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5870 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5871 Call minibuffer-inactive-mode.
5873 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5875 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5876 Update dependencies.
5878 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5880 * data.c (init_data): Remove code for UTS, this system is not
5883 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5885 Don't force ./temacs to start in terminal mode.
5887 * frame.c (make_initial_frame): Initialize faces in all cases, not
5888 only when CANNOT_DUMP is defined.
5889 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5891 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5893 * dispnew.c (add_window_display_history): Use const for the string
5894 pointer. Remove declaration, not needed.
5896 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5898 Use 'inline', not 'INLINE'.
5899 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5900 * alloc.c, fontset.c (INLINE): Remove.
5901 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5902 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5903 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5904 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5905 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5907 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5909 Make it possible to run ./temacs.
5911 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5912 syms_of_callproc does the same thing. Remove test for
5913 "initialized", do it in the caller.
5914 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5916 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5918 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5919 (read_minibuf): Use get_minibuffer.
5920 (syms_of_minibuf): Use DEFSYM.
5921 (Qmetadata): New var.
5922 * data.c (Qbuffer): Don't make it static.
5923 (syms_of_data): Use DEFSYM.
5925 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5927 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5928 (CCL_CODE_MIN): New macro.
5930 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5932 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5934 * eval.c (Qdebug): Now static.
5935 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5936 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5937 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5939 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5941 * image.c: Various fixes to ImageMagick code comments.
5942 (Fimagemagick_types): Doc fix.
5944 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5946 Minor fixes prompted by GCC 4.6.0 warnings.
5948 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5950 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5951 (x_clipboard_manager_save_all): Move extern decl to ...
5952 * xterm.h: ... here, so that it can be checked for consistency.
5954 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5956 * xselect.c (x_clipboard_manager_save_frame)
5957 (x_clipboard_manager_save_all): New functions.
5958 (Fx_clipboard_manager_save): Lisp function deleted.
5960 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5961 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5963 * xterm.h: Update prototype.
5965 2011-05-28 William Xu <william.xwl@gmail.com>
5967 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5970 2011-05-28 Jim Meyering <meyering@redhat.com>
5972 Avoid a sign-extension bug in crypto_hash_function.
5973 * fns.c (to_uchar): Define.
5974 (crypto_hash_function): Use it to convert some newly-signed
5975 variables to unsigned, to avoid sign-extension bugs. For example,
5976 without this change, (md5 "truc") would evaluate to
5977 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5978 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5979 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5981 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5983 Integer overflow fixes.
5985 * dbusbind.c: Serial number integer overflow fixes.
5986 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5987 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5988 to hold a serial number that is too large for a fixnum.
5989 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5990 Check for serial numbers out of range. Decode any serial number
5991 that was so large that it became a float. (Bug#8722)
5993 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5994 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5995 Use XFASTINT rather than XUINT when numbers are nonnegative.
5996 (xd_append_arg, Fdbus_method_return_internal):
5997 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5998 arguments, check that Lisp number is nonnegative, rather than
5999 silently wrapping negative numbers around. (Bug#8722)
6000 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6003 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6005 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6007 ccl: Add integer overflow checks.
6008 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6009 (IN_INT_RANGE): New macros.
6010 (ccl_driver): Use them to check for integer overflow when
6011 decoding a CCL program. Many of the new checks are whether XINT (x)
6012 fits in int; it doesn't always, on 64-bit hosts. The new version
6013 doesn't catch all possible integer overflows, but it's an
6014 improvement. (Bug#8719)
6016 * alloc.c (make_event_array): Use XINT, not XUINT.
6017 There's no need for unsigned here.
6019 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6020 This follows up to the 2011-05-06 change that substituted uintptr_t
6021 for EMACS_INT. This case wasn't caught back then.
6023 Rework Fformat to avoid integer overflow issues.
6024 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6025 now (part of C89). Include <verify.h>.
6026 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6027 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6028 (Fformat): Avoid the prepass trying to compute sizes; it was only
6029 approximate and thus did not catch overflow reliably. Instead, walk
6030 through the format just once, formatting and computing sizes as we go,
6031 checking for integer overflow at every step, and allocating a larger
6032 buffer as needed. Keep track separately whether the format is
6033 multibyte. Keep only the most-recently calculated precision, rather
6034 than them all. Record whether each argument has been converted to
6035 string. Use EMACS_INT, not int, for byte and char and arg counts.
6036 Support field widths and precisions larger than INT_MAX. Avoid
6037 sprintf's undefined behavior with conversion specifications such as %#d
6038 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6039 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6040 formatting out-of-range floating point numbers with int
6043 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6045 * data.c: Avoid integer truncation in expressions involving floats.
6046 * data.c: Include <intprops.h>.
6047 (arith_driver): When there's an integer overflow in an expression
6048 involving floating point, convert the integers to floating point
6049 so that the resulting value does not suffer from catastrophic
6050 integer truncation. For example, on a 64-bit host (* 4
6051 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6052 Do not rely on undefined behavior after integer overflow.
6054 merge count_size_as_multibyte, parse_str_to_multibyte
6055 * character.c, character.h (count_size_as_multibyte):
6056 Rename from parse_str_to_multibyte; all uses changed.
6057 Check for integer overflow.
6058 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6059 since it's now a duplicate of the other. This is more of
6060 a character than a buffer op, so better that it's in character.c.
6061 * fns.c, print.c: Adjust to above changes.
6063 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6065 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6067 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6069 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6070 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6071 (x_clipboard_manager_save): Now static.
6072 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6074 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6075 (crypto_hash_function): Now static.
6076 Fix pointer signedness problems. Avoid unnecessary initializations.
6078 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6080 * termhooks.h (Vselection_alist): Make it terminal-local.
6082 * terminal.c (create_terminal): Initialize it.
6084 * xselect.c: Support for clipboard managers.
6085 (Vselection_alist): Move to termhooks.h as terminal-local var.
6086 (LOCAL_SELECTION): New macro.
6087 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6088 (symbol_to_x_atom): Remove gratuitous arg.
6089 (x_handle_selection_request, lisp_data_to_selection_data)
6090 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6091 (x_own_selection, x_get_local_selection, x_convert_selection):
6092 New arg, specifying work frame. Use terminal-local Vselection_alist.
6093 (some_frame_on_display): Delete unused function.
6094 (Fx_own_selection_internal, Fx_get_selection_internal)
6095 (Fx_disown_selection_internal, Fx_selection_owner_p)
6096 (Fx_selection_exists_p): New optional frame arg.
6097 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6098 (x_handle_selection_clear): Don't treat other terminals with the
6099 same keyboard specially. Use the terminal-local Vselection_alist.
6100 (x_clear_frame_selections): Use Frun_hook_with_args.
6102 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6104 * xterm.h: Add support for those atoms.
6106 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6108 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6109 (converted_selections, conversion_fail_tag): New global variables.
6110 (x_selection_request_lisp_error): Free the above.
6111 (x_get_local_selection): Remove unnecessary code.
6112 (x_reply_selection_request): Args changed; handle arbitrary array
6113 of converted selections stored in converted_selections.
6114 Separate the XChangeProperty and SelectionNotify steps.
6115 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6116 (x_convert_selection): New function.
6117 (x_handle_selection_event): Simplify.
6118 (x_get_foreign_selection): Don't ignore incoming requests while
6119 waiting for an answer; this will fail when we implement
6120 SAVE_TARGETS, and seems unnecessary anyway.
6121 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6122 (Vx_sent_selection_functions): Doc fix.
6124 2011-05-26 Leo Liu <sdl.web@gmail.com>
6126 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6128 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6130 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6132 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6133 for fringe update if it has periodic bitmap.
6134 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6135 and fringe_bitmap_periodic_p.
6137 * fringe.c (get_fringe_bitmap_data): New function.
6138 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6139 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6140 row. Mark glyph row for fringe update if periodicity changed.
6142 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6143 for fringe update unless it has periodic bitmap.
6145 2011-05-25 Kenichi Handa <handa@m17n.org>
6147 * xdisp.c (get_next_display_element): Set correct it->face_id for
6148 a static composition.
6150 2011-05-24 Leo Liu <sdl.web@gmail.com>
6153 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6155 * fns.c (crypto_hash_function, Fsha1): New function.
6156 (Fmd5): Use crypto_hash_function.
6157 (syms_of_fns): Add Ssha1.
6159 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6161 * gnutls.c: Remove unused macros.
6162 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6163 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6164 Remove macros that are defined and never used.
6165 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6167 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6169 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6170 (Fx_get_selection_internal): Minor cleanup.
6171 (Fx_own_selection_internal): Rename arguments for consistency with
6174 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6176 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6178 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6180 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6182 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6184 * dispnew.c (scrolling_window): Don't exclude the case that the
6185 last enabled row in the desired matrix touches the bottom boundary.
6187 2011-05-21 Glenn Morris <rgm@gnu.org>
6189 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6190 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6191 and add some more files.
6193 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6195 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6196 report_file_error introduced by the change from 2011-05-07.
6198 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6200 * systime.h (Time): Define only if emacs is defined.
6201 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6202 where the include path doesn't have X11/X.h by default. See
6203 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6205 2011-05-20 Kenichi Handa <handa@m17n.org>
6207 * composite.c (find_automatic_composition): Fix previous change.
6209 2011-05-20 Glenn Morris <rgm@gnu.org>
6211 * lisp.mk: New file, split from Makefile.in.
6212 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6213 (shortlisp): Remove.
6214 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6216 2011-05-19 Glenn Morris <rgm@gnu.org>
6218 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6219 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6220 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6221 (lisp): Set the order to that of loadup.el.
6222 (shortlisp): Make it a copy of $lisp.
6223 (SOME_MACHINE_LISP): Remove.
6224 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6225 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6227 2011-05-18 Kenichi Handa <handa@m17n.org>
6229 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6230 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6231 (find_automatic_composition): Mostly rewrite for efficiency.
6233 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6235 * makefile.w32-in: Update dependencies.
6237 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6239 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6240 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6242 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6244 Fix some integer overflow issues, such as string length overflow.
6246 * insdel.c (count_size_as_multibyte): Check for string overflow.
6248 * character.c (lisp_string_width): Check for string overflow.
6249 Use EMACS_INT, not int, for string indexes and lengths; in
6250 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6251 the resulting string length overflows an EMACS_INT; instead,
6252 report a string overflow if no precision given. When checking for
6253 precision exhaustion, use a check that cannot possibly have
6254 integer overflow. (Bug#8675)
6255 * character.h (lisp_string_width): Adjust to new signature.
6257 * alloc.c (string_overflow): New function.
6258 (Fmake_string): Use it. This doesn't change behavior, but saves
6259 a few bytes and will simplify future changes.
6260 * character.c (string_escape_byte8): Likewise.
6261 * lisp.h (string_overflow): New decl.
6263 Fixups, following up to the user-interface timestamp change.
6264 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6265 for UI timestamps, instead of unsigned long.
6266 * msdos.c (mouse_get_pos): Likewise.
6267 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6268 * w32gui.h (Time): Define by including "systime.h" rather than by
6269 declaring it ourselves. (Bug#8664)
6271 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6272 * image.c (clear_image_cache): Likewise.
6274 * term.c (term_mouse_position): Don't assume time_t wraparound.
6276 Be more systematic about user-interface timestamps.
6277 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6278 and sometimes 'EMACS_UINT', to represent these timestamps.
6279 This change causes it to use 'Time' uniformly, as that's what X uses.
6280 This makes the code easier to follow, and makes it easier to catch
6281 integer overflow bugs such as Bug#8664.
6282 * frame.c (Fmouse_position, Fmouse_pixel_position):
6283 Use Time, not unsigned long, for user-interface timestamps.
6284 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6285 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6286 * keyboard.h (last_event_timestamp): Likewise.
6287 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6288 * menu.h (xmenu_show): Likewise.
6289 * term.c (term_mouse_position): Likewise.
6290 * termhooks.h (struct input_event.timestamp): Likewise.
6291 (struct terminal.mouse_position_hook): Likewise.
6292 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6293 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6294 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6295 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6297 * menu.h, termhooks.h: Include "systime.h", for Time.
6299 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6300 Don't assume that the difference between two unsigned long values
6301 can fit into an integer. At this point, we know button_down_time
6302 <= event->timestamp, so the difference must be nonnegative, so
6303 there's no need to cast the result if double-click-time is
6304 nonnegative, as it should be; check that it's nonnegative, just in
6305 case. This bug is triggered when events are more than 2**31 ms
6306 apart (about 25 days). (Bug#8664)
6308 * xselect.c (last_event_timestamp): Remove duplicate decl.
6309 (x_own_selection): Remove needless cast to unsigned long.
6311 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6312 that always fit in int. Use a sentinel instead of a counter, to
6313 avoid a temp and to allay GCC's concerns about possible int overflow.
6314 * frame.h (struct frame): Use int for menu_bar_items_used
6315 instead of EMACS_INT, since it always fits in int.
6317 * menu.c (grow_menu_items): Check for int overflow.
6319 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6321 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6322 Before, the code was not consistent. These values cannot exceed
6323 2**31 - 1 so there's no need to make them unsigned.
6324 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6325 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6326 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6328 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6330 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6331 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6332 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6333 presumably because the widths might not match.
6335 * window.c (size_window): Avoid needless test at loop start.
6337 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6339 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6341 2011-05-12 Drew Adams <drew.adams@oracle.com>
6343 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6345 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6347 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6348 `width' to `bar_area_x' and `bar_area_width', respectively.
6349 (x_scroll_run): Take account of fringe background extension.
6351 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6352 Rename local vars `left' and `width' to `bar_area_x' and
6353 `bar_area_width', respectively.
6354 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6355 background extension.
6357 2011-05-10 Jim Meyering <meyering@redhat.com>
6359 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6361 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6363 * image.c (Finit_image_library): Return t for built-in image types,
6364 like pbm and xbm. (Bug#8640)
6366 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6368 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6370 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6372 * w32console.c (Fset_screen_color): Doc fix.
6373 (Fget_screen_color): New function.
6374 (syms_of_ntterm): Defsubr it.
6376 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6377 unlink the temporary file if Fcall_process didn't create it in the
6379 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6380 child process will be redirected to a file specified with `:file'.
6381 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6382 cue to call_process_cleanup not to close that handle.
6384 2011-05-07 Ben Key <bkey76@gmail.com>
6386 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6387 one of two shell specific rules, either bootstrap-temacs-CMD or
6388 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6389 to the previous implementation of the bootstrap-temacs rule.
6390 The bootstrap-temacs-CMD rule is similar to the previous
6391 implementation of the bootstrap-temacs rule except that it
6392 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6395 These changes, along with some changes to nt/configure.bat,
6396 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6397 earlier fix to add support for --cflags and --ldflags options
6398 that include quotes so that it works whether make uses cmd or
6401 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6403 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6404 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6406 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6407 a string. Handle both cases.
6408 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6409 (Fdbus_register_method): Use Qinvalid_function.
6411 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6413 * makefile.w32-in: Update dependencies.
6414 (LISP_H): Add inttypes.h and stdin.h.
6415 (PROCESS_H): Add unistd.h.
6417 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6419 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6420 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6422 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6424 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6426 * term.c (vfatal): Remove stray call to va_end.
6427 It's not needed and the C Standard doesn't allow it here anyway.
6429 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6430 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6432 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6435 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6437 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6439 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6441 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6443 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6445 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6446 * charset.c (Fdefine_charset_internal): Don't initialize
6447 charset.code_space[15]. The value was garbage, on hosts with
6448 32-bit int (Bug#8600).
6450 * lread.c (read_integer): Be more consistent with string-to-number.
6451 Use string_to_number to do the actual conversion; this avoids
6452 rounding errors and fixes some other screwups. Without this fix,
6453 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6454 (digit_to_number): Move earlier, for benefit of read_integer.
6455 Return -1 if the digit is out of range for the base, -2 if it is
6456 not a digit in any supported base. (Bug#8602)
6458 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6460 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6461 to match comment at start of function. This also removes a
6462 GCC warning about overflow in a 32+64-bit port.
6464 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6466 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6467 Reported by Stefan Monnier in
6468 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6469 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6470 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6472 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6473 (EMACS_UINTPTR): Likewise, with uintptr_t.
6475 * lisp.h: Prefer 64-bit EMACS_INT if available.
6476 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6477 on 32-bit hosts that have 64-bit int, so that they can access
6479 However, temporarily disable this change unless the temporary
6480 symbol WIDE_EMACS_INT is defined.
6482 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6484 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6485 This removes an assumption that EMACS_INT and long are the same
6486 width as pointers. The assumption is true for Emacs porting targets
6487 now, but we want to make other targets possible.
6488 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6489 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6490 In the rest of the code, change types of integers that hold casted
6491 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6492 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6493 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6494 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6495 No need to cast type when ORing.
6496 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6497 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6498 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6499 assume EMACS_INT is the same width as char *.
6500 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6501 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6502 Remove no-longer-needed casts.
6503 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6504 (xg_tool_bar_help_callback, xg_make_tool_item):
6505 Use EMACS_INTPTR to hold an integer
6506 that will be cast to void *; this can avoid a GCC warning
6507 if EMACS_INT is not the same width as void *.
6508 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6509 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6510 (current_message_1, set_message_1):
6511 Use a local to convert to proper width without a cast.
6512 * xmenu.c (dialog_selection_callback): Likewise.
6514 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6515 Also, don't assume VALBITS / RAND_BITS is less than 5,
6516 and don't rely on undefined behavior when shifting a 1 left into
6518 * lisp.h (get_random): Change signature to match.
6520 * lread.c (hash_string): Use size_t, not int, for hash computation.
6521 Normally we prefer signed values; but hashing is special, because
6522 it's better to use unsigned division on hash table sizes so that
6523 the remainder is nonnegative. Also, size_t is the natural width
6524 for hashing into memory. The previous code used 'int', which doesn't
6525 retain enough info to hash well into very large tables.
6526 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6528 * dbusbind.c: Don't possibly lose pointer info when converting.
6529 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6530 Use XPNTR rather than XHASH, so that the high-order bits of
6531 the pointer aren't lost when converting through void *.
6533 * eval.c (Fautoload): Don't double-shift a pointer.
6535 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6537 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6539 * gnutls.c (DEF_GNUTLS_FN):
6540 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6542 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6544 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6547 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6549 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6550 New version that can reserve upto 2GB of heap space.
6552 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6554 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6556 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6558 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6559 `gnutls_certificate_set_x509_key_file'.
6561 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6563 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6564 Update dependencies.
6566 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6568 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6569 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6570 Remove unused parameter `fildes'.
6571 * process.c (read_process_output, send_process): Don't pass it.
6573 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6575 Fix previous change: the library cache is defined in w32.c.
6576 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6577 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6579 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6581 Implement dynamic loading of GnuTLS on Windows.
6583 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6584 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6585 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6588 * gnutls.c (Qgnutls_dll): Define.
6589 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6590 (gnutls_*): Declare function pointers.
6591 (init_gnutls_functions): New function to initialize function pointers.
6592 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6593 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6594 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6595 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6596 (emacs_gnutls_write, emacs_gnutls_read)
6597 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6598 (Fgnutls_available_p): New function.
6599 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6600 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6601 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6603 * image.c: Include w32.h.
6604 (Vimage_type_cache): Delete.
6605 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6606 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6607 (w32_delayed_load): Move to w32.c.
6609 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6611 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6612 (w32_delayed_load): Move from image.c. When loading a library, record
6613 its filename in the :loaded-from property of the library id.
6614 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6615 Initialize and staticpro them.
6616 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6618 * process.c: Include lisp.h before w32.h, not after.
6619 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6620 instead of gnutls_record_check_pending.
6622 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6624 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6626 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6627 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6630 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6632 * xterm.c (x_set_frame_alpha): Do not set property on anything
6633 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6635 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6637 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6639 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6641 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6642 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6643 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6644 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6645 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6646 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6647 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6648 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6649 (Qgnutls_bootprop_callbacks_verify): Make static.
6651 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6653 * callproc.c: Indentation fixup.
6655 * sysdep.c (wait_for_termination_1): Make static.
6656 (wait_for_termination, interruptible_wait_for_termination):
6657 Move after wait_for_termination_1.
6659 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6661 * sysdep.c (interruptible_wait_for_termination): New function
6662 which is like wait_for_termination, but allows keyboard
6665 * callproc.c (Fcall_process): Add (:file "file") as an option for
6667 (Fcall_process_region): Ditto.
6669 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6671 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6672 rather than `XVECTOR (FOO)->size'.
6674 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6675 inttypes.h, as a gnulib replacement is used if it not available in
6678 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6680 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6681 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6682 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6684 * coding.c (coding_alloc_by_realloc): Error out if destination
6685 will grow beyond MOST_POSITIVE_FIXNUM.
6686 (decode_coding_emacs_mule): Abort if there isn't enough place in
6687 charbuf for the composition carryover bytes. Reserve an extra
6688 space for up to 2 characters produced in a loop.
6689 (decode_coding_iso_2022): Abort if there isn't enough place in
6690 charbuf for the composition carryover bytes.
6692 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6694 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6695 aborting when %lld or %lll format is passed.
6696 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6697 %llo or %llx format is passed. (Bug#8545)
6699 * window.c (window_scroll_line_based): Use a marker instead of
6700 simple variables to record original value of point. (Bug#7952)
6702 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6703 produced by %s or %c overflows available buffer space. (Bug#8545)
6705 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6707 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6708 (SIZE_MAX): Move defn after all includes, as they might #define it.
6710 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6712 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6714 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6716 * keyboard.c (Qdelayed_warnings_hook): Define.
6717 (command_loop_1): Run `delayed-warnings-hook'
6718 if Vdelayed_warnings_list is non-nil.
6719 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6720 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6722 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6724 * doprnt.c (doprnt): Don't return value smaller than the buffer
6725 size if the message was truncated. (Bug#8545).
6727 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6729 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6730 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6732 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6734 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6736 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6738 * makefile.w32-in: Update dependencies.
6740 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6742 Improve `doprnt' and its usage. (Bug#8545)
6743 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6744 `format_end'. Remove support for %l as a conversion specifier.
6745 Don't use xrealloc. Improve diagnostics when the %l size modifier
6746 is used. Update the commentary.
6748 * eval.c (verror): Simplify calculation of size_t.
6750 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6753 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6755 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6758 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6760 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6761 This makes this file independent of the recent pseudovector change.
6763 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6765 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6767 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6768 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6769 Remove unused local.
6770 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6772 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6773 GCC 4.6.0 optimizes based on type-based alias analysis.
6774 For example, if b is of type struct buffer * and v of type struct
6775 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6776 != &v->size, and therefore "v->size = 1; b->size = 2; return
6777 v->size;" must therefore return 1. This assumption is incorrect
6778 for Emacs, since it type-puns struct Lisp_Vector * with many other
6779 types. To fix this problem, this patch adds a new type struct
6780 vectorlike_header that documents the constraints on layout of vectors
6781 and pseudovectors, and helps optimizing compilers not get fooled
6782 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6783 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6784 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6786 (XSETPVECTYPE): Rewrite in terms of new macro.
6787 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6788 This is a bit clearer, and further avoids the possibility of
6789 undesirable aliasing.
6790 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6791 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6792 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6793 since Lisp_Subr is a special case (no "next" field).
6794 (ASIZE): Now uses header.size rather than size.
6795 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6796 to avoid the hassle of writing XVECTOR (foo)->header.size.
6797 (struct vectorlike_header): New type.
6798 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6799 object, to help avoid aliasing.
6800 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6801 (SUBRP): Likewise, since Lisp_Subr is a special case.
6802 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6803 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6804 (struct Lisp_Hash_Table): Combine first two members into a single
6805 struct vectorlike_header member. All uses of "size" and "next" members
6806 changed to be "header.size" and "header.next".
6807 * buffer.h (struct buffer): Likewise.
6808 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6809 * frame.h (struct frame): Likewise.
6810 * process.h (struct Lisp_Process): Likewise.
6811 * termhooks.h (struct terminal): Likewise.
6812 * window.c (struct save_window_data, struct saved_window): Likewise.
6813 * window.h (struct window): Likewise.
6814 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6815 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6816 * buffer.c (init_buffer_once): Likewise.
6817 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6819 * process.c (Fformat_network_address): Use local var for size,
6822 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6824 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6825 * data.c (atof): Remove decl; no longer used or needed.
6826 (digit_to_number): Move to lread.c.
6827 (Fstring_to_number): Use new string_to_number function, to be
6828 consistent with how the Lisp reader treats infinities and NaNs.
6829 Do not assume that floating-point numbers represent EMACS_INT
6830 without losing information; this is not true on most 64-bit hosts.
6831 Avoid double-rounding errors, by insisting on integers when
6832 parsing non-base-10 numbers, as the documentation specifies.
6833 * lisp.h (string_to_number): New decl, replacing ...
6834 (isfloat_string): Remove.
6835 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6836 (read1): Do not accept +. and -. as integers; this
6837 appears to have been a coding error. Similarly, do not accept
6838 strings like +-1e0 as floating point numbers. Do not report
6839 overflow for integer overflows unless the base is not 10 which
6840 means we have no simple and reliable way to continue.
6841 Break out the floating-point parsing into a new
6842 function string_to_number, so that Fstring_to_number parses
6843 floating point numbers consistently with the Lisp reader.
6844 (digit_to_number): Move here from data.c. Make it static inline.
6845 (E_CHAR, EXP_INT): Remove, replacing with ...
6846 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6847 (string_to_number): New function, replacing isfloat_string.
6848 This function checks for valid syntax and produces the resulting
6849 Lisp float number too. Rework it so that string-to-number
6850 no longer mishandles examples like "1.0e+". Use strtoumax,
6851 so that overflow for non-base-10 numbers is reported only when
6852 there's no portable and simple way to convert to floating point.
6854 * textprop.c (set_text_properties_1): Rewrite for clarity,
6855 and to avoid GCC warning about integer overflow.
6857 * intervals.h (struct interval): Use EMACS_INT for members
6858 where EMACS_UINT might cause problems. See
6859 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6860 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6861 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6863 (offset_intervals): Tell GCC not to worry about length overflow
6864 when negating a negative length.
6866 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6867 (overrun_check_free): Likewise.
6869 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6870 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6873 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6874 (gnutls_make_error): Rename local to avoid shadowing.
6875 (gnutls_emacs_global_deinit): ifdef out; not used.
6876 (Fgnutls_boot): Use const for pointer to readonly storage.
6877 Comment out unused local. Fix pointer signedness problems.
6879 * lread.c (openp): Don't stuff size_t into an 'int'.
6880 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6881 about possible signed overflow.
6883 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6884 (GDK_KEY_g): Don't define if already defined.
6885 (xg_prepare_tooltip): Avoid pointer signedness problem.
6886 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6888 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6889 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6891 * xfns.c (Fx_window_property): Simplify a bit,
6892 to make a bit faster and to avoid GCC 4.6.0 warning.
6893 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6895 * fns.c (internal_equal): Don't assume size_t fits in int.
6897 * alloc.c (compact_small_strings): Tighten assertion a little.
6899 Replace pEd with more-general pI, and fix some printf arg casts.
6900 * lisp.h (pI): New macro, generalizing old pEd macro to other
6901 conversion specifiers. For example, use "...%"pI"d..." rather
6902 than "...%"pEd"...".
6903 (pEd): Remove. All uses replaced with similar uses of pI.
6904 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6905 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6906 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6907 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6908 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6909 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6910 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6912 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6913 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6914 * print.c (safe_debug_print, print_object): Likewise.
6915 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6917 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6918 avoiding the 0 flag, which is not portable.
6919 * process.c (Fmake_network_process): Use pI to avoid cast.
6920 * region-cache.c (pp_cache): Likewise.
6921 * xdisp.c (decode_mode_spec): Likewise.
6922 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6923 behavior on 64-bit hosts with printf arg.
6924 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6925 (x_stop_queuing_selection_requests): Likewise.
6926 (x_get_window_property): Don't truncate byte count to an 'int'
6929 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6930 here, since it parses constructs like leading '-' and spaces,
6931 which are not wanted; and it overflows with large numbers.
6932 Instead, simply match F[0-9]+, which is what is wanted anyway.
6934 * alloc.c: Remove unportable assumptions about struct layout.
6935 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6936 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6937 (allocate_vectorlike, make_pure_vector): Use the new macros,
6938 plus offsetof, to remove unportable assumptions about struct layout.
6939 These assumptions hold on all porting targets that I know of, but
6940 they are not guaranteed, they're easy to remove, and removing them
6941 makes further changes easier.
6943 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6944 This doesn't fix a bug but makes the code clearer.
6945 (string_overrun_cookie): Now const. Use initializers that
6946 don't formally overflow signed char, to avoid warnings.
6947 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6948 can cause Emacs to crash when string overrun checking is enabled.
6949 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6950 multiple of sizeof (EMACS_INT); it need not be, if
6951 alignof(EMACS_INT) < sizeof (EMACS_INT).
6952 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6954 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6956 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6958 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6960 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6961 supposed to be handshaking. (Bug#8556)
6962 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6964 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6966 * lisp.h (Qdebug): List symbol.
6967 * eval.c (Qdebug): Restore global linkage.
6968 * keyboard.c (debug-on-event): New variable.
6969 (handle_user_signal): Break into debugger when debug-on-event
6970 matches the current signal symbol.
6972 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6974 * alloc.c (check_sblock, check_string_bytes)
6975 (check_string_free_list): Convert to standard C.
6977 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6979 * w32.c (emacs_gnutls_push): Fix typo.
6981 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6983 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6984 "cast to pointer from integer of different size".
6986 Improve doprnt and its use in verror. (Bug#8545)
6987 * doprnt.c (doprnt): Document the set of format control sequences
6988 supported by the function. Use SAFE_ALLOCA instead of always
6991 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6992 is one byte too soon. Don't use xrealloc; instead xfree and
6995 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6997 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7000 * gnutls.c: Renamed global_initialized to
7001 gnutls_global_initialized. Added internals for the
7002 :verify-hostname-error, :verify-error, and :verify-flags
7003 parameters of `gnutls-boot' and documented those parameters in the
7004 docstring. Start callback support.
7005 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7006 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7007 on error. Return error code.
7008 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7009 (emacs_gnutls_read): Likewise.
7010 (Fgnutls_boot): Return handshake error code.
7011 (emacs_gnutls_handle_error): New function.
7012 (wsaerror_to_errno): Likewise.
7014 * w32.h (emacs_gnutls_pull): Add prototype.
7015 (emacs_gnutls_push): Likewise.
7017 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7018 (emacs_gnutls_push): Likewise.
7020 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7022 * process.c (wait_reading_process_output): Check if GnuTLS
7023 buffered some data internally if no FDs are set for TLS
7026 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7027 (LIBS): Link to USER_LIBS.
7028 ($(BLD)/gnutls.$(0)): New target.
7030 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7032 * xdisp.c (handle_single_display_spec): Rename the
7033 display_replaced_before_p argument into display_replaced_p, to
7034 make it consistent with the commentary. Fix typos in the
7037 * textprop.c (syms_of_textprop): Remove dead code.
7038 (copy_text_properties): Delete obsolete commentary about an
7039 interface that was deleted long ago. Fix typos in the description
7042 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7043 to changes in oldXMenu/XMenu.h from 2011-04-16.
7044 <menu_help_message, prev_menu_help_message>: Constify.
7045 (IT_menu_make_room): menu->help_text is now `const char **';
7048 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7049 to changes in oldXMenu/XMenu.h from 2011-04-16.
7050 (struct XMenu): Declare `help_text' `const char **'.
7052 * xfaces.c <Qunspecified>: Make extern again.
7054 * syntax.c: Include sys/types.h before including regex.h, as
7057 * doc.c (get_doc_string): Improve the format passed to `error'.
7059 * doprnt.c (doprnt): Improve commentary.
7061 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7063 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7066 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7067 changes in globals.h immediately force recompilation.
7068 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7069 $(CURDIR)/s/ms-w32.h.
7070 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7072 * character.c (Fchar_direction): Function deleted.
7073 (syms_of_character): Don't defsubr it.
7074 <char-direction-table>: Deleted.
7076 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7078 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7079 * doprnt.c: Include limits.h.
7080 (SIZE_MAX): New macro.
7081 (doprnt): Return a size_t value. 2nd arg is now size_t.
7082 Many local variables are now size_t instead of int or unsigned.
7083 Improve overflow protection. Support `l' modifier for integer
7084 conversions. Support %l conversion. Don't assume an EMACS_INT
7085 argument for integer conversions and for %c.
7087 * lisp.h (doprnt): Restore prototype.
7089 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7092 * Makefile.in (base_obj): Add back doprnt.o.
7094 * deps.mk (doprnt.o): Add back prerequisites.
7095 (callint.o): Depend on character.h.
7097 * eval.c (internal_lisp_condition_case): Include the handler
7098 representation in the error message.
7099 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7100 when breaking from the loop.
7102 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7104 * callint.c (Fcall_interactively): When displaying error message
7105 about invalid control letter, pass the character's codepoint, not
7106 a pointer to its multibyte form. Improve display of the character
7107 in octal and display also its hex code.
7109 * character.c (char_string): Use %x to display the (unsigned)
7110 codepoint of an invalid character, to avoid displaying a bogus
7113 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7114 `error', not SYMBOL_NAME itself.
7116 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7117 character arguments to `error'.
7119 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7120 to `error' in error message about FINAL_CHAR argument. Make sure
7121 FINAL_CHAR is a character, and use %c when it is passed as
7122 argument to `error'.
7124 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7126 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7128 * w32.c: Include <time.h>.
7129 (sys_localtime): New function.
7131 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7133 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7135 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7137 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7139 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7142 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7144 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7145 gl_state.e_property when gl_state.object is Qt.
7147 * insdel.c (make_gap_larger): Remove limitation of buffer size
7150 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7152 * xdisp.c (lookup_glyphless_char_display)
7153 (produce_glyphless_glyph): Handle cons cell entry in
7154 glyphless-char-display.
7155 (Vglyphless_char_display): Document it.
7157 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7158 glyphless-char-display.
7160 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7162 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7164 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7166 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7167 definition for no-X builds.
7169 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7171 Static checks with GCC 4.6.0 and non-default toolkits.
7173 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7175 * process.c (keyboard_bit_set): Define only if SIGIO.
7176 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7177 (send_process): Repair possible setjmp clobbering.
7179 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7181 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7183 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7185 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7186 Define only if needed.
7188 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7189 by pacifying GCC about it. Maybe it's time to retire it?
7190 * xfaces.c (USG, __TIMEVAL__): Likewise.
7192 * dispextern.h (struct redisplay_interface): Rename param
7194 * termhooks.h (struct terminal): Likewise.
7195 * xterm.c (xembed_send_message): Likewise.
7197 * insdel.c (make_gap_smaller): Define only if
7198 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7200 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7203 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7204 so that we aren't warned about unused symbols.
7206 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7208 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7210 * xfns.c (x_real_positions): Mark locals as initialized.
7212 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7214 * xterm.c: Fix problems found by static analysis with other toolkits.
7215 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7216 (x_dispatch_event): Declare static if USE_GTK, and
7217 define if USE_GTK || USE_X_TOOLKIT.
7218 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7219 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7220 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7221 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7223 * xmenu.c (menu_help_callback): Pointer type fixes.
7224 Use const pointers when pointing at readonly data. Avoid pointer
7226 (FALSE): Remove unused macro.
7227 (update_frame_menubar): Remove unused decl.
7229 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7231 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7232 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7233 (single_menu_item): Rename local to avoid shadowing.
7235 * keyboard.c (make_lispy_event): Remove unused local var.
7237 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7238 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7240 * bitmaps: Change bitmaps from unsigned char back to the X11
7241 compatible char. Avoid the old compiler warnings about
7242 out-of-range initializers by using, for example, '\xab' rather
7245 * xgselect.c (xgselect_initialize): Check vs interface
7246 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7248 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7250 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7251 to read-only memory.
7253 * fns.c (vector): Remove; this old hack is no longer needed.
7255 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7257 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7259 * xrdb.c (x_load_resources): Omit unused local.
7261 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7262 (x_window): Rename locals to avoid shadowing.
7263 (USG): Use the kludged USG macro, to pacify gcc.
7265 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7266 (x_term_init): Remove local to avoid shadowing.
7268 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7270 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7271 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7273 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7275 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7277 Fix regex.c, syntax.c and friends for buffers > 2GB.
7278 * syntax.h (struct gl_state_s): Declare character position members
7281 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7283 * textprop.c (verify_interval_modification, interval_of):
7284 Declare arguments EMACS_INT.
7286 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7289 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7291 * indent.c (Fvertical_motion): Local variable it_start is now
7294 * regex.c (re_match, re_match_2, re_match_2_internal)
7295 (bcmp_translate, regcomp, regexec, print_double_string)
7296 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7297 (re_compile_pattern, re_exec): Declare arguments and local
7298 variables `size_t' and `ssize_t' and return values `regoff_t', as
7300 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7301 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7302 <compile_stack_type>: `size' and `avail' are now `size_t'.
7304 * regex.h <regoff_t>: Use ssize_t, not int.
7305 (re_search, re_search_2, re_match, re_match_2): Arguments that
7306 specify buffer/string position and length are now ssize_t and
7307 size_t. Return type is regoff_t.
7309 2011-04-16 Ben Key <bkey76@gmail.com>
7311 * nsfont.m: Fixed bugs in ns_get_family and
7312 ns_descriptor_to_entity that were caused by using free to
7313 deallocate memory blocks that were allocated by xmalloc (via
7314 xstrdup). This caused Emacs to crash when compiled with
7315 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7316 --enable-checking=xmallocoverrun). xfree is now used to
7317 deallocate these memory blocks.
7319 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7321 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7323 emacs_write: Accept and return EMACS_INT for sizes.
7324 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7326 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7327 Accept and return EMACS_INT.
7328 (emacs_gnutls_write): Return the number of bytes written on
7330 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7331 (emacs_read, emacs_write): Remove check for negative size, as the
7332 Emacs source code has been audited now.
7333 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7334 (emacs_read, emacs_write): Use it.
7335 * process.c (send_process): Adjust to the new signatures of
7336 emacs_write and emacs_gnutls_write. Do not attempt to store
7337 a byte offset into an 'int'; it might overflow.
7338 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7340 * sound.c: Don't assume sizes fit in 'int'.
7341 (struct sound_device.period_size, alsa_period_size):
7342 Return EMACS_INT, not int.
7343 (struct sound_device.write, vox_write, alsa_write):
7344 Accept EMACS_INT, not int.
7345 (wav_play, au_play): Use EMACS_INT to store sizes and to
7346 record read return values.
7348 2011-04-15 Ben Key <bkey76@gmail.com>
7350 * keyboard.c (Qundefined): Don't declare static since it is used
7352 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7353 static since they are used in nsfont.m.
7355 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7357 * process.c (Qprocessp): Don't declare static.
7358 * lisp.h (Qprocessp): Declare again.
7360 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7362 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7364 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7366 Improve C-level modularity by making more things 'static'.
7368 Don't publish debugger-only interfaces to other modules.
7369 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7370 (verify_bytepos, count_markers): Move decls to the only modules
7372 * region-cache.h (pp_cache): Likewise.
7373 * window.h (check_all_windows): Likewise.
7374 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7376 * sysdep.c (croak): Now static, if
7377 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7378 * syssignal.h (croak): Declare only if not static.
7380 * alloc.c (refill_memory_reserve): Now static if
7381 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7382 * lisp.h (refill_memory_reserve): Declare only if not static.
7384 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7385 Define only if USE_LUCID.
7387 * xrdb.c (x_customization_string, x_rm_string): Now static.
7389 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7390 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7392 * xdisp.c (draw_row_with_mouse_face): Now static.
7393 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7395 * window.h (check_all_windows): Mark externally visible.
7397 * window.c (window_deletion_count): Now static.
7399 * undo.c: Make symbols static if they're not exported.
7400 (last_undo_buffer, last_boundary_position, pending_boundary):
7403 * textprop.c (interval_insert_behind_hooks): Now static.
7404 (interval_insert_in_front_hooks): Likewise.
7406 * term.c: Make symbols static if they're not exported.
7407 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7408 (max_frame_lines, tty_set_terminal_modes):
7409 (tty_reset_terminal_modes, tty_turn_off_highlight):
7410 (get_tty_terminal): Now static.
7411 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7412 * termhooks.h (term_mouse_moveto): Do not declare if
7414 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7415 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7417 * sysdep.c: Make symbols static if they're not exported.
7418 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7420 (sigprocmask_set, full_mask): Remove; unused.
7421 (wait_debugging): Mark as visible.
7422 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7423 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7425 * syntax.c (syntax_temp): Define only if !__GNUC__.
7427 * sound.c (current_sound_device, current_sound): Now static.
7429 * search.c (searchbufs, searchbuf_head): Now static.
7431 * scroll.c (scroll_cost): Remove; unused.
7432 * dispextern.h (scroll_cost): Remove decl.
7434 * region-cache.h (pp_cache): Mark as externally visible.
7436 * process.c: Make symbols static if they're not exported.
7437 (process_tick, update_tick, create_process, chan_process):
7438 (Vprocess_alist, proc_buffered_char, datagram_access):
7439 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7440 (deactivate_process): Mark defn as static, as well as decl.
7441 * lisp.h (create_process): Remove decl.
7442 * process.h (chan_process, Vprocess_alist): Remove decls.
7444 * print.c: Make symbols static if they're not exported.
7445 (print_depth, new_backquote_output, being_printed, print_buffer):
7446 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7447 (print_interval, print_number_index, initial_stderr_stream):
7449 * lisp.h (Fprinc): Remove decl.
7450 (debug_output_compilation_hack): Mark as externally visible.
7452 * sysdep.c (croak): Move decl from here to syssignal.h.
7453 * syssignal.h (croak): Put it here, so the API can be checked when
7454 'croak' is called from dissociate_if_controlling_tty.
7456 * minibuf.c: Make symbols static if they're not exported.
7457 (minibuf_save_list, choose_minibuf_frame): Now static.
7458 * lisp.h (choose_minibuf_frame): Remove decl.
7460 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7462 * lread.c: Make symbols static if they're not exported.
7463 (read_objects, initial_obarray, oblookup_last_bucket_number):
7465 (make_symbol): Remove; unused.
7466 * lisp.h (initial_obarray, make_symbol): Remove decls.
7468 * keyboard.c: Make symbols static if they're not exported.
7469 (single_kboard, recent_keys_index, total_keys, recent_keys):
7470 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7471 (this_single_command_key_start, echoing, last_auto_save):
7472 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7473 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7474 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7475 (Vlispy_mouse_stem, double_click_count):
7477 (force_auto_save_soon): Define only if SIGDANGER.
7478 (ignore_mouse_drag_p): Now static if
7479 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7480 (print_help): Remove; unused.
7481 (stop_character, last_timer_event): Mark as externally visible.
7482 * keyboard.h (ignore_mouse_drag_p): Declare only if
7483 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7484 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7485 * lisp.h (echoing): Remove decl.
7486 (force_auto_save_soon): Declare only if SIGDANGER.
7487 * xdisp.c (redisplay_window): Simplify code, to make it more
7488 obvious that ignore_mouse_drag_p is not accessed if !defined
7489 USE_GTK && !defined HAVE_NS.
7491 * intervals.c: Make symbols static if they're not exported.
7492 (merge_properties_sticky, merge_interval_right, delete_interval):
7494 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7496 * insdel.c: Make symbols static if they're not exported.
7497 However, leave prepare_to_modify_buffer alone. It's never
7498 called from outside this function, but that appears to be a bug.
7499 (combine_after_change_list, combine_after_change_buffer):
7500 (adjust_after_replace, signal_before_change): Now static.
7501 (adjust_after_replace_noundo): Remove; unused.
7502 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7503 (signal_before_change): Remove decls.
7505 * indent.c (val_compute_motion, val_vmotion): Now static.
7507 * image.c: Make symbols static if they're not exported.
7508 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7510 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7511 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7513 * fringe.c (standard_bitmaps): Now static.
7514 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7516 * frame.c: Make symbols static if they're not exported.
7517 (x_report_frame_params, make_terminal_frame): Now static.
7518 (get_frame_param): Now static, unless HAVE_NS.
7519 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7520 (x_get_resource_string): Remove; not used.
7521 * frame.h (make_terminal_frame, x_report_frame_params):
7522 (x_get_resource_string); Remove decls.
7523 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7524 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7526 * font.c, fontset.c: Make symbols static if they're not exported.
7527 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7528 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7529 * font.c (font_close_object): Now static.
7530 * font.h (font_close_object): Remove.
7531 * fontset.c (FONTSET_OBJLIST): Remove.
7532 (free_realized_fontset) #if-0 the body, which does nothing.
7533 (face_suitable_for_char_p): #if-0, as it's never called.
7534 * fontset.h (face_suitable_for_char_p): Remove decl.
7535 * xfaces.c (face_at_string_position):
7536 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7537 since 0 is always ASCII.
7539 * fns.c (weak_hash_tables): Now static.
7541 * fileio.c: Make symbols static if they're not exported.
7542 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7543 (Vwrite_region_annotation_buffers): Now static.
7545 * eval.c: Make symbols static if they're not exported.
7546 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7547 * lisp.h (backtrace_list): Remove decl.
7549 * emacs.c: Make symbols static if they're not exported.
7550 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7551 (fatal_error_code, fatal_error_signal_hook, standard_args):
7553 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7554 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7555 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7556 * lisp.h (fatal_error_signal_hook): Remove decl.
7557 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7559 * editfns.c: Move a (normally-unused) function to its only use.
7560 * editfns.c, lisp.h (get_operating_system_release): Remove.
7561 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7562 worth the hassle of breaking this out.
7564 * xterm.c: Make symbols static if they're not exported.
7565 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7566 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7567 (x_destroy_window, x_delete_display):
7569 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7570 (x_mouse_leave): Remove; unused.
7571 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7572 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7573 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7575 (x_mouse_leave): Declare only if WINDOWSNT.
7576 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7577 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7580 * ftxfont.c: Make symbols static if they're not exported.
7581 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7583 * font.h (ftxfont_driver): Likewise.
7585 * xfns.c: Make symbols static if they're not exported.
7586 (x_last_font_name, x_display_info_for_name):
7587 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7588 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7589 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7590 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7591 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7592 (last_show_tip_args): Now static.
7593 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7594 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7595 (x_screen_planes): Remove; unused.
7596 * dispextern.h (x_screen_planes): Remove decl.
7598 * dispnew.c: Make symbols static if they're not exported.
7599 * dispextern.h (redraw_garbaged_frames, scrolling):
7600 (increment_row_positions): Remove.
7601 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7602 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7604 (redraw_garbaged_frames): Remove; unused.
7606 * xfaces.c: Make symbols static if they're not exported.
7607 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7609 * xterm.h (defined_color): Remove decls.
7610 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7611 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7612 (menu_face_changed_default, defined_color, free_realized_face):
7613 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7614 (ascii_face_of_lisp_face): Remove; unused.
7616 * xdisp.c: Make symbols static if they're not exported.
7617 * dispextern.h (scratch_glyph_row, window_box_edges):
7618 (glyph_to_pixel_coords, set_cursor_from_row):
7619 (get_next_display_element, set_iterator_to_next):
7620 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7621 (show_mouse_face): Remove decls
7622 * frame.h (message_buf_print): Likewise.
7623 * lisp.h (pop_message, set_message, check_point_in_composition):
7625 * xterm.h (set_vertical_scroll_bar): Likewise.
7626 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7627 (message_buf_print, scratch_glyph_row, displayed_buffer):
7628 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7629 (get_next_display_element, show_mouse_face, window_box_edges):
7630 (frame_to_window_pixel_xy, check_point_in_composition):
7631 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7632 (glyph_to_pixel_coords): Remove; unused.
7634 * dired.c (file_name_completion): Now static.
7636 * dbusbind.c (xd_in_read_queued_messages): Now static.
7638 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7639 * data.c (circular_list_error): Remove.
7641 * commands.h (last_point_position, last_point_position_buffer):
7642 (last_point_position_window): Remove decls.
7643 * keyboard.c: Make these variables static.
7645 * coding.h (coding, code_convert_region, encode_coding_gap):
7647 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7648 (iso_code_class, detect_coding, code_convert_region): Now static.
7649 (encode_coding_gap): Remove; unused.
7651 * chartab.c (chartab_chars, chartab_bits): Now static.
7653 * charset.h (charset_iso_8859_1): Remove decl.
7654 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7657 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7658 * ccl.c (Vccl_program_table): Now static.
7659 (check_ccl_update): Remove; unused.
7661 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7662 * category.h: ... from here.
7663 * category.c (check_category_table, set_category_set): Now static.
7665 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7666 * lisp.h: Remove these decls.
7668 * buffer.c (buffer_count): Remove unused var.
7670 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7671 so that it's not optimized away.
7672 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7673 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7674 exported only to the debugger.
7676 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7677 * atimer.h (run_all_atimers): Remove; not exported.
7679 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7680 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7681 was inaccessible from Lisp.
7682 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7683 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7685 alloc.c: Import and export fewer symbols, and remove unused items.
7686 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7688 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7689 it's not optimized away by whole-program optimization.
7690 (message_enable_multibyte, free_misc): Remove.
7691 (catchlist, handlerlist, mark_backtrace):
7692 Declare only if BYTE_MARK_STACK.
7693 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7694 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7695 (message_enable_multibyte): Remove decl.
7696 (free_misc, interval_free_list, float_block, float_block_index):
7697 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7698 (cons_free_list, last_marked_index):
7700 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7701 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7702 (mark_backtrace): Define only if BYTE_MARK_STACK.
7703 * xdisp.c (message_enable_multibyte): Now static.
7705 Declare Lisp_Object Q* variables to be 'static' if not exported.
7706 This makes it easier for human readers (and static analyzers)
7707 to see whether these variables are used from other modules.
7708 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7709 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7710 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7711 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7712 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7713 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7714 * xmenu.c, xselect.c:
7715 Declare Q* vars static if they are not used in other modules.
7716 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7717 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7718 Remove decls of unexported vars.
7719 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7721 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7723 Make Emacs functions such as Fatom 'static' by default.
7724 This makes it easier for human readers (and static analyzers)
7725 to see whether these functions can be called from other modules.
7726 DEFUN now defines a static function. To make the function external
7727 so that it can be used in other C modules, use the new macro DEFUE.
7728 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7729 (Finit_image_library):
7730 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7731 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7732 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7733 Remove decls, since these functions are now static.
7734 (Funintern, Fget_internal_run_time): New decls, since these functions
7735 were already external.
7737 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7738 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7739 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7740 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7741 * keyboard.c, keymap.c, lread.c:
7742 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7743 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7744 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7745 Mark functions with DEFUE instead of DEFUN,
7746 if they are used in other modules.
7747 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7748 decls for now-static functions.
7749 * buffer.h (Fdelete_overlay): Remove decl.
7750 * callproc.c (Fgetenv_internal): Mark as internal.
7751 * composite.c (Fremove_list_of_text_properties): Remove decl.
7752 (Fcomposition_get_gstring): New forward static decl.
7753 * composite.h (Fcomposite_get_gstring): Remove decl.
7754 * dired.c (Ffile_attributes): New forward static decl.
7755 * doc.c (Fdocumntation_property): New forward static decl.
7756 * eval.c (Ffetch_bytecode): New forward static decl.
7757 (Funintern): Remove extern decl; now in .h file where it belongs.
7758 * fileio.c (Fmake_symbolic_link): New forward static decl.
7759 * image.c (Finit_image_library): New forward static decl.
7760 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7761 * intervals.h (Fprevious_property_change):
7762 (Fremove_list_of_text_properties): Remove decls.
7763 * keyboard.c (Fthis_command_keys): Remove decl.
7764 (Fcommand_execute): New forward static decl.
7765 * keymap.c (Flookup_key): New forward static decl.
7766 (Fcopy_keymap): Now static.
7767 * keymap.h (Flookup_key): Remove decl.
7768 * process.c (Fget_process): New forward static decl.
7769 (Fprocess_datagram_address): Mark as internal.
7770 * syntax.c (Fsyntax_table_p): New forward static decl.
7771 (skip_chars): Remove duplicate decl.
7772 * textprop.c (Fprevious_property_change): New forward static decl.
7773 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7775 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7776 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7778 * editfns.c (Fformat): Remove unreachable code.
7780 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7782 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7785 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7787 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7788 when at ZV. (Bug#8487)
7790 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7792 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7794 * keyboard.c (parse_tool_bar_item): Likewise.
7795 * sound.c (sound_cleanup, alsa_close): Likewise.
7796 * termcap.c (tgetent): Likewise.
7797 * xfns.c (x_default_font_parameter): Likewise.
7798 * xsettings.c (read_and_apply_settings): Likewise.
7800 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7801 (overrun_check_free): Protoize.
7803 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7805 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7806 since callers should never pass a negative size.
7807 Change the signature to match that of plain 'read' and 'write'; see
7808 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7809 * lisp.h: Update prototypes of emacs_write and emacs_read.
7811 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7813 * xdisp.c (redisplay_window): Don't try to determine the character
7814 position of the scroll margin if the window start point w->startp
7815 is outside the buffer's accessible region. (Bug#8468)
7817 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7819 Fix write-region and its subroutines for buffers > 2GB.
7820 * fileio.c (a_write, e_write): Modify declaration of arguments and
7821 local variables to support buffers larger than 2GB.
7822 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7824 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7825 argument, local variables, and return value.
7827 * lisp.h: Update prototypes of emacs_write and emacs_read.
7829 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7831 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7833 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7835 Fix more problems found by GCC 4.6.0's static checks.
7837 * xdisp.c (vmessage): Use a better test for character truncation.
7839 * charset.c (load_charset_map): <, not <=, for optimization,
7840 and to avoid potential problems with integer overflow.
7841 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7842 * casetab.c (set_identity, shuffle): Likewise.
7843 * editfns.c (Fformat): Likewise.
7844 * syntax.c (skip_chars): Likewise.
7846 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7847 This also lets GCC 4.6.0 generate slightly better loop code.
7849 * callint.c (Fcall_interactively): <, not <=, for optimization.
7850 (Fcall_interactively): Count the number of arguments produced,
7851 not the number of arguments given. This is simpler and lets GCC
7852 4.6.0 generate slightly better code.
7854 * ftfont.c: Distingish more carefully between FcChar8 and char.
7855 The previous code passed unsigned char * to a functions like
7856 strlen and xstrcasecmp that expect char *, which does not
7857 conform to the C standard.
7858 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7859 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7860 char * when the C standard requires it.
7862 * keyboard.c (read_char): Remove unused var.
7864 * eval.c: Port to Windows vsnprintf (Bug#8435).
7866 (SIZE_MAX): Define if the headers do not.
7867 (verror): Do not give up if vsnprintf returns a negative count.
7868 Instead, grow the buffer. This ports to Windows vsnprintf, which
7869 does not conform to C99. Problem reported by Eli Zaretskii.
7870 Also, simplify the allocation scheme, by avoiding the need for
7871 calling realloc, and removing the ALLOCATED variable.
7873 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7875 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7876 But keep the doprint source code for now, as we might revamp it
7877 and use it again (Bug#8435).
7878 * lisp.h (doprnt): Remove.
7879 * Makefile.in (base_obj): Remove doprnt.o.
7880 * deps.mk (doprnt.o): Remove.
7882 error: Print 32- and 64-bit integers portably (Bug#8435).
7883 Without this change, on typical 64-bit hosts error ("...%d...", N)
7884 was used to print both 32- and 64-bit integers N, which relied on
7886 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7887 * lisp.h (error, verror): Mark as printf-like functions.
7888 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7889 Report overflow in size calculations when allocating printf buffer.
7890 Do not truncate output string at its first null byte.
7891 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7892 Truncate the output at a character boundary, since vsnprintf does not
7894 * charset.c (check_iso_charset_parameter): Convert internal
7895 character to string before calling 'error', since %c now has the
7897 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7898 overflow when computing char to be passed to 'error'. Do not
7899 pass Lisp_Object to 'error'; pass the integer instead.
7900 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7901 formatted with plain %d.
7903 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7905 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7907 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7909 * xterm.c (x_catch_errors): Remove duplicate declaration.
7911 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7913 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7915 2011-04-10 Jim Meyering <meyering@redhat.com>
7917 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7918 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7919 return ssize_t not "int", and use size_t as the buffer length.
7920 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7921 * gnutls.h: Update declarations.
7922 * process.c (read_process_output): Use ssize_t, to match.
7923 (send_process): Likewise.
7925 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7927 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7929 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7931 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7932 Use unsigned char, to match FcChar8 type definition.
7934 * xterm.c (handle_one_xevent):
7935 * xmenu.c (create_and_show_popup_menu):
7936 * xselect.c (x_decline_selection_request)
7937 (x_reply_selection_request): Avoid type-punned deref of X events.
7939 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7941 Fix some uses of `int' instead of EMACS_INT.
7942 * search.c (string_match_1, fast_string_match)
7943 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7944 (scan_buffer, find_next_newline_no_quit)
7945 (find_before_next_newline, search_command, Freplace_match)
7946 (Fmatch_data): Make some `int' variables be EMACS_INT.
7948 * xdisp.c (display_count_lines): 3rd argument and return value now
7949 EMACS_INT. All callers changed.
7950 (pint2hrstr): Last argument is now EMACS_INT.
7952 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7953 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7954 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7955 (decode_coding_utf_16, decode_coding_emacs_mule)
7956 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7957 (decode_coding_ccl, decode_coding_charset)
7958 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7959 (decode_coding_iso_2022, decode_coding_emacs_mule)
7960 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7961 <char_offset, last_offset>: Declare EMACS_INT.
7962 (encode_coding_utf_8, encode_coding_utf_16)
7963 (encode_coding_emacs_mule, encode_invocation_designation)
7964 (encode_designation_at_bol, encode_coding_iso_2022)
7965 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7966 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7968 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7969 (encode_invocation_designation): Last argument P_NCHARS is now
7971 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7972 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7974 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7977 * ccl.c (Fccl_execute_on_string): Declare some variables
7980 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7982 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7984 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7986 * process.c (Fformat_network_address): Doc fix.
7988 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7990 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7992 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7994 * keyboard.c (read_char): Call Lisp function help-form-show,
7995 instead of using internal_with_output_to_temp_buffer.
7996 (Qhelp_form_show): New var.
7997 (syms_of_keyboard): Use DEFSYM macro.
7999 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8001 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8003 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8005 * process.c (Flist_processes): Remove to Lisp.
8006 (list_processes_1): Delete.
8008 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8010 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8012 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8014 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8016 Fix more problems found by GCC 4.6.0's static checks.
8018 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8020 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8022 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8024 * xdisp.c (vmessage): Mark as a printf-like function.
8026 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8028 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8030 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8031 printf-like functions.
8032 (tiff_load): Add casts to remove these marks before passing them
8033 to system-supplied API.
8035 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8037 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8038 This avoids several warnings with gcc -Wstrict-overflow.
8039 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8040 directly, rather than having caller test rule sign. This avoids
8041 some unnecessary tests.
8042 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8043 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8044 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8046 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8047 (xfont_open): Avoid unnecessary tests.
8049 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8051 * composite.h, composite.c (composition_gstring_put_cache):
8052 Use EMACS_INT, not int, for length.
8054 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8055 breaking out part of COMPOSITION_DECODE_RULE.
8056 (COMPOSITION_DECODE_RULE): Use it.
8057 * composite.c (get_composition_id): Remove unused local vars,
8058 by using the new macro.
8060 * textprop.c (set_text_properties_1): Change while to do-while,
8061 since the condition is always true at first.
8063 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8064 (interval_deletion_adjustment): Return unsigned value.
8067 * process.c (list_processes_1, create_pty, read_process_output):
8068 (exec_sentinel): Remove vars that were set but not used.
8069 (create_pty): Remove unnecessary "volatile"s.
8070 (Fnetwork_interface_info): Avoid possibility of int overflow.
8071 (read_process_output): Do adaptive read buffering even if carryover.
8072 (read_process_output): Simplify nbytes computation if buffered.
8074 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8076 * syntax.c (scan_words): Remove var that was set but not used.
8077 (update_syntax_table): Use unsigned instead of int.
8079 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8080 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8081 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8083 * print.c (print_error_message): Avoid int overflow.
8085 * font.c (font_list_entities): Redo for clarity,
8086 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8088 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8089 (font_score): Avoid potential overflow in diff calculation.
8091 * fns.c (substring_both): Remove var that is set but not used.
8092 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8094 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8096 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8097 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8098 can always succeed if overflow has undefined behavior.
8100 * search.c (boyer_moore, wordify): Remove vars set but not used.
8101 (wordify): Omit three unnecessary tests.
8103 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8104 All callers changed. This avoids the need for an unused var.
8106 * casefiddle.c (casify_region): Remove var that is set but not used.
8108 * dired.c (file_name_completion): Remove var that is set but not used.
8110 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8112 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8113 (Finsert_file_contents): Remove unnecessary code checking fd.
8115 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8116 Check for integer overflow on size calculations.
8118 * buffer.c (Fprevious_overlay_change): Remove var that is set
8121 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8122 Remove vars that are set but not used.
8123 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8124 (timer_check_2): Mark vars as initialized.
8126 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8128 * image.c (lookup_image): Remove var that is set but not used.
8129 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8131 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8132 that are set but not used.
8134 * xfns.c (make_invisible_cursor): Don't return garbage
8135 if XCreateBitmapFromData fails (Bug#8410).
8137 * xselect.c (x_get_local_selection, x_handle_property_notify):
8138 Remove vars that are set but not used.
8140 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8141 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8143 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8144 Remove var that is set but not used.
8145 (scroll_bar_windows_size): Now size_t, not int.
8146 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8149 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8150 (map_tty_color) [!defined MSDOS]: Likewise.
8152 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8154 * coding.c: Remove vars that are set but not used.
8155 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8156 All callers changed.
8157 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8158 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8159 (decode_coding_charset): Remove vars that are set but not used.
8161 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8162 that is set but not used.
8164 * print.c (print_object): Remove var that is set but not used.
8166 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8167 The gnulib version avoids calling malloc in the usual case,
8168 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8169 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8170 * filelock.c (current_lock_owner): Likewise.
8171 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8172 * sysdep.c: Include allocator.h, careadlinkat.h.
8173 (emacs_no_realloc_allocator): New static constant.
8174 (emacs_readlink): New function.
8175 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8176 ../lib/careadlinkat.h.
8178 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8180 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8181 first non-nil return value).
8183 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8185 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8186 if not defined (Bug#8403).
8188 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8190 * xdisp.c (display_count_lines): Remove parameter `start',
8191 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8192 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8193 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8194 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8195 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8196 and thereabouts. All callers changed.
8197 (get_per_char_metric): Remove parameter `f', unused since
8198 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8200 2011-04-02 Jim Meyering <meyering@redhat.com>
8202 do not dereference NULL upon failed strdup
8203 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8204 (ns_get_family): Likewise.
8206 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8208 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8210 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8212 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8215 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8217 Add lexical binding.
8219 * window.c (Ftemp_output_buffer_show): New fun.
8220 (Fsave_window_excursion):
8221 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8223 * lread.c (lisp_file_lexically_bound_p): New function.
8224 (Fload): Bind Qlexical_binding.
8225 (readevalloop): Remove `evalfun' arg.
8226 Bind Qinternal_interpreter_environment.
8227 (Feval_buffer): Bind Qlexical_binding.
8228 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8230 (syms_of_lread): Declare `lexical-binding'.
8232 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8234 * keyboard.c (eval_dyn): New fun.
8235 (menu_item_eval_property): Use it.
8237 * image.c (parse_image_spec): Use Ffunctionp.
8239 * fns.c (concat, mapcar1): Accept byte-code-functions.
8241 * eval.c (Fsetq): Handle lexical vars.
8242 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8243 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8244 (FletX, Flet): Obey lexical binding.
8245 (Fcommandp): Handle closures.
8246 (Feval): New `lexical' arg.
8247 (eval_sub): New function extracted from Feval. Use it almost
8248 everywhere where Feval was used. Look up vars in lexical env.
8250 (Ffunctionp): Move from subr.el.
8251 (Ffuncall): Handle closures.
8252 (apply_lambda): Remove `eval_flags'.
8253 (funcall_lambda): Handle closures and new byte-code-functions.
8254 (Fspecial_variable_p): New function.
8255 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8256 but without exporting it to Lisp.
8258 * doc.c (Fdocumentation, store_function_docstring):
8259 * data.c (Finteractive_form): Handle closures.
8261 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8264 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8266 (exec_byte_code): New function extracted from Fbyte_code to handle new
8267 calling convention for byte-code-functions. Add new byte-codes.
8269 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8271 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8273 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8275 * xdisp.c (redisplay_internal): Fix prototype.
8277 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8279 * xdisp.c (SCROLL_LIMIT): New macro.
8280 (try_scrolling): Use it when setting scroll_limit.
8281 Limit scrolling to 100 screen lines.
8282 (redisplay_window): Even when falling back on "recentering",
8283 position point in the window according to scroll-conservatively,
8284 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8286 (try_scrolling): When point is above the window, allow searching
8287 as far as scroll_max, or one screenful, to compute vertical
8288 distance from PT to the scroll margin position. This prevents
8289 try_scrolling from unnecessarily failing when
8290 scroll-conservatively is set to a value slightly larger than the
8291 window height. Clean up the case of PT below the margin at bottom
8292 of window: scroll_max can no longer be INT_MAX. When aggressive
8293 scrolling is in use, don't let point enter the opposite scroll
8294 margin as result of the scroll.
8295 (syms_of_xdisp) <scroll-conservatively>: Document the
8296 threshold of 100 lines for never-recentering scrolling.
8298 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8300 * dispextern.h (move_it_by_lines):
8301 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8302 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8303 (message_log_check_duplicate): Remove parameters `prev_bol' and
8304 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8305 (redisplay_internal): Remove parameter `preserve_echo_area',
8306 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8308 * indent.c (Fvertical_motion):
8309 * window.c (window_scroll_pixel_based, Frecenter):
8310 Don't pass `need_y_p' to `move_it_by_lines'.
8312 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8314 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8315 steal a few bits to be more compact.
8316 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8317 Remove unneeded casts.
8319 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8321 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8323 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8324 binding" message (bug#7967).
8326 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8328 Fix more problems found by GCC 4.6.0's static checks.
8330 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8331 Remove unused local var.
8333 * editfns.c (Fmessage_box): Remove unused local var.
8335 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8336 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8337 Omit unused local vars.
8338 * window.c (shrink_windows): Omit unused local var.
8339 * menu.c (digest_single_submenu): Omit unused local var.
8340 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8341 Omit unused local var.
8343 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8344 Don't assume string length fits in int.
8345 (keyremap_step, read_key_sequence): Use size_t for sizes.
8346 (read_key_sequence): Don't check last_real_key_start redundantly.
8348 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8349 instead of alloca (Bug#8344).
8351 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8352 (Fbacktrace_frame): Don't assume nframes fits in int.
8354 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8356 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8359 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8361 * cm.c (calccost): Turn while-do into do-while, for clarity.
8363 * keyboard.c (syms_of_keyboard): Use the same style as later
8364 in this function when indexing through an array. This also
8365 works around GCC bug 48267.
8367 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8369 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8371 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8372 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8374 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8375 This avoids undefined behavior on integer overflow, and is a bit
8376 more convenient anyway since it is compared to a size_t variable.
8378 Variadic C functions now count arguments with size_t, not int.
8379 This avoids an unnecessary limitation on 64-bit machines, which
8380 caused (substring ...) to crash on large vectors (Bug#8344).
8381 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8382 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8383 All variadic functions and their callers changed accordingly.
8384 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8385 * data.c (arith_driver, float_arith_driver): Likewise.
8386 * editfns.c (general_insert_function): Likewise.
8387 * eval.c (struct backtrace.nargs, interactive_p)
8388 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8389 (funcall_lambda, mark_backtrace): Likewise.
8390 * fns.c (concat): Likewise.
8391 * frame.c (x_set_frame_parameters): Likewise.
8392 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8393 0 if not found, not -1. All callers changed.
8395 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8396 (stack_copy_size): Now size_t, not int.
8397 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8399 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8401 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8402 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8403 All callers changed.
8405 * lisp.h (multibyte_char_to_unibyte):
8406 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8407 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8408 * character.h (CHAR_TO_BYTE8):
8409 * cmds.c (internal_self_insert):
8410 * editfns.c (general_insert_function):
8411 * keymap.c (push_key_description):
8412 * search.c (Freplace_match):
8413 * xdisp.c (message_dolog, set_message_1): All callers changed.
8415 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8417 * keyboard.c (safe_run_hook_funcall): New function.
8418 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8419 don't set the hook to nil, but remove the offending function instead.
8420 (Qcommand_hook_internal): Remove, unused.
8421 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8422 Vcommand_hook_internal.
8424 * eval.c (enum run_hooks_condition): Remove.
8425 (funcall_nil, funcall_not): New functions.
8426 (run_hook_with_args): Call each function through a `funcall' argument.
8427 Remove `cond' argument, now redundant.
8428 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8429 (Frun_hook_with_args_until_failure): Adjust accordingly.
8430 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8432 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8434 * dispextern.h (string_buffer_position): Remove declaration.
8436 * print.c (strout): Remove parameter `multibyte', unused since
8437 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8439 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8440 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8441 All callers changed.
8443 * w32.c (_wsa_errlist): Use braces for struct initializers.
8445 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8446 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8447 All callers changed.
8448 (string_buffer_position): Likewise. Also, make static (it's never
8449 used outside xdisp.c).
8450 (cursor_row_p): Remove parameter `w', unused since
8451 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8452 (decode_mode_spec): Remove parameter `precision', introduced during
8453 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8454 All callers changed.
8456 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8458 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8460 2011-03-27 Anders Lindgren <andlind@gmail.com>
8462 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8463 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8464 (ns_update_auto_hide_menu_bar): New functions.
8465 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8466 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8467 ns_constrain_all_frames.
8468 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8469 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8471 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8473 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8475 2011-03-27 Glenn Morris <rgm@gnu.org>
8477 * syssignal.h: Replace RETSIGTYPE with void.
8478 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8479 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8480 Replace SIGTYPE with void everywhere.
8481 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8482 * s/template.h (SIGTYPE): Remove commented out definition.
8484 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8486 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8487 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8489 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8491 * w32.c (read_unc_volume): Use parameter `henum', instead of
8492 global variable `wget_enum_handle'.
8494 * keymap.c (describe_vector): Remove parameters `indices' and
8495 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8496 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8498 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8500 * keyboard.c (timer_check): Remove parameter `do_it_now',
8501 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8502 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8503 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8505 * keyboard.c (read_char):
8506 * w32menu.c (w32_menu_display_help):
8507 * xmenu.c (show_help_event, menu_help_callback):
8508 Adjust calls to `show_help_echo'.
8510 * gtkutil.c (xg_maybe_add_timer):
8511 * keyboard.c (readable_events):
8512 * process.c (wait_reading_process_output):
8513 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8515 * insdel.c (adjust_markers_gap_motion):
8516 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8517 (gap_left, gap_right): Don't call it.
8519 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8521 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8522 incurred during fontification.
8524 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8526 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8527 (DEFVAR_PER_BUFFER): Don't pass it.
8529 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8530 (scrolling_window): Don't pass it.
8532 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8534 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8536 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8538 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8539 of variables specific to SELinux and computation of `encoded_absname'.
8541 * image.c (XPutPixel): Remove unused variable `height'.
8543 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8545 * unexw32.c (get_section_info): Remove unused variable `section'.
8547 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8548 (system_process_attributes): Remove unused variable `sess'.
8549 (sys_read): Remove unused variable `err'.
8551 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8552 (w32_wnd_proc): Remove unused variable `isdead'.
8553 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8554 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8555 (x_create_tip_frame): Remove unused variable `tem'.
8557 * w32inevt.c (w32_console_read_socket):
8558 Remove unused variable `no_events'.
8560 * w32term.c (x_draw_composite_glyph_string_foreground):
8561 Remove unused variable `width'.
8563 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8565 * w32term.c (x_set_glyph_string_clipping):
8566 Don't pass uninitialized region to CombineRgn.
8568 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8570 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8571 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8572 (Fx_close_connection): Remove unused variable `i'.
8574 * w32font.c (w32font_draw): Return number of glyphs.
8575 (w32font_open_internal): Remove unused variable `i'.
8576 (w32font_driver): Add missing initializer.
8578 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8579 (fill_in_menu): Remove unused variable `items_added'.
8581 * w32term.c (last_mouse_press_frame): Remove static global variable.
8582 (w32_clip_to_row): Remove unused variable `f'.
8583 (x_delete_terminal): Remove unused variable `i'.
8585 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8586 (NOTHING): Remove unused static global variable.
8587 (uniscribe_check_otf): Remove unused variable `table'.
8588 (uniscribe_font_driver): Add missing initializers.
8590 2011-03-23 Julien Danjou <julien@danjou.info>
8592 * term.c (Fsuspend_tty, Fresume_tty):
8593 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8594 * window.c (temp_output_buffer_show):
8595 * insdel.c (signal_before_change):
8596 * frame.c (Fhandle_switch_frame):
8597 * fileio.c (Fdo_auto_save):
8598 * emacs.c (Fkill_emacs):
8599 * editfns.c (save_excursion_restore):
8600 * cmds.c (internal_self_insert):
8601 * callint.c (Fcall_interactively):
8602 * buffer.c (Fkill_all_local_variables):
8603 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8605 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8606 unconditionally since it does the check itself.
8608 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8610 Fix more problems found by GCC 4.5.2's static checks.
8612 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8613 the first time through the loop, since we know p0 < p1 then.
8614 This also avoids a gcc -Wstrict-overflow warning.
8616 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8617 leading to a memory leak, possible in functions like
8618 load_charset_map_from_file that can allocate an unbounded number
8619 of objects (Bug#8318).
8621 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8622 that could (at least in theory) be that large.
8624 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8625 This is less likely to overflow, and avoids undefined behavior if
8626 overflow does occur. All callers changed. Use strtoul to scan
8627 for the unsigned long integer.
8628 (pint2hrstr): Simplify and tune code slightly.
8629 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8631 * scroll.c (do_scrolling): Work around GCC bug 48228.
8632 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8634 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8635 This also avoids a warning with gcc -Wstrict-overflow.
8636 (validate_x_resource_name): Simplify count usage.
8637 This also avoids a warning with gcc -Wstrict-overflow.
8639 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8642 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8644 * process.c (Fmake_network_process): Use socklen_t, not int,
8645 where POSIX says socklen_t is required in portable programs.
8646 This fixes a porting bug on hosts like 64-bit HP-UX, where
8647 socklen_t is wider than int (Bug#8277).
8648 (Fmake_network_process, server_accept_connection):
8649 (wait_reading_process_output, read_process_output):
8652 * process.c: Rename or move locals to avoid shadowing.
8653 (list_processes_1, Fmake_network_process):
8654 (read_process_output_error_handler, exec_sentinel_error_handler):
8655 Rename or move locals.
8656 (Fmake_network_process): Define label "retry_connect" only if needed.
8657 (Fnetwork_interface_info): Fix pointer signedness.
8658 (process_send_signal): Add cast to avoid pointer signedness problem.
8659 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8660 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8662 Make tparam.h and terminfo.c consistent.
8663 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8664 Include tparam.h instead, since it declares them.
8665 * cm.h (PC): Remove extern decl; tparam.h now does this.
8666 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8667 * terminfo.c: Include tparam.h, to check interfaces.
8668 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8669 (tparam): Adjust signature to match interface in tparam.h;
8670 this removes some undefined behavior. Check that outstring and len
8671 are zero, which they always are with Emacs.
8672 * tparam.h (PC, BC, UP): New extern decls.
8674 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8675 (xftfont_open): Rename locals to avoid shadowing.
8677 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8678 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8679 (OTF_TAG_SYM): Omit macro if not needed.
8680 (ftfont_list): Remove unused local.
8681 (get_adstyle_property, ftfont_pattern_entity):
8682 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8683 Rename locals to avoid shadowing.
8685 * xfont.c (xfont_list_family): Mark var as initialized.
8687 * xml.c (make_dom): Now static.
8689 * composite.c (composition_compute_stop_pos): Rename local to
8691 (composition_reseat_it): Remove unused locals.
8692 (find_automatic_composition, composition_adjust_point): Likewise.
8693 (composition_update_it): Mark var as initialized.
8694 (find_automatic_composition): Mark vars as initialized,
8695 with a FIXME (Bug#8290).
8697 character.h: Rename locals to avoid shadowing.
8698 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8699 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8700 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8701 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8704 * textprop.c (property_change_between_p): Remove; unused.
8706 * intervals.c (interval_start_pos): Now static.
8708 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8710 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8711 Rename locals to avoid shadowing.
8713 * sound.c (wav_play, au_play, Fplay_sound_internal):
8714 Fix pointer signedness.
8715 (alsa_choose_format): Remove unused local var.
8716 (wav_play): Initialize a variable to 0, to prevent undefined
8717 behavior (Bug#8278).
8719 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8721 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8723 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8724 clobbering (Bug#8298).
8725 * sysdep.c (sys_subshell): Likewise.
8726 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8728 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8729 This should get cleaned up, so that child_setup has the
8730 same signature on all platforms.
8732 * callproc.c (call_process_cleanup): Now static.
8733 (relocate_fd): Rename locals to avoid shadowing.
8735 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8737 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8738 not to be necessary, and produces flickering.
8740 2011-03-20 Glenn Morris <rgm@gnu.org>
8742 * config.in: Remove file.
8744 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8746 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8747 are now in src/globals.h.
8748 (syms_of_minibuf): Remove spurious & from previous change.
8750 2011-03-20 Leo Liu <sdl.web@gmail.com>
8752 * minibuf.c (completing-read-function): New variable.
8753 (completing-read-default): Rename from completing-read.
8754 (completing-read): Call completing-read-function.
8756 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8758 * xfaces.c (Fx_load_color_file):
8759 Read color file from absolute filename (bug#8250).
8761 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8763 * makefile.w32-in: Update dependencies.
8765 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8767 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8769 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8771 Fix more problems found by GCC 4.5.2's static checks.
8773 * process.c (make_serial_process_unwind, send_process_trap):
8774 (sigchld_handler): Now static.
8776 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8777 That way, the code declares only the vars that it needs.
8778 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8779 * s/cygwin.h (PTY_ITERATION): Likewise.
8780 * s/darwin.h (PTY_ITERATION): Likewise.
8781 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8783 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8784 * process.c (allocate_pty): Don't declare stb unless it's needed.
8786 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8787 (CONSTANTLIM): Remove; unused.
8788 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8789 Define only if needed.
8791 * unexelf.c (unexec): Name an expression,
8792 to avoid gcc -Wbad-function-cast warning.
8793 Use a different way to cause a compilation error if anyone uses
8794 n rather than nn, a way that does not involve shadowing.
8795 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8797 * deps.mk (unexalpha.o): Remove; unused.
8799 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8800 * unexec.h: New file.
8801 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8802 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8804 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8805 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8806 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8807 Change as necessary to match prototype in unexec.h.
8809 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8811 (back_comment, skip_chars): Mark vars as initialized.
8813 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8814 Rename locals to avoid shadowing.
8816 * lread.c (read1): Rewrite so as not to use empty "else".
8817 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8819 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8821 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8822 warning when compiling print.c.
8824 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8825 instead of using an uninitialized var.
8826 (font_sort_entities): Mark var as initialized.
8828 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8830 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8831 pointers to constants.
8832 (font_parse_fcname): Remove unused vars.
8833 (font_delete_unmatched): Now static.
8834 (font_get_spec): Remove; unused.
8835 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8836 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8837 Rename or move locals to avoid shadowing.
8839 * fns.c (require_nesting_list, require_unwind): Now static.
8840 (Ffillarray): Rename locals to avoid shadowing.
8842 * floatfns.c (domain_error2): Define only if needed.
8843 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8845 * alloc.c (mark_backtrace): Move decl from here ...
8846 * lisp.h: ... to here, so that it can be checked.
8848 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8849 (Fdefvar): Rewrite so as not to use empty "else".
8850 (lisp_indirect_variable): Name an expression,
8851 to avoid gcc -Wbad-function-cast warning.
8852 (Fdefvar): Rename locals to avoid shadowing.
8854 * callint.c (quotify_arg, quotify_args): Now static.
8855 (Fcall_interactively): Rename locals to avoid shadowing.
8856 Use const pointer when appropriate.
8858 * lisp.h (get_system_name, get_operating_system_release):
8859 Move decls here, to check interfaces.
8860 * process.c (get_operating_system_release): Move decl to lisp.h.
8861 * xrdb.c (get_system_name): Likewise.
8862 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8863 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8864 some of which prompt warnings from gcc -Wbad-function-cast.
8865 (Fformat_time_string, Fencode_time, Finsert_char):
8866 (Ftranslate_region_internal, Fformat):
8867 Rename or remove local vars to avoid shadowing.
8868 (Ftranslate_region_internal): Mark var as initialized.
8870 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8873 * lisp.h (eassert): Check that the argument compiles, even if
8874 ENABLE_CHECKING is not defined.
8876 * data.c (Findirect_variable): Name an expression, to avoid
8877 gcc -Wbad-function-cast warning.
8878 (default_value, arithcompare, arith_driver, arith_error): Now static.
8879 (store_symval_forwarding): Rename local to avoid shadowing.
8880 (Fmake_variable_buffer_local, Fmake_local_variable):
8881 Mark variables as initialized.
8882 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8884 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8885 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8886 Rename locals to avoid shadowing.
8887 (mark_stack): Move local variables into the #ifdef region where
8889 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8890 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8892 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8893 (GC_STRING_CHARS): Remove; not used.
8894 (Fmemory_limit): Cast sbrk's returned value to char *.
8896 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8897 avoids undefined behavior in theory.
8899 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8901 Use functions, not macros, for up- and down-casing (Bug#8254).
8902 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8903 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8904 to use the following functions instead of these macros.
8905 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8906 EMACS_INT, since callers assume the returned value fits in int.
8907 (upcase1): Likewise, for UPCASE_TABLE.
8908 (uppercasep, lowercasep, upcase): New static inline functions.
8909 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8910 the race-condition problem in the old DOWNCASE.
8912 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8913 Rename locals to avoid shadowing.
8914 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8915 (regex_compile, re_search_2, re_match_2_internal):
8916 Remove unused local vars.
8917 (FREE_VAR): Rewrite so as not to use empty "else",
8918 which gcc can warn about.
8919 (regex_compile, re_match_2_internal): Mark locals as initialized.
8920 (RETALLOC_IF): Define only if needed.
8921 (WORDCHAR_P): Likewise. This one is never needed, but is used
8922 only in a comment talking about a compiler bug, so put inside
8923 the #if 0 of that comment.
8924 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8925 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8928 * search.c (boyer_moore): Rename locals to avoid shadowing.
8929 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8930 (PREV_CHAR_BOUNDARY): Likewise.
8932 * search.c (simple_search): Remove unused var.
8934 * dired.c (compile_pattern): Move decl from here ...
8935 * lisp.h: ... to here, so that it can be checked.
8936 (struct re_registers): New forward decl.
8938 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8940 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8942 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8943 Rename locals to avoid shadowing.
8944 (Fvertical_motion): Mark locals as initialized.
8946 * casefiddle.c (casify_object, casify_region): Now static.
8947 (casify_region): Mark local as initialized.
8949 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8951 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8952 New macros, so that the caller can use some names other than
8953 gcpro1, gcpro2, etc.
8954 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8956 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8957 argument, for consistency with GCPRO2_VAR, etc: it is now the
8958 prefix of the variable, not the variable itself. All uses
8960 * dired.c (directory_files_internal, file_name_completion):
8961 Rename locals to avoid shadowing.
8963 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8964 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8965 dired.c's scmp function, had undefined behavior.
8966 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8967 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8968 * buffer.h: ... to here, because these macros use current_buffer,
8969 and the new implementation with inline functions needs to have
8970 current_buffer in scope now, rather than later when the macros
8972 (downcase, upcase1): New static inline functions.
8973 (DOWNCASE, UPCASE1): Reimplement using these functions.
8974 This avoids undefined behavior in expressions like
8975 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8976 from race conditions in accessing the global variables
8977 case_temp1 and case_temp2.
8978 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8979 * lisp.h (case_temp1, case_temp2): Remove their decls.
8980 * character.h (ASCII_CHAR_P): Move from here ...
8981 * lisp.h: ... to here, so that the inline functions mentioned
8984 * dired.c (directory_files_internal_unwind): Now static.
8986 * fileio.c (file_name_as_directory, directory_file_name):
8987 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8989 (file_name_as_directory): Use const pointers when appropriate.
8990 (Fexpand_file_name): Likewise. In particular, newdir might
8991 point at constant storage, so make it a const pointer.
8992 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8993 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8995 (Fset_file_times, Finsert_file_contents, auto_save_error):
8996 Rename locals to avoid shadowing.
8998 * minibuf.c (choose_minibuf_frame_1): Now static.
8999 (Ftry_completion, Fall_completions): Rename or remove locals
9002 * marker.c (bytepos_to_charpos): Remove; unused.
9004 * lisp.h (verify_bytepos, count_markers): New decls,
9005 so that gcc does not warn that these functions aren't declared.
9007 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9008 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9009 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9010 (copy_text): Remove unused local var.
9012 * filelock.c (within_one_second): Now static.
9013 (lock_file_1): Rename local to avoid shadowing.
9015 * buffer.c (fix_overlays_before): Mark locals as initialized.
9016 (fix_start_end_in_overlays): Likewise. This function should be
9017 simplified by using pointers-to-pointers, but that's a different
9019 (switch_to_buffer_1): Now static.
9020 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9021 (report_overlay_modification): Rename locals to avoid shadowing.
9023 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9024 Fix pointer signedness issue.
9025 (sys_subshell): Mark local as volatile if checking for lint,
9026 to suppress a gcc -Wclobbered warning that does not seem to be right.
9027 (MAXPATHLEN): Define only if needed.
9029 * process.c (serial_open, serial_configure): Move decls from here ...
9030 * systty.h: ... to here, so that they can be checked.
9032 * fns.c (get_random, seed_random): Move extern decls from here ...
9033 * lisp.h: ... to here, so that they can be checked.
9035 * sysdep.c (reset_io): Now static.
9036 (wait_for_termination_signal): Remove; unused.
9038 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9039 (copy_keymap_item, append_key, push_text_char_description):
9041 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9042 (DENSE_TABLE_SIZE): Remove; unused.
9043 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9044 (describe_map_tree):
9045 Rename locals to avoid shadowing.
9047 * keyboard.c: Declare functions static if they are not used elsewhere.
9048 (echo_char, echo_dash, cmd_error, top_level_2):
9049 (poll_for_input, handle_async_input): Now static.
9050 (read_char, kbd_buffer_get_event, make_lispy_position):
9051 (make_lispy_event, make_lispy_movement, apply_modifiers):
9052 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9053 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9054 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9055 (read_key_sequence, read_char): Mark locals as initialized.
9056 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9058 * keyboard.h (make_ctrl_char): New decl.
9059 (mark_kboards): Move decl here ...
9060 * alloc.c (mark_kboards): ... from here.
9062 * lisp.h (force_auto_save_soon): New decl.
9064 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9065 (DEFINE_DUMMY_FUNCTION): New macro.
9066 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9068 (main): Add casts to avoid warnings
9069 if GCC considers string literals to be constants.
9071 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9073 * dbusbind.c: Pointer signedness fixes.
9074 (xd_signature, xd_append_arg, xd_initialize):
9075 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9076 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9077 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9078 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9080 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9081 if GCC considers string literals to be constants.
9082 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9084 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9086 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9087 (print_preprocess, print_object): New macro to fix last change.
9089 * print.c (print_preprocess): Don't forget font objects.
9091 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9093 * emacs.c (USAGE3): Doc fixes.
9095 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9097 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9100 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9102 * lisp.h (VWindow_system, Qfile_name_history):
9103 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9104 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9105 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9107 * w32select.c: Don't #include "keyboard.h".
9108 (run_protected): Add extern declaration for waiting_for_input.
9110 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9111 * w32console.c (detect_input_pending, read_input_pending)
9112 (encode_terminal_code):
9113 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9114 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9115 (w32_system_caret_y, Qfile_name_history):
9116 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9117 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9118 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9119 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9120 * w32proc.c (Qlocal, report_file_error):
9121 * w32term.c (Vwindow_system, updating_frame):
9122 * w32uniscribe.c (initialized, uniscribe_font_driver):
9123 Remove unneeded extern declarations.
9125 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9127 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9129 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9131 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9132 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9133 These macros can no longer be used for assignment.
9135 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9136 Assign struct members directly, instead of using BUF_BEGV etc.
9137 (record_buffer_markers, fetch_buffer_markers): New functions for
9138 recording and fetching special buffer markers.
9139 (set_buffer_internal_1, set_buffer_temp): Use them.
9141 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9143 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9145 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9146 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9148 * xdisp.c (hscroll_window_tree):
9149 (reconsider_clip_changes): Use PT instead of BUF_PT.
9151 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9153 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9154 $(EMACS_ROOT)/lib/intprops.h.
9156 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9158 Fix more problems found by GCC 4.5.2's static checks.
9160 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9161 to unsigned char * to avoid compiler diagnostic.
9162 (xg_free_frame_widgets): Make it clear that a local variable is
9163 needed only if USE_GTK_TOOLTIP.
9164 (gdk_window_get_screen): Make it clear that this macro is needed
9165 only if USE_GTK_TOOLTIP.
9166 (int_gtk_range_get_value): New function, which avoids a diagnostic
9167 from gcc -Wbad-function-cast.
9168 (xg_set_toolkit_scroll_bar_thumb): Use it.
9169 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9170 diagnostic from gcc -Wbad-function-cast.
9171 (get_utf8_string, xg_get_file_with_chooser):
9172 Rename locals to avoid shadowing.
9173 (create_dialog): Move locals to avoid shadowing.
9175 * xgselect.c (xg_select): Remove unused var.
9177 * image.c (four_corners_best): Mark locals as initialized.
9178 (gif_load): Initialize transparent_p to zero (Bug#8238).
9179 Mark another local as initialized.
9180 (my_png_error, my_error_exit): Mark with NO_RETURN.
9182 * image.c (clear_image_cache): Now static.
9183 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9184 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9185 (x_edge_detection): Remove unnecessary cast that
9186 gcc -Wbad-function-cast diagnoses.
9187 (gif_load): Fix pointer signedness.
9188 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9189 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9191 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9193 Improve quality of tests for time stamp overflow.
9194 For example, without this patch (encode-time 0 0 0 1 1
9195 1152921504606846976) returns the obviously-bogus value (-948597
9196 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9197 reports time overflow. See
9198 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9199 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9200 * editfns.c: Include limits.h and intprops.h.
9201 (TIME_T_MIN, TIME_T_MAX): New macros.
9202 (time_overflow): Move earlier, to before first use.
9203 (hi_time, lo_time): New functions, for an accurate test for
9205 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9206 (Fget_internal_run_time): Don't assume time_t fits in int.
9207 (make_time): Use list2 instead of Fcons twice.
9208 (Fdecode_time): More accurate test for out-of-range times.
9209 (check_tm_member): New function.
9210 (Fencode_time): Use it, to test for out-of-range times.
9211 (lisp_time_argument): Don't rely on undefined left-shift and
9212 right-shift behavior when checking for time stamp overflow.
9214 * editfns.c (time_overflow): New function, refactoring common code.
9215 (Fformat_time_string, Fdecode_time, Fencode_time):
9216 (Fcurrent_time_string): Use it.
9218 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9219 * dired.c (make_time): Move to ...
9220 * editfns.c (make_time): ... here.
9221 * systime.h: Note the move.
9223 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9225 * fringe.c (update_window_fringes): Remove unused variables.
9227 * unexmacosx.c (copy_data_segment): Also copy __got section.
9230 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9232 * termcap.c [MSDOS]: Include "msdos.h".
9233 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9234 Constify `char *' arguments and their references according to
9235 prototypes in tparam.h.
9237 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9239 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9240 Adapt all references accordingly.
9242 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9244 2011-03-11 Tom Tromey <tromey@redhat.com>
9246 * buffer.c (syms_of_buffer): Remove obsolete comment.
9248 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9250 * termhooks.h (encode_terminal_code): Declare prototype.
9252 * msdos.c (encode_terminal_code): Don't declare prototype.
9254 * term.c (encode_terminal_code): Now external again, used by
9255 w32console.c and msdos.c.
9257 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9258 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9260 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9262 Fix some minor problems found by GCC 4.5.2's static checks.
9264 * fringe.c (update_window_fringes): Mark locals as initialized
9266 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9268 * alloc.c (mark_fringe_data): Move decl from here ...
9269 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9270 to check its interface.
9271 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9273 * fontset.c (free_realized_fontset): Now static.
9274 (Fset_fontset_font): Rename local to avoid shadowing.
9275 (fontset_font): Mark local as initialized.
9276 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9278 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9280 * xselect.c (x_disown_buffer_selections): Remove; not used.
9281 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9282 (x_own_selection, Fx_disown_selection_internal): Rename locals
9284 (x_handle_dnd_message): Remove local to avoid shadowing.
9286 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9287 so that the caller can use some name other than gcpro1.
9288 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9289 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9290 (Fx_backspace_delete_keys_p):
9291 Use them to avoid shadowing, and rename vars to avoid shadowing.
9292 (x_decode_color, x_set_name, x_window): Now static.
9293 (Fx_create_frame): Add braces to silence GCC warning.
9294 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9295 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9296 Remove unused locals.
9297 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9298 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9299 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9302 * xterm.h (x_mouse_leave): New decl.
9304 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9305 Remove unused functions.
9306 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9307 (x_calc_absolute_position): Now static.
9308 (XTread_socket): Don't define label "out" unless it's used.
9309 Don't declare local "event" unless it's used.
9310 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9311 unless they are used.
9312 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9313 (x_fatal_error_signal): Remove; not used.
9314 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9315 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9316 (x_error_catcher, x_connection_closed, x_error_handler):
9317 (x_error_quitter, xembed_send_message, x_iconify_frame):
9318 (my_log_handler): Rename locals to avoid shadowing.
9319 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9320 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9322 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9323 Rename or move locals to avoid shadowing.
9324 (tty_defined_color, merge_face_heights): Now static.
9325 (free_realized_faces_for_fontset): Remove; not used.
9326 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9327 does not deduce is never used uninitialized.
9328 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9329 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9331 * terminal.c (store_terminal_param): Now static.
9333 * xmenu.c (menu_highlight_callback): Now static.
9334 (set_frame_menubar): Remove unused local.
9335 (xmenu_show): Rename parameter to avoid shadowing.
9336 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9337 since they might point to immutable storage.
9338 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9339 since it's unused otherwise.
9341 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9342 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9343 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9344 avoids a gcc -Wuninitialized diagnostic.
9345 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9346 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9347 does not deduce are never used uninitialized.
9349 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9351 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9352 * window.c (window_loop, size_window):
9353 (run_window_configuration_change_hook, enlarge_window): Likewise.
9355 * window.c (display_buffer): Now static.
9356 (size_window): Mark variables that gcc -Wuninitialized
9357 does not deduce are never used uninitialized.
9358 * window.h (check_all_windows): New decl, to forestall
9359 gcc -Wmissing-prototypes diagnostic.
9360 * dispextern.h (bidi_dump_cached_states): Likewise.
9362 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9364 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9366 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9367 and to avoid gcc -Wuninitialized warning.
9368 (load_charset_map): Mark variables that gcc -Wuninitialized
9369 does not deduce are never used uninitialized.
9370 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9372 * coding.c (coding_set_source, coding_set_destination):
9373 Use "else { /* comment */ }" rather than "else /* comment */;"
9374 for clarity, and to avoid gcc -Wempty-body warning.
9375 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9376 a block, when the outer 'i' will do.
9377 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9378 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9379 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9380 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9381 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9382 Rename locals to avoid shadowing.
9383 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9384 * coding.c (emacs_mule_char, encode_invocation_designation):
9385 Now static, since they're not used elsewhere.
9386 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9387 (decode_coding_object, encode_coding_object, detect_coding_system):
9388 (decode_coding_emacs_mule): Mark variables that gcc
9389 -Wuninitialized does not deduce are never used uninitialized.
9390 (detect_coding_iso_2022): Initialize a local variable that might
9391 be used uninitialized. Leave a FIXME because it's not clear that
9392 this initialization is needed. (Bug#8211)
9393 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9394 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9395 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9396 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9397 Remove unused macros.
9399 * category.c (hash_get_category_set): Remove unused local var.
9400 (copy_category_table): Now static, since it's not used elsewhere.
9401 * character.c (string_count_byte8): Likewise.
9403 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9404 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9406 * chartab.c (copy_sub_char_table): Now static, since it's not used
9408 (sub_char_table_ref_and_range, char_table_ref_and_range):
9409 Rename locals to avoid shadowing.
9410 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9412 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9413 (BIDI_BOB): Remove unused macro.
9415 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9416 deduce are never used uninitialized.
9417 * term.c (encode_terminal_code): Likewise.
9419 * term.c (encode_terminal_code): Now static. Remove unused local.
9421 * tparam.h: New file.
9422 * term.c, tparam.h: Include it.
9423 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9424 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9425 Move these decls to tparam.h, and make them agree with what
9426 is actually in tparam.c. The previous trick of using incompatible
9427 decls in different modules does not conform to the C standard.
9428 All callers of tparam changed to use tparam's actual API.
9429 * tparam.c (tparam1, tparam, tgoto):
9430 Use const pointers where appropriate.
9432 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9433 * cm.h (struct cm): Likewise.
9434 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9435 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9436 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9437 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9438 (turn_on_face, init_tty): Likewise.
9439 * termchar.h (struct tty_display_info): Likewise.
9441 * term.c (term_mouse_position): Rename local to avoid shadowing.
9443 * alloc.c (mark_ttys): Move decl from here ...
9444 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9446 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9448 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9450 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9452 * search.c (compile_pattern_1): Remove argument regp, unused since
9453 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9454 (compile_pattern): Don't pass it.
9456 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9458 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9459 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9461 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9463 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9465 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9466 gdk_window_get_screen, gdk_window_get_geometry,
9467 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9468 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9469 (xg_get_pixbuf_from_pixmap): New function.
9470 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9471 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9472 Call xg_get_pixbuf_from_pixmap instead of
9473 gdk_pixbuf_get_from_drawable.
9474 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9475 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9476 (xg_check_special_colors): Use GtkStyleContext and its functions
9478 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9479 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9480 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9481 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9482 Call gtk_widget_get_preferred_size.
9483 (xg_frame_resized): gdk_window_get_geometry only takes 5
9485 (xg_win_to_widget, xg_event_is_for_menubar):
9486 Call gdk_x11_window_lookup_for_display.
9487 (xg_set_widget_bg): New function.
9488 (delete_cb): New function.
9489 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9490 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9491 (xg_set_background_color): Call xg_set_widget_bg.
9492 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9493 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9494 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9495 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9497 (update_frame_tool_bar): Call gtk_widget_hide.
9498 (xg_initialize): Use GDK_KEY_g.
9500 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9502 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9504 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9505 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9506 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9508 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9510 * w32xfns.c (select_palette): Check success of RealizePalette against
9511 GDI_ERROR, not zero.
9513 See ChangeLog.11 for earlier changes.
9519 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9521 This file is part of GNU Emacs.
9523 GNU Emacs is free software: you can redistribute it and/or modify
9524 it under the terms of the GNU General Public License as published by
9525 the Free Software Foundation, either version 3 of the License, or
9526 (at your option) any later version.
9528 GNU Emacs is distributed in the hope that it will be useful,
9529 but WITHOUT ANY WARRANTY; without even the implied warranty of
9530 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9531 GNU General Public License for more details.
9533 You should have received a copy of the GNU General Public License
9534 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.