1 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3 * w32font.c (Qsymbol): Remove local definition.
4 (syms_of_w32font): Don't DEFSYM it.
6 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
8 Fix sweep_vectors to handle large bool vectors correctly.
9 * alloc.c (sweep_vectors): Account total_vector_bytes for
10 bool vectors larger than VBLOCK_BYTES_MAX.
12 2012-07-18 Chong Yidong <cyd@gnu.org>
14 * frame.c (x_set_frame_parameters): Revert bogus change introduced
15 in 2012-05-25 commit by Paul Eggert (Bug#11738).
17 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
19 Return more descriptive data from Fgarbage_collect.
20 Suggested by Stefan Monnier in
21 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
22 * alloc.c (bounded_number): New function.
23 (total_buffers, total_vectors): New variable.
24 (total_string_size): Rename to total_string_bytes, adjust users.
25 (total_vector_size): Rename to total_vector_bytes, adjust users.
26 (sweep_vectors): Account total_vectors and total_vector_bytes.
27 (Fgarbage_collect): New return value. Adjust documentation.
28 (gc_sweep): Account total_buffers.
29 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
30 (VECTOR_SIZE): Remove.
31 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
32 (Qinterval, Qmisc): New symbols.
33 (syms_of_data): Initialize them.
34 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
35 (Qcons, Qbuffer): New declarations.
37 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
39 * alloc.c (Fmemory_free): Account for memory-free's own storage.
40 Round up, not down. Improve doc.
42 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
44 Restore old code in allocate_string_data to avoid Faset breakage.
45 Reported by Julien Danjou <julien@danjou.info> in
46 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
47 * alloc.c (allocate_string_data): Restore old code with minor
48 adjustments, fix comment to explain this subtle issue.
50 2012-07-17 Eli Zaretskii <eliz@gnu.org>
52 Remove FILE_SYSTEM_CASE.
53 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
55 * fileio.c (FILE_SYSTEM_CASE): Don't define.
56 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
57 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
58 call-process-region passes it through expand-file-name.
60 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
62 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
64 Fix crash when creating indirect buffer (Bug#11917)
65 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
66 Don't handle unbound variables specially if non-zero.
67 (Fbuffer_local_variables): Pass zero.
68 (clone_per_buffer_values): Pass non-zero.
70 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
72 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
73 to make the loop interruptible.
75 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
77 * gnutls.c (emacs_gnutls_handshake): Only retry if
80 2012-07-17 Eli Zaretskii <eliz@gnu.org>
81 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
83 Cleanup and convert miscellaneous checks to eassert.
84 * alloc.c (mark_interval): Fix comment, partially rephrase
85 old comment from intervals.h (see below).
86 * intervals.c (find_interval, adjust_intervals_for_insertion)
87 (delete_interval, adjust_intervals_for_deletion)
88 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
90 (adjust_intervals_for_insertion, make_new_interval):
91 Remove obsolete and unused code.
92 * intervals.h (struct interval): Remove obsolete comment.
93 * textprotp.c (erase_properties): Remove unused code.
94 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
95 (Fremove_list_of_text_properties): Convert to eassert.
97 2012-07-17 Chong Yidong <cyd@gnu.org>
99 * editfns.c (Finsert_char): Doc fix.
101 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
103 Fix previous change to make Fmemory_free always accurate.
104 * alloc.c (make_interval): Update total_free_intervals.
105 (make_float): Likewise for total_free_floats.
106 (free_cons, Fcons): Likewise for total_free_conses.
107 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
108 Likewise for total_free_vector_bytes.
109 (Fmake_symbol): Likewise for total_free_symbols.
110 (bytes_free): Remove.
112 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
114 Simple free memory accounting feature.
115 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
116 (sweep_vectors): Accumulate size of free vectors.
117 (Fgarbage_collect): Setup bytes_free.
118 (Fmemory_free): New function.
119 (syms_of_alloc): Register it.
121 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
123 Cleanup overlays checking.
124 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
125 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
126 eassert and OVERLAYP.
127 (sort_overlays): Change to use OVERLAYP.
129 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
131 * editfns.c (Finsert_char): Make it interactive, and make the
132 second arg optional. Copy interactive spec and docstring from
135 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
137 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
138 Unlike the other wrapped functions, fabs has an unspecified
141 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
143 * nsterm.m (keyDown): Interpret flags without left/right bits
144 as the left key (Bug#11670).
146 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
148 Remove empty and useless init functions.
149 * lisp.h (init_character_once, init_fns, init_image)
150 (init_filelock, init_sound): Remove prototype.
151 * character.c (init_character_once): Remove.
152 * filelock.c (init_filelock): Likewise.
153 * fns.c (init_fns): Likewise.
154 * image.c (init_image): Likewise.
155 * sound.c (init_sound): Likewise.
156 * emacs.c (main): Adjust accordingly.
158 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
160 * gtkutil.h: Tiny cleanups.
161 (use_old_gtk_file_dialog): Remove useless declaration.
162 (xg_uses_old_file_dialog): Add suggested const attribute.
164 2012-07-15 Eli Zaretskii <eliz@gnu.org>
166 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
167 (bidi_paragraph_init): Use it to limit search forward for a strong
168 directional character in abnormally large paragraphs full of
169 neutral or weak characters. (Bug#11943)
171 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
173 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
174 the toolbar (Bug#9451).
175 (xg_make_tool_item): Give the widget event box a transparent
178 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
180 Cleanup basic allocation variables and functions.
181 * alloc.c (ignore_warnings, init_intervals, init_float)
182 (init_cons, init_symbol, init_marker): Remove.
183 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
184 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
185 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
186 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
187 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
188 (staticidx, init_alloc_once, init_strings, free_ablock):
189 Remove redundant initialization.
190 * fns.c (init_weak_hash_tables): Remove.
191 * lisp.h (init_weak_hash_tables): Remove prototype.
193 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
195 Use zero_vector where appropriate.
196 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
198 * lisp.h (zero_vector): New declaration.
199 * font.c (null_vector): Remove.
200 (syms_of_font): Remove initialization and staticpro.
201 (font_list_entities, font_find_for_lface): Change to use zero_vector.
202 * keymap.c (Faccessible_keymaps): Likewise.
204 2012-07-15 Leo Liu <sdl.web@gmail.com>
206 * fringe.c: Fix typo in comments.
208 2012-07-14 Leo Liu <sdl.web@gmail.com>
210 * fringe.c: Add a new bitmap exclamation-mark.
212 2012-07-14 Eli Zaretskii <eliz@gnu.org>
214 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
216 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
217 (HAVE_MENUS): Don't define, defined by editing config.in with
219 (GMALLOC_INHIBIT_VALLOC): Don't define.
220 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
222 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
224 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
226 2012-07-14 Glenn Morris <rgm@gnu.org>
228 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
229 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
230 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
232 2012-07-13 Glenn Morris <rgm@gnu.org>
234 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
236 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
237 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
239 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
241 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
242 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
243 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
244 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
246 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
247 as boolean expression.
248 (x_set_window_size): Remove unused variable toolbar.
249 (ns_get_color_default, ns_mod_to_lisp): Remove.
250 (ns_mouse_position): Remove unused variables xchar and ychar.
251 (ns_compute_glyph_string_overhangs): Remove unused variable face.
252 (ns_set_vertical_scroll_bar): Remove unused variable count.
253 (ns_delete_terminal): Remove unused variable i.
254 (ns_term_init): Remove unused variables r, g and b.
255 (mouseDown): Remove unused variable window.
256 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
257 (initFrameFromEmacs): Remove unused variable vbextra.
258 (mouseEntered): Remove unused variables p and dpyinfo.
259 (mouseExited): Remove unused variables p and r.
260 (ns_define_frame_cursor, ns_clear_frame_area)
261 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
262 (menuDown): Assign [sender tag] to variable and cast the variable.
264 * nsterm.h (menuDown): Add id as type to argument sender.
265 (ns_display_info_for_name): Add Lisp_Object argument.
266 (ns_term_init): Add Lisp_Object argument.
267 (ns_map_event_to_object): Add void argument.
268 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
269 prototype with arguments and only declare if __OBJC__.
270 (nxatoms_of_nsselect): Add void argument.
271 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
272 (ns_alloc_autorelease_pool): Add void argument.
273 (ns_release_autorelease_pool): Add void* argument.
274 (ns_get_defaults_value): Add const char* argument.
276 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
277 (initFromContents): Use SSDATA where appropriate.
278 (ns_update_menubar): Add braces to ambigous if-else.
279 (initWithTitle): Put () around assignment in if statement.
280 (ns_menu_show): Remove unused variables window and keymap.
281 (update_frame_tool_bar): Remove unused variable selected_p.
282 (initWithContentRect): Remove unused variable this_cmd_name.
284 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
286 (setXBMColor): Remove unused variable len.
287 (setPixmapData): Put () around assignment in loop statement.
289 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
290 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
292 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
293 around assignment in loop statement.
294 (nsfont_open): Remove unused variable i.
295 (nsfont_open): Remove unused variable len.
296 (nsfont_draw): Remove unused variable cs.
298 * nsfns.m (x_set_icon_name, ns_set_name_internal)
299 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
300 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
301 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
302 (Fns_font_name, Fns_perform_service)
303 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
304 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
305 (ns_set_name): Remove unused variable view.
306 (x_set_menu_bar_lines): Remove unused variable olines.
307 (x_set_tool_bar_lines): Remove unused variable root_window.
308 (Fns_list_colors): Put () around assignment in while statement.
309 (Fns_perform_service): Remove unused variable len.
310 (Fns_display_usable_bounds): Remove unused variable top.
311 (syms_of_nsfns): Remove unused variable i.
313 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
316 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
318 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
319 and free it with DestroyExceptionInfo (Bug#11558).
321 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
323 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
324 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
325 Set here, not in nt/config.nt.
327 2012-07-13 Eli Zaretskii <eliz@gnu.org>
329 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
330 cursor overflow into the last glyph on display line when the right
331 fringe is off. (Bug#11832)
333 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
335 * xdisp.c (produce_special_glyphs): Now static.
336 * dispextern.h (produce_special_glyphs): Remove decl.
338 2012-07-13 Glenn Morris <rgm@gnu.org>
340 * s/bsd-common, s/cygwin.h: Remove empty files.
341 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
343 * s/usg5-4-common.h (USG, USG5):
344 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
345 * s/sol2-6.h (SOLARIS2):
346 * s/irix6-5.h (IRIX6_5):
347 * s/hpux10-20.h (USG, USG5, HPUX):
348 * s/gnu-linux.h (USG, GNU_LINUX):
349 * s/freebsd.h (BSD_SYSTEM):
350 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
351 * s/cygwin.h (CYGWIN):
352 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
353 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
355 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
357 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
359 2012-07-13 Glenn Morris <rgm@gnu.org>
361 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
363 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
365 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
366 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
368 2012-07-12 Glenn Morris <rgm@gnu.org>
370 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
372 * process.c (init_process_emacs): Rename from init_process.
373 The old name is also the name of a Mach system call.
374 * lisp.h, emacs.c: Update for this name change.
375 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
378 2012-07-12 Eli Zaretskii <eliz@gnu.org>
380 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
381 memmove call that removes glyphs covered by the left truncation
382 glyph. Improve commentary.
383 (display_line): Fix display of continuation glyphs on GUI frames
384 when the right fringe is turned off and variable-size fonts are
385 used in the window. Move the code that appends a stretch glyph to
386 produce_special_glyphs, so that it could be used for truncation
387 and continuation glyphs alike.
388 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
389 glyph of a suitably computed width, to align the special glyphs at
390 the window margin. Code moved from display_line. (Bug#11832)
392 2012-07-12 Glenn Morris <rgm@gnu.org>
394 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
396 * s/gnu-linux.h, s/hpux10-20.h:
397 Do not unconditionally define HAVE_XRMSETDATABASE.
399 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
401 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
403 Fix typos that broke OS X build.
404 Reported by Randal L. Schwartz in
405 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
406 * nsterm.m (ns_timeout): Add missing local decl.
407 (ns_get_color): snprintf -> sprintf, to fix typo.
409 2012-07-12 Glenn Morris <rgm@gnu.org>
411 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
412 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
413 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
414 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
416 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
417 Move PTY_OPEN to configure.
419 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
420 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
421 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
423 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
425 Use empty_unibyte_string where applicable.
426 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
427 * lread.c (read1): Likewise.
428 * xsettings.c (syms_of_xsettings): Likewise.
430 2012-07-12 Glenn Morris <rgm@gnu.org>
432 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
433 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
434 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
435 * s/hpux10-20.h (RUN_TIME_REMAP):
436 * s/bsd-common.h (TABDLY): Move to configure.
438 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
440 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
442 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
443 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
445 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
447 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
448 * s/template.h: Move NARROWPROTO to configure.
450 2012-07-11 Glenn Morris <rgm@gnu.org>
452 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
453 unused since 2011-01-17 change to systty.h.
455 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
456 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
457 Move HAVE_PTYS and HAVE_SOCKETS to configure.
459 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
461 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
463 2012-07-11 Glenn Morris <rgm@gnu.org>
465 * s/darwin.h, s/gnu-linux.h, s/template.h:
466 Move INTERRUPT_INPUT to configure.
468 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
470 Minor adjustments to interning code.
471 * lisp.h (intern, intern_c_string): Redefine as static inline
472 wrappers for intern_1 and intern_c_string_1, respectively.
473 (intern_1, intern_c_string_1): Rename prototypes.
474 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
476 * font.c (font_intern_prop): Likewise. Adjust comment.
477 * w32font.c (intern_font_name): Likewise.
479 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
481 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
483 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
484 of Fcar/Fcdr if possible.
485 * font.c (check_otf_features): Likewise.
486 * fontset.c (Fnew_fontset): Likewise.
487 * gnutls.c (Fgnutls_boot): Likewise.
488 * minibuf.c (read_minibuf): Likewise.
489 * msdos.c (IT_set_frame_parameters): Likewise.
490 * xmenu.c (Fx_popup_dialog): Likewise.
491 * w32menu.c (Fx_popup_dialog): Likewise.
493 2012-07-11 Glenn Morris <rgm@gnu.org>
495 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
496 since nothing has defined it on these platforms.
498 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
499 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
501 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
502 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
503 Move CLASH_DETECTION to configure.
505 * s/gnu.h: Remove file, which is now empty.
507 * s/gnu.h, s/gnu-linux.h:
508 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
510 2012-07-11 John Wiegley <johnw@newartisans.com>
512 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
513 function attribute, so we only use it if it exists in the
516 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
518 Avoid call to strlen in fast_c_string_match_ignore_case.
519 * search.c (fast_c_string_match_ignore_case): Change to use
520 length argument. Adjust users accordingly.
521 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
523 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
526 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
527 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
530 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
533 * s/hpux10-20.h (HAVE_PERROR): Remove.
534 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
535 Remove dummy definition, as this problem was obsolete long ago.
538 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
540 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
542 Avoid calls to strlen in font processing functions.
543 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
544 (font_open_by_name): Change to use length argument. Adjust
546 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
548 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
549 Change to return ptrdiff_t.
550 (xfont_list_pattern, xfont_match): Use length returned by
551 xfont_decode_coding_xlfd.
552 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
554 2012-07-11 Glenn Morris <rgm@gnu.org>
556 * s/darwin.h, s/freebsd.h, s/netbsd.h:
557 Move DONT_REOPEN_PTY to configure.
559 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
560 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
562 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
564 Remove "#define unix" that is no longer needed (Bug#11905).
565 * s/aix4-2.h (unix): Remove; no longer needed.
567 EMACS_TIME simplification (Bug#11875).
568 This replaces macros (which typically do not work in GDB)
569 with functions, typedefs and enums, making the code easier to debug.
570 The functional style also makes code easier to read and maintain.
571 * systime.h: Include <sys/time.h> on all hosts, not just if
572 WINDOWSNT, since 'struct timeval' is needed in general.
573 (EMACS_TIME): Now a typedef, not a macro.
574 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
576 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
577 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
578 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
579 (EMACS_TIME_LE): Now functions, not macros.
580 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
581 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
582 which are not functions. All uses rewritten to use:
583 (make_emacs_time): New function.
584 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
585 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
586 not functions. All uses rewritten to use the following, respectively:
587 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
588 (add_emacs_time, sub_emacs_time): New functions.
589 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
590 * fileio.c (Fcopy_file):
591 * xterm.c (XTflash): Get the current time closer to when it's used.
592 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
594 * bytecode.c (targets): Suppress -Woverride-init warnings.
596 Simplify by avoiding confusing use of strncpy etc.
597 * doc.c (Fsnarf_documentation):
598 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
599 * frame.c (Fmake_terminal_frame):
600 * gtkutil.c (get_utf8_string):
602 * nsmenu.m (ns_update_menubar):
603 * regex.c (regerror):
604 Prefer memcpy to strncpy and strncat when either will do.
605 * fileio.c (Fsubstitute_in_file_name):
606 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
607 (menu_separator_name_p):
608 * nsmenu.m (ns_update_menubar):
609 Prefer memcmp to strncmp when either will do.
610 * nsterm.m: Include <ftoastr.h>.
612 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
613 Prefer snprintf to strncpy.
614 * nsterm.m (ns_term_init):
615 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
616 * nsterm.m (ns_term_init):
617 Avoid the need for strncpy, by using build_string or
618 make_unibyte_string directly. Use dtoastr, not snprintf.
619 * process.c (Fmake_network_process): Diagnose service names that
620 are too long, rather than silently truncating them or creating
621 non-null-terminated names.
622 (Fnetwork_interface_info): Likewise, for interface names.
623 * sysdep.c (system_process_attributes) [GNU_LINUX]:
624 Prefer sprintf to strncat.
625 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
626 Prefer vsnprintf to vsprintf + strncpy.
628 2012-07-10 Glenn Morris <rgm@gnu.org>
630 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
631 Clarify fallback case.
633 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
635 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
636 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
637 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
638 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
639 where argument type is known to be a Lisp_Cons.
641 2012-07-10 Tom Tromey <tromey@redhat.com>
643 * bytecode.c (BYTE_CODE_THREADED): New macro.
644 (BYTE_CODES): New macro. Replaces all old byte-code defines.
645 (enum byte_code_op): New type.
646 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
647 (exec_byte_code): Use them. Use token threading when applicable.
649 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
651 Optimize pure C strings initialization.
652 * lisp.h (make_pure_string): Fix prototype.
653 (build_pure_c_string): New function, defined as static inline. This
654 provides a better opportunity to optimize away calls to strlen when
655 the function is called with compile-time constant argument.
656 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
657 argument, adjust users accordingly. Use build_pure_c_string where
659 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
660 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
661 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
663 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
665 Avoid calls to strlen in miscellaneous functions.
666 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
667 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
668 * lread.c (openp): Likewise.
670 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
672 Avoid calls to strlen in path processing functions.
673 * fileio.c (file_name_as_directory): Add comment. Change to add
674 srclen argument and return the length of result. Adjust users
676 (directory_file_name): Fix comment. Change to add srclen argument,
677 swap 1st and 2nd arguments to obey the common convention. Adjust
679 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
681 2012-07-10 Glenn Morris <rgm@gnu.org>
683 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
684 Move PENDING_OUTPUT_COUNT definition to configure.
686 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
687 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
688 * s/gnu.h (DATA_START): Move definitions to configure.
690 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
691 We include usg5-4-common.h, which defines them both.
693 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
694 O_RDONLY already includes it).
696 Stop ns builds setting the EMACSLOADPATH environment variable.
697 * nsterm.m (ns_load_path): Rename from ns_init_paths.
698 Now it does not set EMACSLOADPATH, just returns the load-path string.
699 * nsterm.h: Update accordingly.
700 * lread.c [HAVE_NS]: Include nsterm.h.
701 (init_lread) [HAVE_NS]: Use ns_load_path.
702 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
704 2012-07-09 Glenn Morris <rgm@gnu.org>
706 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
707 since the included bsd-common.h does so.
709 Stop ns builds setting the EMACSPATH environment variable.
710 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
711 (ns_init_paths): Do not set EMACSPATH.
712 * nsterm.h (ns_exec_path): Add it.
713 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
716 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
718 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
720 * process.c (wait_reading_process_output): 'waitchannels' was unset
721 when read_kbd || !NILP (wait_for_cell); fix this.
723 Add GCC-style 'const' attribute to functions that can use it.
724 * character.h (char_resolve_modifier_mask):
725 * keyboard.h (make_ctrl_char):
726 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
727 (init_character_once, next_almost_prime, init_fns, init_image)
728 (flush_pending_output, init_sound):
729 * mem-limits.h (start_of_data):
730 * menu.h (finish_menu_items):
732 * emacs.c (DEFINE_DUMMY_FUNCTION):
733 Declare the dummy function with ATTRIBUTE_CONST.
734 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
735 Add decls with ATTRIBUTE_CONST.
737 Minor improvements to make_formatted_string.
738 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
739 where int is good enough, as vsprintf returns an int.
740 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
742 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
744 Use make_formatted_string to avoid double length calculation.
745 * lisp.h (make_formatted_string): New prototype.
746 * alloc.c (make_formatted_string): New function.
747 * buffer.c (Fgenerate_new_buffer_name): Use it.
748 * dbus.c (syms_of_dbusbind): Likewise.
749 * editfns.c (Fcurrent_time_zone): Likewise.
750 * filelock.c (get_boot_time): Likewise.
751 * frame.c (make_terminal_frame, set_term_frame_name)
752 (x_report_frame_params): Likewise.
753 * image.c (gs_load): Likewise.
754 * minibuf.c (get_minibuffer): Likewise.
755 * msdos.c (dos_set_window_size): Likewise.
756 * process.c (make_process): Likewise.
757 * xdisp.c (ensure_echo_area_buffers): Likewise.
758 * xsettings.c (apply_xft_settings): Likewise.
760 2012-07-09 Glenn Morris <rgm@gnu.org>
762 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
763 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
764 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
765 * nsterm.h (ns_etc_directory): Add it.
766 * callproc.c [HAVE_NS]: Include nsterm.h.
767 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
769 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
771 Move marker debugging code under MARKER_DEBUG.
772 * marker.c (MARKER_DEBUG): Move marker debugging code under
773 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
774 for bootstrap with --enable-checking (~3x slowdown reported
775 by Juanma Barranquero <lekktu@gmail.com>).
776 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
778 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
780 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
781 See <http://bugs.gnu.org/11825#29>.
783 2012-07-08 Eli Zaretskii <eliz@gnu.org>
785 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
786 has no font, use the frame's font. (Bug#11813)
787 (display_line): Add commentary about displaying truncation glyphs
789 (produce_special_glyphs): Move here from term.c.
791 * term.c (produce_special_glyphs): Move to xdisp.c.
793 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
796 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
798 * xdisp.c (display_line): Avoid warning about implicit declaration
801 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
803 * lisp.h: Remove empty conditional.
805 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
807 * lread.c (load_path_check): Now static.
809 Fix some minor --with-ns problems found by static checking.
810 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
811 (x_set_font) [!HAVE_X_WINDOWS]:
812 * image.c (xpm_load_image) [HAVE_NS]:
813 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
814 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
816 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
817 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
818 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
819 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
820 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
821 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
822 Fix pointer signedness problem.
823 * xfaces.c (FRAME_X_FONT_TABLE):
824 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
826 2012-07-07 Glenn Morris <rgm@gnu.org>
828 * lread.c (load_path_check): New function, split from init_lread.
829 (init_lread): Reorganize. Motivation:
830 If EMACSLOADPATH is set, check/warn about that rather than the
831 defaults, which we are not going to use. Hence we can remove
832 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
833 Don't warn if site-lisp directories are missing.
834 If not installed, start from a blank load-path, since
835 PATH_LOADSEARCH refers to the eventual installation directories.
837 2012-07-07 Eli Zaretskii <eliz@gnu.org>
839 Support truncation and continuation glyphs on GUI frames, when
840 fringes are disabled. (Bug#11832)
841 * xdisp.c (init_iterator): Get dimensions of truncation and
842 continuation glyphs even if on GUI frames. Adjust
843 it->last_visible_x on GUI frames when the left or right fringes,
845 (start_display, move_it_in_display_line_to): Handle the case of a
846 GUI frame without a fringe to display continuation or truncation
848 (insert_left_trunc_glyphs): Support GUI frames: make sure
849 truncation glyphs overwrite enough glyphs from the current line to
850 have sufficient space in pixels.
851 (display_line): Support truncation and continuation glyphs on GUI
852 frames. If some spare pixels are left on the line after inserting
853 the truncation glyphs, fill that space with a stretch glyph of a
854 suitably computed width.
856 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
857 produce_glyphs, to support GUI sessions.
859 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
861 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
863 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
865 Do not require float-time's arg to fit in time_t (Bug#11825).
866 This works better on hosts where time_t is unsigned, and where
867 float-time is applied to the (negative) difference between two times.
868 * editfns.c (decode_time_components): Last arg is now double *,
869 not int *, and means to store all the result as a double, without
870 worrying about whether the seconds part fits in time_t.
872 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
874 (Ffloat_time): Do not fail merely because the specified time falls
875 outside of time_t range.
877 2012-07-07 Glenn Morris <rgm@gnu.org>
879 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
880 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
881 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
883 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
885 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
888 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
890 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
892 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
893 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
894 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
895 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
896 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
897 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
899 * xfont.c (compare_font_names): Redo to omit the need for casts.
901 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
903 * xfns.c (Fx_change_window_property): Doc fix.
904 * w32fns.c (Fx_change_window_property): Doc fix.
906 * w32fns.c (Fx_window_property): Accept the same arguments as the
907 X Windows version. Doc fix.
908 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
910 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
911 Eli Zaretskii <eliz@gnu.org>
913 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
914 Windows-specific code from nt/config.nt moved here.
915 Obsolete settings removed.
917 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
919 * process.c: Avoid unnecessary calls to gettime.
920 (wait_reading_process_output): Don't get the time of day
921 when gobbling data immediately and not waiting, as there's no need
922 for it in that case. This removes a FIXME.
924 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
926 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
927 is defined (Bug#11768).
929 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
931 Fix marker debugging code.
932 * marker.c (byte_char_debug_check): Do not perform the check
933 if buffer is not multibyte.
934 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
935 Call byte_char_debug_check with correct arguments.
937 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
939 Compile marker debugging code only if ENABLE_CHECKING is defined.
940 * marker.c (byte_char_debug_check, count_markers):
941 Use only if ENABLE_CHECKING is defined.
942 (byte_debug_flag): Remove.
943 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
944 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
946 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
948 Avoid code repetition in marker-related functions.
949 * marker.c (attach_marker): New function.
950 (Fset_marker, set_marker_restricted, set_marker_both)
951 (set_marker_restricted_both): Use it.
952 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
953 Consistently rename charno to charpos.
954 (marker_position): Add eassert.
955 (marker_byte_position): Convert to eassert.
957 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
959 Simplify list operations in unchain_overlay and unchain_marker.
960 * buffer.c (unchain_overlay): Simplify. Add comment.
961 * marker.c (unchain_marker): Simplify. Fix comments.
963 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
965 Introduce fast path for the widely used marker operation.
966 * alloc.c (build_marker): New function.
967 * lisp.h (build_marker): New prototype.
968 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
969 * composite.c (autocmp_chars): Likewise.
970 * editfns.c (buildmark): Remove.
971 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
972 (save_restriction_save): Use build_marker.
973 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
974 * window.c (save_window_save): Likewise.
976 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
978 Do not use Fdelete_overlay in delete_all_overlays
979 to avoid redundant calls to unchain_overlay.
980 * buffer.c (drop_overlay): New function.
981 (delete_all_overlays, Fdelete_overlay): Use it.
982 * minibuf.c (get_minibuffer): Fix comment.
984 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
986 Port to OpenBSD 5.1 amd64.
987 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
988 This is needed for OpenBSD, and should be harmless on all BSD systems.
989 Also, include <sys/sysctl.h>, as it should be available on all
990 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
991 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
992 use p_pid member, not kp_proc.pid.
994 2012-07-06 Glenn Morris <rgm@gnu.org>
996 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
998 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1000 More xmalloc and related cleanup.
1001 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1002 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1003 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1004 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1005 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1006 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1007 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1008 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1009 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1011 Omit needless casts involving void * pointers and allocation.
1012 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1013 as the former is more robust if P's type is changed.
1014 Prefer xzalloc to xmalloc + memset 0.
1015 Simplify malloc-or-realloc to realloc.
1016 Don't worry about xmalloc returning a null pointer.
1017 Prefer xstrdup to xmalloc + strcpy.
1018 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1020 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1021 alloca of a constant.
1023 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1026 hscroll is larger than the line width. Fixes long and futile
1027 looping inside extend_face_to_end_of_line (on a TTY) producing
1028 glyphs that are not needed and thrown away.
1030 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1032 * marker.c (set_marker_restricted_both): Simplify by using
1035 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1037 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1039 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1041 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1042 not defined (Bug#11768).
1043 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1044 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1045 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1046 followed by gtk_box_set_homogeneous (Bug#11768).
1047 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1048 (update_theme_scrollbar_width, xg_create_scroll_bar):
1049 Use gtk_scrollbar_new (Bug#11768).
1050 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1051 (is_box_type): New function (Bug#11768).
1052 (xg_tool_item_stale_p): Call is_box_type.
1053 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1054 with default display (Bug#11768).
1056 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1058 * xdisp.c (window_hscroll_limited): New function.
1059 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1060 coordinates when window's hscroll is set to insanely large
1063 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1065 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1066 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1068 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1071 * lisp.h (xzalloc): New prototype. Omit needless casts.
1072 * alloc.c (xzalloc): New function. Omit needless casts.
1073 * charset.c: Omit needless casts. Convert all calls to
1074 xmalloc with following memset to xzalloc.
1075 * dispnew.c: Likewise.
1076 * fringe.c: Likewise.
1077 * image.c: Likewise.
1078 * sound.c: Likewise.
1080 * w32fns.c: Likewise.
1081 * w32font.c: Likewise.
1082 * w32term.c: Likewise.
1083 * xfaces.c: Likewise.
1085 * xterm.c: Likewise.
1086 * atimer.c: Omit needless casts.
1087 * buffer.c: Likewise.
1088 * callproc.c: Likewise.
1090 * coding.c: Likewise.
1091 * composite.c: Likewise.
1093 * doprnt.c: Likewise.
1094 * editfns.c: Likewise.
1095 * emacs.c: Likewise.
1097 * filelock.c: Likewise.
1099 * gtkutil.c: Likewise.
1100 * keyboard.c: Likewise.
1102 * lread.c: Likewise.
1103 * minibuf.c: Likewise.
1104 * msdos.c: Likewise.
1105 * print.c: Likewise.
1106 * process.c: Likewise.
1107 * region-cache.c: Likewise.
1108 * search.c: Likewise.
1109 * sysdep.c: Likewise.
1110 * termcap.c: Likewise.
1111 * terminal.c: Likewise.
1112 * tparam.c: Likewise.
1113 * w16select.c: Likewise.
1115 * w32reg.c: Likewise.
1116 * w32select.c: Likewise.
1117 * w32uniscribe.c: Likewise.
1118 * widget.c: Likewise.
1119 * xdisp.c: Likewise.
1120 * xmenu.c: Likewise.
1122 * xselect.c: Likewise.
1124 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1126 * fileio.c (time_error_value): Check the right error number.
1127 Problem reported by Troels Nielsen in
1128 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1130 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1132 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1133 This should be fixed in a better way; see Eli Zaretskii in
1134 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1135 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1137 * fileio.c (time_error_value): Rename from special_mtime.
1138 The old name's problems were noted by Eli Zaretskii in
1139 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1141 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1142 This variable's comment says Emacs needs at least one GDB-visible
1143 symbol of type enum pvec_type, to work around GDB problems.
1144 The symbol's value doesn't matter.
1146 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1147 that causes compilation to fail on pre-C99 compilers.
1149 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1151 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1152 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1154 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1156 * buffer.c (init_buffer_once): Fix initialization of
1157 headers for buffer_defaults and buffer_local_symbols.
1158 Reported by Juanma Barranquero <lekktu@gmail.com>.
1160 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1162 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1163 * lisp.h (enum pvec_type): Use fewer bits.
1164 (PSEUDOVECTOR_SIZE_BITS): New constant.
1165 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1166 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1167 change in pvec_type.
1168 (PSEUDOVECTOR_TYPEP): New macro.
1169 (TYPED_PSEUDOVECTORP): Use it.
1170 * fns.c (internal_equal): Adapt code to extract pvectype.
1171 * emacs.c (gdb_pvec_type): Update type.
1172 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1173 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1174 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1175 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1176 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1177 abusing vector->header.next.nbytes.
1178 (live_vector_p): Use PVEC_TYPE.
1179 (mark_object): Adapt code to extract pvectype. Use switch.
1181 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1183 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1184 Tighten new eassert a bit.
1186 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1188 Fix compilation with --enable-gcc-warnings and -O1
1190 * doprnt.c (doprnt): Change type of tem to int, initialize
1191 to avoid compiler warning. Add eassert.
1192 * search.c (simple_search): Initialize match_byte to avoid
1193 compiler warning. Add eassert.
1195 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1197 Avoid weird behavior with large horizontal scrolls.
1198 Without this change, for example, large hscroll values would
1199 mess up Emacs's display on Fedora 15 x86, presumably due to
1200 overflows in int calculations in the display code.
1201 Also, if buffers had long lines, Emacs would freeze.
1202 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1203 (set_window_hscroll): New function, containing the old guts of
1204 Fset_window_hscroll. Return the clipped value.
1205 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1206 This avoids the need to check against PTRDIFF_MAX.
1208 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1210 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1212 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1214 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1216 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1217 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1218 since GCC 4.4.6 issues a bogus warning for them.
1220 Fix bugs in file timestamp newness comparisons.
1221 * fileio.c (Ffile_newer_than_file_p):
1222 * lread.c (Fload): Use full timestamp resolution of files,
1223 not just the 1-second resolution, so that files that are only
1224 slightly newer still count as newer.
1225 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1226 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1228 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1230 * fileio.c: Improve handling of file time marker. (Bug#11852)
1231 (special_mtime): New function.
1232 (Finsert_file_contents, Fverify_visited_file_modtime):
1233 Use it to set special mtime values consistently.
1235 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1237 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1238 marker for non-existing file. (Bug#11852)
1240 2012-07-03 Glenn Morris <rgm@gnu.org>
1242 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1243 and did not make it into globals.h).
1245 2012-07-03 Tom Tromey <tromey@redhat.com>
1247 * window.c (Fset_window_margins, Fset_window_fringes)
1248 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1249 * textprop.c (Fprevious_property_change): No longer static.
1250 * syntax.c (Fsyntax_table_p): No longer static.
1251 * process.c (Fget_process, Fprocess_datagram_address): No longer
1253 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1254 * keyboard.c (Fcommand_execute): No longer static.
1256 * insdel.c (Fcombine_after_change_execute): No longer static.
1257 * image.c (Finit_image_library): No longer static.
1258 * fileio.c (Fmake_symbolic_link): No longer static.
1259 * eval.c (Ffetch_bytecode): No longer static.
1260 * editfns.c (Fuser_full_name): No longer static.
1261 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1263 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1265 * dired.c (Ffile_attributes): No longer static.
1266 * composite.c (Fcomposition_get_gstring): No longer static.
1267 * callproc.c (Fgetenv_internal): No longer static.
1269 * ccl.h: Remove EXFUNs.
1270 * buffer.h: Remove EXFUNs.
1271 * dispextern.h: Remove EXFUNs.
1272 * intervals.h: Remove EXFUNs.
1273 * fontset.h: Remove EXFUN.
1274 * font.h: Remove EXFUNs.
1275 * dosfns.c (system_process_attributes): Remove EXFUN.
1276 * keymap.h: Remove EXFUNs.
1277 * lisp.h: Remove EXFUNs.
1278 * w32term.h: Remove EXFUNs.
1279 * window.h: Remove EXFUNs.
1280 * xsettings.h: Remove EXFUN.
1281 * xterm.h: Remove EXFUN.
1283 2012-07-03 Glenn Morris <rgm@gnu.org>
1285 * lisp.h (Frandom): Make it visible to C.
1286 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1287 buffer for invisible buffers. (Bug#1229)
1289 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1291 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1292 values which aren't power of 2.
1293 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1294 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1297 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1299 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1301 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1303 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1305 * alloc.c (allocate_vector_block): Remove redundant
1306 calls to mallopt if DOUG_LEA_MALLOC is defined.
1307 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1308 avoid calls to mallopt if zero_vector is returned.
1310 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1312 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1313 is enabled, avoid dereferencing NULL current_sblock if
1316 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1318 Cleanup basic buffer management.
1319 * buffer.h (struct buffer): Change layout to use generic vector
1320 marking code. Fix some comments. Change type of 'clip_changed'
1321 to bitfield. Remove unused #ifndef old.
1322 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1323 (GET_OVERLAYS_AT): Fix indentation.
1324 (for_each_per_buffer_object_at): New macro.
1325 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1326 (Fbuffer_local_variables): Use it.
1327 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1328 * alloc.c (allocate_buffer): Adjust to match new layout of
1329 struct buffer. Fix comment.
1330 (mark_overlay): New function.
1331 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1332 Lisp area of struct buffer.
1333 (mark_object): Use it. Adjust marking of misc objects
1334 and related comments.
1336 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1338 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1339 wrapper that is not needed because the wrapped code is a no-op (zero
1340 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1341 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1343 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1345 * alloc.c (mark_buffer): Simplify. Remove prototype.
1346 (mark_object): Add comment. Reorganize marking of vector-like
1347 objects. Use CHECK_LIVE for all vector-like objects except buffers
1348 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1349 redundant calls to mark_vectorlike for bool vectors.
1351 2012-06-30 Glenn Morris <rgm@gnu.org>
1353 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1355 * epaths.in (PATH_SITELOADSEARCH): New.
1356 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1357 This is rather than relying on --enable-locallisppath elements
1358 having "site-lisp" in their names. (Bug#10208#25, 11658)
1360 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1362 * w32proc.c (sys_select): Accept and ignore one more argument.
1364 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1366 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1367 (pselect) [!MS_DOS]: Redirect to sys_select.
1369 * sysdep.c: Don't include dos.h and dosfns.h.
1371 * process.c (sys_select):
1372 * msdos.c (sys_select): Accept one more argument and ignore it.
1374 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1375 adapt data types and code to that.
1378 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1379 which clashes with the gnulib function of the same name.
1381 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1383 * font.c (font_style_to_value, font_style_symbolic)
1384 (font_prop_validate_style): Add type checks for values in
1387 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1389 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1392 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1394 * xdisp.c (try_window_id): Undo last change.
1396 * w32.c (getwd): Adjust commentary about startup_dir.
1397 (init_environment): Always call sys_access, even in non-MSVC
1398 builds. Don't chdir to the directory of the Emacs executable.
1399 This undoes code from 1997 which was justified by the need to
1400 "avoid conflicts when removing and renaming directories". But its
1401 downside was that every relative file name was being interpreted
1402 relative to the directory of the Emacs executable, which can never
1403 be TRT. In particular, it broke sys_access when called with
1404 relative file names.
1405 (sys_access): Map GetLastError to errno.
1407 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1409 * window.h (struct window): Change type of 'fringes_outside_margins'
1410 to bitfield. Fix comment. Adjust users accordingly.
1411 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1413 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1416 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1418 * gnutls.c (emacs_gnutls_handshake):
1419 Add QUIT to make the loop interruptible.
1421 2012-06-29 Glenn Morris <rgm@gnu.org>
1423 * charset.c (init_charset): Make lack of etc/charsets fatal.
1425 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1427 * editfns.c (region_limit): Fix type mismatch.
1429 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1431 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1432 undefined. Convert from xassert to eassert.
1433 * nsmenu.m: Convert from xassert to eassert.
1434 * nsterm.m: Likewise.
1436 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1438 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1440 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1442 Avoid integer overflow on scroll-left and scroll-right.
1443 * window.c (HSCROLL_MAX): New macro.
1444 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1445 overflow when requested scroll falls outside ptrdiff_t range.
1447 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1449 * window.h (struct window): Change type of 'hscroll',
1450 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1451 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1452 Adjust users accordingly.
1453 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1454 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1455 from EMACS_INT to ptrdiff_t.
1456 (make_window): Omit redundant initialization.
1458 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1460 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1462 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1464 * window.h (struct window): Change type of 'use_time' and
1465 'sequence_number' from Lisp_Object to int.
1466 * frame.c (make_frame): Adjust users accordingly.
1467 * print.c (print_object): Likewise.
1468 * window.c (select_window, Fwindow_use_time, make_parent_window)
1469 (make_window): Likewise.
1471 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1473 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1474 enabled with --enable-checking=[all,glyphs] configure option.
1475 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1476 adjust comments accordingly.
1477 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1478 undefined, adjust comments accordingly.
1479 * image.c: Likewise.
1480 * scroll.c: Likewise.
1481 * w32fns.c: Likewise.
1482 * w32term.c: Likewise.
1483 * xdisp.c: Likewise.
1484 * xfaces.c: Likewise.
1486 * xterm.c: Likewise.
1488 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1490 Generalize run-time debugging checks.
1491 * dispextern.h (XASSERTS): Remove.
1492 * fontset.c (xassert): Remove.
1493 Convert from xassert to eassert.
1494 * alloc.c: Convert from xassert to eassert.
1496 * dispnew.c: Likewise.
1498 * fringe.c: Likewise.
1499 * ftfont.c: Likewise.
1500 * gtkutil.c: Likewise.
1501 * image.c: Likewise.
1502 * keyboard.c: Likewise.
1504 * process.c: Likewise.
1505 * scroll.c: Likewise.
1506 * sound.c: Likewise.
1508 * w32console.c: Likewise.
1509 * w32fns.c: Likewise.
1510 * w32term.c: Likewise.
1511 * window.c: Likewise.
1512 * xdisp.c: Likewise.
1513 * xfaces.c: Likewise.
1515 * xselect.c: Likewise.
1516 * xterm.c: Likewise.
1518 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1520 * fns.c (maybe_resize_hash_table): Output message when growing the
1523 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1525 * alloc.c (allocate_string_data): Remove dead code.
1526 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1527 avoid GCC warning about unused macro.
1529 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1531 * alloc.c (allocate_string): Omit intervals initialization.
1532 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1533 as in make_pure_string and make_pure_c_string.
1535 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1537 * alloc.c (allocate_string): Fix last change.
1539 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1541 * alloc.c (allocate_string): Remove two redundant calls
1542 to memset, add explicit initialization where appropriate.
1544 2012-06-27 Glenn Morris <rgm@gnu.org>
1546 * lisp.mk (lisp): Remove paths.elc.
1548 2012-06-27 Chong Yidong <cyd@gnu.org>
1550 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1552 2012-06-26 John Wiegley <johnw@newartisans.com>
1554 * unexmacosx.c (copy_data_segment): Add two section names used
1555 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1557 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1558 when building with Clang.
1560 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1562 * eval.c (Fapply): Allow calling it with a single argument.
1564 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1566 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1567 _stricmp and _strnicmp.
1568 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1570 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1572 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1574 (allocate_process): Likewise for new process.
1575 (allocate_terminal): Change to use offsetof.
1576 (allocate_frame): Likewise.
1577 * frame.c (make_frame): Omit redundant initialization.
1578 * window.c (make_parent_window): Use memset.
1579 (make_window): Omit redundant initialization.
1580 * process.c (make_process): Omit redundant initialization.
1581 * terminal.c (create_terminal): Likewise.
1583 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1585 * term.c (delete_tty): Remove redundant call to memset.
1587 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1589 * alloc.c: Remove build_string.
1590 * lisp.h: Define build_string as static inline. This provides
1591 a better opportunity to optimize away calls to strlen when the
1592 function is called with compile-time constant argument.
1593 * image.c (imagemagick_error): Convert to build_string.
1594 * w32proc.c (sys_spawnve): Likewise.
1595 * xterm.c (x_term_init): Likewise.
1597 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1599 Use sprintf return value instead of invoking strlen on result.
1600 In the old days this wasn't portable, since some sprintf
1601 implementations returned char *. But they died out years ago and
1602 Emacs already assumes sprintf returns int.
1603 Similarly for float_to_string.
1604 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1605 * ccl.c (ccl_driver):
1606 * character.c (string_escape_byte8):
1607 * data.c (Fnumber_to_string):
1608 * doprnt.c (doprnt):
1609 * print.c (print_object):
1610 * xdisp.c (message_dolog):
1611 * xfns.c (syms_of_xfns):
1612 Use sprintf or float_to_string result to avoid need to call strlen.
1613 * data.c (Fnumber_to_string):
1614 Use make_unibyte_string, since the string must be ASCII.
1615 * lisp.h, print.c (float_to_string): Now returns int length.
1616 * term.c (produce_glyphless_glyph):
1617 Use sprintf result rather than recomputing it.
1619 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1620 * Makefile.in (ALL_CFLAGS):
1621 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1622 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1624 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1626 * dispextern.h (xstrcasecmp): Define to library function
1627 strcasecmp if available.
1628 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1630 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1632 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1633 Avoid comma operator.
1634 * menu.c (push_submenu_start, push_submenu_end)
1635 (push_left_right_boundary, push_menu_pane): Likewise.
1636 * msdos.c (dos_rawgetc): Likewise.
1638 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1640 * xfns.c (xic_create_fontsetname): Remove redundant calls
1643 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1645 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1646 sprintf already null-terminates its output.
1648 * xfns.c (x_window): Remove redundant cast.
1650 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1652 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1653 `const char *' to `char *' to avoid compiler warning.
1655 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1657 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1658 instead of truncating it to 63 (admittedly a generous limit).
1660 * process.c: Fix spelling and caps in comments.
1662 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1664 * emacs.c (setpgrp): Remove definition, unused.
1665 * sysdep.c (setpgrp): Remove definition, not used in this file.
1667 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1669 * makefile.w32-in: Update dependencies.
1671 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1673 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1674 (SYSTIME_H): Add nt/inc/sys/time.h.
1676 * systime.h [WINDOWSNT]: Include sys/time.h.
1678 * s/ms-w32.h (struct timespec): Definition moved from
1679 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1681 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1683 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1684 * buffer.h (buffer_slot_type_mismatch):
1685 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1686 * eval.c (unwind_to_catch):
1687 * image.c (my_png_error, my_error_exit):
1688 * keyboard.c (quit_throw_to_read_char, user_error)
1689 (Fexit_recursive_edit, Fabort_recursive_edit):
1690 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1691 (wrong_type_argument, buffer_overflow, __executable_start)
1692 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1693 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1694 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1696 (child_setup) [!DOS_NT]:
1697 * lread.c (end_of_file_error, invalid_syntax):
1698 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1699 * puresize.h (pure_write_error):
1700 * search.c (matcher_overflow):
1701 * sound.c (sound_perror, alsa_sound_perror):
1702 * sysdep.c, syssignal.h (croak):
1703 * term.c (maybe_fatal, vfatal):
1704 * textprop.c (text_read_only):
1705 * undo.c (user_error):
1706 * unexmacosx.c (unexec_error):
1707 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1708 Use _Noreturn rather than NO_RETURN.
1709 No need for separate decl merely because of _Noreturn.
1710 * sound.c (sound_warning, parse_sound):
1711 Remove unnecessary forward decls.
1713 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1715 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1716 * lisp.h (WAIT_READING_MAX): New macro.
1717 * dispnew.c (Fsleep_for, sit_for):
1718 * keyboard.c (kbd_buffer_get_event):
1719 * process.c (Faccept_process_output):
1720 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1721 This improves on the previous patch, which introduced a bug
1722 when time_t is unsigned and as wide as intmax_t.
1723 See <http://bugs.gnu.org/9000#51>.
1725 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1727 * dispnew.c (sit_for, Fsleep_for):
1728 * keyboard.c (kbd_buffer_get_event):
1729 * process.c (Faccept_process_output): Avoid compiler warnings when
1730 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1732 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1734 * makefile.w32-in: Update dependencies.
1736 * w32.c (ltime): Add return type and declare static.
1737 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1739 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1741 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1742 Privately reported by Herbert J. Skuhra.
1743 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1745 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1746 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1748 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1750 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1751 last argument of make_unibyte_string.
1753 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1754 language ID in the event parameters.
1756 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1757 event.code, not the obscure "character set ID".
1759 2012-06-23 Chong Yidong <cyd@gnu.org>
1761 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1763 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1765 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1766 * w32.c (fdutimens): New function.
1768 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1770 * s/ms-w32.h (pselect): Redirect to sys_select.
1772 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1774 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1775 in the logic of incrementing and decrementing the value of
1776 use_relocatable_buffers.
1778 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1780 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1781 Privately reported by Herbert J. Skuhra.
1782 [__FreeBSD__]: Remove "*/" typo after "#include".
1783 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1784 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1785 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1786 Don't assume EMACS_TIME and struct timeval are the same type.
1788 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1790 Support higher-resolution time stamps (Bug#9000).
1791 The time stamps are only nanosecond-resolution at the C level,
1792 since that's the best that any real-world system supports now.
1793 But they are picosecond-resolution at the Lisp level, as that's
1794 easy, and leaves room for future OS improvements.
1796 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1799 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1800 Don't get current time unless it's needed.
1802 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1803 now provides it if it's absent.
1804 (start_atimer): Port to higher-res time stamps.
1805 Check for time stamp overflow. Don't get current time more
1806 often than is needed.
1808 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1809 Include systime.h, not time.h.
1810 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1812 * dired.c: Include stat-time.h.
1813 (Ffile-attributes): File times now have higher resolution.
1815 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1816 (struct image): Timestamp now has higher resolution.
1818 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1819 has at least microseconds now. All uses removed.
1820 (update_frame, update_single_window, update_window, update_frame_1)
1821 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1823 * editfns.c (time_overflow): Now extern.
1824 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1825 (float-time, Fformat_time_string, Fcurrent_time_string)
1826 (Fcurrent_time_zone): Accept and generate higher-resolution
1828 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1829 (decode_time_components, lisp_seconds_argument): New functions.
1830 (make_time): Now static.
1831 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1832 Report an error if the time is invalid, rather than having the caller
1835 * fileio.c: Include <stat-time.h>
1836 (Fcopy_file): Copy higher-resolution time stamps.
1837 Prefer to set the time stamp via a file descriptor if that works.
1838 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1839 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1840 (Fvisited_file_modtime, Fset_visited_file_modtime):
1841 Support higher-resolution time stamps.
1843 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1845 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1847 * image.c (prepare_image_for_display, clear_image_cache)
1848 (lookup_image): Port to higer-resolution time stamps.
1850 * keyboard.c (start_polling, bind_polling_period):
1851 Check for time stamp overflow.
1852 (read_char, kbd_buffer_get_event, timer_start_idle)
1853 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1854 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1855 Port to higher-resolution time stamps. Do not assume time_t is signed.
1856 (decode_timer): New function. Timers are now vectors of length 9,
1857 not 8, to accommodate the picosecond component.
1858 (timer_check_2): Use it.
1860 * nsterm.m (select_timeout, timeval_subtract): Remove.
1861 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1862 as they're a bit more accurate and handle overflow better.
1863 (ns_select): Change prototype to be compatible with pselect.
1864 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1865 * nsterm.h (ns_select): Adjust prototype.
1867 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1868 us-resolution time stamps.
1869 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1871 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1873 * lisp.h (time_overflow): New decl.
1874 (wait_reading_process_output): First arg is now intmax_t, not int,
1875 to accommodate larger waits.
1877 * process.h (struct Lisp_Process.read_output_delay):
1878 Now counts nanoseconds, not microseconds.
1879 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1881 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1882 (wait_reading_process_output):
1883 Port to ns-resolution time stamps.
1884 (Faccept_process_output, wait_reading_process_output):
1885 Check for time stamp overflow. Do not assume time_t is signed.
1886 (select_wrapper): Remove; we now use pselect.
1887 (Fprocess_attributes): Now generates ns-resolution time stamps.
1889 * sysdep.c: Include utimens.h. Don't include utime.h
1890 or worry about struct utimbuf; gnulib does that for us now.
1891 (gettimeofday): Remove; gnulib provides a substitute.
1892 (make_timeval): New function.
1893 (set_file_times): Now sets ns-resolution time stamps.
1894 New arg FD; all uses changed.
1895 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1896 (system_process_attributes):
1897 Now returns ns-resolution time stamp. All uses changed.
1898 Check for time stamp overflow.
1900 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1901 provides a substitute now.
1903 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1904 since it guarantees struct timespec.
1905 (EMACS_TIME): Now struct timespec, so that we can support
1906 ns-resolution time stamps.
1907 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1908 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1909 (EMACS_USECS): Remove.
1910 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1911 so multiply the arg by 1000 before storing it.
1912 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1914 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1915 Port to ns-resolution time stamps.
1916 (EMACS_TIME_NEG_P): Remove; replaced by....
1917 (EMACS_TIME_SIGN): New macro.
1918 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1919 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1920 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1921 (make_timeval, make_lisp_time, decode_time_components): New decls.
1922 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1923 that it mishandled time_t overflow. You can't compare by subtracting!
1924 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1925 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1927 * term.c: Include <sys/time.h>.
1928 (timeval_to_Time): New function, for proper overflow wraparound.
1929 (term_mouse_position, term_mouse_click): Use it.
1931 * undo.c (record_first_change): Support higher-resolution time stamps
1933 (Fprimitive_undo): Use them when restoring time stamps.
1935 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1936 (w32_get_internal_run_time):
1937 Port to higher-resolution Emacs time stamps.
1938 (ltime): Now accepts single 64-bit integer, as that's more convenient
1941 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1943 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1944 for compatibility with pselect. Support ns-resolution time stamps.
1946 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1948 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1949 Check for time stamp overflow, and support ns-resolution time stamps.
1951 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1952 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1953 (timeval_subtract): Remove; no longer needed.
1954 (XTflash, XTring_bell, x_wait_for_event):
1955 Port to ns-resolution time stamps. Don't assume time_t is signed.
1957 2012-06-22 Chong Yidong <cyd@gnu.org>
1959 * xdisp.c (x_consider_frame_title): Revert last change.
1961 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1963 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1964 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1965 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1966 staticidx goes up to 1597 out of 1600 = 0x640.)
1968 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1970 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1971 Otherwise, the umask might be mistakenly 0 while handling input signals.
1973 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1975 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1977 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1979 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1980 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1981 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1982 access to `contents' member of Lisp_Vector objects with AREF and ASET
1985 2012-06-19 Chong Yidong <cyd@gnu.org>
1987 * frame.c (delete_frame): When selecting a frame on a different
1988 text terminal, do not alter the terminal's top-frame.
1990 * xdisp.c (format_mode_line_unwind_data): Record the target
1991 frame's selected window and its terminal's top-frame.
1992 (unwind_format_mode_line): Restore them.
1993 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1995 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1996 since tty frames can be explicitly named.
1997 (prepare_menu_bars): Likewise.
1999 * term.c (Ftty_top_frame): New function.
2001 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2003 Port byte-code-meter to modern targets.
2004 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2005 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2006 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2007 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2008 (METER_1, METER_2): Simplify.
2010 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2012 * data.c (Fdefalias): Return `symbol' (bug#11686).
2014 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2016 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2017 gets killed during executing of this function (Bug#11665).
2018 Try to always return Qt when the buffer has been actually killed.
2019 (Vkill_buffer_query_functions): In doc-string say that functions
2020 run by this hook should not change the current buffer.
2022 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2024 Fix recently-introduced process.c problems found by static checking.
2025 * process.c (write_queue_push, write_queue_pop, send_process):
2026 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2027 (write_queue_pop): Fix pointer signedness problem.
2028 (send_process): Remove unused local.
2030 2012-06-17 Chong Yidong <cyd@gnu.org>
2032 * xdisp.c (redisplay_internal): No need to redisplay terminal
2033 frames that are not on top.
2035 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2037 * process.c (make_process): Initialize write_queue.
2038 (write_queue_push, write_queue_pop): New functions.
2039 (send_process): Use them to maintain correct ordering of process
2042 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2044 * lisp.h (eassert): Assume C89 or later.
2045 This removes the need for CHECK.
2046 (CHECK): Remove. Its comments about always evaluating its
2047 argument were confusing, as 'eassert' typically does not evaluate
2050 * coding.c (produce_chars): Use ptrdiff_t, not int.
2052 * xterm.c (x_draw_underwave): Check for integer overflow.
2053 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2055 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2057 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2058 referenced (Bug#11583).
2060 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2062 Implement wave-style variant of underlining.
2063 * dispextern.h (face_underline_type): New enum.
2064 (face): Add field for underline type.
2065 * nsterm.m (ns_draw_underwave): New function.
2066 (ns_draw_text_decoration): Use it.
2067 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2069 (x_draw_glyph_string): Use them.
2070 * xfaces.c (Qline, Qwave): New Lisp objects.
2071 (check_lface_attrs, merge_face_ref)
2072 (Finternal_set_lisp_face_attribute, realize_x_face):
2073 Handle wave-style underline face attributes.
2074 * xterm.c (x_draw_underwave): New function.
2075 (x_draw_glyph_string): Use it.
2077 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2079 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2080 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2081 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2082 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2083 ($(BLD)/w32select.$(O)): Update dependencies.
2085 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2087 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2088 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2089 * character.c (_fetch_multibyte_char_p): Remove.
2090 * alloc.c: Include "character.h" before "buffer.h".
2092 * buffer.c: Likewise.
2093 * bytecode.c: Likewise.
2094 * callint.c: Likewise.
2095 * callproc.c: Likewise.
2096 * casefiddle.c: Likewise.
2097 * casetab.c: Likewise.
2098 * category.c: Likewise.
2100 * coding.c: Likewise.
2101 * composite.c: Likewise.
2102 * dired.c: Likewise.
2103 * dispnew.c: Likewise.
2105 * dosfns.c: Likewise.
2106 * editfns.c: Likewise.
2107 * emacs.c: Likewise.
2108 * fileio.c: Likewise.
2109 * filelock.c: Likewise.
2111 * fontset.c: Likewise.
2112 * fringe.c: Likewise.
2113 * indent.c: Likewise.
2114 * insdel.c: Likewise.
2115 * intervals.c: Likewise.
2116 * keyboard.c: Likewise.
2117 * keymap.c: Likewise.
2118 * lread.c: Likewise.
2119 * macros.c: Likewise.
2120 * marker.c: Likewise.
2121 * minibuf.c: Likewise.
2122 * nsfns.m: Likewise.
2123 * nsmenu.m: Likewise.
2124 * print.c: Likewise.
2125 * process.c: Likewise.
2126 * regex.c: Likewise.
2127 * region-cache.c: Likewise.
2128 * search.c: Likewise.
2129 * syntax.c: Likewise.
2131 * textprop.c: Likewise.
2133 * unexsol.c: Likewise.
2134 * w16select.c: Likewise.
2135 * w32fns.c: Likewise.
2136 * w32menu.c: Likewise.
2137 * window.c: Likewise.
2138 * xdisp.c: Likewise.
2140 * xmenu.c: Likewise.
2142 * xselect.c: Likewise.
2144 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2147 If all the glyphs of the glyph row came from strings, and we have no
2148 cursor positioning clues, put the cursor on the first glyph of the
2150 (handle_face_prop): Use chunk-relative overlay string index when
2151 indexing into it->string_overlays array. (Bug#11653)
2152 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2153 the rightmost. (Bug#11720)
2155 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2157 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2158 (CATEGORY_MEMBER): Enforce 1/0 value.
2159 * category.c (_temp_category_set): Remove.
2161 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2163 * window.c (Fdelete_other_windows_internal)
2164 (Fdelete_window_internal): Don't access frame's mouse highlight
2165 info of the initial frame. (Bug#11677)
2167 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2169 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2170 Assume USE_2_TAGS_FOR_INTS.
2171 (xreload): Adjust $tagmask width to match recent lisp.h change.
2173 Simplify lisp.h in minor ways that should not affect code.
2174 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2175 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2176 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2177 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2178 (INTTYPEBITS): New macro, for clarity.
2179 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2180 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2181 Simplify now that USE_LSB_TAG is always defined.
2182 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2183 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2185 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2187 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2189 2012-06-13 Glenn Morris <rgm@gnu.org>
2191 * s/bsd-common.h (BSD4_3):
2192 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2194 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2196 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2199 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2201 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2202 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2203 * alloc.c (widen_to_Lisp_Object): Remove.
2204 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2205 * frame.c (delete_frame): Remove outdated comment.
2206 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2207 USE_LISP_UNION_TYPE.
2208 (Fw32_unregister_hot_key): Likewise.
2209 (Fw32_toggle_lock_key): Likewise.
2210 * w32menu.c (add_menu_item): Likewise.
2211 (w32_menu_display_help): Use XIL instead of checking
2212 USE_LISP_UNION_TYPE.
2213 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2214 (init_heap): Likewise.
2215 * w32term.c (w32_read_socket): Update comment.
2217 2012-06-13 Glenn Morris <rgm@gnu.org>
2219 * s/usg5-4-common.h, src/s/unixware.h:
2220 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2222 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2224 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2226 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2227 * alloc.c (make_number) [!defined make_number]:
2228 Remove, as lisp.h always defines this now.
2229 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2230 (roundup_size): Verify that it is a power of 2.
2231 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2232 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2233 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2234 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2235 USE_LSB_TAG now is always defined to be either 0 or 1.
2237 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2238 code works fine either way, and efficiency is not a concern here,
2239 as the union type is for debugging, not for production.
2240 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2241 Use an inline function on all platforms when using the union type,
2242 since this is simpler and 'static inline' can be used portably
2244 (LISP_INITIALLY_ZERO): New macro.
2245 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2246 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2248 2012-06-12 Glenn Morris <rgm@gnu.org>
2250 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2252 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2254 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2255 Move BROKEN_SIGIO to configure.
2257 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2258 Move NO_TERMIO to configure.
2260 2012-06-12 Chong Yidong <cyd@gnu.org>
2262 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2263 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2264 MagickExportImagePixels is undefined.
2266 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2268 * image.c (imagemagick_load_image): Remove unused label.
2270 2012-06-11 Glenn Morris <rgm@gnu.org>
2272 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2273 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2274 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2275 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2277 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2279 * alloc.c (make_byte_code): New function.
2280 (Fmake_byte_code): Use it. Don't purify here.
2281 * lread.c (read1): Use it as well to avoid extra allocation.
2283 2012-06-11 Chong Yidong <cyd@gnu.org>
2285 * image.c (imagemagick_load_image): Implement transparency.
2287 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2289 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2290 account for preceding backslashes. (Bug#11663)
2292 2012-06-09 Chong Yidong <cyd@gnu.org>
2294 * term.c: Support italics in capable terminals (Bug#9652).
2295 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2296 (turn_on_face): Output using TS_enter_italic_mode if available.
2297 Don't handle unused blinking and alt-charset cases.
2298 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2299 and tty_alt_charset_p cases.
2300 (tty_capable_p, init_tty): Support italics.
2302 * termchar.h (struct tty_display_info): Add field for italics.
2303 Remove unused blink field.
2305 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2308 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2309 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2310 tty_alt_charset_p. Add tty_italic_p.
2312 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2314 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2315 dbus_type_is_basic if available.
2316 (xd_extract_signed, xd_extract_unsigned): Rename from
2317 extract_signed and extract_unsigned, respectively. Adapt callers.
2319 2012-06-09 Chong Yidong <cyd@gnu.org>
2321 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2323 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2326 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2328 * xdisp.c (vmessage): Treat frame message as multibyte.
2329 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2330 would generate the diagnostic "Making \302\247 buffer-local while
2333 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2335 * dispnew.c (showing_window_margins_p): Undo last change, which
2336 was done due to an inadvertent commit.
2337 (adjust_frame_glyphs_for_frame_redisplay): Do call
2338 showing_window_margins_p.
2340 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2342 * eval.c (Fmake_var_non_special): New primitive.
2343 (syms_of_eval): Defsubr it.
2344 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2346 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2348 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2349 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2351 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2353 * alloc.c (allocate_vectorlike): Fix last change.
2355 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2357 Block-based vector allocation of small vectors.
2358 * lisp.h (struct vectorlike_header): New field `nbytes',
2359 adjust comment accordingly.
2360 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2361 to denote vector blocks. Adjust users (live_vector_p,
2362 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2363 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2364 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2365 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2366 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2367 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2368 (roundup_size): New constant.
2369 (struct vector_block): New data type.
2370 (vector_blocks, vector_free_lists, zero_vector): New variables.
2371 (all_vectors): Rename to `large_vectors'.
2372 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2373 (sweep_vectors): New functions.
2374 (allocate_vectorlike): Return `zero_vector' as the only vector of
2375 0 items. Allocate new vector from block if vector size is less than
2376 or equal to VBLOCK_BYTES_MAX.
2377 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2378 (init_alloc_once): Add call to init_vectors.
2380 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2382 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2384 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2386 * doprnt.c (doprnt): Truncate multibyte char correctly.
2387 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2388 would mishandle a string argument "Xc" if X was a multibyte
2389 character of length 2: it would truncate after X's first byte
2390 rather than including all of X.
2392 2012-06-06 Chong Yidong <cyd@gnu.org>
2394 * buffer.c (word_wrap): Doc fix.
2396 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2398 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2400 2012-06-03 Glenn Morris <rgm@gnu.org>
2402 * xdisp.c (tool-bar-style): Doc fix.
2404 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2406 * Makefile.in (PAXCTL): Define.
2407 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2408 binary via PaX flags if the paxctl utility is available.
2409 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2410 Restore PaX flags to their default. (Bug#11398)
2412 2012-06-03 Chong Yidong <cyd@gnu.org>
2414 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2417 2012-06-03 Chong Yidong <cyd@gnu.org>
2419 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2420 (note_mode_line_or_margin_highlight): If there is no help echo,
2421 use mode-line-default-help-echo. Handle the case where the mouse
2422 position is past the end of the mode line string.
2424 * buffer.c (buffer_local_value_1): New function, split from
2425 Fbuffer_local_value; can return Qunbound.
2426 (Fbuffer_local_value): Use it.
2427 (Vmode_line_format): Docstring tweaks.
2429 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2431 * sysdep.c (system_process_attributes): Improve comment.
2433 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2435 * keyboard.c: Export real-this-command to Elisp.
2436 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2437 and DEFVAR it. Update all users.
2439 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2441 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2443 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2444 Convert pctcpu and pctmem to Lisp float properly.
2445 Let the compiler fold better, as 100.0/0x8000 is exact.
2447 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2449 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2452 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2454 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2456 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2458 For a 'struct window', replace some Lisp_Object fields to
2459 bitfields where appropriate, remove unused fields.
2460 * window.h (struct window): Remove unused 'last_mark_x' and
2461 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2462 change it's type from Lisp_Object to bitfield.
2463 Change type of 'force_start', 'optional_new_start',
2464 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2465 fields from Lisp_Object to bitfield. Adjust users accordingly.
2467 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2469 Pacify gcc -Wdouble-precision when using Xaw.
2470 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2471 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2472 Use 'float' consistently, rather than 'float' in most places
2473 and 'double' in a couple of places.
2475 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (handle_stop): Detect whether we have overlay strings
2478 loaded by testing it->current.overlay_string_index to be
2479 non-negative, instead of checking whether n_overlay_strings is
2480 positive. (Bug#11587)
2482 2012-05-31 Chong Yidong <cyd@gnu.org>
2484 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2486 * doc.c (Fsubstitute_command_keys): Doc fix.
2488 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2490 * search.c (search_buffer): Remove calls to
2491 r_alloc_inhibit_buffer_relocation, as it is now called by
2492 maybe_unify_char, which was the cause of relocation of buffer text
2495 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2497 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2498 for the duration of call to load_charset, to avoid problems with
2499 callers of maybe_unify_char that access buffer text through C
2502 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2503 decrement the inhibition flag, instead of just setting or
2506 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2508 Remove obsolete '#define static' cruft.
2509 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2510 This #undef was "temporary" in 2000; it is no longer needed
2511 now that '#define static' has gone away.
2512 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2513 (gray_bitmap_bits): Remove; no longer needed.
2514 All uses replaced with definiens.
2515 * xterm.c: Include "bitmaps/gray.xbm".
2517 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2519 Clean up __executable_start, monstartup when --enable-profiling.
2520 The following changes affect the code only when profiling.
2521 * dispnew.c (__executable_start): Rename from safe_bcopy.
2522 Define only on platforms that need it.
2523 * emacs.c: Include <sys/gmon.h> when profiling.
2524 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2525 (__executable_start): Remove decl, since lisp.h does it now.
2526 (safe_bcopy): Remove decl; no longer has that name.
2527 (main): Coalesce #if into single bit of code, for simplicity.
2528 Cast pointers to uintptr_t, since standard libraries want integers
2530 * lisp.h (__executable_start): New decl.
2532 2012-05-31 Glenn Morris <rgm@gnu.org>
2534 * image.c (Fimagemagick_types): Doc fix.
2536 2012-05-30 Jim Meyering <meyering@redhat.com>
2538 * callproc.c (Fcall_process_region): Include directory component
2539 in mkstemp error message (Bug#11586).
2541 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2543 * alloc.c, lisp.h (make_pure_vector): Now static.
2545 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2547 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2548 Move to byte-run.el.
2549 (Fautoload): Do the hash-doc more carefully.
2550 * data.c (Fdefalias): Purify definition, except for keymaps.
2551 (Qdefun): Move from eval.c.
2552 * lisp.h (Qdefun): Remove.
2553 * lread.c (read1): Tiny simplification.
2555 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2557 Do not create empty overlays with the evaporate property (Bug#9642).
2558 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2559 Bug#9642, but explicitly check that the buffer the overlay would
2560 be moved to is live and rearrange lines to make sure that errors
2561 will not put the overlay in an inconsistent state.
2562 (Fdelete_overlay): Cosmetics.
2564 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2566 * w32term.c (my_bring_window_to_top): New function.
2567 (x_raise_frame): Use handle returned by DeferWindowPos, which
2568 could be different from the original one.
2569 Call my_bring_window_to_top instead of my_set_foreground_window.
2572 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2573 by calling BringWindowToTop.
2575 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2576 (WM_EMACS_END): Increase by one.
2578 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2580 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2581 This avoids undefined behavior that might cause the eassert
2582 to not catch an out-of-range value.
2584 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2586 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2587 Update dependencies.
2589 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2591 * bidi.c (bidi_mirror_char): Fix last change.
2593 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2595 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2596 when referring to sectname field in printf format.
2598 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2600 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2601 Only r_alloc_inhibit_buffer_relocation needed to be added;
2602 the others were already declared.
2604 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2605 before checking whether it's out of range. Put the check inside
2607 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2609 2012-05-27 Ken Brown <kbrown@cornell.edu>
2611 * callproc.c (Fcall_process): Restore a line that was accidentally
2612 commented out in the 2011-02-13 change (bug#11547).
2614 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2616 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2617 defined on ralloc.c.
2619 * buffer.c [REL_ALLOC]: Remove prototypes of
2620 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2621 they are now on lisp.h.
2623 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2625 * search.c (search_buffer): Use it to inhibit relocation of buffer
2626 text while re_search_2 is doing its job, because re_search_2 is
2627 passed C pointers to buffer text. (Bug#11519)
2629 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2632 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2633 state after an additional call to move_it_in_display_line_to, keep
2634 the values of it->max_ascent and it->max_descent found for the
2636 (pos_visible_p): Revert the comparison against bottom_y to what it
2637 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2640 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2642 Fix coding-related core dumps with gcc -ftrapv.
2643 The code was computing A - B, where A and B are pointers, and B is
2644 random garbage. This can lead to core dumps on platforms that
2645 have special pointer registers, and it also leads to core dumps on
2646 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2647 A - B only when B is initialized properly.
2648 * coding.c (coding_set_source, coding_set_destination): Return void.
2649 (coding_change_source, coding_change_destinations): New functions,
2650 with the old behaviors of coding_set_source and coding_set_destination.
2651 All callers that need an offset changed to use these new functions.
2653 2012-05-26 Glenn Morris <rgm@gnu.org>
2655 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2657 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2659 Extend mouse support on W32 text-mode console.
2660 * xdisp.c (draw_row_with_mouse_face):
2661 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2663 * w32console.c: Include window.h.
2664 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2666 (initialize_w32_display): Initialize mouse-highlight data.
2668 * w32inevt.c: Include termchar.h and window.h.
2669 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2670 moves, call note_mouse_highlight. If help_echo changed, call
2671 gen_help_event to produce help-echo message in the echo area.
2672 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2675 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2677 * lread.c (read1): Simplify slightly to avoid an overflow warning
2678 with GCC 4.7.0 on x86-64.
2680 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2682 * bidi.c (bidi_mirror_char): Revert last change: an int is
2683 definitely wide enough here.
2685 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2687 Fix integer width and related bugs (Bug#9874).
2688 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2689 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2690 (string_bytes, check_sblock, allocate_string_data):
2691 (compact_small_strings, Fmake_bool_vector, make_string)
2692 (make_unibyte_string, make_multibyte_string)
2693 (make_string_from_bytes, make_specified_string)
2694 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2695 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2698 (allocate_pseudovector):
2699 Use int, not EMACS_INT, where int is wide enough.
2700 (inhibit_garbage_collection, Fgarbage_collect):
2701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2702 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2703 int might not be wide enough.
2704 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2705 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2706 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2707 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2708 (bidi_level_of_next_char, bidi_move_to_visually_next):
2709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2710 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2711 (Fkill_buffer, Fset_buffer_major_mode)
2712 (advance_to_char_boundary, Fbuffer_swap_text)
2713 (Fset_buffer_multibyte, overlays_at, overlays_in)
2714 (overlay_touches_p, struct sortvec, record_overlay_string)
2715 (overlay_strings, recenter_overlay_lists)
2716 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2717 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2718 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2719 (Foverlay_recenter, last_overlay_modification_hooks_used)
2720 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2722 (validate_region): Omit unnecessary test for b <= e,
2723 since that's guaranteed by the previous test.
2724 (adjust_overlays_for_delete): Avoid pos + length overflow.
2725 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2726 (report_overlay_modification):
2727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2728 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2729 Omit pointer cast, which isn't needed anyway, and doesn't work
2730 after the EMACS_INT -> ptrdiff_t change.
2731 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2732 * buffer.h: Adjust decls to match defn changes elsewhere.
2733 (struct buffer_text, struct buffer):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 Use EMACS_INT, not int, where int might not be wide enough.
2736 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2737 not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (exec_byte_code): Use tighter memory-full test, one that checks
2739 for alloca overflow. Don't compute the address of the object just
2740 before an array, as that's not portable. Use EMACS_INT, not
2741 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2742 * callint.c (Fcall_interactively):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 * callproc.c (call_process_kill, Fcall_process):
2745 Don't assume pid_t fits into an Emacs fixnum.
2746 (call_process_cleanup, Fcall_process, child_setup):
2747 Don't assume pid_t fits into int.
2748 (call_process_cleanup, Fcall_process, delete_temp_file)
2749 (Fcall_process_region):
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2751 (Fcall_process): Simplify handling of volatile integers.
2752 Use int, not EMACS_INT, where int will do.
2753 * casefiddle.c (casify_object, casify_region, operate_on_word)
2754 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2756 (casify_object): Avoid integer overflow when overallocating buffer.
2757 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2758 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2759 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2760 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2761 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2762 integers are now checked earlier. All uses replaced with XINT.
2764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2765 For CCL_MapSingle, check that content and value are in int range.
2766 (ccl_driver, Fregister_code_conversion_map):
2767 Check that Vcode_version_map_vector is a vector.
2768 (resolve_symbol_ccl_program): Check that vector header is in range.
2769 Always copy the vector, so that we can check its contents reliably
2770 now rather than having to recheck each instruction as it's being
2771 executed. Check that vector words fit in 'int'.
2772 (ccl_get_compiled_code, Fregister_ccl_program)
2773 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2774 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2775 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2776 contents are in range.
2777 (Fccl_execute_on_string): Check that status is in range.
2778 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2779 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2780 Accept and return EMACS_INT, not int, because callers can pass values
2782 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2783 (multibyte_chars_in_text, parse_str_as_multibyte)
2784 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2785 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2786 (string_escape_byte8, Fget_byte):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2789 avoid mishandling large integers.
2790 * character.h: Adjust decls to match defn changes elsewhere.
2791 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2792 (Ffind_charset_region):
2793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2794 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2795 (load_charset_map_from_vector, Fdefine_charset_internal):
2796 Don't assume fixnum fits in int.
2797 (load_charset_map_from_vector, Fmap_charset_chars):
2798 Remove now-unnecessary CHECK_NATNUMs.
2799 (Fdefine_charset_internal): Check ranges here, more carefully.
2800 Don't rely on undefined behavior with signed left shift overflow.
2801 Don't assume unsigned int fits into fixnum, or that fixnum fits
2802 into unsigned int. Don't require max_code to be a valid fixnum;
2803 that's not true for gb10830 4-byte on a 32-bit host. Allow
2804 invalid_code to be a cons, for the same reason. Require code_offset
2805 to be a character. Avoid int overflow if max_char is close
2807 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2808 this is intended anyway and avoids some undefined behavior.
2809 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2810 INDEX_TO_CODE_POINT, as that's what it expects.
2811 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2812 * charset.h (DECODE_CHAR): Return int, not unsigned;
2813 this is what was intended anyway, and it avoids undefined behavior.
2814 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2815 integer-overflow issues.
2816 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2817 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2818 where the argument is EMACS_INT, and this behavior is not intended.
2819 * chartab.c (Fmake_char_table, Fset_char_table_range)
2820 (uniprop_get_decoder, uniprop_get_encoder):
2821 Don't assume fixnum fits in int.
2822 * cmds.c (move_point): New function, that does the gist of
2823 Fforward_char and Fbackward_char, but does so while checking
2824 for integer overflow more accurately.
2825 (Fforward_char, Fbackward_char): Use it.
2826 (Fforward_line, Fend_of_line, internal_self_insert)
2827 (internal_self_insert):
2828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2829 Fix a FIXME, by checking for integer overflow when calculating
2830 target_clm and actual_clm.
2831 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2832 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2833 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2834 (coding_alloc_by_making_gap, alloc_destination)
2835 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2836 (encode_coding_utf_16, detect_coding_emacs_mule)
2837 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2838 (detect_coding_iso_2022, decode_coding_iso_2022)
2839 (encode_invocation_designation, encode_designation_at_bol)
2840 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2841 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2842 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2843 (encode_coding_ccl, encode_coding_raw_text)
2844 (detect_coding_charset, decode_coding_charset)
2845 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2846 (produce_composition, produce_charset, produce_annotation)
2847 (decode_coding, handle_composition_annotation)
2848 (handle_charset_annotation, consume_chars, decode_coding_gap)
2849 (decode_coding_object, encode_coding_object, detect_coding_system)
2850 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2851 (code_convert_region, code_convert_string)
2852 (Fdefine_coding_system_internal)
2853 (coding_set_source, coding_set_destination):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2856 (Fdefine_coding_system_internal):
2857 Don't assume fixnums fit in int.
2858 (decode_coding_gap, decode_coding_object, encode_coding_object)
2859 (Fread_coding_system, Fdetect_coding_region)
2860 (Funencodable_char_position, Fcheck_coding_systems_region)
2861 (get_translation, handle_composition_annotation, consume_chars):
2862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2863 (consume_chars): Rewrite to not calculate an address outside buffer.
2864 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2865 Don't access memory outside of the args array.
2866 (Fdefine_coding_system_internal): Check for charset-id overflow.
2867 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2868 result of ENCODE_CHAR.
2869 * coding.h: Adjust decls to match defn changes elsewhere.
2870 (struct coding_system):
2871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2872 * composite.c (get_composition_id, find_composition)
2873 (run_composition_function, update_compositions)
2874 (compose_text, composition_gstring_put_cache)
2875 (composition_gstring_p, composition_gstring_width)
2876 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2877 (composition_compute_stop_pos, composition_reseat_it)
2878 (composition_update_it, struct position_record)
2879 (find_automatic_composition, composition_adjust_point)
2880 (Fcomposition_get_gstring, Ffind_composition_internal):
2881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2882 (update_compositions):
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2884 * composite.h: Adjust decls to match defn changes elsewhere.
2885 (struct composition):
2886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2887 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2888 Do not attempt to compute the address of the object just before a
2889 buffer; this is not portable.
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2892 (Faset): Use int, not EMACS_INT, where int is wide enough.
2893 (Fstring_to_number): Don't assume fixnums fit in int.
2894 (Frem): Don't assume arg is nonnegative.
2895 * dbusbind.c (xd_append_arg): Check for integers out of range.
2896 (Fdbus_call_method): Don't overflow the timeout int.
2897 (extract_signed, extract_unsigned): New functions.
2898 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2899 (xd_get_connection_references): Return ptrdiff_t, not int.
2901 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2902 (xd_read_message_1):
2903 Use int, not unsigned, where the dbus API uses int.
2904 (Fdbus_message_internal): Don't overflow mtype.
2905 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2906 * dired.c (directory_files_internal, file_name_completion, scmp)
2907 (file_name_completion_stat):
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 (file_name_completion): Don't overflow matchcount.
2910 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2911 * dispextern.h: Adjust decls to match defn changes elsewhere.
2912 (struct text_pos, struct glyph, struct bidi_saved_info)
2913 (struct bidi_string_data, struct bidi_it, struct composition_it)
2915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2916 (struct display_pos, struct composition_it, struct it):
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 * dispnew.c (increment_matrix_positions)
2919 (increment_row_positions, mode_line_string)
2920 (marginal_area_string):
2921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2922 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2924 (duration_to_sec_usec): New function, to check for overflow better.
2925 (Fsleep_for, sit_for): Use it.
2926 * doc.c (get_doc_string, store_function_docstring):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 (get_doc_string, Fsnarf_documentation):
2929 Use int, not EMACS_INT, where int is wide enough.
2931 Use SAFE_ALLOCA, not alloca.
2932 Check for overflow when converting EMACS_INT to off_t.
2933 * doprnt.c (doprnt):
2934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2935 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2936 Don't assume uid_t fits into fixnum.
2937 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2938 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2939 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2940 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2941 (general_insert_function)
2942 (Finsert_char, make_buffer_string, make_buffer_string_both)
2943 (update_buffer_properties, Fbuffer_substring)
2944 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2945 (Fsubst_char_in_region, check_translation)
2946 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2947 (transpose_markers, Ftranspose_regions):
2948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2949 (clip_to_bounds): Move to lisp.h as an inline function).
2950 (Fconstrain_to_field): Don't assume integers are nonnegative.
2951 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2952 (Fsubst_char_in_region, Fsave_restriction):
2953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2954 (Femacs_pid): Don't assume pid_t fits into fixnum.
2955 (lo_time): Use int, not EMACS_INT, when int suffices.
2956 (lisp_time_argument): Check for usec out of range.
2957 (Fencode_time): Don't assume fixnum fits in int.
2958 (Fuser_login_name, Fuser_full_name): Signal an error
2959 if a uid argument is out of range, rather than relying on
2961 (Fformat_time_string): Remove now-unnecessary check.
2962 lisp_time_argument checks for out-of-range usec now.
2963 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2964 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2965 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2966 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2967 (init_cmdargs, Fdump_emacs):
2968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2969 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2970 the bottom (typically) 32 bits of the fixnum.
2971 * eval.c (specpdl_size, call_debugger):
2972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2973 (when_entered_debugger, Fbacktrace_debug):
2974 Don't assume fixnum can fit in int.
2975 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2976 the object just before a buffer; this is not portable.
2977 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2978 (grow_specpdl, unbind_to):
2979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2980 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2981 (grow_specpdl): Simplify allocation by using xpalloc.
2982 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2983 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2984 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2986 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2989 (Fcopy_file, non_regular_nbytes, read_non_regular)
2990 (Finsert_file_contents):
2991 Use int, not EMACS_INT, where int is wide enough.
2992 (READ_BUF_SIZE): Verify that it fits in int.
2993 (Finsert_file_contents): Check that counts are in proper range,
2994 rather than assuming fixnums fit into ptrdiff_t etc.
2995 Don't assume fixnums fit into int.
2996 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2997 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2998 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2999 (string_char_to_byte, string_byte_to_char)
3000 (string_make_multibyte, string_to_multibyte)
3001 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3002 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3003 (substring_both, Fdelete, internal_equal, Ffillarray)
3004 (Fclear_string, mapcar1)
3005 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3006 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3007 (larger_vector, make_hash_table, maybe_resize_hash_table)
3008 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3009 (Fmaphash, secure_hash):
3010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3011 (concat): Check for string index and length overflow.
3012 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3015 (larger_vector): New API (vec, incr_min, size_max) replaces old
3016 one (vec, new_size, init). This catches size overflow.
3017 INIT was removed because it was always Qnil.
3018 All callers changed.
3019 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3020 the upper bound on a hash table index size.
3021 (make_hash_table, maybe_resize_hash_table): Use it.
3022 (secure_hash): Computer start_byte and end_byte only after
3023 they're known to be in ptrdiff_t range.
3024 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3025 (Ffont_get_glyphs, Ffont_at):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3028 (Flist_fonts, Fopen_font):
3029 Don't assume fixnum can fit in int.
3030 (check_gstring): Don't assume index can fit in int.
3031 (font_match_p): Check that fixnum is a character, not a nonnegative
3032 fixnum, since the later code needs to stuff it into an int.
3033 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3034 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3035 conversion overflow issues.
3036 (Fopen_font): Check for integer out of range.
3037 (Ffont_get_glyphs): Don't assume index can fit in int.
3038 * font.h: Adjust decls to match defn changes elsewhere.
3039 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3041 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3042 printmax_t, where ptrdiff_t is wide enough.
3043 (Finternal_char_font):
3044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3045 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3046 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3047 (Fset_frame_position, x_set_frame_parameters)
3048 (x_set_line_spacing, x_set_border_width)
3049 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3050 Check that fixnums are in proper range for system types.
3051 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3053 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3054 Use SAFE_ALLOCA_LISP, not alloca.
3055 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3056 intptr_t is wide enough.
3057 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3058 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3059 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3060 Check for fixnum out of range.
3061 * ftfont.c (ftfont_list): Don't assume index fits in int.
3062 Check that fixnums are in proper range for system types.
3063 (ftfont_shape_by_flt):
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3067 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3068 Check that fixnums are in proper range for system types.
3069 * gnutls.h: Adjust decls to match defn changes elsewhere.
3070 * gtkutil.c (xg_dialog_run):
3071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3072 (update_frame_tool_bar):
3073 Check that fixnums are in proper range for system types.
3074 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3075 (lookup_image): Check that fixnums are in range for system types.
3076 * indent.c (last_known_column, last_known_column_point):
3077 (current_column_bol_cache):
3078 (skip_invisible, current_column, check_display_width):
3079 (check_display_width, scan_for_column, current_column_1)
3080 (Findent_to, Fcurrent_indentation, position_indentation)
3081 (indented_beyond_p, Fmove_to_column, compute_motion):
3082 (Fcompute_motion, Fvertical_motion):
3083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3084 (last_known_column_modified): Use EMACS_INT, not int.
3085 (check_display_width):
3087 Check that fixnums and floats are in proper range for system types.
3088 (compute_motion): Don't assume index or fixnum fits in int.
3089 (compute_motion, Fcompute_motion):
3090 Use int, not EMACS_INT, when it is wide enough.
3091 (vmotion): Omit local var start_hpos that is always 0; that way
3092 we don't need to worry about overflow in expressions involving it.
3093 * indent.h: Adjust decls to match defn changes elsewhere.
3095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3096 Use int, not EMACS_INT, where int is wide enough.
3097 Remove unused members ovstring_chars_done and tab_offset;
3099 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3100 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3101 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3102 (make_gap, copy_text, insert, insert_and_inherit)
3103 (insert_before_markers, insert_before_markers_and_inherit)
3104 (insert_1, count_combining_before, count_combining_after)
3105 (insert_1_both, insert_from_string)
3106 (insert_from_string_before_markers, insert_from_string_1)
3107 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3108 (adjust_after_replace, adjust_after_insert, replace_range)
3109 (replace_range_2, del_range, del_range_1, del_range_byte)
3110 (del_range_both, del_range_2, modify_region)
3111 (prepare_to_modify_buffer, signal_before_change)
3112 (signal_after_change, Fcombine_after_change_execute):
3113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3114 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3115 (balance_an_interval, split_interval_right, split_interval_left)
3116 (find_interval, next_interval, update_interval)
3117 (adjust_intervals_for_insertion, delete_node, delete_interval)
3118 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3119 (static_offset_intervals, offset_intervals)
3120 (merge_interval_right, merge_interval_left, make_new_interval)
3121 (graft_intervals_into_buffer, temp_set_point_both)
3122 (temp_set_point, set_point, adjust_for_invis_intang)
3123 (set_point_both, move_if_not_intangible, get_property_and_range)
3124 (get_local_map, copy_intervals, copy_intervals_to_string)
3125 (compare_string_intervals, set_intervals_multibyte_1):
3126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3127 * intervals.h: Adjust decls to match defn changes elsewhere.
3129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3130 * keyboard.c (this_command_key_count, this_single_command_key_start)
3131 (before_command_key_count, before_command_echo_length, echo_now)
3132 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3133 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3134 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3135 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3137 (last_non_minibuf_size, last_point_position, echo_truncate)
3138 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3139 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3140 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3141 (stuff_buffered_input):
3142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3143 (last_auto_save, command_loop_1, read_char):
3144 Use EMACS_INT, not int, to avoid integer overflow.
3145 (record_char): Avoid overflow in total_keys computation.
3146 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3147 * keyboard.h: Adjust decls to match defn changes elsewhere.
3148 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3149 (Fkey_description, Fdescribe_vector, Flookup_key):
3150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3151 (click_position): New function, to check that positions are in range.
3152 (Fcurrent_active_maps):
3154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3155 (Faccessible_keymaps, Fkey_description):
3156 (preferred_sequence_p):
3157 Don't assume fixnum can fit into int.
3158 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3159 Check for integer overflow in size calculations.
3160 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3161 avoid mishandling large integers.
3162 * lisp.h: Adjust decls to match defn changes elsewhere.
3163 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3164 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3165 (struct Lisp_Marker):
3166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3167 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3168 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3169 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3170 All callers changed.
3171 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3172 Assume the arg has valid form, since it always does.
3173 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3174 unsigned integer system type.
3175 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3176 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3178 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3179 (duration_to_sec_usec): New decl.
3180 * lread.c (read_from_string_index, read_from_string_index_byte)
3181 (read_from_string_limit, readchar, unreadchar, openp)
3182 (read_internal_start, read1, oblookup):
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 (Fload, readevalloop, Feval_buffer, Feval_region):
3185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3186 (openp): Check for out-of-range argument to 'access'.
3187 (read1): Use int, not EMACS_INT, where int is wide enough.
3188 Don't assume fixnum fits into int.
3189 Fix off-by-one error that can read outside a buffer.
3190 (read_filtered_event): Use duration_to_sec_usec
3191 to do proper overflow checking on durations.
3192 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3193 in size calculation.
3194 (Fexecute_kbd_macro):
3195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3196 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3197 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3198 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3199 (set_marker_both, set_marker_restricted_both, marker_position)
3200 (marker_byte_position, Fbuffer_has_markers_at):
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3203 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3204 It now merely ensures that the menu is large enough, without
3205 necessarily growing it, as this avoids some integer overflow issues.
3206 All callers changed.
3207 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3209 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3210 Use SAFE_ALLOCA_LISP, not alloca.
3211 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3212 to EMACS_INT. Check that fixnums are in proper range for system types.
3213 * minibuf.c (minibuf_prompt_width, string_to_object)
3214 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3215 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3217 (get_minibuffer, read_minibuf_unwind):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3220 this simplifies overflow checking. All callers changed.
3221 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3224 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3225 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3226 Check that fixnums are in proper range for system types.
3227 (Fx_create_frame, Fx_show_tip):
3228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3229 * nsfont.m (ns_findfonts, nsfont_list_family):
3230 Don't assume fixnum fits in long.
3231 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3233 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3235 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3238 (PRINTDECLARE, PRINTPREPARE):
3239 (strout, print_string):
3240 (print, print_preprocess, print_check_string_charset_prop)
3242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3244 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3246 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3247 (printchar, strout): Use xpalloc to catch size calculation overflow.
3248 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3249 (print_error_message): Use SAFE_ALLOCA, not alloca.
3250 (print_object): Use int, not EMACS_INT, where int is wide enough.
3251 (print_depth, new_backquote_output, print_number_index):
3252 Use ptrdiff_t, not int, where int might not be wide enough.
3253 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3254 (Fset_process_window_size, Fformat_network_address)
3255 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3257 Check that fixnums are in proper range for system types.
3258 (Fsignal_process): Simplify by avoiding a goto.
3259 Check for process-ids out of pid_t range rather than relying on
3261 (process_tick, update_tick): Use EMACS_INT, not int.
3262 (Fformat_network_address, read_process_output, send_process)
3263 (Fprocess_send_region, status_notify):
3264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3265 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3266 (wait_reading_process_output, read_process_output, exec_sentinel):
3267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3268 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3269 (Faccept_process_output): Use duration_to_sec_usec to do proper
3270 overflow checking on durations.
3271 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3272 Don't assume pid_t fits in int.
3273 * process.h (struct Lisp_Process): Members tick and update_tick
3274 are now of type EMACS_INT, not int.
3275 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3276 configured --with-wide-int.
3277 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3278 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3279 * search.c (looking_at_1, string_match_1):
3280 (fast_string_match, fast_c_string_match_ignore_case)
3281 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3282 (scan_newline, find_before_next_newline, search_command)
3283 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3284 (set_search_regs, wordify):
3287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3288 (string_match_1, search_buffer, set_search_regs):
3290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3291 (wordify): Check for overflow in size calculation.
3292 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3293 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3294 Check that fixnums are in proper range for system types.
3295 * sound.c (struct sound_device)
3296 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3298 (Fplay_sound_internal):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 * syntax.c (struct lisp_parse_state, find_start_modiff)
3301 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3302 (Fparse_partial_sexp):
3303 Don't assume fixnums can fit in int.
3304 (struct lisp_parse_state, find_start_pos, find_start_value)
3305 (find_start_value_byte, find_start_begv)
3306 (update_syntax_table, char_quoted, dec_bytepos)
3307 (find_defun_start, prev_char_comend_first, back_comment):
3308 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3309 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3311 (Finternal_describe_syntax_value): Check that match_lisp is a
3312 character, not an integer, since the code stuffs it into int.
3313 (scan_words, scan_sexps_forward):
3314 Check that fixnums are in proper range for system types.
3316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3317 (scan_sexps_forward):
3318 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3319 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3320 * syntax.h: Adjust decls to match defn changes elsewhere.
3321 (struct gl_state_s):
3322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3323 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3324 MOST_POSITIVE_FIXNUM.
3325 * sysdep.c (wait_for_termination_1, wait_for_termination)
3326 (interruptible_wait_for_termination, mkdir):
3327 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3328 (emacs_read, emacs_write):
3329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3330 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3331 and double all fit in int.
3332 * term.c (set_tty_color_mode):
3333 Check that fixnums are in proper range for system types.
3334 * termhooks.h (struct input_event):
3335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3336 * textprop.c (validate_interval_range, interval_of)
3337 (Fadd_text_properties, set_text_properties_1)
3338 (Fremove_text_properties, Fremove_list_of_text_properties)
3339 (Ftext_property_any, Ftext_property_not_all)
3340 (copy_text_properties, text_property_list, extend_property_ranges)
3341 (verify_interval_modification):
3342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3343 (Fnext_single_char_property_change)
3344 (Fprevious_single_char_property_change):
3345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3346 (copy_text_properties):
3347 Check for integer overflow in index calculation.
3348 * undo.c (last_boundary_position, record_point, record_insert)
3349 (record_delete, record_marker_adjustment, record_change)
3350 (record_property_change):
3351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3352 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3354 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3355 (Fx_hide_tip, Fx_file_dialog):
3356 * w32menu.c (set_frame_menubar):
3357 Use ptrdiff_t, not int, for consistency with rest of code.
3358 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3359 (select_window, Fdelete_other_windows_internal)
3360 (window_scroll_pixel_based, window_scroll_line_based)
3361 (Frecenter, Fset_window_configuration):
3362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3363 (Fset_window_hscroll, run_window_configuration_change_hook)
3364 (set_window_buffer, temp_output_buffer_show, scroll_command)
3365 (Fscroll_other_window, Frecenter):
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3367 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3368 Don't assume fixnum fits in int.
3369 (Fset_window_scroll_bars):
3370 Check that fixnums are in proper range for system types.
3371 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3372 (string_pos, c_string_pos, number_of_chars, init_iterator)
3373 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3374 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3375 (compute_display_string_end, handle_face_prop)
3376 (face_before_or_after_it_pos, handle_invisible_prop)
3377 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3378 (display_prop_intangible_p, string_buffer_position_lim)
3379 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3380 (get_overlay_strings_1, get_overlay_strings)
3381 (iterate_out_of_display_property, forward_to_next_line_start)
3382 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3383 (get_next_display_element, set_iterator_to_next)
3384 (get_visually_first_element, compute_stop_pos_backwards)
3385 (handle_stop_backwards, next_element_from_buffer)
3386 (move_it_in_display_line_to, move_it_in_display_line)
3387 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3388 (add_to_log, message_dolog, message_log_check_duplicate)
3389 (message2, message2_nolog, message3, message3_nolog
3390 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3391 (current_message_1, truncate_echo_area, truncate_message_1)
3392 (set_message, set_message_1, store_mode_line_noprop)
3393 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3394 (text_outside_line_unchanged_p, check_point_in_composition)
3395 (reconsider_clip_changes)
3396 (redisplay_internal, set_cursor_from_row, try_scrolling)
3397 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3398 (redisplay_window, find_last_unchanged_at_beg_row)
3399 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3400 (trailing_whitespace_p, find_row_edges, display_line)
3401 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3402 (display_mode_element, store_mode_line_string)
3403 (pint2str, pint2hrstr, decode_mode_spec)
3404 (display_count_lines, display_string, draw_glyphs)
3405 (x_produce_glyphs, x_insert_glyphs)
3406 (rows_from_pos_range, mouse_face_from_buffer_pos)
3407 (fast_find_string_pos, mouse_face_from_string_pos)
3408 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (safe_call, init_from_display_pos, handle_fontified_prop)
3411 (handle_single_display_spec, load_overlay_strings)
3412 (with_echo_area_buffer, setup_echo_area_for_printing)
3413 (display_echo_area, echo_area_display)
3414 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3415 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3416 (redisplay_window, dump_glyph_row, display_mode_line)
3417 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3418 (handle_display_spec, display_prop_string_p):
3419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3420 (handle_single_display_spec, build_desired_tool_bar_string)
3421 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3422 (get_specified_cursor_type):
3423 Check that fixnums are in proper range for system types.
3424 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3425 (Flookup_image_map):
3426 Don't assume fixnums fit in int.
3427 (compare_overlay_entries):
3428 Avoid mishandling comparisons due to subtraction overflow.
3429 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3430 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3431 (handle_tool_bar_click):
3432 Use int, not unsigned, since we prefer signed and the signedness
3433 doesn't matter here.
3434 (get_next_display_element, next_element_from_display_vector):
3435 Use int, not EMACS_INT, when int is wide enough.
3436 (start_hourglass): Use duration_to_sec_usec to do proper
3437 overflow checking on durations.
3438 * xfaces.c (Fbitmap_spec_p):
3439 Check that fixnums are in proper range for system types.
3440 (compare_fonts_by_sort_order):
3441 Avoid mishandling comparisons due to subtraction overflow.
3442 (Fx_family_fonts, realize_basic_faces):
3443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3445 Don't assume fixnum fits in int.
3446 Use SAFE_ALLOCA_LISP, not alloca.
3447 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3448 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3449 (face_at_buffer_position, face_for_overlay_string)
3450 (face_at_string_position):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3453 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3455 Check that fixnums are in proper range for system types.
3456 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3457 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3459 (Fx_change_window_property): Don't assume fixnums fit in int.
3460 * xfont.c (xfont_chars_supported):
3461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3462 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3463 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3465 * xml.c (parse_region):
3466 * xrdb.c (magic_file_p):
3467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3468 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3469 (x_get_local_selection, x_reply_selection_request)
3470 (x_handle_selection_request, wait_for_property_change):
3471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3472 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3473 short is wide enough.
3474 (x_send_client_event): Don't assume fixnum fits in int.
3475 * xterm.c (x_x_to_emacs_modifiers):
3476 Don't assume EMACS_INT overflows nicely into int.
3477 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3479 (handle_one_xevent): NATNUMP can eval its arg twice.
3480 (x_connection_closed):
3481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3482 * xterm.h: Adjust decls to match defn changes elsewhere.
3483 (struct scroll_bar): Use struct vectorlike_header
3484 rather than rolling our own approximation.
3485 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3487 2012-05-25 Glenn Morris <rgm@gnu.org>
3489 * lisp.mk (lisp): Update for more files being compiled now.
3491 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3493 * lread.c: Remove `read_pure' which makes no difference.
3494 (read_pure): Remove var.
3495 (unreadpure): Remove function.
3496 (readevalloop): Don't call read_list with -1 flag.
3497 (read1, read_vector): Don't test read_pure any more.
3498 (read_list): Simplify.
3500 * fileio.c, character.h: Minor style tweaks.
3502 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3504 * window.h (clip_changed): Remove useless declaration.
3506 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3508 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3509 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3511 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3514 This directory predates autoconf and is no longer needed nowadays.
3515 Move its few remaining bits of functionality to where they're needed.
3516 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3517 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3518 * m/template.h: Remove.
3519 * Makefile.in (M_FILE): Remove. All uses removed.
3520 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3521 * lisp.h (USE_LSB_TAG):
3522 * mem-limits.h (EXCEEDS_LISP_PTR):
3523 Use VAL_MAX, not VALBITS, in #if.
3524 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3525 (EMACS_UINT): Define unconditionally now.
3526 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3527 (BITS_PER_EMACS_INT): New constants, replacing
3528 what used to be in config.h, but not useful in #if.
3529 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3530 define them any more.
3531 (VAL_MAX): New macro.
3533 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3534 BITS_PER_EMACS_INT, in #if.
3535 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3536 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3537 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3538 * s/ms-w32.h (DATA_START):
3539 Move here from removed file m/intel386.h.
3540 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3541 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3543 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3545 Assume C89 or later.
3546 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3547 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3549 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3550 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3551 * textprop.c, tparam.c (NULL): Remove.
3552 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3553 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3554 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3555 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3556 * xterm.c (input_signal_count): Assume volatile works.
3558 2012-05-21 Ken Brown <kbrown@cornell.edu>
3560 * xgselect.c (xg_select): Fix first argument in call to 'select'
3563 2012-05-20 Ken Brown <kbrown@cornell.edu>
3565 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3566 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3568 2012-05-19 Ken Brown <kbrown@cornell.edu>
3570 * xfns.c (x_in_use): Remove `static' qualifier.
3571 * xterm.h (x_in_use): Declare.
3572 * xgselect.c: Include xterm.h.
3573 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3574 and `display_arg' (bug#9754).
3576 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3578 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3580 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3581 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3583 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3585 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3587 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3588 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3590 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3591 reference to image_cache->refcount.
3592 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3594 2012-05-17 Juri Linkov <juri@jurta.org>
3596 * search.c (Fword_search_regexp, Fword_search_backward)
3597 (Fword_search_forward, Fword_search_backward_lax)
3598 (Fword_search_forward_lax): Move functions to isearch.el
3599 (bug#10145, bug#11381).
3601 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3603 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3605 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3607 * lread.c (init_obarray): Declare Qt and Qnil as special.
3609 2012-05-14 Glenn Morris <rgm@gnu.org>
3611 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3612 Put "libexec" before "bin", for the sake of init_callproc_1.
3614 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3616 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3618 * unexaix.c: Port to more-recent AIX compilers.
3619 (report_error, report_error_1, make_hdr, copy_sym)
3620 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3621 Make arguments const char *, not char *, to avoid violations of C
3622 standard and to fix some AIX warnings reported by Gilles Pion.
3624 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3626 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3627 already have overlays loaded.
3628 (handle_single_display_spec): Before returning without displaying
3629 fringe bitmap, synchronize the bidi iterator with the main display
3630 iterator, by calling iterate_out_of_display_property.
3631 (iterate_out_of_display_property): Detect buffer iteration by
3632 testing that it->string is a Lisp string.
3633 (get_next_display_element): When the current object is exhausted,
3634 and there's something on it->stack, call set_iterator_to_next to
3635 proceed with what's on the stack, instead of returning zero.
3636 (set_iterator_to_next): If called at the end of a Lisp string,
3637 proceed to consider_string_end without incrementing string
3638 position. Don't increment display vector index past the end of
3639 the display vector. (Bug#11417)
3640 (pos_visible_p): Don't report a position visible when move_it_to
3641 stopped at the last line of window, which happens to be scanned
3642 backwards by the bidi iteration. (Bug#11464)
3644 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3646 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3647 and right-margin display specs even if the spec is invalid or we
3648 are on a TTY, and thus unable to display on the fringes.
3649 That's because the text with the property will not be displayed anyway,
3650 so we need to signal to the caller that this is a "replacing"
3651 display spec. This fixes display when the spec is invalid or we
3654 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3656 * unexaix.c (make_hdr): Fix typo in prototype.
3657 This bug broke the build on AIX. Problem reported by Gilles Pion.
3659 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3661 * keyboard.c (kbd_buffer_get_event): Read special events also in
3662 batch mode. (Bug#11415)
3664 2012-05-12 Glenn Morris <rgm@gnu.org>
3666 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3668 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3670 * lisp.mk (lisp): Add newcomment.elc.
3672 2012-05-12 Glenn Morris <rgm@gnu.org>
3674 * Makefile.in (MKDIR_P): New, set by configure.
3675 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3677 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3679 Remove unused function hourglass_started.
3680 * dispextern.h (hourglass_started):
3681 * w32fns.c (hourglass_started):
3682 * xdisp.c (hourglass_started): Remove.
3684 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3686 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3687 Update dependencies.
3689 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3691 * xgselect.c (xg_select): Put maxfds+1 into a var.
3692 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3694 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3696 2012-05-10 Dave Abrahams <dave@boostpro.com>
3698 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3699 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3701 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3703 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3704 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3705 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3706 Initialize xd_registered_buses.
3708 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3710 Untag more efficiently if USE_LSB_TAG.
3711 This is based on a proposal by YAMAMOTO Mitsuharu in
3712 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3713 For an admittedly artificial (nth 8000 longlist) benchmark on
3714 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3715 Emacs's overall text size by 1%.
3716 * lisp.h (XUNTAG): New macro.
3717 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3718 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3719 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3720 * eval.c (Fautoload):
3721 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3722 * frame.h (XFRAME): Use XUNTAG.
3724 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3725 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3726 Remove unportable assumptions about print widths of types like
3728 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3729 intptr_t when converting between pointer and integer, to avoid GCC
3730 warnings about wrong width.
3732 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3734 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3735 stack for each reader_thread, instead of defaulting to 8MB
3736 determined by the linker. This avoids failures in creating
3737 subprocesses on Windows 7, see the discussion in this thread:
3738 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3740 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3742 Fix up display of the *Minibuf-0* buffer in the mini window.
3743 * keyboard.c (read_char): Don't clear the echo area if there's no
3745 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3746 contents of *Minibuf-0*) if there's no message displayed in its stead.
3748 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3750 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3753 2012-05-06 Chong Yidong <cyd@gnu.org>
3755 * lisp.mk (lisp): Update.
3757 2012-05-05 Jim Meyering <meyering@redhat.com>
3759 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3761 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3763 * data.c (PUT_ERROR): New macro.
3764 (syms_of_data): Use it. Add new error type `user-error'.
3765 * undo.c (user_error): New function.
3766 (Fprimitive_undo): Use it.
3767 * print.c (print_error_message): Adjust print style for `user-error'.
3768 * keyboard.c (user_error): New function.
3769 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3771 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3773 Do not limit current-time-string to years 1000..9999.
3774 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3775 (Fcurrent_time_string): Support any year that is supported by the
3776 underlying localtime representation. Don't use asctime, as it
3777 has undefined behavior for years outside the range -999..9999.
3779 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3781 Fix race conditions involving setenv, gmtime, localtime, asctime.
3782 Without this fix, interrupts could mess up code that uses these
3783 nonreentrant functions, since setting TZ invalidates existing
3784 tm_zone or tzname values, and since most of these functions return
3785 pointers to static storage.
3786 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3787 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3788 Grow the critical sections to include not just invoking
3789 localtime/gmtime, but also accessing these functions' results
3790 including their tm_zone values if any, and any related TZ setting.
3791 (format_time_string): Last arg is now struct tm *, not struct tm **,
3792 so that the struct tm is saved in the critical section.
3793 All callers changed. Simplify allocation of initial buffer, partly
3794 motivated by the fact that memory allocation needs to be outside
3795 the critical section.
3797 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3799 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3800 with RESET_INTERVAL.
3802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3803 Remove duplicated buffer name initialization.
3805 2012-05-02 Jim Meyering <jim@meyering.net>
3807 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3809 * xfns.c (x_window): Use xstrdup (Bug#11375).
3811 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3813 * xdisp.c (pos_visible_p): If already at a newline from the
3814 display string before the 'while' loop, don't walk back the glyphs
3815 from it3.glyph_row. Solves assertion violation when the display
3816 string begins with a newline (egg.el). (Bug#11367)
3818 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3820 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3823 2012-05-01 Glenn Morris <rgm@gnu.org>
3825 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3826 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3827 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3828 All were removed before 23.1.
3830 * dispnew.c: Remove HAVE_LIBNCURSES test;
3831 it is always true on relevant platforms.
3833 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3834 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3836 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3838 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3840 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3841 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3844 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3846 Do not avoid creating empty evaporating overlays (Bug#9642).
3847 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3848 That is, do not delete an evaporating overlay if it becomes
3849 empty after its bounds are adjusted to fit within its buffer.
3850 This fix caused other problems, and I'm reverting it until we get
3851 to the bottom of them.
3853 2012-04-27 Chong Yidong <cyd@gnu.org>
3855 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3857 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3859 * xdisp.c (pos_visible_p): If the window start position is beyond
3860 ZV, start the display from buffer beginning. Prevents assertion
3861 violation in init_iterator when the minibuffer window is scrolled
3864 * window.c (window_scroll_pixel_based): Likewise.
3866 2012-04-27 Chong Yidong <cyd@gnu.org>
3868 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3870 2012-04-27 Glenn Morris <rgm@gnu.org>
3872 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3873 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3875 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3877 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3878 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3880 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3882 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3883 display element, check also the underlying string or buffer
3884 character. (Bug#11341)
3886 * w32menu.c: Include w32heap.h.
3887 (add_menu_item): If the call to AppendMenuW (via
3888 unicode_append_menu) fails, disable Unicode menus only if we are
3889 running on Windows 9X/Me.
3891 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3893 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3894 (xgetint): Add missing shift for LSB tags.
3896 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3898 * keyboard.c (read_char): Don't wipe echo area for select window
3899 events: These might get delayed via `mouse-autoselect-window'
3902 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3904 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3905 manipulation of :loaded-from data.
3907 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3909 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3910 now a cons (bug#11311).
3912 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3914 Do not create empty overlays with the evaporate property (Bug#9642).
3915 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3916 if it becomes empty after its bounds are adjusted to fit within
3917 its buffer. Without this fix, in a nonempty buffer (let ((o
3918 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3919 yields an empty overlay that has the evaporate property, which is
3920 not supposed to happen.
3922 Fix minor GTK3 problems found by static checking.
3923 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3924 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3925 (struct _EmacsFixedClass, emacs_fixed_get_type):
3926 Move decls here from emacsgtkfixed.h, since they needn't be public.
3927 (emacs_fixed_get_type): Now static.
3928 (emacs_fixed_class_init): Omit unused local.
3929 (emacs_fixed_child_type): Remove; unused.
3930 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3931 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3932 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3933 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3934 (EMACS_FIXED_GET_CLASS): Remove; unused.
3935 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3937 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3938 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3940 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3942 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3943 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3944 (__malloc_size_t, __malloc_ptrdiff_t):
3945 Remove. All uses removed, replaced by the definiens if needed,
3946 since we can assume C89 or better now.
3947 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3948 (protect_malloc_state, align, get_contiguous_space)
3949 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3950 (malloc_atfork_handler_child, malloc_enable_thread)
3951 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3952 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3953 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3954 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3955 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3956 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3957 Define using prototypes, not old style.
3958 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3959 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3960 (align): Don't assume that signed integer overflow wraps around.
3961 Omit unused local var.
3962 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3963 (_free_internal_nolock, memalign, mallochook, reallochook):
3964 Omit no-longer-needed casts.
3965 (valloc): Use getpagesize, not __getpagesize.
3966 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3967 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3969 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3971 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3973 Move functions from C to Lisp. Make non-blocking method calls
3974 the default. Implement further D-Bus standard interfaces.
3976 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3977 (QCdbus_request_name_allow_replacement)
3978 (QCdbus_request_name_replace_existing)
3979 (QCdbus_request_name_do_not_queue)
3980 (QCdbus_request_name_reply_primary_owner)
3981 (QCdbus_request_name_reply_in_queue)
3982 (QCdbus_request_name_reply_exists)
3983 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3984 (QCdbus_registered_serial, QCdbus_registered_method)
3985 (QCdbus_registered_signal): New Lisp objects.
3986 (XD_DEBUG_MESSAGE): Use sizeof.
3987 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3988 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3989 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3990 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3991 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3992 (xd_signature, xd_append_arg): Allow float for integer types.
3993 (xd_get_connection_references): New function.
3994 (xd_get_connection_address): Rename from xd_initialize.
3995 Return cached address.
3996 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3997 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3999 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4000 Return number of refcounts.
4001 (Fdbus_get_unique_name): Make stronger parameter check.
4002 (Fdbus_message_internal): New defun.
4003 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4004 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4005 (Fdbus_send_signal, Fdbus_register_service)
4006 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4007 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4008 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4009 (Vdbus_compiled_version, Vdbus_runtime_version)
4010 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4011 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4012 (Vdbus_message_type_signal): New defvars.
4013 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4016 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4018 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4019 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4020 Do not assume ptrdiff_t is the same width as 'int'.
4022 * alloc.c: Handle unusual debugging option combinations.
4023 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4024 since the two debugging options are incompatible.
4025 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4027 (mem_init, mem_insert, mem_insert_fixup):
4028 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4029 (NEED_MEM_INSERT): Remove; no longer needed.
4031 2012-04-22 Leo Liu <sdl.web@gmail.com>
4033 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4035 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4037 * sysdep.c [__FreeBSD__]: Minor cleanups.
4038 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4039 Use Emacs indenting style more consistently. Avoid some casts.
4040 Use 'double' consistently rather than mixing 'float' and 'double'.
4042 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4044 * sysdep.c (list_system_processes, system_process_attributes):
4045 Add implementation for FreeBSD (Bug#5243).
4047 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4049 * lisp.mk (lisp): Update.
4051 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4053 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4054 It is never used otherwise.
4056 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4058 * print.c (print_preprocess): Only check print_depth if print-circle
4060 (print_object): Check for cycles even when print-circle is nil and
4061 print-gensym is t, but only check print_depth if print-circle is nil.
4063 2012-04-20 Chong Yidong <cyd@gnu.org>
4065 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4066 set the status to "failed" and ensure that sentinel is run.
4068 2012-04-20 Glenn Morris <rgm@gnu.org>
4070 * process.c (Fset_process_inherit_coding_system_flag)
4071 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4072 (Fmake_network_process, Fmake_serial_process): Doc fix.
4074 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4076 * xdisp.c (string_buffer_position_lim): Limit starting position to
4078 (set_cursor_from_row): If called for a mode-line or header-line
4079 row, return zero immediately.
4080 (try_cursor_movement): If inside continuation line, don't back up
4081 farther than the first row after the header line, if any.
4082 Don't consider the header-line row as "partially visible", even if
4083 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4085 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4087 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4090 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4091 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4093 configure: new option --enable-gcc-warnings (Bug#11207)
4094 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4095 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4096 (ALL_CFLAGS): Use new macros rather than old.
4097 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4098 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4099 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4100 -Wunused-result, -Wunused-variable. This should go away once
4101 the Emacs and Gnulib regex code is merged.
4102 (xmalloc, xrealloc): Now static.
4104 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4106 * dired.c (Fsystem_groups): Remove unused local.
4108 2012-04-17 Glenn Morris <rgm@gnu.org>
4110 * dired.c (Fsystem_users): Doc fix.
4112 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4114 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4115 (syms_of_dired): Add them.
4117 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4119 Fix minor alloc.c problems found by static checking.
4120 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4121 New extern decls, to avoid calling undeclared functions.
4122 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4123 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4124 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4125 (NEED_MEM_INSERT): New macro.
4126 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4127 Remove one incorrect comment and fix another.
4129 Fix minor ralloc.c problems found by static checking.
4130 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4131 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4132 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4133 (r_alloc_sbrk): Now static.
4135 Improve ralloc.c interface checking.
4136 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4137 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4138 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4139 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4140 [REL_ALLOC]: ... to here, to check interface.
4141 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4142 Remove decls. This fixes an "It stinks!".
4144 * alloc.c (which_symbols): Fix alignment issue / type clash.
4146 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4148 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4149 (struct Lisp_Misc_Any): Likewise.
4150 (struct Lisp_Free): Likewise.
4151 * alloc.c (union aligned_Lisp_Symbol): Define.
4152 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4153 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4154 (union aligned_Lisp_Misc): Define.
4155 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4156 aligned_Lisp_Misc instead of union Lisp_Misc.
4157 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4159 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4161 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4162 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4163 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4164 * s/netbsd.h, s/sol2-6.h:
4165 Remove definition of GC_MARK_STACK, since the default now works.
4166 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4167 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4168 no longer the default.
4169 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4171 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4173 * lread.c (lisp_file_lexically_bound_p):
4174 Fix hang at ";-*-\n" (bug#11238).
4176 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4178 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4179 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4181 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4183 * nsterm.m (constrainFrameRect): Always constrain when there is only
4184 one screen (Bug#10962).
4186 2012-04-13 Ken Brown <kbrown@cornell.edu>
4188 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4190 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4192 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4194 2012-04-11 Daniel Colascione <dancol@dancol.org>
4196 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4197 against is gone. It's better to use vfork now so that when Cygwin
4198 gains a new, working vfork, we use it automatically (bug#10398).
4200 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4202 * window.c (save_window_save): Obey window-point-insertion-type.
4204 2012-04-11 Glenn Morris <rgm@gnu.org>
4206 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4208 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4210 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4212 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4214 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4215 (force_quit_count): New var.
4216 (handle_interrupt): Use it.
4218 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4220 * w32.c (w32_delayed_load): Record the full path of the library
4221 being loaded (bug#10424).
4223 2012-04-09 Glenn Morris <rgm@gnu.org>
4225 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4226 not just in the obarray, before snarfing them. (Bug#11036)
4228 * Makefile.in ($(leimdir)/leim-list.el):
4229 Pass EMACS rather than BUILT_EMACS.
4231 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4233 * process.c (make_process):
4234 * process.h: Add integer `gnutls_handshakes_tried' member to
4237 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4238 Add convenience `GNUTLS_LOG2i' macro.
4240 * gnutls.c (gnutls_log_function2i): Convenience log function.
4241 (emacs_gnutls_read): Use new log functions,
4242 `gnutls_handshakes_tried' process member, and
4243 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4244 attempts per process (connection).
4246 2012-04-09 Chong Yidong <cyd@gnu.org>
4248 * eval.c (Fuser_variable_p, user_variable_p_eh)
4249 (lisp_indirect_variable): Functions deleted.
4250 (Fdefvar): Caller changed.
4252 * callint.c (Finteractive, Fcall_interactively):
4253 * minibuf.c (Fread_variable): Callers changed.
4255 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4257 * xdisp.c (set_cursor_from_row): If the display string appears in
4258 the buffer at position that is closer to point than the position
4259 after the display string, display the cursor on the first glyph of
4260 the display string. Fixes cursor display when a 'display' text
4261 property immediately follows invisible text. (Bug#11094)
4263 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4265 composite.c: use 'double' consistently
4266 * composite.c (get_composition_id): Use 'double' consistently
4267 instead of converting 'float' to 'double' and vice versa; this is
4268 easier to understand and avoids a GCC warning.
4270 2012-04-09 Glenn Morris <rgm@gnu.org>
4272 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4273 preparation for dumping it with emacs. (Bug#4789)
4274 (leimdir): New variable.
4275 ($(leimdir)/leim-list.el): New rule.
4276 (emacs$(EXEEXT)): Depend on leim-list.el.
4278 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4279 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4280 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4282 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4284 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4287 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4289 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4290 Remove unused local variable.
4292 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4294 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4295 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4296 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4297 objects, as mark_maybe_pointer will catch them otherwise.
4298 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4299 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4301 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4303 Fix typo that broke non-Windows builds.
4304 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4306 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4308 Support building on MS-Windows with libxml2.
4310 * makefile.w32-in (OBJ2): Add xml.$(O).
4311 (GLOBAL_SOURCES): Add xml.c.
4312 ($(BLD)/xml.$(O)): New dependency list.
4314 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4315 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4316 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4317 [!WINDOWSNT]: New macros.
4318 (init_libxml2_functions, libxml2_loaded_p): New functions.
4319 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4320 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4321 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4322 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4324 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4325 Call init_libxml2_functions before calling libxml2 functions.
4326 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4328 * emacs.c: Don't include libxml/parser.h.
4329 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4330 xmlCleanupParser directly.
4332 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4334 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4336 * indent.c (Fvertical_motion): If there is a display string at
4337 point, use it.vpos to compute how many lines to backtrack after
4338 move_it_to point. (Bug#11133)
4340 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4342 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4343 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4344 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4345 macros related to unification of CJK characters. For the details,
4346 see the discussion following the message here:
4347 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4349 2012-04-04 Chong Yidong <cyd@gnu.org>
4351 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4353 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4355 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4356 instead of alloca. (Bug#11138)
4358 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4360 * w32menu.c (is_simple_dialog): Properly check lisp types.
4363 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4365 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4366 position we get to after a call to move_it_to fails the
4367 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4368 only if we wind up in a string from display property. (Bug#11063)
4370 * window.c (Fdelete_other_windows_internal): Invalidate the row
4371 and column information about mouse highlight, so that redisplay
4372 restores it after reallocating the glyph matrices. (Bug#7464)
4374 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4375 string comes from a `display' text property, use the buffer
4376 position of that property as if we actually saw that position in
4378 (move_it_by_lines): Remove the assertion that
4379 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4380 violated when there's a before-string at the beginning of a line.
4383 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4385 * xdisp.c (append_space_for_newline): If the default face was
4386 remapped, use the remapped face for the appended newline.
4387 (extend_face_to_end_of_line): Use the remapped default face for
4388 extending the face to the end of the line.
4389 (display_line): Call extend_face_to_end_of_line when the default
4390 face was remapped. (Bug#11068)
4392 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4394 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4396 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4398 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4400 2012-03-27 Glenn Morris <rgm@gnu.org>
4402 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4405 2012-03-26 Kenichi Handa <handa@m17n.org>
4407 * dispextern.h (struct glyph): Fix previous change. Change the
4408 bit length of glyphless.ch to 25 (Bug#11082).
4410 2012-03-26 Chong Yidong <cyd@gnu.org>
4412 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4413 (command_loop_1): Use it; inhibit selection update for
4414 handle-select-window too (Bug#8996).
4416 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4418 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4420 2012-03-25 Kenichi Handa <handa@m17n.org>
4422 * dispextern.h (struct glyph): Change the bit length of
4423 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4425 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4427 * s/ms-w32.h (tzname): Include time.h before redirecting to
4428 _tzname. Fixes the MSVC build. (Bug#9960)
4430 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4432 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4435 * xterm.c (XTread_socket): Only modify handling_signal if
4436 !SYNC_INPUT. (Bug#11080)
4438 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4440 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4441 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4442 when fetching a multibyte character consumes more bytes than
4443 CHAR_BYTES returns, due to unification of CJK characters in
4444 string_char. (Bug#11073)
4446 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4448 * process.c (wait_reading_process_output): Handle pty disconnect
4449 by refraining from sending oneself a SIGCHLD (bug#10933).
4451 2012-03-22 Chong Yidong <cyd@gnu.org>
4453 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4455 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4456 Mark string as coming from a prefix property.
4457 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4458 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4460 2012-03-21 Chong Yidong <cyd@gnu.org>
4462 * xfaces.c (Vface_remapping_alist): Doc fix.
4464 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4466 * w32proc.c (Fw32_set_console_codepage)
4467 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4470 2012-03-20 Chong Yidong <cyd@gnu.org>
4472 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4473 to reflect default non-nil value of redisplay-dont-pause.
4475 2012-03-19 Kenichi Handa <handa@m17n.org>
4477 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4478 it fit in a valid range (Bug#11003).
4480 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4482 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4483 that is not from display property, accept the row as a "cursor
4484 row" if one of the string's character has a non-nil `cursor'
4485 property. Fixes cursor positioning when there are newlines in
4486 overlay strings, e.g. in icomplete.el. (Bug#11035)
4488 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4490 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4492 2012-03-12 Chong Yidong <cyd@gnu.org>
4494 * eval.c (inhibit_lisp_code): Rename from
4495 inhibit_window_configuration_change_hook; move from window.c.
4497 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4498 * window.c (run_window_configuration_change_hook)
4499 (syms_of_window): Callers changed.
4501 2012-03-11 Chong Yidong <cyd@gnu.org>
4503 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4505 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4507 2012-03-10 Chong Yidong <cyd@gnu.org>
4509 * frame.c (other_visible_frames): Don't assume the selected frame
4510 is visible (Bug#10955).
4512 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4514 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4516 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4518 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4519 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4522 2012-03-03 Glenn Morris <rgm@gnu.org>
4524 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4526 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4528 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4529 position past the first glyph_row that ends at ZV. (Bug#10902)
4530 (redisplay_window, next_element_from_string): Fix typos in
4532 (redisplay_window): Pass to move_it_vertically the margin in
4533 pixels, not in screen lines.
4535 2012-03-02 Glenn Morris <rgm@gnu.org>
4537 * buffer.c (buffer-list-update-hook): Doc fix.
4539 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4541 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4542 push_it before setting up the iterator for the first overlay
4543 string, even if we have an empty string loaded.
4544 (next_overlay_string): If there's an empty string on the iterator
4545 stack, pop the stack. (Bug#10903)
4547 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4549 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4550 Suggested by Stefan Monnier in
4551 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4552 * alloc.c (widen_to_Lisp_Object): New static function.
4553 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4554 and widening them to Lisp_Objects. This would work even if
4555 USE_LSB_TAG is defined and wide integers are used, which might
4556 happen in a future version of Emacs.
4558 2012-02-25 Chong Yidong <cyd@gnu.org>
4560 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4563 * xselect.c (Fx_selection_exists_p): Doc fix.
4564 (x_clipboard_manager_save_all): Print an informative message
4565 before saving to clipboard manager.
4567 2012-02-24 Chong Yidong <cyd@gnu.org>
4569 * keyboard.c (process_special_events): Handle all X selection
4570 requests in kbd_buffer, not just the next one (Bug#8869).
4572 2012-02-23 Chong Yidong <cyd@gnu.org>
4574 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4575 call when setting menu-bar-lines and tool-bar-lines parameters.
4576 (unwind_create_frame_1): New helper function.
4578 * window.c (inhibit_window_configuration_change_hook): New var.
4579 (run_window_configuration_change_hook): Obey it.
4580 (syms_of_window): Initialize it.
4582 2012-02-22 Chong Yidong <cyd@gnu.org>
4584 * xterm.c (x_draw_image_relief): Add missing type check for
4585 Vtool_bar_button_margin (Bug#10743).
4587 2012-02-21 Chong Yidong <cyd@gnu.org>
4589 * fileio.c (Vfile_name_handler_alist): Doc fix.
4591 * buffer.c (Fget_file_buffer): Protect against invalid file
4592 handler return value.
4594 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4596 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4597 when computing $valmask.
4599 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4600 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4601 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4602 It's useless in that case, and it can cause problems on hosts
4603 that allocate halves of EMACS_INT values separately.
4604 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4605 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4606 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4607 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4608 it avoids undefined behavior on hosts where shifting right by more
4609 than the word width has undefined behavior.
4611 2012-02-19 Chong Yidong <cyd@gnu.org>
4613 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4614 (Funhandled_file_name_directory, Ffile_name_as_directory)
4615 (Fdirectory_file_name, Fexpand_file_name)
4616 (Fsubstitute_in_file_name): Protect against invalid file handler
4617 return values (Bug#10845).
4619 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4621 * .gdbinit (pitx): Fix incorrect references to fields of the
4624 2012-02-17 Chong Yidong <cyd@gnu.org>
4626 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4628 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4630 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4631 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4633 2012-02-15 Chong Yidong <cyd@gnu.org>
4635 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4636 marked as special. Also, starting docstrings with * is obsolete.
4638 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4640 * gnutls.c (emacs_gnutls_write): Fix last change.
4642 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4644 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4647 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4649 * keymap.c (Fsingle_key_description): Handle char ranges.
4651 2012-02-12 Chong Yidong <cyd@gnu.org>
4653 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4654 as that creates a dangerous corner case.
4656 * window.c (Fdelete_window_internal): Invalidate the mouse
4657 highlight (Bug#9904).
4659 2012-02-12 Glenn Morris <rgm@gnu.org>
4661 * xselect.c (Fx_own_selection_internal)
4662 (Fx_get_selection_internal, Fx_disown_selection_internal)
4663 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4664 * nsselect.m (Fx_own_selection_internal)
4665 (Fx_disown_selection_internal, Fx_selection_exists_p)
4666 (Fx_selection_owner_p, Fx_get_selection_internal):
4667 Sync docs and argument specs with the xselect.c versions.
4669 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4671 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4673 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4675 * w32select.c (Fx_selection_exists_p): Sync doc string and
4676 argument list with xselect.c. (Bug#10783)
4678 * w16select.c (Fx_selection_exists_p): Sync doc string and
4679 argument list with xselect.c. (Bug#10783)
4681 2012-02-10 Glenn Morris <rgm@gnu.org>
4683 * fns.c (Fsecure_hash): Doc fix.
4685 2012-02-09 Kenichi Handa <handa@m17n.org>
4687 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4689 2012-02-07 Chong Yidong <cyd@gnu.org>
4691 * buffer.c (Fbuffer_local_variables)
4692 (buffer_lisp_local_variables): Handle unbound vars correctly;
4693 don't let Qunbound leak into Lisp.
4695 2012-02-07 Glenn Morris <rgm@gnu.org>
4697 * image.c (Fimagemagick_types): Doc fix.
4699 * image.c (imagemagick-render-type): Change it from a lisp object
4700 to an integer. Move the doc here from the lisp manual.
4701 Treat all values not equal to 0 the same.
4703 2012-02-06 Chong Yidong <cyd@gnu.org>
4705 * doc.c (store_function_docstring): Avoid applying docstring of
4706 alias to base function (Bug#2603).
4708 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4710 * .gdbinit (pp1, pv1): Remove redundant defines.
4713 2012-02-04 Chong Yidong <cyd@gnu.org>
4715 * nsterm.m: Declare a global (Bug#10694).
4717 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4719 * w32.c (get_emacs_configuration_options):
4720 Include --enable-checking, if specified, in the return value.
4722 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4724 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4725 after rounding frame sizes. (Bug#9723)
4727 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4729 * keyboard.c (adjust_point_for_property): Don't position point
4730 before BEGV. (Bug#10696)
4732 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4734 Handle overflow when computing char display width (Bug#9496).
4735 * character.c (char_width): Return EMACS_INT, not int.
4736 (char_width, c_string_width): Check for overflow when
4737 computing the width; this is possible now that individual
4738 characters can have unbounded width. Problem introduced
4739 by merge from Emacs 23 on 2012-01-19.
4741 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4743 * dbusbind.c (Fdbus_register_method): Mention the return value
4744 :ignore in the docstring.
4746 2012-02-02 Glenn Morris <rgm@gnu.org>
4748 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4750 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4751 Unconditionally set to t. (Bug#10673)
4752 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4753 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4754 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4756 2012-02-02 Kenichi Handa <handa@m17n.org>
4758 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4759 0, do not call append_composite_glyph.
4761 2012-02-02 Kenichi Handa <handa@m17n.org>
4763 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4765 (x_produce_glyphs): If the component of a composition is a null
4766 string, set it->pixel_width to 1 to avoid zero-width glyph.
4768 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4770 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4771 first 2 arguments are identical. This makes inserting large
4772 output from a subprocess an order of magnitude faster on
4773 MS-Windows, where all sbrk'ed memory is always contiguous.
4775 2012-01-31 Glenn Morris <rgm@gnu.org>
4777 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4778 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4779 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4781 2012-01-29 Glenn Morris <rgm@gnu.org>
4783 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4785 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4787 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4789 2012-01-28 Chong Yidong <cyd@gnu.org>
4791 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4793 2012-01-26 Chong Yidong <cyd@gnu.org>
4795 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4797 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4798 repeat counts (Bug#10507).
4800 2012-01-26 Glenn Morris <rgm@gnu.org>
4802 * lread.c (syms_of_lread): Doc fix.
4804 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4806 * coding.c (encode_designation_at_bol): Change return value to
4809 2012-01-25 Chong Yidong <cyd@gnu.org>
4811 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4813 2012-01-21 Chong Yidong <cyd@gnu.org>
4815 * floatfns.c (Fcopysign): Make the second argument non-optional,
4816 since nil is not allowed anyway.
4818 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4820 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4821 (send_process): Likewise.
4823 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4825 * window.c (save_window_save, Fcurrent_window_configuration)
4826 (Vwindow_persistent_parameters): Do not use Qstate.
4827 Rewrite doc-strings.
4829 2012-01-19 Kenichi Handa <handa@m17n.org>
4831 * character.c (char_width): New function.
4832 (Fchar_width, c_string_width, lisp_string_width):
4833 Use char_width (Bug#9496).
4835 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4837 * window.c (Vwindow_persistent_parameters): New variable.
4838 (Fset_window_configuration, save_window_save): Handle persistent
4841 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4843 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4844 thrashing the stack of the thread. (Bug#9087)
4846 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4848 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4850 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4852 * xdisp.c (rows_from_pos_range): Handle the case where the
4853 highlight ends on a newline. (Bug#10464)
4854 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4855 he end column for display of highlight that ends on a newline
4858 2012-01-11 Glenn Morris <rgm@gnu.org>
4860 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4861 from load-path also when installation-directory is nil. (Bug#10208)
4863 2012-01-10 Glenn Morris <rgm@gnu.org>
4865 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4867 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4868 Update template values to be closer to their typical values these days.
4870 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4872 * xdisp.c (rows_from_pos_range): Accept additional argument
4873 DISP_STRING, and accept any glyph in a row whose object is that
4874 string as eligible for mouse highlight. Fixes mouse highlight of
4875 display strings from overlays. (Bug#10464)
4877 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4879 emacs: fix an auto-save permissions race condition (Bug#10400)
4880 * fileio.c (auto_saving_dir_umask): New static var.
4881 (Fmake_directory_internal): Use it.
4882 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4883 creating the directory. The old code temporarily assigns
4884 too-generous permissions to the directory.
4885 (do_auto_save_eh): Clear it.
4886 (Fdo_auto_save): Catch all errors, not just file errors, so
4887 that the var is always cleared.
4889 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4891 * search.c (scan_buffer): Pass character positions to
4892 know_region_cache, not byte positions. (Bug#6540)
4894 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4896 * w32.c (sys_rename): Report EXDEV when rename of a directory
4897 fails because the target is on another logical disk. (Bug#10284)
4899 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4901 * xterm.c (x_embed_request_focus): New function.
4903 * xterm.h: Add prototype.
4905 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4907 2012-01-05 Glenn Morris <rgm@gnu.org>
4909 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4911 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4913 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4914 Load gnutls_transport_set_lowat only if GnuTLS version is below
4916 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4917 GnuTLS versions below 2.11.1.
4919 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4921 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4922 to the doc string advising against its use for altering the way
4923 windows are scrolled.
4925 2011-12-28 Kenichi Handa <handa@m17n.org>
4927 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4928 coding-system ASCII compatible only when it does not produce BOM
4929 on encoding (Bug#10383).
4931 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4933 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4935 (create_and_show_popup_menu): Always use menu_position_func for
4938 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4940 * callint.c (Fcall_interactively): Don't truncate prompt string.
4942 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4945 property that ends at ZV, so that the bidi iteration could be
4946 resumed from there (after widening). (Bug#10360)
4948 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4950 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4952 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4954 * nsterm.m (x_free_frame_resources):
4955 Release f->output_data.ns->miniimage.
4956 (ns_index_color): Fix indentation. Do not retain
4957 color_table->colors[i].
4959 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4962 * nsfns.m (x_set_background_color): Assign return value from
4963 ns_index_color to face-background instead of NSColor*.
4964 (ns_implicitly_set_icon_type): Fix indentation.
4965 Change assignment in for loop to comparison.
4967 * emacs.c (ns_pool): New variable.
4968 (main): Assign ns_pool.
4969 (Fkill_emacs): Call ns_release_autorelease_pool.
4971 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4972 autorelease fdesc, release fdAttrs and tdict.
4973 (ns_get_covering_families): Release charset.
4974 (ns_findfonts): Release NSFontDescriptor created with new.
4975 (ns_uni_to_glyphs): Fix indentation.
4976 (setString): Release attrStr before assigning new value.
4978 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4980 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4982 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4983 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4985 2011-12-18 David Reitter <reitter@cmu.edu>
4987 * nsterm.m (ns_term_init): Subscribe for notifications
4988 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4989 to method trackingNotification in EmacsMenu.
4991 * nsmenu.m (trackingMenu): New variable.
4992 (trackingNotification): New method (from Aquamacs).
4993 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4994 from Aquamacs (Bug#7030).
4996 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4998 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4999 (symbol_to_nsstring): Fix indentation.
5000 (ns_symbol_to_pb): New function.
5001 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5002 (Fns_rotate_cut_buffers_internal): Remove.
5003 (Fns_store_selection_internal): Rename from
5004 Fns_store_cut_buffer_internal.
5005 (ns_get_foreign_selection, Fx_own_selection_internal)
5006 (Fx_disown_selection_internal, Fx_selection_exists_p)
5007 (Fns_get_selection_internal, Fns_store_selection_internal):
5008 Use ns_symbol_to_pb and check if return value is nil.
5009 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5010 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5011 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5012 renamed to Sns_store_selection_internal.
5013 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5014 and remove this function.
5015 (ns_handle_selection_clear): Remove, never used.
5016 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5019 2011-12-17 Ken Brown <kbrown@cornell.edu>
5021 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5022 GID is unknown (Bug#10257).
5024 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5026 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5027 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5028 which caused a build failure on GNU/Linux IA-64. This problem was
5029 introduced by my 2011-10-07 patch.
5031 2011-12-15 Juri Linkov <juri@jurta.org>
5033 * image.c (imagemagick_error): New function. (Bug#10112)
5034 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5035 Use `imagemagick_error' where ImageMagick functions return
5037 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5040 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5042 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5043 fill background (Bug#8992).
5045 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5047 * window.c (Vwindow_combination_resize)
5048 (Vwindow_combination_limit): Use t instead of non-nil in
5050 (Vrecenter_redisplay): Add first sentence of doc-string on
5052 (Frecenter): Fix doc-string typo.
5054 2011-12-11 Kenichi Handa <handa@m17n.org>
5056 * coding.c (Funencodable_char_position): Pay attention to the
5057 buffer text relocation (Bug#9389).
5059 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5061 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5062 gtk_init (Bug#10100).
5064 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5066 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5067 IT->string is nil. (Bug#10263)
5069 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5071 * nsterm.h (x_free_frame_resources): Declare.
5073 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5074 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5076 * nsterm.h (ns_get_defaults_value): Declare.
5078 * nsterm.m (ns_default): Call ns_get_defaults_value.
5080 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5082 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5085 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5087 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5088 that where the value of an _OBJC_* symbol points to is in the .bss
5089 section (Bug#10240).
5091 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5093 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5094 after the loop to call ccl_driver at least once (Bug#8619).
5096 2011-12-08 Kenichi Handa <handa@m17n.org>
5098 * ftfont.c (get_adstyle_property): Fix previous change
5101 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5103 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5104 dirs from the default value of EMACSLOADPATH (bug#10208).
5106 2011-12-07 Glenn Morris <rgm@gnu.org>
5108 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5109 installation and source directories as well. (Bug#10208)
5111 2011-12-06 Chong Yidong <cyd@gnu.org>
5113 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5115 2011-12-06 Glenn Morris <rgm@gnu.org>
5117 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5118 as an error, not just -1. (Bug#10217)
5120 2011-12-05 Chong Yidong <cyd@gnu.org>
5122 * keyboard.c (process_special_events): New function.
5123 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5125 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5127 * coding.c (encode_designation_at_bol): Don't use uninitialized
5128 local variable (Bug#9318).
5130 2011-12-05 Kenichi Handa <handa@m17n.org>
5132 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5133 return Qnil (Bug#8046, Bug#10193).
5135 2011-12-05 Kenichi Handa <handa@m17n.org>
5137 * coding.c (encode_designation_at_bol): New args charbuf_end and
5138 dst. Return the number of produced bytes. Callers changed.
5139 (coding_set_source): Return how many bytes coding->source was
5141 (coding_set_destination): Return how many bytes
5142 coding->destination was relocated.
5143 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5144 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5146 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5148 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5149 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5152 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5154 The following changes are to fix Bug#9318.
5156 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5157 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5158 (encode_coding_iso_2022, encode_coding_sjis)
5159 (encode_coding_big5, encode_coding_charset): Use the above macros.
5161 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5163 * lisp.h (process_quit_flag): Fix external declaration.
5165 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5167 Don't macro-inline non-performance-critical code.
5168 * eval.c (process_quit_flag): New function.
5169 * lisp.h (QUIT): Use it.
5171 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5173 * nsfns.m (get_geometry_from_preferences): New function.
5174 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5176 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5178 * emacs.c (Qkill_emacs): Define.
5179 (syms_of_emacs): Initialize it.
5180 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5181 Qquit_flag to `kill-emacs' instead.
5182 (quit_throw_to_read_char): Add parameter `from_signal'.
5183 All callers changed. Call Fkill_emacs if requested and safe.
5184 * lisp.h (QUIT): Call Fkill_emacs if requested.
5186 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5188 * widget.c (update_wm_hints): Return if wmshell is null.
5189 (widget_update_wm_size_hints): New function.
5191 * widget.h (widget_update_wm_size_hints): Declare.
5193 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5194 widget_update_wm_size_hints (Bug#10104).
5196 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5198 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5199 before a newline, prepare the bidi iterator for consuming the
5200 newline, and keep the current paragraph direction. (Bug#10183)
5201 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5203 2011-12-02 Juri Linkov <juri@jurta.org>
5205 * search.c (Fword_search_regexp): New Lisp function created from
5206 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5207 (Fword_search_backward, Fword_search_forward)
5208 (Fword_search_backward_lax, Fword_search_forward_lax):
5209 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5210 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5212 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5214 * fileio.c (Finsert_file_contents): Move after-change-function call
5215 to before the "handled:" label, since all "goto handled" appear in
5216 cases where the *-change-functions have already been properly called
5219 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5221 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5222 waiting for input. (Bug#10169)
5224 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5226 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5227 verifies glyph row's hash code--we have just reallocated the
5228 glyphs, so their contents can be complete garbage. (Bug#10164)
5230 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5232 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5234 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5236 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5237 attributes are tested _before_ calling verify_row_hash, to protect
5238 against GCC re-ordering of the tests. (Bug#10164)
5240 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5242 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5244 * xterm.c (handle_one_xevent): Only set async_visible and friends
5245 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5246 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5247 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5249 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5251 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5252 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5253 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5254 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5255 All uses changed to use GCPRO1 etc.
5256 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5257 Revert to old implementation (i.e., before 2011-03-11).
5259 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5261 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5262 of scroll runs so as to avoid assigning disabled bogus rows and
5263 unnecessary graphics copy operations.
5265 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5267 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5268 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5269 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5270 (malloc, free, realloc, calloc): Redirect to e_* only when
5273 * lisp.h (GCTYPEBITS): Move before first use.
5274 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5275 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5276 this macro definition.
5278 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5281 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5283 * gtkutil.c (xg_create_frame_widgets):
5284 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5285 present with Gtk+ 2.0.
5287 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5289 * fileio.c (Finsert_file_contents): Undo previous change; see
5290 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5292 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5294 Rename locals to avoid shadowing.
5295 * fileio.c (Finsert_file_contents):
5296 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5297 * process.c (wait_reading_process_output):
5298 Rename inner 'proc' to 'p' to avoid shadowing.
5299 Indent for consistency with usual Emacs style.
5301 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5303 * xdisp.c (redisplay_window): If cursor row is not fully visible
5304 after recentering, and scroll-conservatively is set to a large
5305 number, scroll window by a few more lines to make the cursor fully
5306 visible and out of scroll-margin. (Bug#10105)
5307 (start_display): Don't move to the next line if the display should
5308 start at a newline that is part of a display vector or an overlay
5311 2011-11-24 Juri Linkov <juri@jurta.org>
5313 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5314 after the `MagickPingImage' call. (Bug#10112)
5316 2011-11-23 Chong Yidong <cyd@gnu.org>
5318 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5320 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5322 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5323 making another buffer current. (Bug#10114)
5325 2011-11-23 Glenn Morris <rgm@gnu.org>
5327 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5329 2011-11-23 Chong Yidong <cyd@gnu.org>
5331 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5332 using it (Bug#5984).
5334 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5336 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5337 and header-lines, as they don't have one computed for them.
5340 * .gdbinit (prow): Make displayed values more self-explaining.
5341 Add row's hash code.
5343 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5345 * process.c (wait_reading_process_output): Fix asynchrounous
5346 GnuTLS socket handling on some versions of the GnuTLS library.
5347 (wait_reading_process_output): Add comment and URL.
5349 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5351 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5353 2011-11-21 Chong Yidong <cyd@gnu.org>
5355 * window.c (Fnext_window, Fprevious_window): Doc fix.
5357 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5359 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5361 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5363 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5365 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5367 * window.c (Fset_window_combination_limit): Rename argument
5369 (Vwindow_combination_limit): Remove "status" from doc-string.
5371 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5373 * m/ibms390.h: Remove.
5374 * m/ibms390x.h: Don't include "ibms390.h".
5376 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5378 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5379 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5381 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5383 * casetab.c (Fset_case_table):
5384 * charset.c (Fcharset_after): Fix typos.
5386 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5388 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5389 Otherwise, valgrind does not work on some platforms.
5390 Problem reported by Andreas Schwab in
5391 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5392 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5393 is set, removing the need for VIRT_ADDRESS_VARIES.
5394 (PURE_P): Use a more-efficient implementation that needs just one
5395 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5396 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5397 to 4 (xorl, subq, cmpq, setbe).
5398 * alloc.c (pure): Always extern now, since that's the
5399 VIRT_ADDR_VARIES behavior.
5400 (PURE_POINTER_P): Use a single comparison, not two, for
5401 consistency with the new puresize.h.
5402 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5403 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5404 Remove VIRT_ADDR_VARIES no longer needed.
5406 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5408 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5409 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5410 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5411 behave as if the cursor position were at the window margin.
5413 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5414 and the cursor position is out of bounds, behave as if the cursor
5415 position were at the window margin. (Bug#10075)
5417 2011-11-18 Chong Yidong <cyd@gnu.org>
5419 * window.c (Fwindow_combination_limit): Make first argument
5420 non-optional, since it is meaningless for live windows like the
5423 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5425 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5427 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5429 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5430 (graft_intervals_into_buffer): Simplify.
5432 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5434 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5435 hash values of the two rows.
5436 (copy_row_except_pointers): Preserve the used[] arrays and the
5437 hash values of the two rows. (Bug#10035)
5438 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5440 * xdisp.c (row_hash): New function, body extracted from
5441 compute_line_metrics.
5442 (compute_line_metrics): Call row_hash, instead of computing the
5445 * dispnew.c (verify_row_hash): Call row_hash for computing the
5446 hash code of a row, instead of duplicating code from xdisp.c.
5448 * dispextern.h (row_hash): Add prototype.
5450 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5452 * frame.c (delete_frame): Don't delete the terminal when the last
5453 X frame is closed if emacs is built with GTK toolkit.
5455 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5457 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5459 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5461 * window.c (Vwindow_splits): Rename to
5462 Vwindow_combination_resize. Suggested by Juri Linkov.
5463 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5466 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5468 * nsfns.m (Fns_font_name):
5469 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5471 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5473 * window.h (window): Rename slot "nest" to "combination_limit".
5474 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5475 (Fset_window_nest): Rename to Fset_window_combination_limit.
5476 (Vwindow_nest): Rename to Vwindow_combination_limit.
5477 (recombine_windows, make_parent_window, make_window)
5478 (Fsplit_window_internal, saved_window)
5479 (Fset_window_configuration, save_window_save): Rename all
5480 occurrences of window_nest to window_combination_limit.
5482 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5484 * image.c (imagemagick_load_image): Fix typo.
5486 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5488 * xdisp.c (display_line): Move the call to
5489 highlight_trailing_whitespace before the call to
5490 compute_line_metrics, since the latter needs to see the final
5491 faces of all the glyphs to compute ROW's hash value.
5492 Fixes assertion violations in row_equal_p. (Bug#10035)
5494 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5496 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5497 just return (bug#10044).
5499 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5501 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5502 with user-defined heap size. Bump the default size of the temacs
5503 heap to 27MB, to avoid memory warning when running temacs.
5504 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5506 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5507 current_matrix and desired_matrix. (Bug#9990)
5508 (verify_row_hash) [XASSERTS]: New function.
5509 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5510 that the hash value of glyph rows is correct.
5512 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5514 * window.h (window): Remove splits slot.
5515 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5516 (Fdelete_other_windows_internal, make_parent_window)
5517 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5518 (Fset_window_configuration, save_window_save): Don't deal with
5519 split status of windows.
5520 (saved_window): Remove splits slot.
5521 (Vwindow_splits): Rewrite doc-string.
5523 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5525 * xfns.c (unwind_create_frame):
5526 * nsfns.m (unwind_create_frame):
5527 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5528 Vframe_list (Bug#9999).
5530 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5532 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5534 2011-11-11 Kenichi Handa <handa@m17n.org>
5536 * callproc.c (Fcall_process): Set the member dst_multibyte of
5539 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5541 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5542 avoid a crash (bug#9496).
5544 2011-11-09 Chong Yidong <cyd@gnu.org>
5546 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5547 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5549 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5551 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5553 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5555 Avoid some portability problems by eschewing 'extern inline' functions.
5556 The trivial performance wins aren't worth the portability hassles; see
5557 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5559 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5560 (window_box_width, window_box_left, window_box_left_offset)
5561 (window_box_right, window_box_right_offset): Undo previous change,
5562 by removing the "extern"s.
5563 * intervals.c (adjust_intervals_for_insertion)
5564 (adjust_intervals_for_deletion): Undo previous change,
5565 making these static again.
5566 (offset_intervals, temp_set_point_both, temp_set_point)
5567 (copy_intervals_to_string): No longer inline.
5568 * xdisp.c (window_text_bottom_y, window_box_width)
5569 (window_box_height, window_box_left_offset)
5570 (window_box_right_offset, window_box_left, window_box_right)
5571 (window_box): No longer inline.
5573 2011-11-08 Chong Yidong <cyd@gnu.org>
5575 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5576 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5577 Signal an error if not a live window.
5578 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5579 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5581 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5583 * lisp.h (syms_of_abbrev): Remove declaration.
5584 Reported by CHENG Gao <chenggao@royau.me>.
5586 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5588 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5589 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5590 of temacs in GUI mode.
5592 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5594 * window.h: Declare delete_all_child_windows instead of
5595 delete_all_subwindows.
5596 * window.c (Fwindow_nest, Fset_window_nest)
5597 (Fset_window_new_total, Fset_window_new_normal)
5598 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5599 (delete_all_subwindows): Rename to delete_all_child_windows.
5600 (Fdelete_other_windows_internal, Fset_window_configuration):
5601 Call delete_all_child_windows instead of delete_all_subwindows.
5602 * frame.c (delete_frame): Call delete_all_child_windows instead
5603 of delete_all_subwindows.
5605 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5607 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5608 This is also needed for porting to any host where GC_MARK_STACK is
5609 not GC_MAKE_GCPROS_NOOPS.
5610 (which_symbols): Use it.
5612 2011-11-07 Kenichi Handa <handa@m17n.org>
5614 * coding.c (coding_set_destination): Check coding->src_pos only
5615 when coding->src_object is a buffer (bug#9910).
5617 * process.c (send_process): Set the member src_multibyte of coding
5618 to 0 (bug#9911) when sending a unibyte text.
5620 * callproc.c (Fcall_process): Set the member src_multibyte of
5621 process_coding to 0 (bug#9912).
5623 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5625 * xmenu.c (cleanup_widget_value_tree): New function.
5626 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5627 calling free_menubar_widget_value_tree directly (Bug#9830).
5629 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5631 Fix some portability problems with 'inline'.
5632 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5633 (window_box_width, window_box_left, window_box_left_offset)
5634 (window_box_right, window_box_right_offset): Declare extern.
5635 Otherwise, these inline functions do not conform to C99 and
5636 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5637 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5638 * intervals.c (adjust_intervals_for_insertion)
5639 (adjust_intervals_for_deletion): Now extern, because otherwise the
5640 extern inline functions 'offset_intervals' couldn't refer to it.
5641 (static_offset_intervals): Remove.
5642 (offset_intervals): Rewrite using the old contents of
5643 static_offset_intervals. The old version didn't conform to C99
5644 because an extern inline function contained a reference to an
5645 identifier with static linkage.
5647 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5649 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5652 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5654 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5655 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5656 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5657 return Qleft_to_right.
5659 2011-11-06 Chong Yidong <cyd@gnu.org>
5661 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5662 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5663 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5664 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5665 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5666 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5667 (Fwindow_vscroll): Doc fix.
5668 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5669 argument, since it makes no sense to pass a live window and for
5670 consistency with window-child.
5672 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5674 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5677 2011-11-05 Jason Rumney <jasonr@gnu.org>
5679 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5680 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5682 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5683 bitwise arithmetic preventing use of unicode-sip and non-truetype
5686 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5688 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5691 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5692 initialization code to keep similarity to xfns.c after changes
5695 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5697 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5698 (unwind_create_frame): New function (Bug#9943).
5699 (Fx_create_frame): Restructure code to be more similar to the one in
5700 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5701 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5702 Move terminal->reference_count++ just before making the frame official
5705 * nsterm.m (x_free_frame_resources): New function.
5706 (x_destroy_window): Move code to x_free_frame_resources.
5708 * xfns.c (unwind_create_frame): Fix comment.
5709 (Fx_create_frame, x_create_tip_frame):
5710 Move terminal->reference_count++ just before making the frame
5711 official. Move initialization of image_cache_refcount and
5712 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5714 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5716 Support MSVC build with newer versions of Visual Studio.
5717 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5718 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5721 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5722 which are not supported by MSVC.
5723 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5724 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5726 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5728 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5730 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5732 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5734 Support MSVC build with newer versions of Visual Studio.
5735 * w32.c: Don't include w32api.h for MSVC.
5736 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5738 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5739 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5740 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5741 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5743 (alloca) [_MSC_VER]: Define to _alloca.
5745 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5747 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5749 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5751 * xdisp.c (note_mouse_highlight): If either of
5752 previous/next-single-property-change returns nil, treat that as
5753 the beginning or the end of the buffer. (Bug#9955)
5755 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5757 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5758 label is not null (Bug#9951).
5759 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5762 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5764 * window.c (Fwindow_body_size): Mention in the doc string that the
5765 return value is in frame's canonical units. (Bug#9949)
5767 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5769 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5771 * w32fns.c (unwind_create_frame): If needed, free the glyph
5772 matrices of the partially constructed frame. (Bug#9943)
5773 * xfns.c (unwind_create_frame): Likewise.
5775 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5777 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5778 Don't stop backward scan on the continuation glyph, even though
5779 its CHARPOS is positive.
5780 (mouse_face_from_buffer_pos, note_mouse_highlight):
5781 Rename cover_string to disp_string.
5783 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5785 * window.c (temp_output_buffer_show): Don't use
5786 Vtemp_buffer_show_specifiers.
5787 (Vtemp_buffer_show_specifiers): Remove unused variable.
5789 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5791 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5792 past the beginning of the current glyph matrix.
5794 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5796 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5797 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5798 HAVE_GTK3 (Bug#9869).
5800 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5801 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5803 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5805 * xterm.c: Declare x_handle_net_wm_state to return int.
5806 (handle_one_xevent): Check if we are iconified but don't have
5807 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5808 (get_current_wm_state): Return non-zero if not hidden,
5809 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5810 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5811 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5812 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5814 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5816 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5817 so that this new function doesn't get optimized away by a
5818 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5820 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5822 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5824 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5826 Fix the `xbytecode' command.
5827 * .gdbinit (xprintbytestr): New command.
5828 (xwhichsymbols): Rename from `which'; all callers changed.
5829 (xbytecode): Print the byte-code string as well.
5831 2011-10-29 Kim Storm <storm@cua.dk>
5833 * alloc.c (which_symbols): New function.
5835 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5837 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5840 2011-10-29 Glenn Morris <rgm@gnu.org>
5842 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5843 Not clear what it was for, and it causes various bugs. (Bug#9839)
5845 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5847 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5848 possible random value that matches one of those tested as
5849 condition to clear the mouse face.
5851 2011-10-28 Chong Yidong <cyd@gnu.org>
5853 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5855 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5857 * window.c (make_window): Initialize phys_cursor_on_p.
5859 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5861 * lisp.h (struct Lisp_Symbol): Update comments.
5863 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5865 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5867 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5869 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5870 <oslsachem@gmail.com> for helping to debug this.
5872 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5873 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5874 (g_b_init_get_glyph_outline_w): New static variables.
5875 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5876 (GetGlyphOutlineW_Proc): New typedefs.
5877 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5878 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5880 (w32font_open_internal, compute_metrics):
5881 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5882 instead of calling the "wide" APIs directly.
5884 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5886 * w32.h (syms_of_w32font): Add prototype.
5888 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5890 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5891 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5892 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5893 (Fmove_to_window_line): Doc fix.
5895 2011-10-27 Chong Yidong <cyd@gnu.org>
5897 * process.c (make_process): Set gnutls_state to NULL.
5899 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5900 non-NULL, regardless of GNUTLS_INITSTAGE.
5901 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5902 an error. Set process slots as soon as we allocate them.
5904 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5906 2011-10-27 Chong Yidong <cyd@gnu.org>
5908 * gnutls.c (emacs_gnutls_deinit): New function.
5909 Deallocate credentials structures as well as calling gnutls_deinit.
5910 (Fgnutls_deinit, Fgnutls_boot): Use it.
5912 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5913 (deactivate_process): Call emacs_gnutls_deinit.
5915 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5917 * image.c (x_create_x_image_and_pixmap):
5918 * w32.c (sys_rename, w32_delayed_load):
5919 * w32font.c (fill_in_logfont):
5920 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5922 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5924 * w32fns.c (w32_default_color_map): New function,
5925 extracted from Fw32_default_color_map.
5926 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5928 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5930 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5932 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5934 * keyboard.c (test_undefined): New function (bug#9751).
5935 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5937 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5939 * sysdep.c (init_sys_modes): Fix the check for the controlling
5940 terminal (Bug#6649).
5942 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5944 * dispextern.h (struct bidi_it): New member next_en_type.
5946 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5947 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5948 current character, check also for next_en_type being WEAK_EN.
5949 (bidi_resolve_weak): Don't enter the expensive loop if the current
5950 position is before next_en_pos. Record the bidi type of the first
5951 non-ET, non-BN character we find, in addition to its position.
5952 (bidi_level_of_next_char): Invalidate next_en_type when
5953 next_en_pos is over-stepped.
5955 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5957 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5958 * editfns.c: Rewrite current-time-zone so that it invokes
5959 the equivalent of (format-time-string "%Z") to get the time zone name.
5960 This fixes a bug when the time zone name contains characters that
5961 need converting from the system time locale to Emacs internal format.
5962 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5963 that patch fixed format-time-string to do the conversion, but
5964 I forgot to fix current-time-zone.
5965 (format_time_string): New function, containing most of
5966 what Fformat_time_string used to contain.
5967 (Fformat_time_string): Rewrite in terms of format_time_string.
5968 This doesn't change this function's behavior.
5969 (current-time-zone): Rewrite to use format_time_string.
5970 This fixes the bug reported by Michael Schierl in
5971 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5972 Jason Rumney's 2007-06-07 change worked around this bug, but
5974 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5976 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5978 * xdisp.c (start_display): If the character at POS is displayed
5979 via a display vector, reset IT->current.dpvec_index to zero.
5980 (try_window_reusing_current_matrix): If a line ends in a display
5981 vector or the next line starts in a display vector, continue
5982 redrawing the window even though the character position of
5983 start_row was reached.
5986 2011-10-18 Chong Yidong <cyd@gnu.org>
5988 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5989 with nobreak-char-display too.
5991 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5993 Fix part 3 of bug#9771.
5994 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5995 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5996 non-neutral characters if the current character is a paragraph
5997 separator (a.k.a. Newline). This avoids running the same
5998 expensive loop twice, once when we consume the preceding newline
5999 and the other time when the line actually needs to be displayed.
6000 Avoid the loop when we see neutrals on the base embedding level
6001 following a character whose directionality is the same as the
6002 paragraph's. This avoids running the expensive loop when a line
6003 ends in a long sequence of neutrals, like control characters.
6004 Add assertion against STRONG_AL type. Slightly rearrange code
6005 that determines the type of a neutral given the first non-neutral
6007 (bidi_level_of_next_char): Set next_en_pos to zero when
6008 invalidating its info.
6010 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6012 * xdisp.c (push_display_prop): Determine whether to record string
6013 or buffer position by IT->string, not by IT->method. Allow
6014 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6015 (move_it_vertically_backward): Don't look for character position
6016 immediately after the newline when in a continuation line.
6019 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6021 * window.c (coordinates_in_window): Rewrite and delabelize
6022 vertical border check. (Bug#5357) (Bug#9618)
6024 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6026 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6027 errors in XSetWindowBorder (bug#9310).
6029 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6031 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6032 avoid crash when xmalloc overrun checking is enabled.
6034 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6036 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6037 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6038 cursor motion with <left> and <right> arrow keys.
6040 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6041 some callers set that themselves.
6043 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6045 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6046 display string and the previous row comes from the same string and
6047 is empty. (Bug#9739) (Bug#9738)
6049 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6051 * doc.c (get_doc_string): Encode file name (bug#9735).
6053 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6055 * bidi.c (bidi_level_of_next_char):
6056 * xdisp.c (get_visually_first_element): Remove old incorrect
6057 comments regarding the Unicode Line Separator character.
6059 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6061 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6063 * alloc.c (Fgc_status): Do not access beyond zombies array
6064 boundary if nzombies > MAX_ZOMBIES.
6065 * alloc.c (dump_zombies): Add missing format specifier.
6067 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6069 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6070 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6072 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6073 Some packages use them to denote characters with modifiers.
6075 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6077 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6078 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6079 matching a pp-number. Rename parameter var to var1.
6081 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6083 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6085 2011-10-08 Glenn Morris <rgm@gnu.org>
6087 * callint.c (Fcall_interactively): Give a more explicit error for the
6088 'c' case with a non-character input. (Bug#8479)
6090 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6092 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6094 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6095 lines that are hscrolled on the left.
6097 * dispnew.c (buffer_posn_from_coords): Account for a possible
6098 presence of header-line. (Bug#4426)
6100 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6102 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6103 Don't advertise functionality which we discourage or doesn't work.
6105 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6107 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6108 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6109 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6110 this makes Emacs dump core during garbage collection on rare
6111 occasions. sizeof is obviously inferior to offsetof here, so
6112 stick with offsetof.
6113 (GC_POINTER_ALIGNMENT): New macro.
6114 (mark_memory): Omit 3rd (offset) arg; caller changed.
6115 Don't assume EMACS_INT alignment is the same as pointer alignment.
6117 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6119 * keyboard.c (read_key_sequence_remapped): New var.
6120 (read_key_sequence): Compute remapping in the right buffer.
6121 (command_loop_1): Use read_key_sequence's remapping directly.
6123 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6125 * dired.c (file_name_completion): Don't expand file name.
6126 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6127 before checking file name handler.
6129 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6130 they've been requested explicitly (bug#9591).
6132 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6134 * keymap.c (Fsingle_key_description): Use make_specified_string
6135 instead of build_string to build string from push_key_description.
6138 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6140 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6141 This fixes a Y2038 bug on 64-bit hosts.
6142 * buffer.c (reset_buffer):
6143 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6144 (Fclear_buffer_auto_save_failure):
6145 Use 0, not -1, to represent an unset failure time, since time_t
6146 might not be signed.
6148 Remove dependency on glibc malloc internals.
6149 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6150 Move back here from lisp.h, but with their new implementations.
6151 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6152 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6153 * charset.c (charset_table_init): New static var.
6154 (syms_of_charset): Use it instead of xmalloc. This removes a
6155 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6156 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6157 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6158 Move back to alloc.c.
6159 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6160 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6162 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6164 * nsterm.m (windowDidResize): Call x_set_window_size only when
6165 ns_in_resize is true. Otherwise set pixelwidth/height and
6166 call change_frame_size (Bug#9628).
6168 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6170 Port --enable-checking=all to Fedora 14 x86-64.
6171 * charset.c (syms_of_charset): Also account for glibc malloc's
6172 internal overhead when calculating the initial malloc maximum.
6174 Port --enable-checking=all to Fedora 14 x86.
6175 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6177 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6178 (overrun_check_realloc, overrun_check_free):
6179 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6180 That way, xmalloc returns a properly-aligned pointer even if
6181 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6182 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6183 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6184 into account when calculating the initial malloc maximum.
6185 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6186 Move here from alloc.c, so that charset.c can use it too.
6187 Properly align; the old code wasn't right for common 32-bit hosts
6188 when configured with --enable-checking=all.
6189 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6190 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6192 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6194 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6197 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6199 * xdisp.c (compute_display_string_end): If there's no display
6200 string at CHARPOS, return -1.
6202 * bidi.c (bidi_fetch_char): When compute_display_string_end
6203 returns a negative value, treat the character as a normal
6204 character not covered by a display string. (Bug#9624)
6206 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6208 * lread.c (Fread_from_string): Fix typo in docstring.
6210 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6212 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6213 newline, reseat the iterator instead of bidi-iterating there one
6214 character at a time. (Bug#9610)
6215 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6216 TO_CHARPOS if the bidi iterator is at base embedding level.
6218 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6220 * lread.c (readevalloop): Use correct code for NBSP.
6221 (read1): Likewise. (Bug#9608)
6223 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6225 * dbusbind.c (Fdbus_register_signal): When service is not
6226 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6228 2011-09-25 Glenn Morris <rgm@gnu.org>
6230 * buffer.c (truncate-lines): Doc fix.
6232 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6234 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6235 (Fset_window_next_buffers): Doc fix.
6237 2011-09-24 Glenn Morris <rgm@gnu.org>
6239 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6241 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6243 Fix minor problems found by static checking.
6244 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6245 * indent.c (Fvertical_motion): Fix == vs = typo.
6247 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6249 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6250 Default value is now t. Doc fix.
6252 * indent.c (Fvertical_motion): Compute and apply the overshoot
6253 logic when moving up, not only when moving down. Fix the
6254 confusing name and values of the it_overshoot_expected variable;
6255 logic changes accordingly. (Bug#9254) (Bug#9549)
6257 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6258 CHARPOS is covered by a display string which includes newlines.
6259 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6260 is covered by a display string with embedded newlines.
6262 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6264 * dbusbind.c (Fdbus_register_signal): Add match rule to
6265 Vdbus_registered_objects_table. (Bug#9581)
6266 (Fdbus_register_method, Vdbus_registered_objects_table):
6269 2011-09-24 Jim Meyering <meyering@redhat.com>
6271 do not ignore write error for any output size
6272 The previous change was incomplete.
6273 While it makes emacs --batch detect the vast majority of stdout
6274 write failures, errors were still ignored whenever the output size is
6275 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6276 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6277 && echo FAIL: ignored write error
6278 FAIL: ignored write error
6279 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6280 && echo FAIL: ignored write error
6281 FAIL: ignored write error
6282 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6284 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6286 * emacs.c (Fkill_emacs): In noninteractive mode exit
6287 non-successfully if a write error occurred on stdout. (Bug#9574)
6289 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6291 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6294 * dispextern.h (struct it): Update the comment documenting what
6297 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6299 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6300 a display string, extend search for cursor position to end of row.
6301 (find_row_edges): If the row ends in a newline from a display
6302 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6303 Handle the case of a display string with multiple newlines.
6304 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6305 non-empty line. Fixes confusing cursor motion with arrow keys at
6306 the beginning of a line that starts with whitespace.
6308 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6310 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6313 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6315 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6318 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6320 * xdisp.c (display_line): Record maximum and minimum buffer
6321 positions even if no glyphs were produced (e.g., by a zero-width
6322 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6323 buffer positions that will be removed from the glyph row because
6325 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6326 column is beyond frame width: don't subtract 1 "pixel" when
6327 computing width of the stretch.
6328 (reseat_at_next_visible_line_start): Undo the change made on
6329 2011-09-17 that saved paragraph information and restored it after
6330 the call to `reseat'. (Bug#9545)
6332 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6334 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6335 and turn window cursor on if cleared (Bug#9415).
6337 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6339 * search.c (boyer_moore): Take unibyte characters from pattern
6340 literally. (Bug#9458)
6342 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6344 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6346 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6348 Fix minor problem found by static checking.
6349 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6350 initialized, to pacify gcc -Wuninitialized.
6352 * fileio.c: Report proper errno when syscall falls.
6353 (Finsert_file_contents): Save and restore errno,
6354 so that report_file_error outputs the correct diagnostic.
6355 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6357 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6359 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6361 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6363 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6364 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6366 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6368 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6369 about the current paragraph and restore it after the call to reseat.
6371 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6372 (bidi_find_paragraph_start): Search back for paragraph beginning
6373 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6374 (bidi_move_to_visually_next): Only trigger paragraph-related
6375 computations when the last character is a newline or at EOB, not
6376 just any NEUTRAL_B. (Bug#9470)
6378 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6379 truncated lines if point is covered by a display string. (Bug#9524)
6381 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6383 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6384 (cons_to_x_long): New function.
6385 (lisp_data_to_selection_data): Use it. Correct the test for
6386 short-versus-long data; it was negated. Break out of vector
6387 loop, for efficiency, when a long datum is discovered.
6389 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6391 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6393 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6395 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6396 GCC PR/17406) by declaring this function with external scope.
6398 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6400 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6401 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6403 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6405 * editfns.c (Fformat): Correctly handle text properties on "%%".
6407 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6409 * xterm.c (x_draw_composite_glyph_string_foreground):
6410 * w32term.c (x_draw_composite_glyph_string_foreground):
6411 * term.c (encode_terminal_code):
6412 * composite.c (composition_update_it, get_composition_id):
6413 * xdisp.c (get_next_display_element)
6414 (fill_composite_glyph_string): Add comments about special meaning
6415 of TAB characters in a composition.
6417 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6419 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6420 This occurs when processing a multibyte format.
6421 Problem reported by Wolfgang Jenker.
6423 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6425 * xdisp.c (try_cursor_movement): Only check for exact match if
6426 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6428 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6430 Remove unused external symbols.
6431 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6432 * xdisp.c (calc_pixel_width_or_height): Now static.
6433 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6434 * indent.c (check_display_width):
6435 * w32term.c: Fix comment to match code.
6436 * xterm.c, xterm.h (x_catching_errors): Remove.
6438 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6440 * xselect.c: Use signed conversions more consistently (Bug#9498).
6441 (selection_data_to_lisp_data): Assume incoming selection data are
6442 signed integers, not unsigned. This is to be consistent with
6443 outgoing selection data, which was modified to use signed integers
6444 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6445 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6446 expects long, not unsigned long.
6448 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6450 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6451 computation of loop end. Reported by Johan Bockgård
6454 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6456 * frame.c (Fother_visible_frames_p): Function deleted.
6458 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6460 * indent.c (compute_motion): Process display vector front to back
6461 rather than the other way around. (Bug#2496)
6463 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6465 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6467 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6469 * minibuf.c (Fread_from_minibuffer): Doc fix.
6471 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6473 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6474 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6476 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6478 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6479 value for non-existent files.
6481 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6483 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6484 set its "size" to -1. This will set the modtime_size field of
6485 the corresponding buffer to -1, which is what
6486 verify-visited-file-modtime expects for files that do not exist.
6489 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6491 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6493 * lisp.h: ... from here. push_key_description is no longer
6494 defined in keyboard.c, so its declaration should not be in
6495 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6496 logically belongs with push_key_description.
6498 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6500 * buffer.h: Include <sys/types.h> instead of <time.h>.
6501 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6502 Problem reported by Herbert J. Skuhra.
6504 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6506 * xml.c (parse_region): Make the parsing work for
6507 non-comment-starting XML files again (bug#9144).
6509 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6511 * image.c (gif_load): Fix calculation of bottom and right corner.
6514 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6516 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6517 redisplay in small windows.
6519 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6521 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6523 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6525 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6526 Operate on live windows only.
6528 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6530 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6532 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6534 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6535 only under bidi iteration.
6537 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6539 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6541 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6543 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6544 Without this fix, the command to link temacs failed due to an
6545 undefined symbol __builtin_isnan. This is because
6546 /usr/include/iso/math_c99.h #defines isnan(x) to
6547 __builtin_isnan(x), but the bundled gcc, which identifies itself
6548 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6550 * floatfns.c (isnan): #undef, and then #define to a clone of
6552 (Fisnan): Always define, since it's always available now.
6553 (syms_of_floatfns): Always define isnan at the Lisp level.
6555 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6557 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6559 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6561 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6562 The previous code assumed that file offsets (off_t values) fit in
6563 EMACS_INT variables, which is not true on typical 32-bit hosts.
6564 The code messed up by falsely reporting buffer overflow in cases
6565 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6566 when "big" contains more than 2**29 bytes, even though this
6567 inserts just one byte and does not overflow the buffer.
6568 (Finsert_file_contents): Store file offsets as off_t
6569 values, not as EMACS_INT values. Check for overflow when
6570 converting between EMACS_INT and off_t. When checking for
6571 buffer overflow or for overlap, take the offsets into account.
6572 Don't use EMACS_INT for small values where int suffices.
6573 When checking for overlap, fix a typo: ZV was used where
6574 ZV_BYTE was intended.
6575 (Fwrite_region): Don't assume off_t fits into 'long'.
6576 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6578 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6580 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6582 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6584 sprintf-related integer and memory overflow issues (Bug#9412).
6586 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6587 (esprintf, exprintf, evxprintf): New functions.
6588 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6589 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6590 (modify_event_symbol): Do not assume that the length of
6591 name_alist_or_stem is safe to alloca and fits in int.
6592 (Fexecute_extended_command): Likewise for function name and binding.
6593 (Frecursion_depth): Wrap around reliably on integer overflow.
6594 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6595 since some callers pass EMACS_INT values.
6596 (Fsingle_key_description): Don't crash if symbol name contains more
6597 than MAX_ALLOCA bytes.
6598 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6599 (get_minibuffer): Arg is now EMACS_INT, not int.
6600 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6601 (esprintf, exprintf, evxprintf): New decls.
6602 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6604 * dbusbind.c (signature_cat): New function.
6605 (xd_signature, Fdbus_register_signal):
6606 Do not overrun buffer; instead, report string overflow.
6608 * dispnew.c (add_window_display_history): Don't overrun buffer.
6609 Truncate instead; this is OK since it's just a log.
6611 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6612 even if the time zone offset is outlandishly large.
6613 Don't mishandle offset == INT_MIN.
6615 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6616 when creating daemon; the previous buffer-overflow check was incorrect.
6618 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6619 which has the guts of the old verror function.
6621 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6622 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6624 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6625 (font_unparse_xlfd): Don't blindly alloca long strings.
6626 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6627 fits in int, when using sprintf. Use single snprintf to count
6628 length of string rather than counting it via multiple sprintfs;
6629 that's simpler and more reliable.
6630 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6631 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6632 sprintf, in case result does not fit in int.
6634 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6635 (fontset_from_font): Print it.
6637 * frame.c (tty_frame_count): Now printmax_t, not int.
6638 (make_terminal_frame, set_term_frame_name): Print it.
6639 (x_report_frame_params): In X, window IDs are unsigned long,
6640 not signed long, so print them as unsigned.
6641 (validate_x_resource_name): Check for implausibly long names,
6642 and don't assume name length fits in 'int'.
6643 (x_get_resource_string): Don't blindly alloca invocation name;
6644 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6647 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6648 (xg_check_special_colors, xg_set_geometry):
6649 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6651 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6652 Use esprintf, not sprintf, in case result does not fit in int.
6654 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6655 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6656 it as a large positive number.
6657 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6658 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6660 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6661 in case result does not fit in int.
6663 * print.c (float_to_string): Detect width overflow more reliably.
6664 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6665 buffer overrun. Don't assume list length fits in 'int'. Treat
6666 print length of 0 as 0, not as infinity; to be consistent with other
6667 uses of print length in this function. Don't overflow print length
6668 index. Don't assume hash table size fits in 'long', or that
6669 vectorlike size fits in 'unsigned long'.
6671 * process.c (make_process): Use printmax_t, not int, to format
6672 process-name gensyms.
6674 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6676 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6677 to avoid potential buffer overrun.
6679 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6680 if X resource line is longer than 512 bytes.
6682 * xfns.c (x_window): Make sprintf buffer a bit bigger
6683 to avoid potential buffer overrun.
6685 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6687 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6689 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6691 Integer overflow fixes for scrolling, etc.
6692 Without these, Emacs silently mishandles large integers sometimes.
6693 For example, "C-u 4294967297 M-x recenter" was treated as if
6694 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6696 * xdisp.c (try_window_id): Check Emacs fixnum range before
6697 converting to 'int'.
6699 * window.c (window_scroll_line_based, Frecenter):
6700 Check that an Emacs fixnum is in range before assigning it to 'int'.
6701 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6702 values converted from Emacs fixnums.
6703 (Frecenter): Don't wrap around a line count if it is out of 'int'
6704 range; instead, treat it as an extreme value.
6705 (Fset_window_configuration, compare_window_configurations):
6706 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6708 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6709 that can exceed INT_MAX. Check that EMACS_INT value is in range
6710 before assigning it to the (possibly-narrower) index.
6711 (match_limit): Don't assume that a fixnum can fit in 'int'.
6713 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6716 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6717 (Fvertical_motion): Don't wrap around LINES values that don't fit
6718 in 'int'. Instead, treat them as extreme values. This is good
6719 enough for windows, which can't have more than INT_MAX lines anyway.
6721 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6723 * Require libxml/parser.h to avoid compilation warning.
6725 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6727 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6728 since this reportedly can destroy thread storage.
6730 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6732 * syntax.c (find_defun_start): Update all cache variables if
6733 exiting early (Bug#9401).
6735 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6737 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6739 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6740 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6741 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6743 * term.c (tty_append_glyph): New function.
6744 (produce_stretch_glyph): Static function and its prototype deleted.
6746 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6749 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6751 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6752 when checking :margin (Bug#9390).
6753 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6754 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6755 so that the name doesn't mislead. All uses changed.
6757 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6759 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6762 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6764 * xdisp.c (move_it_to): Don't bail out early when reaching
6765 position beyond to_charpos, if we are scanning backwards.
6766 (move_it_vertically_backward): When DY == 0, make sure we get to
6767 the first character in the line after the newline.
6769 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6771 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6772 (ccl_driver): Do not generate an out-of-range pointer.
6773 (Fccl_execute_on_string): Remove unnecessary check for
6774 integer overflow, noted by Stefan Monnier in
6775 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6776 Remove a FIXME that didn't need fixing.
6777 Simplify the newly-introduced buffer reallocation code.
6779 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6781 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6783 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6785 Integer and memory overflow issues (Bug#9196).
6787 * doc.c (get_doc_string): Rework so that
6788 get_doc_string_buffer_size is the actual buffer size, rather than
6789 being 1 less than the actual buffer size; this makes xpalloc more
6792 * image.c (x_allocate_bitmap_record, cache_image):
6793 * xselect.c (Fx_register_dnd_atom):
6794 Simplify previous changes by using xpalloc.
6796 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6797 since either will do and ptrdiff_t is convenient with xpalloc.
6799 * charset.c (charset_table_size)
6800 (struct charset_sort_data.priority): Now ptrdiff_t.
6801 (charset_compare): Don't overflow if priorities differ greatly.
6802 (Fsort_charsets): Don't assume list length fits in int.
6803 Check for size-calculation overflow when allocating sort data.
6804 (syms_of_charset): Allocate an initial charset table that is
6805 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6807 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6809 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6810 The actual value is always <= INT_MAX, and leaving it unsigned made
6811 overflow checking harder.
6813 * dispextern.h (struct glyph_matrix.rows_allocated)
6814 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6815 with xpalloc. The values are still always <= INT_MAX.
6817 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6819 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6820 (SAFE_NALLOCA): New macro.
6822 * region-cache.c (struct boundary.pos, find_cache_boundary)
6823 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6824 (set_cache_region, invalidate_region_cache)
6825 (revalidate_region_cache, know_region_cache, region_cache_forward)
6826 (region_cache_backward, pp_cache):
6827 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6828 so that ptrdiff_t * can be passed to xpalloc.
6829 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6830 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6831 (pp_cache): Don't assume cache_len fits in int.
6832 * region-cache.h: Adjust extern decls to match.
6834 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6835 EMACS_INT, since either will do, for xpalloc.
6837 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6838 (xnmalloc, xnrealloc, xpalloc): New functions.
6840 * bidi.c (bidi_shelve_header_size): New constant.
6841 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6842 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6844 * bidi.c (bidi_cache_shrink):
6845 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6847 Don't update size of array until after memory allocation succeeds,
6848 because xmalloc/xrealloc may not return.
6849 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6850 now that we have proper integer overflow checking.
6851 (record_overlay_string, overlay_strings): Catch overflows when
6852 calculating size of overlay_str_buf.
6854 * callproc.c (Fcall_process): Check for size overflow when
6855 calculating size of args2.
6856 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6857 Normally we prefer signed values, but sticking with ptrdiff_t would
6858 require adding more-complicated checks.
6860 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6861 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6862 Redo buffer-overflow calculations to avoid integer overflow.
6863 Add a FIXME comment where memory seems to be over-allocated.
6865 * character.c (Fstring): Check for size-calculation overflow.
6867 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6868 unnecessary integer overflow. Check for size overflow.
6869 (encode_coding_object): Don't update size until xmalloc succeeds.
6871 * composite.c (get_composition_id): Check for overflow in glyph
6872 length calculations.
6874 Integer and memory overflow fixes for display code.
6875 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6876 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6877 (scrolling_window): Check for overflow in size calculations.
6878 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6879 Don't assume glyph table len fits in int.
6880 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6881 (row_table_size): Now ptrdiff_t, not int.
6882 (scrolling_window): Avoid overflow in size calculations.
6883 Don't update size until allocation succeeds.
6884 * fns.c (concat): Check for overflow in size calculations.
6885 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6886 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6887 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6889 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6890 (get_doc_string): Check for size calculation overflow.
6891 Don't update size until allocation succeeds.
6892 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6893 EMACS_INT, where ptrdiff_t will do.
6894 (Fsubstitute_command_keys): Check for string overflow.
6896 * editfns.c (set_time_zone_rule): Don't assume environment length
6898 (message_length): Now ptrdiff_t, not int.
6899 (Fmessage_box): Don't update size until allocation succeeds.
6900 Don't assume message length fits in int.
6901 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6903 * emacs.c (main): Do not reallocate argv, since there is a null at
6904 the end that can be overwritten, and this way there's no need to
6905 worry about size-calculation overflow.
6906 (sort_args): Check for size-calculation overflow.
6908 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6910 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6912 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6913 (x_set_scroll_bar_width, x_figure_window_size):
6914 Check for integer overflow.
6915 (x_set_alpha): Do not assume XINT fits in int.
6917 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6918 This is for the members text_lines, text_cols, total_lines, total_cols,
6919 where the system imposes an 'int' limit.
6921 * fringe.c (Fdefine_fringe_bitmap):
6922 Don't update size until alloc works.
6924 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6925 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6927 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6928 Check for size-calculation overflow.
6929 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6930 do, as we prefer signed integers.
6931 (id_to_widget.max_size, id_to_widget.used)
6932 (xg_store_widget_in_map, xg_remove_widget_from_map)
6933 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6934 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6935 Use and return ptrdiff_t, not int.
6936 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6937 * gtkutil.h: Change prototypes to match the above.
6939 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6940 are duplicate now that they've been promoted to lisp.h.
6941 (x_allocate_bitmap_record, x_alloc_image_color)
6942 (make_image_cache, cache_image, xpm_load):
6943 Don't update size until alloc is done.
6944 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6946 Check for size calculation overflow.
6947 (ct_colors_allocated_max): New constant.
6948 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6951 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6952 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6953 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6954 Use ptrdiff_t, not int, to count maps.
6955 (read_char_minibuf_menu_prompt): Check for overflow in size
6956 calculations. Don't update size until allocation succeeds.
6957 Redo calculations to avoid overflow.
6958 * keyboard.h: Change prototypes to match the above.
6960 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6962 (current_minor_maps): Check for size calculation overflow.
6963 * keymap.h: Change prototypes to match the above.
6965 * lread.c (read1, init_obarray): Don't update size until alloc done.
6967 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6968 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6970 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6971 Now ptrdiff_t, not int.
6972 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6973 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6975 * process.c (Fnetwork_interface_list): Check for overflow
6976 in size calculation.
6978 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6980 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6981 overflow. Don't bother calling xmalloc when xrealloc will do.
6983 * search.c (Freplace_match): Check for size calculation overflow.
6984 (Fset_match_data): Don't assume list lengths fit in 'int'.
6986 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6987 for command line length. Do not attempt to address one before the
6988 beginning of an array, as that's not portable.
6990 * term.c (max_frame_lines): Remove; unused.
6991 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6993 (encode_terminal_code, calculate_costs): Check for size
6994 calculation overflow.
6995 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6996 table lengths and related sizes. Don't update size until alloc
6997 done. Redo calculations to avoid overflow.
6998 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7000 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7001 subtracting pointers.
7002 (gobble_line): Check for overflow more carefully. Don't update size
7005 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7006 Don't update size until alloc done.
7007 Redo size calculations to avoid overflow.
7008 Check for size calculation overflow.
7009 (main) [DEBUG]: Fix typo in invoking tparam1.
7011 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7012 Use ptrdiff_t, not int, for sizes.
7013 (store_mode_line_noprop_char): Don't update size until alloc done.
7015 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7016 Use ptrdiff_t, not int, for sizes.
7017 (Finternal_make_lisp_face, cache_face):
7018 Check for size calculation overflow.
7019 (cache_face): Treat size calculation overflows as if they were
7020 memory exhaustion (the usual treatment), rather than aborting.
7022 * xfns.c (x_encode_text, x_set_name_internal)
7023 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7024 sizes, since they can exceed INT_MAX in size. Check for size
7025 calculation overflow.
7027 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7028 (xg_select): Check for size calculation overflow.
7029 Don't update size until alloc done.
7031 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7032 as sprintf is limited to int lengths.
7034 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7035 (X_LONG_MIN): New macros.
7036 Use them to make the following changes clearer.
7037 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7038 This change doesn't affect the value now, but it may help remind
7039 future maintainers not to raise the value too much later.
7040 (SELECTION_QUANTUM): Remove, replacing with ...
7041 (selection_quantum): ... new function, which avoids overflow.
7043 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7044 assumption that selection length fits in 'int'.
7045 (x_reply_selection_request, x_handle_selection_request)
7046 (x_get_window_property, receive_incremental_selection)
7047 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7048 (lisp_data_to_selection_data, clean_local_selection_data):
7049 Use ptrdiff_t, not int, to record length of selection.
7050 (x_reply_selection_request, x_get_window_property)
7051 (receive_incremental_selection, x_property_data_to_lisp):
7052 Redo calculations to avoid overflow.
7053 (x_reply_selection_request): When sending hint, ceiling it at
7054 X_LONG_MAX rather than relying on wraparound overflow to send
7056 (x_get_window_property, receive_incremental_selection)
7057 (lisp_data_to_selection_data, x_property_data_to_lisp):
7058 Check for size-calculation overflow.
7059 (x_get_window_property, receive_incremental_selection)
7060 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7061 Don't store size until memory allocation succeeds.
7062 (x_get_window_property): Plug memory leak on memory exhaustion.
7063 Don't double-block input; malloc is safe here. Don't assume 2**34
7064 - 4 fits in unsigned long. Add an xassert to check
7065 XGetWindowProperty overflow. Be more careful about overflow
7066 calculations, and distinguish size from memory overflow better.
7067 (receive_incremental_selection): When tracing, don't assume
7068 unsigned int is less than INT_MAX.
7069 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7070 harmful) conversions of unsigned short to int.
7071 (lisp_data_to_selection_data): Don't assume that integers
7072 in the range -65535 through -1 fit in an X unsigned short.
7073 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7074 result parameters unless successful. Rely on cons_to_unsigned
7075 to report problems with elements; the old code wasn't right anyway.
7076 (x_check_property_data): Check for int overflow; we cannot use
7077 a wider type due to X limits.
7078 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7080 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7082 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7083 (x_term_init): Check for size calculation overflow.
7084 (x_color_cells): Don't store size until memory allocation succeeds.
7085 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7086 Don't assume alloca size is less than MAX_ALLOCA.
7087 (x_term_init): Don't assume length fits in int (sprintf is limited
7090 Use ptrdiff_t for composition IDs.
7091 * character.c (lisp_string_width):
7092 * composite.c (composition_table_size, n_compositions)
7093 (get_composition_id, composition_gstring_from_id):
7094 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7095 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7096 * window.c (Frecenter):
7097 Use ptrdiff_t, not int, for composition IDs.
7098 * composite.c (get_composition_id): Check for integer overflow.
7099 * composite.h: Adjust prototypes to match the above changes.
7101 Use ptrdiff_t for hash table indexes.
7102 * category.c (hash_get_category_set):
7103 * ccl.c (ccl_driver):
7104 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7105 * coding.c (coding_system_charset_list, detect_coding_system):
7106 * coding.h (struct coding_system.id):
7107 * composite.c (get_composition_id, gstring_lookup_cache):
7108 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7109 * image.c (xpm_get_color_table_h):
7110 * lisp.h (hash_lookup, hash_put):
7111 * minibuf.c (Ftest_completion):
7112 Use ptrdiff_t for hash table indexes, not int (which is too
7113 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7114 32-bit --with-wide-int hosts).
7116 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7117 Add a FIXME comment about memory leaks.
7118 (syms_of_charset): Don't assume xmalloc returns.
7120 Don't assume that stated character widths fit in int.
7121 * character.c (Fchar_width, c_string_width, lisp_string_width):
7122 * character.h (CHAR_WIDTH):
7123 * indent.c (MULTIBYTE_BYTES_WIDTH):
7124 Use sanitize_char_width to avoid undefined and/or bad behavior
7125 with outlandish widths.
7126 * character.h (sanitize_tab_width): Rename from sanitize_width,
7127 now that we have two such functions. All uses changed.
7128 (sanitize_char_width): New inline function.
7130 Don't assume that tab-width fits in int.
7131 * character.h (sanitize_width): New inline function.
7132 (SANE_TAB_WIDTH): New macro.
7133 (ASCII_CHAR_WIDTH): Use it.
7134 * indent.c (sane_tab_width): Remove. All uses replaced by
7135 SANE_TAB_WIDTH (current_buffer).
7136 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7138 * fileio.c: Integer overflow issues with file modes.
7139 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7141 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7142 Remove unreachable code.
7143 (read_hex, load_charset_map_from_file): Check for integer overflow.
7145 * xterm.c: Don't go over XClientMessageEvent limit.
7146 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7147 (x_send_scroll_bar_event): Likewise. Check that the size does not
7148 exceed limits imposed by XClientMessageEvent, as well as the usual
7149 ptrdiff_t and size_t limits.
7151 * keyboard.c: Overflow, signedness and related fixes.
7152 (make_lispy_movement): Use same integer type in forward decl
7153 that is used in the definition.
7154 (read_key_sequence, keyremap_step):
7155 Change bufsize argument back to int, undoing my 2011-03-30 change.
7156 We prefer signed types, and int is wide enough here.
7157 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7158 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7159 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7160 length, not size_t. Use ptrdiff_t for index, not int.
7161 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7162 possibility of integer overflow.
7164 Overflow, signedness and related fixes for images.
7166 * dispextern.h (struct it.stack[0].u.image.image_id)
7167 (struct_it.image_id, struct image.id, struct image_cache.size)
7168 (struct image_cache.used, struct image_cache.ref_count):
7169 * gtkutil.c (update_frame_tool_bar):
7170 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7171 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7172 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7173 * nsmenu.m (update_frame_tool_bar):
7174 * xdisp.c (calc_pixel_width_or_height):
7175 * xfns.c (image_cache_refcount):
7176 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7177 on typical 64-bit hosts.
7179 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7180 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7181 Omit unnecessary casts to int.
7182 (parse_image_spec): Check that integers fall into 'int' range
7183 when the callers expect that.
7184 (image_ascent): Redo ascent calculation to avoid int overflow.
7185 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7186 (lookup_image): Remove unnecessary tests.
7187 (xbm_image_p): Locals are now of int, not EMACS_INT,
7188 since parse_image_check makes sure they fit into int.
7189 (png_load, gif_load, svg_load_image):
7190 Prefer int to unsigned where either will do.
7191 (tiff_handler): New function, combining the cores of the
7192 old tiff_error_handler and tiff_warning_handler.
7193 This function is rewritten to use vsnprintf and thereby avoid
7194 stack buffer overflows. It uses only the features of vsnprintf
7195 that are common to both POSIX and native Microsoft.
7196 (tiff_error_handler, tiff_warning_handler): Use it.
7197 (tiff_load, gif_load, imagemagick_load_image):
7198 Don't assume :index value fits in 'int'.
7199 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7200 (imagemagick_load_image): Check that crop parameters fit into
7201 the integer types that MagickCropImage accepts. Don't assume
7202 Vimagemagick_render_type has a nonnegative value. Don't assume
7203 size_t fits in 'long'.
7204 (gs_load): Use printmax_t to print the widest integers possible.
7205 Check for integer overflow when computing image height and width.
7207 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7209 * xdisp.c (redisplay_window): Don't force window start if point
7210 will be invisible in the resulting window. (Bug#9324)
7212 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7214 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7215 the display spec is of the form `(space ...)'.
7216 (handle_display_spec): Return the value returned by
7217 handle_single_display_spec, not just 1 or zero.
7218 (handle_single_display_spec): If the display spec is of the form
7219 `(space ...)', and specifies display in the text area, return 2
7221 (try_cursor_movement): Check for the need to scroll more
7222 accurately, and prefer exact match for point under bidi.
7223 Don't advance `row' beyond the last row of the window.
7225 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7226 into disp_prop; all users changed.
7228 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7229 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7230 for the text covered by the display property.
7232 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7234 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7235 Change return value to nil.
7236 (Frecord_buffer): Delete unused function.
7238 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7240 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7241 buffers, return left-to-right.
7242 (set_cursor_from_row): Consider candidate row a win if its glyph
7243 represents a newline and point is on that newline. Fixes cursor
7244 positioning on the newline at EOL of R2L text within L2R
7245 paragraph, and vice versa.
7246 (try_cursor_movement): Check continued rows, in addition to
7247 continuation rows. Fixes unwarranted scroll when point enters a
7248 continued line of R2L text within an L2R paragraph, or vice versa.
7249 (cursor_row_p): Consider the case of point being equal to
7250 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7251 from the end of a short line to the beginning of a continued line
7252 of R2L text within L2R paragraph.
7253 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7254 composed characters.
7256 * bidi.c (bidi_check_type): Use xassert.
7257 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7260 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7262 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7265 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7267 * nsfont.m (ns_otf_to_script): Fix typo.
7269 2011-08-22 Kenichi Handa <handa@m17n.org>
7271 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7272 extra slot even if the purpose is char-code-property-table.
7274 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7276 * xdisp.c (redisplay_window): When computing centering_position,
7277 account for the height of the header line. (Bug#8874)
7279 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7280 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7281 candidate is selected by the mouse, and that candidate has a
7282 composed character under the mouse.
7284 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7285 coordinates reported by pos-visible-in-window-p for a composed
7286 character in column zero.
7288 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7290 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7292 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7294 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7295 consider it a hit if to_charpos is anywhere in the range of the
7296 composed buffer positions.
7298 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7300 * image.c (gif_load): Don't assume that each subimage has the same
7301 dimensions as the base image. Handle disposal method that is
7302 "undefined" by the gif spec (Bug#9335).
7304 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7306 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7307 (Fcondition_case): Document `debug' symbol in error handler.
7309 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7311 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7312 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7313 from an Org mode buffer to a Speedbar frame.
7315 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7316 a composition, take its buffer position from IT->cmp_it.charpos.
7317 Fixes cursor positioning at the beginning of a line that begins
7318 with a composed character.
7320 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7322 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7323 character bidirectional type, use STRONG_L instead. Fixes crashes
7324 in a buffer produced by `describe-categories'.
7326 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7327 members before the level stack, so they would be saved and
7328 restored when copying iterator state. Fixes incorrect reordering
7329 around TABs covered by display properties.
7331 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7333 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7335 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7337 * eval.c (internal_condition_case, internal_condition_case_1)
7338 (internal_condition_case_2, internal_condition_case_n):
7339 Remove unnecessary aborts (Bug#9081).
7341 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7343 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7344 has no `load' handler, try opening the file locally. (Bug#9311)
7346 2011-08-16 Ken Brown <kbrown@cornell.edu>
7348 * gmalloc.c: Expand comment.
7350 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7352 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7353 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7355 2011-08-16 Ken Brown <kbrown@cornell.edu>
7357 Fix memory allocation problems in Cygwin build (Bug#9273).
7359 * unexcw.c ( __malloc_initialized): Declare external variable.
7360 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7362 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7364 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7366 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7368 [CYGWIN] (special_realloc): New function.
7369 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7370 requests to realloc storage in the static heap.
7372 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7374 * bidi.c (bidi_initialize): Remove unused local.
7376 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7379 * biditype.h: Remove file.
7380 * makefile.w32-in ($(BLD)/bidi.$(O)):
7381 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7383 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7385 * chartab.c: Improve commentary for the uniprop_table API.
7387 * bidi.c (bidi_paragraph_init): Support zero value of
7388 bidi_ignore_explicit_marks_for_paragraph_level.
7389 (bidi_initialize): Use uniprop_table instead of including
7390 biditype.h and bidimirror.h.
7392 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7393 coordinates of the iterator when restoring from ppos_it.
7396 2011-08-14 Kenichi Handa <handa@m17n.org>
7398 * process.c (create_process): Call setup_process_coding_systems
7399 after the pid of the process is set to -1 (Bug#8162).
7401 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7403 * xdisp.c (move_it_in_display_line_to): Don't invoke
7404 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7405 ppos_it. Fixes vertical cursor motion when line beginning is
7406 covered by an image. (Bug#9296)
7408 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7410 * nsterm.h (ns_run_ascript): Declare.
7411 (NSAPP_DATA2_RUNASSCRIPT): Define.
7413 * nsfns.m (as_script, as_result, as_status): New static variables.
7414 (ns_run_ascript): New function.
7415 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7416 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7417 the event loop. Get status from as_status (Bug#7276).
7419 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7420 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7421 the event loop (Bug#7276).
7423 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7425 * gnutls.c (QCgnutls_bootprop_priority)
7426 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7427 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7428 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7429 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7430 (QCgnutls_bootprop_verify_hostname_error)
7431 (QCgnutls_bootprop_callbacks_verify): Rename from
7432 Qgnutls_bootprop_..., all uses changed.
7434 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7437 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7439 * xfaces.c (Qframe_set_background_mode): Now static.
7440 * dispextern.h (Qframe_set_background_mode): Remove decl.
7442 * process.c (Fnetwork_interface_info): Declare local only if needed.
7444 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7446 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7447 (Fnetwork_interface_list): Allocate in increments of bytes instead
7448 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7449 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7451 (struct ifflag_def): notrailers is smart on OSX.
7452 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7453 Get hardware address with getifaddrs if available.
7455 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7457 * xdisp.c (iterate_out_of_display_property): xassert that
7458 IT->position is set to within IT->object's boundaries. Break from
7459 the loop as soon as EOB is reached; avoids infloops in redisplay
7460 when IT->position is set up wrongly due to some bug.
7461 Set IT->current to match the bidi iterator unconditionally.
7462 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7463 entry. Force push_it to save on the stack the current
7464 buffer/string position, to be restored by pop_it. Fix flags in
7465 the iterator structure wrt the object coming from a display
7466 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7467 properties. (Bug#9284)
7469 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7471 * fontset.c (fontset_get_font_group): Add proper type checks.
7474 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7476 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7477 and LC_VERSION_MIN_MACOSX.
7478 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7479 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7481 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7483 * xdisp.c (forward_to_next_line_start): Allow to use the
7484 no-display-properties-and-no-overlays under bidi display.
7485 Set disp_pos in the bidi iterator to avoid searches for display
7486 properties and overlays.
7488 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7490 * editfns.c (Fset_time_zone_rule): Document relationship with the
7493 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7494 the font entity extracted from the cache (Bug#8109).
7496 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7498 * composite.c (autocmp_chars): Don't reset point. That is done by
7499 restore_point_unwind (Bug#5984).
7501 2011-08-07 Juri Linkov <juri@jurta.org>
7503 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7504 to show the arg `TIME' instead of `TIMEVAL'.
7506 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7508 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7509 display property strides EOL and includes a newline, as in
7510 longlines-mode. (Bug#9254)
7511 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7512 word-wrap under bidirectional display. (Bug#9224)
7514 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7515 is non-zero, even if the data buffer is NULL. Fixes a crash in
7516 vertical-motion with longlines-mode. (Bug#9254)
7518 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7520 * bidi.c <bidi_cache_total_alloc>: Now static.
7521 (bidi_initialize): Initialize bidi_cache_total_alloc.
7523 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7526 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7527 amount allocated this far in `bidi_cache_total_alloc'.
7528 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7529 non-zero, only free the data buffer without restoring the cache
7530 contents. All callers changed.
7532 * dispextern.h (bidi_unshelve_cache): Update prototype.
7534 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7535 (move_it_in_display_line, move_it_to)
7536 (move_it_vertically_backward, move_it_by_lines): Replace the call
7537 to xfree to an equivalent call to bidi_unshelve_cache.
7538 (move_it_in_display_line_to): Fix logic of returning
7539 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7541 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7543 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7544 came from a string character with a `cursor' property. (Bug#9229)
7546 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7548 * Makefile.in (LIB_PTHREAD): New variable.
7549 (LIBES): Add LIB_PTHREAD (Bug#9216).
7551 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7552 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7554 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7556 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7558 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7560 * xterm.c (x_find_topmost_parent): New function.
7561 (x_set_frame_alpha): Find topmost parent window with
7562 x_find_topmost_parent and set the property there also (bug#9181).
7563 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7565 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7567 * callproc.c (Fcall_process): Avoid vfork clobbering
7568 the local vars buffer, coding_systems, current_dir.
7570 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7572 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7574 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7576 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7577 so that it is not optimized away.
7579 * xdisp.c (compute_display_string_pos): Remove unused local.
7581 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7583 Fix slow cursor motion and scrolling in large buffers with
7584 selective display, like Org Mode buffers. (Bug#9218)
7586 * dispextern.h (struct bidi_it): New member disp_prop_p.
7588 * xdisp.c: Remove one-slot cache of display string positions.
7589 (compute_display_string_pos): Accept an additional argument
7590 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7591 for a display string or property. If found, set DISP_PROP_P
7594 * bidi.c (bidi_fetch_char): Accept an additional argument
7595 DISP_PROP_P, and pass it to compute_display_string_pos.
7596 Only handle text covered by a display string if DISP_PROP_P is returned
7597 non-zero. All callers of bidi_fetch_char changed.
7599 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7601 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7603 2010-12-03 Don March <don@ohspite.net>
7605 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7606 last character M-[char] is translated to ESC [char] (bug#7541).
7608 2011-08-02 Kenichi Handa <handa@m17n.org>
7610 * lisp.h (uniprop_table): Extern it.
7612 * chartab.c (uniprop_table): Make it non-static.
7614 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7616 * xdisp.c (forward_to_next_line_start): Accept additional argument
7617 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7619 (reseat_at_next_visible_line_start): Use the bidi iterator state
7620 returned by forward_to_next_line_start to restore the state of
7621 it->bidi_it after backing up to previous newline. (Bug#9212)
7623 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7625 * regex.c (re_comp): Protoize.
7626 (re_exec): Fix return type.
7627 (regexec): Fix type of `ret'. (Bug#9203)
7629 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7631 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7632 This is needed if max-image-size is a floating-point number.
7634 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7636 * print.c (print_object): Print empty symbol as ##.
7638 * lread.c (read1): Read ## as empty symbol.
7640 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7642 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7643 setting frame foreground color (Bug#9175).
7644 (x_set_background_color): Likewise.
7646 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7647 contents (Bug#9176).
7648 (EmacsTooltip -init): Remove bezels and add shadows to
7651 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7652 or scroll bar (Bug#8470).
7654 * nsfont.m (nsfont_open): Remove assignment to voffset and
7655 unnecessary vars hshink, expand, hd, full_height, min_height.
7656 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7658 * nsterm.h (nsfont_info): Remove voffset field.
7660 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7662 Implement strike-through and overline on NextStep (Bug#8863).
7664 * nsfont.m (nsfont_open): Use underline position provided by font,
7665 instead of hard-coded value of 2.
7666 (nsfont_draw): Call ns_draw_text_decoration instead.
7668 * nsterm.h: Add declaration for ns_draw_text_decoration.
7670 * nsterm.m (ns_draw_text_decoration): New function for drawing
7671 underline, overline, and strike-through.
7672 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7673 ns_draw_text_decoration. Change treatment of cursor drawing to
7674 accommodate underlining, etc.
7676 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7678 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7681 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7683 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7684 Without this fix, if a signal arrives just after memory fills up,
7685 'malloc' might be invoked reentrantly.
7687 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7688 In other words, assume that every image size is allowed, on non-X
7689 hosts. This assumption is probably wrong, but it lets Emacs compile.
7691 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7693 * regex.c (re_iswctype): Convert return values to boolean.
7695 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7697 * xdisp.c (compute_display_string_pos): Don't use cached display
7698 string position if the buffer had its restriction changed.
7701 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7703 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7705 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7707 Integer signedness and overflow and related fixes. (Bug#9079)
7709 * bidi.c: Integer size and overflow fixes.
7710 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7711 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7712 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7713 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7714 (bidi_find_other_level_edge):
7715 Use ptrdiff_t instead of EMACS_INT where either will do.
7716 This works better on 32-bit hosts configured --with-wide-int.
7717 (bidi_cache_ensure_space): Check for size-calculation overflow.
7718 Use % rather than repeated addition, for better worst-case speed.
7719 Don't set bidi_cache_size until after xrealloc returns, because it
7721 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7722 (bidi_cache_ensure_space): Also check that the bidi cache size
7723 does not exceed that of the largest Lisp string or buffer. See Eli
7724 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7726 * alloc.c (__malloc_size_t): Remove.
7727 All uses replaced by size_t. See Andreas Schwab's note
7728 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7730 * image.c: Improve checking for integer overflow.
7731 (check_image_size): Assume that f is nonnull, since
7732 it is always nonnull in practice. This is one less thing to
7733 worry about when checking for integer overflow later.
7734 (x_check_image_size): New function, which checks for integer
7735 overflow issues inside X.
7736 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7737 This removes the need for a memory_full check.
7738 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7739 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7740 (xbm_read_bitmap_data): Change locals back to 'int', since
7741 their values must fit in 'int'.
7742 (xpm_load_image, png_load, tiff_load):
7743 Invoke x_create_x_image_and_pixmap earlier,
7744 to avoid much needless work if the image is too large.
7745 (tiff_load): Treat overly large images as if
7746 x_create_x_image_and_pixmap failed, not as malloc failures.
7747 (gs_load): Use x_check_image_size.
7749 * gtkutil.c: Omit integer casts.
7750 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7751 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7753 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7755 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7756 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7757 would wrongly return t on a 64-bit host.
7759 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7760 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7761 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7762 and therefore cause GCC to emit a bogus diagnostic in some cases.
7764 * image.c: Integer signedness and overflow and related fixes.
7765 This is not an exhaustive set of fixes, but it's time to
7766 record what I've got.
7767 (lookup_pixel_color, check_image_size): Remove redundant decls.
7768 (check_image_size): Don't assume that arbitrary EMACS_INT values
7769 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7770 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7771 (tiff_load, imagemagick_load_image):
7772 Check for overflow in size calculations.
7773 (x_create_x_image_and_pixmap): Remove unnecessary test for
7774 xmalloc returning NULL; that can't happen.
7775 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7776 (xpm_color_bucket): Use better integer hashing function.
7777 (xpm_cache_color): Don't possibly over-allocate memory.
7778 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7779 (gif_memory_source):
7780 Use ptrdiff_t, not int or size_t, to record sizes.
7781 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7782 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7783 either works, as we prefer signed integers.
7784 (tiff_read_from_memory, tiff_write_from_memory):
7785 Return tsize_t, not size_t, since that's what the TIFF API wants.
7786 (tiff_read_from_memory): Don't fail simply because the read would
7787 go past EOF; instead, return a short read.
7788 (tiff_load): Omit no-longer-needed casts.
7789 (Fimagemagick_types): Don't assume size fits into 'int'.
7791 Improve hashing quality when configured --with-wide-int.
7792 * fns.c (hash_string): New function, taken from sxhash_string.
7793 Do not discard information about ASCII character case; this
7794 discarding is no longer needed.
7795 (sxhash-string): Use it. Change sig to match it. Caller changed.
7796 * lisp.h: Declare it.
7797 * lread.c (hash_string): Remove, since we now use fns.c's version.
7798 The fns.c version returns a wider integer if --with-wide-int is
7799 specified, so this should help the quality of the hashing a bit.
7801 * emacs.c: Integer overflow minor fix.
7802 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7803 Define only if GNU_LINUX.
7804 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7806 * dispnew.c: Integer signedness and overflow fixes.
7807 Remove unnecessary forward decls, that were a maintenance hassle.
7808 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7810 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7811 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7812 (prepare_desired_row, line_draw_cost):
7813 Use int, not unsigned, where either works.
7814 (save_current_matrix, restore_current_matrix):
7815 Use ptrdiff_t, not size_t, where either works.
7816 (init_display): Check for overflow more accurately, and without
7817 relying on undefined behavior.
7819 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7820 Remove, replacing with the new symbols in lisp.h. All uses changed.
7821 * fileio.c (make_temp_name):
7822 * filelock.c (lock_file_1, lock_file):
7823 * xdisp.c (message_dolog):
7824 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7825 Use pMd etc. instead.
7826 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7827 replacing the pWIDE etc. symbols removed from editfns.c.
7829 * keyboard.h (num_input_events): Now uintmax_t.
7830 This is (very slightly) less likely to mess up due to wraparound.
7833 * buffer.c: Integer signedness fixes.
7834 (alloc_buffer_text, enlarge_buffer_text):
7835 Use ptrdiff_t rather than size_t when either will do, as we prefer
7838 * alloc.c: Integer signedness and overflow fixes.
7839 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7840 (__malloc_size_t): Default to size_t, not to int.
7841 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7842 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7843 Prefer ptrdiff_t to size_t when either would do, as we prefer
7845 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7846 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7847 Now const. Initialize with values that are in range even if char
7849 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7850 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7851 These functions do the right thing with sizes > 2**32.
7852 (check_depth): Now ptrdiff_t, not int.
7853 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7854 Adjust to new way of storing sizes. Check for size overflow bugs
7856 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7857 slightly wrong anyway, as it missed one instance of
7858 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7859 (refill_memory_reserve): Omit needless cast to size_t.
7860 (mark_object_loop_halt): Mark as externally visible.
7862 * xselect.c: Integer signedness and overflow fixes.
7863 (Fx_register_dnd_atom, x_handle_dnd_message):
7864 Use ptrdiff_t, not size_t, since we prefer signed.
7865 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7866 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7867 x_dnd_atoms_size and x_dnd_atoms_length.
7869 * doprnt.c: Prefer signed to unsigned when either works.
7871 * doprnt.c (doprnt):
7873 * xdisp.c (vmessage):
7874 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7875 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7876 prefer signed arithmetic to avoid comparison confusion.
7877 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7878 but is a bit tricky.
7880 Assume freestanding C89 headers, string.h, stdlib.h.
7881 * data.c, doprnt.c, floatfns.c, print.c:
7882 Include float.h unconditionally.
7883 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7884 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7885 * regex.c: Likewise for stddef.h, string.h.
7886 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7887 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7888 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7889 (STDC_HEADERS): Remove obsolete defines.
7890 * sysdep.c: Include limits.h unconditionally.
7892 Assume support for memcmp, memcpy, memmove, memset.
7893 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7894 * regex.c (memcmp, memcpy):
7895 Remove; we assume C89 now.
7897 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7898 (__malloc_safe_bcopy): Remove; no longer needed.
7900 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7901 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7902 well either way, and we prefer signed to unsigned.
7904 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7906 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7907 closes the connection while we're reading (bug#9182).
7909 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7911 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7912 are specified (Bug#9168).
7914 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7916 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7917 Found by GCC static checking and --with-wide-int on a 32-bit host.
7919 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7921 * xdisp.c (compute_display_string_pos): Fix logic of caching
7922 previous display string position. Initialize cached_prev_pos to
7923 -1. Fixes slow-down at the beginning of a buffer.
7925 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7927 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7928 for attrs[LFACE_FONTSET_INDEX].
7930 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7932 * xml.c (parse_region): Remove unused local
7933 that was recently introduced.
7935 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7937 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7938 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7940 * xdisp.c (move_it_in_display_line_to): Record the best matching
7941 position for TO_CHARPOS while scanning the line, and restore it on
7942 exit if none of the characters scanned was an exact match.
7943 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7944 when exact match is impossible due to invisible text, and the
7945 lines are truncated.
7947 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7949 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7952 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7954 Fix a significant slow-down of cursor motion with C-n, C-p,
7955 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7956 auto-repeat under bidi redisplay in fontified buffers.
7957 * xdisp.c (compute_stop_pos_backwards): New function.
7958 (next_element_from_buffer): Call compute_stop_pos_backwards to
7959 find a suitable prev_stop when we find ourselves before
7961 (reseat): Don't look for prev_stop, as that could mean a very long
7963 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7964 <cached_disp_overlay_modiff>: Cache for last found display string
7966 (compute_display_string_pos): Return the cached position if asked
7967 about the same buffer in the same area of character positions, and
7968 the buffer wasn't changed since the time the display string
7969 position was cached.
7971 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7973 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7974 is an integer, which is important for empty lines. (Bug#9149)
7976 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7978 * frame.c (Fmodify_frame_parameters): In tty case, update the
7979 default face if necessary (Bug#4238).
7981 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7983 * editfns.c (Fstring_to_char): No need to explain what a character
7984 is in the docstring (Bug#6576).
7986 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7988 * xml.c (parse_region): Make sure we always return a tree.
7990 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7992 * xml.c (parse_region): If a document contains only comments,
7995 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7997 * xml.c (make_dom): Return comments, too.
7999 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8002 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8003 and the surrounding thread.
8004 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8005 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8006 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8008 * s/openbsd.h (BROKEN_SIGIO): Define.
8009 * unexelf.c (unexec) [__OpenBSD__]:
8010 Don't update the .mdebug section of the Alpha COFF symbol table.
8012 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8014 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8017 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8019 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8020 This fixes some race conditions on the permissions of any newly
8023 * alloc.c (valid_pointer_p): Use pipe, not open.
8024 This fixes some permissions issues when debugging.
8026 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8027 If fchown fails to set both uid and gid, try to set just gid,
8028 as that is sometimes allowed. Adjust the file's mode to eliminate
8029 setuid or setgid bits that are inappropriate if fchown fails.
8031 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8033 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8034 to compare Lisp_Objects.
8035 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8036 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8037 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8039 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8041 * lread.c (read_integer): Unread even EOF character.
8042 (read1): Likewise. Properly record start position of symbol.
8044 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8045 symbol character follows.
8047 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8049 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8050 This works around a problem with the previous change to Fcopy_file.
8051 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8052 and without this change, GCC might complain about discarding
8053 fchown's return value.
8055 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8057 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8059 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8061 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8063 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8065 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8066 it's used from the C level.
8068 * process.c: Use the same condition for POLL_FOR_INPUT in both
8069 keyboard.c and process.c (bug#1858).
8071 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8073 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8074 (Fgnutls_boot): Use it.
8076 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8078 * doc.c (Fsubstitute_command_keys): Revert last change.
8080 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8082 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8083 quotes the next character, and doesn't affect other longer
8084 sequences (bug#8935).
8086 * lread.c (syms_of_lread): Clarify that is isn't only
8087 `eval-buffer' and `eval-defun' that's affected by
8088 `lexical-binding' (bug#8460).
8090 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8092 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8093 bidi redisplay when a line includes both an image and is truncated.
8095 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8097 Fix minor problems found by static checking.
8098 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8099 (elsz): Now a signed constant, not a size_t var. We prefer signed
8100 types to unsigned, to avoid integer comparison confusion. Without
8101 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8102 "cannot optimize loop, the loop counter may overflow", a symptom
8104 * indent.c (Fvertical_motion): Mark locals as initialized.
8105 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8107 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8109 * search.c (Fre_search_backward): Mention `case-fold-search' in
8110 all the re_search_* functions (bug#8138).
8112 * keyboard.c (Fopen_dribble_file): Document when the file is
8115 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8117 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8120 Support bidi reordering of display and overlay strings.
8121 * xdisp.c (compute_display_string_pos)
8122 (compute_display_string_end): Accept additional argument STRING.
8123 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8124 (reseat_to_string): Initialize bidi_it->string.s and
8125 bidi_it->string.schars.
8126 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8127 NULL (avoids a crash in bidi_paragraph_init).
8128 Initialize itb.string.lstring.
8129 (init_iterator): Call bidi_init_it only of a valid
8130 buffer position was specified. Initialize paragraph_embedding to
8132 (reseat_to_string): Initialize the bidi iterator.
8133 (display_string): If we need to ignore text properties of
8134 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8135 original value of -1 will not work with bidi.)
8136 (compute_display_string_pos): First arg is now struct
8137 `text_pos *'; all callers changed. Support display properties on
8139 (compute_display_string_end): Support display properties on Lisp
8141 (init_iterator, reseat_1, reseat_to_string): Initialize the
8142 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8143 when iterating on a string not from display properties).
8144 (compute_display_string_pos, compute_display_string_end):
8145 Fix calculation of the object to scan. Fixes an error when using
8147 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8148 base_level_stop; instead, set base_level_stop to BEGV.
8149 Fixes crashes in vertical-motion.
8150 (next_element_from_buffer): Improve commentary for when
8151 the iterator is before prev_stop.
8152 (init_iterator): Initialize bidi_p from the default value of
8153 bidi-display-reordering, not from buffer-local value. Use the
8154 buffer-local value only if initializing for buffer iteration.
8155 (handle_invisible_prop): Support invisible properties on strings
8156 that are being bidi-reordered.
8157 (set_iterator_to_next): Support bidi reordering of C strings and
8159 (next_element_from_string): Support bidi reordering of Lisp
8161 (handle_stop_backwards): Support Lisp strings as well.
8162 (display_string): Support display of R2L glyph rows.
8163 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8164 (init_iterator): Don't initialize it->bidi_p for strings
8166 (reseat_to_string): Initialize it->bidi_p for strings here.
8167 (next_element_from_string, next_element_from_c_string)
8168 (next_element_from_buffer): Add xassert's for correspondence
8169 between IT's object being iterated and it->bidi_it.string
8171 (face_before_or_after_it_pos): Support bidi iteration.
8172 (next_element_from_c_string): Handle the case of the first string
8173 character that is not the first one in the visual order.
8174 (get_visually_first_element): New function, refactored from common
8175 parts of next_element_from_buffer, next_element_from_string, and
8176 next_element_from_c_string.
8177 (tool_bar_lines_needed, redisplay_tool_bar)
8178 (display_menu_bar): Force left-to-right direction. Add a FIXME
8179 comment for making that be controlled by a user option.
8180 (push_it, pop_it): Save and restore the state of the
8181 bidi iterator. Save and restore the bidi_p flag.
8182 (pop_it): Iterate out of display property for string iteration as
8184 (iterate_out_of_display_property): Support iteration over strings.
8185 (handle_single_display_spec): Set up it->bidi_it for iteration
8186 over a display string, and call bidi_init_it.
8187 (handle_single_display_spec, next_overlay_string)
8188 (get_overlay_strings_1, push_display_prop): Set up the bidi
8189 iterator for displaying display or overlay strings.
8190 (forward_to_next_line_start): Don't use the shortcut if
8192 (back_to_previous_visible_line_start): If handle_display_prop
8193 pushed the iterator stack, restore the internal state of the bidi
8194 iterator by calling bidi_pop_it same number of times.
8195 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8196 and we are bidi-iterating, don't decrement the iterator position;
8197 instead, set the first_elt flag in the bidi iterator, to produce
8199 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8200 (push_display_prop): xassert that we are iterating a buffer.
8201 (push_it, pop_it): Save and restore paragraph_embedding member.
8202 (handle_single_display_spec, next_overlay_string)
8203 (get_overlay_strings_1, reseat_1, reseat_to_string)
8204 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8205 correctly. Don't assume unibyte strings are not bidi-reordered.
8206 (compute_display_string_pos)
8207 (compute_display_string_end): Fix handling the case of C string.
8208 (push_it, pop_it): Save and restore from_disp_prop_p.
8209 (handle_single_display_spec, push_display_prop): Set the
8210 from_disp_prop_p flag.
8211 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8212 (pop_it): Call iterate_out_of_display_property only if we are
8213 popping after iteration over a string that came from a display
8214 property. Fix a typo in popping stretch info. Add an assertion
8215 for verifying that the iterator position is in sync with the bidi
8217 (handle_single_display_spec, get_overlay_strings_1)
8218 (push_display_prop): Fix initialization of paragraph direction for
8219 string when that of the parent object is not yet determined.
8220 (reseat_1): Call bidi_init_it to resync the bidi
8221 iterator with IT's position. (Bug#7616)
8222 (find_row_edges): If ROW->start.pos gives position
8223 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8224 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8225 Reset the from_disp_prop_p flag.
8226 (SAVE_IT, RESTORE_IT): New macros.
8227 (pos_visible_p, face_before_or_after_it_pos)
8228 (back_to_previous_visible_line_start)
8229 (move_it_in_display_line_to, move_it_in_display_line)
8230 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8231 (try_scrolling, redisplay_window, display_line): Use them when
8232 saving a temporary copy of the iterator and restoring it back.
8233 (back_to_previous_visible_line_start, reseat_1)
8234 (init_iterator): Empty the bidi cache "stack".
8235 (move_it_in_display_line_to): If iterator ended up at
8236 EOL, but we never saw any buffer positions smaller than
8237 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8238 motion in bidi-reordered lines.
8239 (move_it_in_display_line_to): Record prev_method and prev_pos
8240 immediately before the call to set_iterator_to_next. Fixes cursor
8241 motion in bidi-reordered lines with stretch glyphs and strings
8242 displayed in margins. (Bug#8133) (Bug#8867)
8243 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8245 (pos_visible_p): Support positions in bidi-reordered lines.
8246 Save and restore bidi cache.
8248 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8249 (bidi_paragraph_info): Delete unused struct.
8250 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8251 (bidi_cache_start): New variable.
8252 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8254 (bidi_cache_fetch_state, bidi_cache_search)
8255 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8256 (bidi_cache_find, bidi_peek_at_next_level)
8257 (bidi_level_of_next_char, bidi_find_other_level_edge)
8258 (bidi_move_to_visually_next): Compare cache index with
8259 bidi_cache_start rather than with zero.
8260 (bidi_fetch_char): Accept new argument STRING; all callers
8261 changed. Support iteration over a string. Support strings with
8262 display properties. Support unibyte strings. Fix the type of
8263 `len' according to what STRING_CHAR_AND_LENGTH expects.
8264 (bidi_paragraph_init, bidi_resolve_explicit_1)
8265 (bidi_resolve_explicit, bidi_resolve_weak)
8266 (bidi_level_of_next_char, bidi_move_to_visually_next):
8267 Support iteration over a string.
8268 (bidi_set_sor_type, bidi_resolve_explicit_1)
8269 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8270 can now be zero (for strings); special values 0 and -1 were
8271 changed to -1 and -2, respectively.
8272 (bidi_char_at_pos): New function.
8273 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8274 Call it instead of FETCH_MULTIBYTE_CHAR.
8275 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8276 initialized to valid values.
8277 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8279 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8280 the test for valid cached positions. Fix the logic for looking up
8281 the sentinel state in the cache. GCPRO the Lisp string we are
8283 (bidi_push_it, bidi_pop_it): New functions.
8284 (bidi_initialize): Initialize the bidi cache start stack pointer.
8285 (bidi_cache_ensure_space): New function, refactored from part of
8286 bidi_cache_iterator_state. Don't assume the required size is just
8287 one BIDI_CACHE_CHUNK away.
8288 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8289 (bidi_count_bytes, bidi_char_at_pos): New functions.
8290 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8291 always valid if bidi_cache_idx is valid.
8292 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8293 is valid if it's going to be used.
8294 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8295 (bidi_cache_fetch_state, bidi_cache_search)
8296 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8297 (bidi_cache_iterator_state, bidi_cache_find)
8298 (bidi_find_other_level_edge, bidi_cache_start_stack):
8299 All variables related to cache indices are now EMACS_INT.
8301 * dispextern.h (struct bidi_string_data): New structure.
8302 (struct bidi_it): New member `string'. Make flag members be 1-bit
8303 fields, and put them last in the struct.
8304 (compute_display_string_pos, compute_display_string_end):
8306 (bidi_push_it, bidi_pop_it): Add prototypes.
8307 (struct iterator_stack_entry): New members bidi_p,
8308 paragraph_embedding, and from_disp_prop_p.
8309 (struct it): Member bidi_p is now a bit field 1 bit wide.
8310 (bidi_shelve_cache, bidi_unshelve_cache):
8313 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8314 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8315 and vector-like objects.
8317 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8318 cache around display iteration.
8320 * window.c (Fwindow_end, window_scroll_pixel_based)
8321 (displayed_window_lines, Frecenter): Save and restore the bidi
8322 cache around display iteration.
8324 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8326 * editfns.c (Fdelete_region): Clarify the use of the named
8327 parameters (bug#6788).
8329 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8331 * indent.c (Fvertical_motion): Set and restore w->pointm when
8332 saving and restoring the window's buffer (Bug#9006).
8334 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8336 * editfns.c (Fstring_to_char): Clarify just what is returned
8337 (bug#6576). Text by Eli Zaretskii.
8339 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8341 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8343 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8345 * buffer.c (mmap_find): Fix a typo.
8347 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8349 Fix execution of x selection hooks.
8350 * xselect.c (Qx_lost_selection_functions)
8351 (Qx_sent_selection_functions): New vars.
8352 (syms_of_xselect): DEFSYM them.
8353 (x_handle_selection_request): Pass Qx_sent_selection_functions
8354 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8355 (x_handle_selection_clear,x_clear_frame_selections):
8356 Pass Qx_lost_selection_functions rather than
8357 Vx_lost_selection_functions to Frun_hook_with_args.
8359 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8361 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8362 The old code sometimes used this field without initializing it.
8364 * alloc.c (gc_sweep): Don't read past end of array.
8365 In theory, the old code could also have corrupted Emacs internals,
8366 though it'd be very unlikely.
8368 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8370 * character.c (Fcharacterp): Don't advertise optional ignored
8371 argument. (Bug#4026)
8373 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8375 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8378 * window.c (Fset_window_start): Doc fix (bug#4199).
8379 (Fset_window_hscroll): Ditto.
8381 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8383 Fix minor new problems caught by GCC 4.6.1.
8384 * term.c (init_tty): Remove unused local.
8385 * xsettings.c (store_monospaced_changed): Define this function only
8386 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8389 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8391 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8393 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8395 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8396 are the mini-buffer and the echo area (bug#3320).
8398 * term.c (init_tty): Remove support for supdup, c10 and perq
8399 terminals, which are no longer supported (bug#1482).
8401 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8403 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8405 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8407 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8408 for non-popups (Bug#3642).
8410 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8412 * alloc.c (reset_malloc_hooks): Protoize.
8413 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8414 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8415 * cm.c (losecursor): Likewise.
8416 * data.c (fmod): Likewise.
8417 * dispnew.c (swap_glyphs_in_rows): Likewise.
8418 * emacs.c (memory_warning_signal): Likewise.
8419 * floatfns.c (float_error): Likewise.
8420 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8421 (otf_open, font_otf_capability, generate_otf_features)
8422 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8424 * image.c (pbm_read_file): Likewise.
8425 * indent.c (string_display_width): Likewise.
8426 * intervals.c (check_for_interval, search_for_interval)
8427 (inc_interval_count, count_intervals, root_interval)
8428 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8429 * lread.c (defalias): Likewise.
8430 * ralloc.c (r_alloc_check): Likewise.
8431 * regex.c (set_image_of_range_1, set_image_of_range)
8432 (regex_grow_registers): Likewise.
8433 * sysdep.c (strerror): Likewise.
8434 * termcap.c (valid_filename_p, tprint, main): Likewise.
8435 * tparam.c (main): Likewise.
8436 * unexhp9k800.c (run_time_remap, save_data_space)
8437 (update_file_ptrs, read_header, write_header, calculate_checksum)
8438 (copy_file, copy_rest, display_header): Likewise.
8439 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8441 * xdisp.c (check_it): Likewise.
8442 * xfaces.c (register_color, unregister_color, unregister_colors):
8444 * xfns.c (print_fontset_result): Likewise.
8445 * xrdb.c (member, fatal, main): Likewise.
8447 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8449 Fix minor problems found by static checking (Bug#9031).
8450 * chartab.c (char_table_set_range, map_sub_char_table):
8451 Remove unused locals.
8452 (uniprop_table): Now static.
8453 * composite.c (_work_char): Remove unused static var.
8455 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8457 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8459 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8461 * gtkutil.c (qttip_cb): Remove code without function.
8463 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8465 * w32.c (pthread_sigmask): New stub.
8467 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8469 Use pthread_sigmask, not sigprocmask (Bug#9010).
8470 sigprocmask is portable only for single-threaded applications, and
8471 Emacs can be multi-threaded when it uses GTK.
8472 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8474 * callproc.c (Fcall_process):
8475 * process.c (create_process):
8476 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8477 Use pthread_sigmask, not sigprocmask.
8479 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8481 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8482 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8485 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8487 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8488 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8489 (xg_hide_tooltip): Fix comment.
8491 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8492 in registerServicesMenuSendTypes.
8493 (validRequestorForSendType): Don't check ns_return_types.
8495 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8498 2011-07-08 Jason Rumney <jasonr@gnu.org>
8500 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8501 SH_SHOW for hidden windows (Bug#5482).
8503 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8504 frame struct members of non-existent frames (Bug#6284).
8506 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8508 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8509 variable firstTime not needed on OSX >= 10.6.
8510 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8511 >= 10.5. Use setKnobProportion, setDoubleValue.
8513 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8514 (MAC_OS_X_VERSION_10_5): Define if not defined.
8515 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8516 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8517 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8519 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8520 cString and lossyCString on OSX >= 10.4.
8522 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8523 sizeToFit on OSX >= 10.2.
8525 * nsimage.m (allocInitFromFile): Don't use deprecated method
8526 bestRepresentationForDevice on OSX >= 10.6.
8528 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8531 * emacs.c: Declare unexec_init_emacs_zone.
8533 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8535 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8537 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8538 on svcsMenu (Bug#8842).
8540 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8542 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8544 * nsterm.m (QUTF8_STRING): Declare.
8545 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8546 (validRequestorForSendType): Return type is (id).
8547 Change indexOfObjectIdenticalTo to indexOfObject.
8548 Check if we have local selection before returning self (Bug#8842).
8549 (writeSelectionToPasteboard): Put local selection into paste board
8550 if we have a local selection (Bug#8842).
8551 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8553 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8554 (ns_get_local_selection): Declare.
8556 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8558 * keymap.c (describe_map_tree): Don't insert a double newline at
8559 the end of the buffer (bug#1169) and return whether we inserted
8562 * callint.c (Fcall_interactively): Change "reading args" to
8563 "providing args" to try to clarify what it does (bug#1010).
8565 2011-07-07 Kenichi Handa <handa@m17n.org>
8567 * composite.c (composition_compute_stop_pos): Ignore a static
8568 composition starting before CHARPOS (Bug#8915).
8570 * xdisp.c (handle_composition_prop): Likewise.
8572 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8574 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8577 2011-07-07 Kenichi Handa <handa@m17n.org>
8579 * character.h (unicode_category_t): New enum type.
8581 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8582 (Qchar_code_property_table): New variable.
8583 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8584 (UNIPROP_COMPRESSED_FORM_P): New macros.
8585 (char_table_ascii): Uncompress the compressed values.
8586 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8587 Uncompress the compressed values.
8588 (sub_char_table_ref_and_range): Likewise.
8589 (char_table_ref_and_range): Uncompress the compressed values.
8590 (sub_char_table_set): New arg is_uniprop. Callers changed.
8591 Uncompress the compressed values.
8592 (sub_char_table_set_range): Args changed. Callers changed.
8593 (char_table_set_range): Adjuted for the above change.
8594 (map_sub_char_table): Delete args default_val and parent. Add arg
8595 top. Give decoded values to a Lisp function.
8596 (map_char_table): Adjust for the above change. Give decoded
8597 values to a Lisp function. Gcpro more variables.
8598 (uniprop_table_uncompress)
8599 (uniprop_decode_value_run_length): New functions.
8600 (uniprop_decoder, uniprop_decoder_count): New variables.
8601 (uniprop_get_decoder, uniprop_encode_value_character)
8602 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8604 (uniprop_encoder, uniprop_encoder_count): New variables.
8605 (uniprop_get_encoder, uniprop_table)
8606 (Funicode_property_table_internal, Fget_unicode_property_internal)
8607 (Fput_unicode_property_internal): New functions.
8608 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8609 Sunicode_property_table_internal, Sget_unicode_property_internal,
8610 and Sput_unicode_property_internal. Defvar_lisp
8611 char-code-property-alist.
8613 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8614 Vunicode_category_table.
8616 * font.c (font_range): Adjust for the change of
8617 Vunicode_category_table.
8619 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8621 * m/iris4d.h: Remove file, move contents ...
8622 * s/irix6-5.h: ... here.
8624 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8626 Remove unportable assumption about struct layout (Bug#8884).
8627 * alloc.c (mark_buffer):
8628 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8629 (clone_per_buffer_values): Don't assume that
8630 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8631 This isn't true in general, and it's particularly not true
8632 if Emacs is configured with --with-wide-int.
8633 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8634 New macros, used in the buffer.c change.
8636 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8638 * xsettings.c: Use both GConf and GSettings if both are available.
8639 (store_config_changed_event): Add comment.
8640 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8641 (store_tool_bar_style_changed): New functions.
8642 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8643 (struct xsettings): Move font inside HAVE_XFT.
8644 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8645 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8646 Move inside HAVE_XFT.
8647 (something_changed_gsettingsCB): Rename from something_changedCB.
8648 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8650 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8651 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8652 (something_changed_gconfCB): Rename from something_changedCB.
8653 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8654 (parse_settings): Move check for font inside HAVE_XFT.
8655 (read_settings, apply_xft_settings): Add comment.
8656 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8657 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8658 call store_font_name_changed.
8659 (xft_settings_event): Add comment.
8660 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8661 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8662 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8663 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8664 (xsettings_initialize): Call init_gsettings last.
8665 (xsettings_get_system_font, xsettings_get_system_normal_font):
8668 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8670 Random fixes. E.g., (random) never returned negative values.
8671 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8672 subseconds part to the entropy, as that's a bit more random.
8673 Prefer signed to unsigned, since the signedness doesn't matter and
8674 in general we prefer signed. When given a limit, use a
8675 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8676 latter isn't right if USE_2_TAGS_FOR_INTS.
8677 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8678 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8680 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8682 * textprop.c (text_property_stickiness):
8683 Obey Vtext_property_default_nonsticky.
8684 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8685 * w32fns.c (syms_of_w32fns):
8686 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8688 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8690 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8691 This is more efficient than Ffile_directory_p and avoids a minor race.
8693 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8695 * buffer.c (Foverlay_put): Say what the return value is
8698 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8699 is a directory before asking whether to use the file name
8701 (barf_or_query_if_file_exists): Make the "File is a directory"
8702 error be more correct.
8704 * fns.c (Frequire): Remove the mention of the .gz files, since
8705 that's installation-specific, but keep the mention of
8706 `get-load-suffixes'.
8708 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8710 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8711 Report string overflow if the output is too long.
8713 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8715 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8716 (syms_of_gnutls): Remove duplicate DEFSYM for
8717 Qgnutls_bootprop_verify_hostname_error, an error for
8718 Qgnutls_bootprop_verify_error (which is no longer used).
8720 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8721 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8722 Also (re)move comments that are misplaced or no longer relevant.
8724 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8726 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8728 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8730 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8731 and background color parameters if they have been changed.
8733 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8735 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8737 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8739 * xsettings.c (SYSTEM_FONT): Define only when used.
8740 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8742 * keymap.c (access_keymap_1): Now static.
8744 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8746 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8747 leave any prefix arg for the up event (Bug#1586).
8749 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8751 * lread.c (syms_of_lread): Mention single symbols defined by
8752 `defvar' or `defconst' (bug#7154).
8754 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8755 (Frequire): Mention get-load-suffixes.
8757 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8759 * window.h (window): Remove clone_number slot.
8760 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8762 (make_parent_window, make_window, saved_window)
8763 (Fset_window_configuration, save_window_save): Don't deal with
8765 * buffer.c (Qclone_number): Remove declaration.
8766 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8768 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8770 Add multiple inheritance to keymaps.
8771 * keymap.c (Fmake_composed_keymap): New function.
8772 (Fset_keymap_parent): Simplify.
8773 (fix_submap_inheritance): Remove.
8774 (access_keymap_1): New function extracted from access_keymap to handle
8775 embedded parents and handle lists of maps.
8776 (access_keymap): Use it.
8777 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8778 (Fcopy_keymap): Handle embedded parents.
8779 (Fcommand_remapping, define_as_prefix): Simplify.
8780 (Fkey_binding): Simplify.
8781 (syms_of_keymap): Move minibuffer-local-completion-map,
8782 minibuffer-local-filename-completion-map,
8783 minibuffer-local-must-match-map, and
8784 minibuffer-local-filename-must-match-map to Elisp.
8785 (syms_of_keymap): Defsubr make-composed-keymap.
8786 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8787 (parse_menu_item): Trivial simplification.
8789 2011-07-01 Glenn Morris <rgm@gnu.org>
8791 * Makefile.in (SETTINGS_LIBS): Fix typo.
8793 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8795 * coding.c (Fencode_coding_string): Record the last coding system
8796 used, as the function doc string says (bug#8738).
8798 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8800 * xsettings.c (store_monospaced_changed): Take new font as arg and
8801 check for change against current_mono_font.
8802 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8803 (emacs_settings_constructor, emacs_settings_get_property)
8804 (emacs_settings_set_property, emacs_settings_class_init)
8805 (emacs_settings_init, gsettings_obj): Remove.
8806 (something_changedCB): New function for HAVE_GSETTINGS.
8807 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8808 with value as argument.
8809 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8810 g_settings_new (Bug#8967). Do not create gsettings_obj.
8811 Remove calls to g_settings_bind. Connect something_changedCB to
8814 * xgselect.c: Add defined (HAVE_GSETTINGS).
8815 (xgselect_initialize): Ditto.
8817 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8818 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8821 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8823 * eval.c (struct backtrace): Simplify and port the data structure.
8824 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8825 signed bit field, as this assumption is not portable and it makes
8826 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8827 "char debug_on_exit : 1" as this is not portable either; instead,
8828 use the portable "unsigned int debug_on_exit : 1". Remove unused
8829 member evalargs. Remove obsolete comments about cc bombing out.
8831 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8833 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8834 Let HAVE_GSETTINGS override HAVE_GCONF.
8835 (store_monospaced_changed): New function.
8836 (EMACS_SETTINGS): A new type derived from GObject to handle
8837 GSettings notifications.
8838 (emacs_settings_constructor, emacs_settings_get_property)
8839 (emacs_settings_set_property, emacs_settings_class_init):
8841 (gsettings_client, gsettings_obj): New variables.
8842 (GSETTINGS_SCHEMA): New define.
8843 (something_changedCB): Call store_monospaced_changed.
8844 (init_gsettings): New function.
8845 (xsettings_initialize): Call init_gsettings.
8846 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8849 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8852 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8854 * window.c (resize_root_window, grow_mini_window)
8855 (shrink_mini_window): Rename Qresize_root_window to
8856 Qwindow_resize_root_window and Qresize_root_window_vertically to
8857 Qwindow_resize_root_window_vertically.
8859 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8861 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8863 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8865 * makefile.w32-in: Redesign dependencies so they reflect more
8866 clearly which files are directly included by each source file,
8867 and not through other includes.
8869 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8871 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8872 (sort_overlays, overlay_strings): When an overlay's clone number
8873 matches the window's clone number process the overlay even if
8874 the overlay's window property doesn't match the current window.
8876 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8877 (Fwindow_hchild): Rename to Fwindow_left_child.
8878 (Fwindow_next): Rename to Fwindow_next_sibling.
8879 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8880 (resize_window_check): Rename to window_resize_check.
8881 (resize_window_apply): Rename to window_resize_apply.
8882 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8883 (Fdelete_other_windows_internal, resize_frame_windows)
8884 (Fsplit_window_internal, Fdelete_window_internal)
8885 (grow_mini_window, shrink_mini_window)
8886 (Fresize_mini_window_internal): Fix callers accordingly.
8888 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8890 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8891 (emacs_fixed_set_min_size): Remove.
8892 (emacs_fixed_new): Take frame as argument.
8894 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8895 (_EmacsFixedPrivate): Remove minwidth/height.
8896 Add struct frame *f.
8897 (emacs_fixed_init): Initialize priv->f.
8898 (get_parent_class, emacs_fixed_set_min_size): Remove.
8899 (emacs_fixed_new): Set priv->f to argument.
8900 (emacs_fixed_get_preferred_width)
8901 (emacs_fixed_get_preferred_height): Use min_width/height from
8902 frames size_hint to set minimum and natural (Bug#8919).
8903 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8904 and use min_width/height from frames size_hint to set
8905 min_width/height (Bug#8919).
8907 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8908 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8911 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8913 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8914 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8917 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8919 * process.c (wait_reading_process_output): Bypass select if
8920 waiting for a cell while ignoring keyboard input, and input is
8921 pending. Suggested by Jan Djärv (Bug#8869).
8923 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8925 Use gnulib's dup2 module instead of rolling our own.
8926 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8928 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8930 * dispnew.c (scrolling_window): Before scrolling, turn off a
8931 mouse-highlight in the window being scrolled.
8933 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8935 Move DEFSYM to lisp.h and use everywhere.
8937 * character.h (DEFSYM): Move declaration...
8938 * lisp.h (DEFSYM): ...here.
8944 * w32select.c: Don't include character.h.
8946 * alloc.c (syms_of_alloc):
8947 * buffer.c (syms_of_buffer):
8948 * bytecode.c (syms_of_bytecode):
8949 * callint.c (syms_of_callint):
8950 * casefiddle.c (syms_of_casefiddle):
8951 * casetab.c (init_casetab_once):
8952 * category.c (init_category_once, syms_of_category):
8953 * ccl.c (syms_of_ccl):
8954 * cmds.c (syms_of_cmds):
8955 * composite.c (syms_of_composite):
8956 * dbusbind.c (syms_of_dbusbind):
8957 * dired.c (syms_of_dired):
8958 * dispnew.c (syms_of_display):
8959 * doc.c (syms_of_doc):
8960 * editfns.c (syms_of_editfns):
8961 * emacs.c (syms_of_emacs):
8962 * eval.c (syms_of_eval):
8963 * fileio.c (syms_of_fileio):
8964 * fns.c (syms_of_fns):
8965 * frame.c (syms_of_frame):
8966 * fringe.c (syms_of_fringe):
8967 * insdel.c (syms_of_insdel):
8968 * keymap.c (syms_of_keymap):
8969 * lread.c (init_obarray, syms_of_lread):
8970 * macros.c (syms_of_macros):
8971 * msdos.c (syms_of_msdos):
8972 * print.c (syms_of_print):
8973 * process.c (syms_of_process):
8974 * search.c (syms_of_search):
8975 * sound.c (syms_of_sound):
8976 * syntax.c (init_syntax_once, syms_of_syntax):
8977 * terminal.c (syms_of_terminal):
8978 * textprop.c (syms_of_textprop):
8979 * undo.c (syms_of_undo):
8980 * w32.c (globals_of_w32):
8981 * window.c (syms_of_window):
8982 * xdisp.c (syms_of_xdisp):
8983 * xfaces.c (syms_of_xfaces):
8984 * xfns.c (syms_of_xfns):
8985 * xmenu.c (syms_of_xmenu):
8986 * xsettings.c (syms_of_xsettings):
8987 * xterm.c (syms_of_xterm): Use DEFSYM.
8989 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8991 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8993 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8995 Integer and buffer overflow fixes (Bug#8873).
8997 * print.c (printchar, strout): Check for string overflow.
8998 (PRINTPREPARE, printchar, strout):
8999 Don't set size unless allocation succeeds.
9001 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9002 for sizes. Check for string overflow more accurately.
9003 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9005 * macros.c: Integer and buffer overflow fixes.
9006 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9007 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9008 Use ptrdiff_t, not int, for sizes.
9009 Don't increment bufsize until after realloc succeeds.
9010 Check for size-calculation overflow.
9011 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9013 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9015 * lread.c: Integer overflow fixes.
9016 (read_integer): Radix is now EMACS_INT, not int,
9017 to improve quality of diagnostics for out-of-range radices.
9018 Calculate buffer size correctly for out-of-range radices.
9019 (read1): Check for integer overflow in radices, and in
9020 read-circle numbers.
9021 (read_escape): Avoid int overflow.
9022 (Fload, openp, read_buffer_size, read1)
9023 (substitute_object_recurse, read_vector, read_list, map_obarray):
9024 Use ptrdiff_t, not int, for sizes.
9025 (read1): Use EMACS_INT, not int, for sizes.
9026 Check for size overflow.
9028 * image.c (cache_image): Check for size arithmetic overflow.
9030 * lread.c: Integer overflow issues.
9031 (saved_doc_string_size, saved_doc_string_length)
9032 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9033 Now ptrdiff_t, not int.
9034 (read1): Don't assume doc string length fits in int. Check for
9035 out-of-range doc string lengths.
9036 (read_list): Don't assume file position fits in int.
9037 (read_escape): Check for hex character overflow.
9039 2011-06-22 Leo Liu <sdl.web@gmail.com>
9041 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9042 Move to minibuffer.el.
9044 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9046 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9047 The following patches are for when GLYPH_DEBUG && !XASSERT.
9048 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9049 * dispnew.c (flush_stdout):
9050 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9051 Mark as externally visible.
9052 * dispnew.c (check_window_matrix_pointers): Now static.
9053 * dispnew.c (window_to_frame_vpos):
9054 * xfns.c (unwind_create_frame):
9055 * xterm.c (x_check_font): Remove unused local.
9056 * scroll.c (CHECK_BOUNDS):
9057 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9058 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9059 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9060 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9061 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9063 (debug_method_add): Use va_list and vsprintf rather than relying
9064 on undefined behavior with wrong number of arguments.
9065 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9066 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9067 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9068 since we're not interested in debugging glyphs with old libraries.
9069 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9070 GCC 4.6.0's static checking.
9072 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9074 Integer overflow and signedness fixes (Bug#8873).
9075 A few related buffer overrun fixes, too.
9077 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9079 * dispextern.h (struct face.stipple):
9080 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9081 (x_bitmap_mask, x_allocate_bitmap_record)
9082 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9083 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9084 (x_create_bitmap_from_xpm_data):
9085 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9086 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9088 * xfaces.c (load_pixmap):
9089 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9090 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9091 (.bitmaps_last, struct x_output.icon_bitmap):
9092 Use ptrdiff_t, not int, for bitmap indexes.
9093 (x_allocate_bitmap_record): Check for size overflow.
9094 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9096 Use ptrdiff_t, not int, for overlay counts.
9097 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9098 * editfns.c (overlays_around, get_pos_property):
9099 * textprop.c (get_char_property_and_overlay):
9100 * xdisp.c (next_overlay_change, note_mouse_highlight):
9101 * xfaces.c (face_at_buffer_position):
9102 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9103 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9104 (Fnext_overlay_change, Fprevious_overlay_change)
9105 (mouse_face_overlay_overlaps, Foverlays_in):
9106 Use ptrdiff_t, not int, for sizes.
9107 (overlays_at, overlays_in): Check for size-calculation overflow.
9109 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9111 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9112 (x_session_initialize): Do not assume string length fits in int.
9114 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9115 This is unlikely, but can occur if DPI is outlandish.
9117 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9118 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9120 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9121 * xrdb.c (magic_file_p, search_magic_path):
9122 Omit last arg SUFFIX; it was always 0. All callers changed.
9123 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9125 * xfont.c (xfont_match): Avoid need for strlen.
9127 * xfns.c: Don't assume strlen fits in int.
9128 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9130 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9131 not unsigned long, as we prefer signed integers. All callers changed.
9132 Detect integer overflow in repeat count.
9133 (message_dolog): Don't assume print length fits in 39 bytes.
9134 (display_mode_element): Don't assume strlen fits in int.
9136 * termcap.c: Don't assume sizes fit in int and never overflow.
9137 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9138 (gobble_line): Check for size-calculation overflow.
9140 * minibuf.c (Fread_buffer):
9141 * lread.c (intern, intern_c_string):
9142 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9143 Don't assume string length fits in int.
9145 * keyboard.c (parse_tool_bar_item):
9146 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9148 * font.c: Don't assume string length fits in int.
9149 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9150 Use ptrdiff_t, not int.
9151 (font_intern_prop): Don't assume string length fits in int.
9152 Don't assume integer property fits in fixnum.
9153 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9155 * filelock.c: Fix some buffer overrun and integer overflow issues.
9156 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9157 Reformulate so as not to need the command string.
9158 Invoke gzip -cd rather than gunzip, as it's more portable.
9159 (lock_info_type, lock_file_1, lock_file):
9160 Don't assume pid_t and time_t fit in unsigned long.
9161 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9162 (current_lock_owner): Prefer signed type for sizes.
9163 Use memcpy, not strncpy, where memcpy is what is really wanted.
9164 Don't assume (via atoi) that time_t and pid_t fit in int.
9165 Check for time_t and/or pid_t out of range, e.g., via a network share.
9166 Don't alloca where an auto var works fine.
9168 * fileio.c: Fix some integer overflow issues.
9169 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9170 Don't assume string length fits in int.
9171 (directory_file_name): Don't assume string length fits in long.
9172 (make_temp_name): Don't assume pid fits in int, or that its print
9173 length is less than 20.
9175 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9177 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9179 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9181 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9182 We prefer signed integers, even for size calculations.
9184 * emacs.c: Don't assume string length fits in 'int'.
9185 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9186 (main): Don't invoke strlen when not needed.
9188 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9189 (XD_DEBUG_MESSAGE): Don't waste a byte.
9191 * callproc.c (getenv_internal_1, getenv_internal)
9193 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9195 * lread.c (invalid_syntax): Omit length argument.
9196 All uses changed. This doesn't fix a bug, but it simplifies the
9197 code away from its former Hollerith-constant appearance, and it's
9198 one less 'int' to worry about when looking at integer-overflow issues.
9199 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9201 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9202 This didn't break anything, but it didn't help either.
9203 It's confusing to put a bogus integer in a place where the actual
9204 value does not matter.
9205 (LIST_END_P): Remove unused macro and its bogus comment.
9206 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9208 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9209 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9211 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9212 We prefer signed types, and the value cannot exceed the EMACS_INT
9213 range anyway (because otherwise the length would not be representable).
9214 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9215 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9216 This avoids a GCC warning when WIDE_EMACS_INT.
9218 * indent.c (sane_tab_width): New function.
9219 (current_column, scan_for_column, Findent_to, position_indentation)
9220 (compute_motion): Use it. This is just for clarity.
9221 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9223 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9225 * lisp.h (lint_assume): New macro.
9226 * composite.c (composition_gstring_put_cache):
9227 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9229 * editfns.c, insdel.c:
9230 Omit unnecessary forward decls, to simplify future changes.
9232 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9234 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9236 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9237 Use much-faster test for byte-length change.
9238 Don't assume string byte-length fits in 'int'.
9239 Check that character arg fits in 'int'.
9240 (mapcar1): Declare byte as byte, for clarity.
9242 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9244 * fns.c (concat): Catch string overflow earlier.
9245 Do not rely on integer wraparound.
9247 * dispextern.h (struct it.overlay_strings_charpos)
9248 (struct it.selective): Now EMACS_INT, not int.
9249 * xdisp.c (forward_to_next_line_start)
9250 (back_to_previous_visible_line_start)
9251 (reseat_at_next_visible_line_start, next_element_from_buffer):
9252 Don't arbitrarily truncate the value of 'selective' to int.
9254 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9256 * composite.c: Don't truncate sizes to 'int'.
9257 (composition_gstring_p, composition_reseat_it)
9258 (composition_adjust_point): Use EMACS_INT, not int.
9259 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9260 not EMACS_UINT, for indexes.
9262 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9264 * buffer.c: Include <verify.h>.
9265 (struct sortvec.priority, struct sortstr.priority):
9266 Now EMACS_INT, not int.
9267 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9268 (struct sortstr.size, record_overlay_string)
9269 (struct sortstrlist.size, struct sortlist.used):
9270 Don't truncate size to int.
9271 (record_overlay_string): Check for size-calculation overflow.
9272 (init_buffer_once): Check at compile-time, not run-time.
9274 2011-06-22 Jim Meyering <meyering@redhat.com>
9276 Don't leak an XBM-image-sized buffer
9277 * image.c (xbm_load): Free the image buffer after using it.
9279 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9282 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9283 that Sun C diagnosed.
9284 * fns.c (secure_hash): Fix pointer signedness issue.
9285 * intervals.c (static_offset_intervals): New function.
9286 (offset_intervals): Use it.
9288 2011-06-21 Leo Liu <sdl.web@gmail.com>
9291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9294 * fns.c (secure_hash): Rename from crypto_hash_function and change
9295 the first arg to accept symbols.
9296 (Fsecure_hash): New primitive.
9297 (syms_of_fns): New symbols.
9299 2011-06-20 Deniz Dogan <deniz@dogan.se>
9301 * process.c (Fset_process_buffer): Clarify return value in
9304 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9306 * dispnew.c (add_window_display_history): Use BVAR.
9308 * xdisp.c (debug_method_add): Use BVAR.
9309 (check_window_end, dump_glyph_matrix, dump_glyph)
9310 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9312 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9315 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9316 check till after the cache is created in init_frame_faces.
9318 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9320 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9322 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9324 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9325 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9326 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9328 Improve buffer-overflow checking (Bug#8873).
9329 * fileio.c (Finsert_file_contents):
9330 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9331 Remove the old (too-loose) buffer overflow checks.
9332 They weren't needed, since make_gap checks for buffer overflow.
9333 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9334 The old code merely checked for Emacs fixnum overflow, and relied
9335 on undefined (wraparound) behavior. The new code avoids undefined
9336 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9338 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9339 Tune. Don't use wider integers than needed. Don't use alloca.
9340 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9342 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9344 * insdel.c, lisp.h (buffer_overflow): New function.
9345 (insert_from_buffer_1, replace_range, replace_range_2):
9346 * insdel.c (make_gap_larger):
9347 * editfns.c (Finsert_char):
9348 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9350 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9352 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9354 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9356 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9357 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9359 * fileio.c: Don't assume EMACS_INT fits in off_t.
9360 (emacs_lseek): New static function.
9361 (Finsert_file_contents, Fwrite_region): Use it.
9362 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9364 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9366 * fns.c: Don't overflow int when computing a list length.
9367 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9368 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9369 truncation on 64-bit hosts. Check for QUIT every
9370 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9371 faster and is responsive enough.
9372 (Flength): Report an error instead of overflowing an integer.
9373 (Fsafe_length): Return a float if the value is not representable
9374 as a fixnum. This shouldn't happen except in contrived situations.
9375 (Fnthcdr, Fsort): Don't assume list length fits in int.
9376 (Fcopy_sequence): Don't assume vector length fits in int.
9378 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9379 (header_size, word_size): New constants.
9380 (allocate_vectorlike): Don't check size overflow here.
9381 (allocate_vector): Check it here instead, since this is the only
9382 caller of allocate_vectorlike that could cause overflow.
9383 Check that the new vector's length is representable as a fixnum.
9385 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9386 The previous code was bogus. For example, next_almost_prime (32)
9387 returned 39, which is undesirable as it is a multiple of 3; and
9388 next_almost_prime (24) returned 25, which is a multiple of 5 so
9389 why was the code bothering to check for multiples of 7?
9391 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9393 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9395 Variadic C functions now count arguments with ptrdiff_t.
9396 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9397 Back then I didn't know that the Emacs coding style prefers signed int.
9398 Also, in the meantime I found a few more instances where arguments
9399 were being counted with int, which may truncate counts on 64-bit
9400 machines, or EMACS_INT, which may be unnecessarily wide.
9401 * lisp.h (struct Lisp_Subr.function.aMANY)
9402 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9403 Arg counts are now ptrdiff_t, not size_t.
9404 All variadic functions and their callers changed accordingly.
9405 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9406 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9407 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9408 * callint.c (Fcall_interactively): Check arg count for overflow,
9409 to avoid potential buffer overrun. Use signed char, not 'int',
9410 for 'varies' array, so that we needn't bother to check its size
9411 calculation for overflow.
9412 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9413 * eval.c (apply_lambda):
9414 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9415 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9416 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9418 * callint.c (Fcall_interactively): Don't use index var as event count.
9420 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9421 * mem-limits.h (SIZE): Remove; no longer used.
9423 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9425 Remove unnecessary casts.
9426 * xterm.c (x_term_init):
9427 * xfns.c (x_set_border_pixel):
9428 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9429 These aren't needed now that we assume ANSI C.
9431 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9432 It's more likely to cause problems (due to unsigned overflow)
9435 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9437 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9439 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9441 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9443 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9445 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9447 GLYPH_CODE_FACE returns EMACS_INT, not int.
9448 * dispextern.h (merge_faces):
9449 * xfaces.c (merge_faces):
9450 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9451 Don't assume EMACS_INT fits in int.
9453 * character.h (CHAR_VALID_P): Remove unused parameter.
9454 * fontset.c, lisp.h, xdisp.c: All uses changed.
9456 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9458 * fns.c (concat): Minor tuning based on overflow analysis.
9459 This doesn't fix any bugs. Use int to hold character, instead
9460 of constantly refetching from Emacs object. Use XFASTINT, not
9461 XINT, for value known to be a character. Don't bother comparing
9462 a single byte to 0400, as it's always less.
9464 * floatfns.c (Fexpt):
9465 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9467 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9470 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9472 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9473 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9474 incorrectly succeed when S was a string, because 4294967386 was
9475 truncated before it was used.
9477 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9478 Otherwise, an out-of-range integer could cause undefined behavior
9481 * composite.c: Use int, not EMACS_INT, for characters.
9482 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9483 EMACS_INT, for values that are known to be in character range.
9484 This doesn't fix any bugs but is the usual style inside Emacs and
9485 may generate better code on 32-bit machines.
9487 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9488 This is for reasons similar to the recent CHAR_STRING fix.
9489 * charset.c (Fencode_char): Check that character arg is actually
9490 a character. Pass an int to ENCODE_CHAR.
9491 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9492 wider than 'int', as a compile-time check to prevent future regressions
9495 * character.c (char_string): Remove unnecessary casts.
9497 Make sure a 64-bit char is never passed to CHAR_STRING.
9498 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9499 by silently ignoring the top 32 bits, allowing some values
9500 that were far too large to be valid characters.
9501 * character.h: Include <verify.h>.
9502 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9503 arguments are no wider than unsigned, as a compile-time check
9504 to prevent future regressions in this area.
9506 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9507 (Fsubst_char_in_region):
9509 * xdisp.c (decode_mode_spec_coding):
9510 Adjust to CHAR_STRING's new requirement.
9511 * editfns.c (Finsert_char, Fsubst_char_in_region):
9512 * fns.c (concat): Check that character args are actually
9513 characters. Without this test, these functions did the wrong
9514 thing with wildly out-of-range values on 64-bit hosts.
9516 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9517 These casts should not be needed on 32-bit hosts, either.
9518 * keyboard.c (read_char):
9519 * lread.c (Fload): Remove casts to unsigned.
9521 * lisp.h (UNSIGNED_CMP): New macro.
9522 This fixes comparison bugs on 64-bit hosts.
9523 (ASCII_CHAR_P): Use it.
9524 * casefiddle.c (casify_object):
9525 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9526 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9527 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9528 * dispextern.h (FACE_FROM_ID):
9529 * keyboard.c (read_char): Use UNSIGNED_CMP.
9531 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9532 not to EMACS_INT, to avoid GCC warning.
9534 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9536 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9537 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9538 isn't needed on 32-bit machines.
9540 * buffer.c (Fgenerate_new_buffer_name):
9541 Use EMACS_INT for count, not int.
9542 (advance_to_char_boundary): Return EMACS_INT, not int.
9544 * data.c (Qcompiled_function): Now static.
9546 * window.c (window_body_lines): Now static.
9548 * image.c (gif_load): Rename local to avoid shadowing.
9550 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9551 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9552 * alloc.c (make_save_value): Integer argument is now of type
9554 (mark_object): Use ptrdiff_t, not int.
9555 * lisp.h (pD): New macro.
9556 * print.c (print_object): Use it.
9558 * alloc.c: Use EMACS_INT, not int, to count objects.
9559 (total_conses, total_markers, total_symbols, total_vector_size)
9560 (total_free_conses, total_free_markers, total_free_symbols)
9561 (total_free_floats, total_floats, total_free_intervals)
9562 (total_intervals, total_strings, total_free_strings):
9563 Now EMACS_INT, not int. All uses changed.
9564 (Fgarbage_collect): Compute overall total using a double, so that
9565 integer overflow is less likely to be a problem. Check for overflow
9566 when converting back to an integer.
9567 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9568 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9569 These were 'int' variables that could overflow on 64-bit hosts;
9570 they were never used, so remove them instead of repairing them.
9571 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9572 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9573 Previously, this ceilinged at INT_MAX, but that doesn't work on
9575 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9577 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9578 (allocate_vectorlike): Check for ptrdiff_t overflow.
9579 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9580 when a (possibly-narrower) signed value would do just as well.
9581 We prefer using signed arithmetic, to avoid comparison confusion.
9583 * alloc.c: Catch some string size overflows that we were missing.
9584 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9585 for convenience in STRING_BYTES_MAX.
9586 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9587 The definition here is exact; the one in lisp.h was approximate.
9588 (allocate_string_data): Check for string overflow. This catches
9589 some instances we weren't catching before. Also, it catches
9590 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9591 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9592 and ptrdiff_t and EMACS_INT are both 64 bits.
9594 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9595 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9596 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9598 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9600 * alloc.c (Fmake_string): Check for out-of-range init.
9602 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9604 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9606 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9608 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9609 xg_get_default_scrollbar_width.
9611 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9612 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9613 (style_changed_cb): Call update_theme_scrollbar_width and call
9614 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9615 all frames (Bug#8505).
9616 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9617 Call gtk_window_set_resizable if HAVE_GTK3.
9618 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9619 and height if HAVE_GTK3 (Bug#8505).
9620 (scroll_bar_width_for_theme): New variable.
9621 (update_theme_scrollbar_width): New function.
9622 (xg_get_default_scrollbar_width): Move code to
9623 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9624 (xg_initialize): Call update_theme_scrollbar_width.
9626 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9628 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9630 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9632 * frame.c (make_frame): Call other_buffer_safely instead of
9635 * window.c (temp_output_buffer_show): Call display_buffer with
9636 second argument Vtemp_buffer_show_specifiers and reset latter
9637 immediately after the call.
9638 (Vtemp_buffer_show_specifiers): New variable.
9639 (auto_window_vscroll_p, next_screen_context_lines)
9640 (Vscroll_preserve_screen_position): Remove leading asterisks from
9643 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9645 Fix minor problems found by GCC 4.6.0 static checking.
9646 * buffer.c (Qclone_number): Remove for now, as it's unused.
9647 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9648 (record_buffer): Remove unused local.
9649 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9650 (set_frame_buffer_list): Remove; unused.
9651 * frame.h (other_visible_frames): Remove decl.
9652 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9653 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9654 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9656 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9657 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9658 Define only if HAVE_GPM.
9659 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9660 (update_hints_inhibit): Remove; never set. All uses removed.
9661 * widgetprv.h (emacsFrameClassRec): Remove decl.
9662 * window.c (delete_deletable_window): Now returns void, since it
9663 wasn't returning anything.
9664 (compare_window_configurations): Remove unused locals.
9665 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9666 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9667 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9668 the same widths as pointers. This follows up on the 2011-05-06 patch.
9669 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9670 * xterm.h: Likewise.
9671 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9673 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9675 * makefile.w32-in: Update dependencies.
9676 (LISP_H): Add lib/intprops.h.
9678 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9680 * image.c (gif_load): Add animation frame delay to the metadata.
9681 (syms_of_image): Use DEFSYM. New symbol `delay'.
9683 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9685 * window.c (delete_deletable_window): Re-add.
9686 (Fset_window_configuration): Rewrite to handle dead buffers and
9687 consequently deletable windows.
9688 (window_tree, Fwindow_tree): Remove. Supply functionality in
9690 (compare_window_configurations): Simplify code.
9692 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9694 * image.c (imagemagick_load_image): Fix type mismatch.
9695 (Fimagemagick_types): Likewise.
9697 * window.h (replace_buffer_in_windows): Declare.
9699 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9701 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9702 Qclone_number. Remove external declaration of Qdelete_window.
9703 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9705 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9706 Run Qbuffer_list_update_hook if allowed.
9707 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9708 buffer list implementation.
9709 (other_buffer_safely): New function.
9710 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9711 calls to replace_buffer_in_windows and
9712 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9714 (record_buffer): Inhibit quitting and rewrite using quittable
9715 functions. Run Qbuffer_list_update_hook if allowed.
9716 (Frecord_buffer, Funrecord_buffer): New functions.
9717 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9718 Move switch-to-buffer to window.el.
9719 (bury-buffer): Move to window.el.
9720 (Vbuffer_list_update_hook): New variable.
9722 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9725 * window.h (resize_frame_windows): Move up in code.
9726 (Fwindow_frame): Remove EXFUN.
9727 (replace_buffer_in_all_windows): Remove prototype.
9728 (replace_buffer_in_windows_safely): Add prototype.
9730 * window.c: Declare Qdelete_window static again. Move down
9731 declaration of select_count.
9732 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9733 (Fother_window): Move to window.el.
9734 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9735 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9736 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9738 (replace_buffer_in_windows): Implement by calling
9739 Qreplace_buffer_in_windows.
9740 (replace_buffer_in_all_windows): Remove with some functionality
9741 moved into replace_buffer_in_windows_safely.
9742 (replace_buffer_in_windows_safely): New function.
9743 (select_window_norecord, select_frame_norecord): Move in front
9744 of run_window_configuration_change_hook. Remove now obsolete
9746 (Fset_window_buffer): Rewrite doc-string.
9747 Call Qrecord_window_buffer.
9748 (keys_of_window): Move binding for other-window to window.el.
9750 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9752 * dispextern.h (struct image): Replace data member, whose int_val
9753 and ptr_val fields were not used by anything, with a single
9756 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9757 (gif_clear_image, gif_load, imagemagick_load_image)
9758 (gs_clear_image, gs_load): Callers changed.
9760 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9762 * buffer.h: Include <time.h>, for time_t.
9763 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9765 Fix minor problems found by static checking.
9767 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9769 Make identifiers static if they are not used in other modules.
9770 * data.c (Qcompiled_function, Qframe, Qvector):
9771 * image.c (QimageMagick, Qsvg):
9772 * minibuf.c (Qmetadata):
9773 * window.c (resize_window_check, resize_root_window): Now static.
9774 * window.h (resize_window_check, resize_root_window): Remove decls.
9776 * window.c (window_deletion_count, delete_deletable_window):
9778 (window_body_lines): Now static.
9779 (Fdelete_other_windows_internal): Mark vars as initialized.
9780 Make sure 'resize_failed' is initialized.
9781 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9782 (resize_window_apply): Remove unused local.
9783 * window.h (delete_deletable_window): Remove decl.
9785 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9786 (imagemagick_load_image): Fix pointer signedness problem by changing
9787 last arg from unsigned char * to char *. All uses changed.
9788 Also, fix a local for similar reasons.
9789 Remove unused locals. Remove locals to avoid shadowing.
9790 (fn_rsvg_handle_free): Remove; unused.
9791 (svg_load, svg_load_image): Fix pointer signedness problem.
9792 (imagemagick_load_image): Don't use garbage pointer image_wand.
9794 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9796 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9798 * image.c (gif_load): Fix omitted cast error introduced by
9801 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9803 * window.h (resize_proportionally, orig_total_lines)
9804 (orig_top_line): Remove from window structure.
9805 (set_window_height, set_window_width, change_window_heights)
9806 (Fdelete_window): Remove prototypes.
9807 (resize_frame_windows): Remove duplicate declaration.
9809 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9811 * window.h (resize_frame_windows, resize_window_check)
9812 (delete_deletable_window, resize_root_window)
9813 (resize_frame_windows): Declare prototypes.
9815 * window.c (resize_window_apply): Make definition be "static" to
9816 match the prototype.
9818 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9820 * window.c: Remove declarations of Qwindow_size_fixed,
9821 window_min_size_1, window_min_size_2, window_min_size,
9822 size_window, window_fixed_size_p, enlarge_window, delete_window.
9823 Remove static from declaration of Qdelete_window, it's
9824 temporarily needed by Fbury_buffer.
9825 (replace_window): Don't assign orig_top_line and
9827 (Fdelete_window, delete_window): Remove. Window deletion is
9828 handled by window.el.
9829 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9830 Replace Fdelete_window calls with calls to Qdelete_window.
9831 (Fdelete_other_windows): Remove. Deleting other windows is
9832 handled by window.el.
9833 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9834 handled in window.el.
9835 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9836 Window minimum sizes are handled in window.el.
9837 (shrink_windows, size_window, set_window_height)
9838 (set_window_width, change_window_heights, window_height)
9839 (window_width, CURBEG, CURSIZE, enlarge_window)
9840 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9841 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9842 handled in window.el.
9843 (make_dummy_parent): Rename to make_parent_window and give it a
9844 second argument horflag.
9845 (make_window): Don't set resize_proportionally any more.
9846 (Fsplit_window): Remove. Windows are split in window.el.
9847 (save_restore_action, save_restore_orig_size)
9848 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9849 Resize mini windows in window.el.
9850 (grow_mini_window, shrink_mini_window): Implement by calling
9851 Qresize_root_window_vertically, resize_window_check and
9852 resize_window_apply.
9853 (saved_window, Fset_window_configuration, save_window_save):
9854 Do not handle orig_top_line, orig_total_lines, and
9855 resize_proportionally.
9856 (window_min_height, window_min_width): Move to window.el.
9857 (keys_of_window): Move bindings for delete-other-windows,
9858 split-window, delete-window and enlarge-window to window.el.
9860 * buffer.c: Temporarily extern Qdelete_window.
9861 (Fbury_buffer): Temporarily call Qdelete_window instead of
9862 Fdelete_window (Fbury_buffer will move to window.el soon).
9864 * frame.c (set_menu_bar_lines_1): Remove code handling
9865 orig_top_line and orig_total_lines.
9867 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9868 set_window_height but set heights directly.
9869 (change_frame_size_1): Use resize_frame_windows.
9871 * xdisp.c (init_xdisp): Don't use set_window_height but set
9874 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9875 Use resize_frame_windows instead of change_window_heights and run
9876 run_window_configuration_change_hook.
9878 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9879 instead of change_window_heights and run
9880 run_window_configuration_change_hook.
9882 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9884 * window.c (replace_window): Rename second argument REPLACEMENT to
9885 NEW. New third argument SETFLAG. Rewrite.
9886 (delete_window, make_dummy_parent): Call replace_window with
9888 (window_list_1): Move down in code.
9889 (run_window_configuration_change_hook): Move set_buffer part
9890 before select_frame_norecord part in order to unwind correctly.
9891 Rename count1 to count.
9892 (recombine_windows, delete_deletable_window, resize_root_window)
9893 (Fdelete_other_windows_internal)
9894 (Frun_window_configuration_change_hook, make_parent_window)
9895 (resize_window_check, resize_window_apply, Fresize_window_apply)
9896 (resize_frame_windows, Fsplit_window_internal)
9897 (Fdelete_window_internal, Fresize_mini_window_internal):
9899 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9901 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9903 * window.h (window): Add some new members to window structure -
9904 normal_lines, normal_cols, new_total, new_normal, clone_number,
9905 splits, nest, prev_buffers, next_buffers.
9906 (WINDOW_TOTAL_SIZE): Move here from window.c.
9907 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9909 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9911 (make_dummy_parent): Set new members of windows structure.
9912 (make_window): Move down in code. Handle new members of window
9914 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9915 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9916 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9917 (Fset_window_prev_buffers, Fwindow_next_buffers)
9918 (Fset_window_next_buffers, Fset_window_clone_number):
9920 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9921 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9923 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9924 Argument WINDOW can be now internal window too.
9925 (Fwindow_use_time): Move up in code.
9926 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9928 (Fset_window_configuration, saved_window)
9929 (Fcurrent_window_configuration, save_window_save): Handle new
9930 members of window structure.
9931 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9932 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9933 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9934 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9935 Qget_mru_window, Qresize_root_window,
9936 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9937 Qauto_buffer_name; staticpro them.
9939 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9941 * window.c (Fwindow_total_size, Fwindow_left_column)
9942 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9943 (Fwindow_list_1): New functions.
9944 (window_box_text_cols): Replace with window_body_cols.
9945 (Fwindow_width, Fscroll_left, Fscroll_right):
9946 Use window_body_cols instead of window_box_text_cols.
9947 (delete_window, Fset_window_configuration):
9948 Call delete_all_subwindows with window as argument.
9949 (delete_all_subwindows): Take a window as argument and not a
9951 (window_loop): Remove handling of GET_LRU_WINDOW and
9953 (Fget_lru_window, Fget_largest_window): Move to window.el.
9955 * window.h: Extern window_body_cols instead of
9956 window_box_text_cols. delete_all_subwindows now takes a
9957 Lisp_Object as argument.
9959 * indent.c (compute_motion, Fcompute_motion):
9960 Use window_body_cols instead of window_box_text_cols.
9962 * frame.c (delete_frame): Call delete_all_subwindows with root
9965 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9967 * fns.c (Fputhash): Document return value.
9969 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9971 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9973 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9975 Cons<->int and similar integer overflow fixes (Bug#8794).
9977 Check for overflow when converting integer to cons and back.
9978 * charset.c (Fdefine_charset_internal, Fdecode_char):
9979 Use cons_to_unsigned to catch overflow.
9980 (Fencode_char): Use INTEGER_TO_CONS.
9981 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9982 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9983 * data.c (long_to_cons, cons_to_long): Remove.
9984 (cons_to_unsigned, cons_to_signed): New functions.
9985 These signal an error for invalid or out-of-range values.
9986 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9987 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9988 * font.c (Ffont_variation_glyphs):
9989 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9990 * lisp.h: Include <intprops.h>.
9991 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9992 (cons_to_signed, cons_to_unsigned): New decls.
9993 (long_to_cons, cons_to_long): Remove decls.
9994 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9995 (Fprimitive_undo): Use CONS_TO_INTEGER.
9996 * xfns.c (Fx_window_property): Likewise.
9997 * xselect.c: Include <limits.h>.
9998 (x_own_selection, selection_data_to_lisp_data):
9999 Use INTEGER_TO_CONS.
10000 (x_handle_selection_request, x_handle_selection_clear)
10001 (x_get_foreign_selection, Fx_disown_selection_internal)
10002 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10003 (lisp_data_to_selection_data): Use cons_to_unsigned.
10004 (x_fill_property_data): Use cons_to_signed.
10005 Report values out of range.
10007 Check for buffer and string overflow more precisely.
10008 * buffer.h (BUF_BYTES_MAX): New macro.
10009 * lisp.h (STRING_BYTES_MAX): New macro.
10010 * alloc.c (Fmake_string):
10011 * character.c (string_escape_byte8):
10012 * coding.c (coding_alloc_by_realloc):
10013 * doprnt.c (doprnt):
10014 * editfns.c (Fformat):
10016 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10017 since they may not be the same number.
10018 * editfns.c (Finsert_char):
10019 * fileio.c (Finsert_file_contents):
10020 Likewise for BUF_BYTES_MAX.
10022 * image.c: Use ptrdiff_t, not int, for sizes.
10023 (slurp_file): Switch from int to ptrdiff_t.
10025 (slurp_file): Check that file size fits in both size_t (for
10026 malloc) and ptrdiff_t (for sanity and safety).
10028 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10029 if b->modtime has its maximal value.
10031 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10033 Don't assume time_t can fit into int.
10034 * buffer.h (struct buffer.modtime): Now time_t, not int.
10035 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10036 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10038 Minor fixes for signed vs unsigned integers.
10039 * character.h (MAYBE_UNIFY_CHAR):
10040 * charset.c (maybe_unify_char):
10041 * keyboard.c (read_char, reorder_modifiers):
10042 XINT -> XFASTINT, since the integer must be nonnegative.
10043 * ftfont.c (ftfont_spec_pattern):
10044 * keymap.c (access_keymap, silly_event_symbol_error):
10045 XUINT -> XFASTINT, since the integer must be nonnegative.
10046 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10047 since it makes no difference and we prefer signed.
10048 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10049 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10052 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10054 * window.h (Fwindow_frame): Declare.
10056 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10058 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10059 (SPARE_MEMORY): Always define.
10060 (LARGE_REQUEST): Remove.
10061 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10063 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10065 * lisp.h: Move EXFUNS for Fframe_root_window,
10066 Fframe_first_window and Fset_frame_selected_window to window.h.
10068 * window.h: Move EXFUNS for Fframe_root_window,
10069 Fframe_first_window and Fset_frame_selected_window here from
10072 * frame.c (Fwindow_frame, Fframe_first_window)
10073 (Fframe_root_window, Fframe_selected_window)
10074 (Fset_frame_selected_window): Move to window.c.
10075 (Factive_minibuffer_window): Move to minibuf.c.
10076 (Fother_visible_frames_p): New function.
10078 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10080 * window.c (decode_window, decode_any_window): Move up in code.
10081 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10082 (inhibit_frame_unsplittable): Remove unused variable.
10083 (Fwindow_buffer): Move up and rewrite doc-string.
10084 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10085 (Fwindow_prev): New functions.
10086 (Fwindow_frame): Move here from frame.c. Accept any window as
10088 (Fframe_root_window, Fframe_first_window)
10089 (Fframe_selected_window): Move here from frame.c. Accept frame
10090 or arbitrary window as argument. Update doc-strings.
10091 (Fminibuffer_window): Move up in code.
10092 (Fwindow_minibuffer_p): Move up in code and simplify.
10093 (Fset_frame_selected_window): Move here from frame.c.
10095 (Fselected_window, select_window, Fselect_window): Move up in
10096 code. Minor doc-string fixes.
10098 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10100 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10101 Do not assume that spare memory exists; that assumption is valid
10102 only if SYSTEM_MALLOC.
10103 (LARGE_REQUEST): New macro, so that the issue of large requests
10104 is separated from the issue of spare memory.
10106 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10108 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10111 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10113 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10116 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10118 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10120 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10122 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10123 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10125 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10127 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10129 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10131 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10132 (x_clipboard_manager_save): Add return value.
10133 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10134 New error handlers.
10135 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10136 Obey Vx_select_enable_clipboard_manager. Catch errors in
10137 x_clipboard_manager_save (Bug#8779).
10138 (Vx_select_enable_clipboard_manager): New variable.
10139 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10141 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10143 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10145 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10147 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10148 in the current matrix if keep_current_p is non-zero.
10150 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10152 * bidi.c (bidi_level_of_next_char): Fix last change.
10154 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10156 Support bidi reordering of text covered by display properties.
10158 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10159 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10160 (bidi_cache_search, bidi_cache_iterator_state)
10161 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10162 (bidi_level_of_next_char, bidi_move_to_visually_next):
10163 Support character positions inside a run of characters covered by a
10165 (bidi_paragraph_init, bidi_resolve_explicit_1)
10166 (bidi_level_of_next_char): Call bidi_fetch_char and
10167 bidi_fetch_char_advance instead of FETCH_CHAR and
10168 FETCH_CHAR_ADVANCE.
10169 (bidi_init_it): Initialize new members.
10170 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10172 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10173 instead of using explicit *_CHAR codes.
10174 (bidi_resolve_explicit, bidi_resolve_weak):
10175 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10176 bidirectional text is supported only in multibyte buffers.
10177 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10178 it to initialize the frame_window_p member of struct bidi_it.
10179 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10180 (bidi_resolve_explicit, bidi_resolve_weak)
10181 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10182 bidi_it->nchars is non-positive.
10183 (bidi_level_of_next_char): Don't try to lookup the cache for the
10184 next/previous character if nothing is cached there yet, or if we
10185 were just reseat()'ed to a new position.
10187 * xdisp.c (set_cursor_from_row): Set start and stop points
10188 according to the row's direction when priming the loop that looks
10189 for the glyph on which to display cursor.
10190 (single_display_spec_intangible_p): Function deleted.
10191 (display_prop_intangible_p): Reimplement to call
10192 handle_display_spec instead of single_display_spec_intangible_p.
10193 Accept 3 additional arguments needed by handle_display_spec.
10194 This fixes incorrect cursor motion across display property with complex
10195 values: lists, `(when COND...)' forms, etc.
10196 (single_display_spec_string_p): Support property values that are
10197 lists with the argument STRING its top-level element.
10198 (display_prop_string_p): Fix the condition for processing a
10199 property that is a list to be consistent with handle_display_spec.
10200 (handle_display_spec): New function, refactored from the
10201 last portion of handle_display_prop.
10202 (compute_display_string_pos): Accept additional argument
10203 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10204 value of a `display' property is a "replacing spec".
10205 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10206 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10207 the display property, but just return a value indicating whether
10208 the display property will replace the characters it covers.
10209 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10210 frame_window_p members of struct bidi_it.
10211 (compute_display_string_pos, compute_display_string_end):
10213 (push_it): Accept second argument POSITION, where pop_it should
10214 jump to continue iteration.
10215 (reseat_1): Initialize bidi_it.disp_pos.
10217 * keyboard.c (adjust_point_for_property): Adjust the call to
10218 display_prop_intangible_p to its new signature.
10220 * dispextern.h (struct bidi_it): New member frame_window_p.
10221 (bidi_init_it): Update prototypes.
10222 (display_prop_intangible_p): Update prototype.
10223 (compute_display_string_pos, compute_display_string_end):
10224 Declare prototypes.
10225 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10228 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10230 Malloc failure behavior now depends on size of allocation.
10231 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10232 * lisp.h: Change signatures accordingly.
10233 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10234 All callers changed. (Bug#8762)
10236 * gnutls.c: Use Emacs's memory allocators.
10237 Without this change, the gnutls library would invoke malloc etc.
10238 directly, which causes problems on non-SYNC_INPUT hosts, and which
10239 runs afoul of improving memory_full behavior. (Bug#8761)
10240 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10241 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10242 xfree instead of the default malloc, realloc, free.
10243 (Fgnutls_boot): No need to check for memory allocation failure,
10244 since xmalloc does that for us.
10246 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10247 * category.c (hash_get_category_set):
10248 * ccl.c (ccl_driver):
10249 * charset.c (Fdefine_charset_internal):
10250 * charset.h (struct charset.hash_index):
10251 * composite.c (get_composition_id, gstring_lookup_cache)
10252 (composition_gstring_put_cache):
10253 * composite.h (struct composition.hash_index):
10254 * dispextern.h (struct image.hash):
10255 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10256 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10257 (hashfn_equal, hashfn_user_defined, make_hash_table)
10258 (maybe_resize_hash_table, hash_lookup, hash_put)
10259 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10260 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10261 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10262 * image.c (make_image, search_image_cache, lookup_image)
10263 (xpm_put_color_table_h):
10264 * lisp.h (struct Lisp_Hash_Table):
10265 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10266 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10267 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10268 * alloc.c (allocate_vectorlike):
10269 Check for overflow in vector size calculations.
10270 * ccl.c (ccl_driver):
10271 Check for overflow when converting EMACS_INT to int.
10272 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10273 need to be updated by these changes.
10274 * fns.c (make_hash_table, maybe_resize_hash_table):
10275 Check for integer overflow with large hash tables.
10276 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10277 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10278 (SXHASH_REDUCE): New macro.
10279 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10280 Use it instead of discarding useful hash info with large hash values.
10281 (sxhash_float): New function.
10282 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10283 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10284 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10285 Rewrite to use FIXNUM_BITS, as this simplifies things.
10286 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10287 Adjust signatures to match updated version of code.
10288 (consing_since_gc): Now EMACS_INT, since a single hash table can
10289 use more than INT_MAX bytes.
10291 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10293 Make it possible to build with GCC-4.6+ -O2 -flto.
10295 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10297 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10299 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10300 Call minibuffer-inactive-mode.
10302 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10304 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10305 Update dependencies.
10307 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10309 * data.c (init_data): Remove code for UTS, this system is not
10312 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10314 Don't force ./temacs to start in terminal mode.
10316 * frame.c (make_initial_frame): Initialize faces in all cases, not
10317 only when CANNOT_DUMP is defined.
10318 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10320 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10322 * dispnew.c (add_window_display_history): Use const for the string
10323 pointer. Remove declaration, not needed.
10325 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10327 Use 'inline', not 'INLINE'.
10328 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10329 * alloc.c, fontset.c (INLINE): Remove.
10330 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10331 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10332 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10333 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10334 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10336 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10338 Make it possible to run ./temacs.
10340 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10341 syms_of_callproc does the same thing. Remove test for
10342 "initialized", do it in the caller.
10343 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10345 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10347 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10348 (read_minibuf): Use get_minibuffer.
10349 (syms_of_minibuf): Use DEFSYM.
10350 (Qmetadata): New var.
10351 * data.c (Qbuffer): Don't make it static.
10352 (syms_of_data): Use DEFSYM.
10354 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10356 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10357 (CCL_CODE_MIN): New macro.
10359 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10361 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10363 * eval.c (Qdebug): Now static.
10364 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10365 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10366 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10368 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10370 * image.c: Various fixes to ImageMagick code comments.
10371 (Fimagemagick_types): Doc fix.
10373 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10375 Minor fixes prompted by GCC 4.6.0 warnings.
10377 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10379 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10380 (x_clipboard_manager_save_all): Move extern decl to ...
10381 * xterm.h: ... here, so that it can be checked for consistency.
10383 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10385 * xselect.c (x_clipboard_manager_save_frame)
10386 (x_clipboard_manager_save_all): New functions.
10387 (Fx_clipboard_manager_save): Lisp function deleted.
10389 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10390 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10392 * xterm.h: Update prototype.
10394 2011-05-28 William Xu <william.xwl@gmail.com>
10396 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10397 exiting (Bug#8239).
10399 2011-05-28 Jim Meyering <meyering@redhat.com>
10401 Avoid a sign-extension bug in crypto_hash_function.
10402 * fns.c (to_uchar): Define.
10403 (crypto_hash_function): Use it to convert some newly-signed
10404 variables to unsigned, to avoid sign-extension bugs. For example,
10405 without this change, (md5 "truc") would evaluate to
10406 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10407 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10408 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10410 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10412 Integer overflow fixes.
10414 * dbusbind.c: Serial number integer overflow fixes.
10415 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10416 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10417 to hold a serial number that is too large for a fixnum.
10418 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10419 Check for serial numbers out of range. Decode any serial number
10420 that was so large that it became a float. (Bug#8722)
10422 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10423 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10424 Use XFASTINT rather than XUINT when numbers are nonnegative.
10425 (xd_append_arg, Fdbus_method_return_internal):
10426 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10427 arguments, check that Lisp number is nonnegative, rather than
10428 silently wrapping negative numbers around. (Bug#8722)
10429 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10432 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10434 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10436 ccl: Add integer overflow checks.
10437 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10438 (IN_INT_RANGE): New macros.
10439 (ccl_driver): Use them to check for integer overflow when
10440 decoding a CCL program. Many of the new checks are whether XINT (x)
10441 fits in int; it doesn't always, on 64-bit hosts. The new version
10442 doesn't catch all possible integer overflows, but it's an
10443 improvement. (Bug#8719)
10445 * alloc.c (make_event_array): Use XINT, not XUINT.
10446 There's no need for unsigned here.
10448 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10449 This follows up to the 2011-05-06 change that substituted uintptr_t
10450 for EMACS_INT. This case wasn't caught back then.
10452 Rework Fformat to avoid integer overflow issues.
10453 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10454 now (part of C89). Include <verify.h>.
10455 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10456 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10457 (Fformat): Avoid the prepass trying to compute sizes; it was only
10458 approximate and thus did not catch overflow reliably. Instead, walk
10459 through the format just once, formatting and computing sizes as we go,
10460 checking for integer overflow at every step, and allocating a larger
10461 buffer as needed. Keep track separately whether the format is
10462 multibyte. Keep only the most-recently calculated precision, rather
10463 than them all. Record whether each argument has been converted to
10464 string. Use EMACS_INT, not int, for byte and char and arg counts.
10465 Support field widths and precisions larger than INT_MAX. Avoid
10466 sprintf's undefined behavior with conversion specifications such as %#d
10467 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10468 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10469 formatting out-of-range floating point numbers with int
10470 formats. (Bug#8668)
10472 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10474 * data.c: Avoid integer truncation in expressions involving floats.
10475 * data.c: Include <intprops.h>.
10476 (arith_driver): When there's an integer overflow in an expression
10477 involving floating point, convert the integers to floating point
10478 so that the resulting value does not suffer from catastrophic
10479 integer truncation. For example, on a 64-bit host (* 4
10480 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10481 Do not rely on undefined behavior after integer overflow.
10483 merge count_size_as_multibyte, parse_str_to_multibyte
10484 * character.c, character.h (count_size_as_multibyte):
10485 Rename from parse_str_to_multibyte; all uses changed.
10486 Check for integer overflow.
10487 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10488 since it's now a duplicate of the other. This is more of
10489 a character than a buffer op, so better that it's in character.c.
10490 * fns.c, print.c: Adjust to above changes.
10492 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10494 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10496 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10498 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10499 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10500 (x_clipboard_manager_save): Now static.
10501 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10503 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10504 (crypto_hash_function): Now static.
10505 Fix pointer signedness problems. Avoid unnecessary initializations.
10507 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10509 * termhooks.h (Vselection_alist): Make it terminal-local.
10511 * terminal.c (create_terminal): Initialize it.
10513 * xselect.c: Support for clipboard managers.
10514 (Vselection_alist): Move to termhooks.h as terminal-local var.
10515 (LOCAL_SELECTION): New macro.
10516 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10517 (symbol_to_x_atom): Remove gratuitous arg.
10518 (x_handle_selection_request, lisp_data_to_selection_data)
10519 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10520 (x_own_selection, x_get_local_selection, x_convert_selection):
10521 New arg, specifying work frame. Use terminal-local Vselection_alist.
10522 (some_frame_on_display): Delete unused function.
10523 (Fx_own_selection_internal, Fx_get_selection_internal)
10524 (Fx_disown_selection_internal, Fx_selection_owner_p)
10525 (Fx_selection_exists_p): New optional frame arg.
10526 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10527 (x_handle_selection_clear): Don't treat other terminals with the
10528 same keyboard specially. Use the terminal-local Vselection_alist.
10529 (x_clear_frame_selections): Use Frun_hook_with_args.
10531 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10533 * xterm.h: Add support for those atoms.
10535 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10537 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10538 (converted_selections, conversion_fail_tag): New global variables.
10539 (x_selection_request_lisp_error): Free the above.
10540 (x_get_local_selection): Remove unnecessary code.
10541 (x_reply_selection_request): Args changed; handle arbitrary array
10542 of converted selections stored in converted_selections.
10543 Separate the XChangeProperty and SelectionNotify steps.
10544 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10545 (x_convert_selection): New function.
10546 (x_handle_selection_event): Simplify.
10547 (x_get_foreign_selection): Don't ignore incoming requests while
10548 waiting for an answer; this will fail when we implement
10549 SAVE_TARGETS, and seems unnecessary anyway.
10550 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10551 (Vx_sent_selection_functions): Doc fix.
10553 2011-05-26 Leo Liu <sdl.web@gmail.com>
10555 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10557 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10559 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10561 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10562 for fringe update if it has periodic bitmap.
10563 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10564 and fringe_bitmap_periodic_p.
10566 * fringe.c (get_fringe_bitmap_data): New function.
10567 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10568 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10569 row. Mark glyph row for fringe update if periodicity changed.
10571 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10572 for fringe update unless it has periodic bitmap.
10574 2011-05-25 Kenichi Handa <handa@m17n.org>
10576 * xdisp.c (get_next_display_element): Set correct it->face_id for
10577 a static composition.
10579 2011-05-24 Leo Liu <sdl.web@gmail.com>
10582 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10584 * fns.c (crypto_hash_function, Fsha1): New function.
10585 (Fmd5): Use crypto_hash_function.
10586 (syms_of_fns): Add Ssha1.
10588 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10590 * gnutls.c: Remove unused macros.
10591 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10592 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10593 Remove macros that are defined and never used.
10594 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10596 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10598 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10599 (Fx_get_selection_internal): Minor cleanup.
10600 (Fx_own_selection_internal): Rename arguments for consistency with
10603 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10605 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10607 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10609 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10611 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10613 * dispnew.c (scrolling_window): Don't exclude the case that the
10614 last enabled row in the desired matrix touches the bottom boundary.
10616 2011-05-21 Glenn Morris <rgm@gnu.org>
10618 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10619 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10620 and add some more files.
10622 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10624 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10625 report_file_error introduced by the change from 2011-05-07.
10627 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10629 * systime.h (Time): Define only if emacs is defined.
10630 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10631 where the include path doesn't have X11/X.h by default. See
10632 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10634 2011-05-20 Kenichi Handa <handa@m17n.org>
10636 * composite.c (find_automatic_composition): Fix previous change.
10638 2011-05-20 Glenn Morris <rgm@gnu.org>
10640 * lisp.mk: New file, split from Makefile.in.
10641 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10642 (shortlisp): Remove.
10643 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10645 2011-05-19 Glenn Morris <rgm@gnu.org>
10647 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10648 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10649 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10650 (lisp): Set the order to that of loadup.el.
10651 (shortlisp): Make it a copy of $lisp.
10652 (SOME_MACHINE_LISP): Remove.
10653 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10654 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10656 2011-05-18 Kenichi Handa <handa@m17n.org>
10658 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10659 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10660 (find_automatic_composition): Mostly rewrite for efficiency.
10662 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10664 * makefile.w32-in: Update dependencies.
10666 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10668 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10669 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10671 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10673 Fix some integer overflow issues, such as string length overflow.
10675 * insdel.c (count_size_as_multibyte): Check for string overflow.
10677 * character.c (lisp_string_width): Check for string overflow.
10678 Use EMACS_INT, not int, for string indexes and lengths; in
10679 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10680 the resulting string length overflows an EMACS_INT; instead,
10681 report a string overflow if no precision given. When checking for
10682 precision exhaustion, use a check that cannot possibly have
10683 integer overflow. (Bug#8675)
10684 * character.h (lisp_string_width): Adjust to new signature.
10686 * alloc.c (string_overflow): New function.
10687 (Fmake_string): Use it. This doesn't change behavior, but saves
10688 a few bytes and will simplify future changes.
10689 * character.c (string_escape_byte8): Likewise.
10690 * lisp.h (string_overflow): New decl.
10692 Fixups, following up to the user-interface timestamp change.
10693 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10694 for UI timestamps, instead of unsigned long.
10695 * msdos.c (mouse_get_pos): Likewise.
10696 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10697 * w32gui.h (Time): Define by including "systime.h" rather than by
10698 declaring it ourselves. (Bug#8664)
10700 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10701 * image.c (clear_image_cache): Likewise.
10703 * term.c (term_mouse_position): Don't assume time_t wraparound.
10705 Be more systematic about user-interface timestamps.
10706 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10707 and sometimes 'EMACS_UINT', to represent these timestamps.
10708 This change causes it to use 'Time' uniformly, as that's what X uses.
10709 This makes the code easier to follow, and makes it easier to catch
10710 integer overflow bugs such as Bug#8664.
10711 * frame.c (Fmouse_position, Fmouse_pixel_position):
10712 Use Time, not unsigned long, for user-interface timestamps.
10713 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10714 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10715 * keyboard.h (last_event_timestamp): Likewise.
10716 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10717 * menu.h (xmenu_show): Likewise.
10718 * term.c (term_mouse_position): Likewise.
10719 * termhooks.h (struct input_event.timestamp): Likewise.
10720 (struct terminal.mouse_position_hook): Likewise.
10721 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10722 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10723 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10724 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10725 what it was before.
10726 * menu.h, termhooks.h: Include "systime.h", for Time.
10728 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10729 Don't assume that the difference between two unsigned long values
10730 can fit into an integer. At this point, we know button_down_time
10731 <= event->timestamp, so the difference must be nonnegative, so
10732 there's no need to cast the result if double-click-time is
10733 nonnegative, as it should be; check that it's nonnegative, just in
10734 case. This bug is triggered when events are more than 2**31 ms
10735 apart (about 25 days). (Bug#8664)
10737 * xselect.c (last_event_timestamp): Remove duplicate decl.
10738 (x_own_selection): Remove needless cast to unsigned long.
10740 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10741 that always fit in int. Use a sentinel instead of a counter, to
10742 avoid a temp and to allay GCC's concerns about possible int overflow.
10743 * frame.h (struct frame): Use int for menu_bar_items_used
10744 instead of EMACS_INT, since it always fits in int.
10746 * menu.c (grow_menu_items): Check for int overflow.
10748 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10750 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10751 Before, the code was not consistent. These values cannot exceed
10752 2**31 - 1 so there's no need to make them unsigned.
10753 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10754 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10755 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10757 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10759 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10760 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10761 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10762 presumably because the widths might not match.
10764 * window.c (size_window): Avoid needless test at loop start.
10766 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10768 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10770 2011-05-12 Drew Adams <drew.adams@oracle.com>
10772 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10774 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10776 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10777 `width' to `bar_area_x' and `bar_area_width', respectively.
10778 (x_scroll_run): Take account of fringe background extension.
10780 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10781 Rename local vars `left' and `width' to `bar_area_x' and
10782 `bar_area_width', respectively.
10783 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10784 background extension.
10786 2011-05-10 Jim Meyering <meyering@redhat.com>
10788 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10790 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10792 * image.c (Finit_image_library): Return t for built-in image types,
10793 like pbm and xbm. (Bug#8640)
10795 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10797 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10799 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10801 * w32console.c (Fset_screen_color): Doc fix.
10802 (Fget_screen_color): New function.
10803 (syms_of_ntterm): Defsubr it.
10805 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10806 unlink the temporary file if Fcall_process didn't create it in the
10808 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10809 child process will be redirected to a file specified with `:file'.
10810 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10811 cue to call_process_cleanup not to close that handle.
10813 2011-05-07 Ben Key <bkey76@gmail.com>
10815 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10816 one of two shell specific rules, either bootstrap-temacs-CMD or
10817 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10818 to the previous implementation of the bootstrap-temacs rule.
10819 The bootstrap-temacs-CMD rule is similar to the previous
10820 implementation of the bootstrap-temacs rule except that it
10821 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10824 These changes, along with some changes to nt/configure.bat,
10825 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10826 earlier fix to add support for --cflags and --ldflags options
10827 that include quotes so that it works whether make uses cmd or
10830 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10832 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10833 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10835 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10836 a string. Handle both cases.
10837 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10838 (Fdbus_register_method): Use Qinvalid_function.
10840 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10842 * makefile.w32-in: Update dependencies.
10843 (LISP_H): Add inttypes.h and stdin.h.
10844 (PROCESS_H): Add unistd.h.
10846 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10848 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10849 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10851 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10853 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10855 * term.c (vfatal): Remove stray call to va_end.
10856 It's not needed and the C Standard doesn't allow it here anyway.
10858 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10859 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10861 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10864 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10868 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10870 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10872 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10874 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10875 * charset.c (Fdefine_charset_internal): Don't initialize
10876 charset.code_space[15]. The value was garbage, on hosts with
10877 32-bit int (Bug#8600).
10879 * lread.c (read_integer): Be more consistent with string-to-number.
10880 Use string_to_number to do the actual conversion; this avoids
10881 rounding errors and fixes some other screwups. Without this fix,
10882 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10883 (digit_to_number): Move earlier, for benefit of read_integer.
10884 Return -1 if the digit is out of range for the base, -2 if it is
10885 not a digit in any supported base. (Bug#8602)
10887 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10889 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10890 to match comment at start of function. This also removes a
10891 GCC warning about overflow in a 32+64-bit port.
10893 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10895 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10896 Reported by Stefan Monnier in
10897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10898 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10899 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10901 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10902 (EMACS_UINTPTR): Likewise, with uintptr_t.
10904 * lisp.h: Prefer 64-bit EMACS_INT if available.
10905 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10906 on 32-bit hosts that have 64-bit int, so that they can access
10908 However, temporarily disable this change unless the temporary
10909 symbol WIDE_EMACS_INT is defined.
10911 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10913 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10914 This removes an assumption that EMACS_INT and long are the same
10915 width as pointers. The assumption is true for Emacs porting targets
10916 now, but we want to make other targets possible.
10917 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10918 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10919 In the rest of the code, change types of integers that hold casted
10920 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10921 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10922 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10923 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10924 No need to cast type when ORing.
10925 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10926 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10927 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10928 assume EMACS_INT is the same width as char *.
10929 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10930 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10931 Remove no-longer-needed casts.
10932 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10933 (xg_tool_bar_help_callback, xg_make_tool_item):
10934 Use EMACS_INTPTR to hold an integer
10935 that will be cast to void *; this can avoid a GCC warning
10936 if EMACS_INT is not the same width as void *.
10937 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10938 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10939 (current_message_1, set_message_1):
10940 Use a local to convert to proper width without a cast.
10941 * xmenu.c (dialog_selection_callback): Likewise.
10943 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10944 Also, don't assume VALBITS / RAND_BITS is less than 5,
10945 and don't rely on undefined behavior when shifting a 1 left into
10947 * lisp.h (get_random): Change signature to match.
10949 * lread.c (hash_string): Use size_t, not int, for hash computation.
10950 Normally we prefer signed values; but hashing is special, because
10951 it's better to use unsigned division on hash table sizes so that
10952 the remainder is nonnegative. Also, size_t is the natural width
10953 for hashing into memory. The previous code used 'int', which doesn't
10954 retain enough info to hash well into very large tables.
10955 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10957 * dbusbind.c: Don't possibly lose pointer info when converting.
10958 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10959 Use XPNTR rather than XHASH, so that the high-order bits of
10960 the pointer aren't lost when converting through void *.
10962 * eval.c (Fautoload): Don't double-shift a pointer.
10964 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10966 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10968 * gnutls.c (DEF_GNUTLS_FN):
10969 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10971 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10973 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10976 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10978 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10979 New version that can reserve upto 2GB of heap space.
10981 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10983 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10985 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10987 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10988 `gnutls_certificate_set_x509_key_file'.
10990 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10992 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10993 Update dependencies.
10995 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10997 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10998 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10999 Remove unused parameter `fildes'.
11000 * process.c (read_process_output, send_process): Don't pass it.
11002 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11004 Fix previous change: the library cache is defined in w32.c.
11005 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11006 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11008 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11010 Implement dynamic loading of GnuTLS on Windows.
11012 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11013 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11014 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11017 * gnutls.c (Qgnutls_dll): Define.
11018 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11019 (gnutls_*): Declare function pointers.
11020 (init_gnutls_functions): New function to initialize function pointers.
11021 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11022 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11023 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11024 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11025 (emacs_gnutls_write, emacs_gnutls_read)
11026 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11027 (Fgnutls_available_p): New function.
11028 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11029 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11030 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11032 * image.c: Include w32.h.
11033 (Vimage_type_cache): Delete.
11034 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11035 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11036 (w32_delayed_load): Move to w32.c.
11038 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11040 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11041 (w32_delayed_load): Move from image.c. When loading a library, record
11042 its filename in the :loaded-from property of the library id.
11043 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11044 Initialize and staticpro them.
11045 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11047 * process.c: Include lisp.h before w32.h, not after.
11048 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11049 instead of gnutls_record_check_pending.
11051 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11053 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11055 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11056 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11059 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11061 * xterm.c (x_set_frame_alpha): Do not set property on anything
11062 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11064 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11066 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11068 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11070 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11071 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11072 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11073 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11074 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11075 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11076 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11077 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11078 (Qgnutls_bootprop_callbacks_verify): Make static.
11080 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11082 * callproc.c: Indentation fixup.
11084 * sysdep.c (wait_for_termination_1): Make static.
11085 (wait_for_termination, interruptible_wait_for_termination):
11086 Move after wait_for_termination_1.
11088 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11090 * sysdep.c (interruptible_wait_for_termination): New function
11091 which is like wait_for_termination, but allows keyboard
11094 * callproc.c (Fcall_process): Add (:file "file") as an option for
11096 (Fcall_process_region): Ditto.
11098 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11100 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11101 rather than `XVECTOR (FOO)->size'.
11103 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11104 inttypes.h, as a gnulib replacement is used if it not available in
11107 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11109 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11110 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11111 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11113 * coding.c (coding_alloc_by_realloc): Error out if destination
11114 will grow beyond MOST_POSITIVE_FIXNUM.
11115 (decode_coding_emacs_mule): Abort if there isn't enough place in
11116 charbuf for the composition carryover bytes. Reserve an extra
11117 space for up to 2 characters produced in a loop.
11118 (decode_coding_iso_2022): Abort if there isn't enough place in
11119 charbuf for the composition carryover bytes.
11121 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11123 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11124 aborting when %lld or %lll format is passed.
11125 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11126 %llo or %llx format is passed. (Bug#8545)
11128 * window.c (window_scroll_line_based): Use a marker instead of
11129 simple variables to record original value of point. (Bug#7952)
11131 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11132 produced by %s or %c overflows available buffer space. (Bug#8545)
11134 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11136 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11137 (SIZE_MAX): Move defn after all includes, as they might #define it.
11139 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11141 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11143 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11145 * keyboard.c (Qdelayed_warnings_hook): Define.
11146 (command_loop_1): Run `delayed-warnings-hook'
11147 if Vdelayed_warnings_list is non-nil.
11148 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11149 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11151 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11153 * doprnt.c (doprnt): Don't return value smaller than the buffer
11154 size if the message was truncated. (Bug#8545).
11156 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11158 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11159 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11161 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11163 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11165 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11167 * makefile.w32-in: Update dependencies.
11169 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11171 Improve `doprnt' and its usage. (Bug#8545)
11172 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11173 `format_end'. Remove support for %l as a conversion specifier.
11174 Don't use xrealloc. Improve diagnostics when the %l size modifier
11175 is used. Update the commentary.
11177 * eval.c (verror): Simplify calculation of size_t.
11179 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11182 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11184 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11187 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11189 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11190 This makes this file independent of the recent pseudovector change.
11192 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11194 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11196 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11197 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11198 Remove unused local.
11199 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11201 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11202 GCC 4.6.0 optimizes based on type-based alias analysis.
11203 For example, if b is of type struct buffer * and v of type struct
11204 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11205 != &v->size, and therefore "v->size = 1; b->size = 2; return
11206 v->size;" must therefore return 1. This assumption is incorrect
11207 for Emacs, since it type-puns struct Lisp_Vector * with many other
11208 types. To fix this problem, this patch adds a new type struct
11209 vectorlike_header that documents the constraints on layout of vectors
11210 and pseudovectors, and helps optimizing compilers not get fooled
11211 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11212 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11213 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11215 (XSETPVECTYPE): Rewrite in terms of new macro.
11216 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11217 This is a bit clearer, and further avoids the possibility of
11218 undesirable aliasing.
11219 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11220 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11221 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11222 since Lisp_Subr is a special case (no "next" field).
11223 (ASIZE): Now uses header.size rather than size.
11224 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11225 to avoid the hassle of writing XVECTOR (foo)->header.size.
11226 (struct vectorlike_header): New type.
11227 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11228 object, to help avoid aliasing.
11229 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11230 (SUBRP): Likewise, since Lisp_Subr is a special case.
11231 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11232 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11233 (struct Lisp_Hash_Table): Combine first two members into a single
11234 struct vectorlike_header member. All uses of "size" and "next" members
11235 changed to be "header.size" and "header.next".
11236 * buffer.h (struct buffer): Likewise.
11237 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11238 * frame.h (struct frame): Likewise.
11239 * process.h (struct Lisp_Process): Likewise.
11240 * termhooks.h (struct terminal): Likewise.
11241 * window.c (struct save_window_data, struct saved_window): Likewise.
11242 * window.h (struct window): Likewise.
11243 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11244 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11245 * buffer.c (init_buffer_once): Likewise.
11246 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11248 * process.c (Fformat_network_address): Use local var for size,
11251 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11253 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11254 * data.c (atof): Remove decl; no longer used or needed.
11255 (digit_to_number): Move to lread.c.
11256 (Fstring_to_number): Use new string_to_number function, to be
11257 consistent with how the Lisp reader treats infinities and NaNs.
11258 Do not assume that floating-point numbers represent EMACS_INT
11259 without losing information; this is not true on most 64-bit hosts.
11260 Avoid double-rounding errors, by insisting on integers when
11261 parsing non-base-10 numbers, as the documentation specifies.
11262 * lisp.h (string_to_number): New decl, replacing ...
11263 (isfloat_string): Remove.
11264 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11265 (read1): Do not accept +. and -. as integers; this
11266 appears to have been a coding error. Similarly, do not accept
11267 strings like +-1e0 as floating point numbers. Do not report
11268 overflow for integer overflows unless the base is not 10 which
11269 means we have no simple and reliable way to continue.
11270 Break out the floating-point parsing into a new
11271 function string_to_number, so that Fstring_to_number parses
11272 floating point numbers consistently with the Lisp reader.
11273 (digit_to_number): Move here from data.c. Make it static inline.
11274 (E_CHAR, EXP_INT): Remove, replacing with ...
11275 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11276 (string_to_number): New function, replacing isfloat_string.
11277 This function checks for valid syntax and produces the resulting
11278 Lisp float number too. Rework it so that string-to-number
11279 no longer mishandles examples like "1.0e+". Use strtoumax,
11280 so that overflow for non-base-10 numbers is reported only when
11281 there's no portable and simple way to convert to floating point.
11283 * textprop.c (set_text_properties_1): Rewrite for clarity,
11284 and to avoid GCC warning about integer overflow.
11286 * intervals.h (struct interval): Use EMACS_INT for members
11287 where EMACS_UINT might cause problems. See
11288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11289 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11290 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11292 (offset_intervals): Tell GCC not to worry about length overflow
11293 when negating a negative length.
11295 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11296 (overrun_check_free): Likewise.
11298 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11299 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11302 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11303 (gnutls_make_error): Rename local to avoid shadowing.
11304 (gnutls_emacs_global_deinit): ifdef out; not used.
11305 (Fgnutls_boot): Use const for pointer to readonly storage.
11306 Comment out unused local. Fix pointer signedness problems.
11308 * lread.c (openp): Don't stuff size_t into an 'int'.
11309 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11310 about possible signed overflow.
11312 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11313 (GDK_KEY_g): Don't define if already defined.
11314 (xg_prepare_tooltip): Avoid pointer signedness problem.
11315 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11317 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11318 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11320 * xfns.c (Fx_window_property): Simplify a bit,
11321 to make a bit faster and to avoid GCC 4.6.0 warning.
11322 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11324 * fns.c (internal_equal): Don't assume size_t fits in int.
11326 * alloc.c (compact_small_strings): Tighten assertion a little.
11328 Replace pEd with more-general pI, and fix some printf arg casts.
11329 * lisp.h (pI): New macro, generalizing old pEd macro to other
11330 conversion specifiers. For example, use "...%"pI"d..." rather
11331 than "...%"pEd"...".
11332 (pEd): Remove. All uses replaced with similar uses of pI.
11333 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11334 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11335 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11336 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11337 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11338 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11339 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11341 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11342 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11343 * print.c (safe_debug_print, print_object): Likewise.
11344 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11346 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11347 avoiding the 0 flag, which is not portable.
11348 * process.c (Fmake_network_process): Use pI to avoid cast.
11349 * region-cache.c (pp_cache): Likewise.
11350 * xdisp.c (decode_mode_spec): Likewise.
11351 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11352 behavior on 64-bit hosts with printf arg.
11353 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11354 (x_stop_queuing_selection_requests): Likewise.
11355 (x_get_window_property): Don't truncate byte count to an 'int'
11358 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11359 here, since it parses constructs like leading '-' and spaces,
11360 which are not wanted; and it overflows with large numbers.
11361 Instead, simply match F[0-9]+, which is what is wanted anyway.
11363 * alloc.c: Remove unportable assumptions about struct layout.
11364 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11365 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11366 (allocate_vectorlike, make_pure_vector): Use the new macros,
11367 plus offsetof, to remove unportable assumptions about struct layout.
11368 These assumptions hold on all porting targets that I know of, but
11369 they are not guaranteed, they're easy to remove, and removing them
11370 makes further changes easier.
11372 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11373 This doesn't fix a bug but makes the code clearer.
11374 (string_overrun_cookie): Now const. Use initializers that
11375 don't formally overflow signed char, to avoid warnings.
11376 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11377 can cause Emacs to crash when string overrun checking is enabled.
11378 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11379 multiple of sizeof (EMACS_INT); it need not be, if
11380 alignof(EMACS_INT) < sizeof (EMACS_INT).
11381 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11383 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11385 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11387 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11389 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11390 supposed to be handshaking. (Bug#8556)
11391 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11393 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11395 * lisp.h (Qdebug): List symbol.
11396 * eval.c (Qdebug): Restore global linkage.
11397 * keyboard.c (debug-on-event): New variable.
11398 (handle_user_signal): Break into debugger when debug-on-event
11399 matches the current signal symbol.
11401 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11403 * alloc.c (check_sblock, check_string_bytes)
11404 (check_string_free_list): Convert to standard C.
11406 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11408 * w32.c (emacs_gnutls_push): Fix typo.
11410 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11412 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11413 "cast to pointer from integer of different size".
11415 Improve doprnt and its use in verror. (Bug#8545)
11416 * doprnt.c (doprnt): Document the set of format control sequences
11417 supported by the function. Use SAFE_ALLOCA instead of always
11420 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11421 is one byte too soon. Don't use xrealloc; instead xfree and
11424 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11426 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11429 * gnutls.c: Renamed global_initialized to
11430 gnutls_global_initialized. Added internals for the
11431 :verify-hostname-error, :verify-error, and :verify-flags
11432 parameters of `gnutls-boot' and documented those parameters in the
11433 docstring. Start callback support.
11434 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11435 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11436 on error. Return error code.
11437 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11438 (emacs_gnutls_read): Likewise.
11439 (Fgnutls_boot): Return handshake error code.
11440 (emacs_gnutls_handle_error): New function.
11441 (wsaerror_to_errno): Likewise.
11443 * w32.h (emacs_gnutls_pull): Add prototype.
11444 (emacs_gnutls_push): Likewise.
11446 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11447 (emacs_gnutls_push): Likewise.
11449 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11451 * process.c (wait_reading_process_output): Check if GnuTLS
11452 buffered some data internally if no FDs are set for TLS
11455 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11456 (LIBS): Link to USER_LIBS.
11457 ($(BLD)/gnutls.$(0)): New target.
11459 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11461 * xdisp.c (handle_single_display_spec): Rename the
11462 display_replaced_before_p argument into display_replaced_p, to
11463 make it consistent with the commentary. Fix typos in the
11466 * textprop.c (syms_of_textprop): Remove dead code.
11467 (copy_text_properties): Delete obsolete commentary about an
11468 interface that was deleted long ago. Fix typos in the description
11471 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11472 to changes in oldXMenu/XMenu.h from 2011-04-16.
11473 <menu_help_message, prev_menu_help_message>: Constify.
11474 (IT_menu_make_room): menu->help_text is now `const char **';
11477 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11478 to changes in oldXMenu/XMenu.h from 2011-04-16.
11479 (struct XMenu): Declare `help_text' `const char **'.
11481 * xfaces.c <Qunspecified>: Make extern again.
11483 * syntax.c: Include sys/types.h before including regex.h, as
11486 * doc.c (get_doc_string): Improve the format passed to `error'.
11488 * doprnt.c (doprnt): Improve commentary.
11490 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11492 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11495 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11496 changes in globals.h immediately force recompilation.
11497 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11498 $(CURDIR)/s/ms-w32.h.
11499 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11501 * character.c (Fchar_direction): Function deleted.
11502 (syms_of_character): Don't defsubr it.
11503 <char-direction-table>: Deleted.
11505 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11507 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11508 * doprnt.c: Include limits.h.
11509 (SIZE_MAX): New macro.
11510 (doprnt): Return a size_t value. 2nd arg is now size_t.
11511 Many local variables are now size_t instead of int or unsigned.
11512 Improve overflow protection. Support `l' modifier for integer
11513 conversions. Support %l conversion. Don't assume an EMACS_INT
11514 argument for integer conversions and for %c.
11516 * lisp.h (doprnt): Restore prototype.
11518 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11519 $(SRC)/character.h.
11521 * Makefile.in (base_obj): Add back doprnt.o.
11523 * deps.mk (doprnt.o): Add back prerequisites.
11524 (callint.o): Depend on character.h.
11526 * eval.c (internal_lisp_condition_case): Include the handler
11527 representation in the error message.
11528 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11529 when breaking from the loop.
11531 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11533 * callint.c (Fcall_interactively): When displaying error message
11534 about invalid control letter, pass the character's codepoint, not
11535 a pointer to its multibyte form. Improve display of the character
11536 in octal and display also its hex code.
11538 * character.c (char_string): Use %x to display the (unsigned)
11539 codepoint of an invalid character, to avoid displaying a bogus
11542 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11543 `error', not SYMBOL_NAME itself.
11545 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11546 character arguments to `error'.
11548 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11549 to `error' in error message about FINAL_CHAR argument. Make sure
11550 FINAL_CHAR is a character, and use %c when it is passed as
11551 argument to `error'.
11553 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11555 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11557 * w32.c: Include <time.h>.
11558 (sys_localtime): New function.
11560 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11562 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11564 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11566 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11568 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11569 zombies (Bug#8467).
11571 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11573 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11574 gl_state.e_property when gl_state.object is Qt.
11576 * insdel.c (make_gap_larger): Remove limitation of buffer size
11579 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11581 * xdisp.c (lookup_glyphless_char_display)
11582 (produce_glyphless_glyph): Handle cons cell entry in
11583 glyphless-char-display.
11584 (Vglyphless_char_display): Document it.
11586 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11587 glyphless-char-display.
11589 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11591 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11593 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11595 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11596 definition for no-X builds.
11598 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11600 Static checks with GCC 4.6.0 and non-default toolkits.
11602 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11604 * process.c (keyboard_bit_set): Define only if SIGIO.
11605 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11606 (send_process): Repair possible setjmp clobbering.
11608 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11610 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11612 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11614 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11615 Define only if needed.
11617 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11618 by pacifying GCC about it. Maybe it's time to retire it?
11619 * xfaces.c (USG, __TIMEVAL__): Likewise.
11621 * dispextern.h (struct redisplay_interface): Rename param
11622 to avoid shadowing.
11623 * termhooks.h (struct terminal): Likewise.
11624 * xterm.c (xembed_send_message): Likewise.
11626 * insdel.c (make_gap_smaller): Define only if
11627 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11629 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11632 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11633 so that we aren't warned about unused symbols.
11635 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11637 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11639 * xfns.c (x_real_positions): Mark locals as initialized.
11641 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11643 * xterm.c: Fix problems found by static analysis with other toolkits.
11644 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11645 (x_dispatch_event): Declare static if USE_GTK, and
11646 define if USE_GTK || USE_X_TOOLKIT.
11647 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11648 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11649 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11650 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11652 * xmenu.c (menu_help_callback): Pointer type fixes.
11653 Use const pointers when pointing at readonly data. Avoid pointer
11654 signedness clashes.
11655 (FALSE): Remove unused macro.
11656 (update_frame_menubar): Remove unused decl.
11658 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11660 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11661 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11662 (single_menu_item): Rename local to avoid shadowing.
11664 * keyboard.c (make_lispy_event): Remove unused local var.
11666 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11667 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11669 * bitmaps: Change bitmaps from unsigned char back to the X11
11670 compatible char. Avoid the old compiler warnings about
11671 out-of-range initializers by using, for example, '\xab' rather
11674 * xgselect.c (xgselect_initialize): Check vs interface
11675 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11677 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11679 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11680 to read-only memory.
11682 * fns.c (vector): Remove; this old hack is no longer needed.
11684 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11686 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11688 * xrdb.c (x_load_resources): Omit unused local.
11690 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11691 (x_window): Rename locals to avoid shadowing.
11692 (USG): Use the kludged USG macro, to pacify gcc.
11694 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11695 (x_term_init): Remove local to avoid shadowing.
11697 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11699 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11700 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11702 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11704 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11706 Fix regex.c, syntax.c and friends for buffers > 2GB.
11707 * syntax.h (struct gl_state_s): Declare character position members
11710 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11712 * textprop.c (verify_interval_modification, interval_of):
11713 Declare arguments EMACS_INT.
11715 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11718 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11720 * indent.c (Fvertical_motion): Local variable it_start is now
11723 * regex.c (re_match, re_match_2, re_match_2_internal)
11724 (bcmp_translate, regcomp, regexec, print_double_string)
11725 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11726 (re_compile_pattern, re_exec): Declare arguments and local
11727 variables `size_t' and `ssize_t' and return values `regoff_t', as
11729 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11730 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11731 <compile_stack_type>: `size' and `avail' are now `size_t'.
11733 * regex.h <regoff_t>: Use ssize_t, not int.
11734 (re_search, re_search_2, re_match, re_match_2): Arguments that
11735 specify buffer/string position and length are now ssize_t and
11736 size_t. Return type is regoff_t.
11738 2011-04-16 Ben Key <bkey76@gmail.com>
11740 * nsfont.m: Fixed bugs in ns_get_family and
11741 ns_descriptor_to_entity that were caused by using free to
11742 deallocate memory blocks that were allocated by xmalloc (via
11743 xstrdup). This caused Emacs to crash when compiled with
11744 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11745 --enable-checking=xmallocoverrun). xfree is now used to
11746 deallocate these memory blocks.
11748 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11750 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11752 emacs_write: Accept and return EMACS_INT for sizes.
11753 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11755 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11756 Accept and return EMACS_INT.
11757 (emacs_gnutls_write): Return the number of bytes written on
11759 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11760 (emacs_read, emacs_write): Remove check for negative size, as the
11761 Emacs source code has been audited now.
11762 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11763 (emacs_read, emacs_write): Use it.
11764 * process.c (send_process): Adjust to the new signatures of
11765 emacs_write and emacs_gnutls_write. Do not attempt to store
11766 a byte offset into an 'int'; it might overflow.
11767 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11769 * sound.c: Don't assume sizes fit in 'int'.
11770 (struct sound_device.period_size, alsa_period_size):
11771 Return EMACS_INT, not int.
11772 (struct sound_device.write, vox_write, alsa_write):
11773 Accept EMACS_INT, not int.
11774 (wav_play, au_play): Use EMACS_INT to store sizes and to
11775 record read return values.
11777 2011-04-15 Ben Key <bkey76@gmail.com>
11779 * keyboard.c (Qundefined): Don't declare static since it is used
11781 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11782 static since they are used in nsfont.m.
11784 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11786 * process.c (Qprocessp): Don't declare static.
11787 * lisp.h (Qprocessp): Declare again.
11789 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11791 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11793 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11795 Improve C-level modularity by making more things 'static'.
11797 Don't publish debugger-only interfaces to other modules.
11798 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11799 (verify_bytepos, count_markers): Move decls to the only modules
11801 * region-cache.h (pp_cache): Likewise.
11802 * window.h (check_all_windows): Likewise.
11803 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11805 * sysdep.c (croak): Now static, if
11806 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11807 * syssignal.h (croak): Declare only if not static.
11809 * alloc.c (refill_memory_reserve): Now static if
11810 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11811 * lisp.h (refill_memory_reserve): Declare only if not static.
11813 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11814 Define only if USE_LUCID.
11816 * xrdb.c (x_customization_string, x_rm_string): Now static.
11818 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11819 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11821 * xdisp.c (draw_row_with_mouse_face): Now static.
11822 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11824 * window.h (check_all_windows): Mark externally visible.
11826 * window.c (window_deletion_count): Now static.
11828 * undo.c: Make symbols static if they're not exported.
11829 (last_undo_buffer, last_boundary_position, pending_boundary):
11832 * textprop.c (interval_insert_behind_hooks): Now static.
11833 (interval_insert_in_front_hooks): Likewise.
11835 * term.c: Make symbols static if they're not exported.
11836 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11837 (max_frame_lines, tty_set_terminal_modes):
11838 (tty_reset_terminal_modes, tty_turn_off_highlight):
11839 (get_tty_terminal): Now static.
11840 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11841 * termhooks.h (term_mouse_moveto): Do not declare if
11842 HAVE_WINDOW_SYSTEM.
11843 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11844 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11846 * sysdep.c: Make symbols static if they're not exported.
11847 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11849 (sigprocmask_set, full_mask): Remove; unused.
11850 (wait_debugging): Mark as visible.
11851 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11852 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11854 * syntax.c (syntax_temp): Define only if !__GNUC__.
11856 * sound.c (current_sound_device, current_sound): Now static.
11858 * search.c (searchbufs, searchbuf_head): Now static.
11860 * scroll.c (scroll_cost): Remove; unused.
11861 * dispextern.h (scroll_cost): Remove decl.
11863 * region-cache.h (pp_cache): Mark as externally visible.
11865 * process.c: Make symbols static if they're not exported.
11866 (process_tick, update_tick, create_process, chan_process):
11867 (Vprocess_alist, proc_buffered_char, datagram_access):
11868 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11869 (deactivate_process): Mark defn as static, as well as decl.
11870 * lisp.h (create_process): Remove decl.
11871 * process.h (chan_process, Vprocess_alist): Remove decls.
11873 * print.c: Make symbols static if they're not exported.
11874 (print_depth, new_backquote_output, being_printed, print_buffer):
11875 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11876 (print_interval, print_number_index, initial_stderr_stream):
11878 * lisp.h (Fprinc): Remove decl.
11879 (debug_output_compilation_hack): Mark as externally visible.
11881 * sysdep.c (croak): Move decl from here to syssignal.h.
11882 * syssignal.h (croak): Put it here, so the API can be checked when
11883 'croak' is called from dissociate_if_controlling_tty.
11885 * minibuf.c: Make symbols static if they're not exported.
11886 (minibuf_save_list, choose_minibuf_frame): Now static.
11887 * lisp.h (choose_minibuf_frame): Remove decl.
11889 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11891 * lread.c: Make symbols static if they're not exported.
11892 (read_objects, initial_obarray, oblookup_last_bucket_number):
11894 (make_symbol): Remove; unused.
11895 * lisp.h (initial_obarray, make_symbol): Remove decls.
11897 * keyboard.c: Make symbols static if they're not exported.
11898 (single_kboard, recent_keys_index, total_keys, recent_keys):
11899 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11900 (this_single_command_key_start, echoing, last_auto_save):
11901 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11902 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11903 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11904 (Vlispy_mouse_stem, double_click_count):
11906 (force_auto_save_soon): Define only if SIGDANGER.
11907 (ignore_mouse_drag_p): Now static if
11908 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11909 (print_help): Remove; unused.
11910 (stop_character, last_timer_event): Mark as externally visible.
11911 * keyboard.h (ignore_mouse_drag_p): Declare only if
11912 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11913 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11914 * lisp.h (echoing): Remove decl.
11915 (force_auto_save_soon): Declare only if SIGDANGER.
11916 * xdisp.c (redisplay_window): Simplify code, to make it more
11917 obvious that ignore_mouse_drag_p is not accessed if !defined
11918 USE_GTK && !defined HAVE_NS.
11920 * intervals.c: Make symbols static if they're not exported.
11921 (merge_properties_sticky, merge_interval_right, delete_interval):
11923 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11925 * insdel.c: Make symbols static if they're not exported.
11926 However, leave prepare_to_modify_buffer alone. It's never
11927 called from outside this function, but that appears to be a bug.
11928 (combine_after_change_list, combine_after_change_buffer):
11929 (adjust_after_replace, signal_before_change): Now static.
11930 (adjust_after_replace_noundo): Remove; unused.
11931 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11932 (signal_before_change): Remove decls.
11934 * indent.c (val_compute_motion, val_vmotion): Now static.
11936 * image.c: Make symbols static if they're not exported.
11937 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11939 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11940 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11942 * fringe.c (standard_bitmaps): Now static.
11943 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11945 * frame.c: Make symbols static if they're not exported.
11946 (x_report_frame_params, make_terminal_frame): Now static.
11947 (get_frame_param): Now static, unless HAVE_NS.
11948 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11949 (x_get_resource_string): Remove; not used.
11950 * frame.h (make_terminal_frame, x_report_frame_params):
11951 (x_get_resource_string); Remove decls.
11952 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11953 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11955 * font.c, fontset.c: Make symbols static if they're not exported.
11956 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11957 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11958 * font.c (font_close_object): Now static.
11959 * font.h (font_close_object): Remove.
11960 * fontset.c (FONTSET_OBJLIST): Remove.
11961 (free_realized_fontset) #if-0 the body, which does nothing.
11962 (face_suitable_for_char_p): #if-0, as it's never called.
11963 * fontset.h (face_suitable_for_char_p): Remove decl.
11964 * xfaces.c (face_at_string_position):
11965 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11966 since 0 is always ASCII.
11968 * fns.c (weak_hash_tables): Now static.
11970 * fileio.c: Make symbols static if they're not exported.
11971 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11972 (Vwrite_region_annotation_buffers): Now static.
11974 * eval.c: Make symbols static if they're not exported.
11975 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11976 * lisp.h (backtrace_list): Remove decl.
11978 * emacs.c: Make symbols static if they're not exported.
11979 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11980 (fatal_error_code, fatal_error_signal_hook, standard_args):
11982 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11983 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11984 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11985 * lisp.h (fatal_error_signal_hook): Remove decl.
11986 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11988 * editfns.c: Move a (normally-unused) function to its only use.
11989 * editfns.c, lisp.h (get_operating_system_release): Remove.
11990 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11991 worth the hassle of breaking this out.
11993 * xterm.c: Make symbols static if they're not exported.
11994 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11995 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11996 (x_destroy_window, x_delete_display):
11998 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11999 (x_mouse_leave): Remove; unused.
12000 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12001 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12002 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12004 (x_mouse_leave): Declare only if WINDOWSNT.
12005 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12006 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12009 * ftxfont.c: Make symbols static if they're not exported.
12010 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12012 * font.h (ftxfont_driver): Likewise.
12014 * xfns.c: Make symbols static if they're not exported.
12015 (x_last_font_name, x_display_info_for_name):
12016 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12017 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12018 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12019 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12020 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12021 (last_show_tip_args): Now static.
12022 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12023 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12024 (x_screen_planes): Remove; unused.
12025 * dispextern.h (x_screen_planes): Remove decl.
12027 * dispnew.c: Make symbols static if they're not exported.
12028 * dispextern.h (redraw_garbaged_frames, scrolling):
12029 (increment_row_positions): Remove.
12030 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12031 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12033 (redraw_garbaged_frames): Remove; unused.
12035 * xfaces.c: Make symbols static if they're not exported.
12036 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12038 * xterm.h (defined_color): Remove decls.
12039 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12040 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12041 (menu_face_changed_default, defined_color, free_realized_face):
12042 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12043 (ascii_face_of_lisp_face): Remove; unused.
12045 * xdisp.c: Make symbols static if they're not exported.
12046 * dispextern.h (scratch_glyph_row, window_box_edges):
12047 (glyph_to_pixel_coords, set_cursor_from_row):
12048 (get_next_display_element, set_iterator_to_next):
12049 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12050 (show_mouse_face): Remove decls
12051 * frame.h (message_buf_print): Likewise.
12052 * lisp.h (pop_message, set_message, check_point_in_composition):
12054 * xterm.h (set_vertical_scroll_bar): Likewise.
12055 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12056 (message_buf_print, scratch_glyph_row, displayed_buffer):
12057 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12058 (get_next_display_element, show_mouse_face, window_box_edges):
12059 (frame_to_window_pixel_xy, check_point_in_composition):
12060 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12061 (glyph_to_pixel_coords): Remove; unused.
12063 * dired.c (file_name_completion): Now static.
12065 * dbusbind.c (xd_in_read_queued_messages): Now static.
12067 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12068 * data.c (circular_list_error): Remove.
12070 * commands.h (last_point_position, last_point_position_buffer):
12071 (last_point_position_window): Remove decls.
12072 * keyboard.c: Make these variables static.
12074 * coding.h (coding, code_convert_region, encode_coding_gap):
12076 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12077 (iso_code_class, detect_coding, code_convert_region): Now static.
12078 (encode_coding_gap): Remove; unused.
12080 * chartab.c (chartab_chars, chartab_bits): Now static.
12082 * charset.h (charset_iso_8859_1): Remove decl.
12083 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12086 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12087 * ccl.c (Vccl_program_table): Now static.
12088 (check_ccl_update): Remove; unused.
12090 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12091 * category.h: ... from here.
12092 * category.c (check_category_table, set_category_set): Now static.
12094 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12095 * lisp.h: Remove these decls.
12097 * buffer.c (buffer_count): Remove unused var.
12099 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12100 so that it's not optimized away.
12101 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12102 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12103 exported only to the debugger.
12105 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12106 * atimer.h (run_all_atimers): Remove; not exported.
12108 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12109 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12110 was inaccessible from Lisp.
12111 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12112 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12114 alloc.c: Import and export fewer symbols, and remove unused items.
12115 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12117 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12118 it's not optimized away by whole-program optimization.
12119 (message_enable_multibyte, free_misc): Remove.
12120 (catchlist, handlerlist, mark_backtrace):
12121 Declare only if BYTE_MARK_STACK.
12122 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12123 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12124 (message_enable_multibyte): Remove decl.
12125 (free_misc, interval_free_list, float_block, float_block_index):
12126 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12127 (cons_free_list, last_marked_index):
12129 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12130 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12131 (mark_backtrace): Define only if BYTE_MARK_STACK.
12132 * xdisp.c (message_enable_multibyte): Now static.
12134 Declare Lisp_Object Q* variables to be 'static' if not exported.
12135 This makes it easier for human readers (and static analyzers)
12136 to see whether these variables are used from other modules.
12137 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12138 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12139 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12140 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12141 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12142 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12143 * xmenu.c, xselect.c:
12144 Declare Q* vars static if they are not used in other modules.
12145 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12146 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12147 Remove decls of unexported vars.
12148 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12150 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12152 Make Emacs functions such as Fatom 'static' by default.
12153 This makes it easier for human readers (and static analyzers)
12154 to see whether these functions can be called from other modules.
12155 DEFUN now defines a static function. To make the function external
12156 so that it can be used in other C modules, use the new macro DEFUE.
12157 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12158 (Finit_image_library):
12159 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12160 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12161 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12162 Remove decls, since these functions are now static.
12163 (Funintern, Fget_internal_run_time): New decls, since these functions
12164 were already external.
12166 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12167 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12168 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12169 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12170 * keyboard.c, keymap.c, lread.c:
12171 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12172 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12173 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12174 Mark functions with DEFUE instead of DEFUN,
12175 if they are used in other modules.
12176 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12177 decls for now-static functions.
12178 * buffer.h (Fdelete_overlay): Remove decl.
12179 * callproc.c (Fgetenv_internal): Mark as internal.
12180 * composite.c (Fremove_list_of_text_properties): Remove decl.
12181 (Fcomposition_get_gstring): New forward static decl.
12182 * composite.h (Fcomposite_get_gstring): Remove decl.
12183 * dired.c (Ffile_attributes): New forward static decl.
12184 * doc.c (Fdocumntation_property): New forward static decl.
12185 * eval.c (Ffetch_bytecode): New forward static decl.
12186 (Funintern): Remove extern decl; now in .h file where it belongs.
12187 * fileio.c (Fmake_symbolic_link): New forward static decl.
12188 * image.c (Finit_image_library): New forward static decl.
12189 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12190 * intervals.h (Fprevious_property_change):
12191 (Fremove_list_of_text_properties): Remove decls.
12192 * keyboard.c (Fthis_command_keys): Remove decl.
12193 (Fcommand_execute): New forward static decl.
12194 * keymap.c (Flookup_key): New forward static decl.
12195 (Fcopy_keymap): Now static.
12196 * keymap.h (Flookup_key): Remove decl.
12197 * process.c (Fget_process): New forward static decl.
12198 (Fprocess_datagram_address): Mark as internal.
12199 * syntax.c (Fsyntax_table_p): New forward static decl.
12200 (skip_chars): Remove duplicate decl.
12201 * textprop.c (Fprevious_property_change): New forward static decl.
12202 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12204 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12205 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12207 * editfns.c (Fformat): Remove unreachable code.
12209 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12211 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12214 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12216 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12217 when at ZV. (Bug#8487)
12219 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12221 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12223 * keyboard.c (parse_tool_bar_item): Likewise.
12224 * sound.c (sound_cleanup, alsa_close): Likewise.
12225 * termcap.c (tgetent): Likewise.
12226 * xfns.c (x_default_font_parameter): Likewise.
12227 * xsettings.c (read_and_apply_settings): Likewise.
12229 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12230 (overrun_check_free): Protoize.
12232 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12234 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12235 since callers should never pass a negative size.
12236 Change the signature to match that of plain 'read' and 'write'; see
12237 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12238 * lisp.h: Update prototypes of emacs_write and emacs_read.
12240 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12242 * xdisp.c (redisplay_window): Don't try to determine the character
12243 position of the scroll margin if the window start point w->startp
12244 is outside the buffer's accessible region. (Bug#8468)
12246 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12248 Fix write-region and its subroutines for buffers > 2GB.
12249 * fileio.c (a_write, e_write): Modify declaration of arguments and
12250 local variables to support buffers larger than 2GB.
12251 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12253 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12254 argument, local variables, and return value.
12256 * lisp.h: Update prototypes of emacs_write and emacs_read.
12258 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12260 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12262 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12264 Fix more problems found by GCC 4.6.0's static checks.
12266 * xdisp.c (vmessage): Use a better test for character truncation.
12268 * charset.c (load_charset_map): <, not <=, for optimization,
12269 and to avoid potential problems with integer overflow.
12270 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12271 * casetab.c (set_identity, shuffle): Likewise.
12272 * editfns.c (Fformat): Likewise.
12273 * syntax.c (skip_chars): Likewise.
12275 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12276 This also lets GCC 4.6.0 generate slightly better loop code.
12278 * callint.c (Fcall_interactively): <, not <=, for optimization.
12279 (Fcall_interactively): Count the number of arguments produced,
12280 not the number of arguments given. This is simpler and lets GCC
12281 4.6.0 generate slightly better code.
12283 * ftfont.c: Distingish more carefully between FcChar8 and char.
12284 The previous code passed unsigned char * to a functions like
12285 strlen and xstrcasecmp that expect char *, which does not
12286 conform to the C standard.
12287 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12288 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12289 char * when the C standard requires it.
12291 * keyboard.c (read_char): Remove unused var.
12293 * eval.c: Port to Windows vsnprintf (Bug#8435).
12294 Include <limits.h>.
12295 (SIZE_MAX): Define if the headers do not.
12296 (verror): Do not give up if vsnprintf returns a negative count.
12297 Instead, grow the buffer. This ports to Windows vsnprintf, which
12298 does not conform to C99. Problem reported by Eli Zaretskii.
12299 Also, simplify the allocation scheme, by avoiding the need for
12300 calling realloc, and removing the ALLOCATED variable.
12302 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12304 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12305 But keep the doprint source code for now, as we might revamp it
12306 and use it again (Bug#8435).
12307 * lisp.h (doprnt): Remove.
12308 * Makefile.in (base_obj): Remove doprnt.o.
12309 * deps.mk (doprnt.o): Remove.
12311 error: Print 32- and 64-bit integers portably (Bug#8435).
12312 Without this change, on typical 64-bit hosts error ("...%d...", N)
12313 was used to print both 32- and 64-bit integers N, which relied on
12314 undefined behavior.
12315 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12316 * lisp.h (error, verror): Mark as printf-like functions.
12317 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12318 Report overflow in size calculations when allocating printf buffer.
12319 Do not truncate output string at its first null byte.
12320 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12321 Truncate the output at a character boundary, since vsnprintf does not
12323 * charset.c (check_iso_charset_parameter): Convert internal
12324 character to string before calling 'error', since %c now has the
12326 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12327 overflow when computing char to be passed to 'error'. Do not
12328 pass Lisp_Object to 'error'; pass the integer instead.
12329 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12330 formatted with plain %d.
12332 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12334 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12336 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12338 * xterm.c (x_catch_errors): Remove duplicate declaration.
12340 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12342 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12344 2011-04-10 Jim Meyering <meyering@redhat.com>
12346 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12347 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12348 return ssize_t not "int", and use size_t as the buffer length.
12349 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12350 * gnutls.h: Update declarations.
12351 * process.c (read_process_output): Use ssize_t, to match.
12352 (send_process): Likewise.
12354 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12356 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12358 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12360 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12361 Use unsigned char, to match FcChar8 type definition.
12363 * xterm.c (handle_one_xevent):
12364 * xmenu.c (create_and_show_popup_menu):
12365 * xselect.c (x_decline_selection_request)
12366 (x_reply_selection_request): Avoid type-punned deref of X events.
12368 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12370 Fix some uses of `int' instead of EMACS_INT.
12371 * search.c (string_match_1, fast_string_match)
12372 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12373 (scan_buffer, find_next_newline_no_quit)
12374 (find_before_next_newline, search_command, Freplace_match)
12375 (Fmatch_data): Make some `int' variables be EMACS_INT.
12377 * xdisp.c (display_count_lines): 3rd argument and return value now
12378 EMACS_INT. All callers changed.
12379 (pint2hrstr): Last argument is now EMACS_INT.
12381 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12382 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12383 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12384 (decode_coding_utf_16, decode_coding_emacs_mule)
12385 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12386 (decode_coding_ccl, decode_coding_charset)
12387 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12388 (decode_coding_iso_2022, decode_coding_emacs_mule)
12389 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12390 <char_offset, last_offset>: Declare EMACS_INT.
12391 (encode_coding_utf_8, encode_coding_utf_16)
12392 (encode_coding_emacs_mule, encode_invocation_designation)
12393 (encode_designation_at_bol, encode_coding_iso_2022)
12394 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12395 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12397 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12398 (encode_invocation_designation): Last argument P_NCHARS is now
12400 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12401 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12403 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12406 * ccl.c (Fccl_execute_on_string): Declare some variables
12409 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12411 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12413 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12415 * process.c (Fformat_network_address): Doc fix.
12417 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12419 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12421 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12423 * keyboard.c (read_char): Call Lisp function help-form-show,
12424 instead of using internal_with_output_to_temp_buffer.
12425 (Qhelp_form_show): New var.
12426 (syms_of_keyboard): Use DEFSYM macro.
12428 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12430 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12432 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12434 * process.c (Flist_processes): Remove to Lisp.
12435 (list_processes_1): Delete.
12437 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12439 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12441 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12443 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12445 Fix more problems found by GCC 4.6.0's static checks.
12447 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12449 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12451 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12453 * xdisp.c (vmessage): Mark as a printf-like function.
12455 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12457 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12459 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12460 printf-like functions.
12461 (tiff_load): Add casts to remove these marks before passing them
12462 to system-supplied API.
12464 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12466 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12467 This avoids several warnings with gcc -Wstrict-overflow.
12468 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12469 directly, rather than having caller test rule sign. This avoids
12470 some unnecessary tests.
12471 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12472 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12473 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12475 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12476 (xfont_open): Avoid unnecessary tests.
12478 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12480 * composite.h, composite.c (composition_gstring_put_cache):
12481 Use EMACS_INT, not int, for length.
12483 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12484 breaking out part of COMPOSITION_DECODE_RULE.
12485 (COMPOSITION_DECODE_RULE): Use it.
12486 * composite.c (get_composition_id): Remove unused local vars,
12487 by using the new macro.
12489 * textprop.c (set_text_properties_1): Change while to do-while,
12490 since the condition is always true at first.
12492 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12493 (interval_deletion_adjustment): Return unsigned value.
12496 * process.c (list_processes_1, create_pty, read_process_output):
12497 (exec_sentinel): Remove vars that were set but not used.
12498 (create_pty): Remove unnecessary "volatile"s.
12499 (Fnetwork_interface_info): Avoid possibility of int overflow.
12500 (read_process_output): Do adaptive read buffering even if carryover.
12501 (read_process_output): Simplify nbytes computation if buffered.
12503 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12505 * syntax.c (scan_words): Remove var that was set but not used.
12506 (update_syntax_table): Use unsigned instead of int.
12508 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12509 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12510 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12512 * print.c (print_error_message): Avoid int overflow.
12514 * font.c (font_list_entities): Redo for clarity,
12515 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12517 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12518 (font_score): Avoid potential overflow in diff calculation.
12520 * fns.c (substring_both): Remove var that is set but not used.
12521 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12523 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12525 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12526 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12527 can always succeed if overflow has undefined behavior.
12529 * search.c (boyer_moore, wordify): Remove vars set but not used.
12530 (wordify): Omit three unnecessary tests.
12532 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12533 All callers changed. This avoids the need for an unused var.
12535 * casefiddle.c (casify_region): Remove var that is set but not used.
12537 * dired.c (file_name_completion): Remove var that is set but not used.
12539 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12541 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12542 (Finsert_file_contents): Remove unnecessary code checking fd.
12544 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12545 Check for integer overflow on size calculations.
12547 * buffer.c (Fprevious_overlay_change): Remove var that is set
12550 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12551 Remove vars that are set but not used.
12552 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12553 (timer_check_2): Mark vars as initialized.
12555 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12557 * image.c (lookup_image): Remove var that is set but not used.
12558 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12560 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12561 that are set but not used.
12563 * xfns.c (make_invisible_cursor): Don't return garbage
12564 if XCreateBitmapFromData fails (Bug#8410).
12566 * xselect.c (x_get_local_selection, x_handle_property_notify):
12567 Remove vars that are set but not used.
12569 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12570 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12572 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12573 Remove var that is set but not used.
12574 (scroll_bar_windows_size): Now size_t, not int.
12575 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12576 Check for overflow.
12578 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12579 (map_tty_color) [!defined MSDOS]: Likewise.
12581 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12583 * coding.c: Remove vars that are set but not used.
12584 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12585 All callers changed.
12586 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12587 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12588 (decode_coding_charset): Remove vars that are set but not used.
12590 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12591 that is set but not used.
12593 * print.c (print_object): Remove var that is set but not used.
12595 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12596 The gnulib version avoids calling malloc in the usual case,
12597 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12598 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12599 * filelock.c (current_lock_owner): Likewise.
12600 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12601 * sysdep.c: Include allocator.h, careadlinkat.h.
12602 (emacs_no_realloc_allocator): New static constant.
12603 (emacs_readlink): New function.
12604 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12605 ../lib/careadlinkat.h.
12607 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12609 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12610 first non-nil return value).
12612 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12614 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12615 if not defined (Bug#8403).
12617 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12619 * xdisp.c (display_count_lines): Remove parameter `start',
12620 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12621 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12622 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12623 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12624 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12625 and thereabouts. All callers changed.
12626 (get_per_char_metric): Remove parameter `f', unused since
12627 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12629 2011-04-02 Jim Meyering <meyering@redhat.com>
12631 do not dereference NULL upon failed strdup
12632 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12633 (ns_get_family): Likewise.
12635 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12637 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12639 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12641 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12644 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12646 Add lexical binding.
12648 * window.c (Ftemp_output_buffer_show): New fun.
12649 (Fsave_window_excursion):
12650 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12652 * lread.c (lisp_file_lexically_bound_p): New function.
12653 (Fload): Bind Qlexical_binding.
12654 (readevalloop): Remove `evalfun' arg.
12655 Bind Qinternal_interpreter_environment.
12656 (Feval_buffer): Bind Qlexical_binding.
12657 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12659 (syms_of_lread): Declare `lexical-binding'.
12661 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12663 * keyboard.c (eval_dyn): New fun.
12664 (menu_item_eval_property): Use it.
12666 * image.c (parse_image_spec): Use Ffunctionp.
12668 * fns.c (concat, mapcar1): Accept byte-code-functions.
12670 * eval.c (Fsetq): Handle lexical vars.
12671 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12672 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12673 (FletX, Flet): Obey lexical binding.
12674 (Fcommandp): Handle closures.
12675 (Feval): New `lexical' arg.
12676 (eval_sub): New function extracted from Feval. Use it almost
12677 everywhere where Feval was used. Look up vars in lexical env.
12679 (Ffunctionp): Move from subr.el.
12680 (Ffuncall): Handle closures.
12681 (apply_lambda): Remove `eval_flags'.
12682 (funcall_lambda): Handle closures and new byte-code-functions.
12683 (Fspecial_variable_p): New function.
12684 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12685 but without exporting it to Lisp.
12687 * doc.c (Fdocumentation, store_function_docstring):
12688 * data.c (Finteractive_form): Handle closures.
12690 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12693 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12695 (exec_byte_code): New function extracted from Fbyte_code to handle new
12696 calling convention for byte-code-functions. Add new byte-codes.
12698 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12700 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12702 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12704 * xdisp.c (redisplay_internal): Fix prototype.
12706 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12708 * xdisp.c (SCROLL_LIMIT): New macro.
12709 (try_scrolling): Use it when setting scroll_limit.
12710 Limit scrolling to 100 screen lines.
12711 (redisplay_window): Even when falling back on "recentering",
12712 position point in the window according to scroll-conservatively,
12713 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12715 (try_scrolling): When point is above the window, allow searching
12716 as far as scroll_max, or one screenful, to compute vertical
12717 distance from PT to the scroll margin position. This prevents
12718 try_scrolling from unnecessarily failing when
12719 scroll-conservatively is set to a value slightly larger than the
12720 window height. Clean up the case of PT below the margin at bottom
12721 of window: scroll_max can no longer be INT_MAX. When aggressive
12722 scrolling is in use, don't let point enter the opposite scroll
12723 margin as result of the scroll.
12724 (syms_of_xdisp) <scroll-conservatively>: Document the
12725 threshold of 100 lines for never-recentering scrolling.
12727 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12729 * dispextern.h (move_it_by_lines):
12730 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12731 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12732 (message_log_check_duplicate): Remove parameters `prev_bol' and
12733 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12734 (redisplay_internal): Remove parameter `preserve_echo_area',
12735 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12737 * indent.c (Fvertical_motion):
12738 * window.c (window_scroll_pixel_based, Frecenter):
12739 Don't pass `need_y_p' to `move_it_by_lines'.
12741 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12743 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12744 steal a few bits to be more compact.
12745 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12746 Remove unneeded casts.
12748 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12750 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12752 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12753 binding" message (bug#7967).
12755 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12757 Fix more problems found by GCC 4.6.0's static checks.
12759 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12760 Remove unused local var.
12762 * editfns.c (Fmessage_box): Remove unused local var.
12764 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12765 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12766 Omit unused local vars.
12767 * window.c (shrink_windows): Omit unused local var.
12768 * menu.c (digest_single_submenu): Omit unused local var.
12769 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12770 Omit unused local var.
12772 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12773 Don't assume string length fits in int.
12774 (keyremap_step, read_key_sequence): Use size_t for sizes.
12775 (read_key_sequence): Don't check last_real_key_start redundantly.
12777 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12778 instead of alloca (Bug#8344).
12780 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12781 (Fbacktrace_frame): Don't assume nframes fits in int.
12783 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12785 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12788 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12790 * cm.c (calccost): Turn while-do into do-while, for clarity.
12792 * keyboard.c (syms_of_keyboard): Use the same style as later
12793 in this function when indexing through an array. This also
12794 works around GCC bug 48267.
12796 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12798 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12800 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12801 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12803 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12804 This avoids undefined behavior on integer overflow, and is a bit
12805 more convenient anyway since it is compared to a size_t variable.
12807 Variadic C functions now count arguments with size_t, not int.
12808 This avoids an unnecessary limitation on 64-bit machines, which
12809 caused (substring ...) to crash on large vectors (Bug#8344).
12810 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12811 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12812 All variadic functions and their callers changed accordingly.
12813 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12814 * data.c (arith_driver, float_arith_driver): Likewise.
12815 * editfns.c (general_insert_function): Likewise.
12816 * eval.c (struct backtrace.nargs, interactive_p)
12817 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12818 (funcall_lambda, mark_backtrace): Likewise.
12819 * fns.c (concat): Likewise.
12820 * frame.c (x_set_frame_parameters): Likewise.
12821 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12822 0 if not found, not -1. All callers changed.
12824 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12825 (stack_copy_size): Now size_t, not int.
12826 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12828 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12830 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12831 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12832 All callers changed.
12834 * lisp.h (multibyte_char_to_unibyte):
12835 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12836 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12837 * character.h (CHAR_TO_BYTE8):
12838 * cmds.c (internal_self_insert):
12839 * editfns.c (general_insert_function):
12840 * keymap.c (push_key_description):
12841 * search.c (Freplace_match):
12842 * xdisp.c (message_dolog, set_message_1): All callers changed.
12844 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12846 * keyboard.c (safe_run_hook_funcall): New function.
12847 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12848 don't set the hook to nil, but remove the offending function instead.
12849 (Qcommand_hook_internal): Remove, unused.
12850 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12851 Vcommand_hook_internal.
12853 * eval.c (enum run_hooks_condition): Remove.
12854 (funcall_nil, funcall_not): New functions.
12855 (run_hook_with_args): Call each function through a `funcall' argument.
12856 Remove `cond' argument, now redundant.
12857 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12858 (Frun_hook_with_args_until_failure): Adjust accordingly.
12859 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12861 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12863 * dispextern.h (string_buffer_position): Remove declaration.
12865 * print.c (strout): Remove parameter `multibyte', unused since
12866 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12868 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12869 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12870 All callers changed.
12872 * w32.c (_wsa_errlist): Use braces for struct initializers.
12874 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12875 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12876 All callers changed.
12877 (string_buffer_position): Likewise. Also, make static (it's never
12878 used outside xdisp.c).
12879 (cursor_row_p): Remove parameter `w', unused since
12880 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12881 (decode_mode_spec): Remove parameter `precision', introduced during
12882 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12883 All callers changed.
12885 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12887 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12889 2011-03-27 Anders Lindgren <andlind@gmail.com>
12891 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12892 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12893 (ns_update_auto_hide_menu_bar): New functions.
12894 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12895 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12896 ns_constrain_all_frames.
12897 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12898 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12900 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12902 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12904 2011-03-27 Glenn Morris <rgm@gnu.org>
12906 * syssignal.h: Replace RETSIGTYPE with void.
12907 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12908 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12909 Replace SIGTYPE with void everywhere.
12910 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12911 * s/template.h (SIGTYPE): Remove commented out definition.
12913 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12915 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12916 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12918 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12920 * w32.c (read_unc_volume): Use parameter `henum', instead of
12921 global variable `wget_enum_handle'.
12923 * keymap.c (describe_vector): Remove parameters `indices' and
12924 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12925 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12927 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12929 * keyboard.c (timer_check): Remove parameter `do_it_now',
12930 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12931 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12932 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12934 * keyboard.c (read_char):
12935 * w32menu.c (w32_menu_display_help):
12936 * xmenu.c (show_help_event, menu_help_callback):
12937 Adjust calls to `show_help_echo'.
12939 * gtkutil.c (xg_maybe_add_timer):
12940 * keyboard.c (readable_events):
12941 * process.c (wait_reading_process_output):
12942 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12944 * insdel.c (adjust_markers_gap_motion):
12945 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12946 (gap_left, gap_right): Don't call it.
12948 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12950 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12951 incurred during fontification.
12953 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12955 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12956 (DEFVAR_PER_BUFFER): Don't pass it.
12958 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12959 (scrolling_window): Don't pass it.
12961 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12963 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12965 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12967 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12968 of variables specific to SELinux and computation of `encoded_absname'.
12970 * image.c (XPutPixel): Remove unused variable `height'.
12972 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12974 * unexw32.c (get_section_info): Remove unused variable `section'.
12976 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12977 (system_process_attributes): Remove unused variable `sess'.
12978 (sys_read): Remove unused variable `err'.
12980 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12981 (w32_wnd_proc): Remove unused variable `isdead'.
12982 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12983 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12984 (x_create_tip_frame): Remove unused variable `tem'.
12986 * w32inevt.c (w32_console_read_socket):
12987 Remove unused variable `no_events'.
12989 * w32term.c (x_draw_composite_glyph_string_foreground):
12990 Remove unused variable `width'.
12992 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12994 * w32term.c (x_set_glyph_string_clipping):
12995 Don't pass uninitialized region to CombineRgn.
12997 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12999 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13000 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13001 (Fx_close_connection): Remove unused variable `i'.
13003 * w32font.c (w32font_draw): Return number of glyphs.
13004 (w32font_open_internal): Remove unused variable `i'.
13005 (w32font_driver): Add missing initializer.
13007 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13008 (fill_in_menu): Remove unused variable `items_added'.
13010 * w32term.c (last_mouse_press_frame): Remove static global variable.
13011 (w32_clip_to_row): Remove unused variable `f'.
13012 (x_delete_terminal): Remove unused variable `i'.
13014 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13015 (NOTHING): Remove unused static global variable.
13016 (uniscribe_check_otf): Remove unused variable `table'.
13017 (uniscribe_font_driver): Add missing initializers.
13019 2011-03-23 Julien Danjou <julien@danjou.info>
13021 * term.c (Fsuspend_tty, Fresume_tty):
13022 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13023 * window.c (temp_output_buffer_show):
13024 * insdel.c (signal_before_change):
13025 * frame.c (Fhandle_switch_frame):
13026 * fileio.c (Fdo_auto_save):
13027 * emacs.c (Fkill_emacs):
13028 * editfns.c (save_excursion_restore):
13029 * cmds.c (internal_self_insert):
13030 * callint.c (Fcall_interactively):
13031 * buffer.c (Fkill_all_local_variables):
13032 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13034 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13035 unconditionally since it does the check itself.
13037 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13039 Fix more problems found by GCC 4.5.2's static checks.
13041 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13042 the first time through the loop, since we know p0 < p1 then.
13043 This also avoids a gcc -Wstrict-overflow warning.
13045 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13046 leading to a memory leak, possible in functions like
13047 load_charset_map_from_file that can allocate an unbounded number
13048 of objects (Bug#8318).
13050 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13051 that could (at least in theory) be that large.
13053 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13054 This is less likely to overflow, and avoids undefined behavior if
13055 overflow does occur. All callers changed. Use strtoul to scan
13056 for the unsigned long integer.
13057 (pint2hrstr): Simplify and tune code slightly.
13058 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13060 * scroll.c (do_scrolling): Work around GCC bug 48228.
13061 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13063 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13064 This also avoids a warning with gcc -Wstrict-overflow.
13065 (validate_x_resource_name): Simplify count usage.
13066 This also avoids a warning with gcc -Wstrict-overflow.
13068 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13071 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13073 * process.c (Fmake_network_process): Use socklen_t, not int,
13074 where POSIX says socklen_t is required in portable programs.
13075 This fixes a porting bug on hosts like 64-bit HP-UX, where
13076 socklen_t is wider than int (Bug#8277).
13077 (Fmake_network_process, server_accept_connection):
13078 (wait_reading_process_output, read_process_output):
13081 * process.c: Rename or move locals to avoid shadowing.
13082 (list_processes_1, Fmake_network_process):
13083 (read_process_output_error_handler, exec_sentinel_error_handler):
13084 Rename or move locals.
13085 (Fmake_network_process): Define label "retry_connect" only if needed.
13086 (Fnetwork_interface_info): Fix pointer signedness.
13087 (process_send_signal): Add cast to avoid pointer signedness problem.
13088 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13089 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13091 Make tparam.h and terminfo.c consistent.
13092 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13093 Include tparam.h instead, since it declares them.
13094 * cm.h (PC): Remove extern decl; tparam.h now does this.
13095 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13096 * terminfo.c: Include tparam.h, to check interfaces.
13097 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13098 (tparam): Adjust signature to match interface in tparam.h;
13099 this removes some undefined behavior. Check that outstring and len
13100 are zero, which they always are with Emacs.
13101 * tparam.h (PC, BC, UP): New extern decls.
13103 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13104 (xftfont_open): Rename locals to avoid shadowing.
13106 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13107 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13108 (OTF_TAG_SYM): Omit macro if not needed.
13109 (ftfont_list): Remove unused local.
13110 (get_adstyle_property, ftfont_pattern_entity):
13111 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13112 Rename locals to avoid shadowing.
13114 * xfont.c (xfont_list_family): Mark var as initialized.
13116 * xml.c (make_dom): Now static.
13118 * composite.c (composition_compute_stop_pos): Rename local to
13120 (composition_reseat_it): Remove unused locals.
13121 (find_automatic_composition, composition_adjust_point): Likewise.
13122 (composition_update_it): Mark var as initialized.
13123 (find_automatic_composition): Mark vars as initialized,
13124 with a FIXME (Bug#8290).
13126 character.h: Rename locals to avoid shadowing.
13127 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13128 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13129 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13130 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13131 to avoid shadowing.
13133 * textprop.c (property_change_between_p): Remove; unused.
13135 * intervals.c (interval_start_pos): Now static.
13137 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13139 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13140 Rename locals to avoid shadowing.
13142 * sound.c (wav_play, au_play, Fplay_sound_internal):
13143 Fix pointer signedness.
13144 (alsa_choose_format): Remove unused local var.
13145 (wav_play): Initialize a variable to 0, to prevent undefined
13146 behavior (Bug#8278).
13148 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13150 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13152 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13153 clobbering (Bug#8298).
13154 * sysdep.c (sys_subshell): Likewise.
13155 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13157 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13158 This should get cleaned up, so that child_setup has the
13159 same signature on all platforms.
13161 * callproc.c (call_process_cleanup): Now static.
13162 (relocate_fd): Rename locals to avoid shadowing.
13164 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13166 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13167 not to be necessary, and produces flickering.
13169 2011-03-20 Glenn Morris <rgm@gnu.org>
13171 * config.in: Remove file.
13173 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13175 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13176 are now in src/globals.h.
13177 (syms_of_minibuf): Remove spurious & from previous change.
13179 2011-03-20 Leo Liu <sdl.web@gmail.com>
13181 * minibuf.c (completing-read-function): New variable.
13182 (completing-read-default): Rename from completing-read.
13183 (completing-read): Call completing-read-function.
13185 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13187 * xfaces.c (Fx_load_color_file):
13188 Read color file from absolute filename (bug#8250).
13190 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13192 * makefile.w32-in: Update dependencies.
13194 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13196 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13198 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13200 Fix more problems found by GCC 4.5.2's static checks.
13202 * process.c (make_serial_process_unwind, send_process_trap):
13203 (sigchld_handler): Now static.
13205 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13206 That way, the code declares only the vars that it needs.
13207 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13208 * s/cygwin.h (PTY_ITERATION): Likewise.
13209 * s/darwin.h (PTY_ITERATION): Likewise.
13210 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13212 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13213 * process.c (allocate_pty): Don't declare stb unless it's needed.
13215 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13216 (CONSTANTLIM): Remove; unused.
13217 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13218 Define only if needed.
13220 * unexelf.c (unexec): Name an expression,
13221 to avoid gcc -Wbad-function-cast warning.
13222 Use a different way to cause a compilation error if anyone uses
13223 n rather than nn, a way that does not involve shadowing.
13224 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13226 * deps.mk (unexalpha.o): Remove; unused.
13228 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13229 * unexec.h: New file.
13230 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13231 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13232 Depend on unexec.h.
13233 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13234 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13235 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13236 Change as necessary to match prototype in unexec.h.
13238 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13240 (back_comment, skip_chars): Mark vars as initialized.
13242 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13243 Rename locals to avoid shadowing.
13245 * lread.c (read1): Rewrite so as not to use empty "else".
13246 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13248 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13250 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13251 warning when compiling print.c.
13253 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13254 instead of using an uninitialized var.
13255 (font_sort_entities): Mark var as initialized.
13257 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13259 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13260 pointers to constants.
13261 (font_parse_fcname): Remove unused vars.
13262 (font_delete_unmatched): Now static.
13263 (font_get_spec): Remove; unused.
13264 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13265 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13266 Rename or move locals to avoid shadowing.
13268 * fns.c (require_nesting_list, require_unwind): Now static.
13269 (Ffillarray): Rename locals to avoid shadowing.
13271 * floatfns.c (domain_error2): Define only if needed.
13272 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13274 * alloc.c (mark_backtrace): Move decl from here ...
13275 * lisp.h: ... to here, so that it can be checked.
13277 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13278 (Fdefvar): Rewrite so as not to use empty "else".
13279 (lisp_indirect_variable): Name an expression,
13280 to avoid gcc -Wbad-function-cast warning.
13281 (Fdefvar): Rename locals to avoid shadowing.
13283 * callint.c (quotify_arg, quotify_args): Now static.
13284 (Fcall_interactively): Rename locals to avoid shadowing.
13285 Use const pointer when appropriate.
13287 * lisp.h (get_system_name, get_operating_system_release):
13288 Move decls here, to check interfaces.
13289 * process.c (get_operating_system_release): Move decl to lisp.h.
13290 * xrdb.c (get_system_name): Likewise.
13291 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13292 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13293 some of which prompt warnings from gcc -Wbad-function-cast.
13294 (Fformat_time_string, Fencode_time, Finsert_char):
13295 (Ftranslate_region_internal, Fformat):
13296 Rename or remove local vars to avoid shadowing.
13297 (Ftranslate_region_internal): Mark var as initialized.
13299 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13302 * lisp.h (eassert): Check that the argument compiles, even if
13303 ENABLE_CHECKING is not defined.
13305 * data.c (Findirect_variable): Name an expression, to avoid
13306 gcc -Wbad-function-cast warning.
13307 (default_value, arithcompare, arith_driver, arith_error): Now static.
13308 (store_symval_forwarding): Rename local to avoid shadowing.
13309 (Fmake_variable_buffer_local, Fmake_local_variable):
13310 Mark variables as initialized.
13311 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13313 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13314 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13315 Rename locals to avoid shadowing.
13316 (mark_stack): Move local variables into the #ifdef region where
13318 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13319 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13321 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13322 (GC_STRING_CHARS): Remove; not used.
13323 (Fmemory_limit): Cast sbrk's returned value to char *.
13325 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13326 avoids undefined behavior in theory.
13328 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13330 Use functions, not macros, for up- and down-casing (Bug#8254).
13331 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13332 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13333 to use the following functions instead of these macros.
13334 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13335 EMACS_INT, since callers assume the returned value fits in int.
13336 (upcase1): Likewise, for UPCASE_TABLE.
13337 (uppercasep, lowercasep, upcase): New static inline functions.
13338 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13339 the race-condition problem in the old DOWNCASE.
13341 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13342 Rename locals to avoid shadowing.
13343 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13344 (regex_compile, re_search_2, re_match_2_internal):
13345 Remove unused local vars.
13346 (FREE_VAR): Rewrite so as not to use empty "else",
13347 which gcc can warn about.
13348 (regex_compile, re_match_2_internal): Mark locals as initialized.
13349 (RETALLOC_IF): Define only if needed.
13350 (WORDCHAR_P): Likewise. This one is never needed, but is used
13351 only in a comment talking about a compiler bug, so put inside
13352 the #if 0 of that comment.
13353 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13354 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13357 * search.c (boyer_moore): Rename locals to avoid shadowing.
13358 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13359 (PREV_CHAR_BOUNDARY): Likewise.
13361 * search.c (simple_search): Remove unused var.
13363 * dired.c (compile_pattern): Move decl from here ...
13364 * lisp.h: ... to here, so that it can be checked.
13365 (struct re_registers): New forward decl.
13367 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13369 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13371 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13372 Rename locals to avoid shadowing.
13373 (Fvertical_motion): Mark locals as initialized.
13375 * casefiddle.c (casify_object, casify_region): Now static.
13376 (casify_region): Mark local as initialized.
13378 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13380 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13381 New macros, so that the caller can use some names other than
13382 gcpro1, gcpro2, etc.
13383 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13385 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13386 argument, for consistency with GCPRO2_VAR, etc: it is now the
13387 prefix of the variable, not the variable itself. All uses
13389 * dired.c (directory_files_internal, file_name_completion):
13390 Rename locals to avoid shadowing.
13392 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13393 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13394 dired.c's scmp function, had undefined behavior.
13395 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13396 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13397 * buffer.h: ... to here, because these macros use current_buffer,
13398 and the new implementation with inline functions needs to have
13399 current_buffer in scope now, rather than later when the macros
13401 (downcase, upcase1): New static inline functions.
13402 (DOWNCASE, UPCASE1): Reimplement using these functions.
13403 This avoids undefined behavior in expressions like
13404 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13405 from race conditions in accessing the global variables
13406 case_temp1 and case_temp2.
13407 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13408 * lisp.h (case_temp1, case_temp2): Remove their decls.
13409 * character.h (ASCII_CHAR_P): Move from here ...
13410 * lisp.h: ... to here, so that the inline functions mentioned
13411 above can use them.
13413 * dired.c (directory_files_internal_unwind): Now static.
13415 * fileio.c (file_name_as_directory, directory_file_name):
13416 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13418 (file_name_as_directory): Use const pointers when appropriate.
13419 (Fexpand_file_name): Likewise. In particular, newdir might
13420 point at constant storage, so make it a const pointer.
13421 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13422 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13424 (Fset_file_times, Finsert_file_contents, auto_save_error):
13425 Rename locals to avoid shadowing.
13427 * minibuf.c (choose_minibuf_frame_1): Now static.
13428 (Ftry_completion, Fall_completions): Rename or remove locals
13429 to avoid shadowing.
13431 * marker.c (bytepos_to_charpos): Remove; unused.
13433 * lisp.h (verify_bytepos, count_markers): New decls,
13434 so that gcc does not warn that these functions aren't declared.
13436 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13437 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13438 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13439 (copy_text): Remove unused local var.
13441 * filelock.c (within_one_second): Now static.
13442 (lock_file_1): Rename local to avoid shadowing.
13444 * buffer.c (fix_overlays_before): Mark locals as initialized.
13445 (fix_start_end_in_overlays): Likewise. This function should be
13446 simplified by using pointers-to-pointers, but that's a different
13448 (switch_to_buffer_1): Now static.
13449 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13450 (report_overlay_modification): Rename locals to avoid shadowing.
13452 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13453 Fix pointer signedness issue.
13454 (sys_subshell): Mark local as volatile if checking for lint,
13455 to suppress a gcc -Wclobbered warning that does not seem to be right.
13456 (MAXPATHLEN): Define only if needed.
13458 * process.c (serial_open, serial_configure): Move decls from here ...
13459 * systty.h: ... to here, so that they can be checked.
13461 * fns.c (get_random, seed_random): Move extern decls from here ...
13462 * lisp.h: ... to here, so that they can be checked.
13464 * sysdep.c (reset_io): Now static.
13465 (wait_for_termination_signal): Remove; unused.
13467 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13468 (copy_keymap_item, append_key, push_text_char_description):
13470 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13471 (DENSE_TABLE_SIZE): Remove; unused.
13472 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13473 (describe_map_tree):
13474 Rename locals to avoid shadowing.
13476 * keyboard.c: Declare functions static if they are not used elsewhere.
13477 (echo_char, echo_dash, cmd_error, top_level_2):
13478 (poll_for_input, handle_async_input): Now static.
13479 (read_char, kbd_buffer_get_event, make_lispy_position):
13480 (make_lispy_event, make_lispy_movement, apply_modifiers):
13481 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13482 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13483 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13484 (read_key_sequence, read_char): Mark locals as initialized.
13485 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13487 * keyboard.h (make_ctrl_char): New decl.
13488 (mark_kboards): Move decl here ...
13489 * alloc.c (mark_kboards): ... from here.
13491 * lisp.h (force_auto_save_soon): New decl.
13493 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13494 (DEFINE_DUMMY_FUNCTION): New macro.
13495 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13497 (main): Add casts to avoid warnings
13498 if GCC considers string literals to be constants.
13500 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13502 * dbusbind.c: Pointer signedness fixes.
13503 (xd_signature, xd_append_arg, xd_initialize):
13504 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13505 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13506 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13507 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13509 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13510 if GCC considers string literals to be constants.
13511 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13513 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13515 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13516 (print_preprocess, print_object): New macro to fix last change.
13518 * print.c (print_preprocess): Don't forget font objects.
13520 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13522 * emacs.c (USAGE3): Doc fixes.
13524 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13526 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13529 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13531 * lisp.h (VWindow_system, Qfile_name_history):
13532 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13533 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13534 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13536 * w32select.c: Don't #include "keyboard.h".
13537 (run_protected): Add extern declaration for waiting_for_input.
13539 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13540 * w32console.c (detect_input_pending, read_input_pending)
13541 (encode_terminal_code):
13542 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13543 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13544 (w32_system_caret_y, Qfile_name_history):
13545 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13546 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13547 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13548 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13549 * w32proc.c (Qlocal, report_file_error):
13550 * w32term.c (Vwindow_system, updating_frame):
13551 * w32uniscribe.c (initialized, uniscribe_font_driver):
13552 Remove unneeded extern declarations.
13554 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13556 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13558 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13560 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13561 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13562 These macros can no longer be used for assignment.
13564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13565 Assign struct members directly, instead of using BUF_BEGV etc.
13566 (record_buffer_markers, fetch_buffer_markers): New functions for
13567 recording and fetching special buffer markers.
13568 (set_buffer_internal_1, set_buffer_temp): Use them.
13570 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13572 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13574 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13575 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13577 * xdisp.c (hscroll_window_tree):
13578 (reconsider_clip_changes): Use PT instead of BUF_PT.
13580 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13582 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13583 $(EMACS_ROOT)/lib/intprops.h.
13585 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13587 Fix more problems found by GCC 4.5.2's static checks.
13589 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13590 to unsigned char * to avoid compiler diagnostic.
13591 (xg_free_frame_widgets): Make it clear that a local variable is
13592 needed only if USE_GTK_TOOLTIP.
13593 (gdk_window_get_screen): Make it clear that this macro is needed
13594 only if USE_GTK_TOOLTIP.
13595 (int_gtk_range_get_value): New function, which avoids a diagnostic
13596 from gcc -Wbad-function-cast.
13597 (xg_set_toolkit_scroll_bar_thumb): Use it.
13598 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13599 diagnostic from gcc -Wbad-function-cast.
13600 (get_utf8_string, xg_get_file_with_chooser):
13601 Rename locals to avoid shadowing.
13602 (create_dialog): Move locals to avoid shadowing.
13604 * xgselect.c (xg_select): Remove unused var.
13606 * image.c (four_corners_best): Mark locals as initialized.
13607 (gif_load): Initialize transparent_p to zero (Bug#8238).
13608 Mark another local as initialized.
13609 (my_png_error, my_error_exit): Mark with NO_RETURN.
13611 * image.c (clear_image_cache): Now static.
13612 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13613 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13614 (x_edge_detection): Remove unnecessary cast that
13615 gcc -Wbad-function-cast diagnoses.
13616 (gif_load): Fix pointer signedness.
13617 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13618 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13620 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13622 Improve quality of tests for time stamp overflow.
13623 For example, without this patch (encode-time 0 0 0 1 1
13624 1152921504606846976) returns the obviously-bogus value (-948597
13625 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13626 reports time overflow. See
13627 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13628 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13629 * editfns.c: Include limits.h and intprops.h.
13630 (TIME_T_MIN, TIME_T_MAX): New macros.
13631 (time_overflow): Move earlier, to before first use.
13632 (hi_time, lo_time): New functions, for an accurate test for
13633 out-of-range times.
13634 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13635 (Fget_internal_run_time): Don't assume time_t fits in int.
13636 (make_time): Use list2 instead of Fcons twice.
13637 (Fdecode_time): More accurate test for out-of-range times.
13638 (check_tm_member): New function.
13639 (Fencode_time): Use it, to test for out-of-range times.
13640 (lisp_time_argument): Don't rely on undefined left-shift and
13641 right-shift behavior when checking for time stamp overflow.
13643 * editfns.c (time_overflow): New function, refactoring common code.
13644 (Fformat_time_string, Fdecode_time, Fencode_time):
13645 (Fcurrent_time_string): Use it.
13647 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13648 * dired.c (make_time): Move to ...
13649 * editfns.c (make_time): ... here.
13650 * systime.h: Note the move.
13652 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13654 * fringe.c (update_window_fringes): Remove unused variables.
13656 * unexmacosx.c (copy_data_segment): Also copy __got section.
13659 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13661 * termcap.c [MSDOS]: Include "msdos.h".
13662 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13663 Constify `char *' arguments and their references according to
13664 prototypes in tparam.h.
13666 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13668 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13669 Adapt all references accordingly.
13671 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13673 2011-03-11 Tom Tromey <tromey@redhat.com>
13675 * buffer.c (syms_of_buffer): Remove obsolete comment.
13677 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13679 * termhooks.h (encode_terminal_code): Declare prototype.
13681 * msdos.c (encode_terminal_code): Don't declare prototype.
13683 * term.c (encode_terminal_code): Now external again, used by
13684 w32console.c and msdos.c.
13686 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13687 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13689 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13691 Fix some minor problems found by GCC 4.5.2's static checks.
13693 * fringe.c (update_window_fringes): Mark locals as initialized
13695 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13697 * alloc.c (mark_fringe_data): Move decl from here ...
13698 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13699 to check its interface.
13700 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13702 * fontset.c (free_realized_fontset): Now static.
13703 (Fset_fontset_font): Rename local to avoid shadowing.
13704 (fontset_font): Mark local as initialized.
13705 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13707 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13709 * xselect.c (x_disown_buffer_selections): Remove; not used.
13710 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13711 (x_own_selection, Fx_disown_selection_internal): Rename locals
13712 to avoid shadowing.
13713 (x_handle_dnd_message): Remove local to avoid shadowing.
13715 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13716 so that the caller can use some name other than gcpro1.
13717 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13718 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13719 (Fx_backspace_delete_keys_p):
13720 Use them to avoid shadowing, and rename vars to avoid shadowing.
13721 (x_decode_color, x_set_name, x_window): Now static.
13722 (Fx_create_frame): Add braces to silence GCC warning.
13723 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13724 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13725 Remove unused locals.
13726 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13727 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13728 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13731 * xterm.h (x_mouse_leave): New decl.
13733 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13734 Remove unused functions.
13735 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13736 (x_calc_absolute_position): Now static.
13737 (XTread_socket): Don't define label "out" unless it's used.
13738 Don't declare local "event" unless it's used.
13739 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13740 unless they are used.
13741 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13742 (x_fatal_error_signal): Remove; not used.
13743 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13744 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13745 (x_error_catcher, x_connection_closed, x_error_handler):
13746 (x_error_quitter, xembed_send_message, x_iconify_frame):
13747 (my_log_handler): Rename locals to avoid shadowing.
13748 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13749 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13751 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13752 Rename or move locals to avoid shadowing.
13753 (tty_defined_color, merge_face_heights): Now static.
13754 (free_realized_faces_for_fontset): Remove; not used.
13755 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13756 does not deduce is never used uninitialized.
13757 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13758 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13760 * terminal.c (store_terminal_param): Now static.
13762 * xmenu.c (menu_highlight_callback): Now static.
13763 (set_frame_menubar): Remove unused local.
13764 (xmenu_show): Rename parameter to avoid shadowing.
13765 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13766 since they might point to immutable storage.
13767 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13768 since it's unused otherwise.
13770 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13771 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13772 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13773 avoids a gcc -Wuninitialized diagnostic.
13774 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13775 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13776 does not deduce are never used uninitialized.
13778 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13780 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13781 * window.c (window_loop, size_window):
13782 (run_window_configuration_change_hook, enlarge_window): Likewise.
13784 * window.c (display_buffer): Now static.
13785 (size_window): Mark variables that gcc -Wuninitialized
13786 does not deduce are never used uninitialized.
13787 * window.h (check_all_windows): New decl, to forestall
13788 gcc -Wmissing-prototypes diagnostic.
13789 * dispextern.h (bidi_dump_cached_states): Likewise.
13791 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13793 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13794 Include <limits.h>.
13795 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13796 and to avoid gcc -Wuninitialized warning.
13797 (load_charset_map): Mark variables that gcc -Wuninitialized
13798 does not deduce are never used uninitialized.
13799 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13801 * coding.c (coding_set_source, coding_set_destination):
13802 Use "else { /* comment */ }" rather than "else /* comment */;"
13803 for clarity, and to avoid gcc -Wempty-body warning.
13804 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13805 a block, when the outer 'i' will do.
13806 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13807 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13809 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13810 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13811 Rename locals to avoid shadowing.
13812 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13813 * coding.c (emacs_mule_char, encode_invocation_designation):
13814 Now static, since they're not used elsewhere.
13815 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13816 (decode_coding_object, encode_coding_object, detect_coding_system):
13817 (decode_coding_emacs_mule): Mark variables that gcc
13818 -Wuninitialized does not deduce are never used uninitialized.
13819 (detect_coding_iso_2022): Initialize a local variable that might
13820 be used uninitialized. Leave a FIXME because it's not clear that
13821 this initialization is needed. (Bug#8211)
13822 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13823 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13824 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13825 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13826 Remove unused macros.
13828 * category.c (hash_get_category_set): Remove unused local var.
13829 (copy_category_table): Now static, since it's not used elsewhere.
13830 * character.c (string_count_byte8): Likewise.
13832 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13833 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13835 * chartab.c (copy_sub_char_table): Now static, since it's not used
13837 (sub_char_table_ref_and_range, char_table_ref_and_range):
13838 Rename locals to avoid shadowing.
13839 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13841 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13842 (BIDI_BOB): Remove unused macro.
13844 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13845 deduce are never used uninitialized.
13846 * term.c (encode_terminal_code): Likewise.
13848 * term.c (encode_terminal_code): Now static. Remove unused local.
13850 * tparam.h: New file.
13851 * term.c, tparam.h: Include it.
13852 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13853 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13854 Move these decls to tparam.h, and make them agree with what
13855 is actually in tparam.c. The previous trick of using incompatible
13856 decls in different modules does not conform to the C standard.
13857 All callers of tparam changed to use tparam's actual API.
13858 * tparam.c (tparam1, tparam, tgoto):
13859 Use const pointers where appropriate.
13861 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13862 * cm.h (struct cm): Likewise.
13863 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13864 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13865 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13866 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13867 (turn_on_face, init_tty): Likewise.
13868 * termchar.h (struct tty_display_info): Likewise.
13870 * term.c (term_mouse_position): Rename local to avoid shadowing.
13872 * alloc.c (mark_ttys): Move decl from here ...
13873 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13875 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13877 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13879 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13881 * search.c (compile_pattern_1): Remove argument regp, unused since
13882 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13883 (compile_pattern): Don't pass it.
13885 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13887 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13888 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13890 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13892 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13894 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13895 gdk_window_get_screen, gdk_window_get_geometry,
13896 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13897 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13898 (xg_get_pixbuf_from_pixmap): New function.
13899 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13900 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13901 Call xg_get_pixbuf_from_pixmap instead of
13902 gdk_pixbuf_get_from_drawable.
13903 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13904 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13905 (xg_check_special_colors): Use GtkStyleContext and its functions
13907 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13908 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13909 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13910 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13911 Call gtk_widget_get_preferred_size.
13912 (xg_frame_resized): gdk_window_get_geometry only takes 5
13914 (xg_win_to_widget, xg_event_is_for_menubar):
13915 Call gdk_x11_window_lookup_for_display.
13916 (xg_set_widget_bg): New function.
13917 (delete_cb): New function.
13918 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13919 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13920 (xg_set_background_color): Call xg_set_widget_bg.
13921 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13922 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13923 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13924 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13926 (update_frame_tool_bar): Call gtk_widget_hide.
13927 (xg_initialize): Use GDK_KEY_g.
13929 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13931 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13933 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13934 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13935 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13937 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13939 * w32xfns.c (select_palette): Check success of RealizePalette against
13940 GDI_ERROR, not zero.
13942 See ChangeLog.11 for earlier changes.
13944 ;; Local Variables:
13948 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13950 This file is part of GNU Emacs.
13952 GNU Emacs is free software: you can redistribute it and/or modify
13953 it under the terms of the GNU General Public License as published by
13954 the Free Software Foundation, either version 3 of the License, or
13955 (at your option) any later version.
13957 GNU Emacs is distributed in the hope that it will be useful,
13958 but WITHOUT ANY WARRANTY; without even the implied warranty of
13959 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13960 GNU General Public License for more details.
13962 You should have received a copy of the GNU General Public License
13963 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
HCoop / bpt / emacs.git / blob