1 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4 rather than `XVECTOR (FOO)->size'.
6 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7 inttypes.h, as a gnulib replacement is used if it not available in
10 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14 of MOST_POSITIVE_FIXNUM. (Bug#8528)
16 * coding.c (coding_alloc_by_realloc): Error out if destination
17 will grow beyond MOST_POSITIVE_FIXNUM.
18 (decode_coding_emacs_mule): Abort if there isn't enough place in
19 charbuf for the composition carryover bytes. Reserve an extra
20 space for up to 2 characters produced in a loop.
21 (decode_coding_iso_2022): Abort if there isn't enough place in
22 charbuf for the composition carryover bytes.
24 2011-04-21 Eli Zaretskii <eliz@gnu.org>
26 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
27 aborting when %lld or %lll format is passed.
28 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
29 %llo or %llx format is passed. (Bug#8545)
31 * window.c (window_scroll_line_based): Use a marker instead of
32 simple variables to record original value of point. (Bug#7952)
34 * doprnt.c (doprnt): Fix the case where a multibyte sequence
35 produced by %s or %c overflows available buffer space. (Bug#8545)
37 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
39 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
40 (SIZE_MAX): Move defn after all includes, as they might #define it.
42 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
44 * w32.c (init_environment): Warn about defaulting HOME to C:\.
46 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
48 * keyboard.c (Qdelayed_warnings_hook): Define.
49 (command_loop_1): Run `delayed-warnings-hook'
50 if Vdelayed_warnings_list is non-nil.
51 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
52 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
54 2011-04-28 Eli Zaretskii <eliz@gnu.org>
56 * doprnt.c (doprnt): Don't return value smaller than the buffer
57 size if the message was truncated. (Bug#8545).
59 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
61 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
62 (Fx_window_property): #if-0 the whole functions, not just the bodies.
64 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
66 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
68 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
70 * makefile.w32-in: Update dependencies.
72 2011-04-27 Eli Zaretskii <eliz@gnu.org>
74 Improve `doprnt' and its usage. (Bug#8545)
75 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
76 `format_end'. Remove support for %l as a conversion specifier.
77 Don't use xrealloc. Improve diagnostics when the %l size modifier
78 is used. Update the commentary.
80 * eval.c (verror): Simplify calculation of size_t.
82 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
85 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
87 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
90 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
92 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
93 This makes this file independent of the recent pseudovector change.
95 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
97 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
99 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
100 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
102 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
104 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
105 GCC 4.6.0 optimizes based on type-based alias analysis. For
106 example, if b is of type struct buffer * and v of type struct
107 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
108 != &v->size, and therefore "v->size = 1; b->size = 2; return
109 v->size;" must therefore return 1. This assumption is incorrect
110 for Emacs, since it type-puns struct Lisp_Vector * with many other
111 types. To fix this problem, this patch adds a new type struct
112 vectorlike_header that documents the constraints on layout of vectors
113 and pseudovectors, and helps optimizing compilers not get fooled
114 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
115 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
116 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
118 (XSETPVECTYPE): Rewrite in terms of new macro.
119 (XSETPVECTYPESIZE): New macro, specifying both type and size.
120 This is a bit clearer, and further avoids the possibility of
121 undesirable aliasing.
122 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
123 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
124 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
125 since Lisp_Subr is a special case (no "next" field).
126 (ASIZE): Now uses header.size rather than size. All
127 previous uses of XVECTOR (foo)->size replaced to use this macro,
128 to avoid the hassle of writing XVECTOR (foo)->header.size.
129 (struct vectorlike_header): New type.
130 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
131 object, to help avoid aliasing.
132 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
133 (SUBRP): Likewise, since Lisp_Subr is a special case.
134 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
135 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
136 (struct Lisp_Hash_Table): Combine first two members into a single
137 struct vectorlike_header member. All uses of "size" and "next" members
138 changed to be "header.size" and "header.next".
139 * buffer.h (struct buffer): Likewise.
140 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
141 * frame.h (struct frame): Likewise.
142 * process.h (struct Lisp_Process): Likewise.
143 * termhooks.h (struct terminal): Likewise.
144 * window.c (struct save_window_data, struct saved_window): Likewise.
145 * window.h (struct window): Likewise.
146 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
147 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
148 * buffer.c (init_buffer_once): Likewise.
149 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
151 * process.c (Fformat_network_address): Use local var for size,
154 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
156 Make the Lisp reader and string-to-float more consistent (Bug#8525)
157 * data.c (atof): Remove decl; no longer used or needed.
158 (digit_to_number): Move to lread.c.
159 (Fstring_to_number): Use new string_to_number function, to be
160 consistent with how the Lisp reader treats infinities and NaNs.
161 Do not assume that floating-point numbers represent EMACS_INT
162 without losing information; this is not true on most 64-bit hosts.
163 Avoid double-rounding errors, by insisting on integers when
164 parsing non-base-10 numbers, as the documentation specifies.
165 * lisp.h (string_to_number): New decl, replacing ...
166 (isfloat_string): Remove.
167 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
168 (read1): Do not accept +. and -. as integers; this
169 appears to have been a coding error. Similarly, do not accept
170 strings like +-1e0 as floating point numbers. Do not report
171 overflow for integer overflows unless the base is not 10 which
172 means we have no simple and reliable way to continue.
173 Break out the floating-point parsing into a new
174 function string_to_number, so that Fstring_to_number parses
175 floating point numbers consistently with the Lisp reader.
176 (digit_to_number): Moved here from data.c. Make it static inline.
177 (E_CHAR, EXP_INT): Remove, replacing with ...
178 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
179 (string_to_number): New function, replacing isfloat_string.
180 This function checks for valid syntax and produces the resulting
181 Lisp float number too. Rework it so that string-to-number
182 no longer mishandles examples like "1.0e+". Use strtoumax,
183 so that overflow for non-base-10 numbers is reported only when
184 there's no portable and simple way to convert to floating point.
186 * textprop.c (set_text_properties_1): Rewrite for clarity,
187 and to avoid GCC warning about integer overflow.
189 * intervals.h (struct interval): Use EMACS_INT for members
190 where EMACS_UINT might cause problems. See
191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
192 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
193 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
195 (offset_intervals): Tell GCC not to worry about length overflow
196 when negating a negative length.
198 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
199 (overrun_check_free): Likewise.
201 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
202 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
205 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
206 (gnutls_make_error): Rename local to avoid shadowing.
207 (gnutls_emacs_global_deinit): ifdef out; not used.
208 (Fgnutls_boot): Use const for pointer to readonly storage.
209 Comment out unused local. Fix pointer signedness problems.
211 * lread.c (openp): Don't stuff size_t into an 'int'.
212 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
213 about possible signed overflow.
215 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
216 (GDK_KEY_g): Don't define if already defined.
217 (xg_prepare_tooltip): Avoid pointer signedness problem.
218 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
220 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
221 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
223 * xfns.c (Fx_window_property): Simplify a bit,
224 to make a bit faster and to avoid GCC 4.6.0 warning.
225 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
227 * fns.c (internal_equal): Don't assume size_t fits in int.
229 * alloc.c (compact_small_strings): Tighten assertion a little.
231 Replace pEd with more-general pI, and fix some printf arg casts.
232 * lisp.h (pI): New macro, generalizing old pEd macro to other
233 conversion specifiers. For example, use "...%"pI"d..." rather
235 (pEd): Remove. All uses replaced with similar uses of pI.
236 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
237 * alloc.c (check_pure_size): Don't overflow by converting size to int.
238 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
239 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
240 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
241 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
242 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
244 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
245 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
246 * print.c (safe_debug_print, print_object): Likewise.
247 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
249 Use pI instead of if-then-else-abort. Use %p to avoid casts,
250 avoiding the 0 flag, which is not portable.
251 * process.c (Fmake_network_process): Use pI to avoid cast.
252 * region-cache.c (pp_cache): Likewise.
253 * xdisp.c (decode_mode_spec): Likewise.
254 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
255 behavior on 64-bit hosts with printf arg.
256 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
257 (x_stop_queuing_selection_requests): Likewise.
258 (x_get_window_property): Don't truncate byte count to an 'int'
261 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
262 here, since it parses constructs like leading '-' and spaces,
263 which are not wanted; and it overflows with large numbers.
264 Instead, simply match F[0-9]+, which is what is wanted anyway.
266 * alloc.c: Remove unportable assumptions about struct layout.
267 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
268 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
269 (allocate_vectorlike, make_pure_vector): Use the new macros,
270 plus offsetof, to remove unportable assumptions about struct layout.
271 These assumptions hold on all porting targets that I know of, but
272 they are not guaranteed, they're easy to remove, and removing them
273 makes further changes easier.
275 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
276 This doesn't fix a bug but makes the code clearer.
277 (string_overrun_cookie): Now const. Use initializers that
278 don't formally overflow signed char, to avoid warnings.
279 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
280 can cause Emacs to crash when string overrun checking is enabled.
281 (allocate_buffer): Don't assume sizeof (struct buffer) is a
282 multiple of sizeof (EMACS_INT); it need not be, if
283 alignof(EMACS_INT) < sizeof (EMACS_INT).
284 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
286 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
288 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
290 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
292 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
293 supposed to be handshaking. (Bug#8556)
294 Reported by Paul Eggert <eggert@cs.ucla.edu>.
296 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
298 * lisp.h (Qdebug): List symbol.
299 * eval.c (Qdebug): Restore global linkage.
300 * keyboard.c (debug-on-event): New variable.
301 (handle_user_signal): Break into debugger when debug-on-event
302 matches the current signal symbol.
304 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
306 * alloc.c (check_sblock, check_string_bytes)
307 (check_string_free_list): Convert to standard C.
309 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
311 * w32.c (emacs_gnutls_push): Fix typo.
313 2011-04-25 Eli Zaretskii <eliz@gnu.org>
315 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
316 "cast to pointer from integer of different size".
318 Improve doprnt and its use in verror. (Bug#8545)
319 * doprnt.c (doprnt): Document the set of format control sequences
320 supported by the function. Use SAFE_ALLOCA instead of always
323 * eval.c (verror): Don't limit the buffer size at size_max-1, that
324 is one byte too soon. Don't use xrealloc; instead xfree and
327 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
329 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
332 * gnutls.c: Renamed global_initialized to
333 gnutls_global_initialized. Added internals for the
334 :verify-hostname-error, :verify-error, and :verify-flags
335 parameters of `gnutls-boot' and documented those parameters in the
336 docstring. Start callback support.
337 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
338 unless a fatal error occured. Call gnutls_alert_send_appropriate
339 on error. Return error code.
340 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
341 (emacs_gnutls_read): Likewise.
342 (Fgnutls_boot): Return handshake error code.
343 (emacs_gnutls_handle_error): New function.
344 (wsaerror_to_errno): Likewise.
346 * w32.h (emacs_gnutls_pull): Add prototype.
347 (emacs_gnutls_push): Likewise.
349 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
350 (emacs_gnutls_push): Likewise.
352 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
354 * process.c (wait_reading_process_output): Check if GnuTLS
355 buffered some data internally if no FDs are set for TLS
358 * makefile.w32-in (OBJ2): Add gnutls.$(O).
359 (LIBS): Link to USER_LIBS.
360 ($(BLD)/gnutls.$(0)): New target.
362 2011-04-24 Eli Zaretskii <eliz@gnu.org>
364 * xdisp.c (handle_single_display_spec): Rename the
365 display_replaced_before_p argument into display_replaced_p, to
366 make it consistent with the commentary. Fix typos in the
369 * textprop.c (syms_of_textprop): Remove dead code.
370 (copy_text_properties): Delete obsolete commentary about an
371 interface that was deleted long ago. Fix typos in the description
374 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
375 to changes in oldXMenu/XMenu.h from 2011-04-16.
376 <menu_help_message, prev_menu_help_message>: Constify.
377 (IT_menu_make_room): menu->help_text is now `const char **';
380 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
381 to changes in oldXMenu/XMenu.h from 2011-04-16.
382 (struct XMenu): Declare `help_text' `const char **'.
384 * xfaces.c <Qunspecified>: Make extern again.
386 * syntax.c: Include sys/types.h before including regex.h, as
389 * doc.c (get_doc_string): Improve the format passed to `error'.
391 * doprnt.c (doprnt): Improve commentary.
393 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
395 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
398 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
399 changes in globals.h immediately force recompilation.
400 (TAGS): Depend on $(CURDIR)/m/intel386.h and
401 $(CURDIR)/s/ms-w32.h.
402 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
404 * character.c (Fchar_direction): Function deleted.
405 (syms_of_character): Don't defsubr it.
406 <char-direction-table>: Deleted.
408 2011-04-23 Eli Zaretskii <eliz@gnu.org>
410 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
411 * doprnt.c: Include limits.h.
412 (SIZE_MAX): New macro.
413 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
414 local variables are now size_t instead of int or unsigned.
415 Improve overflow protection. Support `l' modifier for integer
416 conversions. Support %l conversion. Don't assume an EMACS_INT
417 argument for integer conversions and for %c.
419 * lisp.h (doprnt): Restore prototype.
421 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
424 * Makefile.in (base_obj): Add back doprnt.o.
426 * deps.mk (doprnt.o): Add back prerequisites.
427 (callint.o): Depend on character.h.
429 * eval.c (internal_lisp_condition_case): Include the handler
430 representation in the error message.
431 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
432 when breaking from the loop.
434 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
436 * callint.c (Fcall_interactively): When displaying error message
437 about invalid control letter, pass the character's codepoint, not
438 a pointer to its multibyte form. Improve display of the character
439 in octal and display also its hex code.
441 * character.c (char_string): Use %x to display the (unsigned)
442 codepoint of an invalid character, to avoid displaying a bogus
445 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
446 `error', not SYMBOL_NAME itself.
448 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
449 character arguments to `error'.
451 * charset.c (check_iso_charset_parameter): Fix incorrect argument
452 to `error' in error message about FINAL_CHAR argument. Make sure
453 FINAL_CHAR is a character, and use %c when it is passed as
456 2011-04-23 Eli Zaretskii <eliz@gnu.org>
458 * s/ms-w32.h (localtime): Redirect to sys_localtime.
460 * w32.c: Include <time.h>.
461 (sys_localtime): New function.
463 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
465 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
467 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
469 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
471 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
474 2011-04-19 Eli Zaretskii <eliz@gnu.org>
476 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
477 gl_state.e_property when gl_state.object is Qt.
479 * insdel.c (make_gap_larger): Remove limitation of buffer size
482 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
484 * xdisp.c (lookup_glyphless_char_display)
485 (produce_glyphless_glyph): Handle cons cell entry in
486 glyphless-char-display.
487 (Vglyphless_char_display): Document it.
489 * term.c (produce_glyphless_glyph): Handle cons cell entry in
490 glyphless-char-display.
492 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
494 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
496 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
498 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
499 definition for no-X builds.
501 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
503 Static checks with GCC 4.6.0 and non-default toolkits.
505 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
507 * process.c (keyboard_bit_set): Define only if SIGIO.
508 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
509 (send_process): Repair possible setjmp clobbering.
511 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
513 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
515 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
517 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
518 Define only if needed.
520 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
521 by pacifying GCC about it. Maybe it's time to retire it?
522 * xfaces.c (USG, __TIMEVAL__): Likewise.
524 * dispextern.h (struct redisplay_interface): Rename param
526 * termhooks.h (struct terminal): Likewise.
527 * xterm.c (xembed_send_message): Likewise.
529 * insdel.c (make_gap_smaller): Define only if
530 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
532 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
535 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
536 so that we aren't warned about unused symbols.
538 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
540 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
542 * xfns.c (x_real_positions): Mark locals as initialized.
544 * xmenu.c (xmenu_show): Don't use uninitialized vars.
546 * xterm.c: Fix problems found by static analysis with other toolkits.
547 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
548 (x_dispatch_event): Declare static if USE_GTK, and
549 define if USE_GTK || USE_X_TOOLKIT.
550 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
551 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
552 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
553 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
555 * xmenu.c (menu_help_callback): Pointer type fixes.
556 Use const pointers when pointing at readonly data. Avoid pointer
558 (FALSE): Remove unused macro.
559 (update_frame_menubar): Remove unused decl.
561 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
563 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
564 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
565 (single_menu_item): Rename local to avoid shadowing.
567 * keyboard.c (make_lispy_event): Remove unused local var.
569 * frame.c, frame.h (x_get_resource_string): Bring this back, but
570 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
572 * bitmaps: Change bitmaps from unsigned char back to the X11
573 compatible char. Avoid the old compiler warnings about
574 out-of-range initializers by using, for example, '\xab' rather
577 * xgselect.c (xgselect_initialize): Check vs interface
578 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
580 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
582 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
585 * fns.c (vector): Remove; this old hack is no longer needed.
587 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
589 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
591 * xrdb.c (x_load_resources): Omit unused local.
593 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
594 (x_window): Rename locals to avoid shadowing.
595 (USG): Use the kludged USG macro, to pacify gcc.
597 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
598 (x_term_init): Remove local to avoid shadowing.
600 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
602 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
603 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
605 2011-04-16 Eli Zaretskii <eliz@gnu.org>
607 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
609 Fix regex.c, syntax.c and friends for buffers > 2GB.
610 * syntax.h (struct gl_state_s): Declare character position members
613 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
615 * textprop.c (verify_interval_modification, interval_of): Declare
618 * intervals.c (adjust_intervals_for_insertion): Declare arguments
621 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
623 * indent.c (Fvertical_motion): Local variable it_start is now
626 * regex.c (re_match, re_match_2, re_match_2_internal)
627 (bcmp_translate, regcomp, regexec, print_double_string)
628 (group_in_compile_stack, re_search, re_search_2, regex_compile)
629 (re_compile_pattern, re_exec): Declare arguments and local
630 variables `size_t' and `ssize_t' and return values `regoff_t', as
632 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
633 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
634 <compile_stack_type>: `size' and `avail' are now `size_t'.
636 * regex.h <regoff_t>: Use ssize_t, not int.
637 (re_search, re_search_2, re_match, re_match_2): Arguments that
638 specify buffer/string position and length are now ssize_t and
639 size_t. Return type is regoff_t.
641 2011-04-16 Ben Key <bkey76@gmail.com>
643 * nsfont.m: Fixed bugs in ns_get_family and
644 ns_descriptor_to_entity that were caused by using free to
645 deallocate memory blocks that were allocated by xmalloc (via
646 xstrdup). This caused Emacs to crash when compiled with
647 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
648 --enable-checking=xmallocoverrun). xfree is now used to
649 deallocate these memory blocks.
651 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
653 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
655 emacs_write: Accept and return EMACS_INT for sizes.
656 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
658 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
659 Accept and return EMACS_INT.
660 (emacs_gnutls_write): Return the number of bytes written on
662 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
663 (emacs_read, emacs_write): Remove check for negative size, as the
664 Emacs source code has been audited now.
665 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
666 (emacs_read, emacs_write): Use it.
667 * process.c (send_process): Adjust to the new signatures of
668 emacs_write and emacs_gnutls_write. Do not attempt to store
669 a byte offset into an 'int'; it might overflow.
670 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
672 * sound.c: Don't assume sizes fit in 'int'.
673 (struct sound_device.period_size, alsa_period_size):
674 Return EMACS_INT, not int.
675 (struct sound_device.write, vox_write, alsa_write):
676 Accept EMACS_INT, not int.
677 (wav_play, au_play): Use EMACS_INT to store sizes and to
678 record read return values.
680 2011-04-15 Ben Key <bkey76@gmail.com>
682 * keyboard.c (Qundefined): Don't declare static since it is used
684 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
685 static since they are used in nsfont.m.
687 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
689 * process.c (Qprocessp): Don't declare static.
690 * lisp.h (Qprocessp): Declare again.
692 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
694 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
696 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
698 Improve C-level modularity by making more things 'static'.
700 Don't publish debugger-only interfaces to other modules.
701 * lisp.h (safe_debug_print, debug_output_compilation_hack):
702 (verify_bytepos, count_markers): Move decls to the only modules
704 * region-cache.h (pp_cache): Likewise.
705 * window.h (check_all_windows): Likewise.
706 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
708 * sysdep.c (croak): Now static, if
709 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
710 * syssignal.h (croak): Declare only if not static.
712 * alloc.c (refill_memory_reserve): Now static if
713 !defined REL_ALLOC || defined SYSTEM_MALLOC.
714 * lisp.h (refill_memory_reserve): Declare only if not static.
716 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
717 Define only if USE_LUCID.
719 * xrdb.c (x_customization_string, x_rm_string): Now static.
721 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
722 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
724 * xdisp.c (draw_row_with_mouse_face): Now static.
725 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
727 * window.h (check_all_windows): Mark externally visible.
729 * window.c (window_deletion_count): Now static.
731 * undo.c: Make symbols static if they're not exported.
732 (last_undo_buffer, last_boundary_position, pending_boundary):
735 * textprop.c (interval_insert_behind_hooks): Now static.
736 (interval_insert_in_front_hooks): Likewise.
738 * term.c: Make symbols static if they're not exported.
739 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
740 (max_frame_lines, tty_set_terminal_modes):
741 (tty_reset_terminal_modes, tty_turn_off_highlight):
742 (get_tty_terminal): Now static.
743 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
744 * termhooks.h (term_mouse_moveto): Do not declare if
746 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
747 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
749 * sysdep.c: Make symbols static if they're not exported.
750 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
752 (sigprocmask_set, full_mask): Remove; unused.
753 (wait_debugging): Mark as visible.
754 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
755 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
757 * syntax.c (syntax_temp): Define only if !__GNUC__.
759 * sound.c (current_sound_device, current_sound): Now static.
761 * search.c (searchbufs, searchbuf_head): Now static.
763 * scroll.c (scroll_cost): Remove; unused.
764 * dispextern.h (scroll_cost): Remove decl.
766 * region-cache.h (pp_cache): Mark as externally visible.
768 * process.c: Make symbols static if they're not exported.
769 (process_tick, update_tick, create_process, chan_process):
770 (Vprocess_alist, proc_buffered_char, datagram_access):
771 (fd_callback_data, send_process_frame, process_sent_to): Now static.
772 (deactivate_process): Mark defn as static, as well as decl.
773 * lisp.h (create_process): Remove decl.
774 * process.h (chan_process, Vprocess_alist): Remove decls.
776 * print.c: Make symbols static if they're not exported.
777 (print_depth, new_backquote_output, being_printed, print_buffer):
778 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
779 (print_interval, print_number_index, initial_stderr_stream):
781 * lisp.h (Fprinc): Remove decl.
782 (debug_output_compilation_hack): Mark as externally visible.
784 * sysdep.c (croak): Move decl from here to syssignal.h.
785 * syssignal.h (croak): Put it here, so the API can be checked when
786 'croak' is called from dissociate_if_controlling_tty.
788 * minibuf.c: Make symbols static if they're not exported.
789 (minibuf_save_list, choose_minibuf_frame): Now static.
790 * lisp.h (choose_minibuf_frame): Remove decl.
792 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
794 * lread.c: Make symbols static if they're not exported.
795 (read_objects, initial_obarray, oblookup_last_bucket_number):
797 (make_symbol): Remove; unused.
798 * lisp.h (initial_obarray, make_symbol): Remove decls.
800 * keyboard.c: Make symbols static if they're not exported.
801 (single_kboard, recent_keys_index, total_keys, recent_keys):
802 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
803 (this_single_command_key_start, echoing, last_auto_save):
804 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
805 (command_loop, echo_now, keyboard_init_hook, help_char_p):
806 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
807 (Vlispy_mouse_stem, double_click_count):
809 (force_auto_save_soon): Define only if SIGDANGER.
810 (ignore_mouse_drag_p): Now static if
811 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
812 (print_help): Remove; unused.
813 (stop_character, last_timer_event): Mark as externally visible.
814 * keyboard.h (ignore_mouse_drag_p): Declare only if
815 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
816 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
817 * lisp.h (echoing): Remove decl.
818 (force_auto_save_soon): Declare only if SIGDANGER.
819 * xdisp.c (redisplay_window): Simplify code, to make it more
820 obvious that ignore_mouse_drag_p is not accessed if !defined
821 USE_GTK && !defined HAVE_NS.
823 * intervals.c: Make symbols static if they're not exported.
824 (merge_properties_sticky, merge_interval_right, delete_interval):
826 * intervals.h (merge_interval_right, delete_interval): Remove decls.
828 * insdel.c: Make symbols static if they're not exported.
829 However, leave prepare_to_modify_buffer alone. It's never
830 called from outside this function, but that appears to be a bug.
831 (combine_after_change_list, combine_after_change_buffer):
832 (adjust_after_replace, signal_before_change): Now static.
833 (adjust_after_replace_noundo): Remove; unused.
834 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
835 (signal_before_change): Remove decls.
837 * indent.c (val_compute_motion, val_vmotion): Now static.
839 * image.c: Make symbols static if they're not exported.
840 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
842 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
843 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
845 * fringe.c (standard_bitmaps): Now static.
846 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
848 * frame.c: Make symbols static if they're not exported.
849 (x_report_frame_params, make_terminal_frame): Now static.
850 (get_frame_param): Now static, unless HAVE_NS.
851 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
852 (x_get_resource_string): Remove; not used.
853 * frame.h (make_terminal_frame, x_report_frame_params):
854 (x_get_resource_string); Remove decls.
855 (x_fullscreen_adjust): Declare only if WINDOWSNT.
856 * lisp.h (get_frame_param): Declare only if HAVE_NS.
858 * font.c, fontset.c: Make symbols static if they're not exported.
859 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
860 (FACE_SUITABLE_FOR_CHAR_P): Use it.
861 * font.c (font_close_object): Now static.
862 * font.h (font_close_object): Remove.
863 * fontset.c (FONTSET_OBJLIST): Remove.
864 (free_realized_fontset) #if-0 the body, which does nothing.
865 (face_suitable_for_char_p): #if-0, as it's never called.
866 * fontset.h (face_suitable_for_char_p): Remove decl.
867 * xfaces.c (face_at_string_position): Use
868 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
869 since 0 is always ASCII.
871 * fns.c (weak_hash_tables): Now static.
873 * fileio.c: Make symbols static if they're not exported.
874 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
875 (Vwrite_region_annotation_buffers): Now static.
877 * eval.c: Make symbols static if they're not exported.
878 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
879 * lisp.h (backtrace_list): Remove decl.
881 * emacs.c: Make symbols static if they're not exported.
882 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
883 (fatal_error_code, fatal_error_signal_hook, standard_args):
885 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
886 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
887 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
888 * lisp.h (fatal_error_signal_hook): Remove decl.
889 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
891 * editfns.c: Move a (normally-unused) function to its only use.
892 * editfns.c, lisp.h (get_operating_system_release): Remove.
893 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
894 worth the hassle of breaking this out.
896 * xterm.c: Make symbols static if they're not exported.
897 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
898 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
899 (x_destroy_window, x_delete_display):
901 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
902 (x_mouse_leave): Remove; unused.
903 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
904 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
905 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
907 (x_mouse_leave): Declare only if WINDOWSNT.
908 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
909 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
912 * ftxfont.c: Make symbols static if they're not exported.
913 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
915 * font.h (ftxfont_driver): Likewise.
917 * xfns.c: Make symbols static if they're not exported.
918 (x_last_font_name, x_display_info_for_name):
919 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
920 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
921 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
922 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
923 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
924 (last_show_tip_args): Now static.
925 (xic_defaut_fontset, xic_create_fontsetname): Define only if
926 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
927 (x_screen_planes): Remove; unused.
928 * dispextern.h (x_screen_planes): Remove decl.
930 * dispnew.c: Make symbols static if they're not exported.
931 * dispextern.h (redraw_garbaged_frames, scrolling):
932 (increment_row_positions): Remove.
933 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
934 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
936 (redraw_garbaged_frames): Remove; unused.
938 * xfaces.c: Make symbols static if they're not exported.
939 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
941 * xterm.h (defined_color): Remove decls.
942 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
943 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
944 (menu_face_changed_default, defined_color, free_realized_face):
945 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
946 (ascii_face_of_lisp_face): Remove; unused.
948 * xdisp.c: Make symbols static if they're not exported.
949 * dispextern.h (scratch_glyph_row, window_box_edges):
950 (glyph_to_pixel_coords, set_cursor_from_row):
951 (get_next_display_element, set_iterator_to_next):
952 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
953 (show_mouse_face): Remove decls
954 * frame.h (message_buf_print): Likewise.
955 * lisp.h (pop_message, set_message, check_point_in_composition):
957 * xterm.h (set_vertical_scroll_bar): Likewise.
958 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
959 (message_buf_print, scratch_glyph_row, displayed_buffer):
960 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
961 (get_next_display_element, show_mouse_face, window_box_edges):
962 (frame_to_window_pixel_xy, check_point_in_composition):
963 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
964 (glyph_to_pixel_coords): Remove; unused.
966 * dired.c (file_name_completion): Now static.
968 * dbusbind.c (xd_in_read_queued_messages): Now static.
970 * lisp.h (circular_list_error, FOREACH): Remove; unused.
971 * data.c (circular_list_error): Remove.
973 * commands.h (last_point_position, last_point_position_buffer):
974 (last_point_position_window): Remove decls.
975 * keyboard.c: Make these variables static.
977 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
979 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
980 (iso_code_class, detect_coding, code_convert_region): Now static.
981 (encode_coding_gap): Remove; unused.
983 * chartab.c (chartab_chars, chartab_bits): Now static.
985 * charset.h (charset_iso_8859_1): Remove decl.
986 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
989 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
990 * ccl.c (Vccl_program_table): Now static.
991 (check_ccl_update): Remove; unused.
993 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
994 * category.h: ... from here.
995 * category.c (check_category_table, set_category_set): Now static.
997 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
998 * lisp.h: Remove these decls.
1000 * buffer.c (buffer_count): Remove unused var.
1002 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1003 so that it's not optimized away.
1004 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1005 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1006 exported only to the debugger.
1008 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1009 * atimer.h (run_all_atimers): Removed; not exported.
1011 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1012 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1013 was inaccessible from Lisp.
1014 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1015 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1017 alloc.c: Import and export fewer symbols, and remove unused items.
1018 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1020 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1021 it's not optimized away by whole-program optimization.
1022 (message_enable_multibyte, free_misc): Remove.
1023 (catchlist, handlerlist, mark_backtrace):
1024 Declare only if BYTE_MARK_STACK.
1025 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1026 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1027 (message_enable_multibyte): Remove decl.
1028 (free_misc, interval_free_list, float_block, float_block_index):
1029 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1030 (cons_free_list, last_marked_index):
1032 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1033 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1034 (mark_backtrace): Define only if BYTE_MARK_STACK.
1035 * xdisp.c (message_enable_multibyte): Now static.
1037 Declare Lisp_Object Q* variables to be 'static' if not exported.
1038 This makes it easier for human readers (and static analyzers)
1039 to see whether these variables are used from other modules.
1040 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1041 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1042 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1043 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1044 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1045 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1046 * xmenu.c, xselect.c:
1047 Declare Q* vars static if they are not used in other modules.
1048 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1049 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1050 Remove decls of unexported vars.
1051 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1053 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1055 Make Emacs functions such as Fatom 'static' by default.
1056 This makes it easier for human readers (and static analyzers)
1057 to see whether these functions can be called from other modules.
1058 DEFUN now defines a static function. To make the function external
1059 so that it can be used in other C modules, use the new macro DEFUE.
1060 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1061 (Finit_image_library):
1062 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1063 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1064 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1065 Remove decls, since these functions are now static.
1066 (Funintern, Fget_internal_run_time): New decls, since these functions
1067 were already external.
1069 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1070 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1071 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1072 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1073 * keyboard.c, keymap.c, lread.c:
1074 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1075 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1076 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1077 Mark functions with DEFUE instead of DEFUN,
1078 if they are used in other modules.
1079 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1080 decls for now-static functions.
1081 * buffer.h (Fdelete_overlay): Remove decl.
1082 * callproc.c (Fgetenv_internal): Mark as internal.
1083 * composite.c (Fremove_list_of_text_properties): Remove decl.
1084 (Fcomposition_get_gstring): New forward static decl.
1085 * composite.h (Fcomposite_get_gstring): Remove decl.
1086 * dired.c (Ffile_attributes): New forward static decl.
1087 * doc.c (Fdocumntation_property): New forward static decl.
1088 * eval.c (Ffetch_bytecode): New forward static decl.
1089 (Funintern): Remove extern decl; now in .h file where it belongs.
1090 * fileio.c (Fmake_symbolic_link): New forward static decl.
1091 * image.c (Finit_image_library): New forward static decl.
1092 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1093 * intervals.h (Fprevious_property_change):
1094 (Fremove_list_of_text_properties): Remove decls.
1095 * keyboard.c (Fthis_command_keys): Remove decl.
1096 (Fcommand_execute): New forward static decl.
1097 * keymap.c (Flookup_key): New forward static decl.
1098 (Fcopy_keymap): Now static.
1099 * keymap.h (Flookup_key): Remove decl.
1100 * process.c (Fget_process): New forward static decl.
1101 (Fprocess_datagram_address): Mark as internal.
1102 * syntax.c (Fsyntax_table_p): New forward static decl.
1103 (skip_chars): Remove duplicate decl.
1104 * textprop.c (Fprevious_property_change): New forward static decl.
1105 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1107 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1108 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1110 * editfns.c (Fformat): Remove unreachable code.
1112 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1114 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1117 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1119 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1120 when at ZV. (Bug#8487)
1122 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1124 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1126 * keyboard.c (parse_tool_bar_item): Likewise.
1127 * sound.c (sound_cleanup, alsa_close): Likewise.
1128 * termcap.c (tgetent): Likewise.
1129 * xfns.c (x_default_font_parameter): Likewise.
1130 * xsettings.c (read_and_apply_settings): Likewise.
1132 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1133 (overrun_check_free): Protoize.
1135 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1137 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1138 since callers should never pass a negative size.
1139 Change the signature to match that of plain 'read' and 'write'; see
1140 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1141 * lisp.h: Update prototypes of emacs_write and emacs_read.
1143 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1145 * xdisp.c (redisplay_window): Don't try to determine the character
1146 position of the scroll margin if the window start point w->startp
1147 is outside the buffer's accessible region. (Bug#8468)
1149 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1151 Fix write-region and its subroutines for buffers > 2GB.
1152 * fileio.c (a_write, e_write): Modify declaration of arguments and
1153 local variables to support buffers larger than 2GB.
1154 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1156 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1157 argument, local variables, and return value.
1159 * lisp.h: Update prototypes of emacs_write and emacs_read.
1161 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1163 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1165 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1167 Fix more problems found by GCC 4.6.0's static checks.
1169 * xdisp.c (vmessage): Use a better test for character truncation.
1171 * charset.c (load_charset_map): <, not <=, for optimization,
1172 and to avoid potential problems with integer overflow.
1173 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1174 * casetab.c (set_identity, shuffle): Likewise.
1175 * editfns.c (Fformat): Likewise.
1176 * syntax.c (skip_chars): Likewise.
1178 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1179 This also lets GCC 4.6.0 generate slightly better loop code.
1181 * callint.c (Fcall_interactively): <, not <=, for optimization.
1182 (Fcall_interactively): Count the number of arguments produced,
1183 not the number of arguments given. This is simpler and lets GCC
1184 4.6.0 generate slightly better code.
1186 * ftfont.c: Distingish more carefully between FcChar8 and char.
1187 The previous code passed unsigned char * to a functions like
1188 strlen and xstrcasecmp that expect char *, which does not
1189 conform to the C standard.
1190 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1191 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1192 char * when the C standard requires it.
1194 * keyboard.c (read_char): Remove unused var.
1196 * eval.c: Port to Windows vsnprintf (Bug#8435).
1198 (SIZE_MAX): Define if the headers do not.
1199 (verror): Do not give up if vsnprintf returns a negative count.
1200 Instead, grow the buffer. This ports to Windows vsnprintf, which
1201 does not conform to C99. Problem reported by Eli Zaretskii.
1202 Also, simplify the allocation scheme, by avoiding the need for
1203 calling realloc, and removing the ALLOCATED variable.
1205 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1207 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1208 But keep the doprint source code for now, as we might revamp it
1209 and use it again (Bug#8435).
1210 * lisp.h (doprnt): Remove.
1211 * Makefile.in (base_obj): Remove doprnt.o.
1212 * deps.mk (doprnt.o): Remove.
1214 error: Print 32- and 64-bit integers portably (Bug#8435).
1215 Without this change, on typical 64-bit hosts error ("...%d...", N)
1216 was used to print both 32- and 64-bit integers N, which relied on
1218 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1220 * lisp.h (error, verror): Mark as printf-like functions.
1221 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1222 Report overflow in size calculations when allocating printf buffer.
1223 Do not truncate output string at its first null byte.
1224 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1225 Truncate the output at a character boundary, since vsnprintf does not
1227 * charset.c (check_iso_charset_parameter): Convert internal
1228 character to string before calling 'error', since %c now has the
1230 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1231 overflow when computing char to be passed to 'error'. Do not
1232 pass Lisp_Object to 'error'; pass the integer instead.
1233 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1234 formatted with plain %d.
1236 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1238 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1240 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1242 * xterm.c (x_catch_errors): Remove duplicate declaration.
1244 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1246 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1248 2011-04-10 Jim Meyering <meyering@redhat.com>
1250 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1251 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1252 return ssize_t not "int", and use size_t as the buffer length.
1253 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1254 * gnutls.h: Update declarations.
1255 * process.c (read_process_output): Use ssize_t, to match.
1256 (send_process): Likewise.
1258 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1260 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1262 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1264 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1265 unsigned char, to match FcChar8 type definition.
1267 * xterm.c (handle_one_xevent):
1268 * xmenu.c (create_and_show_popup_menu):
1269 * xselect.c (x_decline_selection_request)
1270 (x_reply_selection_request): Avoid type-punned deref of X events.
1272 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1274 Fix some uses of `int' instead of EMACS_INT.
1275 * search.c (string_match_1, fast_string_match)
1276 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1277 (scan_buffer, find_next_newline_no_quit)
1278 (find_before_next_newline, search_command, Freplace_match)
1279 (Fmatch_data): Make some `int' variables be EMACS_INT.
1281 * xdisp.c (display_count_lines): 3rd argument and return value now
1282 EMACS_INT. All callers changed.
1283 (pint2hrstr): Last argument is now EMACS_INT.
1285 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1286 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1287 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1288 (decode_coding_utf_16, decode_coding_emacs_mule)
1289 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1290 (decode_coding_ccl, decode_coding_charset)
1291 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1292 (decode_coding_iso_2022, decode_coding_emacs_mule)
1293 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1294 <char_offset, last_offset>: Declare EMACS_INT.
1295 (encode_coding_utf_8, encode_coding_utf_16)
1296 (encode_coding_emacs_mule, encode_invocation_designation)
1297 (encode_designation_at_bol, encode_coding_iso_2022)
1298 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1299 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1301 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1302 (encode_invocation_designation): Last argument P_NCHARS is now
1304 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1305 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1307 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1310 * ccl.c (Fccl_execute_on_string): Declare some variables
1313 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1315 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1317 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1319 * process.c (Fformat_network_address): Doc fix.
1321 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1323 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1325 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1327 * keyboard.c (read_char): Call Lisp function help-form-show,
1328 instead of using internal_with_output_to_temp_buffer.
1329 (Qhelp_form_show): New var.
1330 (syms_of_keyboard): Use DEFSYM macro.
1332 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1334 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1336 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1338 * process.c (Flist_processes): Removed to Lisp.
1339 (list_processes_1): Deleted.
1341 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1343 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1345 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1347 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1349 Fix more problems found by GCC 4.6.0's static checks.
1351 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1353 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1355 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1357 * xdisp.c (vmessage): Mark as a printf-like function.
1359 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1361 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1363 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1364 printf-like functions.
1365 (tiff_load): Add casts to remove these marks before passing them
1366 to system-supplied API.
1368 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1370 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1371 This avoids several warnings with gcc -Wstrict-overflow.
1372 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1373 directly, rather than having caller test rule sign. This avoids
1374 some unnecessary tests.
1375 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1376 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1377 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1379 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1380 (xfont_open): Avoid unnecessary tests.
1382 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1384 * composite.h, composite.c (composition_gstring_put_cache):
1385 Use EMACS_INT, not int, for length.
1387 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1388 breaking out part of COMPOSITION_DECODE_RULE.
1389 (COMPOSITION_DECODE_RULE): Use it.
1390 * composite.c (get_composition_id): Remove unused local vars,
1391 by using the new macro.
1393 * textprop.c (set_text_properties_1): Change while to do-while,
1394 since the condition is always true at first.
1396 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1397 (interval_deletion_adjustment): Return unsigned value.
1400 * process.c (list_processes_1, create_pty, read_process_output):
1401 (exec_sentinel): Remove vars that were set but not used.
1402 (create_pty): Remove unnecessary "volatile"s.
1403 (Fnetwork_interface_info): Avoid possibility of int overflow.
1404 (read_process_output): Do adaptive read buffering even if carryover.
1405 (read_process_output): Simplify nbytes computation if buffered.
1407 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1409 * syntax.c (scan_words): Remove var that was set but not used.
1410 (update_syntax_table): Use unsigned instead of int.
1412 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1413 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1414 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1416 * print.c (print_error_message): Avoid int overflow.
1418 * font.c (font_list_entities): Redo for clarity,
1419 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1421 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1422 (font_score): Avoid potential overflow in diff calculation.
1424 * fns.c (substring_both): Remove var that is set but not used.
1425 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1427 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1429 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1430 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1431 can always succeed if overflow has undefined behavior.
1433 * search.c (boyer_moore, wordify): Remove vars set but not used.
1434 (wordify): Omit three unnecessary tests.
1436 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1437 All callers changed. This avoids the need for an unused var.
1439 * casefiddle.c (casify_region): Remove var that is set but not used.
1441 * dired.c (file_name_completion): Remove var that is set but not used.
1443 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1445 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1446 (Finsert_file_contents): Remove unnecessary code checking fd.
1448 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1449 Check for integer overflow on size calculations.
1451 * buffer.c (Fprevious_overlay_change): Remove var that is set
1454 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1455 Remove vars that are set but not used.
1456 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1457 (timer_check_2): Mark vars as initialized.
1459 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1461 * image.c (lookup_image): Remove var that is set but not used.
1462 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1464 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1465 that are set but not used.
1467 * xfns.c (make_invisible_cursor): Don't return garbage
1468 if XCreateBitmapFromData fails (Bug#8410).
1470 * xselect.c (x_get_local_selection, x_handle_property_notify):
1471 Remove vars that are set but not used.
1473 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1474 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1476 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1477 Remove var that is set but not used.
1478 (scroll_bar_windows_size): Now size_t, not int.
1479 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1482 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1483 (map_tty_color) [!defined MSDOS]: Likewise.
1485 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1487 * coding.c: Remove vars that are set but not used.
1488 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1489 All callers changed.
1490 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1491 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1492 (decode_coding_charset): Remove vars that are set but not used.
1494 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1495 that is set but not used.
1497 * print.c (print_object): Remove var that is set but not used.
1499 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1500 The gnulib version avoids calling malloc in the usual case,
1501 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1502 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1503 * filelock.c (current_lock_owner): Likewise.
1504 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1505 * sysdep.c: Include allocator.h, careadlinkat.h.
1506 (emacs_no_realloc_allocator): New static constant.
1507 (emacs_readlink): New function.
1508 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1509 ../lib/careadlinkat.h.
1511 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1513 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1514 first non-nil return value).
1516 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1518 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1519 if not defined (Bug#8403).
1521 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1523 * xdisp.c (display_count_lines): Remove parameter `start',
1524 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1525 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1526 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1527 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1528 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1529 and thereabouts. All callers changed.
1530 (get_per_char_metric): Remove parameter `f', unused since
1531 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1533 2011-04-02 Jim Meyering <meyering@redhat.com>
1535 do not dereference NULL upon failed strdup
1536 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1537 (ns_get_family): Likewise.
1539 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1541 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1543 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1545 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1548 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1550 Add lexical binding.
1552 * window.c (Ftemp_output_buffer_show): New fun.
1553 (Fsave_window_excursion):
1554 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1556 * lread.c (lisp_file_lexically_bound_p): New function.
1557 (Fload): Bind Qlexical_binding.
1558 (readevalloop): Remove `evalfun' arg.
1559 Bind Qinternal_interpreter_environment.
1560 (Feval_buffer): Bind Qlexical_binding.
1561 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1563 (syms_of_lread): Declare `lexical-binding'.
1565 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1567 * keyboard.c (eval_dyn): New fun.
1568 (menu_item_eval_property): Use it.
1570 * image.c (parse_image_spec): Use Ffunctionp.
1572 * fns.c (concat, mapcar1): Accept byte-code-functions.
1574 * eval.c (Fsetq): Handle lexical vars.
1575 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1576 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1577 (FletX, Flet): Obey lexical binding.
1578 (Fcommandp): Handle closures.
1579 (Feval): New `lexical' arg.
1580 (eval_sub): New function extracted from Feval. Use it almost
1581 everywhere where Feval was used. Look up vars in lexical env.
1583 (Ffunctionp): Move from subr.el.
1584 (Ffuncall): Handle closures.
1585 (apply_lambda): Remove `eval_flags'.
1586 (funcall_lambda): Handle closures and new byte-code-functions.
1587 (Fspecial_variable_p): New function.
1588 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1589 but without exporting it to Lisp.
1591 * doc.c (Fdocumentation, store_function_docstring):
1592 * data.c (Finteractive_form): Handle closures.
1594 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1597 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1599 (exec_byte_code): New function extracted from Fbyte_code to handle new
1600 calling convention for byte-code-functions. Add new byte-codes.
1602 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1604 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1606 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1608 * xdisp.c (redisplay_internal): Fix prototype.
1610 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1612 * xdisp.c (SCROLL_LIMIT): New macro.
1613 (try_scrolling): Use it when setting scroll_limit. Limit
1614 scrolling to 100 screen lines.
1615 (redisplay_window): Even when falling back on "recentering",
1616 position point in the window according to scroll-conservatively,
1617 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1619 (try_scrolling): When point is above the window, allow searching
1620 as far as scroll_max, or one screenful, to compute vertical
1621 distance from PT to the scroll margin position. This prevents
1622 try_scrolling from unnecessarily failing when
1623 scroll-conservatively is set to a value slightly larger than the
1624 window height. Clean up the case of PT below the margin at bottom
1625 of window: scroll_max can no longer be INT_MAX. When aggressive
1626 scrolling is in use, don't let point enter the opposite scroll
1627 margin as result of the scroll.
1628 (syms_of_xdisp) <scroll-conservatively>: Document the
1629 threshold of 100 lines for never-recentering scrolling.
1631 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1633 * dispextern.h (move_it_by_lines):
1634 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1635 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1636 (message_log_check_duplicate): Remove parameters `prev_bol' and
1637 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1638 (redisplay_internal): Remove parameter `preserve_echo_area',
1639 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1641 * indent.c (Fvertical_motion):
1642 * window.c (window_scroll_pixel_based, Frecenter):
1643 Don't pass `need_y_p' to `move_it_by_lines'.
1645 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1647 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1648 steal a few bits to be more compact.
1649 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1650 Remove unneeded casts.
1652 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1654 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1656 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1657 binding" message (bug#7967).
1659 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1661 Fix more problems found by GCC 4.6.0's static checks.
1663 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1664 Remove unused local var.
1666 * editfns.c (Fmessage_box): Remove unused local var.
1668 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1669 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1670 Omit unused local vars.
1671 * window.c (shrink_windows): Omit unused local var.
1672 * menu.c (digest_single_submenu): Omit unused local var.
1673 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1674 Omit unused local var.
1676 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1677 Don't assume string length fits in int.
1678 (keyremap_step, read_key_sequence): Use size_t for sizes.
1679 (read_key_sequence): Don't check last_real_key_start redundantly.
1681 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1682 instead of alloca (Bug#8344).
1684 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1685 (Fbacktrace_frame): Don't assume nframes fits in int.
1687 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1689 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1692 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1694 * cm.c (calccost): Turn while-do into do-while, for clarity.
1696 * keyboard.c (syms_of_keyboard): Use the same style as later
1697 in this function when indexing through an array. This also
1698 works around GCC bug 48267.
1700 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1702 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1704 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1705 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1707 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1708 This avoids undefined behavior on integer overflow, and is a bit
1709 more convenient anyway since it is compared to a size_t variable.
1711 Variadic C functions now count arguments with size_t, not int.
1712 This avoids an unnecessary limitation on 64-bit machines, which
1713 caused (substring ...) to crash on large vectors (Bug#8344).
1714 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1715 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1716 All variadic functions and their callers changed accordingly.
1717 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1718 * data.c (arith_driver, float_arith_driver): Likewise.
1719 * editfns.c (general_insert_function): Likewise.
1720 * eval.c (struct backtrace.nargs, interactive_p)
1721 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1722 (funcall_lambda, mark_backtrace): Likewise.
1723 * fns.c (concat): Likewise.
1724 * frame.c (x_set_frame_parameters): Likewise.
1725 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1726 0 if not found, not -1. All callers changed.
1728 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1729 (stack_copy_size): Now size_t, not int.
1730 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1732 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1734 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1735 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1736 All callers changed.
1738 * lisp.h (multibyte_char_to_unibyte):
1739 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1740 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1741 * character.h (CHAR_TO_BYTE8):
1742 * cmds.c (internal_self_insert):
1743 * editfns.c (general_insert_function):
1744 * keymap.c (push_key_description):
1745 * search.c (Freplace_match):
1746 * xdisp.c (message_dolog, set_message_1): All callers changed.
1748 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1750 * keyboard.c (safe_run_hook_funcall): New function.
1751 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1752 don't set the hook to nil, but remove the offending function instead.
1753 (Qcommand_hook_internal): Remove, unused.
1754 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1755 Vcommand_hook_internal.
1757 * eval.c (enum run_hooks_condition): Remove.
1758 (funcall_nil, funcall_not): New functions.
1759 (run_hook_with_args): Call each function through a `funcall' argument.
1760 Remove `cond' argument, now redundant.
1761 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1762 (Frun_hook_with_args_until_failure): Adjust accordingly.
1763 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1765 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1767 * dispextern.h (string_buffer_position): Remove declaration.
1769 * print.c (strout): Remove parameter `multibyte', unused since
1770 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1772 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1773 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1774 All callers changed.
1776 * w32.c (_wsa_errlist): Use braces for struct initializers.
1778 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1779 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1780 All callers changed.
1781 (string_buffer_position): Likewise. Also, make static (it's never
1782 used outside xdisp.c).
1783 (cursor_row_p): Remove parameter `w', unused since
1784 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1785 (decode_mode_spec): Remove parameter `precision', introduced during
1786 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1787 All callers changed.
1789 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1791 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1793 2011-03-27 Anders Lindgren <andlind@gmail.com>
1795 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1796 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1797 (ns_update_auto_hide_menu_bar): New functions.
1798 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1799 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1800 ns_constrain_all_frames.
1801 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1802 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1804 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1806 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1808 2011-03-27 Glenn Morris <rgm@gnu.org>
1810 * syssignal.h: Replace RETSIGTYPE with void.
1811 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1812 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1813 Replace SIGTYPE with void everywhere.
1814 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1815 * s/template.h (SIGTYPE): Remove commented out definition.
1817 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1819 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1820 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1822 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1824 * w32.c (read_unc_volume): Use parameter `henum', instead of
1825 global variable `wget_enum_handle'.
1827 * keymap.c (describe_vector): Remove parameters `indices' and
1828 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1829 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1831 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1833 * keyboard.c (timer_check): Remove parameter `do_it_now',
1834 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1835 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1836 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1838 * keyboard.c (read_char):
1839 * w32menu.c (w32_menu_display_help):
1840 * xmenu.c (show_help_event, menu_help_callback):
1841 Adjust calls to `show_help_echo'.
1843 * gtkutil.c (xg_maybe_add_timer):
1844 * keyboard.c (readable_events):
1845 * process.c (wait_reading_process_output):
1846 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1848 * insdel.c (adjust_markers_gap_motion):
1849 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1850 (gap_left, gap_right): Don't call it.
1852 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1854 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1855 incurred during fontification.
1857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1859 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1860 (DEFVAR_PER_BUFFER): Don't pass it.
1862 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1863 (scrolling_window): Don't pass it.
1865 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1867 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1869 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1871 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1872 of variables specific to SELinux and computation of `encoded_absname'.
1874 * image.c (XPutPixel): Remove unused variable `height'.
1876 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1878 * unexw32.c (get_section_info): Remove unused variable `section'.
1880 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1881 (system_process_attributes): Remove unused variable `sess'.
1882 (sys_read): Remove unused variable `err'.
1884 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1885 (w32_wnd_proc): Remove unused variable `isdead'.
1886 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1887 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1888 (x_create_tip_frame): Remove unused variable `tem'.
1890 * w32inevt.c (w32_console_read_socket):
1891 Remove unused variable `no_events'.
1893 * w32term.c (x_draw_composite_glyph_string_foreground):
1894 Remove unused variable `width'.
1896 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1898 * w32term.c (x_set_glyph_string_clipping):
1899 Don't pass uninitialized region to CombineRgn.
1901 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1903 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1904 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1905 (Fx_close_connection): Remove unused variable `i'.
1907 * w32font.c (w32font_draw): Return number of glyphs.
1908 (w32font_open_internal): Remove unused variable `i'.
1909 (w32font_driver): Add missing initializer.
1911 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1912 (fill_in_menu): Remove unused variable `items_added'.
1914 * w32term.c (last_mouse_press_frame): Remove static global variable.
1915 (w32_clip_to_row): Remove unused variable `f'.
1916 (x_delete_terminal): Remove unused variable `i'.
1918 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1919 (NOTHING): Remove unused static global variable.
1920 (uniscribe_check_otf): Remove unused variable `table'.
1921 (uniscribe_font_driver): Add missing initializers.
1923 2011-03-23 Julien Danjou <julien@danjou.info>
1925 * term.c (Fsuspend_tty, Fresume_tty):
1926 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1927 * window.c (temp_output_buffer_show):
1928 * insdel.c (signal_before_change):
1929 * frame.c (Fhandle_switch_frame):
1930 * fileio.c (Fdo_auto_save):
1931 * emacs.c (Fkill_emacs):
1932 * editfns.c (save_excursion_restore):
1933 * cmds.c (internal_self_insert):
1934 * callint.c (Fcall_interactively):
1935 * buffer.c (Fkill_all_local_variables):
1936 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1938 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1939 unconditionnaly since it does the check itself.
1941 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1943 Fix more problems found by GCC 4.5.2's static checks.
1945 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1946 the first time through the loop, since we know p0 < p1 then.
1947 This also avoids a gcc -Wstrict-overflow warning.
1949 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1950 leading to a memory leak, possible in functions like
1951 load_charset_map_from_file that can allocate an unbounded number
1952 of objects (Bug#8318).
1954 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1955 that could (at least in theory) be that large.
1957 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1958 This is less likely to overflow, and avoids undefined behavior if
1959 overflow does occur. All callers changed. Use strtoul to scan
1960 for the unsigned long integer.
1961 (pint2hrstr): Simplify and tune code slightly.
1962 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1964 * scroll.c (do_scrolling): Work around GCC bug 48228.
1965 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1967 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1968 This also avoids a warning with gcc -Wstrict-overflow.
1969 (validate_x_resource_name): Simplify count usage.
1970 This also avoids a warning with gcc -Wstrict-overflow.
1972 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1975 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1977 * process.c (Fmake_network_process): Use socklen_t, not int,
1978 where POSIX says socklen_t is required in portable programs.
1979 This fixes a porting bug on hosts like 64-bit HP-UX, where
1980 socklen_t is wider than int (Bug#8277).
1981 (Fmake_network_process, server_accept_connection):
1982 (wait_reading_process_output, read_process_output):
1985 * process.c: Rename or move locals to avoid shadowing.
1986 (list_processes_1, Fmake_network_process):
1987 (read_process_output_error_handler, exec_sentinel_error_handler):
1988 Rename or move locals.
1989 (Fmake_network_process): Define label "retry_connect" only if needed.
1990 (Fnetwork_interface_info): Fix pointer signedness.
1991 (process_send_signal): Add cast to avoid pointer signedness problem.
1992 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1993 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1995 Make tparam.h and terminfo.c consistent.
1996 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1997 Include tparam.h instead, since it declares them.
1998 * cm.h (PC): Remove extern decl; tparam.h now does this.
1999 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2000 * terminfo.c: Include tparam.h, to check interfaces.
2001 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2002 (tparam): Adjust signature to match interface in tparam.h;
2003 this removes some undefined behavior. Check that outstring and len
2004 are zero, which they always are with Emacs.
2005 * tparam.h (PC, BC, UP): New extern decls.
2007 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2008 (xftfont_open): Rename locals to avoid shadowing.
2010 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2011 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2012 (OTF_TAG_SYM): Omit macro if not needed.
2013 (ftfont_list): Remove unused local.
2014 (get_adstyle_property, ftfont_pattern_entity):
2015 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2016 Rename locals to avoid shadowing.
2018 * xfont.c (xfont_list_family): Mark var as initialized.
2020 * xml.c (make_dom): Now static.
2022 * composite.c (composition_compute_stop_pos): Rename local to
2024 (composition_reseat_it): Remove unused locals.
2025 (find_automatic_composition, composition_adjust_point): Likewise.
2026 (composition_update_it): Mark var as initialized.
2027 (find_automatic_composition): Mark vars as initialized,
2028 with a FIXME (Bug#8290).
2030 character.h: Rename locals to avoid shadowing.
2031 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2032 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2033 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2034 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2037 * textprop.c (property_change_between_p): Remove; unused.
2039 * intervals.c (interval_start_pos): Now static.
2041 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2043 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2044 Rename locals to avoid shadowing.
2046 * sound.c (wav_play, au_play, Fplay_sound_internal):
2047 Fix pointer signedness.
2048 (alsa_choose_format): Remove unused local var.
2049 (wav_play): Initialize a variable to 0, to prevent undefined
2050 behavior (Bug#8278).
2052 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2054 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2056 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2057 clobbering (Bug#8298).
2058 * sysdep.c (sys_subshell): Likewise.
2059 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2061 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2062 This should get cleaned up, so that child_setup has the
2063 same signature on all platforms.
2065 * callproc.c (call_process_cleanup): Now static.
2066 (relocate_fd): Rename locals to avoid shadowing.
2068 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2070 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2071 not to be necessary, and produces flickering.
2073 2011-03-20 Glenn Morris <rgm@gnu.org>
2075 * config.in: Remove file.
2077 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2079 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2080 are now in src/globals.h.
2081 (syms_of_minibuf): Remove spurious & from previous change.
2083 2011-03-20 Leo <sdl.web@gmail.com>
2085 * minibuf.c (completing-read-function): New variable.
2086 (completing-read-default): Rename from completing-read.
2087 (completing-read): Call completing-read-function.
2089 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2091 * xfaces.c (Fx_load_color_file):
2092 Read color file from absolute filename (bug#8250).
2094 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2096 * makefile.w32-in: Update dependencies.
2098 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2100 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2102 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2104 Fix more problems found by GCC 4.5.2's static checks.
2106 * process.c (make_serial_process_unwind, send_process_trap):
2107 (sigchld_handler): Now static.
2109 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2110 That way, the code declares only the vars that it needs.
2111 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2112 * s/cygwin.h (PTY_ITERATION): Likewise.
2113 * s/darwin.h (PTY_ITERATION): Likewise.
2114 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2116 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2117 * process.c (allocate_pty): Don't declare stb unless it's needed.
2119 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2120 (CONSTANTLIM): Remove; unused.
2121 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2122 Define only if needed.
2124 * unexelf.c (unexec): Name an expression,
2125 to avoid gcc -Wbad-function-cast warning.
2126 Use a different way to cause a compilation error if anyone uses
2127 n rather than nn, a way that does not involve shadowing.
2128 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2130 * deps.mk (unexalpha.o): Remove; unused.
2132 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2133 * unexec.h: New file.
2134 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2135 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2137 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2138 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2139 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2140 Change as necessary to match prototype in unexec.h.
2142 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2144 (back_comment, skip_chars): Mark vars as initialized.
2146 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2147 Rename locals to avoid shadowing.
2149 * lread.c (read1): Rewrite so as not to use empty "else".
2150 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2152 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2154 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2155 warning when compiling print.c.
2157 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2158 instead of using an uninitialized var.
2159 (font_sort_entities): Mark var as initialized.
2161 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2163 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2164 pointers to constants.
2165 (font_parse_fcname): Remove unused vars.
2166 (font_delete_unmatched): Now static.
2167 (font_get_spec): Remove; unused.
2168 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2169 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2170 Rename or move locals to avoid shadowing.
2172 * fns.c (require_nesting_list, require_unwind): Now static.
2173 (Ffillarray): Rename locals to avoid shadowing.
2175 * floatfns.c (domain_error2): Define only if needed.
2176 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2178 * alloc.c (mark_backtrace): Move decl from here ...
2179 * lisp.h: ... to here, so that it can be checked.
2181 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2182 (Fdefvar): Rewrite so as not to use empty "else".
2183 (lisp_indirect_variable): Name an expression,
2184 to avoid gcc -Wbad-function-cast warning.
2185 (Fdefvar): Rename locals to avoid shadowing.
2187 * callint.c (quotify_arg, quotify_args): Now static.
2188 (Fcall_interactively): Rename locals to avoid shadowing.
2189 Use const pointer when appropriate.
2191 * lisp.h (get_system_name, get_operating_system_release):
2192 Move decls here, to check interfaces.
2193 * process.c (get_operating_system_release): Move decl to lisp.h.
2194 * xrdb.c (get_system_name): Likewise.
2195 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2196 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2197 some of which prompt warnings from gcc -Wbad-function-cast.
2198 (Fformat_time_string, Fencode_time, Finsert_char):
2199 (Ftranslate_region_internal, Fformat):
2200 Rename or remove local vars to avoid shadowing.
2201 (Ftranslate_region_internal): Mark var as initialized.
2203 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2206 * lisp.h (eassert): Check that the argument compiles, even if
2207 ENABLE_CHECKING is not defined.
2209 * data.c (Findirect_variable): Name an expression, to avoid
2210 gcc -Wbad-function-cast warning.
2211 (default_value, arithcompare, arith_driver, arith_error): Now static.
2212 (store_symval_forwarding): Rename local to avoid shadowing.
2213 (Fmake_variable_buffer_local, Fmake_local_variable):
2214 Mark variables as initialized.
2215 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2217 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2218 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2219 Rename locals to avoid shadowing.
2220 (mark_stack): Move local variables into the #ifdef region where
2222 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2223 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2225 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2226 (GC_STRING_CHARS): Remove; not used.
2227 (Fmemory_limit): Cast sbrk's returned value to char *.
2229 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2230 avoids undefined behavior in theory.
2232 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2234 Use functions, not macros, for up- and down-casing (Bug#8254).
2235 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2236 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2237 to use the following functions instead of these macros.
2238 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2239 EMACS_INT, since callers assume the returned value fits in int.
2240 (upcase1): Likewise, for UPCASE_TABLE.
2241 (uppercasep, lowercasep, upcase): New static inline functions.
2242 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2243 the race-condition problem in the old DOWNCASE.
2245 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2246 Rename locals to avoid shadowing.
2247 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2248 (regex_compile, re_search_2, re_match_2_internal):
2249 Remove unused local vars.
2250 (FREE_VAR): Rewrite so as not to use empty "else",
2251 which gcc can warn about.
2252 (regex_compile, re_match_2_internal): Mark locals as initialized.
2253 (RETALLOC_IF): Define only if needed.
2254 (WORDCHAR_P): Likewise. This one is never needed, but is used
2255 only in a comment talking about a compiler bug, so put inside
2256 the #if 0 of that comment.
2257 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2258 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2261 * search.c (boyer_moore): Rename locals to avoid shadowing.
2262 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2263 (PREV_CHAR_BOUNDARY): Likewise.
2265 * search.c (simple_search): Remove unused var.
2267 * dired.c (compile_pattern): Move decl from here ...
2268 * lisp.h: ... to here, so that it can be checked.
2269 (struct re_registers): New forward decl.
2271 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2273 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2275 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2276 Rename locals to avoid shadowing.
2277 (Fvertical_motion): Mark locals as initialized.
2279 * casefiddle.c (casify_object, casify_region): Now static.
2280 (casify_region): Mark local as initialized.
2282 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2284 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2285 New macros, so that the caller can use some names other than
2286 gcpro1, gcpro2, etc.
2287 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2289 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2290 argument, for consistency with GCPRO2_VAR, etc: it is now the
2291 prefix of the variable, not the variable itself. All uses
2293 * dired.c (directory_files_internal, file_name_completion):
2294 Rename locals to avoid shadowing.
2296 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2297 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2298 dired.c's scmp function, had undefined behavior.
2299 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2300 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2301 * buffer.h: ... to here, because these macros use current_buffer,
2302 and the new implementation with inline functions needs to have
2303 current_buffer in scope now, rather than later when the macros
2305 (downcase, upcase1): New static inline functions.
2306 (DOWNCASE, UPCASE1): Reimplement using these functions.
2307 This avoids undefined behavior in expressions like
2308 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2309 from race conditions in accessing the global variables
2310 case_temp1 and case_temp2.
2311 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2312 * lisp.h (case_temp1, case_temp2): Remove their decls.
2313 * character.h (ASCII_CHAR_P): Move from here ...
2314 * lisp.h: ... to here, so that the inline functions mentioned
2317 * dired.c (directory_files_internal_unwind): Now static.
2319 * fileio.c (file_name_as_directory, directory_file_name):
2320 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2322 (file_name_as_directory): Use const pointers when appropriate.
2323 (Fexpand_file_name): Likewise. In particular, newdir might
2324 point at constant storage, so make it a const pointer.
2325 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2326 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2328 (Fset_file_times, Finsert_file_contents, auto_save_error):
2329 Rename locals to avoid shadowing.
2331 * minibuf.c (choose_minibuf_frame_1): Now static.
2332 (Ftry_completion, Fall_completions): Rename or remove locals
2335 * marker.c (bytepos_to_charpos): Remove; unused.
2337 * lisp.h (verify_bytepos, count_markers): New decls,
2338 so that gcc does not warn that these functions aren't declared.
2340 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2341 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2342 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2343 (copy_text): Remove unused local var.
2345 * filelock.c (within_one_second): Now static.
2346 (lock_file_1): Rename local to avoid shadowing.
2348 * buffer.c (fix_overlays_before): Mark locals as initialized.
2349 (fix_start_end_in_overlays): Likewise. This function should be
2350 simplified by using pointers-to-pointers, but that's a different
2352 (switch_to_buffer_1): Now static.
2353 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2354 (report_overlay_modification): Rename locals to avoid shadowing.
2356 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2357 Fix pointer signedness issue.
2358 (sys_subshell): Mark local as volatile if checking for lint,
2359 to suppress a gcc -Wclobbered warning that does not seem to be right.
2360 (MAXPATHLEN): Define only if needed.
2362 * process.c (serial_open, serial_configure): Move decls from here ...
2363 * systty.h: ... to here, so that they can be checked.
2365 * fns.c (get_random, seed_random): Move extern decls from here ...
2366 * lisp.h: ... to here, so that they can be checked.
2368 * sysdep.c (reset_io): Now static.
2369 (wait_for_termination_signal): Remove; unused.
2371 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2372 (copy_keymap_item, append_key, push_text_char_description):
2374 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2375 (DENSE_TABLE_SIZE): Remove; unused.
2376 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2377 (describe_map_tree):
2378 Rename locals to avoid shadowing.
2380 * keyboard.c: Declare functions static if they are not used elsewhere.
2381 (echo_char, echo_dash, cmd_error, top_level_2):
2382 (poll_for_input, handle_async_input): Now static.
2383 (read_char, kbd_buffer_get_event, make_lispy_position):
2384 (make_lispy_event, make_lispy_movement, apply_modifiers):
2385 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2386 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2387 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2388 (read_key_sequence, read_char): Mark locals as initialized.
2389 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2391 * keyboard.h (make_ctrl_char): New decl.
2392 (mark_kboards): Move decl here ...
2393 * alloc.c (mark_kboards): ... from here.
2395 * lisp.h (force_auto_save_soon): New decl.
2397 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2398 (DEFINE_DUMMY_FUNCTION): New macro.
2399 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2401 (main): Add casts to avoid warnings
2402 if GCC considers string literals to be constants.
2404 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2406 * dbusbind.c: Pointer signedness fixes.
2407 (xd_signature, xd_append_arg, xd_initialize):
2408 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2409 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2410 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2411 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2413 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2414 if GCC considers string literals to be constants.
2415 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2417 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2419 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2420 (print_preprocess, print_object): New macro to fix last change.
2422 * print.c (print_preprocess): Don't forget font objects.
2424 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2426 * emacs.c (USAGE3): Doc fixes.
2428 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2430 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2433 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2435 * lisp.h (VWindow_system, Qfile_name_history):
2436 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2437 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2438 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2440 * w32select.c: Don't #include "keyboard.h".
2441 (run_protected): Add extern declaration for waiting_for_input.
2443 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2444 * w32console.c (detect_input_pending, read_input_pending)
2445 (encode_terminal_code):
2446 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2447 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2448 (w32_system_caret_y, Qfile_name_history):
2449 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2450 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2451 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2452 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2453 * w32proc.c (Qlocal, report_file_error):
2454 * w32term.c (Vwindow_system, updating_frame):
2455 * w32uniscribe.c (initialized, uniscribe_font_driver):
2456 Remove unneeded extern declarations.
2458 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2460 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2462 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2464 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2465 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2466 These macros can no longer be used for assignment.
2468 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2469 Assign struct members directly, instead of using BUF_BEGV etc.
2470 (record_buffer_markers, fetch_buffer_markers): New functions for
2471 recording and fetching special buffer markers.
2472 (set_buffer_internal_1, set_buffer_temp): Use them.
2474 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2476 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2478 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2479 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2481 * xdisp.c (hscroll_window_tree):
2482 (reconsider_clip_changes): Use PT instead of BUF_PT.
2484 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2486 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2487 $(EMACS_ROOT)/lib/intprops.h.
2489 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2491 Fix more problems found by GCC 4.5.2's static checks.
2493 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2494 to unsigned char * to avoid compiler diagnostic.
2495 (xg_free_frame_widgets): Make it clear that a local variable is
2496 needed only if USE_GTK_TOOLTIP.
2497 (gdk_window_get_screen): Make it clear that this macro is needed
2498 only if USE_GTK_TOOLTIP.
2499 (int_gtk_range_get_value): New function, which avoids a diagnostic
2500 from gcc -Wbad-function-cast.
2501 (xg_set_toolkit_scroll_bar_thumb): Use it.
2502 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2503 diagnostic from gcc -Wbad-function-cast.
2504 (get_utf8_string, xg_get_file_with_chooser):
2505 Rename locals to avoid shadowing.
2506 (create_dialog): Move locals to avoid shadowing.
2508 * xgselect.c (xg_select): Remove unused var.
2510 * image.c (four_corners_best): Mark locals as initialized.
2511 (gif_load): Initialize transparent_p to zero (Bug#8238).
2512 Mark another local as initialized.
2513 (my_png_error, my_error_exit): Mark with NO_RETURN.
2515 * image.c (clear_image_cache): Now static.
2516 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2517 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2518 (x_edge_detection): Remove unnecessary cast that
2519 gcc -Wbad-function-cast diagnoses.
2520 (gif_load): Fix pointer signedness.
2521 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2522 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2524 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2526 Improve quality of tests for time stamp overflow.
2527 For example, without this patch (encode-time 0 0 0 1 1
2528 1152921504606846976) returns the obviously-bogus value (-948597
2529 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2530 reports time overflow. See
2531 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2532 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2533 * editfns.c: Include limits.h and intprops.h.
2534 (TIME_T_MIN, TIME_T_MAX): New macros.
2535 (time_overflow): Move earlier, to before first use.
2536 (hi_time, lo_time): New functions, for an accurate test for
2538 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2539 (Fget_internal_run_time): Don't assume time_t fits in int.
2540 (make_time): Use list2 instead of Fcons twice.
2541 (Fdecode_time): More accurate test for out-of-range times.
2542 (check_tm_member): New function.
2543 (Fencode_time): Use it, to test for out-of-range times.
2544 (lisp_time_argument): Don't rely on undefined left-shift and
2545 right-shift behavior when checking for time stamp overflow.
2547 * editfns.c (time_overflow): New function, refactoring common code.
2548 (Fformat_time_string, Fdecode_time, Fencode_time):
2549 (Fcurrent_time_string): Use it.
2551 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2552 * dired.c (make_time): Move to ...
2553 * editfns.c (make_time): ... here.
2554 * systime.h: Note the move.
2556 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2558 * fringe.c (update_window_fringes): Remove unused variables.
2560 * unexmacosx.c (copy_data_segment): Also copy __got section.
2563 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2565 * termcap.c [MSDOS]: Include "msdos.h".
2566 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2567 Constify `char *' arguments and their references according to
2568 prototypes in tparam.h.
2570 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2572 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2573 Adapt all references accordingly.
2575 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2577 2011-03-11 Tom Tromey <tromey@redhat.com>
2579 * buffer.c (syms_of_buffer): Remove obsolete comment.
2581 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2583 * termhooks.h (encode_terminal_code): Declare prototype.
2585 * msdos.c (encode_terminal_code): Don't declare prototype.
2587 * term.c (encode_terminal_code): Now external again, used by
2588 w32console.c and msdos.c.
2590 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2591 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2593 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2595 Fix some minor problems found by GCC 4.5.2's static checks.
2597 * fringe.c (update_window_fringes): Mark locals as initialized
2599 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2601 * alloc.c (mark_fringe_data): Move decl from here ...
2602 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2603 to check its interface.
2604 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2606 * fontset.c (free_realized_fontset): Now static.
2607 (Fset_fontset_font): Rename local to avoid shadowing.
2608 (fontset_font): Mark local as initialized.
2609 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2611 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2613 * xselect.c (x_disown_buffer_selections): Remove; not used.
2614 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2615 (x_own_selection, Fx_disown_selection_internal): Rename locals
2617 (x_handle_dnd_message): Remove local to avoid shadowing.
2619 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2620 so that the caller can use some name other than gcpro1.
2621 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2622 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2623 (Fx_backspace_delete_keys_p):
2624 Use them to avoid shadowing, and rename vars to avoid shadowing.
2625 (x_decode_color, x_set_name, x_window): Now static.
2626 (Fx_create_frame): Add braces to silence GCC warning.
2627 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2628 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2629 Remove unused locals.
2630 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2631 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2632 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2635 * xterm.h (x_mouse_leave): New decl.
2637 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2638 Remove unused functions.
2639 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2640 (x_calc_absolute_position): Now static.
2641 (XTread_socket): Don't define label "out" unless it's used.
2642 Don't declare local "event" unless it's used.
2643 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2644 unless they are used.
2645 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2646 (x_fatal_error_signal): Remove; not used.
2647 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2648 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2649 (x_error_catcher, x_connection_closed, x_error_handler):
2650 (x_error_quitter, xembed_send_message, x_iconify_frame):
2651 (my_log_handler): Rename locals to avoid shadowing.
2652 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2653 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2655 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2656 Rename or move locals to avoid shadowing.
2657 (tty_defined_color, merge_face_heights): Now static.
2658 (free_realized_faces_for_fontset): Remove; not used.
2659 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2660 does not deduce is never used uninitialized.
2661 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2662 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2664 * terminal.c (store_terminal_param): Now static.
2666 * xmenu.c (menu_highlight_callback): Now static.
2667 (set_frame_menubar): Remove unused local.
2668 (xmenu_show): Rename parameter to avoid shadowing.
2669 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2670 since they might point to immutable storage.
2671 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2672 since it's unused otherwise.
2674 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2675 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2676 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2677 avoids a gcc -Wuninitialized diagnostic.
2678 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2679 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2680 does not deduce are never used uninitialized.
2682 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2684 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2685 * window.c (window_loop, size_window):
2686 (run_window_configuration_change_hook, enlarge_window): Likewise.
2688 * window.c (display_buffer): Now static.
2689 (size_window): Mark variables that gcc -Wuninitialized
2690 does not deduce are never used uninitialized.
2691 * window.h (check_all_windows): New decl, to forestall
2692 gcc -Wmissing-prototypes diagnostic.
2693 * dispextern.h (bidi_dump_cached_states): Likewise.
2695 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2697 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2699 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2700 and to avoid gcc -Wuninitialized warning.
2701 (load_charset_map): Mark variables that gcc -Wuninitialized
2702 does not deduce are never used uninitialized.
2703 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2705 * coding.c (coding_set_source, coding_set_destination):
2706 Use "else { /* comment */ }" rather than "else /* comment */;"
2707 for clarity, and to avoid gcc -Wempty-body warning.
2708 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2709 a block, when the outer 'i' will do.
2710 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2711 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2712 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2713 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2714 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2715 Rename locals to avoid shadowing.
2716 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2717 * coding.c (emacs_mule_char, encode_invocation_designation):
2718 Now static, since they're not used elsewhere.
2719 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2720 (decode_coding_object, encode_coding_object, detect_coding_system):
2721 (decode_coding_emacs_mule): Mark variables that gcc
2722 -Wuninitialized does not deduce are never used uninitialized.
2723 (detect_coding_iso_2022): Initialize a local variable that might
2724 be used uninitialized. Leave a FIXME because it's not clear that
2725 this initialization is needed. (Bug#8211)
2726 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2727 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2728 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2729 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2730 Remove unused macros.
2732 * category.c (hash_get_category_set): Remove unused local var.
2733 (copy_category_table): Now static, since it's not used elsewhere.
2734 * character.c (string_count_byte8): Likewise.
2736 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2737 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2739 * chartab.c (copy_sub_char_table): Now static, since it's not used
2741 (sub_char_table_ref_and_range, char_table_ref_and_range):
2742 Rename locals to avoid shadowing.
2743 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2745 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2746 (BIDI_BOB): Remove unused macro.
2748 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2749 deduce are never used uninitialized.
2750 * term.c (encode_terminal_code): Likewise.
2752 * term.c (encode_terminal_code): Now static. Remove unused local.
2754 * tparam.h: New file.
2755 * term.c, tparam.h: Include it.
2756 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2757 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2758 Move these decls to tparam.h, and make them agree with what
2759 is actually in tparam.c. The previous trick of using incompatible
2760 decls in different modules does not conform to the C standard.
2761 All callers of tparam changed to use tparam's actual API.
2762 * tparam.c (tparam1, tparam, tgoto):
2763 Use const pointers where appropriate.
2765 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2766 * cm.h (struct cm): Likewise.
2767 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2768 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2769 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2770 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2771 (turn_on_face, init_tty): Likewise.
2772 * termchar.h (struct tty_display_info): Likewise.
2774 * term.c (term_mouse_position): Rename local to avoid shadowing.
2776 * alloc.c (mark_ttys): Move decl from here ...
2777 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2779 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2781 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2783 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2785 * search.c (compile_pattern_1): Remove argument regp, unused since
2786 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2787 (compile_pattern): Don't pass it.
2789 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2791 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2792 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2794 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2796 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2798 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2799 gdk_window_get_screen, gdk_window_get_geometry,
2800 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2801 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2802 (xg_get_pixbuf_from_pixmap): New function.
2803 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2804 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2805 Call xg_get_pixbuf_from_pixmap instead of
2806 gdk_pixbuf_get_from_drawable.
2807 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2808 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2809 (xg_check_special_colors): Use GtkStyleContext and its functions
2811 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2812 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2813 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2814 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2815 Call gtk_widget_get_preferred_size.
2816 (xg_frame_resized): gdk_window_get_geometry only takes 5
2818 (xg_win_to_widget, xg_event_is_for_menubar):
2819 Call gdk_x11_window_lookup_for_display.
2820 (xg_set_widget_bg): New function.
2821 (delete_cb): New function.
2822 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2823 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2824 (xg_set_background_color): Call xg_set_widget_bg.
2825 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2826 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2827 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2828 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2830 (update_frame_tool_bar): Call gtk_widget_hide.
2831 (xg_initialize): Use GDK_KEY_g.
2833 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2835 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2837 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2838 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2839 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2841 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2843 * w32xfns.c (select_palette): Check success of RealizePalette against
2844 GDI_ERROR, not zero.
2846 See ChangeLog.11 for earlier changes.
2852 Copyright (C) 2011 Free Software Foundation, Inc.
2854 This file is part of GNU Emacs.
2856 GNU Emacs is free software: you can redistribute it and/or modify
2857 it under the terms of the GNU General Public License as published by
2858 the Free Software Foundation, either version 3 of the License, or
2859 (at your option) any later version.
2861 GNU Emacs is distributed in the hope that it will be useful,
2862 but WITHOUT ANY WARRANTY; without even the implied warranty of
2863 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2864 GNU General Public License for more details.
2866 You should have received a copy of the GNU General Public License
2867 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.